Timeline



May 29, 2012:

11:37 PM Changeset in webkit [118898] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

[Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
(They only used to check for Skipped in platform/qt-5.0-wk1)
https://bugs.webkit.org/show_bug.cgi?id=87376

Patch by János Badics <János Badics> on 2012-05-29
Reviewed by Csaba Osztrogonác.

  • Scripts/old-run-webkit-tests:

(buildPlatformResultHierarchy):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.baseline_search_path):

11:34 PM Changeset in webkit [118897] by commit-queue@webkit.org
  • 7 edits in trunk

[FileAPI] The result attribute of FileReader shuold use null to replace empty string
https://bugs.webkit.org/show_bug.cgi?id=87578

Patch by Li Yin <li.yin@intel.com> on 2012-05-29
Reviewed by Jian Li.

Source/WebCore:

Spec: http://www.w3.org/TR/FileAPI/#dfn-result
If the readyState is EMPTY (no read method has been called) or an error
in reading the File or Blob has occurred (using any read method), then the
result attribute MUST return null.

Currently, Firefox11, Opera and IE 10 follows the spec, but Webkit based
browser doesn't.
WebKit should change the returned value empty string into null to keep
conformance with the spec.

Tests: fast/files/read-file-async.html

fast/files/workers/worker-read-file-async.html

  • fileapi/FileReader.cpp:

(WebCore::FileReader::arrayBufferResult):
(WebCore::FileReader::stringResult):

LayoutTests:

Spec: http://www.w3.org/TR/FileAPI/#dfn-result
If the readyState is EMPTY (no read method has been called) or an error in
reading the File or Blob has occurred (using any read method), then the result
attribute MUST return null.

Currently, webkit return empty string, not null.

  • fast/files/read-file-async-expected.txt:
  • fast/files/resources/read-common.js:

(logResult):
(loadFailed):

  • fast/files/resources/read-file-test-cases.js:

(testReadAgainAfterFailedReadStep1):

  • fast/files/workers/worker-read-file-async-expected.txt:
11:33 PM Changeset in webkit [118896] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Noticeable delay taking an HTML5 trailer fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=87794

Reviewed by Darin Adler.

Work around a not-entirely understood delay when using the results of a CGWindowListCreateImage()
call as the contents of a placeholder view. The backing of the resulting CGImageRef resides on
the WindowServer, and drawing that image requires synchronous calls to the WindowServer process.
By copying the image data, up front, into our own process, we can avoid those synchronous calls
later and avoid the delay-causing drawing behavior.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(CGImageDeepCopy): Added a helper function which copies the image data into a new CGImage.
(-[WKFullScreenWindowController enterFullScreen:]): Use the above.

11:17 PM Changeset in webkit [118895] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] The Page's deviceScaleFactor() is not being properly maintained
https://bugs.webkit.org/show_bug.cgi?id=87817

Patch by Max Feil <mfeil@rim.com> on 2012-05-29
Reviewed by Antonio Gomes.

This bug fix in WebKit/blackberry is needed by the changes for
fullscreen media control sizing in WebCore (bug 87551). The sizing
of controls depends on the page's deviceScaleFactor(), which was
not being maintained properly due to errors in logic. Viewport
changes from non-default to default were being erroneously
thrown out. Also, when the viewport did change back to default
the deviceScaleFactor was not being updated.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):

10:08 PM Changeset in webkit [118894] by pilgrim@chromium.org
  • 4 edits in trunk/Source

[Chromium] Move fileExists to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=87531

Reviewed by Adam Barth.

Call fileExists through fileUtilities(), not directly.

Source/Platform:

  • chromium/public/Platform.h:

(Platform):

Source/WebCore:

  • platform/chromium/FileSystemChromium.cpp:

(WebCore::fileExists):

9:37 PM Changeset in webkit [118893] by tkent@chromium.org
  • 20 edits
    12 adds
    2 deletes in trunk/LayoutTests

[Chromium] Test expectation update.

Rebaseline for placeholder-related tests.

  • platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Removed.
  • platform/chromium-mac/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-mac/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/css/text-overflow-input-expected.txt:
  • platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/chromium/test_expectations.txt:
9:37 PM Changeset in webkit [118892] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove a dummy style sheet from CSSParser::parseFlowThread()
https://bugs.webkit.org/show_bug.cgi?id=87715

Reviewed by Darin Adler.

r118736 changed CSSGrammar.y so that it works fine with no style sheet.
r118736 removed a dummy style sheet from CSSParser::parserSelector().
Now we can safely remove a dummy style sheet from parserFlowThread().

Tests: fast/regions. No change in test results.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlowThread):

9:34 PM Changeset in webkit [118891] by yosin@chromium.org
  • 5 edits in trunk

REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled
https://bugs.webkit.org/show_bug.cgi?id=87719

Reviewed by Kent Tamura.

Source/WebCore:

This patch added checking of "option" element for CSS pseudo class :enabled as same as
:disabled to selector checker. Before r111497, it was done by using isFormControlElement.
After that revision, HTMLOptionElement was no longer derived from HTMLFormControlElement.

Test: fast/form/select/optgroup-rendering.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Checking element is option element as same
as PseudoDisabled in PseudoEnabled case.

LayoutTests:

  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Updated. Text color of option element is bule from CSS pseudo class option:enabled.
  • platform/chromium/test_expectations.txt: Update comment.
9:20 PM Changeset in webkit [118890] by hayato@chromium.org
  • 5 edits in trunk/Source/WebCore

Introduces ComposedShadowTreeParentWalker, extracted from ComposedShadowTreeWalker.
https://bugs.webkit.org/show_bug.cgi?id=87004

Reviewed by Dimitri Glazkov.

Introduces a ComposedShadowTreeParentWalker, which is only used
for traversing a parent node (including shadow roots and insertion
points) and get rid of an equivalent function from
ComposedShadowTreeWalker.

Before this patch, there is an inconsistency inside of
ComposedShadowTreeWalker. The Walker uses 'Policy' to decide
whether it should visit shadow roots or not, but
parentIncludingInsertionPointAndShadowRoot() member function
ignores the policy. We can not add an assertion in its
constructor due to this inconsistency. To resolve it, we could
add yet another special policy, but that makes the implementation
complex and may add some overhead in runtime. So separate the
functionality into another class as ComposedShadowTreeParentWalker.

No new tests, no new functionality except for assertion.

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeParentWalker::ComposedShadowTreeParentWalker):
(WebCore):
(WebCore::ComposedShadowTreeParentWalker::parentIncludingInsertionPointAndShadowRoot):
(WebCore::ComposedShadowTreeParentWalker::traverseParentIncludingInsertionPointAndShadowRoot):

  • dom/ComposedShadowTreeWalker.h:

(ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeWalker::assertPrecondition):
(WebCore):
(ComposedShadowTreeParentWalker):
(WebCore::ComposedShadowTreeParentWalker::get):

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::adjust):
(WebCore::EventDispatcher::ensureEventAncestors):

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateMouseEventTargetNode):

9:05 PM Changeset in webkit [118889] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

Add assertions to make sure that event's target and relatedTarget are accessible.
https://bugs.webkit.org/show_bug.cgi?id=87641

Reviewed by Dimitri Glazkov.

No new tests. No new functionality except for assertions.

  • dom/EventContext.cpp:

(WebCore::EventContext::EventContext):

  • dom/EventContext.h:

(WebCore):
(EventContext):
(WebCore::EventContext::setRelatedTarget):
(WebCore::EventContext::accessible):

9:03 PM Changeset in webkit [118888] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix inefficient usage of traverseNextNode()
https://bugs.webkit.org/show_bug.cgi?id=87804

Reviewed by Ryosuke Niwa.

foo->traverseNextNode(foo) is equivalent to foo->firstChild(), and
firstChild() is more efficient.

No new tests because of no behavior change.

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
Replace traverseNextNode() with firstChild(), and shorten a variable name.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::getElementById):
Replace traverseNextNode() with firstChild().

8:51 PM Changeset in webkit [118887] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

[BlackBerry] Loading media data with http authentication
https://bugs.webkit.org/show_bug.cgi?id=84214

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-29
Reviewed by George Staikos.

.:

Added a manual test case which needs user to provide a HTTP server
with HTTP authentication support when loading the specified media
resource. The test case will test if the media resource is successfully
loaded.

  • ManualTests/blackberry/video-load-with-authentication.html: Added.

Source/WebCore:

RIM PR: 117618
Implemented http authentication feature for media by implementing
two interface functions in class MediaPlayerPrivate:
onAuthenticationNeeded(): this function is triggered when MMR
engine requires http authentication. We search the CredentialStorage
to see if we have already stored existing credential information,
or challenge user to provide it.
OnAuthenticationAccepted(): this function is triggered when MMR
engine accepts the credential information, and we need to save
it in CredentialStorage for later use.

Internally reviewed by Max Feil <mfeil@qnx.com>.

Manual test case: blackberry/video-load-with-authentication.html

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::generateProtectionSpaceFromMMRAuthChallenge):
(WebCore):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::onAuthenticationAccepted):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

8:33 PM Changeset in webkit [118886] by morrita@google.com
  • 15 edits in trunk/Source/WebCore

[Shadow DOM] Node distribution should be orthogonal from node attachment
https://bugs.webkit.org/show_bug.cgi?id=87223

Reviewed by Dimitri Glazkov.

This chagne reorganizes Shadow DOM subtree distribution implementation.

Originally, it was interleaved across attach() of several classes like
InsertionPoint and ShadowRoot. Its invalidation was also mixed as a part of
the style recalculation and detach()-es.

This change extracts these bits of code to a set of ContentDistributor methods, which are
facaded by two ElementShadow API. Following two API are the primary entry points:

  • ElementShadow::ensureDistribution()
  • ElementShadow::invalidateDistribution()

The actual implementations are ContentDistributor::distribute() and
ContentDistributor::invalidate() respectively.

When clients need to traverse composed tree, before attach() for
example, they should call ensureDistribution() to make sure that
the traversal data structure ("the distribution") is ready. When
there is any DOM mutation which can result a composed tree
mutation, then clients should call invalidateDistribution() to
mark the distribution being dated.

Here are such DOM mutations:

  • The children of any ShadowRoots are changed,
  • The children of any InsertionPoints are changed,
  • The children of any host elements are changed,
  • Any insertion point is inserted to or removed from the shadow tree,
  • @select attribute of <content> is modified and
  • New ShadowRoot is added to the shadow tree.

Note that the validity of the distribution is tracked and
unnecessary distribution requests are ignored.

After the invalidation, that shadow subtrees are detached once and
request their re-attachment through the style recalculation.
Then, on the responding style recalculation and attach(), new
distribution will be computed.

No new tests. Covered by existing tests.

  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::childrenChanged):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::~ElementShadow):
(WebCore::ElementShadow::addShadowRoot):
(WebCore::ElementShadow::removeAllShadowRoots):
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::ensureDistribution):
(WebCore::ElementShadow::invalidateDistribution):

  • dom/ElementShadow.h:

(ElementShadow):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setApplyAuthorStyles):
(WebCore::ShadowRoot::attach):
(WebCore::ShadowRoot::childrenChanged):
(WebCore):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • html/HTMLFormControlElement.cpp:
  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::ContentDistributor):
(WebCore::ContentDistributor::~ContentDistributor):
(WebCore::ContentDistributor::findInsertionPointFor):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):
(WebCore::ContentDistributor::finishInivalidation):
(WebCore::ContentDistributor::distributeSelectionsTo):
(WebCore::ContentDistributor::distributeShadowChildrenTo):
(WebCore::ContentDistributor::invalidateDistributionIn):

  • html/shadow/ContentDistributor.h:

(WebCore::ContentDistributor::needsInvalidation):
(ContentDistributor):
(WebCore::ContentDistributor::needsDistribution):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::nextTo):
(WebCore::InsertionPoint::previousTo):
(WebCore::InsertionPoint::childrenChanged):

  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::setDistribution):
(WebCore::InsertionPoint::clearDistribution):
(InsertionPoint):

8:30 PM Changeset in webkit [118885] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Implement post-landing feedback for WebKitCSSTransformValue::customCSSText().
https://bugs.webkit.org/show_bug.cgi?id=87684

Reviewed by Darin Adler.

Darin provided some style suggesting on https://bugs.webkit.org/show_bug.cgi?id=87462 after it landed.
This patch incorporates those suggestions, namely using 0 instead of empty string for UnknownTransformOperation
and WTF_ARRAY_LENGTH instead of hard coding the array length.

Covered by existing transform tests.

  • css/WebKitCSSTransformValue.cpp:

(WebCore):
(WebCore::WebKitCSSTransformValue::customCssText):

8:15 PM Changeset in webkit [118884] by ojan@chromium.org
  • 5 edits
    2 moves in trunk/Tools

Add a linter error for pngs that lack an embedded checksum
https://bugs.webkit.org/show_bug.cgi?id=87793

Reviewed by Dirk Pranke.

  • Scripts/read-checksum-from-png:
  • Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.

(read_checksum):

  • Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.

(ReadChecksumFromPngTest):
(ReadChecksumFromPngTest.test_read_checksum):

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/style/checkers/png.py:

(PNGChecker.check):

  • Scripts/webkitpy/style/checkers/png_unittest.py:

(PNGCheckerTest.test_check):

7:28 PM Changeset in webkit [118883] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix ENABLE_IFRAME_SEAMLESS to actually fully disable <iframe seamless>
https://bugs.webkit.org/show_bug.cgi?id=87646

Reviewed by Adam Barth.

In the process of moving the seamless feature out of github and into bugs.webkit.org
multiple versions of the shouldDisplaySeamlessly function got written
(and moved from HTMLIFrameElement to Document), but only one of them was wrapped
in ENABLE_IFRAME_SEAMLESS. HTMLIFrameElement was checking mayDisplaySeamlessly
directly (as was my original design), which got around the ENABLE_IFRAME_SEAMLESS check.
I've fixed this oversight, and the feature is now off when we tell it to be off.

This is covered by many existing tests. I've verified locally that
all tests fail when ENABLE_IFRAME_SEAMLESS is disabled instead of
only some of them.

  • dom/SecurityContext.h:

(SecurityContext):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::shouldDisplaySeamlessly):

7:18 PM Changeset in webkit [118882] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

Show an error in the pretty diff when an image lacks a checksum
https://bugs.webkit.org/show_bug.cgi?id=87791

Reviewed by Dirk Pranke.

  • PrettyPatch/PrettyPatch.rb:
  • PrettyPatch/PrettyPatch_test.rb:
7:13 PM Changeset in webkit [118881] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Refactor shadow-dom-event-dispatching.html.
https://bugs.webkit.org/show_bug.cgi?id=87626

Reviewed by Dimitri Glazkov.

There are badly named functions in shadow-dom-event-dispatching.html.
e.g. prepareDOMTree1, prepareDOMTree2 and so on.
That should have better namings which make the intention of each test clear.

  • fast/dom/shadow/shadow-dom-event-dispatching.html:
7:01 PM Changeset in webkit [118880] by cevans@google.com
  • 13 edits
    4 copies
    2 deletes in branches/chromium/1132

Merge 117971
BUG=125374
Review URL: https://chromiumcodereview.appspot.com/10447082

6:57 PM Changeset in webkit [118879] by cevans@google.com
  • 2 edits in branches/chromium/1132/Source/WebCore

Merge 117957
BUG=128342
Review URL: https://chromiumcodereview.appspot.com/10446075

6:55 PM Changeset in webkit [118878] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 117792
BUG=127234
Review URL: https://chromiumcodereview.appspot.com/10443074

6:52 PM Changeset in webkit [118877] by cevans@google.com
  • 1 edit in branches/chromium/1132/Source/WebCore/rendering/svg/RenderSVGText.cpp

Merge 117977
BUG=128800
Review URL: https://chromiumcodereview.appspot.com/10448069

6:51 PM IdlAttributes edited by thakis@chromium.org
(diff)
6:51 PM Changeset in webkit [118876] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1132

Merge 117975
BUG=128800
Review URL: https://chromiumcodereview.appspot.com/10456022

6:47 PM Changeset in webkit [118875] by cevans@google.com
  • 15 edits
    6 copies in branches/chromium/1132

Merge 117225
BUG=127679
Review URL: https://chromiumcodereview.appspot.com/10443073

6:36 PM Changeset in webkit [118874] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix warning in preprocessing Source/WebCore/dom/DOMError.idl
https://bugs.webkit.org/show_bug.cgi?id=87763

Patch by Scott Graham <scottmg@chromium.org> on 2012-05-29
Reviewed by Adam Barth.

Add newline at end of file to avoid warning:
../dom/DOMError.idl:35:2: warning: no newline at end of file

  • dom/DOMError.idl:
6:33 PM Changeset in webkit [118873] by pilgrim@chromium.org
  • 7 edits in trunk/Source

[Chromium] Move fileExists to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=87531

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • chromium/public/Platform.h:

(WebKit::Platform::fileExists):
(Platform):

Source/WebCore:

  • platform/chromium/FileSystemChromium.cpp:

(WebCore::fileExists):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

6:24 PM Changeset in webkit [118872] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 118471
BUG=128665
Review URL: https://chromiumcodereview.appspot.com/10444080

6:17 PM Changeset in webkit [118871] by rakuco@webkit.org
  • 9 edits
    4 adds in trunk/LayoutTests

[EFL] Gardening after r118845 and r118851.

Apparently some baselines were not updated as expected, fixing
that now.

  • platform/efl/fast/ruby/ruby-text-before-after-content-expected.png: Added.
  • platform/efl/fast/ruby/ruby-text-before-after-content-expected.txt:
  • platform/efl/fast/selectors/166-expected.png:
  • platform/efl/fast/selectors/166-expected.txt:
  • platform/efl/fast/selectors/unqualified-hover-strict-expected.png:
  • platform/efl/fast/selectors/unqualified-hover-strict-expected.txt: Added.
  • platform/efl/svg/batik/text/textAnchor-expected.txt:
  • platform/efl/svg/batik/text/textOnPath3-expected.txt:
  • platform/efl/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/efl/svg/carto.net/tabgroup-expected.txt:
  • platform/efl/transitions/cross-fade-background-image-expected.txt: Added.
  • platform/efl/transitions/cross-fade-border-image-expected.txt: Added.
6:13 PM Changeset in webkit [118870] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 118005
BUG=128204
Review URL: https://chromiumcodereview.appspot.com/10453072

6:09 PM Changeset in webkit [118869] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 118248
BUG=126475
Review URL: https://chromiumcodereview.appspot.com/10442075

6:05 PM Changeset in webkit [118868] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Rolled back in r118646, now that
https://bugs.webkit.org/show_bug.cgi?id=87784 is fixed.

http://trac.webkit.org/changeset/118646
https://bugs.webkit.org/show_bug.cgi?id=87599

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

  • heap/MarkedBlock.h:

(JSC):

  • heap/MarkedSpace.cpp:

(JSC):

  • heap/MarkedSpace.h:

(MarkedSpace):

6:04 PM Changeset in webkit [118867] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 118592
BUG=120222
Review URL: https://chromiumcodereview.appspot.com/10459020

6:00 PM Changeset in webkit [118866] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 118236
BUG=129357
Review URL: https://chromiumcodereview.appspot.com/10448068

5:56 PM Changeset in webkit [118865] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 118249
BUG=129299
Review URL: https://chromiumcodereview.appspot.com/10458025

5:47 PM Changeset in webkit [118864] by cevans@google.com
  • 10 edits
    6 copies
    3 deletes in branches/chromium/1132

Merge 117865
BUG=128711
Review URL: https://chromiumcodereview.appspot.com/10447080

5:38 PM Changeset in webkit [118863] by cevans@google.com
  • 6 edits
    15 copies in branches/chromium/1132

Merge 117482
BUG=120006
Review URL: https://chromiumcodereview.appspot.com/10448067

5:34 PM Changeset in webkit [118862] by haraken@chromium.org
  • 14 edits in trunk/Source/WebCore

[V8] Rename v8Null() to v8NullWithCheck()
https://bugs.webkit.org/show_bug.cgi?id=87713

Reviewed by Adam Barth.

In IRC, cmarcelo@ pointed out that v8::Null() and v8Null()
are confusing. This patch renames v8Null() to v8NullWithCheck().

No tests. No behavior change.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::toV8):

  • bindings/v8/V8Binding.h:

(WebCore::v8NullWithCheck):
(WebCore::v8DateOrNull):

5:25 PM Changeset in webkit [118861] by commit-queue@webkit.org
  • 3 edits
    8 deletes in trunk

Some Content Security Policy console messages are missing line numbers in JSC
https://bugs.webkit.org/show_bug.cgi?id=87558

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-29
Reviewed by Adam Barth.

Source/WebCore:

Make ScriptController::eventHandlerPosition() behave the same way on
JSC than V8. This means that TextPosition::minimumPosition() is
returned if parser is null, instead of
TextPosition::belowRangePosition(). The line numbers are now correctly
printed in the output of Content Security Policy tests.

Tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html

http/tests/security/contentSecurityPolicy/javascript-url-blocked.html

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::eventHandlerPosition):

LayoutTests:

Remove Mac/EFL/GTK/Qt-specific expectations for Content Security Policy
tests now that the line numbers are correctly printed.

  • platform/efl/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
  • platform/efl/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
  • platform/gtk/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
  • platform/gtk/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
  • platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
  • platform/mac/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
  • platform/qt/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Removed.
  • platform/qt/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Removed.
5:03 PM Changeset in webkit [118860] by Stephanie Lewis
  • 2 edits in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=87720
WebProcess is often killed due to being unresponsive on the bots

Reviewed by Alexey Proskuryakov.

Blind attempt to improve flakiness on the bots by reducing the number
of crashes due to an unresponsive process. This helped on my personal machine
under stress conditions. I don't have enough cores to hit the problem
under normal conditions.

  • WebKitTestRunner/TestController.cpp:

(WTR):

4:46 PM Changeset in webkit [118859] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

String should be move enabled/optimized
https://bugs.webkit.org/show_bug.cgi?id=87596

Reviewed by Andreas Kling.

Add move constructors and move assignment operators to String and AtomicString when building with
compilers that support rvalue references. This gets rid of ref-churn when the source of the
constructor or assignment is a temporary object.

  • wtf/text/AtomicString.h:

(AtomicString):
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::operator=):

  • wtf/text/WTFString.h:

(String):
(WTF::String::String):
(WTF::String::operator=):

4:43 PM Changeset in webkit [118858] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

DFG should keep captured variables alive until the (inline) return.
https://bugs.webkit.org/show_bug.cgi?id=87205

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Changes the way we do flushing for captured variables and arguments. Instead of flushing
each SetLocal immediately, we flush at kill points. So a SetLocal will cause a Flush of
whatever was live in the variable previously, and a return will cause a Flush of all
captured variables and all arguments.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::findArgumentPositionForArgument):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::findArgumentPosition):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::flushArgumentsAndCapturedVariables):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

LayoutTests:

Reviewed by Gavin Barraclough.

  • fast/js/dfg-inline-arguments-osr-exit-and-capture-expected.txt: Added.
  • fast/js/dfg-inline-arguments-osr-exit-and-capture.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-osr-exit-and-capture.js: Added.

(foo):
(bar):
(baz):

4:42 PM Changeset in webkit [118857] by shawnsingh@chromium.org
  • 4 edits in trunk/Source

[chromium] make WebTransformationMatrix object usable by non-webkit code
https://bugs.webkit.org/show_bug.cgi?id=87315

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebTransformationMatrix.h:

(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
(WebTransformationMatrix):

Source/WebCore:

This change is covered by existing tests and by whether it
compiles. There should be no changes in behavior.

  • platform/chromium/support/WebTransformationMatrix.cpp:

(WebKit::WebTransformationMatrix::WebTransformationMatrix):
(WebKit::WebTransformationMatrix::operator=):
(WebKit::WebTransformationMatrix::operator==):
(WebKit::WebTransformationMatrix::inverse):
(WebKit::WebTransformationMatrix::to2dTransform):
(WebKit::WebTransformationMatrix::multiply):
(WebKit::WebTransformationMatrix::makeIdentity):
(WebKit::WebTransformationMatrix::translate):
(WebKit::WebTransformationMatrix::translate3d):
(WebKit::WebTransformationMatrix::translateRight3d):
(WebKit::WebTransformationMatrix::scale):
(WebKit::WebTransformationMatrix::scaleNonUniform):
(WebKit::WebTransformationMatrix::scale3d):
(WebKit::WebTransformationMatrix::rotate):
(WebKit::WebTransformationMatrix::rotate3d):
(WebKit::WebTransformationMatrix::skewX):
(WebKit::WebTransformationMatrix::skewY):
(WebKit::WebTransformationMatrix::applyPerspective):
(WebKit::WebTransformationMatrix::blend):
(WebKit::WebTransformationMatrix::hasPerspective):
(WebKit::WebTransformationMatrix::isInvertible):
(WebKit::WebTransformationMatrix::isBackFaceVisible):
(WebKit::WebTransformationMatrix::isIdentity):
(WebKit::WebTransformationMatrix::isIdentityOrTranslation):
(WebKit::WebTransformationMatrix::isIntegerTranslation):
(WebKit::WebTransformationMatrix::m11):
(WebKit::WebTransformationMatrix::setM11):
(WebKit::WebTransformationMatrix::m12):
(WebKit::WebTransformationMatrix::setM12):
(WebKit::WebTransformationMatrix::m13):
(WebKit::WebTransformationMatrix::setM13):
(WebKit::WebTransformationMatrix::m14):
(WebKit::WebTransformationMatrix::setM14):
(WebKit::WebTransformationMatrix::m21):
(WebKit::WebTransformationMatrix::setM21):
(WebKit::WebTransformationMatrix::m22):
(WebKit::WebTransformationMatrix::setM22):
(WebKit::WebTransformationMatrix::m23):
(WebKit::WebTransformationMatrix::setM23):
(WebKit::WebTransformationMatrix::m24):
(WebKit::WebTransformationMatrix::setM24):
(WebKit::WebTransformationMatrix::m31):
(WebKit::WebTransformationMatrix::setM31):
(WebKit::WebTransformationMatrix::m32):
(WebKit::WebTransformationMatrix::setM32):
(WebKit::WebTransformationMatrix::m33):
(WebKit::WebTransformationMatrix::setM33):
(WebKit::WebTransformationMatrix::m34):
(WebKit::WebTransformationMatrix::setM34):
(WebKit::WebTransformationMatrix::m41):
(WebKit::WebTransformationMatrix::setM41):
(WebKit::WebTransformationMatrix::m42):
(WebKit::WebTransformationMatrix::setM42):
(WebKit::WebTransformationMatrix::m43):
(WebKit::WebTransformationMatrix::setM43):
(WebKit::WebTransformationMatrix::m44):
(WebKit::WebTransformationMatrix::setM44):
(WebKit::WebTransformationMatrix::a):
(WebKit::WebTransformationMatrix::setA):
(WebKit::WebTransformationMatrix::b):
(WebKit::WebTransformationMatrix::setB):
(WebKit::WebTransformationMatrix::c):
(WebKit::WebTransformationMatrix::setC):
(WebKit::WebTransformationMatrix::d):
(WebKit::WebTransformationMatrix::setD):
(WebKit::WebTransformationMatrix::e):
(WebKit::WebTransformationMatrix::setE):
(WebKit::WebTransformationMatrix::f):
(WebKit::WebTransformationMatrix::setF):
(WebKit::WebTransformationMatrix::toWebCoreTransform):
(WebKit::WebTransformationMatrix::mapRect):
(WebKit::WebTransformationMatrix::mapPoint):
(WebKit::WebTransformationMatrix::mapQuad):
(WebKit::WebTransformationMatrix::projectPoint):

4:40 PM Changeset in webkit [118856] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

WeakGCMap should be lazy-finalization-safe
https://bugs.webkit.org/show_bug.cgi?id=87784

Reviewed by Darin Adler.

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::get): Since this is a map of raw WeakImpl pointers, and
not Weak<T>, we need to verify manually that the WeakImpl is live before
we return its payload.

4:31 PM Changeset in webkit [118855] by dpranke@chromium.org
  • 4 edits in trunk/Tools

webkitpy: rename 'rm' to 'delete' in rebaseline scm output
https://bugs.webkit.org/show_bug.cgi?id=87779

Reviewed by Eric Seidel.

Update output to match the names in scm.py as per
https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_test_and_print_scm_changes):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(GardeningServerTest.test_rebaselineall):

4:27 PM Changeset in webkit [118854] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Support WebKit log messages on Android
https://bugs.webkit.org/show_bug.cgi?id=87773

Patch by Alexandre Elias <aelias@google.com> on 2012-05-29
Reviewed by Darin Adler.

This sends WebKit log messages to the Android "logcat" facility, as
Android sends stderr to /dev/null.

  • wtf/Assertions.cpp:
4:24 PM Changeset in webkit [118853] by alexis.menard@openbossa.org
  • 38 edits
    3 adds in trunk

[CSS3 Backgrounds and Borders] Implement box-decoration-break parsing.
https://bugs.webkit.org/show_bug.cgi?id=87678

Reviewed by Eric Seidel.

Source/WebCore:

Implement the parsing part of box-decoration-break. The specification
is located at http://www.w3.org/TR/css3-background/#box-decoration-break.
So far Opera implements it. This patch only implements the parsing part of
the property. A following patch will implement the rendering part. Despite
the rendering part missing it improves http://css3test.com by 1%.

Test: fast/box-decoration-break/box-decoration-break-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EBoxDecorationBreak):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleBoxData.cpp:

(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

  • rendering/style/StyleBoxData.h:

(WebCore::StyleBoxData::boxDecorationBreak):
(StyleBoxData):

LayoutTests:

Add a new test to cover the parsing part of the new css property. Also rebase the
existing tests which are listing the css properties of the style.

  • fast/box-decoration-break/box-decoration-break-parsing-expected.txt: Added.
  • fast/box-decoration-break/box-decoration-break-parsing.html: Added.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
4:20 PM Changeset in webkit [118852] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[text-overflow: ellipsis] WebKit should ignore the ellipsis for the purpose of dispatching mouse events
https://bugs.webkit.org/show_bug.cgi?id=63781

Patch by David Barr <davidbarr@chromium.org> on 2012-05-29
Reviewed by Eric Seidel.

Source/WebCore:

"Ellipsing only affects rendering and must not affect layout nor dispatching of pointer events."
http://www.w3.org/TR/2012/WD-css3-ui-20120117/#text-overflow

Test: fast/css/text-overflow-ellipsis-hit-test.html

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::nodeAtPoint): Always return false.

LayoutTests:

  • fast/css/text-overflow-ellipsis-hit-test-expected.txt: Added.
  • fast/css/text-overflow-ellipsis-hit-test.html: Added.
4:15 PM Changeset in webkit [118851] by rakuco@webkit.org
  • 73 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Unskip a lot of fast/selectors tests which were really passing all
the time, they just needed updated baselines after the jhbuild and
font commits.

  • platform/efl/Skipped:
  • platform/efl/fast/selectors/001-expected.png:
  • platform/efl/fast/selectors/002-expected.png:
  • platform/efl/fast/selectors/003-expected.png:
  • platform/efl/fast/selectors/004-expected.png:
  • platform/efl/fast/selectors/005-expected.png:
  • platform/efl/fast/selectors/006-expected.png:
  • platform/efl/fast/selectors/007a-expected.png:
  • platform/efl/fast/selectors/007b-expected.png:
  • platform/efl/fast/selectors/008-expected.png:
  • platform/efl/fast/selectors/009-expected.png:
  • platform/efl/fast/selectors/010-expected.png:
  • platform/efl/fast/selectors/011-expected.png:
  • platform/efl/fast/selectors/012-expected.png:
  • platform/efl/fast/selectors/013-expected.png:
  • platform/efl/fast/selectors/014-expected.png:
  • platform/efl/fast/selectors/015-expected.png:
  • platform/efl/fast/selectors/018-expected.png:
  • platform/efl/fast/selectors/018b-expected.png:
  • platform/efl/fast/selectors/021-expected.png:
  • platform/efl/fast/selectors/021b-expected.png:
  • platform/efl/fast/selectors/032-expected.png:
  • platform/efl/fast/selectors/034-expected.png:
  • platform/efl/fast/selectors/038-expected.png:
  • platform/efl/fast/selectors/040-expected.png:
  • platform/efl/fast/selectors/043-expected.png:
  • platform/efl/fast/selectors/043b-expected.png:
  • platform/efl/fast/selectors/044-expected.png:
  • platform/efl/fast/selectors/044b-expected.png:
  • platform/efl/fast/selectors/044c-expected.png:
  • platform/efl/fast/selectors/044d-expected.png:
  • platform/efl/fast/selectors/045-expected.png:
  • platform/efl/fast/selectors/045b-expected.png:
  • platform/efl/fast/selectors/045c-expected.png:
  • platform/efl/fast/selectors/046-expected.png:
  • platform/efl/fast/selectors/054-expected.png:
  • platform/efl/fast/selectors/056-expected.png:
  • platform/efl/fast/selectors/058-expected.png:
  • platform/efl/fast/selectors/059-expected.png:
  • platform/efl/fast/selectors/060-expected.png:
  • platform/efl/fast/selectors/061-expected.png:
  • platform/efl/fast/selectors/063-expected.png:
  • platform/efl/fast/selectors/064-expected.png:
  • platform/efl/fast/selectors/066-expected.png:
  • platform/efl/fast/selectors/066b-expected.png:
  • platform/efl/fast/selectors/072-expected.png:
  • platform/efl/fast/selectors/072b-expected.png:
  • platform/efl/fast/selectors/077-expected.png:
  • platform/efl/fast/selectors/077b-expected.png:
  • platform/efl/fast/selectors/078b-expected.png:
  • platform/efl/fast/selectors/083-expected.png:
  • platform/efl/fast/selectors/087b-expected.png:
  • platform/efl/fast/selectors/090b-expected.png:
  • platform/efl/fast/selectors/154-expected.png:
  • platform/efl/fast/selectors/155-expected.png:
  • platform/efl/fast/selectors/155a-expected.png:
  • platform/efl/fast/selectors/155b-expected.png:
  • platform/efl/fast/selectors/155c-expected.png:
  • platform/efl/fast/selectors/155d-expected.png:
  • platform/efl/fast/selectors/156b-expected.png:
  • platform/efl/fast/selectors/157-expected.png:
  • platform/efl/fast/selectors/158-expected.png:
  • platform/efl/fast/selectors/160-expected.png:
  • platform/efl/fast/selectors/168-expected.png:
  • platform/efl/fast/selectors/168a-expected.png:
  • platform/efl/fast/selectors/169-expected.png:
  • platform/efl/fast/selectors/169a-expected.png:
  • platform/efl/fast/selectors/lang-inheritance-expected.png:
  • platform/efl/fast/selectors/lang-inheritance2-expected.png:
  • platform/efl/fast/selectors/lang-vs-xml-lang-expected.png:
  • platform/efl/fast/selectors/lang-vs-xml-lang-xhtml-expected.png:
  • platform/efl/fast/selectors/visited-descendant-expected.png:
4:12 PM Changeset in webkit [118850] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] WebOverlay build fixes and bug fixes
https://bugs.webkit.org/show_bug.cgi?id=87780

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-29
Reviewed by Rob Buis.

Fix build when accelerated compositing disabled, or debug build.

Also fix a bug where the selection overlay would not disappear properly
because of a typo in WebPage::removeOverlay(). Also convert said method
to early return style.

Debug build fixes contributed by Ming Xie.

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlay::addAnimation):
(BlackBerry::WebKit::WebOverlay::setContentsToImage):
(WebKit):
(BlackBerry::WebKit::WebOverlay::setContentsToColor):
(BlackBerry::WebKit::WebOverlay::setDrawsContent):
(BlackBerry::WebKit::WebOverlay::invalidate):
(BlackBerry::WebKit::WebOverlay::setClient):
(BlackBerry::WebKit::WebOverlay::override):
(BlackBerry::WebKit::WebOverlay::resetOverrides):

  • Api/WebOverlayOverride.cpp:

(BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):

  • Api/WebOverlay_p.h:

(BlackBerry::WebKit::WebOverlayPrivate::~WebOverlayPrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::removeOverlay):
(BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
(BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):

4:12 PM Changeset in webkit [118849] by jberlin@webkit.org
  • 1 edit
    11 adds in trunk/LayoutTests

<progress> element is unsupported on Windows
https://bugs.webkit.org/show_bug.cgi?id=49769

Add platform-specific results for tests that use the progress element on Windows.

  • platform/win/fast/forms/label: Added.
  • platform/win/fast/forms/label/labelable-elements-expected.txt: Added.
  • platform/win/fast/forms/label/labels-add-htmlFor-label-expected.txt: Added.
  • platform/win/fast/forms/label/labels-add-parent-label-expected.txt: Added.
  • platform/win/fast/forms/label/labels-change-htmlFor-attribute-expected.txt: Added.
  • platform/win/fast/forms/label/labels-multiple-sibling-labels-expected.txt: Added.
  • platform/win/fast/forms/label/labels-parent-and-sibling-labels-expected.txt: Added.
  • platform/win/fast/forms/label/labels-remove-htmlFor-attribute-expected.txt: Added.
  • platform/win/fast/forms/label/labels-remove-htmlFor-label-expected.txt: Added.
  • platform/win/fast/forms/label/labels-remove-parent-label-expected.txt: Added.
  • platform/win/fast/forms/label/labels-set-htmlFor-attribute-expected.txt: Added.
4:07 PM Changeset in webkit [118848] by gavinp@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium] Remove assertions on state in Prerender.cpp
https://bugs.webkit.org/show_bug.cgi?id=87746

Chrome was crashing in the new Prerender API on Google Web Search; this was because the DOM would stop(), setting the
state of the Prerenders in the document to Inactive, but an asyncronous GC would later come come along and trigger the
removedFromDocument behaviour on each element, including the <link> element launching the prerender. This causes an
assertion failure.

I believe the late-deletion of the DOM, and the HTMLElement::removedFromDocument calls are legal, and it was the
overzealous assertions in Prerender that were inappropriate.

Reviewed by Adam Barth.

No new automated tests, working on a Chromium browser test. Manually test by entering many prerender and non-prerendered
queries into Google Web Search.

  • platform/chromium/Prerender.cpp:

(WebCore::Prerender::Prerender):
(WebCore::Prerender::add):
(WebCore::Prerender::cancel):
(WebCore::Prerender::abandon):

  • platform/chromium/Prerender.h:

(Prerender):

3:59 PM Changeset in webkit [118847] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add malloc info to about:memory page
https://bugs.webkit.org/show_bug.cgi?id=87676

Patch by Yong Li <yoli@rim.com> on 2012-05-29
Reviewed by Rob Buis.

Detailed malloc info can tell us how much memory
in the heaps is being in use.

  • WebCoreSupport/AboutData.cpp:

(WebCore::memoryPage):

3:59 PM Changeset in webkit [118846] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Updating test expectation (media/track/track-cues-missed CRASH).

  • platform/chromium/test_expectations.txt:
3:53 PM Changeset in webkit [118845] by rakuco@webkit.org
  • 10 edits
    70 adds in trunk/LayoutTests

[EFL] Unreviewed gardening.

House cleaning on Skipped: remove tests which do not exist, unskip
some which are passing and add expectations for some which were
lacking them.

  • platform/efl/Skipped:
  • platform/efl/editing/selection/fake-doubleclick-expected.png: Added.
  • platform/efl/editing/selection/fake-doubleclick-expected.txt: Added.
  • platform/efl/fast/borders/border-image-slice-constrained-expected.png: Added.
  • platform/efl/fast/borders/border-image-slice-constrained-expected.txt: Added.
  • platform/efl/fast/borders/border-mixed-alpha-expected.png: Added.
  • platform/efl/fast/borders/borderRadiusArcs01-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusDouble01-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusDouble02-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusDouble03-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusGroove01-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusGroove02-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusInset01-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusOutset01-expected.txt: Added.
  • platform/efl/fast/borders/borderRadiusRidge01-expected.txt: Added.
  • platform/efl/fast/borders/scaled-border-image-expected.png: Added.
  • platform/efl/fast/borders/scaled-border-image-expected.txt: Added.
  • platform/efl/fast/forms/input-appearance-disabled-expected.png: Added.
  • platform/efl/fast/forms/input-appearance-disabled-expected.txt: Added.
  • platform/efl/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/efl/fast/forms/input-appearance-readonly-expected.txt: Added.
  • platform/efl/fast/forms/input-placeholder-visibility-3-expected.png: Added.
  • platform/efl/fast/forms/input-placeholder-visibility-3-expected.txt: Added.
  • platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
  • platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.txt: Added.
  • platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
  • platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.txt: Added.
  • platform/efl/fast/forms/textarea-scrollbar-expected.png: Added.
  • platform/efl/fast/forms/textarea-scrollbar-expected.txt: Added.
  • platform/efl/fast/line-grid/line-grid-floating-expected.png: Added.
  • platform/efl/fast/line-grid/line-grid-floating-expected.txt: Added.
  • platform/efl/fast/line-grid/line-grid-inside-columns-expected.png: Added.
  • platform/efl/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
  • platform/efl/fast/line-grid/line-grid-into-floats-expected.png: Added.
  • platform/efl/fast/line-grid/line-grid-into-floats-expected.txt: Added.
  • platform/efl/fast/line-grid/line-grid-positioned-expected.png: Added.
  • platform/efl/fast/line-grid/line-grid-positioned-expected.txt: Added.
  • platform/efl/fast/repaint/4774354-expected.png: Added.
  • platform/efl/fast/repaint/4774354-expected.txt: Added.
  • platform/efl/fast/repaint/4776765-expected.png: Added.
  • platform/efl/fast/repaint/4776765-expected.txt: Added.
  • platform/efl/fast/repaint/delete-into-nested-block-expected.png: Added.
  • platform/efl/fast/repaint/delete-into-nested-block-expected.txt: Added.
  • platform/efl/fast/repaint/inline-outline-repaint-expected.png: Added.
  • platform/efl/fast/repaint/inline-outline-repaint-expected.txt: Added.
  • platform/efl/fast/repaint/selection-after-delete-expected.png: Added.
  • platform/efl/fast/repaint/selection-after-delete-expected.txt: Added.
  • platform/efl/fast/selectors/159-expected.png: Added.
  • platform/efl/fast/selectors/159-expected.txt: Added.
  • platform/efl/fast/selectors/177a-expected.png: Added.
  • platform/efl/fast/selectors/177a-expected.txt: Added.
  • platform/efl/fast/spatial-navigation/snav-multiple-select-focusring-expected.png: Added.
  • platform/efl/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Added.
  • platform/efl/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/efl/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/efl/fast/text/delete-hard-break-character-expected.png: Added.
  • platform/efl/fast/text/delete-hard-break-character-expected.txt: Added.
  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/efl/mathml/presentation/roots-expected.png: Added.
  • platform/efl/mathml/presentation/roots-expected.txt: Added.
  • platform/efl/mathml/presentation/row-alignment-expected.png: Added.
  • platform/efl/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/efl/media/controls-styling-expected.png: Added.
  • platform/efl/media/controls-styling-expected.txt: Added.
  • platform/efl/svg/batik/text/textAnchor-expected.png: Added.
  • platform/efl/svg/batik/text/textOnPath3-expected.png: Added.
  • platform/efl/svg/batik/text/verticalTextOnPath-expected.png: Added.
  • platform/efl/svg/carto.net/tabgroup-expected.png: Added.
  • platform/efl/transitions/cross-fade-background-image-expected.png: Added.
  • platform/efl/transitions/cross-fade-border-image-expected.png: Added.
  • platform/efl/transitions/default-timing-function-expected.png:
  • platform/efl/transitions/default-timing-function-expected.txt:
  • platform/efl/transitions/move-after-transition-expected.png:
  • platform/efl/transitions/move-after-transition-expected.txt:
  • platform/efl/transitions/svg-text-shadow-transition-expected.png:
  • platform/efl/transitions/svg-text-shadow-transition-expected.txt:
3:37 PM Changeset in webkit [118844] by jamesr@google.com
  • 16 edits in branches/chromium/1132

Merge 118261 - [chromium] Turn ENABLE(OVERFLOW_SCROLLING) off for Chromium port
https://bugs.webkit.org/show_bug.cgi?id=87177

Reviewed by Eric Seidel.

Source/WebKit/chromium:

Removes ENABLE(OVERFLOW_SCROLLING) from the set of enables set by Chromium. This guards a new non-standard
CSS property, -webkit-overflow-scrolling, that was introduced by iOS5 intended for mobile browsers. This
property is very partially implemented in Chromium but the way it's implemented does cause new stacking contexts
to be created that otherwise would not be, breaking "desktop" pages.

This turns the feature off until we can figure out how to deal with the compatibility issues.

  • features.gypi:

LayoutTests:

Mark test depending on ENABLE(OVERFLOW_SCROLLING) as an expected failure since the define is off.

  • platform/chromium/test_expectations.txt:

TBR=jamesr@google.com
BUG=124559
Review URL: https://chromiumcodereview.appspot.com/10447078

3:36 PM Changeset in webkit [118843] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Updating test expectations (fast/forms/form-associated-element-removal MISSING).

  • platform/chromium/test_expectations.txt:
3:33 PM Changeset in webkit [118842] by Stephanie Lewis
  • 2 edits in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=87711

Reviewed by Jessie Berlin.

Remove Snowleopard testers so the hardware can be repurposed. The lion bots
are better maintained.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:28 PM Changeset in webkit [118841] by commit-queue@webkit.org
  • 8 edits
    2 moves in trunk

Display cues in the controls area
https://bugs.webkit.org/show_bug.cgi?id=87591

Patch by Victor Carbune <victor@rosedu.org> on 2012-05-29
Reviewed by Eric Carlson.

Source/WebCore:

Changed the behaviour to implicitly hide the volume slidebar
if the controls are hidden (due mouse moving out of the video
area or controls are toggled through JS).

This seems to be the simplest fix to this issue, otherwise
on toggling the display:none property on the controls the
volume slidebar might appear below the video.

Re-enabled failing tests for this functionality.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::makeTransparent): Re-enabled
timer to set the display:none property on the controls.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::hide): Added a call to hide
the volume slider.
(WebCore::MediaControlRootElement::makeTransparent): Same.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::hide): Same.
(WebCore::MediaControlRootElementChromium::makeTransparent): Same.

LayoutTests:

  • media/media-volume-slider-rendered-normal-expected.txt: Renamed from LayoutTests/media/video-controls-rendering-toggle-display-none-expected.txt.
  • media/media-volume-slider-rendered-normal.html: Renamed from LayoutTests/media/video-controls-rendering-toggle-display-none.html.
  • platform/chromium/test_expectations.txt: Unmarked tests.
  • platform/efl/test_expectations.txt: Unmarked tests.
  • platform/mac/test_expectations.txt: Unmarked tests.
3:24 PM Changeset in webkit [118840] by enne@google.com
  • 2 edits in trunk/Source/WebCore

Fix transparent iframes with composited contents in WK1 on Mac
https://bugs.webkit.org/show_bug.cgi?id=76478

Reviewed by Simon Fraser.

Test: compositing/iframes/repaint-after-losing-scrollbars.html

  • page/FrameView.cpp:

(WebCore::FrameView::useSlowRepaints):

3:22 PM Changeset in webkit [118839] by hyatt@apple.com
  • 9 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=87787

[New Multicolumn] Refactor the region and flow thread code so that it can pick up the correct column widths
and heights when determining the logical width and height of the flow thread itself.

This patch adds new virtual methods to RenderRegion: logicalWidthForFlowThreadContent and logicalHeightForFlowThreadContent.
For normal regions, these methods return the contentWidth and contentHeight of the regions themselves. For column sets,
however, these methods actually return the column widths and heights.

This allows the flow thread to properly lay out according to the column width.

Region invalidation is also done properly by using these new methods.

In some cases the code is actually simplified, since we can get rid of some isHorizontalWritingMode() switching.

With this patch the flow thread now actually lays out and paints at the right width (spilling out of the region set in a single unbroken
column).

Reviewed by Dan Bernstein.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::ensureColumnSets):

  • rendering/RenderMultiColumnBlock.h:

(WebCore::RenderMultiColumnBlock::isRenderMultiColumnBlock):
(RenderMultiColumnBlock):
(WebCore::toRenderMultiColumnBlock):
(WebCore):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::computeLogicalWidth):
(WebCore):
(WebCore::RenderMultiColumnSet::computeLogicalHeight):

  • rendering/RenderMultiColumnSet.h:

(WebCore::RenderMultiColumnSet::setColumnWidthAndCount):
(RenderMultiColumnSet):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderMultiColumnBlock):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::logicalWidthForFlowThreadContent):
(WebCore):
(WebCore::RenderRegion::logicalHeightForFlowThreadContent):
(WebCore::RenderRegion::layout):

  • rendering/RenderRegion.h:

(RenderRegion):

2:46 PM Changeset in webkit [118838] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkit-patch optimize-baselines should add/delete files in batches from the vcs
https://bugs.webkit.org/show_bug.cgi?id=87538

Reviewed by Ojan Vafai.

Invoking git and svn on one file at a time is kinda slow. We
should batch the add and rm operations together.

  • Scripts/webkitpy/common/checkout/baselineoptimizer.py:

(BaselineOptimizer._move_baselines):

2:39 PM Changeset in webkit [118837] by rakuco@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[EFL] Gardening. Unskip passing test.

  • platform/efl/Skipped:
  • platform/efl/editing/input/emacs-ctrl-o-expected.png: Added.
  • platform/efl/editing/input/emacs-ctrl-o-expected.txt: Added.
2:30 PM Changeset in webkit [118836] by dpranke@chromium.org
  • 9 edits in trunk/Tools

garden-o-matic should rebaseline baselines in parallel
https://bugs.webkit.org/show_bug.cgi?id=87451

Reviewed by Ojan Vafai.

This modifies garden-o-matic so that we will fetch all
of the baselines in parallel from the bots, and then
optimize the baselines serially (since that should be fairly
quick and we get into trouble if we optimize in parallel due
to concurrent access to the source control system).

This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
so that the files that need to be modified in the SCM are returned to
garden-o-matic rather than actually added or removed. This is done so that
we can run multiple rebaseline-tests in parallel (we can't modify the SCM
concurrently). In order to safely return the files (as a JSON dict) I
needed to shift all of the logging in rebaseline-test to use the logging
module (and hence log to stderr).

I also had to stub out a line in chromium.py that would get confused if
the skia overrides file didn't exist in a mock checkout.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.popen):
(Executive):
(Executive.run_in_parallel):
(_run_command_thunk):

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.run_in_parallel):

  • Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.test_run_in_parallel):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._expectations_file_contents):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand.init):
(RebaselineTest.init):
(RebaselineTest._copy_existing_baseline):
(RebaselineTest._save_baseline):
(RebaselineTest):
(RebaselineTest._add_to_scm):
(RebaselineTest._rebaseline_test):
(RebaselineTest.execute):
(RebaselineExpectations._rebaseline_port):
(RebaselineExpectations.execute):
(Rebaseline._builder_to_pull_from):
(Rebaseline.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_updates_expectations_file):
(test_rebaseline_test):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(test_rebaseline_expectations):

  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler._rebaseline_commands):
(GardeningHTTPRequestHandler):
(GardeningHTTPRequestHandler._files_to_add):
(GardeningHTTPRequestHandler._optimize_baselines):
(GardeningHTTPRequestHandler.rebaselineall):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(GardeningServerTest._post_to_path):
(GardeningServerTest.test_rebaselineall):
(GardeningServerTest.test_rebaselineall.run_command):

2:20 PM Changeset in webkit [118835] by commit-queue@webkit.org
  • 17 edits in trunk

IndexedDB: Align codes and names for IDB-specific and DOM-specific errors/exceptions
https://bugs.webkit.org/show_bug.cgi?id=87276

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-29
Reviewed by Tony Chang.

Source/WebCore:

No new tests. Existing tests have been updated to use the new
exception constant values.

The IDB spec has evolved to DOM4-style DOMExceptions, which are
referred to with MixedCase, string-based style names for
exceptions rather than UNDERSCORE_CONSTANT_ERR codes. Change to
use MixedCase error/exception names, and tease out the
IDB-specific exception/error codes/names from the system-level
codes. Make sure that the legacy IDB-masked exception code values
match the DOM exception values. Make sure that
IDBDatabaseException[exception.name] still works.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):

  • Modules/indexeddb/IDBDatabaseException.cpp:

(IDBDatabaseExceptionNameDescription):
(WebCore):
(WebCore::IDBDatabaseException::initializeDescription):

  • Modules/indexeddb/IDBDatabaseException.h:
  • Modules/indexeddb/IDBDatabaseException.idl:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::abort):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):

Source/WebKit/chromium:

  • public/WebIDBDatabaseException.h:
  • src/AssertMatchingEnums.cpp:

LayoutTests:

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/resources/constants.js:

(test):

2:17 PM Changeset in webkit [118834] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests
because of missing LayoutTestController implementation.

  • platform/qt/Skipped:
2:13 PM Changeset in webkit [118833] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip scroll related layout tests
https://bugs.webkit.org/show_bug.cgi?id=87765

Unreviewed EFL gardening.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-29

  • platform/efl/Skipped:
2:13 PM Changeset in webkit [118832] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=87775

[New Multicolumn] Make sure RenderMultiColumnSets have their own copy of the count, width and height of their columns.

Reviewed by Anders Carlsson.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):

  • rendering/RenderMultiColumnBlock.h:

(WebCore::RenderMultiColumnBlock::columnWidth):
(WebCore::RenderMultiColumnBlock::columnCount):
(RenderMultiColumnBlock):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):

  • rendering/RenderMultiColumnSet.h:

(WebCore::RenderMultiColumnSet::columnCount):
(WebCore::RenderMultiColumnSet::columnWidth):
(WebCore::RenderMultiColumnSet::columnHeight):
(RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::setColumnWidthAndCount):
(WebCore::RenderMultiColumnSet::setColumnHeight):

1:58 PM Changeset in webkit [118831] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

AX: windows DRT needs to implement ::press
https://bugs.webkit.org/show_bug.cgi?id=36145

Add more tests that use press to the Windows Skipped list.

  • platform/win/Skipped:
1:56 PM Changeset in webkit [118830] by ap@apple.com
  • 2 edits in trunk/LayoutTests

fast/events/message-port-close.html hits ASSERT in Debug
https://bugs.webkit.org/show_bug.cgi?id=85811

  • platform/mac/Skipped: I think that it's just this one test with a delayed effect. Skipping it, and unskipping a victim.
1:49 PM Changeset in webkit [118829] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Updating chromium test_expectations (svg/dom/viewspec-parser timeouts)

  • platform/chromium/test_expectations.txt:
1:49 PM Changeset in webkit [118828] by Simon Fraser
  • 5 edits
    1 add in trunk

Incomplete repaint on twitter.com when replying to a tweet
https://bugs.webkit.org/show_bug.cgi?id=87553

Reviewed by Dean Jackson.

Manual test that adds a transform to a layer, forcing that
layer to gain backing store.

  • ManualTests/compositing/requires-backing-change.html: Added.

Source/WebCore:

Reviewed by Dean Jackson.

Style changes can cause a compositing layer to change between
requiring its own backing store or not, e.g. with the addition
or removal of a transform.

When that happens, we need to repaint the ancesetor layer that
this layer was, or will be drawing into.

Factored some code out of layerWillBeRemoved() to be able to
also call it from setRequiresOwnBackingStore().

New manual test, ManualTests/compositing/requires-backing-change.html.
I was not able to get an automated pixel test to work.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setRequiresOwnBackingStore):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers): Remove trailing whitespace.
(WebCore::RenderLayerCompositor::repaintInCompositedAncestor):
(WebCore::RenderLayerCompositor::layerWillBeRemoved):

  • rendering/RenderLayerCompositor.h:
1:35 PM Changeset in webkit [118827] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

JSC doesn't support heap profiling.
https://bugs.webkit.org/show_bug.cgi?id=50485

Add another heap profiling test to the Mac and Windows Skipped lists.

  • platform/mac/Skipped:
  • platform/win/Skipped:
1:27 PM Changeset in webkit [118826] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=87771

[New Multicolumn] Make sure we have one column set by default and add it to the flow thread's region list.

Reviewed by Anders Carlsson.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::ensureColumnSets):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):

1:26 PM Changeset in webkit [118825] by ap@apple.com
  • 2 edits in trunk/LayoutTests

WTR doesn't support beginDragWithFiles.

  • platform/wk2/Skipped: Added fast/files/file-list-test.html
1:19 PM Changeset in webkit [118824] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Clean up the Windows WK2 Skipped list.

Update it for the moves / renames in r96918, r102226, and r108612.

  • platform/win-wk2/Skipped:
1:03 PM Changeset in webkit [118823] by rafaelw@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
12:59 PM Changeset in webkit [118822] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

JSC doesn't support heap profiling.
https://bugs.webkit.org/show_bug.cgi?id=50485

Add two heap profiling tests to the Windows Skipped list.

  • platform/win/Skipped:
12:42 PM Changeset in webkit [118821] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Fix the type of dispatch_time() offset

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-05-29
Rubber-stamped by Joseph Pecoraro.

In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().

  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):

12:33 PM Changeset in webkit [118820] by sullivan@apple.com
  • 3 edits in trunk/Source/WebCore

Update label for blacklisted plug-in
https://bugs.webkit.org/show_bug.cgi?id=87767
rdar://problem/11550048

Reviewed by Kevin Decker.

  • English.lproj/Localizable.strings:

Regenerated.

  • platform/LocalizedStrings.cpp:

(WebCore::insecurePluginVersionText):
Changed this string.

12:30 PM Changeset in webkit [118819] by jchaffraix@webkit.org
  • 3 edits
    9 adds in trunk

REGRESSION(r111742): box-sizing: border-box doesn't work on fixed table layout
https://bugs.webkit.org/show_bug.cgi?id=87536

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout.html

fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout.html
fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout.html
fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout.html

The change in r111742 completely ignored border-sizing (following the table's code lead unfortunately).
The issue is that we would count the borders and paddings twice for the border-box case which would lead
to the content-box including them too. From a web-author, this behavior is equivalent to ignoring box-sizing.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
Reworked the function to properly use computeBorderBoxLogicalWidth() for correctness. This matches
what RenderBox and the rendering code does generally. Also refactored the code to avoid the need
for local variables and make it more readable.

LayoutTests:

  • fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout.html: Added.

This test covers the regression.

  • fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout.html: Added.
  • fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout.html: Added.
  • fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout.html: Added.

Those test ensured I didn't regress and document our current behavior ie that column and column group fixed
width apply to the cell's border-box.

12:28 PM Changeset in webkit [118818] by ojan@chromium.org
  • 6 edits
    2 adds in trunk

Absolute positioned elements in a relative positioned CSS3 Flexbox fail to display properly
https://bugs.webkit.org/show_bug.cgi?id=58453

Reviewed by Tony Chang.

Source/WebCore:

Test: css3/flexbox/align-absolute-child.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::adjustAlignmentForChild):
When adjusting positioned items, adjust their static position, not their location.
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
(WebCore::RenderFlexibleBox::flipForWrapReverse):

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/align-absolute-child-expected.txt: Added.
  • css3/flexbox/align-absolute-child.html: Added.
  • css3/flexbox/position-absolute-child-expected.txt:
  • css3/flexbox/position-absolute-child.html:
12:23 PM Changeset in webkit [118817] by jberlin@webkit.org
  • 3 edits
    13 deletes in trunk

[Win] ~1/2 of all the iframe seamless tests fail
https://bugs.webkit.org/show_bug.cgi?id=87543

Rubber-stamped by Eric Seidel.

WebKitLibraries:

Finish enabling IFRAME_SEAMLESS on Windows.

  • win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Remove the platform-specific results as they are no longer needed.

  • platform/win/fast/frames/seamless/seamless-basic-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-css-cascade-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-form-get-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-form-get-named-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-form-post-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-form-post-named-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-hyperlink-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-hyperlink-named-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-inherited-document-style-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-window-location-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-window-location-href-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-window-location-sandbox-expected.txt: Removed.
  • platform/win/fast/frames/seamless/seamless-window-open-expected.txt: Removed.
12:15 PM Changeset in webkit [118816] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash due to text fragment destruction when updating first-letter block.
https://bugs.webkit.org/show_bug.cgi?id=87751

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/text/text-fragment-first-letter-update-crash.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle):

LayoutTests:

  • fast/text/text-fragment-first-letter-update-crash-expected.txt: Added.
  • fast/text/text-fragment-first-letter-update-crash.html: Added.
12:12 PM Changeset in webkit [118815] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=87764

Add implementation of checkForPaginationLogicalHeightChange to RenderMultiColumnBlock.

Also stub out ensureColumnSets() and write a comment describing how it's going to work.

Reviewed by Anders Carlsson.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
(WebCore):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):

  • rendering/RenderMultiColumnBlock.h:

(WebCore::RenderMultiColumnBlock::columnHeight):
(WebCore::RenderMultiColumnBlock::setColumnHeight):
(RenderMultiColumnBlock):

11:48 AM Changeset in webkit [118814] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk/LayoutTests

[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=87754

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-29

  • platform/efl/Skipped:
  • platform/efl/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/efl/fast/forms/select/optgroup-rendering-expected.txt: Added.
  • platform/efl/test_expectations.txt:
11:42 AM Changeset in webkit [118813] by rniwa@webkit.org
  • 1 edit
    2 copies in branches/chromium/1132

Merge 118449 - REGRESSION (r112399): insertHTML doesn't respect current selection range and inserts HTML to incorrect position
https://bugs.webkit.org/show_bug.cgi?id=87195

Reviewed by Darin Adler.

Source/WebCore:
The bug was caused by our passing insertionPos.anchorNode() to splitTreeToNode's start node even when
the position's type was an offset in a container. Fixed the bug by passing the node after the insert position
or the container node if the position is at the end of the container.

Test: editing/pasteboard/paste-at-end-of-node-followed-by-inline-element.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply):
LayoutTests:
Add a regression test.

  • editing/pasteboard/paste-at-end-of-node-followed-by-inline-element-expected.txt: Added.
  • editing/pasteboard/paste-at-end-of-node-followed-by-inline-element.html: Added.
11:42 AM Changeset in webkit [118812] by commit-queue@webkit.org
  • 9 edits in trunk

Unreviewed, rolling out r118620.
http://trac.webkit.org/changeset/118620
https://bugs.webkit.org/show_bug.cgi?id=87760

This patch causes regression to read an empty file/blob via
FileReader (Requested by jianli on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-29

Source/WebCore:

  • fileapi/FileReader.cpp:

(WebCore::FileReader::stringResult):

LayoutTests:

  • fast/files/blob-slice-test-expected.txt:
  • fast/files/read-blob-async-expected.txt:
  • fast/files/read-file-async-expected.txt:
  • fast/files/resources/read-common.js:

(logResult):

  • fast/files/workers/worker-read-blob-async-expected.txt:
  • fast/files/workers/worker-read-file-async-expected.txt:
11:39 AM Changeset in webkit [118811] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] ASSERT(m_manualStream) failed in PluginView::didFinishLoading running
fast/loader/reload-zero-byte-plugin.html

Skip the test on Windows to get the bots greener.

  • platform/win/Skipped:
11:38 AM Changeset in webkit [118810] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CopiedSpace::doneCopying could start another collection
https://bugs.webkit.org/show_bug.cgi?id=86538

Reviewed by Geoffrey Garen.

It's possible that if we don't have anything at the head of to-space
after a collection and the BlockAllocator doesn't have any fresh blocks
to give us right now we could start another collection while still in
the middle of the first collection when we call CopiedSpace::addNewBlock().

One way to resolve this would be to have Heap::shouldCollect() check that
m_operationInProgress is NoOperation. This would prevent the path in
getFreshBlock() that starts the collection if we're already in the middle of one.

I could not come up with a test case to reproduce this crash on ToT.

  • heap/Heap.h:

(JSC::Heap::shouldCollect): We shouldn't collect if we're already in the middle
of a collection, i.e. the current operation should be NoOperation.

11:19 AM Changeset in webkit [118809] by kling@webkit.org
  • 6 edits in trunk/Source/WebCore

Make StylePropertySet a variable-sized object to reduce memory use.
<http://webkit.org/b/87506>

Reviewed by Antti Koivisto.

Make immutable StylePropertySet objects variable-sized and allocate exactly
the space needed to hold the CSSProperty objects passed at construction.
This lets us avoid the memory overhead of Vector<CSSProperty, 4>.

Renamed StylePropertySet::adopt* to create and createImmutable since they no
longer adopt the incoming vector. More cleanup will follow in this area.

This reduces memory usage across the board - the more CSS declarations,
the bigger the benefit. As an example, we save around ~0.5MB on wsj.com.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSParser.cpp:

(WebCore::CSSParser::createStylePropertySet):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::~StylePropertySet):
(WebCore::StylePropertySet::copyPropertiesFrom):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::copyPropertiesInSet):
(WebCore::StylePropertySet::averageSizeInBytes):
(SameSizeAsStylePropertySet):
(WebCore::StylePropertySet::append):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::create):
(StylePropertySet):
(WebCore::StylePropertySet::propertyAt):
(WebCore::StylePropertySet::propertyCount):
(WebCore::StylePropertySet::isEmpty):
(WebCore::StylePropertySet::array):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateAttributeStyle):

11:15 AM Changeset in webkit [118808] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=87759

Pull the initial page logical height checking for columns into its own separate function. This
will allow the derived RenderMultiColumnBlock class to do its own setup there. It also has the
effect of cleaning up layoutBlock even for the existing code.

Reviewed by Anders Carlsson.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
(WebCore):
(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderBlock.h:

(RenderBlock):

11:13 AM Changeset in webkit [118807] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Adding VISTA timeout expectations to a number of viewport tests. Also, narrowing optgroup-clicking.html
to be just MAC.

  • platform/chromium/test_expectations.txt:
10:55 AM Changeset in webkit [118806] by commit-queue@webkit.org
  • 6 edits in trunk

Update cue event dispatching for zero and negative duration cues
https://bugs.webkit.org/show_bug.cgi?id=85143

Patch by Victor Carbune <victor@rosedu.org> on 2012-05-29
Reviewed by Eric Carlson.

Source/WebCore:

Updated existing test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Explicitly
treated event dispatching for zero and negative duration cues.
(WebCore::HTMLMediaElement::textTrackAddCue): Interval tree doesn't
handle invalid cues with intervals - negative cues need to be treated
as zero-length cues as they are always missed cues anyway.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Same.

LayoutTests:

  • media/track/captions-webvtt/missed-cues.vtt: Added negative

duration cue and changed a missed cue to have zero-length.

  • media/track/track-cues-missed-expected.txt: Updated.
  • media/track/track-cues-missed.html: Updated.
10:50 AM Changeset in webkit [118805] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make DefaultTapHighlight use the new WebOverlay API
https://bugs.webkit.org/show_bug.cgi?id=87604

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-29
Reviewed by Antonio Gomes.

Also add a new method to allow the embedder to use the default tap
highlight instead of replacing it with a custom one just to keep track
of the "shouldHideAfterScroll" flag.

PR #160262.

  • Api/WebTapHighlight.h:
  • WebKitSupport/DefaultTapHighlight.cpp:

(BlackBerry::WebKit::DefaultTapHighlight::DefaultTapHighlight):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):
(BlackBerry::WebKit::DefaultTapHighlight::paintContents):

  • WebKitSupport/DefaultTapHighlight.h:

(BlackBerry::WebKit::DefaultTapHighlight::shouldHideAfterScroll):
(DefaultTapHighlight):

10:50 AM Changeset in webkit [118804] by morrita@google.com
  • 4 edits
    2 adds in trunk

ShadowRoot.getElementById() returns removed node.
https://bugs.webkit.org/show_bug.cgi?id=62184

Source/WebCore:

Deregitration of m_elementsById map is done at Element::removedFrom()
But the tree scope of the removed node is already reset from a shadow root
to a document.

This change lookup the old shadow root through its parent node and
deregitrater the node against it.

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/get-element-by-id-in-shadow-mutation.html

  • dom/Element.cpp:

(WebCore::treeScopeOfParent):
(WebCore):
(WebCore::Element::removedFrom):

  • dom/Element.h:

(Element):
(WebCore::Element::updateId):
(WebCore):

LayoutTests:

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/get-element-by-id-in-shadow-mutation-expected.txt: Added.
  • fast/dom/shadow/get-element-by-id-in-shadow-mutation.html: Added.
10:46 AM Changeset in webkit [118803] by danakj@chromium.org
  • 8 edits in trunk/Source

[chromium] Unoccluded area in surfaces should always be clipped to the rootScissorRect
https://bugs.webkit.org/show_bug.cgi?id=87677

Reviewed by Adrienne Walker.

Source/WebCore:

When a contributing surface is visited, and we have not visited another
surface, then we know the surface is completely unoccluded. However, the
root scissor rect should still be applied, and anything outside of it
should be considered occluded.

Unit test: WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::targetRenderSurface):
(WebCore):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::unoccludedContributingSurfaceContentRect):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::targetRenderSurface):
(WebCore):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCOcclusionTrackerTest.cpp:

(CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor):
(WebKitTests::CCOcclusionTrackerTestTopmostSurfaceIsClippedToScissor::runMyTest):
(WebKitTests):

10:23 AM Changeset in webkit [118802] by ap@apple.com
  • 2 edits in trunk/LayoutTests
  • platform/mac/Skipped: Skipping a heap profiler test (unsupported functionality).
10:14 AM Changeset in webkit [118801] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Refactoring http/proxy authentication to use authcallback mechanism introduced with libcurl
https://bugs.webkit.org/show_bug.cgi?id=87706

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-29
Reviewed by Antonio Gomes.

Because we use authentication callback mechanism of libcurl,
which will take care of all the authentication communication
between UA and server, so the only thing we need to do is to
provide credential information when authentication callback
is triggered. By using this we don't need to process
intermediate headers for each http authentication scheme.

Implemented interface function notifyAuthReceived() in
NetworkJob to handle the authentication notification from
networking thread.
When the authentication callback is triggered, we should
cancel the current loading request and restart a new one with
credential information attached which comes from
credentialStorage or user input.

Internally reviewed by Joe Mason <jmason@rim.com>.

No new tests since there is no behavior change.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyAuthReceived):
(WebCore):
(WebCore::NetworkJob::handleNotifyHeaderReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

10:02 AM Changeset in webkit [118800] by jberlin@webkit.org
  • 2 edits in branches/safari-536-branch/LayoutTests

Merge r118078, which skips the test added in r118039, onto the 536 branch.

WTR does not have support for layoutTestController.setPrinting yet.

  • platform/wk2/Skipped:
9:57 AM Changeset in webkit [118799] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] http authentication challenge issue when loading subresource
https://bugs.webkit.org/show_bug.cgi?id=87660

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-29
Reviewed by Rob Buis.

We should try to store the credential information as soon as we
receive http status notification which indicates that the
authentication succeeds, instead of storing credentials when the
main resource receives notify done which is too late for loading
subresource.

Internally reviewed by Joe Mason <jmason@rim.com>

No new tests since there is no change in behavior.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyStatusReceived):
(WebCore::NetworkJob::handleNotifyClose):

9:52 AM Changeset in webkit [118798] by ap@apple.com
  • 4 edits
    1 delete in trunk/Source/WebCore

[Mac] Move DefaultFonts.plist to C++ code
https://bugs.webkit.org/show_bug.cgi?id=87560
<rdar://problem/11466119>

Reviewed by Dan Bernstein.

  • DerivedSources.make:
  • Resources/DefaultFonts.plist.in: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/SettingsMac.mm: (WebCore::Settings::initializeDefaultFontFamilies):

Instead of having a separate configuration file, just hardcode the settings in C++.

9:49 AM Changeset in webkit [118797] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Regression: fast/forms/select/optgroup-clicking.html is failing / timing out
https://bugs.webkit.org/show_bug.cgi?id=87748

This test times out on Mac if there is no interaction with the keyboard. Skip it to keep the
bots green.

  • platform/mac/Skipped:
9:48 AM Changeset in webkit [118796] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] [WK2] Reproducible crash in performDragControllerAction
https://bugs.webkit.org/show_bug.cgi?id=87744

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-29
Reviewed by Martin Robinson.

Fix a crash by using deref() instead of delete to dereference and
release the platformData of DragData.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

9:47 AM Changeset in webkit [118795] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] Missing field initializers for WKPageLoaderClient and WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=87745

Patch by Simon Pena <Simon Pena> on 2012-05-29
Reviewed by Carlos Garcia Campos.

Add missing initializers for WKPageLoaderClient and
WKPageUIClient, for callbacks WKPagePluginDidFailCallback and
WKPageUnavailablePluginButtonClickedCallback, introduced in
revision r116716.

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView): Initialize WKPagePluginDidFailCallback

  • UIProcess/API/gtk/WebKitUIClient.cpp:

(attachUIClientToView): Initialize callback
WKPageUnavailablePluginButtonClickedCallback

9:44 AM Changeset in webkit [118794] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Policy decision headers are not included in the main webkit2.h header
https://bugs.webkit.org/show_bug.cgi?id=87753

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/webkit2.h: Include

WebKitNavigationPolicyDecision.h and WebKitResponsePolicyDecision.h.

9:36 AM Changeset in webkit [118793] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Web Inspector: Retainers are missing for all objects
https://bugs.webkit.org/show_bug.cgi?id=87655

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-29
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):

LayoutTests:

  • inspector/profiler/heap-snapshot-summary-retainers-expected.txt: Added.
  • inspector/profiler/heap-snapshot-summary-retainers.html: Added.
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

9:31 AM Changeset in webkit [118792] by commit-queue@webkit.org
  • 9 edits in trunk/LayoutTests

[GTK] fast tests needs rebaseline after r118733
https://bugs.webkit.org/show_bug.cgi?id=87729

Unreviewed GTK gardening, updated fast pngs.

Patch by Simon Pena <Simon Pena> on 2012-05-29

  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.png:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.png:
  • platform/gtk/fast/forms/placeholder-position-expected.png:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/gtk/fast/forms/search-styled-expected.png:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.png:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.png:
9:29 AM Changeset in webkit [118791] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Mac] fast/forms/select/optgroup-rendering.html "failing" since introduction in r118772
https://bugs.webkit.org/show_bug.cgi?id=87752

Add expected (failing?) results to get the bots green.

  • platform/mac/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/mac/fast/forms/select/optgroup-rendering-expected.txt: Added.
9:28 AM Changeset in webkit [118790] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening after r118776. The failing test was split into
5 separate tests, but we're still failing all of them.

  • platform/gtk/test_expectations.txt:
9:27 AM Changeset in webkit [118789] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

[GStreamer] Video sink doesn't respect WebKit code style
https://bugs.webkit.org/show_bug.cgi?id=87693

Reviewed by Alexis Menard.

No change in behavior of the sink, this patch only adapts the code
style to WebKit's.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(_WebKitVideoSinkPrivate):
(webkitVideoSinkTimeoutCallback):
(webkitVideoSinkRender):
(webkitVideoSinkDispose):
(unlockBufferMutex):
(webkitVideoSinkUnlock):
(webkitVideoSinkUnlockStop):
(webkitVideoSinkStop):
(webkitVideoSinkStart):
(webkitVideoSinkMarshalVoidAndMiniObject):
(webkit_video_sink_class_init):
(webkitVideoSinkNew):

  • platform/graphics/gstreamer/VideoSinkGStreamer.h:

(_WebKitVideoSink):
(_WebKitVideoSinkClass):

9:20 AM Changeset in webkit [118788] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Uninitialized shader compiler when GLES is used
https://bugs.webkit.org/show_bug.cgi?id=87712

The '#if !defined(QT_OPENGL_ES_2)' has been removed before the initialization
of shader compiler to compile shader codes for ES-platforms as well.

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-05-29
Reviewed by Noam Rosenthal.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

9:17 AM Changeset in webkit [118787] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[FileAPI] Miss FileList test
https://bugs.webkit.org/show_bug.cgi?id=87696

Patch by Li Yin <li.yin@intel.com> on 2012-05-29
Reviewed by Kentaro Hara.

WebKit should have the test to track the attribute of FileList.

  • fast/files/file-list-test-expected.txt: Added.
  • fast/files/file-list-test.html: Added.
9:09 AM Changeset in webkit [118786] by Carlos Garcia Campos
  • 8 edits in trunk/Source/WebKit2

[GTK] Add webkit_web_view_can_show_mime_type() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=85998

Reviewed by Martin Robinson.

And use it in the default handler of WebKitWebView::decide-policy
signal to decide whether to use or ignore a response policy
decision depending on whether the mime type of the response can be
displayed in the WebView or not.

  • UIProcess/API/gtk/WebKitURIResponse.cpp:

(webkitURIResponseGetProperty): Add getter for mime-type property.
(webkit_uri_response_class_init): Add mime-type property.
(webkit_uri_response_get_mime_type): Return the mime type of the
response.

  • UIProcess/API/gtk/WebKitURIResponse.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewDecidePolicy): In case of response policy decisions,
use the URI response to decide what to do: download if the
response is an attachment, use if the mime type is supported by
the web view or ignore otherwise.
(webkit_web_view_can_show_mime_type): Returns whether the given
mime type can be displayed in the WebView or not.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestResources.cpp:

(testWebResourceResponse):
(testWebResourceMimeType):
(serverCallback):
(beforeAll):

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewCanShowMIMEType):
(beforeAll):

9:06 AM Changeset in webkit [118785] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk/Source/WebKit

[BlackBerry] WebKit-side implementation of SelectionOverlay
https://bugs.webkit.org/show_bug.cgi?id=87605

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-29
Reviewed by Rob Buis.

Source/WebKit:

Add SelectionOverlay to the build system.

PR #160263

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Leverage the new WebOverlay API to move SelectionOverlay to the WebKit
library, so we always draw selection regardless of which embedder is
integrating WebKit.

PR #160263

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::selectionOverlay):
(WebKit):

  • Api/WebPage.h:

(WebKit):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebSelectionOverlay.h: Added.

(WebKit):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

  • WebKitSupport/SelectionOverlay.cpp: Added.

(WebKit):
(BlackBerry::WebKit::SelectionOverlay::SelectionOverlay):
(BlackBerry::WebKit::SelectionOverlay::~SelectionOverlay):
(BlackBerry::WebKit::SelectionOverlay::draw):
(BlackBerry::WebKit::SelectionOverlay::hide):
(BlackBerry::WebKit::SelectionOverlay::notifySyncRequired):
(BlackBerry::WebKit::SelectionOverlay::paintContents):

  • WebKitSupport/SelectionOverlay.h: Added.

(WebKit):
(SelectionOverlay):
(BlackBerry::WebKit::SelectionOverlay::create):
(BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):
(BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
(BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):
(BlackBerry::WebKit::SelectionOverlay::contentsVisible):

9:02 AM Changeset in webkit [118784] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Mac] fast/events/message-port-constructor-for-deleted-document.html ASSERTS in Debug.

This is happening often enough that it is necessary to add the test to the Mac Skipped list
in order to keep the bots green.

  • platform/mac/Skipped:
9:00 AM Changeset in webkit [118783] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Add InspectorFileSystemAgent::FrontendProvider
https://bugs.webkit.org/show_bug.cgi?id=87635

InspectorFileSystemAgent needs weak reference to its frontend to perform
asynchronous operation.

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-05-29
Reviewed by Yury Semikhatsky.

  • inspector/InspectorFileSystemAgent.cpp:

(InspectorFileSystemAgent::FrontendProvider):
(WebCore):
(WebCore::InspectorFileSystemAgent::~InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::enable):
(WebCore::InspectorFileSystemAgent::disable):
(WebCore::InspectorFileSystemAgent::setFrontend):
(WebCore::InspectorFileSystemAgent::clearFrontend):
(WebCore::InspectorFileSystemAgent::restore):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):

  • inspector/InspectorFileSystemAgent.h:

(InspectorFileSystemAgent):

8:52 AM Changeset in webkit [118782] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][DRT] move idn encoding test to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=86080

Unreviewed gardening. Implementing copy{En,De}codedHostName just
to test them is not useful: marking fast/encoding/idn-security.html
as expected to fail.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-05-29

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
8:28 AM Changeset in webkit [118781] by Csaba Osztrogonác
  • 7 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/compositing/geometry/composited-in-columns-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/qt-5.0-wk2/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/qt-5.0-wk2/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/qt-5.0-wk2/svg/css/text-gradient-shadow-expected.txt:
  • platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/wk2/Skipped:
8:20 AM Changeset in webkit [118780] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Regression: fast/forms/select/optgroup-clicking.html is failing
https://bugs.webkit.org/show_bug.cgi?id=87748

Unreviewed gardening.

This test was added by r118772 and it fails with a mismatch in menulist.selectedIndex.

  • platform/chromium/test_expectations.txt:
8:12 AM Changeset in webkit [118779] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Fix new layout tests for images with color profiles by using fixed size
https://bugs.webkit.org/show_bug.cgi?id=87542

Patch by Tony Payne <tpayne@chromium.org> on 2012-05-29
Reviewed by Kent Tamura.

  • fast/images/jpeg-with-color-profile.html: Use width=400px instead of 50% to make sure size is consistent across ports.
  • fast/images/png-with-color-profile.html: Use width=40px instead of 50% to make sure size is consistent across ports.
8:08 AM Changeset in webkit [118778] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed: Web Inspector: single line fix.
heap-snapshot-loader are failing in Debug configuration because the list of profiles is not empty.

  • inspector/profiler/heap-snapshot-loader.html:
7:56 AM Changeset in webkit [118777] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] OpenGL content is not rendered on simulator
https://bugs.webkit.org/show_bug.cgi?id=87721

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-29
Reviewed by George Staikos.

Fixed by enabling GLES2 support in simulator builds.

To experiment with building without OpenGL support, you can set the
DISABLE_GLES2 environment variable to a non-empty string and rebuild.

PR #150695

  • Scripts/webkitdirs.pm:

(blackberryCMakeArguments):

7:53 AM Changeset in webkit [118776] by bulach@chromium.org
  • 1 edit
    4 copies
    1 move
    6 adds
    1 delete in trunk/LayoutTests

Split svg/dom/viewspec-parser.html in smaller tests
https://bugs.webkit.org/show_bug.cgi?id=87726

Reviewed by Andreas Kling.

This test was added by r118735.
Splits into smaller independent tests to avoid timeouts on ports such as chromium.

  • svg/dom/resources/viewspec-parser.js: Added.

(buildTestsToRun):
(zoomAndPanToString):
(viewSpecToString):
(testString.string_appeared_here.makeURLRelative):
(testFragment):
(startNextTest):
(continueFuzzing.else.script.onload):
(continueFuzzing):

  • svg/dom/viewspec-parser-1-expected.txt: Copied from LayoutTests/svg/dom/viewspec-parser-expected.txt.
  • svg/dom/viewspec-parser-1.html: Added.
  • svg/dom/viewspec-parser-2-expected.txt: Copied from LayoutTests/svg/dom/viewspec-parser-expected.txt.
  • svg/dom/viewspec-parser-2.html: Added.
  • svg/dom/viewspec-parser-3-expected.txt: Copied from LayoutTests/svg/dom/viewspec-parser-expected.txt.
  • svg/dom/viewspec-parser-3.html: Added.
  • svg/dom/viewspec-parser-4-expected.txt: Copied from LayoutTests/svg/dom/viewspec-parser-expected.txt.
  • svg/dom/viewspec-parser-4.html: Added.
  • svg/dom/viewspec-parser-5-expected.txt: Renamed from LayoutTests/svg/dom/viewspec-parser-expected.txt.
  • svg/dom/viewspec-parser-5.html: Added.
  • svg/dom/viewspec-parser.html: Removed.
7:45 AM Changeset in webkit [118775] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed gardening, skip failing tests.

  • platform/mac/Skipped:
  • platform/qt/Skipped:
7:44 AM Changeset in webkit [118774] by commit-queue@webkit.org
  • 14 edits in trunk

Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
https://bugs.webkit.org/show_bug.cgi?id=87685

Patch by David Barr <davidbarr@chromium.org> on 2012-05-29
Reviewed by Eric Seidel.

Add a configuration option for CSS image-resolution support, disabling it by default.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:
7:09 AM Changeset in webkit [118773] by apavlov@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebCore/platform/chromium/PopupContainer.cpp

Merge 118768 - [Chromium] [Regression] SELECT popup misplaced when there is not enough vertical space
https://bugs.webkit.org/show_bug.cgi?id=87735

Reviewed by Kent Tamura.

This change fixes the obsolete WebWidget Y-repositioning code for the insufficient vertical space case, not removed in r113418.

No new tests, as popups are not testable in Chromium.

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::layoutAndCalculateWidgetRect):

TBR=apavlov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10442063

7:00 AM Changeset in webkit [118772] by yosin@chromium.org
  • 7 edits
    8 adds in trunk

REGRESSION(r109729): The optgroup element's "disabled" attribute has no effect to rendering and selection
https://bugs.webkit.org/show_bug.cgi?id=87614

Reviewed by Kent Tamura.

Source/WebCore:

This patch adds HTMLOptGroupElement::disabled and isEnabledFormControl
methods which was implemented in HTMLFormControlElement at r109729 and
updates CSS pseudo class checker to check "optgroup" element.

Tests: fast/forms/select/optgroup-clicking.html

fast/forms/select/optgroup-disabled.html
fast/forms/select/optgroup-rendering.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): On disabled and enabled pseudo class checker.
We checked tag name "optgroup" in addition isFormControlElement.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement): Checks optgroup.disabled.

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::disabled): Added.

  • html/HTMLOptGroupElement.h:

(HTMLOptGroupElement): Added isEnabledFormControl.

LayoutTests:

Note: An image for optgroup-rendering.html will be change due by
BUG-87719. Color of option elements should be blue (:enabled
pseudo class) instead of green.

  • fast/forms/select/optgroup-clicking-expected.txt: Added.
  • fast/forms/select/optgroup-clicking.html: Added.
  • fast/forms/select/optgroup-disabled-expected.txt: Added.
  • fast/forms/select/optgroup-disabled.html: Added.
  • fast/forms/select/optgroup-rendering.html: Added.
  • platform/chromium/test_expectations.txt: Add MISSING entry for optgroup-rendering.html.
  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.txt: Added.
6:57 AM Changeset in webkit [118771] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

REGRESSION(r118742): It made inspector/profiler/heap-snapshot-loader.html fail on Lion, Qt
https://bugs.webkit.org/show_bug.cgi?id=87741

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-29
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip the failing test.
6:53 AM Changeset in webkit [118770] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[EFL] Tests needs gardening after r118733
https://bugs.webkit.org/show_bug.cgi?id=87733

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-29

  • platform/efl/fast/css/text-overflow-input-expected.txt:
  • platform/efl/fast/forms/search-styled-expected.png:
  • platform/efl/fast/forms/search-styled-expected.txt:
  • platform/efl/test_expectations.txt:
6:53 AM Changeset in webkit [118769] by vestbo@webkit.org
  • 2 edits in trunk/Source/WTF

[Qt] Remove duplication of logic for disabling selected warnings related to C++11

This is already handled in unix/default_post.prf

Reviewed by Simon Hausmann.

6:41 AM Changeset in webkit [118768] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] [Regression] SELECT popup misplaced when there is not enough vertical space
https://bugs.webkit.org/show_bug.cgi?id=87735

Reviewed by Kent Tamura.

This change fixes the obsolete WebWidget Y-repositioning code for the insufficient vertical space case, not removed in r113418.

No new tests, as popups are not testable in Chromium.

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::layoutAndCalculateWidgetRect):

6:39 AM Changeset in webkit [118767] by commit-queue@webkit.org
  • 7 edits
    2 adds
    2 deletes in trunk

[CSS Regions]Rename NamedFlow::overflow to NamedFlow::overset
https://bugs.webkit.org/show_bug.cgi?id=87491

This patch updates the CSSOM property name overflow to overset. There are no changes in functionality.
Link to spec: http://www.w3.org/TR/2012/WD-css3-regions-20120503/

Source/WebCore:

Patch by Andrei Bucur <abucur@adobe.com> on 2012-05-29
Reviewed by Andreas Kling.

Test: fast/regions/webkit-named-flow-overset.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::overset):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::computeOverflowStateForRegions):

  • rendering/RenderFlowThread.h:

LayoutTests:

The test was refactored to be more similar to the other script tests (by using make-new-script-test)

Patch by Andrei Bucur <abucur@adobe.com> on 2012-05-29
Reviewed by Andreas Kling.

  • fast/regions/webkit-named-flow-overflow-expected.txt: Removed.
  • fast/regions/webkit-named-flow-overflow.html: Removed.
  • fast/regions/webkit-named-flow-overset-expected.txt: Added.
  • fast/regions/webkit-named-flow-overset.html: Added.
6:37 AM Changeset in webkit [118766] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8
https://bugs.webkit.org/show_bug.cgi?id=87740

Unreviewed gardening.

  • platform/qt-4.8/Skipped: Skip fast/forms/textarea-maxlength.html until proper fix.
6:34 AM Changeset in webkit [118765] by Csaba Osztrogonác
  • 5 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-4.8/Skipped: Skip fast/parser/innerhtml-with-prefixed-elements.xhtml because of buggy QtXmlPatterns.
  • platform/qt-5.0/Skipped: Unskip fast/parser/innerhtml-with-prefixed-elements.xhtml, because libxslt works fine.
  • platform/qt/Skipped: Unskip a non-existing test.
  • platform/qt/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
  • platform/qt/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Updated.
6:26 AM Changeset in webkit [118764] by kenneth@webkit.org
  • 1 edit
    4 moves in trunk/Source/WebKit2

[Qt] Move tests from DesktopBehavior which can be made to work
https://bugs.webkit.org/show_bug.cgi?id=87736

Rubberstamped by Simon Hausmann.

Move and modify the following tests to WebView/ and make them
use touch events.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_itemSelector.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_messaging.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_messaging.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_multiFileUpload.qml.
  • UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_singleFileUpload.qml.
6:21 AM Changeset in webkit [118763] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't add cxx-flags to QMAKE_CFLAGS

Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is

valid for C++/ObjC++ but not for C [enabled by default]"

Reviewed by Simon Hausmann.

6:17 AM Changeset in webkit [118762] by vestbo@webkit.org
  • 15 edits in trunk

[Qt] Sync up favicon-implementation with WebView url changes in r118158

https://bugs.webkit.org/show_bug.cgi?id=87133

We now base64-encode the page url in the image-provider url, so that any
normalization done by QUrl will not mess up the page-url. The logic of
creating and parsing the provider-url has been moved into the image
provider, to keep it in one place.

We were also releasing icons (even ones we hadn't retained), which we can't
do since we don't know when the icon url is no longer in use.

Reviewed-by Simon Hausmann.

5:25 AM Changeset in webkit [118761] by kling@webkit.org
  • 24 edits in trunk/Source/WebCore

Give StylePropertySet a proper mutability flag.
<http://webkit.org/b/87675>

Reviewed by Antti Koivisto.

Add a flag to StylePropertySet that determines whether it's mutable or not. Only objects
constructed from the CSS parser (by way of StylePropertySet::adopt()) are made immutable.
This is clean-up and prep work for implementing a more efficient storage scheme for immutable
StylePropertySets (fixed-size array instead of vector) as the vast majority of them are
unlikely to ever mutate during their lifetime.

Sprinkled ASSERT(isMutable()) all over StylePropertySet to catch any attempts to modify
an immutable object.

Also made properties() const on StyleRule and friends, which brought some additional code
churn along with it.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::reattach):

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs):

  • css/CSSFontFaceSrcValue.h:

(CSSFontFaceSrcValue):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::reattach):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::addSubresourceStyleURLs):

  • css/CSSReflectValue.h:

(CSSReflectValue):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::style):
(WebCore::CSSStyleRule::reattach):

  • css/CSSValue.cpp:

(WebCore::CSSValue::addSubresourceStyleURLs):

  • css/CSSValue.h:

(CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::addSubresourceStyleURLs):

  • css/CSSValueList.h:

(CSSValueList):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::setCSSParserMode):
(WebCore):
(WebCore::StylePropertySet::copyPropertiesFrom):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addParsedProperties):
(WebCore::StylePropertySet::addParsedProperty):
(WebCore::StylePropertySet::merge):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::findPropertyWithId):
(WebCore::StylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::copyPropertiesInSet):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::adopt):
(WebCore::StylePropertySet::adoptMutable):
(StylePropertySet):
(WebCore::StylePropertySet::isMutable):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::addMatchedProperties):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(StyleResolver):

  • css/StyleRule.cpp:

(WebCore::StyleRule::mutableProperties):
(WebCore):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::mutableProperties):

  • css/StyleRule.h:

(WebCore::StyleRule::properties):
(StyleRule):
(WebCore::StyleRuleFontFace::properties):
(StyleRuleFontFace):
(WebCore::StyleRulePage::properties):
(StyleRulePage):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):

  • editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::parseAttribute):
(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::removedFrom):

5:13 AM Changeset in webkit [118760] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
https://bugs.webkit.org/show_bug.cgi?id=87654

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-29
Reviewed by Csaba Osztrogonác.

Source/WebCore:

Evas key events already provide key string, so no practical need for singleCharacterString()
evaluating the event string from keyname.
Modified code related functionality is already covered with fast/events and fast/forms tests.

  • platform/efl/EflKeyboardUtilities.cpp:
  • platform/efl/PlatformKeyboardEventEfl.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

Tools:

Event sender provides strings for all the key events.
Also KeyEventInfo constructor parameters order was changed to simplify the case when
a key event has empty string.

  • DumpRenderTree/efl/EventSender.cpp:

(KeyEventInfo::KeyEventInfo):
(keyPadNameFromJSValue):
(keyNameFromJSValue):

5:10 AM Changeset in webkit [118759] by zandobersek@gmail.com
  • 11 edits in trunk/LayoutTests

Unreviewed GTK gardening after r118733 and r118735.

  • platform/gtk/fast/css/text-overflow-input-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/gtk/test_expectations.txt:
5:09 AM Changeset in webkit [118758] by kenneth@webkit.org
  • 8 edits in trunk/Source/WebKit2

[Qt][WK2] Fix failing qmltests::FitToView::test_basic()
https://bugs.webkit.org/show_bug.cgi?id=87236

Reviewed by Simon Hausmann.

The fix is a combination of things. First of all some events
were emitted at the wrong times or when nothing had changed.

We also initialized the view saying it was suspended which is
not correct.

Another bug was that the touch tap, didn't result in marking
the view as having user interaction. This was recently fixed
in r118493.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::setContentsScale):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):

Make sure pageIsSuspended is initialized to false.

(QQuickWebViewFlickablePrivate::_q_onInformVisibleContentChange):

Early bail out if there is no change.

Inform contentScaleCommitted if the scale changed since last time.

(QQuickWebViewFlickablePrivate::didChangeContentsSize):

Make sure to commit the right signals, ie. *Changed and not *Committed.

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebkittest.cpp:

(touchPoint):
(QWebKitTest::sendTouchEvent):
(QWebKitTest::touchTap):
(QWebKitTest::touchDoubleTap):

Add proper touch emulation for the testing system. Call directly
to our WebKit API (avoid Qt event loop) to ensure all events gets
delivered.

  • UIProcess/API/qt/qwebkittest_p.h:
  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::setItemRectVisible):

Assert that a ViewportUpdateDeferrer is always used when calling
this method.

(WebKit::QtViewportInteractionEngine::animateItemRectVisible):

Remove work around now we have the proper fix in place.

(WebKit::QtViewportInteractionEngine::pagePositionRequest):

Do not send the informVisibleContentChange manually, use the
ViewportUpdateDeferrer instead.

(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):

Add missing ViewportUpdateDeferrer.

(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

No reason to emit informVisibleContentChange before pinch
start, as it is always done on end (due to the ViewportUpdateDeferrer).

(WebKit::QtViewportInteractionEngine::itemSizeChanged):

Add missing ViewportUpdateDeferrer.

4:43 AM Changeset in webkit [118757] by kkristof@inf.u-szeged.hu
  • 10 edits in trunk/LayoutTests

[Qt] Unreviewed Gardening. Update test expectations after r118733.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-29

  • platform/qt/fast/css/text-overflow-input-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/qt/fast/forms/placeholder-position-expected.txt:
  • platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
4:43 AM Changeset in webkit [118756] by caio.oliveira@openbossa.org
  • 10 edits
    5 adds in trunk/Source/WebKit2

[Qt] [WK2] Allow user to inject JS scripts when the page loads
https://bugs.webkit.org/show_bug.cgi?id=85827

Reviewed by Simon Hausmann.

Create a new experimental property to list URLs of JS scripts that should be
loaded when a page is loaded. These scripts will run in the normal JS environment
of the page.

The supported URL schemes are file:/// and qrc:///. The scripts are read from the
UI process and transfered to the Web process.

Together with the experimental messaging API this provides a way for the
application to manipulate the DOM (by injecting a script that does the
manipulation and communicating with it via postMessage). This covers some of the
use cases of QWebElement in our WK1 API.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didRelaunchProcess):
(readUserScript):
(QQuickWebViewPrivate::updateUserScripts):
(QQuickWebViewExperimental::userScripts):
(QQuickWebViewExperimental::setUserScripts):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qmltests/WebView.pro:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_userScripts.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/append-document-title.js: Added.
  • UIProcess/API/qt/tests/qmltests/common/big-user-script.js: Added.
  • UIProcess/API/qt/tests/qmltests/common/change-document-title.js: Added.
  • UIProcess/API/qt/tests/qmltests/resources.qrc: Added.
  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::setUserScripts):
(WebKit):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::setUserScripts):
(WebKit):

4:42 AM Changeset in webkit [118755] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Cancel potential url-edit when going back/forward

Reviewed by Kenneth Rohde Christiansen.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
4:37 AM Changeset in webkit [118754] by caio.oliveira@openbossa.org
  • 10 edits in trunk/Source/WebKit2

Unreviewed, rolling out r118752.
http://trac.webkit.org/changeset/118752
https://bugs.webkit.org/show_bug.cgi?id=87731

incomplete patch (Requested by cmarcelo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-29

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didRelaunchProcess):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qmltests/WebView.pro:
  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/qt/WebPageProxyQt.cpp:
  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:
4:36 AM Changeset in webkit [118753] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping failing test
See https://bugs.webkit.org/show_bug.cgi?id=87728

  • platform/mac/Skipped:
4:22 AM Changeset in webkit [118752] by caio.oliveira@openbossa.org
  • 10 edits in trunk/Source/WebKit2

[Qt] [WK2] Allow user to inject JS scripts when the page loads
https://bugs.webkit.org/show_bug.cgi?id=85827

Reviewed by Simon Hausmann.

Create a new experimental property to list URLs of JS scripts that should be
loaded when a page is loaded. These scripts will run in the normal JS environment
of the page.

The supported URL schemes are file:/// and qrc:///. The scripts are read from the
UI process and transfered to the Web process.

Together with the experimental messaging API this provides a way for the
application to manipulate the DOM (by injecting a script that does the
manipulation and communicating with it via postMessage). This covers some of the
use cases of QWebElement in our WK1 API.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::didRelaunchProcess):
(readUserScript):
(QQuickWebViewPrivate::updateUserScripts):
(QQuickWebViewExperimental::userScripts):
(QQuickWebViewExperimental::setUserScripts):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/API/qt/tests/qmltests/WebView.pro:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_userScripts.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/append-document-title.js: Added.
  • UIProcess/API/qt/tests/qmltests/common/big-user-script.js: Added.
  • UIProcess/API/qt/tests/qmltests/common/change-document-title.js: Added.
  • UIProcess/API/qt/tests/qmltests/resources.qrc: Added.
  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::setUserScripts):
(WebKit):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::setUserScripts):
(WebKit):

4:14 AM Changeset in webkit [118751] by Stephanie Lewis
  • 10 edits
    3 adds in trunk/LayoutTests

Unreviewed, updating results after http://trac.webkit.org/projects/webkit/changeset/118733

  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
4:14 AM Changeset in webkit [118750] by commit-queue@webkit.org
  • 7 edits
    9 adds in trunk/Source/WebKit

[BlackBerry] WebOverlay API
https://bugs.webkit.org/show_bug.cgi?id=87603

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-29
Reviewed by Rob Buis.

Source/WebKit:

Add WebOverlay related files to the build system.

PR #156812

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

This new API makes it possible to leverage the BlackBerry accelerated
compositing implementation to draw, transform and fluidly animate
overlays in the embedding library or application.

A WebOverlay has an affinity for the thread where it was created. If
the current thread is the WebKit thread, use WebPage::addOverlay() to
add it to the page, and manipulate it only from the WebKit thread, with
exception of the "override" functionality which can be used from the
compositing thread. If the current thread is the compositing thread,
use WebPage::addCompositingThreadOverlay() to add it to the page, and
only manipulate it on the compositing thread.

A WebOverlay can be painted using Skia, or its contents can be set to
an image or a solid color.

PR #156812

  • Api/WebAnimation.cpp: Added.

(WebKit):
(BlackBerry::WebKit::WebAnimation::fadeAnimation):
(BlackBerry::WebKit::WebAnimation::name):
(BlackBerry::WebKit::WebAnimation::WebAnimation):
(BlackBerry::WebKit::WebAnimation::~WebAnimation):
(BlackBerry::WebKit::WebAnimation::operator=):

  • Api/WebAnimation.h: Added.

(WebKit):

  • Api/WebAnimation_p.h: Added.

(WebKit):
(WebAnimationPrivate):
(BlackBerry::WebKit::WebAnimationPrivate::WebAnimationPrivate):

  • Api/WebOverlay.cpp: Added.

(WebKit):
(BlackBerry::WebKit::WebOverlay::WebOverlay):
(BlackBerry::WebKit::WebOverlay::~WebOverlay):
(BlackBerry::WebKit::WebOverlay::position):
(BlackBerry::WebKit::WebOverlay::setPosition):
(BlackBerry::WebKit::WebOverlay::anchorPoint):
(BlackBerry::WebKit::WebOverlay::setAnchorPoint):
(BlackBerry::WebKit::WebOverlay::size):
(BlackBerry::WebKit::WebOverlay::setSize):
(BlackBerry::WebKit::WebOverlay::sizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlay::setSizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlay::transform):
(BlackBerry::WebKit::WebOverlay::setTransform):
(BlackBerry::WebKit::WebOverlay::opacity):
(BlackBerry::WebKit::WebOverlay::setOpacity):
(BlackBerry::WebKit::WebOverlay::addAnimation):
(BlackBerry::WebKit::WebOverlay::removeAnimation):
(BlackBerry::WebKit::WebOverlay::parent):
(BlackBerry::WebKit::WebOverlay::addChild):
(BlackBerry::WebKit::WebOverlay::removeFromParent):
(BlackBerry::WebKit::WebOverlay::setContentsToImage):
(BlackBerry::WebKit::WebOverlay::setContentsToColor):
(BlackBerry::WebKit::WebOverlay::setDrawsContent):
(BlackBerry::WebKit::WebOverlay::invalidate):
(BlackBerry::WebKit::WebOverlay::setClient):
(BlackBerry::WebKit::WebOverlay::override):
(BlackBerry::WebKit::WebOverlay::resetOverrides):
(BlackBerry::WebKit::WebOverlayPrivate::page):
(BlackBerry::WebKit::WebOverlayPrivate::override):
(BlackBerry::WebKit::WebOverlayPrivate::drawContents):
(BlackBerry::WebKit::WebOverlayPrivate::scheduleCompositingRun):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::WebOverlayPrivateWebKitThread):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::override):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::position):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setPosition):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::anchorPoint):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::size):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setSize):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::sizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setSizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::transform):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setTransform):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::opacity):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setOpacity):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::addAnimation):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::removeAnimation):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::addChild):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::removeFromParent):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setContentsToColor):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::setDrawsContent):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::clear):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::invalidate):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::resetOverrides):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifySyncRequired):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::~WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setDrawsContent):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::invalidate):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerCompositingThreadDestroyed):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::layerVisibilityChanged):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::deleteTextures):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setClient):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::override):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::position):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setPosition):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::anchorPoint):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::size):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setSize):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::sizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setSizeIsScaleInvariant):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::transform):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setTransform):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::opacity):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setOpacity):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::addAnimation):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeAnimation):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::addChild):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToColor):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setDrawsContent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::clear):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::invalidate):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::resetOverrides):

  • Api/WebOverlay.h: Added.

(WebCore):
(WebKit):

  • Api/WebOverlayClient.h: Added.

(WebKit):

  • Api/WebOverlayOverride.cpp: Added.

(WebKit):
(BlackBerry::WebKit::WebOverlayOverride::WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::~WebOverlayOverride):
(BlackBerry::WebKit::WebOverlayOverride::setPosition):
(BlackBerry::WebKit::WebOverlayOverride::setAnchorPoint):
(BlackBerry::WebKit::WebOverlayOverride::setSize):
(BlackBerry::WebKit::WebOverlayOverride::setTransform):
(BlackBerry::WebKit::WebOverlayOverride::setOpacity):
(BlackBerry::WebKit::WebOverlayOverride::addAnimation):
(BlackBerry::WebKit::WebOverlayOverride::removeAnimation):

  • Api/WebOverlayOverride.h: Added.

(WebKit):

  • Api/WebOverlay_p.h: Added.

(WTF):
(WebCore):
(WebKit):
(WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivate::WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivate::~WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivate::setPage):
(BlackBerry::WebKit::WebOverlayPrivate::setClient):
(BlackBerry::WebKit::WebOverlayPrivate::layerCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivate::graphicsLayer):
(WebOverlayPrivateWebKitThread):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::graphicsLayer):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::contentsVisible):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setLayer):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawsContent):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::contents):
(WebOverlayPrivateCompositingThread):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::addOverlay):
(WebKit):
(BlackBerry::WebKit::WebPage::removeOverlay):
(BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
(BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):

  • Api/WebPage.h:

(WebKit):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::compositeLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::addOverlay):
(BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):

  • Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::compositingThreadOverlayLayer):
(WebPageCompositorPrivate):

4:14 AM Changeset in webkit [118749] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed: Web Inspector: single line fix after r118742.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapProfileHeader.prototype.saveToFile):

3:42 AM Changeset in webkit [118748] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Remove m_rootNode and m_selectorChecker from SelectorQuery.h
https://bugs.webkit.org/show_bug.cgi?id=87650

Reviewed by Antti Koivisto.

To avoid parsing CSS selectors every time, I am planning to cache
SelectorQuery objects into a HashMap, which will be defined in
Node::querySelector(). To make the size of SelectorQuery small,
this patch removes m_rootNode and m_selectorChecker from SelectorQuery.h.

Tests: fast/dom/SelectorAPI/*. No change in test results.

  • dom/Node.cpp:

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::SelectorQuery):
(WebCore):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

  • dom/SelectorQuery.h:

(SelectorQuery):

3:06 AM Changeset in webkit [118747] by caseq@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Tabbed Settings Screen
https://bugs.webkit.org/show_bug.cgi?id=87497

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-29
Reviewed by Yury Semikhatsky.

Combine settings screen and shortcuts screen
to a single tabbed settings screen.
This will make shortcuts screen more discoverable.

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen): Make titled tamplate optional.
(WebInspector.HelpScreen.prototype._createCloseButton): Extract method.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen): Split initialization and UI construction.
(WebInspector.SettingsScreen.prototype._createSettingsTabView.appendSection):
(WebInspector.SettingsScreen.prototype._createSettingsTabView):
Extract GUI construction method.
(WebInspector.SettingsScreen.prototype._getOrCreateTabbedPane):
Make GUI construction lazy.
(WebInspector.SettingsScreen.prototype.selectTab):
Add method for external tab swithching.
(WebInspector.SettingsScreen.prototype.wasShown):
Make GUI construction lazy.
(WebInspector.SettingsScreenTabbedPane):
Extend class to access protected member.
(WebInspector.SettingsController.prototype._buttonClicked):
Change "showSettingsScreen" visibility and parameters.
(WebInspector.SettingsController.prototype._onHideSettingsScreen):
Preserve settings screen state.
(WebInspector.SettingsController.prototype.showSettingsScreen):
Change method visibility and parameters.

  • inspector/front-end/ShortcutsScreen.js:

(WebInspector.ShortcutsScreen): Remove inheritance from HelpScreen.
(WebInspector.ShortcutsScreen.prototype._createShortcutsTabView):
Refactoring of GUI construction.
(WebInspector.ShortcutsSection.prototype.renderSection):
Ditto.

  • inspector/front-end/helpScreen.css:

(.help-window-main ::-webkit-scrollbar): Rebind scrollbar settings.
(.help-window-main ::-webkit-resizer): Ditto.
(.help-window-main ::-webkit-scrollbar-thumb:vertical): Ditto.
(.help-window-main ::-webkit-scrollbar-thumb:vertical:active): Ditto.
(.help-window-main ::-webkit-scrollbar-track:vertical): Ditto.
(body:not(.compact) #settings-screen .tabbed-pane): Fix container height.
(#settings-screen .tabbed-pane-header): Ditto.
(#settings-screen .tabbed-pane-header-tabs): Adjust spacing.
(#settings-screen .tabbed-pane-header-tab): Adjust style.
(#settings-screen .help-close-button): Adjust spacing.
(#settings-screen .tabbed-pane-header-tab.selected):
Erase line below active tab.
(#settings-screen .tabbed-pane-content): Adjust spacing.
(#settings-screen .help-content): Ditto.

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown): Use Settings screen to show shortcuts.

2:43 AM Changeset in webkit [118746] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
2:35 AM Changeset in webkit [118745] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations
https://bugs.webkit.org/show_bug.cgi?id=87155

More placehodler tests.

  • platform/chromium/test_expectations.txt:
2:29 AM Changeset in webkit [118744] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=87155

Placeholder-related render dumps need to be udpated.

  • platform/chromium/test_expectations.txt:
2:20 AM Changeset in webkit [118743] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r118618. http/tests/cache/cancel-in-progress-load.html
fails with code 5.
https://bugs.webkit.org/show_bug.cgi?id=35377

Patch by János Badics <János Badics> on 2012-05-29

  • platform/qt/Skipped:
2:17 AM Changeset in webkit [118742] by loislo@chromium.org
  • 8 edits in trunk

Web Inspector: REGRESSION: load heap snapshot doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=87642

Source/WebCore:

HeapSnapshotReceiver interface was introduced.
It declares the API for HeapSnapshotLoader, HeapSnapshotLoaderProxy and HeapSnapshotSaveToFileReceiver.
The HeapProfileHeader was refactored and tests were added.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshotLoader.js:

(WebInspector.HeapSnapshotLoader):
(WebInspector.HeapSnapshotLoader.prototype.startLoading):
(WebInspector.HeapSnapshotLoader.prototype.dispose):
(WebInspector.HeapSnapshotLoader.prototype._reset):
(WebInspector.HeapSnapshotLoader.prototype.finishLoading):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker.prototype.startCheckingForLongRunningCalls):
(WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotReceiver):
(WebInspector.HeapSnapshotReceiver.prototype.startLoading):
(WebInspector.HeapSnapshotReceiver.prototype.pushJSONChunk):
(WebInspector.HeapSnapshotReceiver.prototype.finishLoading):
(WebInspector.HeapSnapshotReceiver.prototype.dispose):
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
(WebInspector.HeapProfileHeader.prototype.dispose):
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate):
(WebInspector.HeapProfileHeader.prototype.pushJSONChunk):
(WebInspector.HeapProfileHeader.prototype._parsed):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.saveToFile):
(WebInspector.HeapProfileHeader.prototype.loadFromFile.onLoad):
(WebInspector.HeapProfileHeader.prototype.loadFromFile):
(WebInspector.HeapProfileHeader.prototype._loadNextChunk):
(WebInspector.HeapProfileHeader.prototype._nextChunkLoaded):
(WebInspector.HeapProfileHeader.prototype._createFileReader):
(WebInspector.HeapSnapshotSaveToFileReceiver):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype.startLoading):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype.pushJSONChunk):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype.finishLoading):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype.dispose):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype._startSavingSnapshot):
(WebInspector.HeapSnapshotSaveToFileReceiver.prototype._saveStatusUpdate):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._createFileSelectorElement.onChange):
(WebInspector.ProfilesPanel.prototype._createFileSelectorElement):
(WebInspector.ProfilesPanel.prototype._loadFromFile):

LayoutTests:

HeapSnapshotReceiver interface was introduced.
It declares the API for HSLoader, HSLoaderProxy and HSSaveToFileReceiver.
The HeapProfileHeader was refactored and tests were added.

Reviewed by Yury Semikhatsky.

  • inspector/profiler/heap-snapshot-loader-expected.txt:
  • inspector/profiler/heap-snapshot-loader.html:
2:12 AM Changeset in webkit [118741] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

Test expectation pngs missing checksums are treated as MISSING by bots
https://bugs.webkit.org/show_bug.cgi?id=87552

Unreviewed gardening.

This test was already failing for IMAGE and TEXT reasons prior to r118566.
On r118566, new images were added, probably without an embedded checksum.
It looks like our test infrastructure thinks that these images are MISSING.
Temporarily add MISSING expectations, so that we can proceed with this (failing) test.

  • platform/chromium/test_expectations.txt:
2:10 AM Changeset in webkit [118740] by hbono@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Use WebSpellCheckClient::spellcheck to retrieve suggestions.
https://bugs.webkit.org/show_bug.cgi?id=87690

Reviewed by Hajime Morita.

This change uses WebSpellCheckClient::spellcheck as a fallback method to
retrieve suggestions when a marker does not have any suggestions. (It consumes
lots of CPU power to get suggestions for misspelled word, i.e. Chromium cannot
afford to attach suggestions to all spelling markers.)

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Retrieve suggestions if markers do not have any.

2:06 AM Changeset in webkit [118739] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

[EFL] MathML tests needs rebaseline after r118713
https://bugs.webkit.org/show_bug.cgi?id=87705

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-29

  • platform/efl/mathml/presentation/mo-stretch-expected.png:
  • platform/efl/mathml/presentation/mo-stretch-expected.txt:
  • platform/efl/mathml/presentation/mroot-pref-width-expected.png:
  • platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
  • platform/efl/mathml/presentation/tables-expected.png:
  • platform/efl/mathml/presentation/tables-expected.txt:
2:05 AM Changeset in webkit [118738] by kkristof@inf.u-szeged.hu
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r118585. Added Qt platform specific expected files.
https://bugs.webkit.org/show_bug.cgi?id=86848

Patch by János Badics <János Badics> on 2012-05-29

  • platform/qt/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
  • platform/qt/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.
2:01 AM Changeset in webkit [118737] by eric@webkit.org
  • 11 edits in trunk

Add HTMLIFrameElement.seamless property accessor now that seamless is enabled and works
https://bugs.webkit.org/show_bug.cgi?id=87708

Reviewed by Adam Barth.

Source/WebCore:

Lots of tests in fast/frames/seamless cover this property.

  • html/HTMLIFrameElement.idl:

LayoutTests:

  • fast/frames/seamless/seamless-basic-expected.txt:
  • fast/frames/seamless/seamless-inherited-origin-expected.txt:
  • fast/frames/seamless/seamless-nested-expected.txt:
  • fast/frames/seamless/seamless-quirks-expected.txt:
  • fast/frames/seamless/seamless-sandbox-flag-expected.txt:
  • fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt:
  • http/tests/security/seamless/seamless-cross-origin-expected.txt:
  • http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt:
1:43 AM Changeset in webkit [118736] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[Performance] Optimize querySelector() and querySelectorAll() by removing
redundant dummy style sheet creations
https://bugs.webkit.org/show_bug.cgi?id=87627

Reviewed by Antti Koivisto.

This patch improves performance of querySelector("#id") by 4.2% ~ 17.7%
in Safari and Chromium.

Performance tests: https://bugs.webkit.org/attachment.cgi?id=144288

The performance test results in my desktop:

[Safari/Mac]
document.querySelector("#headId") : 13.60 ms => 12.40 ms +9.68%
document.querySelector("#duplicatedId") : 14.80 ms => 14.20 ms +4.23%
document.querySelector("#tailId") : 13.80 ms => 12.20 ms +13.11%
document.querySelectorAll("#headId") : 17.80 ms => 14.60 ms +21.92%
document.querySelectorAll("#duplicatedId") : 513.80 ms => 471.60 ms +8.95%
document.querySelectorAll("#tailId") : 19.20 ms => 16.40 ms +17.07%
document.querySelector("h1") : 14.40 ms => 13.60 ms +5.88%
document.querySelector("h2") : 14.80 ms => 13.80 ms +7.25%
document.querySelector("h3") : 312.00 ms => 306.60 ms +1.76%
document.querySelectorAll("h1") : 322.00 ms => 314.60 ms +2.35%
document.querySelectorAll("h2") : 481.00 ms => 420.60 ms +14.36%
document.querySelectorAll("h3") : 326.80 ms => 315.80 ms +3.48%
document.querySelector(".headClass") : 16.20 ms => 15.40 ms +5.19%
document.querySelector(".duplicatedClass") : 17.00 ms => 15.40 ms +10.39%
document.querySelector(".tailClass") : 369.60 ms => 362.60 ms +1.93%
document.querySelectorAll(".headClass") : 388.20 ms => 377.60 ms +2.81%
document.querySelectorAll(".duplicatedClass") : 605.00 ms => 581.20 ms +4.09%
document.querySelectorAll(".tailClass") : 401.60 ms => 391.40 ms +2.61%

[Chromium/Linux]
ocument.querySelector("#headId") : 16.00 ms => 13.60 ms +17.65%
document.querySelector("#duplicatedId") : 16.80 ms => 15.40 ms +9.09%
document.querySelector("#tailId") : 16.00 ms => 13.60 ms +17.65%
document.querySelectorAll("#headId") : 29.00 ms => 25.00 ms +16.00%
document.querySelectorAll("#duplicatedId") : 561.40 ms => 505.20 ms +11.12%
document.querySelectorAll("#tailId") : 34.00 ms => 26.80 ms +26.87%
document.querySelector("h1") : 18.20 ms => 15.80 ms +15.19%
document.querySelector("h2") : 19.00 ms => 16.60 ms +14.46%
document.querySelector("h3") : 280.40 ms => 274.00 ms +2.34%
document.querySelectorAll("h1") : 300.20 ms => 365.20 ms -17.80%
document.querySelectorAll("h2") : 487.60 ms => 504.20 ms -3.29%
document.querySelectorAll("h3") : 349.40 ms => 324.00 ms +7.84%
document.querySelector(".headClass") : 18.40 ms => 16.00 ms +15.00%
document.querySelector(".duplicatedClass") : 19.40 ms => 16.20 ms +19.75%
document.querySelector(".tailClass") : 349.60 ms => 345.40 ms +1.22%
document.querySelectorAll(".headClass") : 382.80 ms => 378.20 ms +1.22%
document.querySelectorAll(".duplicatedClass") : 550.80 ms => 574.20 ms -4.08%
document.querySelectorAll(".tailClass") : 381.00 ms => 387.00 ms -1.55%

I've found that StyleSheetInternal::create() in CSSParser::parseSelector()
is a bottleneck of querySelector() and querySelectorAll().

void CSSParser::parseSelector(const String& string, CSSSelectorList& selectorList)
{

RefPtr<StyleSheetInternal> dummyStyleSheet = StyleSheetInternal::create();
setStyleSheet(dummyStyleSheet.get());
...;

}

This patch removes a dummy style sheet. Previously the dummy style sheet
was needed to avoid null checks of m_styleSheet in CSSGrammer.y.
This patch fixes CSSGrammer.y so that it works fine with a null m_styleSheet.

Tests: fast/dom/SelectorAPI/*. No change in the test results.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSelector):

1:41 AM Changeset in webkit [118735] by Nikolas Zimmermann
  • 58 edits
    1 move
    11 adds
    11 deletes in trunk

SVGViewSpec DOM bindings aka SVGSVGElement.currentView is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=15495

Reviewed by Rob Buis.

Source/WebCore:

Finish SVGViewSpec implementation and expose it to the Web. Numerous smaller bugs are fixed:

  • SVGViewSpec and all of its contents should be read-only. Enforce that and test it. Add a new enum to SVGPropertyInfo so that each SVGAnimatedProperty knows if its content is supposed to be read-write or read-only.
  • Make the 'transform' attribute of SVGViewSpec exposable by switching to a SVGTransformListProperty - it can now be accessed from JS.
  • Assure that following XXXString methods are in sync with the corresponding SVG DOM interfaces

readonly attribute DOMString viewBoxString;
readonly attribute DOMString preserveAspectRatioString;
readonly attribute DOMString transformString;
readonly attribute DOMString viewTargetString;

  • Cleanup code in svg/properties that was intended to handle SVGViewSpec. Turns out lot of the complexity was unncessary, and can be removed.
  • Move SVGFitToViewBox to the same pattern SVGZoomAndPan uses since two days, that avoids any virtual function calls for attribute parsing.
  • Create/expose ObjectiveC/JS bindings for SVGViewSpec.
  • Enable SVGViewSpec constructor.

Tests: svg/custom/linking-a-03-b-all-expected.svg

svg/dom/SVGViewSpec-defaults.html
svg/dom/SVGViewSpec.html
svg/dom/complex-svgView-specification.html
svg/dom/viewspec-parser.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSSVGLengthCustom.cpp:

(WebCore::JSSVGLength::setValue):
(WebCore::JSSVGLength::convertToSpecifiedUnits):

  • bindings/objc/DOMSVG.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateFunctionCallback):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::valueAccessorSetter):
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):

  • page/DOMWindow.idl:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildTileImageTransform):

  • svg/SVGFitToViewBox.cpp:
  • svg/SVGFitToViewBox.h:

(SVGFitToViewBox):
(WebCore::SVGFitToViewBox::parseAttribute):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::orientTypePropertyInfo):
(WebCore::SVGMarkerElement::parseAttribute):
(WebCore::SVGMarkerElement::synchronizeOrientType):
(WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::dPropertyInfo):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathByteStream):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::synchronizeD):

  • svg/SVGPathSegWithContext.h:

(WebCore::SVGPathSegWithContext::animatedProperty):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::parseAttribute):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::pointsPropertyInfo):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):

  • svg/SVGRect.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::~SVGSVGElement):
(WebCore::SVGSVGElement::currentView):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::currentViewBoxRect):
(WebCore::SVGSVGElement::viewBoxToViewTransform):
(WebCore::SVGSVGElement::setupInitialView):
(WebCore::SVGSVGElement::inheritViewAttributes):

  • svg/SVGSVGElement.h:

(SVGSVGElement):

  • svg/SVGSVGElement.idl:
  • svg/SVGSymbolElement.cpp:

(WebCore::SVGSymbolElement::parseAttribute):

  • svg/SVGTests.cpp:

(WebCore::SVGTests::requiredFeaturesPropertyInfo):
(WebCore::SVGTests::requiredExtensionsPropertyInfo):
(WebCore::SVGTests::systemLanguagePropertyInfo):
(WebCore::SVGTests::synchronizeRequiredFeatures):
(WebCore::SVGTests::synchronizeRequiredExtensions):
(WebCore::SVGTests::synchronizeSystemLanguage):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::textLengthPropertyInfo):
(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):

  • svg/SVGViewElement.cpp:

(WebCore::SVGViewElement::parseAttribute):

  • svg/SVGViewElement.h:
  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::viewBoxPropertyInfo):
(WebCore::SVGViewSpec::preserveAspectRatioPropertyInfo):
(WebCore::SVGViewSpec::transformPropertyInfo):
(WebCore::SVGViewSpec::SVGViewSpec):
(WebCore::SVGViewSpec::viewBoxIdentifier):
(WebCore::SVGViewSpec::preserveAspectRatioIdentifier):
(WebCore::SVGViewSpec::transformIdentifier):
(WebCore::SVGViewSpec::setZoomAndPan):
(WebCore::SVGViewSpec::setTransformString):
(WebCore::SVGViewSpec::transformString):
(WebCore::SVGViewSpec::viewBoxString):
(WebCore::SVGViewSpec::preserveAspectRatioString):
(WebCore::SVGViewSpec::viewTarget):
(WebCore::SVGViewSpec::transform):
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper):
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper):
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper):
(WebCore::SVGViewSpec::reset):
(WebCore::SVGViewSpec::parseViewSpec):

  • svg/SVGViewSpec.h:

(WebCore::SVGViewSpec::~SVGViewSpec):
(SVGViewSpec):
(WebCore::SVGViewSpec::create):
(WebCore::SVGViewSpec::setViewTargetString):
(WebCore::SVGViewSpec::setZoomAndPan):
(WebCore::SVGViewSpec::contextElement):
(WebCore::SVGViewSpec::resetContextElement):
(WebCore::SVGViewSpec::transformBaseValue):
(WebCore::SVGViewSpec::viewBoxAnimated):
(WebCore::SVGViewSpec::viewBox):
(WebCore::SVGViewSpec::viewBoxBaseValue):
(WebCore::SVGViewSpec::setViewBoxBaseValue):
(WebCore::SVGViewSpec::preserveAspectRatioAnimated):
(WebCore::SVGViewSpec::preserveAspectRatio):
(WebCore::SVGViewSpec::preserveAspectRatioBaseValue):
(WebCore::SVGViewSpec::setPreserveAspectRatioBaseValue):

  • svg/SVGViewSpec.idl:
  • svg/properties/SVGAnimatedProperty.h:

(WebCore::SVGAnimatedProperty::isReadOnly):
(WebCore::SVGAnimatedProperty::setIsReadOnly):
(SVGAnimatedProperty):
(WebCore::SVGAnimatedProperty::lookupOrCreateWrapper):
(WebCore::SVGAnimatedProperty::lookupWrapper):
(WebCore::SVGAnimatedProperty::SVGAnimatedProperty):

  • svg/properties/SVGAnimatedPropertyMacros.h:

(WebCore::SVGSynchronizableAnimatedProperty::synchronize):
(SVGSynchronizableAnimatedProperty):

  • svg/properties/SVGAnimatedPropertySynchronizer.h: Removed.
  • svg/properties/SVGAttributeToPropertyMap.h:
  • svg/properties/SVGListProperty.h:
  • svg/properties/SVGListPropertyTearOff.h:

(SVGListPropertyTearOff):
(WebCore::SVGListPropertyTearOff::isReadOnly):

  • svg/properties/SVGPathSegListPropertyTearOff.h:

(SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::isReadOnly):

  • svg/properties/SVGProperty.h:

(SVGProperty):

  • svg/properties/SVGPropertyInfo.h:

(WebCore::SVGPropertyInfo::SVGPropertyInfo):
(SVGPropertyInfo):

  • svg/properties/SVGPropertyTearOff.h:

(WebCore::SVGPropertyTearOff::isReadOnly):

  • svg/properties/SVGStaticListPropertyTearOff.h:

(SVGStaticListPropertyTearOff):
(WebCore::SVGStaticListPropertyTearOff::isReadOnly):

Source/WebKit/mac:

  • MigrateHeaders.make: Copy DOMSVGViewSpec*.h headers.

LayoutTests:

Re-enable a long disabled test for SVGViewSpec, and make it actually work.
Extend SVGViewSpec test coverage, and rebaseline results that changed due the SVGViewSpec constructor addition.

Make linking-a-03-b-all.svg a reftest, to avoid rebaselines on all platforms.

  • platform/chromium-linux/svg/custom/linking-a-03-b-all-expected.png: Removed.
  • platform/chromium-mac/svg/custom/linking-a-03-b-all-expected.png: Removed.
  • platform/chromium-win/fast/js/global-constructors-expected.txt:
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.png: Removed.
  • platform/chromium-win/svg/custom/linking-a-03-b-all-expected.txt: Removed.
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/gtk/svg/custom/linking-a-03-b-all-expected.png: Removed.
  • platform/gtk/svg/custom/linking-a-03-b-all-expected.txt: Removed.
  • platform/mac/fast/js/global-constructors-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.png: Removed.
  • platform/mac/svg/custom/linking-a-03-b-all-expected.txt: Removed.
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/qt/svg/custom/linking-a-03-b-all-expected.png: Removed.
  • platform/qt/svg/custom/linking-a-03-b-all-expected.txt: Removed.
  • platform/win/fast/js/global-constructors-expected.txt:
  • svg/custom/global-constructors-expected.txt:
  • svg/custom/linking-a-03-b-all-expected.svg: Added.
  • svg/dom/SVGViewSpec-defaults-expected.txt: Added.
  • svg/dom/SVGViewSpec-defaults.html: Added.
  • svg/dom/SVGViewSpec-expected.txt: Added.
  • svg/dom/SVGViewSpec.html: Added.
  • svg/dom/complex-svgView-specification-expected.html: Added.
  • svg/dom/complex-svgView-specification.html: Added.
  • svg/dom/resources/viewspec-target.svg: Added.
  • svg/dom/script-tests/SVGViewSpec-defaults.js: Added.
  • svg/dom/script-tests/SVGViewSpec.js: Added.

(completeTest.script.onload):
(completeTest):
(testFragment):
(matrixToString):
(continueTesting):

  • svg/dom/viewspec-parser-expected.txt: Added.
  • svg/dom/viewspec-parser.html: Renamed from LayoutTests/svg/dom/viewspec-parser.html-disabled.
1:32 AM Changeset in webkit [118734] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Adjust expectations for fast/layers/clip-rects-assertion-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=87671

Unreviewed gardening.
Test has been fixed by r118724, remove expectation.

  • platform/chromium/test_expectations.txt:
1:23 AM Changeset in webkit [118733] by tkent@chromium.org
  • 9 edits
    12 adds in trunk

REGRESSION (r90971): the cursor is painted “behind” the placeholder text
https://bugs.webkit.org/show_bug.cgi?id=87155

Reviewed by Hajime Morita.

Source/WebCore:

This regression happened only on platforms on which
RenderTheme::shouldShowPlaceholderWhenFocused() returns true.

Because the order of renderers for the editable node and the placeholder
node was:

  • A renderer for the editable node
  • A renderer for the placeholder node,

The text caret was painted, then the palceholder was painted.

We should not use z-index in the built-in shadow nodes. So the patch
fixes this bug by re-ordering these renderers.

Tests: fast/forms/input-placeholder-paint-order-2.html

fast/forms/input-placeholder-paint-order.html
fast/forms/textarea/textarea-placeholder-paint-order-2.html
fast/forms/textarea/textarea-placeholder-paint-order.html

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::fixPlaceholderRenderer):
Added. Reorder the order of renderers so that the placeholder renderer
precedes the inner text renderer.

  • html/HTMLTextFormControlElement.h: Add fixPlaceholderRenderer() declaration.
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::attach): Calls fixPlaceholderRenderer().
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
ditto. Also, use innerTextElement() to improvde code readability.

  • html/HTMLTextAreaElement.h:

(HTMLTextAreaElement): Overrides attach().

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):
Calls fixPlaceholderRenderer().
(WebCore::TextFieldInputType::attach): ditto.

  • html/TextFieldInputType.h:

(TextFieldInputType): Overrides attach().

LayoutTests:

  • fast/forms/input-placeholder-paint-order-2-expected.html: Added.
  • fast/forms/input-placeholder-paint-order-2.html: Added.
  • fast/forms/input-placeholder-paint-order.html: Added.
  • fast/forms/textarea/textarea-placeholder-paint-order-2-expected.html: Added.
  • fast/forms/textarea/textarea-placeholder-paint-order-2.html: Added.
  • fast/forms/textarea/textarea-placeholder-paint-order.html: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/input-placeholder-paint-order-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:08 AM Changeset in webkit [118732] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Add return value information to WebKitWebView::load-failed signal documentation
https://bugs.webkit.org/show_bug.cgi?id=87704

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):

1:06 AM Changeset in webkit [118731] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Add WebKitWebInspector.h to the list of WebKit2 GTK public headers
https://bugs.webkit.org/show_bug.cgi?id=87703

Reviewed by Martin Robinson.

  • GNUmakefile.list.am: Add WebKitWebInspector.h to webkit2gtk_h_api.
12:57 AM Changeset in webkit [118730] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r118631. http/tests/appcache/load-from-appcache-defer-resume-crash.html
fails because of missing LayoutTestController::setUseDeferredFrameLoading implementation.

Patch by János Badics <János Badics> on 2012-05-29

  • platform/qt/Skipped:
12:51 AM Changeset in webkit [118729] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Compilation warning in DumpRenderTreeView.cpp
https://bugs.webkit.org/show_bug.cgi?id=87636

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-29
Reviewed by Filip Pizlo.

Source/WebKit/efl:

Fix return type of exceeded_application_cache_quota callback, it
should be int64_t, not uint64_t.

  • ewk/ewk_view.h:

Tools:

Fix compilation error in DumpRenderTreeView.cpp due to wrong format
specifier in printf. Also fix the return type for
onExceededApplicationCacheQuota callback.

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onExceededApplicationCacheQuota):

12:34 AM Changeset in webkit [118728] by hbono@chromium.org
  • 2 edits in trunk/Tools

Adding Hironori Bono to committers.py.
https://bugs.webkit.org/show_bug.cgi?id=87697

  • Scripts/webkitpy/common/config/committers.py:

May 28, 2012:

11:44 PM Changeset in webkit [118727] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] New fast/dom/window-scroll-scaling.html made 3-400 tests flakey
https://bugs.webkit.org/show_bug.cgi?id=87700

Unreviewed gardening to paint the bot less and less red.

  • platform/qt/Skipped: Skip fast/dom/window-scroll-scaling.html until proper fix.
11:42 PM Changeset in webkit [118726] by haraken@chromium.org
  • 18 edits in trunk/Source/WebCore

[V8] Implement V8Binding::v8Null(isolate) and use it in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=87692

Reviewed by Adam Barth.

Since v8::Null(isolate) crashes if we pass a NULL isolate, we are planning
to pass Isolate to v8::Null() in the following steps:

[1] Implement V8Bindings::v8Null(isolate). v8Null(isolate) does the NULL check.
If isolate is NULL, v8Null(isolate) calls v8::Null(). Otherwise,
v8Null(isolate) calls v8::Null(isolate).

[2] In V8 bindings, we replace v8::Null() with v8::Null(isolate) for a non-optional
'isolate' parameter. (e.g. void foo(..., Isolate* isolate) { v8::Null(); } )

[3] In V8 bindings, we replace v8::Null() with v8Null(isolate) for an optional
'isolate' parameter. (e.g. void foo(..., Isolate* isolate = 0) { v8::Null(); } )

This bug fixes [1] by implementing V8Binding::v8Null(isolate). Also this patch uses
V8Binding::v8Null(isolate) in bindings/v8/*.{h,cpp}.

No tests. No behavior change.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8Float64Array.h:
  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::toV8):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetter):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::toV8):

  • bindings/v8/V8Binding.h:

(WebCore::v8Null):
(WebCore):
(WebCore::v8DateOrNull):

  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:

(WebCore):

10:37 PM Changeset in webkit [118725] by tkent@chromium.org
  • 8 edits in trunk

Fix a crash in HTMLFormControlElement::disabled().
https://bugs.webkit.org/show_bug.cgi?id=86534

Reviewed by Ryosuke Niwa.

Source/WebCore:

Stop to hold pointers of fildset and legend elements. We can avoid it by
holding ancestor's disabled state.

The ancesotr's disabled state should be invalidated when

  • fieldset's disabled value is changed.
  • fieldset's children is updated because a legend position might be changed.
  • A form control is attached to or detached from a tree.

No new tests. It's almost impossible to make a reliable test.

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
Added. Invalidate disabled state of form controls under the specified node.
(WebCore::HTMLFieldSetElement::disabledAttributeChanged):
Uses invalidateDisabledStateUnder().
(WebCore::HTMLFieldSetElement::childrenChanged):
Added new override function. We need invalidate disabled state of form
controls under legend elements.

  • html/HTMLFieldSetElement.h:

(HTMLFieldSetElement): Add invalidateDisabledStateUnder() and childrenChanged().

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
Remove initialization of the removed data members.
Initialize m_ancestorDisabledState.
(WebCore::HTMLFormControlElement::updateAncestorDisabledState):
Update m_ancestorDisabledState. It should be
AncestorDisabledStateDisabled if the control is under a disabled
fieldset and not under the first legend child of the disabled filedset.
(WebCore::HTMLFormControlElement::ancestorDisabledStateWasChanged):
Invalidate m_ancestorDisabledState.
(WebCore::HTMLFormControlElement::insertedInto): ditto.
(WebCore::HTMLFormControlElement::removedFrom): ditto.
(WebCore::HTMLFormControlElement::disabled):
Calls updateAncestorDisabledState() if needed.
(WebCore::HTMLFormControlElement::recalcWillValidate):
Remove unnecessary check for m_legendAncestor.

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • Rename updateFieldSetAndLegendAncestor() to updateAncestorDisabledState(), and make it private.
  • Remove m_fieldSetAncestor, m_legendAncestor, and m_fieldSetAncestorValid.
  • Add m_ancestorDisabledState.

LayoutTests:

Add a testcase to confirm <lagend> doesn't affect validation.

  • fast/forms/datalist/datalist-child-validation-expected.txt:
  • fast/forms/datalist/datalist-child-validation.html:
10:16 PM Changeset in webkit [118724] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

Removes pixel result requirements from fast/layers/clip-rects-assertion-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=87663

Unreviewed gardening.

This test was added by r118612, but no pixel result were provided.
It seems that it's enough to remove the param for dumpAsText() and just use the text text output.

  • fast/layers/clip-rects-assertion.html:
10:15 PM Changeset in webkit [118723] by toyoshim@chromium.org
  • 11 edits in trunk

[WebSocket] Receiving reserved close codes, 1005, 1006, and 1015 must appear as code=1006 and wasClean=false
https://bugs.webkit.org/show_bug.cgi?id=87084

Reviewed by Kent Tamura.

Source/WebCore:

Status codes 1005, 1006, and 1015 are forbidden to be sent in actual close frames.
If a client received these frames, the client should handle them as broken.
Close frames containing invalid body size are the same as these forbidden cases.
Update close-code-and-reason tests to verify this patch.

  • Modules/websockets/WebSocket.cpp: Handle AbnormalClosure as wasClean == false

(WebCore::WebSocket::didClose):

  • Modules/websockets/WebSocketChannel.cpp: Handle close frames' status code carefully

(WebCore::WebSocketChannel::processFrame):

  • Modules/websockets/WebSocketChannel.h: Update on newly defined close event codes

Source/WebKit/chromium:

Update close event codes corresponding to WebSocketChannel::CloseEventCode.

  • public/WebSocket.h: Update on newly defined close event codes

LayoutTests:

Add test cases where server initiates a closing handshake with forbidden status codes.

  • http/tests/websocket/tests/hybi/close-code-and-reason-expected.txt:
  • http/tests/websocket/tests/hybi/close-code-and-reason.html:
  • http/tests/websocket/tests/hybi/workers/close-code-and-reason-expected.txt:
  • http/tests/websocket/tests/hybi/workers/resources/close-code-and-reason.js:

(WebSocketTest.prototype.onclose):

9:11 PM Changeset in webkit [118722] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Avoid passing NULL to an 'isolate' parameter
https://bugs.webkit.org/show_bug.cgi?id=87689

Reviewed by Adam Barth.

v8::Null(isolate) crashes if we pass a NULL isolate.
Thus we are planning to replace v8::Null()s in a following way:

  • Implement V8Bindings::v8Null(isolate). v8Null(isolate) does the NULL check.

If isolate is NULL, v8Null(isolate) calls v8::Null(). Otherwise,
v8Null(isolate) calls v8::Null(isolate).

  • In V8 bindings, we replace v8::Null() with v8::Null(isolate) for a

non-optional 'isolate' parameter.
(e.g. void foo(..., Isolate* isolate) { v8::Null(); } )

  • In V8 bindings, we replace v8::Null() with v8Null(isolate) for an

optional 'isolate' parameter.
(e.g. void foo(..., Isolate* isolate = 0) { v8::Null(); } )

However, currently we cannot do the replacement mechanically, since some code
pass NULL to a non-optional 'isolate' parameter. In other words, currently
"non-optional" does not guarantee that 'isolate' is not NULL.

This patch removes all the code that passes NULL to a non-optional 'isolate'
parameter. This will enable us to achieve the replacement mechanically.

No tests. No behavior change.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackImplementation):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::installPerContextProperties):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8SQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp:

(WebCore::V8MutationCallback::handleEvent):

9:08 PM Changeset in webkit [118721] by tkent@chromium.org
  • 5 edits
    2 adds in trunk

Form controls in <fieldset disabled> should not be validated.
https://bugs.webkit.org/show_bug.cgi?id=87381

Reviewed by Hajime Morita.

Source/WebCore:

We need to use disabeld() instead of m_disabled to calculate
willValidate property. Also, we need to update willValidate if
necessary.

Test: fast/forms/fieldset/validation-in-fieldset.html

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::disabledAttributeChanged):

  • Do not traverse this.
  • Calls ancestorDisabledStateWasChanged() instead of setNeedsStyleRecalc() because we'd like to do additional tasks.
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::ancestorDisabledStateWasChanged):
Added. Just calls disabledAttributeChanged().
(WebCore::HTMLFormControlElement::parseAttribute):
Do not call setNeedsWillValidateCheck() whenever an attribute is updated.
It should be called only if disabled or readonly attribute is updated.
(WebCore::HTMLFormControlElement::disabledAttributeChanged):
Add setNeedsWillValidateCheck(). It was moved from parseAttribute().
(WebCore::HTMLFormControlElement::insertedInto):
Invalidate ancestor information.
(WebCore::HTMLFormControlElement::recalcWillValidate):
Use disabled() instead of m_disabled. disabled() takes care of
ancestor's disabled state.

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

LayoutTests:

  • fast/forms/fieldset/validation-in-fieldset-expected.txt: Added.
  • fast/forms/fieldset/validation-in-fieldset.html: Added.
9:05 PM AddingFeatures edited by rakuco@webkit.org
Add another CMake-related file that should be changed. (diff)
8:57 PM Changeset in webkit [118720] by commit-queue@webkit.org
  • 9 edits
    4 adds in trunk

[Forms] HTMLFieldSetElement.idl doesn't have elements attribute.
https://bugs.webkit.org/show_bug.cgi?id=80110

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-05-28
Reviewed by Kent Tamura.

Source/WebCore:

Implemented elements attribute for HTMLFieldSetElement. This is spec'ed at
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-fieldset-elements

Tests: fast/forms/fieldset/fieldset-elements.html

fast/forms/fieldset/fieldset-form-collection-radionode-list.html

  • dom/Node.cpp:

(WebCore::Node::radioNodeList):
Extended ASSERT to assert if not HTMLFieldSetElement or HTMLFormElement.

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::elements):
Elements attribute implementation.
(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):
Update the formcontrol elements collections if dom tree got modified.
(WebCore::HTMLFieldSetElement::associatedElements):
FormControl elements collection accessor.
(WebCore::HTMLFieldSetElement::length):
Number of elements in the fieldset group.

  • html/HTMLFieldSetElement.h:

Added elements collection member and form control collection members.

  • html/HTMLFieldSetElement.idl:

Added elements attribute.

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::formControlElements):
Added support for HTMLFieldSetElement, based on base element type gets its associated elements.
(WebCore::HTMLFormCollection::numberOfFormControlElements): Ditto
(WebCore::HTMLFormCollection::getNamedFormItem): Process image elements only for form element.
(WebCore::HTMLFormCollection::updateNameCache): Ditto

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList):
DynamicSubTree root element is decided based on the type whether base element is form or fieldset element.
Renamed m_formElement to m_baseElement.
(WebCore::RadioNodeList::~RadioNodeList):
Renamed m_formElement to m_baseElement.
(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
Form element specific changes moved under form element check.

  • html/RadioNodeList.h:

(WebCore::RadioNodeList::create):
(RadioNodeList):
Renamed m_formElement to m_baseElement.

LayoutTests:

  • fast/forms/fieldset/fieldset-elements-expected.txt: Added.
  • fast/forms/fieldset/fieldset-elements.html: Added.
  • fast/forms/fieldset/fieldset-form-collection-radionode-list-expected.txt: Added.
  • fast/forms/fieldset/fieldset-form-collection-radionode-list.html: Added.
8:49 PM Changeset in webkit [118719] by commit-queue@webkit.org
  • 11 edits in trunk

[BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
https://bugs.webkit.org/show_bug.cgi?id=80135

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-28
Reviewed by Rob Buis.

Source/WebCore:

RIM PR: 145660
Fixed a regression introduced by r111810, we should cancel the new
request when user press cancel button in http authentication challenge
dialog, and we should also allow sending empty username and password
with the request.
Also removed redundant codes which checked the existence of the
FrameLoaderClient pointer, as we've already moved authenticationChallenge()
out of class FrameLoaderClient, it is not needed.

Manual test added. Testing http authentication dialog relies on user interaction.

Resubmit the patch reverted by r115104 after the digest infinite loop
issue for BlackBerry porting get identified and fixed.

Internally reviewed by Joe Mason <jmason@rim.com>

  • platform/blackberry/PageClientBlackBerry.h:
  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

Source/WebKit/blackberry:

RIM PR: 145660
Fixed a regression introduced by r111810, which used the wrong
credential object.

Added the interface function didReceivedAuthenticaitonChallenge()
in interface class DumpRenderTreeClient;
Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
WebPagePrivate::authenticationChallenge() when DRT is enabled.

Test: reuse existing test cases:
http/tests/loading/basic-credentials-sent-automatically.html
http/tests/loading/basic-auth-resend-wrong-credentials.html

Resubmit the patch reverted by r115104 after the digest infinite loop
issue for BlackBerry porting get identified and fixed.

Internally reviewed by Joe Mason <jmason@rim.com>

  • Api/DumpRenderTreeClient.h:

(WebCore):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

Tools:

Implemented interface function didReceiveAuthenticationChallenge in class
DumpRenderTree.

Resubmit the patch reverted by r115104 after the digest infinite loop
issue for BlackBerry porting get identified and fixed.

Internally reviewed by Joe Mason <jmason@rim.com>

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(drtCredentialDescription):
(BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
(WebKit):

  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(WebCore):
(DumpRenderTree):

8:24 PM Changeset in webkit [118718] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r118646.
http://trac.webkit.org/changeset/118646
https://bugs.webkit.org/show_bug.cgi?id=87691

broke V8 raytrace benchmark (Requested by pizlo_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-28

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::sweepWeakSet):
(JSC):

  • heap/MarkedSpace.cpp:

(JSC::SweepWeakSet::operator()):
(JSC):
(JSC::MarkedSpace::sweepWeakSets):

  • heap/MarkedSpace.h:

(MarkedSpace):

8:04 PM Changeset in webkit [118717] by Dave Barton
  • 2 edits in trunk/LayoutTests

mathml/presentation/mo-stretch.html and mroot-pref-width.html tests fail on Mac
https://bugs.webkit.org/show_bug.cgi?id=86786

Unreviewed gardening - add back these two tests to skip for now.

  • platform/mac/Skipped:
7:58 PM Changeset in webkit [118716] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] http authentication challenge issue when loading favicon
https://bugs.webkit.org/show_bug.cgi?id=87665

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-28
Reviewed by Rob Buis.

Provide the TargetType when generating a favicon loading
request. Loading favicons is triggered after the main resource
has been loaded and parsed, so if we cancel the authentication
challenge when loading main resource, we should also cancel
loading the favicon when it starts to load. If not we will
receive another challenge after we canceled the main resource
loading, which may confuse the user.

Internally reviewed by Joe Mason <jmason@rim.com>

No new tests because of no behavior changes.

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendRequestWithCredentials):

7:43 PM Changeset in webkit [118715] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG should not generate code for code that the CFA proves to be unreachable
https://bugs.webkit.org/show_bug.cgi?id=87682

Reviewed by Sam Weinig.

This also fixes a small performance bug where CFA was not marking blocks
as having constants (and hence not triggering constant folding) if the only
constants were on GetLocals.

And fixing that bug revealed another bug: constant folding was assuming that
a GetLocal must be the first access to a local in a basic block. This isn't
true. The first access may be a Flush. This patch fixes that issue using the
safest approach possible, since we don't need to be clever for something that
only happens in one of our benchmarks.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

6:50 PM Changeset in webkit [118714] by morrita@google.com
  • 6 edits in trunk/Source

Rename FrameLoaderClient::shadowDOMAllowed() to allowShadowDOM()
https://bugs.webkit.org/show_bug.cgi?id=87101

Reviewed by Kentaro Hara.

Source/WebCore:

No new tests. No behavior change.

  • bindings/generic/ContextEnabledFeatures.cpp:

(WebCore::ContextEnabledFeatures::shadowDOMEnabled):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::allowShadowDOM):

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::allowShadowDOM):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

6:24 PM Changeset in webkit [118713] by Dave Barton
  • 10 edits in trunk

mathml/presentation/mo-stretch.html and mroot-pref-width.html tests fail on Mac
https://bugs.webkit.org/show_bug.cgi?id=86786

Reviewed by Darin Adler.

Source/WebCore:

The fix to https://bugs.webkit.org/show_bug.cgi?id=84167 changed inline-table baselines,
including for <mtable>. We therefore have to correct <mtable>'s vertical-align CSS
property.

Tested by existing tests mo-stretch.html, row-alignment.xhtml, and tables.xhtml.

  • css/mathml.css:

(mtable):

LayoutTests:

  • platform/mac/Skipped:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:
4:56 PM Changeset in webkit [118712] by macpherson@chromium.org
  • 4 edits in trunk/Source/WebCore

Make CSSParser::filteredProperties() O(n) instead of O(n2) and improve readability.
https://bugs.webkit.org/show_bug.cgi?id=87078

Reviewed by Darin Adler.

This patch implements a number of improvements to filteredProperties:
1) Make the code more linearly readable by separating out handling of important and non-important properties.
2) Eliminate one BitArray instance (reduces hot memory so more cache friendly).
3) Remove O(n2) behavior caused by scanning for and removing previously encountered definitions of each property.
The key algorithmic change is to add properties in decreasing precedence:
a) Iterating once per (important, !important) so that important properties are visited first.
b) Reverse iteration of m_parsedProperties visits the properties in decreasing precedence.

Covered by loads of existing tests - getting CSS property precedence wrong results in too many errors to list.
In particular fast/css contains test cases for important corner cases like duplicated important properties.

  • css/CSSParser.cpp:

(WebCore::CSSParser::createStylePropertySet):

  • css/CSSProperty.h:

Add vector traits so that CSSProperty can just be memset by vector without calling constructor.

4:52 PM Changeset in webkit [118711] by morrita@google.com
  • 6 edits
    2 adds in trunk

Can't edit <input> elements with :first-letter
https://bugs.webkit.org/show_bug.cgi?id=87615

Reviewed by Kent Tamura.

A check using canHaveGeneratedChildren() should cover not only
button and menulist, but also RenderTextControl.
This change pulles canHaveGeneratedChildren() up
from RenderDeprecatedFlexibleBox to RenderObject,
and lets RenderTextControl override it.

Test: fast/forms/input-first-letter-edit.html

  • rendering/RenderBlock.cpp:

(WebCore):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderBlock.h: Removed a static function canHaveGeneratedChildren()

(RenderBlock):

  • rendering/RenderDeprecatedFlexibleBox.h:
  • rendering/RenderObject.cpp:

(WebCore):
(WebCore::RenderObject::canHaveGeneratedChildren): Added.

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderTextControl.h:
3:49 PM Changeset in webkit [118710] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

[BlackBerry] Add support for layers with scale invariant size
https://bugs.webkit.org/show_bug.cgi?id=87601

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.

To support layers that have a "floating" appearance, i.e. don't change size
when the web page is drawn at a different scale, we add a new layer property
named "sizeIsScaleInvariant".

The anchor position will still be given in document coordinates for these
"floating" layers, so this is well suited for interface elements like selection
handles whose size is always the same but move with the web page contents.

PR #156812

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawMissingTextures):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):

  • platform/graphics/blackberry/LayerCompositingThreadClient.h:

(LayerCompositingThreadClient):
(WebCore::LayerCompositingThreadClient::drawMissingTextures):

  • platform/graphics/blackberry/LayerData.h:

(WebCore::LayerData::LayerData):
(WebCore::LayerData::sizeIsScaleInvariant):
(LayerData):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::LayerRenderer::compositeLayersRecursive):

  • platform/graphics/blackberry/LayerRenderer.h:

(LayerRenderer):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::drawMissingTextures):
(WebCore::LayerTiler::drawTexturesInternal):

  • platform/graphics/blackberry/LayerTiler.h:

(LayerTiler):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(WebCore::LayerWebKitThread::setSizeIsScaleInvariant):
(LayerWebKitThread):

3:22 PM Changeset in webkit [118709] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[BlackBerry] Make it possible to manipulate layers on the compositing thread
https://bugs.webkit.org/show_bug.cgi?id=87602

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.

Normally, layers are manipulated on the WebKit thread, and the changes are
synced to the compositing thread during the next accelerated compositing commit
operation.

However, for overlay layers the ability to manipulate layers on the compositing
thread is necessary for adequate user interface responsiveness.

Two mechanisms are added:

  1. For a layer with a WebKit-thread counterpart, you can temporarily override

attributes or add animations whose output override attributes.

  1. For a layer with no WebKit-thread counterpart, you can now directly set the

compositing thread values for attributes. If you attempt to do this for layers
that do have a WebKit-thread counterpart, the compositing thread values will
be overwritten at the time of the next commit, which makes the override
mechanism more useful there.

PR #156812

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::addSublayer):
(WebCore):
(WebCore::LayerCompositingThread::updateAnimations):
(WebCore::LayerCompositingThread::removeAnimation):
(WebCore::LayerCompositingThread::override):
(WebCore::LayerCompositingThread::clearOverride):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(LayerOverride):
(WebCore::LayerOverride::create):
(WebCore::LayerOverride::setPosition):
(WebCore::LayerOverride::setAnchorPoint):
(WebCore::LayerOverride::setBounds):
(WebCore::LayerOverride::setTransform):
(WebCore::LayerOverride::setOpacity):
(WebCore::LayerOverride::addAnimation):
(WebCore::LayerOverride::LayerOverride):
(WebCore):
(LayerCompositingThread):
(WebCore::LayerCompositingThread::setPosition):
(WebCore::LayerCompositingThread::setAnchorPoint):
(WebCore::LayerCompositingThread::setBounds):
(WebCore::LayerCompositingThread::setSizeIsScaleInvariant):
(WebCore::LayerCompositingThread::setTransform):
(WebCore::LayerCompositingThread::setOpacity):
(WebCore::LayerCompositingThread::setNeedsTexture):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::commitOnCompositingThread):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(LayerWebKitThread):
(WebCore::LayerWebKitThread::clearOverride):

3:22 PM Changeset in webkit [118708] by jesus@webkit.org
  • 4 edits in trunk/LayoutTests

Flaky tests in fast/profiler/
https://bugs.webkit.org/show_bug.cgi?id=84102

Unreviewed gardening.

Tests fast/profiler/stop-profiling-after-setTimeout.html and
fast/profiler/dead-time.html were still failing after
https://bugs.webkit.org/show_bug.cgi?id=42328 . Mac and chromium
already skip these tests.

  • platform/efl/Skipped:
  • platform/gtk/test_expectations.txt:
  • platform/qt/Skipped:
2:55 PM Changeset in webkit [118707] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[chromium] Only increase size of Combo Box Options when displayed on touch screen
https://bugs.webkit.org/show_bug.cgi?id=85921

Patch by Rob Flack <flackr@chromium.org> on 2012-05-28
Reviewed by Adam Barth.

Adds a flag to set whether the current device is a touch screen, independent of whether touch events are supported and use this for the combo box sizing.

Source/WebCore:

No new tests as this is a flag change and covered by existing tests: WebKit/chromium/tests/PopupMenuTest.cpp

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setDeviceSupportsTouch):
(WebCore::Settings::deviceSupportsTouch):
(Settings):

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupListBox.h:

(PopupContainerSettings):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupMenuChromium::show):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::defaultDeviceScaleFactor):
(WebKit):
(WebKit::WebSettingsImpl::setDeviceSupportsTouch):
(WebKit::WebSettingsImpl::deviceSupportsTouch):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyAutofillSuggestions):

  • tests/PopupMenuTest.cpp:

(WebKit::SelectPopupMenuTest::SetUp):
(WebKit::SelectPopupMenuTest::TearDown):
(SelectPopupMenuTest):
(WebKit::TEST_F):

2:20 PM Changeset in webkit [118706] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source/WebCore

[BlackBerry] Make custom compositing thread layers more flexible
https://bugs.webkit.org/show_bug.cgi?id=87600

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.

Introduce a LayerCompositingThreadClient that's used to fine tune the
behaviour of custom layers. Let the LayerTiler be a
LayerCompositingThreadClient and thus decouple it from
LayerCompositingThread. Adjust method signatures to allow a one-to-many
relationship between Client and Layer.

Remove the old LayerCompositingThread::drawCustom() in favour of this new
Client interface.

PR #156812

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::create):
(WebCore::LayerCompositingThread::LayerCompositingThread):
(WebCore::LayerCompositingThread::~LayerCompositingThread):
(WebCore::LayerCompositingThread::deleteTextures):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::hasMissingTextures):
(WebCore::LayerCompositingThread::drawMissingTextures):
(WebCore::LayerCompositingThread::updateTextureContentsIfNeeded):
(WebCore::LayerCompositingThread::bindContentsTexture):
(WebCore::LayerCompositingThread::setVisible):
(WebCore::LayerCompositingThread::scheduleCommit):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore):
(LayerCompositingThread):

  • platform/graphics/blackberry/LayerCompositingThreadClient.h: Added.

(WebCore):
(LayerCompositingThreadClient):
(WebCore::LayerCompositingThreadClient::~LayerCompositingThreadClient):
(WebCore::LayerCompositingThreadClient::bindContentsTexture):
(WebCore::LayerCompositingThreadClient::hasMissingTextures):
(WebCore::LayerCompositingThreadClient::drawMissingTextures):
(WebCore::LayerCompositingThreadClient::scheduleCommit):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::drawDebugBorder):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::layerCompositingThreadDestroyed):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::deleteTextures):
(WebCore::LayerTiler::scheduleCommit):
(WebCore):
(WebCore::LayerTiler::bindContentsTexture):

  • platform/graphics/blackberry/LayerTiler.h:

(LayerTiler):
(WebCore::LayerTiler::hasMissingTextures):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::LayerWebKitThread):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(LayerWebKitThread):

1:00 PM Changeset in webkit [118705] by jesus@webkit.org
  • 95 edits in trunk

WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42328

Reviewed by Eric Seidel.

.:

  • Source/autotools/symbols.filter: Added needed symbols for GTK build.

Source/WebCore:

Add setJavaScriptProfilingEnabled() to window.internals.settings. No new tests, but this
change will allow more tests to run in WebKitTestRunner and DRT for ports that weren't
implementing this function before.
This patch also refactors InspectorController::enableProfiler() and
InspectorController::disableProfiler() to InspectorController::setProfilerEnabled(bool).

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::profilerEnabled):
(WebCore::InspectorController::setProfilerEnabled):

  • inspector/InspectorController.h:

(InspectorController):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setJavaScriptProfilingEnabled):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

Removed private APIs that were only being used by DRT.

  • public/WebDevToolsAgent.h:

(WebDevToolsAgent):

  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

Source/WebKit/efl:

Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
move to windows.internals.settings.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

  • webkit/webkitwebinspector.cpp:

(webkit_web_inspector_set_property):

Source/WebKit/mac:

  • WebInspector/WebInspector.mm:

(-setJavaScriptProfilingEnabled:):

Source/WebKit/qt:

Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
move to windows.internals.settings.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

(WebInspector::setJavaScriptProfilingEnabled):

Source/WebKit2:

Removed unneeded setJavaScriptProfilingEnabled function from WTR after its
move to windows.internals.settings.

  • WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleInspector.h:
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::setJavaScriptProfilingEnabled):

  • win/WebKit2.def:

Tools:

Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
move to windows.internals.settings.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:

(DRTDevToolsAgent):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

Updated tests to use windows.internals instead of layoutTestController.

  • fast/profiler/anonymous-event-handler.html:
  • fast/profiler/anonymous-function-called-from-different-contexts.html:
  • fast/profiler/anonymous-function-calls-built-in-functions.html:
  • fast/profiler/anonymous-function-calls-eval.html:
  • fast/profiler/anonymous-functions-with-display-names.html:
  • fast/profiler/apply.html:
  • fast/profiler/built-in-function-calls-anonymous.html:
  • fast/profiler/built-in-function-calls-user-defined-function.html:
  • fast/profiler/call-register-leak.html:
  • fast/profiler/call.html:
  • fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
  • fast/profiler/compare-multiple-profiles.html:
  • fast/profiler/constructor.html:
  • fast/profiler/dead-time.html:
  • fast/profiler/document-dot-write.html:
  • fast/profiler/event-handler.html:
  • fast/profiler/execution-context-and-eval-on-same-line.html:
  • fast/profiler/inline-event-handler.html:
  • fast/profiler/many-calls-in-the-same-scope.html:
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
  • fast/profiler/multiple-and-different-scoped-function-calls.html:
  • fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html:
  • fast/profiler/multiple-frames.html:
  • fast/profiler/named-functions-with-display-names.html:
  • fast/profiler/nested-anonymous-functon.html:
  • fast/profiler/nested-start-and-stop-profiler.html:
  • fast/profiler/no-execution-context.html:
  • fast/profiler/one-execution-context.html:
  • fast/profiler/profile-calls-in-included-file.html:
  • fast/profiler/profile-with-no-title.html:
  • fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
  • fast/profiler/profiling-from-a-nested-location.html:
  • fast/profiler/simple-event-call.html:
  • fast/profiler/simple-no-level-change.html:
  • fast/profiler/start-and-stop-profiler-multiple-times.html:
  • fast/profiler/start-and-stop-profiling-in-the-same-function.html:
  • fast/profiler/start-but-dont-stop-profiling.html:
  • fast/profiler/stop-profiling-after-setTimeout.html:
  • fast/profiler/stop-then-function-call.html:
  • fast/profiler/throw-exception-from-eval.html-disabled:
  • fast/profiler/two-execution-contexts.html:
  • fast/profiler/user-defined-function-calls-built-in-functions.html:
  • fast/profiler/window-dot-eval.html:
  • inspector/profiler/cpu-profiler-profiling-without-inspector.html:
  • platform/wk2/Skipped:
12:57 PM Changeset in webkit [118704] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Always create a compositor
https://bugs.webkit.org/show_bug.cgi?id=87598

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.

There will likely be compositing layers either due to web content or
due to overlays.

Defer initialization of OpenGL objects (i.e., delay creation of the
LayerRenderer object) until we actually need to draw and there are such
layers, to avoid initializing OpenGL in the unlikely case that there
are no compositing layers or overlay layers.

PR #156811

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::createCompositor):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):

  • Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

12:37 PM Changeset in webkit [118703] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Crash on incomplete :not().
https://bugs.webkit.org/show_bug.cgi?id=86673

Patch by Yong Li <yoli@rim.com> on 2012-05-28
Reviewed by Antti Koivisto.

Source/WebCore:

Add back null-checks for incomplete :not() class
which were dropped by r81845.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::specificityForOneSelector):
(WebCore::CSSSelector::selectorText):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::determineLinkMatchType):

LayoutTests:

Add a test case that makes CSS parser create incomplete
:not selector.

  • fast/css/crash-on-incomplete-not.html: Added.
  • fast/css/crash-on-incomplete-not-expected.txt: Added.
12:21 PM Changeset in webkit [118702] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Dangling pointer in WebPagePrivate::setCompositor() message
https://bugs.webkit.org/show_bug.cgi?id=87590

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.

A crash would be seen in GuardedPointerBase::getWithGuardLocked when
attempting to unpickle and execute serialized call to setCompositor.

The problem was that the message had been created with a dangling
pointer as the target. The web page failed to inform its compositor
that it was being destroyed due to an early return in
WebPagePrivate::destroyCompositor.

The root cause was that a method called "destroyCompositor" was being
called in two situations, when navigating to a new page as well as when
actually deleting the web page. And in one case, we really only wanted
to free up some memory by clearing textures, while in the other case we
really did want to destroy the compositor.

Fixed by calling a method to release textures when that's what we want
to do, and calling a method to destroy the compositor when that's what
we want to do, and making that latter method unconditional.

Reviewed internally by Jeff Rogers.

PR #156765

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::destroyCompositor):

11:53 AM Changeset in webkit [118701] by commit-queue@webkit.org
  • 8 edits
    3 adds in trunk/Source/WebKit

[BlackBerry] Add a default tap highlight
https://bugs.webkit.org/show_bug.cgi?id=87569

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.

Source/WebKit:

Add DefaultTapHighlight to the build system

Reviewed internally by Mike Lattanzio and Mike Fenton.

PR #154329

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

We used to require the embedder to implement tap highlight drawing.
Now, a default tap highlight, implemented using the recently added
accelerated compositing overlay layer support, can be used instead.

The tap highlight appears instantly but fades out when hidden.

The default tap highlight can be overridden using the new
WebPage::setTapHighlight() method.

Reviewed internally by Mike Lattanzio and Mike Fenton.

PR #154329

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::tapHighlight):
(WebKit):
(BlackBerry::WebKit::WebPage::setTapHighlight):

  • Api/WebPage.h:

(WebKit):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):

  • Api/WebTapHighlight.h: Added.

(WebKit):

  • WebKitSupport/DefaultTapHighlight.cpp: Added.

(WebKit):
(BlackBerry::WebKit::fadeAnimationName):
(BlackBerry::WebKit::DefaultTapHighlight::DefaultTapHighlight):
(BlackBerry::WebKit::DefaultTapHighlight::~DefaultTapHighlight):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):
(BlackBerry::WebKit::DefaultTapHighlight::notifySyncRequired):
(BlackBerry::WebKit::DefaultTapHighlight::paintContents):

  • WebKitSupport/DefaultTapHighlight.h: Added.

(WebKit):
(DefaultTapHighlight):
(BlackBerry::WebKit::DefaultTapHighlight::create):
(BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):
(BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
(BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):
(BlackBerry::WebKit::DefaultTapHighlight::contentsVisible):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

11:33 AM Changeset in webkit [118700] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

FileWriterSync binding should have no static table
https://bugs.webkit.org/show_bug.cgi?id=87645

Reviewed by George Staikos.

FileWriterSync could be used in filesystem FileWriter in worker thread, so we should add ProgressEvent in idl file.

Covered by existing test: fast/filesystem/workers/sync-operations.html.

  • Modules/filesystem/FileWriterSync.idl:
11:29 AM Changeset in webkit [118699] by commit-queue@webkit.org
  • 11 edits in trunk/Source

[BlackBerry] Add an overlay layer
https://bugs.webkit.org/show_bug.cgi?id=87567

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Antonio Gomes.

The overlay layer allows us to have compositing layers even though the
web page is not currently using accelerated compositing.

These layers can be used to implement tap highlight, inspector overlay
and more.

Source/WebCore:

The WebCore changes support the overlay layer functionality in WebKit
by making it possible to add animations from the compositing thread
without them being instantly overwritten during the next commit.

Also a new custom layer type is added, which allow an overlay layer to
draw itself using raw OpenGL calls. An instance of a custom subclass of
LayerCompositingThread must be provided when creating the
LayerWebKitThread. Then, the custom layer can be used as the content
layer of a GraphicsLayer, or by itself.

Reviewed internally by Filip Spacek.

PR #154335

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::~LayerCompositingThread):
(WebCore::LayerCompositingThread::deleteTextures):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawMissingTextures):
(WebCore::LayerCompositingThread::updateTextureContentsIfNeeded):
(WebCore::LayerCompositingThread::setVisible):
(WebCore::LayerCompositingThread::scheduleCommit):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerCompositingThread::addAnimation):
(WebCore::LayerCompositingThread::setRunningAnimations):
(WebCore::LayerCompositingThread::setSuspendedAnimations):
(LayerCompositingThread):
(WebCore::LayerCompositingThread::drawCustom):

  • platform/graphics/blackberry/LayerData.h:

(LayerData):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore):
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::updateTextureContentsIfNeeded):
(WebCore::LayerWebKitThread::startAnimations):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore::LayerWebKitThread::setNeedsDisplayInRect):
(WebCore::LayerWebKitThread::setNeedsDisplay):
(WebCore::LayerWebKitThread::setIsMask):
(WebCore::LayerWebKitThread::setRunningAnimations):
(WebCore::LayerWebKitThread::setSuspendedAnimations):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(LayerWebKitThread):

Source/WebKit/blackberry:

Reviewed internally by Filip Spacek.

PR #154335

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::scheduleRootLayerCommit):
(BlackBerry::WebKit::WebPagePrivate::overlayLayer):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::setOverlayLayer):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):

  • Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::overlayLayer):
(WebPageCompositorPrivate):

  • Api/WebPage_p.h:

(WebPagePrivate):

11:17 AM Changeset in webkit [118698] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

ProgressEvent JSC binding should have no static table
https://bugs.webkit.org/show_bug.cgi?id=87365

Reviewed by George Staikos.

ProgressEvent could be used in filesystem FileWriter in worker thread, so we should add ProgressEvent in idl file.

Covered by existing test: fast/filesystem/workers/file-writer-events.html.

  • dom/ProgressEvent.idl:
10:48 AM Changeset in webkit [118697] by noam.rosenthal@nokia.com
  • 3 edits in trunk/Source/WebKit2

Remove unused argument coders for animation
https://bugs.webkit.org/show_bug.cgi?id=87435

Reviewed by Sam Weinig.

Left the used argument coders only, behind a proper USE(UI_SIDE_COMPOSITING) flag.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC):

  • Shared/WebCoreArgumentCoders.h:
10:29 AM Changeset in webkit [118696] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[BlackBerry] Update WebPageCompositor::render() API
https://bugs.webkit.org/show_bug.cgi?id=87565

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.

Source/WebCore:

The new API allows the embedder to specify the root transform and many
OpenGL related parameters.

Also refactor the code to allow several sets of layers to be rendered,
and to allow interleaving the rendering of layers with rendering of
buffers and checkerboard.

Reviewed internally by Filip Spacek.

PR #154334

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::orthoMatrix):
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::prepareFrame):
(WebCore):
(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawCheckerboardPattern):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::LayerRenderer::prepareFrameRecursive):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::updateScissorIfNeeded):
(WebCore::LayerRenderingResults::addHolePunchRect):

  • platform/graphics/blackberry/LayerRenderer.h:

(LayerRenderer):

Source/WebKit/blackberry:

The new API allows the embedder to specify the root transform and many
OpenGL related parameters to be used when rendering the web page.

To honor the transform, we have to implement a way to composite the
BackingStore output using a generic transform. This method,
BackingStorePrivate::compositeContents(), uses a strategy that differs
from blitContents(), because that one is optimized for software
blitting, while this one is optimized for GPU rendering. Specifically,
instead of drawing the checkerboard first, and the rendered subregions
of the tile afterward, we draw the whole tile in one call, and then
draw checkered regions on top, if any.

Removed the blit generation condvar from the new code paths for drawing
BackingStore output using a transform, since the condvar is ineffective
in preventing flicker when we're not in charge of swapping the window.
Instead, another synchronization solution will be implemented in the
future.

Reviewed internally by Filip Spacek.
Some parts reviewed internally by Jacky Jiang and others by
Mike Lattanzio.

PR #151887, #154334

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):

  • Api/BackingStore_p.h:

(WebCore):
(BackingStorePrivate):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositor::prepareFrame):
(BlackBerry::WebKit::WebPageCompositor::render):

  • Api/WebPageCompositor.h:
  • Api/WebPageCompositorClient.h:
  • Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:
9:59 AM Changeset in webkit [118695] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Adjust expectations for fast/layers/clip-rects-assertion-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=87671

Unreviewed gardening.
Temporarily adds "MISSING" for this test.

  • platform/chromium/test_expectations.txt:
9:54 AM Changeset in webkit [118694] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r118399 -> <rdar://problem/11527190>

9:52 AM Changeset in webkit [118693] by Lucas Forschler
  • 12 edits in branches/safari-536-branch

Merged r118397 -> <rdar://problem/11024330>

9:49 AM Changeset in webkit [118692] by Lucas Forschler
  • 5 edits
    4 copies in branches/safari-536-branch

Merged r118039 -> <rdar://problem/11348396>

9:41 AM Changeset in webkit [118691] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] http/tests/cache/cancel-in-progress-load.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=87657

Unreviewed gardening.
It should be "MISSING" rather than "IMAGE" (fixes r118683).

  • platform/chromium/test_expectations.txt:
9:28 AM Changeset in webkit [118690] by bulach@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Adds missing expectation after r118577
https://bugs.webkit.org/show_bug.cgi?id=87670

Unreviewed gardening.
A few baselines were already added by r118584. Adds baseline for Windows.

  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
9:23 AM Changeset in webkit [118689] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Plumb through the return value of makeCurrent to caller
https://bugs.webkit.org/show_bug.cgi?id=87564

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Rob Buis.

This way the caller can take appropriate action if makeCurrent fails,
for example because we're running out of memory.

Reviewed internally by George Staikos.

PR #149721

  • WebKitSupport/GLES2Context.cpp:

(BlackBerry::WebKit::GLES2Context::makeCurrent):

9:22 AM Changeset in webkit [118688] by Antti Koivisto
  • 3 edits
    2 adds in trunk

REGRESSION(r96517): Attribute selector fails to match dynamically modified style attribute
https://bugs.webkit.org/show_bug.cgi?id=87349

Source/WebCore:

Reviewed by Andreas Kling.

Selector fast path does not trigger lazy style attribute generation. Since attribute selectors matching
style attribute are rare, disallow them from the fast path rather than making it more branchy.

Test: fast/css/dynamic-style-attribute-query.html

  • css/SelectorChecker.cpp:

(WebCore::isFastCheckableMatch):

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/dynamic-style-attribute-query-expected.txt: Added.
  • fast/css/dynamic-style-attribute-query.html: Added.
9:05 AM Changeset in webkit [118687] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] [V8] Layout Test fast/js/string-replace-2.html failing following 11594 => 11648 v8 update
https://bugs.webkit.org/show_bug.cgi?id=87423

Unreviewed gardening.

We have rolled v8 and we can now set the expectation for both debug and release back to TEXT.

  • platform/chromium/test_expectations.txt:
8:57 AM Changeset in webkit [118686] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
8:52 AM Changeset in webkit [118685] by commit-queue@webkit.org
  • 16 edits in trunk

Web Inspector: Expose function (closure) scopes in remote protocol
https://bugs.webkit.org/show_bug.cgi?id=86861

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-05-28
Reviewed by Yury Semikhatsky.

Source/WebCore:

A data transfer from V8's FunctionMirror via DebuggerScript.js via InjectedScriptHost is built.
Scope field is added to protocol declaration similar to scopes of stack call frame.
Test for function details is extended.
JSC code binging got fixme for implemting the corresponding feature.

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::functionDetails):

  • bindings/v8/DebuggerScript.js:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::functionScopes):
(WebCore):

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::functionDetailsCallback):

  • inspector/InjectedScriptHost.cpp:

(WebCore):
(WebCore::InjectedScriptHost::scriptDebugServer):

  • inspector/InjectedScriptHost.h:

(WebCore):
(WebCore::InjectedScriptHost::init):
(InjectedScriptHost):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

LayoutTests:

Test for function details now checks scopes.

  • inspector/debugger/function-details-expected.txt:
  • inspector/debugger/function-details.html:
  • platform/chromium/inspector/debugger/function-details-expected.txt:
8:45 AM Changeset in webkit [118684] by bulach@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[chromium] Rebaseline following r118598
https://bugs.webkit.org/show_bug.cgi?id=87669

Unreviewed gardening.

In chromium we print a prefix "line 1:" on one console message.

  • platform/chromium/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.
8:07 AM Changeset in webkit [118683] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] http/tests/cache/cancel-in-progress-load.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=87657

Unreviewed gardening.

Adds PASS and IMAGE expectations.

  • platform/chromium/test_expectations.txt:
8:04 AM Changeset in webkit [118682] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Add a constructor to create a Path from an SkPath
https://bugs.webkit.org/show_bug.cgi?id=87566

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-28
Reviewed by Antonio Gomes.

Skia allows the creation of more complex paths than WebCore would
allow. This will be used in the BlackBerry port to implement a default
tap highlight appearance.

Reviewed internally by Mike Lattanzio.

PR #154329

  • platform/graphics/Path.h:

(Path):

  • platform/graphics/skia/PathSkia.cpp:

(WebCore):
(WebCore::Path::Path):

7:54 AM Changeset in webkit [118681] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Mac on Lion.

  • inspector/CodeGeneratorInspector.py:
6:49 AM Changeset in webkit [118680] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] http/tests/cache/cancel-in-progress-load.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=87657

Unreviewed gardening.

r118618 added this new test but it's been flaky in chromium.

  • platform/chromium/test_expectations.txt:
6:23 AM Changeset in webkit [118679] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Baseline compositing/geometry/composited-in-columns.html
https://bugs.webkit.org/show_bug.cgi?id=87653

Unreviewed gardening.

r118567 introduced a new test. Chromium is positioning the layers
a few pixels off.
Set the baseline for IMAGE+TEXT temporarily.

  • platform/chromium/test_expectations.txt:
6:16 AM Changeset in webkit [118678] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Build fix for the Android bot, set CXX_target at gyp generation-time
https://bugs.webkit.org/show_bug.cgi?id=87649

Unreviewed build fix.

Chromium Android builds were broken because v8 tried to compile files
for target with the "-m32" flag. This was caused by a v8 check falling
back to using "which g++" to find the right compiler, whereas it should
have used the $CXX_target environment variable. This isn't being set
for Android builds.

  • gyp_webkit: Set the CXX_target environment variable. Annotate the fix with a FIXME comment too.
5:50 AM Changeset in webkit [118677] by keishi@webkit.org
  • 12 edits in trunk/Source

Expose value localization function of HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=84356

Reviewed by Kent Tamura.

Source/WebCore:

No new tests.

We want to localize the values that are defined in the datalist element.
This adds HTMLInputElement::localizeValue() which will localize a given
value.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::localizeValue):
(WebCore):
(WebCore::BaseDateAndTimeInputType::visibleValue):

  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::localizeValue):
(WebCore):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::localizeValue):
(WebCore):

  • html/InputType.h:

(InputType):

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::localizeValue):
(WebCore):
(WebCore::NumberInputType::visibleValue):

  • html/NumberInputType.h:

(NumberInputType):

Source/WebKit/chromium:

  • public/WebInputElement.h:

(WebInputElement):

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::localizeValue):
(WebKit):

5:38 AM Changeset in webkit [118676] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] LayoutTestController needs DeferredFrameLoading flag
https://bugs.webkit.org/show_bug.cgi?id=87652

Unreviewed gardening.

r118631 introduced a new test and a new API on LayoutTestController
that we need to implement in chromium.
Skip the test temporarily.

  • platform/chromium/test_expectations.txt:
5:15 AM Changeset in webkit [118675] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

fast/tokenizer/entities-01.html & fast/tokenizer/entities-03.html need new baseline after r118672
https://bugs.webkit.org/show_bug.cgi?id=87648

Unreviewed gardening.

r118672 fixed a rendering bug with &AElig but did not update the
expected results for fast/tokenizer/entities-01.html and
fast/tokenizer/entities-03.html.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-28

  • fast/tokenizer/entities-01-expected.txt:
  • fast/tokenizer/entities-03-expected.txt:
5:09 AM Changeset in webkit [118674] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Test fix after r118670: saved timeline data may
not have DOM counters data and MemoryStatistics object should
take this into account.

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._onRecordAdded):

4:13 AM Changeset in webkit [118673] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r118580.
http://trac.webkit.org/changeset/118580
https://bugs.webkit.org/show_bug.cgi?id=87647

Caused webkit_unit_tests to crash on chromium. (Requested by
bulach on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-28

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerPainter::ContentLayerPainter):
(ContentLayerPainter):
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::updateTiles):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):

3:23 AM Changeset in webkit [118672] by peter@chromium.org
  • 5 edits in trunk

&AElig doesn't get rendered as U+00C6
https://bugs.webkit.org/show_bug.cgi?id=87465

Reviewed by Adam Barth.

Source/WebCore:

The if-statement to check whether the first entry of a certain letter
already exists in the index used .get(). The very first alphabetical
entry is in position "0", which evaluates to false, causing the first
entry to be ignored. Instead, use a "x not in y" check here.

Also update WebCore.gyp to list the create-html-entity-table script as
an input for the action, to make sure the table will be recreated.

Test: html5lib/resources/entities02.dat

  • WebCore.gyp/WebCore.gyp:
  • html/parser/create-html-entity-table:

LayoutTests:

Test that the (current) first alphabetical entity in the named entity
table (&AElig, without a semi-colon) renders as expected.

  • html5lib/resources/entities02.dat:
3:21 AM Changeset in webkit [118671] by Carlos Garcia Campos
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing header file.
3:20 AM Changeset in webkit [118670] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: dom counters graphs vanish on switching between timeline views
https://bugs.webkit.org/show_bug.cgi?id=87628

Reviewed by Vsevolod Vlasov.

MemoryStatistics object now listens to the TimelineModel events instead of being
populated by timeline panel. This behavior mathes that of the overview pane.

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype.addTimlineEvent):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):

3:19 AM Changeset in webkit [118669] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

Remove obsolete feature define ENABLE_3D_CANVAS from FeatureDefines.vsprops for windows
https://bugs.webkit.org/show_bug.cgi?id=87622

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-28
Reviewed by Eric Seidel.

Removed the ENABLE_3D_CANVAS from the property define as this is
obsolete since bug #53041

  • win/tools/vsprops/FeatureDefines.vsprops:
3:14 AM Changeset in webkit [118668] by bulach@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Buildfix: remove obsolete file from gypi.
https://bugs.webkit.org/show_bug.cgi?id=87643

Reviewed by no-reviewer.

Following http://trac.webkit.org/changeset/118610.
Removes reference to platform/graphics/gstreamer/ImageGStreamerCG.mm

  • WebCore.gypi:
3:12 AM Changeset in webkit [118667] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] fast/dom/beforeload/image-object-before-load* need to be skipped after r118618
https://bugs.webkit.org/show_bug.cgi?id=87632

Unreviewed EFL gardening.
fast/dom/beforeload/image-object-before-load* need to be skipped after
r118618. The issue will be addressed in Bug 87631.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-28

  • platform/efl/test_expectations.txt:
3:07 AM Changeset in webkit [118666] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] http/tests/appcache/abort-cache* are flaky and should be skipped
https://bugs.webkit.org/show_bug.cgi?id=87634

Unreviewed EFL gardening. Aborting application cache downloads is
flaky on EFL port so we need to skip the corresponding test cases for
now.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-28

  • platform/efl/test_expectations.txt:
2:54 AM Changeset in webkit [118665] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Move input element's internal spinner layout tests to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=87629

Unreviewed EFL gardening.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-28

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
2:54 AM Changeset in webkit [118664] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

HTMLFormControlElement::m_validationMessage shouldn't be cleared on detach()
https://bugs.webkit.org/show_bug.cgi?id=87608

Reviewed by Kent Tamura.

Moved m_validationMessage clearance from detach() to removedFrom() and
remove detach().

No new tests. This change has no visible difference. Upcoming changes rely on this though.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::removedFrom):

2:49 AM Changeset in webkit [118663] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[EFL] Unreviewed EFL gardening after r118585
https://bugs.webkit.org/show_bug.cgi?id=87621

Unreviewed EFL Gardening.

Two contentSecurityPolicy tests need expectation for EFL port after
r118585 due to line numbers not being printed. Mac and GTK port are
already doing the same.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-28

  • platform/efl/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
  • platform/efl/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.
2:44 AM Changeset in webkit [118662] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: "Record CPU profile" button doesn't change its state after finishing profiling
https://bugs.webkit.org/show_bug.cgi?id=87624

Reviewed by Vsevolod Vlasov.

Keep record button state in sync with the current profiling state.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.toggleRecordButton):

2:38 AM Changeset in webkit [118661] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Test added in r118577 is failing and should be skipped
https://bugs.webkit.org/show_bug.cgi?id=87620

Unreviewed EFL gardening. Skipping new test introduced in r118577
which is failing on our port.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-28

  • platform/efl/test_expectations.txt:
2:14 AM Changeset in webkit [118660] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed Mac Chromium build fix.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::allowStyleScoped):

2:14 AM Changeset in webkit [118659] by zandobersek@gmail.com
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r118650.
http://trac.webkit.org/changeset/118650
https://bugs.webkit.org/show_bug.cgi?id=87639

Patch caused massive failures throughout the builders
(Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-28

  • css/MediaQuery.cpp:

(WebCore):
(WebCore::MediaQuery::serialize):
(WebCore::MediaQuery::MediaQuery):
(WebCore::MediaQuery::cssText):

  • css/MediaQuery.h:

(WebCore::MediaQuery::expressions):
(WebCore::MediaQuery::mediaType):
(MediaQuery):
(WebCore::MediaQuery::copy):

  • css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::MediaQueryEvaluator):
(WebCore::MediaQueryEvaluator):
(WebCore::MediaQueryEvaluator::eval):
(WebCore::aspect_ratioMediaFeatureEval):
(WebCore::device_aspect_ratioMediaFeatureEval):
(WebCore::transform_3dMediaFeatureEval):
(WebCore::view_modeMediaFeatureEval):
(WebCore::createFunctionMap):

  • css/MediaQueryEvaluator.h:

(WebCore):
(MediaQueryEvaluator):

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(MediaQueryResult):
(WebCore::MediaQueryResult::MediaQueryResult):
(WebCore):
(StyleResolver):

2:08 AM Changeset in webkit [118658] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] New tests added in r118567 should be skipped on EFL port
https://bugs.webkit.org/show_bug.cgi?id=87618

Unreviewed EFL gardening. Move the test added in r118567 to test
expectations since the EFL port lacks support for
LayoutTestController::layerTreeAsText.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-28

  • platform/efl/test_expectations.txt:
2:05 AM Changeset in webkit [118657] by gyuyoung.kim@samsung.com
  • 20 edits in trunk

Move allowRoundingHacks to Internals interface
https://bugs.webkit.org/show_bug.cgi?id=87328

Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter: Add allowRoundingHacks symbol filter.

Source/WebCore:

Add allowRoundingHacks function, because it is able to work in the
cross-port way by means of the Internals interface.

In addition, a function is added in order to restore default setting values.

No new tests, since we are improving here the infra-structure for testing
a specific method.

  • testing/Internals.cpp:

(WebCore::Internals::reset):
(WebCore):
(WebCore::Internals::resetDefaultsToConsistentValues):
(WebCore::Internals::allowRoundingHacks):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def: Add setAllowsRoundingHacks() to symbol filter.

Tools:

Remove allowRoundingHacks functions, because it is able to work in the
cross-port way through the Internals interface.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

LayoutTests:

Invoke allowRoundingHacks function from internals, because it is able to work in the
cross-port way via the Internals interface.

  • platform/mac/fast/text/rounding-hacks-expansion.html:
  • platform/mac/fast/text/rounding-hacks.html:
2:03 AM Changeset in webkit [118656] by macpherson@chromium.org
  • 2 edits in trunk/Tools

Fix mac build with older XCode by defining NSEC_PER_MSEC.
https://bugs.webkit.org/show_bug.cgi?id=87616

Reviewed by Hajime Morita.

The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
Patch just adds a #ifndef / #define check.

  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):

1:53 AM Changeset in webkit [118655] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] http authentication crash the browser when user commit or cancel the http authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=87579

Patch by Jonathan Dong <Jonathan Dong> on 2012-05-28
Reviewed by George Staikos.

In function NetworkJob::startNewJobWithRequest, We should cancel the
NetworkJob first before we start a new NetworkJob which reuses the
resource handle of the old one. If we only set the m_handle = 0 of the
old NetworkJob without cancelling itself, it will still receives data
notification from network thread and handles the received data with
the released resource handler, which will cause the crash.

No new tests because no behavior has changed.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::startNewJobWithRequest):

1:40 AM Changeset in webkit [118654] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

[Refactoring][ShadowDOM] Some ElementShadow methods can be inlined.
https://bugs.webkit.org/show_bug.cgi?id=87617

Reviewed by Kentaro Hara.

Inlined ElementShadow::attachHost(), ElementShadow::detachHost() and
ElementShadow::reattach()

No new tests. No behavior change.

  • dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::detach):

  • dom/ElementShadow.cpp:

(WebCore::ElememtnShadow::reattachHostChildrenAndShadow):

  • dom/ElementShadow.h:

(ElementShadow):

1:17 AM Changeset in webkit [118653] by morrita@google.com
  • 3 edits in trunk/Source/WebKit/chromium

https://bugs.webkit.org/show_bug.cgi?id=87609
[Chromium] FrameLoaderClient::allowStyleScoped() should be implemented interms of WebPermissionClient

Reviewed by Kent Tamura.

Added allowStyleScoped() implementation which is essentially same as shadowDOMAllowed().

  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

1:03 AM Changeset in webkit [118652] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: protect typed API from C++ implicit float to int cast
https://bugs.webkit.org/show_bug.cgi?id=87183

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-05-28
Reviewed by Yury Semikhatsky.

An intermediate C++ class is introduced that uses C++ template technique to control actual type
of its constructor argument.
All input parameters of type "int" now have type ExactlyInt.
All usage sites are fixed accordingly.

  • inspector/CodeGeneratorInspector.py:

(TypeModel.RefPtrBased):
(TypeModel.Enum):
(TypeModel.ValueType):
(TypeModel.ValueType.get_opt_output_type_):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(TypeModel.ExactlyInt):
(TypeModel.ExactlyInt.init):
(TypeModel.ExactlyInt.get_input_param_type_text):
(TypeModel.ExactlyInt.get_opt_output_type_):
(TypeModel.init_class):
(ExactlyInt):

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::didCreateWorker):
(WebCore::InspectorAgent::didDestroyWorker):
(WebCore::InspectorAgent::evaluateForTestInFrontend):

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::jsHeapInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::notifyContextCreated):

12:48 AM Changeset in webkit [118651] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-binding-tests results.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectOwner::finalize):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterOwner::finalize):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetOwner::finalize):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionOwner::finalize):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerOwner::finalize):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjOwner::finalize):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::installPerContextProperties):

12:11 AM Changeset in webkit [118650] by Darin Adler
  • 7 edits in trunk/Source/WebCore

StyleResolver need not allocate each MediaQueryResult on the heap
https://bugs.webkit.org/show_bug.cgi?id=75223

Reviewed by Daniel Bates.

  • css/MediaQuery.cpp: Removed some comments that pointed to CSS documents.

There is no guarantee these links will be valid over time.
(WebCore::MediaQuery::MediaQuery): Rewrote for clarity, conventional WebKit coding
style, and simplicity.
(WebCore::MediaQuery::copy): Moved out of line; not performance critical, and this
allows us to cut down header dependencies.
(WebCore::MediaQuery::cssText): Updated for change to data member name.

  • css/MediaQuery.h: Removed unneeded includes. Removed non-helpful argument name

"exprs". Changed expressions function to return a reference instead of
a pointer. Changed mediaType and cssText functions to return a reference. Renamed
m_serializationCache to m_serializedQuery. Moved copy function out of header.

  • css/MediaQueryEvaluator.cpp: Renamed EvalFunc to MediaFeatureEvaluationFunction.

Broke a FIXME into three and reworded for clarity.
(WebCore::MediaQueryEvaluator): Updated for name changes.
(WebCore::MediaQueryEvaluator::eval): Rewrote this for clarity and to regularize
the logic a bit.
(WebCore::aspect_ratioMediaFeatureEval): Got rid of a != 0 that is contrary to the
normal WebKit style.
(WebCore::device_aspect_ratioMediaFeatureEval): Ditto.
(WebCore::transform_3dMediaFeatureEval): Fixed mangled #if that was here.
(WebCore::view_modeMediaFeatureEval): Replaced UNUSED_PARAM usage with ASSERT_UNUSED.
(WebCore::createFunctionMap): Changed this so it returns the map so we can use a
cleaner style in the caller.
(WebCore::MediaQueryEvaluator::eval): Updated to take a reference and improved the
comments and coding style a bit.

  • css/MediaQueryEvaluator.h: Updated comment style. Removed unused constructor.

Removed unneeded destructor declaration. Renamed m_expResult to m_mediaFeatureResult.

  • css/StyleResolver.cpp: Moved the MediaQueryResult class into this file

and made it a structure rather than a class.
(WebCore::StyleResolver::addViewportDependentMediaQueryResult): Updated to take
a reference argument instead of a pointer and for the new vector type.
(WebCore::StyleResolver::affectedByViewportChange): Updated for above changes.

  • css/StyleResolver.h: Removed many unneeded includes and forward declarations of

classes, including now-unneeded include of MediaQueryExp.h. Replaced MediaQueryResult
definition with a forward declaration. Changed addViewportDependentMediaQueryResult
to take a reference instead of a pointer. Changed m_viewportDependentMediaQueryResults
to be a vector of values rather than of pointers.

May 27, 2012:

10:48 PM Changeset in webkit [118649] by Darin Adler
  • 2 edits in trunk/Source/WTF

Fix an incorrect assertion in Vector::remove
https://bugs.webkit.org/show_bug.cgi?id=87612

Reviewed by Dan Bernstein.

  • wtf/Vector.h: There's no good reason to disallow calling remove

with a size of 0, even when the position is at the end of the vector,
so changed the two-argument Vector::remove assertion to assert that
the position is <= size rather than < size.

10:13 PM Changeset in webkit [118648] by shinyak@chromium.org
  • 3 edits
    4 adds in trunk

cut, copy or paste event won't be fired in Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=87352

Reviewed by Dimitri Glazkov.

Source/WebCore:

cut, copy or paste event was not fired in Shadow DOM.
Since event re-targeting has been implemented, it should be safe to fire them in Shadow DOM now.

Tests: fast/dom/shadow/cppevent-in-shadow.html

fast/dom/shadow/cppevent-input-in-shadow.html

  • editing/Editor.cpp:

(WebCore::Editor::findEventTargetFrom):

LayoutTests:

  • fast/dom/shadow/cppevent-in-shadow-expected.txt: Added.
  • fast/dom/shadow/cppevent-in-shadow.html: Added.
  • fast/dom/shadow/cppevent-input-in-shadow-expected.txt: Added.
  • fast/dom/shadow/cppevent-input-in-shadow.html: Added.
10:00 PM Changeset in webkit [118647] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] Enable blob support for the EFL port
https://bugs.webkit.org/show_bug.cgi?id=85363

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-27
Reviewed by Hajime Morita.

.:

Enable Blob support by default for the EFL port.

  • Source/cmake/OptionsEfl.cmake:

Tools:

Enable Blob support by default for the EFL port.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Unskip tests which require blob support to be enabled.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
9:56 PM Changeset in webkit [118646] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Weak pointer finalization should be lazy
https://bugs.webkit.org/show_bug.cgi?id=87599

Reviewed by Darin Adler.

  • heap/Heap.cpp:

(JSC::Heap::collect): Don't force immediate finalization -- it will
happen lazily.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep): Sweep a block's weak set when sweeping the
block. The weak set may not have been swept yet, and this is our last
chance to run weak finalizers before we recycle the memory they reference.

  • heap/MarkedBlock.h:
  • heap/MarkedSpace.cpp:

(JSC::MarkedBlock::sweepWeakSets):

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::sweepWeakSets): Nixed sweepWeakSets because it's unused
now.

9:39 PM Changeset in webkit [118645] by hayato@chromium.org
  • 5 edits in trunk

Support multiple shadow roots in event dispatching.
https://bugs.webkit.org/show_bug.cgi?id=87470

Reviewed by Dimitri Glazkov.

Source/WebCore:

The current implementation does not set event's target correctly
if an event happens on DOM tree with multiple shadow roots. So
this patch updates an event re-targeting algorithm so that it
works even if it is applied to multiple shadow roots.

Tests: fast/dom/shadow/shadow-dom-event-dispatching.html

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseParentIncludingInsertionPointAndShadowRoot):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::ensureEventAncestors):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
9:22 PM Changeset in webkit [118644] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Minor code cleaning for the interface of MainResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=87607

Reviewed by Darin Adler.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::handleSubstituteDataLoadNow):
(WebCore::MainResourceLoader::handleSubstituteDataLoadSoon):

  • loader/MainResourceLoader.h:

(MainResourceLoader):
-Add the OVERRIDE keyword for the methods inherited from ResourceLoader.
-Remove the useless declaration of handleDataLoad(ResourceRequest&), this method does not exist.
-Rename handleDataLoadNow() to handleSubstituteDataLoadNow() and make the method private. This should

only be used by handleSubstituteDataLoadSoon() and indirectly through the timer.

7:26 PM Changeset in webkit [118643] by yosin@chromium.org
  • 4 edits in trunk/Source

[WTF] Introduce UINT64_C to MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=87485

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces UINT64_C for all platforms to avoid using
conditional compilation.

No new tests. This patch doesn't change behavior.

  • Modules/websockets/WebSocketFrame.cpp:

(WebCore::WebSocketFrame::parseFrame): Replace conditional compilation with UINT64_C.

Source/WTF:

  • wtf/MathExtras.h:
7:05 PM Changeset in webkit [118642] by mitz@apple.com
  • 5 copies
    1 add in releases/Apple/Safari 5.1.7

Added a tag for the Safari 5.1.7 release.

Safari 5.1.7 includes JavaScriptCore-x534.57.3, JavaScriptGlue-x534.57.2, WebCore-x534.57.2, WebKit-x534.57.2, and WebKit2-x534.57.2.

6:58 PM Changeset in webkit [118641] by mitz@apple.com
  • 4 copies
    1 add in releases/Apple/OS X Lion Update 10.7.4

Added a tag for the OS X Lion Update 10.7.4 release.

OS X Lion v10.7.4 includes JavaScriptCore-7534.56.6, WebCore-7534.56.5, WebKit-7534.56.5, and WebKit2-7534.56.5.

6:56 PM Changeset in webkit [118640] by rakuco@webkit.org
  • 2 edits in trunk

[CMake] Make WEBKIT_SET_EXTRA_COMPILER_FLAGS work with clang.
https://bugs.webkit.org/show_bug.cgi?id=87597

Reviewed by Daniel Bates.

Building with clang requires at least the -fPIC option being
passed correctly, just like it is needed with gcc. clang is also
compatible with most of gcc's compiler options, so we only need to
check for clang besides g++ in the macro definition.

  • Source/cmake/WebKitHelpers.cmake: Check for "Clang" and use

CMAKE_COMPILER_IS_GNUCXX for the previous check, as it is shorter
and achieves the same effect.

6:53 PM Changeset in webkit [118639] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Use StringBuilder in WebKitCSSTransformValue::customCssText() to allow code reuse with CSS Variables.
https://bugs.webkit.org/show_bug.cgi?id=87462

Reviewed by Dimitri Glazkov.

Factor out strings into a const char* array, and use a StringBuilder instead of String concatenation.
This will allow future code to re-use the array of transform names, and StringBuilder is generally faster.

Covered by existing CSS transform tests.

  • css/WebKitCSSTransformValue.cpp:

(WebCore):
(WebCore::WebKitCSSTransformValue::customCssText):

6:52 PM Changeset in webkit [118638] by mitz@apple.com
  • 5 copies
    1 add in releases/Apple/Safari 5.1.5

Added a tag for the Safari 5.1.5 release.

Safari 5.1.5 includes JavaScriptCore-x534.55.2, JavaScriptGlue-x534.55.2, WebCore-x534.55.3, WebKit-x534.55.3, and WebKit2-x534.55.3.

6:49 PM Changeset in webkit [118637] by mitz@apple.com
  • 5 copies
    1 add in releases/Apple/Safari 5.1.4

Added a tag for the Safari 5.1.4 release.

Safari 5.1.4 includes JavaScriptCore-x534.54.15, JavaScriptGlue-x534.54.5, WebCore-x534.54.17, WebKit-x534.54.16, and WebKit2-x534.54.16.

6:44 PM Changeset in webkit [118636] by mitz@apple.com
  • 4 copies
    1 add in releases/Apple/OS X Lion Update 10.7.3

Added a tag for the OS X Lion Update 10.7.3 release.

OS X Lion v10.7.3 includes JavaScriptCore-x534.53.8, WebCore-x534.53.11, WebKit-x534.53.11, and WebKit2-x534.53.11.

6:24 PM Changeset in webkit [118635] by mitz@apple.com
  • 5 copies
    1 add in releases/Apple/Safari 5.1.2

Added a tag for the Safari 5.1.2 release.

Safari 5.1.2 includes JavaScriptCore-x534.52.7, JavaScriptGlue-x534.51.13, WebCore-x534.52.11, WebKit-x534.52.7, and WebKit2-x534.52.7.

6:17 PM Changeset in webkit [118634] by mitz@apple.com
  • 5 copies
    1 add in releases/Apple/Safari 5.1.1

Added a tag for the Safari 5.1.1 release.

Safari 5.1.1 includes JavaScriptCore-x534.51.21, JavaScriptGlue-x534.51.13, WebCore-x534.51.22, WebKit-x534.51.22, and WebKit2-x534.51.22.

5:28 PM Changeset in webkit [118633] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

fast/dom/shadow/content-element-in-media.html is wrong.
https://bugs.webkit.org/show_bug.cgi?id=81310

Modifying to check() to dump expected and actual text at the same
absolute position, because DumpRenderTree dumps absolute x,y-position
information for a layer which contains RenderVideo. For example,
backgroundClip at (8,163), clip at (8, 163) and so on.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-27
Reviewed by Hajime Morita.

  • fast/dom/resources/shadow-test-driver.js:

(check):
Disabled actual block when dumping expected block as text, and vice
versa.

  • platform/chromium/test_expectations.txt:

Removed BUGWK81310.

5:23 PM Changeset in webkit [118632] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Update color for tap highlight and selection
https://bugs.webkit.org/show_bug.cgi?id=87606

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-27
Reviewed by Antonio Gomes.

PR #154813

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::platformTapHighlightColor):
(WebCore::RenderThemeBlackBerry::platformActiveSelectionBackgroundColor):

2:31 PM Changeset in webkit [118631] by benjamin@webkit.org
  • 9 edits
    4 adds in trunk

When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
https://bugs.webkit.org/show_bug.cgi?id=87582

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-05-27
Reviewed by Darin Adler.

Source/WebCore:

Previously, there was a shortcut when a deferred MainResourceLoader is resumed: If the data
was coming from AppCache we could jump directly to startDataLoadTimer().

The problem with the shortcut is willSendRequest() is never called in that particular case
(substituteData + deferred-resume). The imbalance between willSendRequest() and didReceiveResponse()
causes problems.

This patch removes the shortcut so that MainResourceLoader::loadNow() is used regardless of
the deferred loading. The method MainResourceLoader::loadNow() handle the substituteData as if the loading
was not deferred.

Test: http/tests/appcache/load-from-appcache-defer-resume-crash.html

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::continueAfterNavigationPolicy):
(WebCore::MainResourceLoader::handleSubstituteDataLoadSoon):
Rename the method to be consistent with the attribute it uses, making the naming more explicit.
(WebCore::MainResourceLoader::loadNow):
(WebCore::MainResourceLoader::setDefersLoading):

  • loader/MainResourceLoader.h:

(MainResourceLoader):

Tools:

Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
possible to test pages in a similar way as they are loaded in Browsers.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(setUseDeferredFrameLoadingCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::useDeferredFrameLoading):
(LayoutTestController::setUseDeferredFrameLoading):
(LayoutTestController):

  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):

LayoutTests:

  • http/tests/appcache/load-from-appcache-defer-resume-crash-expected.txt: Added.
  • http/tests/appcache/load-from-appcache-defer-resume-crash.html: Added.
  • http/tests/appcache/resources/load-from-appcache-defer-resume-bounce-back.html: Added.
  • http/tests/appcache/resources/load-from-appcache-defer-resume-crash.manifest: Added.
12:51 PM Changeset in webkit [118630] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening after r118618.

  • platform/gtk/test_expectations.txt:
12:48 PM Changeset in webkit [118629] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Trivial unreviewed build fix with newer Qt

  • Api/qwebpage.cpp:

(QWebPage::javaScriptPrompt): Don't use deprecated QString/QChar functions.

12:27 PM Changeset in webkit [118628] by Dave Barton
  • 2 edits in trunk/Tools

[watchlist] Improve MathML rule
https://bugs.webkit.org/show_bug.cgi?id=87592

Reviewed by Adam Barth.

The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
but if this changed the rule would be slow. We protect against this, clarify the rule,
and make it more similar to existing rules.

  • Scripts/webkitpy/common/config/watchlist:
7:54 AM Changeset in webkit [118627] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash when deleting WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=87589

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-27
Reviewed by Rob Buis.

The WebPageCompositorPrivate is reference counted, so it may outlive
either the WebPage or the WebPageCompositor, depending on who releases
its reference first.

Fixed by disconnecting the objects properly, regardless of who goes
away first.

Reviewed internally by Mike Lattanzio.

PR #156444

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::destroyCompositor):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::client):

  • Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::setPage):

7:41 AM Changeset in webkit [118626] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] BackingStore accesses tiles even though it's not active
https://bugs.webkit.org/show_bug.cgi?id=87563

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-18
Reviewed by Antonio Gomes.

There are many scenarios that can call render and cause tile access,
and they used to be rerouted to the direct rendering code when the
backing store was not active. This was thanks to an implicit check for
isActive() by virtue of calling shouldDirectRenderingToWindow() from
render().

If we're using OpenGL for compositing the backing store contents
however, direct rendering is always disabled and we jump right into the
tile based rendering code.

Fixed by adding an explicit check for isActive() in render(), now that
the implicit check in shouldDirectRenderingToWindow() is conditional on
having raster usage.

Since PR136381/bug83131, when OpenGL compositing is used, and the
backing store is not active, it is not in charge of drawing the root
layer. Instead, we switch off the paintingGoesToWindow flag on the root
RenderLayer so no invalidates will reach the ChromeClient or the
BackingStore any more. Instead, invalidations will cause the root
accelerated compositing layer to be repainted. Any BackingStore render
calls while in this state are pointless, and can safely do an early
return.

Reviewed internally by Jakob Petsovits.

PR #150403

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):

7:17 AM Changeset in webkit [118625] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Web page fails to render after clicking link with target=_blank
https://bugs.webkit.org/show_bug.cgi?id=87562

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-12
Reviewed by Antonio Gomes.

Clicking such a link opens a new tab. The compositor was briefly in
charge of drawing the root layer while the backing store was inactive
and the user was looking at the other tab. The problem was that the
compositor believed it was still painting the root layer even after the
backing store became active again. The flag was not properly cleared
when turning off compositing.

Fixed by returning false from drawsRootLayer() if we don't have a root
layer.

Reviewed internally by Filip Spacek.

PR #149342

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::drawsRootLayer):

4:35 AM Changeset in webkit [118624] by ddkilzer@apple.com
  • 5 edits in trunk/Source/WebCore

Use xcrun to find gperf path on platforms that use Xcode
<http://webkit.org/b/87587>

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj:

(Generate Derived Sources): Set GPERF environment variable using
xcrun.

  • css/makeprop.pl: Use GPERF environment variable if set, else

"gperf".

  • css/makevalues.pl: Ditto.
  • make-hash-tools.pl: Ditto.
12:40 AM Changeset in webkit [118623] by Dave Barton
  • 2 edits in trunk/Tools

[watchlist] Add myself & a rule for MathML
https://bugs.webkit.org/show_bug.cgi?id=87586

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:
12:35 AM Applications using WebKit edited by rmoneymunch@yahoo.com
(diff)
12:34 AM Applications using WebKit edited by rmoneymunch@yahoo.com
(diff)
12:34 AM Changeset in webkit [118622] by commit-queue@webkit.org
  • 5 edits in trunk

[FileAPI] FileReader should fire progress event when blob has been completely read into memory
https://bugs.webkit.org/show_bug.cgi?id=87585

Patch by Li Yin <li.yin@intel.com> on 2012-05-27
Reviewed by Kentaro Hara.

From Spec: http://www.w3.org/TR/FileAPI/#dfn-progress-event
One progress event will fire when blob has been completely read into memory.
Firefox, Opera and IE follows the spec.
Webkit based browser doesn't do that, it only fires progress event at interval of 50ms.
WebKit should add the behavior to make the conformance with the spec.

Source/WebCore:

Tests: fast/files/file-reader-event-listener.html

  • fileapi/FileReader.cpp:

(WebCore::FileReader::didFinishLoading):

LayoutTests:

  • fast/files/file-reader-event-listener-expected.txt:
  • fast/files/file-reader-event-listener.html:

May 26, 2012:

11:52 PM Changeset in webkit [118621] by ddkilzer@apple.com
  • 3 edits in trunk/Tools

Use xcrun to find path to nm for Mac port
<http://webkit.org/b/87588>

Reviewed by Dan Bernstein.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.nm_command): Add. Tries to find a path for the nm
command using xcrun. Falls back to returning 'nm'.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.nm_command): Add. Returns 'nm'.
(WebKitPort._webcore_symbols_string): Call self.nm_command().

6:51 PM Changeset in webkit [118620] by commit-queue@webkit.org
  • 9 edits in trunk

[FileAPI] The result attribute of FileReader shuold use null to replace empty string
https://bugs.webkit.org/show_bug.cgi?id=87578

Patch by Li Yin <li.yin@intel.com> on 2012-05-26
Reviewed by Kentaro Hara.

Source/WebCore:

From Spec: http://www.w3.org/TR/FileAPI/#filedata-attr
Before read method has been called or an error in reading has occurred,
the result attribute should be null, not empty string.

Currently, Firefox, Opera and IE 10 follows the spec, but Webkit based
browser don't.
WebKit should change the returned value empty string into null to keep
conformance with the spec.

Tests: fast/files/read-file-async.html

fast/files/blob-slice-test.html
fast/files/read-blob-async.html
fast/files/workers/worker-read-blob-async.html
fast/files/workers/worker-read-file-async.html

  • fileapi/FileReader.cpp:

(WebCore::FileReader::stringResult):

LayoutTests:

From Spec: http://www.w3.org/TR/FileAPI/#filedata-attr
Before read method has been called or an error in reading has occurred,
the result attribute should be null, not empty string.
WebKit should change the returned value empty string into null to keep
conformance with the spec.

  • fast/files/blob-slice-test-expected.txt:
  • fast/files/read-blob-async-expected.txt:
  • fast/files/read-file-async-expected.txt:
  • fast/files/resources/read-common.js:

(logResult):

  • fast/files/workers/worker-read-blob-async-expected.txt:
  • fast/files/workers/worker-read-file-async-expected.txt:
6:16 PM Changeset in webkit [118619] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build when NETSCAPE_PLUGIN_API is disabled by marking a
parameter as unused.

  • plugins/PluginData.cpp:

(WebCore::PluginData::initPlugins):

5:46 PM Changeset in webkit [118618] by Nate Chapin
  • 12 edits
    2 adds in trunk

Source/WebCore: Cancel CachedResource loads when the last client is removed.
https://bugs.webkit.org/show_bug.cgi?id=35377

Reviewed by Darin Adler.

Test: http/tests/cache/cancel-in-progress-load.html

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::errorLoadingResource):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::allClientsRemoved):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::allClientsRemoved):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::allClientsRemoved):

  • loader/cache/CachedRawResource.cpp:

(WebCore):

  • loader/cache/CachedRawResource.h:

(WebCore::CachedRawResource::shouldIgnoreHTTPStatusCodeErrors):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::allClientsRemoved):
(WebCore):

  • loader/cache/CachedResource.h:

(CachedResource):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::allClientsRemoved):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=35377.

Reviewed by Darin Adler.

  • http/tests/cache/cancel-in-progress-load-expected.txt: Added.
  • http/tests/cache/cancel-in-progress-load.html: Added.
  • http/tests/misc/write-while-waiting.html: Add waitUntilDone()/notifyDone().

The slow script will now be cancelled when the script element is removed from the document.
Without waitUntilDone(), LayoutTestController will immediately end the test upon cancellation
of the last resource.

5:43 PM Changeset in webkit [118617] by Simon Fraser
  • 5 edits
    2 adds in trunk

fast/block/inline-children-root-linebox-crash.html asserts after r118567
https://bugs.webkit.org/show_bug.cgi?id=87544

Source/WebCore:

Reviewed by Darin Adler.

RenderInline::offsetFromContainer() set offsetDependsOnPoint to true based
on the container's flipped writing mode. However, offsetFromContainer() would
then overwrite that, since it only checked for columns.

Fix by having RenderInline::offsetFromContainer() check for flipping on
the container. This fixes the assertion.

The new testcase exercises fixes another issue; unlike mapLocalToAbsolute(),
RenderGeometryMap::absoluteRect() didn't pass the rect center point through
the mapping, which resulted in a different result in some flipping cases.

Test: compositing/geometry/flipped-blocks-inline-mapping.html

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::absoluteRect):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::pushMappingToContainer):

LayoutTests:

Reviewed by Darin Adler.

Remove fast/block/inline-children-root-linebox-crash.html from the skipped
list.

New, more complex writing mode flipping test with compositing.

  • compositing/geometry/flipped-blocks-inline-mapping-expected.txt: Added.
  • compositing/geometry/flipped-blocks-inline-mapping.html: Added.
  • platform/mac/Skipped:
3:40 PM Changeset in webkit [118616] by ggaren@apple.com
  • 47 edits in trunk/Source

WebKit should be lazy-finalization-safe (esp. the DOM) v2
https://bugs.webkit.org/show_bug.cgi?id=87581

Reviewed by Oliver Hunt.

../JavaScriptCore:

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::callDestructor):

  • heap/WeakBlock.h:
  • heap/WeakSetInlines.h:

(JSC::WeakBlock::finalize): Since we don't guarantee destruction order,
it's not valid to access GC pointers like the Structure pointer during
finalization. We NULL out the structure pointer in debug builds to try
to make this programming mistake more obvious.

  • API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::destroy):

  • API/JSCallbackObject.cpp:

(JSC::::destroy):
(JSC::JSCallbackObjectData::finalize):

  • runtime/Arguments.cpp:

(JSC::Arguments::destroy):

  • runtime/DateInstance.cpp:

(JSC::DateInstance::destroy):

  • runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::destroy):

  • runtime/Executable.cpp:

(JSC::ExecutableBase::destroy):
(JSC::NativeExecutable::destroy):
(JSC::ScriptExecutable::destroy):
(JSC::EvalExecutable::destroy):
(JSC::ProgramExecutable::destroy):
(JSC::FunctionExecutable::destroy):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::destroy):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::destroy):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::destroy):

  • runtime/JSString.cpp:

(JSC::JSString::destroy):

  • runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::destroy):

  • runtime/NameInstance.cpp:

(JSC::NameInstance::destroy):

  • runtime/RegExp.cpp:

(JSC::RegExp::destroy):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::destroy):

  • runtime/Structure.cpp:

(JSC::Structure::destroy):

  • runtime/StructureChain.cpp:

(JSC::StructureChain::destroy): Use static_cast instead of jsCast because
jsCast does Structure-based validation, and our Structure is not guaranteed
to be alive when we get finalized.

../WebCore:

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::destroy):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::destroy):

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::destroy):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::finalize):

  • bindings/js/JSWorkerContextBase.cpp:

(WebCore::JSWorkerContextBase::destroy):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObject::destroy):
(WebCore::JSTestActiveDOMObjectOwner::finalize):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetter::destroy):
(WebCore::JSTestCustomNamedGetterOwner::finalize):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::destroy):
(WebCore::JSTestEventConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::destroy):
(WebCore::JSTestEventTargetOwner::finalize):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestException::destroy):
(WebCore::JSTestExceptionOwner::finalize):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::destroy):
(WebCore::JSTestInterfaceOwner::finalize):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::destroy):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::destroy):
(WebCore::JSTestNamedConstructorOwner::finalize):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::destroy):
(WebCore::JSTestObjOwner::finalize):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::destroy):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::destroy):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethod::destroy):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::QtRuntimeMethod::destroy):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::destroy):

  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::destroy):

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::destroy):

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::finalize): Use static_cast instead of jsCast because
jsCast does Structure-based validation, and our Structure is not guaranteed
to be alive when we get finalized.

../WebKit2:

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::destroy):
(WebKit::JSNPObject::leakNPObject):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::finalize): Use static_cast instead of jsCast because
jsCast does Structure-based validation, and our Structure is not guaranteed
to be alive when we get finalized.

3:08 PM Changeset in webkit [118615] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r116720): Subframe PDF scrolls extremely slowly
https://bugs.webkit.org/show_bug.cgi?id=87557
<rdar://problem/11499408>

Reviewed by Anders Carlsson.

It's not possible to make an automated test for this.

  • WebProcess/Plugins/PDF/BuiltInPDFView.mm:

(WebKit::BuiltInPDFView::wantsWheelEvents): Return true instead of false and delete
misleading comment. While the built-in PDF view would get added to the set of scrollable
areas anyway, there are some code paths that check wantsWheelEvents explicitly, so it seems
necessary to reutrn true.

2:25 PM Changeset in webkit [118614] by Dave Barton
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Move myself to committers.

1:35 PM Changeset in webkit [118613] by Dave Barton
  • 2 edits in trunk/LayoutTests

My first commit - set svn:mime-type to image/png on one .png file.

  • platform/mac/mathml/presentation/mroot-pref-width-expected.png:
1:15 PM Changeset in webkit [118612] by Simon Fraser
  • 3 edits
    2 adds in trunk

Clip rects assertion when hovering div with transform
https://bugs.webkit.org/show_bug.cgi?id=87580

Source/WebCore:

Reviewed by Eric Seidel.

Hit testing used to use temporary clip rects in composited documents,
until r118562. Now that we cache clip rects for hit testing, we need
to clear the cache on descendant layers when a layer gains or loses
a transform.

Test: fast/layers/clip-rects-assertion.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateTransform):

LayoutTests:

Reviewed by Eric Seidel.

Test that changes transform on hover style, testing for clipRect-related
assertions.

  • fast/layers/clip-rects-assertion-expected.txt: Added.
  • fast/layers/clip-rects-assertion.html: Added.
10:32 AM WebKit Team edited by noam.rosenthal@nokia.com
(diff)
10:14 AM Changeset in webkit [118611] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/11439771> WebProcess sends many synchronous messages to the UI process while scrolling beneath ScrollView::contentsToScreen()
https://bugs.webkit.org/show_bug.cgi?id=87571

Reviewed by Anders Carlsson.

fakeMouseEventTimerFired() uses the last known mouse position for the fake mouse event, but
calls contentsToScreen() to compute a corresponding position in screen coordinates. Avoid
this by also recording the last known mouse position in screen coordinates, and using that
value.

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear): Added resetting m_currentMouseGlobalPosition.
(WebCore::EventHandler::handleMousePressEvent): Added updating m_currentMouseGlobalPosition
when updating m_currentMousePosition.
(WebCore::EventHandler::handleMouseDoubleClickEvent): Ditto.
(WebCore::EventHandler::handleMouseMoveEvent): Ditto.
(WebCore::EventHandler::handleMouseReleaseEvent): Ditto.
(WebCore::EventHandler::fakeMouseMoveEventTimerFired): Changed to use m_currentMouseGlobalPosition
in the fake event instead of calling contentsToScreen().

  • page/EventHandler.h: Added m_currentMouseGlobalPosition data member.
8:34 AM Changeset in webkit [118610] by Philippe Normand
  • 2 edits
    1 delete in trunk/Source/WebCore

[GStreamer] Remove ImageGStreamerCG implementation
https://bugs.webkit.org/show_bug.cgi?id=87559

The ImageGStreamerCG abstraction is being removed until I manage to
port my gst-mac WebKit branch over to the WebKit2 mac port. No
need to update the XCode project because this file is not
referenced there anyway.

Reviewed by Martin Robinson.

  • platform/graphics/gstreamer/ImageGStreamer.h:

(ImageGStreamer):

  • platform/graphics/gstreamer/ImageGStreamerCG.mm: Removed.
4:38 AM Changeset in webkit [118609] by rwlbuis@webkit.org
  • 4 edits
    54 adds in trunk

Bug 15799: textPath element does not re-render when referenced path changes
https://bugs.webkit.org/show_bug.cgi?id=15799

Patch by Rob Buis <rwlbuis@webkit.org> on 2012-05-26
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Support textPath updating to changes on the referenced path. To make this possible
use the target reference functionality also used by SVGFEImageElement.

Tests: svg/custom/textPath-change-id-expected.svg

svg/custom/textPath-change-id-pattern-expected.svg
svg/custom/textPath-change-id-pattern.svg
svg/custom/textPath-change-id.svg
svg/custom/textPath-change-id2-expected.svg
svg/custom/textPath-change-id2-pattern-expected.svg
svg/custom/textPath-change-id2-pattern.svg
svg/custom/textPath-change-id2.svg
svg/custom/textPath-change-reference-expected.svg
svg/custom/textPath-change-reference-pattern-expected.svg
svg/custom/textPath-change-reference-pattern.svg
svg/custom/textPath-change-reference-using-baseval-expected.svg
svg/custom/textPath-change-reference-using-baseval-pattern-expected.svg
svg/custom/textPath-change-reference-using-baseval-pattern.svg
svg/custom/textPath-change-reference-using-baseval.svg
svg/custom/textPath-change-reference.svg
svg/custom/textPath-change-reference2-expected.svg
svg/custom/textPath-change-reference2-pattern-expected.svg
svg/custom/textPath-change-reference2-pattern.svg
svg/custom/textPath-change-reference2-using-baseval-expected.svg
svg/custom/textPath-change-reference2-using-baseval-pattern-expected.svg
svg/custom/textPath-change-reference2-using-baseval-pattern.svg
svg/custom/textPath-change-reference2-using-baseval.svg
svg/custom/textPath-change-reference2.svg
svg/custom/textPath-insert-path-expected.svg
svg/custom/textPath-insert-path-pattern-expected.svg
svg/custom/textPath-insert-path-pattern.svg
svg/custom/textPath-insert-path.svg
svg/custom/textPath-modify-child-expected.svg
svg/custom/textPath-modify-child-pattern-expected.svg
svg/custom/textPath-modify-child-pattern.svg
svg/custom/textPath-modify-child.svg
svg/custom/textPath-path-change-expected.svg
svg/custom/textPath-path-change-pattern-expected.svg
svg/custom/textPath-path-change-pattern.svg
svg/custom/textPath-path-change-using-svg-dom-expected.svg
svg/custom/textPath-path-change-using-svg-dom-pattern-expected.svg
svg/custom/textPath-path-change-using-svg-dom-pattern.svg
svg/custom/textPath-path-change-using-svg-dom.svg
svg/custom/textPath-path-change.svg
svg/custom/textPath-path-change2-expected.svg
svg/custom/textPath-path-change2-pattern-expected.svg
svg/custom/textPath-path-change2-pattern.svg
svg/custom/textPath-path-change2.svg
svg/custom/textPath-remove-path-expected.svg
svg/custom/textPath-remove-path-pattern-expected.svg
svg/custom/textPath-remove-path-pattern.svg
svg/custom/textPath-remove-path.svg
svg/custom/textPath-set-id-expected.svg
svg/custom/textPath-set-id.svg
svg/custom/textPath-startoffset-expected.svg
svg/custom/textPath-startoffset-pattern-expected.svg
svg/custom/textPath-startoffset-pattern.svg
svg/custom/textPath-startoffset.svg

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::~SVGTextPathElement):
(WebCore):
(WebCore::SVGTextPathElement::clearResourceReferences):
(WebCore::SVGTextPathElement::svgAttributeChanged):
(WebCore::SVGTextPathElement::buildPendingResource):
(WebCore::SVGTextPathElement::insertedInto):
(WebCore::SVGTextPathElement::removedFrom):

  • svg/SVGTextPathElement.h:

LayoutTests:

  • textPath-path-change-id.svg, react to change of id attribute on referenced path (makes the xlink:href valid).
  • textPath-path-change-id2.svg, react to change of id attribute on referenced path (makes the xlink:href invalid).
  • textPath-path-set-id.svg, react to setting of id attribute on referenced path (makes the xlink:href valid).
  • textPath-change-reference.svg, <textPath> references existing <path>, change the xlink:href to a non-existing one.
  • textPath-change-reference-using-baseval.svg, <textPath> references existing <path>, change the xlink:href to a non-existing one using SVG DOM.
  • textPath-change-reference2.svg, <textPath> references non-existing <path>, change xlink:href to an existing one.
  • textPath-change-reference2-using-baseval.svg, <textPath> references non-existing <path>, change xlink:href to an existing one using SVG DOM.
  • textPath-insert-path.svg, <textPath> references non-existing <path>, <path> added dynamically.
  • textPath-modify-child.svg, react to change on textPath content.
  • textPath-path-change-using-svg-dom.svg, react to change on pathSegList of referenced path.
  • textPath-path-change.svg, react to change on d attribute of referenced path.
  • textPath-path-change2.svg, react to change on d attribute of path referenced by multiple <textPath>s.
  • textPath-remove-path.svg, <textPath> references existing <path>, <path> is removed from DOM.
  • textPath-startoffset.svg, react to startOffset attribute change on <textPath>.

These tests are duplicated for <textPath> inside a <pattern>.

  • svg/custom/textPath-change-id-expected.svg: Added.
  • svg/custom/textPath-change-id-pattern-expected.svg: Added.
  • svg/custom/textPath-change-id-pattern.svg: Added.
  • svg/custom/textPath-change-id.svg: Added.
  • svg/custom/textPath-change-id2-expected.svg: Added.
  • svg/custom/textPath-change-id2-pattern-expected.svg: Added.
  • svg/custom/textPath-change-id2-pattern.svg: Added.
  • svg/custom/textPath-change-id2.svg: Added.
  • svg/custom/textPath-change-reference-expected.svg: Added.
  • svg/custom/textPath-change-reference-pattern-expected.svg: Added.
  • svg/custom/textPath-change-reference-pattern.svg: Added.
  • svg/custom/textPath-change-reference-using-baseval-expected.svg: Added.
  • svg/custom/textPath-change-reference-using-baseval-pattern-expected.svg: Added.
  • svg/custom/textPath-change-reference-using-baseval-pattern.svg: Added.
  • svg/custom/textPath-change-reference-using-baseval.svg: Added.
  • svg/custom/textPath-change-reference.svg: Added.
  • svg/custom/textPath-change-reference2-expected.svg: Added.
  • svg/custom/textPath-change-reference2-pattern-expected.svg: Added.
  • svg/custom/textPath-change-reference2-pattern.svg: Added.
  • svg/custom/textPath-change-reference2-using-baseval-expected.svg: Added.
  • svg/custom/textPath-change-reference2-using-baseval-pattern-expected.svg: Added.
  • svg/custom/textPath-change-reference2-using-baseval-pattern.svg: Added.
  • svg/custom/textPath-change-reference2-using-baseval.svg: Added.
  • svg/custom/textPath-change-reference2.svg: Added.
  • svg/custom/textPath-insert-path-expected.svg: Added.
  • svg/custom/textPath-insert-path-pattern-expected.svg: Added.
  • svg/custom/textPath-insert-path-pattern.svg: Added.
  • svg/custom/textPath-insert-path.svg: Added.
  • svg/custom/textPath-modify-child-expected.svg: Added.
  • svg/custom/textPath-modify-child-pattern-expected.svg: Added.
  • svg/custom/textPath-modify-child-pattern.svg: Added.
  • svg/custom/textPath-modify-child.svg: Added.
  • svg/custom/textPath-path-change-expected.svg: Added.
  • svg/custom/textPath-path-change-pattern-expected.svg: Added.
  • svg/custom/textPath-path-change-pattern.svg: Added.
  • svg/custom/textPath-path-change-using-svg-dom-expected.svg: Added.
  • svg/custom/textPath-path-change-using-svg-dom-pattern-expected.svg: Added.
  • svg/custom/textPath-path-change-using-svg-dom-pattern.svg: Added.
  • svg/custom/textPath-path-change-using-svg-dom.svg: Added.
  • svg/custom/textPath-path-change.svg: Added.
  • svg/custom/textPath-path-change2-expected.svg: Added.
  • svg/custom/textPath-path-change2-pattern-expected.svg: Added.
  • svg/custom/textPath-path-change2-pattern.svg: Added.
  • svg/custom/textPath-path-change2.svg: Added.
  • svg/custom/textPath-remove-path-expected.svg: Added.
  • svg/custom/textPath-remove-path-pattern-expected.svg: Added.
  • svg/custom/textPath-remove-path-pattern.svg: Added.
  • svg/custom/textPath-remove-path.svg: Added.
  • svg/custom/textPath-set-id-expected.svg: Added.
  • svg/custom/textPath-set-id.svg: Added.
  • svg/custom/textPath-startoffset-expected.svg: Added.
  • svg/custom/textPath-startoffset-pattern-expected.svg: Added.
  • svg/custom/textPath-startoffset-pattern.svg: Added.
  • svg/custom/textPath-startoffset.svg: Added.
2:08 AM Changeset in webkit [118608] by Nikolas Zimmermann
  • 17 edits in trunk/Source/WebCore

Avoid updateFromElement() usage in SVG
https://bugs.webkit.org/show_bug.cgi?id=87573

Stop relying on updateFromElement() - instead rely on addChild/removeChild, which
allows us to optimize the resources re-fetching. When a child is added to the tree
we don't need to remove existing resources from the SVGResourcesCache - the renderer
can't be in the cache yet. Similary, remove the entry from the cache earlier: as soon
as the renderer is removed from the tree, instead of waiting for willBeDestroyed().

No new tests, refactoring only.

  • rendering/svg/RenderSVGBlock.cpp:
  • rendering/svg/RenderSVGBlock.h:

(RenderSVGBlock):

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::addChild):
(WebCore):
(WebCore::RenderSVGContainer::removeChild):

  • rendering/svg/RenderSVGContainer.h:

(RenderSVGContainer):

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::addChild):
(WebCore::RenderSVGInline::removeChild):

  • rendering/svg/RenderSVGInline.h:

(RenderSVGInline):

  • rendering/svg/RenderSVGModelObject.cpp:
  • rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::registerResource):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::addChild):
(WebCore):
(WebCore::RenderSVGRoot::removeChild):

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::addChild):
(WebCore::RenderSVGText::removeChild):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientStyleChanged):
(WebCore::rendererCanHaveResources):
(WebCore):
(WebCore::SVGResourcesCache::clientWasAddedToTree):
(WebCore::SVGResourcesCache::clientWillBeRemovedFromTree):

  • rendering/svg/SVGResourcesCache.h:

(SVGResourcesCache):

  • svg/SVGStyledElement.cpp:
  • svg/SVGStyledElement.h:

(SVGStyledElement):

12:16 AM Changeset in webkit [118607] by zandobersek@gmail.com
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening after r118577 and r118585.

  • platform/gtk/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.
  • platform/gtk/test_expectations.txt:

May 25, 2012:

11:39 PM Changeset in webkit [118606] by nduca@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Instrument V8 GC with TraceEvent
https://bugs.webkit.org/show_bug.cgi?id=87530

Reviewed by Kentaro Hara.

We sometimes get performance issues where performance stalls can
be attributed to badly timed GC operations, especially ones that
happen just before a frame running. This adds tracing calls around
GC so that we can better understand these kinds of hangs.

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::gcEpilogue):

11:09 PM Changeset in webkit [118605] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll chromium DEPS from r139156 to r139184.

  • DEPS:
8:20 PM Changeset in webkit [118604] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

cursor gets trapped when border-style: dashed is used
https://bugs.webkit.org/show_bug.cgi?id=37693

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-05-25
Reviewed by Tony Chang.

This bug has been fixed. Add a test to make sure that it won't regress.

  • editing/selection/move-by-line-006-expected.txt: Added.
  • editing/selection/move-by-line-006.html: Added.
8:09 PM Changeset in webkit [118603] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

weakCompareAndSwap should work on Windows
https://bugs.webkit.org/show_bug.cgi?id=87549

Reviewed by Jessie Berlin.

  • wtf/Atomics.h:

(WTF):
(WTF::weakCompareAndSwap):

7:24 PM Changeset in webkit [118602] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

Unreviewed, fix bad copy/paste.

  • platform/mac/Skipped:
7:20 PM Changeset in webkit [118601] by commit-queue@webkit.org
  • 11 edits
    1 copy in trunk/Source

Allow WebTextFieldDecoratorClient to see applied decorations.
https://bugs.webkit.org/show_bug.cgi?id=86557

Patch by Garrett Casto <gcasto@chromium.org> on 2012-05-25
Reviewed by Kent Tamura.

Source/WebCore:

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::fromShadowRoot): A function
that will extract a TextFielDecorationElement from a ShadowRoot, if
there is one.

  • html/shadow/TextFieldDecorationElement.h:

(WebCore):
(TextFieldDecorator):

Source/WebKit/chromium:

  • WebKit.gyp: Added new files.
  • public/WebInputElement.h:

(WebKit::WebInputElement::decorationElementFor): Returns the
WebElement attached to the WebInputElement by the given
WebTextFieldDecoratorClient, if one exists.

  • src/TextFieldDecoratorImpl.cpp:

(WebKit):

  • src/TextFieldDecoratorImpl.h:

(TextFieldDecoratorImpl::decoratorClient): Get the
WebTextFieldDecoratorClient owned by this object.

7:07 PM Changeset in webkit [118600] by tony@chromium.org
  • 6 edits in trunk

implement new negative flexing algorithm
https://bugs.webkit.org/show_bug.cgi?id=86528

Reviewed by Ojan Vafai.

Source/WebCore:

Rather than just scale by the negative flexibility, we also take the
flex-basis (preferred size) into consideration. That means items with
a larger preferred size will shrink faster.

Test: css3/flexbox/flex-algorithm.html (new test cases added)

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): Handle overflow.
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeNextFlexLine): Sum weighted negative flex.
(WebCore::RenderFlexibleBox::freezeViolations):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths): Shrink by weighted amount.
Also handle large values by making sure the flex values are finite.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

  • css3/flexbox/flex-algorithm-expected.txt:
  • css3/flexbox/flex-algorithm.html:
7:05 PM Changeset in webkit [118599] by mihaip@chromium.org
  • 12 edits
    2 adds in trunk

Allow synchronous XHRs to be disabled in documents
https://bugs.webkit.org/show_bug.cgi?id=87540

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/xmlhttprequest/xmlhttprequest-sync-disabled.html

Synchronous XMLHttpRequests are a problematic API, since they result
in blocked UI threads. Some clients may wish to always disable them;
give them a setting to do so (see also r103629 for other cases where
synchronous XHRs are disabled).

  • page/Settings.cpp:

(WebCore):
(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):
(WebCore::Settings::setSyncXHRInDocumentsEnabled):
(WebCore::Settings::syncXHRInDocumentsEnabled):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setSyncXHRInDocumentsEnabled):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):

Source/WebKit/chromium:

Synchronous XMLHttpRequests are a problematic API, since they result
in blocked UI threads. Some clients may wish to always disable them;
give them a setting to do so (see also r103629 for other cases where
synchronous XHRs are disabled).

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setSyncXHRInDocumentsEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

LayoutTests:

Synchronous XMLHttpRequests are a problematic API, since they result
in blocked UI threads. Some clients may wish to always disable them;
give them a setting to do so (see also r103629 for other cases where
synchronous XHRs are disabled).

  • fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-sync-disabled.html: Added.
6:53 PM Changeset in webkit [118598] by Stephanie Lewis
  • 1 edit
    3 adds in trunk/LayoutTests

See https://bugs.webkit.org/show_bug.cgi?id=87558

Unreviewed, checking in expected failing results.

  • platform/mac/http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
  • platform/mac/http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.
6:43 PM Changeset in webkit [118597] by kinuko@chromium.org
  • 7 edits in trunk/Source

[chromium] Deprecate FileUtilities::getFileSize and getFileModifiedTime in favor of getFileMetadata
https://bugs.webkit.org/show_bug.cgi?id=87492

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebFileUtilities.h:

Source/WebCore:

No new tests: existing tests (http/tests/local/fileapi/* and fast/files/*) should pass.

  • platform/chromium/FileSystemChromium.cpp:

(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::getFileMetadata):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::getFileMetadata):

6:25 PM Changeset in webkit [118596] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r139024 to r139156 in an attempt to fix Chromium Win builds.

  • DEPS:
6:21 PM Changeset in webkit [118595] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

See https://bugs.webkit.org/show_bug.cgi?id=87544

Unreviewed, skipping asserting test

  • platform/mac/Skipped:
6:02 PM Changeset in webkit [118594] by commit-queue@webkit.org
  • 12 edits
    7 adds
    2 deletes in trunk

Source/WebKit/win: Added methods needed to implement backend for DRT's TextInputController on windows, https://bugs.webkit.org/show_bug.cgi?id=32021

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-05-25
Reviewed by Eric Seidel.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(WebView::setCompositionForTesting):
(WebView::hasCompositionForTesting):
(WebView::confirmCompositionForTesting):
(WebView::compositionRangeForTesting):
(WebView::firstRectForCharacterRangeForTesting):
(WebView::selectedRangeForTesting):

  • WebView.h:

(WebView):

Tools: Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-05-25
Reviewed by Eric Seidel.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::FrameLoadDelegate):
(FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):

  • DumpRenderTree/win/FrameLoadDelegate.h:

(FrameLoadDelegate):

  • DumpRenderTree/win/TextInputController.cpp: Added.

(setMarkedTextCallback):
(hasMarkedTextCallback):
(unmarkTextCallback):
(markedRangeCallback):
(insertTextCallback):
(firstRectForCharacterRangeCallback):
(selectedRangeCallback):
(TextInputController::makeWindowObject):
(TextInputController::getJSClass):
(TextInputController::staticValues):
(TextInputController::staticFunctions):

  • DumpRenderTree/win/TextInputController.h: Added.

(TextInputController):

  • DumpRenderTree/win/TextInputControllerWin.cpp: Added.

(TextInputController::setMarkedText):
(TextInputController::hasMarkedText):
(TextInputController::unmarkText):
(TextInputController::markedRange):
(TextInputController::insertText):
(TextInputController::firstRectForCharacterRange):
(TextInputController::selectedRange):

LayoutTests: Updated tests as a result of implementing TextInputController in DRT for windows, https://bugs.webkit.org/show_bug.cgi?id=32021

Patch by Lynn Neir <lynn.neir@skype.net> on 2012-05-25
Reviewed by Eric Seidel.

  • platform/win/Skipped:
  • platform/win/editing/selection/5825350-1-expected.txt: Added.
  • platform/win/editing/selection/5825350-2-expected.txt: Added.
  • platform/win/editing/selection/mixed-editability-10-expected.txt:
  • platform/win/editing/selection/move-left-right-expected.txt: Added.
  • platform/win/fast/events/ime-composition-events-001-expected.txt:
  • platform/win/fast/forms/input-maxlength-ime-completed-expected.txt: Removed.
  • platform/win/fast/forms/input-maxlength-ime-preedit-expected.txt: Removed.
  • platform/win/svg/text/caret-in-svg-text-expected.txt: Added.
5:35 PM Changeset in webkit [118593] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Enhance Windows DRT implementation to support platform scroll wheel events.
https://bugs.webkit.org/show_bug.cgi?id=36002

Add another test that uses continuousMouseScrollBy to the Windows Skipped list.

  • platform/win/Skipped:
5:28 PM Changeset in webkit [118592] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

Crash in RenderTableSection::paintCell.
https://bugs.webkit.org/show_bug.cgi?id=87445

Reviewed by Eric Seidel and Julien Chaffraix.

Source/WebCore:

Fix the crash by preventing table parts from being set
as layout root. This prevents us from accessing removed
table cells which can happen if RenderTableSection::layout
is called directly without calling RenderTable::layout first
(in case of cell recalc).

Add ASSERTs to RenderTableSection::layout to prevent
layout to happen when we are already pending cell recalc
or our table is pending section recalc. In those cases,
RenderTable::layout should be called first to relayout
the entire table.

Test: tables/table-section-overflow-clip-crash.html

  • rendering/RenderObject.cpp:

(WebCore::objectIsRelayoutBoundary):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layout):

LayoutTests:

  • tables/table-section-overflow-clip-crash-expected.txt: Added.
  • tables/table-section-overflow-clip-crash.html: Added.
5:23 PM Changeset in webkit [118591] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Implement spinbutton support in RenderThemeSafari
https://bugs.webkit.org/show_bug.cgi?id=54662

Add more spinbutton tests to the Windows Skipped list.

  • platform/win/Skipped:
5:22 PM Changeset in webkit [118590] by pilgrim@chromium.org
  • 12 edits
    5 copies in trunk/Source

[Chomium] Move sandboxSupport to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=87518

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::sandboxSupport):

  • chromium/public/android/WebSandboxSupport.h: Added.

(WebKit):
(WebSandboxSupport):

  • chromium/public/linux/WebFontFamily.h: Added.

(WebKit):
(WebFontFamily):

  • chromium/public/linux/WebSandboxSupport.h: Added.

(WebKit):
(WebSandboxSupport):

  • chromium/public/mac/WebSandboxSupport.h: Added.

(WebKit):
(WebSandboxSupport):

  • chromium/public/win/WebSandboxSupport.h: Added.

(WebKit):
(WebSandboxSupport):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

  • public/platform/android/WebSandboxSupport.h:
  • public/platform/linux/WebFontFamily.h:
  • public/platform/linux/WebSandboxSupport.h:
  • public/platform/mac/WebSandboxSupport.h:
  • public/platform/win/WebSandboxSupport.h:
  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::ensureFontLoaded):
(WebCore::PlatformSupport::loadFont):
(WebCore::PlatformSupport::getFontFamilyForCharacters):
(WebCore::PlatformSupport::getRenderStyleForStrike):

5:18 PM Changeset in webkit [118589] by pdr@google.com
  • 4 edits
    2 adds in trunk

Fix for self-closing <use> tags
https://bugs.webkit.org/show_bug.cgi?id=87504

Reviewed by Adam Barth.

Source/WebCore:

This change causes self-closing non-html tags to behave the same
as tags immediately followed by the closing tag.

Test: svg/custom/svg-self-closing-use.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertForeignElement):

  • html/parser/HTMLConstructionSite.h:

(HTMLConstructionSite):

LayoutTests:

  • svg/custom/svg-self-closing-use-expected.html: Added.
  • svg/custom/svg-self-closing-use.html: Added.
4:59 PM Changeset in webkit [118588] by jberlin@webkit.org
  • 1 edit
    15 adds in trunk/LayoutTests

[Win] ~1/2 of all the iframe seamless tests fail
https://bugs.webkit.org/show_bug.cgi?id=87543

Add failing expected results for Windows in order to get the bots green.

  • platform/win/fast/frames: Added.
  • platform/win/fast/frames/seamless: Added.
  • platform/win/fast/frames/seamless/seamless-basic-expected.txt: Added.
  • platform/win/fast/frames/seamless/seamless-css-cascade-expected.txt: Added.
  • platform/win/fast/frames/seamless/seamless-form-get-expected.txt: Added.
  • platform/win/fast/frames/seamless/seamless-form-get-named-expected.txt: Added.
  • platform/win/fast/frames/seamless/seamless-form-post-expected.txt: Added.
  • platform/win/fast/frames/seamless/seamless-form-post-named-expected.txt: Added.
  • platform/win/fast/frames/seamless/seamless-hyperlink-expected.txt: Added.
  • platform/win/fast/frames/seamless/seamless-hyperlink-named-expected.txt: Added.
  • platform/win/fast/frames/seamless/seamless-inherited-document-style-expected.txt: Added.
  • platform/win/fast/frames/seamless/seamless-window-location-expected.txt: Added.
  • platform/win/fast/frames/seamless/seamless-window-location-href-expected.txt: Added.
  • platform/win/fast/frames/seamless/seamless-window-location-sandbox-expected.txt: Added.
  • platform/win/fast/frames/seamless/seamless-window-open-expected.txt: Added.
4:46 PM Changeset in webkit [118587] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Make the ICU-based implementation of NonSharedCharacterBreakIterator work in configurations
that do not have COMPARE_AND_SWAP enabled.

Reviewed by Jessie Berlin.

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::compareAndSwapNonSharedCharacterBreakIterator): Added this helper. It uses
weakCompareAndSwap when COMPARE_AND_SWAP is enabled, and uses a mutex to do the atomic
compare and swap otherwise.
(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Changed to use
compareAndSwapNonSharedCharacterBreakIterator().
(WebCore::NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator): Ditto.

4:31 PM Changeset in webkit [118586] by tommyw@google.com
  • 7 edits in trunk

MediaStream API: Make sure IceCallback is valid for PeerConnection00
https://bugs.webkit.org/show_bug.cgi?id=87480

Reviewed by Adam Barth.

Source/WebCore:

Existing tests have been extended to cover this change.

  • Modules/mediastream/PeerConnection00.cpp:

(WebCore::PeerConnection00::create):

  • Modules/mediastream/PeerConnection00.h:
  • Modules/mediastream/PeerConnection00.idl:

LayoutTests:

  • fast/mediastream/constructors-expected.txt:
  • fast/mediastream/constructors.html:
4:29 PM Changeset in webkit [118585] by commit-queue@webkit.org
  • 28 edits
    1 copy
    9 adds in trunk

Inline script and style blocked by Content Security Policy should provide more detailed console errors.
https://bugs.webkit.org/show_bug.cgi?id=86848

Patch by Mike West <mkwst@chromium.org> on 2012-05-25
Reviewed by Adam Barth.

Source/WebCore:

This change adds a URL and line number for context to each call to
ContentSecurityPolicy::allowInline*, and pipes it through to the
console message generation in CSPDirectiveList::reportViolation.

Line numbers are not added for injected scripts (document.write(...),
document.body.appendChild, and etc.).

Tests: http/tests/security/contentSecurityPolicy/injected-inline-script-allowed.html

http/tests/security/contentSecurityPolicy/injected-inline-script-blocked.html
http/tests/security/contentSecurityPolicy/injected-inline-style-allowed.html
http/tests/security/contentSecurityPolicy/injected-inline-style-blocked.html

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::executeScript):

  • dom/ScriptElement.h:

(ScriptElement):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::StyleElement):
(WebCore::StyleElement::createSheet):

  • dom/StyleElement.h:

(StyleElement):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::StyledElement):
(WebCore):
(WebCore::StyledElement::style):
(WebCore::StyledElement::styleAttributeChanged):

  • dom/StyledElement.h:

(StyledElement):

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):
(WebCore):
(WebCore::isAllowedByAllWithCallStack):
(WebCore::isAllowedByAllWithContext):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowInlineStyle):

  • page/ContentSecurityPolicy.h:

(WTF):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/combine-multiple-policies-expected.txt:
  • http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/injected-inline-script-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/injected-inline-script-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/injected-inline-script-blocked-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt.
  • http/tests/security/contentSecurityPolicy/injected-inline-script-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/injected-inline-style-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/injected-inline-style-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/injected-inline-style-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/injected-inline-style-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
  • http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
  • http/tests/security/contentSecurityPolicy/resources/inject-script.js: Added.
  • http/tests/security/contentSecurityPolicy/resources/inject-style.js: Added.
  • http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
  • http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src-expected.txt:
4:26 PM Changeset in webkit [118584] by jsbell@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Chromium] Add missing expectations needed after http://trac.webkit.org/changeset/118577/

Unreviewed gardening.

  • platform/chromium-mac-leopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
4:01 PM Changeset in webkit [118583] by timothy_horton@apple.com
  • 15 edits in trunk/Source/WebCore

ENABLE_CSS3_FLEXBOX is insufficient to disable all web-facing bits of the feature
https://bugs.webkit.org/show_bug.cgi?id=87537
<rdar://problem/11524921>

Reviewed by Simon Fraser.

Allow the feature flag to disable more web-facing parts of the CSS3 flexbox
implementation (primarily fallout from hiding it from computed style).

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::asText):

  • css/StylePropertyShorthand.cpp:

(WebCore::shorthandForProperty):

  • css/StylePropertyShorthand.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimation::ensurePropertyMap):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/style/RenderStyleConstants.h:
4:00 PM Changeset in webkit [118582] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG CSE should eliminate redundant WeakJSConstants
https://bugs.webkit.org/show_bug.cgi?id=87179

Reviewed by Gavin Barraclough.

Merged r118141 from dfgopt.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::weakConstantCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGNode.h:

(JSC::DFG::Node::weakConstant):

3:57 PM Changeset in webkit [118581] by kbr@google.com
  • 2 edits in trunk/LayoutTests

New tex-image-and-sub-image-2d-with-video tests from r118565 failing on Mac Lion
https://bugs.webkit.org/show_bug.cgi?id=87541

Unreviewed; skipping tests until bug can be investigated.

  • platform/mac/Skipped:
3:49 PM Changeset in webkit [118580] by enne@google.com
  • 5 edits in trunk/Source/WebCore

[chromium] Add setting for painting debug info onto tiles
https://bugs.webkit.org/show_bug.cgi?id=75763

Reviewed by James Robinson.

Add a compile-time CCSetting to paint debug information onto tiles. This
can help to understand paint counts and layer indices. This setting is
off by default.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerChromium::createTextureUpdater):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::UpdatableTile):
(WebCore::UpdatableTile::setUpdateFrame):
(WebCore::UpdatableTile::incrementPaintCount):
(WebCore::UpdatableTile::updateFrame):
(WebCore::UpdatableTile::paintCount):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::paintDebugTileInfo):

  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

3:45 PM Changeset in webkit [118579] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

DFG CSE should do redundant store elimination
https://bugs.webkit.org/show_bug.cgi?id=87161

Reviewed by Oliver Hunt.

Merge r118138 from dfgopt.

This patch adds redundant store elimination. For example, consider this
code:

o.x = 42;
o.x = 84;

If o.x is speculated to be a well-behaved field, the first assignment is
unnecessary, since the second just overwrites it. We would like to
eliminate the first assignment in these cases. The need for this
optimization arises mostly from stores that our runtime requires. For
example:

o = {f:1, g:2, h:3};

This will have four assignments to the structure for the newly created
object - one assignment for the empty structure, one for {f}, one for
{f, g}, and one for {f, g, h}. We would like to only have the last of
those assigments in this case.

Intriguingly, doing so for captured variables breaks the way arguments
simplification used to work. Consider that prior to either arguments
simplification or store elimination we will have IR that looks like:

a: SetLocal(r0, Empty)
b: SetLocal(r1, Empty)
c: GetLocal(r0)
d: CreateArguments(@c)
e: SetLocal(r0, @d)
f: SetLocal(r1, @d)

Then redundant store elimination will eliminate the stores that
initialize the arguments registers to Empty, but then arguments
simplification eliminates the stores that initialize the arguments to
the newly created arguments - and at this point we no longer have any
stores to the arguments register, leading to hilarious crashes. This
patch therefore changes arguments simplification to replace
CreateArguments with JSConstant(Empty) rather than eliminating the
SetLocals. But this revealed bugs where arguments simplification was
being overzealous, so I fixed those bugs.

This is a minor speed-up on V8/early and a handful of other tests.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::uncheckedActivationRegister):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUses):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::globalVarStoreElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::uncheckedActivationRegisterFor):
(Graph):

  • dfg/DFGNode.h:

(JSC::DFG::Node::isPhantomArguments):
(Node):
(JSC::DFG::Node::hasConstant):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::hasStructureTransitionData):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:36 PM Changeset in webkit [118578] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Remove a bunch of flaky expectations for tests that now pass.

Unreviewed test expectations update.

Also marked some nearby tests as more definitely failing.

  • platform/chromium/test_expectations.txt:
3:30 PM Changeset in webkit [118577] by fischman@chromium.org
  • 2 edits
    3 adds in trunk

[chromium] Default media controls should render only the currentTime-containing buffered range
https://bugs.webkit.org/show_bug.cgi?id=85925

Reviewed by Eric Carlson.

Test: http/tests/media/video-buffered-range-contains-currentTime.html

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaSlider):

3:24 PM Changeset in webkit [118576] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

compositing/overflow/overflow-positioning.html fails with timeout on multiple chromium bots
https://bugs.webkit.org/show_bug.cgi?id=85771

Unreviewed test expectations update.

These tests haven't timed out lately on the Chromium bots, so removing
the suppressions.

  • platform/chromium/test_expectations.txt:
3:22 PM Changeset in webkit [118575] by annacc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Removing tests from test_expectations.txt that are no longer crashing.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
3:19 PM Changeset in webkit [118574] by annacc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Removing media/video-volume-slider.html from test_expectations.txt

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
3:14 PM Changeset in webkit [118573] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Mark some "flaky" TypedArray tests more appropriately as DEBUG SLOW

Unreviewed test expectations update.

  • platform/chromium/test_expectations.txt:
3:10 PM Changeset in webkit [118572] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Build fix: add TransformationMatrix ctor from an AffineTransform.

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::TransformationMatrix):
(WebCore):

  • platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

3:07 PM Changeset in webkit [118571] by adamk@chromium.org
  • 2 edits
    1 move
    10 deletes in trunk/LayoutTests

Rebaseline Chromium expectations for fast/box-shadow/shadow-buffer-partial.html

Unreviewed rebaselining.

The same rebaseline was made in r112582, but only got the Linux expectations.

  • fast/box-shadow/shadow-buffer-partial-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt.
  • platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
  • platform/mac/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
3:02 PM Changeset in webkit [118570] by rniwa@webkit.org
  • 12 edits
    2 adds in trunk

createContextualFragment and insertAdjacentHTML should throw syntax error
https://bugs.webkit.org/show_bug.cgi?id=87454

Reviewed by Darin Adler.

Source/WebCore:

Before this patch, createContextualFragment threw NOT_SUPPORTED_ERR and insertAdjacentHTML didn't throw any errors.
Make them throw SYNTAX_ERR to be consistent with the spec and Firefox:
http://html5.org/specs/dom-parsing.html#parsing
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-xhtml-syntax.html#xml-fragment-parsing-algorithm

Also reduced the code duplication.

Test: fast/dom/xhtml-fragment-parsing-exceptions.xhtml

  • dom/Range.cpp:

(WebCore::Range::createContextualFragment):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setInnerHTML): Explicitly pass AllowScriptingContent.

  • editing/markup.cpp:

(WebCore::createFragmentFromMarkup):
(WebCore::createFragmentForInnerOuterHTML): Takes ExceptionCode now.
(WebCore::createContextualFragment): Share code with createFragmentForInnerOuterHTML
and propagate the exception code.

  • editing/markup.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerHTML): Explicitly pass AllowScriptingContent.
(WebCore::HTMLElement::setOuterHTML): Ditto.
(WebCore::HTMLElement::insertAdjacentHTML): Ditto; also rename ignoredEc to ignoredEC
per Darin's comment on the bug 87339.

Source/WebKit/qt:

Pass an ExceptionCode to createContextualFragment.

  • Api/qwebelement.cpp:

(QWebElement::appendInside):
(QWebElement::prependInside):
(QWebElement::prependOutside):
(QWebElement::appendOutside):
(QWebElement::encloseContentsWith):
(QWebElement::encloseWith):

LayoutTests:

Add a regression test, and rebaselined the existing tests since we throw
DOMException.SYNTAX_ERR instead of DOMException.INVALID_STATE_ERR.

  • fast/dom/xhtml-fragment-parsing-exceptions-expected.txt: Added.
  • fast/dom/xhtml-fragment-parsing-exceptions.xhtml: Added.
  • fast/innerHTML/innerHTML-changing-document-properties-expected.txt:
  • fast/parser/xhtml-innerhtml-null-byte-first.xhtml:
  • fast/parser/xhtml-innerhtml-null-byte.xhtml:
2:48 PM Changeset in webkit [118569] by jknotten@chromium.org
  • 3 edits
    2 adds in trunk

Body scrollWidth() and scrollHeight() should be page scale-invariant
https://bugs.webkit.org/show_bug.cgi?id=87494

RenderView::documentRect() is calculating the "scaled" document rect by applying
the current transformation matrix to the unscaledDocumentRect() and then
returning the rounded-out IntRect result.

This rounding out is incorrect because it allows the scaled rectangle to
represent an area that is not actually covered by the document.

We fix this by applying the current transform to the document rect
as a FloatRect and then explicitly converting to IntRect, which
takes the floor of the resulting rectangle coordinates instead of
rounding them out.

This is evidenced by the document.body.scrollWidth() and
document.body.scrollHeight() changing under page scale factor when
they are expected to remain invariant.

Reviewed by James Robinson.

Source/WebCore:

Test: fast/dom/window-scroll-scaling.html

  • rendering/RenderView.cpp:

(WebCore::RenderView::documentRect):

LayoutTests:

  • fast/dom/window-scroll-scaling-expected.txt: Added.
  • fast/dom/window-scroll-scaling.html: Added.
2:46 PM Changeset in webkit [118568] by mitz@apple.com
  • 9 edits in trunk/Source/WebCore

characterBreakIterator() is not safe to use reentrantly or from multiple threads
https://bugs.webkit.org/show_bug.cgi?id=87521

Reviewed by Darin Adler.

Replaced characterBreakIterator() with a NonSharedCharacterBreakIterator class, which
obtains a unique TextBreakIterator. Replaced the global shared instance with a single-entry
cache.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData): Changed to use NonSharedCharacterBreakIterator.

  • platform/graphics/StringTruncator.cpp:

(WebCore::centerTruncateToBuffer): Ditto.
(WebCore::rightTruncateToBuffer): Ditto.

  • platform/text/String.cpp:

(WebCore::numGraphemeClusters): Ditto.
(WebCore::numCharactersInGraphemeClusters): Ditto.

  • platform/text/TextBreakIterator.h: Removed the declaration of characterBreakIterator().

(NonSharedCharacterBreakIterator): Added. An instance of this class has a character break
iterator instance that is unique to it for the lifetime of the instance.
(WebCore::NonSharedCharacterBreakIterator::operator TextBreakIterator*): Added.

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Added. Tries
to swap the m_iterator member variable with the cached instance. If that fails, initializes
m_iterator to a new character break iterator.
(WebCore::NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator): Added. Tries
to put the m_iterator member variable back in the cache. If that fails, meaning there is
already something in the cache, destroys m_iterator.

  • platform/text/gtk/TextBreakIteratorGtk.cpp:

(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Same as in
TextBreakIteratorICU.cpp.
(WebCore::NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator): Ditto.
(WebCore::cursorMovementIterator): Moved the old implementation of characterBreakIterator()
here.

  • platform/text/qt/TextBreakIteratorQt.cpp:

(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Same as in
TextBreakIteratorICU.cpp.
(WebCore::NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator): Ditto.
(WebCore::cursorMovementIterator): Moved the old implementation of characterBreakIterator()
here.

  • platform/text/wince/TextBreakIteratorWinCE.cpp:

(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator): Same as in
TextBreakIteratorICU.cpp.
(WebCore::NonSharedCharacterBreakIterator::~NonSharedCharacterBreakIterator): Ditto.
(WebCore::cursorMovementIterator): Moved the old implementation of characterBreakIterator()
here.

2:42 PM Changeset in webkit [118567] by Simon Fraser
  • 32 edits
    8 adds in trunk

Terrible performance on http://alliances.commandandconquer.com/ and http://www.lordofultima.com/
https://bugs.webkit.org/show_bug.cgi?id=84410

Source/WebCore:

Reviewed by Dave Hyatt.

First part of fixing O(N2) issues when walking the RenderLayer tree
for computeCompositingRequirements().

For each layer that goes into the OverlapMap, we were computing an absolute
layer bounds, which requires walking back to the root of the tree.
Optimize this when possible by storing a stack of offsets as we walk
the tree, and using this stack to do the mapping.

The stack of offsets and transforms is managed by RenderGeometryMap.
When visiting a RenderLayer, RenderLayerCompositor pushes onto
the geometry map stack data about offsets and transforms between
the current layer and its stacking-parent. RenderGeometryMap handles
the case where the previous renderer pushed is between the current
renderer and its container. RenderGeometryMap can also handle callers
pushing renderers with multiple containers between them.

RenderGeometryMap stores some flags about whether the set of mapping
steps in the stack involve transforms, fixed position, or special non-uniform
mappings like CSS columns. In some cases, it falls back to mapping via
renderers.

Once constructed, the RenderGeometryMap stack can be used to map multiple
rects or points efficiently. Stacks consisting of simple offsets are
collapsed to a single offset.

Mappings between renderers and their containers are pushed by pushMappingToContainer()
methods, which are similar to mapLocalToContainer() methods. Having this code
in RenderObjects was deemed preferable to handling columns, transforms etc. all in
RenderLayer code.

Tested by assertions in RenderGeometryMap code that its mapping matches
mapping via localToAbsolute() calls.

RenderLayerCompositor::updateCompositingLayers() creates a RenderGeometryMap,
and pushes and pops layer renderers as it visits them. The geometry map is used
by RenderLayerCompositor::addToOverlapMap() when computing absolute layer bounds.

Futher optimizations in RenderGeometryMap are possible, especially with stacks that
have many offsets and a few transforms.

Tests: compositing/geometry/composited-in-columns.html

compositing/geometry/flipped-writing-mode.html

  • CMakeLists.txt: Add RenderGeometryMap
  • GNUmakefile.list.am: Ditt
  • Target.pri: Ditto
  • WebCore.gypi: Ditto
  • WebCore.vcproj/WebCore.vcproj: Ditto
  • WebCore.xcodeproj/project.pbxproj: Ditto
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::absoluteContentBox):
(WebCore::RenderBox::pushMappingToContainer):
(WebCore::RenderBox::offsetFromContainer):

  • rendering/RenderBox.h:
  • rendering/RenderGeometryMap.cpp: Added.

(RenderGeometryMapStep):
(WebCore::RenderGeometryMapStep::RenderGeometryMapStep):
(WebCore::RenderGeometryMapStep::mapPoint):
(WebCore::RenderGeometryMapStep::mapQuad):
(WebCore::RenderGeometryMap::RenderGeometryMap):
(WebCore::RenderGeometryMap::~RenderGeometryMap):
(WebCore::RenderGeometryMap::absolutePoint):
(WebCore::RenderGeometryMap::absoluteRect):
(WebCore::RenderGeometryMap::mapToAbsolute):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):
(WebCore::RenderGeometryMap::push):
(WebCore::RenderGeometryMap::pushView):
(WebCore::RenderGeometryMap::popMappingsToAncestor):
(WebCore::RenderGeometryMap::stepInserted):
(WebCore::RenderGeometryMap::stepRemoved):

  • rendering/RenderGeometryMap.h: Added.

(RenderGeometryMap):
(WebCore::RenderGeometryMap::hasNonUniformStep):
(WebCore::RenderGeometryMap::hasTransformStep):
(WebCore::RenderGeometryMap::hasFixedPositionStep):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::offsetFromContainer):
(WebCore::RenderInline::pushMappingToContainer):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::pushMappingToContainer):
(WebCore::RenderObject::offsetFromContainer):
(WebCore::RenderObject::container):

  • rendering/RenderObject.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::offsetFromContainer):

  • rendering/RenderTableCell.h:

(RenderTableCell):

  • rendering/RenderView.cpp:

(WebCore::RenderView::pushMappingToContainer):

  • rendering/RenderView.h:
  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::pushMappingToContainer):

  • rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::pushMappingToContainer):

  • rendering/svg/RenderSVGInline.h:

(RenderSVGInline):

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::pushMappingToContainer):

  • rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::pushMappingToContainer):

  • rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::pushMappingToContainer):

  • rendering/svg/RenderSVGText.h:

(RenderSVGText):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::pushMappingToContainer):

  • rendering/svg/SVGRenderSupport.h:

(SVGRenderSupport):

LayoutTests:

Reviewed by Dave Hyatt.

Basic tests for compositing inside columns, and in a flipped-writing-mode
document.

  • compositing/geometry/composited-in-columns-expected.png: Added.
  • compositing/geometry/composited-in-columns-expected.txt: Added.
  • compositing/geometry/composited-in-columns.html: Added.
  • compositing/geometry/flipped-writing-mode-expected.png: Added.
  • compositing/geometry/flipped-writing-mode-expected.txt: Added.
  • compositing/geometry/flipped-writing-mode.html: Added.
2:41 PM Changeset in webkit [118566] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk/LayoutTests

Acid3 fails in WebKit2 regression tests
https://bugs.webkit.org/show_bug.cgi?id=87187

Patch by Andras Becsi <andras.becsi@nokia.com> on 2012-05-25
Reviewed by Alexey Proskuryakov.

Since the link test in the acid3.html relies on visited link tracking
it should call layoutTestController.keepWebHistory() because visited
link tracking is disabled by default to avoid interdependencies between
test.

Update expected files and png's now that the result does not show the
"YOU SHOULD NOT SEE THIS AT ALL" text in red in the top left corner.

  • http/tests/misc/acid3-expected.png:
  • http/tests/misc/acid3-expected.txt:
  • http/tests/misc/acid3.html: Fix test.
  • platform/chromium-mac-leopard/http/tests/misc/acid3-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png:
  • platform/chromium-mac/http/tests/misc/acid3-expected.png:
  • platform/chromium-mac/http/tests/misc/acid3-expected.txt:
  • platform/mac-wk2/http/tests/misc/acid3-expected.png: Same as the platform independent result. Removed.
  • platform/mac-wk2/http/tests/misc/acid3-expected.txt: Same as the platform independent result. Removed.
2:38 PM Changeset in webkit [118565] by kbr@google.com
  • 3 edits
    3 copies
    4 adds in trunk/LayoutTests

Incorporate new tex-image-and-sub-image-2d-with-video*.html tests
https://bugs.webkit.org/show_bug.cgi?id=87042

Reviewed by James Robinson.

Incorporated current version of video-related WebGL tests from
Khronos repository testing uploading to all packed pixel formats.

  • fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-video.js: Added.

(generateTest.runOneIteration):
(generateTest.runTest):

  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551-expected.txt: Copied from LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html:
2:36 PM Changeset in webkit [118564] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Rebaseline the Windows getComputedStyle results to reflect features
turned off on Windows.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
2:28 PM Changeset in webkit [118563] by danakj@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] WebLayerTreeViewImpl should not hide methods in CCLayerTreeHost with signatures that match the Client interface
https://bugs.webkit.org/show_bug.cgi?id=87301

Reviewed by James Robinson.

Most methods in the CCLayerTreeHostClient interface have a matching
method signature on CCLayerTreeHost that simply calls the client, if
one exists at all. However, CCLayerTreeHost::updateAnimations() does
important work in addition to calling the client.

Currently WebLayerTreeViewImpl itself implements the interface for
CCLayerTreeHostClient as well as CCLayerTreeHost, and simply forwards
any call to a method in the client interface to its own client. This
blocks WebViewImpl from calling CCLayerTreeHost::updateAnimations, since
the method is also in the client interface.

We change WebLayerTreeViewImpl to own a CCLayerTreeHost and a
WebLayerTreeHostClientAdapter. This fixes the shadowing by making
the two interfaces separate, and resolves lifetime issues by
ensuring that the CCLayerTreeHost is destroyed before its client.

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setSurfaceReady):
(WebKit::WebLayerTreeView::setRootLayer):
(WebKit::WebLayerTreeView::compositorIdentifier):
(WebKit::WebLayerTreeView::setViewportSize):
(WebKit::WebLayerTreeView::viewportSize):
(WebKit::WebLayerTreeView::setBackgroundColor):
(WebKit::WebLayerTreeView::setVisible):
(WebKit::WebLayerTreeView::setPageScaleFactorAndLimits):
(WebKit::WebLayerTreeView::startPageScaleAnimation):
(WebKit::WebLayerTreeView::setNeedsAnimate):
(WebKit::WebLayerTreeView::setNeedsRedraw):
(WebKit::WebLayerTreeView::commitRequested):
(WebKit::WebLayerTreeView::composite):
(WebKit::WebLayerTreeView::updateAnimations):
(WebKit::WebLayerTreeView::compositeAndReadback):
(WebKit::WebLayerTreeView::finishAllRendering):
(WebKit::WebLayerTreeView::context):
(WebKit::WebLayerTreeView::loseCompositorContext):

  • src/WebLayerTreeViewImpl.cpp:

(WebKit):
(WebLayerTreeViewClientAdapter):
(WebKit::WebLayerTreeViewClientAdapter::WebLayerTreeViewClientAdapter):
(WebKit::WebLayerTreeViewClientAdapter::~WebLayerTreeViewClientAdapter):
(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::~WebLayerTreeViewImpl):

  • src/WebLayerTreeViewImpl.h:

(WebCore):
(WebKit):
(WebKit::WebLayerTreeViewImpl::layerTreeHost):
(WebLayerTreeViewImpl):

2:17 PM Changeset in webkit [118562] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

Cache absolute clip rects on RenderLayer for compositing overlap testing
https://bugs.webkit.org/show_bug.cgi?id=87212

Reviewed by Dave Hyatt.

Enhance the cache of ClipRects on RenderLayers to store three
different types of ClipRects, rather than just one.

We need to compute clip rects relative to different layers
for different purposes. For painting, we compute relative to
the compositing layer which is acting as a painting root.
For hit testing, we compute relative to the root, except
for transformed layers. For composting overlap testing, we
compute relative to the root ("absolute"). At other times, we do one-off
computation which we never want to cache ("temporary clip rects").

This change allows us to cache rects for hit testing, and for
compositing overlap testing. This has huge performance benefits
on some pages (bug 84410).

This change also makes ClipRects not arena-allocated, so we
can use RefPtr<ClipRect>.

No testable behavior change.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed): No need for the
explicit clipRects teardown, since clipRects don't need a live
RenderObject for arena-based destruction.

  • rendering/RenderLayer.cpp: Remove arena-related new and delete.

(WebCore::RenderLayer::RenderLayer): No need to explicitly initialize m_clipRects,
since it's an OwnPtr now.
(WebCore::RenderLayer::~RenderLayer): No explicit clipRect teardown required.
(WebCore::RenderLayer::clippingRootForPainting): Renamed to make its purpose
more obvious.
(WebCore::RenderLayer::paintLayer): Use the TemporaryClipRects type when necessary.
(WebCore::RenderLayer::paintLayerContents): Ditto
(WebCore::RenderLayer::hitTestLayer): No longer need to use temporary clipRects when
hit testing since we cache clip rects for hit testing.
(WebCore::RenderLayer::updateClipRects): Take a ClipRectsType and pass it through.
(WebCore::RenderLayer::calculateClipRects): Ditto
(WebCore::RenderLayer::parentClipRects): Ditto
(WebCore::RenderLayer::backgroundClipRect): Ditto
(WebCore::RenderLayer::calculateRects): Take ClipRectsType, which obviates temporaryClipRects.
(WebCore::RenderLayer::childrenClipRect): Use clippingRootForPainting().
(WebCore::RenderLayer::selfClipRect): Ditto
(WebCore::RenderLayer::localClipRect): Ditto
(WebCore::RenderLayer::clearClipRectsIncludingDescendants): Take a type of clip rect to clear
(include all). Allows us to just clear painting clip rects.
(WebCore::RenderLayer::clearClipRects):

  • rendering/RenderLayer.h:

(WebCore::ClipRects::create): We don't use RefCounted<> in order to use a bit in
the refCount for a flag. Add create() method.
(WebCore::ClipRects::deref): No longer arena-allocated.
(WebCore::ClipRectsCache::ClipRectsCache): Struct that holds a small
array of the 3 types of clipRects (and, in debug, the layer relative
to which they were computed).
(WebCore::RenderLayer::clipRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds): Use AbsoluteClipRects; rootLayer
is always the RenderView's layer here.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Use TemporaryClipRects.
(WebCore::RenderLayerBacking::setRequiresOwnBackingStore): When this variable changes,
we need to invalidate painting clipRects, since it affects the ancestor relative to which
those rects are computed.

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking): When the composited state
of a layer changes, we have to clear all descendant clip rects, since this
can affect the layers relative to which clip rects are computed.
(WebCore::RenderLayerCompositor::addToOverlapMap): Use AbsoluteClipRects.
(WebCore::RenderLayerCompositor::computeCompositingRequirements): No need
to call updateLayerPosition(), since that should have always happened after
layout. That call cleared clip rects, so removing it is very beneficial.
(WebCore::RenderLayerCompositor::clippedByAncestor): Use TemporaryClipRects.

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers): Use TemporaryClipRects.

2:14 PM Changeset in webkit [118561] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Pasting into contenteditable table cell pastes into adjacent cell instead.
https://bugs.webkit.org/show_bug.cgi?id=53933

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-05-25
Reviewed by Darin Adler.

This bug has been fixed. Add a test to make sure that it won't regress.

  • editing/pasteboard/paste-into-table-cell-2-expected.txt: Added.
  • editing/pasteboard/paste-into-table-cell-2.html: Added.
2:09 PM Changeset in webkit [118560] by beidson@apple.com
  • 4 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=87418
WebBackForwardList should separate "has no current index" from the integer value of the current index

This patch also renames "m_current" to "m_currentIndex" for clarity and symmetry with
other variable names that reference "index",

It also removes the m_closed and m_enabled flags which were never actually used.

Reviewed by Darin Adler.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::currentItem):
(WebKit::WebBackForwardList::backItem):
(WebKit::WebBackForwardList::forwardItem):
(WebKit::WebBackForwardList::itemAtIndex):
(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):

  • UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::currentIndex):
(WebBackForwardList):

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):

2:07 PM Changeset in webkit [118559] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=87529
Background tabs hosted in window server flash before painting
when they first become active

Reviewed by Anders Carlsson.

Initialize to LayerHostingModeInWindowServer if that is
available to avoid having to re-make the context and re-set
everything later on.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

2:00 PM Changeset in webkit [118558] by jsbell@chromium.org
  • 1 edit
    6 deletes in trunk/LayoutTests

[Chromium] Remove 6 incorrect baselines from http://trac.webkit.org/changeset/117821/

Unreviewed gardening.

  • platform/chromium-win/fast/viewport/viewport-126-expected.txt: Removed.
  • platform/chromium-win/fast/viewport/viewport-127-expected.txt: Removed.
  • platform/chromium-win/fast/viewport/viewport-65-expected.txt: Removed.
  • platform/chromium-win/fast/viewport/viewport-82-expected.txt: Removed.
  • platform/chromium-win/fast/viewport/viewport-84-expected.txt: Removed.
  • platform/chromium-win/fast/viewport/viewport-87-expected.txt: Removed.
1:48 PM Changeset in webkit [118557] by dpranke@chromium.org
  • 6 edits in trunk/Tools

webkitpy: change scm.add(), scm.delete() to accept multiple paths
https://bugs.webkit.org/show_bug.cgi?id=87528

Reviewed by Ojan Vafai.

launching git or svn for individual files can be slow; this
change will hand multiple paths at once to git and svn so they
can be added in a batch.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.add_list):
(Git.delete_list):

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.add):
(SCM):
(SCM.add_list):
(SCM.delete):
(SCM.delete_list):

  • Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.add):
(MockSCM):
(MockSCM.add_list):
(MockSCM.delete):
(MockSCM.delete_list):

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(_shared_test_exists):
(_shared_test_added_files):
(_test_delete_list):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.add_list):
(SVN.delete_list):

1:28 PM Changeset in webkit [118556] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

2012-05-25 Jessie Berlin <jberlin@apple.com>

Web Timing is not enabled on Windows
https://bugs.webkit.org/show_bug.cgi?id=42435

Add the fast/performance tests to the Windows Skipped list.

  • platform/win/Skipped:
1:19 PM Changeset in webkit [118555] by fpizlo@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

DFG ConvertThis should just be a CheckStructure if the structure is known
https://bugs.webkit.org/show_bug.cgi?id=87057

Reviewed by Gavin Barraclough.

Merged r118021 from dfgopt.

This gives ValueProfile the ability to track singleton values - i.e. profiling
sites that always see the same value.

That is then used to profile the structure in op_convert_this.

This is then used to optimize op_convert_this into a CheckStructure if the
structure is always the same.

That then results in better CSE in inlined code that uses 'this', since
previously we couldn't CSE accesses on 'this' from different inline call frames.

Also fixed a bug where we were unnecessarily flushing 'this'.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::stronglyVisitStrongReferences):

  • bytecode/LazyOperandValueProfile.cpp:

(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):

  • bytecode/LazyOperandValueProfile.h:

(CompressedLazyOperandValueProfileHolder):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/ValueProfile.h:

(JSC::ValueProfileBase::ValueProfileBase):
(JSC::ValueProfileBase::dump):
(JSC::ValueProfileBase::computeUpdatedPrediction):
(ValueProfileBase):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_convert_this):
(JSC::JIT::emitSlow_op_convert_this):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSValue.h:

(JSValue):

  • runtime/Structure.h:

(JSC::JSValue::structureOrUndefined):
(JSC):

1:11 PM Changeset in webkit [118554] by jhoneycutt@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

2012-05-25 Jessie Berlin <jberlin@apple.com>

File API is not yet supported on Windows
https://bugs.webkit.org/show_bug.cgi?id=37957

Add platform specific results for a test that attempts to use the FileReaderConstructor.

  • platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
1:02 PM Changeset in webkit [118553] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r112155.
http://trac.webkit.org/changeset/112155
https://bugs.webkit.org/show_bug.cgi?id=79389
Hitch (due to style recalc?) when starting CSS3 animation

This caused a number of issues, including:
https://bugs.webkit.org/show_bug.cgi?id=87146
https://bugs.webkit.org/show_bug.cgi?id=84194
<rdar://problem/11506629>
<rdar://problem/11267408>
<rdar://problem/11531859>

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

12:50 PM Changeset in webkit [118552] by hyatt@apple.com
  • 8 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=87525

For the new multi-column layout, create a flow thread and make sure the children get put inside it.

Reviewed by Eric Seidel.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::addChild):
(WebCore):

  • rendering/RenderMultiColumnBlock.h:

(WebCore):
(RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::flowThread):

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::~RenderMultiColumnFlowThread):
(WebCore):

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::isRenderMultiColumnSet):

12:40 PM Changeset in webkit [118551] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

Change RenderBoxModelObject to compute relativePositionOffset as size
https://bugs.webkit.org/show_bug.cgi?id=87447

Reviewed by Eric Seidel.

Compute relativePositionOffset as size instead of doing one axis at a
time as all call sites uses the size version of the method. This avoids
having to walk the DOM twice to accumulate the offsets.

Also remove the relativePositionOffsetX and Y methods as they are no
longer used.

No new tests, covered by existing tests.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::layoutOverflowRectForPropagation):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::accumulateRelativePositionOffsets):
(WebCore::RenderBoxModelObject::relativePositionOffset):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

12:40 PM Changeset in webkit [118550] by zandobersek@gmail.com
  • 2 edits in trunk

configure.ac has duplicated AC_MSG_RESULT([$enable_sandbox]) and nothing for seamless iframes
https://bugs.webkit.org/show_bug.cgi?id=87453

Reviewed by Eric Seidel.

Report the value of $enable_iframe_seamless rather than $enable_sandbox
after checking whether to enable the iframe seamless option.

  • configure.ac:
12:38 PM WebKit Team edited by Dave Barton
(diff)
12:21 PM Changeset in webkit [118549] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r118395.
http://trac.webkit.org/changeset/118395
https://bugs.webkit.org/show_bug.cgi?id=87526

Breaking sites including GMail and Yahoo mail (Requested by
jsbell on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-25

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseMargins):

LayoutTests:

  • fast/css/clear-float-sibling-expected.html: Removed.
  • fast/css/clear-float-sibling.html: Removed.
12:06 PM Changeset in webkit [118548] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip the Network Information tests on Windows.

  • platform/win/Skipped:
12:05 PM Changeset in webkit [118547] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[NRWT] Add unit testing for perf tests on locked shards
https://bugs.webkit.org/show_bug.cgi?id=87489

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-25
Reviewed by Dirk Pranke.

Adding utests that makes sure that perf tests are running in locked
shards and by passing --no-http won't break NRWT (r118421).

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ShardingTests):
(ShardingTests.test_shard_by_dir):
(ShardingTests.test_shard_every_file):
(ShardingTests.test_shard_in_two):
(ShardingTests.test_multiple_locked_shards):
(LockCheckingManager):
(LockCheckingManager.init):
(LockCheckingManager.handle_finished_list):
(ManagerTest.test_http_locking):
(ManagerTest):
(ManagerTest.test_perf_locking):

  • Scripts/webkitpy/layout_tests/port/test.py:
12:04 PM Changeset in webkit [118546] by jsbell@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

[Chromium] Remove 2 incorrect rebaselines from http://trac.webkit.org/changeset/117818/

Unreviewed gardening.

  • platform/chromium-mac/canvas/philip/tests/2d.imageData.create1.type-expected.txt: Removed.
  • platform/chromium-mac/canvas/philip/tests/2d.imageData.create2.type-expected.txt: Removed.
11:48 AM Changeset in webkit [118545] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip more WebGL tests on Windows.

  • platform/win/Skipped:
11:36 AM Changeset in webkit [118544] by zandobersek@gmail.com
  • 2 edits in trunk

[Gtk] Remove configuration options that do not apply anymore
https://bugs.webkit.org/show_bug.cgi?id=87509

Reviewed by Martin Robinson.

Remove configuration options for enabling or disabling HTML5 datagrid,
DOM storage, image resizer API and sandboxed iframe support. These
features were either turned on by default with the feature defines
removed from the code or removed from the source.

  • configure.ac:
11:24 AM Changeset in webkit [118543] by epoger@chromium.org
  • 13 edits
    2 adds
    8 deletes in trunk/LayoutTests

New baselines for http://crbug.com/129184

Unreviewed rebaselining.

Patch by Elliot Poger <epoger@chromium.org> on 2012-05-25

  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-linux/svg/transforms/svg-css-transforms-expected.png:
  • platform/chromium-linux/transforms/svg-vs-css-expected.png:
  • platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-mac/svg/transforms/svg-css-transforms-expected.png:
  • platform/chromium-mac/transforms/svg-vs-css-expected.png:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-win/svg/transforms/svg-css-transforms-expected.png:
  • platform/chromium-win/transforms/svg-vs-css-expected.png:
  • platform/efl/svg/filters/subRegion-one-effect-expected.txt: Removed.
  • platform/efl/svg/filters/subRegion-two-effects-expected.txt: Removed.
  • platform/gtk/svg/filters/subRegion-one-effect-expected.txt: Removed.
  • platform/gtk/svg/filters/subRegion-two-effects-expected.txt: Removed.
  • platform/mac/svg/filters/subRegion-one-effect-expected.txt: Removed.
  • platform/mac/svg/filters/subRegion-two-effects-expected.txt: Removed.
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt: Removed.
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt: Removed.
  • svg/filters/subRegion-one-effect-expected.txt: Added.
  • svg/filters/subRegion-two-effects-expected.txt: Added.
11:01 AM Changeset in webkit [118542] by kenrb@chromium.org
  • 2 edits in trunk/Source/WebCore

Layout root not getting cleared for anonymous renderers geting destroyed
https://bugs.webkit.org/show_bug.cgi?id=84002

Reviewed by Abhishek Arya.

This is a follow-up to r109406, which added a check to clear layout
roots when they point to a renderer that is being destroyed. The
thinking was that layout roots would never be anonymous renderers,
but there are some cases where this is not true (in particular,
generated content containers with overflow clips can be layout roots).

As in r109406, this patch has no layout test. This is because any test
that exercises this behavior is caused by an existing layout bug where
a child is not properly getting layout (or a renderer is getting dirtied
out of order during layout) and will fail multiple ASSERTs:

in particular, ASSERT(!m_layoutRoot->container()
!m_layoutRoot->

container()->needsLayout()) in FrameView::scheduleRelayoutOfSubtree(),
and ASSERT_NOT_REACHED() in RenderObject::clearLayoutRootIfNeeded().
We are preventing those bugs from manifesting as security issues with
this patch.

This also removes an ASSERT from the RenderObject destructor. This is
redundant with the condition in RenderObject::clearLayoutRootIfNeeded()
which is always called in RenderObject::willBeDestroyed(), so the check
is not needed. It had to be removed because it fails when I try to
adjust the ASSERT condition by removing the !node()
check, due to RenderWidget clearing its node() during destruction.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::~RenderObject):
(WebCore::RenderObject::willBeDestroyed):

10:47 AM Changeset in webkit [118541] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Implement LayoutTest's eventSender.beginDragWithFiles interface in windows platform
https://bugs.webkit.org/show_bug.cgi?id=86296

Add more affected tests to the Windows Skipped list.

  • platform/win/Skipped:
10:47 AM Changeset in webkit [118540] by jberlin@webkit.org
  • 2 edits in trunk/Tools

[Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
https://bugs.webkit.org/show_bug.cgi?id=87511

Reviewed by Alexey Proskuryakov.

Update the Windows implementation of keyDown to match the Mac one changed in r118001.

  • DumpRenderTree/win/EventSender.cpp:

(keyDownCallback):

10:28 AM Changeset in webkit [118539] by kenrb@chromium.org
  • 2 edits in trunk/Tools

Adding Ken Buchanan to committers.py
https://bugs.webkit.org/show_bug.cgi?id=87443

Unreviewed.

Adding self to committers.py as a Committer.

  • Scripts/webkitpy/common/config/committers.py:
10:26 AM Changeset in webkit [118538] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: Hangup when continuously changing a css width value in Inspector
https://bugs.webkit.org/show_bug.cgi?id=85802

Reviewed by Vsevolod Vlasov.

Source/WebCore:

An error in the property whitespace prefix detection algorithm would append the previous line trailing whitespace,
thereby enormously increasing the actual prefix during multiple incremental property changes.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):

LayoutTests:

  • inspector/styles/styles-formatting-expected.txt:
  • inspector/styles/styles-formatting.html:
10:24 AM Changeset in webkit [118537] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Widen CRASH expectation for visibility-simple-canvas2d-layer.html to include Mac10.6.

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:14 AM Changeset in webkit [118536] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove/restore test expectations for html5lib tests.
https://bugs.webkit.org/show_bug.cgi?id=87275

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
10:08 AM Changeset in webkit [118535] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Remove test expectation for video-cookie.html now that the issue
is fixed on the Chromium side.
https://bugs.webkit.org/show_bug.cgi?id=87459

Unreviewed gardening.

  • platform/chromium/test_expectations.txt:
9:44 AM Changeset in webkit [118534] by jberlin@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove the Windows platform-specific results for window-domurl-crash.

r115582 changed this test to use Blob instead of WebKitBlobBuilder, so the fact that Windows
doesn't support WebKitBlobBuilder no longer affects this test.

  • platform/chromium-win/fast/dom/window-domurl-crash-expected.txt: Removed.
  • platform/win/fast/dom/window-domurl-crash-expected.txt: Removed.
9:24 AM Changeset in webkit [118533] by apavlov@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Clean up Inspector.json after r118367
https://bugs.webkit.org/show_bug.cgi?id=87499

Reviewed by Yury Semikhatsky.

This cleans up the semantic inconsistencies introduced into type/field names r118367.

No new tests, as this is a refactoring.

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

  • inspector/InspectorStyleSheet.h:

(InspectorStyleSheet):
(WebCore::InspectorStyleSheet::canBind):
(InspectorStyleSheetForInlineStyle):

9:23 AM Changeset in webkit [118532] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

  • platform/chromium/test_expectations.txt:
9:19 AM Changeset in webkit [118531] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed; rolling chromium deps.

  • DEPS:
8:49 AM Changeset in webkit [118530] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] History navigation caused google.com scale not kept
https://bugs.webkit.org/show_bug.cgi?id=87438

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 159923
For back/forward history navigation, we were trying to keep the values
set by dispatchViewportDataDidChange. However, when we went back from
the previous page, if the current page didn't contain the meta viewport
tag, then those values set by previous page would never be reset.
Although the current page could get correct saved scale when restoring
view state, the scale would still be clamped by zoomToFitScale which
was based on the virtual viewport of the previous page which could make
the scale incorrect.
Since we know the viewport arguments of the current document before
setLoadState on back/forward history navigation, we can reset these
previous values if the document doesn't have viewport arguments during
setLoadState.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):

8:40 AM Changeset in webkit [118529] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: speed-up HeapSnapshot._bfs method.
https://bugs.webkit.org/show_bug.cgi?id=87502

It had containmentEdges.length call in the loop that forced deoptimization.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._calculateObjectToWindowDistance):
(WebInspector.HeapSnapshot.prototype._bfs):

8:32 AM Changeset in webkit [118528] by loislo@chromium.org
  • 4 edits in trunk

Web Inspector: Speed up edges iteration in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=87286

Add an extra node to nodes array that points to the end of edges array.
It allows to eliminate a check for the last node in iteration code.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-25
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype._edgeIndexesStart):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesEnd):
(WebInspector.HeapSnapshotNodeIterator):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatorTree):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
(initialize_HeapSnapshotTest.InspectorTest._postprocessHeapSnapshotMock):

8:16 AM Changeset in webkit [118527] by caseq@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Web Inspector: put paint and compositing timeline events in a new category of their own
https://bugs.webkit.org/show_bug.cgi?id=86852

Reviewed by Pavel Feldman.

  • add forth timeline category, "Painting"; make it light-purple;
  • assign paint and compositing events to Painting category;
  • WebCore.gypi: added timelineBarLightPurple.png;
  • inspector/front-end/Images/timelineBarLightPurple.png: Added.
  • inspector/front-end/Images/timelineCheckmarks.png: added light-purple icon;
  • inspector/front-end/Images/timelineDots.png: ditto.
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineCategoryStrips.prototype.update.appendRecord): do not merge bars in same raw if these are from different categories;
(WebInspector.TimelineCategoryStrips.prototype.update):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.recordStyle):

  • inspector/front-end/WebKit.qrc: added timelineBarLightPurple.png;
  • inspector/front-end/timelinePanel.css: added styles for painting category;

(.timeline-category-statusbar-item.timeline-category-painting .timeline-category-checkbox):
(.timeline-category-painting .timeline-graph-bar):
(.popover .timeline-painting):
(.timeline-category-scripting .timeline-tree-icon):
(.timeline-category-rendering .timeline-tree-icon):
(.timeline-category-painting .timeline-tree-icon):

8:04 AM Changeset in webkit [118526] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Pass http headers to loader in download request
https://bugs.webkit.org/show_bug.cgi?id=87449

Reviewed by Rob Buis.

PR# 149283

This is to support byte-range download and we could pass http headers like
"Range" in download request to loader.

Reviewed internally by Lyon Chen.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::download):

7:47 AM Changeset in webkit [118525] by wjmaclean@chromium.org
  • 5 edits in trunk/Source

[chromium] LayerChromium should recognise existing layer active animations when the layer is added.
https://bugs.webkit.org/show_bug.cgi?id=87166

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test added.

LayerChromium needs to correctly recognize if a newly added layer has an existing
active animation.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerTreeHost):
(WebCore::LayerChromium::notifyAnimationFinished):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::didAddAnimationWasCalled):
(MockLayerTreeHost):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF):
(CCLayerTreeHostTestLayerAddedWithAnimation):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::CCLayerTreeHostTestLayerAddedWithAnimation):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::afterTest):

7:05 AM Changeset in webkit [118524] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening after r118166, r118291 and r118442.

  • platform/gtk/test_expectations.txt:
6:48 AM Changeset in webkit [118523] by loislo@chromium.org
  • 4 edits in trunk

Web Inspector: HeapSnapshot: introduce performance counter for HeapSnapshotConstructorsDataGrid._aggregatesReceived method.
https://bugs.webkit.org/show_bug.cgi?id=87393

Reviewed by Yury Semikhatsky.

PerformanceTests:

  • inspector/heap-snapshot.html:

Source/WebCore:

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._aggregatesReceived):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._populateChildren):

6:45 AM Changeset in webkit [118522] by mario@webkit.org
  • 8 edits
    2 adds in trunk/Source/WebKit2

[GTK][WK2] Implement API for generic permission requests
https://bugs.webkit.org/show_bug.cgi?id=84018

Reviewed by Martin Robinson.

Added new 'permission-request' signal to WebKitWebView, to be
fired when WebKit needs confirmation from the user on whether to
allow or deny certain operations, such as sharing the user's
location with web site through the Geolocation API.

New WebKitPermissionRequest interface, providing allow() and
deny() operations, to be called over the objects implementing it
when emitted along with the new 'permission-request' signal.

  • UIProcess/API/gtk/WebKitPermissionRequest.cpp: Added.

(webkit_permission_request_default_init):
(webkit_permission_request_allow):
(webkit_permission_request_deny):

  • UIProcess/API/gtk/WebKitPermissionRequest.h: Added.

(_WebKitPermissionRequestIface):

  • GNUmakefile.am: Added new files.

Added the new signal to WebKitWebView, providing a default handler
that will just deny the request when the signal is not handled.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewDecidePermissionRequest): Default handler.
(webkit_web_view_class_init): Declare the new signal and connect
to the default handler.
(webkitWebViewMakePermissionRequest): Helper function to create a
make a new permission request and emit the new signal signal.

  • UIProcess/API/gtk/WebKitWebView.h:

(_WebKitWebViewClass):

  • UIProcess/API/gtk/WebKitWebViewPrivate.h: Declare the creational

function webkitWebViewMakePermissionRequest for internal use only.

Updated documentation files.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
6:42 AM Changeset in webkit [118521] by loislo@chromium.org
  • 6 edits in trunk

Web Inspector: drop obsolete WebInspector.Uint32Array and adjust snapshot chunk size for better transfer-snapshot metric.
https://bugs.webkit.org/show_bug.cgi?id=87490

Originally WebInspector.Uint32Array was used for dynamic array
reallocation because we had no information about expected arrays sizes.
Now we have these sizes and allocates array precisely.

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • bindings/v8/ScriptHeapSnapshot.cpp:

(WebCore):

  • inspector/front-end/HeapSnapshot.js:
  • inspector/front-end/HeapSnapshotLoader.js:

(WebInspector.HeapSnapshotLoader.prototype._parseUintArray):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):

LayoutTests:

  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.):

6:10 AM Changeset in webkit [118520] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: cmd-[ shortcut navigates page and is fr-keyboard incompatible
https://bugs.webkit.org/show_bug.cgi?id=85312

Reviewed by Vsevolod Vlasov.

Suppress the handling of panel history navigation events if the corresponding keyboard activities produce
the "keypress" event (which is the case on French keyboards, where AltGr+[ is translated into Ctrl+Alt+[ on Windows).
The event is also told to preventDefault() to avoid browser history navigation on Mac while traversing the Inspector panel history.

  • inspector/front-end/InspectorView.js:

(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype._keyPress):
(WebInspector.InspectorView.prototype._keyDown):
(WebInspector.InspectorView.prototype._keyDownInternal):

  • inspector/front-end/UIUtils.js:

(WebInspector.isWin):

6:08 AM Changeset in webkit [118519] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2012-05-25 Yury Semikhatsky <yurys@google.com>

Unreviewed. Fixed closure compiler warnings.

  • inspector/front-end/NativeMemorySnapshotView.js: (WebInspector.NativeMemoryProfileType.prototype.buttonClicked): (WebInspector.NativeMemoryProfileHeader.prototype.createView):
6:05 AM Changeset in webkit [118518] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] fix compilation warning in GtkInputMethodFilter.cpp
https://bugs.webkit.org/show_bug.cgi?id=87475

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-05-25
Reviewed by Martin Robinson.

  • platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::setWidget):

6:04 AM Changeset in webkit [118517] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] fix compilation for webkitwebview.cpp
https://bugs.webkit.org/show_bug.cgi?id=87473

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-05-25
Reviewed by Martin Robinson.

When ACCELERATED_COMPOSITING and TEXTURE_MAPPER_GL is not set,
the local variable 'priv' won't be used. Therefore the following warning:

../../../Source/WebKit/gtk/webkit/webkitwebview.cpp: In function ‘void webkit_web_view_realize(GtkWidget*)’:
../../../Source/WebKit/gtk/webkit/webkitwebview.cpp:971:27: warning: unused variable ‘priv’ [-Wunused-variable]

  • webkit/webkitwebview.cpp:

(webkit_web_view_realize):

5:54 AM Changeset in webkit [118516] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] fast/forms/color/input-value-sanitization-color.html can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=87487

Unreviewed EFL gardening. Unskip
fast/forms/color/input-value-sanitization-color.html now that
INPUT_TYPE_COLOR flag has been enabled by default for EFL port in
r114113.

Patch by Christophe Dumez <Christophe Dumez> on 2012-05-25

  • platform/efl/Skipped:
5:24 AM Changeset in webkit [118515] by commit-queue@webkit.org
  • 14 edits in trunk/LayoutTests

[EFL] [DRT] Gardening of failing tests and missing results
https://bugs.webkit.org/show_bug.cgi?id=87486

Unreviewed EFL gardening. Some rebaselines after r118448, and updated
expectations for a couple of tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-25

  • platform/efl/fast/html/details-position-expected.txt:
  • platform/efl/fast/replaced/width100percent-checkbox-expected.png:
  • platform/efl/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/efl/fast/replaced/width100percent-radio-expected.png:
  • platform/efl/fast/replaced/width100percent-radio-expected.txt:
  • platform/efl/mathml/presentation/fractions-expected.png:
  • platform/efl/mathml/presentation/fractions-expected.txt:
  • platform/efl/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/efl/mathml/presentation/mo-stretch-expected.png:
  • platform/efl/mathml/presentation/mo-stretch-expected.txt:
  • platform/efl/mathml/presentation/subsup-expected.txt:
  • platform/efl/test_expectations.txt:
5:18 AM Changeset in webkit [118514] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

[Qt] Broken controls rendering when transform is applied.
https://bugs.webkit.org/show_bug.cgi?id=87483

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-25
Reviewed by Simon Hausmann.

.:

  • ManualTests/qt/control_paiting_with_transforms.html: Added.

Source/WebCore:

Use only the scaling transform value to determine the size of
the control to be drawn. When other transforms present such as
rotate or skew, ignore them, unless scaling also involved. In
that case, calculate the scaling value out of the transformation.

  • ManualTests/qt/control_paiting_with_transforms.html: Added.
  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::painterScale):
(WebCore):
(WebCore::StylePainterMobile::sizeForPainterScale):

5:05 AM Changeset in webkit [118513] by caseq@chromium.org
  • 15 edits
    1 add in trunk/Source

[chromium] add instrumentation for compositing
https://bugs.webkit.org/show_bug.cgi?id=83928

Reviewed by James Robinson.

Source/Platform:

  • added willCommit() and didBeginFrame() methods for instrumentation of compositing.
  • chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):

Source/WebCore:

  • plumb willCommit() and didBeginFrame() from CCSingleThreadProxy and CCThreadProxy to inspector instrumentation;
  • note for threaded case, didBeginFrame() is invoked upon unblocking of main thread;
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHostClient):
(WebCore::CCLayerTreeHost::didBeginFrame):
(WebCore::CCLayerTreeHost::willCommit):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::commitAndComposite):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrame):

Source/WebKit/chromium:

  • plumb willCommit() and didComposite() to inspector instrumentation via WebViewImpl.
  • WebKit.gypi: Added WebLayerTreeViewTest
  • src/WebLayerTreeViewImpl.cpp:

(WebKit::WebLayerTreeViewImpl::didBeginFrame):
(WebKit):
(WebKit::WebLayerTreeViewImpl::willCommit):

  • src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::didBeginFrame):
(WebKit):
(WebKit::WebViewImpl::willCommit):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/CCLayerTreeHostTest.cpp:
  • tests/FakeCCLayerTreeHostClient.h:
  • tests/WebLayerTest.cpp:
  • tests/WebLayerTreeViewTest.cpp: Added.
4:20 AM Changeset in webkit [118512] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening. Skip a new test: fast/events/domactivate-sets-underlying-click-event-as-handled.html
because it times out on Qt and GTK platforms.

Patch by János Badics <János Badics> on 2012-05-25
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
3:34 AM Changeset in webkit [118511] by Csaba Osztrogonác
  • 11 edits in trunk

[Qt] Buildfix for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=87257

Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • Api/qgraphicswebview.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
  • Api/qwebframe.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
  • Api/qwebhistory.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
  • Api/qwebsettings.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
  • Api/qwebview.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
  • WebCoreSupport/FrameLoaderClientQt.cpp: Adjust QCoreApplication::translate() parameter list to newer Qt 5.

(WebCore::FrameLoaderClientQt::cancelledError):
(WebCore::FrameLoaderClientQt::blockedError):
(WebCore::FrameLoaderClientQt::cannotShowURLError):
(WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
(WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):
(WebCore::FrameLoaderClientQt::fileDoesNotExistError):
(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):

  • declarative/experimental/plugin.cpp: QDeclarativeExtensionPlugin -> QQmlExtensionPlugin renaming.
  • declarative/plugin.cpp: QDeclarativeExtensionPlugin -> QQmlExtensionPlugin renaming.

(WebKitQmlPlugin):

Tools:

  • MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
3:23 AM Changeset in webkit [118510] by vsevik@chromium.org
  • 10 edits
    1 delete in trunk/Source/WebCore

Web Inspector: Drop InspectorFileSystemInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=87460

Inspector does not need to track DOMFileSystem object now. So we can
drop InspectorFileSystemInstrumentation.

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-05-25
Reviewed by Vsevolod Vlasov.

  • GNUmakefile.list.am:
  • Modules/filesystem/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::create):

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorFileSystemAgent.cpp:

(WebCore::InspectorFileSystemAgent::enable):

  • inspector/InspectorFileSystemAgent.h:

(InspectorFileSystemAgent):

  • inspector/InspectorFileSystemInstrumentation.h: Removed.
  • inspector/InspectorInstrumentation.cpp:

(WebCore):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):

3:15 AM Changeset in webkit [118509] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: HeapProfiler: speed-up _calculateClassesRetainedSize and _buildAggregates.
https://bugs.webkit.org/show_bug.cgi?id=87482

Engine didn't inline node's classIndex method because the switch statement in it wasn't inlineable.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.classIndex):

3:09 AM Changeset in webkit [118508] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Dodge style recalc when id attribute is overwritten with same value.
<http://webkit.org/b/87211>

Reviewed by Eric Seidel.

Don't force style recalc when the id attribute is set to the same value it already had.
~3.5% improvement on Dromaeo's "dom-attr" locally.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

3:05 AM Changeset in webkit [118507] by kinuko@chromium.org
  • 4 edits in branches/chromium/1132

Merge 118497 - [chromium] DataTransferItem.webkitGetAsEntry() shouldn't be exposed without flag yet
https://bugs.webkit.org/show_bug.cgi?id=87457
BUG=129702
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10448022

3:05 AM Changeset in webkit [118506] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Fix client interface size for WKPageContextMenuClient.
https://bugs.webkit.org/show_bug.cgi?id=87472

Reviewed by Carlos Garcia Campos.

Add correct offset for version 1 and 2 of WKPageContextMenuClient.
Revision 109750 introduces a new API and increases size of interfaceSizesByVersion
but the table is not properly initialized for newly introduced version 2.

  • Shared/APIClientTraits.cpp:

(WebKit):

3:02 AM Changeset in webkit [118505] by kling@webkit.org
  • 3 edits in trunk/Source/WebKit2

Mac bots crashing under PluginInfo destructor.
<http://webkit.org/b/87414>
<rdar://problem/11527172>

Reviewed by Darin Adler.

We can't safely pass WTF::String to another thread without a deref() race,
so pass the PluginInfo vector by pointer instead of by value.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::sendDidGetPlugins):
(WebKit::WebContext::handleGetPlugins):

  • UIProcess/WebContext.h:
2:49 AM Changeset in webkit [118504] by yurys@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Web Inspector: add profile type for native memory snapshots
https://bugs.webkit.org/show_bug.cgi?id=87400

Reviewed by Vsevolod Vlasov.

Introduced new profile type and view classes for native memory snapshots.
All the stuff is hidden behind an experimental setting.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/NativeMemorySnapshotView.js: Added.

(WebInspector.NativeMemorySnapshotView):
(WebInspector.NativeMemorySnapshotView.prototype.dispose):
(WebInspector.NativeMemorySnapshotView.prototype.get statusBarItems):
(WebInspector.NativeMemorySnapshotView.prototype.get profile):
(WebInspector.NativeMemoryProfileType):
(WebInspector.NativeMemoryProfileType.prototype.get buttonTooltip):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.NativeMemoryProfileType.prototype.get treeItemTitle):
(WebInspector.NativeMemoryProfileType.prototype.get description):
(WebInspector.NativeMemoryProfileType.prototype.createTemporaryProfile):
(WebInspector.NativeMemoryProfileType.prototype.createProfile):
(WebInspector.NativeMemoryProfileHeader):
(WebInspector.NativeMemoryProfileHeader.prototype.createSidebarTreeElement):
(WebInspector.NativeMemoryProfileHeader.prototype.createView):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
2:44 AM Changeset in webkit [118503] by yurys@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: make some profiler methods private
https://bugs.webkit.org/show_bug.cgi?id=87479

Reviewed by Vsevolod Vlasov.

  • Removed unused methods.
  • Renamed private methods so that their names start with underscore.
  • ProfileLauncherView methods are called directly from ProfilesPanel instead of sending events.
  • inspector/front-end/CPUProfileView.js:
  • inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile):

  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView.prototype.profileStarted):
(WebInspector.ProfileLauncherView.prototype.profileFinished):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.createProfile):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback.var):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback):
(WebInspector.ProfilesPanel.prototype._populateProfiles):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot.done):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):

2:41 AM Changeset in webkit [118502] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] Gardening. fast/events/option-tab.html does not pass
https://bugs.webkit.org/show_bug.cgi?id=87471

Unreviewed. fast/events/option-tab.html should not pass as the
EFL port uses different keyboard accelerators than Safari (via Chromium).

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-25

  • platform/efl/test_expectations.txt:
2:30 AM Changeset in webkit [118501] by keishi@webkit.org
  • 3 edits
    2 adds in trunk

Bad checkValidity result on recently "enabled" form fields
https://bugs.webkit.org/show_bug.cgi?id=85704

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/disabled-attr-checkvalidity.html

We were tripping on the assertion m_isValid == validity()->valid()
inside HTMLFormControlElement::isValidFormControlElement.
m_isValid was becoming stale because setNeedsValidityCheck wasn't called
after m_willValidate changed.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::willValidate): We used const_cast
because it was too difficult to remove const. We are checking if the
value from willValidate has changed to avoid an infinite loop.
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):

LayoutTests:

  • fast/forms/disabled-attr-checkvalidity-expected.txt: Added.
  • fast/forms/disabled-attr-checkvalidity.html: Added.
2:28 AM Changeset in webkit [118500] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r118448. Added rebaseline to 2 tests on Qt platform that
had 1 pixel differences because of rounding mistakes.

Patch by János Badics <János Badics> on 2012-05-25

  • platform/qt/fast/html/details-position-expected.txt:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
2:21 AM Changeset in webkit [118499] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Pasting text in input field is not available if <body> has visibility:hidden
https://bugs.webkit.org/show_bug.cgi?id=66754

Reviewed by Kent Tamura.

Add a regression test since this bug has been fixed by r99076.

  • editing/pasteboard/input-with-visibility-hidden-expected.txt: Copied from input-with-display-none-div-expected.txt.
  • editing/pasteboard/input-with-visibility-hidden.html: Copied from input-with-display-none-div.html.
2:21 AM Changeset in webkit [118498] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Pull in Android tools from Chromium's repo through the DEPS file
https://bugs.webkit.org/show_bug.cgi?id=87478

Reviewed by Kent Tamura.

Chromium's r122048 added the forwarder tool, which forwards a TCP port
listening on the device to a port on the host. This now is a required
dependency of DumpRenderTree, so pull it in.

Since it's likely that more tools will be required, pull in the entire
tools/android/ directory in case the Chromium port for Android is being
checked out or updated.

  • DEPS: Added Android-specific dependency on tools/android/
2:13 AM Changeset in webkit [118497] by kinuko@chromium.org
  • 4 edits in trunk

[chromium] DataTransferItem.webkitGetAsEntry() shouldn't be exposed without flag yet
https://bugs.webkit.org/show_bug.cgi?id=87457

Reviewed by Kent Tamura.

Source/WebCore:

No new tests, marking some tests SKIP as we stop exposing this by default.

  • Modules/filesystem/DataTransferItemFileSystem.idl: Removed webkitGetAsEntry

LayoutTests:

  • platform/chromium/test_expectations.txt: Marking tests using webkitGetAsEntry SKIP
2:01 AM Changeset in webkit [118496] by loislo@chromium.org
  • 2 edits in trunk/PerformanceTests

Web Inspector: HeapProfiler's perf test: each N-th run pushes the run results N-th times.
https://bugs.webkit.org/show_bug.cgi?id=87476

The time tracking wrappers were attaching on each run.

Reviewed by Yury Semikhatsky.

  • inspector/heap-snapshot.html:
1:51 AM Changeset in webkit [118495] by commit-queue@webkit.org
  • 6 edits in trunk

RadioNodeList does not include a object element
https://bugs.webkit.org/show_bug.cgi?id=87371

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-05-25
Reviewed by Kent Tamura.

Source/WebCore:

As per spec http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#category-listed
Object element should also be listed in RadioNodeList object.

Updated existing test.

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
Compares if test element's name/id and form matches that of the RadioNodeList filter.
(WebCore::RadioNodeList::nodeMatches):
Added support for Object element, check if object elements name/id matches the RadioNodeList filter.

  • html/RadioNodeList.h:

(RadioNodeList): Ditto

LayoutTests:

  • fast/forms/form-collection-radio-node-list-expected.txt:
  • fast/forms/form-collection-radio-node-list.html:

Updated test to include test for object element.

1:41 AM Changeset in webkit [118494] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Unreviewed fix after r118484.

Enable CSS_EXCLUSIONS and CSS_REGIONS.
They were enabled uncoditinally before r118484.

  • qmake/mkspecs/features/features.pri:
1:29 AM Changeset in webkit [118493] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt][WK2] Fix failing qmltests::FitToView::test_basic()
https://bugs.webkit.org/show_bug.cgi?id=87236

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-25
Reviewed by Kenneth Rohde Christiansen.

Rename contentViewportChanged to informVisibleContentChange() to
reflect its functionality better. Centralize m_hadUserInteraction flag
setting and add assertions on it to ensure that designated
functions are called only on user interaction.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_onInformVisibleContentChange):
(QQuickWebViewFlickablePrivate::_q_resume):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate::_q_onInformVisibleContentChange):
(QQuickWebViewFlickablePrivate):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::touchBegin):
(WebKit::QtViewportInteractionEngine::focusEditableArea):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::panGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

1:09 AM Changeset in webkit [118492] by caseq@chromium.org
  • 4 edits in trunk

Web Inspector: Resource object has no methods getContent and setContent
https://bugs.webkit.org/show_bug.cgi?id=87424

Source/WebCore:

This fixes the extension API so that it uses the new Resource()
constructor, which adds the missing getContent and setContent
methods to a Resource object.

Patch by Jan Keromnes <janx@linux.com> on 2012-05-25
Reviewed by Vsevolod Vlasov.

The tests were fixed accordingly in:
LayoutTests/inspector/extensions/extensions-resources-expected.txt

  • inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler.else.callbackWrapper):
(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler):

LayoutTests:

This fixes the expected test result for handleOpenResource(), see fix
for bug #87424 in Source/WebCore/inspector/front-end/ExtensionAPI.js.

Patch by Jan Keromnes <janx@linux.com> on 2012-05-25
Reviewed by Vsevolod Vlasov.

  • inspector/extensions/extensions-resources-expected.txt:
1:00 AM Changeset in webkit [118491] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/efl

[EFL] API for PageGroup visited links hash populating
https://bugs.webkit.org/show_bug.cgi?id=86370

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-25
Reviewed by Kenneth Rohde Christiansen.

Added "populate,visited,links" ewk_view signal that tells to the client managing
persistent history storage to fill the visited links cache.
Added API for the PageGroup visited links hash populating.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::populateVisitedLinks): Implementation added (sends notification).
(WebCore):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(ewk_view_visited_link_add): PageGroup visited links hash populating.

  • ewk/ewk_view.h:
12:56 AM Changeset in webkit [118490] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r118461.
http://trac.webkit.org/changeset/118461
https://bugs.webkit.org/show_bug.cgi?id=87468

Breaks two chromium browser_tests. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-25

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize):

12:41 AM Changeset in webkit [118489] by vsevik@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed chromium test expectations rebaseline.

  • platform/chromium-mac-leopard/editing/spelling/grammar-markers-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/spelling/grammar-markers-expected.png: Added.
  • platform/chromium-mac/editing/spelling/grammar-markers-expected.png: Added.
  • platform/chromium-win/editing/spelling/grammar-markers-expected.png: Added.
12:31 AM Changeset in webkit [118488] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

  • platform/qt/Skipped:
12:26 AM Changeset in webkit [118487] by commit-queue@webkit.org
  • 2 edits
    8 adds in trunk/LayoutTests

Add tests for JPEG and PNG images with a non-generic RGB color profile
https://bugs.webkit.org/show_bug.cgi?id=87437

No layout test currently covers a color transform except for the no-op case of a
Generic RGB profile (image) -> Generic RGB profile (screen) color transform. Add
tests for JPEG and PNG images with a non-identity color correction transform, in
particular, use test images with a (non-generic) RGB color profile.

Patch by Tony Payne <tpayne@chromium.org> on 2012-05-25
Reviewed by Kent Tamura.

  • fast/images/jpeg-with-color-profile-expected.txt: Added.
  • fast/images/jpeg-with-color-profile.html: Added.
  • fast/images/png-with-color-profile-expected.txt: Added.
  • fast/images/png-with-color-profile.html: Added.
  • fast/images/resources/red-at-12-oclock-with-color-profile.jpg: Added. The image

has an RGB color profile (non-generic). If color correction is correctly applied,
the image red sector appears at the 12 o'clock position. If color correction fails,
the red sector appears at 4 o'clock.

  • fast/images/resources/red-at-12-oclock-with-color-profile.png: Added, and ditto

for the expected image red sector position and image color profile type.

  • platform/chromium/test_expectations.txt: Add MISSING expectations.
  • platform/mac-snowleopard/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/mac-snowleopard/fast/images/png-with-color-profile-expected.png: Added.
12:22 AM Changeset in webkit [118486] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip a now passing test.

  • platform/qt/Skipped:
12:10 AM Changeset in webkit [118485] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip a passing test and mark it as SLOW.

  • platform/qt/Skipped:
  • platform/qt/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.