Timeline


and

06/04/12:

23:40 Changeset [119464] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG CFG simplification should correct the variables at the head of the predecessor block
https://bugs.webkit.org/show_bug.cgi?id=88284

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

LayoutTests:

  • fast/js/dfg-constant-fold-first-local-read-after-block-merge-expected.txt: Added.
  • fast/js/dfg-constant-fold-first-local-read-after-block-merge.html: Added.
  • fast/js/script-tests/dfg-constant-fold-first-local-read-after-block-merge.js: Added.

(foo):
(bar):

23:38 Changeset [119463] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Make a builder group support+expect multiple loads.
https://bugs.webkit.org/show_bug.cgi?id=88260

Change BuilderGroup to allow expecting multiple
loads. This allows merging results for a given set
of builders into one group.

Add a test that verifies that the group count
increments correctly based on successful and failed
list loads.

Patch by Chase Phillips <cmp@google.com> on 2012-06-04
Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.js:

(BuilderGroup):
(BuilderGroup.prototype.setbuilder):
(BuilderGroup.prototype.append):
(BuilderGroup.prototype.loaded):
(requestBuilderList.xhr.onload):
(requestBuilderList.xhr.onerror):
(onErrorLoadingBuilderList):
(loadBuildersList):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

  • TestResultServer/static-dashboards/run-unittests.html:
23:07 Changeset [119462] by eae@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed chromium windows rebaseline for r119456.

  • platform/chromium-win-vista/fast/multicol: Removed.
  • platform/chromium-win/fast/multicol/float-multicol-expected.png:
22:44 Changeset [119461] by eae@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed chromium test expectation updates for new tests.

  • fast/sub-pixel/inline-block-with-padding-expected.txt:
  • platform/chromium-mac/fast/sub-pixel: Added.
  • platform/chromium-mac/fast/sub-pixel/inline-block-with-padding-expected.txt: Added.
22:33 Changeset [119460] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fix a TestExpectations format error.

  • platform/chromium/TestExpectations:
22:20 Changeset [119459] by eae@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed chromium test and expectation updates for r119456.

  • fast/sub-pixel/inline-block-with-padding.html:
  • platform/chromium-mac-snowleopard/fast/events/offsetX-offsetY-expected.txt:
  • platform/chromium/TestExpectations:
22:06 LayoutUnit edited by eae@chromium.org
Updated status (diff)
22:01 Changeset [119458] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

Leaking ClipRects
https://bugs.webkit.org/show_bug.cgi?id=88282

Reviewed by Dan Bernstein.

In r118562 I made the ClipRectsCache use RefPtr<ClipRects>. However, ClipRects
was initialized with m_refCnt=0, not 1 as adoptRef() and friends expect. Also,
there was a manual ref() in RenderLayer::updateClipRects() which this patch removes.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateClipRects):

  • rendering/RenderLayer.h:

(WebCore::ClipRects::ClipRects):

21:49 Changeset [119457] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Python test fix attempt for Chromium Windows.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.uri_to_test):

21:42 Changeset [119456] by eae@chromium.org
  • 31 edits
    6 adds in trunk

Add missing FractionalLayoutUnit += operator and move LineWidth to use all floats
https://bugs.webkit.org/show_bug.cgi?id=88259

Patch by Emil A Eklund <eae@chromium.org> and Levi Weintraub <leviw@chromium.org> on 2012-06-04
Reviewed by Ryosuke Niwa.

Source/WebCore:

Fix two rounding bugs in LineLayout and RenderBlock that caused inlines
and floats to wrap incorrectly.

Tests: fast/sub-pixel/float-containing-block-with-margin.html

fast/sub-pixel/float-with-right-margin-zoom.html
fast/sub-pixel/inline-block-with-padding.html

  • platform/FractionalLayoutUnit.h:

(WebCore::operator+=):
Add missing float version of += operator thus avoiding a silent cast to
int loosing precision.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
(WebCore::LineWidth::updateAvailableWidth):
Change LineWidth left/right to floating point and instead of rounding the
left and right edge separately.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
Use explicit cast to avoid compiler ambiguity warning.

LayoutTests:

  • fast/dom/elementFromPoint-relative-to-viewport.html:
  • fast/events/offsetX-offsetY.html:

Remove special casing for subpixel layout as it is no longer needed.

  • fast/sub-pixel/float-containing-block-with-margin-expected.html: Added.
  • fast/sub-pixel/float-containing-block-with-margin.html: Added.
  • fast/sub-pixel/float-with-right-margin-zoom-expected.txt: Added.
  • fast/sub-pixel/float-with-right-margin-zoom.html: Added.
  • fast/sub-pixel/inline-block-with-padding-expected.txt: Added.
  • fast/sub-pixel/inline-block-with-padding.html: Added.

New tests for wrapping logic.

  • platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-linux/fast/line-grid/line-align-left-edges-expected.png:
  • platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.png:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.png:
  • platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
  • platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:

Update expectations to match pre-subpixel rendering.

  • platform/chromium/TestExpectations:

Mark updated tests as failing on mac and windows temporarily.

  • platform/chromium/fast/dom/elementFromPoint-relative-to-viewport-expected.txt:

Remove special casing for subpixel layout as it is no longer needed.

  • platform/chromium/fast/line-grid/line-align-left-edges-expected.txt:

Update expectations to match pre-subpixel rendering.

  • platform/efl/Skipped:
  • platform/gtk-wk2/Skipped:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:

Skip new sub-pixel tests on platforms that does not enable sub-pixel layout.

21:38 Changeset [119455] by tony@chromium.org
  • 14 edits in trunk

CSS property 'order' should be a number rather than an int
https://bugs.webkit.org/show_bug.cgi?id=88111

Reviewed by Ojan Vafai.

Source/WebCore:

This changed in the spec:
http://dev.w3.org/csswg/css3-flexbox/#order

I also fixed the compile with CSS3_FLEXBOX disabled.

No new tests, covered by existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp: Parse as float, remove clamping for HashMap<int>.

(WebCore::CSSProperty::isInheritedProperty):

  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderFlexibleBox.cpp: Remove traits for HashMap<int>.

(RenderFlexibleBox::OrderIterator):

  • rendering/RenderFlexibleBox.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html: Allow decimal values.
  • css3/flexbox/flex-order.html: Fix tests based on float limits.
21:29 Changeset [119454] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/LayoutTests

Syntax error in fast/filesystem/resources/file-writer-gc-blob.js
https://bugs.webkit.org/show_bug.cgi?id=87939

Reviewed by Alexey Proskuryakov.

  • fast/filesystem/resources/file-writer-gc-blob.js: Add parentheses around the blob data.

(startWrite):

21:11 FeatureFlags edited by tkent@chromium.org
Add LEGACY_VIEWPORT_ADAPTION (diff)
20:17 Changeset [119453] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Unreviewed.

Rolled out r119364 because it's still causing crashes (when running
v8-earley in release builds of DRT)

This time for sure!

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::resetAllocator):
(JSC):

  • heap/MarkedSpace.cpp:

(JSC::ResetAllocator::operator()):
(JSC):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::sweepWeakSets):

  • heap/MarkedSpace.h:

(MarkedSpace):

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::sweep):

  • heap/WeakSet.cpp:

(JSC::WeakSet::sweep):
(JSC::WeakSet::tryFindAllocator):

  • heap/WeakSet.h:

(JSC::WeakSet::shrink):

20:01 Changeset [119452] by commit-queue@webkit.org
  • 8 edits in trunk

Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
https://bugs.webkit.org/show_bug.cgi?id=88243

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-06-04
Reviewed by Adam Barth.

.:

  • Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

No new tests needed, this just rename a compiler flag.

  • dom/Document.cpp:

(WebCore::Document::setDocType):

  • dom/ViewportArguments.h:
  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

Tools:

  • qmake/mkspecs/features/features.prf:
19:13 Changeset [119451] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
https://bugs.webkit.org/show_bug.cgi?id=88280

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TestServerProcess.test_basic):

19:05 Changeset [119450] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip more tests on Windows to get the bots greener.

See r119449 for more context.

  • platform/win/Skipped:
18:10 Changeset [119449] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Start skipping all the failing tests on Windows to get the bots greener.

At this point it doesn't make sense to try to split the hundreds of failures out into
separate bugs and rebaseline. It makes more sense to use the Skipped list as a todo list
of things that need to be checked / updated for Windows.

18:10 Changeset [119448] by yosin@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebCore/css/SelectorChecker.cpp

Merge 118891 - REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled
https://bugs.webkit.org/show_bug.cgi?id=87719

Reviewed by Kent Tamura.

Source/WebCore:

This patch added checking of "option" element for CSS pseudo class :enabled as same as
:disabled to selector checker. Before r111497, it was done by using isFormControlElement.
After that revision, HTMLOptionElement was no longer derived from HTMLFormControlElement.

Test: fast/form/select/optgroup-rendering.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Checking element is option element as same
as PseudoDisabled in PseudoEnabled case.

LayoutTests:

  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Updated. Text color of option element is bule from CSS pseudo class option:enabled.
  • platform/chromium/test_expectations.txt: Update comment.

TBR=yosin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10477022

18:07 Changeset [119447] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Remove redundant setNeedsCommit when prepareToDraw fails
https://bugs.webkit.org/show_bug.cgi?id=88246

Reviewed by James Robinson.

Source/WebCore:

When prepareToDraw fails it explicitly calls setNeedsCommit, but the
scheduler already takes care of this for it. When a frame is not
successfully drawn, the scheduler state machine sets the needsCommit
bit itself.

This behaviour is covered by CCSchedulerStateMachineTest.TestFailedDrawSetsNeedsCommitAndDoesNotDrawAgain

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::prepareToDraw):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
17:51 Changeset [119446] by toyoshim@chromium.org
  • 4 edits
    1 add in trunk/Source

[WebSocket] Send requires super linear time against data size
https://bugs.webkit.org/show_bug.cgi?id=87383

Reviewed by Kent Tamura.

Source/WebCore:

WebSocket send operation requires super linear time to send data
against data size. This is because removing sent data in Vector<char>
always requires data copy.
Introduced wtf/StreamBuffer realizes O(n) buffer operations.
This patch is only for optimization. No new tests are needed.

  • platform/network/SocketStreamHandleBase.cpp:

(WebCore::SocketStreamHandleBase::sendPendingData):

  • platform/network/SocketStreamHandleBase.h:

(SocketStreamHandleBase):

Source/WTF:

  • wtf/StreamBuffer.h: Added.

(WTF):
(StreamBuffer):
(WTF::StreamBuffer::StreamBuffer):
(WTF::StreamBuffer::~StreamBuffer):
(WTF::StreamBuffer::isEmpty):
(WTF::StreamBuffer::append):
(WTF::StreamBuffer::consume):
(WTF::StreamBuffer::size):
(WTF::StreamBuffer::firstBlockData):
(WTF::StreamBuffer::firstBlockSize):

17:37 Changeset [119445] by dpranke@chromium.org
  • 3 edits in trunk/Tools

test-webkitpy is hanging under cygwin
https://bugs.webkit.org/show_bug.cgi?id=88269

Reviewed by Ryosuke Niwa.

The 'multiprocessing' module doesn't work correctly under Cygwin yet,
so we need to skip any tests that use it.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.run_in_parallel):

  • Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.test_run_in_parallel):

17:28 Changeset [119444] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG arguments simplification should have rationalized handling of TearOffArguments
https://bugs.webkit.org/show_bug.cgi?id=88206

Reviewed by Geoffrey Garen.

  • Accesses to the unmodified arguments register ought to have the same effect on alias/escape analysis of arguments as accesses to the mutable arguments register.


  • The existence of TearOffArguments should not get in the way of arguments aliasing.


  • TearOffArguments should be eliminated if CreateArguments is eliminated.
  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):

17:27 Changeset [119443] by dpranke@chromium.org
  • 4 edits
    1 add in trunk/Tools

test-webkitpy is failing on win32 after r115054
https://bugs.webkit.org/show_bug.cgi?id=88264

Reviewed by Ryosuke Niwa.

The failing http_server test was improperly suppressed (the
tuple was missing a comma, and so wasn't a tuple at all, just a
string) and so we were skipping *all* tests on win32. The right
way to skip a single test is to disable it inside the test
itself.

  • Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:

(TestHttpServer.test_start_cmd):

  • Scripts/webkitpy/test/test_finder.py:

(TestFinder._default_names):

  • Scripts/webkitpy/test/main.py:

(Tester.run): Add error message if we don't find any tests to run.

  • Scripts/webkitpy/test/main_unittest.py:
17:21 Changeset [119442] by timothy_horton@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed new baseline for test added in r119423.

  • platform/mac/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/mac/fast/hidpi/device-scale-factor-paint-expected.txt: Added.
17:00 Changeset [119441] by barraclough@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Remove enabledProfilerReference
https://bugs.webkit.org/show_bug.cgi?id=88258

Reviewed by Michael Saboff.

Make the enabled profiler a member of JSGlobalData, and switch code that accesses it to do so directly
via the JSGlobalData, rather than holding a Profiler reference to it. Do not pass the Profiler
reference to JIT code. This patch does not change the stack layout on entry into JIT code (passing an
unused void* instead), since this is an intrusive change better handled in a separate patch.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):

  • jit/JITCode.h:

(JSC::JITCode::execute):

  • Don't pass Profiler to JIT code.
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):

  • jit/JITStubs.cpp:

(JSC):
(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):
(JSC::JITThunks::JITThunks):
(JSC::DEFINE_STUB_FUNCTION):

  • For ARM_THUMB2, rename ENABLE_PROFILER_REFERENCE_OFFSET to FIRST_STACK_ARGUMENT (which is how it is being used).
  • For MIPS, remove ENABLE_PROFILER_REFERENCE_OFFSET.
  • jit/JITStubs.h:

(JITStackFrame):
(JSC):

  • Renamed enabledProfilerReference to unusedX.
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • profiler/Profiler.cpp:

(JSC):
(JSC::Profiler::startProfiling):
(JSC::Profiler::stopProfiling):

  • profiler/Profiler.h:

(Profiler):

  • Removed s_sharedEnabledProfilerReference, enabledProfilerReference().
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC):
(JSC::JSGlobalData::enabledProfiler):
(JSGlobalData):

  • Added m_enabledProfiler, enabledProfiler().
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::~JSGlobalObject):

16:45 Changeset [119440] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Mock scrollbars differ by 1px in DRT vs. WKTR
https://bugs.webkit.org/show_bug.cgi?id=80879

Rubber-stamped by Ryosuke Niwa.

Disable r119431 except for Apple Mac port.

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::thumbLength):

16:38 Changeset [119439] by jpfau@apple.com
  • 2 edits in trunk/Source/WebCore

Document cleanup can get confused if parser still exists
https://bugs.webkit.org/show_bug.cgi?id=88250

Reviewed by Geoffrey Garen.

No new tests; no behavior changes.

  • dom/Document.cpp:

(WebCore::Document::removedLastRef): Detach parser earlier

16:32 Changeset [119438] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

get_argument_by_val should be profiled everywhere
https://bugs.webkit.org/show_bug.cgi?id=88205

Reviewed by Geoffrey Garen.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_get_argument_by_val):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

16:27 Changeset [119437] by fpizlo@apple.com
  • 6 edits
    12 adds in trunk

DFG arguments simplification takes unkindly to direct accesses to the arguments register
https://bugs.webkit.org/show_bug.cgi?id=88261

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Fixed arguments simplification for direct accesses to the arguments register, which may
arise if CSE had not run. Fixed CSE so that it does run prior to arguments simplification,
by making it a full-fledged member of the fixpoint. Fixed other issues in arguments
simplification, like realizing that it needs to bail if there is a direct assignment to
the arguments register, and failing to turn CreateArguments into PhantomArguments. Also
fixed CSE's handling of store elimination of captured locals in the presence of a
GetMyArgumentByVal (or one of its friends), and fixed CSE to correctly fixup variables at
tail if the Flush it removes is the last operation on a local in a basic block.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(CSEPhase):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

LayoutTests:

Reviewed by Geoffrey Garen.

  • fast/js/dfg-arguments-alias-one-block-expected.txt: Added.
  • fast/js/dfg-arguments-alias-one-block-osr-exit-expected.txt: Added.
  • fast/js/dfg-arguments-alias-one-block-osr-exit.html: Added.
  • fast/js/dfg-arguments-alias-one-block-overwrite-arguments-expected.txt: Added.
  • fast/js/dfg-arguments-alias-one-block-overwrite-arguments.html: Added.
  • fast/js/dfg-arguments-alias-one-block-overwrite-expected.txt: Added.
  • fast/js/dfg-arguments-alias-one-block-overwrite.html: Added.
  • fast/js/dfg-arguments-alias-one-block.html: Added.
  • fast/js/script-tests/dfg-arguments-alias-one-block-osr-exit.js: Added.

(foo):

  • fast/js/script-tests/dfg-arguments-alias-one-block-overwrite-arguments.js: Added.

(foo):

  • fast/js/script-tests/dfg-arguments-alias-one-block-overwrite.js: Added.

(foo):

  • fast/js/script-tests/dfg-arguments-alias-one-block.js: Added.

(foo):

16:25 Changeset [119436] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[BlackBerry] Split AnimationFrameRateController into its own file
https://bugs.webkit.org/show_bug.cgi?id=88242

Patch by Andrew Lo <anlo@rim.com> on 2012-06-04
Reviewed by Antonio Gomes.

Include new header file to reflect re-organization of platform animation
header files.

Source/WebCore:

  • platform/graphics/DisplayRefreshMonitor.h:

Source/WebKit/blackberry:

  • Api/WebPageCompositor_p.h:
16:19 Changeset [119435] by danakj@chromium.org
  • 11 edits in trunk/Source

[chromium] Allow CCLayerImpl to find its layer tree host, and use this for CCVideoLayerImpl instead of always-null pointer.
https://bugs.webkit.org/show_bug.cgi?id=88252

Reviewed by James Robinson.

Source/WebCore:

CCVideoLayerImpl has a pointer to its CCLayerTreeHostImpl which is never
set to be non-null currently. Instead of making this a special case, we
move the CCLayerTreeHostImpl* up to the CCLayerImpl base class, and set
the pointer on every layer during commit via the TreeSynchronizer's walk
through the layer tree.

Unit tests: Tested by TreeSynchronizer tests.

  • platform/graphics/chromium/TreeSynchronizer.cpp:

(WebCore::TreeSynchronizer::synchronizeTrees):
(WebCore::TreeSynchronizer::synchronizeTreeRecursive):

  • platform/graphics/chromium/TreeSynchronizer.h:

(WebCore):
(TreeSynchronizer):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):
(WebCore::CCLayerImpl::layerTreeHostImpl):
(WebCore::CCLayerImpl::setLayerTreeHostImpl):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

Source/WebKit/chromium:

  • tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::TEST):

  • tests/TreeSynchronizerTest.cpp:

(WebKitTests::expectTreesAreIdentical):
(WebKitTests::TEST):

16:03 Changeset [119434] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

yet another build fix attempt.

  • src/WebHelperPluginImpl.cpp:
15:52 Changeset [119433] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Another Chromium Windows build fix attempt after r119411.

  • src/WebHelperPluginImpl.cpp:
15:26 Changeset [119432] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] CCDamageTrackerTest.verifyDamageForPerspectiveClippedLayer needs to be cleaner
https://bugs.webkit.org/show_bug.cgi?id=85245

Reviewed by James Robinson.

Updated CCDamageTrackerTest.verifyDamageForPerspectiveClippedLayer
so that the test is clearer and cleaner. The original test was
covering what it needed, but in a confusing and not-so-practical
way. This patch adds comments and performs a tighter test so that
the intent is a bit more clear.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

15:25 Changeset [119431] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Mock scrollbars differ by 1px in DRT vs. WKTR
https://bugs.webkit.org/show_bug.cgi?id=80879

Reviewed by Simon Fraser.

Round the length of the scrollbar thumb instead of truncating it.

No new tests, fixes a mismatch between pixel results from DRT and WKTR.
Change is covered by all existing tests with scrollbars run with low tolerance.

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::thumbLength):

15:24 Changeset [119430] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix an unused result warning when building with clang.

  • platform/cf/BinaryPropertyList.cpp:

(WebCore::BinaryPropertyListWriter::writePropertyList):

14:56 Changeset [119429] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix a struct/class mismatch.

  • heap/Handle.h:

(Handle):

14:47 Changeset [119428] by fischman@chromium.org
  • 3 edits
    2 adds in trunk

Don't crash when re-parenting a removed HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=88058

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-reparent.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::userCancelledLoad): Clear the pending load flags because any pending load has been cancelled.

LayoutTests:

  • media/media-reparent-expected.txt: Added.
  • media/media-reparent.html: Added.
14:41 Changeset [119427] by jchaffraix@webkit.org
  • 1 edit in branches/chromium/1132/Source/WebCore/rendering/FixedTableLayout.cpp

Merge 118819 - REGRESSION(r111742): box-sizing: border-box doesn't work on fixed table layout
https://bugs.webkit.org/show_bug.cgi?id=87536

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout.html

fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout.html
fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout.html
fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout.html

The change in r111742 completely ignored border-sizing (following the table's code lead unfortunately).
The issue is that we would count the borders and paddings twice for the border-box case which would lead
to the content-box including them too. From a web-author, this behavior is equivalent to ignoring box-sizing.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
Reworked the function to properly use computeBorderBoxLogicalWidth() for correctness. This matches
what RenderBox and the rendering code does generally. Also refactored the code to avoid the need
for local variables and make it more readable.

LayoutTests:

  • fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout.html: Added.

This test covers the regression.

  • fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout.html: Added.
  • fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout.html: Added.
  • fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout.html: Added.

Those test ensured I didn't regress and document our current behavior ie that column and column group fixed
width apply to the cell's border-box.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10479019

14:35 Changeset [119426] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r119421 and r119425.
http://trac.webkit.org/changeset/119421
http://trac.webkit.org/changeset/119425
https://bugs.webkit.org/show_bug.cgi?id=88256

not reliable, let's have a do-over (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-04

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::createAttributeData):
(WebCore):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::cloneAttributesFromElement):

  • dom/Element.h:

(WebCore::Element::attributeData):
(Element):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::setClass):
(WebCore):
(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::destroyInlineStyle):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::isEquivalent):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute):
(WebCore::ElementAttributeData::getAttributeNode):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::create):
(ElementAttributeData):
(WebCore::ElementAttributeData::setIdForStyleResolution):
(WebCore::ElementAttributeData::setAttributeStyle):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(WebCore::ElementAttributeData::getAttributeItemIndex):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::style):
(WebCore::StyledElement::classAttributeChanged):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

13:23 Changeset [119425] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fixes for cr-android and Qt.

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::setClass):
Change ElementAttributeData::setClass() to take an AtomicString instead of a String.
The only call site has an AtomicString anyway.

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser): Add missing const.

13:14 Changeset [119424] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Fix attempt after r119411.

  • src/WebHelperPluginImpl.cpp:
13:11 Changeset [119423] by commit-queue@webkit.org
  • 15 edits
    3 adds in trunk

.: [chromium] Fix software rendering for device-scale-factor > 1
https://bugs.webkit.org/show_bug.cgi?id=88136

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

Export WebCore::Page::setDeviceScaleFactor and WebCore::Settings::setDefaultDeviceScaleFactor.

  • Source/autotools/symbols.filter:

Source/WebCore: [chromium] Fix software rendering for device-scale-factor > 1
https://bugs.webkit.org/show_bug.cgi?id=88136

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

Test: fast/hidpi/device-scale-factor-paint.html

  • WebCore.exp.in:
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setDeviceScaleFactor):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium: [chromium] Fix software rendering for larger device-scale-factor
https://bugs.webkit.org/show_bug.cgi?id=88136

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

The fix is to apply the device-scale factor on the GraphicsContext.
(and add a WebWidgetClient::deviceScaleFactor method to facilitate that).

  • public/WebWidgetClient.h:

(WebWidgetClient):
(WebKit::WebWidgetClient::deviceScaleFactor):

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::paint):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::paint):

Source/WebKit2: [chromium] Fix software rendering for device-scale-factor > 1
https://bugs.webkit.org/show_bug.cgi?id=88136

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

Export WebCore::Page::setDeviceScaleFactor and WebCore::Settings::setDefaultDeviceScaleFactor.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests: [chromium] Fix software rendering for device-scale-factor > 1
https://bugs.webkit.org/show_bug.cgi?id=88136

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

  • fast/hidpi/device-scale-factor-paint.html: Added.
  • platform/chromium/fast/hidpi/device-scale-factor-paint-expected.html: Added.
13:10 Changeset [119422] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Memory leaks in AccessibilityUIElementGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=88215

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-04
Reviewed by Martin Robinson.

Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
for newly allocated strings.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(attributeSetToString):
(AccessibilityUIElement::allAttributes):

13:00 Changeset [119421] by kling@webkit.org
  • 8 edits in trunk/Source/WebCore

Make ElementAttributeData a variable-sized object to reduce memory use.
<http://webkit.org/b/88240>

Reviewed by Antti Koivisto.

Take advantage of the fact that we know at ElementAttributeData construction time how many attributes
it needs to accomodate and allocate exactly as much space as needed instead of using a Vector.
For elements that never have their attribute list mutated (the vast majority), this saves a lot of
memory and removes the indirection to Vector<Attribute>'s heap-allocated storage.

Introduced a mutability flag to ElementAttributeData and sprinkled assertions all over to make sure
that nothing tries to mutate an element with a raw attribute array.

When an Element's attribute(s) are mutated, we reconstruct the ElementAttributeData, this time using
a Vector as backing instead. This is triggered when calling Element::mutableAttributeData().

This reduces memory consumption by 3.2MB when viewing the full HTML5 spec at <http://whatwg.org/c/>.
This is a 35% reduction in DOM attribute memory use.

Furthermore, that page ends up promoting 27% of the elements to mutable attribute storage due to dynamic
adding of "class" attributes. For more static pages, savings are even greater.

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createMutableAttributeData):

  • dom/Element.h:

(WebCore::Element::attributeData):
(Element):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):
(WebCore::Element::mutableAttributeData):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::ElementAttributeData::~ElementAttributeData):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::destroyInlineStyle):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::isEquivalent):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute):
(WebCore::ElementAttributeData::getAttributeNode):

  • dom/ElementAttributeData.h:

(ElementAttributeData):
(WebCore::ElementAttributeData::setClass):
(WebCore::ElementAttributeData::setIdForStyleResolution):
(WebCore::ElementAttributeData::inlineStyle):
(WebCore::ElementAttributeData::setAttributeStyle):
(WebCore::ElementAttributeData::isMutable):
(WebCore::ElementAttributeData::makeMutable):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::array):
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::style):
(WebCore::StyledElement::classAttributeChanged):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

12:56 Changeset [119420] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Source/WebCore: [chromium] Combobox options and autofill options should not be scaled for device-scale factor
https://bugs.webkit.org/show_bug.cgi?id=87921

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

Chrome takes care of scaling the combobox/autofill lists in the browser side. So it is not
necessary to scale here. This change reverts parts of changes in r111539.

Manually tested with different scale factors.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupListBox.h:

(PopupContainerSettings):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupMenuChromium::show):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

Source/WebKit/chromium: Combobox options and autofill options should not be scaled for device-scale factor.
https://bugs.webkit.org/show_bug.cgi?id=87921

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyAutofillSuggestions):

12:53 Changeset [119419] by danakj@chromium.org
  • 19 edits
    2 moves in trunk/Source

[chromium] Make LayerRendererChromium use RenderPasses instead of RenderSurfaces
https://bugs.webkit.org/show_bug.cgi?id=88132

Reviewed by Adrienne Walker.

Source/WebCore:

This patch is partly renaming, partly moving data into CCRenderPass
and CCRenderPassDrawQuad. LayerRendererChromium should accept as input
a set of RenderPasses and this should be sufficient for drawing. It
should have no notion of RenderSurfaces at all.

First, what isn't done: RenderSurfaces still hold the textures
where RenderPasses are drawn to/from, so that these textures can
persist across frames. This will be addressed separately.

Otherwise, this completely removes the concept of RenderSurface from
LayerRenderChromium and the CCDrawQuad, replacing it with RenderPass.
The "renderSurfaceTextureManager" is renamed to the "implTextureManager"
and like-wise for the TextureAllocator, as these are not used
exclusively for render surfaces (passes), and a texture manager for
render passes that does not require a RenderSurface* will be the focus
of future changes.

Covered by existing tests.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::setVisible):
(WebCore::LayerRendererChromium::releaseRenderPassTextures):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::clearRenderPass):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::copyPlaneToTexture):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::isCurrentRenderPass):
(WebCore::LayerRendererChromium::useRenderPass):
(WebCore::LayerRendererChromium::useManagedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawFramebufferRect):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::renderPassProgram):
(WebCore::LayerRendererChromium::renderPassProgramAA):
(WebCore::LayerRendererChromium::renderPassMaskProgram):
(WebCore::LayerRendererChromium::renderPassMaskProgramAA):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:
  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::CCRenderPass):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):
(WebCore::CCRenderPass::framebufferOutputRect):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp.

(WebCore):
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h.

(WebCore):
(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPass):
(WebCore::CCRenderPassDrawQuad::isReplica):
(WebCore::CCRenderPassDrawQuad::maskTextureId):
(WebCore::CCRenderPassDrawQuad::filters):
(WebCore::CCRenderPassDrawQuad::backgroundFilters):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::prepareBackgroundTexture):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::willDraw):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::reserveTextures):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):
(FakeCCRendererClient::rootRenderPass):
(FakeCCRendererClient):
(TEST_F):

12:52 Changeset [119418] by commit-queue@webkit.org
  • 2 edits in trunk

[chromium] Issue async events for console.time/timeEnd
https://bugs.webkit.org/show_bug.cgi?id=88003

Patch by Kevin Greer <kgr@chromium.org> on 2012-06-04
Reviewed by Pavel Feldman.

  • ../../Source/WebCore/page/Console.cpp:
12:36 Changeset [119417] by aestes@apple.com
  • 6 edits in trunk/Source/WebKit2

Use ENABLE() and USE() macros in a few more places
https://bugs.webkit.org/show_bug.cgi?id=88245

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPluginSiteDataManager.cpp: Only include npapi.h if

Netscape plug-in API is enabled.

  • UIProcess/mac/CorrectionPanel.h: Wrap with USE(AUTOCORRECTION_PANEL)
  • WebProcess/Authentication/AuthenticationManager.cpp: Use the stub

version of tryUsePlatformCertificateInfoForChallenge if
Security.framework isn't available.

  • WebProcess/WebProcess.messages.in: Only generate two messages if

Security.framework is available.

  • WebProcess/mac/KeychainItemShimMethods.mm: Wrap with

USE(SECURITY_FRAMEWORK).

12:30 Changeset [119416] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Memory leaks in DumpRenderTree.cpp
https://bugs.webkit.org/show_bug.cgi?id=88213

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-04
Reviewed by Martin Robinson.

Fixed memory leaks in DumpRenderTree.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(appendString): Accepts const gchar* as the second argument.
(dumpFramesAsText): Free the string returned by g_strdup_printf().
(dumpHistoryItem): Free the string returned by g_uri_parse_scheme().

12:26 Changeset [119415] by fischman@chromium.org
  • 2 edits in trunk/LayoutTests

[Gtk] http/tests/media/video-buffered.html is failing after r119268
https://bugs.webkit.org/show_bug.cgi?id=88138

Reviewed by Eric Carlson.

  • http/tests/media/video-buffered.html:
12:22 Changeset [119414] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Speed up video-media-source-play & video-media-source-seek LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=87986

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-06-04
Reviewed by Eric Carlson.

  • http/tests/media/media-source/video-media-source-play.html: Updated test to only play 1 second of media data instead of ~3 seconds.
  • http/tests/media/media-source/video-media-source-seek-expected.txt:
  • http/tests/media/media-source/video-media-source-seek.html:
    • Triggers seek after playing 0.5 seconds instead of 2 seconds.
    • Seeks to the last segment instead of a segment that is ~2 seconds from the end.
    • Added an webkitSourceAbort() call before appending the segments for the seek. This is to prevent this test from failing when the old v0.3 "flush on seek" behavior is removed from the Chromium code.
12:21 Changeset [119413] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

Add stub WebKit2 implementations of PLUGIN_PROXY_FOR_VIDEO methods declared in FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=88244

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createMediaPlayerProxyPlugin): Add a stub implementation.
(WebKit::WebFrameLoaderClient::hideMediaPlayerProxyPlugin): Ditto.
(WebKit::WebFrameLoaderClient::showMediaPlayerProxyPlugin): Ditto.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
12:14 Changeset [119412] by paroga@webkit.org
  • 2 edits in trunk/Source/WTF

Port RAMSize to WinCE
https://bugs.webkit.org/show_bug.cgi?id=87854

Reviewed by Geoffrey Garen.

WinCE has no GlobalMemoryStatusEx() function. Use GlobalMemoryStatus() instead.

  • wtf/RAMSize.cpp:

(WTF::computeRAMSize):

12:03 Changeset [119411] by commit-queue@webkit.org
  • 14 edits
    1 copy
    2 adds in trunk

Enable Chromium media player to instantiate a plugin
https://bugs.webkit.org/show_bug.cgi?id=87399

Patch by David Dorwin <ddorwin@chromium.org> on 2012-06-04
Reviewed by Kent Tamura.

Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebHelperPlugin.h: Copied from Source/WebKit/chromium/public/WebPopupType.h.

(WebKit):
(WebHelperPlugin):
(WebKit::WebHelperPlugin::~WebHelperPlugin):

  • public/WebMediaPlayerClient.h:

(WebKit):

  • public/WebPopupType.h:
  • public/WebView.h:
  • public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::initializeHelperPluginWebFrame):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::WebFrameImpl):
(WebKit::WebFrameImpl::initializeAsMainFrame):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebHelperPluginImpl.cpp: Added.

(WebKit):
(WebKit::addString):
(WebKit::writeDocument):
(HelperPluginChromeClient):
(WebKit::HelperPluginChromeClient::HelperPluginChromeClient):
(WebKit::WebHelperPluginImpl::WebHelperPluginImpl):
(WebKit::WebHelperPluginImpl::~WebHelperPluginImpl):
(WebKit::WebHelperPluginImpl::init):
(WebKit::WebHelperPluginImpl::initializeFrame):
(WebKit::WebHelperPluginImpl::initPage):
(WebKit::WebHelperPluginImpl::setCompositorSurfaceReady):
(WebKit::WebHelperPluginImpl::composite):
(WebKit::WebHelperPluginImpl::layout):
(WebKit::WebHelperPluginImpl::setFocus):
(WebKit::WebHelperPluginImpl::close):
(WebKit::WebHelperPluginImpl::closeHelperPlugin):
(WebKit::WebHelperPlugin::create):

  • src/WebHelperPluginImpl.h: Copied from Source/WebKit/chromium/public/WebPopupType.h.

(WebCore):
(WebKit):
(WebHelperPluginImpl):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::createHelperPlugin):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::closeHelperPlugin):

  • src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::initializeMainFrame):
(WebKit::WebViewImpl::initializeHelperPluginFrame):
(WebKit):
(WebKit::WebViewImpl::createHelperPlugin):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createPopupMenu):

11:30 Changeset [119410] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Remove obsolete acceptMIMETypes member.
https://bugs.webkit.org/show_bug.cgi?id=88241

Patch by Raymes Khoury <raymes@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

Obsoleted by https://bugs.webkit.org/show_bug.cgi?id=87271 and http://codereview.chromium.org/10414085/.

  • public/WebFileChooserParams.h:

(WebFileChooserParams):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel):

11:06 Changeset [119409] by inferno@chromium.org
  • 3 edits
    4 adds in trunk

Crash in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=88022

Reviewed by Ojan Vafai.

Source/WebCore:

The patch addresses two problems::

  1. |this| in RenderBlock::splitBlocks can get destroyed when we

move its children to the clone and later call updateBeforeAfterContent
on the parent. So, we stop accessing its member variables and cache
it in a local.

  1. Positioned objects were not getting cleared from our grand parents.

This will happen if our immediate children got moved to a clone tree,
however at our parent nothing was moved. So, we make sure to remove
the positioned objects at every level while we are doing the cloning.

Tests: fast/multicol/span/empty-anonymous-block-split-crash.html

fast/multicol/span/positioned-objects-not-removed-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

  • fast/multicol/span/empty-anonymous-block-split-crash-expected.txt: Added.
  • fast/multicol/span/empty-anonymous-block-split-crash.html: Added.
  • fast/multicol/span/positioned-objects-not-removed-crash-expected.txt: Added.
  • fast/multicol/span/positioned-objects-not-removed-crash.html: Added.
11:04 Changeset [119408] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

Mac build fails with SVG disabled
https://bugs.webkit.org/show_bug.cgi?id=88165

Reviewed by Dirk Schulze.

Wrap all of SVGCSSPropertyNames in #if ENABLE(SVG),
and mark an unused argument in collectMatchingRulesForList.

  • css/SVGCSSPropertyNames.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

11:01 Changeset [119407] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX: Unused variable with ENABLE(CONTEXT_MENUS) off

This broke in r118374.

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu): Add
UNUSED_PARAM(exec) when ENABLE(CONTEXT_MENUS) is off.

10:07 Changeset [119406] by tony@chromium.org
  • 2 edits
    10 moves in trunk/LayoutTests

Rename CSS flexbox test files to match new property names
https://bugs.webkit.org/show_bug.cgi?id=88174

Reviewed by Ojan Vafai.

flex-pack became justify-content and flex-line-pack became
align-content. Rename the tests to match the new names.

  • css3/flexbox/flex-justify-content-expected.txt: Renamed from LayoutTests/css3/flexbox/flex-pack-expected.txt.
  • css3/flexbox/flex-justify-content.html: Renamed from LayoutTests/css3/flexbox/flex-pack.html.
  • css3/flexbox/multiline-align-content-expected.txt: Renamed from LayoutTests/css3/flexbox/multiline-line-pack-expected.txt.
  • css3/flexbox/multiline-align-content-horizontal-column-expected.txt: Renamed from LayoutTests/css3/flexbox/multiline-line-pack-horizontal-column-expected.txt.
  • css3/flexbox/multiline-align-content-horizontal-column.html: Renamed from LayoutTests/css3/flexbox/multiline-line-pack-horizontal-column.html.
  • css3/flexbox/multiline-align-content.html: Renamed from LayoutTests/css3/flexbox/multiline-line-pack.html.
  • css3/flexbox/multiline-align-self-expected.txt: Renamed from LayoutTests/css3/flexbox/multiline-align-expected.txt.
  • css3/flexbox/multiline-align-self.html: Renamed from LayoutTests/css3/flexbox/multiline-align.html.
  • css3/flexbox/multiline-justify-content-expected.txt: Renamed from LayoutTests/css3/flexbox/multiline-pack-expected.txt.
  • css3/flexbox/multiline-justify-content.html: Renamed from LayoutTests/css3/flexbox/multiline-pack.html.
  • platform/chromium/TestExpectations:
10:05 Changeset [119405] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Fix a couple flexbox tests to use flex-start and flex-end
https://bugs.webkit.org/show_bug.cgi?id=88170

Reviewed by Ojan Vafai.

This test was still using start/end for align-self, which fallback
to stretch. The test still passed because it is testing that all
values of align-self behave the same and stretch produced the same
behavior as flex-start/flex-end.

  • css3/flexbox/cross-axis-scrollbar.html:
09:05 Changeset [119404] by mario@webkit.org
  • 7 edits
    2 adds in trunk

[GTK][WK2] Implement geolocation provider for the GTK port
https://bugs.webkit.org/show_bug.cgi?id=83877

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Add a new client-based geolocation provider for WebKit2GTK+, relying the
new Geoclue-based geolocation provider available in WebCore.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UIProcess/API/gtk/WebKitGeolocationProvider.cpp: Added.

(toGeolocationProvider):
(startUpdatingCallback):
(stopUpdatingCallback):
(WebKitGeolocationProvider::~WebKitGeolocationProvider):
(WebKitGeolocationProvider::create):
(WebKitGeolocationProvider::WebKitGeolocationProvider):
(WebKitGeolocationProvider::startUpdating):
(WebKitGeolocationProvider::stopUpdating):
(WebKitGeolocationProvider::notifyPositionChanged):
(WebKitGeolocationProvider::notifyErrorOccurred):

  • UIProcess/API/gtk/WebKitGeolocationProvider.h: Added.
  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(_WebKitWebContextPrivate):
(createDefaultWebContext):

Tools:

  • gtk/generate-gtkdoc:

(get_webkit2_options): Ignore WebKitGeolocationProvider files.

09:02 Changeset [119403] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r119393.
http://trac.webkit.org/changeset/119393
https://bugs.webkit.org/show_bug.cgi?id=88236

Test is incorrect (duplicate content) and is causing Chromium
failures (Requested by schenney on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-04

Source/WebCore:

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

LayoutTests:

  • fast/canvas/drawImage-clipped-source-expected.txt: Removed.
  • fast/canvas/drawImage-clipped-source.html: Removed.
  • fast/canvas/drawImage-clipped-source.js: Removed.
08:50 Changeset [119402] by pdr@google.com
  • 4 edits in trunk/LayoutTests

Update test expectations after 119392
https://bugs.webkit.org/show_bug.cgi?id=88230

Unreviewed update of test expectations.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
08:42 Changeset [119401] by commit-queue@webkit.org
  • 30 edits in trunk/Source

[chromium] Cleanup scissor rect computation/use with damage
https://bugs.webkit.org/show_bug.cgi?id=87167

Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-04
Reviewed by Adrienne Walker.

Source/WebCore:

Performing scissorRect computation during
calculateRenderPasses. Storing scissorRect in shared quad state
instead of computing it during drawQuad. Added scissorRect fields
into layers and render surfaces.

Covered by existing layout tests. Introduced more unit tests to
test end-to-end drawing using mock graphic context, and added more
test cases to CCLayerTreeHostCommon to verify scissorRect computation.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::scissorRect):
(WebCore::LayerChromium::setScissorRect):
(LayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::computeRootScissorRectInCurrentSurface):
(WebCore):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::scissorRect):
(WebCore::RenderSurfaceChromium::setScissorRect):
(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::scissorRect):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::createSharedQuadState):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::scissorRect):
(WebCore::CCLayerImpl::setScissorRect):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore):
(WebCore::calculateLayerScissorRect):
(WebCore::calculateSurfaceScissorRect):
(WebCore::calculateDrawTransformsInternal):
(WebCore::calculateVisibleAndScissorRectsInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):
(WebCore::CCLayerTreeHostCommon::calculateVisibleAndScissorRects):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::swapBuffers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore):
(WebCore::CCRenderSurface::computeRootScissorRectInCurrentSurface):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):
(WebCore::CCRenderSurface::setScissorRect):
(WebCore::CCRenderSurface::scissorRect):

  • platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp:

(WebCore::CCRenderSurfaceDrawQuad::create):
(WebCore::CCRenderSurfaceDrawQuad::CCRenderSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h:

(CCRenderSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

  • platform/graphics/chromium/cc/CCSharedQuadState.cpp:

(WebCore::CCSharedQuadState::create):
(WebCore::CCSharedQuadState::CCSharedQuadState):

  • platform/graphics/chromium/cc/CCSharedQuadState.h:

(CCSharedQuadState):
(WebCore::CCSharedQuadState::scissorRect):

Source/WebKit/chromium:

Added unit tests to CCLayerTreeHostImpl using mock graphic context
to verify end-to-end quad drawing.

Added more test cases to CCLayerTreeHostCommon to verify clip and
scissor rect computations.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::executeCalculateDrawTransformsAndVisibility):

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):

  • tests/CCRenderSurfaceTest.cpp:
08:30 Changeset [119400] by commit-queue@webkit.org
  • 13 edits
    2 moves in trunk/Source/WebKit2

[Qt][WK2] Rename QtViewportInteractionEngine to QtViewportHandler.
https://bugs.webkit.org/show_bug.cgi?id=88226

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-06-04
Reviewed by Kenneth Rohde Christiansen.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage_p_p.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::~QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):

  • UIProcess/API/qt/qquickwebview_p.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(WebKit):
(QQuickWebViewPrivate::viewportHandler):
(QQuickWebViewFlickablePrivate::viewportHandler):
(QQuickWebViewFlickablePrivate):

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::contentsScale):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::initialScale):
(QWebKitTest::minimumScale):
(QWebKitTest::maximumScale):
(QWebKitTest::isScalable):
(QWebKitTest::layoutSize):

  • UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::viewportHandler):

  • UIProcess/qt/QtGestureRecognizer.h:

(WebKit):

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::update):
(WebKit::QtPanGestureRecognizer::finish):
(WebKit::QtPanGestureRecognizer::cancel):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::update):
(WebKit::QtPinchGestureRecognizer::finish):
(WebKit::QtPinchGestureRecognizer::cancel):

  • UIProcess/qt/QtViewportHandler.cpp: Copied from Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp.

(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(ViewportUpdateDeferrer):
(WebKit::QtViewportHandler::suspendPageContent):
(WebKit::QtViewportHandler::resumePageContent):
(WebKit::QtViewportHandler::cssScaleFromItem):
(WebKit::QtViewportHandler::itemScaleFromCSS):
(WebKit::QtViewportHandler::itemCoordFromCSS):
(WebKit::QtViewportHandler::itemRectFromCSS):
(WebKit::QtViewportHandler::QtViewportHandler):
(WebKit::QtViewportHandler::~QtViewportHandler):
(WebKit::QtViewportHandler::innerBoundedCSSScale):
(WebKit::QtViewportHandler::outerBoundedCSSScale):
(WebKit::QtViewportHandler::viewportAttributesChanged):
(WebKit::QtViewportHandler::pageContentsSizeChanged):
(WebKit::QtViewportHandler::setPageItemRectVisible):
(WebKit::QtViewportHandler::animatePageItemRectVisible):
(WebKit::QtViewportHandler::flickMoveStarted):
(WebKit::QtViewportHandler::flickMoveEnded):
(WebKit::QtViewportHandler::pageItemPositionChanged):
(WebKit::QtViewportHandler::pageContentPositionRequested):
(WebKit::QtViewportHandler::scaleAnimationStateChanged):
(WebKit::QtViewportHandler::scaleAnimationValueChanged):
(WebKit::QtViewportHandler::touchBegin):
(WebKit::QtViewportHandler::touchEnd):
(WebKit::QtViewportHandler::computePosRangeForPageItemAtScale):
(WebKit::QtViewportHandler::focusEditableArea):
(WebKit::QtViewportHandler::zoomToAreaGestureEnded):
(WebKit::QtViewportHandler::nearestValidBounds):
(WebKit::QtViewportHandler::setCSSScale):
(WebKit::QtViewportHandler::currentCSSScale):
(WebKit::QtViewportHandler::scrollAnimationActive):
(WebKit::QtViewportHandler::panGestureActive):
(WebKit::QtViewportHandler::panGestureStarted):
(WebKit::QtViewportHandler::panGestureRequestUpdate):
(WebKit::QtViewportHandler::panGestureEnded):
(WebKit::QtViewportHandler::panGestureCancelled):
(WebKit::QtViewportHandler::scaleAnimationActive):
(WebKit::QtViewportHandler::cancelScrollAnimation):
(WebKit::QtViewportHandler::interruptScaleAnimation):
(WebKit::QtViewportHandler::pinchGestureActive):
(WebKit::QtViewportHandler::pinchGestureStarted):
(WebKit::QtViewportHandler::pinchGestureRequestUpdate):
(WebKit::QtViewportHandler::pinchGestureEnded):
(WebKit::QtViewportHandler::pinchGestureCancelled):
(WebKit::QtViewportHandler::visibleContentsRect):
(WebKit::QtViewportHandler::informVisibleContentChange):
(WebKit::QtViewportHandler::viewportItemSizeChanged):
(WebKit::QtViewportHandler::scaleContent):

  • UIProcess/qt/QtViewportHandler.h: Copied from Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h.

(QtViewportHandler):

  • UIProcess/qt/QtViewportInteractionEngine.cpp: Removed.
  • UIProcess/qt/QtViewportInteractionEngine.h: Removed.
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::setViewportHandler):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):
(WebKit::QtWebPageEventHandler::didFindZoomableArea):

  • UIProcess/qt/QtWebPageEventHandler.h:

(WebKit):
(QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::viewportHandler):

08:30 Changeset [119399] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove SelectorQueryCacheEntry from SelectorQuery.h
https://bugs.webkit.org/show_bug.cgi?id=88204

Reviewed by Hajime Morita.

As anttik@ pointed out in https://bugs.webkit.org/show_bug.cgi?id=87942#c15,
we can remove SelectorQueryCacheEntry by having SelectorQuery hold CSSSelectorList.

Tests: fast/dom/SelectorAPI/* No change in test results.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQueryCache::add):

  • dom/SelectorQuery.h:

(SelectorQuery):
(SelectorQueryCache):

08:18 Changeset [119398] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Memory leak in PasteboardHelper
https://bugs.webkit.org/show_bug.cgi?id=88216

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-04
Reviewed by Martin Robinson.

Fixed a memory leak in PasteboardHelper by using adoptRef instead
of just getting a new reference of TargetList.

No new tests because of no behavior changes.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::dropAtomsForContext):

08:15 Changeset [119397] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Memory leak in WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=88214

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-04
Reviewed by Martin Robinson.

Fixed a memory leak in WebKitWebView by making
GeolocationClientMock to be owned by the WebView.

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

  • webkit/webkitwebviewprivate.h:
08:00 Changeset [119396] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

Hit ASSERT when editing attribute value in Element in SVG Document
https://bugs.webkit.org/show_bug.cgi?id=88179

Patch by Rob Buis <rbuis@rim.com> on 2012-06-04
Reviewed by Pavel Feldman.

Make sure the <span> is created as a HTML Element regardless of document in use.

  • inspector/InspectorDOMAgent.cpp:

(WebCore):
(WebCore::InspectorDOMAgent::setAttributesAsText):

07:57 Changeset [119395] by yosin@chromium.org
  • 18 edits in trunk/Source/WebCore

[Forms] Change function and variable names independent from "double" type
https://bugs.webkit.org/show_bug.cgi?id=88220

Reviewed by Kent Tamura.

This patch is a part of introducing decimal arithmetic to input type.

This patch renames function and variable names which contain term "double"
to "number" to separate concept and implementation.

No new tests. This patch doesn't change behavior.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::valueAsDate): Replace parseToDouble to parseToNumber.
(WebCore::BaseDateAndTimeInputType::valueAsNumber): ditto.
(WebCore::BaseDateAndTimeInputType::parseToNumber): ditto.

  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType):

  • html/DateInputType.cpp:

(WebCore::DateInputType::createStepRange): Replace parseToDouble to parseToNumber.

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::createStepRange): Replace parseToDouble to parseToNumber.

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::createStepRange): Replace parseToDouble to parseToNumber.

  • html/InputType.cpp:

(WebCore::InputType::rangeUnderflow): Replace parseToDouble to parseToNumber and doubleValue to numericValue.
(WebCore::InputType::rangeOverflow): ditto.
(WebCore::InputType::isInRange): ditto.
(WebCore::InputType::isOutOfRange): ditto.
(WebCore::InputType::stepMismatch): ditto.
(WebCore::InputType::validationMessage): ditto.
(WebCore::InputType::parseToNumber): ditto.
(WebCore::InputType::parseToDoubleWithDecimalPlaces): ditto.
(WebCore::InputType::stepUpFromRenderer): dttio.

  • html/InputType.h:

(InputType):

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::createStepRange): Replace parseToDouble to parseToNumber.
(WebCore::MonthInputType::parseToNumber): ditto.

  • html/MonthInputType.h:

(MonthInputType):

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::valueAsNumber): Replace parseToDouble to parseToNumber.
(WebCore::NumberInputType::createStepRange): ditto.
(WebCore::NumberInputType::parseToNumber): ditto.

  • html/NumberInputType.h:
  • html/RangeInputType.cpp:

(WebCore::ensureMaximum): Added helper function for createStepRange for avoiding cast in max() and using "const".
(WebCore::RangeInputType::valueAsNumber): Replace parseToDouble to parseToNumber.
(WebCore::RangeInputType::createStepRange): ditto.
(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::parseToNumber): ditto.
(WebCore::RangeInputType::sanitizeValue): ditto.

  • html/RangeInputType.h:

(RangeInputType):

  • html/StepRange.cpp:

(WebCore::StepRange::parseStep): Replace DoubleWithDecimalPlaces to NumberWithDecimalPlaces.
(WebCore::StepRange::stepMismatch): Replace parseToDouble to parseToNumber.

  • html/StepRange.h:

(WebCore::StepRange::NumberWithDecimalPlaces): Renamed from DoubleWithDecimalPlaces.
(WebCore::StepRange::NumberWithDecimalPlacesOrMissing): Renamed from DoubleWithDecimalPlacesOrMissing.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::createStepRange): Replace parseToDouble to parseToNumber.

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::createStepRange): Replace parseToDouble to parseToNumber.

07:55 Changeset [119394] by ddkilzer@apple.com
  • 8 edits in trunk/Source

BUILD FIX: FeatureDefines.xcconfig should match across projects

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • Add missing ENABLE_LEGACY_CSS_VENDOR_PREFIXES.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • Add missing ENABLE_CSS_IMAGE_RESOLUTION.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • Fix sort order of ENABLE_CSS3_FLEXBOX.
  • Fix typo in ENABLE_FONT_BOOSTING.
  • Add missing ENABLE_LEGACY_CSS_VENDOR_PREFIXES.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Add missing ENABLE_LEGACY_CSS_VENDOR_PREFIXES.
07:43 Changeset [119393] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Canvas 2D - Source rectangles that overlap the source image boundary, not supported by drawImage
https://bugs.webkit.org/show_bug.cgi?id=66574

Patch by Justin Novosad <junov@chromium.org> on 2012-06-04
Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/drawImage-clipped-source.html

When the source rectangle argument to drawImage is not entirely
contatained by the domain of the source image, the source rectangle
is clipped, and the destination rectangle is clipped proportionately
Old behavior was to silently fail, which did not comply with the spec.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::normalizeAndClipRects):
(WebCore):
(WebCore::CanvasRenderingContext2D::drawImage):

LayoutTests:

Adding a new layout test that verifies that the source and destination
rectangle arguments to drawImage are properly clipped when the source
rectangle is not entirely contained whithin the domian of the source
image. Tests image to canvas draws and canvas to canvas draws.

  • fast/canvas/drawImage-clipped-source-expected.txt: Added.
  • fast/canvas/drawImage-clipped-source.html: Added.
  • fast/canvas/drawImage-clipped-source.js: Added.

(patternTest.this.testPixel):
(patternTest.this.testRedSquare):
(patternTest.this.testAggregatePattern):
(patternTest):
(drawTestPattern):
(executeTest):

06:31 Changeset [119392] by commit-queue@webkit.org
  • 7 edits in trunk

[Cairo] Implementation of GraphicsContext does not save/restore ImageInterpolation correctly
https://bugs.webkit.org/show_bug.cgi?id=87985

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-04
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Moving image interpolation quality setting into state so that it's saved and restored.

Covered by existing test fast/canvas/canvas-imageSmoothingEnabled.html which is now passing.

  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:

(GraphicsContextPlatformPrivate): Removing stale member that was never used.

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::State::State):
(PlatformContextCairo::State):
(WebCore::PlatformContextCairo::PlatformContextCairo):
(WebCore::PlatformContextCairo::drawSurfaceToContext):
(WebCore::PlatformContextCairo::setImageInterpolationQuality):
(WebCore):
(WebCore::PlatformContextCairo::imageInterpolationQuality):

  • platform/graphics/cairo/PlatformContextCairo.h:

(PlatformContextCairo): Moving implementations for image interpolation quality setter into implementation file.

LayoutTests:

Unskipping fast/canvas/canvas-imageSmoothingEnabled.html now that it passes.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
06:23 Changeset [119391] by pdr@google.com
  • 7 edits
    2 adds in trunk

Fix assert in non-scaling strokes in patterns
https://bugs.webkit.org/show_bug.cgi?id=88198

Source/WebCore:

When calculating the CTM for a rect or path in a pattern we need to use
an SVGPatternElement's local transform. Pattern did not expose the transform
because it does not extend from from SVGStyledLocatable or SVGStyledTransformable.
This patch exposes the pattern's transform in localCoordinateSpaceTransform.

SVGGradientElement does not need this special handling because the children
of a gradient element are restricted to not include shape and structural elements
that would need to calculate a CTM.

Before this patch the added test would assert.
This patch is a prerequisite to a major refactoring of RenderSVGShape &
friends, and the test will be unskipped in a followup patch.

Reviewed by Dirk Schulze.

Tests: svg/stroke/non-scaling-stroke-pattern-expected.svg

svg/stroke/non-scaling-stroke-pattern.svg

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::localCoordinateSpaceTransform):
(WebCore):

  • svg/SVGPatternElement.h:

(SVGPatternElement):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::localCoordinateSpaceTransform):

LayoutTests:

Reviewed by Dirk Schulze.

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
  • svg/stroke/non-scaling-stroke-pattern-expected.svg: Added.
  • svg/stroke/non-scaling-stroke-pattern.svg: Added.
06:15 Changeset [119390] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Tap-to-zoom overshoot animation.
https://bugs.webkit.org/show_bug.cgi?id=87108

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-04
Reviewed by Tor Arne Vestbø.

Reverts the change in animation, so the default is more "neutral".
This should be made configurable later.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animatePageItemRectVisible):

05:38 Changeset [119389] by loislo@chromium.org
  • 4 edits
    1 copy
    1 add in trunk

Web Inspector: speed up _calculateRetainedSizes function
https://bugs.webkit.org/show_bug.cgi?id=87863

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-04
Reviewed by Yury Semikhatsky.

PerformanceTests:

  • inspector/heap-snapshot-advanced.html: Added.
  • inspector/heap-snapshot-performance-test.js: Copied from PerformanceTests/inspector/heap-snapshot.html.

(test.performanceTest.step0):
(test.performanceTest.step1):
(test.performanceTest.step2):
(test.performanceTest.cleanup):
(test.performanceTest.done):
(test.performanceTest):
(test):

  • inspector/heap-snapshot.html:

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._calculateRetainedSizes):

05:35 Changeset [119388] by loislo@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed. Disable heap profiler test on mac platform.

  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
05:17 Changeset [119387] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed, rolling out r119384.
http://trac.webkit.org/changeset/119384
https://bugs.webkit.org/show_bug.cgi?id=88227

Need to update some tests, I'll roll in later. (Requested by
Zoltan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-04

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

05:02 Changeset [119386] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: add unknown size to the memory pie-chart legend
https://bugs.webkit.org/show_bug.cgi?id=88081

Patch by Yury Semikhatsky <yurys@chromium.org> on 2012-06-04
Reviewed by Pavel Feldman.

Added "Unknown" part size to the memory pie-chart legend.

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.MemoryBlockViewProperties._initialize):
(WebInspector.NativeMemoryPieChart.prototype._paint):

04:31 Changeset [119385] by abecsi@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Refactor the tap gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=88096

Reviewed by Simon Hausmann.

Refactor the tap gesture recognizer so that its internal state machine is
self contained and independent of input event types.
Also change the internal API for tap highlighting to make the code easier
to understand on the caller side.

This patch makes the tap gesture recognizer more robust, consistent with
other gesture recognizers and fixes some issues related to highlighting
and link activation with respect to native touch events.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::withinDistance):
(WebKit::QtTapGestureRecognizer::update):
(WebKit::QtTapGestureRecognizer::finish):
(WebKit::QtTapGestureRecognizer::cancel):
(WebKit::QtTapGestureRecognizer::highlightTimeout):
(WebKit::QtTapGestureRecognizer::singleTapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):

  • UIProcess/qt/QtTapGestureRecognizer.h:

(QtTapGestureRecognizer):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::activateTapHighlight):
(WebKit::QtWebPageEventHandler::deactivateTapHighlight):
(WebKit):
(WebKit::QtWebPageEventHandler::handleSingleTapEvent):
(WebKit::QtWebPageEventHandler::handleDoubleTapEvent):
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

04:26 Changeset [119384] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Qt DRT / WTR should be able to load external resources
https://bugs.webkit.org/show_bug.cgi?id=87326

Reviewed by Ryosuke Niwa.

Allow external resources to be loaded when the main frame's URL is also an external resource.
This change is analogous to r118231 for Mac port and to r119153 Chromium port.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::blockRequest):
(WebCore):
(WebCore::isLocalhost):
(WebCore::hostIsUsedBySomeTestsToGenerateError):
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

04:12 Changeset [119383] by carlosgc@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.9.3

Tagging the WebKitGTK+ 1.9.3 release

04:00 Changeset [119382] by carlosgc@webkit.org
  • 4 edits in trunk

Unreviewed. Update NEWS and configure.ac for 1.9.3 release

.:

  • configure.ac: Bump version number.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.9.3.
03:24 Changeset [119381] by vestbo@webkit.org
  • 7 edits in trunk/Source/WebKit

[Qt] Don't use WebKit HAVE() macro in public Qt headers

Reviewed by Kenneth Rohde Christiansen.

03:09 Changeset [119380] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Adding explicit console error for duplicated CSP directives.
https://bugs.webkit.org/show_bug.cgi?id=88193

Source/WebCore:

This patch adds an explicit error message for duplicated CSP
directives instead of reusing the "unrecognized directive" error.

Patch by Mike West <mkwst@chromium.org> on 2012-06-04
Reviewed by Adam Barth.

Test: http/tests/security/contentSecurityPolicy/duplicate-directive.html

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::logDuplicateDirective):
(WebCore):
(WebCore::CSPDirectiveList::parseReportURI):
(WebCore::CSPDirectiveList::setCSPDirective):
(WebCore::CSPDirectiveList::applySandboxPolicy):
(WebCore::CSPDirectiveList::addDirective):

LayoutTests:

Patch by Mike West <mkwst@chromium.org> on 2012-06-04
Reviewed by Adam Barth.

  • http/tests/security/contentSecurityPolicy/duplicate-directive-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/duplicate-directive.html: Added.
02:48 Changeset [119379] by yosin@chromium.org
  • 5 edits in trunk

REGRESSION(r117929) [Forms] input type=number thinks 0 is not a number
https://bugs.webkit.org/show_bug.cgi?id=88208

Reviewed by Kent Tamura.

Source/WebCore:

This patch fixes invalid handling of return value of parseToDoubleForNumberType
in NumberInputType::isAcceptableValue to use isfinite() function for checking
whether specified string is valid number or not. Before r117929, return value
of parseToDoubleForNumberType was bool, but after r117929, it is double.

Test: fast/forms/number/input-number-from-renderer.html

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::isAcceptableValue): Use isfinite()

LayoutTests:

This patch introduced function checkIt() for code sharing and added
more test cases to input-number-commit-valid-only.htm

  • fast/forms/number/input-number-commit-valid-only-expected.txt: Changed for additional tests.
  • fast/forms/number/input-number-commit-valid-only.html: Changed.
02:32 Changeset [119378] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::RenderView::getRetainedWidgets
https://bugs.webkit.org/show_bug.cgi?id=88217

Reviewed by Kenneth Rohde Christiansen.

There is no known repro, the crash has been seen on the field. It is likely that it happens with frame
flattening enabled only.

Null check root renderer in performPostLayoutTasks. The root can legitimely be null for several reasons and
is mostly null checked everywhere else.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

02:28 Changeset [119377] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
https://bugs.webkit.org/show_bug.cgi?id=87668

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-06-04
Reviewed by Ryosuke Niwa.

Tools:

Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might
be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true).

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

  • platform/efl/Skipped: Unskipped fast/html/tab-order.html.
02:06 Changeset [119376] by mario@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Remove geoclue dependency from WebKit API Layer
https://bugs.webkit.org/show_bug.cgi?id=87801

Reviewed by Martin Robinson.

Make GeolocationClient for WebKitGTK+ use the new Geoclue-based
geolocation provider available in WebCore.

  • WebCoreSupport/GeolocationClientGtk.cpp:

(WebKit):
(WebKit::GeolocationClient::GeolocationClient):
(WebKit::GeolocationClient::startUpdating):
(WebKit::GeolocationClient::stopUpdating):
(WebKit::GeolocationClient::setEnableHighAccuracy):
(WebKit::GeolocationClient::notifyPositionChanged):
(WebKit::GeolocationClient::notifyErrorOccurred):

  • WebCoreSupport/GeolocationClientGtk.h:

(GeolocationClient):

01:52 Changeset [119375] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Use SelectorQuery in Element::webkitMatchesSelector()
https://bugs.webkit.org/show_bug.cgi?id=88209

Reviewed by Antti Koivisto.

By using SelectorQuery in Element::webkitMatchesSelector(),
we can not only simplify the code but also improve the performance
thanks to the cache mechanism of SelectorQuery which was implemented
in bug 87942.

Tests: fast/dom/SelectorAPI/*. No change in test results.

  • dom/Element.cpp:

(WebCore::Element::webkitMatchesSelector):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::matches):
(WebCore):

  • dom/SelectorQuery.h:

(SelectorQuery):

01:45 Changeset [119374] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

[EFL] Refactor ewk_view_context_paint code.
https://bugs.webkit.org/show_bug.cgi?id=85588

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-06-04
Reviewed by Hajime Morita.

Source/WebKit:

Added new ewk_paint_context.cpp file to source list.

  • PlatformEfl.cmake:

Source/WebKit/efl:

The main purpose of this change is reduce size of ewk_view.h/cpp files and make use of ewk_view_context_paint
object by ewk_view_single and ewk_view_tiled instead of direct operations on cairo.
The code is more objective and looks very simple now.
Remove ewk_view_context_paint code from ewk_view h/cpp file and move it to separate new ewk_context_paint file.
The ewk_view_context_paint has been renamed to ewk_context_paint and it is not binded to view on creation time.

  • ewk/ewk_paint_context.cpp: Added.

Functions renamed and moved from ewk_view to ewk_paint_context file.
(ewk_paint_context_new):
(ewk_paint_context_from_image_new): New function.
(ewk_paint_context_from_image_data_new): New function.
(ewk_paint_context_free):
(ewk_paint_context_save):
(ewk_paint_context_restore):
(ewk_paint_context_clip):
(ewk_paint_context_scale):
(ewk_paint_context_translate):
(ewk_paint_context_paint): Added FrameView parameter.
(ewk_paint_context_paint_contents): Added FrameView parameter.

  • ewk/ewk_paint_context_private.h: Added.

(_Ewk_Paint_Context):

  • ewk/ewk_private.h: Functions ewk_view_paint and ewk_view_paint_contents moved from ewk_view.h.
  • ewk/ewk_tiled_backing_store.h: Removed unused include.
  • ewk/ewk_view.cpp: Moved all function releated to paint context object to new ewk_paint_context file.

(_Ewk_View_Private_Data):
(ewk_view_paint): Changed function according change in ewk_paint_context_paint function.
(ewk_view_paint_contents): Changed function according change in ewk_paint_context_paint_contents function.

  • ewk/ewk_view.h: Removed all paint context functions and ewk_view_paint, ewk_view_paint_contents function from

public API.

  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_repaints_process):
Refactor of _ewk_view_single_smart_repaints_process function.
Removed goto statements.
Removed variables declaration from function beginning.

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_render_cb): Make use of ewk_paint_context object instead of direction operation on cairo.
Looks simpler and more objective.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt: Added include directory.
01:04 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
01:03 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
01:02 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
01:01 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
00:00 Changeset [119373] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
https://bugs.webkit.org/show_bug.cgi?id=87869

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-04
Reviewed by Andreas Kling.

Replace %lld by PRId64 macro to print an int64_t value and silent a
compilation warning on 64-Bit.

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onExceededApplicationCacheQuota):

06/03/12:

23:20 Changeset [119372] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140222 to r140260.

  • DEPS:
22:38 Changeset [119371] by kinuko@chromium.org
  • 9 edits in trunk

[chromium] DataTransferItem.webkitGetAsEntry() should synchronously return entry
https://bugs.webkit.org/show_bug.cgi?id=87969

Reviewed by Tony Chang.

Source/WebCore:

Per discussion on whatwg we should make webkitGetAsEntry synchronous.
http://lists.w3.org/Archives/Public/public-whatwg-archive/2012Apr/0079.html

Tests: editing/pasteboard/data-transfer-items-drag-drop-entry.html

fast/filesystem/cross-filesystem-op.html

  • Modules/filesystem/DataTransferItemFileSystem.h:

(DataTransferItemFileSystem):

  • Modules/filesystem/DataTransferItemFileSystem.idl:
  • Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp:

(WebCore::DataTransferItemFileSystem::webkitGetAsEntry): Changed it to synchronously return entry.

LayoutTests:

  • editing/pasteboard/data-transfer-items-drag-drop-entry-expected.txt:
  • editing/pasteboard/data-transfer-items-drag-drop-entry.html:
  • fast/filesystem/cross-filesystem-op.html:
  • platform/chromium/test_expectations.txt:
22:24 Changeset [119370] by shawnsingh@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix of chromium TestExpectations

Some extra junk got added by accident when I tried to change
TestExpectations. This patch removes it.

  • platform/chromium/TestExpectations:
22:10 Changeset [119369] by shawnsingh@chromium.org
  • 17 edits
    43 adds in trunk/LayoutTests

Unreviewed rebasline for transforms/3d test cases.

9 tests re-baselined.
The remainin 6 tests are explicitly enumerated in the TestExpectations file now.

  • platform/chromium-linux/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/chromium-linux/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/chromium-linux/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/general/perspective-units-expected.png:
  • platform/chromium-mac-leopard/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png:
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
  • platform/chromium-mac-snowleopard/transforms/3d/general/perspective-units-expected.png:
  • platform/chromium-mac-snowleopard/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
  • platform/chromium-mac/transforms/3d/general/matrix-with-zoom-3d-expected.png: Added.
  • platform/chromium-mac/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/chromium-mac/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/chromium-mac/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/chromium-win/transforms/3d/general/matrix-with-zoom-3d-expected.png: Added.
  • platform/chromium-win/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/chromium-win/transforms/3d/general/perspective-units-expected.txt: Added.
  • platform/chromium-win/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/chromium-win/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
  • platform/chromium-win/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/chromium-win/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
  • platform/chromium/TestExpectations:
21:19 TestExpectations edited by rniwa@webkit.org
Update per TestExpectations rename (diff)
21:18 NewRunWebKitTests edited by rniwa@webkit.org
Update per TestExpectations rename (diff)
21:18 Rebaseline edited by rniwa@webkit.org
Update per TestExpectations rename (diff)
21:16 April 2012 Keeping the bots green edited by rniwa@webkit.org
Update per TestExpectations rename (diff)
21:14 WikiStart edited by rniwa@webkit.org
Rename test_expectations.txt to TestExpectations (diff)
20:14 Changeset [119368] by haraken@chromium.org
  • 3 edits
    1 copy in trunk/PerformanceTests

[perf-test] Add a benchmark of querySelector() for an element that appears in the depths in the document
https://bugs.webkit.org/show_bug.cgi?id=88202

Reviewed by Ryosuke Niwa.

query-selector-first.html tests querySelector() for an element
that appears at the head of the document. query-selector-last.html
tests querySelector() for an element that appears at the tail of
the document. In addition, we want a benchmark of querySelector()
for an element that appears in the depths in the document.

Test results in my Linux desktop:

RESULT Parser: query-selector-deep= 460.776980611 runs/s
median= 460.947503201 runs/s, stdev= 1.72274941942 runs/s, min= 455.696202532 runs/s, max= 463.32046332 runs/s

RESULT Parser: query-selector-deep= 458.925050915 runs/s
median= 459.183673469 runs/s, stdev= 1.47930124139 runs/s, min= 454.545454545 runs/s, max= 460.947503201 runs/s

RESULT Parser: query-selector-deep= 461.866981491 runs/s
median= 461.538461538 runs/s, stdev= 1.14613123359 runs/s, min= 459.183673469 runs/s, max= 463.917525773 runs/s

RESULT Parser: query-selector-deep= 453.922010788 runs/s
median= 454.258855898 runs/s, stdev= 1.77279123317 runs/s, min= 447.204968944 runs/s, max= 455.696202532 runs/s

RESULT Parser: query-selector-deep= 454.666321221 runs/s
median= 454.545454545 runs/s, stdev= 1.65775667417 runs/s, min= 451.127819549 runs/s, max= 456.852791878 runs/s

  • Parser/query-selector-deep.html: Added.
20:06 Changeset [119367] by dominicc@chromium.org
  • 15 edits
    1 move
    1 delete in trunk/Source/WebCore

EventTarget.idl should generate JS bindings
https://bugs.webkit.org/show_bug.cgi?id=88120

This is one step in a larger change to expose a constructor for
EventTarget and put EventTarget on the prototype chain of DOM
objects that are event targets, in line with DOM Core. See
<https://bugs.webkit.org/show_bug.cgi?id=67312>

Reviewed by Adam Barth.

No new tests. This change does not change any functionality.

  • CMakeLists.txt: Generate JSEventTarget.
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp: JSEventTarget.cpp was renamed.
  • bindings/js/JSEventTarget.h: Removed. Generated now.
  • bindings/js/JSEventTargetCustom.cpp: Renamed from Source/WebCore/bindings/js/JSEventTarget.cpp.
  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields): EventTarget is an EventTarget.

  • dom/EventTarget.idl: Defer to toJS, toEventTarget in JSEventTargetCustom.cpp.
19:24 Changeset [119366] by haraken@chromium.org
  • 2 edits in trunk/PerformanceTests

[perf-test] Make query-selector-last.html more realistic
https://bugs.webkit.org/show_bug.cgi?id=88203

Reviewed by Ryosuke Niwa.

query-selector-last.html tests querySelector() for an element
that appears after 1000 div elements, all of which have the same
id and class. To test the performance of querySelector() under
a lot of ids and classes, we should make the ids and classes of
the 1000 elements different.

This patch degrades the performance of query-selector-last.html
by 3.6%.

[Before]
RESULT Parser: query-selector-last= 476.382274152 runs/s
median= 476.821192053 runs/s, stdev= 1.14578875814 runs/s, min= 474.308300395 runs/s, max= 478.087649402 runs/s

RESULT Parser: query-selector-last= 478.423061861 runs/s
median= 478.723404255 runs/s, stdev= 1.54876867255 runs/s, min= 473.684210526 runs/s, max= 481.347773767 runs/s

RESULT Parser: query-selector-last= 479.849287174 runs/s
median= 480.0 runs/s, stdev= 1.69849752498 runs/s, min= 475.561426684 runs/s, max= 481.927710843 runs/s

RESULT Parser: query-selector-last= 476.765438846 runs/s
median= 477.453580902 runs/s, stdev= 1.8724488664 runs/s, min= 471.821756225 runs/s, max= 478.723404255 runs/s

RESULT Parser: query-selector-last= 481.715340644 runs/s
median= 481.637742305 runs/s, stdev= 1.81446361145 runs/s, min= 475.561426684 runs/s, max= 483.675937122 runs/s

[After]
RESULT Parser: query-selector-last= 458.866623582 runs/s
median= 459.183673469 runs/s, stdev= 1.48881464737 runs/s, min= 453.972257251 runs/s, max= 460.947503201 runs/s

RESULT Parser: query-selector-last= 460.363532897 runs/s
median= 460.358056266 runs/s, stdev= 1.58512056995 runs/s, min= 456.273764259 runs/s, max= 462.130937099 runs/s

RESULT Parser: query-selector-last= 457.727448451 runs/s
median= 458.015267176 runs/s, stdev= 1.23681915516 runs/s, min= 453.972257251 runs/s, max= 459.183673469 runs/s

RESULT Parser: query-selector-last= 465.57336853 runs/s
median= 465.717981889 runs/s, stdev= 1.6616925374 runs/s, min= 460.947503201 runs/s, max= 467.532467532 runs/s

RESULT Parser: query-selector-last= 459.836252019 runs/s
median= 459.770114943 runs/s, stdev= 1.84485630505 runs/s, min= 455.696202532 runs/s, max= 462.724935733 runs/s

  • Parser/query-selector-last.html:
17:35 WebKit Team edited by joone@webkit.org
(diff)
15:35 Changeset [119365] by hayato@chromium.org
  • 5 edits in trunk

Supports traversing nodes in an orphaned shadow subtree in ComposedShadowTreeParentWalker.
https://bugs.webkit.org/show_bug.cgi?id=87924

Reviewed by Dimitri Glazkov.

Source/WebCore:

Some events, such as a 'click' event, can be dispatched on nodes in an orphaned shadow subtree.
When resolving a parent node of a shadow root which is not assigned to any shadow insertion point,
we have to return its shadow host as a parent node.

The related shadow DOM spec section is:
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events

Test: fast/dom/shadow/shadow-dom-event-dispatching.html

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeParentWalker::traverseParentIncludingInsertionPointAndShadowRoot):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
14:16 Changeset [119364] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Weak pointer finalization should be lazy
https://bugs.webkit.org/show_bug.cgi?id=87599

Reviewed by Sam Weinig.

This time for sure!

  • heap/Heap.cpp:

(JSC::Heap::collect): Don't sweep eagerly -- we'll sweep lazily instead.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep): Sweep our weak set before we sweep our other
destructors -- this is our last chance to run weak set finalizers before
we recycle our memory.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::resetAllocator):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::resetAllocators):

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::resetAllocators): Don't force allocator reset anymore.
It will happen automatically when a weak set is swept. It's simpler to
have only one canonical way for this to happen, and it wasn't buying
us anything to do it eagerly.

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::sweep): Don't short-circuit a sweep unless we know
the sweep would be a no-op. If even one finalizer is pending, we need to
run it, since we won't get another chance.

  • heap/WeakSet.cpp:

(JSC::WeakSet::sweep): This loop can be simpler now that
WeakBlock::sweep() does what we mean.

Reset our allocator after a sweep because this is the optimal time to
start trying to recycle old weak pointers.

(JSC::WeakSet::tryFindAllocator): Don't sweep when searching for an
allocator because we've swept already, and forcing a new sweep would be
wasteful.

  • heap/WeakSet.h:

(JSC::WeakSet::shrink): Be sure to reset our allocator after a shrink
because the shrink may have removed the block the allocator was going to
allocate out of.

12:13 Changeset [119363] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] http/tests/media/video-buffered.html is failing after r119268 and need to be skipped
https://bugs.webkit.org/show_bug.cgi?id=88194

Unreviewed EFL gardening. Skipping http/tests/media/video-buffered.html
which is failing after r119268.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-03

  • platform/efl/TestExpectations:
11:49 Changeset [119362] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] legacy-viewport tests added in r119256 need to be skipped
https://bugs.webkit.org/show_bug.cgi?id=88192

Unreviewed EFL gardening. Skip new tests added in r119256 since the
LEGACY_VIEWPORT_ADAPTION flag is disabled on EFL port.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-03

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
11:30 Changeset [119361] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[EFL] New tests need a baseline
https://bugs.webkit.org/show_bug.cgi?id=88190

Unreviewed EFL gardening. Add EFL baseline for new test cases.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-03

  • platform/efl/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/efl/fast/reflections/reflection-with-zoom-expected.txt: Added.
  • platform/efl/svg/repaint/text-mask-update-expected.png: Added.
  • platform/efl/svg/repaint/text-mask-update-expected.txt: Added.
08:51 Changeset [119360] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, rolling out r119359.
http://trac.webkit.org/changeset/119359
https://bugs.webkit.org/show_bug.cgi?id=88189

This broke platform/mac/fast/dom/wrapper-classes-objc.html.
(Requested by dominicc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-03

Source/WebCore:

  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:

(GetBaseClass):

  • dom/MouseEvent.h:

(MouseEvent):

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):

  • dom/WheelEvent.h:

(WheelEvent):

  • dom/WheelEvent.idl:

LayoutTests:

  • fast/events/event-creation-expected.txt:
  • fast/events/event-creation.html:
07:33 Changeset [119359] by dominicc@chromium.org
  • 10 edits in trunk

WheelEvent should inherit from MouseEvent
https://bugs.webkit.org/show_bug.cgi?id=76104

Reviewed by Kentaro Hara.

Source/WebCore:

The spec for WheelEvent is
<http://www.w3.org/TR/DOM-Level-3-Events/#webidl-events-WheelEvent>

Tests: fast/events/event-creation.html

http://samples.msdn.microsoft.com/ietestcenter/dominheritance/showdominheritancetest.htm?Prototype_WheelEvent

  • bindings/objc/PublicDOMInterfaces.h: Remove redundant MouseEvent API from WheelEvent
  • bindings/scripts/CodeGeneratorObjC.pm: MouseEvents are Events
  • dom/MouseEvent.h: Expose no-arg constructor to WheelEvent
  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent): Call MouseEvent superconstructor

  • dom/WheelEvent.h: Extend MouseEvent
  • dom/WheelEvent.idl: "

LayoutTests:

  • fast/events/event-creation-expected.txt:
  • fast/events/event-creation.html: Also check WheelEvent instanceof MouseEvent as well as UIEvent, Event
02:35 Changeset [119358] by gyuyoung.kim@samsung.com
  • 4 edits
    1 copy in trunk/Source/WebKit/efl

Add ewk_custom_handler_private.h for ewk_custom_handler.cpp
https://bugs.webkit.org/show_bug.cgi?id=88163

Reviewed by Ryosuke Niwa.

EFL WK1 decided to divide up ewk_private.h into each file's XXX_private.h file
in order to maintain internal functions more easily. Bug 73176 is adding new
internal functions to ewk_custom_hanlder.cpp. So, ewk_custom_handler.cpp needs
to have _private.h file as well.

  • WebCoreSupport/ChromeClientEfl.cpp:
  • ewk/ewk_custom_handler.cpp:
  • ewk/ewk_custom_handler_private.h: Added.
  • ewk/ewk_view_private.h:
01:21 Changeset [119357] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140000 to r140222.

  • DEPS:
00:26 Changeset [119356] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

[chromium] Add new gesture type (two finger tap) that triggers context menu.
https://bugs.webkit.org/show_bug.cgi?id=88173

Patch by Varun Jain <varunjain@google.com> on 2012-06-03
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/touch/gesture/context-menu-on-two-finger-tap.html

  • platform/PlatformEvent.h:

Source/WebKit/chromium:

  • public/WebInputEvent.h:
  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::handleInputEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureTwoFingerTap):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/EventSender.h:

(EventSender):

LayoutTests:

  • fast/events/touch/gesture/context-menu-on-two-finger-tap.html: Added.
  • platform/chromium/fast/events/touch/gesture/context-menu-on-two-finger-tap-expected.txt: Added.
00:06 Changeset [119355] by rjkroege@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] replace isScrollGestureEventType with isGestureEventType
https://bugs.webkit.org/show_bug.cgi?id=88097

This change replaces the unused and incorrect isScrollGestureEventType
method with a correct and useful isGestureEventType method.

Reviewed by Adam Barth.

  • public/WebInputEvent.h:

(WebInputEvent):
(WebKit::WebInputEvent::isGestureEventType):

06/02/12:

23:29 Changeset [119354] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

ZNK7WebCore4Node27traverseNextAncestorSiblingEv should be exported even if ENABLE(FULLSCREEN_API) is false
https://bugs.webkit.org/show_bug.cgi?id=88184

Reviewed by Dan Bernstein.

Node::traverseNextAncestorSibling() is called in several inline
functions defined in ContainerNode.h (a private header), so its symbol
needs to be exported regardless of whether full-screen API is enabled.

  • WebCore.exp.in:
22:06 Changeset [119353] by wangxianzhu@chromium.org
  • 15 edits
    2 adds in trunk

SVGImageCache leaks image data
https://bugs.webkit.org/show_bug.cgi?id=87792

Source/WebCore:

There are two functions to remove a client from a CachedImage:

  • CachedResource::removeClient()
  • CachedImage::removeClientForRenderer().

It's easy to make error to call the former which will leak the cached
image buffers in SVGImageCache.

This change combined the two by adding the virtual
CachedResource::didRemoveClient(). CachedImage will do SVGImageCache
cleanup in the function.

Reviewed by Nikolas Zimmermann.

Test: svg/as-image/svg-image-leak-cached-data.html

  • loader/cache/CachedFont.h:

(WebCore::CachedFontClient::resourceClientType): Added 'const'.

  • loader/cache/CachedImage.cpp:

(WebCore):
(WebCore::CachedImage::didRemoveClient): Removes the client from SVGImageCache.
(WebCore::CachedImage::lookupOrCreateImageForRenderer):

  • loader/cache/CachedImage.h:

(CachedImage):
(WebCore::CachedImageClient::resourceClientType): Added 'const'.

  • loader/cache/CachedRawResource.h:

(WebCore::CachedRawResourceClient::resourceClientType): Added 'const'.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::removeClient): Added invocation of didRemoveClient().

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::didRemoveClient): Added for subclasses to do additional works.

  • loader/cache/CachedResourceClient.h:

(WebCore::CachedResourceClient::resourceClientType): Added 'const'.

  • loader/cache/CachedSVGDocument.h:

(WebCore::CachedSVGDocumentClient::resourceClientType): Added 'const'.

  • loader/cache/CachedStyleSheetClient.h:

(WebCore::CachedStyleSheetClient::resourceClientType): Added 'const'.

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::removeClient):

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::removeClient):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache): Added checking for leaks.
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndScales):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForClient):

  • svg/graphics/SVGImageCache.h:

(WebCore):
(SVGImageCache):

LayoutTests:

Reviewed by Nikolas Zimmermann.

New test case.

  • svg/as-image/svg-image-leak-cached-data-expected.txt: Added.
  • svg/as-image/svg-image-leak-cached-data.html: Added.
21:10 Changeset [119352] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove the failing expectation on fast/forms/textarea-scrollbar-height.html since it has been passing.

  • platform/chromium/TestExpectations:
20:45 Changeset [119351] by ggaren@apple.com
  • 3 edits in trunk/Source/WebKit2

2012-06-02 Geoffrey Garen <ggaren@apple.com>

Try to fix the Windows build.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
20:35 Changeset [119350] by rniwa@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Add back files inadvertently removed in r119323.

19:46 Changeset [119349] by aestes@apple.com
  • 20 edits in trunk/Source/WebKit2

[WebKit2] Use USE(), ENABLE(), and HAVE() macros in more places
https://bugs.webkit.org/show_bug.cgi?id=88182

Reviewed by Sam Weinig.

Use USE(APPKIT):

  • Shared/mac/NativeWebKeyboardEventMac.mm:
  • Shared/mac/NativeWebMouseEventMac.mm:
  • Shared/mac/NativeWebWheelEventMac.mm:
  • Shared/mac/WebEventFactory.h:
  • UIProcess/API/mac/WKTextInputWindowController.h:
  • UIProcess/API/mac/WKTextInputWindowController.mm:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:

Use ENABLE(NETSCAPE_PLUGIN_API):

  • UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):

Use USE(AUTOCORRECTION_PANEL):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::showCorrectionPanel):
(WebKit::PageClientImpl::dismissCorrectionPanel):
(WebKit::PageClientImpl::dismissCorrectionPanelSoon):

  • UIProcess/mac/CorrectionPanel.mm:

Use HAVE(HOSTED_CORE_ANIMATION):

  • UIProcess/mac/WebContextMac.mm:

Put ENABLE(FULLSCREEN_API) in the right place:

  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:

Remove unnecessary use of USE(APPKIT):

  • UIProcess/mac/WebPageProxyMac.mm:

Use USE(SECURITY_FRAMEWORK):

  • WebProcess/Authentication/mac/AuthenticationManager.mac.mm:

Use ENABLE(CONTEXT_MENUS):

  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:

Use USE(SECURITY_FRAMEWORK):

  • WebProcess/WebProcess.h:

Remove unnecessary use of USE(SECURITY_FRAMEWORK):

  • WebProcess/mac/WebProcessMac.mm:
19:38 Changeset [119348] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Windows build fix after r119330. Unnest the class for now.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCacheEntry::SelectorQueryCacheEntry):
(WebCore::SelectorQueryCache::add):

  • dom/SelectorQuery.h:

(SelectorQueryCacheEntry):
(WebCore::SelectorQueryCacheEntry::selectorQuery):
(WebCore):
(SelectorQueryCache):

19:33 Changeset [119347] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove a duplicate INIT() from WebSystemInterface.mm
https://bugs.webkit.org/show_bug.cgi?id=88181

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

19:23 Changeset [119346] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unnecessary import of <Cocoa/Cocoa.h>
https://bugs.webkit.org/show_bug.cgi?id=88180

Reviewed by Sam Weinig.

  • UIProcess/mac/WKFullKeyboardAccessWatcher.h:
17:53 Changeset [119345] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Ensure cpu_type_t is defined by including <mach/machine.h>
https://bugs.webkit.org/show_bug.cgi?id=88178

Reviewed by Anders Carlsson.

  • Shared/Plugins/PluginModuleInfo.h:
17:47 Changeset [119344] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

InjectedBundles' sandbox extensions don't do what we think they do
https://bugs.webkit.org/show_bug.cgi?id=88177

Reviewed by Anders Carlsson.

This cannot be tested with our current infrastructure (or any modifications of the
infrastructure I can think of) since it relies on the bundle being put outside
the build directory where WebKit is put.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load):
Use SandboxExtension::consumePermanently() rather than consume(), otherwise,
nulling out the SandboxExtension a few lines later invalidates the extension
we just consumed.

17:41 Changeset [119343] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

If the DFG bytecode parser detects that op_method_check has gone polymorphic, it
shouldn't revert all the way to GetById/GetByIdFlush
https://bugs.webkit.org/show_bug.cgi?id=88176

Reviewed by Geoffrey Garen.

Refactored the code so that the op_method_check case of the parser gracefully falls
through to all of the goodness of the normal op_get_by_id case.

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleGetById):
(DFG):
(JSC::DFG::ByteCodeParser::parseBlock):

15:58 Changeset [119342] by fpizlo@apple.com
  • 18 edits in trunk/Source/JavaScriptCore

DFG CSE should be able to eliminate unnecessary flushes of arguments and captured variables
https://bugs.webkit.org/show_bug.cgi?id=87929

Reviewed by Geoffrey Garen.

Slight speed-up on V8. Big win (up to 50%) on programs that inline very small functions.

This required a bunch of changes:

  • The obvious change is making CSE essentially ignore whether or not the set of operations between the Flush and the SetLocal can exit, and instead focus on whether or not that set of operations can clobber the world or access local variables. This code is now refactored to return a set of flags indicating any of these events, and the CSE decides what to do based on those flags. If the set of operations is non-clobbering and non-accessing, then the Flush is turned into a Phantom on the child of the SetLocal. This expands the liveness of the relevant variable but virtually guarantees that it will be register allocated and not flushed to the stack. So, yeah, this patch is a lot of work to save a few stores to the stack.


  • Previously, CheckArgumentsNotCreated was optimized "lazily" in that you only knew if it was a no-op if you were holding onto a CFA abstract state. But this would make the CSE act pessimistically, since it doesn't use the CFA. Hence, this patch changes the constant folding phase into something more broad; it now fixes up CheckArgumentsNotCreated nodes by turning them into phantoms if it knows that they are no-ops.


  • Arguments simplification was previously relying on this very strange PhantomArguments node, which had two different meanings: for normal execution it meant the empty value but for OSR exit it meant that the arguments should be reified. This produces problems when set SetLocals to the captured arguments registers are CSE'd away, since we'd be triggering reification of arguments without having initialized the arguments registers to empty. The cleanest solution was to fix PhantomArguments to have one meaning: namely, arguments reification on OSR exit. Hence, this patch changes arguments simplification to change SetLocal of CreateArguments on the arguments registers to be a SetLocal of Empty.


  • Argument value recoveries were previously derived from the value source of the arguments at the InlineStart. But that relies on all SetLocals to arguments having been flushed. It's possible that we could have elided the SetLocal to the arguments at the callsite because there were subsequent SetLocals to the arguments inside of the callee, in which case the InlineStart would get the wrong information. Hence, this patch changes argument value recovery computation to operate over the ArgumentPositions directly.


  • But that doesn't actually work, because previously, there was no way to link an InlineStart back to the corresponding ArgumentPositions, at least not without some ugliness. So this patch instates the rule that the m_argumentPositions vector consists of disjoint subsequences such that each subsequence corresponds to an inline callsite and can be identified by its first index, and within each subsequence are the ArgumentPositions of all of the arguments ordered by argument index. This required flipping the order in which ArgumentPositions are added to the vector, and giving InlineStart an operand that indicates the start of that inline callsite's ArgumentPosition subsequence.


  • This patch also revealed a nasty bug in the reification of arguments in inline call frames on OSR exit. Since the reification was happening after the values of virtual registers were recovered, the value recoveries of the inline arguments were wrong. Hence using operationCreateInlinedArguments is wrong. For example a value recovery might say that you have to box a double, but if we had already boxed it then boxing it a second time will result in garbage. The specific case of this bug was this patch uncovered was that now it is possible for an inline call frame to not have any valid value recoveries for any inline arguments, if the optimization elides all argument flushes, while at the same time optimizing away arguments creation. Then OSR exit would try to recover the arguments using the inline call frame, which had bogus information, and humorous crashes would ensue. This patch fixes this issue by moving arguments reification to after call frame reification, so that arguments reification can always use operationCreateArguments instead of operationCreateInlinedArguments.


  • This patch may turn a Flush into a Phantom. That's kind of the whole point. But that broke forward speculation checks, which knew to look for a Flush prior to a SetLocal but didn't know that there could alternatively be a Phantom in place of the Flush. This patch fixes that by augmenting the forward speculation check logic.


  • Finally, in the process of having fun with all of the above, I realized that my DFG validation was not actually running on every phase like I had originally designed it to. In fact it was only running just after bytecode parsing. I initially tried to make it run in every phase but found that this causes some tests to timeout (specifically the evil fuzzing ones), so I decided on a compromise where: (i) in release mode validation never runs, (ii) in debug mode validation will run just after parsing and just before the backend, and (iii) it's possible with a simple switch to enable validation to run on every phase.


Luckily all of the above issues were already covered by the 77 or so DFG-specific
layout tests. Hence, this patch does not introduce any new tests despite being so
meaty.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentPosition.h:

(JSC::DFG::ArgumentPosition::prediction):
(JSC::DFG::ArgumentPosition::doubleFormatState):
(JSC::DFG::ArgumentPosition::shouldUseDoubleFormat):
(ArgumentPosition):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::SetLocalStoreEliminationResult::SetLocalStoreEliminationResult):
(SetLocalStoreEliminationResult):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGNode.h:

(Node):
(JSC::DFG::Node::hasArgumentPositionStart):
(JSC::DFG::Node::argumentPositionStart):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGPhase.cpp:

(DFG):

  • dfg/DFGPhase.h:

(Phase):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

15:49 Changeset [119341] by ggaren@apple.com
  • 8 edits in trunk/Source

DOM string cache should hash pointers, not characters
https://bugs.webkit.org/show_bug.cgi?id=88175

Reviewed by Phil Pizlo and Sam Weinig.

../JavaScriptCore:

  • heap/Weak.h:

(JSC::weakAdd):
(JSC::weakRemove): Made these function templates slightly more generic
to accommodate new client types.

../WebCore:

Dromaeo DOM Core reports no change.

http://trac.webkit.org/changeset/84934 accidentally changed from hashing
pointers to hashing characters, due to template defaults. Let's change back.

Hashing characters is not so good because:

(1) It's not memory-safe with HashMap::set(). HashMap::set() replaces
the value but not the key. Since our values own our keys, we need to
ensure object identity between key and value, or the key can be freed
prematurely. (This is impossible to demonstrate with our current
eager sweep behavior, but it shows up as crashes in layout tests if you
change to lazy sweep.)

(2) It's slower.

  • bindings/js/DOMWrapperWorld.h:

(WebCore): Override the default hash, which hashes based on characters.

14:52 Changeset [119340] by efidler@rim.com
  • 2 edits in trunk/Source/WebCore

Don't crash if we ask for fonts that don't exist.
https://bugs.webkit.org/show_bug.cgi?id=88106

Reviewed by Dan Bernstein.

RIM PR 161219

If the site doesn't ask for a reasonable font and the system doesn't
provide a good fallback, FontFallBackList::primaryFontData can be 0,
which can cause a crash.

  • platform/graphics/skia/FontCacheSkia.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

14:30 Changeset [119339] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

loadRequest should check for empty URLs.
https://bugs.webkit.org/show_bug.cgi?id=88154

In [WebFrame loadRequest], if the url is invalid and not nil, we transform it to file: url.
However, WebKit client could send down an empty URL that makes us transform it to file: url
as well. We should skip that as we did for nil URLs.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-06-02
Reviewed by Brady Eidson.

  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]):

13:34 WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
13:32 Changeset [119338] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.8

Merge 115763 - Ensure HTMLElementStack fails gracefully if it has a non-Element.
https://bugs.webkit.org/show_bug.cgi?id=85167

Reviewed by Adam Barth.

Source/WebCore:

Test: Added to html5lib/resources/webkit02.dat

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::oneBelowTop):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

  • html5lib/resources/webkit02.dat:
13:31 Changeset [119337] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8

Merge 108311 - Invalid cast in WebCore::toElement / WebCore::HTMLElementStack::ElementRecord::element
https://bugs.webkit.org/show_bug.cgi?id=78975

Reviewed by Eric Seidel.

Source/WebCore:

We're supposed to set the action attribute on the form element we just
created. Previously, we assumed the newly created form element would
be on the top of the stack of open elements, but if we're in the table
body insertion mode, the form element gets treated as self closing and
is therefore popped off the stack of open elements.

Fortunately, we already cache a pointer to the most recently inserted
form element on the HTMLConstructionSite, so we can just grab the
element from there.

Test: html5lib/runner.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):

LayoutTests:

  • html5lib/resourcesl/webkit-02.dat:
13:31 Changeset [119336] by kov@webkit.org
  • 1 add in releases/WebKitGTK/webkit-1.8/LayoutTests/platform/gtk/fast/dom/htmlcollection-non-html-expected.txt

Rebseline for 115398.

13:31 Changeset [119335] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 115646 - loadOrRedirectSubframe should return the owner element's frame
https://bugs.webkit.org/show_bug.cgi?id=84780

Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/loader/javascript-url-iframe-remove-on-navigate.html

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadOrRedirectSubframe):

LayoutTests:

  • fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt: Added.
  • fast/loader/javascript-url-iframe-remove-on-navigate.html: Added.
13:30 Changeset [119334] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 115398 - Invalid cast in WebCore::HTMLCollection::isAcceptableElement
https://bugs.webkit.org/show_bug.cgi?id=84626

Reviewed by Darin Adler.

Source/WebCore:

Check if the object is an HTMLElement before casting.

Test: fast/dom/htmlcollection-non-html.html

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::isAcceptableElement):

LayoutTests:

Add tests to make sure only HTML elements are present in most HTMLCollection objects.

  • fast/dom/htmlcollection-non-html-option-expected.txt: Added.
  • fast/dom/htmlcollection-non-html.html: Added.
13:30 Changeset [119333] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Source/WebCore: Crash in CachedRawResource::didAddClient() due to missing protector.
https://bugs.webkit.org/show_bug.cgi?id=83632

Reviewed by Eric Seidel.

Test: http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::didAddClient):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=83632.

Reviewed by Eric Seidel.

  • http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html: Added.
13:30 Changeset [119332] by kov@webkit.org
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-1.8

2012-03-09 Nate Chapin <japhet@chromium.org>

CachedRawResource breaks when trying to load
a resource with an empty response body from cache.

Reviewed by Alexey Proskuryakov.

Test: http/tests/cache/zero-length-xhr.html

  • loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::didAddClient): Don't exit early

if m_data is empty, we may still need to notifyFinished().

13:29 Changeset [119331] by kov@webkit.org
  • 7 edits in releases/WebKitGTK/webkit-1.8

Source/WebCore: Prevent CachedRawResource from sending the same data
chunk multiple times.
https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

If a CachedRawResource receives data while a CachedRawResourceCallback
timer is active, the incremental data will be sent to the client, followed
but all data received so far, resulting in invalid data. Resolving this adds
complexity to CachedRawResource and requires making a few more CachedResource
functions virtual, so push the callback logic into CachedResource where it can
be implemented more cleanly.

Test: inspector/debugger/script-formatter-console.html

should no longer be flaky.

  • loader/cache/CachedRawResource.cpp: CachedRawResourceCallback renamed and moved to CachedResource.

(WebCore::CachedRawResource::didAddClient): More or less the same as sendCallbacks() was.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClient): Check the return value of addClientToSet() to determine whether

or not to call didAddClient.

(WebCore::CachedResource::didAddClient): May be called during addClient(), or may be called on a timer.

If called on a timer, move the client between sets.

(WebCore::CachedResource::addClientToSet): Determine whether didAddClient() can be called synchronously and

return true if it can.

(WebCore::CachedResource::removeClient): Ensure we cancel pending callbacks if necessary.
(WebCore::CachedResource::CachedResourceCallback::CachedResourceCallback): Renamed and moved from CachedRawResource.

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::hasClients): Check m_clientsAwaitingCallback as well as m_clients.
(WebCore::CachedResource::CachedResourceCallback::schedule):
(WebCore::CachedResource::hasClient): Helper for calling contains() on both m_clientsAwaitingCallback and m_clients.

LayoutTests: inspector/debugger/script-formatter-console.html should
no longer be flaky.
https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
12:23 Changeset [119330] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[Performance] Optimize querySelector() by caching SelectorQuery objects
https://bugs.webkit.org/show_bug.cgi?id=87942

Reviewed by Antti Koivisto.

This patch improves performance of Node::querySelector() by 7.1x in Safari/Mac
and by 8.5x in Chromium/Linux.

Performance test: Parser/query-selector-first.html, Parser/query-selector-last.html

[query-selector-first.html]
Safari/Mac 264.97 runs/s => 1872.78 runs/s (7.06x speed-up)
Chromium/Linux 244.84 runs/s => 2071.60 runs/s (8.46x speed-up)

[query-selector-last.html]
Safari/Mac 393.73 runs/s => 466.05 runs/s (1.18x speed-up)
Chromium/Linux 401.15 runs/s => 484.45 runs/s (1.20x speed-up)

Previously Node::querySelector() and Node::querySelectorAll() had been
parsing CSS queries every time. This patch optimizes the performance by caching
parsed results onto a Document.

The cache is invalidated when any of CSS related variables is updated.
As per the current implementation of CSSParserContext::operator==(), the CSS related
variables are as follows:

  • baseURI
  • charset
  • mode
  • isHTMLDocument
  • isCSSCustomFilterEnabled
  • isCSSRegionsEnabled
  • needsSiteSpecificQuirks
  • enforcesCSSMIMETypeInNoQuirksMode

Actually, we do not need to watch all of these variables:

  • The current implementation does not watch the change of charset.

charset is always set to a null String by CSSParserContext::CSSParserContext().

  • isHTMLDocument never changes.
  • isCSSCustomFilterEnabled, isCSSRegionsEnabled, needsSiteSpecificQuirks and

enforcesCSSMIMETypeInNoQuirksMode are not flipped in a user scenario.
If someone changes them, it would be reasonable to expect them
to take the effect only on subsequent document loads.
Thus we do not need to invalidate the cache when these variables are updated.

Consequently, the condition under which we have to invalidate the cache is
that any of the following variables is updated:

  • baseURI
  • mode

Tests: fast/dom/SelectorAPI/*. No change in test results.

  • dom/SelectorQuery.h: SelectorQueryCache is a cache from CSS selectors to parsed results.

SelectorQueryCache::Entry is an entry of the cache.
SelectorQueryCache::Entry holds a SelectorQuery object and a CSSSelectorList object.
The reason why SelectorQueryCache::Entry needs to hold the CSSSelectorList object
is that the CSSSelectorList object keeps the lifetime of CSSSelector objects
in the SelectorQuery object. Since the SelectorQuery object just holds pointers
to CSSSelector objects, the CSSSelectorList object must not be destructed
before the SelectorQuery object is destructed.
(WebCore):
(SelectorDataList):
(WebCore::SelectorQuery::SelectorQuery):
(SelectorQuery):
(SelectorQueryCache):
(WebCore::SelectorQueryCache::SelectorQueryCache):
(Entry):
(WebCore::SelectorQueryCache::Entry::selectorQuery):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::initialize):
(WebCore::SelectorQueryCache::Entry::Entry):
(WebCore::SelectorQueryCache::add): Returns a cached SelectorQuery object if any.
Otherwise, parses a given CSS selector, creates a SelectorQuery object,
adds the SelectorQuery object to a new entry in the cache, returns the SelectorQuery
object.
(WebCore::SelectorQueryCache::invalidate): Clears the cache.

  • dom/Document.h:

(WebCore):
(Document):

  • dom/Document.cpp:

(WebCore::Document::selectorQueryCache):
(WebCore):
(WebCore::Document::setCompatibilityMode): Invalidates the cache
when m_compatibilityMode is updated.
(WebCore::Document::updateBaseURL): Invalidates the cache
when m_baseURL is updated.

  • dom/Node.h: Changed String to AtomicString, since the key of the cache

should be AtomicString.
(Node):

  • dom/Node.cpp: Optimized the code by using the cache.

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):

12:05 Changeset [119329] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Reverted the last change.

  • WebCore.xcodeproj/project.pbxproj:
12:02 Changeset [119328] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Reverted the last change.

  • WebKit2.xcodeproj/project.pbxproj:
11:59 Changeset [119327] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Stop treating Perl code as private headers.

  • WebCore.xcodeproj/project.pbxproj: Removed CodeGenerator.pm, generate-bindings.pl,

IDLParser.pm, IDLStructure.pm, and preprocessor.pm from the Copy Headers build phase.

11:57 Changeset [119326] by fischman@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] SKIP http/tests/media/video-buffered.html because it requires overly large data
https://bugs.webkit.org/show_bug.cgi?id=88172

Unreviewed gardening.

  • platform/chromium/TestExpectations:
11:54 Changeset [119325] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed build fix. Temporarily disable DerivedSources cleanup on Windows.

11:43 Changeset [119324] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop treating two Python scripts as private headers.

  • WebKit2.xcodeproj/project.pbxproj: Removed model.py and parser.py from the Copy Headers

build phase.

09:58 Changeset [119323] by ossy@webkit.org
  • 6 edits
    37 moves
    17 adds
    5 deletes in trunk/LayoutTests

[Qt] Replace QtXmlPatterns usage with libxslt dependency
https://bugs.webkit.org/show_bug.cgi?id=76820

Unreviewed gardening.

  • fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Renamed from LayoutTests/platform/efl/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt.
  • platform/efl/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Removed.
  • platform/gtk/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Removed.
  • platform/gtk/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Removed.
  • platform/mac/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Removed.
  • platform/mac/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Removed.
  • platform/qt-4.8/Skipped:
  • platform/qt-4.8/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt.
  • platform/qt-4.8/fast/dom/Range/surround-contents-font-face-crash-expected.txt: Renamed from LayoutTests/platform/qt/fast/dom/Range/surround-contents-font-face-crash-expected.txt.
  • platform/qt-4.8/fast/dom/xml-parser-error-message-crash-expected.txt: Renamed from LayoutTests/platform/qt/fast/dom/xml-parser-error-message-crash-expected.txt.
  • platform/qt-4.8/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Renamed from LayoutTests/platform/qt/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt.
  • platform/qt-4.8/fast/events/xsl-onload-expected.txt: Renamed from LayoutTests/platform/qt/fast/events/xsl-onload-expected.txt.
  • platform/qt-4.8/fast/parser/xml-colon-entity-expected.txt: Renamed from LayoutTests/platform/qt/fast/parser/xml-colon-entity-expected.txt.
  • platform/qt-4.8/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Renamed from LayoutTests/platform/qt/fast/parser/xml-declaration-missing-ending-mark-expected.txt.
  • platform/qt-4.8/fast/parser/xslt-with-html-expected.txt: Renamed from LayoutTests/platform/qt/fast/parser/xslt-with-html-expected.txt.
  • platform/qt-4.8/fast/xsl/subframe-location-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/subframe-location-expected.txt.
  • platform/qt-4.8/fast/xsl/transform-to-html-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/transform-to-html-expected.txt.
  • platform/qt-4.8/fast/xsl/utf8-chunks-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/utf8-chunks-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-bad-import-uri-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-bad-import-uri-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-doc-noenc-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-doc-noenc-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-entity-enc-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-entity-enc-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-entity-expected.png: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-entity-expected.png.
  • platform/qt-4.8/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-recursion-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-recursion-expected.txt.
  • platform/qt-4.8/http/tests/misc/location-test-xsl-style-sheet-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/misc/location-test-xsl-style-sheet-expected.txt.
  • platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt.
  • platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt.
  • platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt.
  • platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.png: Renamed from LayoutTests/platform/qt/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.png.
  • platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.txt.
  • platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.png: Renamed from LayoutTests/platform/qt/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.png.
  • platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.txt.
  • platform/qt-4.8/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xml-external-entity-expected.txt.
  • platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt.
  • platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt.
  • platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt.
  • platform/qt-4.8/svg/custom/bug45331-expected.png: Renamed from LayoutTests/platform/qt/svg/custom/bug45331-expected.png.
  • platform/qt-4.8/svg/custom/bug45331-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/bug45331-expected.txt.
  • platform/qt-4.8/svg/custom/bug78807-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/bug78807-expected.txt.
  • platform/qt-4.8/svg/custom/use-invalid-html-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-invalid-html-expected.txt.
  • platform/qt-4.8/svg/custom/use-invalid-style-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-invalid-style-expected.txt.
  • platform/qt-4.8/svg/hixie/error/dumpAsText/004-expected.txt: Renamed from LayoutTests/platform/qt/svg/hixie/error/dumpAsText/004-expected.txt.
  • platform/qt-4.8/svg/hixie/error/dumpAsText/005-expected.txt: Renamed from LayoutTests/platform/qt/svg/hixie/error/dumpAsText/005-expected.txt.
  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Added.
  • platform/qt-5.0/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Added.
  • platform/qt-arm/Skipped:
  • platform/qt/Skipped:
07:53 Changeset [119322] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART III)
https://bugs.webkit.org/show_bug.cgi?id=88019

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

Enter 'pure-with-mouse-conversion' mode when going fullscreen, so
that it prevents user from scrolling the WebPage, pinch zooming,
touch-and-hold, enter selection mode, etc ...

Internally reviewed by Gen Mak.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • Api/WebPage_p.h:

(WebPagePrivate):

07:52 Changeset [119321] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART II)
https://bugs.webkit.org/show_bug.cgi?id=88019

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

When an element goes fullscreen, its wrapper/container obeys all
BlackBerry specific fixed position customizations: we fixed
against Y, but not X. Then, in order to have the wrapper element
properly positioned when entering fullscreen mode, we
temporarily scroll x to 0.

The original x scroll position is restored when we leave
fullscreen.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • Api/WebPage_p.h:

(WebPagePrivate):

07:52 Changeset [119320] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART I)
https://bugs.webkit.org/show_bug.cgi?id=88019
PR #158266

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

The way elements go fullscreen with the new FULLSCREEN_API
is that they get cloned and added to an out-of-DOM wrapper
element. The wrapper is a normal fixed position element and
then zoom in/out accordingly to how other layers do: following
WebPage's scale.

When going fullscreen, we have to take the current WebPage scale
into account in order to properly fit the element to the screen,
regardless the web page scale.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore):
(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

07:48 Changeset [119319] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r119255.

  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
07:01 Changeset [119318] by zeno.albisser@nokia.com
  • 20 edits in trunk

Fix and enable WebGL for WebKit2 on Qt.
https://bugs.webkit.org/show_bug.cgi?id=86214

Source/WebCore:

Make GraphicsContext3DPrivate use GraphicsSurfaces
for WK2. The GraphicsContext3D then uses the existing
RenderBuffer for multisample rendering.
When WebGraphicsLayer::syncCompositingState is being
executed, the canvas is being synced as well. This means
that the RenderBuffer contents are being blit onto
a GraphicsSurface, and the GraphicsSurface token is
being sent to the UIProcess.
The WebLayerTreeRenderer then creates a
TextureMapperSurfaceBackingStore for the canvas and
passes the GraphicsSurface token as an argument.
The token can then be used to identify the GraphicsSurface
from the UIProcess side.

Reviewed by Noam Rosenthal.

  • platform/graphics/GraphicsContext3D.h:

Added createGraphicsSurfaces function. This is currently only
being used by the Qt port.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::reshape):
Calling the createGraphicsSurfaces function when the GraphicsContext3D
is reshaped. This is currently only relevant for the Qt port.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(GraphicsContext3DPrivate):
Added m_frontBufferGraphicsSurface, m_backBufferGraphicsSurface
and m_surfaceFlags members.
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
In case of WK2, create a QOpenGLContext and two GraphicsSurface
for sharing the WebGL content with the UIProcess. One GraphicsSurface
is being used as the front, the other one as the backbuffer.
Creating a QOpenGLContext currently requires showing a QWindow.
For the moment we therefore create a minimal QWindow and place
it offscreen.
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
This new function is called from the WebGraphicsLayer,
to blit the multisample framebuffer and copy its contents
onto the GraphicsSurface.
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
Whenever the GraphicsContext3D is being reshaped,
new GraphicsSurfaces must be created with the updated dimensions.
(WebCore::GraphicsContext3D::createGraphicsSurfaces):

  • platform/graphics/texmap/TextureMapperPlatformLayer.h:

Added a new virtual function copyToGraphicsSurface.
(TextureMapperPlatformLayer):
(WebCore::TextureMapperPlatformLayer::copyToGraphicsSurface):

Source/WebKit2:

Added glue code to make use of GraphicsSurface
as a backend for the webgl-canvas in case of WK2.

Reviewed by Noam Rosenthal.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::webGLEnabled):
(QWebPreferences::setWebGLEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:

Added WebGLEnabled enum to allow enabling/disabling of
WebGL using QWebPreferences.

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::syncCanvas):
Dispatch syncCanvas calls to the apropriate
WebLayerTreeRenderer.

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.messages.in:
  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::syncCanvas):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
Create a TextureMapperSurfaceBackingStore for the canvas
if necessary and pass or update the graphicsSurfaceToken
for to be used with the backing store.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore):
(WebCore::WebGraphicsLayer::setContentsToCanvas):
(WebCore::WebGraphicsLayer::syncCanvas):
Copy the multisample framebuffer contents onto the GraphicsSurface.
Notify the UIProcess of the availability of a new texture.
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
Sync the canvas as well.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

Added a pure virtual function syncCanvas.
This is guarded by PLATFORM(QT).
(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::syncLayerChildren):
(WebKit):
(WebKit::LayerTreeHostQt::syncCanvas):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

Tools:

Enable WebGL by default for Qt MiniBrowser.

Reviewed by Noam Rosenthal.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
02:46 Changeset [119317] by rniwa@webkit.org
  • 3 edits
    6 moves in trunk

Tools: Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=88164

Reviewed by Kentaro Hara.

Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.

  • Scripts/VCSUtils.pm:

(adjustPathForRecentRenamings):
(fixChangeLogPatch):

LayoutTests: Rename test_expectations.txt to TestExpectations.

  • platform/chromium/TestExpectations: Copied from LayoutTests/platform/chromium/test_expectations.txt.
  • platform/chromium/test_expectations.txt: Removed.
  • platform/efl/TestExpectations: Copied from LayoutTests/platform/efl/test_expectations.txt.
  • platform/efl/test_expectations.txt: Removed.
  • platform/gtk/TestExpectations: Copied from LayoutTests/platform/gtk/test_expectations.txt.
  • platform/gtk/test_expectations.txt: Removed.
  • platform/mac/TestExpectations: Copied from LayoutTests/platform/mac/test_expectations.txt.
  • platform/mac/test_expectations.txt: Removed.
  • platform/qt/TestExpectations: Copied from LayoutTests/platform/qt/test_expectations.txt.
  • platform/qt/test_expectations.txt: Removed.
  • platform/win/TestExpectations: Copied from LayoutTests/platform/win/test_expectations.txt.
  • platform/win/test_expectations.txt: Removed.
01:15 Changeset [119316] by tony@chromium.org
  • 55 edits in trunk

Rename the flexbox CSS propery values from start to flex-start and end to flex-end
https://bugs.webkit.org/show_bug.cgi?id=88152

Reviewed by Ojan Vafai.

Source/WebCore:

The spec changed. This is to differentiate from start/end which will
depend on writing mode direction, rather than flex direction.

No new tests, just updated the existing values.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EAlignContent):

  • css/CSSValueKeywords.in:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::initialJustifyContentOffset):
(WebCore::alignmentForChild):
(WebCore::initialAlignContentOffset):
(WebCore::RenderFlexibleBox::alignFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Rename start to flex-start and end to flex-end.

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-align-column.html:
  • css3/flexbox/flex-align-end.html:
  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/flex-pack.html:
  • css3/flexbox/line-wrapping.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-column-auto.html:
  • css3/flexbox/multiline-line-pack-horizontal-column-expected.txt:
  • css3/flexbox/multiline-line-pack-horizontal-column.html:
  • css3/flexbox/multiline-line-pack.html:
  • css3/flexbox/multiline-pack-expected.txt:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-reverse-wrap-baseline.html:
  • css3/flexbox/multiline-reverse-wrap-overflow.html:
  • css3/flexbox/multiline-shrink-to-fit.html:
  • css3/flexbox/multiline.html:
  • css3/flexbox/nested-stretch.html:
  • css3/flexbox/orthogonal-flex-directions.html:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
00:12 Changeset [119315] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Use 'Ok' and 'Cancel' buttons in JavaScript confirm box.
https://bugs.webkit.org/show_bug.cgi?id=76190
Based on Johannes Obermayrs (johannesobermayr@gmx.de) patch.
See: http://www.javascripter.net/faq/confirm.htm
Fixes: https://bugs.kde.org/show_bug.cgi?id=287629

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-02
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPage::javaScriptConfirm):

06/01/12:

23:44 Changeset [119314] by rniwa@webkit.org
  • 19 edits in trunk/Tools

Rename test_expectations.txt to TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=86690

Reviewed by Dirk Pranke.

Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
We can the code to read test_expectations.txt once we've successfully transitioned.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._check_path_does_not_exist):
(TestExpectationParser._tokenize):
(TestExpectations): Removed TEST_LIST, which is not used anywhere.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
test_expectations.txt if one exists and the path to TestExpectations otherwise.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
virtual.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.path_from_chromium_base):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.test_expectations):

  • Scripts/webkitpy/layout_tests/port/test.py:

(add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
(TestPort.init):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.baseline_search_path):
(WebKitPort.test_expectations):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these

tests to base as a follow up.
(WebKitPortTest.test_path_to_test_expectations_file):
(test_test_expectations):
(test_legacy_test_expectations):

  • Scripts/webkitpy/style/checker.py:

(CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
with one for TestExpectations.

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
test_expectations.txt.
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
(TestExpectationsTestCase.assert_lines_lint):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintExpectations.init):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineExpectations):

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit._check_test_expectations):

  • Scripts/webkitpy/tool/steps/commit_unittest.py:

(CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
(CommitTest.test_check_test_expectations): For TestExpectations.
(CommitTest.test_check_legacy_test_expectations): For test_expectations.txt

  • TestResultServer/static-dashboards/dashboard_base.js:

(requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
Error only when neither exists.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(processMissingAndExtraExpectations):
(htmlForTestsWithExpectationsButNoFailures):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
23:07 Changeset [119313] by commit-queue@webkit.org
  • 61 edits
    1 copy
    1 add in trunk/Source

[chromium] Software compositor initialization and base classes
https://bugs.webkit.org/show_bug.cgi?id=87920

Patch by Alexandre Elias <aelias@google.com> on 2012-06-01
Reviewed by James Robinson.

Source/Platform:

Add a new setting to force software compositing. In this mode,
no GraphicsContext3D should ever be created.

  • chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

This introduces new wrapper class CCGraphicsContext and base class
CCRenderer which will be used for software compositing support.
If no GraphicsContext3D is available, early return for now.

No new tests. (No-op change in 3d mode.)

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(Texture):
(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(BitmapSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(FrameBufferSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::Texture::updateRect):
(WebCore::ImageLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::CCRenderer::toGLMatrix):
(WebCore):
(WebCore::LayerRendererChromium::create):
(WebCore::CCRenderer::CCRenderer):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::copyPlaneToTexture):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):

  • platform/graphics/chromium/LayerRendererChromium.h:

(CCRenderer):
(WebCore::CCRenderer::~CCRenderer):
(WebCore::CCRenderer::ccContext):
(WebCore::CCRenderer::settings):
(WebCore::CCRenderer::viewportSize):
(WebCore::CCRenderer::viewportWidth):
(WebCore::CCRenderer::viewportHeight):
(WebCore::CCRenderer::projectionMatrix):
(WebCore::CCRenderer::windowMatrix):
(WebCore::CCRenderer::sharedGeometryQuad):
(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/LayerTextureSubImage.cpp:

(WebCore::LayerTextureSubImage::upload):
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):

  • platform/graphics/chromium/LayerTextureSubImage.h:

(WebCore):
(LayerTextureSubImage):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore):
(Texture):

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):

  • platform/graphics/chromium/ManagedTexture.h:

(WebCore):
(ManagedTexture):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:
  • platform/graphics/chromium/TextureCopier.cpp:

(WebCore::AcceleratedTextureCopier::copyTexture):

  • platform/graphics/chromium/TextureCopier.h:

(TextureCopier):
(AcceleratedTextureCopier):

  • platform/graphics/chromium/TextureUploader.h:

(TextureUploader):

  • platform/graphics/chromium/ThrottledTextureUploader.cpp:

(WebCore::ThrottledTextureUploader::uploadTexture):

  • platform/graphics/chromium/ThrottledTextureUploader.h:

(ThrottledTextureUploader):

  • platform/graphics/chromium/cc/CCGraphicsContext.h: Copied from Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.h.

(WebCore):
(CCGraphicsContext):
(WebCore::CCGraphicsContext::create2D):
(WebCore::CCGraphicsContext::create3D):
(WebCore::CCGraphicsContext::context3D):
(WebCore::CCGraphicsContext::CCGraphicsContext):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::willDraw):
(WebCore::CCLayerImpl::bindContentsTexture):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::createContext):
(WebCore::CCLayerTreeHost::context):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHostClient):
(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::context):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::layerRenderer):

  • platform/graphics/chromium/cc/CCProxy.h:

(WebCore):
(CCProxy):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::willDraw):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::recreateContext):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::update):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::initializeContextOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::reserveTextures):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

Add a new setting to force software compositing. In this mode,
no GraphicsContext3D should ever be created.

  • public/WebSettings.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::context):

  • src/WebLayerTreeViewImpl.cpp:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setForceSoftwareCompositing):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::forceSoftwareCompositing):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createCompositorGraphicsContext3D):
(WebKit::WebViewImpl::createContext3D):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::CCLayerTreeHostImplTest::createContext):
(WebKitTests::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):

  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::Texture::updateRect):

  • tests/CCTiledLayerTestCommon.h:

(Texture):
(WebKitTests::FakeTextureCopier::copyTexture):
(WebKitTests::FakeTextureUploader::uploadTexture):

  • tests/Canvas2DLayerChromiumTest.cpp:

(Canvas2DLayerChromiumTest::fullLifecycleTest):

  • tests/FakeCCLayerTreeHostClient.h:
  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(LayerRendererChromiumTest):
(TEST):

  • tests/TextureCopierTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

22:47 Changeset [119312] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Suppress text diff on http/tests/media/video-buffered.html on Chromium Leopard as
it has been failing on Leopard since it was re-enabled in http://trac.webkit.org/changeset/119268.
The failure is tracked by the bug 88160.

  • platform/chromium/test_expectations.txt:
20:20 Changeset [119311] by commit-queue@webkit.org
  • 19 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r119283, r119287, and r119291.
http://trac.webkit.org/changeset/119283
http://trac.webkit.org/changeset/119287
http://trac.webkit.org/changeset/119291
https://bugs.webkit.org/show_bug.cgi?id=88159

Not only broke compilation in the initial commit but also
broke LayerChromiumTest.basicCreateAndDestroy (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/AnimationTranslationUtil.cpp: Removed.
  • platform/graphics/chromium/AnimationTranslationUtil.h: Removed.
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::LinkHighlight):

  • platform/graphics/chromium/cc/CCAnimationCurve.h:

(CCTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:

(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCTransformKeyframe):
(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::addAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::add):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationControllerClient):
(CCLayerAnimationController):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.cpp:

(WebCore::addOpacityTransition):
(WebCore::addAnimatedTransform):
(WebKitTests::FakeTransformTransition::getValue):

  • tests/CCAnimationTestCommon.h:
  • tests/CCKeyframedAnimationCurveTest.cpp:
  • tests/CCLayerAnimationControllerTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted):
(WebKitTests::MockGraphicsLayerClient::notifySyncRequired):
(WebKitTests::MockGraphicsLayerClient::paintContents):
(WebKitTests::MockGraphicsLayerClient::showDebugBorders):
(WebKitTests::MockGraphicsLayerClient::showRepaintCounter):
(WebKitTests::TEST):

20:17 Changeset [119310] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Large number constant in TransformationMatrix::projectPoint overflows FractionalLayoutUnits with sub-pixel layout enabled
https://bugs.webkit.org/show_bug.cgi?id=87896

Reviewed by James Robinson.

kLargeNumber is meant to avoid overflowing when projecting a point through a transform. Unfortunately,
due to FractionalLayoutUnit's diminished range compared to integers, we were overflowing anyways. This
change adjusts our large number by the same value, but adjusted for our denominator.

This was originally missed because transforms/3d is marked as pass/fail in Chromium's test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=66989 tracks removing this problem.

No new tests. Covered by transforms/3d/hit-testing/perspective-clipped.html

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::projectPoint):

19:47 Changeset [119309] by wangxianzhu@chromium.org
  • 4 edits in trunk

Remove dependency from ImageDiff to WTF
https://bugs.webkit.org/show_bug.cgi?id=88147

Reviewed by Adam Barth.

Source/WTF:

  • WTF.gyp/WTF.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
19:09 Changeset [119308] by dpranke@chromium.org
  • 5 edits in trunk/Tools

NRWT seems to leak (more?) temp dirs
https://bugs.webkit.org/show_bug.cgi?id=88126

Re-land r119297 with chromium fix (weren't calling the
super() method if not in --test-shell mode in start().
Add unit tests to chromium_unittest as well to check.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.start):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.del):
(WebKitDriver._start):
(WebKitDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_stop_cleans_up_properly):
(WebKitDriverTest):
(WebKitDriverTest.test_two_starts_cleans_up_properly):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.test_stop_cleans_up_properly):
(ChromiumDriverTest.test_two_starts_cleans_up_properly):

18:38 Changeset [119307] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebCore

Cleanup GeneratorGeneratedImage/Gradient changes from r117858
https://bugs.webkit.org/show_bug.cgi?id=88063

Reviewed by Simon Fraser.

No new tests, code cleanup.

  • platform/graphics/Generator.h:

(WebCore::Generator::hash): hash() should be const.

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::drawPattern): Minor cleanup.

  • platform/graphics/Gradient.cpp:

(WebCore::Gradient::Gradient): Rename m_hashCache to m_cachedHash.
(WebCore::Gradient::addColorStop): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::sortStopsIfNecessary): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setSpreadMethod): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setGradientSpaceTransform): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::hash): Use intHash instead of the pair hasher. Add compile time size checks
for structures being passed to StringHasher.

  • platform/graphics/Gradient.h:

(WebCore::Gradient::setP0): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setP1): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setStartRadius): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setEndRadius): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::invalidateHash): Rename clearHashCache to invalidateHash.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::scalesMatch): Added. Determine if the scale of two AffineTransforms match.
(WebCore::GraphicsContext::isCompatibleWithBuffer): Make use of scalesMatch to simplify the logic.

18:26 Changeset [119306] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip more asserting tests on Windows.

  • platform/win/Skipped:
18:26 Changeset [119305] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Lots of "failed download-built-product" on Apple bots
https://bugs.webkit.org/show_bug.cgi?id=88158

Reviewed by Jessie Berlin.

Disable mergeRequests on all Apple builders. This is a speculative fix.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
18:00 Changeset [119304] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r119297.
http://trac.webkit.org/changeset/119297
https://bugs.webkit.org/show_bug.cgi?id=88156

May have broken Chromium bots (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.del):
(WebKitDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_stop_cleans_up_properly):

17:22 Changeset [119303] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG CFA should know that PutByVal can clobber the world
https://bugs.webkit.org/show_bug.cgi?id=88155

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

LayoutTests:

  • fast/js/dfg-putbyval-cfa-clobber-expected.txt: Added.
  • fast/js/dfg-putbyval-cfa-clobber.html: Added.
  • fast/js/script-tests/dfg-putbyval-cfa-clobber.js: Added.

(foo.bar):
(foo):

17:09 Changeset [119302] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Remove RefInfo class
https://bugs.webkit.org/show_bug.cgi?id=87904

Patch by Raymond Toy <rtoy@google.com> on 2012-06-01
Reviewed by Chris Rogers.

No new tests; covered by existing tests.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::~AudioBufferSourceNode): Clear
panner node.
(WebCore::AudioBufferSourceNode::totalPitchRate):
(WebCore::AudioBufferSourceNode::setPannerNode): Use
RefTypeConnection counting for panner node.
(WebCore):
(WebCore::AudioBufferSourceNode::clearPannerNode): New function to

clear panner node in AudioBufferSourceNode.

(WebCore::AudioBufferSourceNode::finish): Clear panner node when done.

  • Modules/webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode): Add virtual finish(), m_pannerNode is not
a RefPtr anymore.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::addDeferredFinishDeref): Remove unneeded RefTyp.
(WebCore::AudioContext::handleDeferredFinishDerefs): Remove
unneeded RefType.

  • Modules/webaudio/AudioContext.h:

(AudioContext): Update addDeferredFinishDeref signature.

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::deref): Update call to addDeferredFinishDeref.

  • Modules/webaudio/AudioScheduledSourceNode.h:

(AudioScheduledSourceNode): Make finish() virtual.

16:54 Changeset [119301] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFA should mark basic blocks as having constants if local accesses yield constants
https://bugs.webkit.org/show_bug.cgi?id=88153

Reviewed by Gavin Barraclough.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

16:47 Changeset [119300] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG arguments simplification phase uses a node.codeOrigin after appending a node
https://bugs.webkit.org/show_bug.cgi?id=88151

Reviewed by Geoffrey Garen.

The right thing to do is to save the CodeOrigin before appending to the graph.

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

16:18 Changeset [119299] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG should not emit unnecessary speculation checks when performing an int32 to double conversion on
a value that is proved to be a number, predicted to be an int32, but not proved to be an int32
https://bugs.webkit.org/show_bug.cgi?id=88146

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):

LayoutTests:

  • fast/js/dfg-int32-to-double-on-known-number-expected.txt: Added.
  • fast/js/dfg-int32-to-double-on-known-number.html: Added.
  • fast/js/script-tests/dfg-int32-to-double-on-known-number.js: Added.

(foo.bar):
(foo):

16:18 Changeset [119298] by tony@chromium.org
  • 60 edits in trunk

rename -webkit-flex-pack and -webkit-flex-line-pack to -webkit-justify-content and -webkit-align-content
https://bugs.webkit.org/show_bug.cgi?id=88113

Reviewed by Ojan Vafai.

Source/WebCore:

This recently changed in the spec:
http://dev.w3.org/csswg/css3-flexbox/#justify-content-property
http://dev.w3.org/csswg/css3-flexbox/#align-content-property

No new tests, updated existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EAlignContent):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::initialJustifyContentOffset):
(WebCore::justifyContentSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
(WebCore::initialAlignContentOffset):
(WebCore::alignContentSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::alignFlexLines):

  • rendering/RenderFlexibleBox.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

Find and replace for the CSS keywords.

  • css3/flexbox/columns-auto-size.html:
  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-pack.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-column-auto.html:
  • css3/flexbox/multiline-line-pack-expected.txt:
  • css3/flexbox/multiline-line-pack-horizontal-column-expected.txt:
  • css3/flexbox/multiline-line-pack-horizontal-column.html:
  • css3/flexbox/multiline-line-pack.html:
  • css3/flexbox/multiline-pack-expected.txt:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-reverse-wrap-overflow.html:
  • css3/flexbox/multiline-shrink-to-fit.html:
  • css3/flexbox/multiline.html:
  • css3/flexbox/nested-stretch.html:
  • css3/flexbox/position-absolute-child.html:
  • css3/flexbox/true-centering.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
16:11 Changeset [119297] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt seems to leak tmpdirs
https://bugs.webkit.org/show_bug.cgi?id=88126

Reviewed by Ojan Vafai.

Fix leak possibly introduced in r118979 - we now will
make sure we clean up any stale temp directories during the
start routine and attempt to clean up again in del. It
turns out that asserting in del logs a message but is
caught by the runtime, so it's mostly useless.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.del):
(WebKitDriver._start):
(WebKitDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_stop_cleans_up_properly):
(WebKitDriverTest):
(WebKitDriverTest.test_two_starts_cleans_up_properly):

16:09 Changeset [119296] by ap@apple.com
  • 6 edits
    1 delete in trunk/LayoutTests

Make cookie tests debuggable by merging scripts into HTML
https://bugs.webkit.org/show_bug.cgi?id=88143

Reviewed by Anders Carlsson.

  • http/tests/cookies/double-quoted-value-with-semi-colon.html:
  • http/tests/cookies/multiple-cookies.html:
  • http/tests/cookies/script-tests: Removed.
  • http/tests/cookies/script-tests/TEMPLATE.html: Removed.
  • http/tests/cookies/script-tests/double-quoted-value-with-semi-colon.js: Removed.
  • http/tests/cookies/script-tests/multiple-cookies.js: Removed.
  • http/tests/cookies/script-tests/simple-cookies-expired.js: Removed.
  • http/tests/cookies/script-tests/simple-cookies-max-age.js: Removed.
  • http/tests/cookies/script-tests/single-quoted-value.js: Removed.
  • http/tests/cookies/simple-cookies-expired.html:
  • http/tests/cookies/simple-cookies-max-age.html:
  • http/tests/cookies/single-quoted-value.html:
15:59 Changeset [119295] by jberlin@webkit.org
  • 1 edit
    48 adds in trunk/LayoutTests

[Win] Windows 7 Release Testers report many compositing failures
https://bugs.webkit.org/show_bug.cgi?id=88040

Part 2 of adding expected (failing?) results to get the bots greener.

  • platform/win/compositing/images: Added.
  • platform/win/compositing/images/clip-on-directly-composited-image-expected.txt: Added.
  • platform/win/compositing/images/direct-image-background-color-expected.txt: Added.
  • platform/win/compositing/images/direct-pdf-image-expected.txt: Added.
  • platform/win/compositing/images/direct-svg-image-expected.txt: Added.
  • platform/win/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
  • platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-animation-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-child-layer-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-clipping-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-transformed-layer-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-transforms-expected.txt: Added.
  • platform/win/compositing/layer-creation/rotate3d-overlap-expected.txt: Added.
  • platform/win/compositing/layer-creation/scroll-partial-update-expected.txt: Added.
  • platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
  • platform/win/compositing/layer-creation/stacking-context-overlap-expected.txt: Added.
  • platform/win/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
  • platform/win/compositing/layer-creation/translatez-overlap-expected.txt: Added.
  • platform/win/compositing/masks: Added.
  • platform/win/compositing/masks/direct-image-mask-expected.txt: Added.
  • platform/win/compositing/masks/masked-ancestor-expected.txt: Added.
  • platform/win/compositing/masks/multiple-masks-expected.txt: Added.
  • platform/win/compositing/masks/simple-composited-mask-expected.txt: Added.
  • platform/win/compositing/overflow/ancestor-overflow-expected.txt
  • platform/win/compositing/overflow/clip-descendents-expected.txt: Added.
  • platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/win/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • platform/win/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
  • platform/win/compositing/overflow/overflow-positioning-expected.txt: Added.
  • platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • platform/win/compositing/overflow/resize-painting-expected.txt: Added.
  • platform/win/compositing/rtl: Added.
  • platform/win/compositing/rtl/rtl-absolute-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-relative-expected.txt: Added.
  • platform/win/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
  • platform/win/compositing/visibility: Added.
  • platform/win/compositing/visibility/layer-visible-content-expected.txt: Added.
  • platform/win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
15:53 Changeset [119294] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Overflow scrolling doesn't need to create a stacking context is the overflow is hidden
https://bugs.webkit.org/show_bug.cgi?id=88057

Reviewed by James Robinson.

This patch causes us to match the iOS implementation of this feature.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

15:50 Changeset [119293] by mrowe@apple.com
  • 4 edits in branches/safari-536-branch/Source

Versioning.

15:44 Changeset [119292] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG constant folding search for the last local access skips the immediately previous local access
https://bugs.webkit.org/show_bug.cgi?id=88141

Source/JavaScriptCore:

Reviewed by Michael Saboff.

If you use a loop in the style of:

for (i = start; i--;)

then you need to remember that the first value of 'i' that the loop body will see is 'start - 1'.
Hence the following is probably wrong:

for (i = start - 1; i--;)

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

LayoutTests:

Reviewed by Michael Saboff.

  • fast/js/dfg-obvious-constant-cfa-expected.txt: Added.
  • fast/js/dfg-obvious-constant-cfa.html: Added.
  • fast/js/script-tests/dfg-obvious-constant-cfa.js: Added.

(bar.baz):
(bar):

15:43 Changeset [119291] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Use fully qualified name for Fixed to avoid the collision with "typedef SInt32 Fixed" in MacTypes.h

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKitTests::TEST_F):

15:34 Changeset [119290] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix the return value checking in SelectPopupClient
https://bugs.webkit.org/show_bug.cgi?id=88130

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-01
Reviewed by Rob Buis.

In SelectPopupClient, return '1' means selected, '0' means not selected,
the ASCII value of '0' is 48, not 32, use '0' to be more readable.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::setValueAndClosePopup):

15:32 Changeset [119289] by rniwa@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Chromium rebaseline after r119274.

  • platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/chromium-mac-leopard/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/chromium-win/fast/reflections/reflection-with-zoom-expected.png: Added.
15:15 Changeset [119288] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix a typo in the expected result for the test added in r119281.119281

  • fast/js/dfg-cse-cfa-discrepancy-expected.txt:
15:14 Changeset [119287] by jamesr@google.com
  • 5 edits in trunk/Source

[chromium] Unreviewed compile fix for r119283

For the record, Dana Jensens <danakj@chromium.org> wrote this slightly faster than I did.

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::bounds):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::bounds):

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.h:
15:11 Changeset [119286] by ap@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/cookies/simple-cookies-expired.html and simple-cookies-max-age.html are failing
https://bugs.webkit.org/show_bug.cgi?id=82749

I don't see any failures locally (other than sometimes as flakiness in all cookie
tests), and the bug report doesnt' have any information about what was wrong.

  • platform/mac/Skipped: Re-enable to see what happens.
14:59 Changeset [119285] by jberlin@webkit.org
  • 3 edits
    48 adds in trunk/LayoutTests

[Win] Windows 7 Release Testers report many compositing failures
https://bugs.webkit.org/show_bug.cgi?id=88040

Part 1 of adding expected (failing?) results to get the bots greener.

  • platform/win/compositing/geometry/flipped-writing-mode-expected.txt: Added.
  • platform/win/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/win/compositing/geometry/foreground-offset-change-expected.txt: Added.
  • platform/win/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
  • platform/win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
  • platform/win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
  • platform/win/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
  • platform/win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/win/compositing/geometry/outline-change-expected.txt: Added.
  • platform/win/compositing/geometry/partial-layout-update-expected.txt: Added.
  • platform/win/compositing/geometry/preserve-3d-switching-expected.txt: Added.
  • platform/win/compositing/geometry/root-layer-update-expected.txt: Added.
  • platform/win/compositing/geometry/tall-page-composited-expected.txt: Added.
  • platform/win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added.
  • platform/win/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
  • platform/win/compositing/geometry/video-opacity-overlay-expected.txt: Added.
  • platform/win/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
  • platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
  • platform/win/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-content-flipping-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/win/compositing/iframes/invisible-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/invisible-nested-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Added.
  • platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/win/compositing/iframes/layout-on-compositing-change-expected.txt: Added.
  • platform/win/compositing/iframes/nested-iframe-scrolling-expected.txt: Added.
  • platform/win/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • platform/win/compositing/iframes/page-cache-layer-tree-expected.txt: Added.
  • platform/win/compositing/iframes/resizer-expected.txt: Added.
  • platform/win/compositing/iframes/scrolling-iframe-expected.txt: Added.
14:53 Changeset [119284] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding a TEXT expectation for http/tests/media/video-buffered.html
after it started failing in r119268.

  • platform/gtk/test_expectations.txt:
14:46 Changeset [119283] by commit-queue@webkit.org
  • 18 edits
    2 adds in trunk/Source

[chromium] Accelerated animations should use WebTransformOperations
https://bugs.webkit.org/show_bug.cgi?id=87686

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-01
Reviewed by James Robinson.

CCTransformKeyframe new owns a WebTransformOperations rather than a
TransformOperations. LayerChromium's API has been changed so that
LayerChromium::addAnimation should take only a CCActiveAnimation.
GraphicsLayerChromium is new responsible for translating to
WebTransformOperations and creating CCActiveAnimations. Tests that use
the public API (that is, they call addAnimation with KeyframeValueList
and Animation arguments) have been moved to GraphicsLayerChromiumTest.

Source/WebCore:

Unit tests:

GraphicsLayerChromiumTest.createOpacityAnimation
GraphicsLayerChromiumTest.createTransformAnimation
GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
GraphicsLayerChromiumTest.createTransformAnimationWithSingularMatrix
GraphicsLayerChromiumTest.createReversedAnimation
GraphicsLayerChromiumTest.createAlternatingAnimation
GraphicsLayerChromiumTest.createReversedAlternatingAnimation

  • WebCore.gypi:
  • platform/graphics/chromium/AnimationTranslationUtil.cpp: Added.

(WebCore):
(WebCore::toWebTransformOperations):
(WebCore::appendKeyframe):
(WebCore::CCKeyframedTransformAnimationCurve):
(WebCore::createActiveAnimation):

  • platform/graphics/chromium/AnimationTranslationUtil.h: Added.

(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):

  • platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::LinkHighlight):

  • platform/graphics/chromium/cc/CCAnimationCurve.h:

(CCTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:

(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCTransformKeyframe):
(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::removeAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::addAnimation):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationControllerClient):
(CCLayerAnimationController):

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.cpp:

(WebCore::addOpacityTransition):
(WebCore::addAnimatedTransform):
(WebKitTests::FakeTransformTransition::getValue):

  • tests/CCAnimationTestCommon.h:
  • tests/CCKeyframedAnimationCurveTest.cpp:

(WebCore::TEST):

  • tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests::TEST):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):

  • tests/GraphicsLayerChromiumTest.cpp:

(MockLayerTreeHostClient):
(WebKitTests):
(MockLayerTreeHost):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::expectTranslateX):
(WebKitTests::TEST_F):

14:34 Changeset [119282] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

DFG constant folding should be OK with GetLocal of captured variables having a constant
https://bugs.webkit.org/show_bug.cgi?id=88137

Fix a typo that Gavin found but that I failed to fix in previous commit.

  • fast/js/script-tests/dfg-cse-cfa-discrepancy.js:
14:32 Changeset [119281] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG constant folding should be OK with GetLocal of captured variables having a constant
https://bugs.webkit.org/show_bug.cgi?id=88137

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

LayoutTests:

  • fast/js/dfg-cse-cfa-discrepancy-expected.txt: Added.
  • fast/js/dfg-cse-cfa-discrepancy.html: Added.
  • fast/js/script-tests/dfg-cse-cfa-discrepancy.js: Added.

(foo.bar.baz):
(foo.bar):
(foo):

14:26 Changeset [119280] by msaboff@apple.com
  • 4 edits in trunk

WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
https://bugs.webkit.org/show_bug.cgi?id=88109

Reviewed by Geoffrey Garen.

Source/WebKit/mac:

Added short circuit return when the NSString to evaluate is nil.

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

Tools:

Additional test case.

  • TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:

(TestWebKitAPI::TEST):

14:04 Changeset [119279] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] ASSERT(enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()))
failed in RenderGeometryMap::absoluteRect
https://bugs.webkit.org/show_bug.cgi?id=88128

Add affected tests to the Windows Skipped list.

  • platform/win/Skipped:

Also, fix the line endings for this file.

14:00 Changeset [119278] by zandobersek@gmail.com
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed GTK gardening, adding new baselines after r119256.

  • platform/gtk/fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-ordering-5-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-ordering-6-expected.txt: Added.
13:47 Changeset [119277] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88131

Unreviewed addition to Chromium test expectations.

  • platform/chromium/test_expectations.txt:
13:23 Changeset [119276] by mihaip@chromium.org
  • 5 edits in trunk

Improve synchronous XHR disabling
https://bugs.webkit.org/show_bug.cgi?id=88032

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setSyncXHRInDocumentsEnabled): Fix a
copy-and-paste error

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open): Improves the disabled message, as
suggested in a comment after r118599 was put in the commit queue.

LayoutTests:

Update with new error message.

  • fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt:
13:22 Changeset [119275] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix QObject bridge tests in Qt5 after (not so) recent QVariant changes
https://bugs.webkit.org/show_bug.cgi?id=88127

Reviewed by Noam Rosenthal.

We were checking for invalid QVariants in a very odd way. Since in Qt5 the
userType of invalid changed to not be Void, this broke the tests for QtWebKit
with Qt5. Replace those checks with QVariant::isValid() calls.

  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::evalJS):
(tst_QObjectBridge::evalJSV):

13:20 Changeset [119274] by bdakin@apple.com
  • 4 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=87774
REGRESSION (r105515): reflection masks are truncated at zoom levels < 1
-and corresponding-
<rdar://problem/11387506>

Reviewed by Simon Fraser.

Source/WebCore:

paintNinePieceImage() expects un-zoomed results from
calculateImageIntrinsicDimensions(). This was previously addressed by having
paintNinePieceImage() divide the effective zoom out of the result from
calculateImageIntrinsicDimensions(). However, that results in buggy behavior for
generated images and images with percentage sizes. In the end it seems best to
just send a parameter to calculateImageIntrinsicDimensions() indicating whether
the caller wants the result to be scaled by the effective zoom when appropriate.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

LayoutTests:

  • fast/reflections/reflection-with-zoom.html: Added.
  • platform/mac/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/mac/fast/reflections/reflection-with-zoom-expected.txt: Added.
13:15 Changeset [119273] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Another Chromium test expectation update per the bug 88124.

Unreviewed Chromium test expectations fix.

  • platform/chromium/test_expectations.txt:
13:15 Changeset [119272] by jchaffraix@webkit.org
  • 6 edits in trunk/Source/WebCore

Prepare table collapsed border computation to support mixed directionality on row group
https://bugs.webkit.org/show_bug.cgi?id=88110

Reviewed by Ojan Vafai.

No expected change in behavior.

One big issue with supporting mixed directionality inside a table is that the start / end
borders don't align between table parts anymore: the start border of a ltr table will have
to match the end border of a rtl row group for the purpose of collapsed border computation.

This change adds the concept of adjoining borders in the table direction so that we can safely
hide which exact borders we pick up for the collapsed border computation.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
Refactored those functions to use proper naming along with the new APIs. The name 'adjoining' is
used extensively as we cannot make any assumptions on which borders we will get.

(WebCore::RenderTable::recalcBordersInRowDirection):
Added a FIXME found during testing.

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):

  • rendering/RenderTableRow.h:

(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
Those functions are the same at the moment to match the existing code. They
will be changed to use the proper directionality in a follow up patch.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
Those functions return the cells that is adjoining a table edge. Due to us flipping
the cells at layout to match the section's direction, those functions will need to
account for mixed direction in determining the right cell to consider.

13:13 Changeset [119271] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline of svg/css/getComputedStyle-basic for mac.

  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
13:08 Changeset [119270] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Indenting a paragraph that begins with a link 3 times breaks the paragraph into two paragraphs
https://bugs.webkit.org/show_bug.cgi?id=87428

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-06-01
Reviewed by Ryosuke Niwa.

Source/WebCore:

Fix the way lastNode (our insertion point) is updated whenever
traverseNextSibling moves up to a new parent, so that the relative
depth between the next sibling and the original start node is
maintained in the clone. The divergence in depth broke the paragraph
into two paragraphs because the next sibling was inserted outside the
blockquote that was created for the indentation.

Note that the topNode is not required anymore because it is no longer
used anywhere.

Tests: editing/execCommand/indent-nested-inlines-1.html

editing/execCommand/indent-nested-inlines-2.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

LayoutTests:

Adding two tests for indenting nested inlines.

  • editing/execCommand/indent-nested-inlines-1-expected.txt: Added.
  • editing/execCommand/indent-nested-inlines-1.html: Added.
  • editing/execCommand/indent-nested-inlines-2-expected.txt: Added.
  • editing/execCommand/indent-nested-inlines-2.html: Added.
13:00 Changeset [119269] by hausmann@webkit.org
  • 5 edits in trunk

[Qt] Use -Werror only in developer builds

Rubber-stamped by Tor Arne Vestbø.

In production builds -Werror with custom toolchains and wierd system
headers, -Werror is of no use and just creates confusion. So use it
only if Qt is configured with -developer-build.

.:

  • Source/api.pri: qt_developer_build determination moved to default_pre.prf

Tools:

  • qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
  • qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror

only if qt_developer_build is set.

12:58 Changeset [119268] by fischman@chromium.org
  • 4 edits in trunk/LayoutTests

[chromium] Unskip http/tests/media/video-buffered.html
https://bugs.webkit.org/show_bug.cgi?id=87568

Reviewed by Eric Carlson.

  • http/tests/media/video-buffered-expected.txt:
  • http/tests/media/video-buffered.html:
  • platform/chromium/test_expectations.txt:
12:57 Changeset [119267] by caio.oliveira@openbossa.org
  • 4 edits
    1 copy
    2 adds in trunk

[Qt] Move QObject bridge related tests from tst_qwebframe to tst_qobjectbridge
https://bugs.webkit.org/show_bug.cgi?id=88117

Reviewed by Noam Rosenthal.

.:

  • Source/tests.pri: Add new entry for tst_qobjectbridge.

Source/WebKit/qt:

Five tests (classEnums, classConstructor, transferInvokable, findObject and
findChildren) were removed since they contained commented code since the file was
added back in 2008. The QObject bridge tests were probably inspired in similar
tests for QtScript, so many features not yet implemented were present in QtWebKit
tests but commented.

Other minor changes:

  • Moved MyEnumTestQObject near the only test function that uses it.
  • Removed unnecessary Q_INVOKABLE from setBrushProperty.
  • Removed some bits of dead / commented code.
  • tests/qobjectbridge/qobjectbridge.pro: Added.
  • tests/qobjectbridge/tst_qobjectbridge.cpp: Copied from Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp.

Kept only the tests related to QObject bridge implementation.

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame):
(tst_QWebFrame::init):
(tst_QWebFrame::cleanup):

12:52 Changeset [119266] by jochen@chromium.org
  • 2 edits in trunk/Tools

[watchlist] Add myself to loader and v8 bindings changes
https://bugs.webkit.org/show_bug.cgi?id=88112

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:
12:41 Changeset [119265] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Another Chromium test expectation update per the bug 88124.

  • platform/chromium/test_expectations.txt:
12:39 Changeset [119264] by zhajiang@rim.com
  • 2 edits in trunk/Tools

Adding Jacky Jiang to committers.py
https://bugs.webkit.org/show_bug.cgi?id=88122

Reviewed by Rob Buis.

Adding myself to committers.py as a Committer.

  • Scripts/webkitpy/common/config/committers.py:
12:38 Changeset [119263] by ap@apple.com
  • 3 edits in branches/safari-536-branch/LayoutTests

Update test results after r119025

  • platform/mac/mathml/presentation/mo-stretch-expected.txt: Clearly incorrect results were landed for this test, not sure how that happened (I cannot find these wrong results anywhere in trunk history).
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt: Looks like this test was not updated with others. The only observable difference is a slightly smaller width of an input field, which matches what one could expect from the change.
12:32 Changeset [119262] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
12:32 Changeset [119261] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/11335622> and https://bugs.webkit.org/show_bug.cgi?id=88119
REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call

Followup to r119260

Rubber-stamped by Anders Carlsson.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow): Set the m_hasCalledSetWindow here...
(WebKit::NetscapePlugin::geometryDidChange): ...instead of here.

12:24 Changeset [119260] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/11335622> and https://bugs.webkit.org/show_bug.cgi?id=88119
REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call

Reviewed by Oliver Hunt.

Add a flag to NetscapePlugin to track whether or not NPP_SetWindow has ever been called.
Check this flag in geometryDidChange to make sure every plug-in gets the call at least once.

"Everybody gets one. Tell him, Peter."
"Apparently everybody gets one."
"Bingo."

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
(WebKit::NetscapePlugin::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):

12:00 Changeset [119259] by commit-queue@webkit.org
  • 7 edits in trunk

getComputedStyle for background shorthand property does not return background-origin and background-clip.
https://bugs.webkit.org/show_bug.cgi?id=86155

Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-01
Reviewed by Tony Chang.

Added background-origin and background-clip CSS Property values to the background shorthand CSSValueList.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getBackgroundShorthandValue):

LayoutTests:

  • fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
  • fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
  • fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-background-shorthand.html:
11:55 Changeset [119258] by pilgrim@chromium.org
  • 14 edits
    1 delete in trunk/Source

[Chromium] Call clipboard methods directly
https://bugs.webkit.org/show_bug.cgi?id=88038

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • chromium/public/WebClipboard.h:

(WebKit::WebClipboard::sequenceNumber):

Source/WebCore:

  • WebCore.gypi:
  • platform/Pasteboard.h:

(Pasteboard):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::createFromPasteboard):

  • platform/chromium/ChromiumDataObjectItem.cpp:

(WebCore::ChromiumDataObjectItem::getAsFile):
(WebCore::ChromiumDataObjectItem::internalGetAsString):

  • platform/chromium/ClipboardUtilitiesChromium.cpp:

(WebCore::currentPasteboardBuffer):

  • platform/chromium/ClipboardUtilitiesChromium.h:

(WebCore):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::writeClipboard):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):

  • platform/chromium/PasteboardPrivate.h: Removed.
  • platform/chromium/PlatformSupport.h:

(WebCore):
(PlatformSupport):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
  • src/PlatformSupport.cpp:

(WebCore::getCookieJar):

11:33 Changeset [119257] by jberlin@webkit.org
  • 2 edits in trunk/Tools

Fix Windows build.

  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
11:24 Changeset [119256] by commit-queue@webkit.org
  • 6 edits
    26 adds in trunk

Improve handling of legacy viewport meta tags
https://bugs.webkit.org/show_bug.cgi?id=55874

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-06-01
Reviewed by Adam Barth.

Source/WebCore:

We now support MobileOptimized and HandheldFriendly as well.

We set width equal to device-width for HandheldFriendly and
for MobileOptimized, the content value of MobileOptimized is
ignored and the initial-scale set to 1 to fit Android behavior.

The prioritizing is done the same way as on Windows Phone 7:

XHTML Mobile Profile found
HandheldFriendly
MobileOptimized (overrides HandheldFriendly)
Viewport (overrides all above)

Original patch by Kenneth Rohde Christiansen.

Tests: fast/viewport/viewport-legacy-handheldfriendly.html

fast/viewport/viewport-legacy-mobileoptimized-2.html
fast/viewport/viewport-legacy-mobileoptimized-3.html
fast/viewport/viewport-legacy-mobileoptimized.html
fast/viewport/viewport-legacy-ordering-1.html
fast/viewport/viewport-legacy-ordering-2.html
fast/viewport/viewport-legacy-ordering-3.html
fast/viewport/viewport-legacy-ordering-4.html
fast/viewport/viewport-legacy-ordering-5.html
fast/viewport/viewport-legacy-ordering-6.html
fast/viewport/viewport-legacy-ordering-7.html
fast/viewport/viewport-legacy-ordering-8.html
fast/viewport/viewport-legacy-ordering-9.html

  • dom/Document.cpp:

(WebCore::Document::setDocType):
(WebCore::Document::processViewport): Add an origin parameter to
tell what is changing the viewport.

  • dom/Document.h:

(Document):

  • dom/ViewportArguments.h:
  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

LayoutTests:

Add tests and expected results.

  • fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Added.
  • fast/viewport/viewport-legacy-handheldfriendly.html: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-2.html: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-3.html: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Added.
  • fast/viewport/viewport-legacy-mobileoptimized.html: Added.
  • fast/viewport/viewport-legacy-ordering-1-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-1.html: Added.
  • fast/viewport/viewport-legacy-ordering-2-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-2.html: Added.
  • fast/viewport/viewport-legacy-ordering-3-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-3.html: Added.
  • fast/viewport/viewport-legacy-ordering-4-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-4.html: Added.
  • fast/viewport/viewport-legacy-ordering-5-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-5.html: Added.
  • fast/viewport/viewport-legacy-ordering-6-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-6.html: Added.
  • fast/viewport/viewport-legacy-ordering-7-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-7.html: Added.
  • fast/viewport/viewport-legacy-ordering-8-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-8.html: Added.
  • fast/viewport/viewport-legacy-ordering-9-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-9.html: Added.
11:10 Changeset [119255] by tony@chromium.org
  • 43 edits in trunk

rename -webkit-flex-order to -webkit-order
https://bugs.webkit.org/show_bug.cgi?id=88104

Reviewed by Ojan Vafai.

Source/WebCore:

This recently changed in the spec:
http://dev.w3.org/csswg/css3-flexbox/#order-property

No new tests, just updated existing results.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::OrderIterator::OrderIterator):
(WebCore::RenderFlexibleBox::OrderIterator::next):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
(WebCore::RenderFlexibleBox::packFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
(WebCore::RenderFlexibleBox::flipForWrapReverse):

  • rendering/RenderFlexibleBox.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

Just a find and replace for the new property name.

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-order.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
10:50 Changeset [119254] by fmalita@chromium.org
  • 2 edits
    1 copy
    1 move
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed. Adding Win and Mac baselines after r119241.

Patch by Florin Malita <fmalita@chromium.org> on 2012-06-01

  • platform/chromium-mac/svg/repaint/text-mask-update-expected.png: Added.
  • platform/chromium-mac/svg/repaint/text-mask-update-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.txt.
  • platform/chromium-win/svg/repaint/text-mask-update-expected.png: Added.
  • platform/chromium-win/svg/repaint/text-mask-update-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.txt.
  • platform/chromium/test_expectations.txt:
10:31 Changeset [119253] by jberlin@webkit.org
  • 5 edits
    2 adds in trunk/LayoutTests

[Win] 9 plugin tests fail/time out
https://bugs.webkit.org/show_bug.cgi?id=88107

Skip the ones that time out and add/update platform-specific results for the the ones that
fail to get the bots greener.

  • platform/win/Skipped:
  • platform/win/plugins/get-value-netscape-window-expected.txt:
  • platform/win/plugins/netscape-dom-access-and-reload-expected.txt: Added.
  • platform/win/plugins/npn-invalidate-rect-invalidates-window-expected.txt:
  • platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt:
  • platform/win/plugins/geturlnotify-during-document-teardown-expected.txt
10:26 Changeset [119252] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r119247.

Do not include TextureMapperGL.h when not building
with GRAPHICS_SURFACE.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:
10:16 Changeset [119251] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] WebLayerTreeRenderer::setContentsSize called synchronously
https://bugs.webkit.org/show_bug.cgi?id=88091

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Noam Rosenthal.

Do not call WebLayerTreeRenderer::setContentsSize synchronously
from LayerTreeHostProxy.

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::setContentsSize):

10:09 Changeset [119250] by jberlin@webkit.org
  • 2 edits in trunk/Tools

Windows WK2 MouseMoveAfterCrash API test failing
https://bugs.webkit.org/show_bug.cgi?id=69982

Disable the test on Windows to get the bots greener.

  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:

(TestWebKitAPI::TEST):

10:05 Changeset [119249] by mario@webkit.org
  • 3 edits
    4 adds in trunk/Source/WebCore

[GTK] Add a new and reusable Geoclue-based geolocation provider in WebCore
https://bugs.webkit.org/show_bug.cgi?id=87800

Reviewed by Carlos Garcia Campos.

Added new and reusable Geoclue-based geolocation provider to WebCore.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • platform/geoclue/GeolocationProviderGeoclue.cpp: Added.

(getPositionCallback):
(positionChangedCallback):
(GeolocationProviderGeoclue::GeolocationProviderGeoclue):
(GeolocationProviderGeoclue::~GeolocationProviderGeoclue):
(GeolocationProviderGeoclue::startUpdating):
(GeolocationProviderGeoclue::stopUpdating):
(GeolocationProviderGeoclue::setEnableHighAccuracy):
(GeolocationProviderGeoclue::setGeoclueClient):
(GeolocationProviderGeoclue::setGeocluePosition):
(GeolocationProviderGeoclue::updateClientRequirements):
(GeolocationProviderGeoclue::positionChanged):
(GeolocationProviderGeoclue::errorOccured):

  • platform/geoclue/GeolocationProviderGeoclue.h: Added.

(WebCore):
(GeolocationProviderGeoclue):

  • platform/geoclue/GeolocationProviderGeoclueClient.h: Added.

(WebCore):
(GeolocationProviderGeoclueClient):

10:04 Changeset [119248] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Remove deprecated Q_GLOBAL_STATIC_WITH_INITIALIZER
https://bugs.webkit.org/show_bug.cgi?id=88100

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-01
Reviewed by Tor Arne Vestbø.

It will be deprecated on Qt5.

  • platform/text/qt/TextBreakIteratorInternalICUQt.cpp:

(WebCore):

10:02 Changeset [119247] by zeno.albisser@nokia.com
  • 7 edits in trunk/Source/WebCore

Make TextureMapper work with GraphicsSurface.
https://bugs.webkit.org/show_bug.cgi?id=87738

Add TextureMapperSurfaceBackingStore, a new backing store
that allows to import textures from a GraphicsSurface.
On Mac the GraphicsSurface is backed by an IOSurface
which must be used with a GL_TEXTURE_RECTANGLE_ARB texture.
Therefore it is also necessary to add new shader programs
for directly painting these textures on screen.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

Add a new TextureMapperBackingStore implementation that can directly
reuse textures as they are being passed from the GraphicsSurface.
(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::texture):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(GraphicsSurfaceData):
(WebCore::GraphicsSurfaceData::setSurface):
(WebCore::GraphicsSurfaceData::GraphicsSurfaceData):
(TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::create):
(WebCore::TextureMapperSurfaceBackingStore::~TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::TextureMapperSurfaceBackingStore):

  • platform/graphics/texmap/TextureMapperGL.cpp:

Add a drawing function for textures of type GL_TEXTURE_RECTANGLE_ARB.
(WebCore::TextureMapperGL::drawTextureRectangleARB):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderProgramSimple::create):
(WebCore::TextureMapperShaderProgramSimple::initialize):
(WebCore::TextureMapperShaderProgramSolidColor::create):
(WebCore::TextureMapperShaderProgramSolidColor::initialize):
(WebCore::TextureMapperShaderProgramRectSimple::create):
(WebCore::TextureMapperShaderProgramRectSimple::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramOpacityAndMask::initialize):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::fragmentShaderSource):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

Add new shader programs that can be used with GL_TEXTURE_RECTANGLE_ARB textures.
This is mainly necessary, because this type of texture uses non-normalized coordinates.
Further move the calls to initializeProgram() from the constructor into a separate
initialize() function, as initializeProgram() calls vertexShaderSource() (and friends)
and we should not call virtual functions in the constructor.
(WebCore::TextureMapperShaderProgram::initialize):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple):
(TextureMapperShaderProgramRectSimple):
(WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(TextureMapperShaderProgramRectOpacityAndMask):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::TextureMapperShaderProgramRectOpacityAndMask):
(TextureMapperShaderProgramSolidColor):
(WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):

09:57 Changeset [119246] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip some plugin tests that crash/assert on Windows.

  • platform/win/Skipped:
09:50 Changeset [119245] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Set QWebKitTest::isScalable default as false
https://bugs.webkit.org/show_bug.cgi?id=88095

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Tor Arne Vestbø.

Set QWebKitTest::isScalable default as false

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::isScalable):

09:41 Changeset [119244] by pdr@google.com
  • 2 edits
    2 copies in branches/chromium/1084

Merge 117365 - Crash if SVG gradient stop has display: none set

09:35 Changeset [119243] by commit-queue@webkit.org
  • 19 edits in trunk

[EFL] EFL port does not enable WEB_INTENTS_TAG flag
https://bugs.webkit.org/show_bug.cgi?id=86866

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-01
Reviewed by Adam Barth.

.:

Enable WEB_INTENTS_TAG flag by default on EFL port.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Fix compilation error when WEB_INTENTS_TAG flag is enabled.
HTMLElement::insertedInto() takes a ContainerNode* in argument, not a
Node*.

Test: webintents/intent-tag.html

  • CMakeLists.txt:
  • html/HTMLIntentElement.cpp:

(WebCore::HTMLIntentElement::insertedInto):

  • html/HTMLIntentElement.h:

(HTMLIntentElement):

Source/WebKit/efl:

Implement registerIntentService() in EFL's FrameLoaderClient.
Emit a "intent,service,register" signal on the frame when a new Web
Intent service registers.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore):
(WebCore::FrameLoaderClientEfl::registerIntentService):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

  • ewk/ewk_frame.cpp:

(ewk_frame_intent_service_register):

  • ewk/ewk_frame.h:
  • ewk/ewk_frame_private.h:

Tools:

Catch new "intent,service,register" signal on the frame and print out
information about the Web Intent service in EFL's DumpRenderTree.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameIntentServiceRegistration):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip webintents/intent-tag.html now that the WEB_INTENTS_TAG flag is
enabled by default on EFL port.

  • platform/efl/test_expectations.txt:
09:19 Changeset [119242] by commit-queue@webkit.org
  • 7 edits in trunk

[cairo] Pixel artifacts can be seen on reflections
https://bugs.webkit.org/show_bug.cgi?id=85483

Source/WebCore:

Antialiased clipping in the simple rectangular clip method
leads to edge artifacts when transformations are applied to the layer.
Explicitly disabling antialiased clipping for this function solves this issue.
Comparing Cairo GraphicsContext to Qt and Skia GC, it seems that these
backends do not expect the platform context to clip antialiased in this
case either.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-01
Reviewed by Martin Robinson.

No new tests, covered by fast/css/transformed-mask.html.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::clip):

LayoutTests:

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-01
Reviewed by Martin Robinson.

Rebaselining the relevant test case for GTK and EFL.

  • platform/efl/fast/css/transformed-mask-expected.png:
  • platform/efl/fast/css/transformed-mask-expected.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/fast/css/transformed-mask-expected.png:
09:03 Changeset [119241] by fmalita@chromium.org
  • 5 edits
    3 adds in trunk

http://shinydemos.com/clock/ doesn't seem to work
https://bugs.webkit.org/show_bug.cgi?id=79682

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/repaint/text-mask-update.svg

Currently, parent resources are not invalidated when SVGInlineText nodes
are added or removed. Adjusting SVGResourcesCache::clientWasAddedToTree()
and SVGResourcesCache::clientWillBeRemovedFromTree() to cover this case.

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientWasAddedToTree):
(WebCore::SVGResourcesCache::clientWillBeRemovedFromTree):

LayoutTests:

  • platform/chromium-linux/svg/repaint/text-mask-update-expected.png: Added.
  • platform/chromium-linux/svg/repaint/text-mask-update-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • svg/repaint/text-mask-update.svg: Added.
09:03 Changeset [119240] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

The ChangeLog parser cannot handle reviewers with initials in their name
https://bugs.webkit.org/show_bug.cgi?id=87864

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-01
Reviewed by Ryosuke Niwa.

Add support in the ChangeLog parser for reviewer names that have
initials in them.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry): Add a new group of regular expressions that need a backreference
in the replacement string. This allows for matching the word characters before a
period, without totally throwing them away.
(ChangeLogEntry._parse_reviewer_text): Use the new regular expression.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.

09:00 Changeset [119239] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add end editing handling into AutofillManager
https://bugs.webkit.org/show_bug.cgi?id=88071

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-06-01
Reviewed by Rob Buis.

RIM PR: 160857
Implemented EditorClientBlackBerry::textFieldDidEndEditing
to notify AutofillManager to send the dismissing autofill
dialog notification to webpage client.

No new tests since there is no behavior changes.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyDismissAutofillDialog):
(WebKit):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/AutofillManager.cpp:

(WebCore::AutofillManager::textFieldDidEndEditing):
(WebCore):

  • WebCoreSupport/AutofillManager.h:

(AutofillManager):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::textFieldDidEndEditing):

08:56 Changeset [119238] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] ewk_intent_data_get() is not needed and can be removed
https://bugs.webkit.org/show_bug.cgi?id=88072

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-01
Reviewed by Adam Barth.

Remove ewk_intent_data_get() method from Ewk_Intent. Intent data is
serialized and does not need to be publicly exposed. The browser only
needs action and type to match with services.

  • ewk/ewk_intent.cpp:

(_Ewk_Intent):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_free):

  • ewk/ewk_intent.h:
08:49 Changeset [119237] by commit-queue@webkit.org
  • 18 edits in trunk

[EFL] EFL's LayoutTestController needs to implement deliverWebIntent
https://bugs.webkit.org/show_bug.cgi?id=86865

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-01
Reviewed by Adam Barth.

Source/WebKit:

Add "${WEBCORE_DIR}/dom/default" to include directories in
CMakeLists.txt.

  • CMakeLists.txt:

Source/WebKit/efl:

Add method on Ewk_Frame to deliver an intent.
Add helper function to DumpRenderTreeSupportEfl to deliver a Web
Intent.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::deliverWebIntent):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • ewk/ewk_frame.cpp:

(ewk_frame_intent_deliver):

  • ewk/ewk_frame.h:

Tools:

Add deliverWebIntent method to LayoutTestController and provide
implementation for EFL port.

  • DumpRenderTree/LayoutTestController.cpp:

(deliverWebIntentCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::deliverWebIntent):

LayoutTests:

Unskip webintents/web-intents-delivery.html now that Web intent
delivery is implemented on EFL port.

  • platform/efl/test_expectations.txt:
08:47 Changeset [119236] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Bridge Apps - Apps do not redraw correctly after orientation change
https://bugs.webkit.org/show_bug.cgi?id=88033

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 142961
When bridge apps were in carousel mode, the backing store was inactive
as its memory had been released. When we rotated the device, we would
call WebPagPrivate:setViewportSize and resume screen and backing store
to render and blit visible contents. As backing store was inactive and
the window usage was GLES2Usage, we were neither doing backing store
rendering nor direct rendering. Therefore, we drew layers directly
based on the invalid texture contents when blitting contents if
accelerated compositing was enabled.
This patch forces compositing mode to let the accelerated compositing
layer take care of the rendering which can update texture contents
before drawing when backing store is inactive and is openGL compositing.

Reviewed internally by George Staikos and Arvid Nilsson.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):

08:45 Changeset [119235] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't set scroll position twice in HistoryController::restoreScrollPositionAndViewState
https://bugs.webkit.org/show_bug.cgi?id=88068

Patch by John Mellor <johnme@chromium.org> on 2012-06-01
Reviewed by Adam Barth.

In the case where pageScaleFactor changes, we were calling
setScrollPosition with an incorrect scroll position (i.e. a scroll
position scaled by the pageScaleFactor we hadn't yet applied), then
fixing it by setting the pageScaleFactor and scroll position together,
overwriting the old scroll position. It's cleaner to just set the
pageScaleFactor and scroll position together.

No new tests as this isn't expected to change the ultimate behavior, just clean up how it happens.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

08:43 Changeset [119234] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Remove QtViewportInteractionEngine::pageItemSizeChanged.
https://bugs.webkit.org/show_bug.cgi?id=88082

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

The function was causing flickering, and after testing it was verified
that it was no longer needed either.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

08:38 Changeset [119233] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r119228.
http://trac.webkit.org/changeset/119228
https://bugs.webkit.org/show_bug.cgi?id=88098

Caused the EFL debug bot to crash. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01

Source/WebKit/efl:

  • ewk/ewk_main.cpp:

(ewk_init):

LayoutTests:

  • platform/efl/test_expectations.txt:
08:34 Changeset [119232] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Qt] Remove deprecated to/fromAscii()
https://bugs.webkit.org/show_bug.cgi?id=88086

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-01
Reviewed by Simon Hausmann.

Replacing to/fromAscii with to/fromLatin1 since it
is deprecated on Qt5.

Source/WebCore:

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

Source/WebKit/qt:

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore):

  • WebCoreSupport/InspectorServerQt.cpp:

(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView::settings):

08:21 Changeset [119231] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Contents not rendered in MiniBrowser for some pages
https://bugs.webkit.org/show_bug.cgi?id=87922

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

Set drawing area visible contents rect if new visible contents rect is different from
the previous one.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::informVisibleContentChange):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

07:36 Changeset [119230] by ossy@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt: Added.
07:27 Changeset [119229] by apavlov@chromium.org
  • 4 edits in trunk/LayoutTests

Web Inspector: Prepare styles-new-API.html results format for a more complex CSS model
https://bugs.webkit.org/show_bug.cgi?id=88090

Reviewed by Antti Koivisto.

  • inspector/styles/resources/styles-new-API.css:
  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-new-API.html:
07:23 Changeset [119228] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] [DRT] editing/execCommand/paste-and-match-style-event.html crashes
https://bugs.webkit.org/show_bug.cgi?id=86961

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-01
Reviewed by Csaba Osztrogonác.

Source/WebKit/efl:

Call ecore_x_init() in ewk_init() to initialize the ecore_x library.
This avoids crashing upong calling WebCore::systemBeep() which uses
ecore_x_bell() internally.

  • ewk/ewk_main.cpp:

(ewk_init):

LayoutTests:

Unskip editing/execCommand/paste-and-match-style-event.html now that
it is no longer crashing thanks to ecore_x library init.

  • platform/efl/test_expectations.txt:
07:14 Changeset [119227] by mitz@apple.com
  • 4 edits
    2 adds in trunk

Layout not updated after setting -webkit-line-clamp to none
https://bugs.webkit.org/show_bug.cgi?id=88049

Reviewed by Abhishek Arya.

Source/WebCore:

Test: fast/flexbox/line-clamp-removed-dynamically.html

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::styleWillChange): Added. Calls clearLineClamp if
line-clamp will change to none.
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp): Added. Marks possibly-clamped
children for layout and clears truncation from blocks.

  • rendering/RenderDeprecatedFlexibleBox.h:

LayoutTests:

  • fast/flexbox/line-clamp-removed-dynamically-expected.html: Added.
  • fast/flexbox/line-clamp-removed-dynamically.html: Added.
06:53 Changeset [119226] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r119213.
http://trac.webkit.org/changeset/119213
https://bugs.webkit.org/show_bug.cgi?id=88084

This patch broke two tests on all platform except Chromium.
The authors are unavailable. (Requested by zherczeg on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

06:51 Changeset [119225] by kkristof@inf.u-szeged.hu
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r119219.
http://trac.webkit.org/changeset/119219
https://bugs.webkit.org/show_bug.cgi?id=88088

This patch broke two tests on GTK/Qt. The authors are
unavailable. (Requested by kkristof on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):

  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):

  • page/Frame.h:

(Frame):
(WebCore::Frame::detachFromPage):
(WebCore):

  • page/Page.cpp:

(WebCore::Page::~Page):

06:47 Changeset [119224] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Add Closure compiler annotations to WorkerConsole
https://bugs.webkit.org/show_bug.cgi?id=88073

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-01
Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshotWorker.js:

(WebInspector.WorkerConsole.prototype.log):
(WebInspector.WorkerConsole.prototype.error):
(WebInspector.WorkerConsole.prototype.info):

05:57 Changeset [119223] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] New signals in ewk_view to enable global history delegate functionality
https://bugs.webkit.org/show_bug.cgi?id=86343

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

Global history delegate is an interface for WebKit clients to manage their own global history store.
The new ewk_view signals do the following:
1) report that a navigation happened within the view and give the navigation details.
2) report that view performed a client redirect and give source and destination uris.
3) report that view performed a server redirect and give source and destination uris.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::updateGlobalHistoryRedirectLinks): implementation added.
(WebCore::FrameLoaderClientEfl::updateGlobalHistory): implementation added.

  • ewk/ewk_view.h: Added new signals and data types.
05:52 Changeset [119222] by vestbo@webkit.org
  • 2 edits in trunk/Source/WTF

[Qt] Save one copy when going from 8-bit WTF::String to QString

Asking for characters() of an 8-bit string will make a 16-bit copy internally
in WTF::String. Since we're going to copy the data to QStringData anyways, which
is 16-bit, we can do the conversion ourselves and save one copy.

Reviewed by Simon Hausmann.

05:50 Changeset [119221] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing and crashing tests.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt/Skipped:
05:32 Changeset [119220] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Move suspension to QtViewportInteractionEngine
https://bugs.webkit.org/show_bug.cgi?id=88078

Reviewed by Simon Hausmann.

Next step is to take care of visibility changes.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::suspendPageContent):
(WebKit):
(WebKit::QtViewportInteractionEngine::resumePageContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

05:30 Changeset [119219] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

Frame::willDetachPage() shouldn't be called more than once.
https://bugs.webkit.org/show_bug.cgi?id=88056

Reviewed by Ryosuke Niwa.

This change moved willDetachPage() to private and calls it from
detachFromParent(). Also, it checks m_page and call
willDetachPage() only once, if m_page is available.

No new tests. Covered by existing suites.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):

  • page/Frame.cpp:

(WebCore::Frame::detachFromPage):
(WebCore):
(WebCore::Frame::willDetachPage):

  • page/Frame.h:

(Frame):

  • page/Page.cpp:

(WebCore::Page::~Page):

05:26 Changeset [119218] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][W2] Qml Error in ViewportInfoItem.qml in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=87999

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

Return default viewport attributes rather than invalid QVariant.

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::contentsScale):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::initialScale):
(QWebKitTest::minimumScale):
(QWebKitTest::maximumScale):
(QWebKitTest::isScalable):
(QWebKitTest::layoutSize):

05:25 Changeset [119217] by vestbo@webkit.org
  • 4 edits in trunk/Source/WTF

[Qt] Make conversion from QString to WTF::String (and back again) ~free

https://bugs.webkit.org/show_bug.cgi?id=87847

Instead of copying the QString data when converting to a WTF::String we
make the WTF::String adopt the QString data by introducing a new buffer
ownership type, and pointing the internal WTF::StringImpl 16-bit data
member to the string data managed by QStringData.

We make sure to reference the QStringData when adopting, so that the
data will stay alive, and then dereference it when the WTF::StringImpl
is deleted, which will free the QStringData (either straight away, if
we're the only one holding a reference still, or later, when the ref
count goes to 0).

In the case of going back from a WTF::String to a QString we can cheat
a bit (avoid a copy), if we know that the WTF::String was adopted from
a QString, since it's then just a matter of having the QString adopt
the existing QStringData (just like a regular QString copy).

If the WTF::String buffer is not owned by QStringData, eg a regular
8-bit or 16-bit string/substring, we have to fall back to copying,
as before (though there are potential optimization tricks we can
apply here later on).

Reviewed by Gavin Barraclough.

  • wtf/qt/StringQt.cpp:
  • wtf/text/StringImpl.cpp:
  • wtf/text/StringImpl.h:
05:21 Changeset [119216] by pierre.rossi@gmail.com
  • 4 edits in trunk

[Qt] Support drawing a pattern with a translation.
https://bugs.webkit.org/show_bug.cgi?id=87025

Source/WebCore:

Drawing an SVG pattern that has its x or y attribute set
works by setting a transform on the Pattern.
We would ignore this by only taking into account the texture and
target rect.

Reviewed by Kenneth Rohde Christiansen.

test: svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::drawRepeatPattern): refactored to take into account the translation set on the brush.
(WebCore::GraphicsContext::fillRect):

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: fix the expected pixel result
04:56 Changeset [119215] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening failure case on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=88067

Unreviewed EFL gardening after r119196.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01

  • platform/efl/test_expectations.txt:
04:55 Changeset [119214] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
04:53 Changeset [119213] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r109729) [Form] Rendering of select/optgroup/option combination is too slow.
https://bugs.webkit.org/show_bug.cgi?id=88059

Reviewed by Kent Tamura.

This patch changes to share RenderStyle object among the "option"
elements to improve rendering performance and reducing memory usage
of RenderStyle.

No new tests. This patch doesn't change behavior but rendering performance.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement): Check attribute value
mismatching for "option" element.

04:26 Changeset [119212] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Bad layout of "Override device metrics" controls in the Settings dialog
https://bugs.webkit.org/show_bug.cgi?id=88074

Reviewed by Yury Semikhatsky.

The "Override device metrics" controls are placed in a table, which gets too narrow. Give it a
"white-space: nowrap" to avoid wrapping individual cells.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):

  • inspector/front-end/elementsPanel.css:
  • inspector/front-end/inspector.css:

(.nowrap):

04:18 Changeset [119211] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing

Reviewed by Simon Hausmann.

04:12 Changeset [119210] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Clean up our viewport handling mess
https://bugs.webkit.org/show_bug.cgi?id=87977

Reviewed by Simon Hausmann.

Consolidated functionality from QQuickWebViewPrivate* into
ViewportInteractionEngine that belongs there, in preparation for
renaming ViewportInteractionEngine in the future.

Remove unneeded methods and move others to private.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::viewportAttributesChanged):
(WebKit::QtViewportInteractionEngine::pageContentsSizeChanged):
(WebKit::QtViewportInteractionEngine::pageItemPositionChanged):
(WebKit::QtViewportInteractionEngine::pageContentPositionRequested):
(WebKit::QtViewportInteractionEngine::visibleContentsRect):
(WebKit):
(WebKit::QtViewportInteractionEngine::informVisibleContentChange):
(WebKit::QtViewportInteractionEngine::viewportItemSizeChanged):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(WebKit):
(QtViewportInteractionEngine):

03:50 Changeset [119209] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Move input element's spinner style tests to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=88054

Unreviewed EFL gardening.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-06-01

  • platform/efl/test_expectations.txt:
03:45 Changeset [119208] by commit-queue@webkit.org
  • 8 edits
    2 adds
    1 delete in trunk/Source

[EFL] Implement PlatformStrategies
https://bugs.webkit.org/show_bug.cgi?id=86946

Source/WebCore:

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.

  • PlatformEfl.cmake: Add PlatformStrategies.cpp file to the build system.

Also, remove PluginDataEfl.cpp because the same functionality is now
implemented in PlatformStrategiesEfl.cpp.

Source/WebKit:

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.

  • PlatformEfl.cmake: Add PlatformStrategiesEfl file to the build

system.

Source/WebKit/efl:

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.

Enable PLATFORM_STRATEGIES for EFL platform.

  • WebCoreSupport/PlatformStrategiesEfl.cpp: Added, code was moved

from platform/PluginDataEfl.
(PlatformStrategiesEfl::initialize): Initialize platform strategies.
(PlatformStrategiesEfl::PlatformStrategiesEfl):
(PlatformStrategiesEfl::createCookiesStrategy): Return this.
(PlatformStrategiesEfl::createPluginStrategy): Ditto.
(PlatformStrategiesEfl::createVisitedLinkStrategy): Ditto.
(PlatformStrategiesEfl::createPasteboardStrategy): Return 0, since
PasteboardStrategy is only used by mac code for now.
(PlatformStrategiesEfl::notifyCookiesChanged):
(PlatformStrategiesEfl::refreshPlugins): Refresh the plugin
database. Code executes only when NETSCAPE_PLUGIN_API is ON.
(PlatformStrategiesEfl::getPluginInfo): Initialize plugins and
populate the given vector with plugins information. Code executes
only when NETSCAPE_PLUGIN_API is ON.
(PlatformStrategiesEfl::isLinkVisited): Return whether the given
hash is a visited link of the page group.
(PlatformStrategiesEfl::addVisitedLink): Add the given hash to the
page group visited links.

  • WebCoreSupport/PlatformStrategiesEfl.h: Added.

(PlatformStrategiesEfl):

  • ewk/ewk_main.cpp: Initialize PlatformStrategiesEfl.

(_ewk_init_body):

Source/WTF:

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.

  • wtf/Platform.h: Enable PLATFORM_STRATEGIES for EFL platform.
03:39 Changeset [119207] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

ASSERT(m_fontSelector->document()) is bogus and should be removed
https://bugs.webkit.org/show_bug.cgi?id=88053

Reviewed by Abhishek Arya.

This ASSERT was introduced in http://trac.webkit.org/changeset/97402
together with a branch that handled the case of the ASSERT firing.
This ASSERT fires when running tests on Android (which runs with
ASSERTs enabled). The ASSERT appears to be bogus, so this patch removes
it.

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

03:37 Changeset [119206] by ossy@webkit.org
  • 15 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected files.

  • platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/qt-5.0/fast/forms/form-element-geometry-expected.png:
  • platform/qt-5.0/fast/forms/form-element-geometry-expected.txt:
  • platform/qt-5.0/fast/forms/menulist-separator-painting-expected.png:
  • platform/qt-5.0/fast/forms/menulist-separator-painting-expected.txt:
  • platform/qt-5.0/fast/forms/select-baseline-expected.png:
  • platform/qt-5.0/fast/forms/select-baseline-expected.txt:
  • platform/qt-5.0/fast/forms/selectlist-minsize-expected.png:
  • platform/qt-5.0/fast/forms/selectlist-minsize-expected.txt:
  • platform/qt-5.0/fast/replaced/three-selects-break-expected.png:
  • platform/qt-5.0/fast/replaced/three-selects-break-expected.txt:
02:40 Changeset [119205] by yosin@chromium.org
  • 4 edits in trunk/Source

[Platform][Decimal] UInt128::operator/= calls makeUInt128 with wrong argument order
https://bugs.webkit.org/show_bug.cgi?id=88044

Reviewed by Kent Tamura.

Source/WebCore:

This patch fixed wrong argument of makeUInt128 in UInt128::operator/= to get right
result for decimal multiplication.

Test: WebKit/chromium/tests/DecimalTest.cpp: Add new a new test case.

  • platform/Decimal.cpp:

(WebCore::DecimalPrivate::UInt128::operator/=):

Source/WebKit/chromium:

  • tests/DecimalTest.cpp:

(TEST_F): Add a new test for multiplication.

02:26 Changeset [119204] by abarth@webkit.org
  • 7 edits
    9 adds in trunk

sandbox directive in X-WebKit-CSP header unable to create a unique origin
https://bugs.webkit.org/show_bug.cgi?id=88014

Reviewed by Ryosuke Niwa.

Source/WebCore:

We process the HTTP headers for a response after we create a document
object for the response. Previously, the SecurityOrigin of a document
was determined when the document was created, which meant that the
sandbox directive in CSP couldn't create a unique origin.

In this patch, we transition to a unique origin when we start enforcing
the SandboxOrigin bit. This patch is more complicated than you might
expect because we redundantly store the SecurityOrigin object in
DOMWindow. Removing that redundant state is
https://bugs.webkit.org/show_bug.cgi?id=75793.

The CSP sandbox directive is defined in
http://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-1.0-specification.html
by reference to
http://www.whatwg.org/specs/web-apps/current-work/#forced-sandboxing-flag-set.
The relation between sandbox and unique origin arises from
http://www.whatwg.org/specs/web-apps/current-work/#origin-0.

Test: http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control.html

http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header.html
http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control.html
http/tests/security/contentSecurityPolicy/sandbox-in-http-header.html

  • dom/Document.cpp:

(WebCore::Document::didUpdateSecurityOrigin):
(WebCore::Document::initContentSecurityPolicy):

  • dom/Document.h:

(Document):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::enforceSandboxFlags):
(WebCore):
(WebCore::SecurityContext::didUpdateSecurityOrigin):

  • dom/SecurityContext.h:

(SecurityContext):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/sandbox.php: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control-expected.txt: Added.
02:03 Changeset [119203] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: expose MemoryCache statistics in the inspector protocol
https://bugs.webkit.org/show_bug.cgi?id=87984

Reviewed by Pavel Feldman.

Added MemoryCache statistics to Memory.getProcessMemoryDistribution command
result. Corresponding sector is added to the memory pie-chart.

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::addMemoryBlockFor):
(WebCore::memoryCacheInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

01:54 Changeset [119202] by zandobersek@gmail.com
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening, add missing text and image baselines for
fast/images/png-suite/test.html. Add MISSING expectations for two
placeholder-in-text-area tests - the placeholder text does not appear
in text areas (known bug).

  • platform/gtk/fast/images/png-suite: Added.
  • platform/gtk/fast/images/png-suite/test-expected.png: Added.
  • platform/gtk/fast/images/png-suite/test-expected.txt: Added.
  • platform/gtk/test_expectations.txt:
01:34 Changeset [119201] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add RenderArena sizes to the memory pie-chart
https://bugs.webkit.org/show_bug.cgi?id=87971

Reviewed by Pavel Feldman.

Added allocated and used sizes of page render arenas to the memory
report returned by the InspectorMemoryAgent. Total allocated size of
the inspected page's render arenas will be displayed on the memory
pie-chart.

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::renderTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

01:32 Changeset [119200] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening after r119196.

  • platform/gtk/fast/dom/gc-attribute-node-expected.txt: Added.
  • platform/gtk/test_expectations.txt: Also mark fast/replaced/border-radius-clip.html as flaky.
01:29 Changeset [119199] by tkent@chromium.org
  • 3 edits
    2 copies in branches/chromium/1132

Merge 118721 - Form controls in <fieldset disabled> should not be validated.
https://bugs.webkit.org/show_bug.cgi?id=87381

Reviewed by Hajime Morita.

Source/WebCore:

We need to use disabeld() instead of m_disabled to calculate
willValidate property. Also, we need to update willValidate if
necessary.

Test: fast/forms/fieldset/validation-in-fieldset.html

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::disabledAttributeChanged):

  • Do not traverse this.
  • Calls ancestorDisabledStateWasChanged() instead of setNeedsStyleRecalc() because we'd like to do additional tasks.
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::ancestorDisabledStateWasChanged):
Added. Just calls disabledAttributeChanged().
(WebCore::HTMLFormControlElement::parseAttribute):
Do not call setNeedsWillValidateCheck() whenever an attribute is updated.
It should be called only if disabled or readonly attribute is updated.
(WebCore::HTMLFormControlElement::disabledAttributeChanged):
Add setNeedsWillValidateCheck(). It was moved from parseAttribute().
(WebCore::HTMLFormControlElement::insertedInto):
Invalidate ancestor information.
(WebCore::HTMLFormControlElement::recalcWillValidate):
Use disabled() instead of m_disabled. disabled() takes care of
ancestor's disabled state.

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

LayoutTests:

  • fast/forms/fieldset/validation-in-fieldset-expected.txt: Added.
  • fast/forms/fieldset/validation-in-fieldset.html: Added.

TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10451107

01:23 Changeset [119198] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: change type of injected script id from long to int
https://bugs.webkit.org/show_bug.cgi?id=87837

Reviewed by Pavel Feldman.

Changed injected script id type from long to int so that we don't
lose precision when sending the id over the protocol.

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptIdFor):
(WebCore::InjectedScriptManager::injectScript):

  • inspector/InjectedScriptManager.h:

(InjectedScriptManager):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::notifyContextCreated):

01:17 Changeset [119197] by yurys@chromium.org
  • 6 edits
    1 add in trunk/Source/WebCore

Web Inspector: draw pie-chart based on memory data received from backend
https://bugs.webkit.org/show_bug.cgi?id=87737

Reviewed by Pavel Feldman.

Added pie chart for memory data received from inspector memory agent.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemorySnapshotView):
(WebInspector.NativeMemoryProfileType):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.NativeMemoryProfileHeader):
(WebInspector.MemoryBlockViewProperties):
(WebInspector.MemoryBlockViewProperties._initialize):
(WebInspector.MemoryBlockViewProperties._forMemoryBlock):
(WebInspector.NativeMemoryPieChart):
(WebInspector.NativeMemoryPieChart.prototype.onResize):
(WebInspector.NativeMemoryPieChart.prototype._updateSize):
(WebInspector.NativeMemoryPieChart.prototype._addBlockLabels):
(WebInspector.NativeMemoryPieChart.prototype._paint.paintPercentAndLabel):
(WebInspector.NativeMemoryPieChart.prototype._paint):
(WebInspector.NativeMemoryPieChart.prototype._clear):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/nativeMemoryProfiler.css: Added.

(.memory-pie-chart-container):
(.memory-pie-chart):
(.memory-blocks-list .swatch):
(.memory-blocks-list):
(.memory-blocks-list .item):

05/31/12:

23:37 Changeset [119196] by dominicc@chromium.org
  • 3 edits
    4 adds in trunk

[V8] Expando properties on attribute nodes disappear
https://bugs.webkit.org/show_bug.cgi?id=87925

Source/WebCore:

Reviewed by Adam Barth.

Test: fast/dom/gc-attribute-node.html

  • bindings/v8/V8GCController.cpp:

(WebCore::calculateGroupId): Group attributes like other nodes.

LayoutTests:

Checks in a failing result for JSC; see
<https://bugs.webkit.org/show_bug.cgi?id=88045>.

Reviewed by Adam Barth.

  • fast/dom/gc-attribute-node-expected.txt: Added.
  • fast/dom/gc-attribute-node.html: Added.
  • platform/chromium/fast/dom/gc-attribute-node-expected.txt: Added.
  • platform/mac/fast/dom/gc-attribute-node-expected.txt: Added.
23:33 Changeset [119195] by commit-queue@webkit.org
  • 7 edits
    9 adds in trunk

[EFL] <input type="number"> is not a spinbutton
https://bugs.webkit.org/show_bug.cgi?id=86846

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-31
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Implemented adjustInnerSpinButtonStyle and
paintInnerSpinButton in RenderThemeEfl.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::applyEdjeStateFromForm):
(WebCore::RenderThemeEfl::edjeGroupFromFormType):
(WebCore::RenderThemeEfl::adjustInnerSpinButtonStyle):
(WebCore):
(WebCore::RenderThemeEfl::paintInnerSpinButton):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

Source/WebKit/efl:

Implemented spinner widget.

  • DefaultTheme/default.edc:
  • DefaultTheme/widget/spinner/sp_bg.png: Added.
  • DefaultTheme/widget/spinner/sp_down_default.png: Added.
  • DefaultTheme/widget/spinner/sp_down_hover.png: Added.
  • DefaultTheme/widget/spinner/sp_down_pressed.png: Added.
  • DefaultTheme/widget/spinner/sp_up_default.png: Added.
  • DefaultTheme/widget/spinner/sp_up_hover.png: Added.
  • DefaultTheme/widget/spinner/sp_up_pressed.png: Added.
  • DefaultTheme/widget/spinner/spinner.edc: Added.

LayoutTests:

Unskip spinbutton layout tests.

  • platform/efl/test_expectations.txt:
22:05 Changeset [119194] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Update Chromium test expectation of media/video-poster-blocked-by-willsendrequest.html to PASS TEXT
on all platforms as supposed to just Mac and Linux since the result of jquery/traversing.html is
bleeding into this test on Windows as well.

  • platform/chromium/test_expectations.txt:
21:24 Changeset [119193] by tony@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed. Fix expectations for for fast/multicol/span/clone-flexbox.html,
the result I checked in was off by 1px.

  • fast/multicol/span/clone-flexbox-expected.txt:
  • platform/efl/fast/multicol/span/clone-flexbox-expected.txt:
  • platform/gtk/fast/multicol/span/clone-flexbox-expected.txt:
  • platform/qt/fast/multicol/span/clone-flexbox-expected.txt:
21:00 Changeset [119192] by commit-queue@webkit.org
  • 35 edits in trunk

REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac
https://bugs.webkit.org/show_bug.cgi?id=86859

Source/WebCore:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

The test tries to reach an invalid SpellChecker object. Such an access should be guarded
beforehand.

Asynchronous spellchecking can return results after originated
frame is gone, which triggered an invalid access to the dead spellchecker
object. This chagne prevents it by marking request objects from
the spellchecker as invalid:

  • Originally TextCheckerClient API was passed a SpellCheker object. This change abstracted it behind TextCheckingRequest interface, didSucceed() and didCancel() method specifically.
  • TextCheckingRequest was turned from a plain old object into a refcounted abstract class, which is now subclassed by SpellCheckRequest.
  • SpellChecker now marks pending SpellCheckRequest objects as invalid on its destructor.

Test: editing/spelling/spellcheck-async-remove-frame.html

  • WebCore.exp.in:
  • editing/SpellChecker.cpp:

(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
(WebCore::SpellCheckRequest::didSucceed):
(WebCore):
(WebCore::SpellCheckRequest::didCancel):
(WebCore::SpellCheckRequest::wasRequestedBy):
(WebCore::SpellCheckRequest::requesterDestroyed):
(WebCore::SpellChecker::~SpellChecker):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::didCheckSucceed):
(WebCore::SpellChecker::didCheckCancel):

  • editing/SpellChecker.h:

(WebCore):
(SpellCheckRequest):
(WebCore::SpellCheckRequest::isStarted):
(SpellChecker):

  • loader/EmptyClients.h:

(WebCore::EmptyTextCheckerClient::requestCheckingOfString):

  • platform/text/TextCheckerClient.h:

(TextCheckerClient):

  • platform/text/TextChecking.h:

(GrammarDetail):
(TextCheckingResult):
(TextCheckingRequest):
(WebCore::TextCheckingRequest::~TextCheckingRequest):

Source/WebKit/blackberry:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::requestCheckingOfString):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

Removed a port specific fix which was introduced at r117572.

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::frameWillDetachPage):
(WebKit::EditorClientImpl::requestCheckingOfString):

  • src/EditorClientImpl.h:

(WebCore):
(EditorClientImpl):

  • src/WebTextCheckingCompletionImpl.cpp:

(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):

  • src/WebTextCheckingCompletionImpl.h:

(WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
(WebTextCheckingCompletionImpl):

Source/WebKit/efl:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::requestCheckingOfString):

Source/WebKit/gtk:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/TextCheckerClientGtk.h:

(WebKit::TextCheckerClientGtk::requestCheckingOfString):

Source/WebKit/mac:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(-[WebEditorSpellCheckResponder initWithClient:sequence:results:]):
(-[WebEditorSpellCheckResponder perform]):
(WebEditorClient::didCheckSucceeded):
(WebEditorClient::requestCheckingOfString):

Source/WebKit/qt:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/TextCheckerClientQt.h:

(WebCore::TextCheckerClientQt::requestCheckingOfString):

Source/WebKit/win:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient::requestCheckingOfString):

Source/WebKit/wince:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::requestCheckingOfString):

Source/WebKit/wx:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::requestCheckingOfString):

Source/WebKit2:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::requestCheckingOfString):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

LayoutTests:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • platform/mac/Skipped: Unskipped the test.
20:35 WikiStart edited by tkent@chromium.org
Add a link to ChromiumWebKitAPI (diff)
20:32 Changeset [119191] by tony@chromium.org
  • 57 edits in trunk

initial flex value should be 1 1 auto
https://bugs.webkit.org/show_bug.cgi?id=86526

Source/WebCore:

Reviewed by Ojan Vafai.

Also, if -webkit-flex is used to set the positive flex to 0 and
the negative flex is omitted, the negative flex is set to 0.

New test cases in: flex-property-parsing.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyFlex::applyValue):

  • rendering/style/RenderStyle.h:

LayoutTests:

In most tests, I added a CSS rule to default -webkit-flex: none.
In a few tests, -webkit-flex didn't include the negative flex value
and it was becoming 1, causing negative flexing. I fixed those by
explicitly stating the negative flex as 0.

Reviewed by Ojan Vafai.

  • css3/flexbox/align-absolute-child.html:
  • css3/flexbox/auto-margins.html:
  • css3/flexbox/flex-algorithm-with-margins.html:
  • css3/flexbox/flex-algorithm.html:
  • css3/flexbox/flex-align-end.html:
  • css3/flexbox/flex-flow-auto-margins.html:
  • css3/flexbox/flex-flow-orientations.html:
  • css3/flexbox/flex-flow-overflow.html:
  • css3/flexbox/flex-pack.html:
  • css3/flexbox/flex-property-parsing-expected.txt:
  • css3/flexbox/flex-property-parsing.html:
  • css3/flexbox/flexbox-overflow-auto-expected.html:
  • css3/flexbox/flexbox-overflow-auto.html:
  • css3/flexbox/multiline-column-auto.html:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-shrink-to-fit.html:
  • css3/flexbox/multiline.html:
  • css3/flexbox/nested-stretch.html:
  • css3/flexbox/orthogonal-flex-directions.html:
  • css3/flexbox/position-absolute-child.html:
  • css3/flexbox/preferred-widths-orthogonal.html:
  • css3/flexbox/true-centering.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
20:29 Changeset [119190] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Win] 4 fast/frames tests failing
https://bugs.webkit.org/show_bug.cgi?id=88034

Add Windows-specific expected (failing?) results to get the bots green.

  • platform/win/fast/frames/frame-set-scaling-hit-expected.txt: Added.
  • platform/win/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Added.
  • platform/win/fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Added.
  • platform/win/fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Added.
20:21 Changeset [119189] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

[WebKit2] Remove nested #if conditions from messages.in files
https://bugs.webkit.org/show_bug.cgi?id=88039

Reviewed by Filip Pizlo.

The code generator that processes messages.in files can't handle nested
#if conditions. Sadly I added said conditions in r117700 but failed to
verify the generated result. Un-nest the conditions I added.

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.messages.in:
20:19 Changeset [119188] by rniwa@webkit.org
  • 8 edits
    3 adds in trunk

Add public page loading performance tests using web-page-replay
https://bugs.webkit.org/show_bug.cgi?id=84008

Reviewed by Dirk Pranke.

PerformanceTests:

Add replay tests for google.com and youtube.com as examples.

  • Replay: Added.
  • Replay/www.google.com.replay: Added.
  • Replay/www.youtube.com.replay: Added.

Tools:

Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.

Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.is_external_http_test): Added.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest.init): Takes port.
(PerfTest.prepare): Added. Overridden by ReplayPerfTest.
(PerfTest):
(PerfTest.run): Calls run_single.
(PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
(ChromiumStylePerfTest.init):
(PageLoadingPerfTest.init):
(PageLoadingPerfTest.run):
(ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
(ReplayServer.init):
(ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
but it caused a dead lock on some web pages.
(ReplayServer.stop):
(ReplayServer.del):
(ReplayPerfTest):
(ReplayPerfTest.init):
(ReplayPerfTest._start_replay_server):
(ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
The subsequent runs of the same test will just use test.wpr.
(ReplayPerfTest.run_single):
(PerfTestFactory):
(PerfTestFactory.create_perf_test):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):
(TestReplayPerfTest):
(TestReplayPerfTest.ReplayTestPort):
(TestReplayPerfTest.ReplayTestPort.init):
(TestReplayPerfTest.ReplayTestPort.init.ReplayTestDriver):
(TestReplayPerfTest.ReplayTestPort.init.ReplayTestDriver.run_test):
(TestReplayPerfTest.ReplayTestPort._driver_class):
(TestReplayPerfTest.MockReplayServer):
(TestReplayPerfTest.MockReplayServer.init):
(TestReplayPerfTest.MockReplayServer.stop):
(TestReplayPerfTest._add_file):
(TestReplayPerfTest._setup_test):
(TestReplayPerfTest.test_run_single):
(TestReplayPerfTest.test_run_single.run_test):
(TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
(TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
(TestReplayPerfTest.test_prepare):
(TestReplayPerfTest.test_prepare.run_test):
(TestReplayPerfTest.test_prepare_calls_run_single):
(TestReplayPerfTest.test_prepare_calls_run_single.run_single):
(TestPerfTestFactory.test_regular_test):
(TestPerfTestFactory.test_inspector_test):
(TestPerfTestFactory.test_page_loading_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner):
(PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
(PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
(PerfTestsRunner._collect_tests._is_test_file):
(PerfTestsRunner.run): Exit early if one of calls to prepare() fails.

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(create_runner):
(run_test):
(_tests_for_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(test_run_with_upload_json):
(test_upload_json):
(test_upload_json.MockFileUploader.upload_single_text_file):
(_add_file):
(test_collect_tests):
(test_collect_tests_with_multile_files):
(test_collect_tests_with_multile_files.add_file):
(test_collect_tests_with_skipped_list):
(test_collect_tests_with_page_load_svg):
(test_collect_tests_should_ignore_replay_tests_by_default):
(test_collect_tests_with_replay_tests):
(test_parse_args):

  • Scripts/webkitpy/thirdparty/init.py: Added the dependency for web-page-replay version 1.1.1.

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_webpagereplay):

19:16 Changeset [119187] by commit-queue@webkit.org
  • 22 edits in trunk/Source

Unreviewed, rolling out r119146.
http://trac.webkit.org/changeset/119146
https://bugs.webkit.org/show_bug.cgi?id=88035

android breakage fixed in http://crrev.com/139945 (Requested
by fischman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-31

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::didLoadingProgress):
(WebCore::MediaPlayer::didLoadingProgress):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::didLoadingProgress):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(MediaPlayerPrivateAVFoundation):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::didLoadingProgress):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:

(MediaPlayerPrivateQTKit):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::didLoadingProgress):

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::didLoadingProgress):

  • platform/graphics/qt/MediaPlayerPrivateQt.h:

(MediaPlayerPrivateQt):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::didLoadingProgress):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

(MediaPlayerPrivateQuickTimeVisualContext):

  • platform/graphics/wince/MediaPlayerPrivateWinCE.h:

(MediaPlayerPrivate):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::didLoadingProgress):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

19:01 Changeset [119186] by yosin@chromium.org
  • 5 edits
    5 copies in branches/chromium/1132

Merge 118772 - REGRESSION(r109729): The optgroup element's "disabled" attribute has no effect to rendering and selection
https://bugs.webkit.org/show_bug.cgi?id=87614

Reviewed by Kent Tamura.

Source/WebCore:

This patch adds HTMLOptGroupElement::disabled and isEnabledFormControl
methods which was implemented in HTMLFormControlElement at r109729 and
updates CSS pseudo class checker to check "optgroup" element.

Tests: fast/forms/select/optgroup-clicking.html

fast/forms/select/optgroup-disabled.html
fast/forms/select/optgroup-rendering.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): On disabled and enabled pseudo class checker.
We checked tag name "optgroup" in addition isFormControlElement.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement): Checks optgroup.disabled.

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::disabled): Added.

  • html/HTMLOptGroupElement.h:

(HTMLOptGroupElement): Added isEnabledFormControl.

LayoutTests:

Note: An image for optgroup-rendering.html will be change due by
BUG-87719. Color of option elements should be blue (:enabled
pseudo class) instead of green.

  • fast/forms/select/optgroup-clicking-expected.txt: Added.
  • fast/forms/select/optgroup-clicking.html: Added.
  • fast/forms/select/optgroup-disabled-expected.txt: Added.
  • fast/forms/select/optgroup-disabled.html: Added.
  • fast/forms/select/optgroup-rendering.html: Added.
  • platform/chromium/test_expectations.txt: Add MISSING entry for optgroup-rendering.html.
  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.txt: Added.

TBR=yosin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10453112

18:37 Changeset [119185] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] WebGL and 2D canvas output not available to WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=88012

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-31
Reviewed by George Staikos.

Properly set up resource sharing between WebKit thread EGL contexts and
the compositing thread EGL context, so the texture ID produced by WebGL
and 2D canvas makes sense to the compositing context.

There's no public API to supply an EGLContext yet, so we're lucky that
the embedder never makes its context un-current. Just grab the current
context on the compositing thread and use that as the compositing
context.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setCompositor):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):

  • Api/WebPage_p.h:

(WebPagePrivate):

18:31 Changeset [119184] by tsepez@chromium.org
  • 3 edits
    2 adds in trunk

XSSAuditor bypass with leading /*/*/ comment
https://bugs.webkit.org/show_bug.cgi?id=88002

Reviewed by Adam Barth.

Source/WebCore:

Fixes issue in xssauditor's parsing of /*/.

Test: http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::decodedSnippetForJavaScript):

LayoutTests:

Fixes issue in xssauditor's parsing of /*/.

  • http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html: Added.
18:13 Changeset [119183] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Support building the Android port of chromium with Ninja
https://bugs.webkit.org/show_bug.cgi?id=87545

Patch by Yaron Friedman <yfriedman@chromium.org> on 2012-05-31
Reviewed by Adam Barth.

Ensures that shared libraries are looked up in a generator-agnostic
way and that output is placed in the correct directory.

Depends on http://codereview.chromium.org/10386188/

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
17:59 Changeset [119182] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Bug: Negative SVG rect rx,ry corner radii values aren't handled correctly
https://bugs.webkit.org/show_bug.cgi?id=87859

Patch by Hans Muller <hmuller@adobe.com> on 2012-05-31
Reviewed by Dirk Schulze.

Source/WebCore:

Added the rect element corner radius constraints specified in steps 2-4 of
http://www.w3.org/TR/SVG/shapes.html#RectElement to Path::addRoundedRect().
Support for steps 6 and 7 was already included. Steps 2-4:

2 - If neither rx nor ry are properly specified, then set both rx and ry to 0. (This will result in square corners.)
3 - Otherwise, if a properly specified value is provided for rx, but not for ry then set both rx and ry to the value of rx.
4 - Otherwise, if a properly specified value is provided for ry, but not for rx, then set both rx and ry to the value of ry.

Tests: svg/custom/rect-negative-corner-radii-expected.svg

svg/custom/rect-negative-corner-radii.svg

  • platform/graphics/Path.cpp:

(WebCore::Path::addRoundedRect):

LayoutTests:

Added a reftest which verifies that negative rect corner radius values are handled per the SVG spec,
http://www.w3.org/TR/SVG/shapes.html#RectElement.

  • svg/custom/rect-negative-corner-radii-expected.svg: Added.
  • svg/custom/rect-negative-corner-radii.svg: Added.
17:56 Changeset [119181] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening. Skip fast/loader/opaque-base-url.html only on debug bots.

The test hits an assertion which obviously only crashes the debug
bots.

  • platform/efl/test_expectations.txt:
17:55 Changeset [119180] by rakuco@webkit.org
  • 68 edits
    32 adds in trunk/LayoutTests

[EFL] Unskip fast/multicol tests.

Most tests were passing and just needed new baselines. Only skip
the few failing ones.

  • platform/efl/Skipped:
  • platform/efl/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
  • platform/efl/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
  • platform/efl/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/efl/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
  • platform/efl/fast/multicol/block-axis-vertical-lr-expected.png: Added.
  • platform/efl/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
  • platform/efl/fast/multicol/block-axis-vertical-rl-expected.png: Added.
  • platform/efl/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
  • platform/efl/fast/multicol/client-rects-expected.png: Added.
  • platform/efl/fast/multicol/client-rects-expected.txt: Added.
  • platform/efl/fast/multicol/column-count-with-rules-expected.png:
  • platform/efl/fast/multicol/column-rules-expected.png:
  • platform/efl/fast/multicol/column-rules-stacking-expected.png:
  • platform/efl/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/efl/fast/multicol/float-avoidance-expected.png:
  • platform/efl/fast/multicol/float-multicol-expected.png:
  • platform/efl/fast/multicol/float-paginate-complex-expected.png:
  • platform/efl/fast/multicol/float-paginate-complex-expected.txt:
  • platform/efl/fast/multicol/float-paginate-empty-lines-expected.png:
  • platform/efl/fast/multicol/float-paginate-expected.png:
  • platform/efl/fast/multicol/layers-in-multicol-expected.png:
  • platform/efl/fast/multicol/layers-split-across-columns-expected.png:
  • platform/efl/fast/multicol/margin-collapse-expected.png:
  • platform/efl/fast/multicol/max-height-columns-block-expected.png:
  • platform/efl/fast/multicol/nested-columns-expected.png:
  • platform/efl/fast/multicol/nested-columns-expected.txt:
  • platform/efl/fast/multicol/overflow-across-columns-expected.png:
  • platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.png:
  • platform/efl/fast/multicol/overflow-unsplittable-expected.png:
  • platform/efl/fast/multicol/paginate-block-replaced-expected.png:
  • platform/efl/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
  • platform/efl/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
  • platform/efl/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
  • platform/efl/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
  • platform/efl/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
  • platform/efl/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
  • platform/efl/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
  • platform/efl/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
  • platform/efl/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
  • platform/efl/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.
  • platform/efl/fast/multicol/positioned-split-expected.png:
  • platform/efl/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/efl/fast/multicol/positive-leading-expected.png:
  • platform/efl/fast/multicol/scrolling-overflow-expected.png:
  • platform/efl/fast/multicol/single-line-expected.png: Added.
  • platform/efl/fast/multicol/single-line-expected.txt: Added.
  • platform/efl/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/efl/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/efl/fast/multicol/span/clone-flexbox-expected.txt: Added.
  • platform/efl/fast/multicol/span/clone-summary-expected.txt: Added.
  • platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/efl/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/efl/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/efl/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
  • platform/efl/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/efl/fast/multicol/table-margin-collapse-expected.png:
  • platform/efl/fast/multicol/table-vertical-align-expected.png:
  • platform/efl/fast/multicol/table-vertical-align-expected.txt:
  • platform/efl/fast/multicol/unsplittable-inline-block-expected.png:
  • platform/efl/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/efl/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
  • platform/efl/fast/multicol/vertical-lr/column-rules-expected.png:
  • platform/efl/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/efl/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/efl/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/efl/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
  • platform/efl/fast/multicol/vertical-lr/float-paginate-expected.png:
  • platform/efl/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt:
  • platform/efl/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
  • platform/efl/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/efl/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
  • platform/efl/fast/multicol/vertical-rl/column-rules-expected.png:
  • platform/efl/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/efl/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/efl/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/efl/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
  • platform/efl/fast/multicol/vertical-rl/float-paginate-expected.png:
  • platform/efl/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/efl/fast/multicol/vertical-rl/rule-style-expected.txt: Added.
  • platform/efl/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
  • platform/efl/test_expectations:
17:29 Changeset [119179] by danakj@chromium.org
  • 16 edits in branches/chromium/1132/Source

Merge 118383 - [chromium] Only display frames created with memory allocations meant to be displayed
https://bugs.webkit.org/show_bug.cgi?id=85108

Reviewed by Adrienne Walker.

Source/WebCore:

In this patch we remove the setVisible() code paths from CCProxy, and
instead commit visiblity state along with a frame. We also commit a
flag with a frame that indicates if the frame is one that can be drawn.

The impl host is set to visible during commit instead of using a
special channel through the proxy, and the scheduler allows
commits when we are waiting to draw our first frame but blocked on
being non-visible.

canDraw is gated on a new flag that indicates if the frame is one meant
for display. A frame is meant for display if the frame was generated
with a memory allocation meant for display. At this time, any non-zero
memory allocation is considered meant for display.

We prevent races by not changing the memory allocation at any time
except during a commit. So we force a commit when the memory
allocation needs to be adjusted and we are not visible. Similarly,
we force a commit when visibility changes so that we are able to
commit the visibility change to the impl tree.

In order to prevent drawing frames that are not meant for display
with a single thread, we prevent compositing when the impl tree
is not visible, with an early out in CCSingleThreadProxy.

Unit tests: CCLayerTreeHostTestVisibilityAndAllocationControlDrawing

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/TiledLayerChromium.cpp:
  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore):
(WebCore::CCLayerTreeHost::setNeedsForcedCommit):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::setContentsMemoryAllocationLimitBytes):
(WebCore::CCLayerTreeHost::scheduleComposite):
(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::canDraw):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::sourceFrameCanBeDrawn):
(WebCore::CCLayerTreeHostImpl::setSourceFrameCanBeDrawn):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCProxy.h:

(CCProxy):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::drawSuspendedUntilCommit):
(WebCore::CCSchedulerStateMachine::scheduledToDraw):
(WebCore::CCSchedulerStateMachine::updateState):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore):
(WebCore::CCSingleThreadProxy::setNeedsForcedCommit):
(WebCore::CCSingleThreadProxy::doComposite):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::setNeedsForcedCommit):
(WebCore):
(WebCore::CCThreadProxy::setNeedsForcedCommitOnImplThread):
(WebCore::CCThreadProxy::forceBeginFrameOnImplThread):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::scheduledActionCommit):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

Removing code to protect visible textures when a tab becomes invisible,
as we want to reduce our memory limit for invisible tabs and these
textures should not be saved.

  • src/NonCompositedContentHost.cpp:
  • src/NonCompositedContentHost.h:

(NonCompositedContentHost):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setVisibilityState):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::didCommit):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::scheduleComposite):
(WTF::CCLayerTreeHostTest::dispatchComposite):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestTickAnimationWhileBackgrounded):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::willAnimateLayers):
(CCLayerTreeHostTestVisibilityAndAllocationControlDrawing):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::beginTest):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommit):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::afterTest):
(WTF):

TBR=danakj@chromium.org

17:24 Changeset [119178] by jamesr@google.com
  • 65 edits in trunk/Source

[chromium] Migrate to WebTransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=87788

Patch by Shawn Singh <shawnsingh@chromium.org> on 2012-05-31
Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebTransformationMatrix.h:

(WebTransformationMatrix):

Source/WebCore:

Covered by all existing layout tests and unit tests.

This patch replaces all occurrences of WebCore::TransformationMatrix
with WebKit::WebTransformationMatrix in the chromium compositor code.

  • platform/chromium/support/WebTransformationMatrix.cpp:

(WebKit::WebTransformationMatrix::WebTransformationMatrix):
(WebKit):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setTransformFromAnimation):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
(WebCore::LayerChromium::sublayerTransform):
(WebCore::LayerChromium::drawTransform):
(WebCore::LayerChromium::setDrawTransform):
(WebCore::LayerChromium::screenSpaceTransform):
(WebCore::LayerChromium::setScreenSpaceTransform):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::toGLMatrix):
(WebCore::LayerRendererChromium::drawTexturedQuad):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore::LayerRendererChromium::projectionMatrix):
(WebCore::LayerRendererChromium::windowMatrix):
(LayerRendererChromium):

  • platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::LinkHighlight):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::drawTransform):
(WebCore::RenderSurfaceChromium::setDrawTransform):
(WebCore::RenderSurfaceChromium::originTransform):
(WebCore::RenderSurfaceChromium::setOriginTransform):
(WebCore::RenderSurfaceChromium::screenSpaceTransform):
(WebCore::RenderSurfaceChromium::setScreenSpaceTransform):
(WebCore::RenderSurfaceChromium::replicaDrawTransform):
(WebCore::RenderSurfaceChromium::setReplicaDrawTransform):
(WebCore::RenderSurfaceChromium::replicaOriginTransform):
(WebCore::RenderSurfaceChromium::setReplicaOriginTransform):
(WebCore::RenderSurfaceChromium::replicaScreenSpaceTransform):
(WebCore::RenderSurfaceChromium::setReplicaScreenSpaceTransform):
(RenderSurfaceChromium):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):

  • platform/graphics/chromium/cc/CCAnimationCurve.h:

(WebCore):
(CCTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::quadTransform):
(WebCore::CCDrawQuad::layerTransform):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:

(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(WebKit):
(WebCore):
(CCLayerAnimationControllerClient):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::quadTransform):
(WebCore::CCLayerImpl::setTransformFromAnimation):
(WebCore::CCLayerImpl::setSublayerTransform):
(WebCore::CCLayerImpl::setTransform):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::sublayerTransform):
(WebCore::CCLayerImpl::drawTransform):
(WebCore::CCLayerImpl::setDrawTransform):
(WebCore::CCLayerImpl::screenSpaceTransform):
(WebCore::CCLayerImpl::setScreenSpaceTransform):

  • platform/graphics/chromium/cc/CCLayerSorter.cpp:

(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::createGraphNodes):

  • platform/graphics/chromium/cc/CCLayerSorter.h:

(WebKit):
(LayerShape):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:
  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isSurfaceBackFaceVisible):
(WebCore::calculateVisibleLayerRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::damageInSurfaceSpace):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore):

  • platform/graphics/chromium/cc/CCMathUtil.cpp:

(WebCore::projectPoint):
(WebCore::mapPoint):
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::mapClippedQuad):
(WebCore::CCMathUtil::mapQuad):
(WebCore::CCMathUtil::projectQuad):

  • platform/graphics/chromium/cc/CCMathUtil.h:

(WebKit):
(WebCore):
(CCMathUtil):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::transformSurfaceOpaqueRegion):
(WebCore::reduceOcclusionBelowSurface):
(WebCore::contentToScreenSpaceTransform):
(WebCore::contentToTargetSurfaceTransform):
(WebCore::addOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):
(WebCore::::unoccludedContributingSurfaceContentRect):

  • platform/graphics/chromium/cc/CCOcclusionTracker.h:
  • platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:

(WebCore::CCOverdrawMetrics::didUpload):
(WebCore::CCOverdrawMetrics::didCullForDrawing):
(WebCore::CCOverdrawMetrics::didDraw):

  • platform/graphics/chromium/cc/CCOverdrawMetrics.h:

(WebKit):
(CCOverdrawMetrics):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:
  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsToFillScreen):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore::CCRenderSurface::setDrawTransform):
(WebCore::CCRenderSurface::drawTransform):
(WebCore::CCRenderSurface::setOriginTransform):
(WebCore::CCRenderSurface::originTransform):
(WebCore::CCRenderSurface::setScreenSpaceTransform):
(WebCore::CCRenderSurface::screenSpaceTransform):
(WebCore::CCRenderSurface::setReplicaDrawTransform):
(WebCore::CCRenderSurface::replicaDrawTransform):
(WebCore::CCRenderSurface::setReplicaOriginTransform):
(WebCore::CCRenderSurface::replicaOriginTransform):
(WebCore::CCRenderSurface::setReplicaScreenSpaceTransform):
(WebCore::CCRenderSurface::replicaScreenSpaceTransform):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCSharedQuadState.cpp:

(WebCore::CCSharedQuadState::create):
(WebCore::CCSharedQuadState::CCSharedQuadState):

  • platform/graphics/chromium/cc/CCSharedQuadState.h:

(CCSharedQuadState):
(WebCore::CCSharedQuadState::quadTransform):
(WebCore::CCSharedQuadState::layerTransform):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:

(WebCore::CCSolidColorLayerImpl::quadTransform):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::quadTransform):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

Source/WebKit/chromium:

  • src/WebLayer.cpp:

(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::setTransform):

  • tests/CCAnimationTestCommon.cpp:

(WebKitTests::FakeTransformTransition::getValue):

  • tests/CCAnimationTestCommon.h:
  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::executeCalculateDrawTransformsAndVisibility):
(WebKitTests::TEST_F):

  • tests/CCKeyframedAnimationCurveTest.cpp:
  • tests/CCLayerAnimationControllerTest.cpp:
  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerSorterTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
(WTF::setLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::setTestLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

  • tests/CCLayerTreeTestCommon.h:

(WebKitTests):

  • tests/CCMathUtilTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::createRoot):
(WebKitTests::CCOcclusionTrackerTest::createLayer):
(WebKitTests::CCOcclusionTrackerTest::createSurface):
(WebKitTests::CCOcclusionTrackerTest::createDrawingLayer):
(WebKitTests::CCOcclusionTrackerTest::createReplicaLayer):
(WebKitTests::CCOcclusionTrackerTest::createDrawingSurface):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::setBaseProperties):
(WebKitTests::CCOcclusionTrackerTest::setProperties):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest):

  • tests/CCQuadCullerTest.cpp:
  • tests/CCRenderSurfaceTest.cpp:
  • tests/FloatQuadTest.cpp:
  • tests/LayerChromiumTest.cpp:
  • tests/LinkHighlightTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
  • tests/WebTransformationMatrixTest.cpp:

(WebKit::TEST):
(WebKit):

17:05 Changeset [119177] by danakj@chromium.org
  • 2 edits in branches/chromium/1132/Source/WebKit/chromium

Merge 118276 - [chromium] Enable the CCLayerTreeHostTestCanDrawBlocksDrawing test in single-threaded mode
https://bugs.webkit.org/show_bug.cgi?id=87308

Reviewed by James Robinson.

Chromium bug: http://crbug.com/127481

Unit test: CCLayerTreeHostTestCanDrawBlocksDrawing.runSingleThread

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestHooks::didCommit):
(WTF):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommit):

TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10456072

17:02 Changeset [119176] by piman@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp

Merge 117825 - Don't force rendering in finishAllRendering
https://bugs.webkit.org/show_bug.cgi?id=86919

Reviewed by James Robinson.

After we acquire the texture layers on the main thread, we can't draw.
In particular if we destroyed the texture ids used previously by
TextureLayerChromium, drawing before a commit would cause a
bind-after-destroy.

Tested by CCLayerTreeHostTestFinishAllRendering.

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

TBR=piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10448114

17:02 Changeset [119175] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSGlobalObject does not mark m_privateNameStructure
https://bugs.webkit.org/show_bug.cgi?id=88023

Rubber stamped by Gavin Barraclough.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildren): We need to mark this so it doesn't get
inadvertently garbage collected.

16:53 Changeset [119174] by jberlin@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

[Win] 4 css3 tests fail
https://bugs.webkit.org/show_bug.cgi?id=88024

Add Windows-specific expected (failing?) results to get the bots green.

  • platform/win/css3: Added.
  • platform/win/css3/filters: Added.
  • platform/win/css3/filters/composited-during-animation-expected.txt: Added.
  • platform/win/css3/filters/composited-during-animation-layertree-expected.txt: Added.
  • platform/win/css3/filters/composited-during-transition-layertree-expected.txt: Added.
  • platform/win/css3/unicode-bidi-isolate-basic-expected.png: Added.
  • platform/win/css3/unicode-bidi-isolate-basic-expected.txt: Added.
16:48 Changeset [119173] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Single thread proxy should not tick animations unless the layer renderer has been initialized
https://bugs.webkit.org/show_bug.cgi?id=87873

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-31
Reviewed by James Robinson.

When the layer renderer fails to initialize, be sure to stop the animation timer.

Source/WebCore:

Unit test: CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation.runSingleThread

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::didAddAnimation):
(WebCore::CCSingleThreadProxy::animationTimerDelay):
(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF):
(WTF::TestHooks::didRecreateContext):
(TestHooks):
(WTF::TestHooks::createContext):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::clearEndTestTask):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(EndTestTask):
(WTF::CCLayerTreeHostTest::EndTestTask::EndTestTask):
(WTF::CCLayerTreeHostTest::EndTestTask::~EndTestTask):
(WTF::CCLayerTreeHostTest::EndTestTask::clearTest):
(WTF::CCLayerTreeHostTest::EndTestTask::run):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::endTestAfterDelay):
(FakeWebGraphicsContext3DMakeCurrentFails):
(WTF::FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent):
(CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::beginTest):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::didRecreateContext):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::afterTest):
(WTF::TEST_F):

16:48 WikiStart edited by alex.bravo@nokia.com
Added "(obsolete)" to "Result Fallback Order" (diff)
16:25 Changeset [119172] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

RenderLayerCompositor cleanup: make RenderGeometryMap part of the OverlapMap
https://bugs.webkit.org/show_bug.cgi?id=88021

Reviewed by James Robinson.

We only ever use the RenderGeometryMap when we have an OverlapMap, so make
it a member of the OverlapMap.

No behavior change.

  • rendering/RenderLayerCompositor.cpp:

(RenderLayerCompositor::OverlapMap):
(WebCore::RenderLayerCompositor::OverlapMap::geometryMap):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

  • rendering/RenderLayerCompositor.h:

(WebCore):
(RenderLayerCompositor):

16:13 Changeset [119171] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Pass Isolate to v8Boolean()
https://bugs.webkit.org/show_bug.cgi?id=87948

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8Boolean().

No tests. No change in behavior.

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyDeleter):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::storageDeleter):

  • bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::sendCallback):

16:12 Changeset [119170] by mrobinson@webkit.org
  • 1 edit in trunk/Source/WebKit/gtk/ChangeLog

Fix a broken ChangeLog entry from r119113 due to a corrupted patch.

16:02 Changeset [119169] by lforschler@apple.com
  • 4 edits in branches/safari-536-branch/Source

Versioning.

16:01 Changeset [119168] by lforschler@apple.com
  • 1 copy in tags/Safari-536.15

New Tag.

16:00 Changeset [119167] by lforschler@apple.com
  • 4 edits in branches/safari-536-branch/Source

Versioning.

16:00 Changeset [119166] by jberlin@webkit.org
  • 8 edits
    12 adds in trunk/LayoutTests

[Win] 10 fast/forms tests failing
https://bugs.webkit.org/show_bug.cgi?id=88013

Add/update Windows-expected (failing?) results to get the bots greener.

  • platform/win/fast/forms/basic-selects-expected.png: Added.
  • platform/win/fast/forms/basic-selects-expected.txt:
  • platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png:
  • platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
  • platform/win/fast/forms/file: Added.
  • platform/win/fast/forms/file/file-input-disabled-expected.png: Added.
  • platform/win/fast/forms/file/file-input-disabled-expected.txt: Added.
  • platform/win/fast/forms/implicit-submission-expected.txt:
  • platform/win/fast/forms/input-step-as-double-expected.txt: Added.
  • platform/win/fast/forms/input-text-drag-down-expected.png:
  • platform/win/fast/forms/input-text-drag-down-expected.txt:
  • platform/win/fast/forms/select: Added.
  • platform/win/fast/forms/select-overflow-scroll-expected.png: Added.
  • platform/win/fast/forms/select-overflow-scroll-expected.txt: Added.
  • platform/win/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
  • platform/win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
  • platform/win/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/win/fast/forms/select/optgroup-rendering-expected.txt: Added.
  • platform/win/fast/forms/text-control-intrinsic-widths-expected.txt:
15:58 Changeset [119165] by lforschler@apple.com
  • 3 edits in branches/safari-536-branch/Source/WebCore

fix after r119150.

15:54 Changeset [119164] by brettw@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2012-05-15 Brett Wilson <brettw@chromium.org>

Hook up GTK IsKeyPad flag for keyboard events, and preserve this flag
on all platforms when converting back to a WebKeyboardEvent.

https://bugs.webkit.org/show_bug.cgi?id=86514

Reviewed by Dimitri Glazkov.

  • src/WebInputEventConversion.cpp: (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
  • src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::keyboardEvent):
  • tests/WebInputEventFactoryTestGtk.cpp:
15:53 Changeset [119163] by lforschler@apple.com
  • 1 delete in tags/Safari-536.15

Remove Tag.

15:50 Changeset [119162] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Enable support for rvalue references when building with a version of clang that supports them
https://bugs.webkit.org/show_bug.cgi?id=88018

Re-enable support for rvalue references when building with a version of Xcode newer than 4.2.

  • wtf/Compiler.h:
15:47 Changeset [119161] by commit-queue@webkit.org
  • 78 edits in trunk

IndexedDB: Implement IDBTransaction.error and IDBRequest.error
https://bugs.webkit.org/show_bug.cgi?id=87865

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-31
Reviewed by Tony Chang.

Source/WebCore:

Added "error" attribute to IDBRequest and IDBTransaction. Update
IDBDatabaseError to honor the IDBDatabaseException behavior
of dealing with IDB-specific throws of DOMException codes,
as per the spec.

Existing tests which previously tested 'errorCode' and
'webkitErrorMessage' have been updated to use the new attribute.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setVersion):

  • Modules/indexeddb/IDBDatabaseError.h:

(WebCore::IDBDatabaseError::create):
(WebCore::IDBDatabaseError::code):
(WebCore::IDBDatabaseError::idbCode):
(WebCore::IDBDatabaseError::name):
(WebCore::IDBDatabaseError::IDBDatabaseError):
(IDBDatabaseError):

  • Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore):
(WebCore::getErrorEntry):
(WebCore::IDBDatabaseException::initializeDescription):
(WebCore::IDBDatabaseException::getErrorName):
(WebCore::IDBDatabaseException::getLegacyErrorCode):

  • Modules/indexeddb/IDBDatabaseException.h:

(IDBDatabaseException):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::createIndex):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::error):
(WebCore):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::dispatchEvent):

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::error):
(WebCore):
(WebCore::IDBTransaction::setError):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • Modules/indexeddb/IDBTransaction.idl:

Source/WebKit/chromium:

IDBDatabaseError now honors IDB-specific DOMException codes,
so make sure that's how they are passed to/from chromium.

  • src/WebIDBDatabaseError.cpp:

(WebKit::WebIDBDatabaseError::assign):

LayoutTests:

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/cursor-continue-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/deleteIndex-expected.txt:
  • storage/indexeddb/factory-cmp-expected.txt:
  • storage/indexeddb/get-keyrange-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics-workers-expected.txt:
  • storage/indexeddb/index-count-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/invalid-keys-expected.txt:
  • storage/indexeddb/key-generator-expected.txt:
  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/keypath-edges-expected.txt:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/objectstore-count-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/readonly-expected.txt:
  • storage/indexeddb/resources/basics.js:

(test):
(openCallback):

  • storage/indexeddb/resources/create-and-remove-object-store.js:

(testCreateAndRemove):
(cleanDatabase):
(tryOnceMore):

  • storage/indexeddb/resources/cursor-continue.js:

(ascendingErrorTestLessThan.request.onsuccess):
(ascendingErrorTestLessThan):
(ascendingErrorTestEqual.request.onsuccess):
(ascendingErrorTestEqual):
(descendingErrorTestGreaterThan.request.onsuccess):
(descendingErrorTestGreaterThan):
(descendingErrorTestEqual.request.onsuccess):
(descendingErrorTestEqual):
(onTransactionComplete):

  • storage/indexeddb/resources/cursor-update.js:

(keyCursor):

  • storage/indexeddb/resources/database-basics.js:

(testClose):

  • storage/indexeddb/resources/database-quota.js:

(logError):

  • storage/indexeddb/resources/deleteIndex.js:

(twiddleIndexes):
(postTwiddling):

  • storage/indexeddb/resources/factory-cmp.js:

(testValidKeys):
(testInvalidKeys):

  • storage/indexeddb/resources/get-keyrange.js:

(getNullTest):

  • storage/indexeddb/resources/index-basics.js:

(index3Count):

  • storage/indexeddb/resources/index-count.js:
  • storage/indexeddb/resources/index-unique.js:

(addMoreDataFailed):

  • storage/indexeddb/resources/invalid-keys.js:
  • storage/indexeddb/resources/key-generator.js:
  • storage/indexeddb/resources/key-type-array.js:

(testDepthLimits):

  • storage/indexeddb/resources/keypath-edges.js:
  • storage/indexeddb/resources/keyrange.js:

(test):

  • storage/indexeddb/resources/objectstore-autoincrement.js:

(getAbrahamSuccess):

  • storage/indexeddb/resources/objectstore-basics.js:

(setVersionSuccess):
(createIndex):
(addAgainFailure):
(removeSuccessButNotThere):
(testPreConditions.request.onsuccess):
(testPreConditions):

  • storage/indexeddb/resources/objectstore-count.js:
  • storage/indexeddb/resources/open-cursor.js:

(cursorWithKeySuccess):
(cursorSuccess):

  • storage/indexeddb/resources/readonly.js:

(openSuccess):

  • storage/indexeddb/resources/set_version_queue.js:

(connectionError):

  • storage/indexeddb/resources/shared.js:

(unexpectedErrorCallback):
(evalAndExpectException):

  • storage/indexeddb/resources/transaction-abort-workers.js:

(transactionAborted):
(transactionCompleted):
(timeoutTest.transaction.onabort):
(timeoutTest):
(errorTransactionAborted):

  • storage/indexeddb/resources/transaction-abort.js:

(firstAdd):
(secondAdd):
(transactionAborted):

  • storage/indexeddb/resources/transaction-after-close.js:

(firstTransactionComplete):

  • storage/indexeddb/resources/transaction-and-objectstore-calls.js:

(created):
(afterComplete):

  • storage/indexeddb/resources/transaction-basics.js:

(testInactiveAbortedTransaction):
(testInactiveCompletedTransaction):
(testInvalidMode):

  • storage/indexeddb/resources/transaction-read-only.js:

(setVersionDone):
(gotCursor):

  • storage/indexeddb/set_version_queue-expected.txt:
  • storage/indexeddb/transaction-abort-expected.txt:
  • storage/indexeddb/transaction-abort-workers-expected.txt:
  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-read-only-expected.txt:
15:43 Changeset [119160] by jamesr@google.com
  • 4 edits in trunk/Source

[chromium] Assertion failures during compositor startup in lost context situations
https://bugs.webkit.org/show_bug.cgi?id=87912

Reviewed by Adrienne Walker.

Source/WebCore:

getShaderiv and getProgramiv may return 0 if the context is lost. We correctly recover in this case, so it's
bogus to fail an ASSERT in debug in this case.

Added new unit test in LayerRendererChromiumTest to cover this.

  • platform/graphics/chromium/ProgramBinding.cpp:

(WebCore::contextLost):
(WebCore):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::createShaderProgram):

Source/WebKit/chromium:

Adds a unit test verifying that even if we lose our context during or before initialization we get through the
rest of the path without failing ASSERT()s.

  • tests/LayerRendererChromiumTest.cpp:

(LoseContextOnFirstGetContext):
(LoseContextOnFirstGetContext::LoseContextOnFirstGetContext):
(TEST):

15:37 Changeset [119159] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

Unreviewed, rolling out r119113.
http://trac.webkit.org/changeset/119113
https://bugs.webkit.org/show_bug.cgi?id=88016

This caused multiple regressions (Requested by mrobinson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-31

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString):

  • webkit/webkitspellcheckerenchant.cpp:

(checkSpellingOfString):

15:36 Acronyms edited by alex.bravo@nokia.com
(diff)
15:34 Changeset [119158] by benm@google.com
  • 5 edits
    3 adds in trunk

Fix crash in V8Document::createTouchListCallback.
https://bugs.webkit.org/show_bug.cgi?id=87085

Source/WebCore:

Reviewed by Abhishek Arya.

Test: fast/events/touch/document-create-touch-list-crash.html

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::createTouchListCallback): Verify the native type
of the arguments passed to createTouchList are Touches before appending
them to the TouchList. In the case of a non-Touch argument, insert
null into the TouchList. This consolidates V8 and JSC bindings
behaviour.

  • dom/Document.cpp: Remove dead code.
  • dom/Document.h: ditto.

LayoutTests:

Test for crash in document.createTouchList when it
is supplied with non-touch parameters.

Reviewed by Abhishek Arya.

  • fast/events/touch/document-create-touch-list-crash-expected.txt: Added.
  • fast/events/touch/document-create-touch-list-crash.html: Added.
15:30 Changeset [119157] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

DataLog should be usable outside of JSC
https://bugs.webkit.org/show_bug.cgi?id=88015

Reviewed by Oliver Hunt.

  • wtf/DataLog.h:

(WTF):

15:18 Changeset [119156] by rafaelw@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Updating test expectations after r119124.

  • platform/chromium/fast/workers/storage/test-authorizer-sync-expected.txt: Added.
15:06 Changeset [119155] by lforschler@apple.com
  • 4 edits in branches/safari-536-branch/Source

Versioning.

15:03 Changeset [119154] by lforschler@apple.com
  • 1 copy in tags/Safari-536.15

New Tag.

14:51 Changeset [119153] by rniwa@webkit.org
  • 2 edits in trunk/Tools

[Chromium] Chromium DRT should be able to load external resources
https://bugs.webkit.org/show_bug.cgi?id=87893

Reviewed by Dirk Pranke.

Allow external resources to be loaded when the main frame's URL is also an external resource.
This change is analogous to r118231 for Mac port.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(blockRequest):
(isLocalhost):
(hostIsUsedBySomeTestsToGenerateError):
(WebViewHost::willSendRequest):

14:32 SettingUpDevelopmentEnvironmentForN9 edited by luciano.wolf@openbossa.org
(diff)
14:26 Changeset [119152] by ap@apple.com
  • 4 edits in branches/safari-536-branch/LayoutTests

More result updating for disabling CSS Exclusions.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
14:21 Changeset [119151] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

Remove some duplicate code in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=88009

Reviewed by Anders Carlsson.

RenderLayerCompositor::hasNonAffineTransform() has the same code
as the existing RenderLayer::has3DTransform(), so just use the
RenderLayer method and remove hasNonAffineTransform().

No behavior change.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

14:20 Changeset [119150] by lforschler@apple.com
  • 34 edits in branches/safari-536-branch

Merge <rdar://problem/11524921>

14:15 Changeset [119149] by jberlin@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

[Win] 5 fast/events/popup-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=88008

Add Windows-specific expected (failing?) results to get the bots greener.

  • platform/win/fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
  • platform/win/fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Added.
  • platform/win/fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Added.
  • platform/win/fast/events/popup-blocked-from-untrusted-mouse-click-expected.txt: Added.
  • platform/win/fast/events/popup-blocking-timers-expected.txt: Added.
14:12 Changeset [119148] by ap@apple.com
  • 4 edits in branches/safari-536-branch/LayoutTests

Updating results after r119051.

Per discussion with Simon, it's not surprising that more layers have drawsContents now.

  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
14:10 Changeset [119147] by jberlin@webkit.org
  • 13 edits
    8 adds in trunk/LayoutTests

[Win] 23 media tests fail / time out
https://bugs.webkit.org/show_bug.cgi?id=88005

Add/update the Windows expected (failing?) results to get the bots greener.

  • platform/win/Skipped:
  • platform/win/media/audio-controls-rendering-expected.txt:
  • platform/win/media/audio-repaint-expected.txt:
  • platform/win/media/controls-after-reload-expected.txt:
  • platform/win/media/controls-strict-expected.txt:
  • platform/win/media/controls-styling-expected.txt:
  • platform/win/media/controls-without-preload-expected.txt:
  • platform/win/media/media-can-play-wav-audio-expected.txt: Added.
  • platform/win/media/media-controls-clone-expected.txt:
  • platform/win/media/media-controls-invalid-url-expected.txt: Added.
  • platform/win/media/media-document-audio-repaint-expected.txt:
  • platform/win/media/nodesFromRect-shadowContent-expected.txt: Added.
  • platform/win/media/video-colorspace-yuv420-expected.txt: Added.
  • platform/win/media/video-colorspace-yuv422-expected.txt: Added.
  • platform/win/media/video-controls-rendering-expected.txt:
  • platform/win/media/video-display-toggle-expected.txt:
  • platform/win/media/video-no-audio-expected.txt:
  • platform/win/media/video-pause-immediately-expected.txt: Added.
  • platform/win/media/video-playing-and-pause-expected.txt: Added.
  • platform/win/media/video-size-intrinsic-scale-expected.txt: Added.
14:09 Changeset [119146] by rafaelw@chromium.org
  • 22 edits in trunk/Source

Unreviewed, rolling out r119125.
http://trac.webkit.org/changeset/119125
https://bugs.webkit.org/show_bug.cgi?id=88007

Will break android build if rolled (Requested by rafaelw_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-31

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayer::bytesLoaded):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::bytesLoaded):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(MediaPlayerPrivateAVFoundation):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::bytesLoaded):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::bytesLoaded):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:

(MediaPlayerPrivateQTKit):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::bytesLoaded):

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::bytesLoaded):

  • platform/graphics/qt/MediaPlayerPrivateQt.h:

(MediaPlayerPrivateQt):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::bytesLoaded):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

(MediaPlayerPrivateQuickTimeVisualContext):

  • platform/graphics/wince/MediaPlayerPrivateWinCE.h:

(MediaPlayerPrivate):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::bytesLoaded):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

14:03 Changeset [119145] by aestes@apple.com
  • 12 edits in trunk/Source

Disentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that which merely relies on PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=87933

Reviewed by Dan Bernstein.

Source/WebCore:

  • editing/Editor.cpp:
  • editing/Editor.h:
  • loader/EmptyClients.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):

  • page/EditorClient.h:

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
13:58 Changeset [119144] by jberlin@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

[Win] fast/events/remove-target* tests fail
https://bugs.webkit.org/show_bug.cgi?id=88006

Add Windows-specific expected (failing?) results to get the bots greener.

  • platform/win/fast/events/remove-target-in-mouseup-deep-expected.txt: Added.
  • platform/win/fast/events/remove-target-in-mouseup-expected.txt: Added.
  • platform/win/fast/events/remove-target-in-mouseup-insertback-expected.txt: Added.
  • platform/win/fast/events/remove-target-in-mouseup-twice-expected.txt: Added.
  • platform/win/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.
13:55 Writing Layout Tests for DumpRenderTree edited by jchaffraix@webkit.org
Added a section on ref-tests and added more tips on portable text (diff)
13:55 Changeset [119143] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Disable support for rvalue references until I figure out why this is breaking the Xcode 4.2 build.

  • wtf/Compiler.h:
13:53 Changeset [119142] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; skip fast/canvas/canvas-imageSmoothingEnabled.

Skip the test just like GTK+, as there seems to be a problem in
the cairo backend that makes the test fail.

  • platform/efl/test_expectations.txt:
13:48 Changeset [119141] by ap@apple.com
  • 9 edits in branches/safari-536-branch/LayoutTests

Update test results for disabling CSS Exclusions.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/Skipped:
  • platform/mac/fast/js/global-constructors-expected.txt:
  • platform/win/Skipped:
  • platform/win/fast/js/global-constructors-expected.txt:
  • platform/wk2/Skipped:
  • svg/css/getComputedStyle-basic-expected.txt:
13:44 Changeset [119140] by andersca@apple.com
  • 4 edits in trunk/Tools

Build fixes.

Disable the C++11 extensions warning.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
13:41 Changeset [119139] by danakj@chromium.org
  • 17 edits in trunk/Source

[chromium] Move drawing code for RenderSurfaces into LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=87877

Reviewed by James Robinson.

Source/WebCore:

We add data to CCRenderSurfaceDrawQuad so that the only use of
CCRenderSurface directly from LayerRendererChromium is to
reserve, release, and use the surface's textures, and to set the
scissor rect. Each of these changes will be done independent
of this change.

Covered by existing tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::applyFilters):
(WebCore):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::contentsTextureId):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateDrawTransformsAndVisibilityInternal):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:
  • platform/graphics/chromium/cc/CCQuadCuller.h:

(CCQuadCuller):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore):
(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::releaseContentsTexture):
(WebCore::CCRenderSurface::hasValidContentsTexture):
(WebCore::CCRenderSurface::releaseBackgroundTexture):
(WebCore::CCRenderSurface::hasValidBackgroundTexture):
(WebCore::CCRenderSurface::hasMask):
(WebCore::CCRenderSurface::replicaHasMask):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp:

(WebCore::CCRenderSurfaceDrawQuad::create):
(WebCore::CCRenderSurfaceDrawQuad::CCRenderSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h:

(WebKit):
(CCRenderSurfaceDrawQuad):
(WebCore::CCRenderSurfaceDrawQuad::maskTextureId):
(WebCore::CCRenderSurfaceDrawQuad::filters):
(WebCore::CCRenderSurfaceDrawQuad::backgroundFilters):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::contentsTextureId):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

Source/WebKit/chromium:

  • tests/CCRenderSurfaceTest.cpp:

(WebCore::TEST):

13:28 Changeset [119138] by jberlin@webkit.org
  • 3 edits
    8 adds in trunk/LayoutTests

[Win] 10 fast/text tests failing
https://bugs.webkit.org/show_bug.cgi?id=87998

Add/update Windows-specific expected (failing?) pixel results in order to get the bots greener.

  • platform/win/fast/text/complex-preferred-logical-widths-expected.png: Added.
  • platform/win/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
  • platform/win/fast/text/international/arabic-justify-expected.png: Added.
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Added.
  • platform/win/fast/text/international/text-combine-image-test-expected.png:
  • platform/win/fast/text/international/text-spliced-font-expected.png: Added.
  • platform/win/fast/text/line-initial-and-final-swashes-expected.png: Added.
  • platform/win/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
  • platform/win/fast/text/unicode-variation-selector-expected.png: Added.
13:16 Changeset [119137] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed gardening, updating baselines after r119124.

  • dom/xhtml/level3/core/documentnormalizedocument10-expected.txt:
  • dom/xhtml/level3/core/documentsetxmlversion03-expected.txt:
  • fast/workers/storage/test-authorizer-sync-expected.txt:
12:58 Changeset [119136] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/11544454> and https://bugs.webkit.org/show_bug.cgi?id=87990
Crashes unregistering DOMWindowProperties while releasing CachedPages

Reviewed by Jessie Berlin.

This patch rewrites DOMWindowProperty to always keep direct track of the DOMWindow
it has registered with and to only ever unregister from that very same DOMWindow.

No new tests. (While the direct cause of the crash is understood, reproducing it is not)

  • page/DOMWindowProperty.cpp:

(WebCore::DOMWindowProperty::DOMWindowProperty):
(WebCore::DOMWindowProperty::~DOMWindowProperty):
(WebCore::DOMWindowProperty::disconnectFrameForPageCache):
(WebCore::DOMWindowProperty::reconnectFrameFromPageCache):
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInCachedFrame):
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInFrame):
(WebCore::DOMWindowProperty::willDetachGlobalObjectFromFrame):

  • page/DOMWindowProperty.h:

(DOMWindowProperty):

12:48 Changeset [119135] by jamesr@google.com
  • 1 edit in branches/chromium/1132/LayoutTests/platform/chromium/test_expectations.txt

Revert bad merge of chromium test_expectations.txt on 1132 branch

BUG=130392

12:30 Changeset [119134] by staikos@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[Blackberry] Initialize the select client and delete the pointer
in the destructor so it doesn't leak. Fixes test crashes.
https://bugs.webkit.org/show_bug.cgi?id=87992

Reviewed by Rob Buis.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::~InputHandler):

12:20 Changeset [119133] by pdr@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 117365 - Crash if SVG gradient stop has display: none set

12:12 Changeset [119132] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Vector should have a move constructor and move assignment operator
https://bugs.webkit.org/show_bug.cgi?id=87997

Reviewed by Andreas Kling.

  • wtf/Compiler.h:

Use has_extension so we can use move semantics and other C++11 features even when building as C++98.

  • wtf/Vector.h:

Add a move constructor and a move assignment operator to Vector.

12:08 Changeset [119131] by tony@chromium.org
  • 58 edits in trunk

rename flexbox CSS properties from flex-align and flex-item-align to align-items and align-self
https://bugs.webkit.org/show_bug.cgi?id=87907

Reviewed by Ojan Vafai.

Source/WebCore:

This was recently changed in the spec:
http://dev.w3.org/csswg/css3-flexbox/#align-items-property

No new tests, updated the tests to use the new naming.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EAlignItems):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::alignmentForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData): Move member variables to StyleRareNonInheritedData
because these values will eventually apply to more than just flexbox.

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

Updated tests for new CSS property names.

  • css3/flexbox/align-absolute-child.html:
  • css3/flexbox/cross-axis-scrollbar.html:
  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-align-baseline.html:
  • css3/flexbox/flex-align-column.html:
  • css3/flexbox/flex-align-end.html:
  • css3/flexbox/flex-align-stretch.html:
  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/line-wrapping.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-reverse-wrap-baseline.html:
  • css3/flexbox/orthogonal-flex-directions.html:
  • css3/flexbox/position-absolute-child.html:
  • css3/flexbox/true-centering.html:
11:52 Changeset [119130] by jberlin@webkit.org
  • 2 edits
    9 adds in trunk/LayoutTests

[Win] 10 fast/text tests failing
https://bugs.webkit.org/show_bug.cgi?id=87998

Add/update Windows-specific expected (failing?) results in order to get the bots greener.

  • platform/win/fast/text/complex-preferred-logical-widths-expected.txt: Added.
  • platform/win/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
  • platform/win/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Added.
  • platform/win/fast/text/international/text-combine-image-test-expected.txt:
  • platform/win/fast/text/international/text-spliced-font-expected.txt: Added.
  • platform/win/fast/text/line-initial-and-final-swashes-expected.txt: Added.
  • platform/win/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
  • platform/win/fast/text/unicode-variation-selector-expected.txt: Added.
11:48 Changeset [119129] by danakj@chromium.org
  • 2 edits in trunk/Source/Platform

[chromium] Add copy constructor to WebFilterOperations
https://bugs.webkit.org/show_bug.cgi?id=87970

Reviewed by James Robinson.

  • chromium/public/WebFilterOperations.h:

(WebKit::WebFilterOperations::WebFilterOperations):

11:37 Changeset [119128] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Updating test expectations (svg/as-image/animated-svg-as-image.html)

  • platform/chromium/test_expectations.txt:
11:17 Writing testharness Tests edited by jacobg@adobe.com
(diff)
11:17 Writing testharness Tests edited by jacobg@adobe.com
(diff)
11:11 Changeset [119127] by ap@apple.com
  • 4 edits in trunk/Tools

[WK2] window.internals settings are not reset between tests
https://bugs.webkit.org/show_bug.cgi?id=87783

Reviewed by Mihai Parparita.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done): Call resetAfterTest().
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity. (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals. This needs to be done after a tets, because the code assumes that there is an object with this name in global scope.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
11:09 Changeset [119126] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash when destroying WebOverlay with active WebOverlayOverride
https://bugs.webkit.org/show_bug.cgi?id=87968

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-31
Reviewed by Rob Buis.

The override object is using a compositing thread WebOverlayPrivate
object with no client because the layer doesn't delegate drawing to the
WebOverlayPrivate, it's only used to modify the override properties on
the underlying compositing thread layer.

Since the m_layerCompositingThreadClient is optional, we have to add
null checks.

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setClient):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToColor):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setDrawsContent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::invalidate):

11:03 Changeset [119125] by fischman@chromium.org
  • 22 edits in trunk/Source

Replace WebMediaPlayer::bytesLoaded() with an explicit didLoadingProgress()
https://bugs.webkit.org/show_bug.cgi?id=86113

Reviewed by Eric Carlson.

Source/WebCore:

No new functionality, so no new tests. Loading progress is already tested by existing layouttests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::didLoadingProgress):
(WebCore::MediaPlayer::didLoadingProgress):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(MediaPlayerPrivateAVFoundation):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::didLoadingProgress):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:

(MediaPlayerPrivateQTKit):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::didLoadingProgress):

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::didLoadingProgress):

  • platform/graphics/qt/MediaPlayerPrivateQt.h:

(MediaPlayerPrivateQt):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::didLoadingProgress):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:

(MediaPlayerPrivateQuickTimeVisualContext):

  • platform/graphics/wince/MediaPlayerPrivateWinCE.h:

(MediaPlayerPrivate):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::didLoadingProgress):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

11:00 Changeset [119124] by arv@chromium.org
  • 31 edits
    3 moves
    8 adds
    4 deletes in trunk

Make DOM Exceptions Errors
https://bugs.webkit.org/show_bug.cgi?id=85078

Reviewed by Oliver Hunt.

WebIDL mandates that exceptions should have Error.prototype on its prototype chain.

For JSC we have access to the Error.prototype from the binding code.

For V8 we set a field in the WrapperTypeInfo and when the constructor function is created we
set the prototype as needed.

Updated test: fast/dom/DOMException/prototype-object.html

Source/JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObject.h:

(JSC):
(JSGlobalObject):
(JSC::JSGlobalObject::errorPrototype):

Source/WebCore:

  • ForwardingHeaders/runtime/ErrorPrototype.h: Added.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestException::createPrototype):

  • bindings/scripts/test/JS/JSTestException.h:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):
(WebCore::V8TestObj::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npObjectTypeInfo):

  • bindings/v8/V8BindingPerContextData.cpp:

(WebCore):
(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):

  • bindings/v8/V8BindingPerContextData.h:

(V8BindingPerContextData):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperTypeInfo):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

LayoutTests:

  • fast/dom/DOMException/prototype-object-expected.txt:
  • fast/dom/DOMException/prototype-object.html:
  • fast/dom/DOMException/resources/prototype-object.js: Removed.
  • platform/chromium-win/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Removed.
  • platform/chromium-win/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Removed.
  • platform/chromium-win/svg/filters/feBlend-invalid-mode-expected.txt: Removed.
  • platform/chromium/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Added.
  • platform/chromium/dom/xhtml/level3/core/documentsetxmlversion03-expected.txt: Added.
  • platform/chromium/fast/dom/DOMException/prototype-object-expected.txt:
  • platform/chromium/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt.
  • platform/chromium/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt.
  • platform/chromium/svg/filters/feBlend-invalid-mode-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/filters/feBlend-invalid-mode-expected.txt.
10:56 Changeset [119123] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] ASSERT(oldLayoutDelta == view()->layoutDelta()) failed in RenderBlock::layoutBlockChild
when running media/media-volume-slider-rendered-below.html
https://bugs.webkit.org/show_bug.cgi?id=87450

Add the test to the Windows Skipped list to get the bots greener.

  • platform/win/Skipped:
10:55 Writing Layout Tests for DumpRenderTree edited by jacobg@adobe.com
(diff)
10:51 Writing testharness Tests created by jacobg@adobe.com
10:42 WikiStart edited by jacobg@adobe.com
(diff)
10:41 Changeset [119122] by lforschler@apple.com
  • 40 edits in branches/safari-536-branch

Merge <rdar://problem/10887709>

10:38 Changeset [119121] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk/Source

[chromium] create WebTransformOperation interface for chromium platform
https://bugs.webkit.org/show_bug.cgi?id=87510

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-31
Reviewed by James Robinson.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebTransformOperations.h: Added.

(WebKit):
(WebTransformOperations):
(WebKit::WebTransformOperations::~WebTransformOperations):
(WebKit::WebTransformOperations::WebTransformOperations):
(WebKit::WebTransformOperations::operator=):

Source/WebCore:

Unit tests:

WebTransformOperationsTest.transformTypesAreUnique
WebTransformOperationsTest.matchesTypesSameLength
WebTransformOperationsTest.matchesTypesDifferentLength
WebTransformOperationsTest.applyTranslate
WebTransformOperationsTest.applyRotate
WebTransformOperationsTest.applyScale
WebTransformOperationsTest.applySkew
WebTransformOperationsTest.applyPerspective
WebTransformOperationsTest.applyMatrix
WebTransformOperationsTest.applyOrder
WebTransformOperationsTest.blendOrder
WebTransformOperationsTest.blendProgress
WebTransformOperationsTest.blendWhenTypesDoNotMatch

  • WebCore.gypi:
  • platform/chromium/support/WebTransformOperations.cpp: Added.

(WebKit):
(WebTransformOperationsPrivate):
(WebKit::WebTransformOperations::apply):
(WebKit::WebTransformOperations::blend):
(WebKit::WebTransformOperations::matchesTypes):
(WebKit::WebTransformOperations::appendTranslate):
(WebKit::WebTransformOperations::appendRotate):
(WebKit::WebTransformOperations::appendScale):
(WebKit::WebTransformOperations::appendSkew):
(WebKit::WebTransformOperations::appendPerspective):
(WebKit::WebTransformOperations::appendMatrix):
(WebKit::WebTransformOperations::reset):
(WebKit::WebTransformOperations::initialize):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/WebTransformOperationsTest.cpp: Added.

(TEST):
(checkProgress):

10:36 WikiStart edited by jacobg@adobe.com
(diff)
10:35 Changeset [119120] by jberlin@webkit.org
  • 1 edit
    15 adds in trunk/LayoutTests

10 W3C video and audio canPlayType tests are failing on Mac and Win
https://bugs.webkit.org/show_bug.cgi?id=75184

Add Windows-specific expected (failing?) results to get the bots greener.

  • platform/win/media/W3C: Added.
  • platform/win/media/W3C/audio: Added.
  • platform/win/media/W3C/audio/canPlayType: Added.
  • platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
  • platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • platform/win/media/W3C/video: Added.
  • platform/win/media/W3C/video/canPlayType: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
  • platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
10:33 Changeset [119119] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[Blackberry] WebKit's fullscreen mode needs to notify page client.
https://bugs.webkit.org/show_bug.cgi?id=87337

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-05-31
Reviewed by Antonio Gomes.

Move "fullScreenVideoCapable" into webpagePrivate to make code
clean for "fullScreenForElement/Node" of cromeClientBlackberry,
All Video checks and code path selections are in webpagePrivate now.
For some UX and secure reasons, we could not apply fullscreen capacity
for all elements, So we use client's fullscreenStart/Stop only for
those video elements and those elements containing video tags.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(WebKit):
(BlackBerry::WebKit::containsVideoTags):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):

10:29 Changeset [119118] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Memory leak in webkit_web_view_init
https://bugs.webkit.org/show_bug.cgi?id=87943

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-31
Reviewed by Martin Robinson.

Fixed a memory leak in webkit_web_view_init by making the
UserMediaClientGtk to be owned by the WebView.

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

  • webkit/webkitwebviewprivate.h:
10:28 Changeset [119117] by wingo@igalia.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix reference to unset variable in debug mode
https://bugs.webkit.org/show_bug.cgi?id=87981

Reviewed by Geoffrey Garen.

  • runtime/JSONObject.cpp (Stringifier::Holder::Holder):

Initialize m_size in debug mode, as we check it later in an assert.

10:15 Changeset [119116] by commit-queue@webkit.org
  • 9 edits in trunk

[EFL][DRT] EFL's DRT navigation_policy_decision implementation
https://bugs.webkit.org/show_bug.cgi?id=85006

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31
Reviewed by Tor Arne Vestbø.

Tools:

Added navigation_policy_decision implementation for DumpRenderTreeView.
Added LayoutTestController::setCustomPolicyDelegate implementation.
Modified LayoutTestController::waitForPolicyDelegate.

  • DumpRenderTree/efl/DumpRenderTree.cpp:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/DumpRenderTreeEfl.h:
  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(navigationTypeToString): aux function
(onNavigationPolicyDecision): navigation_policy_decision implementation
(drtViewAdd):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setCustomPolicyDelegate):
(LayoutTestController::waitForPolicyDelegate):

LayoutTests:

Unskipped corresponding tests. Those still not passing are put into
test_expectations.txt.

  • platform/efl/Skipped:
  • platform/efl/test_expectations.txt:
10:00 Changeset [119115] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
https://bugs.webkit.org/show_bug.cgi?id=86195

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-05-31
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

add new function to clear security origin application cache,
and a function to create a security origin from url string.
Reindent the header to match new longer return signature.

  • ewk/ewk_security_origin.cpp:

(ewk_security_origin_application_cache_clear):
(ewk_security_origin_new_from_string):

  • ewk/ewk_security_origin.h:

Tools:

Implement clearApplicationCacheForOrigin in EFL
LayoutTestController.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::clearApplicationCacheForOrigin):

LayoutTests:

Unskip http/tests/appcache/origin-delete.html now that
EFL TestLayoutController has required functionality.

  • platform/efl/Skipped:
09:53 Changeset [119114] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

m_totalAllocated should be intialized in RenderArena constructor
https://bugs.webkit.org/show_bug.cgi?id=87967

Reviewed by Ojan Vafai.

  • rendering/RenderArena.cpp:

(WebCore::RenderArena::RenderArena): added missing initializer.

09:36 Changeset [119113] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

Spell checker doesn't recognize contractions (apostrophes)
https://bugs.webkit.org/show_bug.cgi?id=86118

Patch by commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> on 2012-05-31
Reviewed by Gustavo Noronha Silva.

The Enchant spell checker was breaking words on apostrophes, because
apparently they were always being detected as Pango word-end
characters. To know whether or not the apostrophe is a
word end character requires looking at a string with a larger
granularity than one character.

Simplify the way the we break strings, by search for non-graphable
character manually to find word starts and ends. This has the side
effect of removing the dependency on Pango and eliminating one copy.

This change also cleans up some misbehavior on the part of the
WebCoreSupport layer which was not converting from Unicode character
offsets to UTF-16. These offsets can be different if any of the
characters in the UTF-16 string are surrogate pairs (non BMP
characters).

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString): Properly
convert from Unicode offsets to UTF-16 offsets.

  • webkit/webkitspellcheckerenchant.cpp:

(findByteOffsetToFirstNonGraphableCharacter): Added this helper.
(getExtentsOfNextWord): Ditto.
(wordIsSpelledCorrectlyInAtLeastOneDictionary): Ditto.
(checkSpellingOfString): Don't split words on apostrophes.

09:32 Changeset [119112] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed. Added FAIL expectation due to failure after r119100.

  • platform/gtk/test_expectations.txt:
09:08 Changeset [119111] by jberlin@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[Win] 6 canvas tests failing
https://bugs.webkit.org/show_bug.cgi?id=87983

Add Windows-specific expected (failing?) results to get the bots greener.

  • platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-scale-drawImage-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Added.
09:00 Changeset [119110] by jchaffraix@webkit.org
  • 13 edits in trunk/Source/WebCore

The difference between a column and a column group renderer is badly drawn
https://bugs.webkit.org/show_bug.cgi?id=87556

Reviewed by Abhishek Arya.

No expected change in behavior.

This patch tries to draw a better line between those 3 concepts:

  • renderer is a RenderTableCol (RenderObject::isRenderTableCol).
  • renderer is a column (RenderTableCol::isTableColumn()).
  • renderer is a column group (RenderTableCol::isTableColumnGroup()).

(most of the code that needs to know the difference manipulate a RenderTableCol
so there was no need to move the 2 last helpers into RenderObject)

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
Factored the code to use the column / column group iteration we
set up in the rest of the code. Made the code more self-describing
by using more RenderTableCol functions.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild):
Factored the code to use the isTableColumn() and isTableColumnGroup() to
better underline what we check.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderTableCol):
(WebCore::RenderObject::isTablePart):
Renamed isTableCol to isRenderTableCol to match the class as this doesn't
imply that the renderer is actually a column.

  • html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::parseAttribute):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::fullRecalc):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::firstColumn):
Updated after the isRenderTableCol rename.

  • dom/Text.cpp:

(WebCore::Text::rendererIsNeeded):

  • editing/htmlediting.cpp:

(WebCore::isTableStructureNode):
Ditto and renamed some variables.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::rendererIsNeeded):
Ditto and added a FIXME as the logic doesn't seem very bullet proof.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
Changed to use the enclosingColumnGroup* helpers.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintCell):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::isChildAllowed):
(WebCore::RenderTableCol::canHaveChildren):
(WebCore::RenderTableCol::enclosingColumnGroup):
(WebCore::RenderTableCol::nextColumn):
Updated to use the new functions.

  • rendering/RenderTableCol.h:

(WebCore::RenderTableCol::isTableColumn):
(WebCore::RenderTableCol::isTableColumnGroup):
(WebCore::RenderTableCol::enclosingColumnGroupIfAdjacentBefore):
(WebCore::RenderTableCol::enclosingColumnGroupIfAdjacentAfter):
Added the following new helpers.

08:41 Changeset [119109] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix Lion build after r119073.

  • platform/Decimal.cpp:

(WebCore::Decimal::toString):
Do not attempt to assign a unsigned long long to an int.

08:31 Changeset [119108] by carlosgc@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] Add webkit_download_get_request to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=87957

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitDownload.cpp:

(webkit_download_get_request): Return the WebKitURIRequest
representing the request that originated the download.

  • UIProcess/API/gtk/WebKitDownload.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
  • UIProcess/API/gtk/tests/TestDownloads.cpp:

(testDownloadLocalFile):
(testDownloadRemoteFile):

08:29 Changeset [119107] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[SOUP] WebProcess crashes when a download is started from an existing ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=87953

Reviewed by Martin Robinson.

The output stream to write the downloaded data is created in the
didReceiveResponse callback of the download client. When a
download is created for an existing ResourceHandle (this happens
for example when policy decision is download), the response has
already been received. In this case we should make sure that the
download client is notified about the response, so that when data
actually arrives the output stream has already been created.

  • WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::Download::startWithHandle):

08:27 Changeset [119106] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix webkit_web_view_can_execute_editing_command() API doc
https://bugs.webkit.org/show_bug.cgi?id=87930

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitWebView.cpp:
08:27 Changeset [119105] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash when closing web page if selection is active
https://bugs.webkit.org/show_bug.cgi?id=87962

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-31
Reviewed by Antonio Gomes.

The embedder may try to remove a layer from the compositor at a stage
where the compositor has been set to 0.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
(BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):

08:15 Changeset [119104] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[v8] Fix bug reference in array-override-set.html test
https://bugs.webkit.org/show_bug.cgi?id=87952

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-05-31
Reviewed by Abhishek Arya.

  • fast/canvas/webgl/array-override-set-expected.txt:
  • fast/canvas/webgl/array-override-set.html:
08:12 Changeset [119103] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed. Added FAIL expectation due to test consistently failing.

  • platform/gtk/test_expectations.txt:
07:47 Changeset [119102] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL] Enable CSS_IMAGE_SET flag
https://bugs.webkit.org/show_bug.cgi?id=87727

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-31
Reviewed by Adam Roben.

.:

Add CSS_IMAGE_SET flag to CMake and enable it by default on EFL port.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Fix CMakeLists.txt so that CSSImageSetValue.cpp gets compiled if
CSS_IMAGE_SET flag is enabled.

  • CMakeLists.txt:

LayoutTests:

Unskip test case associated to CSS image-set functionality now that it
is enabled by default on EFL port.

  • platform/efl/test_expectations.txt:
07:44 Changeset [119101] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Added FAIL expectation for GTK due to missing feature in DRT.

  • platform/gtk/test_expectations.txt:
07:32 Changeset [119100] by commit-queue@webkit.org
  • 6 edits in trunk

the imageSmoothingEnabled flag needs to be in the state object
https://bugs.webkit.org/show_bug.cgi?id=87853

Patch by Keyar Hood <keyar@chromium.org> on 2012-05-31
Reviewed by Darin Adler.

Source/WebCore:

Updated fast/canvas/canvas-imageSmoothingEnabled.html instead of
adding a new test.

The imageSmoothingEnabled flag is saved in the draw state now.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::webkitImageSmoothingEnabled):
(WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled):

  • html/canvas/CanvasRenderingContext2D.h:

(State):

LayoutTests:

Updated the test for imageSmoothingEnabled to test that it is saved in
the draw state.

  • fast/canvas/canvas-imageSmoothingEnabled-expected.txt:
  • fast/canvas/script-tests/canvas-imageSmoothingEnabled.js:
07:08 Changeset [119099] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Fix checkbox position on Settings screen.
https://bugs.webkit.org/show_bug.cgi?id=87007

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-31
Reviewed by Yury Semikhatsky.

Checkbox seems to be improperly aligned.
It is "shifted" up on 1px on Mac and 2px on Linux.
Also, keyboard-shortcuts screen has "wrapped" key descriptions on Mac.

UI changes, no new tests.

  • inspector/front-end/helpScreen.css:

(.help-container): Fixed column width.
(.help-block): Ditto.
(.help-key-cell): Ditto.
(body.platform-mac .help-container): Ditto.
(body.platform-mac .help-block): Ditto.
(body.platform-mac .help-key-cell): Ditto.
(.help-content p): Ajdusted spacing between lines
(.help-content input[type=checkbox]): Fixed alignment.
(body.platform-mac .help-content input[type=checkbox]): Ditto.
(.help-content input[type=radio]): Fixed alignment.
(body.platform-mac .help-content input[type=radio]): Ditto.

07:00 Changeset [119098] by vestbo@webkit.org
  • 53 edits in trunk

[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
https://bugs.webkit.org/show_bug.cgi?id=87955

Reviewed by Simon Hausmann.

Source/WebCore:

  • bridge/qt/qt_class.cpp:
  • bridge/qt/qt_instance.cpp:
  • bridge/qt/qt_runtime.h:
  • page/qt/EventHandlerQt.cpp:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/OpenGLShims.cpp:
  • platform/graphics/OpenGLShims.h:
  • platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/SimpleFontDataQt.cpp:
  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:
  • platform/qt/DeviceMotionProviderQt.h:
  • platform/qt/DeviceOrientationProviderQt.h:
  • platform/qt/KURLQt.cpp:
  • platform/qt/PlatformScreenQt.cpp:
  • platform/qt/QWebPageClient.h:
  • plugins/qt/PluginPackageQt.cpp:
  • plugins/qt/PluginViewQt.cpp:

Source/WebKit/qt:

  • Api/qgraphicswebview.cpp:
  • Api/qgraphicswebview.h:
  • Api/qwebframe.cpp:
  • Api/qwebframe_p.h:
  • Api/qwebpage.cpp:
  • Api/qwebpage.h:
  • Api/qwebsettings.cpp:
  • Api/qwebview.cpp:
  • Api/qwebview.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:
  • WebCoreSupport/GeolocationClientQt.cpp:
  • WebCoreSupport/GeolocationClientQt.h:
  • WebCoreSupport/PageClientQt.cpp:
  • WebCoreSupport/WebEventConversion.cpp:
  • declarative/plugin.cpp:
  • tests/qwebframe/tst_qwebframe.cpp:
  • tests/util.h:

Source/WebKit2:

  • UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:

Source/WTF:

  • wtf/qt/UtilsQt.h:

Tools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  • DumpRenderTree/qt/EventSenderQt.cpp:
  • DumpRenderTree/qt/QtInitializeTestFonts.cpp:
  • DumpRenderTree/qt/main.cpp:
  • QtTestBrowser/cookiejar.cpp:
  • QtTestBrowser/launcherwindow.cpp:
  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
  • qmake/mkspecs/features/default_post.prf:
06:38 Changeset [119097] by kling@webkit.org
  • 5 edits in trunk/Source/WebCore

Have StylePropertySet constructor take array/length instead of vector.
<http://webkit.org/b/87876>

Reviewed by Antti Koivisto.

Remove the StylePropertyVector typedef and have StylePropertySet constructors
take CSSProperty*/length since we are copying the data into a tightly packed
array anyway. This frees up the call sites to use whatever storage they please
rather than being restricted to a vector with inlineCapacity=4.

Change said call sites to use an arbitrary high inline capacity (256) for their
stack-allocated temporary vectors.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSParser.cpp:

(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::create):
(StylePropertySet):

06:24 Changeset [119096] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r118989
https://bugs.webkit.org/show_bug.cgi?id=87958

Unreviewed gardening.

fast/css/font-face-download-error.html is skipped as bug85977 is not fixed yet.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

  • platform/efl/test_expectations.txt:
06:07 Changeset [119095] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible() calls.
https://bugs.webkit.org/show_bug.cgi?id=87936

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-31
Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::viewportAttributesChanged):
(WebKit::QtViewportInteractionEngine::pageContentsSizeChanged):

05:41 Changeset [119094] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fixing compilation with SVG disabled.
https://bugs.webkit.org/show_bug.cgi?id=87944

This patch adds the missing enumeration value
'CSSPropertyWebkitBoxDecorationBreak' into switch statements to make
clang happy.

Patch by Mike West <mkwst@chromium.org> on 2012-05-31
Reviewed by Alexis Menard.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

05:33 Changeset [119093] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update Mac Leopard baselines for fast/muticol/span/span-as-immediate-columns-child.html.

  • platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.png:
05:30 Changeset [119092] by commit-queue@webkit.org
  • 1 edit
    10 adds in trunk/Source/WebKit2

[EFL][WK2] Add WKURLRequestEfl and WKURLResponseEfl
https://bugs.webkit.org/show_bug.cgi?id=70231

Patch by Keunsoon Lee <keunsoon.lee@samsung.com> on 2012-05-31
Reviewed by Chang Shu.

These codes can be used for WKPageDecidePolicyForResponseCallback on page policy callbacks.
The callback conveys WKURLResponseRef and WKURLRequestRef as parameter.

By the way, EFL browser needs content type from response to decide correct policy.
Another information, cookie, is necessary with similar reason.
But, there is no way to obtain such information on WebKit2 main stream, except for WKURLRequestCopyURL().

So, EFL port created those files to extract necessary information from WKURLResponseRef and WKURLRequestRef,
and not to desturb WebKit2 main stream.

  • Shared/API/c/efl/WKURLRequestEfl.cpp: Added.

(WKURLRequestEflCopyCookies): extracting cookie information from WKURLRequestRef.

  • Shared/API/c/efl/WKURLRequestEfl.h: Added.
  • Shared/API/c/efl/WKURLResponseEfl.cpp: Added.

(WKURLResponseEflCopyContentType): extracting content type (i.e. MIME type) from WKURLResponseRef.

  • Shared/API/c/efl/WKURLResponseEfl.h: Added.
  • Shared/efl/WebCoreArgumentCodersEfl.cpp: Added.

(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/efl/WebURLRequestEfl.cpp: Added.

(WebKit):
(WebKit::WebURLRequestEfl::WebURLRequestEfl):
(WebKit::WebURLRequestEfl::cookies): obtaining cookie information from ResourceRequest.

  • Shared/efl/WebURLRequestEfl.h: Added.

(WebKit):
(WebURLRequestEfl):
(WebKit::WebURLRequestEfl::create):

  • Shared/efl/WebURLResponseEfl.cpp: Added.

(WebKit):
(WebKit::WebURLResponseEfl::WebURLResponseEfl):
(WebKit::WebURLResponseEfl::contentType): obtaining content type (i.e. MIME type) from ResourceResponse.

  • Shared/efl/WebURLResponseEfl.h: Added.

(WebKit):
(WebURLResponseEfl):
(WebKit::WebURLResponseEfl::create):

05:06 Changeset [119091] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests, unskip a now passing test.

  • platform/qt/Skipped:
04:57 Changeset [119090] by mario@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

Unreviewed. Added new baselines for GTK after r117815.

  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Updated.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
04:57 Changeset [119089] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. Added new baselines for GTK after r118891.

  • platform/gtk/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/gtk/fast/forms/select/optgroup-rendering-expected.txt: Added.
04:54 Changeset [119088] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

[Platform] Implementation of Decimal(int32_t) isn't portable.
https://bugs.webkit.org/show_bug.cgi?id=87941

Reviewed by Kent Tamura.

This patch changes negation of integer to make unsigned integer
in portable way.

No new tests. This patch doesn't change behavior.

  • platform/Decimal.cpp:

(WebCore::Decimal::Decimal): Use uint64_t(-int64_t(i32)) instead of uint64_t(-i32)

04:48 Changeset [119087] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

fast/events/message-port-multi.html needs new baseline after r119027
https://bugs.webkit.org/show_bug.cgi?id=87949

Unreviewed gardening.

Update baseline for fast/events/message-port-multi.html after r119027.
Now all the checks are passing and we can get rid of the FAIL lines in
the expected result.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-31

  • fast/events/message-port-multi-expected.txt:
04:35 Changeset [119086] by gyuyoung.kim@samsung.com
  • 3 edits
    1 move in trunk/Source/WebKit2

[EFL][WK2] Rename ewk_private.h to ewk_view_private.h
https://bugs.webkit.org/show_bug.cgi?id=87923

Reviewed by Kenneth Rohde Christiansen.

EFL WK1 decided to divide up ewk_private.h into each file's XXX_private.h file in order to maintain
internal functions more easily. EFL WK2 needs to adjust this as well.

  • UIProcess/API/efl/PageClientImpl.cpp:
  • UIProcess/API/efl/ewk_view_private.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_private.h.

(WebCore):

  • UIProcess/cairo/BackingStoreCairo.cpp:
04:28 Changeset [119085] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint
https://bugs.webkit.org/show_bug.cgi?id=87871

Reviewed by Yury Semikhatsky.

When input events handling is suppressed (due to the JS being paused on a breakpoint), we should report
these events as NOT handled by the WebKit, so that the browser can handle them appropriately
(on MacOS, switching between the application windows is done through the default key event handler, so if you run
event.preventDefault() for all keydown events in a handler, the Chromium window switch will not occur on Cmd+`).

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

04:22 Changeset [119084] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r118993
https://bugs.webkit.org/show_bug.cgi?id=87946

Unreviewed gardening.

Test fast/forms/file/input-file-write-files.html that was added at r118993 relies on
unsupported EventSender.beginDragWithFiles and hence should be skipped.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

  • platform/efl/test_expectations.txt:
04:14 Changeset [119083] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Unskipping tests for GTK now passing in all the bots.

  • platform/gtk/test_expectations.txt:
03:42 Changeset [119082] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

fast/dom/Window/mozilla-focus-blur.html failing after r118916
https://bugs.webkit.org/show_bug.cgi?id=87951

Unreviewed. Added FAIL expectation for GTK after r118916.

  • platform/gtk/test_expectations.txt:
03:10 Changeset [119081] by abecsi@webkit.org
  • 7 edits in trunk/LayoutTests

Test expectation pngs missing checksums
https://bugs.webkit.org/show_bug.cgi?id=87947

Reviewed by Ojan Vafai.

Add proper platform independent png expectation with checksum and revert chromium
expectations since layoutTestController.keepWebHistory() seems to have no effect
on chromium, and the test is still failing (See bug 87839).

  • http/tests/misc/acid3-expected.png: Add png with embedded checksum.
  • platform/chromium-mac-leopard/http/tests/misc/acid3-expected.png: Revert to prior r118566.
  • platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png: Revert to prior r118566.
  • platform/chromium-mac/http/tests/misc/acid3-expected.png: Revert to prior r118566.
  • platform/chromium-mac/http/tests/misc/acid3-expected.txt: Revert to prior r118566.
  • platform/chromium/test_expectations.txt: Revert to prior r118566.
03:02 Changeset [119080] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source

Source/WebCore: [CMAKE][EFL] Remove unneeded include path
https://bugs.webkit.org/show_bug.cgi?id=87927

Reviewed by Kenneth Rohde Christiansen.

Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including the previous
path. In addition, files on EFL port are using "<wtf/gobject/XXX>" directly in #include line.
So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.

  • PlatformEfl.cmake: Remove '${JAVASCRIPTCORE_DIR}/wtf/gobject' path from include path list.

Source/WebKit: [CMAKE][EFL] Remove unneeded include path
https://bugs.webkit.org/show_bug.cgi?id=87927

Reviewed by Kenneth Rohde Christiansen.

Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including the previous
path. In addition, files on EFL port are using <wtf/gobject/XXX> directly in #include line.
So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.

  • PlatformEfl.cmake: Remove '${JAVASCRIPTCORE_DIR}/wtf/gobject' path from include path list.
02:50 Changeset [119079] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
02:47 Changeset [119078] by zoltan@webkit.org
  • 2 edits in trunk/Tools

[Qt] Don't enforce the version of libpng for the config test when passing the option to the linker

Rubber-stamped by Kenneth Rohde Christiansen.

  • qmake/config.tests/libpng/libpng.pro:
02:22 Changeset [119077] by peter@chromium.org
  • 5 edits in trunk

[Chromium] Automatically install 64-bit linker for Android
https://bugs.webkit.org/show_bug.cgi?id=79780

Reviewed by Adam Barth.

Source/WebKit/chromium:

Change the Android-specific dependencies to inherit their revision from
Chromium's DEPS file, like many other dependencies do, solving the
versioning problem that we're running in to right now. These are listed
in Chromium's main DEPS file starting Chromium r139529.

  • DEPS:

Tools:

Change the update-webkit-chromium script to check whether the 64-bit
linker needs to be installed as part of the update process. The actual
code for doing these checks and "installing" it has been added to the
webkitdirs.pm script.

The linker itself is part of the third_party/aosp repository, which
will be pulled in through the DEPS change.

  • Scripts/update-webkit-chromium:
  • Scripts/webkitdirs.pm:

(chromiumInstall64BitAndroidLinkerIfNeeded):
(chromiumReplaceAndroidLinkerIfNeeded):

02:02 Changeset [119076] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r118957
https://bugs.webkit.org/show_bug.cgi?id=87937

Unreviewed gardening.

compositing/layer-creation/fixed-position-and-transform.html and compositing/layer-creation/fixed-position-under-transform.html
added with r118957 were skipped in EFL port as EFL's LayoutTestController does not implement layerTreeAsText.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

  • platform/efl/test_expectations.txt:
01:55 Changeset [119075] by yosin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Build fix for Chromium Linux (Tests) after r119073.

  • tests/DecimalTest.cpp:

(TEST_F):

01:42 Changeset [119074] by kkristof@inf.u-szeged.hu
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase xss test, skip failing tests.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-31

  • platform/qt/Skipped:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
01:28 Changeset [119073] by yosin@chromium.org
  • 9 edits
    3 adds in trunk/Source

[Platform] Introduce Decimal class for Number/Range input type.
https://bugs.webkit.org/show_bug.cgi?id=87360

Reviewed by Kent Tamura.

Source/WebCore:

This patch added new class Decimal for decimal arithmatic in two
files: platform/Decimal.cpp and Decimal.h with unit test.

Test: WebKit/chromium/tests/DecimalTest.cpp

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/Decimal.cpp: Added.

(WebCore):
(DecimalPrivate):
(SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::handle):
(WebCore::DecimalPrivate::SpecialValueHandler::value):
(UInt128):
(WebCore::DecimalPrivate::UInt128::UInt128):
(WebCore::DecimalPrivate::UInt128::high):
(WebCore::DecimalPrivate::UInt128::low):
(WebCore::DecimalPrivate::UInt128::multiply):
(WebCore::DecimalPrivate::UInt128::highUInt32):
(WebCore::DecimalPrivate::UInt128::lowUInt32):
(WebCore::DecimalPrivate::UInt128::isZero):
(WebCore::DecimalPrivate::UInt128::makeUInt64):
(WebCore::DecimalPrivate::UInt128::operator/=):
(WebCore::DecimalPrivate::UInt128::multiplyHigh):
(WebCore::DecimalPrivate::countDigits):
(WebCore::DecimalPrivate::scaleDown):
(WebCore::DecimalPrivate::scaleUp):
(WebCore::Decimal::EncodedData::EncodedData):
(WebCore::Decimal::EncodedData::operator==):
(WebCore::Decimal::Decimal):
(WebCore::Decimal::operator=):
(WebCore::Decimal::operator+=):
(WebCore::Decimal::operator-=):
(WebCore::Decimal::operator*=):
(WebCore::Decimal::operator/=):
(WebCore::Decimal::operator-):
(WebCore::Decimal::operator+):
(WebCore::Decimal::operator*):
(WebCore::Decimal::operator/):
(WebCore::Decimal::operator==):
(WebCore::Decimal::operator!=):
(WebCore::Decimal::operator<):
(WebCore::Decimal::operator<=):
(WebCore::Decimal::operator>):
(WebCore::Decimal::operator>=):
(WebCore::Decimal::abs):
(WebCore::Decimal::alignOperands):
(WebCore::Decimal::ceiling):
(WebCore::Decimal::compareTo):
(WebCore::Decimal::floor):
(WebCore::Decimal::fromString):
(WebCore::Decimal::infinity):
(WebCore::Decimal::nan):
(WebCore::Decimal::remainder):
(WebCore::Decimal::round):
(WebCore::Decimal::toString):
(WebCore::Decimal::zero):

  • platform/Decimal.h: Added.

(WebCore):
(DecimalPrivate):
(Decimal):
(EncodedData):
(WebCore::Decimal::EncodedData::operator!=):
(WebCore::Decimal::EncodedData::coefficient):
(WebCore::Decimal::EncodedData::exponent):
(WebCore::Decimal::EncodedData::isFinite):
(WebCore::Decimal::EncodedData::isNaN):
(WebCore::Decimal::EncodedData::isSpecial):
(WebCore::Decimal::EncodedData::isZero):
(WebCore::Decimal::EncodedData::sign):
(WebCore::Decimal::EncodedData::setSign):
(WebCore::Decimal::EncodedData::formatClass):
(WebCore::Decimal::isFinite):
(WebCore::Decimal::isNaN):
(WebCore::Decimal::isNegative):
(WebCore::Decimal::isPositive):
(WebCore::Decimal::isSpecial):
(WebCore::Decimal::isZero):
(WebCore::Decimal::value):
(AlignedOperands):
(WebCore::Decimal::invertSign):
(WebCore::Decimal::exponent):
(WebCore::Decimal::sign):

Source/WebKit/chromium:

This patch added unit test for Decimal class.

  • WebKit.gypi:
  • tests/DecimalTest.cpp: Added.

(WebCore):
(WebCore::operator<<): Output Decimal for unit test debugging
(DecimalStepRange):
(DecimalStepRange::DecimalStepRange):
(DecimalStepRange::clampValue):
(DecimalTest):
(DecimalTest::encode):
(DecimalTest::fromString):
(DecimalTest::stepDown):
(DecimalTest::stepUp):
(TEST_F):

01:22 Changeset [119072] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][DRT] Gardening after r118920
https://bugs.webkit.org/show_bug.cgi?id=87934

Unreviewed, gardening of http/tests/local/fileapi/file-last-modified-after-delete.html which
relies on unsupported drag'n'drop feature.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

  • platform/efl/test_expectations.txt:
01:05 Changeset [119071] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Web Inspector: Retainers are missing for all objects
https://bugs.webkit.org/show_bug.cgi?id=87655

Skip the test on wincairo platform.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-31
Reviewed by Yury Semikhatsky.

  • platform/wincairo/Skipped:
01:00 Changeset [119070] by haraken@chromium.org
  • 22 edits in trunk/Source/WebCore

[V8] Pass Isolate to v8String() in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=87825

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8String() in custom bindings.

No tests. No change in behavior.

  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp:

(WebCore::installFastSet):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::V8CSSStyleDeclaration::namedPropertyEnumerator):
(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toV8Object):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):

  • bindings/v8/custom/V8DOMStringMapCustom.cpp:

(WebCore::V8DOMStringMap::namedPropertyGetter):
(WebCore::V8DOMStringMap::namedPropertyEnumerator):

  • bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAccessorGetter):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::toDataURLCallback):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::toV8Object):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8IDBKeyCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::databaseIdCallback):
(WebCore::V8InjectedScriptHost::storageIdCallback):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::V8InspectorFrontendHost::platformCallback):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::typeAccessorGetter):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::toStringCallback):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/custom/V8StorageCustom.cpp:

(WebCore::V8Storage::namedPropertyEnumerator):
(WebCore::storageGetter):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):

  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:

(WebCore::V8XSLTProcessor::getParameterCallback):

00:55 Changeset [119069] by hayato@chromium.org
  • 5 edits in trunk

ComposedShadowTreeWalker should support traversing nodes in an orphaned shadow subtree.
https://bugs.webkit.org/show_bug.cgi?id=87493

Reviewed by Dimitri Glazkov.

Source/WebCore:

ComposedShadowTreeWalker assumed that a visited shadow root is
always assigned to a shadow insertion point since it only
traverses nodes which are rendered. But there is an exceptional
use case such as an event dispatching. Some events, such as a
'click' event, may happen in an orphaned shadow subtree. In such
cases, traversal might start with a node in an orphaned shadow
subtree. So ComposedShadowTreeWalker can not assume that visited
shadow root is always assigned to a shadow insertion point.

This patch only fixes ComposedShadowTreeWalker.
ComposedShadowTreeParentWalker will be fixed in another patch with
an event dispatching test.

Test: fast/dom/shadow/composed-shadow-tree-walker.html

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):

LayoutTests:

  • fast/dom/shadow/composed-shadow-tree-walker.html:
00:33 Changeset [119068] by yurys@chromium.org
  • 10 edits in trunk/Source

Web Inspector: add MemoryUsageSupport::processMemorySizesInBytes
https://bugs.webkit.org/show_bug.cgi?id=87830

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/Platform.h:

(Platform):
(WebKit::Platform::processMemorySizesInBytes): moved this method from
Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h, also
removed 'get' prefix.

Source/WebCore:

Added a method for getting process memory usage in bytes. It is
used in the inspector memory instrumentation to get process total
memory usage.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • platform/MemoryUsageSupport.cpp:

(WebCore::MemoryUsageSupport::processMemorySizesInBytes):
(WebCore):

  • platform/MemoryUsageSupport.h:

(MemoryUsageSupport): provided embedders with a way to report WebKit process
memory usage.

  • platform/chromium/MemoryUsageSupportChromium.cpp:

(WebCore::MemoryUsageSupport::processMemorySizesInBytes):
(WebCore):

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h: pulled getProcessMemorySize up

to the Source/Platform/chromium/public/Platform.h

  • src/PlatformSupport.cpp:
00:22 Changeset [119067] by tkent@chromium.org
  • 9 edits
    3 deletes in trunk/Source

Unreviewed, rolling out r119062 and r119064.
http://trac.webkit.org/changeset/119062
http://trac.webkit.org/changeset/119064
https://bugs.webkit.org/show_bug.cgi?id=87360

Broke build on Lion, SnowLoepard, Chromium Windows, and
Chromium Linux 32

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/Decimal.cpp: Removed.
  • platform/Decimal.h: Removed.

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/DecimalTest.cpp: Removed.
00:18 Changeset [119066] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

Move the specification of framework and library linking out of WebKit2.xcodeproj and into WebKit2.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=87932

Reviewed by Dan Bernstein.

Doing this makes it easier to vary linking based on SDK or other factors.

  • Configurations/WebKit2.xcconfig: Create FRAMEWORK_AND_LIBRARY_LDFLAGS,

which specifies the same list of frameworks and libraries that were
previously in WebKit2's 'Link Binary With Libraries' build phase, and
append it to $(OTHER_LDFLAGS).

  • WebKit2.xcodeproj/project.pbxproj: Remove all frameworks and

libraries from the 'Link Binary With Libraries' build phase.

00:12 Changeset [119065] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

text-decoration should not be propagated through absolutely positioned elements to <a> tags
https://bugs.webkit.org/show_bug.cgi?id=86517

Source/WebCore:

Patch by Shane Stephens <shanestephens@google.com> on 2012-05-31
Reviewed by Darin Adler.

Test: fast/css/text-decoration-in-second-order-descendants.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):
Remove fix from 18611 as it doesn't work on second order descendants.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
Add floating and positioned checks when deciding whether to avoid propagating text decoration. Move all checks into new method to improve readability.
(WebCore::doesNotInheritTextDecoration): Added

LayoutTests:

Added layout test to check no propagation of text-decoration to second-order descendants
(i.e. descendants of descendants), where the first-order descendant is positioned.

Tightened up existing descendants test to fail when text-decoration is incorrectly propagated
to first-order descendant.

Patch by Shane Stephens <shanestephens@google.com> on 2012-05-31
Reviewed by Darin Adler.

  • fast/css/text-decoration-in-descendants-expected.html:
  • fast/css/text-decoration-in-second-order-descendants-expected.html: Added.
  • fast/css/text-decoration-in-second-order-descendants.html: Added.
Note: See TracTimeline for information about the timeline view.