Timeline


and

06/05/12:

23:53 Changeset [119565] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox
https://bugs.webkit.org/show_bug.cgi?id=88197

Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-05
Reviewed by Daniel Bates.

RenderSVGRoot extends RenderReplaced and it overrides the computeIntrinsicRatioInformation()
method of RenderReplaced. RenderSVGRoot::computeIntrinsicRatioInformation
sets isPercentageIntrinsicSize to true while it handles width and height of percentage types.
So this assertion should be fired only if intrinsicRatio is non-zero.

Source/WebCore:

Test: svg/in-html/svg-assert-failure-percentage.html

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeIntrinsicRatioInformationForRenderBox):

LayoutTests:

  • svg/in-html/svg-assert-failure-percentage-expected.txt: Added.
  • svg/in-html/svg-assert-failure-percentage.html: Added.
23:45 Changeset [119564] by tony@chromium.org
  • 3 edits
    2 adds in trunk

Changing flexbox justify/alignment doesn't update their positioning
https://bugs.webkit.org/show_bug.cgi?id=88366

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/style-change.html

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Since these member variables were moved
out of StyleFlexibleBoxData, we have to compare them in RenderStyle::diff.

LayoutTests:

  • css3/flexbox/style-change-expected.txt: Added.
  • css3/flexbox/style-change.html: Added.
22:51 Changeset [119563] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

JSC implementation of SerializedScriptValue for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=88048

Reviewed by George Staikos.

No new tests. All the current indexeddb test cases apply when indexeddb works for JSC.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serializeNumber):
(CloneSerializer):
(WebCore::CloneDeserializer::toWireString):
(CloneDeserializer):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::toWireString):
(WebCore):
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::deserialize):

22:41 Changeset [119562] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

Nested CSS flexbox renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=87679

Reviewed by Julien Chaffraix.

Source/WebCore:

If the containing block with a perpendicular writing mode has an overrideHeight,
then its logical height should be based off that instead of its RenderStyle.

Test: css3/flexbox/perpendicular-writing-modes-inside-flex-item.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):

LayoutTests:

  • css3/flexbox/perpendicular-writing-modes-inside-flex-item-expected.txt: Added.
  • css3/flexbox/perpendicular-writing-modes-inside-flex-item.html: Added.
22:37 Changeset [119561] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

Need special-case toJS(IDBAny) for IDBCursorWithValue
https://bugs.webkit.org/show_bug.cgi?id=87963

Reviewed by George Staikos.

No new tests, this is for indexedDB, which is not working for JSC binding.
When indexedDB working for JSC, all the indexdb test cases should apply.

  • bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS):

22:35 Changeset [119560] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140653 to r140700.

  • DEPS:
22:32 Changeset [119559] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Use Component.onCompleted in API tests for single and multi file upload tests.
https://bugs.webkit.org/show_bug.cgi?id=88247

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-05
Reviewed by Kenneth Rohde Christiansen.

With r116936, Component.onCompleted can be used for callback instead of the
1s timer in single and multi file upload tests.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml:
22:25 Changeset [119558] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Improve Math.round and Math.floor intrinsic
https://bugs.webkit.org/show_bug.cgi?id=88314

Reviewed by Filip Pizlo.

Currently we call a native function from the JIT code to complete the
"round" and "floor" operations. We could inline some fast paths
especially for those positive values on the platforms where floating
point truncation is supported.
This brings 3% gain on Kraken, especially 32% on audio-oscillator,
and slight win on SunSpider, measured on IA32.

  • jit/ThunkGenerators.cpp:

(JSC::floorThunkGenerator):
(JSC):
(JSC::roundThunkGenerator):

22:19 Changeset [119557] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] show the feature list in alphabetical order
https://bugs.webkit.org/show_bug.cgi?id=88343

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2012-06-05
Reviewed by Gustavo Noronha Silva.

  • configure.ac:
22:08 Changeset [119556] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove JSObject::m_inheritorID
https://bugs.webkit.org/show_bug.cgi?id=88378

Reviewed by Geoff Garen.

This is rarely used, and not performance critical (the commonly accessed copy is cached on JSFunction),
and most objects don't need an inheritorID (this value is only used if the object is used as a prototype).
Instead use a private named value in the object's property storage.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):

  • No need m_inheritorID to initialize!
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • No need m_inheritorID to initialize!
  • llint/LowLevelInterpreter.asm:
    • No need m_inheritorID to initialize!
  • runtime/JSGlobalData.h:

(JSGlobalData):

  • Added private name 'm_inheritorIDKey'.
  • runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::setUnwrappedObject):

  • resetInheritorID is now passed a JSGlobalData&.
  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):

  • No m_inheritorID to be marked.

(JSC::JSObject::createInheritorID):

  • Store the newly created inheritorID in the property map.
  • runtime/JSObject.h:

(JSC::JSObject::resetInheritorID):

  • Remove the inheritorID from property storage.

(JSC::JSObject::inheritorID):

  • Read the inheritorID from property storage.
22:01 ScalesAndZooms created by jamesr@google.com
21:58 Changeset [119555] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove erroneous expected image added in r119544.

  • platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.txt: Removed.
21:44 Changeset [119554] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Set default memory allocation limit bytes when GL_CHROMIUM_gpu_memory_manager is not supported by graphics context.
https://bugs.webkit.org/show_bug.cgi?id=87996

Patch by Michal Mocny <mmocny@google.com> on 2012-06-05
Reviewed by James Robinson.

Soon we hope to have renderers not manage there own memory allocation limits, and rely exclusively on the
allocation given by GpuMemoryManager. However, when the graphics context does not support the
GL_CHROMIUM_gpu_memory_manager extension, such as the one used by DumpRenderTree, we must default the
memory allocation limit to some non-0 value.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::postSetContentsMemoryAllocationLimitBytesToMainThreadOnImplThread):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore):
(DebugScopedSetMainThreadFromEither):
(WebCore::DebugScopedSetMainThreadFromEither::DebugScopedSetMainThreadFromEither):
(WebCore::DebugScopedSetMainThreadFromEither::~DebugScopedSetMainThreadFromEither):

20:44 Changeset [119553] by haraken@chromium.org
  • 5 edits
    1 delete in trunk/Source/WebKit/chromium

Unreviewed, rolling out r119494.
http://trac.webkit.org/changeset/119494
https://bugs.webkit.org/show_bug.cgi?id=87911

We found similar APIs are already implemented

  • public/WebWidget.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/WebViewTest.cpp:
  • tests/data/textarea.html: Removed.
20:04 Changeset [119552] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=78720

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-06-05
Reviewed by Noam Rosenthal.

Source/WebCore:

Functions are removed from GraphicsContext3DQt that already implemented
in GraphicsContext3DCommon. Macros that not supported at GLES have been
changed to their appropriate pair that found in GraphicsContext3D
(e.g. GL_FRAMEBUFFER_EXT to GraphicsContext3D::FRAMEBUFFER).
It was needed because OpenGLES does not support these macros.
Extensions3DQt is removed beceause it has never been used.
Some functions have been moved fron GraphicsContext3DCommon to *OpenGL
and *OpenGLES to provide specialization.
The "m_depthStencilBuffer" member is added to Qt port because it uses
"m_depthStencilBuffer" like the other platforms.

  • Target.pri:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::depthRange):
(WebCore):
(WebCore::GraphicsContext3D::clearDepth):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::readPixels):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::depthRange):
(WebCore):
(WebCore::GraphicsContext3D::clearDepth):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebuffer):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore):

Source/WTF:

Defined a global Opengl ES macro to check OpenGL ES on every platforms.

  • wtf/Platform.h:
19:41 Changeset [119551] by rniwa@webkit.org
  • 7 edits
    3 adds in trunk/LayoutTests

Chromium rebaselines after r115091.

  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/chromium/TestExpectations:
19:13 Changeset [119550] by rniwa@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

More Chromium rebaselines after r119528 and r119512.

  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-linux/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
18:57 Changeset [119549] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
https://bugs.webkit.org/show_bug.cgi?id=88342

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-05
Reviewed by Rob Buis.

RIM PR: 163141

Reviewed internally by Mike Fenton.

We set all options' type to TypeOption, which can't tell if an option belongs to a group,
introduce TypeOptionInGroup to fix it.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openSelectPopup):

18:51 Changeset [119548] by darin@apple.com
  • 4 edits in trunk/Source/WebCore

Special layout handler should be done on top frame being printed.
https://bugs.webkit.org/show_bug.cgi?id=88201

Patch by Vitaly Buka <vitalybuka@chromium.org> on 2012-06-05
Reviewed by Brady Eidson.

No new tests. Root case is already covered by tests.
Case described in the issue can be reproduced only by direct call
to Frame::setPrinting of subframe. Probably it's not possible with
layout tests.

  • page/Frame.cpp:

(WebCore::Frame::setPrinting):
Use shouldUsePrintingLayout to choose proper version of forceLayout().
(WebCore::Frame::shouldUsePrintingLayout):
Checks if current frame is the top frame being printed.

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldUsePrintingLayout): Forward to Frame.

18:40 Changeset [119547] by commit-queue@webkit.org
  • 36 edits
    5 adds in trunk

[BlackBerry] Conditionally enlarge HTML5 video controls in fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=87551

Patch by Max Feil <mfeil@rim.com> on 2012-06-05
Reviewed by Antonio Gomes.

Source/WebCore:

Changes to make media controls larger in fullscreen mode. The
BlackBerry media controls used to be sized by a combination
of CSS styles specified in mediaControlsBlackBerry.css and
hard coded constants in RenderThemeBlackBerry.cpp. This patch
moves all the dimensional sizes to a common location, i.e.
RenderThemeBlackBerry.cpp. Having all the logic in C++ code allows
more complex decision making for when and how much to enlarge the
media controls. Currently the controls are enlarged by a factor
of 2 if the document is in fullscreen mode, the video element
is the current fullscreen element, and the deviceScaleFactor of
the page is less than 2.0. This avoids overly large controls
on pages which are already at least doubling the size of the
controls via viewport meta tag device-width settings. In other
words, if the CSS pixels are already enlarged compared to device
pixels by a factor of at least 2 in length and width.

In order to accomplish this, I had to add a new Element* parameter
to RenderTheme::adjustSliderThumbSize(). This is needed so
that fullscreen mode can be checked and the deviceScaleFactor
retrieved. I feel that this does not have a big impact on the
code and the other ports, for which I will simply be adding the
additional parameter in their platform code.

Tests:
video-controls-enlarged-fullscreen-meta.html
video-controls-enlarged-fullscreen-nometa.html

  • css/mediaControlsBlackBerry.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderThumb::updateAppearance):

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore):
(WebCore::determineRenderSlider):
(WebCore::determineFullScreenMultiplier):
(WebCore::RenderThemeBlackBerry::adjustSliderThumbSize):
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::adjustSliderTrackStyle):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):

  • platform/blackberry/RenderThemeBlackBerry.h:

(RenderThemeBlackBerry):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustSliderThumbSize):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp:

(WebCore::RenderThemeGtk::adjustSliderThumbSize):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::adjustSliderThumbSize):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustSliderThumbSize):

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):

  • platform/qt/RenderThemeQtMobile.h:

(RenderThemeQtMobile):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):

  • rendering/RenderThemeChromiumLinux.h:

(RenderThemeChromiumLinux):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):

  • rendering/RenderThemeChromiumWin.h:

(RenderThemeChromiumWin):

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::adjustSliderThumbSize):

  • rendering/RenderThemeSafari.h:

(RenderThemeSafari):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::adjustSliderThumbSize):

  • rendering/RenderThemeWin.h:

(RenderThemeWin):

  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::adjustSliderThumbSize):

  • rendering/RenderThemeWinCE.h:

(RenderThemeWinCE):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustMediaControlStyle):
(WebCore):
(WebCore::RenderTheme::adjustSliderThumbStyle):
(WebCore::RenderTheme::adjustSliderThumbSize):

  • rendering/RenderTheme.h:

(RenderTheme):

Source/WebKit/qt:

Add a new parameter to adjustSliderThumbSize() for BlackBerry
port. Fixing compiles of other ports.

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • WebCoreSupport/RenderThemeQStyle.h:

(RenderThemeQStyle):

LayoutTests:

  • media/media-controls.js:

(mediaControlsButtonDimensions):

  • platform/blackberry/media/video-controls-enlarged-fullscreen-meta-expected.txt: Added.
  • platform/blackberry/media/video-controls-enlarged-fullscreen-meta.html: Added.
  • platform/blackberry/media/video-controls-enlarged-fullscreen-nometa-expected.txt: Added.
  • platform/blackberry/media/video-controls-enlarged-fullscreen-nometa.html: Added.
18:37 Changeset [119546] by slewis@apple.com
  • 6 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=88370
Memory sampler should trigger low memory signal

Reviewed by Geoff Garen.

Source/WebCore:

No new tests. Verify by running stress test which crashes
in a few minutes without the fix.

Fix assumption in block code. We could get in a state where timer_event_source
had already been released before the block ran.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::holdOff):

Source/WebKit2:

Send low memory signal when running the memory sampler. We'd
like to test memory that cannot be freed.

  • Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::sampleTimerFired):

  • Shared/WebMemorySampler.h:

(WebMemorySampler):

  • Shared/mac/WebMemorySampler.mac.mm:

(WebKit):
(WebKit::WebMemorySampler::sendMemoryPressureEvent):

18:10 Changeset [119545] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

Stop generating image results in the tests added by r114172.

Rubber-stamped by Simon Fraser.

  • css3/filters/huge-region-composited.html:
  • css3/filters/huge-region.html:
  • platform/chromium/TestExpectations:
18:01 Changeset [119544] by rniwa@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

Chromium rebaselines after r118772.

  • platform/chromium-mac-leopard/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.txt: Added.
  • platform/chromium-win/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-win/fast/forms/select/optgroup-rendering-expected.txt: Added.
  • platform/chromium/TestExpectations:
17:57 Changeset [119543] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Build fix.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::createPlugin):
The error constant has been renamed.

17:48 Changeset [119542] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Rename a plug-in loading error constant
https://bugs.webkit.org/show_bug.cgi?id=88381
<rdar://problem/11602601>

Reviewed by Sam Weinig.

  • Misc/WebKitErrors.h:
17:47 Changeset [119541] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Fixing an incorrect path in lion Skipped file.

  • platform/mac-lion/Skipped:
17:39 Changeset [119540] by yosin@chromium.org
  • 24 edits in trunk/Source/WebCore

[Forms] Introduce InputNumber type as an alias of double for replacing it to Decimal
https://bugs.webkit.org/show_bug.cgi?id=88275

Reviewed by Kent Tamura.

This patch introduced InputNumber type as alias of double to be
replaced to Decimal and convertDoubleToInputNumber and
convertToInputNumberToDouble for reducing size of patch when we
introduce Decimal type.

This patch added new vairables to use const variable to reduce
copy operation when introducing Decimal type.

In the implementation, we use InputNumber, will be Decimal, however some methods in IDL
use double. To clarify internal usage of value and external usage, thit patch renamed
following functions:

  • parseToDouble => parseNumber
  • setValueAsNumber => setValueAsDouble and setValueAsInputNumber
  • valueAsNumber => valueAsDouble

This patch is a part of introducing Decimal, https://bugs.webkit.org/show_bug.cgi?id=80009

No new tests. This patch doesn't change behavior.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::valueAsDate): Replaced parseToNumber() to valueAsDouble()
(WebCore::BaseDateAndTimeInputType::setValueAsDate): Inserted convertDoubleToInputNumber.
(WebCore::BaseDateAndTimeInputType::valueAsDouble): Use new function parseToDouble().
(WebCore::BaseDateAndTimeInputType::setValueAsInputNumber): Added.
(WebCore::BaseDateAndTimeInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::BaseDateAndTimeInputType::parseToNumber): This is replacement of parseToDouble().
(WebCore::BaseDateAndTimeInputType::parseToDouble): Added for valueAsDate and valueAsDouble.
(WebCore::BaseDateAndTimeInputType::serialize): Changed parameter type to InputNumber.
(WebCore::BaseDateAndTimeInputType::serializeWithComponents): Replace double to InputNumber for getAllowdStep.

  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType):

  • html/DateInputType.cpp:

(WebCore::DateInputType::createStepRange): Replaced double to InputNumber.

  • html/DateInputType.h:

(DateInputType):

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::DateTimeInputType::createStepRange): Replaced double to InputNumber.

  • html/DateTimeInputType.h:

(DateTimeInputType):

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::createStepRange): Replaced double to InputNumber.

  • html/DateTimeLocalInputType.h:

(DateTimeLocalInputType):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::getAllowedValueStep): Changed parameter type to InputNumber.
(WebCore::HTMLInputElement::valueAsNumber): Use InputType::valueAsDouble.
(WebCore::HTMLInputElement::setValueAsNumber): Use InputType::valueAsDouble.

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::valueAsDouble): Replacement of valueAsNumber.
(WebCore::InputType::setValueAsDouble): Replacement of valueAsNumber.
(WebCore::InputType::setValueAsInputNumber): Replacement of valueAsNumber.
(WebCore::InputType::rangeUnderflow): Replaced double to InputNumber.
(WebCore::InputType::rangeOverflow): Replaced double to InputNumber.
(WebCore::InputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::InputType::isInRange): Replaced double to InputNumber.
(WebCore::InputType::isOutOfRange): Replaced double to InputNumber.
(WebCore::InputType::stepMismatch): Replaced double to InputNumber.
(WebCore::InputType::validationMessage): Replaced double to InputNumber.
(WebCore::InputType::parseToNumber): Replacement of parseToDouble.
(WebCore::InputType::parseToNumberOrNaN): Added for reducing number of std::numeric_limits<double>::quiet_NaN().
(WebCore::InputType::parseToNumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::InputType::serialize): Changed parameter type to InputNumber.
(WebCore::InputType::applyStep): Replaced double to InputNumber.
(WebCore::InputType::getAllowedValueStep): Changed parameter type to InputNumber.
(WebCore::InputType::stepUpFromRenderer): Replaced double to InputNumber.

  • html/InputType.h:

(InputType):

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::MonthInputType::createStepRange): Replaced double to InputNumber.
(WebCore::MonthInputType::parseToNumber): Replacement of parseToDouble.

  • html/MonthInputType.h:

(MonthInputType):

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::valueAsDouble): Replacement of valueAsNumber. Changed to use parseToDoubleForNumberType.
(WebCore::NumberInputType::setValueAsDouble): Replacement of setValueAsNumber. Changed to use serializeForNumberType.
(WebCore::NumberInputType::setValueAsInputNumber): Replacement of setValueAsNumber.
(WebCore::NumberInputType::createStepRange): Replaced double to InputNumber.
(WebCore::NumberInputType::parseToNumber): Replacement of parseToDouble.
(WebCore::NumberInputType::parseToNumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::NumberInputType::serialize):

  • html/NumberInputType.h:

(NumberInputType):

  • html/RangeInputType.cpp:

(WebCore::ensureMaximum): Replaced double to InputNumber.
(WebCore::RangeInputType::valueAsDouble): Replacement of valueAsNumber.
(WebCore::RangeInputType::setValueAsInputNumber): Replacement of setValueAsNumber.
(WebCore::RangeInputType::createStepRange): Replaced double to InputNumber.
(WebCore::RangeInputType::handleKeydownEvent): Replaced double to InputNumber.
(WebCore::RangeInputType::parseToNumber): Replacement of parseToDouble.
(WebCore::RangeInputType::serialize): Changed parameter type to InputNumber.
(WebCore::RangeInputType::sanitizeValue): Replaced double to InputNumber.

  • html/RangeInputType.h:

(RangeInputType):

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange): Replaced double to InputNumber.
(WebCore::StepRange::acceptableError): Replaced double to InputNumber.
(WebCore::StepRange::alignValueForStep): Replaced double to InputNumber.
(WebCore):
(WebCore::StepRange::clampValue): Replaced double to InputNumber.
(WebCore::StepRange::stepMismatch): Replaced double to InputNumber.

  • html/StepRange.h:

(WebCore::convertDoubleToInputNumber): Added.
(WebCore::convertInputNumberToDouble): Added.
(WebCore::StepRange::NumberWithDecimalPlaces::NumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::StepRange::StepDescription::defaultValue): Replaced double to InputNumber.
(StepRange):
(WebCore::StepRange::maximum): Replaced double to InputNumber.
(WebCore::StepRange::minimum): Replaced double to InputNumber.
(WebCore::StepRange::step): Replaced double to InputNumber.
(WebCore::StepRange::stepBase): Replaced double to InputNumber.
(WebCore::StepRange::defaultValue): Replaced double to InputNumber.
(WebCore::StepRange::proportionFromValue): Replaced double to InputNumber.
(WebCore::StepRange::valueFromProportion): Replaced double to InputNumber.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::defaultValueForStepUp): Replaced double to InputNumber.
(WebCore::TimeInputType::createStepRange): Replaced double to InputNumber.

  • html/TimeInputType.h:

(TimeInputType):

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::createStepRange): Replaced double to InputNumber.

  • html/WeekInputType.h:

(WeekInputType):

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::writeDocument): Replaced double to InputNumber.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderPosition): Replaced double to InputNumber.
(WebCore::RenderSliderThumb::layout): Replaced double to InputNumber.
(WebCore::SliderThumbElement::setPositionFromPoint): Replaced double to InputNumber.

17:38 Changeset [119539] by eae@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed gardening. Chromium windows test expectation updates.

  • platform/chromium-win/fast/sub-pixel: Added.
  • platform/chromium-win/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • platform/chromium/TestExpectations:
17:32 Changeset [119538] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140528 to r140653.

  • DEPS:
17:31 Changeset [119537] by leviw@chromium.org
  • 37 edits
    18 adds in trunk/LayoutTests

Unreviewed gardening. More updated Chromium test expectations following 119528.

  • platform/chromium-linux-x86/editing/selection: Added.
  • platform/chromium-linux-x86/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/3690703-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/3690719-expected.png: Added.
  • platform/chromium-linux-x86/fast/sub-pixel: Added.
  • platform/chromium-linux-x86/fast/sub-pixel/selection: Added.
  • platform/chromium-linux-x86/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-linux/fast/sub-pixel: Added.
  • platform/chromium-linux/fast/sub-pixel/selection: Added.
  • platform/chromium-linux/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac/fast/sub-pixel/selection: Added.
  • platform/chromium-mac/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-win-vista/fast/sub-pixel: Added.
  • platform/chromium-win-vista/fast/sub-pixel/selection: Added.
  • platform/chromium-win-vista/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-win/editing/selection/3690703-2-expected.png:
  • platform/chromium-win/editing/selection/3690703-expected.png:
  • platform/chromium-win/editing/selection/3690719-expected.png:
  • platform/chromium-win/fast/sub-pixel: Added.
  • platform/chromium-win/fast/sub-pixel/selection: Added.
  • platform/chromium-win/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium/TestExpectations:
17:25 Changeset [119536] by rniwa@webkit.org
  • 4 edits
    4 adds
    1 delete in trunk/LayoutTests

Chromium rebaselines for r119523 and r119529.

  • platform/chromium-linux/compositing/layer-creation: Removed.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/chromium-win/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
  • platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
17:15 Changeset [119535] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/11575898> and https://bugs.webkit.org/show_bug.cgi?id=88372
REGRESSION(110494): Can no longer drag-and-drop links into FileMaker Pro 12

  • Before r110494 we used to write the NSStringPboardType to the pasteboard. After r110494 we write NSURLPboardType instead. That's basically a no-op, but the NSStringPboardType needs to be restored.
  • Before r110494 we wrote the link destination URL to the pasteboard. After r110494 we write the image src URL if the link is an image. We need to revert to writing the link URL.

Fortunately these changes can be accomplished with a 2-line fix.

Reviewed by Enrica Casucci.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
n

17:05 Changeset [119534] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r119527.

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):

16:12 Changeset [119533] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Cairo] [OpenGL] Enable GL_OES_standard_derivatives
https://bugs.webkit.org/show_bug.cgi?id=87583

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-05
Reviewed by Alejandro G. Castro.

No new tests. This is covered by oes-standard-derivatives.html
in the Khronos WebGL conformance tests, which may one day be part
of the WebKit test suite.

Activate the GL_OES_standard_derivatives on Cairo along with
Qt and Mac.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):

15:45 Changeset [119532] by jonlee@apple.com
  • 2 edits in trunk/Tools

Buildbot fix.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier

in the function. Store in a local variable.
(loadBuilderConfig):

15:28 Changeset [119531] by leviw@chromium.org
  • 3 edits in trunk/LayoutTests

Fixing two leopard-specific baselines following r119528.

  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
15:19 Changeset [119530] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectations.

  • platform/chromium/TestExpectations:
15:18 Changeset [119529] by simon.fraser@apple.com
  • 8 edits
    1 copy
    1 add in trunk

Avoid creating compositing layers for preserve-3d without transformed descendants
https://bugs.webkit.org/show_bug.cgi?id=88115

Source/WebCore:

Reviewed by Antti Koivisto.

Avoid creating compositing layers, and therefore using excess backing store,
for elements that have -webkit-transform-style: preserve-3d, but no 3D-transformed
descendants that would be affected by that preserve-3d.

Test: compositing/layer-creation/no-compositing-for-preserve-3d.html

  • rendering/RenderLayer.h: Replace the "mustOverlap" flag with a enum

that describes the different reasons for indirect compositing, so that
we can use that information to decide whether to allocate backing store.
(WebCore::RenderLayer::setIndirectCompositingReason):
(WebCore::RenderLayer::indirectCompositingReason):
(WebCore::RenderLayer::mustCompositeForIndirectReasons):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer): Initialize m_indirectCompositingReason

  • rendering/RenderLayerCompositor.h: New out param for computeCompositingRequirements()

that is uses to indicate that a 3d-transformed descendant has been encountered.
Rename requiresCompositingWhenDescendantsAreCompositing() to requiresCompositingForIndirectReason(),
and return the reason as an out param.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers): Pass in the saw3DTransform
param to computeCompositingRequirements().
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Return a flag
from computeCompositingRequirements() that is set to true if we've seen descendants
that have 3d transforms. This is later used to decide whether to composite for
perspective or preserve-3d.
Change the "mustOverlapCompositedLayers" code to use the new "indirect compositing"
enum flags.
After enumerating children, call requiresCompositingForIndirectReason() and
record the reason in the layer.
(WebCore::RenderLayerCompositor::needsToBeComposited): Use mustCompositeForIndirectReasons() now.
(WebCore::RenderLayerCompositor::requiresOwnBackingStore): Consult the indirect compositing
reason rather than just looking for the overlap flag.
(WebCore::RenderLayerCompositor::reasonForCompositing): Now that we have more information
about indirect compositing reasons, the logging can be more detailed.
(WebCore::RenderLayerCompositor::requiresCompositingForTransform): This now only looks
for 3d transforms. We now treat perspective and perserve-3d as "indirect" reasons, because
whether they composite depends on descendants having non-affine transforms.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): Includes the logic
previously in requiresCompositingWhenDescendantsAreCompositing(), and now determines
whether to composite for preserve-3d and perspective, based on whether we have transformed descendants.

LayoutTests:

Reviewed by Antti Koivisto.

  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/backing/no-backing-for-perspective.html: Change the transform to be non-affine so that

we keep making layers for perspective.

  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
  • compositing/layer-creation/no-compositing-for-preserve-3d.html: Copied from LayoutTests/compositing/backing/no-backing-for-perspective.html.
14:56 Changeset [119528] by leviw@chromium.org
  • 37 edits
    6 adds in trunk

Block selection gaps painted not properly pixel snapped
https://bugs.webkit.org/show_bug.cgi?id=88000

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixes for selection painting in both inline line heights and block gaps. We were unintentionally
flooring inline and block offsets in RenderBlock, but actually need to intentionally floor the
logical left and right values in logical(Left|Right)SelectionGap to properly align our block
selection gaps. This is to properly mirror the behavior in pixelSnappedLogicalRightOffsetForLine.

We were also unintentionally upcasting LayoutUnits to floats in InlineTextBox's selection painting
routine. Now we're properly rounding.

Test: fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintSelection): Move paint values to integers and do proper rounding.

  • rendering/RenderBlock.cpp:

(WebCore::blockDirectionOffset): Fix incorrect flooring in return value.
(WebCore::inlineDirectionOffset): Ditto.
(WebCore): Removing previous attempt to properly mirror inline box selection pixel alignment. This
implementation rounded the final x value instead of properly rounding our block offset then flooring
the offset that corresponds to the behavior in InlineTextBox. It also didn't properly pixel snap
the y offset and height.
(WebCore::RenderBlock::blockSelectionGap): Properly pixel snapping the gap rect before painting.
(WebCore::RenderBlock::logicalLeftSelectionGap): Correctly match InlineTextBox's selection pixel
alignment by flooring the logicalLeft and pixel snapping the subsequent rect. We do this in order
to maintain proper render tree pixel snapping while simultaneously mirroring the flooring in the
inline direction that occurs in InlineTextBox.cpp's alignSelectionRectToDevicePixels method.
(WebCore::RenderBlock::logicalRightSelectionGap): Ditto with the right.

LayoutTests:

One new selection test and updated snowleopard expectations for a handful that improved.

Note: a couple of the RTL results appear worse, but sadly are only returning to our old pre-sub-pixel results.

  • fast/sub-pixel/selection: Added.
  • fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Added.
  • fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac-snowleopard/fast/sub-pixel: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/selection: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/gtk-wk2/Skipped:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
14:36 Changeset [119527] by abarth@webkit.org
  • 10 edits
    12 deletes in trunk

Remove support for target-densitydpi in the viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=88047

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The target-densitydpi parameter was originally implemented on Android,
but it does not appear to be widely used and introduces significant
implementation complexity because it forces us to track three scale
factors (defaultDeviceScaleFactor, deviceScaleFactor, and
pageScaleFactor) rather than just two (deviceScaleFactor and
pageScaleFactor).

There don't appear to be many web sites that use target-densitydpi
because it is not supported on iOS. There are also concerns from the
standards community about the design of the feature. It seems our best
course of action is to remove target-densitydpi and address these use
cases via other mechanisms, such as responsive images and device units
in CSS because those approaches are likely to be implemented broadly.

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):
(WebCore):
(WebCore::setViewportFeature):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):

  • dom/ViewportArguments.h:

(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

  • Api/WebViewportArguments.cpp:

(BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):

  • Api/WebViewportArguments.h:

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

LayoutTests:

These tests are no longer needed because they're testing a feature we
no longer support.

  • fast/viewport/viewport-133-expected.txt: Removed.
  • fast/viewport/viewport-133.html: Removed.
  • fast/viewport/viewport-92-expected.txt: Removed.
  • fast/viewport/viewport-92.html: Removed.
  • fast/viewport/viewport-93-expected.txt: Removed.
  • fast/viewport/viewport-93.html: Removed.
  • fast/viewport/viewport-94-expected.txt: Removed.
  • fast/viewport/viewport-94.html: Removed.
  • fast/viewport/viewport-95-expected.txt: Removed.
  • fast/viewport/viewport-95.html: Removed.
  • fast/viewport/viewport-96-expected.txt: Removed.
  • fast/viewport/viewport-96.html: Removed.
14:32 Changeset [119526] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFG simplification should not attempt to deref nodes inside of an unreachable subgraph
https://bugs.webkit.org/show_bug.cgi?id=88362

Reviewed by Gavin Barraclough.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::fixPhis):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):

14:31 Changeset [119525] by kerz@chromium.org
  • 6 edits
    2 deletes in branches/chromium/1132/Source

Revert 119486 - Merge 117978 - IndexedDB: Fire error when there are problems opening a DB
https://bugs.webkit.org/show_bug.cgi?id=85579

Source/WebCore:

We used to either fire success or get into an infinite loop.

Reviewed by Tony Chang.

New unit test in
Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::openConnection):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::create):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openInternal):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/IDBAbortOnCorruptTest.cpp: Added.

(WebCore):
(MockIDBCallbacks):
(WebCore::MockIDBCallbacks::MockIDBCallbacks):
(WebCore::MockIDBCallbacks::~MockIDBCallbacks):
(WebCore::MockIDBCallbacks::onError):
(WebCore::MockIDBCallbacks::onSuccess):
(WebCore::MockIDBCallbacks::onSuccessWithContinuation):
(WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
(WebCore::MockIDBCallbacks::onBlocked):
(FailingBackingStore):
(WebCore::FailingBackingStore::~FailingBackingStore):
(WebCore::FailingBackingStore::open):
(WebCore::FailingBackingStore::createIDBDatabaseMetaData):
(FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::~FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::create):
(WebCore::FailingIDBFactoryBackendImpl::removeIDBDatabaseBackend):
(WebCore::FailingIDBFactoryBackendImpl::openBackingStore):
(WebCore::TEST):

  • tests/IDBFakeBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h.

(WebCore):
(IDBFakeBackingStore):

TBR=dgrogan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10536007

TBR=dgrogan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10534013

14:24 Changeset [119524] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectations.

  • platform/chromium/TestExpectations:
14:16 Changeset [119523] by eae@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed chromium mac rebaseline for float-containing-block-with-margin.

  • platform/chromium-mac-leopard/fast/sub-pixel: Added.
  • platform/chromium-mac-leopard/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png:
13:54 Changeset [119522] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add Chromium test failure expectations per Skia roll:
http://src.chromium.org/viewvc/chrome?view=rev&revision=140580

  • platform/chromium/TestExpectations:
13:53 Changeset [119521] by jonlee@apple.com
  • 2 edits in trunk/Tools

Buildbot fix.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

13:47 Changeset [119520] by dpranke@chromium.org
  • 12 edits in trunk/Tools

webkitpy: clean up win-specific path handling and tests
https://bugs.webkit.org/show_bug.cgi?id=88281

Reviewed by Adam Barth.

There was a bunch of inconsistent logic for handling path
conversions for win32 and cygwin paths due to us sometimes
looking at sys.platform and sometimes using mock hosts. This
patch cleans everything up so that we are required to pass
PlatformInfo objects to the path module and stop trying to do
different things when running on cygwin or win32 hosts (except
in the path_unittest module itself).

This may slightly reduce test coverage for the win32 code paths
but will be a lot easier to follow and maintain.

  • Scripts/webkitpy/common/system/path.py:

(abspath_to_uri):
(_convert_path):

  • Scripts/webkitpy/common/system/path_unittest.py:

(AbspathTest.platforminfo):
(AbspathTest.test_abspath_to_uri_cygwin):
(AbspathTest.test_abspath_to_uri_unixy):
(AbspathTest.test_abspath_to_uri_win):
(AbspathTest.test_abspath_to_uri_escaping_unixy):
(AbspathTest.test_abspath_to_uri_escaping_cygwin):
(AbspathTest.test_stop_cygpath_subprocess):

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init):
(PlatformInfo.is_cygwin):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.is_cygwin):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.show_results_html_file):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.test_to_uri):
(Driver.uri_to_test):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverTest.test_test_to_uri):
(DriverTest.test_uri_to_test):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.make_port):
(MockDRTTest.input_line):
(MockChromiumDRTTest.test_pixeltestfails):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.show_results_html_file):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_unexpected_failures):
(MainTest.test_results_directory_absolute):
(MainTest.test_results_directory_default):
(MainTest.test_results_directory_relative):

13:41 Changeset [119519] by jonlee@apple.com
  • 3 edits in trunk/Tools

Workaround buildbot bug when merging build requests.
https://bugs.webkit.org/show_bug.cgi?id=88158

Reviewed by Mark Rowe.

For expediency, we still want testers to pick the latest build to test, but to ensure
that the builders are reporting the correct revision number, we should let the building bots
run as they normally would. That is, the builder picks the oldest revision, and merges
subsequent requests. Because merged requests get appended to the list of changes for a given
build, the last change in that list is also the latest change. When we used pickLatestBuild
for the builders, this was not the case (it would always report the penultimate change).

http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override

for all Apple builders.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick

the latest build to run.
(loadBuilderConfig):

13:38 Changeset [119518] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Entry into JSC should CRASH() if the Heap is busy
https://bugs.webkit.org/show_bug.cgi?id=88355

Reviewed by Geoffrey Garen.

Interpreter::execute() returns jsNull() right now if we try to enter it while
the Heap is busy (e.g. with a collection), which is okay, but some code paths
that call Interpreter::execute() allocate objects before checking if the Heap
is busy. Attempting to execute JS code while the Heap is busy should not be
allowed and should be enforced by a release-mode CRASH() to prevent vague,
unhelpful backtraces later on if somebody makes a mistake. Normally, recursively
executing JS code is okay, e.g. for evals, but it should not occur during a
Heap allocation or collection because the Heap is not guaranteed to be in a
consistent state (especially during collections). We are protected from
executing JS on the same Heap concurrently on two separate threads because
they must each take a JSLock first. However, we are not protected from reentrant
execution of JS on the same thread because JSLock allows reentrancy. Therefore,
we should fail early if we detect an entrance into JS code while the Heap is busy.

  • heap/Heap.cpp: Changed Heap::collect so that it sets the m_operationInProgress field

at the beginning of collection and then unsets it at the end so that it is set at all
times throughout the duration of a collection rather than sporadically during various
phases. There is no reason to unset during a collection because our collector does
not currently support running additional JS between the phases of a collection.
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::collect):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute): Crash if the Heap is busy.

  • runtime/Completion.cpp: Crash if the Heap is busy. We do it here before we call

Interpreter::execute() because we do some allocation prior to calling execute() which
could cause Heap corruption if, for example, that allocation caused a collection.
(JSC::evaluate):

13:21 NewRunWebKitTests edited by alex.bravo@nokia.com
Removed link to HackingOnNewRunWebKitTests as it onlyhas a link back to … (diff)
13:06 Changeset [119517] by vestbo@webkit.org
  • 4 edits
    1 copy in trunk/Source/WebKit2

[Qt] Implement log channel initialization for WebKit2

Reviewed by Alexis Menard.

12:59 Changeset [119516] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

WebLayerTreeRenderer behaves wrongly when no contentsScale is set.
https://bugs.webkit.org/show_bug.cgi?id=88357

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-06-05
Reviewed by Alexis Menard.

The contentsScale needs to get a default value in case no
value is explicitely set yet.
This fixes the blank-until-resize problem when running MiniBrowser
in --desktop mode.

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):

12:52 Changeset [119515] by timothy_horton@apple.com
  • 2 edits
    2 deletes in trunk/LayoutTests

Assertion failure on mac-lion-wk2 in fast/hidpi/device-scale-factor-paint.html
https://bugs.webkit.org/show_bug.cgi?id=88356

Unreviewed, remove incorrect baselines and skip test on Mac.

  • platform/mac/Skipped:
  • platform/mac/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
  • platform/mac/fast/hidpi/device-scale-factor-paint-expected.txt: Removed.
12:22 Changeset [119514] by arv@chromium.org
  • 6 edits
    1 copy
    3 adds in trunk

[V8] Improve variable resolution order on window
https://bugs.webkit.org/show_bug.cgi?id=84247

Reviewed by Ojan Vafai.

This changes the V8 flag to turn on es52_globals and updates the layout tests to reflect the fixed behavior.

Source/WebCore:

Test: fast/dom/Window/window-property-shadowing-onclick.html

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded): Set the flag as we initialize V8.

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initIsolate): Ditto.

LayoutTests:

  • fast/dom/Window/window-property-shadowing-name-expected.txt: The expectation is now reversed.
  • fast/dom/Window/window-property-shadowing-name.html: JSC fails so this test says fail. Bug 75575 tracks JSC.
  • fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
  • fast/dom/Window/window-property-shadowing-onclick.html: Added.
  • platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Copied from LayoutTests/fast/dom/Window/window-property-shadowing-name-expected.txt.
  • platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
12:16 Changeset [119513] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Delete dead code from RenderBox::computeLogicalWidthInRegion
https://bugs.webkit.org/show_bug.cgi?id=88353

Reviewed by Tony Chang.

No new tests obviously since this is dead code.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):

12:16 Changeset [119512] by eae@chromium.org
  • 3 edits
    3 adds
    1 delete in trunk/LayoutTests

Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test
https://bugs.webkit.org/show_bug.cgi?id=88351

Reviewed by Levi Weintraub.

Change fast/sub-pixel/float-containing-block-with-margin.html to pixel
test to allow for platform differences as the default styling makes it
very hard to use a reftests for this.

  • fast/sub-pixel/float-containing-block-with-margin-expected.html: Removed.
  • fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • fast/sub-pixel/float-containing-block-with-margin-expected.txt: Added.
  • fast/sub-pixel/float-containing-block-with-margin.html:
  • platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • platform/chromium/TestExpectations:
12:01 Changeset [119511] by leviw@chromium.org
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed gardening. Fixing improper text expectation following r119503.

  • platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/chromium-win/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/chromium/fast/line-grid: Added.
  • platform/chromium/fast/line-grid/line-align-left-edges-expected.txt: Added.
11:53 Changeset [119510] by pilgrim@chromium.org
  • 8 edits
    2 copies in trunk/Source

[Chromium] Move createLocalStorageNamespace to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85766

Source/Platform:

Reviewed by James Robinson.

Part of a refactoring series. See tracking bug 82948.

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::createLocalStorageNamespace):

  • chromium/public/WebStorageArea.h: Added.

(WebKit):
(WebStorageArea):
(WebKit::WebStorageArea::~WebStorageArea):
(WebKit::WebStorageArea::setItem):
(WebKit::WebStorageArea::removeItem):
(WebKit::WebStorageArea::clear):

  • chromium/public/WebStorageNamespace.h: Added.

(WebKit):
(WebStorageNamespace):
(WebKit::WebStorageNamespace::~WebStorageNamespace):
(WebKit::WebStorageNamespace::isSameNamespace):

Source/WebKit/chromium:

Reviewed by James Robinson.

Part of a refactoring series. See tracking bug 82948.

  • WebKit.gyp:
  • public/WebStorageArea.h:
  • public/WebStorageNamespace.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

11:53 Changeset [119509] by rniwa@webkit.org
  • 5 edits
    4 adds in trunk/LayoutTests

Chromium rebaseline per Chromium r140536.

  • platform/chromium-linux-x86/http/tests/media: Added.
  • platform/chromium-linux-x86/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win-vista/http/tests/media: Added.
  • platform/chromium-win-vista/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
11:39 Changeset [119508] by commit-queue@webkit.org
  • 10 edits in trunk

New constructor for WebIntent to be used for delivery
https://bugs.webkit.org/show_bug.cgi?id=87143

Patch by Greg Billock <gbillock@google.com> on 2012-06-05
Reviewed by Darin Fisher.

Source/WebCore:

  • Modules/intents/Intent.cpp:

(WebCore::Intent::setExtras):
(WebCore):

  • Modules/intents/Intent.h:

(Intent):

Source/WebKit/chromium:

When delivering an intent to webkit, the caller needs to be able to
provide the action, type, and data, and also extra data and ports.

  • public/WebIntent.h:

(WebIntent):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::deliverIntent):

  • src/WebIntent.cpp:

(WebKit::WebIntent::WebIntent):
(WebKit):
(WebKit::WebIntent::reset):
(WebKit::WebIntent::messagePortChannelsRelease):

11:32 Changeset [119507] by ojan@chromium.org
  • 16 edits
    2 adds in trunk

Change overrideSizes to be content-box instead of border-box
https://bugs.webkit.org/show_bug.cgi?id=88116

Reviewed by Tony Chang.

Source/WebCore:

Previously, the code used border-box everywhere except for one place
where it used content-box when setting the override size. Conversely,
it subtracted the borderAndPaddingSize everywhere it grabbed the override
size except for one.

Instead, make the override size override the content-box size.
Converging on using the border-box size would be tricky given RenderTableCell's
tricky management of intrinsic padding.

There is no behavior change except in RenderBox::availableLogicalHeightUsing,
which fixes a table test.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::setOverrideLogicalContentHeight):
(WebCore::RenderBox::setOverrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentHeight):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
We were incorrectly subtracting the borderAndPaddingLogicalWidth instead
of the borderAndPaddingLogicalHeight.

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeAvailableFreeSpace):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):

LayoutTests:

  • fast/table/padding-height-and-override-height-expected.txt:
  • fast/table/padding-height-and-override-height.html:

Tests the change in RenderBox::availableLogicalHeightUsing to correctly subtract the
borderAndPaddingLogicalHeight instead of the borderAndPaddingLogicalWidth.

  • platform/chromium-linux/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug131020-expected.txt:

The new results are more correct. The table cell had 2px too much padding-top and padding-bottom before.

11:28 Changeset [119506] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r118197): PluginStrategy should be used even if ENABLE(NETSCAPE_PLUGIN_API) is false
https://bugs.webkit.org/show_bug.cgi?id=88296

Reviewed by Dan Bernstein.

refresh() and initPlugins() should call into PluginStrategy even if
ENABLE(NETSCAPE_PLUGIN_API) is false. Some ports support non-Netscape
plug-ins, so PluginStrategy should be consulted even if Netscape
plug-ins specifically are disabled.

Ports that support platform strategies but not Netscape plug-ins should
handle this inside their PluginStrategy rather than modifying generic
plug-in code.

  • plugins/PluginData.cpp:

(WebCore::PluginData::refresh):
(WebCore::PluginData::initPlugins):

11:23 Changeset [119505] by jberlin@webkit.org
  • 2 edits in trunk/Tools

[Win] DumpRenderTree should call resetInternalsObject
https://bugs.webkit.org/show_bug.cgi?id=88346

Reviewed by Simon Fraser.

Invoke it on Windows in the same place it is invoked on Mac.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

11:15 Changeset [119504] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/media/remove-while-loading.html times out on mac-lion-wk2
https://bugs.webkit.org/show_bug.cgi?id=88348

Unreviewed skip of this test for greenness.

  • platform/mac-wk2/Skipped:
11:13 Changeset [119503] by leviw@chromium.org
  • 43 edits
    4 adds
    3 deletes in trunk/LayoutTests

Unreviewed gardening. Updating test expectations after r119456.

  • fast/line-grid/line-grid-contains-value-expected.txt: Added.
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-leopard/fast/forms/001-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-mac/fast/forms/001-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.txt:
  • platform/chromium-mac/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.png:
  • platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.txt: Added.
  • platform/chromium-mac/fast/line-grid/line-grid-contains-value-expected.txt: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-win/fast/line-grid/line-align-left-edges-expected.png:
  • platform/chromium-win/fast/line-grid/line-align-left-edges-expected.txt: Added.
  • platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/line-grid: Removed.
  • platform/chromium/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/efl/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
  • platform/gtk/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
11:05 Changeset [119502] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash when modifying fixed-position elements in a detached frame
https://bugs.webkit.org/show_bug.cgi?id=88288

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-06-05
Reviewed by James Robinson.

Source/WebCore:

Test: fast/block/positioning/fixed-position-detached-frame.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

  • fast/block/positioning/fixed-position-detached-frame-expected.txt: Added.
  • fast/block/positioning/fixed-position-detached-frame.html: Added.
10:33 Changeset [119501] by leviw@chromium.org
  • 1 move in branches/old/subpixellayout

Moving the sub-pixel layout branch to branches/old since the feature has landed and development on the branch has ceased.

10:22 Changeset [119500] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140492 to r140528.

  • DEPS:
10:12 Changeset [119499] by caseq@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

Web Inspector: render timeline paint category dark green
https://bugs.webkit.org/show_bug.cgi?id=88333

Reviewed by Pavel Feldman.

  • Added a new, dark-green color for timeline events.
  • WebCore.gypi: Added timelineBarDarkGreen.png
  • inspector/front-end/Images/timelineBarDarkGreen.png: Added.
  • inspector/front-end/Images/timelineCheckmarks.png: Added a dark-green checkbox.
  • inspector/front-end/Images/timelineDots.png: Added a dark-green dot.
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.categories):

  • inspector/front-end/WebKit.qrc: Added timelineBarDarkGreen.png.
  • inspector/front-end/timelinePanel.css:

(.timeline-category-statusbar-item.timeline-category-painting .timeline-category-checkbox):
(.timeline-category-painting .timeline-graph-bar):
(.popover .timeline-painting):
(.timeline-category-painting .timeline-tree-icon):

10:08 Changeset [119498] by loislo@chromium.org
  • 8 edits in trunk

Web Inspector: serialize edge counts instead of indexes in heap snapshot
https://bugs.webkit.org/show_bug.cgi?id=88324

The serialized node structure currently holds an index
of its first containment edge in the edges array.
The index can be quite big (up to 7 digits for large snapshots).
The patch changes the serialization format to pass
node containment edge count instead. For most nodes the count
is just a single digit number.
This reduces serialized snapshot size and therefore its transfer time.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-05
Reviewed by Yury Semikhatsky.

PerformanceTests:

  • inspector/heap-snapshot-performance-test.js:

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype._edgeIndexesStart):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesEnd):
(WebInspector.HeapSnapshotNode.prototype._ordinal):
(WebInspector.HeapSnapshotNodeIterator):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildEdgeIndexes):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatorTree):
(WebInspector.HeapSnapshot.prototype._markPageOwnedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

  • inspector/profiler/heap-snapshot-expected.txt:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest.):

  • inspector/profiler/heap-snapshot.html:
10:01 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
09:30 Changeset [119497] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Don't propagate viewport size changes if the viewport is empty.
https://bugs.webkit.org/show_bug.cgi?id=88336

Reviewed by Tor Arne Vestbø.

Qt Quick sequentially set the x, y, width, height of the view. We really want to
start propagating further when the size of the viewport becomes valid, i.e. both
height and width are defined. In any case lower level classes are discarding an empty
size such as WebPage::sendViewportAttributesChanged() so it was pointless to send the size
through the IPC bus for nothing.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):

09:23 Changeset [119496] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Web Inspector highlight is slow
https://bugs.webkit.org/show_bug.cgi?id=88331

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-05
Reviewed by Rob Buis.

Highlight is slow on large pages because of constant repaint calls.
Change to use the accelerated layer highlight all the time.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::renderContents):

  • WebCoreSupport/InspectorClientBlackBerry.cpp:

(WebCore::InspectorClientBlackBerry::highlight):
(WebCore::InspectorClientBlackBerry::hideHighlight):

  • WebCoreSupport/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::clear):
(WebCore::InspectorOverlay::update):

09:18 Changeset [119495] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Fix two more memory leaks in DRT
https://bugs.webkit.org/show_bug.cgi?id=88255

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-05
Reviewed by Martin Robinson.

Fixed memory leaks in GTK's DRT code.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(dumpHistoryItem): webkit_web_history_item_get_target() returns a
g_strdup()'d string. So, use GOwnPtr to manage memory automatically.

  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:

(createBitmapContextFromWebView): Free the cairo surface.

09:04 Changeset [119494] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] There is no way to retrieve composition character rectangle in WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=87911

Patch by Seigo Nonaka <nona@chromium.org> on 2012-06-05
Reviewed by Ryosuke Niwa.

Add an API for retreieving each character bounds in composition text.
This API is necessary for implementing IMR_QUERYCHARPOSITION message in Windows.
The message is used by Japanese IME for showing their window at the correct position.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::compositionCharacterBounds):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::compositionCharacterBounds):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

08:47 Changeset [119493] by carlosgc@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] Add webkit_download_get_received_data_length to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=88323

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitDownload.cpp:

(webkit_download_get_received_data_length):

  • UIProcess/API/gtk/WebKitDownload.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestDownloads.cpp:
08:37 Changeset [119492] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk

CSS 2.1 failure: border-conflict-element-021a
https://bugs.webkit.org/show_bug.cgi?id=86885

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-06-05
Reviewed by Julien Chaffraix.

Source/WebCore:

When two adjacent table row groups (thead, tbody, tfoot) have the same border-width
and the same border-style in a 'border-collapse: collapse' table the color of the border
from the top-most table row wins.

Tests: fast/table/border-collapsing/adjacent-row-groups-multi.html

fast/table/border-collapsing/adjacent-row-groups.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintObject):
Currently each row group is sent for paint from top (firstChild) to bottom thereby causing
the borders of the bottom-most row group (which is painted last) to overlap over the
previous row-group. This breaks the precedence for collapsed borders between adjacent cells.

This fix thus reverses the order in which the row-groups/sections are passed for painting.
Additional change has been done to iterate over the RenderTableSections directly.

(WebCore):
(WebCore::RenderTable::bottomSection):

  • rendering/RenderTable.h:

New function has been added to obtain the last section of the table.

(RenderTable):

  • rendering/RenderTableSection.h:

(RenderTableSection):
RenderTableSection's paint() method has now been made public so as to make it accessible
from RenderTable.

LayoutTests:

  • css2.1/20110323/border-conflict-element-021a-expected.html: Added.
  • css2.1/20110323/border-conflict-element-021a.htm: Added.

Added ref test under the css2.1 test-suite for border-conflict-element-021a.

  • fast/table/border-collapsing/adjacent-row-groups-expected.html: Added.
  • fast/table/border-collapsing/adjacent-row-groups.html: Added.

Added ref test for verifying 'border-collapse: collapse' table rendering when two
adjacent table row-groups have the same border-width and the same border-style. In
such a case the color of the border from the top-most table row-group wins.

  • fast/table/border-collapsing/adjacent-row-groups-multi.html: Added.
  • fast/table/border-collapsing/adjacent-row-groups-multi-expected.html: Added.

Additional ref test added for verifying 'border-collapse: collapse' table rendering
for adjacent table row-groups when more than one table headers and/or footers are specified.

08:32 Changeset [119491] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium unreviewed sheriffing: enable blob tests that are passing since r119454.

  • platform/chromium/TestExpectations:

fast/filesystem/file-writer-gc-blob.html
fast/filesystem/workers/file-writer-sync-truncate-extend.html
fast/filesystem/workers/file-writer-gc-blob.html

08:26 Changeset [119490] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][Win] Fix IDL dependency generation
https://bugs.webkit.org/show_bug.cgi?id=88304

Reviewed by Tor Arne Vestbø.

  • DerivedSources.pri:
08:17 Changeset [119489] by loislo@chromium.org
  • 8 edits
    7 deletes in trunk

Unreviewed, rolling out r119467, r119471, and r119476.
http://trac.webkit.org/changeset/119467
http://trac.webkit.org/changeset/119471
http://trac.webkit.org/changeset/119476
https://bugs.webkit.org/show_bug.cgi?id=88332

it broke chromium-mac static initializers test.\ (Requested by
loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-05

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/FontPlatformData.h:

(FontPlatformData):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):

  • platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp: Removed.
  • platform/graphics/harfbuzz/ng/HarfBuzzFace.h: Removed.
  • platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp: Removed.
  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: Removed.
  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h: Removed.
  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):

LayoutTests:

  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.png: Removed.
  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.txt: Removed.
  • platform/chromium/TestExpectations:
08:13 Changeset [119488] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Building when a top directory is named Source
https://bugs.webkit.org/show_bug.cgi?id=77727

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-05
Reviewed by Tor Arne Vestbø.

Change regex to only replace the last instance of OUT_PWD.

  • qmake/mkspecs/features/default_pre.prf:
08:01 Changeset [119487] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: SHIFT key as helper to color adjustment in color picker
https://bugs.webkit.org/show_bug.cgi?id=88319

Reviewed by Pavel Feldman.

With Shift depressed, the dragger in the color picker will snap to the horizontal
or vertical axis while dragging, depending on which axis offset is greater.

  • inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.colorDragStart):
(WebInspector.Spectrum.colorDrag):
(WebInspector.Spectrum.draggable.move):
(WebInspector.Spectrum.draggable.start):

07:51 Changeset [119486] by dgrogan@chromium.org
  • 6 edits
    2 copies in branches/chromium/1132/Source

Merge 117978 - IndexedDB: Fire error when there are problems opening a DB
https://bugs.webkit.org/show_bug.cgi?id=85579

Source/WebCore:

We used to either fire success or get into an infinite loop.

Reviewed by Tony Chang.

New unit test in
Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::openConnection):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::create):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openInternal):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/IDBAbortOnCorruptTest.cpp: Added.

(WebCore):
(MockIDBCallbacks):
(WebCore::MockIDBCallbacks::MockIDBCallbacks):
(WebCore::MockIDBCallbacks::~MockIDBCallbacks):
(WebCore::MockIDBCallbacks::onError):
(WebCore::MockIDBCallbacks::onSuccess):
(WebCore::MockIDBCallbacks::onSuccessWithContinuation):
(WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
(WebCore::MockIDBCallbacks::onBlocked):
(FailingBackingStore):
(WebCore::FailingBackingStore::~FailingBackingStore):
(WebCore::FailingBackingStore::open):
(WebCore::FailingBackingStore::createIDBDatabaseMetaData):
(FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::~FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::create):
(WebCore::FailingIDBFactoryBackendImpl::removeIDBDatabaseBackend):
(WebCore::FailingIDBFactoryBackendImpl::openBackingStore):
(WebCore::TEST):

  • tests/IDBFakeBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h.

(WebCore):
(IDBFakeBackingStore):

TBR=dgrogan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10536007

07:50 Changeset [119485] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: aggregate all events before first frame into a fake frame
https://bugs.webkit.org/show_bug.cgi?id=88229

  • in Timeline's frame mode, start aggregating events by frame even before we get first frame marker.
  • inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController.prototype._addRecord):
(WebInspector.TimelineFrameController.prototype._flushFrame):
(WebInspector.TimelineFrameController.prototype._createFrame):

05:27 Changeset [119484] by charles.wei@torchmobile.com.cn
  • 5 edits in trunk/Source/WebCore

JSC:need to implement Dictionary::getWithUndefinedOrNullCheck for IDB
https://bugs.webkit.org/show_bug.cgi?id=88283

Reviewed by Kentaro Hara.

No new tests, idb not working for JSC yet.

  • bindings/js/Dictionary.cpp:

(WebCore::Dictionary::getWithUndefinedOrNullCheck):

  • bindings/js/Dictionary.h:

(Dictionary):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::getWithUndefinedOrNullCheck):
(WebCore):

  • bindings/js/JSDictionary.h:

(JSDictionary):

04:37 FeatureFlags edited by tkent@chromium.org
Add CUSTOM_SCHEME_HANDLER (diff)
04:35 Changeset [119483] by rwlbuis@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Hit ASSERT when editing attribute value in Element in SVG Document
https://bugs.webkit.org/show_bug.cgi?id=88179

Reviewed by Pavel Feldman.

Test setting attribute on non HTML element.

  • inspector/elements/set-attribute-non-html-expected.txt: Added.
  • inspector/elements/set-attribute-non-html.svg: Added.
04:32 Changeset [119482] by commit-queue@webkit.org
  • 30 edits
    2 adds in trunk

Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
https://bugs.webkit.org/show_bug.cgi?id=73176

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-06-05
Reviewed by Adam Barth.

Two more APIs are added in Custom Scheme Handler specification.
http://dev.w3.org/html5/spec/Overview.html#custom-handlers
One is 'isProtocolHandlerRegistered' to query whether the specific URL
is registered or not.
The other is 'unregisterProtocolHandler' to remove the registered URL.

.:

  • Source/cmake/WebKitFeatures.cmake: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
  • Source/cmakeconfig.h.cmake: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/WebCore:

Test: fast/dom/unregister-protocol-handler.html

  • Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
  • loader/EmptyClients.h: Add prototypes.

(EmptyChromeClient):
(WebCore::EmptyChromeClient::isProtocolHandlerRegistered):
(WebCore::EmptyChromeClient::unregisterProtocolHandler):

  • page/ChromeClient.h:

(ChromeClient):

  • page/NavigatorRegisterProtocolHandler.cpp:

(WebCore):
(WebCore::customHandlersStateString):
(WebCore::NavigatorRegisterProtocolHandler::isProtocolHandlerRegistered): Query if the handler is registered.
(WebCore::NavigatorRegisterProtocolHandler::unregisterProtocolHandler): Unregister the registered handler.

  • page/NavigatorRegisterProtocolHandler.h:

(NavigatorRegisterProtocolHandler):

  • page/NavigatorRegisterProtocolHandler.idl:

Source/WebKit/chromium:

  • features.gypi: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::customHandlerDataCreate):
(WebCore::customHandlerDataDelete):
(WebCore::ChromeClientEfl::registerProtocolHandler):
(WebCore):
(WebCore::ChromeClientEfl::isProtocolHandlerRegistered): Query if the handler is registered.
(WebCore::ChromeClientEfl::unregisterProtocolHandler): Unregister the registered handler.

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

  • ewk/ewk_custom_handler.cpp:

(ewk_custom_handler_is_protocol_handler_registered): Query if the handler is registered.
(ewk_custom_handler_unregister_protocol_handler): Unregister the registered handler.

  • ewk/ewk_custom_handler_private.h: Adds private function.
  • ewk/ewk_view.h: Adds enumeration.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

LayoutTests:

  • fast/dom/unregister-protocol-handler-expected.txt: Added.
  • fast/dom/unregister-protocol-handler.html: Added.
04:28 Changeset [119481] by morrita@google.com
  • 5 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=88029
content-element-api.html and shadow-element.html depend on V8.

Reviewed by Kentaro Hara.

Replaced typeof checking with comparison.

  • fast/dom/shadow/content-element-api.html:
  • fast/dom/shadow/shadow-element.html:
04:13 Changeset [119480] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] WebKit2-EFL does not link with gold linker
https://bugs.webkit.org/show_bug.cgi?id=88295

Unreviewed. Fix linking when using gold linker.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-05

  • PlatformEfl.cmake:
03:57 Changeset [119479] by kinuko@chromium.org
  • 4 edits in trunk

Chromium tests: "Add support for the Blob constructor" [r115582] regressed blob layout tests
https://bugs.webkit.org/show_bug.cgi?id=85174

Reviewed by Kentaro Hara.

Source/WebCore:

This fixes a crash problem which could happen when the constructor is
given an array which contains String-type item(s).

There're still some Text mismatches between v8 results and
JSC results, most of them are v8 not throwing exception
when it is given an object whose toString() method throws
exception. (The issue will be addresse in a separate patch.)

Test: fast/files/blob-constructor.html

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

LayoutTests:

Changing blob-constructor.html label from CRASH to TEXT.

  • platform/chromium/TestExpectations:
03:39 Changeset [119478] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary constructor of SelectorQueryCache
https://bugs.webkit.org/show_bug.cgi?id=87942

Reviewed by Ryosuke Niwa.

Per the comment from darin@ (https://bugs.webkit.org/show_bug.cgi?id=87942#c27),
this patch removes an inline constructor that has no arguments.
To have the compiler generate the constructor,
this patch also removes WTF_MAKE_NONCOPYABLE().

No tests. No change in behavior.

  • dom/SelectorQuery.h:

(SelectorQueryCache):

03:25 Changeset [119477] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove unused methods from SelectorQuery.h
https://bugs.webkit.org/show_bug.cgi?id=88289

Reviewed by Antti Koivisto.

This patch removes SelectorDataList::size() and
SelectorDataList::SelectorDataList().
SelectorDataList::size() is not used by anybody.
SelectorDataList::SelectorDataList() can be auto-generated
by a compiler.

No tests. No change in behavior.

  • dom/SelectorQuery.cpp:
  • dom/SelectorQuery.h:

(SelectorDataList):

02:55 Changeset [119476] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update

  • platform/chromium/TestExpectations:
02:47 WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
02:46 Changeset [119475] by mario@webkit.org
  • 10 edits
    3 adds in trunk

[GTK][WK2] Implement API for Geolocation permission requests in the GTK port
https://bugs.webkit.org/show_bug.cgi?id=83879

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Added a new kind of permission request for supporting the
Geolocation API in WebKit2GTK+.

New WebKitGeolocationPermissionRequest class, implementing the
WebKitPermissionRequest interface, to enabling client applications
to allow or deny geolocation permission requests.

  • GNUmakefile.list.am: Added new files.
  • UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp: Added.

(_WebKitGeolocationPermissionRequestPrivate):
(webkitGeolocationPermissionRequestAllow):
(webkitGeolocationPermissionRequestDeny):
(webkit_permission_request_interface_init):
(webkit_geolocation_permission_request_init):
(webkitGeolocationPermissionRequestFinalize):
(webkit_geolocation_permission_request_class_init):
(webkitGeolocationPermissionRequestCreate):

  • UIProcess/API/gtk/WebKitGeolocationPermissionRequest.h: Added.

(_WebKitGeolocationPermissionRequest):
(_WebKitGeolocationPermissionRequestClass):

  • UIProcess/API/gtk/WebKitGeolocationPermissionRequestPrivate.h: Added.

Include WKGeolocationPermissionRequest.h in WebKitPrivate.h, so we
can use it from the new WebKitGeolocationPermissionRequest class.

  • UIProcess/API/gtk/WebKitPrivate.h: Added new include.

Implement geolocation permission requests in the UI client.

  • UIProcess/API/gtk/WebKitUIClient.cpp:

(decidePolicyForGeolocationPermissionRequest): Create a new
instance of the WebKitGeolocationPermissionRequest class and call
to webkitWebViewMakePermissionRequest().
(attachUIClientToView): Provide an implementation function for
decidePolicyForGeolocationPermissionRequest.

  • UIProcess/API/gtk/WebKitWebView.h: Add new element to

WebKitPermissionRequestType enumeration for geolocation requests.

  • UIProcess/API/gtk/webkit2.h: Added header file for

WebKitGeolocationPermissionRequest

New unit tests to test allowing and denying permission requests.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewPermissionRequests): New test that loads a simple HTML
with JavaScript code requesting the current location.
(beforeAll): Added new test.

Updated documentation files.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

Tools:

Make minibrowser connect to the new 'permission requests' signal
to allow users handle the Geolocation permission requests.

  • MiniBrowser/gtk/BrowserWindow.c:

(geolocationRequestDialogCallback): Callback for the dialog asking
the user for allowing or not geolocation permission requests.
(webViewDecidePermissionRequest): Launch a dialog to ask the user
whether to allow or deny geolocation permission requests.
(browserWindowConstructed): Connect to 'permission-request' signal.

02:37 Changeset [119474] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Build fix for r119470.

  • loader/EmptyClients.cpp: Add #include "IntentRequest.h".
02:34 Changeset [119473] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused function: Document::formElements
https://bugs.webkit.org/show_bug.cgi?id=88272

Reviewed by Kentaro Hara.

No new tests. No behavior change.

  • dom/Document.h:

(Document): remove formElements(). It was used for radio group
validation, but the current code doesn't use it any more.

02:33 Changeset [119472] by apavlov@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, build fix after r119469.

  • inspector/styles/lazy-computed-style-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
02:28 Changeset [119471] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix on Chromium mac

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::isAATFont):

02:08 Changeset [119470] by tkent@chromium.org
  • 7 edits in trunk/Source

Move some function definitions in EmptyClients.h to EmptyClients.cpp
https://bugs.webkit.org/show_bug.cgi?id=88285

Reviewed by Ryosuke Niwa.

Source/WebCore:

If we have definitions of functions with RefPtr<> in EmptyClients.h like

virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) { }

and a source file includes EmptyClient.h, the source file needs to
include FileChooser.h though the source file doesn't use FileChooser
class explicitly because the definition of runOpenPanel() needs to call
FileChooser::deref().
To avoid this, we had better move such functions to EmptyClients.cpp.

No new tests. No behavior changes.

  • loader/EmptyClients.cpp: Move such functions from EmptyClients.h to

here, and move EmptyPopupMenu and EmptySearchPopupMenu too because
they're used only by EmptyChromeClient.
(WebCore):
(EmptyPopupMenu):
(WebCore::EmptyPopupMenu::show):
(WebCore::EmptyPopupMenu::hide):
(WebCore::EmptyPopupMenu::updateFromElement):
(WebCore::EmptyPopupMenu::disconnectClient):
(EmptySearchPopupMenu):
(WebCore::EmptySearchPopupMenu::popupMenu):
(WebCore::EmptySearchPopupMenu::saveRecentSearches):
(WebCore::EmptySearchPopupMenu::loadRecentSearches):
(WebCore::EmptySearchPopupMenu::enabled):
(WebCore::EmptyChromeClient::createPopupMenu):
(WebCore::EmptyChromeClient::createSearchPopupMenu):
(WebCore::EmptyChromeClient::createColorChooser):
(WebCore::EmptyChromeClient::runOpenPanel):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebCore::EmptyFrameLoaderClient::dispatchWillSendSubmitEvent):
(WebCore::EmptyFrameLoaderClient::dispatchWillSubmitForm):
(WebCore::EmptyFrameLoaderClient::createDocumentLoader):
(WebCore::EmptyFrameLoaderClient::createFrame):
(WebCore::EmptyFrameLoaderClient::createPlugin):
(WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
(WebCore::EmptyFrameLoaderClient::createMediaPlayerProxyPlugin):
(WebCore::EmptyFrameLoaderClient::createNetworkingContext):
(WebCore::EmptyFrameLoaderClient::dispatchIntent):
(WebCore::EmptyTextCheckerClient::requestCheckingOfString):
(WebCore::EmptyEditorClient::registerUndoStep):
(WebCore::EmptyEditorClient::registerRedoStep):
(WebCore::EmptyContextMenuClient::customizeMenu):

  • loader/EmptyClients.h: Move such function definitions to

EmptyClient.cpp, and append OVERRIDE.
(EmptyChromeClient):
(EmptyFrameLoaderClient):
(EmptyTextCheckerClient):
(EmptyEditorClient):
(EmptyContextMenuClient):

  • svg/graphics/SVGImage.cpp: Remove unnecessary #includes.

Source/WebKit/chromium:

  • src/WebHelperPluginImpl.cpp: Remove unnecessary #includes, and add necessary #includes.
  • src/WebPagePopupImpl.cpp: ditto.
01:56 Changeset [119469] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: "-webkit"-prefixed properties are considered inherited in the Computed Style pane
https://bugs.webkit.org/show_bug.cgi?id=88257

Reviewed by Pavel Feldman.

Source/WebCore:

Canonical names for properties should be used when checking if they are inherited (since only canonical names
are put into the usedProperties set).

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):

LayoutTests:

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/elements/elements-panel-styles.html:
01:27 Changeset [119468] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
01:15 Changeset [119467] by bashi@chromium.org
  • 8 edits
    8 adds in trunk

[Chromium] Implement font shaping with font-feature-settings on Mac
https://bugs.webkit.org/show_bug.cgi?id=69826

Reviewed by Tony Chang.

Source/WebCore:

Add HarfBuzz-ng text shaper.
Chromium mac port uses it as secondary text shaper to support OpenType features.
HarfBuzz-ng is only used when -webkit-font-feature-settings is specified and
corresponding font is not an AAT font.

No new tests. css3/font-feature-settings-rendering.html should pass on Chromium mac port.

  • WebCore.gyp/WebCore.gyp: Added harfbuzz-ng dependencies.
  • WebCore.gypi: Added harfbuzz-ng files.
  • platform/graphics/FontPlatformData.h:

(FontPlatformData): Added m_harfbuzzFace.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::platformDataInit): Copy m_harfbuzzFace.
(WebCore::FontPlatformData::platformDataAssign): Ditto.
(WebCore):
(WebCore::isAATFont):
(WebCore::FontPlatformData::harfbuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp: Added.

(WebCore):
(WebCore::harfbuzzFaceCache):
(WebCore::HarfBuzzFace::HarfBuzzFace):
(WebCore::HarfBuzzFace::~HarfBuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzFace.h: Added.

(WebCore):
(HarfBuzzFace):
(WebCore::HarfBuzzFace::create):

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp: Added.

(WebCore):
(WebCore::floatToHarfBuzzPosition):
(WebCore::getGlyph):
(WebCore::getGlyphHorizontalAdvance):
(WebCore::getGlyphHorizontalOrigin):
(WebCore::getGlyphExtents):
(WebCore::harfbuzzCoreTextGetFontFuncs):
(WebCore::releaseTableData):
(WebCore::harfbuzzCoreTextGetTable):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: Added.

(WebCore):
(WebCore::harfbuzzPositionToFloat):
(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions):
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::~HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setFontFeatures):
(WebCore::HarfBuzzShaper::shape):
(WebCore::HarfBuzzShaper::setupHarfBuzzRun):
(WebCore::HarfBuzzShaper::shapeHarfBuzzRun):
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun):
(WebCore::HarfBuzzShaper::offsetForPosition):
(WebCore::HarfBuzzShaper::selectionRect):

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h: Added.

(WebCore):
(HarfBuzzShaper):
(WebCore::HarfBuzzShaper::totalWidth):
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setWidth):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numGlyphs):
(WebCore::HarfBuzzShaper::HarfBuzzRun::width):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore):
(WebCore::preferHarfBuzz): Added.
(WebCore::Font::selectionRectForComplexText): Use HarfBuzzShaper if font-feature-settings exists.
(WebCore::Font::drawComplexText): Ditto.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.

LayoutTests:

Added the expectation for sss3/font-feature-settings-rendering.html.

  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.png: Added.
  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.txt: Added.
  • platform/chromium/TestExpectations: Removed css3/font-feature-settings-rendering.html.
01:12 Changeset [119466] by commit-queue@webkit.org
  • 5 edits in trunk

IETC: FileList.item(-1) should return null instead of raising
https://bugs.webkit.org/show_bug.cgi?id=77899

Patch by Li Yin <li.yin@intel.com> on 2012-06-05
Reviewed by Kentaro Hara.

Source/WebCore:

IETC: http://samples.msdn.microsoft.com/ietestcenter/fileapi/filelist.htm
Accroding to http://es5.github.com/#x9.6
When the index is negative, it should not raise exception.
Firefox and IE returns null when there is not indexth File object.

Test: fast/files/file-list-test.html

  • fileapi/FileList.idl:

LayoutTests:

IETC: http://samples.msdn.microsoft.com/ietestcenter/fileapi/filelist.htm
Ref: http://es5.github.com/#x9.6
Some index values have been covered in this test, including negative index,
undefined, null, normal index(0~length-1), more than length index.

  • fast/files/file-list-test-expected.txt:
  • fast/files/file-list-test.html:
00:38 Changeset [119465] by abarth@webkit.org
  • 12 edits
    2 adds in trunk

EventHandler shouldn't dispatch fake mousemove events when scrolling on devices that don't have a mouse
https://bugs.webkit.org/show_bug.cgi?id=88270

Reviewed by James Robinson.

Source/WebCore:

This patch adds a setting analogous to deviceSupportsTouch to determine
whether the device supports mouse. We then don't dispatch fake mouse
events on devices that don't have a mouse in the first place.

Test: fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setDeviceSupportsMouse):
(WebCore::Settings::deviceSupportsMouse):
(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setDeviceSupportsMouse):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDeviceSupportsMouse):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

LayoutTests:

  • fast/events/touch/scroll-without-mouse-lacks-mousemove-events-expected.txt: Added.
  • fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html: Added.

06/04/12:

23:40 Changeset [119464] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG CFG simplification should correct the variables at the head of the predecessor block
https://bugs.webkit.org/show_bug.cgi?id=88284

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

LayoutTests:

  • fast/js/dfg-constant-fold-first-local-read-after-block-merge-expected.txt: Added.
  • fast/js/dfg-constant-fold-first-local-read-after-block-merge.html: Added.
  • fast/js/script-tests/dfg-constant-fold-first-local-read-after-block-merge.js: Added.

(foo):
(bar):

23:38 Changeset [119463] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Make a builder group support+expect multiple loads.
https://bugs.webkit.org/show_bug.cgi?id=88260

Change BuilderGroup to allow expecting multiple
loads. This allows merging results for a given set
of builders into one group.

Add a test that verifies that the group count
increments correctly based on successful and failed
list loads.

Patch by Chase Phillips <cmp@google.com> on 2012-06-04
Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.js:

(BuilderGroup):
(BuilderGroup.prototype.setbuilder):
(BuilderGroup.prototype.append):
(BuilderGroup.prototype.loaded):
(requestBuilderList.xhr.onload):
(requestBuilderList.xhr.onerror):
(onErrorLoadingBuilderList):
(loadBuildersList):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

  • TestResultServer/static-dashboards/run-unittests.html:
23:07 Changeset [119462] by eae@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed chromium windows rebaseline for r119456.

  • platform/chromium-win-vista/fast/multicol: Removed.
  • platform/chromium-win/fast/multicol/float-multicol-expected.png:
22:44 Changeset [119461] by eae@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed chromium test expectation updates for new tests.

  • fast/sub-pixel/inline-block-with-padding-expected.txt:
  • platform/chromium-mac/fast/sub-pixel: Added.
  • platform/chromium-mac/fast/sub-pixel/inline-block-with-padding-expected.txt: Added.
22:33 Changeset [119460] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fix a TestExpectations format error.

  • platform/chromium/TestExpectations:
22:20 Changeset [119459] by eae@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed chromium test and expectation updates for r119456.

  • fast/sub-pixel/inline-block-with-padding.html:
  • platform/chromium-mac-snowleopard/fast/events/offsetX-offsetY-expected.txt:
  • platform/chromium/TestExpectations:
22:06 LayoutUnit edited by eae@chromium.org
Updated status (diff)
22:01 Changeset [119458] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

Leaking ClipRects
https://bugs.webkit.org/show_bug.cgi?id=88282

Reviewed by Dan Bernstein.

In r118562 I made the ClipRectsCache use RefPtr<ClipRects>. However, ClipRects
was initialized with m_refCnt=0, not 1 as adoptRef() and friends expect. Also,
there was a manual ref() in RenderLayer::updateClipRects() which this patch removes.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateClipRects):

  • rendering/RenderLayer.h:

(WebCore::ClipRects::ClipRects):

21:49 Changeset [119457] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Python test fix attempt for Chromium Windows.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.uri_to_test):

21:42 Changeset [119456] by eae@chromium.org
  • 31 edits
    6 adds in trunk

Add missing FractionalLayoutUnit += operator and move LineWidth to use all floats
https://bugs.webkit.org/show_bug.cgi?id=88259

Patch by Emil A Eklund <eae@chromium.org> and Levi Weintraub <leviw@chromium.org> on 2012-06-04
Reviewed by Ryosuke Niwa.

Source/WebCore:

Fix two rounding bugs in LineLayout and RenderBlock that caused inlines
and floats to wrap incorrectly.

Tests: fast/sub-pixel/float-containing-block-with-margin.html

fast/sub-pixel/float-with-right-margin-zoom.html
fast/sub-pixel/inline-block-with-padding.html

  • platform/FractionalLayoutUnit.h:

(WebCore::operator+=):
Add missing float version of += operator thus avoiding a silent cast to
int loosing precision.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
(WebCore::LineWidth::updateAvailableWidth):
Change LineWidth left/right to floating point and instead of rounding the
left and right edge separately.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
Use explicit cast to avoid compiler ambiguity warning.

LayoutTests:

  • fast/dom/elementFromPoint-relative-to-viewport.html:
  • fast/events/offsetX-offsetY.html:

Remove special casing for subpixel layout as it is no longer needed.

  • fast/sub-pixel/float-containing-block-with-margin-expected.html: Added.
  • fast/sub-pixel/float-containing-block-with-margin.html: Added.
  • fast/sub-pixel/float-with-right-margin-zoom-expected.txt: Added.
  • fast/sub-pixel/float-with-right-margin-zoom.html: Added.
  • fast/sub-pixel/inline-block-with-padding-expected.txt: Added.
  • fast/sub-pixel/inline-block-with-padding.html: Added.

New tests for wrapping logic.

  • platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-linux/fast/line-grid/line-align-left-edges-expected.png:
  • platform/chromium-linux/fast/line-grid/line-grid-contains-value-expected.png:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.png:
  • platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
  • platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:

Update expectations to match pre-subpixel rendering.

  • platform/chromium/TestExpectations:

Mark updated tests as failing on mac and windows temporarily.

  • platform/chromium/fast/dom/elementFromPoint-relative-to-viewport-expected.txt:

Remove special casing for subpixel layout as it is no longer needed.

  • platform/chromium/fast/line-grid/line-align-left-edges-expected.txt:

Update expectations to match pre-subpixel rendering.

  • platform/efl/Skipped:
  • platform/gtk-wk2/Skipped:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:

Skip new sub-pixel tests on platforms that does not enable sub-pixel layout.

21:38 Changeset [119455] by tony@chromium.org
  • 14 edits in trunk

CSS property 'order' should be a number rather than an int
https://bugs.webkit.org/show_bug.cgi?id=88111

Reviewed by Ojan Vafai.

Source/WebCore:

This changed in the spec:
http://dev.w3.org/csswg/css3-flexbox/#order

I also fixed the compile with CSS3_FLEXBOX disabled.

No new tests, covered by existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp: Parse as float, remove clamping for HashMap<int>.

(WebCore::CSSProperty::isInheritedProperty):

  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderFlexibleBox.cpp: Remove traits for HashMap<int>.

(RenderFlexibleBox::OrderIterator):

  • rendering/RenderFlexibleBox.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html: Allow decimal values.
  • css3/flexbox/flex-order.html: Fix tests based on float limits.
21:29 Changeset [119454] by leo.yang@torchmobile.com.cn
  • 2 edits in trunk/LayoutTests

Syntax error in fast/filesystem/resources/file-writer-gc-blob.js
https://bugs.webkit.org/show_bug.cgi?id=87939

Reviewed by Alexey Proskuryakov.

  • fast/filesystem/resources/file-writer-gc-blob.js: Add parentheses around the blob data.

(startWrite):

21:11 FeatureFlags edited by tkent@chromium.org
Add LEGACY_VIEWPORT_ADAPTION (diff)
20:17 Changeset [119453] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Unreviewed.

Rolled out r119364 because it's still causing crashes (when running
v8-earley in release builds of DRT)

This time for sure!

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::resetAllocator):
(JSC):

  • heap/MarkedSpace.cpp:

(JSC::ResetAllocator::operator()):
(JSC):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::sweepWeakSets):

  • heap/MarkedSpace.h:

(MarkedSpace):

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::sweep):

  • heap/WeakSet.cpp:

(JSC::WeakSet::sweep):
(JSC::WeakSet::tryFindAllocator):

  • heap/WeakSet.h:

(JSC::WeakSet::shrink):

20:01 Changeset [119452] by commit-queue@webkit.org
  • 8 edits in trunk

Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
https://bugs.webkit.org/show_bug.cgi?id=88243

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-06-04
Reviewed by Adam Barth.

.:

  • Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

No new tests needed, this just rename a compiler flag.

  • dom/Document.cpp:

(WebCore::Document::setDocType):

  • dom/ViewportArguments.h:
  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

Tools:

  • qmake/mkspecs/features/features.prf:
19:13 Changeset [119451] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
https://bugs.webkit.org/show_bug.cgi?id=88280

Unreviewed, build fix.

  • Scripts/webkitpy/layout_tests/port/server_process_unittest.py:

(TestServerProcess.test_basic):

19:05 Changeset [119450] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip more tests on Windows to get the bots greener.

See r119449 for more context.

  • platform/win/Skipped:
18:10 Changeset [119449] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Start skipping all the failing tests on Windows to get the bots greener.

At this point it doesn't make sense to try to split the hundreds of failures out into
separate bugs and rebaseline. It makes more sense to use the Skipped list as a todo list
of things that need to be checked / updated for Windows.

18:10 Changeset [119448] by yosin@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebCore/css/SelectorChecker.cpp

Merge 118891 - REGRESSION(r111497): The "option" element doesn't match CSS pseudo class :enabled
https://bugs.webkit.org/show_bug.cgi?id=87719

Reviewed by Kent Tamura.

Source/WebCore:

This patch added checking of "option" element for CSS pseudo class :enabled as same as
:disabled to selector checker. Before r111497, it was done by using isFormControlElement.
After that revision, HTMLOptionElement was no longer derived from HTMLFormControlElement.

Test: fast/form/select/optgroup-rendering.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector): Checking element is option element as same
as PseudoDisabled in PseudoEnabled case.

LayoutTests:

  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Updated. Text color of option element is bule from CSS pseudo class option:enabled.
  • platform/chromium/test_expectations.txt: Update comment.

TBR=yosin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10477022

18:07 Changeset [119447] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Remove redundant setNeedsCommit when prepareToDraw fails
https://bugs.webkit.org/show_bug.cgi?id=88246

Reviewed by James Robinson.

Source/WebCore:

When prepareToDraw fails it explicitly calls setNeedsCommit, but the
scheduler already takes care of this for it. When a frame is not
successfully drawn, the scheduler state machine sets the needsCommit
bit itself.

This behaviour is covered by CCSchedulerStateMachineTest.TestFailedDrawSetsNeedsCommitAndDoesNotDrawAgain

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::prepareToDraw):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
17:51 Changeset [119446] by toyoshim@chromium.org
  • 4 edits
    1 add in trunk/Source

[WebSocket] Send requires super linear time against data size
https://bugs.webkit.org/show_bug.cgi?id=87383

Reviewed by Kent Tamura.

Source/WebCore:

WebSocket send operation requires super linear time to send data
against data size. This is because removing sent data in Vector<char>
always requires data copy.
Introduced wtf/StreamBuffer realizes O(n) buffer operations.
This patch is only for optimization. No new tests are needed.

  • platform/network/SocketStreamHandleBase.cpp:

(WebCore::SocketStreamHandleBase::sendPendingData):

  • platform/network/SocketStreamHandleBase.h:

(SocketStreamHandleBase):

Source/WTF:

  • wtf/StreamBuffer.h: Added.

(WTF):
(StreamBuffer):
(WTF::StreamBuffer::StreamBuffer):
(WTF::StreamBuffer::~StreamBuffer):
(WTF::StreamBuffer::isEmpty):
(WTF::StreamBuffer::append):
(WTF::StreamBuffer::consume):
(WTF::StreamBuffer::size):
(WTF::StreamBuffer::firstBlockData):
(WTF::StreamBuffer::firstBlockSize):

17:37 Changeset [119445] by dpranke@chromium.org
  • 3 edits in trunk/Tools

test-webkitpy is hanging under cygwin
https://bugs.webkit.org/show_bug.cgi?id=88269

Reviewed by Ryosuke Niwa.

The 'multiprocessing' module doesn't work correctly under Cygwin yet,
so we need to skip any tests that use it.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.run_in_parallel):

  • Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.test_run_in_parallel):

17:28 Changeset [119444] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG arguments simplification should have rationalized handling of TearOffArguments
https://bugs.webkit.org/show_bug.cgi?id=88206

Reviewed by Geoffrey Garen.

  • Accesses to the unmodified arguments register ought to have the same effect on alias/escape analysis of arguments as accesses to the mutable arguments register.


  • The existence of TearOffArguments should not get in the way of arguments aliasing.


  • TearOffArguments should be eliminated if CreateArguments is eliminated.
  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):

17:27 Changeset [119443] by dpranke@chromium.org
  • 4 edits
    1 add in trunk/Tools

test-webkitpy is failing on win32 after r115054
https://bugs.webkit.org/show_bug.cgi?id=88264

Reviewed by Ryosuke Niwa.

The failing http_server test was improperly suppressed (the
tuple was missing a comma, and so wasn't a tuple at all, just a
string) and so we were skipping *all* tests on win32. The right
way to skip a single test is to disable it inside the test
itself.

  • Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:

(TestHttpServer.test_start_cmd):

  • Scripts/webkitpy/test/test_finder.py:

(TestFinder._default_names):

  • Scripts/webkitpy/test/main.py:

(Tester.run): Add error message if we don't find any tests to run.

  • Scripts/webkitpy/test/main_unittest.py:
17:21 Changeset [119442] by timothy_horton@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed new baseline for test added in r119423.

  • platform/mac/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/mac/fast/hidpi/device-scale-factor-paint-expected.txt: Added.
17:00 Changeset [119441] by barraclough@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Remove enabledProfilerReference
https://bugs.webkit.org/show_bug.cgi?id=88258

Reviewed by Michael Saboff.

Make the enabled profiler a member of JSGlobalData, and switch code that accesses it to do so directly
via the JSGlobalData, rather than holding a Profiler reference to it. Do not pass the Profiler
reference to JIT code. This patch does not change the stack layout on entry into JIT code (passing an
unused void* instead), since this is an intrusive change better handled in a separate patch.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):

  • jit/JITCode.h:

(JSC::JITCode::execute):

  • Don't pass Profiler to JIT code.
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):

  • jit/JITStubs.cpp:

(JSC):
(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):
(JSC::JITThunks::JITThunks):
(JSC::DEFINE_STUB_FUNCTION):

  • For ARM_THUMB2, rename ENABLE_PROFILER_REFERENCE_OFFSET to FIRST_STACK_ARGUMENT (which is how it is being used).
  • For MIPS, remove ENABLE_PROFILER_REFERENCE_OFFSET.
  • jit/JITStubs.h:

(JITStackFrame):
(JSC):

  • Renamed enabledProfilerReference to unusedX.
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • profiler/Profiler.cpp:

(JSC):
(JSC::Profiler::startProfiling):
(JSC::Profiler::stopProfiling):

  • profiler/Profiler.h:

(Profiler):

  • Removed s_sharedEnabledProfilerReference, enabledProfilerReference().
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC):
(JSC::JSGlobalData::enabledProfiler):
(JSGlobalData):

  • Added m_enabledProfiler, enabledProfiler().
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::~JSGlobalObject):

16:45 Changeset [119440] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Mock scrollbars differ by 1px in DRT vs. WKTR
https://bugs.webkit.org/show_bug.cgi?id=80879

Rubber-stamped by Ryosuke Niwa.

Disable r119431 except for Apple Mac port.

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::thumbLength):

16:38 Changeset [119439] by jpfau@apple.com
  • 2 edits in trunk/Source/WebCore

Document cleanup can get confused if parser still exists
https://bugs.webkit.org/show_bug.cgi?id=88250

Reviewed by Geoffrey Garen.

No new tests; no behavior changes.

  • dom/Document.cpp:

(WebCore::Document::removedLastRef): Detach parser earlier

16:32 Changeset [119438] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

get_argument_by_val should be profiled everywhere
https://bugs.webkit.org/show_bug.cgi?id=88205

Reviewed by Geoffrey Garen.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_get_argument_by_val):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

16:27 Changeset [119437] by fpizlo@apple.com
  • 6 edits
    12 adds in trunk

DFG arguments simplification takes unkindly to direct accesses to the arguments register
https://bugs.webkit.org/show_bug.cgi?id=88261

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Fixed arguments simplification for direct accesses to the arguments register, which may
arise if CSE had not run. Fixed CSE so that it does run prior to arguments simplification,
by making it a full-fledged member of the fixpoint. Fixed other issues in arguments
simplification, like realizing that it needs to bail if there is a direct assignment to
the arguments register, and failing to turn CreateArguments into PhantomArguments. Also
fixed CSE's handling of store elimination of captured locals in the presence of a
GetMyArgumentByVal (or one of its friends), and fixed CSE to correctly fixup variables at
tail if the Flush it removes is the last operation on a local in a basic block.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(CSEPhase):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

LayoutTests:

Reviewed by Geoffrey Garen.

  • fast/js/dfg-arguments-alias-one-block-expected.txt: Added.
  • fast/js/dfg-arguments-alias-one-block-osr-exit-expected.txt: Added.
  • fast/js/dfg-arguments-alias-one-block-osr-exit.html: Added.
  • fast/js/dfg-arguments-alias-one-block-overwrite-arguments-expected.txt: Added.
  • fast/js/dfg-arguments-alias-one-block-overwrite-arguments.html: Added.
  • fast/js/dfg-arguments-alias-one-block-overwrite-expected.txt: Added.
  • fast/js/dfg-arguments-alias-one-block-overwrite.html: Added.
  • fast/js/dfg-arguments-alias-one-block.html: Added.
  • fast/js/script-tests/dfg-arguments-alias-one-block-osr-exit.js: Added.

(foo):

  • fast/js/script-tests/dfg-arguments-alias-one-block-overwrite-arguments.js: Added.

(foo):

  • fast/js/script-tests/dfg-arguments-alias-one-block-overwrite.js: Added.

(foo):

  • fast/js/script-tests/dfg-arguments-alias-one-block.js: Added.

(foo):

16:25 Changeset [119436] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[BlackBerry] Split AnimationFrameRateController into its own file
https://bugs.webkit.org/show_bug.cgi?id=88242

Patch by Andrew Lo <anlo@rim.com> on 2012-06-04
Reviewed by Antonio Gomes.

Include new header file to reflect re-organization of platform animation
header files.

Source/WebCore:

  • platform/graphics/DisplayRefreshMonitor.h:

Source/WebKit/blackberry:

  • Api/WebPageCompositor_p.h:
16:19 Changeset [119435] by danakj@chromium.org
  • 11 edits in trunk/Source

[chromium] Allow CCLayerImpl to find its layer tree host, and use this for CCVideoLayerImpl instead of always-null pointer.
https://bugs.webkit.org/show_bug.cgi?id=88252

Reviewed by James Robinson.

Source/WebCore:

CCVideoLayerImpl has a pointer to its CCLayerTreeHostImpl which is never
set to be non-null currently. Instead of making this a special case, we
move the CCLayerTreeHostImpl* up to the CCLayerImpl base class, and set
the pointer on every layer during commit via the TreeSynchronizer's walk
through the layer tree.

Unit tests: Tested by TreeSynchronizer tests.

  • platform/graphics/chromium/TreeSynchronizer.cpp:

(WebCore::TreeSynchronizer::synchronizeTrees):
(WebCore::TreeSynchronizer::synchronizeTreeRecursive):

  • platform/graphics/chromium/TreeSynchronizer.h:

(WebCore):
(TreeSynchronizer):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):
(WebCore::CCLayerImpl::layerTreeHostImpl):
(WebCore::CCLayerImpl::setLayerTreeHostImpl):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::setNeedsRedraw):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

Source/WebKit/chromium:

  • tests/ScrollbarLayerChromiumTest.cpp:

(WebCore::TEST):

  • tests/TreeSynchronizerTest.cpp:

(WebKitTests::expectTreesAreIdentical):
(WebKitTests::TEST):

16:03 Changeset [119434] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

yet another build fix attempt.

  • src/WebHelperPluginImpl.cpp:
15:52 Changeset [119433] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Another Chromium Windows build fix attempt after r119411.

  • src/WebHelperPluginImpl.cpp:
15:26 Changeset [119432] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] CCDamageTrackerTest.verifyDamageForPerspectiveClippedLayer needs to be cleaner
https://bugs.webkit.org/show_bug.cgi?id=85245

Reviewed by James Robinson.

Updated CCDamageTrackerTest.verifyDamageForPerspectiveClippedLayer
so that the test is clearer and cleaner. The original test was
covering what it needed, but in a confusing and not-so-practical
way. This patch adds comments and performs a tighter test so that
the intent is a bit more clear.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

15:25 Changeset [119431] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Mock scrollbars differ by 1px in DRT vs. WKTR
https://bugs.webkit.org/show_bug.cgi?id=80879

Reviewed by Simon Fraser.

Round the length of the scrollbar thumb instead of truncating it.

No new tests, fixes a mismatch between pixel results from DRT and WKTR.
Change is covered by all existing tests with scrollbars run with low tolerance.

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::thumbLength):

15:24 Changeset [119430] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix an unused result warning when building with clang.

  • platform/cf/BinaryPropertyList.cpp:

(WebCore::BinaryPropertyListWriter::writePropertyList):

14:56 Changeset [119429] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix a struct/class mismatch.

  • heap/Handle.h:

(Handle):

14:47 Changeset [119428] by fischman@chromium.org
  • 3 edits
    2 adds in trunk

Don't crash when re-parenting a removed HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=88058

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-reparent.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::userCancelledLoad): Clear the pending load flags because any pending load has been cancelled.

LayoutTests:

  • media/media-reparent-expected.txt: Added.
  • media/media-reparent.html: Added.
14:41 Changeset [119427] by jchaffraix@webkit.org
  • 1 edit in branches/chromium/1132/Source/WebCore/rendering/FixedTableLayout.cpp

Merge 118819 - REGRESSION(r111742): box-sizing: border-box doesn't work on fixed table layout
https://bugs.webkit.org/show_bug.cgi?id=87536

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout.html

fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout.html
fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout.html
fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout.html

The change in r111742 completely ignored border-sizing (following the table's code lead unfortunately).
The issue is that we would count the borders and paddings twice for the border-box case which would lead
to the content-box including them too. From a web-author, this behavior is equivalent to ignoring box-sizing.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
Reworked the function to properly use computeBorderBoxLogicalWidth() for correctness. This matches
what RenderBox and the rendering code does generally. Also refactored the code to avoid the need
for local variables and make it more readable.

LayoutTests:

  • fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/cell-box-sizing-fixed-table-layout.html: Added.

This test covers the regression.

  • fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/column-box-sizing-fixed-table-layout.html: Added.
  • fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/column-group-box-sizing-fixed-table-layout.html: Added.
  • fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout-expected.html: Added.
  • fast/table/fixed-table-layout/column-in-column-group-box-sizing-fixed-table-layout.html: Added.

Those test ensured I didn't regress and document our current behavior ie that column and column group fixed
width apply to the cell's border-box.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10479019

14:35 Changeset [119426] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r119421 and r119425.
http://trac.webkit.org/changeset/119421
http://trac.webkit.org/changeset/119425
https://bugs.webkit.org/show_bug.cgi?id=88256

not reliable, let's have a do-over (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-04

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::createAttributeData):
(WebCore):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::cloneAttributesFromElement):

  • dom/Element.h:

(WebCore::Element::attributeData):
(Element):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::setClass):
(WebCore):
(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::destroyInlineStyle):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::isEquivalent):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute):
(WebCore::ElementAttributeData::getAttributeNode):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::create):
(ElementAttributeData):
(WebCore::ElementAttributeData::setIdForStyleResolution):
(WebCore::ElementAttributeData::setAttributeStyle):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(WebCore::ElementAttributeData::getAttributeItemIndex):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::style):
(WebCore::StyledElement::classAttributeChanged):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

13:23 Changeset [119425] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fixes for cr-android and Qt.

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::setClass):
Change ElementAttributeData::setClass() to take an AtomicString instead of a String.
The only call site has an AtomicString anyway.

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser): Add missing const.

13:14 Changeset [119424] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Fix attempt after r119411.

  • src/WebHelperPluginImpl.cpp:
13:11 Changeset [119423] by commit-queue@webkit.org
  • 15 edits
    3 adds in trunk

.: [chromium] Fix software rendering for device-scale-factor > 1
https://bugs.webkit.org/show_bug.cgi?id=88136

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

Export WebCore::Page::setDeviceScaleFactor and WebCore::Settings::setDefaultDeviceScaleFactor.

  • Source/autotools/symbols.filter:

Source/WebCore: [chromium] Fix software rendering for device-scale-factor > 1
https://bugs.webkit.org/show_bug.cgi?id=88136

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

Test: fast/hidpi/device-scale-factor-paint.html

  • WebCore.exp.in:
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setDeviceScaleFactor):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium: [chromium] Fix software rendering for larger device-scale-factor
https://bugs.webkit.org/show_bug.cgi?id=88136

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

The fix is to apply the device-scale factor on the GraphicsContext.
(and add a WebWidgetClient::deviceScaleFactor method to facilitate that).

  • public/WebWidgetClient.h:

(WebWidgetClient):
(WebKit::WebWidgetClient::deviceScaleFactor):

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::paint):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::paint):

Source/WebKit2: [chromium] Fix software rendering for device-scale-factor > 1
https://bugs.webkit.org/show_bug.cgi?id=88136

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

Export WebCore::Page::setDeviceScaleFactor and WebCore::Settings::setDefaultDeviceScaleFactor.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests: [chromium] Fix software rendering for device-scale-factor > 1
https://bugs.webkit.org/show_bug.cgi?id=88136

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

  • fast/hidpi/device-scale-factor-paint.html: Added.
  • platform/chromium/fast/hidpi/device-scale-factor-paint-expected.html: Added.
13:10 Changeset [119422] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Memory leaks in AccessibilityUIElementGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=88215

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-04
Reviewed by Martin Robinson.

Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
for newly allocated strings.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(attributeSetToString):
(AccessibilityUIElement::allAttributes):

13:00 Changeset [119421] by kling@webkit.org
  • 8 edits in trunk/Source/WebCore

Make ElementAttributeData a variable-sized object to reduce memory use.
<http://webkit.org/b/88240>

Reviewed by Antti Koivisto.

Take advantage of the fact that we know at ElementAttributeData construction time how many attributes
it needs to accomodate and allocate exactly as much space as needed instead of using a Vector.
For elements that never have their attribute list mutated (the vast majority), this saves a lot of
memory and removes the indirection to Vector<Attribute>'s heap-allocated storage.

Introduced a mutability flag to ElementAttributeData and sprinkled assertions all over to make sure
that nothing tries to mutate an element with a raw attribute array.

When an Element's attribute(s) are mutated, we reconstruct the ElementAttributeData, this time using
a Vector as backing instead. This is triggered when calling Element::mutableAttributeData().

This reduces memory consumption by 3.2MB when viewing the full HTML5 spec at <http://whatwg.org/c/>.
This is a 35% reduction in DOM attribute memory use.

Furthermore, that page ends up promoting 27% of the elements to mutable attribute storage due to dynamic
adding of "class" attributes. For more static pages, savings are even greater.

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createMutableAttributeData):

  • dom/Element.h:

(WebCore::Element::attributeData):
(Element):
(WebCore::Element::updatedAttributeData):
(WebCore::Element::ensureAttributeData):
(WebCore::Element::ensureUpdatedAttributeData):
(WebCore::Element::mutableAttributeData):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::ElementAttributeData::~ElementAttributeData):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::ensureInlineStyle):
(WebCore::ElementAttributeData::ensureMutableInlineStyle):
(WebCore::ElementAttributeData::destroyInlineStyle):
(WebCore::ElementAttributeData::addAttribute):
(WebCore::ElementAttributeData::removeAttribute):
(WebCore::ElementAttributeData::isEquivalent):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::getAttributeItemIndexSlowCase):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::replaceAttribute):
(WebCore::ElementAttributeData::getAttributeNode):

  • dom/ElementAttributeData.h:

(ElementAttributeData):
(WebCore::ElementAttributeData::setClass):
(WebCore::ElementAttributeData::setIdForStyleResolution):
(WebCore::ElementAttributeData::inlineStyle):
(WebCore::ElementAttributeData::setAttributeStyle):
(WebCore::ElementAttributeData::isMutable):
(WebCore::ElementAttributeData::makeMutable):
(WebCore::ElementAttributeData::length):
(WebCore::ElementAttributeData::isEmpty):
(WebCore::ElementAttributeData::array):
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::style):
(WebCore::StyledElement::classAttributeChanged):
(WebCore::StyledElement::removeInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

12:56 Changeset [119420] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Source/WebCore: [chromium] Combobox options and autofill options should not be scaled for device-scale factor
https://bugs.webkit.org/show_bug.cgi?id=87921

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

Chrome takes care of scaling the combobox/autofill lists in the browser side. So it is not
necessary to scale here. This change reverts parts of changes in r111539.

Manually tested with different scale factors.

  • platform/chromium/PopupListBox.cpp:

(WebCore::PopupListBox::paint):
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::getRowHeight):

  • platform/chromium/PopupListBox.h:

(PopupContainerSettings):

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupMenuChromium::show):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

Source/WebKit/chromium: Combobox options and autofill options should not be scaled for device-scale factor.
https://bugs.webkit.org/show_bug.cgi?id=87921

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::applyAutofillSuggestions):

12:53 Changeset [119419] by danakj@chromium.org
  • 19 edits
    2 moves in trunk/Source

[chromium] Make LayerRendererChromium use RenderPasses instead of RenderSurfaces
https://bugs.webkit.org/show_bug.cgi?id=88132

Reviewed by Adrienne Walker.

Source/WebCore:

This patch is partly renaming, partly moving data into CCRenderPass
and CCRenderPassDrawQuad. LayerRendererChromium should accept as input
a set of RenderPasses and this should be sufficient for drawing. It
should have no notion of RenderSurfaces at all.

First, what isn't done: RenderSurfaces still hold the textures
where RenderPasses are drawn to/from, so that these textures can
persist across frames. This will be addressed separately.

Otherwise, this completely removes the concept of RenderSurface from
LayerRenderChromium and the CCDrawQuad, replacing it with RenderPass.
The "renderSurfaceTextureManager" is renamed to the "implTextureManager"
and like-wise for the TextureAllocator, as these are not used
exclusively for render surfaces (passes), and a texture manager for
render passes that does not require a RenderSurface* will be the focus
of future changes.

Covered by existing tests.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::setVisible):
(WebCore::LayerRendererChromium::releaseRenderPassTextures):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::clearRenderPass):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::copyPlaneToTexture):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::isCurrentRenderPass):
(WebCore::LayerRendererChromium::useRenderPass):
(WebCore::LayerRendererChromium::useManagedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawFramebufferRect):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::renderPassProgram):
(WebCore::LayerRendererChromium::renderPassProgramAA):
(WebCore::LayerRendererChromium::renderPassMaskProgram):
(WebCore::LayerRendererChromium::renderPassMaskProgramAA):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCQuadCuller.cpp:
  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::CCRenderPass):
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):
(WebCore::CCRenderPass::framebufferOutputRect):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp.

(WebCore):
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h.

(WebCore):
(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPass):
(WebCore::CCRenderPassDrawQuad::isReplica):
(WebCore::CCRenderPassDrawQuad::maskTextureId):
(WebCore::CCRenderPassDrawQuad::filters):
(WebCore::CCRenderPassDrawQuad::backgroundFilters):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::prepareBackgroundTexture):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::willDraw):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::reserveTextures):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):
(FakeCCRendererClient::rootRenderPass):
(FakeCCRendererClient):
(TEST_F):

12:52 Changeset [119418] by commit-queue@webkit.org
  • 2 edits in trunk

[chromium] Issue async events for console.time/timeEnd
https://bugs.webkit.org/show_bug.cgi?id=88003

Patch by Kevin Greer <kgr@chromium.org> on 2012-06-04
Reviewed by Pavel Feldman.

  • ../../Source/WebCore/page/Console.cpp:
12:36 Changeset [119417] by aestes@apple.com
  • 6 edits in trunk/Source/WebKit2

Use ENABLE() and USE() macros in a few more places
https://bugs.webkit.org/show_bug.cgi?id=88245

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPluginSiteDataManager.cpp: Only include npapi.h if

Netscape plug-in API is enabled.

  • UIProcess/mac/CorrectionPanel.h: Wrap with USE(AUTOCORRECTION_PANEL)
  • WebProcess/Authentication/AuthenticationManager.cpp: Use the stub

version of tryUsePlatformCertificateInfoForChallenge if
Security.framework isn't available.

  • WebProcess/WebProcess.messages.in: Only generate two messages if

Security.framework is available.

  • WebProcess/mac/KeychainItemShimMethods.mm: Wrap with

USE(SECURITY_FRAMEWORK).

12:30 Changeset [119416] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Memory leaks in DumpRenderTree.cpp
https://bugs.webkit.org/show_bug.cgi?id=88213

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-04
Reviewed by Martin Robinson.

Fixed memory leaks in DumpRenderTree.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(appendString): Accepts const gchar* as the second argument.
(dumpFramesAsText): Free the string returned by g_strdup_printf().
(dumpHistoryItem): Free the string returned by g_uri_parse_scheme().

12:26 Changeset [119415] by fischman@chromium.org
  • 2 edits in trunk/LayoutTests

[Gtk] http/tests/media/video-buffered.html is failing after r119268
https://bugs.webkit.org/show_bug.cgi?id=88138

Reviewed by Eric Carlson.

  • http/tests/media/video-buffered.html:
12:22 Changeset [119414] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Speed up video-media-source-play & video-media-source-seek LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=87986

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-06-04
Reviewed by Eric Carlson.

  • http/tests/media/media-source/video-media-source-play.html: Updated test to only play 1 second of media data instead of ~3 seconds.
  • http/tests/media/media-source/video-media-source-seek-expected.txt:
  • http/tests/media/media-source/video-media-source-seek.html:
    • Triggers seek after playing 0.5 seconds instead of 2 seconds.
    • Seeks to the last segment instead of a segment that is ~2 seconds from the end.
    • Added an webkitSourceAbort() call before appending the segments for the seek. This is to prevent this test from failing when the old v0.3 "flush on seek" behavior is removed from the Chromium code.
12:21 Changeset [119413] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

Add stub WebKit2 implementations of PLUGIN_PROXY_FOR_VIDEO methods declared in FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=88244

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createMediaPlayerProxyPlugin): Add a stub implementation.
(WebKit::WebFrameLoaderClient::hideMediaPlayerProxyPlugin): Ditto.
(WebKit::WebFrameLoaderClient::showMediaPlayerProxyPlugin): Ditto.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
12:14 Changeset [119412] by paroga@webkit.org
  • 2 edits in trunk/Source/WTF

Port RAMSize to WinCE
https://bugs.webkit.org/show_bug.cgi?id=87854

Reviewed by Geoffrey Garen.

WinCE has no GlobalMemoryStatusEx() function. Use GlobalMemoryStatus() instead.

  • wtf/RAMSize.cpp:

(WTF::computeRAMSize):

12:03 Changeset [119411] by commit-queue@webkit.org
  • 14 edits
    1 copy
    2 adds in trunk

Enable Chromium media player to instantiate a plugin
https://bugs.webkit.org/show_bug.cgi?id=87399

Patch by David Dorwin <ddorwin@chromium.org> on 2012-06-04
Reviewed by Kent Tamura.

Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebHelperPlugin.h: Copied from Source/WebKit/chromium/public/WebPopupType.h.

(WebKit):
(WebHelperPlugin):
(WebKit::WebHelperPlugin::~WebHelperPlugin):

  • public/WebMediaPlayerClient.h:

(WebKit):

  • public/WebPopupType.h:
  • public/WebView.h:
  • public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::initializeHelperPluginWebFrame):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::WebFrameImpl):
(WebKit::WebFrameImpl::initializeAsMainFrame):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebHelperPluginImpl.cpp: Added.

(WebKit):
(WebKit::addString):
(WebKit::writeDocument):
(HelperPluginChromeClient):
(WebKit::HelperPluginChromeClient::HelperPluginChromeClient):
(WebKit::WebHelperPluginImpl::WebHelperPluginImpl):
(WebKit::WebHelperPluginImpl::~WebHelperPluginImpl):
(WebKit::WebHelperPluginImpl::init):
(WebKit::WebHelperPluginImpl::initializeFrame):
(WebKit::WebHelperPluginImpl::initPage):
(WebKit::WebHelperPluginImpl::setCompositorSurfaceReady):
(WebKit::WebHelperPluginImpl::composite):
(WebKit::WebHelperPluginImpl::layout):
(WebKit::WebHelperPluginImpl::setFocus):
(WebKit::WebHelperPluginImpl::close):
(WebKit::WebHelperPluginImpl::closeHelperPlugin):
(WebKit::WebHelperPlugin::create):

  • src/WebHelperPluginImpl.h: Copied from Source/WebKit/chromium/public/WebPopupType.h.

(WebCore):
(WebKit):
(WebHelperPluginImpl):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::createHelperPlugin):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::closeHelperPlugin):

  • src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::initializeMainFrame):
(WebKit::WebViewImpl::initializeHelperPluginFrame):
(WebKit):
(WebKit::WebViewImpl::createHelperPlugin):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createPopupMenu):

11:30 Changeset [119410] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Remove obsolete acceptMIMETypes member.
https://bugs.webkit.org/show_bug.cgi?id=88241

Patch by Raymes Khoury <raymes@chromium.org> on 2012-06-04
Reviewed by Darin Fisher.

Obsoleted by https://bugs.webkit.org/show_bug.cgi?id=87271 and http://codereview.chromium.org/10414085/.

  • public/WebFileChooserParams.h:

(WebFileChooserParams):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel):

11:06 Changeset [119409] by inferno@chromium.org
  • 3 edits
    4 adds in trunk

Crash in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=88022

Reviewed by Ojan Vafai.

Source/WebCore:

The patch addresses two problems::

  1. |this| in RenderBlock::splitBlocks can get destroyed when we

move its children to the clone and later call updateBeforeAfterContent
on the parent. So, we stop accessing its member variables and cache
it in a local.

  1. Positioned objects were not getting cleared from our grand parents.

This will happen if our immediate children got moved to a clone tree,
however at our parent nothing was moved. So, we make sure to remove
the positioned objects at every level while we are doing the cloning.

Tests: fast/multicol/span/empty-anonymous-block-split-crash.html

fast/multicol/span/positioned-objects-not-removed-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

  • fast/multicol/span/empty-anonymous-block-split-crash-expected.txt: Added.
  • fast/multicol/span/empty-anonymous-block-split-crash.html: Added.
  • fast/multicol/span/positioned-objects-not-removed-crash-expected.txt: Added.
  • fast/multicol/span/positioned-objects-not-removed-crash.html: Added.
11:04 Changeset [119408] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

Mac build fails with SVG disabled
https://bugs.webkit.org/show_bug.cgi?id=88165

Reviewed by Dirk Schulze.

Wrap all of SVGCSSPropertyNames in #if ENABLE(SVG),
and mark an unused argument in collectMatchingRulesForList.

  • css/SVGCSSPropertyNames.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

11:01 Changeset [119407] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX: Unused variable with ENABLE(CONTEXT_MENUS) off

This broke in r118374.

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu): Add
UNUSED_PARAM(exec) when ENABLE(CONTEXT_MENUS) is off.

10:07 Changeset [119406] by tony@chromium.org
  • 2 edits
    10 moves in trunk/LayoutTests

Rename CSS flexbox test files to match new property names
https://bugs.webkit.org/show_bug.cgi?id=88174

Reviewed by Ojan Vafai.

flex-pack became justify-content and flex-line-pack became
align-content. Rename the tests to match the new names.

  • css3/flexbox/flex-justify-content-expected.txt: Renamed from LayoutTests/css3/flexbox/flex-pack-expected.txt.
  • css3/flexbox/flex-justify-content.html: Renamed from LayoutTests/css3/flexbox/flex-pack.html.
  • css3/flexbox/multiline-align-content-expected.txt: Renamed from LayoutTests/css3/flexbox/multiline-line-pack-expected.txt.
  • css3/flexbox/multiline-align-content-horizontal-column-expected.txt: Renamed from LayoutTests/css3/flexbox/multiline-line-pack-horizontal-column-expected.txt.
  • css3/flexbox/multiline-align-content-horizontal-column.html: Renamed from LayoutTests/css3/flexbox/multiline-line-pack-horizontal-column.html.
  • css3/flexbox/multiline-align-content.html: Renamed from LayoutTests/css3/flexbox/multiline-line-pack.html.
  • css3/flexbox/multiline-align-self-expected.txt: Renamed from LayoutTests/css3/flexbox/multiline-align-expected.txt.
  • css3/flexbox/multiline-align-self.html: Renamed from LayoutTests/css3/flexbox/multiline-align.html.
  • css3/flexbox/multiline-justify-content-expected.txt: Renamed from LayoutTests/css3/flexbox/multiline-pack-expected.txt.
  • css3/flexbox/multiline-justify-content.html: Renamed from LayoutTests/css3/flexbox/multiline-pack.html.
  • platform/chromium/TestExpectations:
10:05 Changeset [119405] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

Fix a couple flexbox tests to use flex-start and flex-end
https://bugs.webkit.org/show_bug.cgi?id=88170

Reviewed by Ojan Vafai.

This test was still using start/end for align-self, which fallback
to stretch. The test still passed because it is testing that all
values of align-self behave the same and stretch produced the same
behavior as flex-start/flex-end.

  • css3/flexbox/cross-axis-scrollbar.html:
09:05 Changeset [119404] by mario@webkit.org
  • 7 edits
    2 adds in trunk

[GTK][WK2] Implement geolocation provider for the GTK port
https://bugs.webkit.org/show_bug.cgi?id=83877

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Add a new client-based geolocation provider for WebKit2GTK+, relying the
new Geoclue-based geolocation provider available in WebCore.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UIProcess/API/gtk/WebKitGeolocationProvider.cpp: Added.

(toGeolocationProvider):
(startUpdatingCallback):
(stopUpdatingCallback):
(WebKitGeolocationProvider::~WebKitGeolocationProvider):
(WebKitGeolocationProvider::create):
(WebKitGeolocationProvider::WebKitGeolocationProvider):
(WebKitGeolocationProvider::startUpdating):
(WebKitGeolocationProvider::stopUpdating):
(WebKitGeolocationProvider::notifyPositionChanged):
(WebKitGeolocationProvider::notifyErrorOccurred):

  • UIProcess/API/gtk/WebKitGeolocationProvider.h: Added.
  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(_WebKitWebContextPrivate):
(createDefaultWebContext):

Tools:

  • gtk/generate-gtkdoc:

(get_webkit2_options): Ignore WebKitGeolocationProvider files.

09:02 Changeset [119403] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r119393.
http://trac.webkit.org/changeset/119393
https://bugs.webkit.org/show_bug.cgi?id=88236

Test is incorrect (duplicate content) and is causing Chromium
failures (Requested by schenney on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-04

Source/WebCore:

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

LayoutTests:

  • fast/canvas/drawImage-clipped-source-expected.txt: Removed.
  • fast/canvas/drawImage-clipped-source.html: Removed.
  • fast/canvas/drawImage-clipped-source.js: Removed.
08:50 Changeset [119402] by pdr@google.com
  • 4 edits in trunk/LayoutTests

Update test expectations after 119392
https://bugs.webkit.org/show_bug.cgi?id=88230

Unreviewed update of test expectations.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
08:42 Changeset [119401] by commit-queue@webkit.org
  • 30 edits in trunk/Source

[chromium] Cleanup scissor rect computation/use with damage
https://bugs.webkit.org/show_bug.cgi?id=87167

Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-04
Reviewed by Adrienne Walker.

Source/WebCore:

Performing scissorRect computation during
calculateRenderPasses. Storing scissorRect in shared quad state
instead of computing it during drawQuad. Added scissorRect fields
into layers and render surfaces.

Covered by existing layout tests. Introduced more unit tests to
test end-to-end drawing using mock graphic context, and added more
test cases to CCLayerTreeHostCommon to verify scissorRect computation.

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::scissorRect):
(WebCore::LayerChromium::setScissorRect):
(LayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:

(WebCore::RenderSurfaceChromium::computeRootScissorRectInCurrentSurface):
(WebCore):

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(WebCore::RenderSurfaceChromium::scissorRect):
(WebCore::RenderSurfaceChromium::setScissorRect):
(RenderSurfaceChromium):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore::CCDrawQuad::scissorRect):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::createSharedQuadState):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::scissorRect):
(WebCore::CCLayerImpl::setScissorRect):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore):
(WebCore::calculateLayerScissorRect):
(WebCore::calculateSurfaceScissorRect):
(WebCore::calculateDrawTransformsInternal):
(WebCore::calculateVisibleAndScissorRectsInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):
(WebCore::CCLayerTreeHostCommon::calculateVisibleAndScissorRects):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::swapBuffers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore):
(WebCore::CCRenderSurface::computeRootScissorRectInCurrentSurface):
(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):
(WebCore::CCRenderSurface::setScissorRect):
(WebCore::CCRenderSurface::scissorRect):

  • platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp:

(WebCore::CCRenderSurfaceDrawQuad::create):
(WebCore::CCRenderSurfaceDrawQuad::CCRenderSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h:

(CCRenderSurfaceDrawQuad):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

  • platform/graphics/chromium/cc/CCSharedQuadState.cpp:

(WebCore::CCSharedQuadState::create):
(WebCore::CCSharedQuadState::CCSharedQuadState):

  • platform/graphics/chromium/cc/CCSharedQuadState.h:

(CCSharedQuadState):
(WebCore::CCSharedQuadState::scissorRect):

Source/WebKit/chromium:

Added unit tests to CCLayerTreeHostImpl using mock graphic context
to verify end-to-end quad drawing.

Added more test cases to CCLayerTreeHostCommon to verify clip and
scissor rect computations.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::executeCalculateDrawTransformsAndVisibility):

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):

  • tests/CCRenderSurfaceTest.cpp:
08:30 Changeset [119400] by commit-queue@webkit.org
  • 13 edits
    2 moves in trunk/Source/WebKit2

[Qt][WK2] Rename QtViewportInteractionEngine to QtViewportHandler.
https://bugs.webkit.org/show_bug.cgi?id=88226

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-06-04
Reviewed by Kenneth Rohde Christiansen.

  • Target.pri:
  • UIProcess/API/qt/qquickwebpage_p_p.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::~QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):

  • UIProcess/API/qt/qquickwebview_p.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(WebKit):
(QQuickWebViewPrivate::viewportHandler):
(QQuickWebViewFlickablePrivate::viewportHandler):
(QQuickWebViewFlickablePrivate):

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::contentsScale):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::initialScale):
(QWebKitTest::minimumScale):
(QWebKitTest::maximumScale):
(QWebKitTest::isScalable):
(QWebKitTest::layoutSize):

  • UIProcess/qt/QtGestureRecognizer.cpp:

(WebKit::QtGestureRecognizer::viewportHandler):

  • UIProcess/qt/QtGestureRecognizer.h:

(WebKit):

  • UIProcess/qt/QtPanGestureRecognizer.cpp:

(WebKit::QtPanGestureRecognizer::update):
(WebKit::QtPanGestureRecognizer::finish):
(WebKit::QtPanGestureRecognizer::cancel):

  • UIProcess/qt/QtPinchGestureRecognizer.cpp:

(WebKit::QtPinchGestureRecognizer::update):
(WebKit::QtPinchGestureRecognizer::finish):
(WebKit::QtPinchGestureRecognizer::cancel):

  • UIProcess/qt/QtViewportHandler.cpp: Copied from Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp.

(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(ViewportUpdateDeferrer):
(WebKit::QtViewportHandler::suspendPageContent):
(WebKit::QtViewportHandler::resumePageContent):
(WebKit::QtViewportHandler::cssScaleFromItem):
(WebKit::QtViewportHandler::itemScaleFromCSS):
(WebKit::QtViewportHandler::itemCoordFromCSS):
(WebKit::QtViewportHandler::itemRectFromCSS):
(WebKit::QtViewportHandler::QtViewportHandler):
(WebKit::QtViewportHandler::~QtViewportHandler):
(WebKit::QtViewportHandler::innerBoundedCSSScale):
(WebKit::QtViewportHandler::outerBoundedCSSScale):
(WebKit::QtViewportHandler::viewportAttributesChanged):
(WebKit::QtViewportHandler::pageContentsSizeChanged):
(WebKit::QtViewportHandler::setPageItemRectVisible):
(WebKit::QtViewportHandler::animatePageItemRectVisible):
(WebKit::QtViewportHandler::flickMoveStarted):
(WebKit::QtViewportHandler::flickMoveEnded):
(WebKit::QtViewportHandler::pageItemPositionChanged):
(WebKit::QtViewportHandler::pageContentPositionRequested):
(WebKit::QtViewportHandler::scaleAnimationStateChanged):
(WebKit::QtViewportHandler::scaleAnimationValueChanged):
(WebKit::QtViewportHandler::touchBegin):
(WebKit::QtViewportHandler::touchEnd):
(WebKit::QtViewportHandler::computePosRangeForPageItemAtScale):
(WebKit::QtViewportHandler::focusEditableArea):
(WebKit::QtViewportHandler::zoomToAreaGestureEnded):
(WebKit::QtViewportHandler::nearestValidBounds):
(WebKit::QtViewportHandler::setCSSScale):
(WebKit::QtViewportHandler::currentCSSScale):
(WebKit::QtViewportHandler::scrollAnimationActive):
(WebKit::QtViewportHandler::panGestureActive):
(WebKit::QtViewportHandler::panGestureStarted):
(WebKit::QtViewportHandler::panGestureRequestUpdate):
(WebKit::QtViewportHandler::panGestureEnded):
(WebKit::QtViewportHandler::panGestureCancelled):
(WebKit::QtViewportHandler::scaleAnimationActive):
(WebKit::QtViewportHandler::cancelScrollAnimation):
(WebKit::QtViewportHandler::interruptScaleAnimation):
(WebKit::QtViewportHandler::pinchGestureActive):
(WebKit::QtViewportHandler::pinchGestureStarted):
(WebKit::QtViewportHandler::pinchGestureRequestUpdate):
(WebKit::QtViewportHandler::pinchGestureEnded):
(WebKit::QtViewportHandler::pinchGestureCancelled):
(WebKit::QtViewportHandler::visibleContentsRect):
(WebKit::QtViewportHandler::informVisibleContentChange):
(WebKit::QtViewportHandler::viewportItemSizeChanged):
(WebKit::QtViewportHandler::scaleContent):

  • UIProcess/qt/QtViewportHandler.h: Copied from Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h.

(QtViewportHandler):

  • UIProcess/qt/QtViewportInteractionEngine.cpp: Removed.
  • UIProcess/qt/QtViewportInteractionEngine.h: Removed.
  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::setViewportHandler):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):
(WebKit::QtWebPageEventHandler::didFindZoomableArea):

  • UIProcess/qt/QtWebPageEventHandler.h:

(WebKit):
(QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::viewportHandler):

08:30 Changeset [119399] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove SelectorQueryCacheEntry from SelectorQuery.h
https://bugs.webkit.org/show_bug.cgi?id=88204

Reviewed by Hajime Morita.

As anttik@ pointed out in https://bugs.webkit.org/show_bug.cgi?id=87942#c15,
we can remove SelectorQueryCacheEntry by having SelectorQuery hold CSSSelectorList.

Tests: fast/dom/SelectorAPI/* No change in test results.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQueryCache::add):

  • dom/SelectorQuery.h:

(SelectorQuery):
(SelectorQueryCache):

08:18 Changeset [119398] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Memory leak in PasteboardHelper
https://bugs.webkit.org/show_bug.cgi?id=88216

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-04
Reviewed by Martin Robinson.

Fixed a memory leak in PasteboardHelper by using adoptRef instead
of just getting a new reference of TargetList.

No new tests because of no behavior changes.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::dropAtomsForContext):

08:15 Changeset [119397] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Memory leak in WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=88214

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-04
Reviewed by Martin Robinson.

Fixed a memory leak in WebKitWebView by making
GeolocationClientMock to be owned by the WebView.

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

  • webkit/webkitwebviewprivate.h:
08:00 Changeset [119396] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

Hit ASSERT when editing attribute value in Element in SVG Document
https://bugs.webkit.org/show_bug.cgi?id=88179

Patch by Rob Buis <rbuis@rim.com> on 2012-06-04
Reviewed by Pavel Feldman.

Make sure the <span> is created as a HTML Element regardless of document in use.

  • inspector/InspectorDOMAgent.cpp:

(WebCore):
(WebCore::InspectorDOMAgent::setAttributesAsText):

07:57 Changeset [119395] by yosin@chromium.org
  • 18 edits in trunk/Source/WebCore

[Forms] Change function and variable names independent from "double" type
https://bugs.webkit.org/show_bug.cgi?id=88220

Reviewed by Kent Tamura.

This patch is a part of introducing decimal arithmetic to input type.

This patch renames function and variable names which contain term "double"
to "number" to separate concept and implementation.

No new tests. This patch doesn't change behavior.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::valueAsDate): Replace parseToDouble to parseToNumber.
(WebCore::BaseDateAndTimeInputType::valueAsNumber): ditto.
(WebCore::BaseDateAndTimeInputType::parseToNumber): ditto.

  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType):

  • html/DateInputType.cpp:

(WebCore::DateInputType::createStepRange): Replace parseToDouble to parseToNumber.

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::createStepRange): Replace parseToDouble to parseToNumber.

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::createStepRange): Replace parseToDouble to parseToNumber.

  • html/InputType.cpp:

(WebCore::InputType::rangeUnderflow): Replace parseToDouble to parseToNumber and doubleValue to numericValue.
(WebCore::InputType::rangeOverflow): ditto.
(WebCore::InputType::isInRange): ditto.
(WebCore::InputType::isOutOfRange): ditto.
(WebCore::InputType::stepMismatch): ditto.
(WebCore::InputType::validationMessage): ditto.
(WebCore::InputType::parseToNumber): ditto.
(WebCore::InputType::parseToDoubleWithDecimalPlaces): ditto.
(WebCore::InputType::stepUpFromRenderer): dttio.

  • html/InputType.h:

(InputType):

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::createStepRange): Replace parseToDouble to parseToNumber.
(WebCore::MonthInputType::parseToNumber): ditto.

  • html/MonthInputType.h:

(MonthInputType):

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::valueAsNumber): Replace parseToDouble to parseToNumber.
(WebCore::NumberInputType::createStepRange): ditto.
(WebCore::NumberInputType::parseToNumber): ditto.

  • html/NumberInputType.h:
  • html/RangeInputType.cpp:

(WebCore::ensureMaximum): Added helper function for createStepRange for avoiding cast in max() and using "const".
(WebCore::RangeInputType::valueAsNumber): Replace parseToDouble to parseToNumber.
(WebCore::RangeInputType::createStepRange): ditto.
(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::parseToNumber): ditto.
(WebCore::RangeInputType::sanitizeValue): ditto.

  • html/RangeInputType.h:

(RangeInputType):

  • html/StepRange.cpp:

(WebCore::StepRange::parseStep): Replace DoubleWithDecimalPlaces to NumberWithDecimalPlaces.
(WebCore::StepRange::stepMismatch): Replace parseToDouble to parseToNumber.

  • html/StepRange.h:

(WebCore::StepRange::NumberWithDecimalPlaces): Renamed from DoubleWithDecimalPlaces.
(WebCore::StepRange::NumberWithDecimalPlacesOrMissing): Renamed from DoubleWithDecimalPlacesOrMissing.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::createStepRange): Replace parseToDouble to parseToNumber.

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::createStepRange): Replace parseToDouble to parseToNumber.

07:55 Changeset [119394] by ddkilzer@apple.com
  • 8 edits in trunk/Source

BUILD FIX: FeatureDefines.xcconfig should match across projects

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • Add missing ENABLE_LEGACY_CSS_VENDOR_PREFIXES.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • Add missing ENABLE_CSS_IMAGE_RESOLUTION.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • Fix sort order of ENABLE_CSS3_FLEXBOX.
  • Fix typo in ENABLE_FONT_BOOSTING.
  • Add missing ENABLE_LEGACY_CSS_VENDOR_PREFIXES.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Add missing ENABLE_LEGACY_CSS_VENDOR_PREFIXES.
07:43 Changeset [119393] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Canvas 2D - Source rectangles that overlap the source image boundary, not supported by drawImage
https://bugs.webkit.org/show_bug.cgi?id=66574

Patch by Justin Novosad <junov@chromium.org> on 2012-06-04
Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/drawImage-clipped-source.html

When the source rectangle argument to drawImage is not entirely
contatained by the domain of the source image, the source rectangle
is clipped, and the destination rectangle is clipped proportionately
Old behavior was to silently fail, which did not comply with the spec.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::normalizeAndClipRects):
(WebCore):
(WebCore::CanvasRenderingContext2D::drawImage):

LayoutTests:

Adding a new layout test that verifies that the source and destination
rectangle arguments to drawImage are properly clipped when the source
rectangle is not entirely contained whithin the domian of the source
image. Tests image to canvas draws and canvas to canvas draws.

  • fast/canvas/drawImage-clipped-source-expected.txt: Added.
  • fast/canvas/drawImage-clipped-source.html: Added.
  • fast/canvas/drawImage-clipped-source.js: Added.

(patternTest.this.testPixel):
(patternTest.this.testRedSquare):
(patternTest.this.testAggregatePattern):
(patternTest):
(drawTestPattern):
(executeTest):

06:31 Changeset [119392] by commit-queue@webkit.org
  • 7 edits in trunk

[Cairo] Implementation of GraphicsContext does not save/restore ImageInterpolation correctly
https://bugs.webkit.org/show_bug.cgi?id=87985

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-04
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Moving image interpolation quality setting into state so that it's saved and restored.

Covered by existing test fast/canvas/canvas-imageSmoothingEnabled.html which is now passing.

  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:

(GraphicsContextPlatformPrivate): Removing stale member that was never used.

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::State::State):
(PlatformContextCairo::State):
(WebCore::PlatformContextCairo::PlatformContextCairo):
(WebCore::PlatformContextCairo::drawSurfaceToContext):
(WebCore::PlatformContextCairo::setImageInterpolationQuality):
(WebCore):
(WebCore::PlatformContextCairo::imageInterpolationQuality):

  • platform/graphics/cairo/PlatformContextCairo.h:

(PlatformContextCairo): Moving implementations for image interpolation quality setter into implementation file.

LayoutTests:

Unskipping fast/canvas/canvas-imageSmoothingEnabled.html now that it passes.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
06:23 Changeset [119391] by pdr@google.com
  • 7 edits
    2 adds in trunk

Fix assert in non-scaling strokes in patterns
https://bugs.webkit.org/show_bug.cgi?id=88198

Source/WebCore:

When calculating the CTM for a rect or path in a pattern we need to use
an SVGPatternElement's local transform. Pattern did not expose the transform
because it does not extend from from SVGStyledLocatable or SVGStyledTransformable.
This patch exposes the pattern's transform in localCoordinateSpaceTransform.

SVGGradientElement does not need this special handling because the children
of a gradient element are restricted to not include shape and structural elements
that would need to calculate a CTM.

Before this patch the added test would assert.
This patch is a prerequisite to a major refactoring of RenderSVGShape &
friends, and the test will be unskipped in a followup patch.

Reviewed by Dirk Schulze.

Tests: svg/stroke/non-scaling-stroke-pattern-expected.svg

svg/stroke/non-scaling-stroke-pattern.svg

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::localCoordinateSpaceTransform):
(WebCore):

  • svg/SVGPatternElement.h:

(SVGPatternElement):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::localCoordinateSpaceTransform):

LayoutTests:

Reviewed by Dirk Schulze.

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
  • svg/stroke/non-scaling-stroke-pattern-expected.svg: Added.
  • svg/stroke/non-scaling-stroke-pattern.svg: Added.
06:15 Changeset [119390] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Tap-to-zoom overshoot animation.
https://bugs.webkit.org/show_bug.cgi?id=87108

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-04
Reviewed by Tor Arne Vestbø.

Reverts the change in animation, so the default is more "neutral".
This should be made configurable later.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::animatePageItemRectVisible):

05:38 Changeset [119389] by loislo@chromium.org
  • 4 edits
    1 copy
    1 add in trunk

Web Inspector: speed up _calculateRetainedSizes function
https://bugs.webkit.org/show_bug.cgi?id=87863

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-04
Reviewed by Yury Semikhatsky.

PerformanceTests:

  • inspector/heap-snapshot-advanced.html: Added.
  • inspector/heap-snapshot-performance-test.js: Copied from PerformanceTests/inspector/heap-snapshot.html.

(test.performanceTest.step0):
(test.performanceTest.step1):
(test.performanceTest.step2):
(test.performanceTest.cleanup):
(test.performanceTest.done):
(test.performanceTest):
(test):

  • inspector/heap-snapshot.html:

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._calculateRetainedSizes):

05:35 Changeset [119388] by loislo@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed. Disable heap profiler test on mac platform.

  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
05:17 Changeset [119387] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed, rolling out r119384.
http://trac.webkit.org/changeset/119384
https://bugs.webkit.org/show_bug.cgi?id=88227

Need to update some tests, I'll roll in later. (Requested by
Zoltan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-04

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

05:02 Changeset [119386] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: add unknown size to the memory pie-chart legend
https://bugs.webkit.org/show_bug.cgi?id=88081

Patch by Yury Semikhatsky <yurys@chromium.org> on 2012-06-04
Reviewed by Pavel Feldman.

Added "Unknown" part size to the memory pie-chart legend.

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.MemoryBlockViewProperties._initialize):
(WebInspector.NativeMemoryPieChart.prototype._paint):

04:31 Changeset [119385] by abecsi@webkit.org
  • 5 edits in trunk/Source/WebKit2

[Qt][WK2] Refactor the tap gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=88096

Reviewed by Simon Hausmann.

Refactor the tap gesture recognizer so that its internal state machine is
self contained and independent of input event types.
Also change the internal API for tap highlighting to make the code easier
to understand on the caller side.

This patch makes the tap gesture recognizer more robust, consistent with
other gesture recognizers and fixes some issues related to highlighting
and link activation with respect to native touch events.

  • UIProcess/qt/QtTapGestureRecognizer.cpp:

(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::withinDistance):
(WebKit::QtTapGestureRecognizer::update):
(WebKit::QtTapGestureRecognizer::finish):
(WebKit::QtTapGestureRecognizer::cancel):
(WebKit::QtTapGestureRecognizer::highlightTimeout):
(WebKit::QtTapGestureRecognizer::singleTapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):

  • UIProcess/qt/QtTapGestureRecognizer.h:

(QtTapGestureRecognizer):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::activateTapHighlight):
(WebKit::QtWebPageEventHandler::deactivateTapHighlight):
(WebKit):
(WebKit::QtWebPageEventHandler::handleSingleTapEvent):
(WebKit::QtWebPageEventHandler::handleDoubleTapEvent):
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

04:26 Changeset [119384] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Qt DRT / WTR should be able to load external resources
https://bugs.webkit.org/show_bug.cgi?id=87326

Reviewed by Ryosuke Niwa.

Allow external resources to be loaded when the main frame's URL is also an external resource.
This change is analogous to r118231 for Mac port and to r119153 Chromium port.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::blockRequest):
(WebCore):
(WebCore::isLocalhost):
(WebCore::hostIsUsedBySomeTestsToGenerateError):
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

04:12 Changeset [119383] by carlosgc@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.9.3

Tagging the WebKitGTK+ 1.9.3 release

04:00 Changeset [119382] by carlosgc@webkit.org
  • 4 edits in trunk

Unreviewed. Update NEWS and configure.ac for 1.9.3 release

.:

  • configure.ac: Bump version number.

Source/WebKit/gtk:

  • NEWS: Added release notes for 1.9.3.
03:24 Changeset [119381] by vestbo@webkit.org
  • 7 edits in trunk/Source/WebKit

[Qt] Don't use WebKit HAVE() macro in public Qt headers

Reviewed by Kenneth Rohde Christiansen.

03:09 Changeset [119380] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Adding explicit console error for duplicated CSP directives.
https://bugs.webkit.org/show_bug.cgi?id=88193

Source/WebCore:

This patch adds an explicit error message for duplicated CSP
directives instead of reusing the "unrecognized directive" error.

Patch by Mike West <mkwst@chromium.org> on 2012-06-04
Reviewed by Adam Barth.

Test: http/tests/security/contentSecurityPolicy/duplicate-directive.html

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::logDuplicateDirective):
(WebCore):
(WebCore::CSPDirectiveList::parseReportURI):
(WebCore::CSPDirectiveList::setCSPDirective):
(WebCore::CSPDirectiveList::applySandboxPolicy):
(WebCore::CSPDirectiveList::addDirective):

LayoutTests:

Patch by Mike West <mkwst@chromium.org> on 2012-06-04
Reviewed by Adam Barth.

  • http/tests/security/contentSecurityPolicy/duplicate-directive-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/duplicate-directive.html: Added.
02:48 Changeset [119379] by yosin@chromium.org
  • 5 edits in trunk

REGRESSION(r117929) [Forms] input type=number thinks 0 is not a number
https://bugs.webkit.org/show_bug.cgi?id=88208

Reviewed by Kent Tamura.

Source/WebCore:

This patch fixes invalid handling of return value of parseToDoubleForNumberType
in NumberInputType::isAcceptableValue to use isfinite() function for checking
whether specified string is valid number or not. Before r117929, return value
of parseToDoubleForNumberType was bool, but after r117929, it is double.

Test: fast/forms/number/input-number-from-renderer.html

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::isAcceptableValue): Use isfinite()

LayoutTests:

This patch introduced function checkIt() for code sharing and added
more test cases to input-number-commit-valid-only.htm

  • fast/forms/number/input-number-commit-valid-only-expected.txt: Changed for additional tests.
  • fast/forms/number/input-number-commit-valid-only.html: Changed.
02:32 Changeset [119378] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::RenderView::getRetainedWidgets
https://bugs.webkit.org/show_bug.cgi?id=88217

Reviewed by Kenneth Rohde Christiansen.

There is no known repro, the crash has been seen on the field. It is likely that it happens with frame
flattening enabled only.

Null check root renderer in performPostLayoutTasks. The root can legitimely be null for several reasons and
is mostly null checked everywhere else.

  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

02:28 Changeset [119377] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
https://bugs.webkit.org/show_bug.cgi?id=87668

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-06-04
Reviewed by Ryosuke Niwa.

Tools:

Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might
be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true).

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

LayoutTests:

  • platform/efl/Skipped: Unskipped fast/html/tab-order.html.
02:06 Changeset [119376] by mario@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Remove geoclue dependency from WebKit API Layer
https://bugs.webkit.org/show_bug.cgi?id=87801

Reviewed by Martin Robinson.

Make GeolocationClient for WebKitGTK+ use the new Geoclue-based
geolocation provider available in WebCore.

  • WebCoreSupport/GeolocationClientGtk.cpp:

(WebKit):
(WebKit::GeolocationClient::GeolocationClient):
(WebKit::GeolocationClient::startUpdating):
(WebKit::GeolocationClient::stopUpdating):
(WebKit::GeolocationClient::setEnableHighAccuracy):
(WebKit::GeolocationClient::notifyPositionChanged):
(WebKit::GeolocationClient::notifyErrorOccurred):

  • WebCoreSupport/GeolocationClientGtk.h:

(GeolocationClient):

01:52 Changeset [119375] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Use SelectorQuery in Element::webkitMatchesSelector()
https://bugs.webkit.org/show_bug.cgi?id=88209

Reviewed by Antti Koivisto.

By using SelectorQuery in Element::webkitMatchesSelector(),
we can not only simplify the code but also improve the performance
thanks to the cache mechanism of SelectorQuery which was implemented
in bug 87942.

Tests: fast/dom/SelectorAPI/*. No change in test results.

  • dom/Element.cpp:

(WebCore::Element::webkitMatchesSelector):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::matches):
(WebCore):

  • dom/SelectorQuery.h:

(SelectorQuery):

01:45 Changeset [119374] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

[EFL] Refactor ewk_view_context_paint code.
https://bugs.webkit.org/show_bug.cgi?id=85588

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-06-04
Reviewed by Hajime Morita.

Source/WebKit:

Added new ewk_paint_context.cpp file to source list.

  • PlatformEfl.cmake:

Source/WebKit/efl:

The main purpose of this change is reduce size of ewk_view.h/cpp files and make use of ewk_view_context_paint
object by ewk_view_single and ewk_view_tiled instead of direct operations on cairo.
The code is more objective and looks very simple now.
Remove ewk_view_context_paint code from ewk_view h/cpp file and move it to separate new ewk_context_paint file.
The ewk_view_context_paint has been renamed to ewk_context_paint and it is not binded to view on creation time.

  • ewk/ewk_paint_context.cpp: Added.

Functions renamed and moved from ewk_view to ewk_paint_context file.
(ewk_paint_context_new):
(ewk_paint_context_from_image_new): New function.
(ewk_paint_context_from_image_data_new): New function.
(ewk_paint_context_free):
(ewk_paint_context_save):
(ewk_paint_context_restore):
(ewk_paint_context_clip):
(ewk_paint_context_scale):
(ewk_paint_context_translate):
(ewk_paint_context_paint): Added FrameView parameter.
(ewk_paint_context_paint_contents): Added FrameView parameter.

  • ewk/ewk_paint_context_private.h: Added.

(_Ewk_Paint_Context):

  • ewk/ewk_private.h: Functions ewk_view_paint and ewk_view_paint_contents moved from ewk_view.h.
  • ewk/ewk_tiled_backing_store.h: Removed unused include.
  • ewk/ewk_view.cpp: Moved all function releated to paint context object to new ewk_paint_context file.

(_Ewk_View_Private_Data):
(ewk_view_paint): Changed function according change in ewk_paint_context_paint function.
(ewk_view_paint_contents): Changed function according change in ewk_paint_context_paint_contents function.

  • ewk/ewk_view.h: Removed all paint context functions and ewk_view_paint, ewk_view_paint_contents function from

public API.

  • ewk/ewk_view_single.cpp:

(_ewk_view_single_smart_repaints_process):
Refactor of _ewk_view_single_smart_repaints_process function.
Removed goto statements.
Removed variables declaration from function beginning.

  • ewk/ewk_view_tiled.cpp:

(_ewk_view_tiled_render_cb): Make use of ewk_paint_context object instead of direction operation on cairo.
Looks simpler and more objective.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt: Added include directory.
01:04 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
01:03 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
01:02 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
01:01 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
00:00 Changeset [119373] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
https://bugs.webkit.org/show_bug.cgi?id=87869

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-04
Reviewed by Andreas Kling.

Replace %lld by PRId64 macro to print an int64_t value and silent a
compilation warning on 64-Bit.

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onExceededApplicationCacheQuota):

06/03/12:

23:20 Changeset [119372] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140222 to r140260.

  • DEPS:
22:38 Changeset [119371] by kinuko@chromium.org
  • 9 edits in trunk

[chromium] DataTransferItem.webkitGetAsEntry() should synchronously return entry
https://bugs.webkit.org/show_bug.cgi?id=87969

Reviewed by Tony Chang.

Source/WebCore:

Per discussion on whatwg we should make webkitGetAsEntry synchronous.
http://lists.w3.org/Archives/Public/public-whatwg-archive/2012Apr/0079.html

Tests: editing/pasteboard/data-transfer-items-drag-drop-entry.html

fast/filesystem/cross-filesystem-op.html

  • Modules/filesystem/DataTransferItemFileSystem.h:

(DataTransferItemFileSystem):

  • Modules/filesystem/DataTransferItemFileSystem.idl:
  • Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp:

(WebCore::DataTransferItemFileSystem::webkitGetAsEntry): Changed it to synchronously return entry.

LayoutTests:

  • editing/pasteboard/data-transfer-items-drag-drop-entry-expected.txt:
  • editing/pasteboard/data-transfer-items-drag-drop-entry.html:
  • fast/filesystem/cross-filesystem-op.html:
  • platform/chromium/test_expectations.txt:
22:24 Changeset [119370] by shawnsingh@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix of chromium TestExpectations

Some extra junk got added by accident when I tried to change
TestExpectations. This patch removes it.

  • platform/chromium/TestExpectations:
22:10 Changeset [119369] by shawnsingh@chromium.org
  • 17 edits
    43 adds in trunk/LayoutTests

Unreviewed rebasline for transforms/3d test cases.

9 tests re-baselined.
The remainin 6 tests are explicitly enumerated in the TestExpectations file now.

  • platform/chromium-linux/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/chromium-linux/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/chromium-linux/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/general/perspective-units-expected.png:
  • platform/chromium-mac-leopard/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png:
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
  • platform/chromium-mac-snowleopard/transforms/3d/general/perspective-units-expected.png:
  • platform/chromium-mac-snowleopard/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
  • platform/chromium-mac/transforms/3d/general/matrix-with-zoom-3d-expected.png: Added.
  • platform/chromium-mac/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/chromium-mac/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/chromium-mac/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/chromium-win/transforms/3d/general/matrix-with-zoom-3d-expected.png: Added.
  • platform/chromium-win/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/chromium-win/transforms/3d/general/perspective-units-expected.txt: Added.
  • platform/chromium-win/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/chromium-win/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
  • platform/chromium-win/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/chromium-win/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
  • platform/chromium/TestExpectations:
21:19 TestExpectations edited by rniwa@webkit.org
Update per TestExpectations rename (diff)
21:18 NewRunWebKitTests edited by rniwa@webkit.org
Update per TestExpectations rename (diff)
21:18 Rebaseline edited by rniwa@webkit.org
Update per TestExpectations rename (diff)
21:16 April 2012 Keeping the bots green edited by rniwa@webkit.org
Update per TestExpectations rename (diff)
21:14 WikiStart edited by rniwa@webkit.org
Rename test_expectations.txt to TestExpectations (diff)
20:14 Changeset [119368] by haraken@chromium.org
  • 3 edits
    1 copy in trunk/PerformanceTests

[perf-test] Add a benchmark of querySelector() for an element that appears in the depths in the document
https://bugs.webkit.org/show_bug.cgi?id=88202

Reviewed by Ryosuke Niwa.

query-selector-first.html tests querySelector() for an element
that appears at the head of the document. query-selector-last.html
tests querySelector() for an element that appears at the tail of
the document. In addition, we want a benchmark of querySelector()
for an element that appears in the depths in the document.

Test results in my Linux desktop:

RESULT Parser: query-selector-deep= 460.776980611 runs/s
median= 460.947503201 runs/s, stdev= 1.72274941942 runs/s, min= 455.696202532 runs/s, max= 463.32046332 runs/s

RESULT Parser: query-selector-deep= 458.925050915 runs/s
median= 459.183673469 runs/s, stdev= 1.47930124139 runs/s, min= 454.545454545 runs/s, max= 460.947503201 runs/s

RESULT Parser: query-selector-deep= 461.866981491 runs/s
median= 461.538461538 runs/s, stdev= 1.14613123359 runs/s, min= 459.183673469 runs/s, max= 463.917525773 runs/s

RESULT Parser: query-selector-deep= 453.922010788 runs/s
median= 454.258855898 runs/s, stdev= 1.77279123317 runs/s, min= 447.204968944 runs/s, max= 455.696202532 runs/s

RESULT Parser: query-selector-deep= 454.666321221 runs/s
median= 454.545454545 runs/s, stdev= 1.65775667417 runs/s, min= 451.127819549 runs/s, max= 456.852791878 runs/s

  • Parser/query-selector-deep.html: Added.
20:06 Changeset [119367] by dominicc@chromium.org
  • 15 edits
    1 move
    1 delete in trunk/Source/WebCore

EventTarget.idl should generate JS bindings
https://bugs.webkit.org/show_bug.cgi?id=88120

This is one step in a larger change to expose a constructor for
EventTarget and put EventTarget on the prototype chain of DOM
objects that are event targets, in line with DOM Core. See
<https://bugs.webkit.org/show_bug.cgi?id=67312>

Reviewed by Adam Barth.

No new tests. This change does not change any functionality.

  • CMakeLists.txt: Generate JSEventTarget.
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp: JSEventTarget.cpp was renamed.
  • bindings/js/JSEventTarget.h: Removed. Generated now.
  • bindings/js/JSEventTargetCustom.cpp: Renamed from Source/WebCore/bindings/js/JSEventTarget.cpp.
  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields): EventTarget is an EventTarget.

  • dom/EventTarget.idl: Defer to toJS, toEventTarget in JSEventTargetCustom.cpp.
19:24 Changeset [119366] by haraken@chromium.org
  • 2 edits in trunk/PerformanceTests

[perf-test] Make query-selector-last.html more realistic
https://bugs.webkit.org/show_bug.cgi?id=88203

Reviewed by Ryosuke Niwa.

query-selector-last.html tests querySelector() for an element
that appears after 1000 div elements, all of which have the same
id and class. To test the performance of querySelector() under
a lot of ids and classes, we should make the ids and classes of
the 1000 elements different.

This patch degrades the performance of query-selector-last.html
by 3.6%.

[Before]
RESULT Parser: query-selector-last= 476.382274152 runs/s
median= 476.821192053 runs/s, stdev= 1.14578875814 runs/s, min= 474.308300395 runs/s, max= 478.087649402 runs/s

RESULT Parser: query-selector-last= 478.423061861 runs/s
median= 478.723404255 runs/s, stdev= 1.54876867255 runs/s, min= 473.684210526 runs/s, max= 481.347773767 runs/s

RESULT Parser: query-selector-last= 479.849287174 runs/s
median= 480.0 runs/s, stdev= 1.69849752498 runs/s, min= 475.561426684 runs/s, max= 481.927710843 runs/s

RESULT Parser: query-selector-last= 476.765438846 runs/s
median= 477.453580902 runs/s, stdev= 1.8724488664 runs/s, min= 471.821756225 runs/s, max= 478.723404255 runs/s

RESULT Parser: query-selector-last= 481.715340644 runs/s
median= 481.637742305 runs/s, stdev= 1.81446361145 runs/s, min= 475.561426684 runs/s, max= 483.675937122 runs/s

[After]
RESULT Parser: query-selector-last= 458.866623582 runs/s
median= 459.183673469 runs/s, stdev= 1.48881464737 runs/s, min= 453.972257251 runs/s, max= 460.947503201 runs/s

RESULT Parser: query-selector-last= 460.363532897 runs/s
median= 460.358056266 runs/s, stdev= 1.58512056995 runs/s, min= 456.273764259 runs/s, max= 462.130937099 runs/s

RESULT Parser: query-selector-last= 457.727448451 runs/s
median= 458.015267176 runs/s, stdev= 1.23681915516 runs/s, min= 453.972257251 runs/s, max= 459.183673469 runs/s

RESULT Parser: query-selector-last= 465.57336853 runs/s
median= 465.717981889 runs/s, stdev= 1.6616925374 runs/s, min= 460.947503201 runs/s, max= 467.532467532 runs/s

RESULT Parser: query-selector-last= 459.836252019 runs/s
median= 459.770114943 runs/s, stdev= 1.84485630505 runs/s, min= 455.696202532 runs/s, max= 462.724935733 runs/s

  • Parser/query-selector-last.html:
17:35 WebKit Team edited by joone@webkit.org
(diff)
15:35 Changeset [119365] by hayato@chromium.org
  • 5 edits in trunk

Supports traversing nodes in an orphaned shadow subtree in ComposedShadowTreeParentWalker.
https://bugs.webkit.org/show_bug.cgi?id=87924

Reviewed by Dimitri Glazkov.

Source/WebCore:

Some events, such as a 'click' event, can be dispatched on nodes in an orphaned shadow subtree.
When resolving a parent node of a shadow root which is not assigned to any shadow insertion point,
we have to return its shadow host as a parent node.

The related shadow DOM spec section is:
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#events

Test: fast/dom/shadow/shadow-dom-event-dispatching.html

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeParentWalker::traverseParentIncludingInsertionPointAndShadowRoot):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
14:16 Changeset [119364] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Weak pointer finalization should be lazy
https://bugs.webkit.org/show_bug.cgi?id=87599

Reviewed by Sam Weinig.

This time for sure!

  • heap/Heap.cpp:

(JSC::Heap::collect): Don't sweep eagerly -- we'll sweep lazily instead.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep): Sweep our weak set before we sweep our other
destructors -- this is our last chance to run weak set finalizers before
we recycle our memory.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::resetAllocator):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::resetAllocators):

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::resetAllocators): Don't force allocator reset anymore.
It will happen automatically when a weak set is swept. It's simpler to
have only one canonical way for this to happen, and it wasn't buying
us anything to do it eagerly.

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::sweep): Don't short-circuit a sweep unless we know
the sweep would be a no-op. If even one finalizer is pending, we need to
run it, since we won't get another chance.

  • heap/WeakSet.cpp:

(JSC::WeakSet::sweep): This loop can be simpler now that
WeakBlock::sweep() does what we mean.

Reset our allocator after a sweep because this is the optimal time to
start trying to recycle old weak pointers.

(JSC::WeakSet::tryFindAllocator): Don't sweep when searching for an
allocator because we've swept already, and forcing a new sweep would be
wasteful.

  • heap/WeakSet.h:

(JSC::WeakSet::shrink): Be sure to reset our allocator after a shrink
because the shrink may have removed the block the allocator was going to
allocate out of.

12:13 Changeset [119363] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] http/tests/media/video-buffered.html is failing after r119268 and need to be skipped
https://bugs.webkit.org/show_bug.cgi?id=88194

Unreviewed EFL gardening. Skipping http/tests/media/video-buffered.html
which is failing after r119268.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-03

  • platform/efl/TestExpectations:
11:49 Changeset [119362] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] legacy-viewport tests added in r119256 need to be skipped
https://bugs.webkit.org/show_bug.cgi?id=88192

Unreviewed EFL gardening. Skip new tests added in r119256 since the
LEGACY_VIEWPORT_ADAPTION flag is disabled on EFL port.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-03

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
11:30 Changeset [119361] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

[EFL] New tests need a baseline
https://bugs.webkit.org/show_bug.cgi?id=88190

Unreviewed EFL gardening. Add EFL baseline for new test cases.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-03

  • platform/efl/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/efl/fast/reflections/reflection-with-zoom-expected.txt: Added.
  • platform/efl/svg/repaint/text-mask-update-expected.png: Added.
  • platform/efl/svg/repaint/text-mask-update-expected.txt: Added.
08:51 Changeset [119360] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, rolling out r119359.
http://trac.webkit.org/changeset/119359
https://bugs.webkit.org/show_bug.cgi?id=88189

This broke platform/mac/fast/dom/wrapper-classes-objc.html.
(Requested by dominicc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-03

Source/WebCore:

  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:

(GetBaseClass):

  • dom/MouseEvent.h:

(MouseEvent):

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):

  • dom/WheelEvent.h:

(WheelEvent):

  • dom/WheelEvent.idl:

LayoutTests:

  • fast/events/event-creation-expected.txt:
  • fast/events/event-creation.html:
07:33 Changeset [119359] by dominicc@chromium.org
  • 10 edits in trunk

WheelEvent should inherit from MouseEvent
https://bugs.webkit.org/show_bug.cgi?id=76104

Reviewed by Kentaro Hara.

Source/WebCore:

The spec for WheelEvent is
<http://www.w3.org/TR/DOM-Level-3-Events/#webidl-events-WheelEvent>

Tests: fast/events/event-creation.html

http://samples.msdn.microsoft.com/ietestcenter/dominheritance/showdominheritancetest.htm?Prototype_WheelEvent

  • bindings/objc/PublicDOMInterfaces.h: Remove redundant MouseEvent API from WheelEvent
  • bindings/scripts/CodeGeneratorObjC.pm: MouseEvents are Events
  • dom/MouseEvent.h: Expose no-arg constructor to WheelEvent
  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent): Call MouseEvent superconstructor

  • dom/WheelEvent.h: Extend MouseEvent
  • dom/WheelEvent.idl: "

LayoutTests:

  • fast/events/event-creation-expected.txt:
  • fast/events/event-creation.html: Also check WheelEvent instanceof MouseEvent as well as UIEvent, Event
02:35 Changeset [119358] by gyuyoung.kim@samsung.com
  • 4 edits
    1 copy in trunk/Source/WebKit/efl

Add ewk_custom_handler_private.h for ewk_custom_handler.cpp
https://bugs.webkit.org/show_bug.cgi?id=88163

Reviewed by Ryosuke Niwa.

EFL WK1 decided to divide up ewk_private.h into each file's XXX_private.h file
in order to maintain internal functions more easily. Bug 73176 is adding new
internal functions to ewk_custom_hanlder.cpp. So, ewk_custom_handler.cpp needs
to have _private.h file as well.

  • WebCoreSupport/ChromeClientEfl.cpp:
  • ewk/ewk_custom_handler.cpp:
  • ewk/ewk_custom_handler_private.h: Added.
  • ewk/ewk_view_private.h:
01:21 Changeset [119357] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140000 to r140222.

  • DEPS:
00:26 Changeset [119356] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

[chromium] Add new gesture type (two finger tap) that triggers context menu.
https://bugs.webkit.org/show_bug.cgi?id=88173

Patch by Varun Jain <varunjain@google.com> on 2012-06-03
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/touch/gesture/context-menu-on-two-finger-tap.html

  • platform/PlatformEvent.h:

Source/WebKit/chromium:

  • public/WebInputEvent.h:
  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::handleInputEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

Tools:

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::gestureTwoFingerTap):
(EventSender::gestureEvent):

  • DumpRenderTree/chromium/EventSender.h:

(EventSender):

LayoutTests:

  • fast/events/touch/gesture/context-menu-on-two-finger-tap.html: Added.
  • platform/chromium/fast/events/touch/gesture/context-menu-on-two-finger-tap-expected.txt: Added.
00:06 Changeset [119355] by rjkroege@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] replace isScrollGestureEventType with isGestureEventType
https://bugs.webkit.org/show_bug.cgi?id=88097

This change replaces the unused and incorrect isScrollGestureEventType
method with a correct and useful isGestureEventType method.

Reviewed by Adam Barth.

  • public/WebInputEvent.h:

(WebInputEvent):
(WebKit::WebInputEvent::isGestureEventType):

06/02/12:

23:29 Changeset [119354] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

ZNK7WebCore4Node27traverseNextAncestorSiblingEv should be exported even if ENABLE(FULLSCREEN_API) is false
https://bugs.webkit.org/show_bug.cgi?id=88184

Reviewed by Dan Bernstein.

Node::traverseNextAncestorSibling() is called in several inline
functions defined in ContainerNode.h (a private header), so its symbol
needs to be exported regardless of whether full-screen API is enabled.

  • WebCore.exp.in:
22:06 Changeset [119353] by wangxianzhu@chromium.org
  • 15 edits
    2 adds in trunk

SVGImageCache leaks image data
https://bugs.webkit.org/show_bug.cgi?id=87792

Source/WebCore:

There are two functions to remove a client from a CachedImage:

  • CachedResource::removeClient()
  • CachedImage::removeClientForRenderer().

It's easy to make error to call the former which will leak the cached
image buffers in SVGImageCache.

This change combined the two by adding the virtual
CachedResource::didRemoveClient(). CachedImage will do SVGImageCache
cleanup in the function.

Reviewed by Nikolas Zimmermann.

Test: svg/as-image/svg-image-leak-cached-data.html

  • loader/cache/CachedFont.h:

(WebCore::CachedFontClient::resourceClientType): Added 'const'.

  • loader/cache/CachedImage.cpp:

(WebCore):
(WebCore::CachedImage::didRemoveClient): Removes the client from SVGImageCache.
(WebCore::CachedImage::lookupOrCreateImageForRenderer):

  • loader/cache/CachedImage.h:

(CachedImage):
(WebCore::CachedImageClient::resourceClientType): Added 'const'.

  • loader/cache/CachedRawResource.h:

(WebCore::CachedRawResourceClient::resourceClientType): Added 'const'.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::removeClient): Added invocation of didRemoveClient().

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::didRemoveClient): Added for subclasses to do additional works.

  • loader/cache/CachedResourceClient.h:

(WebCore::CachedResourceClient::resourceClientType): Added 'const'.

  • loader/cache/CachedSVGDocument.h:

(WebCore::CachedSVGDocumentClient::resourceClientType): Added 'const'.

  • loader/cache/CachedStyleSheetClient.h:

(WebCore::CachedStyleSheetClient::resourceClientType): Added 'const'.

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::removeClient):

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::removeClient):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache): Added checking for leaks.
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndScales):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForClient):

  • svg/graphics/SVGImageCache.h:

(WebCore):
(SVGImageCache):

LayoutTests:

Reviewed by Nikolas Zimmermann.

New test case.

  • svg/as-image/svg-image-leak-cached-data-expected.txt: Added.
  • svg/as-image/svg-image-leak-cached-data.html: Added.
21:10 Changeset [119352] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove the failing expectation on fast/forms/textarea-scrollbar-height.html since it has been passing.

  • platform/chromium/TestExpectations:
20:45 Changeset [119351] by ggaren@apple.com
  • 3 edits in trunk/Source/WebKit2

2012-06-02 Geoffrey Garen <ggaren@apple.com>

Try to fix the Windows build.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
20:35 Changeset [119350] by rniwa@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Add back files inadvertently removed in r119323.

19:46 Changeset [119349] by aestes@apple.com
  • 20 edits in trunk/Source/WebKit2

[WebKit2] Use USE(), ENABLE(), and HAVE() macros in more places
https://bugs.webkit.org/show_bug.cgi?id=88182

Reviewed by Sam Weinig.

Use USE(APPKIT):

  • Shared/mac/NativeWebKeyboardEventMac.mm:
  • Shared/mac/NativeWebMouseEventMac.mm:
  • Shared/mac/NativeWebWheelEventMac.mm:
  • Shared/mac/WebEventFactory.h:
  • UIProcess/API/mac/WKTextInputWindowController.h:
  • UIProcess/API/mac/WKTextInputWindowController.mm:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:

Use ENABLE(NETSCAPE_PLUGIN_API):

  • UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):

Use USE(AUTOCORRECTION_PANEL):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::showCorrectionPanel):
(WebKit::PageClientImpl::dismissCorrectionPanel):
(WebKit::PageClientImpl::dismissCorrectionPanelSoon):

  • UIProcess/mac/CorrectionPanel.mm:

Use HAVE(HOSTED_CORE_ANIMATION):

  • UIProcess/mac/WebContextMac.mm:

Put ENABLE(FULLSCREEN_API) in the right place:

  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:

Remove unnecessary use of USE(APPKIT):

  • UIProcess/mac/WebPageProxyMac.mm:

Use USE(SECURITY_FRAMEWORK):

  • WebProcess/Authentication/mac/AuthenticationManager.mac.mm:

Use ENABLE(CONTEXT_MENUS):

  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:

Use USE(SECURITY_FRAMEWORK):

  • WebProcess/WebProcess.h:

Remove unnecessary use of USE(SECURITY_FRAMEWORK):

  • WebProcess/mac/WebProcessMac.mm:
19:38 Changeset [119348] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Windows build fix after r119330. Unnest the class for now.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCacheEntry::SelectorQueryCacheEntry):
(WebCore::SelectorQueryCache::add):

  • dom/SelectorQuery.h:

(SelectorQueryCacheEntry):
(WebCore::SelectorQueryCacheEntry::selectorQuery):
(WebCore):
(SelectorQueryCache):

19:33 Changeset [119347] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove a duplicate INIT() from WebSystemInterface.mm
https://bugs.webkit.org/show_bug.cgi?id=88181

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

19:23 Changeset [119346] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unnecessary import of <Cocoa/Cocoa.h>
https://bugs.webkit.org/show_bug.cgi?id=88180

Reviewed by Sam Weinig.

  • UIProcess/mac/WKFullKeyboardAccessWatcher.h:
17:53 Changeset [119345] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Ensure cpu_type_t is defined by including <mach/machine.h>
https://bugs.webkit.org/show_bug.cgi?id=88178

Reviewed by Anders Carlsson.

  • Shared/Plugins/PluginModuleInfo.h:
17:47 Changeset [119344] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

InjectedBundles' sandbox extensions don't do what we think they do
https://bugs.webkit.org/show_bug.cgi?id=88177

Reviewed by Anders Carlsson.

This cannot be tested with our current infrastructure (or any modifications of the
infrastructure I can think of) since it relies on the bundle being put outside
the build directory where WebKit is put.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load):
Use SandboxExtension::consumePermanently() rather than consume(), otherwise,
nulling out the SandboxExtension a few lines later invalidates the extension
we just consumed.

17:41 Changeset [119343] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

If the DFG bytecode parser detects that op_method_check has gone polymorphic, it
shouldn't revert all the way to GetById/GetByIdFlush
https://bugs.webkit.org/show_bug.cgi?id=88176

Reviewed by Geoffrey Garen.

Refactored the code so that the op_method_check case of the parser gracefully falls
through to all of the goodness of the normal op_get_by_id case.

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleGetById):
(DFG):
(JSC::DFG::ByteCodeParser::parseBlock):

15:58 Changeset [119342] by fpizlo@apple.com
  • 18 edits in trunk/Source/JavaScriptCore

DFG CSE should be able to eliminate unnecessary flushes of arguments and captured variables
https://bugs.webkit.org/show_bug.cgi?id=87929

Reviewed by Geoffrey Garen.

Slight speed-up on V8. Big win (up to 50%) on programs that inline very small functions.

This required a bunch of changes:

  • The obvious change is making CSE essentially ignore whether or not the set of operations between the Flush and the SetLocal can exit, and instead focus on whether or not that set of operations can clobber the world or access local variables. This code is now refactored to return a set of flags indicating any of these events, and the CSE decides what to do based on those flags. If the set of operations is non-clobbering and non-accessing, then the Flush is turned into a Phantom on the child of the SetLocal. This expands the liveness of the relevant variable but virtually guarantees that it will be register allocated and not flushed to the stack. So, yeah, this patch is a lot of work to save a few stores to the stack.


  • Previously, CheckArgumentsNotCreated was optimized "lazily" in that you only knew if it was a no-op if you were holding onto a CFA abstract state. But this would make the CSE act pessimistically, since it doesn't use the CFA. Hence, this patch changes the constant folding phase into something more broad; it now fixes up CheckArgumentsNotCreated nodes by turning them into phantoms if it knows that they are no-ops.


  • Arguments simplification was previously relying on this very strange PhantomArguments node, which had two different meanings: for normal execution it meant the empty value but for OSR exit it meant that the arguments should be reified. This produces problems when set SetLocals to the captured arguments registers are CSE'd away, since we'd be triggering reification of arguments without having initialized the arguments registers to empty. The cleanest solution was to fix PhantomArguments to have one meaning: namely, arguments reification on OSR exit. Hence, this patch changes arguments simplification to change SetLocal of CreateArguments on the arguments registers to be a SetLocal of Empty.


  • Argument value recoveries were previously derived from the value source of the arguments at the InlineStart. But that relies on all SetLocals to arguments having been flushed. It's possible that we could have elided the SetLocal to the arguments at the callsite because there were subsequent SetLocals to the arguments inside of the callee, in which case the InlineStart would get the wrong information. Hence, this patch changes argument value recovery computation to operate over the ArgumentPositions directly.


  • But that doesn't actually work, because previously, there was no way to link an InlineStart back to the corresponding ArgumentPositions, at least not without some ugliness. So this patch instates the rule that the m_argumentPositions vector consists of disjoint subsequences such that each subsequence corresponds to an inline callsite and can be identified by its first index, and within each subsequence are the ArgumentPositions of all of the arguments ordered by argument index. This required flipping the order in which ArgumentPositions are added to the vector, and giving InlineStart an operand that indicates the start of that inline callsite's ArgumentPosition subsequence.


  • This patch also revealed a nasty bug in the reification of arguments in inline call frames on OSR exit. Since the reification was happening after the values of virtual registers were recovered, the value recoveries of the inline arguments were wrong. Hence using operationCreateInlinedArguments is wrong. For example a value recovery might say that you have to box a double, but if we had already boxed it then boxing it a second time will result in garbage. The specific case of this bug was this patch uncovered was that now it is possible for an inline call frame to not have any valid value recoveries for any inline arguments, if the optimization elides all argument flushes, while at the same time optimizing away arguments creation. Then OSR exit would try to recover the arguments using the inline call frame, which had bogus information, and humorous crashes would ensue. This patch fixes this issue by moving arguments reification to after call frame reification, so that arguments reification can always use operationCreateArguments instead of operationCreateInlinedArguments.


  • This patch may turn a Flush into a Phantom. That's kind of the whole point. But that broke forward speculation checks, which knew to look for a Flush prior to a SetLocal but didn't know that there could alternatively be a Phantom in place of the Flush. This patch fixes that by augmenting the forward speculation check logic.


  • Finally, in the process of having fun with all of the above, I realized that my DFG validation was not actually running on every phase like I had originally designed it to. In fact it was only running just after bytecode parsing. I initially tried to make it run in every phase but found that this causes some tests to timeout (specifically the evil fuzzing ones), so I decided on a compromise where: (i) in release mode validation never runs, (ii) in debug mode validation will run just after parsing and just before the backend, and (iii) it's possible with a simple switch to enable validation to run on every phase.


Luckily all of the above issues were already covered by the 77 or so DFG-specific
layout tests. Hence, this patch does not introduce any new tests despite being so
meaty.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentPosition.h:

(JSC::DFG::ArgumentPosition::prediction):
(JSC::DFG::ArgumentPosition::doubleFormatState):
(JSC::DFG::ArgumentPosition::shouldUseDoubleFormat):
(ArgumentPosition):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::SetLocalStoreEliminationResult::SetLocalStoreEliminationResult):
(SetLocalStoreEliminationResult):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGNode.h:

(Node):
(JSC::DFG::Node::hasArgumentPositionStart):
(JSC::DFG::Node::argumentPositionStart):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGPhase.cpp:

(DFG):

  • dfg/DFGPhase.h:

(Phase):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

15:49 Changeset [119341] by ggaren@apple.com
  • 8 edits in trunk/Source

DOM string cache should hash pointers, not characters
https://bugs.webkit.org/show_bug.cgi?id=88175

Reviewed by Phil Pizlo and Sam Weinig.

../JavaScriptCore:

  • heap/Weak.h:

(JSC::weakAdd):
(JSC::weakRemove): Made these function templates slightly more generic
to accommodate new client types.

../WebCore:

Dromaeo DOM Core reports no change.

http://trac.webkit.org/changeset/84934 accidentally changed from hashing
pointers to hashing characters, due to template defaults. Let's change back.

Hashing characters is not so good because:

(1) It's not memory-safe with HashMap::set(). HashMap::set() replaces
the value but not the key. Since our values own our keys, we need to
ensure object identity between key and value, or the key can be freed
prematurely. (This is impossible to demonstrate with our current
eager sweep behavior, but it shows up as crashes in layout tests if you
change to lazy sweep.)

(2) It's slower.

  • bindings/js/DOMWrapperWorld.h:

(WebCore): Override the default hash, which hashes based on characters.

14:52 Changeset [119340] by efidler@rim.com
  • 2 edits in trunk/Source/WebCore

Don't crash if we ask for fonts that don't exist.
https://bugs.webkit.org/show_bug.cgi?id=88106

Reviewed by Dan Bernstein.

RIM PR 161219

If the site doesn't ask for a reasonable font and the system doesn't
provide a good fallback, FontFallBackList::primaryFontData can be 0,
which can cause a crash.

  • platform/graphics/skia/FontCacheSkia.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

14:30 Changeset [119339] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

loadRequest should check for empty URLs.
https://bugs.webkit.org/show_bug.cgi?id=88154

In [WebFrame loadRequest], if the url is invalid and not nil, we transform it to file: url.
However, WebKit client could send down an empty URL that makes us transform it to file: url
as well. We should skip that as we did for nil URLs.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-06-02
Reviewed by Brady Eidson.

  • WebView/WebFrame.mm:

(-[WebFrame loadRequest:]):

13:34 WebKitGTK/1.8.x edited by kov@webkit.org
(diff)
13:32 Changeset [119338] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.8

Merge 115763 - Ensure HTMLElementStack fails gracefully if it has a non-Element.
https://bugs.webkit.org/show_bug.cgi?id=85167

Reviewed by Adam Barth.

Source/WebCore:

Test: Added to html5lib/resources/webkit02.dat

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::oneBelowTop):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

  • html5lib/resources/webkit02.dat:
13:31 Changeset [119337] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.8

Merge 108311 - Invalid cast in WebCore::toElement / WebCore::HTMLElementStack::ElementRecord::element
https://bugs.webkit.org/show_bug.cgi?id=78975

Reviewed by Eric Seidel.

Source/WebCore:

We're supposed to set the action attribute on the form element we just
created. Previously, we assumed the newly created form element would
be on the top of the stack of open elements, but if we're in the table
body insertion mode, the form element gets treated as self closing and
is therefore popped off the stack of open elements.

Fortunately, we already cache a pointer to the most recently inserted
form element on the HTMLConstructionSite, so we can just grab the
element from there.

Test: html5lib/runner.html

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):

LayoutTests:

  • html5lib/resourcesl/webkit-02.dat:
13:31 Changeset [119336] by kov@webkit.org
  • 1 add in releases/WebKitGTK/webkit-1.8/LayoutTests/platform/gtk/fast/dom/htmlcollection-non-html-expected.txt

Rebseline for 115398.

13:31 Changeset [119335] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 115646 - loadOrRedirectSubframe should return the owner element's frame
https://bugs.webkit.org/show_bug.cgi?id=84780

Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/loader/javascript-url-iframe-remove-on-navigate.html

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadOrRedirectSubframe):

LayoutTests:

  • fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt: Added.
  • fast/loader/javascript-url-iframe-remove-on-navigate.html: Added.
13:30 Changeset [119334] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 115398 - Invalid cast in WebCore::HTMLCollection::isAcceptableElement
https://bugs.webkit.org/show_bug.cgi?id=84626

Reviewed by Darin Adler.

Source/WebCore:

Check if the object is an HTMLElement before casting.

Test: fast/dom/htmlcollection-non-html.html

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::isAcceptableElement):

LayoutTests:

Add tests to make sure only HTML elements are present in most HTMLCollection objects.

  • fast/dom/htmlcollection-non-html-option-expected.txt: Added.
  • fast/dom/htmlcollection-non-html.html: Added.
13:30 Changeset [119333] by kov@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Source/WebCore: Crash in CachedRawResource::didAddClient() due to missing protector.
https://bugs.webkit.org/show_bug.cgi?id=83632

Reviewed by Eric Seidel.

Test: http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::didAddClient):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=83632.

Reviewed by Eric Seidel.

  • http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html: Added.
13:30 Changeset [119332] by kov@webkit.org
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-1.8

2012-03-09 Nate Chapin <japhet@chromium.org>

CachedRawResource breaks when trying to load
a resource with an empty response body from cache.

Reviewed by Alexey Proskuryakov.

Test: http/tests/cache/zero-length-xhr.html

  • loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::didAddClient): Don't exit early

if m_data is empty, we may still need to notifyFinished().

13:29 Changeset [119331] by kov@webkit.org
  • 7 edits in releases/WebKitGTK/webkit-1.8

Source/WebCore: Prevent CachedRawResource from sending the same data
chunk multiple times.
https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

If a CachedRawResource receives data while a CachedRawResourceCallback
timer is active, the incremental data will be sent to the client, followed
but all data received so far, resulting in invalid data. Resolving this adds
complexity to CachedRawResource and requires making a few more CachedResource
functions virtual, so push the callback logic into CachedResource where it can
be implemented more cleanly.

Test: inspector/debugger/script-formatter-console.html

should no longer be flaky.

  • loader/cache/CachedRawResource.cpp: CachedRawResourceCallback renamed and moved to CachedResource.

(WebCore::CachedRawResource::didAddClient): More or less the same as sendCallbacks() was.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClient): Check the return value of addClientToSet() to determine whether

or not to call didAddClient.

(WebCore::CachedResource::didAddClient): May be called during addClient(), or may be called on a timer.

If called on a timer, move the client between sets.

(WebCore::CachedResource::addClientToSet): Determine whether didAddClient() can be called synchronously and

return true if it can.

(WebCore::CachedResource::removeClient): Ensure we cancel pending callbacks if necessary.
(WebCore::CachedResource::CachedResourceCallback::CachedResourceCallback): Renamed and moved from CachedRawResource.

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::hasClients): Check m_clientsAwaitingCallback as well as m_clients.
(WebCore::CachedResource::CachedResourceCallback::schedule):
(WebCore::CachedResource::hasClient): Helper for calling contains() on both m_clientsAwaitingCallback and m_clients.

LayoutTests: inspector/debugger/script-formatter-console.html should
no longer be flaky.
https://bugs.webkit.org/show_bug.cgi?id=78810

Reviewed by Adam Barth.

  • platform/chromium/test_expectations.txt:
12:23 Changeset [119330] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[Performance] Optimize querySelector() by caching SelectorQuery objects
https://bugs.webkit.org/show_bug.cgi?id=87942

Reviewed by Antti Koivisto.

This patch improves performance of Node::querySelector() by 7.1x in Safari/Mac
and by 8.5x in Chromium/Linux.

Performance test: Parser/query-selector-first.html, Parser/query-selector-last.html

[query-selector-first.html]
Safari/Mac 264.97 runs/s => 1872.78 runs/s (7.06x speed-up)
Chromium/Linux 244.84 runs/s => 2071.60 runs/s (8.46x speed-up)

[query-selector-last.html]
Safari/Mac 393.73 runs/s => 466.05 runs/s (1.18x speed-up)
Chromium/Linux 401.15 runs/s => 484.45 runs/s (1.20x speed-up)

Previously Node::querySelector() and Node::querySelectorAll() had been
parsing CSS queries every time. This patch optimizes the performance by caching
parsed results onto a Document.

The cache is invalidated when any of CSS related variables is updated.
As per the current implementation of CSSParserContext::operator==(), the CSS related
variables are as follows:

  • baseURI
  • charset
  • mode
  • isHTMLDocument
  • isCSSCustomFilterEnabled
  • isCSSRegionsEnabled
  • needsSiteSpecificQuirks
  • enforcesCSSMIMETypeInNoQuirksMode

Actually, we do not need to watch all of these variables:

  • The current implementation does not watch the change of charset.

charset is always set to a null String by CSSParserContext::CSSParserContext().

  • isHTMLDocument never changes.
  • isCSSCustomFilterEnabled, isCSSRegionsEnabled, needsSiteSpecificQuirks and

enforcesCSSMIMETypeInNoQuirksMode are not flipped in a user scenario.
If someone changes them, it would be reasonable to expect them
to take the effect only on subsequent document loads.
Thus we do not need to invalidate the cache when these variables are updated.

Consequently, the condition under which we have to invalidate the cache is
that any of the following variables is updated:

  • baseURI
  • mode

Tests: fast/dom/SelectorAPI/*. No change in test results.

  • dom/SelectorQuery.h: SelectorQueryCache is a cache from CSS selectors to parsed results.

SelectorQueryCache::Entry is an entry of the cache.
SelectorQueryCache::Entry holds a SelectorQuery object and a CSSSelectorList object.
The reason why SelectorQueryCache::Entry needs to hold the CSSSelectorList object
is that the CSSSelectorList object keeps the lifetime of CSSSelector objects
in the SelectorQuery object. Since the SelectorQuery object just holds pointers
to CSSSelector objects, the CSSSelectorList object must not be destructed
before the SelectorQuery object is destructed.
(WebCore):
(SelectorDataList):
(WebCore::SelectorQuery::SelectorQuery):
(SelectorQuery):
(SelectorQueryCache):
(WebCore::SelectorQueryCache::SelectorQueryCache):
(Entry):
(WebCore::SelectorQueryCache::Entry::selectorQuery):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::initialize):
(WebCore::SelectorQueryCache::Entry::Entry):
(WebCore::SelectorQueryCache::add): Returns a cached SelectorQuery object if any.
Otherwise, parses a given CSS selector, creates a SelectorQuery object,
adds the SelectorQuery object to a new entry in the cache, returns the SelectorQuery
object.
(WebCore::SelectorQueryCache::invalidate): Clears the cache.

  • dom/Document.h:

(WebCore):
(Document):

  • dom/Document.cpp:

(WebCore::Document::selectorQueryCache):
(WebCore):
(WebCore::Document::setCompatibilityMode): Invalidates the cache
when m_compatibilityMode is updated.
(WebCore::Document::updateBaseURL): Invalidates the cache
when m_baseURL is updated.

  • dom/Node.h: Changed String to AtomicString, since the key of the cache

should be AtomicString.
(Node):

  • dom/Node.cpp: Optimized the code by using the cache.

(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):

12:05 Changeset [119329] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Reverted the last change.

  • WebCore.xcodeproj/project.pbxproj:
12:02 Changeset [119328] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Reverted the last change.

  • WebKit2.xcodeproj/project.pbxproj:
11:59 Changeset [119327] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Stop treating Perl code as private headers.

  • WebCore.xcodeproj/project.pbxproj: Removed CodeGenerator.pm, generate-bindings.pl,

IDLParser.pm, IDLStructure.pm, and preprocessor.pm from the Copy Headers build phase.

11:57 Changeset [119326] by fischman@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] SKIP http/tests/media/video-buffered.html because it requires overly large data
https://bugs.webkit.org/show_bug.cgi?id=88172

Unreviewed gardening.

  • platform/chromium/TestExpectations:
11:54 Changeset [119325] by kevino@webkit.org
  • 2 edits in trunk

[wx] Unreviewed build fix. Temporarily disable DerivedSources cleanup on Windows.

11:43 Changeset [119324] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop treating two Python scripts as private headers.

  • WebKit2.xcodeproj/project.pbxproj: Removed model.py and parser.py from the Copy Headers

build phase.

09:58 Changeset [119323] by ossy@webkit.org
  • 6 edits
    37 moves
    17 adds
    5 deletes in trunk/LayoutTests

[Qt] Replace QtXmlPatterns usage with libxslt dependency
https://bugs.webkit.org/show_bug.cgi?id=76820

Unreviewed gardening.

  • fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Renamed from LayoutTests/platform/efl/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt.
  • platform/efl/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Removed.
  • platform/gtk/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Removed.
  • platform/gtk/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Removed.
  • platform/mac/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Removed.
  • platform/mac/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Removed.
  • platform/qt-4.8/Skipped:
  • platform/qt-4.8/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt.
  • platform/qt-4.8/fast/dom/Range/surround-contents-font-face-crash-expected.txt: Renamed from LayoutTests/platform/qt/fast/dom/Range/surround-contents-font-face-crash-expected.txt.
  • platform/qt-4.8/fast/dom/xml-parser-error-message-crash-expected.txt: Renamed from LayoutTests/platform/qt/fast/dom/xml-parser-error-message-crash-expected.txt.
  • platform/qt-4.8/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Renamed from LayoutTests/platform/qt/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt.
  • platform/qt-4.8/fast/events/xsl-onload-expected.txt: Renamed from LayoutTests/platform/qt/fast/events/xsl-onload-expected.txt.
  • platform/qt-4.8/fast/parser/xml-colon-entity-expected.txt: Renamed from LayoutTests/platform/qt/fast/parser/xml-colon-entity-expected.txt.
  • platform/qt-4.8/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Renamed from LayoutTests/platform/qt/fast/parser/xml-declaration-missing-ending-mark-expected.txt.
  • platform/qt-4.8/fast/parser/xslt-with-html-expected.txt: Renamed from LayoutTests/platform/qt/fast/parser/xslt-with-html-expected.txt.
  • platform/qt-4.8/fast/xsl/subframe-location-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/subframe-location-expected.txt.
  • platform/qt-4.8/fast/xsl/transform-to-html-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/transform-to-html-expected.txt.
  • platform/qt-4.8/fast/xsl/utf8-chunks-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/utf8-chunks-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-bad-import-uri-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-bad-import-uri-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-doc-noenc-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-doc-noenc-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-entity-enc-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-entity-enc-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-entity-expected.png: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-entity-expected.png.
  • platform/qt-4.8/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt.
  • platform/qt-4.8/fast/xsl/xslt-recursion-expected.txt: Renamed from LayoutTests/platform/qt/fast/xsl/xslt-recursion-expected.txt.
  • platform/qt-4.8/http/tests/misc/location-test-xsl-style-sheet-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/misc/location-test-xsl-style-sheet-expected.txt.
  • platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt.
  • platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt.
  • platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt.
  • platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.png: Renamed from LayoutTests/platform/qt/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.png.
  • platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.txt.
  • platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.png: Renamed from LayoutTests/platform/qt/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.png.
  • platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.txt.
  • platform/qt-4.8/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xml-external-entity-expected.txt.
  • platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt.
  • platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt.
  • platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt.
  • platform/qt-4.8/svg/custom/bug45331-expected.png: Renamed from LayoutTests/platform/qt/svg/custom/bug45331-expected.png.
  • platform/qt-4.8/svg/custom/bug45331-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/bug45331-expected.txt.
  • platform/qt-4.8/svg/custom/bug78807-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/bug78807-expected.txt.
  • platform/qt-4.8/svg/custom/use-invalid-html-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-invalid-html-expected.txt.
  • platform/qt-4.8/svg/custom/use-invalid-style-expected.txt: Renamed from LayoutTests/platform/qt/svg/custom/use-invalid-style-expected.txt.
  • platform/qt-4.8/svg/hixie/error/dumpAsText/004-expected.txt: Renamed from LayoutTests/platform/qt/svg/hixie/error/dumpAsText/004-expected.txt.
  • platform/qt-4.8/svg/hixie/error/dumpAsText/005-expected.txt: Renamed from LayoutTests/platform/qt/svg/hixie/error/dumpAsText/005-expected.txt.
  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Added.
  • platform/qt-5.0/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Added.
  • platform/qt-arm/Skipped:
  • platform/qt/Skipped:
07:53 Changeset [119322] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART III)
https://bugs.webkit.org/show_bug.cgi?id=88019

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

Enter 'pure-with-mouse-conversion' mode when going fullscreen, so
that it prevents user from scrolling the WebPage, pinch zooming,
touch-and-hold, enter selection mode, etc ...

Internally reviewed by Gen Mak.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • Api/WebPage_p.h:

(WebPagePrivate):

07:52 Changeset [119321] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART II)
https://bugs.webkit.org/show_bug.cgi?id=88019

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

When an element goes fullscreen, its wrapper/container obeys all
BlackBerry specific fixed position customizations: we fixed
against Y, but not X. Then, in order to have the wrapper element
properly positioned when entering fullscreen mode, we
temporarily scroll x to 0.

The original x scroll position is restored when we leave
fullscreen.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):

  • Api/WebPage_p.h:

(WebPagePrivate):

07:52 Changeset [119320] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] browser video player fullscreen mode (portrait) - out of screen/focus - cannot navigate or use the buttons on the screen (PART I)
https://bugs.webkit.org/show_bug.cgi?id=88019
PR #158266

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

The way elements go fullscreen with the new FULLSCREEN_API
is that they get cloned and added to an out-of-DOM wrapper
element. The wrapper is a normal fixed position element and
then zoom in/out accordingly to how other layers do: following
WebPage's scale.

When going fullscreen, we have to take the current WebPage scale
into account in order to properly fit the element to the screen,
regardless the web page scale.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore):
(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

07:48 Changeset [119319] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix after r119255.

  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
07:01 Changeset [119318] by zeno.albisser@nokia.com
  • 20 edits in trunk

Fix and enable WebGL for WebKit2 on Qt.
https://bugs.webkit.org/show_bug.cgi?id=86214

Source/WebCore:

Make GraphicsContext3DPrivate use GraphicsSurfaces
for WK2. The GraphicsContext3D then uses the existing
RenderBuffer for multisample rendering.
When WebGraphicsLayer::syncCompositingState is being
executed, the canvas is being synced as well. This means
that the RenderBuffer contents are being blit onto
a GraphicsSurface, and the GraphicsSurface token is
being sent to the UIProcess.
The WebLayerTreeRenderer then creates a
TextureMapperSurfaceBackingStore for the canvas and
passes the GraphicsSurface token as an argument.
The token can then be used to identify the GraphicsSurface
from the UIProcess side.

Reviewed by Noam Rosenthal.

  • platform/graphics/GraphicsContext3D.h:

Added createGraphicsSurfaces function. This is currently only
being used by the Qt port.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::reshape):
Calling the createGraphicsSurfaces function when the GraphicsContext3D
is reshaped. This is currently only relevant for the Qt port.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(GraphicsContext3DPrivate):
Added m_frontBufferGraphicsSurface, m_backBufferGraphicsSurface
and m_surfaceFlags members.
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
In case of WK2, create a QOpenGLContext and two GraphicsSurface
for sharing the WebGL content with the UIProcess. One GraphicsSurface
is being used as the front, the other one as the backbuffer.
Creating a QOpenGLContext currently requires showing a QWindow.
For the moment we therefore create a minimal QWindow and place
it offscreen.
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
This new function is called from the WebGraphicsLayer,
to blit the multisample framebuffer and copy its contents
onto the GraphicsSurface.
(WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
Whenever the GraphicsContext3D is being reshaped,
new GraphicsSurfaces must be created with the updated dimensions.
(WebCore::GraphicsContext3D::createGraphicsSurfaces):

  • platform/graphics/texmap/TextureMapperPlatformLayer.h:

Added a new virtual function copyToGraphicsSurface.
(TextureMapperPlatformLayer):
(WebCore::TextureMapperPlatformLayer::copyToGraphicsSurface):

Source/WebKit2:

Added glue code to make use of GraphicsSurface
as a backend for the webgl-canvas in case of WK2.

Reviewed by Noam Rosenthal.

  • UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::webGLEnabled):
(QWebPreferences::setWebGLEnabled):

  • UIProcess/API/qt/qwebpreferences_p.h:
  • UIProcess/API/qt/qwebpreferences_p_p.h:

Added WebGLEnabled enum to allow enabling/disabling of
WebGL using QWebPreferences.

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::syncCanvas):
Dispatch syncCanvas calls to the apropriate
WebLayerTreeRenderer.

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.messages.in:
  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::syncCanvas):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
Create a TextureMapperSurfaceBackingStore for the canvas
if necessary and pass or update the graphicsSurfaceToken
for to be used with the backing store.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore):
(WebCore::WebGraphicsLayer::setContentsToCanvas):
(WebCore::WebGraphicsLayer::syncCanvas):
Copy the multisample framebuffer contents onto the GraphicsSurface.
Notify the UIProcess of the availability of a new texture.
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
Sync the canvas as well.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

Added a pure virtual function syncCanvas.
This is guarded by PLATFORM(QT).
(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::syncLayerChildren):
(WebKit):
(WebKit::LayerTreeHostQt::syncCanvas):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

Tools:

Enable WebGL by default for Qt MiniBrowser.

Reviewed by Noam Rosenthal.

  • MiniBrowser/qt/qml/BrowserWindow.qml:
02:46 Changeset [119317] by rniwa@webkit.org
  • 3 edits
    6 moves in trunk

Tools: Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=88164

Reviewed by Kentaro Hara.

Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.

  • Scripts/VCSUtils.pm:

(adjustPathForRecentRenamings):
(fixChangeLogPatch):

LayoutTests: Rename test_expectations.txt to TestExpectations.

  • platform/chromium/TestExpectations: Copied from LayoutTests/platform/chromium/test_expectations.txt.
  • platform/chromium/test_expectations.txt: Removed.
  • platform/efl/TestExpectations: Copied from LayoutTests/platform/efl/test_expectations.txt.
  • platform/efl/test_expectations.txt: Removed.
  • platform/gtk/TestExpectations: Copied from LayoutTests/platform/gtk/test_expectations.txt.
  • platform/gtk/test_expectations.txt: Removed.
  • platform/mac/TestExpectations: Copied from LayoutTests/platform/mac/test_expectations.txt.
  • platform/mac/test_expectations.txt: Removed.
  • platform/qt/TestExpectations: Copied from LayoutTests/platform/qt/test_expectations.txt.
  • platform/qt/test_expectations.txt: Removed.
  • platform/win/TestExpectations: Copied from LayoutTests/platform/win/test_expectations.txt.
  • platform/win/test_expectations.txt: Removed.
01:15 Changeset [119316] by tony@chromium.org
  • 55 edits in trunk

Rename the flexbox CSS propery values from start to flex-start and end to flex-end
https://bugs.webkit.org/show_bug.cgi?id=88152

Reviewed by Ojan Vafai.

Source/WebCore:

The spec changed. This is to differentiate from start/end which will
depend on writing mode direction, rather than flex direction.

No new tests, just updated the existing values.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EAlignContent):

  • css/CSSValueKeywords.in:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::initialJustifyContentOffset):
(WebCore::alignmentForChild):
(WebCore::initialAlignContentOffset):
(WebCore::RenderFlexibleBox::alignFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Rename start to flex-start and end to flex-end.

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-align-column.html:
  • css3/flexbox/flex-align-end.html:
  • css3/flexbox/flex-align-vertical-writing-mode.html:
  • css3/flexbox/flex-align.html:
  • css3/flexbox/flex-pack.html:
  • css3/flexbox/line-wrapping.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-column-auto.html:
  • css3/flexbox/multiline-line-pack-horizontal-column-expected.txt:
  • css3/flexbox/multiline-line-pack-horizontal-column.html:
  • css3/flexbox/multiline-line-pack.html:
  • css3/flexbox/multiline-pack-expected.txt:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-reverse-wrap-baseline.html:
  • css3/flexbox/multiline-reverse-wrap-overflow.html:
  • css3/flexbox/multiline-shrink-to-fit.html:
  • css3/flexbox/multiline.html:
  • css3/flexbox/nested-stretch.html:
  • css3/flexbox/orthogonal-flex-directions.html:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
00:12 Changeset [119315] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Use 'Ok' and 'Cancel' buttons in JavaScript confirm box.
https://bugs.webkit.org/show_bug.cgi?id=76190
Based on Johannes Obermayrs (johannesobermayr@gmx.de) patch.
See: http://www.javascripter.net/faq/confirm.htm
Fixes: https://bugs.kde.org/show_bug.cgi?id=287629

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-02
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:

(QWebPage::javaScriptConfirm):

06/01/12:

23:44 Changeset [119314] by rniwa@webkit.org
  • 19 edits in trunk/Tools

Rename test_expectations.txt to TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=86690

Reviewed by Dirk Pranke.

Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
We can the code to read test_expectations.txt once we've successfully transitioned.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._check_path_does_not_exist):
(TestExpectationParser._tokenize):
(TestExpectations): Removed TEST_LIST, which is not used anywhere.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
test_expectations.txt if one exists and the path to TestExpectations otherwise.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
virtual.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.path_from_chromium_base):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.test_expectations):

  • Scripts/webkitpy/layout_tests/port/test.py:

(add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
(TestPort.init):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.baseline_search_path):
(WebKitPort.test_expectations):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these

tests to base as a follow up.
(WebKitPortTest.test_path_to_test_expectations_file):
(test_test_expectations):
(test_legacy_test_expectations):

  • Scripts/webkitpy/style/checker.py:

(CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
with one for TestExpectations.

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
test_expectations.txt.
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
(TestExpectationsTestCase.assert_lines_lint):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintExpectations.init):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineExpectations):

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit._check_test_expectations):

  • Scripts/webkitpy/tool/steps/commit_unittest.py:

(CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
(CommitTest.test_check_test_expectations): For TestExpectations.
(CommitTest.test_check_legacy_test_expectations): For test_expectations.txt

  • TestResultServer/static-dashboards/dashboard_base.js:

(requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
Error only when neither exists.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(processMissingAndExtraExpectations):
(htmlForTestsWithExpectationsButNoFailures):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
23:07 Changeset [119313] by commit-queue@webkit.org
  • 61 edits
    1 copy
    1 add in trunk/Source

[chromium] Software compositor initialization and base classes
https://bugs.webkit.org/show_bug.cgi?id=87920

Patch by Alexandre Elias <aelias@google.com> on 2012-06-01
Reviewed by James Robinson.

Source/Platform:

Add a new setting to force software compositing. In this mode,
no GraphicsContext3D should ever be created.

  • chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

This introduces new wrapper class CCGraphicsContext and base class
CCRenderer which will be used for software compositing support.
If no GraphicsContext3D is available, early return for now.

No new tests. (No-op change in 3d mode.)

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(Texture):
(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(BitmapSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(FrameBufferSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::Texture::updateRect):
(WebCore::ImageLayerTextureUpdater::updateTextureRect):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::CCRenderer::toGLMatrix):
(WebCore):
(WebCore::LayerRendererChromium::create):
(WebCore::CCRenderer::CCRenderer):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::copyPlaneToTexture):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):

  • platform/graphics/chromium/LayerRendererChromium.h:

(CCRenderer):
(WebCore::CCRenderer::~CCRenderer):
(WebCore::CCRenderer::ccContext):
(WebCore::CCRenderer::settings):
(WebCore::CCRenderer::viewportSize):
(WebCore::CCRenderer::viewportWidth):
(WebCore::CCRenderer::viewportHeight):
(WebCore::CCRenderer::projectionMatrix):
(WebCore::CCRenderer::windowMatrix):
(WebCore::CCRenderer::sharedGeometryQuad):
(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/LayerTextureSubImage.cpp:

(WebCore::LayerTextureSubImage::upload):
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):

  • platform/graphics/chromium/LayerTextureSubImage.h:

(WebCore):
(LayerTextureSubImage):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore):
(Texture):

  • platform/graphics/chromium/ManagedTexture.cpp:

(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):

  • platform/graphics/chromium/ManagedTexture.h:

(WebCore):
(ManagedTexture):

  • platform/graphics/chromium/RenderSurfaceChromium.cpp:
  • platform/graphics/chromium/TextureCopier.cpp:

(WebCore::AcceleratedTextureCopier::copyTexture):

  • platform/graphics/chromium/TextureCopier.h:

(TextureCopier):
(AcceleratedTextureCopier):

  • platform/graphics/chromium/TextureUploader.h:

(TextureUploader):

  • platform/graphics/chromium/ThrottledTextureUploader.cpp:

(WebCore::ThrottledTextureUploader::uploadTexture):

  • platform/graphics/chromium/ThrottledTextureUploader.h:

(ThrottledTextureUploader):

  • platform/graphics/chromium/cc/CCGraphicsContext.h: Copied from Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.h.

(WebCore):
(CCGraphicsContext):
(WebCore::CCGraphicsContext::create2D):
(WebCore::CCGraphicsContext::create3D):
(WebCore::CCGraphicsContext::context3D):
(WebCore::CCGraphicsContext::CCGraphicsContext):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::draw):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::willDraw):
(WebCore::CCLayerImpl::bindContentsTexture):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):
(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::createContext):
(WebCore::CCLayerTreeHost::context):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHostClient):
(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::context):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::layerRenderer):

  • platform/graphics/chromium/cc/CCProxy.h:

(WebCore):
(CCProxy):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::willDraw):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::recreateContext):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::update):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::initializeContextOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::reserveTextures):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

Add a new setting to force software compositing. In this mode,
no GraphicsContext3D should ever be created.

  • public/WebSettings.h:
  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::context):

  • src/WebLayerTreeViewImpl.cpp:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setForceSoftwareCompositing):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::forceSoftwareCompositing):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createCompositorGraphicsContext3D):
(WebKit::WebViewImpl::createContext3D):

  • tests/CCLayerTreeHostImplTest.cpp:

(WebKitTests::CCLayerTreeHostImplTest::createContext):
(WebKitTests::TEST_F):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):

  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::Texture::updateRect):

  • tests/CCTiledLayerTestCommon.h:

(Texture):
(WebKitTests::FakeTextureCopier::copyTexture):
(WebKitTests::FakeTextureUploader::uploadTexture):

  • tests/Canvas2DLayerChromiumTest.cpp:

(Canvas2DLayerChromiumTest::fullLifecycleTest):

  • tests/FakeCCLayerTreeHostClient.h:
  • tests/LayerRendererChromiumTest.cpp:

(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(LayerRendererChromiumTest):
(TEST):

  • tests/TextureCopierTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

22:47 Changeset [119312] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Suppress text diff on http/tests/media/video-buffered.html on Chromium Leopard as
it has been failing on Leopard since it was re-enabled in http://trac.webkit.org/changeset/119268.
The failure is tracked by the bug 88160.

  • platform/chromium/test_expectations.txt:
20:20 Changeset [119311] by commit-queue@webkit.org
  • 19 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r119283, r119287, and r119291.
http://trac.webkit.org/changeset/119283
http://trac.webkit.org/changeset/119287
http://trac.webkit.org/changeset/119291
https://bugs.webkit.org/show_bug.cgi?id=88159

Not only broke compilation in the initial commit but also
broke LayerChromiumTest.basicCreateAndDestroy (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01

Source/WebCore:

  • WebCore.gypi:
  • platform/graphics/chromium/AnimationTranslationUtil.cpp: Removed.
  • platform/graphics/chromium/AnimationTranslationUtil.h: Removed.
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):

  • platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::LinkHighlight):

  • platform/graphics/chromium/cc/CCAnimationCurve.h:

(CCTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:

(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCTransformKeyframe):
(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::addAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::add):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationControllerClient):
(CCLayerAnimationController):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.cpp:

(WebCore::addOpacityTransition):
(WebCore::addAnimatedTransform):
(WebKitTests::FakeTransformTransition::getValue):

  • tests/CCAnimationTestCommon.h:
  • tests/CCKeyframedAnimationCurveTest.cpp:
  • tests/CCLayerAnimationControllerTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted):
(WebKitTests::MockGraphicsLayerClient::notifySyncRequired):
(WebKitTests::MockGraphicsLayerClient::paintContents):
(WebKitTests::MockGraphicsLayerClient::showDebugBorders):
(WebKitTests::MockGraphicsLayerClient::showRepaintCounter):
(WebKitTests::TEST):

20:17 Changeset [119310] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Large number constant in TransformationMatrix::projectPoint overflows FractionalLayoutUnits with sub-pixel layout enabled
https://bugs.webkit.org/show_bug.cgi?id=87896

Reviewed by James Robinson.

kLargeNumber is meant to avoid overflowing when projecting a point through a transform. Unfortunately,
due to FractionalLayoutUnit's diminished range compared to integers, we were overflowing anyways. This
change adjusts our large number by the same value, but adjusted for our denominator.

This was originally missed because transforms/3d is marked as pass/fail in Chromium's test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=66989 tracks removing this problem.

No new tests. Covered by transforms/3d/hit-testing/perspective-clipped.html

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::projectPoint):

19:47 Changeset [119309] by wangxianzhu@chromium.org
  • 4 edits in trunk

Remove dependency from ImageDiff to WTF
https://bugs.webkit.org/show_bug.cgi?id=88147

Reviewed by Adam Barth.

Source/WTF:

  • WTF.gyp/WTF.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
19:09 Changeset [119308] by dpranke@chromium.org
  • 5 edits in trunk/Tools

NRWT seems to leak (more?) temp dirs
https://bugs.webkit.org/show_bug.cgi?id=88126

Re-land r119297 with chromium fix (weren't calling the
super() method if not in --test-shell mode in start().
Add unit tests to chromium_unittest as well to check.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumDriver.start):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.del):
(WebKitDriver._start):
(WebKitDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_stop_cleans_up_properly):
(WebKitDriverTest):
(WebKitDriverTest.test_two_starts_cleans_up_properly):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumDriverTest.test_stop_cleans_up_properly):
(ChromiumDriverTest.test_two_starts_cleans_up_properly):

18:38 Changeset [119307] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebCore

Cleanup GeneratorGeneratedImage/Gradient changes from r117858
https://bugs.webkit.org/show_bug.cgi?id=88063

Reviewed by Simon Fraser.

No new tests, code cleanup.

  • platform/graphics/Generator.h:

(WebCore::Generator::hash): hash() should be const.

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::drawPattern): Minor cleanup.

  • platform/graphics/Gradient.cpp:

(WebCore::Gradient::Gradient): Rename m_hashCache to m_cachedHash.
(WebCore::Gradient::addColorStop): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::sortStopsIfNecessary): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setSpreadMethod): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setGradientSpaceTransform): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::hash): Use intHash instead of the pair hasher. Add compile time size checks
for structures being passed to StringHasher.

  • platform/graphics/Gradient.h:

(WebCore::Gradient::setP0): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setP1): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setStartRadius): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setEndRadius): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::invalidateHash): Rename clearHashCache to invalidateHash.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::scalesMatch): Added. Determine if the scale of two AffineTransforms match.
(WebCore::GraphicsContext::isCompatibleWithBuffer): Make use of scalesMatch to simplify the logic.

18:26 Changeset [119306] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip more asserting tests on Windows.

  • platform/win/Skipped:
18:26 Changeset [119305] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Lots of "failed download-built-product" on Apple bots
https://bugs.webkit.org/show_bug.cgi?id=88158

Reviewed by Jessie Berlin.

Disable mergeRequests on all Apple builders. This is a speculative fix.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
18:00 Changeset [119304] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r119297.
http://trac.webkit.org/changeset/119297
https://bugs.webkit.org/show_bug.cgi?id=88156

May have broken Chromium bots (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.del):
(WebKitDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_stop_cleans_up_properly):

17:22 Changeset [119303] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG CFA should know that PutByVal can clobber the world
https://bugs.webkit.org/show_bug.cgi?id=88155

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

LayoutTests:

  • fast/js/dfg-putbyval-cfa-clobber-expected.txt: Added.
  • fast/js/dfg-putbyval-cfa-clobber.html: Added.
  • fast/js/script-tests/dfg-putbyval-cfa-clobber.js: Added.

(foo.bar):
(foo):

17:09 Changeset [119302] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Remove RefInfo class
https://bugs.webkit.org/show_bug.cgi?id=87904

Patch by Raymond Toy <rtoy@google.com> on 2012-06-01
Reviewed by Chris Rogers.

No new tests; covered by existing tests.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::~AudioBufferSourceNode): Clear
panner node.
(WebCore::AudioBufferSourceNode::totalPitchRate):
(WebCore::AudioBufferSourceNode::setPannerNode): Use
RefTypeConnection counting for panner node.
(WebCore):
(WebCore::AudioBufferSourceNode::clearPannerNode): New function to

clear panner node in AudioBufferSourceNode.

(WebCore::AudioBufferSourceNode::finish): Clear panner node when done.

  • Modules/webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode): Add virtual finish(), m_pannerNode is not
a RefPtr anymore.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::addDeferredFinishDeref): Remove unneeded RefTyp.
(WebCore::AudioContext::handleDeferredFinishDerefs): Remove
unneeded RefType.

  • Modules/webaudio/AudioContext.h:

(AudioContext): Update addDeferredFinishDeref signature.

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::deref): Update call to addDeferredFinishDeref.

  • Modules/webaudio/AudioScheduledSourceNode.h:

(AudioScheduledSourceNode): Make finish() virtual.

16:54 Changeset [119301] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFA should mark basic blocks as having constants if local accesses yield constants
https://bugs.webkit.org/show_bug.cgi?id=88153

Reviewed by Gavin Barraclough.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

16:47 Changeset [119300] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG arguments simplification phase uses a node.codeOrigin after appending a node
https://bugs.webkit.org/show_bug.cgi?id=88151

Reviewed by Geoffrey Garen.

The right thing to do is to save the CodeOrigin before appending to the graph.

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

16:18 Changeset [119299] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG should not emit unnecessary speculation checks when performing an int32 to double conversion on
a value that is proved to be a number, predicted to be an int32, but not proved to be an int32
https://bugs.webkit.org/show_bug.cgi?id=88146

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):

LayoutTests:

  • fast/js/dfg-int32-to-double-on-known-number-expected.txt: Added.
  • fast/js/dfg-int32-to-double-on-known-number.html: Added.
  • fast/js/script-tests/dfg-int32-to-double-on-known-number.js: Added.

(foo.bar):
(foo):

16:18 Changeset [119298] by tony@chromium.org
  • 60 edits in trunk

rename -webkit-flex-pack and -webkit-flex-line-pack to -webkit-justify-content and -webkit-align-content
https://bugs.webkit.org/show_bug.cgi?id=88113

Reviewed by Ojan Vafai.

Source/WebCore:

This recently changed in the spec:
http://dev.w3.org/csswg/css3-flexbox/#justify-content-property
http://dev.w3.org/csswg/css3-flexbox/#align-content-property

No new tests, updated existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EAlignContent):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::initialJustifyContentOffset):
(WebCore::justifyContentSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
(WebCore::initialAlignContentOffset):
(WebCore::alignContentSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::alignFlexLines):

  • rendering/RenderFlexibleBox.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

Find and replace for the CSS keywords.

  • css3/flexbox/columns-auto-size.html:
  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-pack.html:
  • css3/flexbox/multiline-align.html:
  • css3/flexbox/multiline-column-auto.html:
  • css3/flexbox/multiline-line-pack-expected.txt:
  • css3/flexbox/multiline-line-pack-horizontal-column-expected.txt:
  • css3/flexbox/multiline-line-pack-horizontal-column.html:
  • css3/flexbox/multiline-line-pack.html:
  • css3/flexbox/multiline-pack-expected.txt:
  • css3/flexbox/multiline-pack.html:
  • css3/flexbox/multiline-reverse-wrap-overflow.html:
  • css3/flexbox/multiline-shrink-to-fit.html:
  • css3/flexbox/multiline.html:
  • css3/flexbox/nested-stretch.html:
  • css3/flexbox/position-absolute-child.html:
  • css3/flexbox/true-centering.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
16:11 Changeset [119297] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt seems to leak tmpdirs
https://bugs.webkit.org/show_bug.cgi?id=88126

Reviewed by Ojan Vafai.

Fix leak possibly introduced in r118979 - we now will
make sure we clean up any stale temp directories during the
start routine and attempt to clean up again in del. It
turns out that asserting in del logs a message but is
caught by the runtime, so it's mostly useless.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver.del):
(WebKitDriver._start):
(WebKitDriver.run_test):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_stop_cleans_up_properly):
(WebKitDriverTest):
(WebKitDriverTest.test_two_starts_cleans_up_properly):

16:09 Changeset [119296] by ap@apple.com
  • 6 edits
    1 delete in trunk/LayoutTests

Make cookie tests debuggable by merging scripts into HTML
https://bugs.webkit.org/show_bug.cgi?id=88143

Reviewed by Anders Carlsson.

  • http/tests/cookies/double-quoted-value-with-semi-colon.html:
  • http/tests/cookies/multiple-cookies.html:
  • http/tests/cookies/script-tests: Removed.
  • http/tests/cookies/script-tests/TEMPLATE.html: Removed.
  • http/tests/cookies/script-tests/double-quoted-value-with-semi-colon.js: Removed.
  • http/tests/cookies/script-tests/multiple-cookies.js: Removed.
  • http/tests/cookies/script-tests/simple-cookies-expired.js: Removed.
  • http/tests/cookies/script-tests/simple-cookies-max-age.js: Removed.
  • http/tests/cookies/script-tests/single-quoted-value.js: Removed.
  • http/tests/cookies/simple-cookies-expired.html:
  • http/tests/cookies/simple-cookies-max-age.html:
  • http/tests/cookies/single-quoted-value.html:
15:59 Changeset [119295] by jberlin@webkit.org
  • 1 edit
    48 adds in trunk/LayoutTests

[Win] Windows 7 Release Testers report many compositing failures
https://bugs.webkit.org/show_bug.cgi?id=88040

Part 2 of adding expected (failing?) results to get the bots greener.

  • platform/win/compositing/images: Added.
  • platform/win/compositing/images/clip-on-directly-composited-image-expected.txt: Added.
  • platform/win/compositing/images/direct-image-background-color-expected.txt: Added.
  • platform/win/compositing/images/direct-pdf-image-expected.txt: Added.
  • platform/win/compositing/images/direct-svg-image-expected.txt: Added.
  • platform/win/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
  • platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-animation-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-child-layer-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-clipping-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-transformed-layer-expected.txt: Added.
  • platform/win/compositing/layer-creation/overlap-transforms-expected.txt: Added.
  • platform/win/compositing/layer-creation/rotate3d-overlap-expected.txt: Added.
  • platform/win/compositing/layer-creation/scroll-partial-update-expected.txt: Added.
  • platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
  • platform/win/compositing/layer-creation/stacking-context-overlap-expected.txt: Added.
  • platform/win/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
  • platform/win/compositing/layer-creation/translatez-overlap-expected.txt: Added.
  • platform/win/compositing/masks: Added.
  • platform/win/compositing/masks/direct-image-mask-expected.txt: Added.
  • platform/win/compositing/masks/masked-ancestor-expected.txt: Added.
  • platform/win/compositing/masks/multiple-masks-expected.txt: Added.
  • platform/win/compositing/masks/simple-composited-mask-expected.txt: Added.
  • platform/win/compositing/overflow/ancestor-overflow-expected.txt
  • platform/win/compositing/overflow/clip-descendents-expected.txt: Added.
  • platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/win/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • platform/win/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
  • platform/win/compositing/overflow/overflow-positioning-expected.txt: Added.
  • platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
  • platform/win/compositing/overflow/resize-painting-expected.txt: Added.
  • platform/win/compositing/rtl: Added.
  • platform/win/compositing/rtl/rtl-absolute-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/win/compositing/rtl/rtl-relative-expected.txt: Added.
  • platform/win/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
  • platform/win/compositing/visibility: Added.
  • platform/win/compositing/visibility/layer-visible-content-expected.txt: Added.
  • platform/win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
15:53 Changeset [119294] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Overflow scrolling doesn't need to create a stacking context is the overflow is hidden
https://bugs.webkit.org/show_bug.cgi?id=88057

Reviewed by James Robinson.

This patch causes us to match the iOS implementation of this feature.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

15:50 Changeset [119293] by mrowe@apple.com
  • 4 edits in branches/safari-536-branch/Source

Versioning.

15:44 Changeset [119292] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG constant folding search for the last local access skips the immediately previous local access
https://bugs.webkit.org/show_bug.cgi?id=88141

Source/JavaScriptCore:

Reviewed by Michael Saboff.

If you use a loop in the style of:

for (i = start; i--;)

then you need to remember that the first value of 'i' that the loop body will see is 'start - 1'.
Hence the following is probably wrong:

for (i = start - 1; i--;)

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

LayoutTests:

Reviewed by Michael Saboff.

  • fast/js/dfg-obvious-constant-cfa-expected.txt: Added.
  • fast/js/dfg-obvious-constant-cfa.html: Added.
  • fast/js/script-tests/dfg-obvious-constant-cfa.js: Added.

(bar.baz):
(bar):

15:43 Changeset [119291] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Use fully qualified name for Fixed to avoid the collision with "typedef SInt32 Fixed" in MacTypes.h

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKitTests::TEST_F):

15:34 Changeset [119290] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix the return value checking in SelectPopupClient
https://bugs.webkit.org/show_bug.cgi?id=88130

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-01
Reviewed by Rob Buis.

In SelectPopupClient, return '1' means selected, '0' means not selected,
the ASCII value of '0' is 48, not 32, use '0' to be more readable.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::setValueAndClosePopup):

15:32 Changeset [119289] by rniwa@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Chromium rebaseline after r119274.

  • platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/chromium-mac-leopard/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/chromium-win/fast/reflections/reflection-with-zoom-expected.png: Added.
15:15 Changeset [119288] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix a typo in the expected result for the test added in r119281.119281

  • fast/js/dfg-cse-cfa-discrepancy-expected.txt:
15:14 Changeset [119287] by jamesr@google.com
  • 5 edits in trunk/Source

[chromium] Unreviewed compile fix for r119283

For the record, Dana Jensens <danakj@chromium.org> wrote this slightly faster than I did.

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::bounds):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::bounds):

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.h:
15:11 Changeset [119286] by ap@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/cookies/simple-cookies-expired.html and simple-cookies-max-age.html are failing
https://bugs.webkit.org/show_bug.cgi?id=82749

I don't see any failures locally (other than sometimes as flakiness in all cookie
tests), and the bug report doesnt' have any information about what was wrong.

  • platform/mac/Skipped: Re-enable to see what happens.
14:59 Changeset [119285] by jberlin@webkit.org
  • 3 edits
    48 adds in trunk/LayoutTests

[Win] Windows 7 Release Testers report many compositing failures
https://bugs.webkit.org/show_bug.cgi?id=88040

Part 1 of adding expected (failing?) results to get the bots greener.

  • platform/win/compositing/geometry/flipped-writing-mode-expected.txt: Added.
  • platform/win/compositing/geometry/foreground-layer-expected.txt: Added.
  • platform/win/compositing/geometry/foreground-offset-change-expected.txt: Added.
  • platform/win/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
  • platform/win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
  • platform/win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
  • platform/win/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
  • platform/win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Added.
  • platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/win/compositing/geometry/outline-change-expected.txt: Added.
  • platform/win/compositing/geometry/partial-layout-update-expected.txt: Added.
  • platform/win/compositing/geometry/preserve-3d-switching-expected.txt: Added.
  • platform/win/compositing/geometry/root-layer-update-expected.txt: Added.
  • platform/win/compositing/geometry/tall-page-composited-expected.txt: Added.
  • platform/win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added.
  • platform/win/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
  • platform/win/compositing/geometry/video-opacity-overlay-expected.txt: Added.
  • platform/win/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
  • platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
  • platform/win/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
  • platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
  • platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-content-flipping-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-resize-expected.txt: Added.
  • platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
  • platform/win/compositing/iframes/invisible-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/invisible-nested-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Added.
  • platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/win/compositing/iframes/layout-on-compositing-change-expected.txt: Added.
  • platform/win/compositing/iframes/nested-iframe-scrolling-expected.txt: Added.
  • platform/win/compositing/iframes/overlapped-iframe-expected.txt: Added.
  • platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • platform/win/compositing/iframes/page-cache-layer-tree-expected.txt: Added.
  • platform/win/compositing/iframes/resizer-expected.txt: Added.
  • platform/win/compositing/iframes/scrolling-iframe-expected.txt: Added.
14:53 Changeset [119284] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding a TEXT expectation for http/tests/media/video-buffered.html
after it started failing in r119268.

  • platform/gtk/test_expectations.txt:
14:46 Changeset [119283] by commit-queue@webkit.org
  • 18 edits
    2 adds in trunk/Source

[chromium] Accelerated animations should use WebTransformOperations
https://bugs.webkit.org/show_bug.cgi?id=87686

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-01
Reviewed by James Robinson.

CCTransformKeyframe new owns a WebTransformOperations rather than a
TransformOperations. LayerChromium's API has been changed so that
LayerChromium::addAnimation should take only a CCActiveAnimation.
GraphicsLayerChromium is new responsible for translating to
WebTransformOperations and creating CCActiveAnimations. Tests that use
the public API (that is, they call addAnimation with KeyframeValueList
and Animation arguments) have been moved to GraphicsLayerChromiumTest.

Source/WebCore:

Unit tests:

GraphicsLayerChromiumTest.createOpacityAnimation
GraphicsLayerChromiumTest.createTransformAnimation
GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
GraphicsLayerChromiumTest.createTransformAnimationWithSingularMatrix
GraphicsLayerChromiumTest.createReversedAnimation
GraphicsLayerChromiumTest.createAlternatingAnimation
GraphicsLayerChromiumTest.createReversedAlternatingAnimation

  • WebCore.gypi:
  • platform/graphics/chromium/AnimationTranslationUtil.cpp: Added.

(WebCore):
(WebCore::toWebTransformOperations):
(WebCore::appendKeyframe):
(WebCore::CCKeyframedTransformAnimationCurve):
(WebCore::createActiveAnimation):

  • platform/graphics/chromium/AnimationTranslationUtil.h: Added.

(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromium):

  • platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::LinkHighlight):

  • platform/graphics/chromium/cc/CCAnimationCurve.h:

(CCTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:

(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCTransformKeyframe):
(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::removeAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::addAnimation):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationControllerClient):
(CCLayerAnimationController):

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.cpp:

(WebCore::addOpacityTransition):
(WebCore::addAnimatedTransform):
(WebKitTests::FakeTransformTransition::getValue):

  • tests/CCAnimationTestCommon.h:
  • tests/CCKeyframedAnimationCurveTest.cpp:

(WebCore::TEST):

  • tests/CCLayerAnimationControllerTest.cpp:

(WebKitTests::TEST):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):

  • tests/GraphicsLayerChromiumTest.cpp:

(MockLayerTreeHostClient):
(WebKitTests):
(MockLayerTreeHost):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::expectTranslateX):
(WebKitTests::TEST_F):

14:34 Changeset [119282] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

DFG constant folding should be OK with GetLocal of captured variables having a constant
https://bugs.webkit.org/show_bug.cgi?id=88137

Fix a typo that Gavin found but that I failed to fix in previous commit.

  • fast/js/script-tests/dfg-cse-cfa-discrepancy.js:
14:32 Changeset [119281] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

DFG constant folding should be OK with GetLocal of captured variables having a constant
https://bugs.webkit.org/show_bug.cgi?id=88137

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

LayoutTests:

  • fast/js/dfg-cse-cfa-discrepancy-expected.txt: Added.
  • fast/js/dfg-cse-cfa-discrepancy.html: Added.
  • fast/js/script-tests/dfg-cse-cfa-discrepancy.js: Added.

(foo.bar.baz):
(foo.bar):
(foo):

14:26 Changeset [119280] by msaboff@apple.com
  • 4 edits in trunk

WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
https://bugs.webkit.org/show_bug.cgi?id=88109

Reviewed by Geoffrey Garen.

Source/WebKit/mac:

Added short circuit return when the NSString to evaluate is nil.

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

Tools:

Additional test case.

  • TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:

(TestWebKitAPI::TEST):

14:04 Changeset [119279] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] ASSERT(enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()))
failed in RenderGeometryMap::absoluteRect
https://bugs.webkit.org/show_bug.cgi?id=88128

Add affected tests to the Windows Skipped list.

  • platform/win/Skipped:

Also, fix the line endings for this file.

14:00 Changeset [119278] by zandobersek@gmail.com
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed GTK gardening, adding new baselines after r119256.

  • platform/gtk/fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-ordering-5-expected.txt: Added.
  • platform/gtk/fast/viewport/viewport-legacy-ordering-6-expected.txt: Added.
13:47 Changeset [119277] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88131

Unreviewed addition to Chromium test expectations.

  • platform/chromium/test_expectations.txt:
13:23 Changeset [119276] by mihaip@chromium.org
  • 5 edits in trunk

Improve synchronous XHR disabling
https://bugs.webkit.org/show_bug.cgi?id=88032

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setSyncXHRInDocumentsEnabled): Fix a
copy-and-paste error

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open): Improves the disabled message, as
suggested in a comment after r118599 was put in the commit queue.

LayoutTests:

Update with new error message.

  • fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt:
13:22 Changeset [119275] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix QObject bridge tests in Qt5 after (not so) recent QVariant changes
https://bugs.webkit.org/show_bug.cgi?id=88127

Reviewed by Noam Rosenthal.

We were checking for invalid QVariants in a very odd way. Since in Qt5 the
userType of invalid changed to not be Void, this broke the tests for QtWebKit
with Qt5. Replace those checks with QVariant::isValid() calls.

  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::evalJS):
(tst_QObjectBridge::evalJSV):

13:20 Changeset [119274] by bdakin@apple.com
  • 4 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=87774
REGRESSION (r105515): reflection masks are truncated at zoom levels < 1
-and corresponding-
<rdar://problem/11387506>

Reviewed by Simon Fraser.

Source/WebCore:

paintNinePieceImage() expects un-zoomed results from
calculateImageIntrinsicDimensions(). This was previously addressed by having
paintNinePieceImage() divide the effective zoom out of the result from
calculateImageIntrinsicDimensions(). However, that results in buggy behavior for
generated images and images with percentage sizes. In the end it seems best to
just send a parameter to calculateImageIntrinsicDimensions() indicating whether
the caller wants the result to be scaled by the effective zoom when appropriate.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

LayoutTests:

  • fast/reflections/reflection-with-zoom.html: Added.
  • platform/mac/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/mac/fast/reflections/reflection-with-zoom-expected.txt: Added.
13:15 Changeset [119273] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Another Chromium test expectation update per the bug 88124.

Unreviewed Chromium test expectations fix.

  • platform/chromium/test_expectations.txt:
13:15 Changeset [119272] by jchaffraix@webkit.org
  • 6 edits in trunk/Source/WebCore

Prepare table collapsed border computation to support mixed directionality on row group
https://bugs.webkit.org/show_bug.cgi?id=88110

Reviewed by Ojan Vafai.

No expected change in behavior.

One big issue with supporting mixed directionality inside a table is that the start / end
borders don't align between table parts anymore: the start border of a ltr table will have
to match the end border of a rtl row group for the purpose of collapsed border computation.

This change adds the concept of adjoining borders in the table direction so that we can safely
hide which exact borders we pick up for the collapsed border computation.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
Refactored those functions to use proper naming along with the new APIs. The name 'adjoining' is
used extensively as we cannot make any assumptions on which borders we will get.

(WebCore::RenderTable::recalcBordersInRowDirection):
Added a FIXME found during testing.

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):

  • rendering/RenderTableRow.h:

(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
Those functions are the same at the moment to match the existing code. They
will be changed to use the proper directionality in a follow up patch.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
Those functions return the cells that is adjoining a table edge. Due to us flipping
the cells at layout to match the section's direction, those functions will need to
account for mixed direction in determining the right cell to consider.

13:13 Changeset [119271] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline of svg/css/getComputedStyle-basic for mac.

  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
13:08 Changeset [119270] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Indenting a paragraph that begins with a link 3 times breaks the paragraph into two paragraphs
https://bugs.webkit.org/show_bug.cgi?id=87428

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-06-01
Reviewed by Ryosuke Niwa.

Source/WebCore:

Fix the way lastNode (our insertion point) is updated whenever
traverseNextSibling moves up to a new parent, so that the relative
depth between the next sibling and the original start node is
maintained in the clone. The divergence in depth broke the paragraph
into two paragraphs because the next sibling was inserted outside the
blockquote that was created for the indentation.

Note that the topNode is not required anymore because it is no longer
used anywhere.

Tests: editing/execCommand/indent-nested-inlines-1.html

editing/execCommand/indent-nested-inlines-2.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

LayoutTests:

Adding two tests for indenting nested inlines.

  • editing/execCommand/indent-nested-inlines-1-expected.txt: Added.
  • editing/execCommand/indent-nested-inlines-1.html: Added.
  • editing/execCommand/indent-nested-inlines-2-expected.txt: Added.
  • editing/execCommand/indent-nested-inlines-2.html: Added.
13:00 Changeset [119269] by hausmann@webkit.org
  • 5 edits in trunk

[Qt] Use -Werror only in developer builds

Rubber-stamped by Tor Arne Vestbø.

In production builds -Werror with custom toolchains and wierd system
headers, -Werror is of no use and just creates confusion. So use it
only if Qt is configured with -developer-build.

.:

  • Source/api.pri: qt_developer_build determination moved to default_pre.prf

Tools:

  • qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
  • qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror

only if qt_developer_build is set.

12:58 Changeset [119268] by fischman@chromium.org
  • 4 edits in trunk/LayoutTests

[chromium] Unskip http/tests/media/video-buffered.html
https://bugs.webkit.org/show_bug.cgi?id=87568

Reviewed by Eric Carlson.

  • http/tests/media/video-buffered-expected.txt:
  • http/tests/media/video-buffered.html:
  • platform/chromium/test_expectations.txt:
12:57 Changeset [119267] by caio.oliveira@openbossa.org
  • 4 edits
    1 copy
    2 adds in trunk

[Qt] Move QObject bridge related tests from tst_qwebframe to tst_qobjectbridge
https://bugs.webkit.org/show_bug.cgi?id=88117

Reviewed by Noam Rosenthal.

.:

  • Source/tests.pri: Add new entry for tst_qobjectbridge.

Source/WebKit/qt:

Five tests (classEnums, classConstructor, transferInvokable, findObject and
findChildren) were removed since they contained commented code since the file was
added back in 2008. The QObject bridge tests were probably inspired in similar
tests for QtScript, so many features not yet implemented were present in QtWebKit
tests but commented.

Other minor changes:

  • Moved MyEnumTestQObject near the only test function that uses it.
  • Removed unnecessary Q_INVOKABLE from setBrushProperty.
  • Removed some bits of dead / commented code.
  • tests/qobjectbridge/qobjectbridge.pro: Added.
  • tests/qobjectbridge/tst_qobjectbridge.cpp: Copied from Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp.

Kept only the tests related to QObject bridge implementation.

  • tests/qwebframe/tst_qwebframe.cpp:

(tst_QWebFrame):
(tst_QWebFrame::init):
(tst_QWebFrame::cleanup):

12:52 Changeset [119266] by jochen@chromium.org
  • 2 edits in trunk/Tools

[watchlist] Add myself to loader and v8 bindings changes
https://bugs.webkit.org/show_bug.cgi?id=88112

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/watchlist:
12:41 Changeset [119265] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Another Chromium test expectation update per the bug 88124.

  • platform/chromium/test_expectations.txt:
12:39 Changeset [119264] by zhajiang@rim.com
  • 2 edits in trunk/Tools

Adding Jacky Jiang to committers.py
https://bugs.webkit.org/show_bug.cgi?id=88122

Reviewed by Rob Buis.

Adding myself to committers.py as a Committer.

  • Scripts/webkitpy/common/config/committers.py:
12:38 Changeset [119263] by ap@apple.com
  • 3 edits in branches/safari-536-branch/LayoutTests

Update test results after r119025

  • platform/mac/mathml/presentation/mo-stretch-expected.txt: Clearly incorrect results were landed for this test, not sure how that happened (I cannot find these wrong results anywhere in trunk history).
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt: Looks like this test was not updated with others. The only observable difference is a slightly smaller width of an input field, which matches what one could expect from the change.
12:32 Changeset [119262] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
12:32 Changeset [119261] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/11335622> and https://bugs.webkit.org/show_bug.cgi?id=88119
REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call

Followup to r119260

Rubber-stamped by Anders Carlsson.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow): Set the m_hasCalledSetWindow here...
(WebKit::NetscapePlugin::geometryDidChange): ...instead of here.

12:24 Changeset [119260] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/11335622> and https://bugs.webkit.org/show_bug.cgi?id=88119
REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call

Reviewed by Oliver Hunt.

Add a flag to NetscapePlugin to track whether or not NPP_SetWindow has ever been called.
Check this flag in geometryDidChange to make sure every plug-in gets the call at least once.

"Everybody gets one. Tell him, Peter."
"Apparently everybody gets one."
"Bingo."

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
(WebKit::NetscapePlugin::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):

12:00 Changeset [119259] by commit-queue@webkit.org
  • 7 edits in trunk

getComputedStyle for background shorthand property does not return background-origin and background-clip.
https://bugs.webkit.org/show_bug.cgi?id=86155

Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-01
Reviewed by Tony Chang.

Added background-origin and background-clip CSS Property values to the background shorthand CSSValueList.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getBackgroundShorthandValue):

LayoutTests:

  • fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
  • fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
  • fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-background-shorthand.html:
11:55 Changeset [119258] by pilgrim@chromium.org
  • 14 edits
    1 delete in trunk/Source

[Chromium] Call clipboard methods directly
https://bugs.webkit.org/show_bug.cgi?id=88038

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • chromium/public/WebClipboard.h:

(WebKit::WebClipboard::sequenceNumber):

Source/WebCore:

  • WebCore.gypi:
  • platform/Pasteboard.h:

(Pasteboard):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::createFromPasteboard):

  • platform/chromium/ChromiumDataObjectItem.cpp:

(WebCore::ChromiumDataObjectItem::getAsFile):
(WebCore::ChromiumDataObjectItem::internalGetAsString):

  • platform/chromium/ClipboardUtilitiesChromium.cpp:

(WebCore::currentPasteboardBuffer):

  • platform/chromium/ClipboardUtilitiesChromium.h:

(WebCore):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::writeClipboard):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):

  • platform/chromium/PasteboardPrivate.h: Removed.
  • platform/chromium/PlatformSupport.h:

(WebCore):
(PlatformSupport):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
  • src/PlatformSupport.cpp:

(WebCore::getCookieJar):

11:33 Changeset [119257] by jberlin@webkit.org
  • 2 edits in trunk/Tools

Fix Windows build.

  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
11:24 Changeset [119256] by commit-queue@webkit.org
  • 6 edits
    26 adds in trunk

Improve handling of legacy viewport meta tags
https://bugs.webkit.org/show_bug.cgi?id=55874

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-06-01
Reviewed by Adam Barth.

Source/WebCore:

We now support MobileOptimized and HandheldFriendly as well.

We set width equal to device-width for HandheldFriendly and
for MobileOptimized, the content value of MobileOptimized is
ignored and the initial-scale set to 1 to fit Android behavior.

The prioritizing is done the same way as on Windows Phone 7:

XHTML Mobile Profile found
HandheldFriendly
MobileOptimized (overrides HandheldFriendly)
Viewport (overrides all above)

Original patch by Kenneth Rohde Christiansen.

Tests: fast/viewport/viewport-legacy-handheldfriendly.html

fast/viewport/viewport-legacy-mobileoptimized-2.html
fast/viewport/viewport-legacy-mobileoptimized-3.html
fast/viewport/viewport-legacy-mobileoptimized.html
fast/viewport/viewport-legacy-ordering-1.html
fast/viewport/viewport-legacy-ordering-2.html
fast/viewport/viewport-legacy-ordering-3.html
fast/viewport/viewport-legacy-ordering-4.html
fast/viewport/viewport-legacy-ordering-5.html
fast/viewport/viewport-legacy-ordering-6.html
fast/viewport/viewport-legacy-ordering-7.html
fast/viewport/viewport-legacy-ordering-8.html
fast/viewport/viewport-legacy-ordering-9.html

  • dom/Document.cpp:

(WebCore::Document::setDocType):
(WebCore::Document::processViewport): Add an origin parameter to
tell what is changing the viewport.

  • dom/Document.h:

(Document):

  • dom/ViewportArguments.h:
  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

LayoutTests:

Add tests and expected results.

  • fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Added.
  • fast/viewport/viewport-legacy-handheldfriendly.html: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-2.html: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-3.html: Added.
  • fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Added.
  • fast/viewport/viewport-legacy-mobileoptimized.html: Added.
  • fast/viewport/viewport-legacy-ordering-1-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-1.html: Added.
  • fast/viewport/viewport-legacy-ordering-2-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-2.html: Added.
  • fast/viewport/viewport-legacy-ordering-3-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-3.html: Added.
  • fast/viewport/viewport-legacy-ordering-4-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-4.html: Added.
  • fast/viewport/viewport-legacy-ordering-5-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-5.html: Added.
  • fast/viewport/viewport-legacy-ordering-6-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-6.html: Added.
  • fast/viewport/viewport-legacy-ordering-7-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-7.html: Added.
  • fast/viewport/viewport-legacy-ordering-8-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-8.html: Added.
  • fast/viewport/viewport-legacy-ordering-9-expected.txt: Added.
  • fast/viewport/viewport-legacy-ordering-9.html: Added.
11:10 Changeset [119255] by tony@chromium.org
  • 43 edits in trunk

rename -webkit-flex-order to -webkit-order
https://bugs.webkit.org/show_bug.cgi?id=88104

Reviewed by Ojan Vafai.

Source/WebCore:

This recently changed in the spec:
http://dev.w3.org/csswg/css3-flexbox/#order-property

No new tests, just updated existing results.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::OrderIterator::OrderIterator):
(WebCore::RenderFlexibleBox::OrderIterator::next):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
(WebCore::RenderFlexibleBox::packFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
(WebCore::RenderFlexibleBox::flipForWrapReverse):

  • rendering/RenderFlexibleBox.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

Just a find and replace for the new property name.

  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-order.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
10:50 Changeset [119254] by fmalita@chromium.org
  • 2 edits
    1 copy
    1 move
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed. Adding Win and Mac baselines after r119241.

Patch by Florin Malita <fmalita@chromium.org> on 2012-06-01

  • platform/chromium-mac/svg/repaint/text-mask-update-expected.png: Added.
  • platform/chromium-mac/svg/repaint/text-mask-update-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.txt.
  • platform/chromium-win/svg/repaint/text-mask-update-expected.png: Added.
  • platform/chromium-win/svg/repaint/text-mask-update-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.txt.
  • platform/chromium/test_expectations.txt:
10:31 Changeset [119253] by jberlin@webkit.org
  • 5 edits
    2 adds in trunk/LayoutTests

[Win] 9 plugin tests fail/time out
https://bugs.webkit.org/show_bug.cgi?id=88107

Skip the ones that time out and add/update platform-specific results for the the ones that
fail to get the bots greener.

  • platform/win/Skipped:
  • platform/win/plugins/get-value-netscape-window-expected.txt:
  • platform/win/plugins/netscape-dom-access-and-reload-expected.txt: Added.
  • platform/win/plugins/npn-invalidate-rect-invalidates-window-expected.txt:
  • platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt:
  • platform/win/plugins/geturlnotify-during-document-teardown-expected.txt
10:26 Changeset [119252] by zeno.albisser@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r119247.

Do not include TextureMapperGL.h when not building
with GRAPHICS_SURFACE.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:
10:16 Changeset [119251] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] WebLayerTreeRenderer::setContentsSize called synchronously
https://bugs.webkit.org/show_bug.cgi?id=88091

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Noam Rosenthal.

Do not call WebLayerTreeRenderer::setContentsSize synchronously
from LayerTreeHostProxy.

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::setContentsSize):

10:09 Changeset [119250] by jberlin@webkit.org
  • 2 edits in trunk/Tools

Windows WK2 MouseMoveAfterCrash API test failing
https://bugs.webkit.org/show_bug.cgi?id=69982

Disable the test on Windows to get the bots greener.

  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:

(TestWebKitAPI::TEST):

10:05 Changeset [119249] by mario@webkit.org
  • 3 edits
    4 adds in trunk/Source/WebCore

[GTK] Add a new and reusable Geoclue-based geolocation provider in WebCore
https://bugs.webkit.org/show_bug.cgi?id=87800

Reviewed by Carlos Garcia Campos.

Added new and reusable Geoclue-based geolocation provider to WebCore.

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • platform/geoclue/GeolocationProviderGeoclue.cpp: Added.

(getPositionCallback):
(positionChangedCallback):
(GeolocationProviderGeoclue::GeolocationProviderGeoclue):
(GeolocationProviderGeoclue::~GeolocationProviderGeoclue):
(GeolocationProviderGeoclue::startUpdating):
(GeolocationProviderGeoclue::stopUpdating):
(GeolocationProviderGeoclue::setEnableHighAccuracy):
(GeolocationProviderGeoclue::setGeoclueClient):
(GeolocationProviderGeoclue::setGeocluePosition):
(GeolocationProviderGeoclue::updateClientRequirements):
(GeolocationProviderGeoclue::positionChanged):
(GeolocationProviderGeoclue::errorOccured):

  • platform/geoclue/GeolocationProviderGeoclue.h: Added.

(WebCore):
(GeolocationProviderGeoclue):

  • platform/geoclue/GeolocationProviderGeoclueClient.h: Added.

(WebCore):
(GeolocationProviderGeoclueClient):

10:04 Changeset [119248] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Remove deprecated Q_GLOBAL_STATIC_WITH_INITIALIZER
https://bugs.webkit.org/show_bug.cgi?id=88100

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-01
Reviewed by Tor Arne Vestbø.

It will be deprecated on Qt5.

  • platform/text/qt/TextBreakIteratorInternalICUQt.cpp:

(WebCore):

10:02 Changeset [119247] by zeno.albisser@nokia.com
  • 7 edits in trunk/Source/WebCore

Make TextureMapper work with GraphicsSurface.
https://bugs.webkit.org/show_bug.cgi?id=87738

Add TextureMapperSurfaceBackingStore, a new backing store
that allows to import textures from a GraphicsSurface.
On Mac the GraphicsSurface is backed by an IOSurface
which must be used with a GL_TEXTURE_RECTANGLE_ARB texture.
Therefore it is also necessary to add new shader programs
for directly painting these textures on screen.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

Add a new TextureMapperBackingStore implementation that can directly
reuse textures as they are being passed from the GraphicsSurface.
(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::texture):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):

  • platform/graphics/texmap/TextureMapperBackingStore.h:

(GraphicsSurfaceData):
(WebCore::GraphicsSurfaceData::setSurface):
(WebCore::GraphicsSurfaceData::GraphicsSurfaceData):
(TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::create):
(WebCore::TextureMapperSurfaceBackingStore::~TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::TextureMapperSurfaceBackingStore):

  • platform/graphics/texmap/TextureMapperGL.cpp:

Add a drawing function for textures of type GL_TEXTURE_RECTANGLE_ARB.
(WebCore::TextureMapperGL::drawTextureRectangleARB):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderProgramSimple::create):
(WebCore::TextureMapperShaderProgramSimple::initialize):
(WebCore::TextureMapperShaderProgramSolidColor::create):
(WebCore::TextureMapperShaderProgramSolidColor::initialize):
(WebCore::TextureMapperShaderProgramRectSimple::create):
(WebCore::TextureMapperShaderProgramRectSimple::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramOpacityAndMask::initialize):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::fragmentShaderSource):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

Add new shader programs that can be used with GL_TEXTURE_RECTANGLE_ARB textures.
This is mainly necessary, because this type of texture uses non-normalized coordinates.
Further move the calls to initializeProgram() from the constructor into a separate
initialize() function, as initializeProgram() calls vertexShaderSource() (and friends)
and we should not call virtual functions in the constructor.
(WebCore::TextureMapperShaderProgram::initialize):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple):
(TextureMapperShaderProgramRectSimple):
(WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(TextureMapperShaderProgramRectOpacityAndMask):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::TextureMapperShaderProgramRectOpacityAndMask):
(TextureMapperShaderProgramSolidColor):
(WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):

09:57 Changeset [119246] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip some plugin tests that crash/assert on Windows.

  • platform/win/Skipped:
09:50 Changeset [119245] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Set QWebKitTest::isScalable default as false
https://bugs.webkit.org/show_bug.cgi?id=88095

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Tor Arne Vestbø.

Set QWebKitTest::isScalable default as false

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::isScalable):

09:41 Changeset [119244] by pdr@google.com
  • 2 edits
    2 copies in branches/chromium/1084

Merge 117365 - Crash if SVG gradient stop has display: none set

09:35 Changeset [119243] by commit-queue@webkit.org
  • 19 edits in trunk

[EFL] EFL port does not enable WEB_INTENTS_TAG flag
https://bugs.webkit.org/show_bug.cgi?id=86866

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-01
Reviewed by Adam Barth.

.:

Enable WEB_INTENTS_TAG flag by default on EFL port.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Fix compilation error when WEB_INTENTS_TAG flag is enabled.
HTMLElement::insertedInto() takes a ContainerNode* in argument, not a
Node*.

Test: webintents/intent-tag.html

  • CMakeLists.txt:
  • html/HTMLIntentElement.cpp:

(WebCore::HTMLIntentElement::insertedInto):

  • html/HTMLIntentElement.h:

(HTMLIntentElement):

Source/WebKit/efl:

Implement registerIntentService() in EFL's FrameLoaderClient.
Emit a "intent,service,register" signal on the frame when a new Web
Intent service registers.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore):
(WebCore::FrameLoaderClientEfl::registerIntentService):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

  • ewk/ewk_frame.cpp:

(ewk_frame_intent_service_register):

  • ewk/ewk_frame.h:
  • ewk/ewk_frame_private.h:

Tools:

Catch new "intent,service,register" signal on the frame and print out
information about the Web Intent service in EFL's DumpRenderTree.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameIntentServiceRegistration):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

Unskip webintents/intent-tag.html now that the WEB_INTENTS_TAG flag is
enabled by default on EFL port.

  • platform/efl/test_expectations.txt:
09:19 Changeset [119242] by commit-queue@webkit.org
  • 7 edits in trunk

[cairo] Pixel artifacts can be seen on reflections
https://bugs.webkit.org/show_bug.cgi?id=85483

Source/WebCore:

Antialiased clipping in the simple rectangular clip method
leads to edge artifacts when transformations are applied to the layer.
Explicitly disabling antialiased clipping for this function solves this issue.
Comparing Cairo GraphicsContext to Qt and Skia GC, it seems that these
backends do not expect the platform context to clip antialiased in this
case either.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-01
Reviewed by Martin Robinson.

No new tests, covered by fast/css/transformed-mask.html.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::clip):

LayoutTests:

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-01
Reviewed by Martin Robinson.

Rebaselining the relevant test case for GTK and EFL.

  • platform/efl/fast/css/transformed-mask-expected.png:
  • platform/efl/fast/css/transformed-mask-expected.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/fast/css/transformed-mask-expected.png:
09:03 Changeset [119241] by fmalita@chromium.org
  • 5 edits
    3 adds in trunk

http://shinydemos.com/clock/ doesn't seem to work
https://bugs.webkit.org/show_bug.cgi?id=79682

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/repaint/text-mask-update.svg

Currently, parent resources are not invalidated when SVGInlineText nodes
are added or removed. Adjusting SVGResourcesCache::clientWasAddedToTree()
and SVGResourcesCache::clientWillBeRemovedFromTree() to cover this case.

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientWasAddedToTree):
(WebCore::SVGResourcesCache::clientWillBeRemovedFromTree):

LayoutTests:

  • platform/chromium-linux/svg/repaint/text-mask-update-expected.png: Added.
  • platform/chromium-linux/svg/repaint/text-mask-update-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • svg/repaint/text-mask-update.svg: Added.
09:03 Changeset [119240] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

The ChangeLog parser cannot handle reviewers with initials in their name
https://bugs.webkit.org/show_bug.cgi?id=87864

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-01
Reviewed by Ryosuke Niwa.

Add support in the ChangeLog parser for reviewer names that have
initials in them.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry): Add a new group of regular expressions that need a backreference
in the replacement string. This allows for matching the word characters before a
period, without totally throwing them away.
(ChangeLogEntry._parse_reviewer_text): Use the new regular expression.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.

09:00 Changeset [119239] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add end editing handling into AutofillManager
https://bugs.webkit.org/show_bug.cgi?id=88071

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-06-01
Reviewed by Rob Buis.

RIM PR: 160857
Implemented EditorClientBlackBerry::textFieldDidEndEditing
to notify AutofillManager to send the dismissing autofill
dialog notification to webpage client.

No new tests since there is no behavior changes.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::notifyDismissAutofillDialog):
(WebKit):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/AutofillManager.cpp:

(WebCore::AutofillManager::textFieldDidEndEditing):
(WebCore):

  • WebCoreSupport/AutofillManager.h:

(AutofillManager):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::textFieldDidEndEditing):

08:56 Changeset [119238] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] ewk_intent_data_get() is not needed and can be removed
https://bugs.webkit.org/show_bug.cgi?id=88072

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-01
Reviewed by Adam Barth.

Remove ewk_intent_data_get() method from Ewk_Intent. Intent data is
serialized and does not need to be publicly exposed. The browser only
needs action and type to match with services.

  • ewk/ewk_intent.cpp:

(_Ewk_Intent):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_free):

  • ewk/ewk_intent.h:
08:49 Changeset [119237] by commit-queue@webkit.org
  • 18 edits in trunk

[EFL] EFL's LayoutTestController needs to implement deliverWebIntent
https://bugs.webkit.org/show_bug.cgi?id=86865

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-01
Reviewed by Adam Barth.

Source/WebKit:

Add "${WEBCORE_DIR}/dom/default" to include directories in
CMakeLists.txt.

  • CMakeLists.txt:

Source/WebKit/efl:

Add method on Ewk_Frame to deliver an intent.
Add helper function to DumpRenderTreeSupportEfl to deliver a Web
Intent.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::deliverWebIntent):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • ewk/ewk_frame.cpp:

(ewk_frame_intent_deliver):

  • ewk/ewk_frame.h:

Tools:

Add deliverWebIntent method to LayoutTestController and provide
implementation for EFL port.

  • DumpRenderTree/LayoutTestController.cpp:

(deliverWebIntentCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::deliverWebIntent):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::deliverWebIntent):

LayoutTests:

Unskip webintents/web-intents-delivery.html now that Web intent
delivery is implemented on EFL port.

  • platform/efl/test_expectations.txt:
08:47 Changeset [119236] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Bridge Apps - Apps do not redraw correctly after orientation change
https://bugs.webkit.org/show_bug.cgi?id=88033

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 142961
When bridge apps were in carousel mode, the backing store was inactive
as its memory had been released. When we rotated the device, we would
call WebPagPrivate:setViewportSize and resume screen and backing store
to render and blit visible contents. As backing store was inactive and
the window usage was GLES2Usage, we were neither doing backing store
rendering nor direct rendering. Therefore, we drew layers directly
based on the invalid texture contents when blitting contents if
accelerated compositing was enabled.
This patch forces compositing mode to let the accelerated compositing
layer take care of the rendering which can update texture contents
before drawing when backing store is inactive and is openGL compositing.

Reviewed internally by George Staikos and Arvid Nilsson.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):

08:45 Changeset [119235] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't set scroll position twice in HistoryController::restoreScrollPositionAndViewState
https://bugs.webkit.org/show_bug.cgi?id=88068

Patch by John Mellor <johnme@chromium.org> on 2012-06-01
Reviewed by Adam Barth.

In the case where pageScaleFactor changes, we were calling
setScrollPosition with an incorrect scroll position (i.e. a scroll
position scaled by the pageScaleFactor we hadn't yet applied), then
fixing it by setting the pageScaleFactor and scroll position together,
overwriting the old scroll position. It's cleaner to just set the
pageScaleFactor and scroll position together.

No new tests as this isn't expected to change the ultimate behavior, just clean up how it happens.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

08:43 Changeset [119234] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Remove QtViewportInteractionEngine::pageItemSizeChanged.
https://bugs.webkit.org/show_bug.cgi?id=88082

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

The function was causing flickering, and after testing it was verified
that it was no longer needed either.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

08:38 Changeset [119233] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r119228.
http://trac.webkit.org/changeset/119228
https://bugs.webkit.org/show_bug.cgi?id=88098

Caused the EFL debug bot to crash. (Requested by rakuco on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01

Source/WebKit/efl:

  • ewk/ewk_main.cpp:

(ewk_init):

LayoutTests:

  • platform/efl/test_expectations.txt:
08:34 Changeset [119232] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Qt] Remove deprecated to/fromAscii()
https://bugs.webkit.org/show_bug.cgi?id=88086

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-01
Reviewed by Simon Hausmann.

Replacing to/fromAscii with to/fromLatin1 since it
is deprecated on Qt5.

Source/WebCore:

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • platform/network/qt/ResourceRequestQt.cpp:

(WebCore::ResourceRequest::toNetworkRequest):

Source/WebKit/qt:

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore):

  • WebCoreSupport/InspectorServerQt.cpp:

(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):

  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:

(tst_QDeclarativeWebView::settings):

08:21 Changeset [119231] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Contents not rendered in MiniBrowser for some pages
https://bugs.webkit.org/show_bug.cgi?id=87922

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

Set drawing area visible contents rect if new visible contents rect is different from
the previous one.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::informVisibleContentChange):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

07:36 Changeset [119230] by ossy@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt: Added.
07:27 Changeset [119229] by apavlov@chromium.org
  • 4 edits in trunk/LayoutTests

Web Inspector: Prepare styles-new-API.html results format for a more complex CSS model
https://bugs.webkit.org/show_bug.cgi?id=88090

Reviewed by Antti Koivisto.

  • inspector/styles/resources/styles-new-API.css:
  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-new-API.html:
07:23 Changeset [119228] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] [DRT] editing/execCommand/paste-and-match-style-event.html crashes
https://bugs.webkit.org/show_bug.cgi?id=86961

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-01
Reviewed by Csaba Osztrogonác.

Source/WebKit/efl:

Call ecore_x_init() in ewk_init() to initialize the ecore_x library.
This avoids crashing upong calling WebCore::systemBeep() which uses
ecore_x_bell() internally.

  • ewk/ewk_main.cpp:

(ewk_init):

LayoutTests:

Unskip editing/execCommand/paste-and-match-style-event.html now that
it is no longer crashing thanks to ecore_x library init.

  • platform/efl/test_expectations.txt:
07:14 Changeset [119227] by mitz@apple.com
  • 4 edits
    2 adds in trunk

Layout not updated after setting -webkit-line-clamp to none
https://bugs.webkit.org/show_bug.cgi?id=88049

Reviewed by Abhishek Arya.

Source/WebCore:

Test: fast/flexbox/line-clamp-removed-dynamically.html

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::styleWillChange): Added. Calls clearLineClamp if
line-clamp will change to none.
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp): Added. Marks possibly-clamped
children for layout and clears truncation from blocks.

  • rendering/RenderDeprecatedFlexibleBox.h:

LayoutTests:

  • fast/flexbox/line-clamp-removed-dynamically-expected.html: Added.
  • fast/flexbox/line-clamp-removed-dynamically.html: Added.
06:53 Changeset [119226] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r119213.
http://trac.webkit.org/changeset/119213
https://bugs.webkit.org/show_bug.cgi?id=88084

This patch broke two tests on all platform except Chromium.
The authors are unavailable. (Requested by zherczeg on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

06:51 Changeset [119225] by kkristof@inf.u-szeged.hu
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r119219.
http://trac.webkit.org/changeset/119219
https://bugs.webkit.org/show_bug.cgi?id=88088

This patch broke two tests on GTK/Qt. The authors are
unavailable. (Requested by kkristof on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):

  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):

  • page/Frame.h:

(Frame):
(WebCore::Frame::detachFromPage):
(WebCore):

  • page/Page.cpp:

(WebCore::Page::~Page):

06:47 Changeset [119224] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Add Closure compiler annotations to WorkerConsole
https://bugs.webkit.org/show_bug.cgi?id=88073

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-01
Reviewed by Yury Semikhatsky.

  • inspector/front-end/HeapSnapshotWorker.js:

(WebInspector.WorkerConsole.prototype.log):
(WebInspector.WorkerConsole.prototype.error):
(WebInspector.WorkerConsole.prototype.info):

05:57 Changeset [119223] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] New signals in ewk_view to enable global history delegate functionality
https://bugs.webkit.org/show_bug.cgi?id=86343

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

Global history delegate is an interface for WebKit clients to manage their own global history store.
The new ewk_view signals do the following:
1) report that a navigation happened within the view and give the navigation details.
2) report that view performed a client redirect and give source and destination uris.
3) report that view performed a server redirect and give source and destination uris.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::updateGlobalHistoryRedirectLinks): implementation added.
(WebCore::FrameLoaderClientEfl::updateGlobalHistory): implementation added.

  • ewk/ewk_view.h: Added new signals and data types.
05:52 Changeset [119222] by vestbo@webkit.org
  • 2 edits in trunk/Source/WTF

[Qt] Save one copy when going from 8-bit WTF::String to QString

Asking for characters() of an 8-bit string will make a 16-bit copy internally
in WTF::String. Since we're going to copy the data to QStringData anyways, which
is 16-bit, we can do the conversion ourselves and save one copy.

Reviewed by Simon Hausmann.

05:50 Changeset [119221] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing and crashing tests.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt/Skipped:
05:32 Changeset [119220] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Move suspension to QtViewportInteractionEngine
https://bugs.webkit.org/show_bug.cgi?id=88078

Reviewed by Simon Hausmann.

Next step is to take care of visibility changes.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::suspendPageContent):
(WebKit):
(WebKit::QtViewportInteractionEngine::resumePageContent):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(QtViewportInteractionEngine):

05:30 Changeset [119219] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

Frame::willDetachPage() shouldn't be called more than once.
https://bugs.webkit.org/show_bug.cgi?id=88056

Reviewed by Ryosuke Niwa.

This change moved willDetachPage() to private and calls it from
detachFromParent(). Also, it checks m_page and call
willDetachPage() only once, if m_page is available.

No new tests. Covered by existing suites.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):

  • page/Frame.cpp:

(WebCore::Frame::detachFromPage):
(WebCore):
(WebCore::Frame::willDetachPage):

  • page/Frame.h:

(Frame):

  • page/Page.cpp:

(WebCore::Page::~Page):

05:26 Changeset [119218] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][W2] Qml Error in ViewportInfoItem.qml in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=87999

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

Return default viewport attributes rather than invalid QVariant.

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::contentsScale):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::initialScale):
(QWebKitTest::minimumScale):
(QWebKitTest::maximumScale):
(QWebKitTest::isScalable):
(QWebKitTest::layoutSize):

05:25 Changeset [119217] by vestbo@webkit.org
  • 4 edits in trunk/Source/WTF

[Qt] Make conversion from QString to WTF::String (and back again) ~free

https://bugs.webkit.org/show_bug.cgi?id=87847

Instead of copying the QString data when converting to a WTF::String we
make the WTF::String adopt the QString data by introducing a new buffer
ownership type, and pointing the internal WTF::StringImpl 16-bit data
member to the string data managed by QStringData.

We make sure to reference the QStringData when adopting, so that the
data will stay alive, and then dereference it when the WTF::StringImpl
is deleted, which will free the QStringData (either straight away, if
we're the only one holding a reference still, or later, when the ref
count goes to 0).

In the case of going back from a WTF::String to a QString we can cheat
a bit (avoid a copy), if we know that the WTF::String was adopted from
a QString, since it's then just a matter of having the QString adopt
the existing QStringData (just like a regular QString copy).

If the WTF::String buffer is not owned by QStringData, eg a regular
8-bit or 16-bit string/substring, we have to fall back to copying,
as before (though there are potential optimization tricks we can
apply here later on).

Reviewed by Gavin Barraclough.

  • wtf/qt/StringQt.cpp:
  • wtf/text/StringImpl.cpp:
  • wtf/text/StringImpl.h:
05:21 Changeset [119216] by pierre.rossi@gmail.com
  • 4 edits in trunk

[Qt] Support drawing a pattern with a translation.
https://bugs.webkit.org/show_bug.cgi?id=87025

Source/WebCore:

Drawing an SVG pattern that has its x or y attribute set
works by setting a transform on the Pattern.
We would ignore this by only taking into account the texture and
target rect.

Reviewed by Kenneth Rohde Christiansen.

test: svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::drawRepeatPattern): refactored to take into account the translation set on the brush.
(WebCore::GraphicsContext::fillRect):

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: fix the expected pixel result
04:56 Changeset [119215] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening failure case on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=88067

Unreviewed EFL gardening after r119196.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01

  • platform/efl/test_expectations.txt:
04:55 Changeset [119214] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
04:53 Changeset [119213] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r109729) [Form] Rendering of select/optgroup/option combination is too slow.
https://bugs.webkit.org/show_bug.cgi?id=88059

Reviewed by Kent Tamura.

This patch changes to share RenderStyle object among the "option"
elements to improve rendering performance and reducing memory usage
of RenderStyle.

No new tests. This patch doesn't change behavior but rendering performance.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement): Check attribute value
mismatching for "option" element.

04:26 Changeset [119212] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] Bad layout of "Override device metrics" controls in the Settings dialog
https://bugs.webkit.org/show_bug.cgi?id=88074

Reviewed by Yury Semikhatsky.

The "Override device metrics" controls are placed in a table, which gets too narrow. Give it a
"white-space: nowrap" to avoid wrapping individual cells.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):

  • inspector/front-end/elementsPanel.css:
  • inspector/front-end/inspector.css:

(.nowrap):

04:18 Changeset [119211] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing

Reviewed by Simon Hausmann.

04:12 Changeset [119210] by kenneth@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Qt] Clean up our viewport handling mess
https://bugs.webkit.org/show_bug.cgi?id=87977

Reviewed by Simon Hausmann.

Consolidated functionality from QQuickWebViewPrivate* into
ViewportInteractionEngine that belongs there, in preparation for
renaming ViewportInteractionEngine in the future.

Remove unneeded methods and move others to private.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::viewportAttributesChanged):
(WebKit::QtViewportInteractionEngine::pageContentsSizeChanged):
(WebKit::QtViewportInteractionEngine::pageItemPositionChanged):
(WebKit::QtViewportInteractionEngine::pageContentPositionRequested):
(WebKit::QtViewportInteractionEngine::visibleContentsRect):
(WebKit):
(WebKit::QtViewportInteractionEngine::informVisibleContentChange):
(WebKit::QtViewportInteractionEngine::viewportItemSizeChanged):

  • UIProcess/qt/QtViewportInteractionEngine.h:

(WebKit):
(QtViewportInteractionEngine):

03:50 Changeset [119209] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Move input element's spinner style tests to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=88054

Unreviewed EFL gardening.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-06-01

  • platform/efl/test_expectations.txt:
03:45 Changeset [119208] by commit-queue@webkit.org
  • 8 edits
    2 adds
    1 delete in trunk/Source

[EFL] Implement PlatformStrategies
https://bugs.webkit.org/show_bug.cgi?id=86946

Source/WebCore:

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.

  • PlatformEfl.cmake: Add PlatformStrategies.cpp file to the build system.

Also, remove PluginDataEfl.cpp because the same functionality is now
implemented in PlatformStrategiesEfl.cpp.

Source/WebKit:

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.

  • PlatformEfl.cmake: Add PlatformStrategiesEfl file to the build

system.

Source/WebKit/efl:

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.

Enable PLATFORM_STRATEGIES for EFL platform.

  • WebCoreSupport/PlatformStrategiesEfl.cpp: Added, code was moved

from platform/PluginDataEfl.
(PlatformStrategiesEfl::initialize): Initialize platform strategies.
(PlatformStrategiesEfl::PlatformStrategiesEfl):
(PlatformStrategiesEfl::createCookiesStrategy): Return this.
(PlatformStrategiesEfl::createPluginStrategy): Ditto.
(PlatformStrategiesEfl::createVisitedLinkStrategy): Ditto.
(PlatformStrategiesEfl::createPasteboardStrategy): Return 0, since
PasteboardStrategy is only used by mac code for now.
(PlatformStrategiesEfl::notifyCookiesChanged):
(PlatformStrategiesEfl::refreshPlugins): Refresh the plugin
database. Code executes only when NETSCAPE_PLUGIN_API is ON.
(PlatformStrategiesEfl::getPluginInfo): Initialize plugins and
populate the given vector with plugins information. Code executes
only when NETSCAPE_PLUGIN_API is ON.
(PlatformStrategiesEfl::isLinkVisited): Return whether the given
hash is a visited link of the page group.
(PlatformStrategiesEfl::addVisitedLink): Add the given hash to the
page group visited links.

  • WebCoreSupport/PlatformStrategiesEfl.h: Added.

(PlatformStrategiesEfl):

  • ewk/ewk_main.cpp: Initialize PlatformStrategiesEfl.

(_ewk_init_body):

Source/WTF:

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.

  • wtf/Platform.h: Enable PLATFORM_STRATEGIES for EFL platform.
03:39 Changeset [119207] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

ASSERT(m_fontSelector->document()) is bogus and should be removed
https://bugs.webkit.org/show_bug.cgi?id=88053

Reviewed by Abhishek Arya.

This ASSERT was introduced in http://trac.webkit.org/changeset/97402
together with a branch that handled the case of the ASSERT firing.
This ASSERT fires when running tests on Android (which runs with
ASSERTs enabled). The ASSERT appears to be bogus, so this patch removes
it.

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

03:37 Changeset [119206] by ossy@webkit.org
  • 15 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected files.

  • platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/qt-5.0/fast/forms/form-element-geometry-expected.png:
  • platform/qt-5.0/fast/forms/form-element-geometry-expected.txt:
  • platform/qt-5.0/fast/forms/menulist-separator-painting-expected.png:
  • platform/qt-5.0/fast/forms/menulist-separator-painting-expected.txt:
  • platform/qt-5.0/fast/forms/select-baseline-expected.png:
  • platform/qt-5.0/fast/forms/select-baseline-expected.txt:
  • platform/qt-5.0/fast/forms/selectlist-minsize-expected.png:
  • platform/qt-5.0/fast/forms/selectlist-minsize-expected.txt:
  • platform/qt-5.0/fast/replaced/three-selects-break-expected.png:
  • platform/qt-5.0/fast/replaced/three-selects-break-expected.txt:
02:40 Changeset [119205] by yosin@chromium.org
  • 4 edits in trunk/Source

[Platform][Decimal] UInt128::operator/= calls makeUInt128 with wrong argument order
https://bugs.webkit.org/show_bug.cgi?id=88044

Reviewed by Kent Tamura.

Source/WebCore:

This patch fixed wrong argument of makeUInt128 in UInt128::operator/= to get right
result for decimal multiplication.

Test: WebKit/chromium/tests/DecimalTest.cpp: Add new a new test case.

  • platform/Decimal.cpp:

(WebCore::DecimalPrivate::UInt128::operator/=):

Source/WebKit/chromium:

  • tests/DecimalTest.cpp:

(TEST_F): Add a new test for multiplication.

02:26 Changeset [119204] by abarth@webkit.org
  • 7 edits
    9 adds in trunk

sandbox directive in X-WebKit-CSP header unable to create a unique origin
https://bugs.webkit.org/show_bug.cgi?id=88014

Reviewed by Ryosuke Niwa.

Source/WebCore:

We process the HTTP headers for a response after we create a document
object for the response. Previously, the SecurityOrigin of a document
was determined when the document was created, which meant that the
sandbox directive in CSP couldn't create a unique origin.

In this patch, we transition to a unique origin when we start enforcing
the SandboxOrigin bit. This patch is more complicated than you might
expect because we redundantly store the SecurityOrigin object in
DOMWindow. Removing that redundant state is
https://bugs.webkit.org/show_bug.cgi?id=75793.

The CSP sandbox directive is defined in
http://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-1.0-specification.html
by reference to
http://www.whatwg.org/specs/web-apps/current-work/#forced-sandboxing-flag-set.
The relation between sandbox and unique origin arises from
http://www.whatwg.org/specs/web-apps/current-work/#origin-0.

Test: http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control.html

http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header.html
http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control.html
http/tests/security/contentSecurityPolicy/sandbox-in-http-header.html

  • dom/Document.cpp:

(WebCore::Document::didUpdateSecurityOrigin):
(WebCore::Document::initContentSecurityPolicy):

  • dom/Document.h:

(Document):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::enforceSandboxFlags):
(WebCore):
(WebCore::SecurityContext::didUpdateSecurityOrigin):

  • dom/SecurityContext.h:

(SecurityContext):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/sandbox.php: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header.html: Added.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control-expected.txt: Added.
02:03 Changeset [119203] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: expose MemoryCache statistics in the inspector protocol
https://bugs.webkit.org/show_bug.cgi?id=87984

Reviewed by Pavel Feldman.

Added MemoryCache statistics to Memory.getProcessMemoryDistribution command
result. Corresponding sector is added to the memory pie-chart.

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::addMemoryBlockFor):
(WebCore::memoryCacheInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

01:54 Changeset [119202] by zandobersek@gmail.com
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening, add missing text and image baselines for
fast/images/png-suite/test.html. Add MISSING expectations for two
placeholder-in-text-area tests - the placeholder text does not appear
in text areas (known bug).

  • platform/gtk/fast/images/png-suite: Added.
  • platform/gtk/fast/images/png-suite/test-expected.png: Added.
  • platform/gtk/fast/images/png-suite/test-expected.txt: Added.
  • platform/gtk/test_expectations.txt:
01:34 Changeset [119201] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: add RenderArena sizes to the memory pie-chart
https://bugs.webkit.org/show_bug.cgi?id=87971

Reviewed by Pavel Feldman.

Added allocated and used sizes of page render arenas to the memory
report returned by the InspectorMemoryAgent. Total allocated size of
the inspected page's render arenas will be displayed on the memory
pie-chart.

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::renderTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

01:32 Changeset [119200] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening after r119196.

  • platform/gtk/fast/dom/gc-attribute-node-expected.txt: Added.
  • platform/gtk/test_expectations.txt: Also mark fast/replaced/border-radius-clip.html as flaky.
01:29 Changeset [119199] by tkent@chromium.org
  • 3 edits
    2 copies in branches/chromium/1132

Merge 118721 - Form controls in <fieldset disabled> should not be validated.
https://bugs.webkit.org/show_bug.cgi?id=87381

Reviewed by Hajime Morita.

Source/WebCore:

We need to use disabeld() instead of m_disabled to calculate
willValidate property. Also, we need to update willValidate if
necessary.

Test: fast/forms/fieldset/validation-in-fieldset.html

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::disabledAttributeChanged):

  • Do not traverse this.
  • Calls ancestorDisabledStateWasChanged() instead of setNeedsStyleRecalc() because we'd like to do additional tasks.
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::ancestorDisabledStateWasChanged):
Added. Just calls disabledAttributeChanged().
(WebCore::HTMLFormControlElement::parseAttribute):
Do not call setNeedsWillValidateCheck() whenever an attribute is updated.
It should be called only if disabled or readonly attribute is updated.
(WebCore::HTMLFormControlElement::disabledAttributeChanged):
Add setNeedsWillValidateCheck(). It was moved from parseAttribute().
(WebCore::HTMLFormControlElement::insertedInto):
Invalidate ancestor information.
(WebCore::HTMLFormControlElement::recalcWillValidate):
Use disabled() instead of m_disabled. disabled() takes care of
ancestor's disabled state.

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

LayoutTests:

  • fast/forms/fieldset/validation-in-fieldset-expected.txt: Added.
  • fast/forms/fieldset/validation-in-fieldset.html: Added.

TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10451107

01:23 Changeset [119198] by yurys@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: change type of injected script id from long to int
https://bugs.webkit.org/show_bug.cgi?id=87837

Reviewed by Pavel Feldman.

Changed injected script id type from long to int so that we don't
lose precision when sending the id over the protocol.

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptIdFor):
(WebCore::InjectedScriptManager::injectScript):

  • inspector/InjectedScriptManager.h:

(InjectedScriptManager):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::notifyContextCreated):

01:17 Changeset [119197] by yurys@chromium.org
  • 6 edits
    1 add in trunk/Source/WebCore

Web Inspector: draw pie-chart based on memory data received from backend
https://bugs.webkit.org/show_bug.cgi?id=87737

Reviewed by Pavel Feldman.

Added pie chart for memory data received from inspector memory agent.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemorySnapshotView):
(WebInspector.NativeMemoryProfileType):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.NativeMemoryProfileHeader):
(WebInspector.MemoryBlockViewProperties):
(WebInspector.MemoryBlockViewProperties._initialize):
(WebInspector.MemoryBlockViewProperties._forMemoryBlock):
(WebInspector.NativeMemoryPieChart):
(WebInspector.NativeMemoryPieChart.prototype.onResize):
(WebInspector.NativeMemoryPieChart.prototype._updateSize):
(WebInspector.NativeMemoryPieChart.prototype._addBlockLabels):
(WebInspector.NativeMemoryPieChart.prototype._paint.paintPercentAndLabel):
(WebInspector.NativeMemoryPieChart.prototype._paint):
(WebInspector.NativeMemoryPieChart.prototype._clear):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/nativeMemoryProfiler.css: Added.

(.memory-pie-chart-container):
(.memory-pie-chart):
(.memory-blocks-list .swatch):
(.memory-blocks-list):
(.memory-blocks-list .item):

Note: See TracTimeline for information about the timeline view.