Timeline



Jun 9, 2012:

11:36 PM Changeset in webkit [119922] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make WebGL mark draws for compositing even if the draw count is zero
https://bugs.webkit.org/show_bug.cgi?id=88718

Patch by Gregg Tavares <gman@google.com> on 2012-06-09
Reviewed by Kenneth Russell.

No new tests as no new functionality.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):

11:31 PM Changeset in webkit [119921] by dominicc@chromium.org
  • 8 edits
    14 deletes in trunk

[Chromium] Remove JavaScriptCore dependencies from gyp
https://bugs.webkit.org/show_bug.cgi?id=88510

Reviewed by Adam Barth.

Chromium doesn't support JSC any more and there doesn't seem to be
a strong interest in using GYP as the common build system in other
ports.

Source/JavaScriptCore:

  • JavaScriptCore.gyp/JavaScriptCore.gyp: WebCore still depends on YARR interpreter.
  • JavaScriptCore.gypi: Only include YARR source.
  • gyp/JavaScriptCore.gyp: Removed.
  • gyp/gtk.gyp: Removed.

Source/WebCore:

No new functionality => No new tests.

  • gyp/WebCore.gyp: Removed.
  • gyp/copy-forwarding-and-icu-headers.sh: Removed.
  • gyp/copy-inspector-resources.sh: Removed.
  • gyp/generate-derived-sources.sh: Removed.
  • gyp/generate-webcore-export-file-generator.sh: Removed.
  • gyp/gtk.gyp: Removed.
  • gyp/run-if-exists.sh: Removed.
  • gyp/streamline-inspector-source.sh: Removed.
  • gyp/update-info-plist.sh: Removed.

Source/WTF:

  • WTF.gyp/WTF.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • Scripts/generate-project-files: Removed.
7:45 PM Changeset in webkit [119920] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove a Chromium test expectation for the test that has been rolled out in r119918.

  • platform/chromium/TestExpectations:
6:08 PM Changeset in webkit [119919] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Refactor and improve code style in TextResourceDecoder to prepare for buffering improvement
https://bugs.webkit.org/show_bug.cgi?id=88566

Reviewed by Alexey Proskuryakov.

  • loader/TextResourceDecoder.cpp:

(WebCore::bytesEqual): Added helper function to make comparing against sequences of bytes
easier to read at the call site.
(WebCore::KanjiCode::judge): Changed to use bytesEqual in a few places, merged multiple if
statements, got rid of else after goto.
(WebCore::TextResourceDecoder::checkForCSSCharset): Changed to use early return instead of
nesting the whole function. Changed to use bytesEqual.
(WebCore::skipComment): Changed to use early return for more cases. Changed to use bytesEqual.
(WebCore::TextResourceDecoder::checkForHeadCharset): Changed to use bytesEqual.
(WebCore::TextResourceDecoder::decode): Changed to use emptyString() instead of "", since
the former is more efficient.

4:03 PM Changeset in webkit [119918] by commit-queue@webkit.org
  • 21 edits
    4 deletes in trunk

Unreviewed, rolling out r118618 and r119353.
http://trac.webkit.org/changeset/118618
http://trac.webkit.org/changeset/119353
https://bugs.webkit.org/show_bug.cgi?id=88720

Caused at least 30 different crashes on ClusterFuzz (Requested
by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-09

Source/WebCore:

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::allClientsRemoved):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::allClientsRemoved):

  • loader/cache/CachedFont.h:

(WebCore::CachedFontClient::resourceClientType):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::removeClientForRenderer):
(WebCore):
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::lookupOrCreateImageForRenderer):

  • loader/cache/CachedImage.h:

(CachedImage):
(WebCore::CachedImageClient::resourceClientType):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::allClientsRemoved):
(WebCore):

  • loader/cache/CachedRawResource.h:

(CachedRawResource):
(WebCore::CachedRawResourceClient::resourceClientType):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::removeClient):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::allClientsRemoved):

  • loader/cache/CachedResourceClient.h:

(WebCore::CachedResourceClient::resourceClientType):

  • loader/cache/CachedSVGDocument.h:

(WebCore::CachedSVGDocumentClient::resourceClientType):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::allClientsRemoved):

  • loader/cache/CachedStyleSheetClient.h:

(WebCore::CachedStyleSheetClient::resourceClientType):

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::removeClient):

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::removeClient):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeRendererFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndScales):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):

  • svg/graphics/SVGImageCache.h:

(WebCore):
(SVGImageCache):

LayoutTests:

  • http/tests/cache/cancel-in-progress-load-expected.txt: Removed.
  • http/tests/cache/cancel-in-progress-load.html: Removed.
  • http/tests/misc/write-while-waiting.html:
  • svg/as-image/svg-image-leak-cached-data-expected.txt: Removed.
  • svg/as-image/svg-image-leak-cached-data.html: Removed.
2:38 PM Changeset in webkit [119917] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectations after my previous commit (r119916).

  • platform/chromium/TestExpectations:
1:57 PM Changeset in webkit [119916] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Spring CRASH cleanup of Chromium test expectations.
Removed a whole bunch of bogus CRASH test expectations.

  • platform/chromium/TestExpectations:
12:58 PM Changeset in webkit [119915] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove bogus CRASH expectations from skipped tests.
There's no point in specifying test expectation when tests are skipped.

  • platform/chromium/TestExpectations:
12:37 PM Changeset in webkit [119914] by fmalita@chromium.org
  • 3 edits
    4 adds in trunk

Fixed-position foreignObject descendants should be relative to the foreignObject viewport
https://bugs.webkit.org/show_bug.cgi?id=88547

Reviewed by Abhishek Arya.

Source/WebCore:

Tests: svg/foreignObject/fO-fixed-position-crash.html

svg/foreignObject/fixed-position-expected.svg
svg/foreignObject/fixed-position.svg

Fixed position elements are currently registered with the top level
RenderView even when embedded within an SVG foreignOject. This patch
changes containingBlock() & container() to return the containing
foreignObject renderer instead.

The new foreignObject fixed position behavior matches that of current
FireFox and Opera versions and is consistent with the spec:
http://www.w3.org/TR/CSS2/visuren.html#fixed-positioning
http://www.w3.org/TR/SVG/coords.html#EstablishingANewViewport

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::container):

LayoutTests:

  • svg/foreignObject/fO-fixed-position-crash-expected.txt: Added.
  • svg/foreignObject/fO-fixed-position-crash.html: Added.
  • svg/foreignObject/fixed-position-expected.svg: Added.
  • svg/foreignObject/fixed-position.svg: Added.
12:35 PM Changeset in webkit [119913] by abarth@webkit.org
  • 7 edits
    3 adds in trunk

Can't use eval in iframes sanbdoxed via CSP header
https://bugs.webkit.org/show_bug.cgi?id=88450

Reviewed by Mihai Parparita.

Source/WebCore:

The initial empty document in a frame inherits the security context of
its parent (including the CSP policy). When we load the real document,
in some cases we'll do a "secure transition" to the new document. That
means that we leave the global object in place in case the parent
document has created any properties that it expects will be visible to
the new document.

If the parent document has a CSP policy that blocks eval, the "no eval"
bit will be set on the global object of the initial document. When we
perform a "secure transition" to the new document, we'll keep the bit,
which is wrong. In this patch, we reset the bit by always enabling
eval when clearing the context, regardless of whether we're performing
a "secure transition".

Test: http/tests/security/contentSecurityPolicy/iframe-inside-csp.html

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::enableEval):
(WebCore):

  • bindings/js/ScriptController.h:

(ScriptController):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::enableEval):
(WebCore):
(WebCore::ScriptController::disableEval):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):

LayoutTests:

  • http/tests/security/contentSecurityPolicy/iframe-inside-csp-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/iframe-inside-csp.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/sandboxed-eval.php: Added.
12:14 PM Changeset in webkit [119912] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] skip new tests added in r119883
https://bugs.webkit.org/show_bug.cgi?id=88716

Unreviewed EFL gardening. Skip new tests added in r119883.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-09

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
11:42 AM Changeset in webkit [119911] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

The value in Access-Control-Allow-Origin is not being matched correctly for CORS-enabled requests
https://bugs.webkit.org/show_bug.cgi?id=88139

Patch by Pablo Flouret <pablof@motorola.com> on 2012-06-09
Reviewed by Adam Barth.

Source/WebCore:

Compare a request's origin with the value given in any
Access-Control-Allow-Origin headers in an exact, case-sensitive manner,
instead of using SecurityOrigin::isSameSchemeHostPort(). Per step 3 of
the resource sharing check algorithm in
http://dvcs.w3.org/hg/cors/raw-file/tip/Overview.html#resource-sharing-check

Test: http/tests/xmlhttprequest/origin-exact-matching.html

  • loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck):

LayoutTests:

  • http/tests/xmlhttprequest/origin-exact-matching-expected.txt: Added.
  • http/tests/xmlhttprequest/origin-exact-matching.html: Added.
  • http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Get rid of a trailing slash in the origin.
  • http/tests/xmlhttprequest/resources/origin-exact-matching-iframe.html: Added.
11:26 AM Changeset in webkit [119910] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip tests that rely on pathToLocalResource() due to regression in r119788
https://bugs.webkit.org/show_bug.cgi?id=88714

Unreviewed EFL gardening. Skip tests that rely on pathToLocalResource()
due to regression in r119788.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-09

  • platform/efl/TestExpectations:
10:34 AM Changeset in webkit [119909] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling back in part2 of r118646.

This patch removes eager finalization.

Weak pointer finalization should be lazy
https://bugs.webkit.org/show_bug.cgi?id=87599

Reviewed by Sam Weinig.

  • heap/Heap.cpp:

(JSC::Heap::collect): Don't finalize eagerly -- we'll do it lazily.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweep): Do sweep weak sets when sweeping a block,
since we won't get another chance.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::sweepWeakSet):

  • heap/MarkedSpace.cpp:

(MarkedSpace::WeakSetSweep):

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::sweepWeakSets): Removed now-unused code.

10:11 AM Changeset in webkit [119908] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt][Texmap] All layers with backingStore are opaque when using TextureMapperGL.
https://bugs.webkit.org/show_bug.cgi?id=88703

The bug originated from StillImage that is not override
Image::currentFrameHasAlpha(), so it always returns false.
StillImage is used by ImageBuffer, and if Texmap draws contents on ImageBuffer,
TextureMapperBackingStore thinks contents does not have alpha.

Covered by existing compositing tests.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-09
Reviewed by Noam Rosenthal.

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::currentFrameHasAlpha):
(WebCore):

  • platform/graphics/qt/StillImageQt.h:

(StillImage):

10:01 AM Changeset in webkit [119907] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

Basic support for timestamps within a TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=88187

Implemented support for timestamps within a TextTrackCue.
This enables rendering functionality for Karaoke and Paint-on captions.

Patch by Victor Carbune <victor@rosedu.org> on 2012-06-09
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-cue-rendering-inner-timestamps.html

  • css/mediaControls.css: Remove the background shadow pseudo-id and

added two others, which can be further used for styling past / future
contents of the cue.
(video::-webkit-media-text-track-past-nodes): Used to style elements
within the cue that are before the current movie time.
(video::-webkit-media-text-track-future-nodes): Used to style elements
within the cue that are after the current movie time.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Regardless of whether
the active set changed or not, the current cues need to be informed of the current
movie time.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::TextTrackCue): Initiliazed past and future containers.
(WebCore::TextTrackCue::getCueAsHTML): Checked whether the current cue text has
inner timestamps or not, in order to render faster if no timestamps are there.
(WebCore::TextTrackCue::updateDisplayTree): Added method that keeps the past and future
containers up to date, given a current movie time.
(WebCore):
(WebCore::TextTrackCue::getDisplayTree): Replaced the cue background container with the
past cues container. The *internal* display tree of the cue now has two containers,
representing past and future elements.

  • html/track/TextTrackCue.h: Added several variables to support the new functionality.

(TextTrackCue):

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken): Updated representation for this patch.

  • html/track/WebVTTParser.h:

(WebVTTParser): Made public the collectTimeStamp method, as this is required for
parsing timestamps within a cue as well.

LayoutTests:

  • media/track/captions-webvtt/captions-inner-timestamps.vtt: Added.
  • media/track/track-cue-rendering-inner-timestamps-expected.txt: Added.
  • media/track/track-cue-rendering-inner-timestamps.html: Added.
9:53 AM Changeset in webkit [119906] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Open links in Sources panel by default and fallback to Resources and Network panel otherwise.
https://bugs.webkit.org/show_bug.cgi?id=88710

Reviewed by Pavel Feldman.

  • inspector/front-end/inspector.js:

(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector._showAnchorLocation):

9:48 AM Changeset in webkit [119905] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Only expand root domain in Sources/Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=88135

Reviewed by Pavel Feldman.

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorTreeOutline._treeElementsCompare.compare.typeWeight):
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):

9:46 AM Changeset in webkit [119904] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Pretty print should respect text editor indent setting.
https://bugs.webkit.org/show_bug.cgi?id=88713

Reviewed by Pavel Feldman.

  • inspector/front-end/ScriptFormatter.js:
9:29 AM Changeset in webkit [119903] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed the build after r119895.

  • WebCore.xcodeproj/project.pbxproj:
6:18 AM Changeset in webkit [119902] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: [refactoring] rename TimelineVerticalOverview into TimelineFrameOverview
https://bugs.webkit.org/show_bug.cgi?id=88708

Reviewed by Vsevolod Vlasov.

  • rename TimelineVerticalOverview to TimelineFrameOverview;
  • rename associated fields, parameters, CSS classes etc;
  • rename overview mode designators to match the UI;
  • drop unused CSS rules for old-style mode selector;
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showEvents):
(WebInspector.TimelineOverviewPane.prototype._showFrames):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.addFrame):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineFrameOverview):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._shouldShowFrames):
(WebInspector.TimelinePanel.prototype.revealRecordAt):

  • inspector/front-end/timelinePanel.css:

(.timeline-frame-overview #timeline-overview-grid):
(.timeline-frame-overview .timeline-overview-window):
(.timeline-frame-overview .timeline-overview-dividers-background):
(.timeline-frame-overview #timeline-overview-memory):
(.timeline-frame-overview-status-bar-item.toggled-on .glyph):
(.timeline-frame-overview-bars):
(.timeline.timeline-frame-overview .resources-divider):
(.sidebar-tree-item .timeline-frame-overview-status-bar-item):

5:01 AM Changeset in webkit [119901] by vsevik@chromium.org
  • 10 edits in trunk

IndexedDB: Inspector should handle null, string, and array keyPaths
https://bugs.webkit.org/show_bug.cgi?id=84303

Reviewed by Pavel Feldman.

Source/WebCore:

Supported different key path types and updated tests to cover each case.
Key path strings are now highlighted in the DataGrid column headers.

  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.idbKeyPathFromKeyPath):
(WebInspector.IndexedDBModel.keyPathStringFromIDBKeyPath):
(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.ObjectStore.prototype.get keyPathString):
(WebInspector.IndexedDBModel.Index.prototype.get keyPathString):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDataView.prototype._createDataGrid):
(WebInspector.IDBDataView.prototype._keyColumnHeaderFragment):
(WebInspector.IDBDataView.prototype._keyPathStringFragment):
(WebInspector.IDBDataGridNode.prototype.createCell):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.IDBObjectStoreTreeElement.prototype._updateTooltip):
(WebInspector.IDBIndexTreeElement.prototype._updateTooltip):

LayoutTests:

  • http/tests/inspector/indexeddb/database-structure-expected.txt:
  • http/tests/inspector/indexeddb/database-structure.html:
4:49 AM Changeset in webkit [119900] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening failure case on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=88656

Unreviewed EFL gardening after r119795. jquery/core.html test
is crashing on debug bot and failing with a text diff on
release bot.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-09

  • platform/efl/TestExpectations:
4:25 AM Changeset in webkit [119899] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Increase size limits for resource content cached in InspectorResourceAgent.
https://bugs.webkit.org/show_bug.cgi?id=88674

Reviewed by Pavel Feldman.

  • inspector/NetworkResourcesData.cpp:
4:23 AM Changeset in webkit [119898] by vsevik@chromium.org
  • 18 edits in trunk

Web Inspector: Limit DebuggerAgent.Location use to DebuggerModel only, introduce WebInspector.RawLocation to be used elsewhere.
https://bugs.webkit.org/show_bug.cgi?id=87270

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced WebInspector.RawLocation interface, a generic raw location independent from concrete domain (Styles, Debugger).
Made WebInspector.DebuggerModel.Location implement it and switched all debugger related methods to it.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._breakpointResolved):

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):

  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype.continueToLocation):
(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
(WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.prototype._breakpointResolved):
(WebInspector.DebuggerModel.prototype.createRawLocation):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):
(WebInspector.DebuggerModel.prototype.setSelectedCallFrame):
(WebInspector.DebuggerModel.prototype.createLiveLocation):
(WebInspector.DebuggerModel.CallFrame.prototype.get location):
(WebInspector.DebuggerModel.CallFrame.prototype.createLiveLocation):

  • inspector/front-end/DebuggerResourceBinding.js:

(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):
(WebInspector.DebuggerResourceBinding.prototype.setContent.get if):
(WebInspector.DebuggerResourceBinding.prototype.setContent):
(WebInspector.DebuggerResourceBinding.prototype._setContentWithInitialContent):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):

  • inspector/front-end/Linkifier.js:
  • inspector/front-end/ObjectPopoverHelper.js:

(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):

  • inspector/front-end/PresentationConsoleMessageHelper.js:
  • inspector/front-end/RawSourceCode.js:
  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.rawLocationToUILocation):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.SnippetScriptMapping.prototype.rawLocationToUILocation):

  • inspector/front-end/SourceMapping.js:
  • inspector/front-end/UISourceCode.js:

(WebInspector.RawLocation):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/pause-in-inline-script.html:
3:16 AM Changeset in webkit [119897] by commit-queue@webkit.org
  • 15 edits in trunk/Source

Web Inspector: Add message loop instrumentation to public API and timeline agent
https://bugs.webkit.org/show_bug.cgi?id=88639

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-06-09
Reviewed by Vsevolod Vlasov.

Message loop instrumentation will show when the render thread is busy.
That way developer can discover if a render thread business causes low fps, or not.

Source/WebCore:

  • inspector/InspectorClient.h:

(WebCore::InspectorClient::startMessageLoopMonitoring): Starts observer.
(WebCore::InspectorClient::stopMessageLoopMonitoring): Stops observer.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
Changed timeline agent constructor parameters.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willProcessTaskImpl):
Forwards observer notification.
(WebCore):
(WebCore::InspectorInstrumentation::didProcessTaskImpl):
Ditto.

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willProcessTask):
Ditto.
(WebCore):
(WebCore::InspectorInstrumentation::didProcessTask):
Ditto.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):
Starts observer.
(WebCore::InspectorTimelineAgent::stop):
Stops observer.
(WebCore::InspectorTimelineAgent::supportsFrameInstrumentation):
Changed result origin.
(WebCore::InspectorTimelineAgent::willProcessTask):
Noop implementqation.
(WebCore):
(WebCore::InspectorTimelineAgent::didProcessTask):
Noop implementqation.
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
Changed constructor parameters.

  • inspector/InspectorTimelineAgent.h:

(WebCore::InspectorTimelineAgent::create):
Ditto.
(InspectorTimelineAgent):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
Changed timeline agent constructor parameters.

Source/WebKit/chromium:

  • public/WebDevToolsAgent.h:

(WebDevToolsAgent):

  • public/WebDevToolsAgentClient.h:

(WebDevToolsAgentClient):
(WebKit::WebDevToolsAgentClient::startMessageLoopMonitoring):
Request message loop notifications.
(WebKit::WebDevToolsAgentClient::stopMessageLoopMonitoring):
Cancel message loop notifications.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::startMessageLoopMonitoring):
Request message loop notifications.
(WebKit):
(WebKit::InspectorClientImpl::stopMessageLoopMonitoring):
Cancel message loop notifications.

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::startMessageLoopMonitoring):
Request message loop notifications.
(WebKit):
(WebKit::WebDevToolsAgentImpl::stopMessageLoopMonitoring):
Cancel message loop notifications.
(WebKit::WebDevToolsAgentImpl::instrumentWillProcessTask):
Message loop notification.
(WebKit::WebDevToolsAgentImpl::instrumentDidProcessTask):
Ditto.

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

3:13 AM Changeset in webkit [119896] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: optimize timeline's frame mode overview appearance for 30fps
https://bugs.webkit.org/show_bug.cgi?id=88556

Reviewed by Vsevolod Vlasov.

  • adjust frame overview scale to 30fps == full height by default;
  • provide a fall-back auto-scale mode when median frame is longer than 1/30s;
  • add horizontal lines for 30 and 60fps;
  • drive-by fix: always use same order of categories in frame bars.
  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames):
(WebInspector.TimelineVerticalOverview.prototype._renderBars):
(WebInspector.TimelineVerticalOverview.prototype._drawFPSMarks):
(WebInspector.TimelineVerticalOverview.prototype._renderBar):

2:05 AM Changeset in webkit [119895] by commit-queue@webkit.org
  • 35 edits
    6 adds in trunk

Add UNDO_MANAGER flag
https://bugs.webkit.org/show_bug.cgi?id=87908

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-06-09
Reviewed by Tony Chang.

.:

  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add undoManager property to document behind the UNDO_MANAGER flag and
add placeholders for some methods of undoManager.

Test: editing/undomanager/document-has-undomanager.html

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore):
(WebCore::Document::undoManager):

  • dom/Document.h:

(WebCore):
(Document):

  • dom/Document.idl:
  • editing/UndoManager.cpp: Added.

(WebCore):
(WebCore::UndoManager::create):
(WebCore::UndoManager::UndoManager):
(WebCore::UndoManager::undo):
(WebCore::UndoManager::redo):
(WebCore::UndoManager::clearUndo):
(WebCore::UndoManager::clearRedo):

  • editing/UndoManager.h: Added.

(WebCore):
(UndoManager):

  • editing/UndoManager.idl: Added.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

Jun 8, 2012:

11:18 PM Changeset in webkit [119894] by rniwa@webkit.org
  • 3 edits in trunk/Tools

webkit-patch land-safely should set cq? if the patch author is not in committers.py
https://bugs.webkit.org/show_bug.cgi?id=88689

Reviewed by Dirk Pranke.

When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
in committers.py or the contributor cannot commit. If anything, the contributor can still
set cq+ on thier patches manually so I don't think this will be an issue for people who
don't list their Bugzille email on committers.py.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._commit_queue_flag):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(test_commit_queue_flag):
(test_commit_queue_flag.assert_commit_queue_flag):

10:44 PM Changeset in webkit [119893] by leviw@chromium.org
  • 9 edits
    2 adds in trunk

RenderLayer::paintChildLayerIntoColumns doesn't properly pixel snap
https://bugs.webkit.org/show_bug.cgi?id=88554

Reviewed by Darin Adler.

Source/WebCore:

Column handling code in RenderLayer and RenderBlock was improperly clipping and translating
using floats derived from FractionalLayoutUnits without pixel snapping. RenderLayer also
improperly stored render tree offsets in ints instead of LayoutUnits. This corrects this
issue.

Test: fast/sub-pixel/column-clipping.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnContents):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintChildLayerIntoColumns):

LayoutTests:

  • fast/sub-pixel/column-clipping-expected.html: Added.
  • fast/sub-pixel/column-clipping.html: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
  • platform/chromium/TestExpectations:
10:02 PM Changeset in webkit [119892] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

Remove FAIL test expectations from EFL, Mac, and Qt ports' test expectations.

  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
8:50 PM Changeset in webkit [119891] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

REGRESSION(r116487?): HTMLFormElement::elementsname? is empty if the form is detached from the document tree
https://bugs.webkit.org/show_bug.cgi?id=88632

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-06-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

Update root node of RadioNodeList when the form element is detached from dom tree.

Test: fast/forms/radionodelist-whose-form-element-detached-from-domtree.html

  • dom/Node.cpp:

(WebCore::Node::resetCachedRadioNodeListRootNode):
New function to update the root node of RadioNodeLists to form element from document.

  • dom/Node.h: Ditto.
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::removedFrom):
On detach, we update the root node of all RadioNodeLists of this form element.

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::setRootElement):
Setter for updating root node.

  • html/RadioNodeList.h:

(RadioNodeList): Ditto.

LayoutTests:

  • fast/forms/radionodelist-whose-form-element-detached-from-domtree-expected.txt: Added.
  • fast/forms/radionodelist-whose-form-element-detached-from-domtree.html: Added.
8:04 PM Changeset in webkit [119890] by dpranke@chromium.org
  • 2 edits in trunk/Tools

remove obsolete NewRunWebKitTests buildbot master factory classes
https://bugs.webkit.org/show_bug.cgi?id=88693

Reviewed by Ryosuke Niwa.

I believe these aren't used any more ...

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.getText2):
(BuildAndTestLeaksFactory):

7:51 PM Changeset in webkit [119889] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Remove all uses of FAIL test expectation from Chromium test expectations.

  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
7:45 PM Changeset in webkit [119888] by wangxianzhu@chromium.org
  • 3 edits in trunk/Tools

[Chromium-Android] Build DumpRenderTree with Android SDK
https://bugs.webkit.org/show_bug.cgi?id=88598

Change WebKit side of DRT related code according to some recent changes at chromium side.

Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort._path_to_driver):

7:29 PM Changeset in webkit [119887] by commit-queue@webkit.org
  • 21 edits in trunk/Source

[Chromium] Compositor doesn't support translucent root layers.
https://bugs.webkit.org/show_bug.cgi?id=87821

Patch by David Reveman <reveman@chromium.org> on 2012-06-08
Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebLayer.h:

(WebLayer):

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

Source/WebCore:

Forward the isTransparent WebView setting to WebLayerTreeView,
CCLayerTreeHost and CCLayerTreeHostImpl as hasTransparentBackground.
Use hasTransparentBackground setting to determine how to clear the
root render pass and draw the background. Set opaque flag correctly
on the NonCompositedContentHost's graphics layer to make sure
sub-pixel rendering is not used with a transparent WebView.

Unit tests: CCLayerTreeHostImplTest.hasTransparentBackground

LayerRendererChromiumTest2.opaqueRenderPass
LayerRendererChromiumTest2.transparentRenderPass

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::clearRenderPass):
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawBackgroundFilters):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeHost::setHasTransparentBackground):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(WebCore::CCLayerTreeHostImpl::hasTransparentBackground):
(WebCore::CCLayerTreeHostImpl::setHasTransparentBackground):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore::CCRenderPass::hasTransparentBackground):
(WebCore::CCRenderPass::setHasTransparentBackground):
(CCRenderPass):

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setOpaque):
(WebKit):

  • src/NonCompositedContentHost.h:

(NonCompositedContentHost):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::setHasTransparentBackground):
(WebKit):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsTransparent):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:

(ClearCountingContext):
(ClearCountingContext::ClearCountingContext):
(ClearCountingContext::clear):
(ClearCountingContext::clearCount):
(TEST):

7:26 PM Changeset in webkit [119886] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk/Source

[chromium] Single thread proxy's animation timer should short circuit if the layer renderer has not been initialized
https://bugs.webkit.org/show_bug.cgi?id=88668

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-08
Reviewed by James Robinson.

Source/WebCore:

Unit test: CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer.runSingleThreaded

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestWriteLayersRedraw::beginTest):
(WTF::CCLayerTreeHostTestWriteLayersAfterVisible::commitCompleteOnCCThread):
(WTF):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::CCLayerTreeHostTestLayerAddedWithAnimation):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::didAddAnimation):
(CCLayerTreeHostTestLayerAddedWithAnimation):

  • tests/CCSingleThreadProxyTest.cpp: Added.

(FakeWebGraphicsContext3DMakeCurrentFails):
(FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::beginTest):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::animateLayers):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::didRecreateContext):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::afterTest):
(TEST_F):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::beginTest):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::animateLayers):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::didRecreateContext):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::didAddAnimation):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::afterTest):

  • tests/CCThreadedTest.cpp: Added.

(WebKitTests):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WebKitTests::TestHooks::createContext):
(WebKitTests::MockLayerTreeHostImpl::create):
(WebKitTests::MockLayerTreeHostImpl::beginCommit):
(WebKitTests::MockLayerTreeHostImpl::commitComplete):
(WebKitTests::MockLayerTreeHostImpl::prepareToDraw):
(WebKitTests::MockLayerTreeHostImpl::drawLayers):
(WebKitTests::MockLayerTreeHostImpl::animateLayers):
(WebKitTests::MockLayerTreeHostImpl::lowFrequencyAnimationInterval):
(WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(MockLayerTreeHost):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(MockLayerTreeHostClient):
(WebKitTests::MockLayerTreeHostClient::create):
(WebKitTests::MockLayerTreeHostClient::MockLayerTreeHostClient):
(TimeoutTask):
(WebKitTests::TimeoutTask::TimeoutTask):
(WebKitTests::TimeoutTask::clearTest):
(WebKitTests::TimeoutTask::~TimeoutTask):
(WebKitTests::TimeoutTask::run):
(BeginTask):
(WebKitTests::BeginTask::BeginTask):
(WebKitTests::BeginTask::~BeginTask):
(WebKitTests::BeginTask::run):
(EndTestTask):
(WebKitTests::EndTestTask::EndTestTask):
(WebKitTests::EndTestTask::~EndTestTask):
(WebKitTests::EndTestTask::clearTest):
(WebKitTests::EndTestTask::run):
(WebKitTests::CCThreadedTest::CCThreadedTest):
(WebKitTests::CCThreadedTest::endTest):
(WebKitTests::CCThreadedTest::endTestAfterDelay):
(WebKitTests::CCThreadedTest::postSetNeedsAnimateToMainThread):
(WebKitTests::CCThreadedTest::postAddAnimationToMainThread):
(WebKitTests::CCThreadedTest::postAddInstantAnimationToMainThread):
(WebKitTests::CCThreadedTest::postSetNeedsCommitToMainThread):
(WebKitTests::CCThreadedTest::postAcquireLayerTextures):
(WebKitTests::CCThreadedTest::postSetNeedsRedrawToMainThread):
(WebKitTests::CCThreadedTest::postSetNeedsAnimateAndCommitToMainThread):
(WebKitTests::CCThreadedTest::postSetVisibleToMainThread):
(WebKitTests::CCThreadedTest::postDidAddAnimationToMainThread):
(WebKitTests::CCThreadedTest::doBeginTest):
(WebKitTests::CCThreadedTest::timeout):
(WebKitTests::CCThreadedTest::scheduleComposite):
(WebKitTests::CCThreadedTest::onEndTest):
(WebKitTests::CCThreadedTest::dispatchSetNeedsAnimate):
(WebKitTests::CCThreadedTest::dispatchAddInstantAnimation):
(WebKitTests::CCThreadedTest::dispatchAddAnimation):
(WebKitTests::CCThreadedTest::dispatchSetNeedsAnimateAndCommit):
(WebKitTests::CCThreadedTest::dispatchSetNeedsCommit):
(WebKitTests::CCThreadedTest::dispatchAcquireLayerTextures):
(WebKitTests::CCThreadedTest::dispatchSetNeedsRedraw):
(WebKitTests::CCThreadedTest::dispatchSetVisible):
(WebKitTests::CCThreadedTest::dispatchSetInvisible):
(WebKitTests::CCThreadedTest::dispatchComposite):
(WebKitTests::CCThreadedTest::dispatchDidAddAnimation):
(WebKitTests::CCThreadedTest::runTest):

  • tests/CCThreadedTest.h: Added.

(WebCore):
(WebKit):
(WebKitTests):
(TestHooks):
(WebKitTests::TestHooks::beginCommitOnCCThread):
(WebKitTests::TestHooks::commitCompleteOnCCThread):
(WebKitTests::TestHooks::prepareToDrawOnCCThread):
(WebKitTests::TestHooks::drawLayersOnCCThread):
(WebKitTests::TestHooks::animateLayers):
(WebKitTests::TestHooks::willAnimateLayers):
(WebKitTests::TestHooks::applyScrollAndScale):
(WebKitTests::TestHooks::updateAnimations):
(WebKitTests::TestHooks::layout):
(WebKitTests::TestHooks::didRecreateContext):
(WebKitTests::TestHooks::didAddAnimation):
(WebKitTests::TestHooks::didCommit):
(WebKitTests::TestHooks::didCommitAndDrawFrame):
(WebKitTests::TestHooks::scheduleComposite):
(WebKitTests::TestHooks::notifyAnimationStarted):
(WebKitTests::TestHooks::notifyAnimationFinished):
(CCThreadedTest):
(WebKitTests::CCThreadedTest::clearTimeout):
(WebKitTests::CCThreadedTest::clearEndTestTask):
(WebKitTests::CCThreadedTest::layerTreeHost):
(CCThreadedTestThreadOnly):
(WebKitTests::CCThreadedTestThreadOnly::runTestThreaded):
(MockLayerTreeHostImpl):
(CompositorFakeWebGraphicsContext3DWithTextureTracking):

7:00 PM Changeset in webkit [119885] by ojan@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

Last set of chromium rebaselines missed in r119875.

  • platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
  • platform/chromium-linux/svg/custom/js-update-container-expected.png: Added.
  • platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.png: Added.
  • platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.png: Added.
  • platform/chromium-linux/svg/custom/js-update-transform-addition-expected.png: Added.
  • platform/chromium-linux/svg/custom/js-update-transform-changes-expected.png: Added.
  • platform/chromium-linux/svg/custom/marker-referencePoint-expected.png: Added.
  • platform/chromium-linux/svg/custom/non-scaling-stroke-markers-expected.png: Added.
6:56 PM Changeset in webkit [119884] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk

Caret is not rendered in empty inline contenteditable elements
https://bugs.webkit.org/show_bug.cgi?id=85793

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-06-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

Override localCaretRect in RenderInline. The implementation was almost
identical to localCaretRect in RenderBlock for empty block elements, so
I refactored RenderBlock::localCaretRect and moved the logic to a new
method 'localCaretRectForEmptyElement' in RenderBoxModelObject. The
implementation of 'localCaretRect' in RenderBlock and RenderInline both
use this helper method in RenderBoxModelObject.

Tests: editing/selection/caret-in-empty-inline-1.html

editing/selection/caret-in-empty-inline-2.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::localCaretRect):
Modified to use RenderBoxModelObject::localCaretRectForEmptyElement.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
(WebCore):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):
Add localCaretRectForEmptyElement helper method.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::localCaretRect):
(WebCore):

  • rendering/RenderInline.h:

(RenderInline):
Override localCaretRect using localCaretRectForEmptyElement.

LayoutTests:

Add test cases for caret in empty inline.

  • editing/selection/caret-in-empty-inline-1-expected.txt: Added.
  • editing/selection/caret-in-empty-inline-1.html: Added.
  • editing/selection/caret-in-empty-inline-2-expected.txt: Added.
  • editing/selection/caret-in-empty-inline-2.html: Added.
6:51 PM Changeset in webkit [119883] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

Source/WebCore: Treat blob: and filesystem: URLs generated via secure origins as secure.
https://bugs.webkit.org/show_bug.cgi?id=84054

Loading a blob: or filesystem: URL into an iframe or image that's
contained on an HTTPS page shouldn't generate a mixed content warning.
This change adds a SecurityOrigin::isSecure to check both against a
URLs protocol, and the protocol of it's so-called "inner URL" if it's
the type of URL that has such a thing. These sorts of URLs which are
generated from secure sources will themselves be treated as secure.

Patch by Mike West <mkwst@chromium.org> on 2012-06-08
Reviewed by Adam Barth.

Tests: http/tests/security/mixedContent/blob-url-in-iframe.html

http/tests/security/mixedContent/filesystem-url-in-iframe.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::isMixedContent):

  • page/SecurityOrigin.cpp:

(WebCore):
(WebCore::SecurityOrigin::isSecure):

  • page/SecurityOrigin.h:

(SecurityOrigin):

LayoutTests: Excluding blob: and filesystem: schemes from the mixed content check.
https://bugs.webkit.org/show_bug.cgi?id=84054

Patch by Mike West <mkwst@chromium.org> on 2012-06-08
Reviewed by Adam Barth.

  • http/tests/security/mixedContent/blob-url-in-iframe-expected.txt: Added.
  • http/tests/security/mixedContent/blob-url-in-iframe.html: Added.
  • http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt: Added.
  • http/tests/security/mixedContent/filesystem-url-in-iframe.html: Added.
5:56 PM Changeset in webkit [119882] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Cairo] [TextureMapperGL] Nvidia card does not update WebGL texture when interacting with canvas
https://bugs.webkit.org/show_bug.cgi?id=87797

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-08
Reviewed by Philippe Normand.

No new tests. WebGL is already covered by WebGL tests and this
bug is only present on certain hardware.

After resolving multisampling before drawing the texture via the
TextureMapper, first rebind the multisampling framebuffer. This ensures
that the texture isn't active in two framebuffers at a time.

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper): Rebind the multisampling
framebuffer.

5:46 PM Changeset in webkit [119881] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Build fix after Windows export definition file change.

  • win/WebKit2CFLite.def: This file needs to be kept in sync with

WebKit2.def (aside from the WebKitInterface exports.)

5:12 PM Changeset in webkit [119880] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix crash on PagePopupChromeClient
https://bugs.webkit.org/show_bug.cgi?id=88675

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-08
Reviewed by Antonio Gomes.

PR 163672.

Actually it's the bug inside InputHandler, should delete the old popup and create a new one,
because update() is problematic. Also no need to save pointer in InputHandler.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::openPagePopup):
(WebCore::ChromeClientBlackBerry::closePagePopup):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::~InputHandler):
(BlackBerry::WebKit::InputHandler::openSelectPopup):

  • WebKitSupport/InputHandler.h:

(WebCore):
(InputHandler):

5:07 PM Changeset in webkit [119879] by efidler@rim.com
  • 3 edits
    2 adds in trunk

[BlackBerry] Default font settings are getting deleted
https://bugs.webkit.org/show_bug.cgi?id=88670

Reviewed by Rob Buis.

Source/WebKit/blackberry:

RIM PR: 163720

WebSettings is overriding the default font settings with "", which deletes them.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

LayoutTests:

This test crashes if -webkit-body (i.e. WebCore::Settings::standardFontFamily())
is not a valid font family.

  • fonts/valid-standard-font.html: Added.
4:57 PM Changeset in webkit [119878] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling back in part1 of r118646.

This patch includes everything necessary for lazy finalization, but
keeps eager finalization enabled for the time being.

Weak pointer finalization should be lazy
https://bugs.webkit.org/show_bug.cgi?id=87599

Reviewed by Sam Weinig.

  • heap/MarkedBlock.cpp:
  • heap/MarkedBlock.h:

(JSC::MarkedBlock::resetAllocator):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::resetAllocators):

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::resetAllocators): Don't force allocator reset anymore.
It will happen automatically when a weak set is swept. It's simpler to
have only one canonical way for this to happen, and it wasn't buying
us anything to do it eagerly.

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::sweep): Don't short-circuit a sweep unless we know
the sweep would be a no-op. If even one finalizer is pending, we need to
run it, since we won't get another chance.

  • heap/WeakSet.cpp:

(JSC::WeakSet::sweep): This loop can be simpler now that
WeakBlock::sweep() does what we mean.
Reset our allocator after a sweep because this is the optimal time to
start trying to recycle old weak pointers.
(JSC::WeakSet::tryFindAllocator): Don't sweep when searching for an
allocator because we've swept already, and forcing a new sweep would be
wasteful.

  • heap/WeakSet.h:

(JSC::WeakSet::shrink): Be sure to reset our allocator after a shrink
because the shrink may have removed the block the allocator was going to
allocate out of.

4:54 PM Changeset in webkit [119877] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/11412294> Add appropriate iOS default font settings

Reviewed by Dan Bernstein.

  • page/mac/SettingsMac.mm: (WebCore::Settings::initializeDefaultFontFamilies):
4:41 PM Changeset in webkit [119876] by charles.wei@torchmobile.com.cn
  • 3 edits in trunk/Source/WebCore

IndexedDB: Transactions without any request scheduled should abort itself.
https://bugs.webkit.org/show_bug.cgi?id=88052

Reviewed by Kentaro Hara.

This is needed for indexedDB to make it work for JSC. We need to clean up all the
pending transactions(transactions without any request scheduled) when leaving Javascript context.

Manually tested using the existing test LayoutTests/storage/indexeddb/tutorial.html

  • bindings/js/JSMainThreadExecState.cpp:

(WebCore):
(WebCore::JSMainThreadExecState::didLeaveScriptContext):

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
(JSMainThreadExecState):

4:18 PM Changeset in webkit [119875] by ojan@chromium.org
  • 34 edits
    9 copies
    8 adds
    1 delete in trunk/LayoutTests

Final set of chromium rebaselines for skia change. See crbug.com/131829.

  • platform/chromium-linux/svg/clip-path/clipper-placement-issue-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
  • platform/chromium-linux/svg/css/arrow-with-shadow-expected.png: Added.
  • platform/chromium-linux/svg/css/background-image-svg-expected.png: Added.
  • platform/chromium-linux/svg/custom/broken-internal-references-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png.
  • platform/chromium-linux/svg/custom/dynamic-empty-path-expected.png: Added.
  • platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.png: Added.
  • platform/chromium-linux/svg/custom/svgpolyparser-extra-space-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
  • platform/chromium-linux/svg/custom/use-forward-refs-expected.png: Added.
  • platform/chromium-linux/svg/custom/use-on-clip-path-with-transformation-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png.
  • platform/chromium-linux/svg/text/text-hkern-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
  • platform/chromium-linux/svg/text/text-vkern-expected.png: Added.
  • platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png.
  • platform/chromium-linux/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png.
  • platform/chromium-linux/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
  • platform/chromium-win-xp/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Removed.
  • platform/chromium-win/svg/custom/js-late-marker-creation-expected.png:
  • platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png:
  • platform/chromium-win/svg/custom/js-update-bounce-expected.png:
  • platform/chromium-win/svg/custom/js-update-container-expected.png:
  • platform/chromium-win/svg/custom/js-update-path-changes-expected.png:
  • platform/chromium-win/svg/custom/js-update-path-removal-expected.png:
  • platform/chromium-win/svg/custom/js-update-polygon-changes-expected.png:
  • platform/chromium-win/svg/custom/js-update-polygon-removal-expected.png:
  • platform/chromium-win/svg/custom/js-update-transform-addition-expected.png:
  • platform/chromium-win/svg/custom/js-update-transform-changes-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/chromium-win/svg/custom/linking-uri-01-b-expected.png:
  • platform/chromium-win/svg/custom/marker-changes-expected.png:
  • platform/chromium-win/svg/custom/marker-child-changes-css-expected.png:
  • platform/chromium-win/svg/custom/marker-child-changes-expected.png:
  • platform/chromium-win/svg/custom/marker-opacity-expected.png:
  • platform/chromium-win/svg/custom/marker-referencePoint-expected.png:
  • platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png:
  • platform/chromium-win/svg/custom/marker-viewBox-changes-expected.png:
  • platform/chromium-win/svg/custom/mask-colorspace-expected.png:
  • platform/chromium-win/svg/custom/mask-on-multiple-objects-expected.png:
  • platform/chromium-win/svg/custom/no-inherited-dashed-stroke-expected.png:
  • platform/chromium-win/svg/custom/non-circular-marker-reference-expected.png:
  • platform/chromium-win/svg/custom/non-scaling-stroke-markers-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.png:
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.png:
  • platform/chromium-win/svg/filters/invalidate-on-child-layout-expected.png:
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/chromium/TestExpectations:
4:13 PM Changeset in webkit [119874] by Martin Robinson
  • 2 edits in trunk

Fix the GTK+ build when OpenGL is enabled.

  • configure.ac: Fix the build.
4:13 PM Changeset in webkit [119873] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

viewspec-parser tests still timeout in Chromium debug even when marked slow.

  • platform/chromium/TestExpectations:
4:09 PM Changeset in webkit [119872] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::CompositeEditCommand::breakOutOfEmptyListItem
https://bugs.webkit.org/show_bug.cgi?id=88361

Reviewed by Levi Weintraub.

Use RefPtr instead of raw pointers across DOM mutations.

No tests are added for the lack of a reliable reduction.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

4:00 PM Changeset in webkit [119871] by commit-queue@webkit.org
  • 6 edits
    4 deletes in trunk

Unreviewed, rolling out r119514.
http://trac.webkit.org/changeset/119514
https://bugs.webkit.org/show_bug.cgi?id=88664

Broke JSFiddle.net (Requested by arv on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-08

Source/WebCore:

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initIsolate):

LayoutTests:

  • fast/dom/Window/window-property-shadowing-name-expected.txt:
  • fast/dom/Window/window-property-shadowing-name.html:
  • fast/dom/Window/window-property-shadowing-onclick-expected.txt: Removed.
  • fast/dom/Window/window-property-shadowing-onclick.html: Removed.
  • platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Removed.
  • platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Removed.
3:35 PM Changeset in webkit [119870] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

Crash in WebCore::InsertParagraphSeparatorCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=88108

Reviewed by Levi Weintraub.

Use NodeVector instead of walking through siblings as we mutate the DOM.

No new tests are added since there is no reliable reduction.

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveRemainingSiblingsToNewParent):
(WebCore):

  • editing/CompositeEditCommand.h:

(CompositeEditCommand):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

3:24 PM Changeset in webkit [119869] by Martin Robinson
  • 2 edits in trunk

[GTK] build accelerated compositing on by default if OpenGL is present
https://bugs.webkit.org/show_bug.cgi?id=88677

Reviewed by Alejandro G. Castro.

Build accelerated compositing by default if OpenGL is present, just like WebGL.
Also prevent enabling WebGL if Clutter is turned on.

  • configure.ac: Build AC by default.
2:59 PM Changeset in webkit [119868] by dgrogan@chromium.org
  • 12 edits in trunk/Source

IndexedDB: rename some instances of open to registerFrontendCallbacks
https://bugs.webkit.org/show_bug.cgi?id=88611

Source/WebCore:

We should still make the change in the WebKit API.

Reviewed by Tony Chang.

No new tests, just a method rename.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::registerFrontendCallbacks):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):

  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::open):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

2:37 PM Changeset in webkit [119867] by danakj@chromium.org
  • 5 edits in trunk/Source

[chromium] Skip willDraw() and didDraw() on fully occluded layers
https://bugs.webkit.org/show_bug.cgi?id=88435

Reviewed by Adrienne Walker.

Source/WebCore:

Current willDraw() is called on all layers with non-empty
visibleLayerRect and non-empty scissorRect. This excludes
layers outside the viewport, but does not exclude occluded
layers. We add a check for occlusion to calculateRenderPasses
in order to avoid willDraw() when it will be culled anyway.

We prevent didDraw() from being called for occluded layers, for
which we did not call didDraw() by holding a vector of layers
for which we did call willDraw(). This lets us avoid storing a
flag on the layers, or computing occlusion again in
didDrawAllLayers.

Unit test: CCLayerTreeHostImplTest.willDrawNotCalledOnOccludedLayer

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(FrameData):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
2:37 PM Changeset in webkit [119866] by ojan@chromium.org
  • 462 edits
    4 copies
    9 moves
    10 adds
    221 deletes in trunk/LayoutTests

Second wave of Chromium rebaselines after skia change. See crbug.com/131829.

List of changed expectations deleted because it's too long.

2:30 PM Changeset in webkit [119865] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Unreviewed roll out r119795.

This broke jquery/core.html

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • llint/LowLevelInterpreter.asm:
  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::setUnwrappedObject):

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):
(JSC::JSObject::createInheritorID):

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::resetInheritorID):
(JSC):
(JSC::JSObject::offsetOfInheritorID):
(JSC::JSObject::inheritorID):

2:13 PM Changeset in webkit [119864] by mitz@apple.com
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

Added Mac pixel results for canvas-imageSmoothingEnabled-patterns.html, and made the text
results shared between platforms.

  • fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
  • platform/mac/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
2:12 PM Changeset in webkit [119863] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

[chromium] Unreviewed, rebaseline a chromium-win result that changed
due to the various mock scrollbar changes.
https://bugs.webkit.org/show_bug.cgi?id=88490

  • platform/chromium-win/fast/repaint/fixed-tranformed-expected.png:
  • platform/chromium/TestExpectations:
1:37 PM Changeset in webkit [119862] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebCore

EventHandler shouldn't schedule the fake mousemove event timer when scrolling on devices that don't have a mouse
https://bugs.webkit.org/show_bug.cgi?id=88379

Reviewed by James Robinson.
Patch by Antonio Gomes <agomes@rim.com>

Paraphrasing Andy Estes:
"In <http://trac.webkit.org/changeset/119465> we stopped dispatching fake
mousemove events when scrolling on devices that don't support mice. This event
is dispatched on a timer, so one better would be to not even schedule the
timer (rather than scheduling the timer but making it a no-op).

No new tests, as no functionality has changed. We basically do not
start a timer under a given circumstance instead of fire it, it times out,
and we make the callback no-op when under the given circumstance.

It is still possible though that we have the following scenario:

  • Setting::deviceSupportsMouse set as true;
  • we fire the timer;
  • before its callback gets executed (timed out) the setting gets toggled.

So for sakeness, lets keep the check in both places.

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

1:31 PM Changeset in webkit [119861] by jamesr@google.com
  • 4 edits in trunk/Source

[chromium] Clean up some unnecessary LayerChromium.h includes
https://bugs.webkit.org/show_bug.cgi?id=88599

Reviewed by Adam Barth.

Source/WebCore:

Reworks test code slightly to use WebCore interfaces.

  • testing/Internals.cpp:

(WebCore::Internals::setBackgroundBlurOnNode):

Source/WebKit/chromium:

Removes unused include, update comment.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):

1:13 PM Changeset in webkit [119860] by schenney@chromium.org
  • 1184 edits
    93 adds
    229 deletes in trunk/LayoutTests

WebCore::ImageBuffer.cpp has broken color table code
https://bugs.webkit.org/show_bug.cgi?id=80321

Unreviewed Chromium test expectations update after changes to SVG filter color conversion.

Full list of changed files excluded to to very large number.

  • platform/chromium/TestExpectations:
1:04 PM Changeset in webkit [119859] by fpizlo@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix JavaScriptCore/ChangeLog goof, where Geoff's change did not have a date + name + email header

1:02 PM Changeset in webkit [119858] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

PredictedType should be called SpeculatedType
https://bugs.webkit.org/show_bug.cgi?id=88477

Unreviewed, fix a renaming goof from http://trac.webkit.org/changeset/119660.
I accidentally renamed ByteCodeParser::getPrediction to
ByteCodeParser::getSpeculation. That was not the intent. This changes it
back.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):

12:57 PM Changeset in webkit [119857] by wingo@igalia.com
  • 13 edits in trunk/Source

Explictly mark stubs called by JIT as being internal
https://bugs.webkit.org/show_bug.cgi?id=88552

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

  • dfg/DFGOSRExitCompiler.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • jit/HostCallReturnValue.h:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/ThunkGenerators.cpp:
  • llint/LLIntSlowPaths.h: Mark a bunch of stubs as being

WTF_INTERNAL. Change most calls to SYMBOL_STRING_RELOCATION to
LOCAL_REFERENCE, or GLOBAL_REFERENCE in the case of the wrappers
to truly global symbols.

  • offlineasm/asm.rb: Generate LOCAL_REFERENCE instead of

SYMBOL_STRING_RELOCATION.

Don't rely on weak pointers for eager CodeBlock finalization
https://bugs.webkit.org/show_bug.cgi?id=88465

Reviewed by Gavin Barraclough.

This is incompatible with lazy weak pointer finalization.

I considered just making CodeBlock finalization lazy-friendly, but it
turns out that the heap is already way up in CodeBlock's business when
it comes to finalization, so I decided to finish the job and move full
responsibility for CodeBlock finalization into the heap.

will build.

  • debugger/Debugger.cpp: Updated for rename.
  • heap/Heap.cpp:

(JSC::Heap::deleteAllCompiledCode): Renamed for consistency. Fixed a bug
where we would not delete code for a code block that had been previously
jettisoned. I don't know if this happens in practice -- I mostly did
this to improve consistency with deleteUnmarkedCompiledCode.

(JSC::Heap::deleteUnmarkedCompiledCode): New function, responsible for
eager finalization of unmarked code blocks.

(JSC::Heap::collect): Updated for rename. Updated to call
deleteUnmarkedCompiledCode(), which takes care of jettisoned DFG code
blocks too.

(JSC::Heap::addCompiledCode): Renamed, since this points to all code
now, not just functions.

  • heap/Heap.h:

(Heap): Keep track of all user code, not just functions. This is a
negligible additional overhead, since most code is function code.

  • runtime/Executable.cpp:

(JSC::*::finalize): Removed these functions, since we don't rely on
weak pointer finalization anymore.

(JSC::FunctionExecutable::FunctionExecutable): Moved linked-list stuff
into base class so all executables can be in the list.

(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::clearCode): All we need to do is delete our
CodeBlock -- that will delete all of its internal data structures.

(JSC::FunctionExecutable::clearCodeIfNotCompiling): Factored out a helper
function to improve clarity.

  • runtime/Executable.h:

(JSC::ExecutableBase): Moved linked-list stuff
into base class so all executables can be in the list.

(JSC::NativeExecutable::create):
(NativeExecutable):
(ScriptExecutable):
(JSC::ScriptExecutable::finishCreation):
(JSC::EvalExecutable::create):
(EvalExecutable):
(JSC::ProgramExecutable::create):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::create): Don't use a finalizer -- the heap
will call us back to destroy our code block.

(JSC::FunctionExecutable::discardCode): Renamed to clearCodeIfNotCompiling()
for clarity.

(JSC::FunctionExecutable::isCompiling): New helper function, for clarity.

(JSC::ScriptExecutable::clearCodeVirtual): New helper function, since
the heap needs to make polymorphic calls to clear code.

  • runtime/JSGlobalData.cpp:

(JSC::StackPreservingRecompiler::operator()):

  • runtime/JSGlobalObject.cpp:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Updated for
renames.

Source/WTF:

  • wtf/ExportMacros.h (WTF_INTERNAL, HAVE_INTERNAL_VISIBILITY): New

defines. Regardless of what the port does about visibility in
general, for code referenced only from assembly it is useful to
give it internal visibility.

  • wtf/InlineASM.h: Split SYMBOL_STRING_RELOCATION into

LOCAL_REFERENCE and GLOBAL_REFERENCE; the former will try to avoid
indirection if HAVE(INTERNAL_VISIBILITY).

12:49 PM Changeset in webkit [119856] by jsbell@chromium.org
  • 6 edits in trunk/LayoutTests

IndexedDB: Add regression test to verify that legacy constants have been removed
https://bugs.webkit.org/show_bug.cgi?id=88669

Reviewed by Tony Chang.

  • storage/indexeddb/legacy-constants-expected.txt:
  • storage/indexeddb/mozilla/create-index-unique-expected.txt:
  • storage/indexeddb/mozilla/resources/create-index-unique.js:

(createAndVerifyIndex):

  • storage/indexeddb/resources/constants.js:

(test):

  • storage/indexeddb/resources/legacy-constants.js:

(testObsoleteConstants):

12:25 PM Changeset in webkit [119855] by ojan@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

First wave of Chromium rebaselines after skia rollback. See crbug.com/131829.

List of changed expected files excluded because it's too long.

12:19 PM Changeset in webkit [119854] by ojan@chromium.org
  • 535 edits
    21 copies
    16 moves
    218 adds
    15 deletes in trunk/LayoutTests

First wave of Chromium rebaselines after skia rollback. See crbug.com/131289.

List of changed expected files excluded because it's too long.

12:05 PM Changeset in webkit [119853] by arv@chromium.org
  • 8 edits
    1 copy in trunk

[V8] Keep TextTrackList alive as long as its owner is alive
https://bugs.webkit.org/show_bug.cgi?id=88541

Reviewed by Adam Barth.

Add a hidden reference from the owner to the text track list.

Source/WebCore:

Covered by existing tests.

  • Target.pri: Add V8TextTrackListCustom.cpp.
  • UseV8.cmake: Ditto.
  • WebCore.gypi: Ditto.
  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/custom/V8TextTrackListCustom.cpp: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.

(WebCore):
(WebCore::toV8): When the wrapper is created add a reference to the owner of the TextTrackList to the TextTrackList.

  • html/track/TextTrackList.idl:

LayoutTests:

  • platform/chromium/TestExpectations:
11:53 AM Changeset in webkit [119852] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
11:44 AM Changeset in webkit [119851] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add app_abi option for DumpRenderTree_apk
https://bugs.webkit.org/show_bug.cgi?id=88626

Patch by Wei James <james.wei@intel.com> on 2012-06-08
Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11:41 AM Changeset in webkit [119850] by commit-queue@webkit.org
  • 20 edits
    2 adds in trunk/Source

[chromium] Accelerated animations should use WebTransformOperations
https://bugs.webkit.org/show_bug.cgi?id=87686

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-08
Reviewed by James Robinson.

CCTransformKeyframe new owns a WebTransformOperations rather than a
TransformOperations. LayerChromium's API has been changed so that
LayerChromium::addAnimation should take only a CCActiveAnimation.
GraphicsLayerChromium is new responsible for translating to
WebTransformOperations and creating CCActiveAnimations. Tests that use
the public API (that is, they call addAnimation with KeyframeValueList
and Animation arguments) have been moved to GraphicsLayerChromiumTest.

Source/WebCore:

Unit tests:

GraphicsLayerChromiumTest.createOpacityAnimation
GraphicsLayerChromiumTest.createTransformAnimation
GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
GraphicsLayerChromiumTest.createTransformAnimationWithSingularMatrix
GraphicsLayerChromiumTest.createReversedAnimation
GraphicsLayerChromiumTest.createAlternatingAnimation
GraphicsLayerChromiumTest.createReversedAlternatingAnimation

  • WebCore.gypi:
  • platform/graphics/chromium/AnimationTranslationUtil.cpp: Added.

(WebCore):
(WebCore::toWebTransformOperations):
(WebCore::appendKeyframe):
(WebCore::CCKeyframedTransformAnimationCurve):
(WebCore::createActiveAnimation):

  • platform/graphics/chromium/AnimationTranslationUtil.h: Added.

(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(WebCore::LayerChromium::bounds):
(LayerChromium):

  • platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::LinkHighlight):

  • platform/graphics/chromium/cc/CCAnimationCurve.h:

(CCTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:

(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):

  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCTransformKeyframe):
(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::removeAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::addAnimation):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationControllerClient):
(CCLayerAnimationController):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::bounds):

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.cpp:

(WebCore::addOpacityTransition):
(WebCore::addAnimatedTransform):
(WebKitTests::FakeTransformTransition::getValue):

  • tests/CCAnimationTestCommon.h:
  • tests/CCKeyframedAnimationCurveTest.cpp:
  • tests/CCLayerAnimationControllerTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):

  • tests/GraphicsLayerChromiumTest.cpp:

(MockLayerTreeHostClient):
(WebKitTests):
(MockLayerTreeHost):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::expectTranslateX):
(WebKitTests::TEST_F):

  • tests/LayerChromiumTest.cpp:
11:39 AM Changeset in webkit [119849] by noam.rosenthal@nokia.com
  • 6 edits in trunk/Source/WebCore

[Texmap] Accelerated versions of drop-shadow and blur filters
https://bugs.webkit.org/show_bug.cgi?id=87695

Reviewed by Kenneth Rohde Christiansen.

Added shaders for blur and drop-shadow effects.
The shaders use sampling of multiple coordinates and averaging them with normal-
distribution to create a fast gaussian blur effect.

Covered by existing tests in css3/filters.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawFiltered):

Call the prepare function explicitly, with a size argument that's used to calculate
some of the uniform values.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::intermediateSurfaceRect):

The outsets of the effect have to be considered when calculating the intermediate rect.
Otherwise the resulting image is scaled instead of outsetted.

(WebCore::applyFilters):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::StandardFilterProgram::StandardFilterProgram):

Added the new shaders.

(WebCore::StandardFilterProgram::prepare):
(WebCore::TextureMapperShaderManager::getShaderForFilter):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(StandardFilterProgram):

11:36 AM Changeset in webkit [119848] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the build after r119844.

  • bindings/js/GCController.cpp:

(WebCore::GCController::discardAllCompiledCode):

11:34 AM Changeset in webkit [119847] by ostapenko.viatcheslav@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] [WK2] API tests randomly assert in WebLayerTreeRenderer::assignImageToLayer
https://bugs.webkit.org/show_bug.cgi?id=88667

Reviewed by Noam Rosenthal.

Move deactivation of WebLayerTreeRenderer from LayerTreeHostProxy::purgeBackingStores
to WebLayerTreeRenderer::purgeGLResources. LayerTreeHostProxy::purgeBackingStores is
invoked on main thread after going through call gate and it is too late to deactivate
renderer here, because some update messages are able to go through.
WebLayerTreeRenderer::purgeGLResources is called directly from render node deallocation
and it is right place to deactivate renderer.

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::purgeBackingStores):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::purgeGLResources):

11:24 AM Changeset in webkit [119846] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add COMPILE_ASSERT to StyledElement to ensure it doesn't accidentally grow larger.
https://bugs.webkit.org/show_bug.cgi?id=88627

Patch by Mike West <mkwst@chromium.org> on 2012-06-08
Reviewed by Adam Barth.

No change in user-facing behavior.

  • dom/StyledElement.cpp:

(WebCore):

11:19 AM Changeset in webkit [119845] by tony@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

[chromium] Unreviewed, rebaseline platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html after skia gamma correction
https://bugs.webkit.org/show_bug.cgi?id=88589

  • platform/chromium-linux/platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle-expected.png: Added.
  • platform/chromium/TestExpectations:
11:17 AM Changeset in webkit [119844] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Don't rely on weak pointers for eager CodeBlock finalization
https://bugs.webkit.org/show_bug.cgi?id=88465

Reviewed by Gavin Barraclough.

This is incompatible with lazy weak pointer finalization.

I considered just making CodeBlock finalization lazy-friendly, but it
turns out that the heap is already way up in CodeBlock's business when
it comes to finalization, so I decided to finish the job and move full
responsibility for CodeBlock finalization into the heap.

will build.

  • debugger/Debugger.cpp: Updated for rename.
  • heap/Heap.cpp:

(JSC::Heap::deleteAllCompiledCode): Renamed for consistency. Fixed a bug
where we would not delete code for a code block that had been previously
jettisoned. I don't know if this happens in practice -- I mostly did
this to improve consistency with deleteUnmarkedCompiledCode.

(JSC::Heap::deleteUnmarkedCompiledCode): New function, responsible for
eager finalization of unmarked code blocks.

(JSC::Heap::collect): Updated for rename. Updated to call
deleteUnmarkedCompiledCode(), which takes care of jettisoned DFG code
blocks too.

(JSC::Heap::addCompiledCode): Renamed, since this points to all code
now, not just functions.

  • heap/Heap.h:

(Heap): Keep track of all user code, not just functions. This is a
negligible additional overhead, since most code is function code.

  • runtime/Executable.cpp:

(JSC::*::finalize): Removed these functions, since we don't rely on
weak pointer finalization anymore.

(JSC::FunctionExecutable::FunctionExecutable): Moved linked-list stuff
into base class so all executables can be in the list.

(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::clearCode): All we need to do is delete our
CodeBlock -- that will delete all of its internal data structures.

(JSC::FunctionExecutable::clearCodeIfNotCompiling): Factored out a helper
function to improve clarity.

  • runtime/Executable.h:

(JSC::ExecutableBase): Moved linked-list stuff
into base class so all executables can be in the list.

(JSC::NativeExecutable::create):
(NativeExecutable):
(ScriptExecutable):
(JSC::ScriptExecutable::finishCreation):
(JSC::EvalExecutable::create):
(EvalExecutable):
(JSC::ProgramExecutable::create):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::create): Don't use a finalizer -- the heap
will call us back to destroy our code block.

(JSC::FunctionExecutable::discardCode): Renamed to clearCodeIfNotCompiling()
for clarity.

(JSC::FunctionExecutable::isCompiling): New helper function, for clarity.

(JSC::ScriptExecutable::clearCodeVirtual): New helper function, since
the heap needs to make polymorphic calls to clear code.

  • runtime/JSGlobalData.cpp:

(JSC::StackPreservingRecompiler::operator()):

  • runtime/JSGlobalObject.cpp:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Updated for
renames.

11:14 AM Changeset in webkit [119843] by rjkroege@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

More than 8 fingers get ignored by touch
https://bugs.webkit.org/show_bug.cgi?id=88359

Reviewed by James Robinson.

  • public/WebInputEvent.h: Increase of TouchPoints per TouchEvent from 8 to 12.
10:59 AM Changeset in webkit [119842] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Added svg/filters/color-space-conversion.svg to the Mac skip list. It has been failing since
its addition in r119841. <http://webkit.org/b/88672> is tracking the failure.

  • platform/mac/Skipped:
10:52 AM Changeset in webkit [119841] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

WebCore::ImageBuffer.cpp has broken color table code
https://bugs.webkit.org/show_bug.cgi?id=80321

Unreviewed Chromium expectations update.

Adding tests that are failing pending a rebaseline.

  • platform/chromium/TestExpectations:
10:46 AM Changeset in webkit [119840] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed, remove css3/flexbox/child-overflow.html from TestExpectations.
Since bug 77368 is now fixed, this test passes.

  • platform/chromium/TestExpectations:
9:57 AM Changeset in webkit [119839] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Fix several compiler warnings and errors.
https://bugs.webkit.org/show_bug.cgi?id=88660

Reviewed by Pavel Feldman.

Fixed several compiler warnings and errors.
Removed isEmpty method from Object.prototype and made it static method on Object.

  • inspector/InjectedScriptExterns.js:
  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype._detachFrame):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildDominatorTree):

  • inspector/front-end/utilities.js:

(Object.isEmpty):

9:54 AM Changeset in webkit [119838] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fix assertion failure introduced by bug 87551
https://bugs.webkit.org/show_bug.cgi?id=88659

Patch by Max Feil <mfeil@rim.com> on 2012-06-08
Reviewed by Antonio Gomes.

The determineRenderSlider() convenience function added in bug
87551 made an assumption that wasn't always true. This didn't
cause a functional error but it caused an assertion failure,
which indicates a problem with the code. PR164142.

No new tests because this case is already covered by ASSERT's.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::determineRenderSlider):

9:37 AM Changeset in webkit [119837] by Carlos Garcia Campos
  • 11 edits
    3 adds in trunk

[GTK] Add API to get the library version to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=88426

Reviewed by Martin Robinson.

.:

  • configure.ac: Generate WebKitVersion.h from WebKitVersion.h.in

file.

Source/WebKit2:

  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • UIProcess/API/gtk/WebKitVersion.cpp: Added.

(webkit_get_major_version):
(webkit_get_minor_version):
(webkit_get_micro_version):

  • UIProcess/API/gtk/WebKitVersion.h.in: Added.
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new section

for WebKitVersion.

  • UIProcess/API/gtk/tests/GNUmakefile.am:
  • UIProcess/API/gtk/tests/TestWebKitVersion.cpp: Added.

(testWebKitVersion):
(testWebKitCheckVersion):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/webkit2.h: Include WebKitVersion.h.

Tools:

  • gtk/generate-gtkdoc:

(get_webkit2_options): Add built sources to the list of files, but
ignore enum types and marshallers.

9:27 AM BuildBot edited by alex.bravo@nokia.com
FIxed a typo (diff)
9:26 AM BuildBot edited by alex.bravo@nokia.com
Fixed formatting of lists (diff)
8:36 AM Changeset in webkit [119836] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix for Chromium TestExpectations.

A file crept into the expectations that has not yet been submitted.

  • platform/chromium/TestExpectations:
8:35 AM Changeset in webkit [119835] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed, fix file permissions.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
8:23 AM Changeset in webkit [119834] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

Some overlay scrollbar API calls in ScrollAnimatorMac can lead to an assertion in RenderBox::mapAbsoluteToLocalPoint
https://bugs.webkit.org/show_bug.cgi?id=74111

Patch by Ion Rosca <Ion Rosca> on 2012-06-08
Reviewed by Simon Fraser.

.:

  • ManualTests/scrollbar-crash-on-hide-scrolled-area.html: Added.

Source/WebCore:

Added zero-delay timer for AppKit scroll notification that can be called during layout.
Manual test: ManualTests/scrollbar-crash-on-hide-scrolled-area.html
This assertion does not fire when running layout tests. It can be easly reproduced using a debug build by loading the manual test page.

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledSoon):
(WebCore):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

8:20 AM Changeset in webkit [119833] by reni@webkit.org
  • 6 edits in trunk

Adding few already supported features to the FeatureSet in DOMImplementation
https://bugs.webkit.org/show_bug.cgi?id=86482

Source/WebCore:

Text, Filter and View features are already implemented but they
are not added to the SVG11 feature set. This is corrected in this patch.

Reviewed by Nikolas Zimmermann.

No new testcase is needed because we already have one what checks the svg features via
DOMImplementation (svg/custom/svg-features.html).

  • dom/DOMImplementation.cpp:

(WebCore::isSVG11Feature):

LayoutTests:

Reviewed by Nikolas Zimmermann.

  • platform/qt-5.0/svg/custom/svg-features-expected.txt:
  • platform/qt/svg/custom/svg-features-expected.txt:
  • svg/custom/svg-features-expected.txt:
8:13 AM Changeset in webkit [119832] by scheib@chromium.org
  • 4 edits in trunk

Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88604

Reviewed by Kent Tamura.

Tools:

DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::requestPointerUnlock):

LayoutTests:

Removed CRASH expectation.
Test is no longer crashing with this fix to DumpRenderTree.

  • platform/chromium/TestExpectations:
8:01 AM Changeset in webkit [119831] by schenney@chromium.org
  • 5 edits
    2 adds in trunk

WebCore::ImageBuffer.cpp has broken color table code
https://bugs.webkit.org/show_bug.cgi?id=80321

Reviewed by Dirk Schulze.

Source/WebCore:

The code in ImageBuffer::transformColorSpace had two problems that are
fixed by this patch.

First, it was using member variables for data
that is static constant. This is incredibly wasteful, as every
ImageBuffer that is created (and we make a lot of them) gets its own
copy of the LUT and the table is initialized again and again. The
patch replaces this with a static local, with lazy evaluation, in
the method that uses the tables.

Second, the code for filling the table was mapping 255 to 254, thus
reducing the intensity and alpha of every image it pushed through a
color transform.

Test: svg/filters/color-space-conversion.svg

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::transformColorSpace):

  • platform/graphics/ImageBuffer.h:

(ImageBuffer):

LayoutTests:

Temporarily marking Chromium tests expected to fail as a result of this patch. And a new test.

  • platform/chromium/TestExpectations:
  • svg/filters/color-space-conversion.svg:
  • svg/filters/color-space-conversion-expected.svg:
7:44 AM Changeset in webkit [119830] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Better labels positioning on the memory pie chart
https://bugs.webkit.org/show_bug.cgi?id=88652

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-08
Reviewed by Vsevolod Vlasov.

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemoryPieChart.prototype._paint.paintPercentAndLabel):
(WebInspector.NativeMemoryPieChart.prototype._paint):

7:30 AM Changeset in webkit [119829] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Tried to fix the Snow Leopard build after r119806.

  • WebKit2Prefix.h:
7:23 AM Changeset in webkit [119828] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-08

  • DEPS:
7:11 AM Changeset in webkit [119827] by qi.2.zhang@nokia.com
  • 2 edits in trunk/LayoutTests

[Qt] fast/viewport/viewport-133.html fails
https://bugs.webkit.org/show_bug.cgi?id=80689

Since https://bugs.webkit.org/show_bug.cgi?id=88047 remove this
test case, remove it from skip list.

Reviewed by Laszlo Gombos.

  • platform/qt/Skipped:
6:07 AM Changeset in webkit [119826] by caseq@chromium.org
  • 30 edits in trunk

Web Inspector: Annotate timeline records with a frame identifier
https://bugs.webkit.org/show_bug.cgi?id=86406

Patch by Bryan McQuade <bmcquade@google.com> on 2012-06-08
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Tests: Updated existing layout tests.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::frameForScriptExecutionContext):
(WebCore):
(WebCore::InspectorInstrumentation::didScheduleResourceRequestImpl):
(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willCallFunctionImpl):
(WebCore::InspectorInstrumentation::willChangeXHRReadyStateImpl):
(WebCore::InspectorInstrumentation::willDispatchEventImpl):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
(WebCore::InspectorInstrumentation::willEvaluateScriptImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::willLayoutImpl):
(WebCore::InspectorInstrumentation::willLoadXHRImpl):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::willRecalculateStyleImpl):
(WebCore::InspectorInstrumentation::willSendRequestImpl):
(WebCore::InspectorInstrumentation::willReceiveResourceDataImpl):
(WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::loadEventFiredImpl):
(WebCore::InspectorInstrumentation::willWriteHTMLImpl):
(WebCore::InspectorInstrumentation::didRequestAnimationFrameImpl):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didScheduleResourceRequest):
(WebCore::InspectorInstrumentation::didInstallTimer):
(WebCore::InspectorInstrumentation::didRemoveTimer):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::willChangeXHRReadyState):
(WebCore::InspectorInstrumentation::willDispatchEvent):
(WebCore::InspectorInstrumentation::willEvaluateScript):
(WebCore::InspectorInstrumentation::willFireTimer):
(WebCore::InspectorInstrumentation::willLayout):
(WebCore::InspectorInstrumentation::willLoadXHR):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::willRecalculateStyle):
(WebCore::InspectorInstrumentation::willReceiveResourceData):
(WebCore::InspectorInstrumentation::willReceiveResourceResponse):
(WebCore::InspectorInstrumentation::willWriteHTML):
(WebCore::InspectorInstrumentation::didRequestAnimationFrame):
(WebCore::InspectorInstrumentation::didCancelAnimationFrame):
(WebCore::InspectorInstrumentation::willFireAnimationFrame):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::willDispatchEvent):
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::willRecalculateStyle):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::willComposite):
(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didInstallTimer):
(WebCore::InspectorTimelineAgent::didRemoveTimer):
(WebCore::InspectorTimelineAgent::willFireTimer):
(WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
(WebCore::InspectorTimelineAgent::willLoadXHR):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willReceiveResourceData):
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
(WebCore::InspectorTimelineAgent::didFinishLoadingResource):
(WebCore::InspectorTimelineAgent::didTimeStamp):
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
(WebCore::InspectorTimelineAgent::didMarkLoadEvent):
(WebCore::InspectorTimelineAgent::didRequestAnimationFrame):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrame):
(WebCore::InspectorTimelineAgent::willFireAnimationFrame):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::pushCancelableRecord):
(WebCore::InspectorTimelineAgent::commitCancelableRecords):

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(WebCore::InspectorTimelineAgent::create):
(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.isEventDivider):
(WebInspector.TimelinePresentationModel.Record):

LayoutTests:

  • inspector/timeline/timeline-animation-frame-expected.txt:
  • inspector/timeline/timeline-dom-content-loaded-event-expected.txt:
  • inspector/timeline/timeline-event-dispatch-expected.txt:
  • inspector/timeline/timeline-injected-script-eval-expected.txt:
  • inspector/timeline/timeline-layout-expected.txt:
  • inspector/timeline/timeline-load-event-expected.txt:
  • inspector/timeline/timeline-network-resource-expected.txt:
  • inspector/timeline/timeline-paint-expected.txt:
  • inspector/timeline/timeline-parse-html-expected.txt:
  • inspector/timeline/timeline-recalculate-styles-expected.txt:
  • inspector/timeline/timeline-script-tag-1-expected.txt:
  • inspector/timeline/timeline-script-tag-2-expected.txt:
  • inspector/timeline/timeline-test.js:
  • inspector/timeline/timeline-timer-expected.txt:
  • platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt:
  • platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt:
  • platform/chromium/inspector/timeline/timeline-layout-expected.txt:
  • platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
  • platform/chromium/inspector/timeline/timeline-paint-expected.txt:
  • platform/chromium/inspector/timeline/timeline-parse-html-expected.txt:
  • platform/chromium/inspector/timeline/timeline-timer-expected.txt:
5:59 AM Changeset in webkit [119825] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed update for chromium test expectations.
viewspec-parser-*.html were marked as SLOW.

  • platform/chromium/TestExpectations:

BUGWK87772 SLOW : svg/dom/viewspec-parser-1.html = PASS
BUGWK87772 SLOW : svg/dom/viewspec-parser-2.html = PASS
BUGWK87772 SLOW : svg/dom/viewspec-parser-3.html = PASS
BUGWK87772 SLOW : svg/dom/viewspec-parser-4.html = PASS
BUGWK87772 SLOW : svg/dom/viewspec-parser-5.html = PASS

5:46 AM Changeset in webkit [119824] by kinuko@chromium.org
  • 12 edits in trunk/Source/WebCore

Unreviewed, rolling out r119821.
http://trac.webkit.org/changeset/119821
https://bugs.webkit.org/show_bug.cgi?id=88648

Seems to have regression on Mac (Requested by kinuko on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-08

  • fileapi/File.cpp:

(WebCore::File::File):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding):
(WebCore):
(WebCore::File::captureSnapshot):

  • fileapi/File.h:

(File):

  • fileapi/File.idl:
  • platform/FileMetadata.h:

(WebCore::FileMetadata::FileMetadata):

  • platform/FileSystem.h:
  • platform/chromium/support/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

  • platform/network/BlobData.cpp:

(WebCore):

  • platform/network/BlobData.h:

(BlobDataItem):
(WebCore::BlobDataItem::BlobDataItem):

  • platform/network/FormData.cpp:

(WebCore::FormData::appendFile):

  • platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::advanceCurrentStream):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::blobIsOutOfDate):

5:29 AM Changeset in webkit [119823] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, removing duplicated entries in gyp.

  • WebCore.gypi:
5:16 AM Changeset in webkit [119822] by arko@motorola.com
  • 3 edits
    2 adds in trunk

Microdata: An element with an empty itemprop= should not get listed in the .properties list.
https://bugs.webkit.org/show_bug.cgi?id=88235

Reviewed by Ryosuke Niwa.

Source/WebCore:

As per the specification change http://html5.org/r/6854, an element should be listed in .properties
if the elelement has an attribute itemprop specified and the element has one or more property names.

Test: fast/dom/MicroData/element-with-empty-itemprop.html

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::itemAfter):

LayoutTests:

  • fast/dom/MicroData/element-with-empty-itemprop-expected.txt: Added.
  • fast/dom/MicroData/element-with-empty-itemprop.html: Added.
4:50 AM Changeset in webkit [119821] by kinuko@chromium.org
  • 12 edits in trunk/Source/WebCore

File::lastModifiedDate should use NaN or separate boolean flag for null Date value
https://bugs.webkit.org/show_bug.cgi?id=87826

Reviewed by Kent Tamura.

Test: http/tests/local/fileapi/file-last-modified-after-delete.html

  • fileapi/File.cpp:

(WebCore::File::File):
(WebCore::File::captureSnapshot):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding): Removed.

  • fileapi/File.h:

(File):

  • fileapi/File.idl:
  • platform/FileMetadata.h:

(WebCore::FileMetadata::FileMetadata):

  • platform/FileSystem.h:
  • platform/chromium/support/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

  • platform/network/BlobData.h:

(WebCore::BlobDataItem::doNotCheckFileChange): Removed.

  • platform/network/BlobData.cpp:
  • platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::advanceCurrentStream):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::blobIsOutOfDate):

4:44 AM Changeset in webkit [119820] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip passing sputnik tests
https://bugs.webkit.org/show_bug.cgi?id=88641

Unreviewed, unskip sputnik tests which are passing now.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-08

  • platform/efl/TestExpectations:
4:11 AM Changeset in webkit [119819] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, removing crash expectations for two plugins
tests that were fixed after LLInt was enabled for the Gtk port in r119593.

  • platform/gtk/TestExpectations:
4:02 AM Changeset in webkit [119818] by hans@chromium.org
  • 7 edits
    4 adds in trunk

Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=87976

Reviewed by Kent Tamura.

Tools:

Provide a mock implementation of WebSpeechRecognizer for
DumpRenderTree. This will allow better testing of the API via layout
tests.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::addMockSpeechRecognitionResult):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.

(MockWebSpeechRecognizer::create):
(MockWebSpeechRecognizer::start):
(MockWebSpeechRecognizer::stop):
(MockWebSpeechRecognizer::abort):
(MockWebSpeechRecognizer::MockWebSpeechRecognizer):
(MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
(MockWebSpeechRecognizer::ResultTask::runIfValid):

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.

(WebKit):
(MockWebSpeechRecognizer):
(MockWebSpeechRecognizer::addMockResult):
(MockWebSpeechRecognizer::taskList):
(ClientCallTask):
(MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
(ResultTask):
(MockWebSpeechRecognizer::ResultTask::ResultTask):
(NoMatchTask):
(MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::speechRecognizer):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):
(WebViewHost::mockSpeechRecognizer):

LayoutTests:

Add a layout test using the new mock, pushing a mock result through
and checking that events fire correctly.

  • fast/speech/scripted/speechrecognition-basics-expected.txt: Added.
  • fast/speech/scripted/speechrecognition-basics.html: Added.
3:59 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
3:41 AM Changeset in webkit [119817] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening after r119795, adding separate test expectations
for jquery/core.html - the test is crashing on debug builds and failing
with a text diff on release builds.

  • platform/gtk/TestExpectations:
2:53 AM Changeset in webkit [119816] by tkent@chromium.org
  • 15 edits
    2 adds in trunk/Source/WebCore

Move form-related functions of Document to FormController
https://bugs.webkit.org/show_bug.cgi?id=88497

Reviewed by Hajime Morita.

A lot of files depend on Document.h. We had to build many files when we
touched form-related features in Document.h or
CheckedRadioButtons.h. This patch reduces such pain.

No new tests. Just a refactoring.

  • CMakeLists.txt: Add FormController.cpp and/or FormController.h.
  • GNUmakefile.list.am: ditto.
  • Target.pri: ditto.
  • WebCore.gypi: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • dom/Document.cpp: Removed form-releated features except the followings.

(WebCore::Document::formController): Accessor for a FormController.
(WebCore::Document::formElementsState):
Just returns FormController::formElementsState().
We don't create new FormController.
(WebCore::Document::setStateForNewFormElements):
Just returns FormController::setStateForNewFormElements().
We don't create new FormController if the specified vector is empty.

  • dom/Document.h:

Moved form-related functions to FormController.

  • html/FormController.cpp: Added. Moved from Document.cpp.
  • html/FormController.h: Added. Moved from Document.h
  • html/FormAssociatedElement.cpp: Use Document::formController().

(WebCore::FormAssociatedElement::didMoveToNewDocument):
(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formAttributeChanged):

  • html/HTMLFormControlElementWithState.cpp: Use Document::formController().

(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):

  • html/HTMLFormElement.cpp: Use Document::formController().

(WebCore::HTMLFormElement::didNotifyDescendantInsertions):
(WebCore::HTMLFormElement::removedFrom):

  • html/HTMLInputElement.cpp: Use Document::formController().

(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::didMoveToNewDocument):
(WebCore::HTMLInputElement::checkedRadioButtons):

  • html/HTMLInputElement.h:

Declare CheckedRadioButtons. It was provided by Document.h.

  • html/parser/HTMLConstructionSite.h:

Declare HTMLFormElement. It was provided by Document.h

2:50 AM Changeset in webkit [119815] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk/Source

Add FileSystem item to storage tree.
https://bugs.webkit.org/show_bug.cgi?id=72691

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-08
Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/FileSystemModel.js: Added.
  • inspector/front-end/Images/fileSystem.png: Added.
  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FileSystemListTreeElement):
(WebInspector.FileSystemListTreeElement.prototype.onexpand):
(WebInspector.FileSystemListTreeElement.prototype.onattach):
(WebInspector.FileSystemListTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemAdded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemTreeElementByName):
(WebInspector.FileSystemListTreeElement.prototype._refreshFileSystem):
(WebInspector.FileSystemTreeElement):
(WebInspector.FileSystemTreeElement.prototype.get fileSystemName):
(WebInspector.FileSystemTreeElement.prototype.get itemURL):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/resourcesPanel.css:

(.file-system-storage-tree-item .icon):

  • inspector/front-end/utilities.js:

Source/WebKit/chromium:

  • src/js/DevTools.js:
2:19 AM Changeset in webkit [119814] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

REGRESSION r119802: Remove unnecessary ASSERT(!m_deletionHasBegun) from Document.h
https://bugs.webkit.org/show_bug.cgi?id=88528

Reviewed by Ryosuke Niwa.

m_deletionHasBegun should become true just before 'delete this'.

No tests. No change in behavior.

  • dom/Document.h:

(WebCore::Document::guardRef):
(WebCore::Document::guardDeref):

2:09 AM Changeset in webkit [119813] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Re-enable SHARED_WORKERS for Android until a build fix has been resolved.
https://bugs.webkit.org/show_bug.cgi?id=88637

Unreviewed build fix.

Linking content_shell on the Chromium side fails due to an unresolved
call to WebSharedWorker::create(). Since this blocks WebKit rolls,
temporarily re-enable the feature until this has been solved.

  • features.gypi:
1:29 AM Changeset in webkit [119812] by noel.gordon@gmail.com
  • 1 edit
    1 copy
    1 move in trunk/LayoutTests

[chromium] Run optimize-baselines over canvas-toDataURL-webp.html results

Unreviewed test expectations update.

  • platform/chromium-mac/fast/canvas/canvas-toDataURL-webp-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/canvas/canvas-toDataURL-webp-expected.png.
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/canvas/canvas-toDataURL-webp-expected.png.
1:14 AM Changeset in webkit [119811] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

HTTP 204 No Content responses shouldn't trigger MIME type warnings in the web inspector
https://bugs.webkit.org/show_bug.cgi?id=88603

Reviewed by Pavel Feldman.

A 204 response doesn't have an entity body, so its MIME type is kind of
meaningless. We shouldn't spam the console with a warning about MIME
types.

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):

1:01 AM Changeset in webkit [119810] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip tests using disabled SHADOW_DOM feature on Qt.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-08

  • platform/qt/Skipped:
12:51 AM Changeset in webkit [119809] by yosin@chromium.org
  • 11 edits in trunk/Source/WebCore

[Forms] Drop StepRange::NumberWithDecimalPlacesOrMissing
https://bugs.webkit.org/show_bug.cgi?id=88621

Reviewed by Kent Tamura.

This patch changes NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.
We use NaN as indication of having value or not.

No new tests, because this patch doesn't change behavior.

  • html/DateInputType.cpp:

(WebCore::DateInputType::createStepRange): Replace NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::createStepRange): ditto.

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::createStepRange): ditto.

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::createStepRange): ditto.

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::createStepRange): ditto.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createStepRange): ditto.

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange): Checks value is finite or not.
(WebCore::StepRange::parseStep): Replace NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.

  • html/StepRange.h:

(StepRange): Removed NumberWithDecimalPlacesOrMissing.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::createStepRange): NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::createStepRange): ditto.

12:45 AM Changeset in webkit [119808] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fixed a comment, pointed out by ap@.

  • platform/TreeShared.h:

(WebCore):

12:42 AM Changeset in webkit [119807] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium] WEBP image blue and red color channels reversed on Android
https://bugs.webkit.org/show_bug.cgi?id=88613

Reviewed by Kent Tamura.

No new tests. Covered by test fast/images/webp-image-decoding.html though I'm
not sure where/how the Androids run their layout tests.

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(outputMode): Detect little-endian Skia with a blue pixel shift (aka Android)
which seems to be the way for them per bug 75861.

12:29 AM Changeset in webkit [119806] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

[WebKit2] Move Mac-specific bits from config.h to WebKit2Prefix.h
https://bugs.webkit.org/show_bug.cgi?id=88625

Reviewed by Dan Bernstein.

Since the Mac supports prefix headers, there is no point in having
Mac-specific code in WebKit2's config.h. Move it to WebKit2Prefix.h.

  • WebKit2Prefix.h:
  • config.h:
12:27 AM Changeset in webkit [119805] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Fixed fast/files/read-blob-async.html failing after r119791.

  • fast/files/resources/read-blob-test-cases.js:

(testReadingSingleArrayBufferBlob):
(testReadingSlicedArrayBufferBlob):
(testReadingMultipleArrayBufferBlob):
(testReadingHybridBlob):
(testReadingSlicedHybridBlob):
(testReadingTripleSlicedHybridBlob):

12:22 AM Changeset in webkit [119804] by noel.gordon@gmail.com
  • 1 edit
    1 add in trunk/LayoutTests

[chromium] New virtual GPU canvas-toDataURL-webp.html results after r119787

Unreviewed test expectations update.

  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png: Added.
12:04 AM Changeset in webkit [119803] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove the assertion that has been moved to TreeScope after r119802.

  • dom/Document.cpp:

(WebCore::Document::removedLastRef):

Jun 7, 2012:

11:28 PM Changeset in webkit [119802] by haraken@chromium.org
  • 16 edits in trunk

Reduce Node object size from 72 byte to 64 byte
https://bugs.webkit.org/show_bug.cgi?id=88528

Reviewed by Ryosuke Niwa.

.:

Added a symbol for callRemovedLastRef().

  • Source/autotools/symbols.filter:

Source/WebCore:

This patch removes all virtual methods from TreeShared.h,
by which we can remove a virtual method table pointer (8 byte
in a 64bit architechture) from each Node object. Consequently,
this patch reduces the Node object size from 72 byte to 64 byte.

e.g. The HTML spec (http://www.whatwg.org/specs/web-apps/current-work/)
contains 325640 Node objects. Thus this patch saves 325640 * 8 byte = 2.6 MB.

e.g. sizeof(Element) is reduced from 104 byte to 96 byte.

  • In multiple inheritance, a virtual method table pointer is allocated

for each base class that has virtual methods. For example, for
'class A : public B, C {};' where B and C have virtual methods,
two virtual method table pointers are allocated for each A object.
In this patch, A = Node, B = EventTarget, and C = TreeShared.
By removing the virtual methods from TreeShared, we can save the virtual
method table pointer for TreeShared. 8 byte saving.

  • Node and SVGElementInstance are the only classes that inherit TreeShared.
  • This patch removes virtual TreeShared::removeLastRef() and implements

virtual Node::removeLastRef() and virtual SVGElementInstance::removeLastRef().
Node::removeLastRef() calls 'delete this' for 'this' of type Node*,
and SVGElementInstance::removeLastRef() calls 'delete this' for 'this' of type
SVGElementInstance*.

  • This patch removes the virtual destructor of TreeShared. This removal is safe

because (1) no one calls 'delete this' for 'this' of type TreeShared*,
and (2) both Node and SVGElementInstance have virtual destructor.

No change in behavior. Confirm no regression in existing tests.

  • dom/ContainerNode.cpp:

(WebCore::callRemovedLastRef):
(WebCore):

  • dom/Node.h:

(WebCore::Node::removedLastRef):

  • platform/TreeShared.h:

(WebCore):
(TreeShared):
(WebCore::TreeShared::deref):

  • svg/SVGElementInstance.cpp:

(WebCore::callRemovedLastRef):
(WebCore):

  • svg/SVGElementInstance.h:

(WebCore::SVGElementInstance::removedLastRef):

  • WebCore.order: Added a symbol for callRemovedLastRef().
  • WebCore.exp.in: Ditto.

Source/WebKit/mac:

Added a symbol for callRemovedLastRef().

  • WebKit.order:

Source/WebKit2:

Added a symbol for callRemovedLastRef().

  • mac/WebKit2.order:
  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
11:22 PM Changeset in webkit [119801] by noel.gordon@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

[chromium] Update canvas-toDataURL-webp.html results after r119787

Unreviewed test expectations update.

  • platform/chromium/TestExpectations:
  • platform/chromium-win/fast/canvas/canvas-toDataURL-webp-expected.png: Added.
10:48 PM Changeset in webkit [119800] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

[WebKit2] Explicitly include CoreFoundation.h in config.h
https://bugs.webkit.org/show_bug.cgi?id=88619

Reviewed by Dan Bernstein.

WebKit2 relies (probably unintentionally) on CoreFoundation.h being
included by CoreGraphics.h (via CGSession.h), but some versions of
CoreGraphics headers don't include CoreFoundation.h. WebKit2 should
include it explicitly in config.h.

  • config.h: Import CoreFoundation.h.
10:29 PM Changeset in webkit [119799] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

ShadowRoot needs resetStyleInheritance
https://bugs.webkit.org/show_bug.cgi?id=84048

Source/WebCore:

Added resetStyleInheritance API to ShadowRoot. The spec URL is
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-root-attributes
To implement the API, modified StyleResolver to use empty style
instead of parent style if resetStyleInheritance is true,
and a node and its parent node are placed in different shadow trees.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
Reviewed by Hajime Morita.

Test: fast/dom/shadow/shadow-root-resetStyleInheritance.html

fast/dom/shadow/shadow-root-resetStyleInheritance-expected.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::initForStyleResolve):
Set m_parentStyle to NULL when resetStyleInheritance.
(WebCore::StyleResolver::documentSettings):
Added a new method to obtain current document's settings.
(WebCore::StyleResolver::initializeFontStyle):
Initialize m_style by using document settings. Its code was move
from the code initializing font style in applyProperty.
(WebCore::StyleResolver::styleForElement):
Initialize font style if m_parentStyle is NULL. The old code just
used style() and don't touch font style. The new code uses the above
initializeFontStyle.
(WebCore::StyleResolver::applyProperty):
Moved a code for initializing font style as "initial" to
a new method: initializeFontStyle and modified to use the method.
Modified to use documentSettings().
(WebCore::StyleResolver::checkForGenericFamilyChange):
Modified to use documentSettings().

  • css/StyleResolver.h:

(WebCore::StyleResolver::documentSettings):
(WebCore::StyleResolver::initializeFontStyle):
Added two new methods to class StyleResolver.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
Modified to calculate m_resetStyleInheritance in its constructor.

  • dom/NodeRenderingContext.h:

(WebCore::NodeRenderingContext::resetStyleInheritance):
Implemented a new method, just returning m_resetStyleInheritance.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setResetStyleInheritance):
Modified to force to recalculate children's styles if
resetStyleInheritance is changed.

  • dom/ShadowRoot.h:

(ShadowRoot):
Added resetStyleInheritance getter and setter.

  • dom/ShadowRoot.idl:

Added an attribute, resetStyleInheritance.

  • dom/TreeScope.cpp:

(WebCore::TreeScope::resetStyleInheritance):

  • dom/TreeScope.h:

(TreeScope):
Added resetStyleInheritance's default getter.
The getter will be overrided by class ShadowRoot's getter.

LayoutTests:

Added layout tests for checking whether resetStyleInheritance works correctly or not.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
Reviewed by Hajime Morita.

  • fast/dom/shadow/shadow-root-resetStyleInheritance.html: Added.
  • fast/dom/shadow/shadow-root-resetStyleInheritance-expected.html: Added.
9:49 PM Changeset in webkit [119798] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

[WebKit2] Only include Cocoa.h on platforms that use AppKit
https://bugs.webkit.org/show_bug.cgi?id=88517

Reviewed by Sam Weinig.

  • WebKit2Prefix.h: Include Platform.h to get USE() macros. GTK needs to

include autotoolsconfig.h before including Platform.h, so do that first
if building on GTK. Then, if compiling an Objective-C file, it's safe
to include Foundation.h, but not necessarily Cocoa.h; only include the
latter if USE(APPKIT) is true.

  • config.h: There's no need to import Cocoa.h since this is already

imported in the prefix header.

9:27 PM Changeset in webkit [119797] by mrowe@apple.com
  • 4 edits in branches/safari-536-branch/Source

Versioning.

9:26 PM Changeset in webkit [119796] by mrowe@apple.com
  • 1 copy in tags/Safari-536.17

New tag.

9:25 PM Changeset in webkit [119795] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG should inline prototype chain accesses, and do the right things if the
specific function optimization is available
https://bugs.webkit.org/show_bug.cgi?id=88594

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-06-07
Reviewed by Gavin Barraclough.

Looks like a 3% win on V8.

  • bytecode/CodeBlock.h:

(JSC::Structure::prototypeForLookup):
(JSC):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::isSimple):
(JSC::GetByIdStatus::chain):
(JSC::GetByIdStatus::specificValue):
(GetByIdStatus):

  • bytecode/StructureSet.h:

(StructureSet):
(JSC::StructureSet::singletonStructure):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

  • jit/JITStubs.cpp:

(JSC::JITThunks::tryCacheGetByID):

  • runtime/JSGlobalObject.h:

(JSC::Structure::prototypeForLookup):
(JSC):

  • runtime/Structure.h:

(Structure):

9:24 PM Changeset in webkit [119794] by kinuko@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style needs to be taught about <public/Foo.h>
https://bugs.webkit.org/show_bug.cgi?id=88524

Reviewed by David Levin.

  • Scripts/webkitpy/style/checkers/cpp.py:

(_classify_include):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_public_primary_header):
(OrderOfIncludesTest.test_classify_include):

9:15 PM Changeset in webkit [119793] by kinuko@chromium.org
  • 3 edits in trunk/LayoutTests

Fix unmatched parenthesis in fast/dom/HTMLAnchorElement/anchor-download-unset.html
https://bugs.webkit.org/show_bug.cgi?id=88526

Reviewed by Alexey Proskuryakov.

This test is skipped on other platforms than chromium.

  • fast/dom/HTMLAnchorElement/anchor-download-unset.html:
  • platform/chromium/TestExpectations:
8:21 PM Changeset in webkit [119792] by commit-queue@webkit.org
  • 6 edits in trunk

addTextTrack should set track mode to HIDDEN
https://bugs.webkit.org/show_bug.cgi?id=88317

Patch by Victor Carbune <victor@rosedu.org> on 2012-06-07
Reviewed by Eric Carlson.

Source/WebCore:

Updated existing test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addTextTrack): Set the default parameters
for the newly created TextTrack.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):

LayoutTests:

  • media/track/track-texttracks-expected.txt: Updated.
  • media/track/track-texttracks.html: Updated.
8:15 PM Changeset in webkit [119791] by commit-queue@webkit.org
  • 15 edits in trunk

FileAPI: Blob should support ArrayBufferView instead of ArrayBuffer for Constructor Parameters
https://bugs.webkit.org/show_bug.cgi?id=88294

Patch by Li Yin <li.yin@intel.com> on 2012-06-07
Reviewed by Jian Li.

Source/WebCore:

From Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob
Currently we add the support for ArrayBufferView, while still keeping ArrayBuffer for
backward compatibility. We will remove it in the near future.

Test: fast/files/blob-constructor.html

  • bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::WebKitBlobBuilder::append):
(WebCore):

  • fileapi/WebKitBlobBuilder.h:

(WebCore):
(WebKitBlobBuilder):

  • fileapi/WebKitBlobBuilder.idl: Add support for ArrayBufferView in append method

LayoutTests:

Support ArrayBufferView in Blob constructing function.

  • fast/files/blob-constructor-expected.txt:
  • fast/files/file-reader-fffd-expected.txt:
  • fast/files/file-reader-fffd.html:
  • fast/files/script-tests/blob-constructor.js:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hybi/send-blob.html:
  • http/tests/websocket/tests/hybi/workers/resources/send-blob.js:

(createBlobContainingAllDistinctBytes):

8:13 PM Changeset in webkit [119790] by morrita@google.com
  • 3 edits
    2 adds in trunk

A style in an older shadow subtree causes assert when composing with <shadow>
https://bugs.webkit.org/show_bug.cgi?id=88299

Reviewed by Dimitri Glazkov.

Source/WebCore:

InsertionPoint::attach() assumes its distributed content not being attach()-ed.
But this assumption can break. This change added a guard for that.
This can happen for shadow boundaries in general. But ShadowRoot already handles that case.

Test: fast/dom/shadow/insertion-point-shadow-crash.html

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):

LayoutTests:

  • fast/dom/shadow/insertion-point-shadow-crash-expected.txt: Added.
  • fast/dom/shadow/insertion-point-shadow-crash.html: Added.
8:06 PM Changeset in webkit [119789] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Show correct fullscreen button image (media controls)
https://bugs.webkit.org/show_bug.cgi?id=88563

Patch by Max Feil <mfeil@rim.com> on 2012-06-07
Reviewed by Antonio Gomes.

PR159306: Show "exit" fullscreen button image instead of "enter"
fullscreen button image when in fullscreen mode (HTML5 media
controls).

I am not providing a test due to the simplicity of this patch
and the relative difficulty and maintainability issues associated
with testing how an image is rendered.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintMediaFullscreenButton):

7:59 PM Changeset in webkit [119788] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=67255

Patch by Joshua Lock <joshua.lock@intel.com> on 2012-06-07
Reviewed by Dirk Pranke.

Tools:

Implement pathToLocalResource to redirect file:///tmp URL's to
DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
LayoutTests sub-directory of the WebKit source tree.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::pathToLocalResource):

LayoutTests:

  • platform/efl/TestExpectations: unskip

fast/dom/frame-loading-via-document-write.html now that
LayoutTestController::pathToLocalResource() is implemented for EFL.

7:57 PM Changeset in webkit [119787] by noel.gordon@gmail.com
  • 6 edits
    2 adds in trunk

[chromium] Use WEBPImportPictureRGBX|BGRX to import picture data
https://bugs.webkit.org/show_bug.cgi?id=88218

Reviewed by Kent Tamura.

Source/WebCore:

Stop using the RGBA and RGBA variants of the picture import routines (since
these will import alpha channel data in a future libwebp). Use the RGBX and
BGRX variants to import picture data for encoding to make it clear that the
alpha channel is (and must be) ignored.

Test: fast/canvas/canvas-toDataURL-webp.html

  • platform/image-encoders/skia/WEBPImageEncoder.cpp:

(WebCore::rgbPictureImport):
(WebCore::importPictureBGRX): Use WEBPImportPictureBGRX for picture imports
that must ignore the alpha channel. Change the template parameter to be the
premultiplied alpha state of the input image data.
(WebCore::importPictureRGBX): Use WEBPImportPictureRGBX, ditto.
(WebCore::encodePixels): Invert the sense of the template parameter to make
it now indicate the premultiplied alpha state of the input image data.

LayoutTests:

The test image (html5.png) has an alpha 255 background. The background should
be rendered black when a <canvas>.toDataURL('image/webp') is used as an <img>
element src attribute for example, since WEBP does not support alpha.

  • fast/canvas/canvas-toDataURL-webp-expected.txt:
  • fast/canvas/canvas-toDataURL-webp.html: Change the test to encode the added

html5.png test image as an image/webp data url.

  • fast/canvas/resources/html5.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/canvas-toDataURL-webp-expected.png: Added.
  • platform/chromium/TestExpectations: Requires WIN, LINUX rebaselines.
7:51 PM Changeset in webkit [119786] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium/mac] Improve deviceDPI, rect, and availableRect computation
https://bugs.webkit.org/show_bug.cgi?id=88596

Reviewed by Adam Barth.

Set deviceDPI to 160 for normal displays and 320 for HiDPI displays.
(Why 160? That's what chromium's render_view.cc assumes as default
single-resolution resolution at the moment. The only other place
where this number gets used is fixed layout mode, which is currently
not enabled.)

Also fix rect and availableRect computations: They get returned in
user space already.

Needed for http://crbug.com/31960.

  • src/mac/WebScreenInfoFactory.mm:

(WebKit::toUserSpace):
(WebKit::deviceScaleFactor):
(WebKit):
(WebKit::WebScreenInfoFactory::screenInfo):

7:40 PM Changeset in webkit [119785] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[chromium] Allow LayoutTests under new git workflow
https://bugs.webkit.org/show_bug.cgi?id=88575

On Windows, chromium indirects through git.bat. Adds the same hack that
is currently used for discovering svn.bat to support the new git
workflow.

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-07
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git): Replaces all hard-coded references to 'git' with the class
variable executable_name.
(Git._check_git_architecture):
(Git.in_working_directory):
(Git.find_checkout_root):
(Git.read_git_config):
(Git.discard_local_commits):
(Git.local_commits):
(Git.working_directory_is_clean):
(Git.clean_working_directory):
(Git.status_command):
(Git.add_list):
(Git.delete_list):
(Git.exists):
(Git._current_branch):
(Git.changed_files):
(Git._changes_files_for_commit):
(Git.revisions_changing_file):
(Git.conflicted_files):
(Git.svn_revision):
(Git.create_patch):
(Git._run_git_svn_find_rev):
(Git.contents_at_revision):
(Git.diff_for_file):
(Git.show_head):
(Git.committer_email_for_revision):
(Git.apply_reverse_diff):
(Git.revert_files):
(Git.commit_with_message):
(Git._commit_on_branch):
(Git.svn_commit_log):
(Git.last_svn_commit_log):
(Git.svn_blame):
(Git._branch_ref_exists):
(Git.delete_branch):
(Git.remote_merge_base):
(Git.commit_locally_with_message):
(Git.push_local_commits_to_server):
(Git.commit_ids_from_commitish_arguments):
(Git.commit_message_for_local_commit):
(Git.files_changed_summary_for_commit):

  • Scripts/webkitpy/common/host.py:

(Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
that duplicates the logic in the existing 'svn.bat' hack.

7:19 PM Changeset in webkit [119784] by ojan@chromium.org
  • 2 edits in trunk/Tools

Style build architectures like build versions for non-layout test failures
https://bugs.webkit.org/show_bug.cgi?id=88590

Reviewed by Tony Chang.

Since we show the list of failing tests after the architecture, we want the
buildtype and architecture to be grouped together visually.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:

(.effects a.failing-builder>span.architecture):

7:18 PM Changeset in webkit [119783] by ojan@chromium.org
  • 175 edits
    34 deletes in trunk/LayoutTests

Last set of chromium rebaselines after r119748.
Also mark pointer-lock/pointerlockchange-pointerlockerror-events.html
as crashing in Chromium debug after r119763.

Excluding list of changed pngs because it's too long.

  • platform/chromium/TestExpectations:
7:06 PM Changeset in webkit [119782] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Improve the performance of pushScope in StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=88222

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
Reviewed by Hajime Morita.

As setupScopeStack always sets m_scopeStackParent to be NULL,
m_scopeStack is never reused. m_scopeStackParent should be the last
element of m_scopeStack.

No new tests, because fast/css/style-scoped/ uses pushScope,
popScope and setupScopeStack and checks whether there exists
any crash bug or not. And this patch doesn't change any behavior
of scoped author syltes.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::setupScopeStack):
Modified to set m_scopeSackParent to be the last element of
m_scopeStack.
(WebCore::StyleResolver::popScope):
Modified to remove the last element if m_scopeStack is not empty and
the last element of m_scopeStack has the same scope as the scoping
element given by the argument.

6:35 PM Changeset in webkit [119781] by wangxianzhu@chromium.org
  • 3 edits in trunk/Tools

[Chromium] Remove header dependency of ImageDiff to WTF
https://bugs.webkit.org/show_bug.cgi?id=88422

Reviewed by Ryosuke Niwa.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/ImageDiff.cpp:

(untestedCompareImages):

6:33 PM Changeset in webkit [119780] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
https://bugs.webkit.org/show_bug.cgi?id=88491

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-06-07
Reviewed by Dirk Pranke.

DRT should enable WebAudio when WebAudio feature is enabled,
so that the WebAudio feature could be tested by the Layouttest.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.

(LayoutTestController::overridePreference):

6:31 PM Changeset in webkit [119779] by fpizlo@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

DFG should inline prototype chain accesses, and do the right things if the
specific function optimization is available
https://bugs.webkit.org/show_bug.cgi?id=88594

Reviewed by Gavin Barraclough.

Looks like a 3% win on V8.

  • bytecode/CodeBlock.h:

(JSC::Structure::prototypeForLookup):
(JSC):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::isSimple):
(JSC::GetByIdStatus::chain):
(JSC::GetByIdStatus::specificValue):
(GetByIdStatus):

  • bytecode/StructureSet.h:

(StructureSet):
(JSC::StructureSet::singletonStructure):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):

  • jit/JITStubs.cpp:

(JSC::JITThunks::tryCacheGetByID):

  • runtime/JSGlobalObject.h:

(JSC::Structure::prototypeForLookup):
(JSC):

  • runtime/Structure.h:

(Structure):

6:21 PM Changeset in webkit [119778] by morrita@google.com
  • 5 edits
    2 copies in branches/chromium/1132

Merge 118711 - Can't edit <input> elements with :first-letter
https://bugs.webkit.org/show_bug.cgi?id=87615

Reviewed by Kent Tamura.

A check using canHaveGeneratedChildren() should cover not only
button and menulist, but also RenderTextControl.
This change pulles canHaveGeneratedChildren() up
from RenderDeprecatedFlexibleBox to RenderObject,
and lets RenderTextControl override it.

Test: fast/forms/input-first-letter-edit.html

  • rendering/RenderBlock.cpp:

(WebCore):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderBlock.h: Removed a static function canHaveGeneratedChildren()

(RenderBlock):

  • rendering/RenderDeprecatedFlexibleBox.h:
  • rendering/RenderObject.cpp:

(WebCore):
(WebCore::RenderObject::canHaveGeneratedChildren): Added.

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderTextControl.h:

TBR=morrita@google.com
Review URL: https://chromiumcodereview.appspot.com/10538049

5:48 PM Changeset in webkit [119777] by pilgrim@chromium.org
  • 7 edits in trunk/Source

[Chromium] Move didStartWorkerRunLoop to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=88562

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::~WorkerScriptController):

  • platform/chromium/PlatformSupport.h:

(WebCore):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

5:36 PM Changeset in webkit [119776] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Dropping m_startingLineNumber property from StyledElement.
https://bugs.webkit.org/show_bug.cgi?id=86848

Patch by Mike West <mkwst@chromium.org> on 2012-06-07
Reviewed by Adam Barth.

We can have the same effect by moving the line-number calculation
directly into StyledElement::styleAttributeChanged. This means that
subsequent changes to the style attribute (via script) won't generate
error messages with line numbers, but that's an acceptable tradeoff.

Behavior is covered by existing CSP tests.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::StyledElement):
(WebCore::StyledElement::styleAttributeChanged):

  • dom/StyledElement.h:

(WebCore::StyledElement::destroyInlineStyle):

5:29 PM Changeset in webkit [119775] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Math.pow on iOS does not support denormal numbers.
https://bugs.webkit.org/show_bug.cgi?id=88592

Reviewed by Filip Pizlo.

Import an implementation from fdlibm, detect cases where it is safe to use the system
implementation & where we should fall back to fdlibm.

  • runtime/MathObject.cpp:

(JSC::isDenormal):
(JSC::isEdgeCase):
(JSC::mathPow):

  • On iOS, detect cases where denormal support may be required & use fdlibm in these cases.

(JSC::mathProtoFuncPow):

  • Changed to use mathPow.

(JSC::fdlibmScalbn):
(JSC::fdlibmPow):

  • These functions imported from fdlibm; original style retained to ease future merging.
5:00 PM Changeset in webkit [119774] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Should Use the WebPage Already Created by Client, No Need to Create New One.
https://bugs.webkit.org/show_bug.cgi?id=88576

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-07
Reviewed by Rob Buis.

When PagePopupBlackBerry::init() is called, a WebPage is already created, we can just use
this to load popup, no need to create a new one. The old code is based on an old solution
which has been abandoned.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::openPagePopup):

  • WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::PagePopupBlackBerry::init):
(WebCore::setValueAndClosePopupCallback):
(WebCore::PagePopupBlackBerry::handleMouseEvent):
(WebCore::PagePopupBlackBerry::closePopup):

  • WebCoreSupport/PagePopupBlackBerry.h:

(PagePopupBlackBerry):

4:59 PM Changeset in webkit [119773] by peter@chromium.org
  • 2 edits in trunk/Source/WebCore

Initialize m_document in AXObjectCache's constructor for !HAVE(ACCESSIBILITY) builds
https://bugs.webkit.org/show_bug.cgi?id=88527

Reviewed by Adam Barth.

Initialize the m_document member with the passed on document in the stubbed
AXObjectCache constructor. No behavioral changes.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::AXObjectCache):

4:46 PM Changeset in webkit [119772] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Mark fast/table/multiple-captions-display.xhtml as flaky on Chromium.

  • platform/chromium/TestExpectations:
4:44 PM Changeset in webkit [119771] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Get rid of unused maximumLayoutSize in WebPage
https://bugs.webkit.org/show_bug.cgi?id=88574

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 164098
maximumLayoutSize was deprecated when we made use of
WebCore::computeViewportAttributes for
WebPagePrivate::recomputeVirtualViewportFromViewportArguments.
So clean it up.

  • Api/WebPage.cpp:

(WebKit):

4:36 PM Changeset in webkit [119770] by ojan@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Chromium rebaselines after http://trac.webkit.org/changeset/119760.

  • platform/chromium-linux/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-valid-border-clipping-expected.png:
  • platform/chromium-win/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
4:35 PM Changeset in webkit [119769] by jamesr@google.com
  • 11 edits
    3 adds
    3 deletes in trunk/Source

[chromium] Move deferral-related logic out of Canvas2DLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=86050

Reviewed by Stephen White.

Source/WebCore:

This removes Canvas2DLayerChromium and puts the deferral and double-buffering related logic in a new class,
Canvas2DLayerBridge, that uses TextureLayerChromium for compositing. The bridge is responsible for managing the
front texture when double buffering is active, inserting the correct makeContextCurrent() and flush() calls on
the GraphicsContext3D and SkCanvas when appropriate, and owning the lifetime of the layer.

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerBridge.cpp: Added.

(WebCore):
(AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::skCanvas):
(WebCore::Canvas2DLayerBridge::prepareTexture):
(WebCore::Canvas2DLayerBridge::context):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):

  • platform/graphics/chromium/Canvas2DLayerBridge.h: Added.

(WebCore):
(Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::create):

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: Removed.
  • platform/graphics/chromium/Canvas2DLayerChromium.h: Removed.
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:
  • platform/graphics/chromium/ImageBufferDataSkia.h:

(WebCore):
(ImageBufferData):

  • platform/graphics/chromium/TextureLayerChromium.cpp:

(WebCore::TextureLayerChromium::willModifyTexture):

willModifyTexture() is called whenever the texture currently owned by the TextureLayerChromium will be
modified by a system out of the compositor's control. It makes sure that the compositor does not attempt to
draw with the potentially-modified texture until the next commit. For canvas, this is used when threading is
enabled and a non-deferrable drawing command is invoked from JS.

(WebCore):

  • platform/graphics/chromium/TextureLayerChromium.h:

(TextureLayerChromium):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::context):
(WebCore::ImageBuffer::platformLayer):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/Canvas2DLayerBridgeTest.cpp: Renamed from tests/Canvas2DLayerChromiumTest

(Canvas2DLayerBridgeTest):
(Canvas2DLayerBridgeTest::fullLifecycleTest):

4:24 PM Changeset in webkit [119768] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r119441.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

4:18 PM Changeset in webkit [119767] by Patrick Gansterer
  • 2 edits in trunk

Build fix for WinCE after r113570.

  • Source/cmake/OptionsWinCE.cmake:
4:10 PM Changeset in webkit [119766] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
https://bugs.webkit.org/show_bug.cgi?id=88581

Reviewed by Ojan Vafai.

webkit-paptch rebaseline-expectations was ignoring what the
expected results for a test were and pulling down all the result
files from a bot. This could lead to us pulling down old,
incorrect .txt or .png files. With this patch we will now only
pull down expectations of the appropriate file types (so an
IMAGE failure will only pull the png and not the txt file).

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(has_pixel_failures):
(suffixes_for_expectations):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(FunctionsTest.test_suffixes_for_expectations):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand.init):
(RebaselineExpectations._is_supported_port):
(RebaselineExpectations._update_expectations_file):
(RebaselineExpectations._tests_to_rebaseline):
(RebaselineExpectations._rebaseline_port):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_overrides_are_included_correctly):

4:07 PM Changeset in webkit [119765] by Patrick Gansterer
  • 4 edits in trunk/Source/WebCore

Remove HAVE(PATH_BASED_BORDER_RADIUS_DRAWING)
https://bugs.webkit.org/show_bug.cgi?id=87931

Reviewed by Beth Dakin.

r62035 added HAVE(PATH_BASED_BORDER_RADIUS_DRAWING) until all ports implement
GraphicsContext::clipConvexPolygon(). All major ports define HAVE_PATH_BASED_BORDER_RADIUS_DRAWING in the
meantime and the alternative path has unnecessary maintainace costs and even don't compile at the moment.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::drawBoxSideFromPath):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::paintFocusRing):

  • rendering/RenderObject.h:

(RenderObject):

3:44 PM Changeset in webkit [119764] by tony@chromium.org
  • 499 edits
    1 move
    2 adds
    14 deletes in trunk/LayoutTests

[chromium] Unreviewed, new baselines for chromium-win after fixing
scrollbar rendering in r119748.

List of files omitted since it's long.

3:40 PM Changeset in webkit [119763] by scheib@chromium.org
  • 13 edits
    2 adds in trunk

Add new Pointer Lock spec events webkitpointerlockchange and webkitpointerlockerror
https://bugs.webkit.org/show_bug.cgi?id=88377

Reviewed by Dimitri Glazkov.

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402

New change and error events added. Follow up patches will remove
the previous callbacks and pointerlocklost event. Tests updated
to include the new events, and a new test added specifically for
the new events, pointerlockchange-pointerlockerror-events.html.

Source/WebCore:

Test: pointer-lock/pointerlockchange-pointerlockerror-events.html

  • dom/Document.h:

(Document):

  • dom/Document.idl:
  • dom/EventNames.h:

(WebCore):

  • page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::didAcquirePointerLock):
(WebCore::PointerLockController::didNotAcquirePointerLock):
(WebCore::PointerLockController::didLosePointerLock):
(WebCore::PointerLockController::enqueueEvent):
(WebCore):

  • page/PointerLockController.h:

(PointerLockController):

LayoutTests:

  • pointer-lock/lock-already-locked-expected.txt:
  • pointer-lock/lock-already-locked.html:
  • pointer-lock/pointer-lock-api-expected.txt:
  • pointer-lock/pointer-lock-api.html:
  • pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt: Added.
  • pointer-lock/pointerlockchange-pointerlockerror-events.html: Added.
  • pointer-lock/pointerlocklost-event-expected.txt:
  • pointer-lock/pointerlocklost-event.html:
3:37 PM Changeset in webkit [119762] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r119744.
http://trac.webkit.org/changeset/119744
https://bugs.webkit.org/show_bug.cgi?id=88584

Fails assertions in debug builds (Requested by jamesr_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07

Source/WebCore:

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:

(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
3:27 PM Changeset in webkit [119761] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Cache RenderLayer::isRootLayer for better performance
https://bugs.webkit.org/show_bug.cgi?id=88570

Reviewed by Ojan Vafai.

Caching covered by existing tests.

RenderLayer::isRootLayer()'s answer will be the same during the RenderLayer's
lifetime as a RenderLayer is tied to a RenderBoxModelObject. This change caches
isRootLayer value in the constructor.

On http://dglazkov.github.com/performance-tests/biggrid.html with a 100,000 rows
by 100 columns table, it saves about 10% on the paint time during scrolling on
my machine (going from 50ms to 45ms). It would expect all code paths to see some
improvement as checking renderer()->isRenderView() was pretty common.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
Added code to cache the result of renderer()->isRenderView() here.

(WebCore::RenderLayer::stackingContext):
(WebCore::isPositionedContainer):
(WebCore::isFixedPositionedContainer):
(WebCore::RenderLayer::enclosingTransformedAncestor):
(WebCore::RenderLayer::clippingRootForPainting):
(WebCore::shouldSuppressPaintingLayer):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::intersectsDamageRect):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::isStackingContext):
Updated all the call sites to use isRootLayer() instead of renderer()->isRenderView()
as it is faster.

(WebCore::RenderLayer::isRootLayer):
Added our caching here. Also made m_canSkipRepaintRectsUpdateOnScroll to follow
m_isRootLayer example.

3:12 PM Changeset in webkit [119760] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Incorrect border rendering when border radius is above 2px.
https://bugs.webkit.org/show_bug.cgi?id=88046

Source/WebCore:

Fixing findInnerVertex's logic to decide which is the better line
to find an inner vertex, x=center point's x of a rendering box or
y=center point's y of a rendering box.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
Reviewed by Simon Fraser.

Test: fast/borders/border-radius-valid-border-clipping.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::findInnerVertex):

LayoutTests:

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
Reviewed by Simon Fraser.

  • fast/borders/border-radius-valid-border-clipping-expected.txt: Added.
  • fast/borders/border-radius-valid-border-clipping.html: Added.
  • platform/chromium-mac/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
3:08 PM Changeset in webkit [119759] by commit-queue@webkit.org
  • 6 edits
    6 adds in trunk

Source/WebCore: Should fire error event for empty 404 script
https://bugs.webkit.org/show_bug.cgi?id=50589

Patch by Edaena Salinas Jasso <edaena@apple.com> on 2012-06-07
Reviewed by Brady Eidson.

Tests:
http/tests/loading/fire-error-event-empty-404-script.html
http/tests/loading/fire-error-script-no-content-type.html

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): We should check for http status
codes here to stop depending on the response being non-empty.
(WebCore::SubresourceLoader::didReceiveData): Moved the http status check but
avoid messing with multipart responses.
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError): Renamed from
errorLoadingResource for clarity.

  • loader/SubresourceLoader.h:
  • loader/cf/SubresourceLoaderCF.cpp:

(WebCore::SubresourceLoader::didReceiveDataArray):
Updated for errorLoadingResource renaming.

LayoutTests: Should fire error event for empty 404 script
https://bugs.webkit.org/show_bug.cgi?id=50589

Patch by Edaena Salinas Jasso <edaena@apple.com> on 2012-06-07
Reviewed by Brady Eidson.

Based on a test by Ojan Vafai.

  • http/tests/loading/fire-error-event-empty-404-script-expected.txt: Added.
  • http/tests/loading/fire-error-event-empty-404-script.html: Added.
  • http/tests/loading/fire-error-event-script-no-content-type-expected.txt: Added.
  • http/tests/loading/fire-error-event-script-no-content-type.html: Added.
  • http/tests/loading/resources/404-with-empty-body-no-content-type.cgi: Added.
  • http/tests/loading/resources/404-with-empty-body.cgi: Added.
  • http/tests/resources/network-simulator.php: Fixed to no longer return 404 error

when logging a request.

3:08 PM Changeset in webkit [119758] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Search highlight does not scroll with the content of the page, and find overlay doesn't work, on large-enough window
https://bugs.webkit.org/show_bug.cgi?id=88577
<rdar://problem/11430118>

Reviewed by John Sullivan.

Prevent the page overlay layer from falling into tiled mode.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

3:01 PM Changeset in webkit [119757] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Qt DRT should load external resources - cleanup
https://bugs.webkit.org/show_bug.cgi?id=88568

Make things more straighforward to load external URLs in DRT.

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

2:55 PM Changeset in webkit [119756] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

fast/js/dfg-double-vote-fuzz.html fails on Chromium release.

  • platform/chromium/TestExpectations:
2:35 PM Changeset in webkit [119755] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Update PlayBook's User Agent String for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=88543

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-07
Reviewed by Antonio Gomes.

We expect users to upgrade their devices so developers only need the latest UA String.

No tests needed.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

2:32 PM Changeset in webkit [119754] by ojan@chromium.org
  • 3 edits in trunk/Tools

Fix recent null pointer error regression in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=88573

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/builders.js:

(requestBuilderList):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2:32 PM Changeset in webkit [119753] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Remove obsolete FIXME comment about a layer sorting bug.
https://bugs.webkit.org/show_bug.cgi?id=88546

Reviewed by James Robinson.

No tests needed, only comment changed. The comment referred to a
potential bug that actually will not occur. The W3C spec on CSS 3d
transforms indicates that layers that do not share the same "3d
rendering context" do not sort together, and our existing code
sorts this way already.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::subtreeShouldRenderToSeparateSurface):

2:21 PM Changeset in webkit [119752] by abarth@webkit.org
  • 16 edits in trunk

Settings::defaultDeviceScaleFactor is redundant with Page::deviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=88375

Reviewed by James Robinson.

.:

This symbol no longer exists.

  • Source/autotools/symbols.filter:

Source/WebCore:

This patch removes Settings::defaultDeviceScaleFactor because it is
redundant with Page::deviceScaleFactor now that we no longer support
target-densitydpi. Page::deviceScaleFactor is the canonical place to
store the device scale factor.

  • WebCore.exp.in:
  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore):

  • page/Settings.h:

(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setDeviceScaleFactor):

Source/WebKit/chromium:

  • public/WebSettings.h:

(WebKit::WebSettings::setDefaultDeviceScaleFactor):
(WebSettings):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • src/WebSettingsImpl.cpp:

(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):

2:11 PM Changeset in webkit [119751] by commit-queue@webkit.org
  • 35 edits in trunk

IndexedDB: Error codes, phase one
https://bugs.webkit.org/show_bug.cgi?id=88459

Patch by Alec Flett <alecflett@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

Source/WebCore:

This phase gets rid of the now-deprecated NOT_ALLOWED_ERR and
NON_TRANSIENT_ERR from earlier versions of the spec, and
normalizes the place where TypeError should be thrown so that it's
easier to update when the bindings change.

No new tests: existing tests cover these changes and have been updated.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::deleteFunction):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersion):

  • Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore):

  • Modules/indexeddb/IDBDatabaseException.h:
  • Modules/indexeddb/IDBDatabaseException.idl:
  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):
(WebCore::IDBFactory::deleteDatabase):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::index):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::result):
(WebCore::IDBRequest::errorCode):
(WebCore::IDBRequest::webkitErrorMessage):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):

LayoutTests:

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics-shared-workers-expected.txt:
  • storage/indexeddb/basics-workers-expected.txt:
  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/cursor-advance-expected.txt:
  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/deleteIndex-expected.txt:
  • storage/indexeddb/resources/basics.js:

(test):

  • storage/indexeddb/resources/create-and-remove-object-store.js:

(testCreateAndRemove):
(tryOnceMore):

  • storage/indexeddb/resources/cursor-advance.js:

(testBadAdvance.advanceBadly):
(testBadAdvance):

  • storage/indexeddb/resources/cursor-update.js:

(keyCursor):

  • storage/indexeddb/resources/database-basics.js:

(testClose):

  • storage/indexeddb/resources/deleteIndex.js:

(postTwiddling):

  • storage/indexeddb/resources/transaction-after-close.js:

(firstTransactionComplete):

  • storage/indexeddb/resources/transaction-and-objectstore-calls.js:

(afterComplete):

  • storage/indexeddb/resources/transaction-basics.js:

(testInvalidMode):

  • storage/indexeddb/transaction-after-close-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-basics-expected.txt:
1:08 PM Changeset in webkit [119750] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add Konrad Piascik to committers.py
https://bugs.webkit.org/show_bug.cgi?id=88560

Unreviewed.

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-07

  • Scripts/webkitpy/common/config/committers.py:
1:07 PM Changeset in webkit [119749] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] features.gypi should have the correct definitions for Android
https://bugs.webkit.org/show_bug.cgi?id=88533

Reviewed by Adam Barth.

Make all features which are enabled on Android but disabled on other platforms,
or are disabled on Android while enabled on other platforms, conditional. This
also means that the selection of code compiled for Android will slightly change.

This change also removes the enable_viewport variable as the value of this is
no longer respected by WebKit - it's enabled by default for all of Chromium.
Furthermore, ENABLE_OVERFLOW_SCROLLING is now listed in features.gypi again.

  • features.gypi:
1:06 PM Changeset in webkit [119748] by tony@chromium.org
  • 2 edits in trunk/Tools

[chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
https://bugs.webkit.org/show_bug.cgi?id=77368

Reviewed by Ojan Vafai.

It doesn't look like we ever get a rect with width or height of 0.
I ran css1, css2.1, fast/forms, and tables without any crashes.

  • DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:

(webRectToSkIRect): Correctly convert a WebRect to a SkIRect.

12:44 PM Changeset in webkit [119747] by dpranke@chromium.org
  • 3 edits in trunk/Tools

run-webkit-tests --lint-test-files gives an error when run on linux
https://bugs.webkit.org/show_bug.cgi?id=88551

Reviewed by Ojan Vafai.

We weren't mapping the expectations properly for the
google-chrome ports.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.path_to_test_expectations_file):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(TestGoogleChromePort.test_path_to_expectations):

12:27 PM Changeset in webkit [119746] by epoger@chromium.org
  • 443 edits
    147 copies
    88 deletes in trunk/LayoutTests

Unreviewed, rolling out r119737.
http://trac.webkit.org/changeset/119737

see https://bugs.webkit.org/show_bug.cgi?id=88561

  • css1/basic/class_as_selector-expected.txt: Removed.
  • css1/basic/containment-expected.txt: Removed.

...

  • platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt: Copied from LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt.
  • platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt: Copied from LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt.
12:16 PM Changeset in webkit [119745] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Hopefully final chromium rebaseline for r119617.

  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
12:07 PM Changeset in webkit [119744] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
https://bugs.webkit.org/show_bug.cgi?id=88371

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.layersFreeTextures

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:

(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
11:46 AM Changeset in webkit [119743] by peter@chromium.org
  • 3 edits in trunk/Source/WebCore

Buildfix for ENABLE_OVERFLOW_SCROLLING=0 (though defined)
https://bugs.webkit.org/show_bug.cgi?id=88564

Reviewed by Adam Barth.

Where ENABLE(X) mandates that X both has to be defined and evaluates to
true as a lone preprocessor statement, there were two places in the CSS
property and value input files where only was checked whether is has
been defined. This also goes against other #ifdefs in those files.

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
11:37 AM Changeset in webkit [119742] by fischman@chromium.org
  • 19 edits
    3 adds in trunk

Plumb CORS attribute information from HTMLMediaElement to media players so it can be used
https://bugs.webkit.org/show_bug.cgi?id=88349

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/video-cross-origin-readback.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerCORSMode):
(WebCore):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::didPassCORSAccessCheck):
(WebCore):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerCORSMode):
(MediaPlayer):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::didPassCORSAccessCheck):
(MediaPlayerPrivateInterface):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):

  • src/AssertMatchingEnums.cpp:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::didPassCORSAccessCheck):
(WebKit):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

  • http/tests/security/resources/video-cross-origin-allow.php: Added.
  • http/tests/security/video-cross-origin-readback-expected.txt: Added.
  • http/tests/security/video-cross-origin-readback.html: Added.
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:
11:32 AM Changeset in webkit [119741] by senorblanco@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

Unreviewed; chromium test_expectations update.

Removing expected-to-fail results for now-passing tests.

  • platform/chromium-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Removed.
  • platform/chromium-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Removed.
  • platform/chromium-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Removed.
  • platform/chromium-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Removed.
11:31 AM Changeset in webkit [119740] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/WebCore

Worker tear-down can re-enter JSC during GC finalization
https://bugs.webkit.org/show_bug.cgi?id=88449

Reviewed by Geoffrey Garen.

No new tests.

This is the first of two patches to fix this issue with Workers.

  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::~AbstractWorker): We don't need to call onDestroyWorker() here, it
will be called elsewhere in contextDestroyed().

11:18 AM Changeset in webkit [119739] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

sometimes all slaved videos don't start playing
https://bugs.webkit.org/show_bug.cgi?id=88553

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-controller-time-clamp.html

Some PlatformClock classes will occasionally return times < 0 and will
always return times slightly > duration() when playback has ended. Clamp
the value of currentTime() to the specified [0..duration] range.

  • html/MediaController.cpp:

(MediaController::currentTime):

LayoutTests:

  • media/media-controller-time-clamp-expected.txt: Added.
  • media/media-controller-time-clamp.html: Added.
11:02 AM Changeset in webkit [119738] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Mark another test as slow on Chromium Windows.

  • platform/chromium/TestExpectations:
10:58 AM Changeset in webkit [119737] by epoger@chromium.org
  • 443 edits
    88 adds
    147 deletes in trunk/LayoutTests

Part 1 of rebaselines for http://crbug.com/131189

Unreviewed rebaselining.

  • css1/basic/class_as_selector-expected.txt: Added.
  • css1/basic/containment-expected.txt: Added.

...

  • platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt: Removed.
10:57 AM Changeset in webkit [119736] by Simon Fraser
  • 9 edits in trunk/Source/WebCore

Optimize FrameView::scrollXForFixedPosition() / scrollYForFixedPosition()
https://bugs.webkit.org/show_bug.cgi?id=88475

Reviewed by Sam Weinig.

FrameView's scrollXForFixedPosition() and scrollYForFixedPosition()
methods were often called together, but they do duplicate work,
including calling into platform widget code which might be slow.

Fix by converting scrollOffsetForFixedPosition() from being a wrapper
that just calls scrollXForFixedPosition() and scrollYForFixedPosition()
to the method that does all the work, calling just once into platform
widget code.

Changed callers to use scrollOffsetForFixedPosition() rather than make
two separate method calls.

Added ScrollView::layoutSize() and visibleSize() methods for
convenience.

Removed FrameView::scrollXForFixedPosition and FrameView::scrollYForFixedPosition
to avoid inefficient callers in future.

No new tests; refactoring only.

  • page/FrameView.cpp:

(WebCore::fixedPositionScrollOffset):
(WebCore::FrameView::scrollOffsetForFixedPosition):

  • page/FrameView.h: Removed scrollXForFixedPosition and scrollYForFixedPosition.
  • platform/ScrollView.cpp:

(WebCore::ScrollView::layoutSize):

  • platform/ScrollView.h:

(WebCore::ScrollView::visibleSize):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundClipRect):

  • rendering/RenderLayer.h:

(WebCore::ClipRect::move):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

  • rendering/RenderView.cpp:

(WebCore::RenderView::computeRectForRepaint):

10:44 AM Changeset in webkit [119735] by reed@google.com
  • 2 edits in trunk/LayoutTests

clean up suppressions around two-point-radial-gradient in skia (fix will come later)
https://bugs.webkit.org/show_bug.cgi?id=88549

Expectations change only.

  • platform/chromium/TestExpectations:
10:37 AM Changeset in webkit [119734] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Update some flaky/slow expectations to better match the bots.

  • platform/chromium/TestExpectations:
10:02 AM Changeset in webkit [119733] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Incorrect rect-based hit-test result for culled-inline elements
https://bugs.webkit.org/show_bug.cgi?id=85849

Patch by Raymes Khoury <raymes@chromium.org> on 2012-06-07
Reviewed by Levi Weintraub.

Source/WebCore:

Modified code which blindly adds culled inlines to rect-based hit-test
results so that it only does so if the child node does not fully cover
the hit-test region.

Test: fast/dom/nodesFromRect-culled-inline.html

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::addNodeToRectBasedTestResult):

LayoutTests:

Added tests for rect-based hit-testing for the case when the child of a
culled inline element is in the hit-test result. One of these tests is
expected to fail due to https://bugs.webkit.org/show_bug.cgi?id=88376.

  • fast/dom/nodesFromRect-culled-inline-expected.txt: Added.
  • fast/dom/nodesFromRect-culled-inline.html: Added.
9:58 AM Changeset in webkit [119732] by commit-queue@webkit.org
  • 18 edits
    3 adds in trunk

Source/WebCore: Make Skia backend honor requests for subpixel-positioned text.
https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

Add subpixel positioning field to FontRenderStyle and rename
subpixel rendering field.

Pass setting to SkPaint in FontPlatformDataHarfBuzz and remove
round() call when computing glyph widths in SimpleFontDataSkia.

Test: platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html

  • platform/graphics/blackberry/skia/PlatformSupport.cpp:

(WebCore::setFontRenderStyleDefaults):
(WebCore::PlatformSupport::getRenderStyleForStrike):

  • platform/graphics/chromium/FontRenderStyle.h:

(WebCore::FontRenderStyle::FontRenderStyle):
(WebCore::FontRenderStyle::operator==):
(FontRenderStyle):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore):
(WebCore::FontPlatformData::setSubpixelRendering):
(WebCore::FontPlatformData::setSubpixelPositioning):
(WebCore::FontPlatformData::setupPaint):
(WebCore::FontPlatformData::querySystemForRenderStyle):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformWidthForGlyph):

Source/WebKit/chromium: Add setting to enable subpixel-positioned text on Linux.
https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

Add subpixel positioning field to WebFontRenderStyle and rename
subpixel rendering field. Make similar changes in
WebFontRendering.

Also add global WebFontInfo::setSubpixelPositioning() to turn
subpixel positioning on or off (there's not currently a
well-defined way to configure subpixel positioning via FontConfig).

  • public/linux/WebFontInfo.h:

(WebFontInfo):

  • public/linux/WebFontRenderStyle.h:
  • public/linux/WebFontRendering.h:

(WebFontRendering):

  • src/linux/WebFontInfo.cpp:

(WebKit):
(WebKit::WebFontInfo::setSubpixelPositioning):
(WebKit::WebFontInfo::renderStyleForStrike):

  • src/linux/WebFontRenderStyle.cpp:

(WebKit::WebFontRenderStyle::toFontRenderStyle):
(WebKit::WebFontRenderStyle::setDefaults):

  • src/linux/WebFontRendering.cpp:

(WebKit::WebFontRendering::setSubpixelGlyphs):
(WebKit):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):

Tools: [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/chromium/fonts.conf:

LayoutTests: [chromium] Add test for subpixel positioning.
https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

  • platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning-expected.png: Added.
  • platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning-expected.txt: Added.
  • platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html: Added.
9:53 AM Changeset in webkit [119731] by commit-queue@webkit.org
  • 2 edits
    9 adds in trunk/LayoutTests

[GTK] Add baselines for new tests
https://bugs.webkit.org/show_bug.cgi?id=88540

Unreviewed gardening. Added baselines for new tests.

Patch by Simon Pena <Simon Pena> on 2012-06-07

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/gtk/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/gtk/fast/reflections/reflection-with-zoom-expected.png: Added.
  • platform/gtk/fast/reflections/reflection-with-zoom-expected.txt: Added.
  • platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
  • platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Added.
  • platform/gtk/svg/repaint/text-mask-update-expected.png: Added.
  • platform/gtk/svg/repaint/text-mask-update-expected.txt: Added.
9:50 AM Changeset in webkit [119730] by beidson@apple.com
  • 5 edits
    3 moves in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=88481

Move new test added by r119644 that was only meant for platform/mac into the platform/mac directory:

  • platform/mac/fast/loader/resources/utf8-encoded.webarchive: Renamed from LayoutTests/fast/loader/resources/utf8-encoded.webarchive.
  • platform/mac/fast/loader/webarchive-encoding-respected-expected.txt: Renamed from LayoutTests/fast/loader/webarchive-encoding-respected-expected.txt.
  • platform/mac/fast/loader/webarchive-encoding-respected.html: Renamed from LayoutTests/fast/loader/webarchive-encoding-respected.html.

Also remove it from the TestExpectations files for platforms where it was Skipped:

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
9:05 AM Changeset in webkit [119729] by wingo@igalia.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r119593.

  • llint/LLIntOfflineAsmConfig.h (OFFLINE_ASM_GLOBAL_LABEL): Fix

uses of "name" to be "label", the macro's parameter. Otherwise we
serialize mentions of the literal symbol "name" into the objcode.
Causes a build error using GNU ld (not gold).

9:03 AM Changeset in webkit [119728] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r119707.
http://trac.webkit.org/changeset/119707
https://bugs.webkit.org/show_bug.cgi?id=88539

Because the original patch with the failing test was rolled
out by 119712 (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07

  • platform/qt/Skipped:
8:31 AM Changeset in webkit [119727] by senorblanco@chromium.org
  • 18 edits
    1 delete in trunk/LayoutTests

[Chromium] Rebaseline tests after r119591 that enabled imageSmoothingEnabled for patterns
https://bugs.webkit.org/show_bug.cgi?id=88253

Unreviewed; test expectations update.

  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-linux/svg/custom/pattern-skew-transformed-expected.png: Removed.
  • platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-mac/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
  • platform/chromium-mac/svg/custom/oversized-pattern-scale-expected.png:
  • platform/chromium-mac/svg/custom/pattern-in-defs-expected.png:
  • platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png:
  • platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-win/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
  • platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png:
  • platform/chromium-win/svg/custom/pattern-in-defs-expected.png:
  • platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
  • platform/chromium/TestExpectations:
8:24 AM Changeset in webkit [119726] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] deviceScaleFactor setting is not honored
https://bugs.webkit.org/show_bug.cgi?id=88511

Patch by Simon Pena <Simon Pena> on 2012-06-07
Reviewed by Gustavo Noronha Silva.

Honor the deviceScaleFactor property in the paintWebView
method of the ChromeClientGtk.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::paintWebView):

8:09 AM Changeset in webkit [119725] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called
https://bugs.webkit.org/show_bug.cgi?id=88469

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.didDrawNotCalledOnScissoredLayer

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::shouldDrawLayer):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
7:54 AM Changeset in webkit [119724] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Unskip passing tests for GTK.

  • platform/gtk/TestExpectations:
7:46 AM Changeset in webkit [119723] by ahf@0x90.dk
  • 1 edit
    1 add in trunk/Source/WebKit2

Add QML API tests for Device Pixel Ratio
https://bugs.webkit.org/show_bug.cgi?id=88531

Reviewed by Kenneth Rohde Christiansen.

This patch adds an initial test case for the QML device pixel ratio
API. The test currently fails and is therefore marked as being
expected to fail. This will be fixed in a separated patch.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml: Added.
7:41 AM Changeset in webkit [119722] by loislo@chromium.org
  • 8 edits
    4 adds in trunk

Web Inspector: sorting of object fields is broken in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=88532

A recent change to heap profiler has replaced getters with functions.
Function calls were missing in couple places after that change.

Source/WebCore:

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-07
Reviewed by Vsevolod Vlasov.

Tests: inspector/profiler/heap-snapshot-summary-sorting-fields.html

inspector/profiler/heap-snapshot-summary-sorting-instances.html

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeField):

LayoutTests:

The following changes were made to the tests:

  • generateSnapshot now uses pseudo random numbers for object sizes. It allows to test sorting.
  • Added a test that checks sorting of object instances of a particular class.
  • Added a test that checks sorting of fields in an object instance.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-07
Reviewed by Vsevolod Vlasov.

Tests: inspector/profiler/heap-snapshot-summary-sorting-fields.html

inspector/profiler/heap-snapshot-summary-sorting-instances.html

  • inspector/profiler/heap-snapshot-summary-sorting-fields-expected.txt: Added.
  • inspector/profiler/heap-snapshot-summary-sorting-fields.html: Added.
  • inspector/profiler/heap-snapshot-summary-sorting-instances-expected.txt: Added.
  • inspector/profiler/heap-snapshot-summary-sorting-instances.html: Added.
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
7:30 AM Changeset in webkit [119721] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] User viewport arguments are not respected
https://bugs.webkit.org/show_bug.cgi?id=88530

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-06-07
Reviewed by Antonio Gomes.

RIM PR #163767

Fixed by applying the user supplied viewport arguments if the page
specifies default viewport arguments (i.e. the page has no viewport
meta tag).

If the user didn't supply any viewport arguments either, the behaviour
is the same as before the patch, the caller will successfully reset to
default viewport arguments.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):

7:19 AM Changeset in webkit [119720] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] WebKit2-EFL does not link in debug mode
https://bugs.webkit.org/show_bug.cgi?id=88518

Unreviewed. Fix WebKit2-EFL linking error in debug mode.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-07

  • CMakeLists.txt:
7:17 AM Changeset in webkit [119719] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Consider Ctrl+Shift+key as valid zoom change combinations
https://bugs.webkit.org/show_bug.cgi?id=88520

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

7:00 AM Changeset in webkit [119718] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[BlackBerry] Allow WebPageCompositor to blend a transparent web page
https://bugs.webkit.org/show_bug.cgi?id=88233

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-06-07
Reviewed by Rob Buis.

RIM PR #159998

Source/WebCore:

Add a parameter to LayerRenderer::compositeBuffer() indicating whether
the buffer contents are opaque, and set the GL blend mode accordingly.

This is not currently testable using BlackBerry testing infrastructure.

Reviewed internally by Jakob Petsovits.

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::compositeBuffer):

  • platform/graphics/blackberry/LayerRenderer.h:

(LayerRenderer):

Source/WebKit/blackberry:

Keep track of the web page background color in the compositor so we can
determine whether the contents of the root layer are transparent.

Reviewed internally by Jakob Petsovits.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::compositeContents):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::setCompositorBackgroundColor):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::createCompositor):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::setBackgroundColor):
(WebKit):

  • Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::backgroundColor):
(WebPageCompositorPrivate):

  • Api/WebPage_p.h:

(WebPagePrivate):

6:45 AM Changeset in webkit [119717] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Clean chromium test expectations.

  • platform/chromium/TestExpectations:
6:43 AM Changeset in webkit [119716] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix broken build due to missing <SECTION> in GTK-DOC
https://bugs.webkit.org/show_bug.cgi?id=88525

Unreviewed gardening. Added missing <SECTION> tag.

Patch by Simon Pena <Simon Pena> on 2012-06-07

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
6:21 AM Changeset in webkit [119715] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[Gtk] Assertions in gtk_widget_draw when acquiring pixel output
https://bugs.webkit.org/show_bug.cgi?id=88060

Reviewed by Martin Robinson.

Spin the main loop before acquiring the pixel content. This ensures things
like late size allocations are finished before calling gtk_widget_draw,
avoiding assertions and subsequent empty pixel results.

  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:

(createBitmapContextFromWebView):

6:09 AM Changeset in webkit [119714] by commit-queue@webkit.org
  • 4 edits in trunk

Web Inspector: reuse edge_count field of heap snapshot to store retained size
https://bugs.webkit.org/show_bug.cgi?id=88416

The edge_count field is unused after node first edge indexes have been built.
Store node retained size in there instead of allocating an extra array for it.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-07
Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.retainedSize):
(WebInspector.HeapSnapshot.prototype._calculateRetainedSizes):

LayoutTests:

  • inspector/profiler/heap-snapshot.html:
5:59 AM Changeset in webkit [119713] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add enable credential autofill and enable form autofill feature control in WebSetting
https://bugs.webkit.org/show_bug.cgi?id=88513

Patch by Jonathan Dong <Jonathan Dong> on 2012-06-07
Reviewed by Rob Buis.

RIM PR: #163391
Implemented credential autofill setting and form autofill setting.

Internally reviewed by Leo Yang <leo.yang@torchmobile.com.cn>.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::autofillTextField):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::clearCredentials):
(BlackBerry::WebKit::WebPage::clearAutofillData):
(BlackBerry::WebKit::WebPage::clearNeverRememberSites):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::isCredentialAutofillEnabled):
(BlackBerry::WebKit::WebSettings::setCredentialAutofillEnabled):
(BlackBerry::WebKit::WebSettings::isFormAutofillEnabled):
(BlackBerry::WebKit::WebSettings::setFormAutofillEnabled):

  • Api/WebSettings.h:
  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
(WebCore::EditorClientBlackBerry::textDidChangeInTextField):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):

5:56 AM Changeset in webkit [119712] by loislo@chromium.org
  • 13 edits
    3 deletes in trunk

Unreviewed, rolling out r119694.
http://trac.webkit.org/changeset/119694
https://bugs.webkit.org/show_bug.cgi?id=88529

it broke PrerenderBrowserTest.PrerenderHTML5VideoNetwork
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07

Source/WebCore:

  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/MediaPlayer.h:

(MediaPlayer):

  • platform/graphics/MediaPlayerPrivate.h:

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):

  • src/AssertMatchingEnums.cpp:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::loadInternal):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

  • http/tests/security/resources/video-cross-origin-allow.php: Removed.
  • http/tests/security/video-cross-origin-readback-expected.txt: Removed.
  • http/tests/security/video-cross-origin-readback.html: Removed.
5:22 AM Changeset in webkit [119711] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

Delete a contenteditable element having a Shadow DOM causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=86345

Reviewed by Ryosuke Niwa.

Source/WebCore:

In VisibleSelection::validate(), m_start.downstream() or m_end.upstream() might cross
editing boundaries. So we adjust selection after calling them again.

Test: editing/shadow/select-contenteditable-shadowhost.html

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::validate):

LayoutTests:

  • editing/shadow/select-contenteditable-shadowhost-expected.txt: Added.
  • editing/shadow/select-contenteditable-shadowhost.html: Added.
5:11 AM Changeset in webkit [119710] by kenneth@webkit.org
  • 2 edits in trunk/Tools

[Qt] Improve the visual of the viewport info box
https://bugs.webkit.org/show_bug.cgi?id=88410

Reviewed by Tor Arne Vestbø.

Improve the visual and make it possible to see the content more easy.

  • MiniBrowser/qt/qml/ViewportInfoItem.qml:
5:08 AM Changeset in webkit [119709] by kinuko@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed rebaseline for r115582.

  • http/tests/security/filesystem-iframe-from-remote-expected.txt:
  • platform/chromium/TestExpectations:
4:58 AM Changeset in webkit [119708] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

No new line at the end for SVGCSSPropertyNames.in causes compilation warning
https://bugs.webkit.org/show_bug.cgi?id=88503

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-06-07
Reviewed by Ryosuke Niwa.

Added new line at the end of the file.

No new tests required.

  • css/SVGCSSPropertyNames.in:
4:57 AM Changeset in webkit [119707] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening. Skip failing new test.
https://bugs.webkit.org/show_bug.cgi?id=88523

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-07
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped: Skip http/tests/security/video-cross-origin-readback.html.
4:49 AM Changeset in webkit [119706] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][Win] Use OS(WINDOWS) instead of Q_WS_WIN in WebCore/platform/graphics/GraphicsContext.h
https://bugs.webkit.org/show_bug.cgi?id=88305

Reviewed by Simon Hausmann.

  • platform/graphics/GraphicsContext.h: Buildfix.

(GraphicsContext):

4:45 AM Changeset in webkit [119705] by shinyak@chromium.org
  • 4 edits in trunk/Source/WebCore

Incorrect data retrieved in calls to get selection data in client->textWillBeReplaced from CharacterData::setDataAndUpdate
https://bugs.webkit.org/show_bug.cgi?id=66120

Reviewed by Ryosuke Niwa.

Since FrameSelection::textWillBeReplaced was called before replacing text, updated Selection became
temporarily invalid. The invalid selection was set to updateSelection(), so client will have
invalid selection.

This patch makes calling updateSelection() after updating selection.

No new tests, it's too hard to create a correct test cases in DRT.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::setDataAndUpdate):

  • editing/FrameSelection.cpp:

(WebCore::updatePositionAfterAdoptingTextReplacement):
(WebCore::FrameSelection::textWasReplaced):

  • editing/FrameSelection.h:

(FrameSelection):

4:39 AM Changeset in webkit [119704] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

[Qt][Win] Fix linking WTF with ICU
https://bugs.webkit.org/show_bug.cgi?id=88302

Reviewed by Simon Hausmann.

  • WTF.pri: Use proper library names on win32 platforms.
4:25 AM Changeset in webkit [119703] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed Skipped list cleanup. Remove disabled/passing tests, add bug reports.

  • platform/qt-arm/Skipped:
  • platform/qt/Skipped:
4:06 AM Changeset in webkit [119702] by commit-queue@webkit.org
  • 6 edits in trunk

FileAPI: If type consists of non-ASCII characters in Blob constructor, it should throw a SyntaxError.
https://bugs.webkit.org/show_bug.cgi?id=88411

Patch by Li Yin <li.yin@intel.com> on 2012-06-07
Reviewed by Kentaro Hara.

Source/WebCore:

From spec: http://dev.w3.org/2006/webapi/FileAPI/#constructorBlob
If type consists of any non-ASCII characters, throw a SyntaxError and
return from this algorithm.
This patch checks the String is ASCii or not, if not, throw SyntaxError.

Test: fast/files/blob-constructor.html

  • bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

LayoutTests:

From Spec: http://dev.w3.org/2006/webapi/FileAPI/#constructorBlob
If type consists of any non-ASCII characters, throw a SyntaxError and
return from this algorithm.

  • fast/files/blob-constructor-expected.txt:
  • fast/files/script-tests/blob-constructor.js:
3:36 AM Changeset in webkit [119701] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

InsertUnorderedList and InsertOrderedList (execCommand) do not remove bullets
https://bugs.webkit.org/show_bug.cgi?id=84597

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-06-07
Reviewed by Ryosuke Niwa.

Source/WebCore:

Comparison between start and end VisiblePositions will fail when a position inside
a paragraph is compared with one at the start of the paragraph.

This fix thus converts the end VisiblePosition (which could be inside the paragraph)
to the start of the paragraph thereby enabling a proper comparison of start and end
positions.

Test: editing/execCommand/remove-list-from-multi-list-items.html

  • editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::selectionHasListOfType):

LayoutTests:

This test verifies removing of an (un)ordered list on a selection consisting of multiple
list items (paragraphs) when the end point of the selection points to the end of the last
list item; followed by another paragraph not part of the selection/list.

  • editing/execCommand/remove-list-from-multi-list-items-expected.txt: Added.
  • editing/execCommand/remove-list-from-multi-list-items.html: Added.
3:16 AM Changeset in webkit [119700] by Carlos Garcia Campos
  • 11 edits
    5 adds in trunk/Source/WebKit2

[GTK] Add API to register custom URI schemes to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=84133

Reviewed by Martin Robinson.

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitRequestManagerClient.cpp: Added.

(didReceiveURIRequest): Callback emitted by the C API when a
request for a custom URI scheme has been received. Call
webkitWebContextReceivedURIRequest() to handle the request.
(didFailToLoadURIRequest): Callback emitted by the C API when a
request for a custom URI scheme failed to load. Call
webkitWebContextDidFailToLoadURIRequest() to noitfy the web
context.
(attachRequestManagerClientToContext): Initialize the
WKSoupRequestManagerClient.

  • UIProcess/API/gtk/WebKitRequestManagerClient.h: Added.
  • UIProcess/API/gtk/WebKitURISchemeRequest.cpp: Added.

(webkit_uri_scheme_request_init):
(webkitURISchemeRequestFinalize):
(webkit_uri_scheme_request_class_init):
(webkitURISchemeRequestCreate): Create a new
WebKitURISchemeRequest for the given URI and request identifier.
(webkitURISchemeRequestGetID): Return the request identifier.
(webkitURISchemeRequestCancel): Cancel the request operation.
(webkit_uri_scheme_request_get_scheme): Return the scheme of the
request.
(webkit_uri_scheme_request_get_uri): Return the full URI of the
request.
(webkit_uri_scheme_request_get_path): Return the path of the URI.
(webkitURISchemeRequestReadCallback): Read callback emitted when
reading the contents of the input stream.
(webkit_uri_scheme_request_finish): Finish the request by reading
the contents of the input stream and sending the data to the
WebProcess.

  • UIProcess/API/gtk/WebKitURISchemeRequest.h: Added.
  • UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(WebKitURISchemeHandler::WebKitURISchemeHandler): Helper struct to
save callback and user data of registered URI schemes.
(createDefaultWebContext): Initialize the SoupRequestManager.
(webkit_web_context_register_uri_scheme): Public API to register a
custom URI scheme providing a callback that will be called to
handle requests for that URI scheme.
(webkitWebContextGetRequestManager): Helper private method to
return the SoupRequestManager.
(webkitWebContextReceivedURIRequest): Get the
WebKitURISchemeHandler for the given request identifier and call
the callback. Save the request in the request map.
(webkitWebContextDidFailToLoadURIRequest): Cancel the ongoing
request.
(webkitWebContextDidFinishURIRequest): Remove the request from the
map.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add

WebKitURISchemeRequest section.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add

webkit_uri_scheme_request_get_type.

  • UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:

(testWebContextURIScheme):
(beforeAll):

  • UIProcess/API/gtk/webkit2.h: Include WebKitURISchemeRequest.h.
2:47 AM Changeset in webkit [119699] by yosin@chromium.org
  • 3 edits in trunk/LayoutTests

[Forms] Improve test coverage of input-number-size.html
https://bugs.webkit.org/show_bug.cgi?id=88489

Reviewed by Kent Tamura.

This patch improves test coverage for NumberInputType::sizeShouldIncludeDecoration()
for preparation of introducing decimal arithmetic.

  • fast/forms/number/input-number-size-expected.txt: Updated for a new test case.
  • fast/forms/number/input-number-size.html: Added a test case.
2:42 AM Changeset in webkit [119698] by commit-queue@webkit.org
  • 16 edits
    3 deletes in trunk

[FileAPI] FileReader should throw an InvalidStateError exception when readyState is LOADING
https://bugs.webkit.org/show_bug.cgi?id=88212

Patch by Li Yin <li.yin@intel.com> on 2012-06-07
Reviewed by Jian Li.

Source/WebCore:

From Spec: http://www.w3.org/TR/FileAPI/#readAsBinaryString
FileReader should throw an InvalidStateError exception instead of NOT_ALLOWED_ERR
when the readyState is LOADING.
Also delete OperationNotAllowedException related code, because it is not longer needed.

Tests: fast/files/read-file-async.html

fast/files/workers/worker-read-file-async.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMExceptions.in:
  • fileapi/FileReader.cpp:

(WebCore::FileReader::readInternal): Changed it to throw INVALID_STATE_ERR.

  • fileapi/FileReader.idl: Changed it to raise DOMException for all read methods.
  • fileapi/OperationNotAllowedException.cpp: Removed.
  • fileapi/OperationNotAllowedException.h: Removed.
  • fileapi/OperationNotAllowedException.idl: Removed.

LayoutTests:

From spec: http://www.w3.org/TR/FileAPI/#readAsBinaryString
FileReader should throw an InvalidStateError exception instead of NOT_ALLOWED_ERR.

  • fast/files/read-file-async-expected.txt:
  • fast/files/workers/worker-read-file-async-expected.txt:
2:38 AM Changeset in webkit [119697] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] setPageItemRectVisible() is not guarded by ViewportUpdateDeferrer at scaleAnimationValueChanged()
https://bugs.webkit.org/show_bug.cgi?id=87954

Reviewed by Kenneth Rohde Christiansen.

Resetting the end value, the easing curve or the duration of the scale animation triggers
a recalculation of the animation interval. This might change the current value of the
animated property.
Since guarding of setPageItemRectVisible() relies on animation state change we have to
make sure we only act on animation value changes if the animation is in active state.

  • UIProcess/qt/QtViewportHandler.cpp:

(WebKit::QtViewportHandler::QtViewportHandler):
(WebKit::QtViewportHandler::animatePageItemRectVisible):
(WebKit::QtViewportHandler::scaleAnimationValueChanged):

2:26 AM Changeset in webkit [119696] by loislo@chromium.org
  • 4 edits in trunk/Source

Unreviewed, rolling out r119689.
http://trac.webkit.org/changeset/119689
https://bugs.webkit.org/show_bug.cgi?id=88516

it broke didDrawNotCalledOnScissoredLayer webkit_unit_test
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
2:11 AM Changeset in webkit [119695] by Carlos Garcia Campos
  • 10 edits in trunk/Source/WebKit2

[SOUP] WebSoupRequestManager should handle loading errors and zero-length replies
https://bugs.webkit.org/show_bug.cgi?id=88087

Reviewed by Martin Robinson.

  • UIProcess/API/C/soup/WKSoupRequestManager.h:
  • UIProcess/soup/WebSoupRequestManagerClient.cpp:

(WebKit::WebSoupRequestManagerClient::didFailToLoadURIRequest):
Call didFailToLoadURIRequest in the client if present.

  • UIProcess/soup/WebSoupRequestManagerClient.h:
  • UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::WebSoupRequestManagerProxy):
Initialize m_loadFailed.
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequestData):
Don't send more data to the web process if the resource failed to
load.
(WebKit::WebSoupRequestManagerProxy::didFailToLoadURIRequest): Set
m_loadFailed and notifiy the client calling didFailToLoadURIRequest.

  • UIProcess/soup/WebSoupRequestManagerProxy.h:
  • UIProcess/soup/WebSoupRequestManagerProxy.messages.in: Add

DidFailToLoadURIRequest message.

  • WebProcess/soup/WebKitSoupRequestGeneric.cpp:

(webkitSoupRequestGenericSendAsync): Pass the cancellable to the
WebSoupRequestManager.

  • WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestAsyncData::WebSoupRequestAsyncData): Helper
struct to save requests.
(WebSoupRequestAsyncData): Add a weak pointer to invalidate the
request when it's destroyed before the operation has finished.
(WebKit::WebSoupRequestAsyncData::~WebSoupRequestAsyncData):
Remove the weak pointer.
(WebKit::WebSoupRequestAsyncData::requestFailed): Return whther
the request failed.
(WebKit::WebSoupRequestAsyncData::releaseResult): Return the
result and clear the pointer.
(WebKit::WebSoupRequestManager::didHandleURIRequest): Create and
empty memory stream for zero-length replies instead of creating an
error.
(WebKit::WebSoupRequestManager::didReceiveURIRequestData): If the
request failed and more data expected from the UI process, send a
message to the UI process to notify that the resource load failed.
(WebKit::WebSoupRequestManager::send): Save request information in
the request map.

  • WebProcess/soup/WebSoupRequestManager.h:
1:48 AM Changeset in webkit [119694] by fischman@chromium.org
  • 12 edits
    3 adds in trunk

Plumb CORS attribute information from HTMLMediaElement to media players so it can be used
https://bugs.webkit.org/show_bug.cgi?id=88349

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/video-cross-origin-readback.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerCORSMode):
(WebCore):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerCORSMode):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::loadInternal):

1:28 AM Changeset in webkit [119693] by hbono@chromium.org
  • 5 edits in trunk

Use light gray for grammar markers on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=88398

Reviewed by Ryosuke Niwa.

This change changes the color of grammar markers from dark gray to light gray
and rebaselines a couple of pixel tests affected by this change.

Source/WebCore:

No new tests because it changes the marker color of an existing test 'grammar-markers.html'.

  • platform/graphics/skia/GraphicsContextSkia.cpp: Change dark gray to light gray.

LayoutTests:

  • platform/chromium-linux/editing/spelling/grammar-markers-expected.png:
  • platform/chromium-win/editing/spelling/grammar-markers-expected.png:
12:56 AM Changeset in webkit [119692] by yosin@chromium.org
  • 5 edits in trunk/Source

Source/WebCore: [Platform] Introduce conversion from/to Deciaml to/from double
https://bugs.webkit.org/show_bug.cgi?id=88480

Reviewed by Kent Tamura.

This patch added functions for Decimal/Double conversion and isInfinity
for reducing patch size of introducing Decimal arithmetic, bug 88383.

Tests: WebKit/chromium/tests/DecimalTest.cpp

  • platform/Decimal.cpp:

(WebCore::Decimal::fromDouble): Added.
(WebCore::Decimal::toDouble): Added.

  • platform/Decimal.h:

(WebCore::Decimal::EncodedData::isInfinity): Added for isinf()
(WebCore::Decimal::isInfinity): Added.

Source/WebKit/chromium: [Platform] Introduce conversion from/to Deciaml to/from double and helper functions
https://bugs.webkit.org/show_bug.cgi?id=88480

Reviewed by Kent Tamura.

This patch added tests for Decimal::fromDouble, isInfinity, toDouble.

  • tests/DecimalTest.cpp:

(TEST_F):

12:45 AM Changeset in webkit [119691] by fischman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:

Jun 6, 2012:

11:57 PM Changeset in webkit [119690] by wangxianzhu@chromium.org
  • 7 edits
    5 adds in trunk

Element.getBoundingClientRect() and Element.getClientRects() return incorrect values in frames in a scaled page
https://bugs.webkit.org/show_bug.cgi?id=88430

Source/WebCore:

Element.getBoudingClientRect() and Element.getClientRects() should not scale back the rects
if the element is in a frame because page scale only apply to elements in the main frame.

Reviewed by James Robinson.

Tests: fast/dom/Element/scale-page-bounding-client-rect-in-frame.html

fast/dom/Element/scale-page-client-rects-in-frame.html

  • dom/Document.cpp:

(WebCore):
(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale): Extracted from Element.cpp and Range.cpp and fixed issue of pageScale in frames.
(WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale): Extracted from Element.cpp and fixed issue of pageScale in frames.

  • dom/Document.h:

(WebCore):
(Document):

  • dom/Element.cpp:

(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):

  • dom/Range.cpp:

(WebCore):
(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale): Moved into Document and fixed issue of pageScale in frames.
(WebCore::Range::getBorderAndTextQuads):

  • rendering/RenderObject.h: Removed adjustFloatQuadForPageScale and adjustFloatRectForPageScale because they seem unrelated to RenderObject.

(WebCore):

LayoutTests:

Reviewed by James Robinson.

  • fast/dom/Element/resources/client-rect-frame.html: Added.
  • fast/dom/Element/scale-page-bounding-client-rect-in-frame-expected.txt: Added.
  • fast/dom/Element/scale-page-bounding-client-rect-in-frame.html: Added.
  • fast/dom/Element/scale-page-client-rects-in-frame-expected.txt: Added.
  • fast/dom/Element/scale-page-client-rects-in-frame.html: Added.
11:54 PM Changeset in webkit [119689] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called
https://bugs.webkit.org/show_bug.cgi?id=88469

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.didDrawNotCalledOnScissoredLayer

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::shouldDrawLayer):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
11:25 PM Changeset in webkit [119688] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r60044.
http://trac.webkit.org/changeset/60044

It made a regression, crbug.com/114922.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::invalidateContentsForSlowScroll): Do not hide popups by scrolling.
(WebKit::ChromeClientImpl::scroll): ditto.

11:20 PM Changeset in webkit [119687] by aestes@apple.com
  • 17 edits in trunk/Source

Wrap uppercaseWord, lowercaseWord, and capitalizeWord with USE(APPKIT)
https://bugs.webkit.org/show_bug.cgi?id=88504

Reviewed by Dan Bernstein.

uppercaseWord, lowercaseWord, and capitalizeWord are methods declared
by NSResponder that subclasses are expected to implement. WebKit should
only support these implementations on platforms that use AppKit.

Source/WebCore:

  • WebCore.exp.in:
  • editing/Editor.cpp:
  • editing/Editor.h:
  • loader/EmptyClients.h:
  • page/ContextMenuController.cpp:
  • page/EditorClient.h:

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

Source/WebKit2:

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
11:14 PM Changeset in webkit [119686] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS: Roll to chromium 140955.
11:01 PM Changeset in webkit [119685] by loislo@chromium.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r119683.
http://trac.webkit.org/changeset/119683
https://bugs.webkit.org/show_bug.cgi?id=88505

it broke webkit-unit-test
WebLayerTreeViewThreadedTest.InstrumentationCallbacks on mac
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-06

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::setVisible):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):

  • tests/Canvas2DLayerChromiumTest.cpp:

(Canvas2DLayerChromiumTest::fullLifecycleTest):

10:56 PM Changeset in webkit [119684] by rjkroege@chromium.org
  • 9 edits in trunk/Source

Source/WebCore: [Chromium] Re-enable handling of smooth scrolling on Chromium Linux/Windows
https://bugs.webkit.org/show_bug.cgi?id=87535 by adding support for
m_hasPreciseScrollingDelta on all Chromium platforms and adjusting ScrollAnimator
and ScrollAnimatorNone accordingly to let m_hasPreciseScrollingDelta == true
force exact (non-animated) scrolling.

Reviewed by James Robinson.

Updated WebKit unit tests to validate change.

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent): Adjusted #ifdefs to
make m_hasPreciseScrollingDelta available on all Chromium platforms.
(PlatformWheelEvent):

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent): Default scroll type is set based on
m_hasPreciseScrollingDelta value.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scroll): Scroll precisely when necessary.

  • platform/ScrollTypes.h: Added additional pixel scrolling subtype.
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scroll): Updated for additional pixel scroll subtype.

Source/WebKit/chromium: [Chromium] Re-enable handling of smooth scrolling on Chromium Linux/Windows
https://bugs.webkit.org/show_bug.cgi?id=87535 by adding support for precise
scrolling deltas on all Chromium platforms.

Reviewed by James Robinson.

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder): Create PlatformWheelEvents
with m_hasPreciseScrollingDelta flag as required.

  • tests/ScrollAnimatorNoneTest.cpp: Added new unit test condiiton for precise scrolling.

(TEST):

10:00 PM Changeset in webkit [119683] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Stop dropping texture limits when the layer tree host becomes invisible, and initialize with 0 allocation.
https://bugs.webkit.org/show_bug.cgi?id=87747

Patch by Michal Mocny <mmocny@google.com> on 2012-06-06
Reviewed by Adrienne Walker.

Source/WebCore:

GpuMemoryManager manages texture memory allocation limits. It will send a 0 allocation when a renderer becomes
invisible, and an appropriate allocation after a renderer is initialized. These numbers will change
depending on the state of memory across devices and other renderers, so we would like to remove all explicit
management by the renderers themselves.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::setVisible):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockLayerTreeHost::create):

  • tests/Canvas2DLayerChromiumTest.cpp:

(Canvas2DLayerChromiumTest::fullLifecycleTest):

9:52 PM Changeset in webkit [119682] by kinuko@chromium.org
  • 8 edits in trunk/Source/WebCore

Unreviewed, rolling out r119680.
http://trac.webkit.org/changeset/119680
https://bugs.webkit.org/show_bug.cgi?id=88498

It broke mac build (Requested by kinuko on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-06

  • fileapi/File.cpp:

(WebCore::File::File):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding):
(WebCore):
(WebCore::File::captureSnapshot):

  • fileapi/File.h:

(File):

  • fileapi/File.idl:
  • platform/FileMetadata.h:

(WebCore::FileMetadata::FileMetadata):

  • platform/FileSystem.h:
  • platform/chromium/support/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

  • platform/network/BlobData.cpp:

(WebCore):

9:34 PM Changeset in webkit [119681] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] browser video player fullscreen mode (portrait) - Controls are off screen so cannot exit fullscreen
https://bugs.webkit.org/show_bug.cgi?id=88488
PR #162991

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

When we use width:100%/pageScale as the math to calculate the width of the
FullScreen element, it goes too wide for horizontally scrollable webpages.
The reason is that 100% is relative to the content size here, and we want 100%
relative to the viewport size. However, since there is no such a thing in CSS,
we set an absolute file.

A known problem with this will be rotating the device when in fullscreen mode
that we can address when rotating is supported.

Internally reviewed by Jacky Jiang.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

9:34 PM Changeset in webkit [119680] by kinuko@chromium.org
  • 8 edits in trunk/Source/WebCore

File::lastModifiedDate should use NaN or separate boolean flag for null Date value
https://bugs.webkit.org/show_bug.cgi?id=87826

Reviewed by Kent Tamura.

Test: http/tests/local/fileapi/file-last-modified-after-delete.html

  • fileapi/File.cpp:

(WebCore::File::File):
(WebCore::File::captureSnapshot):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding): Removed.

  • fileapi/File.h:

(File):

  • fileapi/File.idl:
  • platform/FileMetadata.h:

(WebCore::FileMetadata::FileMetadata):

  • platform/FileSystem.h:
  • platform/chromium/support/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

  • platform/network/BlobData.cpp:

(WebCore):

9:34 PM Changeset in webkit [119679] by tonikitoo@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Implement a top-down in-region boundary detection in InRegionScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=88254
PR #125237

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

Patch implements a top-down visibleWindowRect calculation for all scrollable
elements hit-tested by a given point.

The reason on why this approach is better is that it calculates the visible
window rect from the outtermost scrollable element towards the inner ones, and
that allows it to use the visible window rect of the previous scrollable element
as the clipping rect for the current one.

Patch also changes the return vector to store ScrollViewBase pointers, so
we can make use of static_cast properly.

Internally reviewed by Jakob Petsovits.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::pushBackInRegionScrollable):
(BlackBerry::WebKit::WebPagePrivate::inRegionScrollableAreasForPoint):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
(BlackBerry::WebKit::InRegionScrollableArea::setVisibleWindowRect):
(WebKit):
(BlackBerry::WebKit::InRegionScrollableArea::visibleWindowRect):

  • WebKitSupport/InRegionScrollableArea.h:

(InRegionScrollableArea):

9:26 PM Changeset in webkit [119678] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Compile webkit1 and webkit2 by default.
https://bugs.webkit.org/show_bug.cgi?id=85041

Patch by Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2012-06-06
Reviewed by Chang Shu.

Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.

  • Scripts/build-webkit:
9:23 PM Changeset in webkit [119677] by rniwa@webkit.org
  • 7 edits
    4 deletes in trunk

Unreviewed, rolling out r119668.
http://trac.webkit.org/changeset/119668
https://bugs.webkit.org/show_bug.cgi?id=88493

Hitting assertions in debug builds (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-06

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::localCaretRect):

  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderInline.cpp:
  • rendering/RenderInline.h:

(RenderInline):

LayoutTests:

  • editing/selection/caret-in-empty-inline-1-expected.txt: Removed.
  • editing/selection/caret-in-empty-inline-1.html: Removed.
  • editing/selection/caret-in-empty-inline-2-expected.txt: Removed.
  • editing/selection/caret-in-empty-inline-2.html: Removed.
9:20 PM Changeset in webkit [119676] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Cache isSelfPaintingLayer() for better performance
https://bugs.webkit.org/show_bug.cgi?id=88464

Reviewed by Simon Fraser.

Covered by existing tests (repaint tests among them).

isSelfPaintingLayer() has shown up several times on some scrolling benchmarks due
to the function being called several time per paint phase. This change caches the
boolean at style change time.

On http://dglazkov.github.com/performance-tests/biggrid.html, this nearly speed-up
painting by 2 (lowering the time taken to paint the newly exposed area when scrolling
on a 10,000 * 100 table from 95ms to 50ms).

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
Initialized m_isSelfPaintingLayer here.

(WebCore::RenderLayer::paintLayer):
Changed the order of the checks to get the more likely check first.

(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
Renamed from isSelfPaintingLayer to make m_isNormalFlowOnly.

(WebCore::RenderLayer::styleChanged):
Added code to update our cached m_isSelfPaintingLayer.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::isSelfPaintingLayer):
Changed to return m_isSelfPaintingLayer.

9:19 PM Changeset in webkit [119675] by rniwa@webkit.org
  • 6 edits in trunk/LayoutTests

One more Chromium rebaseline for r119617.

Also update the test expectation per r119659.
fast/sub-pixel/file-upload-control-at-fractional-offset.html should have MISSING expectation.

  • platform/chromium-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium/TestExpectations:
8:54 PM Changeset in webkit [119674] by rniwa@webkit.org
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

More Chromium rebaselines for r119591 and r119617.

  • platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Removed.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/chromium-win/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
8:47 PM Changeset in webkit [119673] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add an image failure expectation to fast/repaint/fixed-tranformed.html
on Chromium Windows and Chromium Mac. The failure is tracked by the bug 88490.

  • platform/chromium/TestExpectations:
8:47 PM Changeset in webkit [119672] by yosin@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r109729) [Form] Rendering of select/optgroup/option combination is too slow.
https://bugs.webkit.org/show_bug.cgi?id=88059

Reviewed by Kent Tamura.

This patch changes not to share RenderStyle object for option and
optgroup element regardless attributes.

When we tried to shared RenderStyle object, rendering performance was
good but we had issue in selected option and text transform, see
https://bugs.webkit.org/show_bug.cgi?id=88405 for details.

No new tests. This patch doesn't change behavior but rendering performance.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement): Changed to always
return false for option and optgroup.

8:39 PM Changeset in webkit [119671] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Optimize single-key get()
https://bugs.webkit.org/show_bug.cgi?id=85288

Patch by Alec Flett <alecflett@chromium.org> on 2012-06-06
Reviewed by Tony Chang.

No new tests, this is just an optimization.

After a recent refactoring, we started creating
an internal cursor with every call to get(). The
most common use of get() is with a single key,
so provide a fast-path to avoid creating the cursor.

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::getByRangeInternal):

  • Modules/indexeddb/IDBKeyRange.h:

(WebCore::IDBKeyRange::isOnlyKey):
(IDBKeyRange):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::getByRangeInternal):

8:39 PM Changeset in webkit [119670] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a timeout expectation to http/tests/media/video-cookie.html.
The failure is tracked by the Chromium issue 131533.

  • platform/chromium/TestExpectations:
8:16 PM Changeset in webkit [119669] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r119662.
http://trac.webkit.org/changeset/119662
https://bugs.webkit.org/show_bug.cgi?id=88487

Broke builds (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-06

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/ImageDiff.cpp:

(untestedCompareImages):

8:11 PM Changeset in webkit [119668] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk

Caret is not rendered in empty inline contenteditable elements
https://bugs.webkit.org/show_bug.cgi?id=85793

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-06-06
Reviewed by Ryosuke Niwa.

Source/WebCore:

Override localCaretRect in RenderInline. The implementation was almost
identical to localCaretRect in RenderBlock for empty block elements, so
I refactored RenderBlock::localCaretRect and moved the logic to a new
method 'localCaretRectForEmptyElement' in RenderBoxModelObject. The
implementation of 'localCaretRect' in RenderBlock and RenderInline both
use this helper method in RenderBoxModelObject.

Tests: editing/selection/caret-in-empty-inline-1.html

editing/selection/caret-in-empty-inline-2.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::localCaretRect):
Modified to use RenderBoxModelObject::localCaretRectForEmptyElement.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
(WebCore):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):
Add localCaretRectForEmptyElement helper method.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::localCaretRect):
(WebCore):

  • rendering/RenderInline.h:

(RenderInline):
Override localCaretRect using localCaretRectForEmptyElement.

LayoutTests:

Add test cases for caret in empty inline.

  • editing/selection/caret-in-empty-inline-1-expected.txt: Added.
  • editing/selection/caret-in-empty-inline-1.html: Added.
  • editing/selection/caret-in-empty-inline-2-expected.txt: Added.
  • editing/selection/caret-in-empty-inline-2.html: Added.
7:47 PM Changeset in webkit [119667] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Chromium build fix attempt. Why do we need to list these files in gyp!?

7:40 PM Changeset in webkit [119666] by pilgrim@chromium.org
  • 14 edits
    2 copies in trunk/Source

[Chromium] Move createMessagePortChannel to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85764

Source/Platform:

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::createMessagePortChannel):

  • chromium/public/WebMessagePortChannel.h: Added.

(WebKit):
(WebMessagePortChannel):
(WebKit::WebMessagePortChannel::~WebMessagePortChannel):

  • chromium/public/WebMessagePortChannelClient.h: Added.

(WebKit):
(WebMessagePortChannelClient):
(WebKit::WebMessagePortChannelClient::~WebMessagePortChannelClient):

Source/WebKit/chromium:

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

  • WebKit.gyp:
  • public/WebFrame.h:

(WebFrame):

  • public/WebMessagePortChannel.h:
  • public/WebMessagePortChannelClient.h:
  • public/WebSharedWorkerClient.h:

(WebSharedWorkerClient):

  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):

  • src/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):

  • src/PlatformMessagePortChannel.h:
  • src/SharedWorkerRepository.cpp:
  • src/WebSharedWorkerImpl.cpp:
7:39 PM Changeset in webkit [119665] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

Add failing test expectation for the test added by r119644.
The failure is tracked by the bug 88481.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
7:32 PM Changeset in webkit [119664] by noel.gordon@gmail.com
  • 5 edits
    4 adds in trunk/LayoutTests

Add a test for PNG COLOR_TYPE_PALETTE image with a color profile
https://bugs.webkit.org/show_bug.cgi?id=86722

Reviewed by Adam Barth

Add paletted PNG image with a color profile and write a test. Add platform exceptions
since color correction is not implemented on all platforms. Note: that wincairo skips
fast/images/*.

  • fast/images/paletted-png-with-color-profile-expected.txt: Added.
  • fast/images/paletted-png-with-color-profile.html: Added.
  • fast/images/resources/palatted-color-png-gamma-one-color-profile.png: Added.
  • platform/chromium/TestExpectations: No color correction for paletted PNG images.
  • platform/efl/TestExpectations: SKIP, no color correction.
  • platform/gtk/TestExpectations: SKIP, no color correction.
  • platform/mac-snowleopard/fast/images/paletted-png-with-color-profile-expected.png: Added.

The image is a 64-color, paletted PNG image containing a gamma 1.0 sRGB color profile.
See the bug for more detailed properties of the test image and its color profile.

  • platform/qt/TestExpectations: SKIP, no color correction.
7:22 PM Changeset in webkit [119663] by alexis.menard@openbossa.org
  • 3 edits
    2 adds in trunk

Fix border-image-slice failures on http://css3test.com.
https://bugs.webkit.org/show_bug.cgi?id=88328

Reviewed by Tony Chang.

Source/WebCore:

The old parsing code was assuming that the fill keyword comes after the
numbers or the percentage values. http://www.w3.org/TR/css3-background/#the-border-image-slice
defines the property like this : [<number> | <percentage>]{1,4} && fill? where the fill
keyword is not mandatory. But according to http://www.w3.org/TR/CSS2/about.html "&&"
separates two or more components, all of which must occur, in any order. So the previous
code was wrong the fill can come first following by the percentages or the numbers. http://css3test.com
was covering this particular case. I took the opportunity to extend our coverage
by adding tests on many different values the boder-image-slice property could take. I
also did a small cleanup by removing unused functions in BorderImageSliceParseContext.

Test: fast/css/getComputedStyle/getComputedStyle-border-image-slice.html

  • css/CSSParser.cpp:

(WebCore::BorderImageSliceParseContext::BorderImageSliceParseContext):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageSliceParseContext::commitFill):

LayoutTests:

Make sure we cover more border-image-slice parsing.

  • fast/css/getComputedStyle/getComputedStyle-border-image-slice-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-border-image-slice.html: Added.
6:46 PM Changeset in webkit [119662] by wangxianzhu@chromium.org
  • 3 edits in trunk/Tools

[Chromium] Remove header dependency of ImageDiff to WTF
https://bugs.webkit.org/show_bug.cgi?id=88422

Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/chromium/ImageDiff.cpp:

(untestedCompareImages):

6:36 PM Changeset in webkit [119661] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebKit/chromium: [Chromium] DeviceOrientation cleanup
https://bugs.webkit.org/show_bug.cgi?id=88406

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-06
Reviewed by Kent Tamura.

Made default constructor public and added a set function for each property.
This will allow us to remove the 8-parameter constructor.

  • public/WebDeviceOrientation.h:

(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::setNull):
(WebKit::WebDeviceOrientation::setAlpha):
(WebKit::WebDeviceOrientation::setBeta):
(WebKit::WebDeviceOrientation::setGamma):
(WebKit::WebDeviceOrientation::setAbsolute):
(WebDeviceOrientation):

Tools: [WebKit] DeviceOrientation cleanup
https://bugs.webkit.org/show_bug.cgi?id=88406

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-06
Reviewed by Kent Tamura.

Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::setMockDeviceOrientation):

6:35 PM Changeset in webkit [119660] by fpizlo@apple.com
  • 31 edits
    2 moves in trunk/Source/JavaScriptCore

PredictedType should be called SpeculatedType
https://bugs.webkit.org/show_bug.cgi?id=88477

Rubber stamped by Gavin Barraclough.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):

  • bytecode/LazyOperandValueProfile.cpp:

(JSC::LazyOperandValueProfileParser::prediction):

  • bytecode/LazyOperandValueProfile.h:

(LazyOperandValueProfileParser):

  • bytecode/PredictedType.cpp: Removed.
  • bytecode/PredictedType.h: Removed.
  • bytecode/SpeculatedType.cpp: Copied from Source/JavaScriptCore/bytecode/PredictedType.cpp.

(JSC::speculationToString):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromClassInfo):
(JSC::speculationFromStructure):
(JSC::speculationFromCell):
(JSC::speculationFromValue):

  • bytecode/SpeculatedType.h: Copied from Source/JavaScriptCore/bytecode/PredictedType.h.

(JSC):
(JSC::isAnySpeculation):
(JSC::isCellSpeculation):
(JSC::isObjectSpeculation):
(JSC::isFinalObjectSpeculation):
(JSC::isFinalObjectOrOtherSpeculation):
(JSC::isFixedIndexedStorageObjectSpeculation):
(JSC::isStringSpeculation):
(JSC::isArraySpeculation):
(JSC::isFunctionSpeculation):
(JSC::isInt8ArraySpeculation):
(JSC::isInt16ArraySpeculation):
(JSC::isInt32ArraySpeculation):
(JSC::isUint8ArraySpeculation):
(JSC::isUint8ClampedArraySpeculation):
(JSC::isUint16ArraySpeculation):
(JSC::isUint32ArraySpeculation):
(JSC::isFloat32ArraySpeculation):
(JSC::isFloat64ArraySpeculation):
(JSC::isArgumentsSpeculation):
(JSC::isActionableIntMutableArraySpeculation):
(JSC::isActionableFloatMutableArraySpeculation):
(JSC::isActionableTypedMutableArraySpeculation):
(JSC::isActionableMutableArraySpeculation):
(JSC::isActionableArraySpeculation):
(JSC::isArrayOrOtherSpeculation):
(JSC::isMyArgumentsSpeculation):
(JSC::isInt32Speculation):
(JSC::isDoubleRealSpeculation):
(JSC::isDoubleSpeculation):
(JSC::isNumberSpeculation):
(JSC::isBooleanSpeculation):
(JSC::isOtherSpeculation):
(JSC::isEmptySpeculation):
(JSC::mergeSpeculations):
(JSC::mergeSpeculation):

  • bytecode/StructureSet.h:

(JSC::StructureSet::speculationFromStructures):

  • bytecode/ValueProfile.h:

(JSC::ValueProfileBase::ValueProfileBase):
(JSC::ValueProfileBase::dump):
(JSC::ValueProfileBase::computeUpdatedPrediction):
(ValueProfileBase):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::speculateInt32Unary):
(JSC::DFG::AbstractState::speculateNumberUnary):
(JSC::DFG::AbstractState::speculateBooleanUnary):
(JSC::DFG::AbstractState::speculateInt32Binary):
(JSC::DFG::AbstractState::speculateNumberBinary):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::StructureAbstractValue::filter):
(JSC::DFG::StructureAbstractValue::speculationFromStructures):
(JSC::DFG::AbstractValue::AbstractValue):
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::isClear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::isTop):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::validateIgnoringValue):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::dump):
(AbstractValue):

  • dfg/DFGArgumentPosition.h:

(JSC::DFG::ArgumentPosition::ArgumentPosition):
(JSC::DFG::ArgumentPosition::mergeArgumentAwareness):
(JSC::DFG::ArgumentPosition::prediction):
(ArgumentPosition):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getSpeculationWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getSpeculation):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::fixVariableAccessSpeculations):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::nameOfVariableAccessData):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::getJSConstantSpeculation):
(JSC::DFG::Graph::isPredictedNumerical):
(JSC::DFG::Graph::byValIsPure):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::getSpeculation):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::getHeapPrediction):
(JSC::DFG::Node::predictHeap):
(JSC::DFG::Node::prediction):
(JSC::DFG::Node::predict):
(JSC::DFG::Node::shouldSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateDouble):
(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldSpeculateBoolean):
(JSC::DFG::Node::shouldSpeculateFinalObject):
(JSC::DFG::Node::shouldSpeculateFinalObjectOrOther):
(JSC::DFG::Node::shouldSpeculateArray):
(JSC::DFG::Node::shouldSpeculateArguments):
(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):
(JSC::DFG::Node::shouldSpeculateInt32Array):
(JSC::DFG::Node::shouldSpeculateUint8Array):
(JSC::DFG::Node::shouldSpeculateUint8ClampedArray):
(JSC::DFG::Node::shouldSpeculateUint16Array):
(JSC::DFG::Node::shouldSpeculateUint32Array):
(JSC::DFG::Node::shouldSpeculateFloat32Array):
(JSC::DFG::Node::shouldSpeculateFloat64Array):
(JSC::DFG::Node::shouldSpeculateArrayOrOther):
(JSC::DFG::Node::shouldSpeculateObject):
(JSC::DFG::Node::shouldSpeculateCell):
(Node):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::setPrediction):
(JSC::DFG::PredictionPropagationPhase::mergePrediction):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayLength):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithMod):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
(JSC::DFG::SpeculativeJIT::compileRegExpExec):

  • dfg/DFGSpeculativeJIT.h:

(DFG):
(JSC::DFG::ValueSource::forSpeculation):
(SpeculativeJIT):
(GPRTemporary):
(FPRTemporary):
(JSC::DFG::SpecDoubleOperand::SpecDoubleOperand):
(JSC::DFG::SpecDoubleOperand::~SpecDoubleOperand):
(JSC::DFG::SpecDoubleOperand::fpr):
(JSC::DFG::SpecCellOperand::SpecCellOperand):
(JSC::DFG::SpecCellOperand::~SpecCellOperand):
(JSC::DFG::SpecCellOperand::gpr):
(JSC::DFG::SpecBooleanOperand::SpecBooleanOperand):
(JSC::DFG::SpecBooleanOperand::~SpecBooleanOperand):
(JSC::DFG::SpecBooleanOperand::gpr):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpecDouble):
(JSC::DFG::SpeculativeJIT::fillSpecCell):
(JSC::DFG::SpeculativeJIT::fillSpecBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpecDouble):
(JSC::DFG::SpeculativeJIT::fillSpecCell):
(JSC::DFG::SpeculativeJIT::fillSpecBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::predict):
(JSC::DFG::VariableAccessData::nonUnifiedPrediction):
(JSC::DFG::VariableAccessData::prediction):
(JSC::DFG::VariableAccessData::argumentAwarePrediction):
(JSC::DFG::VariableAccessData::mergeArgumentAwarePrediction):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::makePredictionForDoubleFormat):
(VariableAccessData):

6:28 PM Changeset in webkit [119659] by leviw@chromium.org
  • 18 edits
    3 adds in trunk

Use enclosingIntRect instead of pixelSnappedIntRect in RenderFileUploadControl
https://bugs.webkit.org/show_bug.cgi?id=88454

Reviewed by Kent Tamura.

Source/WebCore:

Properly clipping the file upload control to avoid clipping out the top of the file upload button
when the control is positioned at a sub-pixel offset that rounds up.

Test: fast/sub-pixel/file-upload-control-at-fractional-offset.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

Skipping new test on non-chromium platforms, and correcting a typo in several skipped files.
Also updating the bug number in the gtk skipped file to 85532 from 60318 to better reflect
the outstanding work of enabling each port to support sub-pixel layout, instead of sub-pixel
layout itself.

  • fast/sub-pixel/file-upload-control-at-fractional-offset.html: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/gtk-wk2/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
6:26 PM Changeset in webkit [119658] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1132

Merge 118955
BUG=129951
Review URL: https://chromiumcodereview.appspot.com/10543046

6:00 PM Changeset in webkit [119657] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Revert erroneous change in r119637.

  • platform/chromium/TestExpectations:
5:57 PM Changeset in webkit [119656] by cevans@google.com
  • 1 edit in branches/chromium/1132/Source/WebCore/dom/ContainerNodeAlgorithms.h

Revert 119622 - Merge 118096
BUG=128157
Review URL: https://chromiumcodereview.appspot.com/10545041

TBR=cevans@google.com
Review URL: https://chromiumcodereview.appspot.com/10543044

5:49 PM Changeset in webkit [119655] by fpizlo@apple.com
  • 33 edits
    4 adds in trunk/Source

Global object variable accesses should not require an extra load
https://bugs.webkit.org/show_bug.cgi?id=88385

Source/JavaScriptCore:

Reviewed by Gavin Barraclough and Geoffrey Garen.

Previously, if you wanted to access a global variable, you'd first have
to load the register array from the appropriate global object and then
either load or store at an offset to the register array. This is because
JSGlobalObject inherited from JSVariableObject, and JSVariableObject is
designed with the pessimistic assumption that its register array may
point into the call stack. This is never the case for global objects.
Hence, even though the global object may add more registers at any time,
it does not need to store them in a contiguous array. It can use a
SegmentedVector or similar.

This patch refactors global objects and variable objects as follows:

  • The functionality to track variables in an indexable array using a SymbolTable to map names to indices is moved into JSSymbolTableObject, which is now a supertype of JSVariableObject. JSVariableObject is now just a holder for a registers array and implements the registerAt() method that is left abstract in JSSymbolTableObject. Because all users of JSVariableObject know whether they are a JSStaticScopeObject, JSActivation, or JSGlobalObject, this "abstract" method is not virtual; instead the utility methods that would call registerAt() are now template functions that require you to know statically what subtype of JSSymbolTableObject you're using (JSVariableObject or something else), so that registerAt() can be statically bound.


  • A new class is added called JSSegmentedVariableObject, which only differs from JSVariableObject in how it allocates registers. It uses a SegmentedVector instead of manually managing a pointer to a contiguous slab of registers. This changes the interface somewhat; for example with JSVariableObject if you wanted to add a register you had to do it yourself since the JSVariableObject didn't know how the registers array ought to be allocated. With JSSegmentedVariableObject you can just call addRegisters(). JSSegmentedVariableObject preserves the invariant that once you get a pointer into a register, that pointer will continue to be valid so long as the JSSegmentedVariableObject is alive. This allows the JITs and interpreters to skip the extra load.


  • JSGlobalObject now inherits from JSSegmentedVariableObject. For now (and possibly forever) it is the only subtype of this new class.


  • The bytecode format is changed so that get_global_var and put_global_var have a pointer to the register directly rather than having an index. A convenience method is provided in JSSegmentedVariableObject to get the index given a a pointer, which is used for assertions and debug dumps.


This appears to be a 1% across the board win.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Instruction.h:

(Instruction):
(JSC::Instruction::Instruction):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::ResolveResult::registerPointer):
(JSC):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::retrieveLastUnaryOp):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
(JSC::BytecodeGenerator::emitGetStaticVar):
(JSC::BytecodeGenerator::emitPutStaticVar):

  • bytecompiler/BytecodeGenerator.h:

(ResolveResult):
(BytecodeGenerator):

  • dfg/DFGAssemblyHelpers.h:

(AssemblyHelpers):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::globalVarStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::globalObjectFor):
(Graph):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasVarNumber):
(Node):
(JSC::DFG::Node::hasRegisterPointer):
(JSC::DFG::Node::registerPointer):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • heap/Heap.h:

(Heap):
(JSC::Heap::isWriteBarrierEnabled):
(JSC):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSGlobalObject.cpp:

(JSC):
(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putDirectVirtual):
(JSC::JSGlobalObject::defineOwnProperty):
(JSC::JSGlobalObject::visitChildren):
(JSC::JSGlobalObject::addStaticGlobals):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::JSGlobalObject):
(JSC):
(JSC::JSGlobalObject::hasOwnPropertyForWrite):

  • runtime/JSSegmentedVariableObject.cpp: Added.

(JSC):
(JSC::JSSegmentedVariableObject::findRegisterIndex):
(JSC::JSSegmentedVariableObject::addRegisters):
(JSC::JSSegmentedVariableObject::visitChildren):

  • runtime/JSSegmentedVariableObject.h: Added.

(JSC):
(JSSegmentedVariableObject):
(JSC::JSSegmentedVariableObject::registerAt):
(JSC::JSSegmentedVariableObject::assertRegisterIsInThisObject):
(JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):
(JSC::JSSegmentedVariableObject::finishCreation):

  • runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putDirectVirtual):
(JSC::JSStaticScopeObject::getOwnPropertySlot):

  • runtime/JSSymbolTableObject.cpp: Added.

(JSC):
(JSC::JSSymbolTableObject::destroy):
(JSC::JSSymbolTableObject::deleteProperty):
(JSC::JSSymbolTableObject::getOwnPropertyNames):
(JSC::JSSymbolTableObject::putDirectVirtual):
(JSC::JSSymbolTableObject::isDynamicScope):

  • runtime/JSSymbolTableObject.h: Added.

(JSC):
(JSSymbolTableObject):
(JSC::JSSymbolTableObject::symbolTable):
(JSC::JSSymbolTableObject::JSSymbolTableObject):
(JSC::JSSymbolTableObject::finishCreation):
(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/JSVariableObject.cpp:

(JSC):

  • runtime/JSVariableObject.h:

(JSVariableObject):
(JSC::JSVariableObject::JSVariableObject):
(JSC::JSVariableObject::finishCreation):
(JSC):

  • runtime/WriteBarrier.h:

Source/WebCore:

Reviewed by Gavin Barraclough and Geoffrey Garen.

Updated JSDOMWindowBase.cpp to use the new symbol table API. this->symbolTableFoo(...)
becomes symbolTableFoo(this, ...).

No new tests because no change in behavior.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::updateDocument):

5:49 PM Changeset in webkit [119654] by dpranke@chromium.org
  • 4 edits
    1 add in trunk/Tools

webkitpy: add support for an ordered dict of test expectations
https://bugs.webkit.org/show_bug.cgi?id=87802

Reviewed by Ojan Vafai.

As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
support a cascaded list of test expectations files. An easy way
to think of this is as an ordered dictionary of name -> contents
for files, where the name is usually a path on disk (I say
usually because we want to support other kinds of expectations
like the compile-time skips for unsupported features in
webkit.py, and we want to continue to support "in-memory" test
expectations that don't require a filesystem).

Conveniently there is an OrderedDict implementation in Python
2.7+ and it is available as a backport, so the first step in
adding this support is to use that implementation. Subsequent
patches will update the test_expectations.py module (and other
callers) to access the dict directly.

This patch just changes the base internal implementation and
provides wrappers for compatibility. The derived ports
(WebKitPort, TestPort, etc.) still need to be updated.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._expectations_dict):
(Port.test_expectations):
(Port):
(Port._expectations_overrides_dict):
(Port.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_expectations_ordering):
(PortTestCase):
(PortTestCase.test_expectations_overrides_ordering):

  • Scripts/webkitpy/thirdparty/ordered_dict.py: Added.

(OrderedDict):
(OrderedDict.init):
(OrderedDict.clear):
(OrderedDict.setitem):
(OrderedDict.delitem):
(OrderedDict.iter):
(OrderedDict.reversed):
(OrderedDict.popitem):
(OrderedDict.reduce):
(OrderedDict.repr):
(OrderedDict.copy):
(OrderedDict.fromkeys):

5:39 PM Changeset in webkit [119653] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] ASSERT(m_manualStream) failed in PluginView::didFinishLoading running
fast/loader/reload-zero-byte-plugin.html

Skip another affected test on Windows to get the bots greener.

  • platform/win/Skipped:
5:39 PM Changeset in webkit [119652] by mario@webkit.org
  • 2 edits in trunk/Tools

Unreviewed gardening. Unit test fails on GTK 64bit debug bot.

  • gtk/run-api-tests:

(TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.

5:38 PM Changeset in webkit [119651] by jamesr@google.com
  • 4 edits
    4 moves in trunk/Source

[chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit/chromium/src to WebCore/platform/chromium/support
https://bugs.webkit.org/show_bug.cgi?id=86257

Reviewed by Kenneth Russell.

Source/WebCore:

The WebCore platform interfaces GraphicsContext3D and Extensions3DChromium are implemented in chromium
on top of the Platform interface WebGraphicsContext3D. This moves the implementation support code from
WebKit/chromium/src to WebCore/platform/chromium/support, which avoids having code in WebKit/ implementing WebCore
interfaces and allows code in WebCore/platform to use this support code directly where appropriate.

Refactor only, no new functionality or tests.

  • WebCore.gypi:
  • platform/chromium/support/Extensions3DChromium.cpp: Renamed from Source/WebKit/chromium/src/Extensions3DChromium.cpp.

(WebCore):
(WebCore::Extensions3DChromium::Extensions3DChromium):
(WebCore::Extensions3DChromium::~Extensions3DChromium):
(WebCore::Extensions3DChromium::supports):
(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::isEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::createVertexArrayOES):
(WebCore::Extensions3DChromium::deleteVertexArrayOES):
(WebCore::Extensions3DChromium::isVertexArrayOES):
(WebCore::Extensions3DChromium::bindVertexArrayOES):
(WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::paintFramebufferToCanvas):
(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
(WebCore::Extensions3DChromium::texStorage2DEXT):
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):

  • platform/chromium/support/GraphicsContext3DChromium.cpp: Renamed from Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp.

(WebCore):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):

  • platform/chromium/support/GraphicsContext3DPrivate.cpp: Renamed from Source/WebKit/chromium/src/GraphicsContext3DPrivate.cpp.

(WebCore):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(GraphicsContext3DContextLostCallbackAdapter):
(WebCore::GraphicsContext3DContextLostCallbackAdapter::GraphicsContext3DContextLostCallbackAdapter):
(WebCore::GraphicsContext3DContextLostCallbackAdapter::~GraphicsContext3DContextLostCallbackAdapter):
(WebCore::GraphicsContext3DContextLostCallbackAdapter::onContextLost):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(GraphicsContext3DErrorMessageCallbackAdapter):
(WebCore::GraphicsContext3DErrorMessageCallbackAdapter::GraphicsContext3DErrorMessageCallbackAdapter):
(WebCore::GraphicsContext3DErrorMessageCallbackAdapter::~GraphicsContext3DErrorMessageCallbackAdapter):
(WebCore::GraphicsContext3DErrorMessageCallbackAdapter::onErrorMessage):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):

  • platform/chromium/support/GraphicsContext3DPrivate.h: Renamed from Source/WebKit/chromium/src/GraphicsContext3DPrivate.h.

(WebKit):
(WebCore):
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::webContext):
(WebCore::GraphicsContext3DPrivate::preserveDrawingBuffer):

Source/WebKit/chromium:

  • WebKit.gyp:
5:37 PM Changeset in webkit [119650] by rniwa@webkit.org
  • 115 edits
    38 adds
    1 delete in trunk/LayoutTests

Chromium rebaseline after r119617 part 5.

  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug101759-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug22122-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core/columns-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11944-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug16252-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug22019-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2947-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43039-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug650-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-linux/tables/mozilla/core/borders-expected.png:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_fix-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
  • platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-linux/tables/mozilla/other/test6-expected.png:
  • platform/chromium-linux/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug101759-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug19526-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug22122-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core/col_span2-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/core/columns-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/other: Added.
  • platform/chromium-win-vista/tables/mozilla_expected_failures/other/empty_cells-expected.png: Added.
  • platform/chromium-win-xp/tables/mozilla/bugs/bug131020-expected.png: Removed.
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug10269-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug113235-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug22019-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug38916-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug50695-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56405-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7112-1-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug7112-2-expected.png:
  • platform/chromium-win/tables/mozilla/core/borders-expected.png:
  • platform/chromium-win/tables/mozilla/core/captions-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_span-expected.png:
  • platform/chromium-win/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-win/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-win/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/other/empty_cells-expected.png:
5:31 PM Changeset in webkit [119649] by dpranke@chromium.org
  • 10 edits in trunk/Tools

nrwt should look in 'out' for binaries on chromium win to support ninja
https://bugs.webkit.org/show_bug.cgi?id=88273

Reviewed by Tony Chang.

This patch standardizes the search algorithm the chromium ports
use to figure out which driver to run. We will look in a
chromium location before a webkit location (e.g., in
Source/WebKit/chromium/out before out/) and we will look in the
"legacy" directory (xcodebuild) before the directory ninja uses
(out).

Unfortunately due to the way the test code is set up testing the
properly requires some duplication of test code. I will fix that
in a followup patch.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort):
(ChromiumPort._static_build_path):
(ChromiumPort._build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort):
(ChromiumLinuxPort._determine_driver_path_statically):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_build_path):
(ChromiumLinuxPortTest):
(ChromiumLinuxPortTest.test_driver_name_option):
(ChromiumLinuxPortTest.path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_build_path):
(ChromiumMacPortTest):
(ChromiumMacPortTest.test_driver_name_option):
(ChromiumMacPortTest.path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_overrides_and_builder_names):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_build_path):
(ChromiumWinTest.test_operating_system):
(ChromiumWinTest):
(ChromiumWinTest.test_driver_name_option):
(ChromiumWinPortTest.path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.assert_build_path):

5:27 PM Changeset in webkit [119648] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r119624.
http://trac.webkit.org/changeset/119624
https://bugs.webkit.org/show_bug.cgi?id=88472

Caused worker tests to become flaky (Requested by mhahnenberg
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-06

  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::~AbstractWorker):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::workerObjectDestroyed):

5:23 PM Changeset in webkit [119647] by fpizlo@apple.com
  • 8 edits
    6 adds in trunk

DFG arguments access slow path should not crash if the arguments haven't been created
https://bugs.webkit.org/show_bug.cgi?id=88471

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

  • fast/js/dfg-arguments-out-of-bounds-expected.txt: Added.
  • fast/js/dfg-arguments-out-of-bounds.html: Added.
  • fast/js/dfg-inline-arguments-out-of-bounds-expected.txt: Added.
  • fast/js/dfg-inline-arguments-out-of-bounds.html: Added.
  • fast/js/script-tests/dfg-arguments-out-of-bounds.js: Added.

(foo.bar):
(foo):

  • fast/js/script-tests/dfg-inline-arguments-out-of-bounds.js: Added.

(foo):
(bar):

5:20 PM Changeset in webkit [119646] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/1132

Merge 119409
BUG=130369
Review URL: https://chromiumcodereview.appspot.com/10546039

5:13 PM Changeset in webkit [119645] by rniwa@webkit.org
  • 132 edits
    11 adds
    1 delete in trunk/LayoutTests

Chromium rebaseline after r119617 part 4.

  • platform/chromium-linux-x86/fast/text/international: Added.
  • platform/chromium-linux-x86/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/chromium-linux-x86/ietestcenter: Added.
  • platform/chromium-linux-x86/ietestcenter/css3: Added.
  • platform/chromium-linux-x86/ietestcenter/css3/bordersbackgrounds: Added.
  • platform/chromium-linux-x86/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/compositing: Removed.
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-european-terminators-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.png:
  • platform/chromium-linux/fast/text/softHyphen-expected.png:
  • platform/chromium-linux/fast/text/wbr-expected.png:
  • platform/chromium-linux/fast/text/whitespace/024-expected.png:
  • platform/chromium-linux/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/chromium-linux/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-linux/fonts/cursive-expected.png:
  • platform/chromium-linux/fonts/default-expected.png:
  • platform/chromium-linux/fonts/fantasy-expected.png:
  • platform/chromium-linux/fonts/serif-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/chromium-linux/media/video-zoom-expected.png:
  • platform/chromium-linux/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-linux/platform/chromium/media/video-frame-size-change-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-linux/printing/return-from-printing-mode-expected.png:
  • platform/chromium-linux/scrollbars/basic-scrollbar-expected.png:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/scrollbars/scrollbar-orientation-expected.png:
  • platform/chromium-linux/svg/custom/altglyph-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.png:
  • platform/chromium-linux/svg/dom/SVGLengthList-insertItemBefore-expected.png:
  • platform/chromium-linux/svg/dom/SVGLengthList-replaceItem-expected.png:
  • platform/chromium-linux/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/chromium-linux/svg/dom/SVGPathSegList-appendItem-expected.png:
  • platform/chromium-linux/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/chromium-linux/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
  • platform/chromium-linux/svg/dom/SVGPathSegList-removeItem-expected.png:
  • platform/chromium-linux/svg/dom/SVGPathSegList-replaceItem-expected.png:
  • platform/chromium-linux/svg/dom/SVGPointList-basics-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/chromium-linux/svg/text/multichar-glyph-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-mac-leopard/media/video-zoom-expected.png:
  • platform/chromium-mac-leopard/scrollbars/basic-scrollbar-expected.png:
  • platform/chromium-mac-leopard/scrollbars/disabled-scrollbar-expected.png:
  • platform/chromium-mac-leopard/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-leopard/scrollbars/scrollbar-orientation-expected.png:
  • platform/chromium-mac-snowleopard/media/video-zoom-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/basic-scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/disabled-scrollbar-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/scrollbar-orientation-expected.png:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/img-layer-grow-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-mac/scrollbars/basic-scrollbar-expected.png:
  • platform/chromium-mac/scrollbars/disabled-scrollbar-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/scrollbar-orientation-expected.png:
  • platform/chromium-win-vista/platform/chromium/compositing: Added.
  • platform/chromium-win-vista/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/compositing: Added.
  • platform/chromium-win-xp/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-win/fast/text/international/bidi-european-terminators-expected.png:
  • platform/chromium-win/fast/text/word-break-expected.png:
  • platform/chromium-win/fast/writing-mode/fieldsets-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/chromium-win/media/video-zoom-expected.png:
  • platform/chromium-win/platform/chromium/compositing/img-layer-grow-expected.png: Added.
  • platform/chromium-win/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-win/platform/chromium/media/video-frame-size-change-expected.png:
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-win/scrollbars/basic-scrollbar-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/scrollbars/scrollbar-orientation-expected.png:
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-win/svg/custom/altglyph-expected.png:
  • platform/chromium-win/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/chromium-win/svg/custom/junk-data-expected.png:
  • platform/chromium-win/svg/custom/missing-xlink-expected.png:
  • platform/chromium-win/svg/custom/path-bad-data-expected.png:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-win/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/chromium-win/svg/custom/use-font-face-crash-expected.png:
  • platform/chromium-win/svg/dom/SVGLengthList-initialize-expected.png:
  • platform/chromium-win/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
  • platform/chromium-win/svg/dom/SVGNumberList-basics-expected.png:
  • platform/chromium-win/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/chromium-win/svg/hixie/error/012-expected.png:
  • platform/chromium-win/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/chromium-win/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/chromium-win/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/chromium-win/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/chromium-win/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/chromium-win/svg/repaint/image-with-clip-path-expected.png:
  • platform/chromium-win/svg/text/multichar-glyph-expected.png:
5:10 PM Changeset in webkit [119644] by beidson@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/11575112> and https://bugs.webkit.org/show_bug.cgi?id=88428
REGRESSION (r115654): Opening many non-English WebArchives shows obvious encoding issues

Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/loader/webarchive-encoding-respected.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData): Properly set the main resource encoding from the webarchive.

LayoutTests:

  • fast/loader/resources/utf8-encoded.webarchive: Added.
  • fast/loader/webarchive-encoding-respected-expected.txt: Added.
  • fast/loader/webarchive-encoding-respected.html: Added.
5:10 PM Changeset in webkit [119643] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 119227
BUG=130723
Review URL: https://chromiumcodereview.appspot.com/10543041

5:09 PM Changeset in webkit [119642] by dgrogan@chromium.org
  • 6 edits
    2 adds in branches/chromium/1132/Source

Re-Merge 117978

original bug at https://bugs.webkit.org/show_bug.cgi?id=85579

BUG=130671
Review URL: https://chromiumcodereview.appspot.com/10535043

5:07 PM Changeset in webkit [119641] by mrowe@apple.com
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merge r119570.

5:06 PM Changeset in webkit [119640] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 119050
BUG=130235
Review URL: https://chromiumcodereview.appspot.com/10539032

5:03 PM Changeset in webkit [119639] by mrowe@apple.com
  • 4 edits in branches/safari-536-branch/Source/WebCore

Merge r119548.

5:01 PM Changeset in webkit [119638] by mrowe@apple.com
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merge r119535.

4:48 PM Changeset in webkit [119637] by rniwa@webkit.org
  • 180 edits
    29 adds
    2 deletes in trunk/LayoutTests

Chromium rebaseline after r119617 part 3.

  • platform/chromium-linux-x86/fast/images: Removed.
  • platform/chromium-linux-x86/fast/media: Removed.
  • platform/chromium-linux-x86/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-linux/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-linux/fast/forms/form-hides-table-expected.png:
  • platform/chromium-linux/fast/forms/textAreaLineHeight-expected.png:
  • platform/chromium-linux/fast/frames/frame-scrolling-attribute-expected.png:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-linux/fast/images/gif-large-checkerboard-expected.png:
  • platform/chromium-linux/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/chromium-linux/fast/invalid/residual-style-expected.png:
  • platform/chromium-linux/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png:
  • platform/chromium-linux/fast/lists/001-vertical-expected.png:
  • platform/chromium-linux/fast/lists/li-br-expected.png:
  • platform/chromium-linux/fast/lists/ol-start-parsing-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.png:
  • platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.png:
  • platform/chromium-linux/fast/multicol/column-rules-stacking-expected.png:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.png:
  • platform/chromium-linux/fast/multicol/float-paginate-expected.png:
  • platform/chromium-linux/fast/multicol/layers-split-across-columns-expected.png:
  • platform/chromium-linux/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-linux/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/column-rules-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/column-rules-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-linux/fast/overflow/005-expected.png:
  • platform/chromium-linux/fast/overflow/008-expected.png:
  • platform/chromium-linux/fast/overflow/childFocusRingClip-expected.png:
  • platform/chromium-linux/fast/overflow/clip-rects-fixed-ancestor-expected.png:
  • platform/chromium-linux/fast/overflow/float-in-relpositioned-expected.png:
  • platform/chromium-linux/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-auto-position-absolute-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-stacking-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-text-hit-testing-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
  • platform/chromium-linux/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/chromium-linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-linux/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-linux/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png:
  • platform/chromium-linux/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png:
  • platform/chromium-linux/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-linux/fast/table/023-expected.png:
  • platform/chromium-linux/fast/table/027-vertical-expected.png:
  • platform/chromium-linux/fast/table/034-expected.png:
  • platform/chromium-linux/fast/table/040-expected.png:
  • platform/chromium-linux/fast/table/040-vertical-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-linux/fast/table/height-percent-test-expected.png:
  • platform/chromium-linux/fast/table/height-percent-test-vertical-expected.png:
  • platform/chromium-linux/fast/table/table-display-types-vertical-expected.png:
  • platform/chromium-linux/fast/table/wide-colspan-expected.png:
  • platform/chromium-linux/fast/table/wide-column-expected.png:
  • platform/chromium-mac/fast/frames/transparent-scrollbar-expected.png:
  • platform/chromium-win-vista/fast/multicol: Added.
  • platform/chromium-win-vista/fast/multicol/span: Added.
  • platform/chromium-win-vista/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-lr: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-win/fast/forms/basic-textareas-expected.png:
  • platform/chromium-win/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-win/fast/forms/button-default-title-expected.png:
  • platform/chromium-win/fast/forms/form-hides-table-expected.png:
  • platform/chromium-win/fast/forms/textAreaLineHeight-expected.png:
  • platform/chromium-win/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-win/fast/frames/inline-object-inside-frameset-expected.png:
  • platform/chromium-win/fast/frames/transparent-scrollbar-expected.png:
  • platform/chromium-win/fast/gradients/css3-color-stop-units-expected.png:
  • platform/chromium-win/fast/images/gif-large-checkerboard-expected.png:
  • platform/chromium-win/fast/images/gray-scale-jpeg-with-color-profile-expected.png:
  • platform/chromium-win/fast/inline-block/tricky-baseline-expected.png:
  • platform/chromium-win/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/chromium-win/fast/inline/long-wrapped-line-expected.png:
  • platform/chromium-win/fast/invalid/residual-style-expected.png:
  • platform/chromium-win/fast/layers/overflow-scroll-auto-switch-expected.png:
  • platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png:
  • platform/chromium-win/fast/lists/001-expected.png:
  • platform/chromium-win/fast/lists/001-vertical-expected.png:
  • platform/chromium-win/fast/lists/li-br-expected.png:
  • platform/chromium-win/fast/lists/ol-start-parsing-expected.png:
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/chromium-win/fast/multicol/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/float-paginate-expected.png:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-win/fast/multicol/layers-split-across-columns-expected.png:
  • platform/chromium-win/fast/multicol/overflow-unsplittable-expected.png:
  • platform/chromium-win/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-win/fast/multicol/scrolling-overflow-expected.png:
  • platform/chromium-win/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
  • platform/chromium-win/fast/overflow/003-expected.png:
  • platform/chromium-win/fast/overflow/005-expected.png:
  • platform/chromium-win/fast/overflow/007-expected.png:
  • platform/chromium-win/fast/overflow/008-expected.png:
  • platform/chromium-win/fast/overflow/float-in-relpositioned-expected.png:
  • platform/chromium-win/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-win/fast/overflow/overflow-stacking-expected.png:
  • platform/chromium-win/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/chromium-win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/chromium-win/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-win/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/chromium-win/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/chromium-win/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/chromium-win/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium-win/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-win/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/chromium-win/fast/repaint/scroll-inside-table-cell-expected.png:
  • platform/chromium-win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/chromium-win/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/chromium-win/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/chromium-win/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png:
  • platform/chromium-win/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png:
  • platform/chromium-win/fast/table/027-vertical-expected.png:
  • platform/chromium-win/fast/table/034-expected.png:
  • platform/chromium-win/fast/table/038-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/004-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png:
  • platform/chromium-win/fast/table/edge-offsets-expected.png:
  • platform/chromium-win/fast/table/empty-cells-expected.png:
  • platform/chromium-win/fast/table/frame-and-rules-expected.png:
  • platform/chromium-win/fast/table/overflowHidden-expected.png:
  • platform/chromium-win/fast/table/table-display-types-expected.png:
  • platform/chromium-win/fast/table/table-display-types-vertical-expected.png:
  • platform/chromium-win/fast/table/wide-colspan-expected.png:
  • platform/chromium-win/fast/table/wide-column-expected.png:
  • platform/chromium/TestExpectations:
4:42 PM Changeset in webkit [119636] by jberlin@webkit.org
  • 2 edits in trunk/Tools

Remove very red Windows WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=88452

Reviewed by Steve Falkenburg.

Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
need to focus on getting the WK1 testers green.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:21 PM Changeset in webkit [119635] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Unreviewed build fix, add an apparently used include of OwnArrayPtr.h back to GraphicsContext3DPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=88468

  • src/GraphicsContext3DPrivate.h:
4:21 PM Changeset in webkit [119634] by rniwa@webkit.org
  • 120 edits
    8 adds
    2 deletes in trunk/LayoutTests

Chromium rebaseline after r119617 part 2.

  • fast/block/float/021-expected.txt: Added.
  • platform/chromium-linux-x86/fast/block/positioning/auto: Added.
  • platform/chromium-linux-x86/fast/block/positioning/auto/vertical-lr: Added.
  • platform/chromium-linux-x86/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
  • platform/chromium-linux-x86/fast/block/positioning/auto/vertical-rl: Added.
  • platform/chromium-linux-x86/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/block/float/019-expected.png:
  • platform/chromium-linux/fast/block/float/021-expected.png:
  • platform/chromium-linux/fast/block/float/025-expected.png:
  • platform/chromium-linux/fast/block/float/026-expected.png:
  • platform/chromium-linux/fast/block/float/027-expected.png:
  • platform/chromium-linux/fast/block/float/028-expected.png:
  • platform/chromium-linux/fast/block/float/033-expected.png:
  • platform/chromium-linux/fast/block/float/avoidance-percent-width-strict-expected.png:
  • platform/chromium-linux/fast/block/float/centered-float-avoidance-complexity-expected.png:
  • platform/chromium-linux/fast/block/float/nested-clearance-expected.png:
  • platform/chromium-linux/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
  • platform/chromium-linux/fast/block/lineboxcontain/parsing-invalid-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/chromium-linux/fast/block/positioning/047-expected.png:
  • platform/chromium-linux/fast/block/positioning/055-expected.png:
  • platform/chromium-linux/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/chromium-linux/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/chromium-linux/fast/block/positioning/negative-rel-position-expected.png:
  • platform/chromium-linux/fast/block/positioning/relative-overflow-block-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/002-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/003-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/004-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/007-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/chromium-linux/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-linux/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-linux/fast/css/005-expected.png:
  • platform/chromium-linux/fast/css/bidi-override-in-anonymous-block-expected.png:
  • platform/chromium-linux/fast/css/clip-text-in-scaled-div-expected.png:
  • platform/chromium-linux/fast/css/first-child-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/font_property_normal-expected.png:
  • platform/chromium-linux/fast/css/last-child-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/nested-floating-relative-position-percentages-expected.png:
  • platform/chromium-linux/fast/css/only-child-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png:
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png:
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png:
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-expected.png:
  • platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png:
  • platform/chromium-linux/fast/css/text-overflow-ellipsis-expected.png:
  • platform/chromium-linux/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/chromium-linux/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/chromium-linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png:
  • platform/chromium-linux/fast/dom/scroll-reveal-top-overflow-expected.png:
  • platform/chromium-linux/fast/dynamic/008-expected.png:
  • platform/chromium-linux/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-linux/fast/events/resize-events-expected.png:
  • platform/chromium-linux/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/chromium-linux/fast/flexbox/016-expected.png:
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
  • platform/chromium-win-vista/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
  • platform/chromium-win-xp/fast/dom/34176-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.png:
  • platform/chromium-win/fast/block/float/008-expected.png:
  • platform/chromium-win/fast/block/float/021-expected.png:
  • platform/chromium-win/fast/block/float/021-expected.txt:
  • platform/chromium-win/fast/block/float/032-expected.png:
  • platform/chromium-win/fast/block/float/avoidance-percent-width-strict-expected.png:
  • platform/chromium-win/fast/block/float/br-with-clear-2-expected.png:
  • platform/chromium-win/fast/block/float/nested-clearance-expected.png:
  • platform/chromium-win/fast/block/margin-collapse/104-expected.png:
  • platform/chromium-win/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/chromium-win/fast/block/positioning/047-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/chromium-win/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/chromium-win/fast/block/positioning/negative-rel-position-expected.png:
  • platform/chromium-win/fast/block/positioning/relative-overflow-replaced-expected.png:
  • platform/chromium-win/fast/block/positioning/relative-overflow-replaced-float-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-lr/002-expected.png:
  • platform/chromium-win/fast/block/positioning/vertical-rl/002-expected.png:
  • platform/chromium-win/fast/borders/border-image-massive-scale-expected.png:
  • platform/chromium-win/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-01-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-02-expected.png:
  • platform/chromium-win/fast/borders/rtl-border-03-expected.png:
  • platform/chromium-win/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-win/fast/clip/014-expected.png:
  • platform/chromium-win/fast/css/clip-text-in-scaled-div-expected.png:
  • platform/chromium-win/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/font_property_normal-expected.png:
  • platform/chromium-win/fast/css/hsl-color-expected.png:
  • platform/chromium-win/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/nested-floating-relative-position-percentages-expected.png:
  • platform/chromium-win/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/chromium-win/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png:
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png:
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png:
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-expected.png:
  • platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png:
  • platform/chromium-win/fast/css/word-space-extra-expected.png:
  • platform/chromium-win/fast/dom/34176-expected.png:
  • platform/chromium-win/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png:
  • platform/chromium-win/fast/dom/scroll-reveal-left-overflow-expected.png:
  • platform/chromium-win/fast/dynamic/window-resize-scrollbars-test-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-win/fast/events/pointer-events-2-expected.png:
  • platform/chromium-win/fast/events/resize-events-expected.png:
  • platform/chromium-win/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/chromium-win/fast/flexbox/016-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/fast/block/float/021-expected.txt: Removed.
  • platform/gtk/fast/block/float/021-expected.txt: Removed.
4:11 PM Changeset in webkit [119633] by msaboff@apple.com
  • 14 edits in trunk/Source

ENH: Add Logging to GC Marking Phase
https://bugs.webkit.org/show_bug.cgi?id=88364

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Log GC marking to stderr or a file. The logging in controlled
with the define ENABLE_OBJECT_MARK_LOGGING in wtf/Platform.h.
If DATA_LOG_TO_FILE in wtf/DataLog.cpp is set to 1, output is
logged to a file otherwise it is logged to stderr.

When logging is enabled, the GC is built single threaded since the
log output from the various threads isn't buffered and output in a
thread safe manner.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • heap/MarkStack.cpp:

(JSC::MarkStackThreadSharedData::resetChildren):
(JSC::MarkStackThreadSharedData::childVisitCount):
(JSC::MarkStackThreadSharedData::markingThreadMain):
(JSC::MarkStackThreadSharedData::markingThreadStartFunc):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):

  • heap/MarkStack.h:

(MarkStackThreadSharedData):
(MarkStack):
(JSC::MarkStack::sharedData):
(JSC::MarkStack::resetChildCount):
(JSC::MarkStack::childCount):
(JSC::MarkStack::incrementChildCount):

  • runtime/JSArray.cpp:

(JSC::JSArray::visitChildren):

  • runtime/JSCell.cpp:

(JSC::JSCell::className):

  • runtime/JSCell.h:

(JSCell):
(JSC::JSCell::visitChildren):

  • runtime/JSString.cpp:

(JSC::JSString::visitChildren):

  • runtime/JSString.h:

(JSString):

  • runtime/Structure.h:

(JSC::MarkStack::internalAppend):

Source/WTF:

  • wtf/DataLog.cpp:

(WTF::dataLogString): Additional method to support GC Mark logging.

  • wtf/DataLog.h:
  • wtf/Platform.h: New ENABLE_OBJECT_MARK_LOGGING flag macro.
4:04 PM Changeset in webkit [119632] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 118816
BUG=129947
Review URL: https://chromiumcodereview.appspot.com/10533037

3:59 PM Changeset in webkit [119631] by jamesr@google.com
  • 5 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Clean up GraphicsContext3D implementation
https://bugs.webkit.org/show_bug.cgi?id=88460

Reviewed by Kenneth Russell.

Chromium's implementation of the GraphicsContext3D implementation has been somewhat messy for historical
reasons. The actual implementation of the majority of these functions is done by delegating to the Platform API
WebGraphicsContext3D. A few bits of functionality - extension mapping, some compositor functionality, a readback
utility - are implemented by code in WebKit. Previously, all GraphicsContext3D functions delegates to a clone of
the interface in GraphicsContext3DPrivate which in turn delegated to WebGraphicsContext3D. This required
duplicating the entire GraphicsContext3D interface and made updating the interface an epic pain in the rear.

This patch provides the implementations of GraphicsContext3D functions in GraphicsContext3DChromium.cpp. Most of
these functions delegate directly to WebGraphicsContext3D. The ones that do not delegate to
GraphicsContext3DPrivate, which now has a dedicated header and cpp file. GraphicsContext3DPrivate.cpp implements
all GraphicsContext3DPrivate functions. I've also reordered the implementation files so that the function order
matches the associated header file and normalized the names of callback adapters.

Refactor only, no change in functionality. Existing tests apply.

  • WebKit.gyp:
  • src/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::ensureEnabled):
(WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
(WebCore::Extensions3DChromium::blitFramebuffer):
(WebCore::Extensions3DChromium::renderbufferStorageMultisample):
(WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
(WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
(WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
(WebCore::Extensions3DChromium::discardFramebufferEXT):
(WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
(WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
(WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
(WebCore::Extensions3DChromium::texStorage2DEXT):
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):

  • src/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::setContextLostCallback):
(WebCore::GraphicsContext3D::setErrorMessageCallback):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
(WebCore::GraphicsContext3D::platformTexture):
(WebCore::GraphicsContext3D::grContext):
(WebCore::GraphicsContext3D::platformLayer):
(WebCore):
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3D::isResourceSafe):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::getContextAttributes):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getString):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::markContextChanged):
(WebCore::GraphicsContext3D::layerComposited):
(WebCore::GraphicsContext3D::markLayerComposited):
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
(WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::getInternalFramebufferSize):

  • src/GraphicsContext3DPrivate.cpp: Added.

(WebCore):
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
(GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
(WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::markContextChanged):
(WebCore::GraphicsContext3DPrivate::layerComposited):
(WebCore::GraphicsContext3DPrivate::markLayerComposited):
(WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
(GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter):
(WebCore::GraphicsContextLostCallbackAdapter::onContextLost):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter):
(WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
(WebCore::GraphicsContext3DPrivate::getExtensions):
(WebCore::GraphicsContext3DPrivate::initializeExtensions):
(WebCore::GraphicsContext3DPrivate::supportsExtension):
(WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
(WebCore::GraphicsContext3DPrivate::isResourceSafe):
(GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
(WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
(WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):

  • src/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::webContext):
(WebCore::GraphicsContext3DPrivate::preserveDrawingBuffer):

3:58 PM Changeset in webkit [119630] by rniwa@webkit.org
  • 133 edits
    11 adds
    7 deletes in trunk/LayoutTests

Chromium rebaseline after r119617 part 1.

  • platform/chromium-linux-x86/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-linux-x86/css2.1/20110323: Removed.
  • platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-linux/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-linux/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-linux/compositing/scaling: Removed.
  • platform/chromium-linux/css1/basic/comments-expected.png:
  • platform/chromium-linux/css1/box_properties/border_left_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_right_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_style-expected.png:
  • platform/chromium-linux/css1/box_properties/border_top_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_width-expected.png:
  • platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-linux/css1/box_properties/margin-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_top-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_bottom-expected.png:
  • platform/chromium-linux/css1/box_properties/width-expected.png:
  • platform/chromium-linux/css1/color_and_background/background-expected.png:
  • platform/chromium-linux/css1/color_and_background/background_position-expected.png:
  • platform/chromium-linux/css1/font_properties/font-expected.png:
  • platform/chromium-linux/css1/font_properties/font_size-expected.png:
  • platform/chromium-linux/css1/font_properties/font_weight-expected.png:
  • platform/chromium-linux/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-linux/css1/pseudo/firstletter-expected.png:
  • platform/chromium-linux/css1/pseudo/firstline-expected.png:
  • platform/chromium-linux/css1/text_properties/letter_spacing-expected.png:
  • platform/chromium-linux/css1/text_properties/line_height-expected.png:
  • platform/chromium-linux/css1/text_properties/text_decoration-expected.png:
  • platform/chromium-linux/css1/text_properties/text_transform-expected.png:
  • platform/chromium-linux/css1/text_properties/word_spacing-expected.png:
  • platform/chromium-linux/css1/units/color_units-expected.png:
  • platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.png:
  • platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
  • platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-expected.png:
  • platform/chromium-linux/css2.1/20110323/block-non-replaced-height-016-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
  • platform/chromium-linux/css2.1/t1202-counters-08-b-expected.png:
  • platform/chromium-linux/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/chromium-linux/editing/inserting/typing-at-end-of-line-expected.png:
  • platform/chromium-linux/editing/selection/focus_editable_html-expected.png:
  • platform/chromium-linux/editing/selection/select-all-003-expected.png:
  • platform/chromium-linux/editing/selection/select-all-004-expected.png:
  • platform/chromium-mac-leopard/compositing/masks/multiple-masks-expected.png: Removed.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Removed.
  • platform/chromium-mac-snowleopard/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-mac-snowleopard/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-mac-snowleopard/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-mac/compositing/culling/filter-occlusion-alpha-large-expected.png: Added.
  • platform/chromium-mac/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-mac/compositing/iframes/scroll-fixed-transformed-element-expected.png:
  • platform/chromium-mac/compositing/iframes/scroll-grandchild-iframe-expected.png: Added.
  • platform/chromium-mac/compositing/layer-creation/fixed-position-and-transform-expected.png: Added.
  • platform/chromium-mac/compositing/layer-creation/fixed-position-scroll-expected.png:
  • platform/chromium-mac/compositing/layer-creation/fixed-position-under-transform-expected.png: Added.
  • platform/chromium-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-mac/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-win-vista/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win-vista/css1/formatting_model/inline_elements-expected.png: Removed.
  • platform/chromium-win-vista/css1/formatting_model/replaced_elements-expected.png: Added.
  • platform/chromium-win-xp/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win-xp/css1/formatting_model: Removed.
  • platform/chromium-win-xp/css1/formatting_model/inline_elements-expected.png: Removed.
  • platform/chromium-win/compositing/culling/filter-occlusion-alpha-large-expected.png: Added.
  • platform/chromium-win/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/compositing/iframes/scroll-fixed-transformed-element-expected.png:
  • platform/chromium-win/compositing/iframes/scroll-grandchild-iframe-expected.png: Added.
  • platform/chromium-win/compositing/layer-creation/fixed-position-and-transform-expected.png: Added.
  • platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.png:
  • platform/chromium-win/compositing/layer-creation/fixed-position-under-transform-expected.png: Added.
  • platform/chromium-win/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-win/compositing/masks/multiple-masks-expected.png:
  • platform/chromium-win/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-win/compositing/overflow/overflow-scroll-expected.png:
  • platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-win/css1/basic/comments-expected.png:
  • platform/chromium-win/css1/basic/inheritance-expected.png:
  • platform/chromium-win/css1/box_properties/border_bottom_width-expected.png:
  • platform/chromium-win/css1/box_properties/border_width-expected.png:
  • platform/chromium-win/css1/box_properties/clear-expected.png:
  • platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-win/css1/box_properties/height-expected.png:
  • platform/chromium-win/css1/box_properties/margin_inline-expected.png:
  • platform/chromium-win/css1/box_properties/margin_top-expected.png:
  • platform/chromium-win/css1/box_properties/padding-expected.png:
  • platform/chromium-win/css1/box_properties/padding_bottom-expected.png:
  • platform/chromium-win/css1/box_properties/padding_inline-expected.png:
  • platform/chromium-win/css1/box_properties/padding_top-expected.png:
  • platform/chromium-win/css1/classification/white_space-expected.png:
  • platform/chromium-win/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-win/css1/color_and_background/background_position-expected.png:
  • platform/chromium-win/css1/color_and_background/background_repeat-expected.png:
  • platform/chromium-win/css1/conformance/forward_compatible_parsing-expected.png:
  • platform/chromium-win/css1/font_properties/font_weight-expected.png:
  • platform/chromium-win/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-win/css1/formatting_model/height_of_lines-expected.png:
  • platform/chromium-win/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-win/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-win/css1/pseudo/firstline-expected.png:
  • platform/chromium-win/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/chromium-win/css1/text_properties/text_decoration-expected.png:
  • platform/chromium-win/css1/text_properties/text_indent-expected.png:
  • platform/chromium-win/css1/text_properties/text_transform-expected.png:
  • platform/chromium-win/css1/units/color_units-expected.png:
  • platform/chromium-win/css1/units/length_units-expected.png:
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-expected.png:
  • platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-win/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
  • platform/chromium-win/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/chromium-win/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-023-expected.png:
  • platform/chromium-win/editing/selection/focus_editable_html-expected.png:
  • platform/chromium-win/editing/selection/select-all-003-expected.png:
  • platform/chromium-win/editing/selection/select-all-004-expected.png:
  • platform/chromium/compositing/scaling: Removed.
  • platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
3:55 PM Changeset in webkit [119629] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 118703
BUG=128498
Review URL: https://chromiumcodereview.appspot.com/10533036

3:55 PM ScalesAndZooms edited by jamesr@google.com
(diff)
3:44 PM Changeset in webkit [119628] by dpranke@chromium.org
  • 3 edits in trunk/Tools

get rebaselining tools to kinda work with the skia overrides file
https://bugs.webkit.org/show_bug.cgi?id=88456

Reviewed by Ryosuke Niwa.

Update rebaseline-expectations so that we read in the overrides
when looking for tests to rebaseline, but don't read in the
overrides when we are writing the expectations file back out.
This prevents the overrides from getting written into the main
file. This is kind of a hack but will have to do until we
support multiple expectations files properly.

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineExpectations._expectations):
(RebaselineExpectations._update_expectations_file):
(RebaselineExpectations._tests_to_rebaseline):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_overrides_are_included_correctly):

3:44 PM Changeset in webkit [119627] by cevans@google.com
  • 16 edits in branches/chromium/1132/Source/WebCore

Merge 118608
BUG=124356
Review URL: https://chromiumcodereview.appspot.com/10540037

3:38 PM Changeset in webkit [119626] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1132

Merge 118213
BUG=127371
Review URL: https://chromiumcodereview.appspot.com/10543038

3:30 PM Changeset in webkit [119625] by cevans@google.com
  • 6 edits in branches/chromium/1132

Merge 118725
BUG=118725
Review URL: https://chromiumcodereview.appspot.com/10542040

3:28 PM Changeset in webkit [119624] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/WebCore

Worker tear-down can re-enter JSC during GC finalization
https://bugs.webkit.org/show_bug.cgi?id=88449

Reviewed by Geoffrey Garen.

No new tests. Current regression tests cover these changes.

  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::~AbstractWorker): We don't need to call onDestroyWorker() here, it
will be called elsewhere in contextDestroyed().

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::workerObjectDestroyed): We make the call to terminateWorkerContext()
and workerContextDestroyed() asynchronous to avoid entering JSC during GC finalization.

3:09 PM Changeset in webkit [119623] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

Assigning to a static property should not change iteration order
https://bugs.webkit.org/show_bug.cgi?id=88401

Reviewed by Geoff Garen.

A specific iteration order is not defined by the spec, but test-262 somewhat tenuously
requires that it is at least stable, e.g. ch10/10.4/10.4.2/S10.4.2_A1.1_T1.js

Whilst it is not clear that this behavior really arises from the specification, it
would seem like common sense to conform to this.

The problem here is that we allow properties in the structure to shadow those in the
static table, and we iterate the properties in the structure first - which means that
as values of existing properties are modified, their iteration order changes too.

The easy fix is to iterate the properties from the static table first. This has a
further benefit, since it will mean that user added properties will come after those
present in the static table (respected the expected insertion-order).

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyNames):

  • Iterate static properties first.

LayoutTests:

  • fast/js/property-iteration-expected.txt: Added.
  • fast/js/property-iteration.html: Added.
  • fast/js/script-tests/property-iteration.js: Added.

(arrayEqual):

  • Added test case.
2:48 PM Changeset in webkit [119622] by cevans@google.com
  • 1 edit in branches/chromium/1132/Source/WebCore/dom/ContainerNodeAlgorithms.h

Merge 118096
BUG=128157
Review URL: https://chromiumcodereview.appspot.com/10545041

2:43 PM Changeset in webkit [119621] by cevans@google.com
  • 1 edit in branches/chromium/1132/Source/WebCore/rendering/RenderObject.cpp

Merge 118542
BUG=120944
Review URL: https://chromiumcodereview.appspot.com/10538032

2:41 PM Changeset in webkit [119620] by tony@chromium.org
  • 9 edits in trunk

webkit crashes on debug builds when running IETC flexbox-ordinal-group-001.htm
https://bugs.webkit.org/show_bug.cgi?id=85832

Reviewed by Ojan Vafai.

Source/WebCore:

We were using a HashSet<unsigned>, which can't hold the value of 0.
According to the spec, 0 isn't a valid value, so at CSS parse time,
reject the value 0. This lets us pass the test, although that's kind
of by accident.

We could allow 0 for box-ordinal-group, but there are some perf implications
to having allowing a value below the initial value (1 in this case).

We still allow 0 for box-flex-group, because that's what the existing code
does and there are tests expecting this behavior.

No new tests, covered by ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm
which was crashing.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Reject 0 for -webkit-box-ordinal-group.

LayoutTests:

  • platform/chromium/TestExpectations: Remove test that passes.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/Skipped:
2:19 PM Changeset in webkit [119619] by ddkilzer@apple.com
  • 2 edits in trunk

Teach git about localizable *.strings files
<http://webkit.org/b/88447>

Reviewed by Adam Roben.

  • .gitattributes: Set diff attribute for *.strings files so

git-diff doesn't complain about them being binary files once the
git-config command is run.

2:16 PM Changeset in webkit [119618] by ojan@chromium.org
  • 5 edits in trunk

Remove some magic from the -webkit-flex shorthand parsing to match the changes in the spec
https://bugs.webkit.org/show_bug.cgi?id=88444

Reviewed by Tony Chang.

Source/WebCore:

-Unset positive flex defaults to 0.
-Unset negative flex defaults to 1. No magic of doing something different if positive flex was set.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFlex):

LayoutTests:

  • css3/flexbox/flex-property-parsing-expected.txt:
  • css3/flexbox/flex-property-parsing.html:
2:11 PM Changeset in webkit [119617] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Revert r119440 now that I have a time to rebaseline them all!

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::thumbLength):

2:03 PM Changeset in webkit [119616] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: two manager_worker_broker_unittest tests are broken
https://bugs.webkit.org/show_bug.cgi?id=88445

Reviewed by Ojan Vafai.

These tests were never updated when we removed the
--worker-model argument, and we were passing 'inline' instead of
1 (for the number of workers) :(. As a result we were creating
multiprocessing queues unnecessarily and that was failing on cygwin.

  • Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:

(InterfaceTest.test_managerconnection_is_abstract):
(InterfaceTest.test_workerconnection_is_abstract):

2:01 PM Changeset in webkit [119615] by jsbell@chromium.org
  • 5 edits in trunk

IndexedDB: Infinite recursion in IDBObjectStore.openCursor(key, legacy_constant)
https://bugs.webkit.org/show_bug.cgi?id=88431

Reviewed by Tony Chang.

Source/WebCore:

Function was calling itself, rather than delegating to the correct (IDBKeyRange) overload.

Test: storage/indexeddb/legacy-constants.html

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::openCursor):

LayoutTests:

  • storage/indexeddb/legacy-constants-expected.txt:
  • storage/indexeddb/resources/legacy-constants.js: Refactored and added test cases.

(populateStore):
(doChecks.doNext.request.onsuccess):
(doChecks.doNext.testWithKey.request.onsuccess):
(doChecks.doNext.testWithKey):
(doChecks.doNext):
(doChecks):

1:56 PM Changeset in webkit [119614] by mrowe@apple.com
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merge r119261.

1:56 PM Changeset in webkit [119613] by mrowe@apple.com
  • 3 edits in branches/safari-536-branch/Source/WebKit2

Merge r119260.

1:56 PM Changeset in webkit [119612] by mrowe@apple.com
  • 2 edits in branches/safari-536-branch/Source/WebKit/mac

Merge r119339.

1:56 PM Changeset in webkit [119611] by mrowe@apple.com
  • 3 edits in branches/safari-536-branch/Source/WebCore

Merge r119136.

1:56 PM Changeset in webkit [119610] by mrowe@apple.com
  • 4 edits
    3 adds in branches/safari-536-branch

Merge r119274.

1:56 PM Changeset in webkit [119609] by mrowe@apple.com
  • 2 edits in branches/safari-536-branch/Source/JavaScriptCore

Merge r118995.

1:56 PM Changeset in webkit [119608] by mrowe@apple.com
  • 2 edits in branches/safari-536-branch/Source/JavaScriptCore

Merge r118992.

1:41 PM Changeset in webkit [119607] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Avoid limiting page-scale-factor when device-scale-factor is applied in the compositor.
https://bugs.webkit.org/show_bug.cgi?id=88417

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-06
Reviewed by James Robinson.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

1:24 PM Changeset in webkit [119606] by fischman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
1:12 PM Changeset in webkit [119605] by rniwa@webkit.org
  • 4 edits in trunk/Tools

REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=87406

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._update_expectations_file):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_rebaseline_does_not_include_overrides):

12:57 PM Changeset in webkit [119604] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: perf tests unit tests fail on chromium win
https://bugs.webkit.org/show_bug.cgi?id=88279

Reviewed by Ryosuke Niwa.

I'm seeing weird failures running the unit tests in my win32
checkout, and we don't really expect webpagereplay to work on
win32 anyway, so I'm skipping the import of that module for now
and adding a warning.

  • Scripts/run-perf-tests:
  • Scripts/webkitpy/performance_tests/perftest.py:
12:00 PM Changeset in webkit [119603] by jsbell@chromium.org
  • 5 edits in trunk

IndexedDB: Rename IDBFactory.getDatabaseNames() to webkitGetDatabaseNames()
https://bugs.webkit.org/show_bug.cgi?id=86874

Reviewed by Ojan Vafai.

Source/WebCore:

The function is non-standard, and should be prefixed.

Test: storage/indexeddb/factory-basics.html

  • Modules/indexeddb/IDBFactory.idl:

LayoutTests:

  • storage/indexeddb/factory-basics-expected.txt:
  • storage/indexeddb/resources/factory-basics.js:

(test):
(openSuccess):
(deleteDatabaseSuccess):

11:59 AM Changeset in webkit [119602] by wingo@igalia.com
  • 2 edits in trunk/Source/JavaScriptCore

Ensure consistent order of evaluation in LLInt slow paths
https://bugs.webkit.org/show_bug.cgi?id=88409

Reviewed by Geoffrey Garen.

  • llint/LLIntSlowPaths.cpp:

(slow_path_mul)
(slow_path_sub)
(slow_path_div)
(slow_path_mod)
(slow_path_lshift)
(slow_path_rshift)
(slow_path_urshift)
(slow_path_bitand)
(slow_path_bitor)
(slow_path_bitxor): Avoid calling toNumber, toInt32, or toUInt32
multiple times without intervening sequence points. Fixes
fast/js/exception-sequencing-binops.html with GCC 4.7 on x86-64
Linux, which reordered evaluation of the arguments to fmod.

11:47 AM Changeset in webkit [119601] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Update my email address in committers.py.

Patch by Yong Li <yoli@rim.com> on 2012-06-06

  • Scripts/webkitpy/common/config/committers.py:
11:00 AM Changeset in webkit [119600] by thakis@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Expose setPictographFontFamily through the chromium webkit api.
https://bugs.webkit.org/show_bug.cgi?id=88393

Reviewed by Adam Barth.

This was added to WebCore in
https://bugs.webkit.org/show_bug.cgi?id=65197

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setPictographFontFamily):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

10:58 AM Changeset in webkit [119599] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
10:51 AM Changeset in webkit [119598] by rniwa@webkit.org
  • 3 edits
    11 adds
    1 delete in trunk/LayoutTests

Chromium rebaseline after r119591 because it was failing with missing results.

  • platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
  • platform/chromium-mac-leopard/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium-mac/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium-win/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
10:34 AM Changeset in webkit [119597] by rjkroege@chromium.org
  • 2 edits in trunk/Tools

Add Robert Kroeger to commiters.py
https://bugs.webkit.org/show_bug.cgi?id=88415

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
10:33 AM Changeset in webkit [119596] by commit-queue@webkit.org
  • 2 edits
    1 move in trunk/LayoutTests

[WK2] fast/hidpi/device-scale-factor-paint.html crashes
https://bugs.webkit.org/show_bug.cgi?id=88350

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-06-06
Reviewed by Alexey Proskuryakov.

  • fast/hidpi/device-scale-factor-paint-expected.html: Renamed from LayoutTests/platform/chromium/fast/hidpi/device-scale-factor-paint-expected.html.
  • platform/wk2/Skipped:
10:21 AM ScalesAndZooms edited by danakj@chromium.org
(diff)
10:20 AM ScalesAndZooms edited by danakj@chromium.org
(diff)
10:15 AM ScalesAndZooms edited by danakj@chromium.org
(diff)
10:13 AM ScalesAndZooms edited by danakj@chromium.org
(diff)
10:12 AM ScalesAndZooms edited by danakj@chromium.org
(diff)
9:47 AM Changeset in webkit [119595] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed rebaseline for r119591.

  • platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
9:07 AM Changeset in webkit [119594] by jchaffraix@webkit.org
  • 9 edits
    30 adds in trunk

Add support for direction on table row group with collapsing borders
https://bugs.webkit.org/show_bug.cgi?id=87900

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/table/border-collapsing/first-cell-left-border-hidden-table-ltr-section-rtl.html

fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl.html
fast/table/border-collapsing/left-border-table-ltr-section-rtl.html
fast/table/border-collapsing/left-border-table-rtl-section-ltr.html
fast/table/border-collapsing/left-border-table-rtl-section-rtl.html
fast/table/border-collapsing/left-border-vertical-lr-table-ltr-section-rtl.html
fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-ltr.html
fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-rtl.html
fast/table/border-collapsing/rtl-table-left-border-hidden.html
fast/table/border-collapsing/top-border-vertical-rl-table-ltr-section-rtl.html
fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-ltr.html
fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-rtl.html
fast/table/table-ltr-section-rtl.html
fast/table/table-rtl-section-ltr.html
fast/table/table-rtl-section-rtl.html

This change enables proper support for direction on table row group.
The current code would allow people to set direction on the row group but would still
use the table's code for directionality checks (with surprising consequences).

The main change involve swapping end / start borders in case of mixed directionality
as those 2 are not in sync.

Example: <table dir="ltr"><tbody dir="rtl"><td id="cell0"></td><td id="cell1"></td></tbody></table>

Visually:
Table: Start ---------------------> End
Tbody: End <---------------------- Start
Cell: | #cell0 | #cell1 |

In this example, the end table border should be compared with the tbody's start border
and the last cell's (in DOM order) start border.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::tableStartBorderAdjoiningCell):
(WebCore::RenderTable::tableEndBorderAdjoiningCell):
Same as the other adjoining functions.

  • rendering/RenderTable.h:

(WebCore::RenderTable::lastColumnIndex):
Helper function to get the last column index.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Updated to call the table's adjoining border helpers.

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::styleForCellFlow):
Updated to use the table row group's style now that we properly support it.

(WebCore::RenderTableCell::isFirstOrLastCellInRow):
Debug only helper to make sure we don't call the border adjoining function
on non-terminal cells.

(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):

  • rendering/RenderTableRow.h:

(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
Updated the previous function to account for mixed directionality.

(WebCore::RenderTableSection::layoutRows):
Move some of the code to setLogicalPositionForCell to match RenderBlock.

(WebCore::RenderTableSection::setLogicalPositionForCell):
Switched direction checks to styleForCellFlow (this doesn't change anything as we
were already properly flipping already but ensure better).

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::hasSameDirectionAsTable):
Added this helper to know if we have a mixed direction.

(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
Updated to account for mixed directionality.

LayoutTests:

  • fast/table/border-collapsing/first-cell-left-border-hidden-table-ltr-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/first-cell-left-border-hidden-table-ltr-section-rtl.html: Added.
  • fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl.html: Added.
  • fast/table/border-collapsing/left-border-table-ltr-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/left-border-table-ltr-section-rtl.html: Added.
  • fast/table/border-collapsing/left-border-table-rtl-section-ltr-expected.html: Added.
  • fast/table/border-collapsing/left-border-table-rtl-section-ltr.html: Added.
  • fast/table/border-collapsing/left-border-table-rtl-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/left-border-table-rtl-section-rtl.html: Added.
  • fast/table/border-collapsing/left-border-vertical-lr-table-ltr-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/left-border-vertical-lr-table-ltr-section-rtl.html: Added.
  • fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-ltr-expected.html: Added.
  • fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-ltr.html: Added.
  • fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-rtl.html: Added.
  • fast/table/border-collapsing/rtl-table-left-border-hidden-expected.html: Added.
  • fast/table/border-collapsing/rtl-table-left-border-hidden.html: Added.
  • fast/table/border-collapsing/top-border-vertical-rl-table-ltr-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/top-border-vertical-rl-table-ltr-section-rtl.html: Added.
  • fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-ltr-expected.html: Added.
  • fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-ltr.html: Added.
  • fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-rtl-expected.html: Added.
  • fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-rtl.html: Added.

Most of those are test are a variation of direction on table and row group along with disabling some
borders (either using 'hidden' or just disabling it by setting it to 0px).

  • fast/table/table-ltr-section-rtl-expected.html: Added.
  • fast/table/table-ltr-section-rtl.html: Added.
  • fast/table/table-rtl-section-ltr-expected.html: Added.
  • fast/table/table-rtl-section-ltr.html: Added.
  • fast/table/table-rtl-section-rtl-expected.html: Added.
  • fast/table/table-rtl-section-rtl.html: Added.

Bonus as there was little testing for mixed direction + separate borders.

9:00 AM Changeset in webkit [119593] by wingo@igalia.com
  • 10 edits in trunk

[GTK] Enable the LLInt
https://bugs.webkit.org/show_bug.cgi?id=88315

Reviewed by Filip Pizlo.

.:

  • configure.ac: Require Ruby, to build the low-level interpreter.

Source/JavaScriptCore:

  • GNUmakefile.am: Add rules to generate LLIntDesiredOffsets.h and

LLIntAssembly.h.

  • GNUmakefile.list.am: Add offlineasm and llint files to the

dist. Add LLInt source files to the build.

  • llint/LowLevelInterpreter.asm (crash): Generate a store of

0xbbadbeef to a register, not to a constant. Otherwise, gas was
failing to assemble result.

  • offlineasm/asm.rb (labelReference): Generate a

SYMBOL_STRING_RELOCATION instead of a SYMBOL_STRING, so that we go
through the PLT on ELF systems.

Source/WTF:

  • wtf/InlineASM.h: Add an implementation of LOCAL_LABEL_STRING for

OS(LINUX).

  • wtf/Platform.h: Add OS(LINUX) to the set of operating systems

for ENABLE_LLINT. Add a specific check for PLATFORM(MAC) or
PLATFORM(IOS), and add to that a check for PLATFORM(GTK).

8:57 AM Changeset in webkit [119592] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2-Gtk]Compilation errors with flag CONTEXT_MENUS=0
https://bugs.webkit.org/show_bug.cgi?id=87842

Patch by chandra Shekar Vallala <chandra.vallala@motorola.com> on 2012-06-06
Reviewed by Martin Robinson.

Fix for compilation errors while building webkit2-gtk with CONTEXT_MENUS=0

  • UIProcess/gtk/WebContextMenuProxyGtk.cpp: Added code under CONTEXT_MENUS CC
  • UIProcess/gtk/WebContextMenuProxyGtk.h: Ditto
  • WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp: Ditto
8:38 AM wxWebKit edited by kevino@theolliviers.com
(diff)
8:17 AM Changeset in webkit [119591] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

[Chromium] imageSmoothingEnabled should apply to patterns
https://bugs.webkit.org/show_bug.cgi?id=88103

Patch by Keyar Hood <keyar@chromium.org> on 2012-06-06
Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/canvas-imageSmoothingEnabled-patterns.html

When drawing patterns on a Canvas, the imageSmoothingEnabled flag is
respected.

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::setupShader):

LayoutTests:

Added tests for imageSmoothingEnabled flag applying to patterns.

Modified the TestExpectations file as tests are failing due to the new
change. It makes the pictures prettier (and it agrees with other
browsers) so we have decided that the new results are to be considered
correct.

  • fast/canvas/canvas-imageSmoothingEnabled-patterns.html: Added.
  • platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
  • platform/chromium-linux/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
  • platform/chromium/TestExpectations:
7:57 AM Changeset in webkit [119590] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL][DRT] http/tests/globalhistory testcases do not pass
https://bugs.webkit.org/show_bug.cgi?id=82579

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-06-06
Reviewed by Csaba Osztrogonác.

Tools:

DRT has provided callbacks for ewk_view "global history delegate" signals.

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(isGlobalHistoryTest): Aux function to ident global history testcase.
(createLayoutTestController):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
(DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
(DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
(DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
(DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

LayoutTests:

  • platform/efl/Skipped: Unskip http/tests/globalhistory.
7:12 AM Changeset in webkit [119589] by caseq@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: [JSC] Add WebGL instrumentation support
https://bugs.webkit.org/show_bug.cgi?id=87975

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-06
Reviewed by Vsevolod Vlasov.

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::injectAndExecuteFunction):
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore):
(WebCore::InjectedScriptManager::injectWebGLScript):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::injectWebGLScript):

  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation):

  • inspector/InjectedScriptManager.h:

(InjectedScriptManager):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/InspectorWebGLAgent.cpp:

(WebCore::InspectorWebGLAgent::wrapWebGLRenderingContextForInstrumentation):

  • inspector/InspectorWebGLAgent.h:

(InspectorWebGLAgent):

  • inspector/InspectorWebGLInstrumentation.h:

(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

6:09 AM Changeset in webkit [119588] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] run-qtwebkit-tests hangs with -j1
run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
This could happen due to an uncancelled timer after results were returned. This timer was
started only if --timeout was set.
https://bugs.webkit.org/show_bug.cgi?id=85475

Patch by János Badics <János Badics> on 2012-06-06
Reviewed by Csaba Osztrogonác.

  • Scripts/run-qtwebkit-tests:

(run_test):

5:24 AM Changeset in webkit [119587] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed update chromium test expectations.

  • platform/chromium/TestExpectations:

css3/filters/huge-region-composited.html = CRASH : was removed

4:41 AM Changeset in webkit [119586] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a few spelling mistakes in IconDatabase logging

Makes debugging harder if the logging is confusing.

Reviewed by Jocelyn Turcotte.

4:37 AM Changeset in webkit [119585] by vsevik@chromium.org
  • 2 edits
    1 add
    2 deletes in trunk/Source/WebCore

Web Inspector: [Compiler] Remove compile-front-end.sh and fix InjectedScriptSource errors.
https://bugs.webkit.org/show_bug.cgi?id=87512

Reviewed by Yury Semikhatsky.

Removed compile-front-end.sh, compile-front-end.py should be used instead now.
Made generate_protocol_externs a python module to call it from compile-front-end.py.
Temporary copy of InjectedScriptSource.js is created and modified to
avoid "This code lacks side effects" warning.

  • inspector/compile-front-end.py:
  • inspector/compile-front-end.sh: Removed.
  • inspector/generate-protocol-externs: Removed.
  • inspector/generate_protocol_externs.py: Added.

(full_qualified_type_id):
(param_type):
(generate_protocol_externs):

4:34 AM Changeset in webkit [119584] by zherczeg@webkit.org
  • 6 edits in trunk/Source/WebCore

[Qt] REGRESSION(r118616): It made all tests crash in debug mode
https://bugs.webkit.org/show_bug.cgi?id=87701

Reviewed by Csaba Osztrogonác.

Replace WriteBarrier<JSObject> to Weak<JSObject> by introducing a new
QtWeakObjectReference sub class. Rewrite all affected type definitions.

All existing test in debug mode cover this issue.

  • bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

  • bridge/qt/qt_instance.cpp:

(QtRuntimeObject):
(JSC::Bindings::QtInstance::removeUnusedMethods):

  • bridge/qt/qt_instance.h:

(QtInstance):
(QtWeakObjectReference):
(JSC::Bindings::QtInstance::QtWeakObjectReference::QtWeakObjectReference):
(JSC::Bindings::QtInstance::QtWeakObjectReference::operator=):
(JSC::Bindings::QtInstance::QtWeakObjectReference::get):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMethodData::finalize):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::QtRuntimeMethodData::finalize):

4:27 AM Changeset in webkit [119583] by loislo@chromium.org
  • 4 edits in trunk

Web Inspector: Option for selecting/deselecting all breakpoints in breakpoint pane
https://bugs.webkit.org/show_bug.cgi?id=87644

Patch by Sam D <dsam2912@gmail.com> on 2012-06-06
Reviewed by Pavel Feldman.

Added an option to enable/disable all breakpoints in Breakpoint pane.

  • Source/WebCore/English.lproj/localizedStrings.js:
  • Source/WebCore/inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.enableAllBreakpoints):
(WebInspector.BreakpointManager.prototype.disableAllBreakpoints):

  • Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu.enabledBreakpointCount):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):

4:21 AM Changeset in webkit [119582] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Qt DRT / WTR should be able to load external resources
https://bugs.webkit.org/show_bug.cgi?id=87326

Reviewed by Hajime Morita.

Allow external resources to be loaded when the main frame's URL is also an external resource.
This change is analogous to r118231 for Mac port and to r119153 Chromium port.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::blockRequest):
(WebCore):
(WebCore::isLocalhost):
(WebCore::hostIsUsedBySomeTestsToGenerateError):
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

3:41 AM Changeset in webkit [119581] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: help/settings screen does not overlay console in split screen mode
https://bugs.webkit.org/show_bug.cgi?id=88352

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-06-06
Reviewed by Pavel Feldman.

  • inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreen): Mark view as root.
(WebInspector.HelpScreen.prototype.showModal): Change view parent.

  • inspector/front-end/helpScreen.css:

(.help-window-outer): Add panel and status bar indent.
(body.compact .help-window-outer): Ditto.

3:26 AM Changeset in webkit [119580] by yosin@chromium.org
  • 7 edits in trunk/Source/WebCore

[Form] Changes for InputNumber type
https://bugs.webkit.org/show_bug.cgi?id=88394

Reviewed by Kent Tamura.

This patch changes codes for consitency of InputNumber usage for
reducing size of patch when we change InputNumber type alias from
double to Decimal.

No new tests. This patch doesn't change behavior.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::serializeWithComponents): Fixed parameter type for getAllowedValueStep.

  • html/InputType.cpp:

(WebCore::InputType::minimum): Fixed return value type to InputNumber.
(WebCore::InputType::maximum): ditto.

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::defaultValueForStepUp): Fix return value type to InputNumber.
(WebCore::MonthInputType::parseToNumber): ditto.

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::setValueAsDouble): Removed extra convertDoubleToInputNumber.

  • html/StepRange.cpp:

(WebCore::StepRange::alignValueForStep): Use roundByStep for code sharing.
(WebCore::StepRange::clampValue): ditto.
(WebCore::StepRange::roundByStep): Added.

  • html/StepRange.h:

(StepRange): Added a declaration of roundByStep.

3:24 AM Changeset in webkit [119579] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Fix harmattan builds broken by r119247.
https://bugs.webkit.org/show_bug.cgi?id=88330

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-06-06
Reviewed by Jocelyn Turcotte.

Fix Harmattan build break caused by undefined constant
GL_TEXTURE_RECTANGLE_ARB by adding defined(GL_ARB_texture_rectangle)
guards around TextureMapperGL::drawTextureRectangleARB.

  • platform/graphics/texmap/TextureMapperGL.cpp: Added defined(GL_ARB_texture_rectangle) guards around drawTextureRectangleARB.

(WebCore):

  • platform/graphics/texmap/TextureMapperGL.h: Added definded(GL_ARB_texture_rectangle) guards around drawTextureRectangleARB.
3:12 AM Changeset in webkit [119578] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk

[Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=88327

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-06-06
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::setPreferredMinimumContentsWidth):

  • UIProcess/API/qt/qquickwebview_p.h:

Tools:

  • MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
  • MiniBrowser/qt/icons/contents_width.png: Added.
  • MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
  • MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
3:04 AM Changeset in webkit [119577] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updated TestExpectations after several tests have been
regularly passing in the 3 GTK bots for some time.

  • platform/gtk/TestExpectations:
2:57 AM Changeset in webkit [119576] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Turning the bot into a springtime green
https://bugs.webkit.org/show_bug.cgi?id=88400

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-06

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
2:39 AM Changeset in webkit [119575] by wingo@igalia.com
  • 3 edits
    3 adds in trunk

REGRESSION (r106478): None of the Paper.js JavaScript examples work
https://bugs.webkit.org/show_bug.cgi?id=87158

Source/JavaScriptCore:

Reviewed by Michael Saboff.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve): If we have to bail out to
dynamicResolve(), only skip static scopes from the head of the
scope chain. Before, we were also skipping activations with
direct eval as well, which was incorrect.

LayoutTests:

Added regression tests for functions inside eval inside a with.

Reviewed by Michael Saboff.

  • fast/js/eval-and-with-expected.txt: Added.
  • fast/js/eval-and-with.html: Added.
  • fast/js/script-tests/eval-and-with.js: Added.
2:34 AM Changeset in webkit [119574] by kkristof@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Skip modified falining test. Rebase a test.
[Qt] Fix wrong skipping.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-06

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/qt/Skipped:
2:03 AM Changeset in webkit [119573] by shinyak@chromium.org
  • 4 edits in trunk/Source/WebCore

PositionIterator:;setOffsetInLeafNode() is not used anywhere.
https://bugs.webkit.org/show_bug.cgi?id=88397

Reviewed by Ryosuke Niwa.

It's not used anywhere. We can remove it safely.

No new tests, no change in behavior.

  • WebCore.order:
  • dom/PositionIterator.cpp:
  • dom/PositionIterator.h:
1:35 AM Changeset in webkit [119572] by caseq@chromium.org
  • 24 edits
    4 adds in trunk/Source/WebCore

Web Inspector: [WebGL] Add WebGL instrumentation support on the backend
https://bugs.webkit.org/show_bug.cgi?id=87960

Adds a WebGLAgent, injects a WebGL script upon calling the getContext
method of a HTMLCanvasElement that will wrap the WebGL rendering context
for instrumentation purposes.

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-06
Reviewed by Yury Semikhatsky.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):
(WebCore::JSHTMLCanvasElement::toDataURL):

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore):
(WebCore::InjectedScriptManager::injectWebGLScript):

  • bindings/v8/ScriptState.cpp:

(WebCore::ScriptState::forContext):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore):
(WebCore::InjectedScriptManager::injectWebGLScript):
(WebCore::InjectedScriptManager::discardInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):

  • inspector/CodeGeneratorInspector.py:
  • inspector/InjectedScriptManager.cpp:

(WebCore):
(WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InjectedScriptManager::injectedWebGLScriptSource):

  • inspector/InjectedScriptManager.h:

(InjectedScriptManager):

  • inspector/InjectedWebGLScriptSource.js: Added.
  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::markResourceAsCached):

  • inspector/InspectorWebGLAgent.cpp: Added.

(WebCore):
(WebGLAgentState):
(WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::~InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::setFrontend):
(WebCore::InspectorWebGLAgent::clearFrontend):
(WebCore::InspectorWebGLAgent::restore):
(WebCore::InspectorWebGLAgent::enable):
(WebCore::InspectorWebGLAgent::disable):
(WebCore::InspectorWebGLAgent::wrapWebGLRenderingContextForInstrumentation):

  • inspector/InspectorWebGLAgent.h: Added.

(WebCore):
(InspectorWebGLAgent):
(WebCore::InspectorWebGLAgent::create):
(WebCore::InspectorWebGLAgent::enabled):

  • inspector/InspectorWebGLInstrumentation.h: Added.

(WebCore):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

  • inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorWebGLAgent):
(WebCore::InstrumentingAgents::setInspectorWebGLAgent):

1:13 AM QtWebKitBuildBots edited by kkristof@inf.u-szeged.hu
(diff)
12:55 AM Changeset in webkit [119571] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140700 to r140711.

  • DEPS:
12:54 AM Changeset in webkit [119570] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

WebPage::windowIsVisible is incorrect during resumePainting
https://bugs.webkit.org/show_bug.cgi?id=88374
<rdar://problem/11587039>

Reviewed by Simon Fraser.

Currently, when changing window visibility, WKView calls viewStateDidChange(ViewIsVisible)
and then _updateWindowVisibility. This means that during viewStateDidChange, the WebPage's
windowIsVisible state is incorrect.

viewStateDidChange(ViewIsVisible) can end up in (one of the DrawingArea implementations)::resumePainting(),
which uses windowIsVisible to determine whether or not to unpause requestAnimationFrame.

This results in a state where, with some configurations, doing the following:

  1. requestAnimationFrame()
  2. requestFullScreen()
  3. requestAnimationFrame()
  4. cancelFullScreen()
  5. requestAnimationFrame()

Will cause the second and third rAF calls to have no effect. Even after cancelFullScreen() is called,
the fact that we have had unpaired suspend/resumeScriptedAnimations will cause the suspend count
on the ScriptedAnimationController to never return to zero, which will cause us to never
recover rAF functionality.

The fix is very simple: we should _updateWindowVisibility *before* viewStateDidChange, so that it is
always correct for any code called underneath that method.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):

12:51 AM Changeset in webkit [119569] by fischman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349
https://bugs.webkit.org/show_bug.cgi?id=88388

Reviewed by Darin Fisher.

  • public/WebMediaPlayer.h:
12:37 AM Changeset in webkit [119568] by mitz@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Reverted r119567, the fix for <http://webkit.org/b/88378>, because it broke the 32-bit build.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • llint/LowLevelInterpreter.asm:
  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::setUnwrappedObject):

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):
(JSC::JSObject::createInheritorID):

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::resetInheritorID):
(JSC):
(JSC::JSObject::offsetOfInheritorID):
(JSC::JSObject::inheritorID):

12:29 AM Changeset in webkit [119567] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK] Build fix for Accelerated Compositing with OpenGL
https://bugs.webkit.org/show_bug.cgi?id=88292

Patch by Joone Hur <joone.hur@intel.com> on 2012-06-06
Reviewed by Martin Robinson.

Build fix after r119247.
Do not include GraphicsSurface.h when not building
with GRAPHICS_SURFACE.

No new tests. This is only a build fix.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:
  • platform/graphics/texmap/TextureMapperBackingStore.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:
12:01 AM Changeset in webkit [119566] by charles.wei@torchmobile.com.cn
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] IndexedDB file should be sand-boxed to the application data directory.
https://bugs.webkit.org/show_bug.cgi?id=88065

Reviewed by George Staikos.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::indexedDataBasePath):
(BlackBerry::WebKit::WebSettings::setIndexedDataBasePath):

  • Api/WebSettings.h:

Jun 5, 2012:

11:53 PM Changeset in webkit [119565] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox
https://bugs.webkit.org/show_bug.cgi?id=88197

Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-05
Reviewed by Daniel Bates.

RenderSVGRoot extends RenderReplaced and it overrides the computeIntrinsicRatioInformation()
method of RenderReplaced. RenderSVGRoot::computeIntrinsicRatioInformation
sets isPercentageIntrinsicSize to true while it handles width and height of percentage types.
So this assertion should be fired only if intrinsicRatio is non-zero.

Source/WebCore:

Test: svg/in-html/svg-assert-failure-percentage.html

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeIntrinsicRatioInformationForRenderBox):

LayoutTests:

  • svg/in-html/svg-assert-failure-percentage-expected.txt: Added.
  • svg/in-html/svg-assert-failure-percentage.html: Added.
11:45 PM Changeset in webkit [119564] by tony@chromium.org
  • 3 edits
    2 adds in trunk

Changing flexbox justify/alignment doesn't update their positioning
https://bugs.webkit.org/show_bug.cgi?id=88366

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/style-change.html

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Since these member variables were moved
out of StyleFlexibleBoxData, we have to compare them in RenderStyle::diff.

LayoutTests:

  • css3/flexbox/style-change-expected.txt: Added.
  • css3/flexbox/style-change.html: Added.
10:51 PM Changeset in webkit [119563] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

JSC implementation of SerializedScriptValue for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=88048

Reviewed by George Staikos.

No new tests. All the current indexeddb test cases apply when indexeddb works for JSC.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serializeNumber):
(CloneSerializer):
(WebCore::CloneDeserializer::toWireString):
(CloneDeserializer):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::toWireString):
(WebCore):
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::deserialize):

10:41 PM Changeset in webkit [119562] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

Nested CSS flexbox renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=87679

Reviewed by Julien Chaffraix.

Source/WebCore:

If the containing block with a perpendicular writing mode has an overrideHeight,
then its logical height should be based off that instead of its RenderStyle.

Test: css3/flexbox/perpendicular-writing-modes-inside-flex-item.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):

LayoutTests:

  • css3/flexbox/perpendicular-writing-modes-inside-flex-item-expected.txt: Added.
  • css3/flexbox/perpendicular-writing-modes-inside-flex-item.html: Added.
10:37 PM Changeset in webkit [119561] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

Need special-case toJS(IDBAny) for IDBCursorWithValue
https://bugs.webkit.org/show_bug.cgi?id=87963

Reviewed by George Staikos.

No new tests, this is for indexedDB, which is not working for JSC binding.
When indexedDB working for JSC, all the indexdb test cases should apply.

  • bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS):

10:35 PM Changeset in webkit [119560] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140653 to r140700.

  • DEPS:
10:32 PM Changeset in webkit [119559] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Use Component.onCompleted in API tests for single and multi file upload tests.
https://bugs.webkit.org/show_bug.cgi?id=88247

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-05
Reviewed by Kenneth Rohde Christiansen.

With r116936, Component.onCompleted can be used for callback instead of the
1s timer in single and multi file upload tests.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml:
10:25 PM Changeset in webkit [119558] by yuqiang.xian@intel.com
  • 2 edits in trunk/Source/JavaScriptCore

Improve Math.round and Math.floor intrinsic
https://bugs.webkit.org/show_bug.cgi?id=88314

Reviewed by Filip Pizlo.

Currently we call a native function from the JIT code to complete the
"round" and "floor" operations. We could inline some fast paths
especially for those positive values on the platforms where floating
point truncation is supported.
This brings 3% gain on Kraken, especially 32% on audio-oscillator,
and slight win on SunSpider, measured on IA32.

  • jit/ThunkGenerators.cpp:

(JSC::floorThunkGenerator):
(JSC):
(JSC::roundThunkGenerator):

10:19 PM Changeset in webkit [119557] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] show the feature list in alphabetical order
https://bugs.webkit.org/show_bug.cgi?id=88343

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2012-06-05
Reviewed by Gustavo Noronha Silva.

  • configure.ac:
10:08 PM Changeset in webkit [119556] by barraclough@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Remove JSObject::m_inheritorID
https://bugs.webkit.org/show_bug.cgi?id=88378

Reviewed by Geoff Garen.

This is rarely used, and not performance critical (the commonly accessed copy is cached on JSFunction),
and most objects don't need an inheritorID (this value is only used if the object is used as a prototype).
Instead use a private named value in the object's property storage.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):

  • No need m_inheritorID to initialize!
  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • No need m_inheritorID to initialize!
  • llint/LowLevelInterpreter.asm:
    • No need m_inheritorID to initialize!
  • runtime/JSGlobalData.h:

(JSGlobalData):

  • Added private name 'm_inheritorIDKey'.
  • runtime/JSGlobalThis.cpp:

(JSC::JSGlobalThis::setUnwrappedObject):

  • resetInheritorID is now passed a JSGlobalData&.
  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):

  • No m_inheritorID to be marked.

(JSC::JSObject::createInheritorID):

  • Store the newly created inheritorID in the property map.
  • runtime/JSObject.h:

(JSC::JSObject::resetInheritorID):

  • Remove the inheritorID from property storage.

(JSC::JSObject::inheritorID):

  • Read the inheritorID from property storage.
10:01 PM ScalesAndZooms created by jamesr@google.com
9:58 PM Changeset in webkit [119555] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove erroneous expected image added in r119544.

  • platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.txt: Removed.
9:44 PM Changeset in webkit [119554] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Set default memory allocation limit bytes when GL_CHROMIUM_gpu_memory_manager is not supported by graphics context.
https://bugs.webkit.org/show_bug.cgi?id=87996

Patch by Michal Mocny <mmocny@google.com> on 2012-06-05
Reviewed by James Robinson.

Soon we hope to have renderers not manage there own memory allocation limits, and rely exclusively on the
allocation given by GpuMemoryManager. However, when the graphics context does not support the
GL_CHROMIUM_gpu_memory_manager extension, such as the one used by DumpRenderTree, we must default the
memory allocation limit to some non-0 value.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::postSetContentsMemoryAllocationLimitBytesToMainThreadOnImplThread):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore):
(DebugScopedSetMainThreadFromEither):
(WebCore::DebugScopedSetMainThreadFromEither::DebugScopedSetMainThreadFromEither):
(WebCore::DebugScopedSetMainThreadFromEither::~DebugScopedSetMainThreadFromEither):

8:44 PM Changeset in webkit [119553] by haraken@chromium.org
  • 5 edits
    1 delete in trunk/Source/WebKit/chromium

Unreviewed, rolling out r119494.
http://trac.webkit.org/changeset/119494
https://bugs.webkit.org/show_bug.cgi?id=87911

We found similar APIs are already implemented

  • public/WebWidget.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/WebViewTest.cpp:
  • tests/data/textarea.html: Removed.
8:04 PM Changeset in webkit [119552] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=78720

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-06-05
Reviewed by Noam Rosenthal.

Source/WebCore:

Functions are removed from GraphicsContext3DQt that already implemented
in GraphicsContext3DCommon. Macros that not supported at GLES have been
changed to their appropriate pair that found in GraphicsContext3D
(e.g. GL_FRAMEBUFFER_EXT to GraphicsContext3D::FRAMEBUFFER).
It was needed because OpenGLES does not support these macros.
Extensions3DQt is removed beceause it has never been used.
Some functions have been moved fron GraphicsContext3DCommon to *OpenGL
and *OpenGLES to provide specialization.
The "m_depthStencilBuffer" member is added to Qt port because it uses
"m_depthStencilBuffer" like the other platforms.

  • Target.pri:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::depthRange):
(WebCore):
(WebCore::GraphicsContext3D::clearDepth):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::readPixels):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::depthRange):
(WebCore):
(WebCore::GraphicsContext3D::clearDepth):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebuffer):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore):

Source/WTF:

Defined a global Opengl ES macro to check OpenGL ES on every platforms.

  • wtf/Platform.h:
7:41 PM Changeset in webkit [119551] by rniwa@webkit.org
  • 7 edits
    3 adds in trunk/LayoutTests

Chromium rebaselines after r115091.

  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/chromium/TestExpectations:
7:13 PM Changeset in webkit [119550] by rniwa@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

More Chromium rebaselines after r119528 and r119512.

  • platform/chromium-linux/editing/selection/3690703-2-expected.png:
  • platform/chromium-linux/editing/selection/3690703-expected.png:
  • platform/chromium-linux/editing/selection/3690719-expected.png:
  • platform/chromium-linux/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
6:57 PM Changeset in webkit [119549] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
https://bugs.webkit.org/show_bug.cgi?id=88342

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-05
Reviewed by Rob Buis.

RIM PR: 163141

Reviewed internally by Mike Fenton.

We set all options' type to TypeOption, which can't tell if an option belongs to a group,
introduce TypeOptionInGroup to fix it.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openSelectPopup):

6:51 PM Changeset in webkit [119548] by Darin Adler
  • 4 edits in trunk/Source/WebCore

Special layout handler should be done on top frame being printed.
https://bugs.webkit.org/show_bug.cgi?id=88201

Patch by Vitaly Buka <vitalybuka@chromium.org> on 2012-06-05
Reviewed by Brady Eidson.

No new tests. Root case is already covered by tests.
Case described in the issue can be reproduced only by direct call
to Frame::setPrinting of subframe. Probably it's not possible with
layout tests.

  • page/Frame.cpp:

(WebCore::Frame::setPrinting):
Use shouldUsePrintingLayout to choose proper version of forceLayout().
(WebCore::Frame::shouldUsePrintingLayout):
Checks if current frame is the top frame being printed.

  • rendering/RenderView.cpp:

(WebCore::RenderView::shouldUsePrintingLayout): Forward to Frame.

6:40 PM Changeset in webkit [119547] by commit-queue@webkit.org
  • 36 edits
    5 adds in trunk

[BlackBerry] Conditionally enlarge HTML5 video controls in fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=87551

Patch by Max Feil <mfeil@rim.com> on 2012-06-05
Reviewed by Antonio Gomes.

Source/WebCore:

Changes to make media controls larger in fullscreen mode. The
BlackBerry media controls used to be sized by a combination
of CSS styles specified in mediaControlsBlackBerry.css and
hard coded constants in RenderThemeBlackBerry.cpp. This patch
moves all the dimensional sizes to a common location, i.e.
RenderThemeBlackBerry.cpp. Having all the logic in C++ code allows
more complex decision making for when and how much to enlarge the
media controls. Currently the controls are enlarged by a factor
of 2 if the document is in fullscreen mode, the video element
is the current fullscreen element, and the deviceScaleFactor of
the page is less than 2.0. This avoids overly large controls
on pages which are already at least doubling the size of the
controls via viewport meta tag device-width settings. In other
words, if the CSS pixels are already enlarged compared to device
pixels by a factor of at least 2 in length and width.

In order to accomplish this, I had to add a new Element* parameter
to RenderTheme::adjustSliderThumbSize(). This is needed so
that fullscreen mode can be checked and the deviceScaleFactor
retrieved. I feel that this does not have a big impact on the
code and the other ports, for which I will simply be adding the
additional parameter in their platform code.

Tests:
video-controls-enlarged-fullscreen-meta.html
video-controls-enlarged-fullscreen-nometa.html

  • css/mediaControlsBlackBerry.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderThumb::updateAppearance):

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore):
(WebCore::determineRenderSlider):
(WebCore::determineFullScreenMultiplier):
(WebCore::RenderThemeBlackBerry::adjustSliderThumbSize):
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::adjustSliderTrackStyle):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):

  • platform/blackberry/RenderThemeBlackBerry.h:

(RenderThemeBlackBerry):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustSliderThumbSize):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp:

(WebCore::RenderThemeGtk::adjustSliderThumbSize):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::adjustSliderThumbSize):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::adjustSliderThumbSize):

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):

  • platform/qt/RenderThemeQtMobile.h:

(RenderThemeQtMobile):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):

  • rendering/RenderThemeChromiumLinux.h:

(RenderThemeChromiumLinux):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):

  • rendering/RenderThemeChromiumWin.h:

(RenderThemeChromiumWin):

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::adjustSliderThumbSize):

  • rendering/RenderThemeSafari.h:

(RenderThemeSafari):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::adjustSliderThumbSize):

  • rendering/RenderThemeWin.h:

(RenderThemeWin):

  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::adjustSliderThumbSize):

  • rendering/RenderThemeWinCE.h:

(RenderThemeWinCE):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustMediaControlStyle):
(WebCore):
(WebCore::RenderTheme::adjustSliderThumbStyle):
(WebCore::RenderTheme::adjustSliderThumbSize):

  • rendering/RenderTheme.h:

(RenderTheme):

Source/WebKit/qt:

Add a new parameter to adjustSliderThumbSize() for BlackBerry
port. Fixing compiles of other ports.

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::adjustSliderThumbSize):

  • WebCoreSupport/RenderThemeQStyle.h:

(RenderThemeQStyle):

LayoutTests:

  • media/media-controls.js:

(mediaControlsButtonDimensions):

  • platform/blackberry/media/video-controls-enlarged-fullscreen-meta-expected.txt: Added.
  • platform/blackberry/media/video-controls-enlarged-fullscreen-meta.html: Added.
  • platform/blackberry/media/video-controls-enlarged-fullscreen-nometa-expected.txt: Added.
  • platform/blackberry/media/video-controls-enlarged-fullscreen-nometa.html: Added.
6:37 PM Changeset in webkit [119546] by Stephanie Lewis
  • 6 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=88370
Memory sampler should trigger low memory signal

Reviewed by Geoff Garen.

Source/WebCore:

No new tests. Verify by running stress test which crashes
in a few minutes without the fix.

Fix assumption in block code. We could get in a state where timer_event_source
had already been released before the block ran.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::holdOff):

Source/WebKit2:

Send low memory signal when running the memory sampler. We'd
like to test memory that cannot be freed.

  • Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::sampleTimerFired):

  • Shared/WebMemorySampler.h:

(WebMemorySampler):

  • Shared/mac/WebMemorySampler.mac.mm:

(WebKit):
(WebKit::WebMemorySampler::sendMemoryPressureEvent):

6:10 PM Changeset in webkit [119545] by rniwa@webkit.org
  • 4 edits in trunk/LayoutTests

Stop generating image results in the tests added by r114172.

Rubber-stamped by Simon Fraser.

  • css3/filters/huge-region-composited.html:
  • css3/filters/huge-region.html:
  • platform/chromium/TestExpectations:
6:01 PM Changeset in webkit [119544] by rniwa@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

Chromium rebaselines after r118772.

  • platform/chromium-mac-leopard/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.txt: Added.
  • platform/chromium-win/fast/forms/select/optgroup-rendering-expected.png: Added.
  • platform/chromium-win/fast/forms/select/optgroup-rendering-expected.txt: Added.
  • platform/chromium/TestExpectations:
5:57 PM Changeset in webkit [119543] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Build fix.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::createPlugin):
The error constant has been renamed.

5:48 PM Changeset in webkit [119542] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Rename a plug-in loading error constant
https://bugs.webkit.org/show_bug.cgi?id=88381
<rdar://problem/11602601>

Reviewed by Sam Weinig.

  • Misc/WebKitErrors.h:
5:47 PM Changeset in webkit [119541] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Fixing an incorrect path in lion Skipped file.

  • platform/mac-lion/Skipped:
5:39 PM Changeset in webkit [119540] by yosin@chromium.org
  • 24 edits in trunk/Source/WebCore

[Forms] Introduce InputNumber type as an alias of double for replacing it to Decimal
https://bugs.webkit.org/show_bug.cgi?id=88275

Reviewed by Kent Tamura.

This patch introduced InputNumber type as alias of double to be
replaced to Decimal and convertDoubleToInputNumber and
convertToInputNumberToDouble for reducing size of patch when we
introduce Decimal type.

This patch added new vairables to use const variable to reduce
copy operation when introducing Decimal type.

In the implementation, we use InputNumber, will be Decimal, however some methods in IDL
use double. To clarify internal usage of value and external usage, thit patch renamed
following functions:

  • parseToDouble => parseNumber
  • setValueAsNumber => setValueAsDouble and setValueAsInputNumber
  • valueAsNumber => valueAsDouble

This patch is a part of introducing Decimal, https://bugs.webkit.org/show_bug.cgi?id=80009

No new tests. This patch doesn't change behavior.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::valueAsDate): Replaced parseToNumber() to valueAsDouble()
(WebCore::BaseDateAndTimeInputType::setValueAsDate): Inserted convertDoubleToInputNumber.
(WebCore::BaseDateAndTimeInputType::valueAsDouble): Use new function parseToDouble().
(WebCore::BaseDateAndTimeInputType::setValueAsInputNumber): Added.
(WebCore::BaseDateAndTimeInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::BaseDateAndTimeInputType::parseToNumber): This is replacement of parseToDouble().
(WebCore::BaseDateAndTimeInputType::parseToDouble): Added for valueAsDate and valueAsDouble.
(WebCore::BaseDateAndTimeInputType::serialize): Changed parameter type to InputNumber.
(WebCore::BaseDateAndTimeInputType::serializeWithComponents): Replace double to InputNumber for getAllowdStep.

  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType):

  • html/DateInputType.cpp:

(WebCore::DateInputType::createStepRange): Replaced double to InputNumber.

  • html/DateInputType.h:

(DateInputType):

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::DateTimeInputType::createStepRange): Replaced double to InputNumber.

  • html/DateTimeInputType.h:

(DateTimeInputType):

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::createStepRange): Replaced double to InputNumber.

  • html/DateTimeLocalInputType.h:

(DateTimeLocalInputType):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::getAllowedValueStep): Changed parameter type to InputNumber.
(WebCore::HTMLInputElement::valueAsNumber): Use InputType::valueAsDouble.
(WebCore::HTMLInputElement::setValueAsNumber): Use InputType::valueAsDouble.

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::valueAsDouble): Replacement of valueAsNumber.
(WebCore::InputType::setValueAsDouble): Replacement of valueAsNumber.
(WebCore::InputType::setValueAsInputNumber): Replacement of valueAsNumber.
(WebCore::InputType::rangeUnderflow): Replaced double to InputNumber.
(WebCore::InputType::rangeOverflow): Replaced double to InputNumber.
(WebCore::InputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::InputType::isInRange): Replaced double to InputNumber.
(WebCore::InputType::isOutOfRange): Replaced double to InputNumber.
(WebCore::InputType::stepMismatch): Replaced double to InputNumber.
(WebCore::InputType::validationMessage): Replaced double to InputNumber.
(WebCore::InputType::parseToNumber): Replacement of parseToDouble.
(WebCore::InputType::parseToNumberOrNaN): Added for reducing number of std::numeric_limits<double>::quiet_NaN().
(WebCore::InputType::parseToNumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::InputType::serialize): Changed parameter type to InputNumber.
(WebCore::InputType::applyStep): Replaced double to InputNumber.
(WebCore::InputType::getAllowedValueStep): Changed parameter type to InputNumber.
(WebCore::InputType::stepUpFromRenderer): Replaced double to InputNumber.

  • html/InputType.h:

(InputType):

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::MonthInputType::createStepRange): Replaced double to InputNumber.
(WebCore::MonthInputType::parseToNumber): Replacement of parseToDouble.

  • html/MonthInputType.h:

(MonthInputType):

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::valueAsDouble): Replacement of valueAsNumber. Changed to use parseToDoubleForNumberType.
(WebCore::NumberInputType::setValueAsDouble): Replacement of setValueAsNumber. Changed to use serializeForNumberType.
(WebCore::NumberInputType::setValueAsInputNumber): Replacement of setValueAsNumber.
(WebCore::NumberInputType::createStepRange): Replaced double to InputNumber.
(WebCore::NumberInputType::parseToNumber): Replacement of parseToDouble.
(WebCore::NumberInputType::parseToNumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::NumberInputType::serialize):

  • html/NumberInputType.h:

(NumberInputType):

  • html/RangeInputType.cpp:

(WebCore::ensureMaximum): Replaced double to InputNumber.
(WebCore::RangeInputType::valueAsDouble): Replacement of valueAsNumber.
(WebCore::RangeInputType::setValueAsInputNumber): Replacement of setValueAsNumber.
(WebCore::RangeInputType::createStepRange): Replaced double to InputNumber.
(WebCore::RangeInputType::handleKeydownEvent): Replaced double to InputNumber.
(WebCore::RangeInputType::parseToNumber): Replacement of parseToDouble.
(WebCore::RangeInputType::serialize): Changed parameter type to InputNumber.
(WebCore::RangeInputType::sanitizeValue): Replaced double to InputNumber.

  • html/RangeInputType.h:

(RangeInputType):

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange): Replaced double to InputNumber.
(WebCore::StepRange::acceptableError): Replaced double to InputNumber.
(WebCore::StepRange::alignValueForStep): Replaced double to InputNumber.
(WebCore):
(WebCore::StepRange::clampValue): Replaced double to InputNumber.
(WebCore::StepRange::stepMismatch): Replaced double to InputNumber.

  • html/StepRange.h:

(WebCore::convertDoubleToInputNumber): Added.
(WebCore::convertInputNumberToDouble): Added.
(WebCore::StepRange::NumberWithDecimalPlaces::NumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::StepRange::StepDescription::defaultValue): Replaced double to InputNumber.
(StepRange):
(WebCore::StepRange::maximum): Replaced double to InputNumber.
(WebCore::StepRange::minimum): Replaced double to InputNumber.
(WebCore::StepRange::step): Replaced double to InputNumber.
(WebCore::StepRange::stepBase): Replaced double to InputNumber.
(WebCore::StepRange::defaultValue): Replaced double to InputNumber.
(WebCore::StepRange::proportionFromValue): Replaced double to InputNumber.
(WebCore::StepRange::valueFromProportion): Replaced double to InputNumber.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::defaultValueForStepUp): Replaced double to InputNumber.
(WebCore::TimeInputType::createStepRange): Replaced double to InputNumber.

  • html/TimeInputType.h:

(TimeInputType):

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::createStepRange): Replaced double to InputNumber.

  • html/WeekInputType.h:

(WeekInputType):

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::writeDocument): Replaced double to InputNumber.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderPosition): Replaced double to InputNumber.
(WebCore::RenderSliderThumb::layout): Replaced double to InputNumber.
(WebCore::SliderThumbElement::setPositionFromPoint): Replaced double to InputNumber.

5:38 PM Changeset in webkit [119539] by eae@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed gardening. Chromium windows test expectation updates.

  • platform/chromium-win/fast/sub-pixel: Added.
  • platform/chromium-win/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • platform/chromium/TestExpectations:
5:32 PM Changeset in webkit [119538] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140528 to r140653.

  • DEPS:
5:31 PM Changeset in webkit [119537] by leviw@chromium.org
  • 37 edits
    18 adds in trunk/LayoutTests

Unreviewed gardening. More updated Chromium test expectations following 119528.

  • platform/chromium-linux-x86/editing/selection: Added.
  • platform/chromium-linux-x86/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/3690703-expected.png: Added.
  • platform/chromium-linux-x86/editing/selection/3690719-expected.png: Added.
  • platform/chromium-linux-x86/fast/sub-pixel: Added.
  • platform/chromium-linux-x86/fast/sub-pixel/selection: Added.
  • platform/chromium-linux-x86/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-linux/fast/sub-pixel: Added.
  • platform/chromium-linux/fast/sub-pixel/selection: Added.
  • platform/chromium-linux/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac/fast/sub-pixel/selection: Added.
  • platform/chromium-mac/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-win-vista/fast/sub-pixel: Added.
  • platform/chromium-win-vista/fast/sub-pixel/selection: Added.
  • platform/chromium-win-vista/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-win/editing/selection/3690703-2-expected.png:
  • platform/chromium-win/editing/selection/3690703-expected.png:
  • platform/chromium-win/editing/selection/3690719-expected.png:
  • platform/chromium-win/fast/sub-pixel: Added.
  • platform/chromium-win/fast/sub-pixel/selection: Added.
  • platform/chromium-win/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium/TestExpectations:
5:25 PM Changeset in webkit [119536] by rniwa@webkit.org
  • 4 edits
    4 adds
    1 delete in trunk/LayoutTests

Chromium rebaselines for r119523 and r119529.

  • platform/chromium-linux/compositing/layer-creation: Removed.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/chromium-win/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
  • platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
5:15 PM Changeset in webkit [119535] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/11575898> and https://bugs.webkit.org/show_bug.cgi?id=88372
REGRESSION(110494): Can no longer drag-and-drop links into FileMaker Pro 12

  • Before r110494 we used to write the NSStringPboardType to the pasteboard. After r110494 we write NSURLPboardType instead. That's basically a no-op, but the NSStringPboardType needs to be restored.
  • Before r110494 we wrote the link destination URL to the pasteboard. After r110494 we write the image src URL if the link is an image. We need to revert to writing the link URL.

Fortunately these changes can be accomplished with a 2-line fix.

Reviewed by Enrica Casucci.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
n

5:05 PM Changeset in webkit [119534] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r119527.

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):

4:12 PM Changeset in webkit [119533] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Cairo] [OpenGL] Enable GL_OES_standard_derivatives
https://bugs.webkit.org/show_bug.cgi?id=87583

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-05
Reviewed by Alejandro G. Castro.

No new tests. This is covered by oes-standard-derivatives.html
in the Khronos WebGL conformance tests, which may one day be part
of the WebKit test suite.

Activate the GL_OES_standard_derivatives on Cairo along with
Qt and Mac.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):

3:45 PM Changeset in webkit [119532] by jonlee@apple.com
  • 2 edits in trunk/Tools

Buildbot fix.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier

in the function. Store in a local variable.
(loadBuilderConfig):

3:28 PM Changeset in webkit [119531] by leviw@chromium.org
  • 3 edits in trunk/LayoutTests

Fixing two leopard-specific baselines following r119528.

  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
3:19 PM Changeset in webkit [119530] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectations.

  • platform/chromium/TestExpectations:
3:18 PM Changeset in webkit [119529] by Simon Fraser
  • 8 edits
    1 copy
    1 add in trunk

Avoid creating compositing layers for preserve-3d without transformed descendants
https://bugs.webkit.org/show_bug.cgi?id=88115

Source/WebCore:

Reviewed by Antti Koivisto.

Avoid creating compositing layers, and therefore using excess backing store,
for elements that have -webkit-transform-style: preserve-3d, but no 3D-transformed
descendants that would be affected by that preserve-3d.

Test: compositing/layer-creation/no-compositing-for-preserve-3d.html

  • rendering/RenderLayer.h: Replace the "mustOverlap" flag with a enum

that describes the different reasons for indirect compositing, so that
we can use that information to decide whether to allocate backing store.
(WebCore::RenderLayer::setIndirectCompositingReason):
(WebCore::RenderLayer::indirectCompositingReason):
(WebCore::RenderLayer::mustCompositeForIndirectReasons):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer): Initialize m_indirectCompositingReason

  • rendering/RenderLayerCompositor.h: New out param for computeCompositingRequirements()

that is uses to indicate that a 3d-transformed descendant has been encountered.
Rename requiresCompositingWhenDescendantsAreCompositing() to requiresCompositingForIndirectReason(),
and return the reason as an out param.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers): Pass in the saw3DTransform
param to computeCompositingRequirements().
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Return a flag
from computeCompositingRequirements() that is set to true if we've seen descendants
that have 3d transforms. This is later used to decide whether to composite for
perspective or preserve-3d.
Change the "mustOverlapCompositedLayers" code to use the new "indirect compositing"
enum flags.
After enumerating children, call requiresCompositingForIndirectReason() and
record the reason in the layer.
(WebCore::RenderLayerCompositor::needsToBeComposited): Use mustCompositeForIndirectReasons() now.
(WebCore::RenderLayerCompositor::requiresOwnBackingStore): Consult the indirect compositing
reason rather than just looking for the overlap flag.
(WebCore::RenderLayerCompositor::reasonForCompositing): Now that we have more information
about indirect compositing reasons, the logging can be more detailed.
(WebCore::RenderLayerCompositor::requiresCompositingForTransform): This now only looks
for 3d transforms. We now treat perspective and perserve-3d as "indirect" reasons, because
whether they composite depends on descendants having non-affine transforms.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): Includes the logic
previously in requiresCompositingWhenDescendantsAreCompositing(), and now determines
whether to composite for preserve-3d and perspective, based on whether we have transformed descendants.

LayoutTests:

Reviewed by Antti Koivisto.

  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/backing/no-backing-for-perspective.html: Change the transform to be non-affine so that

we keep making layers for perspective.

  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
  • compositing/layer-creation/no-compositing-for-preserve-3d.html: Copied from LayoutTests/compositing/backing/no-backing-for-perspective.html.
2:56 PM Changeset in webkit [119528] by leviw@chromium.org
  • 37 edits
    6 adds in trunk

Block selection gaps painted not properly pixel snapped
https://bugs.webkit.org/show_bug.cgi?id=88000

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixes for selection painting in both inline line heights and block gaps. We were unintentionally
flooring inline and block offsets in RenderBlock, but actually need to intentionally floor the
logical left and right values in logical(Left|Right)SelectionGap to properly align our block
selection gaps. This is to properly mirror the behavior in pixelSnappedLogicalRightOffsetForLine.

We were also unintentionally upcasting LayoutUnits to floats in InlineTextBox's selection painting
routine. Now we're properly rounding.

Test: fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintSelection): Move paint values to integers and do proper rounding.

  • rendering/RenderBlock.cpp:

(WebCore::blockDirectionOffset): Fix incorrect flooring in return value.
(WebCore::inlineDirectionOffset): Ditto.
(WebCore): Removing previous attempt to properly mirror inline box selection pixel alignment. This
implementation rounded the final x value instead of properly rounding our block offset then flooring
the offset that corresponds to the behavior in InlineTextBox. It also didn't properly pixel snap
the y offset and height.
(WebCore::RenderBlock::blockSelectionGap): Properly pixel snapping the gap rect before painting.
(WebCore::RenderBlock::logicalLeftSelectionGap): Correctly match InlineTextBox's selection pixel
alignment by flooring the logicalLeft and pixel snapping the subsequent rect. We do this in order
to maintain proper render tree pixel snapping while simultaneously mirroring the flooring in the
inline direction that occurs in InlineTextBox.cpp's alignSelectionRectToDevicePixels method.
(WebCore::RenderBlock::logicalRightSelectionGap): Ditto with the right.

LayoutTests:

One new selection test and updated snowleopard expectations for a handful that improved.

Note: a couple of the RTL results appear worse, but sadly are only returning to our old pre-sub-pixel results.

  • fast/sub-pixel/selection: Added.
  • fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Added.
  • fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html: Added.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/chromium-mac-snowleopard/fast/sub-pixel: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/selection: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/gtk-wk2/Skipped:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
2:36 PM Changeset in webkit [119527] by abarth@webkit.org
  • 10 edits
    12 deletes in trunk

Remove support for target-densitydpi in the viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=88047

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The target-densitydpi parameter was originally implemented on Android,
but it does not appear to be widely used and introduces significant
implementation complexity because it forces us to track three scale
factors (defaultDeviceScaleFactor, deviceScaleFactor, and
pageScaleFactor) rather than just two (deviceScaleFactor and
pageScaleFactor).

There don't appear to be many web sites that use target-densitydpi
because it is not supported on iOS. There are also concerns from the
standards community about the design of the feature. It seems our best
course of action is to remove target-densitydpi and address these use
cases via other mechanisms, such as responsive images and device units
in CSS because those approaches are likely to be implemented broadly.

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):
(WebCore):
(WebCore::setViewportFeature):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):

  • dom/ViewportArguments.h:

(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

  • Api/WebViewportArguments.cpp:

(BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):

  • Api/WebViewportArguments.h:

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

LayoutTests:

These tests are no longer needed because they're testing a feature we
no longer support.

  • fast/viewport/viewport-133-expected.txt: Removed.
  • fast/viewport/viewport-133.html: Removed.
  • fast/viewport/viewport-92-expected.txt: Removed.
  • fast/viewport/viewport-92.html: Removed.
  • fast/viewport/viewport-93-expected.txt: Removed.
  • fast/viewport/viewport-93.html: Removed.
  • fast/viewport/viewport-94-expected.txt: Removed.
  • fast/viewport/viewport-94.html: Removed.
  • fast/viewport/viewport-95-expected.txt: Removed.
  • fast/viewport/viewport-95.html: Removed.
  • fast/viewport/viewport-96-expected.txt: Removed.
  • fast/viewport/viewport-96.html: Removed.
2:32 PM Changeset in webkit [119526] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFG simplification should not attempt to deref nodes inside of an unreachable subgraph
https://bugs.webkit.org/show_bug.cgi?id=88362

Reviewed by Gavin Barraclough.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::fixPhis):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):

2:31 PM Changeset in webkit [119525] by kerz@chromium.org
  • 6 edits
    2 deletes in branches/chromium/1132/Source

Revert 119486 - Merge 117978 - IndexedDB: Fire error when there are problems opening a DB
https://bugs.webkit.org/show_bug.cgi?id=85579

Source/WebCore:

We used to either fire success or get into an infinite loop.

Reviewed by Tony Chang.

New unit test in
Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::openConnection):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::create):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openInternal):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/IDBAbortOnCorruptTest.cpp: Added.

(WebCore):
(MockIDBCallbacks):
(WebCore::MockIDBCallbacks::MockIDBCallbacks):
(WebCore::MockIDBCallbacks::~MockIDBCallbacks):
(WebCore::MockIDBCallbacks::onError):
(WebCore::MockIDBCallbacks::onSuccess):
(WebCore::MockIDBCallbacks::onSuccessWithContinuation):
(WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
(WebCore::MockIDBCallbacks::onBlocked):
(FailingBackingStore):
(WebCore::FailingBackingStore::~FailingBackingStore):
(WebCore::FailingBackingStore::open):
(WebCore::FailingBackingStore::createIDBDatabaseMetaData):
(FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::~FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::create):
(WebCore::FailingIDBFactoryBackendImpl::removeIDBDatabaseBackend):
(WebCore::FailingIDBFactoryBackendImpl::openBackingStore):
(WebCore::TEST):

  • tests/IDBFakeBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h.

(WebCore):
(IDBFakeBackingStore):

TBR=dgrogan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10536007

TBR=dgrogan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10534013

2:24 PM Changeset in webkit [119524] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectations.

  • platform/chromium/TestExpectations:
2:16 PM Changeset in webkit [119523] by eae@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed chromium mac rebaseline for float-containing-block-with-margin.

  • platform/chromium-mac-leopard/fast/sub-pixel: Added.
  • platform/chromium-mac-leopard/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png:
1:54 PM Changeset in webkit [119522] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add Chromium test failure expectations per Skia roll:
http://src.chromium.org/viewvc/chrome?view=rev&revision=140580

  • platform/chromium/TestExpectations:
1:53 PM Changeset in webkit [119521] by jonlee@apple.com
  • 2 edits in trunk/Tools

Buildbot fix.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

1:47 PM Changeset in webkit [119520] by dpranke@chromium.org
  • 12 edits in trunk/Tools

webkitpy: clean up win-specific path handling and tests
https://bugs.webkit.org/show_bug.cgi?id=88281

Reviewed by Adam Barth.

There was a bunch of inconsistent logic for handling path
conversions for win32 and cygwin paths due to us sometimes
looking at sys.platform and sometimes using mock hosts. This
patch cleans everything up so that we are required to pass
PlatformInfo objects to the path module and stop trying to do
different things when running on cygwin or win32 hosts (except
in the path_unittest module itself).

This may slightly reduce test coverage for the win32 code paths
but will be a lot easier to follow and maintain.

  • Scripts/webkitpy/common/system/path.py:

(abspath_to_uri):
(_convert_path):

  • Scripts/webkitpy/common/system/path_unittest.py:

(AbspathTest.platforminfo):
(AbspathTest.test_abspath_to_uri_cygwin):
(AbspathTest.test_abspath_to_uri_unixy):
(AbspathTest.test_abspath_to_uri_win):
(AbspathTest.test_abspath_to_uri_escaping_unixy):
(AbspathTest.test_abspath_to_uri_escaping_cygwin):
(AbspathTest.test_stop_cygpath_subprocess):

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init):
(PlatformInfo.is_cygwin):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.is_cygwin):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.show_results_html_file):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.test_to_uri):
(Driver.uri_to_test):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverTest.test_test_to_uri):
(DriverTest.test_uri_to_test):

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:

(MockDRTPortTest.make_port):
(MockDRTTest.input_line):
(MockChromiumDRTTest.test_pixeltestfails):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort.show_results_html_file):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_unexpected_failures):
(MainTest.test_results_directory_absolute):
(MainTest.test_results_directory_default):
(MainTest.test_results_directory_relative):

1:41 PM Changeset in webkit [119519] by jonlee@apple.com
  • 3 edits in trunk/Tools

Workaround buildbot bug when merging build requests.
https://bugs.webkit.org/show_bug.cgi?id=88158

Reviewed by Mark Rowe.

For expediency, we still want testers to pick the latest build to test, but to ensure
that the builders are reporting the correct revision number, we should let the building bots
run as they normally would. That is, the builder picks the oldest revision, and merges
subsequent requests. Because merged requests get appended to the list of changes for a given
build, the last change in that list is also the latest change. When we used pickLatestBuild
for the builders, this was not the case (it would always report the penultimate change).

http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override

for all Apple builders.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick

the latest build to run.
(loadBuilderConfig):

1:38 PM Changeset in webkit [119518] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Entry into JSC should CRASH() if the Heap is busy
https://bugs.webkit.org/show_bug.cgi?id=88355

Reviewed by Geoffrey Garen.

Interpreter::execute() returns jsNull() right now if we try to enter it while
the Heap is busy (e.g. with a collection), which is okay, but some code paths
that call Interpreter::execute() allocate objects before checking if the Heap
is busy. Attempting to execute JS code while the Heap is busy should not be
allowed and should be enforced by a release-mode CRASH() to prevent vague,
unhelpful backtraces later on if somebody makes a mistake. Normally, recursively
executing JS code is okay, e.g. for evals, but it should not occur during a
Heap allocation or collection because the Heap is not guaranteed to be in a
consistent state (especially during collections). We are protected from
executing JS on the same Heap concurrently on two separate threads because
they must each take a JSLock first. However, we are not protected from reentrant
execution of JS on the same thread because JSLock allows reentrancy. Therefore,
we should fail early if we detect an entrance into JS code while the Heap is busy.

  • heap/Heap.cpp: Changed Heap::collect so that it sets the m_operationInProgress field

at the beginning of collection and then unsets it at the end so that it is set at all
times throughout the duration of a collection rather than sporadically during various
phases. There is no reason to unset during a collection because our collector does
not currently support running additional JS between the phases of a collection.
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::collect):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute): Crash if the Heap is busy.

  • runtime/Completion.cpp: Crash if the Heap is busy. We do it here before we call

Interpreter::execute() because we do some allocation prior to calling execute() which
could cause Heap corruption if, for example, that allocation caused a collection.
(JSC::evaluate):

1:21 PM NewRunWebKitTests edited by alex.bravo@nokia.com
Removed link to HackingOnNewRunWebKitTests as it onlyhas a link back … (diff)
1:06 PM Changeset in webkit [119517] by vestbo@webkit.org
  • 4 edits
    1 copy in trunk/Source/WebKit2

[Qt] Implement log channel initialization for WebKit2

Reviewed by Alexis Menard.

12:59 PM Changeset in webkit [119516] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

WebLayerTreeRenderer behaves wrongly when no contentsScale is set.
https://bugs.webkit.org/show_bug.cgi?id=88357

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-06-05
Reviewed by Alexis Menard.

The contentsScale needs to get a default value in case no
value is explicitely set yet.
This fixes the blank-until-resize problem when running MiniBrowser
in --desktop mode.

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):

12:52 PM Changeset in webkit [119515] by timothy_horton@apple.com
  • 2 edits
    2 deletes in trunk/LayoutTests

Assertion failure on mac-lion-wk2 in fast/hidpi/device-scale-factor-paint.html
https://bugs.webkit.org/show_bug.cgi?id=88356

Unreviewed, remove incorrect baselines and skip test on Mac.

  • platform/mac/Skipped:
  • platform/mac/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
  • platform/mac/fast/hidpi/device-scale-factor-paint-expected.txt: Removed.
12:22 PM Changeset in webkit [119514] by arv@chromium.org
  • 6 edits
    1 copy
    3 adds in trunk

[V8] Improve variable resolution order on window
https://bugs.webkit.org/show_bug.cgi?id=84247

Reviewed by Ojan Vafai.

This changes the V8 flag to turn on es52_globals and updates the layout tests to reflect the fixed behavior.

Source/WebCore:

Test: fast/dom/Window/window-property-shadowing-onclick.html

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded): Set the flag as we initialize V8.

  • bindings/v8/WorkerContextExecutionProxy.cpp:

(WebCore::WorkerContextExecutionProxy::initIsolate): Ditto.

LayoutTests:

  • fast/dom/Window/window-property-shadowing-name-expected.txt: The expectation is now reversed.
  • fast/dom/Window/window-property-shadowing-name.html: JSC fails so this test says fail. Bug 75575 tracks JSC.
  • fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
  • fast/dom/Window/window-property-shadowing-onclick.html: Added.
  • platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Copied from LayoutTests/fast/dom/Window/window-property-shadowing-name-expected.txt.
  • platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
12:16 PM Changeset in webkit [119513] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Delete dead code from RenderBox::computeLogicalWidthInRegion
https://bugs.webkit.org/show_bug.cgi?id=88353

Reviewed by Tony Chang.

No new tests obviously since this is dead code.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):

12:16 PM Changeset in webkit [119512] by eae@chromium.org
  • 3 edits
    3 adds
    1 delete in trunk/LayoutTests

Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test
https://bugs.webkit.org/show_bug.cgi?id=88351

Reviewed by Levi Weintraub.

Change fast/sub-pixel/float-containing-block-with-margin.html to pixel
test to allow for platform differences as the default styling makes it
very hard to use a reftests for this.

  • fast/sub-pixel/float-containing-block-with-margin-expected.html: Removed.
  • fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • fast/sub-pixel/float-containing-block-with-margin-expected.txt: Added.
  • fast/sub-pixel/float-containing-block-with-margin.html:
  • platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
  • platform/chromium/TestExpectations:
12:01 PM Changeset in webkit [119511] by leviw@chromium.org
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed gardening. Fixing improper text expectation following r119503.

  • platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/chromium-win/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/chromium/fast/line-grid: Added.
  • platform/chromium/fast/line-grid/line-align-left-edges-expected.txt: Added.
11:53 AM Changeset in webkit [119510] by pilgrim@chromium.org
  • 8 edits
    2 copies in trunk/Source

[Chromium] Move createLocalStorageNamespace to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85766

Source/Platform:

Reviewed by James Robinson.

Part of a refactoring series. See tracking bug 82948.

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::createLocalStorageNamespace):

  • chromium/public/WebStorageArea.h: Added.

(WebKit):
(WebStorageArea):
(WebKit::WebStorageArea::~WebStorageArea):
(WebKit::WebStorageArea::setItem):
(WebKit::WebStorageArea::removeItem):
(WebKit::WebStorageArea::clear):

  • chromium/public/WebStorageNamespace.h: Added.

(WebKit):
(WebStorageNamespace):
(WebKit::WebStorageNamespace::~WebStorageNamespace):
(WebKit::WebStorageNamespace::isSameNamespace):

Source/WebKit/chromium:

Reviewed by James Robinson.

Part of a refactoring series. See tracking bug 82948.

  • WebKit.gyp:
  • public/WebStorageArea.h:
  • public/WebStorageNamespace.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):

11:53 AM Changeset in webkit [119509] by rniwa@webkit.org
  • 5 edits
    4 adds in trunk/LayoutTests

Chromium rebaseline per Chromium r140536.

  • platform/chromium-linux-x86/http/tests/media: Added.
  • platform/chromium-linux-x86/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win-vista/http/tests/media: Added.
  • platform/chromium-win-vista/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
11:39 AM Changeset in webkit [119508] by commit-queue@webkit.org
  • 10 edits in trunk

New constructor for WebIntent to be used for delivery
https://bugs.webkit.org/show_bug.cgi?id=87143

Patch by Greg Billock <gbillock@google.com> on 2012-06-05
Reviewed by Darin Fisher.

Source/WebCore:

  • Modules/intents/Intent.cpp:

(WebCore::Intent::setExtras):
(WebCore):

  • Modules/intents/Intent.h:

(Intent):

Source/WebKit/chromium:

When delivering an intent to webkit, the caller needs to be able to
provide the action, type, and data, and also extra data and ports.

  • public/WebIntent.h:

(WebIntent):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::deliverIntent):

  • src/WebIntent.cpp:

(WebKit::WebIntent::WebIntent):
(WebKit):
(WebKit::WebIntent::reset):
(WebKit::WebIntent::messagePortChannelsRelease):

11:32 AM Changeset in webkit [119507] by ojan@chromium.org
  • 16 edits
    2 adds in trunk

Change overrideSizes to be content-box instead of border-box
https://bugs.webkit.org/show_bug.cgi?id=88116

Reviewed by Tony Chang.

Source/WebCore:

Previously, the code used border-box everywhere except for one place
where it used content-box when setting the override size. Conversely,
it subtracted the borderAndPaddingSize everywhere it grabbed the override
size except for one.

Instead, make the override size override the content-box size.
Converging on using the border-box size would be tricky given RenderTableCell's
tricky management of intrinsic padding.

There is no behavior change except in RenderBox::availableLogicalHeightUsing,
which fixes a table test.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::setOverrideLogicalContentHeight):
(WebCore::RenderBox::setOverrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentHeight):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
We were incorrectly subtracting the borderAndPaddingLogicalWidth instead
of the borderAndPaddingLogicalHeight.

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeAvailableFreeSpace):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):

LayoutTests:

  • fast/table/padding-height-and-override-height-expected.txt:
  • fast/table/padding-height-and-override-height.html:

Tests the change in RenderBox::availableLogicalHeightUsing to correctly subtract the
borderAndPaddingLogicalHeight instead of the borderAndPaddingLogicalWidth.

  • platform/chromium-linux/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug131020-expected.txt:

The new results are more correct. The table cell had 2px too much padding-top and padding-bottom before.

11:28 AM Changeset in webkit [119506] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r118197): PluginStrategy should be used even if ENABLE(NETSCAPE_PLUGIN_API) is false
https://bugs.webkit.org/show_bug.cgi?id=88296

Reviewed by Dan Bernstein.

refresh() and initPlugins() should call into PluginStrategy even if
ENABLE(NETSCAPE_PLUGIN_API) is false. Some ports support non-Netscape
plug-ins, so PluginStrategy should be consulted even if Netscape
plug-ins specifically are disabled.

Ports that support platform strategies but not Netscape plug-ins should
handle this inside their PluginStrategy rather than modifying generic
plug-in code.

  • plugins/PluginData.cpp:

(WebCore::PluginData::refresh):
(WebCore::PluginData::initPlugins):

11:23 AM Changeset in webkit [119505] by jberlin@webkit.org
  • 2 edits in trunk/Tools

[Win] DumpRenderTree should call resetInternalsObject
https://bugs.webkit.org/show_bug.cgi?id=88346

Reviewed by Simon Fraser.

Invoke it on Windows in the same place it is invoked on Mac.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

11:15 AM Changeset in webkit [119504] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/media/remove-while-loading.html times out on mac-lion-wk2
https://bugs.webkit.org/show_bug.cgi?id=88348

Unreviewed skip of this test for greenness.

  • platform/mac-wk2/Skipped:
11:13 AM Changeset in webkit [119503] by leviw@chromium.org
  • 43 edits
    4 adds
    3 deletes in trunk/LayoutTests

Unreviewed gardening. Updating test expectations after r119456.

  • fast/line-grid/line-grid-contains-value-expected.txt: Added.
  • platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-leopard/fast/forms/001-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac-leopard/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-mac/fast/forms/001-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.txt:
  • platform/chromium-mac/fast/inline/inline-box-background-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.png:
  • platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.txt: Added.
  • platform/chromium-mac/fast/line-grid/line-grid-contains-value-expected.txt: Added.
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-win/fast/line-grid/line-align-left-edges-expected.png:
  • platform/chromium-win/fast/line-grid/line-align-left-edges-expected.txt: Added.
  • platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/line-grid: Removed.
  • platform/chromium/fast/line-grid/line-align-left-edges-expected.txt: Removed.
  • platform/efl/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
  • platform/gtk/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
11:05 AM Changeset in webkit [119502] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash when modifying fixed-position elements in a detached frame
https://bugs.webkit.org/show_bug.cgi?id=88288

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-06-05
Reviewed by James Robinson.

Source/WebCore:

Test: fast/block/positioning/fixed-position-detached-frame.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

  • fast/block/positioning/fixed-position-detached-frame-expected.txt: Added.
  • fast/block/positioning/fixed-position-detached-frame.html: Added.
10:33 AM Changeset in webkit [119501] by leviw@chromium.org
  • 1 move in branches/old/subpixellayout

Moving the sub-pixel layout branch to branches/old since the feature has landed and development on the branch has ceased.

10:22 AM Changeset in webkit [119500] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS from r140492 to r140528.

  • DEPS:
10:12 AM Changeset in webkit [119499] by caseq@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

Web Inspector: render timeline paint category dark green
https://bugs.webkit.org/show_bug.cgi?id=88333

Reviewed by Pavel Feldman.

  • Added a new, dark-green color for timeline events.
  • WebCore.gypi: Added timelineBarDarkGreen.png
  • inspector/front-end/Images/timelineBarDarkGreen.png: Added.
  • inspector/front-end/Images/timelineCheckmarks.png: Added a dark-green checkbox.
  • inspector/front-end/Images/timelineDots.png: Added a dark-green dot.
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.categories):

  • inspector/front-end/WebKit.qrc: Added timelineBarDarkGreen.png.
  • inspector/front-end/timelinePanel.css:

(.timeline-category-statusbar-item.timeline-category-painting .timeline-category-checkbox):
(.timeline-category-painting .timeline-graph-bar):
(.popover .timeline-painting):
(.timeline-category-painting .timeline-tree-icon):

10:08 AM Changeset in webkit [119498] by loislo@chromium.org
  • 8 edits in trunk

Web Inspector: serialize edge counts instead of indexes in heap snapshot
https://bugs.webkit.org/show_bug.cgi?id=88324

The serialized node structure currently holds an index
of its first containment edge in the edges array.
The index can be quite big (up to 7 digits for large snapshots).
The patch changes the serialization format to pass
node containment edge count instead. For most nodes the count
is just a single digit number.
This reduces serialized snapshot size and therefore its transfer time.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-05
Reviewed by Yury Semikhatsky.

PerformanceTests:

  • inspector/heap-snapshot-performance-test.js:

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype._edgeIndexesStart):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesEnd):
(WebInspector.HeapSnapshotNode.prototype._ordinal):
(WebInspector.HeapSnapshotNodeIterator):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildEdgeIndexes):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatorTree):
(WebInspector.HeapSnapshot.prototype._markPageOwnedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

  • inspector/profiler/heap-snapshot-expected.txt:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest.):

  • inspector/profiler/heap-snapshot.html:
10:01 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
9:30 AM Changeset in webkit [119497] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Don't propagate viewport size changes if the viewport is empty.
https://bugs.webkit.org/show_bug.cgi?id=88336

Reviewed by Tor Arne Vestbø.

Qt Quick sequentially set the x, y, width, height of the view. We really want to
start propagating further when the size of the viewport becomes valid, i.e. both
height and width are defined. In any case lower level classes are discarding an empty
size such as WebPage::sendViewportAttributesChanged() so it was pointless to send the size
through the IPC bus for nothing.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewLegacyPrivate::updateViewportSize):

9:23 AM Changeset in webkit [119496] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Web Inspector highlight is slow
https://bugs.webkit.org/show_bug.cgi?id=88331

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-05
Reviewed by Rob Buis.

Highlight is slow on large pages because of constant repaint calls.
Change to use the accelerated layer highlight all the time.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::renderContents):

  • WebCoreSupport/InspectorClientBlackBerry.cpp:

(WebCore::InspectorClientBlackBerry::highlight):
(WebCore::InspectorClientBlackBerry::hideHighlight):

  • WebCoreSupport/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::clear):
(WebCore::InspectorOverlay::update):

9:18 AM Changeset in webkit [119495] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Fix two more memory leaks in DRT
https://bugs.webkit.org/show_bug.cgi?id=88255

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-05
Reviewed by Martin Robinson.

Fixed memory leaks in GTK's DRT code.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(dumpHistoryItem): webkit_web_history_item_get_target() returns a
g_strdup()'d string. So, use GOwnPtr to manage memory automatically.

  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:

(createBitmapContextFromWebView): Free the cairo surface.

9:04 AM Changeset in webkit [119494] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] There is no way to retrieve composition character rectangle in WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=87911

Patch by Seigo Nonaka <nona@chromium.org> on 2012-06-05
Reviewed by Ryosuke Niwa.

Add an API for retreieving each character bounds in composition text.
This API is necessary for implementing IMR_QUERYCHARPOSITION message in Windows.
The message is used by Japanese IME for showing their window at the correct position.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::compositionCharacterBounds):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::compositionCharacterBounds):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

8:47 AM Changeset in webkit [119493] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

[GTK] Add webkit_download_get_received_data_length to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=88323

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitDownload.cpp:

(webkit_download_get_received_data_length):

  • UIProcess/API/gtk/WebKitDownload.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestDownloads.cpp:
8:37 AM Changeset in webkit [119492] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk

CSS 2.1 failure: border-conflict-element-021a
https://bugs.webkit.org/show_bug.cgi?id=86885

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-06-05
Reviewed by Julien Chaffraix.

Source/WebCore:

When two adjacent table row groups (thead, tbody, tfoot) have the same border-width
and the same border-style in a 'border-collapse: collapse' table the color of the border
from the top-most table row wins.

Tests: fast/table/border-collapsing/adjacent-row-groups-multi.html

fast/table/border-collapsing/adjacent-row-groups.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintObject):
Currently each row group is sent for paint from top (firstChild) to bottom thereby causing
the borders of the bottom-most row group (which is painted last) to overlap over the
previous row-group. This breaks the precedence for collapsed borders between adjacent cells.

This fix thus reverses the order in which the row-groups/sections are passed for painting.
Additional change has been done to iterate over the RenderTableSections directly.

(WebCore):
(WebCore::RenderTable::bottomSection):

  • rendering/RenderTable.h:

New function has been added to obtain the last section of the table.

(RenderTable):

  • rendering/RenderTableSection.h:

(RenderTableSection):
RenderTableSection's paint() method has now been made public so as to make it accessible
from RenderTable.

LayoutTests:

  • css2.1/20110323/border-conflict-element-021a-expected.html: Added.
  • css2.1/20110323/border-conflict-element-021a.htm: Added.

Added ref test under the css2.1 test-suite for border-conflict-element-021a.

  • fast/table/border-collapsing/adjacent-row-groups-expected.html: Added.
  • fast/table/border-collapsing/adjacent-row-groups.html: Added.

Added ref test for verifying 'border-collapse: collapse' table rendering when two
adjacent table row-groups have the same border-width and the same border-style. In
such a case the color of the border from the top-most table row-group wins.

  • fast/table/border-collapsing/adjacent-row-groups-multi.html: Added.
  • fast/table/border-collapsing/adjacent-row-groups-multi-expected.html: Added.

Additional ref test added for verifying 'border-collapse: collapse' table rendering
for adjacent table row-groups when more than one table headers and/or footers are specified.

8:32 AM Changeset in webkit [119491] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium unreviewed sheriffing: enable blob tests that are passing since r119454.

  • platform/chromium/TestExpectations:

fast/filesystem/file-writer-gc-blob.html
fast/filesystem/workers/file-writer-sync-truncate-extend.html
fast/filesystem/workers/file-writer-gc-blob.html

8:26 AM Changeset in webkit [119490] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][Win] Fix IDL dependency generation
https://bugs.webkit.org/show_bug.cgi?id=88304

Reviewed by Tor Arne Vestbø.

  • DerivedSources.pri:
8:17 AM Changeset in webkit [119489] by loislo@chromium.org
  • 8 edits
    7 deletes in trunk

Unreviewed, rolling out r119467, r119471, and r119476.
http://trac.webkit.org/changeset/119467
http://trac.webkit.org/changeset/119471
http://trac.webkit.org/changeset/119476
https://bugs.webkit.org/show_bug.cgi?id=88332

it broke chromium-mac static initializers test.\ (Requested by
loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-05

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/FontPlatformData.h:

(FontPlatformData):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):

  • platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp: Removed.
  • platform/graphics/harfbuzz/ng/HarfBuzzFace.h: Removed.
  • platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp: Removed.
  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: Removed.
  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h: Removed.
  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):

LayoutTests:

  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.png: Removed.
  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.txt: Removed.
  • platform/chromium/TestExpectations:
8:13 AM Changeset in webkit [119488] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Building when a top directory is named Source
https://bugs.webkit.org/show_bug.cgi?id=77727

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-05
Reviewed by Tor Arne Vestbø.

Change regex to only replace the last instance of OUT_PWD.

  • qmake/mkspecs/features/default_pre.prf:
8:01 AM Changeset in webkit [119487] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: SHIFT key as helper to color adjustment in color picker
https://bugs.webkit.org/show_bug.cgi?id=88319

Reviewed by Pavel Feldman.

With Shift depressed, the dragger in the color picker will snap to the horizontal
or vertical axis while dragging, depending on which axis offset is greater.

  • inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.colorDragStart):
(WebInspector.Spectrum.colorDrag):
(WebInspector.Spectrum.draggable.move):
(WebInspector.Spectrum.draggable.start):

7:51 AM Changeset in webkit [119486] by dgrogan@chromium.org
  • 6 edits
    2 copies in branches/chromium/1132/Source

Merge 117978 - IndexedDB: Fire error when there are problems opening a DB
https://bugs.webkit.org/show_bug.cgi?id=85579

Source/WebCore:

We used to either fire success or get into an infinite loop.

Reviewed by Tony Chang.

New unit test in
Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::openConnection):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::create):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::openInternal):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

Source/WebKit/chromium:

Reviewed by Tony Chang.

  • WebKit.gypi:
  • tests/IDBAbortOnCorruptTest.cpp: Added.

(WebCore):
(MockIDBCallbacks):
(WebCore::MockIDBCallbacks::MockIDBCallbacks):
(WebCore::MockIDBCallbacks::~MockIDBCallbacks):
(WebCore::MockIDBCallbacks::onError):
(WebCore::MockIDBCallbacks::onSuccess):
(WebCore::MockIDBCallbacks::onSuccessWithContinuation):
(WebCore::MockIDBCallbacks::onSuccessWithPrefetch):
(WebCore::MockIDBCallbacks::onBlocked):
(FailingBackingStore):
(WebCore::FailingBackingStore::~FailingBackingStore):
(WebCore::FailingBackingStore::open):
(WebCore::FailingBackingStore::createIDBDatabaseMetaData):
(FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::~FailingIDBFactoryBackendImpl):
(WebCore::FailingIDBFactoryBackendImpl::create):
(WebCore::FailingIDBFactoryBackendImpl::removeIDBDatabaseBackend):
(WebCore::FailingIDBFactoryBackendImpl::openBackingStore):
(WebCore::TEST):

  • tests/IDBFakeBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h.

(WebCore):
(IDBFakeBackingStore):

TBR=dgrogan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10536007

7:50 AM Changeset in webkit [119485] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: aggregate all events before first frame into a fake frame
https://bugs.webkit.org/show_bug.cgi?id=88229

  • in Timeline's frame mode, start aggregating events by frame even before we get first frame marker.
  • inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController.prototype._addRecord):
(WebInspector.TimelineFrameController.prototype._flushFrame):
(WebInspector.TimelineFrameController.prototype._createFrame):

5:27 AM Changeset in webkit [119484] by charles.wei@torchmobile.com.cn
  • 5 edits in trunk/Source/WebCore

JSC:need to implement Dictionary::getWithUndefinedOrNullCheck for IDB
https://bugs.webkit.org/show_bug.cgi?id=88283

Reviewed by Kentaro Hara.

No new tests, idb not working for JSC yet.

  • bindings/js/Dictionary.cpp:

(WebCore::Dictionary::getWithUndefinedOrNullCheck):

  • bindings/js/Dictionary.h:

(Dictionary):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::getWithUndefinedOrNullCheck):
(WebCore):

  • bindings/js/JSDictionary.h:

(JSDictionary):

4:37 AM FeatureFlags edited by tkent@chromium.org
Add CUSTOM_SCHEME_HANDLER (diff)
4:35 AM Changeset in webkit [119483] by rwlbuis@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Hit ASSERT when editing attribute value in Element in SVG Document
https://bugs.webkit.org/show_bug.cgi?id=88179

Reviewed by Pavel Feldman.

Test setting attribute on non HTML element.

  • inspector/elements/set-attribute-non-html-expected.txt: Added.
  • inspector/elements/set-attribute-non-html.svg: Added.
4:32 AM Changeset in webkit [119482] by commit-queue@webkit.org
  • 30 edits
    2 adds in trunk

Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
https://bugs.webkit.org/show_bug.cgi?id=73176

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-06-05
Reviewed by Adam Barth.

Two more APIs are added in Custom Scheme Handler specification.
http://dev.w3.org/html5/spec/Overview.html#custom-handlers
One is 'isProtocolHandlerRegistered' to query whether the specific URL
is registered or not.
The other is 'unregisterProtocolHandler' to remove the registered URL.

.:

  • Source/cmake/WebKitFeatures.cmake: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
  • Source/cmakeconfig.h.cmake: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/WebCore:

Test: fast/dom/unregister-protocol-handler.html

  • Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
  • loader/EmptyClients.h: Add prototypes.

(EmptyChromeClient):
(WebCore::EmptyChromeClient::isProtocolHandlerRegistered):
(WebCore::EmptyChromeClient::unregisterProtocolHandler):

  • page/ChromeClient.h:

(ChromeClient):

  • page/NavigatorRegisterProtocolHandler.cpp:

(WebCore):
(WebCore::customHandlersStateString):
(WebCore::NavigatorRegisterProtocolHandler::isProtocolHandlerRegistered): Query if the handler is registered.
(WebCore::NavigatorRegisterProtocolHandler::unregisterProtocolHandler): Unregister the registered handler.

  • page/NavigatorRegisterProtocolHandler.h:

(NavigatorRegisterProtocolHandler):

  • page/NavigatorRegisterProtocolHandler.idl:

Source/WebKit/chromium:

  • features.gypi: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::customHandlerDataCreate):
(WebCore::customHandlerDataDelete):
(WebCore::ChromeClientEfl::registerProtocolHandler):
(WebCore):
(WebCore::ChromeClientEfl::isProtocolHandlerRegistered): Query if the handler is registered.
(WebCore::ChromeClientEfl::unregisterProtocolHandler): Unregister the registered handler.

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

  • ewk/ewk_custom_handler.cpp:

(ewk_custom_handler_is_protocol_handler_registered): Query if the handler is registered.
(ewk_custom_handler_unregister_protocol_handler): Unregister the registered handler.

  • ewk/ewk_custom_handler_private.h: Adds private function.
  • ewk/ewk_view.h: Adds enumeration.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
  • win/tools/vsprops/FeatureDefinesCairo.vsprops: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

LayoutTests:

  • fast/dom/unregister-protocol-handler-expected.txt: Added.
  • fast/dom/unregister-protocol-handler.html: Added.
4:28 AM Changeset in webkit [119481] by morrita@google.com
  • 5 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=88029
content-element-api.html and shadow-element.html depend on V8.

Reviewed by Kentaro Hara.

Replaced typeof checking with comparison.

  • fast/dom/shadow/content-element-api.html:
  • fast/dom/shadow/shadow-element.html:
4:13 AM Changeset in webkit [119480] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] WebKit2-EFL does not link with gold linker
https://bugs.webkit.org/show_bug.cgi?id=88295

Unreviewed. Fix linking when using gold linker.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-05

  • PlatformEfl.cmake:
3:57 AM Changeset in webkit [119479] by kinuko@chromium.org
  • 4 edits in trunk

Chromium tests: "Add support for the Blob constructor" [r115582] regressed blob layout tests
https://bugs.webkit.org/show_bug.cgi?id=85174

Reviewed by Kentaro Hara.

Source/WebCore:

This fixes a crash problem which could happen when the constructor is
given an array which contains String-type item(s).

There're still some Text mismatches between v8 results and
JSC results, most of them are v8 not throwing exception
when it is given an object whose toString() method throws
exception. (The issue will be addresse in a separate patch.)

Test: fast/files/blob-constructor.html

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

LayoutTests:

Changing blob-constructor.html label from CRASH to TEXT.

  • platform/chromium/TestExpectations:
3:39 AM Changeset in webkit [119478] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary constructor of SelectorQueryCache
https://bugs.webkit.org/show_bug.cgi?id=87942

Reviewed by Ryosuke Niwa.

Per the comment from darin@ (https://bugs.webkit.org/show_bug.cgi?id=87942#c27),
this patch removes an inline constructor that has no arguments.
To have the compiler generate the constructor,
this patch also removes WTF_MAKE_NONCOPYABLE().

No tests. No change in behavior.

  • dom/SelectorQuery.h:

(SelectorQueryCache):

3:25 AM Changeset in webkit [119477] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove unused methods from SelectorQuery.h
https://bugs.webkit.org/show_bug.cgi?id=88289

Reviewed by Antti Koivisto.

This patch removes SelectorDataList::size() and
SelectorDataList::SelectorDataList().
SelectorDataList::size() is not used by anybody.
SelectorDataList::SelectorDataList() can be auto-generated
by a compiler.

No tests. No change in behavior.

  • dom/SelectorQuery.cpp:
  • dom/SelectorQuery.h:

(SelectorDataList):

2:55 AM Changeset in webkit [119476] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectations update

  • platform/chromium/TestExpectations:
2:47 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
2:46 AM Changeset in webkit [119475] by mario@webkit.org
  • 10 edits
    3 adds in trunk

[GTK][WK2] Implement API for Geolocation permission requests in the GTK port
https://bugs.webkit.org/show_bug.cgi?id=83879

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Added a new kind of permission request for supporting the
Geolocation API in WebKit2GTK+.

New WebKitGeolocationPermissionRequest class, implementing the
WebKitPermissionRequest interface, to enabling client applications
to allow or deny geolocation permission requests.

  • GNUmakefile.list.am: Added new files.
  • UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp: Added.

(_WebKitGeolocationPermissionRequestPrivate):
(webkitGeolocationPermissionRequestAllow):
(webkitGeolocationPermissionRequestDeny):
(webkit_permission_request_interface_init):
(webkit_geolocation_permission_request_init):
(webkitGeolocationPermissionRequestFinalize):
(webkit_geolocation_permission_request_class_init):
(webkitGeolocationPermissionRequestCreate):

  • UIProcess/API/gtk/WebKitGeolocationPermissionRequest.h: Added.

(_WebKitGeolocationPermissionRequest):
(_WebKitGeolocationPermissionRequestClass):

  • UIProcess/API/gtk/WebKitGeolocationPermissionRequestPrivate.h: Added.

Include WKGeolocationPermissionRequest.h in WebKitPrivate.h, so we
can use it from the new WebKitGeolocationPermissionRequest class.

  • UIProcess/API/gtk/WebKitPrivate.h: Added new include.

Implement geolocation permission requests in the UI client.

  • UIProcess/API/gtk/WebKitUIClient.cpp:

(decidePolicyForGeolocationPermissionRequest): Create a new
instance of the WebKitGeolocationPermissionRequest class and call
to webkitWebViewMakePermissionRequest().
(attachUIClientToView): Provide an implementation function for
decidePolicyForGeolocationPermissionRequest.

  • UIProcess/API/gtk/WebKitWebView.h: Add new element to

WebKitPermissionRequestType enumeration for geolocation requests.

  • UIProcess/API/gtk/webkit2.h: Added header file for

WebKitGeolocationPermissionRequest

New unit tests to test allowing and denying permission requests.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewPermissionRequests): New test that loads a simple HTML
with JavaScript code requesting the current location.
(beforeAll): Added new test.

Updated documentation files.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

Tools:

Make minibrowser connect to the new 'permission requests' signal
to allow users handle the Geolocation permission requests.

  • MiniBrowser/gtk/BrowserWindow.c:

(geolocationRequestDialogCallback): Callback for the dialog asking
the user for allowing or not geolocation permission requests.
(webViewDecidePermissionRequest): Launch a dialog to ask the user
whether to allow or deny geolocation permission requests.
(browserWindowConstructed): Connect to 'permission-request' signal.

2:37 AM Changeset in webkit [119474] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Build fix for r119470.

  • loader/EmptyClients.cpp: Add #include "IntentRequest.h".
2:34 AM Changeset in webkit [119473] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused function: Document::formElements
https://bugs.webkit.org/show_bug.cgi?id=88272

Reviewed by Kentaro Hara.

No new tests. No behavior change.

  • dom/Document.h:

(Document): remove formElements(). It was used for radio group
validation, but the current code doesn't use it any more.

2:33 AM Changeset in webkit [119472] by apavlov@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, build fix after r119469.

  • inspector/styles/lazy-computed-style-expected.txt:
  • inspector/styles/styles-computed-trace-expected.txt:
2:28 AM Changeset in webkit [119471] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix on Chromium mac

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::isAATFont):

2:08 AM Changeset in webkit [119470] by tkent@chromium.org
  • 7 edits in trunk/Source

Move some function definitions in EmptyClients.h to EmptyClients.cpp
https://bugs.webkit.org/show_bug.cgi?id=88285

Reviewed by Ryosuke Niwa.

Source/WebCore:

If we have definitions of functions with RefPtr<> in EmptyClients.h like

virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) { }

and a source file includes EmptyClient.h, the source file needs to
include FileChooser.h though the source file doesn't use FileChooser
class explicitly because the definition of runOpenPanel() needs to call
FileChooser::deref().
To avoid this, we had better move such functions to EmptyClients.cpp.

No new tests. No behavior changes.

  • loader/EmptyClients.cpp: Move such functions from EmptyClients.h to

here, and move EmptyPopupMenu and EmptySearchPopupMenu too because
they're used only by EmptyChromeClient.
(WebCore):
(EmptyPopupMenu):
(WebCore::EmptyPopupMenu::show):
(WebCore::EmptyPopupMenu::hide):
(WebCore::EmptyPopupMenu::updateFromElement):
(WebCore::EmptyPopupMenu::disconnectClient):
(EmptySearchPopupMenu):
(WebCore::EmptySearchPopupMenu::popupMenu):
(WebCore::EmptySearchPopupMenu::saveRecentSearches):
(WebCore::EmptySearchPopupMenu::loadRecentSearches):
(WebCore::EmptySearchPopupMenu::enabled):
(WebCore::EmptyChromeClient::createPopupMenu):
(WebCore::EmptyChromeClient::createSearchPopupMenu):
(WebCore::EmptyChromeClient::createColorChooser):
(WebCore::EmptyChromeClient::runOpenPanel):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebCore::EmptyFrameLoaderClient::dispatchWillSendSubmitEvent):
(WebCore::EmptyFrameLoaderClient::dispatchWillSubmitForm):
(WebCore::EmptyFrameLoaderClient::createDocumentLoader):
(WebCore::EmptyFrameLoaderClient::createFrame):
(WebCore::EmptyFrameLoaderClient::createPlugin):
(WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
(WebCore::EmptyFrameLoaderClient::createMediaPlayerProxyPlugin):
(WebCore::EmptyFrameLoaderClient::createNetworkingContext):
(WebCore::EmptyFrameLoaderClient::dispatchIntent):
(WebCore::EmptyTextCheckerClient::requestCheckingOfString):
(WebCore::EmptyEditorClient::registerUndoStep):
(WebCore::EmptyEditorClient::registerRedoStep):
(WebCore::EmptyContextMenuClient::customizeMenu):

  • loader/EmptyClients.h: Move such function definitions to

EmptyClient.cpp, and append OVERRIDE.
(EmptyChromeClient):
(EmptyFrameLoaderClient):
(EmptyTextCheckerClient):
(EmptyEditorClient):
(EmptyContextMenuClient):

  • svg/graphics/SVGImage.cpp: Remove unnecessary #includes.

Source/WebKit/chromium:

  • src/WebHelperPluginImpl.cpp: Remove unnecessary #includes, and add necessary #includes.
  • src/WebPagePopupImpl.cpp: ditto.
1:56 AM Changeset in webkit [119469] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: "-webkit"-prefixed properties are considered inherited in the Computed Style pane
https://bugs.webkit.org/show_bug.cgi?id=88257

Reviewed by Pavel Feldman.

Source/WebCore:

Canonical names for properties should be used when checking if they are inherited (since only canonical names
are put into the usedProperties set).

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):

LayoutTests:

  • inspector/elements/elements-panel-styles-expected.txt:
  • inspector/elements/elements-panel-styles.html:
1:27 AM Changeset in webkit [119468] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
1:15 AM Changeset in webkit [119467] by bashi@chromium.org
  • 8 edits
    8 adds in trunk

[Chromium] Implement font shaping with font-feature-settings on Mac
https://bugs.webkit.org/show_bug.cgi?id=69826

Reviewed by Tony Chang.

Source/WebCore:

Add HarfBuzz-ng text shaper.
Chromium mac port uses it as secondary text shaper to support OpenType features.
HarfBuzz-ng is only used when -webkit-font-feature-settings is specified and
corresponding font is not an AAT font.

No new tests. css3/font-feature-settings-rendering.html should pass on Chromium mac port.

  • WebCore.gyp/WebCore.gyp: Added harfbuzz-ng dependencies.
  • WebCore.gypi: Added harfbuzz-ng files.
  • platform/graphics/FontPlatformData.h:

(FontPlatformData): Added m_harfbuzzFace.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::platformDataInit): Copy m_harfbuzzFace.
(WebCore::FontPlatformData::platformDataAssign): Ditto.
(WebCore):
(WebCore::isAATFont):
(WebCore::FontPlatformData::harfbuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp: Added.

(WebCore):
(WebCore::harfbuzzFaceCache):
(WebCore::HarfBuzzFace::HarfBuzzFace):
(WebCore::HarfBuzzFace::~HarfBuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzFace.h: Added.

(WebCore):
(HarfBuzzFace):
(WebCore::HarfBuzzFace::create):

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp: Added.

(WebCore):
(WebCore::floatToHarfBuzzPosition):
(WebCore::getGlyph):
(WebCore::getGlyphHorizontalAdvance):
(WebCore::getGlyphHorizontalOrigin):
(WebCore::getGlyphExtents):
(WebCore::harfbuzzCoreTextGetFontFuncs):
(WebCore::releaseTableData):
(WebCore::harfbuzzCoreTextGetTable):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: Added.

(WebCore):
(WebCore::harfbuzzPositionToFloat):
(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions):
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::~HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setFontFeatures):
(WebCore::HarfBuzzShaper::shape):
(WebCore::HarfBuzzShaper::setupHarfBuzzRun):
(WebCore::HarfBuzzShaper::shapeHarfBuzzRun):
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun):
(WebCore::HarfBuzzShaper::offsetForPosition):
(WebCore::HarfBuzzShaper::selectionRect):

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h: Added.

(WebCore):
(HarfBuzzShaper):
(WebCore::HarfBuzzShaper::totalWidth):
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setWidth):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numGlyphs):
(WebCore::HarfBuzzShaper::HarfBuzzRun::width):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore):
(WebCore::preferHarfBuzz): Added.
(WebCore::Font::selectionRectForComplexText): Use HarfBuzzShaper if font-feature-settings exists.
(WebCore::Font::drawComplexText): Ditto.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.

LayoutTests:

Added the expectation for sss3/font-feature-settings-rendering.html.

  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.png: Added.
  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.txt: Added.
  • platform/chromium/TestExpectations: Removed css3/font-feature-settings-rendering.html.
1:12 AM Changeset in webkit [119466] by commit-queue@webkit.org
  • 5 edits in trunk

IETC: FileList.item(-1) should return null instead of raising
https://bugs.webkit.org/show_bug.cgi?id=77899

Patch by Li Yin <li.yin@intel.com> on 2012-06-05
Reviewed by Kentaro Hara.

Source/WebCore:

IETC: http://samples.msdn.microsoft.com/ietestcenter/fileapi/filelist.htm
Accroding to http://es5.github.com/#x9.6
When the index is negative, it should not raise exception.
Firefox and IE returns null when there is not indexth File object.

Test: fast/files/file-list-test.html

  • fileapi/FileList.idl:

LayoutTests:

IETC: http://samples.msdn.microsoft.com/ietestcenter/fileapi/filelist.htm
Ref: http://es5.github.com/#x9.6
Some index values have been covered in this test, including negative index,
undefined, null, normal index(0~length-1), more than length index.

  • fast/files/file-list-test-expected.txt:
  • fast/files/file-list-test.html:
12:38 AM Changeset in webkit [119465] by abarth@webkit.org
  • 12 edits
    2 adds in trunk

EventHandler shouldn't dispatch fake mousemove events when scrolling on devices that don't have a mouse
https://bugs.webkit.org/show_bug.cgi?id=88270

Reviewed by James Robinson.

Source/WebCore:

This patch adds a setting analogous to deviceSupportsTouch to determine
whether the device supports mouse. We then don't dispatch fake mouse
events on devices that don't have a mouse in the first place.

Test: fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setDeviceSupportsMouse):
(WebCore::Settings::deviceSupportsMouse):
(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setDeviceSupportsMouse):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDeviceSupportsMouse):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

LayoutTests:

  • fast/events/touch/scroll-without-mouse-lacks-mousemove-events-expected.txt: Added.
  • fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html: Added.
Note: See TracTimeline for information about the timeline view.