Timeline


and

06/19/12:

23:51 Changeset [120809] by commit-queue@webkit.org

Web Inspector: Clicking "Clear all profiles" while ongoing recording should reset the ProfileLauncherView
https://bugs.webkit.org/show_bug.cgi?id=89464

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-06-19
Reviewed by Yury Semikhatsky.

Resetting the ProfileLauncherView in order to reflect the correct states of buttons

No new tests as UI related minor fix.

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reset):

23:46 Changeset [120808] by ossy@webkit.org

[Qt][Mac] Speculative skipping to try to paint the bot green.

  • platform/qt-mac/Skipped:
23:30 Changeset [120807] by ryuan.choi@samsung.com

[EFL][Regression] Build break after r120786
https://bugs.webkit.org/show_bug.cgi?id=89549

Unreviewed build fix for Efl port.

Source/WebKit2:

  • CMakeLists.txt: Added disassembler in includes.

Tools:

  • DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
23:29 Changeset [120806] by hayato@chromium.org

Assertion for event's target is wrong.
https://bugs.webkit.org/show_bug.cgi?id=89479

Reviewed by Hajime Morita.

Fix an assertion to ensure that event's target is reachable from a current target.

No new tests. Fix an assert condition.

  • dom/EventContext.cpp:

(WebCore::EventContext::EventContext):

  • dom/EventContext.h:

(EventContext):
(WebCore::EventContext::setRelatedTarget):
(WebCore::EventContext::isUnreachableNode):
(WebCore):
(WebCore::EventContext::isReachable):

23:23 Changeset [120805] by ossy@webkit.org

[CMake] Unreviewed speculative buildfix after r120786.

  • CMakeLists.txt:
23:03 Changeset [120804] by benjamin@webkit.org

Refactoring: Geolocation::startRequest() should not create the GeoNotifiers
https://bugs.webkit.org/show_bug.cgi?id=89533

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-06-19
Reviewed by David Kilzer.

It was odd to create the GeoNotifiers in Geolocation::startRequest() and having
assertions from the call site.

This patch move GeoNotifiers initialization to the exposed methods and pass them to
startRequest() as needed.
This will also help when adding support for dynamic permission reset and suspend/resume.

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::startRequest):

  • Modules/geolocation/Geolocation.h:

(Geolocation):

22:51 Changeset [120803] by commit-queue@webkit.org

Refine syncLayersTimeoutCallback for Accelerated Compositing.
https://bugs.webkit.org/show_bug.cgi?id=89538

Patch by Chang Wan Hong <jourmoon@company100.net> on 2012-06-19
Reviewed by Martin Robinson.

syncLayersTimeout reschedules the timer so that it can render each frame
every 1/60 seconds on animation. However, because it takes to time to execute
renderLayersToWindow, the timer is delayed. To fix this, we must reschedule
the timer before calling renderLayersToWindow.

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::syncLayersTimeout):

22:40 Changeset [120802] by ossy@webkit.org

[Qt][Mac] Skip one more crashing test.

  • platform/qt-mac/Skipped:
22:36 Changeset [120801] by cdn@chromium.org

Source/WebCore: Fixes condition where inserting a CounterNode subtree which could result in incorrect placement.
https://bugs.webkit.org/show_bug.cgi?id=88142

Reviewed by Adam Barth.

Test: fast/css/counters/counter-reset-subtree-insert-crash.html

  • rendering/CounterNode.cpp:

(WebCore::CounterNode::insertAfter):

LayoutTests: Add test which inserts a CounterNode subtree which contains reset nodes into another tree.
https://bugs.webkit.org/show_bug.cgi?id=88142

Reviewed by Adam Barth.

  • fast/css/counters/counter-reset-subtree-insert-crash-expected.txt: Added.
  • fast/css/counters/counter-reset-subtree-insert-crash.html: Added.
22:34 Changeset [120800] by ossy@webkit.org

Unreviewed expected update after r120735.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
22:18 Changeset [120799] by ossy@webkit.org

[Qt] Unreviewed buildfix after r120790. Typo fix.

  • platform/graphics/gstreamer/ImageGStreamerQt.cpp:

(ImageGStreamer::ImageGStreamer):

22:12 Changeset [120798] by kinuko@chromium.org

Use testRunner instead of layoutTestController in fast/{files,filesystem}
https://bugs.webkit.org/show_bug.cgi?id=89462

Reviewed by Ryosuke Niwa.

  • fast/files/apply-blob-url-to-img.html:
  • fast/files/apply-blob-url-to-xhr.html:
  • fast/files/blob-builder-crash.html:
  • fast/files/blob-slice-overflow.html:
  • fast/files/blob-slice-test.html:
  • fast/files/create-blob-url-crash.html:
  • fast/files/domurl-script-execution-context-crash.html:
  • fast/files/file-reader-abort.html:
  • fast/files/file-reader-directory-crash.html:
  • fast/files/file-reader-event-listener.html:
  • fast/files/file-reader-file-url.html:
  • fast/files/file-reader-sandbox-iframe.html:
  • fast/files/null-origin-string.html:
  • fast/files/read-blob-async.html:
  • fast/files/read-file-async.html:
  • fast/files/resources/file-reader-real.html:
  • fast/files/resources/setup-for-read-common.js:
  • fast/files/revoke-blob-url.html:
  • fast/files/script-tests/xhr-response-blob.js:
  • fast/files/workers/inline-worker-via-blob-url.html:
  • fast/files/workers/worker-apply-blob-url-to-xhr.html:
  • fast/files/workers/worker-read-blob-async.html:
  • fast/files/workers/worker-read-blob-sync.html:
  • fast/files/workers/worker-read-file-async.html:
  • fast/files/workers/worker-read-file-sync.html:
  • fast/filesystem/cross-filesystem-op.html:
  • fast/filesystem/file-after-reload-crash.html:
  • fast/filesystem/file-metadata-after-write.html:
  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
  • fast/filesystem/filesystem-uri-origin.html:
21:31 Changeset [120797] by commit-queue@webkit.org

[Shadow DOM] ShadowRoot.host should be gone
https://bugs.webkit.org/show_bug.cgi?id=88387

Source/WebCore:

According to the w3c spec change,
i.e. https://www.w3.org/Bugs/Public/show_bug.cgi?id=16764
Removed host attribute from ShadowRoot.idl.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-19
Reviewed by Dimitri Glazkov.

No new tests, because this change modified only idl.

  • dom/ShadowRoot.idl:

Just removed host attribute.

LayoutTests:

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-19
Reviewed by Dimitri Glazkov.

  • fast/css/style-scoped/style-scoped-in-shadow-expected.txt:
  • fast/css/style-scoped/style-scoped-in-shadow.html:
  • fast/dom/shadow/resources/shadow-dom.js:

(isShadowRoot):

  • fast/dom/shadow/shadow-root-js-api-expected.txt:
  • fast/dom/shadow/shadow-root-js-api.html:

Just removed references to shadow root's host attribute.

21:26 Changeset [120796] by tkent@chromium.org

Fix a form restore test broken by HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=89539

Reviewed by Kentaro Hara.

Before HTML5 parser, we parsed innerHTML input text and we attached
renderers to parsed nodes at the same time. The parsed nodes had
restored form values because we restore form values only for attached
elements.

After HTML5 parser, we don't attach renderers during innerHTML
parsing. state-restore-to-nonedited-controls.html used innerHTML to
built a form and the test haven't worked since introducing HTML5 parser.

This patch changes the test so that it uses document.write() instead of
innerHTML.

  • fast/forms/state-restore-to-non-edited-controls-expected.txt:

Note that the FAIL line is expected. It's due to Bug 88685.

  • fast/forms/state-restore-to-non-edited-controls.html:

Use document.write() instead of innerHTML.

21:06 Changeset [120795] by dpranke@chromium.org

NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
https://bugs.webkit.org/show_bug.cgi?id=64489

Reviewed by Tony Chang.

This change changes NRWT so that we don't start the websocket
server if we aren't running websocket tests and don't start the
HTTP server if we aren't running http tests.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._websocket_tests):
(Manager.start_servers_with_lock):
(Manager.stop_servers_with_lock):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_servers_started):

21:01 Changeset [120794] by dpranke@chromium.org

test-webkitpy: add a -p flag to pass through captured output to enable debugging
https://bugs.webkit.org/show_bug.cgi?id=89158

Reviewed by Eric Seidel.

Normally when outputcapture runs it intercepts stdout/stderr,
which makes running under the debugger difficult and mostly
pointless (since you can't see any output). This change adds a
flag to test-webkitpy (-p) that will cause outputcapture to pass
through the output as well as capture it.

  • Scripts/webkitpy/common/system/outputcapture.py:

(OutputCapture.stream_wrapper):
(OutputCapture._capture_output_with_name):

  • Scripts/webkitpy/common/system/outputcapture_unittest.py:

(OutputCaptureTest.setUp):

  • Scripts/webkitpy/test/main.py:

(Tester._parse_args):
(Tester._run_tests):
(Tester._log_exception):
(_CaptureAndPassThroughStream):
(_CaptureAndPassThroughStream.init):
(_CaptureAndPassThroughStream.write):
(_CaptureAndPassThroughStream._message_is_from_pdb):
(_CaptureAndPassThroughStream.flush):
(_CaptureAndPassThroughStream.getvalue):

20:43 Changeset [120793] by rniwa@webkit.org

Test fix after r120521.

  • webarchive/resources/dump-webarchive.js:
  • webarchive/test-duplicate-resources-expected.webarchive:
  • webarchive/test-script-src-expected.webarchive:
20:28 Changeset [120792] by rniwa@webkit.org

Use testRunner instead of layoutTestController in fast/doctypes, dom, dynamic, encoding, events, eventsource, and exclusions tests
https://bugs.webkit.org/show_bug.cgi?id=89438

Reviewed by Tony Chang.

  • fast/doctypes/005-case-preserving.html:
  • fast/doctypes/doctype-after-comment.html:
  • fast/doctypes/doctype-at-end.html:
  • fast/doctypes/doctype-in-element.html:
  • fast/doctypes/doctype-parsing.html:
  • fast/doctypes/html-doctype.html:
  • fast/doctypes/xhtml-with-xhtmlmp-doctype.xhtml:
  • fast/doctypes/xml-doctype.xhtml:
  • fast/dom/:
  • fast/dynamic/5872671.html:
  • fast/dynamic/ancestor-to-absolute.html:
  • fast/dynamic/checkbox-selection-crash.html:
  • fast/dynamic/containing-block-change.html:
  • fast/dynamic/crash-generated-counter.html:
  • fast/dynamic/crash-generated-image.html:
  • fast/dynamic/crash-generated-quote.html:
  • fast/dynamic/crash-generated-text.html:
  • fast/dynamic/crash-paint-no-documentElement-renderer.html-disabled:
  • fast/dynamic/float-remove-above-line-2.html:
  • fast/dynamic/float-remove-above-line.html:
  • fast/dynamic/hover-before-position-after-style-change.html:
  • fast/dynamic/hover-before-position-after-style-change2.html:
  • fast/dynamic/hover-style-recalc-crash.html:
  • fast/dynamic/hovered-detach.html:
  • fast/dynamic/inline-to-block-crash.html:
  • fast/dynamic/insertAdjacentElement.html:
  • fast/dynamic/insertAdjacentHTML-allowed-parents.html:
  • fast/dynamic/insertAdjacentHTML.html:
  • fast/dynamic/insertAdjacentText.html:
  • fast/dynamic/jQuery-animation-crash.html:
  • fast/dynamic/layer-hit-test-crash.html:
  • fast/dynamic/layer-no-longer-paginated.html:
  • fast/dynamic/outerHTML-no-element.html:
  • fast/dynamic/paused-event-dispatch.html:
  • fast/dynamic/position-absolute-to-fixed-crash.html:
  • fast/dynamic/position-change-layout.html:
  • fast/dynamic/recursive-layout.html:
  • fast/dynamic/style-access-late-stylesheet-load.html:
  • fast/dynamic/subtree-common-root.html:
  • fast/dynamic/subtree-table-cell-height.html:
  • fast/dynamic/subtree-unrooted.html:
  • fast/encoding/:
  • fast/events/:
  • platform/chromium/fast/events/drag-downloadURL.html:
  • platform/chromium/fast/events/intercept-postmessage.html:
  • platform/chromium/fast/events/rtl-scrollbar.html:
  • platform/gtk/fast/events/event-sender-metakey.html:
  • platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk.html:
  • platform/mac/fast/dom/character-index-for-point.html:
  • platform/mac/fast/dom/objc-wrapper-identity.html:
  • platform/mac/fast/dom/wrapper-classes-objc.html:
  • platform/mac/fast/dom/wrapper-round-tripping.html:
  • platform/mac/fast/events/objc-event-api.html:
  • platform/mac/fast/events/objc-keyboard-event-creation.html:
  • platform/qt/fast/events/event-sender-keydown-frame.html:
  • platform/win/fast/events/alt-numpad.html:
  • platform/win/fast/events/alt-space-scroll.html:
  • platform/win/fast/events/double-dead-char.html:
  • platform/win/fast/events/keyLocation-numpad.html:
  • platform/win/fast/events/panScroll-correct-direction.html:
  • platform/win/fast/events/panScroll-event-fired.html:
  • platform/win/fast/events/panScroll-image-no-scroll.html:
  • platform/win/fast/events/panScroll-imageMap-href-no-scroll.html:
  • platform/win/fast/events/panScroll-imageMap-noHref-scroll.html:
  • platform/win/fast/events/panScroll-nested-divs.html:
  • platform/win/fast/events/panScroll-no-iframe-jump.html:
  • platform/win/fast/events/panScroll-preventDefault.html:
  • platform/win/fast/events/script-tests/context-click-events.js:
20:27 Changeset [120791] by adamk@chromium.org

Pass ScriptValue by const ref where possible
https://bugs.webkit.org/show_bug.cgi?id=89531

Reviewed by Kentaro Hara.

Previously ScriptValue was sometimes passed by value, sometimes by const ref.

For consistency and optimality, pass by const ref everywhere (except where
ScriptValue is returned from non-accessor methods).

No new tests, no change in behavior.

  • bindings/js/ScriptFunctionCall.h:

(ScriptCallback):

  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::getHeapObjectId):

  • bindings/js/ScriptProfiler.h:

(ScriptProfiler):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::setException):

  • bindings/js/WorkerScriptController.h:

(WorkerScriptController):

  • bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptCallback::ScriptCallback):

  • bindings/v8/ScriptFunctionCall.h:

(ScriptCallback):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::getHeapObjectId):
(WebCore):

  • bindings/v8/ScriptProfiler.h:

(ScriptProfiler):

  • bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::operator!=):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::setException):

  • bindings/v8/WorkerScriptController.h:

(WorkerScriptController):

  • css/MediaQueryListListener.h:

(WebCore::MediaQueryListListener::create):
(WebCore::MediaQueryListListener::MediaQueryListListener):

  • dom/CustomEvent.cpp:

(WebCore::CustomEvent::initCustomEvent):

  • dom/CustomEvent.h:

(CustomEvent):
(WebCore::CustomEvent::detail):

  • dom/MessageEvent.h:

(WebCore::MessageEvent::dataAsScriptValue):

  • dom/PopStateEvent.h:

(WebCore::PopStateEvent::state):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::wrapObject):

  • inspector/InjectedScript.h:

(InjectedScript):

19:25 Changeset [120790] by philn@webkit.org

[GStreamer] 0.11 video-sink
https://bugs.webkit.org/show_bug.cgi?id=77087

Reviewed by Martin Robinson.

  • configure.ac: Fix required gstreamer 0.11 version

Source/WebCore:

Port the video sink to GStreamer 0.11 APIs. There is no change in
functionality compared to 0.10, for now.

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(webkitGetVideoSizeAndFormatFromCaps):
(webkitGstCreateBuffer):

  • platform/graphics/gstreamer/GStreamerVersioning.h:

(WebCore):

  • platform/graphics/gstreamer/ImageGStreamer.h:

(WebCore::ImageGStreamer::createImage):
(WebCore::ImageGStreamer::setCropRect):
(WebCore::ImageGStreamer::rect):
(ImageGStreamer):

  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp:

(ImageGStreamer::ImageGStreamer):

  • platform/graphics/gstreamer/ImageGStreamerQt.cpp:

(ImageGStreamer::ImageGStreamer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(_WebKitVideoSinkPrivate):
(webkitVideoSinkRender):
(webkitVideoSinkProposeAllocation):
(webkit_video_sink_class_init):

  • platform/graphics/gstreamer/VideoSinkGStreamer.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
19:15 Changeset [120789] by commit-queue@webkit.org

Add monitor profile support for Win
https://bugs.webkit.org/show_bug.cgi?id=88565

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-19
Reviewed by Eric Seidel.

Source/Platform:

  • chromium/public/Platform.h:

(Platform):
(WebKit::Platform::screenColorProfile):

Source/WebCore:

Tests: fast/images/jpeg-with-color-profile.html
fast/images/png-with-color-profile.html. Also covered by numerous
layout tests.

  • WebCore.gyp/WebCore.gyp:
  • platform/PlatformScreen.h:

(WebCore):

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::screenColorProfile):
(WebCore):

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenColorProfile):
(WebCore):

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenColorProfile):
(WebCore):

  • platform/gtk/PlatformScreenGtk.cpp:

(WebCore::screenColorProfile):
(WebCore):

  • platform/image-decoders/ImageDecoder.h:

(ImageFrame):
(ImageDecoder):
(WebCore::ImageDecoder::qcmsOutputDeviceProfile):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(turboSwizzled):
(colorSpaceHasAlpha):

19:12 Changeset [120788] by abarth@webkit.org

garden-o-matic fails to rebaseline tests with MISSING results
https://bugs.webkit.org/show_bug.cgi?id=89521

Reviewed by Kenneth Russell.

If the bots report "MISSING", we should try to find PNG and TXT results on the server.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
18:46 Changeset [120787] by abarth@webkit.org

svn.delete_list fails to delete empty parent directories
https://bugs.webkit.org/show_bug.cgi?id=89520

Reviewed by Dirk Pranke.

These functions were calling scm.delete and scm.add, which already
delete the parent directory. We'd get an exception when we tried to
delete the parent directory again.

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN._add_parent_directories):
(SVN._delete_parent_directories):

18:33 Changeset [120786] by fpizlo@apple.com

JSC should be able to show disassembly for all generated JIT code
https://bugs.webkit.org/show_bug.cgi?id=89536

Reviewed by Gavin Barraclough.

Now instead of doing linkBuffer.finalizeCode(), you do
FINALIZE_CODE(linkBuffer, (... explanation ...)). FINALIZE_CODE() then
prints your explanation and the disassembled code, if
Options::showDisassembly is set to true.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/LinkBuffer.cpp: Added.

(JSC):
(JSC::LinkBuffer::finalizeCodeWithoutDisassembly):
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::performFinalization):
(JSC::LinkBuffer::dumpLinkStatistics):
(JSC::LinkBuffer::dumpCode):

  • assembler/LinkBuffer.h:

(LinkBuffer):
(JSC):

  • assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodeRef::tryToDisassemble):
(MacroAssemblerCodeRef):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):

  • dfg/DFGThunks.cpp:

(JSC::DFG::osrExitGenerationThunkGenerator):

  • disassembler/Disassembler.h:

(JSC):
(JSC::tryToDisassemble):

  • disassembler/UDis86Disassembler.cpp:

(JSC::tryToDisassemble):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITCode.h:

(JSC::JITCode::tryToDisassemble):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):

  • llint/LLIntThunks.cpp:

(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):

  • runtime/Options.cpp:

(Options):
(JSC::Options::initializeOptions):

  • runtime/Options.h:

(Options):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::compile):

18:31 Changeset [120785] by commit-queue@webkit.org

webkitpy: Simplify fetch_bugs_matching_search()
https://bugs.webkit.org/show_bug.cgi?id=89497

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-19
Reviewed by Adam Barth.

Removed parameter with default value. It's not being used
and the handling of the parameter was wrong. Saves a check.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(BugzillaQueries.fetch_bugs_matching_search):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzillaQueries.fetch_bugs_matching_search):

18:29 Changeset [120784] by jhoneycutt@apple.com

Remove the failing expected results added in
http://trac.webkit.org/changeset/119190 now that these tests pass.

Rubber-stamped by Jessie Berlin.

  • platform/win/fast/frames/frame-set-scaling-hit-expected.txt: Removed.
  • platform/win/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Removed.
  • platform/win/fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Removed.
  • platform/win/fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Removed.
18:04 Changeset [120783] by arv@chromium.org

[V8] Fix issue where a callback got a null calling context
https://bugs.webkit.org/show_bug.cgi?id=89532

Reviewed by Kentaro Hara.

Source/WebCore:

Test: fast/dom/Window/post-message-crash.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback): Check the calling context and throw a type error (like JSC) if it is null.

LayoutTests:

  • fast/dom/Window/post-message-crash-expected.txt: Added.
  • fast/dom/Window/post-message-crash.html: Added.
17:54 Changeset [120782] by lforschler@apple.com

Versioning.

17:49 Changeset [120781] by lforschler@apple.com

New Tag.

17:40 Changeset [120780] by tony@chromium.org

Refactor RenderFlexibleBox terminology to use grow/shrink instead of positive/negative
https://bugs.webkit.org/show_bug.cgi?id=89493

Reviewed by Eric Seidel.

The spec stopped referring to positive and negative flex and now
talks about flex grow and flex shrink. Also, the preferred size is
now known as the flex basis. Make the code match the terms used in
the spec. http://dev.w3.org/csswg/css3-flexbox/

This will also make it easier to split flex into long hand notation
(flex-grow, flex-shrink and flex-basis).

No new tests, covered by existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::PropertyWrapperFlex::equals):
(WebCore::PropertyWrapperFlex::blend):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::flexBasisForChild):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
(WebCore::RenderFlexibleBox::freezeViolations):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):

  • rendering/RenderFlexibleBox.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleFlexibleBoxData.cpp:

(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):

  • rendering/style/StyleFlexibleBoxData.h:

(StyleFlexibleBoxData):

17:25 Changeset [120779] by kbr@google.com

[Chromium] Unreviewed test expectations update.

  • platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/resize-while-save-active-expected.txt: Removed.
  • platform/chromium/TestExpectations:

Referenced bugs 89529 and 89534.

17:20 Changeset [120778] by mhahnenberg@apple.com

[Qt][Mac] REGRESSION(r120742): It broke the build
https://bugs.webkit.org/show_bug.cgi?id=89516

Reviewed by Geoffrey Garen.

Removing GCActivityCallbackCF.cpp because it doesn't mesh well with cross-platform
code on Darwin (e.g. Qt). We now use plain ol' vanilla ifdefs to handle platforms
without CF support. These if-defs will probably disappear in the future when we
use cross-platform timers in HeapTimer.

(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::cancel):

  • runtime/GCActivityCallbackCF.cpp: Removed.
17:15 Changeset [120777] by dpranke@chromium.org

webkitpy: remove unneeded imports in layout_tests/port/chromium.py
https://bugs.webkit.org/show_bug.cgi?id=89522

Reviewed by Eric Seidel.

They were no longer being used. No tests necessary.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
17:09 Changeset [120776] by commit-queue@webkit.org

Source/WebCore: Make DOMFileSystem selectively structure clonable so it can be the body of a web intent.
https://bugs.webkit.org/show_bug.cgi?id=88267

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2012-06-19
Reviewed by David Levin.

This functionality will allow FileSystem API objects to be dispatched to
web content in order to enable, for instance, an intent notifying web
content that a particular filesystem has been mounted by the local
system. The goal at this point is not to enable across-the-board
clonability, but just for handling the particular use case.

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::V8ObjectMap::Writer::writeDOMFileSystem):
(WebCore::V8ObjectMap::Serializer::writeDOMFileSystem):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Reader::readDOMFileSystem):

LayoutTests: Add filesystem regression test to check that the filesystem object is
not serializable as created by javascript.
https://bugs.webkit.org/show_bug.cgi?id=88267

Patch by Greg Billock <gbillock@google.com> on 2012-06-19
Reviewed by David Levin.

  • fast/filesystem/filesystem-unserializable-expected.html: Added.
  • fast/filesystem/filesystem-unserializable.html: Added.
  • fast/filesystem/script-tests/filesystem-unserializable.js: Added.
17:07 Changeset [120775] by kbr@google.com

Unreviewed, rolling out r120772.
http://trac.webkit.org/changeset/120772
https://bugs.webkit.org/show_bug.cgi?id=89503

Broke build on Chromium Mac

Source/WebCore:

  • platform/graphics/chromium/AnimationTranslationUtil.h:

(WebCore):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:
  • platform/graphics/chromium/Canvas2DLayerBridge.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp:
  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/GraphicsLayerChromium.h:

(WebCore):

  • platform/graphics/chromium/ImageLayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):

  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/ManagedTexture.cpp:
  • platform/graphics/chromium/ProgramBinding.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/TextureCopier.cpp:
  • platform/graphics/chromium/TextureLayerChromium.cpp:
  • platform/graphics/chromium/TextureManager.cpp:
  • platform/graphics/chromium/TiledLayerChromium.cpp:
  • platform/graphics/chromium/TiledLayerChromium.h:

(WebCore):

  • platform/graphics/chromium/cc/CCActiveAnimation.h:
  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
  • platform/graphics/chromium/cc/CCDrawQuad.cpp:
  • platform/graphics/chromium/cc/CCFontAtlas.cpp:
  • platform/graphics/chromium/cc/CCFrameRateController.cpp:
  • platform/graphics/chromium/cc/CCFrameRateController.h:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore):

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerAnimationController.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
  • platform/graphics/chromium/cc/CCOcclusionTracker.h:
  • platform/graphics/chromium/cc/CCProxy.cpp:
  • platform/graphics/chromium/cc/CCQuadCuller.cpp:
  • platform/graphics/chromium/cc/CCRenderPass.h:
  • platform/graphics/chromium/cc/CCRenderSurface.cpp:
  • platform/graphics/chromium/cc/CCRenderSurface.h:
  • platform/graphics/chromium/cc/CCRenderer.h:

(WebCore):

  • platform/graphics/chromium/cc/CCScopedThreadProxy.h:
  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:
  • platform/graphics/chromium/cc/CCTimer.cpp:
  • platform/graphics/chromium/cc/CCTimer.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

Source/WebKit/chromium:

  • src/WebCompositorImpl.cpp:
  • src/WebLayerTreeView.cpp:
  • tests/CCLayerTestCommon.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:
  • tests/CCQuadCullerTest.cpp:
  • tests/CCTiledLayerImplTest.cpp:
  • tests/ImageLayerChromiumTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
16:50 Changeset [120774] by commit-queue@webkit.org

[BlackBerry] Should check the return value of fromUTF8() before executing the script.
https://bugs.webkit.org/show_bug.cgi?id=89500

Patch by Yong Li <yoli@rim.com> on 2012-06-19
Reviewed by Rob Buis.
PR# 166623.

WebPagePrivate::executeJavaScript() should check the return value of fromUTF8()
before executing the script to avoid potential crash on invalid script source.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::executeJavaScript):

16:47 Changeset [120773] by bdakin@apple.com

Skipping failing tests to keep the bots green. Filed
https://bugs.webkit.org/show_bug.cgi?id=89528 to track fixing the
real problem.

  • platform/mac/Skipped:
16:46 Changeset [120772] by commit-queue@webkit.org

[Chromium] Remove redundant #includes in compositor
https://bugs.webkit.org/show_bug.cgi?id=89503

Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-19
Reviewed by Adrienne Walker.

Source/WebCore:

Removed some redundant #includes to clarify dependency
picture. Some 90 #includes removed, some 50 less disruptive
#includes added. This brings the number of class dependencies to
902 from 1383.

No new tests are required, as this is only affects compile-time behavior.

  • platform/graphics/chromium/AnimationTranslationUtil.h:

(WebCore):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:
  • platform/graphics/chromium/Canvas2DLayerBridge.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp:
  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp:
  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):

  • platform/graphics/chromium/LayerTextureUpdater.h:
  • platform/graphics/chromium/ManagedTexture.cpp:
  • platform/graphics/chromium/ProgramBinding.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp:
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/TextureCopier.cpp:
  • platform/graphics/chromium/TextureLayerChromium.cpp:
  • platform/graphics/chromium/TextureManager.cpp:
  • platform/graphics/chromium/TiledLayerChromium.cpp:
  • platform/graphics/chromium/TiledLayerChromium.h:
  • platform/graphics/chromium/cc/CCActiveAnimation.h:

(WebCore):

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
  • platform/graphics/chromium/cc/CCDrawQuad.cpp:
  • platform/graphics/chromium/cc/CCFontAtlas.cpp:
  • platform/graphics/chromium/cc/CCFrameRateController.cpp:
  • platform/graphics/chromium/cc/CCFrameRateController.h:

(WebCore):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore):

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerAnimationController.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
  • platform/graphics/chromium/cc/CCOcclusionTracker.h:

(WebCore):

  • platform/graphics/chromium/cc/CCProxy.cpp:
  • platform/graphics/chromium/cc/CCQuadCuller.cpp:
  • platform/graphics/chromium/cc/CCRenderPass.h:

(WebCore):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:
  • platform/graphics/chromium/cc/CCRenderSurface.h:
  • platform/graphics/chromium/cc/CCRenderer.h:
  • platform/graphics/chromium/cc/CCScopedThreadProxy.h:
  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.h:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(WebCore):

  • platform/graphics/chromium/cc/CCTimer.cpp:
  • platform/graphics/chromium/cc/CCTimer.h:

(WebCore):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

Source/WebKit/chromium:

Minor adjustments to #include statements to remove
dependencies. No new tests.

  • src/WebCompositorImpl.cpp:
  • src/WebLayerTreeView.cpp:
  • tests/CCLayerTestCommon.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:
  • tests/CCQuadCullerTest.cpp:
  • tests/CCTiledLayerImplTest.cpp:
  • tests/ImageLayerChromiumTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
16:43 Changeset [120771] by jamesr@google.com

Merge 120640 - [chromium] REGRESSION(r120346) ContentLayerPainter should clear rect to be painted
https://bugs.webkit.org/show_bug.cgi?id=89376

Reviewed by Adrienne Walker.

In r120346, a refactor moved a clearRect()/clip() call from ContentLayerPainter - which all
ContentLayerChromiums use - out to OpaqueRectTrackingContentLayerDelegate - which all GraphicsLayerChromium
backed layers use, but which callers using WebContentLayer directly do not use. This meant that the canvas
wasn't cleared/clipped as WebContentLayerClient.h claimed it would be. This moves the clear and the clip
into CanvasLayerTextureUpdater which all paths use, including layers that don't use the ContentLayerPainter.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::paint):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

TBR=jamesr@google.com
BUG=132982
Review URL: https://chromiumcodereview.appspot.com/10574034

16:39 Changeset [120770] by jchaffraix@webkit.org

Align RenderLayer's descendant dependent flags semantics
https://bugs.webkit.org/show_bug.cgi?id=89241

Reviewed by Simon Fraser.

Refactoring only, covered by existing tests.

This change aligns the naming and implementation of the different descendant
dependent flags. While aligning, I found some bugs (inefficiencies) with how
the visible descendant flags was computed.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setHasVisibleContent):
Changed this method to not take a boolean as every callers was passing 'true'.
Reworked the logic under this assumption.

(WebCore::RenderLayer::dirtyVisibleContentStatus):
Updated after the following renaming.

(WebCore::RenderLayer::dirtyAncestorChainVisibleDescendantStatus):
Renamed this function from dirtyVisibleDescendantStatus to match the hasSelfPaintingLayer
naming and implementation.

(WebCore::RenderLayer::setAncestorChainHasVisibleDescendant):
Added this function to factor the visible descendant setting out of defunct childVisibilityChanged.
Also improved the efficiency of the function by clearing the dirty flag as it goes up (an unnoticed bug).

(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
Updated to use the new functions lieu of childVisibilityChanged.

  • rendering/RenderLayer.h:

(RenderLayer::childVisibilityChanged):
Removed this function as it wasn't adding much and it's a lot more clear to call
dirtyAncestorChainVisibleDescendantStatus / setAncestorChainHasVisibleDescendant.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Updated those callers after removing the boolean parameter from setHasVisibleContent.

16:21 Changeset [120769] by pfeldman@chromium.org

Web Inspector: Extract InjectedScriptBase class from the InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=89107

Extract methods from the InjectedScript that do not depend on
the concrete InjectedScriptSource.js implementation.

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-19
Reviewed by Pavel Feldman.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::nodeForObjectId):
(WebCore::InjectedScript::releaseObject):
(WebCore::InjectedScript::wrapCallFrames):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapSerializedObject):
(WebCore::InjectedScript::findObjectById):
(WebCore::InjectedScript::inspectNode):
(WebCore::InjectedScript::releaseObjectGroup):
(WebCore::InjectedScript::nodeAsScriptValue):

  • inspector/InjectedScript.h:

(WebCore):
(InjectedScript):

  • inspector/InjectedScriptBase.cpp: Added.

(WebCore):
(WebCore::InjectedScriptBase::InjectedScriptBase):
(WebCore::InjectedScriptBase::canAccessInspectedWindow):
(WebCore::InjectedScriptBase::injectedScriptObject):
(WebCore::InjectedScriptBase::callFunctionWithEvalEnabled):
(WebCore::InjectedScriptBase::makeCall):
(WebCore::InjectedScriptBase::makeEvalCall):

  • inspector/InjectedScriptBase.h: Copied from Source/WebCore/bindings/js/ScriptObject.h.

(WebCore):
(InjectedScriptBase):
(WebCore::InjectedScriptBase::~InjectedScriptBase):
(WebCore::InjectedScriptBase::hasNoValue):
(WebCore::InjectedScriptBase::scriptState):

  • inspector/InspectorAllInOne.cpp:
16:19 Changeset [120768] by kbr@google.com

[Chromium][Mac] Layout Test ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm is failing
https://bugs.webkit.org/show_bug.cgi?id=89411

Unreviewed test expectations update generated by garden-o-matic.

  • ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt.
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Removed.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
  • platform/chromium/TestExpectations:

Removed IMAGE MISSING expectation for this test.

  • platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Removed.
16:10 Changeset [120767] by fpizlo@apple.com

DFG CFA forgets to notify subsequent phases of found constants if it proves LogicalNot to be a constant
https://bugs.webkit.org/show_bug.cgi?id=89511
<rdar://problem/11700089>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

LayoutTests:

  • fast/js/dfg-constant-fold-logical-not-branch-expected.txt: Added.
  • fast/js/dfg-constant-fold-logical-not-branch.html: Added.
  • fast/js/script-tests/dfg-constant-fold-logical-not-branch.js: Added.

(foo1):
(foo2):
(Stuff):
(Stuff.prototype.thingy):
(Stuff.prototype.otherThingy):

16:09 Changeset [120766] by jhoneycutt@apple.com

Remove the failing results added in
http://trac.webkit.org/changeset/119144 and
http://trac.webkit.org/changeset/119149 now that these tests pass
without them.

Rubber-stamped by Jessie Berlin.

  • platform/win/fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Removed.
  • platform/win/fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Removed.
  • platform/win/fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Removed.
  • platform/win/fast/events/popup-blocked-from-untrusted-mouse-click-expected.txt: Removed.
  • platform/win/fast/events/popup-blocking-timers-expected.txt: Removed.
  • platform/win/fast/events/remove-target-in-mouseup-deep-expected.txt: Removed.
  • platform/win/fast/events/remove-target-in-mouseup-expected.txt: Removed.
  • platform/win/fast/events/remove-target-in-mouseup-insertback-expected.txt: Removed.
  • platform/win/fast/events/remove-target-in-mouseup-twice-expected.txt: Removed.
  • platform/win/fast/events/remove-target-with-shadow-in-drag-expected.txt: Removed.
15:51 Changeset [120765] by commit-queue@webkit.org

Unreviewed, rolling out r120621.
http://trac.webkit.org/changeset/120621
https://bugs.webkit.org/show_bug.cgi?id=89518

Memory graph should have been behind the experimental flag.
(Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-19

  • inspector/front-end/NativeMemorySnapshotView.js:
  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView):

  • inspector/front-end/nativeMemoryProfiler.css:

(.memory-blocks-list .item):

15:49 Changeset [120764] by commit-queue@webkit.org

The CSS_WRAP_SHAPE CSSWrapShape::Type is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=89403

Patch by Hans Muller <hmuller@adobe.com> on 2012-06-19
Reviewed by Eric Seidel.

Removed CSS_WRAP_SHAPE_PATH definition from CSSWrapShapes.h.
It's no longer required. This definition was never used or
tested, no new tests are required.

  • css/CSSWrapShapes.h:
15:48 Changeset [120763] by jpetsovits@rim.com

[BlackBerry] Missing notifyContentRendered() when resuming rendering
https://bugs.webkit.org/show_bug.cgi?id=89507
RIM PR 150049

Reviewed by Antonio Gomes.

All the current calls to notifyContentRendered() are
located in the RenderQueue, but this omits the case
when we force rendering from resumeBackingStore()
after rendering had been suspended for a while.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):

15:46 Changeset [120762] by cevans@google.com

Merge 120559
BUG=130356
Review URL: https://chromiumcodereview.appspot.com/10536212

15:34 Changeset [120761] by kenrb@chromium.org

Absolute positioned objects should not be added to anonymous block lists
https://bugs.webkit.org/show_bug.cgi?id=87768

Reviewed by Abhishek Arya.

Source/WebCore:

containingBlock() was returning an anonymous block for absolute
positioned objects under a relative positioned inline in the case
that the inline is split and the object is underneath the block
continuation. Anonymous blocks should never have anything in their
positioned object lists because they can be destroyed at any time
for a different reasons such as anonymous block merging, which is
a problem for layout if they have m_posChildNeedsLayout set.

This patch adds a generic check for anonymous blocks in
containingBlock() to correct this problem.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):

LayoutTests:

Test crashing condition in bug 87768.

  • fast/block/positioning/abspositioned-object-under-split-relpositioned-inline-crash-expected.txt: Added
  • fast/block/positioning/abspositioned-object-under-split-relpositioned-inline-crash.html: Added
  • fast/block/positioning/insert-positioned-in-anonymous-crash-expected.txt: Added
  • fast/block/positioning/insert-positioned-in-anonymous-crash.html: Added
15:30 Changeset [120760] by commit-queue@webkit.org

Source/WebCore: Web Inspector: extensionPanel.onSearch action strings should be
enumerated.
https://bugs.webkit.org/show_bug.cgi?id=89509

Patch by Jan Keromnes <janx@linux.com> on 2012-06-19
Reviewed by Pavel Feldman.

Fixed LayoutTests/inspector/extensions/extensions-api-expected.txt
accordingly.

  • inspector/front-end/ExtensionAPI.js:

(defineCommonExtensionSymbols):
(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler):
(injectedExtensionAPI.Panels.prototype.get SearchAction):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionPanel.prototype.searchCanceled):
(WebInspector.ExtensionPanel.prototype.performSearch):
(WebInspector.ExtensionPanel.prototype.jumpToNextSearchResult):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):

LayoutTests: Web Inspector: extensionPanel.onSearch action strings should be enumerated
https://bugs.webkit.org/show_bug.cgi?id=89509

Patch by Jan Keromnes <janx@linux.com> on 2012-06-19
Reviewed by Pavel Feldman.

  • inspector/extensions/extensions-api-expected.txt:
15:18 Changeset [120759] by danakj@chromium.org

[chromium] Add an allocation step for CCRenderer before drawing a frame
https://bugs.webkit.org/show_bug.cgi?id=88924

Reviewed by Adrienne Walker.

This step will be used to decide which RenderPass textures can be kept
alive and do not need to be drawn again.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore):
(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
(WebCore::LayerRendererChromium::beginDrawingFrame):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

15:01 Changeset [120758] by kbr@google.com

[Chromium] Unreviewed gardening.

  • platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/resize-while-save-active-expected.txt:

Added expectations without trailing newlines; unclear why this only happens in this configuration.

  • platform/chromium/TestExpectations:

Added reference to https://bugs.webkit.org/show_bug.cgi?id=89510 .

14:44 Changeset [120757] by achicu@adobe.com

[CSS Shaders] Create a shared object between FECustomFilter objects to store the shared resources
https://bugs.webkit.org/show_bug.cgi?id=87878

Reviewed by Dean Jackson.

An object called CustomFilterGlobalContext is created the first time a new FECustomFilter is needed in a document.
It is used to store the GraphicsContext3D needed to render the CSS Shaders. The context is shared by all the elements
in a document (no cross-domain).

More resources will be shared in following patches, including precompiled shaders and vertices/indices data.
https://bugs.webkit.org/show_bug.cgi?id=88427
https://bugs.webkit.org/show_bug.cgi?id=88429

The plan is to make CustomFilterGlobalContext and FECustomFilter (or a base class extracted out of it) usable from platform
code in the hardware accelerated compositing layer. The only dependency of the code is on the GraphicsContext3D.

No new tests. No functionality is changed yet, just added the new objects.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/CustomFilterGlobalContext.cpp: Added.

(WebCore):
(WebCore::CustomFilterGlobalContext::CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):

  • platform/graphics/filters/CustomFilterGlobalContext.h: Added.

(WebCore):
(CustomFilterGlobalContext):
(WebCore::CustomFilterGlobalContext::context):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter): Changed to use the global context instead of the host window.
(WebCore::FECustomFilter::create):
(WebCore::FECustomFilter::initializeContext):

  • platform/graphics/filters/FECustomFilter.h:

(WebCore):
(FECustomFilter):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build): Changed to initialize the global context if needed and pass it to the FECustomFilter.

  • rendering/RenderView.cpp:

(WebCore):
(WebCore::RenderView::customFilterGlobalContext):

  • rendering/RenderView.h:

(WebCore):
(RenderView):

14:43 Changeset [120756] by abarth@webkit.org

Missing results aren't shown in garden-o-matic

Reviewed by Kenneth Russell.

Previously we didn't know to look for text and image results when the
bot told us that results were missing.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
14:33 Changeset [120755] by commit-queue@webkit.org

[cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html
https://bugs.webkit.org/show_bug.cgi?id=53085

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-19
Reviewed by Martin Robinson.

Source/WebCore:

Clipping previously unlimited vertical and horizontal pattern repeats with
a clip rectangle similar to the Qt Graphics Context.

No new tests, this patch fixes
canvas/philip/tests/2d.pattern.paint.repeat* tests.

  • platform/graphics/Pattern.h:

(WebCore::Pattern::getPatternSpaceTransform): Adding constant getter method to be able to map to pattern space externally, needed by PlatformContextCairo::clipForPatternFilling.

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::prepareForFilling):
(WebCore::PlatformContextCairo::clipForPatternFilling): Clip pattern repeats if needed.

  • platform/graphics/cairo/PlatformContextCairo.h:

LayoutTests:

canvas/philip/tests/2d.pattern.paint.repeat* tests now passing.

  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
14:20 Changeset [120754] by hayato@chromium.org

[Shadow DOM] An upper boundary breaks if a child node of an insertion point is clicked.
https://bugs.webkit.org/show_bug.cgi?id=89407

Reviewed by Dimitri Glazkov.

Source/WebCore:

Update an event re-targeting algorithm so that it can set event's
target correctly when a fallback element in an insertion point is
clicked. To distinguish between distributed nodes and fallback
elements in an ancestor chain of composite shadow tree, an event
dispatcher checks explicitly whether a node is actually
distributed or assigned to the given insertion point.

Test: fast/dom/shadow/shadow-dom-event-dispatching.html

  • dom/EventDispatcher.cpp:

(WebCore::isAssignedTo):
(WebCore):
(WebCore::EventDispatcher::ensureEventAncestors):

  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::contains):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
14:19 Changeset [120753] by jsbell@chromium.org

IndexedDB: Add new type (and chromium webkit API) for metadata snapshot
https://bugs.webkit.org/show_bug.cgi?id=88678

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::metadata):

  • public/WebIDBKeyPath.h:

(WebIDBKeyPath):
(WebKit::WebIDBKeyPath::WebIDBKeyPath):
(WebKit::WebIDBKeyPath::~WebIDBKeyPath):
(WebKit::WebIDBKeyPath::operator=): Used by Chromium backend.

  • public/WebIDBMetadata.h: Added new type.

(WebKit):
(WebIDBMetadata):
(WebKit::WebIDBMetadata::WebIDBMetadata):
(ObjectStore):
(WebKit::WebIDBMetadata::ObjectStore::ObjectStore):
(Index):
(WebKit::WebIDBMetadata::Index::Index):

  • src/WebIDBKeyPath.cpp: Conform to normal WebXXX patern.

(WebKit::WebIDBKeyPath::assign):
(WebKit):
(WebKit::WebIDBKeyPath::reset):

14:12 Changeset [120752] by commit-queue@webkit.org

[Chromium] Add LayoutTests for find in page.
https://bugs.webkit.org/show_bug.cgi?id=89453

Patch by Martin Kosiba <mkosiba@google.com> on 2012-06-19
Reviewed by Adam Barth.

  • platform/chromium/editing/text-iterator/findString-restarts-at-last-position-expected.txt: Added.
  • platform/chromium/editing/text-iterator/findString-restarts-at-last-position.html: Added.
  • platform/chromium/editing/text-iterator/findString-start-search-after-selection-expected.txt: Added.
  • platform/chromium/editing/text-iterator/findString-start-search-after-selection.html: Added.
14:06 Changeset [120751] by commit-queue@webkit.org

CodeBlock::needsCallReturnIndices() is no longer needed.
https://bugs.webkit.org/show_bug.cgi?id=89490

Patch by Mark Lam <mark.lam@apple.com> on 2012-06-19
Reviewed by Geoffrey Garen.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::needsCallReturnIndices): removed.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

14:00 Changeset [120750] by enne@google.com

Fix scrollbar layers being misplaced with a clipped owner layer
https://bugs.webkit.org/show_bug.cgi?id=89486

Reviewed by Simon Fraser.

Source/WebCore:

Scrollbar layers are positioned relative to their parent layer. If
that parent gets clipped, then that positioning becomes incorrect and
scrollbars get positioned relative to the clipped bounds instead of
the full bounds. Fix by not clipping in this case.

Test: compositing/overflow/scrollbars-with-clipped-owner.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::shouldClipCompositedBounds):

LayoutTests:

  • compositing/overflow/scrollbars-with-clipped-owner-expected.png: Added.
  • compositing/overflow/scrollbars-with-clipped-owner-expected.txt: Added.
  • compositing/overflow/scrollbars-with-clipped-owner.html: Added.
13:13 Changeset [120749] by shinyak@chromium.org

[Shadow][Editing] applying document.execCommand('bold') twice to elements having shadow insertion points causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=88502

Reviewed by Ryosuke Niwa.

Source/WebCore:

When inserting or removing insertion points (<shadow> or <content>) into or from Shdaow DOM,
ElementShadow::invalidateDistribution() will be called immediately. It will remove all the renderers
of elements in the Shadow DOM. Since Node::rendererIsEditable() returns false when an renderer does not
exist, all the elements in the Shadow DOM will be considered as non-content-editable until recalculating
layout, though some of them may actually be content-editable.

Actually the current code does not recalculate layout inside editing command, so a disaster happens.
For example, performing an editing command quits before completing all the commands, because the command
thinks it is adding some elements to a non-content-editable element (but actually it's content-editable).

So we have to recalculate layout if necessary when checking an element is content-editable or not.
This can be achieved by using Node::isContentEditable() instead of Node::rendererIsEditable().

Test: editing/shadow/bold-twice-in-shadow.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::removeInlineStyleFromElement):

  • editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

  • editing/RemoveNodeCommand.cpp:

(WebCore::RemoveNodeCommand::doApply):

LayoutTests:

  • editing/shadow/bold-twice-in-shadow-expected.txt: Added.
  • editing/shadow/bold-twice-in-shadow.html: Added.
13:11 Changeset [120748] by kbr@google.com

Unreviewed, rolling out r120744.
http://trac.webkit.org/changeset/120744
https://bugs.webkit.org/show_bug.cgi?id=89220

Broke build on Chromium Windows canary bots

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/mock/DeviceMotionClientMock.cpp: Removed.
  • platform/mock/DeviceMotionClientMock.h: Removed.
13:05 Changeset [120747] by fpizlo@apple.com

Unreviewed, try to fix Windows build.

12:48 Changeset [120746] by jhoneycutt@apple.com

Remove some failing layout tests results added in
http://trac.webkit.org/changeset/119285 and
http://trac.webkit.org/changeset/119295. Most of these tests pass
without the failing results. Only one of them passes with the failing
result; compositing/layer-creation/spanOverlapsCanvas.html. I left that
failing result in place.

Rubber-stamped by Alexey Proskuryakov.

  • platform/win/compositing/geometry/flipped-writing-mode-expected.txt: Removed.
  • platform/win/compositing/geometry/foreground-layer-expected.txt: Removed.
  • platform/win/compositing/geometry/foreground-offset-change-expected.txt: Removed.
  • platform/win/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
  • platform/win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Removed.
  • platform/win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
  • platform/win/compositing/geometry/layer-due-to-layer-children-expected.txt: Removed.
  • platform/win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Removed.
  • platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
  • platform/win/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Removed.
  • platform/win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Removed.
  • platform/win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.
  • platform/win/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Removed.
  • platform/win/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Removed.
  • platform/win/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Removed.
  • platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Removed.
  • platform/win/compositing/geometry/outline-change-expected.txt: Removed.
  • platform/win/compositing/geometry/partial-layout-update-expected.txt: Removed.
  • platform/win/compositing/geometry/preserve-3d-switching-expected.txt: Removed.
  • platform/win/compositing/geometry/root-layer-update-expected.txt: Removed.
  • platform/win/compositing/geometry/tall-page-composited-expected.txt: Removed.
  • platform/win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Removed.
  • platform/win/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
  • platform/win/compositing/geometry/video-opacity-overlay-expected.txt: Removed.
  • platform/win/compositing/iframes/become-composited-nested-iframes-expected.txt: Removed.
  • platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/composited-iframe-alignment-expected.txt: Removed.
  • platform/win/compositing/iframes/composited-iframe-scroll-expected.txt: Removed.
  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
  • platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Removed.
  • platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
  • platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/iframe-content-flipping-expected.txt: Removed.
  • platform/win/compositing/iframes/iframe-copy-on-scroll-expected.txt: Removed.
  • platform/win/compositing/iframes/iframe-in-composited-layer-expected.txt: Removed.
  • platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
  • platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
  • platform/win/compositing/iframes/invisible-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/invisible-nested-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Removed.
  • platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/win/compositing/iframes/layout-on-compositing-change-expected.txt: Removed.
  • platform/win/compositing/iframes/nested-iframe-scrolling-expected.txt: Removed.
  • platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • platform/win/compositing/iframes/page-cache-layer-tree-expected.txt: Removed.
  • platform/win/compositing/iframes/resizer-expected.txt: Removed.
  • platform/win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
  • platform/win/compositing/images: Removed.
  • platform/win/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
  • platform/win/compositing/images/direct-image-background-color-expected.txt: Removed.
  • platform/win/compositing/images/direct-pdf-image-expected.txt: Removed.
  • platform/win/compositing/images/direct-svg-image-expected.txt: Removed.
  • platform/win/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Removed.
  • platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
  • platform/win/compositing/layer-creation/overlap-animation-expected.txt: Removed.
  • platform/win/compositing/layer-creation/overlap-child-layer-expected.txt: Removed.
  • platform/win/compositing/layer-creation/overlap-clipping-expected.txt: Removed.
  • platform/win/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Removed.
  • platform/win/compositing/layer-creation/overlap-transformed-layer-expected.txt: Removed.
  • platform/win/compositing/layer-creation/overlap-transforms-expected.txt: Removed.
  • platform/win/compositing/layer-creation/rotate3d-overlap-expected.txt: Removed.
  • platform/win/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
  • platform/win/compositing/layer-creation/stacking-context-overlap-expected.txt: Removed.
  • platform/win/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Removed.
  • platform/win/compositing/layer-creation/translatez-overlap-expected.txt: Removed.
  • platform/win/compositing/masks: Removed.
  • platform/win/compositing/masks/direct-image-mask-expected.txt: Removed.
  • platform/win/compositing/masks/masked-ancestor-expected.txt: Removed.
  • platform/win/compositing/masks/multiple-masks-expected.txt: Removed.
  • platform/win/compositing/masks/simple-composited-mask-expected.txt: Removed.
  • platform/win/compositing/overflow/ancestor-overflow-expected.txt: Removed.
  • platform/win/compositing/overflow/clip-descendents-expected.txt: Removed.
  • platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Removed.
  • platform/win/compositing/overflow/content-loses-scrollbars-expected.txt: Removed.
  • platform/win/compositing/overflow/overflow-compositing-descendant-expected.txt: Removed.
  • platform/win/compositing/overflow/overflow-positioning-expected.txt: Removed.
  • platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Removed.
  • platform/win/compositing/overflow/resize-painting-expected.txt: Removed.
  • platform/win/compositing/rtl: Removed.
  • platform/win/compositing/rtl/rtl-absolute-expected.txt: Removed.
  • platform/win/compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
  • platform/win/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
  • platform/win/compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
  • platform/win/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed.
  • platform/win/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
  • platform/win/compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
  • platform/win/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed.
  • platform/win/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed.
  • platform/win/compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
  • platform/win/compositing/rtl/rtl-relative-expected.txt: Removed.
  • platform/win/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Removed.
  • platform/win/compositing/visibility: Removed.
  • platform/win/compositing/visibility/layer-visible-content-expected.txt: Removed.
  • platform/win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Removed.
12:42 Changeset [120745] by fpizlo@apple.com

It should be possible to look at disassembly
https://bugs.webkit.org/show_bug.cgi?id=89319

Source/JavaScriptCore:

Reviewed by Sam Weinig.

This imports the udis86 disassembler library. The library is placed
behind an abstraction in disassembler/Disassembler.h, so that we can
in the future use other disassemblers (for other platforms) whenever
appropriate. As a first step, the disassembler is being invoked for
DFG verbose dumps.

If we ever want to merge a new version of udis86 in the future, I've
made notes about changes I made to the library in
disassembler/udis86/differences.txt.

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • disassembler: Added.
  • disassembler/Disassembler.h: Added.

(JSC):
(JSC::tryToDisassemble):

  • disassembler/UDis86Disassembler.cpp: Added.

(JSC):
(JSC::tryToDisassemble):

  • disassembler/udis86: Added.
  • disassembler/udis86/differences.txt: Added.
  • disassembler/udis86/itab.py: Added.

(UdItabGenerator):
(UdItabGenerator.init):
(UdItabGenerator.toGroupId):
(UdItabGenerator.genLookupTable):
(UdItabGenerator.genLookupTableList):
(UdItabGenerator.genInsnTable):
(genItabH):
(genItabH.UD_ITAB_H):
(genItabC):
(genItab):
(main):

  • disassembler/udis86/optable.xml: Added.
  • disassembler/udis86/ud_opcode.py: Added.

(UdOpcodeTables):
(UdOpcodeTables.sizeOfTable):
(UdOpcodeTables.nameOfTable):
(UdOpcodeTables.updateTable):
(UdOpcodeTables.Insn):
(UdOpcodeTables.Insn.init):
(UdOpcodeTables.Insn.init.opcode):
(UdOpcodeTables.parse):
(UdOpcodeTables.addInsnDef):
(UdOpcodeTables.print_table):
(UdOpcodeTables.print_tree):

  • disassembler/udis86/ud_optable.py: Added.

(UdOptableXmlParser):
(UdOptableXmlParser.parseDef):
(UdOptableXmlParser.parse):
(printFn):
(parse):
(main):

  • disassembler/udis86/udis86.c: Added.

(ud_init):
(ud_disassemble):
(ud_set_mode):
(ud_set_vendor):
(ud_set_pc):
(ud):
(ud_insn_asm):
(ud_insn_off):
(ud_insn_hex):
(ud_insn_ptr):
(ud_insn_len):

  • disassembler/udis86/udis86.h: Added.
  • disassembler/udis86/udis86_decode.c: Added.

(eff_adr_mode):
(ud_lookup_mnemonic):
(decode_prefixes):
(modrm):
(resolve_operand_size):
(resolve_mnemonic):
(decode_a):
(decode_gpr):
(resolve_gpr64):
(resolve_gpr32):
(resolve_reg):
(decode_imm):
(decode_modrm_reg):
(decode_modrm_rm):
(decode_o):
(decode_operand):
(decode_operands):
(clear_insn):
(resolve_mode):
(gen_hex):
(decode_insn):
(decode_3dnow):
(decode_ssepfx):
(decode_ext):
(decode_opcode):
(ud_decode):

  • disassembler/udis86/udis86_decode.h: Added.

(ud_itab_entry_operand):
(ud_itab_entry):
(ud_lookup_table_list_entry):
(sse_pfx_idx):
(mode_idx):
(modrm_mod_idx):
(vendor_idx):
(is_group_ptr):
(group_idx):

  • disassembler/udis86/udis86_extern.h: Added.
  • disassembler/udis86/udis86_input.c: Added.

(inp_buff_hook):
(inp_file_hook):
(ud):
(ud_set_user_opaque_data):
(ud_get_user_opaque_data):
(ud_set_input_buffer):
(ud_set_input_file):
(ud_input_skip):
(ud_input_end):
(ud_inp_next):
(ud_inp_back):
(ud_inp_peek):
(ud_inp_move):
(ud_inp_uint8):
(ud_inp_uint16):
(ud_inp_uint32):
(ud_inp_uint64):

  • disassembler/udis86/udis86_input.h: Added.
  • disassembler/udis86/udis86_itab_holder.c: Added.
  • disassembler/udis86/udis86_syn-att.c: Added.

(opr_cast):
(gen_operand):
(ud_translate_att):

  • disassembler/udis86/udis86_syn-intel.c: Added.

(opr_cast):
(gen_operand):
(ud_translate_intel):

  • disassembler/udis86/udis86_syn.c: Added.
  • disassembler/udis86/udis86_syn.h: Added.

(mkasm):

  • disassembler/udis86/udis86_types.h: Added.

(ud_operand):
(ud):

  • jit/JITCode.h:

(JITCode):
(JSC::JITCode::tryToDisassemble):

Source/WebCore:

Reviewed by Sam Weinig.

Just fixing EFL's build system now that JSC has a new directory.

  • CMakeLists.txt:

Source/WTF:

Reviewed by Sam Weinig.

Made changes to Assertions.h to make it friendly to C code again.

Added ENABLE(DISASSEMBLER) and USE(UDIS86) logic to Platform.h.

  • wtf/Assertions.h:
  • wtf/Platform.h:
12:27 Changeset [120744] by commit-queue@webkit.org

Adds DeviceMotionClientMock
https://bugs.webkit.org/show_bug.cgi?id=89220

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-19
Reviewed by Steve Block.

Adds DeviceMotionClientMock in WebCore to enable testing of DeviceMotion once it is fully implemented in WebKit.
This addition was originally included in https://bugs.webkit.org/show_bug.cgi?id=89197 but was split into a separate patch for easier review.

No new tests because DeviceMotionClientMock is designed to enable future testing and cannot be tested in itself.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • platform/mock/DeviceMotionClientMock.cpp: Added.

(WebCore):
(WebCore::DeviceMotionClientMock::DeviceMotionClientMock):
(WebCore::DeviceMotionClientMock::setController):
(WebCore::DeviceMotionClientMock::startUpdating):
(WebCore::DeviceMotionClientMock::stopUpdating):
(WebCore::DeviceMotionClientMock::setMotion):
(WebCore::DeviceMotionClientMock::timerFired):

  • platform/mock/DeviceMotionClientMock.h: Added.

(WebCore):
(DeviceMotionClientMock):

12:22 Changeset [120743] by dpranke@chromium.org

Fix regression introduced in r120646 where the svn revision isn't saved in results.json

Unreviewed, build fix.

It turns out that we store the svn revision two different ways
in the JSON, and I only caught one of them :(. This should fix
the other.

Also, this part of the code is poorly tested. I will investigate
adding at least a basic test for this in a separate fix.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):

12:17 Changeset [120742] by mhahnenberg@apple.com

GCActivityCallback and IncrementalSweeper should share code
https://bugs.webkit.org/show_bug.cgi?id=89400

Reviewed by Geoffrey Garen.

A lot of functionality is duplicated between GCActivityCallback and IncrementalSweeper.
We should extract the common functionality out into a separate class that both of them
can inherit from. This refactoring will be an even greater boon when we add the ability
to shut these two agents down in a thread-safe fashion

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • heap/Heap.cpp:

(JSC::Heap::Heap): Move initialization down so that the JSGlobalData has a valid Heap when
we're initializing the GCActivityCallback and the IncrementalSweeper.

  • heap/Heap.h:

(Heap):

  • heap/HeapTimer.cpp: Added.

(JSC):
(JSC::HeapTimer::HeapTimer): Initialize the various base class data that
DefaultGCActivityCallback::commonConstructor() used to do.
(JSC::HeapTimer::~HeapTimer): Call to invalidate().
(JSC::HeapTimer::synchronize): Same functionality as the old DefaultGCActivityCallback::synchronize().
Virtual so that non-CF subclasses can override.
(JSC::HeapTimer::invalidate): Tears down the runloop timer to prevent any future firing.
(JSC::HeapTimer::timerDidFire): Callback to pass to the timer function. Casts and calls the virtual doWork().

  • heap/HeapTimer.h: Added. This is the class that serves as the common base class for

both GCActivityCallback and IncrementalSweeper. It handles setting up and tearing down run loops and synchronizing
across threads for its subclasses.
(JSC):
(HeapTimer):

  • heap/IncrementalSweeper.cpp: Changes to accomodate the extraction of common functionality

between IncrementalSweeper and GCActivityCallback into a common ancestor.
(JSC):
(JSC::IncrementalSweeper::doWork):
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::cancelTimer):
(JSC::IncrementalSweeper::create):

  • heap/IncrementalSweeper.h:

(IncrementalSweeper):

  • runtime/GCActivityCallback.cpp:

(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):

  • runtime/GCActivityCallback.h:

(GCActivityCallback):
(JSC::GCActivityCallback::willCollect):
(JSC::GCActivityCallback::GCActivityCallback):
(JSC):
(DefaultGCActivityCallback): Remove the platform data struct. The platform data should be kept in
the class itself so as to be accessible by doWork(). Most of the platform data for CF is kept in
HeapTimer anyways, so we only need the m_delay field now.

  • runtime/GCActivityCallbackBlackBerry.cpp:

(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::didAllocate):

  • runtime/GCActivityCallbackCF.cpp:

(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::cancel):

12:09 Changeset [120741] by commit-queue@webkit.org

Fix link error with fillWithEmptyClients
https://bugs.webkit.org/show_bug.cgi?id=89484

Patch by Alexandre Elias <aelias@google.com> on 2012-06-19
Reviewed by Ryosuke Niwa.

fillWithEmptyClients() was within #if ENABLE() guard in the .cpp file
but not in the header. There is now a caller unrelated to these ENABLEs
in WebHelperPluginImpl, so linking fails if both SVG and PAGE_POPUP
are disabled.

This function looks generic, so just remove the ENABLE guards.

No new tests. (Build fix.)

  • loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):

11:27 Changeset [120740] by dpranke@chromium.org

REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
https://bugs.webkit.org/show_bug.cgi?id=78127

Reviewed by Ryosuke Niwa.

Add the --add-platform-exceptions flag from ORWT, and ensure
that --new-baseline is equivalent to --reset-results
--add-platform-exceptions. Also fix the default logic for where to
put PNGs and render tree dumps if --new-test-results is true:
if --add-platform-exceptions is False, baselines should go in
the least-specific platform directory (e.g., platform/mac)
rather than the most-specific (platform/mac-snowleopard).

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner):
(SingleTestRunner.run):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._add_missing_baselines):
(SingleTestRunner._location_for_new_baseline):
(SingleTestRunner._overwrite_baselines):
(SingleTestRunner._save_baseline_data):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.baseline_path):
(Port):
(Port.baseline_platform_dir):
(Port.baseline_version_dir):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RebaselineTest.assertBaselines):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

11:25 Changeset [120739] by simon.fraser@apple.com

Rebaseline some media controller tests.

  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-playing-and-pause-expected.txt:
11:21 Changeset [120738] by dpranke@chromium.org

NRWT should not take memory used as disk cache into account when deciding how many processes to launch
https://bugs.webkit.org/show_bug.cgi?id=81379

Reviewed by Eric Seidel.

The 'free memory' calculation we were running on the mac seemed
to underestimate how many children we can run in parallel, and
it was complex. This patch replaces that calculation with a
simpler one that reserves 2GB for overhead and assumes 256MB per
DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.

Also, there was a bug where we were truncating the memory
installed on the machine to 4GB by casting to an int instead of
a long; this was probably the source of some of the earlier
problems when using total memory.

This patch also removes the no-longer-needed restrictions on the
number of workers on beefy Lion boxes for both Apple Mac and Chromium
Mac; we should now use all of the cores by default.

The memory calculations have only been implemented on the mac;
having the calculation in base.default_child_processes() was IMO
misleading, and so this patch also moves the computation into
the MacPort. I have not heard of the # of workers being an issue
on any other ports, so this should be fine.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.total_bytes_memory):

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(PlatformInfo.total_bytes_memory):
(PlatformInfo.total_bytes_memory):
(PlatformInfo._win_version_tuple_from_cmd):

  • Scripts/webkitpy/common/system/platforminfo_unittest.py:

(TestPlatformInfo.test_total_bytes_memory):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.default_child_processes):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_default_child_processes):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort.operating_system):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_child_processes):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(TestMacPort.test_default_child_processes):

11:05 Changeset [120737] by inferno@chromium.org

Crash in RenderInline::willBeDestroyed.
https://bugs.webkit.org/show_bug.cgi?id=89386

Reviewed by Julien Chaffraix.

Source/WebCore:

We were unable to find the previous continuation during the process
of cleaning up empty anonymous block continuation. The reason being
that we were just looking till our immediate parent and ignoring the
fact that it can be enclosed in anonymous blocks. The change skips
over anonymous blocks in the parent chain.

Test: fullscreen/empty-anonymous-block-continuation-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):

LayoutTests:

  • fullscreen/empty-anonymous-block-continuation-crash-expected.txt: Added.
  • fullscreen/empty-anonymous-block-continuation-crash.html: Added.
11:03 Changeset [120736] by dpranke@chromium.org

new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
https://bugs.webkit.org/show_bug.cgi?id=85446

Reviewed by Simon Fraser.

Tools:

Embed whether pixel testing was enabled into the results.json.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):

LayoutTests:

This change makes results.html aware of whether pixel tests were
enabled when the tests were run; if they weren't, we ignore
expected IMAGE tests that pass instead of reporting them as
'unexpected pass'.

  • fast/harness/resources/results-test.js:

(mockResults):

  • fast/harness/results.html:
10:59 Changeset [120735] by kling@webkit.org

Remove the -webkit-match-nearest-mail-blockquote-color property.
<http://webkit.org/b/89480>

Reviewed by Antti Koivisto.

Source/WebCore:

This property does nothing except taking up a bit on StyleRareNonInheritedData.
It's apparently famous for being the longest property name we support.
This passes the torch to -webkit-border-bottom-right-radius.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

  • fast/css/getComputedStyle/resources/property-names.js:
  • fast/dom/CSSStyleDeclaration/access-longest-css-property-expected.txt:
  • fast/dom/CSSStyleDeclaration/access-longest-css-property.html:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
10:57 Changeset [120734] by commit-queue@webkit.org

[BlackBerry] Animations continue to request frames after they have finished
https://bugs.webkit.org/show_bug.cgi?id=89483

Patch by Andrew Lo <anlo@rim.com> on 2012-06-19
Reviewed by Rob Buis.

Don't report that we have running animations if all the animations
are finished. This prevents unnecessary requesting of animation frames.
Internal PR165119
Internally Reviewed by Arvid Nilsson.

  • platform/graphics/blackberry/LayerAnimation.cpp:

(WebCore::progress):
(WebCore::fetchIntervalEndpoints):
(WebCore::LayerAnimation::apply):

  • platform/graphics/blackberry/LayerAnimation.h:

(WebCore::LayerAnimation::finished):
(WebCore::LayerAnimation::LayerAnimation):
(LayerAnimation):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::updateAnimations):

10:55 Changeset [120733] by lforschler@apple.com

Merged r120642

10:55 Changeset [120732] by inferno@chromium.org

Wrong repaintContainerSkipped in RenderObject::container()
when positioned objects are enclosed in a <foreignObject>.
https://bugs.webkit.org/show_bug.cgi?id=89384

Reviewed by Simon Fraser.

No new tests. The bug was found in a code audit.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::container):

10:43 Changeset [120731] by inferno@chromium.org

Crash in WebCore::RenderSVGModelObject::checkIntersection
https://bugs.webkit.org/show_bug.cgi?id=89059

Reviewed by Rob Buis.

Source/WebCore:

getElementCTM updates layout causing the renderer to be destroyed. We get
the new renderer by storing the element pointer and later accessing it using
the element pointer.

Test: svg/custom/intersection-list-crash.svg

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::checkIntersection):
(WebCore::RenderSVGModelObject::checkEnclosure):

LayoutTests:

  • svg/custom/intersection-list-crash-expected.txt: Added.
  • svg/custom/intersection-list-crash.svg: Added.
10:38 Changeset [120730] by kareng@chromium.org

adding for easy drover

10:37 Changeset [120729] by kareng@chromium.org

creating branch for m21

10:25 Changeset [120728] by ericu@chromium.org

FileWriter progress events should be throttled to 50ms
https://bugs.webkit.org/show_bug.cgi?id=89022

Reviewed by Kent Tamura.

No new tests; existing tests validate our event sequences, and testing
timing is likely to be flaky.

  • Modules/filesystem/FileWriter.cpp:

(WebCore):
(WebCore::FileWriter::FileWriter):
(WebCore::FileWriter::didWrite): Throttle sending progress events.

  • Modules/filesystem/FileWriter.h:

(FileWriter): Add a variable that remembers when the last event was
sent.

10:10 Changeset [120727] by mitz@apple.com

Source/WebCore: WebCore part of: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394

Reviewed by Darin Adler.

Updated fast/multicol/pagination-*.html.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForDocument): Changed to handle the new Pagination::Mode enum
values and set the column progression in addition to the column axis.

  • page/Page.h: Changed the Pagination::Mode enum values to ones that specify an axis and a

direction along that axis.

  • testing/Internals.cpp:

(WebCore::Internals::setPagination): Changed to support the new Pagination::Mode enum values.

Source/WebKit/mac: WebKit/mac part of: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394

Reviewed by Darin Adler.

  • WebView/WebView.mm:

(-[WebView _setPaginationMode:]): Changed to map new WebPaginationMode values to new
Pagination::Mode values.
(-[WebView _paginationMode]): Similarly, in the opposite direction.

  • WebView/WebViewPrivate.h: Replaced WebPaginationMode values with ones that specify an

axis and a direction along that axis.

Source/WebKit2: WebKit2 part of: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394

Reviewed by Darin Adler.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPaginationMode): Changed to map new WKPaginationMode values to new
Pagination::Mode values.
(WKPageGetPaginationMode): Similarly, in the opposite direction.

  • UIProcess/API/C/WKPagePrivate.h: Replaced WKPaginationMode values with ones that specify

an axis and a direction along that axis.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController setPaginationMode:]): Changed to handle new values.
(-[WKBrowsingContextController paginationMode]): Ditto.

  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Replaced

WKBrowsingContextPaginationMode values with ones that specify an axis and a direction along
that axis.

LayoutTests: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394

Reviewed by Darin Adler.

  • fast/multicol/pagination-h-horizontal-bt.html:
  • fast/multicol/pagination-h-horizontal-tb.html:
  • fast/multicol/pagination-h-vertical-lr.html:
  • fast/multicol/pagination-h-vertical-rl.html:
  • fast/multicol/pagination-v-horizontal-bt.html:
  • fast/multicol/pagination-v-horizontal-tb.html:
  • fast/multicol/pagination-v-vertical-lr.html:
  • fast/multicol/pagination-v-vertical-rl.html:
10:09 Changeset [120726] by aestes@apple.com

[Mac] -[WebPDFView _menuItemsFromPDFKitForEvent:] leaks NSMenuItems
https://bugs.webkit.org/show_bug.cgi?id=89434

Reviewed by Darin Adler.

  • WebView/WebPDFView.mm:

(-[WebPDFView _menuItemsFromPDFKitForEvent:]): Release copied
NSMenuItems once they're stored in copiedItems.

09:37 Changeset [120725] by ossy@webkit.org

[Qt][Mac] Skip new failing and crashing tests to try to paint the bot green.

  • platform/qt-mac/Skipped:
09:37 Changeset [120724] by kareng@chromium.org

Merge 118297 - REGRESSION (115573): Incorrect rounding of margins for floats
https://bugs.webkit.org/show_bug.cgi?id=87319

Reviewed by Eric Seidel.

Source/WebCore:

In RenderBlock::computeInlinePreferredLogicalWidths we used a float to
accumulate margins for floating children while the children themselves
represent their margins as LayoutUnits. Due to lack of rounding this can
cause the block to be too small at certain certain zoom levels, causing
unwanted wrapping.

This patch changes computeInlinePreferredLogicalWidths to use a
LayoutUnit to accumulate the margins and thus ensures that the margin
values are rounded the same way.

Test: fast/block/float/floats-with-margin-should-not-wrap.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

LayoutTests:

Add new test ensuring that using margins with floats doesn't cause
undesired wrapping.

  • fast/block/float/floats-with-margin-should-not-wrap-expected.html: Added.
  • fast/block/float/floats-with-margin-should-not-wrap.html: Added.

TBR=eae@chromium.org

09:21 Changeset [120723] by ossy@webkit.org

[Qt] Unreviewed gardening, remove unnecessary expected files.

  • platform/qt/animations/combo-transform-translate+scale-expected.txt: Removed.
  • platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
  • platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Removed.
  • platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
  • platform/qt/editing/inserting/return-key-in-hidden-field-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-noscript-expected.txt: Removed.
  • platform/qt/editing/pasteboard/select-element-1-expected.txt: Removed.
  • platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.txt: Removed.
  • platform/qt/fast/css/border-solid-single-edge-antialias-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-resize-contents-expected.txt: Removed.
  • platform/qt/fast/events/mouse-relative-position-expected.txt: Removed.
  • platform/qt/fast/preloader/document-write-noscript-expected.txt: Removed.
  • platform/qt/fast/repaint/table-hover-on-link-expected.txt: Removed.
  • platform/qt/http/tests/misc/SVGFont-delayed-load-expected.txt: Removed.
  • platform/qt/http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt: Removed.
  • platform/qt/svg/custom/acid3-test-77-expected.txt: Removed.
  • platform/qt/svg/custom/circular-marker-reference-1-expected.txt: Removed.
  • platform/qt/svg/custom/glyph-setting-d-attribute-expected.txt: Removed.
  • platform/qt/svg/custom/insertItemBefore-from-non-list-origin-expected.txt: Removed.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-svg-expected.txt: Removed.
  • platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt: Removed.
  • platform/qt/svg/dom/baseVal-animVal-crash-expected.txt: Removed.
  • platform/qt/svg/dom/css-transforms-expected.txt: Removed.
  • platform/qt/svg/dom/font-face-elements-expected.txt: Removed.
  • platform/qt/svg/hixie/links/001-expected.txt: Removed.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
09:15 Changeset [120722] by ossy@webkit.org

[Qt] Unreviewed gardening, remove unnecessary expected files.

  • platform/qt-5.0/fast/dom/DeviceMotion/create-event-expected.txt: Removed.
  • platform/qt-5.0/fast/dom/DeviceOrientation/create-event-expected.txt: Removed.
09:12 WebKitGTK/1.8.x edited by philn@webkit.org
(diff)
09:07 Changeset [120721] by commit-queue@webkit.org

Make RenderTableSection - nodeAtPoint and paintObject reuse spanning logic.
https://bugs.webkit.org/show_bug.cgi?id=88066

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-19
Reviewed by Julien Chaffraix.

Makes dirtiedRows and dirtiedColumns reuse spannedRows and spannedColumns
internally. This also changes their API to accept a damage-rect flipped
by logicalRectForWritingModeAndDirection.

The generic code in spannedRows and spannedColumns solves a few FIXMEs
surrounding RTL tables, which should improve performance.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::dirtiedRows):
(WebCore::RenderTableSection::dirtiedColumns):
(WebCore::RenderTableSection::paintObject):

  • rendering/RenderTableSection.h:

(WebCore::CellSpan::start):
(WebCore::CellSpan::end):
(CellSpan):
(RenderTableSection):

08:59 Changeset [120720] by ossy@webkit.org

[Qt] Unreviewed gardening, skip one more failing test.

  • platform/qt-5.0-wk2/Skipped:
08:47 Changeset [120719] by commit-queue@webkit.org

[JSC] Implement support for JSDictionary::convertValue(Vector<String>& result)
https://bugs.webkit.org/show_bug.cgi?id=89447

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-19
Reviewed by Adam Barth.

Add implementation for JSDictionary::convertValue(Vector<String>& result)
so that IDBDatabase::createObjectStore() compiles with JSC.

Tests: storage/indexeddb

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):
(WebCore):

  • bindings/js/JSDictionary.h:
08:45 Changeset [120718] by aestes@apple.com

[Mac] AudioFileReader::createBus() leaks an AudioBufferList if ExtAudioFileRead() returns an error
https://bugs.webkit.org/show_bug.cgi?id=89429

Reviewed by Darin Adler.

  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus): Call destroyAudioBufferList()
before returning if ExtAudioFileRead() returns an error.

08:40 Changeset [120717] by commit-queue@webkit.org

Fixing Typos in DeviceOrientation and DeviceMotion Tests
https://bugs.webkit.org/show_bug.cgi?id=89339

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-19
Reviewed by Steve Block.

  • fast/dom/DeviceMotion/create-event-expected.txt:
  • fast/dom/DeviceMotion/script-tests/create-event.js:
  • fast/dom/DeviceOrientation/no-synchronous-events-expected.txt:
  • fast/dom/DeviceOrientation/script-tests/no-synchronous-events.js:
08:38 Changeset [120716] by commit-queue@webkit.org

[Chromium] Style Fix in WebDeviceOrientationController
https://bugs.webkit.org/show_bug.cgi?id=89337

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-19
Reviewed by Steve Block.

Changing a local variable from a PassRefPtr to a RefPtr in order to be consistent with the style guide.

  • src/WebDeviceOrientationController.cpp:

(WebKit::WebDeviceOrientationController::didChangeDeviceOrientation):

08:17 Changeset [120715] by ossy@webkit.org

[Qt] Unreviewed gardening, skip one more failing test.

  • platform/qt-5.0-wk2/Skipped:
08:17 Changeset [120714] by mrobinson@webkit.org

Fix the GTK+ build by adding some missing source files to the source list.

  • GNUmakefile.list.am: WebGLDepthTexture.cpp/h to the source list.
08:15 Changeset [120713] by jocelyn.turcotte@nokia.com

[Qt] Fix the Windows build when Qt is built without -release or -debug
https://bugs.webkit.org/show_bug.cgi?id=89471

Reviewed by Tor Arne Vestbø.

Make sure that we at least remove build_all on Windows for api.pri,
as WebCore wasn't built for all configurations.

  • Source/api.pri:
07:25 Changeset [120712] by ossy@webkit.org

[Qt] Unreviewed typo fix.

  • platform/qt/Skipped:
07:15 Changeset [120711] by commit-queue@webkit.org

Remove the function ScriptDebugServer::supportsNativeBreakpoints()
https://bugs.webkit.org/show_bug.cgi?id=88759

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-06-19
Reviewed by Pavel Feldman.

Source/WebCore:

Since both JSC and V8 support DOM breakpoint now, remove the conditional interface and related code.
So there is no new tests.

  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.h:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype._populateContextMenu):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshRequest):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype._clearInterface):

  • inspector/front-end/Settings.js:
  • inspector/front-end/inspector.js:

(WebInspector.doLoadedDone):

Source/WebKit/chromium:

  • src/js/DevTools.js:
07:06 Changeset [120710] by commit-queue@webkit.org

Web Inspector: Make text in WebSocket Frames tab selectable
https://bugs.webkit.org/show_bug.cgi?id=89307

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-06-19
Reviewed by Yury Semikhatsky.

  • inspector/front-end/ResourceWebSocketFrameView.js:

(WebInspector.ResourceWebSocketFrameView):

  • inspector/front-end/networkPanel.css:

(.resource-websocket-frame-view):

07:03 Changeset [120709] by commit-queue@webkit.org

Web Inspector: Support 'Restart frame' in protocol and backend
https://bugs.webkit.org/show_bug.cgi?id=89147

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-06-19
Reviewed by Yury Semikhatsky.

Inspector.json got new command in Debugger domain.
A call path from InspectorDebuggerAgent to V8 Debug.LiveEdit.RestartFrame API
is built.
JSC implementation is a stub with fix me (40300).

  • bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::restart):
(WebCore):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore):
(WebCore::ScriptDebugServer::updateCallStack):

  • bindings/js/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/v8/DebuggerScript.js:

(.):

  • bindings/v8/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::restart):
(WebCore):

  • bindings/v8/JavaScriptCallFrame.h:

(JavaScriptCallFrame):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore):
(WebCore::ScriptDebugServer::updateCallStack):

  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::restartCallback):
(WebCore):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::restartFrame):
(WebCore):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InjectedScriptExterns.js:

(JavaScriptCallFrame.prototype.restart):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::restartFrame):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/JavaScriptCallFrame.idl:
07:03 Changeset [120708] by apavlov@chromium.org

New inspector/styles/inject-stylesheet.html fails
https://bugs.webkit.org/show_bug.cgi?id=89364

Reviewed by Zoltan Herczeg.

LayoutTestController in Chromium injects testRunner into the Inspector window, while its other implementations don't.
Additionally, testRunner.addUserStyleSheet() behavior differs across platforms: Chromium injects stylesheets
with the "Author" level, while the others do with the "User" level, so the Chromium expectation stands apart.

  • inspector/styles/inject-stylesheet-expected.txt:
  • inspector/styles/inject-stylesheet.html:
  • platform/chromium/inspector/styles/inject-stylesheet-expected.txt: Copied from LayoutTests/inspector/styles/inject-stylesheet-expected.txt.
  • platform/qt/Skipped:
06:59 Changeset [120707] by commit-queue@webkit.org

Replaced printf with fprintf in DEBUG_AUDIONODE_REFERENCES

Change printf to fprintf in DEBUG_AUDIONODE_REFERENCES
https://bugs.webkit.org/show_bug.cgi?id=86564

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-06-19
Reviewed by Csaba Osztrogonác.

There is no need for new tests: writing data to stderr, instead of stdout.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::~AudioContext):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):
(WebCore::AudioNode::printNodeCounts):

05:59 Changeset [120706] by commit-queue@webkit.org

[GTK] Assert failure in svg/batik/text/textDecoration.svg,textEffect3.svg for 64bit Debug bot
https://bugs.webkit.org/show_bug.cgi?id=89104

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-19
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Adding SVGInline to assertion to fix assertion failure. Same assertion was hit on Chromium.

Covered by existing tests
svg/batik/text/textDecoration.svg
svg/batik/text/textEffect3.svg
where the assertion failure was hit.

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::shouldTransformOnTextPainting):

LayoutTests:

Removing CRASH expectations after assertion failure is now fixed.

  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
04:43 Changeset [120705] by alexis.menard@openbossa.org

[Qt] Create an extra atlas when there is no available buffer space.
https://bugs.webkit.org/show_bug.cgi?id=89012

Reviewed by Noam Rosenthal.

In case of the desktop mode when we scroll the view all the tiles
are updated. It can happen that there no available buffer space for
the currently used atlas(especially when scrolling fast). In that case
we can create a new one. One future improvement could be to make a timer and
delete this extra atlas when it is not used.

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::beginContentUpdateInAtlas):
(WebKit::LayerTreeHostQt::beginContentUpdate):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

04:34 Changeset [120704] by ossy@webkit.org

[Qt] Buildfix for newer Qt5, use QPointer instead of the deprecated QWeakPointer.
https://bugs.webkit.org/show_bug.cgi?id=89449

Reviewed by Simon Hausmann.

Source/WebCore:

  • bridge/qt/qt_instance.h:

(QtInstance):

  • bridge/qt/qt_runtime.h:

(QtField):

  • platform/Widget.h:

(Widget):

Source/WebKit/qt:

  • Api/qwebframe_p.h:

(QWebHitTestResultPrivate):

  • Api/qwebpage_p.h:

(QWebPagePrivate):

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createFrame):

  • WebCoreSupport/PageClientQt.h:

(PageClientQGraphicsWidget):

Source/WebKit2:

  • UIProcess/API/qt/qquicknetworkreply_p.h:
03:46 FeatureFlags edited by tkent@chromium.org
Add CSP_NEXT (diff)
03:44 Changeset [120703] by commit-queue@webkit.org

[Qt] Document the versions enums where added
https://bugs.webkit.org/show_bug.cgi?id=89452

Patch by Albert Astals Cid <albert.astals@canonical.com> on 2012-06-19
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:
03:38 Changeset [120702] by commit-queue@webkit.org

Web Inspector: FileSystem tree should hide uninitialized FileSystem
https://bugs.webkit.org/show_bug.cgi?id=88602

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-19
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: http/tests/inspector/filesystem/get-filesystem-root.html

  • inspector/Inspector.json:
  • inspector/InspectorFileSystemAgent.cpp:

(WebCore):
(WebCore::InspectorFileSystemAgent::getFileSystemRoot):

  • inspector/InspectorFileSystemAgent.h:

(InspectorFileSystemAgent):

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype._originAdded):
(WebInspector.FileSystemModel.prototype.refreshFileSystemList):
(WebInspector.FileSystemModel.prototype._gotFileSystem):
(WebInspector.FileSystemModel.FileSystem):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototype.getFileSystemRoot):
(WebInspector.FileSystemRequestManager.prototype._gotFileSystemRoot):
(WebInspector.FileSystemDispatcher.prototype.gotFileSystemRoot):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):

LayoutTests:

  • http/tests/inspector/filesystem/get-filesystem-root-expected.txt: Added.
  • http/tests/inspector/filesystem/get-filesystem-root.html: Added.
03:27 Changeset [120701] by yurys@chromium.org

[Chromium] Web Inspector: remove unnecessary indirection from message loop instrumentation
https://bugs.webkit.org/show_bug.cgi?id=89443

Removed start/stopMainThreadMonitoring methods from WebDevToolsAgentClient
and WebDevToolsAgentImpl. The functionality is now implemented inside
InspectorClientImpl.

Reviewed by Vsevolod Vlasov.

  • public/WebDevToolsAgentClient.h:
  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::clearBrowserCookies):
(WebKit::InspectorClientImpl::startMainThreadMonitoring):
(WebKit::InspectorClientImpl::stopMainThreadMonitoring):
(WebKit::InspectorClientImpl::willProcessTask):
(WebKit):
(WebKit::InspectorClientImpl::didProcessTask):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

03:18 Changeset [120700] by rniwa@webkit.org

Update webkit.org to refer to layoutTestController instead of testRunner
https://bugs.webkit.org/show_bug.cgi?id=89445

Reviewed by Kent Tamura.

  • quality/testwriting.html:
02:33 Changeset [120699] by zoltan@webkit.org

[Qt] Modify HTTPS port to 8443 for performance tests
https://bugs.webkit.org/show_bug.cgi?id=89442

Reviewed by Ryosuke Niwa.

We should be consistent with the default HTTPS port and with the changelog of r119188.

  • Scripts/webkitpy/performance_tests/perftest.py:

(ReplayServer.init):

02:13 Changeset [120698] by commit-queue@webkit.org

Introduce ENABLE_CSP_NEXT configuration flag.
https://bugs.webkit.org/show_bug.cgi?id=89300

Patch by Mike West <mkwst@chromium.org> on 2012-06-19
Reviewed by Adam Barth.

The 1.0 draft of the Content Security Policy spec is just about to
move to Last Call. We'll hide work on the upcoming 1.1 spec behind
this ENABLE flag, disabled by default.

Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
02:12 Changeset [120697] by jhoneycutt@apple.com

REGRESSION(r120552): Many tests timing out on Windows
https://bugs.webkit.org/show_bug.cgi?id=89433

Reviewed by Andy Estes.

  • wtf/CurrentTime.cpp:

(WTF::lowResUTCTime):
It looks like there were two bugs:
1) the function was converting from 100ths of nanoseconds to seconds

rather than 100s of nanoseconds to seconds by dividing by
(nsPerSecond * 100) rather than (nsPerSecond / 100)

2) the function should've been returning milliseconds, not seconds

02:10 Changeset [120696] by commit-queue@webkit.org

Make StylePropertySet::merge() always override on conflict
https://bugs.webkit.org/show_bug.cgi?id=89348

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-19
Reviewed by Ryosuke Niwa.

merge() was only used with argOverridesOnConflict = true, which
makes the extra parameter useless. It will also save a boolean check.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::mergeAndOverrideOnConflict):

  • css/StylePropertySet.h:

(StylePropertySet):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::overrideWithStyle):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):

01:57 Changeset [120695] by yosin@chromium.org

[Forms] Move isKeyboardFocusable and isMouseFocusable to InputType from HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=89425

Reviewed by Kent Tamura.

This patch moves implementation of HTMLInpueElement::isKeyboardFocusable
and isMouseFocusable to InputType class to allow each implementation
of InputType can decide focus-ability.

No new tests. This patch doesn't change behavior.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isKeyboardFocusable): Changed to call InputType::isKeyboardFocusable.
(WebCore::HTMLInputElement::isMouseFocusable): Changed to call InputType::isMouseFocusable.
(WebCore::HTMLInputElement::isTextFormControlFocusable): Added to allow InputType can call a method in HTMLTextFormControlElement.
(WebCore::HTMLInputElement::isTextFormControlKeyboardFocusable): Added to allow InputType can call a method in HTMLTextFormControlElement.
(WebCore::HTMLInputElement::isTextFormControlMouseFocusable): Added to allow InputType can call a method in HTMLTextFormControlElement.

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::isKeyboardFocusable): Changed to call isTextFormControlKeyboardFocusable.
(WebCore::InputType::isMouseFocusable): Added for default method of derived InputType classes.

  • html/InputType.h:

(InputType): Chagned signature of isKeyboardFocusable.

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::isKeyboardFocusable): Changed to call isTextFormControlKeyboardFocusable which was done in HTMLInputElement.

  • html/RadioInputType.h:

(RadioInputType):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::isKeyboardFocusable): Moved implementation from HTMLInputElement.
(WebCore::TextFieldInputType::isMouseFocusable): Moved implementation from HTMLInputElement.

  • html/TextFieldInputType.h:

(TextFieldInputType):

01:55 Changeset [120694] by sergio@webkit.org

Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()
https://bugs.webkit.org/show_bug.cgi?id=67582

Reviewed by David Levin.

Source/WebCore:

Added a new synchronous method to the IconDatabase that returns a
native image for the platform instead of a WebCore::Image*.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousNativeIconForPageURL):
(WebCore):

  • loader/icon/IconDatabase.h:

(IconDatabase):

  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
(IconDatabaseBase):

Source/WebKit/blackberry:

Use synchronousNativeIconForPageURL() to retrieve favicons.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):

Source/WebKit/cf:

Fixes windows build.

  • WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/efl:

Use synchronousNativeIconForPageURL() to retrieve favicons.

  • ewk/ewk_history.cpp:

(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):

Source/WebKit/gtk:

Use synchronousNativeIconForPageURL() to retrieve favicons.

  • webkit/webkitfavicondatabase.cpp:

(getIconPixbufSynchronously):

Source/WebKit/qt:

Use synchronousNativeIconForPageURL() to retrieve favicons.

  • Api/qwebhistory.cpp:

(QWebHistoryItem::icon):

  • Api/qwebsettings.cpp:

(QWebSettings::iconForUrl):

01:45 Changeset [120693] by aestes@apple.com

[Mac] Use AutodrainedPool instead of NSAutoreleasePool in AudioBus::loadPlatformResource()
https://bugs.webkit.org/show_bug.cgi?id=89427

Reviewed by Dan Bernstein.

loadPlatformResource() called -[NSAutoreleasePool release] at each of
its exit points, which is not only an error-prone pattern but is
incorrect in garbage-collected environments. AutodrainedPool solves
both these problems by automatically calling -[NSAutoreleasePool drain]
when going out of scope.

  • platform/audio/mac/AudioBusMac.mm:

(WebCore::AudioBus::loadPlatformResource):

01:38 Changeset [120692] by commit-queue@webkit.org

[EFL] EFL's LayoutTestController does not support setTextDirection
https://bugs.webkit.org/show_bug.cgi?id=87481

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-19
Reviewed by Hajime Morita.

Source/WebKit/efl:

Add new Ewk_View method to set the text direction, by calling
Editor::setBaseWritingDirection() internally, as Mac and Chromium
ports do.

  • WebCoreSupport/AssertMatchingEnums.cpp:
  • ewk/ewk_view.cpp:

(ewk_view_text_direction_set):

  • ewk/ewk_view.h:

Tools:

Implement setTextDirection in EFL's LayoutTestController and
properly reset its value between test cases to avoid flakiness.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setTextDirection):

LayoutTests:

Unskip related test case now that EFL's LayoutTestController
implements setTextDirection.

  • platform/efl/Skipped:
01:36 Changeset [120691] by rniwa@webkit.org

Compilation failure in StyleResolver.cpp
https://bugs.webkit.org/show_bug.cgi?id=89446

Patch by Mike West <mkwst@chromium.org> on 2012-06-19
Reviewed by Ryosuke Niwa.

Adding 'CSSPropertyWebkitColumnProgression' to a switch statement from
which it was missing.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

01:23 Changeset [120690] by ossy@webkit.org

[Qt] Unreviewed build system fix after r120051.

  • Target.pri:
01:18 Writing DumpAsMarkup Tests edited by rniwa@webkit.org
s/layoutTestController/testRunner/ (diff)
01:17 Writing Layout Tests for DumpRenderTree edited by rniwa@webkit.org
s/layoutTestController/testRunner/ (diff)
01:16 Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
s/layoutTestController/testRunner/ (diff)
01:15 Changeset [120689] by commit-queue@webkit.org

Unreviewed, rolling out r120586.
http://trac.webkit.org/changeset/120586
https://bugs.webkit.org/show_bug.cgi?id=89444

doesn't fix mac issue (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-19

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::replaceMisspelledRange):

00:40 Changeset [120688] by kkristof@inf.u-szeged.hu

[Qt] Temporarily disable xvfb driver in nrwt
https://bugs.webkit.org/show_bug.cgi?id=88414

Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._build_driver):

00:35 Changeset [120687] by morrita@google.com

Unreviewed expectation update.

  • platform/chromium/TestExpectations:
00:35 Changeset [120686] by hausmann@webkit.org

[Qt] Allow the modules file generation to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=89010

Patch by Joel Dillon <joel.dillon@codethink.co.uk>, Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-06-19
Reviewed by Csaba Osztrogonác.

Add calls to toSystemPath and use QMAKE_DIR_SEP where necessary.

  • Source/api.pri:
00:32 Changeset [120685] by hausmann@webkit.org

[Qt] Fix TARGET not properly being set for QtWebKitd5.dll when building in debug.
https://bugs.webkit.org/show_bug.cgi?id=88880

load(qt_module_config) adjusts the TARGET to add the "d" suffix when doing
the debug build_pass. When doing the first pass, qt_module_config.prf doesn't
adjust the target since it is in debug_and_release and expects the debug
build_pass to come later. However, since we remove debug_and_release from CONFIG
right after this, the TARGET hasn't been adjusted and the debug build_pass
will not happen.

Work around it by disabling this optimization on Windows.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-06-19
Reviewed by Tor Arne Vestbø.

  • Source/api.pri:
00:27 Changeset [120684] by commit-queue@webkit.org

Add a scheme registry for bypassing Content Security Policy.
https://bugs.webkit.org/show_bug.cgi?id=89373

Patch by Mike West <mkwst@chromium.org> on 2012-06-19
Reviewed by Adam Barth.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

The Content Security Policy specification notes that "Enforcing a CSP
policy should not interfere with the operation of user-supplied scripts
such as third-party user-agent add-ons and JavaScript bookmarklets."
(https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#processing-model)
This use case can be at least partially addressed by adding a scheme
registry for certain types of URLs whose resources should be loaded
regardless of a page's defined policy directives.

See http://crbug.com/133223 for additional context.

Test: http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html

  • WebCore.exp.in:

Exporting new symbols for use by Internals.

  • page/ContentSecurityPolicy.cpp:

(WebCore::isAllowedByAllWithURL):

Adding a check against the new SchemeRegistry method to determine
whether or not we should proceed with checking the URL against the
policy.

  • platform/SchemeRegistry.cpp:

(WebCore::CSPBypassingSchemes):
(WebCore):
(WebCore::SchemeRegistry::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsBypassingContentSecurityPolicy):
(WebCore::SchemeRegistry::schemeShouldBypassContentSecurityPolicy):

  • platform/SchemeRegistry.h:

(SchemeRegistry):

Adding the scheme registry for CSP-bypassing URL schemes.

  • testing/Internals.cpp:

(WebCore):
(WebCore::Internals::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebCore::Internals::removeURLSchemeRegisteredAsBypassingContentSecurityPolicy):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Adding a method to Internals so that we can write a layout test.

Source/WebKit/chromium:

  • public/WebSecurityPolicy.h:

(WebSecurityPolicy):

  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebKit):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • http/tests/security/contentSecurityPolicy/register-bypassing-scheme-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html: Added.
00:23 Changeset [120683] by rniwa@webkit.org

Use testRunner instead of layoutTestController in fast/canvas, clip, compact, constructors, cookies, and css* tests
https://bugs.webkit.org/show_bug.cgi?id=89431

Reviewed by Kent Tamura.

  • fast/canvas/:
  • fast/constructors/constructor-as-function-crash.html:
  • fast/css-generated-content/absolute-position-inside-inline.html:
  • fast/css-generated-content/after-with-first-letter-float-crash.html:
  • fast/css-generated-content/attr-missing.html:
  • fast/css-generated-content/before-content-with-list-marker-in-anon-block-crash.html:
  • fast/css-generated-content/block-after.html:
  • fast/css-generated-content/drag-state.html:
  • fast/css-generated-content/empty-content-with-float-crash.html:
  • fast/css-generated-content/first-letter-next-sibling-crash.html:
  • fast/css-generated-content/first-letter-table-cell-format-block-crash.html:
  • fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html:
  • fast/css-generated-content/floating-before-content-with-list-marker-crash.html:
  • fast/css-generated-content/hit-test-generated-content.html:
  • fast/css-generated-content/hover-style-change.html:
  • fast/css-generated-content/inline-splitting-with-after-float-crash.html:
  • fast/css-generated-content/malformed-url.html:
  • fast/css-generated-content/positioned-background-hit-test-crash.html:
  • fast/css-generated-content/positioned-div-with-floating-after-content-crash.html:
  • fast/css-generated-content/positioned-generated-content-under-run-in-crash.html:
  • fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash.html:
  • fast/css-generated-content/reset-content-to-initial.html:
  • fast/css-generated-content/resources/pass.html:
  • fast/css-generated-content/resources/positioned-div-with-floating-after-content-crash-frame2.html:
  • fast/css-generated-content/spellingToolTip-assert.html:
  • fast/css-generated-content/table-row-after-no-crash.html:
  • fast/css-generated-content/table-with-scrollbar-corner.html:
  • fast/css-generated-content/text-before-table-col-crash.html:
  • fast/css-grid-layout/display-grid-set-get.html:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
  • fast/css-grid-layout/grid-columns-rows-get-set.html:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:
  • fast/css/:
  • platform/mac/fast/canvas/canvas-draw-xbm-image.html:
  • platform/qt/fast/canvas/toDataURL-jpeg-alpha.html:
  • platform/qt/fast/canvas/toDataURL-jpeg-primarycolors.html:
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-basic.html:
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-notnumber.html:
  • platform/qt/fast/canvas/toDataURL-jpeg-quality-outsiderange.html:

06/18/12:

23:52 Changeset [120682] by ossy@webkit.org

[Qt] Unreviewed gardening, skip failing tests.

  • platform/qt-4.8/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/Skipped:
23:35 Changeset [120681] by rniwa@webkit.org

Use testRunner instead of layoutTestController in fast/animation, autoresize, backgrounds, block, body-propagation, borders, and box-* tests
https://bugs.webkit.org/show_bug.cgi?id=89422

Reviewed by Kent Tamura.

  • fast/animation/request-animation-frame-detach-element.html:
  • fast/animation/request-animation-frame-detach-element2.html:
  • fast/animation/request-animation-frame-disabled.html:
  • fast/animation/request-animation-frame-during-modal.html:
  • fast/animation/request-animation-frame-iframe.html:
  • fast/animation/script-tests/request-animation-frame-cancel.js:
  • fast/animation/script-tests/request-animation-frame-cancel2.js:
  • fast/animation/script-tests/request-animation-frame-disabled.js:
  • fast/animation/script-tests/request-animation-frame-timestamps-advance.js:
  • fast/animation/script-tests/request-animation-frame-timestamps.js:
  • fast/animation/script-tests/request-animation-frame-within-callback.js:
  • fast/animation/script-tests/request-animation-frame.js:
  • fast/autoresize/autoresize-with-iframe.html:
  • fast/autoresize/basic.html:
  • fast/autoresize/turn-off-autoresize.html:
  • fast/backgrounds/animated-gif-as-background.html:
  • fast/backgrounds/animated-svg-as-mask.html:
  • fast/backgrounds/background-fast-path-simple-color.html:
  • fast/backgrounds/background-fill-zero-area-crash.html:
  • fast/backgrounds/background-repeat-computed-style.html:
  • fast/backgrounds/multiple-backgrounds-assert.html:
  • fast/backgrounds/root-background-propagation.html:
  • fast/backgrounds/root-background-propagation2.html:
  • fast/backgrounds/size/contain-and-cover-zoomed.html:
  • fast/backgrounds/solid-color-context-restore.html:
  • fast/block/:
  • fast/borders/border-image-reset-by-border-shorthand.html:
  • fast/borders/border-image-slice-omission.html:
  • fast/borders/border-mixed-alpha.html:
  • fast/borders/border-radius-complex-inner.html:
  • fast/borders/border-radius-parsing.html:
  • fast/borders/negative-border-width.html:
  • fast/borders/outline-alpha-block.html:
  • fast/borders/outline-alpha-inline.html:
  • fast/box-shadow/box-shadow-clipped-slices.html:
  • fast/box-shadow/box-shadow-currentcolor.html:
  • fast/box-shadow/no-blur-multiple-offsets.html:
  • fast/box-shadow/resources/box-shadow-overflow-scroll.js:
  • fast/box-shadow/spread-multiple-inset.html:
  • fast/box-shadow/spread-multiple-normal.html:
23:33 Changeset [120680] by aestes@apple.com

[Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow
https://bugs.webkit.org/show_bug.cgi?id=89424

Reviewed by Dan Bernstein.

  • editing/mac/EditorMac.mm:

(WebCore::Editor::fontAttributesForSelectionStart): Store the NSShadow
in a RetainPtr so that it's released before going out of scope.

23:20 Changeset [120679] by tkent@chromium.org

Refactoring: Introduce a class to represent restoring state of a form control
https://bugs.webkit.org/show_bug.cgi?id=89412

Reviewed by Hajime Morita.

HTMLFormControlElementWithState::saveFormControlState had two return
values; One is a boolean to represent whether we should save the state
or not, and another is form control value. This patch introduces
FormControlState class representing these values.

We're going to extend FormControlState class so that it can contain
multiple strings to fix a FileInputType issue and it have another type
to fix Bug 89409.

No new tests. Just a refactoring.

  • html/FormController.cpp:

(WebCore::FormController::formElementsState):
Gets a state string from a FormControlState instance.
(WebCore::FormController::takeStateForFormElement):
Creates a FormControlState instance with a state string.

  • html/FormController.h:

(WebCore::FormControlState): Added.

  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::saveFormControlState):
Use FormControlState class.
(WebCore::BaseCheckableInputType::restoreFormControlState): ditto.

  • html/BaseCheckableInputType.h:

(BaseCheckableInputType): ditto.

  • html/FileInputType.cpp:

(WebCore::FileInputType::saveFormControlState): ditto.
(WebCore::FileInputType::restoreFormControlState): ditto.

  • html/FileInputType.h:

(FileInputType): ditto.

  • html/HTMLFormControlElementWithState.cpp:

(WebCore::HTMLFormControlElementWithState::saveFormControlState): ditto.
(WebCore::HTMLFormControlElementWithState::finishParsingChildren): ditto.

  • html/HTMLFormControlElementWithState.h:

(HTMLFormControlElementWithState): ditto.
(WebCore::HTMLFormControlElementWithState::restoreFormControlState): ditto.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::saveFormControlState): ditto.
(WebCore::HTMLInputElement::restoreFormControlState): ditto.

  • html/HTMLInputElement.h:

(HTMLInputElement): ditto.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::saveFormControlState): ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): ditto.

  • html/HTMLSelectElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::saveFormControlState): ditto.
(WebCore::HTMLTextAreaElement::restoreFormControlState): ditto.

  • html/HTMLTextAreaElement.h:
  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::saveFormControlState): ditto.
(WebCore::HiddenInputType::restoreFormControlState): ditto.

  • html/HiddenInputType.h:

(HiddenInputType): ditto.

  • html/InputType.cpp:

(WebCore::InputType::saveFormControlState): ditto.
(WebCore::InputType::restoreFormControlState): ditto.

  • html/InputType.h:

(InputType): ditto.

  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::saveFormControlState): ditto.
(WebCore::PasswordInputType::restoreFormControlState): ditto.

  • html/PasswordInputType.h:

(PasswordInputType): ditto.

23:16 Changeset [120678] by zandobersek@gmail.com

Unreviewed GTK gardening, updating baselines after rollouts in r120627.

  • platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
  • platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
  • platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
  • platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:
23:09 Changeset [120677] by ossy@webkit.org

[Qt] Unreviewed gardening, update expected files.

  • platform/qt/Skipped: Skip a new failing test to paint the bot green.
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Updated after r120609.
  • platform/qt/fast/multicol/progression-reverse-expected.png: Added after r120609.
  • platform/qt/fast/multicol/progression-reverse-expected.txt: Added after r120609.
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt: Updated after r120609.
23:07 Changeset [120676] by commit-queue@webkit.org

Source/JavaScriptCore: Changed JSC to always record line number information so that error.stack
and window.onerror() can report proper line numbers.
https://bugs.webkit.org/show_bug.cgi?id=89410

Patch by Mark Lam <mark.lam@apple.com> on 2012-06-18
Reviewed by Geoffrey Garen.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit): m_lineInfo is now available unconditionally.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addLineInfo):
(JSC::CodeBlock::hasLineInfo): Unused. Now removed.
(JSC::CodeBlock::needsCallReturnIndices):
(CodeBlock):
(RareData): Hoisted m_lineInfo out of m_rareData. m_lineInfo is now
filled in unconditionally.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::addLineInfo):

LayoutTests: Ensure that error.stack and window.onerror always have the appropriate
line numbers of the exception being thrown.
https://bugs.webkit.org/show_bug.cgi?id=89410

Patch by Mark Lam <mark.lam@apple.com> on 2012-06-18
Reviewed by Geoffrey Garen.

  • fast/js/exception-line-number-expected.txt: Added.
  • fast/js/exception-line-number.html: Added.
  • fast/js/script-tests/exception-line-number.js: Added.

(foo):
(window.onerror):

22:47 Changeset [120675] by joone@webkit.org

[EFL] Fontconfig can't be linked properly
https://bugs.webkit.org/show_bug.cgi?id=89418

Unreviewed build fix.

Make Fontconfig be linked correctly.

Source/WebCore:

No new tests. This is only a build fix.

  • PlatformEfl.cmake: add FONTCONFIG_LIBRARIES to WebCore_LIBRARIES.

Tools:

  • MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
22:47 Changeset [120674] by kinuko@chromium.org

Unreviewed test fix (one more) for r120667: skip '.svn' directory from the test results.

  • fast/forms/file/input-file-entries.html:
22:34 Changeset [120673] by mrobinson@webkit.org

[Cairo] Fix memory leaks in GLContextGLX.cpp
https://bugs.webkit.org/show_bug.cgi?id=89346

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-18
Reviewed by Martin Robinson.

Fix memory leaks found in GLContextGLX.cpp.

  • platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::cleanupActiveContextsAtExit): Removing element reduces
size of the vector, so the loop termination condition was failing in the last
iteration, when the vector contains more than one element. This patch fixes the
issue by iterating the vector backwards, so the termination condition doesn't
fail until the size() reaches 0.
(WebCore::GLContextGLX::createPbufferContext): Delete GLXPbuffer
returned by glXCreatePbuffer().
(WebCore::GLContextGLX::createPixmapContext): Delete XVisualInfo
returned by glXChooseVisual().

22:19 Changeset [120672] by mikelawther@chromium.org

Unreviewed gardening. Add missing expectation file.

  • fast/text/title-crash-expected.txt: Added.
22:09 Changeset [120671] by joone@webkit.org

Unreviewed. Updating email for committers.py script.

  • Scripts/webkitpy/common/config/committers.py:
22:08 Changeset [120670] by kinuko@chromium.org

Unreviewed test fix for r120667: skip '.svn' directory from the test results.

  • fast/forms/file/input-file-entries.html:
21:56 Changeset [120669] by simon.fraser@apple.com

Fix a typo that caused TestFailures to have a syntax error.

Sadly TestFailures is broken for another reason now too:
https://bugs.webkit.org/show_bug.cgi?id=89419

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:

(ViewController.prototype._domForBuildName):

21:34 Changeset [120668] by commit-queue@webkit.org

Source/WebCore: Expose WEBGL_depth_texture extension to WebGL
https://bugs.webkit.org/show_bug.cgi?id=87029

Patch by Gregg Tavares <gman@google.com> on 2012-06-18
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/webgl-depth-texture.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLDepthTexture.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebCore::WebGLDepthTexture::WebGLDepthTexture):
(WebCore::WebGLDepthTexture::~WebGLDepthTexture):
(WebCore::WebGLDepthTexture::getName):
(WebCore::WebGLDepthTexture::create):
(WebCore::WebGLDepthTexture::supported):

  • html/canvas/WebGLDepthTexture.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebGLDepthTexture):

  • html/canvas/WebGLDepthTexture.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::initializeAttachments):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::validateSettableTexFormat):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::generateMipmap):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
(WebCore::WebGLRenderingContext::validateTexFuncData):

  • html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::getClearBitsByAttachmentType):
(WebCore):
(WebCore::GraphicsContext3D::getClearBitsByFormat):

  • platform/graphics/GraphicsContext3D.h:

LayoutTests: Expose WEBGL_depth_texture extension to WebGL
https://bugs.webkit.org/show_bug.cgi?id=87029

Patch by Gregg Tavares <gman@google.com> on 2012-06-18
Reviewed by Kenneth Russell.

  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils):

  • fast/canvas/webgl/webgl-depth-texture-expected.txt: Added.
  • fast/canvas/webgl/webgl-depth-texture.html: Added.
21:13 Changeset [120667] by kinuko@chromium.org

Support File/DirectoryEntry access for <input type=file> if FileSystem API is enabled
https://bugs.webkit.org/show_bug.cgi?id=88293

Reviewed by Tony Chang.

Source/WebCore:

Proposal email on whatwg: http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033814.html
Proposal draft: http://wiki.whatwg.org/wiki/DragAndDropEntries

Test: fast/forms/file/input-file-entries.html

  • Modules/filesystem/HTMLInputElementFileSystem.cpp: Added.
  • Modules/filesystem/HTMLInputElementFileSystem.h: Added.
  • Modules/filesystem/HTMLInputElementFileSystem.idl: Added.
  • WebCore.gypi:
  • html/FileInputType.cpp:

(WebCore::FileInputType::receiveDroppedFiles): Retrieves dropped file
system Id if the given DragData has it.
(WebCore::FileInputType::droppedFileSystemId): Added. This returns
dropped file system Id retrieved in receiveDroppedFiles, or an empty
string if the platform does not support isolated file system for
dropped files.

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::droppedFileSystemId): Added.

  • html/HTMLInputElement.h:
  • html/InputType.cpp:

(WebCore::InputType::droppedFileSystemId): Added.

  • html/InputType.h:
  • platform/DragData.cpp:
  • platform/DragData.h:
  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::droppedFileSystemId): Added.

LayoutTests:

  • fast/forms/file/input-file-entries-expected.txt: Added.
  • fast/forms/file/input-file-entries.html: Added.
  • fast/forms/resources/dir1/UTF8-2.txt: Added.
  • fast/forms/resources/dir1/UTF8.txt: Added.
  • fast/forms/resources/dir2/green.jpg: Added.
  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
21:02 Changeset [120666] by shinyak@chromium.org

[Crash][Editing] VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries() crashes in some Shadow DOM case.
https://bugs.webkit.org/show_bug.cgi?id=88500

Reviewed by Ryosuke Niwa.

Source/WebCore:

When selecting from a child of shadow host to an element in Shadow DOM, the start position of
Selection comes after the end position of Selection in some cases. This caused a crash.

For example, let's think '<div id="host">A</div>D' and host has a Shadow DOM whose innerHTML
is 'B<content></content>C'. When selecting from just after A (p1 = (PositionIsOffsetInAnchor,
#text, 1)) to just before B (p2 = (PositionIsOffsetInAnchor, shadowRoot, 0)), since
comparePosition always judge as p2 is before p1, m_start and m_end in VisibleSelection
will be p2 and p1 respectively.

However, the anchorNodes of p1 and p2 have the different tree scope, we have to adjust p2 to
the same tree scope as p1. Since p2 is m_start, m_start was adjusted to positionAfterNode(div).
This breaks the assumption that m_start is always before (or equal to) m_end.

This patch keeps the assumption. When we cannot move m_start to positionAfterNode(div),
we move m_start to positionBeforeNode(div). Note that we cannot always move m_start to
positionBeforeNode(div), because when selecting just after D (p3 = (PositionIsOffsetInAnchor,
D's parent, 2), we don't want to select A.

In this case, m_start should be adjusted to positionAfterNode(div).

Test: editing/shadow/breaking-editing-boundaries.html

  • editing/VisibleSelection.cpp:

(WebCore::adjustPositionForEnd):
(WebCore):
(WebCore::adjustPositionForStart):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):

  • editing/VisibleSelection.h:

(VisibleSelection):

LayoutTests:

  • editing/shadow/breaking-editing-boundaries-expected.txt: Added.
  • editing/shadow/breaking-editing-boundaries.html: Added.
20:54 Changeset [120665] by morrita@google.com

Unreviewed test marking. Marked border-radius-clip-002.htm as a failure.

  • platform/chromium/TestExpectations:
20:34 Changeset [120664] by aestes@apple.com

Fix r120663, which didn't land the change that was reviewed.

20:32 Changeset [120663] by aestes@apple.com

[JSC] In JSGlobalData.cpp, enableAssembler() sometimes leaks two CF objects
https://bugs.webkit.org/show_bug.cgi?id=89415

Reviewed by Sam Weinig.

In the case where canUseJIT was a non-NULL CFBooleanRef,
enableAssembler() would leak both canUseJITKey and canUseJIT by
returning before calling CFRelease. Fix this by using RetainPtr.

  • runtime/JSGlobalData.cpp:

(JSC::enableAssembler):

20:20 Changeset [120662] by mikelawther@chromium.org

Crash when setting title dynamically
https://bugs.webkit.org/show_bug.cgi?id=88083

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/text/title-crash.html

The crashing code takes a rare branch in StyleResolver::styleForElement() where
m_parentStyle is set to point to m_style. Consequently, while applying properties
to m_style we end up mutating m_parentStyle.

In this situation, we clone style() and point m_parentStyle at the clone. The
clone is destroyed at the end of StyleResolver::styleForElement().

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

  • fast/text/title-crash.html: Added.
20:04 Changeset [120661] by enne@google.com

RenderLayerBacking sometimes doesn't attach scrollbars to graphics layer tree
https://bugs.webkit.org/show_bug.cgi?id=89402

Reviewed by James Robinson.

Source/WebCore:

RenderLayerBacking only attaches scrollbar layers to the graphics
layer tree if there's a clip layer. This is wrong, because these
scrollbars become orphans and other code expects them to handle
repainting the scrollbars (which now become invisible). Fix by always
attaching scrollbar layers.

Test: compositing/overflow/image-load-overflow-scrollbars.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateInternalHierarchy):

LayoutTests:

Add a test where an image load creates overflow.

  • compositing/overflow/image-load-overflow-scrollbars-expected.png: Added.
  • compositing/overflow/image-load-overflow-scrollbars-expected.txt: Added.
  • compositing/overflow/image-load-overflow-scrollbars.html: Added.
19:54 Changeset [120660] by fischman@chromium.org

Make serve-video.php serve 206 responses
https://bugs.webkit.org/show_bug.cgi?id=89252

Reviewed by Adam Barth.

  • http/tests/media/resources/serve-video.php:
19:51 Changeset [120659] by abarth@webkit.org

[Chromium] GesturePinchBegin and friends are gesture events
https://bugs.webkit.org/show_bug.cgi?id=89398

Reviewed by James Robinson.

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isGestureEventType):

19:25 Changeset [120658] by morrita@google.com

Unreviewed test marking. Marked border-radius-clip-002.htm as a failure.

  • platform/chromium/TestExpectations:
19:06 Changeset [120657] by simon.fraser@apple.com

Provide bug links for suspicious commits
https://bugs.webkit.org/show_bug.cgi?id=89408

Reviewed by Adam Barth.

Add links to bugs for the suspicious commits if we have bug data.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:

(ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
(ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):

18:54 Changeset [120656] by jchaffraix@webkit.org

Merge 120257 - Padding and borders can cause integer overflow in block layouts

https://bugs.webkit.org/show_bug.cgi?id=88820

< rdar://problem/11328762>
Reviewed by Tony Chang.
Source/WebCore:
Tests: fast/block/block-size-integer-overflow.html
fast/flexbox/box-size-integer-overflow.html
fast/table/table-size-integer-overflow.html

  • rendering/AutoTableLayout.cpp: Decreased max int.

(WebCore::AutoTableLayout::computePreferredLogicalWidths):

  • rendering/FixedTableLayout.cpp: Use shared constant.

(WebCore::FixedTableLayout::computePreferredLogicalWidths):

  • rendering/RenderBlock.cpp: Removed unused constant.
  • rendering/TableLayout.h: Add shared constant.

(TableLayout):
LayoutTests:

  • fast/block/block-size-integer-overflow-expected.txt: Added.
  • fast/block/block-size-integer-overflow.html: Added.
  • fast/flexbox/box-size-integer-overflow-expected.txt: Added.
  • fast/flexbox/box-size-integer-overflow.html: Added.
  • fast/table/table-size-integer-overflow-expected.txt: Added.
  • fast/table/table-size-integer-overflow.html: Added.

TBR=tc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10583010

18:38 Changeset [120655] by commit-queue@webkit.org

[Chromium] DeviceOrientation Cleanup
https://bugs.webkit.org/show_bug.cgi?id=89354

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-18
Reviewed by Kent Tamura.

Source/WebCore:

No new tests because there is no intended change in behavior.

  • platform/mock/DeviceOrientationClientMock.h: added OVERRIDE specifier for virtual functions

(DeviceOrientationClientMock):

Source/WebKit/chromium:

  • public/WebDeviceOrientation.h: added const-qualifiers to getters, simplified an overly-complicated parameter to two functions

(WebKit::WebDeviceOrientation::isNull):
(WebKit::WebDeviceOrientation::canProvideAlpha):
(WebKit::WebDeviceOrientation::alpha):
(WebKit::WebDeviceOrientation::canProvideBeta):
(WebKit::WebDeviceOrientation::beta):
(WebKit::WebDeviceOrientation::canProvideGamma):
(WebKit::WebDeviceOrientation::gamma):
(WebKit::WebDeviceOrientation::canProvideAbsolute):
(WebKit::WebDeviceOrientation::absolute):
(WebDeviceOrientation):

  • public/WebDeviceOrientationClient.h: added WEBKIT_ASSERT_NOT_REACHED to virtual functions

(WebKit::WebDeviceOrientationClient::setController):
(WebKit::WebDeviceOrientationClient::startUpdating):
(WebKit::WebDeviceOrientationClient::stopUpdating):
(WebKit::WebDeviceOrientationClient::lastOrientation):

  • public/WebDeviceOrientationClientMock.h: added OVERRIDE specifier for virtual functions

(WebDeviceOrientationClientMock):

  • src/DeviceOrientationClientProxy.h: designated functions as 'virtual' and added OVERRIDE specifier

(DeviceOrientationClientProxy):

  • src/WebDeviceOrientation.cpp: simplified overly-complicated parameter to two functions

(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::operator=):

Tools:

  • DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function

(WebViewHost):

18:32 Changeset [120654] by commit-queue@webkit.org

[EFL] media/video-seek-past-end-playing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=89301

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-18
Reviewed by Philippe Normand.

Source/WebCore:

Switch to double for media duration and playback position
calculations to avoid precision problems.
This patch also removes the workaround for the precision
problem in didEnd() which is no longer needed.

Test: media/video-seek-past-end-playing.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::duration):

LayoutTests:

Unskip media/video-seek-past-end-playing.html now that the
precision problem in MediaPlayerPrivateGStreamer is fixed.

  • platform/efl/TestExpectations:
18:30 Changeset [120653] by scherkus@chromium.org

2012-06-18 Andrew Scherkus <scherkus@chromium.org>

[Chromium] Unreviewed. Rebaseline media layout tests due to updated controls.

https://bugs.webkit.org/show_bug.cgi?id=89050

  • platform/chromium-linux-x86/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-layout-direction-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/media-controls-clone-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-leopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-leopard/media/controls-strict-expected.png:
  • platform/chromium-mac-leopard/media/controls-styling-expected.png:
  • platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-layout-direction-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-controls-clone-expected.png:
  • platform/chromium-mac/media/media-controls-clone-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/media/video-playing-and-pause-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win-vista/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-win-xp/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-layout-direction-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/win-xp/fast/layers/video-layer-expected.txt: Renamed from LayoutTests/platform/win/fast/layers/video-layer-expected.txt.
  • platform/win-xp/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/win/media/audio-controls-rendering-expected.txt.
  • platform/win-xp/media/audio-repaint-expected.txt: Renamed from LayoutTests/platform/win/media/audio-repaint-expected.txt.
  • platform/win-xp/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/win/media/controls-after-reload-expected.txt.
  • platform/win-xp/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/win/media/controls-strict-expected.txt.
  • platform/win-xp/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/win/media/controls-styling-expected.txt.
  • platform/win-xp/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/win/media/controls-without-preload-expected.txt.
  • platform/win-xp/media/media-controls-clone-expected.txt: Renamed from LayoutTests/platform/win/media/media-controls-clone-expected.txt.
  • platform/win-xp/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt.
  • platform/win-xp/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/win/media/video-controls-rendering-expected.txt.
  • platform/win-xp/media/video-display-toggle-expected.txt: Renamed from LayoutTests/platform/win/media/video-display-toggle-expected.txt.
  • platform/win-xp/media/video-empty-source-expected.txt: Renamed from LayoutTests/platform/win/media/video-empty-source-expected.txt.
  • platform/win-xp/media/video-no-audio-expected.txt: Renamed from LayoutTests/platform/win/media/video-no-audio-expected.txt.
  • platform/win-xp/media/video-playing-and-pause-expected.txt: Renamed from LayoutTests/platform/win/media/video-playing-and-pause-expected.txt.
  • platform/win-xp/media/video-zoom-controls-expected.png: Renamed from LayoutTests/platform/win/media/video-zoom-controls-expected.png.
  • platform/win-xp/media/video-zoom-controls-expected.txt: Renamed from LayoutTests/platform/win/media/video-zoom-controls-expected.txt.
18:29 Changeset [120652] by fischman@chromium.org

Unreviewed. Rolled DEPS.

  • DEPS:
18:21 Changeset [120651] by atwilson@chromium.org

Unreviewed chromium expectations update to mark tests as timing out due to r120627.

  • platform/chromium/TestExpectations:
18:12 Changeset [120650] by commit-queue@webkit.org

[chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=89254

Patch by James Robinson <jamesr@chromium.org> on 2012-06-18
Reviewed by Adrienne Walker.

This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
upstream.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createGraphicsContext3D):

18:09 Changeset [120649] by simon.fraser@apple.com

Minor fix suggested by Adam Barth.

Use $(this._what).empty(); rather than removing children one at a time.
For some reason removeAllChildren() is undefined on this node.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
18:03 Changeset [120648] by simon.fraser@apple.com

Show TOT revision in garden-o-matic, and make the revisions into links
https://bugs.webkit.org/show_bug.cgi?id=89396

Reviewed by Adam Barth.

The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
where the revisions are links to trac.

To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
the knock-on effect of flipping the target and href attributes for anchors in some test output.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:

(ViewController.prototype._displayTesters.updateList.list):
(ViewController.prototype._displayTesters.updateList):
(ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
(ViewController.prototype._domForRegressionRange):
(ViewController.prototype._domForAuxiliaryUIElements):
(ViewController.prototype._domForBuildName):
(ViewController.prototype):
(ViewController.prototype.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
18:02 Changeset [120647] by atwilson@chromium.org

Unreviewed chromium expectations.

  • platform/chromium-mac/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
  • platform/chromium-win/compositing/fixed-position-scroll-offset-history-restore-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/fixed-position-scroll-offset-history-restore-expected.png.
17:58 Changeset [120646] by dpranke@chromium.org

REGRESSION(r100558): NRWT should work without SVN or GIT
https://bugs.webkit.org/show_bug.cgi?id=76630

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2012-06-18
Reviewed by Dirk Pranke.

NRWT is not supposed to have a requirement that we have an
actual SVN or Git checkout, and we were unnecessarily
initializing the checkout. This patch removes that line :).

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

17:50 Changeset [120645] by commit-queue@webkit.org

Unreviewed, rolling out r120593.
http://trac.webkit.org/changeset/120593
https://bugs.webkit.org/show_bug.cgi?id=89404

Caused failures in fast/forms/file/input-file-entries.html
(Requested by atwilson on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18

Source/WebCore:

  • Modules/filesystem/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::createIsolatedFileSystem):

  • Modules/filesystem/HTMLInputElementFileSystem.cpp: Removed.
  • Modules/filesystem/HTMLInputElementFileSystem.h: Removed.
  • Modules/filesystem/HTMLInputElementFileSystem.idl: Removed.
  • WebCore.gypi:
  • html/FileInputType.cpp:

(WebCore::FileInputType::receiveDroppedFiles):

  • html/FileInputType.h:

(FileInputType):

  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:
  • html/InputType.h:

(InputType):

  • platform/DragData.cpp:

(WebCore::DragData::modifierKeyState):
(WebCore):

  • platform/DragData.h:

(DragData):

  • platform/chromium/DragDataChromium.cpp:

LayoutTests:

  • fast/forms/file/input-file-entries-expected.txt: Removed.
  • fast/forms/file/input-file-entries.html: Removed.
  • fast/forms/resources/dir1/UTF8-2.txt: Removed.
  • fast/forms/resources/dir1/UTF8.txt: Removed.
  • fast/forms/resources/dir2/green.jpg: Removed.
  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
16:54 Changeset [120644] by jamesr@google.com

[chromium] Use WebImageLayer in GraphicsLayerChromium for image layers
https://bugs.webkit.org/show_bug.cgi?id=89150

Reviewed by Adrienne Walker.

Source/Platform:

Adds a WebImageLayer type to represent layers backed by (guess what) Images.

  • Platform.gypi:
  • chromium/public/WebImageLayer.h: Added.

(WebCore):
(WebKit):
(WebImageLayer):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::~WebImageLayer):

Source/WebCore:

Uses WebImageLayer instead of ImageLayerChromium for GraphicsLayerChromium::setContentsToImage.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):

Source/WebKit/chromium:

Implementation of WebImageLayer. Note: This could (should?) live in WebCore/platform/chromium/support/, but it's
here to be next to the other Web*Layer.cpp implementation files.

  • WebKit.gyp:
  • src/WebImageLayer.cpp: Added.

(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::setBitmap):

16:41 Changeset [120643] by jamesr@google.com

[chromium] GraphicsLayerChromium should use WebContentLayer directly
https://bugs.webkit.org/show_bug.cgi?id=89145

Reviewed by Adrienne Walker.

Source/Platform:

Add an opaque rect parameter to WebContentLayerClient::paintContents() for a client to (optionally) provide
information about opaque portions of the painted region for culling optimizations.

  • chromium/public/WebContentLayerClient.h:

(WebContentLayerClient):

Source/WebCore:

Ports GraphicsLayerChromium (or more specifically OpaqueRectTrackingContentLayerDelegate) to implement
WebContentLayerClient instead of ContentLayerDelegate. In addition to the mechanical changes, this requires
eagerly setting drawsContent on GraphicsLayerChromium::m_layer since WebContentLayerImpl's default value is
different from LayerChromium's. Covered by all of compositing/

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:

(OpaqueRectTrackingContentLayerDelegate):

Source/WebKit/chromium:

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::paintContents):

  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTestMainThreadTypes::createLayer):

  • tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:

(WebCore):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::OpaqueRectTrackingContentLayerDelegateTest):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::canvasRect):
(WebCore::TEST_F):

  • tests/WebLayerTest.cpp:
16:35 Changeset [120642] by enrica@apple.com

Skipping dictation tests on WK2.

Unreviewed.

  • platform/mac-wk2/Skipped:
16:30 Changeset [120641] by commit-queue@webkit.org

Add from-image to css3-images image-resolution
https://bugs.webkit.org/show_bug.cgi?id=85451

Patch by David Barr <davidbarr@chromium.org> on 2012-06-18
Reviewed by Tony Chang.

Source/WebCore:

The css3-images module is at candidate recommendation.
http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-resolution

No new tests; extended fast/css/image-resolution/image-resolution.html

  • css/CSSParser.cpp: Accept from-image identifier in image-resolution property.

(WebCore::CSSParser::parseImageResolution): Map CSSValueFromImage to identifier value from cssValuePool.

  • css/CSSValueKeywords.in: Add from-image.
  • css/StyleBuilder.cpp: Extend ApplyPropertyImageResolution to apply RenderStyle::imageResolutionSource.

(WebCore::ApplyPropertyImageResolution::applyInheritValue): Apply RenderStyle::imageResolutionSource.
(WebCore::ApplyPropertyImageResolution::applyInitialValue): Apply RenderStyle::imageResolutionSource.
(WebCore::ApplyPropertyImageResolution::applyValue): Map CSSValueFromImage to ImageResolutionFromImage.

  • rendering/RenderImage.cpp: Extend conditions for recalculation of intrinsic size.

(WebCore::RenderImage::styleDidChange): Update intrinsic size if RenderStyle::imageResolutionSource() has changed.

  • rendering/style/RenderStyle.cpp: Include StyleRareInheritedData::m_imageResolutionSource in style diff.

(WebCore::RenderStyle::diff): Map change in StyleRareInheritedData::m_imageResolutionSource to StyleDifferenceLayout.

  • rendering/style/RenderStyle.h: Add RenderStyle::imageResolutionSource, RenderStyle::setImageResolutionSource, RenderStyle::initialImageResolutionSource.
  • rendering/style/RenderStyleConstants.h: Add enum ImageResolutionSource.
  • rendering/style/StyleRareInheritedData.cpp: Add StyleRareInheritedData::m_imageResolutionSource.

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Add m_imageResolutionSource to default and copy constructor.
(WebCore::StyleRareInheritedData::operator==): Include m_imageResolutionSource in comparison.

  • rendering/style/StyleRareInheritedData.h: Add StyleRareInheritedData::m_imageResolutionSource.

(StyleRareInheritedData): Add 1-bit field StyleRareInheritedData::m_imageResolutionSource.

LayoutTests:

  • fast/css/image-resolution/image-resolution-expected.txt:
  • fast/css/image-resolution/image-resolution.html:
16:16 Changeset [120640] by jamesr@google.com

[chromium] REGRESSION(r120346) ContentLayerPainter should clear rect to be painted
https://bugs.webkit.org/show_bug.cgi?id=89376

Reviewed by Adrienne Walker.

In r120346, a refactor moved a clearRect()/clip() call from ContentLayerPainter - which all
ContentLayerChromiums use - out to OpaqueRectTrackingContentLayerDelegate - which all GraphicsLayerChromium
backed layers use, but which callers using WebContentLayer directly do not use. This meant that the canvas
wasn't cleared/clipped as WebContentLayerClient.h claimed it would be. This moves the clear and the clip
into CanvasLayerTextureUpdater which all paths use, including layers that don't use the ContentLayerPainter.

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::paint):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

16:14 Changeset [120639] by igor.o@sisa.samsung.com

Unreviewed, rolling out r120119.
http://trac.webkit.org/changeset/120119

Multiple regressions on ClusterFuzz

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):

  • page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):

  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:

(RenderObject):

LayoutTests:

  • animations/first-letter-animation-expected.txt: Removed.
  • animations/first-letter-animation.html: Removed.
  • animations/first-letter-play-state-expected.txt: Removed.
  • animations/first-letter-play-state.html: Removed.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • transitions/first-letter-color-transition-expected.txt: Removed.
  • transitions/first-letter-color-transition.html: Removed.
  • transitions/first-letter-transition-expected.txt: Removed.
    • transitions/first-letter-transition.html: Removed.
16:09 Changeset [120638] by rniwa@webkit.org

REGRESSION(r118414): some pages on concursolutions.com doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=89399

Reviewed by Adam Barth.

Source/WebCore:

The bug was caused by insertAdjacentHTML's not passing context element to createFragmentForInnerOuterHTML.

Test: fast/html/adjacent-html-context-element.html

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::insertAdjacentHTML):

LayoutTests:

Add a regression test.

  • fast/html/adjacent-html-context-element-expected.txt: Added.
  • fast/html/adjacent-html-context-element.html: Added.
16:03 Changeset [120637] by isherman@chromium.org

[Chromium] Ensure layout has happened before calling into hasNonEmptyBoundingBox()
Also update existing code to use updateLayoutIgnorePendingStylesheets()
https://bugs.webkit.org/show_bug.cgi?id=89258

Reviewed by James Robinson.

  • src/WebNode.cpp:

(WebKit::WebNode::isFocusable): Use updateLayoutIgnorePendingStylesheets()
(WebKit::WebNode::hasNonEmptyBoundingBox): Force layout before checking the bounding box

15:37 Changeset [120636] by zmo@google.com

Fix framebuffer-object-attachment.html failures
https://bugs.webkit.org/show_bug.cgi?id=89387

Reviewed by Kenneth Russell.

  • html/canvas/WebGLFramebuffer.cpp: fix detachment behavior with depth/stencil/depth_stencil conflicts

(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):

  • html/canvas/WebGLFramebuffer.h:

(WebGLFramebuffer):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer): move logic to WebGLFramebuffer
(WebCore::WebGLRenderingContext::framebufferTexture2D): Ditto.
(WebCore::WebGLRenderingContext::getParameter): Correct the wrong assumption that it's always checking the drawingbuffer's DEPTH_BITS/STENCIL_BITS

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

15:17 Changeset [120635] by atwilson@chromium.org

Unreviewed expectations update for chromium after r120602.

  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
15:17 Changeset [120634] by commit-queue@webkit.org

[chromium] Ensure that skipping frames during an accelerated animation doesn't cause starvation
https://bugs.webkit.org/show_bug.cgi?id=87766

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-18
Reviewed by James Robinson.

Source/WebCore:

Unit tests:

CCLayerTreeHostTestCheckerboardDoesNotStarveDraws.runMultiThread
CCSchedulerStateMachineTest.TestFailedDrawsWillEventuallyForceADrawAfterTheNextCommit

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::didDrawIfPossibleCompleted):
(WebCore::CCSchedulerStateMachine::setMaximumNumberOfFailedDrawsBeforeDrawIsForced):
(WebCore):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(CCSchedulerStateMachine):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestCheckerboardDoesNotStarveDraws):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::beginTest):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::afterTest):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::animateLayers):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestCheckerboardDoesNotStarveDraws::prepareToDrawOnCCThread):
(WTF::TEST_F):

  • tests/CCSchedulerStateMachineTest.cpp:

(WebCore::TEST):
(WebCore):

  • tests/CCThreadedTest.cpp:

(WebKitTests::MockLayerTreeHostImpl::prepareToDraw):

  • tests/CCThreadedTest.h:

(WebKitTests::TestHooks::prepareToDrawOnCCThread):

15:16 Changeset [120633] by zandobersek@gmail.com

[garden-o-matic] Add support for the GTK builders
https://bugs.webkit.org/show_bug.cgi?id=89360

Reviewed by Adam Barth.

Add the 'gtk' platform, essentially a copy of the 'apple' platform since
both get their data from build.webkit.org.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

(.):

15:08 Changeset [120632] by rwlbuis@webkit.org

[BlackBerry] Enable LEGACY_VIEWPORT_ADAPTION
https://bugs.webkit.org/show_bug.cgi?id=89381

Reviewed by Antonio Gomes.

PR 163598

Enable LEGACY_VIEWPORT_ADAPTION.

  • Source/cmake/OptionsBlackBerry.cmake:
15:08 Changeset [120631] by thakis@chromium.org

Merge 120629 - [chromium/mac] Unbreak smooth scrolling.
https://bugs.webkit.org/show_bug.cgi?id=89327

Reviewed by Dimitri Glazkov.

Broken by Sam in r115589 / r115591.

Source/WebCore:

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::scrollAnimationEnabledForSystem):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • TestWebKitAPI/mac/InjectedBundleControllerMac.mm:

(TestWebKitAPI::InjectedBundleController::platformInitialize):

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10572004

15:07 Changeset [120630] by abarth@webkit.org

Update baselines after http://trac.webkit.org/changeset/120609.

  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/fast/multicol/progression-reverse-expected.png: Added.
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle: Removed.
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/fast/multicol/progression-reverse-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/fast/multicol/progression-reverse-expected.png: Added.
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/multicol/progression-reverse-expected.png: Added.
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
14:48 Changeset [120629] by thakis@chromium.org

[chromium/mac] Unbreak smooth scrolling.
https://bugs.webkit.org/show_bug.cgi?id=89327

Reviewed by Dimitri Glazkov.

Broken by Sam in r115589 / r115591.

Source/WebCore:

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::scrollAnimationEnabledForSystem):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • TestWebKitAPI/mac/InjectedBundleControllerMac.mm:

(TestWebKitAPI::InjectedBundleController::platformInitialize):

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

14:43 Changeset [120628] by enrica@apple.com

Updating test results to include flakey cookies tests.

Unreviewed.

  • platform/mac/TestExpectations:
14:38 Changeset [120627] by commit-queue@webkit.org

Unreviewed, rolling out r120541, r120547, and r120548.
http://trac.webkit.org/changeset/120541
http://trac.webkit.org/changeset/120547
http://trac.webkit.org/changeset/120548
https://bugs.webkit.org/show_bug.cgi?id=89383

This approach doesn't work for WebKit2 (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18

Source/WebCore:

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):

  • testing/InternalSettings.h:

(InternalSettings):

Tools:

  • DumpRenderTree/LayoutTestController.cpp:

(setBackingScaleFactorCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:

(LayoutTestController::setBackingScaleFactor):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setBackingScaleFactor):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setBackingScaleFactor):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setBackingScaleFactor):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setBackingScaleFactor):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::setBackingScaleFactor):

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::postSetBackingScaleFactor):
(WTR):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setBackingScaleFactor):
(WTR):
(WTR::LayoutTestController::callSetBackingScaleFactorCallback):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

  • compositing/tiled-layers-hidpi.html:
  • fast/canvas/2d.backingStorePixelRatio.html:
  • fast/canvas/2d.imageDataHD.html:
  • fast/hidpi/broken-image-icon-hidpi.html:
  • fast/hidpi/broken-image-with-size-hidpi.html:
  • fast/hidpi/clip-text-in-hidpi.html:
  • fast/hidpi/focus-rings.html:
  • fast/hidpi/image-set-as-background.html:
  • fast/hidpi/image-set-background-dynamic.html:
  • fast/hidpi/image-set-background-repeat-without-size.html:
  • fast/hidpi/image-set-background-repeat.html:
  • fast/hidpi/image-set-border-image-comparison.html:
  • fast/hidpi/image-set-border-image-dynamic.html:
  • fast/hidpi/image-set-border-image-simple.html:
  • fast/hidpi/image-set-in-content-dynamic.html:
  • fast/hidpi/image-set-out-of-order.html:
  • fast/hidpi/image-set-simple.html:
  • fast/hidpi/image-set-without-specified-width.html:
  • fast/hidpi/resize-corner-hidpi.html:
  • fast/hidpi/video-controls-in-hidpi.html:
  • platform/mac-wk2/plugins/contents-scale-factor.html:
  • svg/as-image/image-respects-deviceScaleFactor.html:
14:34 Changeset [120626] by commit-queue@webkit.org

[BlackBerry] NetworkJob::startNewJobWithRequest() should check the frame pointer
https://bugs.webkit.org/show_bug.cgi?id=89369

Patch by Yong Li <yoli@rim.com> on 2012-06-18
Reviewed by Antonio Gomes.

NetworkJob::startNewJobWithRequest() should stop proceeding if the frame is null,
which means it is a PingLoader job and should just finish now.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::startNewJobWithRequest):

14:08 Changeset [120625] by abarth@webkit.org

Fix the expected result for this test. This got landed with the wrong expected.txt file.

  • http/tests/security/contentSecurityPolicy/source-list-parsing-malformed-meta-expected.txt:
13:40 Changeset [120624] by mitz@apple.com

Ideographic comma and full-stops are mishandled in linebreak
https://bugs.webkit.org/show_bug.cgi?id=87041

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop-2.html

Specifically, line breaks were always allowed after an ideographic comma or full stop, even
before a closing bracket.

  • rendering/break_lines.cpp:

(WebCore::shouldBreakAfter): Removed code that unconditionally allowed line breaks after
ideographic commas and full stops, which was added for <http://webkit.org/b/17411> to work
around an issue in Unicode 5.0. Current line break iterator implementations are based on
newer versions of Unicode, which do not have that issue, so we can use them instead of the
hardcoded approximate rule.

LayoutTests:

  • fast/text/line-breaks-after-ideographic-comma-or-full-stop-2-expected.txt: Added.
  • fast/text/line-breaks-after-ideographic-comma-or-full-stop-2.html: Added.
13:35 Changeset [120623] by commit-queue@webkit.org

[TextureMapper] Rename shader variables to match the naming scheme of the newer filter shaders
https://bugs.webkit.org/show_bug.cgi?id=89324

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-18
Reviewed by Noam Rosenthal.

Rename shader variables to align them with those in the new filter shaders.

No new tests. This is just a simple refactor.

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

Rename shader variables so that uniforms are prefixed by "u_", attributes by "a_",
and texture samplers by "s_".

13:23 Changeset [120622] by tonikitoo@webkit.org

[BlackBerry] Overscroll can get reset while interacting with a page, due to style recalculations and scroll position clamping
https://bugs.webkit.org/show_bug.cgi?id=89371
PR #166982

Reviewed by Adam Treat.
Patch by Antonio Gomes <agomes@rim.com>

While scrolling, the WebKit thread gets intercalated WebPage::setScrollPosition
calls dispatched from the UI thread. These calls are wrapped with
ScrollableArea::setConstrainsScrollingToContentEdge(false|true) calls, which
can clamp the scroll position (removes overscroll) if set to 'true'.

The following situation can happen: user is scrolling, and WebKit
thread is not in the middle of a WebPage::setScrollPosition call
(so setConstrainsScrollingToContentEdge is 'true'), and a relayout happens.
In this scenario, the scroll position will get clamped to 0,0, removing any
possible overscrolling.

See the stack trace below, paying special attention to frame 16:

Patch fixes this issue by tying ScrollableArea::setConstrainsScrollingToContentEdge
to BackingStore::m_isZoomingOrScrolling, when we are sure clamping should not happen.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setScrollPosition):

13:17 Changeset [120621] by loislo@chromium.org

Web Inspector: Implement native memory bar diagram
https://bugs.webkit.org/show_bug.cgi?id=89106

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-18
Reviewed by Pavel Feldman.

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemoryBarChart):
(WebInspector.NativeMemoryBarChart.prototype._updateStats):
(WebInspector.NativeMemoryBarChart.prototype.willHide):
(WebInspector.NativeMemoryBarChart.prototype.wasShown):
(WebInspector.NativeMemoryBarChart.prototype._updateView):

  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView):

  • inspector/front-end/nativeMemoryProfiler.css:

(.memory-bar-chart-name):
(.memory-bar-chart-bar):
(.memory-bar-chart-size):
(.memory-bar-chart-total):

13:06 Changeset [120620] by dpranke@chromium.org

REGRESSION(r120546): It made 3 webkitpy tests fail
https://bugs.webkit.org/show_bug.cgi?id=89332

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-06-18
Reviewed by Adam Barth.

Update the BaselineOptimizer unittest after r120546.

  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_no_add_mac_future):
(BaselineOptimizerTest.test_mac_future):
(BaselineOptimizerTest.test_complex_shadowing):

12:59 Changeset [120619] by dpranke@chromium.org

new-run-webkit-tests output gets confused when logging
https://bugs.webkit.org/show_bug.cgi?id=63793

Reviewed by Adam Barth.

Ship all of the log messages generated in the worker back
to the manager; this allows the messages to be properly
serialized to stderr and for the meter to flush its output correctly.

Note however that this will likely result in messages to be
logged out of order between workers; I'm not sure that there's
an easy way to fix this short of buffering a potentially
unbounded amount of data. It might be better to just log through
stderr unless we're in 'metering' mode, but it's also worth
noting that we already get messages out of order through stderr
on Windows.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.handle_done):
(Manager.handle_finished_test):
(Manager._log_messages):

  • Scripts/webkitpy/layout_tests/controllers/worker.py:

(Worker.init):
(Worker._set_up_logging):
(Worker.run):
(Worker._run_test):
(Worker.cleanup):
(Worker.run_single_test):
(_WorkerLogHandler):
(_WorkerLogHandler.init):
(_WorkerLogHandler.emit):

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream.write):
(MeteredStream.writeln):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.writeln):

12:53 Changeset [120618] by loislo@chromium.org

Web Inspector: native memory snapshot performance and coverage test implementation.
https://bugs.webkit.org/show_bug.cgi?id=89363

We have to track the performance of MemoryAgent.getProcessMemoryDistribution.
Also this test will work as a burn down chart for Unknown memory metric.

Reviewed by Pavel Feldman.

  • inspector/native-memory-snapshot.html: Added.
  • inspector/performance-test.js:

(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.reportSize):
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):

12:51 Changeset [120617] by commit-queue@webkit.org

Crash in CSPSource::parseSource
https://bugs.webkit.org/show_bug.cgi?id=89353

Patch by Mike West <mkwst@chromium.org> on 2012-06-18
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/contentSecurityPolicy/source-list-parsing-malformed-meta.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPSourceList::parseSource):

Checking that we're not past the end of the string before deref.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/source-list-parsing-malformed-meta.html: Added.
12:30 Changeset [120616] by robert@webkit.org

CSS 2.1 failure: table-height-algorithm-012 fails
https://bugs.webkit.org/show_bug.cgi?id=85652

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: css2.1/20110323/table-height-algorithm-012.htm

fast/css/vertical-align-baseline-rowspan-001.htm
fast/css/vertical-align-baseline-rowspan-002.htm
fast/css/vertical-align-baseline-rowspan-003.htm
fast/css/vertical-align-baseline-rowspan-004.htm
fast/css/vertical-align-baseline-rowspan-005.htm
fast/css/vertical-align-baseline-rowspan-006.htm
fast/css/vertical-align-baseline-rowspan-007.htm
fast/css/vertical-align-baseline-rowspan-008.htm
fast/css/vertical-align-baseline-rowspan-009.htm

A spanning cell with Vertical-align set to 'baseline' should align the cell's content baseline
(which is the bottom of the first line of text or in-flow content) with the baseline of the first of the rows it spans.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight): Only calculate the baseline for the first row in a rowspan. This

ensures that any height added to the rowspan from the baseline is only added to the first row in the span rather than
to each of them.

(WebCore::RenderTableSection::layoutRows): Rather than get the baseline for each row in a rowspan (with the result that

only the baseline for the last row actually sticks), calculate it for the first row in the rowspan only. This function is
inefficient when handling rowspans so this doesn't fix the fact that redundant calculations are performed on each subsequent
row in the span - that should be done separately.

LayoutTests:

  • css2.1/20110323/table-height-algorithm-012-expected.html: Added.
  • css2.1/20110323/table-height-algorithm-012.htm: Added.
  • fast/css/vertical-align-baseline-rowspan-001-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-001.htm: Added.
  • fast/css/vertical-align-baseline-rowspan-002-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-002.htm: Added.
  • fast/css/vertical-align-baseline-rowspan-003-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-003.htm: Added.

These are a few variations on table-height-algorithm-012.htm

  • fast/css/vertical-align-baseline-rowspan-004-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-004.htm: Added.
  • fast/css/vertical-align-baseline-rowspan-005-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-005.htm: Added.
  • fast/css/vertical-align-baseline-rowspan-006-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-006.htm: Added.

These three test the calculation of the baseline RenderTableSection::calcRowLogicalHeight,
where we now always use the first row in the span. Without this the 'Filler Text' in the middle
cell aligns beyond the top of the table.

  • fast/css/vertical-align-baseline-rowspan-007-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-007.htm: Added.
  • fast/css/vertical-align-baseline-rowspan-008-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-008.htm: Added.
  • fast/css/vertical-align-baseline-rowspan-009-expected.html: Added.
  • fast/css/vertical-align-baseline-rowspan-009.htm: Added.

These make sure the alignment used in the first row of the span is correct when things like
the height of the cell and the height of the span are specified.

12:16 Changeset [120615] by hayato@chromium.org

Event dispatcher should use InsertionPoint::hasDistribution instead of InsertinPoint::isActive in re-targeting.
https://bugs.webkit.org/show_bug.cgi?id=89180

Reviewed by Dimitri Glazkov.

Source/WebCore:

If an event is fired on a fallback element within a insertion
point which does not select any nodes, the result of event's
re-targeting will be wrong since it uses
InsertionPoint::isActive() to judge an existence of a lower boundary.
That must use InsertionPoint::hasDistribution().

Test: fast/dom/shadow/shadow-dom-event-dispatching.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::ensureEventAncestors):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
12:02 Changeset [120614] by zandobersek@gmail.com

[garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
https://bugs.webkit.org/show_bug.cgi?id=89362

Reviewed by Simon Fraser.

Replace white spaces, braces and dots in the builder name with underscores. This
way the JQuery tabs will be properly matched with the according container.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
11:52 Changeset [120613] by abarth@webkit.org

Source/WebCore: [chromium] Add iccjpeg and qcms to chromium port

https://bugs.webkit.org/show_bug.cgi?id=81974

Reviewed by Adam Barth.

Covered by existing layout tests which will be rebaselined.

  • WebCore.gyp/WebCore.gyp: Add qcms to the build.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile. On OSX, return the default RGB profile. Add FIXME to use the user's monitor profile and verify that profile for other platforms.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the two known output color spaces for which the decoder uses a data swizzle. (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For libjpeg-turbo, alpha may be present in the swizzled output color space.

(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
to use during decoding, and ensure we switch to inputing RGBA data to qcms
even if the desired output data is BGRA: outputScanlines() sends BGRA data
to the frame buffer following color correction if needed.
(JPEGImageReader):
(WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
(WebCore::JPEGImageReader::createColorTransform): Create color transform.
Release the existing transform (if any) and assign to the color transform
created from the color profile data.
(WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
transform to each decoded image row.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other setters and getters. (WebCore::PNGImageReader::decodingSizeOnly): Ditto. (WebCore::PNGImageReader::setHasAlpha): Ditto. (WebCore::PNGImageReader::hasAlpha): Ditto. (WebCore::PNGImageReader::interlaceBuffer): Ditto. (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer, used when a color transform is applied to the decoded image pixels. (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer. (WebCore::PNGImageReader::colorTransform): qcms color transform getter. (WebCore::PNGImageReader::createColorTransform): Create color transform. Release the existing transform (if any) and assign to the color transform created from the color profile data. (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color transform to use for decoding. Clear m_colorProfile (not used anymore). (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if a color transform is needed for decoding. Apply color transform to each decoded image row.
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no longer used. Add a FIXME to remove the old implementation. (WebCore::ImageFrame::setStatus): Remove old color correction code.

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-18

Source/WTF: [chromium] Add iccjpeg and qcms to chromium port.
https://bugs.webkit.org/show_bug.cgi?id=81974

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-18

  • wtf/Platform.h: Add Chromium USE defines for ICCJPEG and QCMSLIB

to each Chromium platform, excluding Android.

Reviewed by Adam Barth.

11:45 Changeset [120612] by zandobersek@gmail.com

Unreviewed GTK gardening, updating baselines after r120596 and r120609.

  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-volume-slider-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
11:45 Changeset [120611] by dpranke@chromium.org

nrwt: metered output doesn't handle C cleanly
https://bugs.webkit.org/show_bug.cgi?id=89249

Reviewed by Tony Chang.

If you ctrl-c a running nrwt (w/o --verbose), then all but
two characters of the last update are erased, and then we print
"interrupted, exiting" as an update, which itself then gets
erased. Fix this so that we flush the meter (making the last
update persistent, so that we print the C for a visual clue),
print the interrupt message, and move on ...

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream.flush):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer._write):
(Printer):
(Printer.flush):

11:37 Changeset [120610] by ossy@webkit.org

[Qt] Unreviewed gardening, skip one more failing test to paint.

  • platform/qt/Skipped:
11:05 Changeset [120609] by mitz@apple.com

Column progression direction cannot be set independently of writing direction
https://bugs.webkit.org/show_bug.cgi?id=89315

Source/WebCore:

Added a column-progression property, which can have the values 'normal' and 'reverse'. When
set to 'reverse', the first column is positioned at the end side of the block, and
subsequent columns go from the in the start direction (in the inline column axis case; in
the block column axis case, the first column coincides with the block and subsequent columns
go before the block).

Reviewed by Darin Adler.

Test: fast/multicol/progression-reverse.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added handling of the new
property.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Added validity check for the new property. The valid
values are the identifiers 'normal' and 'reverse'.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added this mapping from ColumnProgression
enum values to the identifiers 'normal and 'reverse'.
(WebCore::CSSPrimitiveValue::operator ColumnProgression): Added this mapping from the
identifiers 'normal' and 'reverse' to ColumnProgression enum values.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): Added the new property to the set of
non-inherited properties.

  • css/CSSPropertyNames.in: Added -webkit-column-progression.
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder): Added a handler for the new property.

  • rendering/ColumnInfo.h:

(WebCore::ColumnInfo::ColumnInfo): Added an initializer for the m_progressionIsReversed
member variable.
(WebCore::ColumnInfo::progressionIsReversed): Added this accessor.
(WebCore::ColumnInfo::setProgressionIsReversed): Ditto.
(ColumnInfo): Added a m_progressionIsReversed member variable.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules): Changed to advance in the reverse direction if
needed.
(WebCore::RenderBlock::setDesiredColumnCountAndWidth): Added call to
ColumnInfo::setProgressionIsReversed(), based on the new property.
(WebCore::RenderBlock::columnRectAt): Changed to take the progression direction into
account.

  • rendering/style/RenderStyle.h: Added accessors and initial value for column progression.
  • rendering/style/RenderStyleConstants.h: Added ColumnProgression enum.
  • rendering/style/StyleMultiColData.cpp:

(WebCore::StyleMultiColData::StyleMultiColData): Added initializer for the m_progression
member variable.
(WebCore::StyleMultiColData::operator==): Added equality check for m_progression.

  • rendering/style/StyleMultiColData.h:

(StyleMultiColData): Added m_progression member variable.

LayoutTests:

Reviewed by Darin Adler.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/multicol/progression-reverse-expected.png: Added.
  • fast/multicol/progression-reverse-expected.txt: Added.
  • fast/multicol/progression-reverse.html: Added.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
10:51 JavaScriptCore edited by cornyn@gmail.com
Typo, 3rd paragraph - "JavaScriptCode" (diff)
10:23 Changeset [120608] by commit-queue@webkit.org

[TextureMapper] Replace the source transform with a flip uniform
https://bugs.webkit.org/show_bug.cgi?id=89317

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-18
Reviewed by Noam Rosenthal.

No new tests. This should not change any observable behavior.

  • platform/graphics/texmap/TextureMapperGL.cpp: Instead of building and passing

the m4src matrix to the shader, just pass a single uniform that says whether or
not the texture should be flipped.

  • platform/graphics/texmap/TextureMapperShaderManager.cpp: Change the shader programs

to deal with a flip variable rather than a source matrix.
(WebCore::TextureMapperShaderProgram::TextureMapperShaderProgram): Instead of getting the location
of the source matrix, get the location of the flip uniform.
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple): Ditto.
(WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple): Ditto.
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask): Ditto.
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::TextureMapperShaderProgramRectOpacityAndMask): Ditto.

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(WebCore::TextureMapperShaderProgram::flipLocation): Added this getter.
(TextureMapperShaderProgram): Rename the source matrix location member to reflect above changes.

10:17 Changeset [120607] by zandobersek@gmail.com

Unreviewed, rolling out r120598.
http://trac.webkit.org/changeset/120598
https://bugs.webkit.org/show_bug.cgi?id=89359

Patch causes crashes on EFL and GTK release builds (Requested
by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18

Source/WebCore:

  • platform/graphics/Pattern.h:

(Pattern):

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::prepareForFilling):

  • platform/graphics/cairo/PlatformContextCairo.h:

LayoutTests:

  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
10:15 Changeset [120606] by commit-queue@webkit.org

Unreviewed, rolling out r120592.
http://trac.webkit.org/changeset/120592
https://bugs.webkit.org/show_bug.cgi?id=89357

Broke v8 bindings on windows. (Requested by atwilson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18

  • bindings/js/JSJavaScriptCallFrameCustom.cpp:
  • bindings/js/ScriptDebugServer.cpp:
  • bindings/js/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/v8/DebuggerScript.js:

(.):

  • bindings/v8/JavaScriptCallFrame.cpp:
  • bindings/v8/JavaScriptCallFrame.h:

(JavaScriptCallFrame):

  • bindings/v8/ScriptDebugServer.cpp:
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
  • inspector/InjectedScript.cpp:
  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InjectedScriptSource.js:
  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setScriptSource):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/JavaScriptCallFrame.idl:
10:11 Changeset [120605] by jchaffraix@webkit.org

RenderTableSection wastes vector capacity
https://bugs.webkit.org/show_bug.cgi?id=86561

Reviewed by Antti Koivisto.

Memory optimization, covered by existing tests.

The issue is that addChild calls Vector::grow() which can over-allocate our row grid (especially
for small tables as we allocate at least 16 entries). As we don't know if addChild is called
in a loop (e.g. during parsing), we postpone the shrinkToFit call at layout time.

(WebCore::RenderTableSection::layout):
Added a shrinkToFit call with some explanation as to why it's good trade-off to do it now.

10:04 Changeset [120604] by commit-queue@webkit.org

[EFL] Rebaseline media tests after r120596
https://bugs.webkit.org/show_bug.cgi?id=89352

Unreviewed EFL gardening. Rebaseline a few media tests
due to r120596.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-18

  • platform/efl/fast/layers/video-layer-expected.txt:
  • platform/efl/media/audio-controls-rendering-expected.txt:
  • platform/efl/media/audio-repaint-expected.png:
  • platform/efl/media/audio-repaint-expected.txt:
  • platform/efl/media/controls-after-reload-expected.txt:
  • platform/efl/media/controls-strict-expected.txt:
  • platform/efl/media/controls-styling-expected.txt:
  • platform/efl/media/controls-without-preload-expected.txt:
  • platform/efl/media/media-controls-clone-expected.png:
  • platform/efl/media/media-controls-clone-expected.txt:
  • platform/efl/media/media-document-audio-repaint-expected.txt:
  • platform/efl/media/video-controls-rendering-expected.png:
  • platform/efl/media/video-controls-rendering-expected.txt:
  • platform/efl/media/video-display-toggle-expected.txt:
  • platform/efl/media/video-empty-source-expected.txt:
  • platform/efl/media/video-zoom-controls-expected.png:
  • platform/efl/media/video-zoom-controls-expected.txt:
09:55 Changeset [120603] by wangxianzhu@chromium.org

[Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
https://bugs.webkit.org/show_bug.cgi?id=89228

Reviewed by Tony Chang.

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/linux/WebFontRendering.h:

(WebKit):
(WebFontRendering):

  • public/linuxish/WebFontRendering.h: Removed.
  • src/linux/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp.

(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::setLCDOrder):
(WebKit::WebFontRendering::setLCDOrientation):

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:
  • DumpRenderTree/chromium/TestShellAndroid.cpp:
09:40 Changeset [120602] by commit-queue@webkit.org

webkit fails IETC border-radius-clip-002
https://bugs.webkit.org/show_bug.cgi?id=83205

Source/WebCore:

Added addRoundedRectClip instead of just clip when clipToBorderRadius
is true and bgLayer->clip() == ContentFillBox.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-18
Reviewed by Simon Fraser.

This change is covered by the existing test: ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.
However expected images should be updated. I updated chromium-linux
and chromium-mac's expected images and removed chromium-win,
chromium-mac-leopard and chromium-mac-snowleopard's expected images.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
As the code for "clipping to content boxes as necessary" doesn't
consider border-radius or not, added the code for checking
clipToBorderRadius or not, and if so, modified to use
getBackgroundRoundedRect for obtaining rounded rect and to use
addRoundedRectClip by using the obtained rounded rect.

LayoutTests:

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-18
Reviewed by Simon Fraser.

  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Removed.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Removed.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Removed.
09:33 Changeset [120601] by commit-queue@webkit.org

Source/WebCore: Allow updateFixedElementsAfterScrolling() to run during layout.
https://bugs.webkit.org/show_bug.cgi?id=84965

This is needed because HistoryController restores the previous scroll
position during layout (because we don't want an ugly flash of wrongly-
scrolled content).

Patch by Iain Merrick <husky@google.com> on 2012-06-18
Reviewed by Simon Fraser.

Test: compositing/fixed-position-scroll-offset-history-restore.html

  • page/FrameView.cpp:

(WebCore::FrameView::updateFixedElementsAfterScrolling):

LayoutTests: Allow updateFixedElementsAfterScrolling() to run during layout.
https://bugs.webkit.org/show_bug.cgi?id=84965

This is needed because HistoryController restores the previous scroll
position during layout (because we don't want an ugly flash of wrongly-
scrolled content).

Patch by Iain Merrick <husky@google.com> on 2012-06-18
Reviewed by Simon Fraser.

  • compositing/fixed-position-scroll-offset-history-restore-expected.txt: Added.
  • compositing/fixed-position-scroll-offset-history-restore.html: Added.
  • compositing/resources/fixed-position-scroll-offset-history-restore-2.html: Added.
  • platform/chromium-linux/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
09:04 Changeset [120600] by apavlov@chromium.org

CSSOM wrappers are not built for rules in the per-document and page group user stylesheets
https://bugs.webkit.org/show_bug.cgi?id=89221

Reviewed by Antti Koivisto.

Source/WebCore:

The issue manifested itself by not displaying injected page group stylesheet data in the Styles pane.

Test: inspector/styles/inject-stylesheet.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

  • inspector/styles/inject-stylesheet-expected.txt: Added.
  • inspector/styles/inject-stylesheet.html: Added.
  • inspector/styles/resources/inject-stylesheet-iframe-data.html: Added.
08:52 Changeset [120599] by ossy@webkit.org

[Qt] Unreviewed gardening, skip one more failing test. (Less test == less problem. :) )

  • platform/qt/Skipped:
08:41 Changeset [120598] by commit-queue@webkit.org

[cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html
https://bugs.webkit.org/show_bug.cgi?id=53085

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-18
Reviewed by Martin Robinson.

Source/WebCore:

Clipping previously unlimited vertical and horizontal pattern repeats with
a clip rectangle similar to the Qt Graphics Context.

No new tests, this patch fixes
canvas/philip/tests/2d.pattern.paint.repeat* tests.

  • platform/graphics/Pattern.h:

(WebCore::Pattern::getPatternSpaceTransform): Adding constant getter method to be able to map to pattern space externally, needed by PlatformContextCairo::clipForPatternFilling.

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::prepareForFilling):
(WebCore::PlatformContextCairo::clipForPatternFilling): Clip pattern repeats if needed.

  • platform/graphics/cairo/PlatformContextCairo.h:

LayoutTests:

canvas/philip/tests/2d.pattern.paint.repeat* tests now passing.

  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
08:06 Changeset [120597] by rjkroege@chromium.org

Touch events with default actions should be handled.
https://bugs.webkit.org/show_bug.cgi?id=89304.

Reviewed by Kent Tamura.

Covered by existing tests and tests in blocked bug
https://bugs.webkit.org/show_bug.cgi?id=88807

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent): Return true that the touch event
was handled for either preventDefault or defaultHandled.

08:04 Changeset [120596] by commit-queue@webkit.org

REGRESSION introduced in bug 88623: new shadowPseudoId elements need to get default styling.
https://bugs.webkit.org/show_bug.cgi?id=89280

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-18
Reviewed by Eric Carlson.

No new tests; existing tests found this bug.

  • css/html.css:

(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container):
Add -webkit-media-slider-container to the default styling.
(input[type="range"]::-webkit-slider-thumb, input[type="range"]::-webkit-media-slider-thumb):
Add -webkit-media-slider-thumb to the default styling.

07:45 Changeset [120595] by zandobersek@gmail.com

Unreviewed GTK gardening, remove duplicates from the GTK WK2
Skipped list that are already present in the generic WK2 Skipped
list or in GTK's TestExpectations.

  • platform/gtk-wk2/Skipped:
07:27 Changeset [120594] by abecsi@webkit.org

[Qt] Update QML plugins to Qt 5 style
https://bugs.webkit.org/show_bug.cgi?id=89027

Reviewed by Csaba Osztrogonác.

Since support for Qt 4 style plugins was removed from Qt 5
we need to update our plugins to the new style to be able
to build with a more recent Qt 5 hash.
Add empty plugin description json files for now.

  • declarative/experimental/plugin.cpp:
  • declarative/experimental/plugin.json: Added.
  • declarative/plugin.cpp:

(WebKitQmlPlugin):

  • declarative/plugin.json: Added.
07:10 Changeset [120593] by kinuko@chromium.org

Support File/DirectoryEntry access for <input type=file> if FileSystem API is enabled
https://bugs.webkit.org/show_bug.cgi?id=88293

Reviewed by Tony Chang.

Source/WebCore:

Proposal email on whatwg: http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033814.html
Proposal draft: http://wiki.whatwg.org/wiki/DragAndDropEntries

Test: fast/forms/file/input-file-entries.html

  • Modules/filesystem/HTMLInputElementFileSystem.cpp: Added.
  • Modules/filesystem/HTMLInputElementFileSystem.h: Added.
  • Modules/filesystem/HTMLInputElementFileSystem.idl: Added.
  • WebCore.gypi:
  • html/FileInputType.cpp:

(WebCore::FileInputType::receiveDroppedFiles): Retrieves dropped file
system Id if the given DragData has it.
(WebCore::FileInputType::droppedFileSystemId): Added. This returns
dropped file system Id retrieved in receiveDroppedFiles, or an empty
string if the platform does not support isolated file system for
dropped files.

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::droppedFileSystemId): Added.

  • html/HTMLInputElement.h:
  • html/InputType.cpp:

(WebCore::InputType::droppedFileSystemId): Added.

  • html/InputType.h:
  • platform/DragData.cpp:
  • platform/DragData.h:
  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::droppedFileSystemId): Added.

LayoutTests:

  • fast/forms/file/input-file-entries-expected.txt: Added.
  • fast/forms/file/input-file-entries.html: Added.
  • fast/forms/resources/dir1/UTF8-2.txt: Added.
  • fast/forms/resources/dir1/UTF8.txt: Added.
  • fast/forms/resources/dir2/green.jpg: Added.
  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
06:54 Changeset [120592] by commit-queue@webkit.org

Web Inspector: Support 'Restart frame' in protocol and backend
https://bugs.webkit.org/show_bug.cgi?id=89147

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-06-18
Reviewed by Yury Semikhatsky.

Inspector.json got new command in Debugger domain.
A call path from InspectorDebuggerAgent to V8 Debug.LiveEdit.RestartFrame API
is built.
JSC implementation is a stub with fix me (40300).

  • bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::restart):
(WebCore):

  • bindings/js/JavaScriptCallFrame.h:

(JavaScriptCallFrame):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore):
(WebCore::ScriptDebugServer::updateCallStack):

  • bindings/js/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/v8/DebuggerScript.js:

(.):

  • bindings/v8/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::restart):
(WebCore):

  • bindings/v8/JavaScriptCallFrame.h:

(JavaScriptCallFrame):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore):
(WebCore::ScriptDebugServer::updateCallStack):

  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::call):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::restartCallback):
(WebCore):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::restartFrame):
(WebCore):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::restartFrame):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/JavaScriptCallFrame.idl:
06:46 Changeset [120591] by commit-queue@webkit.org

Unreviewed, rolling out r120485 and r120582.
http://trac.webkit.org/changeset/120485
http://trac.webkit.org/changeset/120582
https://bugs.webkit.org/show_bug.cgi?id=89345

chromeos tree breakage (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • platform/image-decoders/ImageDecoder.h:

(ImageFrame):
(ImageDecoder):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(turboSwizzled):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::decode):
(JPEGImageReader):
(WebCore::JPEGImageDecoder::outputScanlines):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::currentBufferSize):
(PNGImageReader):
(WebCore::PNGImageReader::decodingSizeOnly):
(WebCore::PNGImageReader::interlaceBuffer):
(WebCore::PNGImageReader::hasAlpha):
(WebCore::PNGImageReader::setHasAlpha):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore):
(WebCore::resolveColorSpace):
(WebCore::createColorSpace):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):

Source/WTF:

  • wtf/Platform.h:

LayoutTests:

  • platform/chromium/TestExpectations:
05:53 Changeset [120590] by ossy@webkit.org

[Qt] Gardening after r120311. It made inspector/extensions/extensions-panel.html flakey.
https://bugs.webkit.org/show_bug.cgi?id=89333

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-06-18
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
04:49 Companies and Organizations that have contributed to WebKit edited by dominik.rottsches@intel.com
(diff)
04:40 Changeset [120589] by loislo@chromium.org

Web Inspector: Add heap profiler owned memory to the pie chart
https://bugs.webkit.org/show_bug.cgi?id=89203

Heap profiler may consume considerable amount of memory
which is currently falls into Unknown category.
Give it a separate sector on the pie chart.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-18
Reviewed by Yury Semikhatsky.

  • bindings/js/ScriptProfiler.h:

(WebCore::ScriptProfiler::profilerSnapshotsSize):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::profilerSnapshotsSize):
(WebCore):

  • bindings/v8/ScriptProfiler.h:

(ScriptProfiler):

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::inspectorData):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

04:13 Changeset [120588] by mario@webkit.org

[GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
https://bugs.webkit.org/show_bug.cgi?id=89226

Reviewed by Martin Robinson.

Source/WebCore:

Implement webkitAccessibleValueGetMinimumIncrement() properly,
doing something similar to what is done in AccessibilityObject's
increment() and decrement() functions.

Also, added missing bits to webkitAccessibleValueSetCurrentValue
to make sure we check the new value against range limits.

  • accessibility/gtk/WebKitAccessibleInterfaceValue.cpp:

(webkitAccessibleValueGetCurrentValue):
(webkitAccessibleValueGetMaximumValue):
(webkitAccessibleValueGetMinimumValue):
(webkitAccessibleValueSetCurrentValue):
(webkitAccessibleValueGetMinimumIncrement):

Source/WebKit/gtk:

Remove unnecesary functions incrementAccessibilityValue() and
decrementAccessibilityValue() from DumpRenderTreeSupportGtk.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Implement increment() and decrement() functions in term of the AtkValue interface,
instead of using DumpRenderTreeSupportGtk helper class.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):
(alterCurrentValue):
(AccessibilityUIElement::increment):
(AccessibilityUIElement::decrement):

04:11 Changeset [120587] by kinuko@chromium.org

fast/files/xhr-response-blob should use other file/blob type than javascript
https://bugs.webkit.org/show_bug.cgi?id=89338

Reviewed by Kentaro Hara.

Changing the test to use the most basic text/plain type.
Also removing platform-specific expectations.

  • fast/files/script-tests/xhr-response-blob.js: Updated.
  • fast/files/xhr-response-blob-expected.txt: Updated.
  • platform/chromium-linux/fast/files/xhr-response-blob-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/files/xhr-response-blob-expected.txt: Removed.
  • platform/chromium-mac/fast/files/xhr-response-blob-expected.txt: Removed.
  • platform/chromium/fast/files/xhr-response-blob-expected.txt: Removed.
  • platform/qt/fast/files/xhr-response-blob-expected.txt: Removed.
04:09 Changeset [120586] by hbono@chromium.org

[chromium] Spellchecker should show suggestions only when right-clicking a misspelled word.
https://bugs.webkit.org/show_bug.cgi?id=89331

Reviewed by Hajime Morita.

When a selection includes two or more misspelled words, it is not so easy to
select one word from them and to show its suggestions. To avoid this problem,
this change shows suggestions only when the selection is collapsed. For this
case, we can use Range::setStart and setEnd to convert a DocumentMarker to a
Range.

  • src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Added a check that the selection is collapsed.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::replaceMisspelledRange): Added a check that the selection is collapsed. Also, use Range::setStart() and Range::setEnd() to get the marker range to emulate the behavior of DocumentMarker::markersInRange().

03:56 Changeset [120585] by kinuko@chromium.org

[chromium] Cleanup: remove PlatformSupport::createAsyncFileSystem as it's no longer used
https://bugs.webkit.org/show_bug.cgi?id=89083

Reviewed by Kentaro Hara.

Source/WebCore:

No new tests as this has no functional changes.

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:
03:43 Changeset [120584] by ossy@webkit.org

Unreviewed gardening after r120574.

  • fast/files/xhr-response-blob-expected.txt:
  • platform/qt/fast/files/xhr-response-blob-expected.txt: Added.
03:30 Changeset [120583] by commit-queue@webkit.org

Fix syntax of FileReader::readAsDataURL result
https://bugs.webkit.org/show_bug.cgi?id=89330

When readAsDataURL generates data URL without media type, it used to omit semicolon before
"base64" keyword. But this semicolor is required in this case, according to RFC2397.

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-18
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/files/read-blob-async.html

fast/files/workers/worker-read-blob-async.html:
fast/files/workers/worker-read-blob-sync.html:

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::convertToDataURL):

LayoutTests:

  • fast/files/read-blob-async-expected.txt:
  • fast/files/workers/worker-read-blob-async-expected.txt:
  • fast/files/workers/worker-read-blob-sync-expected.txt:
  • platform/chromium/fast/files/read-blob-async-expected.txt:
  • platform/chromium/fast/files/workers/worker-read-blob-async-expected.txt:
  • platform/chromium/fast/files/workers/worker-read-blob-sync-expected.txt:
03:24 Changeset [120582] by morrita@google.com

Unreviewed chormium crash fix. This should be revisited.

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::qcmsOutputDeviceProfile):

03:03 Changeset [120581] by commit-queue@webkit.org

[EFL] fast/files/xhr-response-blob.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=89334

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-18
Reviewed by Kentaro Hara.

Source/WebCore:

Call wrap() instead of createWrapper() in JSBlob's toJS()
to avoid hitting the !getCachedWrapper ASSERT in
createWrapper() because we fail to use the cached wrapper.

Test: fast/files/xhr-response-blob.html

  • bindings/js/JSBlobCustom.cpp:

(WebCore::toJS):

LayoutTests:

Unskip fast/files/xhr-response-blob.html now that it
no longer crashes.

  • platform/efl/TestExpectations:
  • platform/efl/fast/files/xhr-response-blob-expected.txt: Added.
02:31 Changeset [120580] by hans@chromium.org

[Chromium] fast/events/constructors/speech-recognition-event-constructor.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88856

Reviewed by Adam Barth.

This fixes and re-enables the layout test that I forgot to update in r120053.

  • fast/events/constructors/speech-recognition-event-constructor-expected.txt:
  • fast/events/constructors/speech-recognition-event-constructor.html:
  • platform/chromium/TestExpectations:
02:07 Changeset [120579] by loislo@chromium.org

Web Inspector: rename Unknown to Other in Native heap snapshot.
https://bugs.webkit.org/show_bug.cgi?id=89306

Cosmetic change.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.MemoryBlockViewProperties._initialize):

01:24 Changeset [120578] by commit-queue@webkit.org

[EFL] skip fast/files/xhr-response-blob.html
https://bugs.webkit.org/show_bug.cgi?id=89335

Unreviewed EFL gardening. Skip fast/files/xhr-response-blob.html
because it is crashing.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-18

  • platform/efl/TestExpectations:
01:12 Changeset [120577] by sergio@webkit.org

TextureMapperLayer: invisible layers do not let their children to be painted
https://bugs.webkit.org/show_bug.cgi?id=88786

Reviewed by Noam Rosenthal.

Do not early discard recursively painting children layers if the
current layer is not visible.

Changes already covered by compositing tests. This fixes both
compositing/backface-visibility/backface-visibility-3d.html and
compositing/backface-visibility/backface-visibility-non3d.html.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::isVisible):

00:25 Changeset [120576] by commit-queue@webkit.org

[EFL] Rebaseline needed after r117339
https://bugs.webkit.org/show_bug.cgi?id=89328

Unreviewed EFL gardening. Rebaseline a few tests after r117339.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-18

  • platform/efl/TestExpectations:
  • platform/efl/editing/pasteboard/innerText-inline-table-expected.png: Added.
  • platform/efl/editing/pasteboard/innerText-inline-table-expected.txt: Added.
  • platform/efl/editing/selection/iframe-expected.png: Added.
  • platform/efl/editing/selection/iframe-expected.txt: Added.
  • platform/efl/editing/selection/inline-table-expected.png: Added.
  • platform/efl/editing/selection/inline-table-expected.txt: Added.
  • platform/efl/editing/selection/table-caret-3-expected.png: Added.
  • platform/efl/editing/selection/table-caret-3-expected.txt: Added.
  • platform/efl/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/efl/tables/mozilla/bugs/bug2479-2-expected.txt:
00:12 Changeset [120575] by commit-queue@webkit.org

[EFL] Rebaseline needed after r120477
https://bugs.webkit.org/show_bug.cgi?id=89325

Unreviewed EFL gardening. Rebaseline a few tests after r120477.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-18

  • platform/efl/TestExpectations:
  • platform/efl/editing/deleting/delete-3800834-fix-expected.png: Added.
  • platform/efl/editing/deleting/delete-3800834-fix-expected.txt: Added.
  • platform/efl/fast/dynamic/011-expected.png:
  • platform/efl/fast/dynamic/011-expected.txt:
  • platform/efl/fast/forms/formmove3-expected.png:
  • platform/efl/fast/forms/formmove3-expected.txt:
  • platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.png:
  • platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/efl/fast/invalid/001-expected.png:
  • platform/efl/fast/invalid/001-expected.txt:
  • platform/efl/fast/invalid/003-expected.png:
  • platform/efl/fast/invalid/003-expected.txt:
  • platform/efl/fast/invalid/004-expected.png:
  • platform/efl/fast/invalid/004-expected.txt:
  • platform/efl/fast/invalid/007-expected.png:
  • platform/efl/fast/invalid/007-expected.txt:
  • platform/efl/fast/invalid/019-expected.png:
  • platform/efl/fast/invalid/019-expected.txt:
  • platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/efl/tables/mozilla/bugs/bug647-expected.png:
  • platform/efl/tables/mozilla/bugs/bug647-expected.txt:
  • platform/efl/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/efl/tables/mozilla/other/wa_table_tr_align-expected.txt:
00:06 Changeset [120574] by kinuko@chromium.org

XHR_RESPONSE_BLOB is not enabled on some platforms
https://bugs.webkit.org/show_bug.cgi?id=88859

Reviewed by Adam Barth.

Source/WebCore:

Removing XHR_RESPONSE_BLOB since the current implementation has
no platform-specific part.

Test: http/tests/xmlhttprequest/blob-response-size.html

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitChildren):
(WebCore::JSXMLHttpRequest::response):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseBlob):
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::clearResponseBuffers):
(WebCore::XMLHttpRequest::didReceiveData):

  • xml/XMLHttpRequest.h:

(XMLHttpRequest):

  • xml/XMLHttpRequest.idl:

Source/WebKit/chromium:

Removing XHR_RESPONSE_BLOB since the current implementation has
no platform-specific part.

  • src/PlatformSupport.cpp:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableXHRResponseBlob):
(WebKit::WebRuntimeFeatures::isXHRResponseBlobEnabled):

LayoutTests:

Removing xhr.Blob related test from Skipped files.

  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:

06/17/12:

23:43 Changeset [120573] by commit-queue@webkit.org

[EFL] Add EFL baseline for fast/parser/nested-fragment-parser-crash.html
https://bugs.webkit.org/show_bug.cgi?id=89329

Unreviewed EFL gardening. Use the same expectation for
fast/parser/nested-fragment-parser-crash.html as mac.
The test is passing since it does not crash.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-17

  • platform/efl/TestExpectations:
  • platform/efl/fast/parser/nested-fragment-parser-crash-expected.txt: Added.
23:36 Changeset [120572] by commit-queue@webkit.org

[TextureMapper] Reduce boilerplate code in the TextureMapperShaderManager
https://bugs.webkit.org/show_bug.cgi?id=89293

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-17
Reviewed by Noam Rosenthal.

Refactor TextureMapperShaderManager to reduce boilerplate code, by:

  1. Making fragment and shader source arguments to the superclass constructor.
  2. Removing virtual methods (which should not be called in constructors) with constructor implementations. This exchanges a small amount of code duplication for a lot less boilerplate.
  3. Standardizing on the fooLocation name instead of fooVariable.
  4. Removing the ::prepare() series of methods for non-filter shaders. It's betters to have all the uniform and attribute binding in the same place.

No new tests. This is just a refactor and shouldn't change any functionality.

  • platform/graphics/texmap/TextureMapperGL.cpp:

Handle binding the mask texture and opacity at both of the previous ::prepare callsites. Also
rename "shaderInfo" to "program".

  • platform/graphics/texmap/TextureMapperShaderManager.cpp: Perform the refactoring described above.
  • platform/graphics/texmap/TextureMapperShaderManager.h: Ditto.
23:32 Changeset [120571] by commit-queue@webkit.org

Fix Framebuffer restrictions
https://bugs.webkit.org/show_bug.cgi?id=89320

Patch by Gregg Tavares <gman@google.com> on 2012-06-17
Reviewed by Kenneth Russell.

No new tests, just fixing old ones

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::checkStatus):

22:34 UsingGitWithWebKit edited by yosin@chromium.org
Add "Copying file aka svn copy" section (diff)
21:57 Changeset [120570] by morrita@google.com

Unreviewed, marking some tests as failures..

  • platform/chromium/TestExpectations:
21:57 Changeset [120569] by yosin@chromium.org

[Forms] Move search field related code to RenderSearchField from RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=88980

Reviewed by Kent Tamura.

This patch moves search field related methods in RenderTextControlSingleLine
to new class RenderSearchField and changes related classes to use
RenderSearchField.

No new tests. This patch doesn't change behavior.

  • CMakeLists.txt: Added new file RenderSearchField.cpp
  • GNUmakefile.list.am: Added new file RenderSearchField.cpp and RenderSearchField.h
  • Target.pri: ditto
  • WebCore.gypi: ditto
  • WebCore.vcproj/WebCore.vcproj: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::subtreeHasChanged): Call RenderSearchField::updateCancelButtonVisibility
(WebCore::HTMLInputElement::addSearchResult): Changed to call InputType::addSearchResult.

  • html/InputType.cpp:

(WebCore::InputType::addSearchResult): Added.

  • html/InputType.h:
  • html/SearchInputType.cpp:

(WebCore::SearchInputType::addSearchResult): Moved from HTMLInputElement.
(WebCore::SearchInputType::createRenderer): Added to create RenderSearchField.
(WebCore::SearchInputType::searchEventsShouldBeDispatched): Moved from HTMLInputElement.
(WebCore::SearchInputType::subtreeHasChanged) Moved search related code from HTMLInputElement.

  • html/SearchInputType.h:
  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::defaultEventHandler): Use RenderSearchField instead of RenderTextControlSingleLine.

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create): Got rid isSearchField() guard for addSearchResult().

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::RenderSearchField): Renamed to RenderSearchField.
(WebCore::RenderSearchField::~RenderSearchField): ditto
(WebCore::RenderSearchField::resultsButtonElement): ditto
(WebCore::RenderSearchField::cancelButtonElement): ditto
(WebCore::RenderSearchField::addSearchResult): ditto
(WebCore::RenderSearchField::showPopup): ditto
(WebCore::RenderSearchField::hidePopup): ditto
(WebCore::RenderSearchField::computeControlHeight): Added.
(WebCore::RenderSearchField::updateFromElement): Moved search field related code from RenderTextControlSingleLine.
(WebCore::RenderSearchField::updateCancelButtonVisibility): Renamed to RenderSearchField.
(WebCore::RenderSearchField::visibilityForCancelButton): ditto
(WebCore::RenderSearchField::autosaveName): ditto
(WebCore::RenderSearchField::valueChanged): ditto
(WebCore::RenderSearchField::itemText): ditto
(WebCore::RenderSearchField::itemLabel): ditto
(WebCore::RenderSearchField::itemIcon): ditto
(WebCore::RenderSearchField::itemIsEnabled): ditto
(WebCore::RenderSearchField::itemStyle): ditto
(WebCore::RenderSearchField::menuStyle): ditto
(WebCore::RenderSearchField::clientInsetLeft): ditto
(WebCore::RenderSearchField::clientInsetRight): ditto
(WebCore::RenderSearchField::clientPaddingLeft): ditto
(WebCore::RenderSearchField::clientPaddingRight): ditto
(WebCore::RenderSearchField::listSize): ditto
(WebCore::RenderSearchField::selectedIndex): ditto
(WebCore::RenderSearchField::popupDidHide): ditto
(WebCore::RenderSearchField::itemIsSeparator): ditto
(WebCore::RenderSearchField::itemIsLabel): ditto
(WebCore::RenderSearchField::itemIsSelected): ditto
(WebCore::RenderSearchField::setTextFromItem): ditto
(WebCore::RenderSearchField::fontSelector): ditto
(WebCore::RenderSearchField::hostWindow): ditto
(WebCore::RenderSearchField::createScrollbar): ditto
(WebCore::RenderSearchField::computeHeightLimit): Added.
(WebCore::RenderSearchField::centerContainerIfNeeded): Added.

  • rendering/RenderSearchField.h:

(WebCore::toRenderSearchField): Added.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Remove search field related code.
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): ditto.
(WebCore::RenderTextControlSingleLine::computeHeightLimit): Added.
(WebCore::RenderTextControlSingleLine::layout): Use new methods for removing isSearchField.
(WebCore::RenderTextControlSingleLine::computeControlHeight): Added.
(WebCore::RenderTextControlSingleLine::updateFromElement): Remove search field related code.

  • rendering/RenderTextControlSingleLine.h:

(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::centerContainerIfNeeded): Added.
(WebCore::RenderTextControlSingleLine::containerElement): Exposed for RenderSearchField.
(WebCore::RenderTextControlSingleLine::innerBlockElement): Exposed for RenderSearchField.

  • rendering/RenderingAllInOne.cpp: Added RenderSearchField.cpp
21:35 Changeset [120568] by ggaren@apple.com

GC copy phase spends needless cycles zero-filling blocks
https://bugs.webkit.org/show_bug.cgi?id=89128

Reviewed by Gavin Barraclough.

We only need to zero-fill when we're allocating memory that might not
get fully initialized before GC.

  • heap/CopiedBlock.h:

(JSC::CopiedBlock::createNoZeroFill):
(JSC::CopiedBlock::create): Added a way to create without zero-filling.
This is our optimization.

(JSC::CopiedBlock::zeroFillToEnd):
(JSC::CopiedBlock::CopiedBlock): Split zero-filling out from creation,
so we can sometimes create without zero-filling.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::init):
(JSC::CopiedSpace::tryAllocateSlowCase):
(JSC::CopiedSpace::doneCopying): Renamed addNewBlock to allocateBlock()
to clarify that the new block is always newly-allocated.

(JSC::CopiedSpace::doneFillingBlock): Make sure to zero-fill to the end
of a block that might be used in the future for allocation. (Most of the
time, this is a no-op, since we've already filled the block completely.)

(JSC::CopiedSpace::getFreshBlock): Removed this function because the
abstraction of "allocation must succeed" is no longer useful.

  • heap/CopiedSpace.h: Updated declarations to match.
  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::allocateBlockForCopyingPhase): New function, which
knows that it can skip zero-filling.

Added tighter scoping to our lock, to improve parallelism.

(JSC::CopiedSpace::allocateBlock): Folded getFreshBlock functionality
into this function, for simplicity.

  • heap/MarkStack.cpp:

(JSC::SlotVisitor::startCopying):
(JSC::SlotVisitor::allocateNewSpace): Use our new zero-fill-free helper
function for great good.

21:18 Changeset [120567] by yosin@chromium.org

[Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=89155

This patch copies RenderTextControlSingleLine.cpp and .h into RenderSearchField.cpp
and .h with just "cp" code. New files aren't compiled until bug 88980.

No new tests. This patch doesn't change behavior.

  • rendering/RenderSearchField.cpp: Added. (WebCore): (WebCore::RenderTextControlInnerBlock::positionForPoint): (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::containerElement): (WebCore::RenderTextControlSingleLine::innerBlockElement): (WebCore::RenderTextControlSingleLine::innerSpinButtonElement): (WebCore::RenderTextControlSingleLine::resultsButtonElement): (WebCore::RenderTextControlSingleLine::cancelButtonElement): (WebCore::RenderTextControlSingleLine::textBaseStyle): (WebCore::RenderTextControlSingleLine::addSearchResult): (WebCore::RenderTextControlSingleLine::showPopup): (WebCore::RenderTextControlSingleLine::hidePopup): (WebCore::RenderTextControlSingleLine::paint): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::controlClipRect): (WebCore::RenderTextControlSingleLine::getAvgCharWidth): (WebCore::RenderTextControlSingleLine::preferredContentWidth): (WebCore::RenderTextControlSingleLine::computeControlHeight): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::createInnerBlockStyle): (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): (WebCore::RenderTextControlSingleLine::visibilityForCancelButton): (WebCore::RenderTextControlSingleLine::textShouldBeTruncated): (WebCore::RenderTextControlSingleLine::autosaveName): (WebCore::RenderTextControlSingleLine::valueChanged): (WebCore::RenderTextControlSingleLine::itemText): (WebCore::RenderTextControlSingleLine::itemLabel): (WebCore::RenderTextControlSingleLine::itemIcon): (WebCore::RenderTextControlSingleLine::itemIsEnabled): (WebCore::RenderTextControlSingleLine::itemStyle): (WebCore::RenderTextControlSingleLine::menuStyle): (WebCore::RenderTextControlSingleLine::clientInsetLeft): (WebCore::RenderTextControlSingleLine::clientInsetRight): (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight): (WebCore::RenderTextControlSingleLine::listSize): (WebCore::RenderTextControlSingleLine::selectedIndex): (WebCore::RenderTextControlSingleLine::popupDidHide): (WebCore::RenderTextControlSingleLine::itemIsSeparator): (WebCore::RenderTextControlSingleLine::itemIsLabel): (WebCore::RenderTextControlSingleLine::itemIsSelected): (WebCore::RenderTextControlSingleLine::setTextFromItem): (WebCore::RenderTextControlSingleLine::fontSelector): (WebCore::RenderTextControlSingleLine::hostWindow): (WebCore::RenderTextControlSingleLine::autoscroll): (WebCore::RenderTextControlSingleLine::scrollWidth): (WebCore::RenderTextControlSingleLine::scrollHeight): (WebCore::RenderTextControlSingleLine::scrollLeft): (WebCore::RenderTextControlSingleLine::scrollTop): (WebCore::RenderTextControlSingleLine::setScrollLeft): (WebCore::RenderTextControlSingleLine::setScrollTop): (WebCore::RenderTextControlSingleLine::scroll): (WebCore::RenderTextControlSingleLine::logicalScroll): (WebCore::RenderTextControlSingleLine::createScrollbar): (WebCore::RenderTextControlSingleLine::inputElement):
  • rendering/RenderSearchField.h: Added. (WebCore): (RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::popupIsVisible): (WebCore::RenderTextControlSingleLine::isTextField): (WebCore::toRenderTextControlSingleLine): (RenderTextControlInnerBlock): (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
21:11 Changeset [120566] by yosin@chromium.org

Unreviewed, rolling out r120565.
http://trac.webkit.org/changeset/120565
https://bugs.webkit.org/show_bug.cgi?id=89155

Bad commit message

  • rendering/RenderSearchField.cpp: Removed.
  • rendering/RenderSearchField.h: Removed.
21:08 Changeset [120565] by yosin@chromium.org

Try 1

19:43 Changeset [120564] by morrita@google.com

Unreviewed build fix.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
19:42 Changeset [120563] by philn@webkit.org

[GStreamer] optimize ::naturalSize()
https://bugs.webkit.org/show_bug.cgi?id=89314

Reviewed by Martin Robinson.

Keep track of the video-sink sinkpad in the MediaPlayerPrivate and
adapt the webkitGstGetPadCaps API accordingly. The benefit of this
change is to reduce the number of calls to
gst_element_get_static_pad() and the corresponding gst_pad_unref().

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(webkitGstGetPadCaps):

  • platform/graphics/gstreamer/GStreamerVersioning.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::naturalSize):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

19:35 Changeset [120562] by philn@webkit.org

Unreviewed, GTK 64-bit build fix after r120551.

  • Source/autotools/symbols.filter:
19:28 Changeset [120561] by commit-queue@webkit.org

Don't mark main frame layer opaque if the frame view is transparent
https://bugs.webkit.org/show_bug.cgi?id=88234

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-06-17
Reviewed by Simon Fraser.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):

19:22 Changeset [120560] by jchaffraix@webkit.org

colspan in table-layout:fixed does not add up widths properly
https://bugs.webkit.org/show_bug.cgi?id=20213

Reviewed by Abhishek Arya.

The bug has been fixed (likely by bug 14858) so landing the test case as fixed table layout with cell spanning several
<col>'s with fixed widths is not properly covered.

  • fast/table/fixed-table-layout/fixed-layout-column-colspan-wrong-size-expected.txt: Added.
  • fast/table/fixed-table-layout/fixed-layout-column-colspan-wrong-size.html: Added.
19:12 Changeset [120559] by pdr@google.com

Prevent crash in SVGDocumentExtensions::removeAllElementReferencesForTarget.
https://bugs.webkit.org/show_bug.cgi?id=88144

Reviewed by Abhishek Arya.

Source/WebCore:

When iterating over referencing elements to rebuild after a reference change in
SVGDocumentExtensions::removeAllElementReferencesForTarget, we can
modify the underlying toBeNotified vector, invalidating it. This change checks
that a vector element is valid before rebuilding, preventing a crash.

Some definitions from SVGDocumentExtensions that may put this patch in context:

An example of a "referenced elements" is a <path>.
An example of a "referencing element" is a <textPath href='some_path_id'>.
m_elementDependencies is a map from referenced elements (e.g., paths) to
a set of referencing elements (e.g., textPaths).

The check that the vector element is valid relies on checking if the referencing
element is in m_elementDependencies. This check is allowed because in the
destructor of SVGTextPathElement (and SVGFeImageElement),
removeAllTargetReferencesForElement() is called, removing the referencing element
from m_elementDependencies.

Simply checking if the referencing element is anywhere in m_elementDependencies
is enough to show it is valid, but that requires iterating over all referenced
elements to see if the given referencing element is present. This change
only checks if the textPath is still in the elements referencing the
path being removed, and only removes the referenced element from
m_elementDependencies after forcing the referencing elements to be rebuilt.

Test: svg/text/textpath-reference-crash.html

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget):

LayoutTests:

  • svg/text/textpath-reference-crash-expected.txt: Added.
  • svg/text/textpath-reference-crash.html: Added.
19:09 Changeset [120558] by yosin@chromium.org

Unreviewed, rolling out r120390.
http://trac.webkit.org/changeset/120390
https://bugs.webkit.org/show_bug.cgi?id=89155

Failed to copy merge history to RenderSerachField.{cpp,h}

  • rendering/RenderSearchField.cpp: Removed.
  • rendering/RenderSearchField.h: Removed.
19:06 Changeset [120557] by yosin@chromium.org

Unreviewed, rolling out r120432.
http://trac.webkit.org/changeset/120432
https://bugs.webkit.org/show_bug.cgi?id=88980

Failed to copy merge history to RenderSerachField.{cpp,h}

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::subtreeHasChanged):
(WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
(WebCore):
(WebCore::HTMLInputElement::addSearchResult):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:
  • html/InputType.h:

(InputType):

  • html/SearchInputType.cpp:
  • html/SearchInputType.h:

(SearchInputType):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • rendering/RenderSearchField.cpp:

(WebCore::RenderTextControlInnerBlock::positionForPoint):
(WebCore):
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::containerElement):
(WebCore::RenderTextControlSingleLine::innerBlockElement):
(WebCore::RenderTextControlSingleLine::innerSpinButtonElement):
(WebCore::RenderTextControlSingleLine::resultsButtonElement):
(WebCore::RenderTextControlSingleLine::cancelButtonElement):
(WebCore::RenderTextControlSingleLine::textBaseStyle):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::paint):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::styleDidChange):
(WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
(WebCore::RenderTextControlSingleLine::hasControlClip):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::getAvgCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::computeControlHeight):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
(WebCore::RenderTextControlSingleLine::autosaveName):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::itemText):
(WebCore::RenderTextControlSingleLine::itemLabel):
(WebCore::RenderTextControlSingleLine::itemIcon):
(WebCore::RenderTextControlSingleLine::itemIsEnabled):
(WebCore::RenderTextControlSingleLine::itemStyle):
(WebCore::RenderTextControlSingleLine::menuStyle):
(WebCore::RenderTextControlSingleLine::clientInsetLeft):
(WebCore::RenderTextControlSingleLine::clientInsetRight):
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
(WebCore::RenderTextControlSingleLine::listSize):
(WebCore::RenderTextControlSingleLine::selectedIndex):
(WebCore::RenderTextControlSingleLine::popupDidHide):
(WebCore::RenderTextControlSingleLine::itemIsSeparator):
(WebCore::RenderTextControlSingleLine::itemIsLabel):
(WebCore::RenderTextControlSingleLine::itemIsSelected):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::fontSelector):
(WebCore::RenderTextControlSingleLine::hostWindow):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):
(WebCore::RenderTextControlSingleLine::createScrollbar):
(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderSearchField.h:

(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::isTextField):
(WebCore::toRenderTextControlSingleLine):
(WebCore):
(RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore):
(WebCore::RenderTextControlSingleLine::containerElement):
(WebCore::RenderTextControlSingleLine::innerBlockElement):
(WebCore::RenderTextControlSingleLine::resultsButtonElement):
(WebCore::RenderTextControlSingleLine::cancelButtonElement):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::computeControlHeight):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::autosaveName):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::itemText):
(WebCore::RenderTextControlSingleLine::itemLabel):
(WebCore::RenderTextControlSingleLine::itemIcon):
(WebCore::RenderTextControlSingleLine::itemIsEnabled):
(WebCore::RenderTextControlSingleLine::itemStyle):
(WebCore::RenderTextControlSingleLine::menuStyle):
(WebCore::RenderTextControlSingleLine::clientInsetLeft):
(WebCore::RenderTextControlSingleLine::clientInsetRight):
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
(WebCore::RenderTextControlSingleLine::listSize):
(WebCore::RenderTextControlSingleLine::selectedIndex):
(WebCore::RenderTextControlSingleLine::popupDidHide):
(WebCore::RenderTextControlSingleLine::itemIsSeparator):
(WebCore::RenderTextControlSingleLine::itemIsLabel):
(WebCore::RenderTextControlSingleLine::itemIsSelected):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::fontSelector):
(WebCore::RenderTextControlSingleLine::hostWindow):
(WebCore::RenderTextControlSingleLine::createScrollbar):

  • rendering/RenderTextControlSingleLine.h:

(WebCore):
(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::popupIsVisible):

  • rendering/RenderingAllInOne.cpp:
18:59 Changeset [120556] by fpizlo@apple.com

DFG should attempt to use structure watchpoints for all inlined get_by_id's and put_by_id's
https://bugs.webkit.org/show_bug.cgi?id=89316

Reviewed by Oliver Hunt.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addStructureTransitionCheck):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

17:20 Changeset [120555] by simon.fraser@apple.com

garden-o-matic 'Results' panel is broken for the Apple platform
https://bugs.webkit.org/show_bug.cgi?id=89310

Reviewed by Adam Barth.

For platforms that don't use accumulated build directories on the server,
carry along buildLocation data with buildInfo, so that we know where to
look for the test results files for a given test.

Renamed historicalResultsSummaryURLs to historicalResultsLocations because
it now returns an array of objects with buildNumber, revision and url info.

Fixed results.fetchResultsURLs() to use this data to find results.

Fixed the results display to not scroll when you click on a test to see the results.
Made the h3s look less ugly

Don't try to show the flakiness dashboard for the Apple platform.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

(.results-view .top-panel):
(.results-view h3):

16:06 Changeset [120554] by darin@apple.com

REGRESSION (r111041): Missing element type check in RenderThemeMac::paintMediaFullscreenButton
https://bugs.webkit.org/show_bug.cgi?id=89270

Reviewed by Oliver Hunt.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaFullscreenButton): Use the proper idiom for getting
a media control element's type.

14:19 Changeset [120553] by commit-queue@webkit.org

[Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged
https://bugs.webkit.org/show_bug.cgi?id=88482

Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-17
Reviewed by Adrienne Walker.

Source/WebCore:

Post-processing CCRenderPassList after it's been generated and
removing all render surface quads for which there are
cached textures, and whose content didn't change. Added a new
flag to CCLayerImpl to differentiate surface property change and
layer property change.

The changes are covered by new unit tests that check that
the removal algorithm functions propertly. No rendering
behaviour change, so no new layout tests.

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::layerNeedsToRedrawOntoItsTargetSurface):
(WebCore):
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::layerSurfacePropertyChanged):
(WebCore):
(WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setTransform):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::removeRenderPassesRecursive):
(WebCore):
(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(FrameData):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::hasCachedContentsTexture):
(WebCore):
(WebCore::CCRenderSurface::contentsChanged):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

Added tests to verify quad removal algorithm. Added infrastructure
code to generate custom render passes out of a script encoded as C
string.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerImplTest.cpp:

(WebCore):
(WebCore::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:
14:06 Changeset [120552] by paroga@webkit.org

[WIN] Simplify implementation of currentTime()
https://bugs.webkit.org/show_bug.cgi?id=83156

Reviewed by Brent Fulgham.

Use GetSystemTimeAsFileTime() instead of ftime().
This avoids an unneeded call to the MS CRT and
brings the Win/WinCE code closer together.

  • wtf/CurrentTime.cpp:

(WTF::lowResUTCTime):
(WTF::currentTime):

11:36 Changeset [120551] by philn@webkit.org

Unreviewed, GTK build fix after r120397.

  • Source/autotools/symbols.filter:
04:15 Changeset [120550] by zandobersek@gmail.com

Unreviewed GTK gardening, updating baselines after r120541.

  • platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
  • platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
  • platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
  • platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:
03:16 Changeset [120549] by commit-queue@webkit.org

[EFL] Skip media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=89302

Unreviewed EFL gardening. Skip flaky test.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-17

  • platform/efl/TestExpectations:
01:34 Changeset [120548] by abarth@webkit.org

Attempt to fix a large number of tests I broke with http://trac.webkit.org/changeset/120547

We need to reset the device scale facter after each test.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):

  • testing/InternalSettings.h:

(InternalSettings):

00:01 Changeset [120547] by abarth@webkit.org

Update a few more tests to use internals.settings.setDeviceScaleFactor.

  • compositing/tiled-layers-hidpi.html:
  • fast/canvas/2d.backingStorePixelRatio.html:
  • fast/canvas/2d.imageDataHD.html:
  • platform/mac-wk2/plugins/contents-scale-factor.html:

06/16/12:

21:53 Changeset [120546] by simon.fraser@apple.com

Make garden-o-matic work for the Apple Mac port
https://bugs.webkit.org/show_bug.cgi?id=84642

Reviewed by Adam Barth.

Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
educating the scripts in various ways:

  • Wrap up platform-related differences in config.kPlatforms[]
  • Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
  • The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do, so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most recent build with valid results.
  • The webkit.org bots often generate results directories with no layout test data (e.g. when testers try to test a build that has already been deleted). Make walkHistory() more robust here.
  • webkit.org uses differently named test result directories, that include the SVN revision as well as the build number. That forces us to fetch more build info before we can get the result directory URL.
  • chromium.org serves raw directory listings for a builder's results directories. webkit.org serves those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results dirs.
  • Various URLs differ between webkit.org and chromium.org
  • Better UI for the failures info, so that some info is visible even when not hovered.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:

(LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:

(ol.notifications>li table.failures):
(ol.notifications>li:hover table.failures):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:

(#onebar #platform-picker):

  • Scripts/webkitpy/layout_tests/port/builders.py:
21:42 Changeset [120545] by commit-queue@webkit.org

[Texmap] Share gaussian formula between shaders in TextureMapperShaderManager.
https://bugs.webkit.org/show_bug.cgi?id=89277

This patch makes blur and drop shadow shader share gaussian formula.

On the other hand, blur and drop shadow filter computed a gaussian weight in
pixel shader. However, a gaussian kernal has always same values, so this patch
computes the gaussian kernel only one time using CPU.
It is more accurate and faster.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-16
Reviewed by Noam Rosenthal.

Covered by existing tests, particularly css3/filters/.

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore):
(WebCore::StandardFilterProgram::StandardFilterProgram):
(WebCore::gauss):
(WebCore::gaussianKernel):
(WebCore::StandardFilterProgram::prepare):

  • platform/graphics/texmap/TextureMapperShaderManager.h:
20:55 Changeset [120544] by rjkroege@chromium.org

[chromium] Make the deviceScaleFactor dynamically adjustable.
https://bugs.webkit.org/show_bug.cgi?id=88916

Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebLayerTreeView.h: Plumb setDeviceScaleFactor and

deviceScaleFactor functions.
(WebKit::WebLayerTreeView::Settings::Settings): Remove deviceScaleFactor from
settings as it is now dynamic.
(Settings):
(WebLayerTreeView):

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed use of static

deviceScaleFactor from settings with dyanmic m_deviceScaleFactor
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::setDeviceScaleFactor): Added function to
set deviceScaleFactor.
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings): Removed static deviceScaleFactor
(CCSettings):
(CCLayerTreeHost): Added dynamic m_deviceScaleFactor in its place.
(WebCore::CCLayerTreeHost::deviceScaleFactor):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Same as above.

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
(WebCore::CCLayerTreeHostImpl::setDeviceScaleFactor): Added function to
set deviceScaleFactor.
(WebCore):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Added dynamic

m_deviceScaleFactor instance variable.
(WebCore::CCLayerTreeHostImpl::deviceScaleFactor):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings): Removed unused
static deviceScaleFactor.
(WebKit::WebLayerTreeView::setDeviceScaleFactor):
(WebKit):
(WebKit::WebLayerTreeView::deviceScaleFactor):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setDeviceScaleFactor): Push the dynamic deviceScaleFactor
to the compositor as required.
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostTest.cpp: Tests use dynamic setDeviceScaleFactor.

(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::beginTest):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):

18:05 Changeset [120543] by commit-queue@webkit.org

Unreviewed, rolling out r120536.
http://trac.webkit.org/changeset/120536
https://bugs.webkit.org/show_bug.cgi?id=89296

Does not compile on chromium-linux (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-16

Source/WebCore:

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore):
(WebCore::FontPlatformData::setHinting):
(WebCore::FontPlatformData::setAutoHint):
(WebCore::FontPlatformData::setUseBitmaps):
(WebCore::FontPlatformData::setAntiAlias):
(WebCore::FontPlatformData::setSubpixelRendering):
(WebCore::FontPlatformData::setSubpixelPositioning):
(WebCore::FontPlatformData::setupPaint):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/linux/WebFontRendering.h:
  • public/linuxish/WebFontRendering.h: Renamed from Source/WebKit/chromium/public/WebFontRendering.h.

(WebKit):
(WebFontRendering):

  • src/linuxish/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/WebFontRendering.cpp.

(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::setLCDOrder):
(WebKit::WebFontRendering::setLCDOrientation):

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):

  • DumpRenderTree/chromium/TestShellAndroid.cpp:
18:01 Changeset [120542] by commit-queue@webkit.org

Unreviewed, rolling out r120539.
http://trac.webkit.org/changeset/120539
https://bugs.webkit.org/show_bug.cgi?id=89295

Does not compile on chromium-mac (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-16

Source/WebCore:

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setTransform):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::prepareContentsTexture):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerImplTest.cpp:

(WebCore):
(WebCore::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:
17:39 Changeset [120541] by abarth@webkit.org

layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=89274

Reviewed by Levi Weintraub.

Tools:

Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
Note: The WebKit2 API that setBackingScaleFactor exercises is still
tested by API-level tests.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage):
(WTR):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

We don't need both layoutTestController.setBackingScaleFactor and
internals.settings.setDeviceScaleFactor because they do exactly the
same thing. This patch removes setBackingScaleFactor because it's
async nature is annoying and implementing it requires a bunch of
port-specific code.

  • fast/hidpi/broken-image-icon-hidpi.html:
  • fast/hidpi/broken-image-with-size-hidpi.html:
  • fast/hidpi/clip-text-in-hidpi.html:
  • fast/hidpi/focus-rings.html:
  • fast/hidpi/image-set-as-background.html:
  • fast/hidpi/image-set-background-dynamic.html:
  • fast/hidpi/image-set-background-repeat-without-size.html:
  • fast/hidpi/image-set-background-repeat.html:
  • fast/hidpi/image-set-border-image-comparison.html:
  • fast/hidpi/image-set-border-image-dynamic.html:
  • fast/hidpi/image-set-border-image-simple.html:
  • fast/hidpi/image-set-in-content-dynamic.html:
  • fast/hidpi/image-set-out-of-order.html:
  • fast/hidpi/image-set-simple.html:
  • fast/hidpi/image-set-without-specified-width.html:
  • fast/hidpi/resize-corner-hidpi.html:
  • fast/hidpi/video-controls-in-hidpi.html:
  • svg/as-image/image-respects-deviceScaleFactor.html:
17:35 Changeset [120540] by commit-queue@webkit.org

Ignore paths in Content Security Policy sources rather than failing to parse them.
https://bugs.webkit.org/show_bug.cgi?id=89281

Patch by Mike West <mkwst@chromium.org> on 2012-06-16
Reviewed by Adam Barth.

Source/WebCore:

In short: script-src http://example.com/ should allow scripts from
http://example.com. Currently, it allows no scripts at all, as the
terminal / isn't accepted as part of a hostname.

This patch adjusts CSPSourceList::parseSource to accept paths (and
discard them). Once this lands, the next step will be to keep the
path, and use it when comparing source origins in the various
allowXXXFromSource methods.

Tests: http/tests/security/contentSecurityPolicy/source-list-parsing-05.html

http/tests/security/contentSecurityPolicy/source-list-parsing-06.html

  • page/ContentSecurityPolicy.cpp:

(CSPSourceList):
(WebCore):
(WebCore::CSPSourceList::parseSource):

Reworked this method entirely to support paths.

(WebCore::CSPSourceList::parsePath):

More or less a no-op at the moment.

(WebCore::CSPSourceList::parsePort):

Moved the : assertion here from parseSource.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/source-list-parsing-05-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/source-list-parsing-05.html: Added.
  • http/tests/security/contentSecurityPolicy/source-list-parsing-06-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/source-list-parsing-06.html: Added.
17:26 Changeset [120539] by commit-queue@webkit.org

[Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged
https://bugs.webkit.org/show_bug.cgi?id=88482

Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-16
Reviewed by Adrienne Walker.

Source/WebCore:

Post-processing CCRenderPassList after it's been generated and
removing all render surface quads for which there are
cached textures, and whose content didn't change. Added a new
flag to CCLayerImpl to differentiate surface property change and
layer property change.

The changes are covered by new unit tests that check that
the removal algorithm functions propertly. No rendering
behaviour change, so no new layout tests.

  • platform/graphics/chromium/cc/CCDamageTracker.cpp:

(WebCore::layerNeedsToRedrawOntoItsTargetSurface):
(WebCore):
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::layerSurfacePropertyChanged):
(WebCore):
(WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
(WebCore::CCLayerImpl::setOpacity):
(WebCore::CCLayerImpl::setTransform):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::removeRenderPassesRecursive):
(WebCore):
(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(FrameData):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::hasCachedContentsTexture):
(WebCore):
(WebCore::CCRenderSurface::contentsChanged):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(CCRenderSurface):

Source/WebKit/chromium:

Added tests to verify quad removal algorithm. Added infrastructure
code to generate custom render passes out of a script
encoded as C string.

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCLayerImplTest.cpp:

(WebCore):
(WebCore::TEST):

  • tests/CCLayerTreeHostImplTest.cpp:
17:17 Changeset [120538] by commit-queue@webkit.org

Fix test cases for header/footer AXRoleDescription
https://bugs.webkit.org/show_bug.cgi?id=88911

The relative URLs to js-test-pre.js and js-test-post.js were incorrect.

Patch by Mike West <mkwst@chromium.org> on 2012-06-16
Reviewed by Simon Fraser.

  • platform/mac/accessibility/footer.html:
  • platform/mac/accessibility/header.html:
17:13 Changeset [120537] by commit-queue@webkit.org

[EFL] Rebaseline fast/lists/001*.html tests after r120495
https://bugs.webkit.org/show_bug.cgi?id=89283

Unreviewed EFL gardening after r120495.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-16

  • platform/efl/fast/lists/001-expected.png:
  • platform/efl/fast/lists/001-expected.txt:
  • platform/efl/fast/lists/001-vertical-expected.png:
  • platform/efl/fast/lists/001-vertical-expected.txt:
16:28 Changeset [120536] by wangxianzhu@chromium.org

[Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
https://bugs.webkit.org/show_bug.cgi?id=89228

Source/WebCore:

Reverse the dependency originally from WebKit::WebFontRendering to WebCore::FontPlatformDataHarfBuzz
so that WebKit::WebFontRendering can be platform-independent.

Reviewed by Tony Chang.

Refactory only. No new tests.

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::setupPaint):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):

Source/WebKit/chromium:

Reverse dependency originally from WebCore::FontPlatformDataHarfBuzz to WebKit::WebFontRendering
so that WebKit::WebFontRendering can be platform-independent.

This also avoids the ambiguous name 'linuxish'.

Reviewed by Tony Chang.

  • WebKit.gyp:
  • public/WebFontRendering.h: Copied from Source/WebKit/chromium/public/linuxish/WebFontRendering.h. Added getters under WEBKIT_IMPLEMENTATION.

(WebFontRendering):

  • public/linux/WebFontRendering.h:
  • public/linuxish: Removed.
  • public/linuxish/WebFontRendering.h: Removed.
  • src/WebFontRendering.cpp: Copied from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. Changed setters to be independent of platform-dependent implementation and added getters.

(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::hinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::autoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::useBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::antiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::subpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::subpixelPositioning):

  • src/linuxish: Removed.
  • src/linuxish/WebFontRendering.cpp: Removed.

Tools:

Reviewed by Tony Chang.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):

  • DumpRenderTree/chromium/TestShellAndroid.cpp:
16:01 WebKit Team edited by michelangelo@webkit.org
Changed affiliation (diff)
15:59 Changeset [120535] by commit-queue@webkit.org

[EFL] Rebaseline MathML tests after r120492
https://bugs.webkit.org/show_bug.cgi?id=89282

Unreviewed EFL gardening. Several MathML tests needed
rebaselining after r120492.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-16

  • platform/efl/mathml/presentation/attributes-expected.txt:
  • platform/efl/mathml/presentation/fenced-expected.txt:
  • platform/efl/mathml/presentation/fenced-mi-expected.txt:
  • platform/efl/mathml/presentation/fractions-expected.txt:
  • platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/efl/mathml/presentation/mo-stretch-expected.txt:
  • platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
  • platform/efl/mathml/presentation/roots-expected.txt:
  • platform/efl/mathml/presentation/row-alignment-expected.png:
  • platform/efl/mathml/presentation/row-alignment-expected.txt:
  • platform/efl/mathml/presentation/sub-expected.txt:
  • platform/efl/mathml/presentation/subsup-expected.txt:
  • platform/efl/mathml/presentation/sup-expected.txt:
  • platform/efl/mathml/presentation/tables-expected.txt:
  • platform/efl/mathml/presentation/tokenElements-expected.txt:
  • platform/efl/mathml/presentation/under-expected.png:
  • platform/efl/mathml/presentation/under-expected.txt:
  • platform/efl/mathml/presentation/underover-expected.png:
  • platform/efl/mathml/presentation/underover-expected.txt:
  • platform/efl/mathml/xHeight-expected.png:
  • platform/efl/mathml/xHeight-expected.txt:
15:35 Changeset [120534] by abarth@webkit.org

Settings::devicePixelRatio doesn't do anything and is confusing
https://bugs.webkit.org/show_bug.cgi?id=89272

Reviewed by James Robinson.

Source/WebCore:

Settings::devicePixelRatio is yet another piece of state trying to
represent the device scale factor. The canonical place to store this
state is Page::m_deviceScaleFactor. Nothing in WebCore references
Settings::devicePixelRatio anymore, so we can remove it.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):

Source/WebKit2:

  • Shared/WebPreferencesStore.h:

(WebKit):

  • Remove boilerplate code for the setting.
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::devicePixelRatio):
(QQuickWebViewExperimental::setDevicePixelRatio):

  • Change these functions to get and set the real device scale factor.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):

  • Use the real device scale factor for the viewport calculation.

(WebKit::WebPage::updatePreferences):

  • Remove boilerplate code for the setting.
15:22 Changeset [120533] by commit-queue@webkit.org

[Texmap] SIGSEV in WebCore::TextureMapperGL::drawTexture.
https://bugs.webkit.org/show_bug.cgi?id=89113

TextureMapperTile::m_texture is created lazilly, so we need null check before
using it.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-16
Reviewed by Noam Rosenthal.

No new tests. This patch doesn't change behavior.

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTile::paint):

15:17 Changeset [120532] by commit-queue@webkit.org

[Texmap] Remove unused code in Texmap.
https://bugs.webkit.org/show_bug.cgi?id=89265

Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-16
Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::didSynchronize):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(GraphicsLayerTextureMapper):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::syncCompositingState):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

15:10 Changeset [120531] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-16

  • DEPS:
13:00 Changeset [120530] by abarth@webkit.org

Remove a bunch of 32-bit specific results. These results are the same
on 64 bit.

  • platform/chromium-linux-x86/compositing/color-matching: Removed.
  • platform/chromium-linux-x86/compositing/color-matching/image-color-matching-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/custom: Removed.
  • platform/chromium-linux-x86/css3/filters/custom/custom-filter-shader-cache-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/custom/effect-custom-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/custom/missing-custom-filter-shader-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/effect-blur-hw-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/effect-brightness-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/effect-brightness-hw-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/effect-contrast-hw-expected.png: Removed.
  • platform/chromium-linux-x86/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
  • platform/chromium-linux-x86/fast/images: Removed.
  • platform/chromium-linux-x86/fast/images/jpeg-with-color-profile-expected.png: Removed.
  • platform/chromium-linux-x86/fast/images/png-with-color-profile-expected.png: Removed.
  • platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-linux/css3/filters/custom/missing-custom-filter-shader-expected.png:
  • platform/chromium-linux/css3/filters/effect-blur-hw-expected.png:
  • platform/chromium-linux/css3/filters/effect-brightness-expected.png:
  • platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png:
  • platform/chromium-linux/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium-linux/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-linux/fast/images/png-with-color-profile-expected.png: Added.
12:53 Changeset [120529] by abarth@webkit.org

Update baselines after http://trac.webkit.org/changeset/120485

  • platform/chromium-linux-x86/http/tests/local: Removed.
  • platform/chromium-linux-x86/http/tests/local/file-url-sent-as-referer-expected.png: Removed.
  • platform/chromium-linux-x86/scrollbars: Removed.
  • platform/chromium-linux-x86/scrollbars/listbox-scrollbar-combinations-expected.png: Removed.
  • platform/chromium-linux-x86/scrollbars/overflow-scrollbar-combinations-expected.png: Removed.
  • platform/chromium-linux-x86/svg/as-border-image: Removed.
  • platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/createImageElement-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/createImageElement2-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/focus-ring-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/group-opacity-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/image-parent-translation-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/js-update-image-and-display-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/js-update-image-and-display2-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/js-update-image-and-display3-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/js-update-image-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/text-image-opacity-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/filters/feImage-subregions-expected.png: Removed.
  • platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Removed.
  • platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Removed.
  • platform/chromium-linux-x86/svg/filters/filter-source-position-expected.png: Removed.
  • platform/chromium-linux-x86/svg/repaint: Removed.
  • platform/chromium-linux-x86/svg/repaint/image-href-change-expected.png: Removed.
  • platform/chromium-linux-x86/svg/transforms/animated-path-inside-transformed-html-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Removed.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Removed.
  • platform/chromium-linux/http/tests/local/file-url-sent-as-referer-expected.png:
  • platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-linux/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-linux/svg/custom/createImageElement2-expected.png:
  • platform/chromium-linux/svg/custom/focus-ring-expected.png:
  • platform/chromium-linux/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win-vista/http/tests/local: Removed.
  • platform/chromium-win-vista/svg/dynamic-updates: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win-xp/svg/dynamic-updates: Removed.
  • platform/chromium-win/http/tests/local/file-url-sent-as-referer-expected.png:
  • platform/chromium-win/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-win/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/chromium-win/svg/custom/createImageElement-expected.png:
  • platform/chromium-win/svg/custom/createImageElement2-expected.png:
  • platform/chromium-win/svg/custom/focus-ring-expected.png:
  • platform/chromium-win/svg/custom/group-opacity-expected.png:
  • platform/chromium-win/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-win/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-win/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-win/svg/custom/js-update-image-expected.png:
  • platform/chromium-win/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-win/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-win/svg/filters/feImage-subregions-expected.png:
  • platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/chromium-win/svg/filters/filter-source-position-expected.png:
  • platform/chromium-win/svg/repaint/image-href-change-expected.png:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
09:48 Changeset [120528] by zandobersek@gmail.com

Unreviewed GTK gardening, updating baselines
after r120492 and r120495.

  • platform/gtk/fast/lists/001-expected.txt:
  • platform/gtk/fast/lists/001-vertical-expected.txt:
  • platform/gtk/mathml/xHeight-expected.txt:
09:16 Changeset [120527] by igor.o@sisa.samsung.com

[TexmapGL] Reduce the number of glTexSubImage2D calls
https://bugs.webkit.org/show_bug.cgi?id=83665

Instead of copy the pixels row by row, put the pixels in a buffer and
call glTexSubImage2D just once.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

02:21 Changeset [120526] by commit-queue@webkit.org

[chromium] WebFrameClient::userAgentOverride() should take in a WebFrame* as its first argument
https://bugs.webkit.org/show_bug.cgi?id=89233

Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-06-16
Reviewed by Darin Fisher.

Adds a WebFrame* to the WebFrameClient::userAgentOverride() function.

  • public/WebFrameClient.h:

(WebKit::WebFrameClient::userAgentOverride):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::userAgent):

  • tests/FrameLoaderClientImplTest.cpp:
01:42 Changeset [120525] by ossy@webkit.org

[Qt] Unreviewed weekend gardening, skip a new failing test.

  • platform/qt-5.0-wk2/Skipped:
01:34 Changeset [120524] by ossy@webkit.org

[Qt] Unreviewed weekend gardening.

  • platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.png: Updated after after r120411.
  • platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.txt: Updated after after r120411.
  • platform/qt-5.0/fast/forms/box-shadow-override-expected.png: Updated after after r120411.
  • platform/qt-5.0/fast/forms/box-shadow-override-expected.txt: Updated after after r120411.
  • platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Updated after r120495.
  • platform/qt/fast/lists/001-expected.png: Updated after r120495.
  • platform/qt/fast/lists/001-expected.txt: Updated after r120495.
  • platform/qt/fast/lists/001-vertical-expected.png: Updated after r120495.
  • platform/qt/fast/lists/001-vertical-expected.txt: Updated after r120495.

06/15/12:

22:01 Changeset [120523] by commit-queue@webkit.org

Unreviewed, rolling out r120280.
http://trac.webkit.org/changeset/120280
https://bugs.webkit.org/show_bug.cgi?id=89273

Enabling CSS regions broke all Windows tests (Requested by
jhomeycutt on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-15

Source/WebCore:

  • css/CSSPropertyNames.in:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
20:54 Changeset [120522] by rniwa@webkit.org

Use testRunner instead of layoutTestController in fast/workers/storage tests
https://bugs.webkit.org/show_bug.cgi?id=89271

Reviewed by Adam Barth.

  • fast/workers/storage/change-version-sync.html:
  • fast/workers/storage/interrupt-database-sync.html-disabled:
  • fast/workers/storage/interrupt-database.html:
  • fast/workers/storage/resources/database-worker.js:

(onmessage):

  • fast/workers/storage/resources/multiple-transactions-sync.js:

(checkCompletion):

  • fast/workers/storage/resources/test-inputs-common.js:

(finishTest):

  • fast/workers/storage/use-same-database-in-page-and-workers.html:
20:42 Changeset [120521] by rniwa@webkit.org

Use testRunner instead of layoutTestController in transforms, transitions, traversal, userscripts, webarchive, webaudio, and webintents tests
https://bugs.webkit.org/show_bug.cgi?id=89269

Reviewed by Adam Barth.

  • transitions/:
  • traversal/:
  • userscripts/:
  • webarchive/:
  • webaudio/:
  • webintents/web-intents-delivery.html:
  • webintents/web-intents-failure.html:
  • webintents/web-intents-reload.html:
  • webintents/web-intents-reply.html:
20:35 Changeset [120520] by abarth@webkit.org

garden-o-matic's results.js should use RequestTracker
https://bugs.webkit.org/show_bug.cgi?id=89257

Reviewed by Dimitri Glazkov.

We wrote results.js before we recognized the RequestTracker pattern.
This patch replaces the manual implementations of RequestTracker with
the real deal.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
20:30 Changeset [120519] by rniwa@webkit.org

Use testRunner instead of layoutTestController in the rest of sputnik tests
https://bugs.webkit.org/show_bug.cgi?id=89262

Reviewed by Antti Koivisto.

  • sputnik/Implementation_Diagnostics/:
  • sputnik/Regression/:
  • sputnik/Unicode/:
20:10 Changeset [120518] by rniwa@webkit.org

Test fix attempt after r120516.

  • fast/workers/storage/resources/database-worker-controller.js:

(databaseWorker.onmessage):
(runTest):

19:23 Changeset [120517] by darin@apple.com
  • Scripts/webkitpy/bindings: Added property svn:ignore.
19:16 Changeset [120516] by rniwa@webkit.org

Use testRunner instead of layoutTestController in storage, tables, touchadjustments, and transforms tests
https://bugs.webkit.org/show_bug.cgi?id=89263

Reviewed by Antti Koivisto.

  • storage/domstorage/events/resources/eventTestHarness.js:

(testStorages.allDone):

  • storage/domstorage/localstorage/delete-removal.html:
  • storage/domstorage/localstorage/enumerate-storage.html:
  • storage/domstorage/localstorage/enumerate-with-length-and-key.html:
  • storage/domstorage/localstorage/index-get-and-set.html:
  • storage/domstorage/localstorage/private-browsing-affects-storage.html:
  • storage/domstorage/localstorage/resources/window-open-second.html:
  • storage/domstorage/localstorage/simple-usage.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all-expected.txt:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one-expected.txt:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage-expected.txt:
  • storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html:
  • storage/domstorage/localstorage/string-conversion.html:
  • storage/domstorage/localstorage/window-open.html:
  • storage/domstorage/script-tests/storage-functions-not-overwritten.js:
  • storage/domstorage/sessionstorage/delete-removal.html:
  • storage/domstorage/sessionstorage/enumerate-storage.html:
  • storage/domstorage/sessionstorage/enumerate-with-length-and-key.html:
  • storage/domstorage/sessionstorage/index-get-and-set.html:
  • storage/domstorage/sessionstorage/private-browsing-affects-storage.html:
  • storage/domstorage/sessionstorage/resources/window-open-second.html:
  • storage/domstorage/sessionstorage/simple-usage.html:
  • storage/domstorage/sessionstorage/string-conversion.html:
  • storage/domstorage/sessionstorage/window-open.html:
  • storage/domstorage/window-attributes-exist.html:
  • storage/indexeddb/mozilla/index-prev-no-duplicate.html:
  • storage/indexeddb/tutorial.html:
  • storage/websql/change-version-handle-reuse.js:

(finishTest):

  • storage/websql/change-version-no-crash-on-preflight-failure.html:
  • storage/websql/change-version.html:
  • storage/websql/close-during-stress-test.html:
  • storage/websql/database-lock-after-reload.html:
  • storage/websql/empty-statement.html:
  • storage/websql/execute-sql-args.js:

(runTransactionTests):

  • storage/websql/executesql-accepts-only-one-statement.html:
  • storage/websql/hash-change-with-xhr.js:

(stopTest):

  • storage/websql/multiple-databases-garbage-collection.js:

(checkCompletion):

  • storage/websql/multiple-transactions-on-different-handles.js:

(checkCompletion):

  • storage/websql/multiple-transactions.js:

(checkCompletion):

  • storage/websql/null-callbacks.html:
  • storage/websql/open-database-creation-callback-isolated-world.html:
  • storage/websql/open-database-creation-callback.html:
  • storage/websql/open-database-empty-version.html:
  • storage/websql/open-database-over-quota.html:
  • storage/websql/open-database-set-empty-version.html:
  • storage/websql/open-database-while-transaction-in-progress.js:

(runTest):

  • storage/websql/private-browsing-noread-nowrite.html:
  • storage/websql/quota-tracking.html:
  • storage/websql/read-and-write-transactions-dont-run-together.js:

(terminateTest):

  • storage/websql/read-transactions-running-concurrently.html:
  • storage/websql/resources/database-common.js:

(setupAndRunTest):

  • storage/websql/resources/database-lock-after-reload-2.html:
  • storage/websql/sql-data-types.js:

(notifyDone):
(runTest):

  • storage/websql/sql-error-codes.js:

(finishTest):
(runTest):

  • storage/websql/statement-error-callback-isolated-world.html:
  • storage/websql/statement-error-callback.html:
  • storage/websql/statement-success-callback-isolated-world.html:
  • storage/websql/success-callback.html:
  • storage/websql/test-authorizer.js:

(terminateTest):

  • storage/websql/transaction-callback-exception-crash.html:
  • storage/websql/transaction-callback-isolated-world.html:
  • storage/websql/transaction-error-callback-isolated-world.html:
  • storage/websql/transaction-error-callback.html:
  • storage/websql/transaction-success-callback-isolated-world.html:
  • tables/hittesting/filltable-emptycells.html:
  • tables/hittesting/filltable-levels.html:
  • tables/hittesting/filltable-outline.html:
  • tables/hittesting/filltable-rtl.html:
  • tables/hittesting/filltable-stress.html:
  • tables/layering/paint-test-layering-1.html:
  • tables/layering/paint-test-layering-2.html:
  • tables/table-section-overflow-clip-crash.html:
  • touchadjustment/block-testing.html:
  • touchadjustment/event-triggered-widgets.html:
  • touchadjustment/html-label.html:
  • touchadjustment/iframe.html:
  • touchadjustment/nested-touch.html:
  • touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html:
  • touchadjustment/scroll-offset.html:
  • touchadjustment/touch-inlines.html:
  • touchadjustment/zoom-basic.html:
  • touchadjustment/zoom-fatfinger.html:
  • transforms/2d/compound-2d-transforms.html:
  • transforms/2d/cssmatrix-2d-zoom.html:
  • transforms/2d/set-transform-and-top.html:
  • transforms/2d/transform-2d.html:
  • transforms/2d/transform-accuracy.html:
  • transforms/3d/general/3dtransform-values.html:
  • transforms/3d/general/cssmatrix-3d-zoom.html:
  • transforms/3d/general/matrix-with-zoom-3d.html:
  • transforms/3d/general/transform-origin-z-change.html:
  • transforms/3d/hit-testing/hit-preserves-3d.html:
  • transforms/3d/point-mapping/3d-point-mapping-2.html:
  • transforms/3d/point-mapping/3d-point-mapping-3.html:
  • transforms/3d/point-mapping/3d-point-mapping-deep.html:
  • transforms/3d/point-mapping/3d-point-mapping-origins.html:
  • transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html:
  • transforms/no_transform_hit_testing.html:
19:06 Changeset [120515] by rniwa@webkit.org

Remove empty directories.

  • platform/editing: Removed.
  • platform/editing/inserting: Removed.
  • websocket: Removed.
  • websocket/tests: Removed.
  • websocket/tests/workers: Removed.
18:15 Changeset [120514] by atwilson@chromium.org

2012-06-15 Andrew Wilson <atwilson@chromium.org>

Unreviewed chromium expectations update.
https://bugs.webkit.org/show_bug.cgi?id=82122
https://bugs.webkit.org/show_bug.cgi?id=79914

  • platform/chromium-mac-leopard/fast/lists/001-expected.png:
  • platform/chromium-mac/fast/lists/001-expected.png:
  • platform/chromium-mac/fast/lists/001-vertical-expected.png:
  • platform/chromium-win/fast/lists/001-expected.png:
  • platform/chromium-win/fast/lists/001-vertical-expected.png:
  • platform/chromium/TestExpectations:
17:49 Changeset [120513] by commit-queue@webkit.org

Unreviewed, rolling out r120511.
http://trac.webkit.org/changeset/120511
https://bugs.webkit.org/show_bug.cgi?id=89255

Breaks at least Android builder (Requested by wangxianzhu on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-15

Source/WebCore:

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore):
(WebCore::FontPlatformData::setHinting):
(WebCore::FontPlatformData::setAutoHint):
(WebCore::FontPlatformData::setUseBitmaps):
(WebCore::FontPlatformData::setAntiAlias):
(WebCore::FontPlatformData::setSubpixelRendering):
(WebCore::FontPlatformData::setSubpixelPositioning):
(WebCore::FontPlatformData::setupPaint):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/linux/WebFontRendering.h:
  • public/linuxish/WebFontRendering.h: Renamed from Source/WebKit/chromium/public/WebFontRendering.h.

(WebKit):
(WebFontRendering):

  • src/linuxish/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/WebFontRendering.cpp.

(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::setLCDOrder):
(WebKit::WebFontRendering::setLCDOrientation):

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):

17:33 Changeset [120512] by atwilson@chromium.org

Unreviewed baselines for chromium.
https://bugs.webkit.org/show_bug.cgi?id=87761

  • platform/chromium-linux-x86/compositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/crash-hw-sw-switch-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/custom/custom-filter-shader-cache-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/custom/effect-custom-combined-missing-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/custom/effect-custom-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/custom/missing-custom-filter-shader-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/effect-blur-hw-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/effect-brightness-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/effect-brightness-hw-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/effect-contrast-hw-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/effect-drop-shadow-hw-expected.png: Added.
  • platform/chromium-linux-x86/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-linux-x86/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium-linux-x86/http/tests/local/file-url-sent-as-referer-expected.png: Added.
  • platform/chromium-linux-x86/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
  • platform/chromium-linux-x86/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/createImageElement-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/createImageElement2-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/focus-ring-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/group-opacity-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/image-parent-translation-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/js-update-image-and-display-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/js-update-image-and-display2-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/js-update-image-and-display3-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/js-update-image-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/text-image-opacity-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/feImage-subregions-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/filter-source-position-expected.png: Added.
  • platform/chromium-linux-x86/svg/repaint/image-href-change-expected.png: Added.
  • platform/chromium-linux-x86/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-mac-leopard/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-mac-leopard/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/chromium-mac-leopard/compositing/visibility/visibility-image-layers-expected.png:
  • platform/chromium-mac-leopard/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-mac-leopard/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac-leopard/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-mac-leopard/css3/filters/custom/missing-custom-filter-shader-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-blur-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-blur-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-brightness-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-combined-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-contrast-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-contrast-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-invert-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-invert-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-opacity-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-opacity-hw-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-saturate-expected.png:
  • platform/chromium-mac-leopard/css3/filters/effect-sepia-expected.png:
  • platform/chromium-mac-leopard/css3/filters/regions-expanding-expected.png:
  • platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-mac-leopard/fast/css/color-correction-expected.png:
  • platform/chromium-mac-leopard/fast/css/color-correction-on-backgrounds-expected.png:
  • platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac-leopard/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-leopard/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium-mac-leopard/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-masks-outset-expected.png:
  • platform/chromium-mac-leopard/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-mac-leopard/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-mac-leopard/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-leopard/svg/custom/createImageElement-expected.png:
  • platform/chromium-mac-leopard/svg/custom/createImageElement2-expected.png:
  • platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-leopard/svg/custom/group-opacity-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-leopard/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac-leopard/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac-leopard/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feImage-subregions-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/chromium-mac-leopard/svg/filters/filter-source-position-expected.png:
  • platform/chromium-mac-leopard/svg/repaint/image-href-change-expected.png:
  • platform/chromium-mac-leopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-mac-snowleopard/compositing/masks/direct-image-mask-expected.png:
  • platform/chromium-mac-snowleopard/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/color-correction-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-backgrounds-expected.png:
  • platform/chromium-mac-snowleopard/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/chromium-mac-snowleopard/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac-snowleopard/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/createImageElement2-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-mac/compositing/masks/direct-image-mask-expected.png:
  • platform/chromium-mac/compositing/reflections/simple-composited-reflections-expected.png:
  • platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png:
  • platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
  • platform/chromium-mac/css3/filters/custom/missing-custom-filter-shader-expected.png:
  • platform/chromium-mac/css3/filters/effect-blur-expected.png:
  • platform/chromium-mac/css3/filters/effect-blur-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-expected.png:
  • platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-combined-expected.png:
  • platform/chromium-mac/css3/filters/effect-contrast-expected.png:
  • platform/chromium-mac/css3/filters/effect-contrast-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-mac/css3/filters/effect-invert-expected.png:
  • platform/chromium-mac/css3/filters/effect-invert-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-opacity-expected.png:
  • platform/chromium-mac/css3/filters/effect-opacity-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-saturate-expected.png:
  • platform/chromium-mac/css3/filters/effect-sepia-expected.png:
  • platform/chromium-mac/css3/filters/regions-expanding-expected.png:
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-mac/fast/css/color-correction-expected.png:
  • platform/chromium-mac/fast/css/color-correction-on-backgrounds-expected.png:
  • platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.png:
  • platform/chromium-mac/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-mac/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-masks-outset-expected.png:
  • platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
  • platform/chromium-mac/svg/custom/createImageElement-expected.png:
  • platform/chromium-mac/svg/custom/createImageElement2-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/custom/group-opacity-expected.png:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/chromium-mac/svg/filters/filter-source-position-expected.png:
  • platform/chromium-mac/svg/repaint/image-href-change-expected.png:
  • platform/chromium-mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac/svg/wicd/test-rightsizing-b-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium-win/compositing/color-matching/image-color-matching-expected.png:
  • platform/chromium-win/css3/filters/crash-filter-change-expected.png:
  • platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png:
  • platform/chromium-win/css3/filters/effect-blur-expected.png:
  • platform/chromium-win/css3/filters/effect-blur-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-brightness-expected.png:
  • platform/chromium-win/css3/filters/effect-brightness-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-combined-expected.png:
  • platform/chromium-win/css3/filters/effect-contrast-expected.png:
  • platform/chromium-win/css3/filters/effect-contrast-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-drop-shadow-expected.png:
  • platform/chromium-win/css3/filters/effect-drop-shadow-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-grayscale-expected.png:
  • platform/chromium-win/css3/filters/effect-hue-rotate-expected.png:
  • platform/chromium-win/css3/filters/effect-invert-expected.png:
  • platform/chromium-win/css3/filters/effect-invert-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-opacity-expected.png:
  • platform/chromium-win/css3/filters/effect-opacity-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-saturate-expected.png:
  • platform/chromium-win/css3/filters/effect-sepia-expected.png:
  • platform/chromium-win/css3/filters/regions-expanding-expected.png:
  • platform/chromium-win/fast/images/jpeg-with-color-profile-expected.png: Added.
  • platform/chromium-win/fast/images/png-with-color-profile-expected.png: Added.
  • platform/chromium/TestExpectations:
17:24 Changeset [120511] by wangxianzhu@chromium.org

[Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
https://bugs.webkit.org/show_bug.cgi?id=89228

Source/WebCore:

Reverse the dependency originally from WebKit::WebFontRendering to WebCore::FontPlatformDataHarfBuzz
so that WebKit::WebFontRendering can be platform-independent.

Reviewed by Tony Chang.

Refactory only. No new tests.

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::setupPaint):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):

Source/WebKit/chromium:

Reverse dependency originally from WebCore::FontPlatformDataHarfBuzz to WebKit::WebFontRendering
so that WebKit::WebFontRendering can be platform-independent.

This also avoids the ambiguous name 'linuxish'.

Reviewed by Tony Chang.

  • WebKit.gyp:
  • public/WebFontRendering.h: Copied from Source/WebKit/chromium/public/linuxish/WebFontRendering.h. Added getters under WEBKIT_IMPLEMENTATION.

(WebFontRendering):

  • public/linux/WebFontRendering.h:
  • public/linuxish: Removed.
  • public/linuxish/WebFontRendering.h: Removed.
  • src/WebFontRendering.cpp: Copied from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp. Changed setters to be independent of platform-dependent implementation and added getters.

(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::hinting):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::autoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::useBitmaps):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::antiAlias):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::subpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::subpixelPositioning):

  • src/linuxish: Removed.
  • src/linuxish/WebFontRendering.cpp: Removed.

Tools:

Reviewed by Tony Chang.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):

16:35 Changeset [120510] by dgrogan@chromium.org

IndexedDB: Remove obsolete description parameter from factory.open calls
https://bugs.webkit.org/show_bug.cgi?id=89047

Reviewed by Tony Chang.

This parameter has been obsolete for 18 months and is getting replaced
with a version parameter.

  • storage/indexeddb/mozilla/add-twice-failure-expected.txt:
  • storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
  • storage/indexeddb/mozilla/bad-keypath-expected.txt:
  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/create-index-unique-expected.txt:
  • storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
  • storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
  • storage/indexeddb/mozilla/cursors-expected.txt:
  • storage/indexeddb/mozilla/delete-result-expected.txt:
  • storage/indexeddb/mozilla/event-source-expected.txt:
  • storage/indexeddb/mozilla/global-data-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate.html:
  • storage/indexeddb/mozilla/indexes-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
  • storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
  • storage/indexeddb/mozilla/object-cursors-expected.txt:
  • storage/indexeddb/mozilla/object-identity-expected.txt:
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
  • storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
  • storage/indexeddb/mozilla/objectstorenames-expected.txt:
  • storage/indexeddb/mozilla/odd-result-order-expected.txt:
  • storage/indexeddb/mozilla/put-get-values-expected.txt:
  • storage/indexeddb/mozilla/readonly-transactions-expected.txt:
  • storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
  • storage/indexeddb/mozilla/readyState-expected.txt:
  • storage/indexeddb/mozilla/remove-index-expected.txt:
  • storage/indexeddb/mozilla/remove-objectstore-expected.txt:
  • storage/indexeddb/mozilla/resources/add-twice-failure.js:

(test):

  • storage/indexeddb/mozilla/resources/autoincrement-indexes.js:

(test):

  • storage/indexeddb/mozilla/resources/bad-keypath.js:

(test):

  • storage/indexeddb/mozilla/resources/clear.js:

(test):

  • storage/indexeddb/mozilla/resources/create-index-unique.js:

(test):

  • storage/indexeddb/mozilla/resources/create-index-with-integer-keys.js:

(test):

  • storage/indexeddb/mozilla/resources/create-objectstore-basics.js:

(test):

  • storage/indexeddb/mozilla/resources/create-objectstore-null-name.js:

(test):

  • storage/indexeddb/mozilla/resources/cursor-mutation-objectstore-only.js:

(test):

  • storage/indexeddb/mozilla/resources/cursor-update-updates-indexes.js:

(test):

  • storage/indexeddb/mozilla/resources/cursors.js:

(test):

  • storage/indexeddb/mozilla/resources/delete-result.js:

(test):

  • storage/indexeddb/mozilla/resources/event-source.js:

(test):

  • storage/indexeddb/mozilla/resources/global-data.js:

(test):
(cleanDatabase):

  • storage/indexeddb/mozilla/resources/indexes.js:

(test):

  • storage/indexeddb/mozilla/resources/key-requirements-delete-null-key.js:

(test):

  • storage/indexeddb/mozilla/resources/key-requirements-inline-and-passed.js:

(test):

  • storage/indexeddb/mozilla/resources/key-requirements-put-no-key.js:

(test):

  • storage/indexeddb/mozilla/resources/key-requirements-put-null-key.js:

(test):

  • storage/indexeddb/mozilla/resources/key-requirements.js:

(test):

  • storage/indexeddb/mozilla/resources/object-cursors.js:

(test):

  • storage/indexeddb/mozilla/resources/object-identity.js:

(test):

  • storage/indexeddb/mozilla/resources/object-store-inline-autoincrement-key-added-on-put.js:

(test):

  • storage/indexeddb/mozilla/resources/object-store-remove-values.js:

(test):

  • storage/indexeddb/mozilla/resources/objectstorenames.js:

(test):

  • storage/indexeddb/mozilla/resources/odd-result-order.js:

(test):

  • storage/indexeddb/mozilla/resources/put-get-values.js:

(test):

  • storage/indexeddb/mozilla/resources/readonly-transactions.js:

(test):

  • storage/indexeddb/mozilla/resources/readwrite-transactions.js:

(test):

  • storage/indexeddb/mozilla/resources/readyState.js:

(test):

  • storage/indexeddb/mozilla/resources/remove-index.js:

(test):

  • storage/indexeddb/mozilla/resources/remove-objectstore.js:

(test):

  • storage/indexeddb/mozilla/resources/versionchange-abort.js:

(test):

  • storage/indexeddb/mozilla/resources/versionchange.js:

(test):
(openSuccess):
(postSetVersion):

  • storage/indexeddb/mozilla/versionchange-abort-expected.txt:
  • storage/indexeddb/mozilla/versionchange-expected.txt:
16:33 Changeset [120509] by enne@google.com

[chromium] Fix composited scrollbars with transparent thumbs
https://bugs.webkit.org/show_bug.cgi?id=89247

Reviewed by James Robinson.

On some platforms, the thumb of a scrollbar can be transparent. Fix by
always drawing the thumb quad with blending.

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.cpp:

(WebCore::CCTextureDrawQuad::setNeedsBlending):
(WebCore):

  • platform/graphics/chromium/cc/CCTextureDrawQuad.h:

(CCTextureDrawQuad):

16:18 Changeset [120508] by tony@chromium.org

[chromium] Remove WebKit/chromium/public/gtk/WebFontInfo.h since it's no longer referenced.
https://bugs.webkit.org/show_bug.cgi?id=89251

Reviewed by Adam Barth.

This was a forwarding header when we moved the file to public/linux.

  • public/gtk/WebFontInfo.h: Removed.
16:13 Changeset [120507] by jamesr@google.com

[chromium] Use SkBitmap in ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=89134

Reviewed by Adrienne Walker.

GraphicsLayer::setContentsToImage(Image*) is called whenever an image layer's image is or might have changed.
In Chromium, this used to hang on to a RefPtr<WebCore::Image> until the compositor was ready to upload texture contents.
This is potentially a bit fishy since the Image itself might not be in exactly the same state when we get around
to uploading textures and it also creates a bad dependency from ImageLayerChromium on WebCore::Image.

This patch grabs the underlying SkBitmap in the setContentsTo call and passes that into ImageLayerChromium
instead. I've also removed the venerable but redundant PlatformImage concept since all of chromium's images are
skia bitmaps these days.

Covered by existing tests, particularly compositing/images/ and compositing/color-matching/.

  • WebCore.gypi:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::updateTextureRect):
(WebCore::ImageLayerTextureUpdater::setBitmap):
(ImageLayerTextureUpdater):
(WebCore::ImageLayerChromium::ImageLayerChromium):
(WebCore::ImageLayerChromium::setBitmap):
(WebCore::ImageLayerChromium::update):
(WebCore::ImageLayerChromium::contentBounds):
(WebCore::ImageLayerChromium::drawsContent):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/PlatformImage.cpp: Removed.
  • platform/graphics/chromium/PlatformImage.h: Removed.
16:09 Changeset [120506] by efidler@rim.com

[BlackBerry] Use platform font settings for the standard settings.
https://bugs.webkit.org/show_bug.cgi?id=89232

Reviewed by Rob Buis.

RIM PR 159708

Source/WebCore:

  • page/blackberry/SettingsBlackBerry.cpp:

(WebCore):
(WebCore::Settings::initializeDefaultFontFamilies):

Source/WebKit/blackberry:

  • Api/WebSettings.cpp:

(BlackBerry::WebKit::WebSettings::standardSettings):

15:58 Changeset [120505] by commit-queue@webkit.org

[BlackBerry] Remove touch events handling hook for popup
https://bugs.webkit.org/show_bug.cgi?id=89245

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-15
Reviewed by Rob Buis.

In the old patches we create our own WebPage for popup, so we need to hook up our own
touch handling functions, since we don't use our own WebPage any more, no need to keep
the touch handling code, because it just does nothing other than passing out the events
which might cause the touch events being handled twice.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

  • WebCoreSupport/PagePopupBlackBerry.cpp:
  • WebCoreSupport/PagePopupBlackBerry.h:

(PagePopupBlackBerry):

15:49 Changeset [120504] by jsbell@chromium.org

IndexedDB: Raise exceptions when methods are called on deleted objects
https://bugs.webkit.org/show_bug.cgi?id=89243

Reviewed by Tony Chang.

Source/WebCore:

Implement the IDB spec requirement that InvalidStateError exceptions are
thrown when methods are called on objects (i.e. object stores and indexes)
that have been deleted within a version change transaction.

Test: storage/indexeddb/deleted-objects.html

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::deleteObjectStore): Don't relay to transaction if back-end failed.

  • Modules/indexeddb/IDBIndex.cpp: Check deleted state in methods, raise if set.

(WebCore::IDBIndex::IDBIndex):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • Modules/indexeddb/IDBIndex.h: Add flag to track deleted state, method to mark it.

(WebCore::IDBIndex::markDeleted):
(IDBIndex):

  • Modules/indexeddb/IDBObjectStore.cpp: Check deleted state in methods, raise if set.

(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex): If the index being deleted has been instantiated,
mark it as deleted.
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):

  • Modules/indexeddb/IDBObjectStore.h: Add flag to track deleted state, method to mark it.

(WebCore::IDBObjectStore::markDeleted):
(IDBObjectStore):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::objectStoreDeleted): If the store being deleted has been instantiated,
mark it as deleted.

LayoutTests:

  • storage/indexeddb/deleted-objects-expected.txt: Added.
  • storage/indexeddb/deleted-objects.html: Added.
  • storage/indexeddb/resources/deleted-objects.js: Added.

(test):
(openDatabase.request.onsuccess.request.onsuccess):
(openDatabase.request.onsuccess):
(openDatabase):

  • storage/indexeddb/resources/transaction-basics.js: Fix test that relied on

non-compliant behavior.
(addRemoveIDBObjects):
(addRemoveAddIDBObjects):

  • storage/indexeddb/transaction-basics-expected.txt:
15:30 Changeset [120503] by inferno@chromium.org

Unreviewed. Forgot a rebaseline for r120477.

  • platform/chromium-win/fast/forms/formmove3-expected.txt:
15:24 Changeset [120502] by commit-queue@webkit.org

[BlackBerry] Put platform-specific GC policy in GCActivityCallback
https://bugs.webkit.org/show_bug.cgi?id=89236

Patch by Yong Li <yoli@rim.com> on 2012-06-15
Reviewed by Rob Buis.

Add GCActivityCallbackBlackBerry.cpp and implement platform-specific
low memory GC policy there.

  • PlatformBlackBerry.cmake:
  • heap/Heap.h:

(JSC::Heap::isSafeToCollect): Added.

  • runtime/GCActivityCallbackBlackBerry.cpp: Added.

(JSC):
(JSC::DefaultGCActivityCallbackPlatformData::DefaultGCActivityCallbackPlatformData):
(DefaultGCActivityCallbackPlatformData):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::synchronize):
(JSC::DefaultGCActivityCallback::cancel):

15:24 Changeset [120501] by jamesr@google.com

[chromium] Fix LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html
https://bugs.webkit.org/show_bug.cgi?id=89126

Reviewed by Stephen White.

When drawing an image buffer into a deferred device context, we have to make a deep copy of the source (Skia
can't for some reason). Stephen White fixed this in r101325 by adding a bit on PlatformContextSkia indicating if
a given context is deferred, but I broke this again in r120346 by refactoring the SkCanvas creation to happen in
a different location from the PlatformContextSkia construction.

This moves the check into ImageBufferSkia and directly queries the state of the destination SkDevice to be more
robust and work without needing special PlatformContextSkia setup.

Covered by LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::drawNeedsCopy):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):

15:21 Changeset [120500] by fpizlo@apple.com

DFG should be able to set watchpoints on structure transitions in the
method check prototype chain
https://bugs.webkit.org/show_bug.cgi?id=89058

Adding the same assertion to 32-bit that I added to 64-bit. This change
does not affect correctness but it's a good thing for assertion coverage.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

15:14 Changeset [120499] by fpizlo@apple.com

DFG should be able to set watchpoints on structure transitions in the
method check prototype chain
https://bugs.webkit.org/show_bug.cgi?id=89058

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

This adds the ability to set watchpoints on Structures, and then does
the most modest thing we can do with this ability: the DFG now sets
watchpoints on structure transitions in the prototype chain of method
checks.

This appears to be a >1% speed-up on V8.

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):

  • bytecode/StructureSet.h:

(JSC::StructureSet::containsOnly):
(StructureSet):

  • bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::WatchpointSet):
(JSC::InlineWatchpointSet::add):
(JSC):
(JSC::InlineWatchpointSet::inflateSlow):
(JSC::InlineWatchpointSet::freeFat):

  • bytecode/Watchpoint.h:

(WatchpointSet):
(JSC):
(InlineWatchpointSet):
(JSC::InlineWatchpointSet::InlineWatchpointSet):
(JSC::InlineWatchpointSet::~InlineWatchpointSet):
(JSC::InlineWatchpointSet::hasBeenInvalidated):
(JSC::InlineWatchpointSet::isStillValid):
(JSC::InlineWatchpointSet::startWatching):
(JSC::InlineWatchpointSet::notifyWrite):
(JSC::InlineWatchpointSet::isFat):
(JSC::InlineWatchpointSet::fat):
(JSC::InlineWatchpointSet::inflate):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addStructureTransitionCheck):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::isCellConstant):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addWeakReferences):
(JITCompiler):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasStructure):
(Node):
(JSC::DFG::Node::structure):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::emitPutTransitionStub):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITStubs.cpp:

(JSC::JITThunks::tryCachePutByID):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/Structure.h:

(JSC::Structure::transitionWatchpointSetHasBeenInvalidated):
(Structure):
(JSC::Structure::transitionWatchpointSetIsStillValid):
(JSC::Structure::addTransitionWatchpoint):
(JSC::Structure::notifyTransitionFromThisStructure):
(JSC::JSCell::setStructure):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::attemptToWatch):

LayoutTests:

Rubber stamped by Gavin Barraclough.

  • fast/js/dfg-call-method-hit-watchpoint-expected.txt: Added.
  • fast/js/dfg-call-method-hit-watchpoint.html: Added.
  • fast/js/script-tests/dfg-call-method-hit-watchpoint.js: Added.

(Thingy):
(Thingy.prototype.foo):
(callFoo):
(.Thingy.prototype.foo):

15:02 Changeset [120498] by commit-queue@webkit.org

[WK2] Add support for explicit intents
https://bugs.webkit.org/show_bug.cgi?id=89206

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.

Expose the service URL of a Web Intent. This URL
is set for explicit intents.

  • Shared/IntentData.h:

(IntentData):

  • UIProcess/WebIntentData.h:

(WebKit::WebIntentData::service):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchIntent):

15:00 Changeset [120497] by fischman@chromium.org

[chromium] Compositor should be aware of |flipped| status of video textures per-platform
https://bugs.webkit.org/show_bug.cgi?id=89189

Reviewed by James Robinson.

No new tests (sadly HW video decode is still only being tested manually for orientation).

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

14:58 Changeset [120496] by lforschler@apple.com

Versioning.

14:54 Changeset [120495] by rniwa@webkit.org

Source/WebCore: The initial value of text-align should be start instead of -webkit-auto
https://bugs.webkit.org/show_bug.cgi?id=79914

Reviewed by Tony Chang.

Change the initial value of text-align CSS property from -webkit-auto to start as specified in
http://www.w3.org/TR/css3-text/#text-align

In editing, we have to coerce start and end to left and right for now because match-parent,
which is the text-align value of li in UA stylesheet is going to result in the computed values of
left as supposed to start by default, and this causes editing code not being able to remove
text-align: left when computing typing styles and preserving styles.

In the long term, we should detect this specific case and ignore match-parent but that seemed like
too much work to be done in a single patch also because the test result improved because of this change.

This behavior change is covered by existing regression tests.

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(WebCore::getAttributeSetForAccessibilityObject):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): No longer supports TAAUTO since it's identical to TASTART.
(WebCore::CSSPrimitiveValue::operator ETextAlign): Ditto. Parse -webkit-auto as start.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Replace TAAUTO by TASTART.

  • editing/EditingStyle.cpp:

(WebCore):
(WebCore::textAlignResolvingStartAndEnd): Coerce start and end into left and right based on the directionality
for editing. Otherwise, we end up adding lots of text-align: left due to li's UA style rule having match-parent
as the text alignment and its descendent inherits this style. We need to handle it better in the future
since start and left or end and right are semantically different.
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::getPropertiesNotIn):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::textAlignmentForLine): Justified text is aligned at start by default.
(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::startAlignedOffsetForLine):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):

  • rendering/RenderListBox.cpp:

(WebCore::itemOffsetForAlignment):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::updateMarqueeStyle):

  • rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::textAlignmentForLine):
(WebCore::RenderRubyText::adjustInlineDirectionLineBounds):

  • rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

LayoutTests: The default value of text-align should be start instead of -webkit-auto
https://bugs.webkit.org/show_bug.cgi?id=79914

Reviewed by Tony Chang.

Rebaselined tests. For query-text-alignment.html, we now match start and end
with justifyLeft and justifyRight, which appears to be consistent with Firefox for time being.

  • editing/execCommand/query-text-alignment-expected.txt:
  • editing/execCommand/script-tests/query-text-alignment.js:

(queryTextAlignment):
(selectFirstPosition):
(selectMiddleOfHelloWorld):
(runRangeTests):

  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/list-item-text-align.html:
  • fast/css/text-align-initial-expected.html: Renamed from fast/css/text-align-webkit-auto-expected.html.
  • fast/css/text-align-initial.html: Ditto.
  • fast/events/ondrop-text-html-expected.txt:
  • platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac-snowleopard/fast/lists/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/lists/001-vertical-expected.png:
  • platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/fast/lists/001-expected.txt:
  • platform/mac/fast/lists/001-vertical-expected.txt:
  • platform/mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/qt/svg/css/getComputedStyle-basic-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
14:45 Changeset [120494] by jianli@chromium.org

[File API] FileReader should work in sandbox iframe
https://bugs.webkit.org/show_bug.cgi?id=89242

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/files/file-reader-sandbox-iframe.html

  • fileapi/ThreadableBlobRegistry.cpp: Should remove from map for all threads.

(WebCore::ThreadableBlobRegistry::unregisterBlobURL):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canRequest): Check and use cached origin for blob URL first.

LayoutTests:

  • fast/files/file-reader-file-url.html:
  • fast/files/file-reader-sandbox-iframe-expected.txt: Added.
  • fast/files/file-reader-sandbox-iframe.html: Added.
  • fast/files/resources/file-reader-real.html: Renamed from LayoutTests/fast/files/resources/file-reader-file-url-iframe.html.
14:34 Changeset [120493] by jianli@chromium.org

http/tests/fileapi/create-blob-url-from-data-url.html fails
https://bugs.webkit.org/show_bug.cgi?id=89149

Reviewed by Adam Barth.

Convert the test to check if blob URL can be created in a data iframe.

  • http/tests/fileapi/create-blob-url-from-data-url-expected.txt:
  • http/tests/fileapi/create-blob-url-from-data-url.html:
  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
14:21 Changeset [120492] by dbarton@mathscribe.com

Inherit style changes in MathML anonymous renderers
https://bugs.webkit.org/show_bug.cgi?id=88476

Reviewed by Julien Chaffraix.

Source/WebCore:

A RenderObject that is not the main renderer() for a DOM node is called "anonymous".
Standard WebCore practice is to mark such a renderer as isAnonymous(). For example,
RenderBlock::styleDidChange calls propagateStyleToAnonymousChildren to flow style
changes to such children, by re-initializing their styles and then inheriting from
this->style(). A derived class' styleDidChange() can then set non-default style
properties as needed.

This patch implements this standard practice for RenderMathMLBlock classes, except
RenderMathMLOperator which currently uses a RenderLayer, which reportedly means it
should not be isAnonymous(). We also follow common practice and change
isAnonymousBlock() to return false for RenderMathMLBlock classes, since
isAnonymousBlock() is really used by RenderBlock to detect its own anonymous blocks for
wrapping inline children, which RenderBlock then combines or deletes assuming this.

Test: mathml/presentation/style-changed.html, also added to mathml/presentation/over.xhtml

  • rendering/RenderObject.h:

(WebCore::RenderObject::isAnonymousBlock):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::createAnonymousMathMLBlock):
(WebCore::RenderMathMLBlock::renderName):

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::createMathMLOperator):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
(WebCore::RenderMathMLFenced::styleDidChange):

  • rendering/mathml/RenderMathMLFenced.h:
  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::RenderMathMLFraction):
(WebCore::RenderMathMLFraction::fixChildStyle):
(WebCore::RenderMathMLFraction::addChild):
(WebCore::RenderMathMLFraction::styleDidChange):

  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::styleDidChange):

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLSquareRoot.h:
  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::fixScriptsStyle):
(WebCore::RenderMathMLSubSup::addChild):
(WebCore::RenderMathMLSubSup::styleDidChange):

  • rendering/mathml/RenderMathMLSubSup.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::addChild):
(WebCore::RenderMathMLUnderOver::styleDidChange):

  • rendering/mathml/RenderMathMLUnderOver.h:

LayoutTests:

  • mathml/presentation/over.xhtml:
  • mathml/presentation/style-changed-expected.html: Added.
  • mathml/presentation/style-changed.html: Added.
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/fenced-mi-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/mroot-pref-width-expected.txt:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/style-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.txt:
  • platform/mac/mathml/presentation/tokenElements-expected.txt:
  • platform/mac/mathml/presentation/under-expected.png:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:
  • platform/mac/mathml/xHeight-expected.txt:
14:13 Changeset [120491] by atwilson@chromium.org

Unreviewed chromium expectations change.

  • platform/chromium/TestExpectations:
13:48 Changeset [120490] by bbudge@chromium.org

AssociatedURLLoader should allow trusted clients to read all headers, not just exposed ones.
https://bugs.webkit.org/show_bug.cgi?id=89185

Reviewed by Adam Barth.

This change adds an option to turn off whitelist filtering of response headers for CORS loads,
and modifies AssociatedURLLoader check for that before filtering.

  • public/WebURLLoaderOptions.h:

(WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
(WebURLLoaderOptions):

  • src/AssociatedURLLoader.cpp:

(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse):

  • tests/AssociatedURLLoaderTest.cpp:

(WebKit):
(WebKit::TEST_F):

13:36 Changeset [120489] by rniwa@webkit.org

Use testRunner instead of layoutTestController in sputnik's conformance tests
https://bugs.webkit.org/show_bug.cgi?id=89184

Reviewed by Tony Chang.

  • sputnik/Conformance/:
13:25 Changeset [120488] by dpranke@chromium.org

webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
https://bugs.webkit.org/show_bug.cgi?id=89135

Re-land change in r120370 with fix in
PortFactory.get_from_builder_name() that changes BuilderOptions
to an actual optparse.Values object.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.get_option):
(Port.set_option_default):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_setup_environ_for_server_register_cygwin):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(_builder_options):
(PortFactory.get_from_builder_name):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_get_from_builder_name):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker._determine_port_from_expectations_path):

  • Scripts/webkitpy/tool/mocktool.py:

(MockOptions.ensure_value):

13:00 Changeset [120487] by inferno@chromium.org

Unreviewed. Rebaselines for r120477.

  • platform/chromium-linux/fast/forms/formmove3-expected.txt:
  • platform/chromium-win/editing/deleting/delete-3800834-fix-expected.txt:
  • platform/chromium-win/fast/dynamic/011-expected.txt:
  • platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/chromium-win/fast/invalid/001-expected.txt:
  • platform/chromium-win/fast/invalid/003-expected.txt:
  • platform/chromium-win/fast/invalid/004-expected.txt:
  • platform/chromium-win/fast/invalid/007-expected.txt:
  • platform/chromium-win/fast/invalid/019-expected.txt:
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug647-expected.txt:
  • platform/chromium-win/tables/mozilla/other/wa_table_tr_align-expected.txt:
12:53 Changeset [120486] by scheib@chromium.org

Add new Pointer Lock spec webkitRequestPointerLock and webkitExitPointerLock methods.
https://bugs.webkit.org/show_bug.cgi?id=88891

Reviewed by Dimitri Glazkov.

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402

Entering and exiting mouse lock is provided in the new webkitRequestPointerLock and
webkitExitPointerLock methods.

Source/WebCore:

Existing pointer-lock tests updated to use the new methods.

  • dom/Document.cpp:

(WebCore::Document::webkitExitPointerLock):
(WebCore):

  • dom/Document.h:

(Document):

  • dom/Document.idl:
  • dom/Element.cpp:

(WebCore):
(WebCore::Element::webkitRequestPointerLock):

  • dom/Element.h:
  • dom/Element.idl:

LayoutTests:

Existing tests updated to use the new methods. Also, several updated to
support manual testing.

  • pointer-lock/lock-already-locked-expected.txt:
  • pointer-lock/lock-already-locked.html:
  • pointer-lock/mouse-event-delivery-expected.txt:
  • pointer-lock/mouse-event-delivery.html:
  • pointer-lock/pointer-lock-api-expected.txt:
  • pointer-lock/pointer-lock-api.html:
  • pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
12:51 Changeset [120485] by commit-queue@webkit.org

Source/WebCore: [chromium] Add iccjpeg and qcms to chromium port

https://bugs.webkit.org/show_bug.cgi?id=81974

Reviewed by Adam Barth.

Covered by existing layout tests which will be rebaselined.

  • WebCore.gyp/WebCore.gyp: Add qcms to the build.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile. On OSX, return the default RGB profile. Add FIXME to use the user's monitor profile and verify that profile for other platforms.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the two known output color spaces for which the decoder uses a data swizzle. (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For libjpeg-turbo, alpha may be present in the swizzled output color space.

(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
to use during decoding, and ensure we switch to inputing RGBA data to qcms
even if the desired output data is BGRA: outputScanlines() sends BGRA data
to the frame buffer following color correction if needed.
(JPEGImageReader):
(WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
(WebCore::JPEGImageReader::createColorTransform): Create color transform.
Release the existing transform (if any) and assign to the color transform
created from the color profile data.
(WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
transform to each decoded image row.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other setters and getters. (WebCore::PNGImageReader::decodingSizeOnly): Ditto. (WebCore::PNGImageReader::setHasAlpha): Ditto. (WebCore::PNGImageReader::hasAlpha): Ditto. (WebCore::PNGImageReader::interlaceBuffer): Ditto. (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer, used when a color transform is applied to the decoded image pixels. (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer. (WebCore::PNGImageReader::colorTransform): qcms color transform getter. (WebCore::PNGImageReader::createColorTransform): Create color transform. Release the existing transform (if any) and assign to the color transform created from the color profile data. (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color transform to use for decoding. Clear m_colorProfile (not used anymore). (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if a color transform is needed for decoding. Apply color transform to each decoded image row.
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no longer used. Add a FIXME to remove the old implementation. (WebCore::ImageFrame::setStatus): Remove old color correction code.

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-15

Source/WTF: [chromium] Add iccjpeg and qcms to chromium port.
https://bugs.webkit.org/show_bug.cgi?id=81974

Patch by Tony Payne <tpayne@chromium.org> on 2012-06-15

  • wtf/Platform.h: Add Chromium USE defines for ICCJPEG and QCMSLIB

to each Chromium platform, excluding Android.

Reviewed by Adam Barth.

12:41 Changeset [120484] by bbudge@chromium.org

Add bbudge@chromium.org to committers.py

Unreviewed.

Patch by Bill Budge <bbudge@chromium.org> on 2012-06-15

  • Scripts/webkitpy/common/config/committers.py:
12:39 Changeset [120483] by lforschler@apple.com

New Tag.

11:53 Changeset [120482] by tonikitoo@webkit.org

[BlackBerry] Disable WebCore::EventHandler synthesized mouse events during touch scrolling
https://bugs.webkit.org/show_bug.cgi?id=89227
PR #146642

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

Make use of the Settings::supportsMouseDevice setting in order to
prevent mouse move event to fire as a response to a scroll action.
We might still want to dynamically toggle this setting ON, in case for
example of a mouse wheel driven scroll action, but we can revisit it
when it becomes a fully supported/primary use case.

Internally reviewed by Eli Fidler.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

  • Api/WebSettings.cpp:

(WebKit):
(BlackBerry::WebKit::WebSettings::isDeviceSupportsMouseEnabled):
(BlackBerry::WebKit::WebSettings::setDeviceSupportsMouseEnabled):

  • Api/WebSettings.h:
11:43 Changeset [120481] by inferno@chromium.org

Unreviewed. Rebaselines for r120477.

  • fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-mac-leopard/fast/forms/formmove3-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/chromium-mac-leopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
  • platform/chromium-mac/fast/forms/formmove3-expected.txt:
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/efl/TestExpectations:
  • platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
  • platform/gtk/fast/dynamic/011-expected.txt:
  • platform/gtk/fast/forms/formmove3-expected.txt:
  • platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/gtk/fast/invalid/001-expected.txt:
  • platform/gtk/fast/invalid/003-expected.txt:
  • platform/gtk/fast/invalid/004-expected.txt:
  • platform/gtk/fast/invalid/007-expected.txt:
  • platform/gtk/fast/invalid/019-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug647-expected.txt:
  • platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/qt/editing/deleting/delete-3800834-fix-expected.txt:
  • platform/qt/fast/dynamic/011-expected.txt:
  • platform/qt/fast/forms/formmove3-expected.txt:
  • platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/qt/fast/invalid/001-expected.txt:
  • platform/qt/fast/invalid/003-expected.txt:
  • platform/qt/fast/invalid/004-expected.txt:
  • platform/qt/fast/invalid/007-expected.txt:
  • platform/qt/fast/invalid/019-expected.txt:
  • platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug647-expected.txt:
  • platform/qt/tables/mozilla/other/wa_table_tr_align-expected.txt:
11:39 Changeset [120480] by simon.fraser@apple.com

Rebaseline some tests after r120411.

  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/range/input-appearance-range-expected.txt:
  • platform/mac/fast/multicol/client-rects-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
11:37 Changeset [120479] by fmalita@chromium.org

Unreviewed chromium rebaseline for r120467.

Patch by Florin Malita <fmalita@chromium.org> on 2012-06-15

  • platform/chromium-linux-x86/svg/filters/feLighting-crash-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feLighting-crash-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feLighting-crash-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-mac/svg/filters/feLighting-crash-expected.png:
  • platform/chromium-win-vista/svg/filters/feLighting-crash-expected.png:
  • platform/chromium-win-xp/svg/filters/feLighting-crash-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-win/svg/filters/feLighting-crash-expected.png:
  • platform/chromium/TestExpectations:
10:59 Changeset [120478] by commit-queue@webkit.org

Remove volume thumb for videos without audio track.
https://bugs.webkit.org/show_bug.cgi?id=89093

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-15
Reviewed by Eric Carlson.

No new tests, since this was already tested in media/video-no-audio.html.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaMuteButton):
Change mute button when there is no audio or no source file.
(WebCore::paintMediaVolumeSlider):
Set volume slider to 0 when there is no audio or no source file.
(WebCore::paintMediaVolumeSliderThumb):
Don't paint the volume slider thumb when there is no audio or no source file.

10:57 Changeset [120477] by inferno@chromium.org

Cleanup empty anonymous block continuation.
https://bugs.webkit.org/show_bug.cgi?id=74976

Reviewed by Julien Chaffraix.

Source/WebCore:

Fix rendering on http://docs.google.com/demo.

Test: fast/inline/inline-empty-block-continuation-remove.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild): If we are removing our last child,
and are an anonymous block which is part of a continuation chain, then
we need to first fix our continuation chain by setting our previous
continuation renderer to point to the next continuation renderer. Then,
we reset our continuation pointer and destroy ourselves. Since we no
longer are part of continuation chain, we will be removed and previous
and next anonymous block will be merged automatically.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::previousInPreOrder): add an argument to previousInOrder

  • stayWithin.

(WebCore):

  • rendering/RenderObject.h:

(RenderObject):

LayoutTests:

  • fast/inline/inline-empty-block-continuation-remove-expected.html: Added.
  • fast/inline/inline-empty-block-continuation-remove.html: Added.

and a bunch of rebaselines in existing tests.

10:47 Changeset [120476] by zandobersek@gmail.com

Clean up the flaky tests section in Gtk's TestExpectations file. Remove
flakiness expectations for tests that have been consistently passing and
move expectations for tests that have been consistently failing under
the failing tests section, changing the expectations to represent a constant
expected failure for that test.

Rubber-stamped by Philippe Normand.

  • platform/gtk/TestExpectations:
10:16 Changeset [120475] by commit-queue@webkit.org

Web Inspector: Move FileSystem frame management from frontend to backend
https://bugs.webkit.org/show_bug.cgi?id=89190

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: http/tests/inspector/filesystem/read-directory.html

  • inspector/Inspector.json:
  • inspector/InspectorFileSystemAgent.cpp:

(WebCore::InspectorFileSystemAgent::readDirectory):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::scriptExecutionContextForOrigin):
(WebCore):

  • inspector/InspectorFileSystemAgent.h:

(WebCore):
(InspectorFileSystemAgent):

LayoutTests:

  • http/tests/inspector/filesystem/read-directory.html:
10:13 Changeset [120474] by apavlov@chromium.org

Unreviewed, build fix after r120469.

  • css/CSSPropertySourceData.h:

(WebCore):

10:10 Changeset [120473] by zhajiang@rim.com

[BlackBerry] Certain web pages (i.e., http://www.cloudtweaks.com/) are allowed to be wider than the screen
https://bugs.webkit.org/show_bug.cgi?id=89211

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 135215
Make simpler rules for zoom to fit scale:

  • Zoom to fit horizontally first without clamping the contents width.
  • Zoom to fit vertically instead without clamping the contents height if the horizontal zoom to fit can cause a grey area below the web page. Get rid of the virtual viewport guard as there may be cases that zooming can cause a grey area without a virtual viewport.
  • Clamp the scale by the minimum zoom to fit scale 0.25 and apply this rule to image documents as well. This minimum scale can be changed if there is a better vaule in the future.

In this way, we can get rid of the issue that many web pages don't fit
the screen.

Reviewed internally by Arvid Nilsson.

  • Api/WebPage.cpp:

(WebKit):
(BlackBerry::WebKit::WebPagePrivate::zoomToFitScale):

09:57 Changeset [120472] by commit-queue@webkit.org

Web Inspector: Add FileSystemRequestManager and FileSystemDispatcher
https://bugs.webkit.org/show_bug.cgi?id=89191

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototoype._requestId):
(WebInspector.FileSystemRequestManager.prototoype.readDirectory):
(WebInspector.FileSystemRequestManager.prototoype._didReadDirectory):
(WebInspector.FileSystemDispatcher):
(WebInspector.FileSystemDispatcher.prototype.gotFileSystemRoot):
(WebInspector.FileSystemDispatcher.prototype.didReadDirectory):

09:50 Changeset [120471] by pfeldman@chromium.org

Web Inspector: extension's Resource.getContent always returns original revision.
https://bugs.webkit.org/show_bug.cgi?id=89219

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Fetching proper content from the UISourceCode now.

  • inspector/front-end/DebuggerResourceBinding.js:

(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerResourceBinding.prototype.setContent):

  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping.prototype._debuggerReset):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onGetResourceContent):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/Resource.js:

(WebInspector.Resource.prototype.isHidden):
(WebInspector.Resource.prototype.uiSourceCode):
(WebInspector.Resource.prototype.setUISourceCode):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

LayoutTests:

  • inspector/extensions/extensions-resources-expected.txt:
  • inspector/extensions/extensions-resources.html:
09:48 Changeset [120470] by loislo@chromium.org

Web Inspector: CRASH when DebuggerAgent.setBreakpoint was called twice for the same location.
https://bugs.webkit.org/show_bug.cgi?id=89225

Reviewed by Pavel Feldman.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpoint):

09:36 Changeset [120469] by apavlov@chromium.org

Web Inspector: CSSParser::parseSheet() should provide ready-to-use source data
https://bugs.webkit.org/show_bug.cgi?id=88646

Reviewed by Antti Koivisto.

This change moves the post-processing step from InspectorStyleSheet into CSSParser, so that
CSSParser::parseSheet() will return a ready-to-use list with style rule source code data.
Also, universal data structures are introduced, which allow for the full rule source data tree building.

No new tests, as this is a refactoring.

  • css/CSSParser.cpp: Use universal data structures, which can be used for building the full rule tree.

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::parseSheet): Return ready-to-use source code data entries rather than an intermediate structure.
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::addNewRuleToSourceTree):
(WebCore):
(WebCore::CSSParser::popRuleData):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::fixUnparsedPropertyRanges): Moved in from InspectorStyleSheet.
(WebCore::CSSParser::markSelectorListStart):
(WebCore::CSSParser::markSelectorListEnd):
(WebCore::CSSParser::markRuleBodyStart):
(WebCore::CSSParser::markRuleBodyEnd):
(WebCore::CSSParser::markPropertyEnd):

  • css/CSSParser.h:

(CSSParser):
(WebCore::CSSParser::resetPropertyRange): Renamed.
(WebCore::CSSParser::isExtractingSourceData): A convenience check.

  • css/CSSPropertySourceData.h: Introduce the RuleSourceDataList typedef.

(WebCore):

  • inspector/InspectorStyleSheet.cpp: Make use of RuleSourceDataList and follow the CSSParser::parse*() API changes.

(ParsedStyleSheet::sourceData):
(ParsedStyleSheet):
(ParsedStyleSheet::setSourceData):
(WebCore::InspectorStyleSheet::ensureSourceData): Remove source data postprocessing, follow the new parseSheet() API.

  • inspector/InspectorStyleSheet.h:

(WebCore::InspectorCSSId::InspectorCSSId): Drive-by: uninitialized field fix.
(WebCore::InspectorStyleProperty::InspectorStyleProperty): Ditto.
(InspectorStyleSheet):

09:03 Changeset [120468] by pfeldman@chromium.org

Web Inspector: Long frame urls make all/errors/warnings/logs buttons inaccessible.
https://bugs.webkit.org/show_bug.cgi?id=88907

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/inspector.css:

(#console-context):

08:56 Changeset [120467] by fmalita@chromium.org

Specular light filters produce dark results
https://bugs.webkit.org/show_bug.cgi?id=89116

Reviewed by Dirk Schulze.

Source/WebCore:

Tests: svg/filters/feSpecularLight-premultiplied-expected.svg

svg/filters/feSpecularLight-premultiplied.svg

Per spec (http://www.w3.org/TR/SVG/filters.html#feSpecularLightingElement),
light filters should operate on pre-multiplied RGBA. Currently, the results
are stored in the unmultiplied buffer but the alpha channel is calculated
for premultiplied values (which causes a darkening of the result upon the
subsequent unmultiplied->premultiplied conversion). This patch updates
FELighting to generate premultiplied results.

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplySoftware):

LayoutTests:

  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
  • platform/chromium-linux/svg/filters/feLighting-crash-expected.png:
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
  • svg/filters/feSpecularLight-premultiplied-expected.svg: Added.
  • svg/filters/feSpecularLight-premultiplied.svg: Added.
08:56 Changeset [120466] by ossy@webkit.org

Unreviewed style fix after r120351.

  • BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

(body.interface):

08:51 Changeset [120465] by caseq@chromium.org

Web Inspector: incorrect filtering of async timeline events
https://bugs.webkit.org/show_bug.cgi?id=89214

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane.prototype.accept):

08:37 Changeset [120464] by schenney@chromium.org

SVG Composite of Offset filters incorrectly clips
https://bugs.webkit.org/show_bug.cgi?id=77660

Reviewed by Dirk Schulze.

Source/WebCore:

Prior to this patch, when a group of filtered objects was used as input to another filter,
the filter only operated on the stroke boundary of the group, and hence excluded the results
of filtering elements within the group, or extraneously included regions clipped from the
elements in the group.

This patch modifies the strokeBoundingBox of SVG container elements to
be the union of the repaint rects for the children. This modifes the
results returned for sizing filters and for absoluteRects, which will cause
inline layout around the group to factor in the resources applied to
the group's children.

The relevant spec entry is this, in Section 3.7 of the SVG 1.1 spec: "...the result must be
as though the paint operations had been applied to an intermediate canvas initialized to
transparent black, of a size determined by the rules given in Filter Effects then filtered
by the processes defined in Filter Effects." In this case the "paint operations" is implied
to include the result of applying "paint" but no resources to the group, which in turn would
have resources applied to the children of the group. This makes the most sense, as the current,
incorrect behavior makes it extremely diffucult to understand the actions of filters on
groups of filtered content.

Tests: svg/filters/container-with-filters-expected.svg

svg/filters/container-with-filters.svg

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::updateCachedBoundaries):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::updateCachedBoundaries):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

LayoutTests:

  • svg/filters/container-with-filters-expected.svg: Added.
  • svg/filters/container-with-filters.svg: Added.
08:29 Changeset [120463] by commit-queue@webkit.org

[BlackBerry] Remove BackingStoreClient::scrollsHorizontally/scrollsVeritically()
https://bugs.webkit.org/show_bug.cgi?id=89210

Patch by Yong Li <yoli@rim.com> on 2012-06-15
Reviewed by Antonio Gomes.

Remove BackingStoreClient::scrollsHorizontally()/scrollsVeritically(), because
calling them is neither nessary nor safe.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::blitHorizontalScrollbar):
(BlackBerry::WebKit::BackingStorePrivate::blitVerticalScrollbar):

  • WebKitSupport/BackingStoreClient.cpp:
  • WebKitSupport/BackingStoreClient.h:

(BackingStoreClient):

08:19 Changeset [120462] by ddkilzer@apple.com

Sort ENABLE(INSPECTOR) section of WebCore.exp.in

  • WebCore.exp.in: Sort ENABLE(INSPECTOR) symbols.
08:19 Changeset [120461] by ddkilzer@apple.com

Remove duplicate symbol from WebCore.exp.in

  • WebCore.exp.in: Remove duplicate symbol for:

WebCore::Range::textQuads(WTF::Vector<WebCore::FloatQuad, 0ul>&, bool, WebCore::Range::RangeInFixedPosition*) const

08:18 Changeset [120460] by fmalita@chromium.org

[Chromium] Unreviewed debug build fix for r120457

Patch by Florin Malita <fmalita@chromium.org> on 2012-06-15

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toYUVVideoDrawQuad):

08:15 Changeset [120459] by pfeldman@chromium.org

Not reviewed: remove redundant Mac-specific style rule from inspector front-end.

  • inspector/front-end/helpScreen.css:
08:11 Changeset [120458] by pfeldman@chromium.org

Web Inspector: fix help close button appearance on Mac
https://bugs.webkit.org/show_bug.cgi?id=89208

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/helpScreen.css:

(.help-close-button):
(body.platform-mac .help-close-button):
(body.platform-mac .help-window-main .tabbed-pane-header-contents):

07:34 Changeset [120457] by danakj@chromium.org

[chromium] Create a CCYUVVideoDrawQuad and remove the now-unused generic CCVideoDrawQuad
https://bugs.webkit.org/show_bug.cgi?id=88828

Reviewed by Adrienne Walker.

The CCVideoDrawQuad is now only used for YUV video, so we remove the
class and replace it with CCYUVVideoDrawQuad. This class holds what is
needed to draw a YUV video frame.

No new tests, no change in behaviour.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toYUVVideoDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCVideoDrawQuad.cpp.

(WebCore):
(WebCore::CCYUVVideoDrawQuad::create):
(WebCore::CCYUVVideoDrawQuad::CCYUVVideoDrawQuad):

  • platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCVideoDrawQuad.h.

(WebCore):
(CCYUVVideoDrawQuad):
(WebCore::CCYUVVideoDrawQuad::yPlane):
(WebCore::CCYUVVideoDrawQuad::uPlane):
(WebCore::CCYUVVideoDrawQuad::vPlane):

07:28 Changeset [120456] by loislo@chromium.org

Web Inspector: CRASH: getProfile is crashing for unknown profiles.
https://bugs.webkit.org/show_bug.cgi?id=89202

Source/WebCore:

agents' functions have to set a value to errorString if it can't assign values to the mandatory out arguments.

Reviewed by Pavel Feldman.

Test: inspector/profiler/heap-snapshot-get-profile-crash.html

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfile):

LayoutTests:

Reviewed by Pavel Feldman.

  • inspector/profiler/heap-snapshot-get-profile-crash-expected.txt: Added.
  • inspector/profiler/heap-snapshot-get-profile-crash.html: Added.
07:26 Changeset [120455] by ossy@webkit.org

master.cfg cleanup, remove unnecessary workaround
https://bugs.webkit.org/show_bug.cgi?id=88994

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

07:22 Changeset [120454] by dpranke@chromium.org

webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
https://bugs.webkit.org/show_bug.cgi?id=88581

Reviewed by Adam Barth.

Make sure we only optimize the suffixes we rebaselined during
rebaseline-expectations, and not all suffixes for a test.
While optimizing is somewhere between harmless and good, it's also confusing :)

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineExpectations._rebaseline_port):
(RebaselineExpectations.execute):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
07:17 Changeset [120453] by commit-queue@webkit.org

[BlackBerry] media volume slider in wrong position (master_38 regression)
https://bugs.webkit.org/show_bug.cgi?id=89165

Patch by Max Feil <mfeil@rim.com> on 2012-06-15
Reviewed by Antonio Gomes.

Due to upstream simplification of the volume slider (webkit.org
bug 82150) it now appears in the wrong location below the
media controls. The programmatic controls sizing we do in
RenderThemeBlackBerry.cpp relies on absolute positioning of the
volume slider container, so the best way to fix this is to set
the bottom offset.

No new tests since this is a regression fix. BlackBerry media
controls are manually tested.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):

07:14 Changeset [120452] by ossy@webkit.org

Update builder.html template for newer buildmaster
https://bugs.webkit.org/show_bug.cgi?id=89207

Rebasing builder.html template from v0.8.3 to v0.8.6p1.

Reviewed by Zoltan Herczeg.

  • BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
07:10 Changeset [120451] by tkent@chromium.org

[Chromium] Rebaseline for type=range tests.
https://bugs.webkit.org/show_bug.cgi?id=89067

  • platform/chromium-linux/fast/forms/range/input-appearance-range-expected.txt: Added.
07:07 Changeset [120450] by rniwa@webkit.org

Use testRunner instead of layoutTestController in layout test resources
https://bugs.webkit.org/show_bug.cgi?id=89182

Reviewed by Kent Tamura.

  • resources/dump-as-markup.js:

(Markup.waitUntilDone):
(Markup.notifyDone):

  • resources/magnitude-perf.js:

(Magnitude._run):
(Magnitude._runIteration):
(Magnitude):

  • resources/testharnessreport.js:
06:58 Changeset [120449] by pfeldman@chromium.org

Not reviewed: remove garbage line from inspector view in docked-to-right mode.

  • inspector/front-end/inspectorCommon.css:

(body.docked.dock-to-right.docked):
(body.docked.dock-to-right.inactive):

06:54 Changeset [120448] by zandobersek@gmail.com

Unreviewed GTK gardening, adding TEXT expectation for
editing/spelling/grammar-edit-word.html after r120423.

  • platform/gtk/TestExpectations:
06:36 Changeset [120447] by ossy@webkit.org

Buildfix for !ENABLE(BLOB) platforms after r120433.
https://bugs.webkit.org/show_bug.cgi?id=78648

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-15
Reviewed by Csaba Osztrogonác.

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::ThreadableBlobRegistry::registerBlobURL):

06:27 Changeset [120446] by tkent@chromium.org

[Chromium] Rebaseline for type=range tests.
https://bugs.webkit.org/show_bug.cgi?id=89067

  • fast/forms/range/range-thumb-height-percentage-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/range/range-thumb-height-percentage-expected.txt.
  • platform/chromium-linux/fast/forms/range/range-thumb-height-percentage-expected.txt: Renamed from LayoutTests/platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt.
  • platform/chromium-linux/fast/forms/range/slider-padding-expected.txt: Added.
  • platform/chromium-linux/fast/forms/range/slider-thumb-shared-style-expected.txt: Added.
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.png:
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt:
  • platform/chromium/TestExpectations:
06:06 Changeset [120445] by ossy@webkit.org

[Qt] Gardening. Skip a failing test. After r120423.
https://bugs.webkit.org/show_bug.cgi?id=89199

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-06-15
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
05:45 Changeset [120444] by commit-queue@webkit.org

[chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-06-15
Reviewed by James Robinson.

Source/WebCore:

This patch enables scrolling child layers in the compositor thread.
Scroll deltas are accumulated for each scrolled CCLayerImpl and
synchronized to the main thread.

If a layer has no room to scroll in a given direction, one of its
ancestor layers is scrolled instead if possible.

Layer hit testing code by Shawn Singh.

Added new unit tests to verify layer scrolling behavior:

CCLayerTreeHostCommonTest.verifySubtreeSearch
CCLayerTreeHostImplTest.clearRootRenderSurfaceAndScroll
CCLayerTreeHostImplTest.inhibitScrollAndPageScaleUpdatesWhileAnimatingPageScale
CCLayerTreeHostImplTest.inhibitScrollAndPageScaleUpdatesWhilePinchZooming
CCLayerTreeHostImplTest.replaceTreeWhileScrolling
CCLayerTreeHostImplTest.scrollBeforeRedraw
CCLayerTreeHostImplTest.scrollBlockedByContentLayer
CCLayerTreeHostImplTest.scrollChildAndChangePageScaleOnMainThread
CCLayerTreeHostImplTest.scrollChildBeyondLimit
CCLayerTreeHostImplTest.scrollChildCallsCommitAndRedraw
CCLayerTreeHostImplTest.scrollEventBubbling
CCLayerTreeHostImplTest.scrollMissesBackfacingChild
CCLayerTreeHostImplTest.scrollMissesChild
CCLayerTreeHostImplTest.scrollNonCompositedRoot
CCLayerTreeHostImplTest.scrollRootAndChangePageScaleOnImplThread
CCLayerTreeHostImplTest.scrollRootAndChangePageScaleOnMainThread
CCLayerTreeHostImplTest.scrollRootIgnored
CCLayerTreeHostImplTest.scrollWithoutRootLayer
CCLayerTreeHostTestScrollChildLayer
WebCompositorInputHandlerImplTest.gestureScrollOnMainThread

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setMaxScrollPosition):
(WebCore):
(WebCore::LayerChromium::scrollBy):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(LayerChromiumScrollDelegate):
(WebCore::LayerChromiumScrollDelegate::~LayerChromiumScrollDelegate):
(LayerChromium):
(WebCore::LayerChromium::maxScrollPosition):
(WebCore::LayerChromium::scrollable):
(WebCore::LayerChromium::setLayerScrollDelegate):

  • platform/graphics/chromium/cc/CCInputHandler.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::tryScroll):
(WebCore):
(WebCore::sortLayers):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::findFirstScrollableLayer):
(WebCore):
(WebCore::CCLayerTreeHost::applyScrollAndScale):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):
(WebCore):
(WebCore::CCLayerTreeHostCommon::findLayerInSubtree):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::findRootScrollLayer):
(WebCore):
(WebCore::findScrollLayerForContentLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::detachLayerTree):
(WebCore::adjustScrollsForPageScaleChange):
(WebCore::applyPageScaleDeltaToScrollLayers):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::clearCurrentlyScrollingLayer):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::collectScrollDeltas):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
(WebCore::CCLayerTreeHostImpl::animateLayers):
(WebCore::CCLayerTreeHostImpl::clearRenderSurfaces):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(FrameData):
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::rootScrollLayer):

Source/WebKit/chromium:

New unit tests to verify layer scrolling behavior and the associated
utility functions.

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF::MockContentLayerDelegate::paintContents):
(CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginTest):
(WTF::CCLayerTreeHostTestScrollChildLayer::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::afterTest):
(WTF):
(WTF::TEST_F):

  • tests/WebCompositorInputHandlerImplTest.cpp:

(WebKit::TEST_F):

05:31 Changeset [120443] by ossy@webkit.org

Add ForceScheduler to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=88982

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

05:16 Changeset [120442] by commit-queue@webkit.org

[EFL][WK2] Add title support to Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=89095

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add a method to get the title of the main frame in
an Ewk_View. A "title,changed" signal is now emitted
on the view to notify clients that the main frame
title was changed.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_del):
(ewk_view_base_add):
(ewk_view_title_get):
(ewk_view_title_changed):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_loader_client.cpp: Added.

(didReceiveTitleForFrame):
(ewk_view_loader_client_attach):

  • UIProcess/API/efl/ewk_view_loader_client_private.h: Added.
  • UIProcess/API/efl/ewk_view_private.h:

Tools:

Update the MiniBrowser so it listens for the "title,change"
signal on the view and keeps the browser window title
up-to-date.

  • MiniBrowser/efl/main.c:

(on_title_changed):
(browserCreate):

04:48 Changeset [120441] by commit-queue@webkit.org

[EFL] Gardening after r120411
https://bugs.webkit.org/show_bug.cgi?id=89194

Unreviewed EFL gardening, updating baselines after r120411.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-15

  • platform/efl/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.png:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.png:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/range/input-appearance-range-expected.png:
  • platform/efl/fast/forms/range/input-appearance-range-expected.txt:
  • platform/efl/fast/forms/range/range-thumb-height-percentage-expected.png:
  • platform/efl/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/efl/fast/forms/range/slider-padding-expected.png:
  • platform/efl/fast/forms/range/slider-padding-expected.txt:
  • platform/efl/fast/forms/range/slider-thumb-shared-style-expected.png:
  • platform/efl/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/efl/fast/forms/range/slider-thumb-stylability-expected.txt:
  • platform/efl/fast/multicol/client-rects-expected.png:
  • platform/efl/fast/multicol/client-rects-expected.txt:
  • platform/efl/fast/repaint/slider-thumb-drag-release-expected.txt:
04:44 Changeset [120440] by morrita@google.com

Unreviewed expectation rebaselining.

  • platform/chromium-linux-x86/fast/multicol/client-rects-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/multicol/client-rects-expected.png.
  • platform/chromium-linux-x86/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
  • platform/chromium-linux/fast/multicol/client-rects-expected.png:
  • platform/chromium-linux/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
  • platform/chromium-mac-snowleopard/fast/multicol/client-rects-expected.txt: Added.
  • platform/chromium-win-vista/fast/multicol/client-rects-expected.png: Added.
  • platform/chromium-win-vista/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
  • platform/chromium-win-xp/fast/multicol/client-rects-expected.png: Added.
  • platform/chromium-win-xp/fast/multicol/client-rects-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/multicol/client-rects-expected.txt.
  • platform/chromium-win/fast/multicol/client-rects-expected.png:
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
04:41 Changeset [120439] by tkent@chromium.org

[Chromium] Rebaseline for type=range tests.
https://bugs.webkit.org/show_bug.cgi?id=89067

  • platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.
  • platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-padding-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/chromium-win/fast/repaint/slider-thumb-float-expected.txt: Added.
  • platform/chromium/TestExpectations:
04:22 Changeset [120438] by ossy@webkit.org

[Qt] Gardening after r120411. Updated baselines of 7 tests because of a color property change.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-06-15
Reviewed by Csaba Osztrogonác.

  • platform/qt/fast/dom/HTMLInputElement/input-slider-update-expected.png:
  • platform/qt/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/qt/fast/forms/box-shadow-override-expected.png:
  • platform/qt/fast/forms/box-shadow-override-expected.txt:
  • platform/qt/fast/forms/range/input-appearance-range-expected.txt:
  • platform/qt/fast/forms/range/range-thumb-height-percentage-expected.png: Added.
  • platform/qt/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/qt/fast/forms/range/slider-padding-expected.png:
  • platform/qt/fast/forms/range/slider-padding-expected.txt:
  • platform/qt/fast/multicol/client-rects-expected.png: Added.
  • platform/qt/fast/multicol/client-rects-expected.txt:
  • platform/qt/fast/repaint/slider-thumb-drag-release-expected.png:
  • platform/qt/fast/repaint/slider-thumb-drag-release-expected.txt:
03:58 Changeset [120437] by commit-queue@webkit.org

[WK2][EFL] Implement navigation back/forward in Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=89173

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add API for Ewk_View to ask the main frame to navigate backwards
or forwards in history. Also add API to query if such navigation
is possible.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_back):
(ewk_view_forward):
(ewk_view_back_possible):
(ewk_view_forward_possible):

  • UIProcess/API/efl/ewk_view.h:

Tools:

Implement navigation back / forward in MiniBrowser. Use
'F1' to navigate back and 'F2' to navigate forward.

  • MiniBrowser/efl/main.c:

(on_key_down):

03:32 Changeset [120436] by tkent@chromium.org

[Chromium] Update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89067

  • platform/chromium/TestExpectations:

Mark some tests for type=range FAIL until all bots have the new results.

03:03 Changeset [120435] by tkent@chromium.org

[Chromium] Fix a syntax error of TestExpectations.

  • platform/chromium/TestExpectations:
02:58 Changeset [120434] by commit-queue@webkit.org

Unreviewed, rolling out r120404.
http://trac.webkit.org/changeset/120404
https://bugs.webkit.org/show_bug.cgi?id=89193

This patch breaks [BlackBerry]'s text selection handles moving
in editable elements. (Requested by Sean1 on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-15

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

02:57 Changeset [120433] by jianli@chromium.org

FileReader is dysfunctional in documents with "null" origin string
https://bugs.webkit.org/show_bug.cgi?id=78648

Reviewed by Adam Barth.

Source/WebCore:

The fix is to keep in-memory map from blob URL to SecurityOrigin for the
unique origin case.

Test: fast/files/file-reader-file-url.html

  • fileapi/Blob.cpp:

(WebCore::Blob::Blob):

  • fileapi/BlobURL.cpp:

(WebCore::BlobURL::getOrigin): Return the origin string embeded in the blob URL.
(WebCore):
(WebCore::BlobURL::createBlobURL): Remove the check for null origin string since it is handled now.

  • fileapi/BlobURL.h:

(BlobURL):

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore):
(WebCore::originMap): Thread-specific in-memory map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::registerBlobURL): Add the map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::unregisterBlobURL): Remove the map for the unregistered blob URL.
(WebCore::ThreadableBlobRegistry::getCachedOrigin): Retrieve the origin associated with the blob URL.

  • fileapi/ThreadableBlobRegistry.h:

(WebCore):
(ThreadableBlobRegistry):

  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • page/SecurityOrigin.cpp:

(WebCore::getCachedOrigin): Return the cached origin for the blob URL if it exists.
(WebCore):
(WebCore::SecurityOrigin::create): Call getCachedOrigin to get the cached origin first.

LayoutTests:

  • fast/files/file-reader-file-url-expected.txt: Added.
  • fast/files/file-reader-file-url.html: Added.
  • fast/files/resources/file-reader-file-url-iframe.html: Added.
02:53 Changeset [120432] by yosin@chromium.org

[Forms] Move search field related code to RenderSearchField from RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=88980

Reviewed by Kent Tamura.

This patch moves search field related methods in RenderTextControlSingleLine
to new class RenderSearchField and changes related classes to use
RenderSearchField.

No new tests. This patch doesn't change behavior.

  • CMakeLists.txt: Added new file RenderSearchField.cpp
  • GNUmakefile.list.am: Added new file RenderSearchField.cpp and RenderSearchField.h
  • Target.pri: ditto
  • WebCore.gypi: ditto
  • WebCore.vcproj/WebCore.vcproj: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::subtreeHasChanged): Call RenderSearchField::updateCancelButtonVisibility
(WebCore::HTMLInputElement::addSearchResult): Changed to call InputType::addSearchResult.

  • html/InputType.cpp:

(WebCore::InputType::addSearchResult): Added.

  • html/InputType.h:
  • html/SearchInputType.cpp:

(WebCore::SearchInputType::addSearchResult): Moved from HTMLInputElement.
(WebCore::SearchInputType::createRenderer): Added to create RenderSearchField.

  • html/SearchInputType.h:
  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::defaultEventHandler): Use RenderSearchField instead of RenderTextControlSingleLine.

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create): Got rid isSearchField() guard for addSearchResult().

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::RenderSearchField): Renamed to RenderSearchField.
(WebCore::RenderSearchField::~RenderSearchField): ditto
(WebCore::RenderSearchField::resultsButtonElement): ditto
(WebCore::RenderSearchField::cancelButtonElement): ditto
(WebCore::RenderSearchField::addSearchResult): ditto
(WebCore::RenderSearchField::showPopup): ditto
(WebCore::RenderSearchField::hidePopup): ditto
(WebCore::RenderSearchField::computeControlHeight): Added.
(WebCore::RenderSearchField::updateFromElement): Moved search field related code from RenderTextControlSingleLine.
(WebCore::RenderSearchField::updateCancelButtonVisibility): Renamed to RenderSearchField.
(WebCore::RenderSearchField::visibilityForCancelButton): ditto
(WebCore::RenderSearchField::autosaveName): ditto
(WebCore::RenderSearchField::valueChanged): ditto
(WebCore::RenderSearchField::itemText): ditto
(WebCore::RenderSearchField::itemLabel): ditto
(WebCore::RenderSearchField::itemIcon): ditto
(WebCore::RenderSearchField::itemIsEnabled): ditto
(WebCore::RenderSearchField::itemStyle): ditto
(WebCore::RenderSearchField::menuStyle): ditto
(WebCore::RenderSearchField::clientInsetLeft): ditto
(WebCore::RenderSearchField::clientInsetRight): ditto
(WebCore::RenderSearchField::clientPaddingLeft): ditto
(WebCore::RenderSearchField::clientPaddingRight): ditto
(WebCore::RenderSearchField::listSize): ditto
(WebCore::RenderSearchField::selectedIndex): ditto
(WebCore::RenderSearchField::popupDidHide): ditto
(WebCore::RenderSearchField::itemIsSeparator): ditto
(WebCore::RenderSearchField::itemIsLabel): ditto
(WebCore::RenderSearchField::itemIsSelected): ditto
(WebCore::RenderSearchField::setTextFromItem): ditto
(WebCore::RenderSearchField::fontSelector): ditto
(WebCore::RenderSearchField::hostWindow): ditto
(WebCore::RenderSearchField::createScrollbar): ditto
(WebCore::RenderSearchField::computeHeightLimit): Added.
(WebCore::RenderSearchField::centerContainerIfNeeded): Added.

  • rendering/RenderSearchField.h:

(WebCore::toRenderSearchField): Added.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Remove search field related code.
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): ditto.
(WebCore::RenderTextControlSingleLine::computeHeightLimit): Added.
(WebCore::RenderTextControlSingleLine::layout): Use new methods for removing isSearchField.
(WebCore::RenderTextControlSingleLine::computeControlHeight): Added.
(WebCore::RenderTextControlSingleLine::updateFromElement): Remove search field related code.

  • rendering/RenderTextControlSingleLine.h:

(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::centerContainerIfNeeded): Added.
(WebCore::RenderTextControlSingleLine::containerElement): Exposed for RenderSearchField.
(WebCore::RenderTextControlSingleLine::innerBlockElement): Exposed for RenderSearchField.

  • rendering/RenderingAllInOne.cpp: Added RenderSearchField.cpp
02:41 Changeset [120431] by tkent@chromium.org

[Chromium] Update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89067

  • platform/chromium-mac/fast/multicol/client-rects-expected.txt:
02:33 Changeset [120430] by commit-queue@webkit.org

Web Inspector: LayoutTest http/tests/inspector/filesystem/* should clean up FileSystem after test.
https://bugs.webkit.org/show_bug.cgi?id=89066

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.

  • http/tests/inspector/filesystem/filesystem-test.js:

(initialize_FileSystemTest.InspectorTest.clearFileSystem):
(dispatchCallback):
(createDirectory.gotFileSystem):
(createDirectory):
(createFile.gotFileSystem):
(clearFileSystem.gotRoot):
(clearFileSystem.gotRoot.removeAll):
(clearFileSystem.onError):

  • http/tests/inspector/filesystem/read-directory.html:
02:30 Changeset [120429] by tkent@chromium.org

[Chromium] Update TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89192

  • platform/chromium/TestExpectations:

Failulre of platform/chromium/accessibility/add-to-menu-list-crashes.html is expected.

02:24 Changeset [120428] by commit-queue@webkit.org

[EFL] EFL's LayoutTestController does not support titleTextDirection
https://bugs.webkit.org/show_bug.cgi?id=86475

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-15
Reviewed by Hajime Morita.

Source/WebKit/efl:

Emit the "title,changed" signal even if the title direction has
changed but not its text.

  • ewk/ewk_frame.cpp:

(ewk_frame_title_set):

Tools:

Add titleTextDirection getter and setter to LayoutTestController and
expose its value to JavaScript.
Update the titleTextDirection value from EFL's "title,changed"
callback in DumpRenderTree.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(getTitleTextDirectionCallback):
(LayoutTestController::staticValues):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::titleTextDirection):
(LayoutTestController::setTitleTextDirection):
(LayoutTestController):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onFrameTitleChanged):

LayoutTests:

Unskip title-directionality tests now that EFL's LayoutTestController
supports titleTextDirection.

  • platform/efl/TestExpectations:
02:20 Changeset [120427] by commit-queue@webkit.org

[EFL][WK2] Implement reload / stop in Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=89168

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add API on the Ewk_View to reload the main frame
and to stop the current load.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_reload):
(ewk_view_stop):

  • UIProcess/API/efl/ewk_view.h:

Tools:

Implement view reload / stop loading in MiniBrowser.
Use 'F5' for reload and 'F6' for stopping the load.

  • MiniBrowser/efl/main.c:

(on_key_down):
(browserCreate):

02:07 Changeset [120426] by eae@chromium.org

Unreviewed chromium windows rebaseline.

  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
01:55 Changeset [120425] by tkent@chromium.org

A followup for r120413.
https://bugs.webkit.org/show_bug.cgi?id=89187

We need to update fast/dom/htmlcollection-non-html.html for
HTMLSelectElement::selectedOptions removal.

  • fast/dom/htmlcollection-non-html-expected.txt:
  • fast/dom/htmlcollection-non-html.html:
  • platform/gtk/TestExpectations:
01:45 Changeset [120424] by zandobersek@gmail.com

Unreviewed GTK gardening, adding a CRASH PASS expectation for
storage/websql/quota-tracking.html which crashes intermittently
on release builds.

  • platform/gtk/TestExpectations:
01:41 Changeset [120423] by hbono@chromium.org

Allow platforms to choose whether to remove markers on editing
https://bugs.webkit.org/show_bug.cgi?id=88838

Reviewed by Hajime Morita.

Source/WebCore:

This change allows platforms to choose whether to remove markers on a word being
edited. WebKit does not remove markers when we move a selection to a markered
word on platforms that shouldEraseMarkersAfterChangeSelection returns false.
On such platforms, WebKit expects to set WTF_USE_MARKER_REMOVAL_UPON_EDITING to
1 so Editor::updateMarkersForWordsAffectedByEditing can remove markers. This
change also checks the return value of shouldEraseMarkersAfterChangeSelection so
platform can choose it. This change also adds grammar markers so it can also
remove grammar markers.

Test: editing/spelling/grammar-edit-word.html

  • editing/Editor.cpp:

(WebCore::Editor::updateMarkersForWordsAffectedByEditing):

Source/WebKit/chromium:

This change implements EditorClientImpl::checkGrammarOfString so
DumpRenderTree can run grammar tests.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::isGrammarCheckingEnabled): Return true also when unified text-checking is enabled.
(WebKit::EditorClientImpl::shouldEraseMarkersAfterChangeSelection): ditto.
(WebKit::EditorClientImpl::checkGrammarOfString): Implement this function with our unified text-checker.

Tools:

This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
run grammar tests.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.

LayoutTests:

This change adds a test that verifies WebKit removes a grammar marker from a
grammatically-incorrect word when editing the word.

  • editing/spelling/grammar-edit-word-expected.txt: Added.
  • editing/spelling/grammar-edit-word.html: Added.
01:36 Changeset [120422] by zandobersek@gmail.com

Unreviewed GTK gardening, adding test expectation for
fast/dom/htmlcollection-non-html.html after r120413.

  • platform/gtk/TestExpectations:
01:15 Changeset [120421] by commit-queue@webkit.org

Web Inspector: [WebGL] Simple implementation of the InjectedWebGLScriptSource to support capturing WebGL calls for a frame
https://bugs.webkit.org/show_bug.cgi?id=89088

Simple experimental implementation of the InjectedWebGLScriptSource.js that allows to wrap
a WebGL context and capture names (for now) of the WebGL function calls for a frame being captured.

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-15
Reviewed by Vsevolod Vlasov.

  • inspector/InjectedWebGLScriptSource.js:

(.):

01:15 Changeset [120420] by eae@chromium.org

Unreviewed chromium mac rebaseline.

  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
00:50 Changeset [120419] by zandobersek@gmail.com

Unreviewed, rolling out r120370.
http://trac.webkit.org/changeset/120370
https://bugs.webkit.org/show_bug.cgi?id=89183

Broke webkit-patch rebaseline (Requested by zdobersek on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-15

  • Scripts/webkitpy/layout_tests/port/base.py:

(DummyOptions):
(DummyOptions.init):
(DummyOptions.init.this):
(Port.init):
(Port.get_option):
(Port.set_option_default):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.RegisterCygwinOption):
(ChromiumWinTest.RegisterCygwinOption.init):
(ChromiumWinTest.test_setup_environ_for_server_register_cygwin):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker._determine_port_from_expectations_path):

  • Scripts/webkitpy/tool/mocktool.py:

(MockOptions.update):

00:40 Changeset [120418] by zandobersek@gmail.com

Unreviewed GTK gardening, updating baselines after r120411.

  • platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/range/input-appearance-range-expected.txt:
  • platform/gtk/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/gtk/fast/forms/range/slider-padding-expected.txt:
  • platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/gtk/fast/forms/range/slider-thumb-stylability-expected.txt:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
00:38 Changeset [120417] by rniwa@webkit.org

Use testRunner instead of layoutTestController in networkinformation, perf, plugins, pointer-lock, printing, scrollbars, and security tests
https://bugs.webkit.org/show_bug.cgi?id=89181

Reviewed by Kent Tamura.

  • perf/clone-with-focus.html:
  • perf/nested-combined-selectors.html:
  • perf/table-rows-length-caching.html:
  • platform/chromium/plugins/call-as-function.html:
  • platform/chromium/plugins/get-url-with-blank-target2.html:
  • platform/chromium/plugins/get-url-with-iframe-target-no-crash.html:
  • platform/chromium/printing/custom-page-size-style-expected.txt:
  • platform/chromium/printing/custom-page-size-style.html:
  • platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html:
  • platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html:
  • platform/mac-wk2/plugins/contents-scale-factor.html:
  • platform/mac-wk2/plugins/mouse-events-scaled.html:
  • platform/mac/plugins/bindings-array-apply-crash.html:
  • platform/mac/plugins/bindings-objc-long-method-name.html:
  • platform/mac/plugins/bindings-objc-method-name-conversion.html:
  • platform/mac/plugins/bindings-test-objc.html:
  • platform/mac/plugins/call-as-function-test.html:
  • platform/mac/plugins/convert-point.html:
  • platform/mac/plugins/disable-plugins.html:
  • platform/mac/plugins/jsobjc-dom-wrappers.html:
  • platform/mac/plugins/jsobjc-simple.html:
  • platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html-disabled:
  • platform/mac/plugins/root-object-premature-delete-crash.html:
  • platform/mac/plugins/supports-carbon-event-model.html:
  • platform/mac/plugins/testplugin-onnew-onpaint.html:
  • platform/mac/plugins/throw-on-dealloc.html:
  • platform/mac/plugins/undefined-property-crash.html:
  • platform/mac/plugins/update-widget-from-style-recalc.html:
  • platform/mac/plugins/webScriptObject-exception-deadlock.html:
  • platform/mac/scrollbars/key-window-not-first-responder.html:
  • platform/qt/plugins/application-plugin-plugins-disabled.html:
  • platform/win/plugins/call-javascript-that-destroys-plugin.html:
  • platform/win/plugins/get-value-netscape-window.html:
  • platform/win/plugins/iframe-inside-overflow.html:
  • platform/win/plugins/npn-invalidate-rect-invalidates-window.html:
  • platform/win/plugins/visibility-hidden.html:
  • platform/win/plugins/window-geometry-initialized-before-set-window.html:
  • platform/win/plugins/window-region-is-set-to-clip-rect.html:
  • platform/win/plugins/windowless-paint-rect-coordinates.html:
  • plugins/:
  • pointer-lock/lock-fail-responses-expected.txt:
  • pointer-lock/lock-fail-responses.html:
  • pointer-lock/pointer-lock-api.html:
  • pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
  • pointer-lock/pointerlocklost-event-expected.txt:
  • pointer-lock/pointerlocklost-event.html:
  • printing/compositing-layer-printing.html:
  • printing/css2.1/README.txt:
  • printing/css2.1/page-break-after-000.html:
  • printing/css2.1/page-break-after-001.html:
  • printing/css2.1/page-break-after-002.html:
  • printing/css2.1/page-break-after-003.html:
  • printing/css2.1/page-break-after-004.html:
  • printing/css2.1/page-break-before-000.html:
  • printing/css2.1/page-break-before-001.html:
  • printing/css2.1/page-break-before-002.html:
  • printing/css2.1/page-break-inside-000.html:
  • printing/iframe-print.html:
  • printing/media-queries-print.html:
  • printing/numberOfPages-expected.txt:
  • printing/page-count-layout-overflow.html:
  • printing/page-count-relayout-shrink.html:
  • printing/page-count-with-one-word.html:
  • printing/page-format-data-display-none.html:
  • printing/page-format-data-expected.txt:
  • printing/page-format-data.html:
  • printing/page-rule-css-text.html:
  • printing/page-rule-in-media-query.html:
  • printing/page-rule-selection-expected.txt:
  • printing/page-rule-selection.html:
  • printing/pageNumerForElementById-expected.txt:
  • printing/print-close-crash.html:
  • printing/pseudo-class-outside-page.html:
  • printing/resources/paged-media-test-utils.js:

(pageNumberForElementShouldBe):
(numberOfPagesShouldBe):
(runPrintingTest):

  • printing/return-from-printing-mode.html:
  • printing/script-tests/numberOfPages.js:
  • printing/script-tests/pageNumerForElementById.js:
  • printing/setPrinting.html:
  • printing/simultaneous-position-float-change.html:
  • printing/single-line-must-not-be-split-into-two-pages.html:
  • printing/width-overflow.html:
  • printing/zoomed-document.html:
  • scrollbars/hidden-iframe-scrollbar-crash.html:
  • scrollbars/hidden-iframe-scrollbar-crash2.html:
  • scrollbars/hidden-scrollbar-prevents-layout.html:
  • scrollbars/overflow-custom-scrollbar-crash.html:
  • scrollbars/resources/hidden-iframe-scrollbar-crash2.html:
  • scrollbars/scroll-rtl-or-bt-layer.html:
  • scrollbars/scrollable-iframe-remove-crash.html:
  • scrollbars/scrollbar-click-does-not-blur-content.html:
  • scrollbars/scrollbar-crash-on-refresh.html:
  • scrollbars/scrollbar-drag-thumb-with-large-content.html:
  • scrollbars/scrollbar-gradient-crash.html:
  • scrollbars/scrollbar-iframe-click-does-not-blur-content.html:
  • scrollbars/scrollbar-initial-position.html:
  • scrollbars/scrollbar-middleclick-nopaste.html:
  • scrollbars/scrollbar-miss-mousemove-disabled.html:
  • scrollbars/scrollbar-miss-mousemove.html:
  • scrollbars/scrollbar-owning-renderer-crash.html:
  • scrollbars/scrollbar-part-created-with-no-parent-crash.html:
  • scrollbars/scrollbar-percent-padding-crash.html:
  • scrollbars/scrollbar-scrollbarparts-repaint-crash.html:
  • scrollbars/scrollevent-iframe-no-scrolling-wheel.html:
  • scrollbars/scrollevent-iframe-no-scrolling.html:
  • security/autocomplete-cleared-on-back.html:
  • security/block-test-no-port.html:
  • security/block-test.html:
  • security/set-form-autocomplete-attribute.html:
00:33 Changeset [120416] by rniwa@webkit.org

Use testRunner instead of layoutTestController in ietestcenter, inspector, java, jquery, loader, mathml, media, and mhtml tests
https://bugs.webkit.org/show_bug.cgi?id=89176

Reviewed by Kent Tamura.

  • ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm:
  • inspector/audits/resources/audits-style1.css:
  • inspector/console/console-long-eval-crash.html:
  • inspector/extensions/extensions-audits-content-script.html:
  • inspector/extensions/extensions-eval-content-script.html:
  • inspector/profiler/cpu-profiler-profiling-without-inspector.html:
  • inspector/timeline/timeline-animation-frame.html:
  • inspector/timeline/timeline-paint.html:
  • inspector/timeline/timeline-receive-response-event.html:
  • inspector/timeline/timeline-timer.html:
  • java/argument-to-object-type.html:
  • java/array-return.html:
  • java/array-sort.html:
  • java/embedding-java-with-object.html:
  • java/inaccessible-class.html:
  • java/inline-applet-crash.html:
  • java/java-and-plugins.html:
  • java/lc3/:
  • jquery/resources/helper.js:
  • loader/go-back-to-different-window-size.html:
  • loader/load-defer-resume-crash.html:
  • loader/navigation-while-deferring-loads.html:
  • loader/reload-subresource-when-type-changes.html:
  • mathml/EmptyMFracCrash.xhtml:
  • mathml/EmptyMunderOverCrash.xhtml:
  • mathml/empty-mroot-crash.xhtml:
  • mathml/empty-msubsup-crash.html:
  • mathml/fenced-whitespace-separators-crash.html:
  • mathml/msub-anonymous-child-render-crash.html:
  • mathml/msubsup-no-grandchild.xhtml:
  • mathml/msubsup-remove-children.xhtml:
  • mathml/munderover-remove-children.html:
  • mathml/operator-hijacks-fenced-node.xhtml:
  • mathml/wbr-in-mroot-crash.html:
  • media/W3C/w3cwrapper.js:

(test):
(async_test.t.done):
(async_test):

  • media/adopt-node-crash.html:
  • media/audio-controls-do-not-fade-out.html:
  • media/audio-controls-rendering.html:
  • media/audio-delete-while-slider-thumb-clicked.html:
  • media/audio-delete-while-step-button-clicked.html:
  • media/audio-garbage-collect.html:
  • media/audio-no-installed-engines.html:
  • media/audio-only-video-intrinsic-size.html:
  • media/audio-repaint.html:
  • media/context-menu-actions.html:
  • media/controls-after-reload.html:
  • media/controls-drag-timebar.html:
  • media/controls-layout-direction.html:
  • media/controls-right-click-on-timebar.html:
  • media/controls-without-preload.html:
  • media/crash-closing-page-with-media-as-plugin-fallback.html:
  • media/fallback.html:
  • media/media-blocked-by-beforeload.html:
  • media/media-blocked-by-willsendrequest.html:
  • media/media-controls-clone-crash.html:
  • media/media-controls-invalid-url.html:
  • media/media-document-audio-repaint.html:
  • media/media-document-audio-size.html:
  • media/media-fullscreen.js:

(canplaythrough):

  • media/media-volume-slider-rendered-normal.html:
  • media/no-auto-play-in-sandbox.html:
  • media/remove-from-document-before-load.html:
  • media/resources/foreignobject-media.svg:
  • media/restore-from-page-cache.html:
  • media/svg-as-image-with-media-blocked.html:
  • media/video-beforeload-remove-source.html:
  • media/video-canvas-alpha.html:
  • media/video-canvas.html-disabled:
  • media/video-click-dblckick-standalone.html:
  • media/video-controls-in-media-document.html:
  • media/video-controls-no-scripting.html:
  • media/video-controls-toggling.html:
  • media/video-controls-visible-audio-only.html:
  • media/video-controls-with-mutation-event-handler.html:
  • media/video-delay-load-event.html:
  • media/video-display-toggle.html:
  • media/video-document-types.html:
  • media/video-element-other-namespace-crash.html:
  • media/video-empty-source.html:
  • media/video-no-audio.html:
  • media/video-paint-test.js:

(init.waitForMultipleEvents):
(initAndPause.waitForMultipleEvents):
(initAndPause):

  • media/video-plays-past-end-of-test.html:
  • media/video-poster-blocked-by-willsendrequest.html:
  • media/video-replaces-poster.html:
  • media/video-source-inserted.html:
  • media/video-test.js:

(endTest):

  • media/video-volume-slider.html:
  • media/video-zoom.html:
  • mhtml/check_domain.mht:
  • mhtml/multi_frames.html_original:
  • mhtml/multi_frames_binary.mht:
  • mhtml/multi_frames_ie.mht:
  • mhtml/multi_frames_unmht.mht:
  • mhtml/page_with_css_and_js_ie.mht:
  • mhtml/page_with_css_and_js_unmht.mht:
  • mhtml/page_with_image.html_original:
  • mhtml/page_with_image_ie.mht:
  • mhtml/page_with_image_unmht.mht:
  • mhtml/simple_page.html_original:
  • mhtml/simple_page_ie.mht:
  • mhtml/simple_page_unmht.mht:
  • networkinformation/resources/event-after-navigation-new.html:
  • networkinformation/script-tests/event-after-navigation.js:
  • platform/chromium/media/video-frame-size-change.html:
00:22 Changeset [120415] by eae@chromium.org

Unreviewed chromium win and mac rebaseline for r120403.

  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium/TestExpectations:
00:19 Changeset [120414] by commit-queue@webkit.org

Add fullscreen button to Chrome video controls for video.
https://bugs.webkit.org/show_bug.cgi?id=88818

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-06-15
Reviewed by Eric Carlson.

No new tests, final patch will contain the rebaselined tests.

The Chrome video controls are receiving a visual update.
This patch includes a fullscreen button for video elements and the rendering of the controls
in fullscreen including hiding them after 2 seconds when the mouse is out of the controls
and not moved.

  • css/fullscreen.css:

(video:-webkit-full-screen, audio:-webkit-full-screen):
Add audio to the default fullscreen styling rules.

  • css/mediaControlsChromium.css:

(video:-webkit-full-page-media::-webkit-media-controls-panel):
Align controls to the bottom of the fullscreen page.
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
Include styling for the fullscreen button.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore):
Add a constant for when to hide the controls in fullscreen.
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
Add member fields for fullscreen button, hiding timer and tracking of whether we are in fullscreen.
(WebCore::MediaControlRootElementChromium::create):
Add fullscreen button element to the visual layout.
(WebCore::MediaControlRootElementChromium::setMediaController):
Add fullscreen button element to the media controller.
(WebCore::MediaControlRootElementChromium::reset):
Show the fullscreen button if the controller supports fullscreen.
(WebCore::MediaControlRootElementChromium::playbackStarted):
Start the timer to hide the controls in fullscreen.
(WebCore::MediaControlRootElementChromium::playbackStopped):
Don't hide the controls when the video is paused in fullscreen.
(WebCore::MediaControlRootElementChromium::reportedError):
Hide the fullscreen button when we hit an error.
(WebCore::MediaControlRootElementChromium::defaultEventHandler):
Add logic for mouse events in fullscreen to start/stop the hiding timer.
(WebCore::MediaControlRootElementChromium::startHideFullscreenControlsTimer):
Start the fullscreen hiding timer.
(WebCore::MediaControlRootElementChromium::hideFullscreenControlsTimerFired):
Timer fired: hide the video controls in fullscreen.
(WebCore::MediaControlRootElementChromium::stopHideFullscreenControlsTimer):
Reset the fullscreen hiding timer.
(WebCore::MediaControlRootElementChromium::enteredFullscreen):
Add logic to enter fullscreen.
(WebCore::MediaControlRootElementChromium::exitedFullscreen):
Add logic to exit fullscreen.

  • html/shadow/MediaControlRootElementChromium.h:

(MediaControlRootElementChromium):
Add declaration of member functions and fields for fullscreen.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaFullscreenButton):
Use the new image for the fullscreen button.

  • rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):
Declare the fullscreen painting function for Chrome Mac.

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
Hook up the fullscreen paining function for Chrome Mac.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintMediaFullscreenButton):
Hook up the fullscreen paining function for Chrome Skia.

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):
Declare the fullscreen painting function for Chrome Skia.

00:13 Changeset [120413] by tkent@chromium.org

Unreviewed, rolling out r110340.
http://trac.webkit.org/changeset/110340
https://bugs.webkit.org/show_bug.cgi?id=88749

Source/WebCore:

r110340 added a broken implementation of
HTMLSelectElement::selectedOptions. This roll out removes
HTMLSelectElement::selectedOptions.

  • html/CollectionType.h:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):

  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLSelectElement.idl:

LayoutTests:

  • fast/dom/HTMLSelectElement/select-selectedOptions-expected.txt: Removed.
  • fast/dom/HTMLSelectElement/select-selectedOptions.html: Removed.
00:11 Changeset [120412] by morrita@google.com

Unreviewed typo fix for r120405.

  • platform/chromium/TestExpectations:
Note: See TracTimeline for information about the timeline view.