Timeline


and

07/09/12:

23:42 Changeset [122197] by commit-queue@webkit.org
  • 6 edits
    1 copy
    2 moves
    2 adds in trunk/Source

[EFL] Battery status code needs refactoring to be reused in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=90760

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-09
Reviewed by Hajime Morita.

Source/WebCore:

Rename BatteryClientEfl to BatteryProviderEfl and remove dependency
on BatteryController by introducing the BatteryProviderEflClient
interface. This will allow reusing the BatteryProviderEfl class
in WebKit2.

No new tests. Already tested by batterystatus/*.

  • PlatformEfl.cmake:
  • platform/efl/BatteryProviderEfl.cpp: Renamed from Source/WebCore/platform/efl/BatteryClientEfl.cpp.

(WebCore):
(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::batteryStatus):
(WebCore::BatteryProviderEfl::startUpdating):
(WebCore::BatteryProviderEfl::stopUpdating):
(WebCore::BatteryProviderEfl::setBatteryStatus):
(WebCore::BatteryProviderEfl::timerFired):
(WebCore::BatteryProviderEfl::getBatteryStatus):
(WebCore::BatteryProviderEfl::setBatteryClient):

  • platform/efl/BatteryProviderEfl.h: Copied from Source/WebCore/platform/efl/BatteryClientEfl.h.

(WebCore):
(BatteryProviderEfl):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl):

  • platform/efl/BatteryProviderEflClient.h: Added.

(WebCore):
(BatteryProviderEflClient):

Source/WebKit:

Add BatteryClientEfl to PlatformEfl.cmake.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Add BatteryClientEfl to WebKit, which uses BatteryProviderEfl from
WebCore internally.

  • WebCoreSupport/BatteryClientEfl.cpp: Added.

(BatteryClientEfl::BatteryClientEfl):
(BatteryClientEfl::setController):
(BatteryClientEfl::startUpdating):
(BatteryClientEfl::stopUpdating):
(BatteryClientEfl::batteryControllerDestroyed):
(BatteryClientEfl::didChangeBatteryStatus):

  • WebCoreSupport/BatteryClientEfl.h: Renamed from Source/WebCore/platform/efl/BatteryClientEfl.h.

(WebCore):
(BatteryClientEfl):
(BatteryClientEfl::~BatteryClientEfl):

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

23:37 WebKitIDL edited by toybabyyou@gmail.com
(diff)
23:34 Drosera edited by toybabyyou@gmail.com
(diff)
23:24 WebInspector edited by toybabyyou@gmail.com
(diff)
22:55 Changeset [122196] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed gardening.
Fix a wrong fix of r122194.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):

22:45 Changeset [122195] by commit-queue@webkit.org
  • 31 edits
    3 adds in trunk

Add ENABLE_DIALOG_ELEMENT and skeleton files
https://bugs.webkit.org/show_bug.cgi?id=90521

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-07-09
Reviewed by Kent Tamura.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This adds the ENABLE_DIALOG_ELEMENT feature flag and dummy implementation files for <dialog>. In addition, a runtime feature flag is added.
The feature is diabled by default.

No new tests, as there is no behavior change.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h: Added a runtime feature flag for dialog.

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::dialogElementEnabled):
(WebCore::RuntimeEnabledFeatures::setDialogElementEnabled):

  • dom/ContextFeatures.cpp:

(WebCore::ContextFeatures::dialogElementEnabled):
(WebCore):

  • dom/ContextFeatures.h: Added a per-context flag for dialog so that dialog can be disabled in HTMLTagNames.in and DOMWindow.idl when the dialog runtime feature flag is off.
  • html/HTMLDialogElement.cpp: Added.

(WebCore):
(WebCore::HTMLDialogElement::HTMLDialogElement):
(WebCore::HTMLDialogElement::create):
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::show):

  • html/HTMLDialogElement.h: Added.

(WebCore):
(HTMLDialogElement):

  • html/HTMLDialogElement.idl: Added.
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • features.gypi:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableDialogElement):
(WebKit):
(WebKit::WebRuntimeFeatures::isDialogElementEnabled):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
22:22 Changeset [122194] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed gardening.
Remove an assertion starting to fail on interactive_ui_tests on Chromium OS.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):

21:56 Changeset [122193] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed gardening.
Build fix after r122175

  • WebCore.gypi: Remove Source/WebCore/platform/graphics/qt/Extensions3DQt.{cpp,h}
21:35 Changeset [122192] by tkent@chromium.org
  • 5 edits in trunk/Tools

Improve the boilerplate generated by prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=89560

Reviewed by Ryosuke Niwa.

Produce the following boilerplate:

2012-06-20 Kent Tamura <tkent@chromium.org>

Need a short description (Oops!).
Need the bug URL (Oops!).

Reviewed by NOBODY (Oops!).

Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).

No new tests (Oops!).

  • Scripts/prepare-ChangeLog:

(generateNewChangeLogs): Generate the updated template.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLog.update_with_unreviewed_message):
Update the pattern for the beginning of the boilerplate.
(ChangeLog.set_short_description_and_bug_url):

  • Use self._changelog_indent
  • Update the pattern for the description line
  • Skip the bug boilerplate.

We substitute the specified bug URL to the description boilerplate
because we need to add it even if the bug URL boilerplate is missing.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py: Update the boilerplate data.

(test_set_short_description_and_bug_url):

  • Update the description boilerplate.
  • Add a test for a case with both of the description boilerplace and the bug URL boilerplate.
  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:

(PrepareChangeLogTest.test_ensure_bug_url): Update the expected boilerplate.

21:34 Changeset [122191] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Improve performance of RenderInline::absoluteQuads for deeply nested inlines.
https://bugs.webkit.org/show_bug.cgi?id=90715

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-07-09
Reviewed by Maciej Stachowiak.

No new tests: functionality unchanged.

  • rendering/RenderInline.cpp: Cache transformation from local to absolute coordinates using a

RenderGeometryMap and use it for subsequent mappings.
(WebCore::(anonymous namespace)::AbsoluteQuadsGeneratorContext::AbsoluteQuadsGeneratorContext):
(WebCore::(anonymous namespace)::AbsoluteQuadsGeneratorContext::operator()):

21:31 Changeset [122190] by yosin@chromium.org
  • 5 edits in trunk/Source

[Chromium-Mac] Implement functions for localized time format information
https://bugs.webkit.org/show_bug.cgi?id=90237

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces following localized time format related
functions:

  • localizeTimeFormatText()
  • localizeShortTimeFormatText()
  • timeAMPMLabels

for Mac OSX in feature flag: ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These function will be used by input type "time" with multiple input
fields UI.

Note: ICU version of localized time format functions are implemented
in https://bugs.webkit.org/show_bug.cgi?id=89965

Tests: WebKit/chromium/tests/LocaleMacTest.cpp

  • platform/text/mac/LocaleMac.h:

(LocaleMac): Added time format related functions and variables.

  • platform/text/mac/LocaleMac.mm:

(WebCore::createDateTimeFormatter): Added. A helper function for creating date time formatter.
(WebCore::LocaleMac::createShortDateFormatter): Changed to use createDateTimeFormatter.
(WebCore::LocaleMac::createTimeFormatter): Added.
(WebCore::LocaleMac::createShortTimeFormatter): Added.
(WebCore::LocaleMac::timeFormatText): Added.
(WebCore::LocaleMac::shortTimeFormatText): Added.
(WebCore::LocaleMac::timeAMPMLabels): Added.

Source/WebKit/chromium:

  • tests/LocaleMacTest.cpp:

(LocaleMacTest):
(LocaleMacTest::timeFormatText):
(LocaleMacTest::shortTimeFormatText):
(LocaleMacTest::timeAMPMLabel):
(TEST_F):

20:27 Changeset [122189] by achicu@adobe.com
  • 6 edits in trunk/Source/WebCore

[CSS Shaders] The FECustomFilter is not making the GL context active
https://bugs.webkit.org/show_bug.cgi?id=90840

Reviewed by Dean Jackson.

I've added a couple of makeContextCurrent() in the FECustomFilter related classes.
Also, removed the assumption that GraphicsContext3D::create() never returns 0.

No new tests, this was crashing on existing tests.

  • platform/graphics/filters/CustomFilterCompiledProgram.cpp:

(WebCore::CustomFilterCompiledProgram::CustomFilterCompiledProgram):
(WebCore::CustomFilterCompiledProgram::~CustomFilterCompiledProgram):

  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):

  • platform/graphics/filters/CustomFilterMesh.cpp:

(WebCore::CustomFilterMesh::CustomFilterMesh):
(WebCore::CustomFilterMesh::~CustomFilterMesh):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::initializeContext):

  • platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

20:18 Changeset [122188] by tkent@chromium.org
  • 3 edits
    3 adds in trunk

REGRESSION(r114862-r114886): Fix a crash by switching the input type to hidden.
https://bugs.webkit.org/show_bug.cgi?id=90774

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/forms/hidden/change-type-to-hidden-after-updating-value.html

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):
Pass a copy of the existing Attribute object.

LayoutTests:

  • fast/forms/hidden/change-type-to-hidden-after-updating-value.html: Added.
  • fast/forms/hidden/change-type-to-hidden-after-updating-value-expected.txt: Added.
19:38 Changeset [122187] by philn@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer] cache video dimensions
https://bugs.webkit.org/show_bug.cgi?id=90733

Reviewed by Martin Robinson.

Invalidate the cached video dimensions whenever the video-sink sink pad caps
change and let ::naturalSize() lazily recalculate them.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

19:29 Changeset [122186] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Update TestExpectations.

  • platform/chromium/TestExpectations: http/tests/misc/script-defer.html started failing after r122168.
19:29 Changeset [122185] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[chromium] Merge updates and idle updates into one pass
https://bugs.webkit.org/show_bug.cgi?id=90324

Patch by Eric Penner <epenner@google.com> on 2012-07-09
Reviewed by Adrienne Walker.

Source/WebCore:

We no longer need to do painting is passes in order
to allocate memory in the right order. So this merges
updates and idle updates into one pass.

Covered by existing unit tests (some of which are
updated with this patch).

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::needMoreUpdates):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::needMoreUpdates):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::updateLayerRect):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostTest.cpp:

(WTF::ContentLayerChromiumWithUpdateTracking::resetPaintContentsCount):
(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(ContentLayerChromiumWithUpdateTracking):
(WTF::CCLayerTreeHostTestOpacityChange::afterTest):

  • tests/CCTiledLayerTestCommon.h:

(FakeTiledLayerChromium):

  • tests/TiledLayerChromiumTest.cpp:
19:16 Changeset [122184] by yosin@chromium.org
  • 8 edits
    1 add
    1 delete in trunk/Source

[Platform] Introduce LocaleMac class
https://bugs.webkit.org/show_bug.cgi?id=90248

Reviewed by Kent Tamura.

Source/WebCore:

This patch moves implementation of localized date format related
functions into LocaleMac class as of LocaleWin class for ease of
maintain and using specific locale in testing rather than system
default locale.

Tests: WebKit/chromium/tests/LocaleMacTest.cpp

  • WebCore.gyp/WebCore.gyp: Include LocaleMac.mm
  • WebCore.gypi:
  • platform/text/mac/LocaleMac.h: Replace LocaleWin to LocaleMac.
  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::LocaleMac):
(WebCore::LocaleMac::~LocaleMac):
(WebCore::LocaleMac::create):
(WebCore::LocaleMac::currentLocale):
(WebCore::LocaleMac::createShortDateFormatter):
(WebCore::LocaleMac::parseDate):
(WebCore::LocaleMac::formatDate):
(WebCore::LocaleMac::dateFormatText):
(WebCore::LocaleMac::monthLabels):
(WebCore::LocaleMac::weekDayShortLabels):
(WebCore::LocaleMac::firstDayOfWeek):

  • platform/text/mac/LocalizedDateMac.cpp:

(WebCore::parseLocalizedDate):
(WebCore::formatLocalizedDate):
(WebCore::localizedDateFormatText):
(WebCore::monthLabels):
(WebCore::weekDayShortLabels):
(WebCore::firstDayOfWeek):

  • platform/text/mac/LocalizedDateMac.mm: Removed.

Source/WebKit/chromium:

This patch added tests for LocaleMac class.

  • WebKit.gypi:
  • tests/LocaleMacTest.cpp: Added.

(LocaleMacTest):
(LocaleMacTest::dateComponents):
(LocaleMacTest::msForDate):
(LocaleMacTest::formatDate):
(LocaleMacTest::parseDate):
(LocaleMacTest::dateFormatText):
(LocaleMacTest::firstDayOfWeek):
(LocaleMacTest::monthLabel):
(LocaleMacTest::weekDayShortLabel):
(TEST_F):

19:14 Changeset [122183] by dino@apple.com
  • 2 adds in trunk/LayoutTests/compositing

Forgot to actually add these files in r122152

  • compositing/tile-cache-must-flatten-expected.html: Added.
  • compositing/tile-cache-must-flatten.html: Added.
18:50 Changeset [122182] by fpizlo@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Unreviewed, roll out http://trac.webkit.org/changeset/121511
It made in-browser V8v7 10% slower.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::countSpeculationSuccess):
(JSC::CodeBlock::countSpeculationFailure):
(JSC::CodeBlock::speculativeSuccessCounter):
(JSC::CodeBlock::speculativeFailCounter):
(JSC::CodeBlock::forcedOSRExitCounter):
(JSC::CodeBlock::addressOfSpeculativeSuccessCounter):
(JSC::CodeBlock::addressOfSpeculativeFailCounter):
(JSC::CodeBlock::addressOfForcedOSRExitCounter):
(JSC::CodeBlock::offsetOfSpeculativeSuccessCounter):
(JSC::CodeBlock::offsetOfSpeculativeFailCounter):
(JSC::CodeBlock::offsetOfForcedOSRExitCounter):
(JSC::CodeBlock::largeFailCountThreshold):
(JSC::CodeBlock::largeFailCountThresholdForLoop):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):

  • bytecode/ExecutionCounter.cpp:

(JSC::ExecutionCounter::setThreshold):

  • bytecode/ExecutionCounter.h:

(ExecutionCounter):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileBody):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

  • dfg/DFGOSRExitCompiler.cpp:

(JSC::DFG::OSRExitCompiler::handleExitCounts):

  • dfg/DFGOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Options.h:

(JSC):

18:46 Changeset [122181] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Update TestExpectations.

  • platform/chromium/TestExpectations: Mark fast/forms/select/select-state-restore.html as flaky on WIN DEBUG.
18:43 Changeset [122180] by danakj@chromium.org
  • 4 edits
    5 adds in trunk/Source

[chromium] Create CCScopedTexture class for creating/freeing textures
https://bugs.webkit.org/show_bug.cgi?id=89485

Reviewed by Adrienne Walker.

Source/WebCore:

This class provides a standard way to create texture ids in a way that
ensures they will be freed later.

Also includes a CCTexture base class that holds textureId, size, and
format together in a struct that can be used in place of storing an
unsigned textureId in other classes.

Unit tests: CCScopedTexureTest.NewScopedTexture

CCScopedTexureTest.CreateScopedTexture
CCScopedTexureTest.ScopedTextureIsDeleted
CCScopedTexureTest.LoseScopedTexture

  • WebCore.gypi:
  • platform/graphics/chromium/cc/CCScopedTexture.cpp: Added.

(WebCore):
(WebCore::CCScopedTexture::CCScopedTexture):
(WebCore::CCScopedTexture::~CCScopedTexture):
(WebCore::CCScopedTexture::allocate):
(WebCore::CCScopedTexture::free):
(WebCore::CCScopedTexture::leak):

  • platform/graphics/chromium/cc/CCScopedTexture.h: Added.

(WebCore):
(CCScopedTexture):
(WebCore::CCScopedTexture::create):

  • platform/graphics/chromium/cc/CCTexture.cpp: Added.

(WebCore):
(WebCore::CCTexture::setDimensions):
(WebCore::CCTexture::bytes):
(WebCore::CCTexture::memorySizeBytes):

  • platform/graphics/chromium/cc/CCTexture.h: Added.

(WebCore):
(CCTexture):
(WebCore::CCTexture::CCTexture):
(WebCore::CCTexture::id):
(WebCore::CCTexture::size):
(WebCore::CCTexture::format):
(WebCore::CCTexture::setId):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/CCScopedTextureTest.cpp: Added.

(WebKitTests):
(WebKitTests::TEST):
(TrackingTextureAllocator):
(WebKitTests::TrackingTextureAllocator::TrackingTextureAllocator):
(WebKitTests::TrackingTextureAllocator::numTextures):

18:39 Changeset [122179] by jsbell@chromium.org
  • 3 edits
    2 adds in trunk

IndexedDB: deleteDatabase fails if transaction running in other database
https://bugs.webkit.org/show_bug.cgi?id=90822

Reviewed by Tony Chang.

Source/WebCore:

The IDBLevelDBBackingStore was preventing a deleteDatabase() from running
if any other database was running a transaction. Fix by just creating a scratch
LevelDBTransaction for the delete steps.

Test: storage/indexeddb/deletedatabase-transaction.html

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::deleteDatabase): Use a LevelDBTransaction
directly.

LayoutTests:

  • storage/indexeddb/deletedatabase-transaction-expected.txt: Added.
  • storage/indexeddb/deletedatabase-transaction.html: Added.
18:37 Changeset [122178] by commit-queue@webkit.org
  • 17 edits
    4 adds in trunk

.: Expose an export for the iconUrl list so Internals can use it
https://bugs.webkit.org/show_bug.cgi?id=88665

Patch by Pete Williamson <petewil@google.com> on 2012-07-09
Reviewed by Kent Tamura.

  • Source/autotools/symbols.filter: export iconURLs

Source/WebCore: Changed the behavior of iconURLs to always recalculate the list.
https://bugs.webkit.org/show_bug.cgi?id=88665

Patch by Pete Williamson <petewil@google.com> on 2012-07-09
Reviewed by Kent Tamura..

As it turns out, it can contain stale URLs in the case that some script
manipulates the DOM, which breaks scripts trying to reset the favicon
URL. Also added a method in Internals to allow tests to get the list of
icon

Tests: fast/dom/icon-url-change.html

fast/dom/icon-url-list.html

  • WebCore.exp.in: export Document::iconURLs on the mac for the Internals class
  • dom/Document.cpp:

(WebCore::Document::iconURLs): Changed the method to recalculate the iconURL list every time
(WebCore::Document::addIconURL): we no longer need to add to the internal list since we recalculate it
(WebCore::Document::setUseSecureKeyboardEntryWhenActive): removed extra whitespace

  • dom/Document.h:

(Document): removed the addIconURL method which is no longer used

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::iconType): exposed the icon type with an accessor
(WebCore):
(WebCore::HTMLLinkElement::iconSizes): exposed the icon sizes with an accessor

  • html/HTMLLinkElement.h:

(HTMLLinkElement): declared the icon type and size accessors

  • testing/Internals.cpp:

(WebCore::Internals::iconURLs): made a method to be used by unit tests for inspecting the icon URL list
(WebCore):

  • testing/Internals.h:

(Internals): declared the method for unit testing the icon URL list

  • testing/Internals.idl: exported the Document::iconURLs function

Source/WebKit2: Export the iconURL list to make it available to the Internals class for testing
https://bugs.webkit.org/show_bug.cgi?id=88665

Patch by Pete Williamson <petewil@google.com> on 2012-07-09
Reviewed by Kent Tamura.

  • win/WebKit2.def: export the DocumentL::iconURLs function

LayoutTests: Add some new unit tests to test the favicon changing dynamically
https://bugs.webkit.org/show_bug.cgi?id=88665

Patch by Pete Williamson <petewil@google.com> on 2012-07-09
Reviewed by Kent Tamura.

  • fast/dom/icon-url-change-expected.txt: Added.
  • fast/dom/icon-url-change.html: Added a new test for changing the favicon dynamically
  • fast/dom/icon-url-list-expected.txt: Added.
  • fast/dom/icon-url-list.html: Added a new test for multiple favicons in the HTML header
  • fast/dom/icon-url-property-expected.txt: update unit test expectations
  • fast/dom/icon-url-property.html: update and enable existing favicon test
  • platform/chromium/TestExpectations: reenable the url-property test
18:35 Changeset [122177] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Gcc build fix after r122174.

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::decrementAccessCount):

18:25 Changeset [122176] by commit-queue@webkit.org
  • 5 edits in trunk

Editing: Autocorrection in blockquotes causes text to break out of quote
https://bugs.webkit.org/show_bug.cgi?id=90487
<rdar://problem/11769020>

Patch by Alice Cheng <alice_cheng@apple.com> on 2012-07-09
Reviewed by Enrica Casucci.

Source/WebCore:

Test: platform/mac/editing/spelling/autocorrection-blockquote-crash.html

SpellingCorrectionCommand uses ReplaceSelectionCommand to replace the misspelled word with the auto-corrected word. Specifically, ReplaceSelectionCommand does a smart copy, where it breaks out of blockquotes. Thus, the fix is to substitute ReplaceSelectionCommand with InserTextCommand.

  • editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionCommand::doApply):

LayoutTests:

  • platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
  • platform/mac/editing/spelling/autocorrection-blockquote-crash.html:
18:06 Changeset [122175] by noam.rosenthal@nokia.com
  • 48 edits
    2 deletes in trunk

90506

18:03 Changeset [122174] by commit-queue@webkit.org
  • 20 edits
    3 adds in trunk

Consider closing unused localStorage database after a timeout.
https://bugs.webkit.org/show_bug.cgi?id=90713

For a localStorage, if there is no active document referencing to it for certain amount of time (300 seconds),
we can close the underlying sqlite database.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-07-09
Reviewed by Brady Eidson.

Source/WebCore:

Test: storage/domstorage/storage-close-database-on-idle.html

  • storage/Storage.cpp:

(WebCore::Storage::Storage): increment storageArea access count when a DOMWindow is referencing it.
(WebCore::Storage::~Storage): decrement storageArea access count when DOMWindow is done with it.

  • storage/StorageArea.h:

(StorageArea):

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::StorageAreaImpl):
(WebCore::StorageAreaImpl::incrementAccessCount):
(WebCore):
(WebCore::StorageAreaImpl::decrementAccessCount): schedule closeDatabaseTimer if there is no active document

referencing to this storageArea.

(WebCore::StorageAreaImpl::closeDatabaseTimerFired): close the underlying sqlite database.

  • storage/StorageAreaImpl.h:

(StorageAreaImpl):

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::sync): if m_syncCloseDatabase flag is set and the database is not opened, bail out.

  • storage/StorageTracker.cpp:

(WebCore):
(WebCore::StorageTracker::StorageTracker):

  • storage/StorageTracker.h:

(WebCore::StorageTracker::storageDatabaseIdleInterval):
(WebCore::StorageTracker::setStorageDatabaseIdleInterval): set the timeout value that we will wait before closing the

database. This is currently used by DumpRenderTree only.

(StorageTracker):

Source/WebKit/mac:

  • Storage/WebStorageManager.mm:

(+[WebStorageManager setStorageDatabaseIdleInterval:]): add a new method for DumpRenderTree to set the timeout

that we will wait before closing database.

(initializeLocalStoragePath):

  • Storage/WebStorageManagerPrivate.h:

Tools:

  • DumpRenderTree/LayoutTestController.cpp: add a JS method setStorageDatabaseIdleInterval to testRunner

to set a different timeout value for closing localStorage database.

(setStorageDatabaseIdleIntervalCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setStorageDatabaseIdleInterval): add empty method.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setStorageDatabaseIdleInterval): ditto.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setStorageDatabaseIdleInterval): ditto.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setStorageDatabaseIdleInterval): ditto.

LayoutTests:

  • platform/chromium/TestExpectations: the test needs setCacheModel implementation, skip it in chromium.
  • storage/domstorage/storage-close-database-on-idle-expected.txt: Added.
  • storage/domstorage/storage-close-database-on-idle.html: Added.
  • storage/resources/storage-close-data-on-idle-switch.html: Added.
17:48 Changeset [122173] by jsbell@chromium.org
  • 6 edits in trunk

IndexedDB: A null or undefined storeNames argument to IDBDatabase::transaction() should be coerced to string
https://bugs.webkit.org/show_bug.cgi?id=90474

Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/transaction-basics.html

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabase.idl:

LayoutTests:

  • storage/indexeddb/resources/transaction-basics.js:

(testInvalidMode):
(testDegenerateNames.request.onsuccess):
(testDegenerateNames.verifyDegenerateNames):
(testDegenerateNames):

  • storage/indexeddb/transaction-basics-expected.txt:
17:41 Changeset [122172] by jsbell@chromium.org
  • 17 edits in trunk/Source

IndexedDB: Remove obsolete accessor plumbing
https://bugs.webkit.org/show_bug.cgi?id=90812

Reviewed by Tony Chang.

Source/WebCore:

No new tests - just deleting code.

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction): Since backend mode() is disconnected, can no
longer assert that front-end/back-end modes match; not worth it to keeping the plumbing.

Source/WebKit/chromium:

  • public/WebIDBCursor.h: Remove direction.
  • public/WebIDBDatabase.h: Remove name, version, objectStoreNames;

(WebKit::WebIDBDatabase::metadata):

  • public/WebIDBIndex.h: Remove name, keyPath, unique, multiEntry;
  • public/WebIDBObjectStore.h: Remove name, keyPath, indexNames, autoIncrement;
  • src/IDBDatabaseBackendProxy.cpp: Remove plumbing.
  • src/IDBDatabaseBackendProxy.h: Remove plumbing.

(IDBDatabaseBackendProxy):

  • src/IDBIndexBackendProxy.cpp: Remove plumbing.
  • src/IDBIndexBackendProxy.h: Remove plumbing.

(IDBIndexBackendProxy):

  • src/IDBObjectStoreBackendProxy.cpp: Remove plumbing.
  • src/IDBObjectStoreBackendProxy.h: Remove plumbing.

(IDBObjectStoreBackendProxy):

  • src/IDBTransactionBackendProxy.cpp: Remove plumbing.
  • src/IDBTransactionBackendProxy.h: Assert stub is not used - only needed

by real IDBTransactionBackendImpl
(WebKit::IDBTransactionBackendProxy::mode):

  • src/WebIDBTransactionImpl.cpp: Remove plumbing.
  • src/WebIDBTransactionImpl.h: Remove plumbing.
17:20 Changeset [122171] by commit-queue@webkit.org
  • 15 edits
    2 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r122161.
http://trac.webkit.org/changeset/122161
https://bugs.webkit.org/show_bug.cgi?id=90837

failed to compile on chromium webkit linux bot (Requested by
shawnsingh on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-09

  • WebKit.gypi:
  • WebKitUnitTests.gyp:
  • public/WebDOMMessageEvent.h:
  • tests/AssociatedURLLoaderTest.cpp:

(WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest):
(WebKit::AssociatedURLLoaderTest::SetUp):
(WebKit::AssociatedURLLoaderTest::CheckMethodFails):
(WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
(WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders):
(WebKit::TEST_F):

  • tests/EventListenerTest.cpp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::registerMockedURLLoad):
(FrameTestHelpers):
(WebKit::FrameTestHelpers::loadFrame):

  • tests/FrameTestHelpers.h:

(FrameTestHelpers):

  • tests/ListenerLeakTest.cpp:

(WebKit::ListenerLeakTest::RunTest):

  • tests/PopupMenuTest.cpp:

(WebKit::SelectPopupMenuTest::registerMockedURLLoad):
(WebKit::SelectPopupMenuTest::loadFrame):
(WebKit::TEST_F):

  • tests/RunAllTests.cpp:
  • tests/URLTestHelpers.cpp: Removed.
  • tests/URLTestHelpers.h: Removed.
  • tests/WebFrameTest.cpp:

(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):

  • tests/WebPageNewSerializerTest.cpp:

(WebKit::WebPageNewSerializeTest::registerMockedURLLoad):
(WebPageNewSerializeTest):
(WebKit::WebPageNewSerializeTest::setUpCSSTestPage):
(WebKit::WebPageNewSerializeTest::loadURLInTopFrame):
(WebKit::WebPageNewSerializeTest::resourceVectorContains):
(WebKit::TEST_F):

  • tests/WebPageSerializerTest.cpp:

(WebKit::WebPageSerializerTest::registerMockedURLLoad):
(WebKit::WebPageSerializerTest::loadURLInTopFrame):
(WebKit::WebPageSerializerTest::webVectorContains):
(WebKit::TEST_F):

  • tests/WebViewTest.cpp:

(WebKit::TEST_F):
(WebKit::WebViewTest::testAutoResize):
(WebKit::WebViewTest::testTextInputType):

17:17 Changeset [122170] by danakj@chromium.org
  • 3 edits in trunk/Source/WebCore

[chromium] Remove HashMap workaround for layers with id=0 in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=90825

Reviewed by Adrienne Walker.

Layer ids are no longer allowed to be 0, and the behaviour is guarded
with asserts, so this workaround is not needed any longer.

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(CCDamageTracker):

17:08 Changeset [122169] by scheib@chromium.org
  • 3 edits
    2 adds in trunk

Pointer Lock requestPointerLock rejects locking an element not in a document.
https://bugs.webkit.org/show_bug.cgi?id=90821

Reviewed by Adrienne Walker.

Source/WebCore:

Test: pointer-lock/lock-element-not-in-dom.html

  • page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):

LayoutTests:

  • pointer-lock/lock-element-not-in-dom-expected.txt: Added.
  • pointer-lock/lock-element-not-in-dom.html: Added.
16:48 Changeset [122168] by eric@webkit.org
  • 8 edits
    3 adds in trunk

document.write of scripts that also document.write sometimes writes async
https://bugs.webkit.org/show_bug.cgi?id=89102

Reviewed by Adam Barth.

Source/WebCore:

When a script tag is first encountered, the TreeBuilder holds the element and returns
out to the outer HTMLDocumentParser parse loop. The HTMLDocumentParser then takes
the script element and passes it to the HTMLScriptRunner for execution. However, if the
script is an "external script" the HTMLScriptRunner may have to wait for that parser
blocking script to load, and may store the script in its own m_parserBlockingScript member.

While the HTMLScriptRunner has this not-yet-loaded-script the parser is also blocked.
Because the "paused" state of the parser was held as a separate bool on the TreeBuilder
we'd have to be careful to update it to reflect the current state of this pending script
on the HTMLScriptRunner.

This patch removes this separate "paused" bool and makes the HTMLDocumentParser responsible
for the "paused" state of the parser through the isWaitingForScripts() function which
knows how to check both the TreeBuilder and the ScriptRunner for possible parser-blocking scripts.

I suspect this change may actually fix a bunch of edge cases where we were not
checking for the HTMLScriptRunner's parser blocking script and thus incorrectly ending
the parser, or not starting the pre-load scanner, etc.

As part of this change I also renamed m_haveParsingBlockingScript in HTMLScriptRunner to match
the naming style used elsewhere in the parser, as well as removed all the "bool" return values
for these parse/execute functions as they are no longer useful (or correct). The correct way
is always to check HTMLDocumentParser::isWaitingForScripts().

Test: fast/parser/cached-script-document-write.html

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizerIfPossible):
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
(WebCore::HTMLDocumentParser::canTakeNextToken):
(WebCore::HTMLDocumentParser::isWaitingForScripts):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
(WebCore::HTMLDocumentParser::notifyFinished):
(WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets):

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::~HTMLScriptRunner):
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::hasParserBlockingScript):
(WebCore::HTMLScriptRunner::executeParsingBlockingScripts):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::requestParsingBlockingScript):
(WebCore::HTMLScriptRunner::runScript):

  • html/parser/HTMLScriptRunner.h:

(HTMLScriptRunner):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::takeScriptToProcess):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::hasParserBlockingScript):

LayoutTests:

  • fast/parser/cached-script-document-write-expected.txt: Added.
  • fast/parser/cached-script-document-write.html: Added.
  • fast/parser/resources/cached-script-document-write.js: Added.
16:28 Changeset [122167] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

Source/JavaScriptCore: DFG may get stuck in an infinite fix point if it constant folds a mispredicted node
https://bugs.webkit.org/show_bug.cgi?id=90829
<rdar://problem/11823843>

Reviewed by Oliver Hunt.

If a node is shown to have been mispredicted during CFA, then don't allow constant
folding to make the graph even more degenerate. Instead, pull back on constant folding
and allow the normal OSR machinery to fix our profiling so that a future recompilation
doesn't see the same mistake.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::trySetConstant):
(AbstractState):

  • dfg/DFGPhase.h:

(JSC::DFG::Phase::name):
(Phase):
(JSC::DFG::runAndLog):
(DFG):
(JSC::DFG::runPhase):

LayoutTests: DFG may get stuck in an infinite fix point if it constant folds a mispredicted node
https://bugs.webkit.org/show_bug.cgi?id=90829

Reviewed by Oliver Hunt.

  • fast/js/dfg-constant-fold-misprediction-expected.txt: Added.
  • fast/js/dfg-constant-fold-misprediction.html: Added.
  • fast/js/script-tests/dfg-constant-fold-misprediction.js: Added.

(foo):

16:26 Changeset [122166] by fpizlo@apple.com
  • 25 edits
    6 adds in trunk/Source

It should be possible to jettison JIT stub routines even if they are currently running
https://bugs.webkit.org/show_bug.cgi?id=90731

Reviewed by Gavin Barraclough.

This gives the GC awareness of all JIT-generated stubs for inline caches. That
means that if you want to delete a JIT-generated stub, you don't have to worry
about whether or not it is currently running: if there is a chance that it might
be, the GC will kindly defer deletion until non-running-ness is proved.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/Instruction.h:

(JSC):
(PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):

  • bytecode/PolymorphicPutByIdList.cpp:

(JSC::PutByIdAccess::fromStructureStubInfo):

  • bytecode/PolymorphicPutByIdList.h:

(JSC::PutByIdAccess::transition):
(JSC::PutByIdAccess::replace):
(JSC::PutByIdAccess::stubRoutine):
(PutByIdAccess):
(JSC::PolymorphicPutByIdList::currentSlowPathTarget):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::reset):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):

  • heap/ConservativeRoots.cpp:

(JSC):
(DummyMarkHook):
(JSC::DummyMarkHook::mark):
(JSC::ConservativeRoots::add):
(CompositeMarkHook):
(JSC::CompositeMarkHook::CompositeMarkHook):
(JSC::CompositeMarkHook::mark):

  • heap/ConservativeRoots.h:

(JSC):
(ConservativeRoots):

  • heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::deleteUnmarkedCompiledCode):

  • heap/Heap.h:

(JSC):
(Heap):

  • heap/JITStubRoutineSet.cpp: Added.

(JSC):
(JSC::JITStubRoutineSet::JITStubRoutineSet):
(JSC::JITStubRoutineSet::~JITStubRoutineSet):
(JSC::JITStubRoutineSet::add):
(JSC::JITStubRoutineSet::clearMarks):
(JSC::JITStubRoutineSet::markSlow):
(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):
(JSC::JITStubRoutineSet::traceMarkedStubRoutines):

  • heap/JITStubRoutineSet.h: Added.

(JSC):
(JITStubRoutineSet):
(JSC::JITStubRoutineSet::mark):

  • heap/MachineStackMarker.h:

(JSC):

  • interpreter/RegisterFile.cpp:

(JSC::RegisterFile::gatherConservativeRoots):

  • interpreter/RegisterFile.h:

(JSC):

  • jit/ExecutableAllocator.cpp:

(JSC::DemandExecutableAllocator::DemandExecutableAllocator):

  • jit/ExecutableAllocator.h:

(JSC):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC):
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):

  • jit/GCAwareJITStubRoutine.cpp: Added.

(JSC):
(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::~GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::observeZeroRefCount):
(JSC::GCAwareJITStubRoutine::deleteFromGC):
(JSC::GCAwareJITStubRoutine::markRequiredObjectsInternal):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::MarkingGCAwareJITStubRoutineWithOneObject):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::~MarkingGCAwareJITStubRoutineWithOneObject):
(JSC::MarkingGCAwareJITStubRoutineWithOneObject::markRequiredObjectsInternal):
(JSC::createJITStubRoutine):

  • jit/GCAwareJITStubRoutine.h: Added.

(JSC):
(GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::markRequiredObjects):
(MarkingGCAwareJITStubRoutineWithOneObject):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITStubRoutine.cpp: Added.

(JSC):
(JSC::JITStubRoutine::~JITStubRoutine):
(JSC::JITStubRoutine::observeZeroRefCount):

  • jit/JITStubRoutine.h: Added.

(JSC):
(JITStubRoutine):
(JSC::JITStubRoutine::JITStubRoutine):
(JSC::JITStubRoutine::createSelfManagedRoutine):
(JSC::JITStubRoutine::code):
(JSC::JITStubRoutine::asCodePtr):
(JSC::JITStubRoutine::ref):
(JSC::JITStubRoutine::deref):
(JSC::JITStubRoutine::startAddress):
(JSC::JITStubRoutine::endAddress):
(JSC::JITStubRoutine::addressStep):
(JSC::JITStubRoutine::canPerformRangeFilter):
(JSC::JITStubRoutine::filteringStartAddress):
(JSC::JITStubRoutine::filteringExtentSize):
(JSC::JITStubRoutine::passesFilter):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):

16:21 Changeset [122165] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

fast/js/global-constructors.html is flaky and mostly useless
https://bugs.webkit.org/show_bug.cgi?id=90833

Unreviewed, skip flaky and useless test.

  • platform/mac/Skipped:
16:10 Changeset [122164] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marked webgl/glsl-conformance tests failing after dependency roll in chromium.

  • platform/chromium/TestExpectations:
16:07 Changeset [122163] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Microdata tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=90830

Reviewed by Antti Koivisto.

The bug was caused by SpaceSplitString's not copying on write properly.
Even if there was exactly one owner of the SpaceSplitString, we should still not modify
m_data since m_data is associated with a particular m_keyString in sharedDataMap().

The only situation in which we can safely modify m_data is when m_data's m_keyString is null
meaning that it had been unique'ed. Furthermore, this optimization had not been used for
class lists because class list's refCount is always zero as its ref and deref are forwarded
to the associated Element's ref and deref. This fix re-enables the optimization for class lists.

This behavior change is tested by existing microdata API tests. Without this patch,
some tests such as properties-collection-add-remove-property.html fail on the first run
when several tests were ran in the same WebKit instance.

  • dom/SpaceSplitString.h:

(WebCore::SpaceSplitStringData::isUnique):
(WebCore::SpaceSplitString::ensureUnique):

16:05 Changeset [122162] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=90817

Patch by Yong Li <yoli@rim.com> on 2012-07-09
Reviewed by Rob Buis.

PR# 174085.
PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate to avoid crashes.
This patch also removes unused variable m_parentPopup and its setter.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Remove m_parentPopup.

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::closePagePopup):

  • WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::PagePopupBlackBerry::init): Remove the setParentPopup() call.
(WebCore::PagePopupBlackBerry::closePopup): Clear the reference in WebPagePrivate.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::setValueAndClosePopup): Add an assert for valid m_element.

16:03 Changeset [122161] by shawnsingh@chromium.org
  • 15 edits
    1 copy
    1 add in trunk/Source/WebKit/chromium

[chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90094

Reviewed by Adam Barth.

This patch adds the WEBKIT_IMPLEMENTATION = 1 define to
WebKitUnitTests.gyp. To get it to compile correctly, some string
and URL code was refactored, and GURL types were replaced with KURL types.

  • WebKit.gypi:
  • WebKitUnitTests.gyp:
  • public/WebDOMMessageEvent.h:

(WebKit::WebDOMMessageEvent::WebDOMMessageEvent):

  • tests/AssociatedURLLoaderTest.cpp:
  • tests/EventListenerTest.cpp:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::loadFrame):

  • tests/FrameTestHelpers.h:
  • tests/ListenerLeakTest.cpp:

(WebKit::ListenerLeakTest::RunTest):

  • tests/PopupMenuTest.cpp:
  • tests/RunAllTests.cpp:
  • tests/URLTestHelpers.cpp: Added.

(URLTestHelpers):
(WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
(WebKit::URLTestHelpers::registerMockedURLLoad):

  • tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h.

(WebKit):
(URLTestHelpers):
(WebKit::URLTestHelpers::toKURL):

  • tests/WebFrameTest.cpp:
  • tests/WebPageNewSerializerTest.cpp:
  • tests/WebPageSerializerTest.cpp:
  • tests/WebViewTest.cpp:
15:31 Changeset [122160] by danakj@chromium.org
  • 24 edits in trunk/Source

[chromium] Decouple RenderPass drawing from CCRenderSurface
https://bugs.webkit.org/show_bug.cgi?id=90573

Reviewed by Adrienne Walker.

Source/WebCore:

Removes the managed textures from CCRenderSurface and stores them in a
HashMap in LayerRendererChromium.

At the start of a frame, all textures for the frame are reserved, and
unneeded textures are deleted. After each quad is drawn, evicted textures
(ie temporary textures used for background filters) are deleted to keep
within memory limits. At the end of the frame, all surface contents
textures are kept reserved and thus not deleted.

We add a numeric identifier to CCRenderPass which can be used to
identify the pass across serialization in the future, and is used
in the interface to LayerRendererChromium. Also we add to the
CCRenderPass a contentsChangedSinceLastFrame() flag so that the
value does not need to be retrieved from the CCRenderSurface.

The pointer from CCRenderPass to CCRenderSurface remains for some
code in the CCLayerTreeHostImpl, and will be addressed in the future, but
the pointer is no longer used at all while drawing a frame inside
LayerRendererChromium.

Covered by existing tests, no intended change in behaviour.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::releaseRenderPassTextures):
(WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
(WebCore):
(WebCore::LayerRendererChromium::haveCachedResourcesForRenderPassId):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderPass):
(WebCore::LayerRendererChromium::initializeSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore::CCRenderPass::setFramebufferOutputRect):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:

(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):

  • platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:

(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):
(WebCore::CCRenderPassDrawQuad::contentsChangedSinceLastFrame):

  • platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::appendQuads):

  • platform/graphics/chromium/cc/CCRenderSurface.h:

(WebCore):
(CCRenderSurface):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRenderer):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::pushTileProperties):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:

(FakeCCRendererClient::FakeCCRendererClient):

14:34 Changeset [122159] by adamk@chromium.org
  • 39 edits
    5 moves in trunk

Rename WebCore::WebKitMutationObserver to WebCore::MutationObserver
https://bugs.webkit.org/show_bug.cgi?id=90810

Reviewed by Ojan Vafai.

Source/WebCore:

This is in preparation for removing the vendor prefix from the
MutationObserver constructor on Window (currently it's called
WebKitMutationObserver). Doing the WebCore-internal rename first
makes that change a much smaller one, which is especially useful
because there's ongoing discussion of when the prefix should be
removed from the web-facing API.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSMainThreadExecState.cpp:

(WebCore::JSMainThreadExecState::didLeaveScriptContext):

  • bindings/js/JSMutationCallbackCustom.cpp:

(WebCore::JSMutationCallback::handleEvent):

  • bindings/js/JSMutationObserverCustom.cpp: Renamed from Source/WebCore/bindings/js/JSWebKitMutationObserverCustom.cpp.

(WebCore):
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver):

  • bindings/v8/V8RecursionScope.cpp:

(WebCore::V8RecursionScope::didLeaveScriptContext):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp:

(WebCore::V8MutationCallback::handleEvent):

  • bindings/v8/custom/V8MutationObserverCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitMutationObserverCustom.cpp.

(WebCore):
(WebCore::V8MutationObserver::constructorCallback):

  • dom/CharacterData.cpp:
  • dom/ChildListMutationScope.h:

(WebCore::ChildListMutationScope::ChildListMutationScope):

  • dom/DOMAllInOne.cpp:
  • dom/Document.h:

(WebCore::Document::hasMutationObserversOfType):

  • dom/Element.cpp:
  • dom/MutationCallback.h:

(WebCore):
(MutationCallback):

  • dom/MutationCallback.idl:
  • dom/MutationObserver.cpp: Renamed from Source/WebCore/dom/WebKitMutationObserver.cpp.

(WebCore):
(WebCore::MutationObserver::ObserverLessThan::operator()):
(WebCore::MutationObserver::create):
(WebCore::MutationObserver::MutationObserver):
(WebCore::MutationObserver::~MutationObserver):
(WebCore::MutationObserver::validateOptions):
(WebCore::MutationObserver::observe):
(WebCore::MutationObserver::takeRecords):
(WebCore::MutationObserver::disconnect):
(WebCore::MutationObserver::observationStarted):
(WebCore::MutationObserver::observationEnded):
(WebCore::activeMutationObservers):
(WebCore::MutationObserver::enqueueMutationRecord):
(WebCore::MutationObserver::setHasTransientRegistration):
(WebCore::MutationObserver::deliver):
(WebCore::MutationObserver::deliverAllMutations):

  • dom/MutationObserver.h: Renamed from Source/WebCore/dom/WebKitMutationObserver.h.

(WebCore):
(MutationObserver):

  • dom/MutationObserver.idl: Renamed from Source/WebCore/dom/WebKitMutationObserver.idl.
  • dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::createIfNeeded):
(WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup):
(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):

  • dom/MutationObserverInterestGroup.h:

(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(MutationObserverInterestGroup):

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::create):
(WebCore::MutationObserverRegistration::MutationObserverRegistration):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):

  • dom/MutationObserverRegistration.h:

(MutationObserverRegistration):
(WebCore::MutationObserverRegistration::isSubtree):
(WebCore::MutationObserverRegistration::observer):
(WebCore::MutationObserverRegistration::deliveryOptions):
(WebCore::MutationObserverRegistration::mutationTypes):

  • dom/Node.cpp:

(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):
(WebCore::Node::registerMutationObserver):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:
  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • src/WebKit.cpp:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::deliverAllMutationsIfNecessary):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::deliverAllMutationsIfNecessary):

Tools:

  • DumpRenderTree/gtk/EventSender.cpp:
14:19 Changeset [122158] by scheib@chromium.org
  • 13 edits
    2 adds in trunk/LayoutTests

Refactor common Pointer Lock test code to a harness.
https://bugs.webkit.org/show_bug.cgi?id=90813

Reviewed by Adrienne Walker.

  • pointer-lock/bug90391-move-then-window-open-crash-expected.txt:
  • pointer-lock/bug90391-move-then-window-open-crash.html:
  • pointer-lock/lock-already-locked-expected.txt:
  • pointer-lock/lock-already-locked.html:
  • pointer-lock/lock-fail-responses-expected.txt:
  • pointer-lock/lock-fail-responses.html:
  • pointer-lock/mouse-event-delivery-expected.txt:
  • pointer-lock/mouse-event-delivery.html:
  • pointer-lock/pointer-lock-api-expected.txt:
  • pointer-lock/pointer-lock-api.html:
  • pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
  • pointer-lock/pointerlocklost-event-expected.txt:
  • pointer-lock/pointerlocklost-event.html:
  • pointer-lock/resources/pointer-lock-test-harness.js: Added.

(doNextStep.else):
(doNextStepWithUserGesture):
(eventExpected.targetHanderNode.eventHandlerName):
(eventExpected):
(expectOnlyChangeEvent):
(expectOnlyErrorEvent):
(expectNoEvents):

14:19 Changeset [122157] by cevans@google.com
  • 1 edit in branches/chromium/1180/Source/WebKit/chromium/features.gypi

Revert 116356
BUG=135658
Review URL: https://chromiumcodereview.appspot.com/10758010

14:12 Changeset [122156] by fpizlo@apple.com
  • 21 edits in trunk/Source/WebCore

Unreviewed, rolling out http://trac.webkit.org/changeset/122116 and http://trac.webkit.org/changeset/122119

  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext3D.h:

(WebCore):

  • platform/graphics/OpenGLESShims.h:
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore):

  • platform/graphics/clutter/GraphicsContext3DClutter.cpp:

(WebCore):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore):

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::Extensions3DOpenGL):
(WebCore::Extensions3DOpenGL::supports):
(WebCore):
(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):
(WebCore::Extensions3DOpenGL::getGraphicsResetStatusARB):
(WebCore::Extensions3DOpenGL::getTranslatedShaderSourceANGLE):
(WebCore::Extensions3DOpenGL::copyTextureCHROMIUM):

  • platform/graphics/opengl/Extensions3DOpenGL.h:

(Extensions3DOpenGL):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
  • platform/graphics/opengl/Extensions3DOpenGLCommon.h:
  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:
  • platform/graphics/opengl/Extensions3DOpenGLES.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::systemAllowsMultisamplingOnATICards):
(WebCore):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::getExtensions):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore):

13:52 Changeset [122155] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

Build fix after r122115 and some cleanups.

  • html/HTMLCollection.h:

(HTMLCollection):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::properties):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

13:46 Changeset [122154] by mihaip@chromium.org
  • 2 edits in trunk/Tools

Handle missing results in TestResultsServer better
https://bugs.webkit.org/show_bug.cgi?id=90816

Reviewed by Ojan Vafai.

If we can't load the results JSON, don't try to wrap it with the JSONP
callback invocation.

  • TestResultServer/handlers/testfilehandler.py:

(GetFile.get):

13:46 Changeset [122153] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit2

[WK2] Add missing Battery Status API integration to WebContext and WebPage
https://bugs.webkit.org/show_bug.cgi?id=90784

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-09
Reviewed by Anders Carlsson.

Integrate Battery Status API to WebPage, WebContext and
properly route messages to the WebBatteryManagerProxy.
Without this, the Battery Status tests are crashing for
WebKit2.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetBatteryManager):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):

  • UIProcess/WebContext.h:

(WebKit):
(WebContext):
(WebKit::WebContext::batteryManagerProxy):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):

  • WebProcess/WebCoreSupport/WebBatteryClient.cpp:

(WebKit::WebBatteryClient::setController):
(WebKit):

  • WebProcess/WebCoreSupport/WebBatteryClient.h:

(WebBatteryClient):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

13:36 Changeset [122152] by dino@apple.com
  • 6 edits in trunk

Tiled drawing means some elements can disappear behind the page
https://bugs.webkit.org/show_bug.cgi?id=88906

Reviewed by Simon Fraser.

Source/WebCore:

The compositing layers in the tile cache could become siblings
of the compositing layers for page elements. This meant that in
some 3d transforms, the elements could disappear behind the
page background (which is rendered into the tile cache) or intersect
with the tile cache tiles.

Fix this by inserting a flattening layer between the tile cache
and the page, ensuring that the cache will always be rendered
first. I was able to reuse the clipping layer for this, because
the tile cache is attached to the RenderView, so there should never
be a case where we have both a clipping layer and tiles.

The unfortunate part of this code is the temporary state variable
that wraps the call to GraphicsLayer::create. Because that method
calls back into the object, we need to make sure we don't create
another tile cache.

Also added some obvious names to the tile cache layers to
help with debugging.

Test: compositing/tile-cache-must-flatten.html

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache): give the tile host layer a name.
(WebCore::TileCache::createTileLayer):

  • platform/graphics/ca/mac/WebTileCacheLayer.mm:

(WebCore): give each tile layer a name.

  • rendering/RenderLayerBacking.cpp:

(WebCore):
(WebCore::RenderLayerBacking::shouldUseTileCache): check if we're in the middle
of creating the primary graphics layer before answering.
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): wrap our call to
createGraphicsLayer with a message to indicate we are making the layer that should
get a tile cache.
(WebCore::RenderLayerBacking::destroyGraphicsLayers):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): needs to make
sure the flattening layer is in the tree.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateInternalHierarchy):
(WebCore::RenderLayerBacking::updateClippingLayers):
(WebCore::RenderLayerBacking::backingStoreMemoryEstimate):

  • rendering/RenderLayerBacking.h: rename m_clippingLayer to m_containmentLayer

because it can now either be the clip or the tile cache flattener. Also
a new state property used when creating the main graphics layer.
(WebCore::RenderLayerBacking::hasClippingLayer):
(WebCore::RenderLayerBacking::clippingLayer):
(WebCore::RenderLayerBacking::parentForSublayers):
(WebCore::RenderLayerBacking::hasTileCacheFlatteningLayer):
(WebCore::RenderLayerBacking::tileCacheFlatteningLayer):
(RenderLayerBacking):

LayoutTests:

Reftest to make sure elements can't disappear behind the tile cache.

  • compositing/tile-cache-must-flatten-expected.html: Added.
  • compositing/tile-cache-must-flatten.html: Added.
13:10 Changeset [122151] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r122124.
http://trac.webkit.org/changeset/122124
https://bugs.webkit.org/show_bug.cgi?id=90815

It broke NRWT on Qt (Requested by Ossy_HOME on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-09

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._skipped_file_search_paths):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest._assert_skipped_path):
(QtPortTest.test_skipped_file_search_path):

12:59 Changeset [122150] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Log significant Gamepad API-related events
https://bugs.webkit.org/show_bug.cgi?id=90595

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-09
Reviewed by Antonio Gomes.

Log significant Gamepad API-related events in
GamepadsEfl.

No new tests, no behavior change.

  • platform/efl/GamepadsEfl.cpp:

(WebCore::GamepadDeviceEfl::deviceFile):
(GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::readCallback):
(WebCore::GamepadsEfl::registerDevice):
(WebCore::GamepadsEfl::unregisterDevice):

12:58 Changeset [122149] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1180

Merge 120731
BUG=132690
Review URL: https://chromiumcodereview.appspot.com/10763008

12:57 Changeset [122148] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 120731
BUG=132690
Review URL: https://chromiumcodereview.appspot.com/10750009

12:53 Changeset [122147] by zandobersek@gmail.com
  • 35 edits
    2 adds in trunk

[Gtk] Implement dumpFrameScrollPosition in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=89356

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add a new method for returning the WebKitDOMDocument that is loaded
in a given frame, webkit_web_frame_get_dom_document.

  • docs/webkitgtk-sections.txt:
  • webkit/webkitwebframe.cpp:

(webkit_web_frame_get_dom_document):

  • webkit/webkitwebframe.h:
  • webkit/webkitwebview.cpp: State explicitly that the document being returned

when calling webkit_web_view_get_dom_document is loaded in the main frame.
Also call the webkit_web_frame_get_dom_document on WebKitWebView's main frame
to get the document.

Tools:

Implement dumpFrameScrollPosition, acquiring the scroll position
through WebKitDOMDOMWindow of the WebKitDOMDocument loaded in the frame
whose scroll position is being dumped.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(dumpFrameScrollPosition):

LayoutTests:

Update baselines for affected tests, removing these tests from the GTK WK2 Skipped list.

  • platform/gtk-wk2/Skipped:
  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt:
  • platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.txt:
  • platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt:
  • platform/gtk/fast/dom/focus-contenteditable-expected.txt:
  • platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt:
  • platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt:
  • platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt:
  • platform/gtk/fast/dynamic/anchor-lock-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/reveal-link-when-focused-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/gtk/fast/layers/scroll-rect-to-visible-expected.txt:
  • platform/gtk/fast/multicol/scrolling-overflow-expected.txt: Added.
  • platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
  • platform/gtk/fast/overflow/overflow_hidden-expected.txt:
  • platform/gtk/fast/overflow/position-fixed-transform-clipping-expected.txt:
  • platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-tranformed-expected.txt:
  • platform/gtk/fast/repaint/repaint-during-scroll-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
  • platform/gtk/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/gtk/transforms/2d/transform-fixed-container-expected.txt:
12:53 Changeset [122146] by cevans@google.com
  • 1 edit in branches/chromium/1180/Source/WebCore/loader/DocumentThreadableLoader.cpp

Merge 120845
BUG=132241
Review URL: https://chromiumcodereview.appspot.com/10750008

12:52 Changeset [122145] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

Reduce the amount of flashing when falling into tiled layers
https://bugs.webkit.org/show_bug.cgi?id=90808

Reviewed by Dean Jackson.

Implement +prefetchedTiles so that CATiledLayer renders more
tiles at a time, reducing the appearance of flashing.

  • platform/graphics/mac/WebTiledLayer.mm:

(+[WebTiledLayer prefetchedTiles]):

12:51 Changeset [122144] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 120845
BUG=132241
Review URL: https://chromiumcodereview.appspot.com/10765006

12:42 Changeset [122143] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1180

Merge 121491
BUG=134428
Review URL: https://chromiumcodereview.appspot.com/10762005

12:41 Changeset [122142] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 121491
BUG=134428
Review URL: https://chromiumcodereview.appspot.com/10762004

12:39 Changeset [122141] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1180

Merge 121388
BUG=134305
Review URL: https://chromiumcodereview.appspot.com/10756010

12:37 Changeset [122140] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1132

Merge 121388
BUG=134305
Review URL: https://chromiumcodereview.appspot.com/10763005

12:36 Changeset [122139] by leandrogracia@chromium.org
  • 7 edits in trunk

SurroundingText should not advance character iterators if they are at end.
https://bugs.webkit.org/show_bug.cgi?id=90560

Reviewed by Ryosuke Niwa.

Source/WebCore:

CharacterIterator and BackwardsCharacterIterator try to advance their
internal TextIterator without checking if they already are at end.
This can cause crashes in TextIterator::advance.

Test: platform/chromium/editing/surrounding-text/surrounding-text.html

  • editing/SurroundingText.cpp:

(WebCore::SurroundingText::SurroundingText):
(WebCore::SurroundingText::rangeFromContentOffsets):

Source/WebKit/chromium:

Moving the check for null visible positions to WebCore as it makes no
sense to be in a platform-specific code.

  • src/WebSurroundingText.cpp:

(WebKit::WebSurroundingText::initialize):

LayoutTests:

Add a new test case where character iterators are already at end when
trying to advance. This was caught by Chromium's address sanitizer
here: http://code.google.com/p/chromium/issues/detail?id=135705

  • platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
  • platform/chromium/editing/surrounding-text/surrounding-text.html:
12:33 Changeset [122138] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1180

Merge 121031
BUG=134123
Review URL: https://chromiumcodereview.appspot.com/10750006

12:31 Changeset [122137] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 121031
BUG=134123
Review URL: https://chromiumcodereview.appspot.com/10757006

12:27 Changeset [122136] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] [WK2] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key)
https://bugs.webkit.org/show_bug.cgi?id=90464

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-09
Reviewed by Daniel Bates.

HashMap has the property that 0 is the empty value for integer
keys, so do not use 0 as a key in the HashMap.

  • Platform/efl/WorkQueueEfl.cpp:

(WorkQueue::dispatchAfterDelay):

12:27 Changeset [122135] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

[BlackBerry] meta viewport initial-scale doesn't factor in device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=90575

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-07-09
Reviewed by Rob Buis.

.:

Add a manual test to verify wide content doesn't interfere
with initial-scale calculations.

Internal review from Konrad Piascik.

  • ManualTests/blackberry/meta-viewport-initial-scale-wide-content.html: Added.

Source/WebKit/blackberry:

Refactor meta viewport handling to multiply the developer
specified scale properties by the devicePixelRatio. This
required moving the setting of these values until after
the call to computeViewportAttributes.

This fixes an isssue where content wider than the meta viewport
would case a zoom-out-to-fit scenario because we misinterpreted
the specified initial-scale.

New test to verify wide content doesn't affect initial-scale:
ManualTests/blackberry/meta-viewport-initial-scale-wide-content.html

Internal review from Konrad Piascik, Arvid Nilsson.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):

12:25 Changeset [122134] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] [WK2] Ecore errors from ecore_evas_screen_geometry_get()
https://bugs.webkit.org/show_bug.cgi?id=90609

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-09
Reviewed by Daniel Bates.

Do not call ecore_evas_screen_geometry_get() if ecoreEvas is null.

No new tests. This patch doesn't change behavior.

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore::screenRect): Early return if Evas is null.

12:19 Changeset [122133] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/1180

Merge 121001
BUG=133418
Review URL: https://chromiumcodereview.appspot.com/10729003

12:18 Changeset [122132] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Update TestExpectations after filename change in r122109.

  • platform/chromium/TestExpectations:
12:17 Changeset [122131] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/1132

Merge 121001
BUG=133418
Review URL: https://chromiumcodereview.appspot.com/10764007

12:16 Changeset [122130] by achicu@adobe.com
  • 6 edits
    10 adds in trunk

[CSS Filters] Blur filter is not repainted correctly when applied on a parent of a fixed element
https://bugs.webkit.org/show_bug.cgi?id=90087

Reviewed by Simon Fraser.

Source/WebCore:

Added a new method, RenderLayer::hasAncestorWithFilterOutsets, to check that there's no filter with outsets (ie. blur)
applied on top level fixed positioned elements, nor any of its parent layers. In the event of a blur filter we need to
disable the fast scrolling optimization, otherwise the outsets of the filter will be carried around the page and
repainting will not work correctly.

Tests: css3/filters/blur-filter-page-scroll-parents.html

css3/filters/blur-filter-page-scroll-self.html

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

  • rendering/RenderLayer.cpp:

(WebCore):
(WebCore::RenderLayer::hasAncestorWithFilterOutsets):

  • rendering/RenderLayer.h:

(RenderLayer):

LayoutTests:

Added two new tests to check that we disable fast path scrolling for fixed positioned
elements that have blur applied on them or any of the parent layers.

  • css3/filters/blur-filter-page-scroll-parents.html: Added.
  • css3/filters/blur-filter-page-scroll-self.html: Added.
  • platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png: Added.
  • platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.txt: Added.
  • platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.png: Added.
  • platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.txt: Added.
  • platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.png: Added.
  • platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.txt: Added.
  • platform/mac/css3/filters/blur-filter-page-scroll-self-expected.png: Added.
  • platform/mac/css3/filters/blur-filter-page-scroll-self-expected.txt: Added.
  • platform/qt/Skipped: Qt needs platform results.
12:06 Changeset [122129] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1180

Merge 120862
BUG=130595
Review URL: https://chromiumcodereview.appspot.com/10764006

12:04 Changeset [122128] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1132

Merge 120862
BUG=130595
Review URL: https://chromiumcodereview.appspot.com/10756009

12:04 Changeset [122127] by jsbell@chromium.org
  • 7 edits in trunk

IndexedDB: Empty arrays shouldn't be valid key paths
https://bugs.webkit.org/show_bug.cgi?id=90798

Reviewed by Tony Chang.

Source/WebCore:

Other IDB implementations already enforce this although it is not yet in
the spec (see https://www.w3.org/Bugs/Public/show_bug.cgi?id=17657). If an
empty array is passed as the key path arg to IDBDatabase.createObjectStore()
or IDBObjectStore.createIndex(), a SYNTAX_ERR DOMException is now thrown.

Test: storage/indexeddb/keypath-arrays.html

storage/indexeddb/keypath-basics.html

  • Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::IDBKeyPath::isValid): Test for empty array.

LayoutTests:

  • storage/indexeddb/keypath-arrays-expected.txt:
  • storage/indexeddb/keypath-basics-expected.txt:
  • storage/indexeddb/resources/keypath-arrays.js:

(openSuccess.request.onsuccess):
(openSuccess):

  • storage/indexeddb/resources/keypath-basics.js:
11:58 Changeset [122126] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/1180

Merge 120761
BUG=129936
Review URL: https://chromiumcodereview.appspot.com/10763003

11:57 Changeset [122125] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/1132

Merge 120761
BUG=129936
Review URL: https://chromiumcodereview.appspot.com/10765005

11:53 Changeset [122124] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Qt][NRWT] Enable cascaded TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=89108

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-09
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.expectations_files):

  • Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest._assert_expectations_files):
(QtPortTest.test_expectations_files):

11:52 Changeset [122123] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1180

Merge 120801
BUG=129898
Review URL: https://chromiumcodereview.appspot.com/10759003

11:50 Changeset [122122] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1132

Merge 120801
BUG=129898
Review URL: https://chromiumcodereview.appspot.com/10770002

11:48 Changeset [122121] by cevans@google.com
  • 1 edit in branches/chromium/1180/Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp

Merge 121160
BUG=128151
Review URL: https://chromiumcodereview.appspot.com/10748005

11:37 Changeset [122120] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Create render surfaces on main thread only for the current frame
https://bugs.webkit.org/show_bug.cgi?id=89793

Reviewed by Adrienne Walker.

Source/WebCore:

Previously we would create render surfaces for animating layers
in the main thread since these layers might have a surface on impl,
in order to assist culling. This makes it very difficult to estimate
how much texture memory is needed for RenderSurfaces on the main
thread, in order to keep contents+surface memory below our limit.

Here we stop doing this, and create RenderSurfaces on both threads
under the same conditions, so main thread has surfaces only if the
layers in its current frame demand them. While this may reduce
paint culling within an animating subtree, this seems like an edge
case and knowing the amount of surface memory needed for the frame
is important.

Animation tests in CCLayerTreeHostCommonTest used to verify that these
layers got surfaces, so now no longer do. Creation of surfaces under
other conditions is covered by other CCLayerTreeHostCommonTests.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::subtreeShouldRenderToSeparateSurface):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:
11:32 Changeset [122119] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac build fix after r122116.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
11:25 Changeset [122118] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

EFL build fix after r122115.

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):

11:25 Changeset [122117] by mitz@apple.com
  • 2 edits in trunk/Tools

Fixed clean builds of the All target in the DumpRenderTree project.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode know that the

DumpRenderTree Perl Support target depends on the DumpRenderTree target.

11:00 Changeset [122116] by commit-queue@webkit.org
  • 16 edits
    2 copies
    3 adds in trunk/Source/WebCore

Make GC3D and E3D more maintainable for GLES platforms
https://bugs.webkit.org/show_bug.cgi?id=90567

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-09
Reviewed by Rob Buis.

This patch cleans up code for WebGL on OpenGLES platforms which use
GraphicsContext3DOpenGL* and Extensions3DOpenGL*. Although
GraphicsContext3DOpenGL was already split into GraphicsContext3DOpenGL,
GraphicsContext3DOpenGLCommon, and GraphicsContext3DOpenGLES, this patch
is an attempt to refactor this code in a way that will help BlackBerry and
other teams support WebGL on mobile platforms with as little use of
"#IF USE(OPENGL_ES_2)" in common code as possible. Also included is the
separation of Extensions3DOpenGL into Extensions3DOpenGLCommon,
Extensions3DOpenGL, and Extensions3DOpenGLES as well as the introduction
of OpenGLESShims.

This patch is created in large part by Jonathan Feldstein.

No new tests: no new behaviour.

  • PlatformBlackBerry.cmake: Recognize BlackBerry as OPENGL ES, add new files to build
  • Target.pri: Add new Extensions3DOpenGL* to WebGL builds
  • platform/graphics/GraphicsContext3D.h: Add validateDepthStencil, make systemAllowsMultisamplingOnATICards a a member function.

(WebCore):

  • platform/graphics/OpenGLESShims.h: Added.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Move code to Extensions3DOpenGLCommon where possible

(WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Reflect that it is now inherits Extensions3DCommon
(WebCore::Extensions3DOpenGL::supportsExtension): Contains OpenGL specific code from supports
(WebCore):
(WebCore::Extensions3DOpenGL::getExtensions): Returns a list of extensions

  • platform/graphics/opengl/Extensions3DOpenGL.h: Remove functions now in Extensions3DOpenGLCommon

(WebCore):
(Extensions3DOpenGL):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp: Added.

(WebCore):
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::~Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::supports):
(WebCore::Extensions3DOpenGLCommon::ensureEnabled):
(WebCore::Extensions3DOpenGLCommon::isEnabled):
(WebCore::Extensions3DOpenGLCommon::getGraphicsResetStatusARB):
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE): Existed before, but did nothing. Now does what is says it does.
(WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions): Moved from Extensions3DOpenGL::supports

  • platform/graphics/opengl/Extensions3DOpenGLCommon.h: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.

(WebCore):
(Extensions3DOpenGLCommon):

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp: Added.

(WebCore):
(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::~Extensions3DOpenGLES):
(WebCore::Extensions3DOpenGLES::framebufferTexture2DMultisampleIMG):
(WebCore::Extensions3DOpenGLES::renderbufferStorageMultisampleIMG):
(WebCore::Extensions3DOpenGLES::createVertexArrayOES):
(WebCore::Extensions3DOpenGLES::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGLES::isVertexArrayOES):
(WebCore::Extensions3DOpenGLES::bindVertexArrayOES):
(WebCore::Extensions3DOpenGLES::supportsExtension): Contains OpenGLES specific code from supports
(WebCore::Extensions3DOpenGLES::getExtensions):

  • platform/graphics/opengl/Extensions3DOpenGLES.h: Copied from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.

(WebCore):
(Extensions3DOpenGLES):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::validateAttributes):
(WebCore):
(WebCore::GraphicsContext3D::renderbufferStorage):
(WebCore::GraphicsContext3D::texImage2D):
(WebCore::GraphicsContext3D::systemAllowsMultisamplingOnATICards): Now a member function.
(WebCore::GraphicsContext3D::getExtensions):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::validateDepthStencil):
(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::isTexture):
(WebCore):
(WebCore::GraphicsContext3D::lineWidth):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::pixelStorei):
(WebCore::GraphicsContext3D::polygonOffset):
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::deleteBuffer):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::releaseShaderCompiler):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::validateAttributes):
(WebCore):
(WebCore::GraphicsContext3D::getExtensions):
(WebCore::GraphicsContext3D::systemAllowsMultisamplingOnATICards): Now a member function.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore):
(WebCore::GraphicsContext3D::releaseShaderCompiler):

10:40 Changeset [122115] by rniwa@webkit.org
  • 48 edits in trunk/Source

Make HTMLCollection RefCounted
https://bugs.webkit.org/show_bug.cgi?id=90414

Reviewed by Sam Weinig.

Source/WebCore:

Make HTMLCollection ref counted and stop forwarding ref and deref to its owner (m_base)
so as to align its life time management to that of DynamicNodeList.

After this patch, each HTMLCollection is owned by JSC/V8 and m_cachedCollections in ElementRareData
and m_collection in Document merely hold raw pointers for the caching purpose. These raw pointers
are cleared when each HTMLCollection is destructed via corresponding removeCachedHTMLCollection's.

In the destructor of HTMLCollection, we use the CollectionType to decide whether base() is an element
or an document, and call the appropriate removeCachedHTMLCollection except for WindowNamedItems and
DocumentNamedItems. For those two types, we need to know the atomic string name associated with
the collection just like many DynamicNodeList to remove the cache, so we let HTMLNameCollection
directly call removeWindowNamedItemCache and removeDocumentNamedItemCache. We'll cleanup this mess in
a follow up patch using a nice class hierarchy and virtual destructors.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getDocumentLinks):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedPropertyGetter):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::openSearchDescriptionURL):
(WebCore):
(WebCore::Document::cachedCollection):
(WebCore::Document::removeCachedHTMLCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::removeWindowNamedItemCache):
(WebCore::Document::removeDocumentNamedItemCache):

  • dom/Document.h:

(Document):

  • dom/Element.cpp:

(WebCore::Element::ensureCachedHTMLCollection):
(WebCore::ElementRareData::ensureCachedHTMLCollection):
(WebCore::Element::removeCachedHTMLCollection):
(WebCore):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::cachedHTMLCollection):
(WebCore::ElementRareData::removeCachedHTMLCollection):

  • html/CollectionType.h:

(WebCore): Since WindowNamedItems is not a part of UnnamedDocumentCachedType, we shouldn't addd 1.
(WebCore::isUnnamedDocumentCachedType):
(WebCore::isNodeCollectionType):

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):

  • html/HTMLAllCollection.h:

(HTMLAllCollection):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::HTMLCollection::itemAfter):

  • html/HTMLCollection.h:

(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollection):
(WebCore::HTMLCollection::base):

  • html/HTMLDataListElement.cpp:

(WebCore::HTMLDataListElement::options):

  • html/HTMLDataListElement.h:

(HTMLDataListElement):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children):
(WebCore::HTMLElement::properties):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::elements):

  • html/HTMLFieldSetElement.h:

(HTMLFieldSetElement):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::create):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::elements):

  • html/HTMLFormElement.h:

(HTMLFormElement):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::areas):

  • html/HTMLMapElement.h:

(HTMLMapElement):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::HTMLNameCollection):
(WebCore::HTMLNameCollection::~HTMLNameCollection):
(WebCore):

  • html/HTMLNameCollection.h:

(WebCore::HTMLNameCollection::create):
(HTMLNameCollection):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):

  • html/HTMLOptionsCollection.h:

(HTMLOptionsCollection):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::selectedOptions):
(WebCore::HTMLSelectElement::options):

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):

  • html/HTMLTableElement.h:

(HTMLTableElement):

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):

  • html/HTMLTableRowElement.h:

(HTMLTableRowElement):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::create):

  • html/HTMLTableRowsCollection.h:

(HTMLTableRowsCollection):

  • html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):

  • html/HTMLTableSectionElement.h:

(HTMLTableSectionElement):

Source/WebKit/chromium:

  • src/WebPageSerializer.cpp:

(WebCore::retrieveResourcesForFrame):

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::collectTargetFrames):

Source/WebKit/win:

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::forms):
(DOMHTMLSelectElement::options):

10:30 Changeset [122114] by pfeldman@chromium.org
  • 9 edits in trunk

Web Inspector: unindent line ending block upon { hit.
https://bugs.webkit.org/show_bug.cgi?id=90795

Reviewed by Vsevolod Vlasov.

Added block-start / block-end markup into the highlighter.

  • inspector/front-end/SourceCSSTokenizer.js:

(WebInspector.SourceCSSTokenizer.prototype.nextToken):

  • inspector/front-end/SourceCSSTokenizer.re2js:
  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._unindentAfterBlock):

10:24 Changeset [122113] by carlosgc@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] Add a setting to enable/disable page cache to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=90773

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_page_cache):
(webkit_settings_set_enable_page_cache):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

09:39 Changeset [122112] by zandobersek@gmail.com
  • 50 edits
    32 adds in trunk

[Gtk] Unskip the CSS Regions layout tests
https://bugs.webkit.org/show_bug.cgi?id=90771

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add a method to DumpRenderTreeSupportGtk for enabling or disabling
CSS Regions from DumpRenderTree.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setCSSRegionsEnabled):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Use the DumpRenderTreeSupportGtk method for enabling the CSS Regions,
calling it when resetting the defaults in DumpRenderTree or when the
settings value is overriden through the testRunner.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::overridePreference):

LayoutTests:

Unskip CSS Regions tests, updating baselines for the affected tests.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
  • platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
  • platform/gtk/fast/regions/flow-content-basic-expected.png: Added.
  • platform/gtk/fast/regions/flow-content-basic-expected.txt:
  • platform/gtk/fast/regions/flow-content-basic-vertical-expected.png: Added.
  • platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt:
  • platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
  • platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt:
  • platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
  • platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt:
  • platform/gtk/fast/regions/flows-dependency-same-flow-expected.png: Added.
  • platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt:
  • platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
  • platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
  • platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
  • platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
  • platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
  • platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
  • platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
  • platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt:
  • platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
  • platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt:
  • platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
  • platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.txt:
  • platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt:
  • platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt:
  • platform/gtk/fast/regions/region-style-block-background-color-expected.png: Added.
  • platform/gtk/fast/regions/region-style-block-background-color-expected.txt:
  • platform/gtk/fast/regions/region-style-block-background-color2-expected.png: Added.
  • platform/gtk/fast/regions/region-style-block-background-color2-expected.txt:
  • platform/gtk/fast/regions/text-region-split-small-pagination-expected.png: Added.
  • platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt:
  • platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
  • platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png:
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
  • platform/gtk/fast/repaint/region-painting-invalidation-expected.png:
  • platform/gtk/fast/repaint/region-painting-invalidation-expected.txt:
  • platform/gtk/fast/repaint/region-painting-via-layout-expected.png:
  • platform/gtk/fast/repaint/region-painting-via-layout-expected.txt:
09:32 Changeset [122111] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Memory leak in webkitwebnavigationaction.cpp
https://bugs.webkit.org/show_bug.cgi?id=90787

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-09
Reviewed by Martin Robinson.

Fixed a memory leak in WebKitWebNavigationAction.

  • webkit/webkitwebnavigationaction.cpp:

(webkit_web_navigation_action_finalize): Free the g_strdup()'d string.

08:39 Changeset [122110] by commit-queue@webkit.org
  • 31 edits
    3 deletes in trunk

Unreviewed, rolling out r122107.
http://trac.webkit.org/changeset/122107
https://bugs.webkit.org/show_bug.cgi?id=90794

Build failure on Mac debug bots (Requested by falken_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-09

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • dom/ContextFeatures.cpp:
  • dom/ContextFeatures.h:
  • html/HTMLDialogElement.cpp: Removed.
  • html/HTMLDialogElement.h: Removed.
  • html/HTMLDialogElement.idl: Removed.
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • features.gypi:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
08:35 Changeset [122109] by commit-queue@webkit.org
  • 5 edits
    12 moves in trunk

[CSSRegions] Rename NamedFlow::getRegionsByContentNode to NamedFlow::getRegionsByContent
https://bugs.webkit.org/show_bug.cgi?id=90759

Patch by Andrei Onea <onea@adobe.com> on 2012-07-09
Reviewed by Andreas Kling.

Source/WebCore:

Renamed NamedFlow::getRegionsByContentNode to NamedFlow::getRegionsByContent as per CSS Regions spec:
http://www.w3.org/TR/css3-regions/#dom-named-flow

Tests: fast/regions/get-regions-by-content-horiz-bt.html

fast/regions/get-regions-by-content-horiz-tb.html
fast/regions/get-regions-by-content-vert-lr.html
fast/regions/get-regions-by-content-vert-rl.html
fast/regions/get-regions-by-content.html
fast/regions/get-regions-by-content2.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::getRegionsByContent):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:

LayoutTests:

Renamed test files and functions from 77746: [CSSRegions]Implement NamedFlow::getRegionsByContentNode

  • fast/regions/get-regions-by-content-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-expected.txt.
  • fast/regions/get-regions-by-content-horiz-bt-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-lr-expected.txt.
  • fast/regions/get-regions-by-content-horiz-bt.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-bt.html.
  • fast/regions/get-regions-by-content-horiz-tb-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-tb-expected.txt.
  • fast/regions/get-regions-by-content-horiz-tb.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-tb.html.
  • fast/regions/get-regions-by-content-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-rl-expected.txt.
  • fast/regions/get-regions-by-content-vert-lr.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-lr.html.
  • fast/regions/get-regions-by-content-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-horiz-bt-expected.txt.
  • fast/regions/get-regions-by-content-vert-rl.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node-vert-rl.html.
  • fast/regions/get-regions-by-content.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node.html.
  • fast/regions/get-regions-by-content2-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-node2-expected.txt.
  • fast/regions/get-regions-by-content2.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-node2.html.
08:11 Changeset [122108] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Fix inspector detach when inspector was attached by the client
https://bugs.webkit.org/show_bug.cgi?id=90763

Reviewed by Martin Robinson.

When the inspector is detached, we are unconditionally removing it
from the inspected view, but if the inspector was attached by the
client, the parent might be another widget.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformDetach): Remove the inspector
view from its parent widget.

07:49 FeatureFlags edited by tkent@chromium.org
Add DIALOG_ELEMENT (diff)
07:42 Changeset [122107] by commit-queue@webkit.org
  • 31 edits
    3 adds in trunk

Add ENABLE_DIALOG_ELEMENT and skeleton files
https://bugs.webkit.org/show_bug.cgi?id=90521

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-07-09
Reviewed by Kent Tamura.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This adds the ENABLE_DIALOG_ELEMENT feature flag and dummy implementation files for <dialog>. In addition, a runtime feature flag is added.
The feature is diabled by default.

No new tests, as there is no behavior change.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h: Added a runtime feature flag for dialog.

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::dialogElementEnabled):
(WebCore::RuntimeEnabledFeatures::setDialogElementEnabled):

  • dom/ContextFeatures.cpp:

(WebCore::ContextFeatures::dialogElementEnabled):
(WebCore):

  • dom/ContextFeatures.h: Added a per-context flag for dialog so that dialog can be disabled in HTMLTagNames.in and DOMWindow.idl when the dialog runtime feature flag is off.
  • html/HTMLDialogElement.cpp: Added.

(WebCore):
(WebCore::HTMLDialogElement::HTMLDialogElement):
(WebCore::HTMLDialogElement::create):
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::show):

  • html/HTMLDialogElement.h: Added.

(WebCore):
(HTMLDialogElement):

  • html/HTMLDialogElement.idl: Added.
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • features.gypi:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableDialogElement):
(WebKit):
(WebKit::WebRuntimeFeatures::isDialogElementEnabled):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
06:45 Changeset [122106] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: inspector does not reflect newly created text nodes from contenteditable
https://bugs.webkit.org/show_bug.cgi?id=90779

Reviewed by Vsevolod Vlasov.

Source/WebCore:

We need to report first text node as inserted, otherwise we fail to report character data modified on it.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::characterDataModified):

LayoutTests:

  • inspector/elements/insert-node-expected.txt:
  • inspector/elements/insert-node.html:
06:36 Changeset [122105] by caseq@chromium.org
  • 4 edits in trunk

REGRESSION(r121980) Layout Test inspector/timeline/timeline-frames.html started to crash.
https://bugs.webkit.org/show_bug.cgi?id=90747

Reviewed by Pavel Feldman.

Source/WebCore:

  • consider didCancelFrame() call normal if there is no pending frame, remove assertion;
  • always set empty data object for frame records;
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didCancelFrame):
(WebCore::InspectorTimelineAgent::commitFrameRecord):

LayoutTests:

  • remove CRASH expectations for timeline-frames.html
  • platform/chromium/TestExpectations:
05:33 Changeset [122104] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source/WebCore

Web Inspector: Add FileContentView for FileSystemView
https://bugs.webkit.org/show_bug.cgi?id=90529

Adding FileContentView to Inspector.
This class provides preview of text files in FileSystem.

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-09
Reviewed by Vsevolod Vlasov.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/FileContentView.js: Added.
  • inspector/front-end/FileSystemView.js:

(WebInspector.FileSystemView.prototype.get visibleView):
(WebInspector.FileSystemView.EntryTreeElement.prototype.onselect):
(WebInspector.FileSystemView.EntryTreeElement.prototype._directoryContentReceived):
(WebInspector.FileSystemView.EntryTreeElement.prototype.refresh):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
05:28 Changeset [122103] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebCore

[SOUP] Use soup_cookie_jar_is_persistent() to set whether cookie is a session one or not
https://bugs.webkit.org/show_bug.cgi?id=90769

Reviewed by Gustavo Noronha Silva.

It's currently set to false, because there were no API to know
whether cookies were persistent or not. Now that we bumped libsoup
requirements, we can use soup_cookie_jar_is_persistent().

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::getRawCookies):

04:36 Changeset [122102] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Simplify runTest function by defining default arguments.
https://bugs.webkit.org/show_bug.cgi?id=90525

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-07-09
Reviewed by Chang Shu.

Default arguments will simplify macro RUN_TEST.
Function will only have one mandatory argument, callback test function.
Added static modifiers to callback functions.

  • tests/UnitTestUtils/EWKTestBase.h:

(EWKTestBase):

  • tests/test_ewk_view.cpp:

(ewkViewEditableGetCb):
(TEST):
(ewkViewUriGetCb):

03:52 Changeset [122101] by commit-queue@webkit.org
  • 10 edits in trunk

Web Inspector: Add text file support for FileSystemAgent::requestFileContent
https://bugs.webkit.org/show_bug.cgi?id=90439

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-09
Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorFileSystemAgent.cpp:

(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileContent):

  • inspector/InspectorFileSystemAgent.h:

(InspectorFileSystemAgent):

  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype.requestFileContent):
(WebInspector.FileSystemModel.File.prototype.requestFileContent):
(WebInspector.FileSystemRequestManager.prototype._fileContentReceived):
(WebInspector.FileSystemDispatcher.prototype.fileContentReceived):

LayoutTests:

  • http/tests/inspector/filesystem/read-directory-expected.txt:
  • http/tests/inspector/filesystem/read-file-expected.txt:
  • http/tests/inspector/filesystem/read-file.html:
02:33 Changeset [122100] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the Mac build when codesign_allocate is not installed at /usr/bin.

  • PluginProcess/mac/add-entitlements.sh: Let codesign(1) know where the codesign_allocate

tool is by setting the CODESIGN_ALLOCATE environment variable to its path as obtained with
xcrun.

01:53 Changeset [122099] by morrita@google.com
  • 6 edits in trunk/Source

[Chromium] ContextFeaturesClient::isEnabled is slow
https://bugs.webkit.org/show_bug.cgi?id=90367

Reviewed by Kent Tamura.

Source/WebCore:

  • dom/ContextFeatures.h:

(WebCore::ContextFeaturesClient::urlDidChange): Added.
(WebCore::ContextFeatures::urlDidChange): Added.
(WebCore):

  • dom/Document.cpp:

(WebCore::Document::setURL): Added an urlDidChange() call.

Source/WebKit/chromium:

ContextFeaturesClientImpl::isEnabled touches a heavy part in chrome
where locks are acquired for each invocation.

This change introduces a set of caches to avoid such slow calls.
The cache class ContextFeaturesCache is implemented as a
Supplement of ScriptExecutionContext because the flag bits
depend on the domain of each Document.

  • src/ContextFeaturesClientImpl.cpp:

(ContextFeaturesCache): Added.
(Entry): Added.
(WebKit::ContextFeaturesCache::Entry::Entry):
(WebKit::ContextFeaturesCache::Entry::isEnabled):
(WebKit::ContextFeaturesCache::Entry::set):
(WebKit::ContextFeaturesCache::Entry::needsRefresh):
(WebKit::ContextFeaturesCache::entryFor):
(WebKit):
(WebKit::ContextFeaturesCache::supplementName):
(WebKit::ContextFeaturesCache::from):
(WebKit::ContextFeaturesCache::refreshAgainst):
(WebKit::ContextFeaturesClientImpl::isEnabled):
(WebKit::ContextFeaturesClientImpl::urlDidChange): Added to invoke refrshAgainst.
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

  • src/ContextFeaturesClientImpl.h:

(ContextFeaturesClientImpl):

01:36 Changeset [122098] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed chromium inspector test fix.

  • src/js/Tests.js:

(.TestSuite.prototype.nonAnonymousUISourceCodes_):

01:14 Changeset [122097] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed, unskipping CSS Exclusions tests for the Gtk port.
The feature is already enabled for this port and all the tests pass.

  • platform/gtk/TestExpectations:
01:08 Changeset [122096] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[CSSRegions] Implement NamedFlow::firstEmptyRegionIndex attribute
https://bugs.webkit.org/show_bug.cgi?id=90608

Patch by Andrei Onea <onea@adobe.com> on 2012-07-09
Reviewed by Andreas Kling.

Source/WebCore:

Implemented NamedFlow::firstEmptyRegionIndex as per spec: http://www.w3.org/TR/css3-regions/#dom-named-flow

Test: fast/regions/webkit-named-flow-first-empty-region-index.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:

LayoutTests:

Added tests for NamedFlow::firstEmptyRegionIndex.

  • fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Added.
  • fast/regions/webkit-named-flow-first-empty-region-index.html: Added.
00:07 Changeset [122095] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the failing test.

  • platform/qt/Skipped:

07/08/12:

23:55 Changeset [122094] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Marking a storage/indexeddb/mozilla/key-requirements.html as flaky on WebKit Win.

  • platform/chromium/TestExpectations:
23:43 Changeset [122093] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip the new failing test.

  • platform/qt/Skipped:
23:36 Changeset [122092] by fpizlo@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed, checking in platform results.

  • platform/mac/css3/filters/effect-reference-expected.txt: Added.
  • platform/mac/css3/filters/effect-reference-external-expected.txt: Added.
  • platform/mac/css3/filters/effect-reference-hw-expected.txt: Added.
  • platform/mac/css3/filters/effect-reference-ordering-expected.txt: Added.
  • platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
23:33 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
23:31 UsingGitWithWebKit edited by yosin@chromium.org
Fix "Copying file aks svn copy" secion: Change "p" to "--patch" (diff)
23:30 Changeset [122091] by yosin@chromium.org
  • 1 edit
    3 copies in trunk/Source/WebCore

[Platform-Mac] Derive LocaleMac.{cpp,h} and LocalizedDateMac.cpp from LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=90752

Reviewed by Kent Tamura.

This patch is preparation of introducing LocaleMac class for localize date form.
This patch copies LocaleWin and LocalizedDateWin.cpp as below:

  • LocaleMac.h from LocaleWin.h
  • LocaleMac.mm from LocaliedDateMac.mm
  • LocaliedDateMac.cpp from LocalizedDateWin.cpp

Due by git, diffs are appeared as new thing. I'll do svn copy at landing time.

No new tests. This patch doesn't change behavior.

  • platform/text/mac/LocaleMac.h: Copied from platform/text/LocaleWin.h
  • platform/text/mac/LocaleMac.mm: Copied from platform/text/mac/LocalizedDateMac.mm
  • platform/text/mac/LocalizedDateMac.cpp: Copied from platform/text/LocalizedDateWin.cpp
23:30 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
23:30 WebKitGTK/WebKit2Roadmap edited by carlosgc@webkit.org
(diff)
23:19 Changeset [122090] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

gcc build fix after r121925.

  • runtime/JSObject.h:

(JSC::JSFinalObject::finishCreation):

23:12 Changeset [122089] by laszlo.1.gombos@nokia.com
  • 4 edits in trunk/Source

Introduce a build flag for low quality JPEG images
https://bugs.webkit.org/show_bug.cgi?id=90748

Reviewed by Adam Barth.

Source/WebCore:

Introduce build options for no JPEG dithering (USE(LOW_QUALITY_IMAGE_NO_JPEG_DITHERING))
and no JPEG fancy upsampling (USE(LOW_QUALITY_IMAGE_NO_JPEG_FANCY_UPSAMPLING)).

No new tests as there is no change in functionality.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(ditherMode):
(doFancyUpsampling):

Source/WTF:

Turn on the newly introduced flags for android.

  • wtf/Platform.h:
22:10 Changeset [122088] by gyuyoung.kim@samsung.com
  • 11 edits in trunk/LayoutTests

Check returned value in BatteryStatus APIs test cases
https://bugs.webkit.org/show_bug.cgi?id=90665

Reviewed by Adam Barth.

It is good to compare with actual values to recognize what is difference.

  • batterystatus/add-listener-from-callback-expected.txt:
  • batterystatus/basic-all-types-of-events-expected.txt:
  • batterystatus/basic-operation-expected.txt:
  • batterystatus/script-tests/add-listener-from-callback.js:

(checkBatteryStatus):

  • batterystatus/script-tests/basic-all-types-of-events.js:

(checkBatteryStatus):

  • batterystatus/script-tests/basic-operation.js:
  • batterystatus/script-tests/updates.js:

(checkBatteryStatus):

  • batterystatus/updates-expected.txt:
21:59 Changeset [122087] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r121968.
http://trac.webkit.org/changeset/121968
https://bugs.webkit.org/show_bug.cgi?id=90749

Caused a link error on chromium Win dbg. (Requested by hayato
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-08

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

  • platform/MemoryUsageSupport.cpp:
  • platform/MemoryUsageSupport.h:

(MemoryUsageSupport):

  • platform/chromium/MemoryUsageSupportChromium.cpp:
21:56 Changeset [122086] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Make setForceDownload a setter method.
https://bugs.webkit.org/show_bug.cgi?id=90591

Reviewed by Rob Buis.

  • platform/network/blackberry/ResourceRequest.h:

(WebCore::ResourceRequest::setForceDownload):

21:54 Changeset [122085] by zandobersek@gmail.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed GTK gardening, remove a redundant baseline for the
http/tests/xmlhttprequest/send-array-buffer.html test,
required after r122074.

  • platform/gtk/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Removed.
21:47 Changeset [122084] by tkent@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r122076.
http://trac.webkit.org/changeset/122076
https://bugs.webkit.org/show_bug.cgi?id=89560

Broke sheriffbot rollout

  • Scripts/prepare-ChangeLog:

(generateNewChangeLogs):

21:38 Changeset [122083] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Marking a inspector/timeline/timeline-frames.html as a CRASH on WebKit Linux (dbg).

  • platform/chromium/TestExpectations:
21:36 Changeset [122082] by morrita@google.com
  • 7 edits
    2 adds in trunk

Heap-use-after-free in WebCore::RenderObject::destroyAndCleanupAnonymousWrappers
https://bugs.webkit.org/show_bug.cgi?id=90480

Reviewed by Kent Tamura.

Source/WebCore:

If <select> has any insertion point, the attachment phase
unpextedly creates a renderer for distributed node and added to
the renderer of the <select>, which breaks an assumption and
results the crash.

This change tighten the childShouldCreateRenderer() to forbid
child renderers even from distributed nodes.

There is an exception as always: ValidationMessage can create a
ShadowRoot to <select>, which generates usually-forbidden child
renderers. This change introduces HTMLFormControlElement::validationMessageContains()
to let these renderers in.

Test: fast/dom/shadow/insertion-point-list-menu-crash.html

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::validationMessageContains):
(WebCore):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childShouldCreateRenderer):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::contains):
(WebCore):

  • html/ValidationMessage.h:

(WebCore):
(ValidationMessage):

LayoutTests:

  • fast/dom/shadow/insertion-point-list-menu-crash-expected.txt: Added.
  • fast/dom/shadow/insertion-point-list-menu-crash.html: Added.
21:30 Changeset [122081] by kseo@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unnecessary member HTMLTreeBuilder::m_lastScriptElementStartPosition
https://bugs.webkit.org/show_bug.cgi?id=90726

Reviewed by Adam Barth.

HTMLTreeBuilder::m_lastScriptElementStartPosition is of no use. Currently,
m_lastScriptElementStartPosition is used to store the text position in
"script" start tag, and then the stored position is passed to m_scriptToProcessStartPosition
later in "script" end tag. Because HTMLTreeBuilder handles one script tag at
a time, we can store the text position directly to m_scriptToProcessStartPosition
in "script" start tag.

No behavior change, so no new tests.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

21:15 Changeset [122080] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Marking a fast/multicol/column-span-parent-continuation-crash.html as a flaky.

  • platform/chromium/TestExpectations:
20:57 Changeset [122079] by pdr@google.com
  • 7 edits in trunk/Source/WebCore

Refactor RenderSVGShape to not contain fallback code
https://bugs.webkit.org/show_bug.cgi?id=90514

Reviewed by Nikolas Zimmermann.

The interaction between RenderSVGShape and {RenderSVGEllipse, RenderSVGRect}
was too coupled and it was not clear when a path existed or who controlled
falling back to path codepaths in RenderSVGShape.

This patch cleans up RenderSVGShape so that it does not track fallback state
and does not have special handling for creating a shape in strokeContains. Because
some functions of RenderSVGShape can be called without a path existing, each
of these functions has switched to using the path() function which asserts that
a path exists.

There is only one remaining use of hasPath() in RenderSVGShape which I plan
to remove in a followup patch.

This patch also cleans up RenderSVGRect and RenderSVGEllipse. These classes
now handle fallback tracking themselves and choose when to use their optimized
strokeContains codepaths.

No new tests as this is just a refactoring.

  • rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::RenderSVGEllipse):
(WebCore::RenderSVGEllipse::createShape):
(WebCore::RenderSVGEllipse::objectBoundingBox):
(WebCore::RenderSVGEllipse::strokeBoundingBox):
(WebCore::RenderSVGEllipse::fillShape):
(WebCore::RenderSVGEllipse::strokeShape):
(WebCore::RenderSVGEllipse::shapeDependentStrokeContains):
(WebCore::RenderSVGEllipse::shapeDependentFillContains):

  • rendering/svg/RenderSVGEllipse.h:

(WebCore::RenderSVGEllipse::isEmpty):
(RenderSVGEllipse):

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::RenderSVGRect):
(WebCore::RenderSVGRect::createShape):
(WebCore::RenderSVGRect::objectBoundingBox):
(WebCore::RenderSVGRect::strokeBoundingBox):
(WebCore::RenderSVGRect::fillShape):
(WebCore::RenderSVGRect::strokeShape):
(WebCore::RenderSVGRect::shapeDependentStrokeContains):
(WebCore::RenderSVGRect::shapeDependentFillContains):

  • rendering/svg/RenderSVGRect.h:

(WebCore::RenderSVGRect::isEmpty):
(RenderSVGRect):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::isEmpty):
(WebCore::RenderSVGShape::objectBoundingBox):
(WebCore::RenderSVGShape::shapeDependentStrokeContains):
(WebCore::RenderSVGShape::shapeDependentFillContains):
(WebCore::RenderSVGShape::strokeContains):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::hasSmoothStroke):
(WebCore):

  • rendering/svg/RenderSVGShape.h:

(RenderSVGShape):

20:51 Changeset [122078] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90735

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-08
Reviewed by Antonio Gomes.

Keep a reference to the Element passed to enterFullScreenForElement() so
that we can reuse it later in exitFullScreenForElement(). This is needed
because the Element passed to exitFullScreenForElement() may be null.
This fixes the crash for the fullscreen/exit-full-screen-iframe.html
test introduced in r122035.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::enterFullScreenForElement):
(WebCore::ChromeClientEfl::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

20:48 Changeset [122077] by leandrogracia@chromium.org
  • 5 edits in trunk

Update the description of LayoutTestController::textSurroundingElement
https://bugs.webkit.org/show_bug.cgi?id=90620

Reviewed by Adam Barth.

Tools:

Rename and fix the description of the method as its behaviour changed
during the review of https://bugs.webkit.org/show_bug.cgi?id=82461

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::textSurroundingNode):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

Rename textSurroundingElement to match is real behaviour.

  • platform/chromium/editing/surrounding-text/surrounding-text.html:
20:38 Changeset [122076] by tkent@chromium.org
  • 2 edits in trunk/Tools

Improve the template generated by prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=89560

Reviewed by Ryosuke Niwa.

Produce the following template:

2012-06-20 Kent Tamura <tkent@chromium.org>

Need a short description (Oops!).
Need the bug URL (Oops!).

Reviewed by Ryosuke Niwa.

Additional information of the change such as approach, rationale. Please add per-function descriptions below. (Oops!).

No new tests (Oops!).

  • Scripts/prepare-ChangeLog:

(generateNewChangeLogs):

20:26 Changeset [122075] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Marking a fast/events/display-none-on-focus-crash.html as a flaky.

  • platform/chromium/TestExpectations:
20:09 Changeset [122074] by kinuko@chromium.org
  • 9 edits
    2 copies in trunk

XHR.send should support ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=90536

Source/WebCore:

XHR.send should support ArrayBufferView according to the latest draft
and also eventually deprecate ArrayBuffer.
Spec: http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#dom-xmlhttprequest-send

Reviewed by Kenneth Russell.

Test: http/tests/xmlhttprequest/send-array-buffer.html

http/tests/xmlhttprequest/send-data-view.html

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

  • xml/XMLHttpRequest.cpp:

(WebCore):
(WebCore::XMLHttpRequest::send):

  • xml/XMLHttpRequest.h:

(XMLHttpRequest):

  • xml/XMLHttpRequest.idl:

LayoutTests:

Reviewed by Kenneth Russell.

  • http/tests/xmlhttprequest/send-array-buffer-expected.txt:
  • http/tests/xmlhttprequest/send-array-buffer.html:
  • http/tests/xmlhttprequest/send-data-view-expected.txt: Added.
  • http/tests/xmlhttprequest/send-data-view.html: Added.
19:42 Changeset [122073] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[EFL] Change notifications directory path of WebKit_INCLUDE_DIRECTORIES in the PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=90650

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-08
Reviewed by Laszlo Gombos.

Change directory path for including notifications of WebCore
from WebCore/notifications to WebCore/Modules/notifications

  • PlatformEfl.cmake:
19:42 Changeset [122072] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Fix a wrong entry in r122070.

  • platform/chromium/TestExpectations: Replace dont-commit-on-blocked.html with cursor-delete.html.
19:29 Changeset [122071] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Fix a wrong entry in r122064.

  • platform/chromium/TestExpectations:
19:22 Changeset [122070] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. marking a storage/indexeddb/cursor-delete.html as a flaky crasher after r121629.

  • platform/chromium/TestExpectations:
18:52 Changeset [122069] by hayato@chromium.org
  • 114 edits
    7 copies
    18 adds
    25 deletes in trunk/LayoutTests

Unreviewed gardening.
Rebaseline after r121917.

  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-23-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-24-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-68-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-69-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-23-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-24-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-69-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-23-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-24-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-68-expected.png: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-69-expected.png: Removed.
  • platform/chromium-linux-x86/editing/selection/3690703-2-expected.png: Removed.
  • platform/chromium-linux-x86/editing/selection/3690703-expected.png: Removed.
  • platform/chromium-linux-x86/editing/selection/3690719-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css1/formatting_model/floating_elements-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-23-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-24-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-68-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-69-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-23-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-24-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-69-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-23-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-68-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-69-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.txt: Copied from LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.txt.
  • platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/4397952-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-cannot-be-nested-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-generated-content-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-positioned-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/button-white-space-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/css1/formatting_model/floating_elements-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.txt: Added.
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.txt: Added.
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Added.
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Added.
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.txt: Added.
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.txt: Added.
  • platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.txt:
  • platform/chromium-mac/editing/deleting/5144139-2-expected.txt: Added.
  • platform/chromium-mac/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.txt:
  • platform/chromium-mac/editing/selection/3690703-expected.png:
  • platform/chromium-mac/editing/selection/3690703-expected.txt:
  • platform/chromium-mac/editing/selection/3690719-expected.png:
  • platform/chromium-mac/editing/selection/3690719-expected.txt:
  • platform/chromium-mac/editing/selection/4397952-expected.png:
  • platform/chromium-mac/editing/selection/4397952-expected.txt:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.png:
  • platform/chromium-mac/editing/selection/selection-button-text-expected.txt:
  • platform/chromium-mac/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-mac/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/chromium-mac/fast/block/positioning/inline-block-relposition-expected.txt: Added.
  • platform/chromium-mac/fast/css/continuationCrash-expected.png:
  • platform/chromium-mac/fast/css/continuationCrash-expected.txt:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.png:
  • platform/chromium-mac/fast/css/rtl-ordering-expected.txt:
  • platform/chromium-mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.png:
  • platform/chromium-mac/fast/forms/001-expected.txt:
  • platform/chromium-mac/fast/forms/basic-buttons-expected.png:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.png:
  • platform/chromium-mac/fast/forms/blankbuttons-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.png:
  • platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.txt: Added.
  • platform/chromium-mac/fast/forms/button-generated-content-expected.png:
  • platform/chromium-mac/fast/forms/button-generated-content-expected.txt: Added.
  • platform/chromium-mac/fast/forms/button-positioned-expected.png:
  • platform/chromium-mac/fast/forms/button-positioned-expected.txt:
  • platform/chromium-mac/fast/forms/button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/button-style-color-expected.png:
  • platform/chromium-mac/fast/forms/button-style-color-expected.txt:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.png:
  • platform/chromium-mac/fast/forms/button-table-styles-expected.txt:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.png:
  • platform/chromium-mac/fast/forms/button-text-transform-expected.txt:
  • platform/chromium-mac/fast/forms/button-white-space-expected.png:
  • platform/chromium-mac/fast/forms/button-white-space-expected.txt: Added.
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-direction-expected.txt:
  • platform/chromium-mac/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-mac/fast/forms/file/file-input-pressed-state-expected.png:
  • platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png:
  • platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png:
  • platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.txt:
18:47 Changeset [122068] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

[wx] Unreviewed. Fix notificaitons directory path after notifications move.

  • waf/build/settings.py:
18:41 Changeset [122067] by hayato@chromium.org
  • 157 edits
    2 copies
    10 adds
    2 deletes in trunk/LayoutTests

Unreviewed gardening.
Rebaseline after r121917.

  • platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/formmove3-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-first-letter-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac-snowleopard/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac-snowleopard/fast/selectors/064-expected.png:
  • platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/append-cells2-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/remove-td-display-none-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/rowindex-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/rowindex-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-override-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt.
  • platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt.
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-iframe-zIndex-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-remove-ancestor-after-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-zIndex-after-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52505-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug52506-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug68912-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-mac/fast/forms/formmove3-expected.png:
  • platform/chromium-mac/fast/forms/formmove3-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-mac/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-mac/fast/forms/input-first-letter-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.png:
  • platform/chromium-mac/fast/forms/select-baseline-expected.png:
  • platform/chromium-mac/fast/forms/select-baseline-expected.txt: Added.
  • platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/html/details-replace-summary-child-expected.png:
  • platform/chromium-mac/fast/html/details-replace-text-expected.png:
  • platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-mac/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-button-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-radio-expected.txt:
  • platform/chromium-mac/fast/selectors/064-expected.png:
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png:
  • platform/chromium-mac/fast/table/append-cells2-expected.png:
  • platform/chromium-mac/fast/table/append-cells2-expected.txt: Added.
  • platform/chromium-mac/fast/table/remove-td-display-none-expected.png:
  • platform/chromium-mac/fast/table/remove-td-display-none-expected.txt: Added.
  • platform/chromium-mac/fast/table/rowindex-expected.png:
  • platform/chromium-mac/fast/table/rowindex-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/bidi-override-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-override-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-mac/fast/text/international/hindi-spacing-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-mac/fast/text/international/text-spliced-font-expected.txt:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-mac/fullscreen/full-screen-iframe-zIndex-expected.png:
  • platform/chromium-mac/fullscreen/full-screen-remove-ancestor-after-expected.png:
  • platform/chromium-mac/fullscreen/full-screen-zIndex-after-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug52505-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug52506-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug68912-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/chromium-mac/tables/mozilla/other/move_row-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
18:26 Changeset [122066] by hayato@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.
Rebaseline after r121917.

  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
18:20 Changeset [122065] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=90722
https://bugs.webkit.org/show_bug.cgi?id=90742

Unreviewed, skip crashing tests.

  • platform/mac/Skipped:
18:11 Changeset [122064] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=90741

fast/text-autosizing/simple-paragraph.html (reftest) started to fail after r121907.

  • platform/chromium/TestExpectations: Add IMAGE on Mac.
17:38 Changeset [122063] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Add TIMEOUT for inspector/timeline/timeline-network-received-data.html.

  • platform/chromium/TestExpectations:
17:26 Changeset [122062] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.
Add TIMEOUT for inspector/debugger/live-edit.html.

  • platform/chromium/TestExpectations:
16:33 Changeset [122061] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

inspector/profiler/heap-snapshot-comparison-*.html are crashing
https://bugs.webkit.org/show_bug.cgi?id=90722

Unreviewed, skipping another crashing inspector/profiler test and consolidating
the bugs for those tests.

  • platform/mac/Skipped:
03:00 Changeset [122060] by zherczeg@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[Qt][ARM] Implementing missing macro assembler instructions after r121925
https://bugs.webkit.org/show_bug.cgi?id=90657

Reviewed by Csaba Osztrogonác.

Implementing convertibleLoadPtr, replaceWithLoad and
replaceWithAddressComputation.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::replaceWithLoad):
(ARMAssembler):
(JSC::ARMAssembler::replaceWithAddressComputation):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::convertibleLoadPtr):
(MacroAssemblerARM):

02:04 Changeset [122059] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py should not generate statements with no effect
https://bugs.webkit.org/show_bug.cgi?id=90697

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-08
Reviewed by Vsevolod Vlasov.

Fix to remove the statements with no effect. The check for errors is added only when some valid
statements exist.

No new tests as generator related patch.

  • inspector/CodeGeneratorInspector.py:

(Generator.process_command):

07/07/12:

21:03 Changeset [122058] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[EFL][CMake] Remove non-existent include directory
https://bugs.webkit.org/show_bug.cgi?id=90605

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-07
Reviewed by Kentaro Hara.

  • PlatformEfl.cmake:
18:08 FeatureFlags edited by tkent@chromium.org
Add TEXT_AUTOSIZING (diff)
18:02 Changeset [122057] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Fix build break when Accelerated Compositing is on.
https://bugs.webkit.org/show_bug.cgi?id=90718

Unreviewed build fix.

ewk_view_accelerated_compositing_XXX APIs are in ewk_view_private.h

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-07-07

  • WebCoreSupport/PageClientEfl.cpp:

(PageClientEfl::createEvasObjectForAcceleratedCompositing):
(PageClientEfl::acceleratedCompositingContext):

  • WebCoreSupport/PageClientEfl.h:

(PageClientEfl):

15:26 Changeset [122056] by staikos@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

Detach animation clients properly if we clear the web page pointer.
https://bugs.webkit.org/show_bug.cgi?id=90730

Reviewed by Adam Treat.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::destroyCompositor):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::detach):
(BlackBerry::WebKit::WebPageCompositorPrivate::setPage):

  • Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

13:53 Changeset [122055] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90729

Unreviewed, skip crashing test.

  • platform/mac/Skipped:
12:49 Changeset [122054] by zandobersek@gmail.com
  • 4 edits in trunk

REGRESSION (r122035): fullscreen/exit-full-screen-iframe.html failing on GTK Linux 64-bit Release
https://bugs.webkit.org/show_bug.cgi?id=90719

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Follow the approach of the BlackBerry port outlined in r122035, using in exitFullScreenForElement
the fullscreen element to which the reference was saved when enterFullScreenForElement was called.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::exitFullScreenForElement):

LayoutTests:

Remove the crashing test expectation for the affected test.

  • platform/gtk/TestExpectations:
01:27 Changeset [122053] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Fix build with recent clang.
https://bugs.webkit.org/show_bug.cgi?id=90712

Patch by Nuno Lopes <nlopes@apple.com> on 2012-07-07
Reviewed by Alexey Proskuryakov.

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:

(DOMWindowExtensionBasic):

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:

(DOMWindowExtensionNoCache):

  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:

(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):

00:26 Changeset [122052] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

media/media-blocked-by-beforeload.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=90725

Unreviewed, skip flaky test.

  • platform/mac/Skipped:
00:22 Changeset [122051] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

compositing/iframes/iframe-size-from-zero.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=90724

Unreviewed, skip flaky test.

  • platform/mac/Skipped:
00:17 Changeset [122050] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

inspector/debugger/set-breakpoint.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90723

Unreviewed, skip crashing test.

  • platform/mac/Skipped:
00:13 Changeset [122049] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

inspector/profiler/heap-snapshot-comparison-show-next.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90722

Unreviewed, skip crashing test.

  • platform/mac/Skipped:

07/06/12:

23:36 Changeset [122048] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding a test expectation for
a crashing test introduced in r122035.

  • platform/gtk/TestExpectations:
21:50 Applications using WebKit edited by whzeng@126.com
(diff)
21:49 Applications using WebKit edited by whzeng@126.com
(diff)
21:48 Applications using WebKit edited by whzeng@126.com
(diff)
17:43 Changeset [122047] by fpizlo@apple.com
  • 4 edits
    6 adds in trunk

WebKit Version 5.1.7 (6534.57.2, r121935): Double-click no longer works on OpenStreetMap
https://bugs.webkit.org/show_bug.cgi?id=90703

Source/JavaScriptCore:

Reviewed by Michael Saboff.

It turns out that in my object model refactoring, I managed to fix get_by_pname in all
execution engines except 64-bit baseline JIT.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_pname):

LayoutTests:

Reviewed by Michael Saboff.

  • fast/js/get-by-pname-expected.txt: Added.
  • fast/js/get-by-pname-non-final-object-expected.txt: Added.
  • fast/js/get-by-pname-non-final-object.html: Added.
  • fast/js/get-by-pname.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/get-by-pname-non-final-object.js: Added.

(foo):

  • fast/js/script-tests/get-by-pname.js: Added.

(foo):

17:23 Changeset [122046] by lforschler@apple.com
  • 5 edits in branches/safari-534.57-branch/Source

Versioning.

17:18 Changeset [122045] by lforschler@apple.com
  • 1 copy in tags/Safari-534.57.7

New Tag.

17:13 Changeset [122044] by lforschler@apple.com
  • 5 edits in branches/safari-534.57-branch/Source

Versioning.

16:48 Changeset [122043] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

fast/canvas/webgl/gl-vertexattribpointer.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=90711

Unreviewed, skip crashing test.

  • platform/mac/Skipped:
16:38 Changeset [122042] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

plugins/npruntime/leak-window-scriptable-object.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90710

Unreviewed. skip failing test.

  • platform/mac/Skipped:
16:18 Changeset [122041] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

iframe and global variable related inspector tests are failing
https://bugs.webkit.org/show_bug.cgi?id=90709

Unreviewed, skip failing tests.

  • platform/mac/Skipped:
16:14 Changeset [122040] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

fullscreen/exit-full-screen-iframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90708

Unreviewed, skip failing test.

  • platform/mac/Skipped:
16:09 Changeset [122039] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

inspector/timeline/timeline-receive-response-event is flaky
https://bugs.webkit.org/show_bug.cgi?id=90707

Unreviewed, skip flaky test.

  • platform/mac/Skipped:
16:04 Changeset [122038] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Reproducible crash in inspector/timeline/timeline-frames.html
https://bugs.webkit.org/show_bug.cgi?id=90706

Unreviewed, skip crashng test.

  • platform/mac/Skipped:
15:44 Changeset [122037] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Avoid deep copy of QImage in GraphicsContext3D::getImageData()
https://bugs.webkit.org/show_bug.cgi?id=90705

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-07-06
Reviewed by Noam Rosenthal.

Use QImage.constBits() as argument to packPixels instead of bits() to avoid
deep copying it.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::getImageData):

15:13 Changeset [122036] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix errors reported by generate-bindings.pl after r121882.

  • DerivedSources.make: Specify the correct path for notifications idl

files now that notifications/ lives in WebCore/Modules/.

14:40 Changeset [122035] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[BlackBerry] exitFullScreenForElement() is not working for fullscreen elements in iframes
https://bugs.webkit.org/show_bug.cgi?id=90327

Patch by Max Feil <mfeil@rim.com> on 2012-07-06
Reviewed by Antonio Gomes.

Source/WebKit/blackberry:

Fix exit fullscreen problem for elements in iframes. The
exitFullScreenForElement() call is passed a null element in
this case, instead of the original element which entered
fullscreen. If you look in Document.cpp you can see the
exitFullScreenForElement() call being made on the topDocument
(which has a null m_fullScreenElement) instead of the iframe's
document.

The Chromium and Windows ports get around this problem by
storing either the fullscreen element or its frame during
enterFullScreenForElement(), so I will bring the BlackBerry port
in line with this. See also bug 89817.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

LayoutTests:

Test of exit fullscreen for an iframe.

  • fullscreen/exit-full-screen-iframe-expected.txt: Added.
  • fullscreen/exit-full-screen-iframe.html: Added.
13:43 Changeset [122034] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

Add an API to explicitly call a JavaScript function with args.
https://bugs.webkit.org/show_bug.cgi?id=90694

Currently the Blackberry port doesn't expose the JavaScript
engine to 3rd parties so they rely upon executeJavaScript
which can be slower than necessary and unsafe as eval is used.
This new API provides a way to explicitly call a specific
JavaScript function with a list of args preventing the case
where an argument comes from a untrusted source and tries to
escape the arg list to take control of the JavaScript engine.

In the future if the Blackberry port introduces a formal
way to interact with the JavaScript engine this function should
be removed.

PR 149294

Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-07-06
Reviewed by Unreviewed

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
(WebKit):

  • Api/WebPage.h:
13:41 Changeset [122033] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Build Error on Qt Linux build
https://bugs.webkit.org/show_bug.cgi?id=90699

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-06
Reviewed by Laszlo Gombos.

  • parser/Parser.cpp:

(JSC::::parseForStatement):
Removed unused boolean variable as this was causing build error on Qt Linux.

13:22 Changeset [122032] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merge - 121360 [gtk] Spell checker doesn't recognize contractions (apostrophes)
https://bugs.webkit.org/show_bug.cgi?id=86118

Reviewed by Gustavo Noronha Silva.

Work-around a bug in Pango by trying to detect apostrophes
that create contractions. This work-around is similar to one
found in gtkspell.

  • webkit/webkitspellcheckerenchant.cpp:

(wordEndIsAContractionApostrophe): Added this helper which tries to detect
situations where a word end is both an apostrophe and followed by a alphabetic
character.
(checkSpellingOfString): When searching for the end of a word, skip over
apostrophes that appear to be part of contractions.

13:22 Changeset [122031] by mrobinson@webkit.org
  • 158 edits in releases/WebKitGTK/webkit-1.8/LayoutTests

Merge 109100 - Rebaseline Gtk results after r109097.

Patch by Nikolas Zimmermann <nzimmermann@rim.com> on 2012-02-28

  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/gtk/svg/batik/filters/feTile-expected.txt:
  • platform/gtk/svg/batik/filters/filterRegions-expected.txt:
  • platform/gtk/svg/batik/masking/maskRegions-expected.txt:
  • platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegionA-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/batik/text/longTextOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textAnchor-expected.txt:
  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/batik/text/textEffect-expected.txt:
  • platform/gtk/svg/batik/text/textEffect2-expected.txt:
  • platform/gtk/svg/batik/text/textEffect3-expected.txt:
  • platform/gtk/svg/batik/text/textFeatures-expected.txt:
  • platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/gtk/svg/batik/text/textLayout-expected.txt:
  • platform/gtk/svg/batik/text/textLayout2-expected.txt:
  • platform/gtk/svg/batik/text/textLength-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath2-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath3-expected.txt:
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/gtk/svg/batik/text/textPosition-expected.txt:
  • platform/gtk/svg/batik/text/textPosition2-expected.txt:
  • platform/gtk/svg/batik/text/textProperties-expected.txt:
  • platform/gtk/svg/batik/text/textProperties2-expected.txt:
  • platform/gtk/svg/batik/text/textStyles-expected.txt:
  • platform/gtk/svg/batik/text/verticalText-expected.txt:
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/gtk/svg/carto.net/button-expected.txt:
  • platform/gtk/svg/carto.net/colourpicker-expected.txt:
  • platform/gtk/svg/carto.net/slider-expected.txt:
  • platform/gtk/svg/carto.net/window-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-child-clipped-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-evenodd-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-nonzero-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/gtk/svg/clip-path/clipper-placement-issue-expected.txt:
  • platform/gtk/svg/css/clippath-with-shadow-expected.txt:
  • platform/gtk/svg/css/mask-with-shadow-expected.txt:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/custom/clip-path-referencing-use-expected.txt:
  • platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
  • platform/gtk/svg/custom/path-textPath-simulation-expected.txt:
  • platform/gtk/svg/custom/pattern-rotate-expected.txt:
  • platform/gtk/svg/custom/recursive-clippath-expected.txt:
  • platform/gtk/svg/custom/recursive-mask-expected.txt:
  • platform/gtk/svg/custom/recursive-pattern-expected.txt:
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/gtk/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/gtk/svg/custom/struct-use-09-b-expected.txt:
  • platform/gtk/svg/custom/use-clipped-hit-expected.txt:
  • platform/gtk/svg/custom/use-detach-expected.txt:
  • platform/gtk/svg/custom/use-disappears-after-style-update-expected.txt:
  • platform/gtk/svg/custom/use-dynamic-append-expected.txt:
  • platform/gtk/svg/custom/use-elementInstance-event-target-expected.txt:
  • platform/gtk/svg/custom/use-elementInstance-methods-expected.txt:
  • platform/gtk/svg/custom/use-empty-reference-expected.txt:
  • platform/gtk/svg/custom/use-event-handler-on-referenced-element-expected.txt:
  • platform/gtk/svg/custom/use-event-handler-on-use-element-expected.txt:
  • platform/gtk/svg/custom/use-events-crash-expected.txt:
  • platform/gtk/svg/custom/use-instanceRoot-modifications-expected.txt:
  • platform/gtk/svg/custom/use-modify-container-in-target-expected.txt:
  • platform/gtk/svg/custom/use-modify-target-container-expected.txt:
  • platform/gtk/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/gtk/svg/custom/use-nested-transform-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/gtk/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/gtk/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/gtk/svg/custom/use-on-g-containing-use-expected.txt:
  • platform/gtk/svg/custom/use-on-g-expected.txt:
  • platform/gtk/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/gtk/svg/custom/use-on-rect-expected.txt:
  • platform/gtk/svg/custom/use-on-symbol-expected.txt:
  • platform/gtk/svg/custom/use-on-text-expected.txt:
  • platform/gtk/svg/custom/use-on-use-expected.txt:
  • platform/gtk/svg/custom/use-property-changes-through-dom-expected.txt:
  • platform/gtk/svg/custom/use-property-changes-through-svg-dom-expected.txt:
  • platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt:
  • platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt:
  • platform/gtk/svg/custom/use-recursion-1-expected.txt:
  • platform/gtk/svg/custom/use-recursion-2-expected.txt:
  • platform/gtk/svg/custom/use-recursion-3-expected.txt:
  • platform/gtk/svg/custom/use-recursion-4-expected.txt:
  • platform/gtk/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/gtk/svg/custom/use-symbol-overflow-expected.txt:
  • platform/gtk/svg/custom/use-transform-expected.txt:
  • platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt:
  • platform/gtk/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt:
  • platform/gtk/svg/filters/filter-placement-issue-expected.txt:
  • platform/gtk/svg/filters/filter-refresh-expected.txt:
  • platform/gtk/svg/filters/filter-source-position-expected.txt:
  • platform/gtk/svg/hixie/error/014-expected.txt:
  • platform/gtk/svg/hixie/error/017-expected.txt:
  • platform/gtk/svg/hixie/use/001-expected.txt:
  • platform/gtk/svg/hixie/use/002-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt:
  • platform/gtk/svg/repaint/inner-svg-change-viewPort-relative-expected.txt:
  • platform/gtk/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
  • platform/gtk/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
  • platform/gtk/svg/text/text-gradient-positioning-expected.txt:
  • platform/gtk/svg/text/text-path-01-b-expected.txt:
  • platform/gtk/svg/text/text-text-04-t-expected.txt:
  • platform/gtk/svg/text/text-text-05-t-expected.txt:
  • platform/gtk/svg/text/text-text-06-t-expected.txt:
  • platform/gtk/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
13:22 Changeset [122030] by mrobinson@webkit.org
  • 232 edits
    4 deletes in releases/WebKitGTK/webkit-1.8

Merge 109097 - Integrate SVGUseElement within the new shadow root concept
https://bugs.webkit.org/show_bug.cgi?id=78902

Patch by Nikolas Zimmermann <nzimmermann@rim.com> on 2012-02-28
Reviewed by Zoltan Herczeg.

Source/WebCore:

Replace SVG shadow tree implementation with the new, modern #shadow-root implementation.

Current situation in trunk:
SVGUseElement doesn't create/hold the shadow tree, unlike its expected in
the modern #shadow-root concept, but its renderer RenderSVGShadowTreeRootContainer.
That creates a cycle, as the actual DOM tree is stored as RefPtr<SVGGElement> inside
a renderer - that's weak conceptually, and has lead to sublte security bugs in the past.

Whenever a target element of a <use> element changed, invalidateShadowTree() is called
which calls setNeedsStyleRecalc(), and sets m_needsShadodwTreeRecreation to true.
Once style recalculation happens, the RenderSVGShadowTreeRootContainer then eventually
built the shadow tree, by cloning the target node, building the SVGElementInstance tree
etc, -- all within the render tree.

To easy reviewing, here's a dump of the current render tree for a simple <use> example:
<defs><rect id="rect"/></defs><use xlink:href="#rect"/>

Dump of render tree:
RenderSVGHiddenContainer {defs} <defs> (SVGDefsElement)

RenderSVGRect {rect} <rect> (SVGRectElement)

RenderSVGShadowTreeRootContainer {use} <use> (SVGUseElement)

RenderSVGContainer {g} <g> (SVGShadowTreeRootElement)

RenderSVGRect {rect} <rect> (SVGRectElement, clone of <rect> in <defs>)

The SVGShadowTreeRootElement is created & stored by RenderSVGShadowTreeRootContainer,
the renderer of the <use> element. The RenderSVGTransformableContainer renderer created
for the SVGShadowTreeRootElement stores the x/y translation induced by the <use> attributes.

There are lots of places all over WebCore that assume the existance of a <g> renderer
as first child of the <use> element, representing the "SVG shadow tree root".

Summary of this patch:
Let SVGUseElement create&maintain a #shadow-root, and append the cloned target elements
into this shadow root. We no longer have to take care of attachment/detachment, style
recalculation, etc. - that's handled transparenly by ShadowRoot(List) now.

This makes SVGShadowTreeElements & RenderSVGShadowTreeRootContainer obsolete. Switch
SVGUseElement to create a RenderSVGTransformableContainer as its renderer, and make
it respect the translation induced by the x/y attributes, given for a <use> element.

Remove all occourences of SVGShadowRoot, remove all special cases it induced.

It's all covered by existing tests, took a while to make them all pass again.

  • CMakeLists.txt: Remove SVGShadowTreeElements/RenderSVGShadowTreeRootContainer from build.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList): Enable fast path for selector checking, now that special shadow tree rules are gone.

  • css/SelectorChecker.cpp:

(WebCore::linkAttribute): No need to guard this code with ENABLE(SVG).
(WebCore::SelectorChecker::checkSelector): Remove obsolete SVG shadow root special case.

  • dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingSVGTargetRules): Remove loop, simplify & cleanup this code.
(WebCore::EventDispatcher::adjustToShadowBoundaries): s/isShadowRootOrSVGShadowRoot/isShadowRoot/.
(WebCore::EventDispatcher::adjustRelatedTarget): Ditto.
(WebCore::EventDispatcher::ensureEventAncestors): Simplify logic for SVG, fixed a FIXME.

  • dom/Node.cpp: Remove obsolete svgShadowHost().

(WebCore::Node::shadowTreeRootNode): Remove obsolete isSVGShadowRoot() checks.
(WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto.
(WebCore::Node::isInShadowTree): Make it const.

  • dom/Node.h: Remove isSVGShadowRoot/svgShadowHost.

(WebCore::Node::isShadowRoot): s/IsShadowRootOrSVGShadowRootFlag/isShadowRoot/.
(WebCore::Node::parentNode): Augment comments.
(WebCore::Node::parentNodeGuaranteedHostFree): Ditto.

  • dom/Range.cpp:

(WebCore::Range::checkNodeBA): Remove obsolete SVG shadow root special case.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript): Ditto.

  • rendering/RenderObject.h: Remove isSVGShadowTreeRootContainer.

(WebCore::RenderObject::isSVGTransformableContainer): Added.

  • rendering/svg/RenderSVGAllInOne.cpp: Remove SVGShadowTreeElements/RenderSVGShadowTreeRootContainer from build.
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::isGraphicsElement): To check for <use>, a tag name comparision is needed now, as it no longer has a special renderer.

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): Ditto.
(WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): Ditto.
(WebCore::RenderSVGResourceClipper::hitTestClipContent): Ditto.

  • rendering/svg/RenderSVGResourceContainer.cpp: Remove RenderSVGShadowTreeRootContainer.h include.
  • rendering/svg/RenderSVGShadowTreeRootContainer.cpp: Removed.
  • rendering/svg/RenderSVGShadowTreeRootContainer.h: Removed.
  • rendering/svg/RenderSVGTransformableContainer.cpp: Keep track of last used additional x/y translation.

(WebCore::RenderSVGTransformableContainer::calculateLocalTransform): Handle x/y translation for <use> contains here, instead of storing it in the SVGShadowTreeRootElement.

  • rendering/svg/RenderSVGTransformableContainer.h: Store last used x/y translation.

(WebCore::RenderSVGTransformableContainer::isSVGTransformableContainer): Return true.
(WebCore::toRenderSVGTransformableContainer): Add conversion helpers.

  • rendering/svg/RenderSVGViewportContainer.cpp: Ditto.

(WebCore::RenderSVGViewportContainer::calcViewport): Handle width/height attributes inheritance from the <use> element, if we're a <svg> or <symbol> replacement in the shadow tree.

  • rendering/svg/RenderSVGViewportContainer.h: Remove isSVGContainer() override which is not needed here (already present in RenderSVGContainer).
  • rendering/svg/SVGShadowTreeElements.cpp: Removed.
  • rendering/svg/SVGShadowTreeElements.h: Removed.
  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::createRenderer): Check if parentNode is really a SVGElement, before casting.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::isOutermostSVGSVGElement): Early exit if tag name isn't <svg>, or if we're in a shadow tree (can't be an outermost <svg> element then).
(WebCore::hasLoadListener): Deploy parentOrHostElement() usage to remove any special cases, related to shadow boundaries.
(WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.
(WebCore::SVGElement::customStyleForRenderer): Ditto.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::invalidateAllInstancesOfElement): Call updateStyleIfNeeded() instead of updateLayoutIgnorePendingStylesheets().

  • svg/SVGGElement.cpp:

(WebCore::SVGGElement::rendererIsNeeded): s/parentNode/parentOrHostElement/ - we need to cross shadow boundaries now.

  • svg/SVGGElement.h: Remove obsolete isShadowTreeContainerElement().
  • svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::nearestViewportElement): s/parentNode/parentOrHostElement/ - we need to cross shadow boundaries now.
(WebCore::SVGLocatable::farthestViewportElement): Ditto.
(WebCore::SVGLocatable::computeCTM): Ditto.

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::title): Ditto. (+ simplify code a lot, no need to walk the shadow tree to find its root anymore, use isInShadowTree() helper.)
(WebCore::SVGStyledElement::rendererIsNeeded): Ditto.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::SVGUseElement): Remove no longer needed m_updatesBlocked.
(WebCore::SVGUseElement::create): Always call ensureShadowRoot(), to create a #shadow-root, upon creating a SVGUseElement.
(WebCore::SVGUseElement::insertedIntoDocument): Align with SVGFEImageElement/SVGTRefElement - call buildPendingResource() from insertedIntoDocument(), finally! (no renderer needed anymore to update the SVG shadow subtree).
(WebCore::SVGUseElement::removedFromDocument): Align with SVGFEImageElement/SVGTRefElement - immediately release the SVGElementInstance & shadow tree, once we're removed from the document.
(WebCore::SVGUseElement::svgAttributeChanged): Simplify code a lot, no longer need to deal with x/y/width/height attributes, the renderes in the shadow tree grab these values from their corresponding <use> elements automatically now.
(WebCore::SVGUseElement::willRecalcStyle):

New main part of the logic. invalidateShadowTree() calls setNeedsStyleRecalc, and sets m_needsShadowTreeRecreation=true. If we encounter this case, force rebuilding the SVG shadow tree
and the SVGElementInstance tree, immediately, before executing the actual style recalc. This allows us to lazily rebuild the SVG shadow tree for the <use> element. Consider:
<defs><rect id="rect"></defs> <use xlink:href="#rect"/>. Now from a script we change the rect x/y/width/height attributes:
rect.setAttribute("x", "10"); rect.setAttribute("y", "10")... each call will lead to a SVGUseElement::invalidateShadowTree() call by SVGElementInstance::invalidateAllInstancesOfElement, invoked after the <rect> element got parsed.
This won't update the shadow tree four times, but only once upon the next style recalculation - otherwise performance is a nightmare.
This will serve as future starting point, to explore partial SVG subtree re-clones, which should easily be doable now.

(WebCore::dumpInstanceTree): Add a 'static' to allow DUMP_INSTANCE_TREE to be used in clang builds.
(WebCore::SVGUseElement::clearResourceReferences): Added helper to release instance & shadow tree.
(WebCore::SVGUseElement::buildPendingResource): Modeled exactly like SVGFEImageElement/SVGTRefElement. It's possible to share more code between these in future.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Cleanup code, adapt to new shadow-root concept.
(WebCore::SVGUseElement::createRenderer): Create a RenderSVGTransformableContainer, no longer a <use> specific renderer.
(WebCore::removeDisallowedElementsFromSubtree): Use new replacedChild/appendChild variants, that don't require a ExceptionCode to be passed in.
(WebCore::SVGUseElement::buildShadowTree): Ditto.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::invalidateShadowTree): Only trigger style recalculations if needed.

  • svg/SVGUseElement.h: Remove lots of now unnecessary overrides: attach/detach/didRecalcStyle/updateContainerOffset/updateContainerSizes/etc..
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedIntoDocument): No need to walk the shadow tree to find its root anymore, use isInShadowTree() helper.

LayoutTests:

Update results after the <use> rewrite. Lots of RendeSVGContainer lines are
gone in the expected results, as the artifical <g> element representing the
SVG shadow root is gone, replaced by a standar #shadow-root.

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/mac/svg/batik/filters/feTile-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/batik/paints/gradientLimit-expected.txt:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegionA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/mac/svg/batik/text/longTextOnPath-expected.txt:
  • platform/mac/svg/batik/text/smallFonts-expected.txt:
  • platform/mac/svg/batik/text/textAnchor-expected.txt:
  • platform/mac/svg/batik/text/textDecoration-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/mac/svg/batik/text/textLayout-expected.txt:
  • platform/mac/svg/batik/text/textLayout2-expected.txt:
  • platform/mac/svg/batik/text/textLength-expected.txt:
  • platform/mac/svg/batik/text/textOnPath-expected.txt:
  • platform/mac/svg/batik/text/textOnPath2-expected.txt:
  • platform/mac/svg/batik/text/textOnPath3-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/textPosition-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/batik/text/textProperties2-expected.txt:
  • platform/mac/svg/batik/text/textStyles-expected.txt:
  • platform/mac/svg/batik/text/verticalText-expected.txt:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/mac/svg/carto.net/button-expected.txt:
  • platform/mac/svg/carto.net/colourpicker-expected.txt:
  • platform/mac/svg/carto.net/slider-expected.txt:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt:
  • platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.txt:
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.txt:
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.txt:
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.txt:
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/mac/svg/clip-path/clipper-placement-issue-expected.txt:
  • platform/mac/svg/css/clippath-with-shadow-expected.txt:
  • platform/mac/svg/css/mask-with-shadow-expected.txt:
  • platform/mac/svg/custom/broken-internal-references-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/mac/svg/custom/embedding-external-svgs-expected.txt:
  • platform/mac/svg/custom/path-textPath-simulation-expected.txt:
  • platform/mac/svg/custom/pattern-rotate-expected.txt:
  • platform/mac/svg/custom/recursive-clippath-expected.txt:
  • platform/mac/svg/custom/recursive-mask-expected.txt:
  • platform/mac/svg/custom/recursive-pattern-expected.txt:
  • platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/mac/svg/custom/struct-use-09-b-expected.txt:
  • platform/mac/svg/custom/use-clipped-hit-expected.txt:
  • platform/mac/svg/custom/use-css-events-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/custom/use-disappears-after-style-update-expected.png:
  • platform/mac/svg/custom/use-disappears-after-style-update-expected.txt:
  • platform/mac/svg/custom/use-dynamic-append-expected.txt:
  • platform/mac/svg/custom/use-elementInstance-event-target-expected.txt:
  • platform/mac/svg/custom/use-elementInstance-methods-expected.txt:
  • platform/mac/svg/custom/use-empty-reference-expected.txt:
  • platform/mac/svg/custom/use-event-handler-on-referenced-element-expected.txt:
  • platform/mac/svg/custom/use-event-handler-on-use-element-expected.txt:
  • platform/mac/svg/custom/use-events-crash-expected.txt:
  • platform/mac/svg/custom/use-font-face-crash-expected.txt:
  • platform/mac/svg/custom/use-instanceRoot-event-bubbling-expected.png:
  • platform/mac/svg/custom/use-instanceRoot-event-listeners-expected.png:
  • platform/mac/svg/custom/use-instanceRoot-modifications-expected.txt:
  • platform/mac/svg/custom/use-modify-container-in-target-expected.txt:
  • platform/mac/svg/custom/use-modify-target-container-expected.txt:
  • platform/mac/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/mac/svg/custom/use-nested-transform-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
  • platform/mac/svg/custom/use-on-g-containing-symbol-expected.txt:
  • platform/mac/svg/custom/use-on-g-containing-use-expected.txt:
  • platform/mac/svg/custom/use-on-g-expected.txt:
  • platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
  • platform/mac/svg/custom/use-on-rect-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/mac/svg/custom/use-on-text-expected.txt:
  • platform/mac/svg/custom/use-on-use-expected.txt:
  • platform/mac/svg/custom/use-property-changes-through-dom-expected.txt:
  • platform/mac/svg/custom/use-property-changes-through-svg-dom-expected.txt:
  • platform/mac/svg/custom/use-property-synchronization-crash-expected.txt:
  • platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
  • platform/mac/svg/custom/use-recursion-1-expected.txt:
  • platform/mac/svg/custom/use-recursion-2-expected.txt:
  • platform/mac/svg/custom/use-recursion-3-expected.txt:
  • platform/mac/svg/custom/use-recursion-4-expected.png:
  • platform/mac/svg/custom/use-recursion-4-expected.txt:
  • platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/mac/svg/custom/use-symbol-overflow-expected.txt:
  • platform/mac/svg/custom/use-transform-expected.txt:
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt:
  • platform/mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt:
  • platform/mac/svg/filters/filter-placement-issue-expected.txt:
  • platform/mac/svg/filters/filter-refresh-expected.txt:
  • platform/mac/svg/filters/filter-source-position-expected.txt:
  • platform/mac/svg/hixie/error/014-expected.txt:
  • platform/mac/svg/hixie/error/017-expected.txt:
  • platform/mac/svg/hixie/use/001-expected.txt:
  • platform/mac/svg/hixie/use/002-expected.txt:
  • platform/mac/svg/overflow/overflow-on-inner-svg-element-expected.txt:
  • platform/mac/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt:
  • platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
  • platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
  • platform/mac/svg/text/text-gradient-positioning-expected.txt:
  • platform/mac/svg/text/text-path-01-b-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
  • svg/clip-path/clip-path-childs-clipped-expected.txt:
  • svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt:
  • svg/clip-path/clip-path-clipped-expected.txt:
  • svg/clip-path/clip-path-clipped-nonzero-expected.txt:
  • svg/clip-path/clip-path-on-clipped-use-expected.txt:
  • svg/clip-path/clip-path-use-as-child-expected.txt:
  • svg/css/circle-in-mask-with-shadow-expected.txt:
  • svg/custom/deep-dynamic-updates-expected.txt:
  • svg/custom/non-scaling-stroke-expected.txt:
  • svg/custom/resource-client-removal-expected.txt:
  • svg/custom/use-clipped-transform-expected.txt:
  • svg/custom/use-css-no-effect-on-shadow-tree-expected.txt:
  • svg/custom/use-forward-refs-expected.txt:
  • svg/custom/use-image-in-g-expected.txt:
  • svg/custom/use-in-symbol-with-offset-expected.txt:
  • svg/custom/use-inherit-style-expected.txt:
  • svg/custom/use-move-to-offset-expected.txt:
  • svg/custom/use-multiple-on-nested-disallowed-font-expected.txt:
  • svg/custom/use-on-clip-path-with-transformation-expected.txt:
  • svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
  • svg/custom/use-setAttribute-crash-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-svg-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-svg1-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-symbol1-expected.txt:
  • svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt:
  • svg/repaint/inner-svg-change-viewPort-relative-expected.txt:
13:20 Changeset [122029] by mrobinson@webkit.org
  • 13 edits
    16 adds in releases/WebKitGTK/webkit-1.8

Merge 108699 - Recompute font metrics on scale changes
https://bugs.webkit.org/show_bug.cgi?id=75091

Patch by Philip Rogers <pdr@google.com> on 2012-02-23
Reviewed by Nikolas Zimmermann.

Source/WebCore:

SVG text metrics depend on the transform from renderer to the svg root
which requires that we propagate transform changes down to text.
This change adds a boolean for tracking transform changes to
SVGViewportContainers and SVGTransformableContainers, and updates
RenderSVGText::layout() to recalculate text metrics if the transform
of an ancestor has changed.

Tests: platform/mac/svg/text/text-rescale.html

platform/mac/svg/text/text-viewbox-rescale.html
svg/text/text-rescale.html
svg/text/text-viewbox-rescale.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::isSVGTransformableContainer):
(WebCore::RenderObject::isSVGViewportContainer):

  • rendering/svg/RenderSVGContainer.h:

(WebCore::RenderSVGContainer::didTransformToRootUpdate):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::RenderSVGText):
(WebCore::RenderSVGText::layout):

  • rendering/svg/RenderSVGText.h:

(WebCore::RenderSVGText::setNeedsTextMetricsUpdate):
(RenderSVGText):

  • rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):

  • rendering/svg/RenderSVGTransformableContainer.h:

(WebCore::RenderSVGTransformableContainer::isSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::didTransformToRootUpdate):
(RenderSVGTransformableContainer):

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
(WebCore::RenderSVGViewportContainer::calcViewport):

  • rendering/svg/RenderSVGViewportContainer.h:

(WebCore::RenderSVGViewportContainer::didTransformToRootUpdate):
(RenderSVGViewportContainer):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::transformToRootChanged):
(WebCore):
(WebCore::SVGRenderSupport::layoutChildren):

  • rendering/svg/SVGRenderSupport.h:

(SVGRenderSupport):

LayoutTests:

  • platform/chromium-linux/svg/text/text-rescale-expected.png: Added.
  • platform/chromium-linux/svg/text/text-rescale-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-viewbox-rescale-expected.png: Added.
  • platform/chromium-linux/svg/text/text-viewbox-rescale-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/text/text-rescale-expected.png: Added.
  • platform/mac/svg/text/text-rescale-expected.txt: Added.
  • platform/mac/svg/text/text-rescale.html: Added.
  • platform/mac/svg/text/text-viewbox-rescale-expected.png: Added.
  • platform/mac/svg/text/text-viewbox-rescale-expected.txt: Added.
  • platform/mac/svg/text/text-viewbox-rescale.html: Added.
  • svg/text/text-rescale-expected.png: Added.
  • svg/text/text-rescale-expected.txt: Added.
  • svg/text/text-rescale.html: Added.
  • svg/text/text-viewbox-rescale-expected.png: Added.
  • svg/text/text-viewbox-rescale-expected.txt: Added.
  • svg/text/text-viewbox-rescale.html: Added.
13:20 Changeset [122028] by mrobinson@webkit.org
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-1.8

Merge 109345 - Crash in WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget
https://bugs.webkit.org/show_bug.cgi?id=79831

Patch by Stephen Chenney <schenney@chromium.org> on 2012-03-01
Reviewed by Eric Seidel.

Out-of-order operations in the SVGSMILElement::removedFromDocument
method caused its target to be removed and then re-added due to a
later call. This led to the target being set on the animation while
the target element itself was unaware. At deletion time, this caused a
crash (or assert in debug builds). Thanks to Abhishek Arya for help
with the layout test.

Source/WebCore:

Test: svg/animations/smil-element-target-crash-main.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::removedFromDocument):

LayoutTests:

  • svg/animations/resources/smil-element-target-crash.svg: Added.
  • svg/animations/smil-element-target-crash-main-expected.txt: Added.
  • svg/animations/smil-element-target-crash-main.html: Added.
13:20 Changeset [122027] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 108847 - Overhanging floats not removed from new flex box.
https://bugs.webkit.org/show_bug.cgi?id=79522

Patch by Abhishek Arya <inferno@chromium.org> on 2012-02-24
Reviewed by Ojan Vafai.

Source/WebCore:

Similar to r69476.

Test: fast/flexbox/overhanging-floats-not-removed-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

LayoutTests:

  • fast/flexbox/overhanging-floats-not-removed-crash-expected.txt: Added.
  • fast/flexbox/overhanging-floats-not-removed-crash.html: Added.
13:20 Changeset [122026] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 108372 - Crash in RenderTableSection::nodeAtPoint.
https://bugs.webkit.org/show_bug.cgi?id=78922

Patch by Abhishek Arya <inferno@chromium.org> on 2012-02-21
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/table-section-node-at-point-crash.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint): recalc cells if the
m_needsCellRecalc is set. Otherwise, we will end up accessing
removed table cells.

LayoutTests:

  • fast/table/table-section-node-at-point-crash-expected.txt: Added.
  • fast/table/table-section-node-at-point-crash.html: Added.
13:20 Changeset [122025] by mrobinson@webkit.org
  • 3 edits
    7 adds in releases/WebKitGTK/webkit-1.8

Merge 108543 - Cloning and linebox issues in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78273

Patch by Abhishek Arya <inferno@chromium.org> on 2012-02-22
Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/multicol/span/clone-flexbox.html

fast/multicol/span/clone-summary.html
fast/multicol/span/textbox-not-removed-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone): Fix cloning algorithm to take
care of cloning descendant classes of RenderBlock.
(WebCore::RenderBlock::splitBlocks): When we move our inline children
to cloneBlock, we need to clear our entire line box tree. Any descendant
child in the hierarchy could be a part of our line box tree and will
never get cleared since the child has moved to new parent cloneBlock.

LayoutTests:

  • fast/multicol/span/clone-flexbox-expected.png:
  • fast/multicol/span/clone-flexbox-expected.txt: Added.
  • fast/multicol/span/clone-flexbox.html: Added. Test passes if we

see two RenderFlexibox in the rendertree.

  • fast/multicol/span/clone-summary-expected.png: Added.
  • fast/multicol/span/clone-summary-expected.txt: Added.
  • fast/multicol/span/clone-summary.html: Added. Test passes if we

see two RenderSummary in the rendertree.

  • fast/multicol/span/textbox-not-removed-crash-expected.txt: Added.
  • fast/multicol/span/textbox-not-removed-crash.html: Added. Test

passes it we do not crash on m_hasBadParent assert in InlineBox.

13:19 Changeset [122024] by mrobinson@webkit.org
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-1.8

Merge 109140 - Incorrect before child parent calculation when adding new children
to anonymous column blocks.
https://bugs.webkit.org/show_bug.cgi?id=79755

Patch by Abhishek Arya <inferno@chromium.org> on 2012-02-28
Reviewed by David Hyatt.

Source/WebCore:

before child can be wrapped in anonymous containers, so need to
take care of that in before child parent calculation.

Test: fast/multicol/span/before-child-anonymous-column-block.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):

LayoutTests:

Test passes if you don't see the div block inside table and you see
two blocks in different columns in the pixel test.

  • fast/multicol/span/before-child-anonymous-column-block-expected.png: Added.
  • fast/multicol/span/before-child-anonymous-column-block-expected.txt: Added.
  • fast/multicol/span/before-child-anonymous-column-block.html: Added.
13:19 Changeset [122023] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 108415 - ContainerNode::childrenChanged must be called immediately after removing children
https://bugs.webkit.org/show_bug.cgi?id=79162

Patch by Adam Klein <adamk@chromium.org> on 2012-02-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

In r108152, a call to childrenChanged() was erroneously moved
below the call to child->removedFromDocument(). This breaks, at the
least, the behavior of the <title> element. This patch corrects the
mistake and adds a test.

Test: fast/dom/title-directionality-removeChild.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):

LayoutTests:

  • fast/dom/title-directionality-removeChild-expected.txt: Added.
  • fast/dom/title-directionality-removeChild.html: Added.
13:19 Changeset [122022] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8

Merge 108152 - Avoid inconsistency in Node::inDocument due to DOMSubtreeModified dispatch
https://bugs.webkit.org/show_bug.cgi?id=76087

Patch by Adam Klein <adamk@chromium.org> on 2012-02-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

Move post-removal notifications after call to Node::removeFromDocument
to avoid inconsistent state of Node::inDocument() and thus avoid
inconsistent state in DocumentOrderedMap.

Tests: fast/dom/getElementById-consistency.html

fast/dom/getElementById-consistency2.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText): Fixed to work with new timing of DOMSubtreeModified dispatch.

LayoutTests:

  • fast/dom/getElementById-consistency-expected.txt: Added.
  • fast/dom/getElementById-consistency.html: Added.
  • fast/dom/getElementById-consistency2-expected.txt: Added.
  • fast/dom/getElementById-consistency2.html: Added.
13:19 Changeset [122021] by mrobinson@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 112051 - Crash in ContainerNode::resumePostAttachCallbacks.
https://bugs.webkit.org/show_bug.cgi?id=82159

Patch by Abhishek Arya <inferno@chromium.org> on 2012-03-25
Reviewed by Hajime Morita.

Source/WebCore:

Test: plugins/object-onfocus-mutation-crash.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::resumePostAttachCallbacks): dispatching post attach
callbacks when our attach depth is 1 can fire mutation events such as onfocus
which can blow away |this|. Need to protect it with a RefPtr.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::attach): add calls to suspend attach callbacks
until the function completes.

LayoutTests:

  • plugins/object-onfocus-mutation-crash-expected.txt: Added.
  • plugins/object-onfocus-mutation-crash.html: Added.
13:19 Changeset [122020] by mrobinson@webkit.org
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-1.8

Merge 110326 - Hold cached images with a CachedResourceHandle rather than a raw pointer for CSSCrossfadeValue
https://bugs.webkit.org/show_bug.cgi?id=80186

Patch by Tom Sepez <tsepez@chromium.org> on 2012-03-09
Reviewed by Simon Fraser.

Source/WebCore:

Test: http/tests/css/cross-fade-reload.html

  • css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

LayoutTests:

  • http/tests/css/cross-fade-reload-expected.txt: Added.
  • http/tests/css/cross-fade-reload.html: Added.
  • http/tests/css/resources/abe.png: Added.
13:19 Changeset [122019] by mrobinson@webkit.org
  • 34 edits in releases/WebKitGTK/webkit-1.8

Merge 119192 - REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac
https://bugs.webkit.org/show_bug.cgi?id=86859

Source/WebCore:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

The test tries to reach an invalid SpellChecker object. Such an access should be guarded
beforehand.

Asynchronous spellchecking can return results after originated
frame is gone, which triggered an invalid access to the dead spellchecker
object. This chagne prevents it by marking request objects from
the spellchecker as invalid:

  • Originally TextCheckerClient API was passed a SpellCheker object. This change abstracted it behind TextCheckingRequest interface, didSucceed() and didCancel() method specifically.
  • TextCheckingRequest was turned from a plain old object into a refcounted abstract class, which is now subclassed by SpellCheckRequest.
  • SpellChecker now marks pending SpellCheckRequest objects as invalid on its destructor.

Test: editing/spelling/spellcheck-async-remove-frame.html

  • WebCore.exp.in:
  • editing/SpellChecker.cpp:

(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
(WebCore::SpellCheckRequest::didSucceed):
(WebCore):
(WebCore::SpellCheckRequest::didCancel):
(WebCore::SpellCheckRequest::wasRequestedBy):
(WebCore::SpellCheckRequest::requesterDestroyed):
(WebCore::SpellChecker::~SpellChecker):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::didCheckSucceed):
(WebCore::SpellChecker::didCheckCancel):

  • editing/SpellChecker.h:

(WebCore):
(SpellCheckRequest):
(WebCore::SpellCheckRequest::isStarted):
(SpellChecker):

  • loader/EmptyClients.h:

(WebCore::EmptyTextCheckerClient::requestCheckingOfString):

  • platform/text/TextCheckerClient.h:

(TextCheckerClient):

  • platform/text/TextChecking.h:

(GrammarDetail):
(TextCheckingResult):
(TextCheckingRequest):
(WebCore::TextCheckingRequest::~TextCheckingRequest):

Source/WebKit/blackberry:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::requestCheckingOfString):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

Removed a port specific fix which was introduced at r117572.

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::frameWillDetachPage):
(WebKit::EditorClientImpl::requestCheckingOfString):

  • src/EditorClientImpl.h:

(WebCore):
(EditorClientImpl):

  • src/WebTextCheckingCompletionImpl.cpp:

(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):

  • src/WebTextCheckingCompletionImpl.h:

(WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
(WebTextCheckingCompletionImpl):

Source/WebKit/efl:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::requestCheckingOfString):

Source/WebKit/gtk:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/TextCheckerClientGtk.h:

(WebKit::TextCheckerClientGtk::requestCheckingOfString):

Source/WebKit/mac:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(-[WebEditorSpellCheckResponder initWithClient:sequence:results:]):
(-[WebEditorSpellCheckResponder perform]):
(WebEditorClient::didCheckSucceeded):
(WebEditorClient::requestCheckingOfString):

Source/WebKit/qt:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/TextCheckerClientQt.h:

(WebCore::TextCheckerClientQt::requestCheckingOfString):

Source/WebKit/win:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient::requestCheckingOfString):

Source/WebKit/wince:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::requestCheckingOfString):

Source/WebKit/wx:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::requestCheckingOfString):

Source/WebKit2:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::requestCheckingOfString):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

LayoutTests:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.

  • platform/mac/Skipped: Unskipped the test.
13:18 Changeset [122018] by mrobinson@webkit.org
  • 13 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 114605 - Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
https://bugs.webkit.org/show_bug.cgi?id=83748

Reviewed by Ryosuke Niwa.

Source/WebCore:

The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)

Test: platform/chromium/editing/spelling/delete-misspelled-word.html

  • WebCore.exp.in: Replaced SpellChecker::didCheck with SpellChecker::didCheckSucceeded.
  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::didCheckSucceeded): Added.
(WebCore):
(WebCore::SpellChecker::didCheckCanceled): Added.

  • editing/SpellChecker.h:

(SpellChecker): Added didCheckSucceeded and didCheckCanceled. Also changed didCheck to a private function.

Source/WebKit/chromium:

This change adds a new API WebTextCheckingCompletion::didCancelCheckingText(),
which encapsulates SpellChecker::didCheckCanceled() and implements it so
Chromium can use it.

  • public/WebTextCheckingCompletion.h:

(WebKit::WebTextCheckingCompletion::didCancelCheckingText):

  • src/WebTextCheckingCompletionImpl.cpp:

(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):

  • src/WebTextCheckingCompletionImpl.h:

(WebTextCheckingCompletionImpl):

Source/WebKit/mac:

This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckSucceeded() because didCheck has been split into
didCheckSucceeded(0 and didCheckCanceled().

  • WebCoreSupport/WebEditorClient.mm:

(-[WebEditorSpellCheckResponder perform]): Replaced didCheck with didCheckSucceeded.

Tools:

This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckCenceled() because didCheck() has been split into
didCheckSucceeded() and didCheckCanceled().

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.

LayoutTests:

The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)

  • platform/chromium/editing/spelling/delete-misspelled-word-expected.txt: Added.
  • platform/chromium/editing/spelling/delete-misspelled-word.html: Added.

Conflicts:

Source/WebKit/chromium/src/WebTextCheckingCompletionImpl.cpp

13:05 Changeset [122017] by mrobinson@webkit.org
  • 12 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 113127 - Prevent spellchecking text pasted to an element having spellchecking disabled
https://bugs.webkit.org/show_bug.cgi?id=81323

Patch by Hironori Bono <hbono@chromium.org> on 2012-04-03
Reviewed by Hajime Morita.

This change prevent calling SpellChecker::requestCheckingFor when pasting text
to an element whose spellcheck attribute is false or a password input.

Source/WebCore:

Test: editing/spelling/spellcheck-paste-disabled.html

  • editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment): Disabled spellchecking on password inputs.

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::isCheckable): Return false when spellchecking is disabled.

LayoutTests:

  • editing/spelling/spellcheck-paste-disabled-expected.txt: Added.
  • editing/spelling/spellcheck-paste-disabled.html: Added.
  • platform/efl/Skipped: Skipped due to the lack of requestCheckingOfString().
  • platform/gtk/Skipped: ditto.
  • platform/mac-leopard/Skipped: ditto.
  • platform/mac-lion/Skipped: ditto.
  • platform/mac-wk2/Skipped: ditto.
  • platform/qt/Skipped: ditto.
  • platform/win-wk2/Skipped: ditto.
  • platform/win/Skipped: ditto.
  • platform/wincairo/Skipped: ditto.
13:05 Changeset [122016] by mrobinson@webkit.org
  • 32 edits in releases/WebKitGTK/webkit-1.8/Source

Merge 108772 - SpellCheckRequest needs to know the context where the spellcheck happened.
https://bugs.webkit.org/show_bug.cgi?id=79320

Patch by Shinya Kawanaka <shinyak@chromium.org> on 2012-02-24
Reviewed by Hajime Morita.

Source/WebCore:

WebKit clients should be able to get the context how the spellcheck happended.
For example, WebKit clients may want to change the behavior by a spellcheck request is
invoked in typing or in pasting.

This patch added an enum in SpellCheckRequest so that WebKit clients can understand the context.

  • editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

  • editing/SpellChecker.cpp:

(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
(WebCore::SpellChecker::invokeRequest):

  • editing/SpellChecker.h:

(SpellCheckRequest):
(WebCore::SpellCheckRequest::textCheckingRequest):
(WebCore::SpellCheckRequest::processType):

  • loader/EmptyClients.h:

(WebCore::EmptyTextCheckerClient::requestCheckingOfString):

  • platform/text/TextCheckerClient.h:

(WebCore):
(TextCheckerClient):

  • platform/text/TextChecking.h:

(TextCheckingRequest):
(WebCore::TextCheckingRequest::TextCheckingRequest):
(WebCore::TextCheckingRequest::setSequence):
(WebCore::TextCheckingRequest::sequence):
(WebCore::TextCheckingRequest::text):
(WebCore::TextCheckingRequest::mask):
(WebCore::TextCheckingRequest::processType):
(WebCore):

Source/WebKit/blackberry:

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::requestCheckingOfString):

  • WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::requestCheckingOfString):

  • src/EditorClientImpl.h:

(EditorClientImpl):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::requestTextChecking):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::requestCheckingOfString):

Source/WebKit/gtk:

  • WebCoreSupport/TextCheckerClientGtk.h:

(WebKit::TextCheckerClientGtk::requestCheckingOfString):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::requestCheckingOfString):

Source/WebKit/qt:

  • WebCoreSupport/TextCheckerClientQt.h:

(WebCore::TextCheckerClientQt::requestCheckingOfString):

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient::requestCheckingOfString):
(WebEditorClient):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::requestCheckingOfString):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::requestCheckingOfString):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::requestCheckingOfString):

  • WebProcess/WebCoreSupport/WebEditorClient.h:
13:05 Changeset [122015] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit2

Merge 117578 - Yet another unreviewed build fix on r117572, this time for wk2...

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18

  • WebProcess/WebCoreSupport/WebEditorClient.h:
13:04 Changeset [122014] by mrobinson@webkit.org
  • 10 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit

Merge 117575 - Another unreviewed attempt to fix build breakage on r117572.

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.h:

(WebKit::EditorClient::frameWillDetachPage):

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h:

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient::frameWillDetachPage):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::frameWillDetachPage):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::frameWillDetachPage):

13:04 Changeset [122013] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merge 117574 - Unreviewed attempt to fix build breakage on r117572

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18

  • editing/Editor.cpp:

(WebCore::Editor::willDetachPage):

13:04 Changeset [122012] by mrobinson@webkit.org
  • 27 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 117572 - https://bugs.webkit.org/show_bug.cgi?id=85515
Stale frame in WebCore::SpellChecker::didCheckSucceeded

Source/WebCore:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

Added EditorClient::frameWillDetachPage() notification to give a
change to invalidate pending spellcheck requests on the client.

Test: editing/spelling/spellcheck-async-remove-frame.html

  • editing/Editor.cpp:

(WebCore::Editor::Editor):

  • editing/Editor.h:

(Editor):

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::frameWillDetachPage):

  • page/EditorClient.h:

(EditorClient):

Source/WebKit/blackberry:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientBlackBerry.h:

(WebCore::EditorClientBlackBerry::frameWillDetachPage):

Source/WebKit/chromium:

Added WebTextCheckingCompletionImpl::invalidate() to mark
pending spellcheck request as invalid, and added frameWillDetachPage()
to fire it.

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::frameWillDetachPage):
(WebKit):
(WebKit::EditorClientImpl::requestCheckingOfString):
(WebKit::EditorClientImpl::didCheckString):

  • src/EditorClientImpl.h:

(WebKit):
(EditorClientImpl):

  • src/WebTextCheckingCompletionImpl.cpp:

(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
(WebKit::WebTextCheckingCompletionImpl::invalidate):
(WebKit):

  • src/WebTextCheckingCompletionImpl.h:

(WebKit):
(WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
(WebTextCheckingCompletionImpl):
(WebKit::WebTextCheckingCompletionImpl::spellChecker):

Source/WebKit/efl:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::frameWillDetachPage):

Source/WebKit/gtk:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientGtk.h:

(WebKit::EditorClient::frameWillDetachPage):

Source/WebKit/mac:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.h:

Source/WebKit/qt:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientQt.h:

(WebCore::EditorClientQt::frameWillDetachPage):

Source/WebKit/win:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.h:

(WebEditorClient::frameWillDetachPage):

Source/WebKit/wince:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

  • WebCoreSupport/EditorClientWinCE.h:

(WebKit::EditorClientWinCE::frameWillDetachPage):

Source/WebKit/wx:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

  • WebKitSupport/EditorClientWx.h:

(WebCore::EditorClientWx::frameWillDetachPage):

LayoutTests:

Patch by MORITA Hajime <morrita@google.com> on 2012-05-18
Reviewed by Ryosuke Niwa.

  • editing/spelling/spellcheck-async-remove-frame-expected.txt: Added.
  • editing/spelling/spellcheck-async-remove-frame.html: Added.
13:04 Changeset [122011] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source

Merge 121018 - Causes crashes in LLVMPipe
https://bugs.webkit.org/show_bug.cgi?id=89358

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-06-18
Reviewed by Martin Robinson.

Change suggested by Dave Airlie and Xan Lopez.

  • wtf/Platform.h: disable global fastMalloc for GTK+
13:04 Changeset [122010] by mrobinson@webkit.org
  • 21 edits in releases/WebKitGTK/webkit-1.8

Merge 115829 - [GTK] media/track/track-cue-rendering-snap-to-lines-not-set.html fails
https://bugs.webkit.org/show_bug.cgi?id=84378

Patch by Philippe Normand <pnormand@igalia.com> on 2012-05-02
Reviewed by Eric Carlson.

Source/WebCore:

Fix positioning of the controls panel back to relative, as it is
in the parent CSS. Also remove some duplicate CSS attributes.

  • css/mediaControlsGtk.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

LayoutTests:

  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-playing-and-pause-expected.txt:
  • platform/gtk/media/video-volume-slider-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
  • platform/gtk/test_expectations.txt: Unflag fixed test.
13:03 Changeset [122009] by mrobinson@webkit.org
  • 4 edits
    3 adds in releases/WebKitGTK/webkit-1.8

Merge 115321 - [cairo] CairoGraphicsContext fillRect (with Color) overrides composite operator
https://bugs.webkit.org/show_bug.cgi?id=84848

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-26
Reviewed by Martin Robinson.

Source/WebCore:

FillRectWithColor used to be called fillRectSourceOver before r89314
where this operator still made sense. The way this function is used
these days doesn't expect the composite operator to be overridden anymore.

No new tests, covered by existing tests, e.g.
svg/filters/feDropShadow.svg

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::fillRectWithColor):

LayoutTests:

Unskipping and baselining feDropShadow test,
now works because of composite operator fix.
Fixed png baseline result for drop shadow test on GTK.

  • platform/efl/svg/filters/feDropShadow-expected.png: Added.
  • platform/efl/svg/filters/feDropShadow-expected.txt: Added.
  • platform/efl/test_expectations.txt:
  • platform/gtk/svg/filters/feDropShadow-expected.png:
13:03 Changeset [122008] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore
Merge 116117 - [GTK] ASSERTION FAILED: shouldLoadAsEmptyDocument(r.url())

!defersLoading() in MainResourceLoader.cpp:382

Remove a soup_session_pause_message() call that got left behind,
update the defersLoading stuff to handle this case.

https://bugs.webkit.org/show_bug.cgi?id=85159

Patch by Dan Winship <danw@gnome.org> on 2012-05-04
Reviewed by Martin Robinson.

No new tests. Now passes loader/load-defer-resume-crash.html under
debug build.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::platformSetDefersLoading):

13:03 Changeset [122007] by mrobinson@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8

Merge 116160 - [soup] URL of the ResourceResponse passed to willSendRequest is incorrect
https://bugs.webkit.org/show_bug.cgi?id=85072

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-04
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Store the response message by catching the "got-headers" signal so
that it can be passed later to willSendRequest() in case of
redirection. This is required because the SoupMessage headers and URL
have already been updated once restartedCallback() is called.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::gotHeadersCallback):
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):

LayoutTests:

Unskip http/tests/misc/will-send-request-returns-null-on-redirect.html
and http/tests/loading/307-after-303-after-post.html now that the
response passed to willSendRequest is correct and now that the right
redirect URL is being printed in EFL port.

Unfortunately, http/tests/loading/redirect-methods.html cannot be
unskipped yet due to bug 66873.

  • platform/efl/test_expectations.txt:
13:03 Changeset [122006] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk

Merge 116948 - [GTK] Wrong documentation for Web Database
https://bugs.webkit.org/show_bug.cgi?id=86362

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-14
Reviewed by Martin Robinson.

Fixed docs for webkit_set_default_web_database_quota().

  • webkit/webkitwebdatabase.cpp:
13:03 Changeset [122005] by mrobinson@webkit.org
  • 7 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merge 116949 - [Gtk][DOM Bindings] Feature-protected interface usage in set/get property must be under condition guards
https://bugs.webkit.org/show_bug.cgi?id=86060

Patch by Sriram Neelakandan <sriram.neelakandan@gmail.com> on 2012-05-14
Reviewed by Martin Robinson.

Property set/get functions generated was referencing WebCore::interface without any condition guard.
This issue was triggered usually when an interface gets disabled; For instance; --disable-video, disables WebCore::HTMLMediaElement.
Also updated the GObject binding reference tests

No new tests - covered by existing bindings tests

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperties):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(webkit_dom_test_active_dom_object_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(webkit_dom_test_event_constructor_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(webkit_dom_test_exception_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_get_property):

13:03 Changeset [122004] by mrobinson@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merge 118949 - Check for GTK2/GTK3 symbol mismatch earlier
https://bugs.webkit.org/show_bug.cgi?id=87687

Patch by Daniel Drake <dsd@laptop.org> on 2012-05-30
Reviewed by Martin Robinson.

No new tests. Regressions in core behavior are covered by existing
plugin tests and the fix deals with particular aspects of the system
environment that are difficult to test.

Detect plugins that would mix GTK+ symbols earlier, so that the
WebKit can skip them and choose a more appropriate plugin module.

  • plugins/gtk/PluginPackageGtk.cpp: Move this code from PluginViewGtk.

(WebCore::moduleMixesGtkSymbols):
(WebCore::PluginPackage::load):

  • plugins/gtk/PluginViewGtk.cpp: Move this code to PluginPackageGtk.

(WebCore::PluginView::platformStart):

13:02 Changeset [122003] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 110324 - Crash when splitting an anonymous block in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=80432

Patch by Abhishek Arya <inferno@chromium.org> on 2012-03-09
Reviewed by David Hyatt.

Source/WebCore:

Calculating currChild->nextSibling() is risky after destroying :after content
because it can blow away currChild if it is a left over empty anonymous block.
We need to calculate next sibling upfront, using the same trick, we do in
RenderBlock::addChildIgnoringAnonymousColumnBlock to reset beforeChild (check
out the line before splitFlow call).

Test: fast/multicol/anonymous-block-split-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

  • fast/multicol/anonymous-block-split-crash-expected.txt: Added.
  • fast/multicol/anonymous-block-split-crash.html: Added.
13:02 Changeset [122002] by mrobinson@webkit.org
  • 6 edits in releases/WebKitGTK/webkit-1.8

Merge 112023 - XML error document creation should not fire mutation events
https://bugs.webkit.org/show_bug.cgi?id=80765

Patch by Jeffrey Pfau <jpfau@apple.com> on 2012-03-24
Reviewed by Adam Barth.

Source/WebCore:

Broke two tests that expected the old behavior, which have now been updated.

  • xml/XMLErrors.cpp:

(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):

LayoutTests:

Fixed tests that relied on old behavior.

  • fast/css/stylesheet-candidate-nodes-crash-expected.txt:
  • fast/css/stylesheet-candidate-nodes-crash.xhtml:
  • fast/dom/xml-parser-error-message-crash-expected.txt:
13:02 Changeset [122001] by mrobinson@webkit.org
  • 14 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 115668 - Source/WebCore: Remove positioned float code.
https://bugs.webkit.org/show_bug.cgi?id=84795

Patch by Abhishek Arya <inferno@chromium.org> on 2012-04-30
Reviewed by Dan Bernstein.

Backout r92004 and some pieces from r91702.

Test: fast/block/float/positioned-float-crash.html

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFloat):

  • css/CSSValueKeywords.in:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::simplifiedLayout):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
(WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):

  • rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::forceLayoutInlineChildren):
(FloatingObject):
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::hasOverhangingFloats):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(FloatingObjects):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::updateBoxModelInfoFromStyle):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderDeprecatedFlexibleBox.h:

(RenderDeprecatedFlexibleBox):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollbarsAfterLayout):

  • rendering/style/RenderStyleConstants.h:

LayoutTests: Remove positioned float code.
https://bugs.webkit.org/show_bug.cgi?id=84795

Patch by Abhishek Arya <inferno@chromium.org> on 2012-04-30
Reviewed by Dan Bernstein.

  • fast/block/float/positioned-float-crash-expected.txt: Added.
  • fast/block/float/positioned-float-crash.html: Added.
13:02 Changeset [122000] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 116325 - Crash in RenderBlock::updateFirstLetterStyle.
https://bugs.webkit.org/show_bug.cgi?id=85759

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-07
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/css-generated-content/first-letter-next-sibling-crash.html

RenderBlock::removeChild can bring up the children from last single anonymous block,
causing |nextSibling| in RenderBlock::updateFirstLetterStyle to go stale. We prevent
this by removing the child safely using removeChildNode before destroying it.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):

LayoutTests:

  • fast/css-generated-content/first-letter-next-sibling-crash-expected.txt: Added.
  • fast/css-generated-content/first-letter-next-sibling-crash.html: Added.
13:02 Changeset [121999] by mrobinson@webkit.org
  • 15 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 116174 - ASSERT(beforeChildAnonymousContainer->isTable()); fails in RenderBlock::addChildIgnoringAnonymousColumnBlocks.
https://bugs.webkit.org/show_bug.cgi?id=84606

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-04
Reviewed by Julien Chaffraix.

Source/WebCore:

RenderBlock::removeChild forgot to set display on the anonymous block, causing it
to display as INLINE. To prevent this kind of failure in future, we replace
createAnonymousStyle with createAnonymousStyleWithDisplay to make everyone explictly
pass display as the argument.

Test: fast/block/block-add-child-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousColumnsWithParentRenderer):
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRenderer):

  • rendering/RenderInline.cpp:

(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::addChildIgnoringContinuation):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::propagateStyleToAnonymousChildren):

  • rendering/RenderRuby.cpp:

(WebCore::createAnonymousRubyInlineBlock):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::createAnonymousWithParentRenderer):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::createAnonymousWithParentRenderer):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::createAnonymousWithParentRenderer):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::createAnonymousWithParentRenderer):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::createAlmostAnonymousBlock):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::addChild):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::createAnonymousStyleWithDisplay):

  • rendering/style/RenderStyle.h:

LayoutTests:

  • fast/block/block-add-child-crash-expected.txt: Added.
  • fast/block/block-add-child-crash.html: Added.
13:01 Changeset [121998] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 117304 - Missing RenderApplet cast check in HTMLAppletElement::renderWidgetForJSBindings.
https://bugs.webkit.org/show_bug.cgi?id=86627

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-16
Reviewed by Andreas Kling.

Source/WebCore:

Test: java/inline-applet-crash.html

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::renderWidgetForJSBindings):

LayoutTests:

  • java/inline-applet-crash-expected.txt: Added.
  • java/inline-applet-crash.html: Added.
13:01 Changeset [121997] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 116669 - Crash in ApplyStyleCommand::joinChildTextNodes.
https://bugs.webkit.org/show_bug.cgi?id=85939

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-10
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/style/apply-style-join-child-text-nodes-crash.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): add conditions
to bail out if our start and end position nodes are removed due to
mutation events in joinChildTextNodes.
(WebCore::ApplyStyleCommand::applyInlineStyle): this executes after
applyRelativeFontStyleChange in ApplyStyleCommand::doApply. So, need
to bail out if our start and end position nodes are removed due to
mutation events.
(WebCore::ApplyStyleCommand::joinChildTextNodes): hold all the children
in a ref vector to prevent them from getting destroyed due to mutation events.

LayoutTests:

  • editing/style/apply-style-join-child-text-nodes-crash-expected.txt: Added.
  • editing/style/apply-style-join-child-text-nodes-crash.html: Added.
13:01 Changeset [121996] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 116545 - Crash in ReplaceSelectionCommand::performTrivialReplace
https://bugs.webkit.org/show_bug.cgi?id=85943

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-09
Reviewed by Ryosuke Niwa.

Source/WebCore:

RefPtr nodeAfterInsertionPos to guard against mutation events.

Test: editing/inserting/insert-html-crash.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::performTrivialReplace):

LayoutTests:

  • editing/inserting/insert-html-crash-expected.txt: Added.
  • editing/inserting/insert-html-crash.html: Added.
13:01 Changeset [121995] by mrobinson@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 116683 - Crash due to floats not removed from first-letter element.
https://bugs.webkit.org/show_bug.cgi?id=86019

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-10
Reviewed by Julien Chaffraix.

Source/WebCore:

Move clearing logic of a floating/positioned object from removeChild
to removeChildNode. There are lot of places which use removeChildNode
directly and hence the object is not removed from the floating or
positioned objects list.

Test: fast/block/float/float-not-removed-from-first-letter.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::removeChild):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

LayoutTests:

  • fast/block/float/float-not-removed-from-first-letter-expected.txt: Added.
  • fast/block/float/float-not-removed-from-first-letter.html: Added.
13:01 Changeset [121994] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 116864 - Crash in HTMLSelectElement::setOption
https://bugs.webkit.org/show_bug.cgi?id=85420

Source/WebCore:

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-12
Reviewed by Eric Seidel

RefPtr before option in HTMLSelectElement::setOption since it
can get destroyed due to mutation events.

Test: fast/dom/HTMLSelectElement/option-add-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setOption):

LayoutTests:

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-12
Reviewed by Eric Seidel.

  • fast/dom/HTMLSelectElement/option-add-crash-expected.txt: Added.
  • fast/dom/HTMLSelectElement/option-add-crash.html: Added.
13:00 Changeset [121993] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 117224 - Crash in Document::nodeChildrenWillBeRemoved.
https://bugs.webkit.org/show_bug.cgi?id=85247

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-15
Reviewed by Hajime Morita.

Source/WebCore:

Reverse ordering of commands to ref ptr the children set
first before calling nodeChildrenWillBeRemoved, since it
can fire mutation events.

Test: fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChildren):

LayoutTests:

  • fast/dom/HTMLObjectElement/beforeload-set-text-crash-expected.txt: Added.
  • fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml: Added.
13:00 Changeset [121992] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore

Merge 116717 - Crash in swapInNodePreservingAttributesAndChildren.
https://bugs.webkit.org/show_bug.cgi?id=85197

Patch by Abhishek Arya <inferno@chromium.org> on 2012-05-10
Reviewed by Ryosuke Niwa.

Keep the children in a ref vector before adding them to newNode.
They can get destroyed due to mutation events.

No new tests because we don't have a reduction.

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

13:00 Changeset [121991] by mrobinson@webkit.org
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-1.8

Merge 116357 - Crash due to positioned object list not being cleared during block flow split
https://bugs.webkit.org/show_bug.cgi?id=85074

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-05-07
Reviewed by Abhishek Arya.

Source/WebCore:

When an element is being split due to a column span element being
inserted, any of its ancestors that are underneath the column
containing block also get split. If an ancestor has an object in
its positioned object list from a previous layout, then the list
will have to be cleared because the positioned object could have moved
to be under the continuation. This patch causes the list to be
cleared.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):

LayoutTests:

Test exercises crashing condition in bug 85074. It creates a column
span that requires multiple layers of splitting blocks from the
element that contains the columns, puts a positioned element underneath
one of the split blocks, and then causes a reattach of the column span
element.

  • fast/block/positioning/positioned-object-under-split-block-parent-crash-expected.txt: Added
  • fast/block/positioning/positioned-object-under-split-block-parent-crash.html: Added
12:19 Changeset [121990] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[EFL][CMake] Move gtest sources to an upper level
https://bugs.webkit.org/show_bug.cgi?id=90602

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-06
Reviewed by Chang Shu.

.:

CTest was enabled for all the ports, but used only by EFL. Now
ENABLE_API_TESTS has to be defined, which will also build gtest.

  • CMakeLists.txt:
  • Source/CMakeLists.txt:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/gtest/CMakeLists.txt: Added.

Source/WebKit:

Removed gtest since it is now built as a separated component.
This will allow us to share it with WebKit 2 API tests.

  • PlatformEfl.cmake:
12:12 Changeset [121989] by commit-queue@webkit.org
  • 13 edits
    15 adds in trunk/Source/WebKit2

[WK2] Add support for Network Information API
https://bugs.webkit.org/show_bug.cgi?id=89870

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-06
Reviewed by Anders Carlsson.

Add Network Information API support for WebKit2.

  • CMakeLists.txt:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Platform/CoreIPC/MessageID.h:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • Shared/WebNetworkInfo.cpp: Added.

(WebKit):
(WebKit::WebNetworkInfo::WebNetworkInfo):
(WebKit::WebNetworkInfo::~WebNetworkInfo):
(WebKit::WebNetworkInfo::Data::encode):
(WebKit::WebNetworkInfo::Data::decode):

  • Shared/WebNetworkInfo.h: Added.

(WebKit):
(WebNetworkInfo):
(Data):
(WebKit::WebNetworkInfo::create):
(WebKit::WebNetworkInfo::bandwidth):
(WebKit::WebNetworkInfo::metered):
(WebKit::WebNetworkInfo::data):
(WebKit::WebNetworkInfo::type):

  • Target.pri:
  • UIProcess/API/C/WKAPICast.h:

(WebKit):

  • UIProcess/API/C/WKNetworkInfoManager.cpp: Added.

(WKNetworkInfoManagerGetTypeID):

  • UIProcess/API/C/WKNetworkInfoManager.h: Added.
  • UIProcess/WebNetworkInfoManagerProxy.cpp: Added.

(WebKit):
(WebKit::WebNetworkInfoManagerProxy::create):
(WebKit::WebNetworkInfoManagerProxy::WebNetworkInfoManagerProxy):
(WebKit::WebNetworkInfoManagerProxy::~WebNetworkInfoManagerProxy):
(WebKit::WebNetworkInfoManagerProxy::invalidate):
(WebKit::WebNetworkInfoManagerProxy::initializeProvider):
(WebKit::WebNetworkInfoManagerProxy::providerDidChangeNetworkInformation):
(WebKit::WebNetworkInfoManagerProxy::didReceiveMessage):
(WebKit::WebNetworkInfoManagerProxy::startUpdating):
(WebKit::WebNetworkInfoManagerProxy::stopUpdating):
(WebKit::WebNetworkInfoManagerProxy::getBandwidth):
(WebKit::WebNetworkInfoManagerProxy::isMetered):

  • UIProcess/WebNetworkInfoManagerProxy.h: Added.

(CoreIPC):
(WebKit):
(WebNetworkInfoManagerProxy):
(WebKit::WebNetworkInfoManagerProxy::clearContext):
(WebKit::WebNetworkInfoManagerProxy::type):

  • UIProcess/WebNetworkInfoManagerProxy.messages.in: Added.
  • UIProcess/WebNetworkInfoProvider.cpp: Added.

(WebKit):
(WebKit::WebNetworkInfoProvider::startUpdating):
(WebKit::WebNetworkInfoProvider::stopUpdating):
(WebKit::WebNetworkInfoProvider::bandwidth):
(WebKit::WebNetworkInfoProvider::metered):

  • UIProcess/WebNetworkInfoProvider.h: Added.

(WebKit):
(WebNetworkInfoProvider):

  • WebKit2.pri:
  • WebProcess/NetworkInfo/WebNetworkInfoManager.cpp: Added.

(WebKit):
(WebKit::WebNetworkInfoManager::WebNetworkInfoManager):
(WebKit::WebNetworkInfoManager::~WebNetworkInfoManager):
(WebKit::WebNetworkInfoManager::didReceiveMessage):
(WebKit::WebNetworkInfoManager::registerWebPage):
(WebKit::WebNetworkInfoManager::unregisterWebPage):
(WebKit::WebNetworkInfoManager::bandwidth):
(WebKit::WebNetworkInfoManager::metered):
(WebKit::WebNetworkInfoManager::didChangeNetworkInformation):

  • WebProcess/NetworkInfo/WebNetworkInfoManager.h: Added.

(CoreIPC):
(WebKit):
(WebNetworkInfoManager):

  • WebProcess/NetworkInfo/WebNetworkInfoManager.messages.in: Added.
  • WebProcess/WebCoreSupport/WebNetworkInfoClient.cpp: Added.

(WebKit):
(WebKit::WebNetworkInfoClient::~WebNetworkInfoClient):
(WebKit::WebNetworkInfoClient::bandwidth):
(WebKit::WebNetworkInfoClient::metered):
(WebKit::WebNetworkInfoClient::startUpdating):
(WebKit::WebNetworkInfoClient::stopUpdating):

  • WebProcess/WebCoreSupport/WebNetworkInfoClient.h: Added.

(WebKit):
(WebNetworkInfoClient):
(WebKit::WebNetworkInfoClient::WebNetworkInfoClient):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

(WebProcess):
(WebKit::WebProcess::networkInfoManager):

11:36 Changeset [121988] by zandobersek@gmail.com
  • 4 edits in trunk

[Gtk] Add a configuration option for disabling unstable features in releases
https://bugs.webkit.org/show_bug.cgi?id=87995

Reviewed by Martin Robinson.

.:

Add a configuration flag for enabling the unstable features - features of which
support in the Gtk port is being worked on but is not yet complete. The primary
use of this flag is when compiling through the build-webkit script.

All the features that are currently enabled when building through build-webkit but
are disabled by default when executing the configure script directly have their default
value (when the correspondent flag is not passed) set to 'yes' when unstable features
are enabled and 'no' otherwise. This way unstable features are kept disabled when performing
a release build (unless they are specifically enabled).

  • configure.ac:

Tools:

Pass the --enable-unstable-features flag when building the Gtk port through build-webkit.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

10:47 Changeset [121987] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Drawing to accelerated 2D canvas causes compositor to recompute layer tree
https://bugs.webkit.org/show_bug.cgi?id=90630

Patch by Justin Novosad <junov@chromium.org> on 2012-07-06
Reviewed by Simon Fraser.

No new tests: covered by existing canvas/compositing layout tests

Before this change, there was no distinction between canvas changes
that require recomputing the compositor tree and canvas changes that
only require re-display. The new CanvasPixelsChanged member of enum
ContentChangeType requests re-display without re-layout.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::didDraw):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::contentChanged):

10:39 Changeset [121986] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

Fix build with recent clang.
https://bugs.webkit.org/show_bug.cgi?id=90634

Patch by Nuno Lopes <nlopes@apple.com> on 2012-07-06
Reviewed by Oliver Hunt.

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(SpecializedThunkJIT):

  • jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):

  • parser/NodeConstructors.h:

(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::ForNode::ForNode):
(JSC::ForInNode::ForInNode):

  • parser/Nodes.h:

(FunctionCallResolveNode):
(PostfixErrorNode):
(PrefixErrorNode):
(ReadModifyResolveNode):
(AssignResolveNode):
(AssignErrorNode):
(ForNode):
(ForInNode):

  • parser/Parser.cpp:

(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createForLoop):

10:26 Changeset [121985] by lforschler@apple.com
  • 12 edits in branches/safari-534.57-branch

Merge 116381.

10:19 Changeset [121984] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: get rid of this._lastMarkedRange in TextEditor.
https://bugs.webkit.org/show_bug.cgi?id=90691

Reviewed by Vsevolod Vlasov.

We don't need it, should use setSelection instead.

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.markAndRevealRange):
(WebInspector.TextEditor.prototype._handleSelectionChange):
(WebInspector.TextEditor.prototype.setSelection):
(WebInspector.TextEditor.prototype._handleFocused):

10:08 Changeset [121983] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Snippet renaming behavior is not correct.
https://bugs.webkit.org/show_bug.cgi?id=90689

Reviewed by Pavel Feldman.

Navigator overlay is now not closed when editing is canceled.
Esc handler in NavigatorOverlayController is not installed as a shortcut anymore since
it should not be called until all underlying DOM elements handled the key down event.

  • inspector/front-end/NavigatorOverlayController.js:

(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._keyDown):
(WebInspector.NavigatorOverlayController.prototype._innerHideNavigatorOverlay):

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype.rename.commitHandler):
(WebInspector.NavigatorView.prototype.rename.cancelHandler):
(WebInspector.NavigatorView.prototype.rename.afterEditing):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._itemRenamingRequested):
(WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._itemRenamingRequested.callback):
(WebInspector.ScriptsPanel.prototype._itemRenamingRequested):

10:05 Changeset [121982] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

Separate mutating CSSStyleDeclaration operations.
<http://webkit.org/b/89945>

Reviewed by Antti Koivisto.

Use separate paths for mutating the StylePropertySet wrapped by a CSSStyleDeclaration.
PropertySetCSSStyleDeclaration now has:

  • propertySet() const
  • ensureMutablePropertySet()

This is prep work for supporting immutable ElementAttributeData objects, the idea being
that calling ensureMutablePropertySet() may cause the element to convert its internal
attribute storage (which also holds the inline StylePropertySet.)

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::length):
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::cssText):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::copy):
(WebCore::PropertySetCSSStyleDeclaration::makeMutable):
(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):
(WebCore::InlineCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::ensureMutablePropertySet):

  • css/PropertySetCSSStyleDeclaration.h:

(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::propertySet):
(WebCore::PropertySetCSSStyleDeclaration::ensureMutablePropertySet):

09:54 Changeset [121981] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: text editor scrolls 2px horizontally as one navigates the source code.
https://bugs.webkit.org/show_bug.cgi?id=90682

Reviewed by Vsevolod Vlasov.

Removing the hack that is glueing the scroller to the left.

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype._updatePanelOffsets):
(WebInspector.TextEditorChunkedPanel.prototype._scroll):

  • inspector/front-end/textEditor.css:
09:41 Changeset [121980] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: get rid of cancellable records in Timeline, manage frame records explicitly
https://bugs.webkit.org/show_bug.cgi?id=90684

Reviewed by Pavel Feldman.

  • drop handling of "cancelable" records;
  • keep frame record until other records come (or frame is canceled)
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didBeginFrame):
(WebCore::InspectorTimelineAgent::didCancelFrame):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::commitFrameRecord):
(WebCore::InspectorTimelineAgent::clearRecordStack):

  • inspector/InspectorTimelineAgent.h:

(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):
(InspectorTimelineAgent):

09:35 Changeset [121979] by jberlin@webkit.org
  • 14 edits
    2 copies
    2 adds in trunk

Source/WebKit2: WKContext should ask for its injected bundle initialization user data when it needs it so the
client doesn't have to keep it up to date.
https://bugs.webkit.org/show_bug.cgi?id=90627

Reviewed by NOBODY (OOPS!).

Add a getInjectedBundleInitializationUserData callback to WKContextInjectedBundleClient.

  • Shared/APIClientTraits.cpp:

Allow the WKContextInjectedBundleClient API to be versioned.

  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKContext.h:

Add the callback and bump the version of WKContextInjectedBundleClient.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):
Prefer any user data returned when the callback is invoked over that set with
WKContextSetInitializationUserDataForInjectedBundle.

  • UIProcess/WebContextInjectedBundleClient.cpp:

(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):
Invoke the callback if the client has registered for it.

  • UIProcess/WebContextInjectedBundleClient.h:

Tools: WKContext should ask for its initialization data when it needs it so the client doesn't have
to keep it up to date.
https://bugs.webkit.org/show_bug.cgi?id=90627

Reviewed by NOBODY (OOPS!).

Add tests and update other WKContextInjectedBundleClients.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
Updated for the change to WKContextInjectedBundleClient.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
Ditto.

  • TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
Moved the logic to create the initialization dictionary here ...
(TestWebKitAPI::Util::createContextForInjectedBundleTest):
... from here so that it can be used without automatically using
WKContextSetInitializationUserDataForInjectedBundle.

  • TestWebKitAPI/PlatformUtilities.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add the new test files.

  • TestWebKitAPI/GNUmakefile.am:

Ditto.

  • TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Check that the message received from the injected bundle matches the user data it was
initialized with.
(TestWebKitAPI::getInjectedBundleInitializationUserData):
Return the user data that the injected bundle should be initialized with.
(TestWebKitAPI::TEST):
Set up WKContextInjectedBundleClient and load a page.

  • TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: Added.

(TestWebKitAPI::GetInjectedBundleInitializationUserDataCallbackTest::initialize):
Send the initialization user data back up to the UI Process.

  • TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Check that the message received from the injected bundle matches the user data it was
initialized with in the callback.
(TestWebKitAPI::getInjectedBundleInitializationUserData):
Return the user data that the injected bundle should be initialized with.
(TestWebKitAPI::TEST):
Set up the context and use WKContextSetInitializationUserDataForInjectedBundle to set the
initialization user data (which should be overridden by the user data returned in
getInjectedBundleInitializationUserData).

  • TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: Added.

(TestWebKitAPI::InjectedBundleInitializationUserDataCallbackWinsTest::initialize):
Send the initialization user data back up to the UI Process.

09:35 Changeset [121978] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebContext::injectedBundleInitializationUserData() is unused, should be removed
https://bugs.webkit.org/show_bug.cgi?id=90486

Reviewed by Anders Carlsson.

  • UIProcess/WebContext.h:

Remove it.

09:29 Changeset [121977] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests.

  • platform/qt-5.0-wk1/Skipped:
09:04 Changeset [121976] by carlosgc@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] Add site specific quirks setting to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=90663

Reviewed by Martin Robinson.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_site_specific_quirks):
(webkit_settings_set_enable_site_specific_quirks):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

09:01 Changeset [121975] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL][GTK] jhbuild : Disable pixman demos build depending on GTK+
https://bugs.webkit.org/show_bug.cgi?id=90593

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-06
Reviewed by Philippe Normand.

  • efl/jhbuild.modules: Give '--enable-gtk=no' option to pixman.
  • gtk/jhbuild.modules: Give '--enable-gtk=no' option to pixman.
08:55 Changeset [121974] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, clean up the TestExpectations file, removing
non-existent or doubled test entries and re-specifying detailed test
expectations so the TestExpectations lint passes.

  • platform/gtk/TestExpectations:
08:02 Changeset [121973] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] [GTK] http/tests/multipart/multipart-replace-non-html-content.php is failing after r121912
https://bugs.webkit.org/show_bug.cgi?id=90685

Unreviewed gardening, add test expectation for a failing
test after r121912.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-06

  • platform/efl/TestExpectations:
07:49 Changeset [121972] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

ProcessLauncher's WorkQueue's name is too long on Windows
https://bugs.webkit.org/show_bug.cgi?id=44041

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-06
Reviewed by Andreas Kling.

Shorten thread name for process launcher so that we can silence the warning
for thread names getting truncated under VisualStudio -
see createThread() in Threading.cpp.

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::processLauncherWorkQueue):

07:37 Changeset [121971] by ossy@webkit.org
  • 7 edits in trunk

[Qt] DumpRenderTree does not use 'monospace' font when directed
https://bugs.webkit.org/show_bug.cgi?id=85203

The test fonts used for Qt tests were moved to the Liberation font family.

Due to this change we are skipping tons of tests. They will be gradually
unskipped in batches, ASAP.

Also, the now unneeded special font configuration for Qt5 WK1 was removed.

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-06
Reviewed by Tor Arne Vestbø.

Tools:

  • DumpRenderTree/qt/QtInitializeTestFonts.cpp:

(WebKit::initializeTestFonts):

LayoutTests:

  • platform/qt-4.8/Skipped:
  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
07:21 Changeset [121970] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION: 5 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=90687

Unreviewed gardening, skip new failing tests.

  • platform/qt-5.0/Skipped:
07:16 Changeset [121969] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] WebKit-EFL headers do not build with gcc < 4.6
https://bugs.webkit.org/show_bug.cgi?id=90681

Unreviewed EFL build fix.

Remove several forward declarations from ewk_view
header to avoid typedef redefinitions which are
illegal in C.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-06

  • UIProcess/API/efl/ewk_view.h:
07:11 SelectiveTestEWS edited by rhino666@gmail.com
(diff)
07:09 Changeset [121968] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Add native memory used by GlyphCache to the snapshot
https://bugs.webkit.org/show_bug.cgi?id=90615

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-06
Reviewed by Yury Semikhatsky.

  • inspector/InspectorMemoryAgent.cpp:

(MemoryBlockName):
(WebCore):
(WebCore::addPlatformComponentsInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

  • platform/MemoryUsageSupport.cpp:

(WebCore::MemoryUsageSupport::memoryUsageByComponents):
(WebCore):

  • platform/MemoryUsageSupport.h:

(MemoryUsageSupport):
(ComponentInfo):
(WebCore::MemoryUsageSupport::ComponentInfo::ComponentInfo):

  • platform/chromium/MemoryUsageSupportChromium.cpp:

(WebCore::glyphCacheVisitor):
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageByComponents):

06:46 SelectiveTestEWS edited by kerekattila.hun@gmail.com
(diff)
06:23 Changeset [121967] by ossy@webkit.org
  • 8 edits in trunk

[Qt] Buildfix for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=90519

Reviewed by Tor Arne Vestbø.

Source/WebKit/qt:

  • WebCoreSupport/QtFallbackWebPopup.cpp: Include QtGui/QStandardItemModel instead of deprecated QStandardItemModel.

Source/WebKit2:

  • UIProcess/API/qt/qwebkittest.cpp: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h.

Tools:

  • MiniBrowser/qt/MiniBrowser.pro: We also need to depend on gui-private in the MiniBrowser to get access to these headers.
  • MiniBrowser/qt/MiniBrowserApplication.h: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: Include qpa/qwindowsysteminterface.h instead of deprecated qwindowsysteminterface_qpa.h
06:20 Changeset [121966] by ossy@webkit.org
  • 3 edits in trunk/Tools

[Qt] Make use of Qt5 qmake's changed makefile recursion behavior

When not using the -r option, qmake now interleaves qmake and make calls,
so we don't need custom logic for this. There's also an option to supress
the effect of the -r option, which we use to make WebKit.pro the only
project file parsed in a recursive qmake-run.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/functions.prf:
06:18 Changeset [121965] by ossy@webkit.org
  • 4 edits in trunk

[Qt] Remove custom qmake logic for module creation

Qmake now has the necessary hooks to cleanly override the build locations.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri:

Tools:

  • qmake/mkspecs/features/default_pre.prf:
06:17 Changeset [121964] by ossy@webkit.org
  • 4 edits
    1 add in trunk

[Qt] Add top-level .qmake.conf

With Qt5, this makes setting $QMAKEPATH externally unnecessary.

The magic in the perl scripts to set QMAKEPATH is still there, as it doesn't
hurt, and is still required for Qt4.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

.:

  • .qmake.conf: Added.
  • WebKit.pro:

Tools:

  • qmake/mkspecs/features/default_pre.prf:
06:16 Changeset [121963] by ossy@webkit.org
  • 4 edits in trunk/Tools

[Qt] Unify qtFeatureDefaults code paths

There's no reason to run qmake on features.prf directly anymore, as we
can selectivly run configure tests in the project file now.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

  • Scripts/webkitdirs.pm:

(qtFeatureDefaults):

  • qmake/configure.pri:
  • qmake/mkspecs/features/features.prf:
06:15 Changeset [121962] by ossy@webkit.org
  • 2 edits in trunk

[Qt] Let qt_module_config create the forwarding module pri file

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

  • Source/sync.profile:
06:14 Changeset [121961] by ossy@webkit.org
  • 4 edits in trunk

[Qt] Don't let qt_webkit.pri proclaim its own location

This won't work any more with recent Qt5 versions, as the forwarding
pri is created by qt_module_config, which needs MODULE_PRI to be set
up already.

We also need to load build_config, not qt_module.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

.:

  • Source/api.pri:

Tools:

  • qmake/qt_webkit.pri:
06:13 Changeset [121960] by ossy@webkit.org
  • 4 edits in trunk

[Qt] Remove redundant CONFIG+=module

qt_module_config takes care of that.

In api.pri we are actually testing the flag ourselves, so now we need to
test a related flag qt_module_config sets instead.

.:

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

  • Source/api.pri:

Tools:

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

  • qmake/mkspecs/features/default_post.prf:
06:12 Changeset [121959] by ossy@webkit.org
  • 8 edits in trunk

[Qt] Adjust to changed generation of master include file

The responsiblity for creating the master include was moved out of syncqt.
@ignore_for_master_contents still stays, as syncqt (ab-)uses this for
determining whether a header is private.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

.:

  • Source/sync.profile:

Source/WebKit/qt:

  • Api/qwebscriptworld.h:
  • tests/util.h:

Source/WebKit2:

  • UIProcess/API/qt/tests/bytearraytestdata.h:
  • UIProcess/API/qt/tests/testwindow.h:
06:10 Changeset [121958] by ossy@webkit.org
  • 8 edits
    1 copy
    1 delete in trunk

[Qt] Switch to new-style Qt 5 configure tests

Use explicit project file action instead of syncqt magic.

https://bugs.webkit.org/show_bug.cgi?id=90461

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-06
Reviewed by Tor Arne Vestbø.

Source/WebCore:

  • WebCore.pri:

Tools:

  • Scripts/webkitdirs.pm:

(buildQMakeProjects):

  • qmake/configure.pri: Copied from Tools/qmake/configure.pro.
  • qmake/configure.pro:
  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/features.prf:
  • qmake/sync.profile: Removed.
06:08 Changeset [121957] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: start searching from the cursor position in the Sources panel.
https://bugs.webkit.org/show_bug.cgi?id=90677

Reviewed by Vsevolod Vlasov.

Web Inspector: start searching from the cursor position in the Sources panel.
Drive-by: select whole match upon search cancel.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.lastSelection):
(WebInspector.TextEditor.prototype._handleFocused):

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextRange.prototype.serializeToObject):
(WebInspector.TextRange.prototype.compareTo):

05:19 Changeset [121956] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Snippets should be correctly (re)loaded when inspector is open and on navigation.
https://bugs.webkit.org/show_bug.cgi?id=90672

Reviewed by Pavel Feldman.

Snippets are now reloaded from the storage on ScriptSnippetMapping reset.
Fixed snippets storage.

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._loadSnippets):
(WebInspector.ScriptSnippetModel.prototype._reset):

  • inspector/front-end/SnippetStorage.js:

(WebInspector.Snippet.fromObject):

05:14 Changeset [121955] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Implement snippets removing.
https://bugs.webkit.org/show_bug.cgi?id=90674

Reviewed by Pavel Feldman.

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype.rename.afterEditing):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype.removeUISourceCode):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._revealExecutionLine):

  • inspector/front-end/TabbedEditorContainer.js:
05:02 Changeset [121954] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, adding a test expectation for a failing
http multipart test after r121912.

  • platform/gtk/TestExpectations:
04:45 Changeset [121953] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Not reviewed: fix inspector front-end compilation.

  • inspector/front-end/ElementsTreeOutline.js:
  • inspector/front-end/SearchController.js:
04:25 Changeset [121952] by yurys@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: add memory reporting routine to Document
https://bugs.webkit.org/show_bug.cgi?id=90668

Reviewed by Pavel Feldman.

Added methods for reporting HashSet, ListHashSet and Vector memory
footprint. Made Document report its size along with its internal
collections sizes.

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):
(WebCore):

  • dom/Document.h:

(Document):

  • dom/MemoryInstrumentation.h:

(MemoryInstrumentation):
(MemoryObjectInfo):
(WebCore::MemoryObjectInfo::reportHashMap):
(WebCore::MemoryObjectInfo::reportHashSet):
(WebCore::MemoryObjectInfo::reportListHashSet):
(WebCore::MemoryObjectInfo::reportVector):
(WebCore::MemoryObjectInfo::memoryInstrumentation):
(WebCore::MemoryInstrumentation::reportHashMap):
(WebCore):
(WebCore::MemoryInstrumentation::reportHashSet):
(WebCore::MemoryInstrumentation::reportListHashSet):
(WebCore::MemoryInstrumentation::reportVector):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):

03:05 Changeset [121951] by rgabor@webkit.org
  • 4 edits in trunk/Source/WebCore

Fixing defines for NEON intrinsics.
https://bugs.webkit.org/show_bug.cgi?id=90666

Reviewed by Zoltan Herczeg.

Existing tests cover this issue.

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyGeneric):

  • platform/graphics/filters/arm/FEGaussianBlurNEON.h:
  • platform/graphics/filters/arm/NEONHelpers.h:
03:04 Changeset [121950] by toyoshim@chromium.org
  • 1 edit
    2 moves
    1 add in trunk/LayoutTests

[Inspector][WebSocket][NRWT] layout tests which requires websocket server must be in a websocket subdirectory.
https://bugs.webkit.org/show_bug.cgi?id=90524

Reviewed by Pavel Feldman.

  • http/tests/inspector/websocket/web-socket-frame-expected.txt: Renamed from LayoutTests/http/tests/inspector/web-socket-frame-expected.txt.
  • http/tests/inspector/websocket/web-socket-frame.html: Renamed from LayoutTests/http/tests/inspector/web-socket-frame.html.
02:46 Changeset [121949] by vsevik@chromium.org
  • 13 edits in trunk

Web Inspector: Workspace should dispatch WorkspaceReset event on navigation.
https://bugs.webkit.org/show_bug.cgi?id=90616

Reviewed by Pavel Feldman.

Source/WebCore:

Workspace UISourceCodeProviders are now reset on navigation.
UISourceCodeRemoved event is not dispatched from UISourceCodeProviders on reset (page navigation) anymore.

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.reset):

  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._reset):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._loadUISourceCodes):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.ScriptsPanel.prototype.showGoToSourceDialog):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.reset):

  • inspector/front-end/Workspace.js:

(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodeProviders):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.registerUISourceCodeProvider):
(WebInspector.Workspace.prototype._reset):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/linkifier.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/styles/edit-inspector-stylesheet.html:
01:42 Changeset [121948] by zherczeg@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[Qt][ARM] REGRESSION(r121885): It broke 30 jsc tests, 500+ layout tests
https://bugs.webkit.org/show_bug.cgi?id=90656

Reviewed by Csaba Osztrogonác.

Typo fixes.

  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
Rename getOp2Byte() -> getOp2Half()

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::convertibleLoadPtr):
Add a necessary space.

  • jit/JITStubs.cpp:

(JSC):
Revert INLINE_ARM_FUNCTION macro.

00:17 Changeset [121947] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit

[EFL] Add Web Inspector to WebKit-EFL
https://bugs.webkit.org/show_bug.cgi?id=83865

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-06
Reviewed by Pavel Feldman.

Source/WebKit:

EFL port implementation for Web Inspector.
Prepare Web Inspector resources.

  • PlatformEfl.cmake:

Source/WebKit/efl:

EFL port implementation for Web Inspector.
Implementation of InspectorClientEfl and InspectorFrontendClientEfl
for using the Web Inspector in WebKit-EFL with new EWK APIs.

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::notifyWebInspectorDestroy):
(WebCore):
(InspectorFrontendSettingsEfl):
(WebCore::InspectorFrontendSettingsEfl::getProperty):
(WebCore::InspectorFrontendSettingsEfl::setProperty):
(WebCore::InspectorClientEfl::InspectorClientEfl):
(WebCore::InspectorClientEfl::~InspectorClientEfl):
(WebCore::InspectorClientEfl::inspectorDestroyed):
(WebCore::InspectorClientEfl::openInspectorFrontend):
(WebCore::InspectorClientEfl::closeInspectorFrontend):
(WebCore::InspectorClientEfl::bringFrontendToFront):
(WebCore::InspectorClientEfl::sendMessageToFrontend):
(WebCore::InspectorClientEfl::releaseFrontendPage):
(WebCore::InspectorClientEfl::inspectorFilesPath):
(WebCore::InspectorFrontendClientEfl::InspectorFrontendClientEfl):
(WebCore::InspectorFrontendClientEfl::~InspectorFrontendClientEfl):
(WebCore::InspectorFrontendClientEfl::localizedStringsURL):
(WebCore::InspectorFrontendClientEfl::hiddenPanels):
(WebCore::InspectorFrontendClientEfl::bringToFront):
(WebCore::InspectorFrontendClientEfl::closeWindow):
(WebCore::InspectorFrontendClientEfl::inspectedURLChanged):
(WebCore::InspectorFrontendClientEfl::attachWindow):
(WebCore::InspectorFrontendClientEfl::detachWindow):
(WebCore::InspectorFrontendClientEfl::setAttachedWindowHeight):
(WebCore::InspectorFrontendClientEfl::destroyInspectorWindow):

  • WebCoreSupport/InspectorClientEfl.h:

(WebCore):
(InspectorClientEfl):
(InspectorFrontendClientEfl):
(WebCore::InspectorFrontendClientEfl::disconnectInspectorClient):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_web_inspector_show):
(ewk_view_web_inspector_close):
(ewk_view_web_inspector_view_get):
(ewk_view_web_inspector_view_set):

  • ewk/ewk_view.h:
00:01 Changeset [121946] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r121925): It broke 5 sputnik tests on x86 platforms
https://bugs.webkit.org/show_bug.cgi?id=90658

Reviewed by Zoltan Herczeg.

Under the new object model, out-of-line property accesses such as those
in ResolveGlobal must account for the fact that the offset to the Kth
property is represented by K + inlineStorageCapacity. Hence, the property
loads in ResolveGlobal must have an additional -inlineStorageCapacity *
sizeof(JSValue) offset.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

07/05/12:

23:27 Changeset [121945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Showing the context menu in the Web Inspector can crash the browser
https://bugs.webkit.org/show_bug.cgi?id=88800

Patch by Arnaud Renevier <arno@renevier.net> on 2012-07-05
Reviewed by Carlos Garcia Campos.

Remove ContextMenuItem from its parent before appending it again to a
new parent

No new tests, behavior is unchanged.

  • platform/gtk/ContextMenuGtk.cpp:

(WebCore::ContextMenu::appendItem):

23:07 Changeset [121944] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[WK2][EFL] Ewk_View needs to report load status changes
https://bugs.webkit.org/show_bug.cgi?id=90566

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Add new "load,finished", "load,provisional,failed",
"load,provisional,redirect" and "load,provisional,started"
signals on the Ewk_View to notify the client of different
load state changes.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_load_finished):
(ewk_view_load_provisional_failed):
(ewk_view_load_provisional_redirect):
(ewk_view_load_provisional_started):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(ewk_view_loader_client_attach):

  • UIProcess/API/efl/ewk_view_private.h:
21:52 Changeset [121943] by ossy@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Unreviewed 64 bit buildfix after r121925.

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):

21:31 Changeset [121942] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Transform should be applied to the clip rect in QRawWebView::paint
https://bugs.webkit.org/show_bug.cgi?id=90652

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Applying the transformation matrix to the clip rect in QRawWebView::paint.

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebView::paint):

21:25 Changeset [121941] by jason.liu@torchmobile.com.cn
  • 2 edits in trunk/Tools

Add Jason Liu to committers.py.
https://bugs.webkit.org/show_bug.cgi?id=90654

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
21:09 Changeset [121940] by yosin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed Chromium gardening. Roll Chromium DEPS

  • DEPS: 145501 => 145569
20:57 Changeset [121939] by yosin@chromium.org
  • 12 edits
    2 deletes in trunk/LayoutTests

Unreviewed Chromium gardening - Rebaseline for r121917.

  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/fast/html/details-marker-style-expected.png:
  • platform/chromium-mac/fast/html/details-marker-style-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/fast/html/details-marker-style-expected.png:
  • platform/chromium-win/fast/html/details-marker-style-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
20:47 Changeset [121938] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Unreviewed, Fix build break when WEB_AUDIO is enabled.
https://bugs.webkit.org/show_bug.cgi?id=90653

Unreviewed build fix.

A new file, AudioFIFO.cpp, is added for the Web Audio fearure.
This file should be included into the CMakeLists.txt file.

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-05

  • CMakeLists.txt: Add the newly created file into the CMakeLists.txt
20:33 Changeset [121937] by yosin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed Chromium gardening - Disable WebAnimationTest for Linux and Windows.
https://bugs.webkit.org/show_bug.cgi?id=90651

  • tests/WebAnimationTest.cpp:

(WebKit):
(WebKit::TEST):

19:50 Changeset [121936] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Multiple Content Security Policy headers are correctly processed as separate headers.
https://bugs.webkit.org/show_bug.cgi?id=90629

Source/WebCore:

Headers of the same name are normalized into a single, comma-separated
string as per RFC2616, section 4.2. We didn't correctly account for this
in ContentSecurityPolicy::didReceiveHeader. Now we do by walking through
the header string, looking for commas and processing each block in turn.

This oversight bit Firefox as well, and was patched in February:
https://bugzilla.mozilla.org/show_bug.cgi?id=717511

Patch by Mike West <mkwst@chromium.org> on 2012-07-05
Reviewed by Adam Barth.

Test: http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::didReceiveHeader):

LayoutTests:

Patch by Mike West <mkwst@chromium.org> on 2012-07-05
Reviewed by Adam Barth.

  • http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/echo-multiple-headers.pl: Added.
18:55 Changeset [121935] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping failing tests.

  • platform/mac/Skipped:
18:47 Changeset [121934] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2][EFL] Ewk_View should provide API to set/get device pixel ratio
https://bugs.webkit.org/show_bug.cgi?id=90590

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Add API to Ewk_View so retrieve and set the device
pixel ratio.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):

  • UIProcess/API/efl/ewk_view.h:
18:27 Changeset [121933] by commit-queue@webkit.org
  • 6 edits in trunk

Unreviewed, rolling out r121921.
http://trac.webkit.org/changeset/121921
https://bugs.webkit.org/show_bug.cgi?id=90648

caused hundreds of crashes on Mac (Requested by pizlo on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-05

Source/WebCore:

  • editing/SurroundingText.cpp:

(WebCore::SurroundingText::SurroundingText):

  • editing/TextIterator.cpp:

(WebCore::CharacterIterator::advance):
(WebCore::BackwardsCharacterIterator::advance):

LayoutTests:

  • platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
  • platform/chromium/editing/surrounding-text/surrounding-text.html:
18:24 Changeset [121932] by andersca@apple.com
  • 4 edits in trunk/Source

Type-ahead doesn't work in options inside optgroups
https://bugs.webkit.org/show_bug.cgi?id=90647
<rdar://problem/5604894>

Reviewed by Dan Bernstein.

Set the title of the menu item to a string that doesn't contain any leading or trailing whitespace.

Source/WebCore:

  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenuMac::populate):

Source/WebKit2:

  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::populate):

18:05 Changeset [121931] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix the build error introduced by enabling CUSTOM_THEME_HANDLER
https://bugs.webkit.org/show_bug.cgi?id=90588

Reviewed by Rob Buis.

Fix the build error introduced by enabling CUSTOM_THEME_HANDLER.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):

17:26 Changeset [121930] by hayato@chromium.org
  • 3 edits
    2 adds in trunk

t/fuzzer-mouse-crash

<patch description>

17:20 Changeset [121929] by benjamin@webkit.org
  • 4 edits
    2 adds in trunk

Double release of resources if the load is canceled in a callback of ResourceLoader::didFinishLoading
https://bugs.webkit.org/show_bug.cgi?id=90431

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-05
Reviewed by Anders Carlsson.

Source/WebCore:

In ResourceLoader::didFinishLoadingOnePart(), we invoke didFinishLoad() on the WebKit client. If WebKit
causes the current frame to cancel the load synchronously, the resources are already freed when
ResourceLoader::didFinishLoadingOnePart() ends.
When ResourceLoader::didFinishLoading() subsequently invokes releaseResources(), we are releasing the
resources a second time.

This patch add a second check for cancellation after invoking ResourceLoader::didFinishLoadingOnePart() to
avoid such issues.

The previous check at the beginning of ResourceLoader::didFinishLoading() has been removed because it is
redundant with ResourceLoader::didFinishLoadingOnePart().

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFinishLoadingOnePart):

Tools:

Add a Mac API test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html: Added.
  • TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm: Added.

(-[CancelLoadFromResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
(-[CancelLoadFromResourceLoadDelegateFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

17:04 Changeset [121928] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSString::tryHashConstLock() fails to get exclusive lock
https://bugs.webkit.org/show_bug.cgi?id=90639

Reviewed by Oliver Hunt.

Added check that the string is already locked even before compare and swap.

  • heap/MarkStack.cpp:

(JSC::JSString::tryHashConstLock):

16:31 Changeset [121927] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

INLINE_ARM_FUNCTION(thingy) should make thingy be thumb2 if we're using thumb2
https://bugs.webkit.org/show_bug.cgi?id=90644

Reviewed by Mark Hahnenberg.

Fix breakage introduced in http://trac.webkit.org/changeset/121885

  • wtf/InlineASM.h:
16:14 Changeset [121926] by simon.fraser@apple.com
  • 4 edits in trunk/Source/WebCore

Add a utility method for hasOverflowClip() or hasClip()
https://bugs.webkit.org/show_bug.cgi?id=90635

Reviewed by Dean Jackson.

Add RenderObject::hasClipOrOverflowClip() as a convenience method

since we end up calling hasOverfFlowClip()
hasClip() a lot in the layer code.

No new tests; refactoring only.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::calculateRects):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::enclosingNonStackingClippingLayer):
(WebCore::RenderLayerCompositor::clipsCompositingDescendants):

  • rendering/RenderObject.h:

(WebCore::RenderObject::hasClipOrOverflowClip):

15:55 Changeset [121925] by fpizlo@apple.com
  • 61 edits
    1 add in trunk/Source/JavaScriptCore

Inline property storage should not be wasted when it is exhausted
https://bugs.webkit.org/show_bug.cgi?id=90347

Reviewed by Gavin Barraclough.

Previously, if we switched an object from using inline storage to out-of-line
storage, we would abandon the inline storage. This would have two main implications:
(i) all accesses to the object, even for properties that were previously in inline
storage, must now take an extra indirection; and (ii) we waste a non-trivial amount
of space since we must allocate additional out-of-line storage to hold properties
that would have fit in the inline storage. There's also the copying cost when
switching to out-of-line storage - we must copy all inline properties into ouf-of-line
storage.

This patch changes the way that object property storage works so that we can use both
inline and out-of-line storage concurrently. This is accomplished by introducing a
new notion of property offset. This PropertyOffset is a 32-bit signed integer and it
behaves as follows:

offset == -1: invalid offset, indicating a property that does not exist.

0 <= offset <= inlineStorageCapacity: offset into inline storage.

inlineStorageCapacity < offset: offset into out-of-line storage.

Because non-final objects don't have inline storage, the only valid PropertyOffsets
for those objects' properties are -1 or > inlineStorageCapacity.

This now means that the decision to use inline or out-of-line storage for an access is
made based on the offset, rather than the structure. It also means that any access
where the offset is a variable must have an extra branch, unless the type of the
object is also known (if it's known to be a non-final object then we can just assert
that the offset is >= inlineStorageCapacity).

This looks like a big Kraken speed-up and a slight V8 speed-up.

(ARMv7Assembler):
(JSC::ARMv7Assembler::ldrWide8BitImmediate):
(JSC::ARMv7Assembler::replaceWithLoad):
(JSC::ARMv7Assembler::replaceWithAddressComputation):

  • assembler/AbstractMacroAssembler.h:

(AbstractMacroAssembler):
(ConvertibleLoadLabel):
(JSC::AbstractMacroAssembler::ConvertibleLoadLabel::ConvertibleLoadLabel):
(JSC::AbstractMacroAssembler::ConvertibleLoadLabel::isSet):
(JSC::AbstractMacroAssembler::labelIgnoringWatchpoints):
(JSC::AbstractMacroAssembler::replaceWithLoad):
(JSC::AbstractMacroAssembler::replaceWithAddressComputation):

  • assembler/CodeLocation.h:

(JSC):
(CodeLocationCommon):
(CodeLocationConvertibleLoad):
(JSC::CodeLocationConvertibleLoad::CodeLocationConvertibleLoad):
(JSC::CodeLocationCommon::convertibleLoadAtOffset):

  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassembly):

  • assembler/LinkBuffer.h:

(LinkBuffer):
(JSC::LinkBuffer::locationOf):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::convertibleLoadPtr):

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::convertibleLoadPtr):
(MacroAssemblerX86):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::convertibleLoadPtr):
(MacroAssemblerX86_64):

  • assembler/RepatchBuffer.h:

(RepatchBuffer):
(JSC::RepatchBuffer::replaceWithLoad):
(JSC::RepatchBuffer::replaceWithAddressComputation):
(JSC::RepatchBuffer::setLoadInstructionIsActive):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::replaceWithLoad):
(X86Assembler):
(JSC::X86Assembler::replaceWithAddressComputation):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::finalizeUnconditionally):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::offset):
(GetByIdStatus):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):

  • bytecode/PutByIdStatus.h:

(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::offset):
(PutByIdStatus):

  • bytecode/ResolveGlobalStatus.cpp:

(JSC):
(JSC::computeForStructure):

  • bytecode/ResolveGlobalStatus.h:

(JSC::ResolveGlobalStatus::ResolveGlobalStatus):
(JSC::ResolveGlobalStatus::offset):
(ResolveGlobalStatus):

  • bytecode/StructureSet.h:

(StructureSet):

  • bytecode/StructureStubInfo.h:
  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(PropertyAccessRecord):

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::tryBuildPutByIdList):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • heap/MarkStack.cpp:

(JSC::visitChildren):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::tryCacheGetByID):
(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::PropertyStubCompilationInfo::copyToStubInfo):

  • jit/JIT.h:

(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JIT):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitAllocateBasicJSObject):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve_global):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_resolve_global):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::emit_op_get_by_pname):

  • jit/JITStubs.cpp:

(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/x86.rb:
  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::functionNameOffset):

  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):
(JSC):
(JSC::JSFinalObject::visitChildren):
(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::getPropertySpecificValue):
(JSC::JSObject::removeDirect):
(JSC::JSObject::growOutOfLineStorage):
(JSC::JSObject::getOwnPropertyDescriptor):

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::getDirect):
(JSC::JSObject::getDirectLocation):
(JSC::JSObject::hasInlineStorage):
(JSC::JSObject::inlineStorageUnsafe):
(JSC::JSObject::inlineStorage):
(JSC::JSObject::outOfLineStorage):
(JSC::JSObject::locationForOffset):
(JSC::JSObject::offsetForLocation):
(JSC::JSObject::getDirectOffset):
(JSC::JSObject::putDirectOffset):
(JSC::JSObject::putUndefinedAtDirectOffset):
(JSC::JSObject::addressOfOutOfLineStorage):
(JSC::JSObject::finishCreation):
(JSC::JSNonFinalObject::JSNonFinalObject):
(JSC::JSNonFinalObject::finishCreation):
(JSFinalObject):
(JSC::JSFinalObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSObject::offsetOfOutOfLineStorage):
(JSC::JSObject::setOutOfLineStorage):
(JSC::JSObject::JSObject):
(JSC):
(JSC::JSCell::fastGetOwnProperty):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::offsetRelativeToPatchedStorage):
(JSC::indexRelativeToBase):
(JSC::offsetRelativeToBase):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::create):

  • runtime/JSPropertyNameIterator.h:

(JSPropertyNameIterator):
(JSC::JSPropertyNameIterator::getOffset):
(JSC::JSPropertyNameIterator::finishCreation):

  • runtime/JSValue.cpp:

(JSC::JSValue::putToPrimitive):

  • runtime/Operations.h:

(JSC::normalizePrototypeChain):

  • runtime/Options.cpp:

(JSC):
(JSC::Options::initialize):

  • runtime/PropertyMapHashTable.h:

(PropertyMapEntry):
(JSC::PropertyMapEntry::PropertyMapEntry):
(PropertyTable):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::getDeletedOffset):
(JSC::PropertyTable::addDeletedOffset):
(JSC::PropertyTable::nextOffset):
(JSC):
(JSC::PropertyTable::sizeInMemory):

  • runtime/PropertyOffset.h: Added.

(JSC):
(JSC::checkOffset):
(JSC::validateOffset):
(JSC::isValidOffset):
(JSC::isInlineOffset):
(JSC::isOutOfLineOffset):
(JSC::offsetInInlineStorage):
(JSC::offsetInOutOfLineStorage):
(JSC::offsetInRespectiveStorage):
(JSC::numberOfOutOfLineSlotsForLastOffset):
(JSC::numberOfSlotsForLastOffset):
(JSC::nextPropertyOffsetFor):
(JSC::firstPropertyOffsetFor):

  • runtime/PropertySlot.h:

(JSC::PropertySlot::cachedOffset):
(JSC::PropertySlot::setValue):
(JSC::PropertySlot::setCacheableGetterSlot):
(JSC::PropertySlot::clearOffset):

  • runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::setExistingProperty):
(JSC::PutPropertySlot::setNewProperty):
(JSC::PutPropertySlot::cachedOffset):
(PutPropertySlot):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::nextOutOfLineStorageCapacity):
(JSC::Structure::growOutOfLineCapacity):
(JSC::Structure::suggestedNewOutOfLineStorageCapacity):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):

  • runtime/Structure.h:

(Structure):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::previousID):
(JSC::Structure::outOfLineCapacity):
(JSC::Structure::outOfLineSizeForKnownFinalObject):
(JSC::Structure::outOfLineSizeForKnownNonFinalObject):
(JSC::Structure::outOfLineSize):
(JSC::Structure::hasInlineStorage):
(JSC::Structure::inlineCapacity):
(JSC::Structure::inlineSizeForKnownFinalObject):
(JSC::Structure::inlineSize):
(JSC::Structure::totalStorageSize):
(JSC::Structure::totalStorageCapacity):
(JSC::Structure::firstValidOffset):
(JSC::Structure::lastValidOffset):
(JSC::Structure::isValidOffset):
(JSC::Structure::isEmpty):
(JSC::Structure::transitionCount):
(JSC::Structure::get):

13:36 Changeset [121924] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSObjectCallAsFunction should thisConvert the provided thisObject
https://bugs.webkit.org/show_bug.cgi?id=90628

Reviewed by Gavin Barraclough.

Perform this conversion on the provided this object.

  • API/JSObjectRef.cpp:

(JSObjectCallAsFunction):

13:19 Changeset [121923] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebCore

Code refactoring: move mimeTypeFromUTITree to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=90619

We should move UTI handling related code to a separate file.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-07-05
Reviewed by David Kilzer.

  • WebCore.xcodeproj/project.pbxproj: Add UTIUtilities.h/UTIUtilities.mm to xcode project, and drive-by fix

that happened when editing the Xcode project file.

  • platform/network/mac/UTIUtilities.h: Added.

(WebCore):

  • platform/network/mac/UTIUtilities.mm: Added. move mimeTypeFromUTITree to UTIUtilities.mm.

(WebCore):
(WebCore::mimeTypeFromUTITree):

  • platform/network/mac/WebCoreURLResponse.mm: include UTIUtilities.h to use mimeTypeFromUTITree.

(WebCore):

13:07 Changeset [121922] by vollick@chromium.org
  • 5 edits
    14 adds in trunk/Source

[chromium] Create a WebKit::Web* wrapper for the cc animation classes
https://bugs.webkit.org/show_bug.cgi?id=90303

Reviewed by James Robinson.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebAnimation.h: Added.

(WebCore):
(WebKit):
(WebAnimation):
(WebKit::WebAnimation::WebAnimation):
(WebKit::WebAnimation::~WebAnimation):

  • chromium/public/WebAnimationCurve.h: Added.

(WebCore):
(WebKit):
(WebAnimationCurve):
(WebKit::WebAnimationCurve::~WebAnimationCurve):
(WebKit::WebAnimationCurve::WebAnimationCurve):

  • chromium/public/WebFloatAnimationCurve.h: Added.

(WebCore):
(WebKit):
(WebFloatAnimationCurve):
(WebKit::WebFloatAnimationCurve::WebFloatAnimationCurve):
(WebKit::WebFloatAnimationCurve::~WebFloatAnimationCurve):

  • chromium/public/WebFloatKeyframe.h: Added.

(WebKit):
(WebKit::WebFloatKeyframe::WebFloatKeyframe):
(WebFloatKeyframe):

  • chromium/public/WebTransformAnimationCurve.h: Added.

(WebCore):
(WebKit):
(WebTransformAnimationCurve):
(WebKit::WebTransformAnimationCurve::WebTransformAnimationCurve):
(WebKit::WebTransformAnimationCurve::~WebTransformAnimationCurve):

  • chromium/public/WebTransformKeyframe.h: Added.

(WebKit):
(WebKit::WebTransformKeyframe::WebTransformKeyframe):
(WebTransformKeyframe):

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
  • src/WebAnimation.cpp: Added.

(WebKit):
(WebKit::WebAnimation::iterations):
(WebKit::WebAnimation::setIterations):
(WebKit::WebAnimation::startTime):
(WebKit::WebAnimation::setStartTime):
(WebKit::WebAnimation::timeOffset):
(WebKit::WebAnimation::setTimeOffset):
(WebKit::WebAnimation::alternatesDirection):
(WebKit::WebAnimation::setAlternatesDirection):
(WebKit::WebAnimation::toCCActiveAnimation):
(WebKit::WebAnimation::initialize):
(WebKit::WebAnimation::destroy):

  • src/WebAnimationCurveCommon.cpp: Added.

(WebKit):
(WebKit::createTimingFunction):

  • src/WebAnimationCurveCommon.h: Added.

(WebCore):
(WebKit):

  • src/WebFloatAnimationCurve.cpp: Added.

(WebKit):
(WebKit::WebFloatAnimationCurve::add):
(WebKit::WebFloatAnimationCurve::toCCAnimationCurve):
(WebKit::WebFloatAnimationCurve::initialize):
(WebKit::WebFloatAnimationCurve::destroy):

  • src/WebTransformAnimationCurve.cpp: Added.

(WebKit):
(WebKit::WebTransformAnimationCurve::add):
(WebKit::WebTransformAnimationCurve::toCCAnimationCurve):
(WebKit::WebTransformAnimationCurve::initialize):
(WebKit::WebTransformAnimationCurve::destroy):

  • tests/WebAnimationTest.cpp: Added.
  • tests/WebFloatAnimationCurveTest.cpp: Added.
  • tests/WebTransformAnimationCurveTest.cpp: Added.
13:03 Changeset [121921] by leandrogracia@chromium.org
  • 6 edits in trunk

Character iterators should not advance if they are at end
https://bugs.webkit.org/show_bug.cgi?id=90560

Reviewed by Ryosuke Niwa.

Source/WebCore:

CharacterIterator and BackwardsCharacterIterator try to advance their
internal TextIterator without checking if they already are at end.
This can cause crashes in TextIterator::advance.

Test: platform/chromium/editing/surrounding-text/surrounding-text.html

  • editing/SurroundingText.cpp:

(WebCore::SurroundingText::SurroundingText):

  • editing/TextIterator.cpp:

(WebCore::CharacterIterator::advance):
(WebCore::BackwardsCharacterIterator::advance):

LayoutTests:

Add a new test case where character iterators are already at end when
trying to advance. This was caught by Chromium's address sanitizer
here: http://code.google.com/p/chromium/issues/detail?id=135705

  • platform/chromium/editing/surrounding-text/surrounding-text-expected.txt:
  • platform/chromium/editing/surrounding-text/surrounding-text.html:
12:57 Changeset [121920] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Text Autosizing: Add basic framework
https://bugs.webkit.org/show_bug.cgi?id=88655

Follow-up patch tweaking method signatures.

Patch by John Mellor <johnme@chromium.org> on 2012-07-05
Reviewed by Simon Fraser.

No functional change, so no new tests.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processBlock):
(WebCore::TextAutosizer::processText):
(WebCore):

  • rendering/TextAutosizer.h:

(TextAutosizer):

12:49 Changeset [121919] by commit-queue@webkit.org
  • 6 edits
    2 copies in trunk/Source/WebKit2

[WK2] Add C API for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=90545

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-05
Reviewed by Anders Carlsson.

Add C API for WKBatteryManager and WKBatteryStatus
so that clients can support the Battery Status API
in WebKit2.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • UIProcess/API/C/WKBatteryManager.cpp:

(WKBatteryManagerProviderDidChangeBatteryStatus):
(WKBatteryManagerProviderUpdateBatteryStatus):

  • UIProcess/API/C/WKBatteryStatus.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp.

(WKBatteryStatusGetTypeID):
(WKBatteryStatusCreate):

  • UIProcess/API/C/WKBatteryStatus.h: Copied from Source/WebKit2/UIProcess/API/C/WKBatteryManager.cpp.
12:44 Changeset [121918] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: move cursor to the current search match.
https://bugs.webkit.org/show_bug.cgi?id=90621

Reviewed by Vsevolod Vlasov.

After closing the search dialog, the cursor should be at the latest search match location.

  • inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.markAndRevealRange):
(WebInspector.TextEditor.prototype._handleFocused):

11:20 Changeset [121917] by commit-queue@webkit.org
  • 11 edits
    4 adds in trunk

Subpixel layout broken with spans with CSS position other than static
https://bugs.webkit.org/show_bug.cgi?id=90097

Patch by Behdad Esfahbod <behdad@behdad.org> on 2012-07-05
Reviewed by Eric Seidel.

In InlineBox, don't truncate size to integers when returning.

In RenderBlock, don't round-up width to next integer. Round-up to
next LayoutUnit instead.

Test: Added fast/sub-pixel/size-of-span-with-different-positions.html
Adjust expected outputs affected by the rounding changes.

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::fromFloatCeil):
(FractionalLayoutUnit):

  • rendering/InlineBox.h:

(WebCore::InlineBox::size):

  • rendering/RenderBlock.cpp:

(WebCore::updatePreferredWidth):

11:01 Changeset [121916] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r121899.
http://trac.webkit.org/changeset/121899
https://bugs.webkit.org/show_bug.cgi?id=90623

Unauthorized WK2 API breakage (Requested by andersca on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-05

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toCopiedURLAPI):

10:54 Changeset [121915] by dtharp@codeaurora.org
  • 2 edits in trunk/Tools

Adding myself as committer to committers.py

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
10:46 Changeset [121914] by rwlbuis@webkit.org
  • 3 edits in trunk

[CMake] Fix some CMake warnings
https://bugs.webkit.org/show_bug.cgi?id=90558

Fix WebKit options so they match with FeatureList.pm.

Reviewed by Dan Bates.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
10:37 Changeset [121913] by ap@apple.com
  • 8 edits in trunk

[Mac][WK2] Enable HTTPS tests
https://bugs.webkit.org/show_bug.cgi?id=90600

Reviewed by Brady Eidson.

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed a misleading comment.

It explained why we were doing this here instead of a frame load delegate, but that's
just history, not an explanation of why we need this code.

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):

Ignore certificate errors for localhost and 127.0.0.1. Since this is only needed
for tests, it seems appropriate to have platform specific solutions in every WTR,
and not add a WebKit2 API.

LayoutTests:

Unskip in common wk2 skipped file, re-skip everywhere besides Mac.

  • platform/gtk-wk2/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/win-wk2/Skipped:
  • platform/wk2/Skipped:
10:19 Changeset [121912] by japhet@chromium.org
  • 4 edits
    2 adds in trunk

Source/WebCore: REGRESSION (r115654): Sometimes does not replace content for multipart/x-mixed-replace
https://bugs.webkit.org/show_bug.cgi?id=88436

Reviewed by Brady Eidson.

Test: http/tests/multipart/multipart-replace-non-html-content.php

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData): We should only send receivedFirstData() once per main resource load,

rather than multiple times in a multipart load.

(WebCore::DocumentLoader::setupForReplaceByMIMEType): m_gotFirstByte isn't set to true until data is

actually committed, and multipart data is often not committed until the part is finished. Check
whether the SharedBuffer is non-null instead.

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject): The JSInternals object my have already been cleared if the window shell

was cleared as part of creation of a new Document. Check it before using it.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=88436.

Reviewed by Brady Eidson.

  • http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
  • http/tests/multipart/multipart-replace-non-html-content.php: Added.
09:44 Changeset [121911] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: move search field to the bottom of the page.
https://bugs.webkit.org/show_bug.cgi?id=90610

Reviewed by Vsevolod Vlasov.

This is the first step in the Search/replace implementation. This change moves search
field from the inspector toolbar to the inspector view footer that is visible upon Cmd/Ctrl+F.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/InspectorView.js:

(WebInspector.InspectorView):
(WebInspector.InspectorView.prototype._pushToHistory):
(WebInspector.InspectorView.prototype.panelsElement):
(WebInspector.InspectorView.prototype.setFooterElement):

  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.show):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reset):

  • inspector/front-end/SearchController.js:

(WebInspector.SearchController):
(WebInspector.SearchController.prototype.updateSearchLabel):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype.focusSearchField):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):

  • inspector/front-end/inspector.css:

(#search):
(.toolbar-search-container):
(.toolbar-search-navigation):
(.toolbar-search-navigation:hover):
(.toolbar-search-navigation.toolbar-search-navigation-prev):
(.toolbar-search-navigation.toolbar-search-navigation-next):
(.toolbar-search-navigation-hidden):
(.status-bar):
(.search-drawer-header input[type="search"].search-config-search):
(.inspector-footer):
(.inspector-footer > div):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.get _setCompactMode):
(WebInspector.postDocumentKeyDown):

09:39 Changeset [121910] by vestbo@webkit.org
  • 2 edits in trunk

[Qt] Move Webkit1 before WebKit2 in the build order

Reviewed by Csaba Osztrogonác.

  • WebKit.pro:
09:27 WebKit Team edited by dtharp@codeaurora.org
(diff)
09:21 Changeset [121909] by scheib@chromium.org
  • 3 edits
    2 adds in trunk

[Chromium] Clear m_currentInputEvent after handled by pointerLockMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=90391

Source/WebKit/chromium:

WebViewImpl::handleInputEvent was keeping a pointer to an input event that would
later be accessed. When in pointer lock, that pointer was not being cleared.
Code modified to use TemporaryChange to automatically clear the pointer at all
method exit points.

Reviewed by Abhishek Arya.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleInputEvent):

LayoutTests:

Test that reproduces bug 90391:
Enable pointer lock, receive mouse move, call window.open, don't crash.

Reviewed by Abhishek Arya.

  • pointer-lock/bug90391-move-then-window-open-crash-expected.txt: Added.
  • pointer-lock/bug90391-move-then-window-open-crash.html: Added.
09:13 Changeset [121908] by caseq@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: added low-level instrumentation support for TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90264

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-07-05
Reviewed by Pavel Feldman.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::timelineAgentForOrphanEvents):
(WebCore::InspectorInstrumentation::setTimelineAgentForOrphanEvents):
(WebCore::InspectorInstrumentation::threadSpecificTimelineAgentForOrphanEvents):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

08:38 Changeset [121907] by commit-queue@webkit.org
  • 17 edits
    3 adds in trunk

Text Autosizing: Add test framework and simple test.
https://bugs.webkit.org/show_bug.cgi?id=90561

Source/WebCore:

Exposes methods allowing Layout Tests to enable Text Autosizing and
get the same results as if they were running on a mobile device.

Patch by John Mellor <johnme@chromium.org> on 2012-07-05
Reviewed by Adam Barth.

Test: fast/text-autosizing/simple-paragraph.html

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore):
(WebCore::Settings::setTextAutosizingWindowSizeOverride):

  • page/Settings.h:

(Settings):
(WebCore::Settings::textAutosizingWindowSizeOverride):

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::boostSubtree):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setTextAutosizingEnabled):
(WebCore):
(WebCore::InternalSettings::setTextAutosizingWindowSizeOverride):

  • testing/InternalSettings.h:

(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit/chromium:

ENABLE(TEXT_AUTOSIZING) is now on in Chromium (but disabled at runtime).
This allows it to be used in Layout Tests (and in future by Web
Inspector's mobile device emulation).

Patch by John Mellor <johnme@chromium.org> on 2012-07-05
Reviewed by Adam Barth.

  • features.gypi:

LayoutTests:

Added a RefTest checking that Text Autosizing is active.
Skipped the text-autosizing test directory on platforms that
currently disable ENABLE(TEXT_AUTOSIZING).

Patch by John Mellor <johnme@chromium.org> on 2012-07-05
Reviewed by Adam Barth.

  • fast/text-autosizing/simple-paragraph-expected.html: Added.
  • fast/text-autosizing/simple-paragraph.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
08:27 Changeset [121906] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: timeline events in the vicinity of event dividers some times are tricky to expand
https://bugs.webkit.org/show_bug.cgi?id=90572

Reviewed by Pavel Feldman.

  • do not use resources-event-divider-padding;
  • make dividers larger and use border-color to visualize them;
  • move resources-<color>-divider to timelinePanel.css, as they're not used outside of timeline;
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.createEventDivider):

  • inspector/front-end/inspectorCommon.css:
  • inspector/front-end/timelinePanel.css:

(.timeline .resources-event-divider):
(.resources-red-divider):
(.resources-blue-divider):
(.resources-orange-divider):
(.resources-divider.last):
(.timeline .resources-event-divider.timeline-frame-divider):

08:17 Changeset [121905] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: incorrect height of main timeline pane after switching to memory mode
https://bugs.webkit.org/show_bug.cgi?id=90387

Reviewed by Pavel Feldman.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._splitterDragging):
(WebInspector.TimelinePanel.prototype.set _setSplitterPosition):
(WebInspector.TimelinePanel.prototype._overviewModeChanged):

07:23 Changeset [121904] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebKit/chromium

[chromium] Add a method didChangeFormState to WebViewClient.
https://bugs.webkit.org/show_bug.cgi?id=90563

Patch by Oli Lan <olilan@chromium.org> on 2012-07-05
Reviewed by Adam Barth.

This patch adds a new method didChangeFormState to WebViewClient,
and calls it from ChromeClientImpl::formStateDidChange with the changed node.

This new method can be used for example by the Android port to update the browser's
IME when the state of the currently focused text node has changed. To facilitate this
usage, a focused() method has been added to WebNode.

A new test has been added to WebViewTest. This test checks that didChangeFormState
is called when an input's value is changed, and also checks that WebNode::focused() returns
the correct value for the provided node, in both the focused and non-focused cases.

  • public/WebNode.h:
  • public/WebViewClient.h:

(WebKit::WebViewClient::didChangeFormState):

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::formStateDidChange):

  • src/WebNode.cpp:

(WebKit::WebNode::focused):
(WebKit):

  • tests/WebViewTest.cpp:

(FormChangeWebViewClient):
(WebKit::FormChangeWebViewClient::didChangeFormState):
(WebKit::FormChangeWebViewClient::reset):
(WebKit::FormChangeWebViewClient::called):
(WebKit::FormChangeWebViewClient::focused):
(WebKit):
(WebKit::TEST_F):

  • tests/data/input_field_set_value_while_focused.html: Added.
  • tests/data/input_field_set_value_while_not_focused.html: Added.
07:20 Changeset [121903] by ryuan.choi@samsung.com
  • 2 edits in trunk

[CMAKE] Unreviewd typo fix after r121857

  • Source/cmake/WebKitMacros.cmake:
07:19 Changeset [121902] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Add support for keyboard increment / decrement on numbers in attributes in Elements Panel
https://bugs.webkit.org/show_bug.cgi?id=89586

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-05
Reviewed by Pavel Feldman

Refactoring the key events while editing style property values. Migrated the code to UIUtils.js and referred
from StylesSidebarPane.js, ElementsTreeOutline.js and MetricsSidebarPane.js.

No new tests as code refactoring and UI feature added to ElementsTreeOutline.js

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._startEditingAttribute.handleKeyDownEvents):
(WebInspector.ElementsTreeElement.prototype._startEditingAttribute):

  • inspector/front-end/MetricsSidebarPane.js:

(WebInspector.MetricsSidebarPane.prototype._handleKeyDown.finishHandler):
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown.customNumberHandler):
(WebInspector.MetricsSidebarPane.prototype._handleKeyDown):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._handleNameOrValueUpDown.finishHandler):
(WebInspector.StylesSidebarPane.prototype._handleNameOrValueUpDown):

  • inspector/front-end/UIUtils.js:

(WebInspector._modifiedHexValue):
(WebInspector._modifiedFloatNumber):
(WebInspector.handleElementValueModifications):

06:10 Changeset [121901] by vestbo@webkit.org
  • 3 edits in trunk/Tools

[Qt] Remove rpath-hacks in qt_webkit.pri

Having it in qt_webkit.pri meant that all client apps would inherit the rpath,
even if they were not using QtWebKit.

This is a regression for people who build client apps against a non-installed
QtWebKit, as the client app will be missing a rpath to the standalone WebKit
build dir. This can be solved by LD_LIBRARY_PATH or custom QMAKE_RPATHDIR
logic, until the real issue is fixed in Qt.

Reviewed by Csaba Osztrogonác.

05:31 Changeset [121900] by rgabor@webkit.org
  • 10 edits
    1 add
    1 delete in trunk/Source/WebCore

NEON intrinsics should be used with gaussian blur filter
https://bugs.webkit.org/show_bug.cgi?id=90166

Reviewed by Zoltan Herczeg.

Rewrite inline assembly to NEON intrinsics for better portabilty
and readibility. Remove unnecessary FEGaussianBlurNEON.cpp and add
NEONHelpers.h to the project which will contains the shared
NEON code of the filters.

Existing tests cover this issue.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApplyWorker):

  • platform/graphics/filters/FEGaussianBlur.h:

(FEGaussianBlur):

  • platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Removed.
  • platform/graphics/filters/arm/FEGaussianBlurNEON.h:

(WebCore::boxBlurNEON):

  • platform/graphics/filters/arm/NEONHelpers.h: Added.

(WebCore):
(WebCore::loadRGBA8AsFloat):
(WebCore::storeFloatAsRGBA8):

04:21 Changeset [121899] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] WTR crashes if a URL is passed as a parameter
https://bugs.webkit.org/show_bug.cgi?id=88093

Reviewed by Zoltan Herczeg.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toCopiedURLAPI):
Don't special case null string. It's handled
fine by WebURL and passing 0 is not suitable
to the API.

03:54 Changeset [121898] by commit-queue@webkit.org
  • 4 edits
    2 moves in trunk/Source/WebKit

[EFL] Change class name from NotificationClientEfl to NotificationPresenterClientEfl.
https://bugs.webkit.org/show_bug.cgi?id=90542

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit:

NotificationClientEfl.cpp is changed to NotificationPresenterClientEfl.cpp
to be in line with other ports(qt, chromium, gtk).

  • PlatformEfl.cmake:

Source/WebKit/efl:

Change class name from NotificationClientEfl to NotificationPresenterClientEfl
to be in line with other ports.(qt, chromium, blackberry)

  • WebCoreSupport/ChromeClientEfl.cpp:
  • WebCoreSupport/NotificationPresenterClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.cpp.

(WebCore):
(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::~NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::show):
(WebCore::NotificationPresenterClientEfl::cancel):
(WebCore::NotificationPresenterClientEfl::notificationObjectDestroyed):
(WebCore::NotificationPresenterClientEfl::notificationControllerDestroyed):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):

  • WebCoreSupport/NotificationPresenterClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/NotificationClientEfl.h.

(WebCore):
(NotificationPresenterClientEfl):

03:52 Changeset [121897] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk

[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
https://bugs.webkit.org/show_bug.cgi?id=88608

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-05
Reviewed by Hajime Morita.

.:

  • Source/cmake/OptionsEfl.cmake: Enable the CUSTOM_SCHEME_HANDLER feature as default.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebKit::WebChromeClient::isProtocolHandlerRegistered): Add a stub function.
(WebKit::WebChromeClient::unregisterProtocolHandler): Add a stub function.
(WebChromeClient):

Tools:

  • Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.

LayoutTests:

  • platform/efl/fast/dom/unregister-protocol-handler-expected.txt: Expected result of the EFL port.
03:33 Changeset [121896] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Having a "Scroll into view" for nodes through web inspector.
https://bugs.webkit.org/show_bug.cgi?id=89554

Added options for scrolling-into-view the element node through web
inspector.

Patch by Sam D <dsam2912@gmail.com> on 2012-07-05
Reviewed by Pavel Feldman.

No new tests. UI change.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(.):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.callFunction):

02:34 Changeset [121895] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

Add Gamepad logging channel
https://bugs.webkit.org/show_bug.cgi?id=90570

Reviewed by Carlos Garcia Campos.

Add a new logging channel for logging significant
events that are related to Gamepad API implementation.

No new tests - no new testable functionality.

  • platform/Logging.cpp:

(WebCore):
(WebCore::getChannelFromName):

  • platform/Logging.h:

(WebCore):

  • platform/gtk/GamepadsGtk.cpp: Log when a device is

registered or unregistered.
(WebCore::GamepadsGtk::registerDevice):
(WebCore::GamepadsGtk::unregisterDevice):

02:22 Changeset [121894] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r121891.

  • platform/qt/Skipped:
01:47 Changeset [121893] by ryuan.choi@samsung.com
  • 13 edits
    10 adds in trunk

[Wk2][EFL] EFL needs a WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=87659

Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/CMakeLists.txt:

Set compiler flags for WebCoreTestSupport to be linked into TestRunnerInjectedBundle
shared library.

  • Source/cmake/WebKitMacros.cmake: Remove unnecessary dependency.

Source/WebKit2:

  • PlatformEfl.cmake: Added WKImageCairo.cpp in source list.

Tools:

Add an implementation of WebKitTestRunner for Efl port.

  • CMakeLists.txt: Includes WebKitTestRunner build script.
  • Scripts/build-webkittestrunner: Added knowledge of WebKitTestRunner/Efl.
  • Scripts/webkitpy/layout_tests/port/efl.py: Ditto.

(EflPort.setup_environ_for_server):

  • WebKitTestRunner/CMakeLists.txt: Added.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Added.
  • WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Added.
  • WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Added.
  • WebKitTestRunner/PlatformEfl.cmake: Added.
  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestController.cpp:
  • WebKitTestRunner/config.h: Added knowledge of WebKitTestRunner/Efl.
  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Added.
  • WebKitTestRunner/efl/TestControllerEfl.cpp: Added.
  • WebKitTestRunner/efl/main.cpp: Added.

(main):

01:36 Changeset [121892] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Add ewk_view_reload_bypass_cache API.
https://bugs.webkit.org/show_bug.cgi?id=89413

Patch by Hyerim Bae <hyerim.bae@samsung.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Add API, which is for reloading documents without cache.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_reload_bypass_cache):

  • UIProcess/API/efl/ewk_view.h:
01:19 Changeset [121891] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [JSC] support JS execution in the context of an isolated world
https://bugs.webkit.org/show_bug.cgi?id=85709

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-07-05
Reviewed by Gavin Barraclough.

No new test case for this bug.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::collectIsolatedContexts):
(WebCore):

01:14 Changeset [121890] by commit-queue@webkit.org
  • 5 edits in trunk

[WK2][EFL] Ewk_View needs API to load HTML data
https://bugs.webkit.org/show_bug.cgi?id=90540

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add method to Ewk_View to load provided HTML data.
This is used for e.g. when an URL cannot be reached
and we need to display an error page.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_html_load):

  • UIProcess/API/efl/ewk_view.h:

Tools:

Update EFL MiniBrowser to catch the "load,error" signal
on the view and display an error page.

  • MiniBrowser/efl/main.c:

(on_error):
(browserCreate):

00:59 Changeset [121889] by commit-queue@webkit.org
  • 6 edits
    8 adds in trunk/Source/WebKit2

[WK2][EFL] Ewk_View needs to report new resource requests
https://bugs.webkit.org/show_bug.cgi?id=90577

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Add new "resource,request,new" signal to Ewk_View to
notify clients of the resource requests being initiated.
New Ewk_Url_Request and Ewk_Web_Resource types are
introduced in order to provide the clients with the
needed information regarding the resource requests.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_url_request.cpp: Added.

(_Ewk_Url_Request):
(ewk_url_request_ref):
(ewk_url_request_unref):
(ewk_url_request_url_get):
(ewk_request_first_party_get):
(ewk_url_request_http_method_get):
(ewk_url_request_new):

  • UIProcess/API/efl/ewk_url_request.h: Added.
  • UIProcess/API/efl/ewk_url_request_private.h: Added.
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):
(ewk_view_resource_load_initiated):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp: Added.

(didInitiateLoadForResource):
(ewk_view_resource_load_client_attach):

  • UIProcess/API/efl/ewk_view_resource_load_client_private.h: Added.
  • UIProcess/API/efl/ewk_web_resource.cpp: Added.

(_Ewk_Web_Resource):
(ewk_web_resource_ref):
(ewk_web_resource_unref):
(ewk_web_resource_uri_get):
(ewk_web_resource_new):
(ewk_web_resource_main_get):

  • UIProcess/API/efl/ewk_web_resource.h: Added.
  • UIProcess/API/efl/ewk_web_resource_private.h: Added.
00:58 Changeset [121888] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, marking a test as a flaky crasher after r121869.

  • platform/gtk/TestExpectations:
00:53 Changeset [121887] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Unreviewed buildfix after r121886. Typo fix.

  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):

00:24 Changeset [121886] by sergio@webkit.org
  • 2 edits in trunk/Tools

Hidden dirs are not copied when creating the built product archive
https://bugs.webkit.org/show_bug.cgi?id=90559

Reviewed by Carlos Garcia Campos.

Hidden dirs are not copied inside the built product archive
because the recursive copy command was ignoring them. We need those
hidden directories for the GTK WebKit2 testing bot to work fine.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct): replaced "*" by "." to include hidden
dirs/files.

00:04 Changeset [121885] by zherczeg@webkit.org
  • 19 edits in trunk/Source

Port DFG JIT to traditional ARM
https://bugs.webkit.org/show_bug.cgi?id=90198

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch contains the macro assembler part of the
DFG JIT support on ARM systems with fixed 32 bit instruction
width. A large amount of old code was refactored, and the ARMv4
or lower support is removed from the macro assembler.

Sunspider is improved by 8%, and V8 is 92%.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::dataTransfer32):
(JSC::ARMAssembler::baseIndexTransfer32):
(JSC):
(JSC::ARMAssembler::dataTransfer16):
(JSC::ARMAssembler::baseIndexTransfer16):
(JSC::ARMAssembler::dataTransferFloat):
(JSC::ARMAssembler::baseIndexTransferFloat):
(JSC::ARMAssembler::executableCopy):

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::ARMAssembler):
(JSC::ARMAssembler::emitInst):
(JSC::ARMAssembler::vmov_f64_r):
(ARMAssembler):
(JSC::ARMAssembler::vabs_f64_r):
(JSC::ARMAssembler::vneg_f64_r):
(JSC::ARMAssembler::ldr_imm):
(JSC::ARMAssembler::ldr_un_imm):
(JSC::ARMAssembler::dtr_u):
(JSC::ARMAssembler::dtr_ur):
(JSC::ARMAssembler::dtr_d):
(JSC::ARMAssembler::dtr_dr):
(JSC::ARMAssembler::dtrh_u):
(JSC::ARMAssembler::dtrh_ur):
(JSC::ARMAssembler::dtrh_d):
(JSC::ARMAssembler::dtrh_dr):
(JSC::ARMAssembler::fdtr_u):
(JSC::ARMAssembler::fdtr_d):
(JSC::ARMAssembler::push_r):
(JSC::ARMAssembler::pop_r):
(JSC::ARMAssembler::poke_r):
(JSC::ARMAssembler::peek_r):
(JSC::ARMAssembler::vmov_vfp64_r):
(JSC::ARMAssembler::vmov_arm64_r):
(JSC::ARMAssembler::vmov_vfp32_r):
(JSC::ARMAssembler::vmov_arm32_r):
(JSC::ARMAssembler::vcvt_u32_f64_r):
(JSC::ARMAssembler::vcvt_f64_f32_r):
(JSC::ARMAssembler::vcvt_f32_f64_r):
(JSC::ARMAssembler::clz_r):
(JSC::ARMAssembler::bkpt):
(JSC::ARMAssembler::bx):
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::labelIgnoringWatchpoints):
(JSC::ARMAssembler::labelForWatchpoint):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::getLdrImmAddress):
(JSC::ARMAssembler::replaceWithJump):
(JSC::ARMAssembler::maxJumpReplacementSize):
(JSC::ARMAssembler::getOp2Byte):
(JSC::ARMAssembler::getOp2Half):
(JSC::ARMAssembler::RM):
(JSC::ARMAssembler::RS):
(JSC::ARMAssembler::RD):
(JSC::ARMAssembler::RN):

  • assembler/AssemblerBufferWithConstantPool.h:

(JSC::AssemblerBufferWithConstantPool::ensureSpaceForAnyInstruction):

  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::add32):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::and32):
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::mul32):
(JSC::MacroAssemblerARM::neg32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::xor32):
(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::load8Signed):
(JSC::MacroAssemblerARM::load16):
(JSC::MacroAssemblerARM::load16Signed):
(JSC::MacroAssemblerARM::load32):
(JSC::MacroAssemblerARM::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::store32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::store8):
(JSC::MacroAssemblerARM::store16):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::jump):
(JSC::MacroAssemblerARM::branchAdd32):
(JSC::MacroAssemblerARM::mull32):
(JSC::MacroAssemblerARM::branchMul32):
(JSC::MacroAssemblerARM::nearCall):
(JSC::MacroAssemblerARM::compare32):
(JSC::MacroAssemblerARM::test32):
(JSC::MacroAssemblerARM::sub32):
(JSC::MacroAssemblerARM::call):
(JSC::MacroAssemblerARM::loadFloat):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::storeFloat):
(JSC::MacroAssemblerARM::storeDouble):
(JSC::MacroAssemblerARM::moveDouble):
(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::absDouble):
(JSC::MacroAssemblerARM::negateDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::convertFloatToDouble):
(JSC::MacroAssemblerARM::convertDoubleToFloat):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerARM::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerARM::truncateDoubleToInt32):
(JSC::MacroAssemblerARM::truncateDoubleToUint32):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
(JSC::MacroAssemblerARM::branchDoubleNonZero):
(JSC::MacroAssemblerARM::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerARM::invert):
(JSC::MacroAssemblerARM::replaceWithJump):
(JSC::MacroAssemblerARM::maxJumpReplacementSize):
(JSC::MacroAssemblerARM::call32):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::label):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):

  • dfg/DFGCCallHelpers.h:

(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArguments):

  • dfg/DFGFPRInfo.h:

(DFG):

  • dfg/DFGGPRInfo.h:

(DFG):
(GPRInfo):

  • dfg/DFGOperations.cpp:

(JSC):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):

  • jit/JITStubs.cpp:

(JSC):

  • jit/JITStubs.h:

(JITStackFrame):

  • jit/JSInterfaceJIT.h:

(JSInterfaceJIT):

Source/WTF:

Enabling DFG JIT on ARM systems with 32 bit instruction set.

  • wtf/InlineASM.h:
  • wtf/Platform.h:
Note: See TracTimeline for information about the timeline view.