Timeline


and

07/24/12:

23:52 Changeset [123581] by kseo@webkit.org

Remove anonymous namespace and make functions static.
https://bugs.webkit.org/show_bug.cgi?id=92214

Reviewed by Adam Barth.

Mark functions as static instead of enclosing them in anonymous namespaces.
One exception to this rule is when a function is passed as a template argument.
In this case, the function must have an external linkage.

No functional change. Covered by existing tests.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::hasImpliedEndTag):
(WebCore::causesFosterParenting):
(WebCore::isAllWhitespace):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore):
(WebCore::tokenizerStateForContextElement):

  • html/parser/HTMLElementStack.cpp:

(WebCore::isNumberedHeaderElement):
(WebCore::isRootNode):
(WebCore):

  • html/parser/HTMLEntityParser.cpp:

(WebCore::isAlphaNumeric):

  • html/parser/HTMLEntitySearch.cpp:

(WebCore::halfway):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::toLowerCase):
(WebCore::vectorEqualsString):
(WebCore::isEndTagBufferingState):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore):
(WebCore::uninitializedPositionValue1):
(WebCore::isAllWhitespace):
(WebCore::isAllWhitespaceOrReplacementCharacters):
(WebCore::isNumberedHeaderTag):
(WebCore::isCaptionColOrColgroupTag):
(WebCore::isTableCellContextTag):
(WebCore::isTableBodyContextTag):
(WebCore::isSpecialNode):
(WebCore::isNonAnchorNonNobrFormattingTag):
(WebCore::isNonAnchorFormattingTag):
(WebCore::isFormattingTag):
(WebCore::closestFormAncestor):
(WebCore::mapLoweredLocalNameToName):
(WebCore::adjustSVGTagNameCase):
(WebCore::adjustAttributes):
(WebCore::adjustSVGAttributes):
(WebCore::adjustMathMLAttributes):
(WebCore::addNamesWithPrefix):
(WebCore::adjustForeignAttributes):

23:40 Changeset [123580] by abarth@webkit.org

The EWS bots get flaky when we hit the failure limit
https://bugs.webkit.org/show_bug.cgi?id=92212

Reviewed by Eric Seidel.

Previously we were missing some failure types, which means we didn't
notice that the bots were hitting the failure limit.

  • Scripts/webkitpy/common/net/layouttestresults.py:

(LayoutTestResults.failing_test_results):

  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:

(LayoutTestResultsTest.test_results_from_string):
(LayoutTestResultsTest.test_tests_matching_failure_types):

23:01 Changeset [123579] by vsevik@chromium.org

Unreviewed r123494 follow-up: fixed inspector undock icon.

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
22:53 Changeset [123578] by yosin@chromium.org

[Tests] Copy fast/forms/number/number-spinbutton-change-and-input-events.html to fast/forms/js/resources
https://bugs.webkit.org/show_bug.cgi?id=92209

Reviewed by Kent Tamura.

This patch copies test file fast/forms/number/number-spinbutton-change-and-input-events.html
to JavaScript code directory fast/forms/resources as common-spinbutton-change-and-input-events.js
for sharing code with other input types.

This patch is preparation of re-factoring.

  • fast/forms/resources/common-spinbutton-change-and-input-events.js: Copied from LayoutTests/fast/forms/number/number-spinbutton-change-and-input-events.html.
22:47 Changeset [123577] by kseo@webkit.org

Read tag names and attributes from the saved tokens where possible.
https://bugs.webkit.org/show_bug.cgi?id=92079

Reviewed by Adam Barth.

Read tag names and attributes from the saved tokens, not from the DOM.
Also added convenient methods such as hasLocalName, hasTagName, localName,
isElementNode and isDocumentFragmentNode to HTMLStackItem class.

No new tests, covered by existing tests.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLNames::hasImpliedEndTag):
(WebCore::HTMLNames::causesFosterParenting):
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
(WebCore::HTMLConstructionSite::generateImpliedEndTags):
(WebCore::HTMLConstructionSite::shouldFosterParent):

  • html/parser/HTMLConstructionSite.h:

(WebCore::HTMLConstructionSite::currentStackItem):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isNumberedHeaderElement):
(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isListItemScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
(WebCore::HTMLNames::isTableBodyScopeMarker):
(WebCore::HTMLNames::isTableRowScopeMarker):
(WebCore::HTMLNames::isForeignContentScopeMarker):
(WebCore::HTMLNames::isButtonScopeMarker):
(WebCore::HTMLNames::isSelectScopeMarker):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
(WebCore::HTMLElementStack::popUntilTableScopeMarker):
(WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
(WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
(WebCore::HTMLElementStack::isMathMLTextIntegrationPoint):
(WebCore::HTMLElementStack::isHTMLIntegrationPoint):
(WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
(WebCore::HTMLElementStack::pushRootNode):
(WebCore::HTMLElementStack::oneBelowTop):
(WebCore::HTMLElementStack::topmost):
(WebCore):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
(WebCore::HTMLElementStack::inScope):

  • html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::topStackItem):
(HTMLElementStack):
(WebCore::isInHTMLNamespace):

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::isDocumentFragmentNode):
(WebCore::HTMLStackItem::isElementNode):
(HTMLStackItem):
(WebCore::HTMLStackItem::hasLocalName):
(WebCore::HTMLStackItem::hasTagName):
(WebCore::HTMLStackItem::HTMLStackItem):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore):
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

  • html/parser/HTMLTreeBuilder.h:
22:28 Changeset [123576] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

  • DEPS:
22:18 Changeset [123575] by yosin@chromium.org

[Tests] Rename fast/number/number-events.html to number-spinbutton-change-and-input-events.html
https://bugs.webkit.org/show_bug.cgi?id=92208

Reviewed by Kent Tamura.

This patch renames fast/forms/number/number-events.html to number-spinbutton-change-and-input-events.html
to make file name explains what test will be done.

  • fast/forms/number/number-events-expected.txt: Removed.
  • fast/forms/number/number-events.html: Removed.
  • fast/forms/number/number-spinbutton-change-and-input-events-expected.txt: Copied from LayoutTests/fast/forms/number/number-events-expected.txt.
  • fast/forms/number/number-spinbutton-change-and-input-events.html: Copied from LayoutTests/fast/forms/number/number-events.html.
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
22:04 Changeset [123574] by commit-queue@webkit.org

[chromium] Move renderingStats from WebView to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=92184

Patch by Dave Tu <dtu@chromium.org> on 2012-07-24
Reviewed by Adam Barth.

We are going to add some rendering stats that work in non-composited mode, so the renderingStats() method should be moved from WebView to WebWidget.

  • public/WebView.h:

(WebKit):
(WebView):

  • public/WebWidget.h:

(WebKit):
(WebWidget):
(WebKit::WebWidget::renderingStats):

  • src/WebViewImpl.h:

(WebViewImpl):

22:00 Changeset [123573] by yosin@chromium.org

[Tests] Remove duplicated fast/forms/number/number-spinbutton-events.html
https://bugs.webkit.org/show_bug.cgi?id=92205

Reviewed by Kent Tamura.

This patch removes fast/forms/number/number-spinbutton-events.html
because fast/forms/number/number-events.html covers and checked more.

r108955 is an evidence of coverage.

  • fast/forms/number/number-spinbutton-events-expected.txt: Removed.
  • fast/forms/number/number-spinbutton-events.html: Removed.
  • platform/efl/Skipped:
  • platform/qt-arm/TestExpectations:
  • platform/win/Skipped:
21:51 Changeset [123572] by hbono@chromium.org

Avoid moving child objects multiple times when vertical scrollbar are shown at the left side.
https://bugs.webkit.org/show_bug.cgi?id=91756

Reviewed by Tony Chang.

Source/WebCore:

My r123067 moves the top-left origin of an RTL element right when its vertical
scrollbar is shown at its left side. (That is, r123067 moves all child objects
in the RTL element right.) This change also increases RenderBox::clientLeft()
at the same time, i.e. it also moves child objects right. Furthermore, my r109512
moves positioned objects in an RTL element right at the same time. This makes
WebKit move objects in an RTL element up to three times by the scrollbar width.
(Moving an absolute object right increases the scrollWidth value and it causes
this bug.) This change removes unnecessary code that moves objects right in my
r109512 and RenderBox::clientLeft().

Test: scrollbars/rtl/div-absolute.html

fast/block/float/026.html
fast/block/float/028.html
fast/overflow/unreachable-overflow-rtl-bug.html

  • dom/Element.cpp:

(WebCore::Element::clientLeft): Increase clientLeft value by the width of a vertical scrollbar as written in the CSSOM specification.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromPositionedObjects): Removed unnecessary code.
(WebCore::RenderBlock::determineLogicalLeftPositionForChild): Removed unnecessary code.

  • rendering/RenderBox.h:

(WebCore::RenderBox::clientLeft): Removed unnecessary code.

LayoutTests:

This change adds a test that compares CSSOM properties of an RTL element which
includes positioned objects with the CSSOM properties of an LTR one. This change
also uses clientLeft properties in offsetX-offsetY.html to remove a hard-coded
value in the test and adds rebaselined results for Windows.

  • fast/events/offsetX-offsetY.html: Replaced a hard-coded value 'borderLeft' with clientLeft.
  • platform/chromium-linux/fast/block/float/026-expected.png:
  • platform/chromium-linux/fast/block/float/028-expected.png:
  • platform/chromium-win/fast/block/float/026-expected.png:
  • platform/chromium-win/fast/block/float/028-expected.png:
  • platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
  • scrollbars/rtl/div-absolute-expected.txt: Added.
  • scrollbars/rtl/div-absolute.html: Added.
21:42 Changeset [123571] by mitz@apple.com

RenderBlock::positionForPoint can fail when the block or its children have a vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=92202

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/writing-mode/positionForPoint.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionForPoint): Fixed two issues, each of which are covered by
one of the sub-tests in the new regression test: (1) changed to compare children’s logical
bounds against pointInLogicalContents, i.e. compare childern’s horizontal bounds to the
point’s horizontal component; and (2) changed to use logicalTopForChild and
logicalHeightForChild, which account for this block’s writing mode, instead of logicalTop
and logicalBottom, which are based on the child’s writing mode.

LayoutTests:

  • fast/writing-mode/positionForPoint-expected.txt: Added.
  • fast/writing-mode/positionForPoint.html: Added.
21:13 Changeset [123570] by morrita@google.com

https://bugs.webkit.org/show_bug.cgi?id=89179
Rendering LI having Shadow DOM seems weird

Reviewed by Dimitri Glazkov.

Source/WebCore:

This incorrect rendering happend because HTMLLIElement::attach()
wasn't aware of composed shadow subtree. This change makes it
aware of that using ComposedShadowTreeParentWalker.

Test: fast/dom/shadow/shadow-and-list-elements.html

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

LayoutTests:

  • fast/dom/shadow/shadow-and-list-elements-expected.html: Added.
  • fast/dom/shadow/shadow-and-list-elements.html: Added.
20:25 Changeset [123569] by commit-queue@webkit.org

IndexedDB: fix #include dependencies so IDBRequest isn't an include root
https://bugs.webkit.org/show_bug.cgi?id=92167

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-24
Reviewed by Tony Chang.

Source/WebCore:

Remove implicit dependencies due to using IDBRequest.h, and fix all
places that break as a result.

  • Modules/indexeddb/IDBCallbacks.h:

(WebCore):

  • Modules/indexeddb/IDBObjectStore.cpp:
  • Modules/indexeddb/IDBRequest.h:
  • inspector/InspectorIndexedDBAgent.cpp:

Source/WebKit/chromium:

Remove implicit dependencies due to using IDBRequest.h, and fix all
places that break as a result.

  • src/IDBCallbacksProxy.cpp:
  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBTransactionImpl.cpp:
19:35 Changeset [123568] by keishi@webkit.org

Move PagePopupClient helper functions so they can be shared
https://bugs.webkit.org/show_bug.cgi?id=92096

Reviewed by Kent Tamura.

Move PagePopupClient helper functions to a separate file,
so they can be shared with new PagePopupClients.

No new tests. Covered by fast/forms/date/calendar-picker-appearance.html

  • WebCore.gypi: Added PagePopupClient.cpp
  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::writeDocument): Modified to use PagePopupClient.

  • page/PagePopupClient.cpp: Added.

(WebCore):
(WebCore::PagePopupClient::addJavaScriptString):
(WebCore::PagePopupClient::addProperty):

  • page/PagePopupClient.h:

(WebCore::PagePopupClient::addString):

19:31 Changeset [123567] by jer.noble@apple.com

setting playbackRate on a MediaController doesn't change the playbackRate for slaved media
https://bugs.webkit.org/show_bug.cgi?id=92035

Reviewed by Darin Adler.

Source/WebCore:

Allow updatePlaybackRate() to change the MediaPlayer rate when the media element has a
current media controller.

Test: media/media-controller-playbackrate.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updatePlaybackRate):

LayoutTests:

  • media/media-controller-playbackrate-expected.txt: Added.
  • media/media-controller-playbackrate.html: Added.
19:13 Changeset [123566] by alexis.menard@openbossa.org

[Qt] svg/as-border-image, svg/as-image, svg/as-object, svg/css rebaseline after new test fonts.
https://bugs.webkit.org/show_bug.cgi?id=92193

Unreviewed gardening.

These tests have been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/as-border-image/svg-as-border-image-2-expected.png:
  • platform/qt/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/qt/svg/as-border-image/svg-as-border-image-expected.png:
  • platform/qt/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/qt/svg/as-image/animated-svg-as-image-expected.png: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-expected.txt:
  • platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt:
  • platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-same-image-expected.txt:
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.txt:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/qt/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
  • platform/qt/svg/as-image/same-image-two-instances-expected.txt:
  • platform/qt/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/qt/svg/as-image/svg-image-change-content-size-expected.txt:
  • platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • platform/qt/svg/css/composite-shadow-text-expected.png:
  • platform/qt/svg/css/composite-shadow-text-expected.txt:
  • platform/qt/svg/css/css-box-min-width-expected.png:
  • platform/qt/svg/css/css-box-min-width-expected.txt:
  • platform/qt/svg/css/text-shadow-multiple-expected.png:
  • platform/qt/svg/css/text-shadow-multiple-expected.txt:
19:08 Changeset [123565] by hayato@chromium.org

Rename FocusScope to FocusNavigationScope.
https://bugs.webkit.org/show_bug.cgi?id=92062

Reviewed by Dimitri Glazkov.

FocusNavagationScope is better name than FocusScope since the
class is only used for controlling focus navigation.

No new tests - no functional changes.

  • page/FocusController.cpp:

(WebCore::FocusNavigationScope::FocusNavigationScope):
(WebCore::FocusNavigationScope::rootNode):
(WebCore::FocusNavigationScope::owner):
(WebCore::FocusNavigationScope::focusNavigationScopeOf):
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByShadowHost):
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByIFrame):
(WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableNodeAcrossFocusScope):
(WebCore::FocusController::findFocusableNodeRecursively):
(WebCore::FocusController::findFocusableNode):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

  • page/FocusController.h:

(FocusNavigationScope):
(FocusController):

18:57 Changeset [123564] by caio.oliveira@openbossa.org

[Qt] css2.1/t080* rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92191

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/css2.1/t0805-c5518-brdr-t-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-00-a-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5521-brdr-l-00-a-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5521-brdr-l-01-e-expected.txt: Removed.
  • platform/qt-5.0/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt: Removed.
  • platform/qt/css2.1/t0801-c412-hz-box-00-b-a-expected.png:
  • platform/qt/css2.1/t0801-c412-hz-box-00-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-00-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-01-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-01-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-02-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-02-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-03-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-03-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-04-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-04-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-05-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-05-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-06-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-imrgn-r-06-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-01-c-a-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-02-c-expected.txt:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-03-c-expected.png:
  • platform/qt/css2.1/t0803-c5502-mrgn-r-03-c-expected.txt:
  • platform/qt/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-00-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-01-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-01-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-03-b-a-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-03-b-a-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-04-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-04-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-05-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-05-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-06-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-imrgn-l-06-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.png:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-01-c-a-expected.txt:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-02-c-expected.png:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-02-c-expected.txt:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-03-c-expected.png:
  • platform/qt/css2.1/t0803-c5504-mrgn-l-03-c-expected.txt:
  • platform/qt/css2.1/t0803-c5505-imrgn-00-a-ag-expected.png:
  • platform/qt/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-01-e-a-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-01-e-a-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-02-c-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-02-c-expected.txt:
  • platform/qt/css2.1/t0803-c5505-mrgn-03-c-ag-expected.png:
  • platform/qt/css2.1/t0803-c5505-mrgn-03-c-ag-expected.txt:
  • platform/qt/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/qt/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-00-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-00-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-01-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-01-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-02-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5506-ipadn-t-02-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5506-padn-t-00-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-01-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-01-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-02-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-02-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-03-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-03-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-04-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-ipadn-r-04-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
  • platform/qt/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-01-c-a-expected.png:
  • platform/qt/css2.1/t0804-c5507-padn-r-01-c-a-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-02-f-expected.png:
  • platform/qt/css2.1/t0804-c5507-padn-r-02-f-expected.txt:
  • platform/qt/css2.1/t0804-c5507-padn-r-03-f-expected.png:
  • platform/qt/css2.1/t0804-c5507-padn-r-03-f-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-00-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-00-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-01-f-a-expected.png:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-01-f-a-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-02-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-01-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-01-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-03-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-03-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-04-f-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-ipadn-l-04-f-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-01-b-a-expected.png:
  • platform/qt/css2.1/t0804-c5509-padn-l-01-b-a-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-02-f-expected.png:
  • platform/qt/css2.1/t0804-c5509-padn-l-02-f-expected.txt:
  • platform/qt/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
  • platform/qt/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/qt/css2.1/t0804-c5510-ipadn-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5510-ipadn-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/qt/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
  • platform/qt/css2.1/t0804-c5510-padn-01-e-a-expected.png:
  • platform/qt/css2.1/t0804-c5510-padn-01-e-a-expected.txt:
  • platform/qt/css2.1/t0804-c5510-padn-02-f-expected.png:
  • platform/qt/css2.1/t0804-c5510-padn-02-f-expected.txt:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-03-b-expected.png:
  • platform/qt/css2.1/t0805-c5511-brdr-tw-03-b-expected.txt:
  • platform/qt/css2.1/t0805-c5511-ibrdr-tw-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5511-ibrdr-tw-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-03-b-expected.png:
  • platform/qt/css2.1/t0805-c5512-brdr-rw-03-b-expected.txt:
  • platform/qt/css2.1/t0805-c5512-ibrdr-rw-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5512-ibrdr-rw-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-03-b-expected.png:
  • platform/qt/css2.1/t0805-c5513-brdr-bw-03-b-expected.txt:
  • platform/qt/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5513-ibrdr-bw-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-03-b-expected.png:
  • platform/qt/css2.1/t0805-c5514-brdr-lw-03-b-expected.txt:
  • platform/qt/css2.1/t0805-c5514-ibrdr-lw-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5514-ibrdr-lw-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5515-brdr-w-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5515-brdr-w-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5515-brdr-w-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5515-brdr-w-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5515-brdr-w-02-b-expected.png:
  • platform/qt/css2.1/t0805-c5515-brdr-w-02-b-expected.txt:
  • platform/qt/css2.1/t0805-c5515-ibrdr-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5515-ibrdr-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5516-brdr-c-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5516-brdr-c-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5516-ibrdr-c-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5516-ibrdr-c-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5517-brdr-s-00-c-expected.png:
  • platform/qt/css2.1/t0805-c5517-brdr-s-00-c-expected.txt:
  • platform/qt/css2.1/t0805-c5517-ibrdr-s-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5517-ibrdr-s-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5518-brdr-t-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5518-brdr-t-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5518-ibrdr-t-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5518-ibrdr-t-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5519-brdr-r-02-e-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • platform/qt/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5519-ibrdr-r-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5520-brdr-b-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5520-brdr-b-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5520-ibrdr-b-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5520-ibrdr-b-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-02-e-expected.png:
  • platform/qt/css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • platform/qt/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5522-brdr-00-b-expected.png:
  • platform/qt/css2.1/t0805-c5522-brdr-00-b-expected.txt:
  • platform/qt/css2.1/t0805-c5522-brdr-01-b-g-expected.png:
  • platform/qt/css2.1/t0805-c5522-brdr-01-b-g-expected.txt:
  • platform/qt/css2.1/t0805-c5522-brdr-02-e-expected.png:
  • platform/qt/css2.1/t0805-c5522-brdr-02-e-expected.txt:
  • platform/qt/css2.1/t0805-c5522-ibrdr-00-a-expected.png:
  • platform/qt/css2.1/t0805-c5522-ibrdr-00-a-expected.txt:
18:45 Changeset [123563] by yosin@chromium.org

[Tests] Re-factor some tests in fast/forms/number for sharing with other input types
https://bugs.webkit.org/show_bug.cgi?id=92081

Reviewed by Kent Tamura.

This patch moves JavaScript code from test HTML files into JavaScript
files for sharing JavaScript code with other input types.

  • fast/forms/number/number-change-type-on-focus.html: Removed JavaScript code and changed to load JavaScript code from fast/forms/resources/common-change-type-on-focus.js.
  • fast/forms/number/number-losing-renderer-on-click.html: Removed JavaScript code and changed to load JavaScript code from fast/forms/resources/common-losing-renderer-on-click.js.
  • fast/forms/resources/common-change-type-on-focus.js: Remove HTML markup text.
  • fast/forms/resources/common-losing-renderer-on-click.js: Remove HTML markup text.
18:23 Changeset [123562] by rakuco@webkit.org

[EFL] Unreviewed build fix.

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Include unistd.h

for usleep(3).

18:14 Changeset [123561] by caio.oliveira@openbossa.org

[Qt] css2.1/t170602* rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92188

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.png: Added.
  • platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-50-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-50-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-51-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-52-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-53-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-54-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-55-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-56-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-57-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-58-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-59-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-60-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-60-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-61-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-62-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-63-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-64-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-65-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-66-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-67-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-68-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-69-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-70-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-70-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-71-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-72-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-73-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-74-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-75-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-76-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-77-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-78-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-79-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-80-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-80-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-81-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-82-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-83-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-84-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-85-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-86-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-87-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-88-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-89-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-90-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-90-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-91-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-91-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-92-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-92-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-93-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-93-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-94-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-94-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-95-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-96-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-97-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-98-d-expected.txt:
  • platform/qt/css2.1/t170602-bdr-conflct-w-99-d-expected.png:
  • platform/qt/css2.1/t170602-bdr-conflct-w-99-d-expected.txt:
18:11 Changeset [123560] by msaboff@apple.com

Convert HTML parser to handle 8-bit resources without converting to UChar*
https://bugs.webkit.org/show_bug.cgi?id=90321

Reviewed by Geoffrey Garen.

Source/WebCore:

No new tests, no new functionality therefore covered by existing tests.

Changed the parsing of HTML to handle 8-bit strings without converting the
whole string to 16-bits. Primary change was to use the appropriate
character pointer type (LChar* or UChar*) depending on the source string.
This access is abstracted in SegmentedSubstring by getCurrentChar{8,16} and
incrementAndGetCurrentChar{8,16} methods. In SegmentedString, the advance()
and advanceAndUpdateLineNumber() methods have been refactored into a
state machine managed pair of function pointers. The possible functions
have not only the 8 and 16 bitness factored out, they also have the
"exclude line numbers" logic factored out for advanceAndUpdateLineNumber().
This provides a net speed-up even with the 8/16 bit testing.
Other changes involve using String methods to access and compare with the
source data.

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::append): Changed to use currentChar()
instead of SegmentedString '*' operator.

  • html/parser/HTMLEntityParser.cpp: Changed to use currentChar() instead of

SegmentedString '*' operator.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces): Added 8-bit fast path.

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::sourceForToken): Changed to use currentChar() instead of
SegmentedString '*' operator.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script): Updated to use new String::dataSize() method.

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance): Changed to be a wrapper that invokes current
advance function.
(WebCore::SegmentedString::advance8): Fast path advance function for 8 bit data.
(WebCore::SegmentedString::advance16): Fast path advance function for 16 bit data.
(WebCore::SegmentedString::advanceAndUpdateLineNumber8IncludeLineNumbers): Fast
path advanceAndUpdateLineNumber for 8 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceAndUpdateLineNumber16IncludeLineNumbers): Fast
path advanceAndUpdateLineNumber for 16 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceSlowCase): Slow case advance function for both
8 and 16 bit advance.
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase): Slow case
advanceAndUpdateLineNumber function for both 8 and 16 bit data.
(WebCore::SegmentedString::advanceEmpty): Advance function when input has been exhausted.

  • platform/text/SegmentedString.h:

(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(SegmentedSubstring):
(WebCore::SegmentedSubstring::is8Bit): New getter.
(WebCore::SegmentedSubstring::appendTo):
(WebCore::SegmentedSubstring::getCurrentChar8): New getter for the 8 bit case.
(WebCore::SegmentedSubstring::getCurrentChar16): New getter for the 16 bit case.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar8): New wrapper functions
that pre-increments the 8 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar16): New wrapper functions
that pre-increments the 16 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::currentSubString):
(WebCore::SegmentedSubstring::getCurrentChar):
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(WebCore::SegmentedString::currentChar):
(WebCore::SegmentedString::setSlowCase): Set advance function pointers to slow case
functions.
(WebCore::SegmentedString::decrementAndCheckLength): Decrement substring length and
change to slow case functions when only one character left.
(WebCore::SegmentedString::setAdvanceFunctionPointers): Select appropriate advance
functions based on current substring.
(WebCore::SegmentedString::lookAheadInline): Changed to use String::startsWith().
(WebCore::SegmentedString::lookAheadSlowCase):

  • xml/parser/CharacterReferenceParserInlineMethods.h:

(WebCore::consumeCharacterReference): Changed to use currentChar() instead of
SegmentedString '*' operator.

  • xml/parser/MarkupTokenizerBase.h:

(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek): Changed to use
currentChar() instead of SegmentedString '*' operator.
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):

Source/WTF:

  • wtf/text/WTFString.h:

(WTF::String::dataSize): New method to return the number of bytes
the string requires. This replaces a harcoded calculation based on
length and sizeof(UChar).

18:07 Changeset [123559] by weinig@apple.com

Add per-HashTable stats
https://bugs.webkit.org/show_bug.cgi?id=92185

Reviewed by Anders Carlsson.

Add per-HashTable stats, so we can look at the effectiveness of an individual HashTable.

  • wtf/HashTable.h:

(WTF::HashTable::Stats::Stats):
Add a HashTable::Stats to hold the stats.

(WTF::HashTable::Stats::recordCollisionAtCount):
(WTF::HashTable::Stats::dumpStats):
Add versions of recordCollisionAtCount and dumpStats for per-HashTable version.

(WTF::HashTable):
Keep the stats, if enabled, in an OwnPtr, to not blow JSCell max size restrictions.

(WTF::lookup):
(WTF::lookupForWriting):
(WTF::fullLookupForWriting):
(WTF::add):
(WTF::reinsert):
(WTF::remove):
(WTF::rehash):
Keep track of the stats as the table is used.

17:48 Changeset [123558] by zmo@google.com

Gardening stuff, rebaseline.

Unreviewed.

  • platform/chromium-mac/fast/hidpi: Added.
  • platform/chromium-mac/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-as-background-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-border-image-simple-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-out-of-order-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-simple-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/image-set-without-specified-width-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/resize-corner-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi: Added.
  • platform/chromium-win/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/chromium-win/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-as-background-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-as-background-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-background-repeat-without-size-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-comparison-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-simple-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-border-image-simple-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-out-of-order-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-out-of-order-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-simple-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-simple-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/image-set-without-specified-width-expected.png: Added.
  • platform/chromium-win/fast/hidpi/image-set-without-specified-width-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/resize-corner-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
17:46 Changeset [123557] by commit-queue@webkit.org

WKContextGetGlobalStatistics() assigns wrong value to wkFrameCount in WKContextStatistics
https://bugs.webkit.org/show_bug.cgi?id=92173

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-07-24
Reviewed by John Sullivan.

In WKContextGetGlobalStatistics(), wkViewCount in WebContext::Statistics
is assigned to wkFrameCount in WKContextStatistics.
wkFrameCount in WebContext:Statistics should be assigned to wkFrameCount in WKContextStatistics.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetGlobalStatistics):

17:37 Changeset [123556] by kbr@google.com

[chromium] Hint garbage collector to run if page uses Canvas contexts
https://bugs.webkit.org/show_bug.cgi?id=76225

Reviewed by Kentaro Hara.

Source/WebCore:

Upon creating a canvas context, set a hint in the current isolate
indicating that a full GC should be done upon the next page
navigation.

This improves Chrome's robustness on some WebGL stress tests which
simulate real-world behavior by repeatedly navigating among
several samples. More general measures are being investigated, but
this change makes V8 behave the same as JSC on these stress tests.
JSC doesn't currently use generational garbage collection, so it
has more opportunities to discover unreferenced canvas contexts.

Test: fast/canvas/webgl/context-creation-and-destruction.html

  • bindings/v8/V8Binding.cpp:

(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):

Initialize per-isolate low memory hint.

  • bindings/v8/V8Binding.h:

(V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::setLowMemoryNotificationHint):

Set a per-isolate hint to signal a low memory condition upon the next page navigation.

(WebCore::V8BindingPerIsolateData::clearLowMemoryNotificationHint):

Clear the previously set hint.

(WebCore::V8BindingPerIsolateData::isLowMemoryNotificationHint):

Get the previously set hint.

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::hintForGCIfNecessary):

If necessary, send V8 a hint that it should GC.

(WebCore):
(WebCore::V8Proxy::clearForClose):
(WebCore::V8Proxy::clearForNavigation):

Call hintForGCIfNecessary.

  • bindings/v8/V8Proxy.h:

(V8Proxy):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

Set a hint that we should GC upon the next page navigation.

LayoutTests:

This test doesn't directly exercise this code path yet, but it
needs to work regardless and also needs to be expanded.

  • fast/canvas/webgl/context-creation-and-destruction-expected.txt: Added.
  • fast/canvas/webgl/context-creation-and-destruction.html: Added.
17:28 Changeset [123555] by alexis.menard@openbossa.org

[Qt] svg/as-background-image rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92180

Unreviewed gardening.

These tests have been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/as-background-image/animated-svg-as-background-expected.png: Added.
  • platform/qt/svg/as-background-image/animated-svg-as-background-expected.txt:
  • platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-1-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-2-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-3-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-4-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-as-background-4-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-5-expected.png: Added.
  • platform/qt/svg/as-background-image/svg-as-background-5-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-6-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-background-with-viewBox-expected.txt:
  • platform/qt/svg/as-background-image/svg-as-tiled-background-expected.txt:
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/qt/svg/as-background-image/svg-background-partial-redraw-expected.txt:
  • platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.txt:
17:27 Changeset [123554] by abarth@webkit.org

[Chromium] Support scrolling and zooming to focused input elements
https://bugs.webkit.org/show_bug.cgi?id=91661

Reviewed by Darin Fisher.

This patch introduces saveScrollAndScaleState and
restoreScrollAndScaleState, which can be used to save and restore the
scroll and scale state of the WebView, respectively. These functions
will be used by Chromium on Android to save the scale and scrolls state
before zoom into a text field so that we can "undo" the zoom if the
user didn't mean to zoom into the text field.

I wanted to write unit tests for these functions, but it wasn't clear
to me how to write the test because startPageScaleAnimation appears to
complete asynchronously.

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::saveScrollAndScaleState):
(WebKit):
(WebKit::WebViewImpl::restoreScrollAndScaleState):
(WebKit::WebViewImpl::resetSavedScrollAndScaleState):
(WebKit::WebViewImpl::didCommitLoad):

  • src/WebViewImpl.h:

(WebViewImpl):

17:25 Changeset [123553] by commit-queue@webkit.org

[chromium] Add time spent painting to GPU benchmarking renderingStats() API.
https://bugs.webkit.org/show_bug.cgi?id=90019

Patch by Dave Tu <dtu@chromium.org> on 2012-07-24
Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebRenderingStats.h:

(WebRenderingStats):
(WebKit::WebRenderingStats::WebRenderingStats):

Source/WebCore:

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::paintContentsRect):

  • platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:

(Texture):
(BitmapSkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:

(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:

(CanvasLayerTextureUpdater):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::update):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerChromium::update):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore):
(WebCore::LayerChromium::update):

  • platform/graphics/chromium/LayerTextureUpdater.h:

(WebCore):
(WebCore::LayerTextureUpdater::Texture::prepareRect):
(WebCore::LayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::updatePart):
(WebCore::ScrollbarLayerChromium::update):

  • platform/graphics/chromium/ScrollbarLayerChromium.h:

(ScrollbarLayerChromium):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:

(SkPictureCanvasLayerTextureUpdater):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::updateContentRect):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::updateAnimations):
(WebCore::CCLayerTreeHost::renderingStats):
(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):
(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCRenderingStats.h:

(CCRenderingStats):
(WebCore::CCRenderingStats::CCRenderingStats):

Source/WebKit/chromium:

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::renderingStats):

  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::Texture::prepareRect):
(WebKitTests::FakeTiledLayerChromium::update):

  • tests/CCTiledLayerTestCommon.h:

(Texture):
(FakeTiledLayerChromium):

  • tests/Canvas2DLayerBridgeTest.cpp:
  • tests/ContentLayerChromiumTest.cpp:

(WebKit::TEST):

  • tests/TiledLayerChromiumTest.cpp:
17:16 Changeset [123552] by caio.oliveira@openbossa.org

[Qt] fast/block/positioning rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92174

Unreviewed.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/fast/block/positioning/003-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/004-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/005-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/006-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/007-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/008-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/009-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/010-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/011-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/012-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/013-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/014-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/015-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/016-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/017-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/018-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/019-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/020-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/021-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/022-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/023-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/024-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/025-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/026-expected.png: Added.
  • platform/qt/fast/block/positioning/027-expected.png: Added.
  • platform/qt/fast/block/positioning/028-expected.png: Added.
  • platform/qt/fast/block/positioning/029-expected.png: Added.
  • platform/qt/fast/block/positioning/030-expected.png: Added.
  • platform/qt/fast/block/positioning/031-expected.png: Added.
  • platform/qt/fast/block/positioning/032-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/033-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/034-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/035-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/036-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/037-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/038-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/039-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/040-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/041-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/042-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/043-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/044-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/045-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/046-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/047-expected.png:
  • platform/qt/fast/block/positioning/047-expected.txt:
  • platform/qt/fast/block/positioning/048-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/050-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-rl/001-expected.png.
  • platform/qt/fast/block/positioning/052-expected.txt:
  • platform/qt/fast/block/positioning/053-expected.png:
  • platform/qt/fast/block/positioning/053-expected.txt:
  • platform/qt/fast/block/positioning/054-expected.txt:
  • platform/qt/fast/block/positioning/055-expected.png:
  • platform/qt/fast/block/positioning/055-expected.txt:
  • platform/qt/fast/block/positioning/057-expected.png:
  • platform/qt/fast/block/positioning/057-expected.txt:
  • platform/qt/fast/block/positioning/058-expected.png:
  • platform/qt/fast/block/positioning/058-expected.txt:
  • platform/qt/fast/block/positioning/059-expected.png:
  • platform/qt/fast/block/positioning/059-expected.txt:
  • platform/qt/fast/block/positioning/060-expected.png:
  • platform/qt/fast/block/positioning/060-expected.txt:
  • platform/qt/fast/block/positioning/061-expected.txt:
  • platform/qt/fast/block/positioning/062-expected.png: Added.
  • platform/qt/fast/block/positioning/abs-inside-inline-rel-expected.png:
  • platform/qt/fast/block/positioning/abs-inside-inline-rel-expected.txt:
  • platform/qt/fast/block/positioning/absolute-in-inline-ltr-3-expected.png:
  • platform/qt/fast/block/positioning/absolute-in-inline-ltr-3-expected.txt:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-ltr-expected.png:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-ltr-expected.txt:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-rtl-expected.png:
  • platform/qt/fast/block/positioning/absolute-in-inline-short-rtl-expected.txt:
  • platform/qt/fast/block/positioning/absolute-length-of-neg-666666-expected.png:
  • platform/qt/fast/block/positioning/absolute-length-of-neg-666666-expected.txt:
  • platform/qt/fast/block/positioning/absolute-position-direction-expected.png:
  • platform/qt/fast/block/positioning/absolute-position-direction-expected.txt:
  • platform/qt/fast/block/positioning/absolute-positioned-overconstrained-expected.png:
  • platform/qt/fast/block/positioning/absolute-positioned-overconstrained-expected.txt:
  • platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Added.
  • platform/qt/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt:
  • platform/qt/fast/block/positioning/absolute-with-html-border-quirks-expected.png:
  • platform/qt/fast/block/positioning/absolute-with-html-border-quirks-expected.txt:
  • platform/qt/fast/block/positioning/absolute-with-html-border-strict-expected.png:
  • platform/qt/fast/block/positioning/absolute-with-html-border-strict-expected.txt:
  • platform/qt/fast/block/positioning/auto-height-with-top-and-bottom-expected.png:
  • platform/qt/fast/block/positioning/auto-height-with-top-and-bottom-expected.txt:
  • platform/qt/fast/block/positioning/auto/001-expected.png:
  • platform/qt/fast/block/positioning/auto/001-expected.txt:
  • platform/qt/fast/block/positioning/auto/002-expected.png:
  • platform/qt/fast/block/positioning/auto/002-expected.txt:
  • platform/qt/fast/block/positioning/auto/003-expected.png:
  • platform/qt/fast/block/positioning/auto/003-expected.txt:
  • platform/qt/fast/block/positioning/auto/004-expected.png:
  • platform/qt/fast/block/positioning/auto/004-expected.txt:
  • platform/qt/fast/block/positioning/auto/005-expected.png:
  • platform/qt/fast/block/positioning/auto/005-expected.txt:
  • platform/qt/fast/block/positioning/auto/006-expected.png:
  • platform/qt/fast/block/positioning/auto/006-expected.txt:
  • platform/qt/fast/block/positioning/auto/007-expected.png:
  • platform/qt/fast/block/positioning/auto/007-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/001-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/001-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/002-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/002-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/003-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/003-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/004-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/004-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/006-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/006-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-lr/007-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-lr/007-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/001-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/001-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/002-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/002-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/003-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/003-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/004-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/004-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/006-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/006-expected.txt:
  • platform/qt/fast/block/positioning/auto/vertical-rl/007-expected.png:
  • platform/qt/fast/block/positioning/auto/vertical-rl/007-expected.txt:
  • platform/qt/fast/block/positioning/child-of-absolute-with-auto-height-expected.png:
  • platform/qt/fast/block/positioning/child-of-absolute-with-auto-height-expected.txt:
  • platform/qt/fast/block/positioning/differing-writing-modes-expected.png:
  • platform/qt/fast/block/positioning/differing-writing-modes-expected.txt:
  • platform/qt/fast/block/positioning/differing-writing-modes-replaced-expected.png:
  • platform/qt/fast/block/positioning/differing-writing-modes-replaced-expected.txt:
  • platform/qt/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png:
  • platform/qt/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt:
  • platform/qt/fast/block/positioning/height-change-expected.png:
  • platform/qt/fast/block/positioning/height-change-expected.txt:
  • platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png:
  • platform/qt/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt:
  • platform/qt/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/qt/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/qt/fast/block/positioning/leftmargin-topmargin-expected.png:
  • platform/qt/fast/block/positioning/leftmargin-topmargin-expected.txt:
  • platform/qt/fast/block/positioning/negative-right-pos-expected.png:
  • platform/qt/fast/block/positioning/negative-right-pos-expected.txt:
  • platform/qt/fast/block/positioning/padding-percent-expected.png:
  • platform/qt/fast/block/positioning/padding-percent-expected.txt:
  • platform/qt/fast/block/positioning/pref-width-change-expected.txt:
  • platform/qt/fast/block/positioning/relative-overconstrained-expected.png: Copied from LayoutTests/platform/qt/fast/block/positioning/vertical-lr/001-expected.png.
  • platform/qt/fast/block/positioning/relative-overflow-block-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-block-expected.txt:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-expected.txt:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.png:
  • platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.txt:
  • platform/qt/fast/block/positioning/relayout-on-position-change-expected.png:
  • platform/qt/fast/block/positioning/relayout-on-position-change-expected.txt:
  • platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/qt/fast/block/positioning/rtl-fixed-positioning-expected.png:
  • platform/qt/fast/block/positioning/rtl-static-positioning-expected.png:
  • platform/qt/fast/block/positioning/rtl-static-positioning-expected.txt:
  • platform/qt/fast/block/positioning/rtl-static-positioning-inline-block-expected.png:
  • platform/qt/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt:
  • platform/qt/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png:
  • platform/qt/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt:
  • platform/qt/fast/block/positioning/table-cell-static-position-expected.png:
  • platform/qt/fast/block/positioning/table-cell-static-position-expected.txt:
  • platform/qt/fast/block/positioning/trailing-space-test-expected.png:
  • platform/qt/fast/block/positioning/trailing-space-test-expected.txt:
  • platform/qt/fast/block/positioning/vertical-lr/001-expected.png:
  • platform/qt/fast/block/positioning/vertical-lr/001-expected.txt:
  • platform/qt/fast/block/positioning/vertical-rl/001-expected.png:
  • platform/qt/fast/block/positioning/vertical-rl/001-expected.txt:
  • platform/qt/fast/block/positioning/vertical-rl/fixed-positioning-expected.png:
  • platform/qt/fast/block/positioning/window-height-change-expected.png:
  • platform/qt/fast/block/positioning/window-height-change-expected.txt:
16:58 Changeset [123551] by commit-queue@webkit.org

[Qt] fast/block/float needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92150

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-24
Reviewed by Alexis Menard.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/fast/block/float/001-expected.txt:
  • platform/qt/fast/block/float/002-expected.png:
  • platform/qt/fast/block/float/002-expected.txt:
  • platform/qt/fast/block/float/003-expected.png:
  • platform/qt/fast/block/float/003-expected.txt:
  • platform/qt/fast/block/float/004-expected.png:
  • platform/qt/fast/block/float/004-expected.txt:
  • platform/qt/fast/block/float/005-expected.png:
  • platform/qt/fast/block/float/005-expected.txt:
  • platform/qt/fast/block/float/006-expected.png:
  • platform/qt/fast/block/float/006-expected.txt:
  • platform/qt/fast/block/float/007-expected.png:
  • platform/qt/fast/block/float/007-expected.txt:
  • platform/qt/fast/block/float/010-expected.png:
  • platform/qt/fast/block/float/010-expected.txt:
  • platform/qt/fast/block/float/011-expected.png:
  • platform/qt/fast/block/float/011-expected.txt:
  • platform/qt/fast/block/float/012-expected.png:
  • platform/qt/fast/block/float/012-expected.txt:
  • platform/qt/fast/block/float/013-expected.png:
  • platform/qt/fast/block/float/013-expected.txt:
  • platform/qt/fast/block/float/014-expected.png:
  • platform/qt/fast/block/float/014-expected.txt:
  • platform/qt/fast/block/float/015-expected.png:
  • platform/qt/fast/block/float/015-expected.txt:
  • platform/qt/fast/block/float/016-expected.png:
  • platform/qt/fast/block/float/016-expected.txt:
  • platform/qt/fast/block/float/017-expected.png:
  • platform/qt/fast/block/float/017-expected.txt:
  • platform/qt/fast/block/float/018-expected.png:
  • platform/qt/fast/block/float/018-expected.txt:
  • platform/qt/fast/block/float/020-expected.png:
  • platform/qt/fast/block/float/020-expected.txt:
  • platform/qt/fast/block/float/021-expected.png:
  • platform/qt/fast/block/float/021-expected.txt:
  • platform/qt/fast/block/float/022-expected.png:
  • platform/qt/fast/block/float/022-expected.txt:
  • platform/qt/fast/block/float/023-expected.png:
  • platform/qt/fast/block/float/023-expected.txt:
  • platform/qt/fast/block/float/024-expected.png:
  • platform/qt/fast/block/float/024-expected.txt:
  • platform/qt/fast/block/float/025-expected.png:
  • platform/qt/fast/block/float/025-expected.txt:
  • platform/qt/fast/block/float/027-expected.png:
  • platform/qt/fast/block/float/027-expected.txt:
  • platform/qt/fast/block/float/029-expected.png:
  • platform/qt/fast/block/float/029-expected.txt:
  • platform/qt/fast/block/float/030-expected.png:
  • platform/qt/fast/block/float/030-expected.txt:
  • platform/qt/fast/block/float/031-expected.png:
  • platform/qt/fast/block/float/031-expected.txt:
  • platform/qt/fast/block/float/032-expected.png:
  • platform/qt/fast/block/float/032-expected.txt:
  • platform/qt/fast/block/float/avoidance-percent-width-compat-expected.png: Added.
  • platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt:
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.png:
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
  • platform/qt/fast/block/float/avoiding-float-centered-expected.png:
  • platform/qt/fast/block/float/avoiding-float-centered-expected.txt:
  • platform/qt/fast/block/float/br-with-clear-expected.txt:
  • platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.png:
  • platform/qt/fast/block/float/centered-float-avoidance-complexity-expected.txt:
  • platform/qt/fast/block/float/clamped-right-float-expected.png:
  • platform/qt/fast/block/float/clamped-right-float-expected.txt:
  • platform/qt/fast/block/float/clear-element-too-wide-for-containing-block-expected.png:
  • platform/qt/fast/block/float/clear-element-too-wide-for-containing-block-expected.txt:
  • platform/qt/fast/block/float/dynamic-unfloat-pref-width-expected.png:
  • platform/qt/fast/block/float/dynamic-unfloat-pref-width-expected.txt:
  • platform/qt/fast/block/float/editable-text-overlapping-float-expected.png:
  • platform/qt/fast/block/float/editable-text-overlapping-float-expected.txt:
  • platform/qt/fast/block/float/fit_line_below_floats-expected.png:
  • platform/qt/fast/block/float/fit_line_below_floats-expected.txt:
  • platform/qt/fast/block/float/float-avoidance-expected.png:
  • platform/qt/fast/block/float/float-avoidance-expected.txt:
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.png:
  • platform/qt/fast/block/float/float-in-float-hit-testing-expected.txt:
  • platform/qt/fast/block/float/float-in-float-painting-expected.png:
  • platform/qt/fast/block/float/float-in-float-painting-expected.txt:
  • platform/qt/fast/block/float/floats-and-text-indent-expected.png:
  • platform/qt/fast/block/float/floats-and-text-indent-expected.txt:
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.png:
  • platform/qt/fast/block/float/floats-and-text-indent-rl-expected.txt:
  • platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt:
  • platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt:
  • platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt:
  • platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt:
  • platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt:
  • platform/qt/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt:
  • platform/qt/fast/block/float/intruding-painted-twice-expected.png:
  • platform/qt/fast/block/float/intruding-painted-twice-expected.txt:
  • platform/qt/fast/block/float/marquee-shrink-to-avoid-floats-expected.png:
  • platform/qt/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
  • platform/qt/fast/block/float/multiple-float-positioning-expected.png:
  • platform/qt/fast/block/float/multiple-float-positioning-expected.txt:
  • platform/qt/fast/block/float/nested-clearance-expected.png:
  • platform/qt/fast/block/float/nested-clearance-expected.txt:
  • platform/qt/fast/block/float/nestedAnonymousBlocks-expected.png:
  • platform/qt/fast/block/float/nestedAnonymousBlocks-expected.txt:
  • platform/qt/fast/block/float/nestedAnonymousBlocks2-expected.png:
  • platform/qt/fast/block/float/nestedAnonymousBlocks2-expected.txt:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction-expected.png:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction-expected.txt:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction2-expected.png:
  • platform/qt/fast/block/float/nopaint-after-layer-destruction2-expected.txt:
  • platform/qt/fast/block/float/overhanging-after-height-decrease-expected.png:
  • platform/qt/fast/block/float/overhanging-after-height-decrease-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png:
  • platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt:
  • platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png:
  • platform/qt/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt:
  • platform/qt/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.png:
  • platform/qt/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
  • platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/qt/fast/block/float/shrink-to-fit-width-expected.png:
  • platform/qt/fast/block/float/shrink-to-fit-width-expected.txt:
  • platform/qt/fast/block/float/table-relayout-expected.png:
  • platform/qt/fast/block/float/table-relayout-expected.txt:
  • platform/qt/fast/block/float/vertical-move-relayout-expected.png:
  • platform/qt/fast/block/float/vertical-move-relayout-expected.txt:
  • platform/qt/fast/block/float/width-update-after-clear-expected.png:
  • platform/qt/fast/block/float/width-update-after-clear-expected.txt:
16:51 Changeset [123550] by jianli@chromium.org

[V8] Correct WebIDL type should be used in the testing IDL file
https://bugs.webkit.org/show_bug.cgi?id=92168

Reviewed by Kentaro Hara.

Updated bindings test.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_strict_function):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionStrictFunction):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):

16:38 Changeset [123549] by tkent@chromium.org

Merge 123187 - [Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
https://bugs.webkit.org/show_bug.cgi?id=91824

Reviewed by Hajime Morita.

No new tests. This code is used only in Chromium browser.

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::hostInput):
Use shadowHost(), and allow to return 0.
(WebCore::TextFieldDecorationElement::defaultEventHandler):
Check 0.

TBR=tkent@chromium.org
BUG=crbug.com/136145
Review URL: https://chromiumcodereview.appspot.com/10809092

16:34 Changeset [123548] by tkent@chromium.org

Merge 123180 - Introduce Node::shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=91814

Reviewed by Hajime Morita.

Introduce Node::shadowHost(), which return the host element, or 0.
Node::shadowAncestorNode() is used to obtain a shadow host. However it
is confusing because it returns 'this' if this is not in a shadow tree.

Replaces one callsite of shadowAncestorNode() with shadowHost().

No behavior change.

  • dom/Node.cpp:

(WebCore::Node::shadowHost): Added.

  • dom/Node.h:

(Node): Declare shadowHost(), and add a comment to shadowAncestorNode().

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::hostInput):
Replace shadowAncestorNode() with shaodwHost().

TBR=tkent@chromium.org
BUG=crbug.com/136145
Review URL: https://chromiumcodereview.appspot.com/10823003

16:12 Changeset [123547] by tkent@chromium.org

Unreviewed, rolling out r123191.
http://trac.webkit.org/changeset/123191
https://bugs.webkit.org/show_bug.cgi?id=91804

It might cause another performance regression.
http://code.google.com/p/chromium/issues/detail?id=138410

  • html/FormController.cpp:

(FormKeyGenerator):
(WebCore::createKey):
(WebCore::FormKeyGenerator::formKey):
(WebCore::FormKeyGenerator::willDeleteForm):

15:55 Changeset [123546] by commit-queue@webkit.org

[JSBinding] Merging jsUnsignedLongArrayToVector() to toNativeArray() using traits.
https://bugs.webkit.org/show_bug.cgi?id=90381

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-07-24
Reviewed by Kentaro Hara.

We can remove jsUnsignedLongArrayToVector() implementaion
merging it to current and toNativeArray() traits.

Tests: TestObj.idl
There should be no behavoiral changes as just refactoring.

  • Modules/vibration/NavigatorVibration.idl: Use sequence<T> as method param than T[]
  • bindings/js/JSDOMBinding.cpp: Moved toJSSequence() to header file.
  • bindings/js/JSDOMBinding.h:

(WebCore::toJSSequence): Moved toJSSequence() to header file.
(WebCore::jsArray): Renamed Traits to JSValueTraits
(WebCore::toNativeArray): Using traits.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::fillMessagePortArray):

  • bindings/scripts/CodeGeneratorJS.pm: Removed unsigned long[] specific binding code.

(AddIncludesForType):
(GenerateParametersCheckExpression):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheckExpression): Added check sequence<T> check for overloaded methods.

  • bindings/scripts/test/JS/JSTestObj.cpp: Rebased binding test.

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod10):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence):

  • bindings/scripts/test/JS/JSTestObj.h: Rebased binding test.
  • bindings/scripts/test/TestObj.idl: Added test for sequence<T> as method parameter.
  • bindings/scripts/test/V8/V8TestObj.cpp: Rebased binding test.

(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::overloadedMethodCallback):

15:54 Changeset [123545] by commit-queue@webkit.org

[EFL][WK2] Add unit tests for custom text encoding setting
https://bugs.webkit.org/show_bug.cgi?id=91983

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-24
Reviewed by Dirk Pranke.

Add unit tests for get and set custom text encoding methods. Also, fix
a style nit for r123177.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_setting_encoding_custom_set): Fix a style nit - add newline
before return.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

15:51 Changeset [123544] by rniwa@webkit.org

WinCairo build fix attempt.

  • win/WebKit2CFLite.def:
15:34 Changeset [123543] by rniwa@webkit.org

Windows build fix attempt.

15:34 Changeset [123542] by kseo@webkit.org

Remove an invalid assertion introduced in r123536. Unreviewed.

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):

15:33 Changeset [123541] by zmo@google.com

Unreviewed, rolling out r123504.
http://trac.webkit.org/changeset/123504
https://bugs.webkit.org/show_bug.cgi?id=92169

broke a bunch of text-related tests in chromium mac debug
(Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

  • platform/text/cf/StringCF.cpp:

(WTF::String::createCFString):

  • platform/text/cf/StringImplCF.cpp:

(WTF::StringImpl::createCFString):

15:26 Changeset [123540] by atwilson@chromium.org

Unreviewed chromium expectations change stop ignoring fast/hidpi changes.

  • platform/chromium/TestExpectations:
15:22 Changeset [123539] by simonjam@chromium.org

Merge 123121 - Regression(120096): Protect the element used by ImageLoader until the end of notifyFinished().
https://bugs.webkit.org/show_bug.cgi?id=90471

Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/security/video-poster-cross-origin-crash.html

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::notifyFinished): Hang on to the element until we're done.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::setImage): No behavior change.
(WebCore):
(WebCore::ImageLoader::setImageWithoutConsideringPendingLoadEvent): Split off from old setImage, minus calling updatedHasPendingLoadEvent().
(WebCore::ImageLoader::notifyFinished): Invoke updatedHasPendingLoadEvent when done with cross origin errors.

  • loader/ImageLoader.h:

(ImageLoader):

LayoutTests:

  • http/tests/security/video-poster-cross-origin-crash-expected.txt: Added.
  • http/tests/security/video-poster-cross-origin-crash.html: Added. From fuzzer.

TBR=simonjam@chromium.org

15:20 Changeset [123538] by dpranke@chromium.org

make test-webkitpy at least kinda work in parallel on win32
https://bugs.webkit.org/show_bug.cgi?id=91700

Reviewed by Adam Barth.

This change makes the hoop-jumping we have to do to make running
new-run-webkit-tests in parallel on win32 generic so that we can
re-use it for test-webkitpy as well.

  • Scripts/new-run-webkit-tests:
  • Scripts/test-webkitpy:
  • Scripts/webkitpy/common/multiprocessing_bootstrap.py: Copied from Tools/Scripts/new-run-webkit-tests.

(run):

  • Scripts/webkitpy/test/main.py:

(main):
(Tester._log_exception):

15:19 Changeset [123537] by kseo@webkit.org

Ensure Noah's ark without reading the DOM tree.
https://bugs.webkit.org/show_bug.cgi?id=92065

Reviewed by Adam Barth.

Technically we shouldn't read attributes back from the DOM. If JavaScript changes
the attributes values, we could get a slightly wrong output here.

Read attributes from tokens saved in the active formatting element list.

No new tests, covered by existing tests.

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::attributeCount):
(WebCore::HTMLFormattingElementList::append):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):

  • html/parser/HTMLFormattingElementList.h:

(HTMLFormattingElementList):

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::localName):
(HTMLStackItem):

15:12 Changeset [123536] by kseo@webkit.org

Clear the external characters pointer of an AtomicHTMLToken before the raw token is cleared.
https://bugs.webkit.org/show_bug.cgi?id=92056

Reviewed by Adam Barth.

AtomicHTMLToken keeps a pointer to the HTMLToken's buffer instead of copying the
characters for performance. Clear the external characters pointer before the raw token
is cleared to make sure that we won't have a dangling pointer.

No new tests - no functional changes.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::constructTreeFromToken):

  • xml/parser/MarkupTokenBase.h:

(WebCore::AtomicMarkupTokenBase::clearExternalCharacters):
(AtomicMarkupTokenBase):

15:08 Changeset [123535] by jianli@chromium.org

Add per-context setting for html notifications
https://bugs.webkit.org/show_bug.cgi?id=91295

Reviewed by Adam Barth.

Source/WebCore:

Added a new per-context setting to control the enabling of html notifications.
For chromium port, we're going to disable html notifications for web
pages, but still keep it enabled for extensions.

Also enhance V8 code generator to support V8EnabledPerContext attribute
for methods.

Updated the binding tests.

  • Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::document): Expose document for being used by installPerContextProperties.
(WebCore):

  • Modules/notifications/NotificationCenter.h:

(NotificationCenter):

  • Modules/notifications/NotificationCenter.idl: Add V8EnabledPerContext attribute.
  • bindings/scripts/CodeGeneratorV8.pm: V8EnabledPerContext now supports methods.

(GenerateHeader):
(IsStandardFunction):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateToV8Converters):
(GetContextEnableFunction):

  • bindings/scripts/test/TestObj.idl: Add test case for V8EnabledPerContext methods.
  • bindings/scripts/test/V8/V8TestObj.cpp: Update test result.

(WebCore::TestObjV8Internal::enabledAtContextMethod1Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::enabledAtContextMethod2Callback):
(WebCore::V8TestObj::installPerContextProperties):
(WebCore::V8TestObj::wrapSlow):

  • dom/ContextFeatures.cpp: Add a new per-context feature.

(WebCore::ContextFeatures::htmlNotificationsEnabled):
(WebCore):

  • dom/ContextFeatures.h: Add a new per-context feature.

Source/WebKit/chromium:

Add new per-context feature for chromium port.

  • public/WebPermissionClient.h:

(WebPermissionClient):
(WebKit::WebPermissionClient::allowHTMLNotifications):

  • src/ContextFeaturesClientImpl.cpp:

(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

15:07 Changeset [123534] by inferno@chromium.org

Revert 123529 - Merge 123187 - [Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
https://bugs.webkit.org/show_bug.cgi?id=91824
BUG=136145
Review URL: https://chromiumcodereview.appspot.com/10818041

TBR=inferno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10819007

15:07 Changeset [123533] by zmo@google.com

Unreviewed, rolling out r123499.
http://trac.webkit.org/changeset/123499
https://bugs.webkit.org/show_bug.cgi?id=92161

Android fails to compile (Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

Source/Platform:

  • chromium/public/WebMediaStreamDescriptor.h:

(WebMediaStreamDescriptor):

  • chromium/public/WebMediaStreamSource.h:

(WebMediaStreamSource):

Source/WebCore:

  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::setEnabled):

  • Modules/mediastream/MediaStreamTrack.h:

(MediaStreamTrack):

  • Modules/mediastream/MediaStreamTrack.idl:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • platform/chromium/support/WebMediaStreamDescriptor.cpp:

(WebKit):
(WebKit::WebMediaStreamDescriptor::sources):

  • platform/chromium/support/WebMediaStreamSource.cpp:
  • platform/mediastream/MediaStreamSource.cpp: Removed.
  • platform/mediastream/MediaStreamSource.h:

(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::muted):
(WebCore::MediaStreamSource::setMuted):
(WebCore::MediaStreamSource::MediaStreamSource):
(MediaStreamSource):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didCreateMediaStream):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::createMediaStreamCenter):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.h:

(MockWebKitPlatformSupport):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Removed.
  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Removed.

LayoutTests:

  • fast/mediastream/MediaStreamTrack-expected.txt: Removed.
  • fast/mediastream/MediaStreamTrack.html: Removed.
15:01 Changeset [123532] by atwilson@chromium.org

Unreviewed chromium expectations update from r123490.

  • platform/chromium-mac-snowleopard/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-as-background-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-simple-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-out-of-order-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-simple-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/image-set-without-specified-width-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/resize-corner-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
14:48 Changeset [123531] by inferno@chromium.org

Merge 122918 - Fix an assertion failure in CalendarPickerElement::hostInput().
https://bugs.webkit.org/show_bug.cgi?id=91568
BUG=137671
Review URL: https://chromiumcodereview.appspot.com/10795098

14:44 Changeset [123530] by dpranke@chromium.org

nrwt: never finds binaries in the 'out' dir on chromium win
https://bugs.webkit.org/show_bug.cgi?id=91890

Reviewed by Tony Chang.

Attempt to fix this bug yet again; it turns out that --root and
--build-directory don't have the same meaning (--root should
include the configuration, --build-directory should not).

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._build_path):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort):
(ChromiumPort._build_path_with_configuration):
(ChromiumPort._build_path_with_configuration.does):
(ChromiumPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort):
(ChromiumAndroidPort._build_path_with_configuration):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_build_path):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

14:37 Changeset [123529] by inferno@chromium.org

Merge 123187 - [Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
https://bugs.webkit.org/show_bug.cgi?id=91824
BUG=136145
Review URL: https://chromiumcodereview.appspot.com/10818041

14:35 Changeset [123528] by inferno@chromium.org

Merge 123128 - Crash in WebCore::StyleResolver::collectMatchingRulesForList
https://bugs.webkit.org/show_bug.cgi?id=90803
BUG=136235
Review URL: https://chromiumcodereview.appspot.com/10809085

14:26 Changeset [123527] by caio.oliveira@openbossa.org

[Qt] svg/batik rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92162

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/batik/text/smallFonts-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/smallFonts-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textAnchor-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/textAnchor-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textEffect-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/textEffect-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textEffect3-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/textEffect3-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textPosition-expected.txt: Removed.
  • platform/qt-5.0/svg/batik/text/textPosition2-expected.png: Removed.
  • platform/qt-5.0/svg/batik/text/textPosition2-expected.txt: Removed.
  • platform/qt/svg/batik/filters/filterRegions-expected.png:
  • platform/qt/svg/batik/filters/filterRegions-expected.txt:
  • platform/qt/svg/batik/masking/maskRegions-expected.png:
  • platform/qt/svg/batik/masking/maskRegions-expected.txt:
  • platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/qt/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/qt/svg/batik/paints/patternRegionA-expected.png:
  • platform/qt/svg/batik/paints/patternRegionA-expected.txt:
  • platform/qt/svg/batik/paints/patternRegions-expected.png:
  • platform/qt/svg/batik/paints/patternRegions-expected.txt:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/qt/svg/batik/text/longTextOnPath-expected.png:
  • platform/qt/svg/batik/text/longTextOnPath-expected.txt:
  • platform/qt/svg/batik/text/smallFonts-expected.png:
  • platform/qt/svg/batik/text/smallFonts-expected.txt:
  • platform/qt/svg/batik/text/textAnchor-expected.png:
  • platform/qt/svg/batik/text/textAnchor-expected.txt:
  • platform/qt/svg/batik/text/textAnchor2-expected.png:
  • platform/qt/svg/batik/text/textAnchor2-expected.txt:
  • platform/qt/svg/batik/text/textAnchor3-expected.png:
  • platform/qt/svg/batik/text/textAnchor3-expected.txt:
  • platform/qt/svg/batik/text/textDecoration-expected.png:
  • platform/qt/svg/batik/text/textDecoration-expected.txt:
  • platform/qt/svg/batik/text/textDecoration2-expected.png:
  • platform/qt/svg/batik/text/textDecoration2-expected.txt:
  • platform/qt/svg/batik/text/textEffect-expected.png:
  • platform/qt/svg/batik/text/textEffect-expected.txt:
  • platform/qt/svg/batik/text/textEffect2-expected.png:
  • platform/qt/svg/batik/text/textEffect2-expected.txt:
  • platform/qt/svg/batik/text/textEffect3-expected.png:
  • platform/qt/svg/batik/text/textEffect3-expected.txt:
  • platform/qt/svg/batik/text/textFeatures-expected.png:
  • platform/qt/svg/batik/text/textFeatures-expected.txt:
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/qt/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/qt/svg/batik/text/textLayout2-expected.png:
  • platform/qt/svg/batik/text/textLayout2-expected.txt:
  • platform/qt/svg/batik/text/textLength-expected.png:
  • platform/qt/svg/batik/text/textLength-expected.txt:
  • platform/qt/svg/batik/text/textOnPath-expected.png:
  • platform/qt/svg/batik/text/textOnPath-expected.txt:
  • platform/qt/svg/batik/text/textOnPath2-expected.png:
  • platform/qt/svg/batik/text/textOnPath2-expected.txt:
  • platform/qt/svg/batik/text/textOnPath3-expected.png:
  • platform/qt/svg/batik/text/textOnPath3-expected.txt:
  • platform/qt/svg/batik/text/textPCDATA-expected.png:
  • platform/qt/svg/batik/text/textPCDATA-expected.txt:
  • platform/qt/svg/batik/text/textPosition-expected.png:
  • platform/qt/svg/batik/text/textPosition-expected.txt:
  • platform/qt/svg/batik/text/textPosition2-expected.png:
  • platform/qt/svg/batik/text/textPosition2-expected.txt:
  • platform/qt/svg/batik/text/textProperties-expected.png:
  • platform/qt/svg/batik/text/textProperties-expected.txt:
  • platform/qt/svg/batik/text/textProperties2-expected.png:
  • platform/qt/svg/batik/text/textProperties2-expected.txt:
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/qt/svg/batik/text/verticalTextOnPath-expected.txt:
14:09 Changeset [123526] by rwlbuis@webkit.org

[BlackBerry] Do not call settings setters twice on page construction
https://bugs.webkit.org/show_bug.cgi?id=92157

Reviewed by Yong Li.

The WebPagePrivate init method sets some settings value that were
already set in didChangeSettings.
Also call didChangeSettings explicitly from init, before that we are
not calling it since the delegate is not set yet.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

13:59 Changeset [123525] by jchaffraix@webkit.org

Crash in RenderTableSection::layoutRows
https://bugs.webkit.org/show_bug.cgi?id=92145

Reviewed by Abhishek Arya.

Source/WebCore:

The crash came from the insertChildNode logic being confused and choosing the wrong
renderer for insertion. This is because after r123159, table anonymous wrappers can
be created as 'inline-table' and wouldn't pass the isAnonymousBlock() check.

This change also aligns the ancestor iteration with RenderBlock::addChildToAnonymousColumnBlocks.

Test: fast/table/crash-table-section-layoutRows.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::insertChildNode):
Changed the code to always get the right child. There is no justification to not
walking up to the |owner|'s direct child in all cases.

LayoutTests:

  • fast/table/crash-table-section-layoutRows-expected.txt: Added.
  • fast/table/crash-table-section-layoutRows.html: Added.
13:53 Changeset [123524] by tony@chromium.org

Make RenderBlock::paintChildren virtual so sub classes can change the paint order
https://bugs.webkit.org/show_bug.cgi?id=92042

Reviewed by Ojan Vafai.

The flexbox spec says that the order property should change the paint order of flex children.
To make that possible, make paintChildren virtual so RenderFlexibleBox can override it.

No new tests, this is just a refactoring.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContents): Move some code out of paintChildren into paintContents.
(WebCore::RenderBlock::paintChildren): Make virtual and just have it be a simple for loop.
(WebCore::RenderBlock::paintChild): Move code out of paintChildren so subclasses can reuse.

  • rendering/RenderBlock.h:

(RenderBlock): Make paintChildren virtual and protected so sub classes can call paintChild.

13:46 Changeset [123523] by caio.oliveira@openbossa.org

[Qt] svg/clip-path rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92158

Unreviewed.

Create a separate bug to track two tests that had wrong expected results before
the font change.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/clip-path/clip-path-pixelation-expected.png:
  • platform/qt/svg/clip-path/clip-path-pixelation-expected.txt:
  • platform/qt/svg/clip-path/clip-path-text-and-shape-expected.png:
  • platform/qt/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/qt/svg/clip-path/clip-path-text-and-stroke-expected.png:
  • platform/qt/svg/clip-path/clip-path-text-and-stroke-expected.txt:
  • platform/qt/svg/clip-path/clip-path-text-expected.png:
  • platform/qt/svg/clip-path/clip-path-text-expected.txt:
  • platform/qt/svg/clip-path/clip-path-tspan-and-stroke-expected.png:
  • platform/qt/svg/clip-path/clip-path-tspan-and-stroke-expected.txt:
  • platform/qt/svg/clip-path/clip-path-with-text-clipped-expected.png:
  • platform/qt/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt:
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
  • platform/qt/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
13:44 Changeset [123522] by annacc@chromium.org

Create SourceBuffer and SourceBufferList objects
https://bugs.webkit.org/show_bug.cgi?id=91771

Reviewed by Eric Carlson.

SourceBuffer and SourceBufferList objects are needed in order to
implement the new object-oriented MediaSource API:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html

No new tests - will be able to test after landing BUGWK91775

Adding new files to build files:

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:

New objects:

  • Modules/mediasource/SourceBuffer.cpp: Added.
  • Modules/mediasource/SourceBuffer.h: Added.
  • Modules/mediasource/SourceBuffer.idl: Added.
  • Modules/mediasource/SourceBufferList.cpp: Added.
  • Modules/mediasource/SourceBufferList.h: Added.
  • Modules/mediasource/SourceBufferList.idl: Added.

New events:

  • dom/EventNames.h:

(WebCore):

  • dom/EventTarget.h:

(WebCore):

  • dom/EventTargetFactory.in:

Object constructors:

  • page/DOMWindow.idl:
13:33 Changeset [123521] by zmo@google.com

Rebaseline - gardening stuff.

Unreviewed.

  • fast/canvas/webgl/framebuffer-object-attachment-expected.txt:
  • fast/canvas/webgl/framebuffer-object-attachment.html:
  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils):

  • platform/chromium-linux-x86/css3/selectors3/html: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xhtml: Removed.
  • platform/chromium-linux-x86/css3/selectors3/xml: Removed.
  • platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Removed.
  • platform/chromium-linux/compositing/overflow/theme-affects-visual-overflow-expected.png:
  • platform/chromium-linux/css1/box_properties/acid_test-expected.png:
  • platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/chromium-linux/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/chromium-linux/fast/block/basic/011-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png:
  • platform/chromium-linux/fast/forms/001-expected.png:
  • platform/chromium-linux/fast/forms/basic-inputs-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/file/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/formmove-expected.png:
  • platform/chromium-linux/fast/forms/formmove2-expected.png:
  • platform/chromium-linux/fast/forms/indeterminate-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium-linux/fast/inline/positionedLifetime-expected.png:
  • platform/chromium-linux/fast/parser/bad-xml-slash-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.
  • platform/chromium-win-xp/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Removed.
  • platform/mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.
  • platform/mac/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Removed.
13:32 Changeset [123520] by commit-queue@webkit.org

[chromium] Add a bounding box member in WebGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=92144

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-07-24
Reviewed by Adam Barth.

The new |boundingBox| member will be used to store the touch region for a WebGestureEvent.
This will be useful for gesture target fuzzing across multiple different gesture types
(tap, long press, scroll, etc.)

  • public/WebInputEvent.h:

(WebGestureEvent):

  • src/WebInputEvent.cpp:

(SameSizeAsWebGestureEvent):

13:29 Changeset [123519] by commit-queue@webkit.org

[Qt] fast/block/basic needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92149

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-24
Reviewed by Alexis Menard.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/fast/block/basic/001-expected.png:
  • platform/qt/fast/block/basic/001-expected.txt:
  • platform/qt/fast/block/basic/002-expected.png:
  • platform/qt/fast/block/basic/002-expected.txt:
  • platform/qt/fast/block/basic/003-expected.png:
  • platform/qt/fast/block/basic/003-expected.txt:
  • platform/qt/fast/block/basic/004-expected.png:
  • platform/qt/fast/block/basic/004-expected.txt:
  • platform/qt/fast/block/basic/005-expected.png:
  • platform/qt/fast/block/basic/005-expected.txt:
  • platform/qt/fast/block/basic/006-expected.png:
  • platform/qt/fast/block/basic/006-expected.txt:
  • platform/qt/fast/block/basic/007-expected.png:
  • platform/qt/fast/block/basic/007-expected.txt:
  • platform/qt/fast/block/basic/008-expected.png:
  • platform/qt/fast/block/basic/008-expected.txt:
  • platform/qt/fast/block/basic/009-expected.png:
  • platform/qt/fast/block/basic/009-expected.txt:
  • platform/qt/fast/block/basic/010-expected.png:
  • platform/qt/fast/block/basic/010-expected.txt:
  • platform/qt/fast/block/basic/011-expected.png:
  • platform/qt/fast/block/basic/011-expected.txt:
  • platform/qt/fast/block/basic/012-expected.png:
  • platform/qt/fast/block/basic/012-expected.txt:
  • platform/qt/fast/block/basic/013-expected.png:
  • platform/qt/fast/block/basic/013-expected.txt:
  • platform/qt/fast/block/basic/014-expected.png:
  • platform/qt/fast/block/basic/014-expected.txt:
  • platform/qt/fast/block/basic/015-expected.png:
  • platform/qt/fast/block/basic/015-expected.txt:
  • platform/qt/fast/block/basic/016-expected.png:
  • platform/qt/fast/block/basic/016-expected.txt:
  • platform/qt/fast/block/basic/018-expected.png:
  • platform/qt/fast/block/basic/018-expected.txt:
  • platform/qt/fast/block/basic/019-expected.png:
  • platform/qt/fast/block/basic/019-expected.txt:
  • platform/qt/fast/block/basic/020-expected.txt:
  • platform/qt/fast/block/basic/021-expected.png:
  • platform/qt/fast/block/basic/021-expected.txt:
  • platform/qt/fast/block/basic/adding-near-anonymous-block-expected.png:
  • platform/qt/fast/block/basic/adding-near-anonymous-block-expected.txt:
  • platform/qt/fast/block/basic/minheight-expected.png:
  • platform/qt/fast/block/basic/minheight-expected.txt:
  • platform/qt/fast/block/basic/percent-height-inside-anonymous-block-expected.png:
  • platform/qt/fast/block/basic/percent-height-inside-anonymous-block-expected.txt:
  • platform/qt/fast/block/basic/quirk-height-expected.png:
  • platform/qt/fast/block/basic/quirk-height-expected.txt:
  • platform/qt/fast/block/basic/truncation-rtl-expected.png:
  • platform/qt/fast/block/basic/truncation-rtl-expected.txt:
  • platform/qt/fast/block/basic/white-space-pre-wraps-expected.png:
  • platform/qt/fast/block/basic/white-space-pre-wraps-expected.txt:
13:22 Changeset [123518] by thakis@chromium.org

[chromium/mac] Add cursor resource pngs to the pak file.
https://bugs.webkit.org/show_bug.cgi?id=92148

Reviewed by Tony Chang.

Once https://chromiumcodereview.appspot.com/10817031/ has landed, they can be
removed from WebCore.gyp's mac_bundle_resources. Part of http://crbug.com/137588

  • WebKit.grd:
13:20 Changeset [123517] by caio.oliveira@openbossa.org

[Qt] svg/carto.net rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92152

Unreviewed.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/carto.net/window-expected.png: Removed.
  • platform/qt-5.0/svg/carto.net/window-expected.txt: Removed.
  • platform/qt/svg/carto.net/button-expected.png:
  • platform/qt/svg/carto.net/button-expected.txt:
  • platform/qt/svg/carto.net/colourpicker-expected.png:
  • platform/qt/svg/carto.net/colourpicker-expected.txt:
  • platform/qt/svg/carto.net/scrollbar-expected.png:
  • platform/qt/svg/carto.net/scrollbar-expected.txt:
  • platform/qt/svg/carto.net/selectionlist-expected.png:
  • platform/qt/svg/carto.net/selectionlist-expected.txt:
  • platform/qt/svg/carto.net/slider-expected.png:
  • platform/qt/svg/carto.net/slider-expected.txt:
  • platform/qt/svg/carto.net/tabgroup-expected.png:
  • platform/qt/svg/carto.net/tabgroup-expected.txt:
  • platform/qt/svg/carto.net/textbox-expected.png:
  • platform/qt/svg/carto.net/textbox-expected.txt:
  • platform/qt/svg/carto.net/window-expected.png:
  • platform/qt/svg/carto.net/window-expected.txt:
13:17 Changeset [123516] by jocelyn.turcotte@nokia.com

[Qt] Make sure that an AC sync is triggered when the canvas contents is updated.
https://bugs.webkit.org/show_bug.cgi?id=92128

Reviewed by Kenneth Rohde Christiansen.

This would cause missed frames when animating an accelerated 2D canvas without
touching the document.

  • WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):

13:15 Changeset [123515] by ap@apple.com

[Mac WK2] Improve text input logging
https://bugs.webkit.org/show_bug.cgi?id=92147

Reviewed by Andreas Kling.

  • UIProcess/API/mac/WKView.mm:

(-[WKView insertText:replacementRange:]):
(-[WKView keyUp:]):
(-[WKView keyDown:]):
(-[WKView flagsChanged:]):
(-[WKView _executeSavedKeypressCommands]):
(-[WKView _notifyInputContextAboutDiscardedComposition]):
(-[WKView _interpretKeyEvent:savingCommandsTo:WebCore::]):
(-[WKView _updateSecureInputState]):

13:11 Changeset [123514] by commit-queue@webkit.org

[Qt] platform, plugins and printing need rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92016

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-24
Reviewed by Alexis Menard.

Updating skipped tests inside platform, plugins and printing. The following tests
remain skipped:
/platform/qt/plugins/qt-qwidget-plugin.html (bug #92141)
/plugins/netscape-dom-access.html (already skipped inside qt/Skipped)

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/platform/qt/fast/forms/button-line-break-expected.png:
  • platform/qt/platform/qt/fast/forms/button-line-break-expected.txt:
  • platform/qt/platform/qt/plugins/application-plugin-plugins-disabled-expected.png: Added.
  • platform/qt/platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • platform/qt/platform/qt/plugins/qt-qwidget-plugin-expected.png: Added.
  • platform/qt/platform/qt/plugins/qt-qwidget-plugin-expected.txt:
  • platform/qt/plugins/iframe-plugin-bgcolor-expected.txt:
  • platform/qt/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/qt/printing/compositing-layer-printing-expected.png:
  • platform/qt/printing/compositing-layer-printing-expected.txt:
  • platform/qt/printing/iframe-print-expected.png:
  • platform/qt/printing/iframe-print-expected.txt:
  • platform/qt/printing/media-queries-print-expected.png:
  • platform/qt/printing/media-queries-print-expected.txt:
  • platform/qt/printing/page-rule-in-media-query-expected.png:
  • platform/qt/printing/page-rule-in-media-query-expected.txt:
  • platform/qt/printing/simultaneous-position-float-change-expected.txt:
  • platform/qt/printing/width-overflow-expected.png:
  • platform/qt/printing/width-overflow-expected.txt:
13:04 Changeset [123513] by jchaffraix@webkit.org

Merge 123062 - Crash in RenderTableSection::addCell.
http://webkit.org/b/89496

Reviewed by Abhishek Arya.

Source/WebCore:

The issue comes from RenderBox::splitAnonymousBoxesAroundChild that would move sections
across tables but didn't force the table to do a synchronous section recalc. This opened
the way for race conditions where we would query the table column structure while it's dirty
(this is not uncommon but as usually the table's column representation is always bigger or
more split than a section's, it's usually harmless).

The fix is to force a synchronous section recalc.

Test: fast/table/split-table-no-section-update-crash.html

  • rendering/RenderBox.cpp:

(WebCore::markBoxForRelayoutAfterSplit):
Changed to call forceSectionsRecalc ie force a section recalc.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::recalcSections):
Added missing ASSERT for unneeded calls.

  • rendering/RenderTable.h:

(WebCore::RenderTable::forceSectionsRecalc):
Added this helper function.

LayoutTests:

The test is still pretty complex as it involves lots of generated content. It should
be possible to get a smaller test case based on the conditions for the crash. However
this test is a pretty good stress test so I decided against creating a more simple test
case.

  • fast/table/split-table-no-section-update-crash-expected.txt: Added.
  • fast/table/split-table-no-section-update-crash.html: Added.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10809080

12:59 Changeset [123512] by mifenton@rim.com

Throttle calls to request the virtual keyboard be shown.
https://bugs.webkit.org/show_bug.cgi?id=92138

Reviewed by Rob Buis.

PR 178465.

Do not request keyboard visibility change when
we are actively processing an input event.

Reviewed Internally by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):

12:48 Changeset [123511] by leandrogracia@chromium.org

[Chromium] Enable conversion between WebFloatRect and gfx::RectF.
https://bugs.webkit.org/show_bug.cgi?id=92117

Reviewed by Adam Barth.

Introduce WebFloatRect <--> gfx::RectF conversion as we already do with WebRect <--> gfx::Rect.

  • chromium/public/WebFloatRect.h:

(WebKit::WebFloatRect::WebFloatRect):
(WebFloatRect):
(WebKit::WebFloatRect::operator=):
(WebKit::WebFloatRect::operator gfx::RectF):

12:47 Changeset [123510] by fpizlo@apple.com

REGRESSION(r123417): It made tests assert/crash on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=92088

Reviewed by Mark Hahnenberg.

The pointer arithmetic was wrong, because negative numbers are hard to think about.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::emitPutTransitionStub):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

12:45 Changeset [123509] by commit-queue@webkit.org

[EFL][WK2] Provide more useful output when an injected bundle cannot be loaded
https://bugs.webkit.org/show_bug.cgi?id=92136

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Call eina_error_get() in case an injected bundle cannot be
loaded in order to print more information about the error.

  • WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:

(WebKit::InjectedBundle::load):

12:40 Changeset [123508] by fmalita@chromium.org

Merge 122755 - SVGAnimationElement::currentValuesForValuesAnimation crash
https://bugs.webkit.org/show_bug.cgi?id=91326

Reviewed by Simon Fraser.

SVGSMILElement::progress() assumes that seekToIntervalCorrespondingToTime() always
lands inside a defined interval, but one can force arbitrary time offsets using
setCurrentTime(). This patch adds logic for handling non-interval time offsets
gracefully.

Source/WebCore:

Test: svg/animations/smil-setcurrenttime-crash.svg

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::progress):

LayoutTests:

  • svg/animations/smil-setcurrenttime-crash-expected.txt: Added.
  • svg/animations/smil-setcurrenttime-crash.svg: Added.

TBR=fmalita@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10802091

12:40 Changeset [123507] by peter@chromium.org

Android-chromium layout tests failing with GPU related crash
https://bugs.webkit.org/show_bug.cgi?id=92126

Reviewed by Adam Barth.

Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
as it's not being used by any port anymore, and neither is being passed
on to the test runner. Instead, append the flag directly to DRT for the
Chromium Android port, which does rely on this functionality.

The ChromiumAndroidUnitTest tests didn't catch this as the property was
set to True, but it's unable to detect whether they'll actually be used.
No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidPortTest.test_attributes):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

12:32 Changeset [123506] by commit-queue@webkit.org

[WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
https://bugs.webkit.org/show_bug.cgi?id=92107

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Fixes mouse click events in EventSenderProxyEfl.

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::dispatchMouseDownEvent):
(WTR::EventSenderProxy::dispatchEvent):

12:25 Changeset [123505] by paroga@webkit.org

Store the full year in GregorianDateTime
https://bugs.webkit.org/show_bug.cgi?id=92067

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Use the full year instead of the offset from year 1900
for the year member variable of GregorianDateTime.

  • runtime/DateConstructor.cpp:

(JSC::constructDate):
(JSC::dateUTC):

  • runtime/DateConversion.cpp:

(JSC::formatDate):
(JSC::formatDateUTCVariant):

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncSetYear):

  • runtime/JSDateMath.cpp:

(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):

Source/WebCore:

Use the full year instead of the offset from year 1900
for the year member variable of GregorianDateTime.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

Source/WTF:

Use the full year instead of the offset from year 1900
for the year member variable of GregorianDateTime.

  • wtf/GregorianDateTime.h:

(WTF::GregorianDateTime::operator tm):

12:12 Changeset [123504] by benjamin@webkit.org

Do not perform 8 to 16bits characters conversion when converting a WTFString to NSString/CFString
https://bugs.webkit.org/show_bug.cgi?id=90720

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-24
Reviewed by Geoffrey Garen.

In most String to CFString conversion, we should be able to use the "NoCopy" constructor and have
a relatively cheap conversion from WTF::String to CFString.

When the String is 8 bits, it was converted to 16 bits by getData16SlowCase() because of the call
to String::characters().

This patch adds a path for creating a CFString from a 8bits string using CFStringCreateWithBytes.

This is covered by existing tests.

  • platform/text/cf/StringCF.cpp:

(WTF::String::createCFString): CFSTR() create static CFString, it is unecessary to retain it.

  • platform/text/cf/StringImplCF.cpp:

(WTF::StringImpl::createCFString): The logic to avoid the StringWrapperCFAllocator has also been simplified.
The allocator creation is now closer to where it is useful.

12:03 Changeset [123503] by paroga@webkit.org

[WIN] Build fix after r123417.

11:55 Changeset [123502] by commit-queue@webkit.org

[Qt] Re-skip failing tests for Qt 4.8 platform
https://bugs.webkit.org/show_bug.cgi?id=92119

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-24
Reviewed by Alexis Menard.

The following tests, after unskipping, are now passing on Qt-5.0 build bot
variations, but still failing for Qt-4.8 ones:

Regressions: Unexpected text diff mismatch : (1)

http/tests/misc/acid3.html = TEXT

Regressions: Unexpected image mismatch : (2)

fast/css/tab-size.html = IMAGE
fast/text/international/bdi-dir-default-to-auto.html = IMAGE

This patch adds these to Skipped list of qt-4.8 platform.

  • platform/qt-4.8/Skipped: Added 3 layout tests.
11:43 Changeset [123501] by kareng@chromium.org

Merge 121510 - [Chromium] CTFontCopyTable of MacOSX10.5 SDK doesn't work for layout tables
https://bugs.webkit.org/show_bug.cgi?id=90235

Reviewed by Kent Tamura.

Use CGFontCopyTableForTag instead.

No new tests. css3/font-feature-settings-rendering.html should pass. I'll rebase expectations once bots get the result.

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp:

(WebCore::harfbuzzCoreTextGetTable):

TBR=bashi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10815078

11:42 Changeset [123500] by haraken@chromium.org

[V8] String wrappers should be marked Independent
https://bugs.webkit.org/show_bug.cgi?id=91251

Reviewed by Adam Barth.

Currently V8 String wrappers are not marked Independent.
By marking them Independent, they can be reclaimed by the scavenger GC.
Although I couldn't find a case where this change reduces memory usage,
this change would be important for upcoming changes in string conversion
between V8 and WebKit (https://bugs.webkit.org/show_bug.cgi?id=91850).

'm_lastStringImpl = 0' in StringCache::remove() is important.
Look at the following code:

static void cachedStringCallback(v8::Persistent<v8::Value> wrapper, void* parameter)
{

...;
stringCache()->remove(stringImpl);
wrapper.Dispose();

}

void StringCache::remove(StringImpl* stringImpl)
{

...
if (m_lastStringImpl.get() == stringImpl)

m_lastStringImpl = 0;

}

v8::Local<v8::String> v8ExternalString(StringImpl* stringImpl, v8::Isolate* isolate)
{

if (m_lastStringImpl.get() == stringImpl) {

return v8::Local<v8::String>::New(m_lastV8String); m_lastV8String points to a wrapper object that was accessed most recently.

}
return v8ExternalStringSlow(stringImpl, isolate);

}

Without 'm_lastStringImpl = 0', already disposed m_lastV8String can be used
in v8ExternalString(). This was a cause of the crashes of r122614.

Tests: At the initial commit of this patch (r122614),

the following tests had been broken due to missing 'm_lastStringImpl = 0'.
fast/workers/worker-location.html
Dromaeo/cssquery-jquery.html
Dromaeo/jslib-event-jquery.html
Dromaeo/jslib-style-jquery.html
Dromaeo/jslib-style-prototype.html

  • bindings/v8/V8Binding.cpp:

(WebCore::StringCache::remove):
(WebCore::StringCache::v8ExternalStringSlow):

11:33 Changeset [123499] by tommyw@google.com

MediaStream API: Update MediaStreamTrack to match the specification
https://bugs.webkit.org/show_bug.cgi?id=90180

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebMediaStreamDescriptor.h:

(WebMediaStreamDescriptor):

  • chromium/public/WebMediaStreamSource.h:

(WebMediaStreamSource):

Source/WebCore:

MediaStreamTracks are now required to show the status of the underlying source,
and trigger events when that status changes.

Test: fast/mediastream/MediaStreamTrack.html

  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::setEnabled):
(WebCore::MediaStreamTrack::readyState):
(WebCore):
(WebCore::MediaStreamTrack::sourceChangedState):
(WebCore::MediaStreamTrack::stop):
(WebCore::MediaStreamTrack::interfaceName):
(WebCore::MediaStreamTrack::scriptExecutionContext):
(WebCore::MediaStreamTrack::eventTargetData):
(WebCore::MediaStreamTrack::ensureEventTargetData):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/EventTargetFactory.in:
  • platform/chromium/support/WebMediaStreamDescriptor.cpp:
  • platform/chromium/support/WebMediaStreamSource.cpp:

(WebKit::WebMediaStreamSource::setReadyState):
(WebKit):
(WebKit::WebMediaStreamSource::readyState):

  • platform/mediastream/MediaStreamSource.cpp: Copied from Source/WebCore/platform/mediastream/MediaStreamSource.h.

(WebCore):
(WebCore::MediaStreamSource::create):
(WebCore::MediaStreamSource::MediaStreamSource):
(WebCore::MediaStreamSource::setReadyState):
(WebCore::MediaStreamSource::addObserver):
(WebCore::MediaStreamSource::removeObserver):

  • platform/mediastream/MediaStreamSource.h:

(Observer):
(WebCore::MediaStreamSource::Observer::~Observer):
(MediaStreamSource):
(WebCore::MediaStreamSource::readyState):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::queryMediaStreamSources):
(WebCore::MediaStreamCenterChromium::didCreateMediaStream):

Tools:

Adding a Mock WebMediaStreamCenter to enable better LayoutTests.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::createMediaStreamCenter):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.

(WebKit):
(WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
(WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
(WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
(WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
(WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
(WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
(WebKit::MockWebMediaStreamCenter::constructSDP):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.

(WebKit):
(MockWebMediaStreamCenter):
(WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):

LayoutTests:

  • fast/mediastream/MediaStreamTrack-expected.txt: Added.
  • fast/mediastream/MediaStreamTrack.html: Added.
11:30 Changeset [123498] by rniwa@webkit.org

Fix regressions in replay performance tests
https://bugs.webkit.org/show_bug.cgi?id=92052

Reviewed by Dirk Pranke.

Fix regression that accumulated over time to make replay tests work again.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::willSendRequest): Use the main document URL in the request since the main frame's
URL hadn't been updated yet When requesting a new URL on the main frame.

  • Scripts/webkitpy/performance_tests/perftest.py:

(ReplayServer.wait_until_ready): Waiting for 6 seconds (3 tries) seems enough.
(ReplayPerfTest.prepare): Pass self._archive_path to run_signle as that is the current contract.
(ReplayPerfTest.run_single): Use the archive path to generate -expected.png path.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestReplayPerfTest.test_run_single):
(TestReplayPerfTest.test_prepare):
(TestReplayPerfTest.test_prepare_calls_run_single.run_single):
(TestReplayPerfTest):

11:25 Changeset [123497] by atwilson@chromium.org

Unreviewed expectations change for chromium to address lint error from r90190.

  • platform/chromium/TestExpectations:
11:23 Changeset [123496] by tony@chromium.org

Use native (non-cygwin) binaries for perl, gperf, and bison in Chromium
https://bugs.webkit.org/show_bug.cgi?id=91667

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-24
Reviewed by Tony Chang.

Using native tools instead of cygwin version improves build time
performance by roughly 50% (on top of previous cl-instead-of-gcc
change).

Also, use - instead of / for cl flags, otherwise preprocessing fails
very slowly (due to retry loop). And, replace \ with / in gperf
command line. Without this, gperf emits the filename literally in
#line directives which causes VS to error with "unescaped \ in
string". Bizarrely, building ColorData.cpp with those \ in place
causes the IDE to exit with no error message, which was the cause of
the previous canary failures.

No new tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_bison.py:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

  • make-hash-tools.pl:
11:17 Changeset [123495] by dcheng@chromium.org

Files from drag and file <input> should use getMIMETypeForExtension to determine content type.
https://bugs.webkit.org/show_bug.cgi?id=91702

Reviewed by Jian Li.

Awhile back, we changed File to only use getWellKnownMIMETypeForExtension to prevent web
pages from being able to detect what applications a user has installed indirectly through
the MIME types. However, some sites like YouTube's drag and drop uploader use MIME types
that aren't in WebKit's internal list, so we relax the restriction for Files that originate
from an user action.

  • fileapi/File.cpp:

(WebCore::getContentTypeFromFileName):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):
(WebCore::createBlobDataForFileWithMetadata):
(WebCore::File::createWithRelativePath):
(WebCore::File::File):

  • fileapi/File.h:

(File):
(WebCore::File::create):
(WebCore::File::createWithName):

  • html/FileInputType.cpp:

(WebCore::FileInputType::createFileList):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::addFilename):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::files):

  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::files):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::files):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::files):

11:05 Changeset [123494] by vsevik@chromium.org

Web Inspector: Snippets UI polish
https://bugs.webkit.org/show_bug.cgi?id=92142

Reviewed by Pavel Feldman.

Changed snippets context menu items.
Added run snippet status bar button.
Removed unused edit source button.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.SnippetJavaScriptSourceFrame):
(WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.SnippetsNavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.statusBarItems):

  • inspector/front-end/inspector.css:
  • inspector/front-end/scriptsPanel.css:

(.evaluate-snippet-status-bar-item .glyph):
(.evaluate-snippet-status-bar-item.toggled .glyph):

10:47 Changeset [123493] by thakis@chromium.org

[chromium/mac] Remove webcore_resource_files from WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=92129

Reviewed by Adam Barth.

It was added in http://trac.webkit.org/changeset/81706/trunk/Source/WebCore/WebCore.gypi .
The changes in that revision were mostly reverted in http://trac.webkit.org/changeset/119921 ,
but this block was forgotten. Since it just confused me for a bit, remove it.

  • WebCore.gyp/WebCore.gyp:
10:44 Changeset [123492] by jchaffraix@webkit.org

inline-table wrapper should be generated for display: inline element only
https://bugs.webkit.org/show_bug.cgi?id=92054

Reviewed by Abhishek Arya.

Source/WebCore:

CSS 2.1 only takes into account the display when determining if we should generate
an inline-table. My misreading of the spec would make us generate an inline-table
wrapper for any inline formatting context.

Test: fast/table/inline-block-generates-table-wrapper.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::createAnonymousWithParentRenderer):
Changed to use display instead of isInline to properly match the spec.

LayoutTests:

For some reason, using dumpAsText didn't dump the 2 lines properly so the test
is a reftest to work-around that.

  • fast/table/inline-block-generates-table-wrapper-expected.html: Added.
  • fast/table/inline-block-generates-table-wrapper.html: Added.
10:19 Changeset [123491] by commit-queue@webkit.org

Unreviewed, rolling out r123472.
http://trac.webkit.org/changeset/123472
https://bugs.webkit.org/show_bug.cgi?id=92134

Revert roll to v8 version that crashes sporadically (Requested
by atwilson on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

  • DEPS:
10:16 Changeset [123490] by commit-queue@webkit.org

[chromium] Unskip tests in fast/hidpi
https://bugs.webkit.org/show_bug.cgi?id=90190

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-07-24
Reviewed by Adam Barth.

Adding cr-linux baselines so that the EWS will go green. Will be adding new
baselines for the chromium ports with WebKit gardener atwilson@.

  • platform/chromium-linux/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/device-scale-factor-paint-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/focus-rings-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-as-background-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-as-background-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-background-dynamic-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-background-repeat-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-background-repeat-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-background-repeat-without-size-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-background-repeat-without-size-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-border-image-comparison-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-border-image-comparison-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-border-image-simple-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-border-image-simple-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-out-of-order-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-out-of-order-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-simple-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-simple-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/image-set-without-specified-width-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/image-set-without-specified-width-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/resize-corner-hidpi-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
  • platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
  • platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
  • platform/chromium/TestExpectations:
10:11 Changeset [123489] by commit-queue@webkit.org

IndexedDB: Temporarily continue generating backend keys for empty key lists
https://bugs.webkit.org/show_bug.cgi?id=92012

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-24
Reviewed by Tony Chang.

Temporarily change key behavior to allow chromium in_process_webkit
to call putWithIndexKeys without inadvertently preventing index
key generation. Note this is temporary until frontend key generation
patch lands.

No new tests, this is part of a refactor that doesn't change behavior.

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):

10:09 Changeset [123488] by pfeldman@chromium.org

Web Inspector: introduce UISourceCodeFrame.
https://bugs.webkit.org/show_bug.cgi?id=92124

Reviewed by Vsevolod Vlasov.

Generic implementation of SourceFrame over UISourceCode added.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._createSourceFrame):

  • inspector/front-end/StylesPanel.js:
  • inspector/front-end/UISourceCodeFrame.js: Added.

(WebInspector.UISourceCodeFrame):
(WebInspector.UISourceCodeFrame.prototype.canEditSource):
(WebInspector.UISourceCodeFrame.prototype.commitEditing):
(WebInspector.UISourceCodeFrame.prototype.afterTextChanged):
(WebInspector.UISourceCodeFrame.prototype._didEditContent):
(WebInspector.UISourceCodeFrame.prototype._onContentChanged):
(WebInspector.UISourceCodeFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
10:05 Changeset [123487] by commit-queue@webkit.org

[BlackBerry] Update about:config lists
https://bugs.webkit.org/show_bug.cgi?id=92118

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-24
Reviewed by Rob Buis.

We want to have all flags which could be used / have been used by any platform. These lists were created by running:

  • WebCoreSupport/AboutDataEnableFeatures.in: git grep "ENABLE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u
  • WebCoreSupport/AboutDataHaveFeatures.in: git grep "HAVE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u
  • WebCoreSupport/AboutDataUseFeatures.in: git grep "USE(" | cut -d "(" -f2 | cut -d ")" -f1 | sort -u
09:17 Changeset [123486] by mitz@apple.com

<rdar://problem/11945102> REGRESSION (r109451): Overlay scrollbars always use the default style, regardless of background color
https://bugs.webkit.org/show_bug.cgi?id=92115

Reviewed by Mark Rowe.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::scrollbarOverlayStyle): Reversed an incorrect null check.

09:13 WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
09:00 Changeset [123485] by atwilson@chromium.org

Another prospective build fix for Chromium. Unreviewed.

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:
08:51 Changeset [123484] by commit-queue@webkit.org

[BlackBerry] Remove unused variable in BackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=91987

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-24
Reviewed by Antonio Gomes.

PR: 141439
This is done as part of some general BackingStorePrivate::render()
cleanup in PR 141439.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):

08:44 Changeset [123483] by commit-queue@webkit.org

[chromium] Add pixel expectations for new test scrollbar-tickmarks-styled.html
https://bugs.webkit.org/show_bug.cgi?id=92116

Unreviewed.

Patch by Nico Weber <nicolasweber@gmx.de> on 2012-07-24

  • platform/chromium-win/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Added.
  • platform/chromium/TestExpectations:
08:40 Changeset [123482] by commit-queue@webkit.org

[EFL][WK2] Add vibration client
https://bugs.webkit.org/show_bug.cgi?id=91371

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-24
Reviewed by Antonio Gomes.

Implement Vibration provider for WebKit2 EFL and add an API to set
vibration client callbacks by application to handle the tactile
feedback in the application when the page content ask for vibration.

  • CMakeLists.txt: Add WebCore/Modules/vibration to include path.
  • PlatformEfl.cmake: Add VibrationProvider.cpp file to the build

system.

  • UIProcess/API/efl/VibrationProvider.cpp: Added.

(_Ewk_Vibration_Client): Structure contains the vibration client
callbacks.
(_Ewk_Vibration_Client::_Ewk_Vibration_Client):
(toVibrationProvider): Helper function to cast the clientinfo to
VibrationProvider.
(vibrateCallback):
(cancelVibrationCallback):
(VibrationProvider::create):
(VibrationProvider::VibrationProvider):
(VibrationProvider::~VibrationProvider):
(VibrationProvider::vibrate):
(VibrationProvider::cancelVibration):
(VibrationProvider::setVibrationClientCallbacks):

  • UIProcess/API/efl/VibrationProvider.h: Added.

(VibrationProvider):

  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Context):
(createDefaultEwkContext):
(ewk_context_vibration_client_callbacks_set): API to set vibration
client callbacks.

  • UIProcess/API/efl/ewk_context.h:
08:38 Changeset [123481] by commit-queue@webkit.org

[EFL] Gardening of failing and flaky tests
https://bugs.webkit.org/show_bug.cgi?id=92105

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-24

  • platform/efl/TestExpectations:
08:37 Changeset [123480] by atwilson@chromium.org

Unreviewed prospective build fix for Chromium. Changed include of hb.h in HarfBuzzNGFace.h

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:
08:31 Changeset [123479] by keishi@webkit.org

[Chromium] Page popup should close on mouse down
https://bugs.webkit.org/show_bug.cgi?id=92092

Reviewed by Kent Tamura.

Page popup should close on mouse down because some elements(e.g. <input type=color>) don't have a blur event that
we can hook to hide the page popup when the user clicks on the page.

  • src/WebPagePopupImpl.h:

(WebKit::WebPagePopupImpl::hasSamePopupClient): Returns true if the given WebPagePopupImpl have the same popup client.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseDown): Close all popups when the page is clicked. Checks if the
mouse down event opened the same popup we just closed.

08:25 Changeset [123478] by commit-queue@webkit.org

[Qt] Unskip layout test after monospace-font fix
https://bugs.webkit.org/show_bug.cgi?id=86179

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-24
Reviewed by Alexis Menard.

This test has been skipped because monospace fonts weren't properly to
HTML tags like <pre>, for instance. After r121971, the test results are
normal again.

  • platform/qt/Skipped: Unskipped fast/css/tab-size.html.
07:58 Changeset [123477] by lforschler@apple.com

Versioning.

07:47 Changeset [123476] by ossy@webkit.org

[Qt] Fix compilation after QtQuick API changes
https://bugs.webkit.org/show_bug.cgi?id=91822

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

QQuickCanvas is now QQuickWindow, QQuickItem::canvas() is window() and rootItem()
is contentItem(). Also QQuickWindow::grabFrameBuffer() is now grabWindow().

  • UIProcess/API/qt/qquickwebpage.cpp:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::updateIcon):

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView::multipleWebViews):
(tst_QQuickWebView::basicRenderingSanity):
(tst_QQuickWebView::transparentWebViews):

  • UIProcess/API/qt/tests/testwindow.h:

(TestWindow::TestWindow):

  • UIProcess/qt/QtPageClient.cpp:

(WebKit::QtPageClient::isViewVisible):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::startDrag):

07:40 Changeset [123475] by commit-queue@webkit.org

HarfBuzzFaceNG.h forward declarations conflict with newer versions of Harfbuzz
https://bugs.webkit.org/show_bug.cgi?id=92103

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-24
Reviewed by Philippe Normand.

As preparation for enabling harfbuzz-ng for EFL, I would like to include the header
here since the forward declarations are conflicting with the harfbuzz version
we will use for EFL.

No new tests, no change in behavior.

  • platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h:
07:33 Changeset [123474] by commit-queue@webkit.org

[Qt] Updated acid3 layout test results after monospace fix
https://bugs.webkit.org/show_bug.cgi?id=87501

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-24
Reviewed by Alexis Menard.

Updated Qt (same for WK1 and WK2) layout test results for
http/tests/misc/acid3.html after monospace font fix landed in r121971.

  • platform/qt/Skipped: Unskip http/tests/misc/acid3.html.
  • platform/qt/http/tests/misc/acid3-expected.png: Added.
  • platform/qt/http/tests/misc/acid3-expected.txt: Added.
07:17 Changeset [123473] by commit-queue@webkit.org

[Qt] Unskip layout test after monospace-font fix
https://bugs.webkit.org/show_bug.cgi?id=81899

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-24
Reviewed by Alexis Menard.

This test has been skipped because monospace fonts weren't properly used by
layout tests. After r121971, the test results are normal again.

  • platform/qt/Skipped: Unskipped layout test.
07:07 Changeset [123472] by jochen@chromium.org

Unreviewed. Rolled DEPS.

  • DEPS:
06:50 Changeset [123471] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening after r123100. Added baseline to tests that have been unskipped.
https://bugs.webkit.org/show_bug.cgi?id=91739

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-24

  • platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
  • platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
  • platform/qt-5.0/fast/events/onload-re-entry-expected.png: Added.
  • platform/qt-5.0/fast/events/onload-re-entry-expected.txt: Added.
  • platform/qt-5.0/fast/events/touch/touch-slider-expected.txt: Added.
  • platform/qt-5.0/fast/events/touch/touch-slider-no-js-touch-listener-expected.txt: Added.
  • platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
  • platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
06:42 Changeset [123470] by commit-queue@webkit.org

Unreviewed, rolling out r123463.
http://trac.webkit.org/changeset/123463
https://bugs.webkit.org/show_bug.cgi?id=92110

Broke Android build (Requested by keishi on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-24

  • src/WebPagePopupImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseDown):

06:41 Changeset [123469] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening after r123432. Added baseline to fast/text/whitespace/028.html
after is has been unskipped.
https://bugs.webkit.org/show_bug.cgi?id=91971

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-24

  • platform/qt.5-0/fast/text/whitespace/028-expected.png: Added.
  • platform/qt.5-0/fast/text/whitespace/028-expected.txt: Added.
06:40 Changeset [123468] by rniwa@webkit.org

Add some Japanese and Swedish websites to replay tests
https://bugs.webkit.org/show_bug.cgi?id=92076

Reviewed by Andreas Kling.

Added new replay tests as follows.

  • Replay/Japanese: Added.
  • Replay/Japanese/2ch.net-newsplus.replay: Added.
  • Replay/Japanese/ja.wikipedia.org.replay: Added.
  • Replay/Japanese/www.livedoor.com.replay: Added.
  • Replay/Japanese/www.rakuten.co.jp.replay: Added.
  • Replay/Japanese/www.yahoo.co.jp.replay: Added.
  • Replay/Swedish: Added.
  • Replay/Swedish/www.flashback.se.replay: Added.
  • Replay/Swedish/www.tradera.com.replay: Added.
  • Replay/www.techcrunch.com.replay: Added.
06:37 Changeset [123467] by allan.jensen@nokia.com

Fix blend filter for autovectorizing
https://bugs.webkit.org/show_bug.cgi?id=91398

Reviewed by Nikolas Zimmermann.

To support auto-vectorizing, the loop had to be unswitched, and regular arrays used that
did not do boundary-checks in the inner loop. Finally the integer division by 255
was optimized not use integer division intrinsics.

On a X86-64 architechture using GCC -O3 on the file, this gives a speed-up of 2.9x.

  • platform/graphics/filters/FEBlend.cpp:

(WebCore::fastDivideBy255):
(BlendNormal):
(WebCore::BlendNormal::apply):
(BlendMultiply):
(WebCore::BlendMultiply::apply):
(BlendScreen):
(WebCore::BlendScreen::apply):
(BlendDarken):
(WebCore::BlendDarken::apply):
(BlendLighten):
(WebCore::BlendLighten::apply):
(BlendUnknown):
(WebCore::BlendUnknown::apply):
(WebCore::platformApply):
(WebCore::FEBlend::platformApplyGeneric):
(WebCore::FEBlend::platformApplySoftware):

  • platform/graphics/filters/FEBlend.h:

(FEBlend):

06:33 Changeset [123466] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening. Update expectations after r122988 and r122712.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-24

  • platform/qt-5.0-wk2/editing/deleting/5144139-2-expected.txt: Added after r122712.
  • platform/qt-5.0/editing/deleting/5144139-2-expected.txt: Removed.
  • platform/qt-5.0/http/tests/misc/location-replace-crossdomain-expected.png: Added after r122988.
  • platform/qt-5.0/http/tests/misc/location-replace-crossdomain-expected.txt: Added after r122988.
  • platform/qt-5.0/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added after r122988.
  • platform/qt-5.0/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added after r122988.
06:24 Changeset [123465] by hausmann@webkit.org

[Qt] MSVC: unresolved external symbol DllMainCRTStartup@12
https://bugs.webkit.org/show_bug.cgi?id=91229

Reviewed by Jocelyn Turcotte.

In order to successfully link a DLL on Windows we need to have at least
one object file (or compilation unit). The forward export header files were
supposed to be that, but unfortunately the rule in win32/default_post.prf for
creating the header files had some bugs, among others that it did an exists()
check on the depending static library. At the time qmake is ran those libraries
do not exist yet and therefore the corresponding extra compiler rules were never
created, resulting in empty OBJECTS/SOURCES.

Even without such an exists() check, qmake extra compilers require the files
referred to in the .input variable to exist at qmake time. In this case the input
files were the static libraries, which do not exist yet.

This patch solves this by using a qmake extra target instead of extra
compiler, which does not have this limitation. The target is referenced
through the extension of GENERATED_SOURCES.

The patch also adds a d/_debug suffix for debug builds, do allow for separate
symbol exports if necessary.

  • Scripts/generate-win32-export-forwards: Support multiple input files, i.e.

consider the last argument to be the output file and everything else input.

  • qmake/mkspecs/features/win32/default_post.prf:
06:14 Changeset [123464] by kbalazs@webkit.org

[Qt] Add quirks for running the web process in a profiler shell, like valgrind
https://bugs.webkit.org/show_bug.cgi?id=87672

Reviewed by Jocelyn Turcotte.

Source/WebKit2:

If environment variables QT_WEBKIT_WEB_PROCESS_COMMAND_PREFIX
and/or QT_WEBKIT_PLUGIN_PROCESS_COMMAND_PREFIX are set, use their
values as the prefix of the command when launching the child process.
Example usage:

export QT_WEB_PROCESS_COMMAND_PREFIX="valgrind --smc-check=all"
./MiniBrowser http://somepage.html
./WebKitTestRunner --no-timeout-at-all some_layouttest.html

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

Tools:

Add --no-timeout-at-all command line switch to not time out no matter how
long the web process does it's job. --no-timeout is not enough for profiling
purposes because it only affects the timeout when we are waiting for the end
of the test. We use another timeout to control how much we wait for the web
process to initialize before and reset after the test and it could also easily
expire when running under valgrind. We should keep the behavior of --no-timeout
to not disable this timout check because --no-timeout is used by performace tests
and those should not wait for the web process to initialize and reset more than
normal tests.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runUntil):

  • WebKitTestRunner/TestController.h:
05:38 Changeset [123463] by keishi@webkit.org

[Chromium] Page popup should close on mouse down
https://bugs.webkit.org/show_bug.cgi?id=92092

Reviewed by Kent Tamura.

Page popup should close on mouse down because some elements(e.g. <input type=color>) don't have a blur event that
we can hook to hide the page popup when the user clicks on the page.

  • src/WebPagePopupImpl.h:

(WebKit::WebPagePopupImpl::hasSamePopupClient): Returns true if the given WebPagePopupImpl have the same popup client.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseDown): Close all popups when the page is clicked. Checks if the
mouse down event opened the same popup we just closed.

05:26 Changeset [123462] by caio.oliveira@openbossa.org

[Qt] fast/css/text-transform-select.html should be rebaselined for WK1 and WK2 on Qt 5.0
https://bugs.webkit.org/show_bug.cgi?id=77377

Reviewed by Simon Hausmann.

Test now pass in both WK1 and WK2.

  • platform/qt-5.0/Skipped:
05:25 Changeset [123461] by hans@chromium.org

Speech JavaScript API: Add the SpeechRecognitionResult.emma attribute
https://bugs.webkit.org/show_bug.cgi?id=91743

Reviewed by Adam Barth.

Source/WebCore:

Implement the 'emma' attribute as described in the spec draft at
http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html

Test: fast/speech/scripted/emma.html

  • Modules/speech/SpeechRecognitionResult.cpp:

(WebCore::SpeechRecognitionResult::~SpeechRecognitionResult):
(WebCore):
(WebCore::SpeechRecognitionResult::emma):

  • Modules/speech/SpeechRecognitionResult.h:

(WebCore):
(SpeechRecognitionResult):

  • Modules/speech/SpeechRecognitionResult.idl:
  • WebCore.gypi:
  • bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp:

(WebCore):
(WebCore::V8SpeechRecognitionResult::visitDOMWrapper):

We need to add an implicit reference from the result object to the
emma object to keep the latters DOM tree alive across
garbage-collection.

LayoutTests:

Add layout test for the SpeechRecognitionResult.emma attribute.

  • fast/speech/scripted/emma.html: Added.
  • fast/speech/scripted/emma-expected.txt: Added.
05:09 Changeset [123460] by zandobersek@gmail.com

Unreviewed GTK gardening.

Skipping tests added in r123343 and adding a test expectation for
an accessibility test added in r123428.

  • platform/gtk/TestExpectations:
05:00 Changeset [123459] by commit-queue@webkit.org

Web Inspector: Protocol Extension: add getFlowByName command
https://bugs.webkit.org/show_bug.cgi?id=91855

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-07-24
Reviewed by Pavel Feldman.

Source/WebCore:

The "getFlowByName" command should return a NamedFlow for a given document and name.

Test: inspector/styles/protocol-css-regions-commands.html

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayload):

LayoutTests:

Created a single test suite for the WebInspector protocol extension for CSS Regions.

  • inspector/styles/protocol-css-regions-commands-expected.txt: Added.
  • inspector/styles/protocol-css-regions-commands.html: Added.
  • inspector/styles/protocol-getNamedFlowCollection-command-expected.txt: Removed.
  • inspector/styles/protocol-getNamedFlowCollection-command.html: Removed.
  • platform/efl/TestExpectations:
  • platform/qt/Skipped:
04:48 Changeset [123458] by pierre.rossi@gmail.com

[Qt][WK1] color input type support
https://bugs.webkit.org/show_bug.cgi?id=91998

Reviewed by Simon Hausmann.

Using QColorDialog. This is private for now, but
it could be exposed via a virtual function in
QWebPage at a later point in a Qt 5 minor release
if there are requests for that.

  • Api/qwebpage.cpp:

(QWebPagePrivate::colorSelectionRequested):

  • Api/qwebpage_p.h:

(QWebPagePrivate):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::createColorChooser):

04:37 Changeset [123457] by peter@chromium.org

[Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
https://bugs.webkit.org/show_bug.cgi?id=92097

Unreviewed build fix.

WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
but TestDelegate.h forward declares it as a class.

  • DumpRenderTree/chromium/TestRunner/TestDelegate.h:

(WebKit):

04:33 Changeset [123456] by hausmann@webkit.org

[Qt] Fix compilation against namespaced Qt

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-07-23
Reviewed by Simon Hausmann.

Source/WebCore:

  • platform/graphics/Font.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/qt/ThirdPartyCookiesQt.h:

Source/WebKit/qt:

  • WebCoreSupport/GeolocationClientQt.h:
  • examples/platformplugin/WebPlugin.h:

Source/WebKit2:

  • Platform/CoreIPC/Connection.h:
  • Platform/PlatformProcessIdentifier.h:
  • Platform/WorkQueue.h:
  • Shared/qt/QtNetworkRequestData.h:
  • Shared/qt/WebEventFactoryQt.h:
  • UIProcess/API/C/qt/WKNativeEvent.h:
  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/API/qt/qwebnavigationhistory_p.h:
  • UIProcess/API/qt/raw/qrawwebview_p.h:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/Launcher/ThreadLauncher.h:
  • UIProcess/LayerTreeCoordinatorProxy.h:
  • UIProcess/qt/QtViewportHandler.h:
  • UIProcess/qt/QtWebPageSGNode.h:
  • UIProcess/qt/WebColorChooserProxyQt.h:
  • UIProcess/qt/WebGeolocationProviderQt.h:
  • UIProcess/qt/WebPopupMenuProxyQt.h:
  • WebProcess/WebProcess.h:

Tools:

  • QtTestBrowser/launcherwindow.h:
  • WebKitTestRunner/PlatformWebView.h:
04:23 Changeset [123455] by peter@chromium.org

Update a few Chromium Android contributors in committers.py
https://bugs.webkit.org/show_bug.cgi?id=92090

Reviewed by Kent Tamura.

Add Sami Kyostila, who has been doing significant work on Chromium's
compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and
remove John Grabowski who changed projects, and add my webkit.org alias.

  • Scripts/webkitpy/common/config/committers.py:
04:18 Changeset [123454] by commit-queue@webkit.org

[EFL][WK2] Remove unneeded WebURLRequestEfl and WebURLResponseEfl
https://bugs.webkit.org/show_bug.cgi?id=92087

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Remove WebURLRequestEfl and WebURLResponseEfl classes
and their corresponding C APIs since we don't need / use
them.

  • Shared/API/c/efl/WKURLRequestEfl.cpp: Removed.
  • Shared/API/c/efl/WKURLRequestEfl.h: Removed.
  • Shared/API/c/efl/WKURLResponseEfl.cpp: Removed.
  • Shared/API/c/efl/WKURLResponseEfl.h: Removed.
  • Shared/efl/WebURLRequestEfl.cpp: Removed.
  • Shared/efl/WebURLRequestEfl.h: Removed.
  • Shared/efl/WebURLResponseEfl.cpp: Removed.
  • Shared/efl/WebURLResponseEfl.h: Removed.
  • UIProcess/API/efl/ewk_url_request.cpp:
04:08 Changeset [123453] by pierre.rossi@gmail.com

[Qt] Enable touch slider when touch events are enabled
https://bugs.webkit.org/show_bug.cgi?id=91013

Reviewed by Kenneth Rohde Christiansen.

TOUCH_SLIDER guards are used in WebCore, so we should really
be setting the corresponding ENABLE define in features.prf.

Source/WebKit2:

  • Target.pri:

Tools:

  • qmake/mkspecs/features/features.prf:
03:33 Changeset [123452] by commit-queue@webkit.org

Web Inspector [JSC]: Enable initiator column in network panel.
https://bugs.webkit.org/show_bug.cgi?id=65533

Patch by Anthony Scian <ascian@rim.com> on 2012-07-24
Reviewed by Vsevolod Vlasov.

Source/WebCore:

With 40118 fixed for webkit, Preferences.displayInitiator should be set to true.
Removed references to it since the optionality is no longer required.

Test: http/tests/inspector/network/network-initiator.html

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshRequest):

  • inspector/front-end/Settings.js:

Source/WebKit/chromium:

With 40118 fixed for webkit, Preferences.displayInitiator should be set to true.
Removed references to it since the optionality is no longer required.

Test: http/tests/inspector/network/network-initiator.html

  • src/js/DevTools.js:

LayoutTests:

Bug https://bugs.webkit.org/show_bug.cgi?id=65105 caused
network-initiator.html to be disabled due to caching CSS information.
Tweaked the test so that reloads could be forced to avoid the cache
copy (thanks to Vsevolod Vlasov for help on this); test works now and
is updated for availability of stack traces fixed in 40118. Consolidated
results into common expected results output.

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.hardReloadPage):
(initialize_InspectorTest.InspectorTest.reloadPage):
(initialize_InspectorTest.InspectorTest._innerReloadPage):

  • http/tests/inspector/network/network-initiator-expected.txt:
  • http/tests/inspector/network/network-initiator.html:
  • platform/chromium/TestExpectations:
  • platform/chromium/http/tests/inspector/network/network-initiated-expected.txt: Removed.
  • platform/mac/TestExpectations:
03:27 Changeset [123451] by gyuyoung.kim@samsung.com

Missing *explicit* keyword in dom and page.
https://bugs.webkit.org/show_bug.cgi?id=92074

Reviewed by Kentaro Hara.

Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.

Some files in dom directory can't use explicit keyword because of build breaks.

No new tests. Covered by existing tests.

  • dom/BeforeLoadEvent.h:

(WebCore::BeforeLoadEvent::BeforeLoadEvent):

  • dom/BeforeTextInsertedEvent.h:

(BeforeTextInsertedEvent):

  • dom/ChildListMutationScope.h:

(WebCore::ChildListMutationScope::ChildListMutationScope):

  • dom/ChildNodeList.h:

(ChildNodeList):

  • dom/ClientRect.h:

(ClientRect):

  • dom/ClientRectList.h:

(ClientRectList):

  • dom/ComposedShadowTreeWalker.h:

(ComposedShadowTreeParentWalker):

  • dom/DOMCoreException.h:

(WebCore::DOMCoreException::DOMCoreException):

  • dom/DOMImplementation.h:

(DOMImplementation):

  • dom/DatasetDOMStringMap.h:

(WebCore::DatasetDOMStringMap::DatasetDOMStringMap):

  • dom/DeviceMotionController.h:

(DeviceMotionController):

  • dom/DeviceOrientationController.h:

(DeviceOrientationController):

  • dom/DocumentParser.h:

(DocumentParser):

  • dom/EventException.h:

(WebCore::EventException::EventException):

  • dom/EventListener.h:

(WebCore::EventListener::EventListener):

  • dom/ExceptionBase.h:

(ExceptionBase):

  • dom/GenericEventQueue.h:

(GenericEventQueue):

  • dom/KeyboardEvent.h:

(WebCore::KeypressCommand::KeypressCommand):

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryObjectInfo::MemoryObjectInfo):

  • dom/MessageChannel.h:

(MessageChannel):

  • dom/MessagePort.h:

(MessagePort):

  • dom/MessagePortChannel.h:

(MessagePortChannel):

  • dom/MutationObserver.h:
  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::NamedNodeMap):

  • dom/NodeFilter.h:

(WebCore::NodeFilter::NodeFilter):

  • dom/NodeWithIndex.h:

(WebCore::NodeWithIndex::NodeWithIndex):

  • dom/Range.h:
  • dom/RangeException.h:

(WebCore::RangeException::RangeException):

  • dom/RawDataDocumentParser.h:

(WebCore::RawDataDocumentParser::RawDataDocumentParser):

  • dom/ScriptRunner.h:

(ScriptRunner):

  • dom/SelectorQuery.h:

(SelectorQuery):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/SpaceSplitString.h:

(SpaceSplitStringData):

  • dom/StaticHashSetNodeList.h:

(StaticHashSetNodeList):

  • dom/StaticNodeList.h:

(WebCore::StaticNodeList::StaticNodeList):

  • dom/TransformSource.h:

(TransformSource):

  • dom/TreeScope.h:

(TreeScope):

  • dom/WebKitNamedFlowCollection.h:

(WebKitNamedFlowCollection):

  • page/EventHandler.h:

(EventHandler):

  • page/FocusController.h:

(FocusController):

  • page/FrameView.h:

(FrameView):

  • page/MemoryInfo.h:

(MemoryInfo):

  • page/Page.h:

(Page):

  • page/PageGroup.h:

(PageGroup):

  • page/PrintContext.h:

(PrintContext):

  • page/Settings.h:

(Settings):

  • page/SpeechInput.h:

(SpeechInput):

  • page/SpeechInputResultList.h:

(SpeechInputResultList):

  • page/WebKitAnimation.h:
  • page/WindowFeatures.h:

(WindowFeatures):

  • page/WorkerNavigator.h:

(WorkerNavigator):

03:27 Changeset [123450] by ryuan.choi@samsung.com

[EFL] EWebLauncher should not require config.h in the style check
https://bugs.webkit.org/show_bug.cgi?id=92070

Reviewed by Kentaro Hara.

  • Scripts/webkitpy/style/checker.py:

Remove the include rules from the style-check for EWebLauncher because
EWebLauncher is simple EFL application.

03:23 Changeset [123449] by jochen@chromium.or

[Chromium] EventSender shouldn't know about TestShell
https://bugs.webkit.org/show_bug.cgi?id=91449

Reviewed by Adam Barth.

Original patch by Adam Barth.

This patch removes the dependency from EventSender to TestShell. Most
of EventSender works directly with a WebView, but there are a handful
of references to WebViewHost. We don't want to re-use WebViewHost in
ContentShell because we want to use the multi-process embedding
environment for WebViews.

To avoid the dependency on WebViewHost, this patch introduces
TestDelegate, which is an abstract base class for WebViewHost. In
ContentShell, we'll need another object to implement these functions.

  • DumpRenderTree/chromium/EventSender.cpp:

(EventSender::EventSender):
(EventSender::keyDown):
(makeMenuItemStringsFor):
(EventSender::contextClick):

  • DumpRenderTree/chromium/EventSender.h:

(EventSender):
(EventSender::setDelegate):
(EventSender::setWebView):
(EventSender::webview):

  • DumpRenderTree/chromium/TestRunner/TestDelegate.h: Added.

(WebKit):
(TestDelegate):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::fillSpellingSuggestionList):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

02:50 Changeset [123448] by yosin@chromium.org

[Tests] Copy fast/forms/number/number-change-type-on-focus.html and number-losing-renderer-on-click.html to fast/forms/resources
https://bugs.webkit.org/show_bug.cgi?id=92083

Reviewed by Kent Tamura.

This patch copies two test HTML files in fast/forms/number into JavaScript code directory,
fast/forms/resources:

  • number-change-type-on-focus.html -> common-change-type-on-focus.js
  • number-losing-renderer-on-click.html -> common-losing-renderer-on-click.js
  • fast/forms/resources/common-change-type-on-focus.js: Copied from LayoutTests/fast/forms/number/number-change-type-on-focus.html.
  • fast/forms/resources/common-losing-renderer-on-click.js: Copied from LayoutTests/fast/forms/number/number-losing-renderer-on-click.html.
02:48 Changeset [123447] by commit-queue@webkit.org

Make WebIntents and WebIntentsTag a build option for the build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=91841

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-24
Reviewed by Philippe Normand.

And it will also be disabled when building with --minimal.

  • Scripts/webkitperl/FeatureList.pm:
02:38 Changeset [123446] by yosin@chromium.org

[Tests] Rename fast/forms/number/number-crash.html to number-losing-renderer-on-click.html
https://bugs.webkit.org/show_bug.cgi?id=92085

Reviewed by Kent Tamura.

This patch renames test file fast/forms/number/number-crash.html to number-losing-renderer-on-click.html
to make test name denotes what test will be done.

  • fast/forms/number/number-crash-expected.txt: Removed.
  • fast/forms/number/number-crash.html: Removed.
  • fast/forms/number/number-losing-renderer-on-click-expected.txt: Copied from LayoutTests/fast/forms/number/number-crash-expected.txt.
  • fast/forms/number/number-losing-renderer-on-click.html: Copied from LayoutTests/fast/forms/number/number-crash.html.
02:25 Changeset [123445] by peter@chromium.org

Unreviewed. Rolled DEPS.

  • DEPS:
02:21 Changeset [123444] by commit-queue@webkit.org

[EFL][WK2] Fix possible crash in didSendRequestForResource
https://bugs.webkit.org/show_bug.cgi?id=92077

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Add NULL check for wkRedirectResponse in
didSendRequestForResource() before using it. The
argument may be NULL if there was no redirection.

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_resource_load_client.cpp:

(didSendRequestForResource):

02:17 Changeset [123443] by tkent@chromium.org

Replace some callsites of shadowAncestorNode() with shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=92060

Reviewed by Hajime Morita.

shadowAncestorNode() is deprecated.

No new tests. This shouldn't change behaviors.

  • html/shadow/MediaControlElements.cpp:

(WebCore::toParentMediaElement):

  • html/shadow/TextControlInnerElements.h:

(WebCore::SpinButtonElement::isEnabledFormControl):
(WebCore::SpinButtonElement::isReadOnlyFormControl):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
(WebCore::RenderThemeEfl::paintMediaMuteButton):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::getMediaElementFromRenderObject):
(WebCore::centerRectVerticallyInParentInputElement):

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
Removed an ASSERT() because nullness of o->node() is already asserted.

  • rendering/RenderInputSpeech.cpp:

(WebCore::RenderInputSpeech::paintInputFieldSpeechButton):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaSliderThumb):
Passing shadowHost() to toParentMediaElement(), which accepts 0 and will return 0.
(WebCore::paintMediaVolumeSliderThumb): ditto.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
Remove an ASSERT(input) because input never be null unless o->node() is
null. If o->node() is null, this function crashes.
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
It's ok to ignore "node is a media element" case because this function
works only if node->isMediaControlElement().
(WebCore::RenderThemeMac::paintMediaPlayButton): ditto.
(WebCore::RenderThemeMac::paintMediaSliderTrack): ditto.

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintSearchFieldCancelButton):
Remove an ASSERT(input) because input never be null unless o->node() is
null. If o->node() is null, this function crashes.
(WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): ditto.
(WebCore::RenderThemeSafari::paintSearchFieldResultsButton): ditto.

  • rendering/RenderThemeWinCE.cpp:

(WebCore::mediaElementParent):

02:13 Changeset [123442] by commit-queue@webkit.org

[WK2][EFL][GTK] Share WebCoreArgumentCoders for soup-related types
https://bugs.webkit.org/show_bug.cgi?id=92073

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-24
Reviewed by Kenneth Rohde Christiansen.

Move WebCoreArgumentCoders for soup-related types such as
ResourceRequest, ResourceResponse and ResourceError from
port specific file to Shared/soup/WebCoreArgumentCodersSoup.cpp.
This way, the different ports using libsoup can share
code and avoid duplication.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • Shared/efl/WebCoreArgumentCodersEfl.cpp: Removed.
  • Shared/soup/WebCoreArgumentCodersSoup.cpp: Renamed from Source/WebKit2/Shared/gtk/WebCoreArgumentCodersGtk.cpp.

(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):

02:09 Changeset [123441] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening after r123379. Newly added fast/css/sticky/parsing-position-sticky.html fails.
https://bugs.webkit.org/show_bug.cgi?id=92080

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-24

  • platform/qt/Skipped:
01:55 Changeset [123440] by peter@chromium.org

[Chromium] Build fix for Android after r123424
https://bugs.webkit.org/show_bug.cgi?id=92082

Unreviewed build fix.

Mark removed the PlatformSupport.h header from ScrollbarThemeChromiumAndroid.cpp
in r123424, while there still are two references left to another method and a
constant. Re-add the include directive.

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
01:44 Changeset [123439] by haraken@chromium.org

[JSC] REGRESSION(r122912): CodeGeneratorJS.pm generates wrong code
for static attributes in supplemental IDL files
https://bugs.webkit.org/show_bug.cgi?id=91925

Reviewed by Adam Barth.

r122912 implemented static attributes in CodeGeneratorJS.pm.
However, it generates wrong code for static attributes in supplemental
IDL files. This patch fixes it as shown in JSTestInterface.cpp.
This fix aligns with the fix in CodeGeneratorV8.pm (r123308).

Test: bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):

01:42 Changeset [123438] by gyuyoung.kim@samsung.com

Add *explicit* keyword to constructor which has a parameter in bridge, history, loader and plugins.
https://bugs.webkit.org/show_bug.cgi?id=92064

Reviewed by Kentaro Hara.

Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.

No new tests. Covered by existing tests.

  • bridge/IdentifierRep.h:

(WebCore::IdentifierRep::IdentifierRep):

  • history/BackForwardListImpl.h:

(BackForwardListImpl):

  • history/CachedFrame.h:

(CachedFrame):

  • history/HistoryItem.h:

(HistoryItem):

  • loader/DocumentWriter.h:

(DocumentWriter):

  • loader/FrameNetworkingContext.h:

(WebCore::FrameNetworkingContext::FrameNetworkingContext):

  • loader/HistoryController.h:
  • loader/ImageLoader.h:

(ImageLoader):

  • loader/LinkLoader.h:

(LinkLoader):

  • loader/MainResourceLoader.h:

(MainResourceLoader):

  • loader/NavigationAction.h:

(NavigationAction):

  • loader/NavigationScheduler.h:

(NavigationScheduler):

  • loader/PolicyChecker.h:

(PolicyChecker):

  • loader/SubframeLoader.h:

(SubframeLoader):

  • loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):

  • plugins/PluginData.h:

(PluginData):

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::PluginViewBase):

01:24 Changeset [123437] by kkristof@inf.u-szeged.hu

[Qt] Unreview gardening.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-24

  • platform/qt/Skipped:
01:21 Changeset [123436] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening. Skipped a test because of a missing feature.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-24

  • platform/qt/Skipped:
01:02 Changeset [123435] by paroga@webkit.org

[Qt] Fix conversion from GregorianDateTime to QTime
https://bugs.webkit.org/show_bug.cgi?id=92068

Reviewed by Simon Hausmann.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::convertValueToQVariant):

00:37 Changeset [123434] by arko@motorola.com

Microdata: Implement PropertyNodeList interface.
https://bugs.webkit.org/show_bug.cgi?id=80269

Reviewed by Ryosuke Niwa.

Source/WebCore:

Added support for PropertyNodeList interface. Currently HTMLPropertiesCollection.namedItem(name)
returns NodeList object. Made changes so that it will return PropertyNodeList object.

Implemented propertyNodeList.getValues() method. It returns an array of various values. Its
values are obtained from the "itemValue" DOM property of each of the elements represented by
the object, in tree order.

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#propertynodelist

Tests: fast/dom/MicroData/nameditem-returns-propertynodelist.html

fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element.html
fast/dom/MicroData/propertynodelist-getvalues-test.html
fast/dom/MicroData/propertynodelist-test-add-remove-element.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSMicroDataItemValueCustom.cpp: Added.

(WebCore):
(WebCore::toJS): Added toJS() custom method. Returns Node if itemValue is node else returns String.

  • bindings/v8/custom/V8MicroDataItemValueCustom.cpp: Added.

(WebCore):
(WebCore::toV8): Added toV8 custom code.

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::rootNode): Return document if owner node has itemref attribute specified.
(WebCore):
(WebCore::DynamicNodeListCacheBase::ownerNodeHasItemRefAttribute): Returns true if owner node has itemref attribute
specified with root type NodeListRootedAtDocumentIfOwnerHasItemrefAttr.
(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeList::itemWithName): Update itemrefElements cache if root type is
NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr.

  • dom/DynamicNodeList.h: Added m_hasItemRefElements in DynamicNodeListCacheBase to check if itemRefElmenets cache

is valid.
(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::isRootedAtDocument):
(DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::isItemRefElementsCacheValid):
(WebCore::DynamicNodeListCacheBase::setItemRefElementsCacheValid):
(WebCore::DynamicNodeListCacheBase::rootType): Returns cached root type.
(WebCore::DynamicNodeListCacheBase::shouldInvalidateTypeOnAttributeChange): Invalidate NodeListCache on itemref
attribute change.

  • dom/Node.cpp:

(WebCore::Node::propertyNodeList):

  • dom/Node.h:

(WebCore):
(Node):

  • dom/PropertyNodeList.cpp: Added.

(WebCore):
(WebCore::PropertyNodeList::PropertyNodeList):
(WebCore::PropertyNodeList::~PropertyNodeList):
(WebCore::PropertyNodeList::elementIsPropertyOfRefElement): Checks if the testElement is a property of Microdata
item.
(WebCore::PropertyNodeList::updateRefElements):
(WebCore::PropertyNodeList::nodeMatches):
(WebCore::PropertyNodeList::getValues): Returns PropertyValueArray whose values are obtained from the
itemValue DOM property of each of the elements represented by the object, in tree order.

  • dom/PropertyNodeList.h: Added.

(WebCore):
(PropertyNodeList):
(WebCore::PropertyNodeList::create):

  • dom/PropertyNodeList.idl: Added.
  • html/HTMLCollection.cpp:

(WebCore::DynamicNodeListCacheBase::itemCommon): Update itemrefElements cache if its a NodeListCollectionType with
root type NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::properties):
(WebCore):
(WebCore::HTMLElement::getItemRefElements): Returns the ItemRefElements list of given element. Added this
method to share the code between HTMLPropertiesCollection and PropertyNodeList to update itemRefElements.

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::updateRefElements):
(WebCore::HTMLPropertiesCollection::updateNameCache):
(WebCore::HTMLPropertiesCollection::namedItem): Return PropertyNodeList object instead of NodeList.
(WebCore::HTMLPropertiesCollection::hasNamedItem): Return true if it finds an item with given
name in the properties collection.

  • html/HTMLPropertiesCollection.h: Removed m_hasItemRefElements member variable, now DynamicNodeListCacheBase

has isItemRefElementsCacheValid. Also removed m_hasPropertyNameCache, as DynamicNodeListCacheBase already has
hasNameCache() and setHasNameCache().
(WebCore):
(HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::invalidateCache):
(WebCore::HTMLPropertiesCollection::updatePropertyCache):

  • html/HTMLPropertiesCollection.idl:
  • html/MicroDataItemValue.idl: Added.
  • page/DOMWindow.idl:

LayoutTests:

Added test cases for PropertyNodeList interface and PropertyNodeList.getValues() method.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#propertynodelist

  • fast/dom/MicroData/nameditem-returns-propertynodelist-expected.txt: Added.
  • fast/dom/MicroData/nameditem-returns-propertynodelist.html: Added.
  • fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element-expected.txt: Added.
  • fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element.html: Added.
  • fast/dom/MicroData/propertynodelist-getvalues-test-expected.txt: Added.
  • fast/dom/MicroData/propertynodelist-getvalues-test.html: Added.
  • fast/dom/MicroData/propertynodelist-test-add-remove-element-expected.txt: Added.
  • fast/dom/MicroData/propertynodelist-test-add-remove-element.html: Added.
00:21 Changeset [123433] by haraken@chromium.org

[JSC] REGRESSION(r122912): CodeGeneratorJS.pm should not
implicitly assume ScriptExecutionContext for static attributes
https://bugs.webkit.org/show_bug.cgi?id=91924

Reviewed by Adam Barth.

r122912 implemented static attributes in CodeGeneratorJS.pm.
However, the generated code assumes that static attributes
always require ScriptExecutionContext, which is wrong.
If we need a ScriptExecutionContext, we should specify
[CallWith=ScriptExecutionContext].

This patch fixes CodeGeneratorJS.pm so that static attributes
do not assume ScriptExecutionContext. This fix aligns with
the fix in CodeGeneratorV8.pm in r123308.

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjConstructorStaticReadOnlyIntAttr):
(WebCore::jsTestObjConstructorStaticStringAttr):
(WebCore::setJSTestObjConstructorStaticStringAttr):

00:11 Changeset [123432] by kkristof@inf.u-szeged.hu

[Qt] from platform/qt/fast/overflow to platform/qt/fast/xsl tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91971

Unreviewed rebaseline.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-23

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/fast/overflow/001-expected.png: Added.
  • platform/qt/fast/overflow/001-expected.txt:
  • platform/qt/fast/overflow/002-expected.png: Added.
  • platform/qt/fast/overflow/002-expected.txt:
  • platform/qt/fast/overflow/004-expected.png:
  • platform/qt/fast/overflow/004-expected.txt:
  • platform/qt/fast/overflow/006-expected.png: Added.
  • platform/qt/fast/overflow/006-expected.txt:
  • platform/qt/fast/overflow/007-expected.png:
  • platform/qt/fast/overflow/007-expected.txt:
  • platform/qt/fast/overflow/008-expected.png: Added.
  • platform/qt/fast/overflow/008-expected.txt:
  • platform/qt/fast/overflow/border-radius-clipping-expected.png: Added.
  • platform/qt/fast/overflow/border-radius-clipping-expected.txt:
  • platform/qt/fast/overflow/childFocusRingClip-expected.png: Added.
  • platform/qt/fast/overflow/childFocusRingClip-expected.txt:
  • platform/qt/fast/overflow/dynamic-hidden-expected.png: Added.
  • platform/qt/fast/overflow/dynamic-hidden-expected.txt:
  • platform/qt/fast/overflow/float-in-relpositioned-expected.png: Added.
  • platform/qt/fast/overflow/float-in-relpositioned-expected.txt:
  • platform/qt/fast/overflow/hidden-scrollbar-resize-expected.png: Added.
  • platform/qt/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/qt/fast/overflow/hit-test-overflow-controls-expected.png: Added.
  • platform/qt/fast/overflow/hit-test-overflow-controls-expected.txt:
  • platform/qt/fast/overflow/image-selection-highlight-expected.png:
  • platform/qt/fast/overflow/image-selection-highlight-expected.txt:
  • platform/qt/fast/overflow/infiniteRecursion-expected.png:
  • platform/qt/fast/overflow/infiniteRecursion-expected.txt:
  • platform/qt/fast/overflow/line-clamp-expected.png:
  • platform/qt/fast/overflow/line-clamp-expected.txt:
  • platform/qt/fast/overflow/overflow-auto-position-absolute-expected.png: Added.
  • platform/qt/fast/overflow/overflow-auto-position-absolute-expected.txt:
  • platform/qt/fast/overflow/overflow-auto-table-expected.png:
  • platform/qt/fast/overflow/overflow-auto-table-expected.txt:
  • platform/qt/fast/overflow/overflow-float-stacking-expected.png: Added.
  • platform/qt/fast/overflow/overflow-float-stacking-expected.txt:
  • platform/qt/fast/overflow/overflow-focus-ring-expected.png:
  • platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
  • platform/qt/fast/overflow/overflow-rtl-inline-scrollbar-expected.png: Added.
  • platform/qt/fast/overflow/overflow-rtl-inline-scrollbar-expected.txt:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt:
  • platform/qt/fast/overflow/overflow-stacking-expected.png: Added.
  • platform/qt/fast/overflow/overflow-stacking-expected.txt:
  • platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
  • platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
  • platform/qt/fast/overflow/scrollbar-position-update-expected.png: Added.
  • platform/qt/fast/overflow/scrollbar-position-update-expected.txt:
  • platform/qt/fast/overflow/table-overflow-float-expected.png:
  • platform/qt/fast/overflow/table-overflow-float-expected.txt:
  • platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/qt/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
  • platform/qt/fast/parser/001-expected.png:
  • platform/qt/fast/parser/001-expected.txt:
  • platform/qt/fast/parser/bad-xml-slash-expected.png: Copied from LayoutTests/platform/qt/fast/text/whitespace/023-expected.png.
  • platform/qt/fast/parser/bad-xml-slash-expected.txt:
  • platform/qt/fast/parser/broken-comments-vs-parsing-mode-expected.png: Added.
  • platform/qt/fast/parser/broken-comments-vs-parsing-mode-expected.txt:
  • platform/qt/fast/parser/document-write-option-expected.png: Added.
  • platform/qt/fast/parser/document-write-option-expected.txt:
  • platform/qt/fast/parser/entity-comment-in-style-expected.png: Added.
  • platform/qt/fast/parser/entity-comment-in-style-expected.txt:
  • platform/qt/fast/parser/entity-comment-in-textarea-expected.png:
  • platform/qt/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/qt/fast/parser/nofoo-tags-inside-paragraph-expected.png: Added.
  • platform/qt/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
  • platform/qt/fast/parser/open-comment-in-style-expected.png: Added.
  • platform/qt/fast/parser/open-comment-in-style-expected.txt:
  • platform/qt/fast/parser/open-comment-in-textarea-expected.png:
  • platform/qt/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/qt/fast/parser/title-error-test-expected.png: Added.
  • platform/qt/fast/parser/title-error-test-expected.txt:
  • platform/qt/fast/reflections/abs-position-in-reflection-expected.png: Added.
  • platform/qt/fast/reflections/abs-position-in-reflection-expected.txt:
  • platform/qt/fast/reflections/inline-crash-expected.png: Added.
  • platform/qt/fast/reflections/inline-crash-expected.txt:
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.png:
  • platform/qt/fast/reflections/opacity-reflection-transform-expected.txt:
  • platform/qt/fast/reflections/reflection-nesting-expected.png: Added.
  • platform/qt/fast/reflections/reflection-nesting-expected.txt:
  • platform/qt/fast/reflections/reflection-overflow-hidden-expected.png: Added.
  • platform/qt/fast/reflections/reflection-overflow-hidden-expected.txt:
  • platform/qt/fast/reflections/transparent-reflected-sublayers-expected.png: Added.
  • platform/qt/fast/reflections/transparent-reflected-sublayers-expected.txt:
  • platform/qt/fast/repaint/4774354-expected.png:
  • platform/qt/fast/repaint/4774354-expected.txt:
  • platform/qt/fast/repaint/4776765-expected.png:
  • platform/qt/fast/repaint/4776765-expected.txt:
  • platform/qt/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/qt/fast/repaint/backgroundSizeRepaint-expected.txt:
  • platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
  • platform/qt/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/qt/fast/repaint/body-background-image-expected.png:
  • platform/qt/fast/repaint/body-background-image-expected.txt:
  • platform/qt/fast/repaint/border-fit-lines-expected.png:
  • platform/qt/fast/repaint/border-fit-lines-expected.txt:
  • platform/qt/fast/repaint/border-radius-repaint-expected.png:
  • platform/qt/fast/repaint/border-radius-repaint-expected.txt:
  • platform/qt/fast/repaint/border-repaint-glitch-expected.png:
  • platform/qt/fast/repaint/border-repaint-glitch-expected.txt:
  • platform/qt/fast/repaint/box-shadow-dynamic-expected.png:
  • platform/qt/fast/repaint/box-shadow-dynamic-expected.txt:
  • platform/qt/fast/repaint/bugzilla-3509-expected.png:
  • platform/qt/fast/repaint/bugzilla-3509-expected.txt:
  • platform/qt/fast/repaint/bugzilla-5699-expected.png:
  • platform/qt/fast/repaint/bugzilla-5699-expected.txt:
  • platform/qt/fast/repaint/bugzilla-6278-expected.png:
  • platform/qt/fast/repaint/bugzilla-6278-expected.txt:
  • platform/qt/fast/repaint/bugzilla-6388-expected.png:
  • platform/qt/fast/repaint/bugzilla-6388-expected.txt:
  • platform/qt/fast/repaint/bugzilla-6473-expected.png:
  • platform/qt/fast/repaint/bugzilla-6473-expected.txt:
  • platform/qt/fast/repaint/bugzilla-7235-expected.png:
  • platform/qt/fast/repaint/bugzilla-7235-expected.txt:
  • platform/qt/fast/repaint/caret-outside-block-expected.png:
  • platform/qt/fast/repaint/caret-outside-block-expected.txt:
  • platform/qt/fast/repaint/change-transform-expected.png:
  • platform/qt/fast/repaint/change-transform-expected.txt:
  • platform/qt/fast/repaint/clipped-relative-expected.png:
  • platform/qt/fast/repaint/clipped-relative-expected.txt:
  • platform/qt/fast/repaint/containing-block-position-change-expected.png:
  • platform/qt/fast/repaint/containing-block-position-change-expected.txt:
  • platform/qt/fast/repaint/control-clip-expected.png:
  • platform/qt/fast/repaint/control-clip-expected.txt:
  • platform/qt/fast/repaint/create-layer-repaint-expected.png:
  • platform/qt/fast/repaint/create-layer-repaint-expected.txt:
  • platform/qt/fast/repaint/delete-into-nested-block-expected.png:
  • platform/qt/fast/repaint/delete-into-nested-block-expected.txt:
  • platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/qt/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt:
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/qt/fast/repaint/float-move-during-layout-expected.png:
  • platform/qt/fast/repaint/float-move-during-layout-expected.txt:
  • platform/qt/fast/repaint/focus-layers-expected.png:
  • platform/qt/fast/repaint/focus-layers-expected.txt:
  • platform/qt/fast/repaint/inline-color-change-expected.png:
  • platform/qt/fast/repaint/inline-color-change-expected.txt:
  • platform/qt/fast/repaint/inline-outline-repaint-expected.png:
  • platform/qt/fast/repaint/inline-outline-repaint-expected.txt:
  • platform/qt/fast/repaint/layout-state-relative-expected.png:
  • platform/qt/fast/repaint/layout-state-relative-expected.txt:
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.png:
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/qt/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/qt/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/qt/fast/repaint/line-overflow-expected.png:
  • platform/qt/fast/repaint/line-overflow-expected.txt:
  • platform/qt/fast/repaint/list-marker-2-expected.png:
  • platform/qt/fast/repaint/list-marker-2-expected.txt:
  • platform/qt/fast/repaint/make-children-non-inline-expected.png:
  • platform/qt/fast/repaint/make-children-non-inline-expected.txt:
  • platform/qt/fast/repaint/multicol-repaint-expected.png:
  • platform/qt/fast/repaint/multicol-repaint-expected.txt:
  • platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png:
  • platform/qt/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt:
  • platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.png:
  • platform/qt/fast/repaint/opacity-change-on-overflow-float-expected.txt:
  • platform/qt/fast/repaint/outline-child-repaint-expected.png:
  • platform/qt/fast/repaint/outline-child-repaint-expected.txt:
  • platform/qt/fast/repaint/outline-inset-expected.png:
  • platform/qt/fast/repaint/outline-inset-expected.txt:
  • platform/qt/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/qt/fast/repaint/outline-repaint-glitch-expected.txt:
  • platform/qt/fast/repaint/outline-shrinking-expected.png:
  • platform/qt/fast/repaint/outline-shrinking-expected.txt:
  • platform/qt/fast/repaint/overflow-delete-line-expected.png:
  • platform/qt/fast/repaint/overflow-delete-line-expected.txt:
  • platform/qt/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/qt/fast/repaint/overflow-scroll-body-appear-expected.txt:
  • platform/qt/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/qt/fast/repaint/overflow-scroll-delete-expected.txt:
  • platform/qt/fast/repaint/positioned-document-element-expected.png:
  • platform/qt/fast/repaint/positioned-document-element-expected.txt:
  • platform/qt/fast/repaint/reflection-redraw-expected.png:
  • platform/qt/fast/repaint/reflection-redraw-expected.txt:
  • platform/qt/fast/repaint/region-painting-invalidation-expected.png:
  • platform/qt/fast/repaint/region-painting-invalidation-expected.txt:
  • platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
  • platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt:
  • platform/qt/fast/repaint/repaint-resized-overflow-expected.png:
  • platform/qt/fast/repaint/repaint-resized-overflow-expected.txt:
  • platform/qt/fast/repaint/scale-page-shrink-expected.png:
  • platform/qt/fast/repaint/scale-page-shrink-expected.txt:
  • platform/qt/fast/repaint/search-field-cancel-expected.png:
  • platform/qt/fast/repaint/search-field-cancel-expected.txt:
  • platform/qt/fast/repaint/select-option-background-color-expected.png:
  • platform/qt/fast/repaint/select-option-background-color-expected.txt:
  • platform/qt/fast/repaint/selected-replaced-expected.png:
  • platform/qt/fast/repaint/selected-replaced-expected.txt:
  • platform/qt/fast/repaint/selection-after-delete-expected.png:
  • platform/qt/fast/repaint/selection-after-delete-expected.txt:
  • platform/qt/fast/repaint/selection-after-remove-expected.png:
  • platform/qt/fast/repaint/selection-after-remove-expected.txt:
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
  • platform/qt/fast/repaint/selection-rl-expected.png:
  • platform/qt/fast/repaint/selection-rl-expected.txt:
  • platform/qt/fast/repaint/stacked-diacritics-expected.png:
  • platform/qt/fast/repaint/stacked-diacritics-expected.txt:
  • platform/qt/fast/repaint/subtree-layoutstate-transform-expected.png:
  • platform/qt/fast/repaint/subtree-layoutstate-transform-expected.txt:
  • platform/qt/fast/repaint/subtree-root-skipped-expected.png:
  • platform/qt/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/qt/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/qt/fast/repaint/table-cell-collapsed-border-expected.txt:
  • platform/qt/fast/repaint/table-cell-move-expected.png:
  • platform/qt/fast/repaint/table-cell-move-expected.txt:
  • platform/qt/fast/repaint/table-collapsed-border-expected.png:
  • platform/qt/fast/repaint/table-collapsed-border-expected.txt:
  • platform/qt/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/qt/fast/repaint/table-extra-bottom-grow-expected.txt:
  • platform/qt/fast/repaint/text-append-dirty-lines-expected.png:
  • platform/qt/fast/repaint/text-append-dirty-lines-expected.txt:
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
  • platform/qt/fast/repaint/transform-relative-position-expected.png:
  • platform/qt/fast/repaint/transform-relative-position-expected.txt:
  • platform/qt/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/qt/fast/repaint/transform-repaint-descendants-expected.txt:
  • platform/qt/fast/repaint/transform-translate-expected.png:
  • platform/qt/fast/repaint/transform-translate-expected.txt:
  • platform/qt/fast/replaced/001-expected.png:
  • platform/qt/fast/replaced/001-expected.txt:
  • platform/qt/fast/replaced/002-expected.png:
  • platform/qt/fast/replaced/002-expected.txt:
  • platform/qt/fast/replaced/003-expected.png:
  • platform/qt/fast/replaced/003-expected.txt:
  • platform/qt/fast/replaced/004-expected.png:
  • platform/qt/fast/replaced/004-expected.txt:
  • platform/qt/fast/replaced/005-expected.png:
  • platform/qt/fast/replaced/005-expected.txt:
  • platform/qt/fast/replaced/006-expected.png:
  • platform/qt/fast/replaced/006-expected.txt:
  • platform/qt/fast/replaced/007-expected.png:
  • platform/qt/fast/replaced/007-expected.txt:
  • platform/qt/fast/replaced/absolute-image-sizing-expected.png:
  • platform/qt/fast/replaced/absolute-image-sizing-expected.txt:
  • platform/qt/fast/replaced/absolute-position-percentage-height-expected.png:
  • platform/qt/fast/replaced/absolute-position-percentage-height-expected.txt:
  • platform/qt/fast/replaced/absolute-position-percentage-width-expected.png:
  • platform/qt/fast/replaced/absolute-position-percentage-width-expected.txt:
  • platform/qt/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/qt/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.txt:
  • platform/qt/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/qt/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.txt:
  • platform/qt/fast/replaced/applet-disabled-positioned-expected.png:
  • platform/qt/fast/replaced/applet-disabled-positioned-expected.txt:
  • platform/qt/fast/replaced/applet-display-none-expected.png:
  • platform/qt/fast/replaced/applet-display-none-expected.txt:
  • platform/qt/fast/replaced/applet-rendering-java-disabled-expected.png:
  • platform/qt/fast/replaced/applet-rendering-java-disabled-expected.txt:
  • platform/qt/fast/replaced/border-radius-clip-expected.png:
  • platform/qt/fast/replaced/border-radius-clip-expected.txt:
  • platform/qt/fast/replaced/embed-display-none-expected.png:
  • platform/qt/fast/replaced/embed-display-none-expected.txt:
  • platform/qt/fast/replaced/image-resize-width-expected.png:
  • platform/qt/fast/replaced/image-resize-width-expected.txt:
  • platform/qt/fast/replaced/image-sizing-expected.png:
  • platform/qt/fast/replaced/image-sizing-expected.txt:
  • platform/qt/fast/replaced/inline-box-wrapper-handover-expected.png:
  • platform/qt/fast/replaced/inline-box-wrapper-handover-expected.txt:
  • platform/qt/fast/replaced/max-width-percent-expected.png:
  • platform/qt/fast/replaced/max-width-percent-expected.txt:
  • platform/qt/fast/replaced/maxheight-percent-expected.png:
  • platform/qt/fast/replaced/maxheight-percent-expected.txt:
  • platform/qt/fast/replaced/maxheight-pxs-expected.png:
  • platform/qt/fast/replaced/maxheight-pxs-expected.txt:
  • platform/qt/fast/replaced/maxwidth-percent-expected.png:
  • platform/qt/fast/replaced/maxwidth-percent-expected.txt:
  • platform/qt/fast/replaced/maxwidth-pxs-expected.png:
  • platform/qt/fast/replaced/maxwidth-pxs-expected.txt:
  • platform/qt/fast/replaced/minheight-percent-expected.png:
  • platform/qt/fast/replaced/minheight-percent-expected.txt:
  • platform/qt/fast/replaced/minheight-pxs-expected.png:
  • platform/qt/fast/replaced/minheight-pxs-expected.txt:
  • platform/qt/fast/replaced/minwidth-percent-expected.png:
  • platform/qt/fast/replaced/minwidth-percent-expected.txt:
  • platform/qt/fast/replaced/minwidth-pxs-expected.png:
  • platform/qt/fast/replaced/minwidth-pxs-expected.txt:
  • platform/qt/fast/replaced/object-align-hspace-vspace-expected.png:
  • platform/qt/fast/replaced/object-align-hspace-vspace-expected.txt:
  • platform/qt/fast/replaced/object-display-none-expected.png:
  • platform/qt/fast/replaced/object-display-none-expected.txt:
  • platform/qt/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png:
  • platform/qt/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/qt/fast/replaced/percent-height-in-anonymous-block-widget-expected.png:
  • platform/qt/fast/replaced/percent-height-in-anonymous-block-widget-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/qt/fast/replaced/replaced-child-of-absolute-with-auto-height-expected.png:
  • platform/qt/fast/replaced/replaced-child-of-absolute-with-auto-height-expected.txt:
  • platform/qt/fast/replaced/selection-rect-in-table-cell-expected.png:
  • platform/qt/fast/replaced/selection-rect-in-table-cell-expected.txt:
  • platform/qt/fast/replaced/selection-rect-transform-expected.png:
  • platform/qt/fast/replaced/selection-rect-transform-expected.txt:
  • platform/qt/fast/replaced/three-selects-break-expected.png:
  • platform/qt/fast/replaced/three-selects-break-expected.txt:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.png:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-percentage-width-expected.txt:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.txt:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.txt:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.png:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-percentage-width-expected.txt:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.txt:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
  • platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.txt:
  • platform/qt/fast/replaced/width100percent-button-expected.png:
  • platform/qt/fast/replaced/width100percent-button-expected.txt:
  • platform/qt/fast/replaced/width100percent-checkbox-expected.png:
  • platform/qt/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/qt/fast/replaced/width100percent-image-expected.png:
  • platform/qt/fast/replaced/width100percent-image-expected.txt:
  • platform/qt/fast/replaced/width100percent-radio-expected.png: Added.
  • platform/qt/fast/replaced/width100percent-radio-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.png:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/qt/fast/replaced/width100percent-textfield-expected.png:
  • platform/qt/fast/replaced/width100percent-textfield-expected.txt:
  • platform/qt/fast/ruby/ruby-inline-table-expected.png:
  • platform/qt/fast/ruby/ruby-inline-table-expected.txt:
  • platform/qt/fast/ruby/ruby-text-before-after-content-expected.png:
  • platform/qt/fast/ruby/ruby-text-before-after-content-expected.txt:
  • platform/qt/fast/runin/001-expected.png:
  • platform/qt/fast/runin/001-expected.txt:
  • platform/qt/fast/runin/generated-expected.png:
  • platform/qt/fast/runin/generated-expected.txt:
  • platform/qt/fast/runin/generated2-expected.png:
  • platform/qt/fast/runin/generated2-expected.txt:
  • platform/qt/fast/runin/generated3-expected.png:
  • platform/qt/fast/runin/generated3-expected.txt:
  • platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.png:
  • platform/qt/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt:
  • platform/qt/fast/text/atsui-kerning-and-ligatures-expected.png: Added.
  • platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png:
  • platform/qt/fast/text/backslash-to-yen-sign-dynamic-expected.png:
  • platform/qt/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/qt/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/qt/fast/text/backslash-to-yen-sign-expected.png:
  • platform/qt/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/qt/fast/text/basic/001-expected.png:
  • platform/qt/fast/text/basic/002-expected.png: Added.
  • platform/qt/fast/text/basic/003-expected.png:
  • platform/qt/fast/text/basic/003-expected.txt:
  • platform/qt/fast/text/basic/004-expected.png: Added.
  • platform/qt/fast/text/basic/005-expected.png: Added.
  • platform/qt/fast/text/basic/006-expected.png: Added.
  • platform/qt/fast/text/basic/007-expected.png: Added.
  • platform/qt/fast/text/basic/008-expected.png: Added.
  • platform/qt/fast/text/basic/009-expected.png:
  • platform/qt/fast/text/basic/011-expected.png: Added.
  • platform/qt/fast/text/basic/012-expected.png: Added.
  • platform/qt/fast/text/basic/generic-family-changes-expected.png:
  • platform/qt/fast/text/basic/generic-family-reset-expected.png:
  • platform/qt/fast/text/break-word-expected.png:
  • platform/qt/fast/text/capitalize-empty-generated-string-expected.png: Added.
  • platform/qt/fast/text/capitalize-preserve-nbsp-expected.png: Added.
  • platform/qt/fast/text/cg-vs-atsui-expected.png:
  • platform/qt/fast/text/complex-preferred-logical-widths-expected.png:
  • platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png:
  • platform/qt/fast/text/complex-text-opacity-expected.png:
  • platform/qt/fast/text/complex-text-opacity-expected.txt:
  • platform/qt/fast/text/delete-hard-break-character-expected.png: Added.
  • platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.png:
  • platform/qt/fast/text/fake-italic-expected.png: Added.
  • platform/qt/fast/text/fallback-traits-fixup-expected.png: Added.
  • platform/qt/fast/text/fallback-traits-fixup-expected.txt:
  • platform/qt/fast/text/firstline/001-expected.png: Added.
  • platform/qt/fast/text/firstline/002-expected.png: Added.
  • platform/qt/fast/text/firstline/003-expected.png: Added.
  • platform/qt/fast/text/font-initial-expected.png: Added.
  • platform/qt/fast/text/hyphenate-limit-before-after-expected.png:
  • platform/qt/fast/text/hyphenate-limit-lines-expected.png:
  • platform/qt/fast/text/international/arabic-justify-expected.png: Added.
  • platform/qt/fast/text/international/arabic-justify-expected.txt:
  • platform/qt/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/qt/fast/text/international/hindi-whitespace-expected.txt:
  • platform/qt/fast/text/international/text-spliced-font-expected.png:
  • platform/qt/fast/text/international/text-spliced-font-expected.txt:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/qt/fast/text/justified-selection-at-edge-expected.png: Added.
  • platform/qt/fast/text/justified-selection-expected.png: Added.
  • platform/qt/fast/text/large-text-composed-char-expected.png:
  • platform/qt/fast/text/large-text-composed-char-expected.txt:
  • platform/qt/fast/text/letter-spacing-negative-opacity-expected.png:
  • platform/qt/fast/text/letter-spacing-negative-opacity-expected.txt:
  • platform/qt/fast/text/line-breaks-after-white-space-expected.png:
  • platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/multicol-repaint-expected.png.
  • platform/qt/fast/text/midword-break-hang-expected.png: Added.
  • platform/qt/fast/text/reset-emptyRun-expected.png: Added.
  • platform/qt/fast/text/selection-hard-linebreak-expected.png:
  • platform/qt/fast/text/shadow-no-blur-expected.png:
  • platform/qt/fast/text/shadow-translucent-fill-expected.png: Added.
  • platform/qt/fast/text/should-use-atsui-expected.png: Added.
  • platform/qt/fast/text/softHyphen-expected.png: Added.
  • platform/qt/fast/text/softHyphen-expected.txt:
  • platform/qt/fast/text/stroking-decorations-expected.png: Added.
  • platform/qt/fast/text/stroking-expected.png: Added.
  • platform/qt/fast/text/text-letter-spacing-expected.png:
  • platform/qt/fast/text/text-letter-spacing-expected.txt:
  • platform/qt/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/qt/fast/text/textIteratorNilRenderer-expected.png:
  • platform/qt/fast/text/unicode-variation-selector-expected.png:
  • platform/qt/fast/text/wbr-expected.png: Added.
  • platform/qt/fast/text/wbr-in-pre-crash-expected.png: Added.
  • platform/qt/fast/text/wbr-pre-expected.png:
  • platform/qt/fast/text/wbr-styled-expected.png:
  • platform/qt/fast/text/whitespace/002-expected.png:
  • platform/qt/fast/text/whitespace/003-expected.png:
  • platform/qt/fast/text/whitespace/006-expected.png: Added.
  • platform/qt/fast/text/whitespace/007-expected.png: Added.
  • platform/qt/fast/text/whitespace/008-expected.png: Added.
  • platform/qt/fast/text/whitespace/009-expected.png: Added.
  • platform/qt/fast/text/whitespace/012-expected.png:
  • platform/qt/fast/text/whitespace/013-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/multicol-repaint-expected.png.
  • platform/qt/fast/text/whitespace/014-expected.png: Copied from LayoutTests/platform/qt/fast/replaced/three-selects-break-expected.png.
  • platform/qt/fast/text/whitespace/018-expected.png: Added.
  • platform/qt/fast/text/whitespace/020-expected.png: Added.
  • platform/qt/fast/text/whitespace/021-expected.png: Added.
  • platform/qt/fast/text/whitespace/022-expected.png:
  • platform/qt/fast/text/whitespace/023-expected.png:
  • platform/qt/fast/text/whitespace/025-expected.png: Added.
  • platform/qt/fast/text/whitespace/026-expected.png: Added.
  • platform/qt/fast/text/whitespace/027-expected.png: Added.
  • platform/qt/fast/text/whitespace/030-expected.png:
  • platform/qt/fast/text/whitespace/nbsp-mode-and-linewraps-expected.png: Added.
  • platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/qt/fast/text/whitespace/nowrap-clear-float-expected.png: Added.
  • platform/qt/fast/text/whitespace/pre-break-word-expected.png:
  • platform/qt/fast/text/whitespace/pre-newline-box-test-expected.png:
  • platform/qt/fast/text/whitespace/pre-wrap-last-char-expected.png: Added.
  • platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png:
  • platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.png:
  • platform/qt/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • platform/qt/fast/text/whitespace/span-in-word-space-causes-overflow-expected.png: Added.
  • platform/qt/fast/text/word-break-expected.png:
  • platform/qt/fast/text/word-break-expected.txt:
  • platform/qt/fast/text/zero-font-size-expected.png:
  • platform/qt/fast/text/zero-font-size-expected.txt:
  • platform/qt/fast/tokenizer/001-expected.png:
  • platform/qt/fast/tokenizer/001-expected.txt:
  • platform/qt/fast/tokenizer/003-expected.png:
  • platform/qt/fast/tokenizer/003-expected.txt:
  • platform/qt/fast/transforms/bounding-rect-zoom-expected.png: Added.
  • platform/qt/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/qt/fast/transforms/diamond-expected.png:
  • platform/qt/fast/transforms/diamond-expected.txt:
  • platform/qt/fast/transforms/identity-matrix-expected.png:
  • platform/qt/fast/transforms/identity-matrix-expected.txt:
  • platform/qt/fast/transforms/overflow-with-transform-expected.png:
  • platform/qt/fast/transforms/overflow-with-transform-expected.txt:
  • platform/qt/fast/transforms/skew-with-unitless-zero-expected.png:
  • platform/qt/fast/transforms/skew-with-unitless-zero-expected.txt:
  • platform/qt/fast/transforms/transform-on-inline-expected.png:
  • platform/qt/fast/transforms/transform-on-inline-expected.txt:
  • platform/qt/fast/transforms/transform-overflow-expected.png:
  • platform/qt/fast/transforms/transform-overflow-expected.txt:
  • platform/qt/fast/transforms/transform-positioned-ancestor-expected.png:
  • platform/qt/fast/transforms/transform-positioned-ancestor-expected.txt:
  • platform/qt/fast/transforms/transform-table-row-expected.png:
  • platform/qt/fast/transforms/transform-table-row-expected.txt:
  • platform/qt/fast/transforms/transformed-caret-expected.png:
  • platform/qt/fast/transforms/transformed-caret-expected.txt:
  • platform/qt/fast/transforms/transformed-document-element-expected.png:
  • platform/qt/fast/transforms/transformed-document-element-expected.txt:
  • platform/qt/fast/transforms/transforms-with-opacity-expected.png:
  • platform/qt/fast/transforms/transforms-with-opacity-expected.txt:
  • platform/qt/fast/transforms/transforms-with-zoom-expected.png:
  • platform/qt/fast/transforms/transforms-with-zoom-expected.txt:
  • platform/qt/fast/writing-mode/background-horizontal-bt-expected.png:
  • platform/qt/fast/writing-mode/background-horizontal-bt-expected.txt:
  • platform/qt/fast/writing-mode/background-vertical-lr-expected.png:
  • platform/qt/fast/writing-mode/background-vertical-lr-expected.txt:
  • platform/qt/fast/writing-mode/background-vertical-rl-expected.png:
  • platform/qt/fast/writing-mode/background-vertical-rl-expected.txt:
  • platform/qt/fast/writing-mode/basic-vertical-line-expected.png:
  • platform/qt/fast/writing-mode/basic-vertical-line-expected.txt:
  • platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
  • platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.txt:
  • platform/qt/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-horizontal-bt-expected.txt:
  • platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.txt:
  • platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.txt:
  • platform/qt/fast/writing-mode/english-bt-text-expected.png:
  • platform/qt/fast/writing-mode/english-bt-text-expected.txt:
  • platform/qt/fast/writing-mode/english-lr-text-expected.png:
  • platform/qt/fast/writing-mode/english-lr-text-expected.txt:
  • platform/qt/fast/writing-mode/english-rl-text-expected.png:
  • platform/qt/fast/writing-mode/english-rl-text-expected.txt:
  • platform/qt/fast/writing-mode/fallback-orientation-expected.png:
  • platform/qt/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/qt/fast/writing-mode/fieldsets-expected.png:
  • platform/qt/fast/writing-mode/fieldsets-expected.txt:
  • platform/qt/fast/writing-mode/horizontal-bt-replaced-selection-expected.png:
  • platform/qt/fast/writing-mode/horizontal-bt-replaced-selection-expected.txt:
  • platform/qt/fast/writing-mode/vertical-lr-replaced-selection-expected.png:
  • platform/qt/fast/writing-mode/vertical-lr-replaced-selection-expected.txt:
  • platform/qt/fast/writing-mode/vertical-rl-replaced-selection-expected.png:
  • platform/qt/fast/writing-mode/vertical-rl-replaced-selection-expected.txt:
  • platform/qt/fast/xsl/document-function-expected.png: Added.
  • platform/qt/fast/xsl/document-function-expected.txt:
  • platform/qt/fast/xsl/xslt-entity-expected.png: Copied from LayoutTests/platform/qt/fast/text/whitespace/023-expected.png.
  • platform/qt/fast/xsl/xslt-entity-expected.txt:

07/23/12:

23:43 Changeset [123431] by tkent@chromium.org

[GTK] Remove unnecessary trailing space in the previous commit.

  • Source/autotools/symbols.filter:
23:35 Changeset [123430] by tkent@chromium.org

[GTK] Attempt to fix build

  • Source/autotools/symbols.filter: Export DocumentMarkerController::addTextMatchMarker.
23:33 Changeset [123429] by gyuyoung.kim@samsung.com

Missing *explicit* keyword in editing.
https://bugs.webkit.org/show_bug.cgi?id=92055

Reviewed by Ryosuke Niwa.

Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.

No new tests. Covered by existing tests.

  • editing/AlternativeTextController.h:

(WebCore::AlternativeTextController::UNLESS_ENABLED):

  • editing/BreakBlockquoteCommand.h:

(BreakBlockquoteCommand):

  • editing/DeleteButton.h:

(DeleteButton):

  • editing/DeleteButtonController.h:

(DeleteButtonController):

  • editing/EditCommand.h:

(EditCommand):
(WebCore::SimpleEditCommand::SimpleEditCommand):

  • editing/EditingBehavior.h:

(WebCore::EditingBehavior::EditingBehavior):

  • editing/EditingStyle.h:

(EditingStyle):

  • editing/Editor.h:

(Editor):

  • editing/FrameSelection.h:

(FrameSelection):

  • editing/InsertLineBreakCommand.h:

(InsertLineBreakCommand):

  • editing/ModifySelectionListLevel.h:

(ModifySelectionListLevelCommand):
(DecreaseSelectionListLevelCommand):

  • editing/RemoveFormatCommand.h:

(RemoveFormatCommand):

  • editing/RemoveNodeCommand.h:

(RemoveNodeCommand):

  • editing/RemoveNodePreservingChildrenCommand.h:

(RemoveNodePreservingChildrenCommand):

  • editing/ReplaceNodeWithSpanCommand.h:

(ReplaceNodeWithSpanCommand):

  • editing/TextInsertionBaseCommand.h:

(TextInsertionBaseCommand):

  • editing/UndoManager.h:

(UndoManager):

  • editing/UnlinkCommand.h:

(UnlinkCommand):

  • editing/WrapContentsInDummySpanCommand.h:

(WrapContentsInDummySpanCommand):

23:26 Changeset [123428] by dmazzoni@google.com

AX: Need AccessibilityObjects for nodes without renderers in canvas subtree
https://bugs.webkit.org/show_bug.cgi?id=87899

Reviewed by Chris Fleizach.

Source/WebCore:

Refactors AccessibilityRenderObject so that it inherits from a new class,
AccessibilityNodeObject, that can be constructed from a Node without a
renderer. Modifies AXObjectCache so that it automatically creates an
AccessibilityNodeObject for elements in a canvas subtree but not otherwise.
A new layout test verifies that this correctly exposes an accessibility
tree with appropriate roles for elements in a canvas subtree.

This patch does not try to complete the implementation of
AccessibilityNodeObject. Most AX methods are still unimplemented and need
to be migrated from AccessibilityRenderObject to AccessibilityNodeObject
in a future patch.

This patch also doesn't change anything outside of WebCore/accessibility, so
the rest of WebCore only calls AXObjectCache when there are changes to a
RenderObject, not to a Node. Accessible notifications on nodes without
renderers need to be implemented in a future patch.

Test: accessibility/canvas-accessibilitynodeobject.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::get):
(WebCore):
(WebCore::createFromNode):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):

  • accessibility/AXObjectCache.h:

(AXObjectCache):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::remove):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid):
(WebCore):
(WebCore::AccessibilityARIAGrid::~AccessibilityARIAGrid):
(WebCore::AccessibilityARIAGrid::init):
(WebCore::AccessibilityARIAGrid::create):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::create):

  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::create):

  • accessibility/AccessibilityAllInOne.cpp:
  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::create):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::create):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::create):
(WebCore::AccessibilityMediaControlsContainer::create):
(WebCore::AccessibilityMediaTimeline::create):
(WebCore::AccessibilityMediaTimeDisplay::create):

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::create):
(WebCore):

  • accessibility/AccessibilityMenuList.h:

(AccessibilityMenuList):

  • accessibility/AccessibilityNodeObject.cpp: Added.

(WebCore):
(WebCore::AccessibilityNodeObject::AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::~AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::init):
(WebCore::AccessibilityNodeObject::create):
(WebCore::AccessibilityNodeObject::detach):
(WebCore::AccessibilityNodeObject::childrenChanged):
(WebCore::AccessibilityNodeObject::updateAccessibilityRole):
(WebCore::AccessibilityNodeObject::firstChild):
(WebCore::AccessibilityNodeObject::lastChild):
(WebCore::AccessibilityNodeObject::previousSibling):
(WebCore::AccessibilityNodeObject::nextSibling):
(WebCore::AccessibilityNodeObject::parentObjectIfExists):
(WebCore::AccessibilityNodeObject::parentObject):
(WebCore::AccessibilityNodeObject::elementRect):
(WebCore::AccessibilityNodeObject::setNode):
(WebCore::AccessibilityNodeObject::document):
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::addChildren):
(WebCore::AccessibilityNodeObject::accessibilityIsIgnored):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):
(WebCore::AccessibilityNodeObject::determineAriaRoleAttribute):
(WebCore::AccessibilityNodeObject::ariaRoleAttribute):
(WebCore::AccessibilityNodeObject::remapAriaRoleDueToParent):

  • accessibility/AccessibilityNodeObject.h: Added.

(WebCore):
(AccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::isAccessibilityNodeObject):
(WebCore::AccessibilityNodeObject::node):
(WebCore::AccessibilityNodeObject::isDetached):
(WebCore::toAccessibilityNodeObject):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isAccessibilityNodeObject):

  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::create):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::init):
(WebCore):
(WebCore::AccessibilityRenderObject::create):
(WebCore::AccessibilityRenderObject::detach):
(WebCore::AccessibilityRenderObject::setRenderer):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::addCanvasChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::create):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::AccessibilityTable):
(WebCore):
(WebCore::AccessibilityTable::~AccessibilityTable):
(WebCore::AccessibilityTable::init):
(WebCore::AccessibilityTable::create):

  • accessibility/AccessibilityTable.h:

(AccessibilityTable):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::create):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::create):

LayoutTests:

This new test adds a bunch of elements to a normal container and the same elements to
a canvas subtree, then it iterates over all of the accessible objects within each
container and makes sure they have identical roles. Because we know the nodes in the
canvas subtree don't have renderers, this successfully tests that AccessibilityNodeObjects
are getting created for these nodes.

  • accessibility/canvas-accessibilitynodeobject-expected.txt: Added.
  • accessibility/canvas-accessibilitynodeobject.html: Added.
22:53 FeatureFlags edited by tkent@chromium.org
Add OPENTYPE_VERTICAL (diff)
22:46 Changeset [123427] by commit-queue@webkit.org

Fix ENABLE_CSS_IMAGE_ORIENTATION compile flag
https://bugs.webkit.org/show_bug.cgi?id=91961

Patch by David Barr <davidbarr@chromium.org> on 2012-07-23
Reviewed by Tony Chang.

https://bugs.webkit.org/show_bug.cgi?id=89055
A rule was missed implementing the ENABLE_CSS_IMAGE_ORIENTATION compile flag.

https://bugs.webkit.org/show_bug.cgi?id=90046
Half of the missing rule was inadvertently added together with ENABLE_CSS_STICKY_POSITION.

No new tests; build configuration fix.

  • Configurations/FeatureDefines.xcconfig:
22:34 Changeset [123426] by commit-queue@webkit.org

Null-pointer crash when a derived color like -webkit-activelink is set in a gradient stop
https://bugs.webkit.org/show_bug.cgi?id=89148

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-23
Reviewed by Simon Fraser.

Source/WebCore:

CSSGradientValue attempted to resolve colors during paint, this crashed
when a derived color like -webkit-activelink was encountered because the
corresponding element was no longer available in the StyleResolver.
Instead, by adding a field to CSSGradientColorStop we can resolve and
then cache the resolved colors at the correct time. To avoid sharing
cached derived colors between elements we clone the gradient values when
needed.

Test: fast/css/crash-on-gradient-with-derived-color.html

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::gradientWithStylesResolved): Added. Resolve and cache
resolved colors, clone if colors are derived from the element.
(WebCore):
(WebCore::CSSGradientValue::addStops):
(WebCore::CSSGradientValue::isCacheable): Defer to new logic in
StyleResolver.

  • css/CSSGradientValue.h:

(CSSGradientColorStop): Added cache of resolved color.
(CSSGradientValue):
(CSSLinearGradientValue):
(CSSRadialGradientValue):

  • css/CSSImageGeneratorValue.h:

(WebCore):

  • css/CSSValue.h:

(WebCore::CSSValue::isGradientValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:

(StyleResolver):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::image): Revert change from r96449. This
is no longer necessary as the gradient colors are now resolved at a
time when the style is set on StyleResolver.

LayoutTests:

  • fast/css/crash-on-gradient-with-derived-color-expected.txt: Added.
  • fast/css/crash-on-gradient-with-derived-color.html: Added.
22:19 Changeset [123425] by paroga@webkit.org

Move GregorianDateTime from JSC to WTF namespace
https://bugs.webkit.org/show_bug.cgi?id=91948

Reviewed by Geoffrey Garen.

Moving GregorianDateTime into the WTF namespace allows us to us to
use it in WebCore too. The new class has the same behaviour as the
old struct. Only the unused timeZone member has been removed.

Source/JavaScriptCore:

  • runtime/DateConstructor.cpp:
  • runtime/DateConversion.cpp:
  • runtime/DateConversion.h:
  • runtime/DateInstance.h:
  • runtime/DatePrototype.cpp:
  • runtime/JSDateMath.cpp:
  • runtime/JSDateMath.h:

Source/WebCore:

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

Source/WTF:

  • GNUmakefile.list.am:
  • WTF.gypi:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/GregorianDateTime.h: Added.

(GregorianDateTime):

22:05 Changeset [123424] by pilgrim@chromium.org

[Chromium] Move layoutTestMode to WebCore
https://bugs.webkit.org/show_bug.cgi?id=92010

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • platform/LayoutTestSupport.cpp: Added.

(WebCore):
(WebCore::isRunningLayoutTest):
(WebCore::setIsRunningLayoutTest):

  • platform/LayoutTestSupport.h: Added.

(WebCore):

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):

  • platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):

  • platform/graphics/chromium/FontCacheChromiumWin.cpp:

(WebCore):
(WebCore::LookupAltName):
(WebCore::fontContainsCharacter):
(WebCore::FillLogFont):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::drawGlyphs):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::systemColor):
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::caretBlinkInterval):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumWin::systemColor):
(WebCore::menuListButtonWidth):
(WebCore::RenderThemeChromiumWin::determineClassicState):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

  • src/WebKit.cpp:

(WebKit::setLayoutTestMode):
(WebKit::layoutTestMode):

21:57 Changeset [123423] by joone@webkit.org

Unreviewed GTK/EFL gardening after r123379
Marked fast/css/sticky/parsing-position-sticky.html as known failure
tracked by the bug 92063

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
21:22 Changeset [123422] by yosin@chromium.org

[Tests] Rename fast/forms/time/*.html to time-*.html
https://bugs.webkit.org/show_bug.cgi?id=92058

Reviewed by Kent Tamura.

This patch renames test scripts and expected text to same naming
scheme(name starts with "time-"), for fast/forms/time.

  • fast/forms/time/ValidityState-rangeOverflow-time-expected.txt: Removed.
  • fast/forms/time/ValidityState-rangeOverflow-time.html: Removed.
  • fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt: Removed.
  • fast/forms/time/ValidityState-rangeUnderflow-time.html: Removed.
  • fast/forms/time/ValidityState-stepMismatch-time-expected.txt: Removed.
  • fast/forms/time/ValidityState-stepMismatch-time.html: Removed.
  • fast/forms/time/ValidityState-typeMismatch-time-expected.txt: Removed.
  • fast/forms/time/ValidityState-typeMismatch-time.html: Removed.
  • fast/forms/time/input-valueasdate-time-expected.txt: Removed.
  • fast/forms/time/input-valueasdate-time.html: Removed.
  • fast/forms/time/input-valueasnumber-time-expected.txt: Removed.
  • fast/forms/time/input-valueasnumber-time.html: Removed.
  • fast/forms/time/time-validity-state-range-overflow-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-rangeOverflow-time-expected.txt.
  • fast/forms/time/time-validity-state-range-overflow.html: Copied from LayoutTests/fast/forms/time/ValidityState-rangeOverflow-time.html.
  • fast/forms/time/time-validity-state-range-underflow-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt.
  • fast/forms/time/time-validity-state-range-underflow.html: Copied from LayoutTests/fast/forms/time/ValidityState-rangeUnderflow-time.html.
  • fast/forms/time/time-validity-state-step-mismatch-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-stepMismatch-time-expected.txt.
  • fast/forms/time/time-validity-state-step-mismatch.html: Copied from LayoutTests/fast/forms/time/ValidityState-stepMismatch-time.html.
  • fast/forms/time/time-validity-state-type-mismatch-expected.txt: Copied from LayoutTests/fast/forms/time/ValidityState-typeMismatch-time-expected.txt.
  • fast/forms/time/time-validity-state-type-mismatch.html: Copied from LayoutTests/fast/forms/time/ValidityState-typeMismatch-time.html.
  • fast/forms/time/time-valueasdate-expected.txt: Copied from LayoutTests/fast/forms/time/input-valueasdate-time-expected.txt.
  • fast/forms/time/time-valueasdate.html: Copied from LayoutTests/fast/forms/time/input-valueasdate-time.html.
  • fast/forms/time/time-valueasnumber-expected.txt: Copied from LayoutTests/fast/forms/time/input-valueasnumber-time-expected.txt.
  • fast/forms/time/time-valueasnumber.html: Copied from LayoutTests/fast/forms/time/input-valueasnumber-time.html.
21:17 Changeset [123421] by commit-queue@webkit.org

[chromium] Add droppedFrameCount to renderingStats.
https://bugs.webkit.org/show_bug.cgi?id=91694

Patch by Dave Tu <dtu@chromium.org> on 2012-07-23
Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebRenderingStats.h:

(WebRenderingStats):
(WebKit::WebRenderingStats::WebRenderingStats):

Source/WebCore:

  • platform/graphics/chromium/cc/CCFrameRateCounter.cpp:

(WebCore):
(WebCore::CCFrameRateCounter::frameInterval):
(WebCore::CCFrameRateCounter::frameIndex):
(WebCore::CCFrameRateCounter::CCFrameRateCounter):
(WebCore::CCFrameRateCounter::markBeginningOfFrame):
(WebCore::CCFrameRateCounter::isBadFrame):

  • platform/graphics/chromium/cc/CCFrameRateCounter.h:

(WebCore::CCFrameRateCounter::droppedFrameCount):
(CCFrameRateCounter):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::renderingStats):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderingStats.h:

(CCRenderingStats):
(WebCore::CCRenderingStats::CCRenderingStats):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::implSideRenderingStats):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::implSideRenderingStatsOnImplThread):

Source/WebKit/chromium:

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::renderingStats):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):

19:55 Changeset [123420] by mitz@apple.com

Fixed the build after r123418.

  • WebCore.exp.in: Added DocumentMarkerController::addTextMatchMarker.
19:44 Changeset [123419] by mikelawther@chromium.org

CSS3 calc: optimise blending expression
https://bugs.webkit.org/show_bug.cgi?id=90037

Reviewed by Tony Chang.

Introduce a new calc expression node - a BlendLength node. Given two Lengths and a progress
this blends them together when evaluated.

An alternative and more general approach of being able to blend two CalcExpressionNodes was
tested, but involves more memory allocations, was measurably slower, and nothing currently
would make use of the generality.

No functional change. Covered by existing tests.

  • platform/CalculationValue.h:

(CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::operator==):
(WebCore::CalcExpressionBlendLength::evaluate):
(WebCore):

  • platform/Length.cpp:

(WebCore::Length::blendCalculation):

19:19 Changeset [123418] by thakis@chromium.org

[chromium] Show search tickmarks on css-styled scrollbars
https://bugs.webkit.org/show_bug.cgi?id=91949

Reviewed by Adrienne Walker.

This is done by letting RenderScrollbarTheme::paintTickmarks()
delegate to the native ScrollbarTheme. To make this possible,
move paintTickmarks() from ScrollbarThemeComposite to the
superclass ScrollbarTheme.

For testing, add internals.addTextMatchMarker() and add a pixel test.

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::paintTickmarks):
Moved paintTickmarks() from ScrollbarThemeComposite to here.

  • platform/ScrollbarThemeComposite.h:

Remove paintTickmarks().

  • platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::paintTickmarks):
Switch to drawing tickmarks as vectors, so they can be arbitrarily wide.

  • platform/chromium/ScrollbarThemeChromiumMac.h:

(ScrollbarThemeChromiumMac):
Implement paintTickmarks(), so that css-styled scrollbars get tickmarks on mac.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::paint):
(WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
Implement paintTickmarks(), so that css-styled scrollbars get tickmarks on mac.

  • rendering/RenderScrollbarTheme.cpp:

(WebCore::RenderScrollbarTheme::paintTickmarks):
Delegate to the native ScrollbarTheme for tickmark drawing.
(WebCore):

  • rendering/RenderScrollbarTheme.h:

(RenderScrollbarTheme):
Override paintTickmarks().

19:13 Changeset [123417] by fpizlo@apple.com

Property storage should grow in reverse address direction, to support butterflies
https://bugs.webkit.org/show_bug.cgi?id=91788

Reviewed by Geoffrey Garen.

Changes property storage to grow to the left, and changes the property storage pointer to point
one 8-byte word (i.e. JSValue) to the right of the first value in the storage.

Also improved debug support somewhat, by adding a describe() function to the jsc command-line,
and a slow mode of object access in LLInt.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::repatchCompact):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::isCompactPtrAlignedAddressOffset):
(JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::isCompactPtrAlignedAddressOffset):
(JSC::MacroAssemblerX86Common::repatchCompact):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::repatchCompact):

  • bytecode/CodeBlock.cpp:

(JSC::dumpStructure):

  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryCacheGetByID):
(JSC::DFG::emitPutTransitionStub):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::genericAddPointer):

  • heap/CopiedSpace.h:

(CopiedSpace):

  • heap/CopiedSpaceInlineMethods.h:

(JSC::CopiedSpace::pinIfNecessary):
(JSC):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetDirectOffset):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetDirectOffset):

  • jit/JITStubs.cpp:

(JSC::JITThunks::tryCacheGetByID):

  • jsc.cpp:

(GlobalObject::finishCreation):
(functionDescribe):

  • llint/LLIntCommon.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):
(JSC::JSObject::growOutOfLineStorage):

  • runtime/JSObject.h:

(JSC::JSObject::getDirectLocation):
(JSC::JSObject::offsetForLocation):

  • runtime/JSValue.h:

(JSValue):

  • runtime/PropertyOffset.h:

(JSC::offsetInOutOfLineStorage):

19:03 Changeset [123416] by commit-queue@webkit.org

[chromium] Use shallow flushes that don't glFlush
https://bugs.webkit.org/show_bug.cgi?id=90325

Patch by Brian Anderson <brianderson@chromium.org> on 2012-07-23
Reviewed by Kenneth Russell.

Source/Platform:

Adds shallowFlushCHROMIUM to WebGraphicsContext3D.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::shallowFlushCHROMIUM):

Source/WebCore:

Adds plumbing for the shallowFlushCHROMIUM extension and uses
shallow flushes instead of normal flushes when uploading textures.
Shallow flushes allow us to initiate command buffer flushes to
the GPU thread/process without the overhead of a true glFlush.

CCTextureUpdaterTest updated to recognize shallow flushes.

  • platform/chromium/support/Extensions3DChromium.cpp:

(WebCore::Extensions3DChromium::shallowFlushCHROMIUM):
(WebCore):

  • platform/graphics/chromium/Extensions3DChromium.h:

(Extensions3DChromium):

  • platform/graphics/chromium/cc/CCGraphicsContext.h:
  • platform/graphics/chromium/cc/CCResourceProvider.cpp:

(WebCore::CCResourceProvider::shallowFlushIfSupported):
(WebCore):
(WebCore::CCResourceProvider::CCResourceProvider):
(WebCore::CCResourceProvider::initialize):

  • platform/graphics/chromium/cc/CCResourceProvider.h:

(CCResourceProvider):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::update):

Source/WebKit/chromium:

Changed CCTextureUpdaterTest to recognize shallowFlushCHROMIUM().

  • tests/CCTextureUpdaterTest.cpp:
18:59 Changeset [123415] by commit-queue@webkit.org

Disable flexbox on Windows
https://bugs.webkit.org/show_bug.cgi?id=92047
<rdar://problem/11570384>

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Darin Adler.

Disabled Flexbox CSS3 syntax on Mac, need to do the same for Windows.

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:

Disable ENABLE_CSS3_FLEXBOX property.

LayoutTests:

  • platform/win/Skipped:

Add related CSS3 Flexbox tests to skip list.

18:14 Changeset [123414] by commit-queue@webkit.org

Source/WebCore: When using TextureMapper, WebKit does not retain final value of opacity in animations, unless it is specified on the last key frame.
https://bugs.webkit.org/show_bug.cgi?id=91322

Patch by Hanyee Kim <choco@company100.net> on 2012-07-23
Reviewed by Noam Rosenthal.

When -webkit-fill-mode is forwards, GraphicsLayerAnimation::apply does not apply
the property values defined in the last executing keyframe after the final iteration of animation.

This patch does not return right after the end of animation, but it keeps applying
the property values defined in the last executing keyframe.
Add normalizedAnimationValueForFillsForwards function that returns a normalized value of the
last executing keyframe.

Link to CSS Animations spec: http://www.w3.org/TR/css3-animations/#animation-fill-mode-property

Test: animations/fill-mode-forwards2.html

  • platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::normalizedAnimationValueForFillsForwards):
(WebCore):
(WebCore::GraphicsLayerAnimation::apply):

LayoutTests: WebKit does not retain final value of opacity in animations, unless it is specified on the last key frame
https://bugs.webkit.org/show_bug.cgi?id=91322

Patch by Hanyee Kim <choco@company100.net> on 2012-07-23
Reviewed by Noam Rosenthal.

Added a test to check if the opacity has the right value after animation.

  • animations/fill-mode-forwards2-expected.txt: Added.
  • animations/fill-mode-forwards2.html: Added.
18:13 FeatureFlags edited by tkent@chromium.org
Add CSS_STICKY_POSITION (diff)
17:57 Changeset [123413] by enne@google.com

[chromium] Add more compositor unit tests for high DPI transforms
https://bugs.webkit.org/show_bug.cgi?id=91917

Reviewed by Kenneth Russell.

The current set of high DPI tests only deal with layers in a render
surface. Add some extra tests for non-surface layers. Also add a test
to make sure that an owning layer in a surface doesn't differ from a
non-owning layer in high DPI circumstances.

  • tests/CCLayerTreeHostCommonTest.cpp:
17:53 Changeset [123412] by commit-queue@webkit.org

Unreviewed, rolling out r123184, r123195, and r123197.
http://trac.webkit.org/changeset/123184
http://trac.webkit.org/changeset/123195
http://trac.webkit.org/changeset/123197
https://bugs.webkit.org/show_bug.cgi?id=92049

pagecycler regression (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::suggestedMIMEType):

  • dom/Document.h:

(WebCore):
(WebCore::Node::isDocumentNode):
(WebCore::Node::Node):

  • dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::setDocument):
(WebCore):
(WebCore::Node::setTreeScope):
(WebCore::Node::treeScope):
(WebCore::Node::isInShadowTree):
(WebCore::Node::reportMemoryUsage):

  • dom/Node.h:

(Node):
(WebCore::Node::document):
(WebCore::Node::inDocument):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::treeScope):
(WebCore::NodeRareData::setTreeScope):
(NodeRareData):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::setParentTreeScope):

  • dom/TreeScope.h:

(WebCore):
(WebCore::TreeScope::idTargetObserverRegistry):
(TreeScope):

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):

  • editing/MoveSelectionCommand.cpp:
  • editing/RemoveNodeCommand.cpp:
  • editing/RemoveNodePreservingChildrenCommand.cpp:
  • inspector/PageConsoleAgent.cpp:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
17:48 Changeset [123411] by commit-queue@webkit.org

.: If select element in Windows is off screen horizontally,
menu is either inappropriately resized or positioned offscreen.
https://bugs.webkit.org/show_bug.cgi?id=91913
<rdar://problem/7611229>

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Tim Horton.

Add a manual test to verify that popup menus render in the correct place.

  • ManualTests/win/select-menu-off-screen.html: Added.

Source/WebCore: On Windows, if select element is off screen horizontally,
menu is either inappropriately resized or positioned offscreen.
https://bugs.webkit.org/show_bug.cgi?id=91913
<rdar://problem/7611229>

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-23
Reviewed by Tim Horton.

If the select element is positioned off the edge of the screen to the left,
the menu is resized. It should not be resized, just shifted to remain on the screen.
If the select element is positioned off the edge of the screen to the right,
the menu goes off screen instead of being shifted over to appear on screen.
This problem only occurs on Windows.

Test: ManualTests/win/select-menu-off-screen.html

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):
Modified final horizontal position calculation code to position
popup menu on screen if it would otherwise go off.

17:42 Changeset [123410] by lforschler@apple.com

New Tag.

17:37 Changeset [123409] by commit-queue@webkit.org

Fixed crash in webkitAddKey() when key parameter is null.
https://bugs.webkit.org/show_bug.cgi?id=85444

Patch by David Dorwin <ddorwin@chromium.org> on 2012-07-23
Reviewed by Kentaro Hara.

Reference: Step 1 of http://dvcs.w3.org/hg/html-media/raw-file/5f76a0b43836/encrypted-media/encrypted-media.html#dom-addkey

Source/WebCore:

Tests: media/encrypted-media/encrypted-media-syntax.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::webkitAddKey):

LayoutTests:

  • media/encrypted-media/encrypted-media-syntax-expected.txt:
  • media/encrypted-media/encrypted-media-syntax.html:
17:36 Changeset [123408] by tony@chromium.org

http/tests/multipart/policy-ignore-crash.php is failing on Chromium
https://bugs.webkit.org/show_bug.cgi?id=92046

Reviewed by Adam Barth.

Chromium's network layer now shows most text/* mime types. This test was using text/random to
try to trigger a crash when multipart content switch from a text type to a non-text type.
Change the test to use a text type that we don't render.

  • http/tests/multipart/policy-ignore-crash.php: Use text/rtf instead of text/random.
  • platform/chromium/TestExpectations: Test should be passing again.
17:12 Changeset [123407] by hayato@chromium.org

A FocusScope for a distributed node should not be its TreeScope.
https://bugs.webkit.org/show_bug.cgi?id=91829

Reviewed by Dimitri Glazkov.

Source/WebCore:

Current implementation of FocusScope::focusScopeOf(Node*) returns
the given node's treeScope(). That does not apply if the node is
a distributed node. We should calculate a FocusScope for a
distributed node by traversing ancestor nodes in Composed Shadow
Tree.

Test: fast/dom/shadow/focus-navigation-with-distributed-nodes.html

  • page/FocusController.cpp:

(WebCore::FocusScope::focusScopeOf):

LayoutTests:

  • fast/dom/shadow/focus-navigation-with-distributed-nodes-expected.txt: Added.
  • fast/dom/shadow/focus-navigation-with-distributed-nodes.html: Added.
  • fast/dom/shadow/resources/shadow-dom.js:

(shouldNavigateFocus):

17:06 Changeset [123406] by commit-queue@webkit.org

Null-pointer crash when parsing border-image
https://bugs.webkit.org/show_bug.cgi?id=91963

Patch by Douglas Stockwell <dstockwell@google.com> on 2012-07-23
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/border-image-fill-crash.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseBorderImageRepeat): Handle the case where
parseBorderImageRepeat is called when the value list is empty.

LayoutTests:

  • fast/css/border-image-fill-crash-expected.txt: Added.
  • fast/css/border-image-fill-crash.html: Added.
16:56 Changeset [123405] by commit-queue@webkit.org

[CSS Exclusions] SVG shape errors should invalidate exclusion shapes
https://bugs.webkit.org/show_bug.cgi?id=91761

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2012-07-23
Reviewed by Andreas Kling.

Source/WebCore:

CSS exclusion shapes that are specified with negative radiuses or
height/width are now considered invalid and ignored.

Tests added to
LayoutTests/fast/exclusions/parsing-wrap-shape-lengths.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseExclusionShapeRectangle):
(WebCore::CSSParser::parseExclusionShapeCircle):
(WebCore::CSSParser::parseExclusionShapeEllipse):

LayoutTests:

Test that negative heights. widths, and radiuses are ignored.

  • fast/exclusions/parsing-wrap-shape-lengths-expected.txt:
  • fast/exclusions/parsing-wrap-shape-lengths.html:
16:46 Changeset [123404] by caio.oliveira@openbossa.org

[Qt] css3/selectors3 rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92038

Reviewed by Alexis Menard.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk2/Skipped: These tests are failing because of <input> default size in

WK2, which is different than the expected results generated from WK1. Moved them to
appropriate block in skipped list.

  • platform/qt-5.0/Skipped:
  • platform/qt/css3/selectors3/html/css3-modsel-21c-expected.png:
  • platform/qt/css3/selectors3/html/css3-modsel-21c-expected.txt:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-21c-expected.png:
  • platform/qt/css3/selectors3/xhtml/css3-modsel-21c-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-148-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-148-expected.txt:
  • platform/qt/css3/selectors3/xml/css3-modsel-21c-expected.png:
  • platform/qt/css3/selectors3/xml/css3-modsel-21c-expected.txt:
16:40 Changeset [123403] by tony@chromium.org

Unreviewed gardening. Land pixel results for fast/frames/valid.html on chromium mac snowleopard.

  • fast/frames/valid-expected.txt: Renamed from LayoutTests/platform/efl/fast/frames/valid-expected.txt.
  • platform/chromium-mac-snowleopard/fast/frames/valid-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/gtk/fast/frames/valid-expected.txt: Removed.
  • platform/mac/fast/frames/valid-expected.txt: Removed.
16:38 Changeset [123402] by commit-queue@webkit.org

[chromium] Implement scrollbar theme for Android
https://bugs.webkit.org/show_bug.cgi?id=91674

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-07-23
Reviewed by Adam Barth.

Previously the scrollbar for Android was implemented as an extra
drawing pass in the compositor. Now we switch to use the standard
ScrollbarTheme mechanism.

No new tests. We use mock scrollbars during layout test to share
pixel results with Linux.

  • platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

(WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumAndroid::thumbPosition):
(WebCore::ScrollbarThemeChromiumAndroid::thumbLength):
(WebCore::ScrollbarThemeChromiumAndroid::backButtonRect):
(WebCore::ScrollbarThemeChromiumAndroid::forwardButtonRect):
(WebCore::ScrollbarThemeChromiumAndroid::trackRect):
(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::paintThumb):
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):

  • platform/chromium/ScrollbarThemeChromiumAndroid.h:

(WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
(ScrollbarThemeChromiumAndroid):
(WebCore::ScrollbarThemeChromiumAndroid::hasButtons):
(WebCore::ScrollbarThemeChromiumAndroid::hasThumb):

16:37 Changeset [123401] by atwilson@chromium.org

Unreviewed chromium expectations change to mark test as slow: fast/forms/select-set-length-with-mutation-remove.html.

  • platform/chromium/TestExpectations:
16:33 Changeset [123400] by wsiegrist@apple.com

Update website for new hardware.

16:15 Changeset [123399] by kseo@webkit.org

Use the original token to create an element in "reconstruct the active formatting elements" and "call the adoption agency"
https://bugs.webkit.org/show_bug.cgi?id=91703

Reviewed by Adam Barth.

Source/WebCore:

The current WebKit HTML5 parser implementation does not hold the original token
in the stack of open elements and the active formatting elements. This is
problematic because the original token is used to create an element in
"reconstruct the active formatting elements" and "call the adoption agency".

As a workaround, WebKit uses the saved element instead of the original token
to create an element. But this causes us to fail examples like this:
<b id="1"><p><script>document.getElementById("1").id = "2"</script></p>TEXT</b>
reconstructTheActiveFormattingElements calls this method to open a second <b>
tag to wrap TEXT, it will have id "2", even though the HTML5 spec implies it
should be "1".

Created a ref-counted container class, HTMLStackItem to hold the original token
and the namespace URI as well as the element. Changed HTMLElementStack and
HTMLFormattingElementList to use HTMLStackItem.
Changed HTMLConstructionSite::reconstructTheActiveFormattingElements and
HTMLTreeBuilder::callTheAdoptionAgency to create an element from the saved token
instead of the saved element.

Updated test expectation for html5lib/runner-expected.txt
because now resources/scripted/adoption01.dat passes.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElementFromSavedToken):
(WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements):

  • html/parser/HTMLConstructionSite.h:

(HTMLConstructionSite):
(WebCore::HTMLConstructionSite::currentElementRecord):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::pushRootNode):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::pushRootNodeCommon):
(WebCore::HTMLElementStack::pushHTMLHeadElement):
(WebCore::HTMLElementStack::pushHTMLBodyElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::pushCommon):

  • html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::ElementRecord::element):
(WebCore::HTMLElementStack::ElementRecord::node):
(WebCore::HTMLElementStack::ElementRecord::stackItem):
(ElementRecord):
(HTMLElementStack):

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::swapTo):
(WebCore::HTMLFormattingElementList::append):

  • html/parser/HTMLFormattingElementList.h:

(WebCore::HTMLFormattingElementList::Entry::Entry):
(WebCore::HTMLFormattingElementList::Entry::isMarker):
(WebCore::HTMLFormattingElementList::Entry::stackItem):
(WebCore::HTMLFormattingElementList::Entry::element):
(WebCore::HTMLFormattingElementList::Entry::replaceElement):
(WebCore::HTMLFormattingElementList::Entry::operator==):
(WebCore::HTMLFormattingElementList::Entry::operator!=):
(Entry):
(HTMLFormattingElementList):

  • html/parser/HTMLStackItem.h: Added.

(WebCore):
(HTMLStackItem):
(WebCore::HTMLStackItem::create):
(WebCore::HTMLStackItem::element):
(WebCore::HTMLStackItem::node):
(WebCore::HTMLStackItem::token):
(WebCore::HTMLStackItem::namespaceURI):
(WebCore::HTMLStackItem::HTMLStackItem):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

LayoutTests:

Updated test expectation for html5lib/runner-expected.txt
because now resources/scripted/adoption01.dat passes.

  • html5lib/runner-expected.txt:
16:12 Writing Reftests edited by hayato@chromium.org
(diff)
16:06 Changeset [123398] by shawnsingh@chromium.org

[chromium] Fix unit tests in debug mode after r123375
https://bugs.webkit.org/show_bug.cgi?id=92030

Reviewed by Adrienne Walker.

Fixed two unit tests that were causing debug assertions because
they gave calcDrawTransforms an empty sized root layer.

  • tests/CCLayerTreeHostCommonTest.cpp:
15:57 Changeset [123397] by rafael.lobo@openbossa.org

[Qt] svg/{in-html,overflow,repaint,wicd} needs update after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92023

Unreviewed gardening.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.png: Removed.
  • platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.txt: Removed.
  • platform/qt/Skipped:
  • platform/qt/svg/in-html/by-reference-expected.txt:
  • platform/qt/svg/in-html/circle-expected.png:
  • platform/qt/svg/in-html/circle-expected.txt:
  • platform/qt/svg/overflow/overflow-on-foreignObject-expected.png:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
  • platform/qt/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
  • platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.png.
  • platform/qt/svg/repaint/inner-svg-change-viewBox-contract-expected.txt: Added.
  • platform/qt/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
  • platform/qt/svg/repaint/inner-svg-change-viewBox-expected.txt: Added.
  • platform/qt/svg/repaint/inner-svg-change-viewPort-relative-expected.txt:
  • platform/qt/svg/repaint/mask-clip-target-transform-expected.png: Added.
  • platform/qt/svg/repaint/text-mask-update-expected.png: Copied from LayoutTests/platform/qt/svg/overflow/overflow-on-foreignObject-expected.png.
  • platform/qt/svg/repaint/text-mask-update-expected.txt: Added.
  • platform/qt/svg/wicd/rightsizing-grid-expected.png:
  • platform/qt/svg/wicd/rightsizing-grid-expected.txt:
  • platform/qt/svg/wicd/sizing-flakiness-expected.txt:
  • platform/qt/svg/wicd/test-rightsizing-a-expected.png:
  • platform/qt/svg/wicd/test-rightsizing-a-expected.txt:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.png:
  • platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/qt/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/qt/svg/wicd/test-scalable-background-image1-expected.txt:
  • platform/qt/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/qt/svg/wicd/test-scalable-background-image2-expected.txt:
15:56 Changeset [123396] by kling@webkit.org

Report the extra memory used by immutable StylePropertySet objects.
<http://webkit.org/b/92032>

Reviewed by Anders Carlsson.

Add an optional parameter to the MemoryClassInfo constructor for passing in additional base object
size on top of sizeof(T).

Use this in StylePropertySet::reportMemoryUsage() to properly account for the CSSProperty array
tacked onto the end of the object when m_isMutable == false.

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::reportMemoryUsage):

  • dom/MemoryInstrumentation.h:

(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):

15:53 Changeset [123395] by commit-queue@webkit.org

Fix WebGL texSubImage2D for cube maps
https://bugs.webkit.org/show_bug.cgi?id=91927

Patch by Gregg Tavares <gman@google.com> on 2012-07-23
Reviewed by Kenneth Russell.

Source/WebCore:

Fixes texSubImage2D so any size rectangle can be passed in
for cube maps.

Test: fast/canvas/webgl/tex-sub-image-cube-maps.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

LayoutTests:

Tests for WebGL texSubImage2D for cube maps.

  • fast/canvas/webgl/tex-sub-image-cube-maps-expected.txt: Added.
  • fast/canvas/webgl/tex-sub-image-cube-maps.html: Added.
15:46 Changeset [123394] by fpizlo@apple.com

DFG is too aggressive in performing the specific value optimization on loads
https://bugs.webkit.org/show_bug.cgi?id=92034

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

This ensures that we don't do optimizations based on a structure having a specific
value, if there is no way to detect that the value is despecified. This is the
case for dictionaries, since despecifying a value in a dictionary does not lead to
a transition and so cannot be caught by either structure checks or structure
transition watchpoints.

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

  • bytecode/ResolveGlobalStatus.cpp:

(JSC::computeForStructure):

LayoutTests:

  • fast/js/dfg-resolve-global-polymorphic-non-dictionary-expected.txt: Added.
  • fast/js/dfg-resolve-global-polymorphic-non-dictionary.html: Added.
  • fast/js/dfg-resolve-global-specific-dictionary-expected.txt: Added.
  • fast/js/dfg-resolve-global-specific-dictionary.html: Added.
  • fast/js/script-tests/dfg-resolve-global-polymorphic-non-dictionary.js: Added.

(description.foo):

  • fast/js/script-tests/dfg-resolve-global-specific-dictionary.js: Added.

(description.foo):
(x):

15:38 Changeset [123393] by fpizlo@apple.com

REGRESSION(r123169): It made fast/js/dfg-inline-arguments-use-from-uninlined-code.html fail on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=92002

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

In the process of changing the nature of local variable typing, I forgot to modify one of the places where
we glue the DFG's notion of variable prediction to the runtime's notion of variable tagging.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Unskip test that this change fixes, as requested by Ossy.

  • platform/qt/Skipped:
15:36 Changeset [123392] by commit-queue@webkit.org

Unreviewed, rolling out r123387.
http://trac.webkit.org/changeset/123387
https://bugs.webkit.org/show_bug.cgi?id=92036

Broke chromium win build (Requested by tonywork on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_bison.py:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

  • make-hash-tools.pl:
15:34 Changeset [123391] by commit-queue@webkit.org

[BlackBerry] Move about: URL handling out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91541

Patch by Yong Li <yoli@rim.com> on 2012-07-23
Reviewed by Rob Buis.

PR# 181304.
Move about: URL handling to the right place (FrameLoaderClientBlackBerry::createDocumentLoader), so
reload and history navigation can work.
Other changes: Remove about:version which makes little sense. Make about:memory partially visible.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::load): Remove the call to loadAbout()

  • Api/WebPage_p.h: Remove loadAbout()

(WebPagePrivate):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::createDocumentLoader): Construct about: data here.

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::numberToHTMLTr): Make it static
(BlackBerry::WebKit::configPage): Make it static
(BlackBerry::WebKit::memoryPage): Make it static
(BlackBerry::WebKit::cachePage):
(BlackBerry::WebKit::buildPage):
(BlackBerry::WebKit::creditsPage):
(BlackBerry::WebKit::cookiePage):
(BlackBerry::WebKit::aboutData): The only export function that returns HTML source for a given about: URL.
(WebKit):

  • WebKitSupport/AboutData.h:

(WebKit):

15:09 Changeset [123390] by dpranke@chromium.org

Unreviewed, rolling out r123360.
http://trac.webkit.org/changeset/123360
https://bugs.webkit.org/show_bug.cgi?id=91890

broke the chromium bots

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_build_path):

15:02 Changeset [123389] by kseo@webkit.org

Ref-count AtomicHTMLToken
https://bugs.webkit.org/show_bug.cgi?id=91981

Reviewed by Adam Barth.

Ref-count AtomicHTMLToken to avoid copying AtomicHTMLToken in Bug 91703.

No new tests - no functional changes.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):

  • html/parser/HTMLConstructionSite.h:

(HTMLConstructionSite):

  • html/parser/HTMLToken.h:

(WebCore::AtomicHTMLToken::create):
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::constructTreeFromToken):
(WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
(WebCore::HTMLTreeBuilder::parseError):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

14:54 Changeset [123388] by atwilson@chromium.org

More unreviewed chromium expectation changes to mark tests as failing/slow.

  • platform/chromium/TestExpectations:
14:52 Changeset [123387] by tony@chromium.org

Use native (non-cygwin) binaries for perl, gperf, and bison in Chromium
https://bugs.webkit.org/show_bug.cgi?id=91667

Patch by Scott Graham <scottmg@google.com> on 2012-07-23
Reviewed by Tony Chang.

Using native tools instead of cygwin version improves build time
performance by roughly 50% (on top of previous cl-instead-of-gcc
change).

Also, use - instead of / for cl flags because a layer of project
generator converts them to \ otherwise, which causes the preprocessing
to fail (very slowly because of the cygwin-loop with a sleep 1).

No new tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gyp/scripts/rule_bison.py:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

  • make-hash-tools.pl:
14:39 Changeset [123386] by jer.noble@apple.com

MediaController.currentTime should be kept stable during script execution.
https://bugs.webkit.org/show_bug.cgi?id=88555

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-controller-time-constant.html

To keep MediaController.currentTime stable, add a new m_position variable and
a new m_clearPositionTimer timer. Both must be mutable variables as they will
be updated from within const functions. Calls to currentTime() will result in
stable values until the next runloop iteration.

  • html/MediaController.cpp:

(MediaController::MediaController):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::clearPositionTimerFired):

  • html/MediaController.h:

LayoutTests:

  • media/media-controller-time-constant-expected.txt: Added.
  • media/media-controller-time-constant.html: Added.
14:38 Changeset [123385] by kseo@webkit.org

Destroy CSS decoded data more eagerly once they become dead caches.
https://bugs.webkit.org/show_bug.cgi?id=91733

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-23
Reviewed by Geoffrey Garen.

Internal review by Kwang Yul Seo.

There are three CachedResources with decoded data: CachedImage, CachedScript
and CachedCSSStyleSheet. In the cases of CachedImage and CachedScript, we
eagerly destroy the decoded data using Timer in CacehdResource::allClientsRemoved().
We must apply the same policy here in CachedCSSStyleSheet because priority
inversion can occur. For example, we can't destroy the decoded data of CachedImages
when they are referenced by CachedCSSStyleSheet as background, mask or border
images.

No new tests - no new testable functionality.

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::allClientsRemoved):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):
(WebCore):
(WebCore::CachedCSSStyleSheet::decodedDataDeletionTimerFired):

  • loader/cache/CachedCSSStyleSheet.h:

(CachedCSSStyleSheet):

14:24 Changeset [123384] by abarth@webkit.org

[Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
https://bugs.webkit.org/show_bug.cgi?id=91459

Reviewed by Ryosuke Niwa.

Rather than having TestShell own and bind each of these JavaScript APIs
individually, TestShell should delegate that work to TestInterfaces.
This patch moves AccessibilityController and TextInputController to be
the responsibility of TestInterfaces.

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:

(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::setWebView):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.h:

(WebKit):
(TestInterfaces):
(TestInterfaces::accessibilityController):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::accessibilityController):
(TestShell):

14:23 Changeset [123383] by caio.oliveira@openbossa.org

[Qt] dom/xhtml/level3/core rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92028

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt:
  • platform/qt/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt:
  • platform/qt/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt:
  • platform/qt/dom/xhtml/level3/core/nodelookupprefix19-expected.txt:
14:21 Changeset [123382] by kbalazs@webkit.org

nrwt swallows early exceptions
https://bugs.webkit.org/show_bug.cgi?id=91884

Reviewed by Dirk Pranke.

Put everything in a try block so we won't miss any error.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):
(main):

14:07 Changeset [123381] by scherkus@chromium.org

Merge 123272 - [chromium] Don't display fullscreen button for video elements not containing video
https://bugs.webkit.org/show_bug.cgi?id=91811

Reviewed by Eric Carlson.

Covered by media/media-document-audio-repaint.html

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::reset):

TBR=scherkus@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10800085

14:04 Changeset [123380] by scherkus@chromium.org

Merge 123259 - [chromium] CSS tweaks to media controls to prevent styles from being overridden
https://bugs.webkit.org/show_bug.cgi?id=91802

Reviewed by Eric Carlson.

Source/WebCore:

Having the buttons declared as inline caused them to not be included in the box layout,
resulting in styles set outside the media element to affect the position of the buttons.

In a similar vein, it was also possible to override the font-style attribute for the time
display.

Test: media/controls-styling-strict.html

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):

LayoutTests:

  • media/controls-styling-strict.html: Added.
  • platform/chromium-linux/media/controls-styling-strict-expected.png: Added.
  • platform/chromium-linux/media/controls-styling-strict-expected.txt: Added.

TBR=scherkus@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10807077

14:03 Changeset [123379] by simon.fraser@apple.com

Part 2 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Source/JavaScriptCore:

Turn on ENABLE_CSS_STICKY_POSITION.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Turn on ENABLE_CSS_STICKY_POSITION. Add support for parsing the new '-webkit-sticky'
value for position, returning it from getComputedStyle(), and storing it in RenderStyle.

Test: fast/css/sticky/parsing-position-sticky.html

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getPositionOffsetValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EPosition):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

Source/WebKit/chromium:

Turn on ENABLE_CSS_STICKY_POSITION.

  • features.gypi:

Source/WebKit/mac:

Turn on ENABLE_CSS_STICKY_POSITION.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Turn on ENABLE_CSS_STICKY_POSITION.

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

Test for parsing and returning fro getComputedStyle() the new
-webkit-sticky value for position.

  • fast/css/sticky/parsing-position-sticky-expected.txt: Added.
  • fast/css/sticky/parsing-position-sticky.html: Added.
  • fast/css/sticky/resources/parsing-position-sticky.js: Added.

(test):

14:03 Changeset [123378] by atwilson@chromium.org

Unreviewed chromium expectations change to mark media/media-fragments/TC0010-TC0019.html as flaky/crashy.

  • platform/chromium/TestExpectations:
13:57 Changeset [123377] by schenney@chromium.org

Crash when setting empty class name on a new element
https://bugs.webkit.org/show_bug.cgi?id=92024

Reviewed by Andreas Kling.

Source/WebCore:

Add a check for null attributeData() when setting the className to an
empty string on a newly created element. New SVG elements have null
attributeData() on baseVal upon creation.

Test: svg/custom/empty-className-baseVal-crash.html

  • dom/StyledElement.cpp:

(WebCore::StyledElement::classAttributeChanged): Add check for null attributeData()

LayoutTests:

Add a check for null attributeData() when setting the className to an
empty string on a newly created element.

  • svg/custom/empty-className-baseVal-crash-expected.txt: Added.
  • svg/custom/empty-className-baseVal-crash.html: Added.
13:53 Changeset [123376] by paroga@webkit.org

Move JSC::parseDate() from DateConversion to JSDateMath
https://bugs.webkit.org/show_bug.cgi?id=91982

Reviewed by Geoffrey Garen.

Moveing this function into the other files removes the dependency
on JSC spcific classes in DateConversion.{cpp|h}.

  • runtime/DateConversion.cpp:
  • runtime/DateConversion.h:

(JSC):

  • runtime/JSDateMath.cpp:

(JSC::parseDate):
(JSC):

  • runtime/JSDateMath.h:

(JSC):

13:46 Changeset [123375] by shawnsingh@chromium.org

[chromium] Refactor CCLayerTreeHostCommon: clean up clipRect and drawableContentRect design
https://bugs.webkit.org/show_bug.cgi?id=80622

Reviewed by Adrienne Walker.

Source/WebCore:

clipRect(), usesLayerClipping(), and drawableContentRect() have been
very confusing in CCLayerTreeHostCommon for a while. This patch
refactors it so that (1) clipping is only done locally in
calcDrawTransforms, and (2) the layer's drawableContentRect value
is now meaningful value outside of calcDrawTransforms.
Additionally, the layer is now always clipped to the root
surface's contentBounds (which are set to the viewport bounds).
This refactor not only makes calcDrawTransforms far more readable and intuitive, but
this patch enables more upcoming beneficial refactors, including
the pending refactor in https://bugs.webkit.org/show_bug.cgi?id=88953.

Tests are also significantly updated to keep up with this refactoring change.

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(LayerChromium):
Removed m_usesLayerClipping and m_clipRect and associated accessors.

  • platform/graphics/chromium/RenderSurfaceChromium.h:

(RenderSurfaceChromium):
Updated comment

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
Removed m_usesLayerClipping and m_clipRect and associated accessors.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::updateLayers):
removed setClipRect code that no longer applies

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateLayerScissorRect):
scissor rect is now a little bit tighter, the intersection between damage and layer's new drawableContentRect.

(WebCore::calculateSurfaceScissorRect):
scissor rect is now a little bit tighter, except when filters are involved.

(WebCore::layerClipsSubtree):
new helper function

(WebCore):
(WebCore::calculateVisibleContentRect):
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsInternal):

  • added drawableContentRectOfSubtree to the function args, it is valid only after recursion returns,
  • added clipRectFromAncestor and bool ancestorClipsSubtree to function args, this replaces the layer's clipRect and usesLayerClipping.
  • removed the boolean return value, which was redundant with drawableContentRectOfSubtree.
  • replaced all the "setDrawableContentRect" logic with more intuitive, clear logic.
  • now, layer's drawableContentRect represents the clipped bounds of the layer expressed in the target surface space.

(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):
(WebCore::pointIsClippedBySurfaceOrClipRect):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):

  • platform/graphics/chromium/cc/CCOcclusionTracker.cpp:

(WebCore::::layerScissorRectInTargetSurface):
Updated this accessor. It could be removed in the future, but not appropriate for this patch.

  • platform/graphics/chromium/cc/CCRenderSurface.h:

Source/WebKit/chromium:

Many tests needed to be updated because the semantics of the layer tree have changed:

  • a few tests that were no longer applicable were removed.
  • many tests needed to have fixed initialization, properly setting surface contentRect and rootLayer bounds.
  • because clipRect and usesLayerClipping no longer exists, those places in code had to be removed/changed
  • the scissorRect tests needed to have updated expectations because after this patch, the rootLayer Surface now clips to its contentBounds.
  • the clipRect tests were changed to test the layer's new semantics for the drawableContentRect instead.
  • tests/CCLayerImplTest.cpp:

(WebCore::TEST):

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:

(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):

  • tests/LayerChromiumTest.cpp:
13:37 Changeset [123374] by commit-queue@webkit.org

[WK2] WebKitTestRunner needs to print information about Web intents
https://bugs.webkit.org/show_bug.cgi?id=90873

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Anders Carlsson.

Source/WebKit2:

Add Bundle API for Web Intents. This is needed by the WebKitTestRunner
to print information about the new intent requests and the intent
service registrations.

  • CMakeLists.txt: Move WebIntentData and WebIntentServiceInfo from

UIProcess/ to Shared/.

  • GNUmakefile.list.am: Move WebIntentData and WebIntentServiceInfo from

UIProcess/ to Shared/.

  • Shared/APIClientTraits.h:
  • Shared/WebIntentData.cpp: Renamed from Source/WebKit2/UIProcess/WebIntentData.cpp.

(WebKit):
(WebKit::WebIntentData::WebIntentData):
(WebKit::WebIntentData::data):
(WebKit::WebIntentData::suggestions):
(WebKit::WebIntentData::extra):
(WebKit::WebIntentData::extras):

  • Shared/WebIntentData.h: Renamed from Source/WebKit2/UIProcess/WebIntentData.h.

(WebKit):
(WebIntentData):
(WebKit::WebIntentData::create):
(WebKit::WebIntentData::~WebIntentData):
(WebKit::WebIntentData::action):
(WebKit::WebIntentData::payloadType):
(WebKit::WebIntentData::service):
(WebKit::WebIntentData::store):
(WebKit::WebIntentData::type):

  • Shared/WebIntentServiceInfo.cpp: Renamed from Source/WebKit2/UIProcess/WebIntentServiceInfo.cpp.

(WebKit):
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):

  • Shared/WebIntentServiceInfo.h: Renamed from Source/WebKit2/UIProcess/WebIntentServiceInfo.h.

(WebKit):
(WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::create):
(WebKit::WebIntentServiceInfo::~WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::action):
(WebKit::WebIntentServiceInfo::payloadType):
(WebKit::WebIntentServiceInfo::href):
(WebKit::WebIntentServiceInfo::title):
(WebKit::WebIntentServiceInfo::disposition):
(WebKit::WebIntentServiceInfo::type):

  • Target.pri: Move WebIntentData and WebIntentServiceInfo from

UIProcess/ to Shared/.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/efl/ewk_view_loader_client.cpp:

(didReceiveIntentForFrame):
(registerIntentServiceForFrame):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didReceiveIntentForFrame):
(WebKit::WebLoaderClient::registerIntentServiceForFrame):

  • UIProcess/WebLoaderClient.h:

(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::registerIntentServiceForFrame):
(WebKit::WebPageProxy::didReceiveIntentForFrame):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit):
(WebKit::InjectedBundlePageLoaderClient::didReceiveIntentForFrame):
(WebKit::InjectedBundlePageLoaderClient::registerIntentServiceForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

(WebKit):
(InjectedBundlePageLoaderClient):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchIntent):
(WebKit::WebFrameLoaderClient::registerIntentService):

  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

Tools:

Print out information about new intents requests and intent
services registrations in WebKitTestRunner. This is expected
by tests under webintents/*.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didReceiveIntentForFrame):
(WTR):
(WTR::InjectedBundlePage::registerIntentServiceForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

(InjectedBundlePage):

13:32 Changeset [123373] by caio.oliveira@openbossa.org

[Qt] tables/mozilla_expected_failures rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92013

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
13:26 Changeset [123372] by commit-queue@webkit.org

[EFL][WK2] Add unit tests for Ewk_Cookie_Manager
https://bugs.webkit.org/show_bug.cgi?id=91639

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Antonio Gomes.

Add unit tests for Ewk_Cookie_Manager.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/ewk_cookie_manager.h: Fix "accept policy" documentation

to indicate that only cookies set by the main document are accepted by default.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp: Added.

(EWK2UnitTestServer::EWK2UnitTestServer): Add HTTP server similar to the one
used by GTK port unit tests.
(EWK2UnitTestServer::~EWK2UnitTestServer):
(EWK2UnitTestServer::run):
(EWK2UnitTestServer::getURIForPath):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h: Added.

(EWK2UnitTestServer):
(EWK2UnitTestServer::baseURI):

  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp: Added.

(serverCallback):
(getAcceptPolicyCallback):
(getAcceptPolicy):
(getHostnamesWithCookiesCallback):
(getHostnamesWithCookies):
(freeHostNames):
(countHostnamesWithCookies):
(TEST_F):
(cleanUpCookieFiles):

13:23 Changeset [123371] by paroga@webkit.org

Build fix if NOMINMAX is defined by the build system.

  • COMEnumVariant.h: Added #ifndef NOMINMAX around #define NOMINMAX.
  • COMPropertyBag.h: Ditto.
13:22 Changeset [123370] by dcheng@chromium.org

[chromium] Fix build on Ubuntu Precise.
https://bugs.webkit.org/show_bug.cgi?id=92021

Reviewed by Adrienne Walker.

Remove an array that's written but never read.

  • tests/CCResourceProviderTest.cpp:

(WebKit::TEST_F):

13:16 Changeset [123369] by paroga@webkit.org

[CMAKE] Added missing RenderLayerFilterInfo.cpp to build system.

  • CMakeLists.txt:
13:06 Changeset [123368] by atwilson@chromium.org

[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017

Patch by Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> on 2012-07-23
Reviewed by Alexis Menard.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
13:01 Changeset [123367] by caio.oliveira@openbossa.org

[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017

Reviewed by Alexis Menard.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
12:54 Changeset [123366] by rafael.lobo@openbossa.org

[Qt] svg/zoom needs update after new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92007

Reviewed by Alexis Menard.

  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
  • platform/qt-5.0/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
  • platform/qt/Skipped:
  • platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-background-images-expected.png:
  • platform/qt/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/qt/svg/zoom/page/zoom-foreign-content-expected.txt: Added.
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
  • platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Added.
  • platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Added.
  • platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Added.
  • platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Added.
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
12:49 Changeset [123365] by atwilson@chromium.org

Unreviewed chromium expectations change to ignore DEBUG failures for policy-ignore-crash.php.

  • platform/chromium/TestExpectations:
12:44 Changeset [123364] by caio.oliveira@openbossa.org

Unreviewed, rolling out r123362.
http://trac.webkit.org/changeset/123362
https://bugs.webkit.org/show_bug.cgi?id=92020

uploaded wrong expectations :( bad caio (Requested by cmarcelo
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23

  • platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Removed.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Removed.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
12:38 Changeset [123363] by atwilson@chromium.org

Unreviewed chromium expectations change to mark inline-plaintext-relayout-with-leading-neutrals.html flaky.
https://bugs.webkit.org/show_bug.cgi?id=92019

  • platform/chromium/TestExpectations:
12:32 Changeset [123362] by caio.oliveira@openbossa.org

[Qt] tables/mozilla_expected_failures/bugs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92017

Reviewed by Alexis Menard.

  • platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt: Copied from LayoutTests/platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
12:31 Changeset [123361] by japhet@chromium.org

Add WebTextInputType enum values for text areas and
content-editable.
https://bugs.webkit.org/show_bug.cgi?id=91654

Reviewed by Adam Barth.

No new tests, no behavior change without corresponding chromium.org changes.

  • public/WebTextInputType.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputType):

12:26 Changeset [123360] by dpranke@chromium.org

nrwt: never finds binaries in the 'out' dir on chromium win
https://bugs.webkit.org/show_bug.cgi?id=91890

Reviewed by Tony Chang.

We were figuring out which directory look in for binaries by
testing for the base directory (the directory above
Debug/Release). In chromium-win's case, we look in src/build,
which always exists because there are checked-in files in it,
which means we'd always pick that directory over src/out. All of
the other ports' build_path() implementation was including
Debug/Release. If we matched that, we wouldn't have a problem,
so this change fixes that and updates all of the callers of the
chromium ports' implementation to not pass configuration as part
of the path to look up; we still need to pass configuration in
some cases (to test if the build is out of date between debug
and release) so the implementation gets slightly more
complicated.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._static_build_path):
(ChromiumPort.default_results_directory):
(ChromiumPort._build_path):
(ChromiumPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort._build_path):
(ChromiumAndroidPort._path_to_driver):
(ChromiumAndroidPort._path_to_forwarder):
(ChromiumAndroidPort._push_executable):
(ChromiumAndroidPort._push_fonts):

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._modules_to_search_for_symbols):
(ChromiumLinuxPort._path_to_driver):

  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:

(ChromiumLinuxPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort._modules_to_search_for_symbols):
(ChromiumMacPort._path_to_driver):
(ChromiumMacPort._path_to_helper):

  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

(ChromiumMacPortTest.test_build_path):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort._path_to_driver):
(ChromiumWinPort._path_to_helper):
(ChromiumWinPort._path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_build_path):

12:26 Changeset [123359] by rniwa@webkit.org

REGRESSION(r123281): childNodes sometimes returns wrong nodes
https://bugs.webkit.org/show_bug.cgi?id=92014

Reviewed by Anders Carlsson.

Source/WebCore:

The bug was caused by a typo in itemBeforeOrAfter. Namely, it should have been calling firstNode as
firstNode(forward, rootNode(), shouldOnlyIncludeDirectChildren()),
NOT firstNode(forward, rootNode(), previous)
as evident from the argument list of the function.

Test: fast/dom/NodeList/childNodes-reverse-iteration.html

  • html/HTMLCollection.cpp:

(WebCore::DynamicNodeListCacheBase::itemBeforeOrAfter):

LayoutTests:

Added an integration regression test that caught this bug.

  • fast/dom/NodeList/childNodes-reverse-iteration-expected.txt: Added.
  • fast/dom/NodeList/childNodes-reverse-iteration.html: Added.
11:58 Changeset [123358] by commit-queue@webkit.org

[Qt] animations needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=91997

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-23
Reviewed by Noam Rosenthal.

Updating skipped tests inside animations directory.

  • platform/qt-5.0/Skipped:
  • platform/qt/animations/3d/change-transform-in-end-event-expected.txt: Added.
  • platform/qt/animations/3d/state-at-end-event-transform-expected.txt:
  • platform/qt/animations/additive-transform-animations-expected.txt:
  • platform/qt/animations/cross-fade-background-image-expected.txt:
  • platform/qt/animations/cross-fade-border-image-source-expected.txt:
  • platform/qt/animations/cross-fade-list-style-image-expected.txt:
  • platform/qt/animations/cross-fade-webkit-mask-box-image-expected.txt:
  • platform/qt/animations/cross-fade-webkit-mask-image-expected.txt:
  • platform/qt/animations/missing-values-first-keyframe-expected.txt:
  • platform/qt/animations/missing-values-last-keyframe-expected.txt:
  • platform/qt/animations/state-at-end-event-expected.txt:
11:54 Changeset [123357] by pfeldman@chromium.org

Merge 122979 - Web Inspector: [Regression] Save as file is missing in Network panel preview/response tabs.
https://bugs.webkit.org/show_bug.cgi?id=91625

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/HandlerRegistry.js:
  • inspector/front-end/NetworkPanel.js:

TBR=pfeldman@chromium.org
BUG=137863
Review URL: https://chromiumcodereview.appspot.com/10796093

11:48 Changeset [123356] by commit-queue@webkit.org

Chrome/Skia: PDF print output does not have clickable links.
https://bugs.webkit.org/show_bug.cgi?id=91171

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2012-07-23
Reviewed by Stephen White.

Connect GraphicsContext::setURLForRect to Skia's new API for annotations.

Printing is not generally testable.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setURLForRect):

11:45 Changeset [123355] by pierre.rossi@gmail.com

[Qt] Enable touch slider when touch events are enabled
https://bugs.webkit.org/show_bug.cgi?id=91013

Reviewed by Antonio Gomes.

Take advantage of the logic introduced in r122286.

  • Target.pri:
11:31 Changeset [123354] by pierre.rossi@gmail.com

Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client
https://bugs.webkit.org/show_bug.cgi?id=91006

Reviewed by Ryosuke Niwa.

Source/WebCore:

The rationale here is that the client doesn't need to know about the touch
event handler count. needTouchEvents was already used for that purpose.

Test: fast/events/touch/touch-handler-count.html

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didAddTouchEventHandler): Only notify the client if needed.
(WebCore::Document::didRemoveTouchEventHandler): Ditto. Also unset the TOUCH_LISTENER
flag for the document if we reach a count of zero. The rationale being that
hasListenerType() is relied upon in other places in combination with TOUCH_LISTENER for
the same purpose.

  • dom/Document.h:

(Document):
(WebCore::Document::touchEventHandlerCount):

  • loader/EmptyClients.h:
  • page/ChromeClient.h:

(ChromeClient):

  • page/Frame.cpp: Removed notifyChromeClientTouchEventHandlerCountChanged.

(WebCore::Frame::setDocument): call needsTouchEvents directly.

  • page/Frame.h: Ditto.

(Frame):

  • testing/Internals.cpp:

(WebCore::Internals::hasTouchEventListener): expose Document::hasListenerType indirectly
for additional testing.
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/blackberry:

Removed numTouchEventHandlersChanged stub.

  • WebCoreSupport/ChromeClientBlackBerry.h:

Source/WebKit/chromium:

Rename the functions to follow a more boolean logic.

  • public/WebViewClient.h:

(WebKit::WebViewClient::hasTouchEventHandlers):

  • src/ChromeClientImpl.cpp:

(WebKit):
(WebKit::ChromeClientImpl::needTouchEvents):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::hasTouchEventHandlers):

  • src/WebViewImpl.h:

(WebViewImpl):

Source/WebKit/efl:

Removed numTouchEventHandlersChanged stub.

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

Remove numTouchEventHandlersChanged stub.

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/mac:

Remove numTouchEventHandlersChanged stub.

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/qt:

Remove numTouchEventHandlersChanged stub.

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

Remove numTouchEventHandlersChanged stub.

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

Remove numTouchEventHandlersChanged stub.

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx:

Remove numTouchEventHandlersChanged stub.

  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2:

Remove numTouchEventHandlersChanged stub.

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

LayoutTests:

Extend the touch-handler-count test to also cover the hasListenerType logic.

  • fast/events/touch/touch-handler-count-expected.txt:
  • fast/events/touch/touch-handler-count.html:
11:23 Changeset [123353] by caio.oliveira@openbossa.org

[Qt] RenderThemeQtMobile highlight colors are not being used
https://bugs.webkit.org/show_bug.cgi?id=92004

Reviewed by Noam Rosenthal.

Source/WebCore:

The issue here is that setPaletteFromPageClientIfExists() is being used as a
virtual function, but it isn't, so when platformActiveSelectionBackgroundColor()
runs, it doesn't pick the right palette.

Besides fixing this virtual behavior, the patch changes the structure a bit,
because setPaletteFromPageClientIfExists() was being "overriden" in mobile theme
to set the palette, which isn't exactly what the function name says.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeQt::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeQt::platformFocusRingColor):
(WebCore::RenderThemeQt::systemColor):
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
Use the virtual colorPalette() to get the palette.

(WebCore::RenderThemeQt::colorPalette):
(WebCore): Removed the code for getting the page client from here since it is
used only by the QStyle variant.

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::colorPalette):
(WebCore):

  • platform/qt/RenderThemeQtMobile.h:

(RenderThemeQtMobile):

Source/WebKit/qt:

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists): Moved here since
it's used only by RenderThemeQStyle. Remove unnecessary check for m_page->chrome().
(WebCore):
(WebCore::RenderThemeQStyle::colorPalette):

  • WebCoreSupport/RenderThemeQStyle.h:

(RenderThemeQStyle):

11:17 Changeset [123352] by atwilson@chromium.org

Unreviewed chromium expectations change to mark fast/frames/frameset-frameborder-boolean-values.html as slow on snowleopard.
https://bugs.webkit.org/show_bug.cgi?id=24182

  • platform/chromium/TestExpectations:
11:06 Changeset [123351] by atwilson@chromium.org

Unreviewed chromium change to mark sandboxed-iframe-navigation-parent.html as slow on Windows.
https://bugs.webkit.org/show_bug.cgi?id=24182

  • platform/chromium/TestExpectations:
10:45 Changeset [123350] by simon.fraser@apple.com

Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

  • features.gypi:

Source/WebKit/mac: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2: Part 1 of: Implement sticky positioning
https://bugs.webkit.org/show_bug.cgi?id=90046

Reviewed by Ojan Vafai.

Add ENABLE_CSS_STICKY_POSITION, defaulting to off initially.

Sort the ENABLE_CSS lines in the file. Make sure all the flags
are in FEATURE_DEFINES.

  • Configurations/FeatureDefines.xcconfig:
10:44 Changeset [123349] by atwilson@chromium.org

Unreviewed chromium expectations change after r123302.
https://bugs.webkit.org/show_bug.cgi?id-91806

  • platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.png:
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
10:27 Changeset [123348] by atwilson@chromium.org

Unreviewed chromium expectations change to ignore failures for policy-ignore-crash.php.

  • platform/chromium/TestExpectations:
10:25 WebKit Team edited by leo.yang@torchmobile.com.cn
(diff)
09:25 Changeset [123347] by scheib@chromium.org

Skip http/tests/pointer-lock on ports that do not support pointer lock.

Unreviewed.

  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
09:25 Changeset [123346] by philn@webkit.org

Unreviewed, rolling out r123339.
http://trac.webkit.org/changeset/123339
https://bugs.webkit.org/show_bug.cgi?id=92006

massive media tests failure (Requested by philn on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-23

Source/WebCore:

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(setGstElementClassMetadata):

  • platform/graphics/gstreamer/GStreamerVersioning.h:

Tools:

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

  • gtk/jhbuild.modules:
09:15 Changeset [123345] by tommyw@google.com

[chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown
https://bugs.webkit.org/show_bug.cgi?id=91857

Reviewed by Adam Barth.

Source/Platform:

Made Platforms destructor virtual.

  • chromium/public/Platform.h:

(WebKit::Platform::~Platform):

Tools:

Made a few changes so that the destructor could be called at shutdown.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
(WebKitSupportTestEnvironment):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::create):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.h:

(MockWebKitPlatformSupport):
(MockWebKitPlatformSupport::~MockWebKitPlatformSupport):

08:59 Changeset [123344] by rwlbuis@webkit.org

[BlackBerry] Merge createThreadInternal implementations
https://bugs.webkit.org/show_bug.cgi?id=91899

Reviewed by Yong Li.

PR 111675

Remove our implementation since the default thread stack size on QNX is fine.

  • wtf/ThreadingPthreads.cpp:

(WTF::createThreadInternal):
(WTF::initializeCurrentThreadInternal): make sure we set the thread name.

08:50 Changeset [123343] by scheib@chromium.org

webkitFullscreenElement, webkitCurrentFullScreenElement, webkitPointerLockElement block cross origin access.
https://bugs.webkit.org/show_bug.cgi?id=91892

Reviewed by Adam Barth.

Source/WebCore:

PointerLockElement only returned when requested from the document that owns it.

Tests: http/tests/fullscreen/fullscreenelement-different-origin.html

http/tests/fullscreen/fullscreenelement-same-origin.html
http/tests/pointer-lock/pointerlockelement-different-origin.html
http/tests/pointer-lock/pointerlockelement-same-origin.html

  • dom/Document.cpp:

(WebCore::Document::webkitPointerLockElement):

LayoutTests:

Tests verifying the behavior of accessing
webkitFullscreenElement, webkitCurrentFullScreenElement, webkitPointerLockElement
from different origins.

  • http/tests/fullscreen/fullscreenelement-different-origin-expected.txt: Added.
  • http/tests/fullscreen/fullscreenelement-different-origin.html: Added.
  • http/tests/fullscreen/fullscreenelement-same-origin-expected.txt: Added.
  • http/tests/fullscreen/fullscreenelement-same-origin.html: Added.
  • http/tests/pointer-lock/pointerlockelement-different-origin-expected.txt: Added.
  • http/tests/pointer-lock/pointerlockelement-different-origin.html: Added.
  • http/tests/pointer-lock/pointerlockelement-same-origin-expected.txt: Added.
  • http/tests/pointer-lock/pointerlockelement-same-origin.html: Added.
  • http/tests/resources/pointer-lock/iframe-common.js: Added.

(thisFileName):
(window.onmessage):

  • http/tests/resources/pointer-lock/inner-iframe.html: Added.
  • http/tests/resources/pointer-lock/pointer-lock-test-harness.js:

(runOnKeyPress.keypressHandler):

  • pointer-lock/locked-element-iframe-removed-from-dom-expected.txt:
  • pointer-lock/locked-element-iframe-removed-from-dom.html:
  • pointer-lock/locked-element-removed-from-dom-expected.txt:
  • pointer-lock/locked-element-removed-from-dom.html:
08:49 Changeset [123342] by commit-queue@webkit.org

[BlackBerry] Implement GCActivityCallback with platform timer
https://bugs.webkit.org/show_bug.cgi?id=90175

Patch by Yong Li <yoli@rim.com> on 2012-07-23
Reviewed by Rob Buis.

Use JSLock when performing GC to avoid assertions.

  • runtime/GCActivityCallbackBlackBerry.cpp:

(JSC::DefaultGCActivityCallback::doWork):

08:49 Changeset [123341] by commit-queue@webkit.org

[EFL][WK2] Add request manager client
https://bugs.webkit.org/show_bug.cgi?id=91193

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Add a URL request manager client and attach it
to the Ewk_Context.

The client application can now register a URL scheme
via the Ewk_Context API and provide a callback handler
that will get called whenever a URL request with this
scheme is made.

A new Ewk_Url_Scheme_Request type is introduced to
provide information about the request to the client
and to allow the client to finish it by setting its
contents.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_context.cpp:

(_Ewk_Url_Scheme_Handler):
(_Ewk_Url_Scheme_Handler::_Ewk_Url_Scheme_Handler):
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(ewk_context_request_manager_get):
(ewk_context_url_scheme_request_received):
(createDefaultEwkContext):
(ewk_context_uri_scheme_register):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_private.h:
  • UIProcess/API/efl/ewk_context_request_manager_client.cpp: Added.

(toEwkContext):
(didReceiveURIRequest):
(ewk_context_request_manager_client_attach):

  • UIProcess/API/efl/ewk_context_request_manager_client_private.h: Added.
  • UIProcess/API/efl/ewk_url_scheme_request.cpp: Added.

(_Ewk_Url_Scheme_Request):
(_Ewk_Url_Scheme_Request::_Ewk_Url_Scheme_Request):
(_Ewk_Url_Scheme_Request::~_Ewk_Url_Scheme_Request):
(ewk_url_scheme_request_ref):
(ewk_url_scheme_request_unref):
(ewk_url_scheme_request_scheme_get):
(ewk_url_scheme_request_url_get):
(ewk_url_scheme_request_path_get):
(ewk_url_scheme_request_id_get):
(ewk_url_scheme_request_finish):
(ewk_url_scheme_request_new):

  • UIProcess/API/efl/ewk_url_scheme_request.h: Added.
  • UIProcess/API/efl/ewk_url_scheme_request_private.h: Added.
08:39 Changeset [123340] by zandobersek@gmail.com

Unreviewed GTK gardening, adding the WONTFIX modifier to a few more tests,
moving them to the top of the expected failures section.

  • platform/gtk/TestExpectations:
08:39 Changeset [123339] by philn@webkit.org

[GTK][jhbuild] Switch to GStreamer 0.11 build
https://bugs.webkit.org/show_bug.cgi?id=91727

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Add a new function to encapsulate the GStreamer API removal of
GST_OBJECT_IS_FLOATING in the upcoming 1.0 release. Use of this
macro can now be replaced by calling the g_object_is_floating
function.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(gstObjectIsFloating):

  • platform/graphics/gstreamer/GStreamerVersioning.h:

Tools:

Switch build-webkit --gtk to GStreamer 0.11 support and build the
necessary GStreamer git modules from JHBuild.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.

  • gtk/jhbuild.modules: GStreamer build support.
08:01 Changeset [123338] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening. Skip the failing tests.

  • platform/qt/Skipped:
07:17 Changeset [123337] by ossy@webkit.org

[Qt] DumpRenderTree does not use 'monospace' font when directed
https://bugs.webkit.org/show_bug.cgi?id=85203

Unreviewed gardening.

  • platform/qt-4.8/Skipped: Unskip now passing tests.
07:15 Changeset [123336] by caio.oliveira@openbossa.org

[Qt] editing/inserting/multiple-lines-selected.html fails
https://bugs.webkit.org/show_bug.cgi?id=91993

Reviewed by Simon Hausmann.

Removing wrong expected results, adding it to the skipped list.

  • platform/qt-5.0/Skipped:
  • platform/qt/editing/inserting/multiple-lines-selected-expected.png: Removed.
  • platform/qt/editing/inserting/multiple-lines-selected-expected.txt: Removed.
06:53 Changeset [123335] by caio.oliveira@openbossa.org

[Qt] editing/inserting rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=91985

Unreviewed.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.png: Removed.
  • platform/qt-5.0-wk1/editing/inserting/4960120-1-expected.txt: Removed.
  • platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.png: Removed.
  • platform/qt-5.0-wk1/editing/inserting/before-after-input-element-expected.txt: Removed.
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/editing/inserting/5549929-2-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/5549929-3-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-001-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-002-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-br-at-tabspan-003-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-tab-001-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-tab-002-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-tab-004-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-001-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-002-expected.txt: Removed.
  • platform/qt-5.0/editing/inserting/insert-text-at-tabspan-003-expected.txt: Removed.
  • platform/qt/editing/inserting/4960120-1-expected.png:
  • platform/qt/editing/inserting/before-after-input-element-expected.png:
  • platform/qt/editing/inserting/insert-3654864-fix-expected.txt:
  • platform/qt/editing/inserting/insert-3851164-fix-expected.txt:
  • platform/qt/editing/inserting/insert-div-009-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-009-expected.txt:
  • platform/qt/editing/inserting/insert-div-010-expected.png: Added.
  • platform/qt/editing/inserting/insert-div-010-expected.txt:
06:30 Changeset [123334] by commit-queue@webkit.org

[EFL] media/controls-styling.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91984

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Eric Carlson.

Source/WebCore:

Make sure that the CSS properties letter-spacing, word-spacing,
line-height, text-transform, text-indent, text-shadow,
text-decoration and color do not affect the media element controls,
that display text.

No new tests. Already tested by media/controls-styling.html and
media/controls-styling-strict.html

  • css/mediaControlsEfl.css:

(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):

LayoutTests:

Rebaseline media controls styling tests now that the
EFL port properly ensures that overriding CSS
properties won't affect the media controls.

  • platform/efl/media/controls-styling-expected.png:
  • platform/efl/media/controls-styling-expected.txt:
  • platform/efl/media/controls-styling-strict-expected.png:
  • platform/efl/media/controls-styling-strict-expected.txt:
05:15 Changeset [123333] by commit-queue@webkit.org

[EFL] fast/layers/video-layer.html needs rebasing after r123320
https://bugs.webkit.org/show_bug.cgi?id=91978

Unreviewed EFL gardening, regenerate baseline for
fast/layers/video-layer.html after r123320.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23

  • platform/efl/fast/layers/video-layer-expected.txt:
04:44 Changeset [123332] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening.

  • platform/qt/Skipped:
04:37 Changeset [123331] by commit-queue@webkit.org

[EFL][WK2] ProcessExecutablePath is required
https://bugs.webkit.org/show_bug.cgi?id=89719

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Added executablePathOfWebProcess and executablePathOfPluginProcess.
It's used for getting the location of WebProcess and PluginProcess.

  • PlatformEfl.cmake: Added LIBEXECDIR definition
  • Shared/efl/ProcessExecutablePathEfl.cpp: Added.

(WebKit):
(WebKit::findWebKitProcess):
(WebKit::executablePathOfWebProcess): Get the absolute path of WebProcess
(WebKit::executablePathOfPluginProcess): Get the absolute path of PluginProcess

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess): Modified to use above routines

04:27 Changeset [123330] by carlosgc@webkit.org

Unreviewed. Fix make distcheck.

  • GNUmakefile.list.am: Add missing header files.
04:19 Changeset [123329] by tkent@chromium.org

Replace some instances of shadowAncestorNode() with shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=91966

Reviewed by Hajime Morita.

shadowAncestorNode() is deprecated. We should use shadowHost().
No new tests. This doesn't change any behavior.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

  • dom/TreeScope.cpp:

(WebCore::listTreeScopes):

  • html/HTMLSummaryElement.cpp:

(WebCore::isClickableControl):

  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::summaryElement):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::meterElement):

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressShadowElement::progressElement):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderThumb::layout):
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::hostInput):
(WebCore::TrackLimiterElement::shadowPseudoId):
(WebCore::SliderContainerElement::shadowPseudoId):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::customStyleForRenderer):
(WebCore::TextControlInnerTextElement::defaultEventHandler):
(WebCore::TextControlInnerTextElement::createRenderer):
(WebCore::TextControlInnerTextElement::customStyleForRenderer):
(WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::step):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setState):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlInnerBlock::positionForPoint):

04:18 Changeset [123328] by pfeldman@chromium.org

[WK2] REGRESSION r122966: Crash when closing tab with Web Inspector open in WebKit::PageOverlay
https://bugs.webkit.org/show_bug.cgi?id=91782

Reviewed by Yury Semikhatsky.

hideHighlight was never called once user hovered over a node.

  • inspector/DOMNodeHighlighter.cpp:

(WebCore::InspectorOverlay::update):

04:07 Changeset [123327] by commit-queue@webkit.org

[Qt] new test introduced in r123205 fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=91967

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Skipped WebInspector test that needs CSS Regions enabled.

  • platform/qt/Skipped:
03:54 Changeset [123326] by peter@chromium.org

[Chromium] Build fix for the Windows builder following r123311
https://bugs.webkit.org/show_bug.cgi?id=91979

Unreviewed build fix.

Changeset r123311 moved the TextCodecWinCE.{cpp,h} files to the Windows
directory. Update Chromium's references to these files to fix the build.

  • WebCore.gypi:
03:36 Changeset [123325] by peter@chromium.org

[Chromium] Buildfix for fixing gclient on the Chromium Windows bot
https://bugs.webkit.org/show_bug.cgi?id=91977

Unreviewed build fix.

Add the tools/isolate directory to the Windows checkout as these files
currently are missing during gyp generation. maruel introduced the need
for these in this isolate refactoring, specifically this Chromium CL:
http://src.chromium.org/viewvc/chrome?view=rev&revision=147689

  • DEPS:
03:05 Changeset [123324] by paroga@webkit.org

[WINCE] Define NOMINMAX in the build system instead of Platform.h
https://bugs.webkit.org/show_bug.cgi?id=91938

Reviewed by Ryosuke Niwa.

.:

Define it in OptionsWindows.cmake, since NOMINMAX
should to be defined for all windows ports.

  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmake/OptionsWindows.cmake:

Source/WTF:

  • wtf/Platform.h:
02:58 Changeset [123323] by paroga@webkit.org

[WIN] Remove ICU dependencies from UniscribeController
https://bugs.webkit.org/show_bug.cgi?id=91921

Reviewed by Ryosuke Niwa.

Replace ICU specific functions and macros with the corresponding code from WTF::Unicode.
This allows us to use UniscribeController with an other Unicode implementation too.

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::advance):

02:47 Changeset [123322] by paroga@webkit.org

Build fix for Windows after r123317.

  • wtf/DateMath.cpp: Added missing header include.
02:47 Changeset [123321] by zandobersek@gmail.com

Unreviewed GTK gardening.

Marking more svg/W3C-SVG-1.1/animate-elem-* tests as flaky.

  • platform/gtk/TestExpectations:
02:23 Changeset [123320] by commit-queue@webkit.org

[EFL] media/controls-styling-strict.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91960

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Use "display: -webkit-box;" instead of inline-block
for current-time control. This is needed because
inline-block behaves differently in strict mode.

No new test, already tested by media/controls-styling-strict.html

  • css/mediaControlsEfl.css:

(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):

LayoutTests:

Update test expectations for media tests now that
we use "display: -webkit-box;" for the current-time
control.

  • platform/efl/media/audio-controls-rendering-expected.txt:
  • platform/efl/media/audio-repaint-expected.png:
  • platform/efl/media/audio-repaint-expected.txt:
  • platform/efl/media/controls-layout-direction-expected.png:
  • platform/efl/media/controls-strict-expected.png:
  • platform/efl/media/controls-strict-expected.txt:
  • platform/efl/media/controls-styling-expected.txt:
  • platform/efl/media/controls-styling-strict-expected.png: Added.
  • platform/efl/media/controls-styling-strict-expected.txt: Added.
  • platform/efl/media/media-controls-clone-expected.png:
  • platform/efl/media/media-controls-clone-expected.txt:
  • platform/efl/media/video-aspect-ratio-expected.png:
  • platform/efl/media/video-layer-crash-expected.png:
  • platform/efl/media/video-transformed-expected.png:
  • platform/efl/media/video-zoom-controls-expected.png:
  • platform/efl/media/video-zoom-controls-expected.txt:
  • platform/efl/media/video-zoom-expected.png:
01:43 Changeset [123319] by carlosgc@webkit.org

Unreviewed. Fix GTK+ build with ENABLE_DATALIST_ELEMENT.

Add an implementation for virtual pure methods sliderTickSize()
and sliderTickOffsetFromTrackCenter() when HTML5 datalist element
is enabled.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore):
(WebCore::RenderThemeGtk::sliderTickSize):
(WebCore::RenderThemeGtk::sliderTickOffsetFromTrackCenter):

  • platform/gtk/RenderThemeGtk.h:
01:36 Changeset [123318] by commit-queue@webkit.org

[EFL] Skip http/tests/inspector-enabled/injected-script-discard.html
https://bugs.webkit.org/show_bug.cgi?id=91959

Unreviewed EFL gardening. Skip flaky Web Inspector test case.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23

  • platform/efl/TestExpectations:
01:34 Changeset [123317] by paroga@webkit.org

[WIN] Use GetTimeZoneInformation() for calculateUTCOffset()
https://bugs.webkit.org/show_bug.cgi?id=91935

Reviewed by Ryosuke Niwa.

GetTimeZoneInformation() returns the offset directly. Using it
avoids unnecessary calculations and remove dependencies on
other time related function, which do not exist on WinCE.

  • wtf/DateMath.cpp:

(WTF::calculateUTCOffset):

01:33 Changeset [123316] by commit-queue@webkit.org

WebKit2 needs layoutTestController.setAlwaysAcceptCookies
https://bugs.webkit.org/show_bug.cgi?id=42778

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add setAlwaysAcceptCookies() method to InjectedBundle
so that we can use it in LayoutTestController.
The method uses WebCookieManager::setHTTPCookieAcceptPolicy()
internally.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetAlwaysAcceptCookies):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setAlwaysAcceptCookies):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Add support for layoutTestController.setAlwaysAcceptCookies()
since it is required by some tests.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setAlwaysAcceptCookies):
(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

01:30 Changeset [123315] by commit-queue@webkit.org

[WK2] SQL Database cannot be disabled at build time
https://bugs.webkit.org/show_bug.cgi?id=91837

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-23
Reviewed by Kenneth Rohde Christiansen.

WebKit2 had no #ifdefs for SQL Database. This patch adds these
statments and it can now be disabled at build time.

  • Shared/OriginAndDatabases.cpp:
  • Shared/OriginAndDatabases.h:
  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC):

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetDatabaseManager):

  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerGetTypeID):
(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):
(WKDatabaseManagerSetClient):
(WKDatabaseManagerGetDatabasesByOrigin):
(callGetDatabasesByOriginBlockAndDispose):
(WKDatabaseManagerGetDatabasesByOrigin_b):
(WKDatabaseManagerGetDatabaseOrigins):
(callGetDatabaseOriginsBlockBlockAndDispose):
(WKDatabaseManagerGetDatabaseOrigins_b):
(WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
(WKDatabaseManagerDeleteDatabasesForOrigin):
(WKDatabaseManagerDeleteAllDatabases):
(WKDatabaseManagerSetQuotaForOrigin):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebDatabaseManagerProxy.cpp:
  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.messages.in:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::clearAllDatabases):
(WebKit::InjectedBundle::setDatabaseQuota):

  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage):

01:24 Changeset [123314] by paroga@webkit.org

Replace getCurrentLocalTime() with GetLocalTime() in LocaleWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=91937

Reviewed by Ryosuke Niwa.

The windows function returns the required year directly and
removes one additonal dependecy on getCurrentLocalTime().

  • platform/text/LocaleWin.cpp:

(WebCore::LocaleWin::LocaleWin):

01:18 Changeset [123313] by vsevik@chromium.org

Web Inspector: Drag and drop should not be started on right mouse click.
https://bugs.webkit.org/show_bug.cgi?id=91728

Reviewed by Pavel Feldman.

Introduced WebInspector.installDragHandle method to control drag and drop support, checking whichg mouse button is pressed.
Simplified WebInspector._elementDragStart, removed "element" parameter.
Simplified tab moving support in TabbedPane, removed "mousemove" handler.
Removed while loop determining which element was dragged in TimelineOverviewPane, each drag support is now installed independently.
Drive-by: fixed TimelineOverviewPane window moving on resources-dividers-label-bar drang-and-drop.
Drive-by: fixed CSSStyleModel compilation.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._positionResizers):
(WebInspector.DataGrid.prototype._startResizerDragging):
(WebInspector.DataGrid.prototype._endResizerDragging):

  • inspector/front-end/Drawer.js:

(WebInspector.Drawer):
(WebInspector.Drawer.prototype._animationDuration):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._endStatusBarDragging):

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._startRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._endRetainersHeaderDragging):

  • inspector/front-end/SidebarOverlay.js:

(WebInspector.SidebarOverlay.prototype.set _startResizerDragging):
(WebInspector.SidebarOverlay.prototype._endResizerDragging):
(WebInspector.SidebarOverlay.prototype._installResizer):

  • inspector/front-end/Spectrum.js:
  • inspector/front-end/SplitView.js:

(WebInspector.SplitView.prototype._startResizerDragging):
(WebInspector.SplitView.prototype._endResizerDragging):
(WebInspector.SplitView.prototype.installResizer):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPaneTab.prototype._createTabElement):
(WebInspector.TabbedPaneTab.prototype._tabMouseDown):
(WebInspector.TabbedPaneTab.prototype._startTabDragging):
(WebInspector.TabbedPaneTab.prototype._endTabDragging):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype._leftResizeElementDragging):
(WebInspector.TimelineOverviewWindow.prototype._rightResizeElementDragging):
(WebInspector.TimelineOverviewWindow.prototype._startWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._startWindowDragging):
(WebInspector.TimelineOverviewWindow.prototype._windowDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowDragging):
(WebInspector.TimelineOverviewWindow.prototype._moveWindow):
(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._startSplitterDragging):
(WebInspector.TimelinePanel.prototype._endSplitterDragging):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDragEnd):

  • inspector/front-end/UIUtils.js:

(WebInspector.installDragHandle):
(WebInspector._elementDragStart):
(WebInspector._elementDragEnd):

  • inspector/front-end/timelinePanel.css:

(#timeline-overview-grid .resources-dividers-label-bar):

01:08 Changeset [123312] by hayato@chromium.org

ComposedShadowTreeWalker should skip an empty insertion points.
https://bugs.webkit.org/show_bug.cgi?id=91826

Reviewed by Hajime Morita.

Source/WebCore:

ComposedShadowTreeWalker wrongly returns 'null' if it encounters
an insertion point into where no nodes are distributed. We should
skip such an insertion point and continue walking using the next
possible node, which might be a next sibling or a next distributed
node, and resolve the next node recursively.

Test: fast/dom/shadow/composed-shadow-tree-walker.html

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseLightChildren):
(WebCore):
(WebCore::ComposedShadowTreeWalker::traverseSiblings):
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseDistributedeNodes):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseSiblingInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseBackToYoungerShadowRoot):

  • dom/ComposedShadowTreeWalker.h:

(ComposedShadowTreeWalker):

LayoutTests:

  • fast/dom/shadow/composed-shadow-tree-walker-expected.txt:
  • fast/dom/shadow/composed-shadow-tree-walker.html:
01:06 Changeset [123311] by paroga@webkit.org

Rename TextCodecWinCE to TextCodecWin
https://bugs.webkit.org/show_bug.cgi?id=91947

Reviewed by Ryosuke Niwa.

Since TextCodecWinCE is used by other (non-upstreamed) windows ports too,
TextCodecWin is a better name for the implementation.
Also remove the dependency on WinCE FontCache to make it more usable.

  • PlatformWinCE.cmake:
  • platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps):

  • platform/text/win/TextCodecWin.cpp: Renamed from Source/WebCore/platform/text/wince/TextCodecWinCE.cpp.
  • platform/text/win/TextCodecWin.h: Renamed from Source/WebCore/platform/text/wince/TextCodecWinCE.h.
01:00 Changeset [123310] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening. Skip the new failing tests.

  • platform/qt/Skipped:
00:53 Changeset [123309] by commit-queue@webkit.org

Improve AudioChannelSplitter test
https://bugs.webkit.org/show_bug.cgi?id=91962

Patch by Li Yin <li.yin@intel.com> on 2012-07-23
Reviewed by Kentaro Hara.

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioChannelSplitter-section
The numberOfOutputs parameter determines the number of outputs.
Values of up to 32 must be supported. If not specified, then 6 will be used.

  • webaudio/audiochannelsplitter-expected.txt:
  • webaudio/audiochannelsplitter.html:

07/22/12:

21:55 Changeset [123308] by haraken@chromium.org

[V8] CodeGeneratorV8.pm should support static attributes
https://bugs.webkit.org/show_bug.cgi?id=91764

Reviewed by Adam Barth.

CodeGeneratorJS.pm already supports static attributes.
CodeGeneratorV8.pm should also support them.

Tests: bindings/scripts/test/TestObj.idl

bindings/scripts/test/TestSupplemental.idl

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):

  • bindings/scripts/test/TestObj.idl: Added defined(TESTING_V8).
  • bindings/scripts/test/TestSupplemental.idl: Added test cases for static attributes in supplemental IDL files.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated run-bindings-tests results.

(WebCore):
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
The generated code is wrong since CodeGeneratorJS.pm does not support static attributes for
supplemental IDL files. I will fix it in a follow-up patch.
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp: Updated run-bindings-tests results.

(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetter):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::staticReadOnlyIntAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetter):
(WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
(WebCore):

20:55 Changeset [123307] by tkent@chromium.org

[Chromium-Mac] Fix a build error.

  • DEPS: Add third_party/GTM.
20:33 FeatureFlags edited by tkent@chromium.org
Rename some flags to _ELEMENT (diff)
19:11 Changeset [123306] by commit-queue@webkit.org

Improve BiquadFilterNode test case
https://bugs.webkit.org/show_bug.cgi?id=90937

Patch by Li Yin <li.yin@intel.com> on 2012-07-22
Reviewed by Kentaro Hara.

Spec: http://www.w3.org/TR/webaudio/#BiquadFilterNode
Improve BiquadFilterNode test to cover constant value and number of inputs and outputs.

  • webaudio/biquadfilternode-basic-expected.txt:
  • webaudio/biquadfilternode-basic.html:
18:27 Changeset [123305] by gyuyoung.kim@samsung.com

Missing *explicit* keyword in storage and workers.
https://bugs.webkit.org/show_bug.cgi?id=91934

Reviewed by Kentaro Hara.

Some constructors missed to use *explicit* keyword. They need to be added
*explicit* keyword to contructor which has a parameter in order to avoid
implicit type conversion.

No new tests. Convered by existing tests.

  • storage/StorageAreaImpl.h:

(StorageAreaImpl):

  • storage/StorageMap.h:

(StorageMap):

  • storage/StorageSyncManager.h:

(StorageSyncManager):

  • storage/StorageTask.h:

(StorageTask):

  • storage/StorageTracker.h:

(StorageTracker):

  • workers/SharedWorker.h:

(SharedWorker):

  • workers/Worker.h:

(Worker):

  • workers/WorkerLocation.h:

(WebCore::WorkerLocation::WorkerLocation):

  • workers/WorkerMessagingProxy.h:

(WorkerMessagingProxy):

18:17 Changeset [123304] by yosin@chromium.org

Unreviewed. Set missing SVN property svn:mime-type=image/png to PNG files in
/LayoutTests/fast/forms/ and LayoutTests/platfrom/*fast/forms

18:08 Changeset [123303] by commit-queue@webkit.org

Unreviewed, rolling out r123298 and r123301.
http://trac.webkit.org/changeset/123298
http://trac.webkit.org/changeset/123301
https://bugs.webkit.org/show_bug.cgi?id=91953

We need to think some more about the intricacies of exposing a
CMake option for ENABLE_DFG_JIT as this option is specific to
the port and architecture. (Requested by dydx on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-22

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
18:00 Changeset [123302] by yosin@chromium.org

[Tests] Rename fast/forms/number/*.html to number-*.html
https://bugs.webkit.org/show_bug.cgi?id=91806

Reviewed by Kent Tamura.

This patch renames test scripts and expected text/images to same
naming scheme(name starts with "number-"), for fast/forms/number.

This patch also updates TestExpectations and Skipped files in platform
directory for test name change.

This patch is a part of forms input type test arrangement.
https://bugs.webkit.org/show_bug.cgi?id=91805

  • fast/forms/number/ValidityState-rangeOverflow-number-expected.txt: Removed.
  • fast/forms/number/ValidityState-rangeOverflow-number.html: Removed.
  • fast/forms/number/ValidityState-rangeUnderflow-number-expected.txt: Removed.
  • fast/forms/number/ValidityState-rangeUnderflow-number.html: Removed.
  • fast/forms/number/ValidityState-stepMismatch-number-expected.txt: Removed.
  • fast/forms/number/ValidityState-stepMismatch-number.html: Removed.
  • fast/forms/number/ValidityState-typeMismatch-number-expected.txt: Removed.
  • fast/forms/number/ValidityState-typeMismatch-number.html: Removed.
  • fast/forms/number/input-appearance-number-rtl.html: Removed.
  • fast/forms/number/input-appearance-spinbutton-disabled-readonly.html: Removed.
  • fast/forms/number/input-appearance-spinbutton-layer.html: Removed.
  • fast/forms/number/input-appearance-spinbutton-visibility-expected.html: Removed.
  • fast/forms/number/input-appearance-spinbutton-visibility.html: Removed.
  • fast/forms/number/input-number-blur-twice-expected.txt: Removed.
  • fast/forms/number/input-number-blur-twice.html: Removed.
  • fast/forms/number/input-number-change-type-on-focus-expected.txt: Removed.
  • fast/forms/number/input-number-change-type-on-focus.html: Removed.
  • fast/forms/number/input-number-commit-valid-only-expected.txt: Removed.
  • fast/forms/number/input-number-commit-valid-only.html: Removed.
  • fast/forms/number/input-number-crash-expected.txt: Removed.
  • fast/forms/number/input-number-crash.html: Removed.
  • fast/forms/number/input-number-events-expected.txt: Removed.
  • fast/forms/number/input-number-events.html: Removed.
  • fast/forms/number/input-number-keyoperation-expected.txt: Removed.
  • fast/forms/number/input-number-keyoperation.html: Removed.
  • fast/forms/number/input-number-large-padding-expected.txt: Removed.
  • fast/forms/number/input-number-large-padding.html: Removed.
  • fast/forms/number/input-number-outofrange-expected.txt: Removed.
  • fast/forms/number/input-number-outofrange.html: Removed.
  • fast/forms/number/input-number-size-expected.txt: Removed.
  • fast/forms/number/input-number-size.html: Removed.
  • fast/forms/number/input-number-spinbutton-crash-expected.txt: Removed.
  • fast/forms/number/input-number-spinbutton-crash.html: Removed.
  • fast/forms/number/input-number-unacceptable-style-expected.txt: Removed.
  • fast/forms/number/input-number-unacceptable-style.html: Removed.
  • fast/forms/number/input-number-validation-message-expected.txt: Removed.
  • fast/forms/number/input-number-validation-message.html: Removed.
  • fast/forms/number/input-number-wheel-expected.txt: Removed.
  • fast/forms/number/input-number-wheel.html: Removed.
  • fast/forms/number/input-spinbutton-capturing-expected.txt: Removed.
  • fast/forms/number/input-spinbutton-capturing.html: Removed.
  • fast/forms/number/input-valueasnumber-number-expected.txt: Removed.
  • fast/forms/number/input-valueasnumber-number.html: Removed.
  • fast/forms/number/number-appearance-rtl.html: Copied from LayoutTests/fast/forms/number/input-appearance-number-rtl.html.
  • fast/forms/number/number-appearance-spinbutton-disabled-readonly.html: Copied from LayoutTests/fast/forms/number/input-appearance-spinbutton-disabled-readonly.html.
  • fast/forms/number/number-appearance-spinbutton-layer.html: Copied from LayoutTests/fast/forms/number/input-appearance-spinbutton-layer.html.
  • fast/forms/number/number-appearance-spinbutton-visibility-expected.html: Copied from LayoutTests/fast/forms/number/input-appearance-spinbutton-visibility-expected.html.
  • fast/forms/number/number-appearance-spinbutton-visibility.html: Copied from LayoutTests/fast/forms/number/input-appearance-spinbutton-visibility.html.
  • fast/forms/number/number-blur-twice-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-blur-twice-expected.txt.
  • fast/forms/number/number-blur-twice.html: Copied from LayoutTests/fast/forms/number/input-number-blur-twice.html.
  • fast/forms/number/number-change-type-on-focus-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-change-type-on-focus-expected.txt.
  • fast/forms/number/number-change-type-on-focus.html: Copied from LayoutTests/fast/forms/number/input-number-change-type-on-focus.html.
  • fast/forms/number/number-commit-valid-only-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-commit-valid-only-expected.txt.
  • fast/forms/number/number-commit-valid-only.html: Copied from LayoutTests/fast/forms/number/input-number-commit-valid-only.html.
  • fast/forms/number/number-crash-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-crash-expected.txt.
  • fast/forms/number/number-crash.html: Copied from LayoutTests/fast/forms/number/input-number-crash.html.
  • fast/forms/number/number-events-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-events-expected.txt.
  • fast/forms/number/number-events.html: Copied from LayoutTests/fast/forms/number/input-number-events.html.
  • fast/forms/number/number-keyoperation-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-keyoperation-expected.txt.
  • fast/forms/number/number-keyoperation.html: Copied from LayoutTests/fast/forms/number/input-number-keyoperation.html.
  • fast/forms/number/number-large-padding-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-large-padding-expected.txt.
  • fast/forms/number/number-large-padding.html: Copied from LayoutTests/fast/forms/number/input-number-large-padding.html.
  • fast/forms/number/number-outofrange-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-outofrange-expected.txt.
  • fast/forms/number/number-outofrange.html: Copied from LayoutTests/fast/forms/number/input-number-outofrange.html.
  • fast/forms/number/number-size-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-size-expected.txt.
  • fast/forms/number/number-size.html: Copied from LayoutTests/fast/forms/number/input-number-size.html.
  • fast/forms/number/number-spinbutton-capturing-expected.txt: Copied from LayoutTests/fast/forms/number/input-spinbutton-capturing-expected.txt.
  • fast/forms/number/number-spinbutton-capturing.html: Copied from LayoutTests/fast/forms/number/input-spinbutton-capturing.html.
  • fast/forms/number/number-spinbutton-crash-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-spinbutton-crash-expected.txt.
  • fast/forms/number/number-spinbutton-crash.html: Copied from LayoutTests/fast/forms/number/input-number-spinbutton-crash.html.
  • fast/forms/number/number-spinbutton-events-expected.txt: Copied from LayoutTests/fast/forms/number/spin-button-events-expected.txt.
  • fast/forms/number/number-spinbutton-events.html: Copied from LayoutTests/fast/forms/number/spin-button-events.html.
  • fast/forms/number/number-spinbutton-gets-disabled-or-readonly-expected.txt: Copied from LayoutTests/fast/forms/number/spin-button-gets-disabled-or-readonly-expected.txt.
  • fast/forms/number/number-spinbutton-gets-disabled-or-readonly.html: Copied from LayoutTests/fast/forms/number/spin-button-gets-disabled-or-readonly.html.
  • fast/forms/number/number-spinbutton-in-multi-column-expected.txt: Copied from LayoutTests/fast/forms/number/spin-in-multi-column-expected.txt.
  • fast/forms/number/number-spinbutton-in-multi-column.html: Copied from LayoutTests/fast/forms/number/spin-in-multi-column.html.
  • fast/forms/number/number-spinbutton-state-expected.txt: Copied from LayoutTests/fast/forms/number/spin-button-state-expected.txt.
  • fast/forms/number/number-spinbutton-state.html: Copied from LayoutTests/fast/forms/number/spin-button-state.html.
  • fast/forms/number/number-unacceptable-style-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-unacceptable-style-expected.txt.
  • fast/forms/number/number-unacceptable-style.html: Copied from LayoutTests/fast/forms/number/input-number-unacceptable-style.html.
  • fast/forms/number/number-validation-message-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-validation-message-expected.txt.
  • fast/forms/number/number-validation-message.html: Copied from LayoutTests/fast/forms/number/input-number-validation-message.html.
  • fast/forms/number/number-validity-state-range-underflow-expected.txt: Copied from LayoutTests/fast/forms/number/ValidityState-rangeUnderflow-number-expected.txt.
  • fast/forms/number/number-validity-state-range-underflow.html: Copied from LayoutTests/fast/forms/number/ValidityState-rangeUnderflow-number.html.
  • fast/forms/number/number-validity-state-step-mismatch-expected.txt: Copied from LayoutTests/fast/forms/number/ValidityState-stepMismatch-number-expected.txt.
  • fast/forms/number/number-validity-state-step-mismatch.html: Copied from LayoutTests/fast/forms/number/ValidityState-stepMismatch-number.html.
  • fast/forms/number/number-validity-state-type-mismatch-expected.txt: Copied from LayoutTests/fast/forms/number/ValidityState-typeMismatch-number-expected.txt.
  • fast/forms/number/number-validity-state-type-mismatch.html: Copied from LayoutTests/fast/forms/number/ValidityState-typeMismatch-number.html.
  • fast/forms/number/number-validitystate-range-overflow-expected.txt: Copied from LayoutTests/fast/forms/number/ValidityState-rangeOverflow-number-expected.txt.
  • fast/forms/number/number-validitystate-range-overflow.html: Copied from LayoutTests/fast/forms/number/ValidityState-rangeOverflow-number.html.
  • fast/forms/number/number-valueasnumber-expected.txt: Copied from LayoutTests/fast/forms/number/input-valueasnumber-number-expected.txt.
  • fast/forms/number/number-valueasnumber.html: Copied from LayoutTests/fast/forms/number/input-valueasnumber-number.html.
  • fast/forms/number/number-wheel-expected.txt: Copied from LayoutTests/fast/forms/number/input-number-wheel-expected.txt.
  • fast/forms/number/number-wheel.html: Copied from LayoutTests/fast/forms/number/input-number-wheel.html.
  • fast/forms/number/spin-button-events-expected.txt: Removed.
  • fast/forms/number/spin-button-events.html: Removed.
  • fast/forms/number/spin-button-gets-disabled-or-readonly-expected.txt: Removed.
  • fast/forms/number/spin-button-gets-disabled-or-readonly.html: Removed.
  • fast/forms/number/spin-button-state-expected.txt: Removed.
  • fast/forms/number/spin-button-state.html: Removed.
  • fast/forms/number/spin-in-multi-column-expected.txt: Removed.
  • fast/forms/number/spin-in-multi-column.html: Removed.
  • platform/chromium-linux/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-linux/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-mac-snowleopard/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-mac/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-number-rtl-expected.txt.
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/efl/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/efl/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-number-rtl-expected.txt.
  • platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/efl/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
  • platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/gtk/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt.
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/mac/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/mac/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt.
  • platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
  • platform/qt-4.8/Skipped:
  • platform/qt-5.0-wk2/Skipped:
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.txt.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/qt-5.0-wk2/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
  • platform/qt-arm/TestExpectations:
  • platform/qt-mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png: Removed.
  • platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt: Removed.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Removed.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Removed.
  • platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt: Removed.
  • platform/qt/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-number-rtl-expected.png.
  • platform/qt/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-number-rtl-expected.txt.
  • platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.png: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.png.
  • platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/qt/fast/forms/number/input-appearance-spinbutton-layer-expected.txt.
  • platform/win-wk2/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
17:00 Changeset [123301] by dbates@webkit.org

Fix the Windows CE build after <http://trac.webkit.org/changeset/123298>
(https://bugs.webkit.org/show_bug.cgi?id=91939)

Disable the DFG JIT across all CMake ports (by default) (*). Enabling DFG JIT
breaks the Windows CE build as the Windows CE port builds with the JIT disabled
(ENABLE_JIT := 0) and hence ENABLE_ASSEMBLER := 0.

(*) We should look to further discuss with CMake port maintainers about enabling
the DFG JIT by default.

  • Source/cmake/WebKitFeatures.cmake:
16:23 Changeset [123300] by tkent@chromium.org

Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
https://bugs.webkit.org/show_bug.cgi?id=91941

Reviewed by Kentaro Hara.

A flag name for an elmement should be ENABLE_*_ELEMENT.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • accessibility/AXObjectCache.cpp:

(WebCore::createFromRenderer):

  • accessibility/AccessibilityProgressIndicator.cpp:
  • accessibility/AccessibilityProgressIndicator.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/html.css:
  • html/HTMLMeterElement.cpp:
  • html/HTMLMeterElement.h:
  • html/HTMLMeterElement.idl:
  • html/HTMLProgressElement.cpp:
  • html/HTMLProgressElement.h:
  • html/HTMLProgressElement.idl:
  • html/HTMLTagNames.in:
  • html/shadow/MeterShadowElement.cpp:
  • html/shadow/MeterShadowElement.h: Wrap with #if ENABLE(METER_ELEMENT).
  • html/shadow/ProgressShadowElement.cpp:
  • html/shadow/ProgressShadowElement.h: Wrap with #if ENABLE(PROGRESS_ELEMENT).
  • page/DOMWindow.idl:
  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::edjeGroupFromFormType):
(WebCore):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore):

  • platform/gtk/RenderThemeGtk.h:

(RenderThemeGtk):

  • platform/gtk/RenderThemeGtk2.cpp:

(WebCore):

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore):

  • platform/qt/RenderThemeQt.cpp:

(WebCore):

  • platform/qt/RenderThemeQt.h:

(WebCore):
(RenderThemeQt):

  • platform/qt/RenderThemeQtMobile.cpp:

(WebCore):

  • platform/qt/RenderThemeQtMobile.h:

(RenderThemeQtMobile):

  • rendering/RenderMeter.cpp:
  • rendering/RenderMeter.h:
  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderProgress.cpp:
  • rendering/RenderProgress.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore):

  • rendering/RenderTheme.h:

(WebCore):
(RenderTheme):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore):

  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore):

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):

  • rendering/RenderThemeChromiumWin.h:

(RenderThemeChromiumWin):

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore):

Source/WebKit:

  • PlatformEfl.cmake:

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/efl:

  • DefaultTheme/default.edc:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/qt:

  • WebCoreSupport/RenderThemeQStyle.cpp:

(WebCore):

  • WebCoreSupport/RenderThemeQStyle.h:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

  • fast/dom/wrapper-classes.html:
11:06 Changeset [123299] by senorblanco@chromium.org

[chromium] Unreviewed gardening.

Shamed into removing some BUGSENORBLANCOs from previous gardening
stints.

  • platform/chromium/TestExpectations:
09:36 Changeset [123298] by paroga@webkit.org

[CMake] Add option for ENABLE_DFG_JIT
https://bugs.webkit.org/show_bug.cgi?id=91939

Reviewed by Daniel Bates.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
09:24 Changeset [123297] by senorblanco@chromium.org

[chromium] Test result gardening; unreviewed.

  • platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
  • platform/chromium/TestExpectations:
03:59 Changeset [123296] by tkent@chromium.org

Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT
https://bugs.webkit.org/show_bug.cgi?id=91928

Reviewed by Kentaro Hara.

A flag name for an elmement should be ENABLE_*_ELEMENT.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • html/HTMLDetailsElement.cpp:
  • html/HTMLDetailsElement.idl:
  • html/HTMLSummaryElement.cpp:
  • html/HTMLTagNames.in:
  • html/shadow/DetailsMarkerControl.cpp:
  • rendering/RenderDetailsMarker.cpp:
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
01:04 Changeset [123295] by zandobersek@gmail.com

Unreviewed GTK gardening, adding baselines for the media/controls-styling-strict.html
test and skip a subpixel layout test that's crashing on debug builds (the
feature is disabled at the moment so the failure is somewhat acceptable).

  • platform/gtk/TestExpectations:
  • platform/gtk/media/controls-styling-strict-expected.png: Added.
  • platform/gtk/media/controls-styling-strict-expected.txt: Added.

07/21/12:

14:54 Changeset [123294] by mitz@apple.com

<rdar://problem/11928576> SVG-as-image (constrained) intrinsic size calculation is wrong in vertical writing modes
https://bugs.webkit.org/show_bug.cgi?id=91918

Reviewed by Anders Carlsson.

Source/WebCore:

Test: svg/as-image/svg-intrinsic-size-rectangular-vertical.html

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox): When there is a content
renderer, it returns a physical intrinsic size and aspect ratio. The code was already
accounting for this by taking the reciprocal of the aspect ratio in the vertical case. Made
it also transpose the size itself, turning it from physical to logical. Moved this code
after setting m_intrinsicSize, since that member variable is always physical.

LayoutTests:

  • svg/as-image/svg-intrinsic-size-rectangular-vertical-expected.html: Added.
  • svg/as-image/svg-intrinsic-size-rectangular-vertical.html: Added.
14:22 Changeset [123293] by paroga@webkit.org

[WIN] Use GetDateFormat and GetTimeFormat instead of strftime
https://bugs.webkit.org/show_bug.cgi?id=83436

Reviewed by Brent Fulgham.

The MS CRT implementation of strftime calls the same two functions.
Using them directly avoids the overhead of parsing the format string and removes
the dependency on strftime() for WinCE where this function does not exist.

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

11:33 Changeset [123292] by commit-queue@webkit.org

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-21

  • DEPS:
07:50 Changeset [123291] by paroga@webkit.org

Cleanup TextEncoding USE(XXX_UNICODE) macros
https://bugs.webkit.org/show_bug.cgi?id=91923

Reviewed by Andreas Kling.

Replace PLATFORM(QT) with USE(QT4_UNICODE) and OS(WINCE) with USE(WINCE_UNICODE).
This gives us more flexibility in choosing the unicode backend for a port.

  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps):

04:10 Changeset [123290] by paroga@webkit.org

Remove unnecessary ICU header includes from SimpleFontDataWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=91922

Reviewed by Kentaro Hara.

This allows us to use SimpleFontDataWin with an other Unicode implementation too.

  • platform/graphics/win/SimpleFontDataWin.cpp:
01:01 Changeset [123289] by kseo@webkit.org

A start tag whose tag name is "html" in the "in body" insertion mode is a parse error
https://bugs.webkit.org/show_bug.cgi?id=91916

Reviewed by Eric Seidel.

According to the HTML5 spec, a start tag whose tag name is "html" in the "in body"
insertion mode is a parse error.

Added HTMLTreeBuilder::processHtmlStartTagForInBody(AtomicHTMLToken&) to call parseError(token).
Removed "FIXME: parse error" from HTMLConstructionSite::insertHTMLHtmlStartTagInBody and
HTMLConstructionSite::insertHTMLBodyStartTagInBody because we already marked the call sites
of these two methods with parseError(token).

No behavior change because parseError(token) is just a marker.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):

  • html/parser/HTMLTreeBuilder.h:

07/20/12:

23:07 Changeset [123288] by commit-queue@webkit.org

double data type shoud be changed to float in ColorMatrix
https://bugs.webkit.org/show_bug.cgi?id=91499

Patch by Czene Tamás <tczene@inf.u-szeged.hu> on 2012-07-20
Reviewed by Nikolas Zimmermann.

  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::matrix):
(WebCore::saturate):
(WebCore::huerotate):
(WebCore::luminance):
(WebCore::effectType):

20:58 Changeset [123287] by commit-queue@webkit.org

[EFL] Remove unused headers from ewk_security_origin
https://bugs.webkit.org/show_bug.cgi?id=91914

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-20
Reviewed by Noam Rosenthal.

There are some unused header in the ewk_security_origin.h/cpp
We need to remove them.

  • ewk/ewk_security_origin.cpp:
  • ewk/ewk_security_origin.h:
20:35 Changeset [123286] by tony@chromium.org

[chromium] Mark anther test as needing a rebaseline due to r123285.

  • platform/chromium/TestExpectations:
19:50 Changeset [123285] by senorblanco@chromium.org

Source/WebCore: [chromium] Take current transformation matrix into account when
deciding on resize algorithm for drawPattern.
https://bugs.webkit.org/show_bug.cgi?id=90624

Reviewed by Adrienne Walker.

Since the pattern shader uses both the current transformation matrix
and the pattern matrix when transforming pixels, we need to
do the same when computing the resampling mode. Also removed the
resampling hint code, added in r60658, since it appears to be dead
(caller was removed in r76379).

Covered by existing tests, such as
fast/borders/border-image-scale-transform.html.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::computeResamplingMode):
Pass in the matrix to be used for computing the destination width and
height (for awesome resampling). Remove the image resampling hint code.
(WebCore::paintSkBitmap):
Pass in the CTM to computeResamplingMode().
(WebCore::Image::drawPattern):
Concatenate the CTM and the pattern matrix, and pass that to
computeResamplingMode() and TransformDimensions(). Invert the
CTM's scale and apply it to the pattern transform, so their
concatenation gives identity scale.

  • platform/graphics/skia/PlatformContextSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.h:

Remove the image resampling hint (dead code).

LayoutTests: [chromium] Mark a test as needing a rebaseline due to image change.
https://bugs.webkit.org/show_bug.cgi?id=90624

Reviewed by Adrienne Walker.

  • platform/chromium/TestExpectations:
19:46 Changeset [123284] by commit-queue@webkit.org

Anything else in the "in table" insertion mode is a parse error
https://bugs.webkit.org/show_bug.cgi?id=91915

Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-20
Reviewed by Adam Barth.

According to the HTML5 spec, anything else in the "in table" insertion mode is a parse error.

No behavior change because parseError(token) is just a marker.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTagForInTable):

19:00 Changeset [123283] by tkent@chromium.org

Rename ENABLE_DATALIST to ENABLE_DATALIST_ELEMENT
https://bugs.webkit.org/show_bug.cgi?id=91846

Reviewed by Kentaro Hara.

A flag name for an elmement should be ENABLE_*_ELEMENT.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • css/html.css:
  • html/HTMLDataListElement.cpp:
  • html/HTMLDataListElement.h:
  • html/HTMLDataListElement.idl:
  • html/HTMLInputElement.cpp:

(WebCore):
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::insertedInto):
(WebCore::HTMLInputElement::removedFrom):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/HTMLInputElement.idl:
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::parseAttribute):
(WebCore::HTMLOptionElement::childrenChanged):
(WebCore):

  • html/HTMLOptionElement.h:

(HTMLOptionElement):

  • html/HTMLTagNames.in:
  • html/InputType.cpp:

(WebCore):

  • html/InputType.h:

(InputType):

  • html/RangeInputType.cpp:

(WebCore):

  • html/RangeInputType.h:

(RangeInputType):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderContainer::layout):

  • page/DOMWindow.idl:
  • platform/efl/RenderThemeEfl.cpp:

(WebCore):

  • platform/efl/RenderThemeEfl.h:

(RenderThemeEfl):

  • platform/qt/RenderThemeQt.cpp:

(WebCore):

  • platform/qt/RenderThemeQt.h:

(RenderThemeQt):

  • rendering/RenderTheme.cpp:

(WebCore):

  • rendering/RenderTheme.h:

(RenderTheme):

  • rendering/RenderThemeChromiumLinux.cpp:

(WebCore):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):

  • rendering/RenderThemeChromiumLinux.h:

(RenderThemeChromiumLinux):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):

  • rendering/RenderThemeChromiumWin.h:

(RenderThemeChromiumWin):

  • rendering/RenderThemeMac.h:

(RenderThemeMac):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore):

Source/WebKit/chromium:

  • features.gypi:
  • src/WebInputElement.cpp:

(WebKit::WebInputElement::dataListOptions):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
18:52 Changeset [123282] by tony@chromium.org

[chromium] Unreviewed, one more new baselines after r123272 (I missed SL).

  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
18:03 Changeset [123281] by rniwa@webkit.org

Unify HTMLCollection and DynamicNodeList
https://bugs.webkit.org/show_bug.cgi?id=91335

Reviewed by Anders Carlsson.

This is the grand unification of HTMLCollection and DynamicNodeList.

It merges implementations of item() and length() in ChildNodeList, DynamicNodeList,
and HTMLCollection. The unified implementation is based on the one used for HTMLCollection,
that has been improved over the last few days; see r122660 and r122672 for examples.

There are five key changes:

  1. Made itemBeforeOrAfter aware of DynamicNodeList.
  2. itemBeforeOrAfter and related functions take and return Node* to support ChildNodeList.
  3. Renamed InvalidCollectionType to NodeListCollectionType since DynamicNodeLists need to be

identified itemBeforeOrAfter.

  1. Renamed itemAfter to virtualItemAfter in subclasses of HTMLCollection, and devirtualized

itemAfter used in common cases to avoid performance regressions. To make this intent clear,
SupportItemBefore and DoNotSupportItemBefore have been renamed to DoesNotOverrideItemAfter
and OverridesItemAfter. This change also help us detect a subclass of HTMLCollection that
passes in a wrong value to ItemBeforeSupportType by making forward iterations fail (hit an
assertion or doesn't iterate at all) as well as backward iterations.

  1. Restricted the use of elementsArrayOffset to subclasses that provide virtualItemAfter.

This patch completes my effort to share code between HTMLCollection and DynamicNodeList.

  • dom/ChildNodeList.cpp:

(WebCore::ChildNodeList::ChildNodeList):
(WebCore): Removed length() and item().
(WebCore::ChildNodeList::nodeMatches):

  • dom/ChildNodeList.h:

(ChildNodeList):

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::ClassNodeList):

  • dom/Document.cpp:

(WebCore::Document::registerNodeListCache):
(WebCore::Document::unregisterNodeListCache):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeList::length):
(WebCore::DynamicNodeList::item):

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase): Takes new boolean argument
shouldOnlyIncludeDirectChildren indicating whether the non-child descendents should be
included or not. This is necessary to identify ChildNodeList in itemBeforeOrAfter.
(WebCore::DynamicNodeListCacheBase::ownerNode): Moved from DynamicNodeListCacheBase and
HTMLCollectionCacheBase.
(WebCore::DynamicNodeListCacheBase::document): Moved from DynamicNodeListCacheBase.
(WebCore::DynamicNodeListCacheBase::rootNode): Ditto.
(WebCore::DynamicNodeListCacheBase::overridesItemAfter): Renamed from supportsItemBefore
and the return value has been negated.
(WebCore::DynamicNodeListCacheBase::shouldOnlyIncludeDirectChildren): Added.
(WebCore::DynamicNodeListCacheBase):
(WebCore::DynamicNodeList::DynamicNodeList): Takes NodeListType to determine the value of
shouldOnlyIncludeDirectChildren.
(DynamicNodeList):
(WebCore::DynamicSubtreeNodeList::~DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):

  • dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::MicroDataItemList):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::NameNodeList):

  • dom/TagNodeList.cpp:

(WebCore::TagNodeList::TagNodeList):

  • html/CollectionType.h:
  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::HTMLAllCollection):

  • html/HTMLCollection.cpp:

(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::isAcceptableElement):
(WebCore::firstNode): Extracted from itemBeforeOrAfter.
(WebCore::DynamicNodeListCacheBase::iterateForNextNode): Ditto.
(WebCore::DynamicNodeListCacheBase::itemBeforeOrAfter): Takes and returns Node*.
Special case ChildNodeList since there is no need to skip any node. When "this" is a
node list, call nodeMatches instead of isAcceptableElement.
(WebCore::DynamicNodeListCacheBase::itemBefore): No longer takes offsetInArray since
the use of elementsArrayOffset has been restricted to HTMLCollections that provides
virtualItemAfter.
(WebCore::DynamicNodeListCacheBase::itemAfter): Calls virtualItemAfter if necessary.
Otherwise assert offsetInArray is zero since we should never be using this variable
when virtualItemAfter is not provided.
(WebCore::DynamicNodeListCacheBase::isLastItemCloserThanLastOrCachedItem):
(WebCore::DynamicNodeListCacheBase::isFirstItemCloserThanCachedItem):
(WebCore::DynamicNodeListCacheBase::setItemCache): Updates m_cachedElementsArrayOffset
in HTMLCollection if and only if virtualItemAfter is provided. This is safe because
node lists never provide virtualItemAfter.
(WebCore::DynamicNodeListCacheBase::cachedElementsArrayOffset): Similarly, returns
m_cachedElementsArrayOffset if virtualItemAfter is provided.
(WebCore::DynamicNodeListCacheBase::lengthCommon):
(WebCore::DynamicNodeListCacheBase::itemCommon): Note that supportsItemBefore() is
equivalent to !overridesItemAfter() here.
(WebCore::DynamicNodeListCacheBase::itemBeforeOrAfterCachedItem): Uses Node* through
out the function. Since itemBefore never uses offsetInArray, always sets 0 for that.
Note that we never call itemBefore and virtualItemAfter on the same object.
(WebCore::HTMLCollection::virtualItemAfter): Added only to make the class "concrete".
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
(WebCore::HTMLCollection::tags):

  • html/HTMLCollection.h:

(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollectionCacheBase):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::base):
(HTMLCollection):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::virtualItemAfter):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::HTMLNameCollection):
(WebCore::HTMLNameCollection::virtualItemAfter):

  • html/HTMLNameCollection.h:

(HTMLNameCollection):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::virtualItemAfter):
(WebCore::HTMLPropertiesCollection::updateNameCache):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::virtualItemAfter):

  • html/HTMLTableRowsCollection.h:

(HTMLTableRowsCollection):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::LabelsNodeList):

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList):

17:33 Changeset [123280] by tony@chromium.org

[chromium] Unreviewed, one more new baselines after r123272.

  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
17:28 Changeset [123279] by wangxianzhu@chromium.org

[Chromium-Android] Store test pipes in /data/local/tmp
https://bugs.webkit.org/show_bug.cgi?id=91909

In the previous change (bug 91873, r123258) we placed the pipes in /sdcard/native_tests.
However after tests we found some devices don't allow the app to create pipes there.
So /data/local/tmp is a better place for the pipes.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:
17:24 Changeset [123278] by tony@chromium.org

[chromium] Unreviewed, land new baselines after r123272.

  • platform/chromium-linux/media/controls-styling-strict-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png: Added.
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/css1/basic/inheritance-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-layout-direction-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-strict-expected.png: Added.
  • platform/chromium-mac/media/controls-styling-strict-expected.txt: Added.
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-controls-clone-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-layout-direction-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-strict-expected.png: Added.
  • platform/chromium-win/media/controls-styling-strict-expected.txt: Added.
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
16:56 Changeset [123277] by caio.oliveira@openbossa.org

[Qt] svg/text rebaseline after new test fonts (part 4)
https://bugs.webkit.org/show_bug.cgi?id=91905

Unreviewed.

Two tests, svg/text/foreignObject-text-clipping-bug.xml and
svg/text/scaling-font-with-geometric-precision.html, still have incorrect results.

This is not a regression because they were incorrect before, but had expected files with
the wrong results. Instead of updating wrong expectations, I kept them skipped but created
a new bug to track each one.

  • platform/qt-5.0/Skipped:
  • platform/qt/svg/text/font-size-below-point-five-2-expected.png:
  • platform/qt/svg/text/font-size-below-point-five-2-expected.txt:
  • platform/qt/svg/text/font-size-below-point-five-expected.png:
  • platform/qt/svg/text/font-size-below-point-five-expected.txt:
  • platform/qt/svg/text/lengthAdjust-text-metrics-expected.txt:
  • platform/qt/svg/text/modify-text-node-in-tspan-expected.png:
  • platform/qt/svg/text/modify-text-node-in-tspan-expected.txt:
  • platform/qt/svg/text/remove-text-node-from-tspan-expected.png:
  • platform/qt/svg/text/remove-text-node-from-tspan-expected.txt:
  • platform/qt/svg/text/remove-tspan-from-text-expected.png:
  • platform/qt/svg/text/remove-tspan-from-text-expected.txt:
  • platform/qt/svg/text/text-altglyph-01-b-expected.png:
  • platform/qt/svg/text/text-altglyph-01-b-expected.txt:
  • platform/qt/svg/text/text-deco-01-b-expected.png:
  • platform/qt/svg/text/text-deco-01-b-expected.txt:
  • platform/qt/svg/text/text-fill-opacity-expected.png:
  • platform/qt/svg/text/text-fill-opacity-expected.txt:
  • platform/qt/svg/text/text-fonts-02-t-expected.png:
  • platform/qt/svg/text/text-fonts-02-t-expected.txt:
  • platform/qt/svg/text/text-gradient-positioning-expected.png:
  • platform/qt/svg/text/text-gradient-positioning-expected.txt:
  • platform/qt/svg/text/text-midpoint-split-bug-expected.png:
  • platform/qt/svg/text/text-midpoint-split-bug-expected.txt:
  • platform/qt/svg/text/text-path-middle-align-expected.txt:
  • platform/qt/svg/text/text-repaint-rects-expected.png:
  • platform/qt/svg/text/text-repaint-rects-expected.txt:
  • platform/qt/svg/text/text-spacing-01-b-expected.png:
  • platform/qt/svg/text/text-spacing-01-b-expected.txt:
  • platform/qt/svg/text/text-tref-01-b-expected.png:
  • platform/qt/svg/text/text-tref-01-b-expected.txt:
  • platform/qt/svg/text/text-viewbox-rescale-expected.png:
  • platform/qt/svg/text/text-viewbox-rescale-expected.txt:
  • platform/qt/svg/text/textPathBoundsBug-expected.txt:
16:54 Changeset [123276] by jsbell@chromium.org

IndexedDB: Simplify backend interface classes
https://bugs.webkit.org/show_bug.cgi?id=91901

Reviewed by Tony Chang.

Source/WebCore:

The IDBTransactionBackendInterface included several methods only used by the
real implementation objects, not via the interfaces. Expose a static Impl::from(Interface)
method for transaction, and migrate all of the backend-internal uses from Interface to Impl.

No new tests - no functional changes.

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(WebCore):
(WebCore::IDBCursorBackendImpl::create):
(IDBCursorBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::objectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::setVersionInternal):
(WebCore::IDBDatabaseBackendImpl::transactionStarted):
(WebCore::IDBDatabaseBackendImpl::transactionFinished):
(WebCore::IDBDatabaseBackendImpl::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursorInternal):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::countInternal): Drop unused transaction argument.
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::createIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::countInternal): Drop unused transaction argument.

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore):
(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::from):
(IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::mode):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

(IDBTransactionBackendInterface):

Source/WebKit/chromium:

Remove unnecessary method stubs from proxy class.

  • src/IDBTransactionBackendProxy.cpp:
  • src/IDBTransactionBackendProxy.h:

(IDBTransactionBackendProxy):

16:51 Changeset [123275] by jsbell@chromium.org

IndexedDB: "ASSERTION FAILED: !m_requestFinished" hit in IDBRequest::dispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=86911

Reviewed by Tony Chang.

Source/WebCore:

Clean up the IDBRequest/IDBCursor relationship and the IDBRequest lifecycle.

The IDBRequest's m_cursor/setCursor() calls are renamed to m_pendingCursor/setPendingCursor() to
clarify that the request will move between two states - either there's a cursor request in-flight
c/o a continue() or advance() call, or the result has come in (cursor, null-for-done, or error).
Since they were only ever used together, resetReadyState() is merged into setResultCursor(). The
m_requestFinished flag becomes redundant and is dropped - the ASSERT reported in the bug
becomes an ASSERT(m_readyState == PENDING) and m_readyState tracking is already correct.

Test: storage/indexeddb/request-continue-abort.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance): Unreachable code path now dead and gone.
(WebCore::IDBCursor::continueFunction): Ditto.

  • Modules/indexeddb/IDBRequest.cpp: Most functions just add state assertions.

(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::setCursorDetails):
(WebCore::IDBRequest::setPendingCursor): Merge with old resetReadyState().
(WebCore):
(WebCore::IDBRequest::getResultCursor): Helper, since digging cursor out of IDBAny is pesky.
(WebCore::IDBRequest::setResultCursor): Just moved in the file to be with its friends.
(WebCore::IDBRequest::finishCursor):
(WebCore::IDBRequest::onError): Just assertions, re-ordering, re-naming.
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::hasPendingActivity):
(WebCore::IDBRequest::dispatchEvent): Simplify!
(WebCore::IDBRequest::enqueueEvent):

  • Modules/indexeddb/IDBRequest.h:

(IDBRequest):

LayoutTests:

Added regression test based on repro steps in the bug.

  • storage/indexeddb/request-continue-abort-expected.txt: Added.
  • storage/indexeddb/request-continue-abort.html: Added.
  • storage/indexeddb/resources/request-continue-abort.js: Added.

(test.request.onsuccess.request.onsuccess.request.onsuccess):
(test.request.onsuccess.request.onsuccess):
(test.request.onsuccess):
(test):
(onUpgrade):
(testCursor.request.onsuccess):
(testCursor.request.onerror):
(testCursor.transaction.onabort):
(testCursor):

16:39 Changeset [123274] by tony@chromium.org

Add windows native versions of bison, flex and gperf.

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-20
Reviewed by Tony Chang.

  • DEPS:
16:15 Changeset [123273] by caio.oliveira@openbossa.org

[Qt] svg/text rebaseline after new test fonts (part 3)
https://bugs.webkit.org/show_bug.cgi?id=91904

Unreviewed.

  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Removed.
  • platform/qt-5.0/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-overflow-ellipsis-svgfont-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-tselect-01-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-tselect-01-b-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-tspan-01-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-tspan-01-b-expected.txt: Removed.
  • platform/qt/svg/text/append-text-node-to-tspan-expected.png:
  • platform/qt/svg/text/append-text-node-to-tspan-expected.txt:
  • platform/qt/svg/text/ems-display-none-expected.png:
  • platform/qt/svg/text/ems-display-none-expected.txt:
  • platform/qt/svg/text/exs-display-none-expected.png:
  • platform/qt/svg/text/exs-display-none-expected.txt:
  • platform/qt/svg/text/foreignObject-repaint-expected.png:
  • platform/qt/svg/text/foreignObject-repaint-expected.txt:
  • platform/qt/svg/text/scaled-font-expected.png:
  • platform/qt/svg/text/scaled-font-expected.txt:
  • platform/qt/svg/text/text-overflow-ellipsis-svgfont-expected.png:
  • platform/qt/svg/text/text-overflow-ellipsis-svgfont-expected.txt:
  • platform/qt/svg/text/text-tselect-01-b-expected.png:
  • platform/qt/svg/text/text-tselect-01-b-expected.txt:
  • platform/qt/svg/text/text-tspan-01-b-expected.png:
  • platform/qt/svg/text/text-tspan-01-b-expected.txt:
  • platform/qt/svg/text/text-ws-01-t-expected.png:
  • platform/qt/svg/text/text-ws-01-t-expected.txt:
  • platform/qt/svg/text/text-ws-02-t-expected.png:
  • platform/qt/svg/text/text-ws-02-t-expected.txt:
16:06 Changeset [123272] by scherkus@chromium.org

[chromium] Don't display fullscreen button for video elements not containing video
https://bugs.webkit.org/show_bug.cgi?id=91811

Reviewed by Eric Carlson.

Covered by media/media-document-audio-repaint.html

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::reset):

16:03 Changeset [123271] by scherkus@chromium.org

[chromium] Unreviewed rebaselined due to r123259.

  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/audio-repaint-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-controls-clone-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-playing-and-pause-expected.txt:
  • platform/chromium-mac/media/video-zoom-controls-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/audio-repaint-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-controls-clone-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-playing-and-pause-expected.txt:
  • platform/chromium-win/media/video-zoom-controls-expected.txt:
  • platform/chromium/TestExpectations:
15:56 Changeset [123270] by commit-queue@webkit.org

[Qt] ietestcenter needs rebaseline after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=91886

Updating skipped tests inside ietestcenter. The following tests
remain skipped:
/css3/bordersbackgrounds/border-radius-style-001-expected.txt (not using dashed line)
/css3/bordersbackgrounds/border-radius-style-002-expected.txt (not using dashed line)
/css3/text/textshadow-002-expected.txt (missing bar on top of blue text)

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-20
Reviewed by Noam Rosenthal.

  • platform/qt-5.0-wk1/Skipped:
  • platform/qt-5.0/Skipped:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.png: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-001-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-001-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-003-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-003-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-004-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-004-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-005-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-005-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-006-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-006-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-007-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-007-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-008-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-008-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-009-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-009-expected.txt:
  • platform/qt/ietestcenter/css3/text/textshadow-010-expected.png: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-010-expected.txt:
15:56 Changeset [123269] by dimich@chromium.org

[Chromium] Out of Memory is observed when a large object is passed to a Web Worker.
https://bugs.webkit.org/show_bug.cgi?id=91535.

Reviewed by David Levin.

No new tests because of no new behavior and lack of mechanism to monitor used memory.

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::registerMemoryAllocatedWithCurrentScriptContext):
(WebCore):
(WebCore::SerializedScriptValue::~SerializedScriptValue):

  • bindings/v8/SerializedScriptValue.h:

(SerializedScriptValue):
Added a method to SerializedScriptValue to add memory pressure on GC proportional to the size of memory allocated in serialized data.

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):
Call the new method of SerializedScriptValue during creation of MessageEvent (presumably in the thread which contains the right V8 context).

15:41 Changeset [123268] by caio.oliveira@openbossa.org

[Qt] svg/text rebaseline after new test fonts (part 2)
https://bugs.webkit.org/show_bug.cgi?id=91902

Reviewed by Noam Rosenthal.

  • platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.txt: Removed.
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/text/text-align-01-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-align-01-b-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-align-02-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-align-02-b-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-align-04-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-align-04-b-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-align-06-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-align-06-b-expected.txt: Removed.
  • platform/qt/svg/text/multichar-glyph-expected.png:
  • platform/qt/svg/text/multichar-glyph-expected.txt:
  • platform/qt/svg/text/selection-background-color-expected.png: Added.
  • platform/qt/svg/text/selection-background-color-expected.txt:
  • platform/qt/svg/text/selection-styles-expected.png:
  • platform/qt/svg/text/selection-styles-expected.txt:
  • platform/qt/svg/text/selection-tripleclick-expected.png:
  • platform/qt/svg/text/selection-tripleclick-expected.txt:
  • platform/qt/svg/text/text-align-01-b-expected.png:
  • platform/qt/svg/text/text-align-01-b-expected.txt:
  • platform/qt/svg/text/text-align-02-b-expected.png:
  • platform/qt/svg/text/text-align-02-b-expected.txt:
  • platform/qt/svg/text/text-align-03-b-expected.png:
  • platform/qt/svg/text/text-align-03-b-expected.txt:
  • platform/qt/svg/text/text-align-04-b-expected.png:
  • platform/qt/svg/text/text-align-04-b-expected.txt:
  • platform/qt/svg/text/text-align-05-b-expected.png:
  • platform/qt/svg/text/text-align-05-b-expected.txt:
  • platform/qt/svg/text/text-align-06-b-expected.png:
  • platform/qt/svg/text/text-align-06-b-expected.txt:
  • platform/qt/svg/text/text-path-01-b-expected.png:
  • platform/qt/svg/text/text-path-01-b-expected.txt:
  • platform/qt/svg/text/tspan-dynamic-positioning-expected.png:
  • platform/qt/svg/text/tspan-dynamic-positioning-expected.txt:
14:56 Changeset [123267] by dgrogan@chromium.org

IndexedDB: Include intVersion when converting between WebCore and WebKit IDBMetadata types
https://bugs.webkit.org/show_bug.cgi?id=91414

Reviewed by Adam Barth.

Source/WebCore:

No new tests because no new behavior.

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::metadata):
No behavior change, this just needs a dummy parameter to match the
modified API.

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
(IDBDatabaseMetadata):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:
  • src/WebIDBMetadata.cpp:

(WebKit::WebIDBMetadata::WebIDBMetadata):
(WebKit::WebIDBMetadata::operator IDBDatabaseMetadata):

14:45 Changeset [123266] by commit-queue@webkit.org

Source/WebCore: [Soup] Unnecessary RefPtr usage and null check
https://bugs.webkit.org/show_bug.cgi?id=91636

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-07-18
Reviewed by Martin Robinson.

Small clean up of code that is not necessary; no change in functionality.

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::connected):

Source/WebKit/blackberry: [BlackBerry] clock_gettime() in BackingStore.cpp should use CLOCK_MONOTONIC
https://bugs.webkit.org/show_bug.cgi?id=91898

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-07-20
Reviewed by Yong Li.

PR: 181043
Use CLOCK_MONOTONIC when we do expect a monotonic timer.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitContents):

LayoutTests: [Qt] svg/text rebaseline after new test fonts (part 1)
https://bugs.webkit.org/show_bug.cgi?id=91762

Patch by Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> on 2012-07-20
Reviewed by Andreas Kling.

  • platform/qt-5.0-wk2/svg/text/kerning-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/text/kerning-expected.txt: Removed.
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/text/text-text-01-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-text-01-b-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-text-04-t-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-text-04-t-expected.txt: Removed.
  • platform/qt/svg/text/kerning-expected.png:
  • platform/qt/svg/text/kerning-expected.txt:
  • platform/qt/svg/text/small-fonts-2-expected.png:
  • platform/qt/svg/text/small-fonts-2-expected.txt:
  • platform/qt/svg/text/small-fonts-3-expected.png:
  • platform/qt/svg/text/small-fonts-3-expected.txt:
  • platform/qt/svg/text/small-fonts-expected.png:
  • platform/qt/svg/text/small-fonts-expected.txt: Added.
  • platform/qt/svg/text/small-fonts-in-html5-expected.png:
  • platform/qt/svg/text/small-fonts-in-html5-expected.txt:
  • platform/qt/svg/text/text-text-01-b-expected.png:
  • platform/qt/svg/text/text-text-01-b-expected.txt:
  • platform/qt/svg/text/text-text-03-b-expected.png:
  • platform/qt/svg/text/text-text-03-b-expected.txt:
  • platform/qt/svg/text/text-text-04-t-expected.png:
  • platform/qt/svg/text/text-text-04-t-expected.txt:
  • platform/qt/svg/text/text-text-05-t-expected.png:
  • platform/qt/svg/text/text-text-05-t-expected.txt:
  • platform/qt/svg/text/text-text-06-t-expected.png:
  • platform/qt/svg/text/text-text-06-t-expected.txt:
  • platform/qt/svg/text/text-text-07-t-expected.png:
  • platform/qt/svg/text/text-text-07-t-expected.txt:
  • platform/qt/svg/text/text-text-08-b-expected.png:
  • platform/qt/svg/text/text-text-08-b-expected.txt:
14:41 Changeset [123265] by kov@webkit.org

[Soup] Unnecessary RefPtr usage and null check
https://bugs.webkit.org/show_bug.cgi?id=91636

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-07-18
Reviewed by Martin Robinson.

Small clean up of code that is not necessary; no change in functionality.

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::connected):

14:40 Changeset [123264] by caio.oliveira@openbossa.org

[Qt] svg/text rebaseline after new test fonts (part 1)
https://bugs.webkit.org/show_bug.cgi?id=91762

Reviewed by Andreas Kling.

  • platform/qt-5.0-wk2/svg/text/kerning-expected.png: Removed.
  • platform/qt-5.0-wk2/svg/text/kerning-expected.txt: Removed.
  • platform/qt-5.0/Skipped:
  • platform/qt-5.0/svg/text/text-text-01-b-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-text-01-b-expected.txt: Removed.
  • platform/qt-5.0/svg/text/text-text-04-t-expected.png: Removed.
  • platform/qt-5.0/svg/text/text-text-04-t-expected.txt: Removed.
  • platform/qt/svg/text/kerning-expected.png:
  • platform/qt/svg/text/kerning-expected.txt:
  • platform/qt/svg/text/small-fonts-2-expected.png:
  • platform/qt/svg/text/small-fonts-2-expected.txt:
  • platform/qt/svg/text/small-fonts-3-expected.png:
  • platform/qt/svg/text/small-fonts-3-expected.txt:
  • platform/qt/svg/text/small-fonts-expected.png:
  • platform/qt/svg/text/small-fonts-expected.txt: Added.
  • platform/qt/svg/text/small-fonts-in-html5-expected.png:
  • platform/qt/svg/text/small-fonts-in-html5-expected.txt:
  • platform/qt/svg/text/text-text-01-b-expected.png:
  • platform/qt/svg/text/text-text-01-b-expected.txt:
  • platform/qt/svg/text/text-text-03-b-expected.png:
  • platform/qt/svg/text/text-text-03-b-expected.txt:
  • platform/qt/svg/text/text-text-04-t-expected.png:
  • platform/qt/svg/text/text-text-04-t-expected.txt:
  • platform/qt/svg/text/text-text-05-t-expected.png:
  • platform/qt/svg/text/text-text-05-t-expected.txt:
  • platform/qt/svg/text/text-text-06-t-expected.png:
  • platform/qt/svg/text/text-text-06-t-expected.txt:
  • platform/qt/svg/text/text-text-07-t-expected.png:
  • platform/qt/svg/text/text-text-07-t-expected.txt:
  • platform/qt/svg/text/text-text-08-b-expected.png:
  • platform/qt/svg/text/text-text-08-b-expected.txt:
14:31 Changeset [123263] by tony@chromium.org

[chromium] Unreviewed gardening. Remove a test that hasn't been
added to the tree yet.

  • platform/chromium/TestExpectations:
14:27 Changeset [123262] by commit-queue@webkit.org

Typo in FontCacheWin.cpp causes return value from getCachedFontData() in getLastResortFallbackFont() to be ignored
https://bugs.webkit.org/show_bug.cgi?id=91506

Patch by Mark Salisbury <mark.salisbury@hp.com> on 2012-07-20
Reviewed by Joseph Pecoraro.

No new test. The "fallback fallback" code ends up creating a font, so you always
get a fallback font even with this code bug. A test would be buggy, being highly
platform dependent on what the "fallback fallback" font is on the particular
windows machine the test runs on.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

14:24 Changeset [123261] by tony@chromium.org

[chromium] Unreviewed, mark some tests as slow in debug.

  • platform/chromium/TestExpectations:
14:24 Changeset [123260] by senorblanco@chromium.org

[chromium] Clean up scratch texture usage in Chromium's implementation
of GPU-accelerated filters.
https://bugs.webkit.org/show_bug.cgi?id=83370

Reviewed by Adrienne Walker.

There didn't used to be a safe way to allocate a scratch texture, and
hold into it beyond the lifetime of GrAutoScratchTexture. Now there is:
detach().

Covered by existing tests in css3/filters.

  • platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:

(WebCore::CCRenderSurfaceFilters::apply):
Use a GrAutoScratchTexture to allocate the destination texture, and
detach() to detach it from the cache before placing it in an
SkGrTexturePixelRef. This means we no longer need to do any lock/
unlock trickery with the TextureCacheEntry, since the refcount is
enough to keep the texture away from the cache's prying hands.

14:12 Changeset [123259] by scherkus@chromium.org

[chromium] CSS tweaks to media controls to prevent styles from being overridden
https://bugs.webkit.org/show_bug.cgi?id=91802

Reviewed by Eric Carlson.

Source/WebCore:

Having the buttons declared as inline caused them to not be included in the box layout,
resulting in styles set outside the media element to affect the position of the buttons.

In a similar vein, it was also possible to override the font-style attribute for the time
display.

Test: media/controls-styling-strict.html

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):

LayoutTests:

  • media/controls-styling-strict.html: Added.
  • platform/chromium-linux/media/controls-styling-strict-expected.png: Added.
  • platform/chromium-linux/media/controls-styling-strict-expected.txt: Added.
14:08 Changeset [123258] by wangxianzhu@chromium.org

[Chomium-Android] Place DRT input/output pipes where both app and unrooted shell can read/write
https://bugs.webkit.org/show_bug.cgi?id=91873

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:
14:01 Changeset [123257] by tony@chromium.org

[chromium] Unreviewed gardening. Unskip some tests that just need new baselines.

  • platform/chromium/TestExpectations:
14:01 Changeset [123256] by commit-queue@webkit.org

[chromium][Mac] Switch the MACOSX_DEPLOYMENT_TARGET to 10.6
https://bugs.webkit.org/show_bug.cgi?id=91752

Patch by Robert Sesek <rsesek@chromium.org> on 2012-07-20
Reviewed by Eric Seidel.

Use 10.6 NSScreen/NSColorSpace APIs to determine if the screen is
monochrome rather than comparing against deprecated colorspace names.

  • src/mac/WebScreenInfoFactory.mm:

(WebKit::WebScreenInfoFactory::screenInfo):

13:42 Changeset [123255] by commit-queue@webkit.org

[BlackBerry] Add Cancel button for Select popup
https://bugs.webkit.org/show_bug.cgi?id=91887

Patch by Crystal Zhang <haizhang@rim.com> on 2012-07-20
Reviewed by Yong Li.

PR 177706

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::generateHTML):
(WebCore::SelectPopupClient::setValueAndClosePopup):

13:24 Changeset [123254] by commit-queue@webkit.org

Introduce WebViewBenchmarkSupport for performance experiments on a real WebView
https://bugs.webkit.org/show_bug.cgi?id=88271

Patch by Daniel Murphy <dmurph@chromium.org> on 2012-07-20
Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebView.h:

(WebKit):
(WebView):
(WebKit::WebView::benchmarkSupport):

  • public/WebViewBenchmarkSupport.h: Added.

(WebKit):
(WebViewBenchmarkSupport):
(PaintClient):
(WebKit::WebViewBenchmarkSupport::PaintClient::willPaint):
(WebKit::WebViewBenchmarkSupport::PaintClient::didPaint):
(WebKit::WebViewBenchmarkSupport::PaintClient::~PaintClient):
(WebKit::WebViewBenchmarkSupport::~WebViewBenchmarkSupport):

  • src/WebViewBenchmarkSupportImpl.cpp: Added.

(WebKit):
(WebKit::WebViewBenchmarkSupportImpl::paintLayer):
(WebKit::WebViewBenchmarkSupportImpl::acceleratedPaintUnclipped):
(WebKit::WebViewBenchmarkSupportImpl::softwarePaint):
(WebKit::WebViewBenchmarkSupportImpl::paint):

  • src/WebViewBenchmarkSupportImpl.h: Added.

(WebCore):
(WebKit):
(WebViewBenchmarkSupportImpl):
(WebKit::WebViewBenchmarkSupportImpl::WebViewBenchmarkSupportImpl):
(WebKit::WebViewBenchmarkSupportImpl::~WebViewBenchmarkSupportImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::benchmarkSupport):
(WebKit):
(WebKit::WebViewImpl::rootGraphicsLayer):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

13:09 Changeset [123253] by commit-queue@webkit.org

[Chromium] Compilation fails under gcc 4.7
https://bugs.webkit.org/show_bug.cgi?id=90227

Patch by Han Shen <shenhan@google.com> on 2012-07-20
Reviewed by Tony Chang.

Disable warnings about c++0x compatibility in gcc newer than 4.6.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKitUnitTests.gyp:

Source/WTF:

  • WTF.gyp/WTF.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
13:07 Changeset [123252] by tony@chromium.org

[chromium] Rebaseline css3/filters/custom tests
https://bugs.webkit.org/show_bug.cgi?id=82372

Unreviewed, but unofficially reviewed by Chiculita Alexandru and Stephen White.

Add baselines for these tests. They are enabled and use the Mesa
software renderer.

  • platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
  • platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
  • platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png:
  • platform/chromium-win/css3/filters/custom/custom-filter-shader-cache-expected.png: Added.
  • platform/chromium-win/css3/filters/custom/effect-custom-combined-missing-expected.png: Added.
  • platform/chromium-win/css3/filters/custom/effect-custom-expected.png: Added.
  • platform/chromium-win/css3/filters/custom/effect-custom-parameters-expected.png: Added.
  • platform/chromium-win/css3/filters/custom/missing-custom-filter-shader-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/filters/custom/missing-custom-filter-shader-expected.png.
  • platform/chromium/TestExpectations:
13:02 Changeset [123251] by jchaffraix@webkit.org

Revert 117339 - CSS 2.1 failure: inline-table-001 fails
https://bugs.webkit.org/show_bug.cgi?id=84167

Reviewed by Julien Chaffraix.

Source/WebCore:

Override lastLineBoxBaseline() in RenderTable so that it picks up the baseline
of the text in the first row of the table. This allows inline tables to find the
correct baseline to align to.

Tests:

css2.1/20110323/inline-table-001.htm
css2.1/20110323/inline-table-002a.htm
css2.1/20110323/inline-table-003.htm
fast/css/empty-cell-baseline.html

  • rendering/RenderTable.cpp:

(WebCore::getLineBoxBaseline):
(WebCore):
(WebCore::RenderTable::lastLineBoxBaseline):
(WebCore::RenderTable::firstLineBoxBaseline):

  • rendering/RenderTable.h:

(RenderTable):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstLineBoxBaseline): if a cell is empty it cannot provide a

baseline. Tested by fast/css/empty-cell-baseline.html

LayoutTests:

  • css2.1/20110323/inline-table-001.htm: Added.
  • css2.1/20110323/inline-table-002a.htm: Added.
  • css2.1/20110323/inline-table-003.htm: Added. From the CSS 2.1 test suite.
  • fast/css/empty-cell-baseline-expected.html: Added.
  • fast/css/empty-cell-baseline.html: Added. This ensures we don't take a baseline from an empty cell.
  • fast/inline-block/001.html: Modified to make expected results clearer.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-001-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-002a-expected.txt: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.png: Added.
  • platform/chromium-linux-x86/css2.1/20110323/inline-table-003-expected.txt: Added.
  • platform/chromium-linux/editing/pasteboard/innerText-inline-table-expected.png:

Progression, the baseline of the text in each cell has moved up to where it should be.

  • platform/chromium-linux/editing/selection/iframe-expected.png:

Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.

  • platform/chromium-linux/editing/selection/inline-table-expected.png:

Progression, 'Inline Table' and 'The End' line up with the first row of the inline table.

  • platform/chromium-linux/editing/selection/table-caret-3-expected.png:

Progression, 'foo' and 'baz' line up with the first row of the inline table.

  • platform/chromium-linux/fast/css-generated-content/inline-display-types-expected.png:

Progression, 'Test' and 'content' now line up.

  • platform/chromium-linux/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png:

Progression, the two boxes now line up.

  • platform/chromium-linux/fast/inline-block/001-expected.png:

Progression, the boxes now line up in the same way as FF and Opera.

  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:

Progression, the baseline of the text in each cell has moved up to where it should be.

  • platform/chromium-win/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/chromium-win/editing/selection/iframe-expected.txt:
  • platform/chromium-win/editing/selection/inline-table-expected.txt:
  • platform/chromium-win/editing/selection/table-caret-3-expected.txt:
  • platform/chromium-win/fast/css-generated-content/inline-display-types-expected.txt:
  • platform/chromium-win/fast/inline-block/001-expected.txt:
  • platform/chromium-win/fast/repaint/float-overflow-expected.txt:
  • platform/chromium-win/fast/repaint/float-overflow-right-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/Skipped:

Text rebaselines.

TBR=robert@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10807056

12:59 Changeset [123250] by dpranke@chromium.org

REGRESSION: run-perf-tests --pause-before-testing is broken
https://bugs.webkit.org/show_bug.cgi?id=91789

Reviewed by Ryosuke Niwa.

Turns out start() wasn't actually starting things :(. Fixed, and
added tests.

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidDriverTest.test_read_prompt):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.init):
(Driver._start):

  • Scripts/webkitpy/layout_tests/port/driver_unittest.py:

(DriverTest.test_read_block):
(DriverTest.test_read_binary_block):
(DriverTest.test_read_base64_block):
(DriverTest.test_stop_cleans_up_properly):
(DriverTest.test_two_starts_cleans_up_properly):
(DriverTest.test_start_actually_starts):
(MockServerProcess.init):
(MockServerProcess.start):

12:43 Changeset [123249] by rafael.lobo@openbossa.org

QtNetworkAccessManager should not rely on signal sslErrors when QT_NO_SSL is defined
https://bugs.webkit.org/show_bug.cgi?id=91866

Reviewed by Noam Rosenthal.

  • WebProcess/qt/QtNetworkAccessManager.cpp:

(WebKit::QtNetworkAccessManager::QtNetworkAccessManager): QNAM's signal is only defined when
that flag is undefined. Removed the connection when we have the flag set.
(WebKit::QtNetworkAccessManager::onSslErrors): When the flag is set, this slot becomes unused.

12:43 Changeset [123248] by scheib@chromium.org

Unreviewed compile fix, r123247 included unintended changes to Document.cpp.

See http://trac.webkit.org/changeset/123247.

  • dom/Document.cpp:

(WebCore::Document::webkitExitPointerLock):

12:17 Changeset [123247] by scheib@chromium.org

Move pointer lock test resources to http/tests/resources in preparation for adding new tests to http.
https://bugs.webkit.org/show_bug.cgi?id=91882

Reviewed by Adrienne Walker.

  • http/tests/resources/pointer-lock/pointer-lock-test-harness.js: Renamed from LayoutTests/pointer-lock/resources/pointer-lock-test-harness.js.
  • pointer-lock/bug90391-move-then-window-open-crash.html:
  • pointer-lock/lock-already-locked.html:
  • pointer-lock/lock-element-not-in-dom.html:
  • pointer-lock/lock-fail-responses.html:
  • pointer-lock/locked-element-iframe-removed-from-dom.html:
  • pointer-lock/locked-element-removed-from-dom.html:
  • pointer-lock/mouse-event-api.html:
  • pointer-lock/mouse-event-delivery.html:
  • pointer-lock/pointer-lock-api.html:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
  • pointer-lock/pointerlocklost-event.html:
11:58 Changeset [123246] by zandobersek@gmail.com

Unreviewed GTK gardening, adding platform-specific baseline for
fast/dom/Window/window-properties-performance.html that assumes jsHeapSizeLimit
attribute to be undefined, as expected for ports using JavaScriptCore.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/Window/window-properties-performance-expected.txt: Added.
11:43 Changeset [123245] by wsiegrist@apple.com

Add /usr/bin to PATH so PrettyPatch can find git.

11:40 Changeset [123244] by zandobersek@gmail.com

Unreviewed GTK gardening, adding image baseline for
fast/images/paletted-png-with-color-profile.html.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/images/paletted-png-with-color-profile-expected.png: Added.
11:28 Changeset [123243] by rniwa@webkit.org

REGRESSION(r122873): 15% regression on Dromaeo/dom-attr
https://bugs.webkit.org/show_bug.cgi?id=91827

Reviewed by Anders Carlsson.

Move shouldInvalidateNodeListCaches from Document.cpp to Node.cpp since it's only called
in Node::invalidateNodeListCachesInAncestors.

Test: PerformanceTests/Dromaeo/dom-attr.html.

  • dom/Document.cpp:

(WebCore):

  • dom/Node.cpp:

(WebCore::shouldInvalidateNodeListCachesForAttr): Extracted from shouldInvalidateNodeListCaches
to unroll the loop in shouldInvalidateNodeListCaches. Apparently gcc wasn't doing the right thing.
(WebCore::Document::shouldInvalidateNodeListCaches):
(WebCore::Document::invalidateNodeListCaches):
(WebCore::Node::invalidateNodeListCachesInAncestors):

11:27 Changeset [123242] by schenney@chromium.org

SVG Filter Effect sub-region not applied for some filters
https://bugs.webkit.org/show_bug.cgi?id=89767

Reviewed by Dirk Schulze.

Unreviewed test expectations update.

Numerous results changed by one pixel due to the difference between
clipping and pre-applying the filter subregion. Some feGaussianBlur
and feDropShadow results changed more, but that was expected.

  • platform/chromium-linux-x86/svg/batik/filters: Removed.
  • platform/chromium-linux-x86/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-linux-x86/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/filters/feDropShadow-expected.png:
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-linux/svg/filters/filterRes-expected.png:
  • platform/chromium-linux/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-linux/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-mac/svg/batik/filters/feTile-expected.png:
  • platform/chromium-mac/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/filters/feDropShadow-expected.png:
  • platform/chromium-mac/svg/filters/feDropShadow-subregion-expected.png: Added.
  • platform/chromium-mac/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-mac/svg/filters/feGaussianBlur-subregion-expected.png: Added.
  • platform/chromium-mac/svg/filters/feImage-subregions-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/chromium-mac/svg/filters/feOffset-expected.png:
  • platform/chromium-mac/svg/filters/feTile-expected.png:
  • platform/chromium-mac/svg/filters/filter-placement-issue-expected.png:
  • platform/chromium-mac/svg/filters/filter-rounding-issues-expected.png:
  • platform/chromium-mac/svg/filters/filterRes-expected.png:
  • platform/chromium-mac/svg/filters/filterRes1-expected.png:
  • platform/chromium-mac/svg/filters/filterRes3-expected.png:
  • platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/chromium-mac/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-win-xp/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-win-xp/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/filters/feDropShadow-expected.png:
  • platform/chromium-win/svg/filters/feDropShadow-subregion-expected.png: Added.
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-win/svg/filters/feGaussianBlur-subregion-expected.png: Added.
  • platform/chromium-win/svg/filters/feImage-subregions-expected.png:
  • platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/chromium-win/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/chromium-win/svg/filters/feOffset-expected.png:
  • platform/chromium-win/svg/filters/feTile-expected.png:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-win/svg/filters/filter-placement-issue-expected.png:
  • platform/chromium-win/svg/filters/filter-rounding-issues-expected.png:
  • platform/chromium-win/svg/filters/filterRes-expected.png:
  • platform/chromium-win/svg/filters/filterRes1-expected.png:
  • platform/chromium-win/svg/filters/filterRes3-expected.png:
  • platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-win/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium/TestExpectations:
11:19 Changeset [123241] by abarth@webkit.org

[Chromium] Add WebView::zoomToFindInPageRect for Android
https://bugs.webkit.org/show_bug.cgi?id=91801

Reviewed by Tony Chang.

On Android, when you find in page, we scale the viewport to reveal what
you've found (because the screen is small). This function instructs the
WebView to zoom to display a given rect.

  • public/WebView.h:

(WebView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::animateZoomAroundPoint):

  • This function is a bit more general than necessary for this patch because it is also used in other cases for animating a zoom around a given point (e.g., double-tap to zoom). These uses will be upstreamed in later patches.

(WebKit::WebViewImpl::zoomToFindInPageRect):

  • src/WebViewImpl.h:

(WebViewImpl):

11:13 Changeset [123240] by jochen@chromium.org

[chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91847

Reviewed by Adam Barth.

This allows for including the TestIntefaces.h from content shell
without introducing a dependency to WebCore/wtf

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:

(TestInterfaces::Internal):
(TestInterfaces::Internal::Internal):
(TestInterfaces::Internal::~Internal):
(TestInterfaces::Internal::bindTo):
(TestInterfaces::Internal::resetAll):
(TestInterfaces::TestInterfaces):
(TestInterfaces::~TestInterfaces):
(TestInterfaces::bindTo):
(TestInterfaces::resetAll):

  • DumpRenderTree/chromium/TestRunner/TestInterfaces.h:

(TestInterfaces):

11:11 Changeset [123239] by thakis@chromium.org

Fix more -Wunused-private-field violations
https://bugs.webkit.org/show_bug.cgi?id=91876

Reviewed by Adam Barth.

As of http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120716/061102.html
the warning finds more bugs. Fix them.

  • html/FTPDirectoryDocument.cpp:

(FTPDirectoryDocumentParser):
(WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):

  • html/shadow/MediaControlRootElementChromium.h:

(MediaControlRootElementChromium):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):

  • inspector/InspectorDOMStorageResource.h:

(InspectorDOMStorageResource):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

  • rendering/svg/RenderSVGTextPath.cpp:

(WebCore::RenderSVGTextPath::RenderSVGTextPath):

  • rendering/svg/RenderSVGTextPath.h:
11:10 Changeset [123238] by jsbell@chromium.org

[chromium] Unreviewed test expectations update.
Un-marking various tests as flaky on WIN following rollback of r121610
in http://trac.webkit.org/changeset/123110. Investigation documented in:
https://bugs.webkit.org/show_bug.cgi?id=90469

  • platform/chromium/TestExpectations:
11:05 Changeset [123237] by caio.oliveira@openbossa.org

[Qt] Make WTR use the same color palette as DRT
https://bugs.webkit.org/show_bug.cgi?id=91870

Reviewed by Noam Rosenthal.

Make sure that WebKitTestRunner and DumpRenderTree use the same palette: the
standard from QWindowsStyle.

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts): Moved code to platformInitialize since setting style is not
exactly font related.

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:

(WTR::InjectedBundle::platformInitialize): Force the usage of the style's
palette. Because at this point QApplication was already instantiated, the
default palette was already initialized to be the system one, so we need to
explicitly set the palette to be the standard from style. This is not needed in
DRT because there we set the style before instantiating QApplication.

11:02 Changeset [123236] by zandobersek@gmail.com

Unreviewed GTK gardening.

Generating baselines for two input placeholder tests that fail. The image
baselines used are from Chromium Linux that clearly denote what's missing
in the GTK port's output for these two tests, ignoring other marginal
rendering differences.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-paint-order-expected.txt: Added.
  • platform/gtk/fast/forms/textarea: Added.
  • platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Added.
11:01 Changeset [123235] by eae@chromium.org

Merge 122883 - vertical-align: middle causes overflow with subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=91464

Reviewed by Eric Seidel.

Source/WebCore:

Using vertical-align: middle in combination with an overflow value other
than visible can cause the overflow height to be computed incorrectly.

Test: fast/sub-pixel/vertical-align-middle-overflow.html

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):
Round verticalPosition after calculation instead of flooring the result
of the xHeight calculation. By flooring it the resulting value is in
effect rounded up which can cause the height of the box to grow by one.
By rounding the resulting value thevertical position is more accurate and
the off by one error is avoided.

LayoutTests:

Add new test for vertical-align: middle and adjust existing results to
reflect the improved alignment calculation.

  • fast/sub-pixel/vertical-align-middle-overflow-expected.txt: Added.
  • fast/sub-pixel/vertical-align-middle-overflow.html: Added.
  • platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-linux/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.png:
  • platform/chromium-linux/fast/inline/002-expected.png:
  • platform/chromium-linux/fast/table/table-display-types-strict-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/basic/014-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/line-height-determined-by-primary-font-expected.png:
  • platform/chromium-mac-snowleopard/fast/inline/002-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/table-display-types-strict-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.txt:
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/chromium-mac/fast/block/basic/014-expected.txt:
  • platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/chromium-win/css1/text_properties/vertical_align-expected.txt:
  • platform/chromium-win/fast/block/basic/014-expected.txt:
  • platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/chromium-win/fast/inline/002-expected.txt:
  • platform/chromium-win/fast/table/table-display-types-strict-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/fast/inline/002-expected.txt:
  • platform/mac/fast/replaced/008-expected.png:
  • platform/mac/fast/table/table-display-types-strict-expected.txt:

TBR=eae@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10796066

10:56 Changeset [123234] by eae@chromium.org

Merge 122861 - Incorrect offset used for scrollWidth/Height calculation
https://bugs.webkit.org/show_bug.cgi?id=91461

Reviewed by Eric Seidel.

Source/WebCore:

Due to a different offset being used to calculate the scrollWidth/Height
and pixelSnappedClientWidth/Height the scroll value can be off by one in
same cases. This can causes scrollbars to appear even when there is no
overflow.

Test: fast/sub-pixel/block-with-margin-overflow.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
Change location offset passed to snapSizeToPixel to include x() to match
offset used by pixelSnappedClientWidth.

(WebCore::RenderBox::scrollHeight):
Change location offset passed to snapSizeToPixel to include y() to match
offset used by pixelSnappedClientHeight.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clampScrollOffset):
Change calculation to use pixelSnappedClientWidth/Height as it is
subtracted from the pixel snapped scrollWidth/Height values.

(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
Change RenderLayer versions of scrollWidth/Height to include x()/y() as
per the RenderBox versions.

LayoutTests:

Add new test ensuring that a block that shouldn't have overflow doesn't
have scrollbars.

  • fast/sub-pixel/block-with-margin-overflow-expected.html: Added.
  • fast/sub-pixel/block-with-margin-overflow.html: Added.
  • platform/chromium-win/fast/block/float/026-expected.txt:
  • platform/chromium-win/fast/block/float/028-expected.txt:
  • platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
  • platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png:
  • platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:

Update test expectations that incorrectly had overflow.

TBR=eae@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10790105

10:56 Changeset [123233] by adamk@chromium.org

CodeGeneratorInspector.py is unnecessarily chatty
https://bugs.webkit.org/show_bug.cgi?id=91758

Reviewed by Vsevolod Vlasov.

The code aded in r123091 included a "print" statement for each written
file. This makes for noisy build output, especially noticeable in the
Chromium ninja build (where build output takes up a single line of the
console).

If this print statement is generally useful, it should be
hidden behind a --verbose commandline option, as we do for the binding
generators.

  • inspector/CodeGeneratorInspector.py:

(SmartOutput.close): Remove print statement.

10:53 Changeset [123232] by tony@chromium.org

Baseline align text in the flakiness dashboard toolbar
https://bugs.webkit.org/show_bug.cgi?id=91784

Reviewed by Ojan Vafai.

Baseline align the flex items.

  • TestResultServer/static-dashboards/flakiness_dashboard.css:

(.forms): Add box-align: baseline
(.forms > *): Use block display to force flex items rather than box.
(#tests-form): Add box-align: baseline
(#tests-form > *): Use block display to force flex items rather than box.

10:50 Changeset [123231] by eae@chromium.org

Merge 122769 - Inconsistent rounding in table layout causes background color to bleed through
https://bugs.webkit.org/show_bug.cgi?id=91410

Reviewed by Eric Seidel.

Source/WebCore:

At certain zoom levels a rounding error in the table layout code cases
the table background color to bleed through between cells. Tables layout
happens on pixel bounds however the paint offset wasn't correctly rounded.

Test: fast/sub-pixel/table-rows-no-gaps.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintObject):
Round paintOffset before passing it to the paint method of the children.

LayoutTests:

Add test to ensure that the table background color doesn't bleed through
when the table and a cell are positioned on a subpixel bound.

  • fast/sub-pixel/table-rows-no-gaps-expected.html: Added.
  • fast/sub-pixel/table-rows-no-gaps.html: Added.
  • platform/chromium-linux/css1/basic/inheritance-expected.png:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:

Updated expectations to match new rounding logic. The new results better
match the rendering prior to turning on subpixel layout.

  • platform/efl/Skipped:
  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/Skipped:
  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
  • platform/win-wk2/Skipped:
  • platform/win-xp/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:

Mark new test as skipped on platforms that have not enabled subpixel
layout.

TBR=eae@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10815035

10:49 Changeset [123230] by commit-queue@webkit.org

Fix missing css1/text_properties/text_transform.html results (txt)
https://bugs.webkit.org/show_bug.cgi?id=91875

Expected txt result was added.

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-07-20
Reviewed by Noam Rosenthal.

  • platform/qt/css1/text_properties/text_transform-expected.txt: Added.
10:47 Changeset [123229] by commit-queue@webkit.org

[Qt] Added/updated missing fast/table results after rebaseline
https://bugs.webkit.org/show_bug.cgi?id=91621

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-20
Reviewed by Noam Rosenthal.

The following tests were failing after r122985:

fast/table/003.html = TEXT
fast/table/colspanMinWidth.html = TEXT
fast/table/spanOverlapRepaint.html = TEXT
fast/table/text-field-baseline.html = TEXT

This patch includes/updates the missing expectations.

  • platform/qt-5.0-wk2/fast/table/003-expected.png:
  • platform/qt-5.0-wk2/fast/table/003-expected.txt:
  • platform/qt-5.0-wk2/fast/table/colspanMinWidth-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/colspanMinWidth-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/table/spanOverlapRepaint-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt: Added.
10:35 Changeset [123228] by wsiegrist@apple.com

Port bugs.webkit.org to mod_perl for new hardware.

Reviewed by David Kilzer.

10:29 Changeset [123227] by philn@webkit.org

Unreviewed, rolling out r123220.
http://trac.webkit.org/changeset/123220
https://bugs.webkit.org/show_bug.cgi?id=91880

broke Debug build (Requested by philn on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-20

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

  • gtk/jhbuild.modules:
10:25 Changeset [123226] by zandobersek@gmail.com

Unreviewed GTK gardening, rebaselining a test after r117477.

  • platform/gtk/TestExpectations:
  • platform/gtk/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt:
10:13 Changeset [123225] by senorblanco@chromium.org

[chromium] Enable GPU-accelerated skia implementation of
feDiffuseLighting, feSpecularLighting.
https://bugs.webkit.org/show_bug.cgi?id=91865

Reviewed by Dirk Schulze.

Translate the light parameters into the appropriate
SkLightingImageFilter calls. This path is only enabled when
the filters are created with the Accelerated flag set.

This will be covered by tests in svg/filters/* when they are
added to the virtual GPU tests.

  • WebCore.gypi:
  • platform/graphics/filters/FELighting.h:

(FELighting):

  • platform/graphics/filters/skia/FELightingSkia.cpp: Added.

(WebCore):
(WebCore::FELighting::platformApplySkia):

10:09 Changeset [123224] by zandobersek@gmail.com

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, managing a few more unexpected passes for the GTK port.

Remove a few expectations for tests that were passing, reclassify some failures as
architecture-specific and add PASS expectations for a few tests that pass even though
they test features that are currently not supported on the GTK port.

  • platform/gtk/TestExpectations:
09:50 Changeset [123223] by pfeldman@chromium.org

Web Inspector: disable fake workers inspection.
https://bugs.webkit.org/show_bug.cgi?id=91867

Reviewed by Vsevolod Vlasov.

'Fake workers' is unreliable error-prone way to debug workers. There are a
lot of frameworks supporting it. Inspector should not do that since it has a more
powerful native worker inspection capabilities. Port owners should enable it
in case they want to provide workers debugging.

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::InjectedScriptHost):

  • inspector/InjectedScriptHost.h:

(InjectedScriptHost):

  • inspector/InjectedScriptHost.idl:
  • inspector/Inspector.json:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::enable):

  • inspector/InspectorAgent.h:

(WebCore):
(InspectorAgent):

  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/front-end/InjectedFakeWorker.js: Removed.
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/WorkersSidebarPane.js:

(WebInspector.WorkersSidebarPane):

  • inspector/front-end/externs.js:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:
  • workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::contextDestroyed):

  • workers/AbstractWorker.h:

(AbstractWorker):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/Worker.cpp:

(WebCore::Worker::create):

08:41 Changeset [123222] by zandobersek@gmail.com

Unreviewed GTK gardening, adding platform-specific baseline that's required
after changes in r123145.

  • platform/gtk/http/tests/security/cross-frame-access-put-expected.txt: Added.
08:33 Changeset [123221] by schenney@chromium.org

Rebaseline failing test svg/as-image/svg-non-integer-scaled-image.html

Unreviewed test expectations update.

  • platform/chromium/svg/as-image: Added.
  • platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt: Added.
08:12 Changeset [123220] by philn@webkit.org

[GTK][jhbuild] Switch to GStreamer 0.11 build
https://bugs.webkit.org/show_bug.cgi?id=91727

Reviewed by Gustavo Noronha Silva.

Switch build-webkit --gtk to GStreamer 0.11 support and build the
necessary GStreamer git modules from JHBuild.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.

  • gtk/jhbuild.modules: GStreamer build support.
07:57 Changeset [123219] by commit-queue@webkit.org

Unreviewed, rolling out r123182.
http://trac.webkit.org/changeset/123182
https://bugs.webkit.org/show_bug.cgi?id=91863

Causing ASSERT crashes in tests accessibility/canvas.html and
accessibility/canvas-accessibilitynodeobject.html (Requested
by jernoble on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-20

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • accessibility/AXObjectCache.cpp:

(WebCore):

  • accessibility/AXObjectCache.h:

(AXObjectCache):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::AccessibilityARIAGrid):
(WebCore::AccessibilityARIAGrid::~AccessibilityARIAGrid):
(WebCore):
(WebCore::AccessibilityARIAGrid::create):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::create):

  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::create):

  • accessibility/AccessibilityAllInOne.cpp:
  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::create):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::create):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::create):
(WebCore::AccessibilityMediaControlsContainer::create):
(WebCore::AccessibilityMediaTimeline::create):
(WebCore::AccessibilityMediaTimeDisplay::create):

  • accessibility/AccessibilityMenuList.cpp:
  • accessibility/AccessibilityMenuList.h:

(WebCore::AccessibilityMenuList::create):

  • accessibility/AccessibilityNodeObject.cpp: Removed.
  • accessibility/AccessibilityNodeObject.h: Removed.
  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::create):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::create):
(WebCore::AccessibilityRenderObject::detach):
(WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):
(WebCore):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
(WebCore::AccessibilityRenderObject::ariaRoleAttribute):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::canHaveChildren):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):
(WebCore::AccessibilityRenderObject::setRenderer):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::create):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::AccessibilityTable):
(WebCore::AccessibilityTable::~AccessibilityTable):
(WebCore):
(WebCore::AccessibilityTable::create):

  • accessibility/AccessibilityTable.h:

(AccessibilityTable):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::create):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::create):

LayoutTests:

  • accessibility/canvas-accessibilitynodeobject-expected.txt: Removed.
  • accessibility/canvas-accessibilitynodeobject.html: Removed.
07:39 Changeset [123218] by commit-queue@webkit.org

[EFL] Proxy configuration should honor the no_proxy environment variable
https://bugs.webkit.org/show_bug.cgi?id=91747

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-20
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Implement a custom Proxy URI Resolver for libsoup
so that we can use it in EFL port. This custom
proxy resolver brings support for setting
exceptions so that the proxy is not used for the
specified hosts.

By default, the proxy is not used for localhost and
127.0.0.1.

No new tests, no behavior change for layout tests.

  • PlatformEfl.cmake:
  • platform/network/soup/ProxyResolverSoup.cpp: Added.

(soup_proxy_resolver_wk_init):
(soupProxyResolverWkFinalize):
(soupProxyResolverWkSetProperty):
(soupProxyResolverWkGetProperty):
(shouldBypassProxy):
(idle_return_proxy_uri):
(soupProxyResolverWkGetProxyURIAsync):
(soupProxyResolverWkGetProxyURISync):
(soup_proxy_resolver_wk_class_init):
(soup_proxy_resolver_wk_interface_init):
(soupProxyResolverWkNew):

  • platform/network/soup/ProxyResolverSoup.h: Added.

Source/WebKit:

Add WebCore/platform/network/soup to INCLUDE paths.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Use the new custom proxy resolver from WebCore in
WebKit1-EFL's ewk_network_proxy_uri_set() / get(),
instead of the less flexible SOUP_SESSION_PROXY_URI
SoupSession property.

  • ewk/ewk_network.cpp:

(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):

Source/WebKit2:

Use the new custom proxy resolver from WebCore in
WebKit2-EFL so that it is possible for the client
to set proxy exceptions via the "no_proxy"
environment variable.

By default, the proxy set in the "http_proxy"
environment variable will not be used for requests
to localhost or 127.0.0.1.

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl):

Tools:

Add ProxyResolverSoup to the list of classes that contain GObjects
in style checker script so that it does not complain about naming
convention issues that are mandated by GObject.

  • Scripts/webkitpy/style/checker.py:
07:38 Changeset [123217] by schenney@chromium.org

Fix chromium TestExpectations file.

Unreviewed build fix.

  • platform/chromium/TestExpectations:
07:38 Changeset [123216] by pierre.rossi@gmail.com

[Qt][WK2] Add support for multi-select list
https://bugs.webkit.org/show_bug.cgi?id=85527

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.

Added support for multi-select list:

  • Added multi-selection flag to PlatformPopupMenuData to indicate whether to accept multiple selections or not.
  • Added selected state to WebPopupItem.
  • Modified WebPopupMenuQt to support multiple selections.
  • Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::PlatformPopupMenuData):
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):

  • Shared/PlatformPopupMenuData.h:

(PlatformPopupMenuData):

  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::WebPopupItem):
(WebKit::WebPopupItem::encode):
(WebKit::WebPopupItem::decode):

  • Shared/WebPopupItem.h:
  • UIProcess/API/qt/tests/qmltests/WebView/tst_multiSelect.qml: Added.
  • UIProcess/API/qt/tests/qmltests/common/multiselect.html: Added.
  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPopupMenuProxy.h:

(Client):

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::changeSelectedIndex):
(WebKit):
(WebKit::WebPageProxy::closePopupMenu):

  • UIProcess/qt/WebPopupMenuProxyQt.cpp:

(WebKit::PopupMenuItemModel::multiple):
(PopupMenuItemModel):
(WebKit::PopupMenuItemModel::Item::Item):
(ItemSelectorContextObject):
(WebKit::ItemSelectorContextObject::allowMultiSelect):
(WebKit::ItemSelectorContextObject::reject):
(WebKit::ItemSelectorContextObject::dismiss):
(WebKit::ItemSelectorContextObject::ItemSelectorContextObject):
(WebKit):
(WebKit::ItemSelectorContextObject::onIndexUpdate):
(WebKit::ItemSelectorContextObject::accept):
(WebKit::PopupMenuItemModel::PopupMenuItemModel):
(WebKit::PopupMenuItemModel::select):
(WebKit::PopupMenuItemModel::toggleItem):
(WebKit::PopupMenuItemModel::buildItems):
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
(WebKit::WebPopupMenuProxyQt::hidePopupMenu):
(WebKit::WebPopupMenuProxyQt::selectIndex):
(WebKit::WebPopupMenuProxyQt::createItem):

  • UIProcess/qt/WebPopupMenuProxyQt.h:

(WebPopupMenuProxyQt):

  • WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::didChangeSelectedIndex):
(WebKit::WebPopupMenu::populateItems):

  • WebProcess/WebCoreSupport/WebPopupMenu.h:

(WebPopupMenu):

  • WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didChangeSelectedIndexForActivePopupMenu):
(WebKit):
(WebKit::WebPage::changeSelectedIndex):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::selectedIndex):
(WebKit):
(WebKit::WebPage::hidePopupMenu):

07:30 Changeset [123215] by schenney@chromium.org

Rebaseline Chromium results after r121171
https://bugs.webkit.org/show_bug.cgi?id=91474

Reviewed by Dan Bernstein.

Unreviewed test expectations update.

Values have changed by one pixel, which is expected given the description in the bug report.

  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/as-image/svg-non-integer-scaled-image-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium/svg/as-image: Removed.
  • platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
07:23 Changeset [123214] by pierre.rossi@gmail.com

ColorChooserClient should expose the element's location
https://bugs.webkit.org/show_bug.cgi?id=91767

Reviewed by Kent Tamura.

The rationale is that the chrome client could have an interest in placing the picker next to
the element for usability reasons.

No new tests as there is not much logic here: Just exposing a geometry information to WebKit.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::elementRectRelativeToWindow):
(WebCore):

  • html/ColorInputType.h:

(ColorInputType):

  • platform/ColorChooserClient.h:

(ColorChooserClient):

07:11 Changeset [123213] by commit-queue@webkit.org

[EFL] Fix build when protocol handler and custom scheme is disabled
https://bugs.webkit.org/show_bug.cgi?id=91840

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-20
Reviewed by Kenneth Rohde Christiansen.

Fixed namespace closing bracket positioning.

  • WebCoreSupport/RegisterProtocolHandlerClientEfl.cpp:

(WebCore):

07:05 Changeset [123212] by commit-queue@webkit.org

[WK2] WebIntents doesn't build if mutation observers is disabled
https://bugs.webkit.org/show_bug.cgi?id=91839

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-20
Reviewed by Kenneth Rohde Christiansen.

WebIntents was depending on a code protected by ENABLE(MUTATION_OBSERVERS).
Now the code is also enabled by ENABLE(WEB_INTENTS).

  • bindings/js/JSDictionary.cpp:

(WebCore):

  • bindings/js/JSDictionary.h:
06:59 Changeset [123211] by mihnea@adobe.com

[CSSRegions]Assert failure when layout positioned objects in regions
https://bugs.webkit.org/show_bug.cgi?id=90792

Reviewed by Andreas Kling.

Before clamping the containing block (for an out-of-flow positioned element
inside a named flow) to the region, we have to test whether the region is not
null, which can happen when the named flow does not have attached regions.

Source/WebCore:

Tests: fast/regions/positioned-vrl-in-named-flow.html

fast/regions/positioned-vrl-in-parent-named-flow.html
fast/regions/positioned-with-vrl-parent-in-named-flow.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):

LayoutTests:

  • fast/regions/positioned-vrl-in-named-flow-expected.txt: Added.
  • fast/regions/positioned-vrl-in-named-flow.html: Added.
  • fast/regions/positioned-vrl-in-parent-named-flow-expected.txt: Added.
  • fast/regions/positioned-vrl-in-parent-named-flow.html: Added.
  • fast/regions/positioned-with-vrl-parent-in-named-flow-expected.txt: Added.
  • fast/regions/positioned-with-vrl-parent-in-named-flow.html: Added.
06:55 Changeset [123210] by schenney@chromium.org

SVG Filter Effect sub-region not applied for some filters
https://bugs.webkit.org/show_bug.cgi?id=89767

Reviewed by Dirk Schulze.

Source/WebCore:

The filter effect region for SVG feGaussian and feDropShadow filters
was incorrectly set, failing to account for the radius of the blur.
This patch fixes the problem and removes an unneccessary clip
operation when the filter result is blitted into the target. That clip
was clipping the shadow from webkit-shadow.

Tests: svg/filters/feDropShadow-subregion.svg

svg/filters/feGaussianBlur-subregion.svg

  • platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::determineAbsolutePaintRect): Moved the code
that clips the paint rect by the filter effect subregion to come after
the paint is modified by the filter radius.

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::determineAbsolutePaintRect):
Moved the code that clips the paint rect by the filter effect subregion to
come after the paint is modified by the filter radius.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):
Removed a clip that is unnecessary and that was incorrectly clipping drop shadows.

LayoutTests:

The filter effect region for SVG feGaussian and feDropShadow filters was incorrectly set,
failing to account for the radius of the blur. This patch fixes the problem and removes an
unneccessary clip operation when the filter result is blitted into the target. That clip
was clipping the shadow from webkit-shadow.

  • platform/chromium/TestExpectations: Added temp entries for affected

tests. Will rebaseline later (not closing the bug in the meantime).

  • svg/filters/feDropShadow-subregion-expected.png: Added.
  • svg/filters/feDropShadow-subregion-expected.txt: Added.
  • svg/filters/feDropShadow-subregion.svg: This verifies the subregion for feDropShadow.
  • svg/filters/feGaussianBlur-subregion-expected.png: Added.
  • svg/filters/feGaussianBlur-subregion-expected.txt: Added.
  • svg/filters/feGaussianBlur-subregion.svg: This verifies the subregion for feGaussianBlur.
06:41 Changeset [123209] by mihnea@adobe.com

Unreviewed. Skip regions inspector test on EFL.

06:26 Changeset [123208] by zeno.albisser@nokia.com

[Qt][WK2] Add configure tests for Xrender and GLX.
https://bugs.webkit.org/show_bug.cgi?id=91845

GraphicsSurface on linux requires Xcomposite, Xrender
and GLX. If any of these requirements is not met,
we should disable GraphicsSurface.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/config.tests/glx/glx.cpp: Added.

(main):

  • qmake/config.tests/glx/glx.pro: Added.
  • qmake/config.tests/libXrender/libXrender.cpp: Added.

(main):

  • qmake/config.tests/libXrender/libXrender.pro: Added.
  • qmake/configure.pri:
  • qmake/mkspecs/features/features.prf:
06:07 Changeset [123207] by pfeldman@chromium.org

Web Inspector: Status bar icons are misaligned by 1px to the right
https://bugs.webkit.org/show_bug.cgi?id=91757

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/inspector.css:

(.glyph):
(.glyph.shadow):

05:50 Changeset [123206] by kkristof@inf.u-szeged.hu

[Qt] http/tests/security/cross-frame-access-put.html test fail after r123145
https://bugs.webkit.org/show_bug.cgi?id=91830

Unreviewed gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-20

  • platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Added.
05:34 Changeset [123205] by commit-queue@webkit.org

Web Inspector: Protocol Extension: add getNamedFlowCollection command
https://bugs.webkit.org/show_bug.cgi?id=91607

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-07-20
Reviewed by Pavel Feldman.

Source/WebCore:

Extended the protocol with "getNamedFlowCollection" command.
This command returns the CSS Named Flows from the document.

Test: inspector/styles/protocol-getNamedFlowCollection-command.html

  • dom/WebKitNamedFlowCollection.cpp:

(WebCore::WebKitNamedFlowCollection::namedFlowsNames):
(WebCore):

  • dom/WebKitNamedFlowCollection.h:

(WebKitNamedFlowCollection):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::assertDocument):
(WebCore):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):

LayoutTests:

The test builds a webpage with 3 Named Flows in the main frame and 1 Named Flow in an iframe.
Because the getNamedFlowCollection command is executed with the main document node id as an argument,
it should return only the first 3 Named Flows.

  • inspector/styles/protocol-getNamedFlowCollection-command-expected.txt: Added.
  • inspector/styles/protocol-getNamedFlowCollection-command.html: Added.
05:29 Changeset [123204] by commit-queue@webkit.org

[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=91838

Unreviewed EFL gardening. Add failing tests to the Test Expectations.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-20

  • platform/efl/TestExpectations:
  • platform/efl/fast/forms/state-restore-skip-stateless-expected.txt: Removed

the platform specific expected after r123066.

04:31 Changeset [123203] by commit-queue@webkit.org

[EFL][WK2][WTR] Implement EventSenderProxy
https://bugs.webkit.org/show_bug.cgi?id=91731

Patch by Kangil Han <kangil.han@samsung.com> on 2012-07-20
Reviewed by Kentaro Hara.

This is an initial EFL port implementation of EventSenderProxy.

  • WebKitTestRunner/EventSenderProxy.h:

(WTR):
(EventSenderProxy):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:
  • WebKitTestRunner/PlatformEfl.cmake:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added.

(WTR):
(WTREvent):
(WTR::WTREvent::WTREvent):
(WTR::KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(WTR::evasMouseButton):
(WTR::setEvasModifiers):
(WTR::dispatchMouseDownEvent):
(WTR::dispatchMouseUpEvent):
(WTR::dispatchMouseMoveEvent):
(WTR::dispatchMouseScrollByEvent):
(WTR::keyPadName):
(WTR::keyName):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::dispatchEvent):
(WTR::EventSenderProxy::replaySavedEvents):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::touchCancel):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::cancelTouchPoint):
(WTR::EventSenderProxy::setTouchPointRadius):

04:26 Changeset [123202] by commit-queue@webkit.org

[EFL] Check parameters of ewk APIs in ewk_security_origin
https://bugs.webkit.org/show_bug.cgi?id=91833

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-20
Reviewed by Kentaro Hara.

For preventing crash, check parameters of ewk APIs in the ewk_security_origin.cpp.

  • ewk/ewk_security_origin.cpp:

(ewk_security_origin_port_get):
(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):
(ewk_security_origin_web_database_quota_set):
(ewk_security_origin_application_cache_quota_set):
(ewk_security_origin_application_cache_clear):
(ewk_security_origin_web_database_get_all):
(ewk_security_origin_free):

  • ewk/ewk_security_origin.h:
04:25 Changeset [123201] by kkristof@inf.u-szeged.hu

[Qt] Unreviewed gardening after r123192. Skipped a new test.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-20

  • platform/qt/Skipped:
03:28 Changeset [123200] by gyuyoung.kim@samsung.com

Unreviewed, rolling out r123085.
http://trac.webkit.org/changeset/123085
https://bugs.webkit.org/show_bug.cgi?id=91719

r123085 causes crashes on EFL layout test bot.

Source/WebKit2:

  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::applicationCacheDirectory):

Tools:

  • WebKitTestRunner/CMakeLists.txt:
  • WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp:

(WTR::LayoutTestController::platformInitialize):

03:17 Changeset [123199] by commit-queue@webkit.org

[EFL][WK2] Use "load,finished" signal in EWK2UnitTestBase::loadUrlSync() instead of "load,progress"
https://bugs.webkit.org/show_bug.cgi?id=91721

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-20
Reviewed by Kenneth Rohde Christiansen.

The purpose of EWK2UnitTestBase::loadUrlSync() is to load
a URL in the view and wait synchronously for the load to finish.
The current implementation uses the "load,progress" signal to
detect when the load is finished, which is inefficient because
it gets emitted several times.

It is better to wait for the "load,finished" signal which gets
emitted only once when the load is complete.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::onLoadFinished):
(EWK2UnitTest::EWK2UnitTestBase::EWK2UnitTestBase):
(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTestBase):

02:41 Changeset [123198] by commit-queue@webkit.org

Web Inspector: Timeline: forward compatibility for load.
https://bugs.webkit.org/show_bug.cgi?id=91714

Patch by Eugene Klyuchnikov <eustas.big@gmail.com> on 2012-07-20
Reviewed by Pavel Feldman.

Accept records of unrecognized types and render them as "unknown".

Source/WebCore:

Test: inspector/timeline/timeline-load-incompatible.html

  • English.lproj/localizedStrings.js: Added UI string.
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.recordStyle): Add missing record
styles at runtime.
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
Add some common information for default case.

LayoutTests:

  • inspector/timeline/timeline-load-incompatible-expected.txt: Added.
  • inspector/timeline/timeline-load-incompatible.html: Added.
02:30 Changeset [123197] by morrita@google.com

Another unreviewed Mac build fix against r123184.

  • WebCore.exp.in:
02:23 Changeset [123196] by mihnea@adobe.com

[CSSRegions]Crash when flowing a region into itself
https://bugs.webkit.org/show_bug.cgi?id=90289

Reviewed by Andreas Kling.

If a region is designed to receive itself as content through a named flow, we avoid
a circular dependency by not attaching the region to the desired named flow.
In such occasions, the region's attached flow thread object is null and
we have to check this pointer before using it in RenderRegion::styleDidChange.

Source/WebCore:

Test: fast/regions/flow-region-into-itself-crash.html

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::styleDidChange):

LayoutTests:

  • fast/regions/flow-region-into-itself-crash-expected.txt: Added.
  • fast/regions/flow-region-into-itself-crash.html: Added.
02:13 Changeset [123195] by morrita@google.com

Unreviewed Mac build fix against r123184.

  • WebCore.exp.in:
01:41 Changeset [123194] by kinuko@chromium.org

If value for responseType defined as type that not supported, it should not throw an exception in XHR 2
https://bugs.webkit.org/show_bug.cgi?id=90976

Reviewed by Alexey Proskuryakov.

Source/WebCore:

http://www.w3.org/TR/XMLHttpRequest2/#the-responsetype-attribute
The spec does not say it should throw an exception when a non-supported
type is set, and other browsers do not throw it either.

Test: fast/xmlhttprequest/xmlhttprequest-responsetype-set-type.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setResponseType): Stop throwing an exception when non-supported type is given.

LayoutTests:

Adding tests to see if setting invalid responseType does not throw an exception and does not change the value.

  • fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html: Removed a line which tries to set invalid type (since we now have a separate test)
01:28 Changeset [123193] by commit-queue@webkit.org

Show or hide <dialog> depending on the open attribute
https://bugs.webkit.org/show_bug.cgi?id=90931

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-07-20
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/dom/HTMLDialogElement/dialog-open.html

(dialog:not([open])):
(dialog):

  • html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::close): Set open to false, to hide the dialog.
(WebCore::HTMLDialogElement::show): Set open to true, to show the dialog.
(WebCore):
(WebCore::HTMLDialogElement::isPresentationAttribute): Make openAttr a presentation attribute, to work around bug 91058

  • html/HTMLDialogElement.h:

(HTMLDialogElement):

  • html/HTMLDialogElement.idl:

LayoutTests:

  • fast/dom/HTMLDialogElement/dialog-open-expected.txt: Added.
  • fast/dom/HTMLDialogElement/dialog-open.html: Added.
01:06 Changeset [123192] by shinyak@chromium.org

Needs pseudo id to point the inner element of an img elemnet for styling
https://bugs.webkit.org/show_bug.cgi?id=91590

Reviewed by Hajime Morita.

Source/WebCore:

We introduce pseudo id to point the element in UserAgentShadowDOM.
This enables us to style the inner element of an img element shadow.
Please see also http://trac.webkit.org/wiki/ShadowDOMForReplacedElements

Test: fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html

  • html/shadow/ImageInnerElement.cpp:

(WebCore::ImageInnerElement::shadowPseudoId):
(WebCore):

  • html/shadow/ImageInnerElement.h:

(ImageInnerElement):

LayoutTests:

Uses pseudo id to confirm the style is applied to the inner element of an img element shadow.

  • fast/dom/shadow/shadowdom-for-image-with-pseudo-id-expected.html: Added.
  • fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html: Added.
01:03 Changeset [123191] by tkent@chromium.org

REGRESSION(r121420): Performance regression of form state saving for pages with multiple forms
https://bugs.webkit.org/show_bug.cgi?id=91804

Reviewed by Hajime Morita.

The complexity of FormKeyGenerator::formKey() was O(N) where N is the
number of form elements with an identical action URL, and formKey() is
called for every form. So, it's O(N2). A page in www.reddit.com
contains hundreds of form elements with action="#". So FormController::
formElementsState() took a few seconds on a slow machine.

In order to avoid O(N2) operation, storing a map from form signatures
to next index numbers, instead of storing existing formKey strings.

No new tests. Just a performance improvement.

  • html/FormController.cpp:

(FormKeyGenerator): Remove m_existingKeys. Add a map from a form
signature string to the next index number.
(WebCore::formSignature): Returns a signature string for a form, without
an index number. This is like "actionURL [name1 name2 ]"
(WebCore::FormKeyGenerator::formKey):
Creates a formKey string by concatenating a formSignature and #n. N is
obtained from m_formSignatureToNextIndexMap in O(1).
(WebCore::FormKeyGenerator::willDeleteForm):
Remove the code for m_existingKeys.

00:56 Changeset [123190] by yosin@chromium.org

Unreviewed. Set svn:mime-type to image/png for PNG files without svn:mime-type.

  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png: Added property svn:mime-type.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added property svn:mime-type.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added property svn:mime-type.
00:48 Changeset [123189] by gyuyoung.kim@samsung.com

[WTR] Add *explicit* keyword to constructor which has a parameter
https://bugs.webkit.org/show_bug.cgi?id=91745

Reviewed by Adam Barth.

Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.

  • WebKitTestRunner/EventSenderProxy.h:

(EventSenderProxy):

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation):

00:46 Changeset [123188] by keishi@webkit.org

Fix crash in WebCore::HTMLInputElement::dataList
https://bugs.webkit.org/show_bug.cgi?id=91818

Reviewed by Kent Tamura.

Source/WebCore:

Fix crash that occurs when setting slider appearance on a regular node.

Test: fast/forms/range/slider-appearance-crash.html

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintSliderTicks): Check if node is an input element.

LayoutTests:

  • fast/forms/range/slider-appearance-crash-expected.txt: Added.
  • fast/forms/range/slider-appearance-crash.html: Added.
00:42 Changeset [123187] by tkent@chromium.org

[Chromium] Fix an assertion failure in TextFieldDecorationElement::hostInput()
https://bugs.webkit.org/show_bug.cgi?id=91824

Reviewed by Hajime Morita.

No new tests. This code is used only in Chromium browser.

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::hostInput):
Use shadowHost(), and allow to return 0.
(WebCore::TextFieldDecorationElement::defaultEventHandler):
Check 0.

00:36 Changeset [123186] by yosin@chromium.org

Unreviewed. Set svn:mime-type to image/png for PNG files without svn:mime-type.

  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-number-rtl-expected.png: Added property svn:mime-type.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added property svn:mime-type.
  • platform/qt-5.0-wk2/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added property svn:mime-type.
00:02 WikiStart edited by shinyak@chromium.org
(diff)
00:01 ShadowDOMForReplacedElements created by shinyak@chromium.org
Note: See TracTimeline for information about the timeline view.