Timeline
07/31/12:
- 23:23 Changeset [124305] by
-
[Chromium] Add a baseline and modify expectations.
https://bugs.webkit.org/show_bug.cgi?id=66417
https://bugs.webkit.org/show_bug.cgi?id=81145
https://bugs.webkit.org/show_bug.cgi?id=82547
https://bugs.webkit.org/show_bug.cgi?id=84802
Unreviewed, test expectation updates.
One baseline was ommitted from http://trac.webkit.org/changeset/124296 .
- platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.txt: Added.
- platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.txt: Added.
- platform/chromium/TestExpectations:
- 23:11 Changeset [124304] by
-
Internals::setAuthorShadowDOMForAnyElementEnabled should be on InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=92823
Reviewed by Kentaro Hara.
Source/WebCore:
This change moves Internals::setAuthorShadowDOMForAnyElementEnabled() to
InternalSettings to support original value recovery.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setAuthorShadowDOMForAnyElementEnabled): Moved from Internals.
(WebCore):
- testing/InternalSettings.h:
(Backup):
(InternalSettings):
- testing/InternalSettings.idl:
- testing/Internals.cpp:
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
Followed the changed on Internals API.
- fast/dom/shadow/input-with-validation.html:
- 23:05 Changeset [124303] by
-
Mark fast/forms/color/color-suggestion-picker-appearance.html as missing or image mismatch
Unreviewed.
- platform/chromium/TestExpectations:
- 22:17 Changeset [124302] by
-
Layout Test media/video-currentTime-set.html is still flaky
https://bugs.webkit.org/show_bug.cgi?id=85003
Unreviewed gardening; test was fixed in r115462 but expectation was left behind.
- platform/chromium/TestExpectations:
- 22:10 Changeset [124301] by
-
webkitRequestPointerLock and webkitExitPointerLock limited to the same document of an active Pointer lock.
https://bugs.webkit.org/show_bug.cgi?id=91284
Reviewed by Adrienne Walker.
Previously, cross-talk between documents was possible, e.g. allowing one
document.webkitExitPointerLock to exit the lock from another document.
This change brings Pointer Lock closer to the Fullscreen API behavior,
and stops the pointer lock target from being transferable between
documents.
Source/WebCore:
Test: http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents.html
- dom/Document.cpp:
(WebCore::Document::webkitExitPointerLock):
- page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
LayoutTests:
- http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents-expected.txt: Added.
- http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents.html: Added.
- http/tests/resources/pointer-lock/iframe-common.js:
(document.onwebkitpointerlockchange):
(document.onwebkitpointerlockerror):
- pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
- pointer-lock/pointerlockchange-pointerlockerror-events.html:
- 22:07 Changeset [124300] by
-
[Chromium][Mac] Assertion failure in null_audio_sink.cc running WebGL video layout test on 10.5 debug bots
https://bugs.webkit.org/show_bug.cgi?id=89529
Unreviewed gardening.
Should be mostly/all cured on Mac. See http://crbug.com/138583 for ongoing details.
- platform/chromium/TestExpectations:
- 22:02 Changeset [124299] by
-
ColorInputType::typeMismatchFor is returning the opposite bool
https://bugs.webkit.org/show_bug.cgi?id=92836
Reviewed by Kent Tamura.
No new tests. Covered by color-suggestion-picker-appearance.html.
- html/ColorInputType.cpp:
(WebCore::ColorInputType::typeMismatchFor):
- 21:57 Changeset [124298] by
-
[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=85952
https://bugs.webkit.org/show_bug.cgi?id=92835
Unreviewed, test expectation updates.
- platform/chromium/TestExpectations:
- 21:48 Changeset [124297] by
-
-webkit-flex-flow does not work with inherit/initial values
https://bugs.webkit.org/show_bug.cgi?id=92709
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-31
Reviewed by Ojan Vafai.
Source/WebCore:
Add a new handler for flex-flow and move flex to StyleBuilder to mirror the standard pattern for handling initial/inherit in shorthands.
Test: css3/flexbox/flex-flow-initial.html
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder): Added handlers for flex and flex-flow.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Removed hand written logic for handling flex.
LayoutTests:
Test that flex-flow handles 'initial' as expected.
- css3/flexbox/flex-flow-initial-expected.txt: Added.
- css3/flexbox/flex-flow-initial.html: Added.
- 21:14 Changeset [124296] by
-
[Chromium] Rebaselines and test expectation updates.
https://bugs.webkit.org/show_bug.cgi?id=66953
https://bugs.webkit.org/show_bug.cgi?id=72746
https://bugs.webkit.org/show_bug.cgi?id=74157
https://bugs.webkit.org/show_bug.cgi?id=81145
https://bugs.webkit.org/show_bug.cgi?id=83051
Unreviewed, test expectation updates.
Mostly rebaselining for https://bugs.webkit.org/show_bug.cgi?id=72746 .
- platform/chromium-linux-x86/fast/writing-mode: Added.
- platform/chromium-linux-x86/fast/writing-mode/english-lr-text-expected.png: Added.
- platform/chromium-linux-x86/transitions: Added.
- platform/chromium-linux-x86/transitions/default-timing-function-expected.png: Added.
- platform/chromium-linux-x86/transitions/svg-text-shadow-transition-expected.png: Added.
- platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
- platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
- platform/chromium-linux/fast/repaint/text-shadow-expected.png:
- platform/chromium-linux/fast/repaint/text-shadow-horizontal-expected.png:
- platform/chromium-linux/fast/text/shadow-no-blur-expected.png:
- platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
- platform/chromium-linux/fast/text/stroking-decorations-expected.png:
- platform/chromium-linux/fast/text/stroking-expected.png:
- platform/chromium-linux/fast/writing-mode/english-lr-text-expected.png:
- platform/chromium-linux/transitions/default-timing-function-expected.png:
- platform/chromium-linux/transitions/svg-text-shadow-transition-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/text-shadow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/text-shadow-horizontal-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/text/shadow-no-blur-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/text/shadow-translucent-fill-expected.png:
- platform/chromium-mac-snowleopard/fast/text/stroking-expected.png: Removed.
- platform/chromium-mac-snowleopard/transitions/cross-fade-border-image-expected.png:
- platform/chromium-mac-snowleopard/transitions/default-timing-function-expected.png: Added.
- platform/chromium-mac-snowleopard/transitions/svg-text-shadow-transition-expected.png: Added.
- platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png: Added.
- platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
- platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
- platform/chromium-mac/fast/repaint/text-shadow-expected.png:
- platform/chromium-mac/fast/repaint/text-shadow-horizontal-expected.png:
- platform/chromium-mac/fast/text/shadow-no-blur-expected.png:
- platform/chromium-mac/fast/text/stroking-decorations-expected.png:
- platform/chromium-mac/fast/writing-mode/english-lr-text-expected.png:
- platform/chromium-mac/transitions/default-timing-function-expected.png:
- platform/chromium-mac/transitions/svg-text-shadow-transition-expected.png:
- platform/chromium-win-xp/fast/text/shadow-translucent-fill-expected.png:
- platform/chromium-win-xp/fast/text/stroking-decorations-expected.png: Added.
- platform/chromium-win-xp/fast/text/stroking-expected.png: Added.
- platform/chromium-win-xp/fast/writing-mode/english-lr-text-expected.png: Added.
- platform/chromium-win-xp/transitions/svg-text-shadow-transition-expected.png:
- platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
- platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
- platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
- platform/chromium-win/fast/text/stroking-decorations-expected.png:
- platform/chromium-win/fast/text/stroking-expected.png:
- platform/chromium-win/fast/writing-mode/english-lr-text-expected.png:
- platform/chromium-win/transitions/default-timing-function-expected.png:
- platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
- platform/chromium/TestExpectations:
- 21:03 Changeset [124295] by
-
Float imprecision causes incorrect wrapping in LineLayout with subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=92778
Reviewed by Eric Seidel.
Source/WebCore:
Due to float imprecision an incorrect wrapping decision is made in
certain cases where the values being compare are close but not exactly
the same. This can happen as the size of blocks is represented in layout
units while line layout uses floats.
Test: fast/sub-pixel/inline-block-should-not-wrap.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::fitsOnLine):
Use LayoutUnit::epsilon when comparing values as that is the maximum
precision we support.
LayoutTests:
Add test ensuring that an inline block isn't wrapped incorrectly.
- fast/sub-pixel/inline-block-should-not-wrap-expected.html: Added.
- fast/sub-pixel/inline-block-should-not-wrap.html: Added.
- platform/mac-lion/Skipped:
- platform/mac-snowleopard/Skipped:
- platform/mac-wk2/Skipped:
- platform/mac/Skipped:
- platform/qt-4.8/Skipped:
- platform/qt/Skipped:
- platform/win-wk2/Skipped:
- platform/win-xp/Skipped:
- platform/win/Skipped:
- platform/wincairo/Skipped:
- platform/wk2/Skipped:
- 20:56 Changeset [124294] by
-
Unreviewed EFL gardening.
Marked the following tests as pass, but they don't pass on 32-bits machines.
sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.16_sin/S15.8.2.16_A7.html
sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.18_tan/S15.8.2.18_A7.html
svg/css/stars-with-shadow.html
- platform/efl/TestExpectations:
- 20:50 Changeset [124293] by
-
Layout tests media/event-attributes.html and media/video-playbackrate.html failing
https://bugs.webkit.org/show_bug.cgi?id=73692
Unreviewed gardening.
Should be mostly/all cured. See http://crbug.com/138583 for ongoing details.
- platform/chromium/TestExpectations:
- 20:42 Changeset [124292] by
-
media/video-currentTime-delay.html shouldn't be a performance test, so remove artificial deadline.
https://bugs.webkit.org/show_bug.cgi?id=92816
Unreviewed test cleanup.
- media/video-currentTime-delay.html:
- platform/chromium/TestExpectations:
- 20:41 Changeset [124291] by
-
Refactor EventDispatcher::dispatchEvent() so that we can call each phase (Caputure, Target and Bubbling) of event dispatching separately.
https://bugs.webkit.org/show_bug.cgi?id=92621
Reviewed by Dimitri Glazkov.
This is one of the required refactorings to support event
propagation for seamless iframes. I've removed 'goto' statements
from EventDispatcher::dispatchEvent() as a result.
I've verified that all separated functions are successfully
inlined. I could not see any performance regression. The
benchmark result is:
Before this patch:
% ./Tools/Scripts/run-perf-tests PerformanceTests/DOM/Events.html
Running 1 tests
Running DOM/Events.html (1 of 1)
RESULT DOM: Events= 243.986607143 ms
median= 242.297619048 ms, stdev= 5.74748351315 ms, min= 239.80952381 ms, max= 268.0 ms
After this patch:
% ./Tools/Scripts/run-perf-tests PerformanceTests/DOM/Events.html
Running 1 tests
Running DOM/Events.html (1 of 1)
RESULT DOM: Events= 242.291666667 ms
median= 240.452380952 ms, stdev= 5.8718643632 ms, min= 238.214285714 ms, max= 266.5 ms
No new tests, no behavior change.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchEventPreProcess):
(WebCore):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
(WebCore::EventDispatcher::topEventContext):
- dom/EventDispatcher.h:
(WebCore):
(EventDispatcher):
- 20:29 Changeset [124290] by
-
[Chromium] Enable ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
https://bugs.webkit.org/show_bug.cgi?id=92822
Reviewed by Kent Tamura.
Source/WebCore:
This patch touches header files for compiling files which contains
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
No new tests. This patch doesn't change behavior.
- platform/text/DateTimeFormat.h:
- platform/text/LocaleICU.h:
- platform/text/LocaleWin.h:
- platform/text/LocalizedDate.h:
- platform/text/LocalizedNumber.h:
- platform/text/mac/LocaleMac.h:
Source/WebKit/chromium:
This patch enables ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS for Chromium
port except for Android.
- features.gypi: Add ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS=1 to "feature_defines"
block of OS != "android".
- 20:22 Changeset [124289] by
-
[Chromium] Rebaseline a test and correct two expectations
http://crbug.com/23477
Unreviewed, test expectation updates.
One line was extraneous after http://trac.webkit.org/changeset/124245 ,
another after http://trac.webkit.org/changeset/124284 .
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
- platform/chromium/TestExpectations:
- 19:55 Changeset [124288] by
-
[chromium]Upstream WebViewImpl:StartPageScaleAnimation changes for Chrome for Android
https://bugs.webkit.org/show_bug.cgi?id=92698
Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-07-31
Reviewed by Adam Barth.
Enforce the maximum and minimum scroll positions after the scale has changed.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::startPageScaleAnimation):
- src/WebViewImpl.h:
(WebViewImpl):
- 19:49 Changeset [124287] by
-
i and j keys no longer scroll in results.html
https://bugs.webkit.org/show_bug.cgi?id=92584
Reviewed by Tony Chang.
Scrolling broke with r122880 since the scrolling element is no
longer the body.
Also, fix TestNavigator to allow navigating to tests in the
unexpected passes table. That table doesn't have expand links,
so we change TestNavigator to navigate the tbody's instead, which
also happens to remove a bunch of unnecessary tree-walking.
- fast/harness/resources/results-test.js:
- fast/harness/results-expected.txt:
- fast/harness/results.html:
- 19:43 Changeset [124286] by
-
[Chromium] Layout Test http/tests/media/media-source/webm/video-media-source-*.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=85952
Unreviewed test cleanup.
Timeouts were fixed by acolwell@chromium.org a few weeks ago. Flakiness of seeked vs. the other events is just overspecificity in the test.
- http/tests/media/media-source/video-media-source-seek-expected.txt:
- http/tests/media/media-source/video-media-source-seek.html:
- platform/chromium/TestExpectations:
- 19:39 Changeset [124285] by
-
[BlackBerry] Pass all file chooser settings to clients
https://bugs.webkit.org/show_bug.cgi?id=92237
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-07-31
Reviewed by Rob Buis.
Expose all file chooser settings to clients.
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::runOpenPanel):
- 19:28 Changeset [124284] by
-
[Chromium] Miscellaneous rebaselining.
https://bugs.webkit.org/show_bug.cgi?id=78664
https://bugs.webkit.org/show_bug.cgi?id=82129
https://bugs.webkit.org/show_bug.cgi?id=82547
https://bugs.webkit.org/show_bug.cgi?id=84065
https://bugs.webkit.org/show_bug.cgi?id=84800
https://bugs.webkit.org/show_bug.cgi?id=86592
https://bugs.webkit.org/show_bug.cgi?id=88171
https://bugs.webkit.org/show_bug.cgi?id=88705
https://bugs.webkit.org/show_bug.cgi?id=89045
https://bugs.webkit.org/show_bug.cgi?id=89936
https://bugs.webkit.org/show_bug.cgi?id=90951
https://bugs.webkit.org/show_bug.cgi?id=91811
https://bugs.webkit.org/show_bug.cgi?id=92444
https://bugs.webkit.org/show_bug.cgi?id=92537
https://bugs.webkit.org/show_bug.cgi?id=92721
https://bugs.webkit.org/show_bug.cgi?id=92811
http://crbug.com/128325
Unreviewed, test expectation updates.
- platform/chromium-linux-x86/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/custom: Added.
- platform/chromium-linux-x86/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/custom/effect-color-check-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-expected.png: Added.
- platform/chromium-linux-x86/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
- platform/chromium-linux-x86/fast/css/text-overflow-ellipsis-text-align-center-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/text-overflow-ellipsis-text-align-left-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/text-overflow-ellipsis-text-align-right-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt: Added.
- platform/chromium-linux-x86/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt: Added.
- platform/chromium-linux-x86/fast/text/shaping: Added.
- platform/chromium-linux-x86/fast/text/shaping/shaping-script-order-expected.png: Added.
- platform/chromium-linux-x86/fast/text/shaping/shaping-script-order-expected.txt: Added.
- platform/chromium-linux-x86/fast/text/shaping/shaping-selection-rect-expected.png: Added.
- platform/chromium-linux-x86/fast/text/shaping/shaping-selection-rect-expected.txt: Added.
- platform/chromium-linux-x86/media: Removed.
- platform/chromium-linux/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-linux/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
- platform/chromium-linux/css3/filters/custom/effect-color-check-expected.png: Added.
- platform/chromium-linux/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
- platform/chromium-linux/css3/filters/custom/filter-repaint-custom-expected.png: Added.
- platform/chromium-linux/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
- platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
- platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-center-expected.txt: Added.
- platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-justify-expected.png: Added.
- platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt: Added.
- platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-left-expected.png: Added.
- platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-left-expected.txt: Added.
- platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-right-expected.png: Added.
- platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-right-expected.txt: Added.
- platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
- platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
- platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png: Added.
- platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt: Added.
- platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png: Added.
- platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt: Added.
- platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png: Added.
- platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt: Added.
- platform/chromium-linux/fast/text/shaping: Added.
- platform/chromium-linux/fast/text/shaping/shaping-script-order-expected.png: Added.
- platform/chromium-linux/fast/text/shaping/shaping-script-order-expected.txt: Added.
- platform/chromium-linux/fast/text/shaping/shaping-selection-rect-expected.png: Added.
- platform/chromium-linux/fast/text/shaping/shaping-selection-rect-expected.txt: Added.
- platform/chromium-linux/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-mac-snowleopard/css3/filters/custom: Added.
- platform/chromium-mac-snowleopard/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/lineboxcontain/glyphs-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-center-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-justify-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-left-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-left-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-right-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-text-align-right-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
- platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/text/shaping: Added.
- platform/chromium-mac-snowleopard/fast/text/shaping/shaping-script-order-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/text/shaping/shaping-script-order-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/shaping/shaping-selection-rect-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/text/shaping/shaping-selection-rect-expected.txt: Added.
- platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-mac/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
- platform/chromium-mac/fast/block/lineboxcontain/glyphs-expected.txt:
- platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
- platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt: Added.
- platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.png: Added.
- platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt: Added.
- platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-left-expected.png: Added.
- platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt: Added.
- platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-right-expected.png: Added.
- platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt: Added.
- platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
- platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
- platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png: Added.
- platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt: Added.
- platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png: Added.
- platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt: Added.
- platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png: Added.
- platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt: Added.
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
- platform/chromium-mac/fast/text/shaping: Added.
- platform/chromium-mac/fast/text/shaping/shaping-script-order-expected.png: Added.
- platform/chromium-mac/fast/text/shaping/shaping-script-order-expected.txt: Added.
- platform/chromium-mac/fast/text/shaping/shaping-selection-rect-expected.png: Added.
- platform/chromium-mac/fast/text/shaping/shaping-selection-rect-expected.txt: Added.
- platform/chromium-mac/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
- platform/chromium-win-xp/compositing/reflections: Added.
- platform/chromium-win-xp/compositing/reflections/nested-reflection-anchor-point-expected.png: Added.
- platform/chromium-win-xp/compositing/shadows: Added.
- platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png: Added.
- platform/chromium-win-xp/css1/formatting_model: Added.
- platform/chromium-win-xp/css1/formatting_model/floating_elements-expected.png: Added.
- platform/chromium-win-xp/css3/filters/custom: Added.
- platform/chromium-win-xp/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
- platform/chromium-win-xp/css3/filters/custom/effect-color-check-expected.png: Added.
- platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
- platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-expected.png: Added.
- platform/chromium-win-xp/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
- platform/chromium-win-xp/fast/css/text-overflow-ellipsis-text-align-center-expected.txt: Added.
- platform/chromium-win-xp/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt: Added.
- platform/chromium-win-xp/fast/css/text-overflow-ellipsis-text-align-left-expected.txt: Added.
- platform/chromium-win-xp/fast/css/text-overflow-ellipsis-text-align-right-expected.txt: Added.
- platform/chromium-win-xp/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
- platform/chromium-win-xp/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt: Added.
- platform/chromium-win-xp/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt: Added.
- platform/chromium-win-xp/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt: Added.
- platform/chromium-win-xp/fast/forms/datalist: Added.
- platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
- platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
- platform/chromium-win-xp/fast/speech/input-appearance-searchandspeech-expected.png: Removed.
- platform/chromium-win-xp/fast/text/shaping: Added.
- platform/chromium-win-xp/fast/text/shaping/shaping-script-order-expected.png: Added.
- platform/chromium-win-xp/fast/text/shaping/shaping-script-order-expected.txt: Added.
- platform/chromium-win-xp/fast/text/shaping/shaping-selection-rect-expected.png: Added.
- platform/chromium-win-xp/fast/text/shaping/shaping-selection-rect-expected.txt: Added.
- platform/chromium-win-xp/media: Removed.
- platform/chromium-win/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-win/css1/formatting_model/floating_elements-expected.png:
- platform/chromium-win/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
- platform/chromium-win/css3/filters/custom/effect-color-check-expected.png: Added.
- platform/chromium-win/css3/filters/custom/filter-repaint-custom-clipped-expected.png: Added.
- platform/chromium-win/css3/filters/custom/filter-repaint-custom-expected.png: Added.
- platform/chromium-win/css3/filters/custom/filter-repaint-custom-rotated-expected.png: Added.
- platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
- platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-center-expected.txt: Added.
- platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-justify-expected.png: Added.
- platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt: Added.
- platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-left-expected.png: Added.
- platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-left-expected.txt: Added.
- platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-right-expected.png: Added.
- platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-right-expected.txt: Added.
- platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
- platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
- platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png: Added.
- platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt: Added.
- platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png: Added.
- platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt: Added.
- platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png: Added.
- platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt: Added.
- platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
- platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
- platform/chromium-win/fast/text/shaping: Added.
- platform/chromium-win/fast/text/shaping/shaping-script-order-expected.png: Added.
- platform/chromium-win/fast/text/shaping/shaping-script-order-expected.txt: Added.
- platform/chromium-win/fast/text/shaping/shaping-selection-rect-expected.png: Added.
- platform/chromium-win/fast/text/shaping/shaping-selection-rect-expected.txt: Added.
- platform/chromium-win/media/media-document-audio-repaint-expected.png:
- platform/chromium-win/media/media-document-audio-repaint-expected.txt:
- platform/chromium/TestExpectations:
- platform/efl/css1/formatting_model/floating_elements-expected.png: Removed.
- 19:04 Changeset [124283] by
-
[chromium] Use the event bounding box when constructing a PlatformEvent::GestureTap
https://bugs.webkit.org/show_bug.cgi?id=92151
Patch by Terry Anderson <tdanderson@chromium.org> on 2012-07-31
Reviewed by Darin Fisher.
Now that gesture events store a bounding box, use |boundingBox| instead of
|deltaX| and |deltaY| when specifying |m_area|.
- public/WebInputEvent.h:
(WebGestureEvent):
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
- 19:03 Changeset [124282] by
-
REGRESSION(r120979): Node list returned by getElementsByTagNameNS isn't invalidated when children changes
https://bugs.webkit.org/show_bug.cgi?id=92705
Reviewed by Abhishek Arya.
Source/WebCore:
The bug was caused by a typo in NodeListsNodeData::invalidateCaches. We need to invalidate
tag name node lists when child nodes change and not when attributes change.
Test: fast/dom/NodeList/nodelist-namespace-invalidation.html
- dom/Node.cpp:
(WebCore::NodeListsNodeData::invalidateCaches):
LayoutTests:
Add a regression test to ensure node lists returned by getElementsByTagNameNS are invalidated
when child nodes are added or removed.
- fast/dom/NodeList/nodelist-namespace-invalidation-expected.txt: Added.
- fast/dom/NodeList/nodelist-namespace-invalidation.html: Added.
- 18:51 Changeset [124281] by
-
nrwt: move actual test-running code into layout_test_runner.py
https://bugs.webkit.org/show_bug.cgi?id=92806
Reviewed by Ryosuke Niwa.
This is the final patch in manager-refactoring series (for now).
This moves all of the logic to actually run the tests into
layout_test_runner (in a new LayoutTestRunner) class. Now
the mechanics of actually executing all of the tests are
contained in one file (of course the actual work of talking to
DRT/WTR and diff'ing the results is still in single_test_runner).
Now manager is left with setting up and tearing down the test
environment, finding the tests to run, and processing the
results of the tests, which is a pretty managable amount of code
(no pun intended).
The unit tests for manager were split in two and all of the
runner-specific tests moved into layout_test_runner_unittest.
They were significantly cleaned up to be easier to read and
maintain as a part of this.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(TestRunInterruptedException):
(TestRunInterruptedException.init):
(TestRunInterruptedException.reduce):
(LayoutTestRunner):
(LayoutTestRunner.init):
(LayoutTestRunner.test_key):
(LayoutTestRunner.run_tests):
(LayoutTestRunner.run_tests.worker_factory):
(LayoutTestRunner.run_tests.instead):
(LayoutTestRunner._mark_interrupted_tests_as_skipped):
(LayoutTestRunner._interrupt_if_at_failure_limits):
(LayoutTestRunner._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
(LayoutTestRunner._update_summary_with_result):
(LayoutTestRunner.start_servers_with_lock):
(LayoutTestRunner.stop_servers_with_lock):
(LayoutTestRunner.handle):
(LayoutTestRunner._handle_started_test):
(LayoutTestRunner._handle_finished_test_list):
(LayoutTestRunner._handle_finished_test_list.find):
(LayoutTestRunner._handle_finished_test):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(FakePrinter):
(FakePrinter.print_workers_and_shards):
(FakePrinter.print_finished_test):
(FakePrinter.write):
(FakePrinter.write_update):
(FakePrinter.flush):
(LockCheckingRunner):
(LockCheckingRunner.init):
(LockCheckingRunner.handle_finished_list):
(LayoutTestRunnerTests):
(LayoutTestRunnerTests._runner):
(LayoutTestRunnerTests._result_summary):
(LayoutTestRunnerTests._run_tests):
(LayoutTestRunnerTests.test_http_locking):
(LayoutTestRunnerTests.test_perf_locking):
(LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
(LayoutTestRunnerTests.test_update_summary_with_result):
(LayoutTestRunnerTests.test_servers_started):
(LayoutTestRunnerTests.test_servers_started.start_http_server):
(LayoutTestRunnerTests.test_servers_started.start_websocket_server):
(LayoutTestRunnerTests.test_servers_started.stop_http_server):
(LayoutTestRunnerTests.test_servers_started.stop_websocket_server):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):
(Manager.init):
(Manager._is_http_test):
(Manager):
(Manager._is_websocket_test):
(Manager._websocket_tests):
(Manager._prepare_lists):
(Manager._is_ref_test):
(Manager.run):
(Manager._run_tests):
(Manager._look_for_new_crash_logs):
(Manager._show_results_html_file):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_look_for_new_crash_logs):
(ResultSummaryTest.summarized_results):
(ResultSummaryTest.test_summarized_results_wontfix):
- 18:48 Changeset [124280] by
-
nrwt: move sharding logic into layout_test_runner.py
https://bugs.webkit.org/show_bug.cgi?id=92805
Reviewed by Ryosuke Niwa.
The sharding logic is specific to how we actually run the tests,
so it belongs in this file instead of manager.py or finder.py.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(Worker._run_single_test):
(TestShard):
(TestShard.init):
(TestShard.repr):
(TestShard.eq):
(Sharder):
(Sharder.init):
(Sharder.shard_tests):
(Sharder.shard_tests.or):
(Sharder._shard_in_two):
(Sharder._shard_every_file):
(Sharder._shard_by_directory):
(Sharder._resize_shards):
(Sharder._resize_shards.divide_and_round_up):
(Sharder._resize_shards.extract_and_flatten):
(Sharder._resize_shards.split_at):
(Sharder._dir_for_test_input):
(Sharder.test_key):
(Sharder.natural_sort_key):
(Sharder.natural_sort_key.tryint):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Added.
(SharderTests):
(SharderTests.get_test_input):
(SharderTests.get_shards):
(SharderTests.get_shards.split):
(SharderTests.assert_shards):
(SharderTests.test_shard_by_dir):
(SharderTests.test_shard_by_dir_sharding_ref_tests):
(SharderTests.test_shard_every_file):
(SharderTests.test_shard_in_two):
(SharderTests.test_shard_in_two_sharding_ref_tests):
(SharderTests.test_shard_in_two_has_no_locked_shards):
(SharderTests.test_shard_in_two_has_no_unlocked_shards):
(SharderTests.test_multiple_locked_shards):
(NaturalCompareTest):
(NaturalCompareTest.assert_cmp):
(NaturalCompareTest.test_natural_compare):
(KeyCompareTest):
(KeyCompareTest.setUp):
(KeyCompareTest.setUp.split):
(KeyCompareTest.assert_cmp):
(KeyCompareTest.test_test_key):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.init):
(Manager._prepare_lists):
(Manager._is_ref_test):
(Manager._run_tests):
(Manager._handle_finished_test):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.get_options):
(ManagerTest.test_interrupt_if_at_failure_limits):
(ManagerTest.test_update_summary_with_result):
(ManagerTest.test_needs_servers.get_manager_with_tests):
(ManagerTest.integration_test_needs_servers.get_manager_with_tests):
(ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
(ManagerTest.test_servers_started):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 18:31 Changeset [124279] by
-
flexbox should avoid floats
https://bugs.webkit.org/show_bug.cgi?id=92661
Reviewed by Ojan Vafai.
Source/WebCore:
Block types should avoid floats. Deprecated flexbox and grid already avoid floats.
Tests: css3/flexbox/floated-flexbox.html - added a test case.
- rendering/RenderFlexibleBox.h:
LayoutTests:
Add a test case to make sure flexboxen avoid floats.
- css3/flexbox/floated-flexbox.html:
- 17:54 Changeset [124278] by
-
REGRESSION: flexbox content-size fails to exclude scrollbar
https://bugs.webkit.org/show_bug.cgi?id=92667
Reviewed by Ojan Vafai.
Source/WebCore:
In r123909, we switched to computing the height using computeContentLogicalHeightUsing().
Unfortunately, this includes the scrollbar when we want the content height. Add a helper
method for computing the value needed by flexbox.
Test: css3/flexbox/content-height-with-scrollbars.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisContentExtent): Use computeLogicalClientHeight
(WebCore::RenderFlexibleBox::computeLogicalClientHeight): Add new method for taking scrollbar into consideration.
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Use computeLogicalClientHeight
(WebCore::RenderFlexibleBox::lineBreakLength): Use computeLogicalClientHeight
- rendering/RenderFlexibleBox.h:
LayoutTests:
Add column flow test cases with scrollbars forced on.
- css3/flexbox/content-height-with-scrollbars-expected.html: Added.
- css3/flexbox/content-height-with-scrollbars.html: Added.
- 17:51 Changeset [124277] by
-
Remove unused method HTMLElementStack::bottom()
https://bugs.webkit.org/show_bug.cgi?id=92807
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-31
Reviewed by Kentaro Hara.
HTMLElementStack::bottom() was replaced with HTMLElementStack::rootNode()
in r80231.
No functional change, so no new tests.
- html/parser/HTMLElementStack.cpp:
- html/parser/HTMLElementStack.h:
(HTMLElementStack):
- 17:44 Changeset [124276] by
-
-webkit-order should take an integer, not a number
https://bugs.webkit.org/show_bug.cgi?id=92688
Reviewed by Ojan Vafai.
Source/WebCore:
The spec changed back from floats to integers:
http://lists.w3.org/Archives/Public/www-style/2012Jul/0607.html
Tests: css3/flexbox/css-properties.html: Updated.
css3/flexbox/flex-order.html: Test cases modified.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- rendering/RenderFlexibleBox.cpp:
(WebCore):
(RenderFlexibleBox::OrderHashTraits):
(WebCore::RenderFlexibleBox::OrderHashTraits::emptyValue):
(WebCore::RenderFlexibleBox::OrderHashTraits::constructDeletedValue):
(WebCore::RenderFlexibleBox::OrderHashTraits::isDeletedValue):
(RenderFlexibleBox::OrderIterator):
- rendering/RenderFlexibleBox.h:
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests:
Update tests.
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/css-properties.html:
- css3/flexbox/flex-order.html:
- 17:34 Changeset [124275] by
-
[chromium] Use skia directly in CCHeadsUpDisplayLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=92810
Reviewed by Adrienne Walker.
The chromium compositor HUD doesn't need to use a full GraphicsContext/etc, all it draws are rectangles and a
simple stroked path. This draws the HUD with straight skia calls and removes the now unnecessary PlatformCanvas
wrapper.
- WebCore.gypi:
- platform/graphics/chromium/PlatformCanvas.cpp: Removed.
- platform/graphics/chromium/PlatformCanvas.h: Removed.
- platform/graphics/chromium/cc/CCFontAtlas.cpp:
(WebCore::CCFontAtlas::drawText):
- platform/graphics/chromium/cc/CCFontAtlas.h:
(CCFontAtlas):
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:
(WebCore::CCHeadsUpDisplayLayerImpl::willDraw):
(WebCore::CCHeadsUpDisplayLayerImpl::drawHudContents):
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounter):
(WebCore::CCHeadsUpDisplayLayerImpl::drawFPSCounterText):
(WebCore::CCHeadsUpDisplayLayerImpl::drawDebugRects):
- platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h:
(WebCore):
- 17:19 Changeset [124274] by
-
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31
- DEPS:
- 17:07 Changeset [124273] by
-
ImageCG doesn't initialize m_decodedPropertiesSize in BitmapImage constructor
https://bugs.webkit.org/show_bug.cgi?id=92418
Reviewed by Dan Bernstein.
Tested by existing content.
- platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::BitmapImage): initialize m_decodedPropertiesSize to zero.
- 16:50 Changeset [124272] by
-
Fix the Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 16:46 Changeset [124271] by
-
Maybe fix the GCC build.
- heap/HeapBlock.h:
(HeapBlock): Accommodate incorrect parsing in GCC.
- 16:38 Changeset [124270] by
-
[chromium] Hit test points are being clipped by layers that should not clip
https://bugs.webkit.org/show_bug.cgi?id=92786
Reviewed by James Robinson.
Source/WebCore:
On impl-side hit testing for chromium compositor, we are
accidentally checking all ancestor layers for clipping, instead of
only layers that actually clip something. This patch fixes it.
Added new unit test that reproduces the scenario:
CCLayerTreeHostCommonTest.verifyHitTestingForNonClippingIntermediateLayer
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::pointIsClippedBySurfaceOrClipRect):
Source/WebKit/chromium:
- tests/CCLayerTreeHostCommonTest.cpp: adds a test where the hit-testable layer does not overlap its parent. The parent does not clip, so the layer should still be hittable.
- 16:37 LayoutUnit edited by
- (diff)
- 16:31 Changeset [124269] by
-
[chromium] REGRESSION(r123644) Compositor HUD crashes immediately with --show-paint-rects
https://bugs.webkit.org/show_bug.cgi?id=92775
Reviewed by Adrienne Walker.
In r123644, the compositor HUD was turned into a normal layer. When the HUD is supposed to cover the entire
viewport - for instance if the showPlatformLayerTree or showDebugRects settings are true -
HeadsUpDisplayLayerChromium's constructor tries to size itself to its layerTreeHost()'s device viewport size.
Unfortunately, its layerTreeHost pointer is always nil in the constructor since the layer is not yet in the
tree. Additionally, this doesn't handle resize at all.
To fix this, this grabs the device viewport size and settings in a LayerChromium::update() OVERRIDE. Also
changes CCLayerTreeHost::willCommit to only reparent the HUD layer if needed instead of on every frame.
Tested manually, we don't have any layout tests for the debug HUD.
- platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp:
(WebCore::HeadsUpDisplayLayerChromium::create):
(WebCore::HeadsUpDisplayLayerChromium::HeadsUpDisplayLayerChromium):
- platform/graphics/chromium/HeadsUpDisplayLayerChromium.h:
(HeadsUpDisplayLayerChromium):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::willCommit):
- 16:24 Changeset [124268] by
-
Stop masking 8 bits off of the visited link hash. We need all the bits!
https://bugs.webkit.org/show_bug.cgi?id=92799
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- runtime/Identifier.cpp:
(JSC::IdentifierCStringTranslator::hash):
(JSC::IdentifierLCharFromUCharTranslator::hash):
- runtime/Identifier.h:
(JSC::IdentifierCharBufferTranslator::hash):
Update for new function names.
Source/WebCore:
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::urlHostHash):
- platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::hashCredentialInfo):
- plugins/blackberry/PluginPackageBlackBerry.cpp:
(WebCore::PluginPackage::hash):
Update for new function names.
Source/WTF:
- wtf/StringHasher.h:
(WTF::StringHasher::hashWithTop8BitsMasked):
(WTF::StringHasher::hash):
(StringHasher):
(WTF::StringHasher::computeHashAndMaskTop8Bits):
(WTF::StringHasher::hashMemory):
(WTF::StringHasher::avalancheBits):
Rename existing computeHash and hash functions to computeHashAndMaskTop8Bits
and hashWithTop8BitsMasked respectively. Add new computeHash and hash functions
that do the StringHash without the masking.
- wtf/text/AtomicString.cpp:
(WTF::CStringTranslator::hash):
(WTF::UCharBufferTranslator::hash):
(WTF::HashAndCharactersTranslator::hash):
(WTF::SubstringTranslator::hash):
(WTF::LCharBufferFromLiteralDataTranslator::hash):
(WTF::AtomicString::fromUTF8Internal):
- wtf/text/StringHash.h:
(WTF::CaseFoldingHash::hash):
- wtf/text/StringImpl.h:
(WTF::StringImpl::setHash):
- wtf/text/StringStatics.cpp:
(WTF::StringImpl::hashSlowCase):
- wtf/unicode/UTF8.cpp:
(WTF::Unicode::calculateStringHashAndLengthFromUTF8MaskingTop8Bits):
- wtf/unicode/UTF8.h:
Update for new function names.
- 16:20 Changeset [124267] by
-
nrwt: rename worker.py to layout_test_runner.py
https://bugs.webkit.org/show_bug.cgi?id=92804
Reviewed by Ojan Vafai.
Home stretch of this round of manager refactoring ... I will be
moving all of the actual test-running code (which includes the
code that shards the tests for the workers) into a different
module, and it makes sense for that module to contain the actual
worker code, so I'm renaming worker.py to layout_test_runner.py.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/worker.py.
(Worker):
(Worker.init):
(Worker.del):
(Worker.start):
(Worker.handle):
(Worker._update_test_input):
(Worker._run_test):
(Worker.stop):
(Worker._timeout):
(Worker._kill_driver):
(Worker._run_test_with_timeout):
(Worker._clean_up_after_test):
(Worker._run_test_in_another_thread):
(Worker._run_test_in_another_thread.SingleTestThread):
(Worker._run_test_in_another_thread.SingleTestThread.init):
(Worker._run_test_in_another_thread.SingleTestThread.run):
(Worker._run_test_in_this_thread):
(Worker._run_single_test):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests.worker_factory):
- 16:07 Changeset [124266] by
-
Maybe break the Windows build.
Reviewed by Anders Carlsson.
Formally objected to by Sam Weinig.
- heap/HeapBlock.h:
(HeapBlock): Try to slightly improve this because we don't want Windows to control our lives.
- 16:05 Changeset [124265] by
-
Structures should be swept after all other objects
https://bugs.webkit.org/show_bug.cgi?id=92679
Reviewed by Filip Pizlo.
In order to get rid of ClassInfo from our objects, we need to be able to safely get the
ClassInfo during the destruction of objects. We'd like to get the ClassInfo out of the
Structure, but currently it is not safe to do so because the order of destruction of objects
is not guaranteed to sweep objects before their corresponding Structure. We can fix this by
sweeping Structures after everything else.
- heap/Heap.cpp:
(JSC::Heap::isSafeToSweepStructures): Add a function that checks if it is safe to sweep Structures.
If the Heap's IncrementalSweeper member is null, that means we're shutting down this VM and it is
safe to sweep structures since we'll always do Structures last anyways due to the ordering of
MarkedSpace::forEachBlock.
(JSC):
(JSC::Heap::didStartVMShutdown): Add this intermediate function to the Heap that ~JSGlobalData now
calls rather than calling the two HeapTimer objects individually. This allows the Heap to null out
these pointers after it has invalidated them to prevent accidental use-after-free in the sweep()
calls during lastChanceToFinalize().
- heap/Heap.h:
(Heap):
- heap/HeapTimer.h:
(HeapTimer):
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::structuresCanBeSwept): Determines if it is currently safe to sweep Structures.
This decision is based on whether we have gotten to the end of the vector of blocks that need sweeping
the first time.
(JSC):
(JSC::IncrementalSweeper::doSweep): We add a second pass over the vector to sweep Structures after we
make our first pass. We now null out the slots as we sweep them so that we can quickly find the
Structures during the second pass.
(JSC::IncrementalSweeper::startSweeping): Initialize our new Structure sweeping index.
(JSC::IncrementalSweeper::willFinishSweeping): Callback that is called by MarkedSpace::sweep to notify
the IncrementalSweeper that we are going to sweep all of the remaining blocks in the Heap so it can
assume that everything is taken care of in the correct order. Since MarkedSpace::forEachBlock
iterates over the Structure blocks after all other blocks, the ordering property for sweeping Structures holds.
(JSC::IncrementalSweeper::IncrementalSweeper): Initialize Structure sweeping index.
- heap/IncrementalSweeper.h: Add declarations for new stuff.
(IncrementalSweeper):
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): We now check if the current block only contains structures and
if so and it isn't safe to sweep Structures according to the Heap, we just return early instead of doing
the normal lazy sweep. If this proves to be too much of a waste in the future we can add an extra clause that
will sweep some number of other blocks in place of the current block to mitigate the cost of the floating
Structure garbage.
(JSC::MarkedAllocator::addBlock):
- heap/MarkedAllocator.h:
(JSC::MarkedAllocator::zapFreeList): When we zap the free list in the MarkedAllocator, the current block is no
longer valid to allocate from, so we set the current block to null.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweepHelper): Added a couple assertions to make sure that we weren't trying to sweep Structures
at an unsafe time.
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::sweep): Notify the IncrementalSweeper that the MarkedSpace will finish all currently remaining sweeping.
(JSC):
- heap/MarkedSpace.h:
(JSC):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::~JSGlobalData): Call the new Heap::didStartVMShutdown.
- 16:04 Changeset [124264] by
-
Allow AudioDestination to support local/live audio input
https://bugs.webkit.org/show_bug.cgi?id=90318
Reviewed by Kenneth Russell.
Source/Platform:
- chromium/public/WebAudioDevice.h:
(WebKit::WebAudioDevice::RenderCallback::render):
(RenderCallback):
Source/WebCore:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- GNUmakefile.list.am:
Add AudioIOCallback.h to make files.
- Modules/webaudio/AudioDestinationNode.h:
- Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::render):
Change provideInput() method to render() to support optional audio input.
(AudioDestinationNode):
(WebCore::AudioDestinationNode::localAudioInputProvider):
Expose public access to an AudioSourceProvider for local/live audio input.
(LocalAudioInputProvider):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::LocalAudioInputProvider):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::set):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::provideInput):
Add simple AudioSourceProvider implementation which dishes out a single AudioBus each
render quantum for optional local/live audio input.
- Modules/webaudio/OfflineAudioDestinationNode.h:
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::startRendering):
(WebCore::OfflineAudioDestinationNode::offlineRenderEntry):
(WebCore::OfflineAudioDestinationNode::offlineRender):
Simple name change using "offline" prefix to avoid confusion with AudioDestinationNode::render() method (implementing AudioIOCallback)
- platform/audio/AudioDestination.h:
Switch create() method to take an AudioIOCallback instead of AudioSourceProvider.
- platform/audio/AudioIOCallback.h:
(WebCore::AudioIOCallback::~AudioIOCallback):
Add new AudioIOCallback interface for audio input/output.
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
- platform/audio/gstreamer/AudioDestinationGStreamer.h:
(AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::callback):
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(_WebKitWebAudioSourcePrivate):
(webKitWebAudioSrcSetProperty):
(webKitWebAudioSrcLoop):
Small tweaks to AudioDestinationGStreamer implementation to account for switch to AudioIOCallback.
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationMac::AudioDestinationMac):
(WebCore::AudioDestinationMac::render):
- platform/audio/mac/AudioDestinationMac.h:
(AudioDestinationMac):
Small tweaks to AudioDestinationMac implementation to account for switch to AudioIOCallback.
Source/WebKit/chromium:
- src/AudioDestinationChromium.cpp:
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::provideInput):
(WebCore):
- src/AudioDestinationChromium.h:
(AudioDestinationChromium):
- 16:00 Changeset [124263] by
-
Fix all the other builds I just broke. Maybe fix the Windows build.
- heap/HeapBlock.h:
(HeapBlock): WTF?
- 16:00 Changeset [124262] by
-
Read tag names and attributes from the saved tokens in HTMLTreeBuilder::processEndTag(AtomicHTMLToken*)
https://bugs.webkit.org/show_bug.cgi?id=92715
Reviewed by Adam Barth.
This is a follow-up patch for r123577. Changed oneBelowTop to return HTMLStackItem*.
No new tests, covered by existing tests.
- html/parser/HTMLConstructionSite.h:
(WebCore::HTMLConstructionSite::oneBelowTop):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::oneBelowTop):
- html/parser/HTMLElementStack.h:
(HTMLElementStack):
- 15:59 Changeset [124261] by
-
Maybe fix the Windows build.
- heap/HeapBlock.h:
(HeapBlock): WTF?
- 15:55 Changeset [124260] by
-
StyleResolver::canShareStyleWithElement does not need to use getAttribute for classAttr in the non-SVG case
https://bugs.webkit.org/show_bug.cgi?id=92687
Reviewed by Antti Koivisto.
Previously 10% of samples in canShareStyleWithElement hit this line, after this change < 1% do.
This is a small speedup for the non-SVG case. Since this call is made for every element
when style is resolved, any small speedup in this function matters on large documents.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- 15:44 Changeset [124259] by
-
Prefer the Oracle Java plug-in over the Apple Java plug-in
https://bugs.webkit.org/show_bug.cgi?id=92780
Reviewed by Oliver Hunt.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::findPluginWithBundleIdentifier):
Add a new helper for finding a plug-in with the given bundle identifier.
(WebKit::checkForPreferredPlugin):
Helper function for making sure that an old plug-in is never loaded if a new plug-in is found, and that the old plug-in
is removed from the list of loaded plug-ins if the new plug-in is found.
(WebKit::PluginInfoStore::shouldUsePlugin):
Prefer the Oracle Java plug-in over the Apple Java plug-in.
- 15:36 Changeset [124258] by
-
Heap-use-after-free in WebCore::StyleResolver::loadPendingImage
https://bugs.webkit.org/show_bug.cgi?id=92606
Reviewed by Abhishek Arya.
Source/WebCore:
Changes StyleResolver's m_pendingImageProperties set to a map, such that for each property we keep
a RefPtr to the CSSValue used to set that property. This ensures that CSSValues are not freed before
they are needed by loadPendingImage.
Test: fast/css/variables/deferred-image-load-from-variable.html
- css/StyleResolver.cpp:
- css/StyleResolver.h:
LayoutTests:
Exercises the codepath where an image is loaded using a url specified via a variable.
- fast/css/variables/deferred-image-load-from-variable-expected.txt: Added.
- fast/css/variables/deferred-image-load-from-variable.html: Added.
- 15:34 Changeset [124257] by
-
[Chromium] Rebaselines.
https://bugs.webkit.org/show_bug.cgi?id=58008
https://bugs.webkit.org/show_bug.cgi?id=81145
https://bugs.webkit.org/show_bug.cgi?id=92537
Unreviewed, test updates.
Mostly rebaselining for
http://src.chromium.org/viewvc/chrome?view=rev&revision=149198 , which
resulted in some i18n font changes due to
http://trac.webkit.org/changeset/83126 .
- fast/dom/52776-expected.txt: Added.
- fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
- platform/chromium-linux-x86/fast/text/international: Removed.
- platform/chromium-linux-x86/fast/text/international/bidi-neutral-run-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/compositing: Added.
- platform/chromium-linux-x86/platform/chromium/compositing/scrollbars: Added.
- platform/chromium-linux-x86/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/52776-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/52776-expected.txt:
- platform/chromium-mac-snowleopard/fast/text/complex-text-opacity-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/arabic-justify-expected.txt:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-L-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-CS-after-AN-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-mirror-he-ar-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png:
- platform/chromium-mac/fast/dom/52776-expected.png:
- platform/chromium-mac/fast/dom/52776-expected.txt: Removed.
- platform/chromium-mac/fast/text/complex-text-opacity-expected.png:
- platform/chromium-mac/fast/text/complex-text-opacity-expected.txt: Removed.
- platform/chromium-mac/fast/text/international/arabic-justify-expected.png:
- platform/chromium-mac/fast/text/international/arabic-justify-expected.txt: Removed.
- platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.png:
- platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.txt: Removed.
- platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
- platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.png:
- platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.txt: Removed.
- platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.png:
- platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
- platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
- platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.
- platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png: Added.
- platform/chromium-win-xp/fast/text/international/bidi-neutral-run-expected.png: Removed.
- platform/chromium/TestExpectations:
- platform/efl/fast/dom/52776-expected.txt: Removed.
- platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.
- platform/gtk/fast/dom/52776-expected.txt: Removed.
- platform/gtk/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.
- 15:27 Changeset [124256] by
-
Maybe fix the Windows build.
- heap/HeapBlock.h:
(HeapBlock): WTF?
- 15:07 Changeset [124255] by
-
Add stub implementation for MediaStreamAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=90110
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webaudio/mediastreamaudiosourcenode.html
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
Add MediaStreamAudioSourceNode files to make files.
- Modules/webaudio/AudioContext.cpp:
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/AudioContext.idl:
(WebCore::AudioContext::createMediaStreamSource):
Add new createMediaStreamSource() method.
- Modules/webaudio/AudioNode.h:
Add NodeTypeMediaStreamAudioSource.
- Modules/webaudio/MediaStreamAudioSourceNode.cpp: Added.
- Modules/webaudio/MediaStreamAudioSourceNode.h: Added.
(WebCore::MediaStreamAudioSourceNode::create):
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
(WebCore::MediaStreamAudioSourceNode::~MediaStreamAudioSourceNode):
(WebCore::MediaStreamAudioSourceNode::setFormat):
(WebCore::MediaStreamAudioSourceNode::process):
(WebCore::MediaStreamAudioSourceNode::reset):
(WebCore::MediaStreamAudioSourceNode::mediaStream):
(WebCore::MediaStreamAudioSourceNode::audioSourceProvider):
Basic MediaStreamAudioSourceNode implementation.
- Modules/webaudio/MediaStreamAudioSourceNode.idl: Added.
LayoutTests:
- webaudio/mediastreamaudiosourcenode-expected.txt: Added.
- webaudio/mediastreamaudiosourcenode.html: Added.
- 15:00 Changeset [124254] by
-
[Chromium] Rebaselines.
https://bugs.webkit.org/show_bug.cgi?id=45991
https://bugs.webkit.org/show_bug.cgi?id=81145
https://bugs.webkit.org/show_bug.cgi?id=82911
http://crbug.com/131187
http://crbug.com/135709
http://crbug.com/139796
Mostly rebaselining in the wake of r124209, with a few other things
mixed in.
- platform/chromium-linux-x86/fast/gradients: Added.
- platform/chromium-linux-x86/fast/gradients/crash-on-zero-radius-expected.png: Added.
- platform/chromium-linux-x86/fast/gradients/generated-gradients-expected.png: Added.
- platform/chromium-linux-x86/fast/gradients/list-item-gradient-expected.png: Added.
- platform/chromium-linux-x86/fast/gradients/simple-gradients-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Removed.
- platform/chromium-linux-x86/svg/as-background-image: Added.
- platform/chromium-linux-x86/svg/as-background-image/svg-as-background-3-expected.png: Added.
- platform/chromium-linux-x86/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Removed.
- platform/chromium-linux/fast/gradients/crash-on-zero-radius-expected.png:
- platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
- platform/chromium-linux/fast/gradients/list-item-gradient-expected.png:
- platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
- platform/chromium-linux/platform/chromium/compositing/scrollbars/custom-composited-different-track-parts-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
- platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
- platform/chromium-linux/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
- platform/chromium-linux/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png:
- platform/chromium-mac-snowleopard/fast/gradients/list-item-gradient-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
- platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt: Removed.
- platform/chromium-mac/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt: Removed.
- platform/chromium-mac/fast/canvas/canvas-currentColor-expected.txt: Removed.
- platform/chromium-mac/fast/gradients/crash-on-zero-radius-expected.png:
- platform/chromium-mac/fast/gradients/css3-color-stop-units-expected.png: Added.
- platform/chromium-mac/fast/gradients/generated-gradients-expected.png:
- platform/chromium-mac/fast/gradients/list-item-gradient-expected.png:
- platform/chromium-mac/fast/gradients/simple-gradients-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
- platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png:
- platform/chromium-mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
- platform/chromium-mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- platform/chromium-win-xp/svg/as-background-image: Added.
- platform/chromium-win-xp/svg/as-background-image/svg-as-background-3-expected.png: Added.
- platform/chromium-win-xp/svg/as-background-image/svg-as-background-6-expected.png: Added.
- platform/chromium-win-xp/svg/as-background-image/svg-as-background-with-relative-size-expected.png: Added.
- platform/chromium-win/fast/gradients/crash-on-zero-radius-expected.png:
- platform/chromium-win/fast/gradients/generated-gradients-expected.png:
- platform/chromium-win/fast/gradients/list-item-gradient-expected.png:
- platform/chromium-win/fast/gradients/simple-gradients-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
- platform/chromium-win/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- platform/chromium/TestExpectations:
- 14:32 Changeset [124253] by
-
FractionalLayoutUnit minor math bugs
https://bugs.webkit.org/show_bug.cgi?id=86065
Reviewed by Levi Weintraub.
Implement a consistent set of subject modifying operators, to ensure
operations that need to be in float are performed in float.
Scale FractionalLayoutSize in FractionalLayoutUnits instead of intergers.
No new functionality. No new tests.
- platform/FractionalLayoutUnit.h:
(WebCore::operator-=):
(WebCore::operator*=):
(WebCore::operator/=):
- platform/graphics/FractionalLayoutSize.h:
(WebCore::FractionalLayoutSize::scale):
- 14:29 Changeset [124252] by
-
[Chromium-Android] We should hueristically detect content intents on touch
https://bugs.webkit.org/show_bug.cgi?id=92346
Reviewed by Nate Chapin.
On Android, when the user touches a block of text, we run a bunch of
OS-provided hueristics to detect content intents, such as telephone
numbers and mailing addresses.
This patch introduces the WebViewClient functions and the
detectContentIntentOnTouch function, but does not wire the code into
the event system. There are some decisions to make about how to wire it
into the event system, we'll tackle in the next patch.
- public/WebViewClient.h:
(WebKit::WebViewClient::detectContentIntentAround):
(WebViewClient):
(WebKit::WebViewClient::scheduleContentIntent):
(WebKit::WebViewClient::cancelScheduledContentIntents):
- src/WebViewImpl.cpp:
(WebKit):
(WebKit::tapHighlightColorForNode):
(WebKit::WebViewImpl::showTouchHighlightQuads):
(WebKit::WebViewImpl::detectContentIntentOnTouch):
- src/WebViewImpl.h:
(WebViewImpl):
- 14:29 Changeset [124251] by
-
[chromium] Unreviwed gardening.
Some TestExpectations hygiene.
- platform/chromium/TestExpectations:
- 14:26 Changeset [124250] by
-
Removed some public data and casting from the Heap
https://bugs.webkit.org/show_bug.cgi?id=92777
Reviewed by Oliver Hunt.
- heap/BlockAllocator.cpp:
(JSC::BlockAllocator::releaseFreeBlocks):
(JSC::BlockAllocator::blockFreeingThreadMain): Use the DeadBlock class
since HeapBlock is a template, and not a class, now. Call destroy()
instead of monkeying around with DeadBlock's internal data because
encapsulation is good.
- heap/BlockAllocator.h:
(DeadBlock): Added a class to represent a dead block, since HeapBlock is
a template now, and can't be instantiated directly.
(JSC::DeadBlock::DeadBlock):
(JSC::DeadBlock::create):
(BlockAllocator):
(JSC::BlockAllocator::allocate):
(JSC::BlockAllocator::deallocate): Use the DeadBlock class because
encapsulation is good.
- heap/CopiedBlock.h:
(CopiedBlock::destroy): No need for a destroy() function, since we
inherit one now.
(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::payloadEnd):
(JSC::CopiedBlock::capacity): Updated for some encapsulation inside
HeapBlock.
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::~CopiedSpace):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::size):
(JSC::CopiedSpace::capacity):
(JSC::isBlockListPagedOut): Removed a bunch of casting. This is no longer
necessary, now that our list and its nodes have the right type.
- heap/CopiedSpace.h: Use the right type in our data structures because
it improves clarity.
- heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::startedCopying): Use swap to avoid duplicating it.
- heap/HeapBlock.h:
(HeapBlock): Made this a class template so we can return the right type
in linked list operations. Made our data private because encapsulation
is good.
(JSC::HeapBlock::destroy): Since we know our type, we can also eliminate
duplicate destroy() functions in our subclasses.
(JSC::HeapBlock::allocation): Added an accessor so we can hide our data.
By using const, this accessor prevents clients from accidentally deleting
our allocation.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::isPagedOut):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::removeBlock): Removed a bunch of casting. This is
no longer necessary, now that our list and its nodes have the right type.
- heap/MarkedAllocator.h:
(MarkedAllocator):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::forEachBlock): Use the right type, do less casting.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::destroy): Removed this function because our parent
class provides it for us now.
(JSC::MarkedBlock::MarkedBlock):
- heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::capacity): Updated for encapsulation.
- 14:22 Changeset [124249] by
-
[WK2] Use an actual WebProcessProxy when decoding messages
https://bugs.webkit.org/show_bug.cgi?id=92788
Reviewed by Anders Carlsson.
WebContextUserMessageDecoder gets process proxy from a WebContext object, but we
know which process a message came from, and can just use that.
- UIProcess/WebContextUserMessageCoders.h: (WebKit::WebContextUserMessageDecoder::WebContextUserMessageDecoder): (WebKit::WebContextUserMessageDecoder::decode): This is the focal point of this patch - decoder no longer needs to call m_context->process().
- UIProcess/WebContext.cpp: (WebKit::WebContext::didReceiveMessage): (WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h: These methods now take a WebProcessProxy pointer instead of IPC::Connection, so that they can call the updated coder. A number of other didReceiveMessage can be modified to take WebProcessProxy later if needed (it's a richer interface than IPC::Connection), although not all messages come from WebProcesses.
- UIProcess/WebConnectionToWebProcess.cpp: (WebKit::WebConnectionToWebProcess::didReceiveMessage):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::willGoToBackForwardListItem): (WebKit::WebPageProxy::registerIntentServiceForFrame): (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame): (WebKit::WebPageProxy::didFailProvisionalLoadForFrame): (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::didFinishDocumentLoadForFrame): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::didSameDocumentNavigationForFrame): (WebKit::WebPageProxy::didReceiveTitleForFrame): (WebKit::WebPageProxy::didFirstLayoutForFrame): (WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame): (WebKit::WebPageProxy::didNewFirstVisuallyNonEmptyLayout): (WebKit::WebPageProxy::didRemoveFrameFromHierarchy): (WebKit::WebPageProxy::didDisplayInsecureContentForFrame): (WebKit::WebPageProxy::didRunInsecureContentForFrame): (WebKit::WebPageProxy::didDetectXSSForFrame): (WebKit::WebPageProxy::didReceiveIntentForFrame): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNewWindowAction): (WebKit::WebPageProxy::decidePolicyForResponse): (WebKit::WebPageProxy::unableToImplementPolicy): (WebKit::WebPageProxy::willSubmitForm): (WebKit::WebPageProxy::mouseDidMoveOverElement): (WebKit::WebPageProxy::internalShowContextMenu):
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveMessage): (WebKit::WebProcessProxy::didReceiveSyncMessage): Updated arguments accordingly.
- 13:55 Changeset [124248] by
-
[chromium] Unreviewed gardening.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.
- 13:50 Changeset [124247] by
-
nrwt: clean up names in sharding code
https://bugs.webkit.org/show_bug.cgi?id=92785
Reviewed by Ryosuke Niwa.
More refactoring ... this makes the methods use TestInputs
consistently (and updates the names accordingly) and improves
encapsulation a bit. The sharding code is now pretty
self-contained.
This change adds no new functionality and is covered by the
existing (updated) tests.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(TestShard.visible.init):
(TestShard.visible.repr):
(Manager._dir_for_test_input):
(Manager._shard_tests):
(Manager._shard_in_two):
(Manager._shard_every_file):
(Manager._shard_by_directory):
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerWrapper._test_input_for_file):
(ShardingTests.get_shards):
- Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput.init):
(TestInput.repr):
- 13:48 Changeset [124246] by
-
nrwt: clean up TestInputs in preparation for cleaning up sharding
https://bugs.webkit.org/show_bug.cgi?id=92784
Reviewed by Ryosuke Niwa.
Currently, in order to shard the tests you need to refer to
state in the manager as well as the state in the TestInputs;
this change embeds the necessary state into the TestInputs so
sharding them can be a standalone operation.
The actual clean up of the sharding will follow in a subsequent patch.
Covered by existing tests; no new functionality. However, I did
rework the sharding tests to be less dependent on the test
scaffolding and easier to follow.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._test_input_for_file):
(Manager._shard_in_two):
(Manager._shard_every_file):
(Manager._shard_by_directory):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerWrapper._test_input_for_file):
(ShardingTests.assert_shards):
(ShardingTests.test_shard_by_dir):
(ShardingTests.test_shard_by_dir_sharding_ref_tests):
(ShardingTests.test_shard_every_file):
(ShardingTests.test_shard_in_two):
(ShardingTests.test_shard_in_two_sharding_ref_tests):
(ShardingTests.test_shard_in_two_has_no_unlocked_shards):
(ShardingTests.test_multiple_locked_shards):
- Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput.init):
(TestInput.repr):
- 13:46 Changeset [124245] by
-
[chromium] Unreviewed gardening.
Add new mac baselines for fill-stroke-clip-reset-path. These have red
squares for the dashboard results, since chrome doesn't support
dashboard mode. The same had already been done for Win and Linux.
- platform/chromium-mac-snowleopard/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
- platform/chromium-mac/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
- platform/chromium/TestExpectations:
- 13:30 Changeset [124244] by
-
[EFL] Dump a backtrace in case of a crash
https://bugs.webkit.org/show_bug.cgi?id=92489
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31
Reviewed by Csaba Osztrogonác.
Dump a stack trace in case of a unexpected signal. This should
provide a better report at the build bots when WTR crashes.
- DumpRenderTree/efl/DumpRenderTree.cpp:
(main):
- TestWebKitAPI/efl/InjectedBundleController.cpp:
(TestWebKitAPI::InjectedBundleController::platformInitialize):
- WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp:
(WTR::InjectedBundle::platformInitialize):
- 13:24 Changeset [124243] by
-
suppress gradient tests on skia/mac that have incorrectly "recorded failure", now that those tests are actually passing (drawing correctly)
https://bugs.webkit.org/show_bug.cgi?id=92787
Reviewed by NOBODY - expectations only
- platform/chromium/TestExpectations:
- 12:52 Changeset [124242] by
-
[BlackBerry] Enable CSS Filter Effects
https://bugs.webkit.org/show_bug.cgi?id=92685
Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-31
Reviewed by Rob Buis.
Enable CSS filter effects, with the exception of custom effects (CSS shaders) and reference effects (SVG effects)
.:
Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.
- Source/cmake/OptionsBlackBerry.cmake: Add LayerFilterRenderer
- Source/cmakeconfig.h.cmake: Acknowledge CSS filter effects
Source/WebCore:
No new tests, because this is covered by tests from other platforms.
Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.
- CMakeLists.txt:
- PlatformBlackBerry.cmake:
- platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore):
(WebCore::GraphicsLayerBlackBerry::setFilters):
(WebCore::GraphicsLayerBlackBerry::updateFilters):
- platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::filters):
- platform/graphics/blackberry/LayerCompositingThread.h:
(LayerOverride):
(WebCore):
(WebCore::LayerCompositingThread::filterOperationsChanged):
(WebCore::LayerCompositingThread::setFilterOperationsChanged):
(LayerCompositingThread):
(WebCore::LayerCompositingThread::filterActions):
(WebCore::LayerCompositingThread::setFilterActions):
- platform/graphics/blackberry/LayerData.h:
(LayerData):
(WebCore::LayerData::filters):
- platform/graphics/blackberry/LayerFilterRenderer.cpp: Added.
(WebCore):
(WebCore::operationTypeToProgramID):
(WebCore::Uniformf::Uniformf):
(WebCore::Uniform1f::apply):
(WebCore::Uniform1f::create):
(WebCore::Uniform1f::Uniform1f):
(WebCore::Uniform2f::apply):
(WebCore::Uniform2f::create):
(WebCore::Uniform2f::Uniform2f):
(WebCore::Uniform3f::apply):
(WebCore::Uniform3f::create):
(WebCore::Uniform3f::Uniform3f):
(WebCore::LayerFilterRendererAction::create):
(WebCore::LayerFilterRendererAction::LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::~LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::useActionOn):
(WebCore::LayerFilterRenderer::create):
(WebCore::LayerFilterRenderer::LayerFilterRenderer):
(WebCore::LayerFilterRenderer::bindCommonAttribLocation):
(WebCore::LayerFilterRenderer::initializeSharedGLObjects):
(WebCore::LayerFilterRenderer::ping):
(WebCore::LayerFilterRenderer::pong):
(WebCore::LayerFilterRenderer::pushSnapshot):
(WebCore::LayerFilterRenderer::popSnapshot):
(WebCore::LayerFilterRenderer::actionsForOperations):
(WebCore::LayerFilterRenderer::applyActions):
- platform/graphics/blackberry/LayerFilterRenderer.h: Added.
(WebCore):
(Uniformf):
(WebCore::Uniformf::location):
(Uniform1f):
(Uniform2f):
(Uniform3f):
(LayerFilterRendererAction):
(WebCore::LayerFilterRendererAction::shouldPushSnapshot):
(WebCore::LayerFilterRendererAction::setPushSnapshot):
(WebCore::LayerFilterRendererAction::shouldPopSnapshot):
(WebCore::LayerFilterRendererAction::setPopSnapshot):
(WebCore::LayerFilterRendererAction::appendUniform):
(LayerFilterRenderer):
(WebCore::LayerFilterRenderer::isEnabled):
(WebCore::LayerFilterRenderer::disable):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::loadShader):
(WebCore::LayerRenderer::loadShaderProgram):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore):
(WebCore::LayerRenderer::initializeSharedGLObjects):
- platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderer):
- platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore):
(WebCore::LayerWebKitThread::filtersCanBeComposited):
- platform/graphics/blackberry/LayerWebKitThread.h:
(LayerWebKitThread):
(WebCore::LayerWebKitThread::setFilters):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::resizeContext):
(WebCore::FECustomFilter::bindProgramAndBuffers):
- platform/graphics/filters/FilterOperation.h:
(WebCore):
(FilterOperation):
Tools:
Internally reviewed by Arvid Nilsson <anilsson@rim.com> and Antonio Gomes <agomes@rim.com>.
- Scripts/webkitperl/FeatureList.pm: Acknowledge CSS filter effects.
- 12:50 Changeset [124241] by
-
Get rid of "parser" type casts in CSSGrammar.y
https://bugs.webkit.org/show_bug.cgi?id=92760
Reviewed by Adam Barth.
r124099 now type the parser parameter, it is therefore not needed to
cast to CSSParser* everywhere as we know have a CSSParser* type
already.
No new tests : refactor with no behavior change expected.
- css/CSSGrammar.y:
- 12:42 Changeset [124240] by
-
nrwt: clean up prepare_lists_and_print_output, run, set_up_run a bit
https://bugs.webkit.org/show_bug.cgi?id=92781
Reviewed by Ryosuke Niwa.
More refactoring ... rename prepare_lists_and_print_output to
just prepare_lists so that it only has a single purpose, and
clean up the surrounding code a bit as well.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._collect_tests):
(Manager._prepare_lists):
(Manager._set_up_run):
(Manager.run):
- 12:38 Changeset [124239] by
-
[chromium] Use WebAnimation and related classes in GraphicsLayerChromium and AnimTranslationUtil
https://bugs.webkit.org/show_bug.cgi?id=90468
Reviewed by James Robinson.
Source/Platform:
- Platform.gypi:
- chromium/public/WebAnimation.h:
(WebAnimation):
(WebKit::WebAnimation::WebAnimation):
- chromium/public/WebAnimationDelegate.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCLayerAnimationDelegate.h.
(WebKit):
(WebAnimationDelegate):
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
Source/WebCore:
No new tests. No new functionality.
- WebCore.gypi:
- platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::appendKeyframe):
(WebCore::WebTransformAnimationCurve):
(WebCore::createWebAnimation):
- platform/graphics/chromium/AnimationTranslationUtil.h:
(WebKit):
(WebCore):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
- platform/graphics/chromium/LayerChromium.cpp:
- platform/graphics/chromium/LayerChromium.h:
(WebKit):
(WebCore):
(WebCore::LayerChromium::setLayerAnimationDelegate):
(LayerChromium):
- platform/graphics/chromium/LinkHighlight.h:
(LinkHighlight):
Source/WebKit/chromium:
- src/WebAnimation.cpp:
(WebKit::WebAnimation::targetProperty):
(WebKit):
(WebKit::WebAnimation::initialize):
- src/WebLayer.cpp:
(WebKit::WebLayer::setAnimationDelegate):
(WebKit):
(WebKit::WebLayer::addAnimation):
(WebKit::WebLayer::removeAnimation):
(WebKit::WebLayer::pauseAnimation):
(WebKit::WebLayer::suspendAnimations):
(WebKit::WebLayer::resumeAnimations):
(WebKit::WebLayer::transferAnimationsTo):
- tests/CCThreadedTest.cpp:
- tests/CCThreadedTest.h:
(TestHooks):
- tests/WebAnimationTest.cpp:
(WebKit::TEST):
- 12:20 Changeset [124238] by
-
Fix potential build error on LocalFileSystem::deleteFileSystem.
https://bugs.webkit.org/show_bug.cgi?id=92695
Non-Chrome build of WebKit with FILE_SYSTEM flag will be broken at
LocalFileSystem::deleteFileSystem.
Chrome does not use this source and most of other ports don't turn on
FILE_SYSTEM flag for now. So, we've not seen the breakage explicitly yet.
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-31
Reviewed by Adam Barth.
Non-Chrome WebKit build with FILE_SYSTEM should be finished successfully.
- Modules/filesystem/LocalFileSystem.cpp:
(WebCore::LocalFileSystem::deleteFileSystem):
- 12:14 Changeset [124237] by
-
AudioPannerNode should raise exception when distanceModel is set incorrectly
https://bugs.webkit.org/show_bug.cgi?id=90952
Patch by Li Yin <li.yin@intel.com> on 2012-07-31
Reviewed by Chris Rogers.
Source/WebCore:
Spec: http://www.w3.org/TR/webaudio/#AudioPannerNode-section
The distance model can be only set to LINEAR_DISTANCE, INVERSE_DISTANCE or EXPONENTIAL_DISTANCE.
If the incorrect value is set, it will raise the exception.
Use the unsigned short to replace unsigned long in AudioPannerNode.idl.
Test: webaudio/audiopannernode-basic.html
- Modules/webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::setDistanceModel): raise exception
(WebCore):
- Modules/webaudio/AudioPannerNode.h:
(AudioPannerNode):
- Modules/webaudio/AudioPannerNode.idl: using unsigned short to replace unsigned long
LayoutTests:
Spec: http://www.w3.org/TR/webaudio/#AudioPannerNode-section
Add tests for distanceModel,numberOfInputs and numberOfInputs of AudioPannerNode.
- webaudio/audiopannernode-basic-expected.txt: Added.
- webaudio/audiopannernode-basic.html: Added.
- webaudio/panner-set-model-expected.txt: Removed.
- webaudio/panner-set-model.html: Removed.
- 12:11 Changeset [124236] by
-
nrwt: clean up self._test_files_list vs. self._test_files, other nits
https://bugs.webkit.org/show_bug.cgi?id=92702
Reviewed by Ojan Vafai.
Get rid of self._test_files, rename self._test_files_list to
self._test_names (removing the confusion between the two fields).
Also inline the one call to _parse_expectations, remove the one
use of more_tests_to_skip, and fix a couple of minor nits.
- Scripts/webkitpy/layout_tests/controllers/finder.py:
(LayoutTestFinder.split_into_chunks):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.init):
(Manager._collect_tests):
(Manager._http_tests):
(Manager._websocket_tests):
(Manager._is_perf_test):
(Manager.prepare_lists_and_print_output):
(Manager.needs_servers):
(Manager.run):
(Manager._mark_interrupted_tests_as_skipped):
(Manager._update_summary_with_result):
(Manager._upload_json_files):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_interrupt_if_at_failure_limits):
(ManagerTest.test_needs_servers.get_manager_with_tests):
(ManagerTest.test_servers_started):
- 12:09 Changeset [124235] by
-
nrwt: --verbose logging does not work right on windows
https://bugs.webkit.org/show_bug.cgi?id=92673
Reviewed by Ojan Vafai.
Add a test for r124090.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_verbose):
- 12:05 Changeset [124234] by
-
REGRESSION(124116): Number of skipped tests isn't printed anymore
https://bugs.webkit.org/show_bug.cgi?id=92736
Reviewed by Tony Chang.
Add the skipped number back in; it was useful ... also clean up
the formatting a little bit.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):
- 12:04 Changeset [124233] by
-
[CSS Shaders] CSS parser rejects parameter names that are also CSS keywords
https://bugs.webkit.org/show_bug.cgi?id=92537
Patch by Max Vujovic <mvujovic@adobe.com> on 2012-07-31
Reviewed by Dirk Schulze.
Source/WebCore:
Remove the CSS keyword check for CSS Shaders parameter names. Parameters are allowed to be
any valid CSS identifier, including CSS keywords. See the spec:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/custom/index.html#feCustom
The CSS parser was rejecting input like the following because it uses a CSS keyword
"background" as a parameter name:
-webkit-filter: custom(none url(fragment.shader), background 0 1 0 1);
Test: css3/filters/custom/custom-filter-css-keyword-as-parameter-name.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseCustomFilter): Do not return early when the parameter name is a
CSS keyword (i.e. when the CSSParserValue has a non-zero id).
LayoutTests:
Add a pixel test that uses the CSS keyword "background" as a CSS Shaders parameter name.
Add a parsing test case that uses the CSS keyword "background".
- css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
- css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.txt: Added.
- css3/filters/custom/custom-filter-css-keyword-as-parameter-name.html: Added.
- css3/filters/custom/custom-filter-property-parsing-expected.txt:
- css3/filters/resources/css-keyword-as-parameter-name.fs: Added.
- css3/filters/script-tests/custom-filter-property-parsing.js:
- platform/chromium/TestExpectations:
- platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:
- 12:01 Changeset [124232] by
-
Typo: doubleTa*b*ZoomAnimationDurationInSeconds in WebViewImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=92135
Reviewed by Kentaro Hara.
This patch fixes a typo.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animateZoomAroundPoint):
- 11:56 Changeset [124231] by
-
Caret position is wrong when a editable container has word-wrap:normal set
https://bugs.webkit.org/show_bug.cgi?id=89649
Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-31
Reviewed by Levi Weintraub.
Source/WebCore:
Correcting the incorrect addumption that the min and max position for the caret rect is constrained to
the logical containing block width. This assumption is incorrect when the text has word-wrap:normal and
flows beyound the visible rect of the container.
Test: editing/input/editable-container-with-word-wrap-normal.html
- rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
LayoutTests:
- editing/input/editable-container-with-word-wrap-normal-expected.txt: Added.
- editing/input/editable-container-with-word-wrap-normal.html: Added.
- 11:48 Changeset [124230] by
-
DFG OSR exit profiling has unusual oversights
https://bugs.webkit.org/show_bug.cgi?id=92728
Reviewed by Geoffrey Garen.
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 11:47 Changeset [124229] by
-
Crash in FrameLoader::checkLoadComplete with non-browser client app
https://bugs.webkit.org/show_bug.cgi?id=92774
Reviewed by Alexey Proskuryakov..
Speculative fix. It is possible that CSSFontSelector could get deleted during the timer callback
and memory reused, making m_document point to some garbage when it is tested at the end.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::beginLoadTimerFired):
- 11:44 Changeset [124228] by
-
Add MIPS add32 function
https://bugs.webkit.org/show_bug.cgi?id=91522
Patch by Chao-ying Fu <fu@mips.com> on 2012-07-31
Reviewed by Oliver Hunt.
Add isCompactPtrAlignedAddressOffset.
Add a new version of add32 that accepts AbsoluteAddress as inputs.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::isCompactPtrAlignedAddressOffset): New.
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::add32): Support AbsoluteAddress as inputs.
- 11:43 Changeset [124227] by
-
[BlackBerry] Fix crash in InputHandler spell checking.
https://bugs.webkit.org/show_bug.cgi?id=92763
Reviewed by Antonio Gomes.
PR 185574.
Fix crash in getSpellChecker by guarding the calling paths
to ensure that m_currentFocusElement is valid.
Also add ASSERTs for previous crash.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::getSpellChecker):
- 11:31 Changeset [124226] by
-
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=92770
Unreviewed gardening.
New baselines, skipped some failing tests and removed test
expectations that are the same as the global expectations.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31
- platform/efl/TestExpectations:
- platform/efl/compositing/iframes/leave-compositing-iframe-expected.txt: Removed.
- platform/efl/compositing/plugins/1x1-composited-plugin-expected.txt: Removed.
- platform/efl/compositing/plugins/large-to-small-composited-plugin-expected.txt: Removed.
- platform/efl/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
- platform/efl/fast/block/positioning/rtl-fixed-positioning-expected.txt: Removed.
- platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
- platform/efl/fast/forms/listbox-clip-expected.txt: Removed.
- platform/efl/fast/html/details-position-expected.txt: Removed.
- platform/efl/mathml/msub-anonymous-child-render-crash-expected.txt: Removed.
- platform/efl/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
- platform/efl/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.
- 11:26 Changeset [124225] by
-
Speech JavaScript API: Throw exception for start() when already started
https://bugs.webkit.org/show_bug.cgi?id=92756
Reviewed by Adam Barth.
Source/WebCore:
Make the start() function throw an exception if the SpeechRecognition
object was already started.
Test: fast/speech/scripted/start-exception.html
- Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::stopFunction):
(WebCore::SpeechRecognition::abort):
(WebCore::SpeechRecognition::didReceiveError):
(WebCore::SpeechRecognition::didEnd):
(WebCore::SpeechRecognition::SpeechRecognition):
- Modules/speech/SpeechRecognition.h:
(SpeechRecognition):
- Modules/speech/SpeechRecognition.idl:
Tools:
Fix the task queue in MockWebSpeechRecognizer.
It's important that we remove the task from the queue before we run
it, as running the task could alter the queue's state.
- DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
(MockWebSpeechRecognizer::abort):
(MockWebSpeechRecognizer::setError):
(MockWebSpeechRecognizer::clearTaskQueue):
(MockWebSpeechRecognizer::StepTask::runIfValid):
- DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
(MockWebSpeechRecognizer):
LayoutTests:
Layout test for checking that calling start on an already started
SpeechRecognition object throws an exception.
- fast/speech/scripted/start-exception-expected.txt: Added.
- fast/speech/scripted/start-exception.html: Added.
- 11:19 Changeset [124224] by
-
nrwt: move handling the initial list of tests to skip to finder
https://bugs.webkit.org/show_bug.cgi?id=92701
Reviewed by Ryosuke Niwa.
More refactoring of manager ...
- Scripts/webkitpy/layout_tests/controllers/finder.py:
(LayoutTestFinder.skip_tests):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._collect_tests):
(Manager.prepare_lists_and_print_output):
- 11:16 Changeset [124223] by
-
Unreviewed, rolling out r124207.
http://trac.webkit.org/changeset/124207
https://bugs.webkit.org/show_bug.cgi?id=92773
Patch causes crashes on the 64-bit debug builder (and other
builders likely) (Requested by zdobersek on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31
Source/WebCore:
- GNUmakefile.am:
- GNUmakefile.list.am:
- platform/text/gtk/TextCheckerEnchant.cpp: Removed.
- platform/text/gtk/TextCheckerEnchant.h: Removed.
Source/WebKit/gtk:
- webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(createEnchantBrokerIfNeeded):
(freeSpellCheckingLanguage):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(wordEndIsAContractionApostrophe):
(checkSpellingOfString):
(getGuessesForWord):
(getAvailableDictionariesCallback):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):
- 11:13 Changeset [124222] by
-
[Chromium] transforms/3d/point-mapping/3d-point-mapping-*.html failing on Win
https://bugs.webkit.org/show_bug.cgi?id=92707
Unreviewed, updating expectations after r124052.
For efficiency's sake, ScrollbarLayerChromium doesn't draw the top and
bottom part of the track differently on "native" scrollbars. This
changes the way the mock Windows scrollbars look in tests.
- platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Removed.
- platform/chromium-win-xp/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Removed.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
- platform/chromium/TestExpectations:
- 10:43 Changeset [124221] by
-
inspector/profiler/heap-snapshot-containment-show-all.html test crashing during WebView closing
<rdar://problem/11991881>
- platform/mac-lion/Skipped: Added inspector/debugger/debugger-expand-scope.html to skip list.
- 10:42 Changeset [124220] by
-
[WK2] Kill the concept of secondary shared process
https://bugs.webkit.org/show_bug.cgi?id=92676
Reviewed by Sam Weinig.
- MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Update Windows build fix.
Don't create a new context for every view.
- 10:26 Changeset [124219] by
-
[Chromium] Don't use ninja for building Chromium for Android
https://bugs.webkit.org/show_bug.cgi?id=92764
Reviewed by Adam Barth.
When Ninja projects files are generated (which will be done for Android),
make sure that the Android builder doesn't unintentionally switch to
using Ninja. We should make that switch at a predetermined time.
- Scripts/webkitdirs.pm:
(buildChromium):
- 10:21 Changeset [124218] by
-
Send an onContextMenu event to the page content
so that context menus can be prevented. We use
the node's event handler because we want to use
the fat finger's node. If we use the EventHandler's
sendContextMenuEvent it will hit test with the mouse
position which may not be what we want.
PR #184032
https://bugs.webkit.org/show_bug.cgi?id=92766
Patch by Genevieve Mak <gmak@rim.com> on 2012-07-31
Reviewed by Antonio Gomes.
Reviewed Internally by Antonio Gomes.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::contextNode):
- 10:16 Changeset [124217] by
-
[GStreamer] Live stream support is weak
https://bugs.webkit.org/show_bug.cgi?id=90084
Reviewed by Martin Robinson.
Make sure on-disk buffering is disabled for live streams. It is
enabled initially when loading any remote media file if preload is
set to Auto. Later on if the player detects that the media is live
it disables on-disk buffering. This patch also adds support for
caching the total size of the media.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load): Keep track of the
media url as an instance attribute.
(WebCore::MediaPlayerPrivateGStreamer::duration): Logging improvement.
(WebCore::MediaPlayerPrivateGStreamer::setRate): use the new
isLiveStream() method.
(WebCore::MediaPlayerPrivateGStreamer::buffered): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Indicate
source of duration message.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Perform an
anonymous duration change emission, mostly to cache its value.
(WebCore::MediaPlayerPrivateGStreamer::totalBytes): Return
cached size when available.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Use the new
isLiveStream() method and handle state change corner cases for live streams.
(WebCore::MediaPlayerPrivateGStreamer::durationChanged): Cache
media total size and re-enable on-disk buffering if caching succeeds.
(WebCore::MediaPlayerPrivateGStreamer::movieLoadType): New
implementation handling on-disk buffered and live streaming cases.
(WebCore::MediaPlayerPrivateGStreamer::setPreload): Remember the
case where preload is updated from Auto to another value, do
on-disk buffering only for Auto preload attribute.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::isLiveStream): Utility
method, a stream is live if it goes to PAUSE without prerolling.
- 10:02 Changeset [124216] by
-
[Qt][WK2] Unreviewed gardening, last attempt to paint the WK2 bot green today.
- platform/qt-5.0-wk2/Skipped: Skip a failing test.
- platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
- platform/qt/Skipped:
- 09:42 Changeset [124215] by
-
Add a mechanism to dump the stack trace in case of a crash
https://bugs.webkit.org/show_bug.cgi?id=92666
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31
Reviewed by Csaba Osztrogonác.
Source/WTF:
Unix based ports can make use of signal handlers to dump the stack
trace in case of a crash. This is specially handy when a test crashes on
the bot without hitting an assertion, we might have a chance to see
some insightful information at the reports.
- wtf/Assertions.cpp:
- wtf/Assertions.h:
Tools:
Move crash signal handlers to WTFInstallReportBacktraceOnCrashHook()
and eliminate some duplicated code.
- DumpRenderTree/qt/main.cpp:
(main):
- WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::InjectedBundle::platformInitialize):
- 09:21 Changeset [124214] by
-
[Blackberry][FullScreen] HTML5 <video> controls are scaled differently depending on the current webpage scale
https://bugs.webkit.org/show_bug.cgi?id=90884
PR #162839
Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
The way the BlackBerry port implements the FULLSCREEN_API for media
elements might result in the controls being oversized, proportionally
to the current page scale. That happens because the fullscreen element
gets sized to be as big as the viewport size, and the viewport size might
get outstretched to fit to the screen dimensions.
In order to fix that, the patch strips out the Page scale factor from
the media controls multiplier.
Patch also changes many integer-based calculations to be float-based, in
order to get the needed precision.
Internally reviewed by Jacky Jiang.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::determineFullScreenMultiplier):
(WebCore::RenderThemeBlackBerry::adjustSliderThumbSize):
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::adjustSliderTrackStyle):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
- 09:10 Changeset [124213] by
-
Remove the clone() method from FilterOperation (and subclasses).
https://bugs.webkit.org/show_bug.cgi?id=92757
Reviewed by Kentaro Hara.
Since the move to WebFilterOperation in Chromium, this is now dead
code.
Covered by existing tests in css3/filters.
- platform/graphics/filters/CustomFilterOperation.h:
- platform/graphics/filters/FilterOperation.h:
- 09:08 Changeset [124212] by
-
Regression(r124135): SVG tests crashing on ports using Cairo
https://bugs.webkit.org/show_bug.cgi?id=92752
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31
Reviewed by Martin Robinson.
- platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::operator=):
- 09:05 Changeset [124211] by
-
Unreviewed, rolling out r124208.
http://trac.webkit.org/changeset/124208
https://bugs.webkit.org/show_bug.cgi?id=92765
it broke compilation on mac (Requested by loislo on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
- inspector/MemoryInstrumentationImpl.cpp: Removed.
- inspector/MemoryInstrumentationImpl.h: Removed.
- 09:02 Changeset [124210] by
-
xmlserializer strips xlink from xlink:html svg image tag
https://bugs.webkit.org/show_bug.cgi?id=79586
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Adding code to ensure the correct prefix on attributes in the xml,
xmlns and xlink namespaces. We now follow the rules in
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#serializing-html-fragments
(circa the time of this change).
Rob Buis wrote the original test for this patch and did the initial work.
Tests: fast/dom/XMLSerializer-xml-namespace.html
svg/custom/xlink-prefix-in-attributes.html
- editing/MarkupAccumulator.cpp:
(WebCore::attributeIsInSerializedNamespace): Test for an attribute in
a specially serialized namespace: xml, xmlns, xlink.
(WebCore):
(WebCore::MarkupAccumulator::appendAttribute): Check the namespace of
attributes upon serialization, and add any necessary prefixes.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::adjustForeignAttributes): Use WTF::xmlAtom etc for AtomicString arguments.
Source/WTF:
Add WTF::xlinkAtom as a global AtomicString constant.
- wtf/text/AtomicString.h:
(WTF): Add xlinkAtom.
- wtf/text/StringStatics.cpp:
(WTF): Add xlinkAtom.
(WTF::AtomicString::init): Add xlinkAtom.
LayoutTests:
Adding code to ensure the correct prefix on attributes in the xml,
xmlns and xlink namespaces. We now follow the rules in
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#serializing-html-fragments
(circa the time of this change).
Rob Buis wrote the original test for this patch and did the initial work.
- editing/pasteboard/paste-noscript-svg-expected.txt: Updated.
- fast/dom/XMLSerializer-xml-namespace-expected.txt: Added.
- fast/dom/XMLSerializer-xml-namespace.html: Added. Tests serializing attributes with the xml namespace.
- svg/custom/xlink-prefix-in-attributes-expected.txt: Added.
- svg/custom/xlink-prefix-in-attributes.html: Added. Tests serializing attributes in the xmlns and xlink namespaces.
- 08:55 Changeset [124209] by
-
skia: switch to conical gradient to match css/svg spec for two-point gradients
https://bugs.webkit.org/show_bug.cgi?id=92754
Reviewed by Stephen White.
Source/WebCore:
Switching to skia's TwoPointConical gradient, which has been written explicitly to match the css/svg spec.
Leaving the existing TwoPointRadial gradient in skia, for other callers that may want the old behavior.
No new tests. existing layouttests exercise this change (9 pending rebaselines associated with this CL).
- platform/graphics/skia/GradientSkia.cpp:
(WebCore::Gradient::platformGradient):
LayoutTests:
Update expectations to rebaseline 9 images after this change lands
- platform/chromium/TestExpectations:
- 08:53 Changeset [124208] by
-
Web Inspector: extract MemoryInstrumentationImpl into separate files for future reusing in unit tests
https://bugs.webkit.org/show_bug.cgi?id=92751
Reviewed by Yury Semikhatsky.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
- inspector/MemoryInstrumentationImpl.cpp: Added.
(WebCore):
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::processDeferredInstrumentedPointers):
(WebCore::MemoryInstrumentationImpl::countObjectSize):
(WebCore::MemoryInstrumentationImpl::deferInstrumentedPointer):
(WebCore::MemoryInstrumentationImpl::visited):
(WebCore::MemoryInstrumentationImpl::selfSize):
- inspector/MemoryInstrumentationImpl.h: Added.
(WebCore):
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::totalTypeSize):
- 08:51 Changeset [124207] by
-
[GTK] Add a new and reusable enchant-based spellchecker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=90269
Reviewed by Martin Robinson.
Source/WebCore:
Move enchant specific code down to WebCore, into a new class
TextCheckerEnchant, that we can use from WK1 and WK2.
- GNUmakefile.am: Add flags to handle the SPELLCHECK feature.
- GNUmakefile.list.am: Added new files.
- platform/text/gtk/TextCheckerEnchant.cpp: Added.
(getAvailableDictionariesCallback):
(TextCheckerEnchant::TextCheckerEnchant):
(TextCheckerEnchant::~TextCheckerEnchant):
(TextCheckerEnchant::ignoreWord):
(TextCheckerEnchant::learnWord):
(TextCheckerEnchant::checkSpellingOfString):
(TextCheckerEnchant::getGuessesForWord):
(TextCheckerEnchant::updateSpellCheckingLanguages):
(TextCheckerEnchant::freeEnchantBrokerDictionaries):
- platform/text/gtk/TextCheckerEnchant.h: Added.
(WebCore):
(TextCheckerEnchant):
(WebCore::TextCheckerEnchant::create):
Source/WebKit/gtk:
Remove enchant specific code from WebKitSpellCheckerEnchant and
implement it relying in the new TextCheckerEnchant class in WebCore.
- webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(checkSpellingOfString):
(getGuessesForWord):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):
- 08:44 Changeset [124206] by
-
[Chromium] Unreviewed, rebaseline fast/ruby/overhang-horizontal.html.
- platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Added.
- platform/chromium/TestExpectations:
- 08:41 Changeset [124205] by
-
[BlackBerry] Support Negotiate auth
https://bugs.webkit.org/show_bug.cgi?id=91871
Patch by Joe Mason <jmason@rim.com> on 2012-07-31
Reviewed by George Staikos.
Add Negotiate to the list of auth schemes allowed in the platform request.
Add "success" and "requireCredentials" parameters to notifyAuthReceived (which is now called
with success = true on successful authentication, as well as on failures).
When success is true, update the stored credential to use the auth scheme actually reported
rather than that set in the request. (This is used when Negotiate auth can't get a ticket
and falls back to a different supported auth type.)
When requireCredentials is false, just set the auth type and start a new request using empty
credentials.
RIM PR# 166514
Internally reviewed by Jonathan Dong
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived): Add Negotiate to the auth scheme switch. Handle
success param by updating auth type in stored credentials; pass requireCredentials param on
to sendRequestWithCredentials.
(WebCore::NetworkJob::startNewJobWithRequest): Fix typo in increaseRedirectCount parameter
name.
(WebCore::NetworkJob::sendRequestWithCredentials): Use empty credentials if
requireCredentials is false.
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob): Add Negotiate to the auth scheme switch.
- 08:37 Changeset [124204] by
-
[Qt] Unreviewed gardening, skip new failing tests.
- platform/qt/Skipped:
- platform/qt/TestExpectations:
- 08:20 Changeset [124203] by
-
[Qt][WK2] Unreviewed gardening. Skip failing tests and remove unnecessary expected files. (bug85203)
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Removed.
- platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/dynamic/008-expected.png: Removed.
- platform/qt-5.0-wk2/fast/dynamic/008-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/parser/entity-comment-in-textarea-expected.png: Removed.
- platform/qt-5.0-wk2/fast/parser/entity-comment-in-textarea-expected.txt: Removed.
- platform/qt-5.0-wk2/fast/parser/open-comment-in-textarea-expected.png: Removed.
- platform/qt-5.0-wk2/fast/parser/open-comment-in-textarea-expected.txt: Removed.
- 08:15 Changeset [124202] by
-
[Chromium] Unreviewed, rebaseline some platform/chromium/virtual/gpu/fast/canvas tests due to antialiasing changes.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png:
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png:
- platform/chromium/TestExpectations:
- 08:05 Changeset [124201] by
-
Web Inspector: take into account the whole security origin instead of just host
https://bugs.webkit.org/show_bug.cgi?id=92740
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-31
Reviewed by Pavel Feldman.
Source/WebCore:
Make the DOM Storage Agent take into account all the
information relevant to the security origin, i.e. protocol, host, and
port. Previously only the host was taken into account. That caused
inspector to show the first storage only in the case a page operated
over several security origins sharing the same host (but having
different protocols e.g. http and https).
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
- inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::isSameOriginAndType):
(WebCore::InspectorDOMStorageResource::bind):
- inspector/InspectorDOMStorageResource.h:
(InspectorDOMStorageResource):
LayoutTests:
- http/tests/inspector-enabled/dom-storage-open-expected.txt:
- 07:41 Changeset [124200] by
-
[WK2] Visible content rect update with null trajectory vector does not reach the backing store
https://bugs.webkit.org/show_bug.cgi?id=92750
Reviewed by Jocelyn Turcotte.
Make sure that notifications with a null trajectory vector reach the backing store
since a null vector means that all tiles around the viewport were requested.
- WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::setVisibleContentsRect):
- 07:35 Changeset [124199] by
-
[BlackBerry] Backing store output flickers when using WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=90291
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-31
Reviewed by Antonio Gomes.
The backing store doesn't know when the API client swaps the buffers,
so it doesn't know when to signal the blit generation condition
variable. Fixed by using EGL fence sync instead, when available, so we
don't have to know.
Reviewed internally by Filip Spacek.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
- Api/BackingStore_p.h:
(BackingStorePrivate):
- WebKitSupport/BackingStoreTile.cpp:
(BlackBerry::WebKit::TileBuffer::TileBuffer):
- WebKitSupport/BackingStoreTile.h:
(BlackBerry::WebKit::TileBuffer::syncObject):
(BlackBerry::WebKit::TileBuffer::setSyncObject):
(TileBuffer):
- WebKitSupport/SurfacePool.cpp:
(WebKit):
(BlackBerry::WebKit::SurfacePool::SurfacePool):
(BlackBerry::WebKit::SurfacePool::initialize):
(BlackBerry::WebKit::SurfacePool::waitForBuffer):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
- WebKitSupport/SurfacePool.h:
(SurfacePool):
- 06:50 Changeset [124198] by
-
Slider ticks are drawn at wrong positions
https://bugs.webkit.org/show_bug.cgi?id=92720
Reviewed by Kent Tamura.
Source/WebCore:
Slider tick marks for vertical sliders were drawn reversed. And the tick
mark positions were slightly off from the thumb position because of rounding.
No new tests. Covered in input-appearance-range-with-datalist.html.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):
LayoutTests:
- fast/forms/datalist/input-appearance-range-with-datalist.html: Added values to input elements so we can see if the slider thumb position matches with the tick marks.
- platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
- platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
- platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
- platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
- platform/chromium/TestExpectations:
- 06:42 Changeset [124197] by
-
[Qt] Input method update should also include hints
https://bugs.webkit.org/show_bug.cgi?id=92744
Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-07-31
Reviewed by Simon Hausmann.
The QInputMethod is told to query for input method hints when updated.
- UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::updateTextInputState):
- 06:15 Changeset [124196] by
-
Older ShadowDOM is still rendered when a new ShadowDOM is added when they don't have any InsertionPoints.
https://bugs.webkit.org/show_bug.cgi?id=92456
Reviewed by Hajime Morita.
Source/WebCore:
When adding a new ShadowRoot to an element having other ShadowRoots, and they don't have any InsretionPoint,
the older ShadowDOM is still rendered.
When ContentDistributor's validity is 'Undetermined', ElementShadow reattaches the host and the whole shadow
subtree. Since adding a new ShadowRoot makes the validity 'Undetermined', we have had to make it 'Undetermined'.
This change enables us to remove a unnecessary InvalidationType flag from the code. We should call
setValidityUndetermined() instead of using InvalidateAndForceReattach.
Test: fast/dom/shadow/invalidate-distribution.html
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): Calls setValidityUndetermined().
(WebCore::ElementShadow::removeAllShadowRoots):
(WebCore::ElementShadow::setValidityUndetermined):
(WebCore::ElementShadow::invalidateDistribution): When validity is undetermined, we will reattach the
host and the shadow subtree.
- dom/ElementShadow.h:
(ElementShadow):
- html/shadow/ContentDistributor.cpp:
- html/shadow/ContentDistributor.h:
(WebCore::ContentDistributor::setValidity):
(ContentDistributor):
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::insertedInto): Calls setValidityUndetermined().
LayoutTests:
- fast/dom/shadow/invalidate-distribution-expected.html: Added.
- fast/dom/shadow/invalidate-distribution.html: Added.
- 06:02 Changeset [124195] by
-
[chromium] move EventSender into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=92277
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/chromium/TestRunner/EventSender.cpp: Renamed from Tools/DumpRenderTree/chromium/EventSender.cpp.
- DumpRenderTree/chromium/TestRunner/EventSender.h: Renamed from Tools/DumpRenderTree/chromium/EventSender.h.
- DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
(TestInterfaces::Internal::eventSender):
(TestInterfaces::Internal):
(TestInterfaces::Internal::Internal):
(TestInterfaces::Internal::~Internal):
(TestInterfaces::Internal::setWebView):
(TestInterfaces::Internal::setDelegate):
(TestInterfaces::Internal::bindTo):
(TestInterfaces::Internal::resetAll):
(TestInterfaces::eventSender):
- DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::eventSender):
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
- 05:57 Changeset [124194] by
-
[Qt] Unreviewed gardening, remove unnecessary expected files.
- platform/qt-5.0/fast/css/beforeSelectorOnCodeElement-expected.txt: Removed.
- platform/qt-5.0/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Removed.
- platform/qt-5.0/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
- platform/qt-5.0/fast/dynamic/008-expected.png: Removed.
- platform/qt-5.0/fast/dynamic/008-expected.txt: Removed.
- platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.png: Removed.
- platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Removed.
- platform/qt-5.0/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Removed.
- 04:59 Changeset [124193] by
-
Introduce a minimal RTCPeerConnection together with Dictionary changes
https://bugs.webkit.org/show_bug.cgi?id=92380
Reviewed by Kentaro Hara.
Source/WebCore:
This patch introduces a shell RTCPeerConnection together with neccecary changes to
Dictionary.
The W3C specification can be found here:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#rtcpeerconnection
Since Dictionaries can't be fully copied around adding
get(const String& name, Vector<Dictionary>& result)
isn't feasible so I have added a new ArrayValue class.
Test: fast/mediastream/RTCPeerConnection.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/DOMWindowMediaStream.idl:
- Modules/mediastream/RTCPeerConnection.cpp: Added.
(WebCore):
(RTCIceServer):
(WebCore::RTCIceServer::create):
(WebCore::RTCIceServer::~RTCIceServer):
(WebCore::RTCIceServer::uri):
(WebCore::RTCIceServer::credential):
(WebCore::RTCIceServer::RTCIceServer):
(RTCConfiguration):
(WebCore::RTCConfiguration::create):
(WebCore::RTCConfiguration::~RTCConfiguration):
(WebCore::RTCConfiguration::appendServer):
(WebCore::RTCConfiguration::numberOfServers):
(WebCore::RTCConfiguration::server):
(WebCore::RTCConfiguration::RTCConfiguration):
(WebCore::RTCPeerConnection::parseConfiguration):
(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::interfaceName):
(WebCore::RTCPeerConnection::scriptExecutionContext):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::eventTargetData):
(WebCore::RTCPeerConnection::ensureEventTargetData):
- Modules/mediastream/RTCPeerConnection.h: Added.
(WebCore):
(RTCPeerConnection):
(WebCore::RTCPeerConnection::refEventTarget):
(WebCore::RTCPeerConnection::derefEventTarget):
- Modules/mediastream/RTCPeerConnection.idl: Added.
- Target.pri:
- UseJSC.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitRTCPeerConnectionEnabled):
- bindings/js/ArrayValue.cpp: Added.
(WebCore):
(WebCore::ArrayValue::ArrayValue):
(WebCore::ArrayValue::operator=):
(WebCore::ArrayValue::isUndefinedOrNull):
(WebCore::ArrayValue::length):
(WebCore::ArrayValue::get):
- bindings/js/ArrayValue.h: Added.
(WebCore):
(ArrayValue):
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
(WebCore):
- bindings/js/JSDictionary.h:
(WebCore):
- bindings/v8/ArrayValue.cpp: Added.
(WebCore):
(WebCore::ArrayValue::operator=):
(WebCore::ArrayValue::isUndefinedOrNull):
(WebCore::ArrayValue::length):
(WebCore::ArrayValue::get):
- bindings/v8/ArrayValue.h: Added.
(WebCore):
(ArrayValue):
(WebCore::ArrayValue::ArrayValue):
(WebCore::ArrayValue::~ArrayValue):
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
(WebCore):
- bindings/v8/Dictionary.h:
(WebCore):
(Dictionary):
- dom/EventTargetFactory.in:
LayoutTests:
- fast/mediastream/RTCPeerConnection-expected.txt: Added.
- fast/mediastream/RTCPeerConnection.html: Added.
- 04:28 Changeset [124192] by
-
[Qt][EFL] New inspector/styles/region-style-crash.html introduced in r124186 fails
https://bugs.webkit.org/show_bug.cgi?id=91503
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-31
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 04:27 Changeset [124191] by
-
[Qt] Unreviewed gardening after r124189, remove unnecessary expected files.
- platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt.
- platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Removed.
- platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Removed.
- platform/qt-5.0/fast/images/object-image-expected.txt: Added.
- platform/qt-5.0/fast/parser/entity-comment-in-textarea-expected.png: Removed.
- platform/qt-5.0/fast/parser/entity-comment-in-textarea-expected.txt: Removed.
- platform/qt-5.0/fast/parser/open-comment-in-textarea-expected.png: Removed.
- platform/qt-5.0/fast/parser/open-comment-in-textarea-expected.txt: Removed.
- platform/qt-5.0/fast/repaint/continuation-after-outline-expected.txt: Removed.
- platform/qt-5.0/fast/replaced/three-selects-break-expected.png: Removed.
- platform/qt-5.0/fast/replaced/three-selects-break-expected.txt: Removed.
- platform/qt-5.0/fast/writing-mode/fallback-orientation-expected.txt: Removed.
- platform/qt-5.0/fast/xsl/document-function-expected.png: Removed.
- platform/qt-5.0/fast/xsl/document-function-expected.txt: Removed.
- platform/qt-5.0/fast/xsl/xslt-entity-expected.png: Removed.
- platform/qt-5.0/fast/xsl/xslt-entity-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Removed.
- platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Removed.
- 03:46 Changeset [124190] by
-
Unreviewed. Update watchlist
- Scripts/webkitpy/common/config/watchlist: Turned out to be less useful than I had hoped
- 03:33 Changeset [124189] by
-
[Qt] Unreviewed gardening. Unskip passing tests and add new expected files. (bug85203)
- platform/qt-5.0/Skipped: Unskip passing tests.
- platform/qt/Skipped: Skip the remaining failing tests and add bug reports.
- platform/qt/css2.1/t040103-ident-03-c-expected.png: Added.
- platform/qt/css2.1/t040103-ident-03-c-expected.txt: Added.
- platform/qt/editing/pasteboard/4242293-1-expected.txt:
- platform/qt/editing/pasteboard/5761530-1-expected.txt: Added.
- platform/qt/fast/backgrounds/mask-box-image-expected.png:
- platform/qt/fast/backgrounds/mask-box-image-expected.txt:
- platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png: Copied from LayoutTests/platform/qt/fast/invalid/020-expected.png.
- platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
- platform/qt/fast/backgrounds/svg-as-mask-expected.png:
- platform/qt/fast/backgrounds/svg-as-mask-expected.txt:
- platform/qt/fast/block/positioning/051-expected.png:
- platform/qt/fast/block/positioning/051-expected.txt:
- platform/qt/fast/compact/003-expected.png:
- platform/qt/fast/compact/003-expected.txt:
- platform/qt/fast/css-generated-content/010-expected.png:
- platform/qt/fast/css-generated-content/010-expected.txt:
- platform/qt/fast/css-grid-layout/place-cell-by-index-expected.txt: Added.
- platform/qt/fast/css/font-face-descending-unicode-range-expected.txt:
- platform/qt/fast/css/font-face-font-family-descriptor-expected.txt:
- platform/qt/fast/css/imageTileOpacity-expected.png:
- platform/qt/fast/css/imageTileOpacity-expected.txt:
- platform/qt/fast/css/live-cssrules-expected.png:
- platform/qt/fast/css/live-cssrules-expected.txt:
- platform/qt/fast/css/rgba-custom-text-expected.txt: Added.
- platform/qt/fast/css/rtl-to-viewport-expected.png:
- platform/qt/fast/css/rtl-to-viewport-expected.txt:
- platform/qt/fast/css/vertical-align-lengths-expected.png:
- platform/qt/fast/css/vertical-align-lengths-expected.txt:
- platform/qt/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png:
- platform/qt/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt:
- platform/qt/fast/dom/HTMLHeadElement/textInHead1-expected.png:
- platform/qt/fast/dom/HTMLHeadElement/textInHead1-expected.txt:
- platform/qt/fast/dom/HTMLHeadElement/textInHead2-expected.png:
- platform/qt/fast/dom/HTMLHeadElement/textInHead2-expected.txt:
- platform/qt/fast/dom/HTMLHeadElement/textInHead3-expected.png:
- platform/qt/fast/dom/HTMLHeadElement/textInHead3-expected.txt:
- platform/qt/fast/dom/HTMLHeadElement/textInHead4-expected.png:
- platform/qt/fast/dom/HTMLHeadElement/textInHead4-expected.txt:
- platform/qt/fast/dom/HTMLHeadElement/textInHead5-expected.png:
- platform/qt/fast/dom/HTMLHeadElement/textInHead5-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
- platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png:
- platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
- platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png:
- platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt:
- platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png:
- platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt:
- platform/qt/fast/dom/comment-not-documentElement-expected.png:
- platform/qt/fast/dom/comment-not-documentElement-expected.txt:
- platform/qt/fast/dom/icon-url-change-expected.txt: Added.
- platform/qt/fast/dom/icon-url-list-expected.txt: Added.
- platform/qt/fast/dynamic/010-expected.png:
- platform/qt/fast/dynamic/010-expected.txt:
- platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png.
- platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt:
- platform/qt/fast/dynamic/genContentDestroyChildren-expected.png: Added.
- platform/qt/fast/dynamic/genContentDestroyChildren-expected.txt:
- platform/qt/fast/dynamic/move-node-with-selection-expected.png:
- platform/qt/fast/dynamic/move-node-with-selection-expected.txt:
- platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.png:
- platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
- platform/qt/fast/html/details-add-summary-1-expected.png:
- platform/qt/fast/html/details-add-summary-1-expected.txt:
- platform/qt/fast/html/details-add-summary-10-expected.png:
- platform/qt/fast/html/details-add-summary-10-expected.txt:
- platform/qt/fast/html/details-add-summary-2-expected.png:
- platform/qt/fast/html/details-add-summary-2-expected.txt:
- platform/qt/fast/html/details-add-summary-3-expected.png:
- platform/qt/fast/html/details-add-summary-3-expected.txt:
- platform/qt/fast/html/details-add-summary-4-expected.png:
- platform/qt/fast/html/details-add-summary-4-expected.txt:
- platform/qt/fast/html/details-add-summary-5-expected.png:
- platform/qt/fast/html/details-add-summary-5-expected.txt:
- platform/qt/fast/html/details-add-summary-6-expected.png:
- platform/qt/fast/html/details-add-summary-6-expected.txt:
- platform/qt/fast/html/details-add-summary-7-expected.png:
- platform/qt/fast/html/details-add-summary-7-expected.txt:
- platform/qt/fast/html/details-add-summary-8-expected.png:
- platform/qt/fast/html/details-add-summary-8-expected.txt:
- platform/qt/fast/html/details-add-summary-9-expected.png:
- platform/qt/fast/html/details-add-summary-9-expected.txt:
- platform/qt/fast/html/details-no-summary1-expected.png:
- platform/qt/fast/html/details-no-summary1-expected.txt:
- platform/qt/fast/html/details-no-summary2-expected.png:
- platform/qt/fast/html/details-no-summary2-expected.txt:
- platform/qt/fast/html/details-no-summary3-expected.png:
- platform/qt/fast/html/details-no-summary3-expected.txt:
- platform/qt/fast/html/details-open1-expected.png:
- platform/qt/fast/html/details-open1-expected.txt:
- platform/qt/fast/html/details-open3-expected.png:
- platform/qt/fast/html/details-open3-expected.txt:
- platform/qt/fast/html/details-open5-expected.png:
- platform/qt/fast/html/details-open5-expected.txt:
- platform/qt/fast/html/details-open6-expected.png:
- platform/qt/fast/html/details-open6-expected.txt:
- platform/qt/fast/html/details-remove-summary-1-expected.png:
- platform/qt/fast/html/details-remove-summary-1-expected.txt:
- platform/qt/fast/html/details-remove-summary-2-expected.png:
- platform/qt/fast/html/details-remove-summary-2-expected.txt:
- platform/qt/fast/html/details-remove-summary-3-expected.png:
- platform/qt/fast/html/details-remove-summary-3-expected.txt:
- platform/qt/fast/html/details-remove-summary-4-expected.png:
- platform/qt/fast/html/details-remove-summary-4-expected.txt:
- platform/qt/fast/html/details-remove-summary-5-expected.png:
- platform/qt/fast/html/details-remove-summary-5-expected.txt:
- platform/qt/fast/html/details-remove-summary-6-expected.png:
- platform/qt/fast/html/details-remove-summary-6-expected.txt:
- platform/qt/fast/images/image-in-map-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
- platform/qt/fast/images/image-in-map-expected.txt:
- platform/qt/fast/inline/002-expected.png: Copied from LayoutTests/platform/qt/fast/dynamic/010-expected.png.
- platform/qt/fast/inline/002-expected.txt:
- platform/qt/fast/inline/inline-fixed-position-boundingbox-expected.txt: Added.
- platform/qt/fast/inline/inline-relative-offset-boundingbox-expected.txt: Added.
- platform/qt/fast/inline/positioned-object-between-replaced-elements-expected.txt:
- platform/qt/fast/inline/positionedLifetime-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/continuation-after-outline-expected.png.
- platform/qt/fast/inline/positionedLifetime-expected.txt:
- platform/qt/fast/invalid/005-expected.png: Copied from LayoutTests/platform/qt/fast/dom/comment-not-documentElement-expected.png.
- platform/qt/fast/invalid/005-expected.txt:
- platform/qt/fast/invalid/007-expected.png: Copied from LayoutTests/platform/qt/fast/html/details-remove-summary-6-expected.png.
- platform/qt/fast/invalid/007-expected.txt:
- platform/qt/fast/invalid/020-expected.png:
- platform/qt/fast/invalid/020-expected.txt:
- platform/qt/fast/lists/004-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png.
- platform/qt/fast/lists/004-expected.txt:
- platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png.
- platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
- platform/qt/fast/lists/ol-start-dynamic-expected.png: Copied from LayoutTests/platform/qt/fast/html/details-no-summary2-expected.png.
- platform/qt/fast/lists/ol-start-dynamic-expected.txt:
- platform/qt/fast/multicol/hit-test-gap-between-pages-expected.txt: Added.
- platform/qt/fast/multicol/table-vertical-align-expected.txt:
- platform/qt/fast/multicol/vertical-rl/rule-style-expected.txt:
- platform/qt/fast/parser/tabs-in-scripts-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png.
- platform/qt/fast/parser/tabs-in-scripts-expected.txt:
- platform/qt/fast/reflections/reflection-direction-expected.png: Added.
- platform/qt/fast/reflections/reflection-direction-expected.txt:
- platform/qt/fast/reflections/reflection-masks-expected.png: Added.
- platform/qt/fast/reflections/reflection-masks-expected.txt:
- platform/qt/fast/reflections/reflection-masks-opacity-expected.png: Added.
- platform/qt/fast/reflections/reflection-masks-opacity-expected.txt:
- platform/qt/fast/repaint/block-no-inflow-children-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png.
- platform/qt/fast/repaint/block-no-inflow-children-expected.txt:
- platform/qt/fast/repaint/button-spurious-layout-hint-expected.txt:
- platform/qt/fast/repaint/clip-with-layout-delta-expected.txt:
- platform/qt/fast/repaint/continuation-after-outline-expected.png:
- platform/qt/fast/repaint/continuation-after-outline-expected.txt:
- platform/qt/fast/repaint/float-overflow-expected.png:
- platform/qt/fast/repaint/float-overflow-expected.txt:
- platform/qt/fast/repaint/float-overflow-right-expected.png:
- platform/qt/fast/repaint/float-overflow-right-expected.txt:
- platform/qt/fast/repaint/gradients-em-stops-repaint-expected.png:
- platform/qt/fast/repaint/gradients-em-stops-repaint-expected.txt:
- platform/qt/fast/repaint/iframe-scroll-repaint-expected.txt:
- platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png.
- platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt:
- platform/qt/fast/repaint/lines-with-layout-delta-expected.png:
- platform/qt/fast/repaint/lines-with-layout-delta-expected.txt:
- platform/qt/fast/repaint/reflection-repaint-test-expected.png:
- platform/qt/fast/repaint/reflection-repaint-test-expected.txt:
- platform/qt/fast/repaint/repaint-svg-after-style-change-expected.png: Copied from LayoutTests/platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.png.
- platform/qt/fast/repaint/repaint-svg-after-style-change-expected.txt:
- platform/qt/fast/repaint/selection-clear-expected.png:
- platform/qt/fast/repaint/selection-clear-expected.txt:
- platform/qt/fast/repaint/transform-layout-repaint-expected.png:
- platform/qt/fast/repaint/transform-layout-repaint-expected.txt:
- platform/qt/fast/replaced/image-onload-expected.png:
- platform/qt/fast/replaced/image-onload-expected.txt:
- platform/qt/fast/runin/002-expected.png:
- platform/qt/fast/runin/002-expected.txt:
- platform/qt/fast/runin/generated4-expected.png:
- platform/qt/fast/runin/generated4-expected.txt:
- platform/qt/svg/custom/use-instanceRoot-event-listeners-expected.txt: Added.
- 03:22 Changeset [124188] by
-
Unreviewed, update watchlist
- Scripts/webkitpy/common/config/watchlist:
- Improve "Forms" filename pattern.
- tkent stops watching Chromium DRT. It was not so helpful.
- 03:20 Changeset [124187] by
-
[Chromium] Unreviewed, handle more tests failing after r124052.
- platform/chromium/TestExpectations:
- 03:08 Changeset [124186] by
-
Inspector crashes when trying to inspect a page with CSS region styling
https://bugs.webkit.org/show_bug.cgi?id=91503
Patch by Raul Hudea <rhudea@adobe.com> on 2012-07-31
Reviewed by Alexander Pavlov.
Source/WebCore:
Fix by making sure a CSSRuleSourceData is always created when parsing @-webkit-region rules.
Test: inspector/styles/region-style-crash.html
- css/CSSGrammar.y: Made ruleset called explicitly markRuleBodyStart instead of depending on updateLastSelectorLineAndPosition to call it.
- css/CSSParser.cpp:
(WebCore::CSSParser::updateLastSelectorLineAndPosition): markRuleBodyStart should be called via at_rule_body_start.
- css/CSSPropertySourceData.h:
LayoutTests:
Test to make sure inspector is not crashing when having to parse @-webkit-region rules
- inspector/styles/region-style-crash-expected.txt: Added.
- inspector/styles/region-style-crash.html: Added.
- platform/chromium/TestExpectations:
- 02:41 Changeset [124185] by
-
Unreviewed, rolling out r124179.
http://trac.webkit.org/changeset/124179
https://bugs.webkit.org/show_bug.cgi?id=92730
Breaks Chromium Linux 32 bots with "error: integer constant is
too large for 'long' type" in IDBLevelDBCodingTest.cpp
(Requested by apavlov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31
Source/WebCore:
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeByte):
(WebCore::IDBLevelDBCoding::encodeBool):
(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::encodeDouble):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::KeyPrefix::encode):
- Modules/indexeddb/IDBLevelDBCoding.h:
(IDBLevelDBCoding):
Source/WebKit/chromium:
- tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):
- 02:00 Changeset [124184] by
-
Perf-o-matic: dashboard images are not generated properly from incrementally updated JSON
https://bugs.webkit.org/show_bug.cgi?id=92717
Reviewed by Hajime Morita.
Sort the values by timestamp. Unfortunately, there isn't a good way of testing this fix.
- Websites/webkit-perf.appspot.com/models.py:
(Runs.chart_params):
- 01:53 Changeset [124183] by
-
[jhbuild] Also try to load jhbuild Python module from the source checkout
Reviewed by Philippe Normand.
JHBuild also seems to have an installation mode where it prefers to load its
Python modules from the source checkout. This seems to be used particularly
on the GTK+ 64-bit release bot. We should fall back to this mode.
- jhbuild/jhbuildutils.py:
(enter_jhbuild_environment_if_available): Use the source checkout if there
is no installation path.
- 01:46 Changeset [124182] by
-
add Farstream flags/deps to WebKit, for WebRTC
https://bugs.webkit.org/show_bug.cgi?id=87524
Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2012-07-31
Reviewed by Philippe Normand.
Since Farstream will be used as the backend for GTK's WebRTC, this
patch adds it as a dependency to the build system.
.:
- GNUmakefile.am:
- configure.ac:
Source/WebCore:
No new features or code changes were added, so new tests aren't necessary.
- GNUmakefile.am:
Source/WebKit2:
- GNUmakefile.am:
- 01:09 Changeset [124181] by
-
Unreviewed crash fix after r124135.
- platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::Path): Ensure the Cairo path when acquiring its context,
crashes ensue otherwise.
- 00:58 Changeset [124180] by
-
Change Element::isReadOnlyFormControl to Element::shouldMatchReadOnlySelector/shouldMatchReadWriteSelector or HTMLFormControlElement::readOnly
https://bugs.webkit.org/show_bug.cgi?id=92602
Reviewed by Kent Tamura.
This patch replaces Element::isReadOnlyFormControl() by
Element::shouldMatchReadOnlySelector/shouldMatchReadOnlySelector or
HTMLFormControlElement::readOnly() to make intention of functions
self descriptive.
No new tests. This patch doesn't change behavior.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Replaced isReadOnlyFormControl() by shouldMatchReadOnlySelector() for :read-only pseudo class, and replaced isReadOnlyFormControl() by shouldMatchReadOnlySelector() for :read-only pseudo class.
- dom/Element.cpp:
(WebCore::Element::shouldMatchReadOnlySelector): Added for default implementation.
(WebCore::Element::shouldMatchReadWriteSelector): for default implementation.
- dom/Element.h:
(Element): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::shouldMatchReadOnlySelector): Added.
(WebCore::HTMLFormControlElement::shouldMatchReadWriteSelector): Added.
- html/HTMLFormControlElement.h:
(HTMLFormControlElement): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::shouldMatchReadOnlySelector): Added.
(WebCore::SliderThumbElement::shouldMatchReadWriteSelector): Added.
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SliderThumbElement::willRespondToMouseClickEvents): ditto.
(SliderThumbElement):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents): ditto.
(WebCore::SpinButtonElement::willRespondToMouseClickEvents): ditto.
(WebCore::SpinButtonElement::shouldMatchReadOnlySelector): Added.
(WebCore::SpinButtonElement::shouldMatchReadWriteSelector): Added.
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
- html/shadow/TextControlInnerElements.h:
(SpinButtonElement): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isReadOnlyControl): Replaced isReadOnlyControl() by shouldMatchReadOnlySelector().
- 00:12 Changeset [124179] by
-
IndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString
https://bugs.webkit.org/show_bug.cgi?id=91813
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-07-31
Reviewed by Kentaro Hara.
To avoid memory re-allocation in Vector, init the capability or size of Vector in encodeInt(), encodeVarInt(),
encodeBool(), encodeIDBKey() etc.
No new tests - Low level functions covered by existing layout tests and also covered by Chromium
webkit_unit_tests IDBLevelIDBCodingTest.* which validates the sizes of buffers returned by encodeVarInt.
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):
07/30/12:
- 23:55 Changeset [124178] by
-
[Texmap] Remove the backing store after 'style.visibility' for an element sets 'hidden'.
https://bugs.webkit.org/show_bug.cgi?id=92492
Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-30
Reviewed by Noam Rosenthal.
Source/WebCore:
This patch's purpose is to save vram memory.
When visibility of the element sets hidden, we do not need to draw the element,
so we do not need to keep a texture of the backing store.
Currently, Texmap does not draw the element with visibility:hidden because
RenderLayerBacking::paintIntoLayer does not draw anything.
This patch just removes unused textures.
No new tests - no new testable functionality.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setContentsVisible):
(WebCore):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
- platform/graphics/texmap/TextureMapperLayer.h:
(State):
(WebCore::TextureMapperLayer::State::State):
Source/WebKit2:
Texmap handles visibility:hidden in this patch, so WebGraphicsLayer
sends the LayerTreeCoordinatorProxyMessages with additional infomation
to UIProcess.
- Shared/WebLayerTreeInfo.h:
- UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::setLayerState):
- WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setContentsVisible):
(WebCore):
(WebCore::WebGraphicsLayer::syncLayerState):
- WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.h:
(WebGraphicsLayer):
- 23:52 Changeset [124177] by
-
[GTK] New lines automatically and repeatedly added to list items in Etherpad
https://bugs.webkit.org/show_bug.cgi?id=89971
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-07-30
Reviewed by Ryosuke Niwa.
Disable the deletion UI by default. This UI, which was enabled as a side-effect
of the addition of the private editing API, seems to expose a bug in Etherpad
which causes the continuous insertion of bullet points.
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldShowDeleteInterface): Disable the deletion UI by default.
- 23:41 EFLWebKit edited by
- (diff)
- 23:27 Changeset [124176] by
-
Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075
Reviewed by Kent Tamura.
Source/Platform:
- chromium/public/WebLocalizedString.h: Added OtherColorLabel.
Source/WebCore:
Test: platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html
- rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Added color to types supporting datalist.
Source/WebKit/chromium:
Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController.
ColorChooserUIController can control whether to open the color suggestion picker
popup or the color chooser depending on the responses from ColorChooserClient.
- WebKit.gyp:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser.
(WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium.
- src/ChromeClientImpl.h:
(WebKit):
(ChromeClientImpl):
- src/ColorChooserProxy.cpp: Removed.
- src/ColorChooserProxy.h: Removed.
- src/ColorChooserUIController.cpp: Added.
(WebKit):
(WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient.
(WebKit::ColorChooserUIController::~ColorChooserUIController):
(WebKit::ColorChooserUIController::setSelectedColor):
(WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser.
(WebKit::ColorChooserUIController::didChooseColor):
(WebKit::ColorChooserUIController::didEndChooser):
(WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size.
(WebKit::ColorChooserUIController::writeDocument):
(WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue.
(WebKit::ColorChooserUIController::didClosePopup):
(WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup.
(WebKit::ColorChooserUIController::closePopup):
(WebKit::ColorChooserUIController::openColorChooser): Opens color chooser.
- src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h.
(WebCore):
(WebKit):
(ColorChooserUIController):
- src/WebColorChooserClientImpl.cpp: Removed.
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Added.
- platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Added. Tests color suggestion picker popup appearance.
- platform/chromium/fast/forms/datalist/input-list-expected.txt:
- 23:19 Changeset [124175] by
-
/api/test/runs/chart expires on perf-o-matic
https://bugs.webkit.org/show_bug.cgi?id=92714
Reviewed by Hajime Morita.
Don't update the entire JSON while generating the dashboard images.
This is a bug and not doing this will reduce the server load significantly.
- Websites/webkit-perf.appspot.com/controller.py:
(RunsChartHandler.post):
- 22:46 Changeset [124174] by
-
Unreviewed, rolling out r124171.
http://trac.webkit.org/changeset/124171
https://bugs.webkit.org/show_bug.cgi?id=92712
Start failing fast/css/square-button-appearance.html
(Requested by yosin on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
- dom/Element.cpp:
- dom/Element.h:
(Element):
(WebCore::Element::isReadOnlyFormControl):
- html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::isReadOnlyFormControl):
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::isReadOnlyFormControl):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):
- html/shadow/SliderThumbElement.h:
(SliderThumbElement):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents):
(WebCore::SpinButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
- html/shadow/TextControlInnerElements.h:
(WebCore::SpinButtonElement::isReadOnlyFormControl):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isReadOnlyControl):
- 22:28 Changeset [124173] by
-
[Chromium] Layout Test fast/forms/date/calendar-picker-appearance.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=92710
- fast/forms/date/calendar-picker-appearance.html: Attempt to fix the flakiness.
- platform/chromium/TestExpectations: Add an entry for calendar-picker-appearance.html.
- 21:20 Changeset [124172] by
-
[Chromium] Baseline and expectation followups after r124142.
https://bugs.webkit.org/show_bug.cgi?id=62754
https://bugs.webkit.org/show_bug.cgi?id=80531
http://crbug.com/47826
Unreviewed, test updates.
- platform/chromium-linux-x86/css2.1/20110323: Added.
- platform/chromium-linux-x86/css2.1/20110323/block-replaced-width-001-expected.png: Added.
- platform/chromium-linux-x86/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
- platform/chromium-linux/css2.1/20110323/block-replaced-width-001-expected.png: Added.
- platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.txt: Removed.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png: Added.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
- platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
- platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.png: Added.
- platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
- platform/chromium-win-xp/css2.1/20110323/block-replaced-width-001-expected.png: Added.
- platform/chromium-win/css2.1/20110323/block-replaced-width-001-expected.png: Added.
- platform/chromium-win/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
- platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
- platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
- platform/chromium/TestExpectations:
- 21:19 Changeset [124171] by
-
[CSS] Change Element::isReadOnlyFormControl to shouldMatchReadWriteSelector or HTMLTextFormControlElement::readOnly
https://bugs.webkit.org/show_bug.cgi?id=92602
Reviewed by Kent Tamura.
This patch renames Element::isReadOnlyFormControl() to Element::shouldMatchReadWriteSelector()
or HTMLTextFormControlElement::readOnly() to make intention of
shouldMatchReadWriteSelector(was isReadOnlyFormControl) self descriptive.
No new tests. This patch doesn't change behavior.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
- dom/Element.cpp:
(WebCore::Element::shouldMatchReadWriteSelector): Added default implementation.
- dom/Element.h:
(WebCore::Element::shouldMatchReadWriteSelector): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
- html/HTMLFormControlElement.h:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::shouldMatchReadWriteSelector): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SliderThumbElement::willRespondToMouseClickEvents): ditto.
- html/shadow/SliderThumbElement.h:
(SliderThumbElement): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
- html/shadow/TextControlInnerElements.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isReadOnlyControl): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
- 20:49 Changeset [124170] by
-
[Chromium] Add baseline files for calendar-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=84827
- platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png: Added.
- platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
- platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png: Added.
- platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png: Added.
- platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png: Added.
- platform/chromium/TestExpectations:
- 20:39 Changeset [124169] by
-
Add a proper umbrella header for the public WebKit2 API headers
https://bugs.webkit.org/show_bug.cgi?id=92708
<rdar://problem/11970825>
Reviewed by Dan Bernstein.
Create a new umbrella WebKit2.h and add the currently public (as decided by their
status in Xcode) Objective-C headers.
- UIProcess/API/mac/WebKit2.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
While we are here, make WebKit2_C.h a private header.
- 20:38 Changeset [124168] by
-
Remove overflow: scroll handling in block flow layout methods
https://bugs.webkit.org/show_bug.cgi?id=92689
Reviewed by Simon Fraser.
The overflow: scroll scrollbars creation was done at layout time for all RenderBlocks and
descendants. This was not only wrong ('overflow' only changes at style change time) but it
was also introducing some code duplication.
The gist of this change is to share the code by moving it to RenderLayer::updateScrollbarsAfterStyleChange,
this includes the code from bug 69993 to special case list box part.
Covered by existing tests:
- All fast/overflow ones.
- For the list box change:
fast/forms/select-overflow-scroll-inherited.html
fast/forms/select-overflow-scroll.html
- For the flexbox:
css3/flexbox/preferred-widths-orthogonal.html
css3/flexbox/preferred-widths.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
Removed the common code here.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
Changed to an ASSERT now that the right scrollbars are created. This is
fine as overflow-x/y are physical coordinates and our access was following that.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::invalidateScrollbarRect):
Added an early return here if we are not attached yet as RenderLayer::styleChanged
is called at attachment time before we are inserted in the tree. This is fine as the
scrollbars are part of the object which will be painted after the first layout.
(WebCore::overflowRequiresAScrollbar):
(WebCore::overflowDefinesAutomaticScrollbar):
Split the logic in those 2 functions.
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
Updated to use the require / can-have functions. Also added
an early return for list box parts as required by bug 69993.
(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):
Added an early return for list box parts as required by bug 69993,
also removed some unneeded NULL-checks that were added for list box parts.
- 20:36 Changeset [124167] by
-
Roll out the DEPS roll (r124164) for now since it broke Chromium Mac builds.
- DEPS:
- 20:31 Changeset [124166] by
-
Removed old branch that is no longer needed (according to dglazkov).
- 20:22 Changeset [124165] by
-
Revert r124153 and land the "right" build fix per ap's comment on the bug 92676.
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
- 20:17 Changeset [124164] by
-
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30
- DEPS:
- 20:15 Changeset [124163] by
-
Rename WebKit2.h to WebKit2_C.h
https://bugs.webkit.org/show_bug.cgi?id=92704
Reviewed by Dan Bernstein.
Source/WebKit2:
- GNUmakefile.list.am:
- Target.pri:
- UIProcess/API/C/WebKit2_C.h: Renamed from Source/WebKit2/UIProcess/API/C/WebKit2.h.
- UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
- UIProcess/API/gtk/WebKitPolicyDecisionPrivate.h:
- UIProcess/API/gtk/WebKitPrivate.h:
- UIProcess/API/gtk/WebKitSettingsPrivate.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
Update for changed header file name.
Tools:
- MiniBrowser/mac/MiniBrowser_Prefix.pch:
- MiniBrowser/win/BrowserView.h:
- TestWebKitAPI/config.h:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
- WebKitTestRunner/WebKitTestRunnerPrefix.h:
- WebKitTestRunner/config.h:
Update for changed header file name.
- 20:15 Changeset [124162] by
-
fillWithEmptyClients method should also initialize chromeClient with EmptyChromeClient
https://bugs.webkit.org/show_bug.cgi?id=92703
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-30
Reviewed by Kent Tamura.
fillWithEmptyClients should also intialize PageClients.chromeClient with EmptyChromeClient
as its required for creating a Empty page and to minimize the exported symbols.
No new tests as no change in functionality.
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
- 20:10 Changeset [124161] by
-
Added a tag for the Safari 6.0 release.
Safari 6.0 includes JavaScriptCore-x536.24, WebCore-x536.24, WebKit-x536.25, and WebKit2-x536.25.
- 20:02 Changeset [124160] by
-
[chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer
https://bugs.webkit.org/show_bug.cgi?id=91032
Reviewed by James Robinson.
Source/Platform:
Add WebScrollbarLayer class to the Platform API.
- Platform.gypi:
- chromium/public/WebScrollbarLayer.h: Added.
(WebCore):
(WebKit):
(WebScrollbarLayer):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::~WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
Source/WebCore:
Modify ScrollingCoordinatorChromium to operate on WebScrollbarLayer
instead of ScrollbarLayerChromium. This removes the dependency on
ScrollbarLayerChromium.
No change in functionality, so no new tests.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):
Source/WebKit/chromium:
Add implementation of WebScrollbarLayer to the client API.
- WebKit.gyp:
- src/WebScrollbarLayer.cpp: Added.
(WebKit):
(WebKit::WebScrollbarLayer::setScrollLayer):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>):
- 19:57 Changeset [124159] by
-
Another Qt build fix attempt after r124098.
"interface" is a keyword. Don't use it.
- dom/GestureEvent.cpp:
(WebCore::GestureEvent::interfaceName):
- 19:56 Changeset [124158] by
-
chromium win compile broken after removing webkit.py
https://bugs.webkit.org/show_bug.cgi?id=92549
Reviewed by Ryosuke Niwa.
Remove the stub file for webkit.py now that it's no longer
necessary.
- Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
- 19:56 Changeset [124157] by
-
Make QuotesData use a Vector of pairs
https://bugs.webkit.org/show_bug.cgi?id=92448
Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-07-30
Reviewed by Julien Chaffraix.
Source/WebCore:
QuotesData::create returned an array of memory that contained in place instantiations
of a QuotesData and then String instances. This changes the code to use a Vector of
pairs making it safer and ensuring that quotes are always balanced. This also uses a
HashMap directly in the QuoteRenderer instead of building it on first access reducing
the amount of code needed for picking quotes by language.
Test: fast/css-generated-content/close-quote-negative-depth.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Create pairs and use the new QuotesData API.
- rendering/RenderQuote.cpp:
(WebCore):
(WebCore::quotesDataLanguageMap): New function that returns the HashMap of languages.
(WebCore::basicQuotesData): Returns the simple form of quotes, " and '.
(WebCore::defaultQuotes): Changed to use the new map.
(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::originalText): Changed to use the new getOpenQuote and getCloseQuote which ensure bounds checks.
- rendering/style/QuotesData.cpp:
(WebCore::QuotesData::create): Now returns a plain instance of QuotesData without the in place allocation.
(WebCore):
(WebCore::QuotesData::addPair): Adds an std::pair of strings ensuring quotes are always balanced.
(WebCore::QuotesData::getOpenQuote):
(WebCore::QuotesData::getCloseQuote):
(WebCore::QuotesData::equals): Renamed equals (added the s).
- rendering/style/QuotesData.h:
(WebCore::QuotesData::create):
(QuotesData):
(WebCore::QuotesData::QuotesData):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setQuotes):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::operator==):
LayoutTests:
Test that when quote depths go negative we do not output quotes. The expected result
is wrong right now because we output quotes in this case when we should not.
- fast/css-generated-content/close-quote-negative-depth-expected.html: Added.
- fast/css-generated-content/close-quote-negative-depth.html: Added.
- 19:48 Changeset [124156] by
-
Node::replaceChild() can create bad DOM topology with MutationEvent
https://bugs.webkit.org/show_bug.cgi?id=92619
Reviewed by Ryosuke Niwa.
Source/WebCore:
Node::replaceChild() calls insertBeforeCommon() after dispatching
a MutationEvent event for removeChild(). But insertBeforeCommon()
expects call sites to check the invariant and doesn't have
suffient check. So a MutationEvent handler can let some bad tree
topology to slip into insertBeforeCommon().
This change adds a guard for checking the invariant using
checkReplaceChild() between removeChild() and insertBeforeCommon().
Test: fast/events/mutation-during-replace-child.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild): Added a guard.
LayoutTests:
- fast/events/mutation-during-replace-child-expected.txt: Added.
- fast/events/mutation-during-replace-child.html: Added.
- 19:46 Changeset [124155] by
-
Qt Windows build fix attempt after r124098.
- dom/GestureEvent.cpp:
- 19:46 Changeset [124154] by
-
[Chromium] Enable web audio IPP for x86 chromium android
https://bugs.webkit.org/show_bug.cgi?id=91973
Patch by Wei James <james.wei@intel.com> on 2012-07-30
Reviewed by Tony Chang.
Include the IPP libraries at link-time for Android builds when
compiling the Web Audio API with IPP support.
- WebCore.gyp/WebCore.gyp:
- 19:43 Changeset [124153] by
-
Windows build fix attempt after r124092.
- MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
- 19:17 Changeset [124152] by
-
Merged r123658. <rdar://problem/11961131>
- 19:15 Changeset [124151] by
-
Merged r123649. <rdar://problem/11961125>
- 19:13 Changeset [124150] by
-
Merged r123637. <rdar://problem/11961127>
- 19:08 Changeset [124149] by
-
Merged r123630. <rdar://problem/11961135>
- 19:06 Changeset [124148] by
-
Remove erroneously committed debugging print call from a test.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_generates_results_page):
- 19:05 Changeset [124147] by
-
Merged r123486. <rdar://problem/11954337>
- 19:01 Changeset [124146] by
-
[Forms] Get rid of Element::isReadOnlyFormControl other than CSS related
https://bugs.webkit.org/show_bug.cgi?id=92612
Reviewed by Kent Tamura.
Source/WebCore:
This patch replaces Element::isReadOnlyFormControl() not related to
CSS selector matching to HTMLFormControlElement::readOnly() for
preparation of introducing Element::shouldMatchReadWriteSelector(), bug 92602.
No new tests. This patch doesn't change behavior.
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler): Changed isReadOnlyFormControl() to readOnly().
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Changed isReadOnlyFormControl() to readOnly().
(WebCore::SpinButtonElement::defaultEventHandler): ditto.
(WebCore::SpinButtonElement::step): ditto.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler): ditto.
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult): ditto.
- rendering/RenderTextControl.cpp:
(updateUserModifyProperty): Changed isReadOnlyFormControl() to readOnly().
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton): Changed isReadOnlyFormControl() to readOnly().
Source/WebKit/blackberry:
This patch replaces Element::isReadOnlyFormControl() to
HTMLFormControlElement::readOnly() for preparation of introducing
Element::shouldMatchReadWriteSelector(), bug 92602.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement): Replaced isReadOnlyFormControl() by HTMLTextFormControlElement::readOnly().
- 19:00 Changeset [124145] by
-
Merged r123415. <rdar://problem/11954336>
- 18:57 Changeset [124144] by
-
Fix a popup position issue of fast/forms/date/calendar-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=92609
Reviewed by Hajime Morita.
Force to lay out the document before opening a popup.
- fast/forms/date/calendar-picker-appearance.html:
- 18:53 Changeset [124143] by
-
Merged r123411. <rdar://problem/11954334>
- 18:50 Changeset [124142] by
-
[Chromium] Rebaselines and test expectation updates.
https://bugs.webkit.org/show_bug.cgi?id=62754
https://bugs.webkit.org/show_bug.cgi?id=63937
https://bugs.webkit.org/show_bug.cgi?id=70298
https://bugs.webkit.org/show_bug.cgi?id=74374
https://bugs.webkit.org/show_bug.cgi?id=77368
https://bugs.webkit.org/show_bug.cgi?id=79615
https://bugs.webkit.org/show_bug.cgi?id=80531
https://bugs.webkit.org/show_bug.cgi?id=80879
https://bugs.webkit.org/show_bug.cgi?id=83717
http://crbug.com/10350
http://crbug.com/26291
http://crbug.com/47826
http://crbug.com/131189
Unreviewed, test updates.
Most of the baselines here are for
http://trac.webkit.org/changeset/119431 and
http://trac.webkit.org/changeset/119748 , as well as some changes to
antialiasing (generally to improve it) for which I couldn't find a CL;
when these were originally landed and new baselines committed, a
Chromium test expectation override file was masking the fact that the
tests here needed new baselines as well.
There is also a small number of other changes mixed in.
- platform/chromium-linux-x86/css1: Added.
- platform/chromium-linux-x86/css1/basic: Added.
- platform/chromium-linux-x86/css1/basic/class_as_selector-expected.png: Added.
- platform/chromium-linux-x86/css1/basic/id_as_selector-expected.png: Added.
- platform/chromium-linux-x86/css1/box_properties: Added.
- platform/chromium-linux-x86/css1/box_properties/border_bottom-expected.png: Added.
- platform/chromium-linux-x86/css1/box_properties/margin_left-expected.png: Added.
- platform/chromium-linux-x86/css1/box_properties/padding_right-expected.png: Added.
- platform/chromium-linux-x86/css1/pseudo: Added.
- platform/chromium-linux-x86/css1/pseudo/anchor-expected.png: Added.
- platform/chromium-linux-x86/editing/input: Added.
- platform/chromium-linux-x86/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
- platform/chromium-linux-x86/editing/selection: Removed.
- platform/chromium-linux-x86/fast/backgrounds/repeat: Added.
- platform/chromium-linux-x86/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
- platform/chromium-linux-x86/fast/block/float: Added.
- platform/chromium-linux-x86/fast/block/float/float-avoidance-expected.png: Added.
- platform/chromium-linux-x86/fast/canvas/image-pattern-rotate-expected.png: Added.
- platform/chromium-linux-x86/fast/events: Added.
- platform/chromium-linux-x86/fast/events/autoscroll-expected.png: Added.
- platform/chromium-linux-x86/fast/events/reveal-link-when-focused-expected.png: Added.
- platform/chromium-linux-x86/fast/forms/textarea: Added.
- platform/chromium-linux-x86/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
- platform/chromium-linux-x86/fast/overflow: Added.
- platform/chromium-linux-x86/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
- platform/chromium-linux-x86/fast/selectors: Added.
- platform/chromium-linux-x86/fast/selectors/166-expected.png: Added.
- platform/chromium-linux-x86/fast/selectors/unqualified-hover-strict-expected.png: Added.
- platform/chromium-linux-x86/fast/selectors/unqualified-hover-strict-expected.txt: Added.
- platform/chromium-linux-x86/fast/transforms: Added.
- platform/chromium-linux-x86/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
- platform/chromium-linux-x86/fonts: Added.
- platform/chromium-linux-x86/fonts/monospace-expected.png: Added.
- platform/chromium-linux-x86/http/tests/navigation: Added.
- platform/chromium-linux-x86/http/tests/navigation/javascriptlink-frames-expected.png: Added.
- platform/chromium-linux-x86/ietestcenter: Added.
- platform/chromium-linux-x86/ietestcenter/css3: Added.
- platform/chromium-linux-x86/ietestcenter/css3/bordersbackgrounds: Added.
- platform/chromium-linux-x86/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
- platform/chromium-linux-x86/svg/as-image: Added.
- platform/chromium-linux-x86/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
- platform/chromium-linux-x86/svg/dom: Added.
- platform/chromium-linux-x86/svg/dom/SVGTransformList-basics-expected.png: Added.
- platform/chromium-linux-x86/svg/dom/css-transforms-expected.png: Added.
- platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
- platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/chromium-linux-x86/svg/wicd: Added.
- platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/backgr_index-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
- platform/chromium-linux-x86/transforms: Added.
- platform/chromium-linux-x86/transforms/2d: Added.
- platform/chromium-linux-x86/transforms/2d/hindi-rotated-expected.png: Added.
- platform/chromium-linux-x86/transforms/2d/hindi-rotated-expected.txt: Added.
- platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
- platform/chromium-linux/css1/basic/class_as_selector-expected.png:
- platform/chromium-linux/css1/basic/id_as_selector-expected.png:
- platform/chromium-linux/css1/box_properties/border_bottom-expected.png:
- platform/chromium-linux/css1/box_properties/margin_left-expected.png:
- platform/chromium-linux/css1/box_properties/padding_right-expected.png:
- platform/chromium-linux/css1/pseudo/anchor-expected.png:
- platform/chromium-linux/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- platform/chromium-linux/editing/selection/iframe-expected.png:
- platform/chromium-linux/editing/selection/select-all-001-expected.png:
- platform/chromium-linux/editing/selection/select-all-002-expected.png:
- platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
- platform/chromium-linux/fast/borders/border-radius-valid-border-clipping-expected.png:
- platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
- platform/chromium-linux/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-linux/fast/canvas/image-pattern-rotate-expected.png:
- platform/chromium-linux/fast/events/autoscroll-expected.png:
- platform/chromium-linux/fast/events/reveal-link-when-focused-expected.png:
- platform/chromium-linux/fast/forms/fieldset-align-expected.png:
- platform/chromium-linux/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png:
- platform/chromium-linux/fast/forms/input-table-expected.png:
- platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png:
- platform/chromium-linux/fast/forms/placeholder-position-expected.png:
- platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png:
- platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png:
- platform/chromium-linux/fast/forms/textarea-scrollbar-expected.png:
- platform/chromium-linux/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:
- platform/chromium-linux/fast/html/details-position-expected.png:
- platform/chromium-linux/fast/html/details-writing-mode-expected.png:
- platform/chromium-linux/fast/overflow/overflow-update-transform-expected.png:
- platform/chromium-linux/fast/overflow/overflow-with-local-background-attachment-expected.png:
- platform/chromium-linux/fast/replaced/width100percent-radio-expected.png: Added.
- platform/chromium-linux/fast/selectors/166-expected.png:
- platform/chromium-linux/fast/selectors/unqualified-hover-strict-expected.png:
- platform/chromium-linux/fast/selectors/unqualified-hover-strict-expected.txt: Added.
- platform/chromium-linux/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
- platform/chromium-linux/fonts/monospace-expected.png:
- platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-linux/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
- platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
- platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
- platform/chromium-linux/svg/custom/pattern-rotate-expected.png:
- platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.png:
- platform/chromium-linux/svg/dom/css-transforms-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
- platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
- platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
- platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
- platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
- platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png:
- platform/chromium-linux/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/backgr_index-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
- platform/chromium-linux/transforms/2d/hindi-rotated-expected.png:
- platform/chromium-linux/transforms/2d/hindi-rotated-expected.txt:
- platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-mac-snowleopard/fast/canvas/image-pattern-rotate-expected.png:
- platform/chromium-mac-snowleopard/svg/as-border-image: Removed.
- platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
- platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/chromium-mac-snowleopard/transforms/2d/hindi-rotated-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
- platform/chromium-mac/fast/borders/border-radius-valid-border-clipping-expected.png:
- platform/chromium-mac/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
- platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png:
- platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png:
- platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png:
- platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
- platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/chromium-mac/transforms/2d/hindi-rotated-expected.png: Added.
- platform/chromium-mac/transforms/2d/hindi-rotated-expected.txt: Added.
- platform/chromium-win-xp/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
- platform/chromium-win-xp/css1: Added.
- platform/chromium-win-xp/css1/basic: Added.
- platform/chromium-win-xp/css1/basic/class_as_selector-expected.png: Added.
- platform/chromium-win-xp/css1/basic/containment-expected.png: Added.
- platform/chromium-win-xp/css1/basic/id_as_selector-expected.png: Added.
- platform/chromium-win-xp/css1/box_properties: Added.
- platform/chromium-win-xp/css1/box_properties/border_bottom-expected.png: Added.
- platform/chromium-win-xp/css1/box_properties/border_left-expected.png: Added.
- platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Added.
- platform/chromium-win-xp/css1/box_properties/border_top-expected.png: Added.
- platform/chromium-win-xp/css1/box_properties/clear_float-expected.png: Added.
- platform/chromium-win-xp/css1/box_properties/margin_left-expected.png: Added.
- platform/chromium-win-xp/css1/box_properties/margin_right-expected.png: Added.
- platform/chromium-win-xp/css1/box_properties/padding_left-expected.png: Added.
- platform/chromium-win-xp/css1/box_properties/padding_right-expected.png: Added.
- platform/chromium-win-xp/css1/cascade: Added.
- platform/chromium-win-xp/css1/cascade/cascade_order-expected.png: Added.
- platform/chromium-win-xp/css1/classification: Added.
- platform/chromium-win-xp/css1/classification/list_style_type-expected.png: Added.
- platform/chromium-win-xp/css1/pseudo: Added.
- platform/chromium-win-xp/css1/pseudo/anchor-expected.png: Added.
- platform/chromium-win-xp/css3/selectors3: Added.
- platform/chromium-win-xp/css3/selectors3/html: Added.
- platform/chromium-win-xp/css3/selectors3/html/css3-modsel-161-expected.png: Added.
- platform/chromium-win-xp/css3/selectors3/xhtml: Added.
- platform/chromium-win-xp/css3/selectors3/xhtml/css3-modsel-161-expected.png: Added.
- platform/chromium-win-xp/css3/selectors3/xml: Added.
- platform/chromium-win-xp/css3/selectors3/xml/css3-modsel-161-expected.png: Added.
- platform/chromium-win-xp/editing/input: Added.
- platform/chromium-win-xp/editing/input/caret-at-the-edge-of-input-expected.png: Added.
- platform/chromium-win-xp/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
- platform/chromium-win-xp/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
- platform/chromium-win-xp/fast/backgrounds/repeat: Removed.
- platform/chromium-win-xp/fast/block/float: Added.
- platform/chromium-win-xp/fast/block/float/float-avoidance-expected.png: Added.
- platform/chromium-win-xp/fast/block/margin-collapse: Added.
- platform/chromium-win-xp/fast/block/margin-collapse/103-expected.png: Added.
- platform/chromium-win-xp/fast/events: Added.
- platform/chromium-win-xp/fast/events/autoscroll-expected.png: Added.
- platform/chromium-win-xp/fast/events/context-no-deselect-expected.png: Added.
- platform/chromium-win-xp/fast/events/reveal-link-when-focused-expected.png: Added.
- platform/chromium-win-xp/fast/forms/date: Added.
- platform/chromium-win-xp/fast/forms/date/date-appearance-expected.png: Added.
- platform/chromium-win-xp/fast/forms/select: Added.
- platform/chromium-win-xp/fast/forms/select/optgroup-rendering-expected.png: Added.
- platform/chromium-win-xp/fast/forms/textarea: Added.
- platform/chromium-win-xp/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
- platform/chromium-win-xp/fast/frames: Added.
- platform/chromium-win-xp/fast/frames/take-focus-from-iframe-expected.png: Added.
- platform/chromium-win-xp/fast/gradients: Added.
- platform/chromium-win-xp/fast/gradients/background-clipped-expected.png: Added.
- platform/chromium-win-xp/fast/html: Removed.
- platform/chromium-win-xp/fast/html/details-writing-mode-expected.png: Removed.
- platform/chromium-win-xp/fast/invalid: Added.
- platform/chromium-win-xp/fast/invalid/014-expected.png: Added.
- platform/chromium-win-xp/fast/layers: Added.
- platform/chromium-win-xp/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
- platform/chromium-win-xp/fast/layers/scroll-with-transform-layer-expected.png: Added.
- platform/chromium-win-xp/fast/lists: Added.
- platform/chromium-win-xp/fast/lists/008-expected.png: Added.
- platform/chromium-win-xp/fast/lists/008-vertical-expected.png: Added.
- platform/chromium-win-xp/fast/lists/dynamic-marker-crash-expected.png: Added.
- platform/chromium-win-xp/fast/overflow: Added.
- platform/chromium-win-xp/fast/overflow/overflow-rtl-expected.png: Added.
- platform/chromium-win-xp/fast/overflow/overflow-rtl-vertical-expected.png: Added.
- platform/chromium-win-xp/fast/selectors: Added.
- platform/chromium-win-xp/fast/selectors/166-expected.png: Added.
- platform/chromium-win-xp/fast/selectors/unqualified-hover-strict-expected.png: Added.
- platform/chromium-win-xp/fast/selectors/unqualified-hover-strict-expected.txt: Added.
- platform/chromium-win-xp/fast/speech: Added.
- platform/chromium-win-xp/fast/speech/input-appearance-numberandspeech-expected.png: Added.
- platform/chromium-win-xp/fast/speech/input-appearance-searchandspeech-expected.png: Added.
- platform/chromium-win-xp/fast/speech/input-appearance-speechbutton-expected.png: Added.
- platform/chromium-win-xp/fast/speech/speech-bidi-rendering-expected.png: Added.
- platform/chromium-win-xp/fast/text/drawBidiText-expected.png:
- platform/chromium-win-xp/fast/transforms: Added.
- platform/chromium-win-xp/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
- platform/chromium-win-xp/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
- platform/chromium-win-xp/fast/transforms/transformed-focused-text-input-expected.png: Added.
- platform/chromium-win-xp/fonts: Added.
- platform/chromium-win-xp/fonts/monospace-expected.png: Added.
- platform/chromium-win-xp/http/tests/misc: Added.
- platform/chromium-win-xp/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
- platform/chromium-win-xp/http/tests/navigation: Added.
- platform/chromium-win-xp/http/tests/navigation/javascriptlink-frames-expected.png: Added.
- platform/chromium-win-xp/plugins: Added.
- platform/chromium-win-xp/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
- platform/chromium-win-xp/svg/as-image/image-respects-pageScaleFactor-expected.png: Removed.
- platform/chromium-win-xp/svg/dom: Removed.
- platform/chromium-win-xp/svg/hixie/mixed: Added.
- platform/chromium-win-xp/svg/hixie/mixed/003-expected.png: Added.
- platform/chromium-win-xp/svg/in-html: Added.
- platform/chromium-win-xp/svg/in-html/circle-expected.png: Added.
- platform/chromium-win-xp/svg/transforms: Added.
- platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
- platform/chromium-win-xp/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
- platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png:
- platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
- platform/chromium-win-xp/tables/mozilla/core: Added.
- platform/chromium-win-xp/tables/mozilla/core/margins-expected.png: Added.
- platform/chromium-win-xp/tables/mozilla/dom: Added.
- platform/chromium-win-xp/tables/mozilla/dom/tableDom-expected.png: Added.
- platform/chromium-win-xp/tables/mozilla/other: Added.
- platform/chromium-win-xp/tables/mozilla/other/move_row-expected.png: Added.
- platform/chromium-win-xp/tables/mozilla_expected_failures: Added.
- platform/chromium-win-xp/tables/mozilla_expected_failures/bugs: Added.
- platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
- platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
- platform/chromium-win-xp/tables/mozilla_expected_failures/marvin: Added.
- platform/chromium-win-xp/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
- platform/chromium-win-xp/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png: Added.
- platform/chromium-win-xp/transforms/2d/hindi-rotated-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
- platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
- platform/chromium-win/css1/basic/class_as_selector-expected.png:
- platform/chromium-win/css1/basic/containment-expected.png:
- platform/chromium-win/css1/basic/id_as_selector-expected.png:
- platform/chromium-win/css1/box_properties/border_bottom-expected.png:
- platform/chromium-win/css1/box_properties/border_left-expected.png:
- platform/chromium-win/css1/box_properties/border_right_inline-expected.png:
- platform/chromium-win/css1/box_properties/border_top-expected.png:
- platform/chromium-win/css1/box_properties/clear_float-expected.png:
- platform/chromium-win/css1/box_properties/margin_left-expected.png:
- platform/chromium-win/css1/box_properties/margin_right-expected.png:
- platform/chromium-win/css1/box_properties/padding_left-expected.png:
- platform/chromium-win/css1/box_properties/padding_right-expected.png:
- platform/chromium-win/css1/cascade/cascade_order-expected.png:
- platform/chromium-win/css1/classification/list_style_type-expected.png:
- platform/chromium-win/css1/pseudo/anchor-expected.png:
- platform/chromium-win/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
- platform/chromium-win/css3/selectors3/html/css3-modsel-161-expected.png:
- platform/chromium-win/css3/selectors3/xhtml/css3-modsel-161-expected.png:
- platform/chromium-win/css3/selectors3/xml/css3-modsel-161-expected.png:
- platform/chromium-win/editing/deleting/delete-after-span-ws-001-expected.png:
- platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.png:
- platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.png:
- platform/chromium-win/editing/deleting/delete-line-end-ws-001-expected.png:
- platform/chromium-win/editing/deleting/delete-line-end-ws-002-expected.png:
- platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.png:
- platform/chromium-win/editing/inserting/4960120-1-expected.png:
- platform/chromium-win/editing/inserting/before-after-input-element-expected.png:
- platform/chromium-win/editing/pasteboard/4806874-expected.png:
- platform/chromium-win/editing/pasteboard/4944770-1-expected.png:
- platform/chromium-win/editing/pasteboard/4944770-2-expected.png:
- platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/chromium-win/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-win/editing/pasteboard/pasting-tabs-expected.png:
- platform/chromium-win/editing/selection/3690703-2-expected.png:
- platform/chromium-win/editing/selection/3690703-expected.png:
- platform/chromium-win/editing/selection/3690719-expected.png:
- platform/chromium-win/editing/selection/4397952-expected.png:
- platform/chromium-win/editing/selection/4895428-3-expected.png:
- platform/chromium-win/editing/selection/4975120-expected.png:
- platform/chromium-win/editing/selection/caret-before-select-expected.png:
- platform/chromium-win/editing/selection/drag-select-1-expected.png:
- platform/chromium-win/editing/selection/iframe-expected.png:
- platform/chromium-win/editing/selection/replaced-boundaries-3-expected.png:
- platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.png:
- platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.png:
- platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.png:
- platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.png:
- platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.png:
- platform/chromium-win/editing/selection/select-all-001-expected.png:
- platform/chromium-win/editing/selection/select-all-002-expected.png:
- platform/chromium-win/editing/selection/select-box-expected.png:
- platform/chromium-win/editing/selection/select-element-paragraph-boundary-expected.png:
- platform/chromium-win/editing/selection/unrendered-001-expected.png:
- platform/chromium-win/editing/selection/unrendered-002-expected.png:
- platform/chromium-win/editing/selection/unrendered-003-expected.png:
- platform/chromium-win/editing/selection/unrendered-004-expected.png:
- platform/chromium-win/editing/selection/unrendered-005-expected.png:
- platform/chromium-win/fast/backgrounds/background-inherit-color-bug-expected.png:
- platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-win/fast/block/float/float-avoidance-expected.png:
- platform/chromium-win/fast/block/margin-collapse/103-expected.png:
- platform/chromium-win/fast/borders/border-radius-valid-border-clipping-expected.png:
- platform/chromium-win/fast/borders/mixed-border-styles-radius2-expected.png:
- platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
- platform/chromium-win/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
- platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
- platform/chromium-win/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-win/fast/canvas/image-object-in-canvas-expected.png:
- platform/chromium-win/fast/canvas/image-pattern-rotate-expected.png:
- platform/chromium-win/fast/css/input-search-padding-expected.png:
- platform/chromium-win/fast/css/line-height-expected.png:
- platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.png:
- platform/chromium-win/fast/css/text-overflow-input-expected.png:
- platform/chromium-win/fast/css/text-transform-select-expected.png:
- platform/chromium-win/fast/dom/52776-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- platform/chromium-win/fast/dom/focus-contenteditable-expected.png:
- platform/chromium-win/fast/dom/isindex-001-expected.png:
- platform/chromium-win/fast/dom/isindex-002-expected.png:
- platform/chromium-win/fast/events/autoscroll-expected.png:
- platform/chromium-win/fast/events/context-no-deselect-expected.png:
- platform/chromium-win/fast/events/reveal-link-when-focused-expected.png:
- platform/chromium-win/fast/forms/001-expected.png:
- platform/chromium-win/fast/forms/003-expected.png:
- platform/chromium-win/fast/forms/004-expected.png:
- platform/chromium-win/fast/forms/HTMLOptionElement_label01-expected.png:
- platform/chromium-win/fast/forms/HTMLOptionElement_label02-expected.png:
- platform/chromium-win/fast/forms/HTMLOptionElement_label03-expected.png:
- platform/chromium-win/fast/forms/HTMLOptionElement_label04-expected.png:
- platform/chromium-win/fast/forms/HTMLOptionElement_label05-expected.png:
- platform/chromium-win/fast/forms/HTMLOptionElement_label06-expected.png:
- platform/chromium-win/fast/forms/HTMLOptionElement_label07-expected.png:
- platform/chromium-win/fast/forms/basic-buttons-expected.png:
- platform/chromium-win/fast/forms/basic-inputs-expected.png:
- platform/chromium-win/fast/forms/basic-selects-expected.png:
- platform/chromium-win/fast/forms/button-generated-content-expected.png:
- platform/chromium-win/fast/forms/button-inner-block-reuse-expected.png:
- platform/chromium-win/fast/forms/control-clip-overflow-expected.png:
- platform/chromium-win/fast/forms/control-restrict-line-height-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-expected.png:
- platform/chromium-win/fast/forms/disabled-select-change-index-expected.png:
- platform/chromium-win/fast/forms/encoding-test-expected.png:
- platform/chromium-win/fast/forms/fieldset-align-expected.png:
- platform/chromium-win/fast/forms/floating-textfield-relayout-expected.png:
- platform/chromium-win/fast/forms/form-element-geometry-expected.png:
- platform/chromium-win/fast/forms/input-align-expected.png:
- platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/chromium-win/fast/forms/input-appearance-disabled-expected.png:
- platform/chromium-win/fast/forms/input-appearance-focus-expected.png:
- platform/chromium-win/fast/forms/input-appearance-height-expected.png:
- platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.png:
- platform/chromium-win/fast/forms/input-appearance-readonly-expected.png:
- platform/chromium-win/fast/forms/input-appearance-selection-expected.png:
- platform/chromium-win/fast/forms/input-appearance-visibility-expected.png:
- platform/chromium-win/fast/forms/input-appearance-width-expected.png:
- platform/chromium-win/fast/forms/input-baseline-expected.png:
- platform/chromium-win/fast/forms/input-disabled-color-expected.png:
- platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/chromium-win/fast/forms/input-field-text-truncated-expected.png:
- platform/chromium-win/fast/forms/input-placeholder-paint-order-expected.png:
- platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.png:
- platform/chromium-win/fast/forms/input-readonly-dimmed-expected.png:
- platform/chromium-win/fast/forms/input-readonly-empty-expected.png:
- platform/chromium-win/fast/forms/input-spaces-expected.png:
- platform/chromium-win/fast/forms/input-table-expected.png:
- platform/chromium-win/fast/forms/input-text-click-inside-expected.png:
- platform/chromium-win/fast/forms/input-text-click-outside-expected.png:
- platform/chromium-win/fast/forms/input-text-double-click-expected.png:
- platform/chromium-win/fast/forms/input-text-option-delete-expected.png:
- platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.png:
- platform/chromium-win/fast/forms/input-text-word-wrap-expected.png:
- platform/chromium-win/fast/forms/input-type-text-min-width-expected.png:
- platform/chromium-win/fast/forms/input-value-expected.png:
- platform/chromium-win/fast/forms/input-width-expected.png:
- platform/chromium-win/fast/forms/listbox-bidi-align-expected.png:
- platform/chromium-win/fast/forms/listbox-clip-expected.png:
- platform/chromium-win/fast/forms/listbox-scrollbar-incremental-load-expected.png:
- platform/chromium-win/fast/forms/listbox-width-change-expected.png:
- platform/chromium-win/fast/forms/menulist-deselect-update-expected.png:
- platform/chromium-win/fast/forms/menulist-narrow-width-expected.png:
- platform/chromium-win/fast/forms/menulist-no-overflow-expected.png:
- platform/chromium-win/fast/forms/menulist-restrict-line-height-expected.png:
- platform/chromium-win/fast/forms/menulist-separator-painting-expected.png:
- platform/chromium-win/fast/forms/menulist-style-color-expected.png:
- platform/chromium-win/fast/forms/menulist-width-change-expected.png:
- platform/chromium-win/fast/forms/minWidthPercent-expected.png:
- platform/chromium-win/fast/forms/option-script-expected.png:
- platform/chromium-win/fast/forms/option-strip-whitespace-expected.png:
- platform/chromium-win/fast/forms/option-text-clip-expected.png:
- platform/chromium-win/fast/forms/placeholder-position-expected.png:
- platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.png:
- platform/chromium-win/fast/forms/plaintext-mode-2-expected.png:
- platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.png:
- platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.png:
- platform/chromium-win/fast/forms/search-rtl-expected.png:
- platform/chromium-win/fast/forms/searchfield-heights-expected.png:
- platform/chromium-win/fast/forms/select-align-expected.png:
- platform/chromium-win/fast/forms/select-background-none-expected.png:
- platform/chromium-win/fast/forms/select-baseline-expected.png:
- platform/chromium-win/fast/forms/select-block-background-expected.png:
- platform/chromium-win/fast/forms/select-change-listbox-size-expected.png:
- platform/chromium-win/fast/forms/select-change-listbox-to-popup-expected.png:
- platform/chromium-win/fast/forms/select-change-popup-to-listbox-expected.png:
- platform/chromium-win/fast/forms/select-dirty-parent-pref-widths-expected.png:
- platform/chromium-win/fast/forms/select-disabled-appearance-expected.png:
- platform/chromium-win/fast/forms/select-initial-position-expected.png:
- platform/chromium-win/fast/forms/select-list-box-with-height-expected.png:
- platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png:
- platform/chromium-win/fast/forms/select-overflow-scroll-expected.png:
- platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png:
- platform/chromium-win/fast/forms/select-selected-expected.png:
- platform/chromium-win/fast/forms/select-size-expected.png:
- platform/chromium-win/fast/forms/select-style-expected.png:
- platform/chromium-win/fast/forms/select-visual-hebrew-expected.png:
- platform/chromium-win/fast/forms/select-writing-direction-natural-expected.png:
- platform/chromium-win/fast/forms/select/optgroup-rendering-expected.png:
- platform/chromium-win/fast/forms/selectlist-minsize-expected.png:
- platform/chromium-win/fast/forms/stuff-on-my-optgroup-expected.png:
- platform/chromium-win/fast/forms/tabbing-input-iframe-expected.png:
- platform/chromium-win/fast/forms/text-style-color-expected.png:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png:
- platform/chromium-win/fast/forms/textarea-scrollbar-expected.png:
- platform/chromium-win/fast/forms/textarea-scrolled-type-expected.png:
- platform/chromium-win/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:
- platform/chromium-win/fast/forms/textfield-focus-ring-expected.png:
- platform/chromium-win/fast/forms/textfield-overflow-expected.png:
- platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.png:
- platform/chromium-win/fast/frames/take-focus-from-iframe-expected.png:
- platform/chromium-win/fast/gradients/background-clipped-expected.png:
- platform/chromium-win/fast/html/details-no-summary4-expected.png:
- platform/chromium-win/fast/html/details-open-javascript-expected.png:
- platform/chromium-win/fast/html/details-open2-expected.png:
- platform/chromium-win/fast/html/details-open4-expected.png:
- platform/chromium-win/fast/html/details-position-expected.png:
- platform/chromium-win/fast/html/details-replace-summary-child-expected.png:
- platform/chromium-win/fast/html/details-replace-text-expected.png:
- platform/chromium-win/fast/html/details-writing-mode-expected.png:
- platform/chromium-win/fast/html/keygen-expected.png:
- platform/chromium-win/fast/invalid/014-expected.png:
- platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png:
- platform/chromium-win/fast/layers/scroll-with-transform-layer-expected.png:
- platform/chromium-win/fast/lists/008-expected.png:
- platform/chromium-win/fast/lists/008-vertical-expected.png:
- platform/chromium-win/fast/lists/dynamic-marker-crash-expected.png:
- platform/chromium-win/fast/overflow/overflow-rtl-expected.png:
- platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png:
- platform/chromium-win/fast/overflow/overflow-update-transform-expected.png:
- platform/chromium-win/fast/overflow/overflow-with-local-background-attachment-expected.png:
- platform/chromium-win/fast/parser/document-write-option-expected.png:
- platform/chromium-win/fast/repaint/control-clip-expected.png:
- platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
- platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
- platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
- platform/chromium-win/fast/repaint/select-option-background-color-expected.png:
- platform/chromium-win/fast/repaint/subtree-root-skipped-expected.png:
- platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- platform/chromium-win/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/chromium-win/fast/replaced/three-selects-break-expected.png:
- platform/chromium-win/fast/replaced/width100percent-searchfield-expected.png:
- platform/chromium-win/fast/replaced/width100percent-textfield-expected.png:
- platform/chromium-win/fast/selectors/166-expected.png:
- platform/chromium-win/fast/selectors/unqualified-hover-strict-expected.png:
- platform/chromium-win/fast/selectors/unqualified-hover-strict-expected.txt:
- platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png:
- platform/chromium-win/fast/table/003-expected.png:
- platform/chromium-win/fast/table/colspanMinWidth-expected.png:
- platform/chromium-win/fast/table/spanOverlapRepaint-expected.png:
- platform/chromium-win/fast/table/text-field-baseline-expected.png:
- platform/chromium-win/fast/text/drawBidiText-expected.png:
- platform/chromium-win/fast/text/international/bidi-listbox-atsui-expected.png:
- platform/chromium-win/fast/text/international/bidi-listbox-expected.png:
- platform/chromium-win/fast/text/international/bidi-menulist-expected.png:
- platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
- platform/chromium-win/fast/text/textIteratorNilRenderer-expected.png:
- platform/chromium-win/fast/text/updateNewFont-expected.png:
- platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
- platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
- platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.png:
- platform/chromium-win/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
- platform/chromium-win/fast/writing-mode/box-shadow-vertical-lr-expected.png:
- platform/chromium-win/fast/writing-mode/box-shadow-vertical-rl-expected.png:
- platform/chromium-win/fonts/monospace-expected.png:
- platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png:
- platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.png:
- platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/chromium-win/svg/css/composite-shadow-example-expected.png:
- platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png:
- platform/chromium-win/svg/css/stars-with-shadow-expected.png:
- platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
- platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
- platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
- platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
- platform/chromium-win/svg/custom/object-sizing-no-width-height-expected.png:
- platform/chromium-win/svg/custom/pattern-rotate-expected.png:
- platform/chromium-win/svg/dom/SVGTransformList-basics-expected.png:
- platform/chromium-win/svg/dom/css-transforms-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
- platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
- platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
- platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
- platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
- platform/chromium-win/svg/hixie/mixed/003-expected.png:
- platform/chromium-win/svg/in-html/circle-expected.png:
- platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/chromium-win/svg/wicd/rightsizing-grid-expected.png:
- platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png:
- platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
- platform/chromium-win/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/chromium-win/tables/mozilla/bugs/45621-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug12384-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug24200-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug29326-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug30692-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug33855-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug44505-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug55545-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug59354-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-win/tables/mozilla/core/margins-expected.png:
- platform/chromium-win/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/backgr_index-expected.png:
- platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
- platform/chromium-win/tables/mozilla/other/move_row-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
- platform/chromium-win/transforms/2d/hindi-rotated-expected.png:
- platform/chromium-win/transforms/2d/hindi-rotated-expected.txt:
- platform/chromium-win/transforms/2d/zoom-menulist-expected.png:
- platform/chromium/TestExpectations:
- platform/efl/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
- platform/gtk/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
- 18:48 Changeset [124141] by
-
Unreviewed, rolling out r124123.
http://trac.webkit.org/changeset/124123
https://bugs.webkit.org/show_bug.cgi?id=92700
ASSERT crashes terminate webkit Layout tests (Requested by
msaboff on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30
- heap/Heap.cpp:
- heap/Heap.h:
(Heap):
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::doSweep):
(JSC::IncrementalSweeper::startSweeping):
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC):
- heap/IncrementalSweeper.h:
(IncrementalSweeper):
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::addBlock):
- heap/MarkedAllocator.h:
(JSC::MarkedAllocator::zapFreeList):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweepHelper):
- heap/MarkedSpace.cpp:
- heap/MarkedSpace.h:
(JSC::MarkedSpace::sweep):
(JSC):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::~JSGlobalData):
- 18:45 Changeset [124140] by
-
webkit-patch: system keyring is not used to read my password
https://bugs.webkit.org/show_bug.cgi?id=92532
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-30
Reviewed by Dirk Pranke.
In case no username can be fetched from environment, git or keychain,
prompt for username, and try to get password from keyring associated
with that username.
- Scripts/webkitpy/common/net/credentials.py:
(Credentials.read_credentials):
- Scripts/webkitpy/common/net/credentials_unittest.py:
(test_keyring_without_git_repo_nor_keychain):
(test_keyring_without_git_repo_nor_keychain.MockKeyring):
(test_keyring_without_git_repo_nor_keychain.MockKeyring.get_password):
(test_keyring_without_git_repo_nor_keychain.FakeCredentials):
(test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_keychain):
(test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_environment):
(test_keyring_without_git_repo_nor_keychain.FakeUser):
(test_keyring_without_git_repo_nor_keychain.FakeUser.prompt):
(test_keyring_without_git_repo_nor_keychain.FakeUser.prompt_password):
- 18:40 Changeset [124139] by
-
nrwt: move the code that identifies the chunk of tests to run into finder
https://bugs.webkit.org/show_bug.cgi?id=92694
Reviewed by Ryosuke Niwa.
Another patch to make manager.py smaller and clearer; this patch moves
the handling of breaking the list of tests into chunks (--run-part,
--run-chunk) from manager.py to finder.py.
There are no functional changes and this is covered by existing tests.
- Scripts/webkitpy/layout_tests/controllers/finder.py:
(Finder.init):
(Finder._read_test_files):
(Finder):
(Finder.split_into_chunks_if_necessary):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.init):
(Manager._collect_tests):
(Manager._parse_expectations):
(Manager.prepare_lists_and_print_output):
- 18:34 Changeset [124138] by
-
Merged r122300. <rdar://problem/11932360>
- 18:26 Changeset [124137] by
-
Merged r122271. <rdar://problem/11932360>
- 18:21 Changeset [124136] by
-
Merged r122520. <rdar://problem/11932354>
- 18:14 Changeset [124135] by
-
Grid Demo spends 1.5% of total time allocating Path objects in RenderBoxModelObject::paintBorderSides
https://bugs.webkit.org/show_bug.cgi?id=92252
Reviewed by Simon Fraser.
This change introduces the concept of a "null Path" very similar to a null WTF::String.
Just like String functions as a RefPtr around a StringImpl, Path (for most ports)
functions as an OwnPtr around a PlatformPathPtr.
In various places in the code, we declare a local Path variable, but don't necessarily
use that Path variable in all code paths, or might pass that Path variable along to GraphicsContext
functions, without ever actually adding points to that Path.
On most platforms, this Path default constructor was causing a malloc!
In some of these case, the code-path in question (like paintBorderSides) can be quite hot.
Introducing this null-Path and delaying instantiation of the PlatformPath object
until it's actually needed, saves a malloc for these hot paths.
To test this, I loaded a few popular pages, and added printfs to both the Path constructor
and destructor, logging during construction and destruction when the path was still null at destruction time.
This simple testing showed this to be a small win (avoiding mallocs) on many sites and a huge win for Google Spreadsheets:
apple.com: 147 Paths created, 9 (6%) destroyed null.
google.com: 58 Paths created, 26 (44%) destroyed null (google seems creating 5 paths every second after load? 1 of which is destroyed empty.)
amazon.com: 130 Paths created, 130 (100%) destroyed null.
Loading an empty spreadsheet from drive.google.com: 5237 created, 4861 destroyed null (92%!) :)
- platform/graphics/Path.h:
(Path):
(WebCore::Path::isNull):
(WebCore::Path::ensurePlatformPath):
- platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::appendWebCorePathToCairoContext):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clip):
- platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::ensurePlatformPath):
(WebCore):
(WebCore::Path::operator=):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::currentPoint):
(WebCore::Path::translate):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addRect):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArc):
(WebCore::Path::addArcTo):
(WebCore::Path::addEllipse):
(WebCore::Path::closeSubpath):
(WebCore::Path::boundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::apply):
(WebCore::Path::transform):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clipOut):
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore):
(WebCore::Path::ensurePlatformPath):
(WebCore::Path::operator=):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::fastBoundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::platformAddPathForRoundedRect):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::currentPoint):
(WebCore::Path::apply):
- platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
(WebCore):
(WebCore::LoopBlinnPathProcessor::buildContours):
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing):
- platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PainterOpenVG::drawPath):
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
- platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore):
(WebCore::Path::ensurePlatformPath):
(WebCore::Path::operator=):
(WebCore::Path::isEmpty):
(WebCore::Path::hasCurrentPoint):
(WebCore::Path::currentPoint):
(WebCore::Path::contains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::clear):
(WebCore::Path::apply):
(WebCore::Path::transform):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::strokeContains):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
- platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
- platform/graphics/wx/PathWx.cpp:
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::boundingRect):
(WebCore::Path::operator=):
(WebCore::Path::ensurePlatformPath):
(WebCore):
(WebCore::Path::clear):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::transform):
(WebCore::Path::currentPoint):
- 18:13 Changeset [124134] by
-
Add WTF_EXPORT_PRIVATE to deleteOwnedPtr()
https://bugs.webkit.org/show_bug.cgi?id=92668
Reviewed by Hajime Morita.
When using export macros all non-inlined deleteOwnedPtr()
functions need to be declared with WTF_EXPORT_PRIVATE.
- wtf/OwnPtrCommon.h:
(WTF):
- 18:07 Changeset [124133] by
-
Merged r122228. <rdar://problem/11932475>
- 18:02 Changeset [124132] by
-
Merged r122152. <rdar://problem/11932481>
- 18:02 Changeset [124131] by
-
nrwt: split test-finding code out from manager.py
https://bugs.webkit.org/show_bug.cgi?id=92693
Reviewed by Ryosuke Niwa.
In the interest of making manager.py smaller, this patch moves
the code that actually takes the command line arguments and
--test-file lists of tests to run and expands them into an
actual list of tests out into a separate module.
- Scripts/webkitpy/layout_tests/controllers/finder.py: Added.
(LayoutTestFinder):
(LayoutTestFinder.init):
(LayoutTestFinder.find_tests):
(LayoutTestFinder._strip_test_dir_prefixes):
(LayoutTestFinder._strip_test_dir_prefix):
(LayoutTestFinder._read_test_names_from_file):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._collect_tests):
(Manager._handle_finished_test):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(strip_comments):
- 17:58 Changeset [124130] by
-
Merged r122082. <rdar://problem/11942018>
- 17:53 Changeset [124129] by
-
Merged r121912. <rdar://problem/11932362>
- 17:49 Changeset [124128] by
-
commit-queue is corrupting ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=92681
Reviewed by Tony Chang.
Some commits made with the commit-queue are ending up with duplicate
ChangeLog entries. I've hot-patched the servers to not use a special
merge driver for ChangeLogs, which should fix this issue. This patch
removes the merge driver from our cold-boot.sh script so that we won't
use it on new commit-queue instances.
- EWSTools/cold-boot.sh:
- 17:48 Changeset [124127] by
-
Merged r121646. <rdar://problem/11932486> & <rdar://problem/11932354>
- 17:46 Changeset [124126] by
-
inspector/profiler/heap-snapshot-containment-show-all.html test crashing during WebView closing
<rdar://problem/11991881>
- platform/mac-lion/Skipped:
- 17:42 Changeset [124125] by
-
Merged r121645. <rdar://problem/11932384>
- 17:35 Changeset [124124] by
-
Merged r121643. <rdar://problem/11942168>
- 17:33 Changeset [124123] by
-
Structures should be swept after all other objects
https://bugs.webkit.org/show_bug.cgi?id=92679
Reviewed by Filip Pizlo.
In order to get rid of ClassInfo from our objects, we need to be able to safely get the
ClassInfo during the destruction of objects. We'd like to get the ClassInfo out of the
Structure, but currently it is not safe to do so because the order of destruction of objects
is not guaranteed to sweep objects before their corresponding Structure. We can fix this by
sweeping Structures after everything else.
- heap/Heap.cpp:
(JSC::Heap::isSafeToSweepStructures): Add a function that checks if it is safe to sweep Structures.
If the Heap's IncrementalSweeper member is null, that means we're shutting down this VM and it is
safe to sweep structures since we'll always do Structures last anyways due to the ordering of
MarkedSpace::forEachBlock.
(JSC):
(JSC::Heap::didStartVMShutdown): Add this intermediate function to the Heap that ~JSGlobalData now
calls rather than calling the two HeapTimer objects individually. This allows the Heap to null out
these pointers after it has invalidated them to prevent accidental use-after-free in the sweep()
calls during lastChanceToFinalize().
- heap/Heap.h:
(Heap):
- heap/HeapTimer.h:
(HeapTimer):
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::structuresCanBeSwept): Determines if it is currently safe to sweep Structures.
This decision is based on whether we have gotten to the end of the vector of blocks that need sweeping
the first time.
(JSC):
(JSC::IncrementalSweeper::doSweep): We add a second pass over the vector to sweep Structures after we
make our first pass. We now null out the slots as we sweep them so that we can quickly find the
Structures during the second pass.
(JSC::IncrementalSweeper::startSweeping): Initialize our new Structure sweeping index.
(JSC::IncrementalSweeper::willFinishSweeping): Callback that is called by MarkedSpace::sweep to notify
the IncrementalSweeper that we are going to sweep all of the remaining blocks in the Heap so it can
assume that everything is taken care of in the correct order. Since MarkedSpace::forEachBlock
iterates over the Structure blocks after all other blocks, the ordering property for sweeping Structures holds.
(JSC::IncrementalSweeper::IncrementalSweeper): Initialize Structure sweeping index.
- heap/IncrementalSweeper.h: Add declarations for new stuff.
(IncrementalSweeper):
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): We now check if the current block only contains structures and
if so and it isn't safe to sweep Structures according to the Heap, we just return early instead of doing
the normal lazy sweep. If this proves to be too much of a waste in the future we can add an extra clause that
will sweep some number of other blocks in place of the current block to mitigate the cost of the floating
Structure garbage.
(JSC::MarkedAllocator::addBlock):
- heap/MarkedAllocator.h:
(JSC::MarkedAllocator::zapFreeList): When we zap the free list in the MarkedAllocator, the current block is no
longer valid to allocate from, so we set the current block to null.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweepHelper): Added a couple assertions to make sure that we weren't trying to sweep Structures
at an unsafe time.
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::sweep): Notify the IncrementalSweeper that the MarkedSpace will finish all currently remaining sweeping.
(JSC):
- heap/MarkedSpace.h:
(JSC):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::~JSGlobalData): Call the new Heap::didStartVMShutdown.
- 17:28 Changeset [124122] by
-
Merged r121482. <rdar://problem/11932427>
- 17:24 Changeset [124121] by
-
Add ability to load from a string to the ObjC WK API
https://bugs.webkit.org/show_bug.cgi?id=92590
Reviewed by Dan Bernstein.
Source/WebKit2:
This adds an often used method to the new Objective-C API and will
be helpful for writing API tests.
- UIProcess/API/mac/WKBrowsingContextController.h:
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadHTMLString:baseURL:]):
Implement via calling down to WKPageLoadHTMLString.
Tools:
Add tests for [WKBrowsingContextController loadHTMLString:baseURL:]. We will be able
to greatly improve these tests (to test more than just not crashing) when methods to
access page content are added (soon!).
Adds:
Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString
Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilBaseURL
Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL
- TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
Adds tests and refactors delegates to not use global state.
- 17:20 Changeset [124120] by
-
This branch was created in error. kareng confirms it is safe to remove.
- 17:14 Changeset [124119] by
-
Merged r121391. <rdar://problem/11932432>
- 17:11 Changeset [124118] by
-
[CMake] TestWebKitAPI bundle should link with WTF
https://bugs.webkit.org/show_bug.cgi?id=92616
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-30
Reviewed by Antonio Gomes.
Fixes build when shared core is disabled.
- TestWebKitAPI/CMakeLists.txt:
- 17:11 Changeset [124117] by
-
Merge 121299. <rdar://problem/11932473>
- 17:01 Changeset [124116] by
-
nrwt: clean up handling of 'expected' stats
https://bugs.webkit.org/show_bug.cgi?id=92527
Reviewed by Tony Chang.
This patch alters the way we compute and log the "expected"
results and how we treat skipped tests; we will now log the
number of skipped tests separately from the categories, e.g.:
Found 31607 tests; running 24464.
Expect: 23496 passes (23496 now, 0 wontfix)
Expect: 548 failures ( 543 now, 5 wontfix)
Expect: 420 flaky ( 245 now, 175 wontfix)
(so that the "expect" totals add up to the "running" totals);
in addition, the totals in the one-line-progress reflect the
number of tests we will actually run. If --iterations or
--repeat-each are specified, the number of tests we run are
multiplied as appropriate, but the "expect" numbers are
unchanged, since we don't count multiple invocations of the same
test multiple times. In addition, if we are using --run-part or
--run-chunk, the tests we don't run are treated as skipped
for consistency. We will also log the values for --iterations
and --repeat each as part of the found/running line.
Previously the code had parsed and re-parsed the
TestExpectations files several times in an attempt to come up
with some sane statistics, but this was expensive and lead to
confusing layer; treating files as skipped in the way described
above is more consistent and cleaner.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._split_into_chunks_if_necessary):
(Manager.prepare_lists_and_print_output):
(Manager.run):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_interrupt_if_at_failure_limits):
(ManagerTest.test_update_summary_with_result):
(ManagerTest.test_look_for_new_crash_logs):
(ResultSummaryTest.get_result_summary):
- Scripts/webkitpy/layout_tests/models/result_summary.py:
(ResultSummary.init):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser.expectation_for_skipped_test):
(TestExpectations.init):
(TestExpectations.add_skipped_tests):
Here we make add_skipped_tests() public, so that we can update
the expectations for tests that we are skipping due to
--run-part or --run-chunk; we use the wontfix flag so that
the tests that are intentionally skipped aren't considered
"fixable".
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(SkippedTests.check):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):
(Printer):
(Printer.print_expected):
(Printer._print_result_summary):
(Printer._print_result_summary_entry):
Here we split out printing the number of tests found and run
from the expected results, to be clearer and so that we don't
have to reparse the expectations to update the stats.
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_result_summary):
- 16:53 Changeset [124115] by
-
atomicDecrement() never reach 0 on Android so no deref() will be called
https://bugs.webkit.org/show_bug.cgi?id=92635
Patch by Wei James <james.wei@intel.com> on 2012-07-30
Reviewed by Adam Barth.
With Android NDK 7b and later, atomic_dec() is implemented by
sync_fetch_and_sub(), which will result in that atomicDecrement()
returns the old value instead of new one.
- wtf/Atomics.h:
(WTF):
(WTF::atomicIncrement):
(WTF::atomicDecrement):
- 16:34 Changeset [124114] by
-
[WK2] Kill the concept of secondary shared process
https://bugs.webkit.org/show_bug.cgi?id=92676
Reviewed by Alexey Proskuryakov.
Build fix after r124092.
- UIProcess/qt/QtWebContext.cpp: Build fix for Qt. In exchange of the
method removed, I've used WebContext::create(String()).
- 16:19 Changeset [124113] by
-
Merged r120954. <rdar://problem/11932588>
- 16:16 Changeset [124112] by
-
Merged r120662. <rdar://problem/11942166>
- 16:13 Changeset [124111] by
-
Avoid Assertion Failure in HarfBuzzRun::characterIndexForXPosition
https://bugs.webkit.org/show_bug.cgi?id=92376
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-30
Reviewed by Tony Chang.
.:
Added manual test to reliably reproduce assertion failure which is solved by this patch.
- ManualTests/harfbuzz-mouse-selection-crash.html: Added.
Source/WebCore:
Previously, the if condition in offsetForPosition gating the call to
characterIndexForXPosition was comparing a different value than what was actually used
as the argument to calling it. In some cases, this can lead to a minuscule difference
when comparing the two floats - enough to trigger the assertion. To resolve this,
the accuracy of the index calculation is improved by changing the types from int
to floats and rephrasing the if condition to be exactly the same as what is checked
for in the assertion.
Manual test ManualTests/harfbuzz-mouse-selection-crash.html added
which reliably reproduces the assertion failure before this change.
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition): Types changed to float.
(WebCore::HarfBuzzShaper::offsetForPosition): Types changed to float, if condition rephrased.
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(HarfBuzzRun):
- 16:12 Changeset [124110] by
-
Merged r119409. <rdar://problem/11942162>
- 16:09 Changeset [124109] by
-
Merged r119227. <rdar://problem/11942165>
- 16:06 Changeset [124108] by
-
Merged r119184. <rdar://problem/11942161>
- 15:45 Changeset [124107] by
-
Merged r118542. <rdar://problem/11942034>
- 15:42 Changeset [124106] by
-
Merged r118478. <rdar://problem/11942156>
- 15:37 Changeset [124105] by
-
[chromium] Remove WebTransformationMatrix::mapPoint overrides
https://bugs.webkit.org/show_bug.cgi?id=90329
Reviewed by Adrienne Walker.
Source/Platform:
Remove clipping-unaware mapPoint functions from the WebTransformationMatrix interface.
- chromium/public/WebTransformationMatrix.h:
(WebTransformationMatrix):
Source/WebCore:
Add more functionality for mapping points to CCMathUtil and use it in CCLayerSorter / drawTileQuad. These
mappings should never clip.
- platform/chromium/support/WebTransformationMatrix.cpp:
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawTileQuad):
- platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::LayerShape::LayerShape):
- platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::mapHomogeneousPoint):
(WebCore::CCMathUtil::mapPoint):
(WebCore):
- platform/graphics/chromium/cc/CCMathUtil.h:
(WebCore::HomogeneousCoordinate::cartesianPoint3d):
(HomogeneousCoordinate):
(CCMathUtil):
- 15:33 Changeset [124104] by
-
Merged r118471. <rdar://problem/11942141>
- 15:29 Changeset [124103] by
-
Merged r118420. <rdar://problem/11961148>
- 15:27 Changeset [124102] by
-
Crash in logging code if MIME type is null
https://bugs.webkit.org/show_bug.cgi?id=92683
<rdar://problem/11985295>
Reviewed by Dan Bernstein.
If the MIME type is null, try to figure it out from the URL extension. If this fails, return early instead of crashing
trying to insert the null string into a hash set.
- loader/SubframeLoader.cpp:
(WebCore::logPluginRequest):
- 15:26 Changeset [124101] by
-
Merged r118316. <rdar://problem/11942151>
- 15:21 Changeset [124100] by
-
Merged r118248. <rdar://problem/11942129>
- 15:18 Changeset [124099] by
-
Build fix with newer bison 2.6.
https://bugs.webkit.org/show_bug.cgi?id=92264
Reviewed by Adam Barth.
As stated in http://www.gnu.org/software/bison/manual/html_node/Table-of-Symbols.html
YYLEX_PARAM and YYPARSE_PARAM are depecreated since version 1.875. So far all Mac OS
version I had access to as well as recent Linux runs at least version 2.3 so it's safe
to use the replacement of these deprecated macros in favor of %lex-param and %parse-param.
As announced http://lists.gnu.org/archive/html/info-gnu/2012-07/msg00011.html with the release
of version 2.6 YYLEX_PARAM and YYPARSE_PARAM are not supported anymore.
No new tests : build fix and the patch should not trigger any regressions
- css/CSSGrammar.y:
- css/CSSParser.cpp:
- xml/XPathGrammar.y: Refactored a bit to not use an intermediate PARSER define.
- xml/XPathParser.cpp: bison 2.6 declare xpathyyparse in the .h file now, i.e. XPathGrammar.h
therefore including this file within the namespace {} declarations leads to xpathyyparse being
defined part of WebCore::XPath namespaces but the actual implementation of xpathyyparse is in XPathGrammar.cpp
(generated) and not implemented within the WebCore::XPath so it lead to linking issues. Last, XPathGrammar.h needs
to be included after the other includes as it uses some XPath types. It breaks the style but CSSParser.cpp is doing the same.
- 15:13 Changeset [124098] by
-
Propagate gesture events to plugins.
https://bugs.webkit.org/show_bug.cgi?id=92281
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-07-30
Reviewed by Adam Barth.
Source/WebCore:
Propagate gesture events to plugins. This change does not expose the gesture events
to JavaScript, since there is no spec for that at the moment. Exposing gesture events
to JavaScript will be done separately, once there is a spec for it.
Test: platform/chromium/plugins/gesture-events.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/EventNames.h:
(WebCore):
(WebCore::EventNames::isGestureEventType):
(EventNames):
- dom/GestureEvent.cpp: Added.
(WebCore):
(WebCore::GestureEvent::create):
(WebCore::GestureEvent::initGestureEvent):
(WebCore::GestureEvent::interfaceName):
(WebCore::GestureEvent::GestureEvent):
(WebCore::GestureEventDispatchMediator::GestureEventDispatchMediator):
(WebCore::GestureEventDispatchMediator::event):
(WebCore::GestureEventDispatchMediator::dispatchEvent):
- dom/GestureEvent.h: Added.
(WebCore):
(GestureEvent):
(WebCore::GestureEvent::~GestureEvent):
(WebCore::GestureEvent::deltaX):
(WebCore::GestureEvent::deltaY):
(WebCore::GestureEvent::GestureEvent):
(GestureEventDispatchMediator):
(WebCore::GestureEventDispatchMediator::create):
- dom/Node.cpp:
(WebCore):
(WebCore::Node::dispatchGestureEvent):
- dom/Node.h:
(WebCore):
(Node):
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
- page/EventHandler.h:
Source/WebKit/chromium:
Propagate gesture events to plugins.
- src/WebInputEventConversion.cpp:
(WebKit):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
- src/WebInputEventConversion.h:
(WebCore):
(WebKit):
(WebGestureEventBuilder):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleEvent):
- src/WebPluginContainerImpl.h:
(WebCore):
(WebPluginContainerImpl):
Tools:
Update TestWebPlugin to receive events, and output logs for the events.
- DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::handleInputEvent):
- DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin::acceptsInputEvents):
(TestWebPlugin):
LayoutTests:
Added a layout test to show that the plugins receive the gesture events correctly.
- platform/chromium/plugins/gesture-events-expected.txt: Added.
- platform/chromium/plugins/gesture-events.html: Added.
- 15:04 Changeset [124097] by
-
Plumb vsync-enabled flag up to compositor thread and support disable-vsync
https://bugs.webkit.org/show_bug.cgi?id=92323
Patch by John Bates <jbates@google.com> on 2012-07-30
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
Source/WebCore:
- platform/graphics/chromium/cc/CCFrameRateController.cpp:
(WebCore::CCFrameRateController::CCFrameRateController):
(WebCore::CCFrameRateController::disableTimeSourceThrottling):
(WebCore):
(WebCore::CCFrameRateController::setActive):
(WebCore::CCFrameRateController::postManualTick):
(WebCore::CCFrameRateController::onTimerFired):
(WebCore::CCFrameRateController::didBeginFrame):
(WebCore::CCFrameRateController::didFinishFrame):
- platform/graphics/chromium/cc/CCFrameRateController.h:
(WebCore):
(CCFrameRateController):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
- public/WebSettings.h:
- tests/CCFrameRateControllerTest.cpp:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setRenderVSyncEnabled):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::renderVSyncEnabled):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- 15:02 Changeset [124096] by
-
Merged r118213. <rdar://problem/11942131>
- 14:53 Changeset [124095] by
-
Add function to calculate the day in year from a date
https://bugs.webkit.org/show_bug.cgi?id=92671
Reviewed by Ryosuke Niwa.
Replace monthToDayInYear() with dayInYear() which takes a whole
date for calculation and will be used for bug 92286 later.
- wtf/DateMath.cpp:
(WTF::dayInYear):
(WTF::dateToDaysFrom1970):
- 14:35 Changeset [124094] by
-
[jhbuild] gnutls 2.12.14 does not build with glibc 2.16.0
https://bugs.webkit.org/show_bug.cgi?id=90643
Reviewed by Gustavo Noronha Silva.
The 2.x series of gnutls has a version of Gnulib that is
incompatible with glibc 2.16.0, which now does not define gets()
by default.
After talking to kov, mrobinson and philn, it looks like it makes
sense to simply remove gnutls from jhbuild.modules and rely on the
version installed on the system being recent enough.
This means at least version 2.12.8 for PKCS11 support, or at the
very least 2.11.0 (these are the minimum versions enforced by
glib-networking's configure.ac).
- efl/jhbuild.modules: Do not build gnutls anymore, make
glib-networking depend on glib instead, and move the libgcrypt
dependency to eet, which is what currently needs it.
- gtk/jhbuild.modules: Do not build gnutls anymore.
- 14:33 Changeset [124093] by
-
[chromium] Add miscellaneous missing includes and OVERRIDE declarations in compositor code
https://bugs.webkit.org/show_bug.cgi?id=92680
Reviewed by Adrienne Walker.
- platform/graphics/chromium/TextureCopier.h:
(AcceleratedTextureCopier):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:
- platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
- platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore):
- 14:31 Changeset [124092] by
-
[WK2] Kill the concept of secondary shared process
https://bugs.webkit.org/show_bug.cgi?id=92676
Reviewed by Sam Weinig.
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/WKContext.h:
- UIProcess/WebContext.cpp:
- UIProcess/WebContext.h: Deleted shared process related code. We don't need to build the singleton into the cross-platform C API, platform-specific API wrappers are perfectly capable of doing that.
- UIProcess/API/efl/ewk_context.cpp: (createDefaultEwkContext):
- UIProcess/API/gtk/WebKitWebContext.cpp: (createDefaultWebContext): Use WKContextCreate() when creating default context.
- 14:19 WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 14:11 Changeset [124091] by
-
[chromium] Remove dependency on ScrollbarTheme from the compositor
https://bugs.webkit.org/show_bug.cgi?id=90528
Reviewed by James Robinson.
Source/Platform:
Flesh out WebScrollbar functions enough to be able to implement
the parts of ScrollbarThemeClient that Chromium uses.
Wrap ScrollbarThemeComposite in the Platform API via two different
classes: WebScrollbarThemePainter is the non-threadsafe version that
is used to paint parts of a scrollbar into a context. This is intended
to only be used on the main thread. WebScrollbarThemeGeometry is the
threadsafe version, used to get the location and sizes of scrollbar
parts on both threads, so they can be painted on the main thread and
composited on the compositor thread.
Unfortunately, there is no way to enforce these thread safety issues,
as other ports use the ScrollbarTheme hierarchy differently than
Chromium does. On the bright side, other than painting, the
ScrollbarTheme code is largely functional and we can enforce this
internally for the Chromium port.
- Platform.gypi:
- chromium/public/WebScrollbar.h:
(WebCore):
(WebKit):
(WebScrollbar):
- chromium/public/WebScrollbarThemeGeometry.h: Added.
(WebCore):
(WebKit):
(WebScrollbarThemeGeometry):
(WebKit::WebScrollbarThemeGeometry::WebScrollbarThemeGeometry):
(WebKit::WebScrollbarThemeGeometry::~WebScrollbarThemeGeometry):
(WebKit::WebScrollbarThemeGeometry::operator=):
(WebKit::WebScrollbarThemeGeometry::isNull):
- chromium/public/WebScrollbarThemePainter.h: Added.
(WebCore):
(WebKit):
(WebScrollbarThemePainter):
(WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter):
(WebKit::WebScrollbarThemePainter::~WebScrollbarThemePainter):
(WebKit::WebScrollbarThemePainter::operator=):
(WebKit::WebScrollbarThemePainter::isNull):
Source/WebCore:
Tested by existing layout tests.
ScrollbarLayerChromium is modified to use the Platform API for
WebScrollbar, WebScrollbarThemePainter, and WebScrollbarThemeGeometry.
This prevents API dependencies from the compositor code into WebCore
scrollbar and theme code.
CCScrollbarLayerImpl::CCScrollbar now implements the WebScrollbar API
instead of the ScrollbarThemeClient API.
Also, CCScrollbarLayerImpl now no longer gets the theme from a static
accessor. It now gets a "copy" of the theme from the main thread via
WebScrollbarThemeGeometry, which is more correct for render theme
scrollbars which were previously using the native theme to get part
geometry. Using the correct theme unfortunately causes crashes due to
bad casts in RenderScrollbarTheme, so this patch turns back off the
use of ScrollbarLayerChromium for themed scrollbars until that can be
resolved.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
- platform/ScrollbarThemeClient.h:
(ScrollbarThemeClient):
- platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::create):
(WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(WebCore::ScrollbarBackgroundPainter::create):
(WebCore::ScrollbarBackgroundPainter::ScrollbarBackgroundPainter):
(ScrollbarBackgroundPainter):
(WebCore::ScrollbarThumbPainter::create):
(WebCore::ScrollbarThumbPainter::ScrollbarThumbPainter):
(ScrollbarThumbPainter):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
(WebCore::ScrollbarLayerChromium::setTexturePriorities):
(WebCore::ScrollbarLayerChromium::update):
- platform/graphics/chromium/ScrollbarLayerChromium.h:
(ScrollbarLayerChromium):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::setScrollbarData):
(WebCore::toUVRect):
(WebCore::CCScrollbarLayerImpl::appendQuads):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isOverlay):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::value):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::location):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::size):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::enabled):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::maximum):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::totalSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollViewScrollbar):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isScrollableAreaActive):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::getTickmarks):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::controlSize):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::pressedPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::hoveredPart):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::scrollbarOverlayStyle):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::orientation):
(WebCore::CCScrollbarLayerImpl::CCScrollbar::isCustomScrollbar):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
(CCScrollbar):
Source/WebKit/chromium:
Add implementations for WebScrollbarThemeGeometry and
WebScrollbarThemePainter. Fill out additional API calls for
WebPluginScrollbarImpl since it derives from WebScrollbar.
Add WebScrollbarImpl to the client API to wrap and own an existing
WebCore Scrollbar object and provide the WebScrollbar interface.
By keeping WebScrollbar separate from WebScrollbarThemeGeometry, the
compositor thread can create its own thread-safe data bag version of a
WebScrollbar (CCScrollbarLayerImpl::CCScrollbar), but this requires
WebScrollbarThemeClientImpl.
WebScrollbarThemeClientImpl does the reverse of WebScrollbarImpl; it
wraps a WebScrollbar and provides the ScrollbarThemeClient interface.
This is so that a WebScrollbar can be passed to the geometry and
painter functions. Then, internally the WebScrollbarThemeClientImpl
can be used to adapt the WebScrollbar to the ScrollbarThemeClient
interface so the geometry and painter functions can call direct
functions on ScrollbarThemeComposite.
- WebKit.gyp:
- src/AssertMatchingEnums.cpp:
- src/ExternalPopupMenu.h:
(WebKit):
- src/WebPluginScrollbarImpl.cpp:
(WebKit::WebPluginScrollbarImpl::WebPluginScrollbarImpl):
(WebKit::WebPluginScrollbarImpl::location):
(WebKit):
(WebKit::WebPluginScrollbarImpl::size):
(WebKit::WebPluginScrollbarImpl::enabled):
(WebKit::WebPluginScrollbarImpl::maximum):
(WebKit::WebPluginScrollbarImpl::totalSize):
(WebKit::WebPluginScrollbarImpl::isScrollViewScrollbar):
(WebKit::WebPluginScrollbarImpl::isScrollableAreaActive):
(WebKit::WebPluginScrollbarImpl::getTickmarks):
(WebKit::WebPluginScrollbarImpl::controlSize):
(WebKit::WebPluginScrollbarImpl::pressedPart):
(WebKit::WebPluginScrollbarImpl::hoveredPart):
(WebKit::WebPluginScrollbarImpl::scrollbarOverlayStyle):
(WebKit::WebPluginScrollbarImpl::orientation):
(WebKit::WebPluginScrollbarImpl::isCustomScrollbar):
(WebKit::WebPluginScrollbarImpl::onMouseUp):
(WebKit::WebPluginScrollbarImpl::onMouseMove):
(WebKit::WebPluginScrollbarImpl::onMouseLeave):
- src/WebPluginScrollbarImpl.h:
(WebPluginScrollbarImpl):
- src/WebScrollbarImpl.cpp: Added.
(WebKit):
(WebKit::WebScrollbar::create):
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::isOverlay):
(WebKit::WebScrollbarImpl::value):
(WebKit::WebScrollbarImpl::location):
(WebKit::WebScrollbarImpl::size):
(WebKit::WebScrollbarImpl::enabled):
(WebKit::WebScrollbarImpl::maximum):
(WebKit::WebScrollbarImpl::totalSize):
(WebKit::WebScrollbarImpl::isScrollViewScrollbar):
(WebKit::WebScrollbarImpl::isScrollableAreaActive):
(WebKit::WebScrollbarImpl::getTickmarks):
(WebKit::WebScrollbarImpl::controlSize):
(WebKit::WebScrollbarImpl::pressedPart):
(WebKit::WebScrollbarImpl::hoveredPart):
(WebKit::WebScrollbarImpl::scrollbarOverlayStyle):
(WebKit::WebScrollbarImpl::orientation):
(WebKit::WebScrollbarImpl::isCustomScrollbar):
- src/WebScrollbarImpl.h: Copied from Source/Platform/chromium/public/WebScrollbar.h.
(WebCore):
(WebKit):
(WebScrollbarImpl):
- src/WebScrollbarThemeClientImpl.cpp: Added.
(WebKit):
(WebKit::WebScrollbarThemeClientImpl::WebScrollbarThemeClientImpl):
(WebKit::WebScrollbarThemeClientImpl::x):
(WebKit::WebScrollbarThemeClientImpl::y):
(WebKit::WebScrollbarThemeClientImpl::width):
(WebKit::WebScrollbarThemeClientImpl::height):
(WebKit::WebScrollbarThemeClientImpl::size):
(WebKit::WebScrollbarThemeClientImpl::location):
(WebKit::WebScrollbarThemeClientImpl::parent):
(WebKit::WebScrollbarThemeClientImpl::root):
(WebKit::WebScrollbarThemeClientImpl::setFrameRect):
(WebKit::WebScrollbarThemeClientImpl::frameRect):
(WebKit::WebScrollbarThemeClientImpl::invalidate):
(WebKit::WebScrollbarThemeClientImpl::invalidateRect):
(WebKit::WebScrollbarThemeClientImpl::scrollbarOverlayStyle):
(WebKit::WebScrollbarThemeClientImpl::getTickmarks):
(WebKit::WebScrollbarThemeClientImpl::isScrollableAreaActive):
(WebKit::WebScrollbarThemeClientImpl::isScrollViewScrollbar):
(WebKit::WebScrollbarThemeClientImpl::convertFromContainingWindow):
(WebKit::WebScrollbarThemeClientImpl::isCustomScrollbar):
(WebKit::WebScrollbarThemeClientImpl::orientation):
(WebKit::WebScrollbarThemeClientImpl::value):
(WebKit::WebScrollbarThemeClientImpl::currentPos):
(WebKit::WebScrollbarThemeClientImpl::visibleSize):
(WebKit::WebScrollbarThemeClientImpl::totalSize):
(WebKit::WebScrollbarThemeClientImpl::maximum):
(WebKit::WebScrollbarThemeClientImpl::controlSize):
(WebKit::WebScrollbarThemeClientImpl::lineStep):
(WebKit::WebScrollbarThemeClientImpl::pageStep):
(WebKit::WebScrollbarThemeClientImpl::pressedPart):
(WebKit::WebScrollbarThemeClientImpl::hoveredPart):
(WebKit::WebScrollbarThemeClientImpl::styleChanged):
(WebKit::WebScrollbarThemeClientImpl::enabled):
(WebKit::WebScrollbarThemeClientImpl::setEnabled):
(WebKit::WebScrollbarThemeClientImpl::isOverlayScrollbar):
- src/WebScrollbarThemeClientImpl.h: Added.
(WebCore):
(WebKit):
(WebScrollbarThemeClientImpl):
- src/WebScrollbarThemeGeometry.cpp: Added.
(WebKit):
(WebKit::WebScrollbarThemeGeometry::assign):
(WebKit::WebScrollbarThemeGeometry::thumbPosition):
(WebKit::WebScrollbarThemeGeometry::thumbLength):
(WebKit::WebScrollbarThemeGeometry::trackPosition):
(WebKit::WebScrollbarThemeGeometry::trackLength):
(WebKit::WebScrollbarThemeGeometry::hasButtons):
(WebKit::WebScrollbarThemeGeometry::hasThumb):
(WebKit::WebScrollbarThemeGeometry::trackRect):
(WebKit::WebScrollbarThemeGeometry::thumbRect):
(WebKit::WebScrollbarThemeGeometry::minimumThumbLength):
(WebKit::WebScrollbarThemeGeometry::scrollbarThickness):
(WebKit::WebScrollbarThemeGeometry::backButtonStartRect):
(WebKit::WebScrollbarThemeGeometry::backButtonEndRect):
(WebKit::WebScrollbarThemeGeometry::forwardButtonStartRect):
(WebKit::WebScrollbarThemeGeometry::forwardButtonEndRect):
(WebKit::WebScrollbarThemeGeometry::constrainTrackRectToTrackPieces):
(WebKit::WebScrollbarThemeGeometry::splitTrack):
(WebKit::WebScrollbarThemeGeometry::WebScrollbarThemeGeometry):
- src/WebScrollbarThemePainter.cpp: Added.
(WebKit):
(WebKit::WebScrollbarThemePainter::assign):
(WebKit::WebScrollbarThemePainter::paintScrollbarBackground):
(WebKit::WebScrollbarThemePainter::paintTrackBackground):
(WebKit::WebScrollbarThemePainter::paintBackTrackPart):
(WebKit::WebScrollbarThemePainter::paintForwardTrackPart):
(WebKit::WebScrollbarThemePainter::paintBackButtonStart):
(WebKit::WebScrollbarThemePainter::paintBackButtonEnd):
(WebKit::WebScrollbarThemePainter::paintForwardButtonStart):
(WebKit::WebScrollbarThemePainter::paintForwardButtonEnd):
(WebKit::WebScrollbarThemePainter::paintTickmarks):
(WebKit::WebScrollbarThemePainter::paintThumb):
(WebKit::WebScrollbarThemePainter::WebScrollbarThemePainter):
- tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::MockScrollbar::convertFromContainingWindow):
(WebCore::MockScrollbar::isOverlayScrollbar):
(MockScrollbar):
(WebCore::TEST):
LayoutTests:
Mark custom-composited-different-track-parts.html as failing because
custom scrollbars no longer create ScrollbarLayerChromiums. This is
due to the unsafe casts in RenderThemeScrollbar.
- platform/chromium/TestExpectations:
- 14:07 Changeset [124090] by
-
nrwt: --verbose logging does not work right on windows
https://bugs.webkit.org/show_bug.cgi?id=92673
Unreviewed, build fix.
The --verbose log level is not being propagated to the worker
processes on windows properly; this has been broken ever since I
refactored logging into the message pool directly :(.
Also, fixing this revealed that outputcapture wasn't saving and
restoring log levels correctly, so I had to fix that as well.
- Scripts/webkitpy/common/message_pool.py:
(_MessagePool._start_workers):
(_MessagePool._worker_log_level):
(_Worker.init):
(_Worker._set_up_logging):
(_WorkerLogHandler.init):
- Scripts/webkitpy/common/system/outputcapture.py:
(OutputCapture.capture_output):
(OutputCapture.restore_output):
- 14:06 Changeset [124089] by
-
REGRESSION(r123636): Heap-use-after-free in StyleResolver::collectMatchingRules.
<http://webkit.org/b/92430>
Reviewed by Antti Koivisto.
Don't hold on to a reference to StyledElement::classNames() as that may become
invalid after mutating the element's attribute data.
In this case it was happening below Element::hasAttributes() which is unfortunately
naive enough to always serialize lazy attributes. That is a minor inefficiency that
can be addressed in a separate patch.
Covered by valgrind on existing tests.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules):
- 14:02 Changeset [124088] by
-
Baselines on additional platforms for fast/table/table-row-focus-ring-paint.
https://bugs.webkit.org/show_bug.cgi?id=85348
Unreviewed gardening.
- platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Removed.
- platform/chromium-mac/fast/table/table-row-focus-ring-paint-expected.png: Added.
- platform/chromium-win/fast/table/table-row-focus-ring-paint-expected.png: Added.
- 13:57 Changeset [124087] by
-
[GTK] critical warning: gdk_window_get_cursor() called on a NULL window
https://bugs.webkit.org/show_bug.cgi?id=92651
Patch by Claudio Saavedra <csaavedra@igalia.com> on 2012-07-30
Reviewed by Martin Robinson.
PageClientImpl::setCursor() might get called before the
window is realized, so safeguard against it.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::setCursor): early return if the window is
not realized.
- 13:52 Changeset [124086] by
-
[EFL] Unreviewed gardening.
Fix r124028 by adding the missing expectations to the added lines.
- platform/efl/TestExpectations:
- 13:49 Changeset [124085] by
-
[chromium] Unreviewed gardening. Add new baselines for tests
affected by r124042.
- platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-win-xp/fast/backgrounds/repeat: Removed.
- platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:
- 13:45 Changeset [124084] by
-
Force Mac editing mode on new test so other platforms will pass it.
https://bugs.webkit.org/show_bug.cgi?id=92662
Reviewed by Ryosuke Niwa.
- fast/writing-mode/flipped-blocks-hit-test-line-edges.html:
- 13:42 Changeset [124083] by
-
Merged r117801. <rdar://problem/11942076>
- 13:41 Changeset [124082] by
-
Merged r117792. <rdar://problem/11942076>
- 13:37 Changeset [124081] by
-
Merged r116665. <rdar://problem/11942038>
- 13:35 Changeset [124080] by
-
Merged r116653. <rdar://problem/11942038>
- 13:19 Changeset [124079] by
-
[Qt] Unreviewed gardening.
- platform/qt-5.0/Skipped: Unskip now passing tests. (bug85203)
- platform/qt-5.0/fast/js/global-constructors-expected.txt: Added. Same as platform/qt/...expected.txt, but has more attribute because of enabled SVG_FONTS.
- platform/qt/fast/js/global-constructors-expected.png: Removed, it is text only test.
- 13:13 Changeset [124078] by
-
Merged r118005. <rdar://problem/11942082>
- 13:05 Changeset [124077] by
-
[chromium] CCThreadTask should not depend on CrossThreadTask and does not need to depend on CrossThreadCopier
https://bugs.webkit.org/show_bug.cgi?id=90132
Patch by James Robinson <jamesr@chromium.org> on 2012-07-30
Reviewed by David Levin.
CrossThreadTask is defined in WebCore/dom/ and depends on concepts like ScriptExecutionConcept. CCThreadTask,
being in WebCore/platform/, should not depend on /dom/ or anything from that layer.
CrossThreadCopier is not a layering violation per se, but it's also not at all helpful for CCThreadTask - we
never use any types for which it would be useful.
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::setVisible):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::implSideRenderingStats):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::forceSerializeOnSwapBuffers):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::acquireLayerTextures):
- platform/graphics/chromium/cc/CCThreadTask.h:
(CCThreadTask1):
(WebCore::CCThreadTask1::create):
(WebCore::CCThreadTask1::CCThreadTask1):
(CCThreadTask2):
(WebCore::CCThreadTask2::create):
(WebCore::CCThreadTask2::CCThreadTask2):
(CCThreadTask3):
(WebCore::CCThreadTask3::create):
(WebCore::CCThreadTask3::CCThreadTask3):
(CCThreadTask4):
(WebCore::CCThreadTask4::create):
(WebCore::CCThreadTask4::CCThreadTask4):
(CCThreadTask5):
(WebCore::CCThreadTask5::create):
(WebCore::CCThreadTask5::CCThreadTask5):
(WebCore::createCCThreadTask):
- 13:04 Changeset [124076] by
-
Merge 123377 - Crash when setting empty class name on a new element
https://bugs.webkit.org/show_bug.cgi?id=92024
Reviewed by Andreas Kling.
Source/WebCore:
Add a check for null attributeData() when setting the className to an
empty string on a newly created element. New SVG elements have null
attributeData() on baseVal upon creation.
Test: svg/custom/empty-className-baseVal-crash.html
- dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged): Add check for null attributeData()
LayoutTests:
Add a check for null attributeData() when setting the className to an
empty string on a newly created element.
- svg/custom/empty-className-baseVal-crash-expected.txt: Added.
- svg/custom/empty-className-baseVal-crash.html: Added.
TBR=schenney@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824091
- 12:51 Changeset [124075] by
-
[chromium] Unreviewed gardening. Rebaseline another test affected by
r124042.
- platform/chromium-linux-x86/fast/gradients: Removed.
- platform/chromium-linux/fast/gradients/background-clipped-expected.png:
- platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png:
- platform/chromium-mac/fast/gradients/background-clipped-expected.png:
- platform/chromium/TestExpectations:
- 12:49 Changeset [124074] by
-
Merged r117957. <rdar://problem/11942079>
- 12:32 Changeset [124073] by
-
Merged r117376. <rdar://problem/11942074>
- 12:26 Changeset [124072] by
-
Merged r117309. <rdar://problem/11942073>
- 12:24 WebKit Team edited by
- Add apavlov to the reviewers list (diff)
- 11:55 Changeset [124071] by
-
After r123895, new-run-webkit-tests can fail with TypeError when a test crashes
https://bugs.webkit.org/show_bug.cgi?id=92664
Reviewed by Michael Saboff.
Updated to handle crash_logs being returned as a tuple of (stderr, crash_log).
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.look_for_new_crash_logs):
- 11:54 Changeset [124070] by
-
[Chromium] Rebaseline tests for Skia changes.
http://crbug.com/130283
http://crbug.com/131188
Unreviewed, test expectations update.
- platform/chromium-linux/css3/filters/effect-combined-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png:
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
- platform/chromium-mac/css3/filters/effect-combined-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-grayscale-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Removed.
- platform/chromium-win/css3/filters/effect-combined-hw-expected.png:
- platform/chromium-win/css3/filters/effect-grayscale-hw-expected.png:
- platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.png:
- platform/chromium-win/css3/filters/effect-saturate-hw-expected.png:
- platform/chromium-win/css3/filters/effect-sepia-hw-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
- 11:53 Changeset [124069] by
-
Add special export macro for string related functions
https://bugs.webkit.org/show_bug.cgi?id=92624
Reviewed by Hajime Morita.
The windows port compiles string related code into every binary for performance reasons (see r59187).
Add the WTF_EXPORT_STRING_API define to allow this behaviour with export macros too.
- wtf/ExportMacros.h:
- wtf/text/AtomicString.h:
(AtomicString):
- wtf/text/StringImpl.h:
(StringImpl):
(WTF):
- wtf/text/WTFString.h:
(WTF):
(String):
- 11:49 Changeset [124068] by
-
Unreviewed, rolling out r123983.
http://trac.webkit.org/changeset/123983
https://bugs.webkit.org/show_bug.cgi?id=92663
EFL build is broken when unit tests are enabled (Requested by
paroga on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30
- CMakeLists.txt:
- PlatformEfl.cmake:
- 11:49 Changeset [124067] by
-
Web Inspector: Rename Databases to Web SQL
https://bugs.webkit.org/show_bug.cgi?id=92646
Patch by Paul Irish <paul.irish@gmail.com> on 2012-07-30
Reviewed by Pavel Feldman.
Renamed Databases to Web SQL. Drive-by fix for EmptyView
selection.
- English.lproj/localizedStrings.js:
- inspector/front-end/EmptyView.js:
- inspector/front-end/ResourcesPanel.js:
- 11:46 Changeset [124066] by
-
Merged r117304. <rdar://problem/11942070>
- 11:44 Changeset [124065] by
-
Merged r117289. <rdar://problem/11932472>
- 11:39 Changeset [124064] by
-
new flexbox should ignore float set on flexitems
https://bugs.webkit.org/show_bug.cgi?id=70792
Reviewed by Ojan Vafai.
Source/WebCore:
Force flex items to not float.
Test: css3/flexbox/floated-flexitem.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle): Force NoFloat on flex items.
LayoutTests:
Make an example in the spec into a ref test. Add some styles to make it a bit more clear what's happening.
- css3/flexbox/floated-flexitem-expected.html: Added.
- css3/flexbox/floated-flexitem.html: Added.
- 11:37 Changeset [124063] by
-
Merged r117161. <rdar://problem/11942062>
- 11:35 Changeset [124062] by
-
Merged r117007. <rdar://problem/11942085>
- 11:33 Changeset [124061] by
-
[Chromium] New baselines and test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=88939
https://bugs.webkit.org/show_bug.cgi?id=91485
http://crbug.com/139162
Unreviewed, test expectations update.
- platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added.
- platform/chromium/TestExpectations:
- 11:30 Changeset [124060] by
-
Merged r116860. <rdar://problem/11942084>
- 11:27 Changeset [124059] by
-
Merged r116827. <rdar://problem/11961140>
- 11:24 Changeset [124058] by
-
Merged r116717. <rdar://problem/11942052>
- 11:22 Changeset [124057] by
-
Merged r116698. <rdar://problem/11942088>
- 11:20 Changeset [124056] by
-
[chromium] Unreviewed gardening. Add new mac baselines for tests
affected by r124042. Fix a typo in TestExpectations.
- platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
- platform/chromium/TestExpectations:
- 11:17 Changeset [124055] by
-
Merged r116683. <rdar://problem/11942090>
- 11:15 Changeset [124054] by
-
Merged r116669. <rdar://problem/11942055>
- 11:01 Changeset [124053] by
-
Unreviewed GTK gardening.
Adding platform-specific baselines that are required after r123793, r123912 and r123914.
- platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
- platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.txt: Added.
- platform/gtk/fast/table/table-row-outline-paint-expected.png: Added.
- platform/gtk/fast/table/table-row-outline-paint-expected.txt: Added.
- platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
- platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.
- 11:00 Changeset [124052] by
-
[chromium] Turn back on ScrollbarLayerChromium for Windows
https://bugs.webkit.org/show_bug.cgi?id=92409
Reviewed by James Robinson.
This reverts r122791. As GDI issues were addressed in Chromium via
http://src.chromium.org/viewvc/chrome?view=rev&revision=148215,
scrollbar parts can now be composited on the thread.
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::createScrollbarLayer):
- 10:56 Changeset [124051] by
-
[chromium] Unreviewed gardening. Marking two accelerated painting
tests as crashing intermittently.
https://bugs.webkit.org/show_bug.cgi?id=92660
- platform/chromium/TestExpectations:
- 10:48 Changeset [124050] by
-
[BlackBerry] Optimize the generation of selection details generation.
https://bugs.webkit.org/show_bug.cgi?id=92522
Reviewed by Antonio Gomes.
PR 179264.
Reduce the number of times we generate selection details notifications.
This removes several notifications that are handled by the standard
notification path and makes skipping duplicate notifications the default
so that only those that must generate a response do.
Reviewed Internally by Gen Mak.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
(BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
- 10:46 Changeset [124049] by
-
Unreviewed, rolling out r124025.
http://trac.webkit.org/changeset/124025
https://bugs.webkit.org/show_bug.cgi?id=92658
Causes color-suggestion-picker-appearance layout test to time
out on all Chromium platforms (Requested by tomhudson_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30
Source/Platform:
- chromium/public/WebLocalizedString.h:
Source/WebCore:
- rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI):
Source/WebKit/chromium:
- WebKit.gyp:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser):
- src/ChromeClientImpl.h:
(WebCore):
(ChromeClientImpl):
- src/ColorChooserProxy.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(WebKit::ColorChooserProxy::ColorChooserProxy):
(WebKit::ColorChooserProxy::~ColorChooserProxy):
(WebKit::ColorChooserProxy::setSelectedColor):
(WebKit::ColorChooserProxy::endChooser):
- src/ColorChooserProxy.h: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(ColorChooserProxy):
- src/ColorChooserUIController.cpp: Removed.
- src/WebColorChooserClientImpl.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::didChooseColor):
(WebKit::WebColorChooserClientImpl::didEndChooser):
- src/WebColorChooserClientImpl.h: Renamed from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebCore):
(WebKit):
(WebColorChooserClientImpl):
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Removed.
- platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Removed.
- platform/chromium/fast/forms/datalist/input-list-expected.txt:
- 10:44 Changeset [124048] by
-
Unreviewed GTK gardening.
Skipping a test that utilizes unsupported isolated worlds and updating
one baseline after r123988.
- platform/gtk/TestExpectations:
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
- 10:41 Changeset [124047] by
-
REGRESSION: Focused TR element draws its focus outline in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=85348
Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-30
Reviewed by Julien Chaffraix.
The focus ring used to be drawn around the first row of the table section irrespective of the row in focus.
The issue was fixed by the bug http://www.webkit.org/b/92389 .
Adding a regression test case.
- fast/table/table-row-focus-ring-paint-expected.txt: Added.
- fast/table/table-row-focus-ring-paint.html: Added.
- platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Added.
- platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Added.
- 10:40 Changeset [124046] by
-
Added a SkiaGraphics definition to the watchlist file; cc'ed myself
to that group. Unreviewed.
- Scripts/webkitpy/common/config/watchlist:
- 10:27 Changeset [124045] by
-
Unreviewed, rolling out r123966 and r123967.
http://trac.webkit.org/changeset/123966
http://trac.webkit.org/changeset/123967
https://bugs.webkit.org/show_bug.cgi?id=92656
This patch is causing assertion failures on the debug bot
(also rolling out a dependent patch) (Requested by mrobinson
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30
Source/WebCore:
- GNUmakefile.am:
- GNUmakefile.list.am:
- platform/text/gtk/TextCheckerEnchant.cpp: Removed.
- platform/text/gtk/TextCheckerEnchant.h: Removed.
Source/WebKit/gtk:
- webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(createEnchantBrokerIfNeeded):
(freeSpellCheckingLanguage):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(wordEndIsAContractionApostrophe):
(checkSpellingOfString):
(getGuessesForWord):
(getAvailableDictionariesCallback):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):
Source/WebKit2:
- GNUmakefile.am:
- GNUmakefile.list.am:
- UIProcess/API/gtk/WebKitPrivate.h:
- UIProcess/API/gtk/WebKitTextChecker.cpp: Removed.
- UIProcess/API/gtk/WebKitTextChecker.h: Removed.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate):
(createDefaultWebContext):
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(beforeAll):
Tools:
- gtk/generate-gtkdoc:
(get_webkit2_options):
- 10:24 Changeset [124044] by
-
ASSERTION FAILED: !rect.isEmpty() : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect &)
https://bugs.webkit.org/show_bug.cgi?id=92187
Reviewed by Simon Fraser.
Source/WebCore:
The border painting logic (RenderBoxModelObject::paintOneBorderSide) would pass a rect with a 0px length
to RenderObject::drawLineForBoxSide. We do check the width (thickness) but not the length so we would pass
the rect to GraphicsContext and hit the ASSERT. This change adds a check for the length too as it is the safest
way, it means that we may still do unneeded operations before bailing out but that's an existing problem in the code.
Tests: fast/borders/0px-borders-no-line-height.html
fast/borders/double-1px-border-assert.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
Added a 0px length check. While renaming confusing variables and re-using others,
I also found a potential empty border that I fixed (tested by the 2nd case above).
LayoutTests:
- fast/borders/0px-borders-no-line-height-expected.html: Added.
- fast/borders/0px-borders-no-line-height.html: Added.
- fast/borders/double-1px-border-assert-expected.html: Added.
- fast/borders/double-1px-border-assert.html: Added.
- 10:24 Changeset [124043] by
-
Merged r116647. <rdar://problem/11942030>
- 10:22 Changeset [124042] by
-
[chromium] Refactor the computation of resampled bitmap size in
drawImage and drawPattern.
https://bugs.webkit.org/show_bug.cgi?id=92408
Reviewed by Adrienne Walker.
Source/WebCore:
We used to have a special-purpose function called TransformDimensions()
which did pretty much the same thing as SkRect::mapRect() does. This
change unifies the drawPattern code to use mapRect() in the same way
that drawImage() does.
Covered by existing tests, e.g., fast/backgrounds/size/*.
- platform/graphics/skia/ImageSkia.cpp:
(WebCore):
(WebCore::Image::drawPattern):
Note: we're now doing using the original (float) source rect, and
converting to int only after applying the matrix transform. This
might result in different decisions about resampling mode, but it's
more correct anyway.
LayoutTests:
Mark a test as expected to fail (will need rebaseline).
- platform/chromium/TestExpectations:
- 10:19 Changeset [124041] by
-
[EFL][DRT] fast/text/font-variant-ligatures.html fails with missing rendering output
https://bugs.webkit.org/show_bug.cgi?id=85606
Unreviewed, EFL gardening.
Unskip test that's passing after r123864 due to complex font support.
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-30
- platform/efl/TestExpectations: font-variant-ligatures.html unskipped.
- 10:18 Changeset [124040] by
-
Merged r116642. <rdar://problem/11942097>
- 10:17 Changeset [124039] by
-
[GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=92626
Reviewed by Gustavo Noronha Silva.
Instead of always shelling out to enter a jhbuild environment, add a Python
hook for entering a jhbuild environment directly. This avoids requiring a
script to be wrapped in jhbuild.
- GNUmakefile.am: Remove gtk/run-api-tests from the distribution list.
- Scripts/run-gtk-tests: Move most of the logic from run-api-tests here
with additional code for entering a jhbuild environment directly.
- gtk/run-api-tests: Removed.
- jhbuild/jhbuild-wrapper: Use the new helper methods defined in jhbuildutils.py.
- jhbuild/jhbuildutils.py: Add some new helper methods here including
a method which can transform the current environment into a jhbuild-ified one.
- 10:12 Changeset [124038] by
-
Merged r116551. <rdar://problem/11942093>
- 10:07 Changeset [124037] by
-
Merged r116545. <rdar://problem/11942059>
- 10:04 Changeset [124036] by
-
Merged r116476. <rdar://problem/11942023>
- 09:35 Changeset [124035] by
-
Unreviewed, upgrade apavlov to reviewer.
http://lists.webkit.org/mailman/private/webkit-committers/2012-July/000184.html
- Scripts/webkitpy/common/config/committers.py:
- 09:32 Changeset [124034] by
-
https://bugs.webkit.org/show_bug.cgi?id=92642
[Bindings]Remove custom JS/V8 bindings for WebSocket::close() using [Clamp]
Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-07-30
Reviewed by Kentaro Hara.
With support of [Clamp] as extended attribute we can replace custom bindings from WebSocket::close().
Spec for WebSocket::close() : http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#websocket
No new tests. There should be no behavioural changes
Existing tests under http/websocket/tests/hybi/ should cover this.
- Modules/websockets/WebSocket.h:
(WebCore::WebSocket::close):
- Modules/websockets/WebSocket.idl: Used [Clamp].
- bindings/js/JSWebSocketCustom.cpp: Removed custom call close().
(WebCore):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
- bindings/v8/custom/V8WebSocketCustom.cpp: Removed custom call close().
(WebCore):
- 09:19 Changeset [124033] by
-
[Qt] Unreviewed gardening. Unkskip more passing tests after bug85203.
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk2/Skipped:
- 08:58 Changeset [124032] by
-
Web Inspector: Resource agent's reference to cached resources should be weak.
https://bugs.webkit.org/show_bug.cgi?id=92108
Reviewed by Pavel Feldman.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
NetworkResourcesData now stores a raw pointer to CachedResource.
CachedResource now notifies InspectorInstrumentation that it will be destroyed.
InspectorInstrumentation stores a set of InstrumentingAgents and broadcasts willDestroyCachedResource event to all available resourceAgents.
Destroyed resources content is saved to NetworkResourcesData.
Tests: http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html
http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html
- WebCore.exp.in:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willDestroyCachedResourceImpl):
(WebCore::InspectorInstrumentation::registerInstrumentingAgents):
(WebCore::InspectorInstrumentation::unregisterInstrumentingAgents):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDestroyCachedResource):
(WebCore):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::willDestroyCachedResource):
(WebCore):
(WebCore::InspectorResourceAgent::getResponseBody):
- inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::setContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore):
- inspector/NetworkResourcesData.h:
(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::base64Encoded):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):
(WebCore):
- loader/cache/CachedResource.h:
(CachedResource):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::clearPreloads):
- loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::evict):
- testing/InternalSettings.cpp:
- testing/Internals.cpp:
(WebCore::Internals::garbageCollectDocumentResources):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Added.
- http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Added.
- http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Added.
- http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Added.
- 08:54 Changeset [124031] by
-
[BlackBerry] Adapt to changes in the SharedArray platform API
https://bugs.webkit.org/show_bug.cgi?id=92631
Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-07-30
Reviewed by Rob Buis.
Adapt to changes in the SharedArray platform API. No behavioural change.
Source/WebKit/blackberry:
Reviewed internally by Joe Mason.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::getBackForwardList):
- Api/WebPage.h:
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::runOpenPanel):
Tools:
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::webHistoryItemCount):
- 08:47 Changeset [124030] by
-
[Qt] Gardening. Skip failing tests and add a Qt specific expected file.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-07-30
Reviewed by Csaba Osztrogonác.
- platform/qt-4.8/Skipped: Skip svg/custom/svg-features.html.
- platform/qt/Skipped: Skip http/tests/security/contentSecurityPolicy/object-src-none-blocked.html.
- platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added because of a whitespace difference.
- 08:43 Changeset [124029] by
-
[Qt] Default sizes for input-text and text-area are different when running DRT/WTR
https://bugs.webkit.org/show_bug.cgi?id=91990
Unreviewed gardening.
- platform/qt-5.0-wk2/Skipped: Skip tests.
- platform/qt-5.0/Skipped: Unskip accidentally skipped tests.
- platform/qt.5-0/fast/text/whitespace/028-expected.png: Remove accidentally committed file.
- platform/qt.5-0/fast/text/whitespace/028-expected.txt: Remove accidentally committed file.
- platform/qt/Skipped: Unskip non-existing tests.
- 08:39 Changeset [124028] by
-
[EFL] Skip new compositing tests for EFL port
https://bugs.webkit.org/show_bug.cgi?id=92633
Unreviewed EFL gardening.
Skip new compositing layout tests until accelerated compositing is enabled.
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-07-30
- platform/efl/TestExpectations:
- 08:16 Changeset [124027] by
-
Prohibit having AuthorShadowDOM of input or textarea element for a while and having a flag to enable it in Internals.
https://bugs.webkit.org/show_bug.cgi?id=92611
Reviewed by Hajime Morita.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Prohibit having AuthorShadowDOM of input elemnet unless a flag in RuntimeEnabledFeatures is not enabled.
The flag can be enabled in Internals.
The elements in UserAgentShadowDOM of input element assume that they have a renderer when the input
element has a renderer. However, this does not hold when AuthorShadowDOM is added to input element.
So until we fix the issue, we should disable to have AuthorShadowDOM for input element, because it may
cause crashes and security problems.
Tests: fast/dom/shadow/input-with-validation-without-shadow.html
fast/dom/shadow/input-with-validation.html
fast/dom/shadow/shadow-disable.html
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::authorShadowDOMForAnyElementEnabled):
(WebCore::RuntimeEnabledFeatures::setAuthorShadowDOMForAnyElementEnabled):
- dom/ShadowRoot.cpp:
(WebCore::allowsAuthorShadowRoot): The input element or textarea element does not allow to have a ShadowDOM unless
is a flag in RuntimeEnabledFeatures is not enabled.
- html/HTMLInputElement.h:
(WebCore::isHTMLInputElement):
(WebCore):
- html/HTMLTextAreaElement.h:
(WebCore::isHTMLTextAreaElement):
(WebCore):
- testing/Internals.cpp:
(WebCore::Internals::setAuthorShadowDOMForAnyElementEnabled):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
- fast/dom/shadow/input-with-validation-without-shadow.html: Make the test runs even if
new WebKitShadowRoot() throws an exception.
- fast/dom/shadow/input-with-validation.html: Sets a flag to make AuthorShadowDOM available.
- fast/dom/shadow/shadow-disable-expected.txt:
- fast/dom/shadow/shadow-disable.html: Makes it unavailable for input and textarea to have an AuthorShadowDOM.
- 08:12 Changeset [124026] by
-
Web Inspector: support --line-numbers mapping for SASS
https://bugs.webkit.org/show_bug.cgi?id=92400
Reviewed by Vsevolod Vlasov.
There is --debug-info and --line-numbers ways of referencing the source scss file, adding support for --line-numbers here.
- inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
(WebInspector.SASSSourceMapping.prototype._resourceAdded):
(_bindUISourceCode):
- 07:32 Changeset [124025] by
-
Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075
Reviewed by Kent Tamura.
Source/Platform:
- chromium/public/WebLocalizedString.h: Added OtherColorLabel.
Source/WebCore:
Test: platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html
- rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Added color to types supporting datalist.
Source/WebKit/chromium:
Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController.
ColorChooserUIController can control whether to open the color suggestion picker
popup or the color chooser depending on the responses from ColorChooserClient.
- WebKit.gyp:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser.
(WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium.
- src/ChromeClientImpl.h:
(WebKit):
(ChromeClientImpl):
- src/ColorChooserProxy.cpp: Removed.
- src/ColorChooserProxy.h: Removed.
- src/ColorChooserUIController.cpp: Added.
(WebKit):
(WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient.
(WebKit::ColorChooserUIController::~ColorChooserUIController):
(WebKit::ColorChooserUIController::setSelectedColor):
(WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser.
(WebKit::ColorChooserUIController::didChooseColor):
(WebKit::ColorChooserUIController::didEndChooser):
(WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size.
(WebKit::ColorChooserUIController::writeDocument):
(WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue.
(WebKit::ColorChooserUIController::didClosePopup):
(WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup.
(WebKit::ColorChooserUIController::closePopup):
(WebKit::ColorChooserUIController::openColorChooser): Opens color chooser.
- src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h.
(WebCore):
(WebKit):
(ColorChooserUIController):
- src/WebColorChooserClientImpl.cpp: Removed.
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Added.
- platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Added. Tests color suggestion picker popup appearance.
- platform/chromium/fast/forms/datalist/input-list-expected.txt:
- 07:23 Changeset [124024] by
-
Wheel events on a page with frames are not handled in fixed layout
https://bugs.webkit.org/show_bug.cgi?id=90550
Reviewed by Antonio Gomes.
Based on patch by Andras Becsi.
Frame-rect size is not the right value to check against to see if the document
can be contained within the full visible content rect, since it does not handle
fixedVisibleContentRect. Instead visibleContentRect(true) should be used which
returns the full visible content rect disregarding scrollbars, and which is
the same a frame-rect size when fixedVisibleContentRect is not set.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
- 07:11 Changeset [124023] by
-
Source/WebCore: There is no way to tell whether an element can be activated or not
https://bugs.webkit.org/show_bug.cgi?id=92093
Reviewed by Antonio Gomes.
This patch adds the willRespondToMouseClickEvents and willRespondToMouseMoveEvents
functions, named after similar functions in the iOS fork of WebKit.
Touch-adjustment will now use these two functions, which improves accuracy when
targeting shadow-dom elements, and also means touch adjustment will prefer enabled
form-elements over disabled ones.
Test: touchadjustment/disabled-formelements.html
- dom/Node.cpp:
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
- dom/Node.h:
(Node):
- editing/DeleteButton.h:
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::willRespondToMouseClickEvents):
- html/HTMLAnchorElement.h:
(HTMLAnchorElement):
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
- html/HTMLButtonElement.h:
(HTMLButtonElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::willRespondToMouseClickEvents):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::willRespondToMouseClickEvents):
- html/HTMLLabelElement.h:
(HTMLLabelElement):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::willRespondToMouseClickEvents):
- html/HTMLMediaElement.h:
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::willRespondToMouseClickEvents):
- html/HTMLSummaryElement.h:
(HTMLSummaryElement):
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::willRespondToMouseClickEvents):
- html/shadow/CalendarPickerElement.h:
(CalendarPickerElement):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::willRespondToMouseClickEvents):
(WebCore::MediaControlTimelineElement::setPosition):
(WebCore::MediaControlVolumeSliderElement::willRespondToMouseMoveEvents):
(WebCore::MediaControlVolumeSliderElement::willRespondToMouseClickEvents):
- html/shadow/MediaControlElements.h:
(MediaControlTimelineElement):
(MediaControlVolumeSliderElement):
- html/shadow/MediaControlRootElement.h:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):
- html/shadow/SliderThumbElement.h:
(SliderThumbElement):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::willRespondToMouseClickEvents):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents):
(WebCore::SpinButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
- html/shadow/TextControlInnerElements.h:
(SearchFieldResultsButtonElement):
(SearchFieldCancelButtonElement):
(SpinButtonElement):
- html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::willRespondToMouseClickEvents):
- html/shadow/TextFieldDecorationElement.h:
(TextFieldDecorationElement):
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
Source/WebKit/gtk: [Gtk] Add WK1 API for snapshot retrieval
https://bugs.webkit.org/show_bug.cgi?id=92261
Reviewed by Martin Robinson.
Add API to WebKitWebView to retrieve a snapshot of its
visible contents as a cairo_surface_t.
- docs/webkitgtk-sections.txt: Add new symbols.
- webkit/webkitwebview.cpp:
(webkit_web_view_get_snapshot): New
method to paint a webview snapshot.
- webkit/webkitwebview.h: Ditto.
LayoutTests: There is no way to tell whether an element can be activated or not
https://bugs.webkit.org/show_bug.cgi?id=92093
Reviewed by Antonio Gomes.
Tests that enabled formelements are now preferred over disabled formelements.
- touchadjustment/disabled-formelements-expected.txt: Added.
- touchadjustment/disabled-formelements.html: Added.
- 06:33 Changeset [124022] by
-
There is no way to tell whether an element can be activated or not
https://bugs.webkit.org/show_bug.cgi?id=92093
Reviewed by Antonio Gomes.
Source/WebCore:
This patch adds the willRespondToMouseClickEvents and willRespondToMouseMoveEvents
functions, named after similar functions in the iOS fork of WebKit.
Touch-adjustment will now use these two functions, which improves accuracy when
targeting shadow-dom elements, and also means touch adjustment will prefer enabled
form-elements over disabled ones.
Test: touchadjustment/disabled-formelements.html
- dom/Node.cpp:
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
- dom/Node.h:
(Node):
- editing/DeleteButton.h:
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::willRespondToMouseClickEvents):
- html/HTMLAnchorElement.h:
(HTMLAnchorElement):
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
- html/HTMLButtonElement.h:
(HTMLButtonElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::willRespondToMouseClickEvents):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::willRespondToMouseClickEvents):
- html/HTMLLabelElement.h:
(HTMLLabelElement):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::willRespondToMouseClickEvents):
- html/HTMLMediaElement.h:
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::willRespondToMouseClickEvents):
- html/HTMLSummaryElement.h:
(HTMLSummaryElement):
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::willRespondToMouseClickEvents):
- html/shadow/CalendarPickerElement.h:
(CalendarPickerElement):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::willRespondToMouseClickEvents):
(WebCore::MediaControlTimelineElement::setPosition):
(WebCore::MediaControlVolumeSliderElement::willRespondToMouseMoveEvents):
(WebCore::MediaControlVolumeSliderElement::willRespondToMouseClickEvents):
- html/shadow/MediaControlElements.h:
(MediaControlTimelineElement):
(MediaControlVolumeSliderElement):
- html/shadow/MediaControlRootElement.h:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):
- html/shadow/SliderThumbElement.h:
(SliderThumbElement):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::willRespondToMouseClickEvents):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents):
(WebCore::SpinButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
- html/shadow/TextControlInnerElements.h:
(SearchFieldResultsButtonElement):
(SearchFieldCancelButtonElement):
(SpinButtonElement):
- html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::willRespondToMouseClickEvents):
- html/shadow/TextFieldDecorationElement.h:
(TextFieldDecorationElement):
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
LayoutTests:
Tests that enabled formelements are now preferred over disabled formelements.
- touchadjustment/disabled-formelements-expected.txt: Added.
- touchadjustment/disabled-formelements.html: Added.
- 06:29 Changeset [124021] by
-
Web Inspector: Content size variables in NetworkResourcesData should have size_t type instead of int.
https://bugs.webkit.org/show_bug.cgi?id=92618
Reviewed by Yury Semikhatsky.
Source/WebCore:
Changed content size variables type in NetworkResourcesData from int to size_t.
Drive-by: Switched String length calculation to recently added StringImpl's sizeInBytes.
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::removeContent):
(WebCore::NetworkResourcesData::ResourceData::dataLength):
(WebCore::NetworkResourcesData::ResourceData::appendData):
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
(WebCore::NetworkResourcesData::ensureFreeSpace):
- inspector/NetworkResourcesData.h:
(ResourceData):
(NetworkResourcesData):
LayoutTests:
- http/tests/inspector/network/network-content-replacement-embed-expected.txt:
- http/tests/inspector/network/network-content-replacement-embed.html:
- http/tests/inspector/network/network-content-replacement-xhr-expected.txt:
- http/tests/inspector/network/network-content-replacement-xhr.html:
- 06:21 Changeset [124020] by
-
[Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work
https://bugs.webkit.org/show_bug.cgi?id=92627
Patch by Balazs Kelemen <kbalazs@webkit.org> on 2012-07-30
Reviewed by Noam Rosenthal.
Remove the default behavior I added in r123729 so that we run all tests as pixel
test with -p. It was intentional but it seems like we don't have consensus on
that we want it.
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._supports_switching_pixel_tests_per_test):
- 06:20 Changeset [124019] by
-
Remove an useless member variable, m_shouldPreventDispatch, from EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=92625
Reviewed by Hajime Morita.
EventDispatcher::m_shouldPreventDispatch does not have any effects. We can remove that.
No new tests, no behavior change.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEvent):
- dom/EventDispatcher.h:
(EventDispatcher):
- 06:17 Changeset [124018] by
-
[Qt][WK1] Gardening after r123988. It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail
https://bugs.webkit.org/show_bug.cgi?id=92636
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-30
Reviewed by Csaba Osztrogonác.
- platform/qt-4.8/Skipped:
- platform/qt-5.0-wk1/Skipped:
- 05:59 Changeset [124017] by
-
Web Inspector: make MemoryInstrumentation methods private
https://bugs.webkit.org/show_bug.cgi?id=92379
Reviewed by Vsevolod Vlasov.
MemoryInstrumentation was refactored.
- All reporting methods on MemoryInstrumentation except add*Object are private to enforce MemoryClassInfo usage.
- MemoryInstrumentation::Add*Member methods renamed to Add*Object
- String reporting is implemented directly in the MemoryInstrumentation, not in its descendants.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
- dom/MemoryInstrumentation.cpp: Added.
(WebCore):
(WebCore::MemoryInstrumentation::addString):
- dom/MemoryInstrumentation.h:
(WebCore::MemoryInstrumentation::addInstrumentedObject):
(WebCore::MemoryInstrumentation::addObject):
(MemoryInstrumentation):
(InstrumentedPointerBase):
(WebCore::MemoryInstrumentation::InstrumentedPointerBase::~InstrumentedPointerBase):
(InstrumentedPointer):
(WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer):
(WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedObject):
(WebCore::MemoryInstrumentation::OwningTraits::addObject):
(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl):
(WebCore::MemoryClassInfo::addInstrumentedMember):
(WebCore::MemoryClassInfo::addMember):
(WebCore):
(WebCore::MemoryInstrumentation::addObjectImpl):
(WebCore::MemoryInstrumentation::addInstrumentedCollection):
(WebCore::MemoryInstrumentation::calculateContainerSize):
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
- 05:51 Changeset [124016] by
-
Web Inspector: [Styles] No color swatch for the SVG "fill" and "stroke" property values
https://bugs.webkit.org/show_bug.cgi?id=92638
Reviewed by Vsevolod Vlasov.
Added the "fill" and "stroke" properties to the list of color-aware properties.
- inspector/front-end/CSSKeywordCompletions.js:
- 05:21 Changeset [124015] by
-
Unreviewed, rolling out r124000.
http://trac.webkit.org/changeset/124000
https://bugs.webkit.org/show_bug.cgi?id=92632
seems to have broken chromium Range_InstanceSizeUnknown unit
test across many platforms (Requested by tomhudson on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- WebCore.exp.in:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::getResponseBody):
- inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::setContent):
(WebCore::NetworkResourcesData::setResourceContent):
- inspector/NetworkResourcesData.h:
(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):
(WebCore):
- loader/cache/CachedResource.h:
(CachedResource):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::clearPreloads):
- loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::evict):
- testing/InternalSettings.cpp:
- testing/Internals.cpp:
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Removed.
- http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Removed.
- http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Removed.
- http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Removed.
- 04:38 Changeset [124014] by
-
Remove an unused member variable, m_originalTarget, from EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=92614
Reviewed by Andreas Kling.
No one uses EventDispatcher::m_originalTarget.
No new tests, no behavior change.
- dom/EventDispatcher.h:
(EventDispatcher):
- 04:33 Changeset [124013] by
-
[Qt] Remove accurateVisibleContentsPosition and use a FloatRect for visibleContentsRect instead
https://bugs.webkit.org/show_bug.cgi?id=92536
Reviewed by Noam Rosenthal.
AccurateVisibleContentsPosition carries the same information as visibleContentsRect.location() and
is needed for fixed layer position updates.
This patch instead uses a FloatRect for the visible contents rect from the web view down to the
LayerCoordinatorProxy, and converts it to an IntRect at this moment, before sending it to the
web process.
This also moves the check to prevent sending the same rect to the moment of the conversion
in LayerTreeCoordinatorProxy to fix a bug where the fixed layer deltas wouldn't be updated
unless the integer part of position components changed.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::updateViewportSize):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setVisibleContentsRect):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):
- UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
- UIProcess/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::LayerTreeCoordinatorProxy):
(WebKit::LayerTreeCoordinatorProxy::setVisibleContentsRect):
- UIProcess/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
- UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::setVisibleContentsRect):
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
- UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
- UIProcess/qt/QtViewportHandler.cpp:
(WebKit::QtViewportHandler::visibleContentsRect):
(WebKit::QtViewportHandler::informVisibleContentChange):
- UIProcess/qt/QtViewportHandler.h:
(QtViewportHandler):
- 04:31 Changeset [124012] by
-
[Qt] Fix issues remaining with fixed positioned layers
https://bugs.webkit.org/show_bug.cgi?id=92528
Reviewed by Noam Rosenthal.
Source/WebCore:
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
Make sure that the delta is used when syncCompositingStateSelf is called afterward.
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
- platform/graphics/texmap/TextureMapperLayer.h:
Use a FloatSize instead of an IntPoint for the delta.
(TextureMapperLayer):
(WebCore::TextureMapperLayer::adjustedPosition):
Source/WebKit2:
This partially fixes jittering of fixed layers when zoomed in and the
blurriness of rendered tiles of the non-composited contents layer.
- UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::boundedScrollPosition):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
Remove the adjustment on the root layer. This cancels setPixelAligned and causes the blurriness.
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
Use m_accurateVisibleContentsPosition to calculate the delta.
(WebKit::WebLayerTreeRenderer::didChangeScrollPosition):
- 03:33 Changeset [124011] by
-
[DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091
Reviewed by Hajime Morita.
Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
- public/WebFrame.h:
(WebFrame):
- src/WebFrameImpl.cpp:
(WebKit):
- src/WebFrameImpl.h:
(WebFrameImpl):
- 03:25 Changeset [124010] by
-
Replace UnicodeWinCE with UnicodeWchar https://bugs.webkit.org/show_bug.cgi?id=92539
Reviewed by Ryosuke Niwa.
UnicodeWinCE never contained WinCE specific code. UnicodeWchar
is a replacement for it, which is mainly based on the functions
from <wchar.h>. It is ment as a minimal Unicode backend, which
can be used very easy and has no external dependencies.
.:
- Source/cmake/OptionsWinCE.cmake:
Source/WebCore:
- platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::encode):
- platform/text/TextEncodingRegistry.cpp:
(WebCore::extendTextCodecMaps):
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataUseFeatures.in:
Source/WTF:
- WTF.gyp/WTF.gyp:
- WTF.gypi:
- wtf/Platform.h:
- wtf/PlatformWinCE.cmake:
- wtf/unicode/Unicode.h:
- wtf/unicode/wchar/UnicodeWchar.cpp: Added.
(Unicode):
(WTF::Unicode::category):
(WTF::Unicode::combiningClass):
(WTF::Unicode::direction):
(WTF::Unicode::decompositionType):
(WTF::Unicode::hasLineBreakingPropertyComplexContext):
(WTF::Unicode::mirroredChar):
(WTF::Unicode::convertWithFunction):
(WTF::Unicode::foldCase):
(WTF::Unicode::toLower):
(WTF::Unicode::toUpper):
- wtf/unicode/wchar/UnicodeWchar.h: Added.
(Unicode):
(WTF::Unicode::isAlphanumeric):
(WTF::Unicode::isDigit):
(WTF::Unicode::isLetter):
(WTF::Unicode::isLower):
(WTF::Unicode::isPrintableChar):
(WTF::Unicode::isPunct):
(WTF::Unicode::isSpace):
(WTF::Unicode::isUpper):
(WTF::Unicode::isArabicChar):
(WTF::Unicode::isSeparatorSpace):
(WTF::Unicode::foldCase):
(WTF::Unicode::toLower):
(WTF::Unicode::toUpper):
(WTF::Unicode::toTitleCase):
(WTF::Unicode::umemcasecmp):
- wtf/unicode/wince/UnicodeWinCE.cpp: Removed.
- wtf/unicode/wince/UnicodeWinCE.h: Removed.
- 02:45 Changeset [124009] by
-
Remove unnecessary code which set event's target from EventDispatcher::dispatchEvent.
https://bugs.webkit.org/show_bug.cgi?id=92613
Reviewed by Hajime Morita.
EventContext::handleLocalEvents does all required jobs so we don't
need to set target in EventDispacher::dispatchEvent() for TARGET phase.
No new tests, no behavior change.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
- 02:29 Changeset [124008] by
-
Unreviewed, rolling out r124004.
http://trac.webkit.org/changeset/124004
https://bugs.webkit.org/show_bug.cgi?id=92622
Broke Android build (Requested by keishi on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30
Source/Platform:
- chromium/public/WebLocalizedString.h:
Source/WebCore:
- rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI):
Source/WebKit/chromium:
- WebKit.gyp:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser):
- src/ChromeClientImpl.h:
(WebCore):
(ChromeClientImpl):
- src/ColorChooserProxy.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(WebKit::ColorChooserProxy::ColorChooserProxy):
(WebKit::ColorChooserProxy::~ColorChooserProxy):
(WebKit::ColorChooserProxy::setSelectedColor):
(WebKit::ColorChooserProxy::endChooser):
- src/ColorChooserProxy.h: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(ColorChooserProxy):
- src/ColorChooserUIController.cpp: Removed.
- src/WebColorChooserClientImpl.cpp: Copied from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebKit):
(WebKit::WebColorChooserClientImpl::WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::~WebColorChooserClientImpl):
(WebKit::WebColorChooserClientImpl::didChooseColor):
(WebKit::WebColorChooserClientImpl::didEndChooser):
- src/WebColorChooserClientImpl.h: Renamed from Source/WebKit/chromium/src/ColorChooserUIController.h.
(WebCore):
(WebKit):
(WebColorChooserClientImpl):
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Removed.
- platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Removed.
- platform/chromium/fast/forms/datalist/input-list-expected.txt:
- 02:25 Changeset [124007] by
-
Web Inspector: element tag disappears after editing
https://bugs.webkit.org/show_bug.cgi?id=92385
Reviewed by Vsevolod Vlasov.
This has regressed when we started hiding elements panel upon
batch updates. Narrowing hiding cases, updating selection
in on-screen mode only.
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.updateSelection):
- 02:05 Changeset [124006] by
-
Web Inspector: move StringImpl size calculation to StringImpl
https://bugs.webkit.org/show_bug.cgi?id=92359
Reviewed by Pavel Feldman.
Moved stringSize(StringImpl*) implementation from InspectorMemoryAgent to
StringImpl::sizeInBytes();
Source/WebCore:
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
Source/WTF:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::sizeInBytes):
(WTF):
- wtf/text/StringImpl.h:
(StringImpl):
- 01:57 Changeset [124005] by
-
Web Inspector: workers inspector is broken in the remote debugging mode
https://bugs.webkit.org/show_bug.cgi?id=92540
Reviewed by Yury Semikhatsky.
The problem was that worker manager re-used complete url with query parameters
for spin-off worker front-ends. As a result, in case of remote debugging, newly
created front-ends were connecting to the same web socket (because of the ws parameter).
- inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.isDedicatedWorkerFrontend):
- inspector/front-end/inspector.js:
- 01:33 Changeset [124004] by
-
Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075
Reviewed by Kent Tamura.
Source/Platform:
- chromium/public/WebLocalizedString.h: Added OtherColorLabel.
Source/WebCore:
Test: platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html
- rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Added color to types supporting datalist.
Source/WebKit/chromium:
Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController.
ColorChooserUIController can control whether to open the color suggestion picker
popup or the color chooser depending on the responses from ColorChooserClient.
- WebKit.gyp:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser.
(WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium.
- src/ChromeClientImpl.h:
(WebKit):
(ChromeClientImpl):
- src/ColorChooserProxy.cpp: Removed.
- src/ColorChooserProxy.h: Removed.
- src/ColorChooserUIController.cpp: Added.
(WebKit):
(WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient.
(WebKit::ColorChooserUIController::~ColorChooserUIController):
(WebKit::ColorChooserUIController::setSelectedColor):
(WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser.
(WebKit::ColorChooserUIController::didChooseColor):
(WebKit::ColorChooserUIController::didEndChooser):
(WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size.
(WebKit::ColorChooserUIController::writeDocument):
(WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue.
(WebKit::ColorChooserUIController::didClosePopup):
(WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup.
(WebKit::ColorChooserUIController::closePopup):
(WebKit::ColorChooserUIController::openColorChooser): Opens color chooser.
- src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h.
(WebCore):
(WebKit):
(ColorChooserUIController):
- src/WebColorChooserClientImpl.cpp: Removed.
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Added.
- platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Added. Tests color suggestion picker popup appearance.
- platform/chromium/fast/forms/datalist/input-list-expected.txt:
- 01:28 Changeset [124003] by
-
REGRESSION (r123767): platform/gtk/accessibility/object-with-title.html failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=92477
Reviewed by Chris Fleizach.
Source/WebCore:
Consider title and accessibilityDescription together with helpText to
decide whether an object should be exposed in the accessibility tree.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
LayoutTests:
Remove passing test from TestExpectations.
- platform/gtk/TestExpectations:
- 01:18 Changeset [124002] by
-
Unreviewed Qt/Mac build fix: Use libWebKitSystemInterfaceMountainLion.a
on Mountain Lion.
- WebKit1.pri:
- 00:58 Changeset [124001] by
-
[EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.
https://bugs.webkit.org/show_bug.cgi?id=92366
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-30
Reviewed by Antonio Gomes.
Add SHIFT modifier for capital letters as VK_
codes do not distinguish between lows and caps and also to be consistent
with other ports which send caps as lowercase letters with the shift key down.
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::keyDown):
- 00:54 Changeset [124000] by
-
Web Inspector: Resource agent's reference to cached resources should be weak.
https://bugs.webkit.org/show_bug.cgi?id=92108
Reviewed by Pavel Feldman.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
NetworkResourcesData now stores a raw pointer to CachedResource.
CachedResource now notifies InspectorInstrumentation that it will be destroyed.
InspectorInstrumentation stores a set of InstrumentingAgents and broadcasts willDestroyCachedResource event to all available resourceAgents.
Destroyed resources content is saved to NetworkResourcesData.
Tests: http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html
http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html
- WebCore.exp.in:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willDestroyCachedResourceImpl):
(WebCore::InspectorInstrumentation::registerInstrumentingAgents):
(WebCore::InspectorInstrumentation::unregisterInstrumentingAgents):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDestroyCachedResource):
(WebCore):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::willDestroyCachedResource):
(WebCore):
(WebCore::InspectorResourceAgent::getResponseBody):
- inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::setContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore):
- inspector/NetworkResourcesData.h:
(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::base64Encoded):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):
(WebCore):
- loader/cache/CachedResource.h:
(CachedResource):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::clearPreloads):
- loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::evict):
- testing/InternalSettings.cpp:
- testing/Internals.cpp:
(WebCore::Internals::garbageCollectDocumentResources):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit2:
- win/WebKit2.def:
- win/WebKit2CFLite.def:
LayoutTests:
- http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Added.
- http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Added.
- http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Added.
- http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Added.
- 00:29 WebKitIDL edited by
- (diff)
- 00:10 WebKitIDL edited by
- Support for [Clamp] extended attribute. (diff)
07/29/12:
- 23:25 Changeset [123999] by
-
[WK2][EFL] Accelerated compositing support using TextureMapper on Efl WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91583
Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-29
Reviewed by Noam Rosenthal.
This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
This patch adds Texture Mapper related files to PlatformEfl.cmake.
And wrapped TextureMapperLayer and TextureMapperBackingStore with USE(ACCELERATED_COMPOSITING) for fixing building error when disable ACCELERATED_COMPOSITING.
- CMakeLists.txt:
- PlatformEfl.cmake:
- platform/graphics/GraphicsLayer.cpp:
(WebCore):
- platform/graphics/GraphicsLayer.h:
(GraphicsLayer):
- platform/graphics/GraphicsLayerAnimation.cpp:
- platform/graphics/GraphicsLayerAnimation.h:
- platform/graphics/PlatformLayer.h:
(WebCore):
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
- platform/graphics/texmap/TextureMapperBackingStore.h:
- platform/graphics/texmap/TextureMapperLayer.h:
- 23:09 Changeset [123998] by
-
[WK2][EFL] TILED_BACKING_STORE support on Efl WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91582
Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-29
Reviewed by Noam Rosenthal.
Source/WebCore:
This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
This patch adds TILED_BACKING_STORE related files to CMakeLists.txt and PlatformEfl.cmake
- CMakeLists.txt:
- PlatformEfl.cmake:
Source/WebKit/efl:
Add a dummy function for fixing building error when enabling TILED_BACKING_STORE.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore):
(WebCore::ChromeClientEfl::delegatedScrollRequested):
- WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
Source/WebKit2:
This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
Add a dummy function for fixing building error when enabling TILED_BACKING_STORE.
- UIProcess/API/efl/PageClientImpl.cpp:
(WebKit):
(WebKit::PageClientImpl::pageDidRequestScroll):
- UIProcess/API/efl/PageClientImpl.h:
(PageClientImpl):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
- 22:49 Changeset [123997] by
-
Fix removing invalid values from color input suggestions
https://bugs.webkit.org/show_bug.cgi?id=92502
Reviewed by Kent Tamura.
Make ColorInputType::typeMismatchFor() return false for invalid color
values so that they don't appear in the list of suggestions that
ColorInputType::suggestions() returns.
No new tests. Tests to be added in Bug 92075.
- html/ColorInputType.cpp:
(WebCore::ColorInputType::typeMismatchFor):
(WebCore):
- html/ColorInputType.h:
(ColorInputType):
- 22:28 Changeset [123996] by
-
getChannelData should raise exception when index is more than numberOfChannels.
https://bugs.webkit.org/show_bug.cgi?id=92223
Patch by Li Yin <li.yin@intel.com> on 2012-07-29
Reviewed by Kentaro Hara.
Source/WebCore:
Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioBuffer-section
In getChannelData function, the index value MUST be less than numberOfChannels
or an exception will be thrown.
Test: webaudio/audiobuffer.html
- Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::getChannelData):
(WebCore):
- Modules/webaudio/AudioBuffer.h:
(WebCore):
(AudioBuffer):
- Modules/webaudio/AudioBuffer.idl: raise exception when index is not less than numberOfChannels.
LayoutTests:
Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioBuffer-section
Add test to cover basic attributes of AudioBuffer.
- webaudio/audiobuffer-expected.txt: Added.
- webaudio/audiobuffer.html: Added.
- 22:22 Changeset [123995] by
-
forward-delete in the last cell of a table moves the caret after the table
https://bugs.webkit.org/show_bug.cgi?id=24250
Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-07-29
Reviewed by Ryosuke Niwa.
Source/WebCore:
The ForwardDelete command moved the cursor after the table when it's invoked
in an empty cell that is the last cell of a table. It also removed the break
element when invoked in an empty cell that is not the last cell of a table.
Make it do nothing inside an empty table cell.
Test: editing/deleting/forward-delete-empty-table-cell.html
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::forwardDeleteKeyPressed):
LayoutTests:
- editing/deleting/forward-delete-empty-table-cell-expected.txt: Added.
- editing/deleting/forward-delete-empty-table-cell.html: Added.
- 22:17 Changeset [123994] by
-
REGRESSION(r123993): fast/forms/date/calendar-picker-type-change-onclick.html fails
- fast/forms/date/calendar-picker-appearance-expected.txt:
- fast/forms/date/calendar-picker-appearance.html:
Clear webkitTransitionEnd event handler before notifyDone().
- 21:19 Changeset [123993] by
-
Fix opacity issue of fast/forms/date/calendar-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=92605
Reviewed by Hajime Morita.
We need to wait for pixel dumping until CSS transition completion for
the 'main' element, which has transition from opacity:0 to opacity:1.
- fast/forms/date/calendar-picker-appearance.html:
- 18:58 Changeset [123992] by
-
Remove unused method HTMLConstructionSiteTask::take(HTMLConstructionSiteTask&)
https://bugs.webkit.org/show_bug.cgi?id=92601
Patch by Kwang Yul Seo <skyul@company100.net> on 2012-07-29
Reviewed by Adam Barth.
This method was introduced in r104000, but has never been used from the beginning.
No functional change.
- html/parser/HTMLConstructionSite.h:
- 18:46 Changeset [123991] by
-
[Chromium] HarfBuzzShaper can't handle segmented text run
https://bugs.webkit.org/show_bug.cgi?id=92445
Reviewed by Tony Chang.
Pass the range to be displayed to HarfBuzzShaper. The shaper calculates positions and advances of each glyph
regardless of the range, but only add glyphs which are in the range.
No new tests. platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html should
work as expected once we move to use harfbuzz-ng on linux. Note that the current expectation will need to be rebaselined
because the old hb shaper (ComplexTextController) mishandles the range. |to| should be exclusive. I'll rebaseline
the expectation later.
- platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::drawComplexText): Call shaper.setDrawRange().
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setDrawRange): Added.
(WebCore):
(WebCore::HarfBuzzShaper::shouldDrawCharacterAt): Added.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Added variables that hold pending advances.
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun): Add only glyphs which are in the given range to glyphBuffer.
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(HarfBuzzShaper):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::drawComplexText): Call shaper.setDrawRange().
- 18:17 UsingGitHub edited by
- (diff)
- 18:13 FeatureFlags edited by
- Add CSS_COMPOSITING (diff)
- 17:44 Changeset [123990] by
-
Hit testing in the gap between pages returns incorrect results in flipped blocks writing modes
https://bugs.webkit.org/show_bug.cgi?id=92600
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/multicol/hit-test-gap-between-pages-flipped.html
- rendering/RenderBlock.h:
(WebCore::RenderBlock): Promoted offsetForContents() from private to protected, and demoted
adjustPointToColumnContents() back to private.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest): Changed to flip the point passed to updateHitTestResults().
- rendering/RenderView.cpp:
(WebCore::RenderView::updateHitTestResult): Changed to call offsetForContents(), which, as
of r123977, correctly accounts for flippedness.
LayoutTests:
- fast/multicol/hit-test-gap-between-pages-flipped-expected.txt: Added.
- fast/multicol/hit-test-gap-between-pages-flipped.html: Added.
- 16:15 Changeset [123989] by
-
PropertyNameArray::m_shouldCache is only assigned and never used
https://bugs.webkit.org/show_bug.cgi?id=92598
Reviewed by Dan Bernstein.
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::PropertyNameArray):
(PropertyNameArray):
- 15:55 Changeset [123988] by
-
In flipped blocks, a point on the top edge of a text box is considered outside the box (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=92597
Reviewed by Ryosuke Niwa.
Source/WebCore:
This is similar to <http://webkit.org/b/92593> except for RenderText. Fixing this required
fixing some code that creates a point inside a box by setting its y coordinate to the
logical top of the box. In a flipped block, this would be just outside the box.
Enhanced fast/writing-mode/flipped-blocks-hit-test-line-edges.html to cover this.
- editing/visible_units.cpp:
(WebCore::absoluteLineDirectionPointToLocalPointInBlock): Changed to use
RootInlineBox::blockDirectionPointInLine in the vertical case as well.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren): Changed to use
RootInlineBox::blockDirectionPointInLine.
- rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint): Changed the strictness of y inequalities based on
the flippedness of the block. This fixes the bug.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::blockDirectionPointInLine): Moved the implementation here from the
header, and made it return the bottom in the flipped block case, so that the returned point
is inside the line in that case as well.
- rendering/RootInlineBox.h:
LayoutTests:
Added hits inside the text to this test.
- fast/writing-mode/flipped-blocks-hit-test-line-edges-expected.txt:
- fast/writing-mode/flipped-blocks-hit-test-line-edges.html:
- 15:36 Changeset [123987] by
-
[chromium] pass acceleratePainting info to settings
https://bugs.webkit.org/show_bug.cgi?id=92467
Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-07-29
Reviewed by Eric Seidel.
The acceleratePainting info is not passed into settings correctly so
that GPU composition would not use the code path of accelerated painting.
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):
- 15:26 Changeset [123986] by
-
[EFL][jhbuild] Make run-with-jhbuild become the jhbuild process itself.
https://bugs.webkit.org/show_bug.cgi?id=92592
Reviewed by Eric Seidel.
Adapt to the changes made to GTK+'s run-with-jhbuild in r123979
and make EFL's run-with-jhbuild call os.execve() instead of
launching a subprocess as well.
This should make it possible to interrupt execution of jhbuild
cleanly.
- efl/run-with-jhbuild:
- 15:03 Changeset [123985] by
-
run-perf-tests should generate a results page
https://bugs.webkit.org/show_bug.cgi?id=92575
Reviewed by Eric Seidel.
PerformanceTests:
Add a results page template. This page includes flot and flot.fillbetween.
jQuery and the json that contains test results are injected by run-perf-tests.
- resources/results-template.html: Added.
Tools:
Added the ability to generate a results page that summarizes performance test results from
multiple runs of run-perf-tests when --output-json-path is specified and --test-results-server
is not specified. We cannot generate a results page when --test-results-server is specified
because perf-o-matic cannot parse the new JSON format.
The new JSON format is simply an array of the old JSON output. This JSON is then merged into
results-template.html along with jQuery and copied as a HTML file of the same filename as
the output JSON file with a .html extension.
We merge all scripts and the JSON output into the results page as opposed to including them
with the src content attribute to make it standalone so that we may post it on Bugzilla or
e-mail it to someone else without breaking it.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.run):
(PerfTestsRunner._generate_json): Merge "contents" with the existing JSON file when generating
a results page, and generate the results page from results-template.html merged with jQuery and
the generated JSON output.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(_test_run_with_json_output): Extracted from test_run_with_upload_json to be shared with
several test cases.
(_test_run_with_json_output.mock_upload_json): Ditto.
(test_run_with_json_output): Refactored to use _test_run_with_json_output.
(test_run_generates_results_page): Added. Tests the new feature.
(test_run_with_json_source): Refactored to use _test_run_with_json_output.
(test_run_with_multiple_repositories): Ditto.
(test_run_with_upload_json): Ditto.
- 14:59 Changeset [123984] by
-
.: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.
Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.
Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
- Configurations/FeatureDefines.xcconfig:
Source/WebCore: ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.
Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
- GNUmakefile.am:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/chromium: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.
Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
- features.gypi:
Source/WebKit/mac: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.
Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
- Configurations/FeatureDefines.xcconfig:
Tools: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.
Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
- Scripts/webkitperl/FeatureList.pm:
WebKitLibraries: Add ENABLE_CSS_COMPOSITING flag
https://bugs.webkit.org/show_bug.cgi?id=92553
Patch by Rik Cabanier <cabanier@adobe.com> on 2012-07-29
Reviewed by Dirk Schulze.
Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 14:46 Changeset [123983] by
-
[CMake] Use WEBKIT_CREATE_FORWARDING_HEADERS to generate WK2 forwarding headers
https://bugs.webkit.org/show_bug.cgi?id=83579
Reviewed by Daniel Bates.
Using a list of directories in combination with the WEBKIT_CREATE_FORWARDING_HEADERS
macro allows us to share the common generation of forwarding headers across ports.
- CMakeLists.txt:
- PlatformEfl.cmake:
- 14:02 Changeset [123982] by
-
[WIN] Add missing export macro to friend decleration.
Since the declspec is part of the function signature
on windows, we need it at all friend declerations too.
- wtf/MediaTime.h:
- 14:02 Changeset [123981] by
-
[CMake] Add missing MediaTime files after r123878.
- wtf/CMakeLists.txt:
- 10:27 Changeset [123980] by
-
In flipped blocks, a point on the top edge of a box is considered outside the box (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=92593
Reviewed by Simon Fraser.
Source/WebCore:
With respect to hit testing, boxes should always behave as half-open intervals which include
the physical top and left edges and not the bottom and right edges.
RenderBlock::positionForPoint was not adhering to this, since it was comparing flipped
coordinates.
Tests: fast/writing-mode/flipped-blocks-hit-test-box-edges.html
fast/writing-mode/flipped-blocks-hit-test-line-edges.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren): When blocks are flipped, changed
strict inequalities of y coordinates into non-strict ones and non-strict inequalities into
strict ones.
(WebCore::RenderBlock::positionForPoint): Ditto, except for the test for being under the top
of the last candidate box, which was made non-strict in the unflipped case and remained
strict.
LayoutTests:
- fast/writing-mode/flipped-blocks-hit-test-box-edges-expected.txt: Added.
- fast/writing-mode/flipped-blocks-hit-test-box-edges.html: Added.
- fast/writing-mode/flipped-blocks-hit-test-line-edges-expected.txt: Added.
- fast/writing-mode/flipped-blocks-hit-test-line-edges.html: Added.
- 07:49 Changeset [123979] by
-
Reviewed by Martin Robinson.
Make the jhbuild wrapper scripts become the jhbuild process
instead of starting it as a child. This should make it possible to
interrupt execution of jhbuild cleanly.
- gtk/run-with-jhbuild:
- jhbuild/jhbuild-wrapper:
- 04:26 WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 03:17 BuildingGtk edited by
- (diff)
- 02:49 Changeset [123978] by
-
Extend application/x-webkit-test-netscape plugins to better support multiple frames.
https://bugs.webkit.org/show_bug.cgi?id=92478
Patch by Mike West <mkwst@chromium.org> on 2012-07-29
Reviewed by Adam Barth.
Tools:
DumpRenderTree currently understands
<object src="data:application/x-webkit-test-netscape,alertwhenloaded">.
It would be useful if it understood logifloaded, which could give
more context regarding test expectations, and can be written in such
as way as to support plugins loaded into multiple iframes in a single
test.
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
Adding support for logifloaded.
LayoutTests:
- http/tests/plugins/resources/mock-plugin-logger.js:
Exciting JS "framework" for use when logging via logifloaded.
- http/tests/security/contentSecurityPolicy/object-src-none-allowed.html:
- http/tests/security/contentSecurityPolicy/object-src-none-allowed-expected.html:
- http/tests/security/contentSecurityPolicy/object-src-none-blocked.html:
- http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.html:
Adjusting these tests to use the newly created logifloaded plugin mock.
- http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl:
Loading mock-plugin-logger.js, and adding a log attribute for logifloaded.
07/28/12:
- 21:59 Changeset [123977] by
-
Source/WebCore: RenderBlock::offsetForContents() is wrong in flipped blocks writing modes
https://bugs.webkit.org/show_bug.cgi?id=92588
Reviewed by Sam Weinig.
Tests: fast/multicol/hit-test-block-axis-flipped.html
fast/writing-mode/flipped-blocks-hit-test-overflow-scroll.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::offsetForContents): Flip the point, which puts it back in unflipped
coordinates, before adding the scroll offset and adjusting for columns, then flip it back.
(WebCore::RenderBlock::adjustPointToColumnContents): Changed the inline-axis cases to
work with an unflipped point.
LayoutTests: Hit test results are wrong in flipped blocks writing modes with block column axis
https://bugs.webkit.org/show_bug.cgi?id=92588
Reviewed by Sam Weinig.
- fast/multicol/hit-test-block-axis-flipped-expected.txt: Added.
- fast/multicol/hit-test-block-axis-flipped.html: Added.
- 20:38 Changeset [123976] by
-
Stop copying unnecessary files in WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=92587
Reviewed by Dan Bernstein.
- WebKit2.xcodeproj/project.pbxproj:
We were accidentally copying ColorSpaceData.h and EventDispatcher.messages.in into the
build products. Stop this.
- 18:35 Changeset [123975] by
-
[Chromium] New baselines and test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=72039
https://bugs.webkit.org/show_bug.cgi?id=92569
https://bugs.webkit.org/show_bug.cgi?id=92583
Unreviewed, test expectations update.
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
- platform/chromium-mac-snowleopard/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
- platform/chromium-mac/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
- platform/chromium/TestExpectations:
- 16:28 Changeset [123974] by
-
[WK2][EFL] Add ewk_view_scale_{get|set} to EwkView.
https://bugs.webkit.org/show_bug.cgi?id=92446
Reviewed by Kenneth Rohde Christiansen.
Add methods to Ewk_View to get or set the scale factor of page.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_scale_set):
(ewk_view_scale_get):
- UIProcess/API/efl/ewk_view.h:
- 14:40 Changeset [123973] by
-
In flipped lines writing modes, hit testing at the beginning of a column may return a result from the previous column
https://bugs.webkit.org/show_bug.cgi?id=92566
Reviewed by Simon Fraser.
Source/WebCore:
Enhanced the fix for <http://webkit.org/b/92524> to work with flipped lines.
Extended fast/multicol/hit-test-end-of-column-with-line-height.html.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren): For flipped lines, check if the
hit line is the last one before a page break, and in that case, check if the hit point was
after the break.
LayoutTests:
- fast/multicol/hit-test-end-of-column-with-line-height-expected.txt: Updated.
- fast/multicol/hit-test-end-of-column-with-line-height.html: Extended with tests for
horizontal-bt.
- 14:32 Changeset [123972] by
-
Size changes on a layer with negative z-index children don't repaint correctly
https://bugs.webkit.org/show_bug.cgi?id=92583
Reviewed by Dean Jackson.
Source/WebCore:
Negative z-index descendants cause a composited layer to have a separate
layer for foreground content. If something caused that foreground layer
to change size (like toggling visibility on a descendant), we failed to
repaint the foreground layer, resulting in stretched content.
Test: compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Repaint the foreground
layer if its size changes, like we do for the main layer.
LayoutTests:
Test that causes a composited layer with a foreground layer (by virtue of having
negative z-index children) to resize.
Add missing pixel result for bounds-ignores-hidden-dynamic.html too.
- compositing/geometry/bounds-ignores-hidden-dynamic-expected.png: Added.
- compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
- compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Added.
- compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html: Added.
- 12:44 Changeset [123971] by
-
Ignore visibility:hidden elements when computing compositing layer bounds
https://bugs.webkit.org/show_bug.cgi?id=92569
Reviewed by Dan Bernstein.
Source/WebCore:
When computing the bounds of compositing layers, we would take into account
layers with no visible content (visibility:hidden, and no non-hidden descendants).
This caused some huge layers in mobile Google maps.
Tests: compositing/geometry/bounds-ignores-hidden-composited-descendant.html
compositing/geometry/bounds-ignores-hidden-dynamic.html
compositing/geometry/bounds-ignores-hidden.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateLayerBounds): If the ExcludeHiddenDescendants flag is set, return
the empty rect for layers with no visible content or descendants, as long as the layer is not
the root of the subtree whose bounds are being computed.
calculateLayerBounds() currently (I think incorrectly) passes the default flags to the recursive calls.
It should probably just pass 'flags', but to make this change safe, OR in the ExcludeHiddenDescendants
flag.
- rendering/RenderLayer.h: Add an ExcludeHiddenDescendants flag to the CalculateLayerBoundsFlags.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds): Pass the ExcludeHiddenDescendants
flag.
LayoutTests:
Tests related to visibility:hidden's affect on composited layer bounds.
- compositing/geometry/bounds-ignores-hidden-composited-expected.txt: Added.
- compositing/geometry/bounds-ignores-hidden-composited-descendant.html: Added.
Test with visibility:visible descendants of a visibility:hidden element in a
compositing layer.
- compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt: Added.
- compositing/geometry/bounds-ignores-hidden-dynamic.html: Added.
Test that changes visibility on descendants of a compositing layer, to test dynamic changes.
- compositing/geometry/bounds-ignores-hidden-expected.txt: Added.
- compositing/geometry/bounds-ignores-hidden.html: Added.
Test with a compositing layer having visibility:hidden descendants, which dumps
layer tree information.
- 12:35 Changeset [123970] by
-
[Chromium] Widen expectation for crashing test.
http://crbug.com/139493
Unreviewed, test expectations update.
- platform/chromium/TestExpectations:
- 12:23 Changeset [123969] by
-
Add an overlay play button to media controls on android
https://bugs.webkit.org/show_bug.cgi?id=92132
Patch by Min Qin <qinmin@chromium.org> on 2012-07-28
Reviewed by Adam Barth.
This change adds an overlay play button to the media controls for android.
No tests for now as this setting is not being used by other port.
Will add a test and adjust all the test expectations when we upstream the layout tests for android.
- WebCore.gypi:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- css/mediaControls.css:
(audio::-webkit-media-controls-overlay-play-button, video::-webkit-media-controls-overlay-play-button):
- css/mediaControlsChromiumAndroid.css:
(audio::-webkit-media-controls-overlay-enclosure):
(video::-webkit-media-controls-overlay-enclosure):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(video::-webkit-media-controls-overlay-play-button):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlOverlayPlayButtonElement::MediaControlOverlayPlayButtonElement):
(WebCore):
(WebCore::MediaControlOverlayPlayButtonElement::create):
(WebCore::MediaControlOverlayPlayButtonElement::defaultEventHandler):
(WebCore::MediaControlOverlayPlayButtonElement::updateDisplayType):
(WebCore::MediaControlOverlayPlayButtonElement::shadowPseudoId):
- html/shadow/MediaControlElements.h:
(MediaControlOverlayPlayButtonElement):
(WebCore):
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlPanelEnclosureElement::MediaControlPanelEnclosureElement):
(WebCore::MediaControlPanelEnclosureElement::create):
(WebCore):
(WebCore::MediaControlPanelEnclosureElement::shadowPseudoId):
(WebCore::MediaControlRootElementChromium::create):
(WebCore::MediaControlRootElementChromium::initializeControls):
- html/shadow/MediaControlRootElementChromium.h:
(MediaControlChromiumEnclosureElement):
(WebCore):
(MediaControlPanelEnclosureElement):
(MediaControlRootElementChromium):
- html/shadow/MediaControlRootElementChromiumAndroid.cpp: Added.
(WebCore):
(WebCore::MediaControlOverlayEnclosureElement::MediaControlOverlayEnclosureElement):
(WebCore::MediaControlOverlayEnclosureElement::create):
(WebCore::MediaControlOverlayEnclosureElement::shadowPseudoId):
(WebCore::MediaControlRootElementChromiumAndroid::MediaControlRootElementChromiumAndroid):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElementChromiumAndroid::create):
(WebCore::MediaControlRootElementChromiumAndroid::setMediaController):
(WebCore::MediaControlRootElementChromiumAndroid::playbackStarted):
(WebCore::MediaControlRootElementChromiumAndroid::playbackStopped):
- html/shadow/MediaControlRootElementChromiumAndroid.h: Added.
(WebCore):
(MediaControlOverlayEnclosureElement):
(MediaControlRootElementChromiumAndroid):
- platform/ThemeTypes.h:
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaOverlayPlayButton):
(WebCore):
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaOverlayPlayButton):
- rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::paintMediaOverlayPlayButton):
(WebCore):
- rendering/RenderThemeChromiumAndroid.h:
- 12:22 Changeset [123968] by
-
Fix Chromium/Win compile.
https://bugs.webkit.org/show_bug.cgi?id=88787
Unreviewed, build fix.
Chromium/Win needs _USE_MATH_DEFINES but doesn't define PLATFORM(WIN).
The other files in WebKit that define this macro (both in
WebCore/platform/graphics/cg) do it by unconditionally #defining it to 1
above the #include of "config.h", so copy that pattern here.
- TestWebKitAPI/Tests/WTF/MediaTime.cpp:
- 11:45 Changeset [123967] by
-
[WK2][GTK] Implement a new spell checker API for WebKit2GTK+
https://bugs.webkit.org/show_bug.cgi?id=90268
Reviewed by Martin Robinson.
Source/WebKit2:
Add a simple spell checking API to WK2, allowing to enable/disable
this feature and to define a list of languages associated to it.
- GNUmakefile.am: Add flags to handle the SPELLCHECK feature.
- GNUmakefile.list.am: Added new files
Added new internal class that will act both as the implementation
of TextCheckerClient and as the object WebKitWebContext will
depend on to implement the newly added API.
- UIProcess/API/gtk/WebKitTextChecker.cpp: Added.
(toTextChecker):
(continuousSpellCheckingEnabledCallback):
(setContinuousSpellCheckingEnabledCallback):
(checkSpellingOfStringCallback):
(guessesForWordCallback):
(learnWordCallback):
(ignoreWordCallback):
(WebKitTextChecker::~WebKitTextChecker):
(WebKitTextChecker::create):
(WebKitTextChecker::WebKitTextChecker):
(WebKitTextChecker::checkSpellingOfString):
(WebKitTextChecker::getGuessesForWord):
(WebKitTextChecker::learnWord):
(WebKitTextChecker::ignoreWord):
(WebKitTextChecker::setSpellCheckingEnabled):
(WebKitTextChecker::setSpellCheckingLanguages):
- UIProcess/API/gtk/WebKitTextChecker.h: Added.
(WebKitTextChecker):
(WebKitTextChecker::isSpellCheckingEnabled):
(WebKitTextChecker::getSpellCheckingLanguages):
Added WKTextChecker to WebKitPrivate.h, needed in WebKitTextChecker.
- UIProcess/API/gtk/WebKitPrivate.h:
Add new API to WebKitWebContext to allow enabling/disabling this
spell checking feature, and to set/get the list of languages used
to decide which dictionaries will be consulted.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate):
(createDefaultWebContext):
(webkit_web_context_get_spell_checking_enabled): New API.
(webkit_web_context_set_spell_checking_enabled): Ditto.
(webkit_web_context_get_spell_checking_languages): Ditto.
(webkit_web_context_set_spell_checking_languages): Ditto.
- UIProcess/API/gtk/WebKitWebContext.h:
New tests for checking the new API added to WebKitWebContext.
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextSpellChecker):
(beforeAll):
Update documentation with new sections and symbols.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
Tools:
Ignore WebKitTextChecker.* private files for gtk-doc.
- gtk/generate-gtkdoc:
(get_webkit2_options):
- 11:28 Changeset [123966] by
-
[GTK] Add a new and reusable enchant-based spellchecker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=90269
Reviewed by Martin Robinson.
Source/WebCore:
Move enchant specific code down to WebCore, into a new class
TextCheckerEnchant, that we can use from WK1 and WK2.
- GNUmakefile.am: Add flags to handle the SPELLCHECK feature.
- GNUmakefile.list.am: Added new files.
- platform/text/gtk/TextCheckerEnchant.cpp: Added.
(getAvailableDictionariesCallback):
(TextCheckerEnchant::TextCheckerEnchant):
(TextCheckerEnchant::~TextCheckerEnchant):
(TextCheckerEnchant::ignoreWord):
(TextCheckerEnchant::learnWord):
(TextCheckerEnchant::checkSpellingOfString):
(TextCheckerEnchant::getGuessesForWord):
(TextCheckerEnchant::updateSpellCheckingLanguages):
(TextCheckerEnchant::freeEnchantBrokerDictionaries):
- platform/text/gtk/TextCheckerEnchant.h: Added.
(WebCore):
(TextCheckerEnchant):
(WebCore::TextCheckerEnchant::create):
Source/WebKit/gtk:
Remove enchant specific code from WebKitSpellCheckerEnchant and
implement it relying in the new TextCheckerEnchant class in WebCore.
- webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(checkSpellingOfString):
(getGuessesForWord):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):
- 11:05 Changeset [123965] by
-
Sigh. Just disable all the AutoResize tests after the first three.
https://bugs.webkit.org/show_bug.cgi?id=92318
Unreviewed, making bots happier.
- tests/WebViewTest.cpp:
- 10:36 Changeset [123964] by
-
[Chromium] Rebaselining and test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=77188
https://bugs.webkit.org/show_bug.cgi?id=85856
https://bugs.webkit.org/show_bug.cgi?id=87844
https://bugs.webkit.org/show_bug.cgi?id=91756
http://crbug.com/10364
http://crbug.com/138159
http://crbug.com/139162
http://crbug.com/139493
Unreviewed, test expectations update.
- fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Added.
- platform/chromium-linux-x86/platform/chromium: Added.
- platform/chromium-linux-x86/platform/chromium/virtual: Added.
- platform/chromium-linux-x86/platform/chromium/virtual/gpu: Added.
- platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast: Added.
- platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast/canvas: Added.
- platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Added.
- platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/026-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/028-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/datalist: Added.
- platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-mac/fast/block/float/026-expected.png:
- platform/chromium-mac/fast/block/float/028-expected.png:
- platform/chromium-mac/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
- platform/chromium-mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
- platform/chromium-win/fast/forms/box-shadow-override-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png:
- platform/chromium/TestExpectations:
- platform/efl/fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Removed.
- platform/gtk/fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Removed.
- 09:19 Changeset [123963] by
-
Try disabling different test in hopes of tracking down the real problem.
https://bugs.webkit.org/show_bug.cgi?id=92318
Unreviewed, making bots happier.
- tests/WebViewTest.cpp:
- 09:11 Changeset [123962] by
-
[Clamp] support in binding generator.
https://bugs.webkit.org/show_bug.cgi?id=77605
Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-07-28
Reviewed by Kentaro Hara.
Currently [Clamp] extended attribute in IDL files.
Spec: http://www.w3.org/TR/2012/CR-WebIDL-20120419/#Clamp
Tests: TestObj.idl
- bindings/scripts/CodeGeneratorCPP.pm:
(SkipFunction): Skips methods with [Clamp] parameters.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skips methods with [Clamp] parameters.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck): Support [Clamp] for JSBindings.
- bindings/scripts/CodeGeneratorObjC.pm:
(SkipFunction): Skips methods with [Clamp] parameters.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck): Support [Clamp] for V8Bindings.
- bindings/scripts/IDLAttributes.txt: Added [Clamp] to attributes list.
- bindings/scripts/test/JS/JSTestObj.cpp: Test.
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
(TestObjV8Internal):
- 08:18 Changeset [123961] by
-
[Qt] Unreviewed gardening.
- platform/qt-4.8/Skipped: Unskip now passing tests. (bug85203)
- 06:54 Changeset [123960] by
-
Unreviewed, GTK rebaseline after r123937.
- platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt:
- 06:09 Changeset [123959] by
-
[GTK] Transparent Media controls timeline and panel
https://bugs.webkit.org/show_bug.cgi?id=85279
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Provide gnome-themes-standard build
support, this is necessary so the media controls panel colors are
properly initialized from the GTK+ theme.
- 05:34 Changeset [123958] by
-
Remove obsolete functions from WTF::Unicode
https://bugs.webkit.org/show_bug.cgi?id=92571
Patch by Patrick Gansterer <paroga@webkit.org> on 2012-07-28
Reviewed by Kentaro Hara.
Remove hasLineBreakingPropertyComplexContextOrIdeographic() and digitValue(),
since they are never used and defined for a few Unicode backends only.
- wtf/unicode/glib/UnicodeGLib.h:
- wtf/unicode/icu/UnicodeIcu.h:
- 00:50 EFLWebKit edited by
- (diff)
07/27/12:
- 23:55 Changeset [123957] by
-
Disable failing test.
https://bugs.webkit.org/show_bug.cgi?id=92318
Unreviewed, making bots happier.
- tests/WebViewTest.cpp:
- 23:55 Changeset [123956] by
-
[WebGL] Align contents of drawbuffer-test.html layout test with the one in the WebGL conformance suite.
https://bugs.webkit.org/show_bug.cgi?id=92375
Patch by Nayan Kumar K <nayankk@motorola.com> on 2012-07-27
Reviewed by Kenneth Russell.
- fast/canvas/webgl/drawingbuffer-test-expected.txt:
- fast/canvas/webgl/drawingbuffer-test.html:
- 23:16 Changeset [123955] by
-
Chromium rebaseline after r123285.
https://bugs.webkit.org/show_bug.cgi?id=90624
Unreviewed, rebaselining.
- platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
- 23:11 Changeset [123954] by
-
https://bugs.webkit.org/show_bug.cgi?id=92573
Mac Lion: http/tests/misc/submit-post-keygen.html fails on buildbots
- platform/mac-lion/Skipped:
- 23:00 Changeset [123953] by
-
[EFL] Support for HTML media capture
https://bugs.webkit.org/show_bug.cgi?id=91842
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-27
Reviewed by Ryosuke Niwa.
.:
Add HTML media capture feature, and enable that on the Efl port.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Tools:
Add HTML media capture feature to the feature list.
In addition, enable that on the Efl port.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Remove file-input-capture.html from skipped list.
- platform/efl/Skipped:
- 22:48 Changeset [123952] by
-
Unreviewed, rolling out r123908.
http://trac.webkit.org/changeset/123908
https://bugs.webkit.org/show_bug.cgi?id=92572
Broke Chromium Linux compile (Requested by pkasting on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-27
- WebCore.gypi:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- css/mediaControls.css:
- css/mediaControlsChromiumAndroid.css:
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
- html/shadow/MediaControlElements.cpp:
(WebCore):
- html/shadow/MediaControlElements.h:
(WebCore):
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlChromiumEnclosureElement::create):
(WebCore):
(WebCore::MediaControlChromiumEnclosureElement::shadowPseudoId):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElementChromium::create):
- html/shadow/MediaControlRootElementChromium.h:
(MediaControlChromiumEnclosureElement):
(MediaControlRootElementChromium):
- html/shadow/MediaControlRootElementChromiumAndroid.cpp: Removed.
- html/shadow/MediaControlRootElementChromiumAndroid.h: Removed.
- platform/ThemeTypes.h:
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- rendering/RenderTheme.h:
- rendering/RenderThemeChromiumAndroid.cpp:
- rendering/RenderThemeChromiumAndroid.h:
- 22:12 Changeset [123951] by
-
Mark three tests as flakily timing out.
https://bugs.webkit.org/show_bug.cgi?id=92570
Unreviewed, Chromium test expectations update.
- platform/chromium/TestExpectations:
- 21:30 Changeset [123950] by
-
[BlackBerry] Use new LocaleHandler.
https://bugs.webkit.org/show_bug.cgi?id=92548
Patch by Eli Fidler <efidler@rim.com> on 2012-07-27
Reviewed by Yong Li.
RIM PR 128381
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::platformLanguage):
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):
- platform/text/blackberry/TextBreakIteratorInternalICUBlackBerry.cpp:
(WebCore::currentSearchLocaleID):
(WebCore::currentTextBreakLocaleID):
- 21:29 Changeset [123949] by
-
Fix broken script reference after test move.
https://bugs.webkit.org/show_bug.cgi?id=92111
Unreviewed, fixing bad test move.
- platform/win/fast/events/panScroll-click-hyperlink.html:
- 21:20 Changeset [123948] by
-
Chromium rebaselines after r123912.
https://bugs.webkit.org/show_bug.cgi?id=92327
Unreviewed, rebaselining.
- platform/chromium-linux-x86/fast/hidpi: Added.
- platform/chromium-linux-x86/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
- platform/chromium-linux/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
- platform/chromium-mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
- platform/chromium-win-xp/fast/hidpi: Added.
- platform/chromium-win-xp/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
- platform/chromium-win/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
- 21:12 Changeset [123947] by
-
Chromium rebaseline after r123706.
https://bugs.webkit.org/show_bug.cgi?id=92236
Unreviewed, rebaselining.
- platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.png:
- 20:19 Changeset [123946] by
-
Chromium rebaselines after r123790.
Unreviewed, rebaselining.
- platform/chromium-linux-x86/css3/filters/effect-brightness-clamping-expected.txt: Added.
- platform/chromium-linux-x86/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
- platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.txt: Added.
- platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
- platform/chromium-win-xp/css3: Added.
- platform/chromium-win-xp/css3/filters: Added.
- platform/chromium-win-xp/css3/filters/effect-brightness-clamping-expected.txt: Added.
- platform/chromium-win-xp/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
- platform/chromium-win/css3/filters/effect-brightness-clamping-expected.txt: Added.
- platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
- 18:23 Changeset [123945] by
-
Change constructor with explicit constructor in WebCore/Modules
https://bugs.webkit.org/show_bug.cgi?id=92529
Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2012-07-27
Reviewed by Kentaro Hara.
As a step to let *explicit* keyword add to constructors which have a parameter,
*explicit* keyword is added to Source/WebCore/Modules in order to avoid implicit
type conversion.
No new tests. Covered by existing tests.
- Modules/filesystem/LocalFileSystem.h:
(WebCore::LocalFileSystem::LocalFileSystem):
- Modules/filesystem/Metadata.h:
(WebCore::Metadata::Metadata):
- Modules/filesystem/SyncCallbackHelper.h:
(WebCore::SyncCallbackHelper::SuccessCallbackImpl::SuccessCallbackImpl):
(WebCore::SyncCallbackHelper::ErrorCallbackImpl::ErrorCallbackImpl):
- Modules/mediastream/IceCandidate.h:
(IceCandidate):
- Modules/mediastream/NavigatorUserMediaError.h:
(WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
- Modules/mediastream/SessionDescription.h:
(SessionDescription):
- Modules/mediastream/UserMediaController.h:
(UserMediaController):
- Modules/notifications/NotificationController.h:
(NotificationController):
- Modules/speech/SpeechRecognition.h:
(SpeechRecognition):
- Modules/speech/SpeechRecognitionController.h:
(SpeechRecognitionController):
- Modules/speech/SpeechRecognitionEvent.h:
(SpeechRecognitionEvent):
- Modules/speech/SpeechRecognitionResultList.h:
(SpeechRecognitionResultList):
- Modules/vibration/Vibration.h:
(Vibration):
- Modules/webaudio/AudioBuffer.h:
(AudioBuffer):
- Modules/webaudio/AudioContext.h:
(AudioContext):
- Modules/webaudio/AudioNodeInput.h:
(AudioNodeInput):
- Modules/webaudio/AudioSummingJunction.h:
(AudioSummingJunction):
- Modules/webaudio/BiquadDSPKernel.h:
(WebCore::BiquadDSPKernel::BiquadDSPKernel):
- Modules/webaudio/DefaultAudioDestinationNode.h:
(DefaultAudioDestinationNode):
- Modules/webaudio/DelayDSPKernel.h:
(DelayDSPKernel):
- Modules/webaudio/OfflineAudioCompletionEvent.h:
(OfflineAudioCompletionEvent):
- Modules/webaudio/WaveShaperDSPKernel.h:
(WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):
- Modules/webaudio/WaveShaperNode.h:
(WaveShaperNode):
- Modules/webaudio/WaveTable.h:
(WaveTable):
- Modules/webdatabase/DatabaseAuthorizer.h:
(DatabaseAuthorizer):
- Modules/webdatabase/DatabaseTask.h:
(Database::DatabaseTransactionTask):
- Modules/webdatabase/DatabaseTracker.h:
(DatabaseTracker):
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
- Modules/webdatabase/SQLException.h:
(WebCore::SQLException::SQLException):
- Modules/websockets/WebSocket.h:
- Modules/websockets/WebSocketExtensionProcessor.h:
(WebCore::WebSocketExtensionProcessor::WebSocketExtensionProcessor):
- 18:21 Changeset [123944] by
-
[V8] Optimize Element::getAttributeNS() by replacing String with AtomicString
https://bugs.webkit.org/show_bug.cgi?id=90276
Patch by Kentaro Hara <haraken@chromium.org> on 2012-07-27
Reviewed by Adam Barth.
In r121439, we changed the argument type of Element::getAttribute()
from String to AtomicString for optimization. This patch changes the
argument type of Element::getAttributeNS() from String to AtomicString.
Actually this change affects V8 performance only.
[JSC without the patch]
The binding code converts a given JavaScript string to a String
-> the String is passed to getAttributeNS()
-> the String is converted to an AtomicString when it is passed to
QualifiedName() constructor.
[JSC with the patch]
The binding code converts a given JavaScript string to a String
-> the String is converted to an AtomicString when it is passed to
getAttributeNS()
-> the AtomicString is passed to QualifiedName() constructor.
[V8 without the patch]
The binding code retrieves a cached external String for a given
JavaScript string
-> the String is passed to getAttributeNS()
-> the String is converted to AtomicString when it is passed to
QualifiedName() constructor.
[V8 with the patch]
The binding code retrieves a cached external AtomicString for a given
JavaScript string
-> the AtomicString is passed to getAttributeNS()
-> the AtomicString is passed to QualifiedName() constructor.
In this way, in JSC, the change affects where a String is converted to
an AtomicString. On the other hand, in V8, (since the AtomicString is already
cached,) we can skip the conversion step.
Performance test: https://bugs.webkit.org/attachment.cgi?id=150158
getAttributeNS (Chromium/Linux):
577.80ms => 454.60ms
- dom/Element.cpp:
(WebCore::Element::getAttributeNS):
- dom/Element.h:
(Element):
- 18:02 Changeset [123943] by
-
Unreviewed, rolling out r123679.
http://trac.webkit.org/changeset/123679
https://bugs.webkit.org/show_bug.cgi?id=92565
Slowed down HTML parsing by 3.6% (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-27
Source/WebCore:
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::append):
- html/parser/HTMLEntityParser.cpp:
(WebCore::HTMLEntityParser::consumeNamedEntity):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::stripLeadingAndTrailingHTMLSpaces):
- html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::sourceForToken):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::script):
- platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceSlowCase):
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase):
- platform/text/SegmentedString.h:
(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(WebCore::SegmentedSubstring::appendTo):
(SegmentedSubstring):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(SegmentedString):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(WebCore::SegmentedString::operator*):
(WebCore::SegmentedString::operator->):
(WebCore::SegmentedString::current):
(WebCore::SegmentedString::equalsLiterally):
(WebCore::SegmentedString::equalsIgnoringCase):
(WebCore::SegmentedString::lookAheadInline):
(WebCore::SegmentedString::lookAheadSlowCase):
- xml/parser/CharacterReferenceParserInlineMethods.h:
(WebCore::consumeCharacterReference):
- xml/parser/MarkupTokenizerBase.h:
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):
Source/WTF:
- wtf/text/WTFString.h:
- 17:41 Changeset [123942] by
-
Reset the set of "seen" plugins when the main frame load is committed.
https://bugs.webkit.org/show_bug.cgi?id=92564
Reviewed by Anders Carlsson.
Because the Page object is re-used across navigation and reload, reset the list
of seen plugins when the main frame load commits. This gives a good baseline to
compare against the number of pages loaded.
No new tests; the "seen" plugin list is for diagnostic purposes only.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidCommitLoad):
- page/Page.cpp:
(WebCore::Page::resetSeenPlugins):
- page/Page.h:
- 17:34 Changeset [123941] by
-
"webkit-patch rebaseline <test>" fails with exit_code 1
https://bugs.webkit.org/show_bug.cgi?id=91560
Reviewed by Adam Barth.
webkit-patch rebaseline-json crashes in an svn checkout if it
tries to add files and there are no files to add; arguably
svn.add() should be robust against this, but rebaseline-json
shouldn't be calling it, either. This patch fixes the latter and
adds better debugging info to garden-o-matic so we can see what
caused the crash.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand._rebaseline):
- Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaselineall):
(GardeningHTTPRequestHandler.rebaselineall.error_handler):
(GardeningHTTPRequestHandler):
- 17:32 Changeset [123940] by
-
execCommand copies the backgroung-color of the enclosing element to the element being edited.
https://bugs.webkit.org/show_bug.cgi?id=91783
Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-07-27
Reviewed by Ryosuke Niwa.
Source/WebCore:
InsertListCommand and some other edit commands remove redundant
style properties after their DOM modification by using
StylePropertySet::removeEquivalentProperties. However, this method
does not remove redundant background-color properties such as
"background-color: white" and "background-color: #fff" because
it compares them using cssText and thus treats them as different.
Add code to convert background colors to RGBA and then compare them.
Test: editing/style/redundant-background-color.html
- editing/EditingStyle.cpp:
(WebCore::getRGBABackgroundColor):
(WebCore):
(WebCore::getPropertiesNotIn):
LayoutTests:
This tests to make sure that WebKit removes redundant "background-color"
property after execCommand.
- editing/style/redundant-background-color-expected.txt: Added.
- editing/style/redundant-background-color.html: Added.
- 17:30 Changeset [123939] by
-
[EFL] Return 0 when network is offline
https://bugs.webkit.org/show_bug.cgi?id=92454
Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.
Network Info latest spec says 0 is returned when network is offline.
r123769 modified to return infinity value when network is offiline.
- platform/efl/NetworkInfoProviderEfl.cpp:
(WebCore::NetworkInfoProviderEfl::bandwidth):
- 17:08 Changeset [123938] by
-
Unreviewed perf-o-matic build fix for dashboard image generation.
Also, only show Parser/html5-full-render on the dashboard by default
so that it won't take forever to load it.
- Websites/webkit-perf.appspot.com/controller.py:
(schedule_runs_update):
(RunsChartHandler.post):
- Websites/webkit-perf.appspot.com/models.py:
(Runs.chart_params):
(DashboardImage.get_image):
- Websites/webkit-perf.appspot.com/models_unittest.py:
(RunsTest.test_chart_params_with_value):
- 16:51 Changeset [123937] by
-
Change navigator.webkitGamepads[] to navigator.webkitGetGamepads()
https://bugs.webkit.org/show_bug.cgi?id=92533
Patch by Scott Graham <scottmg@chromium.org> on 2012-07-27
Reviewed by Adam Barth.
Source/WebCore:
Per discussion on public-webapps. Pages that enumerate navigator were
causing background resources to be created to poll hardware
unintentionally. By changing to an explicit function call, this is
avoided (and the API becomes more clear too). This change updates the
implementation to match the current ED spec.
- Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::webkitGetGamepads):
- Modules/gamepad/NavigatorGamepad.h:
(NavigatorGamepad):
- Modules/gamepad/NavigatorGamepad.idl:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebkitGetGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetGamepadsEnabled):
Source/WebKit/chromium:
Renames for updated access point.
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):
LayoutTests:
Updates for renamed access point.
- gamepad/gamepad-api-expected.txt:
- gamepad/gamepad-api.html:
- gamepad/gamepad-polling-access-expected.txt:
- gamepad/gamepad-polling-access.html:
- platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
- 16:44 Changeset [123936] by
-
Plugins should not be allowed to override standard properties/attributes in non-standard worlds
<rdar://problem/11975252> and https://bugs.webkit.org/show_bug.cgi?id=92519
Reviewed by Anders Carlsson.
Source/WebCore:
Change the 3 plugin-owning element's custom bindings to prefer built-in properties if they exist.
When they do they don't give the plugin a chance to override.
Test: plugins/npruntime/overrides-all-properties.html
Add plugin custom functions to prefer built-in properties over plugin scriptable object properties:
- bindings/js/JSPluginElementFunctions.h:
(WebCore::pluginElementCustomGetOwnPropertySlot):
(WebCore::pluginElementCustomGetOwnPropertyDescriptor):
Use those new custom functions for getting properties:
- bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLAppletElement::getOwnPropertyDescriptorDelegate):
- bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLEmbedElement::getOwnPropertyDescriptorDelegate):
- bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
(WebCore::JSHTMLObjectElement::getOwnPropertyDescriptorDelegate):
Tools:
Add a test plugin which overrides all properties it is asked about:
- DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableObjectOverridesAllProperties.cpp: Added.
(PluginScriptableObjectOverridesAllProperties):
(PluginScriptableObjectOverridesAllProperties::PluginScriptableObjectOverridesAllProperties):
(PluginObject):
(PluginScriptableObjectOverridesAllProperties::PluginObject::PluginObject):
(PluginScriptableObjectOverridesAllProperties::PluginObject::~PluginObject):
(PluginScriptableObjectOverridesAllProperties::PluginObject::hasProperty):
(PluginScriptableObjectOverridesAllProperties::PluginObject::getProperty):
(PluginScriptableObjectOverridesAllProperties::NPP_GetValue):
Expose NPN_MemAlloc to the test plugin:
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPN_MemAlloc):
- DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
(PluginTest):
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
LayoutTests:
- plugins/npruntime/overrides-all-properties-expected.txt: Added.
- plugins/npruntime/overrides-all-properties.html: Added.
- platform/chromium/TestExpectations: Test behaves different in V8, so skip on chromium
- 16:32 Changeset [123935] by
-
use createUninitialized when creating TypedArray from another array
https://bugs.webkit.org/show_bug.cgi?id=92518
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-27
Reviewed by Kenneth Russell.
PerformanceTests:
- Bindings/typed-array-construct-from-array.html: Added.
Source/WebCore:
When creating a Typed Array from another array, we fill it with values
from the source array. So, we can create it uninitialized. This is
make constructor about 35% faster when constructed with another typed
array.
Test: fast/canvas/webgl/array-constructor.html
- bindings/js/JSArrayBufferViewHelper.h:
(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore::constructArrayBufferView):
Source/WTF:
Expose a createUninitialized static method on TypedArray classes.
- wtf/Float32Array.h:
(Float32Array):
(WTF::Float32Array::createUninitialized):
(WTF):
- wtf/Float64Array.h:
(Float64Array):
(WTF::Float64Array::createUninitialized):
(WTF):
- wtf/Int16Array.h:
(Int16Array):
(WTF::Int16Array::createUninitialized):
(WTF):
- wtf/Int32Array.h:
(Int32Array):
(WTF::Int32Array::createUninitialized):
(WTF):
- wtf/Int8Array.h:
(Int8Array):
(WTF::Int8Array::createUninitialized):
(WTF):
- wtf/Uint16Array.h:
(Uint16Array):
(WTF::Uint16Array::createUninitialized):
(WTF):
- wtf/Uint32Array.h:
(Uint32Array):
(WTF::Uint32Array::createUninitialized):
(WTF):
- wtf/Uint8Array.h:
(Uint8Array):
(WTF::Uint8Array::createUninitialized):
(WTF):
- wtf/Uint8ClampedArray.h:
(Uint8ClampedArray):
LayoutTests:
Add test to check that constructing a Typed Array with nan values does
not result in random values.
- fast/canvas/webgl/array-constructor-expected.txt: Added.
- fast/canvas/webgl/array-constructor.html: Added.
- 16:29 Changeset [123934] by
-
[BlackBerry] Adapt to change in the FontInfo platform API.
https://bugs.webkit.org/show_bug.cgi?id=92547
Patch by Eli Fidler <efidler@rim.com> on 2012-07-27
Reviewed by Yong Li
RIM PR 161263
Source/WebCore:
- page/blackberry/SettingsBlackBerry.cpp:
(WebCore::Settings::initializeDefaultFontFamilies):
Source/WebKit/blackberry:
- Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):
- 16:12 Changeset [123933] by
-
[EFL][WK2] Assertion hit in ewk_cookie_manager.cpp
https://bugs.webkit.org/show_bug.cgi?id=92544
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.
Removed wrong assertion in ewk_cookie_manager.cpp
and replace it by an if check. The assertion was
sometimes hit by our unit tests.
- UIProcess/API/efl/ewk_cookie_manager.cpp:
(cookiesDidChange):
- 16:02 Changeset [123932] by
-
[chromium] Fix color matrix filter computation so that filters that don't need clamping are correctly detected as such
https://bugs.webkit.org/show_bug.cgi?id=92452
Patch by Antoine Labour <piman@chromium.org> on 2012-07-27
Reviewed by Stephen White.
Because of precision issues, some filters were returning true to
matrixNeedsClamping when they can return false. This fixes it.
No new tests in this CL, a follow-up change refactors the code to add
several tests.
- platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
- 15:59 Changeset [123931] by
-
Split functionality of MarkedAllocator::m_currentBlock
https://bugs.webkit.org/show_bug.cgi?id=92550
Reviewed by Filip Pizlo.
MarkedAllocator::m_currentBlock serves two purposes right now; it indicates the block that is currently
being used for allocation and the beginning of the list of blocks that need to be swept. We should split
these two functionalities into two separate fields.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): Use m_blocksToSweep instead of m_currentBlock as the
initializer/reference of the loop. Only change m_currentBlock when we know what the result will be.
(JSC::MarkedAllocator::addBlock): When we add a new block we know that both m_blocksToSweep and
m_currentBlock are null. In order to preserve the invariant that m_currentBlock <= m_blocksToSweep,
we assign both of them to point to the new block.
(JSC::MarkedAllocator::removeBlock): We need a separate check to see if the block we're removing is
m_blocksToSweep and if so, advance it to the next block in the list.
- heap/MarkedAllocator.h:
(MarkedAllocator): Initialize m_blocksToSweep.
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::reset): We set m_blocksToSweep to be the head of our list. This function is called
at the end of a collection, so all of the blocks in our allocator need to be swept. We need to sweep a
block before we can start allocating, so m_currentBlock is set to null. We also set the freeList to
the empty FreeList to emphasize the fact that we can't start allocating until we do some sweeping.
- 15:58 Changeset [123930] by
-
Add diagnostic logging for plugins-per-page.
https://bugs.webkit.org/show_bug.cgi?id=92538
Reviewed by Anders Carlsson.
Add some diagnostic logging for whether a page has seen a plugin, and
whether a page has seen a plugin of a specific type.
Move the diagnostic logging out of the elemements themselves:
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
Instead, log when the plugin is requested, thereby catching plugins which are
rejected because, e.g., Java is disabled or not installed:
- loader/SubframeLoader.cpp:
(WebCore::logPluginRequest):
(WebCore::SubframeLoader::requestObject):
(WebCore::SubframeLoader::createJavaAppletWidget):
Add new diagnostic key values:
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
- page/DiagnosticLoggingKeys.h:
Add a map of plugin types seen per-page for diagnostic purposes:
- page/Page.cpp:
(WebCore::Page::hasSeenAnyPlugin):
(WebCore::Page::hasSeenPlugin):
(WebCore::Page::sawPlugin):
- page/Page.h:
- 15:46 Changeset [123929] by
-
[WINCE] Use macros from ICU instead of defining the same functionality again
https://bugs.webkit.org/show_bug.cgi?id=92530
Patch by Patrick Gansterer <paroga@webkit.org> on 2012-07-27
Reviewed by Ryosuke Niwa.
Replace isHighSurrogate() with U16_IS_LEAD(), isLowSurrogate() with
U16_IS_TRAIL() and surrogateToUcs4() with U16_GET_SUPPLEMENTARY().
Source/WebCore:
- html/FTPDirectoryDocument.cpp:
(WebCore::processFileDateString):
- loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):
- platform/graphics/wince/FontWinCE.cpp:
(WebCore::generateComponents):
Source/WTF:
- wtf/unicode/wince/UnicodeWinCE.h:
- 15:41 Changeset [123928] by
-
Build warning in CSSPrimitiveValueMappings.h when CSS_STICKY_POSITION is disabled
https://bugs.webkit.org/show_bug.cgi?id=92523
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Simon Fraser.
Move #ifdef in CSSPrimitiveValueMappings.h to silent compilation warning
when CSS_STICKY_POSITION is disabled.
No new tests, no behavior change.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- 15:37 Changeset [123927] by
-
DragController should ascertain dragClient to be non-null
https://bugs.webkit.org/show_bug.cgi?id=92474
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-27
Reviewed by Tony Chang.
The DragController must always ensure a valid dragClient object. Hence
adding the ASSERT to assure that.
No new tests. Added assertion for PageClient.dragClient.
- page/DragController.cpp:
(WebCore::DragController::DragController):
- 15:30 Changeset [123926] by
-
[chromium] Clean up LayerRendererChromium::drawTexturedQuad
https://bugs.webkit.org/show_bug.cgi?id=91823
Patch by Adrienne Walker <enne@google.com> on 2012-07-27
Reviewed by James Robinson.
LayerRendererChromium::drawTexturedQuad has been around forever and
over time has developed several problems:
- Confusingly named relative to drawTextureQuad
- All but one callers identically manipulate the transform matrix
- Lots of optional parameters that only few functions use
This patch breaks up drawTexturedQuad into setShaderOpacity (for
optional opacity values sent to the shader), setShaderFloatQuad (the
full FloatQuad used by AA shaders), and drawQuadGeometry (actually
draw the geometry, and wrap the transform logic that was duplicated
everywhere).
No new tests; no change in functionality.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawIOSurfaceQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::setShaderFloatQuad):
(WebCore::LayerRendererChromium::setShaderOpacity):
(WebCore::LayerRendererChromium::drawQuadGeometry):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- 15:20 Changeset [123925] by
-
[Qt] Fix build after r123917
https://bugs.webkit.org/show_bug.cgi?id=92555
Unreviewed.
- wtf/GregorianDateTime.h: Needs string.h for memset().
- 15:10 Changeset [123924] by
-
"webkit-patch upload" should strip colors from patch if necessary
https://bugs.webkit.org/show_bug.cgi?id=92306
Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-07-27
Reviewed by Adam Barth.
- Scripts/webkitpy/common/checkout/scm/git.py: Explicity remove colors from diff.
- 15:07 Changeset [123923] by
-
[Qt] Remaining rebaselines after new test fonts
https://bugs.webkit.org/show_bug.cgi?id=92552
Unreviewed.
Unskip a bunch of tests, organize the remaining skips. The mentions to bug 85203 were
removed now. A last batch of WK1 results were associated with the bug 91610.
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0-wk2/fullscreen/full-screen-placeholder-expected.txt:
- platform/qt-5.0/Skipped:
- platform/qt/editing/input/caret-at-the-edge-of-input-expected.txt:
- platform/qt/editing/input/reveal-caret-of-multiline-input-expected.txt:
- platform/qt/http/tests/cache/cancel-during-revalidation-succeeded-expected.txt: Removed.
- platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Removed.
- platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt:
- platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
- platform/qt/svg/text/select-x-list-1-expected.txt:
- platform/qt/svg/text/select-x-list-2-expected.txt:
- platform/qt/svg/text/select-x-list-3-expected.txt:
- platform/qt/svg/text/select-x-list-4-expected.txt:
- platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
- platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
- platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
- platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
- platform/qt/svg/text/selection-doubleclick-expected.txt:
- 15:07 Changeset [123922] by
-
Merged r116357. <rdar://problem/11942044>
- 15:04 Changeset [123921] by
-
[chromium] CCLayerTreeHost placeholder scissor should be deviceViewportSize instead of viewportSize
https://bugs.webkit.org/show_bug.cgi?id=92469
Patch by Shawn Singh <shawnsingh@chromium.org> on 2012-07-27
Reviewed by Adrienne Walker.
We were accidentally using viewportSize instead of
deviceViewportSize in a particular place in code. Recent
refactoring to use tighter scissor rects exposed this problem.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
- 14:56 Changeset [123920] by
-
clean-pending-commit throws exception when encountering Ossy
https://bugs.webkit.org/show_bug.cgi?id=92534
Patch by Eric Seidel <eric@webkit.org> on 2012-07-27
Reviewed by Adam Barth.
Mark a couple strings as unicode so that reviewers with unicode names do not cause
clean-pending-commit to barf.
- Scripts/webkitpy/tool/commands/upload.py:
(CleanPendingCommit._flags_to_clear_on_patch):
(CleanPendingCommit.execute):
(AssignToCommitter._assign_bug_to_last_patch_attacher):
- 14:49 Changeset [123919] by
-
Search cancel button is hard to activate with a tap gesture even if touch adjustment is enabled.
https://bugs.webkit.org/show_bug.cgi?id=91894
Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-27
Reviewed by Antonio Gomes.
Source/WebCore:
Update check for determining if a node responds to tap gestures.
Previously, the cancel button was being discarded as a candidate for
touch adjustment if the touch area clipped the text input region
because the candidate pruning process failed to account for the cancel
button having a default mouse handler. Possibly an interim fix,
depending on resolution to 92093.
Test: touchadjustment/search-cancel.html
- page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
LayoutTests:
Add test for touch adjustment in the vicinity of a search cancel button.
Prior to the patch, the cancel button was pruned as a candidate if the
touch area clipped the input field.
- touchadjustment/search-cancel-expected.txt: Added.
- touchadjustment/search-cancel.html: Added.
- 14:48 Changeset [123918] by
-
chromium win compile broken after removing webkit.py
https://bugs.webkit.org/show_bug.cgi?id=92549
Unreviewed, build fix.
It turns out that this file is listed in the chromium downstream
'browser_tests.isolate' file, and so deleting it broke gyp.
Adding a stub file back in until we can remove the entry from
the file.
- Scripts/webkitpy/layout_tests/port/webkit.py: Added.
- 14:40 Changeset [123917] by
-
MinGW build fails because of missing header in GregorianDateTime.h
https://bugs.webkit.org/show_bug.cgi?id=92531
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2012-07-27
- wtf/GregorianDateTime.h: Include time.h
- 14:10 CommitterTips edited by
- Clarify that new committers should manually commit the change to … (diff)
- 14:04 Changeset [123916] by
-
nrwt: remove 'webkit.py' and the 'WebKitPort'
https://bugs.webkit.org/show_bug.cgi?id=92450
Reviewed by Ryosuke Niwa.
This patch finishes the work of merging WebKitPort into Port.
Now Port is way too big :).
This is all cutting and pasting; no new functionality and
no changes in the tests.
- Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort):
(ApplePort.init):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.skipped_layout_tests):
(Port):
(Port._port_flag_for_scripts):
(Port._arguments_for_configuration):
(Port._run_script):
(Port._build_driver):
(Port._build_driver_flags):
(Port._tests_for_other_platforms):
(Port._runtime_feature_list):
(Port.nm_command):
(Port._modules_to_search_for_symbols):
(Port._symbols_string):
(Port._missing_feature_to_skipped_tests):
(Port._missing_symbol_to_skipped_tests):
(Port._has_test_in_directories):
(Port._skipped_tests_for_unsupported_features):
(Port._wk2_port_name):
(Port._skipped_file_search_paths):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
- Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_check_build):
- Scripts/webkitpy/layout_tests/port/driver_unittest.py:
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort):
(EflPort.init):
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort):
(GtkPort.setup_environ_for_server):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(TestWebKitPort):
(TestWebKitPort.init):
(TestWebKitPort.all_test_configurations):
(TestWebKitPort._symbols_string):
(TestWebKitPort._tests_for_other_platforms):
(TestWebKitPort._tests_for_disabled_features):
(PortTestCase):
(PortTestCase.test_diff_image):
(PortTestCase.test_path_to_test_expectations_file):
(PortTestCase.test_skipped_directories_for_symbols):
(test_skipped_directories_for_features):
(test_skipped_directories_for_features_no_matching_tests_in_test_list):
(test_skipped_tests_for_unsupported_features_empty_test_list):
(test_skipped_layout_tests):
(test_skipped_file_search_paths):
(test_root_option):
(test_test_expectations):
(test_build_driver):
(_assert_config_file_for_platform):
(test_linux_distro_detection):
(test_apache_config_file_name_for_platform):
(test_path_to_apache_config_file):
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort):
(QtPort.init):
(QtPort.setup_environ_for_server):
- Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
- Scripts/webkitpy/tool/servers/rebaselineserver.py:
(get_test_baselines.AllPlatformsPort):
(get_test_baselines.AllPlatformsPort.init):
- Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
(get_test_config.TestMacPort):
- 13:48 Changeset [123915] by
-
Don't use an NSUserDefault for disabling the web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=92542
<rdar://problem/11976060>
Reviewed by Mark Rowe.
The user default was really helpful during WebKit2 bringup, but we no longer need to pay the IPC cost of initializing NSUserDefaults at startup,
so get rid of the preference and use a good old #ifdef instead.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
- 13:43 Changeset [123914] by
-
Animated SVGs do not clear previous frame completely in hidpi mode.
https://bugs.webkit.org/show_bug.cgi?id=92395
Patch by Varun Jain <varunjain@chromium.org> on 2012-07-27
Reviewed by Darin Adler.
Source/WebCore:
The rect thats is cleared in subsequent frames needed to be scaled with device scale.
Test: svg/as-image/animated-svg-repaints-completely-in-hidpi.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawSVGToImageBuffer):
LayoutTests:
- platform/chromium/TestExpectations:
- platform/mac/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
- platform/mac/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.
- svg/as-image/animated-svg-repaints-completely-in-hidpi.html: Added.
- svg/as-image/resources/animated-rect-fixed-size-3.svg: Added.
- 13:41 Changeset [123913] by
-
Fix COMPILE_ASSERT for InlineFlowBox growing
https://bugs.webkit.org/show_bug.cgi?id=92541
Patch by Scott Graham <scottmg@chromium.org> on 2012-07-27
Reviewed by Dan Bernstein.
Use unsigned instead of bool to keep size small on Windows.
No new tests.
- rendering/InlineFlowBox.h:
(InlineFlowBox):
- 13:33 Changeset [123912] by
-
https://bugs.webkit.org/show_bug.cgi?id=92327
-webkit-background-clip:text is blurry in WebKit 1 apps when
deviceScaleFactor > 1
-and corresponding-
<rdar://problem/11683788>
Reviewed by Simon Fraser.
Source/WebCore:
The bug here is that the code to make createCompatibleBuffer() HiDPI-savvy
assumed that the deviceScaleFactor would always be baked into the CTM of the
GraphicsContext. But that is NOT the case in WebKit 1.
createCompatibleBuffer() is used for clip text and gradients.
Now getCTM() takes a parameter indicating whether the result should definitely
include the device scale, or if it should possibly included the device scale,
which is the option that matches old behavior.
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::getCTM):
- platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::getCTM):
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::getCTM):
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::getCTM):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::getCTM):
- platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::getCTM):
Actually use the new parameter in the CG implementation. Use CG API to get a
matrix that definitely includes the device scale when that is required.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::getCTM):
Remove some symbol cruft that doesn't seem to require a replacement.
- WebCore.exp.in:
Use DefinitelyIncludeDeviceScale when getting the CTM in the buggy spot.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::createCompatibleBuffer):
The ImageBuffer for gradients is created using createCompatibleBuffer(), and since
createCompatibleBuffer() now uses getCTM(DefinitelyIncludeDeviceScale) to
determine appropriate sizing, drawPattern() should use that same matrix to
determine pattern sizing.
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::drawPattern):
LayoutTests:
- fast/hidpi/gradient-with-scaled-ancestor.html: Added.
- platform/mac/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
- platform/mac/fast/hidpi/gradient-with-scaled-ancestor-expected.txt: Added.
- 13:10 Changeset [123911] by
-
[WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=92228
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Anders Carlsson.
Source/WebKit2:
Add C API to create a WKIntentData and to deliver
it to a frame. This is needed by WebKitTestRunner
to implement LayoutTestController.deliverWebIntent().
- UIProcess/API/C/WKIntentData.cpp:
(WKIntentDataCreate):
- UIProcess/API/C/WKIntentData.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageDeliverIntentToFrame):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/WebPage/WebPage.h:
(WebPage): Make deliverIntentToFrame() public so that it can
be used by WKBundlePage.
Tools:
Implement LayoutTestController.deliverWebIntent() to
allow test cases to deliver a Web intent and test this
functionality.
This functionality is needed by:
- webintents/web-intents-delivery.html
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::deliverWebIntent):
(WTR):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
- 12:49 Changeset [123910] by
-
Add Mac results for fast/table/table-row-outline-paint.html.
- platform/mac/fast/table/table-row-outline-paint-expected.txt: Added.
- 12:46 Changeset [123909] by
-
Source/WebCore: flex-wrap: wrap not wrapping for % sized items in column flow
https://bugs.webkit.org/show_bug.cgi?id=92324
Patch by Tony Chang <tony@chromium.org> on 2012-07-27
Reviewed by Ojan Vafai.
We were using trying to use the value of contentLogicalHeight() before having called computeLogicalHeight()
in a few places. Fix this in mainAxisContentExtent() rather than at the callers.
Test: css3/flexbox/percentage-heights.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): If we haven't called computeLogicalHeight, we try to compute
the height based on the fixed flexbox value. min/max don't matter here since percent values are only based on height/width.
- rendering/RenderFlexibleBox.h: Drop const because computeContentLogicalHeightUsing is not const. I can
try making computeContentLogicalHeightUsing const in a follow up change (might be non-trivial).
Source/WebKit2: Show the unavailable plug-in indicator for Java applets as well
https://bugs.webkit.org/show_bug.cgi?id=92521
Patch by Anders Carlsson <andersca@apple.com> on 2012-07-27
Reviewed by Sam Weinig.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
This can now be called on applet elements as well.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
Get the MIME type from the applet element.
LayoutTests: flex-wrap: wrap not wrapping for % sized items in column flow
https://bugs.webkit.org/show_bug.cgi?id=92324
Patch by Tony Chang <tony@chromium.org> on 2012-07-27
Reviewed by Ojan Vafai.
Test cases for column flow with percentage heights. There are three
test cases for the three callers of mainAxisContentExtent() that were
broken by this.
- css3/flexbox/percentage-heights-expected.txt: Added.
- css3/flexbox/percentage-heights.html: Added.
- 12:38 Changeset [123908] by
-
Add an overlay play button to media controls on android
https://bugs.webkit.org/show_bug.cgi?id=92132
Patch by Min Qin <qinmin@chromium.org> on 2012-07-27
Reviewed by Adam Barth.
This change adds an overlay play button to the media controls for android.
No tests for now as this setting is not being used by other port.
Will add a test and adjust all the test expectations when we upstream the layout tests for android.
- WebCore.gypi:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- css/mediaControls.css:
(audio::-webkit-media-controls-overlay-play-button, video::-webkit-media-controls-overlay-play-button):
- css/mediaControlsChromiumAndroid.css:
(audio::-webkit-media-controls-overlay-enclosure):
(video::-webkit-media-controls-overlay-enclosure):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(video::-webkit-media-controls-overlay-play-button):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlOverlayPlayButtonElement::MediaControlOverlayPlayButtonElement):
(WebCore):
(WebCore::MediaControlOverlayPlayButtonElement::create):
(WebCore::MediaControlOverlayPlayButtonElement::defaultEventHandler):
(WebCore::MediaControlOverlayPlayButtonElement::updateDisplayType):
(WebCore::MediaControlOverlayPlayButtonElement::shadowPseudoId):
- html/shadow/MediaControlElements.h:
(MediaControlOverlayPlayButtonElement):
(WebCore):
- html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlPanelEnclosureElement::MediaControlPanelEnclosureElement):
(WebCore::MediaControlPanelEnclosureElement::create):
(WebCore):
(WebCore::MediaControlPanelEnclosureElement::shadowPseudoId):
(WebCore::MediaControlRootElementChromium::create):
(WebCore::MediaControlRootElementChromium::initializeControls):
- html/shadow/MediaControlRootElementChromium.h:
(MediaControlChromiumEnclosureElement):
(WebCore):
(MediaControlPanelEnclosureElement):
(MediaControlRootElementChromium):
- html/shadow/MediaControlRootElementChromiumAndroid.cpp: Added.
(WebCore):
(WebCore::MediaControlOverlayEnclosureElement::MediaControlOverlayEnclosureElement):
(WebCore::MediaControlOverlayEnclosureElement::create):
(WebCore::MediaControlOverlayEnclosureElement::shadowPseudoId):
(WebCore::MediaControlRootElementChromiumAndroid::MediaControlRootElementChromiumAndroid):
(WebCore::MediaControls::create):
(WebCore::MediaControlRootElementChromiumAndroid::create):
(WebCore::MediaControlRootElementChromiumAndroid::setMediaController):
(WebCore::MediaControlRootElementChromiumAndroid::playbackStarted):
(WebCore::MediaControlRootElementChromiumAndroid::playbackStopped):
- html/shadow/MediaControlRootElementChromiumAndroid.h: Added.
(WebCore):
(MediaControlOverlayEnclosureElement):
(MediaControlRootElementChromiumAndroid):
- platform/ThemeTypes.h:
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaOverlayPlayButton):
(WebCore):
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaOverlayPlayButton):
- rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::paintMediaOverlayPlayButton):
(WebCore):
- rendering/RenderThemeChromiumAndroid.h:
- 12:30 Changeset [123907] by
-
Show the unavailable plug-in indicator for Java applets as well
https://bugs.webkit.org/show_bug.cgi?id=92521
Reviewed by Sam Weinig.
Source/WebCore:
Now that <applet> behaves more like <embed> and <object>, make sure that we show the unavailable plug-in indicator
and call the correct error callbacks if we fail to instantiate the plug-in.
- WebCore.exp.in:
Export a symbol needed by WebKit2.
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::HTMLAppletElement):
Set the correct service type.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
Enable the unavailable plug-in indicator if we fail to create the java applet widget.
Source/WebKit/mac:
Check if the Java plug-in is blocked before trying to instantiate it.
- WebCoreSupport/WebFrameLoaderClient.mm:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
This can now be called on applet elements as well.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
Get the MIME type from the applet element.
- 12:30 Changeset [123906] by
-
Unreviewed build fix.
Source/WTF:
Use MathExtras.h and the non std:: versions of isnan and signbit.
- wtf/MediaTime.cpp:
(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
Tools:
Wrap MSVC-specific fixes is a COMPILER() check, not a PLATFORM() check.
- TestWebKitAPI/Tests/WTF/MediaTime.cpp:
- 12:29 Changeset [123905] by
-
Increase inline storage for JSFinalObjects by one
https://bugs.webkit.org/show_bug.cgi?id=92526
Reviewed by Geoffrey Garen.
Now that we've removed the inheritorID from objects, we can increase our inline storage for JSFinalObjects on
64-bit platforms by 1.
- llint/LowLevelInterpreter.asm: Change the constant.
- runtime/PropertyOffset.h: Change the constant.
(JSC):
- 12:25 Changeset [123904] by
-
Hit testing near a column break can return a result from an adjacent column when there is leading
https://bugs.webkit.org/show_bug.cgi?id=92524
Reviewed by Anders Carlsson.
Source/WebCore:
The fix for <http://webkit.org/b/92311> relied on the existence of a pagination strut for
detecting that a line was at the beginning of a new column. However, when a line naturally
falls at the beginning of a column, there is no pagination strut, and the check failed.
Test: fast/multicol/hit-test-end-of-column-with-line-height.html
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox): Added initializer for new member variable.
(InlineFlowBox): Added m_isFirstAfterPageBreak member variable.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren): Changed the test for whether a
line was at the beginning of a column from relying on a pagination strut to checking
isFirstAfterPageBreak(). Also refined the hit test itself to include the leading above such
a line.
(WebCore::RenderBlock::adjustLinePositionForPagination): Added calls to
setIsFirstAfterPageBreak() to first reset this flag, then set it to true if necessary.
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::isFirstAfterPageBreak): Added this accessor.
(WebCore::RootInlineBox::setIsFirstAfterPageBreak): Ditto.
LayoutTests:
- fast/multicol/hit-test-end-of-column-with-line-height-expected.txt: Added.
- fast/multicol/hit-test-end-of-column-with-line-height.html: Added.
- 12:03 Changeset [123903] by
-
[WK2] Fix build warning in WebEventConversion.cpp
https://bugs.webkit.org/show_bug.cgi?id=92517
Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2012-07-27
Reviewed by Darin Adler.
There is a build warning related to comparison between signed and unsigned integer expressions.
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):
- 12:02 Changeset [123902] by
-
Web Inspector: Allow front_end to be loaded into an iframe
https://bugs.webkit.org/show_bug.cgi?id=92437
Patch by John J. Barton <johnjbarton@johnjbarton.com> on 2012-07-27
Reviewed by Pavel Feldman.
This change only affects 'embedders' of the inspector/front_end. No change of function for WebKit ports.
- inspector/front-end/ExtensionAPI.js:
Replace window.top with window.parent two places. When WebInspector is loaded as the main window content,
then extension iframes have window.top === window.parent; when WebInspector is loaded as an iframe, then
extensions are iframes in iframes and we need to use a relative address window.parent.
(injectedExtensionAPI.ExtensionViewImpl.dispatchShowEvent):
(injectedExtensionAPI.ExtensionViewImpl):
(injectedExtensionAPI.ExtensionServerClient):
WebKit/chromium/scripts/generate_devtools_extension_api.py:
The current number of frames is used in a dynamically created identifier. Again we replace 'top' by
window.parent.
- 11:54 Changeset [123901] by
-
Web Inspector: InspectorPageAgent should ascertain document to be non-null in updateViewMetrics()
https://bugs.webkit.org/show_bug.cgi?id=92476
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-27
Reviewed by Pavel Feldman.
InspectorPageAgent should check for document object being null. As pages created with blank URL might
not have the document object, this causes a crash.
No new tests as added null check.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::updateViewMetrics):
- 11:42 Changeset [123900] by
-
[Chromium-Android] NRWT better handling of DRT deadlocks and crashes
https://bugs.webkit.org/show_bug.cgi?id=92299
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2012-07-27
Reviewed by Dirk Pranke.
- Changed the deadlock detector thread target from a method of driver to a function to avoid its reference to the current driver (see the bug for the problem of the reference.
- Let the deadlock detector thread exit early when the normal_startup_event is set to avoid it from blocking the main thread when the main thread is exiting.
- Extracted common loop until timeout logic into ChromiumAndroidDriver._loop_with_timeout().
- Use the "for i in range(n)" style suggested by dpranke in https://bugs.webkit.org/show_bug.cgi?id=89124 in several functions.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.init):
(ChromiumAndroidPort._run_adb_command): Reduced the verbose output.
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._loop_with_timeout): Extracted common loop until timeout logic here.
(ChromiumAndroidDriver._all_pipes_created):
(ChromiumAndroidDriver._remove_all_pipes):
(ChromiumAndroidDriver._start): Changed the retry loop style.
(ChromiumAndroidDriver._start_once): Changed the loop style and code related to deadlock detector.
(ChromiumAndroidDriver._start_once.deadlock_detector): Moved the original ChromiumAndroidDriver._deadlock_detector() here.
(ChromiumAndroidDriver.stop): Changed the loop style.
- 11:38 Changeset [123899] by
-
CSP directives containing invalid characters should log an error.
https://bugs.webkit.org/show_bug.cgi?id=92487
Patch by Mike West <mkwst@chromium.org> on 2012-07-27
Reviewed by Adam Barth.
Source/WebCore:
Unknown directive names are currently logged, but we exit the directive
parser early without logging if we hit an invalid character inside a
directive. script-src: ..., for example, was ignored without letting
the developer know what happened. This patch changes that behavior,
logging the whole name (in this case script-src:) as an unknown
directive.
Test: http/tests/security/contentSecurityPolicy/directive-parsing-04.html
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::parseDirective):
LayoutTests:
- http/tests/security/contentSecurityPolicy/directive-parsing-03-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/directive-parsing-04-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/directive-parsing-04.html: Added.
Adding a test specifically for script-src: ... which bit me, and
updating test #3, which now has a better error message.
- 11:26 Changeset [123898] by
-
nrwt: move collect_tests(), parse_expectations() into manager
https://bugs.webkit.org/show_bug.cgi?id=92423
Reviewed by Ojan Vafai.
This is the first in a series of patches refactoring
run_webkit_tests.py and manager.py to make them more
maintainable; all this patch does is move a couple of functions
into manager.run_tests() so manager's public interface is
simple.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._collect_tests):
(Manager._parse_expectations):
(Manager._split_into_chunks_if_necessary):
(Manager.run):
(read_test_files):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_http_locking):
(ManagerTest.test_perf_locking):
(ManagerTest.integration_test_needs_servers.get_manager_with_tests):
(ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
- 11:25 Changeset [123897] by
-
Add more Russian replay performance tests
https://bugs.webkit.org/show_bug.cgi?id=92462
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2012-07-27
Reviewed by Tony Chang.
Add more Russian sites as suggested by loislo.
- Replay/Russian/lenta.ru.replay: Added.
- Replay/Russian/www.ixbt.com.replay: Added.
- Replay/Russian/www.kp.ru.replay: Added.
- Replay/Russian/www.liveinternet.ru.replay: Added.
- Replay/Russian/www.pravda.ru.replay: Added.
- 11:25 Changeset [123896] by
-
[Qt] platform/qt/svg/custom tests needs update after font change.
https://bugs.webkit.org/show_bug.cgi?id=91090.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-27
Reviewed by Zoltan Herczeg.
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0-wk2/svg/custom/altglyph-expected.png: Removed.
- platform/qt-5.0-wk2/svg/custom/altglyph-expected.txt: Removed.
- platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.png: Removed.
- platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.txt: Removed.
- platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt.
- platform/qt-5.0/Skipped:
- platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.png: Removed.
- platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
- platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.png: Removed.
- platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt: Removed.
- platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
- platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.png: Removed.
- platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.txt: Removed.
- platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.png: Removed.
- platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.txt: Removed.
- platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Removed.
- platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
- platform/qt-5.0/svg/custom/svg-features-expected.txt: Removed.
- platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.png: Removed.
- platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.txt: Removed.
- platform/qt-5.0/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
- platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.png: Removed.
- platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.txt: Removed.
- platform/qt-5.0/svg/custom/text-linking-expected.png: Removed.
- platform/qt-5.0/svg/custom/text-linking-expected.txt: Removed.
- platform/qt/svg/custom/SVGMatrix-interface-expected.png:
- platform/qt/svg/custom/SVGMatrix-interface-expected.txt:
- platform/qt/svg/custom/SVGPoint-matrixTransform-expected.png:
- platform/qt/svg/custom/SVGPoint-matrixTransform-expected.txt:
- platform/qt/svg/custom/absolute-sized-content-with-resources-expected.png:
- platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:
- platform/qt/svg/custom/absolute-sized-svg-in-xhtml-expected.png:
- platform/qt/svg/custom/absolute-sized-svg-in-xhtml-expected.txt:
- platform/qt/svg/custom/alignment-baseline-modes-expected.png:
- platform/qt/svg/custom/alignment-baseline-modes-expected.txt:
- platform/qt/svg/custom/altglyph-expected.png:
- platform/qt/svg/custom/altglyph-expected.txt:
- platform/qt/svg/custom/baseval-animval-equality-expected.png:
- platform/qt/svg/custom/baseval-animval-equality-expected.txt:
- platform/qt/svg/custom/broken-internal-references-expected.txt:
- platform/qt/svg/custom/bug45331-expected.png: Added.
- platform/qt/svg/custom/bug45331-expected.txt: Added.
- platform/qt/svg/custom/bug86119-expected.txt:
- platform/qt/svg/custom/circle-move-invalidation-expected.png:
- platform/qt/svg/custom/circle-move-invalidation-expected.txt:
- platform/qt/svg/custom/clip-path-referencing-use-expected.png:
- platform/qt/svg/custom/clip-path-referencing-use-expected.txt:
- platform/qt/svg/custom/clip-path-referencing-use2-expected.png:
- platform/qt/svg/custom/clip-path-referencing-use2-expected.txt:
- platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.png:
- platform/qt/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
- platform/qt/svg/custom/container-opacity-clip-viewBox-expected.png:
- platform/qt/svg/custom/container-opacity-clip-viewBox-expected.txt:
- platform/qt/svg/custom/coords-relative-units-transforms-expected.png:
- platform/qt/svg/custom/coords-relative-units-transforms-expected.txt:
- platform/qt/svg/custom/createImageElement2-expected.png: Added.
- platform/qt/svg/custom/createImageElement2-expected.txt:
- platform/qt/svg/custom/dominant-baseline-hanging-expected.png:
- platform/qt/svg/custom/dominant-baseline-hanging-expected.txt:
- platform/qt/svg/custom/dominant-baseline-modes-expected.png:
- platform/qt/svg/custom/dominant-baseline-modes-expected.txt:
- platform/qt/svg/custom/dynamic-svg-document-creation-expected.png:
- platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt:
- platform/qt/svg/custom/embedding-external-svgs-expected.png:
- platform/qt/svg/custom/embedding-external-svgs-expected.txt:
- platform/qt/svg/custom/empty-clip-path-expected.png:
- platform/qt/svg/custom/empty-clip-path-expected.txt:
- platform/qt/svg/custom/empty-mask-expected.png: Added.
- platform/qt/svg/custom/empty-mask-expected.txt:
- platform/qt/svg/custom/external-paintserver-reference-expected.png:
- platform/qt/svg/custom/external-paintserver-reference-expected.txt:
- platform/qt/svg/custom/fill-SVGPaint-interface-expected.png:
- platform/qt/svg/custom/fill-SVGPaint-interface-expected.txt:
- platform/qt/svg/custom/fill-fallback-expected.png:
- platform/qt/svg/custom/fill-fallback-expected.txt:
- platform/qt/svg/custom/focus-ring-expected.png:
- platform/qt/svg/custom/focus-ring-expected.txt:
- platform/qt/svg/custom/font-face-cascade-order-expected.png:
- platform/qt/svg/custom/font-face-cascade-order-expected.txt:
- platform/qt/svg/custom/font-face-simple-expected.png:
- platform/qt/svg/custom/font-face-simple-expected.txt:
- platform/qt/svg/custom/foreign-object-skew-expected.png:
- platform/qt/svg/custom/foreign-object-skew-expected.txt:
- platform/qt/svg/custom/foreignObject-crash-on-hover-expected.png:
- platform/qt/svg/custom/foreignObject-crash-on-hover-expected.txt:
- platform/qt/svg/custom/getPresentationAttribute-expected.png:
- platform/qt/svg/custom/getPresentationAttribute-expected.txt:
- platform/qt/svg/custom/getTransformToElement-expected.png:
- platform/qt/svg/custom/getTransformToElement-expected.txt:
- platform/qt/svg/custom/getscreenctm-in-mixed-content-expected.png:
- platform/qt/svg/custom/getscreenctm-in-mixed-content-expected.txt:
- platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
- platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
- platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
- platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
- platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
- platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
- platform/qt/svg/custom/getsvgdocument-expected.png:
- platform/qt/svg/custom/getsvgdocument-expected.txt:
- platform/qt/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
- platform/qt/svg/custom/glyph-selection-arabic-forms-expected.txt:
- platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.png: Copied from LayoutTests/platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.png.
- platform/qt/svg/custom/glyph-selection-bidi-mirror-expected.txt:
- platform/qt/svg/custom/glyph-selection-non-bmp-expected.png: Renamed from LayoutTests/platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.png.
- platform/qt/svg/custom/glyph-selection-non-bmp-expected.txt:
- platform/qt/svg/custom/glyph-transformation-with-hkern-expected.png:
- platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt:
- platform/qt/svg/custom/gradient-cycle-detection-expected.png:
- platform/qt/svg/custom/gradient-cycle-detection-expected.txt:
- platform/qt/svg/custom/gradient-deep-referencing-expected.png:
- platform/qt/svg/custom/gradient-deep-referencing-expected.txt:
- platform/qt/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
- platform/qt/svg/custom/gradient-with-1d-boundingbox-expected.txt:
- platform/qt/svg/custom/hit-test-path-expected.png:
- platform/qt/svg/custom/hit-test-path-expected.txt:
- platform/qt/svg/custom/hit-test-path-stroke-expected.png:
- platform/qt/svg/custom/hit-test-path-stroke-expected.txt:
- platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.png:
- platform/qt/svg/custom/hit-test-unclosed-subpaths-expected.txt:
- platform/qt/svg/custom/image-parent-translation-expected.png:
- platform/qt/svg/custom/image-parent-translation-expected.txt:
- platform/qt/svg/custom/image-rescale-clip-expected.png:
- platform/qt/svg/custom/image-rescale-clip-expected.txt:
- platform/qt/svg/custom/image-rescale-scroll-expected.png:
- platform/qt/svg/custom/image-rescale-scroll-expected.txt:
- platform/qt/svg/custom/image-small-width-height-expected.png:
- platform/qt/svg/custom/image-small-width-height-expected.txt:
- platform/qt/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/qt/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/qt/svg/custom/inline-svg-in-xhtml-expected.png:
- platform/qt/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/qt/svg/custom/invalid-css-expected.png:
- platform/qt/svg/custom/invalid-css-expected.txt:
- platform/qt/svg/custom/invalid-fill-expected.png:
- platform/qt/svg/custom/invalid-fill-expected.txt:
- platform/qt/svg/custom/invalid-fill-hex-expected.png:
- platform/qt/svg/custom/invalid-fill-hex-expected.txt:
- platform/qt/svg/custom/invalid-lengthlist-expected.png:
- platform/qt/svg/custom/invalid-lengthlist-expected.txt:
- platform/qt/svg/custom/invalid-stroke-hex-expected.png: Added.
- platform/qt/svg/custom/invalid-stroke-hex-expected.txt:
- platform/qt/svg/custom/invalid-uri-stroke-expected.png: Added.
- platform/qt/svg/custom/invalid-uri-stroke-expected.txt:
- platform/qt/svg/custom/invisible-text-after-scrolling-expected.png:
- platform/qt/svg/custom/invisible-text-after-scrolling-expected.txt:
- platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.png:
- platform/qt/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
- platform/qt/svg/custom/js-late-clipPath-creation-expected.png:
- platform/qt/svg/custom/js-late-clipPath-creation-expected.txt:
- platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.png:
- platform/qt/svg/custom/js-late-gradient-and-object-creation-expected.txt:
- platform/qt/svg/custom/js-late-gradient-creation-expected.png:
- platform/qt/svg/custom/js-late-gradient-creation-expected.txt:
- platform/qt/svg/custom/js-update-stop-linked-gradient-expected.png:
- platform/qt/svg/custom/js-update-stop-linked-gradient-expected.txt:
- platform/qt/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
- platform/qt/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
- platform/qt/svg/custom/linking-a-03-b-transform-expected.png:
- platform/qt/svg/custom/linking-a-03-b-transform-expected.txt:
- platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png:
- platform/qt/svg/custom/linking-a-03-b-viewBox-expected.txt:
- platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
- platform/qt/svg/custom/linking-a-03-b-viewTarget-expected.png:
- platform/qt/svg/custom/linking-a-03-b-viewTarget-expected.txt:
- platform/qt/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
- platform/qt/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
- platform/qt/svg/custom/linking-base-external-reference-expected.png:
- platform/qt/svg/custom/linking-base-external-reference-expected.txt:
- platform/qt/svg/custom/linking-uri-01-b-expected.png:
- platform/qt/svg/custom/linking-uri-01-b-expected.txt:
- platform/qt/svg/custom/marker-default-width-height-expected.png:
- platform/qt/svg/custom/marker-default-width-height-expected.txt:
- platform/qt/svg/custom/marker-overflow-clip-expected.png:
- platform/qt/svg/custom/marker-overflow-clip-expected.txt:
- platform/qt/svg/custom/mouse-move-on-svg-container-expected.png:
- platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
- platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
- platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
- platform/qt/svg/custom/mouse-move-on-svg-root-expected.png:
- platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
- platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
- platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
- platform/qt/svg/custom/no-inherited-dashed-stroke-expected.png:
- platform/qt/svg/custom/no-inherited-dashed-stroke-expected.txt:
- platform/qt/svg/custom/non-opaque-filters-expected.png:
- platform/qt/svg/custom/non-opaque-filters-expected.txt:
- platform/qt/svg/custom/object-no-size-attributes-expected.png:
- platform/qt/svg/custom/object-no-size-attributes-expected.txt:
- platform/qt/svg/custom/object-sizing-expected.png:
- platform/qt/svg/custom/object-sizing-expected.txt:
- platform/qt/svg/custom/object-sizing-explicit-height-expected.png:
- platform/qt/svg/custom/object-sizing-explicit-height-expected.txt:
- platform/qt/svg/custom/object-sizing-explicit-width-expected.png:
- platform/qt/svg/custom/object-sizing-explicit-width-expected.txt:
- platform/qt/svg/custom/object-sizing-explicit-width-height-expected.png:
- platform/qt/svg/custom/object-sizing-explicit-width-height-expected.txt:
- platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png:
- platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.png:
- platform/qt/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt:
- platform/qt/svg/custom/object-sizing-no-width-height-expected.png:
- platform/qt/svg/custom/object-sizing-no-width-height-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.png:
- platform/qt/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt:
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt:
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png:
- platform/qt/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
- platform/qt/svg/custom/path-textPath-simulation-expected.png:
- platform/qt/svg/custom/path-textPath-simulation-expected.txt:
- platform/qt/svg/custom/pattern-cycle-detection-expected.png:
- platform/qt/svg/custom/pattern-cycle-detection-expected.txt:
- platform/qt/svg/custom/pattern-deep-referencing-expected.png:
- platform/qt/svg/custom/pattern-deep-referencing-expected.txt:
- platform/qt/svg/custom/pattern-incorrect-tiling-expected.png:
- platform/qt/svg/custom/pattern-incorrect-tiling-expected.txt:
- platform/qt/svg/custom/pattern-rotate-expected.png:
- platform/qt/svg/custom/pattern-rotate-expected.txt:
- platform/qt/svg/custom/pattern-rotate-gaps-expected.png:
- platform/qt/svg/custom/pattern-rotate-gaps-expected.txt:
- platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png:
- platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:
- platform/qt/svg/custom/pattern-with-transformation-expected.png:
- platform/qt/svg/custom/pattern-with-transformation-expected.txt:
- platform/qt/svg/custom/percentage-of-html-parent-expected.png:
- platform/qt/svg/custom/percentage-of-html-parent-expected.txt:
- platform/qt/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt:
- platform/qt/svg/custom/pointer-events-image-expected.png:
- platform/qt/svg/custom/pointer-events-image-expected.txt:
- platform/qt/svg/custom/pointer-events-path-expected.png:
- platform/qt/svg/custom/pointer-events-path-expected.txt:
- platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
- platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
- platform/qt/svg/custom/pointer-events-text-expected.png:
- platform/qt/svg/custom/pointer-events-text-expected.txt:
- platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.png:
- platform/qt/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
- platform/qt/svg/custom/recursive-clippath-expected.png:
- platform/qt/svg/custom/recursive-clippath-expected.txt:
- platform/qt/svg/custom/recursive-filter-expected.png:
- platform/qt/svg/custom/recursive-filter-expected.txt:
- platform/qt/svg/custom/recursive-gradient-expected.png:
- platform/qt/svg/custom/recursive-gradient-expected.txt:
- platform/qt/svg/custom/recursive-mask-expected.png:
- platform/qt/svg/custom/recursive-mask-expected.txt:
- platform/qt/svg/custom/recursive-pattern-expected.png:
- platform/qt/svg/custom/recursive-pattern-expected.txt:
- platform/qt/svg/custom/relative-sized-content-expected.png: Added.
- platform/qt/svg/custom/relative-sized-content-expected.txt:
- platform/qt/svg/custom/relative-sized-content-with-resources-expected.png:
- platform/qt/svg/custom/relative-sized-content-with-resources-expected.txt:
- platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.png:
- platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
- platform/qt/svg/custom/relative-sized-image-expected.png:
- platform/qt/svg/custom/relative-sized-image-expected.txt:
- platform/qt/svg/custom/relative-sized-inner-svg-expected.png:
- platform/qt/svg/custom/relative-sized-inner-svg-expected.txt:
- platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.png:
- platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
- platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png:
- platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
- platform/qt/svg/custom/relative-sized-use-on-symbol-expected.png:
- platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
- platform/qt/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
- platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.png:
- platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.txt:
- platform/qt/svg/custom/scroll-hit-test-expected.png:
- platform/qt/svg/custom/scroll-hit-test-expected.txt:
- platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/qt/svg/custom/second-inline-text-expected.png:
- platform/qt/svg/custom/second-inline-text-expected.txt:
- platform/qt/svg/custom/shape-rendering-expected.png:
- platform/qt/svg/custom/shape-rendering-expected.txt:
- platform/qt/svg/custom/shapes-supporting-markers-expected.png:
- platform/qt/svg/custom/shapes-supporting-markers-expected.txt:
- platform/qt/svg/custom/simple-text-double-shadow-expected.png:
- platform/qt/svg/custom/simple-text-double-shadow-expected.txt:
- platform/qt/svg/custom/simpleCDF-expected.png:
- platform/qt/svg/custom/simpleCDF-expected.txt:
- platform/qt/svg/custom/stroke-fallback-expected.png:
- platform/qt/svg/custom/stroke-fallback-expected.txt:
- platform/qt/svg/custom/stroke-width-large-expected.png:
- platform/qt/svg/custom/stroke-width-large-expected.txt:
- platform/qt/svg/custom/stroked-pattern-expected.png:
- platform/qt/svg/custom/stroked-pattern-expected.txt:
- platform/qt/svg/custom/style-attribute-font-size-expected.png:
- platform/qt/svg/custom/style-attribute-font-size-expected.txt:
- platform/qt/svg/custom/svg-curve-with-relative-cordinates-expected.png:
- platform/qt/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
- platform/qt/svg/custom/svg-features-expected.txt:
- platform/qt/svg/custom/svg-float-border-padding-expected.png:
- platform/qt/svg/custom/svg-float-border-padding-expected.txt:
- platform/qt/svg/custom/svg-fonts-in-html-expected.png:
- platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
- platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt:
- platform/qt/svg/custom/svg-fonts-segmented-expected.png:
- platform/qt/svg/custom/svg-fonts-segmented-expected.txt:
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
- platform/qt/svg/custom/svg-fonts-word-spacing-expected.png:
- platform/qt/svg/custom/svg-fonts-word-spacing-expected.txt:
- platform/qt/svg/custom/svg-overflow-types-expected.png:
- platform/qt/svg/custom/svg-overflow-types-expected.txt:
- platform/qt/svg/custom/text-clip-expected.png:
- platform/qt/svg/custom/text-clip-expected.txt:
- platform/qt/svg/custom/text-ctm-expected.png:
- platform/qt/svg/custom/text-ctm-expected.txt:
- platform/qt/svg/custom/text-decoration-visibility-expected.png:
- platform/qt/svg/custom/text-decoration-visibility-expected.txt:
- platform/qt/svg/custom/text-dom-01-f-expected.png:
- platform/qt/svg/custom/text-dom-01-f-expected.txt:
- platform/qt/svg/custom/text-filter-expected.png:
- platform/qt/svg/custom/text-filter-expected.txt:
- platform/qt/svg/custom/text-hit-test-expected.png:
- platform/qt/svg/custom/text-hit-test-expected.txt:
- platform/qt/svg/custom/text-image-opacity-expected.png:
- platform/qt/svg/custom/text-image-opacity-expected.txt:
- platform/qt/svg/custom/text-letter-spacing-expected.png:
- platform/qt/svg/custom/text-letter-spacing-expected.txt:
- platform/qt/svg/custom/text-linking-expected.png:
- platform/qt/svg/custom/text-linking-expected.txt:
- platform/qt/svg/custom/text-repaint-including-stroke-expected.png:
- platform/qt/svg/custom/text-repaint-including-stroke-expected.txt:
- platform/qt/svg/custom/text-rotated-gradient-expected.png:
- platform/qt/svg/custom/text-rotated-gradient-expected.txt:
- platform/qt/svg/custom/text-rotation-expected.png:
- platform/qt/svg/custom/text-rotation-expected.txt:
- platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.png:
- platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.txt:
- platform/qt/svg/custom/text-tref-03-b-change-href-expected.png:
- platform/qt/svg/custom/text-tref-03-b-change-href-expected.txt:
- platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.png:
- platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt:
- platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.png:
- platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.txt:
- platform/qt/svg/custom/text-whitespace-handling-expected.png:
- platform/qt/svg/custom/text-whitespace-handling-expected.txt:
- platform/qt/svg/custom/text-x-dx-lists-expected.png:
- platform/qt/svg/custom/text-x-dx-lists-expected.txt:
- platform/qt/svg/custom/text-x-dy-lists-expected.png:
- platform/qt/svg/custom/text-x-dy-lists-expected.txt:
- platform/qt/svg/custom/text-x-override-in-tspan-child-expected.png:
- platform/qt/svg/custom/text-x-override-in-tspan-child-expected.txt:
- platform/qt/svg/custom/text-xy-updates-SVGList-expected.png:
- platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
- platform/qt/svg/custom/text-xy-updates-expected.png:
- platform/qt/svg/custom/text-xy-updates-expected.txt:
- platform/qt/svg/custom/tref-own-content-removal-expected.png:
- platform/qt/svg/custom/tref-own-content-removal-expected.txt:
- platform/qt/svg/custom/tref-update-expected.png:
- platform/qt/svg/custom/tref-update-expected.txt:
- platform/qt/svg/custom/use-clipped-hit-expected.png:
- platform/qt/svg/custom/use-clipped-hit-expected.txt:
- platform/qt/svg/custom/use-detach-expected.png:
- platform/qt/svg/custom/use-detach-expected.txt:
- platform/qt/svg/custom/use-dynamic-append-expected.png:
- platform/qt/svg/custom/use-dynamic-append-expected.txt:
- platform/qt/svg/custom/use-elementInstance-event-target-expected.png:
- platform/qt/svg/custom/use-elementInstance-event-target-expected.txt:
- platform/qt/svg/custom/use-elementInstance-methods-expected.png:
- platform/qt/svg/custom/use-elementInstance-methods-expected.txt:
- platform/qt/svg/custom/use-event-handler-on-referenced-element-expected.png:
- platform/qt/svg/custom/use-event-handler-on-referenced-element-expected.txt:
- platform/qt/svg/custom/use-event-handler-on-use-element-expected.png:
- platform/qt/svg/custom/use-event-handler-on-use-element-expected.txt:
- platform/qt/svg/custom/use-events-crash-expected.png:
- platform/qt/svg/custom/use-events-crash-expected.txt:
- platform/qt/svg/custom/use-instanceRoot-modifications-expected.png:
- platform/qt/svg/custom/use-instanceRoot-modifications-expected.txt:
- platform/qt/svg/custom/use-modify-container-in-target-expected.png:
- platform/qt/svg/custom/use-modify-container-in-target-expected.txt:
- platform/qt/svg/custom/use-modify-target-container-expected.png:
- platform/qt/svg/custom/use-modify-target-container-expected.txt:
- platform/qt/svg/custom/use-modify-target-symbol-expected.png:
- platform/qt/svg/custom/use-modify-target-symbol-expected.txt:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
- platform/qt/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
- platform/qt/svg/custom/use-on-g-containing-symbol-expected.png:
- platform/qt/svg/custom/use-on-g-containing-symbol-expected.txt:
- platform/qt/svg/custom/use-on-g-containing-use-expected.png:
- platform/qt/svg/custom/use-on-g-containing-use-expected.txt:
- platform/qt/svg/custom/use-on-g-expected.png:
- platform/qt/svg/custom/use-on-g-expected.txt:
- platform/qt/svg/custom/use-on-non-svg-namespaced-element-expected.png:
- platform/qt/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
- platform/qt/svg/custom/use-on-rect-expected.png:
- platform/qt/svg/custom/use-on-rect-expected.txt:
- platform/qt/svg/custom/use-on-symbol-expected.png:
- platform/qt/svg/custom/use-on-symbol-expected.txt:
- platform/qt/svg/custom/use-on-text-expected.png:
- platform/qt/svg/custom/use-on-text-expected.txt:
- platform/qt/svg/custom/use-on-use-expected.png:
- platform/qt/svg/custom/use-on-use-expected.txt:
- platform/qt/svg/custom/use-property-changes-through-dom-expected.png:
- platform/qt/svg/custom/use-property-changes-through-dom-expected.txt:
- platform/qt/svg/custom/use-property-changes-through-svg-dom-expected.png:
- platform/qt/svg/custom/use-property-changes-through-svg-dom-expected.txt:
- platform/qt/svg/custom/use-recursion-1-expected.png:
- platform/qt/svg/custom/use-recursion-1-expected.txt:
- platform/qt/svg/custom/use-recursion-2-expected.png:
- platform/qt/svg/custom/use-recursion-2-expected.txt:
- platform/qt/svg/custom/use-recursion-3-expected.png:
- platform/qt/svg/custom/use-recursion-3-expected.txt:
- platform/qt/svg/custom/use-recursion-4-expected.png:
- platform/qt/svg/custom/use-recursion-4-expected.txt:
- platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.png:
- platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
- platform/qt/svg/custom/use-setAttribute-crash-expected.png:
- platform/qt/svg/custom/use-setAttribute-crash-expected.txt:
- platform/qt/svg/custom/use-transform-expected.png:
- platform/qt/svg/custom/use-transform-expected.txt:
- platform/qt/svg/custom/viewbox-syntax-expected.png:
- platform/qt/svg/custom/viewbox-syntax-expected.txt:
- platform/qt/svg/custom/viewport-em-expected.png:
- platform/qt/svg/custom/viewport-em-expected.txt:
- 11:23 Changeset [123895] by
-
nrwt: print filtered stderr after a crash correctly
https://bugs.webkit.org/show_bug.cgi?id=92428
Reviewed by Adam Barth.
Some ports will run the stderr output from DRT/WTR through a
filter after a crash in order to print a more useful stack
trace; while that gets written to the crash log correctly, we
don't log it to the debug output properly. This change fixes
that and makes it clearer that we're logging stderr, not the
crash log.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._handle_error):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port._get_crash_log):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._get_crash_log):
- Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(ChromiumAndroidPortTest.test_get_crash_log):
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):
- Scripts/webkitpy/layout_tests/port/gtk.py:
- Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._get_crash_log):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_get_crash_log):
- 11:22 Changeset [123894] by
-
[Texmap] Performance regression in texture uploads after r121223
https://bugs.webkit.org/show_bug.cgi?id=91897
Reviewed by Jocelyn Turcotte.
Rolling out r121223, with some conflict fixes.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::swizzleBGRAToRGBA):
(WebCore):
(WebCore::driverSupportsBGRASwizzling):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):
- 11:21 Changeset [123893] by
-
nrwt: move image diffing code to a separate module
https://bugs.webkit.org/show_bug.cgi?id=92447
Reviewed by Ryosuke Niwa.
This patch moves the code to talk to ImageDiff into its own
module, and adds more tests for it. In addition, the patch
modifies diff_image() so that we don't automatically stop
ImageDiff after a single invocation, and thus subsequent
diffs may be slightly faster. (Note that the chromium ports
don't use any of this code; that is not changed by this patch).
The main motivation for this change is to move more "generic"
code out of the port/* classes, and in particular to move more
code out of webkit.py so that we can eventually eliminate it by
merging it into base.py.
This patch also splits MockServerProcess out from driver_unittest.py
so that it can be re-used.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.init):
(Port.diff_image):
(Port.clean_up_test_run):
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.init):
(Driver._start):
- Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_stop_cleans_up_properly):
(DriverTest.test_two_starts_cleans_up_properly):
(DriverTest.test_start_actually_starts):
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.clean_up_test_run):
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.clean_up_test_run):
- Scripts/webkitpy/layout_tests/port/image_diff.py: Added.
(ImageDiffer):
(ImageDiffer.init):
(ImageDiffer.diff_image):
(ImageDiffer._start):
(ImageDiffer._read):
(ImageDiffer.stop):
- Scripts/webkitpy/layout_tests/port/image_diff_unittest.py: Added.
(for):
(FakePort):
(FakePort.init):
(FakePort._path_to_image_diff):
(FakePort.setup_environ_for_server):
(TestImageDiffer):
(TestImageDiffer.test_diff_image):
- Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.test_diff_image):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_diff_imagemissing_both):
(PortTestCase.test_diff_image):
(PortTestCase.test_diff_image.make_proc):
- Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._start):
- Scripts/webkitpy/layout_tests/port/server_process_mock.py: Added.
(MockServerProcess):
(MockServerProcess.init):
(MockServerProcess.write):
(MockServerProcess.has_crashed):
(MockServerProcess.read_stdout_line):
(MockServerProcess.read_stdout):
(MockServerProcess.pop_all_buffered_stderr):
(MockServerProcess.read_either_stdout_or_stderr_line):
(MockServerProcess.start):
(MockServerProcess.stop):
(MockServerProcess.kill):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._build_driver_flags):
(WebKitPort._symbols_string):
- 11:17 Changeset [123892] by
-
Activate committer bit granted April 6th so I can garden.
https://bugs.webkit.org/show_bug.cgi?id=92500
Patch by Tom Hudson <hudson@google.com> on 2012-07-27
Reviewed by Jochen Eisinger.
- Scripts/webkitpy/common/config/committers.py:
- 11:13 Changeset [123891] by
-
[BlackBerry] Should support onbeforeunload event and show confirmation dialog
https://bugs.webkit.org/show_bug.cgi?id=92510
Patch by Yong Li <yoli@rim.com> on 2012-07-27
Reviewed by Antonio Gomes.
RIM PR# 155878.
- Export dispatchBeforeUnloadEvent() so client can call it before going to close the page.
- Forward runBeforeUnloadConfirmPanel() call to client so it can show a dialog.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::dispatchBeforeUnloadEvent):
(WebKit):
- Api/WebPage.h:
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::canRunBeforeUnloadConfirmPanel):
(WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
- 11:04 Changeset [123890] by
-
[BlackBerry] Update NetworkJob::sendRequestWithCredentials to use new getProxyAddress API
https://bugs.webkit.org/show_bug.cgi?id=92457
Patch by Joe Mason <jmason@rim.com> on 2012-07-27
Reviewed by Yong Li.
getProxyAddress now returns "host:port", and getProxyPort is gone. Update NetworkJob to use
the new interface.
RIM PR: 176166
Internally reviewed by Jonathan Dong <jonathan.dong@torchmobile.com.cn>
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
- 10:59 Changeset [123889] by
-
Improve touch adjustment for targetting small controls.
https://bugs.webkit.org/show_bug.cgi?id=92293
Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-27
Reviewed by Antonio Gomes.
Source/WebCore:
Modifies the touch adjustment algorithm to better discriminate small targets without introducing
a bias towards shorter links. The revised scoring algorihtm uses a normalized distance to
center-line score and a normalized overlap score. The better of the two scores is used for
determining the best candidate for target adjustment. The center-line score works well
for discriminating elements with partial overlaps, where relying solely on percent overlap
could bias towards the smaller element. Conversely, a high percentage in overlap provides a
strong measure of confidence in a candidate target. An additonal tie-break algorithm is
introduced to minimize the adjustment distance if two equally suitable candidates are found.
Test: touchadjustment/small-target-test.html
- page/TouchAdjustment.cpp:
(TouchAdjustment):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
(WebCore::TouchAdjustment::hybridDistanceFunction):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):
(WebCore::findBestClickableCandidate):
LayoutTests:
Adds a test for cases that were problematic for the touch adjustment algorithm. Each example
in the test involves a small control immediately adjacent to a larger control. When the touch
area is significantly larger than the small control, it was possible for the touch element to
completely overlap the control yet select an adjacent element with a partial overlap.
- touchadjustment/small-target-test-expected.txt: Added.
- touchadjustment/small-target-test.html: Added.
- 10:56 Changeset [123888] by
-
[chromium] Calendar for input type=date should be larger on devices that support touch input.
https://bugs.webkit.org/show_bug.cgi?id=92424
Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-27
Reviewed by Kent Tamura.
Source/WebCore:
Adds touch specific CSS rules to enlarge entries in the calendar on
screens that support touch input.
Manually tested with touch support enabled/disabled.
- Resources/calendarPicker.css:
(@media (pointer:coarse)):
- html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::contentSize):
Source/WebKit/chromium:
Plumbs the deviceSupportsTouch setting through to the popup page so
that the Calendar popup can be enlarged on screens that support touch
input.
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::initPage):
- 10:50 Changeset [123887] by
-
[EFL] Add missing baselines for fast/table/table-row-outline-paint.html
https://bugs.webkit.org/show_bug.cgi?id=92509
Unreviewed EFL gardening, add missing results for
fast/table/table-row-outline-paint.html after r123793.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-27
- platform/efl/fast/table/table-row-outline-paint-expected.png: Added.
- platform/efl/fast/table/table-row-outline-paint-expected.txt: Added.
- 10:48 Changeset [123886] by
-
Lose a timer in prerender-remove-after-stop.html
https://bugs.webkit.org/show_bug.cgi?id=92425
Patch by Gavin Peters <gavinp@chromium.org> on 2012-07-27
Reviewed by Nate Chapin.
japhet suggested that the timer wasn't needed, and testing revealed that the test works without it. I've tested that if the bug is reintroduced
that it crashes, and of course it doesn't crash with the fix. So bye-bye setTimeout!
- fast/dom/HTMLLinkElement/prerender-remove-after-stop.html:
- 10:39 Changeset [123885] by
-
[BlackBerry] Switch InputHandler malloc use to fastMalloc for cases that should never fail
https://bugs.webkit.org/show_bug.cgi?id=92508
Patch by Mike Fenton <mifenton@rim.com> on 2012-07-27
Reviewed by Yong Li.
Replace common uses of malloc with fastMalloc rather
than trying to recover gracefully. If we are truly
out of memory, crash before corruption occurs.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
(BlackBerry::WebKit::InputHandler::extractedTextRequest):
- 10:39 Changeset [123884] by
-
WebKit should expose @title as label (AXTitle or AXDescription) sometimes instead of AXHelp, according to the ARIA text alt computation
https://bugs.webkit.org/show_bug.cgi?id=91911
Reviewed by Darin Adler.
Update comments around code to explain rationale.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::accessibilityDescription):
- 10:34 Changeset [123883] by
-
[EFL] Regression(r123858): Default navigation policy decision was switched to "reject"
https://bugs.webkit.org/show_bug.cgi?id=92507
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Kentaro Hara.
After r92466, the default navigation policy is to reject the request if the
client does not make a decision explicitly. The default policy should be
to accept. This broke ewk_view unit tests.
- ewk/ewk_view.cpp:
(ewk_view_navigation_policy_decision):
- 10:24 Changeset [123882] by
-
[EFL][WK2] Add download client for Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=91345
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.
Add download client for Ewk_Context so that
information about downloads can be reported
to the client application via Ewk_View signals.
The client application needs to listen for
"download,request" signal on the view and set
the download path for the download in the
callback in order to accept it. If the signal
is ignored or if the download path is not set
the download will fail.
A new Ewk_Download_Job type is introduced to provide
information relative to a download to the client
and to allow the client to interact with it (e.g.
set its download path, cancel it, ...).
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::handleDownloadRequest):
(WebKit):
- UIProcess/API/efl/PageClientImpl.h:
(PageClientImpl):
- UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(_Ewk_Context::~_Ewk_Context):
(ewk_context_download_job_add):
(ewk_context_download_job_get):
(ewk_context_download_job_remove):
- UIProcess/API/efl/ewk_context_download_client.cpp: Added.
(toEwkContext):
(decideDestinationWithSuggestedFilename):
(didReceiveResponse):
(didCreateDestination):
(didReceiveData):
(didFail):
(didCancel):
(didFinish):
(ewk_context_download_client_attach):
- UIProcess/API/efl/ewk_context_download_client_private.h: Added.
- UIProcess/API/efl/ewk_context_private.h:
- UIProcess/API/efl/ewk_download_job.cpp: Added.
(_Ewk_Download_Job):
(_Ewk_Download_Job::_Ewk_Download_Job):
(_Ewk_Download_Job::~_Ewk_Download_Job):
(ewk_download_job_ref):
(ewk_download_job_unref):
(ewk_download_job_id_get):
(ewk_download_job_view_get):
(ewk_download_job_state_get):
(ewk_download_job_request_get):
(ewk_download_job_response_get):
(ewk_download_job_destination_get):
(ewk_download_job_destination_set):
(ewk_download_job_suggested_filename_get):
(ewk_download_job_cancel):
(ewk_download_job_estimated_progress_get):
(ewk_download_job_elapsed_time_get):
(ewk_download_job_response_set):
(ewk_download_job_suggested_filename_set):
(ewk_download_job_received_data):
(ewk_download_job_state_set):
(ewk_download_job_new):
- UIProcess/API/efl/ewk_download_job.h: Added.
- UIProcess/API/efl/ewk_download_job_private.h: Added.
(WebKit):
- UIProcess/API/efl/ewk_url_response.cpp:
(ewk_url_response_content_length_get): Add a function to
retrieve the content length of a URL response.
- UIProcess/API/efl/ewk_url_response.h:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_download_job_cancelled):
(ewk_view_download_job_requested):
(ewk_view_download_job_failed):
(ewk_view_download_job_finished):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_view_private.h:
- UIProcess/API/efl/tests/resources/test.pdf: Added.
- UIProcess/API/efl/tests/test_ewk2_download_job.cpp: Added. This tests
the download functionality.
(DownloadTestData):
(fileExists):
(serverCallback):
(on_download_requested):
(on_download_cancelled):
(on_download_failed):
(on_download_finished):
(TEST_F):
- UIProcess/PageClient.h:
(PageClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit):
(WebKit::WebPageProxy::handleDownloadRequest):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- 10:19 Changeset [123881] by
-
Add runtime flag to enable/disable JS memory information
https://bugs.webkit.org/show_bug.cgi?id=92479
Patch by Zoltan Horvath <zoltan@webkit.org> on 2012-07-27
Reviewed by Simon Hausmann.
We need console.memory JS object to be accessible because of the memory consumption
measurements of the performance tests, so I added a toggle to InternalSettings.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setMemoryInfoEnabled):
(WebCore):
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl:
- 10:17 Changeset [123880] by
-
Microdata: Remove toJs() and toV8Object() custom methods from JSHTMLElementCustom.cpp and V8HTMLElementCustom.cpp respectively.
https://bugs.webkit.org/show_bug.cgi?id=92482
Patch by Arko Saha <arko@motorola.com> on 2012-07-27
Reviewed by Kentaro Hara.
Removed custom methods toJS() and toV8Object(). We should use toJS() method defined in
JSMicroDataItemValueCustom.cpp and toV8() method defined in V8MicroDataItemValueCustom.cpp
in place of custom toJs() and toV8Object().
Existing tests :
fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html
fast/dom/MicroData/itemvalue-reflects-href-attr.html
fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html
fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html
fast/dom/MicroData/itemvalue-reflects-the-src-attr.html
fast/dom/MicroData/itemvalue-returns-element-itself.html
fast/dom/MicroData/itemvalue-returns-null.html
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html
fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html
- bindings/js/JSHTMLElementCustom.cpp:
(WebCore):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore):
(WebCore::V8HTMLElement::itemValueAccessorGetter):
- 10:14 Changeset [123879] by
-
Source/WebKit: [EFL] WebKit API unit tests needs a timeout
https://bugs.webkit.org/show_bug.cgi?id=92496
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-27
Reviewed by Antonio Gomes.
Added the same timeout value that we have for WebKit2.
- PlatformEfl.cmake:
Source/WTF: Support a rational time class for use by media elements.
https://bugs.webkit.org/show_bug.cgi?id=88787
Patch by Jer Noble <jer.noble@apple.com> on 2012-07-27
Reviewed by Eric Carlson.
Add a new MediaTime class which implements rational math operations.
Add common constructors and assignment operators:
- wtf/MediaTime.cpp: Added.
(WTF::MediaTime::MediaTime):
(WTF::MediaTime::~MediaTime):
(WTF::MediaTime::operator=):
Add common math operators:
- wtf/MediaTime.cpp:
(WTF::MediaTime::operator+):
(WTF::MediaTime::operator-):
(WTF::MediaTime::operator<):
(WTF::MediaTime::operator>):
(WTF::MediaTime::operator==):
(WTF::MediaTime::operator>=):
(WTF::MediaTime::operator<=):
Add functions to check the MeiaTime time type flags:
- wtf/MediaTime.h:
(WTF::MediaTime::isValid):
(WTF::MediaTime::isInvalid):
(WTF::MediaTime::hasBeenRounde):
(WTF::MediaTime::isPositiveInfinite):
(WTF::MediaTime::isNegativeInfinite):
(WTF::MediaTime::isIndefinite):
Add constants for commonly used MediaTime values:
(WTF::MediaTime::zeroTime):
(WTF::MediaTime::invalidTime):
(WTF::MediaTime::positiveInfiniteTime):
(WTF::MediaTime::negativeInfiniteTime):
(WTF::MediaTime::indefiniteTime):
Add explicit conversion functions to convert to and from floating point values.
- wtf/MediaTime.cpp:
(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
(WTF::MediaTime::toFloat):
(WTF::MediaTime::toDouble):
Add some useful exported functions:
- wtf/MediaTime.cpp:
(WTF::MediaTime::compare): Master function for the comparison operators above.
(WTF::MediaTime::setTimeScale): Rescale the time value to a new time scale.
(WTF::abs): Return an absolute value for the current MediaTime.
Static utility functions to implement the above:
- wtf/MediaTime.cpp:
(WTF::greatestCommonDivisor):
(WTF::leastCommonMultiple):
(WTF::signum):
Windows-only implementations of isinf and signbit:
- wtf/MediaTime.cpp:
(std::isinf):
(std::signbit):
Add the new class to platform build files:
- GNUmakefile.list.am:
- WTF.gypi:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.xcodeproj/project.pbxproj:
- 09:31 Changeset [123878] by
-
Support a rational time class for use by media elements.
https://bugs.webkit.org/show_bug.cgi?id=88787
Source/JavaScriptCore:
Re-export WTF::MediaTime from JavaScriptCore.
Reviewed by Eric Carlson.
- JavaScriptCore.order:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Source/WTF:
Reviewed by Eric Carlson.
Add a new MediaTime class which implements rational math operations.
Add common constructors and assignment operators:
- wtf/MediaTime.cpp: Added.
(WTF::MediaTime::MediaTime):
(WTF::MediaTime::~MediaTime):
(WTF::MediaTime::operator=):
Add common math operators:
- wtf/MediaTime.cpp:
(WTF::MediaTime::operator+):
(WTF::MediaTime::operator-):
(WTF::MediaTime::operator<):
(WTF::MediaTime::operator>):
(WTF::MediaTime::operator==):
(WTF::MediaTime::operator>=):
(WTF::MediaTime::operator<=):
Add functions to check the MeiaTime time type flags:
- wtf/MediaTime.h:
(WTF::MediaTime::isValid):
(WTF::MediaTime::isInvalid):
(WTF::MediaTime::hasBeenRounde):
(WTF::MediaTime::isPositiveInfinite):
(WTF::MediaTime::isNegativeInfinite):
(WTF::MediaTime::isIndefinite):
Add constants for commonly used MediaTime values:
(WTF::MediaTime::zeroTime):
(WTF::MediaTime::invalidTime):
(WTF::MediaTime::positiveInfiniteTime):
(WTF::MediaTime::negativeInfiniteTime):
(WTF::MediaTime::indefiniteTime):
Add explicit conversion functions to convert to and from floating point values.
- wtf/MediaTime.cpp:
(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
(WTF::MediaTime::toFloat):
(WTF::MediaTime::toDouble):
Add some useful exported functions:
- wtf/MediaTime.cpp:
(WTF::MediaTime::compare): Master function for the comparison operators above.
(WTF::MediaTime::setTimeScale): Rescale the time value to a new time scale.
(WTF::abs): Return an absolute value for the current MediaTime.
Static utility functions to implement the above:
- wtf/MediaTime.cpp:
(WTF::greatestCommonDivisor):
(WTF::leastCommonMultiple):
(WTF::signum):
Windows-only implementations of isinf and signbit:
- wtf/MediaTime.cpp:
(std::isinf):
(std::signbit):
Add the new class to platform build files:
- GNUmakefile.list.am:
- WTF.gypi:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.xcodeproj/project.pbxproj:
Tools:
Add unit tests for the WTF::MediaTime class.
Reviewed by Eric Carlson.
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/TestWebKitAPI.gypi:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/MediaTime.cpp: Added.
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
(WTF::operator<<):
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- 09:22 Changeset [123877] by
-
[NRWT] should have a way to restrict pixel tests for individual directories
https://bugs.webkit.org/show_bug.cgi?id=91754
Unreviewed attempt to fix the chaos I introduced.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::processLine):
- 07:15 Changeset [123876] by
-
[Qt][WK2] Gardening after r123786. It made 5 fast/animation tests fail
https://bugs.webkit.org/show_bug.cgi?id=92490
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-27
Rubber stamped by Zoltan Herczeg.
- platform/qt-5.0-wk2/Skipped:
- 07:14 Changeset [123875] by
-
set WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED for chromium android
https://bugs.webkit.org/show_bug.cgi?id=91746
Patch by Wei James <james.wei@intel.com> on 2012-07-27
Reviewed by Adam Barth.
This patch is part of efforts to enable web audio for chromium android.
Web audio component needs to use atomicIncrement and atomicDecrement,
which are enabled by this MACRO.
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=89428#c19, make
this patch standalone.
- wtf/Atomics.h:
(WTF):
- 07:04 Changeset [123874] by
-
[EFL] Rebaseline after harfbuzz-ng complex font support is enabled
https://bugs.webkit.org/show_bug.cgi?id=92120
Unreviewed, EFL rebaselining.
Now that we have complex font support using harfbuzz, we need a couple of new expected results.
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-27
- platform/efl/TestExpectations:
- platform/efl/fast/dom/52776-expected.png:
- platform/efl/fast/dom/52776-expected.txt:
- platform/efl/fast/text/atsui-kerning-and-ligatures-expected.png:
- platform/efl/fast/text/atsui-kerning-and-ligatures-expected.txt:
- platform/efl/fast/text/atsui-multiple-renderers-expected.png:
- platform/efl/fast/text/atsui-multiple-renderers-expected.txt:
- platform/efl/fast/text/atsui-negative-spacing-features-expected.png:
- platform/efl/fast/text/atsui-negative-spacing-features-expected.txt:
- platform/efl/fast/text/atsui-partial-selection-expected.png:
- platform/efl/fast/text/atsui-partial-selection-expected.txt:
- platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.png:
- platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.txt:
- platform/efl/fast/text/atsui-rtl-override-selection-expected.png:
- platform/efl/fast/text/atsui-rtl-override-selection-expected.txt:
- platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.png:
- platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.txt:
- platform/efl/fast/text/atsui-spacing-features-expected.png:
- platform/efl/fast/text/atsui-spacing-features-expected.txt:
- platform/efl/fast/text/cg-vs-atsui-expected.png:
- platform/efl/fast/text/cg-vs-atsui-expected.txt:
- platform/efl/fast/text/complex-preferred-logical-widths-expected.png:
- platform/efl/fast/text/complex-preferred-logical-widths-expected.txt:
- platform/efl/fast/text/justify-ideograph-leading-expansion-expected.png:
- platform/efl/fast/text/justify-ideograph-leading-expansion-expected.txt:
- platform/efl/fast/text/midword-break-before-surrogate-pair-2-expected.png:
- platform/efl/fast/text/midword-break-before-surrogate-pair-2-expected.txt:
- platform/efl/fast/text/should-use-atsui-expected.png:
- platform/efl/fast/text/should-use-atsui-expected.txt:
- platform/efl/fast/text/stroking-decorations-expected.png:
- platform/efl/fast/text/stroking-decorations-expected.txt:
- platform/efl/fast/text/stroking-expected.png:
- platform/efl/fast/text/stroking-expected.txt:
- platform/efl/fast/text/wide-zero-width-space-expected.png:
- platform/efl/fast/text/wide-zero-width-space-expected.txt:
- platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
- platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
- platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
- platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
- platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
- platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt:
- platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
- platform/efl/transforms/2d/hindi-rotated-expected.png:
- platform/efl/transforms/2d/hindi-rotated-expected.txt:
- 06:56 Changeset [123873] by
-
REGRESSION(r123856): Breaks the build when disabling inspector
https://bugs.webkit.org/show_bug.cgi?id=92493
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-27
Reviewed by Kentaro Hara.
- bindings/js/ScriptGCEvent.h:
(WebCore):
- bindings/v8/ScriptGCEvent.h:
(WebCore):
- 06:45 Changeset [123872] by
-
[WK2][EFL] Add an ACCELERATED_COMPOSITING implementation for Efl WebKit2
https://bugs.webkit.org/show_bug.cgi?id=91581
Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-27
Reviewed by Noam Rosenthal.
Source/WebKit2:
This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
When enter accelerated compositing mode, create evas_gl, evas_gl_context, and evas_gl_surface.
- PlatformEfl.cmake:
- Shared/LayerTreeContext.h:
(LayerTreeContext):
- UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::exitAcceleratedCompositingMode):
- UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(ewk_view_size_get):
(ewk_view_create_gl_surface):
(ewk_view_enter_accelerated_compositing_mode):
(ewk_view_exit_accelerated_compositing_mode):
(_ewk_view_smart_calculate):
- UIProcess/API/efl/ewk_view_private.h:
Tools:
Add a MiniBrowser's option for selecting evas engine.
- MiniBrowser/efl/main.c:
(browserCreate):
(main):
- 06:41 Changeset [123871] by
-
Unreviewed, rolling out r123869.
http://trac.webkit.org/changeset/123869
https://bugs.webkit.org/show_bug.cgi?id=92501
"it did not fix anything but made things even worst"
(Requested by kbalazs on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-27
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):
(WebCore::DumpRenderTree::setDumpPixelsForAllTests):
(WebCore::DumpRenderTree::dump):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
- DumpRenderTree/qt/main.cpp:
(main):
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._should_fetch_expected_checksum):
(SingleTestRunner._overwrite_baselines):
(SingleTestRunner._compare_output):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker._update_test_input):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.supports_switching_pixel_tests_per_test):
(Port):
(Port._supports_switching_pixel_tests_per_test):
(Port.should_run_as_pixel_test):
(Port._should_run_as_pixel_test):
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.cmd_line):
(Driver._command_from_driver_input):
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.check_sys_deps):
(QtPort):
(QtPort._supports_switching_pixel_tests_per_test):
(QtPort._should_run_as_pixel_test):
(QtPort._default_pixel_test_directories):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.supports_switching_pixel_tests_per_test):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_pixel_test_directories):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
- WebKitTestRunner/TestController.h:
(TestController):
- 06:39 Changeset [123870] by
-
[EFL][WK2] Add API to Ewk_Cookie_Manager to watch for cookie changes
https://bugs.webkit.org/show_bug.cgi?id=92484
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Make use of soup/CookieStorageSoup.cpp for EFL port instead
of defining empty implementations for cookie storage
functions.
No new tests, no behavior change.
- PlatformEfl.cmake:
- platform/efl/TemporaryLinkStubs.cpp:
Source/WebKit2:
Add API tp Ewk_Cookie_Manager so that the client can watch
for cookie changes.
- UIProcess/API/efl/ewk_cookie_manager.cpp:
- UIProcess/API/efl/ewk_cookie_manager.h:
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp: Add unit tests
for cookie changes watching.
- 06:11 Changeset [123869] by
-
[NRWT] should have a way to restrict pixel tests for individual directories
https://bugs.webkit.org/show_bug.cgi?id=91754
Reviewed by Zoltan Herczeg.
Rollout r123729 because it made Qt debug bots crasy.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):
(WebCore::DumpRenderTree::setDumpPixels):
(WebCore::DumpRenderTree::dump):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
- DumpRenderTree/qt/main.cpp:
(main):
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._should_fetch_expected_checksum):
(SingleTestRunner._overwrite_baselines):
(SingleTestRunner._compare_output):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker._update_test_input):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.lookup_virtual_test_args):
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.cmd_line):
(Driver._command_from_driver_input):
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.check_sys_deps):
- Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.virtual_test_suites):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_missing_and_unexpected_results):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
- WebKitTestRunner/TestController.h:
(TestController):
- 05:51 Changeset [123868] by
-
[Qt] Gardening after r123786. It made 3 fast/animation tests fail
https://bugs.webkit.org/show_bug.cgi?id=92490
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-27
Rubber stamped by Zoltan Herczeg.
- platform/qt/Skipped:
- 05:27 Changeset [123867] by
-
Replace ColorChooserClient::elementRectRelativeToWindow with elementRectRelativeToRootView
https://bugs.webkit.org/show_bug.cgi?id=92488
Reviewed by Kent Tamura.
Changing ColorChooserClient interface to return element rectangle that is relative to root view instead of window.
No new tests. Method is not used yet.
- html/ColorInputType.cpp:
(WebCore::ColorInputType::elementRectRelativeToRootView): Replaced elementRectRelativeToWindow. Returns element rectangle relative to root view.
- html/ColorInputType.h:
(ColorInputType):
- platform/ColorChooserClient.h:
(ColorChooserClient):
- 05:25 EFLWebKit edited by
- ragel (diff)
- 04:52 Changeset [123866] by
-
[EFL][WK2] Stop using C API to interact with the page in Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=92463
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Simon Hausmann.
Stop using C API to interact with the PageProxy in Ewk_View
and use the PageProxy object directly. This avoids useless
converting to WK type using toAPI() all the time.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
(ewk_view_uri_update):
(ewk_view_uri_set):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_load_progress_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_theme_get):
(ewk_view_cursor_set):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
- 04:42 Changeset [123865] by
-
webkit.review.bot should run clean-review-queue and clean-pending-commit periodically
https://bugs.webkit.org/show_bug.cgi?id=92472
Reviewed by Eric Seidel.
We need to run these command periodically to keep cruft from
accumulating in bugs.webkit.org. Rather than running them manually, we
should just have a bot run them. This patch has the style-queue run the
commands, which admittedly is a bit odd but it doesn't seem worthwhile
to create another bot specifically for this purposes.
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractReviewQueue):
(StyleQueue.begin_work_queue):
(StyleQueue):
(StyleQueue.clean_bugzilla):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(StyleQueueTest.test_style_queue_with_style_exception):
(test_style_queue_with_watch_list_exception):
- 04:32 Changeset [123864] by
-
[Cairo] Add complex font drawing using HarfbuzzNG
https://bugs.webkit.org/show_bug.cgi?id=91864
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-27
Reviewed by Simon Hausmann and Martin Robinson.
.:
Configuring Freetype backend to use HarfBuzz by default.
- Source/cmake/FindHarfBuzz.cmake: Added pkgconfig based discovery of HarfBuzz.
- Source/cmake/OptionsEfl.cmake: Adding Harfbuzz configuration.
Source/WebCore:
Adding Harfbuzz support to EFL by implementing it with the help of cairo and cairo-ft.
Reusing Chromium's Harfbuzz-NG support.
No new tests, complex font support is covered by existing tests.
- CMakeLists.txt: Adding new cairo based implementations, removing emtpy FontEfl.cpp
- WebCore.gypi: Removing FontEfl.cpp
- platform/graphics/cairo/FontCairoHarfbuzzNG.cpp: Added. New implementation that implements cairo & harfbuzz-ng based complex font drawing.
(WebCore):
(WebCore::Font::drawComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::canExpandAroundIdeographsInComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
- platform/graphics/efl/FontEfl.cpp: Removed.
- platform/graphics/freetype/FontPlatformData.h: Adding a getter that retrieves a harfbuzz face.
(FontPlatformData):
- platform/graphics/freetype/FontPlatformDataFreeType.cpp: Adding a getter that retrieves a harfbuzz face.
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore):
(WebCore::FontPlatformData::harfbuzzFace):
- platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCairo.cpp: Added. Cairo-freetype based approach to get complex font metrics.
(WebCore):
(CairoFtFaceLocker):
(WebCore::CairoFtFaceLocker::CairoFtFaceLocker):
(WebCore::CairoFtFaceLocker::lock):
(WebCore::CairoFtFaceLocker::~CairoFtFaceLocker):
(WebCore::floatToHarfBuzzPosition):
(WebCore::doubleToHarfBuzzPosition):
(WebCore::CairoGetGlyphWidthAndExtents):
(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzCairoTextGetFontFuncs):
(WebCore::harfbuzzCairoGetTable):
(WebCore::HarfBuzzNGFace::createFace):
(WebCore::HarfBuzzNGFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
Source/WebKit:
Adding includes for harfbuzz folders.
- CMakeLists.txt:
Source/WebKit2:
Adding includes for harfbuzz folders.
- CMakeLists.txt:
Tools:
Bringing Harfbuzz support to EFL with this patch, so we need HarfBuzz in the pulled in jhbuild dependencies.
- WebKitTestRunner/CMakeLists.txt: Adding additional header include directories.
- efl/jhbuild.modules: Adding source for HarfBuzz release version 0.9.0.
- 04:12 Changeset [123863] by
-
[EFL][WK2] Add more Ewk_View unit tests
https://bugs.webkit.org/show_bug.cgi?id=92407
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-27
Reviewed by Kenneth Rohde Christiansen.
Add more unit tests for WebKit2 Ewk_View API.
In particular, navigation, HTML loading and
device pixel ratio functions are now tested.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp): Call ewk_init() instead
of duplicating initialization code.
(EWK2UnitTest::EWK2UnitTestBase::TearDown): call ewk_shutdown().
(TitleChangedData):
(EWK2UnitTest):
(EWK2UnitTest::onTitleChanged):
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTitleChangedTo): Add convenience
method to wait until the view main frame title changes to a given value.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
(EWK2UnitTestBase):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
(serverCallbackNavigation):
- 04:09 Changeset [123862] by
-
[Qt] platform/qt/editing/pasteboard tests needs update after font change.
https://bugs.webkit.org/show_bug.cgi?id=91399.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-27
Reviewed by Csaba Osztrogonác.
- platform/qt-5.0-wk1/Skipped:
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0-wk2/editing/pasteboard/4806874-expected.txt: Added.
- platform/qt-5.0-wk2/editing/pasteboard/4944770-1-expected.png: Removed.
- platform/qt-5.0-wk2/editing/pasteboard/4944770-1-expected.txt: Removed.
- platform/qt-5.0-wk2/editing/pasteboard/4944770-2-expected.png: Removed.
- platform/qt-5.0-wk2/editing/pasteboard/4944770-2-expected.txt: Removed.
- platform/qt-5.0-wk2/editing/pasteboard/input-field-1-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/input-field-1-expected.txt.
- platform/qt-5.0/Skipped:
- platform/qt-5.0/editing/pasteboard/4944770-1-expected.png: Removed.
- platform/qt-5.0/editing/pasteboard/4944770-1-expected.txt: Removed.
- platform/qt-5.0/editing/pasteboard/4944770-2-expected.png: Removed.
- platform/qt-5.0/editing/pasteboard/4944770-2-expected.txt: Removed.
- platform/qt-5.0/editing/pasteboard/paste-text-at-tabspan-003-expected.txt: Removed.
- platform/qt/editing/pasteboard/3976872-expected.png: Added.
- platform/qt/editing/pasteboard/3976872-expected.txt:
- platform/qt/editing/pasteboard/4076267-2-expected.png:
- platform/qt/editing/pasteboard/4076267-2-expected.txt:
- platform/qt/editing/pasteboard/4076267-3-expected.png:
- platform/qt/editing/pasteboard/4076267-3-expected.txt:
- platform/qt/editing/pasteboard/4076267-expected.png:
- platform/qt/editing/pasteboard/4076267-expected.txt:
- platform/qt/editing/pasteboard/4242293-expected.png: Added.
- platform/qt/editing/pasteboard/4242293-expected.txt:
- platform/qt/editing/pasteboard/4631972-expected.png: Added.
- platform/qt/editing/pasteboard/4631972-expected.txt:
- platform/qt/editing/pasteboard/4641033-expected.png:
- platform/qt/editing/pasteboard/4641033-expected.txt:
- platform/qt/editing/pasteboard/4806874-expected.png:
- platform/qt/editing/pasteboard/4806874-expected.txt:
- platform/qt/editing/pasteboard/4944770-1-expected.png:
- platform/qt/editing/pasteboard/4944770-1-expected.txt:
- platform/qt/editing/pasteboard/4944770-2-expected.png:
- platform/qt/editing/pasteboard/4944770-2-expected.txt:
- platform/qt/editing/pasteboard/4989774-expected.png: Added.
- platform/qt/editing/pasteboard/4989774-expected.txt:
- platform/qt/editing/pasteboard/5006779-expected.png: Added.
- platform/qt/editing/pasteboard/5006779-expected.txt:
- platform/qt/editing/pasteboard/5028447-expected.png: Added.
- platform/qt/editing/pasteboard/5028447-expected.txt:
- platform/qt/editing/pasteboard/5032095-expected.png: Added.
- platform/qt/editing/pasteboard/5032095-expected.txt:
- platform/qt/editing/pasteboard/5071074-2-expected.png: Added.
- platform/qt/editing/pasteboard/5071074-2-expected.txt:
- platform/qt/editing/pasteboard/5071074-expected.png: Added.
- platform/qt/editing/pasteboard/5071074-expected.txt:
- platform/qt/editing/pasteboard/5075944-expected.png: Added.
- platform/qt/editing/pasteboard/5075944-expected.txt:
- platform/qt/editing/pasteboard/5134759-expected.png: Added.
- platform/qt/editing/pasteboard/5134759-expected.txt:
- platform/qt/editing/pasteboard/5156401-1-expected.png: Added.
- platform/qt/editing/pasteboard/5156401-1-expected.txt:
- platform/qt/editing/pasteboard/5247341-expected.png: Added.
- platform/qt/editing/pasteboard/5247341-expected.txt:
- platform/qt/editing/pasteboard/5387578-expected.png:
- platform/qt/editing/pasteboard/5387578-expected.txt:
- platform/qt/editing/pasteboard/5478250-expected.png:
- platform/qt/editing/pasteboard/5478250-expected.txt:
- platform/qt/editing/pasteboard/5601583-1-expected.png: Added.
- platform/qt/editing/pasteboard/5601583-1-expected.txt:
- platform/qt/editing/pasteboard/5780697-2-expected.txt:
- platform/qt/editing/pasteboard/7955-expected.png: Added.
- platform/qt/editing/pasteboard/7955-expected.txt:
- platform/qt/editing/pasteboard/8145-1-expected.png: Added.
- platform/qt/editing/pasteboard/8145-1-expected.txt:
- platform/qt/editing/pasteboard/8145-2-expected.png: Added.
- platform/qt/editing/pasteboard/8145-2-expected.txt:
- platform/qt/editing/pasteboard/8145-3-expected.png:
- platform/qt/editing/pasteboard/8145-3-expected.txt:
- platform/qt/editing/pasteboard/bad-placeholder-expected.png:
- platform/qt/editing/pasteboard/bad-placeholder-expected.txt:
- platform/qt/editing/pasteboard/block-wrappers-necessary-expected.txt:
- platform/qt/editing/pasteboard/cut-text-001-expected.png:
- platform/qt/editing/pasteboard/cut-text-001-expected.txt:
- platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.png: Added.
- platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.txt:
- platform/qt/editing/pasteboard/displaced-placeholder-expected.png: Added.
- platform/qt/editing/pasteboard/displaced-placeholder-expected.txt:
- platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
- platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
- platform/qt/editing/pasteboard/innerText-inline-table-expected.png:
- platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
- platform/qt/editing/pasteboard/input-field-1-expected.png:
- platform/qt/editing/pasteboard/input-field-1-expected.txt:
- platform/qt/editing/pasteboard/merge-after-delete-1-expected.png: Added.
- platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
- platform/qt/editing/pasteboard/merge-after-delete-2-expected.png: Added.
- platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
- platform/qt/editing/pasteboard/merge-after-delete-expected.png: Added.
- platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
- platform/qt/editing/pasteboard/merge-end-blockquote-expected.png:
- platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
- platform/qt/editing/pasteboard/merge-end-borders-expected.png:
- platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
- platform/qt/editing/pasteboard/merge-start-blockquote-expected.png: Added.
- platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
- platform/qt/editing/pasteboard/merge-start-list-expected.png: Added.
- platform/qt/editing/pasteboard/merge-start-list-expected.txt:
- platform/qt/editing/pasteboard/paste-4035648-fix-expected.png: Added.
- platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt:
- platform/qt/editing/pasteboard/paste-4038267-fix-expected.png: Added.
- platform/qt/editing/pasteboard/paste-4038267-fix-expected.txt:
- platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
- platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
- platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png: Added.
- platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-001-expected.png: Added.
- platform/qt/editing/pasteboard/paste-line-endings-001-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-002-expected.png: Added.
- platform/qt/editing/pasteboard/paste-line-endings-002-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-003-expected.png: Added.
- platform/qt/editing/pasteboard/paste-line-endings-003-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-004-expected.png: Added.
- platform/qt/editing/pasteboard/paste-line-endings-004-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-005-expected.png: Added.
- platform/qt/editing/pasteboard/paste-line-endings-005-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-006-expected.png: Added.
- platform/qt/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-007-expected.png:
- platform/qt/editing/pasteboard/paste-line-endings-007-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-008-expected.png:
- platform/qt/editing/pasteboard/paste-line-endings-008-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-009-expected.png:
- platform/qt/editing/pasteboard/paste-line-endings-009-expected.txt:
- platform/qt/editing/pasteboard/paste-line-endings-010-expected.png:
- platform/qt/editing/pasteboard/paste-line-endings-010-expected.txt:
- platform/qt/editing/pasteboard/paste-match-style-001-expected.png:
- platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/qt/editing/pasteboard/paste-match-style-002-expected.png: Added.
- platform/qt/editing/pasteboard/paste-match-style-002-expected.txt:
- platform/qt/editing/pasteboard/paste-table-003-expected.png:
- platform/qt/editing/pasteboard/paste-table-003-expected.txt:
- platform/qt/editing/pasteboard/paste-table-cells-expected.png:
- platform/qt/editing/pasteboard/paste-table-cells-expected.txt:
- platform/qt/editing/pasteboard/paste-text-004-expected.png:
- platform/qt/editing/pasteboard/paste-text-004-expected.txt:
- platform/qt/editing/pasteboard/paste-text-005-expected.png:
- platform/qt/editing/pasteboard/paste-text-005-expected.txt:
- platform/qt/editing/pasteboard/paste-text-006-expected.png: Added.
- platform/qt/editing/pasteboard/paste-text-006-expected.txt:
- platform/qt/editing/pasteboard/paste-text-007-expected.png: Added.
- platform/qt/editing/pasteboard/paste-text-007-expected.txt:
- platform/qt/editing/pasteboard/paste-text-008-expected.png:
- platform/qt/editing/pasteboard/paste-text-008-expected.txt:
- platform/qt/editing/pasteboard/paste-text-009-expected.png:
- platform/qt/editing/pasteboard/paste-text-009-expected.txt:
- platform/qt/editing/pasteboard/paste-text-013-expected.png: Added.
- platform/qt/editing/pasteboard/paste-text-013-expected.txt:
- platform/qt/editing/pasteboard/paste-text-014-expected.png:
- platform/qt/editing/pasteboard/paste-text-014-expected.txt:
- platform/qt/editing/pasteboard/paste-text-016-expected.png: Added.
- platform/qt/editing/pasteboard/paste-text-016-expected.txt:
- platform/qt/editing/pasteboard/paste-text-019-expected.png:
- platform/qt/editing/pasteboard/paste-text-019-expected.txt:
- platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
- platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/qt/editing/pasteboard/pasting-object-expected.png:
- platform/qt/editing/pasteboard/pasting-object-expected.txt:
- platform/qt/editing/pasteboard/quirks-mode-br-1-expected.png: Added.
- platform/qt/editing/pasteboard/quirks-mode-br-1-expected.txt:
- platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Added.
- platform/qt/editing/pasteboard/smart-paste-007-expected.png:
- platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
- platform/qt/editing/pasteboard/styled-element-markup-expected.png: Added.
- platform/qt/editing/pasteboard/styled-element-markup-expected.txt:
- platform/qt/editing/pasteboard/undoable-fragment-removes-expected.png: Added.
- platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt:
- platform/qt/editing/pasteboard/unrendered-br-expected.png: Added.
- platform/qt/editing/pasteboard/unrendered-br-expected.txt:
- 04:04 Changeset [123861] by
-
Unreviewed. Rolled DEPS.
- DEPS:
- 03:47 Changeset [123860] by
-
[EFL][WK2] Keyboard events miss key location data.
https://bugs.webkit.org/show_bug.cgi?id=92235
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-27
Reviewed by Simon Hausmann.
EFL WK2 did not initialize WebKeyboardEvent::m_isKeypad field.
This caused failure of fast/events/keydown-numpad-keys.html test.
- Shared/efl/WebEventFactory.cpp: WebKeyboardEvent::m_isKeypad is initialized.
(WebKit::WebEventFactory::createWebKeyboardEvent):
- 03:44 Changeset [123859] by
-
[WK2][EFL][WTR] TestNetscapePlugin is required.
https://bugs.webkit.org/show_bug.cgi?id=88756
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-07-27
Reviewed by Simon Hausmann.
libTestNetscapePlugin.so should be required for DRT/WTR/EFL.
- CMakeLists.txt:
- DumpRenderTree/TestNetscapePlugin/CMakeList.txt:
- 02:55 Changeset [123858] by
-
[EFL] Fix wrong return value in EWK_VIEW_XXX macro.
https://bugs.webkit.org/show_bug.cgi?id=92466
Reviewed by Simon Hausmann.
There are wrong return values in EWK_VIEW_XXX macros. The wrong return values
should be fixed. In addition, API description is also modified according to returned
value change.
Source/WebKit/efl:
- ewk/ewk_view.cpp:
(ewk_view_setting_minimum_timer_interval_get):
(ewk_view_navigation_policy_decision):
(ewk_view_page_rect_get):
(ewk_view_setting_enable_xss_auditor_get):
- ewk/ewk_view.h:
Source/WebKit2:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_uri_set):
(ewk_view_load_progress_get):
(ewk_view_device_pixel_ratio_get):
- UIProcess/API/efl/ewk_view.h:
- 02:41 Changeset [123857] by
-
Unreviewed GTK gardening, adding a text failure expectation for an accessibility
test that started failing after r123767.
- platform/gtk/TestExpectations:
- 02:37 Changeset [123856] by
-
Add a Setting to expose quantized, rate-limited MemoryInfo values
https://bugs.webkit.org/show_bug.cgi?id=80444
Reviewed by Eric Seidel.
We do not currently expose real MemoryInfo objects to the web unless
the user opts in because we're worried that this memory information
could be used in side-channel attacks.
We've gotten feedback from a number of web app developers that this
information is very useful in tracking the performance of their
applications. These developers use the setting in their testing labs
and regression harnesses to catch memory leaks and regressiosn early in
their development cycle.
Some of these developers have experimented with enabling this feature
within their enterprise and have found the memory data from the field
extremely useful in tracking down memory issues that slip through their
testing.
Based on this experience, they've asked whether we can enable this
functionality on a wider scale so they catch even more problems
including problems that don't manifest within their enterprise.
Because we're still worried about side-channel attacks, we don't want
to expose the raw data, so we've talked with these folks in more detail
to understand what information they find most valuable.
This patch is the result of those discussions. In particular, this
patch adds an option to expose quantized and rate-limited memory
information to web pages. Web pages can only learn new data every 20
minutes, which helps mitigate attacks where the attacker compares two
or readings to extract side-channel information. The patch also only
reports 100 distinct memory values, which (combined with the rate
limts) makes it difficult for attackers to learn about small changes in
memory use.
- page/MemoryInfo.cpp:
(WebCore):
(HeapSizeCache):
(WebCore::HeapSizeCache::HeapSizeCache):
(WebCore::HeapSizeCache::getCachedHeapSize):
(WebCore::HeapSizeCache::maybeUpdate):
(WebCore::HeapSizeCache::update):
(WebCore::HeapSizeCache::quantize):
(WebCore::MemoryInfo::MemoryInfo):
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setQuantizedMemoryInfoEnabled):
(WebCore::Settings::quantizedMemoryInfoEnabled):
(Settings):
- 02:36 Changeset [123855] by
-
[chromium] Fix issues in visiblePositionForWindowPoint (offscreen points / iframes).
https://bugs.webkit.org/show_bug.cgi?id=79117
Fix two issues in WebFrameImpl::visiblePositionForWindowPoint.
1) If the point is off-screen, the visiblePosition is clipped to the screen.
- The fix is to add HitTestRequest::IgnoreClipping.
2) The result is incorrect if the point is within an iframe.
- This is because we are calling convertFromContainingWindow twice: once in windowToContents, and then explicitly as well.
- This patch removes the explicit call to convertFromContainingWindow.
Patch by Oli Lan <olilan@chromium.org> on 2012-07-27
Reviewed by Adam Barth.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::visiblePositionForWindowPoint):
- 02:32 Changeset [123854] by
-
Unreviewed. Rolled DEPS.
- DEPS:
- 02:26 Changeset [123853] by
-
Source/WebCore: Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=92373
Reviewed by Pavel Feldman.
Moved formatting support from JavaScriptSource to UISourceCode.
Extracted Formatter interface from ScriptFormatter and created IdentityFormatter
implememntation and Formatter.createFormatter(contentType) formatter factory.
Introduced virtual formattedChanged() method on UISourceCode.
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector.JavaScriptSource.prototype.searchInContent):
(WebInspector.JavaScriptSource.prototype.formattedChanged):
- inspector/front-end/ScriptFormatter.js:
(WebInspector.Formatter):
(WebInspector.Formatter.createFormatter):
(WebInspector.Formatter.locationToPosition):
(WebInspector.Formatter.positionToLocation):
(WebInspector.Formatter.prototype.formatContent):
(WebInspector.ScriptFormatter):
(WebInspector.IdentityFormatter):
(WebInspector.IdentityFormatter.prototype.formatContent):
(WebInspector.FormatterSourceMappingImpl.prototype.originalToFormatted):
(WebInspector.FormatterSourceMappingImpl.prototype.formattedToOriginal):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._fireContentAvailable):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.overrideLocation):
(WebInspector.UISourceCode.prototype.togglingFormatter):
(WebInspector.UISourceCode.prototype.formatted):
(WebInspector.UISourceCode.prototype.setFormatted.if):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent.formattedChanged):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent):
(WebInspector.UISourceCode.prototype.setFormatted):
(WebInspector.UISourceCode.prototype.createFormatter):
(WebInspector.UISourceCode.prototype.formattedChanged):
Source/WebKit2: [EFL][WK2] Add unit tests for Ewk_View form client
https://bugs.webkit.org/show_bug.cgi?id=92468
Reviewed by Simon Hausmann.
Add unit test for form client functionality in
Ewk_View.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(onFormAboutToBeSubmitted):
(TEST_F):
LayoutTests: Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=92373
Reviewed by Pavel Feldman.
- inspector/debugger/script-formatter.html:
- 01:50 Changeset [123852] by
-
Web Inspector: Move formatting support from JavaScriptSource to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=92373
Reviewed by Pavel Feldman.
Source/WebCore:
Moved formatting support from JavaScriptSource to UISourceCode.
Extracted Formatter interface from ScriptFormatter and created IdentityFormatter
implememntation and Formatter.createFormatter(contentType) formatter factory.
Introduced virtual formattedChanged() method on UISourceCode.
- inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector.JavaScriptSource.prototype.searchInContent):
(WebInspector.JavaScriptSource.prototype.formattedChanged):
- inspector/front-end/ScriptFormatter.js:
(WebInspector.Formatter):
(WebInspector.Formatter.createFormatter):
(WebInspector.Formatter.locationToPosition):
(WebInspector.Formatter.positionToLocation):
(WebInspector.Formatter.prototype.formatContent):
(WebInspector.ScriptFormatter):
(WebInspector.IdentityFormatter):
(WebInspector.IdentityFormatter.prototype.formatContent):
(WebInspector.FormatterSourceMappingImpl.prototype.originalToFormatted):
(WebInspector.FormatterSourceMappingImpl.prototype.formattedToOriginal):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._fireContentAvailable):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.overrideLocation):
(WebInspector.UISourceCode.prototype.togglingFormatter):
(WebInspector.UISourceCode.prototype.formatted):
(WebInspector.UISourceCode.prototype.setFormatted.if):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent.formattedChanged):
(WebInspector.UISourceCode.prototype.setFormatted.didGetContent):
(WebInspector.UISourceCode.prototype.setFormatted):
(WebInspector.UISourceCode.prototype.createFormatter):
(WebInspector.UISourceCode.prototype.formattedChanged):
LayoutTests:
- inspector/debugger/script-formatter.html:
- 01:41 Changeset [123851] by
-
[EFL] Memory leaks in EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=92347
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-27
Reviewed by Simon Hausmann.
Fix a memory leak in EFL's DRT code by adopting an allocation
of JSString created with JSStringCreateWithUTF8CString.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWindowObjectCleared):
- 01:34 Changeset [123850] by
-
Page object should ascertain EditorClient to be non-null
https://bugs.webkit.org/show_bug.cgi?id=92458
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-27
Reviewed by Ryosuke Niwa.
The EditorClient should always be available in Page object. Added the assertion to ascertain this.
No new tests. Added assertion to make sure EditorClient always exist.
- page/Page.cpp:
(WebCore::Page::Page):
- 01:28 Changeset [123849] by
-
[Qt] Unreviewed, rebaseline for tests introduced in r123790
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-27
Rubber stamped by Zoltan Herczeg.
- platform/qt/css3/filters/effect-brightness-clamping-expected.png: Added.
- platform/qt/css3/filters/effect-brightness-clamping-expected.txt: Added.
- platform/qt/css3/filters/effect-brightness-clamping-hw-expected.png: Added.
- platform/qt/css3/filters/effect-brightness-clamping-hw-expected.txt: Added.
- 01:25 Changeset [123848] by
-
Gather the duplicated timer code into CachedResource.
https://bugs.webkit.org/show_bug.cgi?id=92332
Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-27
Reviewed by Nate Chapin.
Internal review by Jae Hyun Park.
When all clients are removed, CachedImage, CachedScript and CachedCSSStyleSheet
start the timer to destroy decoded data. Those three classes have their own
timer.
Changed CachedCSSStyleSheet::didAddClient to call super class method in order to
stop the timer. This change does not have any side effect because
CachedResource::didAddClient only stops the timer in this case.
No new tests - no new testable functionality.
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
- loader/cache/CachedCSSStyleSheet.h:
(CachedCSSStyleSheet):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage):
(WebCore::CachedImage::didAddClient):
(WebCore::CachedImage::allClientsRemoved):
- loader/cache/CachedImage.h:
(CachedImage):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore):
(WebCore::CachedResource::decodedDataDeletionTimerFired):
- loader/cache/CachedResource.h:
(CachedResource):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::CachedScript):
- loader/cache/CachedScript.h:
(CachedScript):
- 00:56 Changeset [123847] by
-
[EFL] Change prototype of run_open_panel
https://bugs.webkit.org/show_bug.cgi?id=91956
Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-27
Reviewed by Kentaro Hara.
In order to support all of the file chooser attributes,
change the types of parameters in run_open_panel method.
i.e., change "Eina_Bool allows_multiple_files, Eina_List *accept_types"
to "Ewk_File_Chooser *file_chooser"
In addition, Efl can support the capture attribute for HTML media capture.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::runOpenPanel):
- ewk/ewk_view.cpp:
(ewk_view_run_open_panel):
- ewk/ewk_view.h:
- ewk/ewk_view_private.h:
- 00:51 Changeset [123846] by
-
Writing a blog post for new reviewers doesn't add value to the blog
https://bugs.webkit.org/show_bug.cgi?id=92305
Reviewed by Eric Seidel.
Now that we have Peter posting weekly updates to the blog, having an
announcement on the blog for each reviewer is more noise than signal.
- coding/commit-review-policy.html:
- 00:48 Changeset [123845] by
-
Simplify ExpectedFailures
https://bugs.webkit.org/show_bug.cgi?id=92216
Reviewed by Eric Seidel.
This patch simplifies the ExpectedFailures class we use to remember
which tests are currently failing on the bots. When we wrote this code
originally, we weren't entirely sure how it would work. Now that we
understand it more clearly, we can write the code more clearly.
- Scripts/webkitpy/tool/bot/expectedfailures.py:
(_has_failures):
(_is_trustworthy):
(ExpectedFailures.init):
(ExpectedFailures.failures_were_expected):
(ExpectedFailures.unexpected_failures_observed):
(ExpectedFailures.update):
- Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
(ExpectedFailuresTest._assert_can_trust):
(ExpectedFailuresTest.test_failures_were_expected):
(ExpectedFailuresTest.test_unexpected_failures_observed):
(ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._test):
(PatchAnalysisTask._build_and_test_without_patch):
(PatchAnalysisTask._test_patch):
- 00:44 Changeset [123844] by
-
[chromium] Don't add a HUD layer when there is no rootLayer
https://bugs.webkit.org/show_bug.cgi?id=92442
Reviewed by Adrienne Walker.
When the compositor is shutting down in threaded mode, it does a commit
without a root layer. We should not try stick the hud layer onto the
null root layer.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::willCommit):
- 00:30 Changeset [123843] by
-
IndexedDB: inject index keys on cursor/objectstore/index get success handlers
https://bugs.webkit.org/show_bug.cgi?id=91123
Patch by Alec Flett <alecflett@chromium.org> on 2012-07-27
Reviewed by Tony Chang.
Source/WebCore:
Move key-injection into the frontend, by injecting the key into
the value on get rather than set for autoincremented keys. This
gives a potential performance win by avoiding an IPC call to the
V8 utility process on chromium, and generally cleans up the key
management.
Note that this duplicates the logic of generateIndexKeys into the
frontend until that method can be expunged from the backend. This
will be cleaned up in a later patch.
In order to account for both old data (which has the duplicate
primary key already injected and serialized) and any new data, an
assertion was removed from IDBBindingUtilities.
This also includes some minor refactoring such as the deprecation
of IDBCursorBackendInterface::update in favor of a direct call to
IDBObjectStoreBackendImpl::put, and removal of the now-defunct
IDBBackingStore::getObjectViaIndex.
Tests: storage/indexdb/index-duplicate-keypaths.html
- Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::setValueReady):
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::update):
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::getInternal):
- Modules/indexeddb/IDBLevelDBBackingStore.cpp:
- Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::generateIndexKeysForValue):
(WebCore):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
- Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore):
Source/WebKit/chromium:
Remove method no longer used.
- tests/IDBFakeBackingStore.h:
LayoutTests:
One new test to make sure that indexes with the same keypath as an
autoIncrement'ed objectStore still index their values. Also minor
tweaks to tests to make it easier to figure out which key is being
updated.
- storage/indexeddb/index-duplicate-keypaths-expected.txt: Added.
- storage/indexeddb/index-duplicate-keypaths.html: Added.
- storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
- storage/indexeddb/mozilla/resources/autoincrement-indexes.js:
- storage/indexeddb/resources/index-duplicate-keypaths.js: Added.
- 00:27 Changeset [123842] by
-
changing -webkit-order should change the paint order of flex items
https://bugs.webkit.org/show_bug.cgi?id=92041
Reviewed by Ojan Vafai.
Source/WebCore:
Override paintChildren and use the flex order iterator to determine the order to paint the children.
Test: css3/flexbox/order-painting.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Save a reference to the order iterator.
(WebCore::RenderFlexibleBox::paintChildren):
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox): Hold a reference to the order iterator so we don't have to recreate it at paint time.
Also mark all the virtual methods with OVERRIDE.
LayoutTests:
Use a ref test since this is testing paint behavior.
- css3/flexbox/order-painting-expected.html: Added.
- css3/flexbox/order-painting.html: Added.
- 00:10 Changeset [123841] by
-
[Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
https://bugs.webkit.org/show_bug.cgi?id=88064
Reviewed by Zoltan Herczeg.
Source/WebKit/qt:
Add missing DumpRenderTreeSupportQt::resetInternalsObject(JSContextRef context) function.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetInternalsObject):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
Use resetInternalsObject() instead of injectInternalsObject().
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::resetAfterTest):
LayoutTests:
- platform/qt-5.0-wk2/Skipped: Unskip now passing tests.