Timeline



Sep 4, 2012:

11:35 PM Changeset in webkit [127558] by keishi@webkit.org
  • 11 edits
    3 copies
    1 add in trunk/Source

Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=95681

Reviewed by Kent Tamura.

Source/WebCore:

We are moving calendar picker PagePopupClient to WebKit layer so ports
can use their platform native chooser UI if they have one.
DateTimeChooser, DateTimeChooserClient etc. will be reused when we
implement the week picker and month picker.

No new tests. No behavior change. Covered by existing calendar picker tests.

  • WebCore.gypi:
  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::CalendarPickerElement):
(WebCore::CalendarPickerElement::~CalendarPickerElement):
(WebCore::CalendarPickerElement::didChooseValue): Called when user chose a value.
(WebCore):
(WebCore::CalendarPickerElement::didEndChooser): Called when chooser has ended.
(WebCore::CalendarPickerElement::openPopup):
(WebCore::CalendarPickerElement::closePopup):

  • html/shadow/CalendarPickerElement.h:

(CalendarPickerElement):

  • loader/EmptyClients.cpp:

(WebCore):
(WebCore::EmptyChromeClient::openDateTimeChooser):

  • loader/EmptyClients.h:

(EmptyChromeClient):

  • page/ChromeClient.h:

(WebCore):
(ChromeClient):

  • platform/DateTimeChooser.h:

(WebCore):
(DateTimeChooserParameters): Contains information needed to open the DateTimeChooser.
(DateTimeChooser):
(WebCore::DateTimeChooser::~DateTimeChooser):

  • platform/DateTimeChooserClient.h:

(WebCore):
(DateTimeChooserClient):
(WebCore::DateTimeChooserClient::~DateTimeChooserClient):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/ChromeClientImpl.cpp:

(WebKit):
(WebKit::ChromeClientImpl::openDateTimeChooser):

  • src/ChromeClientImpl.h:

(WebCore):
(ChromeClientImpl):

  • src/DateTimeChooserImpl.cpp: Added.

(WebKit):
(WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::~DateTimeChooserImpl):
(WebKit::DateTimeChooserImpl::endChooser):
(WebKit::DateTimeChooserImpl::contentSize):
(WebKit::DateTimeChooserImpl::writeDocument):
(WebKit::DateTimeChooserImpl::setValueAndClosePopup):
(WebKit::DateTimeChooserImpl::didClosePopup):

  • src/DateTimeChooserImpl.h:

(WebCore):
(WebKit):
(DateTimeChooserImpl):

11:28 PM Changeset in webkit [127557] by mikelawther@chromium.org
  • 3 edits
    2 adds in trunk

CSS3 calc: expressions with 'em' units do not zoom correctly.
https://bugs.webkit.org/show_bug.cgi?id=95705

Reviewed by Ojan Vafai.

Source/WebCore:

Each primitive value in a CSS calc expression now has (zoom) multiplier and scale factor applied
independently. Previously the multiplier and a single scale factor was applied to the expression
as a whole, but this failed to account for expressions involving font relative units. This is
because the multiplier should not be applied to font relative units.

Test: css3/calc/zoom-with-em.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLengthDouble):

LayoutTests:

  • css3/calc/zoom-with-em-expected.txt: Added.
  • css3/calc/zoom-with-em.html: Added.
11:07 PM Changeset in webkit [127556] by commit-queue@webkit.org
  • 13 edits in trunk/Source

[chromium] Prevent compositor ticking if it can't draw
https://bugs.webkit.org/show_bug.cgi?id=95399

Patch by Brian Anderson <brianderson@chromium.org> on 2012-09-04
Reviewed by James Robinson.

Background extensions had an always ticking compositor even though
they couldn't draw. This patch disables the ticks when canDraw is false
and adds a notification mechanism for when canDraw changes states so
we can recover properly.

Tests updated for new interfaces.
Regression test added to make sure ticking stops when canDraw is false.
notifyIfCanDrawChanged test added to make sure notifications are sent
for any changes that might affect canDraw.

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::notifyIfCanDrawChanged):
(WebCore):
(WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::initializeRenderer):
(WebCore::CCLayerTreeHostImpl::setViewportSize):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImplClient):
(WebCore::CCLayerTreeHostImpl::resetContentsTexturesPurged):
(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setCanDraw):
(WebCore):
(WebCore::CCScheduler::processScheduledActions):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:

(WebCore::CCSchedulerStateMachine::toString):
(WebCore):
(WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):

  • platform/graphics/chromium/cc/CCSchedulerStateMachine.h:

(CCSchedulerStateMachine):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:
  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::onCanDrawStateChanged):
(WebCore):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

  • platform/graphics/chromium/cc/CCThreadProxy.h:
10:33 PM Changeset in webkit [127555] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp
https://bugs.webkit.org/show_bug.cgi?id=95800

Patch by Adam Barth <abarth@chromium.org> on 2012-09-04
Reviewed by Benjamin Poulain.

This patch is a re-spin of part of the patch from
https://bugs.webkit.org/show_bug.cgi?id=95502, but with the tests
fixed. :)

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):

10:14 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Fix typo. (diff)
10:12 PM Changeset in webkit [127554] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Allow the YarrJIT to use the assembler even when useJIT() is false.
Introduce the useYarrJIT() option.
https://bugs.webkit.org/show_bug.cgi?id=95809.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-04
Reviewed by Geoffrey Garen.

  • runtime/JSGlobalData.cpp:

(JSC::enableAssembler):

  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/Options.h:

(JSC):

10:12 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Fix typo. (diff)
10:08 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Expand "Japanse or Chinese" to "Chinese, Japanese, or Korean". (diff)
9:53 PM Changeset in webkit [127553] by keishi@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r126132): MediaSlider and MediaVolumeSlider thumbs don't match mouse when dragged
https://bugs.webkit.org/show_bug.cgi?id=95701

Reviewed by Kent Tamura.

Source/WebCore:

MediaSlider and MediaVolumeSlider thumbs didn't match mouse when dragged because of the negative margin applied to the thumb.

Test: platform/chromium/media/media-volume-slider-hit-test.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint): Account for margins when calculating the position.

LayoutTests:

  • platform/chromium/media/media-volume-slider-hit-test-expected.txt: Added.
  • platform/chromium/media/media-volume-slider-hit-test.html: Added.
9:40 PM Changeset in webkit [127552] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Use explicit constructor in InjectedBundle.
https://bugs.webkit.org/show_bug.cgi?id=95746

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-04
Reviewed by Sam Weinig.

Added explicit keyword in constructor of InjectedBundle in order to avoid implicit type conversion.

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

9:27 PM Changeset in webkit [127551] by tkent@chromium.org
  • 5 edits in trunk/LayoutTests

[Chromium] Update test expectation
https://bugs.webkit.org/show_bug.cgi?id=95395

  • platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/chromium/TestExpectations:
9:16 PM Changeset in webkit [127550] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectatino update.

  • platform/chromium/TestExpectations:

japanese-ruby-vertical-*.html might be flaky on Windows too.

9:14 PM Changeset in webkit [127549] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Add a const version of RenderBox::computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=95787

Reviewed by Ojan Vafai.

After this, we can rename the old computeLogicalHeight to computeAndSetLogicalHeight
to make it clear that it is modifying values.

No new tests, this should just be a refactor.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalHeightByMinMax): Make const.
(WebCore::RenderBox::computeLogicalHeight): Add a const version that takes a LogicalExtentComputedValues struct for out values.
(WebCore::RenderBox::computeLogicalHeightUsing): Make const.
(WebCore::RenderBox::computeContentLogicalHeightUsing): Make const.
(WebCore::RenderBox::computePercentageLogicalHeight): Add a const cast. I tried to
convert everything below to const, but that's not a simple task. Also, computeReplacedLogicalHeightUsing
is already using a const_cast.

  • rendering/RenderBox.h:

(RenderBox): Add const to method signatures.

8:57 PM Changeset in webkit [127548] by krit@webkit.org
  • 3 edits
    2 adds in trunk

-webkit-clip-path does not apply origin for polygon()
https://bugs.webkit.org/show_bug.cgi?id=95656

Reviewed by Tim Horton.

Source/WebCore:

The polygon() shape function did not apply origin of bouding box on created path. The shape was
not moved to the correct position.

Tests: svg/clip-path/clip-path-shape-polygon-relative-expected.svg

svg/clip-path/clip-path-shape-polygon-relative.svg

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapePolygon::path): Apply origin of bounding box.

LayoutTests:

Check that the origin of the bounding box gets applied to the clip path.

  • svg/clip-path/clip-path-shape-polygon-relative-expected.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-relative.svg: Added.
8:45 PM Changeset in webkit [127547] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Have NRWT log more output when crash logs are missing
https://bugs.webkit.org/show_bug.cgi?id=95814

Reviewed by Dan Bernstein.

Log the stderr and stdout of the test, in order to provide slightly more
context when the WebProcess times out while running tests.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test):

8:33 PM Changeset in webkit [127546] by bashi@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r127534

  • platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.
7:48 PM Changeset in webkit [127545] by jchaffraix@webkit.org
  • 1 edit
    1 copy in branches/chromium/1229

Merge 127520 - REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
https://bugs.webkit.org/show_bug.cgi?id=95776

Reviewed by Simon Fraser.

.:

  • ManualTests/select-menu-list-wrongly-positioned.html: Added.

Source/WebCore:

r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.

Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.

TBR=jchaffraix@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10908086

7:36 PM Changeset in webkit [127544] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

inc/dec behave incorrectly operating on a resolved const
https://bugs.webkit.org/show_bug.cgi?id=95815

Reviewed by Geoff Garen.

Source/JavaScriptCore:

There are two bugs here.

(1) When the value being incremented is const, and the result is ignored, we assume this cannot be observed, and emit no code.

However if the value being incremented is not a primitive & has a valueOf conversion, then this should be being called.

(2) In the case of a pre-increment of a const value where the result is not ignored, we'll move +/-1 to the destination, then

add the resolved const value being incremented to this. This is problematic if the destination is a local, and the const
value being incremented has a valueOf conversion that throws - the destination will be modified erroneously. Instead, we
need to use a temporary location.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):

  • always at least perform a toNumber conversion, use tempDestination when reducing inc/dec to an add +/-1.

LayoutTests:

Added test cases.

  • fast/js/inc-const-valueOf-expected.txt: Added.
  • fast/js/inc-const-valueOf.html: Added.
  • fast/js/script-tests/inc-const-valueOf.js: Added.

(testPostIncConstVarWithIgnoredResult.const.a.valueOf):
(testPostIncConstVarWithIgnoredResult):

test that 'a++' results in a valueOf call, where 'a' is const.

(testPreIncConstVarWithIgnoredResult.const.a.valueOf):
(testPreIncConstVarWithIgnoredResult):

test that '++a' results in a valueOf call, where 'a' is const.

(testPreIncConstVarWithAssign.const.a.valueOf):
(testPreIncConstVarWithAssign):

test that 'b = ++a' does not erroneously update 'b', where 'a' is const.

7:28 PM Changeset in webkit [127543] by tkent@chromium.org
  • 71 edits
    8 copies
    1 move
    25 adds
    4 deletes in trunk/LayoutTests

[Chromium] Test expectation update

Rebaseline vertical-writing tests.

  • platform/chromium-linux-x86/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/chromium-linux-x86/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
  • platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
  • platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt.
  • platform/chromium-mac/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/chromium-mac/fast/writing-mode/japanese-rl-selection-expected.png: Added.
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt.
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt.
  • platform/chromium-win-xp/fast/dynamic/text-combine-expected.png:
  • platform/chromium-win-xp/fast/dynamic/text-combine-expected.txt: Added.
  • platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.png:
  • platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt.
  • platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.txt: Added.
  • platform/chromium-win-xp/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-win-xp/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/chromium-win-xp/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
  • platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.png: Removed.
  • platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
  • platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.png: Removed.
  • platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/vertical-align-table-baseline-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt.
  • platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
  • platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/chromium-win/fast/dynamic/text-combine-expected.png:
  • platform/chromium-win/fast/dynamic/text-combine-expected.txt:
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png:
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/chromium-win/fast/text/international/text-spliced-font-expected.png:
  • platform/chromium-win/fast/text/international/text-spliced-font-expected.txt:
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.png:
  • platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/chromium-win/fast/writing-mode/fallback-orientation-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Removed.
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/chromium-win/fast/writing-mode/vertical-align-table-baseline-expected.png:
  • platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.png: Added.
  • platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.txt:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
  • platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
  • platform/chromium/TestExpectations:
6:55 PM Changeset in webkit [127542] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky media/video tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95806

  • platform/win/Skipped:
6:45 PM Changeset in webkit [127541] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky http/tests/cookies tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95805

  • platform/win/Skipped:
6:43 PM Changeset in webkit [127540] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS
https://bugs.webkit.org/show_bug.cgi?id=95798

Patch by Adam Barth <abarth@chromium.org> on 2012-09-04
Reviewed by Eric Seidel.

Source/WebCore:

This patch makes the chromium-linux port build without
WTF::String::operator+=. There are a couple places that require some
more careful study, and I've whitelisted those uses by defining
WTF_DEPRECATED_STRING_OPERATORS at the top of the files. (See
https://bugs.webkit.org/show_bug.cgi?id=95797 for an explanation of
WTF_DEPRECATED_STRING_OPERATORS.)

  • css/StylePropertySet.cpp:
  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::drawNodeHighlight):

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::rewriteMixVertexShader):

Source/WebKit/chromium:

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::keyboardShortcut):

  • Remove use of WTF::String::operator+=
  • src/WebPageSerializerImpl.cpp:
    • Whitelist use of WTF::String::operator+=. Remove this use will take some more careful thought.
6:38 PM Changeset in webkit [127539] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky http/tests/security tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95803

  • platform/win/Skipped:
6:31 PM Changeset in webkit [127538] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Use TrackedRendererListHashSet typedef for percentHeightDescendants()
https://bugs.webkit.org/show_bug.cgi?id=95791

Reviewed by Ojan Vafai.

There were a couple callers that were using ListHashSet<RenderBox*> instead of the typedef.

No new tests, this is just a refactor.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderView.cpp:

(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):

6:30 PM Changeset in webkit [127537] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Some flaky inspector tests on Windows. Adding to skip list.
https://bugs.webkit.org/show_bug.cgi?id=95802

  • platform/win/Skipped:
6:27 PM Changeset in webkit [127536] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
https://bugs.webkit.org/show_bug.cgi?id=95717

Reviewed by Oliver Hunt.

Rolling back in after fixing the negative index case.

Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
there so we should just use it!

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:56 PM Changeset in webkit [127535] by commit-queue@webkit.org
  • 13 edits
    3 deletes in trunk/Source

IndexedDB: remove final createIndex backend glue
https://bugs.webkit.org/show_bug.cgi?id=95385

Patch by Alec Flett <alecflett@chromium.org> on 2012-09-04
Reviewed by Adam Barth.

Source/WebCore:

Remove all code that created index keys in the IndexedDB backend.

No new tests, this is just removal of dead code.

  • Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Removed.
  • Modules/indexeddb/IDBKeyPathBackendImpl.h: Removed.
  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • storage/chromium/IDBKeyPathBackendImpl.cpp: Removed.

Source/WebKit/chromium:

Remove chromium glue for old key-generation code.

  • public/WebIDBKey.h:

(WebIDBKey):

  • src/WebIDBKey.cpp:
5:40 PM Changeset in webkit [127534] by commit-queue@webkit.org
  • 8 edits
    1 copy
    4 adds in trunk

Frame element doesn't always unload its child frame.
https://bugs.webkit.org/show_bug.cgi?id=94717

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2012-09-04
Reviewed by Hajime Morita.

Source/WebCore:

It's possible for a frame element that has been removed from the document
to retain an active child frame. This inconsistent state may become a source
of security vulnerabilities.

The patch adds a global HashSet to store the nodes currently processed by
ChildFrameDisconnector. Insertion into these nodes' subtrees is not allowed until
the processing is complete.

Also, the ChildFrameDisconnector call in removeChild(ren) is now immediately
followed by the actual removal.

Test: fast/frames/out-of-document-iframe-has-child-frame.html

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChildren): Move the ChildFrameDisconnector call out of a loop.
(WebCore::ContainerNode::removeChild): Rearrange some event firing code.
(WebCore::ContainerNode::removeChildren): Ditto.

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildFrameDisconnector::collectDescendant): Pass a new parameter to collectDescendant(Node*).

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(ChildFrameDisconnector): Maintain a list of nodes that have an active ChildFrameDisconnector.
(WebCore::ChildFrameDisconnector::~ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::rootNodes):
(WebCore::ChildFrameDisconnector::collectDescendant): Add ShouldIncludeRoot parameter.
(WebCore::ChildFrameDisconnector::nodeHasDisconnector):
(WebCore):

  • dom/Node.cpp:

(WebCore::checkAcceptChild): Reject a parent node if it or one of its parents has an active ChildFrameDisconnector.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Check if an element is still in the document.

LayoutTests:

  • fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
  • fast/frames/out-of-document-iframe-has-child-frame.html: Added.
  • fast/innerHTML/innerHTML-iframe-expected.txt:
  • platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
  • platform/chromium/fast/innerHTML: Added.
  • platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
5:28 PM Changeset in webkit [127533] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed test expectation update after r127457

  • platform/chromium/TestExpectations:
5:25 PM Changeset in webkit [127532] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Adding test inspector/timeline/timeline-decode-resize.html to Windows skip list.
It fails on both Windows and Mac: https://bugs.webkit.org/show_bug.cgi?id=94374.

  • platform/win/Skipped:
5:23 PM Changeset in webkit [127531] by mrowe@apple.com
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

5:21 PM Changeset in webkit [127530] by mrowe@apple.com
  • 1 copy in tags/Safari-536.26.13

New tag.

5:21 PM Changeset in webkit [127529] by mrowe@apple.com
  • 1 delete in tags/Safari-536.26.13

Remove tag.

5:18 PM Changeset in webkit [127528] by mrowe@apple.com
  • 1 edit in branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

Build fix.

5:09 PM Changeset in webkit [127527] by roger_fong@apple.com
  • 7 edits in trunk/LayoutTests

Unreviewed. Rebaseline tests after http://trac.webkit.org/changeset/127354.

  • platform/win/fast/text/international/text-spliced-font-expected.txt:
  • platform/win/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/win/fast/writing-mode/japanese-lr-selection-expected.txt:
  • platform/win/fast/writing-mode/japanese-lr-text-expected.txt:
  • platform/win/fast/writing-mode/japanese-rl-selection-expected.txt:
  • platform/win/fast/writing-mode/japanese-rl-text-expected.txt:
5:07 PM Changeset in webkit [127526] by bashi@chromium.org
  • 2 edits in trunk/Source/Platform

[Chromium] Attempt to fix build failure on Win

Remove chromium/public/WebOfferAnswerRequest.h from Platform.gypi,
which was added in r127501, but doesn't exist. Unreviewed.

  • Platform.gypi:
4:58 PM Changeset in webkit [127525] by weinig@apple.com
  • 19 edits
    1 move in trunk/Source

Part 1 of removing PlatformString.h, move remaining functions to new homes
https://bugs.webkit.org/show_bug.cgi?id=95702

Reviewed by Beth Dakin.

Source/WebCore:

Move utf8Buffer() to SharedBuffer.h/cpp
Move numGraphemeClusters() and numCharactersInGraphemeClusters() to TextBreakIterator.h/cpp

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Update projects.

  • platform/text/TextAllInOne.cpp:

Add TextBreakIterator.cpp.

  • editing/Editor.h:

Forward declare SharedBuffer, now that PlatformString.h doesn't.

  • html/InputType.cpp:

#include TextBreakIterator.h.

  • loader/appcache/ApplicationCacheStorage.h:

Replace inclusion of PlatformString.h with WTFString.h and forward declare SharedBuffer.

  • platform/LocalizedStrings.cpp:

Replace inclusion of PlatformString.h with TextBreakIterator.h

  • platform/SharedBuffer.cpp:
  • platform/SharedBuffer.h:

Move utf8Buffer() here.

  • platform/text/PlatformString.h:

Remove everything except the #include of WTFString.h.

  • platform/text/TextBreakIterator.cpp: Renamed from Source/WebCore/platform/text/String.cpp.

(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):

  • platform/text/TextBreakIterator.h:

Move numGraphemeClusters() and numCharactersInGraphemeClusters() here.

Source/WebKit2:

  • UIProcess/WebPageProxy.h:

Forward declare SharedBuffer.

4:56 PM Changeset in webkit [127524] by mrowe@apple.com
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Merge r127319.

4:56 PM Changeset in webkit [127523] by mrowe@apple.com
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Merge r127272.

4:56 PM Changeset in webkit [127522] by mrowe@apple.com
  • 9 edits
    2 adds in branches/safari-536.26-branch

Merge r127047.

4:45 PM Changeset in webkit [127521] by mrowe@apple.com
  • 1 copy in tags/Safari-536.26.13

New tag.

4:39 PM Changeset in webkit [127520] by jchaffraix@webkit.org
  • 3 edits
    1 add in trunk

REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp
https://bugs.webkit.org/show_bug.cgi?id=95776

Reviewed by Simon Fraser.

.:

  • ManualTests/select-menu-list-wrongly-positioned.html: Added.

Source/WebCore:

r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
the offset were positive which got exposed to other code paths, leading to the regression.

Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clampScrollOffset):
Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.

4:34 PM Changeset in webkit [127519] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows since introduced in http://trac.webkit.org/changeset/126865.
Test added to skip list.

https://bugs.webkit.org/show_bug.cgi?id=95795

  • platform/win/Skipped:
4:34 PM Changeset in webkit [127518] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired
https://bugs.webkit.org/show_bug.cgi?id=95777

Reviewed by Tony Chang.

IDBRequests are kept alive as long as they may fire events, which includes
if the associated IDBCursor object can be advanced. When the transaction
is finished the IDBCursor is notified which in turn tells the IDBRequest
that the cursor won't be the source of more events. However, if this occurs
and no further events fire the IDBRequest doesn't clear it's "has pending
activity flag". Clear the flag on the notification if the request is
otherwise complete.

No new tests - ActiveDOMObjects and leaks are persnickety.

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::finishCursor):

3:53 PM Changeset in webkit [127517] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[CSS Shaders] Implement multiply, screen, darken, lighten, difference, exclusion blend modes.
https://bugs.webkit.org/show_bug.cgi?id=93870

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-04
Reviewed by Dirk Schulze.

Source/WebCore:

Add expressions for the aforementioned blend modes. The expressions are lifted directly
from the CSS Compositing and Blending spec [1]. WebKit adds these blending expressions to
the author's shader.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnormal

Test: css3/filters/custom/custom-filter-blend-modes.html

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::blendFunctionString):

LayoutTests:

Add test to check that the DOM element texture blends correctly with the css_MixColor
variable from the author's shader for each blend mode.

  • css3/filters/custom/custom-filter-blend-modes-expected.html: Added.
  • css3/filters/custom/custom-filter-blend-modes.html: Added.
  • css3/filters/resources/mix-color.fs: Added.
3:34 PM Changeset in webkit [127516] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r127503.
http://trac.webkit.org/changeset/127503
https://bugs.webkit.org/show_bug.cgi?id=95788

broke some tests (fast/js/dfg-negative-array-index, fast/js
/dfg-put-by-val-setter-then-get-by-val) (Requested by thorton
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-04

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:27 PM Changeset in webkit [127515] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] FatFingers::cachingStrategy uses incorrect enum value
https://bugs.webkit.org/show_bug.cgi?id=95783

Reviewed by Antonio Gomes.

Use the correct enum values.

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::cachingStrategy):

3:22 PM Changeset in webkit [127514] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix style for Event.h
https://bugs.webkit.org/show_bug.cgi?id=95779

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-09-04
Reviewed by Eric Seidel.

Changes indenting for Event.h to match style guidelines for namespaces

  • dom/Event.h:
3:20 PM Changeset in webkit [127513] by jpfau@apple.com
  • 6 edits
    12 adds in trunk

Make plugins respect third-party storage blocking setting
https://bugs.webkit.org/show_bug.cgi?id=94888

Reviewed by Brady Eidson.

Source/WebCore:

Added functions for discerning if a plugin should be able to access its storage in its current origin.

Tests: http/tests/security/cross-origin-plugin-allowed.html

http/tests/security/cross-origin-plugin.html

  • WebCore.exp.in: Export FrameTree::top and SecurityOrigin::canAccessStorage
  • page/SecurityOrigin.h: Added canAccessPluginStorage

(WebCore::SecurityOrigin::canAccessPluginStorage):

Source/WebKit2:

Plugins that are in a third-party context should be put into private browsing mode so their storage is temporary.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::isPrivateBrowsingEnabled): Put the plugin into private browsing mode if it is in a third-party context.
(WebKit::PluginView::privateBrowsingStateChanged): Make sure a plugin doesn't leave private browsing mode if it's in a third-party context.

LayoutTests:

Created tests for plugins in a third party and first party context when third-party blocking is on and off.

  • http/tests/security/cross-origin-plugin-allowed-expected.txt: Added.
  • http/tests/security/cross-origin-plugin-allowed.html: Added.
  • http/tests/security/cross-origin-plugin-expected.txt: Added.
  • http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed-expected.txt: Added.
  • http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html: Added.
  • http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.
  • http/tests/security/cross-origin-plugin-private-browsing-toggled.html: Added.
  • http/tests/security/cross-origin-plugin.html: Added.
  • http/tests/security/resources/cross-origin-iframe-for-plugin.html: Added.
  • http/tests/security/resources/cross-origin-iframe-for-plugin-async.html: Added.
  • platform/mac-wk2/http/tests/security/cross-origin-plugin-expected.txt: Added.
  • platform/mac-wk2/http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt: Added.
3:14 PM Changeset in webkit [127512] by wangxianzhu@chromium.org
  • 3 edits in trunk/Tools

[Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
https://bugs.webkit.org/show_bug.cgi?id=95770

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._log_error): Added to replace original _log.error().
(ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
(ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
(ChromiumAndroidDriver._push_executable):
(ChromiumAndroidDriver._push_fonts):
(ChromiumAndroidDriver._push_test_resources):
(ChromiumAndroidDriver._run_adb_command):
(ChromiumAndroidDriver._get_last_stacktrace):
(ChromiumAndroidDriver._get_crash_log):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver._start_once):
(ChromiumAndroidDriver._start_once.deadlock_detector):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(ChromiumAndroidDriverTest.test_get_crash_log):

3:14 PM Changeset in webkit [127511] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Rebaseline Windows expected results for accessibility\canvas-description-and-role-expected.txt.
One of the results in the test now passes.

  • platform/win/accessibility/canvas-description-and-role-expected.txt:
2:48 PM Changeset in webkit [127510] by wangxianzhu@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed. Update test expectations for Android.

  • platform/chromium-android/TestExpectations:
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
  • platform/chromium/TestExpectations:
2:35 PM Changeset in webkit [127509] by robert@webkit.org
  • 3 edits
    2 adds in trunk

Regression(r127163): Heap-use-after-free in WebCore::RenderBoxModelObject::hasSelfPaintingLayer
https://bugs.webkit.org/show_bug.cgi?id=95632

Reviewed by Abhishek Arya.

Source/WebCore:

Don't add floats to the floating object set of blocks that avoid floats. There's no point in doing that
and they will never get cleared out during relayout.

Tests: fast/css/intruding-floats-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloatsIfNeeded):

LayoutTests:

  • fast/css/intruding-floats-crash-expected.txt: Added.
  • fast/css/intruding-floats-crash.html: Added.
2:32 PM Changeset in webkit [127508] by msaboff@apple.com
  • 3 edits
    2 adds in trunk

equal() in CSSParser.cpp should check the length of characters
https://bugs.webkit.org/show_bug.cgi?id=95706

Source/WebCore:

Reviewed by Abhishek Arya.

Pass the length of string literals to CSSParser static functions equal() and
equalIgnoringCase() so that checks won't access out of bounds memory.

Added test fast/css/crash-comparing-equal.html.

  • css/CSSParser.cpp:

(WebCore::equal): Use template to retrieve the length of string literal.
(WebCore::equalIgnoringCase): Ditto.
(WebCore::CSSParser::parseDashboardRegions): Use const char[] instead of const char*

LayoutTests:

Added test from duplicate defect https://bugs.webkit.org/show_bug.cgi?id=95634.

Reviewed by Abhishek Arya.

  • fast/css/crash-comparing-equal-expected.txt: Added.
  • fast/css/crash-comparing-equal.html: Added.
2:23 PM Changeset in webkit [127507] by satish@chromium.org
  • 2 edits in trunk/Tools

Run git commands within the checkout directory
https://bugs.webkit.org/show_bug.cgi?id=95742

Reviewed by Eric Seidel.

git commands run from scm/git.py are sometimes run with cwd set to the
checkout_root and other times with whatever directory was the default cwd.
Instead all these should run with the checkout root set as the cwd
(except where we explicitly need a different path)

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git._run_git):
(Git.find_checkout_root):
(Git.discard_local_commits):
(Git.local_commits):
(Git.working_directory_is_clean):
(Git.clean_working_directory):
(Git.add_list):
(Git.delete_list):
(Git.exists):
(Git._current_branch):
(Git._changes_files_for_commit):
(Git.revisions_changing_file):
(Git.svn_revision):
(Git._run_git_svn_find_rev):
(Git.contents_at_revision):
(Git.diff_for_file):
(Git.show_head):
(Git.committer_email_for_revision):
(Git.apply_reverse_diff):
(Git.revert_files):
(Git.commit_with_message):
(Git._commit_on_branch):
(Git.svn_commit_log):
(Git.last_svn_commit_log):
(Git.svn_blame):
(Git._branch_ref_exists):
(Git.delete_branch):
(Git.remote_merge_base):
(Git.commit_locally_with_message):
(Git.push_local_commits_to_server):
(Git.commit_ids_from_commitish_arguments):
(Git.commit_message_for_local_commit):
(Git.files_changed_summary_for_commit):

2:21 PM Changeset in webkit [127506] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. meda/video-controls-captions.html fails on Windows after it was introduced in http://trac.webkit.org/changeset/127035.
https://bugs.webkit.org/show_bug.cgi?id=95428

  • platform/win/Skipped:
2:19 PM Changeset in webkit [127505] by benjamin@webkit.org
  • 39 edits in trunk/Source/JavaScriptCore

Improve JSC use of Strings after the UString->String change
https://bugs.webkit.org/show_bug.cgi?id=95633

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-04
Reviewed by Geoffrey Garen.

This patch improve the use of strings in the JSC runtime.

The initialization of Identifier is left for future patches.

The improvements are the following:
-5% faster to raise one of the modified exception.
-3 times faster to execute Boolean::toString()

Most of the changes are just about using the new methods
for string literals.

With the changes, the binary on x86_64 gets 176 bytes smaller.

  • API/JSCallbackObjectFunctions.h:

(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

  • API/JSContextRef.cpp:

(JSContextCreateBacktrace):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunctionWithCallback):

  • bytecode/CodeBlock.cpp:

(JSC::valueToSourceString):
(JSC::CodeBlock::nameForRegister):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::addStackTraceIfNecessary):

  • runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

  • runtime/ArrayPrototype.cpp:

(JSC::shift):
(JSC::unshift):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):

  • runtime/BooleanPrototype.cpp:

(JSC::booleanProtoFuncToString): Instead of instanciating new strings, reuse the
keywords available in SmallStrings. Avoiding the creation of the JSString and StringImpl
makes the method significantly faster.

  • runtime/DateConversion.cpp:

(JSC::formatDateTime):

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::formateDateInstance):
(JSC::dateProtoFuncToISOString):
Change the way we use snprintf() for clarity and performance.

Instead of allocating one extra byte to put a zero "just in case", we use the size returned
by snprintf().
To prevent any overflow from a programming mistake, we explicitely test for overflow and
return an empty string.

(JSC::dateProtoFuncToJSON):

  • runtime/Error.cpp:

(JSC::createNotEnoughArgumentsError):
(JSC::throwTypeError):
(JSC::throwSyntaxError):

  • runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::create):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::finishCreation):
(JSC::errorProtoFuncToString):
Using a null String is correct because (8) uses jsString(), (9) tests for a length of 0.

  • runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
(JSC::createStackOverflowError):
(JSC::createOutOfMemoryError):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::FunctionExecutable::paramString):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/FunctionPrototype.h:

(JSC::FunctionPrototype::create):
Using a null String for the name is correct because InternalFunction uses jsString()
to create the name value.

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):
There is no need to create an empty string for a null string, jsString() handle both
cases as empty JSString.

  • runtime/JSArray.cpp:

(JSC::reject):
(JSC::SparseArrayValueMap::put):
(JSC::JSArray::put):
(JSC::JSArray::putByIndexBeyondVectorLength):
(JSC::JSArray::putDirectIndexBeyondVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation): Same issue as InternalFunction::finishCreation.

(JSC::JSFunction::callerGetter):
(JSC::JSFunction::defineOwnProperty):

  • runtime/JSGlobalData.cpp:

(JSC::enableAssembler): Use CFSTR() instead of CFStringCreateWithCString().
CFStringCreateWithCString() copy the content and may choose to decode the data.
CFSTR() is much more efficient.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
JSFunction uses jsString() to create the name, we can use null strings instead
of creating empty strings.

(JSC::JSGlobalObject::createThrowTypeError): ditto.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncEval):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::defaultValue):
(JSC::JSObject::hasInstance):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSString.cpp:

Return an empty JSString to avoid the creation of a temporary empty String.

(JSC::JSRopeString::getIndexSlowCase):

  • runtime/JSString.h:

(JSC): Remove the versions of jsNontrivialString() taking a char*. All the callers
have been replaced by calls using ASCIILiteral.

  • runtime/JSValue.cpp:

(JSC::JSValue::putToPrimitive):

  • runtime/LiteralParser.cpp:

(JSC::::Lexer::lex):
(JSC::::Lexer::lexString):
(JSC::::Lexer::lexNumber):
(JSC::::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
(JSC::objectConstructorIsExtensible):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):
(JSC::objectProtoFuncToString):

  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpObject.cpp:

(JSC::reject):
(JSC::regExpObjectSource):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

  • runtime/StringObject.cpp:

(JSC::StringObject::defineOwnProperty):

  • runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):

2:16 PM Changeset in webkit [127504] by Lucas Forschler
  • 4 edits in branches/safari-536.26-branch/Source

Versioning.

2:15 PM Changeset in webkit [127503] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
https://bugs.webkit.org/show_bug.cgi?id=95717

Reviewed by Oliver Hunt.

Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
there so we should just use it!

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

2:10 PM Changeset in webkit [127502] by tonikitoo@webkit.org
  • 12 edits in trunk/Source

[BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin
https://bugs.webkit.org/show_bug.cgi?id=95778
PR #202252

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Arvid Nilsson.

Upstream has switch away from using the parent scroll layer's bounds origin
in order to translate contents of all its child layers. Instead now, it directly
sets the scroll position of the child scrollable contents layer.

Source/WebCore:

No new tests, since it is a catch-up with upstreaming code.

Source/WebCore:

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(GraphicsLayerBlackBerry):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::updateAnimations):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerOverride::LayerOverride):
(LayerOverride):

  • platform/graphics/blackberry/LayerData.h:

(LayerData):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::updateLayersRecursive):

  • platform/graphics/blackberry/LayerWebKitThread.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Source/WebKit/blackberry:

Source/WebKit/blackberry:

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

No new tests, since it is a catch-up with upstreaming code.

2:02 PM Changeset in webkit [127501] by tommyw@google.com
  • 19 edits
    7 copies
    6 adds in trunk

MediaStream API: Add the async createOffer functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95734

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCSessionDescriptionDescriptor.h: Added.

(WebCore):
(WebKit):
(WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::~WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::operator=):
(WebKit::WebRTCSessionDescriptionDescriptor::isNull):

  • chromium/public/WebRTCSessionDescriptionRequest.h: Added.

(WebCore):
(WebKit):
(WebRTCSessionDescriptionRequest):
(ExtraData):
(WebKit::WebRTCSessionDescriptionRequest::ExtraData::~ExtraData):
(WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::~WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::operator=):
(WebKit::WebRTCSessionDescriptionRequest::isNull):

Source/WebCore:

createOffer sends a request to the platform implementer requesting it to gather up all candidates.
This can take some time, therefore the request is async.

Test: fast/mediastream/RTCPeerConnection-createOffer.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCErrorCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.

(WebCore):
(RTCErrorCallback):
(WebCore::RTCErrorCallback::~RTCErrorCallback):

  • Modules/mediastream/RTCErrorCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):
(WebCore):

  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCSessionDescriptionCallback.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.

(WebCore):
(RTCSessionDescriptionCallback):
(WebCore::RTCSessionDescriptionCallback::~RTCSessionDescriptionCallback):

  • Modules/mediastream/RTCSessionDescriptionCallback.idl: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.
  • Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp: Added.

(WebCore):
(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::stop):
(WebCore::RTCSessionDescriptionRequestImpl::clear):

  • Modules/mediastream/RTCSessionDescriptionRequestImpl.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.

(WebCore):
(RTCSessionDescriptionRequestImpl):

  • WebCore.gypi:
  • platform/chromium/support/WebRTCSessionDescriptionDescriptor.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.

(WebKit):
(WebKit::WebRTCSessionDescriptionDescriptor::WebRTCSessionDescriptionDescriptor):
(WebKit::WebRTCSessionDescriptionDescriptor::assign):
(WebKit::WebRTCSessionDescriptionDescriptor::reset):
(WebKit::WebRTCSessionDescriptionDescriptor::operator WTF::PassRefPtr<WebCore::RTCSessionDescriptionDescriptor>):
(WebKit::WebRTCSessionDescriptionDescriptor::initialize):
(WebKit::WebRTCSessionDescriptionDescriptor::type):
(WebKit::WebRTCSessionDescriptionDescriptor::setType):
(WebKit::WebRTCSessionDescriptionDescriptor::sdp):
(WebKit::WebRTCSessionDescriptionDescriptor::setSDP):

  • platform/chromium/support/WebRTCSessionDescriptionRequest.cpp: Added.

(WebKit):
(WebKit::WebRTCSessionDescriptionRequest::WebRTCSessionDescriptionRequest):
(WebKit::WebRTCSessionDescriptionRequest::assign):
(WebKit::WebRTCSessionDescriptionRequest::reset):
(WebKit::WebRTCSessionDescriptionRequest::requestSucceeded):
(WebKit::WebRTCSessionDescriptionRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCSessionDescriptionRequest::extraData):
(WebKit::WebRTCSessionDescriptionRequest::setExtraData):

  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::createOffer):
(WebCore):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCSessionDescriptionDescriptor.h:

(WebCore::RTCSessionDescriptionDescriptor::type):
(WebCore::RTCSessionDescriptionDescriptor::sdp):

  • platform/mediastream/RTCSessionDescriptionRequest.h: Copied from Source/WebCore/platform/mediastream/RTCSessionDescriptionDescriptor.h.

(WebCore):
(RTCSessionDescriptionRequest):
(ExtraData):
(WebCore::RTCSessionDescriptionRequest::ExtraData::~ExtraData):
(WebCore::RTCSessionDescriptionRequest::~RTCSessionDescriptionRequest):
(WebCore::RTCSessionDescriptionRequest::extraData):
(WebCore::RTCSessionDescriptionRequest::setExtraData):
(WebCore::RTCSessionDescriptionRequest::RTCSessionDescriptionRequest):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::createOffer):
(WebCore):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
(MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
(MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
(MockWebRTCPeerConnectionHandler::createOffer):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::taskList):
(SuccessCallbackTask):
(FailureCallbackTask):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-createOffer-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-createOffer.html: Added.
1:58 PM Changeset in webkit [127500] by mitz@apple.com
  • 12 edits in trunk

Reverted r127468 (the fix for <http://webkit.org/b/93443>) because the test it included caused
an assertion failure in Document::updateStyleIfNeeded().

Source/WebCore:

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
1:41 PM Changeset in webkit [127499] by Lucas Forschler
  • 1 copy in tags/Safari-536.26.12

New Tag.

1:35 PM Changeset in webkit [127498] by Lucas Forschler
  • 9 edits
    2 deletes in branches/safari-536.26-branch

Rollout 127252.

1:34 PM Changeset in webkit [127497] by Simon Fraser
  • 4 edits
    2 adds in trunk

Regression: Heap-use-after-free in WebCore::FrameView::scrollContentsFastPath
https://bugs.webkit.org/show_bug.cgi?id=95754

Reviewed by Dave Hyatt.

Source/WebCore:

It's possible to have a renderer with position:fixed or sticky style,
but no layer, for example a RenderScrollBarPart. Don't register such
renderers with the FrameView.

Moved the code that registers/unregisters with the FrameView from
styleWillChange() to styleDidChange(), since in the latter case
we can check if we have a RenderLayer. Only register renderers with layers.
We always unregister, which required removing an assertion in
FrameView::removeFixedObject(), and replacing it with a null check of m_fixedObjects.

Test: fast/css/remove-fixed-resizer-crash.html

  • page/FrameView.cpp:

(WebCore::FrameView::removeFixedObject):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::styleWillChange):
(WebCore::RenderBoxModelObject::styleDidChange):

LayoutTests:

Testcase with a position:fixed resizer and scrolling.

  • fast/css/remove-fixed-resizer-crash-expected.txt: Added.
  • fast/css/remove-fixed-resizer-crash.html: Added.
1:30 PM Changeset in webkit [127496] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Rollout r127276.

1:30 PM Changeset in webkit [127495] by dominik.rottsches@intel.com
  • 3 edits in trunk/Source/WebCore

ResourceErrorBase needs to identify timeouts
https://bugs.webkit.org/show_bug.cgi?id=95755

Reviewed by Alexey Proskuryakov.

Adding a property to check whether this ResourceError was raised due to a timeout.
This is preparatory work for bug 74802. In order to implement XHR2 timeout functionality,
I need to identify some layers up whether the original network problem has been a timeout.

No new tests, no change in behavior yet.

  • platform/network/ResourceErrorBase.cpp:

(WebCore::ResourceErrorBase::copy): Copying new member.
(WebCore::ResourceErrorBase::compare): Comparing new member.

  • platform/network/ResourceErrorBase.h:

(WebCore::ResourceErrorBase::setIsTimeout): New setter.
(WebCore::ResourceErrorBase::isTimeout): New getter.
(ResourceErrorBase),
(WebCore::ResourceErrorBase::ResourceErrorBase): Adding m_isTimeout member.

1:25 PM Changeset in webkit [127494] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Rename WebViewClient::handleDisambiguationPopup
https://bugs.webkit.org/show_bug.cgi?id=95529

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-09-04
Reviewed by Adam Barth.

Rename it to something more descriptive (WebViewClient::didTapMultipleTargets) before people start using it.

  • public/WebViewClient.h:

(WebKit::WebViewClient::didTapMultipleTargets):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

  • tests/WebFrameTest.cpp:
1:22 PM Changeset in webkit [127493] by staikos@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix memory leak in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=95771

Reviewed by Rob Buis.

Simply delete the arrays at function exit.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openSelectPopup):

1:18 PM Changeset in webkit [127492] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

1:14 PM Changeset in webkit [127491] by roger_fong@apple.com
  • 9 edits in trunk/LayoutTests

Unreviewed. Removing accidentally added executable properties on test files.

  • platform/win/accessibility/canvas-description-and-role-expected.txt: Removed property svn:executable.
  • platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed property svn:executable.
  • platform/win/fast/css/image-resolution/image-resolution-expected.txt: Removed property svn:executable.
  • platform/win/fast/css/image-set-setting-expected.txt: Removed property svn:executable.
  • platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt: Removed property svn:executable.
  • platform/win/fast/css/variables/build-supports-variables-expected.txt: Removed property svn:executable.
  • platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Removed property svn:executable.
  • platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Removed property svn:executable.
1:05 PM Changeset in webkit [127490] by Lucas Forschler
  • 1 copy in tags/Safari-537.8/trunk

New Tag.

1:03 PM Changeset in webkit [127489] by staikos@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad()
https://bugs.webkit.org/show_bug.cgi?id=95766

Reviewed by Rob Buis.

Passing the frame status through will allow the client to make better
decisions about how to act on the onload.

  • Api/WebPageClient.h:
  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents):

12:59 PM Changeset in webkit [127488] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] Output time and thread info in crash log
https://bugs.webkit.org/show_bug.cgi?id=95768

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.

12:48 PM Changeset in webkit [127487] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Remove use of deprecated QInputMethod method
https://bugs.webkit.org/show_bug.cgi?id=95741

Patch by Pekka Vuorela <pvuorela@iki.fi> on 2012-09-04
Reviewed by Simon Hausmann.

Adapt from deprecated QInputMethod::visible() to isVisible().

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::setInputPanelVisible):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):

12:46 PM Changeset in webkit [127486] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Provide virtual dtor for DumpRenderTreeClient
https://bugs.webkit.org/show_bug.cgi?id=95769

Reviewed by NOBODY (OOPS!).

Also remove WTF prefixes.

  • Api/DumpRenderTreeClient.h:
12:43 PM Changeset in webkit [127485] by tommyw@google.com
  • 16 edits in trunk

MediaStream API: Change the MediaStreamTrackList track added/removed signaling
https://bugs.webkit.org/show_bug.cgi?id=95721

Reviewed by Adam Barth.

Source/Platform:

Adding the signaling to the WebKit interface.

  • chromium/public/WebMediaStreamCenter.h:

(WebKit::WebMediaStreamCenter::didAddMediaStreamTrack):
(WebKit::WebMediaStreamCenter::didRemoveMediaStreamTrack):

Source/WebCore:

This allows the platform implementor to throw an NOT_SUPPORTED_ERR exception if it doesn support these methods.

Patch covered by expanded existing test.

  • Modules/mediastream/MediaStreamTrackList.cpp:

(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):

  • platform/mediastream/MediaStreamCenter.h:

(MediaStreamCenter):

  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:

(WebCore::MediaStreamCenterBlackBerry::didAddMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenterBlackBerry::didRemoveMediaStreamTrack):

  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:

(MediaStreamCenterBlackBerry):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:

(WebCore::MediaStreamCenterChromium::didAddMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::didRemoveMediaStreamTrack):

  • platform/mediastream/chromium/MediaStreamCenterChromium.h:

(MediaStreamCenterChromium):

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:

(WebCore::MediaStreamCenterGStreamer::didAddMediaStreamTrack):
(WebCore::MediaStreamCenterGStreamer::didRemoveMediaStreamTrack):

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:

(MediaStreamCenterGStreamer):

Tools:

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:

(MockWebMediaStreamCenter::didAddMediaStreamTrack):
(MockWebMediaStreamCenter::didRemoveMediaStreamTrack):

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h:

(MockWebMediaStreamCenter):

LayoutTests:

  • fast/mediastream/MediaStreamTrackList.html:
12:35 PM Changeset in webkit [127484] by zoltan@webkit.org
  • 13 edits in trunk/Source

Extend the coverage of the Custom Allocation Framework in WTF and in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=95737

Reviewed by Eric Seidel.

Add WTF_MAKE_FAST_ALLOCATED macro to the following class declarations because these are instantiated by operator new.

Source/JavaScriptCore:

  • wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.
  • heap/MachineStackMarker.cpp:

(MachineThreads::Thread): Thread is instantiated at heap/MachineStackMarker.cpp:196.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(FixedVMPoolExecutableAllocator): FixedVMPoolExecutableAllocator is instantiated at jit/ExecutableAllocatorFixedVMPool.cpp:111

  • parser/SourceProviderCache.h:

(SourceProviderCache): SourceProviderCache is instantiated at parser/SourceProvider.h:49.

  • parser/SourceProviderCacheItem.h:

(SourceProviderCacheItem): SourceProviderCacheItem is instantiated at parser/Parser.cpp:843.

  • runtime/GCActivityCallback.h:

(GCActivityCallback): GCActivityCallback is instantiated at runtime/GCActivityCallback.h:96.

  • tools/CodeProfile.h:

(CodeProfile): CodeProfile is instantiated at JavaScriptCore/tools/CodeProfiling.cpp:140.

Source/WTF:

  • wtf/CryptographicallyRandomNumber.cpp: CryptographicallyRandomNumber is instantiated at wtf/CryptographicallyRandomNumber.cpp:162.
  • wtf/MediaTime.h: MediaTime is instantiated at wtf/MediaTime.cpp:288.
  • wtf/MetaAllocator.h:

(MetaAllocatorTracker): MetaAllocatorTracker is instantiated at JavaScriptCore/tools/CodeProfiling.cpp:120.

  • wtf/ThreadingPthreads.cpp:

(PthreadState): PthreadState is instantiated at wtf/ThreadingPthreads.cpp:165.

  • wtf/text/AtomicString.cpp:

(AtomicStringTable): AtomicStringTable is instantiated at wtf/text/AtomicString.cpp:43.

12:27 PM WebKitGTK/1.10.x edited by jdiggs@igalia.com
(diff)
12:23 PM Changeset in webkit [127483] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject()
https://bugs.webkit.org/show_bug.cgi?id=95740

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Added sanity check to be sure we have a render object prior to seeing if
said object is an anonymous block.

Testing via unit test because a non-flaky layout test crasher could not
be found.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Sanity check for render object added.

Source/WebKit/gtk:

Updated unit test.

  • tests/testatk.c:

(testWebkitAtkComboBox): Added checks that the menu popup in a combo box
has 0 links and, more importantly, that checking doesn't result in a crash.

12:11 PM Changeset in webkit [127482] by ojan@chromium.org
  • 2 edits in trunk/Tools

Elide test names when running new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=95626

Patch by Tony Chang <tony@chromium.org> on 2012-09-04
Reviewed by Dirk Pranke.

When the test name exceeds the number of terminal columns, it leaves
text on the screen. Avoid this by eliding the test name when running
tests. This is similar to what ninja does when compiling.

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream):
(MeteredStream.number_of_columns): Helper method to get number of
terminal columns. Won't work on Win32 python, but meh.

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
because stderr appears to be ascii only.
(Printer.print_started_test): Route through _test_status_line.
(Printer.print_finished_test): Route through _test_status_line.
(Printer._print_test_trace): Route through _test_status_line.
(Printer._print_baseline): Route through _test_status_line.

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(test_test_status_line): Test for _test_status_line.

11:58 AM Changeset in webkit [127481] by commit-queue@webkit.org
  • 3 edits
    2 moves
    3 adds
    3 deletes in trunk

Automatic features should work in sandboxed iframes if "allow-scripts" flag is set
https://bugs.webkit.org/show_bug.cgi?id=93961

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-04
Reviewed by Adam Barth.

Source/WebCore:

Allow automatic features (video autoplay and form control
autofocus) in a sandboxed iframe that has "allow-scripts"
flag set. This behavior is according to the latest
specification at:
http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin

This sandboxed automatic features browsing context flag is
relaxed by the same keyword as scripts, because when
scripts are enabled these features are trivially possible
anyway, and it would be unfortunate to force authors to
use script to do them when sandboxed rather than allowing
them to use the declarative features.

Tests: fast/forms/autofocus-in-sandbox-with-allow-scripts.html

media/auto-play-in-sandbox-with-allow-scripts.html

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::parseSandboxPolicy):

LayoutTests:

Add layout tests to check that automatic features (video
autoplay and form control autofocus) are allowed / working
in sandboxed iframes if the "allow-scripts" flag is set.
This behavior is according to the latest specification at:
http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin

The tests to check that automatic features are blocked in
sandboxed iframes have been removed since they relied on
the "allow-scripts" flag to work.

  • fast/forms/autofocus-in-sandbox-with-allow-scripts-expected.txt: Added.
  • fast/forms/autofocus-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/fast/forms/no-autofocus-in-sandbox.html.
  • fast/forms/no-autofocus-in-sandbox-expected.txt: Removed.
  • media/auto-play-in-sandbox-with-allow-scripts-expected.txt: Added.
  • media/auto-play-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/media/no-auto-play-in-sandbox.html.
  • media/no-auto-play-in-sandbox-expected.txt: Removed.
  • media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html: Added.
  • media/resources/no-auto-play-in-sandbox-iframe.html: Removed.
11:54 AM Changeset in webkit [127480] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Register scrolling layers with ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=78862

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-04
Reviewed by James Robinson.

In order to allow scrollable child layers to be scrolled off the main
thread, register them with the ScrollingCoordinator. These layers are
also removed from the non-fast scrollable region.

Whenever the scroll offset or other scroll geometry related attribute of
a compositor scrolled layer changes, the ScrollingCoordinator is
informed to allow it to update its internal representation of the
scrollable layer.

No tests because the ScrollingCoordinator is currently not testable.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::computeNonFastScrollableRegion): Composited scrolling layers
can be scrolled off the main thread.
(WebCore):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
Callback to ScrollingCoordinator about changes the composited scrolling layers.

  • page/scrolling/ScrollingCoordinator.h:

(WebCore):
(ScrollingCoordinator):

  • page/scrolling/ScrollingCoordinatorNone.cpp:

(WebCore):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::usesCompositedScrolling):

  • rendering/RenderLayer.cpp:

(WebCore):
(WebCore::RenderLayer::usesCompositedScrolling):

  • rendering/RenderLayer.h:

(RenderLayer):
(WebCore::RenderLayer::usesCompositedScrolling):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateScrollingLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::scrollingLayerDidChange):
(WebCore):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

11:46 AM Changeset in webkit [127479] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove uses of ClassInfo from SpeculativeJIT::compileObjectOrOtherLogicalNot
https://bugs.webkit.org/show_bug.cgi?id=95510

Reviewed by Oliver Hunt.

More refactoring to get rid of ClassInfo checks in the DFG.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):

11:45 AM Changeset in webkit [127478] by tony@chromium.org
  • 4 edits in trunk/Tools

Elide test names when running new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=95626

Reviewed by Dirk Pranke.

When the test name exceeds the number of terminal columns, it leaves
text on the screen. Avoid this by eliding the test name when running
tests. This is similar to what ninja does when compiling.

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream):
(MeteredStream.number_of_columns): Helper method to get number of
terminal columns. Won't work on Win32 python, but meh.

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
because stderr appears to be ascii only.
(Printer.print_started_test): Route through _test_status_line.
(Printer.print_finished_test): Route through _test_status_line.
(Printer._print_test_trace): Route through _test_status_line.
(Printer._print_baseline): Route through _test_status_line.

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(test_test_status_line): Test for _test_status_line.

11:42 AM Changeset in webkit [127477] by Lucas Forschler
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Rollout r127322.

11:37 AM Changeset in webkit [127476] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[chromium] Do not allow infinite pending frames in CCFrameRateController
https://bugs.webkit.org/show_bug.cgi?id=94254

Patch by Brian Anderson <brianderson@chromium.org> on 2012-09-04
Reviewed by James Robinson.

Removes support for infinite pending frames in CCFrameRateController
if swap acks are available.

Functionality covered by existing tests.

  • platform/graphics/chromium/cc/CCFrameRateController.cpp:

(WebCore::CCFrameRateController::CCFrameRateController):
(WebCore::CCFrameRateController::setMaxFramesPending):
(WebCore::CCFrameRateController::setSwapBuffersCompleteSupported):
(WebCore):
(WebCore::CCFrameRateController::onTimerTick):
(WebCore::CCFrameRateController::didBeginFrame):
(WebCore::CCFrameRateController::didFinishFrame):

  • platform/graphics/chromium/cc/CCFrameRateController.h:

(CCFrameRateController):

  • platform/graphics/chromium/cc/CCScheduler.cpp:

(WebCore::CCScheduler::setSwapBuffersCompleteSupported):
(WebCore):

  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::initializeRendererOnImplThread):

11:33 AM Changeset in webkit [127475] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Print API missing documentation when generating gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=95703

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-09-04
Reviewed by Carlos Garcia Campos.

Print out API missing documentation when generating gtkdoc. This makes it
easier to fix documentation errors.

  • gtk/generate-gtkdoc:

(print_missing_api): Added.
(generate_doc): Inline the rebase step, since it now reports an error
when you try to rebase without generating documentation first.

  • gtk/gtkdoc.py:

(GTKDoc.rebase_installed_docs): Raise an error when rebasing without
generating documentation first to enable a small cleanup at the caller.
(GTKDoc.api_missing_documentation): Added.

11:31 AM Changeset in webkit [127474] by timothy_horton@apple.com
  • 7 edits
    2 adds in trunk

ASSERTion failure when SVG element is removed from document and readded
https://bugs.webkit.org/show_bug.cgi?id=95517
<rdar://problem/12175583>

Reviewed by Brady Eidson.

Previously, SVG animations would cease to animate when their parent
<svg> element was removed and re-added to the document.

Instead, to match Firefox and Opera, we should continue the animation
with the same beginTime (i.e. the animation continues as if it had never
been removed from the document).

Test: svg/animations/reinserting-svg-into-document.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::insertedInto): Don't call begin() on an already-started SMILTimeContainer().

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::isStarted): Added.

  • svg/animation/SMILTimeContainer.h: Add isStarted().
  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedInto): Always reschedule SVGSMILElements with
their parent SMILTimeContainer when they are inserted into the document, otherwise
they are lost (and never again update) when their subtree is removed and then
readded to the document.

Add a test that ensures that removing an SVG element from the document
and readding it continues SMIL animations.

  • svg/animations/reinserting-svg-into-document.html: Added.
11:08 AM Changeset in webkit [127473] by scheib@chromium.org
  • 8 edits in trunk

[Chromium] Allow asyncronous response of pointer lock requests in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=95628

Reviewed by James Robinson.

Tools:

Future tests need the ability to respond asynchronously that
pointer lock requests have been accepted or rejected. This patch
adds the following:

testRunner.setPointerLockWillRespondAsynchronously();
testRunner.didAcquirePointerLock();
testRunner.didNotAcquirePointerLock();

Tested in existing test:

pointerlockchange-pointerlockerror-events.html

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::didAcquirePointerLock):
(DRTTestRunner::didNotAcquirePointerLock):
(DRTTestRunner::setPointerLockWillRespondAsynchronously):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::requestPointerLock):
(WebViewHost::didAcquirePointerLock):
(WebViewHost::didNotAcquirePointerLock):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):
(WebViewHost::setPointerLockWillRespondAsynchronously):

LayoutTests:

Add testing for testRunner.setPointerLockWillRespondAsynchronously().

  • pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
10:47 AM Changeset in webkit [127472] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[CSS Regions] Destroying a render named flow thread without unregistering left-over content nodes triggered an assertion.
https://bugs.webkit.org/show_bug.cgi?id=95645

Patch by Andrei Bucur <abucur@adobe.com> on 2012-09-04
Reviewed by Abhishek Arya.

Source/WebCore:

This patch cleans up the render named flow thread before destruction by unregistering left-over content nodes.

Tests: fast/regions/moved-content-node-crash.html

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):

LayoutTests:

Simple test case that triggers an ASSERT in debug mode and causes a crash in release.
The ASSERT appears in RenderFlowThreadController::unregisterNamedFlowContentNode
ASSERT(it != m_mapNamedFlowContentNodes.end());

It happens because when a content node is added to an iframe document and then moved back, the iframe's RenderNamedFlowThread is destroyed
without calling unregisterNamedFlowContentNode on the node. This triggers the before mentioned assertion after a lazyAttach and a detach
in the parent document.

  • fast/regions/moved-content-node-crash-expected.txt: Added.
  • fast/regions/moved-content-node-crash.html: Added.
9:50 AM Changeset in webkit [127471] by peter@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium
https://bugs.webkit.org/show_bug.cgi?id=95744

Patch by Koji Ishii <Koji Ishii> on 2012-09-04
Unreviewed build fix, verified by Scott Graham.

The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant
because '/opentype/' was already included to webcore_remaining.
It was not only redundant but also breaks incremental linking.

No new tests are required because no behavior changes.

Patch by Koji Ishii <Koji Ishii> on 2012-09-04

  • WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform.
8:47 AM Changeset in webkit [127470] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection
https://bugs.webkit.org/show_bug.cgi?id=95747

PR199729

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-04
Reviewed by Rob Buis.
Internally Reviewed by Joe Mason.

If the browser has never saved a secure protocol cookie in its mapping before,
and it tries to set and retreive a secure cookie over a non-secure
protocol, it will not show up because the link between the secure and
non-secure mapping isn't created until a cookie (sent through secure) is set.

The fix is to also check for the linkage in getRawCookies. Note that we cannot
map the secure CookieMap to the non-secure one because getRawCookies is a const
function.

Manually tested using our Browser Test suite.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):

8:45 AM Changeset in webkit [127469] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] 0.11 build breaks due to rename of gst_message_new_duration
https://bugs.webkit.org/show_bug.cgi?id=95751

Reviewed by Martin Robinson.

In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
gst_message_new_duration was renamed to
gst_message_new_duration_changed.

However the only place where we used this is in the HTTP source
element and only if appsrc < 0.10.27 is used at runtime. In the
case of GStreamer 1.0 this condition will be always false so we
can disable this code at build time.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::didReceiveResponse):

8:32 AM Changeset in webkit [127468] by vsevik@chromium.org
  • 12 edits in trunk

Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-04
Reviewed by Pavel Feldman.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

  • inspector/styles/protocol-css-regions-commands-expected.txt:
  • inspector/styles/protocol-css-regions-commands.html:
8:11 AM WebKitGTK/1.10.x edited by Martin Robinson
(diff)
6:48 AM Changeset in webkit [127467] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix IDL dependency generation correctly
https://bugs.webkit.org/show_bug.cgi?id=95730

Patch by Jonathan Liu <net147@gmail.com> on 2012-09-04
Reviewed by Csaba Osztrogonác.

IDL dependency generation is still not working after
https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
added after the filename in an echo command end up being added to the
file which isn't handled correctly by preprocess-idls.pl. The problem
is fixed by removing the space after the filename.

  • DerivedSources.pri:
6:43 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:40 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:38 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:38 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
Add proposed merges for 1.9.92 (diff)
6:36 AM Changeset in webkit [127466] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex
https://bugs.webkit.org/show_bug.cgi?id=95618

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Make sure we only emit the the signal for menu lists and list
boxes rendered from actual HTML select elements.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange): We support accessibility
ListBoxes and MenuLists only here, assuming they represent HTML
select elements, which might be not always true (e.g. ARIA). Thus,
check if that condition is true, early returning in other case.

LayoutTests:

New layout test to ensure we don't crash with ATK notifications
anymore when changing the selection in an ARIA listbox.

  • platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
  • platform/gtk/accessibility/aria-listbox-crash.html: Added.
6:34 AM Changeset in webkit [127465] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Cairo] [TextureMapper] Assertion failure in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=95713

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-09-04
Reviewed by Noam Rosenthal.

Fix an assertion failure by returning a valid context always for GraphicsContext3D::platformContext.
This is important because TextureMapperGL uses the platform context to perform hashing.

No new tests. This is covered by existing accelerated compositing tests.

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::platformContext): Return the current GLContext
when getting the platform context for private GraphicsContext3DPrivates that render
to the currently active context.

6:32 AM Changeset in webkit [127464] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
https://bugs.webkit.org/show_bug.cgi?id=86961

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add ecore_x initialisation check before calling ecore_x_bell
to avoid crashes when X server is not running.

  • platform/efl/SoundEfl.cpp:

(WebCore::systemBeep):

LayoutTests:

Unskipped two layout tests that were crashing.

  • platform/efl/TestExpectations:
6:30 AM Changeset in webkit [127463] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL][WK2] CSS3 Media Queries functionality is broken
https://bugs.webkit.org/show_bug.cgi?id=95680

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

In WK2, WebProcess doesn't have access to ewk_view evas object.
Methods that get screen rect or screen depth either return incorrect value or crash.
This patch removes dependency to ewk_view evas object and relies on ecore_x_* functions
to get screen rectangle or color depth of the screen.

  • platform/efl/EflScreenUtilities.cpp: removed unused getPixelDepth method definition
  • platform/efl/EflScreenUtilities.h: removed unsused getPixelDepth method declaration

(WebCore):

  • platform/efl/PlatformScreenEfl.cpp:

(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):

LayoutTests:

Unskipped passing CSS3 Media Query tests.

  • platform/efl-wk2/TestExpectations:
6:20 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:20 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:19 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
6:13 AM Changeset in webkit [127462] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

.: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

  • Source/cmake/OptionsEfl.cmake: Turn on CONTEXT_MENUS flag for EFL port

Source/WebCore: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

  • PlatformEfl.cmake: Removed -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1

Source/WebKit: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

  • PlatformEfl.cmake: Added ContextMenuClientEfl.cpp file to sources list.

Source/WebKit/efl: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

  • WebCoreSupport/ContextMenuClientEfl.cpp: Added.

(WebCore):
(WebCore::ContextMenuClientEfl::contextMenuDestroyed):
(WebCore::ContextMenuClientEfl::getCustomMenuFromDefaultItems):
(WebCore::ContextMenuClientEfl::contextMenuItemSelected):
(WebCore::ContextMenuClientEfl::downloadURL):
(WebCore::ContextMenuClientEfl::lookUpInDictionary):
(WebCore::ContextMenuClientEfl::speak):
(WebCore::ContextMenuClientEfl::isSpeaking):
(WebCore::ContextMenuClientEfl::stopSpeaking):
(WebCore::ContextMenuClientEfl::searchWithGoogle):

  • WebCoreSupport/ContextMenuClientEfl.h: Added.

(WebCore):
(ContextMenuClientEfl):

  • ewk/ewk_contextmenu.cpp: Removed ewk_context_menu_customize implementation.

(ewk_context_menu_destroy): Added freeing context menu.
(ewk_context_menu_new): Added filling ewk_contextmenu list.
(ewk_context_menu_item_append):

  • ewk/ewk_contextmenu_private.h: Removed ewk_context_menu_customize and changed ewk_context_menu_new definition.
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(ewk_view_context_menu_forward_event):

5:51 AM Changeset in webkit [127461] by vsevik@chromium.org
  • 3 edits in trunk/LayoutTests

Web Inspector: Skip inspector WebGL tests where WebGL is disabled
https://bugs.webkit.org/show_bug.cgi?id=95733

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.

This is to update Skipped and TestExpectations files.

  • platform/efl/TestExpectations:
  • platform/win/Skipped:
5:34 AM Changeset in webkit [127460] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=95725

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-04

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
5:30 AM Changeset in webkit [127459] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Bugfix: wrong texture binding target in replay for 3D textures
https://bugs.webkit.org/show_bug.cgi?id=95687

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.

gl.bindTexture accepts either TEXTURE_2D or TEXTURE_CUBE_MAP targets, but we tried to replay with TEXTURE_CUBE_MAP_POSITIVE_X and others for 3D textures.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

5:11 AM Changeset in webkit [127458] by Carlos Garcia Campos
  • 25 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore

Revert r127442 (Merge r126715)

Patch causes crashes and makes inspector unit tests to fail in both
WebKit1 and WebKit2

5:05 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
4:56 AM Changeset in webkit [127457] by allan.jensen@nokia.com
  • 22 edits
    7 adds in trunk

Allow child-frame content in hit-tests.
https://bugs.webkit.org/show_bug.cgi?id=95204

.:

Reviewed by Antonio Gomes.

Update exported symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

Reviewed by Antonio Gomes.

Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
it is now handled by the hit test itself controlled by the AllowChildFrameContent
flag in HitTestRequest.

Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html

touchadjustment/iframe-boundary.html

  • WebCore.exp.in:
  • WebCore.order:
  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • dom/Document.h:

(Document):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • rendering/HitTestRequest.h:

(WebCore::HitTestRequest::allowChildFrameContent):
(WebCore::HitTestRequest::childFrameHitTest):
(WebCore::HitTestRequest::testChildFrameScrollBars):

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::nodeAtPoint):
(WebCore):

  • rendering/RenderFrameBase.h:

(RenderFrameBase):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

Reviewed by Antonio Gomes.

Update symbols for the Windows build-system.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Reviewed by Antonio Gomes.
Touch-Adjustment test by Kevin Ellis

Two new tests for hit-testing child frame content. One for testing it as an option to
nodesFromRect, and one testing its improvement on touch adjustment on iframe boundaries.

  • fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Added.
  • fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Added.
  • fast/dom/nodesFromRect/resources/child-frame.html: Added.
  • fast/dom/nodesFromRect/resources/nodesFromRect.js:

(check):
(checkShadowContent):
(checkRect):
(nodesFromRectAsString):

  • touchadjustment/iframe-boundary-expected.txt: Added.
  • touchadjustment/iframe-boundary.html: Added.
  • touchadjustment/resources/inner-content-page.html: Added.
  • touchadjustment/resources/inner-navigation-frame.html: Added.
4:52 AM Changeset in webkit [127456] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed tests fix.

  • http/tests/inspector/workspace-test.js:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
4:25 AM Changeset in webkit [127455] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build error in NetworkStateNotifierEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=95724

Unreviewed EFL build fix.

Make sure <sys/socket.h> is included before
<linux/netlink.h> to fix build errors on some
systems (e.g. Ubuntu 11.10).

No new tests, no behavior change.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-04

  • platform/network/efl/NetworkStateNotifierEfl.cpp:
3:48 AM Changeset in webkit [127454] by vsevik@chromium.org
  • 22 edits
    1 move
    5 adds
    2 deletes in trunk

Web Inspector: Create JavaScriptSources based on network resources.
https://bugs.webkit.org/show_bug.cgi?id=95352

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
Removed rawSourceCode as it was not needed anymore.

Tests: inspector/debugger/network-uisourcecode-provider.html

inspector/debugger/resource-script-mapping.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._populate):
(WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):

  • inspector/front-end/RawSourceCode.js:
  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._reset):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.setSourceMapping):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/Workspace.js: Drive-by: fixed duplicating uiSourceCodes in workspace.
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

Removed raw-source-code.html test as RawSourceCode was removed by this patch.
Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
Updated dynamic-script-tag.html to better match expected behavior.

  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/workspace-test.js: Added.

(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
(initialize_WorkspaceTest):

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
  • inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
  • inspector/debugger/network-uisourcecode-provider.html: Added.
  • inspector/debugger/raw-source-code-expected.txt: Removed.
  • inspector/debugger/raw-source-code.html: Removed.
  • inspector/debugger/resource-script-mapping-expected.txt: Added.
  • inspector/debugger/resource-script-mapping.html: Added.
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-frame-count.html:
3:38 AM Changeset in webkit [127453] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r127447.
http://trac.webkit.org/changeset/127447
https://bugs.webkit.org/show_bug.cgi?id=95726

Mistake, did not reliably pass yet. (Requested by drott on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-04

  • platform/efl/TestExpectations:
2:37 AM Changeset in webkit [127452] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards
https://bugs.webkit.org/show_bug.cgi?id=95443

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Save gl.getError() status before taking the GL snapshot and restore it afterwards.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

LayoutTests:

Adds a test to check that we properly save the WebGL getError() status while doing the instrumentation.

  • inspector/profiler/webgl/webgl-profiler-get-error-expected.txt: Added.
  • inspector/profiler/webgl/webgl-profiler-get-error.html: Added.
  • inspector/profiler/webgl/webgl-profiler-test.js: Added.

(initialize_WebGLProfilerTest.InspectorTest.enableWebGLAgent):
(initialize_WebGLProfilerTest):
(createWebGLContext):

2:25 AM Changeset in webkit [127451] by commit-queue@webkit.org
  • 2 edits in trunk

[CMAKE] Update cmakeconfig.h.cmake
https://bugs.webkit.org/show_bug.cgi?id=95712

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-04
Reviewed by Gyuyoung Kim.

Update feature definitions which are missing compared to WebKitFeatures.cmake

  • Source/cmakeconfig.h.cmake:
2:20 AM Changeset in webkit [127450] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] REGRESSION(r127321): It made 3 notification test timeout
https://bugs.webkit.org/show_bug.cgi?id=95638

Patch by Jon Lee <jonlee@apple.com> on 2012-09-04
Reviewed by Csaba Osztrogonác.

Dispatch show event instead of display after r127321.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::sendDisplayEvent):

1:55 AM Changeset in webkit [127449] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: More directional control characters for debugging in inspector
https://bugs.webkit.org/show_bug.cgi?id=95696

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Entities for text directionality-related characters added (LRE, RLE, LRO, RLO, PDF).

  • inspector/front-end/ElementsTreeOutline.js:

LayoutTests:

  • inspector/elements/elements-panel-structure-expected.txt:
  • inspector/elements/elements-panel-structure.html:
1:53 AM Changeset in webkit [127448] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: new CPU Profiles are not shown after reattach
https://bugs.webkit.org/show_bug.cgi?id=95686

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::restore): set m_headersRequested flags
to true and clear all profiles on the front-end since there are no
collected profiles yet immediately after render process sitching.

1:53 AM EFLWebKit edited by tmpsantos@gmail.com
(diff)
1:39 AM Changeset in webkit [127447] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Removing http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
from skipped crashers section, after https://bugs.webkit.org/show_bug.cgi?id=94458#c14

  • platform/efl/TestExpectations: Previously crashing test removed.
1:38 AM Changeset in webkit [127446] by Carlos Garcia Campos
  • 20 edits
    6 adds in releases/WebKitGTK/webkit-1.10

Merge r127070 - Source/WebCore: [Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070

Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.

Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

Test: fast/events/continuous-platform-wheelevent-in-scrolling-div.html

  • platform/gtk/PlatformWheelEventGtk.cpp:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

Source/WebKit/gtk: [Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070

Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.

Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

  • webkit/webkitwebview.cpp:

(webkit_web_view_realize):

Source/WebKit2: [Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070

Gtk 3.3.18 added smooth scroll events, adding a new scroll direction that
provides detailed delta information.

Added GDK_SMOOTH_SCROLL_MASK to the events listened, and added
code to process properly the new direction GDK_SCROLL_SMOOTH and
its deltas.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

  • Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebWheelEvent):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize):

Tools: [Gtk] Process Gtk 3.4 smooth scroll events properly
https://bugs.webkit.org/show_bug.cgi?id=88070

Added continousMouseScrollBy support in WebKitTestRunner, and added
implementation for gtk, and stub for Qt, mac and EFL.

Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
scroll for emulating multi-tick mouseScrollBy events.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/EventSender.cpp:

(mouseScrollByCallback):
(continuousMouseScrollByCallback):

  • WebKitTestRunner/EventSenderProxy.h:

(EventSenderProxy):

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::mouseScrollBy):
(WTR):
(WTR::EventSendingController::continuousMouseScrollBy):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:

(EventSendingController):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::continuousMouseScrollBy):

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR):
(WTR::EventSenderProxy::continuousMouseScrollBy):

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::continuousScrollBy):

  • WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::continuousMouseScrollBy):
(WTR):

LayoutTests: [Gtk] Process Gtk 3.4 smooth scroll events properly.
https://bugs.webkit.org/show_bug.cgi?id=88070

Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
scroll for emulating multi-tick mouseScrollBy events.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-29
Reviewed by Martin Robinson.

  • platform/gtk-wk2/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/gtk-wk2/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/gtk/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
1:38 AM Changeset in webkit [127445] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add webplatform and browser to build info
https://bugs.webkit.org/show_bug.cgi?id=95715

Reviewed by George Staikos.

PR# 202102

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::buildPage):

1:31 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
1:27 AM Changeset in webkit [127444] by ryuan.choi@samsung.com
  • 6 edits in trunk/Source

[EFL] Drop default theme concept
https://bugs.webkit.org/show_bug.cgi?id=94778

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

  • ewk/ewk_view.h:

Updated doxygen document not to mention default theme.

Source/WebKit2:

  • PlatformEfl.cmake: Removed DEFAULT_THEME_PATH definitions.
  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_initialize): Removed default theme concept.

  • UIProcess/API/efl/ewk_view.h:

Updated doxygen document not to mention default theme.

1:23 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
1:19 AM Changeset in webkit [127443] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: NMI: cosmetic change, rename m_domMemoryUsage to m_memoryInstrumentation.
https://bugs.webkit.org/show_bug.cgi?id=95716

Also m_memoryInstrumentation became a reference to external object because it has other life time than domNodeVisitor.

Reviewed by Yury Semikhatsky.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):
(WebCore::collectDomTreeInfo):

12:25 AM Changeset in webkit [127442] by Carlos Garcia Campos
  • 25 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore

Merge r126715 - Array type checks and storage accesses should be uniformly represented and available to CSE
https://bugs.webkit.org/show_bug.cgi?id=95013

Reviewed by Oliver Hunt.

This uniformly breaks up all array accesses into up to three parts:

1) The type check, using a newly introduced CheckArray node, in addition to possibly

a CheckStructure node. We were already inserting the CheckStructure prior to this
patch. The CheckArray node will be automatically eliminated if the thing it was
checking for had already been checked for, either intentionally (a CheckStructure
inserted based on the array profile of this access) or accidentally (some checks,
typically a CheckStructure, inserted for some unrelated operations). The
CheckArray node may not be inserted if the array type is non-specific (Generic or
ForceExit).

2) The storage load using GetIndexedPropertyStorage. Previously, this only worked for

GetByVal. Now it works for all array accesses. The storage load may not be
inserted if the mode of array access does not permit CSE of storage loads (like
non-specific modes or Arguments).

3) The access itself: one of GetByVal, PutByVal, PutByValAlias, ArrayPush, ArrayPop,

GetArrayLength, StringCharAt, or StringCharCodeAt.

This means that the type check can be subjected to CSE even if the CFA isn't smart
enough to reason about it (yet!). It also means that the storage load can always be
subjected to CSE; previously CSE on storage load only worked for array loads and not
other forms of access. Finally, it removes the bizarre behavior that
GetIndexedPropertyStorage previously had: previously, it was responsible for the type
check in some cases, but not others; this made reasoning about the CFA really
confusing.

This change also disables late refinement of array mode, since I decided that
supporting that feature is both confusing and likely unprofitable. The array modes are
now locked in in the first fixup run after prediction propagation. Of course,
refinements from Generic to something else would not have been a problem; we could
reenable those if we thought we really needed to.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::fromStructure):
(DFG):
(JSC::DFG::refineArrayMode):

  • dfg/DFGArrayMode.h:

(DFG):
(JSC::DFG::modeIsJSArray):
(JSC::DFG::lengthNeedsStorage):
(JSC::DFG::modeIsSpecific):
(JSC::DFG::modeSupportsLength):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayMode):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::checkStructureElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::performCSE):

  • dfg/DFGCSEPhase.h:

(DFG):

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(FixupPhase):
(JSC::DFG::FixupPhase::blessArrayOperation):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(DFG):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::collectGarbage):

  • dfg/DFGGraph.h:

(Graph):
(JSC::DFG::Graph::vote):
(JSC::DFG::Graph::substitute):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArrayMode):
(JSC::DFG::Node::setArrayMode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

12:08 AM Changeset in webkit [127441] by Carlos Garcia Campos
  • 28 edits
    2 deletes in releases/WebKitGTK/webkit-1.10

Merge r127228 - Unreviewed, rolling out r126127.
http://trac.webkit.org/changeset/126127

This breaks gobject bindings.

Source/WebCore:

  • dom/Attr.cpp:

(WebCore::Attr::cloneNode):

  • dom/Attr.h:
  • dom/CDATASection.cpp:

(WebCore::CDATASection::cloneNode):

  • dom/CDATASection.h:

(CDATASection):

  • dom/Comment.cpp:

(WebCore::Comment::cloneNode):

  • dom/Comment.h:

(Comment):

  • dom/Document.cpp:

(WebCore::Document::cloneNode):

  • dom/Document.h:

(Document):

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::cloneNode):

  • dom/DocumentFragment.h:

(DocumentFragment):

  • dom/DocumentType.cpp:

(WebCore::DocumentType::cloneNode):

  • dom/DocumentType.h:

(DocumentType):

  • dom/Element.cpp:

(WebCore::Element::cloneNode):

  • dom/Element.h:

(Element):

  • dom/EntityReference.cpp:

(WebCore::EntityReference::cloneNode):

  • dom/EntityReference.h:

(EntityReference):

  • dom/Node.h:

(Node):

  • dom/Node.idl:
  • dom/Notation.cpp:

(WebCore::Notation::cloneNode):

  • dom/Notation.h:

(Notation):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::cloneNode):

  • dom/ProcessingInstruction.h:

(ProcessingInstruction):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::cloneNode):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • dom/Text.cpp:

(WebCore::Text::cloneNode):

  • dom/Text.h:

(Text):

LayoutTests:

  • fast/dom/shadow/shadowroot-clonenode-expected.txt: Removed.
  • fast/dom/shadow/shadowroot-clonenode.html: Removed.
12:08 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)

Sep 3, 2012:

11:37 PM Changeset in webkit [127440] by Simon Hausmann
  • 4 edits in trunk/Source/WebCore

[Qt] Port the Qt pixmap JS bindings to use the JSC C API
https://bugs.webkit.org/show_bug.cgi?id=94702

Reviewed by Kenneth Rohde Christiansen.

Based on patch by Noam Rosenthal.

The conversion uses a simple JSClassRef based binding and only a few
uses of private JSC API for the HTML element DOM bindings remain.

This is essentially used for wrapping QPixmap and QImage types in
JavaScript and the other way around, for retrieving the image data
out of a HTML image element when converting from JS/DOM to Qt.

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::copyPixels):
(JSC::Bindings::toPixmap):
(JSC::Bindings::toImage):
(JSC::Bindings::imageSizeForVariant):
(JSC::Bindings::getPixmapWidth):
(JSC::Bindings::getPixmapHeight):
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::pixmapToImageData):
(JSC::Bindings::pixmapToDataUrl):
(JSC::Bindings::pixmapToString):
(JSC::Bindings::QtPixmapRuntime::toJS):
(JSC::Bindings::QtPixmapRuntime::toQt):
(JSC::Bindings::QtPixmapRuntime::canHandle):
(JSC::Bindings::QtPixmapRuntime::getClassRef):

  • bridge/qt/qt_pixmapruntime.h:

(QtPixmapRuntime):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

10:26 PM Changeset in webkit [127439] by noel.gordon@gmail.com
  • 2 edits
    5 deletes in trunk/LayoutTests

http/tests/incremental/partial-jpeg.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82480

Reviewed by Kent Tamura.

Remove this test: we have a more robust partial load test now in
http/tests/images/jpg-img-partial-load.html

  • http/tests/incremental/partial-jpeg-expected.png: Removed.
  • http/tests/incremental/partial-jpeg-expected.txt: Removed.
  • http/tests/incremental/partial-jpeg.html: Removed.
  • http/tests/incremental/resources/checkerboard.jpg: Removed.
  • http/tests/incremental/resources/partial-jpeg.php: Removed.
  • platform/chromium/TestExpectations:
7:19 PM Changeset in webkit [127438] by kling@webkit.org
  • 7 edits in trunk/Source/WebCore

Share immutable ElementAttributeData between elements with identical attributes.
<http://webkit.org/b/94990>

Reviewed by Antti Koivisto.

Keep a cache of ElementAttributeData objects for a given set of attributes and reuse
them in elements with identical attribute maps. ElementAttributeData is made ref-counted
to facilitate this. A copy-on-write mechanism is already in place, since mutating call
sites have to go via Element::mutableAttributeData().

The cache is held by Document and cleared in Document::finishedParsing() since the vast
majority of immutable ElementAttributeData will be constructed during parsing.

On the HTML5 spec at <http://whatwg.org/c/>, we get a cache hit rate of nearly 80%,
translating into a 3.5MB reduction in memory use.

  • dom/Document.cpp:

(WebCore::Document::finishedParsing):
(ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheEntry):
(WebCore::Document::cachedImmutableAttributeData):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):

  • dom/Element.h:
  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::ElementAttributeData):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::create):
(ElementAttributeData):
(WebCore::ElementAttributeData::makeMutable):

7:09 PM Changeset in webkit [127437] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: the URL of worker inspector window sometimes is invalid
https://bugs.webkit.org/show_bug.cgi?id=95334

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-09-03
Reviewed by Pavel Feldman.

In "_openInspectorWindow", before "&dedicatedWorkerId=" should have a '?' to make the whole URL valid.

No new tests case for this bug.

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager.prototype._openInspectorWindow):

6:44 PM Changeset in webkit [127436] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[EFL] Fix e_dbus_shutdown() error when exiting the Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=95636

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.

Source/WebCore:

Check if the m_timer is active in stopUpdating()
to know the BatteryProvider is updating or not.
By checking the timer, stopUpdating() will be called
only BatteryProviderEfl is updating.

  • platform/efl/BatteryProviderEfl.cpp:

(WebCore::BatteryProviderEfl::stopUpdating):

Source/WebKit/efl:

Invoke stopUpdating() in the destructor of BatteryClinetEfl()
to call e_ukit_shutdown() and e_dbus_shutdown() if and when
stopUpdating() has not been called explicitly.

  • WebCoreSupport/BatteryClientEfl.cpp:

(BatteryClientEfl::~BatteryClientEfl):

  • WebCoreSupport/BatteryClientEfl.h:

(BatteryClientEfl):

6:40 PM Changeset in webkit [127435] by bashi@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r127410

Removed further platform-specific text expectations.

  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
6:21 PM Changeset in webkit [127434] by commit-queue@webkit.org
  • 4 edits in trunk

[WK2][WTR] Implement WebKitEnableCaretBrowsing attribute in testRunner.overridePreference
https://bugs.webkit.org/show_bug.cgi?id=95576

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-03
Reviewed by Maciej Stachowiak.

Added a line of macro to implement WebKitEnableCaretBrowsing attribute in testRunner.overridePreference

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

LayoutTests:

  • platform/wk2/Skipped: Removed fast/repaint/no-caret-repaint-in-non-content-editable-element.html test case.
3:39 PM Changeset in webkit [127433] by bashi@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

[Chromium] Unreviewed test expectations update after r127410

  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
12:14 PM Changeset in webkit [127432] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebKit2

[Qt] Not all activated elements highlighted, but some frames are
https://bugs.webkit.org/show_bug.cgi?id=95683

Reviewed by Kenneth Rohde Christiansen.

Use the new function Node::willRespondToMouseClickEvents to better determine if the element
can be tap-activated and avoid documents and frames completely.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

12:14 PM WebKitGTK/1.10.x edited by Carlos Garcia Campos
r127124 merged (diff)
11:38 AM Changeset in webkit [127431] by ryuan.choi@samsung.com
  • 3 edits in trunk/Tools

[EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=95689

Reviewed by Kenneth Rohde Christiansen.

In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
So, there are bugs that key events are always generated in url bar although
the user clicked the web view.

This patch recovers the focus of the web view when left button is pressed and
adds for MiniBrowser to toggle the focus when middle button is pressed
like EWebLauncher already did.

  • EWebLauncher/main.c:

(on_mouse_down):

  • MiniBrowser/efl/main.c:

(on_mouse_down):
(browserCreate):

11:37 AM Changeset in webkit [127430] by commit-queue@webkit.org
  • 5 edits in trunk

Added ANDROID_GDBSERVER definition for Ant
https://bugs.webkit.org/show_bug.cgi?id=95265

Patch by Tao Bai <michaelbai@chromium.org> on 2012-09-03
Reviewed by Adam Barth.

ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
is only used for finding the gdbserver.

Source/WebKit/chromium:

  • WebKitUnitTests.gyp:

Tools:

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
10:16 AM Changeset in webkit [127429] by commit-queue@webkit.org
  • 19 edits
    3 adds
    6 deletes in trunk

Unreviewed, rolling out r127427.
http://trac.webkit.org/changeset/127427
https://bugs.webkit.org/show_bug.cgi?id=95695

Breaks some inspector/debugger tests on JSC (Requested by
vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-03

Source/WebCore:

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/NetworkUISourceCodeProvider.js: Removed.
  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._shouldBindScriptToContentProvider):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
(WebInspector.ResourceScriptMapping.prototype._reset):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/StylesUISourceCodeProvider.js: Added.

(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype._populate):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype._reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/workspace-test.js: Removed.
  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
  • inspector/debugger/network-uisourcecode-provider-expected.txt: Removed.
  • inspector/debugger/network-uisourcecode-provider.html: Removed.
  • inspector/debugger/raw-source-code-expected.txt: Added.
  • inspector/debugger/raw-source-code.html: Added.
  • inspector/debugger/resource-script-mapping-expected.txt: Removed.
  • inspector/debugger/resource-script-mapping.html: Removed.
  • inspector/debugger/scripts-panel.html:
9:50 AM Changeset in webkit [127428] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
9:45 AM WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
9:44 AM WebKitGTK/1.8.x edited by sergio@webkit.org
(diff)
9:34 AM Changeset in webkit [127427] by vsevik@chromium.org
  • 19 edits
    1 move
    5 adds
    2 deletes in trunk

Web Inspector: Create JavaScriptSources based on network resources.
https://bugs.webkit.org/show_bug.cgi?id=95352

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
Removed rawSourceCode as it was not needed anymore.

Tests: inspector/debugger/network-uisourcecode-provider.html

inspector/debugger/resource-script-mapping.html

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource):

  • inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._populate):
(WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):

  • inspector/front-end/RawSourceCode.js:
  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._reset):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.setSourceMapping):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

LayoutTests:

Removed raw-source-code.html test as RawSourceCode was removed by this patch.
Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
Updated dynamic-script-tag.html to better match expected behavior.

  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/workspace-test.js: Added.

(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
(initialize_WorkspaceTest):

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/dynamic-script-tag-expected.txt:
  • inspector/debugger/dynamic-script-tag.html:
  • inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
  • inspector/debugger/network-uisourcecode-provider.html: Added.
  • inspector/debugger/raw-source-code-expected.txt: Removed.
  • inspector/debugger/raw-source-code.html: Removed.
  • inspector/debugger/resource-script-mapping-expected.txt: Added.
  • inspector/debugger/resource-script-mapping.html: Added.
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/source-frame-count.html:
9:09 AM Changeset in webkit [127426] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Make the injected resourceObject property non-enumerable
https://bugs.webkit.org/show_bug.cgi?id=95682

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-03
Reviewed by Pavel Feldman.

Make the injected auxiliary property resourceObject non-enumerable to hide it from for..in iterations.
Ideally this property should be completely hidden from the user's code.
Drive-by: Fix couple of small FIXME's.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

9:08 AM Changeset in webkit [127425] by tommyw@google.com
  • 25 edits
    2 copies
    5 adds in trunk

MediaStream API: Add Ice-related functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95565

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebRTCICECandidateDescriptor.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandlerClient.h.

(WebCore):
(WebKit):
(WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::~WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::operator=):
(WebKit::WebRTCICECandidateDescriptor::isNull):

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCPeerConnectionHandlerClient.h:

(WebKit):
(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

Adds all Ice-related functionality to RTCPeerConnection, including
events, callbacks and methods.

Test: fast/mediastream/RTCPeerConnection-ice.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCIceCandidateEvent.cpp: Added.

(WebCore):
(WebCore::RTCIceCandidateEvent::create):
(WebCore::RTCIceCandidateEvent::RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::~RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::candidate):
(WebCore::RTCIceCandidateEvent::interfaceName):

  • Modules/mediastream/RTCIceCandidateEvent.h: Added.

(WebCore):
(RTCIceCandidateEvent):

  • Modules/mediastream/RTCIceCandidateEvent.idl: Added.
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::updateIce):
(WebCore):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::iceState):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::didGenerateIceCandidate):
(WebCore::RTCPeerConnection::didChangeIceState):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeIceState):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/EventNames.in:
  • platform/chromium/support/WebRTCICECandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp.

(WebKit):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::assign):
(WebKit::WebRTCICECandidateDescriptor::reset):
(WebKit::WebRTCICECandidateDescriptor::initialize):
(WebKit::WebRTCICECandidateDescriptor::operator PassRefPtr<WebCore::RTCIceCandidateDescriptor>):
(WebKit::WebRTCICECandidateDescriptor::candidate):
(WebKit::WebRTCICECandidateDescriptor::sdpMid):
(WebKit::WebRTCICECandidateDescriptor::sdpMLineIndex):

  • platform/mediastream/RTCIceCandidateDescriptor.h:

(WebCore::RTCIceCandidateDescriptor::candidate):
(WebCore::RTCIceCandidateDescriptor::sdpMid):
(WebCore::RTCIceCandidateDescriptor::sdpMLineIndex):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/RTCPeerConnectionHandlerClient.h:

(WebCore):
(RTCPeerConnectionHandlerClient):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::updateIce):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::addIceCandidate):
(WebCore::RTCPeerConnectionHandlerChromium::didGenerateICECandidate):
(WebCore::RTCPeerConnectionHandlerChromium::didChangeICEState):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(WebKit):
(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:

Tools:

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::updateICE):
(MockWebRTCPeerConnectionHandler::addICECandidate):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-ice-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-ice.html: Added.
8:59 AM Changeset in webkit [127424] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge r127124 - 1.9.90 drops symbols, breaking compatibility
https://bugs.webkit.org/show_bug.cgi?id=93477

Patch by Xan Lopez <xlopez@igalia.com> on 2012-08-30
Reviewed by Martin Robinson.

Add a bunch of compatibility methods to the GObject DOM bindings
to cope with recent renames.

  • bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_html_element_get_class_list):
(webkit_dom_element_get_webkit_region_overflow):
(webkit_dom_webkit_named_flow_get_content_nodes):
(webkit_dom_webkit_named_flow_get_regions_by_content_node):

  • bindings/gobject/WebKitDOMCustom.h:
8:19 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
Fix initial branch revision (diff)
7:57 AM Changeset in webkit [127423] by allan.jensen@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r127421

  • rendering/HitTestResult.cpp:

(WebCore::HitTestLocation::HitTestLocation):

7:48 AM Changeset in webkit [127422] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk/Source/WebKit2

[EFL][WK2] Add ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=91206

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.

Add the ewk_settings which wraps the WKPreferencesRef.
The ewk_settings will be created by the ewk_view and it will be
destroyed when the ewk_view is destroyed. I make each view to have
its own group to make one ewk_settings sets preferences only for
one ewk_view.
The application can get the ewk_settings from ewk_view using
ewk_view_settings_get() API.

  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/ewk_settings.cpp: Added.

(ewk_settings_enable_scripts_set):
(ewk_settings_enable_scripts_get):
(ewk_settings_auto_load_images_set):
(ewk_settings_auto_load_images_get):

  • UIProcess/API/efl/ewk_settings.h: Added.
  • UIProcess/API/efl/ewk_settings_private.h: Added.

(_Ewk_Settings):
(_Ewk_Settings::_Ewk_Settings):

  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_initialize):
(ewk_view_settings_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp: Added.

(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

7:41 AM Changeset in webkit [127421] by allan.jensen@nokia.com
  • 17 edits in trunk/Source/WebCore

Move AllowShadowContent flag to HitTestRequest
https://bugs.webkit.org/show_bug.cgi?id=95685

Reviewed by Antonio Gomes.

Moves the flag and updates the interface for HitTestResult::addNodeToRectBasedTestResult so that
it can read the flag from HitTestRequest instead of from HitTestResult.

No change in functionality. No new tests.

  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • rendering/HitTestRequest.h:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):

  • rendering/HitTestResult.h:

(HitTestLocation):
(HitTestResult):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::nodeAtPoint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::nodeAtPoint):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::nodeAtPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::nodeAtPoint):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::nodeAtPoint):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::nodeAtPoint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::nodeAtPoint):

7:15 AM Changeset in webkit [127420] by allan.jensen@nokia.com
  • 3 edits in trunk/Source/WebKit2

Wheel-events fails temporarily after reload
https://bugs.webkit.org/show_bug.cgi?id=94934

Reviewed by Kenneth Rohde Christiansen.

Set fixed visible content rect using visibleContentBounds instead of WebPage::size. Otherwise the
content rect will be incorrectly set to the entire document size, when resizesToContents is active.

Test: UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml

  • UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

7:01 AM Changeset in webkit [127419] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] Use WebKitVersion.h to get version information
https://bugs.webkit.org/show_bug.cgi?id=95669

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.

.:

WEBKIT_USER_AGENT_MAJOR_VERSION and WEBKIT_USER_AGENT_MINOR_VERSION
are defined as constant in the OptionsEfl.cmake. But we do not need
to define these here but can use the defined constant in WebKitVersion.h.

WebKitVersion.h is already generated with the version information
from the Source/WebCore/Configurations/Version.xcconfig.

  • Source/cmake/OptionsEfl.cmake: Do not set WEBKIT_USER_AGENT_* variables.
  • Source/cmakeconfig.h.cmake: Remove WEBKIT_USER_AGENT_* definitions

as no more port uses.

Source/WebKit/efl:

Use WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION
in the WebKitVersion.h

Relocate the StorageTracker.h to keep the sorted order.

  • ewk/ewk_settings.cpp:

(ewk_settings_default_user_agent_get):

Source/WebKit2:

Use WEBKIT_MAJOR_VERSION and WEBKIT_MINOR_VERSION
in the WebKitVersion.h

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::standardUserAgent):

6:22 AM Changeset in webkit [127418] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: Unhide hidden characters
https://bugs.webkit.org/show_bug.cgi?id=93888

Reviewed by Pavel Feldman.

Source/WebCore:

Certain invisible characters will be rendered as HTML entity references in the DOM tree to make them visible to the user.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):

LayoutTests:

  • inspector/elements/elements-panel-structure-expected.txt:
  • inspector/elements/elements-panel-structure.html:
6:20 AM Changeset in webkit [127417] by pfeldman@chromium.org
  • 11 edits
    1 move in trunk/Source/WebCore

Web Inspector: rename JavaScriptContextManager to RuntimeModel for consistency.
https://bugs.webkit.org/show_bug.cgi?id=95677

Reviewed by Yury Semikhatsky.

  • renamed the file and the usages
  • renamed isolatedContextCreated to executionContextCreated for consistency.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/Inspector.json:
  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::notifyContextCreated):

  • inspector/compile-front-end.py:
  • inspector/front-end/RuntimeModel.js: Renamed from Source/WebCore/inspector/front-end/JavaScriptContextManager.js.

(WebInspector.RuntimeModel):
(WebInspector.RuntimeModel.prototype._frameAdded):
(WebInspector.RuntimeModel.prototype._frameDetached):
(WebInspector.RuntimeModel.prototype._executionContextCreated):
(WebInspector.RuntimeDispatcher):
(WebInspector.RuntimeDispatcher.prototype.executionContextCreated):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
4:53 AM WebKitGTK/1.10.x edited by mario@webkit.org
(diff)
4:17 AM WebKitGTK/1.10.x edited by Carlos Garcia Campos
(diff)
3:44 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Further update on 2010/2013. (diff)
3:43 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Update ICU(*) columns for BA class. Add issue needing verification. (diff)
3:26 AM Changeset in webkit [127416] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Unskipping message-port-close.html after bug 85811 was resolved.

  • platform/efl/TestExpectations:
2:56 AM Changeset in webkit [127415] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: use linkifyResourceAsNode, not linkifyLocation when linkifying resources in Timeline
https://bugs.webkit.org/show_bug.cgi?id=95540

Reviewed by Pavel Feldman.

Linkify recource details using WebInspector.linkifyResourceAsNode(), so these bypass linkifier. Also
fix closure compiler warning.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):

2:45 AM Changeset in webkit [127414] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: fixed front-end compilation warnings.
Not reviewed.

  • inspector/front-end/FilteredItemSelectionDialog.js:
  • inspector/front-end/HeapSnapshotView.js:
2:42 AM Changeset in webkit [127413] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: paint grid on top of box highlight.
https://bugs.webkit.org/show_bug.cgi?id=95676

Reviewed by Alexander Pavlov.

Otherwise, ruler numbers are not visible when selecting body.

  • inspector/InspectorOverlayPage.html:
1:54 AM Changeset in webkit [127412] by pfeldman@chromium.org
  • 6 edits in trunk

Web Inspector: get rid of context execution id fallback.
https://bugs.webkit.org/show_bug.cgi?id=95567

Reviewed by Yury Semikhatsky.

Source/WebCore:

We now assign execution context id upon changes in the UI.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype._contextAdded):
(WebInspector.ConsoleView.prototype._addContextList):
(WebInspector.ConsoleView.prototype._contextListRemoved):
(WebInspector.ConsoleView.prototype._updateExecutionContextSelector):
(WebInspector.ConsoleView.prototype._appendExecutionContextOption):
(WebInspector.ConsoleView.prototype._executionContextChanged):
(WebInspector.ConsoleView.prototype._contextListUpdated):
(WebInspector.ConsoleView.prototype._addedExecutionContext):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow.evalCallback):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
(WebInspector.ConsoleView.prototype._enterKeyPressed):

  • inspector/front-end/JavaScriptContextManager.js:

(WebInspector.JavaScriptContextManager):
(WebInspector.JavaScriptContextManager.prototype.contextLists):
(WebInspector.JavaScriptContextManager.prototype.contextByFrameAndSecurityOrigin):
(WebInspector.JavaScriptContextManager.prototype._frameAdded):
(WebInspector.JavaScriptContextManager.prototype._frameNavigated):
(WebInspector.JavaScriptContextManager.prototype._frameDetached):
(WebInspector.JavaScriptContextManager.prototype.isolatedContextCreated):
(WebInspector.FrameExecutionContextList):
(WebInspector.FrameExecutionContextList.prototype._frameNavigated):
(WebInspector.FrameExecutionContextList.prototype._addExecutionContext):
(WebInspector.FrameExecutionContextList.prototype.executionContexts):
(WebInspector.FrameExecutionContextList.prototype.contextBySecurityOrigin):

LayoutTests:

  • http/tests/inspector/console-cd-completions.html:
  • http/tests/inspector/console-cd.html:
1:50 AM Changeset in webkit [127411] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

[EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=95670

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
Reviewed by Kenneth Rohde Christiansen.

Fix layout issues related to the URL bar in Minibrowser
and EWebLauncher when the window is resized.

The URL bar was not resized accordingly and the Web
page was moved behing the URL bar, hiding part of it.

  • EWebLauncher/main.c:

(on_ecore_evas_resize):
(closeWindow):

  • EWebLauncher/url_bar.c:

(url_bar_width_set):
(url_bar_add):

  • EWebLauncher/url_bar.h:
  • MiniBrowser/efl/main.c:

(on_ecore_evas_resize):
(main):

1:39 AM Changeset in webkit [127410] by yosin@chromium.org
  • 2 edits
    15 adds in trunk/LayoutTests

Unreviewed rebaseline for bug 94287.
Update Chromium-Mac and Chromium-Win images for multiple field time input UI.

  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
  • platform/chromium/TestExpectations:
1:35 AM Changeset in webkit [127409] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark http/tests/incremental/slow-utf8-text.pl as flaky
https://bugs.webkit.org/show_bug.cgi?id=95673

Unreviewed EFL gardening.

Mark http/tests/incremental/slow-utf8-text.pl as flaky
as it does not always time out.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03

  • platform/efl/TestExpectations:
1:34 AM Changeset in webkit [127408] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for ENABLE(CLASSIC_INTERPRETER) after r127393.

  • interpreter/Interpreter.h:
1:30 AM Changeset in webkit [127407] by yosin@chromium.org
  • 2 edits
    5 deletes in trunk/LayoutTests

Unreviewed, rolling out r127406.
http://trac.webkit.org/changeset/127406
https://bugs.webkit.org/show_bug.cgi?id=95674

Expectation images are missing (Requested by yosin1 on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-03

  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
  • platform/chromium/TestExpectations:
1:22 AM Changeset in webkit [127406] by yosin@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

Unreviewed rebaseline for bug 94287.
Update Chromium-Mac and Chromium-Win images for multiple field time input UI.

  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
  • platform/chromium/TestExpectations:
1:18 AM Changeset in webkit [127405] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage API test
https://bugs.webkit.org/show_bug.cgi?id=95671

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03
Reviewed by Kenneth Rohde Christiansen.

Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage
API test since it is flaky on the bots.

  • UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:

(TEST_F):

1:16 AM Changeset in webkit [127404] by g.czajkowski@samsung.com
  • 4 edits in trunk

[GTK][EFL] 'dictIter' iterator is not initialized for an inner loop
https://bugs.webkit.org/show_bug.cgi?id=95436

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

The 'checkSpellingOfString' method assumes that the given string is concatenation of words.
To properly handle spellchecking of each word we need to iterate over the all available
dictionaries ('dictIter').

To allow spellchecking for multiple words, 'dictIter' should be initialized at the beginning
of vector while spellchecking of the word. This ensures performing of spelling for word based on
at least one dictionary.

  • platform/text/enchant/TextCheckerEnchant.cpp:

(TextCheckerEnchant::checkSpellingOfString): Moved initialization of 'dictIter' to an inner loop.

LayoutTests:

'checkSpellingOfString' from the TextCheckerEnchant class can not mark multiplie words that are misspelled.
It's possible to mark misspeled string only by defining its location and length.

  • platform/gtk/TestExpectations: Added spelling-backspace-between-lines.html to TestExpectations.
1:14 AM Changeset in webkit [127403] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Mark several inspector test as flaky
https://bugs.webkit.org/show_bug.cgi?id=95667

Unreviewed EFL gardening.

Mark several inspector test cases as flaky on
WebKit2 EFL.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03

  • platform/efl-wk2/TestExpectations:
12:35 AM Changeset in webkit [127402] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Update TestExpectations for 2 fast/block tests
https://bugs.webkit.org/show_bug.cgi?id=95666

Unreviewed EFL gardening.

Update TestExpectations for 2 fast/block tests to
indicate that we expect TEXT only diff on the bot
since we don't run pixel tests.

Patch by Christophe Dumez <Christophe Dumez> on 2012-09-03

  • platform/efl/TestExpectations:

Sep 2, 2012:

11:57 PM Changeset in webkit [127401] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit2

WK2: Build failure on SnowLeopard after r127384
https://bugs.webkit.org/show_bug.cgi?id=95665

Reviewed by Dan Bernstein.

Add SandboxExtension::consumePermanently(const Handle&) for !ENABLE(WEB_PROCESS_SANDBOX) to fix link error.

  • Shared/SandboxExtension.h:

(WebKit::SandboxExtension::consumePermanently):

11:03 PM Changeset in webkit [127400] by yosin@chromium.org
  • 3 edits in trunk/Source/WebCore

[Forms] Empty visible value of AM/PM field of multiple fields time input UI should display variable number of "-" based on maximum number of labels
https://bugs.webkit.org/show_bug.cgi?id=95660

Reviewed by Kent Tamura.

This patch changes visible empty value of AM/PM field in multiple
fields time input UI to "-", "--", "---", and so on based on maximum
length of AM/PM labels. In current implementation, it is always "--"
regardless locale, although on Arabic, AM/PM are represented in one
character.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(makeVisibleEmptyValue): Build visible empty value from maximum length
of labels.
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Changed to
use m_visibleEmptyValue.

  • html/shadow/DateTimeSymbolicFieldElement.h:

(WebCore::DateTimeSymbolicFieldElement): Added new member variable
m_visibleEmptyValue to hold visible empty value.

10:51 PM Changeset in webkit [127399] by bashi@chromium.org
  • 5 edits
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed test expectation update after r127398

  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
  • platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
9:03 PM Changeset in webkit [127398] by yosin@chromium.org
  • 4 edits in trunk/Source/WebCore

[Forms] AM/PM field of multiple fields time input UI should be fixed width
https://bugs.webkit.org/show_bug.cgi?id=95542

Reviewed by Kent Tamura.

This patch changes width of AM/PM field of multiple field time input
UI fixed as maximum width of labels or "--".

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.

  • css/html.css:

(input::-webkit-datetime-edit-ampm-field): Added "display" property to "inline-block" for setting width.
Added "text-align" property to "center".

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement): Changed to call setHasCustomCallback().
(WebCore::DateTimeSymbolicFieldElement::customStyleForRenderer): Added for setting field with from maximum width of labels.

  • html/shadow/DateTimeSymbolicFieldElement.h:

(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Added for using visible empty value in customStyleForRenderer() and visibleValue().
(WebCore::DateTimeSymbolicFieldElement::visibleValue): Changed to call visibleEmptyValue() instead of using literal "--".
(DateTimeSymbolicFieldElement): Added a declaration of customStyleForRenderer().

7:04 PM Changeset in webkit [127397] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Keep activePopupMenu to call valueChangedForPopupMenu() outside showPopupMenu()
https://bugs.webkit.org/show_bug.cgi?id=95355

Reviewed by Gyuyoung Kim.

Efl does not have a proper way to support nested loop so that applications
may change value after showPopupMenu() is finished.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp: Improved test case to cover this bug.

(selectItemAfterDelayed):
(showPopupMenu):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):
Guard with !PLATFORM(EFL) to keep the activePopupMenu valid to call valueChangedForPopupMenu
outside showPopupMenu().

6:05 PM Changeset in webkit [127396] by yosin@chromium.org
  • 6 edits
    5 adds
    9 deletes in trunk/LayoutTests

[Tests] fast/forms/time-multiple-fields/time-multiple-fields-appearance-*.html should dump text instead of render tree
https://bugs.webkit.org/show_bug.cgi?id=95545

Reviewed by Kent Tamura.

This patch changes test expectations to text output and pixel images
instead of structure of render tree and pixel images for multiple
fields time input UI. This patch helps us to avoid rebaseline when
we change DOM structure but keep appearance.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Changed to call testRunner.dumpAsText().
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Changed to call testRunner.dumpAsText().
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html: Changed to call testRunner.dumpAsText().
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Changed to call testRunner.dumpAsText().
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: Changed to call testRunner.dumpAsText().
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
  • platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
5:24 PM Changeset in webkit [127395] by bashi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectation update after r127362

  • platform/chromium/TestExpectations: Moved

fast/notifications/notifications-event-listener-crash.html to
http/tests/notifications.

4:52 PM WebKitGTK/1.10.x edited by Martin Robinson
(diff)
4:45 PM Changeset in webkit [127394] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Fixed failures seen on Linux bots.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_push_with_scope):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_push_with_scope):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h: push_*_scope doesn't have a destination operand anymore.

Accordingly, update these places in the baseline JIT, which I missed in my last patch.

2:27 PM Changeset in webkit [127393] by ggaren@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Refactored scope chain opcodes to support optimization for named function expressions
https://bugs.webkit.org/show_bug.cgi?id=95658

Reviewed by Sam Weinig.

Renamed

push_scope => push_with_scope
push_new_scope => push_name_scope

to clarify the difference between them.

Changed push_with_scope and push_name_scope not to save the new scope in
a temporary register, since doing so made optimization harder.

(The old behavior was a hold-over from when the scope chain wasn't
a GC object, and wouldn't be marked otherwise. Now, the scope chain is
marked because it is a GC object pointed to by the call frame.)

Changed push_name_scope to accept an operand specifying the attributes
for the named property, instead of assuming DontDelete, because a named
function expression needs ReadOnly|DontDelete.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::highestUsedRegister): Removed this function,
which used to be related to preserving saved scope object temporaries,
because it had no callers.

1:26 PM Changeset in webkit [127392] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Improve the way we use convertedSpaceString() in convertHTMLTextToInterchangeFormat()
https://bugs.webkit.org/show_bug.cgi?id=95301

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-02
Reviewed by Darin Adler.

The static string convertedSpaceString() had a couple of annoying side effects:
-The string was 16bits due to noBreakSpace, which forced any input to be converted to 16bits.
-The string was kept in the heap for no particular reason.

This patch redefines convertedSpaceString as a constant literal so that we can use it efficiently.

The patch also make the binary a tiny bit smaller (700 bytes).

  • editing/HTMLInterchange.cpp:

(WebCore::convertHTMLTextToInterchangeFormat):

11:57 AM Changeset in webkit [127391] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build is broken when SVG is disabled.
https://bugs.webkit.org/show_bug.cgi?id=95653

Patch by Mike West <mkwst@chromium.org> on 2012-09-02
Reviewed by Dirk Schulze.

Adding CSSPropertyWebkitClipPath to the massive switch statement in StyleResolver.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

10:43 AM Changeset in webkit [127390] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Add missing semicolon at the end of some lines.
https://bugs.webkit.org/show_bug.cgi?id=95640

Patch by Byungwoo Lee <bw80.lee@gmail.com> on 2012-09-02
Reviewed by Gyuyoung Kim.

EWK_VIEW_PRIV_GET_OR_RETURN macro and other related macro can be used
without semicolon, because it ends with a semicolon or complete block.
This can make a human mistake about missing semicolon.

Fixed the macros to require semicolon, and added missing semicolons.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_initialize):

10:09 AM Changeset in webkit [127389] by commit-queue@webkit.org
  • 4 edits
    1 move in trunk/LayoutTests

fast/html/marquee-alternate.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=94130

Patch by Jessie Berlin <jberlin@apple.com> on 2012-09-02
Reviewed by Simon Fraser.

Disable the test because it is flakey on so many platforms. Remove it from the Skipped and
TestExpectations files so that run-webkit-tests doesn't go looking for it.

  • fast/html/marquee-alternate.html-disabled: Renamed from LayoutTests/fast/html/marquee-alternate.html.
  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/qt-arm/Skipped:
3:34 AM Changeset in webkit [127388] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Repaints should not be deferred after initial page load is complete
https://bugs.webkit.org/show_bug.cgi?id=95480

Reviewed by Simon Fraser

Any dynamically triggered resource loading currently sends us back to deferred paint mode, making animation choppy.
This is not the intention of this code.

This patch adds an additional condition that prevents page from re-entering deferred repaint mode after the initial
load has completed. It also cleans up the code slightly.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkCompleted):

Add additional call to checkStopDelayingDeferredRepaints() after a frame load completes as the
new condition in shouldUseLoadTimeDeferredRepaintDelay() looks for this change too.

  • page/FrameView.cpp:

(WebCore):

Reduced the normal delay from 25ms to 16ms to not interfere with full framerate animation.

(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::checkFlushDeferredRepaintsAfterLoadComplete):

Ensure the repaint delay is reset after load completes even if we don't currently need a repaint.

(WebCore::FrameView::flushDeferredRepaints):

We had to identical functions, flushDeferredRepaints() and stopDelayingDeferredRepaints(). Remove
the latter.

(WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):

Factor the test for using load time repaint timings to a functions. The test for
initial page load having completed is new.

(WebCore::FrameView::updateDeferredRepaintDelay):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):

  • page/FrameView.h:

(FrameView):

1:34 AM Changeset in webkit [127387] by fpizlo@apple.com
  • 2 edits in trunk/Source/WebCore

Don't create access error strings if there is no access error
https://bugs.webkit.org/show_bug.cgi?id=95652

Reviewed by Adam Barth.

This undoes the 50% performance regression in pdfjs caused by
http://trac.webkit.org/changeset/126165

No new tests because behavior is unchanged.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::shouldAllowAccessToFrame):
(WebCore::shouldAllowAccessToDOMWindow):

Sep 1, 2012:

10:51 PM Changeset in webkit [127386] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unused member variable from WebProcess.

Rubber-stamped by Dan Bernstein.

  • WebProcess/WebProcess.h:

(WebProcess):
Remove m_applicationCachePathExtension.

9:31 PM Changeset in webkit [127385] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Refactoring the DumpRenderTreeSupportEfl
https://bugs.webkit.org/show_bug.cgi?id=95544

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-01
Reviewed by Gyuyoung Kim.

There are lots of repeated codes for getting the WebCore::Frame
and WebCore::Page. To reduce these duplications, simple macros
are added.

No new tests, just refactoring.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::activeAnimationsCount):
(DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
(DumpRenderTreeSupportEfl::clearFrameName):
(DumpRenderTreeSupportEfl::clearOpener):
(DumpRenderTreeSupportEfl::elementDoesAutoCompleteForElementWithId):
(DumpRenderTreeSupportEfl::frameChildren):
(DumpRenderTreeSupportEfl::frameParent):
(DumpRenderTreeSupportEfl::layoutFrame):
(DumpRenderTreeSupportEfl::numberOfPages):
(DumpRenderTreeSupportEfl::pageSizeAndMarginsInPixels):
(DumpRenderTreeSupportEfl::pageProperty):
(DumpRenderTreeSupportEfl::pauseAnimation):
(DumpRenderTreeSupportEfl::pauseTransition):
(DumpRenderTreeSupportEfl::pendingUnloadEventCount):
(DumpRenderTreeSupportEfl::renderTreeDump):
(DumpRenderTreeSupportEfl::responseMimeType):
(DumpRenderTreeSupportEfl::selectionRectangle):
(DumpRenderTreeSupportEfl::suitableDRTFrameName):
(DumpRenderTreeSupportEfl::setDefersLoading):
(DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting):
(DumpRenderTreeSupportEfl::addUserScript):
(DumpRenderTreeSupportEfl::clearUserScripts):
(DumpRenderTreeSupportEfl::addUserStyleSheet):
(DumpRenderTreeSupportEfl::clearUserStyleSheets):
(DumpRenderTreeSupportEfl::executeCoreCommandByName):
(DumpRenderTreeSupportEfl::findString):
(DumpRenderTreeSupportEfl::setCSSGridLayoutEnabled):
(DumpRenderTreeSupportEfl::isCommandEnabled):
(DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled):
(DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled):
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
(DumpRenderTreeSupportEfl::globalContextRefForFrame):
(DumpRenderTreeSupportEfl::setInteractiveFormValidationEnabled):
(DumpRenderTreeSupportEfl::setValidationMessageTimerMagnification):
(DumpRenderTreeSupportEfl::setAuthorAndUserStylesEnabled):
(DumpRenderTreeSupportEfl::setComposition):
(DumpRenderTreeSupportEfl::hasComposition):
(DumpRenderTreeSupportEfl::compositionRange):
(DumpRenderTreeSupportEfl::confirmComposition):
(DumpRenderTreeSupportEfl::firstRectForCharacterRange):
(DumpRenderTreeSupportEfl::selectedRange):

8:08 PM Changeset in webkit [127384] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

Use dynamic sandbox extension rather than sandbox parameters for paths provided by the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=95651

Reviewed by Dan Bernstein.

This is the first step to not relying on the initialization message to initialize
the sandbox.

  • Shared/SandboxExtension.h:

(SandboxExtension):

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::consumePermanently):
Add static version of SandboxExtension::consumePermanently which takes a
SandboxExtension::Handle. There is no reason to create a SandboxExtension
just to consume it forever.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):
Add SandboxExtension::Handles for paths we need access to, and remove
webInspectorBaseDirectory, which is unused.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
Create SandboxExtension::Handles for paths we need access to, and move
getting the presenterApplicationPid to platformInitializeWebProcess, since
it is Mac only.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Move setting the presenterApplicationPid to platformInitializeWebProcess.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):
(WebKit::WebProcess::platformInitializeWebProcess):
Replace the use of sandbox parameters for opening access for necessary paths
with permanent consumption of sandbox extensions.

  • WebProcess/com.apple.WebProcess.sb.in:

Remove sandbox rules that are now handled via extensions.

5:15 PM Changeset in webkit [127383] by krit@webkit.org
  • 5 edits
    18 adds in trunk

Use -webkit-clip-path shapes to clip SVG elements
https://bugs.webkit.org/show_bug.cgi?id=95620

Reviewed by Rob Buis.

Source/WebCore:

This patch adds a path segment for a BasicShape to a given Path object. This
path and it's wind rule are used to clip the context of the SVG element.

Tests: svg/clip-path/clip-path-shape-circle-1-expected.svg

svg/clip-path/clip-path-shape-circle-1.svg
svg/clip-path/clip-path-shape-circle-2-expected.svg
svg/clip-path/clip-path-shape-circle-2.svg
svg/clip-path/clip-path-shape-ellipse-1-expected.svg
svg/clip-path/clip-path-shape-ellipse-1.svg
svg/clip-path/clip-path-shape-ellipse-2-expected.svg
svg/clip-path/clip-path-shape-ellipse-2.svg
svg/clip-path/clip-path-shape-polygon-1-expected.svg
svg/clip-path/clip-path-shape-polygon-1.svg
svg/clip-path/clip-path-shape-polygon-2-expected.svg
svg/clip-path/clip-path-shape-polygon-2.svg
svg/clip-path/clip-path-shape-polygon-3-expected.svg
svg/clip-path/clip-path-shape-polygon-3.svg
svg/clip-path/clip-path-shape-rounded-rect-1-expected.svg
svg/clip-path/clip-path-shape-rounded-rect-1.svg
svg/clip-path/clip-path-shape-rounded-rect-2-expected.svg
svg/clip-path/clip-path-shape-rounded-rect-2.svg

  • rendering/style/BasicShapes.cpp: Added helper functions that apply path segments to a given path.

(WebCore::BasicShapeRectangle::path):
(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapePolygon::path):

  • rendering/style/BasicShapes.h: Make BasicShape virtualized again, since new virtual functions were added.

(WebCore::BasicShape::~BasicShape):
(BasicShape):
(WebCore::BasicShape::windRule): Will return the wind rule of the shape - nonzero by default.
(WebCore::BasicShape::BasicShape):
(BasicShapeRectangle):
(WebCore::BasicShapeRectangle::type): Removed member variable and return type per inheriting class directly.
(WebCore::BasicShapeRectangle::BasicShapeRectangle):
(BasicShapeCircle):
(WebCore::BasicShapeCircle::type): Ditto.
(WebCore::BasicShapeCircle::BasicShapeCircle):
(BasicShapeEllipse):
(WebCore::BasicShapeEllipse::type): Ditto.
(WebCore::BasicShapeEllipse::BasicShapeEllipse):
(BasicShapePolygon):
(WebCore::BasicShapePolygon::windRule):
(WebCore::BasicShapePolygon::type): Ditto.
(WebCore::BasicShapePolygon::BasicShapePolygon):

  • rendering/svg/SVGRenderingContext.cpp: If -webkit-clip-path was defined, clip the context to the shape.

Right now -webkit-clip-path overrides clip-path, so that people don't use both at the same time. Current
clip-path property will be replaced, once -webkit-clip-path gets unprefixed.
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

LayoutTests:

New tests to check behavior of -webkit-clip-path on SVG elements.

  • svg/clip-path/clip-path-shape-circle-1-expected.svg: Added.
  • svg/clip-path/clip-path-shape-circle-1.svg: Added.
  • svg/clip-path/clip-path-shape-circle-2-expected.svg: Added.
  • svg/clip-path/clip-path-shape-circle-2.svg: Added.
  • svg/clip-path/clip-path-shape-ellipse-1-expected.svg: Added.
  • svg/clip-path/clip-path-shape-ellipse-1.svg: Added.
  • svg/clip-path/clip-path-shape-ellipse-2-expected.svg: Added.
  • svg/clip-path/clip-path-shape-ellipse-2.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-1-expected.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-1.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-2-expected.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-2.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-3-expected.svg: Added.
  • svg/clip-path/clip-path-shape-polygon-3.svg: Added.
  • svg/clip-path/clip-path-shape-rounded-rect-1-expected.svg: Added.
  • svg/clip-path/clip-path-shape-rounded-rect-1.svg: Added.
  • svg/clip-path/clip-path-shape-rounded-rect-2-expected.svg: Added.
  • svg/clip-path/clip-path-shape-rounded-rect-2.svg: Added.
1:29 PM Changeset in webkit [127382] by wangxianzhu@chromium.org
  • 4 edits
    1 add
    1 delete in trunk

[Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=95605

Reviewed by Dirk Pranke.

Tools:

Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.check_sys_deps):
(ChromiumAndroidPort.expectations_files):
(ChromiumAndroidPort.clean_up_test_run):

LayoutTests:

Moved the skipping rules for ANDROID into platform/chromium-android/TestExpectations.

  • platform/chromium/TestExpectations:
  • platform/chromium/test_expectations_android.txt: Removed.
  • platform/chromium-android/TestExpectations: Added.
12:46 PM Changeset in webkit [127381] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Regression(r126763): Heap-use-after-free in WebCore::nextBreakablePosition
https://bugs.webkit.org/show_bug.cgi?id=95229

Patch by Ned Holbrook <nholbrook@apple.com> on 2012-09-01
Reviewed by Dan Bernstein.

Source/WebCore:

TextLayout and LazyLineBreakIterator cache a RenderText's string during line breaking but RenderCounter
and RenderQuote can replace that string during preferred width calculation. This patch adds a non-virtual member
function to RenderText named updateTextIfNeeded() that triggers immediate string replacement by calling
the new virtual updateText() if necessary, which in turn calls computePreferredLogicalWidths(). In this way
RenderBlock::LineBreaker::nextLineBreak() can ensure a RenderText's string is current before caching it.

Test: fast/css/content/content-quotes-crash.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::dirtyLineBoxesForRenderer): Drive-by: replace existing code with the equivalent updateTextIfNeeded().
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Use updateTextIfNeeded() prior to caching RenderText string.

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::updateText): Call computePreferredLogicalWidths().
(WebCore):

  • rendering/RenderCounter.h:

(RenderCounter):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::updateText): Call computePreferredLogicalWidths().
(WebCore):

  • rendering/RenderQuote.h:

(RenderQuote):

  • rendering/RenderText.h:

(WebCore::RenderText::updateTextIfNeeded): Only call virtual updateText() if necessary.
(RenderText):
(WebCore::RenderText::updateText): Add no-op default implementation for new virtual member function.

LayoutTests:

Ensure line breaking doesn't crash due to text of RenderText being changed.

  • fast/css/content/content-quotes-crash-expected.txt: Added.
  • fast/css/content/content-quotes-crash.html: Added.
12:42 PM Changeset in webkit [127380] by commit-queue@webkit.org
  • 9 edits in trunk

fast/events/message-port-clone.html hits ASSERT in Debug (usually in later tests)
https://bugs.webkit.org/show_bug.cgi?id=85811

Patch by Li Yin <li.yin@intel.com> on 2012-09-01
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

When MessagePort invoked close function, the close status is needed to set,
regardless of whether the port is cloned or not.

Tests: fast/events/message-port-clone.html

fast/events/message-port-close.html

  • dom/MessagePort.cpp:

(WebCore::MessagePort::close): Must set m_closed to be true.

LayoutTests:

  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/Skipped:
12:26 PM Changeset in webkit [127379] by wangxianzhu@chromium.org
  • 2 edits
    2 adds
    2 deletes in trunk/LayoutTests

[Chromium-Android] Upstream layout test expectations (Part 4)
https://bugs.webkit.org/show_bug.cgi?id=95594

Reviewed by Adam Barth.

Remove a font boosting test which has been removed in downstream.
Update canvas test expectations.
Rebaselined one canvas test (only one space diff).

  • platform/chromium-android/fast/canvas/fallback-content-expected.txt: Added.
  • platform/chromium-android/fast/font-boosting/various-tricky-cases-expected.txt: Removed.
  • platform/chromium-android/fast/font-boosting/various-tricky-cases.html: Removed.
  • platform/chromium/TestExpectations:
12:06 PM Changeset in webkit [127378] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed chromium buildfix when use_libcc_for_compositor=1

This gyp target was renamed downstream.

  • WebKit.gyp:
11:16 AM Changeset in webkit [127377] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure
https://bugs.webkit.org/show_bug.cgi?id=95643

Unreviewed GTK gardening, rebaselining an accessibility test.

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01

  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Corrected.
10:49 AM Changeset in webkit [127376] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-09-01 Geoffrey Garen <ggaren@apple.com>

Rolled back out a piece of <http://trac.webkit.org/changeset/127293>
because it broke inspector tests on Windows.

Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

10:47 AM Changeset in webkit [127375] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

Share inline style between cloned Nodes (copy on write.)
<http://webkit.org/b/95451>

Reviewed by Antti Koivisto.

When cloning a Node, use an immutable StylePropertySet for the new Node's inline style.
If the old Node already had an immutable inline style, we now reuse that, avoiding a copy.
Copying is deferred until mutation (either via CSSOM or setting of the style attribute.)

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::cloneDataFrom):

  • css/StylePropertySet.h:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::immutableCopyIfNeeded):

Added. Simply returns 'this' if the object is already immutable, otherwise creates a new one.

10:36 AM Changeset in webkit [127374] by commit-queue@webkit.org
  • 25 edits
    1 copy
    2 adds in trunk/Source

LLInt C loop backend.
https://bugs.webkit.org/show_bug.cgi?id=91052.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-01
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::bytecodeOffset):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC):

  • interpreter/Interpreter.h:
  • jit/JITStubs.h:

(JITStackFrame):
(JSC):

  • llint/LLIntCLoop.cpp: Added.

(JSC):
(LLInt):
(JSC::LLInt::CLoop::initialize):
(JSC::LLInt::CLoop::catchRoutineFor):
(JSC::LLInt::CLoop::hostCodeEntryFor):
(JSC::LLInt::CLoop::jsCodeEntryWithArityCheckFor):
(JSC::LLInt::CLoop::jsCodeEntryFor):

  • llint/LLIntCLoop.h: Added.

(JSC):
(LLInt):
(CLoop):

  • llint/LLIntData.cpp:

(JSC::LLInt::initialize):

  • llint/LLIntData.h:

(JSC):

  • llint/LLIntOfflineAsmConfig.h:
  • llint/LLIntOpcode.h:
  • llint/LLIntThunks.cpp:

(LLInt):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter.cpp:

(LLInt):
(JSC::LLInt::Ints2Double):
(JSC):
(JSC::CLoop::execute):

  • llint/LowLevelInterpreter.h:

(JSC):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/asm.rb:
  • offlineasm/backends.rb:
  • offlineasm/cloop.rb: Added.
  • offlineasm/instructions.rb:
  • runtime/Executable.h:

(ExecutableBase):
(JSC::ExecutableBase::hostCodeEntryFor):
(JSC::ExecutableBase::jsCodeEntryFor):
(JSC::ExecutableBase::jsCodeWithArityCheckEntryFor):
(JSC::ExecutableBase::catchRoutineFor):
(NativeExecutable):

  • runtime/JSValue.h:

(JSC):
(LLInt):
(JSValue):

  • runtime/JSValueInlineMethods.h:

(JSC):
(JSC::JSValue::JSValue):

  • runtime/Options.cpp:

(JSC::Options::initialize):

Source/WTF:

Added configs for the llint C loop backend.

  • wtf/Platform.h:
10:22 AM Changeset in webkit [127373] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rolled back in a piece of <http://trac.webkit.org/changeset/127293>.

Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

9:14 AM Changeset in webkit [127372] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

Added #include <JavaScriptCore/Identifier.h>.
https://bugs.webkit.org/show_bug.cgi?id=95641.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-01
Reviewed by Dan Bernstein.

The code references JSC::Indentifier but was previously depending on
someone else to #include it. This results in build problems when
building for the llint C loop configuration.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
7:42 AM Changeset in webkit [127371] by krit@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix the --minimal build after r127327
https://bugs.webkit.org/show_bug.cgi?id=95639

Unreviewed attempt to fix Qt minimal build.

  • css/StyleBuilder.cpp:
7:02 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
7:01 AM WebKitGTK/1.8.x edited by Martin Robinson
(diff)
3:51 AM Changeset in webkit [127370] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811

Part of the bug was due to expected accessible objects of DivRole
and ParagraphRole being ignored, in favor of including child blocks.

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/gtk/accessibility/spans-paragraphs-and-divs.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::firstAnonymousBlockChild):
(WebCore):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
New method to return the first child which is an anonymous block.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Include paragraphs and divs which contain a non-nested anonymous block.

LayoutTests:

Added new test to verify that paragraphs and divs which contain anonymous
blocks are included in the accessible object hierarchy and have the correct
number of children with the expected role.

  • platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt: Added.
  • platform/gtk/accessibility/spans-paragraphs-and-divs.html: Added.
3:47 AM Changeset in webkit [127369] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, rebaselining an accessibility test.

  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
1:53 AM Changeset in webkit [127368] by zandobersek@gmail.com
  • 8 edits
    2 adds in trunk

[Gtk] No accessible caret-moved events found in certain content
https://bugs.webkit.org/show_bug.cgi?id=72811

Part of the bug was due to extraneous accessible objects resulting
from unignored inline and block spans.

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/gtk/accessibility/spans.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Ignore objects that have spanTag tag name.

  • accessibility/gtk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore most anonymous blocks.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(roleIsTextType): Add ListItem to the roles which should implement AtkText.

LayoutTests:

Added new test, updated the results of one test to reflect the fix,
corrected a test with a mismatched element tag.

  • platform/gtk/accessibility/aria-roles-unignored-expected.txt: Corrected results having fixed tag.
  • platform/gtk/accessibility/aria-roles-unignored.html: Fixed mismatched element tag.
  • platform/gtk/accessibility/media-element-expected.txt: Updated to reflect removal of extraneous object.
  • platform/gtk/accessibility/spans-expected.txt: Added.
  • platform/gtk/accessibility/spans.html: Added.
1:43 AM Changeset in webkit [127367] by zandobersek@gmail.com
  • 8 edits
    4 adds in trunk

[Gtk] Incorrect/unexpected characters in the text of certain accessibles
https://bugs.webkit.org/show_bug.cgi?id=95180

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
Reviewed by Chris Fleizach.

Source/WebCore:

The bug was caused by failing to properly handle anonymous block text
which had object replacement characters (multibyte) in it. Calculating
the string length based on the UTF-8 string meant that we were returning
more characters than were there and in danger of splitting a multibyte
character.

Tests: platform/gtk/accessibility/entry-and-password.html

platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetText): Convert the text returned by textForObject()
to Unicode before calculating its length.

Source/WebKit/gtk:

Corrected a unit test in which the expected accessible text was wrong as
a result of this bug. In particular, the AtkText inserted into an empty
text field is expected to be the same text atk_text_get_text() returns.
That was not happening -- and presumably not noticed as a result of the
hard to read textual representation of the multibyte password field
bullets.

  • tests/testatk.c:

(testWebkitAtkTextChangedNotifications): Corrected the test and added a
comment so that one knows what the multibyte character is.

Tools:

The bug that was fixed stood in the way of fully implementing stringValue().
Testing that the bug is fixed requires stringValue() to be fully implemented
and object replacement characters to be printable.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(replaceCharactersForResults): New method which turns object replacement
characters into "<obj>" so that the characters can be properly shown in
Layout Test results. Also turns "\n" into "<
n>" so that printing the
accessible text of a single object in the accessible tree doesn't mess up
the readibility of the results.
(AccessibilityUIElement::stringValue): Remove the code that immediately
returned upon encountering an object of ATK_ROLE_PANEL and call the new
replaceCharactersForResults() prior to returning the accessible string
value.

LayoutTests:

Two new layout tests, plus one updated one.

  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Indicated replaced objects.
  • platform/gtk/accessibility/entry-and-password-expected.txt: Added.
  • platform/gtk/accessibility/entry-and-password.html: Added.
  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Added.
  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html: Added.
1:20 AM Changeset in webkit [127366] by abarth@webkit.org
  • 17 edits in trunk/Source/WebCore

Remove all-but-one use of WTF::String::operator+= from WebCore
https://bugs.webkit.org/show_bug.cgi?id=95508

Reviewed by Benjamin Poulain.

This patch removes all the uses of WTF::String::operator+= from
WebCore, except those in WorkerScriptLoader (which need a more delicate
patch). There were actually a handful of legitimate use cases for += in
this group. I've replaced them with calls to String::append rather than
+= so that we can remove += and encourage most contributors to use
more efficient string idioms.

(There are likely some more uses in WebCore hiding in port-specific
code---this patch covers only those call sites found when compiling the
chromium-mac port.)

  • inspector/InspectorStyleTextEditor.cpp:

(WebCore::InspectorStyleTextEditor::insertProperty):

  • This complicated function looks really inefficient, but I didn't have the heart to rewrite it.
  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::sheetText):
(WebCore::CachedCSSStyleSheet::data):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::ensureSVGFontData):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::data):

  • This decoder/flush pattern can probably be improved by combining the decode and flush operations, but I didn't do that in this patch.
  • page/FrameTree.cpp:

(WebCore::FrameTree::uniqueChildName):

  • I found this code very amusing. It's worried enough about efficiency to give a big speech about why snprintf is safe, but then it implicitly performs a large number of mallocs and memcpy operations.
  • page/Page.cpp:

(WebCore::Page::userStyleSheet):

  • platform/chromium/support/WebHTTPLoadInfo.cpp:

(WebKit::addHeader):

  • platform/chromium/support/WebURLResponse.cpp:

(WebKit::WebURLResponse::addHTTPHeaderField):

  • This header-appending idiom looks like a reasonable use case for String::append.
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::setRequestHeaderInternal):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunTranslate::evaluate):

  • Fixes 6 year old FIXME.
  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::append):

  • xml/parser/XMLDocumentParser.h:

(XMLDocumentParser):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::doEnd):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::doEnd):

  • Changed m_originalSourceForTransform to a SegmentedString so that we don't need to malloc and copy the entire document every time we get more data from the network.
12:54 AM Changeset in webkit [127365] by tommyw@google.com
  • 22 edits
    2 adds in trunk

MediaStream API: Add MediaStream management to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95543

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebMediaStreamCenter.h:

(WebMediaStreamCenter):

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebRTCPeerConnectionHandler):

  • chromium/public/WebRTCPeerConnectionHandlerClient.h:

(WebKit):
(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

This includes addStream/removeStream to RTCPeerConnection,
as well as didAddRemoteStream/didRemoveRemoteStream to RTCPeerConnectionHandlerClient.

Test: fast/mediastream/RTCPeerConnection-AddRemoveStream.html

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::parseConfiguration):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::addStream):
(WebCore):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::localStreams):
(WebCore::RTCPeerConnection::remoteStreams):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • bindings/js/Dictionary.cpp:

(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):

  • bindings/v8/Dictionary.h:

(Dictionary):

  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::addStream):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::removeStream):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(RTCPeerConnectionHandler):

  • platform/mediastream/RTCPeerConnectionHandlerClient.h:

(WebCore):
(RTCPeerConnectionHandlerClient):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::addStream):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::removeStream):
(WebCore::RTCPeerConnectionHandlerChromium::didAddRemoteStream):
(WebCore::RTCPeerConnectionHandlerChromium::didRemoveRemoteStream):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(WebKit):
(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

  • src/AssertMatchingEnums.cpp:

Tools:

Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::addStream):
(MockWebRTCPeerConnectionHandler::removeStream):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html: Added.
12:49 AM Changeset in webkit [127364] by jonlee@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

[Tests] Add a test for all notification events
https://bugs.webkit.org/show_bug.cgi?id=95609
<rdar://problem/12218309>

Reviewed by Jessie Berlin.

This test tests for the onshow, onclick, and onclose events. onerror is called only if the
origin did not have permission to show the notification, and that is covered in
http/tests/notifications/{legacy,}/show.html.

  • http/tests/notifications/events-expected.txt: Added.
  • http/tests/notifications/events.html: Added.
  • http/tests/notifications/legacy/events-expected.txt: Added.
  • http/tests/notifications/legacy/events.html: Added.
12:45 AM Changeset in webkit [127363] by ggaren@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

2012-09-01 Geoffrey Garen <ggaren@apple.com>

Rolled back in a piece of <http://trac.webkit.org/changeset/127293>.

Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

  • runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::JSGlobalObject): (JSC::JSGlobalObject::setGlobalThis): (JSC): (JSC::JSGlobalObject::visitChildren):
  • runtime/JSGlobalObject.h: (JSGlobalObject): (JSC::JSScope::globalThis): (JSC): (JSC::JSGlobalObject::globalThis):
  • runtime/JSNameScope.h: (JSC::JSNameScope::JSNameScope):
  • runtime/JSScope.cpp: (JSC::JSScope::visitChildren):
  • runtime/JSScope.h: (JSScope): (JSC::JSScope::JSScope): (JSC::JSScope::globalObject): (JSC::JSScope::globalData):
  • runtime/JSSegmentedVariableObject.h: (JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):
  • runtime/JSSymbolTableObject.h: (JSC::JSSymbolTableObject::JSSymbolTableObject):
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::JSVariableObject):
  • runtime/JSWithScope.h: (JSC::JSWithScope::JSWithScope):
  • runtime/StrictEvalActivation.cpp: (JSC::StrictEvalActivation::StrictEvalActivation):
12:38 AM Changeset in webkit [127362] by jonlee@apple.com
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

[Tests] Move fast/notifications/notifications-event-listener-crash.html to http/tests/notifications
https://bugs.webkit.org/show_bug.cgi?id=95535
<rdar://problem/12213781>

Reviewed by Jessie Berlin.

This test is among a few that are being migrated from fast/notifications to http/tests/notifications because of permissions.
Since most notifications tests will involve permissions, it is easier to have all of them consolidated in the same directory.

This test has been slightly modified to take advantage of the new testRunner notifications API. The test itself also does not
need to be protected within the window.testRunner check since it does not use that object.

  • fast/notifications/notifications-event-listener-crash-expected.txt: Removed.
  • fast/notifications/notifications-event-listener-crash.html: Removed.
  • http/tests/notifications/event-listener-crash-expected.txt: Added.
  • http/tests/notifications/event-listener-crash.html: Added.
12:29 AM Changeset in webkit [127361] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Touch a file so that Chromium-win bots correctly re-build for OPENTYPE_VERTICAL
https://bugs.webkit.org/show_bug.cgi?id=51450

  • platform/graphics/opentype/OpenTypeVerticalData.cpp:
12:15 AM Changeset in webkit [127360] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-09-01 Geoffrey Garen <ggaren@apple.com>

Rolled back out a piece of <http://trac.webkit.org/changeset/127293>
because it broke Window inspector tests.

Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

  • runtime/JSActivation.h: (JSActivation):

Aug 31, 2012:

10:38 PM Changeset in webkit [127359] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Text expectation update
https://bugs.webkit.org/show_bug.cgi?id=51450

  • platform/chromium/TestExpectations:

Fix incorrect entry for track-cue-rendering-vertical.html

10:31 PM Changeset in webkit [127358] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update.
https://bugs.webkit.org/show_bug.cgi?id=51450

  • platform/chromium/TestExpectations:
  • r127354 wrongly removed failure expectation for MAC.
  • Also, fix expectation of vertical-font-fallback.html on WIN.
9:59 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Fix anchor. (diff)
9:57 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Add anchor. (diff)
9:53 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Editorial update. (diff)
9:44 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Add content on after-white-space and migrating to unprefixed line-break. (diff)
9:31 PM Changeset in webkit [127357] by pdr@google.com
  • 8 edits in trunk/LayoutTests

Fix 6 broken SVG animation tests

Unreviewed test update.

Six SVG animation tests were marked as TIMEOUT because they never ran. Each
of these tests required a click event to start and the event was not being fired.
This patch updates these tests to correctly start, fixing 6 TIMEOUTS.

  • platform/chromium/TestExpectations:
  • svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js:
  • svg/animations/script-tests/animate-path-nested-transforms.js:
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:
  • svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:
9:24 PM Changeset in webkit [127356] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, test expectation update

  • platform/chromium/TestExpectations:
    • Skip removing-underline-after-accepting-autocorrection-using-punctuation.html. Chromium doesn't support autocorrection yet.
    • Remove ANDROID entry for http/tests/notifications
9:13 PM Changeset in webkit [127355] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

Touch some files so that Chromium-win bots correctly re-build
files for OPENTYPE_VERTICAL.
https://bugs.webkit.org/show_bug.cgi?id=51450

  • platform/graphics/FontCache.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/opentype/OpenTypeTypes.h:
9:06 PM Changeset in webkit [127354] by tkent@chromium.org
  • 10 edits in trunk

Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=51450

Patch by Koji Ishii <Koji Ishii> on 2012-08-31
Reviewed by Tony Chang.

When writing-mode is vertical-*, Chromium Win does not render glyphs correctly.
http://dev.w3.org/csswg/css3-writing-modes/#writing-mode
Glyphs are now drawn in the correct orientation, regardless of the leading '@' in the font name,
and vertical alternate glyphs (OpenType 'vert' feature) is not enabled.
CJK characters drawn at wrong baseline position is also fixed.
In addition, fontMetrics().unitsPerEm() and SimpleFontData::platformBoundsForGlyph() were empty
in Chromium Win but they were implemented because they were needed to draw vertical flow correctly.

Note that this patch does not address issues in vertical flow for complex code path.
The issue is under discussion with Google people and it will not be fixed in short term.

Source/WebKit/chromium:

Existing tests in fast/writing-mode/* are enabled in LayoutTests/platform/chromium/TestExpectations.

  • features.gypi: ENABLE_OPENTYPE_VERTICAL=1.

LayoutTests:

  • fast/text/international/text-spliced-font.html: Added "MS Gothic" to the font list so that Japanese font is chosen on Windows.
  • fast/writing-mode/border-vertical-lr.html: Ditto.
  • fast/writing-mode/japanese-lr-selection.html: Ditto.
  • fast/writing-mode/japanese-lr-text.html: Ditto.
  • fast/writing-mode/japanese-rl-selection.html: Ditto.
  • fast/writing-mode/japanese-rl-text.html: Ditto.
  • platform/chromium/TestExpectations: writing-mode and vertical tests are separated to rebase later.
8:46 PM Changeset in webkit [127353] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Build warning : -Wformat on WebMemorySampler.cpp.
https://bugs.webkit.org/show_bug.cgi?id=95550

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-08-31
Reviewed by Darin Adler.

Fix build warning.
Use String::number instead of String::format.

  • Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):

8:08 PM Changeset in webkit [127352] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

-webkit-flex: 0 in inspector.css is confusing
https://bugs.webkit.org/show_bug.cgi?id=95568

Patch by Chris Hutten-Czapski <chutten@rim.com> on 2012-08-31
Reviewed by Tony Chang.

The initial value of -webkit-flex results in the same layout as
-webkit-flex: 0; but does not depend on the new initial value of auto
for min-width.

This increases the support for the new Web Inspector style to renderers
built before rev 122264 but after 117385.

No new tests (has no effect except to out-of-date renderers)

  • inspector/front-end/inspector.css:

(.status-bar-item):

7:52 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Add missing description of IS class. (diff)
7:34 PM LineBreakingCSS3Mapping edited by glenn@skynav.com
Fix table order. (diff)
7:14 PM Changeset in webkit [127351] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, attempt to fix Windows, take two.

6:51 PM Changeset in webkit [127350] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, attempt to fix Windows.

6:50 PM Changeset in webkit [127349] by fpizlo@apple.com
  • 12 edits in trunk/Source

JSArray::putDirectIndex should by default behave like JSObject::putDirect
https://bugs.webkit.org/show_bug.cgi?id=95630

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jsc.cpp:

(GlobalObject::finishCreation):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/JSArray.cpp:

(JSC::SparseArrayValueMap::putDirect):
(JSC::JSArray::defineOwnNumericProperty):
(JSC::JSArray::putDirectIndexBeyondVectorLength):

  • runtime/JSArray.h:

(SparseArrayValueMap):
(JSArray):
(JSC::JSArray::putDirectIndex):

  • runtime/JSONObject.cpp:

(JSC::Walker::walk):

  • runtime/RegExpMatchesArray.cpp:

(JSC::RegExpMatchesArray::reifyAllProperties):
(JSC::RegExpMatchesArray::reifyMatchProperty):

  • runtime/StringPrototype.cpp:

(JSC::splitStringByOneCharacterImpl):
(JSC::stringProtoFuncSplit):

Source/WebCore:

No new tests because no change in behavior.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::putProperty):

6:39 PM Changeset in webkit [127348] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Rolled back in a piece of <http://trac.webkit.org/changeset/127293>.

Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSNameScope.h:

(JSC::JSNameScope::JSNameScope):

  • runtime/JSWithScope.h:

(JSC::JSWithScope::JSWithScope):

  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::StrictEvalActivation):

6:09 PM Changeset in webkit [127347] by Nate Chapin
  • 5 edits in trunk

Source/WebCore: fast/loader/document-destruction-within-unload.html causes assertion failures on mac and qt.
https://bugs.webkit.org/show_bug.cgi?id=66783

Reviewed by Darin Adler.

This was a not-quite-regression from trac.webkit.org/changeset/93521, in that we hit asserts
in a case where we previously were use-after-freeing. Tweak how we handle cases where a Document
is cleared from within an unload handler.

No new tests, fixing fast/loader/document-destruction-within-unload.html on mac and qt.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setDocumentLoader): Instead of trying to reattach a partially removed

DocumentLoader if it is detached before being fully added, leave the old one in place, completed.

(WebCore::FrameLoader::transitionToCommitted):

LayoutTests: Unskip fast/loader/document-destruction-within-unload.html
on mac and qt.
https://bugs.webkit.org/show_bug.cgi?id=66783

Reviewed by Darin Adler.

  • platform/mac/Skipped:
  • platform/qt/Skipped:
6:00 PM Changeset in webkit [127346] by tony@chromium.org
  • 6 edits in trunk/Source/WebCore

Make computeBlockDirectionMargins const
https://bugs.webkit.org/show_bug.cgi?id=95595

Reviewed by Ojan Vafai.

This is a step in making computeLogicalHeight const.
Refactor RenderBox::computeBlockDirectionMargins and make it const.
Add a helper method computeAndSetBlockDirectionMargins for the callers outside of
computeLogicalHeight that are calling this.

No new tests, this is already covered by tests in fast/writing-mode and fast/multicol.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::marginBeforeEstimateForChild): Switch to computeAndSetBlockDirectionMargins
(WebCore::RenderBlock::layoutBlockChild): Switch to computeAndSetBlockDirectionMargins
(WebCore::RenderBlock::insertFloatingObject): Switch to computeAndSetBlockDirectionMargins

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight): Use const version and fill in a MarginValues struct (to be merged in the next patch).
(WebCore::RenderBox::computeBlockDirectionMargins): Pass in out params.
(WebCore):
(WebCore::RenderBox::computeAndSetBlockDirectionMargins): Does the same as the old computeBlockDirectionMargins.

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox): Switch to computeAndSetBlockDirectionMargins
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): Switch to computeAndSetBlockDirectionMargins

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout): Switch to computeAndSetBlockDirectionMargins

5:46 PM Changeset in webkit [127345] by ggaren@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Rolled back in a piece of <http://trac.webkit.org/changeset/127293>.

Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve_global_dynamic):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::withScopeStructure):
(JSC::JSGlobalObject::strictEvalActivationStructure):
(JSC::JSGlobalObject::activationStructure):
(JSC::JSGlobalObject::nameScopeStructure):

5:40 PM Changeset in webkit [127344] by roger_fong@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. CSS_VARIABLES are not enabled on Windows. Adding Windows specific results.

  • platform/win/fast/css/variables: Added.
  • platform/win/fast/css/variables/build-supports-variables-expected.txt: Added.
5:38 PM Changeset in webkit [127343] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove use of ClassInfo in SpeculativeJIT::emitBranch
https://bugs.webkit.org/show_bug.cgi?id=95623

Reviewed by Filip Pizlo.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):

5:33 PM Changeset in webkit [127342] by wjmaclean@chromium.org
  • 5 edits
    2 copies
    4 adds in trunk

[chromium] Make link highlighter use same node selection criteria as Chromium for Android.
https://bugs.webkit.org/show_bug.cgi?id=95371

Reviewed by James Robinson.

This CL brings the selection criteria for link highlight targets into alignment with Chromium for Android.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::highlightConditions):
(WebKit::WebViewImpl::bestTouchLinkNode):

  • tests/data/test_touch_link_highlight.html:

LayoutTests:

  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex.html: Copied from LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html.
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html:
  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-body.html: Copied from LayoutTests/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-background.html.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.txt: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-body-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-body-expected.txt: Added.
5:30 PM Changeset in webkit [127341] by roger_fong@apple.com
  • 1 edit
    8 adds in trunk/LayoutTests

Unreviewed. Adding expected failing results for some fast/css(3) tests.
https://bugs.webkit.org/show_bug.cgi?id=95627.

  • platform/win/fast/css/image-resolution: Added.
  • platform/win/fast/css/image-resolution/image-resolution-expected.txt: Added.
  • platform/win/fast/css/image-set-setting-expected.txt: Added.
  • platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt: Added.
  • platform/win/fast/css3-text-decoration: Added.
  • platform/win/fast/css3-text-decoration/getComputedStyle: Added.
  • platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Added.
  • platform/win/fast/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Added.
5:20 PM Changeset in webkit [127340] by jamesr@google.com
  • 13 edits
    1 move
    1 add in trunk/Source/WebKit/chromium

[chromium] Consolidate geometry unit testing functions for cc
https://bugs.webkit.org/show_bug.cgi?id=95526

Reviewed by Julien Chaffraix.

This consolidates geometry equality (rects, matrices) in CCGeometryUtils and removes a few duplicate macros for
testing rect equality.

  • WebKit.gypi:
  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::TEST_F):

  • tests/CCGeometryTestUtils.cpp: Added.

(WebKitTests):
(WebKitTests::ExpectTransformationMatrixEq):

  • tests/CCGeometryTestUtils.h: Renamed from Source/WebKit/chromium/tests/CCLayerTreeTestCommon.h.

(WebKit):
(WebKitTests):

  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCMathUtilTest.cpp:

(WebKit::TEST):

  • tests/TiledLayerChromiumTest.cpp:
5:12 PM Changeset in webkit [127339] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Mark some indexeddb tests as SLOW. They consistently time out for me
when I run with --fully-parallel.

  • platform/chromium/TestExpectations:
5:08 PM Changeset in webkit [127338] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Rolled back in a piece of <http://trac.webkit.org/changeset/127293>.

Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):

  • heap/MarkedBlock.h:

(MarkedBlock):
(JSC::MarkedBlock::globalData):
(JSC):

  • heap/WeakSet.cpp:

(JSC::WeakSet::addAllocator):

  • heap/WeakSet.h:

(WeakSet):
(JSC::WeakSet::WeakSet):
(JSC::WeakSet::globalData):

  • runtime/JSGlobalData.h:

(JSC::WeakSet::heap):
(JSC):

4:49 PM Changeset in webkit [127337] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Use initial process in multi-process mode, too
https://bugs.webkit.org/show_bug.cgi?id=95612

Reviewed by Sam Weinig.

  • UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): (WebKit::WebContext::warmInitialProcess): (WebKit::WebContext::disconnectProcess): (WebKit::WebContext::createWebPage):
  • UIProcess/WebContext.h: Added a boolean telling whether the last (normally, the only) process in m_processes is available for use in a new page.
4:46 PM Changeset in webkit [127336] by jamesr@google.com
  • 21 edits in trunk/Source/WebKit/chromium

[chromium] Clean up Web*Layer initialization paths
https://bugs.webkit.org/show_bug.cgi?id=95523

Reviewed by Darin Fisher.

Constructing a Web*LayerImpl (or other compositor type) wrapper shouldn't require knowledge of the underyling
implementation. Also normalizes naming conventions in these files.

  • src/WebAnimationImpl.cpp:

(WebKit::WebAnimation::create):
(WebKit::WebAnimationImpl::WebAnimationImpl):

  • src/WebAnimationImpl.h:

(WebAnimationImpl):

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::layer):
(WebKit::WebContentLayerImpl::setDoubleSided):
(WebKit::WebContentLayerImpl::setContentsScale):
(WebKit::WebContentLayerImpl::setUseLCDText):
(WebKit::WebContentLayerImpl::setDrawCheckerboardForMissingTiles):

  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • src/WebFloatAnimationCurveImpl.cpp:

(WebKit::WebFloatAnimationCurve::create):
(WebKit::WebFloatAnimationCurveImpl::WebFloatAnimationCurveImpl):

  • src/WebFloatAnimationCurveImpl.h:

(WebFloatAnimationCurveImpl):

  • src/WebIOSurfaceLayerImpl.cpp:

(WebKit::WebIOSurfaceLayer::create):
(WebKit::WebIOSurfaceLayerImpl::WebIOSurfaceLayerImpl):

  • src/WebIOSurfaceLayerImpl.h:

(WebIOSurfaceLayerImpl):

  • src/WebImageLayerImpl.cpp:

(WebKit::WebImageLayer::create):
(WebKit::WebImageLayerImpl::WebImageLayerImpl):

  • src/WebImageLayerImpl.h:

(WebImageLayerImpl):

  • src/WebLayerImpl.cpp:

(WebKit::WebLayer::create):
(WebKit):
(WebKit::WebLayerImpl::WebLayerImpl):

  • src/WebLayerImpl.h:

(WebLayerImpl):

  • src/WebScrollbarLayerImpl.cpp:

(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayerImpl::WebScrollbarLayerImpl):

  • src/WebScrollbarLayerImpl.h:

(WebScrollbarLayerImpl):

  • src/WebSolidColorLayerImpl.cpp:

(WebKit::WebSolidColorLayer::create):
(WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):

  • src/WebSolidColorLayerImpl.h:

(WebSolidColorLayerImpl):

  • src/WebTransformAnimationCurveImpl.cpp:

(WebKit::WebTransformAnimationCurve::create):
(WebKit::WebTransformAnimationCurveImpl::WebTransformAnimationCurveImpl):

  • src/WebTransformAnimationCurveImpl.h:

(WebTransformAnimationCurveImpl):

  • src/WebVideoLayerImpl.cpp:

(WebKit::WebVideoLayer::create):
(WebKit::WebVideoLayerImpl::WebVideoLayerImpl):

  • src/WebVideoLayerImpl.h:

(WebVideoLayerImpl):

4:42 PM Changeset in webkit [127335] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r127309.
http://trac.webkit.org/changeset/127309
https://bugs.webkit.org/show_bug.cgi?id=95624

The Windows tests weren't actually fixed. (Requested by
mhahnenberg on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-31

  • platform/win/Skipped:
4:27 PM Changeset in webkit [127334] by ap@apple.com
  • 11 edits in trunk/Source/WebKit2

[WK2] WebProcesses should not wait 60 seconds to close in multi-process mode
https://bugs.webkit.org/show_bug.cgi?id=95616

Reviewed by Darin Adler.

  • Shared/ChildProcess.cpp: (WebKit::ChildProcess::ChildProcess):
  • Shared/ChildProcess.h: (WebKit::ChildProcess::setTerminationTimeout): Expose a setter for timeout instead of taking it at construction time. If a derived class doesn't call the setter, default to 0.
  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::PluginProcess): (WebKit::PluginProcess::initializePluginProcess): Use timeout from initialization message.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::initializeWebProcess): Ditto.
  • Shared/Plugins/PluginProcessCreationParameters.cpp: (WebKit::PluginProcessCreationParameters::encode): (WebKit::PluginProcessCreationParameters::decode):
  • Shared/Plugins/PluginProcessCreationParameters.h:
  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h: Funnel timeout across process boundary.
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didFinishLaunching): Pass timeout as initialization message after launch.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::createNewWebProcess): Pass timeout as initialization message (unlike plugin process proxy, web process proxy doesn't wait, and relies on the message being queued). (WebKit::WebContext::disconnectProcess): Skip invalidating global managers when one process quits. We still need to do something, but running this code would just result in assertion failures any time a page was closed.
4:25 PM Changeset in webkit [127333] by commit-queue@webkit.org
  • 15 edits in trunk/Source/JavaScriptCore

Refactor LLInt and supporting code in preparation for the C Loop backend.
https://bugs.webkit.org/show_bug.cgi?id=95531.

Patch by Mark Lam <mark.lam@apple.com> on 2012-08-31
Reviewed by Filip Pizlo.

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):

  • jit/JITExceptions.cpp:

(JSC::genericThrow): Use ExecutableBase::catchRoutineFor() to fetch

fetch the catch routine for a thrown exception. This will allow
us to redefine that for the C loop later, and still keep this
code readable.

  • llint/LLIntOfflineAsmConfig.h: Moved ASM macros to

LowLevelInterpreter.cpp which is the only place they are used. This
will make it more convenient to redefine them for the C loop later.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setUpCall): Use ExecutableBase's hostCodeEntry()

jsCodeEntryFor(), and jsCodeWithArityCheckEntryFor() for computing
the entry points to functions being called.

  • llint/LLIntSlowPaths.h:

(SlowPathReturnType):
(JSC::LLInt::encodeResult):
(LLInt):
(JSC::LLInt::decodeResult): Added. Needed by LLInt C Loop later.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter.cpp:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/asm.rb: Disambiguate between opcodes and other labels.
  • offlineasm/config.rb:
  • runtime/Executable.h:

(JSC::ExecutableBase::hostCodeEntryFor): Added.
(ExecutableBase):
(JSC::ExecutableBase::jsCodeEntryFor): Added.
(JSC::ExecutableBase::jsCodeWithArityCheckEntryFor): Added.
(JSC::ExecutableBase::catchRoutineFor): Added.

  • runtime/JSValueInlineMethods.h:

(JSC):

4:16 PM Changeset in webkit [127332] by jberlin@webkit.org
  • 2 edits
    1 copy
    1 add in trunk/LayoutTests

[Lion] css3/filters/composited-during-animation-layertree.html produces empty results
https://bugs.webkit.org/show_bug.cgi?id=95622

Move the empty results to mac-lion and add the ML results to mac to get the bots greener.

  • platform/mac-lion/css3/filters/composited-during-animation-layertree-expected.txt: Copied from LayoutTests/platform/mac/css3/filters/composited-during-animation-layertree-expected.txt.
  • platform/mac/css3/filters/composited-during-animation-layertree-expected.txt:
4:08 PM Changeset in webkit [127331] by roger_fong@apple.com
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed. Getting rid of Windows specific results because CSS3 flexbox has been re-enabled here: https://bugs.webkit.org/show_bug.cgi?id=95382

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
4:00 PM Changeset in webkit [127330] by jberlin@webkit.org
  • 2 edits
    1 copy
    1 move
    1 add in trunk/LayoutTests

[Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing.
https://bugs.webkit.org/show_bug.cgi?id=95477

Add Mountain Lion expected (failing?) results and move the ones previously in mac to mac-lion to get the bots greener.

  • platform/mac-lion/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png.
  • platform/mac-lion/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt: Copied from LayoutTests/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt.
  • platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt:
3:56 PM Changeset in webkit [127329] by pdr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed update of fast/js/function-constructor-this-value.html expectations on Chromium
https://bugs.webkit.org/show_bug.cgi?id=95617

This test was added in r127323 but fails on Chromium ports.

  • platform/chromium/TestExpectations:
3:51 PM Changeset in webkit [127328] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Assert on ChromeClientGtk::scroll with delta (0, -1).
https://bugs.webkit.org/show_bug.cgi?id=95590

Change the assert to avoid hitting when the delta does not have any
value > 0.

Patch by José Dapena Paz <jdapena@igalia.com> on 2012-08-31
Reviewed by Martin Robinson.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::scroll):

3:29 PM Changeset in webkit [127327] by krit@webkit.org
  • 12 edits
    3 adds in trunk

Introduce new CSS property for clip-path
https://bugs.webkit.org/show_bug.cgi?id=95474

Reviewed by Tim Horton.

Source/WebCore:

This path introduces the new, prefixed CSS property 'clip-path' from the
CSS Masking specification. In a first step the property just accepts
'none' and the the basic shapes from CSS Exclusion. Later it will also be
possible to reference SVG 'clipPath' elements - like Firefox already does.
To enable the parsing of the shapes, the exclusion compiler flags
around the shape parser were removed.

http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html

Test: fast/masking/parsing-clip-path-shape.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return CSSValue for CSSPropertyWebkitClipPath.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Add CSSPropertyWebkitClipPath.
(WebCore::CSSParser::parseBasicShape): Modify parser function to accept CSSPropertyWebkitClipPath as well.

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in: Added property name -webkit-clip-path.
  • css/StyleBuilder.cpp:

(ApplyPropertyClipPath): New property applier just for -webkit-clip-path.
(WebCore::ApplyPropertyClipPath::setValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyClipPath::createHandler):
(WebCore::StyleBuilder::StyleBuilder):

  • rendering/style/RenderStyle.cpp: Repaint if there is a difference between two BasicShapes.

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):

  • rendering/style/StyleRareNonInheritedData.h: Add new member variable for clip shape.

(StyleRareNonInheritedData):

LayoutTests:

Test parsing behavior of basic shapes on new introduced '-webkit-clip-path' CSS property.

  • fast/masking/parsing-clip-path-shape-expected.txt: Added.
  • fast/masking/parsing-clip-path-shape.html: Added.
3:17 PM Changeset in webkit [127326] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ASSERT failure in RenderBlock::checkPositionedObjectsNeedLayout
https://bugs.webkit.org/show_bug.cgi?id=95611

Reviewed by Antonio Gomes.
Patch by Jacky Jiang <zhajiang@rim.com>

PR:200127
Remove r118405 now as we already have a new fix webkit/43f8394b for
that issue and it is not reproducible anymore after the removal.
In this way, we can get rid of this ASSERT failure as well.
Thanks Antonio for the suggestion.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

3:09 PM Changeset in webkit [127325] by rwlbuis@webkit.org
  • 4 edits in trunk/Source

[BlackBerry] Eliminate WebGL IT policy
https://bugs.webkit.org/show_bug.cgi?id=95604
Internal RIM PR #198764

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-08-31
Reviewed by Rob Buis.

This is no longer a requirement for the BlackBerry port.

Source/WebCore:

No new tests, because this introduces no new functionality.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::setWebGLEnabled):

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::configPage):

2:49 PM Changeset in webkit [127324] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

Not reviewed.

Removed some tabs that snuck into my last patch.

  • fast/js/function-constructor-this-value.html:
2:47 PM Changeset in webkit [127323] by ggaren@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Use one object instead of two for closures, eliminating ScopeChainNode
https://bugs.webkit.org/show_bug.cgi?id=95501

Reviewed by Sam Weinig.

Adding a test to demonstrate the behavior change in this patch.

  • fast/js/function-constructor-this-value-expected.txt: Added.
  • fast/js/function-constructor-this-value.html: Added.
2:34 PM Changeset in webkit [127322] by timothy@apple.com
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Merge r127319 for <rdar://problem/12217897>.

2:26 PM Changeset in webkit [127321] by jonlee@apple.com
  • 5 edits in trunk

ondisplay event handlers are not called
https://bugs.webkit.org/show_bug.cgi?id=95263
<rdar://problem/12193359>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

To support the legacy API, we conflate ondisplay and onshow.

  • Modules/notifications/Notification.h:

(WebCore::Notification::ondisplay): Use display event as an alias for the show event.
(WebCore::Notification::setOndisplay):

LayoutTests:

Adjust the test to use the ondisplay handler, to fully test legacy API.

  • http/tests/notifications/legacy/show-expected.txt: Verify that event listener for ondisplay is

the same as that for onshow.

  • http/tests/notifications/legacy/show.html:
2:24 PM Changeset in webkit [127320] by roger_fong@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed. Adding passing test results for fast/canvas/canvas-strokeRect-alpha-shadow.
Test passes on Windows port now but Mac port currently uses expected failing results.

  • platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
2:18 PM Changeset in webkit [127319] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r127252): incomplete repaint on Flash element after pinch to zoom
<rdar://problem/12217897> and https://bugs.webkit.org/show_bug.cgi?id=95607

Reviewed by Simon Fraser.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::viewGeometryDidChange): Only give the window coordinate clip rect a chance

to override the boundsRect() if the page scale factor is 1.

2:17 PM Changeset in webkit [127318] by tony@chromium.org
  • 37 edits in trunk

Remove ENABLE_CSS3_FLEXBOX compile time flag
https://bugs.webkit.org/show_bug.cgi?id=95382

Reviewed by Ojan Vafai.

Everyone is already enabling this by default and the spec has stablized.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests, shouldn't change anything.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.features.am:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue): Expand check range to include flex and inline-flex.
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::asText):

  • css/StylePropertyShorthand.cpp:

(WebCore::webkitFlexShorthand):
(WebCore::shorthandForProperty):

  • css/StylePropertyShorthand.h:

(WebCore):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimation::ensurePropertyMap):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
2:11 PM Changeset in webkit [127317] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Add main versus impl thread asserts
https://bugs.webkit.org/show_bug.cgi?id=95596

Patch by Christopher Cameron <ccameron@chromium.org> on 2012-08-31
Reviewed by James Robinson.

Add asserts to prioritized texture manager that specify that a
function be called on the main or impl thread.

Add debug signs that the main thread is blocked to the threaded
proxy.

Add a mechanism to simultaneously set the thread to the impl thread
and indicate that the main thread is blocked.

Update tests that hit asserts in the prioritized texture manager to
set their impl thread and main thread blocked state correctly.

Source/WebCore:

  • platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:

(WebCore::CCPrioritizedTextureManager::prioritizeTextures):
(WebCore::CCPrioritizedTextureManager::clearPriorities):
(WebCore::CCPrioritizedTextureManager::requestLate):
(WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
(WebCore::CCPrioritizedTextureManager::reduceMemory):
(WebCore::CCPrioritizedTextureManager::registerTexture):
(WebCore::CCPrioritizedTextureManager::unregisterTexture):
(WebCore::CCPrioritizedTextureManager::returnBackingTexture):
(WebCore::CCPrioritizedTextureManager::createBacking):
(WebCore::CCPrioritizedTextureManager::assertInvariants):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(WebCore):
(DebugScopedSetImplThreadAndMainThreadBlocked):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::setVisible):
(WebCore::CCThreadProxy::initializeRenderer):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::implSideRenderingStats):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::forceSerializeOnSwapBuffers):
(WebCore::CCThreadProxy::acquireLayerTextures):

Source/WebKit/chromium:

  • tests/CCPrioritizedTextureTest.cpp:

(WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::validateTexture):
(WTF::TEST_F):

  • tests/TiledLayerChromiumTest.cpp:
2:03 PM Changeset in webkit [127316] by pdr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed update of fast/js/function-apply-aliased.html expectations.

fast/js/function-apply-aliased.html has been failing for TEXT for some time but
the chromium-mac TestExpectations did not have an entry for mac. This patch
updates the expectations to include all platforms.

The bug (crbug.com/48239) has been updated to reflect this.

  • platform/chromium/TestExpectations:
1:55 PM Changeset in webkit [127315] by jberlin@webkit.org
  • 4 edits in trunk/LayoutTests

LayoutTests/http/tests/websocket/tests/hixie76/frame-lengths.html was removed. Remove it from the Skipped list.

  • platform/mac-wk2/Skipped:
  • platform/qt-arm/Skipped:
  • platform/wincairo/Skipped:
1:55 PM Changeset in webkit [127314] by jberlin@webkit.org
  • 4 edits in trunk/LayoutTests

compositing/tiling/huge-layer* flakey
https://bugs.webkit.org/show_bug.cgi?id=48454

These tests were disabled in r89631. Remove them from the Skipped list so that
run-webkit-tests doesn't try to find them.

  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
1:47 PM Changeset in webkit [127313] by psolanki@apple.com
  • 2 edits in trunk/Source/WebKit2

objc_msgSend and IMP should be cast appropriately before using
https://bugs.webkit.org/show_bug.cgi?id=95242

Reviewed by Benjamin Poulain.

Follow on fix for Mac EWS - use objc-runtime.h instead of runtime.h so
that it finds the declaration for objc_msgSend.

  • UIProcess/API/mac/PDFViewController.mm:
1:41 PM Changeset in webkit [127312] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

The fast/forms/ file tests were moved in the file sub-directory in r96918. Remove the
old entries from the Skipped list.

  • platform/mac-wk2/Skipped:
1:40 PM Changeset in webkit [127311] by jamesr@google.com
  • 16 edits
    1 copy
    2 adds in trunk/Source

[chromium] Put compositor client interfaces in separate headers, normalize naming
https://bugs.webkit.org/show_bug.cgi?id=95522

Reviewed by Adam Barth.

Source/WebCore:

Client interfaces should be in their own headers so code implementing these interfaces do not have to
transitively #include all of the compositor internals.

We call things 'clients' not 'delegates' in the compositor.

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerChromium::create):
(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::drawsContent):
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/ContentLayerChromium.h:

(WebCore):
(ContentLayerPainter):
(ContentLayerChromium):
(WebCore::ContentLayerChromium::clearClient):

  • platform/graphics/chromium/TextureLayerChromium.cpp:
  • platform/graphics/chromium/TextureLayerChromium.h:

(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):

Source/WebKit/chromium:

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::~WebContentLayerImpl):

  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • src/WebExternalTextureLayerImpl.h:
  • src/WebLayerTreeViewImpl.h:

(WebCore):

  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WebKitTests::ContentLayerChromiumWithUpdateTracking::create):
(WebKitTests::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WebKitTests::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WebKitTests::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
(WebKitTests::CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources):
(CCLayerTreeHostTestLostContextWhileUpdatingResources):

  • tests/ContentLayerChromiumTest.cpp:

(WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
(WebKit::TEST):

1:36 PM Changeset in webkit [127310] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Adding fast/css/nested-layers-with-over.html to Windows skip list.
https://bugs.webkit.org/show_bug.cgi?id=95388

  • platform/win/Skipped:
1:32 PM Changeset in webkit [127309] by mhahnenberg@apple.com
  • 2 edits in trunk/LayoutTests

Unskip plugins/npruntime/delete-plugin-within-* tests on Windows
https://bugs.webkit.org/show_bug.cgi?id=95597

Reviewed by Darin Adler.

  • platform/win/Skipped:
1:28 PM Changeset in webkit [127308] by jonlee@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip http/tests/notifications on Lion, since there is no support.

  • platform/mac-lion/Skipped:
1:15 PM Changeset in webkit [127307] by roger_fong@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed. Adding expected failing results for accessibility/canvas tests.
https://bugs.webkit.org/show_bug.cgi?id=95598

Windows description and role strings don't match up with what is expected on Mac.
Particularly, they do not include the "AX" at the beginning of the descriptions/roles of canvas fallback content.

  • platform/win/accessibility/canvas-description-and-role-expected.txt: Added.
  • platform/win/accessibility/canvas-fallback-content-expected.txt:
1:11 PM Changeset in webkit [127306] by psolanki@apple.com
  • 9 edits in trunk

objc_msgSend and IMP should be cast appropriately before using
https://bugs.webkit.org/show_bug.cgi?id=95242

Reviewed by Benjamin Poulain.

Fix for older compilers. Pass id as the return type to the template
instead of relying on default type.

Source/WebKit/mac:

  • WebView/WebDelegateImplementationCaching.mm:

(CallDelegate):
(CallFormDelegate):

  • WebView/WebHTMLView.mm:

(setCursor):
(setNeedsDisplayInRect):

Source/WTF:

  • wtf/Functional.h:

(WTF::R):

  • wtf/ObjcRuntimeExtras.h:

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(drt_NSFontManager_availableFontFamilies):

  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::wtr_NSFontManager_availableFontFamilies):

1:10 PM Changeset in webkit [127305] by gavinp@chromium.org
  • 4 edits in trunk

[chromium] DEPS roll with a test skip.
https://bugs.webkit.org/show_bug.cgi?id=95601

Unreviewed gardening & DEPS roll.

Source/WebKit/chromium:

fast/frames/cached-frame-counter.html was never the most stable test, and now it's failing on more platforms. Marking it flaky, along with a DEPS roll (earlier attempts at the DEPS roll failed on this)

  • DEPS:

LayoutTests:

fast/frames/cached-frame-counter.html was never the most stable test, and now it's failing on more platforms. Marking it flaky, along with a DEPS roll (earlier attempts at the DEPS roll failed on this)

  • platform/chromium/TestExpectations:
1:10 PM Changeset in webkit [127304] by ggaren@apple.com
  • 23 edits in trunk/Source/JavaScriptCore

Not reviewed.

Rolled out http://trac.webkit.org/changeset/127293 because it broke
inspector tests on Windows.

Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

12:51 PM Changeset in webkit [127303] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the Debug builds after r127277

Unreviewed.

One assertion was not updated in r127277. The encapsulation of CSSParserString's length
has changed and now use an accessor.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-31

  • css/CSSParser.cpp:

(WebCore::CSSParser::storeVariableDeclaration):

12:49 PM Changeset in webkit [127302] by zandobersek@gmail.com
  • 7 edits in trunk/Tools

nrwt: use scm instead of calling svn directly to get the revision in json results generator
https://bugs.webkit.org/show_bug.cgi?id=89616

Reviewed by Eric Seidel.

Add the new 'executive' optional function argument to the SCM.in_working_directory
class method. This way we get to reuse an Executive instance which is necessary in testing
when we're operating with a mock version of the object.

In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
the SCMDetector with the generator's FileSystem and Executive instances.

  • Scripts/webkitpy/common/checkout/scm/detection.py:

(SCMDetector.detect_scm_system):

  • Scripts/webkitpy/common/checkout/scm/detection_unittest.py:

(SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
Executive output and test it against expected output.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.in_working_directory):

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.in_working_directory):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.in_working_directory):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase.init):
(JSONResultsGeneratorBase._get_svn_revision):

12:38 PM Changeset in webkit [127301] by Simon Fraser
  • 6 edits
    2 adds in trunk

(Regression: r126774): Fix crash when scrolling after removing inline sticky element
https://bugs.webkit.org/show_bug.cgi?id=95584

Reviewed by Dave Hyatt.

Source/WebCore:

Move fixed/sticky registration and unregistration with the FrameView from
RenderBox and RenderInline into RenderBoxModelObject, which also
fixes the issue that inlines didn't unregister themselves on destruction.

Test: fast/css/sticky/remove-inline-sticky-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed): Code moved to RenderBoxModelObject. No need
to null-check style.
(WebCore::RenderBox::styleWillChange): Code moved to RenderBoxModelObject.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed): Remove fixed objects. Check
isPositioned() to avoid this work for most non-positioned renderers.
(WebCore::RenderBoxModelObject::styleWillChange): Register and unregister fixed
and sticky objects with the FrameView.

  • rendering/RenderInline.cpp: styleWillChange() is no longer needed.
  • rendering/RenderInline.h: Ditto.

LayoutTests:

Testcase removes an inline sticky, then scrolls.

  • fast/css/sticky/remove-inline-sticky-crash-expected.txt: Added.
  • fast/css/sticky/remove-inline-sticky-crash.html: Added.
12:11 PM Changeset in webkit [127300] by commit-queue@webkit.org
  • 35 edits in trunk/Source/WebCore

Remove extraneous includes (Node.h, Document.h, Element.h, RenderObject.h)
https://bugs.webkit.org/show_bug.cgi?id=95259

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-31
Reviewed by Sam Weinig.

Node.h, Document.h, Element.h, and RenderObject.h are four of the most
expensive headers to include. This patch removes them from many of the
places they are not needed. There is a minor compile-time performance
boost.

  • dom/ElementShadow.h:
  • dom/Range.h:

(WebCore):

  • dom/TreeScopeAdopter.h:

(WebCore):

  • editing/VisiblePosition.h:

(WebCore):

  • html/HTMLCollection.h:

(WebCore):

  • html/parser/HTMLElementStack.h:
  • html/parser/HTMLTreeBuilder.h:

(WebCore):

  • html/track/WebVTTParser.h:

(WebCore):

  • inspector/InspectorCSSAgent.h:

(WebCore):

  • inspector/InspectorInstrumentation.h:

(WebCore):

  • inspector/InspectorOverlay.h:
  • loader/ImageLoader.h:
  • loader/TextTrackLoader.h:

(WebCore):

  • platform/chromium/PopupListBox.cpp:
  • platform/chromium/PopupListBox.h:

(WebCore):

  • platform/graphics/MediaPlayer.h:

(WebCore):

  • rendering/FilterEffectRenderer.h:
  • rendering/InlineFlowBox.cpp:
  • rendering/RenderCounter.cpp:
  • rendering/RenderGeometryMap.h:

(WebCore):

  • rendering/RenderInputSpeech.h:

(WebCore):

  • rendering/RenderMediaControls.h:

(WebCore):

  • rendering/RenderMediaControlsChromium.h:

(WebCore):

  • rendering/RenderQuote.cpp:
  • rendering/RenderQuote.h:

(WebCore):

  • rendering/RenderScrollbar.h:

(WebCore):

  • rendering/RenderText.h:

(WebCore):

  • rendering/RenderTheme.h:

(WebCore):

  • rendering/RenderThemeChromiumSkia.h:

(WebCore):

  • rendering/svg/RenderSVGResourceMarker.h:

(WebCore):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore):

  • xml/NativeXPathNSResolver.h:

(WebCore):
(NativeXPathNSResolver):
(WebCore::NativeXPathNSResolver::create):

  • xml/XPathStep.h:

(WebCore):
(XPath):
(Step):
(NodeTest):
(WebCore::XPath::Step::NodeTest::NodeTest):
(WebCore::XPath::Step::NodeTest::kind):
(WebCore::XPath::Step::NodeTest::data):
(WebCore::XPath::Step::NodeTest::namespaceURI):
(WebCore::XPath::Step::NodeTest::mergedPredicates):
(WebCore::XPath::Step::axis):
(WebCore::XPath::Step::nodeTest):

  • xml/parser/NewXMLDocumentParser.cpp:
  • xml/parser/NewXMLDocumentParser.h:

(WebCore):

  • xml/parser/XMLToken.h:
  • xml/parser/XMLTreeBuilder.cpp:
  • xml/parser/XMLTreeBuilder.h:

(WebCore):

12:08 PM Changeset in webkit [127299] by jonlee@apple.com
  • 19 edits
    11 adds in trunk

[Tests] Add basic tests to http/tests/notifications
https://bugs.webkit.org/show_bug.cgi?id=95493
<rdar://problem/12209303>

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Simplify the passing of the permission policy to just a boolean instead of converting it
back and forth from the NotificationClient::Permission enum.

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Move the declaration to the section

of functions that are TestRunner SPI.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setWebNotificationPermission): Use a boolean.

  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::setPermissionLevelForTesting):

  • WebProcess/Notifications/NotificationPermissionRequestManager.h:

(NotificationPermissionRequestManager):

  • win/WebKit2.vcproj: Add WKNotificationPermissionRequest.{h,cpp}.
  • win/WebKit2Generated.make: Export WKNotificationPermissionRequest.h.

Tools:

Add permission request support for WTR.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
(WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.

  • WebKitTestRunner/TestController.h:

(TestController):

LayoutTests:

  • http/tests/notifications/request-expected.txt: Added.
  • http/tests/notifications/request.html: Added. This test requests permission. DRT/WTR

is expected to accept it, and we verify that both the parameter in the callback function,
and Notification.permission, are both set to "granted".

  • http/tests/notifications/show-expected.txt: Added.
  • http/tests/notifications/show.html: Added. This test checks that the various permission

APIs on TestRunner work.

Legacy analog to above tests.

  • http/tests/notifications/legacy/request-expected.txt: Added.
  • http/tests/notifications/legacy/request.html: Added.
  • http/tests/notifications/legacy/show-expected.txt: Added.
  • http/tests/notifications/legacy/show.html: Added.
  • http/tests/resources/js-test-post-async.js: Added. This will be used for most tests since

the events are called asynchronously.

  • http/tests/resources/js-test-pre.js: Updated from fast/js/resources.
  • http/tests/resources/notifications-test-pre.js: Added. Adds a helper function to complete

the test, and defines the domain of http/tests.
(testCompleted):

Skip.

  • platform/chromium/TestExpectations: Skip on Android. Filed 95506 to bring Chromium support.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped: Filed 95507 to bring Qt support.
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
11:55 AM Changeset in webkit [127298] by jonlee@apple.com
  • 5 edits in trunk/Tools

[DRT] Make simulating a web click on a notification a queued task
https://bugs.webkit.org/show_bug.cgi?id=95546
<rdar://problem/12214170>

Reviewed by Alexey Proskuryakov.

Making the web click happen asynchronously better mimics user interaction with the platform.

  • DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.

(TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
not set.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dump): Assert that the flag is not set.

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
notification. In the case where the block gets executed after the flag has been unset, we avoid
performing the click.

11:51 AM Changeset in webkit [127297] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

[New Multicolumn] Implement column repainting.
https://bugs.webkit.org/show_bug.cgi?id=95593

Reviewed by Dan Bernstein.

Make the new columns repaint properly. Note this code is a significant improvement over the
old multicolumn code in that repaints are properly issued per-column, i.e., no more fuzzy
uniting of rects.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::columnIndexAtOffset):
(WebCore):
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):

  • rendering/RenderMultiColumnSet.h:
11:45 AM Changeset in webkit [127296] by pdr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed update of test expectations.

Marking media/track/track-cue-rendering-snap-to-lines-not-set.html as
flaky again until WK89167 is fixed.

  • platform/chromium/TestExpectations:
11:25 AM Changeset in webkit [127295] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed Gardening. inspector/profiler/webgl/webgl-profiler-api-changes.html fails on Windows.
WebGL not enabled on Windows.

  • platform/win/Skipped:
11:24 AM Changeset in webkit [127294] by alokp@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Layout tests svg-filters.html and alpha.html are crashing intermittently
https://bugs.webkit.org/show_bug.cgi?id=92660

Reviewed by James Robinson.

We use two GL contexts to create and upload tile textures.
One context creates the texture, while another uploads it.
Even though the texture is shared by the two contexts, it is not
available to the uploading context immediately after creation,
unless the creating context is flushed.

  • platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::createAcceleratedCanvas):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

11:22 AM Changeset in webkit [127293] by ggaren@apple.com
  • 23 edits in trunk/Source/JavaScriptCore

Shrink activation objects by half
https://bugs.webkit.org/show_bug.cgi?id=95591

Reviewed by Sam Weinig.

Removed the global object, global data, and global this pointers from
JSScope, and changed an int to a bitfield. This gets the JSActivation
class down to 64 bytes, which in practice cuts it in half by getting it
out of the 128 byte size class.

Now, it's one extra indirection to get these pointers. These pointers
aren't accessed by JIT code, so I thought there would be no cost to the
extra indirection. However, some C++-heavy SunSpider tests regressed a
bit in an early version of the patch, which added even more indirection.
This suggests that calls to exec->globalData() and/or exec->lexicalGlobalObject()
are common and probably duplicated in lots of places, and could stand
further optimization in C++.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute): Test against the specific activation
for our global object, since there's no VM-shared activation structure
anymore. This is guaranteed to have the same success rate as the old test
because activation scope is fixed at compile time.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::globalData):

  • heap/WeakSet.cpp:

(JSC::WeakSet::addAllocator):

  • heap/WeakSet.h:

(WeakSet):
(JSC::WeakSet::WeakSet):
(JSC::WeakSet::globalData): Store a JSGlobalData* instead of a Heap*
because JSGlobalData->Heap is just a constant fold in the addressing
mode, while Heap->JSGlobalData is an extra pointer dereference. (These
objects should eventually just merge.)

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve_global_dynamic): See DFGAbstractState.cpp.

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm: Load the activation structure from

the code block instead of the global data because the structure is not
VM-shared anymore. (See DFGAbstractState.cpp.)

  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):

  • runtime/JSActivation.h:

(JSActivation): This is the point of the patch: Remove the data.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData): No longer VM-shared. (See DFGAbstractState.cpp.)

(JSC::WeakSet::heap): (See WeakSet.h.)

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::setGlobalThis):
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::withScopeStructure):
(JSC::JSGlobalObject::strictEvalActivationStructure):
(JSC::JSGlobalObject::activationStructure):
(JSC::JSGlobalObject::nameScopeStructure):
(JSC::JSScope::globalThis):
(JSC::JSGlobalObject::globalThis): Data that used to be in the JSScope
class goes here now, so it's not duplicated across all activations.

  • runtime/JSNameScope.h:

(JSC::JSNameScope::JSNameScope):

  • runtime/JSScope.cpp:

(JSC::JSScope::visitChildren): This is the point of the patch: Remove the data.

  • runtime/JSScope.h:

(JSScope):
(JSC::JSScope::JSScope):
(JSC::JSScope::globalObject):
(JSC::JSScope::globalData):

  • runtime/JSSegmentedVariableObject.h:

(JSC::JSSegmentedVariableObject::JSSegmentedVariableObject):

  • runtime/JSSymbolTableObject.h:

(JSC::JSSymbolTableObject::JSSymbolTableObject):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::JSVariableObject):

  • runtime/JSWithScope.h:

(JSC::JSWithScope::JSWithScope):

  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::StrictEvalActivation): Simplified now that
we don't need to pass so much data to JSScope.

11:12 AM Changeset in webkit [127292] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Mark http/tests/security/inactive-document-with-empty-security-origin.html while Geoff Garen
investigates in https://bugs.webkit.org/show_bug.cgi?id=95501 in order to get the bots green.

  • platform/mac/TestExpectations:
11:07 AM Changeset in webkit [127291] by gavinp@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Fix platform/chromium/TestExpectations typo
https://bugs.webkit.org/show_bug.cgi?id=95592

Unreviewed gardening.

Unfortunately r127174 contained a typo that broke webkit-lint on our build. See https://bugs.webkit.org/show_bug.cgi?id=95581 .

  • platform/chromium/TestExpectations:
11:00 AM Changeset in webkit [127290] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

fast/css/align-positioned-object-on-resize.html skipped on Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=83489

This test was removed in r126911. Remove it from the Skipped list.

  • platform/mac/Skipped:
  • platform/win/Skipped:
11:00 AM Changeset in webkit [127289] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/cache/cancel-in-progress-load.html fails on several platforms
https://bugs.webkit.org/show_bug.cgi?id=87728

The test was rolled out in r119918. Remove it from the Skipped list so that run-webkit-tests
doesn't complain about not being able to find the test.

  • platform/mac/Skipped:
11:00 AM Changeset in webkit [127288] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

plugins/npruntime/leak-window-scriptable-object.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90710

This test was removed in r91637. Remove it from the Skipped list so that run-webkit-tests
doesn't complain about not being able to find the test.

  • platform/mac/Skipped:
11:00 AM Changeset in webkit [127287] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] http/tests/cookies/js-get-and-set-http-only-cookie.html failing since introduction in r119947
https://bugs.webkit.org/show_bug.cgi?id=87208

The .php version was removed in r118166, but the .html version it was replaced with in r119947
was separately marked as failing on Qt. Update the Skipped lists so that run-webkit-tests
doesn't complain about not being able to find the test on Mac (and so that the comment in the
Qt Skipped list is correct).

  • platform/mac/Skipped:
  • platform/qt/Skipped:
11:00 AM Changeset in webkit [127286] by jberlin@webkit.org
  • 3 edits in trunk/LayoutTests

fast/workers/storage/interrupt-database-sync.html fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=49906

The test was disabled in r81333, so remove it from the Skipped lists so that run-webkit-tests
doesn't complain about not being able to find the test.

  • platform/win-xp/Skipped:
  • platform/wk2/Skipped:
10:58 AM Changeset in webkit [127285] by kareng@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp

Merge 124689 - Disabling eval changes the timing of DidCreateScriptContext
https://bugs.webkit.org/show_bug.cgi?id=92189

Reviewed by Eric Seidel.

When we implemented Content-Security-Policy, we added the ability to
disable eval in the JavaScript engine. However, when we process the
Content-Security-Policy header, we might not have initialized the
script context for the given frame.

Previously, we would initialize the context, but that generates a
DidCreateScriptContext callback to the embedder earlier in the Document's
lifetime that before. A natural thing to do in this callback is to run
script to customize the script context, but Document isn't fully
initialized yet, which leads to odd bugs and general confusion.

In this patch, we delay actually disabling eval until we would have
created the scripting context previously. From the perspective of the
web platform, this has the same behavior. The only difference is that
now the DidCreateScriptContext notification occurs at the same time
regardless of whether Content-Security-Policy disables eval.

I tried to write a test for this change, but it was unclear to me how
to write a good test. I tried writing a Chromium WebKit unit test to no
avail. The good news is that this patch will be covered by the
PlatformAppBrowserTest.Iframes test in Chromium once
https://bugs.webkit.org/show_bug.cgi?id=93079 lands. That's not the
best way to test this change, but it might be sufficient.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initScript):
(WebCore::ScriptController::disableEval):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::enableEval):
(WebCore::ScriptController::disableEval):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

TBR=abarth@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10919034

10:50 AM Changeset in webkit [127284] by timothy@apple.com
  • 2 edits in branches/safari-536.26-branch/LayoutTests

Rename testRunner to layoutTestController for a test on the branch.

Patch by Brady Eidson <beidson@apple.com> on 2012-08-31
Rubberstamped by Tim Hatcher.

  • platform/mac-wk2/plugins/npp-setwindow-called-on-scroll.html:
10:50 AM Changeset in webkit [127283] by kareng@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp

Merge 124689 - Disabling eval changes the timing of DidCreateScriptContext
https://bugs.webkit.org/show_bug.cgi?id=92189

Reviewed by Eric Seidel.

When we implemented Content-Security-Policy, we added the ability to
disable eval in the JavaScript engine. However, when we process the
Content-Security-Policy header, we might not have initialized the
script context for the given frame.

Previously, we would initialize the context, but that generates a
DidCreateScriptContext callback to the embedder earlier in the Document's
lifetime that before. A natural thing to do in this callback is to run
script to customize the script context, but Document isn't fully
initialized yet, which leads to odd bugs and general confusion.

In this patch, we delay actually disabling eval until we would have
created the scripting context previously. From the perspective of the
web platform, this has the same behavior. The only difference is that
now the DidCreateScriptContext notification occurs at the same time
regardless of whether Content-Security-Policy disables eval.

I tried to write a test for this change, but it was unclear to me how
to write a good test. I tried writing a Chromium WebKit unit test to no
avail. The good news is that this patch will be covered by the
PlatformAppBrowserTest.Iframes test in Chromium once
https://bugs.webkit.org/show_bug.cgi?id=93079 lands. That's not the
best way to test this change, but it might be sufficient.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initScript):
(WebCore::ScriptController::disableEval):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::enableEval):
(WebCore::ScriptController::disableEval):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

TBR=abarth@webkit.org

10:48 AM Changeset in webkit [127282] by kareng@chromium.org
  • 4 edits in branches/chromium/1132/Source/WebCore

Merge 124689 - Disabling eval changes the timing of DidCreateScriptContext
https://bugs.webkit.org/show_bug.cgi?id=92189

Reviewed by Eric Seidel.

When we implemented Content-Security-Policy, we added the ability to
disable eval in the JavaScript engine. However, when we process the
Content-Security-Policy header, we might not have initialized the
script context for the given frame.

Previously, we would initialize the context, but that generates a
DidCreateScriptContext callback to the embedder earlier in the Document's
lifetime that before. A natural thing to do in this callback is to run
script to customize the script context, but Document isn't fully
initialized yet, which leads to odd bugs and general confusion.

In this patch, we delay actually disabling eval until we would have
created the scripting context previously. From the perspective of the
web platform, this has the same behavior. The only difference is that
now the DidCreateScriptContext notification occurs at the same time
regardless of whether Content-Security-Policy disables eval.

I tried to write a test for this change, but it was unclear to me how
to write a good test. I tried writing a Chromium WebKit unit test to no
avail. The good news is that this patch will be covered by the
PlatformAppBrowserTest.Iframes test in Chromium once
https://bugs.webkit.org/show_bug.cgi?id=93079 lands. That's not the
best way to test this change, but it might be sufficient.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initScript):
(WebCore::ScriptController::disableEval):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::enableEval):
(WebCore::ScriptController::disableEval):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded):

TBR=abarth@webkit.org

10:45 AM Changeset in webkit [127281] by pdr@google.com
  • 2 edits in trunk/LayoutTests

Mark fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html as failing on mac
https://bugs.webkit.org/show_bug.cgi?id=95588

Unreviewed gardening.

This test is failing on mac due to the sizing of the textbox: in the
expected results there is no scrollbar but in the actual results there
is one. This patch marks this test as failing temporarily.

  • platform/chromium/TestExpectations:
10:37 AM Changeset in webkit [127280] by hyatt@apple.com
  • 7 edits in trunk/Source/WebCore

[New Multicolumn] Refactor flow thread repainting.
https://bugs.webkit.org/show_bug.cgi?id=95586

Reviewed by Simon Fraser.

Refactor flow thread repainting in regions to delegate the work to the region. This allows subclasses
to customize how the repainting happens so that individual repaints can be issued for columns and pages
inside sets.

repaintFlowThreadContent is the new virtual function that can be subclassed by sets to customize
the repaint process.

repaintFlowThreadContentRectangle is a parameterized helper that will be called for each individual
column and page in a set.

  • WebCore.exp.in:

Change repaintRectangle's signature to be const.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::repaintRectangleInRegions):
Now delegates the work for each region to RenderRegion::repaintFlowThreadContent.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::isRooted):

  • rendering/RenderObject.h:

Change a bunch of functions to be const.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::repaintFlowThreadContent):
(WebCore):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):

  • rendering/RenderRegion.h:

(RenderRegion):
Add the two new functions (the virtual repaintFlowThreadContent and the helper it
uses, repaintFlowThreadContentRectangle).

10:34 AM Changeset in webkit [127279] by commit-queue@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed, rolling out r127182.
http://trac.webkit.org/changeset/127182
https://bugs.webkit.org/show_bug.cgi?id=95587

Reftests shouldn't be rebaselined (Requested by pdr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-31

  • platform/chromium-mac-snowleopard/fast/dom/shadow/shadowdom-for-textarea-complex-shadow-expected.png: Removed.
  • platform/chromium-mac/fast/dom/shadow/shadowdom-for-textarea-complex-shadow-expected.png: Removed.
10:28 AM Changeset in webkit [127278] by yoli@rim.com
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Disable GCController timer for PLATFORM(BLACKBERRY)
https://bugs.webkit.org/show_bug.cgi?id=93007

Reviewed by Rob Buis.

Disable GCController timer.

  • bindings/js/GCController.cpp:

(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):
(WebCore):

  • bindings/js/GCController.h:

(GCController):

10:26 AM Changeset in webkit [127277] by msaboff@apple.com
  • 15 edits
    2 adds in trunk

CSS Parser should directly parse 8 bit source strings
https://bugs.webkit.org/show_bug.cgi?id=95207

Reviewed by Geoffrey Garen.

Source/WebCore:

Changed CSSParser to handle 8 bit strings directly. Templatized most private parsing methods
and helper methods by character type. Introduced several templatized helper methods for
parsing methods. Some of these helper methods have independent source and destination template
types to handle that an 8 bit source string when parsed produces a 16 bit result. This is due
to unicode escapes. Renamed the lex method "realLex" and made it a templated method. The lex
method that is called by cssyylex(), which is now inlined, invokes the correct instance of realLex
via a member function pointer.

Split out the encoding part of parseEscape() into a new templated UnicodeToChars() method.

Added 8/16 bit switching to CSSParserString as well as added initialization, setters and getters.
Note that CSSParserString must have a default constructor as it is part of the YYLVAL union.
Therefore created init() methods instead of constructors. Many of the parser function now directly
modify the instance in yylval. Made supporting changes in other webcore classes that are used
directly by CSSParser.

Test: fast/css/unicode-escape-in-8bit-string.html

  • css/CSSGrammar.y: Removed cssyylex() and changed manipulation of CSSParserString objects to

use newly written methods instead of direct manipulation of attributes.

  • css/CSSParser.cpp:

Templatized new or existing helper methods
(WebCore::makeLower):
(WebCore::isCSSLetter):
(WebCore::isCSSEscape):
(WebCore::isURILetter):
(WebCore::isIdentifierStartAfterDash):
(WebCore::isEqualToCSSIdentifier):
(WebCore::checkAndSkipEscape):
(WebCore::checkForValidDouble):
(WebCore::parseDouble):
(WebCore::parseColorIntOrPercentage):
(WebCore::isTenthAlpha):
(WebCore::parseAlphaValue):
(WebCore::mightBeRGBA):
(WebCore::mightBeRGB):
(WebCore::fastParseColorInternal):
(WebCore::CSSParser::fastParseColor):
(WebCore::CSSParser::parseImageSet):
(WebCore::skipWhiteSpace):
(WebCore::CSSParser::currentCharacter16):
(WebCore::CSSParser::isIdentifierStart):
(WebCore::CSSParser::checkAndSkipString):
(WebCore::CSSParser::parseUnicodeRange):
(WebCore::CSSParser::parseNthChild):
(WebCore::CSSParser::parseNthChildExtra):
(WebCore::CSSParser::detectFunctionTypeToken):
(WebCore::CSSParser::detectMediaQueryToken):
(WebCore::CSSParser::detectNumberToken):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::detectAtToken):
(WebCore::CSSParser::setRuleHeaderEnd):
(WebCore::cssPropertyID):
(WebCore::isCSSTokenizerIdentifier):
(WebCore::isCSSTokenizerURL):

(WebCore::CSSParser::CSSParser): Updated constructor for initializing new attributes.

(WebCore::CSSParserString::lower): Calls new makeLower() template helper.

(WebCore::CSSParser::setupParser): Added 8 bit path and set up parser appropriate to
string type.

(WebCore::equal): Updated to use CSSParserString getters and StringImpl::equal
(WebCore::equalIgnoringCase): Updated to use CSSParserString getters and
StringImpl::equalIgnoringCase
(WebCore::parseColorValue): Updated to use new CSSParserString::init()
(WebCore::parseSimpleLength):
(WebCore::parseKeywordValue): Updated to use new CSSParserString::init()
(WebCore::parseTransformArguments):
(WebCore::CSSParser::parseSystemColor): Updated to use new CSSParserString::init()
(WebCore::CSSParser::storeVariableDeclaration): Create right character sized AtomicString.
(WebCore::FontFamilyValueBuilder::add):
(WebCore::TransformOperationInfo::TransformOperationInfo):
(WebCore::CSSParser::parseFontFeatureTag):

(WebCore::CSSParser::parseEscape): Now only parses an escape and returns the resulting
Unicode value as an unsigned.
(WebCore::CSSParser::UnicodeToChars): New method to write out unicode character(s)
based on character type.
(WebCore::CSSParser::parseIdentifierInternal): Templated helper.
(WebCore::CSSParser::parseIdentifier): Parses identifiers, possibly upconverting
the result when a unicode escape is found in an 8 bit source.
(WebCore::CSSParser::parseStringInternal): Templated helper.
(WebCore::CSSParser::parseString): Parses strings, possibly upconverting
the result when a unicode escape is found in an 8 bit source.
(WebCore::CSSParser::parseURIInternal): Templated helper.
(WebCore::CSSParser::parseURI): Templated and split logic out to parseURIInternal.
Reparses a parsed identifier to see if it is a URI. This method doesn't need to up
convert from 8 to 16 bits since that would have been done in parseIdentfier().
(WebCore::CSSParser::realLex): Lot of template related changes. Removed yylval->string
ASSERT checks at the end, since they are too naive to handle upconverted identifier,
string and URIs. They compared source pointers (m_tokenStart) with resulting strings.
(WebCore::fixUnparsedProperties):
(WebCore::CSSParser::fixUnparsedPropertyRanges): Added new template helper with same name.
(WebCore::CSSParser::markRuleHeaderStart):
(WebCore::CSSParser::markRuleHeaderEnd):
(WebCore::CSSParser::markRuleBodyStart):
(WebCore::CSSParser::markRuleBodyEnd):
(WebCore::CSSParser::markPropertyStart):
(WebCore::CSSParser::markPropertyEnd):
(WebCore::cssValueKeywordID):

  • css/CSSParser.h:

(CSSParser):
(WebCore::CSSParser::lex): Made this inline helper that calls correct realLex().
(WebCore::CSSParser::is8BitSource):
(WebCore::CSSParser::tokenStartOffset): Templated method returning offset in source
of the current token start.
(WebCore::CSSParser::tokenStartChar): Templated access to m_tokenStart.
(WebCore::cssyylex): Made this inline to avoid call.

  • css/CSSParserValues.h:

(WebCore::CSSParserString::init): Added three new initialization methods.

New setters, getters and helper methods.
(WebCore::CSSParserString::clear):
(WebCore::CSSParserString::is8Bit):
(WebCore::CSSParserString::characters8):
(WebCore::CSSParserString::characters16):
(WebCore::CSSParserString::length):
(WebCore::CSSParserString::setLength):
(WebCore::CSSParserString::operator[]):
(WebCore::CSSParserString::equalIgnoringCase):
(WebCore::CSSParserString::operator String):
(WebCore::CSSParserString::operator AtomicString):

Other methods templatized to support changes in CSSParser.

  • platform/graphics/Color.cpp:

(WebCore::parseHexColorInternal):
(WebCore::Color::parseHexColor): New LChar flavor
(WebCore::Color::Color):

  • platform/graphics/Color.h:

(Color):

  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::TextEncoding):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::atomicCanonicalTextEncodingName):

  • platform/text/TextEncodingRegistry.h:
  • svg/SVGParserUtilities.cpp:

(WebCore::genericParseNumber):
(WebCore::parseSVGNumber):

  • svg/SVGParserUtilities.h:

(WebCore::isSVGSpace):
(WebCore::skipOptionalSVGSpaces):
(WebCore::skipOptionalSVGSpacesOrDelimiter):

Source/WTF:

  • wtf/text/StringImpl.h:

(WTF::equalIgnoringCase): Added (const char*, const LChar*, unsigned) flavor to support
8 bit CSS parser work.

LayoutTests:

New test that checks the case that a 16 bit unicode escape in an 8 bit CSS
source is properly handled.

  • fast/css/unicode-escape-in-8bit-string-expected.html: Added.
  • fast/css/unicode-escape-in-8bit-string.html: Added.
10:16 AM Changeset in webkit [127276] by timothy@apple.com
  • 2 edits in branches/safari-536.26-branch/Source/WebKit2

Merge r127272 for <rdar://problem/12211180>.

10:08 AM Changeset in webkit [127275] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] ASSERT(m_useFixedLayout) in WebPage when using QRawWebView without setting fixed layout
https://bugs.webkit.org/show_bug.cgi?id=95557

Reviewed by Noam Rosenthal.

Let QRawWebView work with non-fixed layout size.

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebView::setSize): Also put the member assigment into
the point where the new size is ensured to be committed.

10:07 AM Changeset in webkit [127274] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[Chromium] javascript-url-stop-loaders.html and zero-length-response.html are flaky on Chromium EWS
https://bugs.webkit.org/show_bug.cgi?id=95581

Unreviewed, Chromium gardening.

Tests mentioned in the title seem to cause flakiness on the Chromium EWS.

  • platform/chromium/TestExpectations: Mark as TIMEOUT PASS for now.
9:54 AM Changeset in webkit [127273] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] LayerTreeRenderer::callOnMainTread method name is misleading
https://bugs.webkit.org/show_bug.cgi?id=95558

Reviewed by Kenneth Rohde Christiansen.

Fix the typo in the function name so callers will really call this
and not WTF::callOnMainThread. Renamed to dispatchOnMainThread to
make it clear that these things are not the same.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::dispatchOnMainThread):
(WebKit::LayerTreeRenderer::flushLayerChanges):
(WebKit::LayerTreeRenderer::purgeGLResources):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

9:20 AM Changeset in webkit [127272] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (127047): Crash in PluginProxy::windowVisibilityChanged when changing tabs
<rdar://problem/12211180> and https://bugs.webkit.org/show_bug.cgi?id=95515

Reviewed by Dan Bernstein.

Plug-ins created in background tabs don't get initialized until they first become visible,
so telling them they are now invisible leads to messaging on behalf of an uninitialized plug-in.

Many other methods related to visibility and focus only call through if the plug-in is initialized,
so setWindowIsVisible should do the same.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setWindowIsVisible): Only tell initialized plug-ins of window visibility changes.

9:03 AM Changeset in webkit [127271] by jberlin@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

Web Inspector: sort object properties when dumping them in tests
https://bugs.webkit.org/show_bug.cgi?id=95459

Fix the expected results for timeline-paint to actually be in order.

  • inspector/timeline/timeline-paint-expected.txt:

'height' comes before 'width' alphabetically.

  • platform/chromium/inspector/timeline/timeline-paint-expected.txt: Removed.

Once the cross-platform results were fixed, this file was identical to the cross-platform
file. Remove it.

9:03 AM Changeset in webkit [127270] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

[New Multicolumn] Make RenderFlowThreads into selection roots.
https://bugs.webkit.org/show_bug.cgi?id=95580

Reviewed by Dan Bernstein.

Make RenderFlowThreads selection roots so that they paint their own selection gaps.
This fixes multicolumn selection rendering so that the gaps paint correctly and stop
at the edge of the flow thread instead of going out to the edges of enclosing blocks.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelectionRoot):

8:50 AM Changeset in webkit [127269] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

[CSS Regions] It should be possible to specify ::BEFORE/AFTER as regions
https://bugs.webkit.org/show_bug.cgi?id=90079

Patch by Andrei Bucur <abucur@adobe.com> on 2012-08-31
Reviewed by David Hyatt.

Source/WebCore:

The calls for RenderRegion::node() have been replaced with RenderRegion::generatingNode() to allow pseudo-elements to have RenderRegion renderers.
The compare function that establishes the region order was adapted to take into account pseudo-regions.
A renderer for the pseudo-element is now generated if it's a region even though there's no content property specified.

Test: fast/regions/content-flowed-into-pseudo-regions.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeOverflowStateForRegions):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::compareRenderRegions):

  • rendering/RenderObjectChildList.cpp:

(WebCore::ensureBeforeAfterContainer):
(WebCore):
(WebCore::RenderObjectChildList::updateBeforeAfterContent):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::checkRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderNamedFlowThreads):

LayoutTests:

The new ref-test has a block with both a :before and :after pseudo-elements marked as regions.
In the block there's another region.

The test verifies the content is correctly flowed (the region order is respected) in the region chain:
:before region -> child region -> :after region

As a region a pseudo-element should also be displayed if there's no content property specified in the style sheet.

  • fast/regions/content-flowed-into-pseudo-regions-expected.html: Added.
  • fast/regions/content-flowed-into-pseudo-regions.html: Added.
  • fast/regions/resources/region-style.css:

(.regionArticleAfter::after, .regionArticleBefore::before):
(.borderBoxNoFloat):

8:49 AM Changeset in webkit [127268] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

[Qt] ImageDiff output is not in the expected form if image dimensions differ
https://bugs.webkit.org/show_bug.cgi?id=95575

Reviewed by Csaba Osztrogonác.

Output 100% difference in the case of differing image dimensions so
the test harness knows that we won't produce any output further.
This matches the behavior of other ports.

  • DumpRenderTree/qt/ImageDiff.cpp:

(main):

8:47 AM Changeset in webkit [127267] by hyatt@apple.com
  • 14 edits in trunk/Source/WebCore

[New Multicolumn] Implement unforced breaking in the new column layout.
https://bugs.webkit.org/show_bug.cgi?id=95498

Reviewed by Dan Bernstein.

This patch implements unforced breaking for lines and objects inside columns. Forced breaks are
not yet handled properly and will be covered in a separate patch.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
Eliminate the flow thread constructor for LayoutState. Flow threads were doing a double push of
layout states, once in RenderFlowThread::layout() and then again in RenderBlock::layout(). This
double push was unnecessary, so I refactored the code to ensure the RenderBlock push does the
right thing for RenderFlowThreads.

(WebCore):

  • rendering/LayoutState.h:

(LayoutState):
Eliminate the flow thread constructor for LayoutState.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
This function now handles RenderFlowThreads and properly sets a non-zero page height as well
as querying the flow thread to ask if the pagination logical height has changed. The flow thread
has a new member that it sets in layout() so that it can answer this question.

(WebCore::RenderBlock::hasNextPage):
Make sure RenderRegionSets always claim to have a next page when they are the last region, since
we know columns/pages can always generate additional boxes as needed.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
Add the m_pageLogicalHeightChanged member variable for tracking whether regions changed dimensions,
thus forcing us to repaginate everything.

(WebCore::RenderFlowThread::layout):
Remove the redundant push of layout state now that RenderBlock's covers it.

(WebCore::RenderFlowThread::regionAtBlockOffset):
Always return the last region if it's a set, regardless of the extendLastRegion boolean.
This reflects the fact that the last region set can always generate new page/column boxes.

(WebCore::RenderFlowThread::pageLogicalTopForOffset):
Refactored to call into the region it finds for a given offset, so that the region itself
can answer the question of where the top of the page is. This enables sets to return the top of
specific columns/pages within the set.

(WebCore::RenderFlowThread::pageRemainingLogicalHeightForOffset):
Changed to be written in terms of pageLogicalTop and pageLogicalHeight so that it correctly uses
only the current column/page when determining remaining height.

  • rendering/RenderFlowThread.h:

Added pageLogicalHeightChanged() so that RenderBlock can ask the flow thread if its regions changed
dimensions.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
Tweaked to no longer turn on pagination, since the RenderMultiColumnFlowThread does that and we
want to avoid a double push of paginated states. Instead it now just sets the column height ahead
of time so that the RenderMultiColumnSets know how big their columns are.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::pageLogicalTopForOffset):
Subclassed to return the top of a specific column.

(WebCore):

  • rendering/RenderMultiColumnSet.h:

Add the subclassed method for pageLogicalTopForOffset.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::pageLogicalTopForOffset):
The code from RenderFlow::pageLogicalTopForOffset moved here. Just returns the top of the flow
thread portion rect in the region (same as before).

(WebCore::RenderRegion::layout):
Changed to check only the page logical width and height, since we only consider a region as
invalidating how you break if there is an actual page height change.

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::isRenderRegionSet):
Added an isRenderRegionSet() virtual function so that we can test for sets.

  • rendering/RenderRegionSet.h:

(WebCore::RenderRegionSet::isRenderRegionSet):
Subclassed isRenderRegionSet() to return true.

  • rendering/RenderView.cpp:
  • rendering/RenderView.h:

(LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
Remove the pushes of LayoutState that were specific to RenderFlowThreads.

8:40 AM Changeset in webkit [127266] by pfeldman@chromium.org
  • 7 edits in trunk

Web Inspector: Update $ to alias to querySelector rather than getElementById
https://bugs.webkit.org/show_bug.cgi?id=92648

Reviewed by Yury Semikhatsky.

Source/WebCore:

Completed implementation started by Addy Osmani. Updates $ to alias to querySelector
with more flexible handling of selectors. Also adds a warning about the change (as per Firebug).

  • inspector/InjectedScriptSource.js:

(.):

LayoutTests:

  • inspector/console/command-line-api-expected.txt:
  • inspector/console/command-line-api-inspect.html:
  • inspector/console/command-line-api.html:
8:36 AM Changeset in webkit [127265] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening, add Qt-WK2 specific expected
file, because this doesn't fail as expected, but passes.

  • platform/qt-5.0-wk2/css3/compositing/should-have-compositing-layer-expected.txt: Added.
8:04 AM Changeset in webkit [127264] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r127261.
http://trac.webkit.org/changeset/127261
https://bugs.webkit.org/show_bug.cgi?id=95572

This patch depends on other build fixes (see blockers of bug
95466) which should land first (Requested by milian on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-31

  • qmake/mkspecs/features/features.prf:
7:59 AM Changeset in webkit [127263] by gavinp@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Disable WebViewTest.AutoResizeMinimumSize
https://bugs.webkit.org/show_bug.cgi?id=95571

Unreviewed gardening.

Disabling this test since it started failing in build 17225, see http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/17247 for instance. Will shortly file bug to re-enable this.

  • tests/WebViewTest.cpp:
7:54 AM Changeset in webkit [127262] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: disable popover on click outside of popover anchor
https://bugs.webkit.org/show_bug.cgi?id=95564

Reviewed by Yury Semikhatsky.

Immediately hide popover when receiving a click outside of popover anchor.

  • inspector/front-end/Popover.js:

(WebInspector.PopoverHelper.prototype._mouseDown):

7:47 AM Changeset in webkit [127261] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Support WebKit2/QML on QNX
https://bugs.webkit.org/show_bug.cgi?id=95466

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-31
Reviewed by Noam Rosenthal.

Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
this should finally work now.

  • qmake/mkspecs/features/features.prf:
7:38 AM Changeset in webkit [127260] by timothy@apple.com
  • 1 edit in branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

Fix build from another bad project merge.

7:35 AM Changeset in webkit [127259] by gavinp@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed rebaseline after r127226

The windows results needed this rebaseline, apparently the original commit omitted these windows diffs per yosin@chromium.org.

  • platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Added.
  • platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
7:35 AM Changeset in webkit [127258] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk/Source

[EFL] Add proper support for navigator.onLine and associated events
https://bugs.webkit.org/show_bug.cgi?id=95532

Patch by Christophe Dumez <Christophe Dumez> on 2012-08-31
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add support for detecting online state in EFL port and
monitor state changes. The EFL port now has proper
support for navigator.onLine and associated events.

The implementation is based on Eeze library for
detecting network interfaces and their configuration.
Detection of online state changes relies on rtnetlink.

No new tests, no behavior change for layout tests.

  • PlatformEfl.cmake: Link unconditionally against Eeze

library now.

  • platform/network/NetworkStateNotifier.cpp:

(WebCore):

  • platform/network/NetworkStateNotifier.h:

(NetworkStateNotifier):
(WebCore):

  • platform/network/efl/NetworkStateNotifierEfl.cpp: Added.

(WebCore):
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::networkInterfaceChanged):
(WebCore::readSocketCallback):
(WebCore::NetworkStateNotifier::~NetworkStateNotifier):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):

Source/WebKit/efl:

Remove ewk_network_state_notifier_online_set() API since
the EFL port no longer relies on the client application to
provide it with the online state.

  • ewk/ewk_network.cpp:
  • ewk/ewk_network.h:
7:29 AM Changeset in webkit [127257] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] REGRESSION(r127091): It made layout tests extremely slow
https://bugs.webkit.org/show_bug.cgi?id=95450

Unreviewed gardening, skip http/tests/appcache tests until proper fix.

  • platform/qt-5.0-wk2/Skipped:
7:13 AM Changeset in webkit [127256] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Remove http/tests/loading/gmail-assert-on-load.html test case from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=95562

Unreviewed gardening.

Removed http/tests/loading/gmail-assert-on-load.html test case from Skipped files since it has been moved out from http/loading to http/misc, for details see bug 88923.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-31

  • platform/win/Skipped:
  • platform/wincairo/Skipped:
  • platform/wk2/Skipped:
7:04 AM Changeset in webkit [127255] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectations for two HTTP security tests.

  • platform/gtk/TestExpectations:
6:39 AM Changeset in webkit [127254] by timothy@apple.com
  • 1 edit in branches/safari-536.26-branch/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

Fix build from bad merge.

6:34 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Fix typos. (diff)
6:33 AM Changeset in webkit [127253] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] QNX does not support SOCK_SEQPACKET socket type for socketpair in ProcessLauncherQt
https://bugs.webkit.org/show_bug.cgi?id=95553

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-31
Reviewed by Simon Hausmann.

Calling socketpair with SOCK_SEQPACKET socket type fails on QNX with an error 241 (EPROTOTYPE),
as can be seen by the following debug output: "Creation of socket failed with errno: 241".
A test app shows that SOCK_DGRAM works properly on QNX, thus use it instead of SOCK_SEQPACKET.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
6:33 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Minor fix. (diff)
6:31 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Fix typo. (diff)
6:28 AM LineBreaking edited by glenn@skynav.com
Fix typo. (diff)
6:21 AM WikiStart edited by glenn@skynav.com
Add link to new CSS3 Text (webkit) wiki page. (diff)
6:20 AM CSS3Text created by glenn@skynav.com
Initial content.
6:17 AM Changeset in webkit [127252] by timothy@apple.com
  • 9 edits
    3 adds in branches/safari-536.26-branch

Merge r127047 for <rdar://problem/12133021>.

6:14 AM LineBreaking edited by glenn@skynav.com
Elaborate content. (diff)
5:58 AM Changeset in webkit [127251] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] QNX build fails due to missing OpenGL ES defines
https://bugs.webkit.org/show_bug.cgi?id=95554

Patch by Milian Wolff <milian.wolff@kdab.com> on 2012-08-31
Reviewed by Simon Hausmann.

Apply the fix of bug 91030 to all platforms running on QNX.

  • platform/graphics/opengl/Extensions3DOpenGLES.h:
5:53 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Minor fixes. (diff)
5:52 AM Changeset in webkit [127250] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new failing test.

  • platform/qt/Skipped:
5:50 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Elaborate content. (diff)
5:46 AM Changeset in webkit [127249] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[CMake] Changes on the bindings generator does not trigger generation of the bindings
https://bugs.webkit.org/show_bug.cgi?id=95552

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-31
Reviewed by Kenneth Rohde Christiansen.

Added the engine especific part of the generator to the dependency
list.

  • UseJSC.cmake:
  • UseV8.cmake:
5:30 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Add links. (diff)
5:28 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Fix typo. (diff)
5:28 AM Changeset in webkit [127248] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for WinCE after r127191.

  • bytecode/JumpTable.h:
5:27 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Elaborate content. (diff)
5:15 AM LineBreakingCSS3Mapping edited by glenn@skynav.com
Elaborate content. (diff)
5:07 AM Changeset in webkit [127247] by dominik.rottsches@intel.com
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=95555

Unreviewed EFL gardening of failing tests and new passes.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-08-31

  • platform/efl/TestExpectations:
  • platform/efl/http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Added.
5:05 AM Changeset in webkit [127246] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after r127140. Skip a failing reftest.

Patch by János Badics <János Badics> on 2012-08-31
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
4:59 AM Changeset in webkit [127245] by Csaba Osztrogonác
  • 27 edits
    14 adds
    4 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests, update expected files.

  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Removed.
  • platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
  • platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Removed.
  • platform/qt-5.0/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Removed.
  • platform/qt/Skipped:
  • platform/qt/TestExpectations:
  • platform/qt/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.png:
  • platform/qt/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/qt/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/qt/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/qt/css3/filters/blur-filter-page-scroll-expected.png: Added.
  • platform/qt/css3/filters/blur-filter-page-scroll-expected.txt: Added.
  • platform/qt/css3/filters/blur-filter-page-scroll-parents-expected.png: Added.
  • platform/qt/css3/filters/blur-filter-page-scroll-parents-expected.txt: Added.
  • platform/qt/css3/filters/effect-reference-expected.png: Added.
  • platform/qt/css3/filters/effect-reference-expected.txt: Added.
  • platform/qt/css3/filters/effect-reference-external-expected.png: Added.
  • platform/qt/css3/filters/effect-reference-external-expected.txt: Added.
  • platform/qt/css3/filters/effect-reference-hw-expected.txt: Added.
  • platform/qt/css3/filters/effect-reference-ordering-expected.png: Added.
  • platform/qt/css3/filters/effect-reference-ordering-expected.txt: Added.
  • platform/qt/fast/block/float/024-expected.png:
  • platform/qt/fast/block/float/024-expected.txt:
  • platform/qt/fast/block/margin-collapse/025-expected.png:
  • platform/qt/fast/block/margin-collapse/025-expected.txt:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.png:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
  • platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
  • platform/qt/fast/css/nested-layers-with-hover-expected.txt:
  • platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:
  • platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
  • platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png:
  • platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
  • platform/qt/svg/filters/color-interpolation-filters-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png: Added.
  • platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
4:35 AM Changeset in webkit [127244] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Simplify FrameLoaderClinetEfl by adding a private method.
https://bugs.webkit.org/show_bug.cgi?id=95444

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-08-31
Reviewed by Gyuyoung Kim.

In the FrameLoaderClientEfl, the codes which checks that
if current frame is main frame are frequently used.
This patch adds a private method and replaces those codes
with the method to simplify.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidChangeLocationWithinPage):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveIcon):
(WebCore::FrameLoaderClientEfl::dispatchDidStartProvisionalLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveTitle):
(WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientEfl::dispatchDidFailProvisionalLoad):
(WebCore::FrameLoaderClientEfl::transitionToCommittedForNewPage):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(WebCore::FrameLoaderClientEfl::isLoadingMainFrame):

3:41 AM LineBreakingCSS3Mapping created by glenn@skynav.com
Initial content.
3:33 AM LineBreaking edited by glenn@skynav.com
Elaborate content. (diff)
3:17 AM LineBreaking edited by glenn@skynav.com
Elaborate content (diff)
3:01 AM EFLWebKitCodingStyle edited by gyuyoung.kim@samsung.com
(diff)
2:56 AM Changeset in webkit [127243] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Link WebGL calls to the source code where it was made
https://bugs.webkit.org/show_bug.cgi?id=95426

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-31
Reviewed by Vsevolod Vlasov.

Save a stack trace for every call we capture and report to the frontend sourceURL,lineNumber,columnNumber were the call was made from.
Right now, this will work only with V8.

  • inspector/InjectedScriptExterns.js:

(CallSite.prototype.getFileName):
(CallSite.prototype.getLineNumber):
(CallSite.prototype.getColumnNumber):

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/front-end/WebGLProfileView.js:

(WebInspector.WebGLProfileView):
(WebInspector.WebGLProfileView.prototype._showTraceLog):

2:43 AM Changeset in webkit [127242] by pfeldman@chromium.org
  • 6 edits
    1 add in trunk/Source/WebCore

Web Inspector: Add high-DPI images for status bar glyphs
https://bugs.webkit.org/show_bug.cgi?id=95471

Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-08-31
Reviewed by Pavel Feldman.

Add the new 2x resolution image for the status bar glyphs, and add
media queries to use the images on high-DPI devices.

  • inspector/front-end/Images/statusbarButtonGlyphs2x.png: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:

(.long-click-glyph):
(@media (-webkit-min-device-pixel-ratio: 1.5)):
(.status-bar-item > .glyph):

  • inspector/front-end/scriptsPanel.css:

(.toggle-breakpoints .glyph):
(@media (-webkit-min-device-pixel-ratio: 1.5)):
(.status-bar-item.scripts-navigator-show-hide-button > .glyph):
(.status-bar-item.scripts-debugger-show-hide-button > .glyph):

  • WebCore.gypi
  • inspector/front-end/timelinePanel.css:

(#timeline-overview-sidebar .icon):
(@media (-webkit-min-device-pixel-ratio: 1.5)):

2:42 AM LineBreaking edited by glenn@skynav.com
Elaborate content. (diff)
2:40 AM Changeset in webkit [127241] by commit-queue@webkit.org
  • 14 edits in trunk/LayoutTests

[CSS Exclusions] Exclusions tests should run without errors in standalone browser
https://bugs.webkit.org/show_bug.cgi?id=95369

Patch by Bear Travis <betravis@adobe.com> on 2012-08-31
Reviewed by Andreas Kling.

Adding a check to make sure window.internals exists before accessing it.
Without the check, a reference error would occur when trying to run these
tests from the browser (as opposed to the test script).

  • fast/exclusions/css-exclusions-disabled.html:
  • fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
  • fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
  • fast/exclusions/script-tests/wrap-flow-parsing.js:
  • fast/exclusions/script-tests/wrap-margin-parsing.js:
  • fast/exclusions/script-tests/wrap-padding-parsing.js:
  • fast/exclusions/script-tests/wrap-parsing.js:
  • fast/exclusions/script-tests/wrap-through-parsing.js:
  • fast/exclusions/shape-inside/shape-inside-floats-simple.html:
  • fast/exclusions/shape-inside/shape-inside-inline-elements.html:
  • fast/exclusions/shape-inside/shape-inside-overflow.html:
  • fast/exclusions/shape-inside/shape-inside-percentage-auto.html:
  • fast/exclusions/shape-inside/shape-inside-text.html:
2:35 AM Changeset in webkit [127240] by pfeldman@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: render box model elements and grid on inspector overlay
https://bugs.webkit.org/show_bug.cgi?id=95456

Reviewed by Vsevolod Vlasov.

This change migrates native rendering for box model to the InspectorOverlay.

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didScrollImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didScroll):
(WebCore):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore::InspectorOverlay::drawRectHighlight):
(WebCore::InspectorOverlay::overlayPage):
(WebCore::InspectorOverlay::evaluateInOverlay):

  • inspector/InspectorOverlay.h:

(WebCore::Highlight::setColors):
(Highlight):
(InspectorOverlay):

  • inspector/InspectorOverlayPage.html:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didLayout):
(WebCore):
(WebCore::InspectorPageAgent::didScroll):

  • inspector/InspectorPageAgent.h:
  • page/Chrome.cpp:

(WebCore::Chrome::scroll):

2:23 AM LineBreaking edited by glenn@skynav.com
Add content. (diff)
2:14 AM Changeset in webkit [127239] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [WebGL] Make wrap functions initialization lazy
https://bugs.webkit.org/show_bug.cgi?id=95533

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-31
Reviewed by Vsevolod Vlasov.

WebGL wrap functions initialization is not always needed to be executed: for example, when we will instrument a 2D canvas.
Drive-by: fixed variable namings, moved duplicated code into a small auxiliary function.

  • inspector/InjectedScriptWebGLModuleSource.js:

(.):

1:34 AM LineBreaking created by glenn@skynav.com
Outline new page describing line breaking.
1:07 AM Changeset in webkit [127238] by Simon Hausmann
  • 8 edits in trunk/Source

[Qt] Port convertValueToQVariant to use the JSC C API
https://bugs.webkit.org/show_bug.cgi?id=94695

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Most of the code is portable to the C API, with a few exceptions for internal
types such as byte arrays, dates or when unboxing primitive types.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtField::setValueToInstance):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::operator<<):
(JSC::Bindings::isJSUint8ClampedArray):
(JSC::Bindings::isJSArray):
(Bindings):
(JSC::Bindings::isJSDate):
(JSC::Bindings::isQtObject):
(JSC::Bindings::valueRealType):
(JSC::Bindings::toString):
(JSC::Bindings::unwrapBoxedPrimitive):
(JSC::Bindings::convertValueToQVariantMap):
(JSC::Bindings::convertToList):
(JSC::Bindings::toQString):
(JSC::Bindings::getGregorianDateTimeUTC):
(JSC::Bindings::toQDateTimeUTC):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::findMethodIndex):
(JSC::Bindings::QtConnectionObject::execute):

  • bridge/qt/qt_runtime.h:

(Bindings):

Source/WebKit/qt:

Minor adaptations are needed here to accomodate the changed signature of
convertValueToQVariant.

  • Api/qwebelement.cpp:

(QWebElement::evaluateJavaScript):
(convertJSValueToWebElementVariant):

  • Api/qwebframe.cpp:

(QWebFrame::evaluateJavaScript):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(convertJSValueToNodeVariant):

12:58 AM Changeset in webkit [127237] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: render path to file and line number as subtitles in selector dialog.
https://bugs.webkit.org/show_bug.cgi?id=95481

Reviewed by Vsevolod Vlasov.

In case several files have matching names, we should render the path next to it.
Using the same subtitle field, we now also render line number for JS and Style outlines.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype.get _itemsLoaded):
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.SelectionDialogContentProvider.prototype.itemSuffixAt):
(WebInspector.JavaScriptOutlineDialog.prototype.itemSuffixAt):
(WebInspector.JavaScriptOutlineDialog.prototype.itemSubtitleAt):
(WebInspector.OpenResourceDialog.prototype.itemSuffixAt):
(WebInspector.OpenResourceDialog.prototype.itemSubtitleAt):

  • inspector/front-end/StyleSheetOutlineDialog.js:

(WebInspector.StyleSheetOutlineDialog.prototype.itemSuffixAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemSubtitleAt):

  • inspector/front-end/filteredItemSelectionDialog.css:

(.js-outline-dialog > .container > div.item):
(.js-outline-dialog span.subtitle):

12:36 AM Changeset in webkit [127236] by commit-queue@webkit.org
  • 2 edits
    2 moves
    1 add in trunk/LayoutTests

[Qt] New inspector/profiler/webgl-profiler-api-changes.html times out
https://bugs.webkit.org/show_bug.cgi?id=95183

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-08-31
Reviewed by Yury Semikhatsky.

Move inspector WebGL test(s) to its own folder so that they are easy to blacklist. Skip them for QT where WebGL is disabled at the moment.
Drive-by: make the test fail instead of timing out when WebGL is disabled.

  • inspector/profiler/webgl/webgl-profiler-api-changes-expected.txt: Renamed from LayoutTests/inspector/profiler/webgl-profiler-api-changes-expected.txt.
  • inspector/profiler/webgl/webgl-profiler-api-changes.html: Renamed from LayoutTests/inspector/profiler/webgl-profiler-api-changes.html.
  • platform/qt/Skipped:
12:09 AM Changeset in webkit [127235] by yosin@chromium.org
  • 6 edits in trunk

[Forms] Left/Right keys in multiple fields time input UI should move focus physical left/right instead of logical left/right regardless text direction.
https://bugs.webkit.org/show_bug.cgi?id=95434

Reviewed by Kent Tamura.

Source/WebCore:

This patch also changes handling of Left/Right keys to aware text
direction ("dir" attribute"). Left/Right keys should move focus
physical right/left instead of logical right/left.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch adds a test case into fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler): Changed to check isRTL() for Left/Right keys then we call
appropriate focus motion function.
(WebCore::DateTimeFieldElement::isRTL): Added for checking text direction is right-to-left or not.

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement): Added declaration of isRTL().

LayoutTests:

This patch adds a new test case of Left/Right keys navigation on
right-to-left text direction for multiple field time input UI.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Changed to have Left/Right keys navigation in

right-to-left text direction.

Note: See TracTimeline for information about the timeline view.