Timeline
Jan 3, 2013:
- 9:48 PM Changeset in webkit [138779] by
-
- 4 edits in trunk/Source
Versioning.
- 9:48 PM Changeset in webkit [138778] by
-
- 2 edits in trunk/LayoutTests
Add one more Mac test expectation for the bug 105986.
- platform/mac/TestExpectations:
- 9:46 PM Changeset in webkit [138777] by
-
- 1 copy in tags/Safari-537.24
New Tag.
- 8:21 PM Changeset in webkit [138776] by
-
- 2 edits in trunk/Tools
Downloads can be flaky, so try downloading multiple times.
https://bugs.webkit.org/show_bug.cgi?id=105976
Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-03
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._download_to_stream):
- 7:56 PM Changeset in webkit [138775] by
-
- 17 edits in trunk/Tools
Rename Tool.port to deprecated_port in preparation for removing more callers
https://bugs.webkit.org/show_bug.cgi?id=106076
Reviewed by Ryosuke Niwa.
This resolves a long-standing FIXME to rename this method. :)
- Scripts/webkitpy/tool/bot/botinfo.py:
(BotInfo.summary_text):
- Scripts/webkitpy/tool/bot/irc_command.py:
(Rollout._update_working_copy):
- Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
(LayoutTestResultsReader._create_layout_test_results):
(LayoutTestResultsReader._create_unit_test_results):
(LayoutTestResultsReader._results_directory):
- Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(test_missing_unit_test_results_path):
- Scripts/webkitpy/tool/main.py:
(WebKitPatch.deprecated_port):
- Scripts/webkitpy/tool/mocktool.py:
(MockTool.deprecated_port):
- Scripts/webkitpy/tool/steps/build.py:
(Build.build):
- Scripts/webkitpy/tool/steps/checkstyle.py:
(CheckStyle.run):
- Scripts/webkitpy/tool/steps/commit.py:
(Commit._check_test_expectations):
- Scripts/webkitpy/tool/steps/preparechangelog.py:
(PrepareChangeLog.run):
- Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
(PrepareChangeLogForDEPSRoll.run):
- Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
(PrepareChangeLogForRevert.run):
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest.test_runtests_args):
- Scripts/webkitpy/tool/steps/update.py:
(Update._update_command):
- 7:46 PM Changeset in webkit [138774] by
-
- 4 edits1 copy in trunk/Tools
Cleanup perftest* tests and add a test for computing statistics
https://bugs.webkit.org/show_bug.cgi?id=105685
Reviewed by Eric Seidel.
Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
accurate result for the mean.
(PageLoadingPerfTest.run_single):
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_compute_statistics):
(MainTest.test_compute_statistics.compute_statistics): Added.
(TestPageLoadingPerfTest.test_run): floatify values.
(TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
correctly recognizes them as integers.
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
(TestDriver): Moved out of MainTest.
(MainTest): Got rid of assertWritten and all unit tests.
(MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
(MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
(MainTest.test_run_test_set_for_parser_tests):
(MainTest.test_run_memory_test):
(MainTest._test_run_with_json_output):
(MainTest.test_run_generates_json_by_default):
(MainTest.test_run_merges_output_by_default):
(MainTest.test_run_respects_reset_results):
(MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
parsing output JSON files. Just verify that the output path is correct instead.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest): Removed all integration tests.
(MainTest.create_runner): Simplified.
- 7:26 PM Changeset in webkit [138773] by
-
- 3 edits in trunk/LayoutTests
Add Mac test expectations for the bugs 105986 and 105988.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 7:20 PM Changeset in webkit [138772] by
-
- 2 edits in trunk/LayoutTests
Add a crashing test expectation for the test added by r138755 on Mac.
The test failure is tracked by the bug 138755.
- platform/mac/TestExpectations:
- 6:11 PM Changeset in webkit [138771] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed. Gardening Apple Windows port.
- platform/win/fast/css/image-set-value-not-removed-crash-expected.txt: Added.
- 5:21 PM Changeset in webkit [138770] by
-
- 5 edits2 adds in trunk
incorrect flexbox relayout with overflow, padding and absolute positioning
https://bugs.webkit.org/show_bug.cgi?id=106022
Reviewed by Ojan Vafai.
Source/WebCore:
The problem was we were entering simplified layout, which doesn't apply the stretch
behavior for flex children. That should be fine if we had kept the override size from
the previous layout. So clear the override size during layout rather than after layout.
Not clearing the override size re-triggers bug 98611. Fix this by always forcing a
layout of an image if it has an override size set. The presence of an override size means
we did some special layout that may not be covered by re-computing the logical width and
height.
Test: css3/flexbox/stretch-simplified-layout.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Don't clear the override size after layout.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Clear the override size right before layout.
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox): Remove clearChildOverrideSizes() since it's not called anymore.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged): If an override size is present, force a relayout.
Also cleaned up the code a bit to avoid computing the width and height unless we need to.
LayoutTests:
- css3/flexbox/stretch-simplified-layout-expected.txt: Added.
- css3/flexbox/stretch-simplified-layout.html: Added.
- 5:18 PM Changeset in webkit [138769] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed rebaseline of binding tests after r138754
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackHeader): Remove unnecessary whitespace
- bindings/scripts/test/JS/JSTestCallback.h:
(WebCore::JSTestCallback::scriptExecutionContext):
(JSTestCallback):
- bindings/scripts/test/V8/V8TestCallback.h:
(WebCore::V8TestCallback::scriptExecutionContext):
(V8TestCallback):
- 5:06 PM Changeset in webkit [138768] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
Avoid mixed content when expanding context in code review tool
https://bugs.webkit.org/show_bug.cgi?id=106060
Patch by James Robinson <jamesr@chromium.org> on 2013-01-03
Reviewed by Tony Chang.
Example failure: "The page at https://bugs.webkit.org/attachment.cgi?id=181222&action=review displayed insecure
content from http://svn.webkit.org/repository/webkit/trunk/Source/WebCore/page/EventHandler.cpp?p=138617." This
loads from "svn.webkit.org/..." so the protocol matches.
- code-review.js:
- 4:46 PM Changeset in webkit [138767] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marking fast/events/5056619.html as flaky
on XP and Win7.
- platform/chromium/TestExpectations:
- 4:33 PM Changeset in webkit [138766] by
-
- 18 edits2 adds in trunk
onload callback for <track> element attached to <video> does not fire
https://bugs.webkit.org/show_bug.cgi?id=103258
Patch by Antoine Quint <Antoine Quint> on 2013-01-03
Reviewed by Eric Carlson.
Source/WebCore:
We now correctly implement the track processing model per the latest spec at
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#start-the-track-processing-model.
For a <track> to load, three conditions must be met:
- it must have a non-empty src
- it must have a mode other than "disabled" (the default)
- it must have a parent media element
We used to only check if we were able to load upon setting the track's src,
whereas a change of any of those conditions should have done this, which this
patch now correctly implements.
We also correctly implement the load model asynchronously after step 4, per
the spec, hence the split of the code previously entirely contained in
HTMLTrackElement::scheduleLoad() in another method fired on a timer.
Test: media/track/track-element-load-event.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackModeChanged):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::HTMLTrackElement):
(WebCore::HTMLTrackElement::insertedInto):
(WebCore::HTMLTrackElement::parseAttribute):
(WebCore::HTMLTrackElement::scheduleLoad):
(WebCore):
(WebCore::HTMLTrackElement::loadTimerFired):
(WebCore::HTMLTrackElement::textTrackModeChanged):
- html/HTMLTrackElement.h:
- html/track/TextTrack.cpp:
(WebCore::TextTrack::removeAllCues):
(WebCore):
- html/track/TextTrack.h:
(TextTrack):
LayoutTests:
As a result of fixing this bug, a few new failures were uncovered and TestExpectations
needed to be updated to take this into account. Additionally, some existing tests were
incorrect or outdated and were fixed as well. Finally, a new test was added to thoroughly
test the various conditions required for a <track> element to successfully load.
- fast/events/constructors/track-event-constructor.html: Update the test to correctly set
a non-disabled mode on the text track such that it may load per the rules enforced with this patch.
- http/tests/security/text-track-crossorigin.html: Update the test to correctly set a non-disabled
mode on the text track such that it may load per the rules enforced with this patch.
- media/track/track-add-track-expected.txt: Update the output to match changes made to test.
- media/track/track-add-track.html: Update the test to correctly set a non-disabled mode on
the text track such that it may load per the rules enforced with this patch. Also, ensure
the .readyState of the text track is correctly assumed to be NONE vs. LOADING as it would
have to wait until the next run loop to be changed to anything but NONE.
- media/track/track-element-load-event-expected.txt: Added.
- media/track/track-element-load-event.html: Added.
- media/track/track-load-from-src-readyState.html: Update the test to correctly set a
non-disabled mode on the text track such that it may load per the rules enforced with
this patch.
- platform/chromium/TestExpectations: Skip tests that now fail instead of timing out.
- platform/efl/TestExpectations: Skip tests that now fail instead of timing out.
- platform/gtk/TestExpectations: Skip tests that now fail instead of timing out.
- platform/mac/TestExpectations: Skip tests that now fail instead of timing out.
- platform/qt/TestExpectations: Skip tests that now fail instead of timing out.
- platform/win/TestExpectations: Skip tests that now fail instead of timing out.
- 4:32 PM Changeset in webkit [138765] by
-
- 7 edits in trunk/Source
[chromium] Rename low latency rendering mode setting to vsync notification
https://bugs.webkit.org/show_bug.cgi?id=106020
Patch by Sami Kyostila <skyostil@chromium.org> on 2013-01-03
Reviewed by James Robinson.
Source/Platform:
Rename low latency rendering mode setting to vsync notification because
the old name was ambiguous and bad. This setting is meant to control
whether the renderer uses a vsync signal provided by the browser to
schedule rendering.
Source/WebKit/chromium:
Rename low latency rendering mode setting to vsync notification because
the old name was ambiguous and bad. This setting is meant to control
whether the renderer uses a vsync signal provided by the browser to
schedule rendering.
- 4:31 PM Changeset in webkit [138764] by
-
- 5 edits in trunk
REGRESSION(r138729): crash and assertion failures in WebKit::WebProcess::plugInDidReceiveUserInteraction
https://bugs.webkit.org/show_bug.cgi?id=106042
<rdar://problem/12953469>
Reviewed by Brady Eidson.
Source/WebKit2:
The assertion is hit if plugin snapshotting is disabled, and the user interacts with a plug-in that
comes from an origin not found in the cached dictionary. The proper fix is to check for whether the
setting is enabled. Otherwise, that origin should be in the dictionary since the plugin is running.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginDidReceiveUserInteraction): Check for the setting, and avoid the whole code
path if snapshotting is disabled.
LayoutTests:
- platform/mac-wk2/TestExpectations: Unskip the crashing tests.
- 4:28 PM Changeset in webkit [138763] by
-
- 6 edits1 delete in trunk/Source/JavaScriptCore
DFG::ByteCodeCache serves little or no purpose ever since we decided to keep bytecode around permanently
https://bugs.webkit.org/show_bug.cgi?id=106058
Reviewed by Michael Saboff.
All baseline code blocks now always have bytecode, so the bytecode cache's ability to minimize the
number of times that the DFG produces bytecode sequences for code blocks is superfluous.
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGByteCodeCache.h: Removed.
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleInlining):
- runtime/Executable.cpp:
(JSC):
- runtime/Executable.h:
(FunctionExecutable):
- 4:26 PM Changeset in webkit [138762] by
-
- 6 edits in trunk/Tools
Dashboard cleanup: remove usage of global g_defaultBuilderName
https://bugs.webkit.org/show_bug.cgi?id=106043
Use now public defaultBuilder() from the BuilderGroup, rather
than global variable.
Also eliminates the setup() and initBuilders() functions since we
no longer need to track the global.
Reviewed by Adam Barth.
- TestResultServer/static-dashboards/builders.js:
(BuilderGroup.prototype.defaultBuilder):
(BuilderGroup.prototype.master):
- TestResultServer/static-dashboards/dashboard_base.js:
(parseParameters):
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(updateDefaultBuilderState):
- TestResultServer/static-dashboards/loader.js:
(.):
- TestResultServer/static-dashboards/loader_unittests.js:
- 4:20 PM ExportingSymbols edited by
- (diff)
- 4:17 PM Changeset in webkit [138761] by
-
- 3 edits in trunk/LayoutTests
Add a failing test expectation for fast/inline/continuation-outlines-with-layers.html on Mac
and associate it with the bug 106064.
Also update Chromium test expectations to associate the failure with the bug 106064.
They were erroneously associated with resolved bugs.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- 4:07 PM Changeset in webkit [138760] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed gardening. Adding cr-linux image baseline for
http://trac.webkit.org/changeset/138755
- platform/chromium-linux/fast/regions/full-screen-video-from-region-expected.png: Added.
- 3:59 PM Changeset in webkit [138759] by
-
- 5 edits13 adds1 delete in trunk/Source
Remove all traces of Windows from WebKit2 folder.
https://bugs.webkit.org/show_bug.cgi?id=105585.
Reviewed by Sam Weinig.
WebKitExportGenerator project needs to be moved out of the WebKit2/win folder and into WebKit/win.
- WebKit.vcproj/WebKit.def.in: Added.
- WebKit.vcproj/WebKit.sln:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitCFLite.vsprops: Added.
- WebKit.vcproj/WebKitExportGenerator.vcproj: Added.
- WebKit.vcproj/WebKitExportGeneratorBuildCmd.cmd: Added.
- WebKit.vcproj/WebKitExportGeneratorCommon.vsprops: Added.
- WebKit.vcproj/WebKitExportGeneratorDebug.vsprops: Added.
- WebKit.vcproj/WebKitExportGeneratorDebugAll.vsprops: Added.
- WebKit.vcproj/WebKitExportGeneratorDebugCairoCFLite.vsprops: Added.
- WebKit.vcproj/WebKitExportGeneratorPostBuild.cmd: Added.
- WebKit.vcproj/WebKitExportGeneratorPreBuild.cmd: Added.
- WebKit.vcproj/WebKitExportGeneratorProduction.vsprops: Added.
- WebKit.vcproj/WebKitExportGeneratorRelease.vsprops: Added.
- WebKit.vcproj/WebKitExportGeneratorReleaseCairoCFLite.vsprops: Added.
- WebKit.vcproj/WebKitLibCommon.vsprops:
- win: Removed.
- win/MainWin.cpp: Removed.
- win/WebKit2.def.in: Removed.
- win/WebKit2.make: Removed.
- win/WebKit2.rc: Removed.
- win/WebKit2.submit.sln: Removed.
- win/WebKit2.vcproj: Removed.
- win/WebKit2Apple.vsprops: Removed.
- win/WebKit2CFLite.vsprops: Removed.
- win/WebKit2Common.vsprops: Removed.
- win/WebKit2Debug.vsprops: Removed.
- win/WebKit2DebugAll.vsprops: Removed.
- win/WebKit2DebugCairoCFLite.vsprops: Removed.
- win/WebKit2DirectX.vsprops: Removed.
- win/WebKit2ExportGenerator.vcproj: Removed.
- win/WebKit2ExportGeneratorBuildCmd.cmd: Removed.
- win/WebKit2ExportGeneratorCommon.vsprops: Removed.
- win/WebKit2ExportGeneratorDebug.vsprops: Removed.
- win/WebKit2ExportGeneratorDebugAll.vsprops: Removed.
- win/WebKit2ExportGeneratorDebugCairoCFLite.vsprops: Removed.
- win/WebKit2ExportGeneratorPostBuild.cmd: Removed.
- win/WebKit2ExportGeneratorPreBuild.cmd: Removed.
- win/WebKit2ExportGeneratorProduction.vsprops: Removed.
- win/WebKit2ExportGeneratorRelease.vsprops: Removed.
- win/WebKit2ExportGeneratorReleaseCairoCFLite.vsprops: Removed.
- win/WebKit2Generated.make: Removed.
- win/WebKit2Generated.vcproj: Removed.
- win/WebKit2GeneratedCommon.vsprops: Removed.
- win/WebKit2Production.vsprops: Removed.
- win/WebKit2Release.vsprops: Removed.
- win/WebKit2ReleaseCairoCFLite.vsprops: Removed.
- win/WebKit2WebProcess.resources: Removed.
- win/WebKit2WebProcess.resources/Info.plist: Removed.
- win/WebKit2WebProcess.vcproj: Removed.
- win/WebKit2WebProcessCommon.vsprops: Removed.
- win/WebKit2WebProcessDebug.vsprops: Removed.
- win/WebKit2WebProcessDebugAll.vsprops: Removed.
- win/WebKit2WebProcessDebugCairoCFLite.vsprops: Removed.
- win/WebKit2WebProcessPostBuild.cmd: Removed.
- win/WebKit2WebProcessPreBuild.cmd: Removed.
- win/WebKit2WebProcessProduction.vsprops: Removed.
- win/WebKit2WebProcessRelease.vsprops: Removed.
- win/WebKit2WebProcessReleaseCairoCFLite.vsprops: Removed.
- win/WebKitPostBuild.cmd: Removed.
- win/WebKitPreBuild.cmd: Removed.
- win/WebKitPreLink.cmd: Removed.
- win/build-generated-files.sh: Removed.
- win/deleteButton.png: Removed.
- win/deleteButtonPressed.png: Removed.
- win/fsVideoAudioVolumeHigh.png: Removed.
- win/fsVideoAudioVolumeLow.png: Removed.
- win/fsVideoExitFullscreen.png: Removed.
- win/fsVideoPause.png: Removed.
- win/fsVideoPlay.png: Removed.
- win/missingImage.png: Removed.
- win/nullplugin.png: Removed.
- win/panEastCursor.png: Removed.
- win/panIcon.png: Removed.
- win/panNorthCursor.png: Removed.
- win/panNorthEastCursor.png: Removed.
- win/panNorthWestCursor.png: Removed.
- win/panSouthCursor.png: Removed.
- win/panSouthEastCursor.png: Removed.
- win/panSouthWestCursor.png: Removed.
- win/panWestCursor.png: Removed.
- win/resource.h: Removed.
- win/searchCancel.png: Removed.
- win/searchCancelPressed.png: Removed.
- win/searchMagnifier.png: Removed.
- win/searchMagnifierResults.png: Removed.
- win/textAreaResizeCorner.png: Removed.
- win/verticalTextCursor.png: Removed.
- win/xcopy.excludes: Removed.
- win/zoomInCursor.png: Removed.
- win/zoomOutCursor.png: Removed.
- 3:55 PM Changeset in webkit [138758] by
-
- 15 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=105475
Nested fixed position elements incorrectly repositioned on scrolling
Reviewed by Simon Fraser.
Source/WebCore:
The fix here is to ensure that the ScrollingTree reflects the same hierarchy as
the GraphicsLayer tree. And from there, we can correctly calculate the offset for
nested objects by keeping track of a cumulative delta that parents have been moved
by.
We already had to fix this same bug in ScrollingStateNode::removeChild(). The
index can be notFound when you are removing a grandchild.
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::removeChild):
parentScrollPositionDidChange() now takes a second parameter that represents the
delta that parent graphicsLayers have been moved by.
- page/scrolling/ScrollingTreeNode.h:
(ScrollingTreeNode):
- page/scrolling/ScrollingTreeScrollingNode.h:
- page/scrolling/mac/ScrollingTreeFixedNode.h:
(ScrollingTreeFixedNode):
attachToStateTree() now handles re-parenting.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::attachToStateTree):
Properly adjust by and compute the new parameter cumulativeDelta. Adjusting by
this will prevent fixed children of fixed objects from moving when they are not
supposed to.
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::parentScrollPositionDidChange):
Give parentScrollPositionDidChange() an initial delta of (0,0).
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
Properly adjust by and compute the new parameter cumulativeDelta. This math is
actually not quite right for sticky yet as the FIXME indicates.
- page/scrolling/mac/ScrollingTreeStickyNode.h:
(ScrollingTreeStickyNode):
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::parentScrollPositionDidChange):
Re-named attachToScrollingCoordinator() to attachToScrollingCoordinatorWithParent
to make it clear that the node may already be attached, but it may need to be re-
parented.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::attachToScrollingCoordinatorWithParent):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
Always call attachToScrollingCoordinatorWithParent() in case the fixed node has
been re-parented.
(WebCore::RenderLayerCompositor::registerOrUpdateViewportConstrainedLayer):
LayoutTests:
Unfortunately, the children were not really accurate before, and they are not
really accurate now. It seems like the state tree is not fully up-to-date when the
test is printing it.
- platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt:
- 3:46 PM Changeset in webkit [138757] by
-
- 2 edits in trunk/Source/WebCore
Body background with background-attachment:fixed stays in place during rubber-banding
https://bugs.webkit.org/show_bug.cgi?id=67894
Reviewed by Beth Dakin.
Use FrameView::scrollOffsetForFixedPosition() to compute the location of the rect
used to position fixed backgrounds, since it takes rubber-banding into account.
No test because rubber-banding isn't testtable in layout tests.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- 3:41 PM Changeset in webkit [138756] by
-
- 4 edits2 adds in trunk
[HTMLTemplateElement] When adopting a template element, also adopt its content into the appropriate document
https://bugs.webkit.org/show_bug.cgi?id=106039
Reviewed by Eric Seidel.
Source/WebCore:
Implements the approach discussed in the spec bug:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=20129
Test: fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html
- html/HTMLTemplateElement.cpp:
(WebCore::HTMLTemplateElement::didMoveToNewDocument):
- html/HTMLTemplateElement.h:
(HTMLTemplateElement):
LayoutTests:
- fast/dom/HTMLTemplateElement/ownerDocument-adoptNode-expected.txt: Added.
- fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html: Added.
- 3:28 PM Changeset in webkit [138755] by
-
- 3 edits3 adds in trunk
[CSS Regions] Don't apply region flow to fullscreen video playing
https://bugs.webkit.org/show_bug.cgi?id=102388
Reviewed by David Hyatt.
In case of full screen video playing we want to watch the video full screen without applying the region flow.
Source/WebCore:
Test: fast/regions/full-screen-video-from-region.html
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded): Don't move full screen video playing to FlowThread.
LayoutTests:
- fast/regions/full-screen-video-from-region-expected.txt: Added.
- fast/regions/full-screen-video-from-region.html: Added.
- platform/chromium-mac/fast/regions/full-screen-video-from-region-expected.png: Added.
- 3:22 PM Changeset in webkit [138754] by
-
- 7 edits2 adds in trunk
[Mutation Observers] prevent delivery while recipient context is suspended
https://bugs.webkit.org/show_bug.cgi?id=105810
Reviewed by Adam Barth.
Source/WebCore:
Test: inspector/debugger/mutation-observer-suspend-while-paused.html
- dom/MutationObserver.cpp:
(WebCore::suspendedMutationObservers):
(WebCore):
(WebCore::MutationObserver::canDeliver):
(WebCore::MutationObserver::deliver):
(WebCore::MutationObserver::deliverAllMutations):
- dom/MutationObserver.h:
LayoutTests:
- inspector/debugger/mutation-observer-suspend-while-paused-expected.txt: Added.
- inspector/debugger/mutation-observer-suspend-while-paused.html: Added.
- 3:22 PM Changeset in webkit [138753] by
-
- 2 edits in trunk/Tools
Disable an intermittently failing unit test for now.
The failure is tracked by the bug 106051.
- TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
- 3:19 PM Changeset in webkit [138752] by
-
- 3 edits in trunk/Source/WebKit2
Ensure autorelease pool exists when calling WKNSProcessInfoProcessAssertionWithTypes on Mac
https://bugs.webkit.org/show_bug.cgi?id=105674
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-03
Reviewed by Sam Weinig.
The function WKNSProcessInfoProcessAssertionWithTypes returns a autoreleased object and since,
it is called during process initialization prior to the runloop being started in PluginProcess
and SharedWorkerProcess, an autorelease pool must be explictly created.
- PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain): Enclose process initialization code in an @autoreleasepool block.
- SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm:
(WebKit::SharedWorkerProcessMain): Ditto.
- 3:17 PM Changeset in webkit [138751] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening, skip a new crashing test to paint the bots green.
- platform/qt-5.0-wk2/TestExpectations:
- 3:15 PM Changeset in webkit [138750] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Setting webaudio/automatic-pull-node.html to
[ Timeout Pass ] for XP.
- platform/chromium/TestExpectations:
- 3:04 PM Changeset in webkit [138749] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Unreviewed debug buildfix after r138723.
- WebProcess/qt/QtBuiltinBundle.cpp:
- 3:02 PM Changeset in webkit [138748] by
-
- 2 edits in trunk/LayoutTests
css3/filters/effect-invert.html is flaky/has incorrect image output on Win
Unreviewed gardening. Marked this as [ Failure Pass ] for Win7 and
as [ Failure ] for XP.
- platform/chromium/TestExpectations:
- 3:01 PM Changeset in webkit [138747] by
-
- 5 edits1 add in trunk
No way to obtain a DOMNode given a JS wrapper for a Node
https://bugs.webkit.org/show_bug.cgi?id=106033
Source/WebCore:
Reviewed by Sam Weinig.
Test: TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm.
- bindings/objc/DOM.mm:
(+[DOMNode _nodeFromJSWrapper:]): Added. If the given JSObjectRef is a wrapper for a Node,
returns the Objective-C wrapper for that node. Note that Objective-C wrappers are always
for the main world, regardless of which world the given JS wrapper comes from.
- bindings/objc/DOMPrivate.h: Added declaration of the above.
Tools:
Added a test for +[DOMNode _nodeFromJSWrapper:].
Reviewed by Sam Weinig.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- 2:44 PM Changeset in webkit [138746] by
-
- 8 edits2 adds in trunk
webkit fails IETC column-width-negative-001.htm
https://bugs.webkit.org/show_bug.cgi?id=84778
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-01-03
Reviewed by Tony Chang.
Source/WebCore:
CSS3 multicolumn 'column-width' property value must be greater than zero.
http://dev.w3.org/csswg/css3-multicol/#column-width
Test: fast/multicol/column-width-zero.html
Negative value test covered by ietestcenter/css3/multicolumn/column-width-negative-001.htm
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Check for value greater than zero while parsing.
LayoutTests:
New test for multicolumn 'column-width' property with zero value.
Enable IETC column-width-negative test.
- fast/multicol/column-width-zero-expected.txt: Added.
- fast/multicol/column-width-zero.html: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 2:37 PM Changeset in webkit [138745] by
-
- 1 copy in tags/Safari-534.58.2
New Tag.
- 2:30 PM Changeset in webkit [138744] by
-
- 5 edits in branches/safari-534.58-branch/Source
Versioning.
- 2:29 PM Changeset in webkit [138743] by
-
- 2 edits in trunk/LayoutTests
Add crash test expectations for tests regressed by r138729
The failure is tracked by the bug 106042.
- platform/mac-wk2/TestExpectations:
- 2:26 PM Changeset in webkit [138742] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Remove all references to sharedWorkerRepository()
https://bugs.webkit.org/show_bug.cgi?id=104704
Reviewed by Adam Barth.
Now that Chromium calls setSharedWorkerRepository upon
initializing WebKit (
https://codereview.chromium.org/10990121/ and
https://codereview.chromium.org/11576028/ ) and no longer
tries to override sharedWorkerRepository, it is safe to remove
all references to this function.
- public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKit::WebKitPlatformSupport::idbFactory):
- src/SharedWorkerRepository.cpp:
(WebKit::sharedWorkerRepository):
(WebCore::SharedWorkerRepository::isAvailable):
- 2:23 PM Changeset in webkit [138741] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, fix build for DFG JIT disabled.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpValueProfiling):
(JSC::CodeBlock::dumpArrayProfiling):
- runtime/Executable.cpp:
(JSC):
(JSC::ExecutableBase::intrinsic):
- 2:08 PM Changeset in webkit [138740] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed. Add Windows specific result for passing test.
- platform/win/loader: Added.
- platform/win/loader/image-loader-adoptNode-assert-expected.txt: Added.
- 2:06 PM Changeset in webkit [138739] by
-
- 4 edits in branches/chromium/1364
Merge 138717
Fix incorrect assumption about in-flow descendants of inlines in touch event rect tracking
https://bugs.webkit.org/show_bug.cgi?id=105970
Reviewed by Simon Fraser.
Source/WebCore:
Correcting the touch event target rect accumulation code to no longer incorrectly assume that
non-block renderers held only normal-flow children. The updated code will always walk the
complete renderer sub-tree, but only do the work of calculating the absolute rect when the
child won't necessarily fall inside its parent (floating, positioned, or transformed).
Tests: platform/chromium/fast/events/touch/compositor-touch-hit-rects.html updated to catch bug.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::accumulateRendererTouchEventTargetRects): Walk all renderer sub-trees. Also keeping
track of the last added parent container rect to avoid adding redundant rectangles.
(WebCore::accumulateDocumentEventTargetRects): Avoiding adding empty rects.
LayoutTests:
- platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Updating expectations
- platform/chromium/fast/events/touch/compositor-touch-hit-rects.html: Updating test to check previously failing case where
an inline with a touch handler contains a non-normal-flow child. Also, fixing the test since it was incorrectly duplicated.
- platform/chromium/TestExpectations:
TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/11753015
- 2:05 PM Changeset in webkit [138738] by
-
- 7 edits in trunk/Source
MediaStream API: Add a missing state to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=106017
Reviewed by Adam Barth.
Adding the missing ReadyStateHaveRemoteOffer which will show up in the spec soon.
Source/Platform:
- chromium/public/WebRTCPeerConnectionHandlerClient.h:
Source/WebCore:
Not testable, just another state.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::readyState):
- platform/mediastream/RTCPeerConnectionHandlerClient.h:
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
- 2:04 PM Changeset in webkit [138737] by
-
- 7 edits1 add in trunk/Source
CallLinkStatus should be aware of closure calls, and the DFG bytecode parser should use that as its sole internal notion of how to optimize calls
https://bugs.webkit.org/show_bug.cgi?id=106027
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Previously, the DFG bytecode parser had its own internal notion of exactly what CallLinkStatus was
meant to do, in the form of a CallType, expectedFunction, intrinsic, etc. This change makes CallLinkStatus
smart enough to do all of that, and also gives it the ability to understand closure calls.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::CallLinkStatus):
(JSC):
(JSC::CallLinkStatus::function):
(JSC::CallLinkStatus::internalFunction):
(JSC::CallLinkStatus::intrinsicFor):
(JSC::CallLinkStatus::setIsProved):
(JSC::CallLinkStatus::computeFromLLInt):
(JSC::CallLinkStatus::computeFor):
(JSC::CallLinkStatus::dump):
- bytecode/CallLinkStatus.h:
(JSC):
(JSC::CallLinkStatus::CallLinkStatus):
(CallLinkStatus):
(JSC::CallLinkStatus::takesSlowPath):
(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::isClosureCall):
(JSC::CallLinkStatus::callTarget):
(JSC::CallLinkStatus::executable):
(JSC::CallLinkStatus::structure):
(JSC::CallLinkStatus::isProved):
(JSC::CallLinkStatus::canOptimize):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::valueOfFunctionConstant):
Source/WTF:
Reviewed by Mark Hahnenberg.
I got tired of the various idioms for printing a list of things with comma in between, so I wrote a helper.
- WTF.xcodeproj/project.pbxproj:
- wtf/CommaPrinter.h: Added.
(WTF):
(CommaPrinter):
(WTF::CommaPrinter::CommaPrinter):
(WTF::CommaPrinter::dump):
- 1:51 PM Changeset in webkit [138736] by
-
- 4 edits in trunk
Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
https://bugs.webkit.org/show_bug.cgi?id=105961
Source/WebCore:
Reviewed by Levi Weintraub.
The LayoutUnit::ceil and floor methods overflows if given the
intMaxForLayoutUnit and intMinForLayoutUnit values respectively.
Check for the max/min value to avoid this.
Test: TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp
- platform/LayoutUnit.h:
(WebCore::LayoutUnit::ceil):
(WebCore::LayoutUnit::floor):
Check for the max/min value and return early to avoid overflow.
Use the UNLIKELY macro to avoid the cost of branch misprediction
for the common case.
Tools:
Reviewed by Levi Weintraub.
Add tests for LayoutUnit::ceil and floor.
- TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
(TestWebKitAPI::TEST):
(TestWebKitAPI):
- 1:39 PM Changeset in webkit [138735] by
-
- 13 edits in trunk/Source/WebCore
[Refactoring] Replace Node's Document pointer with a TreeScope pointer
https://bugs.webkit.org/show_bug.cgi?id=59816
Patch by Elliott Sprehn <Elliott Sprehn> on 2013-01-03
Reviewed by Ryosuke Niwa.
Instead of giving every node in a shadow a rare data, which can be quite
large, we replace the Document pointer in Node with a TreeScope pointer
and we give TreeScope a pointer to it's document scope.
This introduces no branches in document() because in the common
case document() becomes equivalent to m_treeScope->m_documentScope where
the documentScope is actually m_treeScope so this shouldn't introduce a
perf regression.
Note also that TreeScope can never be null after r136328, and the document
pointer is only null for DocumentType nodes so we can use a special
no-document TreeScope for this case that always returns null from
documentScope().
My original patch in r137524 for this did not correctly handle the case
where the Document is being destroyed and we would then call guardDeref on
ourself in the middle of the Document destructor causing asserts. To fix
this we need to go back to the original model where Document passes
null to it's super constructor for the Document pointer and assigns
it's tree scope later, and we also need to clear the tree scope pointer
in Document's destructor.
No new tests, no change in behavior.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::suggestedMIMEType):
- dom/Document.h:
(WebCore::Node::isDocumentNode):
(WebCore::Node::Node):
- dom/Element.cpp:
(WebCore::Element::createRareData):
- dom/ElementRareData.h:
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::createRareData):
(WebCore::Node::attach):
(WebCore::Node::reportMemoryUsage):
- dom/Node.h:
(WebCore::NodeRareDataBase::NodeRareDataBase):
(NodeRareDataBase):
(WebCore::Node::treeScope):
(WebCore::Node::inDocument):
(WebCore::Node::documentInternal):
(WebCore::Node::setTreeScope):
(Node):
- dom/NodeRareData.cpp:
(SameSizeAsNodeRareData):
(WebCore::NodeRareData::reportMemoryUsage):
- dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
- dom/TreeScope.cpp:
(SameSizeAsTreeScope):
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::clearDocumentScope):
Needed to clear the document scope during Document destruction
so the Node destructor does not guardDeref the document that is
already being destroyed.
(WebCore::TreeScope::setParentTreeScope):
- dom/TreeScope.h:
(TreeScope):
(WebCore::TreeScope::documentScope):
(WebCore::TreeScope::noDocumentInstance):
Special shared tree scope that has a document scope that is always
null. This is needed for DocType nodes, and also for Documents
during construction.
(WebCore::TreeScope::setDocumentScope):
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
- 1:32 PM Changeset in webkit [138734] by
-
- 3 edits in trunk/LayoutTests
Remove failing or flaky test expectations from tests that have been passing on Mac.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 1:30 PM Changeset in webkit [138733] by
-
- 2 edits in trunk/Tools
Add unit test for default builder for the dashboards.
https://bugs.webkit.org/show_bug.cgi?id=105972
Reviewed by Dirk Pranke.
- TestResultServer/static-dashboards/loader_unittests.js:
- 1:26 PM Changeset in webkit [138732] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed gardening of Apple Windows port.
- platform/win/TestExpectations:
- platform/win/fast/inline/justify-emphasis-inline-box-expected.txt: Added.
- 1:22 PM Changeset in webkit [138731] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- dom/ContainerNode.cpp:
(WebCore::isInTemplateContent): s/UNUSED/UNUSED_PARAM/
- 1:16 PM Changeset in webkit [138730] by
-
- 14 edits7 adds in trunk
[HTMLTemplateElement] Disallow cycles within template content
https://bugs.webkit.org/show_bug.cgi?id=105066
Reviewed by Ojan Vafai.
Source/WebCore:
Cycles in <template> content aren't quite as bad as cycles in normal
DOM trees, but they can easily cause crashes, e.g. in cloneNode and
innerHTML.
Shadow DOM has an analagous issue, and this patch tackles that problem
at the same time by creating a new method, Node::containsIncludingHostElements.
In order to disallow cycles, the HTMLTemplateElement.content
DocumentFragment needs a pointer to its host. The approach here
creates a new subclass with a host pointer and a new virtual method
to DocumentFragment to identify the subclass.
To avoid unnecessary virtual function calls, also changed how
Document::templateContentsOwnerDocument works to allow fast inlined
access and avoid lazy creation when not needed.
Tests: fast/dom/HTMLTemplateElement/cycles-in-shadow.html
fast/dom/HTMLTemplateElement/cycles.html
fast/dom/shadow/shadow-hierarchy-exception.html
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp:
(WebCore::isInTemplateContent):
(WebCore::containsConsideringHostElements):
(WebCore::checkAcceptChild):
- dom/Document.cpp:
(WebCore::Document::ensureTemplateContentsOwnerDocument): Renamed to make clear that it lazily creates the Document. Updated all existing callers to call this method.
- dom/Document.h:
(Document):
(WebCore::Document::templateContentsOwnerDocument): Fast, inlined accessor for use in checkAcceptChild().
- dom/DocumentFragment.h:
(WebCore::DocumentFragment::isTemplateContent):
- dom/Node.cpp:
(WebCore::Node::containsIncludingShadowDOM): made const, simplified
(WebCore::Node::containsIncludingHostElements): Specialized version of Node::contains that knows how to jump over template content boundaries.
- dom/Node.h:
(Node):
- dom/TemplateContentDocumentFragment.h: Added.
(TemplateContentDocumentFragment): Subclass of DocumentFragment which stores its host template element.
(WebCore::TemplateContentDocumentFragment::create):
(WebCore::TemplateContentDocumentFragment::host):
(WebCore::TemplateContentDocumentFragment::TemplateContentDocumentFragment):
- editing/markup.cpp:
(WebCore::createFragmentForInnerOuterHTML):
- html/HTMLTemplateElement.cpp:
(WebCore::HTMLTemplateElement::content): Construct the new subclass.
LayoutTests:
- fast/dom/HTMLTemplateElement/cycles-expected.txt: Added.
- fast/dom/HTMLTemplateElement/cycles-in-shadow-expected.txt: Added.
- fast/dom/HTMLTemplateElement/cycles-in-shadow.html: Added.
- fast/dom/HTMLTemplateElement/cycles.html: Added.
- fast/dom/shadow/shadow-hierarchy-exception-expected.txt: Added.
- fast/dom/shadow/shadow-hierarchy-exception.html: Added.
- 1:00 PM Changeset in webkit [138729] by
-
- 15 edits in trunk/Source
Revert auto-start plugins to snapshotted plugins after a period of inactivity
https://bugs.webkit.org/show_bug.cgi?id=105973
<rdar://problem/12947865>
Reviewed by Brady Eidson.
Source/WebCore:
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::plugInOriginHash): Expose publicly for WebKit2.
Reorganize the protected members of the class.
- html/HTMLPlugInImageElement.h: Move the member to HTMLPlugInElement.
Source/WebKit2:
Change the set of origin hashes maintained by the web process to a hash map that associates
a timestamp for each hash. If the plug-in's origin is marked for auto-start, we also check
it against the timestamp. If the time is later, then we consider the entry stale, and snapshot
the plug-in instead.
But, if the user interacts with the plug-in, we delay that expiration timestamp out, so that
it expires a month from first interaction. To avoid too much chatter between the web processes
and UI process, we only update the timestamp if a day a passed since the last change to the
timestamp.
- WebProcess/Plugins/PluginView.h:
(PluginView): Add a member variable to flag whether the user had interacted with the plug-in.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView): Initialize the flag to false.
(WebKit::PluginView::handleEvent): We consider mouse down, up, wheel, context menu, and keyboard
events as user interaction. Do not consider mouse enter, leave, and move events as user
interaction. Also, remove unneeded comments.
(WebKit::PluginView::pluginDidReceiveUserInteraction): If this is the first time the function is
called, tell the web process, so that the expiration timestamp can be updated.
- WebProcess/WebProcess.messages.in: Update the messages to include the expiration time.
- WebProcess/WebProcess.h:
(WebProcess): Update the cached copy of the auto-start origins to include their expiration
timestamps. Update the message signatures. Add a function to update the expiration timestamp
for a specific origin. Rename plugInAutoStartOriginsChanged to resetPlugInAutoStartOrigins.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Instead of individually adding the origins in the
provided vector, just call resetPlugInAutoStartOrigins().
(WebKit::WebProcess::isPlugInAutoStartOrigin): Check to see if the origin is in the table, and if
so, check the current time against the expiration time.
(WebKit::WebProcess::didAddPlugInAutoStartOrigin): Update the cached table.
(WebKit::WebProcess::resetPlugInAutoStartOrigins): Swap the tables between the provided parameter
and the member variable. We can safely do this because the function is called in two cases where
the parameter is afterwards thrown away: when a new web process is created, and when it is called
through an IPC message.
(WebKit::WebProcess::plugInDidReceiveUserInteraction): When invoked, we tell the UI process to
update the expiration time for the given origin if the time difference between the expiration
time and the current time is less than the threshold plugInAutoStartExpirationTimeUpdateThreshold.
- UIProcess/WebContext.messages.in: Add message that is called when the web process wants to
update the expiration timestamp for the plug-in origin.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::plugInDidReceiveUserInteraction): Forward to the provider.
- UIProcess/WebContext.h:
- UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::expirationTimeFromNow): Returns a new time based on the current time + 1 month.
(WebKit::PlugInAutoStartProvider::addAutoStartOrigin): Refactor. Set the expiration time for the
added origin.
(WebKit::PlugInAutoStartProvider::autoStartOriginsCopy): Refactor.
(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy): Refactor to include the expiration
times. Also, check the current time against the expiration time. If we are past the time, remove
the entry from the copy.
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTable): Refactor to extract and duplicate
the provided map of origins and expiration timestamps.
(WebKit::PlugInAutoStartProvider::didReceiveUserInteraction): Look for the origin hash. If found,
update the expiration time. Update all existing web processes with the new expiration time, and
tell the context client that the hashes have changed.
- UIProcess/Plugins/PlugInAutoStartProvider.h:
(PlugInAutoStartProvider): Change the m_autoStartHashes variable to a map of a hash to its domain
entry in the auto-start table. It is used to cross-reference the auto-start table and update
the origin's expiration time.
- Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters): Switch the creation parameter to seed the origin table to a map.
- 12:22 PM Changeset in webkit [138728] by
-
- 20 edits in trunk
Querying transition-timing-function value on the computed style does not return keywords when it should.
https://bugs.webkit.org/show_bug.cgi?id=105442
Reviewed by Simon Fraser.
Source/WebCore:
http://www.w3.org/TR/css3-transitions/#transition-timing-function-property
contains a set of predefined timing functions which under the hood are
implemented using cubic-bezier but it's an implementation detail that
should not be exposed. It seems to be more clear to return a CSS
keyword rather than the cubic-bezier form when querying the value of
the property on the computed style. In fact the spec even say that for
example the initial value is "ease" and not cubic-bezier(0.25, 0.1,
0.25, 1.0). We could also imagine that in the future these predefined
values could contain other values not represented by a cubic-bezier
form. This behavior also align with the "linear" keyword which return
"linear" rather than cubic-bezier(0.0, 0.0, 1.0, 1.0).
Test: transitions/transitions-parsing.html has been updated to cover
the new behavior as well as making sure that an explicitly set value of
cubic-bezier(0.25, 0.1, 0.25, 1.0) does not return "ease" but the
cubic-bezier() form.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::createAnimationValue):
(WebCore):
(WebCore::getTimingFunctionValue):
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
- platform/animation/TimingFunction.h:
(WebCore::CubicBezierTimingFunction::create):
(CubicBezierTimingFunction):
(WebCore::CubicBezierTimingFunction::operator==):
(WebCore::CubicBezierTimingFunction::timingFunctionPreset): Store the
preset value of the timing function if it is one when creating it
so we can use it later from the computed style.
(WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
Source/WebKit2:
Update the code to pass the animations from one process to another as
the constructor of TimingFunction changed to take an extra parameter
holding the type of the cubic-bezier form.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::encodeTimingFunction):
(CoreIPC::decodeTimingFunction):
LayoutTests:
Update the tests to match the correct behavior of returning a keyword
rather than a cubic-bezier() form when using predefined values for the
transition-timing-function property.
- animations/animation-shorthand-name-order-expected.txt:
- animations/animation-shorthand-name-order.html:
- animations/animation-shorthand-removed.html:
- animations/animation-shorthand.html:
- animations/computed-style-expected.txt:
- animations/computed-style.html:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- transitions/inherit-other-props-expected.txt:
- transitions/inherit-other-props.html:
- transitions/transitions-parsing-expected.txt:
- transitions/transitions-parsing.html:
- 12:07 PM Changeset in webkit [138727] by
-
- 23 edits in trunk
Generate internal.settings from Settings.in
https://bugs.webkit.org/show_bug.cgi?id=104740
Reviewed by Adam Barth.
.:
- Source/cmake/WebKitMacros.cmake: Specify additional output files from make_settings.pl.
Source/WebCore:
If the setting is declared in Settings.in and is a basic type, generate a
setter function at internals.settings.
InternalSettingsGenerated.idl is created by make_settings.pl. InternalSettings.idl
inherits from InternalSettingsGenerated.idl so we can override generated functions if
needed or add additional custom setters.
This patch removes 2 password echo methods from InternalSettings.idl since they are
auto generated. There are other methods we could remove, but I'll do that in a followup.
No new tests, existing tests should pass. Specifically, editing/input/password* tests should pass.
- CMakeLists.txt: Add generated cpp file to the testing lib.
- DerivedSources.make: Add generated idl file and specify all the outputs of make_settings.pl
- DerivedSources.pri: Generate idl file before generating bindings and include generated idl
for bindings generation.
- GNUmakefile.am: Specify all the generated files of make_settings.pl. Add generated idl to
list of files to be processed and resulting output to be compiled.
- UseJSC.cmake: Add generated idl file to list of idl files to process.
- UseV8.cmake: Same as UseJSC.cmake.
- WebCore.gyp/WebCore.gyp: Run make_settings.pl earlier so we can run the output through the
bindings generator.
- WebCore.gypi: Add new files.
- WebCore.vcproj/WebCoreTestSupport.vcproj: Add new files.
- WebCore.xcodeproj/project.pbxproj: Add new files.
- bindings/scripts/CodeGenerator.pm:
(IDLFileForInterface): Add current directory to the include path so DerivedSources.make can
find the generated idl file.
- page/make_settings.pl:
(generateCode): Generate InternalSettingsGenerated.{idl,h,cpp}.
(generateSettingsMacrosHeader): Rename since we're generating 2 headers now.
(setterFunctionName): Helper function for naming a setter.
(printGetterAndSetter): Use setterFunctionName.
(enumerateParsedItems): Helper function that visits each parsed item.
(generateInternalSettingsIdlFile): Generate idl file.
(generateInternalSettingsHeaderFile): Generate header file.
(generateInternalSettingsCppFile): Generate C++ file.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Remove password echo members.
(WebCore::InternalSettings::Backup::restoreTo): Remove password echo members.
(InternalSettingsWrapper): We can't use RefCountedSupplemental because we're we're already
RefCounted. Create a wrapper class to wrap the RefCounted InternalSettings for Supplement<>::provideTo,
which uses an OwnPtr.
(WebCore::InternalSettingsWrapper::InternalSettingsWrapper): Wraps an InternalSettings that the Page can own.
(WebCore::InternalSettingsWrapper::~InternalSettingsWrapper): Clear's m_page when the Page goes away.
(WebCore::InternalSettingsWrapper::internalSettings): Unwrap InternalSettings.
(WebCore::InternalSettings::from): Update to use InternalSettingsWrapper.
(WebCore::InternalSettings::InternalSettings): Call base class constructor.
(WebCore::InternalSettings::resetToConsistentState): Renamed from reset() and pass through to base class.
Also remove unnecessary pageScaleFactor reset (done in Internals::resetToConsistentState).
- testing/InternalSettings.h:
(Backup): Remove password echo members.
(WebCore::InternalSettings::create): Create an instance instead of using new.
(WebCore::InternalSettings::hostDestroyed): Clear the page. This is similar to the code that
RefCountedSupplemental has.
- testing/InternalSettings.idl: Extends InternalSettingsGenerated.
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): Rename to resetToConsistentState to be like other code.
- testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): Rename to resetToConsistentState to be like other code.
Remove an unused header.
Tools:
- GNUmakefile.am: Compile new generated files on GTK+.
- qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
with both extra_sources and add_output_to_sources=false will still
compile the files in extra_sources. This makes it possible to compile
InternalSettingsGenerated.cpp and not be confused by
InternalSettingsGenerated.idl.
- 12:04 PM Changeset in webkit [138726] by
-
- 7 edits in trunk
Canvas blending tests fail on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=105943
Patch by Rik Cabanier <cabanier@adobe.com> on 2013-01-03
Reviewed by Simon Fraser.
Source/WebCore:
Tests that now pass:
LayoutTests/fast/canvas/canvas-blend-solid.html
LayoutTests/fast/canvas/canvas-blend-image.html
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
- testing/InternalSettings.h:
(Backup):
Source/WebKit2:
CanvasUsesAcceleratedDrawing preference was not passed to the WebProcess.
- WebProcess/InjectedBundle/InjectedBundle.cpp: Adds support for CanvasUsesAcceleratedDrawing to WK2
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
LayoutTests:
- platform/mac-wk2/TestExpectations: updated expectations as the test now passes
- 11:59 AM Changeset in webkit [138725] by
-
- 3 edits in trunk/Source/WebCore
Microdata: Fix build failure after r137003
https://bugs.webkit.org/show_bug.cgi?id=106023
Reviewed by Ryosuke Niwa.
Set HTMLCollection::namedPropertyGetter as named property getter for
HTMLPropertiesCollection in GenerateImplementationNamedPropertyGetter.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementationNamedPropertyGetter):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::namedPropertyGetter):
- 11:52 AM Changeset in webkit [138724] by
-
- 4 edits2 adds in trunk
Clear failed image loads when an <img> is adopted into a different document
https://bugs.webkit.org/show_bug.cgi?id=104409
Reviewed by Nate Chapin.
Source/WebCore:
This avoids an assertion failure setImageWithoutConsideringPendingLoadEvent().
Test: loader/image-loader-adoptNode-assert.html
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement): Use new helper.
(WebCore::ImageLoader::updateFromElementIgnoringPreviousError): ditto
(WebCore::ImageLoader::elementDidMoveToNewDocument): ditto
(WebCore::ImageLoader::clearFailedLoadURL): Added a helper method to self-document the code.
(WebCore):
- loader/ImageLoader.h:
(ImageLoader):
LayoutTests:
- loader/image-loader-adoptNode-assert-expected.txt: Added.
- loader/image-loader-adoptNode-assert.html: Added.
- 11:24 AM Changeset in webkit [138723] by
-
- 6 edits in trunk/Source/WebKit2
[Qt] Use WebPageProxy::postMessageToInjectedBundle when passing messages to a specific page in the builtin bundle
https://bugs.webkit.org/show_bug.cgi?id=105928
Reviewed by Simon Hausmann.
Simplify the code since we now can send the contents as is, instead of packaging it inside
an array that also contained the reference for the page. This was made possible after
r126311.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::setNavigatorQtObjectEnabled):
(QQuickWebViewExperimental::postMessage):
Built the messages and used WebPageProxy::postMessageToInjectedBundle() directly.
- UIProcess/qt/QtWebContext.cpp: Removed functions that now are simpler and were inlined in
qquickwebview.cpp.
- UIProcess/qt/QtWebContext.h: Ditto.
- WebProcess/qt/QtBuiltinBundle.cpp:
(WebKit::QtBuiltinBundle::initialize): Used the callback that gets messages for specific
pages. Also changed the way we create the bundle client: now we fill the struct with zeros,
and then set the fields we care about. This way if another field is added to that client,
this code doesn't need to be changed.
(WebKit::QtBuiltinBundle::didReceiveMessageToPage):
(WebKit::QtBuiltinBundle::handleMessageToNavigatorQtObject): Changed to not read the page
reference from the message, since we get it in the callback already.
(WebKit::QtBuiltinBundle::handleSetNavigatorQtObjectEnabled): Ditto.
- WebProcess/qt/QtBuiltinBundle.h:
(QtBuiltinBundle):
- 11:07 AM Changeset in webkit [138722] by
-
- 5 edits in trunk
Sandbox-blocked pointer lock should log to the console.
https://bugs.webkit.org/show_bug.cgi?id=105794
Reviewed by Adrienne Walker.
Source/WebCore:
When pointer lock is requested and is denied due to sandbox restrictions
a helpful message to web developers is sent to the developer console.
Existing test expectations updated.
- page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
LayoutTests:
- http/tests/pointer-lock/iframe-sandboxed-expected.txt:
- http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-expected.txt:
- 11:05 AM Changeset in webkit [138721] by
-
- 3 edits in trunk/LayoutTests
Add tests to cover what transition-timing-function accepts for cubic-bezier values.
https://bugs.webkit.org/show_bug.cgi?id=105426
Reviewed by Simon Fraser.
http://www.w3.org/TR/css3-transitions/#transition-timing-function-property
has not yet been updated following the discussions
http://lists.w3.org/Archives/Public/www-style/2010Apr/0489.html and
http://lists.w3.org/Archives/Public/www-style/2010Jun/0254.html where
the range restriction of Y values for cubic-bezier type has been
removed. This patch add tests to cover that behavior to avoid breakage
in the future and test also various other different cubic-bezier use
cases.
- transitions/transitions-parsing-expected.txt:
- transitions/transitions-parsing.html:
- 10:48 AM Changeset in webkit [138720] by
-
- 2 edits in trunk/Source/WebCore
PingLoader.h missing virtual and OVERRIDE keywords on its inherited methods.
https://bugs.webkit.org/show_bug.cgi?id=105975
Reviewed by Nate Chapin.
Change adds compile-time checks only, so no new tests.
- loader/PingLoader.h:
(PingLoader):
(WebCore::PingLoader::timeout):
- 10:42 AM Changeset in webkit [138719] by
-
- 3 edits in trunk/Tools
[style] WebIDL-reflecting uppercase enums reported as style violation
https://bugs.webkit.org/show_bug.cgi?id=105832
Reviewed by Tony Chang.
Recognize the enum as WebIDL-reflecting one if there's a comment present that
indicates this. In enums spanning over multiple lines, the comment is expected
on the first line. In enums placed in one line, the comment is expected at the
end of that line.
WebIDL-reflecting enum values are required to be written in uppercase and as such
violate the common rule of these values being written in InterCaps. Annotating
enums this way makes it possible to avoid false style violation reports.
The comment is of form ' Web(?:Kit)?IDL enum'.
- Scripts/webkitpy/style/checkers/cpp.py:
(_EnumState.init):
(_EnumState.process_clean_line):
(check_enum_casing):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(NoNonVirtualDestructorsTest.test_enum_casing):
- 10:38 AM Changeset in webkit [138718] by
-
- 3 edits in trunk/LayoutTests
Update Mac test expectations after merging the bug 105987 into the bug 105986.
Also add one more test expectation for the bug.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 10:32 AM Changeset in webkit [138717] by
-
- 6 edits in trunk
Fix incorrect assumption about in-flow descendants of inlines in touch event rect tracking
https://bugs.webkit.org/show_bug.cgi?id=105970
Reviewed by Simon Fraser.
Source/WebCore:
Correcting the touch event target rect accumulation code to no longer incorrectly assume that
non-block renderers held only normal-flow children. The updated code will always walk the
complete renderer sub-tree, but only do the work of calculating the absolute rect when the
child won't necessarily fall inside its parent (floating, positioned, or transformed).
Tests: platform/chromium/fast/events/touch/compositor-touch-hit-rects.html updated to catch bug.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::accumulateRendererTouchEventTargetRects): Walk all renderer sub-trees. Also keeping
track of the last added parent container rect to avoid adding redundant rectangles.
(WebCore::accumulateDocumentEventTargetRects): Avoiding adding empty rects.
LayoutTests:
- platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Updating expectations
- platform/chromium/fast/events/touch/compositor-touch-hit-rects.html: Updating test to check previously failing case where
an inline with a touch handler contains a non-normal-flow child. Also, fixing the test since it was incorrectly duplicated.
- platform/chromium/TestExpectations:
- 10:23 AM Changeset in webkit [138716] by
-
- 9 edits in trunk/Source
IndexedDB: Simplify IDBTransactionBackendImpl::scheduleTask usage
https://bugs.webkit.org/show_bug.cgi?id=103536
Reviewed by Tony Chang.
Source/WebCore:
Move responsibility for firing abort errors from requests that arrive on the
back-end after an asynchronous transaction abort out of WebCore, since the
front-end takes care of this as far as script is concerned.
No new tests - no behavior changes.
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::advance):
(WebCore::IDBCursorBackendImpl::prefetchContinue):
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::count):
Source/WebKit/chromium:
Track whether IDBCallbacks has fired before being destructed. If not it probably
came in after a transaction had asynchronously aborted; fire an abort error which
will be ignored on the front-end but will clean up lingering IPC tracking.
- public/WebIDBDatabaseException.h:
- src/AssertMatchingEnums.cpp:
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::IDBCallbacksProxy):
(WebKit::IDBCallbacksProxy::~IDBCallbacksProxy):
(WebKit::IDBCallbacksProxy::onError):
(WebKit::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
- 10:17 AM Changeset in webkit [138715] by
-
- 4 edits in trunk/Source/WebKit2
[Qt] Fix a crash when the QQuickWebPage is destroyed between the scene graph sync and render.
https://bugs.webkit.org/show_bug.cgi?id=106018
Reviewed by Simon Hausmann.
The main and rendering threads are only guaranteed to be synchronised in
the updatePaintNode call. In every other cases, QQuickItems cannot be
safely accessed from the rendering thread.
Do as the first patch version in
https://bugs.webkit.org/show_bug.cgi?id=104574 was doing and copy the
ratio value directly to fix the issue.
Also add a note about the threading issue in QQuickWebPage::updatePaintNode.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::updatePaintNode):
- UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::QtWebPageSGNode::QtWebPageSGNode):
- UIProcess/qt/QtWebPageSGNode.h:
(QtWebPageSGNode):
(WebKit::QtWebPageSGNode::devicePixelRatio):
(WebKit::QtWebPageSGNode::setDevicePixelRatio):
- 10:17 AM Changeset in webkit [138714] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marking webaudio/automatic-pull-node.html as
[ Pass Slow ] instead of [ Pass Timeout ] for XP.
- platform/chromium/TestExpectations:
- 10:05 AM Changeset in webkit [138713] by
-
- 2 edits1 add in trunk/Tools
Adding favicon.ico to the garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=105982
Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-03
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/servers/gardeningserver.py:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
- 9:32 AM Changeset in webkit [138712] by
-
- 3 edits in trunk/Source/WebCore
Update BB10 media render theme.
https://bugs.webkit.org/show_bug.cgi?id=105728
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-01-03
Reviewed by Yong Li.
Internally Reviewed by John Griggs.
Update GL friendly render method for audio volume.
Change the background color for embedded media player to semi-transparent.
Change remaining time font color to grey to match full screen video.
Change media slider thumb color to blue when pressed.
- css/mediaControlsBlackBerry.css:
(audio):
(audio::-webkit-media-controls-embedded-panel, video::-webkit-media-controls-embedded-panel):
(video::-webkit-media-controls-time-display-container, audio::-webkit-media-controls-time-display-container):
(video::-webkit-media-controls-timeline-container, audio::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(video::-webkit-media-controls-time-remaining-display, audio::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-volume-slider-container):
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
- 9:12 AM BadContent edited by
- Adding a spamming account. (diff)
- 9:05 AM Changeset in webkit [138711] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r138640.
http://trac.webkit.org/changeset/138640
https://bugs.webkit.org/show_bug.cgi?id=106019
Causing crashes in multiply() (Requested by danakj on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-03
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore):
(WebCore::TransformationMatrix::multiply):
- platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):
- 9:02 AM WebKit Team edited by
- (diff)
- 6:37 AM Changeset in webkit [138710] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip a new failing test.
- platform/qt/TestExpectations:
- 6:30 AM Changeset in webkit [138709] by
-
- 11 edits2 adds in trunk
The 'body' of seamless IFrames should default to 'margin: 0'
https://bugs.webkit.org/show_bug.cgi?id=90834
Reviewed by Antti Koivisto.
Source/WebCore:
Documents displayed in seamless iframes should override the 'body'
element's normal 8px default margins with 0px, in order to ensure that
contents are displayed flush with the boundries of the seamless box.[1]
This patch does so by adding a new pseudoclass to allow the user agent
stylesheet to specify a different margin for seamless documents.
[1]: http://lists.w3.org/Archives/Public/public-whatwg-archive/2012Jul/0039.html
Test: fast/frames/seamless/seamless-body-margin.html
- css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
- css/CSSSelector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
- css/html.css:
(body:-webkit-seamless-document):
- rendering/style/RenderStyleConstants.h:
Define a new pseudoclass: '-webkit-seamless-document', which
matches for any element in a document that's rendered in a
seamless IFrame.
LayoutTests:
- fast/frames/seamless/seamless-body-margin-expected.txt: Added.
- fast/frames/seamless/seamless-body-margin.html: Added.
New test to explicitly check 'body' margins.
- fast/frames/seamless/resources/nested-seamless.html:
- fast/frames/seamless/resources/quirks-square.html:
- fast/frames/seamless/resources/two-inline-blocks.html:
- fast/frames/seamless/seamless-inherited-origin-expected.txt:
- fast/frames/seamless/seamless-inherited-origin.html:
Updated these tests to remove the assumption that the body had an
8px margin.
- 6:28 AM Changeset in webkit [138708] by
-
- 6 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations: Skip new failing tests.
- platform/qt/editing/deleting/delete-to-select-table-expected.txt: Updated after r138654.
- platform/qt/editing/execCommand/print-expected.txt: Updated after r138654.
- platform/qt/editing/execCommand/selectAll-expected.txt: Updated after r138654.
- platform/qt/editing/inserting/editable-html-element-expected.txt: Updated after r138654.
- 6:13 AM Changeset in webkit [138707] by
-
- 2 edits in trunk/Tools
[Qt] Fix library linking order
https://bugs.webkit.org/show_bug.cgi?id=105818
Some Qt libraries are linked before the private static libraries
that depend on them which results in QtWebKit failing to link.
Copy Qt module dependencies from QT to QT_PRIVATE when creating
module to ensure the Qt libraries are linked after the private
static libraries that depend on them.
Patch by Jonathan Liu <net147@gmail.com> on 2013-01-03
Reviewed by Tor Arne Vestbø.
- qmake/mkspecs/features/default_post.prf:
- 5:43 AM Changeset in webkit [138706] by
-
- 3 edits in trunk/Source/WebKit/win
Unreviewed fix after r138656 to make GIT-SVN repositories happy.
- 1:54 AM Changeset in webkit [138705] by
-
- 4 edits in trunk/Source
[MinGW-w64] Centralize workaround for pow() implementation
https://bugs.webkit.org/show_bug.cgi?id=105925
Reviewed by Sam Weinig.
As suggested by Sam, move the MinGW-w64 workaround into MathExtras.h
away from the JSC usage.
Source/JavaScriptCore:
- runtime/MathObject.cpp:
(JSC::mathPow):
Source/WTF:
- wtf/MathExtras.h:
(wtf_pow):
- 1:13 AM Changeset in webkit [138704] by
-
- 4 edits3 adds in trunk
seamless iframes don't inherit styles when srcdoc is used
https://bugs.webkit.org/show_bug.cgi?id=103539
Reviewed by Antti Koivisto.
Source/WebCore:
Seamless iframes populated via a 'srcdoc' attribute should always
inherit styles from their parent documents. At the moment, this is
only the case when they contain a stylesheet or some other markup
that forces a style recalculation on the document. Simple 'srcdoc'
attributes (e.g. "srcdoc='<p>This is a comment.</p>'") bail out of
recalculating style early, resulting in unstyled appearance.
This patch instructs WebCore to treat seamless documents as having an
updated StyleResolver regardless of what actions the parser takes,
which in turn ensures that the document's style is recalculated
correctly.
Test: fast/frames/seamless/seamless-srcdoc.html
- dom/Document.cpp:
(WebCore::Document::implicitOpen):
If it's a seamless document, notify it that its StyleResolver isn't
what it might have expected.
LayoutTests:
- fast/frames/seamless/resources/span.html: Added.
- fast/frames/seamless/seamless-contenteditable-not-inherited-expected.txt:
Updating the previously failing expectation.
- fast/frames/seamless/seamless-srcdoc-expected.txt: Added.
- fast/frames/seamless/seamless-srcdoc.html: Added.
Exciting new test to ensure that this doesn't regress, neither
for totally simple srcdoc attriubtes, nor for slightly more
complex variations.
- 12:42 AM Changeset in webkit [138703] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Implement SimpleFontData::platformBoundsForGlyph
https://bugs.webkit.org/show_bug.cgi?id=104127
Reviewed by Jocelyn Turcotte.
Implements platformBoundsForGlyph which is necessary for working MathML and Ruby.
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
Jan 2, 2013:
- 11:11 PM Changeset in webkit [138702] by
-
- 2 edits in trunk/LayoutTests
Add failing test expectations for two canvas tests on Mac Lion
since they have been failing as far as we could tell on the flakiness dashboard.
The failure is tracked by the bug 105999.
- platform/mac/TestExpectations:
- 11:09 PM Changeset in webkit [138701] by
-
- 8 edits in trunk/Source/WebCore
Remove superfluous 'IntPoint toPoint(const IntSize&)'
https://bugs.webkit.org/show_bug.cgi?id=105993
Patch by Steve Block <steveblock@chromium.org> on 2013-01-02
Reviewed by Eric Seidel.
Refactoring only, no change in behavior.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remoteSVGElementHitTest):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
- platform/graphics/IntPoint.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::offsetFromResizeCorner):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
- 11:05 PM Changeset in webkit [138700] by
-
- 2 edits in trunk/LayoutTests
Add a Mac test expectation for the bug 105998.
- platform/mac-wk2/TestExpectations:
- 10:11 PM Changeset in webkit [138699] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] file:/// pages don't get correct scales after several rotations and history navigations
https://bugs.webkit.org/show_bug.cgi?id=105996
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by George Staikos.
PR: 273541
When navigating back to the previous page on portrait mode, we were
trying to set virtual viewport after recalculation. However, we didn't
change the fixed layout size so that we still layouted the contents at
the old virtual viewport size. In this case, the old virtual viewport
was 570 * 293 which was set in landscape mode unfortunately. There
would be no chance for such kind of contents size to fit the portrait
mode screen size nicely.
This was a regression of webkit/cc31d9bad where setViewMode() was
removed as a noop. So just get setViewMode() back to apply the fixed
layout size with a little bit change as SVG document path was proved
invalid in that patch. Thanks to George for the float comparison change.
Put a FIXME as we don't have a way to save the scale precisely before
the rotation and history navigation currently.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
- 9:36 PM Changeset in webkit [138698] by
-
- 3 edits in trunk/LayoutTests
More Mac test expectation updates per bugs 105988 and 105987.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 8:47 PM Changeset in webkit [138697] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Fix tooltip bugs in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=102209
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2013-01-02
Reviewed by Gyuyoung Kim.
Set tooltip on the elm_window instead of ewk_view, and add delay to
show the tooltip window.
Setting tooltip on the ewk_view makes elementary error message because
ewk_view is not an elementary widget. To remove the error message,
tooltip should be set on the elm_window.
Most browsers show the tooltip after a mouse pointer stays on an
element object that has tooltip text.
But elm_tooltip widget itself doesn't have delay or handle mouse
events to show/hide.
So additional codes are added to show/hide tooltip widget along with
mouse events.
1) When a mouse pointer stays for a second on an element which has
tooltip text, then tooltip widget is displayed.
2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
widget.
- MiniBrowser/efl/main.c:
(_Tooltip_Information):
(_Browser_Window):
(on_tooltip_show):
(window_tooltip_hide):
(window_tooltip_update):
(on_mouse_in):
(on_mouse_move):
(on_mouse_out):
(window_free):
(on_tooltip_text_set):
(on_tooltip_text_unset):
(window_create):
- 8:44 PM Changeset in webkit [138696] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Do not determine db quota limit using db file size
https://bugs.webkit.org/show_bug.cgi?id=105991
PR 267191
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-01-02
Reviewed by George Staikos.
Passing the current quota to WebPageClientImpl::databaseQuota so we can determine a better
quota limit without using the db file size.
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
- 8:39 PM Changeset in webkit [138695] by
-
- 3 edits in trunk/Source/WebCore
[TexMap] Remove m_size in TextureMapperLayer.
https://bugs.webkit.org/show_bug.cgi?id=105781
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-02
Reviewed by Noam Rosenthal.
m_size is duplicated by State::size, so this patch removes it.
No new tests. Refactoring only.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::layerRect):
(TextureMapperLayer):
- 7:24 PM Changeset in webkit [138694] by
-
- 2 edits in trunk/LayoutTests
Add flaky crash expectations for multiple tests on Mac WebKit2.
- platform/mac-wk2/TestExpectations:
- 7:22 PM Changeset in webkit [138693] by
-
- 15 edits4 adds in trunk
[chromium] Creation of dedicated workers (isolates) leaks reference to HTMLDocument
https://bugs.webkit.org/show_bug.cgi?id=105367
Reviewed by Dmitry Titov.
Source/WebCore:
Eliminated a Chromium-specific object wrapping WorkerMessagingProxy in order to fix a
lifetime management bug, which leaked every Document which started a dedicated worker.
Test: fast/workers/worker-document-leak.html
- workers/WorkerLoaderProxy.h:
(WorkerLoaderProxy):
Added Chromium-specific casting method to bridge two now-distinct class hierarchies.
- workers/WorkerMessagingProxy.h:
(WorkerMessagingProxy):
Made destructor protected instead of private to allow subclassing.
Source/WebKit/chromium:
Made WebWorkerClientImpl a subclass of WorkerMessagingProxy rather than an object wrapping
WorkerMessagingProxy. WorkerMessagingProxy manages its own lifetime and it is impossible to
properly synchronize the lifetime of WebWorkerClientImpl separately.
This allowed most of WebWorkerClientImpl to be deleted, but forced a divergence in the class
hierarchies of WebWorkerClientImpl and WebSharedWorkerImpl. Conversion methods were added to
WorkerLoaderProxy and WebWorkerBase to bridge the hierarchies of in-process and
out-of-process workers.
- src/DatabaseObserver.cpp:
(WebCore::DatabaseObserver::canEstablishDatabase):
Adjusted how WebWorkerBase is obtained from WorkerLoaderProxy.
- src/IDBFactoryBackendProxy.cpp:
(WebKit::AllowIndexedDBMainThreadBridge::signalCompleted):
Adjusted how WorkerLoaderProxy's methods are called.
(WebKit::IDBFactoryBackendProxy::allowIndexedDB):
Adjusted how WebWorkerBase is obtained from WorkerLoaderProxy.
- src/LocalFileSystemChromium.cpp:
(WebCore::openFileSystemHelper):
Adjusted how WebWorkerBase is obtained from WorkerLoaderProxy.
- src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::toWebWorkerBase):
Implemented new conversion method.
- src/WebSharedWorkerImpl.h:
(WebSharedWorkerImpl):
Explicitly derive from WorkerLoaderProxy now that WebWorkerBase no longer does.
(WebKit::WebSharedWorkerImpl::workerLoaderProxy):
Added new conversion method.
- src/WebWorkerBase.h:
(WebWorkerBase):
Removed derivation from WorkerLoaderProxy. Added method to convert to WorkerLoaderProxy.
- src/WebWorkerClientImpl.cpp:
(WebKit):
Adjusted comment.
(WebKit::WebWorkerClientImpl::createWorkerContextProxy):
Adjusted whitespace.
(WebKit::WebWorkerClientImpl::terminateWorkerContext):
Eliminated delegation to separate object.
(WebKit::WebWorkerClientImpl::toWebWorkerBase):
Implemented new conversion method.
(WebKit::WebWorkerClientImpl::view):
(WebKit::WebWorkerClientImpl::allowDatabase):
(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::openFileSystem):
(WebKit::WebWorkerClientImpl::allowIndexedDB):
Eliminated delegation to separate object.
(WebKit::WebWorkerClientImpl::WebWorkerClientImpl):
- src/WebWorkerClientImpl.h:
(WebKit):
Changed to inherit from WorkerMessagingProxy directly.
(WebWorkerClientImpl):
Deleted most methods previously overridden from WorkerContextProxy, etc.
- src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):
Hold on to, and use, WorkerLoaderProxy rather than WebWorkerBase.
- src/WorkerAsyncFileSystemChromium.h:
(WebKit):
(WebCore):
(WorkerAsyncFileSystemChromium):
Hold on to WorkerLoaderProxy rather than WebWorkerBase.
LayoutTests:
- fast/workers/resources/empty-worker.js: Added.
- fast/workers/resources/worker-document-leak-iframe.html: Added.
- fast/workers/worker-document-leak-expected.txt: Added.
- fast/workers/worker-document-leak.html: Added.
- 7:09 PM Changeset in webkit [138692] by
-
- 3 edits2 deletes in trunk/LayoutTests
One more Mac rebaseline attempt for r138654. Also remove an entry for the bug 105514
which has been dup'ed with the bug 103663 for which we have more specific expectations.
- platform/mac-lion/editing/deleting: Removed.
- platform/mac-lion/editing/deleting/delete-to-select-table-expected.txt: Removed.
- platform/mac-wk2/editing/deleting: Removed.
- platform/mac-wk2/editing/deleting/delete-to-select-table-expected.txt: Removed.
- platform/mac/TestExpectations:
- platform/mac/editing/deleting/delete-to-select-table-expected.txt:
- 6:59 PM Changeset in webkit [138691] by
-
- 6 edits in trunk/Source/WebCore
Make ClassList::reset's purpose obvious and don't keep quirks string when not needed
https://bugs.webkit.org/show_bug.cgi?id=105963
Reviewed by Ojan Vafai.
ClassList::reset only exists to handle updating the special SpaceSplitString
for quirks mode documents. This adds a new method that makes this obvious and
instead of updating the string immediately clear the value and lazily
update it. We also clear the value whenever we're inserted into the
document so that when moving from a quirks mode document to a non-quirks
mode document we don't keep the SpaceSplitString around if it's not needed.
No new tests, I'm not sure how to write a test that we don't keep the
SpaceSplitString when moving between quirks and non-quirks mode documents.
- dom/Element.cpp:
(WebCore::Element::classAttributeChanged):
(WebCore::Element::insertedInto):
- dom/Element.h:
(Element):
- dom/ElementRareData.h:
(WebCore::ElementRareData::clearClassListValueForQuirksMode):
- html/ClassList.cpp:
- html/ClassList.h:
(WebCore::ClassList::clearValueForQuirksMode):
- 6:05 PM Changeset in webkit [138690] by
-
- 6 edits in trunk/Source/WebKit/chromium
[chromium] Remove unused transitional #defines from WebKit Client API
https://bugs.webkit.org/show_bug.cgi?id=105974
Patch by James Robinson <jamesr@chromium.org> on 2013-01-02
Reviewed by Adam Barth.
The transitions these #defines helped with have completed.
- public/WebFileSystemCallbacks.h:
(WebKit):
- public/WebKit.h:
- public/WebRuntimeFeatures.h:
- public/WebSettings.h:
- public/WebWidget.h:
- 6:03 PM Changeset in webkit [138689] by
-
- 14 edits in trunk/Source/JavaScriptCore
Objective-C API for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=105889
Reviewed by Geoff Garen.
Fixes for more issues raised by Darin.
- API/JSBlockAdaptor.mm:
(BlockArgument):
(BlockArgumentStruct::BlockArgumentStruct):
(BlockArgumentTypeDelegate::typeStruct):
(BlockResult):
(BlockResultStruct::BlockResultStruct):
(buildBlockSignature):
(-[JSBlockAdaptor initWithBlockSignatureFromProtocol:]):
(-[JSBlockAdaptor blockFromValue:inContext:withException:]):
- fix * position for Objective-C types
- API/JSContext.h:
- fix * position for Objective-C types
- API/JSContext.mm:
(-[JSContext initWithVirtualMachine:]):
(-[JSContext virtualMachine]):
(contextInternalContext):
- fix * position for Objective-C types
(-[JSContext dealloc]):
(-[JSContext protect:]):
(-[JSContext unprotect:]):
- HashMap<JSValueRef, size_t> -> HashCountedSet<JSValueRef>
- API/JSContextInternal.h:
(WeakContextRef):
- fix * position for Objective-C types
- API/JSValue.mm:
(valueToString):
- fix * position for Objective-C types
(isNSBoolean):
- Added helper to check for booleans.
(objectToValueWithoutCopy):
- Added contextRef
- fix * position for Objective-C types
- Remove @YES, @NO literal usage, use isNSBoolean instead
(objectToValue):
- Added contextRef
(+[JSValue valueWithValue:inContext:]):
(-[JSValue initWithValue:inContext:]):
- fix * position for Objective-C types
(createStructHandlerMap):
(handerForStructTag):
- getStructTagHandler -> handerForStructTag
- Split out createStructHandlerMap
- strncmp -> memcmp
- String(type).impl() -> StringImpl::create(type)
(+[JSValue selectorForStructToValue:]):
(+[JSValue selectorForValueToStruct:]):
- getStructTagHandler -> handerForStructTag
(typeToValueInvocationFor):
(valueToTypeInvocationFor):
- fix * position for Objective-C types
- API/JSValueInternal.h:
- fix * position for Objective-C types
- API/JSVirtualMachineInternal.h:
- fix * position for Objective-C types
- API/JSWrapperMap.h:
- fix * position for Objective-C types
- API/JSWrapperMap.mm:
(selectorToPropertyName):
(createObjectWithCustomBrand):
(createRenameMap):
(putNonEnumerable):
(copyMethodsToObject):
(copyPrototypeProperties):
(-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]):
(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap wrapperForObject:]):
(getJSExportProtocol):
- fix * position for Objective-C types
- API/ObjCCallbackFunction.h:
- fix * position for Objective-C types
- API/ObjCCallbackFunction.mm:
(CallbackArgument):
(CallbackArgumentStruct::CallbackArgumentStruct):
- fix * position for Objective-C types
(CallbackArgumentBlockCallback::createAdoptingJSBlockAdaptor):
- Added to make adopt explicit
(CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::CallbackArgumentBlockCallback):
(ArgumentTypeDelegate::typeBlock):
- Call createAdoptingJSBlockAdaptor
(ArgumentTypeDelegate::typeStruct):
(CallbackResult):
(CallbackResultStruct::CallbackResultStruct):
(ResultTypeDelegate::typeStruct):
(ObjCCallbackFunction::ObjCCallbackFunction):
(ObjCCallbackFunction::context):
(objCCallbackFunctionForInvocation):
(objCCallbackFunctionForMethod):
(objCCallbackFunctionForBlock):
- fix * position for Objective-C types
- API/ObjcRuntimeExtras.h:
(protocolImplementsProtocol):
(forEachProtocolImplementingProtocol):
(forEachMethodInProtocol):
(forEachPropertyInProtocol):
- fix * position for Objective-C types
- API/tests/testapi.m:
(-[TestObject testArgumentTypesWithInt:double:boolean:string:number:array:dictionary:]):
(testObjectiveCAPI):
- fix * position for Objective-C types
- 5:29 PM Changeset in webkit [138688] by
-
- 48 edits20 adds in branches/safari-536.28-branch/LayoutTests
Rebaseline Chopin SVG results.
<rdar://problem/12947584> SVG test failures caused by missing merge
Reviewed by Tim Horton.
- platform/mac/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
- platform/mac/svg/carto.net/tabgroup-expected.txt:
- platform/mac/svg/css/shadow-changes-expected.txt:
- platform/mac/svg/custom/SVGPoint-matrixTransform-expected.txt:
- platform/mac/svg/custom/animate-path-morphing-expected.txt:
- platform/mac/svg/custom/circle-move-invalidation-expected.txt:
- platform/mac/svg/custom/clip-path-child-changes-expected.txt: Added.
- platform/mac/svg/custom/clip-path-href-changes-expected.txt: Added.
- platform/mac/svg/custom/clip-path-id-changes-expected.txt: Added.
- platform/mac/svg/custom/clip-path-units-changes-expected.txt: Added.
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
- platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
- platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
- platform/mac/svg/custom/js-late-clipPath-creation-expected.txt:
- platform/mac/svg/custom/js-late-gradient-creation-expected.txt:
- platform/mac/svg/custom/js-late-pattern-creation-expected.txt:
- platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Added.
- platform/mac/svg/custom/js-update-bounce-expected.txt: Added.
- platform/mac/svg/custom/js-update-container-expected.txt: Added.
- platform/mac/svg/custom/js-update-polygon-changes-expected.txt: Added.
- platform/mac/svg/custom/js-update-polygon-removal-expected.txt: Added.
- platform/mac/svg/custom/js-update-style-expected.txt: Added.
- platform/mac/svg/custom/js-update-transform-addition-expected.txt: Added.
- platform/mac/svg/custom/js-update-transform-changes-expected.txt: Added.
- platform/mac/svg/custom/marker-viewBox-changes-expected.txt: Added.
- platform/mac/svg/custom/mask-invalidation-expected.txt: Added.
- platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
- platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
- platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
- platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
- platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
- platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt:
- platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
- platform/mac/svg/custom/relative-sized-inner-svg-expected.txt:
- platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
- platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
- platform/mac/svg/custom/repaint-stroke-width-changes-expected.txt: Added.
- platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
- platform/mac/svg/custom/text-hit-test-expected.txt:
- platform/mac/svg/custom/text-repaint-including-stroke-expected.txt:
- platform/mac/svg/custom/text-xy-updates-SVGList-expected.txt:
- platform/mac/svg/custom/use-modify-container-in-target-expected.txt:
- platform/mac/svg/custom/use-move-to-offset-expected.txt: Added.
- platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
- platform/mac/svg/custom/viewbox-syntax-expected.txt:
- platform/mac/svg/filters/invalidate-on-child-layout-expected.txt: Added.
- platform/mac/svg/hixie/text/003b-expected.txt:
- platform/mac/svg/repaint/repaint-webkit-svg-shadow-expected.txt: Added.
- platform/mac/svg/repaint/repainting-after-animation-element-removal-expected.txt:
- platform/mac/svg/text/remove-text-node-from-tspan-expected.txt:
- platform/mac/svg/text/select-x-list-1-expected.txt:
- platform/mac/svg/text/select-x-list-2-expected.txt:
- platform/mac/svg/text/select-x-list-3-expected.txt:
- platform/mac/svg/text/select-x-list-4-expected.txt:
- platform/mac/svg/text/select-x-list-with-tspans-1-expected.txt:
- platform/mac/svg/text/select-x-list-with-tspans-2-expected.txt:
- platform/mac/svg/text/select-x-list-with-tspans-3-expected.txt:
- platform/mac/svg/text/select-x-list-with-tspans-4-expected.txt:
- platform/mac/svg/text/text-rescale-expected.txt:
- platform/mac/svg/text/text-text-01-b-expected.txt:
- platform/mac/svg/text/tspan-dynamic-positioning-expected.txt:
- platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.txt:
- platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
- 5:21 PM Changeset in webkit [138687] by
-
- 5 edits in trunk/Source/Platform
[chromium] Remove unused transitional #defines from Platform API
https://bugs.webkit.org/show_bug.cgi?id=105971
Patch by James Robinson <jamesr@chromium.org> on 2013-01-02
Reviewed by Adrienne Walker.
These are leftovers from multi-sided patches that landed months ago.
- chromium/public/WebContentLayerClient.h:
(WebContentLayerClient):
- chromium/public/WebLayer.h:
- chromium/public/WebLayerTreeView.h:
- chromium/public/WebThread.h:
- 5:20 PM Changeset in webkit [138686] by
-
- 1 edit5 adds3 deletes in trunk/LayoutTests
Mac and Chromium rebaselines after r138654.
- editing/deleting/delete-to-select-table-expected.txt: Added.
- platform/chromium-mac/editing/deleting/delete-to-select-table-expected.txt: Added.
- platform/chromium/editing/deleting/delete-to-select-table-expected.txt: Removed.
- platform/efl/editing/deleting/delete-to-select-table-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-to-select-table-expected.txt: Removed.
- platform/mac-lion/editing/deleting/delete-to-select-table-expected.txt: Added.
- platform/mac-wk2/editing/deleting: Added.
- platform/mac-wk2/editing/deleting/delete-to-select-table-expected.txt: Added.
- 5:11 PM Changeset in webkit [138685] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed Chromium gardening.
Rebaseline win-xp image for svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.html.
- platform/chromium-win-xp/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
- 5:10 PM Changeset in webkit [138684] by
-
- 2 edits in trunk/Source/WebKit/chromium
Initialize WebInputEvent to prevent sending uninitialized bytes with IPC messages.
https://bugs.webkit.org/show_bug.cgi?id=105934
Reviewed by James Robinson.
- public/WebInputEvent.h:
(WebKit::WebInputEvent::WebInputEvent):
- 5:06 PM Changeset in webkit [138683] by
-
- 14 edits in trunk/Source/WebKit2
Stop pretending its possible to run the WebProcess in threaded mode
https://bugs.webkit.org/show_bug.cgi?id=105969
Reviewed by Alexey Proskuryakov.
- Removes WebProcess::isSeparateProcess()
- Stop storing a RunLoop on the WebProcess and just use RunLoop::main().
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::NetworkProcessConnection):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::PluginProcessConnection):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
- WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::PageOverlay):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::close):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
(WebKit::WebProcess::shouldTerminate):
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didClose):
- WebProcess/WebProcess.h:
(WebProcess):
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
- WebProcess/mac/WebProcessInitialization.mm:
(WebKit::initializeWebProcess):
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
- WebProcess/win/WebProcessMainWin.cpp:
(WebKit::WebProcessMain):
- 5:04 PM Changeset in webkit [138682] by
-
- 2 edits in trunk/Source/WebCore
[V8] V8DOMWrapper.cpp has many more includes than necessary
https://bugs.webkit.org/show_bug.cgi?id=105968
Reviewed by Kentaro Hara.
Now that this file isn't in charge of doing everything under the sun,
it can have a more focused set of include directives.
- bindings/v8/V8DOMWrapper.cpp:
- 5:00 PM Changeset in webkit [138681] by
-
- 4 edits in trunk
[EFL][CMAKE] Remove duplicated conditionals
https://bugs.webkit.org/show_bug.cgi?id=105905
Reviewed by Laszlo Gombos.
.:
- Source/cmake/OptionsEfl.cmake: Remove set(WTF_USE_GLX 1).
Source/WebCore:
Remove conditionals from CMake build system, where the files being built are already wrapped with
the conditionals. It just messes cmake file up.
- PlatformEfl.cmake:
- 4:55 PM Changeset in webkit [138680] by
-
- 4 edits in trunk/Source
AX: Chromium needs platform localized strings for media controls.
https://bugs.webkit.org/show_bug.cgi?id=105940
Patch by David Tseng <dtseng@google.com> on 2013-01-02
Reviewed by Tony Chang.
Source/Platform:
- chromium/public/WebLocalizedString.h:
Source/WebKit/chromium:
- src/LocalizedStrings.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore):
(WebCore::localizedMediaControlElementHelpText):
- 4:53 PM Changeset in webkit [138679] by
-
- 2 edits in trunk/Source/WebCore
Release build fix.
- platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::formFinalize): Use ASSERT_UNUSED for an otherwise unused variable.
- 4:43 PM Changeset in webkit [138678] by
-
- 23 edits in trunk
Unreviewed, rolling out r138661.
http://trac.webkit.org/changeset/138661
https://bugs.webkit.org/show_bug.cgi?id=104740
Compile problems on EFL
.:
- Source/cmake/WebKitMacros.cmake:
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- UseJSC.cmake:
- UseV8.cmake:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- WebCore.vcproj/WebCoreTestSupport.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGenerator.pm:
(IDLFileForInterface):
- page/make_settings.pl:
(generateCode):
(generateHeader):
(printGetterAndSetter):
(printInitializer):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::from):
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::reset):
(WebCore::InternalSettings::setPasswordEchoEnabled):
(WebCore):
(WebCore::InternalSettings::setPasswordEchoDurationInSeconds):
- testing/InternalSettings.h:
(Backup):
(InternalSettings):
- testing/InternalSettings.idl:
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):
- testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):
Tools:
- GNUmakefile.am:
- qmake/mkspecs/features/default_post.prf:
- 4:30 PM Changeset in webkit [138677] by
-
- 23 edits in trunk/Source/WebCore
[V8] There are some extra blank lines after removing INC_STATS
https://bugs.webkit.org/show_bug.cgi?id=105964
Reviewed by Ojan Vafai.
This patch is a followup to http://trac.webkit.org/changeset/138665
that removes some extra blank lines that sed wasn't smart enough to
delete for us.
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertyQuery):
- bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::appendCallback):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):
(WebCore::V8DOMWindow::postMessageCallback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
- bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::V8Geolocation::getCurrentPositionCallback):
(WebCore::V8Geolocation::watchPositionCallback):
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::namedPropertyGetter):
- bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:
(WebCore::V8HTMLFormControlsCollection::namedPropertyGetter):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::namedPropertyGetter):
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::V8MessagePort::postMessageCallback):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::namedPropertyGetter):
- bindings/v8/custom/V8NotificationCustom.cpp:
(WebCore::V8Notification::requestPermissionCallback):
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::V8Storage::namedPropertyQuery):
- bindings/v8/custom/V8StyleSheetListCustom.cpp:
(WebCore::V8StyleSheetList::namedPropertyGetter):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::postMessageCallback):
- 4:26 PM Changeset in webkit [138676] by
-
- 2 edits in trunk/Source/WebCore
[WK2 NetworkProcess] Uploading fails if a client modified the request
https://bugs.webkit.org/show_bug.cgi?id=105965
Reviewed by Brady Eidson.
Associating streams with additional information via a side HashMap does not work,
because the stream we can see is an internal one, with address and other information
not matching a stream that we created.
It's surprising that this design issue was not causing major trouble without NetworkProcess.
- platform/network/cf/FormDataStreamCFNet.cpp: (WebCore): Renamed FormContext to FormCreationContext, because this type only used for creation. Later, we use FormStreamFields as context. (WebCore::closeCurrentStream): Moved a star. (WebCore::formCreate): We no longer have a side map to keep updated. (WebCore::formFinalize): Ditto. (WebCore::formCopyProperty): Added an accessor to get FormData pointer from a stream. (WebCore::setHTTPBody): Ditto. (WebCore::httpBodyFromStream): Use the new property to get FormData pointer.
- 4:25 PM Changeset in webkit [138675] by
-
- 3 edits in trunk/Source/JavaScriptCore
Some renaming in the CodeCache
https://bugs.webkit.org/show_bug.cgi?id=105966
Reviewed by Gavin Barraclough.
CodeBlockKey => SourceCodeKey because the key is not a CodeBlock.
m_recentlyUsedFunctionCode => m_recentlyUsedFunctions to match other names.
GlobalFunctionKey => FunctionKey because the key is not unique to globalness.
m_cachedGlobalFunctions => m_globalFunctions because "cached" is redundant
for data members in an object called "CodeCache".
kMaxRootCodeBlockEntries => kMaxRootEntries because there are no non-CodeBlock
entries in a CodeBlock cache.
kMaxFunctionCodeBlocks => kMaxChildFunctionEntries to clarify that this
number models a parent-child relationship.
Also removed the initial "k" from enum constants. That's an interesting
style for calling out constants, but it's not the WebKit style.
Finally, a behavior change: Use MaxRootEntries for the limit on global
functions, and not MaxChildFunctionEntries. Previously, there was an
unused constant that seemed to have been intended for this purpose.
- runtime/CodeCache.cpp:
(JSC::CodeCache::makeSourceCodeKey):
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::makeFunctionKey):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode):
- runtime/CodeCache.h:
(JSC::CodeCache::clear):
- 4:21 PM Changeset in webkit [138674] by
-
- 17 edits in trunk/Source/WebCore
Clean up dispatchEvent overrides and overloads
https://bugs.webkit.org/show_bug.cgi?id=105959
Reviewed by Adam Barth.
Add OVERRIDE to all dispatchEvent overrides and use "using" instead of
reimplementing EventTarget::dispatchEvent in subclasses where having the
virtual override of dispatchEvent hides the overloads in
the superclass.
No new tests, just refactoring.
- Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
- Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
- Modules/indexeddb/IDBTransaction.h:
(IDBTransaction):
- dom/EventDispatchMediator.h:
(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
- dom/GestureEvent.h:
(GestureEventDispatchMediator):
- dom/KeyboardEvent.h:
(KeyboardEventDispatchMediator):
- dom/MouseEvent.h:
- dom/Node.h:
(Node):
- dom/UIEvent.h:
(FocusInEventDispatchMediator):
(FocusOutEventDispatchMediator):
- dom/WheelEvent.h:
(WheelEventDispatchMediator):
- html/HTMLMediaElement.h:
- html/track/TextTrackCue.cpp:
- html/track/TextTrackCue.h:
(TextTrackCue):
- page/DOMWindow.h:
(DOMWindow):
- svg/SVGElementInstance.h:
(SVGElementInstance):
- 4:08 PM Changeset in webkit [138673] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Add Platform/chromium to include_dirs
https://bugs.webkit.org/show_bug.cgi?id=105955
Reviewed by James Robinson.
Currently the headers in WebKit/chromium/public/Web*.h can not
include headers from the new Platform/chromium/ directory with the
"#include <public/WebFoo.h>" syntax, because the include_dirs for
dependent builds (like Chromium-within-WebKit) do not include the
new Platform/chromium/ directory. This patch adds that capability
without managing to break anything else.
- WebKit.gyp:
- 3:56 PM Changeset in webkit [138672] by
-
- 2 edits1 delete in branches/chromium/1364
Revert 129070
[Chromium] Disable resource load scheduling
https://bugs.webkit.org/show_bug.cgi?id=97131
Reviewed by Nate Chapin.
Source/WebCore:
We'll use Chrome's network stack for scheduling instead.
No new tests.
- loader/ResourceLoadScheduler.cpp:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload):
LayoutTests:
The preload scanner loads resources sooner and these tests are affected.
- platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
- platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Added.
TBR=simonjam@chromium.org
Review URL: https://codereview.chromium.org/11759004
- 3:56 PM Changeset in webkit [138671] by
-
- 4 edits in branches/chromium/1364
Merge 138393
Expose ArrayBufferView constructor on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=105605
Reviewed by Sam Weinig.
Source/WebCore:
Update IDL to track recent spec change exposing ArrayBufferView
constructor on DOMWindow for instanceof checks. There are no
constructors exposed in the Web IDL, however, so calling it via
operator new throws TypeError.
Test (updated): fast/canvas/webgl/array-unit-tests.html
- html/canvas/ArrayBufferView.idl:
Removed OmitConstructor attribute.
- page/DOMWindow.idl:
Exposed ArrayBufferView constructor function attribute.
LayoutTests:
Updated test from Khronos repository.
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
TBR=kbr@google.com
Review URL: https://codereview.chromium.org/11747006
- 3:55 PM Changeset in webkit [138670] by
-
- 5 edits in trunk/Source
IndexedDB: Surface a few more leveldb errors.
https://bugs.webkit.org/show_bug.cgi?id=105670
Reviewed by Tony Chang.
Two calls to old LevelDBTransaction::get slipped through the cracks.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IndexKeyCursorImpl::loadCurrentRow):
(WebCore::IndexCursorImpl::loadCurrentRow):
Make these two functions use safeGet instead of get.
- platform/leveldb/LevelDBTransaction.cpp:
- platform/leveldb/LevelDBTransaction.h: Remove get now that it is unused.
- 3:54 PM Changeset in webkit [138669] by
-
- 11 edits in trunk/Source/JavaScriptCore
DFG inlining machinery should be robust against the inline callee varying while the executable stays the same
https://bugs.webkit.org/show_bug.cgi?id=105953
Reviewed by Mark Hahnenberg.
This institutes the policy that if InlineCallFrame::callee is null, then the callee and scope have already
been stored into the true call frame (i.e. the place where the call frame of the inlined call would have
been) and so any attempt to access the callee or scope should do a load instead of assuming that the value
is constant. This wires the changes through the bytecode parser, the stack scanning logic, and the compiler
optimization phases and backends.
- bytecode/CodeOrigin.cpp:
(JSC::InlineCallFrame::dump):
- bytecode/CodeOrigin.h:
(CodeOrigin):
(InlineCallFrame):
(JSC::InlineCallFrame::isClosureCall):
(JSC::CodeOrigin::stackOffset):
(JSC):
- dfg/DFGAssemblyHelpers.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::get):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::getScope):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGCSEPhase.cpp:
(CSEPhase):
(JSC::DFG::CSEPhase::genericPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::pureCSERequiringSameInlineCallFrame):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallFrame):
- 3:54 PM Changeset in webkit [138668] by
-
- 4 edits2 adds in trunk
When a block's height is determined by min-height/max-height, children with percentage heights are sized incorrectly
https://bugs.webkit.org/show_bug.cgi?id=26559
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-01-02
Reviewed by Tony Chang.
Source/WebCore:
Percentage logical height computation now takes into account the min and max height of the container.
Test: fast/block/min-max-height-percent-height-child.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax): Added. Like constrainLogicalHeightByMinMax,
but constrains the content box instead of the border box.
(WebCore):
(WebCore::RenderBox::computeContentLogicalHeight): Make const so it can be called from the const method
constrainContentBoxLogicalHeightByMinMax.
(WebCore::RenderBox::computePercentageLogicalHeight): Use constrainContentBoxLogicalHeightByMinMax to properly
respect min and max height on the containing box when computing the percentage height.
- rendering/RenderBox.h:
(RenderBox):
LayoutTests:
Add tests to ensure percent heights are correctly determined.
- fast/block/min-max-height-percent-height-child-expected.txt: Added.
- fast/block/min-max-height-percent-height-child.html: Added.
- 3:51 PM Changeset in webkit [138667] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, force InternalSettings.cpp to rebuild to try and fix the Apple Win build.
- testing/InternalSettings.cpp:
- 3:48 PM Changeset in webkit [138666] by
-
- 11 edits in trunk/Source
IndexedDB: Use non-const buffers in put() to avoid copies
https://bugs.webkit.org/show_bug.cgi?id=105572
Reviewed by Adam Barth.
Source/WebCore:
Change the new put() method to allow the implementation to consume
or adopt the vector, to avoid copying.
No new tests as this is an interface change that will be implemented later.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::put):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
Source/WebKit/chromium:
Pass on non-const Vectors to allow buffer adoption rather than copies.
- public/WebIDBDatabase.h:
(WebIDBDatabase):
(WebKit::WebIDBDatabase::put):
- src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::put):
- src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
- src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::put):
- src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
- tests/IDBDatabaseBackendTest.cpp:
- 3:41 PM Changeset in webkit [138665] by
-
- 73 edits in trunk/Source/WebCore
[V8] Remove INC_STATS because it is unused
https://bugs.webkit.org/show_bug.cgi?id=105957
Reviewed by Ojan Vafai.
We haven't been able to compile with INC_STATS turned on in a long
time. This patch just removes this ancient cruft. I generated this
patch using
find . -type f | xargs sed -i '/INC_STATS/d'
and then fixing up V8BindingMacros.h.
- 3:34 PM Changeset in webkit [138664] by
-
- 15 edits in trunk/Source/JavaScriptCore
Objective-C API for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=105889
Reviewed by Geoff Garen.
Fixes for a number of issues raised by Darin.
- API/APIJSValue.h:
- Fix typos in comment
- Add newline before NS_CLASS_AVAILABLE(10_9, NA)
- cls -> expectedClass
- key type for -setObject:forKeyedSubscript: is now NSObject <NSCopying> *
- API/JSBase.h:
- JS_OBJC_API_ENABLED no longer implies OBJC
- API/JSBlockAdaptor.mm:
(BlockArgumentStruct::BlockArgumentStruct):
(BlockArgumentStruct):
- mark virtual functions as virtual, override, and private
- refactor out buffer allocation for struct types
(BlockArgumentTypeDelegate::typeVoid):
(BlockArgumentTypeDelegate::typeBlock):
(BlockArgumentTypeDelegate::typeStruct):
- return nil -> return 0
(BlockResultStruct::BlockResultStruct):
(BlockResultStruct):
- mark virtual functions as virtual, override, and private
- refactor out buffer allocation for struct types
(buildBlockSignature):
- %lu is not an appropriate format specifier for NSInteger
(-[JSBlockAdaptor initWithBlockSignatureFromProtocol:]):
- nil check [super init]
(-[JSBlockAdaptor blockMatchesSignature:]):
(-[JSBlockAdaptor blockFromValue:inContext:withException:]):
- ctx -> contextRef
- API/JSContext.h:
- Fix typos in comment
- Add newline before NS_CLASS_AVAILABLE(10_9, NA)
- key type for -setObject:forKeyedSubscript: is now NSObject <NSCopying> *
- API/JSContext.mm:
(-[JSContext initWithVirtualMachine:]):
- nil check [super init]
(+[JSContext currentArguments]):
- args -> argumentArray
(-[JSContext setObject:forKeyedSubscript:]):
- key type for -setObject:forKeyedSubscript: is now NSObject <NSCopying> *
(-[JSContext dealloc]):
(-[JSContext protect:]):
(-[JSContext unprotect:]):
- m_protected -> m_protectCounts
- API/JSValue.mm:
(-[JSValue toObjectOfClass:]):
- cls -> expectedClass
(-[JSValue toBool]):
(-[JSValue deleteProperty:]):
(-[JSValue hasProperty:]):
(-[JSValue isUndefined]):
(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):
(-[JSValue isObject]):
(-[JSValue isEqualToObject:]):
(-[JSValue isEqualWithTypeCoercionToObject:]):
(-[JSValue isInstanceOf:]):
- removed ? YES : NO
(-[JSValue callWithArguments:]):
(-[JSValue constructWithArguments:]):
(-[JSValue invokeMethod:withArguments:]):
- args -> argumentArray
(+[JSValue valueWithPoint:inContext:]):
(+[JSValue valueWithRange:inContext:]):
(+[JSValue valueWithRect:inContext:]):
(+[JSValue valueWithSize:inContext:]):
- [NSNumber numberWithFloat:] -> @()
(-[JSValue objectForKeyedSubscript:]):
(-[JSValue setObject:forKeyedSubscript:]):
- key type for -setObject:forKeyedSubscript: is now NSObject <NSCopying> *
(JSContainerConvertor):
(JSContainerConvertor::isWorkListEmpty):
(JSContainerConvertor::convert):
(ObjcContainerConvertor):
(ObjcContainerConvertor::isWorkListEmpty):
- remove WTF::
- isWorkListEmpty is const
(objectToValue):
- use fast enumeration
(-[JSValue initWithValue:inContext:]):
- nil check [super init]
(getStructTagHandler):
- m_structHandlers -> structHandlers
- API/JSVirtualMachine.h:
- Add newline before NS_CLASS_AVAILABLE(10_9, NA)
- API/JSVirtualMachine.mm:
(-[JSVirtualMachine init]):
- nil check [super init]
- API/JSWrapperMap.mm:
(selectorToPropertyName):
(copyPrototypeProperties):
- remove WTF::
- use static_cast
(-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]):
(-[JSWrapperMap initWithContext:]):
- nil check [super init]
(-[JSWrapperMap wrapperForObject:]):
(tryUnwrapObjcObject):
- enable ASSERT
(getJSExportProtocol):
(getNSBlockClass):
- remove if check on initializing static
- API/JavaScriptCore.h:
- JS_OBJC_API_ENABLED no longer implies OBJC
- API/ObjCCallbackFunction.mm:
(CallbackArgumentOfClass):
(CallbackArgumentOfClass::~CallbackArgumentOfClass):
(CallbackArgumentStruct::CallbackArgumentStruct):
(CallbackArgumentStruct):
(CallbackArgumentBlockCallback):
- mark virtual functions as virtual, override, and private
- refactor out buffer allocation for struct types
(ArgumentTypeDelegate::typeVoid):
(ArgumentTypeDelegate::typeOfClass):
(ArgumentTypeDelegate::typeStruct):
- return nil -> return 0
(CallbackResultStruct::CallbackResultStruct):
(CallbackResultStruct):
- mark virtual functions as virtual, override, and private
- refactor out buffer allocation for struct types
(ResultTypeDelegate::typeStruct):
- return nil -> return 0
(ObjCCallbackFunction):
- remove WTF::
(objCCallbackFunctionFinalize):
- use static_cast
(objCCallbackFunctionCallAsFunction):
- Fix typos in comment
(createObjCCallbackFunctionClass):
(objCCallbackFunctionClass):
- Split out createObjCCallbackFunctionClass from objCCallbackFunctionClass
(ObjCCallbackFunction::call):
- ctx -> contextRef
(blockSignatureContainsClass):
- Remove tri-state enum.
(skipNumber):
- isdigit -> isASCIIDigit
(objCCallbackFunctionForInvocation):
- clean up & comment blockSignatureContainsClass() usage
(tryUnwrapBlock):
- use static_cast
- API/ObjcRuntimeExtras.h:
(forEachProtocolImplementingProtocol):
(forEachMethodInClass):
(forEachMethodInProtocol):
(forEachPropertyInProtocol):
- Remove WTF::
- Remove if (count) checks
(skipPair):
- NSUInteger -> size_t
(StringRange):
(StringRange::operator const char*):
(StringRange::get):
(StructBuffer):
(StructBuffer::StructBuffer):
(StructBuffer::~StructBuffer):
(StructBuffer::operator void*):
- Added helper for creating an aligned buffer, used by struct conversion invocations.
(parseObjCType):
- *(position++) -> *position++
- API/tests/testapi.c:
- PLATFORM(MAC) -> JS_OBJC_API_ENABLED
- API/tests/testapi.m:
(blockSignatureContainsClass):
- Remove tri-state enum.
(testObjectiveCAPI):
- Added more result type checks.
- 3:32 PM Changeset in webkit [138663] by
-
- 2 edits in trunk/LayoutTests
Add a failing test expectation to a test added by r136697.
The failure is tracked by the bug 105960.
- platform/mac-wk2/TestExpectations:
- 3:23 PM Changeset in webkit [138662] by
-
- 2 edits in trunk/LayoutTests
Add a failing test expectations to a test added by r132411.
The patch updated DumpRenderTree but didn't update WebKitTestRunner.
The failure is tracked by the bug 105958.
- platform/mac-wk2/TestExpectations:
- 3:15 PM Changeset in webkit [138661] by
-
- 23 edits in trunk
Generate internal.settings from Settings.in
https://bugs.webkit.org/show_bug.cgi?id=104740
Reviewed by Adam Barth.
.:
- Source/cmake/WebKitMacros.cmake: Specify additional output files from make_settings.pl.
Source/WebCore:
If the setting is declared in Settings.in and is a basic type, generate a
setter function at internals.settings.
InternalSettingsGenerated.idl is created by make_settings.pl. InternalSettings.idl
inherits from InternalSettingsGenerated.idl so we can override generated functions if
needed or add additional custom setters.
This patch removes 2 password echo methods from InternalSettings.idl since they are
auto generated. There are other methods we could remove, but I'll do that in a followup.
No new tests, existing tests should pass. Specifically, editing/input/password* tests should pass.
- CMakeLists.txt: Add generated cpp file to the testing lib.
- DerivedSources.make: Add generated idl file and specify all the outputs of make_settings.pl
- DerivedSources.pri: Generate idl file before generating bindings and include generated idl
for bindings generation.
- GNUmakefile.am: Specify all the generated files of make_settings.pl. Add generated idl to
list of files to be processed and resulting output to be compiled.
- UseJSC.cmake: Add generated idl file to list of idl files to process.
- UseV8.cmake: Same as UseJSC.cmake.
- WebCore.gyp/WebCore.gyp: Run make_settings.pl earlier so we can run the output through the
bindings generator.
- WebCore.gypi: Add new files.
- WebCore.vcproj/WebCoreTestSupport.vcproj: Add new files.
- WebCore.xcodeproj/project.pbxproj: Add new files.
- bindings/scripts/CodeGenerator.pm:
(IDLFileForInterface): Add current directory to the include path so DerivedSources.make can
find the generated idl file.
- page/make_settings.pl:
(generateCode): Generate InternalSettingsGenerated.{idl,h,cpp}.
(generateSettingsMacrosHeader): Rename since we're generating 2 headers now.
(setterFunctionName): Helper function for naming a setter.
(printGetterAndSetter): Use setterFunctionName.
(enumerateParsedItems): Helper function that visits each parsed item.
(generateInternalSettingsIdlFile): Generate idl file.
(generateInternalSettingsHeaderFile): Generate header file.
(generateInternalSettingsCppFile): Generate C++ file.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Remove password echo members.
(WebCore::InternalSettings::Backup::restoreTo): Remove password echo members.
(InternalSettingsWrapper): We can't use RefCountedSupplemental because we're we're already
RefCounted. Create a wrapper class to wrap the RefCounted InternalSettings for Supplement<>::provideTo,
which uses an OwnPtr.
(WebCore::InternalSettingsWrapper::InternalSettingsWrapper): Wraps an InternalSettings that the Page can own.
(WebCore::InternalSettingsWrapper::~InternalSettingsWrapper): Clear's m_page when the Page goes away.
(WebCore::InternalSettingsWrapper::internalSettings): Unwrap InternalSettings.
(WebCore::InternalSettings::from): Update to use InternalSettingsWrapper.
(WebCore::InternalSettings::InternalSettings): Call base class constructor.
(WebCore::InternalSettings::resetToConsistentState): Renamed from reset() and pass through to base class.
Also remove unnecessary pageScaleFactor reset (done in Internals::resetToConsistentState).
- testing/InternalSettings.h:
(Backup): Remove password echo members.
(WebCore::InternalSettings::create): Create an instance instead of using new.
(WebCore::InternalSettings::hostDestroyed): Clear the page. This is similar to the code that
RefCountedSupplemental has.
- testing/InternalSettings.idl: Extends InternalSettingsGenerated.
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): Rename to resetToConsistentState to be like other code.
- testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): Rename to resetToConsistentState to be like other code.
Remove an unused header.
Tools:
- GNUmakefile.am: Compile new generated files on GTK+.
- qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
with both extra_sources and add_output_to_sources=false will still
compile the files in extra_sources. This makes it possible to compile
InternalSettingsGenerated.cpp and not be confused by
InternalSettingsGenerated.idl.
- 3:15 PM Changeset in webkit [138660] by
-
- 2 edits in trunk/LayoutTests
Add a Mac WebKit2 test expectation for the bug 105954.
- platform/mac-wk2/TestExpectations:
- 3:06 PM Changeset in webkit [138659] by
-
- 2 edits in trunk/LayoutTests
Add a failing test expectation for the bug 105954.
- platform/mac-wk2/TestExpectations:
- 3:06 PM Changeset in webkit [138658] by
-
- 7 edits in trunk/Source/WebCore
HTML preload scanner doesn't need to remember whether we're scanning the body
https://bugs.webkit.org/show_bug.cgi?id=105945
Reviewed by Eric Seidel.
As far as I can tell, no one uses this state.
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::CSSPreloadScanner):
(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):
- html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::PreloadTask::preload):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::processToken):
- html/parser/HTMLPreloadScanner.h:
(HTMLPreloadScanner):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload):
- loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
- 3:03 PM Changeset in webkit [138657] by
-
- 3 edits in trunk/Source/WebCore
Crash in WebCore::Element::cloneElementWithoutChildren.
https://bugs.webkit.org/show_bug.cgi?id=105949
Reviewed by Ryosuke Niwa.
RefPtr |ancestors| vector since its elements can be destroyed from mutation events
fired in CompositeEditCommand::appendNode.
No new tests. The testcase relies on recursive DOM mutations and does not minimize.
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::getAncestorsInsideBlock):
(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
(WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/InsertParagraphSeparatorCommand.h:
(InsertParagraphSeparatorCommand):
- 3:00 PM Changeset in webkit [138656] by
-
- 1 edit2 adds in trunk/Source/WebKit/win
Unreviewed. Build fix after reintroducing r138331.
Attempted to remove WebKit2 from Apple Windows port in r138331 but two vsprops files were missing.
- WebKit.vcproj/WebKitApple.vsprops: Added.
- WebKit.vcproj/WebKitDirectX.vsprops: Added.
- 3:00 PM Changeset in webkit [138655] by
-
- 5 edits2 adds in trunk/Source/WebKit2
Factor out NetworkProcess initialization into its own function in preparation of adding a NetworkProcess service
https://bugs.webkit.org/show_bug.cgi?id=105946
Reviewed by Brady Eidson.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/mac/NetworkProcessInitialization.h: Added.
(NetworkProcessInitializationParameters):
- NetworkProcess/mac/NetworkProcessInitialization.mm: Added.
(WebKit::initializeNetworkProcess):
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::initializeSandbox):
(WebKit::NetworkProcess::platformInitialize):
- NetworkProcess/mac/NetworkProcessMainMac.mm:
(WebKit::NetworkProcessMain):
- WebKit2.xcodeproj/project.pbxproj:
- 2:52 PM Changeset in webkit [138654] by
-
- 8 edits1 move14 adds3 deletes in trunk
Crash in WebCore::InlineBox::deleteLine
https://bugs.webkit.org/show_bug.cgi?id=93448
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-01-02
Reviewed by Eric Seidel.
Source/WebCore:
When we ran off the end of the line while looking for line breaks in an
inline with white-space:nowrap nested in a block with white-space:pre
it was possible for the line break to be set at or before the current
position -- this could result in duplications in the render tree or
infinite looping.
This patch changes the "fixup" logic that runs after we have finished
iterating through elements and text and have potentially found a break
point. In the case of a block setting white-space:pre we would back up
a character in some cases. Not doing so could leave whitespace that
should have been collapsed at the end of an inline.
For example in '<span style="white-space:nowrap">x_</span>_y' if a
break was inserted before 'y' the space after 'x' would still be
rendered (rather than be collapsed with the break).
To avoid this problem we will not take the opportunity to break until
we have finished collapsing whitespace.
Tests: fast/text/whitespace/inline-whitespace-wrapping-1.html
fast/text/whitespace/inline-whitespace-wrapping-2.html
fast/text/whitespace/inline-whitespace-wrapping-3.html
fast/text/whitespace/inline-whitespace-wrapping-4.html
fast/text/whitespace/nowrap-white-space-collapse.html
fast/text/whitespace/pre-block-normal-inline-crash-1.html
fast/text/whitespace/pre-block-normal-inline-crash-2.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Collapse
whitespace before breaking. Avoid setting the break before the current
position.
LayoutTests:
- editing/deleting/delete-block-table-expected.txt:
- editing/execCommand/selectAll-expected.txt: Renamed from LayoutTests/platform/chromium/editing/execCommand/selectAll-expected.txt.
- fast/text/whitespace/inline-whitespace-wrapping-1-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-1.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-2-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-2.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-3-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-3.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-4-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-4.html: Added.
- fast/text/whitespace/nowrap-white-space-collapse-expected.html: Added.
- fast/text/whitespace/nowrap-white-space-collapse.html: Added.
- fast/text/whitespace/pre-block-normal-inline-crash-1-expected.txt: Added.
- fast/text/whitespace/pre-block-normal-inline-crash-1.html: Added.
- fast/text/whitespace/pre-block-normal-inline-crash-2-expected.txt: Added.
- fast/text/whitespace/pre-block-normal-inline-crash-2.html: Added.
- platform/chromium-win/editing/deleting/delete-to-select-table-expected.txt:
- platform/chromium-win/editing/execCommand/print-expected.txt:
- platform/chromium-win/editing/execCommand/selectAll-expected.txt:
- platform/chromium-win/editing/inserting/editable-html-element-expected.txt:
- platform/efl/editing/execCommand/selectAll-expected.txt: Removed.
- platform/gtk/editing/execCommand/selectAll-expected.txt: Removed.
- platform/mac/editing/execCommand/selectAll-expected.txt: Removed.
- 2:45 PM Changeset in webkit [138653] by
-
- 4 edits in trunk/Websites/bugs.webkit.org
REGRESSION: Review tool sometimes doesn't include some comments in preview & posts
https://bugs.webkit.org/show_bug.cgi?id=105252
Reviewed by Tony Chang.
When adding context, the LineContainer for the context line can get removed.
In that case, forEachLine needs to know to keep looping past that line number.
Also, make it so that you can't leave comments on context lines.
- code-review-test.html:
- code-review.js:
- 2:41 PM Changeset in webkit [138652] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Cached frame shouldn't access the page when being destroyed
https://bugs.webkit.org/show_bug.cgi?id=105942
Reviewed by George Staikos.
In order to prevent our FrameLoaderClient from dangling WebPagePrivate object in any case,
this patches clear the m_webPagePrivate pointer when the frame is detached or cached.
RIM PR# 272137.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::isMainFrame):
(WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
(WebCore::FrameLoaderClientBlackBerry::didSaveToPageCache):
(WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
- 2:41 PM Changeset in webkit [138651] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG should not use the InlineCallFrame's callee when it could have used the executable istead
https://bugs.webkit.org/show_bug.cgi?id=105947
Reviewed by Mark Hahnenberg.
We shouldn't use the callee to get the executable when we have the executable already. Not only
does this make the logic more clear, but it also allows for a world where the executable is known
but the callee isn't.
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::strictModeFor):
- 2:34 PM Changeset in webkit [138650] by
-
- 2 edits in trunk/LayoutTests
Add a test expectation for the bug 105952.
- platform/wk2/TestExpectations:
- 2:27 PM Changeset in webkit [138649] by
-
- 10 edits in trunk/Source
Unreviewed, rolling out r138403.
http://trac.webkit.org/changeset/138403
https://bugs.webkit.org/show_bug.cgi?id=105950
Fixing e138331 which was rolled out in r138403 (Requested by
rfong on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-02
Source/WebKit/win:
- WebKit.vcproj/WebKit.sln:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitLibCommon.vsprops:
- WebKit.vcproj/WebKitLibDebug.vsprops:
- WebKit.vcproj/WebKitLibDebugAll.vsprops:
- WebKit.vcproj/WebKitLibProduction.vsprops:
- WebKit.vcproj/WebKitLibRelease.vsprops:
Source/WebKit2:
- win/WebKit2.def.in:
- 2:23 PM Changeset in webkit [138648] by
-
- 2 edits in trunk/LayoutTests
Add a failing test expectation to a test added by r138380 on Mac WK2.
The failure is tracked by the bug 105948.
- platform/mac-wk2/TestExpectations:
- 2:14 PM Changeset in webkit [138647] by
-
- 1 edit in branches/chromium/1364/LayoutTests/platform/chromium/TestExpectations
Merge 138289
[Chromium] Restore WebM EME canPlayType() expectations.
https://bugs.webkit.org/show_bug.cgi?id=105070
Unreviewed TestExpectations revert of r137225.
Patch by David Dorwin <ddorwin@chromium.org> on 2012-12-20
- platform/chromium/TestExpectations:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11748009
- 2:14 PM Changeset in webkit [138646] by
-
- 13 edits in trunk/Source/WebCore
Remove webkitPostMessage
https://bugs.webkit.org/show_bug.cgi?id=105910
Reviewed by Kentaro Hara.
The vendor-prefixed version of postMessage was never widely used.
We've been compiling it out of the Chromium port for a while now and
haven't received any reports of compatibility problems. I've done a
number of web searches for uses of the API and personally contacted a
handful of authors I found using the API, all of whom have now moved to
the identical unprefixed API. We've publicied the prefix removal in a
blog post:
http://blog.chromium.org/2012/11/a-web-developers-guide-to-latest-chrome.html
and discussed it on webkit-dev:
http://lists.macosforge.org/pipermail/webkit-dev/2012-September/022189.html
We've done our diligence, and now we should remove the API from the
remainder of the ports.
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDedicatedWorkerContextCustom.cpp:
- bindings/js/JSMessagePortCustom.cpp:
- bindings/js/JSWorkerCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::postMessageCallback):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::V8MessagePort::postMessageCallback):
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::postMessageCallback):
- dom/MessagePort.idl:
- page/DOMWindow.idl:
- workers/DedicatedWorkerContext.idl:
- workers/Worker.idl:
- 2:11 PM Changeset in webkit [138645] by
-
- 2 edits2 adds in trunk/LayoutTests
X-XSS-Protection report-uri doesn't work with mode=block
https://bugs.webkit.org/show_bug.cgi?id=105907
Reviewed by Adam Barth.
Appears to work as-is, but the test was missing for this case. Checking
for completion is complicated by the frame navigating to about:blank, rather
than the echo-report page, so check it from the parent frame.
- http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt: Added.
- http/tests/security/xssAuditor/report-script-tag-full-block.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
- 2:06 PM Changeset in webkit [138644] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark webaudio/automatic-pull-node.html as Timeout for XP
https://bugs.webkit.org/show_bug.cgi?id=105941
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 2:03 PM Changeset in webkit [138643] by
-
- 4 edits in trunk/LayoutTests
Rebaseline tests after r137798 and update test expectations per bug 105943.
- platform/mac-wk2/TestExpectations:
- platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- 1:33 PM Changeset in webkit [138642] by
-
- 1 edit in branches/chromium/1364/Source/WebKit/chromium/features.gypi
Turn off ENABLE_TEMPLATE_ELEMENT
Review URL: https://codereview.chromium.org/11635022
- 1:28 PM Changeset in webkit [138641] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG inliner should not use the callee's bytecode variable for resolving references to the callee in inlined code
https://bugs.webkit.org/show_bug.cgi?id=105938
Reviewed by Mark Hahnenberg.
This simplifies a bunch of code for referring to the callee. It also ought to simplify how we do
closure call inlining: for inlined closure call frames we will simply require that the callee is
already stashed on the stack in the Callee slot in the inline call frame header.
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):
- 1:19 PM Changeset in webkit [138640] by
-
- 3 edits in trunk/Source/WebCore
Optimize TransformationMatrix::multiply() for x86_64
https://bugs.webkit.org/show_bug.cgi?id=105719
Reviewed by Sam Weinig.
On x86_64, we have access to 16 XMM registers. This can hold 32 double values.
We can use that in two ways to optimize matrix multiplications:
-Keep the source matrix completely in registers. Write the result directly in
the source matrix's memory. This avoids the memcpy at the end of the multiplication
and various memory operations.
-Use SIMD with SSE to perform 2 operations at a time.
The parameter from the second matrix are loaded one by one in XMM registers.
Loading them with SSE then shuffling the values perform worse than loading
one by one.
This is only enabled on 64bits as x86 only has access to 8 XMM registers and
the function should be written differently.
On a i5, TransformationMatrix::multiply() perform about 3 times faster with the change.
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::multiply):
- platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix): Fix an incorrect comment. Unify the comment with the cpp file.
- 1:13 PM Changeset in webkit [138639] by
-
- 2 edits in trunk/Source/WebCore
Clean up the loadXXXStyle() idiom in StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=105903
Reviewed by Darin Adler.
This patch refactors 'loadViewSourceStyle' in order to avoid the
necessity of each call site checking whether the relevant data has
been loaded. The new 'viewSourceStyle' will load the data if required,
and return a pointer which can be used directly.
No new tests, as this refactoring should exhibit no visible change in
behavior.
- css/StyleResolver.cpp:
(WebCore::viewSourceStyle):
Lazily populate the static 'defaultViewSourceStyle' with data. I
haven't removed the outer variable, as it's used directly in
StyleResolver::reportMemoryUsage.
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectFeatures):
Use the new hotness rather than the old, lame method.
- 12:49 PM Changeset in webkit [138638] by
-
- 2 edits in trunk/Source/WebKit2
Yet another Windows build fix attempt. Try exporting more symbols.
- win/WebKit2.def.in:
- 12:48 PM Changeset in webkit [138637] by
-
- 1 edit2 adds in trunk/LayoutTests
View source mode is missing the processing instruction line.
https://bugs.webkit.org/show_bug.cgi?id=15961
Reviewed by Adam Barth.
Add a test for XML documents shown in viewsource mode. The bug
with the missing processing instruction line was fixed long
ago with the HTML5 parser rewrite so this just adds a test.
- fast/frames/viewsource-xml-expected.txt: Added.
- fast/frames/viewsource-xml.html: Added.
- 12:40 PM Changeset in webkit [138636] by
-
- 2 edits in trunk/Source/JavaScriptCore
Another Windows port build fix attempt. Try not exporting this symbol from JSC
since it's also compiled in WebCore.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 12:39 PM Changeset in webkit [138635] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r138464): Safari hangs when opening Privacy preferences
https://bugs.webkit.org/show_bug.cgi?id=105933
Reviewed by Sam Weinig.
Quick and dirty fix - added a special case for main thread. But I'm not sure if
dispatch_sync on main queue is really the best idiom here.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromCarbonResources):
- 12:37 PM Changeset in webkit [138634] by
-
- 8 edits in trunk/Tools
Remove old-run-webkit-tests support from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=105619
Reviewed by Eric Seidel.
This patch removes support for webkitpy parsing the
old-run-webkit-tests results format. There doesn't seem to be any
reason to keep this code around anymore now that most bots have
switched to new-run-webkit-tests.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Builder.fetch_layout_test_results):
- Scripts/webkitpy/common/net/layouttestresults.py:
(path_for_layout_test):
(LayoutTestResults.results_from_string):
(LayoutTestResults):
- Scripts/webkitpy/common/net/layouttestresults_unittest.py:
(LayoutTestResultsTest.test_results_from_string):
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(test_flaky_test_failure):
- Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_missing_layout_test_results):
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._test_patch):
- Scripts/webkitpy/tool/commands/queuestest.py:
(QueuesTest.assert_queue_outputs):
- 12:33 PM Changeset in webkit [138633] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r138627.
http://trac.webkit.org/changeset/138627
https://bugs.webkit.org/show_bug.cgi?id=105935
This patch doesn't fix Windows port build failure (Requested
by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-02
- WebCore.vcproj/WebCore.vcproj:
- 12:31 PM Changeset in webkit [138632] by
-
- 9 edits4 adds in trunk
Transitions and animations do not apply to CSS ::before and ::after pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=92591
Reviewed by Eric Seidel.
.:
Expose Element::pseudoElement for Internals.
- Source/autotools/symbols.filter:
Source/WebCore:
The new DOM based :before and :after pseudo elements support animations
and transitions already, but I had disabled support so we could turn them
on in a separate step. This patch just removes the checks and adds tests.
This also adds two methods to internals to allow pausing animations and
transitions on pseudo elements at predictable locations so the tests
are not flaky.
Tests: fast/css-generated-content/pseudo-animation.html
fast/css-generated-content/pseudo-transition.html
- WebCore.exp.in:
- page/animation/AnimationController.cpp:
(WebCore::AnimationController::updateAnimations):
- testing/Internals.cpp:
(WebCore::Internals::pauseAnimationAtTimeOnPseudoElement):
(WebCore::Internals::pauseTransitionAtTimeOnPseudoElement):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
LayoutTests:
Add tests that check if animations and transitions play for pseudo
:before and :after pseudo elements.
- fast/css-generated-content/pseudo-animation-expected.txt: Added.
- fast/css-generated-content/pseudo-animation.html: Added.
- fast/css-generated-content/pseudo-transition-expected.txt: Added.
- fast/css-generated-content/pseudo-transition.html: Added.
- 12:27 PM Changeset in webkit [138631] by
-
- 14 edits2 copies in trunk
Implement WebIDL-style string constants in WebAudio
https://bugs.webkit.org/show_bug.cgi?id=105058
Reviewed by Kentaro Hara.
Source/WebCore:
See Deprecation Notes for more detail:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#DeprecationNotes
PannerNode, BiquadFilterNode, OscillatorNode constants must support WebIDL-style string constants.
Legacy support in the setters for the old integer values should be supported.
This patch handles the changes for OscillatorNode.
- GNUmakefile.list.am:
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::type):
(WebCore):
(WebCore::OscillatorNode::setType):
- Modules/webaudio/OscillatorNode.h:
- Modules/webaudio/OscillatorNode.idl:
- Target.pri:
- UseJSC.cmake:
- UseV8.cmake:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSOscillatorNodeCustom.cpp: Copied from Source/WebCore/Modules/webaudio/OscillatorNode.idl.
(WebCore):
(WebCore::JSOscillatorNode::setType):
- bindings/v8/custom/V8OscillatorNodeCustom.cpp: Copied from Source/WebCore/Modules/webaudio/OscillatorNode.idl.
(WebCore):
(WebCore::V8OscillatorNode::typeAccessorSetter):
LayoutTests:
- webaudio/oscillator-basic-expected.txt:
- webaudio/oscillator-basic.html:
- webaudio/resources/audio-testing.js:
- 12:18 PM Changeset in webkit [138630] by
-
- 3 edits2 adds in trunk
Regression (r132935): WebKit breaks between <nobr> tags
https://bugs.webkit.org/show_bug.cgi?id=11857
Reviewed by David Hyatt.
Source/WebCore:
The fix for bug 29648 in http://trac.webkit.org/changeset/132935 was too broad - it caused us
to find linebreaks in autowrap containers between non-wrapping elements where there was no
whitespace to allow the break. This reverts the code change in r132935 and ensures we attempt
to move below floats when inside an autowrap container but leaves the treatment of non-wrapping
elements in an autowrap container unaffected.
Test: fast/inline/break-between-nobr.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/inline/break-between-nobr-expected.html: Added.
- fast/inline/break-between-nobr.html: Added.
- 12:16 PM Changeset in webkit [138629] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Use top level field for gesture event source
https://bugs.webkit.org/show_bug.cgi?id=105664
Reviewed by Adam Barth.
Previously, only GestureFlingStart subtypes of WebGestureEvent
had a deviceSource flag. A previous CL added a top-level
deviceSource field for all WebGestureEvent. Now that this field
is populated in Chromium, use it as necessary in the Chromium
WebKit layer.
No new tests: covered by existing tests.
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
- tests/WebCompositorInputHandlerImplTest.cpp:
(WebKit::TEST_F):
- 12:00 PM Changeset in webkit [138628] by
-
- 2 edits in trunk/Source/WTF
WTF.gypi lists Platform.h twice
https://bugs.webkit.org/show_bug.cgi?id=105731
Reviewed by Tony Chang.
Once ought to be enough for everybody.
- WTF.gypi:
- 11:48 AM Changeset in webkit [138627] by
-
- 2 edits in trunk/Source/WebCore
Another Windows port build fix attempt. Don't try to build WTF files in WebCore.
Rubber-stamped by Sam Weinig.
- WebCore.vcproj/WebCore.vcproj:
- 11:28 AM Changeset in webkit [138626] by
-
- 2 edits in trunk/Source/WebKit2
Don't include a header that has been removed in r138413.
- WebProcess/win/WebProcessWin.cpp:
- 11:27 AM Changeset in webkit [138625] by
-
- 4 edits29 adds2 deletes in trunk/LayoutTests
sandboxed iframe attribute parsing layout tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=104848
Reviewed by Adam Barth.
This patch breaks the monolithic sandboxed-iframe-attribute-parsing.html
test into separate tests for each case. The flaky failures were due to
one of the 14 frames loading out of order, which shifted console message
positions around. Breaking them into separate tests should both speed up
the tests, as more can run in parallel, and solve the flake.
- fast/frames/resources/sandboxed-iframe-attribute-test.js: Added.
(fail):
(setStatus):
(allowedCallFromSandbox):
(disallowedCallFromSandbox):
(disallowedFormSubmitted):
(window.onload):
- fast/frames/sandboxed-iframe-attribute-parsing-01-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-01.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-02-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-02.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-03-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-03.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-04-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-04.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-05-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-05.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-06-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-06.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-07-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-07.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-08-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-08.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-09-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-09.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-10-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-10.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-11-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-11.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-12-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-12.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-13-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-13.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-14-expected.txt: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-14.html: Added.
- fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Removed.
- fast/frames/sandboxed-iframe-attribute-parsing.html: Removed.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-arm/TestExpectations:
- 11:15 AM Changeset in webkit [138624] by
-
- 1 edit3 adds in trunk/LayoutTests
Sandboxed iframes should not be granted notification permission of the parent frame unless allow-same-origin is specified
https://bugs.webkit.org/show_bug.cgi?id=36732
Reviewed by Adam Barth.
The behavior was fixed in wkbug.com/79704, but there aren't currently
any tests ensuring that it doesn't regress for sandboxed frames. This
patch adds one.
- fast/notifications/notifications-sandbox-permission-expected.txt: Added.
- fast/notifications/notifications-sandbox-permission.html: Added.
- fast/notifications/resources/notifications-iframe.html: Added.
- 11:10 AM Changeset in webkit [138623] by
-
- 2 edits in trunk/LayoutTests
Update Mac test expectation per bug 105932.
- platform/mac/TestExpectations:
- 9:42 AM Changeset in webkit [138622] by
-
- 9 edits in trunk/Source/WebKit2
[WK2] Rename SetFrameInViewSourceMode to SetMainFrameInViewSourceMode
https://bugs.webkit.org/show_bug.cgi?id=105885
Reviewed by Martin Robinson.
This way we don't depend on a WebFrameProxy and
webkit_web_view_set_view_mode() works even if the main frame proxy
hasn't been created yet.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_set_view_mode): Call
WebPageProxy::setMainFrameInViewSourceMode() directly.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy): Remove
setInViewSourceMode().
- UIProcess/WebFrameProxy.h:
(WebFrameProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setMainFrameInViewSourceMode):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setMainFrameInViewSourceMode):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/WebPage.messages.in:
- 9:10 AM Changeset in webkit [138621] by
-
- 6 edits in trunk/Source/WebKit2
[Qt] Use WebPageGroup to create user scripts instead of Qt-specific function in WebPage
https://bugs.webkit.org/show_bug.cgi?id=105921
Reviewed by Simon Hausmann.
After r131281 the WebPageGroup.h (in UIProcess) exposes a way to add user scripts, so we can
use this directly to implement the user script functionality in Qt. The previous solution was
a Qt-port specific function in WebPage that can be removed now.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::updateUserScripts): Use WebPageGroup functions to manipulate user scripts directly.
- UIProcess/WebPageProxy.h:
(WebPageProxy): Remove now unused function.
- UIProcess/qt/WebPageProxyQt.cpp: Ditto.
- WebProcess/WebPage/WebPage.messages.in: Ditto.
- WebProcess/WebPage/qt/WebPageQt.cpp: Remove now unused function and headers.
- 8:46 AM Changeset in webkit [138620] by
-
- 5 edits in trunk/Source/WebCore
[EFL] [WebGL] Minor cleanup in PlatformContext.
https://bugs.webkit.org/show_bug.cgi?id=105872
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-01-02
Reviewed by Kenneth Rohde Christiansen.
The logic to check for supported extensions is scattered in different classes i.e PlatformContext, eglcontext etc.
This patch cleans up any duplicate code and adds new api in GLPlatformContext to query for supported GL, EGL and GLX extensions.
- PlatformEfl.cmake:
- platform/graphics/opengl/GLPlatformContext.cpp:
(WebCore):
(WebCore::GLPlatformContext::createContext):
(WebCore::GLPlatformContext::supportsGLExtension):
(WebCore::GLPlatformContext::supportsEGLExtension):
(WebCore::GLPlatformContext::supportsGLXExtension):
(WebCore::GLPlatformContext::makeCurrent):
(WebCore::GLPlatformContext::initializeResetStatusExtension):
- platform/graphics/opengl/GLPlatformContext.h:
- platform/graphics/surfaces/egl/EGLContext.cpp:
(WebCore::isRobustnessExtSupported):
(WebCore::EGLOffScreenContext::initialize):
- platform/graphics/surfaces/glx/GLXContext.cpp:
(WebCore::initializeARBExtensions):
(WebCore::GLXOffScreenContext::initialize):
- 8:42 AM Changeset in webkit [138619] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use fatfingers result when checking for misspelled words
https://bugs.webkit.org/show_bug.cgi?id=105923
Reviewed by Yong Li.
PR270866
Currently we are using the raw touch point when checking to see if spell check
is required on a word. When tapping close to a boundary, the raw point can be
placed off but fatfingers moves the point onto the word. This causes the caret
to be placed on a word but no spell check request triggered.
Internally reviewed by Mike Fenton and Tiancheng Jiang
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 7:05 AM Changeset in webkit [138618] by
-
- 11 edits4 adds in trunk
Source/WebKit2: [Qt][WK2] Add experimental API to find text from page
https://bugs.webkit.org/show_bug.cgi?id=96481
Patch by Heikki Paajanen <heikki.paajanen@palm.com> on 2013-01-02
Reviewed by Jocelyn Turcotte.
Expose findString and PageFindClient provided functionality to QtQuick
applications.
- Target.pri:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewExperimental::findText):
(QQuickWebViewPrivate::didFindString):
- UIProcess/API/qt/qquickwebview_p.h:
(WebKit):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- UIProcess/API/qt/tests/qmltests/WebView/tst_findText.qml: Added.
- UIProcess/qt/QtWebPageFindClient.cpp: Added.
(WebKit):
(WebKit::QtWebPageFindClient::QtWebPageFindClient):
(WebKit::QtWebPageFindClient::didFindString):
(WebKit::toQtWebPageFindClient):
(WebKit::QtWebPageFindClient::didFailToFindString):
- UIProcess/qt/QtWebPageFindClient.h: Added.
(WebKit):
(QtWebPageFindClient):
Tools: [Qt][WK2] Add simple UI to find text from page
https://bugs.webkit.org/show_bug.cgi?id=96481
Patch by Heikki Paajanen <heikki.paajanen@palm.com> on 2013-01-02
Reviewed by Jocelyn Turcotte.
Find bar that slides between navigation bar and WebView.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::toggleFind):
- MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
- MiniBrowser/qt/MiniBrowser.qrc:
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
- MiniBrowser/qt/icons/find.png: Added.
- MiniBrowser/qt/qml/BrowserWindow.qml:
- 6:16 AM Changeset in webkit [138617] by
-
- 3 edits in trunk/Tools
Regression(r138603): Caused 2 webkitpy tests to fail
https://bugs.webkit.org/show_bug.cgi?id=105913
Reviewed by Kentaro Hara.
Fix 2 webkitpy tests that started to fail after
r138603.
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest._sheriff_test_data_url): Make sure the
returned test file URL is valid no matter what the
current working directory is.
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help): Add "sheriffs" command to the
list of available commands.
- 4:19 AM Changeset in webkit [138616] by
-
- 4 edits3 deletes in trunk
Unreviewed, rolling out r138601.
http://trac.webkit.org/changeset/138601
https://bugs.webkit.org/show_bug.cgi?id=105917
Also not an optimal solution, needs more discussion.
(Requested by mkwst_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-02
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::finishedParsing):
LayoutTests:
- fast/frames/seamless/resources/span.html: Removed.
- fast/frames/seamless/seamless-contenteditable-not-inherited-expected.txt:
- fast/frames/seamless/seamless-srcdoc-expected.txt: Removed.
- fast/frames/seamless/seamless-srcdoc.html: Removed.
- 4:07 AM Changeset in webkit [138615] by
-
- 14 edits3 deletes in trunk
Unreviewed, rolling out r138611.
http://trac.webkit.org/changeset/138611
https://bugs.webkit.org/show_bug.cgi?id=105916
Not an optimal solution, needs more discussion. (Requested by
mkwst_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-02
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.vcproj/WebCore.vcproj:
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::reportMemoryUsage):
- css/seamless.css: Removed.
LayoutTests:
- fast/frames/seamless/resources/nested-seamless.html:
- fast/frames/seamless/resources/quirks-square.html:
- fast/frames/seamless/resources/two-inline-blocks.html:
- fast/frames/seamless/seamless-body-margin-expected.txt: Removed.
- fast/frames/seamless/seamless-body-margin.html: Removed.
- fast/frames/seamless/seamless-inherited-origin-expected.txt:
- fast/frames/seamless/seamless-inherited-origin.html:
- 3:24 AM Changeset in webkit [138614] by
-
- 2 edits in trunk/Source/WebCore
[AC] Memory leak in GraphicsSurfacePrivate::findFBConfigWithAlpha()
https://bugs.webkit.org/show_bug.cgi?id=105770
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-01-02
Reviewed by Noam Rosenthal.
Free the memory returned by glXGetVisualFromFBConfig() using
XFree to avoid a memory leak.
No new tests. No change in behavior.
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::findFBConfigWithAlpha):
- 2:09 AM Changeset in webkit [138613] by
-
- 2 edits in trunk/Source/WebKit2
Regression(r138607): Causes crashes related to WebIconDatabase
https://bugs.webkit.org/show_bug.cgi?id=105909
Reviewed by Gyuyoung Kim.
Add back WebIconDatabase initialization statement
in WebContext constructor. It was removed in
r138607 and causing a lot of crashes on WebKit2.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
- 1:43 AM Changeset in webkit [138612] by
-
- 2 edits in trunk/Source/JavaScriptCore
One more unreviewed buildfix after r138609.
- jit/JITCall.cpp: Add a missing include.
- 1:17 AM Changeset in webkit [138611] by
-
- 14 edits3 adds in trunk
The 'body' of seamless IFrames should default to 'margin: 0'
https://bugs.webkit.org/show_bug.cgi?id=90834
Reviewed by Eric Seidel.
Source/WebCore:
Documents displayed in seamless iframes should override the 'body'
element's normal 8px default margins with 0px, in order to ensure that
contents are displayed flush with the boundries of the seamless box.[1]
This patch does so by adding a new user agent stylesheet for seamless
documents, and teaching the StyleResolver how and when to apply it.
[1]: http://lists.w3.org/Archives/Public/public-whatwg-archive/2012Jul/0039.html
Test: fast/frames/seamless/seamless-body-margin.html
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.vcproj/WebCore.vcproj:
- CMakeLists.txt:
Added a new CSS file! Let's tell everyone!
- css/StyleResolver.cpp:
(WebCore):
(WebCore::loadSeamlessStyle):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::reportMemoryUsage):
Load the new stylesheet, and apply it to the document in
matchUARules iff the document should be displayed seamlessly.
- css/seamless.css: Added.
(body):
Stylesheet containing defaults for seamless documents.
LayoutTests:
- fast/frames/seamless/seamless-body-margin-expected.txt: Added.
- fast/frames/seamless/seamless-body-margin.html: Added.
New test to explicitly check 'body' margins.
- fast/frames/seamless/resources/nested-seamless.html:
- fast/frames/seamless/resources/quirks-square.html:
- fast/frames/seamless/resources/two-inline-blocks.html:
- fast/frames/seamless/seamless-inherited-origin-expected.txt:
- fast/frames/seamless/seamless-inherited-origin.html:
Updated these tests to remove the assumption that the body had an
8px margin.
- 1:07 AM Changeset in webkit [138610] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed buildfix after r138609.
- jit/JITCall32_64.cpp: Add a missing include.
- 12:48 AM Changeset in webkit [138609] by
-
- 12 edits in trunk/Source/JavaScriptCore
Baseline JIT should have closure call caching
https://bugs.webkit.org/show_bug.cgi?id=105900
Reviewed by Gavin Barraclough.
This is not a speed-up by itself, but is meant to allow the DFG inliner to
accurately discern between closure calls and non-closure calls, so that it can
do closure call inlining in the future.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFromLLInt):
(JSC::CallLinkStatus::computeFor):
- bytecode/CallLinkStatus.h:
(JSC::CallLinkStatus::CallLinkStatus):
(JSC::CallLinkStatus::isClosureCall):
(CallLinkStatus):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
- jit/JIT.cpp:
(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):
- jit/JIT.h:
(JSC::JIT::compileClosureCall):
- jit/JITCall.cpp:
(JSC::JIT::privateCompileClosureCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::privateCompileClosureCall):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- jit/ThunkGenerators.cpp:
(JSC::linkClosureCallGenerator):
- jit/ThunkGenerators.h:
Jan 1, 2013:
- 10:53 PM Changeset in webkit [138608] by
-
- 6 edits in trunk
[WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
https://bugs.webkit.org/show_bug.cgi?id=105897
Reviewed by Alexey Proskuryakov.
Tools:
Dump in WebKitTestRunner the message that is expected by layout tests
when the missing plugin button is clicked.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::unavailablePluginButtonClicked):
(WTR):
- WebKitTestRunner/TestController.h:
(TestController):
LayoutTests:
Unskip plugins/clicking-missing-plugin-fires-delegate.html for
WK2 now that WebKitTestRunner is dumping the expected text when
the missing plugin button is clicked.
- platform/efl-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 8:19 PM Changeset in webkit [138607] by
-
- 28 edits in trunk/Source/WebKit2
Convert more classes to be WebContextSupplements
https://bugs.webkit.org/show_bug.cgi?id=105890
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKContext.cpp:
(WKContextGetCookieManager):
(WKContextGetDatabaseManager):
(WKContextGetGeolocationManager):
(WKContextGetKeyValueStorageManager):
(WKContextGetMediaCacheManager):
(WKContextGetNotificationManager):
(WKContextGetResourceCacheManager):
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::cookieManager):
(EwkContext::clearResourceCache):
- UIProcess/API/efl/ewk_database_manager_private.h:
(EwkDatabaseManager::create):
- UIProcess/API/efl/ewk_storage_manager_private.h:
(EwkStorageManager::create):
- UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):
(webkit_web_context_clear_cache):
(webkit_web_context_get_cookie_manager):
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::supplementName):
(WebKit):
(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):
(WebKit::WebNotificationManagerProxy::initializeProvider):
(WebKit::WebNotificationManagerProxy::contextDestroyed):
(WebKit::WebNotificationManagerProxy::processDidClose):
(WebKit::WebNotificationManagerProxy::refWebContextSupplement):
(WebKit::WebNotificationManagerProxy::derefWebContextSupplement):
(WebKit::WebNotificationManagerProxy::didReceiveMessage):
(WebKit::WebNotificationManagerProxy::providerDidShowNotification):
(WebKit::WebNotificationManagerProxy::providerDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
(WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::removeNetworkProcessProxy):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
- UIProcess/WebContext.h:
(WebKit):
(WebContext):
(WebKit::WebContext::iconDatabase):
- UIProcess/WebContextSupplement.h:
(WebKit):
(WebKit::WebContextSupplement::contextDestroyed):
(WebKit::WebContextSupplement::processDidClose):
(WebContextSupplement):
(WebKit::WebContextSupplement::shouldTerminate):
(WebKit::WebContextSupplement::ref):
(WebKit::WebContextSupplement::deref):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::supplementName):
(WebKit):
(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::initializeClient):
(WebKit::WebCookieManagerProxy::contextDestroyed):
(WebKit::WebCookieManagerProxy::processDidClose):
(WebKit::WebCookieManagerProxy::shouldTerminate):
(WebKit::WebCookieManagerProxy::refWebContextSupplement):
(WebKit::WebCookieManagerProxy::derefWebContextSupplement):
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::supplementName):
(WebKit):
(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy):
(WebKit::WebDatabaseManagerProxy::initializeClient):
(WebKit::WebDatabaseManagerProxy::contextDestroyed):
(WebKit::WebDatabaseManagerProxy::processDidClose):
(WebKit::WebDatabaseManagerProxy::refWebContextSupplement):
(WebKit::WebDatabaseManagerProxy::derefWebContextSupplement):
(WebKit::WebDatabaseManagerProxy::didReceiveMessage):
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::supplementName):
(WebKit):
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::initializeProvider):
(WebKit::WebGeolocationManagerProxy::contextDestroyed):
(WebKit::WebGeolocationManagerProxy::processDidClose):
(WebKit::WebGeolocationManagerProxy::refWebContextSupplement):
(WebKit::WebGeolocationManagerProxy::derefWebContextSupplement):
(WebKit::WebGeolocationManagerProxy::didReceiveMessage):
(WebKit::WebGeolocationManagerProxy::providerDidChangePosition):
(WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):
- UIProcess/WebGeolocationManagerProxy.h:
(WebGeolocationManagerProxy):
- UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::supplementName):
(WebKit):
(WebKit::WebKeyValueStorageManagerProxy::WebKeyValueStorageManagerProxy):
(WebKit::WebKeyValueStorageManagerProxy::contextDestroyed):
(WebKit::WebKeyValueStorageManagerProxy::processDidClose):
(WebKit::WebKeyValueStorageManagerProxy::refWebContextSupplement):
(WebKit::WebKeyValueStorageManagerProxy::derefWebContextSupplement):
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
- UIProcess/WebKeyValueStorageManagerProxy.h:
(WebKeyValueStorageManagerProxy):
- UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::supplementName):
(WebKit):
(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):
(WebKit::WebMediaCacheManagerProxy::contextDestroyed):
(WebKit::WebMediaCacheManagerProxy::processDidClose):
(WebKit::WebMediaCacheManagerProxy::refWebContextSupplement):
(WebKit::WebMediaCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname):
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames):
- UIProcess/WebMediaCacheManagerProxy.h:
(WebMediaCacheManagerProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showNotification):
- UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::supplementName):
(WebKit):
(WebKit::WebResourceCacheManagerProxy::WebResourceCacheManagerProxy):
(WebKit::WebResourceCacheManagerProxy::contextDestroyed):
(WebKit::WebResourceCacheManagerProxy::processDidClose):
(WebKit::WebResourceCacheManagerProxy::refWebContextSupplement):
(WebKit::WebResourceCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebResourceCacheManagerProxy::didReceiveMessage):
(WebKit::WebResourceCacheManagerProxy::getCacheOrigins):
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):
- UIProcess/WebResourceCacheManagerProxy.h:
(WebResourceCacheManagerProxy):
- UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- 8:18 PM Changeset in webkit [138606] by
-
- 16 edits in trunk
<rdar://problem/12942239> Update copyright strings
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- Info.plist:
Source/WebCore:
- Info.plist:
Source/WebKit/mac:
- Info.plist:
Source/WebKit2:
- Info.plist:
- NetworkProcess/Info.plist:
- PluginProcess/Info.plist:
- SharedWorkerProcess/Info.plist:
- WebProcess/Info.plist:
- WebProcessService/Info.plist:
- WebProcessServiceForWebKitDevelopment/Info.plist:
WebKitLibraries:
- win/tools/scripts/COPYRIGHT-END-YEAR:
- 8:14 PM Changeset in webkit [138605] by
-
- 9 edits in trunk
[EFL] Enable MHTML feature
https://bugs.webkit.org/show_bug.cgi?id=105815
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-01-01
Reviewed by Laszlo Gombos.
.:
ENABLE_MHTML is now ON for EFL.
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
Add application/x-mimearchive type to archive mime types.
Add mht and mhtml to extension map.
No new tests. Existing layout tests pass.
- loader/archive/ArchiveFactory.cpp:
(WebCore::archiveMIMETypes):
- platform/efl/MIMETypeRegistryEfl.cpp:
(WebCore):
Source/WebKit2:
Add missing include directory for ENABLE_MHTML.
- CMakeLists.txt:
Tools:
Enable MHTML feature for EFL port by default.
- Scripts/webkitperl/FeatureList.pm:
- 7:51 PM Changeset in webkit [138604] by
-
- 13 edits18 adds in trunk/Source
Objective-C API for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=105889
Reviewed by Filip Pizlo.
For a detailed description of the API implemented here, see:
JSContext.h
APIJSValue.h
JSVirtualMachine.h
JSExport.h
Still to do -
(1) Shoud rename APIJSValue.h -> JSValue.h (but we'll have to rename JSValue.h first).
(2) Numerous FIXMEs, all with separate bugs filed.
- API/APIJSValue.h: Added.
- this Objective-C class is used to reference a JavaScript object.
- API/JSBase.h:
- added JS_OBJC_API_ENABLED macro to control ObjC API support.
- API/JSBlockAdaptor.h: Added.
- this Objective-C class is used in creating a special NSBlock proxying a JavaScript function.
- API/JSBlockAdaptor.mm: Added.
(BlockArgument):
(BlockArgument::~BlockArgument):
(BlockArgumentBoolean):
(BlockArgumentBoolean::get):
(BlockArgumentNumeric):
(BlockArgumentNumeric::get):
(BlockArgumentId):
(BlockArgumentId::get):
(BlockArgumentStruct):
(BlockArgumentStruct::BlockArgumentStruct):
(BlockArgumentStruct::~BlockArgumentStruct):
(BlockArgumentStruct::get):
- decoded arguent type information of a JSBlockAdaptor.
(BlockArgumentTypeDelegate):
(BlockArgumentTypeDelegate::typeInteger):
(BlockArgumentTypeDelegate::typeDouble):
(BlockArgumentTypeDelegate::typeBool):
(BlockArgumentTypeDelegate::typeVoid):
(BlockArgumentTypeDelegate::typeId):
(BlockArgumentTypeDelegate::typeOfClass):
(BlockArgumentTypeDelegate::typeBlock):
(BlockArgumentTypeDelegate::typeStruct):
- delegate for use in conjunction with parseObjCType.
(BlockResult):
(BlockResult::~BlockResult):
(BlockResultVoid):
(BlockResultVoid::set):
(BlockResultInteger):
(BlockResultInteger::set):
(BlockResultDouble):
(BlockResultDouble::set):
(BlockResultBoolean):
(BlockResultBoolean::set):
(BlockResultStruct):
(BlockResultStruct::BlockResultStruct):
(BlockResultStruct::~BlockResultStruct):
(BlockResultStruct::set):
- decoded result type information of a JSBlockAdaptor.
(buildBlockSignature):
- partial step in constructing a signature with stack offset information from one without.
(-[JSBlockAdaptor initWithBlockSignatureFromProtocol:]):
- constructor.
(-[JSBlockAdaptor blockMatchesSignature:]):
- check whether signature strings match, where only one contains stack frame offsets.
(-[JSBlockAdaptor blockFromValue:inContext:withException:]):
- use the adaptor to create a special forwarding block.
- API/JSCallbackObjectFunctions.h:
(JSC::::inherits):
- add missing braces to multiline for statement.
- API/JSContext.h: Added.
- this Objective-C class is used to reference a JavaScript context.
- API/JSContext.mm: Added.
(-[JSContext init]):
- constructor.
(-[JSContext initWithVirtualMachine:]):
- construct in a given VM (JSGlobalData).
(-[JSContext evaluateScript:]):
(-[JSContext globalObject]):
- evaluate a script, global object accessor.
(+[JSContext currentContext]):
(+[JSContext currentThis]):
(+[JSContext currentArguments]):
- These methods obtain context, this, arguments from within a callback.
(-[JSContext virtualMachine]):
- implementation for .virtualMachine property.
(-[JSContext objectForKeyedSubscript:]):
(-[JSContext setObject:forKeyedSubscript:]):
- support for subscript property access.
(contextInternalContext):
- internal accessor to m_context.
(-[JSContext dealloc]):
- desctructor.
(-[JSContext notifyException:]):
(-[JSContext valueFromNotifyException:]):
(-[JSContext boolFromNotifyException:]):
- internal method to record an exception was thrown.
(-[JSContext beginCallbackWithData:thisValue:argumentCount:arguments:]):
(-[JSContext endCallbackWithData:]):
- internal methods to push/pop a callback record.
(-[JSContext protect:]):
(-[JSContext unprotect:]):
- internal methods to add a value to a protect set (used to protect the internal property of JSValue).
(-[JSContext wrapperForObject:]):
- internal method to create a wrapper object.
(WeakContextRef::WeakContextRef):
(WeakContextRef::~WeakContextRef):
(WeakContextRef::get):
(WeakContextRef::set):
- Helper class to implement a weak reference to a JSContext.
- API/JSContextInternal.h: Added.
(CallbackData):
(WeakContextRef):
- see API/JSContext.mm for description of internal methods.
- API/JSExport.h: Added.
- Provides JSExport protocol & JSExportAs macro.
- API/JSValue.mm: Added.
(+[JSValue valueWithObject:inContext:]):
(+[JSValue valueWithBool:inContext:]):
(+[JSValue valueWithDouble:inContext:]):
(+[JSValue valueWithInt32:inContext:]):
(+[JSValue valueWithUInt32:inContext:]):
(+[JSValue valueWithNewObjectInContext:]):
(+[JSValue valueWithNewArrayInContext:]):
(+[JSValue valueWithNewRegularExpressionFromPattern:flags:inContext:]):
(+[JSValue valueWithNewErrorFromMessage:inContext:]):
(+[JSValue valueWithNullInContext:]):
(+[JSValue valueWithUndefinedInContext:]):
- Constructors.
(-[JSValue toObject]):
(-[JSValue toObjectOfClass:]):
(-[JSValue toBool]):
(-[JSValue toDouble]):
(-[JSValue toInt32]):
(-[JSValue toUInt32]):
(-[JSValue toNumber]):
(-[JSValue toString]):
(-[JSValue toDate]):
(-[JSValue toArray]):
(-[JSValue toDictionary]):
- Conversion to Objective-C types.
(-[JSValue valueForProperty:]):
(-[JSValue setValue:forProperty:]):
(-[JSValue deleteProperty:]):
(-[JSValue hasProperty:]):
(-[JSValue defineProperty:descriptor:]):
- Property access by property name.
(-[JSValue valueAtIndex:]):
(-[JSValue setValue:atIndex:]):
- Property access by index.
(-[JSValue isUndefined]):
(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):
(-[JSValue isObject]):
- Test JavaScript type.
(-[JSValue isEqualToObject:]):
(-[JSValue isEqualWithTypeCoercionToObject:]):
(-[JSValue isInstanceOf:]):
- ===, ==, instanceof operators.
(-[JSValue callWithArguments:]):
(-[JSValue constructWithArguments:]):
(-[JSValue invokeMethod:withArguments:]):
- Call & construct.
(-[JSValue context]):
- implementation for .context property.
(-[JSValue toPoint]):
(-[JSValue toRange]):
(-[JSValue toRect]):
(-[JSValue toSize]):
(+[JSValue valueWithPoint:inContext:]):
(+[JSValue valueWithRange:inContext:]):
(+[JSValue valueWithRect:inContext:]):
(+[JSValue valueWithSize:inContext:]):
- Support for NS struct types.
(-[JSValue objectForKeyedSubscript:]):
(-[JSValue objectAtIndexedSubscript:]):
(-[JSValue setObject:forKeyedSubscript:]):
(-[JSValue setObject:atIndexedSubscript:]):
- support for subscript property access.
(isDate):
(isArray):
- internal helper functions to check for instances of JS Date, Array types.
(JSContainerConvertor):
(Task):
(JSContainerConvertor::JSContainerConvertor):
(JSContainerConvertor::isWorkListEmpty):
(JSContainerConvertor::convert):
(JSContainerConvertor::add):
(JSContainerConvertor::take):
- helper class for tracking state while converting to Array/Dictionary objects.
(valueToObjectWithoutCopy):
(containerValueToObject):
(valueToObject):
(valueToNumber):
(valueToString):
(valueToDate):
(valueToArray):
(valueToDictionary):
- function for converting JavaScript values to Objective-C objects.
(ObjcContainerConvertor):
(ObjcContainerConvertor::ObjcContainerConvertor):
(ObjcContainerConvertor::isWorkListEmpty):
(ObjcContainerConvertor::convert):
(ObjcContainerConvertor::add):
(ObjcContainerConvertor::take):
- helper class for tracking state while converting to Array/Dictionary values.
(objectToValueWithoutCopy):
(objectToValue):
(valueInternalValue):
- function for converting Objective-C objects to JavaScript values.
(+[JSValue valueWithValue:inContext:]):
(-[JSValue initWithValue:inContext:]):
- internal constructors.
(StructTagHandler):
(getStructTagHandler):
(+[JSValue selectorForStructToValue:]):
(+[JSValue selectorForValueToStruct:]):
- methods to tracking struct types that support conversion to/from JSValue.
(-[JSValue dealloc]):
- destructor.
(-[JSValue description]):
- Objective-C to-NSString conversion.
(typeToValueInvocationFor):
(valueToTypeInvocationFor):
- create invocation objects for conversion to/from JSValue.
- API/JSValueInternal.h: Added.
- see API/JSValue.mm for description of internal methods.
- API/JSVirtualMachine.h: Added.
- this Objective-C class is used to reference a JavaScript virtual machine (JSGlobalData).
- API/JSVirtualMachine.mm: Added.
(-[JSVirtualMachine init]):
(-[JSVirtualMachine dealloc]):
- constructor & destructor.
(getGroupFromVirtualMachine):
- internal accessor for m_group property.
- API/JSVirtualMachineInternal.h: Added.
- see API/JSVirtualMachine.mm for description of internal methods.
- API/JSWrapperMap.h: Added.
- API/JSWrapperMap.mm: Added.
(wrapperClass):
- singleton root for detction (& unwrapping) of wrapper objects.
(selectorToPropertyName):
- default selector to property name conversion.
(createObjectWithCustomBrand):
- creates a JSObject with a custom NativeBrand (class name).
(createRenameMap):
- parse @optional properties of a JSExport protocol.
(putNonEnumerable):
- property put with enumerable=false.
(copyMethodsToObject):
- iterate methods in a protocol; add functions to a JSObject.
(parsePropertyAttributes):
- examine protocol property metadata.
(makeSetterName):
- "foo" -> "setFoo"
(copyPrototypeProperties):
- create properties on a Protocol object reflecting the instance methods & properties of a protocol.
(-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]):
(-[JSObjCClassInfo dealloc]):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSObjCClassInfo constructor]):
- cache the Protocol/Constructor objects for an Objective-C type.
(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap dealloc]):
- constructor & desctructor.
(-[JSWrapperMap classInfoForClass:]):
- maps Class -> JSObjCClassInfo.
(-[JSWrapperMap wrapperForObject:]):
- cretae or retrieve a cached wrapper value for an object.
(tryUnwrapObjcObject):
- check whether a value is a wrapper object; unwrap if so.
- API/JavaScriptCore.h:
- Added includes for new API headers.
- API/ObjCCallbackFunction.h: Added.
- this class is used to wrap Objective-C instance methods, class methods & blocks as JSFunction objects.
- API/ObjCCallbackFunction.mm: Added.
(CallbackArgument):
(CallbackArgument::~CallbackArgument):
(CallbackArgumentBoolean):
(CallbackArgumentBoolean::set):
(CallbackArgumentInteger):
(CallbackArgumentInteger::set):
(CallbackArgumentDouble):
(CallbackArgumentDouble::set):
(CallbackArgumentJSValue):
(CallbackArgumentJSValue::set):
(CallbackArgumentId):
(CallbackArgumentId::set):
(CallbackArgumentOfClass):
(CallbackArgumentOfClass::CallbackArgumentOfClass):
(CallbackArgumentOfClass::~CallbackArgumentOfClass):
(CallbackArgumentOfClass::set):
(CallbackArgumentNSNumber):
(CallbackArgumentNSNumber::set):
(CallbackArgumentNSString):
(CallbackArgumentNSString::set):
(CallbackArgumentNSDate):
(CallbackArgumentNSDate::set):
(CallbackArgumentNSArray):
(CallbackArgumentNSArray::set):
(CallbackArgumentNSDictionary):
(CallbackArgumentNSDictionary::set):
(CallbackArgumentStruct):
(CallbackArgumentStruct::CallbackArgumentStruct):
(CallbackArgumentStruct::~CallbackArgumentStruct):
(CallbackArgumentStruct::set):
(CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::~CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::set):
- decoded arguent type information of a ObjCCallbackFunction.
(ArgumentTypeDelegate):
(ArgumentTypeDelegate::typeInteger):
(ArgumentTypeDelegate::typeDouble):
(ArgumentTypeDelegate::typeBool):
(ArgumentTypeDelegate::typeVoid):
(ArgumentTypeDelegate::typeId):
(ArgumentTypeDelegate::typeOfClass):
(ArgumentTypeDelegate::typeBlock):
(ArgumentTypeDelegate::typeStruct):
- delegate for use in conjunction with parseObjCType.
(CallbackResult):
(CallbackResult::~CallbackResult):
(CallbackResultVoid):
(CallbackResultVoid::get):
(CallbackResultId):
(CallbackResultId::get):
(CallbackResultNumeric):
(CallbackResultNumeric::get):
(CallbackResultBoolean):
(CallbackResultBoolean::get):
(CallbackResultStruct):
(CallbackResultStruct::CallbackResultStruct):
(CallbackResultStruct::~CallbackResultStruct):
(CallbackResultStruct::get):
- decoded result type information of a ObjCCallbackFunction.
(ResultTypeDelegate):
(ResultTypeDelegate::typeInteger):
(ResultTypeDelegate::typeDouble):
(ResultTypeDelegate::typeBool):
(ResultTypeDelegate::typeVoid):
(ResultTypeDelegate::typeId):
(ResultTypeDelegate::typeOfClass):
(ResultTypeDelegate::typeBlock):
(ResultTypeDelegate::typeStruct):
- delegate for use in conjunction with parseObjCType.
(ObjCCallbackFunction):
(ObjCCallbackFunction::ObjCCallbackFunction):
(ObjCCallbackFunction::~ObjCCallbackFunction):
- constructor & destructor.
(ObjCCallbackFunction::context):
- accessor.
(ObjCCallbackFunction::wrappedBlock):
- attemmpt to unwrap a block object.
(objCCallbackFunctionFinalize):
(objCCallbackFunctionCallAsFunction):
(objCCallbackFunctionClass):
- JSClassRef used to represent ObjCCallbackFunction objects.
(ObjCCallbackFunction::call):
(blockSignatureContainsClass):
- helper function to determine if we're running on a recent Clang.
(skipNumber):
- helper used in parsing signature strings.
(objCCallbackFunctionForInvocation):
(objCCallbackFunctionForMethod):
(objCCallbackFunctionForBlock):
- functions to try to create ObjCCallbackFunction instances for methods/blocks.
(tryUnwrapBlock):
- attemmpt to unwrap a block object.
- API/ObjcRuntimeExtras.h: Added.
(protocolImplementsProtocol):
(forEachProtocolImplementingProtocol):
(forEachMethodInClass):
(forEachMethodInProtocol):
(forEachPropertyInProtocol):
- functions used in reflecting on Objective-C types.
(skipPair):
- parsing helper used by parseObjCType, scans for matching parentheses.
(StringRange):
(StringRange::StringRange):
(StringRange::~StringRange):
(StringRange::operator const char*):
(StringRange::get):
- Helper class - create a c string copy of a range of an existing string.
(parseObjCType):
- function to parse Objective-C type strings, makes callbacks to a deleagte.
- API/tests/testapi.c:
(main):
- added call to testObjectiveCAPI (in testapi.m).
- API/tests/testapi.m: Added.
(+[ParentObject parentTest]):
(+[TestObject testObject]):
(+[TestObject classTest]):
(-[TestObject getString]):
(-[TestObject testArgumentTypesWithInt:double:boolean:string:number:array:dictionary:]):
(-[TestObject callback:]):
(-[TextXYZ test:]):
- test object, used in various test vases.
(checkResult):
- helper function.
(blockSignatureContainsClass):
- helper function to determine if we're running on a recent Clang.
(testObjectiveCAPI):
- new test cases.
- JavaScriptCore.xcodeproj/project.pbxproj:
- added new files.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- added m_apiData - provide convenient storage for use by the API.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
- runtime/JSGlobalObject.h:
(JSGlobalObject):
- added m_apiData - provide convenient storage for use by the API.
../WTF:
- wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
- wtf/WTFThreadData.h:
(WTFThreadData):
- Added m_apiData - provide convenient storage for use by the API.
- 6:54 PM Changeset in webkit [138603] by
-
- 4 edits6 adds in trunk/Tools
sheriff-bot should know who the gardeners/sheriffs are
https://bugs.webkit.org/show_bug.cgi?id=105698
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-01
Reviewed by Eric Seidel.
Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Current):
(Current._retrieve_webkit_sheriffs):
(Current.execute):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_current):
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
- 4:23 PM Changeset in webkit [138602] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK1] Skip some webaudio test cases due to lack of implementation
https://bugs.webkit.org/show_bug.cgi?id=105882
Unreviewed, EFL gardening.
Bunch of webaudio test cases need setAudioData implementation and DRT has not it.
So, skips those cases.
Patch by Kangil Han <kangil.han@samsung.com> on 2013-01-01
- platform/efl-wk1/TestExpectations:
- 9:20 AM Changeset in webkit [138601] by
-
- 4 edits3 adds in trunk
seamless iframes don't inherit styles when srcdoc is used
https://bugs.webkit.org/show_bug.cgi?id=103539
Reviewed by Eric Seidel.
Source/WebCore:
Seamless iframes populated via a 'srcdoc' attribute should always
inherit styles from their parent documents. At the moment, this is
only the case when they contain a stylesheet or some other markup
that forces a style recalculation on the document. Simple 'srcdoc'
attributes (e.g. "srcdoc='<p>This is a comment.</p>'") bail out of
recalculating style early, resulting in unstyled appearance.
This patch instructs WebCore to treat seamless documents as having an
updated StyleResolver regardless of what actions the parser takes,
which in turn ensures that the document's style is recalculated
correctly.
Test: fast/frames/seamless/seamless-srcdoc.html
- dom/Document.cpp:
(WebCore::Document::finishedParsing):
If it's a seamless document, notify it that its StyleResolver isn't
what it might have expected.
LayoutTests:
- fast/frames/seamless/resources/span.html: Added.
- fast/frames/seamless/seamless-contenteditable-not-inherited-expected.txt:
Updating the previously FAILing expectation.
- fast/frames/seamless/seamless-srcdoc-expected.txt: Added.
- fast/frames/seamless/seamless-srcdoc.html: Added.
Exciting new test to ensure that this doesn't regress, neither
for totally simple srcdoc attriubtes, nor for slightly more
complex variations.
- 3:47 AM WebKitGTK/WebKit2Roadmap edited by
- Added web extensions, and updated target versions (diff)
Dec 31, 2012:
- 12:37 PM Changeset in webkit [138600] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Fullscreen Media Time Indicators Background Incorrect
https://bugs.webkit.org/show_bug.cgi?id=105888
Patch by Jeff Rogers <jrogers@rim.com> on 2012-12-31
Reviewed by George Staikos.
Internal PR 272699.
Update fullscreen media controls CSS to fix time container background
color. Also fix transparency to be 80% opaque to and the time
remaining text color to match the system player.
No new tests as there is no functionality change.
- css/mediaControlsBlackBerryFullscreen.css:
(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-display-container):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-timeline-container):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-current-time-display):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-remaining-display):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-button-container, video:-webkit-full-screen::-webkit-media-controls-play-button-container):
(video:-webkit-full-screen::-webkit-media-controls-placeholder):
- 11:53 AM Changeset in webkit [138599] by
-
- 7 edits1 add in trunk/Source/WebKit2
Add supplementability for WebContext
https://bugs.webkit.org/show_bug.cgi?id=105878
Reviewed by Dan Bernstein.
Add WebContextSupplement and convert WebApplicationCacheManagerProxy to it.
- UIProcess/API/C/WKContext.cpp:
(WKContextGetApplicationCacheManager):
- UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::supplementName):
(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::contextDestroyed):
(WebKit::WebApplicationCacheManagerProxy::processDidClose):
(WebKit::WebApplicationCacheManagerProxy::refWebContextSupplement):
(WebKit::WebApplicationCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
- UIProcess/WebContext.h:
(WebKit::WebContext::supplement):
(WebKit::WebContext::addSupplement):
- UIProcess/WebContextSupplement.h: Added.
(WebKit::WebContextSupplement::WebContextSupplement):
(WebKit::WebContextSupplement::~WebContextSupplement):
(WebKit::WebContextSupplement::ref):
(WebKit::WebContextSupplement::deref):
(WebKit::WebContextSupplement::context):
(WebKit::WebContextSupplement::clearContext):
- WebKit2.xcodeproj/project.pbxproj:
- 8:56 AM Changeset in webkit [138598] by
-
- 4 edits in trunk
[EFL][WebGL] Add compile time support for GLES2.
https://bugs.webkit.org/show_bug.cgi?id=105816
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-31
Reviewed by Kenneth Rohde Christiansen.
.:
This patch adds build support for GLES2.
GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
cmake config parameter. GLES2 options is not enabled by default. This patch doesn't
address all the build issues related to GLES2 but only adds the needed support in
OptionsEfl.cmake.
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
This patch adds build support for GLES2.
GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
cmake config parameter. GLES2 options is not enabled by default. This patch doesn't
address all the build issues related to GLES2 but only adds the needed support in
PlatformEfl.cmake.
- PlatformEfl.cmake:
- 8:31 AM Changeset in webkit [138597] by
-
- 2 edits in trunk/Source/WebKit2
[EFL[WK2] Regression(r138574): Should not allocate memory in the fork
https://bugs.webkit.org/show_bug.cgi?id=105868
Reviewed by Kenneth Rohde Christiansen.
Store prefixed executable path in a CString before the fork to
avoid allocating memory in the fork by calling String::utf8().
Allocating memory in the fork may lead to deadlocks due to
FastMalloc and the fork not inheriting the threads.
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
- 8:05 AM Changeset in webkit [138596] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] The HTML5 video fullscreen time indicator on the right cuts clipped when the video is longer than 1 hour
https://bugs.webkit.org/show_bug.cgi?id=105887
Patch by Andy Chen <andchen@rim.com> on 2012-12-31
Reviewed by George Staikos.
The width of the time part was fixed. Remove it.
No new test is required because no functionality change.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
- 5:54 AM Changeset in webkit [138595] by
-
- 4 edits1 move1 add1 delete in trunk
[GTK] Move ImageDiff to the Tools directory root
https://bugs.webkit.org/show_bug.cgi?id=105421
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2012-12-31
Reviewed by Kenneth Rohde Christiansen.
.:
- GNUmakefile.am: Remove the old ImageDiff makefile include.
Tools:
- DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
- GNUmakefile.am:
- ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
- 5:25 AM Changeset in webkit [138594] by
-
- 3 edits in trunk/LayoutTests
[EFL] css3/masking/clip-path-circle-relative-overflow.html needs expected results update after 97217
https://bugs.webkit.org/show_bug.cgi?id=105883
Unreviewed, EFL gardening.
Rebaseline css3/masking/clip-path-circle-relative-overflow.html because BUG 97217 has been resolved.
Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-31
- platform/efl/TestExpectations:
- platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.png:
- 4:50 AM Changeset in webkit [138593] by
-
- 12 edits in trunk/Source/WebKit2
[GTK] Add API to set a WebKitWebView in view source mode to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=99315
Reviewed by Martin Robinson.
Add a generic API to set/get a view mode. For now there are only
two modes, Web and Source, but the API can be extended if we
eventually support other view modes like Printing for example.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewSetProperty): Implement setter for view-mode
property.
(webkitWebViewGetProperty): Implement getter for view-mode
property.
(webkit_web_view_class_init): Add view-source property.
(webkit_web_view_set_view_mode): Public method to set the view
mode.
(webkit_web_view_get_view_mode): Public method to get the view
mode.
- UIProcess/API/gtk/WebKitWebView.h: Add WebKitViewMode enum.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMode):
(beforeAll):
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy): Initialize
m_inViewSourceMode.
(WebKit::WebFrameProxy::setInViewSourceMode): Set
m_inViewSourceMode if it has changed and call
WebPageProxy::setFrameInViewSourceMode() to notify the WebProcess.
- UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::inViewSourceMode): Return whether the
frame is currently in view source mode.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFrameInViewSourceMode): Send a message
to the WebProcess to set the given frame in view source mode or not.
- UIProcess/WebPageProxy.h:
(WebPageProxy): Add setFrameInViewSourceMode().
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setFrameInViewSourceMode): Call
setInViewSourceMode for the main frame.
- WebProcess/WebPage/WebPage.h:
(WebPage): Add setFrameInViewSourceMode().
- WebProcess/WebPage/WebPage.messages.in: Add new message
SetFrameInViewSourceMode.
- 12:57 AM Changeset in webkit [138592] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark editing/spelling/spelling-insert-html.html as flaky
since it sometimes hits an assertion in RenderObject
destructor.
- platform/efl/TestExpectations:
Dec 30, 2012:
- 11:57 PM Changeset in webkit [138591] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark fast/dom/Range/range-extract-contents.html as flaky
since it sometimes hits an assertion in
WebCore::endOfContinuations().
- platform/efl/TestExpectations:
- 11:49 PM Changeset in webkit [138590] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark editing/pasteboard/4806874.html as flaky since
it sometimes hits an assertion in RenderObject
destructor.
- platform/efl/TestExpectations:
- 11:41 PM Changeset in webkit [138589] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/js/global-constructors.html after
TEMPLATE_ELEMENT was enabled for EFL port in r138586.
- platform/efl/fast/js/global-constructors-expected.txt:
- 11:33 PM Changeset in webkit [138588] by
-
- 5 edits2 moves in trunk
[EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.
https://bugs.webkit.org/show_bug.cgi?id=105876
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-30
Reviewed by Kenneth Rohde Christiansen.
This is to sync the naming conventions of our classes in both EGL and GLX implementations.
In our GLX implementation, class responsible for the same functionality is named as GLXConfigSelector.
This patch renames EGLConfigHelper as EGLConfigSelector.
.:
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
- PlatformEfl.cmake:
- platform/graphics/surfaces/egl/EGLConfigSelector.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.cpp.
(WebCore):
(WebCore::SharedEGLDisplay::deref):
(WebCore::SharedEGLDisplay::sharedEGLDisplay):
(WebCore::SharedEGLDisplay::SharedEGLDisplay):
(WebCore::SharedEGLDisplay::cleanup):
(WebCore::SharedEGLDisplay::~SharedEGLDisplay):
(WebCore::EGLConfigSelector::EGLConfigSelector):
(WebCore::EGLConfigSelector::~EGLConfigSelector):
(WebCore::EGLConfigSelector::display):
(WebCore::EGLConfigSelector::pBufferContextConfig):
(WebCore::EGLConfigSelector::surfaceContextConfig):
(WebCore::EGLConfigSelector::nativeVisualId):
(WebCore::EGLConfigSelector::reset):
(WebCore::EGLConfigSelector::createConfig):
- platform/graphics/surfaces/egl/EGLConfigSelector.h: Renamed from Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.h.
(WebCore):
(SharedEGLDisplay):
(WebCore::SharedEGLDisplay::create):
(EGLConfigSelector):
- platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::configuration):
(WebCore::EGLWindowTransportSurface::destroy):
- platform/graphics/surfaces/egl/EGLSurface.h:
(EGLWindowTransportSurface):
- 11:12 PM Changeset in webkit [138587] by
-
- 3 edits in trunk/Tools
Add myself to watchlists for CSP and console logs.
https://bugs.webkit.org/show_bug.cgi?id=105874
Reviewed by Dirk Pranke.
Because I really, really, really need more email.
- Scripts/webkitpy/common/config/committers.py:
Add mkwst+watchlist@chromium.org as a contributor.
- Scripts/webkitpy/common/config/watchlist:
Create watchlist categories for 1) the various mechanisms used to
generate console messages, and 2) CSP usage and files.
- 8:44 PM Changeset in webkit [138586] by
-
- 6 edits in trunk
.: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865
Reviewed by Laszlo Gombos.
- Source/cmake/OptionsEfl.cmake: Add ENABLE_TEMPLATE_ELEMENT macro.
Tools: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865
Reviewed by Laszlo Gombos.
- Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
LayoutTests: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865
Reviewed by Laszlo Gombos.
- platform/efl/TestExpectations: Unskip test cases for template element.
- 1:22 PM Changeset in webkit [138585] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
PrettyDiff.rb fails to render image diffs with Ruby 1.9.3p194
https://bugs.webkit.org/show_bug.cgi?id=104932
Reviewed by Eric Seidel.
Ruby 1.9 added the concept of string encodings, so the use of `match' with binary data
treats it as UTF-8. Forcing the png_bytes string to have the "binary" encoding avoids
this error.
- PrettyPatch/PrettyPatch.rb: Use force_encoding.
- 9:51 AM Changeset in webkit [138584] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Add several webaudio tests to TestExpectations since
they sometimes hit !m_finishedNodes.size() assertion
in AudioContext destructor.
- platform/efl/TestExpectations:
- 9:37 AM Changeset in webkit [138583] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip XSS Auditor test case that has been consistently
passing on EFL port for a while.
- platform/efl/TestExpectations:
- 9:08 AM Changeset in webkit [138582] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip fast/dom/shadow/host-wrapper-reclaimed.html
since it is passing after r137978.
- platform/efl/TestExpectations:
- 9:05 AM Changeset in webkit [138581] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Update expectations for 2 fast/dom test cases so
that they are not reported as unexpected passes.
Those tests are passing because their generated
expectations are wrong.
- platform/efl/TestExpectations:
- 8:57 AM Changeset in webkit [138580] by
-
- 4 edits in trunk
[GStreamer] webaudio/decode-audio-data-basic.html fails
https://bugs.webkit.org/show_bug.cgi?id=105298
Reviewed by Martin Robinson.
Source/WebCore:
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus): Return a null pointer if an
error happened while processing a media file.
LayoutTests:
- platform/efl/TestExpectations: Unflag fixed test.
- 8:55 AM Changeset in webkit [138579] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip text-decoration-style tests passing after
r126054 and r132076.
- platform/efl/TestExpectations:
- 7:55 AM Changeset in webkit [138578] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip cairo-related tests that are now consistently
passing on both WK1 and WK2 EFL.
- platform/efl/TestExpectations:
- 7:45 AM Changeset in webkit [138577] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip several compositing test cases that are passing
consistently on EFL WK2.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 6:57 AM Changeset in webkit [138576] by
-
- 3 edits in trunk/Source/WebCore
Regression(r138545): Makes WebAudio tests crash
https://bugs.webkit.org/show_bug.cgi?id=105869
Reviewed by Philippe Normand.
Stop using smart pointers and adoptGRef() for the
GstBus object and call gst_object_unref() manually.
This fixes assertions hits when calling adoptGRef()
since the GstBus object has a floating reference.
Alternatively, we could keep using smart pointers
and stop calling adoptGRef() so that
gst_object_ref_sink() is called and the floating
flag is cleared but I think it is clearer to do
it manually here.
No new tests, already covered by existing tests.
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::messageCallback):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::decodeAudioForBusCreation):
- 6:52 AM Changeset in webkit [138575] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, unskip a now passing test.
- platform/qt/TestExpectations:
- 3:56 AM Changeset in webkit [138574] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Invalid use of temporary object in ProcessLauncher::launchProcess()
https://bugs.webkit.org/show_bug.cgi?id=105867
Reviewed by Kenneth Rohde Christiansen.
Fix invalid use of temporary object in ProcessLauncher::launchProcess()
for prefixedExecutablePath.
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
- 1:51 AM Changeset in webkit [138573] by
-
- 2 edits in trunk/Tools
Unreviewed GTK gardening of the unit tests.
Skip the TestInspectorServer unit test that's timing out completely.
- Scripts/run-gtk-tests:
(TestRunner):
