Timeline



Feb 21, 2013:

11:51 PM Changeset in webkit [143695] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r143664, r143681): http/tests/security/feed-urls-from-remote.html fails
https://bugs.webkit.org/show_bug.cgi?id=110554

Reviewed by Ryosuke Niwa.

Will fix http/tests/security/feed-urls-from-remote.html for Mac WK1.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):

11:39 PM Changeset in webkit [143694] by alecflett@chromium.org
  • 24 edits in trunk/Source

IndexedDB: Implement SharedBuffer version of put() / onSuccess()
https://bugs.webkit.org/show_bug.cgi?id=110398

Reviewed by Tony Chang.

Source/WebCore:

This avoids all unnecessary data copies within the context of
IndexedDB proper, and removes all references to
SerializedScriptValue from the IndexedDB "backend".

No new tests because this is just a refactor.

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::deserializeIDBValueBuffer): New version of deserializeIDBValue which takes SharedBuffer.

Source/WebKit/chromium:

Proxy new SharedBuffer calls to WebIDBCallbacks through
to the new SharedBuffer-based IDBCallbacks.

  • public/WebIDBCursor.h:
  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onSuccessWithPrefetch):

  • src/IDBCallbacksProxy.h:

(IDBCallbacksProxy):

  • src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::onSuccess):

  • src/WebIDBCallbacksImpl.h:

(WebIDBCallbacksImpl):

  • tests/IDBAbortOnCorruptTest.cpp:

(WebCore::MockIDBCallbacks::onSuccess):
(WebCore::MockIDBCallbacks::onSuccessWithPrefetch):

  • tests/IDBDatabaseBackendTest.cpp:
  • tests/IDBRequestTest.cpp:

(WebKit::TEST_F):

11:18 PM Changeset in webkit [143693] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r143691.
http://trac.webkit.org/changeset/143691
https://bugs.webkit.org/show_bug.cgi?id=110559

Breaks compilation on mac. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore):
(WebCore::RenderLayerCompositor::reasonForCompositing):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

10:39 PM Changeset in webkit [143692] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Remove deep copy of ImageBuffer in tiled SVG backgrounds
https://bugs.webkit.org/show_bug.cgi?id=110549

Reviewed by Dirk Schulze.

SVGImage::drawPatternForContainer creates a temporary ImageBuffer for stamping out tiled
backgrounds. Previously this ImageBuffer was unnecessarily deep-copied! This patch uses a
shallow copy, taking advantage of the fact that the temporary ImageBuffer is never modified.

This patch is covered with existing tests.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawPatternForContainer):

10:33 PM Changeset in webkit [143691] by Antoine Quint
  • 3 edits in trunk/Source/WebCore

Expose a list of all reasons that qualify a RenderLayer to be composited
https://bugs.webkit.org/show_bug.cgi?id=110505

Expose the various reasons that can qualify a RenderLayer to be composited
via a new bitmask returned by the reasonForCompositing() method on
RenderLayerCompositor. This method already existed and was used for logging
purposes, but the previous functionality is now accessed via the
logReasonForCompositing() method.

This will allow the the InspectorLayerTreeAgent to provide this information
to the front-end on a per-layer basis as requested by the front-end.

Reviewed by Simon Fraser.

No new tests.

10:25 PM Changeset in webkit [143690] by tasak@google.com
  • 3 edits
    2 adds in trunk

RenderTable::paintBoxDecorations sometimes draws box-shadow twice.
https://bugs.webkit.org/show_bug.cgi?id=110196

Reviewed by Simon Fraser.

Source/WebCore:

When RenderTable::paintBoxDecorations draws box-shadow, paintBackground
should not draw box-shadow. So we have to provide bleedAvoidance
parameter for RenderBox::paintBackground.

Test: fast/css/table-border-radius-with-box-shadow.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations):
Provide bleedAvoidance, which determineBackgroundBleedAvoidance
returns, for paintBackground.

LayoutTests:

  • fast/css/table-border-radius-with-box-shadow-expected.html: Added.
  • fast/css/table-border-radius-with-box-shadow.html: Added.
10:02 PM Changeset in webkit [143689] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add failing test expectations for bugs 110554 and 110555.

  • platform/mac/TestExpectations:
10:00 PM Changeset in webkit [143688] by g.czajkowski@samsung.com
  • 11 edits in trunk/Source

Allow to retrieve the request data from abstract TextCheckingRequest to be accessible for WK2
https://bugs.webkit.org/show_bug.cgi?id=110208

Reviewed by Hajime Morrita.

Source/WebCore:

The WebCore changes are required to implement asynchronous spell checking in WK2.
The idea of asynchronous spell checking in WK1 is to pass the pointer to the abstract object
to the client who is able to verify the given text and notify the WebCore about results.
WK2 will extract the request data and pass it (with additional information) to the UIProcess.

No new tests, covered by editing/spelling tests.

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):
Extract the request data as it is the member of 'TextCheckingRequest'.

  • editing/SpellChecker.cpp:

(WebCore):
(WebCore::SpellCheckRequest::didCancel):
(WebCore::SpellCheckRequest::setCheckerAndSequence):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::SpellChecker::enqueueRequest):
(WebCore::SpellChecker::didCheck):
(WebCore::SpellChecker::didCheckSucceed):

  • platform/text/TextChecking.h:

(WebCore):
(TextCheckingRequestData):
Introduce a new 'TextCheckingRequestData' class to keep the request data and to
easy extract it from the 'TextCheckingRequest'.

(WebCore::TextCheckingRequestData::TextCheckingRequestData):
(TextCheckingRequest):
(WebCore::TextCheckingRequest::~TextCheckingRequest):

Source/WebKit/blackberry:

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
Extract the request data as it is the member of 'TextCheckingRequest'.

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::requestCheckingOfString):
Extract the request data as it is the member of 'TextCheckingRequest'.

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::didCheckSucceed):
(WebEditorClient::requestCheckingOfString):
Extract the request data as it is the member of 'TextCheckingRequest'.

9:56 PM Changeset in webkit [143687] by beidson@apple.com
  • 4 edits in trunk/Source

Move fastlog2() to WTF/MathExtras.h so it can be used from multiple projects.

Rubberstamped by Geoff Garen.

Source/WebCore:

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::lruListFor): Remove the inline fastlog2 and use WTF::fastlog2.

Source/WTF:

  • wtf/MathExtras.h:

(WTF::fastLog2):

9:15 PM Changeset in webkit [143686] by Dimitri Glazkov
  • 12 edits
    2 adds in trunk/Source/WebCore

Split SelectorChecker's fast-checking logic into its own class.
https://bugs.webkit.org/show_bug.cgi?id=106860

Reviewed by Antti Koivisto.

No functional changes, covered by existing tests.

  • CMakeLists.txt: Added new class to existing build system.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSAllInOne.cpp: Ditto.
  • css/RuleSet.cpp:

(WebCore::RuleData::RuleData): Changed to use SelectorCheckerFastPath.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matches): Ditto.

  • css/SelectorChecker.h:

(SelectorChecker): Move fast path code into SelectorCheckerFastPath.

  • css/SelectorCheckerFastPath.cpp: Added.
  • css/SelectorCheckerFastPath.h: Added.
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::ruleMatches): Changed to use SelectorCheckerFastPath.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::initialize): Ditto.

8:03 PM Changeset in webkit [143685] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

Invalidate outstanding checkpoints for the background input stream and preload scanner
https://bugs.webkit.org/show_bug.cgi?id=110537

Reviewed by Adam Barth.

fast/tokenizer/write-before-load.html caused duplicate didFailSpeculation() calls for the same checkpoint.
One was triggered by processParsedChunkFromBackgroundParser and the other by resumeParsingAfterScriptExecution.
This change ensures that after we send a checkpoint, it is cleared so it won't be sent again until the next
processParsedChunkFromBackgroundParser().

No new tests because no new functionality.

  • html/parser/BackgroundHTMLInputStream.cpp:

(WebCore::BackgroundHTMLInputStream::rewindTo):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didFailSpeculation):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::rewindTo):

7:19 PM Changeset in webkit [143684] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Followup commit for https://bugs.webkit.org/show_bug.cgi?id=110541
from a comment by Jon Lee.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Logic
in conditional was unnecessarily complex.

7:12 PM Changeset in webkit [143683] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

Clean up computePreferredLogicalWidths functions in TableLayout subclasses
https://bugs.webkit.org/show_bug.cgi?id=110515

Reviewed by Tony Chang.

No change in behavior. This is just a cleanup in preparation for other
refactoring to this code.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
Move a FIXME here from computePreferredLogicalWidths. It makes more sense here.
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
-Remove outdated or unhelpful comments.
-Isolate the fixed width codepath to make it a bit less convoluted.
(WebCore::FixedTableLayout::layout):

  • rendering/FixedTableLayout.h:

The argument to calcWidthArray is never used. Remove it.

7:01 PM Changeset in webkit [143682] by aestes@apple.com
  • 2 edits in trunk/Source/WTF

TriState.h should be a Project header
https://bugs.webkit.org/show_bug.cgi?id=110543

Rubber-stamped by Dan Bernstein.

WTF uses a script to copy headers to the build destination, so it isn't
necessary to mark headers as Private/Public (and doing so can be problematic).

  • WTF.xcodeproj/project.pbxproj: Mark TriState.h as a Project header.
6:54 PM Changeset in webkit [143681] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

LayoutTests/fast/encoding/parser-tests-*.html timeout with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109995

Unreviewed speculative fix for Mac WK1.

It appears that m_frame can be null for Mac WK1.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):

6:48 PM Changeset in webkit [143680] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Better sizing model for Snapshotted plugins
https://bugs.webkit.org/show_bug.cgi?id=110541

Reviewed by Simon Fraser.

Clarify the way we apply sizing rules to snapshotted plug-ins. In
testing we've found that plug-ins smaller than 40px in either
dimension should never be frozen. Also, larger plugins should
be explicitly marked, because often they are the single dominant
element on the page.

As a drive-by, I removed the flag that indicated whether or not
the label should show automatically. It wasn't being used. This is
all determined from the shadow root and its CSS now.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New values for size thresholds.
(WebCore::HTMLPlugInImageElement::createRenderer): Remove call to setShouldShowSnapshotLabelAutomatically.
(WebCore::classNameForShadowRoot): Remove logging and clearly assign sizing classes.
(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): We don't need the page size any more.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Use new constant names.

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): Remove setShouldShowSnapshotLabelAutomatically.

6:48 PM Changeset in webkit [143679] by jberlin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix a typo that broke the 32 bit build.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

6:29 PM Changeset in webkit [143678] by benjamin@webkit.org
  • 6 edits
    2 deletes in trunk/LayoutTests

Add support for testing states changing asynchronously. Apply it to state-url-sets-links-visited.html.
https://bugs.webkit.org/show_bug.cgi?id=109883

Reviewed by Antti Koivisto.

Some tests depends on state change happening asynchronously. This is typically solved by using
timers with a long enough interval.

Timers have the general pitfalls of causing unreliable tests, and forcing unnecessary delays
in the tests.

This patch introduces new testing helpers, shouldBecomeEqual and shouldBecomeEqualToString, to
test a change of state repetively until it succeed (or timeout). Those test functions execute
the condition every 5ms until the test succeed.

The helper shouldBecomeEqualToString is applied on state-url-sets-links-visited.html to illustrate
the concept.

  • fast/js/resources/js-test-pre.js:

(_waitForCondition): Generic helper function for the familly shouldBecomeXXX.
(.condition):
(.failureHandler):
(shouldBecomeEqual):
(shouldBecomeEqualToString):

  • fast/loader/stateobjects/state-url-sets-links-visited.html:
  • platform/wk2/TestExpectations:

state-url-sets-links-visited.html fails on WebKit2 because the visited links table is updated
asynchronously, and the style is only updated after 1 IPC message + 1 timer + 1 IPC message.

The test is changed to use shouldBecomeEqualToString in order to become reliable. If the UIProcess
does not update the style in a reasonable amount of time, the test fails.

6:10 PM Changeset in webkit [143677] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

25-30% regression in V8 RayTrace test in 32 bit builds with JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=110539

Reviewed by Filip Pizlo.

Change the scale used to lookup pointers in JSGlobalObject::m_specialPointers to be 4 bytes for
the 32 bit version of the interpreter.

  • llint/LowLevelInterpreter32_64.asm:
5:43 PM Changeset in webkit [143676] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the build after r143664.

Unreviewed.

  • WebCore.exp.in:
5:42 PM Changeset in webkit [143675] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

QuickTime plugin doesn't load when accelerated compositing is disabled
https://bugs.webkit.org/show_bug.cgi?id=110534

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-21
Reviewed by Anders Carlsson.

We shouldn't disable accelerated compositing for plugins, because
plugins such as QuickTime rely on this and will try to set other drawing
models that we don't support.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::isAcceleratedCompositingEnabled):

5:40 PM Changeset in webkit [143674] by pilgrim@chromium.org
  • 3 edits
    1 delete in trunk/Source/WebKit/chromium

[Chromium] Remove chromium/public/platform directory
https://bugs.webkit.org/show_bug.cgi?id=110471

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 82948.

  • WebKit.gyp:
  • public/platform: Removed.
  • public/platform/WebKitPlatformSupport.h: Removed.
  • public/platform/android: Removed.
  • public/platform/default: Removed.
  • public/platform/linux: Removed.
  • public/platform/mac: Removed.
  • public/platform/win: Removed.
  • src/WebKit.cpp:
5:27 PM Changeset in webkit [143673] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

tables/mozilla/bugs/bug8950.html fails with threaded parser due to attribute duplication
https://bugs.webkit.org/show_bug.cgi?id=110532

Reviewed by Adam Barth.

This is a very basic failure which we should have caught earlier with the html5lib parser
tests, except those use document.write and thus avoid the threaded parser.

AtomicHTMLToken expects its attributes to be unique. We were not doing that for the
CompactHTMLToken path, and this ancient mozilla table test caught that.

Fixes tables/mozilla/bugs/bug8950.html.

  • html/parser/AtomicHTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):

5:26 PM Changeset in webkit [143672] by dpranke@chromium.org
  • 4 edits in trunk

[chromium] support the lucid version of freetype on precise in DRT
https://bugs.webkit.org/show_bug.cgi?id=107338

Reviewed by Tony Chang.

Source/WebKit/chromium:

Add in a linux-only dependency on Freetype2 so that we can
match the version shipped in Ubuntu Lucid.

  • DEPS:

Tools:

Modify the DRT build so that we can optionally link against
a fixed version of Freetype2. This allows us to share pixel test
results across multiple versions of Ubuntu without having to
worry about differences in font rendering.

At the moment this feature is off by default. Eventually it will
be on by default on linux.

Note that this only affects DRT; the regular Chromium binary
(and, for now, content_shell) will still use the system version
of Freetype.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
5:13 PM Changeset in webkit [143671] by roger_fong@apple.com
  • 4 edits in trunk/Source

Unreviewed. Add executable property to cmd file.
Required for executable files to maintain their executable permissions over svn.

  • JavaScriptCore.vcxproj/copy-files.cmd: Added property svn:executable.
  • WTF.vcxproj/copy-files.cmd: Added property svn:executable.
5:13 PM Changeset in webkit [143670] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

Threaded HTML Parser fails fast/dom/Document/readystate.html
https://bugs.webkit.org/show_bug.cgi?id=110529

Reviewed by Eric Seidel.

Source/WebCore:

We need to create the tokenizer even when we finish a script-created
parser. Most of the time, the tokenizer has already been created at
this point because it is created by calls to document.write.

Test: fast/parser/body-should-exist-after-open-close.html

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::finish):

LayoutTests:

This test is a reduction of the original issue.

  • fast/parser/body-should-exist-after-open-close-expected.txt: Added.
  • fast/parser/body-should-exist-after-open-close.html: Added.
5:11 PM Changeset in webkit [143669] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Lots of LayoutUnit assertions when loading a Wikipedia article
https://bugs.webkit.org/show_bug.cgi?id=110270

Reviewed by Levi Weintraub.

Change RenderBlock::adjustRectForColumns to ensure that the
endColumn calculation does not overflow.

No new tests, covered by existing tests.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustRectForColumns):
Make the endOffset value be no less than the beforeBorderPadding
value to ensure that endColumn is not negative.

4:56 PM Changeset in webkit [143668] by commit-queue@webkit.org
  • 7 edits in trunk

Tools: [Chromium] Remove the word "cheher" from the list of misspelled words
https://bugs.webkit.org/show_bug.cgi?id=110447

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-21
Reviewed by Tony Chang.

Other platforms do not mark "cheher" as a misspelled word in layout tests.
This change is to bring Chromium platform in line with the rest of the
platforms.

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
(WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
(WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.

LayoutTests: Fix editing/spelling/spelling-changed-text.html on Qt and GTK
https://bugs.webkit.org/show_bug.cgi?id=110447

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-21
Reviewed by Tony Chang.

After r143470 editing/spelling/spelling-changed-text.html fails on Qt and GTK,
because Qt and Gtk spelling tests do not mark "cheher" as a misspelling. This
patch changes the test to use the misspelling "wellcome" instead.

  • editing/spelling/spelling-changed-text-expected.txt: Changed "cheher" to "wellcome".
  • editing/spelling/spelling-changed-text.html: Changed "cheher" to "wellcome".
  • platform/gtk/TestExpectations: Enabled editing/spelling/spelling-changed-text.html test.
  • platform/qt/TestExpectations: Enabled editing/spelling/spelling-changed-text.html test.
4:55 PM Changeset in webkit [143667] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Object allocation profiling will refuse to create objects with more than JSFinalObject::maxInlineCapacity() inline slots, but JSFunction::allocationProfile() asserts that the number of inline slots is always what it asked for
https://bugs.webkit.org/show_bug.cgi?id=110519
<rdar://problem/13218566>

Reviewed by Geoffrey Garen.

  • runtime/JSFunction.h:

(JSC::JSFunction::allocationProfile):

4:55 PM Changeset in webkit [143666] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r183905. Requested by
"Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

  • DEPS:
4:48 PM Changeset in webkit [143665] by alecflett@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Remove copying WebIDBDatabase::put() stub
https://bugs.webkit.org/show_bug.cgi?id=109967

Reviewed by Darin Fisher.

Now that the chromium call to this method has
been removed, we can remove the stub.

  • public/WebIDBDatabase.h:
4:39 PM Changeset in webkit [143664] by eric@webkit.org
  • 6 edits in trunk

LayoutTests/fast/encoding/parser-tests-*.html timeout with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109995

Reviewed by Adam Barth.

Source/WebCore:

In the case where during main document onload, we
load a new iframe, and then from within that iframe
we run script to remove the iframe and call testRunner.notifyDone()
the notifyDone() will not correctly dump because
the testRunner does not yet realize that the main resource
has completed loading.

In the main-thread parser, the testRunner does correctly know
that the main thread has completed, because removing the iframe
causes a didFailLoad callback to the embedder, because when
the iframe is being removed, the DocumentLoader for that iframe
is still on the stack and believe's its loading
(because it has a MainResourceLoader which is also on the stack
delivering us the bytes which contain this inline script).

In the threaded-parser case, the DocumentLoader and MainResourceLoader
are no longer on the stack, as we are parsing the iframe asynchronously
after all the bytes have been delivered, and the MainResourceLoader destroyed.
Thus when DocumentLoader::stopLoading() is called, loading() returns
false, and it returns early. One might argue that we should remove that
early return entirely, but it seemed safer to extend the idea of
when we're loading to include the time when the parser is active.

This patch solves this by teaching the DocumentLoader that it is still
"loading" so long as the parser is still active.

Also added a call to DocumentLoader::checkLoadComplete from
Document::decrementActiveParserCount which seemed to cause
http/tests/multipart/policy-ignore-crash.php to pass.

This causes http/tests/security/feed-urls-from-remote.html to timeout
on chromium (but no other platforms that I'm aware of). I believe this
is due to a bug in our DRT implementation in the policyDelegate case
(which AFAIK is not a codepath which Chromium actually uses in the wild).
The test already times out on TOT if you remove the setCustomPolicyDelegate calls!

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):
(WebCore):

  • loader/DocumentLoader.h:

(DocumentLoader):

LayoutTests:

Mark http/tests/security/feed-urls-from-remote.html as timeout on chromium.
I believe this is due to a bug in our DRT implementation in the policyDelegate case
(which AFAIK is not a codepath which Chromium actually uses in the wild).
The test already times out on TOT if you remove the setCustomPolicyDelegate calls.

  • platform/chromium/TestExpectations:
4:27 PM Changeset in webkit [143663] by arv@chromium.org
  • 6 edits
    2 adds in trunk

Nodes should not have attributes property
https://bugs.webkit.org/show_bug.cgi?id=110510

Reviewed by Adam Barth.

Source/WebCore:

According to http://dom.spec.whatwg.org/ attributes and hasAttributes
should be defined on Element and not on Node.

Test: fast/dom/Text/text-should-not-have-attributes.html

  • dom/Element.idl:
  • dom/Node.idl:

LayoutTests:

  • fast/dom/Node/initial-values-expected.txt:
  • fast/dom/Node/script-tests/initial-values.js:
  • fast/dom/Text/text-should-not-have-attributes-expected.txt: Added.
  • fast/dom/Text/text-should-not-have-attributes.html: Added.
4:26 PM Changeset in webkit [143662] by roger_fong@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in

Unreviewed. Tab to spaces style fix.

4:21 PM Changeset in webkit [143661] by tonyg@chromium.org
  • 7 edits in trunk/Source/WebCore

Make BackgroundHTMLParser rewind the preload scanner instead of clear it
https://bugs.webkit.org/show_bug.cgi?id=110517

Reviewed by Adam Barth.

No new tests becuase no new functionality.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):

  • html/parser/BackgroundHTMLParser.h:

(Checkpoint):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didFailSpeculation):

  • html/parser/HTMLDocumentParser.h:

(ParsedChunk):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::createCheckpoint):
(WebCore):
(WebCore::TokenPreloadScanner::rewindTo):

  • html/parser/HTMLPreloadScanner.h:

(WebCore):
(TokenPreloadScanner):
(WebCore::TokenPreloadScanner::Checkpoint::Checkpoint):
(Checkpoint):

4:19 PM Changeset in webkit [143660] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for VS2010 WebKit solution.

  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
4:07 PM Changeset in webkit [143659] by alokp@chromium.org
  • 4 edits in trunk/LayoutTests

Suppressed failing tests after r143626.
These tests need to be rebaselined.

Unreviewed gardening of TestExpectations.

  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
3:50 PM Changeset in webkit [143658] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Unreviewed, rolling out r143536.
http://trac.webkit.org/changeset/143536
https://bugs.webkit.org/show_bug.cgi?id=110523

Causing a bunch of tests to fail on Windows, requires
rebaselining (Requested by rfong on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

Source/WebCore:

  • config.h:
  • page/Settings.cpp:

(WebCore):
(WebCore::Settings::setShouldPaintNativeControls):

  • page/Settings.h:

(Settings):
(WebCore::Settings::shouldPaintNativeControls):

  • platform/win/ScrollbarThemeWin.cpp:

(WebCore):

  • rendering/RenderThemeWin.cpp:

(WebCore):

Source/WebKit/win:

  • WebKitClassFactory.cpp:

(WebKitClassFactory::WebKitClassFactory):

  • WebView.cpp:

(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):

3:36 PM Changeset in webkit [143657] by Lucas Forschler
  • 18 edits
    6 copies
    18 deletes in tags/Safari-537.31.6/Source/WebKit2

Merged r142806. <rdar://problem/13236883>

3:29 PM Changeset in webkit [143656] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Don't make an overhang shadow layer when the WKView has a transparent background
https://bugs.webkit.org/show_bug.cgi?id=110429

Reviewed by Anders Carlsson.

When in coordinated scrolling mode, RenderLayerCompositor makes a layer to show
the shadow around the content when rubber-banding. However, if the view is
transparent, we don't want to make this layer, since it darkens the entire view.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateRootLayerConfiguration): Code was moved
into viewHasTransparentBackground(), so just call that here.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresContentShadowLayer): Don't make
a shadow layer when the view is transparent.
(WebCore::RenderLayerCompositor::viewHasTransparentBackground): Return
true if the view is transparent or has a non-opaque background color,
and optionally return that color.

  • rendering/RenderLayerCompositor.h:
3:29 PM Changeset in webkit [143655] by Simon Fraser
  • 3 edits
    2 adds in trunk

[Safari] Crash with opacity + drop shadow filter + child element extending beyond filter outsets
https://bugs.webkit.org/show_bug.cgi?id=107467

Source/WebCore:

Reviewed by Dean Jackson.

The filter code plays games with the current GraphicsContext, replacing the current
context with one which will get filtered.

This doesn't play nicely with the RenderLayer code which lazily starts transparency
layers. If we don't start a transparency layer until painting a child of the filtered
layer, then the transparency layer is started using the wrong context.

Fix by eagerly starting transparency layers if we have both a filter and opacity.

Test: css3/filters/filter-with-opacity-and-children.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

LayoutTests:

Reviewed by Dean Jackson.

Testcase with filtered element with opacity, and layer child.

  • css3/filters/filter-with-opacity-and-children-expected.txt: Added.
  • css3/filters/filter-with-opacity-and-children.html: Added.
2:59 PM Changeset in webkit [143654] by fpizlo@apple.com
  • 31 edits
    2 adds in trunk/Source/JavaScriptCore

DFG should not change its mind about what type speculations a node does, by encoding the checks in the NodeType, UseKind, and ArrayMode
https://bugs.webkit.org/show_bug.cgi?id=109371

Reviewed by Oliver Hunt.

FixupPhase now locks in the speculations that each node will do. The DFG then
remembers those speculations, and doesn't change its mind about them even if the
graph is transformed - for example if a node's child is repointed to a different
node as part of CSE, CFG simplification, or folding. Each node ensures that it
executes the speculations promised by its edges. This is true even for Phantom
nodes.

This still leaves some craziness on the table for future work, like the
elimination of speculating SetLocal's due to CFG simplification
(webkit.org/b/109388) and elimination of nodes via DCE (webkit.org/b/109389).

In all, this allows for a huge simplification of the DFG. Instead of having to
execute the right speculation heuristic each time you want to decide what a node
does (for example Node::shouldSpeculateInteger(child1, child2) &&
node->canSpeculateInteger()), you just ask for the use kinds of its children
(typically node->binaryUseKind() == Int32Use). Because the use kinds are
discrete, you can often just switch over them. This makes many parts of the code
more clear than they were before.

Having UseKinds describe the speculations being performed also makes it far
easier to perform analyses that need to know what speculations are done. This is
so far only used to simplify large parts of the CFA.

To have a larger vocabulary of UseKinds, this also changes the node allocator to
be able to round up Node sizes to the nearest multiple of 16.

This appears to be neutral on benchmarks, except for some goofy speed-ups, like
8% on Octane/box2d.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::startExecuting):
(DFG):
(JSC::DFG::AbstractState::executeEdges):
(JSC::DFG::AbstractState::verifyEdge):
(JSC::DFG::AbstractState::verifyEdges):
(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::execute):

  • dfg/DFGAbstractState.h:

(AbstractState):
(JSC::DFG::AbstractState::filterEdgeByUse):
(JSC::DFG::AbstractState::filterByType):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::filter):

  • dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::AdjacencyList):
(JSC::DFG::AdjacencyList::child):
(JSC::DFG::AdjacencyList::setChild):
(JSC::DFG::AdjacencyList::reset):
(JSC::DFG::AdjacencyList::firstChild):
(JSC::DFG::AdjacencyList::setFirstChild):
(JSC::DFG::AdjacencyList::numChildren):
(JSC::DFG::AdjacencyList::setNumChildren):
(AdjacencyList):

  • dfg/DFGAllocator.h:

(DFG):
(Allocator):
(JSC::DFG::Allocator::cellSize):
(JSC::DFG::Allocator::Region::headerSize):
(JSC::DFG::Allocator::Region::numberOfThingsPerRegion):
(JSC::DFG::Allocator::Region::payloadSize):
(JSC::DFG::Allocator::Region::payloadBegin):
(JSC::DFG::Allocator::Region::payloadEnd):
(JSC::DFG::Allocator::Region::isInThisRegion):
(JSC::DFG::::Allocator):
(JSC::DFG::::~Allocator):
(JSC::DFG::::allocate):
(JSC::DFG::::free):
(JSC::DFG::::freeAll):
(JSC::DFG::::reset):
(JSC::DFG::::indexOf):
(JSC::DFG::::allocatorOf):
(JSC::DFG::::bumpAllocate):
(JSC::DFG::::freeListAllocate):
(JSC::DFG::::allocateSlow):
(JSC::DFG::::freeRegionsStartingAt):
(JSC::DFG::::startBumpingIn):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::handleMinMax):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCommon.h:

(DFG):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGEdge.cpp:

(JSC::DFG::Edge::dump):

  • dfg/DFGEdge.h:

(JSC::DFG::Edge::useKindUnchecked):
(JSC::DFG::Edge::useKind):
(JSC::DFG::Edge::shift):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::fixDoubleEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(FixupPhase):
(JSC::DFG::FixupPhase::truncateConstantToInt32):
(JSC::DFG::FixupPhase::truncateConstantsIfNecessary):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):

  • dfg/DFGGraph.cpp:

(DFG):
(JSC::DFG::Graph::refChildren):
(JSC::DFG::Graph::derefChildren):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::performSubstitution):
(JSC::DFG::Graph::isPredictedNumerical):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
(DFG):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::convertToPutByOffset):
(JSC::DFG::Node::willHaveCodeGenOrOSR):
(JSC::DFG::Node::child1):
(JSC::DFG::Node::child2):
(JSC::DFG::Node::child3):
(JSC::DFG::Node::binaryUseKind):
(Node):
(JSC::DFG::Node::isBinaryUseKind):

  • dfg/DFGNodeAllocator.h:

(DFG):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::nodeFlagsAsString):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculationCheck):
(DFG):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::typeCheck):
(JSC::DFG::SpeculativeJIT::forwardTypeCheck):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithMod):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculateInt32):
(JSC::DFG::SpeculativeJIT::speculateNumber):
(JSC::DFG::SpeculativeJIT::speculateRealNumber):
(JSC::DFG::SpeculativeJIT::speculateBoolean):
(JSC::DFG::SpeculativeJIT::speculateCell):
(JSC::DFG::SpeculativeJIT::speculateObject):
(JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateNotCell):
(JSC::DFG::SpeculativeJIT::speculateOther):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::needsTypeCheck):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::IntegerOperand::edge):
(IntegerOperand):
(JSC::DFG::IntegerOperand::node):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::IntegerOperand::use):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSValueOperand):
(JSC::DFG::JSValueOperand::edge):
(JSC::DFG::JSValueOperand::node):
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::JSValueOperand::fill):
(JSC::DFG::JSValueOperand::use):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::edge):
(StorageOperand):
(JSC::DFG::StorageOperand::node):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(SpeculateIntegerOperand):
(JSC::DFG::SpeculateIntegerOperand::edge):
(JSC::DFG::SpeculateIntegerOperand::node):
(JSC::DFG::SpeculateIntegerOperand::gpr):
(JSC::DFG::SpeculateIntegerOperand::use):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateStrictInt32Operand::edge):
(JSC::DFG::SpeculateStrictInt32Operand::node):
(JSC::DFG::SpeculateStrictInt32Operand::gpr):
(JSC::DFG::SpeculateStrictInt32Operand::use):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::edge):
(JSC::DFG::SpeculateDoubleOperand::node):
(JSC::DFG::SpeculateDoubleOperand::fpr):
(JSC::DFG::SpeculateDoubleOperand::use):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::edge):
(JSC::DFG::SpeculateCellOperand::node):
(JSC::DFG::SpeculateCellOperand::gpr):
(JSC::DFG::SpeculateCellOperand::use):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::edge):
(SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::node):
(JSC::DFG::SpeculateBooleanOperand::gpr):
(JSC::DFG::SpeculateBooleanOperand::use):
(DFG):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • dfg/DFGUseKind.cpp: Added.

(WTF):
(WTF::printInternal):

  • dfg/DFGUseKind.h: Added.

(DFG):
(JSC::DFG::typeFilterFor):
(JSC::DFG::isNumerical):
(WTF):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::reportValidationContext):

2:57 PM Changeset in webkit [143653] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, roll chromium deps 183552 -> 183788

  • DEPS:
2:21 PM Changeset in webkit [143652] by tony@chromium.org
  • 9 edits in trunk

Autogenerate Settings that call setNeedsRecalcStyleInAllFrames when set
https://bugs.webkit.org/show_bug.cgi?id=109989

Reviewed by Ryosuke Niwa.

.:

Add setters to export symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

Start generating the code for settings that call m_page->setNeedsRecalcStyleInAllFrames()
when the value is changed. This allows us to generate 10 more settings. As a follow up, we
can remove some methods from DRT/WTR after this.

No new tests, this is a build refactor and should not impact any test results.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Remove member variables. Add SETTINGS_SETTER_BODIES macro that
has the generated setter bodies.

  • page/Settings.h:

(Settings): Remove code that is now generated.

  • page/Settings.in: Add new entries with setNeedsStyleRecalcWhenSetting=1
  • page/make_settings.pl:

(defaultItemFactory): Add setNeedsStyleRecalcWhenSetting flag.
(generateSettingsMacrosHeader): Print macro for setter bodies.
(printConditionalMacros): Add setter body code.
(printGettersAndSetters): Pass in setNeedsStyleRecalcWhenSetting so we know whether to inline the
setter in the header or not.
(printGetterAndSetter): Ditto.
(printSetterBodies): Print macro for setter bodies.
(printSetterBody): Print setter body for a single setting.

2:03 PM Changeset in webkit [143651] by pdr@google.com
  • 12 edits
    2 adds in trunk/LayoutTests

Rebaseline 4 SVG tests after an aspect ratio change in r143389

These 4 SVG tests needed a rebaseline after fixing WK99984.

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium/TestExpectations:
1:53 PM Changeset in webkit [143650] by dino@apple.com
  • 6 edits in trunk/Source

Plug-in snapshotting code always accepts first snapshot
https://bugs.webkit.org/show_bug.cgi?id=110495

Reviewed by Tim Horton.

When we detect a plugin that can be snapshotted we start capturing
images until we find one that we believe isn't blank, or we timeout.
I introduced a regression recently where we swap renderers as
soon as the snapshot arrives, whether or not is is blank.

The fix was to have the embedder (currently only WK2) be the one
who tells the HTMLPlugInElement to start displaying snapshots.

Source/WebCore:

  • html/HTMLPlugInElement.h:

(WebCore::HTMLPlugInElement::setDisplayState): Make this a virtual function.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::setDisplayState): Override to call the

base class version, but swap renderers if we should move to the snapshot.

(WebCore::HTMLPlugInImageElement::updateSnapshot): Don't swap renderers here any more.

  • html/HTMLPlugInImageElement.h: New virtual version of setDisplayState.

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginSnapshotTimerFired): When we find a
snapshot that we like, tell the HTMLPlugInElement to move to
the snapshot view.

1:46 PM Changeset in webkit [143649] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Tune BackgroundHTMLParser's pendingTokenLimit based on a benchmark
https://bugs.webkit.org/show_bug.cgi?id=110408

Reviewed by Adam Barth.

This constant was tuned by running the top 25 sites in Telemetry on a Nexus 7 device.
The new value decreases the maximum time spent parsing by 40% without significantly impacting total parse time or DOMContentLoaded.

No new tests because no new functionality.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore):

1:45 PM ExportingSymbols edited by tony@chromium.org
(diff)
1:40 PM Changeset in webkit [143648] by pdr@google.com
  • 2 edits in trunk/LayoutTests

Fix duplicate TestExpecataions entry for svg/custom/foreign-object-skew.svg

Unreviewed gardening of TestExpecations

  • platform/chromium/TestExpectations:
1:22 PM Changeset in webkit [143647] by fpizlo@apple.com
  • 7 edits in trunk/LayoutTests

Rebalance the running times of JSRegress somewhat.

Rubber stamped by Mark Hahnenberg.

  • fast/js/regress/script-tests/adapt-to-double-divide.js:

(foo):

  • fast/js/regress/script-tests/array-access-polymorphic-structure.js:
  • fast/js/regress/script-tests/int-overflow-local.js:
  • fast/js/regress/script-tests/method-on-number.js:

(foo):

  • fast/js/regress/script-tests/rare-osr-exit-on-local.js:
  • fast/js/regress/script-tests/slow-convergence.js:
1:11 PM Changeset in webkit [143646] by commit-queue@webkit.org
  • 13 edits
    5 deletes in trunk

Unreviewed, rolling out r143419.
http://trac.webkit.org/changeset/143419
https://bugs.webkit.org/show_bug.cgi?id=110507

Broke border-image on Mac (Requested by jpfau on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

Source/WebCore:

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawTiledImage):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(Image):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):

LayoutTests:

  • fast/borders/border-image-02.html: Removed.
  • platform/chromium-linux/fast/borders/border-image-02-expected.png: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/borders/border-image-02-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/gtk/fast/borders/border-image-02-expected.png: Removed.
  • platform/gtk/fast/borders/border-image-02-expected.txt: Removed.
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
1:07 PM Changeset in webkit [143645] by fpizlo@apple.com
  • 1 edit
    9 adds in trunk/LayoutTests

Add Apache's HashMap.java translated into JavaScript as a JSRegress test

Rubber stamped by Geoffrey Garen.

  • fast/js/regress/HashMap-put-get-iterate-keys.html: Added.
  • fast/js/regress/HashMap-put-get-iterate.html: Added.
  • fast/js/regress/HashMap-string-put-get-iterate.html: Added.
  • fast/js/regress/script-tests/HashMap-put-get-iterate-keys.js: Added.

(HashMap):
(HashMap.):
(get var):

  • fast/js/regress/script-tests/HashMap-put-get-iterate.js: Added.

(HashMap):
(HashMap.):
(get var):

  • fast/js/regress/script-tests/HashMap-string-put-get-iterate.js: Added.

(HashMap):
(HashMap.):
(get var):

1:00 PM Changeset in webkit [143644] by tsepez@chromium.org
  • 38 edits
    1 copy
    5 adds in trunk

XSSAuditor should block pages by redirecting to a sandboxed data: URL.
https://bugs.webkit.org/show_bug.cgi?id=110406

Reviewed by Adam Barth.

Source/WebCore:

Patch originally by mkwst@chromium.org.
Tests: http/tests/security/xssAuditor/block-does-not-leak-location.html

http/tests/security/xssAuditor/block-does-not-leak-referrer.html
http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

When blocking entire pages via the XSSAuditor, redirect to a data:
URL to ensure that requests for properties don't leak information.

LayoutTests:

  • http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt: Added.
  • http/tests/security/xssAuditor/block-does-not-leak-location.html: Added.
  • http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt: Added.
  • http/tests/security/xssAuditor/block-does-not-leak-referrer.html: Added.
  • http/tests/security/xssAuditor/full-block-base-href-expected.txt:
  • http/tests/security/xssAuditor/full-block-base-href.html:
  • http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url.html:
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit.php:
  • http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
  • http/tests/security/xssAuditor/full-block-javascript-link.html:
  • http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
  • http/tests/security/xssAuditor/full-block-link-onclick.html:
  • http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-object-tag.html:
  • http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html: Added.
  • http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-with-source.html:
  • http/tests/security/xssAuditor/full-block-script-tag.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-1.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-2.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-3.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-4.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-5.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-6.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-7.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-8.html:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-9.html:
  • http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-02.html:
  • http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-03.html:
  • http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-04.html:

Rebaselined tests. Can no longer use final location of about:blank to
indicate success.

  • http/tests/security/xssAuditor/resources/utilities.js:

(checkIfFrameLocationMatchesSrcAndCallDone):

Check final location against frame source (should only match when same
origin and not blocked).

  • http/tests/security/xssAuditor/resources/echo-intertag.pl:

Clean up noise in httpd error log about undefined values.

12:56 PM Changeset in webkit [143643] by commit-queue@webkit.org
  • 29 edits in trunk

Convert buttons from DeprecatedFlexBox to nondeprecated FlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=109994

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-21
Reviewed by Ojan Vafai.

Source/WebCore:

Covered by existing tests for <button> and <input
type="button|submit|reset">

  • css/html.css:

(input[type="button"], input[type="submit"], input[type="reset"], input[type="file"]::-webkit-file-upload-button, button):
Convert from box-align to align-items. We are using flex-start here in
conjunction with an auto margin for correct centering. See
RenderButton.cpp below for the margin & more explanation.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
Add a case for creating a non-deprecated flex box.

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::addChild):
(WebCore::RenderButton::removeChild):
Forward to new base class
(WebCore::RenderButton::styleWillChange):
(WebCore::RenderButton::setupInnerStyle):
We are now using flexbox properties.

  • min-width is needed for correct shrinking of the contents
  • margin-top and margin-bottom are used for correct centering. We

can't use align-items: center because results are incorrect when the
content overflows. See LayoutTests/fast/forms/control-clip.html

  • rendering/RenderButton.h:

Inherit from RenderFlexibleBox

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::createAnonymous):
(WebCore):

  • rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):
Add a createAnonymous function to RenderFlexibleBox.

LayoutTests:

  • fast/flexbox/box-orient-button.html: Change -webkit-box to

-webkit-flex, and related changes.

  • fast/flexbox/resources/box-orient-button.js:

(setFlexDirection): webkitBoxOrient -> webkitFlexDirection

  • fast/replaced/table-percent-height.html: Give a value to the

<input type="button"> so that the layout doesn't change. No need to
change expectations because this test uses dumpAsText() and just
compares one button's height to another.

  • http/tests/security/isolatedWorld/userGestureEvents.html: Add text

to the button so that sending the click event doesn't miss the
now-smaller button.

  • http/tests/security/isolatedWorld/userGestureEvents-expected.txt:

Add that text to the expectation too.

  • fast/forms/button-generated-content-expected.txt:
  • platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/chromium-linux/fast/forms/button-generated-content-expected.png:
  • platform/chromium-linux/fast/forms/button-generated-content-expected.txt:
  • platform/chromium-linux/fast/forms/select-baseline-expected.png:
  • platform/chromium-linux/fast/forms/select-baseline-expected.txt:
  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/mac/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/mac/fast/forms/select-baseline-expected.txt:
  • platform/mac/svg/custom/foreign-object-skew-expected.txt:

Rebaseline. Most changes come from the fact that an empty button now
consistently has a small height, when previously it would sometimes
have the height of the line. See this testcase:
https://bugs.webkit.org/attachment.cgi?id=188679
The new behavior is consistent with Firefox.

The only other difference is fast/forms/button-generated-content.html:
The empty buttons are now aligned on the baseline instead of being
vertically centered in the line. This is consistent with Firefox.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:

Mark tests for rebaselining.

12:49 PM Changeset in webkit [143642] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Simplify computation of screenRect/windowRect.
https://bugs.webkit.org/show_bug.cgi?id=110456

Patch by John Mellor <johnme@chromium.org> on 2013-02-21
Reviewed by Adam Barth.

This patch removes applyDeviceScaleFactorInCompositor checks
added by http://trac.webkit.org/changeset/139356 because
Chrome for Android now sizes its screen and window in DIP
units (like other platforms), so they are no longer necessary.

Source/WebCore:

No new tests, since this is just removing an unused codepath.

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processSubtree):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::windowRect):

12:41 PM Changeset in webkit [143641] by Beth Dakin
  • 9 edits
    2 deletes in trunk

Out-of-view fixed position check should not be affected by page scale at all on Mac
https://bugs.webkit.org/show_bug.cgi?id=110294
-and corresponding-
<rdar://problem/13247582>

Reviewed by Simon Fraser.

Source/WebCore:

Don't scale the layerBounds. Generally, the layerBounds should be relative to the
viewBounds which are also unscaled. Chromium used to want this behavior, but it is
covered by their pageScaleFactorAppliedInCompositor implementation now.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

These layer results should be the same regardless of the scale factor.

  • compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html:
  • compositing/layer-creation/fixed-position-out-of-view-scaled.html:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Removed.
  • platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:

Skip these on Chromium for now.

  • platform/chromium/TestExpectations:
12:37 PM Changeset in webkit [143640] by pdr@google.com
  • 4 edits
    2 adds in trunk

Stop starting animations when leaving a page
https://bugs.webkit.org/show_bug.cgi?id=110257

Reviewed by Stephen Chenney.

Source/WebCore:

SVGImage::resetAnimation() incorrectly started animations which could cause a crash
when leaving the page. This patch fixes resetAnimation to only stop the animation,
similar to BitmapImage::resetAnimation().

Additionally, this patch removes an unneeded call to Document::updateStyleForAllDocuments()
that was present in the animation loop. This makes the animation code more resistant to
similar bugs in the future.

Both of these changes are functionally covered with existing tests.

Test: svg/animations/reset-animation-crash.html

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::resetAnimation):

LayoutTests:

  • svg/animations/reset-animation-crash-expected.html: Added.
  • svg/animations/reset-animation-crash.html: Added.
12:33 PM Changeset in webkit [143639] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[chromium] Remove deprecated WebCompositorSupport::createLayerTreeView() declaration
https://bugs.webkit.org/show_bug.cgi?id=110492

Patch by James Robinson <jamesr@chromium.org> on 2013-02-21
Reviewed by Adrienne Walker.

  • chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):

12:31 PM Changeset in webkit [143638] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] document WebTestDelegate and WebTestRunner interfaces
https://bugs.webkit.org/show_bug.cgi?id=110472

Reviewed by Adam Barth.

Also remove the default implementation of the remaining WebTestDelegate
methods now that all embedders provide this interface.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

12:00 PM Changeset in webkit [143637] by mhahnenberg@apple.com
  • 50 edits
    3 adds in trunk

Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
https://bugs.webkit.org/show_bug.cgi?id=106059

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

  • API/JSBase.h: Renamed enable flag for API.
  • API/JSBlockAdaptor.h: Using new flag.
  • API/JSBlockAdaptor.mm: Ditto.
  • API/JSContext.h: Add convenience C API conversion function for JSGlobalContextRef.
  • API/JSContext.mm:

(-[JSContext JSGlobalContextRef]): Implementation of C API convenience function.
(-[JSContext initWithVirtualMachine:]): We don't use the m_apiData field any more.
(-[JSContext initWithGlobalContextRef:]): init method for allocating new JSContexts given a JSGlobalContextRef.
(-[JSContext dealloc]): No more m_apiData.
(-[JSContext wrapperForObjCObject:]): Renamed wrapperForObject.
(-[JSContext wrapperForJSObject:]): Fetches or allocates the JSValue for the specified JSValueRef in this JSContext.
(+[JSContext contextWithGlobalContextRef:]): Helper function to grab the lightweight JSContext wrapper for a given
JSGlobalContextRef from the global wrapper cache or allocate a new one if there isn't already one.

  • API/JSContextInternal.h: New flag, new method declaration for initWithGlobalContextRef.
  • API/JSExport.h: New flag.
  • API/JSValue.h: New flag and new C API convenience method.
  • API/JSValue.mm:

(-[JSValue JSValueRef]): Implementation of the C API convenience method.
(objectToValueWithoutCopy):
(+[JSValue valueWithValue:inContext:]): We now ask the JSContext for an Objective-C JSValue wrapper, which it can cache
in its internal JSWrapperMap.

  • API/JSValueInternal.h:
  • API/JSVirtualMachine.h:
  • API/JSVirtualMachine.mm: Added global cache that maps JSContextGroupRef -> JSVirtualMachine lightweight wrappers.

(wrapperCacheLock):
(initWrapperCache):
(+[JSVMWrapperCache addWrapper:forJSContextGroupRef:]):
(+[JSVMWrapperCache wrapperForJSContextGroupRef:]):
(-[JSVirtualMachine init]):
(-[JSVirtualMachine initWithContextGroupRef:]):
(-[JSVirtualMachine dealloc]):
(+[JSVirtualMachine virtualMachineWithContextGroupRef:]):
(-[JSVirtualMachine contextForGlobalContextRef:]):
(-[JSVirtualMachine addContext:forGlobalContextRef:]):

  • API/JSVirtualMachineInternal.h:
  • API/JSWrapperMap.h:
  • API/JSWrapperMap.mm:

(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): We use the JSObjectSetPrototype C API call because
setting the proto property causes all sorts of bad things to happen behind the scenes, which can cause crashes based on
when it gets called.
(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap jsWrapperForObject:]):
(-[JSWrapperMap objcWrapperForJSValueRef:]):

  • API/JavaScriptCore.h:
  • API/ObjCCallbackFunction.h:
  • API/ObjCCallbackFunction.mm:

(ObjCCallbackFunction::ObjCCallbackFunction): We never actually should have retained the target in the case that we had a
block as a callback. Blocks are initially allocated on the stack and are only moved to the heap if we call their copy method.
Retaining the block on the stack was a bad idea because if that stack frame ever went away and we called the block later,
we'd crash and burn.
(ObjCCallbackFunction::setContext): We need a new setter for when the weak reference to a JSContext inside an ObjCCallbackFunction
disappears, we can allocate a new one in its place.
(ObjCCallbackFunction):
(objCCallbackFunctionCallAsFunction): Reset the callback's context if it's ever destroyed.
(objCCallbackFunctionForInvocation): Again, don't set the proto property because it uses black magic that can cause us to crash
depending on when this is called.
(objCCallbackFunctionForBlock): Here is where we copy the block to the heap when we're first creating the callback object for it.

  • API/tests/testapi.c:

(main):

  • API/tests/testapi.mm: We're going to get rid of the automatic block conversion, since that is causing leaks. I changed it

here in this test just so that it wouldn't mask any other potential leaks. Also modified some of the tests since JSContexts are
just lightweight wrappers now, we're not guaranteed to get the same pointer back from the call to [JSValue context] as the one
that the value was created in.
(-[TestObject callback:]):

(JSC::JSGlobalData::JSGlobalData): No more m_apiData.

  • runtime/JSGlobalData.h: Ditto.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject): Ditto.

  • runtime/JSGlobalObject.h:

Source/WebCore:

Reviewed by Geoffrey Garen.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::setWindow): Since we're basically abandoning a JSDOMWindow here, we call
garbageCollectSoon().

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/ScriptController.h: New function to get the JSContext for the global object of the current main world.
  • bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::javaScriptContext): Ditto.

  • bindings/objc/WebScriptObject.h: Added ifdef guards. Also new convenience conversion function for the JSC Obj-C API.
  • bindings/objc/WebScriptObject.mm: JSC::JSValue and JSValue conflict with one another, so we have to be more specific.

(-[WebScriptObject _globalContextRef]): Useful helper function for getting the JSGlobalContextRef of a particular WebScriptObject.
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject webScriptValueAtIndex:]):
(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
(-[WebScriptObject JSValue]): Implementation of convenience WebScriptObject conversion function to new Objective-C API.

  • bindings/objc/WebScriptObjectPrivate.h:

Source/WebKit/mac:

Reviewed by Geoffrey Garen.

Addition of appropriate delegate callbacks and support to the WebKit API.

  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebDelegateImplementationCaching.h:

(WebFrameLoadDelegateImplementationCache):

  • WebView/WebFrame.h:
  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
(-[WebFrame _javaScriptContextForScriptWorld:]):
(-[WebFrame javaScriptContext]):

  • WebView/WebFrameLoadDelegate.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebScriptDebugDelegate.mm:

(-[WebScriptCallFrame _convertValueToObjcValue:JSC::]):
(-[WebScriptCallFrame exception]):
(-[WebScriptCallFrame evaluateWebScript:]):

  • WebView/WebScriptWorld.h:
  • WebView/WebScriptWorld.mm:

(+[WebScriptWorld scriptWorldForJavaScriptContext:]):

  • WebView/WebView.mm:

(-[WebView _cacheFrameLoadDelegateImplementations]):
(aeDescFromJSValue):
(-[WebView aeDescByEvaluatingJavaScriptFromString:]):
(-[WebView _computedStyleIncludingVisitedInfo:forElement:]):

Source/WTF:

Reviewed by Geoffrey Garen.

  • wtf/FeatureDefines.h: Added enable flag for JSC Objective-C API so it can be used in

export files.

Tools:

Reviewed by Geoffrey Garen.

Added new tests for the WebKit API portion of the JSC Objective-C API.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
  • TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
  • TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.

(-[MyConsole log:]):
(-[MyConsole printHelloWorld]):
(-[MyConsole add:to:]):
(-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
(-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

11:56 AM Changeset in webkit [143636] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Rename add{Node,Object}ToGroup() to add{Node,Object}WrapperToGroup()
https://bugs.webkit.org/show_bug.cgi?id=110404

Reviewed by Adam Barth.

The current function name is confusing
(See discussion in bug 110396). We should rename the functions
so that it becomes clear that "Node"/"Object" refers to a type
of a wrapper in the second argument.

No tests. No change in behavior.

  • bindings/v8/V8GCController.cpp:

(WebCore::WrapperGrouper::addObjectWrapperToGroup):
(WebCore::WrapperGrouper::addNodeWrapperToGroup):

11:39 AM Changeset in webkit [143635] by schenney@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, add myself as a reviewer

  • Scripts/webkitpy/common/config/committers.py:
11:35 AM Changeset in webkit [143634] by Lucas Forschler
  • 2 edits in tags/Safari-537.31.6/Source/WebKit2

Merged r143552. <rdar://problem/13157837>

11:30 AM Changeset in webkit [143633] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.6/Source

Versioning.

11:26 AM Changeset in webkit [143632] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.6

New Tag.

11:20 AM Changeset in webkit [143631] by vivek.vg@samsung.com
  • 2 edits in trunk/Source/WebCore

[JS Binding] ScriptObject default constructor should initialize the Script State to 0
https://bugs.webkit.org/show_bug.cgi?id=110177

Reviewed by Geoffrey Garen.

Adding the initialization of ScriptState to 0.

  • bindings/js/ScriptObject.h:

(WebCore::ScriptObject::ScriptObject):

11:19 AM Changeset in webkit [143630] by Nate Chapin
  • 3 edits
    3 adds in trunk

REGRESSION: Crash in MainResourceLoader::setDataBufferingPolicy when sharing an html5 video via email
https://bugs.webkit.org/show_bug.cgi?id=110075

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: webarchive/loading/video-in-webarchive.html

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::continueAfterContentPolicy): isStopping()

isn't accurate to determine whether a SubstituteData load should
continue, as this point in the code shouldn't be reachable from any point
where isStopping() would return true. DocumentLoader might have completely
stopped and believe that MainResourceLoader is complete, though. Don't
continue in that case.

(WebCore::MainResourceLoader::setDataBufferingPolicy): m_resource can be null

in a reasonable case, handle it rather than asserting that it can't be null.

LayoutTests:

  • webarchive/loading/resources/video-in-webarchive.webarchive: Added.
  • webarchive/loading/video-in-webarchive-expected.txt: Added.
  • webarchive/loading/video-in-webarchive.html: Added.
11:09 AM Changeset in webkit [143629] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] WebPagePrivate::load should not check new window policy
https://bugs.webkit.org/show_bug.cgi?id=110403

Patch by Andrew Lo <anlo@rim.com> on 2013-02-21
Reviewed by Rob Buis.

Based on my understanding of changeset 135952, we should
not check the new window policy in WebPagePrivate::load.

None of the other ports seem to do this, except for plugins.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):

10:51 AM Changeset in webkit [143628] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r143616.
http://trac.webkit.org/changeset/143616
https://bugs.webkit.org/show_bug.cgi?id=110491

Caused a test failure on Chromium Mac. (Requested by vollick
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

Source/WebCore:

  • page/FrameView.cpp:

(WebCore::FrameView::visibleContentsResized):

  • page/FrameView.h:

(FrameView):

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

LayoutTests:

  • platform/chromium/fast/repaint/relayout-fixed-position-after-scale-expected.html: Removed.
  • platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html: Removed.
10:46 AM Changeset in webkit [143627] by robert@webkit.org
  • 9 edits in trunk/Source/WebCore

Overflow can be cleared just before it is computed
https://bugs.webkit.org/show_bug.cgi?id=110361

Reviewed by David Hyatt.

Overflow can be cleared just before it is computed in a lot of places because overflow computation happens all at once
now rather than cumulatively during layout. Any object that doesn't use computeOverflow() will still need to clear it manually
though.

No new tests, refactoring.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::simplifiedLayout):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

10:25 AM Changeset in webkit [143626] by alokp@chromium.org
  • 303 edits
    4 copies
    5 adds in trunk

Mark GraphicsLayers as opaque when possible
https://bugs.webkit.org/show_bug.cgi?id=70634

Reviewed by Simon Fraser.

Source/WebCore:

Mark layers as opaque in a very simple case - the main renderer has an
opaque background and covers the entire composited bounds.
RenderLayer::contentsOpaqueInRect has been implemented conservatively,
i.e. it errs towards returning false negative.

Tests: compositing/contents-opaque/contents-opaque-background-clip.html

compositing/contents-opaque/contents-opaque-background-color.html
compositing/contents-opaque/contents-opaque-layer-opacity.html
compositing/contents-opaque/contents-opaque-layer-transform.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::backgroundIsOpaqueInRect):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::backgroundIsOpaqueInRect):
(WebCore::RenderBoxModelObject::foregroundIsOpaqueInRect):
(RenderBoxModelObject):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentsOpaqueInRect):
(WebCore):
(WebCore::RenderLayer::listContentsOpaqueInRect):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

  • rendering/RenderLayerModelObject.h:

(RenderLayerModelObject):

LayoutTests:

  • compositing/absolute-inside-out-of-view-fixed-expected.txt:
  • compositing/backing/no-backing-for-clip-expected.txt:
  • compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/clip-child-by-non-stacking-ancestor-expected.txt:
  • compositing/columns/composited-in-paginated-expected.txt:
  • compositing/contents-opaque/contents-opaque-background-clip-expected.txt: Copied from LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
  • compositing/contents-opaque/contents-opaque-background-clip.html: Added.
  • compositing/contents-opaque/contents-opaque-background-color-expected.txt: Copied from LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
  • compositing/contents-opaque/contents-opaque-background-color.html: Added.
  • compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
  • compositing/contents-opaque/contents-opaque-layer-opacity.html: Added.
  • compositing/contents-opaque/contents-opaque-layer-transform-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
  • compositing/contents-opaque/contents-opaque-layer-transform.html: Added.
  • compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-expected.txt:
  • compositing/geometry/clip-expected.txt:
  • compositing/geometry/clip-inside-expected.txt:
  • compositing/geometry/fixed-position-composited-switch-expected.txt:
  • compositing/geometry/flipped-writing-mode-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
  • compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • compositing/iframes/overlapped-nested-iframes-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/layer-creation/animation-overlap-with-children-expected.txt:
  • compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overlap-animation-clipping-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-child-layer-expected.txt:
  • compositing/layer-creation/overlap-clipping-expected.txt:
  • compositing/layer-creation/overlap-transformed-3d-expected.txt:
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-expected.txt:
  • compositing/layer-creation/translatez-overlap-expected.txt:
  • compositing/masks/mask-layer-size-expected.txt:
  • compositing/overflow-trumps-transform-style-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • compositing/overflow/textarea-scroll-touch-expected.txt:
  • compositing/plugins/no-backing-store-expected.txt:
  • compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • compositing/rtl/rtl-absolute-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • compositing/rtl/rtl-relative-expected.txt:
  • compositing/tiled-layers-hidpi-expected.txt:
  • compositing/tiling/backface-preserve-3d-tiled-expected.txt:
  • compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • compositing/tiling/rotated-tiled-clamped-expected.txt:
  • compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
  • compositing/tiling/tile-cache-zoomed-expected.txt:
  • compositing/tiling/tiled-layer-resize-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/iframe-no-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • css3/filters/filtered-compositing-descendant-expected.txt:
  • platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-mac/compositing/overflow/textarea-scroll-touch-expected.txt:
  • platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
  • platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
  • platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium/compositing/geometry/clip-expected.txt:
  • platform/chromium/compositing/geometry/clip-inside-expected.txt:
  • platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
  • platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
  • platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/chromium/compositing/iframes/iframe-resize-expected.txt:
  • platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
  • platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/chromium/compositing/iframes/resizer-expected.txt:
  • platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
  • platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
  • platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
  • platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
  • platform/chromium/compositing/overflow/clip-descendents-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium/compositing/rtl/rtl-relative-expected.txt:
  • platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
  • platform/mac/TestExpectations:
  • platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
  • platform/mac/compositing/iframes/resizer-expected.txt:
  • platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
  • platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
  • platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
  • platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
  • platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
  • platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
  • platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
  • platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
10:21 AM Changeset in webkit [143625] by jer.noble@apple.com
  • 3 edits in trunk/Tools

Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
10:07 AM Changeset in webkit [143624] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk

Merge r143619 - [GTK] Remove subresource leaks from WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=108960

Patch by George McCollister <george.mccollister@gmail.com> on 2013-02-21
Reviewed by Martin Robinson.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFinishLoading): Remove resource
if it isn't the main resource to prevent leak.
(WebKit::FrameLoaderClient::dispatchDidFailLoading): Ditto

  • webkit/webkitwebview.cpp:

(cleanupTemporarilyCachedSubresources): Added to cleanup subresources.
(webkit_web_view_get_subresources): Use getSubresources from the
documentLoader to provide subresources since resources will be removed
from webview after loading.

10:04 AM Changeset in webkit [143623] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Tools

Merge r143620 - gtk/DumpRenderTree.cpp is missing <locale.h> include
https://bugs.webkit.org/show_bug.cgi?id=109386

  • DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build

by include locale.h when we use setlocale.

10:02 AM Changeset in webkit [143622] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.0/Source

Merge r143618 - A couple more 'make dist' fixes for WebKitGTK+.

Source/WebCore:

  • GNUmakefile.list.am: Add a missing file to the source list.

Source/WTF:

  • GNUmakefile.list.am: Add a missing file to the source list.
9:58 AM WebKitGTK/2.0.x edited by Martin Robinson
(diff)
9:57 AM WebKitGTK/2.0.x edited by Martin Robinson
(diff)
9:53 AM Changeset in webkit [143621] by jchaffraix@webkit.org
  • 6 edits in trunk

[CSS Grid Layout] Implement grid growth during auto placement
https://bugs.webkit.org/show_bug.cgi?id=110418

Reviewed by Ojan Vafai.

Source/WebCore:

This change implements the last remaining piece of the auto placement algorithm:
growing the grid mid-placement. With that landed, we should handle all cases properly.

Change covered by : fast/css-grid-layout/grid-item-addition-auto-placement.html

fast/css-grid-layout/grid-item-removal-auto-placement.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::growGrid):
Added this helper function to grow the grid one item in a direction.

(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
Updated this function to grow in the minor axis direction and insert in the
newly created grid area.

(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
Updated this function to grow in the major axis direction and insert in the
newly create grid area. Unfortunately this code cannot use the iterator to find
the new position as the (auto, auto) case iterates orthogonally to the major axis
direction, which we just grew.

  • rendering/RenderGrid.h:

Added growGrid.

LayoutTests:

  • fast/css-grid-layout/grid-item-addition-auto-placement-update-expected.txt:
  • fast/css-grid-layout/grid-item-removal-auto-placement-update-expected.txt:
9:52 AM Changeset in webkit [143620] by Martin Robinson
  • 2 edits in trunk/Tools

gtk/DumpRenderTree.cpp is missing <locale.h> include
https://bugs.webkit.org/show_bug.cgi?id=109386

  • DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build

by include locale.h when we use setlocale.

9:50 AM Changeset in webkit [143619] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] Remove subresource leaks from WebKit1 and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=108960

Patch by George McCollister <george.mccollister@gmail.com> on 2013-02-21
Reviewed by Martin Robinson.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFinishLoading): Remove resource
if it isn't the main resource to prevent leak.
(WebKit::FrameLoaderClient::dispatchDidFailLoading): Ditto

  • webkit/webkitwebview.cpp:

(cleanupTemporarilyCachedSubresources): Added to cleanup subresources.
(webkit_web_view_get_subresources): Use getSubresources from the
documentLoader to provide subresources since resources will be removed
from webview after loading.

9:49 AM Changeset in webkit [143618] by Martin Robinson
  • 4 edits in trunk/Source

A couple more 'make dist' fixes for WebKitGTK+.

Source/WebCore:

  • GNUmakefile.list.am: Add a missing file to the source list.

Source/WTF:

  • GNUmakefile.list.am: Add a missing file to the source list.
9:42 AM Changeset in webkit [143617] by abucur@adobe.com
  • 3 edits
    2 adds in trunk

-webkit-margin-collapse: separate doesn't work correctly for before margins
https://bugs.webkit.org/show_bug.cgi?id=109956

Reviewed by David Hyatt.

Source/WebCore:

The collapsing code for "-webkit-margin-collapse: separate" assumed the margin value inside
marginInfo always contributes to the position of the child. This is valid only if the collapse
doesn't happen at the before side of the container. In that case, the child needs to be positioned
at the margin value specified in the style sheet.

Test: fast/block/margin-collapse/webkit-margin-collapse-separate-position.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseMargins):

LayoutTests:

The test verifies a child specifying "-webkit-margin-collapse: separate" is correctly positioned inside
its container, at a value equal with the top margin of the child. The container also need to be sized
accordingly.

  • fast/block/margin-collapse/webkit-margin-collapse-separate-position-expected.txt: Added.
  • fast/block/margin-collapse/webkit-margin-collapse-separate-position.html: Added.
9:31 AM Changeset in webkit [143616] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Need to re-layout fixed position elements after scale when using settings()->fixedElementsLayoutRelativeToFrame()
https://bugs.webkit.org/show_bug.cgi?id=105486

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-02-21
Reviewed by James Robinson.

In settings()->fixedElementsLayoutRelativeToFrame() mode, fixed-position
elements are layout relative to the current visible viewport, which can
be different from the layout viewport when using fixed-layout mode.
We need to re-layout fixed-position elements in case of visible content
size changes.

The test is currently chromium-specific due to difficulties to make this
test works on Mac. The mac port seems to work very differently with
visible content size when a page is scaled. And there is no reliable way
to hide scrollbars in mac-wk1 that doesn't cause a side effect.

Source/WebCore:

Test: platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html

  • page/FrameView.cpp:

(WebCore::FrameView::visibleContentsResized):

  • page/FrameView.h:

(FrameView):

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

LayoutTests:

  • platform/chromium/fast/repaint/relayout-fixed-position-after-scale-expected.html: Added.
  • platform/chromium/fast/repaint/relayout-fixed-position-after-scale.html: Added.
9:18 AM Changeset in webkit [143615] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] BackingStore: replace instrument{Begin,Cancel}Frame with did{Begin,Cancel}Frame
https://bugs.webkit.org/show_bug.cgi?id=110460

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Rob Buis.

This was renamed incorrectly in r142879.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
(BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):

9:11 AM Changeset in webkit [143614] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Extra ResourceRequest parameter in FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload
https://bugs.webkit.org/show_bug.cgi?id=110451

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-21
Reviewed by Rob Buis.

Remove the extra ResourceRequest parameter from
FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

9:09 AM Changeset in webkit [143613] by mihnea@adobe.com
  • 1 edit
    2 adds in trunk/LayoutTests

[CSS Regions] border-radius on a region causes overflow to be hidden
https://bugs.webkit.org/show_bug.cgi?id=103684

Reviewed by Tony Chang.

The fix for https://bugs.webkit.org/show_bug.cgi?id=74132, making RenderRegion
inherit from RenderBlock instead of RenderReplaced, also fixed this bug.
Still, it deserves a test.

  • fast/regions/last-region-border-radius-expected.html: Added.
  • fast/regions/last-region-border-radius.html: Added.
9:02 AM Changeset in webkit [143612] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] LayerFilterRenderer: fix inclusion of Vector.h
https://bugs.webkit.org/show_bug.cgi?id=110476

Patch by Xan Lopez <xlopez@rim.com> on 2013-02-21
Reviewed by Rob Buis.

Added in r124242. The include line should be wtf/Vector.h

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:
8:54 AM Changeset in webkit [143611] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Adapt to name changes in WebCore::ViewPortArguments
https://bugs.webkit.org/show_bug.cgi?id=110469

Patch by Xan Lopez <xlopez@rim.com> on 2013-02-21
Reviewed by Rob Buis.

This changed in r134765.

  • Api/WebViewportArguments.cpp:

(BlackBerry::WebKit::WebViewportArguments::zoom):
(BlackBerry::WebKit::WebViewportArguments::setZoom):
(BlackBerry::WebKit::WebViewportArguments::minZoom):
(BlackBerry::WebKit::WebViewportArguments::setMinZoom):
(BlackBerry::WebKit::WebViewportArguments::maxZoom):
(BlackBerry::WebKit::WebViewportArguments::setMaxZoom):
(BlackBerry::WebKit::WebViewportArguments::userZoom):
(BlackBerry::WebKit::WebViewportArguments::setUserZoom):

  • Api/WebViewportArguments.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::didSetSVGZoomAndPan):

8:50 AM Changeset in webkit [143610] by jpetsovits@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Move posting and scrollbar updates to the page client.
https://bugs.webkit.org/show_bug.cgi?id=110256
Internal PR 297099

Reviewed by Rob Buis.

In blitVisibleContents(), we were calling the WebKit thread
functions BackingStorePrivate::isScrollingOrZooming() and
WebPage::isVisible(). This is not the right spot to do it.
Furthermore, we want to move away from direct window access
in WebKit and leave that kind of dirtywork to the client.

This patch removes invalidateWindow() as well as the two
virtual scrollbar drawing functions and replaces it with
one new virtual, WebPageClient::postToSurface().
This clears up threading issues and gets us another step
further towards pure WebPageCompositor rendering.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPageClient.h:
8:46 AM Changeset in webkit [143609] by hyatt@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

[New Multicolumn] Add a positioned object pagination test.
https://bugs.webkit.org/show_bug.cgi?id=110480.

Reviewed by Antti Koivisto.

  • fast/multicol/newmulticol/positioned-split-expected.html: Added.
  • fast/multicol/newmulticol/positioned-split.html: Added.
8:37 AM Changeset in webkit [143608] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening; unskip test that is now passing on the bots.

  • platform/efl/TestExpectations:
8:33 AM Changeset in webkit [143607] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Rename Localizer to Locale
https://bugs.webkit.org/show_bug.cgi?id=110449

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-21
Reviewed by Rob Buis.

  • WebCoreSupport/ColorPickerClient.cpp:

(WebCore::ColorPickerClient::locale):

  • WebCoreSupport/ColorPickerClient.h:

(ColorPickerClient):

  • WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::locale):

  • WebCoreSupport/DatePickerClient.h:

(DatePickerClient):

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::locale):

  • WebCoreSupport/SelectPopupClient.h:

(SelectPopupClient):

8:33 AM Changeset in webkit [143606] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

[New Multicolumn] Remove unneeded layout method in RenderMultiColumnFlowThread.
https://bugs.webkit.org/show_bug.cgi?id=110477.

Reviewed by Antti Koivisto.

I forgot that both the sets and the flow thread lay out before the containing
RenderMultiColumnBlock has finished. That means it hasn't computed its overflow yet.
Therefore there is no need to force it to compute its overflow from inside
RenderMultiColumnFlowThread::layout, because the minute RenderMultiColumnFlowThread
finishes its layout, the block will compute its overflow anyway.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore):

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):

8:30 AM Changeset in webkit [143605] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1410/Source/WebCore/inspector/InspectorDebuggerAgent.cpp

Merge 143334

Web Inspector: release backtrace object group on each step.
https://bugs.webkit.org/show_bug.cgi?id=110223

Reviewed by Pavel Feldman.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):

TBR=podivilov@chromium.org
Review URL: https://codereview.chromium.org/12316038

8:19 AM Changeset in webkit [143604] by Martin Robinson
  • 9 edits
    2 adds
    3 deletes in trunk

[GTK] Move feature overriding to the configure phase
https://bugs.webkit.org/show_bug.cgi?id=110293

Reviewed by Gustavo Noronha Silva.

.:

Rework the feature overrides logic so all feature defines go into a
header rather than the command line. This has a few benefits. Most
notably, we can reuse the header in the gyp build. Another nice result
is that changes to the configuration automatically result in a full
rebuild and Debug and Release builds can have different configurations.

All feature define processing happens now during the configuration phase,
instead of when running autogen.sh. This means that we need to distribute
the feature processing script.

  • GNUmakefile.am: Read feature defines from WebKitFeatures.txt when kicking

off a build. Also include generate-feature-defines-files in the distribution.

  • Source/autotools/SetupAutoconfHeader.m4: Remove an extra ENABLE_3D_RENDERING

from the autoconf header, as it is already provided by the feature configuration.

  • Source/autotools/SetupWebKitFeatures.m4: Added.
  • Source/autotools/webkitfeature.m4: Removed. The functionality has been moved

to SetupWebKitFeatures.m4.

  • autogen.sh: Remove the call to override-feature-defines.
  • configure.ac: Now include SetupWebKitFeatures.

Source/WebCore:

  • GNUmakefile.am: No longer include GNUmakefile.features.am. We don't

have to process the result of this file or do any modification of
feature_defines_override, because this variable is gone.

Tools:

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
WebKitFeatureOverrides.txt to better match the other filenames used in
the new feature processing.

  • gtk/generate-feature-defines-files: Added. A script which takes as an argument

the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
and writes WebKitFeatures.txt and WebKitFeatures.h.

  • gtk/override-feature-defines: Removed.
8:04 AM Changeset in webkit [143603] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Rolling out an unindented change from r143580.

  • inspector/Inspector.json:
8:02 AM Changeset in webkit [143602] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Unskip some tests which are passing; too bad nobody cared to file
bugs for them in the first place.

  • platform/efl/TestExpectations:
7:44 AM Changeset in webkit [143601] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

GlyphPage: Bake per-glyph font data array into same allocation as GlyphPage.

A hopeful fix for REGRESSION(r143125): ~5% performance hit on Chromium's intl2 page cycler
<http://webkit.org/b/108835>

Reviewed by Antti Koivisto.

Rewire GlyphPage so that we have to decide at creation time whether there will be a per-glyph
array of SimpleFontData* or not. This removes one allocation and one step of indirection for
pages with glyphs from mixed fonts.

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::createForMixedFontData):
(WebCore::GlyphPage::createForSingleFontData):
(WebCore::GlyphPage::createCopiedSystemFallbackPage):
(WebCore::GlyphPage::~GlyphPage):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):
(WebCore::GlyphPage::removeFontDataFromSystemFallbackPage):
(WebCore::GlyphPage::GlyphPage):
(WebCore::GlyphPage::hasPerGlyphFontData):
(GlyphPage):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

7:38 AM Changeset in webkit [143600] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] MediaPlayerPrivateBlackBerry: include Logging.h
https://bugs.webkit.org/show_bug.cgi?id=110455

Patch by Xan Lopez <xlopez@rim.com> on 2013-02-21
Reviewed by Eric Carlson.

LOG is used in this file, so it is needed.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
7:33 AM Changeset in webkit [143599] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Invalid use of COMPILE_ASSERT macro in WebKitTextCodec.cpp
https://bugs.webkit.org/show_bug.cgi?id=110437

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-21
Reviewed by Yong Li.

  • Api/WebKitTextCodec.cpp:

(WebKit): Define COMPILE_ASSERT_MATCHING_ENUM() macro and use it to
check enum values match between WebKit and WTF.
(BlackBerry::WebKit::base64Decode): Use a static cast directly to
convert from WebKit Base64DecodePolicy to WTF.
(BlackBerry::WebKit::base64Encode): Use a static cast directly to
convert from WebKit Base64EncodePolicy to WTF.

6:57 AM Changeset in webkit [143598] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Add animation class for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110132

Reviewed by Kent Tamura.

Adding animation related classes as part of the calendar picker
redesign(Bug 109439).

No new tests. Code is not used yet.

  • Resources/pagepopups/calendarPicker.js:

(AnimationTimingFunction.Linear): Parameter t should be a number between 0 and 1.
(AnimationTimingFunction.EaseInOut): Ditto.
(AnimationManager): All animators are managed by this class so we
can dispatch "animationFrameWillFinish" event after all the updates.
(AnimationManager.prototype._startAnimation):
(AnimationManager.prototype._stopAnimation):
(AnimationManager.prototype.add): Adds an animator to the list of running animators.
(AnimationManager.prototype.remove): Removes an animator.
(AnimationManager.prototype._animationFrameCallback): Callback for requestAnimationFrame.
(AnimationManager.prototype._needsAnimationFrame): Returns true if we should request the next animation frame.
(AnimationManager.prototype.on): If we add a callback, request animation frame.
(AnimationManager.prototype.removeListener):
(Animator): Animates between the from value and to value.
(Animator.prototype.setFrom): Sets the from value.
(Animator.prototype.setTo): Sets the to value.
(Animator.prototype.start):
(Animator.prototype.stop):
(Animator.prototype.onAnimationFrame): Called by AnimationManager.

6:49 AM WebKitGTK/Releasing edited by Carlos Garcia Campos
(diff)
6:26 AM Changeset in webkit [143597] by aandrey@chromium.org
  • 4 edits in trunk

Web Inspector: [Canvas] UI: more intuitive control buttons
https://bugs.webkit.org/show_bug.cgi?id=110327

Reviewed by Pavel Feldman.

Source/WebCore:

Tweaks to the CanvasProfiler replay control buttons.

  • NextDrawCall forward button (StepOver) should jump up to the last expanded node, otherwise a noop is not intuitive unless the last node is selected.
  • NextDrawCall/PrevDrawCall buttons should not skip draw call nodes themselves.
  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):

LayoutTests:

  • inspector/profiler/canvas2d/canvas-replay-log-grid.html:
6:19 AM Changeset in webkit [143596] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebCore

Make SpellCheckRequest's constructor private.
https://bugs.webkit.org/show_bug.cgi?id=110462

Reviewed by Antonio Gomes.

It's no need to expose SpellCheckRequest's constructor.
There is SpellCheckRequest::create() method which is
responsible for creating SpellCheckRequest object.

No new tests, no behavior change.

  • editing/SpellChecker.h:

(SpellCheckRequest):

6:15 AM Changeset in webkit [143595] by aandrey@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Canvas] Remove arrays of DataGrid nodes from the View
https://bugs.webkit.org/show_bug.cgi?id=110325

Reviewed by Pavel Feldman.

Remove arrays of DataGrid nodes from the CanvasProfileView and use live DataGrid instead.
This is a prerequisite to support a non-fixed layered tree in the grid (for example, to hide
a single frame group node, or to combine several draw call groups into a pattern group).
Drive-by: added an assert to injected canvas module.

  • inspector/InjectedScriptCanvasModuleSource.js:
  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileView.prototype._requestTraceLog):
(WebInspector.CanvasProfileView.prototype._selectedCallIndex):
(WebInspector.CanvasProfileView.prototype._peekLastRecursively):
(WebInspector.CanvasProfileView.prototype._appendCallNodes):
(WebInspector.CanvasProfileView.prototype.):
(WebInspector.CanvasProfileView.prototype.splitDrawCallGroup):
(WebInspector.CanvasProfileView.prototype._appendCallNodesToFrameNode):

6:13 AM Changeset in webkit [143594] by mikhail.pozdnyakov@intel.com
  • 4 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/fast/dom/constructed-objects-prototypes-expected.txt: Rebaselining after r143505.
  • platform/efl/fast/js/global-constructors-expected.txt: Ditto.
  • platform/efl/TestExpectations: Added editing/spelling/spelling-changed-text.html after r143470.
6:08 AM Changeset in webkit [143593] by apavlov@chromium.org
  • 29 edits
    2 deletes in trunk

Source/WebCore: Web Inspector: Local/session storage tree items in the Resources panel after page refresh are not shown
Re-landing r143581 with a build fix for Windows.
https://bugs.webkit.org/show_bug.cgi?id=109572

Reviewed by Vsevolod Vlasov.

This is a complete rework of the DOMStorage domain of the Web Inspector protocol. The most notable changes:

  • Session and local DOM storages are considered to implicitly exist for each SecurityOrigin in the page (previously, only those that were lazily created by DOMWindow would exist).
  • Consequently, the addDOMStorage event is gone.
  • StorageId is now an object rather than an opaque numeric identifier.
  • DOM storage modifiers no longer return a boolean indicating if the operation was successful. Clients should rely on the returned error message instead.

Implementation changes:

  • InspectorDOMStorageResource would rely on the frame for which it was created throughout its lifetime. As such, the frame removal from the page would break the respective DOM storage inspection. Since this concept was entirely flawed, InspectorDOMStorageResource has been removed. Instead, a StorageArea is retrieved based on the security origin specified by the client.
  • DOM storages can now be dynamically removed (upon the respective SecurityOrigin removal) in the frontend.
  • CMakeLists.txt: Remove InspectorDOMStorageResource.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.order: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/WebCoreMemoryInstrumentation.cpp: Ditto.
  • dom/WebCoreMemoryInstrumentation.h: Ditto.
  • inspector/InjectedScriptSource.js: Account for the structured StorageId.
  • inspector/Inspector.json: Update structures and API methods. Do not return boolean success flag and make use of the error message instead.
  • inspector/InspectorAllInOne.cpp: Remove InspectorDOMStorageResource.
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController): Add InspectorPageAgent into InspectorDOMStorageAgent.

  • inspector/InspectorDOMStorageAgent.cpp: Mostly remove InspectorDOMStorageResource usages.

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::isEnabled):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems): Renamed.
(WebCore::toErrorString): Stringify ExceptionCode.
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId): Make it structured rather than a plain string.
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
(WebCore::InspectorDOMStorageAgent::findStorageArea): Added.
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage): Remove InspectorDOMStorageResource map.

  • inspector/InspectorDOMStorageAgent.h:

(WebCore::InspectorDOMStorageAgent::create): Update signature.
(InspectorDOMStorageAgent):

  • inspector/InspectorDOMStorageResource.cpp: Removed.
  • inspector/InspectorDOMStorageResource.h: Removed.
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl): Do not call the removed clearResources().

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin): Added.

  • inspector/InspectorPageAgent.h:

(InspectorPageAgent):

  • inspector/front-end/DOMStorage.js: Entirely reworked to use the SecurityOriginAdded/Removed events.

(WebInspector.DOMStorage):
(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.get securityOrigin):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):

  • inspector/front-end/DOMStorageItemsView.js: Rename Entries -> Items to avoid confusion.

(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageItems):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageItems):

  • inspector/front-end/ResourcesPanel.js: Follow the updated DOMStorage model.

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._domStorageRemoved):
(WebInspector.ResourcesPanel.prototype._populateDOMStorageTree):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):

  • page/DOMWindow.cpp: Remove instrumentation calls.

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

LayoutTests: Web Inspector: Local/session storage tree items in the Resources panel after page refresh are not shown
https://bugs.webkit.org/show_bug.cgi?id=109572

Reviewed by Vsevolod Vlasov.

  • http/tests/inspector-enabled/dom-storage-open-expected.txt:
  • http/tests/inspector-enabled/dom-storage-open.html:
6:05 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
6:04 AM WebKitGTK/2.0.x created by Carlos Garcia Campos
Add page for stable WebKitGTK+ 2.0
5:53 AM Changeset in webkit [143592] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.0

Branch WebKitGTK+ for 2.0

5:50 AM Changeset in webkit [143591] by Carlos Garcia Campos
  • 7 edits in trunk/Source

Unreviewed. Fix make distcheck.

Source/WebCore:

  • GNUmakefile.list.am: Add missing files to compilation.

Source/WebKit/gtk:

  • GNUmakefile.am: Add -DBUILDING_WEBKIT flags to introspection

scanner.

Source/WebKit2:

  • GNUmakefile.am: Add -DBUILDING_WEBKIT flags to introspection

scanner.

  • GNUmakefile.list.am: Add missing header to compilation and

remove one that no longer exists.

5:10 AM Changeset in webkit [143590] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Element::getAttributeItem() no longer returns a mutable attribute
https://bugs.webkit.org/show_bug.cgi?id=110439

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Antonio Gomes.

This was changed in r142827.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

4:40 AM Changeset in webkit [143589] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fix access to ResourceHandle::context
https://bugs.webkit.org/show_bug.cgi?id=110443

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.

This changed in r141981.

  • platform/network/blackberry/ResourceHandleBlackBerry.cpp:

(WebCore::ResourceHandle::start):

4:39 AM Changeset in webkit [143588] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Replace QWebPageAdaptor::TouchAdjuster
https://bugs.webkit.org/show_bug.cgi?id=110226

Reviewed by Antonio Gomes.

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::adjustPointForClicking):

  • WebCoreSupport/QWebPageAdapter.h:
4:38 AM Changeset in webkit [143587] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] GraphicsLayerBlackBerry: rename showDebugBorder to isShowingDebugBorder
https://bugs.webkit.org/show_bug.cgi?id=110453

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.

This changed in r133517.

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):

4:37 AM Changeset in webkit [143586] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

Web Inspector: take large strings out of CodeGeneratorInspector.py
https://bugs.webkit.org/show_bug.cgi?id=110159

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-21
Reviewed by Yury Semikhatsky.

Python script is refactored.

  • inspector/CodeGeneratorInspector.py:
  • inspector/CodeGeneratorInspectorStrings.py: Added.

(InspectorFrontend_h):
(InspectorFrontendChannel):
(InspectorArray):
(InspectorObject):
(String):
(InspectorFrontend):
(InspectorBackendDispatcher_h):
(InspectorAgent):
(InspectorBackendDispatcherImpl):
(InspectorBackendDispatcher):
(CallbackBase):
(void):
(HashMap):
(OptOutput):
(ExactlyInt):
(RuntimeCastHelper):
(provides):
(typename):
(Array):
(Builder):

4:30 AM WebKit Team edited by zarvai@inf.u-szeged.hu
add myself as committer (diff)
4:29 AM Changeset in webkit [143585] by commit-queue@webkit.org
  • 29 edits
    2 adds in trunk

Unreviewed, rolling out r143581.
http://trac.webkit.org/changeset/143581
https://bugs.webkit.org/show_bug.cgi?id=110457

Breaks Windows builds (compile + link) (Requested by apavlov
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCoreMemoryTypes):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::restore):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
(WebCore::InspectorDOMStorageAgent::clearResources):
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):

  • inspector/InspectorDOMStorageAgent.h:

(WebCore):
(WebCore::InspectorDOMStorageAgent::create):
(InspectorDOMStorageAgent):

  • inspector/InspectorDOMStorageResource.cpp: Added.

(WebCore):
(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
(WebCore::InspectorDOMStorageResource::isSameOriginAndType):
(WebCore::InspectorDOMStorageResource::bind):
(WebCore::InspectorDOMStorageResource::unbind):
(WebCore::InspectorDOMStorageResource::reportMemoryUsage):

  • inspector/InspectorDOMStorageResource.h: Added.

(WebCore):
(InspectorDOMStorageResource):
(WebCore::InspectorDOMStorageResource::create):
(WebCore::InspectorDOMStorageResource::id):
(WebCore::InspectorDOMStorageResource::storageArea):
(WebCore::InspectorDOMStorageResource::frame):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didUseDOMStorageImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didUseDOMStorage):
(WebCore):

  • inspector/InspectorPageAgent.cpp:
  • inspector/InspectorPageAgent.h:

(InspectorPageAgent):

  • inspector/front-end/DOMStorage.js:

(WebInspector.DOMStorage):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.get domain):
(WebInspector.DOMStorage.prototype.getEntries):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._addDOMStorage):
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._addDOMStorage):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

LayoutTests:

  • http/tests/inspector-enabled/dom-storage-open-expected.txt:
  • http/tests/inspector-enabled/dom-storage-open.html:
4:26 AM Changeset in webkit [143584] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] willComposite() and didComposite() are now in InspectorController
https://bugs.webkit.org/show_bug.cgi?id=110343

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.

This was changed in r142879.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::willComposite):
(BlackBerry::WebKit::WebPagePrivate::didComposite):

4:09 AM Changeset in webkit [143583] by vsevik@chromium.org
  • 15 edits in trunk

Web Inspector: Get rid of parsedURL in uiSourceCode, use name and path for displayName instead.
https://bugs.webkit.org/show_bug.cgi?id=110335

Reviewed by Alexander Pavlov.

Source/WebCore:

Replaced UISourceCode.parsedURL with UISourceCode.displayName().

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.displayNameForURL):

  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView.prototype._createUISourceCodeItem):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.displayName):
(WebInspector.UISourceCode.prototype.urlChanged):

Source/WebKit/chromium:

  • src/js/Tests.js:

(.TestSuite.prototype._scriptsAreParsed):

LayoutTests:

  • http/tests/inspector-enabled/dynamic-scripts.html:
  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/dynamic-scripts.html:
  • inspector/debugger/scripts-file-selector-expected.txt:
  • inspector/debugger/source-url-comment.html:
  • inspector/styles/edit-inspector-stylesheet.html:
  • inspector/styles/styles-add-new-rule.html:
3:58 AM Changeset in webkit [143582] by mikhail.pozdnyakov@intel.com
  • 5 edits in trunk/Source/WebKit2

[WK2][EFL] Move PageViewportController and PageViewportControllerClientEfl out from WebView
https://bugs.webkit.org/show_bug.cgi?id=110345

Reviewed by Andreas Kling.

WebView does not need to know about both PageViewportController and
PageViewportControllerClientEfl. Considering the fact that PageViewportController
will stop being WK2 internal and will be based on WK2 C API, it
should be owned by EwkView rather than WebView.

This patch is also a preparation for WKViewClient API extension to cover all
the places where PageViewportController and PageViewportControllerClientEfl
are accessed directly from WebView at the moment.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):

  • UIProcess/API/efl/EwkView.h:

(WebKit):
(EwkView::pageViewportControllerClient):
(EwkView::pageViewportController):
(EwkView):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::didCommitLoad):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::didChangeContentsSize):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):

  • UIProcess/efl/WebView.h:

(WebView):

3:57 AM Changeset in webkit [143581] by apavlov@chromium.org
  • 29 edits
    2 deletes in trunk

Web Inspector: Local/session storage tree items in the Resources panel after page refresh are not shown
https://bugs.webkit.org/show_bug.cgi?id=109572

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • dom/WebCoreMemoryInstrumentation.h:

(WebCoreMemoryTypes):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::isEnabled):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::toErrorString):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
(WebCore::InspectorDOMStorageAgent::findStorageArea):
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):

  • inspector/InspectorDOMStorageAgent.h:

(WebCore):
(WebCore::InspectorDOMStorageAgent::create):
(InspectorDOMStorageAgent):

  • inspector/InspectorDOMStorageResource.cpp: Removed.
  • inspector/InspectorDOMStorageResource.h: Removed.
  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
(WebCore):

  • inspector/InspectorPageAgent.h:

(InspectorPageAgent):

  • inspector/front-end/DOMStorage.js:

(WebInspector.DOMStorage):
(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.get securityOrigin):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageItems):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageItems):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._domStorageRemoved):
(WebInspector.ResourcesPanel.prototype._populateDOMStorageTree):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

LayoutTests:

  • http/tests/inspector-enabled/dom-storage-open-expected.txt:
  • http/tests/inspector-enabled/dom-storage-open.html:
3:39 AM Changeset in webkit [143580] by eustas@chromium.org
  • 18 edits in trunk

Web Inspector: [Console] Add console API message types for profile/profileEnd.
https://bugs.webkit.org/show_bug.cgi?id=109790

Reviewed by Pavel Feldman.

With profile/profileEnd message types we will gain more control over
output messages.

  • English.lproj/localizedStrings.js: Added corresponging strings.
  • inspector/ConsoleAPITypes.h: Added enum members.
  • inspector/Inspector.json: Ditto.
  • inspector/front-end/ConsoleModel.js: Ditto.
  • inspector/ConsoleMessage.cpp:

(WebCore::messageTypeValue): Added cases.

  • inspector/InspectorProfilerAgent.cpp: Adopted changes.
  • inspector/front-end/inspector.js: Ditto.
  • inspector/front-end/ConsoleMessage.js:

Added message generators for introduced message types.

  • inspector/front-end/ProfilesPanel.js:

Turned showProfileForURL(url) to showProfile(typeId, uid).

  • inspector/front-end/ProfilesPanelDescriptor.js:

(WebInspector.ProfilesPanelDescriptor.resolveProfileTitle): Added.

  • inspector/front-end/ResourceUtils.js: Removed linkifier plugins.
2:44 AM Changeset in webkit [143579] by zarvai@inf.u-szeged.hu
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk2/TestExpectations: Skip failing reftests.
  • platform/qt/TestExpectations: Skip failing tests after r143541 and r110447.
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Rebaselining after r143505.
  • platform/qt/fast/js/global-constructors-expected.txt: Rebaselining after r143505.
2:43 AM Changeset in webkit [143578] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebCore

OpenCL implementation of FEMerge filter.
https://bugs.webkit.org/show_bug.cgi?id=110193

Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-21
Reviewed by Zoltan Herczeg.

In case of odd number of parameters the first parameter is copied to the destination image and
the rest of the parameters are merged in pairs.

  • Target.pri:
  • platform/graphics/filters/FEMerge.h:

(FEMerge):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.h:

(WebCore::FilterContextOpenCL::FilterContextOpenCL):
(FilterContextOpenCL):

  • platform/graphics/gpu/opencl/OpenCLFEMerge.cpp: Added.

(WebCore):
(WebCore::FilterContextOpenCL::compileFEMerge):
(WebCore::FilterContextOpenCL::copy): This is a simple copy method.
(WebCore::FilterContextOpenCL::applyFEMerge):
(WebCore::FEMerge::platformApplyOpenCL):

2:26 AM Changeset in webkit [143577] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for tests introduced in r143470 and r143541.
  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Rebaselining after r143505.
  • platform/gtk/fast/js/global-constructors-expected.txt: Ditto.
2:16 AM Changeset in webkit [143576] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Add event dispatch class for the new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110131

Reviewed by Kent Tamura.

Adding event dispatcher class as part of the new calendar picker patch at Bug 109439.

No new tests. Code is not yet used.

  • Resources/pagepopups/calendarPicker.js:

(EventEmitter):
(EventEmitter.prototype.on): Adds a callback for an event.
(EventEmitter.prototype.hasListener): Returns true if more than one listeners exist for an event type.
(EventEmitter.prototype.removeListener): Removes an event listener.
(EventEmitter.prototype.dispatchEvent): Dispatches an event to all callbacks. Takes variable number of arguments.

2:09 AM Changeset in webkit [143575] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipped failing inpector tests after r143300.
https://bugs.webkit.org/show_bug.cgi?id=110440.

  • platform/qt/TestExpectations:
1:18 AM Changeset in webkit [143574] by commit-queue@webkit.org
  • 10 edits
    5 adds in trunk

Web Inspector: Add command for selecting files for file input element
https://bugs.webkit.org/show_bug.cgi?id=109308

Patch by Ken Kania <kkania@chromium.org> on 2013-02-21
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector-protocol/dom/setFileInputFiles.html

  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::canSetFileInputFiles):
(InspectorClient):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::setFileInputFiles):
(WebCore):

  • inspector/InspectorDOMAgent.h:

(WebCore):
(WebCore::InspectorDOMAgent::create):
(InspectorDOMAgent):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::canSetFileInputFiles):
(WebKit):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

LayoutTests:

  • inspector-protocol/dom/setFileInputFiles-expected.txt: Added.
  • inspector-protocol/dom/setFileInputFiles.html: Added.
  • platform/chromium/inspector-protocol/dom/setFileInputFiles-expected.txt: Added.
1:04 AM Changeset in webkit [143573] by commit-queue@webkit.org
  • 37 edits
    1 move
    2 adds in trunk

Source/WebCore: [Web Inspector]Add WebSocket networking events in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=105527.

Patch by Pan Deng <pan.deng@intel.com> on 2013-02-21
Reviewed by Pavel Feldman.

This patch add four WebSocket networking events in Timeline panel. The Events
are CreateWebSocket, SendWebSocketHandshakeRequest, ReceiveWebSocketHandShakeResponse
and DestoryWebSocket. Thanks to Kitamura san's previous work.

Test: http/tests/inspector/websocket/timeline-websocket-event.html

  • English.lproj/localizedStrings.js:
  • Modules/websockets/WebSocketChannel.cpp: Add protocol information

(WebCore::WebSocketChannel::connect):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl): Add Timeline agent instrumentation for websocket
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): Ditto
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): Ditto
(WebCore::InspectorInstrumentation::didCloseWebSocketImpl): Ditto

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):
(WebCore):
(WebCore::InspectorTimelineAgent::didCreateWebSocket): Add Timeline record for websocket create
(WebCore::InspectorTimelineAgent::addWebSocketRecord): Add general websocket record
(WebCore::InspectorTimelineAgent::willSendWebSocketHandshakeRequest): Add Timeline record for websocket handshake request send
(WebCore::InspectorTimelineAgent::didReceiveWebSocketHandshakeResponse): Add Timeline record for websocket handshake response receive
(WebCore::InspectorTimelineAgent::didDestroyWebSocket): Add Timeline record for websocket destroy

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(InspectorTimelineAgent):

  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):
(WebCore::TimelineRecordFactory::createWebSocketCreateData):
(WebCore::TimelineRecordFactory::createGenericWebSocketData):

  • inspector/front-end/TimelineModel.js: Add Timeline record type for websocket
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel._initRecordStyles):
(WebInspector.TimelinePresentationModel.prototype.reset): Add slot to store WebSocket Create record
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview): Add PopupContent for websocket record, including url and protocol

LayoutTests: [Web Inspector]Add WebSocket networking events in WebInspector Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=105527.

Patch by Pan Deng <pan.deng@intel.com> on 2013-02-21
Reviewed by Pavel Feldman.

This change add the record event type to test expections. The Events are CreateWebSocket,
SendWebSocketHandshakeRequest, ReceiveWebSocketHandShakeResponse and DestoryWebSocket.
timeline-test.js was moved to http folder, since new added websocket test need it from server side.

  • http/tests/inspector/timeline-test.js: Renamed from LayoutTests/inspector/timeline/timeline-test.js.

(initialize_Timeline.InspectorTest.startTimeline.addRecord):
(initialize_Timeline.InspectorTest.startTimeline):
(initialize_Timeline.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
(initialize_Timeline.InspectorTest.stopTimeline):
(initialize_Timeline.step1):
(initialize_Timeline.step2):
(initialize_Timeline.InspectorTest.evaluateWithTimeline):
(initialize_Timeline.):
(initialize_Timeline.InspectorTest.performActionsAndPrint):
(initialize_Timeline.InspectorTest.printTimelineRecords):
(initialize_Timeline.InspectorTest.printTimestampRecords):
(initialize_Timeline.InspectorTest.innerPrintTimelineRecords):
(initialize_Timeline.InspectorTest.dumpTimelineRecord):
(initialize_Timeline.InspectorTest.dumpTimelineRecords):
(initialize_Timeline.InspectorTest.printTimelineRecordProperties):
(initialize_Timeline.InspectorTest._timelineAgentTypeToString):
(initialize_Timeline.InspectorTest.findPresentationRecord.findByType):
(initialize_Timeline.InspectorTest.findPresentationRecord):
(initialize_Timeline.InspectorTest.FakeFileReader):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.start):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.cancel):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.loadedSize):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.fileSize):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.fileName):
(initialize_Timeline.InspectorTest):
(initialize_Timeline):

  • http/tests/inspector/websocket/timeline-websocket-event-expected.txt: Added.
  • http/tests/inspector/websocket/timeline-websocket-event.html: Added.
  • inspector/timeline/timeline-animation-frame.html: Modify address of script "timeline-test.js"
  • inspector/timeline/timeline-decode-resize.html:
  • inspector/timeline/timeline-dom-content-loaded-event.html:
  • inspector/timeline/timeline-enum-stability-expected.txt:
  • inspector/timeline/timeline-event-dispatch.html:
  • inspector/timeline/timeline-frames.html:
  • inspector/timeline/timeline-injected-script-eval.html:
  • inspector/timeline/timeline-layout-reason.html:
  • inspector/timeline/timeline-layout.html:
  • inspector/timeline/timeline-load-event.html:
  • inspector/timeline/timeline-load.html:
  • inspector/timeline/timeline-mark-timeline.html:
  • inspector/timeline/timeline-network-received-data.html:
  • inspector/timeline/timeline-network-resource.html:
  • inspector/timeline/timeline-paint.html:
  • inspector/timeline/timeline-parse-html.html:
  • inspector/timeline/timeline-recalculate-styles.html:
  • inspector/timeline/timeline-receive-response-event.html:
  • inspector/timeline/timeline-script-tag-1.html:
  • inspector/timeline/timeline-script-tag-2.html:
  • inspector/timeline/timeline-start-time.html:
  • inspector/timeline/timeline-time-stamp.html:
  • inspector/timeline/timeline-time.html:
  • inspector/timeline/timeline-timer-fired-from-eval-call-site.html:
  • inspector/timeline/timeline-timer.html:
  • inspector/timeline/timeline-trivial.html:
1:03 AM Changeset in webkit [143572] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Remove obsolete DEPENDPATH assignment

Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2013-02-21
Reviewed by Simon Hausmann

qmake now adds CONFIG+=depend_includepath by default, making manual
DEPENDPATH setup unnecessary.

  • qmake/mkspecs/features/default_post.prf:
1:01 AM Changeset in webkit [143571] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Fix pkg-config dependencies of QtWebKit itself

Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2013-02-21
Reviewed by Simon Hausmann.

Don't override QMAKE_PKGCONFIG_REQUIRES needlessly.

  • WebCore.pri:
1:00 AM Changeset in webkit [143570] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

File upload control doesn't apply CSS vertical padding or border to file name
https://bugs.webkit.org/show_bug.cgi?id=109011

Patch by Nils Barth <nbarth@google.com> on 2013-02-21
Reviewed by Hajime Morrita.

Source/WebCore:

Test: fast/forms/file/file-vertical-padding-border.html

  • rendering/RenderFileUploadControl.cpp:

Add borderTop() and paddingTop() when computing position.

(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

  • fast/forms/file/file-vertical-padding-border.html: Added.
  • fast/forms/file/file-vertical-padding-border-expected.html: Added.
12:27 AM Changeset in webkit [143569] by ap@apple.com
  • 9 edits in trunk/Source/WebCore

Stop hardcoding knowledge about blob protocol in ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=110382

Reviewed by Anders Carlsson.

  • platform/network/BlobRegistry.h:
  • platform/network/chromium/BlobRegistryProxy.h: Removed loadResourceSynchronously(). Chromium did not even implement it, and cross-platform code doesn't need it any more either.
  • platform/network/BlobRegistryImpl.cpp: (WebCore::loadResourceSynchronously): A function to load a blob synchronously, suitable for being in a ResourceHandle map. (WebCore::registerBlobResourceHandleConstructor): Register loadResourceSynchronously too. (WebCore::BlobRegistryImpl::createResourceHandle): Don't make policy decisions here, it's just a registry. Moved code for checking request method down to BlobResourceHandle.
  • platform/network/BlobRegistryImpl.h: Removed BlobRegistryImpl::loadResourceSynchronously(). A registry shouldn't load resources, and it already has enough accessors to implement this externally.
  • platform/network/BlobResourceHandle.h:
  • platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::createAsync): Renamed from create(), to make it clear that it's not OK to call from synchronous loader. Moved method check here. (WebCore::BlobResourceHandle::loadResourceSynchronously): Moved method check here. We used to fall through to NSURLConnection based loader when method was not GET, which of course resulted in an error eventually, but was just wrong.
  • platform/network/ResourceHandle.cpp: (WebCore::builtinResourceHandleSynchronousLoaderMap): Added a map for synchronous case. (WebCore::ResourceHandle::registerBuiltinSynchronousLoader): Ditto. (WebCore::ResourceHandle::loadResourceSynchronously): We no longer need to hardcode knowledge about blobRegistry and blobs here.
  • platform/network/ResourceHandle.h: Added registerBuiltinSynchronousLoader().
  • platform/network/chromium/ResourceHandle.h: Removed loadResourceSynchronously(), which was not implemented for Chromium.

Feb 20, 2013:

11:54 PM CoordinatedGraphicsSystem edited by cwhong@company100.net
New dorothybrowser site! (diff)
11:53 PM Changeset in webkit [143568] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: TabbedEditorContainer and OpenResourceDialog should show uiSourceCode path and name instead of parsedURL
https://bugs.webkit.org/show_bug.cgi?id=110334

Reviewed by Alexander Pavlov.

Source/WebCore:

Introduced uiSourceCode.name() that returns a name based on uiSourceCode path.
OpenResourceDialog now shows uiSourceCode workspace path as a subtitle.
TabbedEditorContainer now shows uiSourceCode name in the tab header.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemSubtitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype._updateScriptTitle):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._titleForFile):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.name):

LayoutTests:

  • inspector/debugger/scripts-file-selector-expected.txt:
  • inspector/debugger/ui-source-code-display-name-expected.txt:
  • inspector/debugger/ui-source-code-display-name.html:
11:33 PM Changeset in webkit [143567] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: debugger buttons are scrolled along with the sidebar content.
https://bugs.webkit.org/show_bug.cgi?id=110434

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/scriptsPanel.css:

(div.sidebar-pane-stack#scripts-debug-sidebar-contents, #scripts-sidebar-stack-pane):

11:21 PM Changeset in webkit [143566] by pfeldman@chromium.org
  • 2 edits in branches/chromium/1410/Source/WebCore/inspector/front-end

Merge 143437

Web Inspector: View.markAsRoot should never be invoked on attached view.
https://bugs.webkit.org/show_bug.cgi?id=110224

Reviewed by Pavel Feldman.

This will cause CSS loading problems after "show".

  • inspector/front-end/Drawer.js:

Ensure child view is detached before marked as root.

  • inspector/front-end/View.js:

(WebInspector.View.prototype.markAsRoot): Added assertion.

TBR=eustas@chromium.org
BUG=176912
Review URL: https://codereview.chromium.org/12320033

10:34 PM Changeset in webkit [143565] by james.wei@intel.com
  • 3 edits in trunk/Source/WebCore

ChannelMergerNode may need check for deferred updating of output channels
https://bugs.webkit.org/show_bug.cgi?id=108863

There can in rare cases be a slight delay before the output bus is updated
to the new number of channels because of tryLocks() in the context's
updating system. So need to check the channel number before processing.

Reviewed by Chris Rogers.

  • Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::ChannelMergerNode):
(WebCore::ChannelMergerNode::process):
(WebCore::ChannelMergerNode::checkNumberOfChannelsForInput):

  • Modules/webaudio/ChannelMergerNode.h:

(ChannelMergerNode):

10:26 PM Changeset in webkit [143564] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Web Inspector] Fix Sort by Initiator functionality of Network Panel.
https://bugs.webkit.org/show_bug.cgi?id=109135.

Patch by Pan Deng <pan.deng@intel.com> on 2013-02-20
Reviewed by Pavel Feldman.

A refactor for request initiator types, and the sort by Initiator functionality
was changed to sort by url and line number that displayed in initiator cell.

No new tests.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell): save initiator displayedURL and displayedLineNumber
(WebInspector.NetworkDataGridNode.InitiatorComparator):

  • inspector/front-end/NetworkRequest.js:
9:36 PM Changeset in webkit [143563] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

WebVTTParser copies character buffer more often than necessary
https://bugs.webkit.org/show_bug.cgi?id=103319

Reviewed by Eric Carlson.

Previously this codepath was creating a String just to parse the timestamp
and then if the timestamp was valid, was creating a second string.
I've fixed it to only create one string and use it in both places.
I also fixed this codepath to use 8bit strings when possible, per the FIXME.

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken):

8:58 PM Changeset in webkit [143562] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG::SpeculativeJIT::compileInt32ToDouble() has an unnecessary case for constant operands
https://bugs.webkit.org/show_bug.cgi?id=110309

Reviewed by Sam Weinig.

It used to be necessary, back when we didn't have constant folding. Now we have
constant folding. So we don't need it.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):

8:38 PM Changeset in webkit [143561] by vivek.vg@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Changing primary email id.

8:21 PM Changeset in webkit [143560] by mkwst@chromium.org
  • 3 edits
    4 adds in trunk

Mouseup event does not fire on Scroll Bar
https://bugs.webkit.org/show_bug.cgi?id=25811

Reviewed by Tony Chang.

Source/WebCore:

Currently, clicking on a scrollbar fires a mousedown event, but not a
mouseup event. This causes problems for code like jQuery UI's
draggable[1], as the drag starts, but is never cancelled. Other use
cases are noted in the slightly old Chromium bug[2].

If a mouseup event is received after a mousedown event on a scrollbar,
this patch dispatches a mouseup event on the same node the mousedown
event dispatched on. This matches Gecko's behavior.

[1]: http://bugs.jqueryui.com/ticket/6925
[2]: http://crbug.com/14204

Tests: fast/scrolling/scrollbar-mousedown-mouseup.html

fast/scrolling/scrollbar-mousedown-move-mouseup.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):

If a mouseup event follow a mousedown event on a scrollbar,
dispatch an event on the same node from which the mousedown event
was triggered.

LayoutTests:

  • fast/scrolling/scrollbar-mousedown-mouseup-expected.txt: Added.
  • fast/scrolling/scrollbar-mousedown-mouseup.html: Added.
  • fast/scrolling/scrollbar-mousedown-move-mouseup-expected.txt: Added.
  • fast/scrolling/scrollbar-mousedown-move-mouseup.html: Added.
7:58 PM Changeset in webkit [143559] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, update TestExpectations.

  • platform/chromium/TestExpectations:
7:51 PM Changeset in webkit [143558] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Provide WKView SPI to defer telling the WebPageProxy and WebProcess about changes in the hosting window
https://bugs.webkit.org/show_bug.cgi?id=110415
<rdar://problem/13095405>

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKView.mm: Add _viewInWindowChangesDeferredCount and _viewInWindowChangeWasDeferred to WKViewData.

(-[WKView viewDidMoveToWindow]): If we're deferring window changes, don't include the ViewIsInWindow flag
when sending viewStateDidChange. Instead, save the fact that we want to do that later aside.
(-[WKView beginDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChanges]): Straightforward begin/end pair. When we exit the last pair and
have a pending window change, let the WebPageProxy know. WebPageProxy will do the check to ensure that
the in-window state has actually changed.
(-[WKView isDeferringViewInWindowChanges]):

  • UIProcess/API/mac/WKViewPrivate.h:
7:50 PM Changeset in webkit [143557] by toyoshim@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed gardening, add chromium-mac specific expectation image.

  • platform/chromium-mac/fast/repaint/paint-caret-in-div-with-negative-indent-expected.png: Added.
7:39 PM Changeset in webkit [143556] by tasak@google.com
  • 13 edits in trunk/Source/WebCore

[Refactoring] Make m_state an on-stack object
https://bugs.webkit.org/show_bug.cgi?id=109909

Reviewed by Antti Koivisto.

Mode m_state, an instance of StyleResolver::State, an on-stack object.
The state is only required in styleForElement, styleForKeyframe and
so on. No need to keep the state outside of those methods.

No new tests, because just refactoring.

  • css/BasicShapeFunctions.cpp:

(WebCore::convertToLength):
(WebCore::basicShapeForValue):

  • css/BasicShapeFunctions.h:

(WebCore):
Replaced StyleResolver* with StyleResolver::State&.

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::gradientWithStylesResolved):

  • css/CSSGradientValue.h:

(CSSGradientValue):
Replaced StyleResolver* with StyleResolver::State&.

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::style):
(WebCore::CSSToStyleMap::rootElementStyle):
(WebCore::CSSToStyleMap::useSVGZoomRules):
(WebCore::CSSToStyleMap::styleImage):

  • css/CSSToStyleMap.h:

(WebCore):
(WebCore::CSSToStyleMap::CSSToStyleMap):
(CSSToStyleMap):
Replaced StyleResolver* with StyleResolver::State&.

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):
Replaced m_state with state which is given as an argument of
applySVGProperty.

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyExclusionShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):

  • css/StyleBuilder.h:

(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
Replaced StyleResolver* with StyleResolver::State&.

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::StyleResolver):
Removed m_styleMap. Now m_styleMap is an on-stack object.
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::findSiblingForStyleSharing):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyWithNullCheck):
(WebCore::StyleResolver::applyFontPropertyToStyle):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::checkForZoomChange):
(WebCore::StyleResolver::checkForGenericFamilyChange):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::styleShader):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createCustomFilterOperation):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::loadPendingResources):
Just replaced m_state with state and added one more parameter to
provide the state.
(WebCore::StyleResolver::reportMemoryUsage):
Since m_state was removed, removed a code for reporting m_state's
memory usage.

  • css/StyleResolver.h:

(StyleResolver):
(WebCore::StyleResolver::isRightPage):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::document):
Since State::m_element is not always available (sometimes, 0),
added m_document to State and modified to return the m_document.
(WebCore::StyleResolver::State::useSVGZoomRules):
Moved StyleResolver to State.
(State):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):
Moved the code, updating a style by using a given StylePropertySet,
to StyleResolver.

7:26 PM Changeset in webkit [143555] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

AutoTableLayout applies min-width redundantly with RenderTable
https://bugs.webkit.org/show_bug.cgi?id=110426

Reviewed by Emil A Eklund.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::computePreferredLogicalWidths):
This code used to do something, but has since been superceded by
code in RenderTable::computePreferredLogicalWidths.

7:22 PM Changeset in webkit [143554] by krit@webkit.org
  • 4 edits in trunk

Enable CANVAS_PATH flag
https://bugs.webkit.org/show_bug.cgi?id=108508

Source/WebCore:

Uneviewed attempt to fix Qt minimal build.

  • html/canvas/DOMPath.h:

(WebCore::DOMPath::DOMPath):

LayoutTests:

Reviewed by Simon Fraser.

Unreviewed rebaseline after landing patch.

  • fast/dom/constructed-objects-prototypes-expected.txt:
6:43 PM Changeset in webkit [143553] by fpizlo@apple.com
  • 3 edits
    2 adds in trunk

DFG inlines Resolves that it doesn't know how to handle correctly
https://bugs.webkit.org/show_bug.cgi?id=110405

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Don't try to be clever: if there's a failing resolve, we can't inline it, period.

  • dfg/DFGCapabilities.h:

(JSC::DFG::canInlineResolveOperations):
(JSC::DFG::canInlineOpcode):

LayoutTests:

Reviewed by Geoffrey Garen.

  • fast/js/dfg-inline-resolve-expected.txt: Added.
  • fast/js/dfg-inline-resolve.html: Added.
6:41 PM Changeset in webkit [143552] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Disable window occlusion notifications for App Store on Mac.
https://bugs.webkit.org/show_bug.cgi?id=110417

Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-20
Reviewed by Simon Fraser.

Temporary fix to workaround issues with window occlusion notifications
in App Store.

  • UIProcess/API/mac/WKView.mm:

(+[WKView _registerWindowOcclusionNotificationHandlers]): Return early
if the main bundle identifier matches that of App Store.

6:36 PM Changeset in webkit [143551] by mark.lam@apple.com
  • 24 edits
    2 moves in trunk/Source/WebCore

\2013-02-20 Mark Lam <mark.lam@apple.com>

Rename DatabaseBackendAsync to DatabaseBackend.
https://bugs.webkit.org/show_bug.cgi?id=110422.

Reviewed by Geoffrey Garen.

This is a purely cosmetic change to make the naming consistent with
the front-end Database.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webdatabase/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::from):
(WebCore::Database::backend):

  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackendAsync.cpp.

(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::openAndVerifyVersion):
(WebCore::DatabaseBackend::performOpenAndVerify):
(WebCore::DatabaseBackend::close):
(WebCore::DatabaseBackend::runTransaction):
(WebCore::DatabaseBackend::inProgressTransactionCompleted):
(WebCore::DatabaseBackend::scheduleTransaction):
(WebCore::DatabaseBackend::scheduleTransactionStep):
(WebCore::DatabaseBackend::transactionClient):
(WebCore::DatabaseBackend::transactionCoordinator):

  • Modules/webdatabase/DatabaseBackend.h: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackendAsync.h.
  • Modules/webdatabase/DatabaseBackendAsync.cpp: Removed.
  • Modules/webdatabase/DatabaseBackendAsync.h: Removed.
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::~DatabaseBackendBase):

  • Modules/webdatabase/DatabaseManager.cpp:
  • Modules/webdatabase/DatabaseServer.cpp:
  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseTask::DatabaseTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::~DatabaseTransactionTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::debugTaskName):

  • Modules/webdatabase/DatabaseTask.h:

(WebCore::DatabaseTask::database):
(DatabaseTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::create):
(DatabaseBackend::DatabaseOpenTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::create):
(DatabaseBackend::DatabaseCloseTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::create):
(DatabaseBackend::DatabaseTableNamesTask):

  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):
(WebCore::SameDatabasePredicate::SameDatabasePredicate):
(SameDatabasePredicate):
(WebCore::DatabaseThread::unscheduleDatabaseTasks):

  • Modules/webdatabase/DatabaseThread.h:
  • Modules/webdatabase/SQLStatementBackend.cpp:

(WebCore::SQLStatementBackend::execute):
(WebCore::SQLStatementBackend::setDatabaseDeletedError):
(WebCore::SQLStatementBackend::setVersionMismatchedError):
(WebCore::SQLStatementBackend::setFailureDueToQuota):

  • Modules/webdatabase/SQLStatementBackend.h:
  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):

  • Modules/webdatabase/SQLTransactionBackend.h:

(WebCore::SQLTransactionBackend::database):

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::getDatabaseIdentifier):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
6:25 PM Changeset in webkit [143550] by ddkilzer@apple.com
  • 3 edits
    1 add in trunk/Source/WebCore

Upstream SharedTimerIOS.mm
<http://webkit.org/b/110161>

Reviewed by Benjamin Poulain.

  • Configurations/WebCore.xcconfig:

(EXCLUDED_SOURCE_FILE_NAMES_iphoneos): Add SharedTimerMac.mm.

  • WebCore.xcodeproj/project.pbxproj: Add SharedTimerIOS.mm.
  • platform/ios/SharedTimerIOS.mm: Add.

(WebCore):
(-[WebCoreResumeNotifierIOS init]):
(-[WebCoreResumeNotifierIOS dealloc]):
(-[WebCoreResumeNotifierIOS didWake]):
(WebCore::setSharedTimerFiredFunction):
(WebCore::timerFired):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

6:24 PM Changeset in webkit [143549] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Speculative fix for EFL and Windows compilers not realizing
that all possible cases have a return value from this switch.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

6:20 PM Changeset in webkit [143548] by commit-queue@webkit.org
  • 4 edits
    1 add
    16 deletes in trunk/LayoutTests

Convert residual-style.html test to a reftest (and fix typos)
https://bugs.webkit.org/show_bug.cgi?id=109981

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-20
Reviewed by Darin Adler.

  • fast/flexbox/box-orient-button.html: clsas->class
  • fast/flexbox/resources/box-orient-button.js: DTR->DRT
  • fast/invalid/residual-style-expected.html: Added. New reftest

version. Note that some lines are red, which is
https://bugs.webkit.org/show_bug.cgi?id=109984

  • fast/invalid/residual-style.html: Add missing semicolon in <style>.

Also close a few more <font> tags, so that the descriptive text is
in black as it should be.

  • platform/chromium-android/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-android/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-linux/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-win/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-win/fast/invalid/residual-style-expected.txt: Removed.
  • platform/efl/fast/invalid/residual-style-expected.png: Removed.
  • platform/efl/fast/invalid/residual-style-expected.txt: Removed.
  • platform/gtk/fast/invalid/residual-style-expected.png: Removed.
  • platform/gtk/fast/invalid/residual-style-expected.txt: Removed.
  • platform/mac/fast/invalid/residual-style-expected.png: Removed.
  • platform/mac/fast/invalid/residual-style-expected.txt: Removed.

Removed old expectation files.

6:09 PM Changeset in webkit [143547] by jamesr@google.com
  • 5 edits in trunk

[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
https://bugs.webkit.org/show_bug.cgi?id=109634

Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebUnitTestSupport.h:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):

6:02 PM Changeset in webkit [143546] by hyatt@apple.com
  • 9 edits in trunk

[New Multicolumn] Fix overflow computation for column blocks.
https://bugs.webkit.org/show_bug.cgi?id=110392.

Reviewed by Simon Fraser.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addOverflowFromChild):
Exclude in-flow RenderFlowThreads from overflow propagation.

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderRegion.h:

(WebCore::RenderRegion::shouldHaveAutoLogicalHeight):

  • rendering/RenderRegionSet.h:

(RenderRegionSet):
Override shouldHaveAutoLogicalHeight to always be false
for region sets and for columns. Eventually we're going to try
to leverage this code to do column balancing, and that's why
RenderMultiColumnSet has a unique override.

LayoutTests:

  • fast/multicol/newmulticol/column-rules-fixed-height-expected.html:
  • fast/multicol/newmulticol/column-rules-fixed-height.html:
5:35 PM Changeset in webkit [143545] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Printing WebGL canvases in Chrome uses stale data after first print
https://bugs.webkit.org/show_bug.cgi?id=110003

Patch by Brandon Jones <bajones@google.com> on 2013-02-20
Reviewed by Kenneth Russell.

Unable to validate printed content automatically. No regression in existing WebGL tests.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore): (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
5:29 PM Changeset in webkit [143544] by mrowe@apple.com
  • 7 edits
    1 move
    1 delete in trunk/Source/WebKit2

<https://webkit.org/b/110410> Specify the plug-in process / service entitlements via the Xcode configuration.

This is the modern mechanism for applying entitlements to production builds,
and it simplifies the maintenance of entitlements going forward. It also allows
us to fix the new XPC PluginServices to have the same entitlements as PluginProcess.

Reviewed by Alexey Proskuryakov.

  • Configurations/Base.xcconfig: Ad-hoc sign all WebKit2 components.
  • Configurations/PluginProcess.xcconfig: Specify the entitlements to use.
  • Configurations/PluginService.32.xcconfig: Ditto.
  • Configurations/PluginService.64.xcconfig: Ditto.
  • Configurations/PluginService.Development.xcconfig: Ditto.
  • Configurations/PluginService.entitlements: Renamed from Source/WebKit2/PluginProcess/mac/PluginProcess.entitlements.

Move the entitlements in to the Configurations directory to make them easier to find.

  • PluginProcess/mac/add-entitlements.sh: Removed. In my testing the dependency issue mentioned

in the script is not an issue with current versions of Xcode. If we see it again we can come
up with a workaround that doesn't involve performing the signing via a script phase.

  • WebKit2.xcodeproj/project.pbxproj:
5:29 PM Changeset in webkit [143543] by mrowe@apple.com
  • 3 edits
    1 move
    1 delete in trunk/Source/WebKit2

<https://webkit.org/b/110409> Remove duplication between 32- and 64-bit PluginService plists.

Reviewed by Dan Bernstein.

The only difference between the plists was the CFBundleIdentifier. Since the values are the
same as the product name, we can just use the value of the PRODUCT_NAME configuration setting.

  • Configurations/PluginService.32.xcconfig:
  • Configurations/PluginService.64.xcconfig:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist: Renamed from Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist: Removed.
5:22 PM Changeset in webkit [143542] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Incorrect rendering for flex boxes with percentage height in a table cell
https://bugs.webkit.org/show_bug.cgi?id=110389

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

Source/WebCore:

Tests: css3/flexbox/flex-percentage-height-in-table-standards-mode.html

css3/flexbox/flex-percentage-height-in-table.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
Always update the logical height of the flex box, not just when it is
auto. If necessary, the later updateLogicalHeight() call will adjust
it.

LayoutTests:

  • css3/flexbox/flex-percentage-height-in-table-expected.html: Added.
  • css3/flexbox/flex-percentage-height-in-table-standards-mode-expected.html: Added.
  • css3/flexbox/flex-percentage-height-in-table-standards-mode.html: Added.
  • css3/flexbox/flex-percentage-height-in-table.html: Added.
5:19 PM Changeset in webkit [143541] by pdr@google.com
  • 9 edits
    2 adds in trunk

Account for transform in SVG background images
https://bugs.webkit.org/show_bug.cgi?id=110295

Reviewed by Dirk Schulze.

Source/WebCore:

Tiled SVG background images are rendererd by drawing the SVG content into a temporary
image buffer, then stamping out a tiled pattern using this buffer. Previously the
image buffer did not account for CSS transforms which could result in pixelated backgrounds.

This patch takes advantage of the context's transform when sizing the temporary tiling
image buffer. Because the context's transform also includes scale, this patch simplifies
the SVG image code to no longer track scale.

Test: svg/as-background-image/svg-transformed-background.html

  • loader/cache/CachedImage.cpp:

(WebCore):
(WebCore::CachedImage::imageForRenderer):

CachedImage::lookupOrCreateImageForRenderer no longer creates images so it has been
refactored into just "imageForRenderer". Previously there were two versions of
lookupOrCreateImageForRenderer; these have been folded into imageForRenderer.

  • loader/cache/CachedImage.h:
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawPatternForContainer):

To create the temporary tiling image buffer, the final size in screen coordinates is
needed. This is now computed using the current context's CTM. Because the CTM
already includes the page scale, all page scale tracking can be removed.

The adjustments to srcRect and the pattern transform are the same as before, just
refactored to use imageBufferScale which has x and y components.

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::setContainerSizeForRenderer):

Because the page scale needed to be cached between calls to
setContainerSizeForRenderer, this function was written to modify an existing cache
entry. Because the page scale no longer needs to be tracked, this code has been
simplified to re-write any existing cache entry.

(WebCore::SVGImageCache::imageSizeForRenderer):

This function has been simplified by calling SVGImageForContainer::size() instead
of computing this value manually. The value returned remains the same, containing
the container size multiplied by zoom.

(WebCore::SVGImageCache::imageForRenderer):

Previously we set the page scale on every call to imageForRenderer. Because page scale
no longer needs to be tracked, this function has been simplified to simply return
the cached SVGImageForContainer.

  • svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::drawPattern):

  • svg/graphics/SVGImageForContainer.h:

(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(SVGImageForContainer):

LayoutTests:

  • svg/as-background-image/svg-transformed-background-expected.html: Added.
  • svg/as-background-image/svg-transformed-background.html: Added.
5:09 PM Changeset in webkit [143540] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in com.apple.WebKit2.WebProcessService at com.apple.avfoundation: 73-[AVAssetResourceLoader _attemptDelegateHandlingOfRequestWithDictionary:]_block_invoke + 51
https://bugs.webkit.org/show_bug.cgi?id=110385

Reviewed by Eric Carlson.

Ensure AVFoundation does not attempt to message a dead object by explicitly disassociating
the AVAssetResourceLoaderDelegate on MediaPlayerPrivateAVFoundationObjC destruction.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):

5:07 PM Changeset in webkit [143539] by ojan@chromium.org
  • 4 edits
    2 adds in trunk

Positioned, replaced elements with intrinsic width keywords compute the wrong width
https://bugs.webkit.org/show_bug.cgi?id=110393

Reviewed by Emil A Eklund.

Source/WebCore:

Test: fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
Add the intrinsic size keywords to the switch. Confusingly, we have to
subtract the border and padding since the callers expect the content width.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
Don't do the intrinsic ratio calculation if the width is an
intrinsic width keyword, as per, http://dev.w3.org/csswg/css3-sizing/#replaced-intrinsic.

(WebCore::RenderReplaced::computeIntrinsicLogicalWidths):
(WebCore::RenderReplaced::computePreferredLogicalWidths):
The old code was trying to apply the intrinsic ratio calculation to
the intrinsic width, which is wrong per spec.

LayoutTests:

  • fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes-expected.txt: Added.
  • fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html: Added.
4:49 PM Changeset in webkit [143538] by alecflett@chromium.org
  • 2 edits in trunk/Source/WebCore

LevelDB: Remove excess vector copy
https://bugs.webkit.org/show_bug.cgi?id=110399

Reviewed by Tony Chang.

Remove an extra copy introduced by the makeVector function.

No new tests, this is covered by existing tests.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::safeGet):

4:48 PM Changeset in webkit [143537] by Simon Fraser
  • 18 edits in trunk

Zoomed, slow-scrolling pages keep recreating tiles when scrolled
https://bugs.webkit.org/show_bug.cgi?id=110379

Source/WebCore:

Reviewed by Tim Horton.

On slow-scrolling pages the TileCache makes the tiles the size of
the visible rect to minimize per-tile painting overhead. If the size
of that rect changes, the TileCache re-creates all the tiles.

This was a problem whem zoomed, because mapping the visible rect
through the scale transform and then rounding it would cause the
size to keep changing, causing lots of tile re-creation.

Fix by carrying the visibleRect around as a FloatRect, and doing
the same for the exposedRect. We then only expand to integers
when computing the tile size. This also fixes an issue where we could
sometimes make extra tiles because of fractional bits of tiles at the edges,
as shown by the test result change.

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateVisibleRect):

  • platform/graphics/ca/mac/TileCache.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::setVisibleRect):
(WebCore::TileCache::setExposedRect):
(WebCore::TileCache::prepopulateRect):
(WebCore::TileCache::computeTileCoverageRect):
(WebCore::TileCache::tileSizeForCoverageRect):
(WebCore::TileCache::blankPixelCountForTiles):
(WebCore::TileCache::revalidateTiles):
(WebCore::TileCache::ensureTilesForRect):

  • platform/graphics/ca/mac/WebTileLayer.mm:

(-[WebTileLayer logFilledFreshTile]):

Source/WebKit2:

Reviewed by Tim Horton.

Make the visible rect and exposed rects passed through
the drawing area to the tile cache FloatRects instead of IntRects.

  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView setMinimumWidthForAutoLayout:]):

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::viewExposedRectChanged):

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setExposedRect):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::viewExposedRectChanged):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):

LayoutTests:

Reviewed by Tim Horton.

This test now just has one tile, rather than four. There is an apparent issue
with the integral tile cache coverage rect being smaller than the visible rect.
This is caused by rounding when dumping the tile coverage rect.

  • platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
4:46 PM HackingOnNewRunWebKitTests edited by dpranke@chromium.org
(diff)
4:45 PM HackingOnNewRunWebKitTests edited by dpranke@chromium.org
actually fill out a high-level overview of how things work. (diff)
4:45 PM Changeset in webkit [143536] by roger_fong@apple.com
  • 9 edits in trunk/Source

Unreviewed. Remove references to SAFARI_THEME from Windows Solution.
<rdar://problem/13258710>

  • config.h:
  • page/Settings.cpp:
  • page/Settings.h:
  • platform/win/ScrollbarThemeWin.cpp:
  • rendering/RenderThemeWin.cpp:
  • WebKitClassFactory.cpp:
  • WebView.cpp:
4:33 PM Changeset in webkit [143535] by jchaffraix@webkit.org
  • 6 edits
    4 adds in trunk

[CSS Grid Layout] Implement the auto-placement algorithm without grid growth
https://bugs.webkit.org/show_bug.cgi?id=110277

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-grid-layout/grid-item-addition-auto-placement-update.html

fast/css-grid-layout/grid-item-removal-auto-placement-update.html
fast/css-grid-layout/grid-auto-flow-resolution.html (extended to cover more cases)

This change implements most of the auto-placement algorithm per
http://dev.w3.org/csswg/css3-grid-layout/#auto-placement-algo

To limit the size of the code change, it doesn't implement growing the grid if there
are no empty grid areas. If we don't find any empty grid areas, we just insert in the first
one, like what grid-auto-flow: none would do (which explains the test failures).

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
Added this function to return the GridCoordinate of the next empty grid area along
the iterator's direction.

(WebCore::RenderGrid::placeItemsOnGrid):
Split this function into the different steps below. For efficiency, collect the auto vs specified
major axis grid items in different Vectors.

(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
Added this function that implements part of step 1 of the algorithm (the grid items without
auto row / column are already handled in placeItemsOnGrid).

(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid):
Added this function that iterates over the auto grid items and call placeAutoMajorAxisItemOnGrid.

(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
Added this method to handle the step 4 of the algorithm. Based on the minor axis's position,
it either walks along the major axis once or several times until it finds an empty grid area
for the grid item.

(WebCore::RenderGrid::autoPlacementMajorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMajorAxisDirection):
(WebCore::RenderGrid::autoPlacementMinorAxisDirection):
Added these helper functions that return minor / major axis positions & direction.

  • rendering/RenderGrid.h:

Added the previous new RenderGrid functions.

LayoutTests:

  • fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
  • fast/css-grid-layout/grid-auto-flow-resolution.html:
  • fast/css-grid-layout/grid-item-addition-auto-placement-update-expected.txt: Added.
  • fast/css-grid-layout/grid-item-addition-auto-placement-update.html: Added.
  • fast/css-grid-layout/grid-item-removal-auto-placement-update-expected.txt: Added.
  • fast/css-grid-layout/grid-item-removal-auto-placement-update.html: Added.

The current algorithm doesn't grow the grid but falls back to inserting the element at
position (1, 1). The failures in these tests are due to that.

4:32 PM Changeset in webkit [143534] by jchaffraix@webkit.org
  • 1 edit
    2 deletes in branches/chromium/1410

Revert 130774

max-width property is does not overriding the width properties for css tables(display:table)
https://bugs.webkit.org/show_bug.cgi?id=98455

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-10-09
Reviewed by Tony Chang.

Source/WebCore:

The max-width property determines the maximum computed width an element can have. In case of css tables(display:table),
the computed was not being limited by the max-width property. The current patch fixes this issue.

Test: fast/table/css-table-max-width.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::updateLogicalWidth):

Logic to compute the logical width of an element such that it does not exceed the max-width value.
Also when both min-width and max-width are present, the following contraint is used to compute the logical width:

1) min-width < Computed LogicalWidth < max-width, when min-width < max-width.
2) Computed LogicalWidth = min-width, when min-width > max-width.

LayoutTests:

  • fast/table/css-table-max-width-expected.txt: Added.
  • fast/table/css-table-max-width.html: Added.

TBR=tony@chromium.org
Review URL: https://codereview.chromium.org/12316027

4:32 PM Changeset in webkit [143533] by scheib@chromium.org
  • 6 edits
    2 copies
    6 adds in trunk

Accept 'allowfullscreen' in addition to 'webkitallowfullscreen'.
https://bugs.webkit.org/show_bug.cgi?id=110374

Reviewed by Adam Barth.

Source/WebCore:

The fullscreen API also includes a new HTML attribute for iframes
which permits its use. That attribute, 'allowfullcreen' is now
included in the HTML specification [1] and is stable enough
to remove the webkit prefix.

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-allowfullscreen

Tests: fullscreen/full-screen-enabled-prefixed.html

fullscreen/full-screen-iframe-allowed-prefixed.html
fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html

  • dom/Document.cpp:

(WebCore::isAttributeOnAllOwners):
(WebCore::Document::fullScreenIsAllowedForElement):
(WebCore::Document::webkitFullscreenEnabled):

  • html/HTMLAttributeNames.in:

LayoutTests:

Two previous tests duplicated to preserve testing webkitallowfullscreen
and then modified to test allowfullscreen.

A new test 'full-screen-iframe-with-mixed-allow-webkitallow-attribute.html'
added to test a mixed nesting of iframs with both allowfullscreen and
webkitallowfullscreen.

  • fullscreen/full-screen-enabled-prefixed-expected.txt: Added.
  • fullscreen/full-screen-enabled-prefixed.html: Copied from LayoutTests/fullscreen/full-screen-enabled.html.
  • fullscreen/full-screen-enabled.html:
  • fullscreen/full-screen-iframe-allowed-prefixed-expected.txt: Added.
  • fullscreen/full-screen-iframe-allowed-prefixed.html: Copied from LayoutTests/fullscreen/full-screen-iframe-allowed.html.
  • fullscreen/full-screen-iframe-allowed.html:
  • fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute-expected.txt:
  • fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html: Added.
  • fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe1.html: Added.
  • fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html: Added.
4:31 PM Changeset in webkit [143532] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Re-enable 3D CSS transforms when using build-webkit
https://bugs.webkit.org/show_bug.cgi?id=110402

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-20
Reviewed by Xan Lopez.

  • Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default

when building WebKitGTK+.

4:20 PM Changeset in webkit [143531] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 142365
BUG=174017
Review URL: https://codereview.chromium.org/12310030

4:17 PM Changeset in webkit [143530] by cevans@google.com
  • 15 edits in branches/chromium/1364

Merge 142759
BUG=174566
Review URL: https://codereview.chromium.org/12316026

4:07 PM Changeset in webkit [143529] by roger_fong@apple.com
  • 81 edits
    2 moves
    33 adds
    1 delete in trunk

Get VS2010 Solution B&I ready.
<rdar://problem/1322988>

Rubberstamped by Timothy Horton.

Add Production configuration.
Add a submit solutions with a DebugSuffix configuration.
Modify B&I make files as necessary.

4:05 PM Changeset in webkit [143528] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1410

Merge 143454
BUG=176738
Review URL: https://codereview.chromium.org/12316025

4:02 PM Changeset in webkit [143527] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 142358
BUG=173402
Review URL: https://codereview.chromium.org/12310028

4:00 PM Changeset in webkit [143526] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

[v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
https://bugs.webkit.org/show_bug.cgi?id=110396

Reviewed by Kentaro Hara.

This is in preparation for a refactor to expose a simplified
WrapperGrouper interface to V8 wrapper classes enabling them to
specify multiple roots per wrapper object.

  • bindings/v8/V8GCController.cpp: Since MutationObservers are not Nodes, the correct call here is addObjectToGroup, as it is for all other non-Node wrappers.
3:59 PM Changeset in webkit [143525] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 142657
BUG=173399
Review URL: https://codereview.chromium.org/12330035

3:58 PM Changeset in webkit [143524] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 142539
BUG=173068
Review URL: https://codereview.chromium.org/12318024

3:53 PM Changeset in webkit [143523] by cevans@google.com
  • 3 edits in branches/chromium/1410/Source

Merge 143347
BUG=174627
Review URL: https://codereview.chromium.org/12321031

3:52 PM Changeset in webkit [143522] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/1364

Merge 143514
BUG=176882
Review URL: https://codereview.chromium.org/12327026

3:50 PM Changeset in webkit [143521] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/1410

Merge 143514
BUG=176882
Review URL: https://codereview.chromium.org/12318023

3:44 PM Changeset in webkit [143520] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

Line layout (but not pref widths) double-counts word spacing when between inlines
https://bugs.webkit.org/show_bug.cgi?id=110381

Reviewed by Emil A Eklund.

Source/WebCore:

When a word break with a space occurs between inlines and word-spacing is non-zero,
line layout incorrectly committed the word-spacing value to the line twice, causing
wrapping in inline-blocks. To fix this, clear the word-spacing value when between
words and ignoring spaces, as we will already have added the word-spacing to the
line.

Test: fast/text/word-space-between-inlines.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/text/word-space-between-inlines-expected.html: Added.
  • fast/text/word-space-between-inlines.html: Added.
3:44 PM Changeset in webkit [143519] by cevans@google.com
  • 2 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 142564
BUG=174895
Review URL: https://codereview.chromium.org/12310026

3:31 PM Changeset in webkit [143518] by nghanavatian@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Check offset for initialized value
https://bugs.webkit.org/show_bug.cgi?id=110390

Reviewed by Rob Buis.

Instead of checking isEmpty, which checks for either point being <= 0, we want to explicitly check
for the initialized value of (-1, -1). This would be set in redrawSpellCheckDialogIfRequired, and
triggers the restore from cache in requestSpellingCheckingOptions.

Internally reviewed by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

3:29 PM Changeset in webkit [143517] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/editing/CompositeEditCommand.cpp

Merge 142642
BUG=175342
Review URL: https://codereview.chromium.org/12324025

3:25 PM Changeset in webkit [143516] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp

Merge 141851
BUG=172926
Review URL: https://codereview.chromium.org/12317033

3:21 PM Changeset in webkit [143515] by kareng@chromium.org
  • 4 edits in branches/chromium/1410/Source

Merge 142755

[Qt] window.open passes height and width parameters even if not defined in a page
https://bugs.webkit.org/show_bug.cgi?id=107705

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Do not override width or height of 0, as that indicates default size, and not minimum size.

Tested by tst_qwebpage.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

Source/WebKit/efl:

Do not resize window when default size is requested.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::setWindowRect):

Source/WebKit/gtk:

Do not resize window when default size is requested.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setWindowRect):

Source/WebKit/qt:

Test that minimum size is applied only when the requested size is too small,
not when default is requested.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage):
(TestPage):
(TestPage::TestPage):
(TestPage::createWindow):
(TestPage::slotGeometryChangeRequested):
(tst_QWebPage::openWindowDefaultSize):

TBR=allan.jensen@digia.com
Review URL: https://codereview.chromium.org/12320020

3:13 PM Changeset in webkit [143514] by Nate Chapin
  • 3 edits
    4 adds in trunk

Source/WebCore: Crash in WebCore::FrameLoader::checkCompleted()
https://bugs.webkit.org/show_bug.cgi?id=110237

Reviewed by Abhishek Arya.

Test: http/tests/misc/delete-frame-during-readystatechange.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkCompleted): Protect before setReadyState() is called.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=110237

Reviewed by Abhishek Arya.

  • http/tests/misc/delete-frame-during-readystatechange-expected.txt: Added.
  • http/tests/misc/delete-frame-during-readystatechange.html: Added.
  • http/tests/misc/resources/delete-frame-during-readystatechange-frame.html: Added.
  • http/tests/misc/resources/empty.ogv: Added.
3:04 PM Changeset in webkit [143513] by cevans@google.com
  • 2 edits in branches/chromium/1364/Source/WebCore/Modules/webaudio

Merge 142687
BUG=172331
Review URL: https://codereview.chromium.org/12321030

3:00 PM Changeset in webkit [143512] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Limit LevelDB's max open files
https://bugs.webkit.org/show_bug.cgi?id=109993

Reviewed by Tony Chang.

LevelDB keeps up to 1000 (by default) data files open at a time to
avoid having to open() them. This has caused chromium to hit the
process-wide open file limit. This patch changes max_open_files to 20,
as that's the minimum permitted by LevelDB and we have no reason to
think that performance will suffer because of the extra open calls.

No new tests - a chromium browser test that tracks the open LevelDB
files is plausible but is blocked on http://crbug.com/177249/.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::openDB):

2:56 PM Changeset in webkit [143511] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Add gyp option to switch ENABLE(SQL_DATABASE)
https://bugs.webkit.org/show_bug.cgi?id=109303
http://code.google.com/p/chromium/issues/detail?id=22208

Patch by Paweł Hajdan, Jr. <phajdan.jr@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

This will be useful to implement build with system sqlite.

  • features.gypi:
  • src/ChromeClientImpl.cpp:

(WebKit):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

2:54 PM Changeset in webkit [143510] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 142816
BUG=171557
Review URL: https://codereview.chromium.org/12315018

2:49 PM Changeset in webkit [143509] by jer.noble@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

EME: Enable both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 until clients transition to the new API.
https://bugs.webkit.org/show_bug.cgi?id=110284

Reviewed by Eric Carlson.

Re-enable the ENCRYPTED_MEDIA flag.

  • Configurations/FeatureDefines.xcconfig:
2:39 PM Changeset in webkit [143508] by cevans@google.com
  • 3 edits in branches/chromium/1364

Merge 142063
BUG=173906
Review URL: https://codereview.chromium.org/12324023

2:24 PM Changeset in webkit [143507] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 142922
BUG-170679
Review URL: https://codereview.chromium.org/12310023

2:16 PM Changeset in webkit [143506] by hyatt@apple.com
  • 8 edits
    2 adds in trunk

[New Multicolumn] Resize RenderMultiColumnSets around their columns.
https://bugs.webkit.org/show_bug.cgi?id=110378.

Reviewed by Dirk Schulze.

Source/WebCore:

Test: fast/multicol/newmulticol/positioned-with-constrained-height.html.

  • rendering/RenderBlock.h:

(RenderBlock):
Make computeOverflow public so that RenderMultiColumnFlowThread can
access it.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::layout):
Subclass layout to recompute the overflow for RenderMultiColumnBlock
after the flow thread has finished layout. This way it can account
for changes in RenderMultiColumnSets without having to do a second
layout pass.

  • rendering/RenderMultiColumnFlowThread.h:

(RenderMultiColumnFlowThread):
Override layout().

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::columnCount):
Clean up a comment that referred to portions as region rects still.

(WebCore::RenderMultiColumnSet::setFlowThreadPortionRect):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderRegion.h:

(WebCore::RenderRegion::setFlowThreadPortionRect):
Make setFlowThreadPortionRect virtual and actually mutate the size
and position of RenderMultiColumnSets so that they enclose their
column rects.

LayoutTests:

  • fast/multicol/newmulticol/positioned-with-constrained-height-expected.html: Added.
  • fast/multicol/newmulticol/positioned-with-constrained-height.html: Added.
2:14 PM Changeset in webkit [143505] by krit@webkit.org
  • 22 edits in trunk

Enable CANVAS_PATH flag
https://bugs.webkit.org/show_bug.cgi?id=108508

Reviewed by Simon Fraser.

Enable CANVAS_PATH flag on trunk.

.:

Existing tests cover the feature.

  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Existing tests cover the feature.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Existing tests cover the feature.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Existing tests cover the feature.

  • fast/canvas/canvas-path-object-expected.txt:
  • inspector/profiler/canvas2d/canvas2d-api-changes.html:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
2:03 PM Changeset in webkit [143504] by tony@chromium.org
  • 3 edits in trunk/Tools

Parse author names with commas in ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=110356

Reviewed by Dirk Pranke.

Paweł's name has a comma in it, which was confusing the ChangeLog parser.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry): Move name splitting regexp into a constant.
(ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
(ChangeLogEntry._split_reviewer_names): Rename to be more specific.
(ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
(ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_parse_authors): Test case with Paweł's name.

1:56 PM Changeset in webkit [143503] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r143441.
http://trac.webkit.org/changeset/143441
https://bugs.webkit.org/show_bug.cgi?id=110376

May be causing chromium content_browsertests failures.
(Requested by vollick on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-20

  • bindings/v8/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):

  • bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(WebCore::ScriptValue::v8Value):
(ScriptValue):

  • bindings/v8/SharedPersistent.h:

(WebCore):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::scriptValueAsNode):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAttrGetterCustom):

1:53 PM Changeset in webkit [143502] by krit@webkit.org
  • 11 edits in trunk

[Chromium] Add runtime flag for CanvasPath
https://bugs.webkit.org/show_bug.cgi?id=109997

Reviewed by Adam Barth.

Source/WebCore:

Add runtime flag for Chromium.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::canvasPathEnabled):

  • html/canvas/DOMPath.idl:
  • page/DOMWindow.idl:

Source/WebKit/chromium:

Add runtime flag for Chromium.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableCanvasPath):
(WebKit):
(WebKit::WebRuntimeFeatures::isCanvasPathEnabled):

Tools:

Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
the constructor for Path on DOMWindow would never be activatable, since the script
is running after creating the DOMWindow object.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

1:53 PM Changeset in webkit [143501] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/1364

Merge 143060
Review URL: https://codereview.chromium.org/12328018

1:48 PM Changeset in webkit [143500] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

Patch by Ian Vollick <vollick@chromium.org> on 2013-02-20

  • platform/chromium/TestExpectations:
1:45 PM Changeset in webkit [143499] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Remove unnecessary includes for Platform.h from headers
https://bugs.webkit.org/show_bug.cgi?id=110300

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-20
Reviewed by Alexey Proskuryakov.

Source/WebCore:

wtf/Platform.h only need to be included in a few places directly
as it is included in config.h. Remove the unnecessay duplicate as
it can be confusing.

No new tests, no change in functionality.

  • platform/SecureTextInput.h:
  • platform/audio/Biquad.h:
  • platform/audio/FFTFrame.h:
  • platform/graphics/cpu/arm/filters/FEBlendNEON.h:
  • platform/graphics/cpu/arm/filters/NEONHelpers.h:
  • platform/graphics/filters/FELighting.h:

Source/WebKit2:

wtf/Platform.h only need to be included in a few places directly
as it is included in config.h. Remove the unnecessay duplicate as
it can be confusing.

  • Shared/PrintInfo.h:
1:43 PM Changeset in webkit [143498] by fmalita@chromium.org
  • 3 edits in trunk/Source/WebCore

[SVG] Update of element referenced by multiple 'use' nodes is absurdly slow
https://bugs.webkit.org/show_bug.cgi?id=97905

Reviewed by Dirk Schulze.

Rebuilding the shadow and instance trees of dependent use nodes recursively can be
extremely inefficient with non-trivial dependency graphs (the trees are not constructed
in topological order).

To avoid redundant buildShadowAndInstanceTree() invokations, separate the invalidation
phase from the actual tree (re)building phase, and only descend into the dependency DAG
during the invalidation phase (recursion also stops at nodes that have been previously
invalidated).

No new tests: functional coverage provided by existing tests, perfomance tracked by
PerformanceTests/SVG/SvgNestedUse.html.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::invalidateShadowTree):
(WebCore):
(WebCore::SVGUseElement::invalidateDependentShadowTrees):

  • svg/SVGUseElement.h:

(SVGUseElement):

1:34 PM Changeset in webkit [143497] by wjmaclean@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

Patch by Ian Vollick <vollick@chromium.org> on 2013-02-20

  • platform/chromium/TestExpectations:
1:31 PM Changeset in webkit [143496] by pilgrim@chromium.org
  • 4 edits in trunk/Source

[Chromium] Move WebKitPlatformSupport declaration to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=110262

Reviewed by Adam Barth.

In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.

Source/Platform:

  • chromium/public/Platform.h:

(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h:
1:28 PM Changeset in webkit [143495] by robert@webkit.org
  • 3 edits in trunk/LayoutTests

Make the test land in r143482 less platform-specific

Add outline:none to the test so platform-specific outlines don't kick in and
make us require separate results for Mac and Linux.

Unreviewed, gardening.

  • fast/repaint/paint-caret-in-div-with-negative-indent-expected.png:
  • fast/repaint/paint-caret-in-div-with-negative-indent.html:
1:27 PM Changeset in webkit [143494] by cevans@google.com
  • 5 edits
    2 deletes in branches/chromium/1364

Revert 143493
Review URL: https://codereview.chromium.org/12314017

1:24 PM Changeset in webkit [143493] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1364

Merge 142820
BUG=170184

1:20 PM Changeset in webkit [143492] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1364

Merge 142500
BUG=169398
Review URL: https://codereview.chromium.org/12327019

1:15 PM Changeset in webkit [143491] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 142899
BUG=168982
Review URL: https://codereview.chromium.org/12315016

1:15 PM Changeset in webkit [143490] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

RenderLayerBacking should initialize TiledBacking's isInWindow state with Page's isInWindow, not isOnscreen
https://bugs.webkit.org/show_bug.cgi?id=110370
<rdar://problem/13254006>

Reviewed by Simon Fraser.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

1:10 PM Changeset in webkit [143489] by mark.lam@apple.com
  • 5 edits in trunk/Source/WebCore

Cleanup the SQLTransaction and SQLTransactionBackend state dispatch
to only honor a state transition request if the associated database
hasn't been interrupted.
https://bugs.webkit.org/show_bug.cgi?id=110247.

Reviewed by Antti Koivisto.

No new tests.

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::performPendingCallback):
(WebCore::SQLTransaction::computeNextStateAndCleanupIfNeeded):

  • Modules/webdatabase/SQLTransaction.h:
  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):
(WebCore::SQLTransactionBackend::performNextStep):

  • Modules/webdatabase/SQLTransactionBackend.h:
1:09 PM Changeset in webkit [143488] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Moar hardening
https://bugs.webkit.org/show_bug.cgi?id=110275

Reviewed by Mark Hahnenberg.

We now poison objects when they get freed, and verify that
any object that is being freed is not poisoned. If the
object looks like it's poisoned we validate the freelist,
and ensure the object is not already present. If it is
we crash.

On allocation, we ensure that the object being allocated
is poisoned, then clear the poisoning fields.

  • wtf/FastMalloc.cpp:

(WTF::internalEntropyValue):
(WTF):
(WTF::freedObjectStartPoison):
(WTF::freedObjectEndPoison):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

1:02 PM Changeset in webkit [143487] by ap@apple.com
  • 10 edits in trunk/Source/WebCore

ResourceHandle::loadResourceSynchronously should have blob support in cross-platform code
https://bugs.webkit.org/show_bug.cgi?id=110364

Reviewed by Anders Carlsson.

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Added a cross-platform version to keep blob-related logic in one place.
  • platform/network/blackberry/ResourceHandleBlackBerry.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::platformLoadResourceSynchronously): Renamed loadResourceSynchronously to platformLoadResourceSynchronously, removed blob handling from platforms that had it.
1:00 PM Changeset in webkit [143486] by hyatt@apple.com
  • 3 edits
    10 adds in trunk

[New Multicolumn] RenderMultiColumnFlowThreads should establish a BFC.
https://bugs.webkit.org/show_bug.cgi?id=110366.

Reviewed by Antti Koivisto.

Source/WebCore:

RenderFlowThreads should establish a block formatting context always.
CSS Regions have named flow thread that they absolutely position, and so
they got this for free by being absolutely positioned.

RenderMultiColumnFlowThreads, however, are relative positioned, so we need
to just add an isRenderFlowThread case specifically so we're not dependent
on the positioning scheme used for the flow thread to establish the BFC.

Test: fast/multicol/newmulticol/float-*.html.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):

LayoutTests:

  • fast/multicol/newmulticol/float-avoidance-expected.html: Added.
  • fast/multicol/newmulticol/float-avoidance.html: Added.
  • fast/multicol/newmulticol/float-multicol-expected.html: Added.
  • fast/multicol/newmulticol/float-multicol.html: Added.
  • fast/multicol/newmulticol/float-paginate-complex-expected.html: Added.
  • fast/multicol/newmulticol/float-paginate-complex.html: Added.
  • fast/multicol/newmulticol/float-paginate-empty-lines-expected.html: Added.
  • fast/multicol/newmulticol/float-paginate-empty-lines.html: Added.
  • fast/multicol/newmulticol/float-paginate-expected.html: Added.
  • fast/multicol/newmulticol/float-paginate.html: Added.
12:14 PM Changeset in webkit [143485] by fmalita@chromium.org
  • 2 edits in branches/chromium/1410/Source/Platform

Merge 142496

[Chromium] FilterTypeSaturatingBrightness enum
https://bugs.webkit.org/show_bug.cgi?id=109380

Introduce a new WebFilterOperation::FilterType enum (FilterTypeSaturatingBrightness)
to support existing interntal clients which rely on the current saturating brightness
behavior (in preparation of switching to the new brightness implementation).

Reviewed by James Robinson.

  • chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::createSaturatingBrightnessFilter):
(WebKit::WebFilterOperation::setAmount):

TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/12321021

11:58 AM Changeset in webkit [143484] by hyatt@apple.com
  • 4 edits
    2 adds in trunk

[New Multicolumn] Column gap is computed incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=110360.

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/multicol/newmulticol/layers-split-across-columns.html.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::columnGap):
Make sure we ask the RenderMultiColumnBlock for the gap rather than our
own style, since we don't actually have the gap value in our style.

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):

  • rendering/RenderMultiColumnSet.h:

Fix another spot where the columnGap was an int. It should be a LayoutUnit.

LayoutTests:

  • fast/multicol/newmulticol/layers-split-across-columns-expected.html: Added.
  • fast/multicol/newmulticol/layers-split-across-columns.html: Added.
11:51 AM Changeset in webkit [143483] by robert@webkit.org
  • 3 edits
    3 adds in trunk

No caret on empty contenteditable element with negative text-indent
https://bugs.webkit.org/show_bug.cgi?id=108633

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/repaint/paint-caret-in-div-with-negative-indent.html

When an editable element has a negative text indent we won't paint the caret when the
element is empty because it falls outside the element's border box. To ensure the caret is painted,
account for any negative indent with our overflow.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

LayoutTests:

  • fast/repaint/paint-caret-in-div-with-negative-indent-expected.png: Added.
  • fast/repaint/paint-caret-in-div-with-negative-indent-expected.txt: Added.
  • fast/repaint/paint-caret-in-div-with-negative-indent.html: Added.
11:09 AM Changeset in webkit [143482] by Lucas Forschler
  • 18 edits in tags/Safari-537.31.5/Source

Merged r143418. <rdar://problem/13067171>

11:01 AM Changeset in webkit [143481] by Lucas Forschler
  • 2 edits
    1 delete in tags/Safari-537.31.5/Source/WebKit2

Merged r143113. <rdar://problem/13236883>

10:45 AM Changeset in webkit [143480] by jochen@chromium.org
  • 7 edits in trunk/Tools

[chromium] use a WebTestProxyBase pointer to identify the window we need the history for
https://bugs.webkit.org/show_bug.cgi?id=110346

Reviewed by Adam Barth.

Using an index is very brittle, as the TestRunner API does not define
any ordering of windows.

Also, make TestRunner::shouldDumpBackForwardList() so content shell can
trigger the capturing in the browser process before generating the
text dump.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner):
(WebTestRunner::WebTestDelegate::captureHistoryForWindow):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::captureTree):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::captureHistoryForWindow):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:45 AM Changeset in webkit [143479] by ojan@chromium.org
  • 7 edits in trunk/Source/WebCore

Remove stretchesToMinIntrinsicLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=110266

Reviewed by Emil Eklund.

This was only used by fieldsets and now we have a way to express this
concept in CSS.

  • WebCore.order:
  • css/html.css:

Make fieldsets min-width: -webkit-min-content.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computePositionedLogicalWidth):

  • rendering/RenderBox.h:

Remove all calls to stretchesToMinIntrinsicLogicalWidth.

10:41 AM Changeset in webkit [143478] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.5/Source

Versioning.

10:37 AM Changeset in webkit [143477] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.5

New Tag.

10:37 AM Changeset in webkit [143476] by ojan@chromium.org
  • 4 edits
    4 adds in trunk

Make intrinsic width values work for positioned elements
https://bugs.webkit.org/show_bug.cgi?id=110264

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html

fast/css-intrinsic-dimensions/width-shrinks-avoid-floats.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
Move the computation of intrinsic widths out into a helper function so that
computePositionedLogicalWidthUsing can use it. As per the current spec,
fill-available measures shrink to avoid floats. http://dev.w3.org/csswg/css3-sizing/

(WebCore::RenderBox::computePositionedLogicalWidth):
Compute intrinsic min-widths in addition to non-zero ones. Intrinsic widths
return true for isZero. width and max-width don't need modifying since they already
call computePositionedLogicalWidthUsing for intrinsic widths.

(WebCore::RenderBox::computePositionedLogicalWidthUsing):
Compute intrinsic widths and use a Fixed length for the rest of the positioned width
computation. Doesn't include bordersPlusPadding because the caller, expected the content
width and adds in the bordersPlusPadding later.

  • rendering/RenderBox.h:

LayoutTests:

  • fast/css-intrinsic-dimensions/intrinsic-sized-absolutes-expected.txt: Added.
  • fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html: Added.
  • fast/css-intrinsic-dimensions/width-shrinks-avoid-floats-expected.txt: Added.
  • fast/css-intrinsic-dimensions/width-shrinks-avoid-floats.html: Added.
10:27 AM Changeset in webkit [143475] by robert@webkit.org
  • 3 edits
    4 adds in trunk

input element with placeholder text and width set to 100% on focus causes overflow even after losing focus
https://bugs.webkit.org/show_bug.cgi?id=109020

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/forms/input-placeholder-layout-view.html

fast/forms/textarea-placeholder-layout-view.html

Placeholder elements don't affect layout so shouldn't contribute overflow either.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

LayoutTests:

  • fast/forms/input-placeholder-layout-view-expected.html: Added.
  • fast/forms/input-placeholder-layout-view.html: Added.
  • fast/forms/textarea-placeholder-layout-view-expected.html: Added.
  • fast/forms/textarea-placeholder-layout-view.html: Added.
10:23 AM Changeset in webkit [143474] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit2

[WK2] Remove m_viewportSize in WebPage.
https://bugs.webkit.org/show_bug.cgi?id=110311

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-20
Reviewed by Anders Carlsson.

EFL and Qt use m_viewSize as a contents size while Apple use it as a viewport
size, so EFL and Qt introduced m_viewportSize to make WebPage know a viewport
size.

EFL and Qt use m_viewSize as a contents size because the size of non compositing
layer is contents size, and EFL and Qt mark whole non compositing layer as dirty
using m_viewSize. Bug 110299 (http://webkit.org/b/110299) changes that it is not
necessary to know m_viewSize when marking whole non compositing layer as dirty.
So we can make EFL and Qt use m_viewSize as a viewport size also.

This patch removes m_viewportSize and related methods to increase readability.

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebView::setSize):

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didChangeViewportSize):

  • UIProcess/WebPageProxy.cpp:

(WebKit):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::pageRect):
(WebKit::WebChromeClient::contentsSizeChanged):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updateBackingStoreState):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSize):
(WebKit::WebPage::sendViewportAttributesChanged):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
10:21 AM Changeset in webkit [143473] by pilgrim@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Adam Barth.

Now that https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

  • public/platform/WebKitPlatformSupport.h:

(WebKit):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

10:10 AM Changeset in webkit [143472] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebKit2

[WK2] add setNeedsDisplay in DrawingArea to mark whole layer as dirty.
https://bugs.webkit.org/show_bug.cgi?id=110299

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-20
Reviewed by Anders Carlsson.

Currently, we call setNeedsDisplay with the size of WebPage to mark whole
backing store as dirty. However, the size of non compositing layer can be
inconsistent with the size of WebPage. For example, in Coordinated Graphics, the
size of non compositing layer is contents size.

So, WebPage should not assume the size of non compositing layer, and should just
call setNeedsDisplay when marking whole layer as dirty.

In addition, this patch renames from setNeedsDisplay() with a rect argument to
setNeedsDisplayInRect(), which matches to the terms of GraphicsLayer.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateContentsAndRootView):
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::restoreViewState):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplay):
(WebKit):
(WebKit::CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplayInRect):
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(CoordinatedLayerTreeHost):

  • WebProcess/WebPage/DrawingArea.h:

(DrawingArea):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit):
(WebKit::DrawingAreaImpl::setNeedsDisplayInRect):
(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
(WebKit::DrawingAreaImpl::resumePainting):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

  • WebProcess/WebPage/LayerTreeHost.h:

(LayerTreeHost):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSize):
(WebKit::WebPage::setDrawsBackground):
(WebKit::WebPage::setDrawsTransparentBackground):
(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplay):
(WebKit):
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostGtk::scrollNonCompositedContents):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

(LayerTreeHostGtk):

  • WebProcess/WebPage/mac/LayerTreeHostMac.h:

(LayerTreeHostMac):

  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostMac::scrollNonCompositedContents):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

(RemoteLayerTreeDrawingArea):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::setNeedsDisplay):
(WebKit):
(WebKit::RemoteLayerTreeDrawingArea::setNeedsDisplayInRect):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit):
(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplayInRect):

9:56 AM Changeset in webkit [143471] by mark.lam@apple.com
  • 36 edits
    2 moves in trunk/Source

Rename DatabaseBackend to DatabaseBackendBase.
https://bugs.webkit.org/show_bug.cgi?id=110303.

Rubber stamped by Alexey Proskuryakov.

Source/WebCore:

This is a purely cosmetic change to make the naming consistent with
the front-end DatabaseBase.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webdatabase/AbstractDatabaseServer.h:
  • Modules/webdatabase/Database.cpp:

(WebCore::Database::create):
(WebCore::Database::version):

  • Modules/webdatabase/Database.h:

(Database):

  • Modules/webdatabase/DatabaseBackend.cpp: Removed.
  • Modules/webdatabase/DatabaseBackend.h: Removed.
  • Modules/webdatabase/DatabaseBackendAsync.cpp:

(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):
(WebCore::DatabaseBackendAsync::performOpenAndVerify):

  • Modules/webdatabase/DatabaseBackendAsync.h:
  • Modules/webdatabase/DatabaseBackendBase.cpp: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp.

(WebCore::DatabaseBackendBase::databaseInfoTableName):
(WebCore::DatabaseBackendBase::DatabaseBackendBase):
(WebCore::DatabaseBackendBase::~DatabaseBackendBase):
(WebCore::DatabaseBackendBase::closeDatabase):
(WebCore::DatabaseBackendBase::version):
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::securityOrigin):
(WebCore::DatabaseBackendBase::stringIdentifier):
(WebCore::DatabaseBackendBase::displayName):
(WebCore::DatabaseBackendBase::estimatedSize):
(WebCore::DatabaseBackendBase::fileName):
(WebCore::DatabaseBackendBase::details):
(WebCore::DatabaseBackendBase::getVersionFromDatabase):
(WebCore::DatabaseBackendBase::setVersionInDatabase):
(WebCore::DatabaseBackendBase::setExpectedVersion):
(WebCore::DatabaseBackendBase::getCachedVersion):
(WebCore::DatabaseBackendBase::setCachedVersion):
(WebCore::DatabaseBackendBase::getActualVersionForTransaction):
(WebCore::DatabaseBackendBase::disableAuthorizer):
(WebCore::DatabaseBackendBase::enableAuthorizer):
(WebCore::DatabaseBackendBase::setAuthorizerReadOnly):
(WebCore::DatabaseBackendBase::setAuthorizerPermissions):
(WebCore::DatabaseBackendBase::lastActionChangedDatabase):
(WebCore::DatabaseBackendBase::lastActionWasInsert):
(WebCore::DatabaseBackendBase::resetDeletes):
(WebCore::DatabaseBackendBase::hadDeletes):
(WebCore::DatabaseBackendBase::resetAuthorizer):
(WebCore::DatabaseBackendBase::maximumSize):
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):
(WebCore::DatabaseBackendBase::interrupt):
(WebCore::DatabaseBackendBase::isInterrupted):
(WebCore::DatabaseBackendBase::reportOpenDatabaseResult):
(WebCore::DatabaseBackendBase::reportChangeVersionResult):
(WebCore::DatabaseBackendBase::reportStartTransactionResult):
(WebCore::DatabaseBackendBase::reportCommitTransactionResult):
(WebCore::DatabaseBackendBase::reportExecuteStatementResult):
(WebCore::DatabaseBackendBase::reportVacuumDatabaseResult):

  • Modules/webdatabase/DatabaseBackendBase.h: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackend.h.

(DatabaseBackendBase):

  • Modules/webdatabase/DatabaseBackendSync.cpp:

(WebCore::DatabaseBackendSync::DatabaseBackendSync):

  • Modules/webdatabase/DatabaseBackendSync.h:
  • Modules/webdatabase/DatabaseBase.h:
  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
(WebCore::DatabaseManager::getMaxSizeForDatabase):

  • Modules/webdatabase/DatabaseManager.h:

(DatabaseManager):

  • Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::openDatabase):
(WebCore::DatabaseServer::createDatabase):
(WebCore::DatabaseServer::getMaxSizeForDatabase):

  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseSync.cpp:

(WebCore::DatabaseSync::create):

  • Modules/webdatabase/DatabaseSync.h:

(DatabaseSync):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • Modules/webdatabase/DatabaseTracker.h:

(DatabaseTracker):

  • Modules/webdatabase/OriginQuotaManager.cpp:

(WebCore::OriginQuotaManager::markDatabase):

  • Modules/webdatabase/OriginQuotaManager.h:

(OriginQuotaManager):

  • Modules/webdatabase/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):

  • Modules/webdatabase/SQLTransactionClient.h:

(SQLTransactionClient):

  • Modules/webdatabase/chromium/DatabaseObserver.h:

(DatabaseObserver):

  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::NotifyDatabaseObserverOnCloseTask::create):
(WebCore::NotifyDatabaseObserverOnCloseTask::NotifyDatabaseObserverOnCloseTask):
(NotifyDatabaseObserverOnCloseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::prepareToOpenDatabase):
(WebCore::DatabaseTracker::failedToOpenDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::create):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::CloseOneDatabaseImmediatelyTask):
(DatabaseTracker::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::closeOneDatabaseImmediately):

  • Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp:

(WebCore::NotifyDatabaseChangedTask::create):
(WebCore::NotifyDatabaseChangedTask::NotifyDatabaseChangedTask):
(NotifyDatabaseChangedTask):
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

  • public/WebDatabase.h:

(WebDatabase):

  • src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):
(WebCore::DatabaseObserver::reportOpenDatabaseResult):
(WebCore::DatabaseObserver::reportChangeVersionResult):
(WebCore::DatabaseObserver::reportStartTransactionResult):
(WebCore::DatabaseObserver::reportCommitTransactionResult):
(WebCore::DatabaseObserver::reportExecuteStatementResult):
(WebCore::DatabaseObserver::reportVacuumDatabaseResult):

  • src/WebDatabase.cpp:

(WebKit::WebDatabase::WebDatabase):

9:48 AM Changeset in webkit [143470] by tony@chromium.org
  • 7 edits
    2 adds in trunk

Source/WebKit/chromium: Fix use after free in ContextMenuClientImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=109220

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

ContextMenuClientImpl can use a DocumentMarker after it is freed. The DocumentMarker is originally allocated
by the spell checker. When the user context-clicks on a misspelling, ContextMenuClientImpl saves a reference
to the clicked DocumentMarker, changes the selection, and then uses the DocumentMarker. Changing the selection
causes re-check of spelling. If the spell check client serves the spellcheck request from cache, then re-checking
spelling will delete the DocumentMarker and add a new one. This invalidates the DocumentMarker reference held by
ContextMenuClientImpl. When ContextMenuClientImpl attempts to use the DocumentMarker, Address Sanitizer detects
use after free. The fix is to save a copy of the DocumentMarker before changing selection.

  • src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspellingAsync): Save a copy of DocumentMarker before changing selection.
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Use DocumentMarker instead of Vector<DocumentMarker*>.

Tools: [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
https://bugs.webkit.org/show_bug.cgi?id=109220

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-19
Reviewed by Tony Chang.

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
(WebTestRunner):
(WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
(WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.

LayoutTests: Spellchecker should not crash after text has changed and spellcheck results are served from cache
https://bugs.webkit.org/show_bug.cgi?id=109220

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

  • editing/spelling/spelling-changed-text-expected.txt: Added the expected output for serving spellcheck results from cache for edited text.
  • editing/spelling/spelling-changed-text.html: Added a test for serving spellcheck results from cache for edited text.
9:33 AM WebKit Team edited by mvujovic@adobe.com
Add Max Vujovic to committers list. (diff)
9:23 AM Changeset in webkit [143469] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

iOS does not use CaptionUserPreferencesMac
https://bugs.webkit.org/show_bug.cgi?id=110259

Reviewed by Dean Jackson.

  • page/CaptionUserPreferencesMac.h: Add PLATFORM(IOS) guard
  • page/CaptionUserPreferencesMac.mm: Ditto.
  • page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferences): Ditto.

9:15 AM Changeset in webkit [143468] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r183552. Requested by
"Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-20

  • DEPS:
9:10 AM WebKit Team edited by hmuller@adobe.com
Added Hans Muller to list of committers (diff)
8:59 AM Changeset in webkit [143467] by hyatt@apple.com
  • 6 edits
    2 adds in trunk

[New Multicolumn] Make layers paint properly in columns.
https://bugs.webkit.org/show_bug.cgi?id=110296.

Reviewed by Sam Weinig.

Source/WebCore:

Construct the style for the RenderMultiColumnFlowThread such that it
establishes a stacking context (by being position:relative
with a z-index of 0). This causes the layer collection code
to correctly ignore the RenderFlowThread layers during normal
painting.

Fix more clipping bugs to eliminate subpixel layout differences
between old and new multicolumn.

Test: fast/multicol/newmulticol/layers-in-multicol.html

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::createMultiColumnFlowThreadStyle):
(WebCore):
(WebCore::RenderMultiColumnBlock::addChild):
Use a custom style (similar to what normal RenderFlowThreads do)
for the RenderMultiColumnFlowThread that makes it a stacking
context.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
Fix the overflow calculations out the leftmost and rightmost
columns to actually look at the physical placement of the columns.
The old code was backwards for RTL.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
Fix the clipping done by overflowRectForFlowThreadPortion to min
and max with the passed-in portion rect so that subclasses that
inflate the rect prior to passing it into the method don't have that
inflation discarded.

LayoutTests:

  • fast/multicol/newmulticol/layers-in-multicol-expected.html: Added.
  • fast/multicol/newmulticol/layers-in-multicol.html: Added.
8:43 AM Changeset in webkit [143466] by jpetsovits@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make sure to always sync before reusing backingstore tiles.
https://bugs.webkit.org/show_bug.cgi?id=109863
PR 296118

Reviewed by Rob Buis.
Internally reviewed by Mike Lattanzio and Konrad Piascik.

In SVN r142137, I replaced a syncToCurrentMessage() call
with updateSuspendScreenUpdateState() in some cases,
which internally calls the same function.

Unfortunately, when I optimized updateSuspendScreenUpdateState()
to only sync when the state is actually being changed,
I omitted an adaptation of adoptAsFrontState() which would
rely on this sync but now didn't always perform it.

This caused a bad race condition as tile buffers could now
be accessed from the WebKit thread and the UI thread at
the same time. Fix it by (optionally) letting the caller
of updateSuspendScreenUpdateState() know whether a sync
was performed, and adapt adoptAsFrontState() accordingly.

Also fixes some excessive flicker caused by the same
race condition.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):

  • Api/BackingStore_p.h:
8:12 AM WebKit Team edited by Claudio Saavedra
Adding myself (diff)
8:08 AM Changeset in webkit [143465] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: CSSProperty.status defaults to "style" not "active"
https://bugs.webkit.org/show_bug.cgi?id=110348

Reviewed by Timothy Hatcher.

  • inspector/Inspector.json: Fix the default property status to be "style" in the description.
8:07 AM WebKit Team edited by zhajiang@rim.com
(diff)
7:38 AM Changeset in webkit [143464] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[v8] potentially disposed handle returned for npapi object
https://bugs.webkit.org/show_bug.cgi?id=110331

Patch by Dan Carney <dcarney@google.com> on 2013-02-20
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

7:30 AM Changeset in webkit [143463] by commit-queue@webkit.org
  • 27 edits
    2 adds in trunk

[Gtk] HTML5 Media controls require a design refresh
https://bugs.webkit.org/show_bug.cgi?id=83869

Source/WebCore:

Created new controls that depend less on Gtk and more in CSS.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> and Martin Robinson <mrobinson@igalia.com> on 2013-02-20
Reviewed by Philippe Normand.

  • GNUmakefile.list.am: Added compilation for MediaControlsGtk.cpp

and MediaControlsGtk.h

  • css/mediaControlsGtk.css: Taken from Chromium and adapted for

WebKitGtk+.

  • html/shadow/MediaControlsGtk.cpp: Added.

(WebCore): Added MediaControlsGtk class.
(WebCore::MediaControlsGtk::MediaControlsGtk): Class constructor
(WebCore::MediaControls::create): Creates the Gtk+ controls
components.
(WebCore::MediaControlsGtk::createControls): Creates the Gtk+
controls components.
(WebCore::MediaControlsGtk::initializeControls): Initializes all
media controls.
(WebCore::MediaControlsGtk::setMediaController): Sets the media
controller.
(WebCore::MediaControlsGtk::reset): Resets the controllers.
(WebCore::MediaControlsGtk::playbackStarted): Invoked when the
playback starts
(WebCore::MediaControlsGtk::updateCurrentTimeDisplay): Updates the
controls when the current time shall be updated.
(WebCore::MediaControlsGtk::changedMute): Updates the controls
then the mute changes.
(WebCore::MediaControlsGtk::showVolumeSlider): Invoked when the
volume slider is meant to be shown.
(WebCore::MediaControlsGtk::createTextTrackDisplay): Creates the
track display. Though it is not used by us, it needs to be created
to prevent immediate crashes when loading a video.

  • html/shadow/MediaControlsGtk.h: Added.

(WebCore): Added the MediaControlsGtk class.
(MediaControlsGtk): Added the MediaControlsGtk class.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore): Added getStockSymbolicIconForWidgetType function
signature to load symbolic icons.
(WebCore::supportsFocus): Added media control widgets to support
focus so that the focus ring is not painted by WebCore.
(WebCore::RenderThemeGtk::paintMediaButton): Added the symbolic
icon support. It supports now normal and symbolic icons at the
same time.
(WebCore::RenderThemeGtk::paintMediaFullscreenButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaMuteButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaPlayButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaSeekBackButton): Added the
symbolic icon support.
(WebCore::RenderThemeGtk::paintMediaSeekForwardButton): Added the
symbolic icon support.
(WebCore::borderRadiiFromStyle): Created the radii info from the
style.
(WebCore::RenderThemeGtk::paintMediaSliderTrack): Removed the
background and the Gtk widget support as it is painted with
CSS. Also paint the time ranges with the CSS style.
(WebCore::RenderThemeGtk::paintMediaSliderThumb): Paint slider
thumb according to the CSS parameters.
(WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer):
Delegates in the CSS.
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Fills the
track up to the volume level and delegates the border in the CSS.
(WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb): Delegates
in the paintMediaSliderThumb method so the thumb is painted the
same with the CSS parameters.
(WebCore::RenderThemeGtk::paintMediaCurrentTime): Removed the Gtk
background to use only CSS.

  • platform/gtk/RenderThemeGtk.h:

(RenderThemeGtk): Changed paintMediaButton to support the symbolic
and normal icons at the same time.

  • platform/gtk/RenderThemeGtk2.cpp:

(WebCore::RenderThemeGtk::adjustSliderThumbSize): Not adjusting
the thumb size and letting the CSS decide that for media slider.
(WebCore::getStockSymbolicIconForWidgetType): Implemented as a
fallback to the normal stock icons.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore):
(WebCore::RenderThemeGtk::adjustSliderThumbSize): Not adjusting
the thumb size and letting the CSS decide that for the media
sliders.
(WebCore::getStockSymbolicIconForWidgetType): Added this function
to load symbolic icons. It falls back to normal icons if the
symbolic is not found.

Tools:

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-02-20
Reviewed by Philippe Normand.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(initializeGtkFontSettings): Added gnome as default icon theme for
the DRT.

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::initializeGtkSettings): Added gnome as default icon theme for
the WTR.

  • gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external

dependency.

LayoutTests:

Tests flagged and rebaselines.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-02-20
Reviewed by Philippe Normand.

  • platform/gtk/TestExpectations: Tests flagged and removed some

other flags.

  • platform/gtk/accessibility/media-element-expected.txt: Rebaseline
  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt: Rebaseline
  • platform/gtk/fast/layers/video-layer-expected.png: Rebaseline
  • platform/gtk/fast/layers/video-layer-expected.txt: Rebaseline
  • platform/gtk/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Rebaseline
  • platform/gtk/media/audio-repaint-expected.png: Rebaseline
  • platform/gtk/media/audio-repaint-expected.txt: Rebaseline
  • platform/gtk/media/controls-styling-strict-expected.png: Rebaseline
  • platform/gtk/media/video-controls-rendering-expected.png: Rebaseline
  • platform/gtk/media/video-empty-source-expected.txt: Rebaseline
  • platform/gtk/media/video-no-audio-expected.txt: Rebaseline
  • platform/gtk/media/video-volume-slider-expected.txt: Rebaseline
  • platform/gtk/media/video-zoom-controls-expected.txt: Rebaseline
  • platform/gtk/media/video-zoom-expected.png: Rebaseline
7:27 AM Changeset in webkit [143462] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Rename AncestorChainWalker.h to EventPathWalker.h in the project file.

Unreviewed gardening.

AncestorChainWalker has been renamed to EventPathWalker in r143422.
Rename the header in the project file as well so that it shows up in QtCreator.

No new tests needed.

  • Target.pri:
7:24 AM Changeset in webkit [143461] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Read "data-blackberry-text-selection-handle-position" attribute from element
https://bugs.webkit.org/show_bug.cgi?id=110235

Patch by Yongxin Dai <yodai@rim.com> on 2013-02-20
Reviewed by Yong Li.

PR #257207.

Read "data-blackberry-text-selection-handle-position" attribute from element and pass it along
with notifySelectionDetailsChanged(). If "data-blackberry-text-selection-handle-position" attribute
is specified in the element, the selection handle is always flipped to the required position.
along with selected text within element.

Reviewed Internally by Mike Fenton.

  • Api/WebPageClient.h:
  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::selectionContainerElement):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::elementHandlePositionAttribute):

  • WebKitSupport/DOMSupport.h:
  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::requestedSelectionHandlePosition):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

  • WebKitSupport/SelectionHandler.h:

(SelectionHandler):

7:04 AM Changeset in webkit [143460] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix usage of HitTestRequest::RequestType
https://bugs.webkit.org/show_bug.cgi?id=110342

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-20
Reviewed by Carlos Garcia Campos.

Rename HitTestResult::* -> HitTestRequest::*
This was introduced by mistake in r142977.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::hitTestResult):

6:39 AM Changeset in webkit [143459] by yurys@chromium.org
  • 1 edit
    2 copies in branches/chromium/1410

Merge 142594

Web Inspector: stack trace is cut at native bind if inspector is closed
https://bugs.webkit.org/show_bug.cgi?id=109427

Reviewed by Pavel Feldman.

Source/WebCore:

Only top frame is collected instead of full stack trace when inspector
front-end is closed to avoid expensive operations when exceptions are
thrown.

Test: http/tests/inspector-enabled/console-exception-while-no-inspector.html

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):

LayoutTests:

Test that stack trace for uncaught exceptions is collected when inspector
front-end is closed.

  • http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
  • http/tests/inspector-enabled/console-exception-while-no-inspector.html: Added.
  • platform/chromium/http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.

TBR=yurys@chromium.org
Review URL: https://codereview.chromium.org/12324011

6:24 AM Changeset in webkit [143458] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations: Marked touch event emulation test as failing.
6:10 AM Changeset in webkit [143457] by jochen@chromium.org
  • 11 edits
    4 moves in trunk/Tools

[chromium] move most of the remaining mocks to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=110217

Reviewed by Nico Weber.

While most of the functionality provided by these mocks is also
available in the content module, there is no straight forward way to
inject the mock results required for layout tests.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestRunner):
(WebTestRunner::WebTestProxy::geolocationClient):
(WebTestRunner::WebTestProxy::speechInputController):
(WebTestRunner::WebTestProxy::speechRecognizer):
(WebTestRunner::WebTestProxy::deviceOrientationClient):
(WebTestRunner::WebTestProxy::requestPointerLock):
(WebTestRunner::WebTestProxy::requestPointerUnlock):
(WebTestRunner::WebTestProxy::isPointerLocked):

  • DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.

(WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
(WebTestRunner):
(WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
(WebTestRunner::MockWebSpeechInputController::setDelegate):
(WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
(WebTestRunner::MockWebSpeechInputController::setDumpRect):
(WebTestRunner::MockWebSpeechInputController::clearResults):
(WebTestRunner::MockWebSpeechInputController::startRecognition):
(WebTestRunner::MockWebSpeechInputController::cancelRecognition):
(WebTestRunner::MockWebSpeechInputController::stopRecording):
(WebTestRunner::MockWebSpeechInputController::speechTaskFired):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
(WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):

  • DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.

(WebKit):
(WebTestRunner):
(MockWebSpeechInputController):
(WebTestRunner::MockWebSpeechInputController::taskList):
(SpeechTask):

  • DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.

(WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
(WebTestRunner):
(WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
(WebTestRunner::MockWebSpeechRecognizer::setDelegate):
(WebTestRunner::MockWebSpeechRecognizer::start):
(WebTestRunner::MockWebSpeechRecognizer::stop):
(WebTestRunner::MockWebSpeechRecognizer::abort):
(WebTestRunner::MockWebSpeechRecognizer::addMockResult):
(WebTestRunner::MockWebSpeechRecognizer::setError):
(WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
(WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
(WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):

  • DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.

(WebKit):
(WebTestRunner):
(MockWebSpeechRecognizer):
(WebTestRunner::MockWebSpeechRecognizer::wasAborted):
(WebTestRunner::MockWebSpeechRecognizer::client):
(WebTestRunner::MockWebSpeechRecognizer::handle):
(WebTestRunner::MockWebSpeechRecognizer::taskList):
(Task):
(WebTestRunner::MockWebSpeechRecognizer::Task::Task):
(WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
(StepTask):
(WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::windowOpened):
(WebTestRunner):
(WebTestRunner::TestInterfaces::windowClosed):
(WebTestRunner::TestInterfaces::windowList):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::requestPointerLock):
(WebTestRunner):
(WebTestRunner::TestRunner::requestPointerUnlock):
(WebTestRunner::TestRunner::isPointerLocked):
(WebTestRunner::TestRunner::didAcquirePointerLockInternal):
(WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
(WebTestRunner::TestRunner::didLosePointerLockInternal):
(WebTestRunner::TestRunner::windowCount):
(WebTestRunner::TestRunner::setMockDeviceOrientation):
(WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
(WebTestRunner::TestRunner::setGeolocationPermission):
(WebTestRunner::TestRunner::setMockGeolocationPosition):
(WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
(WebTestRunner::TestRunner::addMockSpeechInputResult):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
(WebTestRunner::TestRunner::setMockSpeechRecognitionError):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::didAcquirePointerLock):
(WebTestRunner::TestRunner::didNotAcquirePointerLock):
(WebTestRunner::TestRunner::didLosePointerLock):
(WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner):
(TestRunner):
(HostMethodTask):
(WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
(WebTestRunner::TestRunner::HostMethodTask::runIfValid):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::setInterfaces):
(WebTestRunner::WebTestProxyBase::setDelegate):
(WebTestRunner::WebTestProxyBase::reset):
(WebTestRunner::WebTestProxyBase::captureTree):
(WebTestRunner::WebTestProxyBase::geolocationClientMock):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
(WebTestRunner::WebTestProxyBase::speechInputControllerMock):
(WebTestRunner::WebTestProxyBase::speechRecognizerMock):
(WebTestRunner::WebTestProxyBase::geolocationClient):
(WebTestRunner::WebTestProxyBase::speechInputController):
(WebTestRunner::WebTestProxyBase::speechRecognizer):
(WebTestRunner::WebTestProxyBase::deviceOrientationClient):
(WebTestRunner::WebTestProxyBase::requestPointerLock):
(WebTestRunner::WebTestProxyBase::requestPointerUnlock):
(WebTestRunner::WebTestProxyBase::isPointerLocked):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::reset):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebKit):
(WebViewHost):

5:42 AM Changeset in webkit [143456] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed. Correcting gardening after r143436.

  • platform/qt/TestExpectations:
5:40 AM Changeset in webkit [143455] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: fix for frontend closure compile errors.
https://bugs.webkit.org/show_bug.cgi?id=110329

Reviewed by Vsevolod Vlasov.

It has no tests because it has no code changes.

  • inspector/front-end/HeapSnapshot.js:

(HeapSnapshotMetainfo):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):

5:38 AM Changeset in webkit [143454] by fmalita@chromium.org
  • 4 edits
    2 adds in trunk

Clear SVGPathSeg role on removal.
https://bugs.webkit.org/show_bug.cgi?id=110058

Reviewed by Dirk Schulze.

Source/WebCore:

SVGPathSegListPropertyTearOff::initialize() and SVGPathSegListPropertyTearOff::replaceItem()
need to clear the context and role for segments being expunged from the list, similarly to
removeItem(). Otherwise, processIncomingListItemValue() can get confused and attempt to
remove stale segments.

Test: svg/dom/SVGPathSegList-crash.html

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):
(WebCore::SVGPathSegListPropertyTearOff::clear):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore):

  • svg/properties/SVGPathSegListPropertyTearOff.h:

(WebCore::SVGPathSegListPropertyTearOff::initialize):
(SVGPathSegListPropertyTearOff):

LayoutTests:

  • svg/dom/SVGPathSegList-crash-expected.txt: Added.
  • svg/dom/SVGPathSegList-crash.html: Added.
4:45 AM Changeset in webkit [143453] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r143434.
http://trac.webkit.org/changeset/143434
https://bugs.webkit.org/show_bug.cgi?id=110326

added reftest fails on chromium mac 10.6 (Requested by
toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-20

Source/WebCore:

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

  • fast/forms/file/file-vertical-padding-border-expected.html: Removed.
  • fast/forms/file/file-vertical-padding-border.html: Removed.
4:36 AM Changeset in webkit [143452] by abecsi@webkit.org
  • 2 edits in trunk/Tools

[Qt] Make debug builds possible on 32bit Linux
https://bugs.webkit.org/show_bug.cgi?id=110231

Reviewed by Tor Arne Vestbø.

Use the stabs format for debug builds to make the object files
a bit smaller so that they can be linked on a 32bit system.

  • qmake/mkspecs/features/unix/default_post.prf:
4:33 AM Changeset in webkit [143451] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: Make UISourceCode.path() an array of path segments.
https://bugs.webkit.org/show_bug.cgi?id=110229

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate.prototype._filePathForPath):
(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._contentTypeForPath):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate.prototype.requestFileContent):
(WebInspector.SimpleProjectDelegate.prototype.searchInFileContent):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleProjectDelegate.prototype._ensureUniquePath):
(WebInspector.SimpleProjectDelegate.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFileByName):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.uri):

  • inspector/front-end/Workspace.js:

(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCode):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.urlForPath):

LayoutTests:

  • inspector/workspace-mapping.html:
4:17 AM Changeset in webkit [143450] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update expectation for chromium gardening.
https://bugs.webkit.org/show_bug.cgi?id=110324

  • platform/chromium/TestExpectations:
4:15 AM Changeset in webkit [143449] by yurys@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: fix message for non-existent domain warning
https://bugs.webkit.org/show_bug.cgi?id=110315

Reviewed by Alexander Pavlov.

Only send (Heap)Profiler.resetProfiles event if the client has
requested profile headers before.

  • inspector/InspectorHeapProfilerAgent.cpp:

(HeapProfilerAgentState):
(WebCore):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorHeapProfilerAgent::clearFrontend):
(WebCore::InspectorHeapProfilerAgent::restore):
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):

  • inspector/InspectorHeapProfilerAgent.h:

(InspectorHeapProfilerAgent):

  • inspector/InspectorProfilerAgent.cpp:

(ProfilerAgentState):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore):
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorProfilerAgent::restore):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

4:06 AM Changeset in webkit [143448] by vsevik@chromium.org
  • 25 edits
    2 adds in trunk

Web Inspector: Move workspace specific code from FileMapping to workspace.
https://bugs.webkit.org/show_bug.cgi?id=110219

Reviewed by Pavel Feldman.

Source/WebCore:

Extracted workspace specific code from FileMapping to Workspace.
This allows to reduce usage of uri and eventually make UISourceCode.path an array of path segments.

Test: inspector/workspace-mapping.html

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.rawLocationToUILocation):

  • inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.get addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.get addScript):

  • inspector/front-end/FileMapping.js:

(WebInspector.FileMapping):
(WebInspector.FileMapping.prototype.mappingEntryForURL):
(WebInspector.FileMapping.prototype.mappingEntryForPath):

  • inspector/front-end/FileSystemMapping.js:

(WebInspector.FileSystemMapping.prototype.fileSystemPathForPrefix):
(WebInspector.FileSystemMappingImpl.prototype.addFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.removeFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPathForPrefix):

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):

  • inspector/front-end/IsolatedFileSystemManager.js:

(WebInspector.IsolatedFileSystemManager):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._workspaceUISourceCodeForScript):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.displayNameForURL):

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(WebInspector.SASSSourceMapping.prototype._bindUISourceCode):
(WebInspector.SASSSourceMapping.prototype.rawLocationToUILocation):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleWorkspaceProvider.pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._resourceAdded):
(WebInspector.StylesSourceMapping.prototype._mainFrameCreatedOrNavigated):
(WebInspector.StyleContentBinding):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):

  • inspector/front-end/Workspace.js:

(WebInspector.Workspace):
(WebInspector.Workspace.prototype.hasMappingForURL):
(WebInspector.Workspace.prototype._fileSystemPathForEntry):
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
(WebInspector.Workspace.prototype.urlForPath):

  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.createWorkspace):

  • inspector/debugger/network-uisourcecode-provider.html:
  • inspector/file-mapping-expected.txt:
  • inspector/file-mapping.html:
  • inspector/file-system-mapping-expected.txt:
  • inspector/file-system-mapping.html:
  • inspector/file-system-project.html:
  • inspector/workspace-mapping-expected.txt: Added.
  • inspector/workspace-mapping.html: Added.
3:48 AM Changeset in webkit [143447] by toyoshim@chromium.org
  • 3 edits in trunk/Tools

Unreviewed. Add myself to watch lists.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
3:25 AM Changeset in webkit [143446] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit/blackberry

Unreviewed BlackBerry build fix.

WebPage::download was renamed in the header by mistake to
convertMainResourceLoadToDownload in r137845.

  • Api/WebPage.h:
3:18 AM Changeset in webkit [143445] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for tests added in r143395, r143420 and r143439.
  • platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r143386.
3:08 AM Changeset in webkit [143444] by Christophe Dumez
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Port EwkPopupMenuItem to the C API
https://bugs.webkit.org/show_bug.cgi?id=108798

Reviewed by Kenneth Rohde Christiansen.

Make use of the new WKPopupItem C API inside EwkPopupMenuItem to remove
dependency on internal WebPopupItem type. Eina shared string members
are now lazily initialized to make the object cheaper to construct.

  • UIProcess/API/efl/ewk_popup_menu.cpp:

(EwkPopupMenu::EwkPopupMenu):

  • UIProcess/API/efl/ewk_popup_menu_item.cpp:

(EwkPopupMenuItem::EwkPopupMenuItem):
(EwkPopupMenuItem::type):
(EwkPopupMenuItem::textDirection):
(EwkPopupMenuItem::text):
(EwkPopupMenuItem::tooltipText):
(EwkPopupMenuItem::accessibilityText):
(EwkPopupMenuItem::hasTextDirectionOverride):
(EwkPopupMenuItem::isEnabled):
(EwkPopupMenuItem::isLabel):
(EwkPopupMenuItem::isSelected):

  • UIProcess/API/efl/ewk_popup_menu_item_private.h:

(EwkPopupMenuItem::create):
(EwkPopupMenuItem):

3:01 AM Changeset in webkit [143443] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: Introduce SecurityOriginAdded and SecurityOriginRemoved events into ResourceTreeModel
https://bugs.webkit.org/show_bug.cgi?id=110232

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._addSecurityOrigin): Added.
(WebInspector.ResourceTreeModel.prototype._removeSecurityOrigin): Added.
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached): Added.
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):

LayoutTests:

  • http/tests/inspector/resource-tree/resource-tree-events-expected.txt:
  • http/tests/inspector/resource-tree/resource-tree-events.html:
2:01 AM Changeset in webkit [143442] by dominik.rottsches@intel.com
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations: Marked new failing ref test svg/as-background-image/tiled-background-image.html.
  • platform/efl/fast/js/global-constructors-expected.txt: Rebaselined, MutationObserver constructor now found.
1:58 AM Changeset in webkit [143441] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[v8] ScriptValue has dangerous copy semantics
https://bugs.webkit.org/show_bug.cgi?id=110206

Patch by Dan Carney <dcarney@google.com> on 2013-02-20
Reviewed by Kentaro Hara.

Update ScriptValue to used a SharedPersistent,
making it impossible to return dead references.

No new tests. No change in functionality.

  • bindings/v8/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):

  • bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(ScriptValue):
(WebCore::ScriptValue::v8Value):
(WebCore::ScriptValue::v8ValueRaw):

  • bindings/v8/SharedPersistent.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::scriptValueAsNode):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAttrGetterCustom):

1:44 AM Changeset in webkit [143440] by commit-queue@webkit.org
  • 7 edits in trunk

Web Inspector: highlight undefined word in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=109585

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-20
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test enhancement: inspector/syntax-highlight-javascript.html

Add global object value properties to tokenizer and add a css style
class to highlight "undefined" with gray color.

  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:
  • inspector/front-end/inspectorSyntaxHighlight.css:

(.webkit-javascript-undef):

LayoutTests:

Enhance layout test to verify highlighting of global object value properties.

  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/syntax-highlight-javascript.html:
1:43 AM Changeset in webkit [143439] by mkwst@chromium.org
  • 8 edits in trunk

Use EventPathWalker rather than parentNode() to normalize event targets in EventHandler.
https://bugs.webkit.org/show_bug.cgi?id=110037

Reviewed by Ryosuke Niwa.

Source/WebCore:

We need to teach EventHandler about Shadow DOM in a few places in order
to ensure that we properly target events dispatched upon text nodes.
Rather than naively grabbing the text node's direct parent via
parentNode(), we need to account for the case in which the text node is
distributed[1] to an insertion point inside a shadow host.
EventPathWalker::parent understands these relationships, and should
be used when dealing with mouse, drag, and touch events.

[1]: http://www.w3.org/TR/shadow-dom/#dfn-distribution

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::passGestureEventToWidgetIfPossible):
(WebCore::EventHandler::updateDragAndDrop):

Refactor parentNode callsites to use EventPathWalker::parent().

LayoutTests:

  • fast/dom/shadow/resources/event-dispatching.js:

(scrollMouseWheel):
(addEventListeners):

Add MouseWheel, Drag, and Touch support to the event-dispatching
tests in Shadow DOM.

  • fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html:
  • fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root.html:

Scroll the mouse wheel, drag a bit, and touch before leaving the
text node, and record the generated events.

1:24 AM Changeset in webkit [143438] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Regression] Search in ProfilesPanel is broken
https://bugs.webkit.org/show_bug.cgi?id=110312

Reviewed by Pavel Feldman.

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileView.prototype.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):

1:21 AM Changeset in webkit [143437] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: View.markAsRoot should never be invoked on attached view.
https://bugs.webkit.org/show_bug.cgi?id=110224

Reviewed by Pavel Feldman.

This will cause CSS loading problems after "show".

  • inspector/front-end/Drawer.js:

Ensure child view is detached before marked as root.

  • inspector/front-end/View.js:

(WebInspector.View.prototype.markAsRoot): Added assertion.

1:17 AM Changeset in webkit [143436] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/TestExpectations:
  • platform/qt/fast/js/global-constructors-expected.txt: Rebaseline after r143420.
1:06 AM Changeset in webkit [143435] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardenning. Unskip now passing tests.
https://bugs.webkit.org/show_bug.cgi?id=99306

  • platform/qt-5.0-wk2/TestExpectations:
12:10 AM Changeset in webkit [143434] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

File upload control doesn't apply CSS vertical padding or border to file name
https://bugs.webkit.org/show_bug.cgi?id=109011

Patch by Nils Barth <nbarth@google.com> on 2013-02-20
Reviewed by Hajime Morrita.

Source/WebCore:

Test: fast/forms/file/file-vertical-padding-border.html

  • rendering/RenderFileUploadControl.cpp:

Add borderTop() and paddingTop() when computing position.

(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

  • fast/forms/file/file-vertical-padding-border.html: Added.
  • fast/forms/file/file-vertical-padding-border-expected.html: Added.

Feb 19, 2013:

11:42 PM Changeset in webkit [143433] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark fast/regions/seamless-iframe-flowed-into-regions.html failure
https://bugs.webkit.org/show_bug.cgi?id=110283

Unreviewed. This test is added by r143256 and it is failing.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-19

  • platform/efl/TestExpectations:
10:54 PM Changeset in webkit [143432] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Few methods in WebGLRenderingContext.idl have incorrect signatures
https://bugs.webkit.org/show_bug.cgi?id=110305

Reviewed by Kentaro Hara.

  • html/canvas/WebGLRenderingContext.idl:
10:14 PM Changeset in webkit [143431] by commit-queue@webkit.org
  • 4 edits
    16 adds
    1 delete in trunk/LayoutTests

Unreviewed, rolling out r143393.
http://trac.webkit.org/changeset/143393
https://bugs.webkit.org/show_bug.cgi?id=110302

the converted reftest fails in chromium mac 10.6 and 10.7
(Requested by toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

  • fast/flexbox/box-orient-button.html:
  • fast/flexbox/resources/box-orient-button.js:
  • fast/invalid/residual-style-expected.html: Removed.
  • fast/invalid/residual-style.html:
  • platform/chromium-android/fast/invalid/residual-style-expected.png: Added.
  • platform/chromium-android/fast/invalid/residual-style-expected.txt: Added.
  • platform/chromium-linux/fast/invalid/residual-style-expected.png: Added.
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt: Added.
  • platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Added.
  • platform/chromium-mac/fast/invalid/residual-style-expected.png: Added.
  • platform/chromium-mac/fast/invalid/residual-style-expected.txt: Added.
  • platform/chromium-win/fast/invalid/residual-style-expected.png: Added.
  • platform/chromium-win/fast/invalid/residual-style-expected.txt: Added.
  • platform/efl/fast/invalid/residual-style-expected.png: Added.
  • platform/efl/fast/invalid/residual-style-expected.txt: Added.
  • platform/gtk/fast/invalid/residual-style-expected.png: Added.
  • platform/gtk/fast/invalid/residual-style-expected.txt: Added.
  • platform/mac/fast/invalid/residual-style-expected.png: Added.
  • platform/mac/fast/invalid/residual-style-expected.txt: Added.
10:02 PM Changeset in webkit [143430] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, uninteresting change to test a theory about bad dependency handling.

  • API/JSStringRefCF.cpp:

(JSStringCreateWithCFString): Remove an unnecessary else clause.

9:57 PM Changeset in webkit [143429] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Unreviewed, rolling out r143338.
http://trac.webkit.org/changeset/143338
https://bugs.webkit.org/show_bug.cgi?id=110301

False alarm, no need to export the symbol (Requested by
aandrey on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

  • WebKit.vcproj/WebKitExports.def.in:
9:53 PM Changeset in webkit [143428] by timothy_horton@apple.com
  • 15 edits in trunk/Source

Clarify isInWindow vs. isVisible path through to RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=110261
<rdar://problem/13196122>

Reviewed by Simon Fraser.

Remove RenderLayerCompositor::willMoveOffscreen/didMoveOnscreen.
Add RenderLayerCompositor::setIsInWindow, and pipe in-window changes through from Page::setIsInWindow.
Adjust a few Document functions that previously called RenderView::didMoveOnscreen/willMoveOffscreen to use setIsInWindow instead, since in-win$

  • WebCore.exp.in: Export Page::setIsInWindow.
  • dom/Document.cpp:

(WebCore::Document::attach): Use setIsInWindow instead of didMoveOnscreen.
(WebCore::Document::documentWillBecomeInactive): Use setIsInWindow instead of willMoveOffscreen.
(WebCore::Document::documentDidResumeFromPageCache): Use setIsInWindow instead of didMoveOnscreen.

  • page/FrameView.cpp:

(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
RenderView doesn't care about moving on/offscreen, just in-window state.
(WebCore::FrameView::setIsInWindow): Added. Forward isInWindow changes to our RenderView.

  • page/FrameView.h:

(FrameView): Add setIsInWindow.

  • page/Page.cpp:

(WebCore::Page::setIsInWindow): Added. Forward isInWindow changes to the Page's FrameViews.

  • page/Page.h:

(Page): Add setIsInWindow.
(WebCore::Page::isInWindow):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::setIsInWindow): Added. Replace willMoveOffscreen/didMoveOnscreen with setIsInWindow,
since that's the only change we actually care about.

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor): Add setIsInWindow.

  • rendering/RenderView.cpp:

(WebCore::RenderView::setIsInWindow): Added. Replace willMoveOffscreen/didMoveOnscreen with setIsInWindow,
since that's the only change RenderLayerCompositor actually cares about.

  • rendering/RenderView.h:

(RenderView): Add setIsInWindow.

  • WebView/WebView.mm:

(-[WebView viewWillMoveToWindow:]):
(-[WebView viewDidMoveToWindow]):
Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setIsInWindow):
Use Page::setIsInWindow in addition to willMoveOffscreen/didMoveOnscreen.

9:24 PM Changeset in webkit [143427] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Cleanup and add JSDocs to SuggestBox
https://bugs.webkit.org/show_bug.cgi?id=110202

Reviewed by Pavel Feldman.

SuggestBox contains some obsolete/unused code and not fully
covered with JSDocs.

  • inspector/front-end/SuggestBox.js:

(WebInspector.SuggestBox.prototype.visible):
Replaced getter with function.
(WebInspector.SuggestBox.prototype._onScrollOrResize):
Use camel-case for function names.
(WebInspector.SuggestBox.prototype._onBoxMouseDown): Ditto.
(WebInspector.SuggestBox.prototype.updateSuggestions):
Removed unused code.
(WebInspector.SuggestBox.prototype.hide): Adopt changes.
(WebInspector.SuggestBox.prototype._applySuggestion): Ditto.

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.isSuggestBoxVisible): Ditto.

7:05 PM Changeset in webkit [143426] by hayato@chromium.org
  • 5 edits in trunk/Source/WebCore

Calculate EventPath in EventDispatcher's constructor.
https://bugs.webkit.org/show_bug.cgi?id=109905

Reviewed by Dimitri Glazkov.

This patch calculates an EventPath in EventDispatcher's
constructor and removes EventDispatcher::ensureEventPath().
We don't have any reason to initialize an EventPath lazily.

No tests. No change in behavior.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatch):

  • dom/EventDispatcher.h:

(WebCore::EventDispatcher::eventPath):
(EventDispatcher):

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

6:49 PM Changeset in webkit [143425] by jsbell@chromium.org
  • 2 edits in trunk/Tools

Remove warning from run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=110285

Reviewed by Kentaro Hara.

Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
"Unknown option: idlattributesfile". That option was removed from
bindings/scripts/preprocess-idls.pl but was still being passed by
the test script. Remove it.

  • Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency): Remove unused arg.

6:46 PM Changeset in webkit [143424] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed, rolling out r143400.
http://trac.webkit.org/changeset/143400
https://bugs.webkit.org/show_bug.cgi?id=110290

breaks everything (instacrash launching Safari) (Requested by
thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

  • wtf/FastMalloc.cpp:

(WTF::internalEntropyValue):
(WTF):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):

6:28 PM Changeset in webkit [143423] by Simon Fraser
  • 3 edits
    2 adds in trunk

Fix TileCache tile size when zoomed on slow-scrolling site
https://bugs.webkit.org/show_bug.cgi?id=110289

Source/WebCore:

Reviewed by Tim Horton.

In slow scrolling mode, we use the tile coverage rect as the tile size
(so a single tile covers the viewport). When zoomed, the tile coverage rect
shrinks relative to the TileCache, so scale the tile size back up.

Test: platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::tileSizeForCoverageRect):

LayoutTests:

Reviewed by Tim Horton.

Test that dumps tile coverage in a slow-scrolling, zoomed page.

  • platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html: Added.
6:27 PM Changeset in webkit [143422] by hayato@chromium.org
  • 12 edits
    2 moves in trunk/Source/WebCore

Rename AncestorChainWalker.
https://bugs.webkit.org/show_bug.cgi?id=110146

Reviewed by Dimitri Glazkov.

Rename AncestorChainWalker to EventPathWalker.
The term of EventPath is used in DOM Core spec. EventPath was
already introduced into a EventContext.h in r112055. We should
spread this term into the Walker class since they share the same
purpose.

No new tests, no behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/EventDispatcher.cpp:
  • dom/EventPathWalker.cpp: Renamed from Source/WebCore/dom/AncestorChainWalker.cpp.

(WebCore):
(WebCore::EventPathWalker::EventPathWalker):
(WebCore::EventPathWalker::parent): parent() is now a static function to cover simple use cases.
(WebCore::EventPathWalker::moveToParent): Renamed from parent().

  • dom/EventPathWalker.h: Renamed from Source/WebCore/dom/AncestorChainWalker.h.

(WebCore):
(EventPathWalker):
(WebCore::EventPathWalker::node):
(WebCore::EventPathWalker::isVisitingInsertionPointInReprojection): Renamed from isCrossingInsertionPoint().

  • dom/EventRetargeter.cpp:

(WebCore::EventRetargeter::calculateEventPath):
(WebCore::EventRetargeter::buildRelatedNodeMap):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::focusedNode):

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::handleWheelEvent):

5:59 PM Changeset in webkit [143421] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Snapshotted plugin label should not be selectable
https://bugs.webkit.org/show_bug.cgi?id=110286

Reviewed by Simon Fraser.

Update the CSS to make it clear that you should click
on a snapshot (use the finger pointer) and disable
text selection.

  • css/plugIns.css:

(embed::-webkit-snapshotted-plugin-content .snapshot-container .snapshot-label):

5:56 PM Changeset in webkit [143420] by hmuller@adobe.com
  • 3 edits
    2 adds in trunk

[CSS Exclusions] Enable shape-inside support for ellipses
https://bugs.webkit.org/show_bug.cgi?id=109868

Reviewed by Dirk Schulze.

Source/WebCore:

This change is very similar to the one recently made for circles:
removed the test that disabled ellipse values for shape-inside.
The remaining support for ellipses, which is based on rounded rectangles
whose width/height is equal to their radiusX/radiusY, has not changed.

Test: fast/exclusions/shape-inside/shape-inside-ellipse.html

  • rendering/ExclusionShapeInsideInfo.h:

(WebCore::ExclusionShapeInsideInfo::isEnabledFor): No longer disallows any BasicShape type.

LayoutTests:

Added a test for ellipse shape-inside values.

  • fast/exclusions/shape-inside/shape-inside-ellipse-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-ellipse.html: Added.
5:46 PM Changeset in webkit [143419] by commit-queue@webkit.org
  • 13 edits
    5 adds in trunk

'round' not implemented in border-image
https://bugs.webkit.org/show_bug.cgi?id=14185

Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-19
Reviewed by David Hyatt.

Source/WebCore:

Add rendering support for 'round' keyword of border-image-repeat CSS property
http://dev.w3.org/csswg/css3-background/#border-image-repeat
Rebased original patch by Benjamin Otte <otte@gnome.org> and made few fixes.

Test: fast/borders/border-image-02.html

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawTiledImage):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(Image):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage): For 'round' keyword,
the image is tiled (repeated) to fill the area. If it does not fill the area
with a whole number of tiles, the image is rescaled so that it does.

LayoutTests:

Added test for 'round' keyword of border-image-repeat CSS property
http://dev.w3.org/csswg/css3-background/#border-image-repeat

  • fast/borders/border-image-02.html: Added.
  • platform/chromium-linux/fast/borders/border-image-02-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/borders/border-image-02-expected.txt: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/fast/borders/border-image-02-expected.png: Added.
  • platform/gtk/fast/borders/border-image-02-expected.txt: Added.
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
5:42 PM Changeset in webkit [143418] by commit-queue@webkit.org
  • 18 edits in trunk/Source

Allow UI clients to handle vertical wheel events.
https://bugs.webkit.org/show_bug.cgi?id=110006

Patch by Conrad Shultz <Conrad Shultz> on 2013-02-19
Reviewed by Tim Horton.

Source/WebCore:

Add API to allow matching changes in WebKit2 to control rubber-banding behavior at vertical page extrema.
If rubber-banding is disabled during a scroll event that would otherwise trigger rubber-banding, dispatch
didNotHandleWheelEvent() to the page UI client.

  • WebCore.exp.in:

Export new rubber-banding API.

  • page/Page.cpp:

(WebCore):
(WebCore::Page::rubberBandsAtBottom):
Proxy for the corresponding function in ScrollingCoordinator.
(WebCore::Page::setRubberBandsAtBottom):
Ditto.
(WebCore::Page::rubberBandsAtTop):
Ditto.
(WebCore::Page::setRubberBandsAtTop):
Ditto.

  • page/Page.h:

(Page):
Declare new rubber-banding API (above).

  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::rubberBandsAtBottom):
Stub API implementation.
(WebCore::ScrollingCoordinator::setRubberBandsAtBottom):
Ditto.
(WebCore::ScrollingCoordinator::rubberBandsAtTop):
Ditto.
(WebCore::ScrollingCoordinator::setRubberBandsAtTop):
Ditto.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
Initialize new member variables.
(WebCore::ScrollingTree::setMainFramePinState):
Set top/bottom pinned states.
(WebCore::ScrollingTree::rubberBandsAtBottom):
New accessor function.
(WebCore::ScrollingTree::setRubberBandsAtBottom):
New mutator function.
(WebCore::ScrollingTree::rubberBandsAtTop):
New accessor function.
(WebCore::ScrollingTree::setRubberBandsAtTop):
New mutator function.
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
Start a vertical swipe event if the frame is pinned at the top or bottom and associated rubber-banding is disabled.

  • page/scrolling/ScrollingTree.h:

(ScrollingTree):
Declare new rubber-banding API and associated member variables.

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollingCoordinatorMac):
Declare API overrides.

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::rubberBandsAtBottom):
Method override; proxy to corresponding function in ScrollingTree.
(WebCore::ScrollingCoordinatorMac::setRubberBandsAtBottom):
Ditto.
(WebCore::ScrollingCoordinatorMac::rubberBandsAtTop):
Ditto.
(WebCore::ScrollingCoordinatorMac::setRubberBandsAtTop):
Ditto.

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::pinnedInDirection):
Remove trailing whitespace.
(WebCore::ScrollingTreeScrollingNodeMac::updateMainFramePinState):
Calculate and pass vertical pinning state to ScrollingTree::setMainFramePinState().

Source/WebKit2:

Add API to allow clients to selectively control rubber-banding at vertical page extrema.

  • UIProcess/API/C/WKPage.cpp:

(WKPageRubberBandsAtBottom):
Proxy for the corresponding function in WebCore::Page.
(WKPageSetRubberBandsAtBottom):
Ditto.
(WKPageRubberBandsAtTop):
Ditto.
(WKPageSetRubberBandsAtTop):
Ditto.

  • UIProcess/API/C/WKPage.h:

Declare new API.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Initialize new member variables.
(WebKit::WebPageProxy::setRubberBandsAtBottom):
New function; dispatches a matching message to the WebKit::WebPage.
(WebKit::WebPageProxy::setRubberBandsAtTop):
Ditto.

  • UIProcess/WebPageProxy.h:

(WebPageProxy):
Declare new API.
(WebKit::WebPageProxy::rubberBandsAtBottom):
New accessor function.
(WebKit::WebPageProxy::rubberBandsAtTop):
Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setRubberBandsAtBottom):
New function; call the matching function on the associated WebCore::Page.
(WebKit::WebPage::setRubberBandsAtTop):
Ditto.

  • WebProcess/WebPage/WebPage.h:

(WebPage):
Declare new rubber-banding API.

  • WebProcess/WebPage/WebPage.messages.in:

Declare new rubber-banding API.

5:29 PM Changeset in webkit [143417] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Rubber-banding should not affect the visibleRect of the TileCache
https://bugs.webkit.org/show_bug.cgi?id=110278

Reviewed by Beth Dakin.

When rubber-banding a slow-scrolling page, or image document, we would constantly re-create
the bottom tile because of the logic that adapts the tile size to the visible rect when slow
scrolling.

Avoid that by ensuring that the visibleRect is not affected by rubber-banding. This is done
via a GraphicsLayerClient function that allows RenderLayerCompositor to provide a custom
position for the scroll layer. We constrain that scroll position to remove the overhang that
results from rubber-banding.

I wasn't able to make a test for this, even with internals.setScrollViewPosition().

  • platform/graphics/GraphicsLayerClient.h:

(GraphicsLayerClient):
(WebCore::GraphicsLayerClient::customPositionForVisibleRectComputation):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::computeVisibleRect):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::customPositionForVisibleRectComputation):

  • rendering/RenderLayerCompositor.h:
5:24 PM Changeset in webkit [143416] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/win

Unreviewed, force file to recompile to fix win build.

  • WebView.cpp:
5:20 PM Changeset in webkit [143415] by tonyg@chromium.org
  • 8 edits in trunk/Source/WebCore

Fix crash in preloading scanning base tags with no href attribute for background parser
https://bugs.webkit.org/show_bug.cgi?id=110276

Reviewed by Eric Seidel.

Previously a <base> tag without an href attribute (like the one in fast/dom/HTMLAnchorElement/set-href-attribute-rebase.html)
would crash the background parser's preload scanner.

To fix that, we only call stripLeadingAndTrailingHTMLSpaces() if the href attribute is non-null. This matches the main thread parser.

Along with this, I decided to templatize updatePredictedBaseURL() so that the main and background parser can share the same impl.

This required making CompactHTMLToken and HTMLToken a little more similar:

  1. Give HTMLToken a getAttributeItem() method.
  2. Move CompactAttribute to CompactHTMLToken::Attribute and make it a struct.

No new tests because covered by existing tests.

  • html/parser/AtomicHTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/CompactHTMLToken.cpp:

(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken):
(WebCore::CompactHTMLToken::getAttributeItem):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):

  • html/parser/CompactHTMLToken.h:

(WebCore::CompactHTMLToken::Attribute::Attribute):
(Attribute):
(WebCore::CompactHTMLToken::attributes):
(CompactHTMLToken):
(WebCore::CompactHTMLToken::publicIdentifier):
(WebCore::CompactHTMLToken::systemIdentifier):

  • html/parser/HTMLParserIdioms.h:

(WebCore):
(WebCore::stripLeadingAndTrailingHTMLSpaces):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore):
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):

  • html/parser/HTMLPreloadScanner.h:
  • html/parser/HTMLToken.h:

(WebCore::HTMLToken::getAttributeItem):
(HTMLToken):

5:18 PM Changeset in webkit [143414] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit

Unreviewed, include exports for VS2010 as well.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
4:55 PM Changeset in webkit [143413] by dgrogan@chromium.org
  • 1 edit in branches/chromium/1410/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp

Merge 142890

IndexedDB: Add a few more histogram calls
https://bugs.webkit.org/show_bug.cgi?id=109762

Reviewed by Tony Chang.

A few places where commits could fail weren't being logged.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::Transaction::commit):

TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/12288067

4:48 PM Changeset in webkit [143412] by mark.lam@apple.com
  • 6 edits
    2 adds in trunk/Source/WebCore

Introducing AbstractSQLTransaction and AbstractSQLTransactionBackend.
https://bugs.webkit.org/show_bug.cgi?id=110273.

Reviewed by Anders Carlsson.

This is part of the webdatabase refactoring for webkit2.

  • Also changed the frontend and backend to only refer to the abstract interface of each other.

No new tests.

  • Modules/webdatabase/AbstractSQLTransaction.h: Added.

(AbstractSQLTransaction):
(WebCore::AbstractSQLTransaction::~AbstractSQLTransaction):

  • Modules/webdatabase/AbstractSQLTransactionBackend.h: Added.

(AbstractSQLTransactionBackend):
(WebCore::AbstractSQLTransactionBackend::~AbstractSQLTransactionBackend):

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::hasCallback):
(WebCore::SQLTransaction::hasSuccessCallback):
(WebCore::SQLTransaction::hasErrorCallback):
(WebCore::SQLTransaction::setBackend):

  • Modules/webdatabase/SQLTransaction.h:

(SQLTransaction):

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):

  • Modules/webdatabase/SQLTransactionBackend.h:

(SQLTransactionBackend):

  • Modules/webdatabase/SQLTransactionStateMachine.h:
4:47 PM Changeset in webkit [143411] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Silence some analyzer warnings
https://bugs.webkit.org/show_bug.cgi?id=110281

Reviewed by Mark Hahnenberg.

The static analyzer believes that callerCodeBlock can be null,
based on other code performing null tests. This should not
ever be the case, but we'll add RELEASE_ASSERTs to make it
obvious if we're ever wrong.

  • interpreter/Interpreter.cpp:

(JSC::getCallerInfo):

4:47 PM ExportingSymbols edited by tony@chromium.org
Updated path to win exports file. (diff)
4:45 PM Changeset in webkit [143410] by eae@chromium.org
  • 4 edits in trunk/Source/WebCore

Change computeStickyPositionConstraints to use LayoutBoxExtent for margins
https://bugs.webkit.org/show_bug.cgi?id=108872

Reviewed by Levi Weintraub.

Change RenderBoxModelObject::computeStickyPositionConstraints to
use a LayoutBoxExtent to represent margins.

No new tests, no change in functionality.

  • platform/graphics/LayoutRect.h:

(WebCore::LayoutRect::contract):
Add version contract methods that takes a LayoutBoxExtent object.

  • platform/graphics/LayoutSize.h:

(WebCore::LayoutSize::shrink):
Add shrink method.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computeStickyPositionConstraints):
Change to use a LayoutBoxExtent object to represent margins.

4:45 PM NewRunWebKitTests edited by dpranke@chromium.org
(diff)
4:45 PM Changeset in webkit [143409] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/win

Unreviewed, fix the Windows build after r143398.
Add new setters to the export list.

  • WebKit.vcproj/WebKitExports.def.in:
4:42 PM Changeset in webkit [143408] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Don't force everything to be blinded in debug builds
https://bugs.webkit.org/show_bug.cgi?id=110279

Reviewed by Mark Hahnenberg.

Switch to an explicit flag for indicating that we want
every constant to be blinded.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlind):

4:35 PM Changeset in webkit [143407] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Disable ASSERT(!hasInsertionPoint()) for background parser
https://bugs.webkit.org/show_bug.cgi?id=110251

Reviewed by Adam Barth.

The background parser crashes about 10 layout tests by hitting ASSERT(!hasInsertionPoint()).
Now, finish() is the thing that closes the HTMLInputStream which removes the insertion point.
In these tests, a document.open() calls insert() which clears the HTMLInputStream which causes
there to be an insertion point again.

With the main thread parser, insert() is called before finish() so the ASSERT passes.
However, with the threaded parser, finish() is called before insert(), so we fail the ASSERT.

This patch disables the ASSERT for the background parser because m_input isn't really relevant.
This causes us to pass the tests. However, there is a risk that now hasInsertionPoint() may be incorrect
and Document has a non-debug branch that tests hasInsertionPoint().

No new tests because covered by existing tests.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd):

4:34 PM Changeset in webkit [143406] by esprehn@chromium.org
  • 3 edits in trunk/Tools

Unreviewed. Add myself to watch lists.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
4:26 PM Changeset in webkit [143405] by hmuller@adobe.com
  • 2 edits in trunk/Tools

Unreviewed, corrected primary email.

  • Scripts/webkitpy/common/config/committers.py:
4:25 PM Changeset in webkit [143404] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

Separate constraining for overhang from fixed-position zooming behavior in scrollOffsetForFixedPosition()
https://bugs.webkit.org/show_bug.cgi?id=110267

Reviewed by Beth Dakin.

The static scrollOffsetForFixedPosition() function in ScrollingCoordinator did two things;
it constrained the scroll position when rubber-banding, and applied the special scaling for
fixed position when zoomed.

Separate these out so that we can use the rubber-banding constrained elsewhere.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollOffsetForFixedPosition): The static function is here now.

  • page/FrameView.h:
  • page/scrolling/ScrollingCoordinator.cpp: Code moved to FrameView.
  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition): scrollOffsetForFixedPosition()
is now on FrameView.

  • platform/ScrollableArea.cpp:

(WebCore::constrainedScrollPosition): Helper to constrain one axis for overhang.
(WebCore::ScrollableArea::constrainScrollPositionForOverhang): Static function that
can be called by FrameView::scrollOffsetForFixedPosition().

  • platform/ScrollableArea.h: Static function constrainScrollPositionForOverhang()

so we can call it from another thread. Also a member fuction of the same name, which takes
the scrollPosition as input (so we can feed it a layer position in a later patch).

4:20 PM Changeset in webkit [143403] by enne@google.com
  • 5 edits in trunk/Source

Unreviewed, rolling out r143382 and r143401.
http://trac.webkit.org/changeset/143382
http://trac.webkit.org/changeset/143401
https://bugs.webkit.org/show_bug.cgi?id=106457

Breaks Chromium win/mac canary compilation

Source/Platform:

  • chromium/public/Platform.h:

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::idbFactory):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

4:15 PM Changeset in webkit [143402] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix checkThatTokensAreSafeToSendToAnotherThread() now that the preload scanner is enabled
https://bugs.webkit.org/show_bug.cgi?id=110258

Reviewed by Adam Barth.

We were hitting this ASSERT on numerous tests with the background parser enabled. This copy fixes the assertion.

No new tests becuase covered by existing tests.

  • html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::setCharset):

4:14 PM Changeset in webkit [143401] by pilgrim@chromium.org
  • 4 edits in trunk/Source

[Chromium] Move WebKitPlatformSupport declaration to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=110262

Reviewed by Adam Barth.

In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.

Source/Platform:

  • chromium/public/Platform.h:

(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):

Source/WebKit/chromium:

  • public/platform/WebKitPlatformSupport.h:
4:13 PM Changeset in webkit [143400] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Moar hardening
https://bugs.webkit.org/show_bug.cgi?id=110275

Reviewed by Anders Carlsson.

We now poison objects when they get freed, and verify that
any object that is being freed is not poisoned. If the
object looks like it's poisoned we validate the freelist,
and ensure the object is not already present. If it is
we crash.

On allocation, we ensure that the object being allocated
is poisoned, then clear the poisoning fields.

  • wtf/FastMalloc.cpp:

(WTF::internalEntropyValue):
(WTF):
(WTF::freedObjectStartPoison):
(WTF::freedObjectEndPoison):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):

3:58 PM Changeset in webkit [143399] by tonyg@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix typo: inititatorFor->initiatorFor
https://bugs.webkit.org/show_bug.cgi?id=110260

Reviewed by Adam Barth.

No new tests because no changed functionality.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::initiatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):

  • html/parser/HTMLPreloadScanner.h:
3:38 PM Changeset in webkit [143398] by tony@chromium.org
  • 13 edits in trunk/Source

Convert 3 settings to use Settings.in
https://bugs.webkit.org/show_bug.cgi?id=109875

Reviewed by Ryosuke Niwa.

Source/WebCore:

Convert mediaEnabled, applicationChromeMode and DOMPasteAllowed to
use Settings.in. They previously had inconsistently named setters.

No new tests, this is a refactoring.

  • Source/WebCore/WebCore.exp.in: Remove symbols that are now inlined from exports.
  • Source/WebCore/WebCore.order: Remove symbols that no longer exist.
  • dom/make_names.pl:

(printConstructorInterior): Rename isMediaEnabled to mediaEnabled.
(printWrapperFunctions): Rename isMediaEnabled to mediaEnabled.

  • editing/EditorCommand.cpp:

(WebCore::supportedPaste): Rename isDOMPasteAllowed to DOMPasteAllowed.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Remove custom code.

  • page/Settings.h:

(Settings): Remove custom code.

  • page/Settings.in: Add entries for mediaEnabled, applicationChromeMode and DOMPasteAllowed.
  • page/make_settings.pl:

(setterFunctionName): Expand uppercase rules to include DOM.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isDefault): Rename inApplicationChromeMode to applicationChromeMode.

  • rendering/RenderThemeWin.cpp:

(WebCore::documentIsInApplicationChromeMode): Rename inApplicationChromeMode to applicationChromeMode.

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new): Rename isDOMPasteAllowed to DOMPasteAllowed.

3:34 PM Changeset in webkit [143397] by jchaffraix@webkit.org
  • 5 edits
    2 adds in trunk

[CSS Grid Layout] Refactor the code in preparation of auto placement support
https://bugs.webkit.org/show_bug.cgi?id=110244

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-auto-flow-resolution.html

In order to support auto placement, we need to iterate over the grid items with
auto row / column several times. This changes makes us do that in a very simple,
not-yet-conformant way. While touching this code, the distinction between grid-auto-flow
none and row / column was better drawn (and enforced).

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveGridPositionFromStyle):
Made it illegal to call resolveGridPositionFromStyle if the grid track is auto and
grid-auto-flow is not none. This would catch bad use of the function.

(WebCore::RenderGrid::maximumIndexInDirection):
Updated to bail out if the grid track is auto. Also improved the comment.

(WebCore::RenderGrid::placeItemsOnGrid):
Updated the function to do several iterations. Also handled the grid-auto-flow: none
case differently as it shouldn't need the extra iteration(s).

LayoutTests:

  • fast/css-grid-layout/grid-auto-flow-resolution-expected.txt: Added.
  • fast/css-grid-layout/grid-auto-flow-resolution.html: Added.
  • fast/css-grid-layout/implicit-position-dynamic-change.html:
  • fast/css-grid-layout/resources/grid.css:

(.autoRowAutoColumn):
(.firstRowAutoColumn):
(.secondRowAutoColumn):
(.thirdRowAutoColumn):
(.autoRowFirstColumn):
(.autoRowSecondColumn):
(.autoRowThirdColumn):
Added these helper classes, some will be used in a follow-up patch.

(.sizedToGridArea):
Hoisted this class into the common style.

3:31 PM Changeset in webkit [143396] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

StorageAreaProxy should know its quota
https://bugs.webkit.org/show_bug.cgi?id=110268

Reviewed by Sam Weinig.

Begin stubbing out StorageAreaProxy::setItem and add some quota member variables.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::StorageAreaProxy):
(WebKit::StorageAreaProxy::setItem):

  • WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

  • WebProcess/Storage/StorageNamespaceProxy.cpp:

(WebKit::StorageNamespaceProxy::createSessionStorageNamespace):
(WebKit::StorageNamespaceProxy::StorageNamespaceProxy):

  • WebProcess/Storage/StorageNamespaceProxy.h:

(WebKit::StorageNamespaceProxy::quota):
(StorageNamespaceProxy):

3:23 PM Changeset in webkit [143395] by hyatt@apple.com
  • 6 edits
    3 adds in trunk

[New Multicolumn] REGRESSION: RenderMultiColumnSets broken by the RenderRegion -> RenderBlock subclassing.
https://bugs.webkit.org/show_bug.cgi?id=110239.

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/multicol/newmulticol/column-rules-fixed-height.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::columnRectAt):
Make sure the columnGap() in the old multicolumn code is always expressed as a LayoutUnit. This was the
one place where it was still an int.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
Rework the painting of flow thread portions to account for the fact that regions paint at an integral
translation. This means you have to construct clipping around that integral destination. Subpixel layout
regions did not clip correctly as a result of this issue.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::columnRectAt):
Fix the same bug with columnGap() that the old column code has, i.e., one spot where it was an int.

(WebCore::RenderMultiColumnSet::paintObject):
RenderMultiColumnSet should be using paintObject and not paint and it needs to check for visibility
and phases now that it is a RenderBlock subclass.

(WebCore::RenderMultiColumnSet::paintColumnRules):
Fix the bug that Opera guys fixed in the old multi-column code. They didn't patch the new code, so this
takes care of that.

  • rendering/RenderMultiColumnSet.h:

(RenderMultiColumnSet):
Change to use paintObject instead of paint.

LayoutTests:

  • fast/multicol/newmulticol: Added.
  • fast/multicol/newmulticol/column-rules-fixed-height-expected.html: Added.
  • fast/multicol/newmulticol/column-rules-fixed-height.html: Added.
3:21 PM Changeset in webkit [143394] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of Opcode.h

Rubber stamped by Mark Hahnenberg.

  • bytecode/Opcode.h:
3:20 PM Changeset in webkit [143393] by commit-queue@webkit.org
  • 4 edits
    1 add
    16 deletes in trunk/LayoutTests

Convert residual-style.html test to a reftest (and fix typos)
https://bugs.webkit.org/show_bug.cgi?id=109981

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-19
Reviewed by Darin Adler.

  • fast/flexbox/box-orient-button.html: clsas->class
  • fast/flexbox/resources/box-orient-button.js: DTR->DRT
  • fast/invalid/residual-style-expected.html: Added. New reftest

version. Note that some lines are red, which is
https://bugs.webkit.org/show_bug.cgi?id=109984

  • fast/invalid/residual-style.html: Add missing semicolon in <style>.

Also close a few more <font> tags, so that the descriptive text is
in black as it should be.

  • platform/chromium-android/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-android/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-linux/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-linux/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
  • platform/chromium-win/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-win/fast/invalid/residual-style-expected.txt: Removed.
  • platform/efl/fast/invalid/residual-style-expected.png: Removed.
  • platform/efl/fast/invalid/residual-style-expected.txt: Removed.
  • platform/gtk/fast/invalid/residual-style-expected.png: Removed.
  • platform/gtk/fast/invalid/residual-style-expected.txt: Removed.
  • platform/mac/fast/invalid/residual-style-expected.png: Removed.
  • platform/mac/fast/invalid/residual-style-expected.txt: Removed.

Removed old expectation files.

3:19 PM Changeset in webkit [143392] by fpizlo@apple.com
  • 6 edits
    1 add in trunk/Source/JavaScriptCore

Moved PolymorphicAccessStructureList into its own file.

Rubber stamped by Mark Hahnenberg.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/Instruction.h:

(JSC):

  • bytecode/PolymorphicAccessStructureList.h: Added.

(JSC):
(PolymorphicAccessStructureList):
(PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::PolymorphicStubInfo):
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::visitWeak):

  • bytecode/StructureStubInfo.h:
3:17 PM WebKit Team edited by abucur@adobe.com
(diff)
3:15 PM Changeset in webkit [143391] by nghanavatian@rim.com
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Appropriately handle word wrapping in SpellingHandler
https://bugs.webkit.org/show_bug.cgi?id=110253

Reviewed by Rob Buis.

PR286001
Since we traverse through text by visual lines instead of blocks, word wrapping causes some
bad behavior. Changing the way we traverse text to jump by words instead of lines. This will
mean it takes longer to finish spellchecking, but the removal of any loops allows webkit
processing to continue. This gives priority to user actions while still completing a large
paragraph in a reasonable amount of time.

Internally reviewed by Mike Fenton

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):

  • WebKitSupport/SpellingHandler.cpp:

(BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
(BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
(BlackBerry::WebKit::SpellingHandler::startOfNextWord):
(WebKit):
(BlackBerry::WebKit::SpellingHandler::incrementByWord):
(BlackBerry::WebKit::SpellingHandler::doesWordWrap):

  • WebKitSupport/SpellingHandler.h:

(SpellingHandler):

3:10 PM Changeset in webkit [143390] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of Instruction.h

Rubber stamped by Mark Hahnenberg.

  • bytecode/Instruction.h:
3:04 PM Changeset in webkit [143389] by pdr@google.com
  • 8 edits
    6 adds in trunk

Fix 'slice' aspect ratio calculation
https://bugs.webkit.org/show_bug.cgi?id=99984

Patch by Branimir Lambov <blambov@google.com> on 2013-02-19
Reviewed by Dirk Schulze.

Source/WebCore:

Previously the calculation for the 'slice' aspect ratio would incorrectly calculate the
source rect location based on the destination rect offset. This caused our source rect to be
incorrect, and sometimes render outside the visible area completely. After this patch
our implementation matches the implementation of both Gecko and Presto.

The relevant spec section:
http://www.w3.org/TR/SVG/single-page.html#coords-PreserveAspectRatioAttribute

Tests: svg/as-image/image-preserveAspectRatio-all.svg

svg/filters/feImage-preserveAspectRatio-all.svg

  • svg/SVGPreserveAspectRatio.cpp:

(WebCore::SVGPreserveAspectRatio::transformRect):

LayoutTests:

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
  • svg/as-image/image-preserveAspectRatio-all-expected.txt: Added.
  • svg/as-image/image-preserveAspectRatio-all.svg: Added.
  • svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
  • svg/filters/feImage-preserveAspectRatio-all-expected.txt: Added.
  • svg/filters/feImage-preserveAspectRatio-all.svg: Added.
3:03 PM Changeset in webkit [143388] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test Expectations to reflect flakey calendar tests.
https://bugs.webkit.org/show_bug.cgi?id=107508

Unreviewed test expectations.

  • platform/chromium/TestExpectations: Re-added all the flakey calendar tests.
3:01 PM Changeset in webkit [143387] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] ScriptRunner::runCompiledScript() should return Handle<Value>() when OOM occurs
https://bugs.webkit.org/show_bug.cgi?id=110254

Patch by Kentaro Hara <haraken@google.com> on 2013-02-19
Reviewed by Adam Barth.

Chromium bug: https://code.google.com/p/chromium/issues/detail?id=176951

Currently ScriptRunner::runCompiledScript() calls
ASSERT(script.IsEmpty()) when OOM occurs. The Chromium bug is
hitting the ASSERT(). The ASSERT() does not make sense at all.
Instead, we should return an empty handle when OOM occurs.

No tests. The bug happens only when OOM occurs.

  • bindings/v8/ScriptRunner.cpp:

(WebCore::ScriptRunner::runCompiledScript):

2:58 PM Changeset in webkit [143386] by esprehn@chromium.org
  • 31 edits
    2 adds in trunk

Support both MutationObserver and WebKitMutationObserver
https://bugs.webkit.org/show_bug.cgi?id=109776

Reviewed by Ojan Vafai.

Source/WebCore:

We should allow new MutationObserver now that we support parser generated
mutations. This leaves the old prefixed constructor in until we decide
people don't depend on it.

Test: fast/dom/MutationObserver/mutation-observer-prefix.html

  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/MutationObserver/added-out-of-order.html:
  • fast/dom/MutationObserver/callback-arguments.html:
  • fast/dom/MutationObserver/clear-transient-without-delivery.html:
  • fast/dom/MutationObserver/create-during-delivery.html:
  • fast/dom/MutationObserver/cross-document.html:
  • fast/dom/MutationObserver/database-callback-delivery.html:
  • fast/dom/MutationObserver/delivery-order.html:
  • fast/dom/MutationObserver/disconnect-cancel-pending.html:
  • fast/dom/MutationObserver/document-fragment-insertion.html:
  • fast/dom/MutationObserver/end-of-task-delivery.html:
  • fast/dom/MutationObserver/filesystem-callback-delivery.html:
  • fast/dom/MutationObserver/inline-event-listener.html:
  • fast/dom/MutationObserver/mutate-during-delivery.html:
  • fast/dom/MutationObserver/mutation-callback-non-element-crash.html:
  • fast/dom/MutationObserver/mutation-observer-constructor.html:
  • fast/dom/MutationObserver/mutation-observer-prefix-expected.txt: Added.
  • fast/dom/MutationObserver/mutation-observer-prefix.html: Added.
  • fast/dom/MutationObserver/mutation-record-nullity.html:
  • fast/dom/MutationObserver/observe-attributes.html:
  • fast/dom/MutationObserver/observe-characterdata.html:
  • fast/dom/MutationObserver/observe-childList.html:
  • fast/dom/MutationObserver/observe-exceptions.html:
  • fast/dom/MutationObserver/observe-subtree.html:
  • fast/dom/MutationObserver/observer-wrapper-dropoff-transient.html:
  • fast/dom/MutationObserver/observer-wrapper-dropoff.html:
  • fast/dom/MutationObserver/parser-mutations.html:
  • fast/dom/MutationObserver/removed-out-of-order.html:
  • fast/dom/MutationObserver/shadow-dom.html:
  • fast/dom/MutationObserver/takeRecords.html:
  • fast/dom/MutationObserver/transient-gc-crash.html:
2:38 PM Changeset in webkit [143385] by ap@apple.com
  • 6 edits in trunk/Source/WebKit2

<rdar://problem/13239119> NetworkProcess generates timeout spindump logs

Reviewed by Mark Rowe.

Don't keep a window server connection in processes that don't need it, and don't
run an NSApplication run loop.

  • Shared/ChildProcess.h:
  • Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::shutdownWindowServerConnection): Added a function to shut down connections, and to make sure we don't get one in the future.
  • NetworkProcess/mac/NetworkProcessMac.mm: (WebKit::NetworkProcess::initializeProcessName):
  • OfflineStorageProcess/mac/OfflineStorageProcessMac.mm: (WebKit::OfflineStorageProcess::initializeProcessName):
  • SharedWorkerProcess/mac/SharedWorkerProcessMac.mm: (WebKit::SharedWorkerProcess::platformInitializeSharedWorkerProcess): Also removed some unused includes and forward declarations.
2:29 PM Changeset in webkit [143384] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling in r143348.
http://trac.webkit.org/changeset/143348
https://bugs.webkit.org/show_bug.cgi?id=110242

The bug was that isEmptyValue() was returning true for the deleted value.
Fixed this and simplified things further by delegating to m_sourceCode
for both isNull() and isHashTableDeletedValue(), so they can't be out of
sync.

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

  • runtime/CodeCache.h:

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):

2:15 PM Changeset in webkit [143383] by hmuller@adobe.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
2:02 PM Changeset in webkit [143382] by pilgrim@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Kentaro Hara.

Now that https://codereview.chromium.org/12230054 has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

  • public/platform/WebKitPlatformSupport.h:

(WebKit):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

1:53 PM Changeset in webkit [143381] by Martin Robinson
  • 2 edits
    1 add
    1 delete in trunk/Source/JavaScriptCore

[GTK] Improve gyp build JavaScriptCore code generation
https://bugs.webkit.org/show_bug.cgi?id=109969

Reviewed by Dirk Pranke.

Switch away from using DerivedSources.make when building JavaScriptCore generated
sources. This bring a couple advantages, such as building the sources in parallel,
but requires us to list the generated sources more than once.

1:51 PM Changeset in webkit [143380] by esprehn@chromium.org
  • 7 edits in trunk/Source/WebCore

Remove RenderText::updateText
https://bugs.webkit.org/show_bug.cgi?id=109991

Reviewed by Eric Seidel.

There's no reason for the generic RenderText::updateText virtual hook
anymore now that r143060 made RenderQuote stop setting dirty bits during
layout since the hook is only used by RenderCounter.

Instead add updateCounterIfNeeded and make it clear this is a hack for
counters.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::updateCounterIfNeeded): Added, not handles the counter specific hack.
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::updateCounter):

  • rendering/RenderCounter.h:

(RenderCounter):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::updateDepth):

  • rendering/RenderQuote.h:

(RenderQuote):

  • rendering/RenderText.h:

(RenderText):

1:48 PM Changeset in webkit [143379] by pdr@google.com
  • 5 edits
    3 copies in branches/chromium/1364

Merge 141645

Prevent skipped repaints for children of inner SVG elements
https://bugs.webkit.org/show_bug.cgi?id=108429

Reviewed by Eric Seidel.

Source/WebCore:

This patch fixes a bug caused by r108699 and r133786 where we would not repaint children
of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport
containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints.

I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed
with this patch.

Test: svg/repaint/svgsvgelement-repaint-children.html

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calcViewport):

This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate.

(WebCore::RenderSVGViewportContainer::calculateLocalTransform):

This change is straightforward and is similar to the equivalent assignment in
RenderSVGTransformableContainer::calculateLocalTransform().

LayoutTests:

Need to update expectations for a single file (just a 1px difference).

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
  • svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
  • svg/repaint/svgsvgelement-repaint-children.html: Added.

TBR=pdr@google.com

1:46 PM Changeset in webkit [143378] by glenn@skynav.com
  • 2 edits
    64 adds in trunk/LayoutTests

CSS3: add line-break tests, initially skipping on all platforms
https://bugs.webkit.org/show_bug.cgi?id=109954

Reviewed by Dirk Pranke.

See also wiki documentation at:
[1] http://trac.webkit.org/wiki/LineBreaking
[2] http://trac.webkit.org/wiki/LineBreakingCSS3Mapping

See also:
https://bugs.webkit.org/show_bug.cgi?id=89235

  • TestExpectations:
  • css3/line-break/line-break-auto-centered-expected.html: Added.
  • css3/line-break/line-break-auto-centered.html: Added.
  • css3/line-break/line-break-auto-half-kana-expected.html: Added.
  • css3/line-break/line-break-auto-half-kana.html: Added.
  • css3/line-break/line-break-auto-hyphens-expected.html: Added.
  • css3/line-break/line-break-auto-hyphens.html: Added.
  • css3/line-break/line-break-auto-inseparables-expected.html: Added.
  • css3/line-break/line-break-auto-inseparables.html: Added.
  • css3/line-break/line-break-auto-iteration-marks-expected.html: Added.
  • css3/line-break/line-break-auto-iteration-marks.html: Added.
  • css3/line-break/line-break-auto-postfixes-expected.html: Added.
  • css3/line-break/line-break-auto-postfixes.html: Added.
  • css3/line-break/line-break-auto-prefixes-expected.html: Added.
  • css3/line-break/line-break-auto-prefixes.html: Added.
  • css3/line-break/line-break-auto-sound-marks-expected.html: Added.
  • css3/line-break/line-break-auto-sound-marks.html: Added.
  • css3/line-break/line-break-loose-centered-expected.html: Added.
  • css3/line-break/line-break-loose-centered.html: Added.
  • css3/line-break/line-break-loose-half-kana-expected.html: Added.
  • css3/line-break/line-break-loose-half-kana.html: Added.
  • css3/line-break/line-break-loose-hyphens-expected.html: Added.
  • css3/line-break/line-break-loose-hyphens.html: Added.
  • css3/line-break/line-break-loose-inseparables-expected.html: Added.
  • css3/line-break/line-break-loose-inseparables.html: Added.
  • css3/line-break/line-break-loose-iteration-marks-expected.html: Added.
  • css3/line-break/line-break-loose-iteration-marks.html: Added.
  • css3/line-break/line-break-loose-postfixes-expected.html: Added.
  • css3/line-break/line-break-loose-postfixes.html: Added.
  • css3/line-break/line-break-loose-prefixes-expected.html: Added.
  • css3/line-break/line-break-loose-prefixes.html: Added.
  • css3/line-break/line-break-loose-sound-marks-expected.html: Added.
  • css3/line-break/line-break-loose-sound-marks.html: Added.
  • css3/line-break/line-break-normal-centered-expected.html: Added.
  • css3/line-break/line-break-normal-centered.html: Added.
  • css3/line-break/line-break-normal-half-kana-expected.html: Added.
  • css3/line-break/line-break-normal-half-kana.html: Added.
  • css3/line-break/line-break-normal-hyphens-expected.html: Added.
  • css3/line-break/line-break-normal-hyphens.html: Added.
  • css3/line-break/line-break-normal-inseparables-expected.html: Added.
  • css3/line-break/line-break-normal-inseparables.html: Added.
  • css3/line-break/line-break-normal-iteration-marks-expected.html: Added.
  • css3/line-break/line-break-normal-iteration-marks.html: Added.
  • css3/line-break/line-break-normal-postfixes-expected.html: Added.
  • css3/line-break/line-break-normal-postfixes.html: Added.
  • css3/line-break/line-break-normal-prefixes-expected.html: Added.
  • css3/line-break/line-break-normal-prefixes.html: Added.
  • css3/line-break/line-break-normal-sound-marks-expected.html: Added.
  • css3/line-break/line-break-normal-sound-marks.html: Added.
  • css3/line-break/line-break-strict-centered-expected.html: Added.
  • css3/line-break/line-break-strict-centered.html: Added.
  • css3/line-break/line-break-strict-half-kana-expected.html: Added.
  • css3/line-break/line-break-strict-half-kana.html: Added.
  • css3/line-break/line-break-strict-hyphens-expected.html: Added.
  • css3/line-break/line-break-strict-hyphens.html: Added.
  • css3/line-break/line-break-strict-inseparables-expected.html: Added.
  • css3/line-break/line-break-strict-inseparables.html: Added.
  • css3/line-break/line-break-strict-iteration-marks-expected.html: Added.
  • css3/line-break/line-break-strict-iteration-marks.html: Added.
  • css3/line-break/line-break-strict-postfixes-expected.html: Added.
  • css3/line-break/line-break-strict-postfixes.html: Added.
  • css3/line-break/line-break-strict-prefixes-expected.html: Added.
  • css3/line-break/line-break-strict-prefixes.html: Added.
  • css3/line-break/line-break-strict-sound-marks-expected.html: Added.
  • css3/line-break/line-break-strict-sound-marks.html: Added.
1:18 PM Changeset in webkit [143377] by tony@chromium.org
  • 3 edits
    2 adds in trunk

Border changes on tables with collapsed borders doesn't relayout table cells
https://bugs.webkit.org/show_bug.cgi?id=109774

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/table/border-collapsing/dynamic-border-width-change.html

Changes to border top and border bottom on table rows also changes the size
of the table cell causing a relayout to be needed.

  • rendering/RenderTableRow.cpp:

(WebCore::borderWidthChanged): Also include border top and bottom.
(WebCore::RenderTableRow::styleDidChange): Remove logical from the helper function name.

LayoutTests:

  • fast/table/border-collapsing/dynamic-border-width-change-expected.txt: Added.
  • fast/table/border-collapsing/dynamic-border-width-change.html: Added.
12:56 PM Changeset in webkit [143376] by Simon Fraser
  • 1 edit
    1 add in trunk/LayoutTests

Add a test result missed in r143074.

  • platform/mac-wk2/tiled-drawing/null-parent-back-crash-expected.txt: Added.
12:49 PM Changeset in webkit [143375] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.
Remove two now-passing tests.

  • platform/chromium/TestExpectations:
12:47 PM Changeset in webkit [143374] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests.

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):

12:43 PM Changeset in webkit [143373] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[WebGL] Fix oes-element-index-uint.html test.
https://bugs.webkit.org/show_bug.cgi?id=110045

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-19
Reviewed by Kenneth Russell.

This patch fixes the test case to use updated WebGLTestUtils functions
and adds shaders used during resized buffer tests. This patch
also enables the test for EFL port.

  • fast/canvas/webgl/oes-element-index-uint-expected.txt:
  • fast/canvas/webgl/oes-element-index-uint.html:
  • platform/efl/TestExpectations:
12:36 PM Changeset in webkit [143372] by tommyw@google.com
  • 2 edits in trunk/Source/Platform

WebAudio API: Change the Platform::createAudioDevice function to take a DeviceId parameter
https://bugs.webkit.org/show_bug.cgi?id=110192

Reviewed by Adam Barth.

  • chromium/public/Platform.h:

(WebKit::Platform::createAudioDevice):
(Platform):

12:32 PM Changeset in webkit [143371] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.4/Source

Versioning.

12:29 PM Changeset in webkit [143370] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.4

New Tag.

12:10 PM Changeset in webkit [143369] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[GTK][AC] Implement matrix transform animation with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=109848

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-19
Reviewed by Gustavo Noronha Silva.

Clutter 1.12 doesn't support additive transform animations yet, so the combination
of two or more transformations(such as rotation after translation) runs unexpectedly.
So we use a matrix transformation instead for the case.

Covered by existing animation tests.

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):

  • platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::toClutterActorPropertyString): Add actor property "transform"
(WebCore::clutterMatrixProgress): Handle interpolation between two matrices instead of default clutter_matrix_progress.
(WebCore):
(WebCore::PlatformClutterAnimation::supportsAdditiveValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue): for TransformationMatrix.
(WebCore::PlatformClutterAnimation::setToValue): ditto.
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addTransformTransition):

  • platform/graphics/clutter/PlatformClutterAnimation.h:

(PlatformClutterAnimation):

  • platform/graphics/clutter/TransformationMatrixClutter.cpp: Add copy constructor for CoglMatrix.

(WebCore::TransformationMatrix::TransformationMatrix):
(WebCore):

  • platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

12:02 PM Changeset in webkit [143368] by simonjam@chromium.org
  • 2 edits
    1 delete in branches/chromium/1410

Revert 129070

[Chromium] Disable resource load scheduling
https://bugs.webkit.org/show_bug.cgi?id=97131

Reviewed by Nate Chapin.

Source/WebCore:

We'll use Chrome's network stack for scheduling instead.

No new tests.

  • loader/ResourceLoadScheduler.cpp:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::preload):

LayoutTests:

The preload scanner loads resources sooner and these tests are affected.

  • platform/chromium/http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error-expected.txt: Added.
  • platform/chromium/http/tests/inspector/network/network-initiator-expected.txt: Added.

TBR=simonjam@chromium.org
Review URL: https://codereview.chromium.org/12294041

12:01 PM Changeset in webkit [143367] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark fast/workers/storage/interrupt-database.html as flaky crasher
https://bugs.webkit.org/show_bug.cgi?id=110247

Unreviewed gardening.

  • platform/chromium/TestExpectations:
11:39 AM Changeset in webkit [143366] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r143348.
http://trac.webkit.org/changeset/143348
https://bugs.webkit.org/show_bug.cgi?id=110242

"Caused a deleted value sentinel crash on the layout tests"
(Requested by ggaren on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

  • runtime/CodeCache.h:

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):

11:34 AM Changeset in webkit [143365] by leviw@chromium.org
  • 1 edit
    2 copies in branches/chromium/1410

Merge 142793

Bidi-Isolated inlines can cause subsequent content to not be rendered
https://bugs.webkit.org/show_bug.cgi?id=108137

Reviewed by Eric Seidel.

Source/WebCore:

First step in fixing how inline isolates behave with collapsed spaces.
webkit.org/b/109624 tracks the overarching issue.

Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html

  • rendering/InlineIterator.h:

(WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while
ignoring spaces, ensure we leave it considering them again. This can result in
including spaces that should be ignored following the isolate on the line, but
failing to do so results in those contents not being rendered at all.

LayoutTests:

  • fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added.
  • fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added.

TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/12308006

11:29 AM Changeset in webkit [143364] by schenney@chromium.org
  • 61 edits
    4 deletes in trunk/LayoutTests

Rebaselining, again, calendar tests
https://bugs.webkit.org/show_bug.cgi?id=110240

Unreviewed expectations update.

  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Removed.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
11:19 AM Changeset in webkit [143363] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Update FeatureObserver on top level navigation in addition to page destruction.
https://bugs.webkit.org/show_bug.cgi?id=109874

Patch by Kassy Coan <kassycoan@chromium.org> on 2013-02-19
Reviewed by Adam Barth.

No new tests. Only effect is to histogram more frequently.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchDidCommitLoad):

  • page/FeatureObserver.cpp:

(WebCore::FeatureObserver::~FeatureObserver):
(WebCore):
(WebCore::FeatureObserver::updateMeasurements):
(WebCore::FeatureObserver::didCommitLoad):

  • page/FeatureObserver.h:

(FeatureObserver):

11:15 AM Changeset in webkit [143362] by pravin.d@samsung.com
  • 2 edits in trunk/Tools

Unreviewed, changing primary email.

11:10 AM Changeset in webkit [143361] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary (and problematic) copy-constructor from LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=110121

This copy constructor does what a default copy constructor would do, so
it's not necessary. Furthermore, this copy constructor is the only
reason why LayoutUnit becomes non-POD, and that triggers a gdb bug,
making it impossible to do things like "print location()" when inside
some RenderBlock, for instance.

Gdb bug http://sourceware.org/bugzilla/show_bug.cgi?id=15154 reported.

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-02-19
Reviewed by Benjamin Poulain.

No tests. Apart from dealing with buggy debuggers, this is just code cleanup.

  • platform/LayoutUnit.h:
11:10 AM Changeset in webkit [143360] by commit-queue@webkit.org
  • 2 edits
    1 copy
    1 move in trunk/Tools

REGRESSION: Sheriffbot is failing to process rollout requests
https://bugs.webkit.org/show_bug.cgi?id=106945

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-19
Reviewed by Adam Barth.

Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
This resolves problems when Sheriffbot attempts to perform a rollout request.

  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
  • EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
  • EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
11:08 AM Changeset in webkit [143359] by kov@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Romanian translation for WebKitGtk+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=110009

Patch by Mișu Moldovan <dumol@gnome.org> on 2013-02-19
Reviewed by Gustavo Noronha.

  • ro.po: Added.
11:06 AM Changeset in webkit [143358] by ap@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

[WK2] Cannot load documents with blob urls
https://bugs.webkit.org/show_bug.cgi?id=110160

Reviewed by Sam Weinig.

  • http/tests/fileapi/blob-url-in-subframe-expected.txt: Added.
  • http/tests/fileapi/blob-url-in-subframe.html: Added.
  • http/tests/fileapi/resources: Added.
  • http/tests/fileapi/resources/blob-url-in-subframe-frame.html: Added.
11:00 AM Changeset in webkit [143357] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

LayoutUnit::epsilon shouldn't be necessary to place floats
https://bugs.webkit.org/show_bug.cgi?id=94000

Reviewed by Levi Weintraub.

Currently, to get float placement correct, we need to have an
epsilon tolerance in RenderBlock::computeLogicalLocationForFloat
for the width of the line to fit them on. This really shouldn't
be necessary, and probably indicates we're losing precision
elsewhere.

Remove epsilon as it no longer appears to be needed. All layout
tests pass without it.

No new tests, covered by existing tests.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat):

10:57 AM Changeset in webkit [143356] by commit-queue@webkit.org
  • 22 edits
    2 adds in trunk

Text Autosizing: prevent oscillation of font sizes during autosizing
https://bugs.webkit.org/show_bug.cgi?id=108205

Patch by Tim Volodine <timvolodine@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

On some websites autosized font-sizes oscillate due to layouts caused by
hovering or incremental page loading (and on other sites font sizes do
eventually stabilize, but it takes many layouts before they reach a steady
size). To prevent all these cases, we no longer allow the autosizing
multiplier to change after it has been set (to a value other than 1).

This won't always give exactly the same results, but testing on 2000 top
sites shows that this makes little difference in practice, and it prevents
these very jarring cases. As a happy side-effect, this speeds up layouts
as font sizes change less.

Test: fast/text-autosizing/oscillation-javascript-fontsize-change.html

  • page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

  • page/Settings.cpp:

(WebCore::Settings::setTextAutosizingFontScaleFactor):

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::recalculateMultipliers):
(WebCore):
(WebCore::TextAutosizer::processContainer):

  • rendering/TextAutosizer.h:

(TextAutosizer):

LayoutTests:

Added overflow-y:hidden to some existing tests, since previously those tests
would start off with incorrect multipliers (because mainFrame->view()-layoutSize()
is initially 785 instead of 800 as ScrollView wrongly guesses a scrollbar will
be needed), and then the multipliers would get corrected on a subsequent layout.
Now that we don't allow the multiplier to change after being set, it needs to be
right first time.
Also added specific oscillation test triggered by javascript.

  • fast/text-autosizing/constrained-height-body-expected.html:
  • fast/text-autosizing/constrained-height-body.html:
  • fast/text-autosizing/constrained-then-float-ancestors-expected.html:
  • fast/text-autosizing/constrained-then-float-ancestors.html:
  • fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
  • fast/text-autosizing/constrained-then-position-fixed-ancestors.html:
  • fast/text-autosizing/nested-em-line-height-expected.html:
  • fast/text-autosizing/nested-em-line-height.html:
  • fast/text-autosizing/oscillation-javascript-fontsize-change-expected.html: Added.
  • fast/text-autosizing/oscillation-javascript-fontsize-change.html: Added.
  • fast/text-autosizing/simple-paragraph-expected.html:
  • fast/text-autosizing/simple-paragraph.html:
  • fast/text-autosizing/span-child-expected.html:
  • fast/text-autosizing/span-child.html:
  • fast/text-autosizing/unwrappable-blocks-expected.html:
  • fast/text-autosizing/unwrappable-blocks.html:
  • fast/text-autosizing/unwrappable-inlines-expected.html:
  • fast/text-autosizing/unwrappable-inlines.html:
10:42 AM Changeset in webkit [143355] by aelias@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Fix races in double-tap zoom minimum scale policy
https://bugs.webkit.org/show_bug.cgi?id=110183

Reviewed by Adam Barth.

Double-tap zoom on Android is supposed to return to minimum scale
if no pinch zoom occurred since the last double-tap. Because both
pinch zoom and the result of double-tap zoom gets passed in from CC
via applyScrollAndScale, this logic was brittle and prone to races
depending on when the animation update was received. This patch
keeps track of what the target double-tap scale is to make it more
robust.

I also fixed double-tap zoom test mocking to exercise the entire
page scale animation flow (our previous way of testing was hiding the
raciness), and added a new test case in DivAutoZoomMultipleParamsTest.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::startPageScaleAnimation):
(WebKit):
(WebKit::WebViewImpl::enableFakeDoubleTapAnimationForTesting):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::animateZoomAroundPoint):
(WebKit::WebViewImpl::didCommitLoad):
(WebKit::WebViewImpl::applyScrollAndScale):

  • src/WebViewImpl.h:

(WebViewImpl):
(WebKit::WebViewImpl::fakeDoubleTapAnimationPendingForTesting):
(WebKit::WebViewImpl::fakeDoubleTapTargetPositionForTesting):
(WebKit::WebViewImpl::fakeDoubleTapPageScaleFactorForTesting):
(WebKit::WebViewImpl::fakeDoubleTapUseAnchorForTesting):

  • tests/WebFrameTest.cpp:
10:40 AM Changeset in webkit [143354] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

HeapBlock::destroy should issue warning if result is unused
https://bugs.webkit.org/show_bug.cgi?id=110233

Reviewed by Oliver Hunt.

To enforce the fact that we need to return blocks to the BlockAllocator after calling destroy,
we should add WARN_UNUSED_RETURN to HeapBlock::destroy and any other destroy functions in its subclasses.

  • heap/HeapBlock.h:
10:29 AM Changeset in webkit [143353] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Cannot load documents with blob urls
https://bugs.webkit.org/show_bug.cgi?id=110160

Reviewed by Sam Weinig.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::canHandleRequest): Added knowledge about blobs.
10:28 AM Changeset in webkit [143352] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][DRT] http/tests/loading/307-after-303-after-post.html times out
https://bugs.webkit.org/show_bug.cgi?id=93214

Source/WebCore:

Ensured that GET verb is consistently used for any request
coming after a redirection that triggers switching to GET.

Patch by Youenn Fablet <youennf@gmail.com> on 2013-02-19
Reviewed by Martin Robinson.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::doRedirect):

LayoutTests:

Removed Failure from potential outcome of
http/tests/loading/307-after-303-after-post.html test.

Patch by Youenn Fablet <youennf@gmail.com> on 2013-02-19
Reviewed by Martin Robinson.

  • platform/efl/TestExpectations:
10:12 AM Changeset in webkit [143351] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

WeakSet::removeAllocator leaks WeakBlocks
https://bugs.webkit.org/show_bug.cgi?id=110228

Reviewed by Geoffrey Garen.

We need to return the WeakBlock to the BlockAllocator after the call to WeakBlock::destroy.

  • heap/WeakSet.cpp:

(JSC::WeakSet::removeAllocator):

10:07 AM Changeset in webkit [143350] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix compilation if Qt was configured with -no-rtti
https://bugs.webkit.org/show_bug.cgi?id=110234

Reviewed by Noam Rosenthal.

Availability of dynamic_cast should be checked.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):

10:05 AM Changeset in webkit [143349] by ap@apple.com
  • 3 edits in trunk/Source/WebCore

Unregistered blob URLs have incorrect MIME type
https://bugs.webkit.org/show_bug.cgi?id=110166

Reviewed by Sam Weinig.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::shouldUseInnerURL): Added a FIXME.
  • platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyResponseOnError): Pass an accurate MIME type (for a delegate to see).
9:48 AM Changeset in webkit [143348] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Save space on keys in the CodeCache
https://bugs.webkit.org/show_bug.cgi?id=110179

Reviewed by Oliver Hunt.

Share the SourceProvider's string instead of making our own copy. This
chops off 16MB - 32MB from the CodeCache's memory footprint when full.
(It's 16MB when the strings are LChar, and 32MB when they're UChar.)

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

  • runtime/CodeCache.h: Removed a defunct enum value.

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(SourceCodeKey):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::string):
(JSC::SourceCodeKey::operator==): Store a SourceCode instead of a String
so we can share our string with our SourceProvider. Cache our hash so
we don't have to re-decode our string just to re-hash the table.

9:42 AM Changeset in webkit [143347] by jsbell@chromium.org
  • 5 edits in trunk/Source

IndexedDB: additional checks on LevelDB decoding
https://bugs.webkit.org/show_bug.cgi?id=109711

Reviewed by Tony Chang.

Source/WebCore:

Watch out for decoding errors caused by corrupted data, and exit various
decode/compare operations earlier.

Covered by existing LayoutTests and Chromium's webkit_unit_tests

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::decodeStringWithLength): Bail if length is negative.
(WebCore::IDBLevelDBCoding::compareEncodedStringsWithLength): Distinguish error case.
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey): Bail if length is negative.
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys): Distinguish error case.
(WebCore::IDBLevelDBCoding::compare): Plumb through "ok".
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare): Ditto.
(WebCore::IDBLevelDBCoding::ExistsEntryKey::compare): Ditto.
(WebCore::IDBLevelDBCoding::IndexDataKey::compare): Ditto.

  • Modules/indexeddb/IDBLevelDBCoding.h: Updated method signatures.

Source/WebKit/chromium:

  • tests/IDBLevelDBCodingTest.cpp: Update test with new method signatures.
9:12 AM Changeset in webkit [143346] by zherczeg@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

revertBranchPtrWithPatch is incorrect on ARM traditional
https://bugs.webkit.org/show_bug.cgi?id=110201

Reviewed by Oliver Hunt.

Revert two instructions back to their original value.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::revertBranchPtrWithPatch):
(ARMAssembler):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::revertJumpReplacementToBranchPtrWithPatch):

9:09 AM Changeset in webkit [143345] by Claudio Saavedra
  • 7 edits in trunk

Unreviewed build fix.

.:

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/Versions.m4:
  • Source/cmake/FindHarfBuzz.cmake:

Bump gtk and efl dependencies on harfbuzz
to 0.9.7. See bug 110145.

Tools:

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:

Bump harfbuzz module to 0.9.7. See related bug 110145.

9:01 AM Changeset in webkit [143344] by commit-queue@webkit.org
  • 2 edits in trunk

Only depend on xrender if x11 is being used
https://bugs.webkit.org/show_bug.cgi?id=84095

Patch by Changhun Kang <temoochin@company100.net> on 2013-02-19
Reviewed by Martin Robinson.

  • Source/autotools/FindDependencies.m4:
9:01 AM Changeset in webkit [143343] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK][AC] Implement keyframe animations with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=110057

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-19
Reviewed by Gustavo Noronha Silva.

This patch brings accelerated keyframe animation with clutter to WebKitGtk+.
Changes of GraphicsLayerClutter are based on GraphicsLayerCA. But major changes
of PlatformClutterAnimation are implemented with clutter keyframe transition apis.
See http://developer.gnome.org/clutter/stable/ClutterKeyframeTransition.html

Covered by existing animation tests.

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::createKeyframeAnimation):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):

  • platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::toClutterActorPropertyString):
(WebCore::PlatformClutterAnimation::PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::setTimingFunction):
(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::setKeyTimes):
(WebCore::PlatformClutterAnimation::setTimingFunctions):
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):
(WebCore::PlatformClutterAnimation::addOpacityTransition):
(WebCore::PlatformClutterAnimation::addTransformTransition):
(WebCore::PlatformClutterAnimation::addAnimationForKey):
(WebCore::PlatformClutterAnimation::removeAnimationForKey):

  • platform/graphics/clutter/PlatformClutterAnimation.h:

(PlatformClutterAnimation):

8:55 AM Changeset in webkit [143342] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing test.

  • platform/qt/TestExpectations:
8:50 AM Changeset in webkit [143341] by Carlos Garcia Campos
  • 8 edits in trunk/Source/WebKit2

[GTK] Move the API to get TLS certificate from WebKitURIResponse to WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=110190

Reviewed by Anders Carlsson.

Add webkit_web_view_get_tls_info() and remove
webkit_uri_response_get_https_status(). This way I can be sure
that when called after load has been committed the certificate
will be available. It also makes the API easier to use.

  • UIProcess/API/gtk/WebKitURIResponse.cpp:
  • UIProcess/API/gtk/WebKitURIResponse.h:
  • UIProcess/API/gtk/WebKitURIResponsePrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewLoadChanged):
(mainResourceResponseChangedCallback):
(webkit_web_view_get_tls_info):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestSSL.cpp:
8:50 AM Changeset in webkit [143340] by aandrey@chromium.org
  • 1 edit in trunk/Source/WebKit/win/ChangeLog

Unreviewed, adding external symbol ?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ.

  • WebKit.vcproj/WebKitExports.def.in:
8:48 AM Changeset in webkit [143339] by mikhail.pozdnyakov@intel.com
  • 8 edits in trunk/Source/WebKit2

[WK2][EFL] Eliminate access to WK2 C++ internals from ewk_view functions
https://bugs.webkit.org/show_bug.cgi?id=109794

Reviewed by Anders Carlsson.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewSetShowsAsSource):
(WKViewGetShowsAsSource):

Added new WKView API to wrap WebPageProxy::setMainFrameInViewSourceMode()
and WebPageProxy::mainFrameInViewSourceMode() calls.

(WKViewExitFullScreen):

Added new WKView API to wrap WebFullScreenManagerProxy::exitFullScreen()
calls.

  • UIProcess/API/C/efl/WKView.h:
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::feedTouchEvent):

Added feedTouchEvent() method so that: at first ewk_view_feed_touch_event()
is not invoked from EwkView class, secondly ewk_view_feed_touch_event() does
not access WebPage instance directly.

(EwkView::feedTouchEvents):

  • UIProcess/API/efl/EwkView.h:

(EwkView):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_feed_touch_event):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):
(ewk_view_fullscreen_exit):
(ewkViewPageContentsCallback):
(ewk_view_page_contents_get):
(ewk_view_source_mode_set):
(ewk_view_source_mode_get):

Those are now using exported C API.

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::setShowsAsSource):
(WebKit):
(WebKit::WebView::showsAsSource):
(WebKit::WebView::exitFullScreen):

  • UIProcess/efl/WebView.h:

(WebView):

Added WebView methods to support added WKView API.

8:47 AM Changeset in webkit [143338] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebKit/win

Unreviewed, Web Inspector: follow up to r143328 fixing Win Debug Build
https://bugs.webkit.org/show_bug.cgi?id=110227

Adding external symbol ?didBeginFrame@InspectorCanvasAgent@WebCore@@QAEXXZ.

  • WebKit.vcproj/WebKitExports.def.in:
8:27 AM Changeset in webkit [143337] by Claudio Saavedra
  • 2 edits in trunk/Source/WebCore

[harfbuzz] Crash in harfbuzz related code
https://bugs.webkit.org/show_bug.cgi?id=110145

Reviewed by Martin Robinson.

Patch by Behdad Esfahbod <behdad@google.com>

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Ask harfbuzz
to guess the segment properties.

8:27 AM Changeset in webkit [143336] by schenney@chromium.org
  • 188 edits
    47 adds
    23 deletes in trunk/LayoutTests

Test Expectations update after r143267 and others

Unreviewed expectations update.

Updated many Chromium expectations, and removed superfluous
expectations from mac and win.

  • editing/selection/extend-by-sentence-001-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-linux-x86/svg/filters/big-sized-filter-2-expected.png: Removed.
  • platform/chromium-linux-x86/svg/filters/shadow-on-filter-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug1188-expected.png: Removed.
  • platform/chromium-linux-x86/tables/mozilla/bugs/bug1318-expected.png: Removed.
  • platform/chromium-linux/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-linux/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium-linux/svg/filters/big-sized-filter-2-expected.png: Removed.
  • platform/chromium-linux/svg/filters/shadow-on-filter-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-mac-lion/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac-lion/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
  • platform/chromium-mac-lion/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/extend-by-sentence-001-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-2-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/shadow-on-filter-expected.png: Removed.
  • platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
  • platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.txt: Added.
  • platform/chromium-mac/fast/inline/drawStyledEmptyInlines-expected.txt: Added.
  • platform/chromium-mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/chromium-mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Added.
  • platform/chromium-mac/fast/text/capitalize-empty-generated-string-expected.txt: Added.
  • platform/chromium-mac/fast/text/whitespace/006-expected.txt: Added.
  • platform/chromium-mac/fast/text/whitespace/007-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added property svn:mime-type.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/chromium-mac/svg/batik/text/xmlSpace-expected.txt: Added.
  • platform/chromium-mac/svg/custom/visibility-override-filter-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
  • platform/chromium-mac/svg/filters/big-sized-filter-2-expected.png:
  • platform/chromium-mac/svg/filters/feImage-reference-svg-primitive-expected.png:
  • platform/chromium-mac/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-mac/svg/filters/filterRes1-expected.png:
  • platform/chromium-mac/svg/filters/filterRes3-expected.png:
  • platform/chromium-mac/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/chromium-mac/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug113235-3-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added.
  • platform/chromium-win-xp/svg/filters/big-sized-filter-2-expected.png: Removed.
  • platform/chromium-win-xp/svg/filters/shadow-on-filter-expected.png: Removed.
  • platform/chromium-win/editing/selection/extend-by-sentence-001-expected.txt:
  • platform/chromium-win/fast/inline/drawStyledEmptyInlines-expected.txt:
  • platform/chromium-win/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/chromium-win/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
  • platform/chromium-win/fast/text/capitalize-empty-generated-string-expected.txt:
  • platform/chromium-win/fast/text/whitespace/006-expected.txt:
  • platform/chromium-win/fast/text/whitespace/007-expected.txt:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • platform/chromium-win/svg/filters/big-sized-filter-2-expected.png:
  • platform/chromium-win/svg/filters/feImage-reference-svg-primitive-expected.png:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug113235-3-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/editing/selection/extend-by-sentence-001-expected.txt: Removed.
  • platform/chromium/fast/inline/drawStyledEmptyInlines-expected.txt: Removed.
  • platform/chromium/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt: Removed.
  • platform/chromium/fast/text/capitalize-empty-generated-string-expected.txt: Removed.
  • platform/chromium/fast/text/whitespace/006-expected.txt: Removed.
  • platform/chromium/fast/text/whitespace/007-expected.txt: Removed.
  • platform/chromium/svg/batik/text/xmlSpace-expected.txt: Removed.
  • platform/chromium/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Removed.
  • platform/chromium/tables/mozilla/bugs/bug113235-3-expected.txt: Removed.
  • platform/efl-wk2/svg/filters: Added.
  • platform/efl-wk2/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
  • platform/efl/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
  • platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/editing/selection/extend-by-sentence-001-expected.txt: Removed.
  • platform/win/TestExpectations:
8:26 AM Changeset in webkit [143335] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] ASSERT(node) hit in WebPage::findZoomableAreaForPoint if no zoomable area found
https://bugs.webkit.org/show_bug.cgi?id=110220

Reviewed by Allan Sandfeld Jensen.

If EventHandler::bestZoomableAreaForTouchPoint was unsuccessfull, eg.
no node was found for a given point, we hit ASSERT(node).
We should only assert for a valid node if a zoomable area was found.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findZoomableAreaForPoint):

8:12 AM Changeset in webkit [143334] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: release backtrace object group on each step.
https://bugs.webkit.org/show_bug.cgi?id=110223

Reviewed by Pavel Feldman.

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore):
(WebCore::InspectorDebuggerAgent::stepOver):
(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::stepOut):

8:01 AM Changeset in webkit [143333] by commit-queue@webkit.org
  • 12 edits
    3 deletes in trunk

Unreviewed, rolling out r142975.
http://trac.webkit.org/changeset/142975
https://bugs.webkit.org/show_bug.cgi?id=110225

Introduces hard-to-reproduce crashes upon inspected page
navigation on Mac (Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

Source/WebCore:

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

  • inspector/Inspector.json:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):
(WebCore::InspectorCSSAgent::buildObjectForRule):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.getViaInspectorResourceForRule):
(WebInspector.CSSStyleModelResourceBinding.prototype.):
(WebInspector.CSSStyleModelResourceBinding.prototype.requestStyleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype.requestResourceURLForStyleSheetId):
(WebInspector.CSSStyleModelResourceBinding.prototype._styleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._loadStyleSheetHeaders):
(WebInspector.CSSStyleModelResourceBinding.prototype.headersLoaded):
(WebInspector.CSSStyleModelResourceBinding.prototype._requestViaInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._getOrCreateInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._reset):

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping.prototype._styleSheetChanged.callback):
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode.callback):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):

  • inspector/front-end/StylesSourceMapping.js:

(WebInspector.StyleContentBinding.prototype.callback):
(WebInspector.StyleContentBinding.prototype.setStyleContent):
(WebInspector.StyleContentBinding.prototype.):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):

LayoutTests:

  • inspector/styles/resources/stylesheet-tracking.css: Removed.
  • inspector/styles/stylesheet-tracking-expected.txt: Removed.
  • inspector/styles/stylesheet-tracking.html: Removed.
7:53 AM Changeset in webkit [143332] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

Regression(r143273): Caused a lot of tests to time out
https://bugs.webkit.org/show_bug.cgi?id=110212

Reviewed by Anders Carlsson.

StorageManager::destroySessionStorageNamespace() and StorageManager::cloneSessionStorageNamespace()
should call their respective "*Internal" equivalent instead of calling themselves. This lead to
a lot of time outs on our build bots.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::destroySessionStorageNamespace):
(WebKit::StorageManager::cloneSessionStorageNamespace):

7:41 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
(diff)
7:36 AM Changeset in webkit [143331] by jchaffraix@webkit.org
  • 4 edits
    2 adds in trunk

RenderGrid::computedUsedBreadthOfGridTracks can read past m_grid's size
https://bugs.webkit.org/show_bug.cgi?id=110126

Reviewed by Ojan Vafai.

Source/WebCore:

The issue comes from how we store the column information inside m_grid.
Because m_grid is a Vector of rows, we could lose the column information
if we had no row, no grid item but some columns defined in CSS. As the
logic would assume that our row / column size would be greater than what
the style defines explicitely, we would access past our Vector's boundary.

The fix is to ensure that we have at least a row so that we can store the
column information in every case. This fix is overly broad as it also forces
the grid to have one column, which shouldn't be an issue.

Test: fast/css-grid-layout/grid-element-empty-row-column.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::maximumIndexInDirection):
Forced this function to return at least one as the maximum index so that
m_grid has at least one row / column.

(WebCore::RenderGrid::placeItemsOnGrid):
Added a ASSERT that m_grid is bigger than the explicit grid-rows / grid-columns.
Also changed an existing ASSERT to use gridWasPopulated for consistency and changed
the code not to call gridRowCount as it would ASSERT (we are in the middle of populating
the grid).

  • rendering/RenderGrid.h:

(WebCore::RenderGrid::gridWasPopulated):
Added this helper function.

(WebCore::RenderGrid::gridColumnCount):
Replaced a now unneeded branch with an ASSERT. As placeItemsOnGrid should be called
prior to read m_grid, this change should be fine.

(WebCore::RenderGrid::gridRowCount):
Added an ASSERT.

LayoutTests:

  • fast/css-grid-layout/grid-element-empty-row-column-expected.txt: Added.
  • fast/css-grid-layout/grid-element-empty-row-column.html: Added.
7:19 AM Changeset in webkit [143330] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding a crash expectation for the layout test

added in r143303. The test is crashing due to missing bits of EventSender implementation.

7:16 AM Changeset in webkit [143329] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

[Soup] Use synchronous calls to close completely processed streams
https://bugs.webkit.org/show_bug.cgi?id=107432

Reviewed by Martin Robinson.

There is no need to close already processed streams in asynchronous
calls since they won't block. Using the synchronous call will save
us some code and unnecessary asynchronous burden. This is kind of
a code refactor so no new tests needed.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::redirectSkipCallback):
(WebCore::readCallback):

7:13 AM Changeset in webkit [143328] by aandrey@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: [Canvas] use timeline's didBeginFrame for marking frame end calls
https://bugs.webkit.org/show_bug.cgi?id=110130

Reviewed by Pavel Feldman.

In Web Inspector canvas profiler use timeline's didBeginFrame for marking frame end calls instead of an ad-hoc timeout-based solution.

  • inspector/InjectedScriptCanvasModule.cpp:

(WebCore::InjectedScriptCanvasModule::markFrameEnd):
(WebCore):

  • inspector/InjectedScriptCanvasModule.h:

(InjectedScriptCanvasModule):

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::hasUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
(WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::didBeginFrame):
(WebCore):

  • inspector/InspectorCanvasAgent.h:

(InspectorCanvasAgent):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::didBeginFrame):

6:59 AM Changeset in webkit [143327] by vsevik@chromium.org
  • 12 edits
    2 adds in trunk

Web Inspector: Decouple various file system project implementation parts for better testability and cover with tests.
https://bugs.webkit.org/show_bug.cgi?id=110204

Reviewed by Pavel Feldman.

Source/WebCore:

Extracted FileSystemWorkspaceProvider from IsolatedFileSystemManager to take care of managing workspace projects and projectDelegates.
Replaced FileMapping.urlForURI with urlForPath method that does not need any information about workspace structure anymore.

Test: inspector/file-system-project.html

  • inspector/front-end/FileMapping.js:

(WebInspector.FileMapping.prototype.urlForPath):

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemRemoved):

  • inspector/front-end/IsolatedFileSystem.js:

(WebInspector.IsolatedFileSystem):
(WebInspector.IsolatedFileSystem.prototype.name):
(WebInspector.IsolatedFileSystem.prototype.rootURL):

  • inspector/front-end/IsolatedFileSystemManager.js:

(WebInspector.IsolatedFileSystemManager):
(WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):
(WebInspector.IsolatedFileSystemManager.prototype._isolatedFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype.requestDOMFileSystem):

  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest):
(initialize_InspectorTest.):

  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):

  • inspector/file-mapping-expected.txt:
  • inspector/file-mapping.html:
  • inspector/file-system-project-expected.txt: Added.
  • inspector/file-system-project.html: Added.
  • inspector/version-controller.html:
6:43 AM Changeset in webkit [143326] by Simon Hausmann
  • 3 edits in trunk/Tools

[Qt] Skip the build with a warning if certain tools cannot be found in the PATH
https://bugs.webkit.org/show_bug.cgi?id=110215

Reviewed by Tor Arne Vestbø.

Check that gperf, python, ruby, perl, bison and flex are in the PATH before
continuing the build. Otherwise skip with an error message explaining which
programs are missing from the build.

  • qmake/mkspecs/features/configure.prf:
  • qmake/mkspecs/features/functions.prf:
6:31 AM Changeset in webkit [143325] by aandrey@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Canvas] do not replace replay image with spinner icon
https://bugs.webkit.org/show_bug.cgi?id=110213

Reviewed by Pavel Feldman.

Otherwise it's visually hard to see changes in the replay image. Instead show a small spinner icon in the bottom right corner.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):

  • inspector/front-end/canvasProfiler.css:

(#canvas-replay-image-container):
(.canvas-debug-info):
(.canvas-spinner-icon):

6:29 AM Changeset in webkit [143324] by aandrey@chromium.org
  • 5 edits in trunk

Web Inspector: [Canvas] UI: tweak replay control buttons behavior
https://bugs.webkit.org/show_bug.cgi?id=110207

Reviewed by Pavel Feldman.

Source/WebCore:

New behavior for control buttons in the Canvas profiler.

  • The NextCall button (~StepInto) on a node group should expand it and move into its first child (instead of expanding and moving into the next node group)
  • The NextDrawCall button (~StepOver) should move to a next node that has children (instead of just iterating call group nodes, ignoring frame nodes).
  • The ReplayLast button should select the last expanded node (instead of always selecting last frame group node).
  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):
(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):

LayoutTests:

Testing control buttons behavior.

  • inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt:
  • inspector/profiler/canvas2d/canvas-replay-log-grid.html:
5:54 AM Changeset in webkit [143323] by commit-queue@webkit.org
  • 3 edits
    42 deletes in trunk

Unreviewed, rolling out r143319.
http://trac.webkit.org/changeset/143319
https://bugs.webkit.org/show_bug.cgi?id=110214

Causes build issues on win32 (Requested by carewolf on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-19

Tools:

  • qmake/mkspecs/features/features.pri:

LayoutTests:

  • platform/qt/mathml/presentation/attributes-expected.png: Removed.
  • platform/qt/mathml/presentation/attributes-expected.txt: Removed.
  • platform/qt/mathml/presentation/fenced-expected.png: Removed.
  • platform/qt/mathml/presentation/fenced-expected.txt: Removed.
  • platform/qt/mathml/presentation/fenced-mi-expected.png: Removed.
  • platform/qt/mathml/presentation/fenced-mi-expected.txt: Removed.
  • platform/qt/mathml/presentation/fractions-expected.png: Removed.
  • platform/qt/mathml/presentation/fractions-expected.txt: Removed.
  • platform/qt/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
  • platform/qt/mathml/presentation/fractions-vertical-alignment-expected.txt: Removed.
  • platform/qt/mathml/presentation/mo-expected.png: Removed.
  • platform/qt/mathml/presentation/mo-expected.txt: Removed.
  • platform/qt/mathml/presentation/mo-stretch-expected.png: Removed.
  • platform/qt/mathml/presentation/mo-stretch-expected.txt: Removed.
  • platform/qt/mathml/presentation/mroot-pref-width-expected.png: Removed.
  • platform/qt/mathml/presentation/mroot-pref-width-expected.txt: Removed.
  • platform/qt/mathml/presentation/over-expected.png: Removed.
  • platform/qt/mathml/presentation/over-expected.txt: Removed.
  • platform/qt/mathml/presentation/roots-expected.png: Removed.
  • platform/qt/mathml/presentation/roots-expected.txt: Removed.
  • platform/qt/mathml/presentation/row-alignment-expected.png: Removed.
  • platform/qt/mathml/presentation/row-alignment-expected.txt: Removed.
  • platform/qt/mathml/presentation/row-expected.png: Removed.
  • platform/qt/mathml/presentation/row-expected.txt: Removed.
  • platform/qt/mathml/presentation/style-expected.png: Removed.
  • platform/qt/mathml/presentation/style-expected.txt: Removed.
  • platform/qt/mathml/presentation/sub-expected.png: Removed.
  • platform/qt/mathml/presentation/sub-expected.txt: Removed.
  • platform/qt/mathml/presentation/subsup-expected.png: Removed.
  • platform/qt/mathml/presentation/subsup-expected.txt: Removed.
  • platform/qt/mathml/presentation/sup-expected.png: Removed.
  • platform/qt/mathml/presentation/sup-expected.txt: Removed.
  • platform/qt/mathml/presentation/tables-expected.png: Removed.
  • platform/qt/mathml/presentation/tables-expected.txt: Removed.
  • platform/qt/mathml/presentation/tokenElements-expected.png: Removed.
  • platform/qt/mathml/presentation/tokenElements-expected.txt: Removed.
  • platform/qt/mathml/presentation/under-expected.png: Removed.
  • platform/qt/mathml/presentation/under-expected.txt: Removed.
  • platform/qt/mathml/presentation/underover-expected.png: Removed.
  • platform/qt/mathml/presentation/underover-expected.txt: Removed.
  • platform/qt/mathml/xHeight-expected.png: Removed.
  • platform/qt/mathml/xHeight-expected.txt: Removed.
5:49 AM AddingFeatures edited by Laszlo Gombos
wtf/FeatureDefines.h has the defaults for all the feature flags (diff)
5:44 AM Changeset in webkit [143322] by abucur@adobe.com
  • 5 edits
    2 adds in trunk

[CSS Regions] Assertion in RenderFlowThread::removeRenderBoxRegionInfo
https://bugs.webkit.org/show_bug.cgi?id=109914

Reviewed by David Hyatt.

Source/WebCore:

This patch moves a part of the invalidation operations inside the RenderFlowThread::invalidateRegions call. The maps
are cleared anyway at layout time but doing this earlier makes sure the flow thread is in a more consistent state
(the RenderFlowThread object has both the region chain invalidated and the regions information cleared).

RenderFlowThread::removeRenderBoxRegionInfo will check if the region chain is invalidated. If true, it means the
flow thread has a layout scheduled and the regions information is not yet reliable. In this case we just return from the
function and wait for the layout to cleanup the box information.

Test: fast/regions/remove-box-info-assert.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRegionFromThread):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):

  • rendering/RenderFlowThread.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::removeRegionFromThread):

LayoutTests:

The test creates a flow thread with two regions and a content node. We remove the region and the node from the flow thread
at the same time. When the style is updated, the region is first removed from the chain and range information for boxes
is cleared from the flow thread. When the node is removed from the flow thread it tries to delete its region box information.
The range information on the flow thread is gone so the range for the node's box is zero - nothing gets deleted. Afterwards,
an ASSERT is triggered because there's leftover box information inside the region chain.

  • fast/regions/remove-box-info-assert-expected.txt: Added.
  • fast/regions/remove-box-info-assert.html: Added.
5:30 AM Changeset in webkit [143321] by senorblanco@chromium.org
  • 10 edits
    3 copies
    2 moves
    5 adds in trunk/LayoutTests

[chromium] Unreviewed gardening.
New baselines for effect-reference.html and effect-reference-hw.html

  • platform/chromium-linux-x86/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-linux-x86/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
  • platform/chromium-linux/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
  • platform/chromium-linux/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-mac-lion/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt.
  • platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt.
  • platform/chromium-mac/css3/filters/effect-reference-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-expected.txt:
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
  • platform/chromium-win-xp/css3/filters/effect-reference-expected.png: Added.
  • platform/chromium-win-xp/css3/filters/effect-reference-expected.txt: Copied from LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.txt.
  • platform/chromium-win/css3/filters/effect-reference-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-expected.txt:
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.txt:
5:15 AM Changeset in webkit [143320] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build broekn by r142988.
https://bugs.webkit.org/show_bug.cgi?id=109530

Unreviewed. Build fix.

Properly add shortMonthFormat() to the LocaleNone class.

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-02-19

  • platform/text/LocaleNone.cpp:

(LocaleNone):
(WebCore::LocaleNone::shortMonthFormat):

5:02 AM Changeset in webkit [143319] by allan.jensen@digia.com
  • 3 edits
    44 adds in trunk

[Qt] Enable MathML
https://bugs.webkit.org/show_bug.cgi?id=110205

Reviewed by Simon Hausmann.

Tools:

  • qmake/mkspecs/features/features.pri:

LayoutTests:

Baselines for the MathML tests.

  • platform/qt/mathml/presentation/attributes-expected.png: Added.
  • platform/qt/mathml/presentation/attributes-expected.txt: Added.
  • platform/qt/mathml/presentation/fenced-expected.png: Added.
  • platform/qt/mathml/presentation/fenced-expected.txt: Added.
  • platform/qt/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/qt/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/qt/mathml/presentation/fractions-expected.png: Added.
  • platform/qt/mathml/presentation/fractions-expected.txt: Added.
  • platform/qt/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/qt/mathml/presentation/fractions-vertical-alignment-expected.txt: Added.
  • platform/qt/mathml/presentation/mo-expected.png: Added.
  • platform/qt/mathml/presentation/mo-expected.txt: Added.
  • platform/qt/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/qt/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/qt/mathml/presentation/mroot-pref-width-expected.png: Added.
  • platform/qt/mathml/presentation/mroot-pref-width-expected.txt: Added.
  • platform/qt/mathml/presentation/over-expected.png: Added.
  • platform/qt/mathml/presentation/over-expected.txt: Added.
  • platform/qt/mathml/presentation/roots-expected.png: Added.
  • platform/qt/mathml/presentation/roots-expected.txt: Added.
  • platform/qt/mathml/presentation/row-alignment-expected.png: Added.
  • platform/qt/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/qt/mathml/presentation/row-expected.png: Added.
  • platform/qt/mathml/presentation/row-expected.txt: Added.
  • platform/qt/mathml/presentation/style-expected.png: Added.
  • platform/qt/mathml/presentation/style-expected.txt: Added.
  • platform/qt/mathml/presentation/sub-expected.png: Added.
  • platform/qt/mathml/presentation/sub-expected.txt: Added.
  • platform/qt/mathml/presentation/subsup-expected.png: Added.
  • platform/qt/mathml/presentation/subsup-expected.txt: Added.
  • platform/qt/mathml/presentation/sup-expected.png: Added.
  • platform/qt/mathml/presentation/sup-expected.txt: Added.
  • platform/qt/mathml/presentation/tables-expected.png: Added.
  • platform/qt/mathml/presentation/tables-expected.txt: Added.
  • platform/qt/mathml/presentation/tokenElements-expected.png: Added.
  • platform/qt/mathml/presentation/tokenElements-expected.txt: Added.
  • platform/qt/mathml/presentation/under-expected.png: Added.
  • platform/qt/mathml/presentation/under-expected.txt: Added.
  • platform/qt/mathml/presentation/underover-expected.png: Added.
  • platform/qt/mathml/presentation/underover-expected.txt: Added.
  • platform/qt/mathml/xHeight-expected.png: Added.
  • platform/qt/mathml/xHeight-expected.txt: Added.
4:45 AM Changeset in webkit [143318] by commit-queue@webkit.org
  • 6 edits in trunk

[Text Autosizing] Combine narrow descendants of a cluster into groups that should be autosized with the same multiplier.
https://bugs.webkit.org/show_bug.cgi?id=109825

Source/WebCore:

Enhancement of the approach introduced in https://bugs.webkit.org/show_bug.cgi?id=109573.
Instead of using the same text size multiplier for all narrow descendants of any autosizing
cluster, group the descendants by how much narrower they are than the cluster's
|blockContainingAllText| and process each group separately with a different multiplier for
each one.
For example, we want nested comments on the page to be autosized as a group but separately
from a sidebar on the same page.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

Updated the existing test to verify the patch.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processClusterInternal):

Splits the narrow descendants of the autosizing cluster into groups before processing
each group individually.

(WebCore::TextAutosizer::getNarrowDescendantsGroupedByWidth):

Sorts the narrow descendants of the given cluster into groups, combining them by the
difference between their content widths. If sorted by width, two consecutive nodes
belong to the same group if their width difference is no greater than 100 CSS units.

  • rendering/TextAutosizer.h:

New method definitions.

LayoutTests:

Verify that narrow descendants are grouped and autosized separately according to the
difference between the descendant's width and the width of its enclosing cluster's
|blockContainingAllText|.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

  • fast/text-autosizing/narrow-descendants-combined-expected.html:
  • fast/text-autosizing/narrow-descendants-combined.html:
4:21 AM Changeset in webkit [143317] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: show user provided name property of the heap snapshot node.
https://bugs.webkit.org/show_bug.cgi?id=110124

Reviewed by Yury Semikhatsky.

Publish userProvidedName into grid node.

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):

  • inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):

  • inspector/front-end/NativeHeapSnapshot.js:

(WebInspector.NativeHeapSnapshotNode.prototype.serialize):

4:15 AM Changeset in webkit [143316] by abucur@adobe.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
3:46 AM Changeset in webkit [143315] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening for chromium.
https://bugs.webkit.org/show_bug.cgi?id=110203

  • platform/chromium/TestExpectations:
2:41 AM Changeset in webkit [143314] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r143241): It made 27 layout tests crash on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=110184

Reviewed by Zoltan Herczeg.

32-bit backend was making all sorts of crazy assumptions, which happened to mostly
not break things prior to http://trac.webkit.org/changeset/143241. This brings the
32-bit backend's type speculation fully into compliance with what the 64-bit
backend does.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

2:14 AM Changeset in webkit [143313] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Caret is not displayed when trying to focus inside a contenteditable element containing an empty block.
https://bugs.webkit.org/show_bug.cgi?id=108053

Source/WebCore:

Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-02-19
Reviewed by Ryosuke Niwa.

Test: editing/selection/caret-in-div-containing-empty-block.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::localCaretRect):
When trying to compute the caret rect for the contenteditable div, the
border and the padding were not considered. Because of this, for the
given test case, which had a border defined on the containing div, the
caret was being painted just atop the border, thereby masking it.

Have modified the code to ensure that the computed caret rect takes
into account the border and padding (if any) specified on the box, but only
if the node doesn't have content that shall be skipped for editing.

We do not add border and padding while computing the caret rect for any
element that either has no content or has content that shall be skipped
for editing purposes. This holds true for table elements as well.

This helps avoid the caret displacement previsouly observed before/after
any controls placed within the contenteditable box, when considering
border and padding in computation of the caret rect.

LayoutTests:

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2013-02-19
Reviewed by Ryosuke Niwa.

  • editing/selection/caret-in-div-containing-empty-block-expected.txt: Added.
  • editing/selection/caret-in-div-containing-empty-block.html: Added.

Layout test added for verifying that a caret is displayed within a
contenteditable div having a border, both for the horizontal
as well as the vertical writing modes.

1:56 AM Changeset in webkit [143312] by mihnea@adobe.com
  • 4 edits
    2 adds in trunk

CSSRegions: crash positioned object with inline containing block in flow thread
https://bugs.webkit.org/show_bug.cgi?id=108307

Reviewed by David Hyatt.

Source/WebCore:

The fix for https://bugs.webkit.org/show_bug.cgi?id=69896 allowed positioned blocks work
with variable width regions. However, the information needed for that is available only
when the container used for positioning is a block.

This patch ensures we are using this solution only when the container used for positioning
is a block. This needs to be revisited when we will extend support for other types of boxes
as mentioned in RenderBox::renderBoxRegionInfo.

Test: fast/regions/positioned-object-inline-cb-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth): Make sure we are using containerBlocks
that are blocks. Add an assert that the type of containerBlock we are using can have
computed RenderBoxRegionInfo.
(WebCore::RenderBox::computePositionedLogicalHeight):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion): This helper method
will return the boxes that may have computed RenderBoxRegionInfo. Currently,
returns true for blocks only.

LayoutTests:

  • fast/regions/positioned-object-inline-cb-crash-expected.txt: Added.
  • fast/regions/positioned-object-inline-cb-crash.html: Added.
1:31 AM Changeset in webkit [143311] by morrita@google.com
  • 2 edits in trunk/Tools

Unreviewed, updated spelling of my name.

  • Scripts/webkitpy/common/config/committers.py:
1:27 AM Changeset in webkit [143310] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] fix ScrollAnimatorNoneTest after r143295
https://bugs.webkit.org/show_bug.cgi?id=110189

Reviewed by Nico Weber.

  • tests/ScrollAnimatorNoneTest.cpp:

(MockScrollableArea):

1:22 AM Changeset in webkit [143309] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Yet anther JSC build fix after r143304.

  • bindings/js/JSDOMBinding.h:

(WebCore::argumentOrNull):

1:00 AM Changeset in webkit [143308] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix. Fixed warning caused by r143305.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

12:55 AM Changeset in webkit [143307] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding a failure expectation for the failing

fast/regions/seamless-iframe-flowed-into-regions.html added in r143256.

12:23 AM Changeset in webkit [143306] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r143304.

  • bindings/js/JSDOMBinding.h:

(WebCore::argumentOrNull):

12:21 AM Changeset in webkit [143305] by haraken@chromium.org
  • 16 edits in trunk/Source/WebCore

[V8] Remove redundant usage of MAYBE_MISSING_PARAMETER() macro
https://bugs.webkit.org/show_bug.cgi?id=109899

Reviewed by Adam Barth.

Currently:

  • MAYBE_MISSING_PARAMETER(args, index, DefaultIsUndefined) returns args[index].
  • MAYBE_MISSING_PARAMETER(args, index, DefaultIsNullString) returns Local<Value>()

if args[index] is missing (i.e. the length of |args| is less than |index|).
It returns args[index] otherwise.

No one other than CodeGeneratorV8.pm uses
MAYBE_MISSING_PARAMETER(args, index, DefaultIsUndefined). Instead, we simply use
args[index]. We should remove the redundant usage from CodeGeneratorV8.pm too.
The long-name macro has been making generated code less readable.

In addition, we can rename MAYBE_MISSING_PARAMETER() to argumentOrNull().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::TestMediaQueryListListenerV8Internal::methodCallback):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::TestObjV8Internal::methodWithOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod4Callback):
(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::overloadedMethod10Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::classMethodWithOptionalCallback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1Callback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1Callback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(WebCore::TestObjV8Internal::domStringListFunctionCallback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::TestObjV8Internal::variadicStringMethodCallback):
(WebCore::TestObjV8Internal::variadicDoubleMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
(WebCore::V8TestOverloadedConstructors::constructor4Callback):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcCallback):
(WebCore::TestTypedefsV8Internal::setShadowCallback):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgCallback):
(WebCore::TestTypedefsV8Internal::nullableArrayArgCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunction2Callback):
(WebCore::V8TestTypedefs::constructorCallback):

  • bindings/v8/V8BindingMacros.h:

(WebCore):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallbackCustom):
(WebCore::V8History::replaceStateCallbackCustom):

12:12 AM Changeset in webkit [143304] by haraken@chromium.org
  • 14 edits in trunk/Source/WebCore

[JSC] MAYBE_MISSING_PARAMETER(..., DefaultIsNullString) macro is redundant
https://bugs.webkit.org/show_bug.cgi?id=109902

Reviewed by Adam Barth.

Currently:

  • MAYBE_MISSING_PARAMETER(exec, index, DefaultIsUndefined) returns exec->argument(index).
  • MAYBE_MISSING_PARAMETER(exec, index, DefaultIsNullString) returns JSValue() if exec->argument(index) is missing (i.e. the length of the argument is less than index). It returns exec->argument(index) otherwise.

No one other than CodeGeneratorJS.pm uses
MAYBE_MISSING_PARAMETER(exec, index, DefaultIsUndefined).
Instead, we simply use exec->argument(index). We should remove
the redundant usage in CodeGeneratorJS.pm too. The long-name macro
has been making generated code less readable.

In addition, we can rename MAYBE_MISSING_PARAMETER() to argumentOrNull().

c.f. corresponding V8 bug: https://bugs.webkit.org/show_bug.cgi?id=109899

No tests. No change in behavior.

  • bindings/js/JSDOMBinding.h:

(WebCore):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::jsFloat64ArrayPrototypeFunctionFoo):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefined):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod8):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod9):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod10):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence):
(WebCore::jsTestObjPrototypeFunctionStringArrayFunction):
(WebCore::jsTestObjPrototypeFunctionDomStringListFunction):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors1):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors2):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors3):
(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors4):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::constructJSTestTypedefs):
(WebCore::jsTestTypedefsPrototypeFunctionFunc):
(WebCore::jsTestTypedefsPrototypeFunctionMultiTransferList):
(WebCore::jsTestTypedefsPrototypeFunctionSetShadow):
(WebCore::jsTestTypedefsPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestTypedefsPrototypeFunctionNullableArrayArg):
(WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction):
(WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction2):

Feb 18, 2013:

11:57 PM Changeset in webkit [143303] by hayato@chromium.org
  • 9 edits
    2 adds in trunk

Make EventDispatcher take an Event object in its constructor.
https://bugs.webkit.org/show_bug.cgi?id=109898

Reviewed by Dimitri Glazkov.

Source/WebCore:

Re-landing r143145, which caused a crash when deltaX and deltaY of a PlatformWheelEvent are both zero.

Fixed a crash by early exiting in EventDispatcher::dispatchEvent(Node*, PassRefPtr<EventDispatcher*>)
if mediator's event() returns null.

Also Added a layout test to catch this kind of crash in the future.

Test: fast/events/platform-wheelevent-with-delta-zero-crash.html

  • dom/EventDispatchMediator.cpp:

(WebCore::EventDispatchMediator::dispatchEvent):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::ensureEventPath):
(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPreProcess):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):

  • dom/EventDispatcher.h:

(EventDispatcher):
(WebCore::EventDispatcher::node):
(WebCore::EventDispatcher::event):

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/WheelEvent.cpp:

(WebCore::WheelEventDispatchMediator::dispatchEvent):
Assert event() rather than an early exit since this code path should be hit only when event() is non-null.

LayoutTests:

  • fast/events/platform-wheelevent-with-delta-zero-crash-expected.txt: Added.
  • fast/events/platform-wheelevent-with-delta-zero-crash.html: Added.
11:48 PM Changeset in webkit [143302] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebKit2

[GTK] Remove webkit_web_view_get_subresources from WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=110125

Reviewed by Anders Carlsson.

This API is currently implemented caching all resources in the
WebView which causes some problems in documents loading resources
indefinitely. This API was used in WebKit1 mainly to implement
webkit_web_view_save(), but we already have such API in
WebKit2.

  • UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:

(didReceiveWebViewMessageFromInjectedBundle):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(_WebKitWebViewPrivate):
(webkitWebViewLoadChanged):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/TestResources.cpp:

(testWebViewResources):
(testWebResourceGetData):

11:39 PM Changeset in webkit [143301] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a flaky failing test expectation to inspector/editor/brace-matcher.html on Mac per bug 110186.

  • platform/mac/TestExpectations:
11:31 PM Changeset in webkit [143300] by tasak@google.com
  • 5 edits
    2 adds in trunk

:before/:after pseudo elements do not always apply to the proper element
https://bugs.webkit.org/show_bug.cgi?id=93925

Reviewed by Dimitri Glazkov.

Source/WebCore:

Disable sharing a style with siblings if :after or :before pseudo style
is unique.

Test: fast/css/before-after-pseudo-class.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):
Added a new condition, hasUniquePseudoStyle.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::hasUniquePseudoStyle):
Added to check whether any pseudo style has unique bit or not.
(WebCore):

  • rendering/style/RenderStyle.h:

LayoutTests:

  • fast/css/before-after-pseudo-class-expected.html: Added.
  • fast/css/before-after-pseudo-class.html: Added.
11:22 PM Changeset in webkit [143299] by aestes@apple.com
  • 5 edits
    2 adds in trunk

Focusing a new frame (via window.focus()) should blur the active element in the current frame
https://bugs.webkit.org/show_bug.cgi?id=110172

Reviewed by Ryosuke Niwa.

Source/WebCore:

When a change in the focused node crosses a frame boundary, WebKit
doesn't always succeed in blurring the old focused node before focusing
the new one.

Each document remembers its focused node, and a Page-scoped
FocusController remembers the focused frame. If a new focused node is
in a different frame than the focused frame, FocusController tells the
old frame's document to clear its focused node before focusing the new
one (and remembering the new frame).

Unfortunately, web content can confuse FocusController by calling
window.focus() at the wrong time. Since window.focus() changes
FocusController's focused frame without focusing a new node,
FocusController won't think that a frame boundary is being crossed if a
node in this frame is later focused. Therefore it won't clear the old
frame's focused node (it won't even know which frame contained the old
focused node), causing at least two bugs:

1) The node in the old frame will not receive a blur event.
2) Calling document.activeElement on the main frame will return the

previously focused node, but the HTML5 spec says it should return
the frame owner element if a subframe has focus.

Fix both of these bugs by explicitly clearing the current frame's
focused node if window.focus() changes the focused frame. This fix
carries some compatibility risk by changing a long-standing behavior
of the engine (we've had this bug since the beginning of the project,
AFAICT). On the upside, it matches the behavior of both Firefox and IE,
matches what HTML5 says about subframe focus, and fixes at least one
well-known enterprise web app.

Tests: fast/dom/HTMLDocument/active-element-frames.html

fast/frames/frame-focus-blurs-active-element.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::focus): If the frame being focused is not the same
as the currently focused frame, clear the currently focused frame's
focused node.

LayoutTests:

  • fast/dom/HTMLDocument/active-element-frames-expected.txt:
  • fast/dom/HTMLDocument/active-element-frames.html: Modified to run the

test a second time, focusing each element's frame before focusing the
element itself.

  • fast/frames/frame-focus-blurs-active-element-expected.txt: Added.
  • fast/frames/frame-focus-blurs-active-element.html: Added a test that

verifies a blur event is fired on the active element when a new frame
is focused.

11:18 PM Changeset in webkit [143298] by loislo@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Adjust expectations.

  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:

(TestWebKitAPI::TEST):

10:57 PM Changeset in webkit [143297] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2][EFL] Stop using internal C++ API in ewk_error
https://bugs.webkit.org/show_bug.cgi?id=108796

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-18
Reviewed by Benjamin Poulain.

Stop using internal C++ API in ewk_error and use C API instead of avoid
violating API layering.

  • UIProcess/API/efl/ewk_error.cpp:

(EwkError::domain):
(EwkError::isCancellation):
(ewk_error_type_get):

  • UIProcess/API/efl/ewk_error_private.h:

(EwkError):

10:39 PM Changeset in webkit [143296] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WebGL] Enable test webgl/conformance/canvas/texture-bindings-unaffected-on-resize.html.
https://bugs.webkit.org/show_bug.cgi?id=110176

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-18
Reviewed by Laszlo Gombos.

Enable the test for EFL port, as it passes after r143220.

  • platform/efl-wk2/TestExpectations:
10:35 PM Changeset in webkit [143295] by Simon Fraser
  • 30 edits in trunk/Source

Clean up the boolean argument to visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=110167

Source/WebCore:

Reviewed by Simon Fraser.

Replace the boolean argument to visibleContentRect() with
an enum.

No behavior change.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::viewportSize):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):

  • page/FrameView.cpp:

(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::layout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::windowClipRect):

  • page/SpatialNavigation.cpp:

(WebCore::canScrollInDirection):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::layoutSize):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::paint):

  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::visibleContentRect):

  • platform/ScrollableArea.h:
  • rendering/RenderDialog.cpp:

(WebCore::RenderDialog::layout):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::maximumScrollPosition):
(WebCore::RenderLayer::visibleContentRect):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):

Source/WebKit/blackberry:

Reviewed by Simon Fraser.

Replace the boolean argument to visibleContentRect() with
an enum.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::getRecursiveVisibleWindowRect):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

Source/WebKit/chromium:

Reviewed by Simon Fraser.

Replace the boolean argument to visibleContentRect() with
an enum.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::popupOpened):

Source/WebKit/efl:

Reviewed by Simon Fraser.

Replace the boolean argument to visibleContentRect() with
an enum.

  • ewk/ewk_frame.cpp:

(ewk_frame_visible_content_geometry_get):

Source/WebKit/win:

Reviewed by Simon Fraser.

Replace the boolean argument to visibleContentRect() with
an enum.

  • WebFrame.cpp:

(WebFrame::visibleContentRect):
(WebFrame::frameBounds):

Source/WebKit2:

Reviewed by Simon Fraser.

Replace the boolean argument to visibleContentRect() with
an enum.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::visibleContentBounds):
(WebKit::WebFrame::visibleContentBoundsExcludingScrollbars):

10:27 PM Changeset in webkit [143294] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

That didn't work either. Just make it public. This is why I hate nested classes. They just don't work.

  • rendering/RenderBlock.h:

(RenderBlock):

10:12 PM Changeset in webkit [143293] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Windows build fix. Apparently Visual Studio still has a lot of bugs with respect to nested classes.
Work around it by directly instantiating the class inside createFloatingObjects.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createFloatingObjects): Directly instantiate FloatingObjects.

  • rendering/RenderBlock.h:

(RenderBlock): Moved the declaration of createFloatingObjects up.
(FloatingObjects::FloatingObjects):

9:51 PM Changeset in webkit [143292] by loislo@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for Apple Windows. Second stage.
Add missed export statement.

7:52 PM Changeset in webkit [143291] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a flaky crash expectation to video-controls-captions-trackmenu.html on Mac per bug 110173.

  • platform/mac/TestExpectations:
7:42 PM Changeset in webkit [143290] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Merge handleSpecialChild into layoutBlockChildren
https://bugs.webkit.org/show_bug.cgi?id=110165

Reviewed by Darin Adler.

Merge handleSpecialChild, handlePositionedChild, and handleFloatingChild into layoutBlockChildren
to make the semantics of the code clear and to get rid of the outdated comment about how there are
four types of four types of special children.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChildren):

  • rendering/RenderBlock.h:

(RenderBlock):

7:38 PM Changeset in webkit [143289] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Encapsulate FloatingObject's constructor inside create
https://bugs.webkit.org/show_bug.cgi?id=110169

Reviewed by Darin Adler.

Added FloatingObject::create and made FloatingObject's constructor private.
Also added RenderBlock::ensureFloatingObjects to help lazily creating FloatingObjects.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::ensureFloatingObjects):
(WebCore::RenderBlock::FloatingObjects::create):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):

  • rendering/RenderBlock.h:

(FloatingObjects):
(RenderBlock):

7:20 PM Changeset in webkit [143288] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove a stale Mac test expectation.

  • platform/mac/TestExpectations:
6:55 PM Changeset in webkit [143287] by andersca@apple.com
  • 16 edits in trunk/Source

Add a DefaultHash for RefPtr<SecurityOrigin>
https://bugs.webkit.org/show_bug.cgi?id=110170

Reviewed by Andreas Kling.

Remove all explicit uses of SecurityOriginHash.

Source/WebCore:

  • Modules/webdatabase/DatabaseTracker.h:
  • Modules/webdatabase/OriginQuotaManager.h:
  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::getOriginsWithCache):

  • loader/cache/MemoryCache.h:
  • page/SecurityOriginHash.h:
  • storage/StorageNamespaceImpl.h:

(StorageNamespaceImpl):

Source/WebKit/mac:

  • WebCoreSupport/WebApplicationCache.mm:

(+[WebApplicationCache originsWithCache]):

Source/WebKit2:

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::SessionStorageNamespace):

  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::originsWithApplicationCache):

  • WebProcess/Notifications/NotificationPermissionRequestManager.h:

Include SecurityOriginHash.h. This fixes a bug where m_originToIDMap used pointer-equality
for looking up security origins.

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::clearCacheForOrigin):
This can just take a const reference.

  • WebProcess/ResourceCache/WebResourceCacheManager.h:
6:34 PM Changeset in webkit [143286] by roger_fong@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed Windows build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
6:02 PM Changeset in webkit [143285] by cevans@google.com
  • 2 edits in branches/chromium/1410/Source/WebCore/Modules/mediastream

Merge 142887
BUG=176033
Review URL: https://codereview.chromium.org/12297021

6:01 PM Changeset in webkit [143284] by hyatt@apple.com
  • 5 edits
    2 adds in trunk

Padding and border changes don't trigger the relayout of children in some cases.
https://bugs.webkit.org/show_bug.cgi?id=109639.

Reviewed by Ryosuke Niwa.

Source/WebCore:

The fix for this bug was way too general and involved putting code into RenderBox. Since
RenderBox makes no assumptions about what kind of layout system might derive from it, it
was incorrect to just mark all children as needing layout whenever borders and padding
changed widths.

This patch takes the two cases handled by the original code and makes them more
specialized down in subclasses, i.e., RenderBlock and RenderTableRow. RenderBlock has
been refined to only check if children aren't inline and to also not invalidate
floats or irrelevant positioned objects that might not even have this block as their
containing block.

The RenderTableRow code is specialized to only care about collapsing borders and
to only check borders rather than padding. It also requires that a child be a cell
in order to do the invalidation.

Covered by existing tests, since this is just specializing the code to more precisely
cover the test cases that have already been written.

Longer term, it should be layout code that figures this stuff out rather than style
change code, but that involves more dramatic changes that can wait.

Test: fast/block/positioning/border-change-relayout-test.html

  • rendering/RenderBlock.cpp:

(WebCore::borderOrPaddingLogicalWidthChanged):
(WebCore):
(WebCore::RenderBlock::styleDidChange):

  • rendering/RenderBox.cpp:

(WebCore):
(WebCore::RenderBox::styleDidChange):

  • rendering/RenderTableRow.cpp:

(WebCore::borderLogicalWidthChanged):
(WebCore):
(WebCore::RenderTableRow::styleDidChange):

LayoutTests:

  • fast/block/positioning/border-change-relayout-test-expected.html: Added.
  • fast/block/positioning/border-change-relayout-test.html: Added.
5:56 PM Changeset in webkit [143283] by Darin Adler
  • 3 edits in trunk/Source/JavaScriptCore

Remove unneeded explicit function template arguments.
https://bugs.webkit.org/show_bug.cgi?id=110043

Reviewed by Ryosuke Niwa.

  • runtime/Identifier.cpp:

(JSC::IdentifierASCIIStringTranslator::hash): Let the compiler deduce the type
when calling computeHashAndMaskTop8Bits.
(JSC::IdentifierLCharFromUCharTranslator::hash): Ditto.

  • runtime/Identifier.h:

(JSC::IdentifierCharBufferTranslator::hash): Ditto.

5:55 PM Changeset in webkit [143282] by mark.lam@apple.com
  • 3 edits in trunk/Source/WebCore

Small follow up to r143271: Fix SQLTransaction leak.
https://bugs.webkit.org/show_bug.cgi?id=110052.

Reviewed by Geoffrey Garen.

Applied Geoff's suggestion nullify m_frontend sooner for greater
code clarity. Also added some comments about m_frontend.

No new tests.

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::doCleanup):

  • Modules/webdatabase/SQLTransactionBackend.h:

(SQLTransactionBackend):

5:51 PM Changeset in webkit [143281] by cevans@google.com
  • 4 edits
    2 copies in branches/chromium/1410

Merge 143060
BUG=170184
Review URL: https://codereview.chromium.org/12301012

5:45 PM Changeset in webkit [143280] by Darin Adler
  • 2 edits in trunk/Source/WTF

Style tweaks to StringHasher.h
https://bugs.webkit.org/show_bug.cgi?id=110042

Reviewed by Alexey Proskuryakov.

I have a bug fix coming soon, but figured I'd separate out style tweaks and land them
first to make that patch easier to undrestand.

  • wtf/StringHasher.h: Tweak and rearrange comments a bit.

(WTF::StringHasher::addCharacter): Use character instead of ch.
(WTF::StringHasher::addCharacters): Use remainder instead of rem. Also capitalize the U
that we use to make an unsigned 1 constant.
(WTF::StringHasher::computeHashAndMaskTop8Bits): Ditto.
(WTF::StringHasher::hashMemory): Change version that takes size as a template argument
to call the version that takes the size at runtime, since both generate the same code
anyway. Added a FIXME questioning why this function uses the "mask top 8 bits" version
of the hash. Fix incorrect compile assertion that required sizes that are multiples
of four. This function works on sizes that are multiples of two. Also fixed a spelling
error where we called it a "multible".
(WTF::StringHasher::defaultConverter): Use character instead of ch.
(WTF::StringHasher::addCharactersToHash): Eliminated unnecessary local variable.

5:39 PM Changeset in webkit [143279] by ggaren@apple.com
  • 17 edits
    3 adds in trunk

Shrank the SourceProvider cache
https://bugs.webkit.org/show_bug.cgi?id=110158

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

CodeCache is now our primary source cache, so a long-lived SourceProvider
cache is a waste. I measured this as a 10MB Membuster win; with more
precise instrumentation, Andreas estimated it as up to 30MB.

I didn't eliminate the SourceProvider cache because it's still useful
in speeding up uncached parsing of scripts with large nested functions
(i.e., all scripts).

  • heap/Heap.cpp:

(JSC::Heap::collect): Discard all source provider caches after GC. This
is a convenient place to do so because it's reasonably soon after initial
parsing without being immediate.

  • parser/Parser.cpp:

(JSC::::Parser): Updated for interface change: The heap now owns the
source provider cache, since most SourceProviders are not expected to
have one by default, and the heap is responsible for throwing them away.

(JSC::::parseInner): No need to update statistics on cache size, since
we're going to throw it away no matter what.

(JSC::::parseFunctionInfo): Reduced the minimum function size to 16. This
is a 27% win on a new parsing micro-benchmark I've added. Now that the
cache is temporary, we don't have to worry so much about its memory
footprint.

  • parser/Parser.h:

(Parser): Updated for interface changes.

  • parser/SourceProvider.cpp:

(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::~SourceProvider):

  • parser/SourceProvider.h:

(JSC):
(SourceProvider): SourceProvider doesn't own its cache anymore because
the cache is temporary.

  • parser/SourceProviderCache.cpp:

(JSC::SourceProviderCache::clear):
(JSC::SourceProviderCache::add):

  • parser/SourceProviderCache.h:

(JSC::SourceProviderCache::SourceProviderCache):
(SourceProviderCache):

  • parser/SourceProviderCacheItem.h:

(SourceProviderCacheItem): No need to update statistics on cache size,
since we're going to throw it away no matter what.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::addSourceProviderCache):
(JSC):
(JSC::JSGlobalData::clearSourceProviderCaches):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData): Moved the cache here so it's easier to throw away.

Source/WebCore:

Test: fast/js/regress/nested-function-parsing.html

No need to keep statistics on cache size, since we're going to throw it
away no matter what.

  • WebCore.order:
  • bindings/js/CachedScriptSourceProvider.h:

(CachedScriptSourceProvider):
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::destroyDecodedData):
(WebCore):
(WebCore::CachedScript::reportMemoryUsage):

  • loader/cache/CachedScript.h:

(CachedScript):

LayoutTests:

New benchmark to show that a minimum size of 16 is better than 64.

  • fast/js/regress/nested-function-parsing-expected.txt: Added.
  • fast/js/regress/nested-function-parsing.html: Added.
  • fast/js/regress/script-tests/nested-function-parsing.js: Added.
5:29 PM Changeset in webkit [143278] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit

[Windows] Unreviewed VS2010 build correction.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Sync

export definition with VS2005 version.

5:22 PM Changeset in webkit [143277] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Begin stubbing out session storage classes
https://bugs.webkit.org/show_bug.cgi?id=110168

Reviewed by Andreas Kling.

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit):
(WebKit::StorageManager::StorageArea::create):
(WebKit::StorageManager::StorageArea::StorageArea):
(WebKit::StorageManager::StorageArea::~StorageArea):
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::isEmpty):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::~SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
(WebKit::StorageManager::createSessionStorageNamespaceInternal):
(WebKit::StorageManager::destroySessionStorageNamespaceInternal):
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

5:15 PM Changeset in webkit [143276] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG backend Branch handling has duplicate code and dead code
https://bugs.webkit.org/show_bug.cgi?id=110162

Reviewed by Mark Hahnenberg.

Streamline the code, and make the 64 backend's optimizations make more sense
(i.e. not be dead code).

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

4:40 PM Changeset in webkit [143275] by Christophe Dumez
  • 16 edits
    2 moves
    10 adds in trunk/Source/WebKit2

[EFL][WK2] Add C API for popup menu and popup item
https://bugs.webkit.org/show_bug.cgi?id=109083

Reviewed by Anders Carlsson.

WK2 EFL delegates display of the popup menu to the browser which causes
us to have a strong interdependency between internal C++ classes
(WebPopupMenuProxyEfl, WebPopupItem) and our EFL API implementation
(EwkView, EwkPopupMenu, EwkPopupMenuItem).

Since we want to remove this interdependency, this patch introduces a
for WebPopupMenuProxyEfl (WKPopupMenuListener) and for WebPopupItem
(WKPopupItem). It also introduces a WKPage client with callbacks for
showPopupMenu and hidePopupMenu.

Note that the popup menu functionality is covered by ewk_popup_menu API
tests and no functionality is lost.

  • PlatformEfl.cmake: Add new files to EFL CMake config.
  • Shared/API/c/efl/WKBaseEfl.h: Add typedefs for WKPopupItemRef and

WKPopupMenuListenerRef.

  • Shared/APIObject.h: Add new TypePopupMenuItem APIObject type for EFL

platform.

  • UIProcess/API/C/efl/WKAPICastEfl.h: Add mapping for WKPopupItemRef

and WKPopupMenuListenerRef API types.
(WebKit):
(WebKit::toAPI):

  • UIProcess/API/C/efl/WKPageEfl.cpp: Added.

(WKPageSetUIPopupMenuClient): Add new C API to set the UI Popup Menu
client on the page.

  • UIProcess/API/C/efl/WKPageEfl.h: Added.
  • UIProcess/API/C/efl/WKPopupItem.cpp: Added. Add C API for WebPopupItem.

(WKPopupItemGetType):
(WKPopupItemGetTextDirection):
(WKPopupItemHasTextDirectionOverride):
(WKPopupItemCopyText):
(WKPopupItemCopyToolTipText):
(WKPopupItemCopyAccessibilityText):
(WKPopupItemIsEnabled):
(WKPopupItemIsLabel):
(WKPopupItemIsSelected):

  • UIProcess/API/C/efl/WKPopupItem.h: Added.
  • UIProcess/API/C/efl/WKPopupMenuListener.cpp: Added. Add C API for

WebPopupMenuListenerEfl (formerly WebPopupMenuProxyEfl) so that the
client can report which popup menu item was selected.
(WKPopupMenuListenerSetSelection):

  • UIProcess/API/C/efl/WKPopupMenuListener.h: Added.
  • UIProcess/API/efl/EwkView.cpp: Remove dependency on internal C++ types

(WebPopupMenuProxyEfl and WebPopupItem) and use C API types instead.
(EwkView::requestPopupMenu):

  • UIProcess/API/efl/EwkView.h:

(WebKit):
(EwkView):

  • UIProcess/API/efl/ewk_popup_menu.cpp: Use C API for Popup menu.

(EwkPopupMenu::EwkPopupMenu):
(EwkPopupMenu::setSelectedIndex):

  • UIProcess/API/efl/ewk_popup_menu_private.h:

(EwkPopupMenu::create):
(EwkPopupMenu):

  • UIProcess/WebPageProxy.cpp: Use WKPageUIPopupMenuClient to show / hide

the popup menu on EFL port instead of asking the WebPopupMenuProxy.
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::hidePopupMenu):

  • UIProcess/WebPageProxy.h: Add new WKPageUIPopupMenuClient member and

corresponding initialization method.
(WebPageProxy):

  • UIProcess/WebPopupMenuProxy.h: Disable showPopupMenu / hidePopupMenu

virtual methods on EFL port since we go via WKPageUIPopupMenuClient
for this now.
(WebPopupMenuProxy):

  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::PageUIClientEfl): Handle WKPageUIPopupMenuClient
callbacks and call corresponding EwkView methods. Previously, the EwkView
methods were called by the internal WebPageProxyEfl class which is no
longer needed.
(WebKit::PageUIClientEfl::showPopupMenu):
(WebKit):
(WebKit::PageUIClientEfl::hidePopupMenu):

  • UIProcess/efl/PageUIClientEfl.h:

(PageUIClientEfl):

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::initializeUIPopupMenuClient):
(WebKit):

  • UIProcess/efl/WebPopupItemEfl.cpp: Added. Add APIObject wrapper for

WebPopupItem so that we can use it in WKPageUIPopupMenuClient.
(WebKit):
(WebKit::WebPopupItemEfl::WebPopupItemEfl):
(WebKit::WebPopupItemEfl::~WebPopupItemEfl):

  • UIProcess/efl/WebPopupItemEfl.h: Added.

(WebKit):
(WebPopupItemEfl):
(WebKit::WebPopupItemEfl::create):
(WebKit::WebPopupItemEfl::data):
(WebKit::WebPopupItemEfl::itemType):
(WebKit::WebPopupItemEfl::text):
(WebKit::WebPopupItemEfl::textDirection):
(WebKit::WebPopupItemEfl::hasTextDirectionOverride):
(WebKit::WebPopupItemEfl::toolTipText):
(WebKit::WebPopupItemEfl::accessibilityText):
(WebKit::WebPopupItemEfl::isEnabled):
(WebKit::WebPopupItemEfl::isLabel):
(WebKit::WebPopupItemEfl::isSelected):
(WebKit::WebPopupItemEfl::type):

  • UIProcess/efl/WebPopupMenuListenerEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.cpp.

Use WebPopupMenuListenerEfl name instead of WebPopupMenuProxyEfl since
it more accurately represents its functionality now.
(WebKit):
(WebKit::WebPopupMenuListenerEfl::WebPopupMenuListenerEfl):
(WebKit::WebPopupMenuListenerEfl::valueChanged):

  • UIProcess/efl/WebPopupMenuListenerEfl.h: Renamed from Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.h.

(WebKit):
(WebPopupMenuListenerEfl):
(WebKit::WebPopupMenuListenerEfl::create):

  • UIProcess/efl/WebUIPopupMenuClient.cpp: Added.

(WebUIPopupMenuClient::showPopupMenu):
(WebUIPopupMenuClient::hidePopupMenu):

  • UIProcess/efl/WebUIPopupMenuClient.h: Added.

(WebKit):
(WebUIPopupMenuClient):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::createPopupMenuProxy):

4:30 PM WebKit Team edited by kbalazs@webkit.org
(diff)
4:19 PM Changeset in webkit [143274] by bfulgham@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed VS2010 build correction after r143273.

file SourceProvider.cpp.

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Add missing exports.
4:03 PM Changeset in webkit [143273] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Add StorageManager member functions for keeping track of session storage namespaces
https://bugs.webkit.org/show_bug.cgi?id=110163

Reviewed by Andreas Kling.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createSessionStorageNamespace):
(WebKit):
(WebKit::StorageManager::destroySessionStorageNamespace):
(WebKit::StorageManager::cloneSessionStorageNamespace):
(WebKit::StorageManager::createSessionStorageNamespaceInternal):
(WebKit::StorageManager::destroySessionStorageNamespaceInternal):
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/WebContext.h:

(WebKit::WebContext::storageManager):
(WebContext):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::createNewPage):

4:00 PM Changeset in webkit [143272] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Curl] The function cookiesForDOM() does not behave correctly.
https://bugs.webkit.org/show_bug.cgi?id=109923

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-02-18
Reviewed by Brent Fulgham.

The cookiesForDOM() function should return a list of matching cookies, both persistent and session cookies.

  • platform/network/curl/CookieJarCurl.cpp:

(WebCore::readCurlCookieToken): Added function to read next token from Curl cookie string.
(WebCore::addMatchingCurlCookie): Added function to add matching cookies to cookie list.
(WebCore::setCookiesFromDOM): Add domain and path from url to cookie if not already set.
(WebCore::cookiesForDOM): Return a list of matching cookies, both session and persistent cookies.

3:42 PM Changeset in webkit [143271] by mark.lam@apple.com
  • 11 edits in trunk/Source/WebCore

Fix SQLTransaction leak.
https://bugs.webkit.org/show_bug.cgi?id=110052.

Reviewed by Geoffrey Garen.

With https://bugs.webkit.org/show_bug.cgi?id=104750, there is now a circular
reference between SQLTransaction and its backend. The clean up process needs
to be fixed to explicitly break this reference cycle.

The 5 phases of the SQLTransaction (and backend) phases and their clean up
actions are:

Phase 1. After Birth, before scheduling

  • During shutdown, DatabaseThread::databaseThread() calls DatabaseBackendAsync::close(). DatabaseBackendAsync::close() iterates DatabaseBackendAsync::m_transactionQueue and calls SQLtransactionBackend::notifyDatabaseThreadIsShuttingDown() on each transaction there.

Phase 2. After scheduling, before state AcquireLock

  • ~DatabaseTask() calls SQLtransactionBackend's notifyDatabaseThreadIsShuttingDown().

Phase 3. After state AcquireLock, before "lockAcquired"

  • During shutdown, DatabaseThread::databaseThread() calls SQLTransactionCoordinator::shutdown(), which calls SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown().

Phase 4: After "lockAcquired", before state CleanupAndTerminate

  • Same as Phase 3.

Phase 5: After state CleanupAndTerminate

  • state CleanupAndTerminate calls SQLTransactionBackend::doCleanup().

See comment at the top of SQLTransactionBackend.cpp for more details.

Other supporting changes:

  • Moved Database::close() to the DatabaseBackendAsync.
  • Moved the "if already cleaned up" check from SQLTransactionBackend's notifyDatabaseThreadIsShuttingDown() to doCleanup().
  • Added a check to prevent SQLTransactionCoordinator's releaseLock() from running when it's shutting down.

No new tests.

  • Modules/webdatabase/Database.cpp:
  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseBackendAsync.cpp:

(WebCore::DatabaseBackendAsync::close): Move from Database.cpp.

  • Modules/webdatabase/DatabaseBackendAsync.h:
  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::~DatabaseTransactionTask):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::doPerformTask):

  • Modules/webdatabase/DatabaseTask.h:

(DatabaseBackendAsync::DatabaseTransactionTask):

  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransactionBackend::cleanupAndTerminate):

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::SQLTransactionCoordinator):
(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):

  • Modules/webdatabase/SQLTransactionCoordinator.h:

(SQLTransactionCoordinator):

3:29 PM Changeset in webkit [143270] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Fix WebCore Xcode project

  • WebCore.xcodeproj/project.pbxproj: Fix path for CDMPrivate.h.
3:21 PM Changeset in webkit [143269] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

Structure::flattenDictionaryStructure should compute max offset in a manner that soundly handles the case where the property list becomes empty
https://bugs.webkit.org/show_bug.cgi?id=110155
<rdar://problem/13233773>

Source/JavaScriptCore:

Reviewed by Mark Rowe.

This was a rookie mistake. It was doing:

for (blah) {

m_offset = foo foo's monotonically increase in the loop

}

as a way of computing max offset for all of the properties. Except what if the loop doesn't
execute because there are no properties? Well, then, you're going to have a bogus m_offset.

The solution is to initialize m_offset at the top of the loop.

  • runtime/Structure.cpp:

(JSC::Structure::flattenDictionaryStructure):

LayoutTests:

Reviewed by Mark Rowe.

  • fast/js/flatten-dictionary-structure-from-which-all-properties-were-deleted-expected.txt: Added.
  • fast/js/flatten-dictionary-structure-from-which-all-properties-were-deleted.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/flatten-dictionary-structure-from-which-all-properties-were-deleted.js: Added.
3:15 PM Changeset in webkit [143268] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Grid Layout] Refactor grid position resolution code to support an internal grid representation
https://bugs.webkit.org/show_bug.cgi?id=109718

Reviewed by Ojan Vafai.

In order to support auto placement (where we can't infer a grid item's position from its style),
we need to have 2 code paths:

  • One that places the elements on the grid representation.
  • One that reuse the grid representation to return the position.

This code path implements this split so that we can add auto placement in a follow-up patch(es).
Also in order to avoid a O(n2) behavior [walking over our grid to find a grid item's position],
the cached position code path needed an efficient way to find the grid items -> position mapping.

Refactoring, covered by existing tests.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::cachedGridCoordinate):
(WebCore::RenderGrid::resolveGridPositionFromStyle):
These methods implements the above split. The first one
reuses our cached information whereas the other one is
used to build the cache.

(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::layoutGridItems):
Added some code to clear the grid items' position.

(WebCore::RenderGrid::findChildLogicalPosition):
(WebCore::RenderGrid::logicalContentHeightForChild):
Updated these functions to use cachedGridPosition.

(WebCore::RenderGrid::maximumIndexInDirection):
Added a comment about why we don't use cachedGridPosition.

(WebCore::RenderGrid::insertItemIntoGrid):
Added this helper function to insert into the grid and
cache the position in the reverse lookup map.

(WebCore::RenderGrid::placeItemsOnGrid):
Updated to call insertItemIntoGrid. Also added an ASSERT
similar to m_grid.

(WebCore::RenderGrid::clearGrid):
Added this helper function to clear our grid structure.

  • rendering/RenderGrid.h:

(GridCoordinate):
(WebCore::RenderGrid::GridCoordinate::GridCoordinate):
Added this POD to hold the coordinates in our reverse map.

3:07 PM Changeset in webkit [143267] by schenney@chromium.org
  • 37 edits
    2 adds in trunk

feFlood incorrectly applied color-interpolation-filters
https://bugs.webkit.org/show_bug.cgi?id=109985

Reviewed by Dirk Schulze.

Source/WebCore:

The SVG spec defines the color-interpolation-filters property for all
filter effect elements in order to control cases where a color is
based on some arithmetic computation on other colors. For example,
when computing gradients or blending colors. feFlood simply fills a
region with the given color, and that given color is always defined to
be in sRGB space, so the feFlood result should always be sRGB.

The new behavior matches both Opera and Firefox.

Tests: svg/filters/feFlood-color-interpolation-expected.svg

svg/filters/feFlood-color-interpolation.svg

  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::platformApplySoftware): Force the color mode to be
sRGB before returning.

LayoutTests:

New test for feFlood behavior when color-interpolation-filters is used.

Failing expectations for tests affected by this change.

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • svg/filters/feFlood-color-interpolation-expected.svg: Added.
  • svg/filters/feFlood-color-interpolation.svg: Added.
3:00 PM Changeset in webkit [143266] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests

Just skip the seamless iframe flowed into regions test on chromium. It's failing with a repaint issue.

  • platform/chromium/TestExpectations:
2:38 PM Changeset in webkit [143265] by ap@apple.com
  • 2 edits in trunk/Source/WTF

Make HexNumber functions return 8-bit strings
https://bugs.webkit.org/show_bug.cgi?id=110152

Reviewed by Michael Saboff.

  • wtf/HexNumber.h: (Internal): (WTF::Internal::hexDigitsForMode): (WTF::appendByteAsHex): (WTF::placeByteAsHexCompressIfPossible): (WTF::placeByteAsHex): (WTF::appendUnsignedAsHex): (WTF::appendUnsignedAsHexFixedSize): Use LChar everywhere.
2:31 PM Changeset in webkit [143264] by mark.lam@apple.com
  • 15 edits
    2 adds in trunk/Source/WebCore

Introduced AbstractSQLStatement and AbstractSQLStatementBackend.
https://bugs.webkit.org/show_bug.cgi?id=110148.

Reviewed by Geoff Garen.

This is part of the webdatabase refactoring for webkit2.

  • Also changed the frontend and backend to only refer to the abstract interface of each other.

No new tests.

  • GNUmakefile.list.am:
  • Modules/webdatabase/AbstractSQLStatement.h: Added.

(AbstractSQLStatement):
(WebCore::AbstractSQLStatement::~AbstractSQLStatement):

  • Modules/webdatabase/AbstractSQLStatementBackend.h: Added.

(AbstractSQLStatementBackend):
(WebCore::AbstractSQLStatementBackend::~AbstractSQLStatementBackend):

  • Modules/webdatabase/SQLStatement.cpp:

(WebCore::SQLStatement::setBackend):

  • Modules/webdatabase/SQLStatement.h:

(SQLStatement):

  • Modules/webdatabase/SQLStatementBackend.cpp:

(WebCore::SQLStatementBackend::create):
(WebCore::SQLStatementBackend::SQLStatementBackend):
(WebCore::SQLStatementBackend::frontend):

  • Modules/webdatabase/SQLStatementBackend.h:

(SQLStatementBackend):

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverStatementCallback):

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::currentStatement):
(WebCore::SQLTransactionBackend::executeSQL):

  • Modules/webdatabase/SQLTransactionBackend.h:

(SQLTransactionBackend):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
2:11 PM Changeset in webkit [143263] by ddkilzer@apple.com
  • 5 edits in trunk/Source/WebCore

BUILD FIX (r143230): Fix renamed header and implementation of -[WebAccessibilityObjectWrapper accessibilityPostedNotification:]
<http://webkit.org/b/110077>

Fixes the following build failures:

AccessibilityObjectIOS.mm:35:9: fatal error: 'AccessibilityObjectWrapperIOS.h' file not found
#import "AccessibilityObjectWrapperIOS.h"


1 error generated.

WebAccessibilityObjectWrapperIOS.mm:2051:35: error: use of undeclared identifier 'notificationString'; did you mean 'notificationType'?

if (AXNotificationCallback && notificationString)

~
notificationType

WebAccessibilityObjectWrapperIOS.mm:2049:81: note: 'notificationType' declared here

  • (void)accessibilityPostedNotification:(WebCore::AXObjectCache::AXNotification)notificationType


WebAccessibilityObjectWrapperIOS.mm:2052:38: error: use of undeclared identifier 'notificationString'; did you mean 'notificationType'?

AXNotificationCallback(self, notificationString, AXPostedNotificationContext);

~
notificationType

WebAccessibilityObjectWrapperIOS.mm:2049:81: note: 'notificationType' declared here

  • (void)accessibilityPostedNotification:(WebCore::AXObjectCache::AXNotification)notificationType


WebAccessibilityObjectWrapperIOS.mm:2052:38: error: cannot initialize a parameter of type 'NSString *' with an lvalue of type 'WebCore::AXObjectCache::AXNotification'

AXNotificationCallback(self, notificationString, AXPostedNotificationContext);

~

WebAccessibilityObjectWrapperIOS.mm:2049:81: error: conflicting parameter types in implementation of 'accessibilityPostedNotification:': 'NSString *' vs 'WebCore::AXObjectCache::AXNotification' [-Werror,-Wmismatched-parameter-types]

  • (void)accessibilityPostedNotification:(WebCore::AXObjectCache::AXNotification)notificationType


WebAccessibilityObjectWrapperBase.h:48:53: note: previous definition is here

  • (void)accessibilityPostedNotification:(NSString *)notificationName;


4 errors generated.

  • accessibility/ios/AccessibilityObjectIOS.mm: Fix name of

included header.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
Fix implementation to match declaration.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
  • accessibility/ios/AXObjectCacheIOS.mm:
  • Clean up #endif comments.
1:52 PM Changeset in webkit [143262] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

StorageManager message handlers should take the connection
https://bugs.webkit.org/show_bug.cgi?id=110151

Reviewed by Andreas Kling.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC):
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessage):

  • Scripts/webkit2/messages.py:

(sync_message_statement):
(generate_message_handler):

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):
(WebKit::StorageManager::getValues):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/Storage/StorageManager.messages.in:
1:52 PM Changeset in webkit [143261] by jochen@chromium.org
  • 2 edits in trunk/LayoutTests

clear databases before running read-transactions-running-concurrently test
https://bugs.webkit.org/show_bug.cgi?id=110144

Reviewed by Nico Weber.

Otherwise, we might not have enough quota when running this tests and lots
of databases from previous tests are hanging around.

  • storage/websql/read-transactions-running-concurrently.html:
1:44 PM Changeset in webkit [143260] by Lucas Forschler
  • 6 edits in tags/Safari-537.31.3/Source

Merge <rdar://problem/12968169>

1:37 PM Changeset in webkit [143259] by jer.noble@apple.com
  • 6 edits
    2 adds in trunk/Source/WebCore

EME: Add a CDMPrivate implementation using AVFoundation.
https://bugs.webkit.org/show_bug.cgi?id=109739

Reviewed by Eric Carlson.

Add a CDMPrivate implementation using AVFoundation, similar to the EME v1 implementation
in MediaPlayerPrivateAVFoundationObjC. This requires passing the AVAssetResourceLoadingRequest
from the MediaPlayerPrivateAVFoundationObjC instance to CDMSessionAVFoundation. To do so
without adding platform-specific API to MediaPlayer, add a static map from MediaPlayer ->
MediaPlayerPrivateAVFoundationObjC instances to be used to vend the AVAssetResourceLoadingRequest
to CDMSessionAVFoundation.

  • Modules/encryptedmedia/CDM.cpp:

(WebCore::installedCDMFactories): Add the factory for CDMPrivateAVFoundation.

  • Modules/encryptedmedia/CDM.h:
  • Modules/encryptedmedia/CDMPrivateAVFoundation.h: Added.

(WebCore::CDMPrivateAVFoundation::create): Simple factory method.
(WebCore::CDMPrivateAVFoundation::~CDMPrivateAVFoundation): Simple virtual destructor.
(WebCore::CDMPrivateAVFoundation::cdm): Simple getter.
(WebCore::CDMPrivateAVFoundation::CDMPrivateAVFoundation): Simple constructor.

  • Modules/encryptedmedia/CDMPrivateAVFoundation.mm: Added.

(WebCore::CDMSessionAVFoundation::~CDMSessionAVFoundation): Simple destructor.
(WebCore::CDMPrivateAVFoundation::supportsKeySytem): Check whether the given key system is supported.
(WebCore::CDMPrivateAVFoundation::supportsMIMEType): Check whether the given MIME type is supported.
(WebCore::CDMPrivateAVFoundation::createSession): Return a new CDMSessionAVFoundation.
(WebCore::CDMSessionAVFoundation::CDMSessionAVFoundation): Simple constructor.
(WebCore::CDMSessionAVFoundation::generateKeyRequest): Retrieve the AVAssetResourceLoadingRequest

from the MediaPlayer, and use it to generate a key request.

(WebCore::CDMSessionAVFoundation::releaseKeys): No-op.
(WebCore::CDMSessionAVFoundation::update): Add the passed in key to the AVAssetResourceLoadingRequest.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::playerToPrivateMap): Lazily instantiate static map.
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Register with the playerToPrivateMap.
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Unregister from same.
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource): Also send keyNeeded event in ENCRYPTED_MEDIA_V2.
(WebCore::MediaPlayerPrivateAVFoundationObjC::extractKeyURIKeyIDAndCertificateFromInitData): Convert this

method from file-static to class static.

(WebCore::MediaPlayerPrivateAVFoundationObjC::takeRequestForPlayerAndKeyURI): Pull the AVAssetResourceLoadingRequest

from m_keyURIToRequestMap and return it, if present.

1:36 PM Changeset in webkit [143258] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Use C API inside ewk_security_origin
https://bugs.webkit.org/show_bug.cgi?id=107923

Patch by Christophe Dumez <Christophe Dumez> on 2013-02-18
Reviewed by Alexey Proskuryakov.

Use C API inside ewk_security_origin instead of accessing
directly internal C++ classes, to avoid breaking API
layering.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::enterFullScreen):

  • UIProcess/API/efl/ewk_security_origin.cpp:

(EwkSecurityOrigin::EwkSecurityOrigin):

  • UIProcess/API/efl/ewk_security_origin_private.h:

(EwkSecurityOrigin::create):
(EwkSecurityOrigin):

1:25 PM Changeset in webkit [143257] by pdr@google.com
  • 3 edits
    2 adds in trunk

Fix scaling of tiled SVG backgrounds on high-dpi displays
https://bugs.webkit.org/show_bug.cgi?id=110047

Reviewed by Dirk Schulze.

Source/WebCore:

This patch fixes the scaling of SVG when used for drawing patterns. Tiled/patterend SVG
images are first drawn into an image buffer and then the image buffer is used to stamp
out tiles. Because it is a raster source, the size of the image buffer needs to
be scaled to the final resolution of the device. After scaling the image buffer, the
source rect and pattern transforms need to be adjusted so they align in device pixel
coordinates. This adjustment was not done before this patch, causing pixelated rendering.

Additionally, a FIXME has been added due to webkit.org/b/110065 and the image buffer
has been manually scaled (using "zoomedAndScaledContainerRect") instead of relying
on the ImageBuffer's resolutionScale parameter.

Test: svg/as-background-image/tiled-background-image.html

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawPatternForContainer):

Note that fixing the FIXME does not change that the source rect and transform need
to be adjusted for page scale.

LayoutTests:

  • svg/as-background-image/tiled-background-image-expected.html: Added.
  • svg/as-background-image/tiled-background-image.html: Added.
1:20 PM Changeset in webkit [143256] by hyatt@apple.com
  • 7 edits
    8 adds in trunk

Make seamless iframes paginate properly in their enclosing document's pagination context.
https://bugs.webkit.org/show_bug.cgi?id=106125
<rdar://problem/12922720> Text in iframe is clipped while printing

Reviewed by Simon Fraser.

Added new tests in fast/multicol and fast/region.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clampToStartAndEndRegions):
Don't clamp when the RenderView is the containing block of an object in a RenderFlowThread.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containerForRepaint):
Don't attempt any repaint container antics when we're in a seamless iframe, since the ancestor
document will actually do the handoff into the flow thread.

  • rendering/RenderView.cpp:

(WebCore::enclosingSeamlessRenderer):
Heper function to test for an enclosing seamless iframe.

(WebCore::RenderView::addChild):
Subclass addChild on RenderView to properly set the inRenderFlowThread state for a seamless
child document so thta it will check regions.

(WebCore::RenderView::initializeLayoutState):
New helper method for setting up the initial layout state of a RenderView. If inside a seamless
paginated ancestor, set up the appropriate pagination information so the child document
knows about it. This method will expand to inherit info about line grids and exclusions eventually
also.

(WebCore::RenderView::layout):
Now calls initializeLayoutState to set up the layout state.

  • rendering/RenderView.h:

(WebCore::RenderView::pageLogicalHeight):
(WebCore::RenderView::setPageLogicalHeight):
(RenderView):
Fix the type of the page logical height methods to be LayoutUnit instead of unsigned.

LayoutTests:

  • fast/multicol/resources/ipad.jpg: Added.
  • fast/multicol/resources/seamless.html: Added.
  • fast/multicol/seamless-flowed-through-columns-expected.html: Added.
  • fast/multicol/seamless-flowed-through-columns.html: Added.
  • fast/regions/resources/ipad.jpg: Added.
  • fast/regions/resources/seamless.html: Added.
  • fast/regions/seamless-iframe-flowed-into-regions-expected.html: Added.
  • fast/regions/seamless-iframe-flowed-into-regions.html: Added.
12:25 PM Changeset in webkit [143255] by Lucas Forschler
  • 3 edits in tags/Safari-537.31.3/Source/WebKit2

Merged r143111. <rdar://problem/13205468>

12:25 PM Changeset in webkit [143254] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Remove Vector::dataSlot(), it has no implementation
https://bugs.webkit.org/show_bug.cgi?id=109999

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-18
Reviewed by Andreas Kling.

VectorBufferBase does not implement any function bufferSlot().
The file only compiles because that part of the template is never
instantiated.

  • wtf/Vector.h:
12:22 PM Changeset in webkit [143253] by Lucas Forschler
  • 2 edits in tags/Safari-537.31.3/Source/WebKit2

Merged r143091. <rdar://problem/13212621>

12:19 PM Changeset in webkit [143252] by Lucas Forschler
  • 4 edits
    1 copy in tags/Safari-537.31.3

Merged r143074. <rdar://problem/13216100>

12:15 PM Changeset in webkit [143251] by Lucas Forschler
  • 8 edits in tags/Safari-537.31.3/Source/WebCore

Merged r142936. <rdar://problem/13210723>

12:08 PM Changeset in webkit [143250] by Lucas Forschler
  • 2 edits in tags/Safari-537.31.3/Source/WebKit2

Merged r142836. <rdar://problem/13211893>

12:05 PM Changeset in webkit [143249] by Lucas Forschler
  • 1 edit in tags/Safari-537.31.3/Source/WebCore/English.lproj/Localizable.strings

Update localizable strings.

11:29 AM Changeset in webkit [143248] by Christophe Dumez
  • 2 edits in trunk/Source/WTF

Move ENABLE macros for WebCore out from Platform.h
https://bugs.webkit.org/show_bug.cgi?id=105735

Unreviewed, build fix when NETSCAPE_PLUGIN_API is disabled.

Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH even if
NETSCAPE_PLUGIN_API is disabled (Qt, Efl, GTK, WX ports).

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-18

  • wtf/FeatureDefines.h:
11:25 AM Changeset in webkit [143247] by commit-queue@webkit.org
  • 13 edits in trunk/Source

MIPS DFG implementation.
https://bugs.webkit.org/show_bug.cgi?id=101328

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-02-18
Reviewed by Oliver Hunt.

DFG implementation for MIPS.

Source/JavaScriptCore:

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::MIPSAssembler):
(JSC::MIPSAssembler::sllv):
(JSC::MIPSAssembler::movd):
(MIPSAssembler):
(JSC::MIPSAssembler::negd):
(JSC::MIPSAssembler::labelForWatchpoint):
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::vmov):
(JSC::MIPSAssembler::linkDirectJump):
(JSC::MIPSAssembler::maxJumpReplacementSize):
(JSC::MIPSAssembler::revertJumpToMove):
(JSC::MIPSAssembler::replaceWithJump):

  • assembler/MacroAssembler.h:

(MacroAssembler):
(JSC::MacroAssembler::poke):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::add32):
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::lshift32):
(JSC::MacroAssemblerMIPS::mul32):
(JSC::MacroAssemblerMIPS::or32):
(JSC::MacroAssemblerMIPS::rshift32):
(JSC::MacroAssemblerMIPS::urshift32):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::xor32):
(JSC::MacroAssemblerMIPS::store32):
(JSC::MacroAssemblerMIPS::jump):
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchMul32):
(JSC::MacroAssemblerMIPS::branchSub32):
(JSC::MacroAssemblerMIPS::branchNeg32):
(JSC::MacroAssemblerMIPS::call):
(JSC::MacroAssemblerMIPS::loadDouble):
(JSC::MacroAssemblerMIPS::moveDouble):
(JSC::MacroAssemblerMIPS::swapDouble):
(JSC::MacroAssemblerMIPS::subDouble):
(JSC::MacroAssemblerMIPS::mulDouble):
(JSC::MacroAssemblerMIPS::divDouble):
(JSC::MacroAssemblerMIPS::negateDouble):
(JSC::MacroAssemblerMIPS::branchEqual):
(JSC::MacroAssemblerMIPS::branchNotEqual):
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerMIPS::truncateDoubleToInt32):
(JSC::MacroAssemblerMIPS::truncateDoubleToUint32):
(JSC::MacroAssemblerMIPS::branchDoubleNonZero):
(JSC::MacroAssemblerMIPS::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerMIPS::invert):
(JSC::MacroAssemblerMIPS::replaceWithJump):
(JSC::MacroAssemblerMIPS::maxJumpReplacementSize):

  • dfg/DFGAssemblyHelpers.h:

(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::debugCall):

  • dfg/DFGCCallHelpers.h:

(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

  • dfg/DFGFPRInfo.h:

(DFG):
(FPRInfo):
(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::debugName):

  • dfg/DFGGPRInfo.h:

(DFG):
(GPRInfo):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • jit/JSInterfaceJIT.h:

(JSInterfaceJIT):

  • runtime/JSGlobalData.h:

(JSC::ScratchBuffer::allocationSize):
(ScratchBuffer):

Source/WTF:

  • wtf/Platform.h:
11:16 AM Changeset in webkit [143246] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.3/Source

Versioning.

11:13 AM Changeset in webkit [143245] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.3

New Tag.

11:07 AM Changeset in webkit [143244] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r143145.
http://trac.webkit.org/changeset/143145
https://bugs.webkit.org/show_bug.cgi?id=110143

Causes frequent crashes. (Requested by eric_carlson on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18

  • dom/EventDispatchMediator.cpp:

(WebCore::EventDispatchMediator::dispatchEvent):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::ensureEventPath):
(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatchEventPreProcess):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):

  • dom/EventDispatcher.h:

(EventDispatcher):
(WebCore::EventDispatcher::node):
(WebCore):

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

11:01 AM Changeset in webkit [143243] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

[Soup] Free cookies explicitly in loops instead of using GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=110103

Reviewed by Martin Robinson.

Free cookies explicitly in loops instead of using GOwnPtr for this.
Until now, the code was mixing both styles. This patch makes the
code consistent one way. Adopting list items with GOwnPtr for the
sole purpose to free them makes the freeing less obvious and may
lead to mistakes if someone refactors the code and calls "break;"
to abort loop iteration.

No new tests, no behavior change.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):

10:43 AM Changeset in webkit [143242] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

DFG::SpeculativeJIT::isKnownXYZ methods should use CFA rather than other things
https://bugs.webkit.org/show_bug.cgi?id=110092

Reviewed by Geoffrey Garen.

These methods were previously using GenerationInfo and other things to try to
gain information that the CFA could give away for free, if you asked kindly
enough.

Also fixed CallLinkStatus's dump() method since it was making an invalid
assertion: we most certainly can have a status where the structure is non-null
and the executable is null, like if we're dealing with an InternalFunction.

Also removed calls to isKnownNotXYZ from fillSpeculateABC methods in 32_64. I
don't know why that was there. But it was causing asserts if the value was
empty - i.e. we had already exited unconditionally but we didn't know it. I
could have fixed this by introducing another form of isKnownNotXYZ which was
tolerant of empty values, but I didn't feel like fixing code that I knew to be
unnecessary. (More deeply, isKnownNotCell, for example, really asks: "do you
know that this value can never be a cell?" while some of the previous uses
wanted to ask: "do you know that this is a value that is not a cell?". The
former is "true" if the value is a contradiction [i.e. BOTTOM], while the
latter is "false" for contradictions, since contradictions are not values.)

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::dump):

  • bytecode/CallLinkStatus.h:

(JSC::CallLinkStatus::CallLinkStatus):

  • dfg/DFGSpeculativeJIT.cpp:

(DFG):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotInteger):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::isKnownNotCell):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):

  • dfg/DFGStructureAbstractValue.h:

(JSC::DFG::StructureAbstractValue::dump):

10:40 AM Changeset in webkit [143241] by fpizlo@apple.com
  • 11 edits
    3 adds in trunk

Get rid of DFG::DoubleOperand and simplify ValueToInt32
https://bugs.webkit.org/show_bug.cgi?id=110072

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

ValueToInt32 had a side-effecting path, which was not OSR-friendly: an OSR after
the side-effect would lead to the side-effect re-executing. I got rid of that path
and replaced it with an optimization for the case where the input is speculated
number-or-other. This makes idioms like null|0 and true|0 work as expected, and
get optimized appropriately.

Also got rid of DoubleOperand. Replaced all remaining uses of it with
SpeculateDoubleOperand. Because the latter asserts that the Edge is a DoubleUse
edge and the remaining uses of DoubleOperand are all for untyped uses, I worked
around the assertion by setting the UseKind to DoubleUse by force. This is sound,
since all existing assertions for DoubleUse are actually asserting that we're not
converting a value to double unexpectedly. But all of these calls to
SpeculateDoubleOperand are when the operand is already known to be represented as
double, so there is no conversion.

This is neutral on benchmarks, except stanford-crypto-ccm, which speeds up a
little. Mostly, this is intended to delete a bunch of code. DoubleOperand was
equivalent to the replace-edge-with-DoubleUse trick that I'm using now, except it
involved a _lot_ more code.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGSpeculativeJIT.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(DFG):
(FPRTemporary):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(DFG):

LayoutTests:

Reviewed by Geoffrey Garen.

  • fast/js/dfg-value-to-int32-with-side-effect-expected.txt: Added.
  • fast/js/dfg-value-to-int32-with-side-effect.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-value-to-int32-with-side-effect.js: Added.

(foo):
(.result.foo):

10:33 AM Changeset in webkit [143240] by commit-queue@webkit.org
  • 5 edits in trunk

[JSC]: ASSERT in KURL(ParsedURLStringTag) under sourceMapURLForScript
https://bugs.webkit.org/show_bug.cgi?id=109987

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-02-18
Reviewed by Pavel Feldman.

Source/WebCore:

Improved an existing test to cover this.

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::dispatchDidParseSource):
Remove the sourceURL parsing and script.url replacement from the JSC
implementation of ScriptDebugServer. The WebCore inspector code that
this was added for already does this, at a more appropriate time.

LayoutTests:

  • inspector/debugger/source-url-comment-expected.txt:
  • inspector/debugger/source-url-comment.html:

Add a test for a sourceURL with a non-relative path. This was causing
an ASSERT, rightfully so, in JSC builds.

10:21 AM Changeset in webkit [143239] by mkwst@chromium.org
  • 3 edits
    2 adds in trunk

compareDocumentPosition reports disconnected nodes as following each other
https://bugs.webkit.org/show_bug.cgi?id=108274

Reviewed by Dimitri Glazkov.

Source/WebCore:

jQuery has had to implement their own sorting mechanism in Sizzle[1] due
to Node::compareDocumentPosition always reporting disconnected nodes
as following each other. According to spec[2], we should instead be
indicating that the result is (a) disconnected, (b) implementation
specific, and (c) deterministically ordered.

[1]: https://github.com/jquery/sizzle/commit/1c8aec91284af8d8c14447976235d5dd72b0d75e
[2]: http://dom.spec.whatwg.org/#dom-node-comparedocumentposition

Test: fast/dom/compare-document-position-disconnected-nodes.html

  • dom/Node.cpp:

(WebCore::Node::compareDocumentPosition):

After walking the parentNode chain of both Nodes, compare the root.
If the Nodes don't share a root, they're in distinct trees, and
should return as described above. We determine which element
"preceeds" the other in an arbitrary fashion via pointer comparison.

LayoutTests:

  • fast/dom/compare-document-position-disconnected-nodes-expected.txt: Added.
  • fast/dom/compare-document-position-disconnected-nodes.html: Added.
10:06 AM Changeset in webkit [143238] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.
Update test expectations for recent failures.

  • platform/chromium/TestExpectations:
9:45 AM Changeset in webkit [143237] by aandrey@chromium.org
  • 5 edits in trunk

Web Inspector: [Canvas] fix replay log grouping by frames
https://bugs.webkit.org/show_bug.cgi?id=110122

Reviewed by Pavel Feldman.

Source/WebCore:

Bug: log grouping by frames did not work if a frame end call is not a draw call.
Drive-by: Last draw call group may not contain a draw call. In this case merge it into the previous group.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype._appendCallNode):
(WebInspector.CanvasProfileView.prototype._maybeMergeLastDrawCallGroups):

LayoutTests:

Canvas replay test: last command is not a draw call.

  • inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt:
  • inspector/profiler/canvas2d/canvas-replay-log-grid.html:
9:42 AM Changeset in webkit [143236] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.
Fix test expectations for effect-reference* tests which I messed up
in my last commit.

  • platform/chromium/TestExpectations:
9:33 AM Changeset in webkit [143235] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Mountain Lion buildfix after r143147.

Reviewed by Csaba Osztrogonác.

  • runtime/DateConstructor.cpp:
9:19 AM Changeset in webkit [143234] by sergio@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Moved WK1 specific failures from the shared TestExpectations file
to the wk1 one. Also removed some tests from the WK2
TestExpectations file as they have been consistently passing on
bots.

  • platform/gtk-wk1/TestExpectations:
  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
9:19 AM Changeset in webkit [143233] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

[Soup] Superfluous HashMap check in SocketStreamHandleSoup::getHandleFromId()
https://bugs.webkit.org/show_bug.cgi?id=110107

Reviewed by Martin Robinson.

Remove Superfluous HashMap::contains() call in SocketStreamHandleSoup::getHandleFromId()
as HashMap::get() will already return 0 in this case anyway.

No new tests, no behavior change.

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore):
(WebCore::getHandleFromId):

9:13 AM Changeset in webkit [143232] by zandobersek@gmail.com
  • 66 edits in trunk/Source

Stop placing std::isfinite and std::signbit inside the global scope
https://bugs.webkit.org/show_bug.cgi?id=109817

Reviewed by Darin Adler.

Prefix calls to the isfinite and signbit methods with std:: as the two
methods are no longer being imported into the global scope.

Source/JavaScriptCore:

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlindDouble):

  • offlineasm/cloop.rb:
  • runtime/BigInteger.h:

(JSC::BigInteger::BigInteger):

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • runtime/DatePrototype.cpp:

(JSC::fillStructuresUsingTimeArgs):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncSetYear):

  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::JSValue):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncIsFinite):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):

  • runtime/MathObject.cpp:

(JSC::mathProtoFuncMax): Also include an opportunistic style fix.
(JSC::mathProtoFuncMin): Ditto.

  • runtime/NumberPrototype.cpp:

(JSC::toStringWithRadix):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):

  • runtime/Uint16WithFraction.h:

(JSC::Uint16WithFraction::Uint16WithFraction):

Source/WebCore:

No new tests as there's no change in functionality.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::JSCanvasRenderingContext2D::setWebkitLineDash):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::jsDateOrNull):

  • bindings/js/JSDOMBinding.h:

(WebCore::finiteInt32Value):

  • bindings/v8/V8Binding.h:

(WebCore::v8DateOrNull):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::parseToNumber):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValueAsNumber):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::setMin):
(WebCore::HTMLMeterElement::setMax):
(WebCore::HTMLMeterElement::setValue):
(WebCore::HTMLMeterElement::setLow):
(WebCore::HTMLMeterElement::setHigh):
(WebCore::HTMLMeterElement::setOptimum):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::value):
(WebCore::HTMLProgressElement::setValue):
(WebCore::HTMLProgressElement::max):
(WebCore::HTMLProgressElement::setMax):

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::valueAsDate):
(WebCore::MonthInputType::defaultValueForStepUp):
(WebCore::MonthInputType::parseToNumber):

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::typeMismatchFor):
(WebCore::NumberInputType::sanitizeValue):
(WebCore::NumberInputType::hasBadInput):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::typeMismatchFor):

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::defaultValueForStepUp):

  • html/canvas/CanvasPathMethods.cpp:

(WebCore::CanvasPathMethods::moveTo):
(WebCore::CanvasPathMethods::lineTo):
(WebCore::CanvasPathMethods::quadraticCurveTo):
(WebCore::CanvasPathMethods::bezierCurveTo):
(WebCore::CanvasPathMethods::arcTo):
(WebCore::CanvasPathMethods::arc):
(WebCore::CanvasPathMethods::rect):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setLineWidth):
(WebCore::CanvasRenderingContext2D::setMiterLimit):
(WebCore::CanvasRenderingContext2D::setShadowOffsetX):
(WebCore::CanvasRenderingContext2D::setShadowOffsetY):
(WebCore::CanvasRenderingContext2D::setShadowBlur):
(WebCore::lineDashSequenceIsValid):
(WebCore::CanvasRenderingContext2D::setLineDashOffset):
(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
(WebCore::validateRectForCanvas):
(WebCore::CanvasRenderingContext2D::isPointInPath):
(WebCore::CanvasRenderingContext2D::isPointInStroke):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::createLinearGradient):
(WebCore::CanvasRenderingContext2D::createRadialGradient):
(WebCore::CanvasRenderingContext2D::createImageData):
(WebCore::CanvasRenderingContext2D::getImageData):
(WebCore::CanvasRenderingContext2D::putImageData):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseToDoubleForNumberType):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTimelineElement::setDuration):

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::reset):

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::reset):

  • html/shadow/MediaControlsBlackBerry.cpp:

(WebCore::MediaControlFullscreenTimelineElement::setDuration):
(WebCore::MediaControlsBlackBerry::reset):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorBasicValue::writeJSON):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::currentAge):
(WebCore::CachedResource::freshnessLifetime):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

  • platform/DateComponents.cpp:

(WebCore::DateComponents::setMillisecondsSinceEpochForDate):
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTime):
(WebCore::DateComponents::setMillisecondsSinceEpochForMonth):
(WebCore::DateComponents::setMillisecondsSinceMidnight):
(WebCore::DateComponents::setMonthsSinceEpoch):
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):

  • platform/Decimal.cpp:

(WebCore::Decimal::fromDouble):

  • platform/FileSystem.h:

(WebCore::isValidFileTime):

  • platform/LocalizedStrings.cpp:

(WebCore::localizedMediaTimeDescription):

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::drawPatternToCairoContext):

  • platform/graphics/cairo/PathCairo.cpp:

(WebCore::Path::addArc):
(WebCore::Path::contains):

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::addArc):

  • platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp:

(WebCore::FullscreenVideoControllerGStreamer::timeToString):

  • platform/graphics/openvg/PathOpenVG.cpp:

(WebCore::Path::addArc):

  • platform/graphics/skia/SkiaUtils.h:

(WebCore::WebCoreFloatToSkScalar):
(WebCore::WebCoreDoubleToSkScalar):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::maxTimeSeekable):

  • platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::localizedMediaTimeDescription):

  • platform/mac/WebVideoFullscreenHUDWindowController.mm:

(timeToString):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::parseDateValueInHeader):

  • platform/qt/LocalizedStringsQt.cpp:

(WebCore::localizedMediaTimeDescription):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::resolveFlexibleLengths):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::formatChromiumMediaControlsTime):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::formatMediaControlsTime):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setFontSize):

  • svg/SVGPathParser.cpp:

(WebCore::SVGPathParser::decomposeArcToCubic):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunRound::round):

  • xml/XPathValue.cpp:

(WebCore::XPath::Value::toString):

Source/WebKit/win:

  • FullscreenVideoController.cpp:

(timeToString):

Source/WTF:

On Solaris and OpenBSD platforms or when using Visual C++ the two methods
are now defined (as incompatibility workarounds) inside the std namespace.

  • wtf/DateMath.cpp:

(WTF::timeClip):

  • wtf/DecimalNumber.h:

(WTF::DecimalNumber::DecimalNumber):

  • wtf/MathExtras.h:

(std):
(std::isfinite):
(std::signbit):
(lrint):
(wtf_pow):
(decomposeDouble):

  • wtf/MediaTime.cpp:

(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):

  • wtf/dtoa.cpp:

(WTF::dtoa):

9:08 AM Changeset in webkit [143231] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Mountain Lion buildfix after r143147.

Reviewed by Csaba Osztrogonác.

  • runtime/DateInstance.cpp:
9:06 AM Changeset in webkit [143230] by Chris Fleizach
  • 3 edits
    2 moves in trunk/Source/WebCore

AX: Make iOS wrapper use the WebAccessibilityObjectBase wrapper
https://bugs.webkit.org/show_bug.cgi?id=110077

Reviewed by David Kilzer.

Make the iOS wrapper a subclass of the shared wrapper so that iOS can re-use code from the Mac.
Rename the iOS file to reflect the class name.

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/ios/AccessibilityObjectWrapperIOS.h: Removed.
  • accessibility/ios/AccessibilityObjectWrapperIOS.mm: Removed.
  • accessibility/ios/WebAccessibilityObjectWrapperIOS.h: Copied from Source/WebCore/accessibility/ios/AccessibilityObjectWrapperIOS.h.
  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: Copied from Source/WebCore/accessibility/ios/AccessibilityObjectWrapperIOS.mm.

(-[WebAccessibilityObjectWrapper initWithAccessibilityObject:]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:WebCore::AXObjectCache::]):

9:06 AM Changeset in webkit [143229] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed GTK gardening.

  • Scripts/run-gtk-tests:

(TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.

9:04 AM Changeset in webkit [143228] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r143210.
http://trac.webkit.org/changeset/143210
https://bugs.webkit.org/show_bug.cgi?id=110128

Still causing some test timeouts (Requested by anttik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18

  • platform/SharedTimer.h:

(SharedTimer):
(WebCore):
(WebCore::MainThreadSharedTimer::stop):

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::fireTimersInNestedEventLoop):

  • platform/mac/SharedTimerMac.mm:

(WebCore):
(WebCore::PowerObserver::restartSharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

8:54 AM Changeset in webkit [143227] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Disable hiding the debugger when it is below the source code
https://bugs.webkit.org/show_bug.cgi?id=110106

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-18
Reviewed by Pavel Feldman.

When the "Split horizontally" option is checked in the Sources panel the button responsible for the sidebar
visibility is hidden and the sidebar is force-shown. Also set the "Split sidebar" option default to true.

No new tests.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

  • inspector/front-end/scriptsPanel.css:

(.split-view-horizontal #scripts-debug-sidebar-resizer-widget):

8:49 AM Changeset in webkit [143226] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

pinch-zooming webpage messes up full-screening of embedded video
https://bugs.webkit.org/show_bug.cgi?id=106115

Reviewed by Maciej Stachowiak.

Reset the page scale when entering full screen, and reset to the original scale when exiting.

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

8:48 AM Changeset in webkit [143225] by betravis@adobe.com
  • 6 edits
    2 adds in trunk

[CSS Exclusions] Support outside-shape layout for shape-inside property
https://bugs.webkit.org/show_bug.cgi?id=102571

Reviewed by David Hyatt.

Source/WebCore:

A shape-inside value of 'outside-shape' should resolve to the value of
the shape-outside property for layout. This patch introduces a helper
method to resolve shape-inside in RenderStyle, and replaces calls to
RenderStyle::shapeInside() when the resolved (layout) value should be
used.

Test: fast/exclusions/shape-inside/shape-inside-outside-shape.html

  • rendering/ExclusionShapeInfo.cpp:

(WebCore::::computedShape): Use the resolved shape-inside getter.

  • rendering/ExclusionShapeInsideInfo.h:

(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Ditto.
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Ditto.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange): Ditto.
(WebCore::RenderBlock::exclusionShapeInsideInfo): Ditto.

  • rendering/style/RenderStyle.h: Add the resolved shape inside getter.

LayoutTests:

Test that the shape-outside value correctly propagates to shape-inside
when shape-inside has a value of 'outside-shape,' using both an
undefined and a simple shape outside value.

  • fast/exclusions/shape-inside/shape-inside-outside-shape-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-outside-shape.html: Added.
8:41 AM Changeset in webkit [143224] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: hide vertical-sidebar-split in dock-to-right mode behind single experimental flag.
https://bugs.webkit.org/show_bug.cgi?id=110119

Reviewed by Vsevolod Vlasov.

Removed context menus, made it toggle automatically upon dock orientation change.

  • inspector/front-end/DockController.js:

(WebInspector.DockController.prototype._toggleDockState):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._sidebarContextMenuEventFired):
(WebInspector.ElementsPanel.prototype._dockSideChanged):
(WebInspector.ElementsPanel.prototype._setVerticalSplit):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._dockSideChanged):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/inspector.css:
  • inspector/front-end/scriptsPanel.css:

(#scripts-sidebar-stack-pane):
(div.sidebar-pane-stack#scripts-debug-sidebar-contents):

  • inspector/front-end/tabbedPane.css:

(.tabbed-pane):

8:34 AM Changeset in webkit [143223] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Fix nits for configuration
https://bugs.webkit.org/show_bug.cgi?id=110083

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-18
Reviewed by Martin Robinson.

.:

Remove unicode backend printing option. The only backend for unicode is icu
after changeset 142724.

  • Source/autotools/PrintBuildConfiguration.m4:

Source/WebCore:

Remove trailing white space. It has caused annoying warning while configuration.

No new tests since no funtionality change.

  • GNUmakefile.list.am:
8:29 AM Changeset in webkit [143222] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adjusting failure expectation for an inspector

test which now times out.

8:17 AM Changeset in webkit [143221] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt][WK2] Remove duped test name and append new test in project file
https://bugs.webkit.org/show_bug.cgi?id=110117

A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
add this test into the runnable test suite and remove a duped test in project file.

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-18
Reviewed by Jocelyn Turcotte.

  • TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
8:15 AM Changeset in webkit [143220] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebCore

[WebGL][EFL] Refactor GraphicsContext3DPrivate to add support for SharedContext.
https://bugs.webkit.org/show_bug.cgi?id=109988

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-18
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This patch refactors PlatformContext and GraphicsContext3DPrivate to
add support for Shared Context. This would help share GL resources
between transport surface and offscreen surface without having to worry
about the context state. So far, we used the same drawable as transport
surface and offscreen surface. After this patch we use pixmap surface as
offscreen surface and use shared context to render texture content to
transport surface. This would also align as to how shared surface is implemented
on EFL and Qt ports.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::makeSharedContextCurrent):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

  • platform/graphics/opengl/GLPlatformContext.cpp:

(WebCore::GLPlatformContext::initialize):

  • platform/graphics/opengl/GLPlatformContext.h:

Needed changes to take shared context into use.

  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::createOffScreenSurface):
(WebCore::GLPlatformSurface::updateContents):

  • platform/graphics/opengl/GLPlatformSurface.h:

(GLPlatformSurface):

  • platform/graphics/surfaces/glx/GLXConfigSelector.h:

(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pixmapContextConfig):
(GLXConfigSelector):
(WebCore::GLXConfigSelector::reset):

  • platform/graphics/surfaces/glx/GLXContext.cpp:

Added support to query configiration supporting
pixmap surface.

(WebCore::GLXOffScreenContext::initialize):

  • platform/graphics/surfaces/glx/GLXContext.h:

(GLXOffScreenContext):

  • platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::swapBuffers):
(WebCore::GLXOffScreenSurface::GLXOffScreenSurface):
(WebCore::GLXOffScreenSurface::~GLXOffScreenSurface):
(WebCore::GLXOffScreenSurface::initialize):
(WebCore::GLXOffScreenSurface::configuration):
(WebCore::GLXOffScreenSurface::destroy):
(WebCore::GLXOffScreenSurface::freeResources):
(WebCore::GLXOffScreenSurface::setGeometry):
Renamed GLXPBuffer surface as GLXOffScreenSurface.

  • platform/graphics/surfaces/glx/GLXSurface.h:

(GLXTransportSurface):
(GLXOffScreenSurface):

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::createSurface):

  • platform/graphics/surfaces/glx/X11Helper.cpp:

(WebCore::X11Helper::createPixmap):
(WebCore):
(WebCore::X11Helper::destroyPixmap):
(WebCore::X11Helper::createOffScreenWindow):

  • platform/graphics/surfaces/glx/X11Helper.h:

(X11Helper):
Added functions to create and destroy pixmap.

8:14 AM Changeset in webkit [143219] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Add Digia to the domain affiliations
https://bugs.webkit.org/show_bug.cgi?id=110116

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2013-02-18
Reviewed by Kenneth Rohde Christiansen.

  • team.html:
7:46 AM Changeset in webkit [143218] by loislo@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: Generate meta information for HeapSnapshot parser.
https://bugs.webkit.org/show_bug.cgi?id=110104

Reviewed by Yury Semikhatsky.

The format of Native heap snapshot is slightly different so it should provide its own meta information.

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::finish):
(WebCore::HeapGraphSerializer::reportMemoryUsage):
(WebCore::HeapGraphSerializer::registerTypeString):
(WebCore):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):

  • inspector/Inspector.json:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

  • inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):

  • inspector/front-end/NativeHeapSnapshot.js:

(WebInspector.NativeHeapSnapshot):

7:40 AM Changeset in webkit [143217] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r183105. Requested by
thakis_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18

  • DEPS:
7:33 AM Changeset in webkit [143216] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove ahem_path from WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=110111

Reviewed by Jochen Eisinger.

It's only used in DumpRenderTree.gyp, and that file defines its own
copy of this variable.

  • WebKit.gyp:
7:32 AM Changeset in webkit [143215] by betravis@adobe.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed. Add myself to committers list.

7:32 AM Changeset in webkit [143214] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark perf/show-hide-table-rows.html as sometimes failing or slow
on EFL port.

  • platform/efl/TestExpectations:
6:47 AM Changeset in webkit [143213] by jochen@chromium.org
  • 2 edits in trunk/Tools

[chromium] remove log spew from dumpAllBackForwardLists
https://bugs.webkit.org/show_bug.cgi?id=110108

Reviewed by Nico Weber.

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
6:45 AM Changeset in webkit [143212] by Carlos Garcia Campos
  • 18 edits in trunk/Source/WebCore

[GTK] Force single header includes in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=104676

Reviewed by Xan Lopez.

Only including <webkitdom/webkitdom.h> should be allowed from
apps.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateHeader):

  • bindings/scripts/gobject-generate-headers.pl:
  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
  • bindings/scripts/test/GObject/WebKitDOMTestException.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNode.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
6:35 AM Changeset in webkit [143211] by commit-queue@webkit.org
  • 10 edits
    1 add in trunk/Source

Move ENABLE macros for WebCore out from Platform.h
https://bugs.webkit.org/show_bug.cgi?id=105735

Source/WebKit/chromium:

Move the chromium specific WebCore ENABLE macro definitions
from Platform.h to features.gypi.

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-18
Reviewed by Darin Adler and Benjamin Poulain.

  • features.gypi: Set ENABLE_SUBPIXEL_LAYOUT to 1.

Source/WTF:

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-18
Reviewed by Darin Adler and Benjamin Poulain.

Introduce FeatureDefines.h by combining the existing rules from
Platform.h and adding new rules for all the ENABLE flags that are
listed in the FeatureFlags wiki.

The new rules are not used at the moment by any ports
as the port specific build systems already define these flags
so the !defined() guard will prevent redefinition of the macros.

  • GNUmakefile.list.am: Add FeatureDefines.h.
  • WTF.gypi: Ditto.
  • WTF.pro: Ditto.
  • WTF.vcproj/WTF.vcproj: Ditto.
  • WTF.xcodeproj/project.pbxproj: Ditto.
  • wtf/CMakeLists.txt: Ditto.
  • wtf/FeatureDefines.h: Added.
  • wtf/Platform.h: Move macro definitions to FeatureDefines.h.
6:28 AM Changeset in webkit [143210] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Reschedule shared CFRunLoopTimer instead of reconstructing it
https://bugs.webkit.org/show_bug.cgi?id=109765

Reviewed by Andreas Kling.

Using CFRunLoopTimerSetNextFireDate is over 2x faster than deleting and reconstructing timers.

  • platform/SharedTimer.h:

(WebCore::SharedTimer::willEnterNestedEventLoop):
(WebCore):
(MainThreadSharedTimer):
(WebCore::MainThreadSharedTimer::willEnterNestedEventLoop):

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::fireTimersInNestedEventLoop):

  • platform/mac/SharedTimerMac.mm:

(WebCore):
(WebCore::PowerObserver::clearSharedTimer):
(WebCore::ensurePowerObserver):
(WebCore::sharedTimer):
(WebCore::reinsertSharedTimer):

Before entering nested runloop (used for inspector debugger mostly) reconstruct and reinsert the timer. For some reason
the timer doesn't fire otherwise.

(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

6:10 AM Changeset in webkit [143209] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Resources] Only remember the tree element selection if explicitly made by user
https://bugs.webkit.org/show_bug.cgi?id=110105

Reviewed by Pavel Feldman.

This change instructs the Resources panel to remember the selected tree element only if it has been
selected by the user (not automatically, like selecting a parent when its child is removed).
All onselect() overrides pass the selectedByUser argument value
to BaseStorageTreeElement.prototype.onselect.
Drive-by: Use === comparisons everywhere.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype._reset): Do not detach [immutable] category views.
(WebInspector.BaseStorageTreeElement.prototype.onselect): Remember itemURL on user gesture only.
(WebInspector.StorageCategoryTreeElement.prototype.onselect):
(WebInspector.FrameTreeElement.prototype.onselect):
(WebInspector.FrameResourceTreeElement.prototype.onselect):
(WebInspector.DatabaseTreeElement.prototype.onselect):
(WebInspector.DatabaseTableTreeElement.prototype.onselect):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement.prototype.onselect):
(WebInspector.IDBIndexTreeElement.prototype.onselect):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.onselect):
(WebInspector.CookieTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.onselect):
(WebInspector.FileSystemTreeElement.prototype.onselect):
(WebInspector.FileSystemTreeElement.prototype.clear):
(WebInspector.ResourcesSearchController.prototype.nextSearchResult):

6:03 AM Changeset in webkit [143208] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark fast/dom/shadow/shadow-dom-event-dispatching-distributed-child.html as
failing on EFL port. The test was introduced in r143191.

  • platform/efl/TestExpectations:
6:01 AM Changeset in webkit [143207] by commit-queue@webkit.org
  • 4 edits in trunk

Web Inspector: Color picker should not be available in Computed Styles pane
https://bugs.webkit.org/show_bug.cgi?id=109697

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-18
Reviewed by Pavel Feldman.

Source/WebCore:

Refactored PropertiesSection and TreeElement inheritors in StylesSidebarPane.js for cleaner separation
of read-only and editable properties.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.BlankStylePropertiesSection):
(WebInspector.StylePropertyTreeElementBase):
(WebInspector.StylePropertyTreeElementBase.prototype.node):
(WebInspector.StylePropertyTreeElementBase.prototype.editablePane):
(WebInspector.StylePropertyTreeElementBase.prototype.onattach):
(WebInspector.StylePropertyTreeElementBase.prototype.updateTitle.linkifyURL):
(WebInspector.StylePropertyTreeElementBase.prototype.updateTitle.):
(WebInspector.StylePropertyTreeElementBase.prototype):
(.event):
(.isRevert):

LayoutTests:

  • inspector/styles/undo-add-property.html:
5:45 AM Changeset in webkit [143206] by aandrey@chromium.org
  • 9 edits in trunk

Web Inspector: [Canvas] group replay log calls by frames
https://bugs.webkit.org/show_bug.cgi?id=110101

Reviewed by Pavel Feldman.

Source/WebCore:

Group canvas replay log by frames, then by draw calls.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype._appendCallNode):
(WebInspector.CanvasProfileView.prototype._appendDrawCallGroup):

LayoutTests:

  • inspector/profiler/canvas-profiler-test.js:
  • inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt:
  • inspector/profiler/canvas2d/canvas-replay-log-grid.html:
  • inspector/profiler/canvas2d/canvas-stack-trace-expected.txt:
5:35 AM Changeset in webkit [143205] by kadam@inf.u-szeged.hu
  • 1 edit
    1 delete in trunk/LayoutTests

[Qt] Deleted extraneous file. It has been added accidentally in r142135.
https://bugs.webkit.org/show_bug.cgi?id=109953.

  • platform/qt-5.0-wk2/TestExpectations.orig: Removed.
5:29 AM Changeset in webkit [143204] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

[Soup] CookieJarSoup::deleteCookie() should stop looking for the cookie after it is removed
https://bugs.webkit.org/show_bug.cgi?id=110100

Reviewed by Kenneth Rohde Christiansen.

CookieJarSoup::deleteCookie() retrieves the list of cookies that apply to a given URL, then
iterates through the cookies to find the one with the right name and delete it. However, the
current implementation keeps on comparing cookie names after the cookie was removed. This
patch introduces a "wasDeleted" boolean to stop comparing cookie names after the cookie was
deleted. Note that we cannot break as soon as the cookie is found as we need to keep iterating
so that the cookies get freed by GOwnPtr.

No new tests, no behavior change.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::deleteCookie):

5:26 AM Changeset in webkit [143203] by Christophe Dumez
  • 4 edits in trunk

[EFL][WK2] Disable failing API tests
https://bugs.webkit.org/show_bug.cgi?id=110081

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Disable EWK2UnitTestBase.ewk_view_scale API test as it is failing.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

Tools:

Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.

  • TestWebKitAPI/PlatformEfl.cmake:
5:26 AM Changeset in webkit [143202] by vsevik@chromium.org
  • 10 edits in trunk

Web Inspector: Create separate project for each domain for UISourceCode based on browser resources.
https://bugs.webkit.org/show_bug.cgi?id=109691

Reviewed by Pavel Feldman.

Source/WebCore:

Separate project of certain type is now created for each domain.
UISourceCode path represents a path in the project now.
UISourceCode uri is now calculated based on project id and path.
It is also possible to calculate path based on projectId and URI, which is used for uiSourceCodeForURI() methods.

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate.prototype._filePathForPath):
(WebInspector.FileSystemProjectDelegate.prototype.setFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype._populate):
(WebInspector.FileSystemProjectDelegate.prototype._removeFile):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.projectId):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.splitURL):
(WebInspector.SimpleWorkspaceProvider._pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._projectDelegate):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFile):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.uri):
(WebInspector.UISourceCode.path):
(WebInspector.UISourceCode.prototype.uri):

  • inspector/front-end/Workspace.js:

(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCodeForURI):

LayoutTests:

  • inspector/debugger/live-edit-breakpoints-expected.txt:
  • inspector/debugger/live-edit-breakpoints.html:
  • inspector/uisourcecode-revisions.html:
5:21 AM Changeset in webkit [143201] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Disable the build if certain configure checks fail
https://bugs.webkit.org/show_bug.cgi?id=110094

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2013-02-18
Reviewed by Tor Arne Vestbø.

Allow for the build to be skipped (clear out SUBDIRS) if certain
configure conditions aren't met.

  • qmake/mkspecs/features/configure.prf:
5:20 AM Changeset in webkit [143200] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

[EFL] Fix build when CONTEXT_MENUS flag is turned off
https://bugs.webkit.org/show_bug.cgi?id=109924

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-02-18
Reviewed by Gyuyoung Kim.

  • WebCoreSupport/ContextMenuClientEfl.cpp:
  • WebCoreSupport/ContextMenuClientEfl.h:
  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(ewk_view_context_menu_get):

5:12 AM Changeset in webkit [143199] by zarvai@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/TestExpectations: Skip test after r143073.
  • platform/qt/css3/filters/effect-reference-expected.png: Rebaseline after r143101.
  • platform/qt/css3/filters/effect-reference-expected.txt: Rebaseline after r143101.
5:06 AM Changeset in webkit [143198] by gyuyoung.kim@samsung.com
  • 22 edits in trunk

[EFL] Rebaseline failure media tests after r142947
https://bugs.webkit.org/show_bug.cgi?id=109904

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

  • css/mediaControlsEfl.css: Align time text vertically.

(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):

LayoutTests:

  • platform/efl/TestExpectations:
  • platform/efl/media/audio-controls-rendering-expected.png:
  • platform/efl/media/audio-controls-rendering-expected.txt:
  • platform/efl/media/controls-after-reload-expected.png:
  • platform/efl/media/controls-after-reload-expected.txt:
  • platform/efl/media/controls-strict-expected.png:
  • platform/efl/media/controls-strict-expected.txt:
  • platform/efl/media/controls-styling-expected.png:
  • platform/efl/media/controls-styling-expected.txt:
  • platform/efl/media/controls-styling-strict-expected.png:
  • platform/efl/media/controls-styling-strict-expected.txt:
  • platform/efl/media/controls-without-preload-expected.png:
  • platform/efl/media/controls-without-preload-expected.txt:
  • platform/efl/media/video-controls-rendering-expected.png:
  • platform/efl/media/video-controls-rendering-expected.txt:
  • platform/efl/media/video-display-toggle-expected.png:
  • platform/efl/media/video-display-toggle-expected.txt:
  • platform/efl/media/video-playing-and-pause-expected.png:
  • platform/efl/media/video-playing-and-pause-expected.txt:
5:00 AM Changeset in webkit [143197] by allan.jensen@digia.com
  • 9 edits
    6 adds in trunk

[Qt][WK2] Support WK2 API tests
https://bugs.webkit.org/show_bug.cgi?id=109843

Reviewed by Jocelyn Turcotte.

Source/WebKit2:

  • UIProcess/API/qt/qquickwebview_p.h:

(TestWebKitAPI):

Tools:

  • TestWebKitAPI/DerivedSources.pri: Added.
  • TestWebKitAPI/InjectedBundle.pri: Added.
  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/TestWebKitAPI.pri:
  • TestWebKitAPI/TestWebKitAPI.pro:
  • TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
  • TestWebKitAPI/Tests/WTF/WTF.pro:
  • TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
  • TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:

(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::isKeyDown):
(Util):

  • TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.

(TestWebKitAPI):
(WrapperWindow):
(TestWebKitAPI::WrapperWindow::WrapperWindow):
(TestWebKitAPI::WrapperWindow::handleStatusChanged):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::focus):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
(TestWebKitAPI::PlatformWebView::simulateRightClick):

  • TestWebKitAPI/qt/main.cpp:

(addQtWebProcessToPath):
(main):

4:56 AM Changeset in webkit [143196] by vsevik@chromium.org
  • 9 edits
    1 move
    1 add in trunk/Source/WebCore

Web Inspector: Extract FileSystemUtils from FileSystemProjectDelegate as IsolatedFileSystem class.
https://bugs.webkit.org/show_bug.cgi?id=110086

Reviewed by Pavel Feldman.

Extracted IsolatedFileSystem class that could be mocked for tests now.
Renamed IsolatedFileSystemModel to IsolatedFileSystemManager.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.id):
(WebInspector.FileSystemProjectDelegate.prototype.displayName):
(WebInspector.FileSystemProjectDelegate.prototype.setFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype._populate):

  • inspector/front-end/IsolatedFileSystem.js: Added.

(WebInspector.IsolatedFileSystem):
(WebInspector.IsolatedFileSystem.errorMessage):
(WebInspector.IsolatedFileSystem.prototype.id):
(WebInspector.IsolatedFileSystem.prototype.path):
(WebInspector.IsolatedFileSystem.prototype._requestFileSystem):
(WebInspector.IsolatedFileSystem.prototype.fileSystemLoaded):
(WebInspector.IsolatedFileSystem.prototype.innerCallback):
(WebInspector.IsolatedFileSystem.prototype.requestFilesRecursive):
(WebInspector.IsolatedFileSystem.prototype.fileEntryLoaded):
(WebInspector.IsolatedFileSystem.prototype.fileLoaded):
(WebInspector.IsolatedFileSystem.prototype.readerLoadEnd):
(WebInspector.IsolatedFileSystem.prototype.errorHandler):
(WebInspector.IsolatedFileSystem.prototype.requestFileContent):
(WebInspector.IsolatedFileSystem.prototype.fileWriterCreated.fileTruncated):
(WebInspector.IsolatedFileSystem.prototype.fileWriterCreated):
(WebInspector.IsolatedFileSystem.prototype.writerEnd):
(WebInspector.IsolatedFileSystem.prototype.setFileContent):
(WebInspector.IsolatedFileSystem.prototype.):
(WebInspector.IsolatedFileSystem.prototype.toArray):
(WebInspector.IsolatedFileSystem.prototype._readDirectory):
(WebInspector.IsolatedFileSystem.prototype._requestEntries):

  • inspector/front-end/IsolatedFileSystemManager.js: Renamed from Source/WebCore/inspector/front-end/IsolatedFileSystemModel.js.

(WebInspector.IsolatedFileSystemManager):
(WebInspector.IsolatedFileSystemManager.prototype.mapping):
(WebInspector.IsolatedFileSystemManager.prototype.supportsFileSystems):
(WebInspector.IsolatedFileSystemManager.prototype._requestFileSystems):
(WebInspector.IsolatedFileSystemManager.prototype.addFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype.removeFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemsLoaded):
(WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemPaths):
(WebInspector.IsolatedFileSystemManager.prototype._processPendingFileSystemRequests):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemAdded):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):
(WebInspector.IsolatedFileSystemManager.prototype._isolatedFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype.requestDOMFileSystem):
(WebInspector.IsolatedFileSystemDispatcher):
(WebInspector.IsolatedFileSystemDispatcher.prototype.fileSystemsLoaded):
(WebInspector.IsolatedFileSystemDispatcher.prototype.fileSystemRemoved):
(WebInspector.IsolatedFileSystemDispatcher.prototype.fileSystemAdded):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.WorkspaceSettingsTab.prototype._createFileSystemsEditor):
(WebInspector.WorkspaceSettingsTab.prototype._addFileSystemRow.removeFileSystemClicked):
(WebInspector.WorkspaceSettingsTab.prototype._addFileSystemClicked):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:
4:54 AM Changeset in webkit [143195] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Changing WebView.contentY and WebView.contentX does not redraw content
https://bugs.webkit.org/show_bug.cgi?id=108337

Reviewed by Jocelyn Turcotte.

We should not ignore content position changes unless pinch zoom or bounce-back
animation is ongoing.
This way we notify the web process about visible rect changes if the contentX
and contentY properties are used to programmatically scroll the content from QML.
One important usecase for this is when implementing scrollbars.

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::pageItemPositionChanged):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):

4:11 AM Changeset in webkit [143194] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][WK2] compositing/layer-creation/fixed-position-out-of-view-scaled.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=110059

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-18
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Remove the ASSERT check in TextureMapperLayer. This assertion seems
valid because CoordinatedGraphicsScene::adjustPositionForFixedLayers() calls
TextureMapperLayer::setScrollPositionDeltaIfNeeded() when the graphics
layer is a fixed position layer. However, the assertion can be failed
because it is possible that TextureMapperLayer is a non-fixed position
layer when the graphics layer that holds the TextureMapperLayer is a
fixed position layer. When CoordinatedGraphicsScene flushes,
TextureMapperLayer becomes a fixed position layer.

No new tests. No change in behavior.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):

LayoutTests:

Unskip two tests on EFL port. Now those pass.
compositing/layer-creation/fixed-position-out-of-view-scaled.html
compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html

  • platform/efl-wk2/TestExpectations:
3:45 AM Changeset in webkit [143193] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip several webgl/conformance tests that started passing after
r142854.

  • platform/efl-wk2/TestExpectations:
3:33 AM Changeset in webkit [143192] by g.czajkowski@samsung.com
  • 8 edits in trunk/Source

[WK2][EFL] Unified text checker implementation
https://bugs.webkit.org/show_bug.cgi?id=107682

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests, covered by editing/spelling tests.

  • platform/text/TextChecking.h:

(WebCore):
Enabling unified text checker feature for WebKit-EFL.

Source/WebKit/efl:

Add an empty checkTextOfParagraph implementation for WK1-EFL
to do not break build when WTF_USE_UNIFIED_TEXT_CHECKING
is enabled.

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):
(WebCore::EditorClientEfl::checkTextOfParagraph):

Source/WebKit2:

  • UIProcess/efl/TextCheckerEfl.cpp:

(WebKit):
(WebKit::nextWordOffset):
Helper function to determine the word offset to do not call
client's checkSpellingOfString for the word separators.

(WebKit::TextChecker::checkTextOfParagraph):
Allow to check spelling for multiple words,
their misspelling location and length are saved to the vector.

  • WebProcess/WebCoreSupport/WebEditorClient.h:

Add UNIFIED_TEXT_CHECKING guard to checkTextOfParagraph.

  • WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:

(WebKit):
(WebKit::WebEditorClient::checkTextOfParagraph):
As spelling implementation is exposed to UIProcess,
send a meesage to UIProcess to call TextChecker::checkTextOfParagraph.

3:26 AM Changeset in webkit [143191] by mkwst@chromium.org
  • 2 edits
    25 adds
    2 deletes in trunk/LayoutTests

fast/dom/shadow/shadow-dom-event-dispatching.html flake
https://bugs.webkit.org/show_bug.cgi?id=103299

Reviewed by Jochen Eisinger.

This patch breaks fast/dom/shadow/shadow-dom-event-dispatching.html out
into 12 separate tests to avoid timeouts. Common logic for all these
dispatching tests is now in resources/event-dispatching.js, and each
individual test function now runs in its own HTML file.

  • fast/dom/shadow/resources/event-dispatching.js: Added.

(moveMouseOver):
(recordEvent):
(dumpNode):
(dumpComposedShadowTree):
(addEventListeners):
(debugDispatchedEvent):
(moveMouse):
(showSandboxTree):

  • fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content.html: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-details-summary-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-details-summary.html: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-distributed-child-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-distributed-child.html: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes.html: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target.html: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-manually-fired.html: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-multiple-shadow-roots-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-multiple-shadow-roots.html: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots.html: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes.html: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree.html: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root.html: Added.

New tests!

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt: Removed.
  • fast/dom/shadow/shadow-dom-event-dispatching.html: Removed.
  • platform/chromium/TestExpectations:

Dropped the old, monolithic test, and removed it from Chromium's
TestExpectations file.

3:24 AM Changeset in webkit [143190] by Christophe Dumez
  • 12 edits in trunk

[EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API
https://bugs.webkit.org/show_bug.cgi?id=108598

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Refactor the Ewk_Favicon code so that it no longer relies on internal
C++ API and so that it is based solely on the C API. The API is changed
a little as well so that the Favicon URL is no longer exposed to the
client. Also the client is now only notified of icon changes once the
favicon data is actually available.

The API is covered by existing API tests and by MiniBrowser which are
both updated accordingly in this patch.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::informURLChange):
(EwkView::createFavicon):
(EwkView::onFaviconChanged):

  • UIProcess/API/efl/EwkView.h:

(EwkView):

  • UIProcess/API/efl/EwkViewCallbacks.h:
  • UIProcess/API/efl/ewk_favicon_database.cpp:

Client are now notified of favicon changes only when the favicon data
becomes available and make API to retrieve a favicon synchronous. NULL
is returned if the favicon data is not available.

(EwkFaviconDatabase::EwkFaviconDatabase):
(EwkFaviconDatabase::getIconSurfaceSynchronously):
(EwkFaviconDatabase::iconDataReadyForPageURL):
(ewk_favicon_database_icon_get):

  • UIProcess/API/efl/ewk_favicon_database.h:
  • UIProcess/API/efl/ewk_favicon_database_private.h:

(EwkFaviconDatabase):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_favicon_get):

  • UIProcess/API/efl/ewk_view.h:

Rename 'icon,changed' signal to 'favicon,changed' for clarity and
consistency with the rest of the favicon API. Remove API to retrieve
the favicon URL and replace it by one to retrieve the favicon image as
an Evas_Object instead.

  • UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:

Update API tests to use the new favicon API.

Tools:

Update EFL's MiniBrowser to make use of new Ewk_Favicon API.

  • MiniBrowser/efl/main.c:

(update_view_favicon):
(on_view_favicon_changed):
(window_create):

3:22 AM Changeset in webkit [143189] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip several webaudio test cases that pass now that we updated to
gstreamer 1.0.

  • platform/efl/TestExpectations:
2:59 AM Changeset in webkit [143188] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium/clang] Remove -Wno-return-type-c-linkage
https://bugs.webkit.org/show_bug.cgi?id=110098

Reviewed by Jochen Eisinger.

The one instance where this triggered was removed in
http://trac.webkit.org/changeset/141184 . A clang that has this
warning landed in chromium r182694, so it should be safe to turn
the warning on now.

  • WebCore.gyp/WebCore.gyp:
2:56 AM Changeset in webkit [143187] by Christophe Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Update expectations for several test cases to make the bots green.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
2:51 AM Changeset in webkit [143186] by pfeldman@chromium.org
  • 21 edits
    2 adds in trunk

Web Inspector: provide basic console.table implementation (no [,columns] support)
https://bugs.webkit.org/show_bug.cgi?id=109453

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/console/console-format-table.html

Using console preview infrastructure to support console.table.

  • English.lproj/localizedStrings.js:
  • inspector/ConsoleAPITypes.h:
  • inspector/ConsoleMessage.cpp:

(WebCore::messageTypeValue):
(WebCore::ConsoleMessage::addToFrontend):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::wrapObject):
(WebCore):
(WebCore::InjectedScript::wrapTable):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype.willHide):
(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
(WebInspector.ConsoleMessageImpl.prototype._renderPropertyPreview):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsTable):

  • inspector/front-end/ConsoleModel.js:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleCommand.prototype.wasShown):
(WebInspector.ConsoleCommand.prototype.willHide):
(WebInspector.ConsoleGroup.prototype.addMessage):

  • inspector/front-end/DataGrid.js:

(.sortDataGrid.comparator):
(.sortDataGrid):
(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.renderInline):

  • inspector/front-end/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype._queryFinished):

  • inspector/front-end/dataGrid.css:

(.data-grid.inline):
(.data-grid.inline td.corner):

  • inspector/front-end/resourcesPanel.css:

(.storage-view > .data-grid):

  • page/Console.cpp:

(WebCore::Console::table):
(WebCore):

  • page/Console.h:

(Console):

  • page/Console.idl:

LayoutTests:

  • inspector/console/command-line-api-expected.txt:
  • inspector/console/console-format-table-expected.txt: Added.
  • inspector/console/console-format-table.html: Added.
2:45 AM Changeset in webkit [143185] by yurys@chromium.org
  • 2 edits in branches/chromium/1410/Source/WebCore/inspector/front-end

Merge 142870

Web Inspector: fix to record button remaining red after heap snapshot is taken
https://bugs.webkit.org/show_bug.cgi?id=109804

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-14
Reviewed by Yury Semikhatsky.

Revert part of r142243 fix. Namely heap snapshot taking button made
stateless as it was before.

  • inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.toggleRecordButton):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12294013

2:45 AM Changeset in webkit [143184] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: JavaScriptSourceFrame should inherit UISourceCodeFrame
https://bugs.webkit.org/show_bug.cgi?id=110091

Reviewed by Pavel Feldman.

Removed duplicated code from JavaScriptSourceFrame and made it inherit UISourceCodeFrame.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.onUISourceCodeContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):

  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame.prototype.canEditSource):
(WebInspector.UISourceCodeFrame.prototype.onTextChanged):
(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):
(WebInspector.UISourceCodeFrame.prototype.onUISourceCodeContentChanged):
(WebInspector.UISourceCodeFrame.prototype._innerSetContent):

2:35 AM Changeset in webkit [143183] by apavlov@chromium.org
  • 3 edits in branches/chromium/1410/Source/WebCore/inspector/front-end

Merge 142745

Web Inspector: Fixed colorpicker editing and scrolling.
https://bugs.webkit.org/show_bug.cgi?id=109434.

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
Reviewed by Alexander Pavlov.

The color picker scrolling logic relied on the fixed DOM structure which changed with the introduction of
SidebarPaneStack (https://bugs.webkit.org/show_bug.cgi?id=108183).
Added a special CSS class to mark the scroll target.

No new tests.

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12301008

2:31 AM Changeset in webkit [143182] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

Follow up to r143112, fixing tests.
Not reviewed.

  • inspector/elements/insert-node-expected.txt:
  • inspector/elements/insert-node.html:
2:30 AM Changeset in webkit [143181] by loislo@chromium.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed speculative build fix for Apple Win bots.

2:29 AM Changeset in webkit [143180] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove unused _files field in FileSystemProjectDelegate
https://bugs.webkit.org/show_bug.cgi?id=110082

Reviewed by Pavel Feldman.

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype._addFile):
(WebInspector.FileSystemProjectDelegate.prototype._removeFile):

2:28 AM Changeset in webkit [143179] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: allow 0 as a formatted parameter in console message.
https://bugs.webkit.org/show_bug.cgi?id=110096

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.append):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):

LayoutTests:

  • inspector/console/console-format.html:
2:20 AM Changeset in webkit [143178] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed speculative fix for Chromium Mac.

  • WebCore.gypi:
2:15 AM Changeset in webkit [143177] by kadam@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipped failing tests.

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt/TestExpectations:
2:11 AM Changeset in webkit [143176] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
1:54 AM Changeset in webkit [143175] by loislo@chromium.org
  • 6 edits
    1 add in trunk

Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
https://bugs.webkit.org/show_bug.cgi?id=109554

In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.

Drive by fix: I introduced a client interface for the HeapGraphSerializer.
It helps me to do the tests for the serializer.

Reviewed by Yury Semikhatsky.

It is covered by newly added tests in TestWebKitAPI.

Source/WebCore:

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):
(Client):
(WebCore::HeapGraphSerializer::Client::~Client):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

Tools:

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.

(TestWebKitAPI):
(HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::printGraph):
(TestWebKitAPI::HeapGraphReceiver::dumpNodes):
(TestWebKitAPI::HeapGraphReceiver::dumpEdges):
(TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
(TestWebKitAPI::HeapGraphReceiver::dumpStrings):
(TestWebKitAPI::HeapGraphReceiver::serializer):
(TestWebKitAPI::HeapGraphReceiver::chunkPart):
(TestWebKitAPI::HeapGraphReceiver::dumpPart):
(TestWebKitAPI::HeapGraphReceiver::stringValue):
(TestWebKitAPI::HeapGraphReceiver::intValue):
(TestWebKitAPI::HeapGraphReceiver::nodeToString):
(TestWebKitAPI::HeapGraphReceiver::edgeToString):
(TestWebKitAPI::HeapGraphReceiver::printNode):
(Helper):
(TestWebKitAPI::Helper::Helper):
(TestWebKitAPI::Helper::addNode):
(TestWebKitAPI::Helper::addEdge):
(TestWebKitAPI::Helper::done):
(Object):
(TestWebKitAPI::Helper::Object::Object):
(TestWebKitAPI::TEST):
(Owner):
(TestWebKitAPI::Owner::Owner):
(TestWebKitAPI::Owner::reportMemoryUsage):

1:30 AM Changeset in webkit [143174] by commit-queue@webkit.org
  • 9 edits in trunk

Unreviewed, rolling out r143100.
http://trac.webkit.org/changeset/143100
https://bugs.webkit.org/show_bug.cgi?id=110088

Breaks file system support in workspace. (Requested by vsevik
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18

Source/WebCore:

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.uri):

  • inspector/front-end/Workspace.js:

(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCodeForURI):
(WebInspector.Workspace.prototype.projectForUISourceCode):

LayoutTests:

  • inspector/debugger/live-edit-breakpoints-expected.txt:
  • inspector/debugger/live-edit-breakpoints.html:
  • inspector/uisourcecode-revisions.html:
1:27 AM Changeset in webkit [143173] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.

Adding failure expectations for two tests that are failing on GTK and Qt,
most likely due to disabled subpixel layout.

  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
1:26 AM Changeset in webkit [143172] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of StructureStubInfo.h

Rubber stamped by Mark Hahnenberg.

  • bytecode/StructureStubInfo.h:
1:25 AM Changeset in webkit [143171] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix indentation of JSGlobalObject.h and JSGlobalObjectFunctions.h

Rubber stamped by Mark Hahnenberg.

  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalObjectFunctions.h:
1:20 AM Changeset in webkit [143170] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indention of Operations.h

Rubber stamped by Mark Hahnenberg.

  • runtime/Operations.h:
1:16 AM Changeset in webkit [143169] by Christophe Dumez
  • 3 edits
    2 deletes in trunk/LayoutTests

Unreviewed. Clean up a few EFL unexpected passes.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Removed.
  • platform/efl/ietestcenter/css3/text/textshadow-005-expected.txt: Removed.
1:16 AM Changeset in webkit [143168] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove DFG::SpeculativeJIT::isKnownNumeric(), since it's not called from anywhere.

Rubber stamped by Andy Estes.

  • dfg/DFGSpeculativeJIT.cpp:

(DFG):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

1:11 AM Changeset in webkit [143167] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove DFG::SpeculativeJIT::isStrictInt32(), since it's not called from anywhere.

Rubber stampted by Andy Estes.

  • dfg/DFGSpeculativeJIT.cpp:

(DFG):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

1:00 AM Changeset in webkit [143166] by tommyw@google.com
  • 2 edits in branches/chromium/1364/Source/WebCore/Modules/mediastream

Merge 142887

MediaStream API: RTCDataChannel triggers a use-after-free
https://bugs.webkit.org/show_bug.cgi?id=109806

Reviewed by Adam Barth.

Making sure RTCPeerConnection::stop() is always called at least once.
Also making sure that RTCDataChannels state gets set to Closed correctly.

Hard to test in WebKit but covered by Chromium tests.

  • Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::stop):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::stop):

TBR=tommyw@google.com
Review URL: https://codereview.chromium.org/12301006

12:59 AM Changeset in webkit [143165] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Remove dead code for ValueToNumber from the DFG.

Rubber stamped by Andy Estes.

We killed ValueToNumber at some point, but forgot to kill all of the backend support
for it.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleMinMax):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:
  • dfg/DFGSpeculativeJIT64.cpp:
12:59 AM Changeset in webkit [143164] by Christophe Dumez
  • 2 edits
    4 deletes in trunk/LayoutTests

Unreviewed. Clean up a few EFL unexpected passes.

  • platform/efl/TestExpectations:
  • platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.png: Removed.
  • platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Removed.
  • platform/efl/fast/repaint/caret-with-transformation-expected.png: Removed.
  • platform/efl/fast/repaint/caret-with-transformation-expected.txt: Removed.
12:46 AM Changeset in webkit [143163] by Christophe Dumez
  • 2 edits
    12 deletes in trunk/LayoutTests

Unreviewed. Remove invalid EFL results that were wrongly added in r140249.

  • platform/efl/TestExpectations:
  • platform/efl/fast/css/color-correction-on-background-image-expected.png: Removed.
  • platform/efl/fast/css/color-correction-on-background-image-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-backgrounds-expected.png: Removed.
  • platform/efl/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-box-shadow-expected.png: Removed.
  • platform/efl/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-text-expected.png: Removed.
  • platform/efl/fast/css/color-correction-on-text-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-on-text-shadow-expected.png: Removed.
  • platform/efl/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
  • platform/efl/fast/css/color-correction-untagged-images-expected.png: Removed.
  • platform/efl/fast/css/color-correction-untagged-images-expected.txt: Removed.
12:38 AM Changeset in webkit [143162] by rniwa@webkit.org
  • 2 edits in trunk/Tools

WKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.

  • Scripts/webkitpy/tool/commands/newcommitbot.py:

(NewCommitBot.next_work_item):

12:37 AM Changeset in webkit [143161] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed. Unskip several test cases that are now passing on
EFL port, most of them due to enabling subpixel layout.

  • platform/efl/TestExpectations:
12:22 AM Changeset in webkit [143160] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed. Unskip several compositing tests that are now
passing on WK2 EFL.

  • platform/efl/TestExpectations:

Feb 17, 2013:

11:51 PM Changeset in webkit [143159] by eustas@chromium.org
  • 12 edits
    1 add in trunk

Web Inspector: Introduce ProfilesPanelDescriptor.
https://bugs.webkit.org/show_bug.cgi?id=109906

Reviewed by Pavel Feldman.

Source/WebCore:

Some constants/methods should be accesible before ProfilesPanel
is instantiated.

Extracted methods to check if profile is "user-initiated" and what is
its index.

Also profile URL regexp moved to ProfilesPanelDescriptor.

  • inspector/front-end/ProfilesPanelDescriptor.js: Added.
  • WebCore.gypi: Added ProfilesPanelDescriptor.js
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • inspector/compile-front-end.py: Ditto.
  • inspector/front-end/WebKit.qrc: Ditto.
  • inspector/front-end/inspector.html: Ditto.
  • inspector/front-end/HeapSnapshotView.js: Adopted changes.
  • inspector/front-end/ProfilesPanel.js: Ditto.
  • inspector/front-end/externs.js: Ditto.
  • inspector/front-end/inspector.js: Ditto.

LayoutTests:

  • inspector/profiler/heap-snapshot-test.js: Adopted changes.
11:50 PM WebKit Team edited by kangil.han@samsung.com
(diff)
11:47 PM Changeset in webkit [143158] by kangil.han@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
11:46 PM Changeset in webkit [143157] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update test expectation for chromium.
https://bugs.webkit.org/show_bug.cgi?id=110079

  • platform/chromium/TestExpectations:
11:44 PM Changeset in webkit [143156] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

GCE EWS bots are all offline
https://bugs.webkit.org/show_bug.cgi?id=110069

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-17
Reviewed by Eric Seidel.

Updated GCE EWS build scripts to use the gcel-10-04-v20130104 image instead of the obsoleted ubuntu-10-04-v20120621.
This changed the ephemeral disk path to /dev/sdb and required /etc/hosts to be chmodded to 644.

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
  • EWSTools/build-vm.sh:
  • EWSTools/start-queue.sh:
11:35 PM Changeset in webkit [143155] by vivek.vg@samsung.com
  • 2 edits in trunk/LayoutTests

Add missing braces in fast/parser/noscript-with-javascript-enabled.html
https://bugs.webkit.org/show_bug.cgi?id=110078

Unreviewed gardening. Adding the missing braces.

  • fast/parser/noscript-with-javascript-enabled.html:
11:25 PM WebKit Team edited by vivekg@webkit.org
(diff)
11:18 PM Changeset in webkit [143154] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed buildfix for JSVALUE32_64 builds after r143147.

  • jit/JIT.h:
10:50 PM Changeset in webkit [143153] by eustas@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, add myself to commiters.py.

  • Scripts/webkitpy/common/config/committers.py:
10:44 PM Changeset in webkit [143152] by Dimitri Glazkov
  • 3 edits in trunk/Source/WebCore

Stop passing around SelectorChecker in SelectorQuery, now that it's stack-allocated.
https://bugs.webkit.org/show_bug.cgi?id=110038

Reviewed by Andreas Kling.

No functional changes, covered by existing tests.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::matches): Moved instantiation of SelectorChecker in here.
(WebCore::SelectorDataList::queryAll): Got rid of unneeded SelectorChecker arg.
(WebCore::SelectorDataList::queryFirst): Ditto.
(WebCore::SelectorDataList::execute): Moved instantiation of SelectorChecker in here.
(WebCore::SelectorQuery::matches): Removed instantiation of SelectorChecker here.
(WebCore::SelectorQuery::queryAll): Ditto.
(WebCore::SelectorQuery::queryFirst): Ditto.

  • dom/SelectorQuery.h:

(WebCore): Tweaked headers to make SelectorChecker just an implementation detail.
(SelectorDataList): Tweaked decls to remove SelectorChecker args.

10:38 PM Changeset in webkit [143151] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update test expectation for chromium.
https://bugs.webkit.org/show_bug.cgi?id=110076

  • platform/chromium/TestExpectations:
10:37 PM Changeset in webkit [143150] by Dimitri Glazkov
  • 3 edits in trunk/Source/WebCore

Stop passing around SelectorChecker in ContentSelectorQuery.
https://bugs.webkit.org/show_bug.cgi?id=110041

Now that SelectorChecker has no interesting state, we can simplify ContentSelectorQuery and get rid of a class.

Reviewed by Andreas Kling.

No functional changes, covered by existing tests.

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorDataList::checkContentSelector): Zapped ContentSelectorChecker and moved its only remaining method here.
(WebCore::ContentSelectorDataList::matches): Removed SelectorChecker argument.
(WebCore::ContentSelectorQuery::ContentSelectorQuery): Removed an unnecessary member.
(WebCore::ContentSelectorQuery::matches): Removed unnecessary argument.

  • html/shadow/ContentSelectorQuery.h:

(WebCore): Cleaned up the file.
(ContentSelectorDataList): Updated decls.
(ContentSelectorQuery): Ditto.

10:33 PM Changeset in webkit [143149] by dw.im@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
10:31 PM Changeset in webkit [143148] by mkwst@chromium.org
  • 3 edits
    2 adds in trunk

WheelEvent should not target text nodes.
https://bugs.webkit.org/show_bug.cgi?id=109939

Reviewed by Darin Adler.

Source/WebCore:

WheelEvent, like other mouse events, should not target text nodes.
EventHandler correctly handles other mouse events by retargeting
events to text nodes' parents; this patch adds that logic to the
WheelEvent handler.

This should allow jQuery to stop working around WebKit's behavior[1].

[1]: https://github.com/jquery/jquery/commit/c61150427fc8ccc8e884df8f221a6c9bb5477929

Test: fast/events/wheelevent-in-text-node.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

If a WheelEvent's hit test lands on a text node, retarget the
event to the text node's parent. Do this before latching the node.

LayoutTests:

  • fast/events/wheelevent-in-text-node-expected.txt: Added.
  • fast/events/wheelevent-in-text-node.html: Added.
10:28 PM Changeset in webkit [143147] by fpizlo@apple.com
  • 35 edits
    4 adds in trunk/Source

Move all Structure out-of-line inline methods to StructureInlines.h
https://bugs.webkit.org/show_bug.cgi?id=110024

Source/JavaScriptCore:

Rubber stamped by Mark Hahnenberg and Sam Weinig.

This was supposed to be easy.

But, initially, there was a Structure inline method in CodeBlock.h, and moving that
into StructureInlines.h meant that Operations.h included CodeBlock.h. This would
cause WebCore build failures, because CodeBlock.h transitively included the JSC
parser (via many, many paths), and the JSC parser defines tokens using enumeration
elements that CSSGrammar.cpp (generated by bison) would #define. For example,
bison would give CSSGrammar.cpp a #define FUNCTION 123, and would do so before
including anything interesting. The JSC parser would have an enum that included
FUNCTION as an element. Hence the JSC parser included into CSSGrammar.cpp would have
a token element called FUNCTION declared in an enumeration, but FUNCTION was
#define'd to 123, leading to a parser error.

Wow.

So I removed all transitive include paths from CodeBlock.h to the JSC Parser. I
believe I was able to do so without out-of-lining anything interesting or performance
critical. This is probably a purely good thing to have done: it will be nice to be
able to make changes to the parser without having to compile the universe.

Of course, doing this caused a bunch of other things to not compile, since a bunch of
headers relied on things being implicitly included for them when they transitively
included the parser. I fixed a lot of that.

Finally, I ended up removing the method that depended on CodeBlock.h from
StructureInlines.h, and putting it in Structure.cpp. That might seem like all of this
was a waste of time, except that I suspect it was a worthwhile forcing function for
cleaning up a bunch of cruft.

  • API/JSCallbackFunction.cpp:
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.h:

(JSC):

  • bytecode/EvalCodeCache.h:
  • bytecode/SamplingTool.h:
  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::parameterCount):
(JSC):

  • bytecode/UnlinkedCodeBlock.h:

(UnlinkedFunctionExecutable):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/Label.h:

(JSC):

  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGByteCodeParser.h:
  • dfg/DFGFPRInfo.h:
  • dfg/DFGRegisterBank.h:
  • heap/HandleStack.cpp:
  • jit/JITWriteBarrier.h:
  • parser/Nodes.h:

(JSC):

  • parser/Parser.h:
  • parser/ParserError.h: Added.

(JSC):
(JSC::ParserError::ParserError):
(ParserError):
(JSC::ParserError::toErrorObject):

  • parser/ParserModes.h:
  • parser/SourceProvider.cpp: Added.

(JSC):
(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::~SourceProvider):

  • parser/SourceProvider.h:

(JSC):
(SourceProvider):

  • runtime/ArrayPrototype.cpp:
  • runtime/DatePrototype.cpp:
  • runtime/Executable.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:

(JSC):

  • runtime/Operations.h:
  • runtime/Structure.cpp:

(JSC::Structure::prototypeForLookup):
(JSC):

  • runtime/Structure.h:

(JSC):

  • runtime/StructureInlines.h: Added.

(JSC):
(JSC::Structure::create):
(JSC::Structure::createStructure):
(JSC::Structure::get):
(JSC::Structure::masqueradesAsUndefined):
(JSC::SlotVisitor::internalAppend):
(JSC::Structure::transitivelyTransitionedFrom):
(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache):
(JSC::Structure::prototypeForLookup):
(JSC::Structure::prototypeChain):
(JSC::Structure::isValid):

  • runtime/StructureRareData.cpp:

Source/WebCore:

Rubber stamped by Sam Weinig.

No new tests because no new behavior. Just rewiring includes.

  • ForwardingHeaders/parser/SourceProviderCache.h: Added.
  • loader/cache/CachedScript.cpp:
10:02 PM WebKit Team edited by dw.im@samsung.com
(diff)
9:53 PM Changeset in webkit [143146] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Remove unnecessary public method DrawingAreaImpl::createGraphicsContext()
https://bugs.webkit.org/show_bug.cgi?id=109893

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-17
Reviewed by Anders Carlsson.

DrawingAreaImpl::createGraphicsContext() is unnecessary since
createGraphicsContext can be called directly using ShareableBitmap.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

9:51 PM Changeset in webkit [143145] by hayato@chromium.org
  • 7 edits in trunk/Source/WebCore

Make EventDispatcher take an Event object in its constructor.
https://bugs.webkit.org/show_bug.cgi?id=109898

Reviewed by Dimitri Glazkov.

That makes EventDispatcher more RAII-like so that we can calculate
an EventPath in its constructor. I'll remove
EventDispatcher::ensureEventPath() in a following patch.

No tests. No change in behavior.

  • dom/EventDispatchMediator.cpp:

(WebCore::EventDispatchMediator::dispatchEvent):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::ensureEventPath):
(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPreProcess):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):

  • dom/EventDispatcher.h:

(EventDispatcher):
(WebCore::EventDispatcher::node):
(WebCore::EventDispatcher::event):

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

9:38 PM Changeset in webkit [143144] by pdr@google.com
  • 3 edits
    2 adds in trunk

Fix non-root SVG viewport under zoom
https://bugs.webkit.org/show_bug.cgi?id=99453

Reviewed by Dirk Schulze.

Source/WebCore:

The root SVG element handles zoom differently than other SVG nodes because it needs
to translate between CSS (where zoom is applied to all units) and SVG (where zoom is only
applied at the top level). A good description of this difference can be found here:
http://trac.webkit.org/browser/trunk/Source/WebCore/css/StyleResolver.cpp?rev=142855#L2598

SVG elements can appear as children in the SVG tree as well, and in this mode
SVGSVGElement should not consider the current zoom level. This patch fixes a bug
where non-root viewport calculations were removing zoom.

Test: svg/custom/symbol-zoom.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::currentViewportSize):

This change removes the unnecessary zoom calculation for non-root nodes. This is similar
to how zoom is handled elsewhere, e.g., SVGSVGElement::localCoordinateSpaceTransform.

LayoutTests:

  • svg/custom/symbol-zoom-expected.html: Added.
  • svg/custom/symbol-zoom.html: Added.
9:31 PM WebKit Team edited by bw80.lee@samsung.com
(diff)
9:30 PM Changeset in webkit [143143] by Chris Fleizach
  • 2 edits
    5 adds in trunk/Source/WebCore

AX: Upstream iOS Accessibility files
https://bugs.webkit.org/show_bug.cgi?id=110071

Reviewed by David Kilzer.

Upstream the iOS Accessibility files for WebCore.

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/ios: Added.
  • accessibility/ios/AXObjectCacheIOS.mm: Added.

(WebCore):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleScrolledToAnchor):

  • accessibility/ios/AccessibilityObjectIOS.mm: Added.

(-[WAKView accessibilityIsIgnored]):
(WebCore):
(WebCore::AccessibilityObject::detachFromParent):
(WebCore::AccessibilityObject::overrideAttachmentParent):
(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • accessibility/ios/AccessibilityObjectWrapperIOS.h: Added.

(WAKView):

  • accessibility/ios/AccessibilityObjectWrapperIOS.mm: Added.

(AccessibilityUnignoredAncestor):
(-[WebAccessibilityTextMarker initWithTextMarker:cache:]):
(-[WebAccessibilityTextMarker initWithData:cache:]):
(-[WebAccessibilityTextMarker initWithData:accessibilityObject:]):
(+[WebAccessibilityTextMarker textMarkerWithVisiblePosition:cache:]):
(-[WebAccessibilityTextMarker dataRepresentation]):
(-[WebAccessibilityTextMarker visiblePosition]):
(-[WebAccessibilityTextMarker description]):
(-[WebAccessibilityObjectWrapper initWithAccessibilityObject:]):
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper dealloc]):
(-[WebAccessibilityObjectWrapper _prepareAccessibilityCall]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper accessibilityPostProcessHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper accessibilityLanguage]):
(-[WebAccessibilityObjectWrapper _accessibilityIsLandmarkRole:]):
(-[WebAccessibilityObjectWrapper _accessibilityListAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityLandmarkAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityTableAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper isAccessibilityElement]):
(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
(-[WebAccessibilityObjectWrapper tableCellParent]):
(-[WebAccessibilityObjectWrapper tableParent]):
(-[WebAccessibilityObjectWrapper accessibilityTitleElement]):
(-[WebAccessibilityObjectWrapper accessibilityHeaderElements]):
(-[WebAccessibilityObjectWrapper accessibilityElementForRow:andColumn:]):
(-[WebAccessibilityObjectWrapper accessibilityRowRange]):
(-[WebAccessibilityObjectWrapper accessibilityColumnRange]):
(-[WebAccessibilityObjectWrapper accessibilityPlaceholderValue]):
(-[WebAccessibilityObjectWrapper accessibilityValue]):
(-[WebAccessibilityObjectWrapper accessibilityIsComboBox]):
(-[WebAccessibilityObjectWrapper accessibilityHint]):
(-[WebAccessibilityObjectWrapper accessibilityURL]):
(-[WebAccessibilityObjectWrapper _convertIntRectToScreenCoordinates:]):
(-[WebAccessibilityObjectWrapper accessibilityElementRect]):
(-[WebAccessibilityObjectWrapper accessibilityActivationPoint]):
(-[WebAccessibilityObjectWrapper accessibilityFrame]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
(-[WebAccessibilityObjectWrapper accessibilityContainer]):
(-[WebAccessibilityObjectWrapper accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapper _accessibilityWebDocumentView]):
(-[WebAccessibilityObjectWrapper _accessibilityNextElementsWithCount:]):
(-[WebAccessibilityObjectWrapper _accessibilityPreviousElementsWithCount:]):
(-[WebAccessibilityObjectWrapper accessibilityRequired]):
(-[WebAccessibilityObjectWrapper accessibilityFlowToElements]):
(-[WebAccessibilityObjectWrapper accessibilityLinkedElement]):
(-[WebAccessibilityObjectWrapper isAttachment]):
(-[WebAccessibilityObjectWrapper _accessibilityActivate]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(rendererForView):
(-[WebAccessibilityObjectWrapper _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapper postFocusChangeNotification]):
(-[WebAccessibilityObjectWrapper postSelectedTextChangeNotification]):
(-[WebAccessibilityObjectWrapper postLayoutChangeNotification]):
(-[WebAccessibilityObjectWrapper postLiveRegionChangeNotification]):
(-[WebAccessibilityObjectWrapper postLoadCompleteNotification]):
(-[WebAccessibilityObjectWrapper postChildrenChangedNotification]):
(-[WebAccessibilityObjectWrapper postInvalidStatusChangedNotification]):
(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):
(-[WebAccessibilityObjectWrapper accessibilityModifySelection:increase:]):
(-[WebAccessibilityObjectWrapper accessibilityIncreaseSelection:]):
(-[WebAccessibilityObjectWrapper accessibilityDecreaseSelection:]):
(-[WebAccessibilityObjectWrapper accessibilityMoveSelectionToMarker:]):
(-[WebAccessibilityObjectWrapper accessibilityIncrement]):
(-[WebAccessibilityObjectWrapper accessibilityDecrement]):
(-[WebAccessibilityObjectWrapper _addAccessibilityObject:toTextMarkerArray:]):
(-[WebAccessibilityObjectWrapper stringForTextMarkers:]):
(blockquoteLevel):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetFont):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributedStringAppendText):
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
(-[WebAccessibilityObjectWrapper _convertToNSRange:]):
(-[WebAccessibilityObjectWrapper _convertToDOMRange:]):
(-[WebAccessibilityObjectWrapper positionForTextMarker:]):
(-[WebAccessibilityObjectWrapper textMarkerRange]):
(-[WebAccessibilityObjectWrapper elementTextRange]):
(-[WebAccessibilityObjectWrapper accessibilityObjectForTextMarker:]):
(-[WebAccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapper textMarkerForPosition:]):
(-[WebAccessibilityObjectWrapper _stringForRange:attributed:]):
(-[WebAccessibilityObjectWrapper stringForRange:]):
(-[WebAccessibilityObjectWrapper attributedStringForRange:]):
(-[WebAccessibilityObjectWrapper elementsForRange:]):
(-[WebAccessibilityObjectWrapper selectionRangeString]):
(-[WebAccessibilityObjectWrapper selectedTextMarker]):
(-[WebAccessibilityObjectWrapper lineEndMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper lineStartMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper nextMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper previousMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper frameForTextMarkers:]):
(-[WebAccessibilityObjectWrapper textMarkerForPoint:]):
(-[WebAccessibilityObjectWrapper accessibilityIdentifier]):
(-[WebAccessibilityObjectWrapper accessibilitySpeechHint]):
(-[WebAccessibilityObjectWrapper accessibilityARIAIsBusy]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIARelevantStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionIsAtomic]):
(-[WebAccessibilityObjectWrapper accessibilityInvalidStatus]):
(-[WebAccessibilityObjectWrapper accessibilityMathRootIndexObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathRadicandObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathNumeratorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathDenominatorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathBaseObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSubscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSuperscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathUnderObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedOpenString]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedCloseString]):
(-[WebAccessibilityObjectWrapper accessibilityIsMathTopObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):
(-[WebAccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:withContext:]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:WebCore::AXObjectCache::]):
(-[WebAccessibilityObjectWrapper description]):

7:34 PM Changeset in webkit [143142] by Chris Fleizach
  • 4 edits
    2 moves
    2 adds in trunk/Source/WebCore

AX: rename WebAccessibilityObjectWrapper to WebAccessibilityObjectWrapperBase
https://bugs.webkit.org/show_bug.cgi?id=110061

Reviewed by David Kilzer.

Rename the base accessibility wrapper class so that the iOS class can share the same name.

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::attachWrapper):

  • accessibility/mac/WebAccessibilityObjectWrapper.h: Replaced with Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h.
  • accessibility/mac/WebAccessibilityObjectWrapper.mm: Replaced with Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm.
  • accessibility/mac/WebAccessibilityObjectWrapperBase.h: Copied from Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.h.
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm: Copied from Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm.
  • accessibility/mac/WebAccessibilityObjectWrapperMac.h: Removed.
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Removed.
7:33 PM Changeset in webkit [143141] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Windows build fix.

  • runtime/CodeCache.h:

(CodeCacheMap):

7:13 PM Changeset in webkit [143140] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Fix typo in script.

  • EWSTools/start-queue-win.sh:
5:58 PM Changeset in webkit [143139] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Pass in bot name as parameter to start-queue-win script.
https://bugs.webkit.org/show_bug.cgi?id=109998.

Reviewed by Darin Adler.

  • EWSTools/start-queue-win.sh:
5:25 PM Changeset in webkit [143138] by bw80.lee@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/committers.py:
3:26 PM Changeset in webkit [143137] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r143125): ~5% performance hit on Chromium's intl2 page cycler.
<http://webkit.org/b/108835>

Reviewed by Ojan Vafai.

Streamline the case where GlyphPage has a per-glyph SimpleFontData* lookup table to allow
taking earlier branches on pages with lots of mixed-font text.
We accomplish this by explicitly storing a null SimpleFontData* for glyph #0 in the per-glyph
lookup table instead of relying on "if (!glyph)" checks in getters.

This is a speculative optimization, I can't get stable enough numbers locally to tell if this
will resolve the issue on the bots.

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):

12:57 PM Changeset in webkit [143136] by Chris Fleizach
  • 17 edits
    2 adds in trunk

WebSpeech: plumb through a method to generate fake speech jobs for testing
https://bugs.webkit.org/show_bug.cgi?id=107351

Reviewed by Adam Barth.

Source/WebCore:

We can't reliably use the platforms synthesizer to test speech synthesis internals.
This patch adds an Internals method to enable a mock synthesizer, which is inherits
from the PlatformSpeechSythesizer.

The fake synthesizer goes through all the motions of a real synthesizer but doesn't do anything.
A bunch of changes were needed here to make PlatformSpeechSynthesizer subclassable so that the
right virtual are used.

The Mock synthesizer only lives in WebCoreTestSupport. Because PlatformSpeechSynthesizer uses
a RetainPtr, I needed to make WebCoreTestSupport link CoreFoundation

LayoutTests:

  • platform/mac/fast/speechsynthesis/speech-synthesis-speak.html:
  • platform/mac/fast/speechsynthesis/speech-synthesis-voices.html:
12:05 PM Changeset in webkit [143135] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark compositing/layer-creation/fixed-position-out-of-view-scaled.html as
flaky on WebKit2 EFL. It sometimes hits an assertion.

  • platform/efl-wk2/TestExpectations:
11:55 AM Changeset in webkit [143134] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Remove fullscreen manager proxy as a message receiver on invalidate()
https://bugs.webkit.org/show_bug.cgi?id=109451

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-02-17
Reviewed by Anders Carlsson.

Remove fullscreen manager proxy as a message receiver on invalidate(), like
other ports do after r142160.

  • UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

11:15 AM Changeset in webkit [143133] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Code cache should be explicit about what it caches
https://bugs.webkit.org/show_bug.cgi?id=110039

Reviewed by Oliver Hunt.

This patch makes the code cache more explicit in two ways:

(1) The cache caches top-level scripts. Any sub-functions executed as a
part of a script are cached with it and evicted with it.

This simplifies things by eliminating out-of-band sub-function tracking,
and fixes pathological cases where functions for live scripts would be
evicted in favor of functions for dead scripts, and/or high probability
functions executed early in script lifetime would be evicted in favor of
low probability functions executed late in script lifetime, due to LRU.

Statistical data from general browsing and PLT confirms that caching
functions independently of scripts is not profitable.

(2) The cache tracks script size, not script count.

This reduces the worst-case cache size by a factor of infinity.

Script size is a reasonable first-order estimate of in-memory footprint
for a cached script because there are no syntactic constructs that have
super-linear memory footprint.

  • bytecode/Unlinke