Context Navigation

← Previous Period
Next Period →

Timeline

Mar 25, 2013:

11:39 PM Changeset in webkit [146853] by morrita@google.com

6 edits
2 adds in trunk

Listening touch events on ShadowRoot can crash.
https://bugs.webkit.org/show_bug.cgi?id=113035

Reviewed by Kentaro Hara.

Source/WebCore:

TreeScope destructor clears a document reference on ShadowRoot but
destructors of ContainerNode and Node assumed it being available
and tried to access it for some cleanup purposes.

This change extracts such cleanup to Node::willBeDeletedFrom() and
calls it from ShadowRoot dtor before the document reference gets cleared.

Test: fast/dom/shadow/shadow-root-touch-listener-crash.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::~ContainerNode): Adopted willBeDeletedFrom()

dom/Node.cpp:

(WebCore::Node::~Node): Adopted willBeDeletedFrom()
(WebCore::Node::willBeDeletedFrom): Extracted from Node and ContainerNode
(WebCore):

dom/Node.h:
dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot): Adopted willBeDeletedFrom()

LayoutTests:

fast/dom/shadow/shadow-root-touch-listener-crash-expected.txt: Added.
fast/dom/shadow/shadow-root-touch-listener-crash.html: Added.

11:35 PM Changeset in webkit [146852] by rniwa@webkit.org

2 edits in trunk/Tools

Remove Lion leaks builder
https://bugs.webkit.org/show_bug.cgi?id=113252

Reviewed by Andreas Kling.

Removed.

BuildSlaveSupport/build.webkit.org-config/config.json:

11:35 PM Changeset in webkit [146851] by morrita@google.com

6 edits
2 deletes in trunk/Source/WebCore

Custom Elements Refactoring: The name V8CustomElement is confusing.
https://bugs.webkit.org/show_bug.cgi?id=113165

Reviewed by Kent Tamura.

This change moves functions from V8CustomElement to CustomElementHelpers and
removes V8CustomElement. V8CustomElement is just a heritage of old design
and no longer makes sense.

No new tests. No behavior change.

WebCore.gypi:
bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::createWrapper):
(WebCore):

bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):
(WebCore::CustomElementHelpers::wrap):
(WebCore):
(WebCore::CustomElementHelpers::constructorOf):

bindings/v8/V8CustomElement.cpp: Removed.
bindings/v8/V8CustomElement.h: Removed.
bindings/v8/custom/V8CustomElementConstructorCustom.cpp:

(WebCore::V8CustomElementConstructor::callAsFunctionCallback):

dom/make_names.pl:

(printWrapperFactoryCppFile):

11:07 PM Changeset in webkit [146850] by jamesr@google.com

5 edits
1 add
1 delete in trunk/LayoutTests

Update a few more chromium compositor baselines.

platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.

9:51 PM Changeset in webkit [146849] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Timeline] Records sidebar is clipped.
https://bugs.webkit.org/show_bug.cgi?id=113177

Reviewed by Pavel Feldman.

Analysis: depending on CSS injection order sidebar rule that overwrites
"bottom" property may win.

Fix: make timeline-specific rule "important".

inspector/front-end/timelinePanel.css:

(.timeline .sidebar): Make "bottom" value "important".

9:04 PM Changeset in webkit [146848] by noel.gordon@gmail.com

4 edits in trunk/LayoutTests

[chromium] Rebaseline canvas-toDataURL-webp test expectations
https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

platform/chromium-mac/fast/canvas/canvas-toDataURL-webp-expected.png:
platform/chromium-win/fast/canvas/canvas-toDataURL-webp-expected.png:
platform/chromium/TestExpectations:

8:28 PM Changeset in webkit [146847] by tkent@chromium.org

35 edits in trunk

Rename ENABLE_INPUT_TYPE_DATETIME
https://bugs.webkit.org/show_bug.cgi?id=113254

Reviewed by Kentaro Hara.

Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
Actually I'd like to remove the code, but we shouldn't remove it yet
because we shipped products with it on some platforms.

Source/autotools/SetupWebKitFeatures.m4:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

css/html.css:
html/DateTimeInputType.cpp:
html/DateTimeInputType.h:
html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):

Source/WebKit/blackberry:

WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium:

src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableInputTypeDateTime):
(WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled):

tests/WebViewTest.cpp:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

Scripts/webkitperl/FeatureList.pm:
qmake/mkspecs/features/features.pri:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.props:
win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.props:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

platform/chromium/TestExpectations:

8:19 PM Changeset in webkit [146846] by rniwa@webkit.org

4 edits in trunk/LayoutTests

REGRESSION(r146657): NRWT shouldn't report image only failures when pixel tests are disabled
https://bugs.webkit.org/show_bug.cgi?id=113261

Reviewed by Dirk Pranke.

Fixed the bug by treating ['TEXT', 'IMAGE'] as a flaky pass when the pixel tests is disabled
since the second token implies that we've forced pixel tests in retry and didn't have text failures.

fast/harness/resources/results-test.js:
fast/harness/results.html:
fast/harness/results-expected.txt:

8:13 PM Changeset in webkit [146845] by mary.wu@torchmobile.com.cn

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] add needReferer in WebPage load() api
https://bugs.webkit.org/show_bug.cgi?id=113167

Reviewed by Rob Buis.

PR310175, internally reviewed by Joe Mason.
Sometimes when client load request, it need to add referer with current frame like
save link/image in option menu, so we add needRef in load() interface in webpage.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::load):
(BlackBerry::WebKit::WebPage::loadExtended):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::download):

Api/WebPage.h:
Api/WebPage_p.h:

(WebPagePrivate):

8:11 PM Changeset in webkit [146844] by tony@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update Efl test expectations to mark new test as failing.
Efl doesn't implement the Pasteboard class.

platform/efl/TestExpectations: Mark editing/pasteboard/copy-image-with-alt-text.html as failing

8:02 PM Changeset in webkit [146843] by danakj@chromium.org

7 edits
1 delete in trunk/Source

[chromium] Move ownership of compositor VideoLayer to WebMediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=112971

Reviewed by James Robinson.

Source/Platform:

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

chromium/public/WebVideoFrame.h:
chromium/public/WebVideoFrameProvider.h:

Source/WebKit/chromium:

This moves ownership of the compositor's video layer over to the
implementation of WebMediaPlayer, as well as all interaction
between the media player system and the compositor layer or its
interfaces such as cc::VideoFrameProvider.

Now, the WebMediaPlayer implementation calls setWebLayer() to
provide the WebLayer* to the WebMediaPlayerClientImpl so that
it can be inserted into the GraphicsLayer tree appropriately.

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

Once chromium removes its use of WebVideoFrame and its related
classes, we can remove them from WebKit entirely.

WebKit.gypi:
public/WebMediaPlayer.h:

(WebKit):

public/WebMediaPlayerClient.h:
public/WebStreamTextureClient.h:
src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::setWebLayer):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::needsWebLayer):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):

src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

tests/WebMediaPlayerClientImplTest.cpp: Removed.

7:51 PM Changeset in webkit [146842] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r190515. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25

DEPS:

7:43 PM Changeset in webkit [146841] by jamesr@google.com

20 edits
3 copies
1 add
10 deletes in trunk/LayoutTests

Update more expectations and baselines for r146826

platform/chromium-linux-x86/compositing/iframes/scrolling-iframe-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt.
platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt:
platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/chromium-mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Removed.
platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Removed.
platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt: Removed.
platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Removed.
platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
platform/chromium-win/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
platform/chromium-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
platform/chromium/TestExpectations:
platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Removed.
platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Removed.
platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Removed.
platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
platform/chromium/compositing/iframes/iframe-resize-expected.txt:
platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
platform/chromium/compositing/iframes/resizer-expected.txt:
platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Removed.
platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:

7:35 PM Changeset in webkit [146840] by timothy@apple.com

9 edits
5 adds in trunk

Make the Web Inspector console work in strict mode with JavaScriptCore.

https://webkit.org/b/65829
rdar://problem/11271238

Reviewed by Oliver Hunt.

Source/WebCore:

bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::evaluate):
Return the evalFunction directly.

inspector/InjectedScriptHost.h:

(WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):
Added. Return true on JSC and false on V8.

inspector/InjectedScriptHost.idl:

Added evaluateReturnsEvalFunction and change evaluate to an attribute on JSC.

inspector/InjectedScriptSource.js:

(InjectedScript.prototype._evaluateOn): Change from using 'with' statements to creating
a closure that evaluates the expression. The command line APIs are passed as parameters
to the closure so they are in scope but not injected. This allows the code evaluated in
the console to stay in strict mode (if is was already set), or to get strict mode by
prefixing expressions with 'use strict';.

LayoutTests:

inspector/debugger/mutation-observer-suspend-while-paused.html: Tweaked.
inspector/console/command-line-api-expected.txt: Updated.

platform/mac/http/tests/inspector/console-resource-errors-expected.txt: Added.
platform/mac/http/tests/inspector/console-websocket-error-expected.txt: Updated.
platform/mac/inspector/console/console-eval-syntax-error-expected.txt: Added.
platform/mac/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Added.
platform/mac/inspector/extensions/extensions-eval-expected.txt: Added.

Added new expectations to match the new console evaluate approach.

7:14 PM Changeset in webkit [146839] by jamesr@google.com

3 edits
4 copies
2 moves
5 adds
10 deletes in trunk/LayoutTests

Update chromium baselines for windows related to r146826

platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-linux/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-linux/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-mac-lion/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
platform/chromium-mac/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-mac/compositing/geometry/preserve-3d-switching-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-win-xp/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
platform/chromium-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium/TestExpectations:
platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
platform/chromium/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/geometry/object-clip-rects-assertion-expected.txt.

7:02 PM Changeset in webkit [146838] by rniwa@webkit.org

2 edits in trunk/Tools

Remove one more line that was intended to be removed in r146657.

Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

6:44 PM Changeset in webkit [146837] by commit-queue@webkit.org

4 edits in trunk

Unreviewed, rolling out r146816, r146821, and r146830.
http://trac.webkit.org/changeset/146816
http://trac.webkit.org/changeset/146821
http://trac.webkit.org/changeset/146830
https://bugs.webkit.org/show_bug.cgi?id=113262

Broke all the Windows tests (Requested by rfong on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

platform/win/TestExpectations:

6:36 PM Changeset in webkit [146836] by jamesr@google.com

2 edits in trunk/LayoutTests

Revert bad change to expectation from r146826

compositing/geometry/object-clip-rects-assertion-expected.txt:

6:33 PM Changeset in webkit [146835] by tony@chromium.org

25 edits
2 adds in trunk

Image alt text not included in plain-text version when copying
https://bugs.webkit.org/show_bug.cgi?id=11200

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add a setting to enable copying image alt text to the clipboard and drag and drop pasteboard.
This setting is disabled by default, so each port can enable if they want to match IE10 and
Firefox's behavior.

Test: editing/pasteboard/copy-image-with-alt-text.html

editing/Editor.cpp:

(WebCore::Editor::cut): Explicitly ask that the selection on the pasteboard as being for the clipboard.
(WebCore::Editor::copy): Explicitly ask that the selection on the pasteboard as being for the clipboard.
(WebCore::Editor::selectedText): Add a private version of selectedText() that can choose between having image alt text or not.
(WebCore::Editor::selectedTextForClipboard): Ask for image alt text if the setting is enabled.

editing/Editor.h:
editing/TextIterator.cpp:

(WebCore::TextIterator::TextIterator): Add a bool to keep track of whether or not to emit image alt text.
(WebCore::TextIterator::handleReplacedElement): If there's alt text, point the iterator to it.

editing/TextIterator.h:

(TextIterator):

editing/mac/EditorMac.mm:

(WebCore::Editor::takeFindStringFromSelection): Use the same text as on the clipboard.
(WebCore::Editor::writeSelectionToPasteboard): Don't include image alt text since this is
used by Services.
(WebCore::Editor::stringSelectionForPasteboard): Don't include image alt text since this is
used by Services.

page/DragController.cpp:

(WebCore::DragController::startDrag): Use image alt text (matches Firefox).

page/Settings.in: Add a setting that disables image alt text by default.
platform/Pasteboard.h:
platform/blackberry/PasteboardBlackBerry.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::writeRange): Use clipboard text when writing ranges (used by d&d).

platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/efl/PasteboardEfl.cpp:

(WebCore::Pasteboard::writeSelection): Update function param.

platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::writeRange): Use clipboard text when writing ranges (used by d&d).

platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writeRange): Use clipboard text when writing ranges (used by d&d).

platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::getStringSelection): Use ShouldSerializeSelectedTextForClipboard to determine whether the selected
text is for the clipboard or not.
(WebCore::Pasteboard::writeSelectionForTypes): Pass ShouldSerializeSelectedTextForClipboard through.
(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::writeRange): Use clipboard text when writing ranges (used by d&d).

platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::writeRange): Use clipboard text when writing ranges (used by d&d).

platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/wince/PasteboardWinCE.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/wx/PasteboardWx.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

rendering/RenderImage.h:

(WebCore::RenderImage::altText): Add a getter for the alt text.

LayoutTests:

editing/pasteboard/copy-image-with-alt-text-expected.txt: Added.
editing/pasteboard/copy-image-with-alt-text.html: Added.

6:23 PM Changeset in webkit [146834] by jamesr@google.com

3 edits
9 moves
13 adds
2 deletes in trunk/LayoutTests

Update chromium mac 10.6 and 10.8 baselines for r146826.

platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
platform/chromium-mac-lion/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Removed.
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-mac/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css3/filters/filtered-compositing-descendant-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/compositing/geometry/composited-in-columns-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/preserve-3d-switching-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layer-creation/scroll-partial-update-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt.
platform/chromium-win/compositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/geometry/composited-in-columns-expected.txt.
platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt.

6:02 PM Changeset in webkit [146833] by dino@apple.com

10 edits
2 deletes in trunk/Source/WebCore

Remove autostart hashing code from WebCore
https://bugs.webkit.org/show_bug.cgi?id=113242

Reviewed by Tim Horton.

Remove PlugInOriginHash and all the related build entries.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
html/HTMLPlugInImageElement.cpp:
plugins/PlugInOriginHash.cpp: Removed.
plugins/PlugInOriginHash.h: Removed.

5:40 PM Changeset in webkit [146832] by pkasting@chromium.org

7 edits
7 adds in trunk/LayoutTests

[chromium] Rebaselining, etc.
https://bugs.webkit.org/show_bug.cgi?id=109507
https://bugs.webkit.org/show_bug.cgi?id=112927

Unreviewed, test expectations update.

platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Added.
platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt: Added.
platform/chromium-mac/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
platform/chromium-mac/css3/filters/effect-reference-expected.png:
platform/chromium-mac/css3/filters/effect-reference-expected.txt:
platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
platform/chromium-win-xp/fast/text/international/bold-bengali-expected.png: Added.
platform/chromium-win-xp/fast/text/international/bold-bengali-expected.txt: Added.
platform/chromium/TestExpectations:

5:36 PM Changeset in webkit [146831] by mark.lam@apple.com

4 edits in trunk/Source/JavaScriptCore

Offlineasm cloop backend compiles op+branch incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=113146.

Reviewed by Geoffrey Garen.

dfg/DFGRepatch.h:

(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

These functions never return when the DFG is dsiabled, not just when asserts are enabled. Changing the attribute from NO_RETURN_DUE_TO_ASSERT to NO_RETURN.
llint/LLIntOfflineAsmConfig.h:
Added some #defines needed to get the cloop building again.
offlineasm/cloop.rb:
Fix cloopEmitOpAndBranchIfOverflow() and cloopEmitOpAndBranch() to emit code that unconditionally executes the specified operation before doing the conditional branch.

5:27 PM Changeset in webkit [146830] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Unreviewed. Wrong place to enable RuntimeEnabledFeature for Windows.

bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

5:14 PM Changeset in webkit [146829] by mhahnenberg@apple.com

3 edits
3 adds in trunk

JSObject::enterDictionaryIndexingMode doesn't have a case for ALL_BLANK_INDEXING_TYPES
https://bugs.webkit.org/show_bug.cgi?id=113236

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

runtime/JSObject.cpp:

(JSC::JSObject::enterDictionaryIndexingMode): We forgot blank indexing types.

LayoutTests:

New test case that tests calling Object.freeze on Array.prototype.

fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type-expected.txt: Added.
fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type.html: Added.
fast/js/script-tests/enter-dictionary-indexing-mode-with-blank-indexing-type.js: Added.

5:11 PM Changeset in webkit [146828] by jamesr@google.com

7 edits
1 move
29 adds
5 deletes in trunk/LayoutTests

Update chromium baselines for r146826

platform/chromium-linux-x86/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-linux-x86/css3/filters/filtered-compositing-descendant-expected.txt: Added.
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
platform/chromium-linux/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
platform/chromium-linux/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-linux/css3/filters/filtered-compositing-descendant-expected.txt: Added.
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-mac-lion/compositing/geometry/composited-in-columns-expected.txt: Added.
platform/chromium-mac-lion/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-mac-lion/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
platform/chromium-mac-lion/css3/filters/filtered-compositing-descendant-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/preserve-3d-switching-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layer-creation/scroll-partial-update-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.

4:46 PM Changeset in webkit [146827] by roger_fong@apple.com

3 edits in trunk/Tools

No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
Re-enable WinEWS tests.

Scripts/webkitpy/common/config/ports.py:

(WinPort.run_bindings_tests_command):

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

4:34 PM Changeset in webkit [146826] by jamesr@google.com

128 edits
11 deletes in trunk

[chromium] Support GraphicsLayer::setContentsToSolidColor
https://bugs.webkit.org/show_bug.cgi?id=104396

Reviewed by Adrienne Walker.

Source/WebCore:

This enables and implements the GraphicsLayer::setContentsToSolidColor
path for Chromium.

Tested by reftests in compositing/background-color/ and several other
compositing/ tests.

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::supportsBackgroundColorContent):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToSolidColor):
(WebCore):

platform/graphics/chromium/GraphicsLayerChromium.h:

(WebKit):
(GraphicsLayerChromium):

Source/WebKit/chromium:

Updates some unit tests for better include discipline.

tests/GraphicsLayerChromiumTest.cpp:
tests/ImageLayerChromiumTest.cpp:

4:30 PM Changeset in webkit [146825] by vcarbune@chromium.org

8 edits
3 copies
2 adds in trunk

TextTrack Extension for WebVTT Regions
https://bugs.webkit.org/show_bug.cgi?id=109820

Reviewed by Eric Carlson.

Source/WebCore:

Implemented the TextTrackRegionList and extended TextTrack with
methods required for proper interaction with TextTrackRegion objects.

Test: media/track/regions-webvtt/text-track-region-list.html

WebCore.gypi: Added files for proper building of TextTrackRegionList.
html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore):
(WebCore::TextTrack::ensureTextTrackRegionList): Method for creating a
TextTrackRegionList associated with the current track, if it does exist
already.
(WebCore::TextTrack::regions): Getter for the regions object.
(WebCore::TextTrack::addRegion): Method for adding a region.
(WebCore::TextTrack::removeRegion): Method for removing a region.

html/track/TextTrack.h:

(WebCore):
(TextTrack):

html/track/TextTrack.idl: Added methods specific for region handling.
html/track/TextTrackRegion.cpp:

(WebCore::TextTrackRegion::TextTrackRegion): Initialized the track member variable.
(WebCore::TextTrackRegion::setTrack): Added internal setter for the track attribute.
(WebCore):
(WebCore::TextTrackRegion::updateParametersFromRegion): Method to copy the parameters
from a different region object.

html/track/TextTrackRegion.h: Added track member variable and copy method.

(WebCore::TextTrackRegion::track): Getter retrieves now the member variable.
(TextTrackRegion):

html/track/TextTrackRegionList.cpp: Implemented methods required by the IDL.

(WebCore):
(WebCore::TextTrackRegionList::TextTrackRegionList):
(WebCore::TextTrackRegionList::length):
(WebCore::TextTrackRegionList::item):
(WebCore::TextTrackRegionList::getRegionById):
(WebCore::TextTrackRegionList::add):
(WebCore::TextTrackRegionList::remove):
(WebCore::TextTrackRegionList::clear):

html/track/TextTrackRegionList.h:

(WebCore):
(TextTrackRegionList):
(WebCore::TextTrackRegionList::create):
(WebCore::TextTrackRegionList::~TextTrackRegionList):

html/track/TextTrackRegionList.idl: IDL defined by the specification.

LayoutTests:

media/track/regions-webvtt/text-track-region-list-expected.txt: Added.
media/track/regions-webvtt/text-track-region-list.html: Added.

4:29 PM Changeset in webkit [146824] by commit-queue@webkit.org

7 edits
1 add in trunk/Source

Unreviewed, rolling out r146819.
http://trac.webkit.org/changeset/146819
https://bugs.webkit.org/show_bug.cgi?id=113249

broke component build (Requested by danakj on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25

Source/Platform:

chromium/public/WebVideoFrame.h:

Source/WebKit/chromium:

WebKit.gypi:
public/WebMediaPlayerClient.h:

(WebKit):

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::disableAcceleratedCompositing):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):

src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

tests/WebMediaPlayerClientImplTest.cpp: Added.

(WebKit):
(FakeWebMediaPlayerClientImpl):
(WebKit::FakeWebMediaPlayerClientImpl::create):
(WebKit::FakeWebMediaPlayerClientImpl::FakeWebMediaPlayerClientImpl):
(FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::create):
(WebKit::FakeVideoFrameProviderClient::~FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::didReceiveFrame):
(WebKit::FakeVideoFrameProviderClient::didUpdateMatrix):
(WebKit::FakeVideoFrameProviderClient::stopUsingProvider):
(WebKit::FakeVideoFrameProviderClient::provider):
(WebKit::FakeVideoFrameProviderClient::FakeVideoFrameProviderClient):
(WebKit::TEST):

4:27 PM Changeset in webkit [146823] by dino@apple.com

20 edits in trunk/Source

Cleanup plugin snapshotting autostart decision making
https://bugs.webkit.org/show_bug.cgi?id=113231

Reviewed by Tim Horton.

Source/WebCore:

Move the code that creates a hash of plugin origin info
out of WebCore. All WebCore needs to do now is simply ask its
host layer whether or not a tuple of (pluginOrigin, pageOrigin, mimeType)
should autostart or not.

As a drive-by, the code in subframeLoaderWillCreatePlugIn was not quite
restarting properly when the displayState was Restarting or
RestartingWithPendingMouseClick. It still worked most of the time, but usually
because the code ran soon after a mouse click. Now it should be explicit and
also allowed us to be more clear about snapshotting at the end of the method.

html/HTMLPlugInElement.h: No more pluginOriginHash().
html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Change signature to accept the tuple

described above, and compare strings rather than hashes.

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Tell host layer the origin

info rather than hash info.

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Remember the url that

the plugin was loaded from. Make some of the logging messages more clear. Test for
plugin and page origin rather than hash.

html/HTMLPlugInImageElement.h:

(WebCore::HTMLPlugInImageElement::loadedUrl): New loadedURL member function.

page/PlugInClient.h:

(PlugInClient): Change signature of virtual class to accept origin and mimeType info

rather than hash.

Source/WebKit2:

Two major changes to the way snapshotting plugins may autostart.

The first is that previously WebCore was keeping a hash that
represented the combination of page origin, plugin origin and
mime type. WebKit was responsible for deciding if that particular
hash should autostart. Now, WebKit keeps the hash, and WebCore
just asks us whether the combination of origins and mimetype
should start immediately. You can see this change the in WebPluginClient
and WebProcess APIs.

The second change is that we now keep two types of structures
around to decide whether a plugin should autostart. One is the
existing page + plugin origin combination. The other is simply
the plugin origin, which allows plugins from major providers
to autostart no matter what page they were embedded on.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Encode the new parameter.
(WebKit::WebProcessCreationParameters::decode): Decode the new parameter.

Shared/WebProcessCreationParameters.h: Also keep a list of strings around.

UIProcess/API/C/WKContext.cpp:

(WKContextSetPlugInAutoStartOrigins): The C API to send the list of plugin

origins over to the context.

UIProcess/API/C/WKContext.h:

UIProcess/Plugins/PlugInAutoStartProvider.cpp:

(WebKit::PlugInAutoStartProvider::addAutoStartOriginHash): Renamed from addAutoStartOrigin.

No functional change other than new names for members.

(WebKit::PlugInAutoStartProvider::autoStartOriginHashesCopy): Ditto.
(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy): Ditto.
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTable): Ditto.
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsArray): New method that converts the

incoming ImmutableArray into a Vector of Strings.

(WebKit::PlugInAutoStartProvider::didReceiveUserInteraction): Rename for new members.

UIProcess/Plugins/PlugInAutoStartProvider.h: Renaming member variables. Adding

some typedefs to clean up code.

(WebKit::PlugInAutoStartProvider::autoStartOrigins): New accessor.

UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess): Renaming, and copy the new parameter into the process creation.
(WebKit::WebContext::addPlugInAutoStartOriginHash): Renaming.
(WebKit::WebContext::setPlugInAutoStartOriginHashes): Renaming.
(WebKit::WebContext::setPlugInAutoStartOrigins): New method.

UIProcess/WebContext.h: Adds the new setPlugInAutoStartOrigin method.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::didInitializePlugin): Drive-by fix that was attempting to restart plugins

that were in the process of restarting.

(WebKit::PluginView::pluginDidReceiveUserInteraction): Temporarily suspend update of

expiration time if the user interacts with a plugin.

WebProcess/WebCoreSupport/WebPlugInClient.cpp:

(WebKit::WebPlugInClient::shouldAutoStartFromOrigin): Renaming.
(WebKit::WebPlugInClient::didStartFromOrigin): Ditto.

WebProcess/WebCoreSupport/WebPlugInClient.h: Renaming.

WebProcess/WebProcess.cpp: Drive-by - noticed that we forgot to count seconds in

a timeout threshold.

(WebKit::WebProcess::initializeWebProcess): Also add the list of origins when we initialize.
(WebKit::addCaseFoldedCharacters): Copied from WebCore - adds a String to a hash input.
(WebKit::hashForPlugInOrigin): Copied from WebCore - hashing function.
(WebKit::WebProcess::isPlugInAutoStartOriginHash): Renaming.
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin): Check the list of pure origins first. If

that fails, fall back to the hash list of pairs.

(WebKit::WebProcess::plugInDidStartFromOrigin): Renaming.
(WebKit::WebProcess::didAddPlugInAutoStartOriginHash): Ditto.
(WebKit::WebProcess::resetPlugInAutoStartOriginHashes): Ditto.
(WebKit::WebProcess::plugInDidReceiveUserInteraction): Ditto.

WebProcess/WebProcess.h: Renaming some methods, but also adding the input of the new

origin-only list.

WebProcess/WebProcess.messages.in: Renaming a message.

4:07 PM Changeset in webkit [146822] by commit-queue@webkit.org

4 edits in trunk

Unreviewed, rolling out r146793.
http://trac.webkit.org/changeset/146793
https://bugs.webkit.org/show_bug.cgi?id=113248

Fix did not work (Requested by rfong on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25

Source/WebCore:

bindings/scripts/preprocessor.pm:

(applyPreprocessor):

Tools:

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

3:58 PM Changeset in webkit [146821] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Disable fast/exclusions and fast/regions tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=113244

platform/win/TestExpectations:

3:51 PM Changeset in webkit [146820] by commit-queue@webkit.org

14 edits
3 copies
3 adds in trunk

WEBGL_compressed_texture_pvrtc needs implementation
https://bugs.webkit.org/show_bug.cgi?id=110497

Patch by Brandon Jones <bajones@google.com> on 2013-03-25
Reviewed by Kenneth Russell.

Source/WebCore:

Test: webgl/conformance/extensions/webgl-compressed-texture-pvrtc.html

Exposes the WEBGL_compressed_texture_pvrtc extension, but is unverified since no desktop hardware supports
the format that I am aware of. Should enable mobile ports to expose the format, however.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

html/canvas/WebGLCompressedTexturePVRTC.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebCore::WebGLCompressedTexturePVRTC::WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::~WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::getName):
(WebCore::WebGLCompressedTexturePVRTC::create):
(WebCore::WebGLCompressedTexturePVRTC::supported):

html/canvas/WebGLCompressedTexturePVRTC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebGLCompressedTexturePVRTC):

html/canvas/WebGLCompressedTexturePVRTC.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
html/canvas/WebGLExtension.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):

html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

LayoutTests:

webgl/conformance/extensions/webgl-compressed-texture-pvrtc-expected.txt: Added.
webgl/conformance/extensions/webgl-compressed-texture-pvrtc.html: Added.
webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-pvrtc.html: Added.

3:48 PM Changeset in webkit [146819] by danakj@chromium.org

7 edits
1 delete in trunk/Source

[chromium] Move ownership of compositor VideoLayer to WebMediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=112971

Reviewed by James Robinson.

Source/Platform:

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

chromium/public/WebVideoFrame.h:
chromium/public/WebVideoFrameProvider.h:

Source/WebKit/chromium:

Now, the WebMediaPlayer implementation calls setWebLayer() to
provide the WebLayer* to the WebMediaPlayerClientImpl so that
it can be inserted into the GraphicsLayer tree appropriately.

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

Once chromium removes its use of WebVideoFrame and its related
classes, we can remove them from WebKit entirely.

WebKit.gypi:
public/WebMediaPlayer.h:

(WebKit):

public/WebMediaPlayerClient.h:
public/WebStreamTextureClient.h:
src/WebMediaPlayerClientImpl.cpp:

src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

tests/WebMediaPlayerClientImplTest.cpp: Removed.

3:18 PM Changeset in webkit [146818] by roger_fong@apple.com

2 edits in trunk/WebKitLibraries

Unreviewed. Also enable CSS_REGIONS and EXCLUSIONS for VS2010 solution.

win/tools/vsprops/FeatureDefines.props:

3:08 PM Changeset in webkit [146817] by rniwa@webkit.org

5 edits in trunk/Tools

REGRESSION(r146657): Test failures reported incorrectly
https://bugs.webkit.org/show_bug.cgi?id=113223

Reviewed by Dirk Pranke.

The bug was caused by BuildBotPrinter not taking the new behavior into account.

Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

Scripts/webkitpy/layout_tests/models/test_run_results.py:

(RunDetails.init):
(summarize_results): Remove the line I intended to remove in r146657.

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(logging_run): Return details instead of the exit code.
(run_and_capture): Ditto.

(RunTest.test_full_results_html):
(RunTest.test_hung_thread):
(RunTest.test_no_tests_found):
(RunTest.test_no_tests_found_2):
(RunTest.test_repeat_each_iterations_num_tests):
(RunTest.test_run_singly_actually_runs_tests):
(RunTest.test_test_list):
(RunTest.test_missing_and_unexpected_results):
(RunTest.test_pixel_test_directories):
(RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
(RunTest.test_crash_with_stderr):
(RunTest.test_no_image_failure_with_image_diff):
(RunTest.test_crash_log):
(RunTest.test_exit_after_n_failures_upload):
(RunTest.test_results_directory_absolute):
(RunTest.test_results_directory_relative):
(RunTest.test_retrying_and_flaky_tests):
(RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
(RunTest.test_retrying_uses_retries_directory):
(RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
(RunTest.test_output_diffs):
(EndToEndTest.test_reftest_with_two_notrefs):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

Scripts/webkitpy/layout_tests/views/buildbot_results.py:

(BuildBotPrinter.print_results):
(BuildBotPrinter.print_unexpected_results):
(BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
when we forced pixel tests in retry (i.e. pixel test was initially disabled).

2:01 PM Changeset in webkit [146816] by roger_fong@apple.com

6 edits in trunk

Enable CSS_REGIONS and CSS_EXCLUSIONS and related tests.
https://bugs.webkit.org/show_bug.cgi?id=87519

Reviewed by Timothy Horton.

win/tools/vsprops/FeatureDefines.vsprops:
platform/win/TestExpectations:
bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

1:53 PM Changeset in webkit [146815] by mikhail.pozdnyakov@intel.com

2 edits in trunk/Source/WebCore

Remove unused code from Frame class destructor
https://bugs.webkit.org/show_bug.cgi?id=113181

Reviewed by Alexey Proskuryakov.

No new tests. No new functionality.

page/Frame.cpp:

(WebCore::Frame::~Frame):

Removed the code which could never have been executed
as m_view had been set to '0'.

1:41 PM Changeset in webkit [146814] by danakj@chromium.org

21 edits in trunk/LayoutTests

Don't use video to trigger compositing for layout tests
https://bugs.webkit.org/show_bug.cgi?id=113228

Reviewed by Adrienne Walker.

These tests used <video> to trigger compositing because a 3d identity
transform would have affected the overlap map differently. This is
no longer the case, so use translateZ(0) to trigger compositing instead,
which makes these tests more reliable and faster.

compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
compositing/geometry/limit-layer-bounds-fixed-positioned.html:
compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
compositing/geometry/limit-layer-bounds-opacity-transition.html:
compositing/geometry/limit-layer-bounds-overflow-repaint.html:
compositing/geometry/limit-layer-bounds-overflow-root.html:
compositing/geometry/limit-layer-bounds-positioned-transition.html:
compositing/geometry/limit-layer-bounds-positioned.html:
compositing/geometry/limit-layer-bounds-transformed-overflow.html:
compositing/geometry/limit-layer-bounds-transformed.html:
compositing/layer-creation/scroll-partial-update-expected.txt:
compositing/layer-creation/scroll-partial-update.html:
platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt:
platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt:
platform/chromium/TestExpectations:
platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt:

1:38 PM Changeset in webkit [146813] by Lucas Forschler

1 edit
2 copies in tags/Safari-537.35.1/LayoutTests

Merged r146685. <rdar://problem/13475726>

1:36 PM Changeset in webkit [146812] by Lucas Forschler

8 edits in tags/Safari-537.35.1/Source

Merged r146679. <rdar://problem/13475726>

1:33 PM Changeset in webkit [146811] by Lucas Forschler

2 edits in tags/Safari-537.35.1/Source/WebCore

Merged r146563. <rdar://problem/13435161>

1:30 PM Changeset in webkit [146810] by Lucas Forschler

5 edits in tags/Safari-537.35.1/Source/WebKit2

Merged r146551. <rdar://problem/13355759>

1:28 PM Changeset in webkit [146809] by Lucas Forschler

2 edits in tags/Safari-537.35.1/Source/WebKit2

Merged r146542. <rdar://problem/13355808>

1:26 PM Changeset in webkit [146808] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Sheriffing.
https://bugs.webkit.org/show_bug.cgi?id=112927
https://bugs.webkit.org/show_bug.cgi?id=113067
https://bugs.webkit.org/show_bug.cgi?id=113129

Unreviewed, test expectation updates.

Removed crash expectations for fixed bug; added fail expectations for
results the bot won't give us; marked a test as slow.

platform/chromium/TestExpectations:

1:26 PM Changeset in webkit [146807] by Lucas Forschler

4 edits in tags/Safari-537.35.1/Source/WebKit2

Merged r146539. <rdar://problem/13355808>

1:23 PM Changeset in webkit [146806] by Lucas Forschler

2 edits in tags/Safari-537.35.1/Source/WebCore

Merged r146373. <rdar://problem/13202277>

1:16 PM Changeset in webkit [146805] by eric@webkit.org

3 edits
2 adds in trunk

Incorrect parsing due to hash collision
https://bugs.webkit.org/show_bug.cgi?id=113235

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/parser/tag-hash-collision.html

html/parser/HTMLIdentifier.cpp:

(WebCore::HTMLIdentifier::findIndex):

LayoutTests:

fast/parser/tag-hash-collision-expected.txt: Added.
fast/parser/tag-hash-collision.html: Added.

1:15 PM Changeset in webkit [146804] by eric.carlson@apple.com

4 edits in branches/safari-536.30-branch/LayoutTests

<rdar://problem/13465764> Many merged tests are failing

Update three more tests that use "testRunner" instead of "layoutTestController".

fast/block/float/intruding-float-not-removed-writing-mode.xhtml:
mhtml/shared_buffer_bug.mht:
svg/custom/use-invalidate-click-crash.xhtml:

1:14 PM Changeset in webkit [146803] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Compile without SVG will fail
https://bugs.webkit.org/show_bug.cgi?id=113234

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-03-25
Reviewed by Timothy Hatcher.

Only make the cast to SVGStyleElement if we have SVG support built.

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

1:11 PM Changeset in webkit [146802] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Enable STORE_FONT_CUSTOM_PLATFORM_DATA for all platforms
https://bugs.webkit.org/show_bug.cgi?id=108438

Reviewed by Andreas Kling.

Remove the conditional code so it is turned on for all platforms.

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::~CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::platformDataFromCustomData):
(WebCore::CachedFont::allClientsRemoved):
(WebCore::CachedFont::reportMemoryUsage):

1:10 PM Changeset in webkit [146801] by eric.carlson@apple.com

4 edits in trunk

REGRESSION(r146380): media/track/track-user-preferences.html
https://bugs.webkit.org/show_bug.cgi?id=113083

Reviewed by Jer Noble.

Source/WebCore:

Ignore track change notifications triggered by automatic track selection so the
configuration is not changed.

No new tests, this fixes an existing test.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup): Clear m_processingPreferenceChange after all

track configuration is finished.

(WebCore::HTMLMediaElement::configureTextTrackDisplay): Do nothing if m_processingPreferenceChange

is true.

LayoutTests:

platform/mac/TestExpectations: Remove test from expectations.

1:06 PM Changeset in webkit [146800] by Martin Robinson

2 edits in trunk/Source/WebCore

[GTK] [gyp] Build the final piece of WebCore
https://bugs.webkit.org/show_bug.cgi?id=113216

Reviewed by Nico Weber.

WebCore.gyp/WebCoreGTK.gyp: Add the rest of the WebCore source files to the WebCore build target.

1:00 PM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

12:57 PM Changeset in webkit [146799] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[WK2][GTK] MiniBrowser won't play video in <embed> tag
https://bugs.webkit.org/show_bug.cgi?id=113107

Reviewed by Martin Robinson.

The wrong clip region is used for windowed plugins, because it's
translated to window frame coords again.

WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange): Do not move
the current clip region.

12:45 PM Changeset in webkit [146798] by Martin Robinson

2 edits in trunk/Source/WebCore

[GTK] [gyp] Adding support for building WebCore rendering
https://bugs.webkit.org/show_bug.cgi?id=113213

Reviewed by Gustavo Noronha Silva.

WebCore.gyp/WebCoreGTK.gyp: Build the rendering directory into a shared library.

12:37 PM Changeset in webkit [146797] by jparent@chromium.org

12 edits in trunk/Tools

Dashboard refactor: Move cross dashboard history related code into history.js.
https://bugs.webkit.org/show_bug.cgi?id=113104

Reviewed by Ojan Vafai.

All functions relating to cross dashboard behavior move from being
globals to methods on the history.History object. Names stay the same,
except many are made private, ones that should have been constants now
are, and the long standing TODO to change "currentState" to
dashboardSpecificState is done.

We now create a global history object in dashboard_base, as an
intermediate measure. Once the dashboard specific code is
added to history, each DB will need to create its own, and this
global will be eliminated.

TestResultServer/static-dashboards/aggregate_results.js:

(handleValidHashParameter):
(htmlForBuilder):
(rawValuesHTML):

TestResultServer/static-dashboards/dashboard_base.js:

(parseDashboardSpecificParameters):
(defaultValue):
(currentBuilderGroupCategory):
(currentBuilderGroupName):
(handleLocationChange):
(expectationsMap):

TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):
(.switch.return):
(platformAndBuildType):
(individualTests):
(substringList):
(processMissingAndExtraExpectations):
(pathToFailureLog):
(showPopupForBuild):
(htmlForTestsWithExpectationsButNoFailures):
(shouldHideTest):
(isCrossBuilderView):
(tableHeaders):
(htmlForSingleTestRow):
(htmlForTableColumnHeader):
(generatePageForExpectationsUpdate):
(handleUpdate):
(nextUpdate):
(setUpdateIndex):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):
(.appendExpectationsItem):
(loadExpectations):
(.dummyNode.onload):
(loadExpectationsLayoutTests):
(appendExpectations):
(htmlForNavBar):
(checkBoxToToggleState):
(linkHTMLToToggleState):
(generatePageForBuilder):
(isInvalidKeyForCrossBuilderView):
(handleQueryParameterChange):
(showLegend):

TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):
(test):

TestResultServer/static-dashboards/history.js:

(.):

TestResultServer/static-dashboards/history_unittests.js:
TestResultServer/static-dashboards/loader.js:

(.):

TestResultServer/static-dashboards/loader_unittests.js:
TestResultServer/static-dashboards/timeline_explorer.js:

(generatePage):
(initCurrentBuilderTestResults):
(selectBuild):
(showResultsDelta):

TestResultServer/static-dashboards/treemap.js:

(generatePage):
(.switch.return):
(handleFocus):

TestResultServer/static-dashboards/ui.js:

12:16 PM Changeset in webkit [146796] by tony@chromium.org

3 edits in trunk/Source/WebCore

Remove TextIterator argumentless constructor
https://bugs.webkit.org/show_bug.cgi?id=113226

Reviewed by Ryosuke Niwa.

The TextIterator argumentless constructors are never used and wouldn't be useful
since you can't specify a range.

No new tests, removing dead code. There should be no behavior change.

editing/TextIterator.cpp: Remove constructors.
editing/TextIterator.h:

(TextIterator):
(SimplifiedBackwardsTextIterator):
(CharacterIterator):
(BackwardsCharacterIterator):
(WordAwareIterator):

12:05 PM Changeset in webkit [146795] by commit-queue@webkit.org

3 edits
3 adds in trunk

Enabled canvas.getContext("webgl") on Desktop Chrome
https://bugs.webkit.org/show_bug.cgi?id=113079

Patch by Brandon Jones <bajones@chromium.org> on 2013-03-25
Reviewed by Dean Jackson.

Test: fast/canvas/webgl/webgl-unprefixed-context-id.html

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextMethodCustom):

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

11:51 AM Changeset in webkit [146794] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Windows rebaseline after r146779.

platform/win/css3/filters/effect-reference-expected.txt:
platform/win/css3/filters/effect-reference-hw-expected.txt:

11:43 AM Changeset in webkit [146793] by roger_fong@apple.com

4 edits in trunk

Unreviewed. Remove some suspicious looking code in an attempt to fix EWS bots.
Enable WinEWS test again.

bindings/scripts/preprocessor.pm:

(applyPreprocessor):

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

11:40 AM Changeset in webkit [146792] by eric.carlson@apple.com

2 edits in branches/safari-536.30-branch/LayoutTests

Merge r136586.

2012-12-04 Florin Malita <fmalita@chromium.org>

Unreviewed gardening - add missing js-test-pre.js include to avoid use-href-update-crash.svg
failures on platforms that do not define gc().

svg/custom/use-href-update-crash.svg:

11:36 AM Changeset in webkit [146791] by Lucas Forschler

4 edits in tags/Safari-537.35.1/Source

Versioning.

11:31 AM Changeset in webkit [146790] by Lucas Forschler

1 copy in tags/Safari-537.35.1

New Tag.

11:19 AM Changeset in webkit [146789] by Martin Robinson

2 edits in trunk/Source/WebCore

[GTK] [gyp] Add support for building the platform directory
https://bugs.webkit.org/show_bug.cgi?id=113212

Reviewed by Nico Weber.

WebCore.gyp/WebCoreGTK.gyp: Add support for building the platform directory including

two libraries, one for platform and one for geometry files. This follows the approach
of Chromium.

11:13 AM Changeset in webkit [146788] by rniwa@webkit.org

6 edits in trunk/LayoutTests

Mac rebaselines after r146779. Also add failing expectations for 4 transition tests per bug 113223.

platform/mac/TestExpectations:
platform/mac/css3/filters/effect-reference-expected.png:
platform/mac/css3/filters/effect-reference-expected.txt:
platform/mac/css3/filters/effect-reference-hw-expected.png:
platform/mac/css3/filters/effect-reference-hw-expected.txt:

10:57 AM Changeset in webkit [146787] by jochen@chromium.org

4 edits in trunk

Swap both the error and change event queue before processing fullscreen events
https://bugs.webkit.org/show_bug.cgi?id=113194

Reviewed by Jer Noble.

Source/WebCore:

While processing the change events, not only new change events but
also new error events might get generated. However, for the timer, we
should only process preexisting events.

This is covered by fullscreen/full-screen-restrictions.html which times
out depending on the delay between requesting fullscreen and granting
fullscreen.

dom/Document.cpp:

(WebCore::Document::fullScreenChangeDelayTimerFired):

LayoutTests:

platform/chromium/TestExpectations:

9:51 AM Changeset in webkit [146786] by zarvai@inf.u-szeged.hu

215 edits
3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining. Making pixel test bot happier after r146206.

platform/qt/fast/replaced/max-width-percent-expected.png:
platform/qt/fast/replaced/maxheight-percent-expected.png:
platform/qt/fast/replaced/maxheight-pxs-expected.png:
platform/qt/fast/replaced/maxwidth-percent-expected.png:
platform/qt/fast/replaced/maxwidth-pxs-expected.png:
platform/qt/fast/replaced/minheight-percent-expected.png:
platform/qt/fast/replaced/minheight-pxs-expected.png:
platform/qt/fast/replaced/minwidth-percent-expected.png:
platform/qt/fast/replaced/minwidth-pxs-expected.png:
platform/qt/fast/replaced/object-align-hspace-vspace-expected.png:
platform/qt/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png:
platform/qt/fast/replaced/percent-height-in-anonymous-block-widget-expected.png:
platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
platform/qt/fast/replaced/width100percent-button-expected.png:
platform/qt/fast/ruby/ruby-inline-table-expected.png:
platform/qt/fast/runin/001-expected.png:
platform/qt/fast/runin/generated-expected.png:
platform/qt/fast/runin/runin-generated-before-content-expected.png:
platform/qt/fast/selectors/016-expected.png:
platform/qt/fast/selectors/017-expected.png:
platform/qt/fast/selectors/061-expected.png:
platform/qt/fast/selectors/062-expected.png:
platform/qt/fast/selectors/064-expected.png:
platform/qt/fast/table/003-expected.png:
platform/qt/fast/table/023-expected.png:
platform/qt/fast/table/027-vertical-expected.png:
platform/qt/fast/table/038-vertical-expected.png:
platform/qt/fast/table/040-expected.png:
platform/qt/fast/table/040-vertical-expected.png:
platform/qt/fast/table/100-percent-cell-width-expected.png:
platform/qt/fast/table/add-before-anonymous-child-expected.png:
platform/qt/fast/table/auto-100-percent-width-expected.png:
platform/qt/fast/table/border-collapsing/002-vertical-expected.png:
platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
platform/qt/fast/table/border-collapsing/equal-precedence-resolution-expected.png:
platform/qt/fast/table/cell-absolute-child-expected.png:
platform/qt/fast/table/click-near-anonymous-table-expected.png:
platform/qt/fast/table/empty-cells-expected.png:
platform/qt/fast/table/empty-table-percent-height-expected.png:
platform/qt/fast/table/fixed-granular-cols-expected.png:
platform/qt/fast/table/fixed-with-auto-with-colspan-expected.png:
platform/qt/fast/table/generated-caption-expected.png:
platform/qt/fast/table/insert-before-anonymous-ancestors-expected.png:
platform/qt/fast/table/mozilla-bug10296-vertical-align-1-expected.png:
platform/qt/fast/table/mozilla-bug10296-vertical-align-2-expected.png:
platform/qt/fast/table/row-height-recalc-expected.png:
platform/qt/fast/table/rtl-cell-display-none-assert-expected.png:
platform/qt/fast/table/stale-grid-crash-expected.png:
platform/qt/fast/table/table-and-parts-outline-expected.png:
platform/qt/fast/table/table-display-types-vertical-expected.png:
platform/qt/fast/table/text-field-baseline-expected.png:
platform/qt/fast/table/unused-percent-heights-expected.png:
platform/qt/fast/text/backslash-to-yen-sign-expected.png:
platform/qt/fast/text/basic/001-expected.png:
platform/qt/fast/text/basic/002-expected.png:
platform/qt/fast/text/basic/004-expected.png:
platform/qt/fast/text/basic/008-expected.png:
platform/qt/fast/text/basic/009-expected.png:
platform/qt/fast/text/basic/011-expected.png:
platform/qt/fast/text/basic/012-expected.png:
platform/qt/fast/text/basic/generic-family-changes-expected.png:
platform/qt/fast/text/basic/generic-family-reset-expected.png:
platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.png:
platform/qt/fast/text/capitalize-empty-generated-string-expected.png:
platform/qt/fast/text/complex-text-opacity-expected.png:
platform/qt/fast/text/fake-italic-expected.png:
platform/qt/fast/text/fallback-traits-fixup-expected.png:
platform/qt/fast/text/firstline/001-expected.png:
platform/qt/fast/text/font-initial-expected.png:
platform/qt/fast/text/hyphenate-limit-before-after-expected.png:
platform/qt/fast/text/international/arabic-justify-expected.png:
platform/qt/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
platform/qt/fast/text/international/hindi-whitespace-expected.png:
platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
platform/qt/fast/text/justified-selection-at-edge-expected.png:
platform/qt/fast/text/justified-selection-expected.png:
platform/qt/fast/text/line-breaks-after-white-space-expected.png:
platform/qt/fast/text/shadow-no-blur-expected.png:
platform/qt/fast/text/shadow-translucent-fill-expected.png:
platform/qt/fast/text/softHyphen-expected.png:
platform/qt/fast/text/unicode-variation-selector-expected.png:
platform/qt/fast/text/wbr-in-pre-crash-expected.png:
platform/qt/fast/text/wbr-styled-expected.png:
platform/qt/fast/text/whitespace/002-expected.png:
platform/qt/fast/text/whitespace/020-expected.png:
platform/qt/fast/text/whitespace/021-expected.png:
platform/qt/fast/text/whitespace/022-expected.png:
platform/qt/fast/text/whitespace/025-expected.png:
platform/qt/fast/text/whitespace/027-expected.png:
platform/qt/fast/text/whitespace/030-expected.png:
platform/qt/fast/text/whitespace/nbsp-mode-and-linewraps-expected.png:
platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
platform/qt/fast/text/whitespace/pre-break-word-expected.png:
platform/qt/fast/text/whitespace/pre-wrap-last-char-expected.png:
platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png:
platform/qt/fast/text/word-break-expected.png:
platform/qt/fast/text/zero-font-size-expected.png:
platform/qt/fast/transforms/bounding-rect-zoom-expected.png:
platform/qt/fast/transforms/diamond-expected.png:
platform/qt/fast/transforms/matrix-01-expected.png:
platform/qt/fast/transforms/matrix-02-expected.png:
platform/qt/fast/transforms/overflow-with-transform-expected.png:
platform/qt/fast/transforms/skew-with-unitless-zero-expected.png:
platform/qt/fast/transforms/transform-on-inline-expected.png:
platform/qt/fast/transforms/transform-positioned-ancestor-expected.png:
platform/qt/fast/transforms/transformed-document-element-expected.png:
platform/qt/fast/transforms/transforms-with-opacity-expected.png:
platform/qt/fast/writing-mode/block-level-images-expected.png:
platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
platform/qt/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.png:
platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.png:
platform/qt/fast/writing-mode/english-bt-text-expected.png:
platform/qt/fast/writing-mode/english-rl-text-expected.png:
platform/qt/fast/writing-mode/horizontal-bt-replaced-selection-expected.png:
platform/qt/fast/writing-mode/vertical-lr-replaced-selection-expected.png:
platform/qt/fast/writing-mode/vertical-rl-replaced-selection-expected.png:
platform/qt/fast/xsl/document-function-expected.png:
platform/qt/fonts/cursive-expected.png:
platform/qt/fonts/default-expected.png:
platform/qt/fonts/fantasy-expected.png:
platform/qt/fonts/monospace-expected.png:
platform/qt/fonts/sans-serif-expected.png:
platform/qt/fonts/serif-expected.png:
platform/qt/http/tests/local/file-url-sent-as-referer-expected.png:
platform/qt/http/tests/misc/frame-access-during-load-expected.png:
platform/qt/http/tests/misc/iframe404-expected.png:
platform/qt/http/tests/navigation/postredirect-basic-expected.png:
platform/qt/http/tests/navigation/postredirect-goback1-expected.png:
platform/qt/http/tests/uri/css-href-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png:
platform/qt/ietestcenter/css3/text/textshadow-003-expected.png:
platform/qt/ietestcenter/css3/text/textshadow-005-expected.png:
platform/qt/ietestcenter/css3/text/textshadow-007-expected.png:
platform/qt/ietestcenter/css3/text/textshadow-008-expected.png:
platform/qt/ietestcenter/css3/text/textshadow-009-expected.png:
platform/qt/ietestcenter/css3/text/textshadow-010-expected.png:
platform/qt/platform/qt/fast/forms/button-line-break-expected.png:
platform/qt/printing/return-from-printing-mode-expected.png:
platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
platform/qt/scrollbars/listbox-scrollbar-combinations-expected.png:
platform/qt/scrollbars/overflow-scrollbar-combinations-expected.png:
platform/qt/scrollbars/scrollbars-on-positioned-content-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-20-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:

9:49 AM Changeset in webkit [146785] by commit-queue@webkit.org

17 edits in trunk/Source/WebCore

[V8] Generate specialized callbacks for the main world
https://bugs.webkit.org/show_bug.cgi?id=112430

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-25
Reviewed by Kentaro Hara.

The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.

This patch generates main world bindings for getters and setters for a
small amount of frequently used functions / functions used by Dromaeo.

Added tests to TestObj.idl and updated bindings tests.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):

bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldMethodMethod):
(WebCore::TestObjV8Internal::perWorldMethodMethodForMainWorld):
(WebCore::TestObjV8Internal::perWorldMethodMethodCallback):
(WebCore::TestObjV8Internal::perWorldMethodMethodCallbackForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod1Method):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod1MethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod2Method):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod2MethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethod):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodCallback):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodCallbackForMainWorld):
(WebCore):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):

bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

bindings/v8/V8DOMConfiguration.h:

(BatchedMethod):
(V8DOMConfiguration):

dom/Document.idl:
dom/Element.idl:
dom/Node.idl:
page/DOMWindow.idl:

9:47 AM Changeset in webkit [146784] by dcheng@chromium.org

3 edits
1 add in trunk

Don't allow drags to start after a mouse press that creates a context menu
https://bugs.webkit.org/show_bug.cgi?id=112079

Reviewed by Tony Chang.

ManualTests/context-menu-during-drag-selection.html: Added.

Source/WebCore:

This appears to be the intent of the original code anyway (the comments in the corresponding
context menu handlers indicate that they set m_mousePressed to false in order to suppress
drags from starting). Since exact platform behavior differs quite a bit in this area, this
will also make the behavior more consistent across different WebKit implementations.

Manually testable using context-menu-during-drag-selection.html.

page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):

9:36 AM Changeset in webkit [146783] by pdr@google.com

2 edits
1 add in trunk/LayoutTests

[Chromium] Rebaseline svg/custom/marker-orient-auto

Unreviewed rebaseline of test expectations.

platform/chromium-linux-x86/svg/custom/marker-orient-auto-expected.png: Added.
platform/chromium/TestExpectations:

9:29 AM Changeset in webkit [146782] by vsevik@chromium.org

6 edits in trunk

Web Inspector: [Regression] Provisional breakpoints are not shown on reload.
https://bugs.webkit.org/show_bug.cgi?id=113210

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._restoreBreakpoints):
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):
(WebInspector.BreakpointManager.prototype._breakpointResolved):

inspector/front-end/utilities.js:

LayoutTests:

inspector/debugger/breakpoint-manager-expected.txt:
inspector/debugger/breakpoint-manager.html:

9:28 AM Changeset in webkit [146781] by commit-queue@webkit.org

8 edits in trunk

Web Inspector: Remove console warnings for *_ prefixed CSS styles
https://bugs.webkit.org/show_bug.cgi?id=113175

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

Source/WebCore:

Added separate error message for syntax CSS error in declaration list when no property detected.
Added filter for messages starting with '*'.

css/CSSGrammar.y.in:

LayoutTests:

inspector/console/console-css-warnings-expected.txt:
inspector/console/console-css-warnings.html:

9:16 AM Changeset in webkit [146780] by jochen@chromium.org

2 edits in trunk/LayoutTests

Triage more test failures on content_shell

Unreviewed gardening.

platform/chromium/ContentShellTestExpectations:

9:10 AM Changeset in webkit [146779] by commit-queue@webkit.org

9 edits
1 add in trunk

Integration of the Skia displacement mapping into WebKit
https://bugs.webkit.org/show_bug.cgi?id=112927

Patch by Alexis Hetu <sugoi@chromium.org> on 2013-03-25
Reviewed by Stephen White.

Added displacement mapping to effect-reference.html and
effect-reference-hw.html

WebCore.gypi:
platform/graphics/filters/FEDisplacementMap.h:

(FEDisplacementMap):
Adding Skia specific declarations

platform/graphics/filters/skia/FEDisplacementMapSkia.cpp: Added.

(WebCore):
(WebCore::toSkiaMode):
Provides conversion between the WebKit displacement mapping mode and
the Skia displacement mapping mode
(WebCore::FEDisplacementMap::platformApplySkia):
Displacement through the Skia API. (Accelerated only for now)
(WebCore::FEDisplacementMap::createImageFilter):
Displacement image filter creation through the Skia API.

9:05 AM Changeset in webkit [146778] by dominik.rottsches@intel.com

3 edits
2 deletes in trunk/Tools

[HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
https://bugs.webkit.org/show_bug.cgi?id=112166

HarfBuzz 0.9.14 merged my patch for icu detection without
pkg-config files, as needed by for example Ubuntu 12.04.
This obsoletes our local workaround. Removed it for GTK and EFL.

Reviewed by Martin Robinson.

efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.

9:01 AM Changeset in webkit [146777] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Graduate some new Inspector APIs to public
https://bugs.webkit.org/show_bug.cgi?id=113176

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

Summary of changes:

DOM.highlightNode.nodeId: required parameter is now optional
Input: domain has been added
Runtime.enable: command has been added
Runtime.executionContextCreated: event has been added
Page.clearGeolocationOverride: command has been added
Page.setGeolocationOverride: command has been added
Page.captureScreenshot: command has been added
Debugger.setBreakpointByUrl.locations: optional response parameter is now required

inspector/Inspector.json:

8:56 AM Changeset in webkit [146776] by kadam@inf.u-szeged.hu

341 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png results.

platform/qt/css3/selectors3/xhtml/css3-modsel-146a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-146b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-147a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-147b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-14c-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-14e-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-15-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-150-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-153-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-159-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-15c-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-16-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-161-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-168-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-168a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-169-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-169a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-172a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-172b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-173a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-173b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-18-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-181-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-183-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-18b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-19-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-20-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-21-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-22-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-28-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-29-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-3-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-30-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-31-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-32-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-33-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-34-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-35-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-36-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-37-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-38-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-39-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-39a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-39b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-39c-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-41-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-41a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-42-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-42a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-43-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-43b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-44-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-44b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-45-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-45b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-46-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-46b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-47-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-48-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-49-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-51-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-52-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-53-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-54-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-55-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-56-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-57-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-57b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-59-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-60-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-62-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-63-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-64-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-65-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-66-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-67-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-7-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-72-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-72b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-73-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-74-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-75-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-75b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-76-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-76b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-77-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-77b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-78-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-78b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-79-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-8-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-80-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-81-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-81b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-82-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-82b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-87-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-87b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-9-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-90-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-90b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-93-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-94-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-94b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-95-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-96-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-96b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-97-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-97b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-98-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-98b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-99-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-99b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-d4-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-1-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-10-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-100-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-100b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-101-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-101b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-102-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-102b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-103-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-103b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-104-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-104b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-105-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-105b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-106-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-106b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-107-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-107b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-108-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-108b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-109-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-109b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-11-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-110-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-110b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-111-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-111b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-112-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-112b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-113-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-113b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-114-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-114b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-115-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-115b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-116-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-116b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-117-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-117b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-118-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-119-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-120-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-121-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-122-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-123-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-124-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-124b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-125-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-125b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-126-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-126b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-127-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-127b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-128-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-128b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-129-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-129b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-13-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-130-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-130b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-131-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-131b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-132-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-132b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-133-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-133b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-134-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-134b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-135-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-135b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-136-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-136b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-137-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-137b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-138-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-138b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-139-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-139b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-14-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-140-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-140b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-141-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-141b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-142-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-142b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-143-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-143b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-145a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-145b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-146a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-146b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-147a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-147b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-14c-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-14e-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-15-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-150-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-153-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-159-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-15c-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-16-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-161-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-168-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-168a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-169-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-169a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-172a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-172b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-173a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-173b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-18-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-181-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-183-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-18b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-19-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-19b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-20-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-21-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-22-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-28-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-28b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-29-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-29b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-3-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-30-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-31-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-32-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-33-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-34-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-35-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-36-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-37-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-38-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-39-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-39a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-39b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-39c-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-3a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-41-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-41a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-42-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-42a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-43-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-43b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-44-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-44b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-45-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-45b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-46-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-46b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-47-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-48-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-49-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-51-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-52-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-53-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-54-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-55-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-56-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-57-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-57b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-59-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-60-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-61-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-62-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-63-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-64-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-65-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-66-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-67-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-7-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-72-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-72b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-73-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-73b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-74-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-74b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-75-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-75b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-76-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-76b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-77-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-77b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-78-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-78b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-79-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-8-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-80-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-81-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-81b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-82-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-82b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-87-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-87b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-9-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-90-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-90b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-93-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-94-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-94b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-95-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-96-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-96b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-97-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-97b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-98-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-98b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-99-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-99b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-d4-expected.png:
platform/qt/css3/unicode-bidi-isolate-basic-expected.png:

8:34 AM Changeset in webkit [146775] by kadam@inf.u-szeged.hu

198 edits
5 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png resutls after r146206.

platform/qt/css3/compositing/effect-background-blend-mode-expected.png: Added.
platform/qt/css3/css3-modsel-33-expected.png:
platform/qt/css3/css3-modsel-35-expected.png:
platform/qt/css3/css3-modsel-36-expected.png:
platform/qt/css3/css3-modsel-37-expected.png:
platform/qt/css3/filters/custom/custom-filter-color-matrix-expected.png: Added.
platform/qt/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
platform/qt/css3/filters/effect-invert-hw-expected.png:
platform/qt/css3/filters/filter-repaint-child-layers-expected.png: Added.
platform/qt/css3/filters/nested-filter-expected.png:
platform/qt/css3/filters/regions-expanding-expected.png:
platform/qt/css3/flexbox/flexbox-baseline-expected.png:
platform/qt/css3/images/cross-fade-background-size-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-1-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-10-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-11-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-13-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-14-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-14c-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-14e-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-15-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-150-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-159-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-16-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-161-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-168-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-168a-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-169-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-169a-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-18-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-181-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-183-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-18b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-19-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-19b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-20-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-21-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-22-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-28-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-28b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-29-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-29b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-30-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-31-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-32-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-33-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-34-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-35-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-36-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-37-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-38-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-39-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-39a-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-39b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-39c-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-3a-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-41-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-41a-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-42-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-42a-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-43-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-43b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-44-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-44b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-45-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-45b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-46-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-46b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-54-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-55-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-56-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-59-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-60-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-61-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-62-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-63-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-64-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-65-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-66-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-67-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-7-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-72-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-72b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-73-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-73b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-74-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-74b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-75-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-75b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-76-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-76b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-77-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-77b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-78-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-78b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-79-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-8-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-80-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-81-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-81b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-82-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-82b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-87-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-87b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-9-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-90-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-90b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-d4-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-1-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-10-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-100-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-100b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-101-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-101b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-102-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-102b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-103-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-103b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-104-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-104b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-105-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-105b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-106-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-106b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-107-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-107b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-108-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-108b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-109-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-109b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-11-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-110-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-110b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-111-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-111b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-112-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-112b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-113-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-113b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-114-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-114b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-115-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-115b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-116-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-116b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-117-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-117b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-118-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-119-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-120-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-121-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-122-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-123-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-124-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-124b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-125-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-125b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-126-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-126b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-127-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-127b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-128-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-128b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-129-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-129b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-13-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-130-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-130b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-131-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-131b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-132-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-132b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-133-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-133b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-134-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-134b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-135-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-135b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-136-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-136b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-137-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-137b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-138-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-138b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-139-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-139b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-14-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-140-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-140b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-141-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-141b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-142-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-142b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-143-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-143b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-145a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-145b-expected.png:

8:25 AM Changeset in webkit [146774] by ddkilzer@apple.com

2 edits in trunk/Source/WTF

WTF::binarySearchImpl() should compile with -Wshorten-64-to-32
<http://webkit.org/b/113170>

Reviewed by Dan Bernstein.

Fixes the following build failure:

/usr/local/include/wtf/StdLibExtras.h:190:30: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]

int pos = (size - 1) >> 1;

~ ~^~

1 error generated.

wtf/StdLibExtras.h:

(WTF::binarySearchImpl): Switch type from int to size_t.

8:09 AM Changeset in webkit [146773] by kadam@inf.u-szeged.hu

123 edits
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png results r146206.

platform/qt-5.0-wk2/css2.1/t0905-c414-flt-01-d-g-expected.png: Added.
platform/qt-5.0-wk2/css2.1/t1004-c5524-width-00-b-g-expected.png: Added.
platform/qt/css2.1/20110323/absolute-non-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-height-002-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-height-008-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-001-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-002-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-003-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-004-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-005-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-007-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-008-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-009-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-010-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-011-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-012-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-013-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-014-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-015-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-016-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-017-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-018-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-019-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-020-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-021-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-022-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-023-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-024-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-008-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-009-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-010-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-016-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-017-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-022-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-023-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-024-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-029-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-030-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-031-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-001-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-008-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-013-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-015-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-020-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-022-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-027-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-029-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-034-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-036-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-041-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-043-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-048-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-050-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-055-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-057-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-062-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-064-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-069-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-071-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-076-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-height-002-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-height-005-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-height-006-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-width-005-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-width-007-expected.png:
platform/qt/css2.1/20110323/block-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/block-replaced-width-001-expected.png:
platform/qt/css2.1/20110323/block-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/border-conflict-style-079-expected.png:
platform/qt/css2.1/20110323/border-conflict-style-088-expected.png:
platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.png:
platform/qt/css2.1/20110323/empty-inline-003-expected.png:
platform/qt/css2.1/20110323/float-non-replaced-width-007-expected.png:
platform/qt/css2.1/20110323/float-non-replaced-width-008-expected.png:
platform/qt/css2.1/20110323/float-non-replaced-width-009-expected.png:
platform/qt/css2.1/20110323/float-non-replaced-width-010-expected.png:
platform/qt/css2.1/20110323/float-non-replaced-width-011-expected.png:
platform/qt/css2.1/20110323/float-non-replaced-width-012-expected.png:
platform/qt/css2.1/20110323/float-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/float-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/float-replaced-width-011-expected.png:
platform/qt/css2.1/20110323/floating-replaced-height-008-expected.png:
platform/qt/css2.1/20110323/inline-block-non-replaced-width-002-expected.png:
platform/qt/css2.1/20110323/inline-block-non-replaced-width-003-expected.png:
platform/qt/css2.1/20110323/inline-block-non-replaced-width-004-expected.png:
platform/qt/css2.1/20110323/inline-block-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.png:
platform/qt/css2.1/20110323/inline-block-replaced-width-001-expected.png:
platform/qt/css2.1/20110323/inline-block-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/inline-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/inline-replaced-height-008-expected.png:
platform/qt/css2.1/20110323/inline-replaced-width-001-expected.png:
platform/qt/css2.1/20110323/inline-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/inline-replaced-width-014-expected.png:
platform/qt/css2.1/20110323/inline-replaced-width-015-expected.png:
platform/qt/css2.1/20110323/margin-applies-to-010-expected.png:
platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.png:
platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
platform/qt/css2.1/20110323/table-caption-002-expected.png:
platform/qt/css2.1/20110323/table-caption-optional-001-expected.png:
platform/qt/css2.1/20110323/table-caption-optional-002-expected.png:
platform/qt/css2.1/20110323/table-height-algorithm-023-expected.png:
platform/qt/css2.1/20110323/table-height-algorithm-024-expected.png:
platform/qt/css2.1/20110323/width-non-replaced-inline-001-expected.png:
platform/qt/css2.1/t051103-c21-activ-ln-00-e-i-expected.png:
platform/qt/css2.1/t051103-c21-hover-ln-00-e-i-expected.png:
platform/qt/css2.1/t060403-c21-pseu-cls-00-e-i-expected.png:
platform/qt/css2.1/t060403-c21-pseu-id-00-e-i-expected.png:
platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/qt/css2.1/t1202-counters-08-b-expected.png:
platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
platform/qt/css2.1/t1508-c527-font-07-b-expected.png:
platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.png:
platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.png:
platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.png:
platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.png:

7:50 AM Changeset in webkit [146772] by kadam@inf.u-szeged.hu

68 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated png results after r146206.

platform/qt/css1/basic/class_as_selector-expected.png:
platform/qt/css1/basic/comments-expected.png:
platform/qt/css1/basic/contextual_selectors-expected.png:
platform/qt/css1/basic/grouping-expected.png:
platform/qt/css1/basic/id_as_selector-expected.png:
platform/qt/css1/box_properties/acid_test-expected.png:
platform/qt/css1/box_properties/border_bottom_inline-expected.png:
platform/qt/css1/box_properties/border_bottom_width-expected.png:
platform/qt/css1/box_properties/border_bottom_width_inline-expected.png:
platform/qt/css1/box_properties/border_color-expected.png:
platform/qt/css1/box_properties/border_color_inline-expected.png:
platform/qt/css1/box_properties/border_inline-expected.png:
platform/qt/css1/box_properties/border_left_inline-expected.png:
platform/qt/css1/box_properties/border_left_width_inline-expected.png:
platform/qt/css1/box_properties/border_right-expected.png:
platform/qt/css1/box_properties/border_right_width_inline-expected.png:
platform/qt/css1/box_properties/border_style_inline-expected.png:
platform/qt/css1/box_properties/border_top_inline-expected.png:
platform/qt/css1/box_properties/border_top_width-expected.png:
platform/qt/css1/box_properties/border_top_width_inline-expected.png:
platform/qt/css1/box_properties/border_width-expected.png:
platform/qt/css1/box_properties/border_width_inline-expected.png:
platform/qt/css1/box_properties/clear-expected.png:
platform/qt/css1/box_properties/float-expected.png:
platform/qt/css1/box_properties/float_elements_in_series-expected.png:
platform/qt/css1/box_properties/height-expected.png:
platform/qt/css1/box_properties/margin-expected.png:
platform/qt/css1/box_properties/margin_bottom-expected.png:
platform/qt/css1/box_properties/margin_bottom_inline-expected.png:
platform/qt/css1/box_properties/margin_left_inline-expected.png:
platform/qt/css1/box_properties/margin_right_inline-expected.png:
platform/qt/css1/box_properties/margin_top-expected.png:
platform/qt/css1/box_properties/margin_top_inline-expected.png:
platform/qt/css1/box_properties/padding-expected.png:
platform/qt/css1/box_properties/padding_left_inline-expected.png:
platform/qt/css1/box_properties/padding_right_inline-expected.png:
platform/qt/css1/box_properties/padding_top-expected.png:
platform/qt/css1/box_properties/padding_top_inline-expected.png:
platform/qt/css1/box_properties/width-expected.png:
platform/qt/css1/classification/list_style-expected.png:
platform/qt/css1/classification/list_style_image-expected.png:
platform/qt/css1/classification/list_style_position-expected.png:
platform/qt/css1/classification/list_style_type-expected.png:
platform/qt/css1/classification/white_space-expected.png:
platform/qt/css1/color_and_background/background-expected.png:
platform/qt/css1/color_and_background/background_attachment-expected.png:
platform/qt/css1/color_and_background/background_color-expected.png:
platform/qt/css1/color_and_background/background_image-expected.png:
platform/qt/css1/color_and_background/color-expected.png:
platform/qt/css1/font_properties/font_family-expected.png:
platform/qt/css1/font_properties/font_size-expected.png:
platform/qt/css1/font_properties/font_style-expected.png:
platform/qt/css1/font_properties/font_variant-expected.png:
platform/qt/css1/font_properties/font_weight-expected.png:
platform/qt/css1/formatting_model/canvas-expected.png:
platform/qt/css1/formatting_model/floating_elements-expected.png:
platform/qt/css1/formatting_model/height_of_lines-expected.png:
platform/qt/css1/formatting_model/horizontal_formatting-expected.png:
platform/qt/css1/formatting_model/replaced_elements-expected.png:
platform/qt/css1/text_properties/letter_spacing-expected.png:
platform/qt/css1/text_properties/line_height-expected.png:
platform/qt/css1/text_properties/text_align-expected.png:
platform/qt/css1/text_properties/vertical_align-expected.png:
platform/qt/css1/text_properties/word_spacing-expected.png:
platform/qt/css1/units/color_units-expected.png:
platform/qt/css1/units/length_units-expected.png:
platform/qt/css1/units/percentage_units-expected.png:

7:42 AM Changeset in webkit [146771] by caseq@chromium.org

4 edits in trunk

Web Inspector: [Timeline] set glue records mode off by default
https://bugs.webkit.org/show_bug.cgi?id=113189

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/TimelinePanel.js: /glueRecordsSetting/s/true/false/

LayoutTests:

inspector/timeline/timeline-receive-response-event.html: enable glue records mode for the test.

7:29 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu

Removing Amazon bot after its shutdown. (diff)

7:27 AM Changeset in webkit [146770] by gyuyoung.kim@samsung.com

5 edits in trunk/Source/WebCore

[EFL] Fix build break when media source is enabled
https://bugs.webkit.org/show_bug.cgi?id=113143

Unreviewed. Build error needs to be fixed in order to start to implement
media source functionality.

CMakeLists.txt:
platform/efl/MIMETypeRegistryEfl.cpp:

(WebCore):
(WebCore::MIMETypeRegistry::isSupportedMediaSourceMIMEType):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::load):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

7:26 AM Changeset in webkit [146769] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Toggling breakpoint with shortcut should be freezed as well while editing.
https://bugs.webkit.org/show_bug.cgi?id=113188

Reviewed by Pavel Feldman.

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.toggleBreakpointOnCurrentLine):

7:23 AM Changeset in webkit [146768] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Remove unneeded code from JavaScriptSourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=113182

Reviewed by Pavel Feldman.

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):

6:56 AM Changeset in webkit [146767] by commit-queue@webkit.org

9 edits in trunk/Source

Web Inspector: Fonts refactoring
https://bugs.webkit.org/show_bug.cgi?id=113047

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

Unify fonts usage across inspector.
Make inspector default font depend on platform.

Source/WebCore:

inspector/front-end/dataGrid.css:

(.data-grid table):
(.data-grid td):

inspector/front-end/inspector.css:

(.toolbar-label):
(body.show-toolbar-icons .toolbar-label):
(.console-message .bubble):
(li .status .bubble):
(.source-frame-breakpoint-message):
(.soft-context-menu):

inspector/front-end/inspectorCommon.css:

(body):

inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid td):
(.network-log-grid.data-grid.small td):

inspector/front-end/tabbedPane.css:

(.tabbed-pane-header-tab):
(select.tabbed-pane-header-tabs-drop-down-select):

inspector/front-end/timelinePanel.css:

(.memory-counter-value):

Source/WebKit/chromium:

src/js/devTools.css:

(body.platform-linux):
(body.platform-mac):
(body.platform-windows):

6:54 AM Changeset in webkit [146766] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

[Qt] Qml WebKit needs preferences to change security knobs
https://bugs.webkit.org/show_bug.cgi?id=111979

Patch by Maxim Ermilov <maxim.ermilov@canonical.com> on 2013-03-25
Reviewed by Jocelyn Turcotte.

UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::universalAccessFromFileURLsAllowed):
(QWebPreferences::setUniversalAccessFromFileURLsAllowed):
(QWebPreferences::fileAccessFromFileURLsAllowed):
(QWebPreferences::setFileAccessFromFileURLsAllowed):

UIProcess/API/qt/qwebpreferences_p.h:
UIProcess/API/qt/qwebpreferences_p_p.h:

6:52 AM Changeset in webkit [146765] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Use generate-inspector-protocol-version to list valid public API changes
https://bugs.webkit.org/show_bug.cgi?id=113148

Added --show-changes command line option.
Used existing compare_schemas method to do a reverse compare.
Fixed a number of small problems (missing domain name in the message,
incorrect error messages for command parameters).

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

inspector/generate-inspector-protocol-version:

(named_list_to_map):
(removed):
(required):
(compare_schemas):
(compare_domains):
(compare_commands):
(compare_events):
(compare_params_list):
(compare_types):
(self_test):
(self_test.create_test_schema_1):
(self_test.create_test_schema_2):
(self_test.is_subset):
(self_test.errors_match):
(main):

6:42 AM Changeset in webkit [146764] by alecflett@chromium.org

17 edits
9 adds in trunk

Support Quota API in Workers
https://bugs.webkit.org/show_bug.cgi?id=112972

Reviewed by Adam Barth.

Source/WebCore:

Tests: fast/workers/shared-worker-storagequota-query-usage.html

fast/workers/worker-storagequota-query-usage.html

Modules/quota/WorkerNavigatorStorageQuota.cpp: Added.
Modules/quota/WorkerNavigatorStorageQuota.h: Added.
Modules/quota/WorkerNavigatorStorageQuota.idl: Added.
WebCore.gypi: Add entries for WorkerNavigatorStorageQuota.
page/WorkerNavigator.h: Add a Navigator supplement that extends the worker navigator.

LayoutTests:

fast/workers/resources/shared-worker-common.js:

(handleMessage): Allow port to be dynamically discovered from self.

fast/workers/resources/storagequota-query-usage.js: Added.

(worker.onmessage):

fast/workers/resources/worker-storagequota-query-usage.js: Added.

(requestUsage.errorCallback):
(requestUsage.usageCallback):
(requestUsage):

fast/workers/shared-worker-storagequota-query-usage-expected.txt: Added.
fast/workers/shared-worker-storagequota-query-usage.html: Added.
fast/workers/worker-storagequota-query-usage-expected.txt: Added.
fast/workers/worker-storagequota-query-usage.html: Added.

6:39 AM Changeset in webkit [146763] by mkwst@chromium.org

15 edits in trunk

CSP 1.1: Rename SecurityPolicyViolationEvent::sourceURL to ::sourceFile.
https://bugs.webkit.org/show_bug.cgi?id=113033

Reviewed by Jochen Eisinger.

Source/WebCore:

Bringing our experimental implementation into line with the spec, which
has landed on the de facto standard name Gecko has been sending out for
years and years.

Spec: https://dvcs.w3.org/hg/content-security-policy/rev/e44f4003e158
Thread: http://lists.w3.org/Archives/Public/public-webappsec/2013Mar/0087.html

dom/SecurityPolicyViolationEvent.h:

(SecurityPolicyViolationEventInit):
(WebCore::SecurityPolicyViolationEvent::sourceFile):
(WebCore::SecurityPolicyViolationEvent::SecurityPolicyViolationEvent):
(SecurityPolicyViolationEvent):

dom/SecurityPolicyViolationEvent.idl:
page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):

s/sourceURL/sourceFile/

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html:

6:10 AM Changeset in webkit [146762] by Michelangelo De Simone

8 edits
20 adds in trunk

[CSS Filters] Using negative drop-shadow radius values has slow performance
https://bugs.webkit.org/show_bug.cgi?id=107848

Source/WebCore:

Setting negative blur radius values in drop-shadow() and box-shadow() led to
significant rendering performance loss. The invalid value overflowed and the
embedder became unresponsive for few seconds.
This impacted SVG too (SVGFEDropShadow and SVGFEGaussianBlur).

Reviewed by Dirk Schulze.

Tests: css3/filters/effect-drop-shadow-negative-radius.html

fast/box-shadow/box-shadow-parsing-invalid.html
svg/filters/feDropShadow-negative-deviation-expected.svg
svg/filters/feDropShadow-negative-deviation.svg
svg/filters/feDropShadow-zero-deviation.svg
svg/filters/feGaussianBlur-negative-deviation-expected.svg
svg/filters/feGaussianBlur-negative-deviation.svg
svg/filters/feGaussianBlur-zero-deviation.svg

css/CSSParser.cpp:

(WebCore::CSSParser::parseShadow): Negative values are skipped during parsing: as per
CSS Background and Borders specs, negative values shall not be allowed.

platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::calculateUnscaledKernelSize): Added "non-negative" assertion for
negative deviations.

svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::build): If a negative standard deviation is encountered, don't
build the filter and returns earlier, this avoids unnecessary calls: FEGaussianBlur is not being
created with wrong and potentially overflowing values.

svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::build): Ditto.

LayoutTests:

Added a whole set of new tests for both CSS and SVG to assess the correctness of
blur(), drop-shadow() and box-shadow() blur radius values.

Reviewed by Dirk Schulze.

css3/filters/effect-drop-shadow-negative-radius-expected.html: Added.
css3/filters/effect-drop-shadow-negative-radius.html: Added.
css3/filters/filter-property-parsing-invalid-expected.txt:
css3/filters/script-tests/filter-property-parsing-invalid.js:
fast/box-shadow/box-shadow-parsing-invalid-expected.txt: Added.
fast/box-shadow/box-shadow-parsing-invalid.html: Added.
fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: Added.

(testInvalidFilterRule):

platform/chromium/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
platform/chromium/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
platform/chromium/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
platform/chromium/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
platform/mac/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
platform/mac/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
svg/filters/feDropShadow-negative-deviation-expected.svg: Added.
svg/filters/feDropShadow-negative-deviation.svg: Added.
svg/filters/feDropShadow-zero-deviation.svg: Added.
svg/filters/feGaussianBlur-negative-deviation-expected.svg: Added.
svg/filters/feGaussianBlur-negative-deviation.svg: Added.
svg/filters/feGaussianBlur-zero-deviation.svg: Added.

6:06 AM Changeset in webkit [146761] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r146630): 8 text related test asserts on debug builds
https://bugs.webkit.org/show_bug.cgi?id=113179

Reviewed by Jocelyn Turcotte.

Test if range.start is within the valid range before testing the value at that point.

platform/graphics/qt/FontQt.cpp:

(WebCore::Font::initFormatForTextLayout):

5:55 AM Changeset in webkit [146760] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Properly handle the rule addition to an XML or SVG document.
https://bugs.webkit.org/show_bug.cgi?id=113185

Reviewed by Pavel Feldman.

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

5:38 AM Changeset in webkit [146759] by commit-queue@webkit.org

6 edits
3 adds in trunk

Web Inspector: support changing local variables in frontend
https://bugs.webkit.org/show_bug.cgi?id=112470

Patch by Peter Rybin <prybin@chromium.org> on 2013-03-25
Reviewed by Yury Semikhatsky.

Source/WebCore:

ScopeRef type is added to RemoteObject and setPropertyValue is patched accordingly.

Test: inspector/debugger/debugger-change-variable.html

inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.CallFrame.prototype.get id):

inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):

inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromScopePayload):
(WebInspector.RemoteObject.prototype.):
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.setVariableValueCallback):
(WebInspector.RemoteObject.prototype._setDeclarativeVariableValue):
(WebInspector.ScopeRef):

inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

LayoutTests:

inspector/debugger/debugger-change-variable-expected.txt: Added.
inspector/debugger/debugger-change-variable.html: Added.
platform/chromium/inspector/debugger/debugger-change-variable-expected.txt: Added.

5:20 AM Changeset in webkit [146758] by mkwst@chromium.org

5 edits
3 copies
8 adds in trunk

CSP 1.1: Strip URLs in SecurityPolicyViolationEvents, just as we do for POSTed violation reports.
https://bugs.webkit.org/show_bug.cgi?id=113039

Reviewed by Jochen Eisinger.

Source/WebCore:

I'd originally assumed that we didn't need to be quite so careful when
handing URLs to JavaScript via SecurityPolicyViolationEvents. This was
a mistake. Cross-origin URLs aren't accessible to JavaScript currently
and there's no reason that we should begin exposing them via an event.

This patch extracts the stripping logic from the existing reports into
stripURLForUseInReport(), and uses that new method when populating the
event and report objects.

Relatedly, we were doing the wrong thing with 'file:' URLs, which this
patch made clear. Now they're treated the same as 'data:' et al.

Spec: https://dvcs.w3.org/hg/content-security-policy/rev/45f6ccaba0ef

Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html

http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html

page/ContentSecurityPolicy.cpp:

(WebCore::stripURLForUseInReport):

Extract the logic from blockedURI out into a reusable method:
cross-origin URLs are stripped down to the ASCII serialization of
their origin, and non-heirarchical (and 'file:') URLs are stripped
down to the ASCII serialization of their protocol.

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

Use ::stripURLForUseInReport for blockedURL and sourceFile
attributes in these two methods.

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html: Added.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html: Added.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html: Added.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html:
http/tests/security/contentSecurityPolicy/resources/securitypolicyviolation-test.js: Added.

Updating tests to cover cross-origin scenarios: load cross-origin
images, and cross-origin scripts that inject images. The former
should strip the image URL down to the origin, the latter the
script URL.

http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html: Added.
platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.

This patch changes the behavior of 'file:' URLs to behave similarly
to 'data:'/'blob:', etc. We weren't previously testing this, now we
are. We need platform-specific results for Chromium and GTK, since
those ports have enabled CSP_NEXT, which adds a field to the report.

4:35 AM Changeset in webkit [146757] by eustas@chromium.org

8 edits in trunk/Source/WebCore

Web Inspector: Fix JSDocs.
https://bugs.webkit.org/show_bug.cgi?id=113025

Reviewed by Pavel Feldman.

Next version of JS compiler finds more inconsistencies
and ambiguous declarations.
Some of them are resolved in this patch.

inspector/InjectedScriptSource.js: Fix JSDocs.
inspector/front-end/ConsoleModel.js: Ditto.
inspector/front-end/CookieParser.js: Ditto.
inspector/front-end/FileContentView.js: Ditto.
inspector/front-end/HeapSnapshotView.js: Ditto.
inspector/front-end/IndexedDBModel.js: Ditto.
inspector/front-end/ProfilesPanelDescriptor.js: Ditto.
inspector/front-end/utilities.js: Ditto.

4:30 AM Changeset in webkit [146756] by zarvai@inf.u-szeged.hu

196 edits
1 copy
14 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Making pixel test bot happier after r146206.

platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.png:
platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.png:
platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-offscreen-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.png:
platform/qt/fast/frames/frame-scrolling-attribute-expected.png:
platform/qt/fast/frames/frameset-style-recalc-expected.png:
platform/qt/fast/frames/iframe-scrolling-attribute-expected.png:
platform/qt/fast/frames/iframe-with-frameborder-expected.png:
platform/qt/fast/frames/viewsource-attribute-expected.png:
platform/qt/fast/gradients/background-clipped-expected.png:
platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
platform/qt/fast/gradients/crash-on-zero-radius-expected.png:
platform/qt/fast/gradients/radial-centered-expected.png:
platform/qt/fast/html/details-nested-1-expected.png:
platform/qt/fast/html/details-nested-2-expected.png:
platform/qt/fast/html/details-writing-mode-expected.png:
platform/qt/fast/html/font-weight-bold-for-b-and-strong-expected.png:
platform/qt/fast/html/link-rel-stylesheet-expected.png:
platform/qt/fast/html/listing-expected.png:
platform/qt/fast/html/marquee-scroll-expected.png:
platform/qt/fast/html/marquee-scrollamount-expected.png:
platform/qt/fast/images/image-map-anchor-children-expected.png:
platform/qt/fast/images/imagemap-circle-focus-ring-expected.png:
platform/qt/fast/images/imagemap-focus-ring-expected.png:
platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.png:
platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png:
platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png:
platform/qt/fast/images/imagemap-polygon-focus-ring-expected.png:
platform/qt/fast/inline-block/001-expected.png:
platform/qt/fast/inline-block/002-expected.png:
platform/qt/fast/inline-block/003-expected.png:
platform/qt/fast/inline-block/006-expected.png:
platform/qt/fast/inline-block/14498-positionForCoordinates-expected.png:
platform/qt/fast/inline-block/contenteditable-baseline-expected.png:
platform/qt/fast/inline-block/tricky-baseline-expected.png:
platform/qt/fast/inline/25277-2-expected.png:
platform/qt/fast/inline/25277-expected.png:
platform/qt/fast/inline/continuation-outlines-with-layers-2-expected.png:
platform/qt/fast/inline/drawStyledEmptyInlines-expected.png:
platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
platform/qt/fast/inline/emptyInlinesWithinLists-expected.png:
platform/qt/fast/inline/inline-continuation-borders-expected.png:
platform/qt/fast/inline/inline-focus-ring-expected.png:
platform/qt/fast/inline/inline-text-quirk-bpm-expected.png:
platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png:
platform/qt/fast/inline/long-wrapped-line-expected.png:
platform/qt/fast/inline/nested-top-alignment-expected.png:
platform/qt/fast/inline/vertical-align-text-bottom-expected.png:
platform/qt/fast/invalid/003-expected.png:
platform/qt/fast/invalid/004-expected.png:
platform/qt/fast/invalid/010-expected.png:
platform/qt/fast/invalid/014-expected.png:
platform/qt/fast/invalid/016-expected.png:
platform/qt/fast/invalid/019-expected.png:
platform/qt/fast/invalid/021-expected.png:
platform/qt/fast/invalid/missing-address-end-tag-expected.png:
platform/qt/fast/invalid/missing-dl-end-tag-expected.png:
platform/qt/fast/invalid/missing-dt-end-tag-expected.png:
platform/qt/fast/invalid/missing-font-end-tag-expected.png:
platform/qt/fast/invalid/nestedh3s-expected.png:
platform/qt/fast/invalid/td-inside-object-expected.png:
platform/qt/fast/layers/inline-dirty-z-order-lists-expected.png:
platform/qt/fast/layers/opacity-transforms-expected.png:
platform/qt/fast/layers/remove-only-this-layer-update-expected.png:
platform/qt/fast/line-grid/line-align-left-edges-expected.png:
platform/qt/fast/line-grid/line-align-right-edges-expected.png:
platform/qt/fast/line-grid/line-grid-floating-expected.png:
platform/qt/fast/line-grid/line-grid-into-floats-expected.png:
platform/qt/fast/line-grid/line-grid-positioned-expected.png:
platform/qt/fast/lists/001-expected.png:
platform/qt/fast/lists/001-vertical-expected.png:
platform/qt/fast/lists/002-expected.png:
platform/qt/fast/lists/002-vertical-expected.png:
platform/qt/fast/lists/007-expected.png:
platform/qt/fast/lists/007-vertical-expected.png:
platform/qt/fast/lists/008-expected.png:
platform/qt/fast/lists/008-vertical-expected.png:
platform/qt/fast/lists/anonymous-items-expected.png:
platform/qt/fast/lists/big-list-marker-expected.png:
platform/qt/fast/lists/li-br-expected.png:
platform/qt/fast/lists/li-style-alpha-huge-value-crash-expected.png:
platform/qt/fast/lists/list-item-line-height-expected.png:
platform/qt/fast/lists/list-style-none-crash-expected.png:
platform/qt/fast/lists/ol-display-types-expected.png:
platform/qt/fast/lists/ol-start-parsing-expected.png:
platform/qt/fast/lists/olstart-expected.png:
platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png:
platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png:
platform/qt/fast/multicol/block-axis-vertical-lr-expected.png:
platform/qt/fast/multicol/block-axis-vertical-rl-expected.png:
platform/qt/fast/multicol/client-rects-expected.png:
platform/qt/fast/multicol/column-break-with-balancing-expected.png:
platform/qt/fast/multicol/column-count-with-rules-expected.png:
platform/qt/fast/multicol/float-avoidance-expected.png:
platform/qt/fast/multicol/float-paginate-complex-expected.png:
platform/qt/fast/multicol/float-paginate-expected.png:
platform/qt/fast/multicol/layers-in-multicol-expected.png:
platform/qt/fast/multicol/margin-collapse-expected.png:
platform/qt/fast/multicol/max-height-columns-block-expected.png:
platform/qt/fast/multicol/overflow-across-columns-expected.png:
platform/qt/fast/multicol/overflow-unsplittable-expected.png:
platform/qt/fast/multicol/paginate-block-replaced-expected.png:
platform/qt/fast/multicol/positioned-split-expected.png:
platform/qt/fast/multicol/positive-leading-expected.png:
platform/qt/fast/multicol/progression-reverse-expected.png:
platform/qt/fast/multicol/shadow-breaking-expected.png:
platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.png:
platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
platform/qt/fast/multicol/table-margin-collapse-expected.png:
platform/qt/fast/multicol/table-vertical-align-expected.png:
platform/qt/fast/multicol/unsplittable-inline-block-expected.png:
platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
platform/qt/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png:
platform/qt/fast/multicol/vertical-lr/float-paginate-expected.png:
platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
platform/qt/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png:
platform/qt/fast/multicol/vertical-rl/float-paginate-expected.png:
platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
platform/qt/fast/overflow/001-expected.png:
platform/qt/fast/overflow/002-expected.png:
platform/qt/fast/overflow/003-expected.png:
platform/qt/fast/overflow/004-expected.png:
platform/qt/fast/overflow/007-expected.png:
platform/qt/fast/overflow/008-expected.png:
platform/qt/fast/overflow/dynamic-hidden-expected.png:
platform/qt/fast/overflow/float-in-relpositioned-expected.png:
platform/qt/fast/overflow/hidden-scrollbar-resize-expected.png:
platform/qt/fast/overflow/line-clamp-expected.png:
platform/qt/fast/overflow/overflow-auto-table-expected.png:
platform/qt/fast/overflow/overflow-float-stacking-expected.png:
platform/qt/fast/overflow/overflow-focus-ring-expected.png:
platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
platform/qt/fast/overflow/overflow-stacking-expected.png:
platform/qt/fast/overflow/paged-x-div-with-column-gap-expected.png:
platform/qt/fast/overflow/position-fixed-transform-clipping-expected.png:
platform/qt/fast/overflow/scrollbar-position-update-expected.png:
platform/qt/fast/overflow/table-overflow-float-expected.png:
platform/qt/fast/overflow/trailing-float-linebox-expected.png:
platform/qt/fast/parser/001-expected.png:
platform/qt/fast/parser/broken-comments-vs-parsing-mode-expected.png:
platform/qt/fast/parser/entity-comment-in-style-expected.png:
platform/qt/fast/parser/nofoo-tags-inside-paragraph-expected.png:
platform/qt/fast/parser/open-comment-in-style-expected.png:
platform/qt/fast/reflections/inline-crash-expected.png:
platform/qt/fast/reflections/opacity-reflection-transform-expected.png:
platform/qt/fast/reflections/reflection-masks-expected.png:
platform/qt/fast/reflections/reflection-masks-opacity-expected.png:
platform/qt/fast/reflections/reflection-masks-outset-expected.png:
platform/qt/fast/reflections/reflection-nesting-expected.png:
platform/qt/fast/reflections/reflection-overflow-hidden-expected.png:
platform/qt/fast/regions/flow-content-basic-expected.png:
platform/qt/fast/regions/flow-content-basic-vertical-expected.png:
platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png:
platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png:
platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.png:
platform/qt/fast/regions/overflow-in-variable-width-regions-expected.png:
platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png:
platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.png:
platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png:
platform/qt/fast/regions/region-style-block-background-color-expected.png:
platform/qt/fast/regions/region-style-block-background-color2-expected.png:
platform/qt/fast/regions/text-region-split-small-pagination-expected.png:
platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png:
platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png:
platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png:
platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png:
platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
platform/qt/fast/repaint/background-misaligned-expected.png:
platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
platform/qt/fast/repaint/focus-layers-expected.png:
platform/qt/fast/repaint/scale-page-shrink-expected.png:
platform/qt/fast/repaint/transform-absolute-child-expected.png:
platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png:
platform/qt/fast/repaint/transform-relative-position-expected.png:
platform/qt/fast/repaint/transform-replaced-shadows-expected.png:
platform/qt/fast/replaced/004-expected.png:
platform/qt/fast/replaced/absolute-position-percentage-height-expected.png:
platform/qt/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
platform/qt/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.png:
platform/qt/fast/replaced/applet-display-none-expected.png:
platform/qt/fast/replaced/image-resize-width-expected.png:

4:05 AM Changeset in webkit [146755] by mkwst@chromium.org

2 edits in trunk/Source/WebCore

Cleanup: Tiny nits in ContentSecurityPolicy::reportViolation.
https://bugs.webkit.org/show_bug.cgi?id=112784

Reviewed by Jochen Eisinger.

Just cleanup of three tiny nits I ran across in
ContentSecurityPolicy::reportViolation while doing other work.

'directiveText' and 'effectiveDirective' can't be empty; we pass in values at every callsite. We can safely remove the 'isEmpty()' checks. Moreover, even if they could possibly somehow be empty, we should still include those empty strings in the report, rather than dropping the values entirely.

We don't need to hold 'document->referrer()' in a temp variable.

page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):

3:55 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com

(diff)

3:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:26 AM Changeset in webkit [146754] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

E: webkitgtk3 missing-sentinel Source/[...]/TestMain.cpp:47 g_build_filename takes a NULL sentinel.
https://bugs.webkit.org/show_bug.cgi?id=113036

Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-03-25
Reviewed by Martin Robinson.

UIProcess/API/gtk/tests/TestMain.cpp:

(removeNonEmptyDirectory):

2:50 AM Changeset in webkit [146753] by eustas@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: [Overview] Make "drag-to-move" feature more discoverable.
https://bugs.webkit.org/show_bug.cgi?id=113032

Reviewed by Pavel Feldman.

To move overview window user could drag-n-drop over
time "ribbon" on OverviewGrid.

This feature is hard to discover.

Setting "move" cursor will make this feature more discoverable.

inspector/front-end/inspectorCommon.css:

Set "move" cursor to draggable area.

inspector/front-end/OverviewGrid.js: Ditto.

2:33 AM Changeset in webkit [146752] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Profiles] Remove unused private member.
https://bugs.webkit.org/show_bug.cgi?id=113015

Reviewed by Pavel Feldman.

_profileGroupsForLinks is not used anymore.

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reset): Removed unused member.

2:33 AM Changeset in webkit [146751] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardneing. Skip two tests, because they are failing with timed out.

platform/qt/TestExpectations:

2:01 AM Changeset in webkit [146750] by yurys@chromium.org

2 edits in trunk/LayoutTests

Mark fast/css/font-family-pictograph.html as flaky on Linux

platform/chromium/TestExpectations:

1:55 AM Changeset in webkit [146749] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Exception when turning on pretty print without any displayed source in the editor
https://bugs.webkit.org/show_bug.cgi?id=113136

Patch by PhistucK <phistuck@chromium.org> on 2013-03-25
Reviewed by Vsevolod Vlasov.

No new tests.
Added a check for the existence of currently edited document.

inspector/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

1:47 AM Changeset in webkit [146748] by mihnea@adobe.com

2 edits in trunk/Source/WebCore

[CSSRegions] Remove RenderRegion::printRegionObjectsStyles
https://bugs.webkit.org/show_bug.cgi?id=113081

Reviewed by Tony Chang.

No change in functionality, remove unused function..

rendering/RenderRegion.h:

1:45 AM Changeset in webkit [146747] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Texmap] Memory leak when closing a tab
https://bugs.webkit.org/show_bug.cgi?id=112127

Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2013-03-25
Reviewed by Noam Rosenthal.

When closing a tab, if there are any updates pending in CoordinatedGraphicsScene's
render queue, the scene is not freed because reference count of m_scene is not zero.

No new tests.

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::detach): When bind updates in CoordinatedGraphicsScene,
the reference count of m_scene is increasing, if m_renderQueue is not empty
before closing tab, then m_scene is never freed.
Hence, when closing tab, need to clear m_renderQueue explicitly in order to
destroy m_scene.

1:21 AM Changeset in webkit [146746] by keishi@webkit.org

3 edits
10 adds in trunk

Clear button visibility is not updated when restoring form state
https://bugs.webkit.org/show_bug.cgi?id=113172

Source/WebCore:

Clear button wasn't showing up when restoring form state.

Reviewed by Kent Tamura.

Tests: fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html

fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html

html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState):

LayoutTests:

Reviewed by Kent Tamura.

fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html: Added.
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html: Added.
fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html: Added.
fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html: Added.

12:45 AM Changeset in webkit [146745] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Settings] Use registry to track settings objects.
https://bugs.webkit.org/show_bug.cgi?id=113008

Reviewed by Pavel Feldman.

Currently .createSetting creates new instance any time it is invoked.
When one instance saves value, the other instance do not know about it.

To resolve this issue we can use registry to make .createSetting return
same object for specific key.

inspector/front-end/Settings.js:

(WebInspector.Settings.prototype.createSetting): Use registry.

Mar 24, 2013:

9:58 PM Changeset in webkit [146744] by falken@chromium.org

9 edits in trunk/Source/WebCore

Refactoring: Pull Node::disabled() and Node::isInert() down to Element.
https://bugs.webkit.org/show_bug.cgi?id=112085

Reviewed by Hajime Morrita.

Node is too low a level for these methods. The plan is to rename
Element::disabled to isDisabledFormControl and to remove
Element::isEnabledFormControl.

No new tests, just refactoring.

dom/Element.cpp:

(WebCore::Element::disabled):
(WebCore):
(WebCore::Element::isInert):

dom/Element.h:

(Element):

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick):

dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

dom/Node.cpp:

(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):

dom/Node.h:

(Node):

9:27 PM Changeset in webkit [146743] by noel.gordon@gmail.com

2 edits in trunk/LayoutTests

[chromium] Mark canvas-toDataURL-webp.html imageOnlyFailure
https://bugs.webkit.org/show_bug.cgi?id=113169

Unreviewed test expectations update.

Start generating test images on the bots now that libwebp 0.3.0
has landed in chromium webkit.

platform/chromium/TestExpectations:

8:55 PM Changeset in webkit [146742] by noel.gordon@gmail.com

2 edits in trunk/LayoutTests

[chromium] fast/text/international/danda-space.html is failing
https://bugs.webkit.org/show_bug.cgi?id=113169

Unreviewed test expectations update.

platform/chromium/TestExpectations:

7:15 PM Changeset in webkit [146741] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146740 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=113113

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-24
Reviewed by Gustavo Noronha Silva (kov).

pl.po: updated translation.

7:14 PM Changeset in webkit [146740] by kov@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=113113

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-24
Reviewed by Gustavo Noronha Silva (kov).

pl.po: updated translation.

6:57 PM Changeset in webkit [146739] by danakj@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium deps to 190311.
https://bugs.webkit.org/show_bug.cgi?id=113161

Unreviewed, rolling deps.

DEPS:

5:38 PM Changeset in webkit [146738] by hayato@chromium.org

1 edit
2 adds in trunk/LayoutTests

[Shadow] Add a test of insertionParent for <shadow> element.
https://bugs.webkit.org/show_bug.cgi?id=113021

Reviewed by Dimitri Glazkov.

fast/dom/shadow/insertion-parent-shadow-expected.txt: Added.
fast/dom/shadow/insertion-parent-shadow.html: Added.

5:36 PM Changeset in webkit [146737] by hclam@chromium.org

4 edits in trunk/Source

GIFImageReader should reports parsing error to client
https://bugs.webkit.org/show_bug.cgi?id=113141

Reviewed by Stephen White.

Source/WebCore:

GIFImageReader nows reports parsing error to client (GIFImageDecoder) such that errors can be handled.
In the case of corrupted GIF images GIFImageReader will be deleted and decoding will fail.

Unit test is updated to reflect change in behavior.
Tested with a local corpus which showed better handling of corrupted GIF images.

platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::decode):

Source/WebKit/chromium:

Updated unit test that runs on a broken GIF image file, decoding should fail.

tests/GIFImageDecoderTest.cpp:

(WebKit::TEST):

4:37 PM Changeset in webkit [146736] by jamesr@google.com

5 edits in trunk/Source

[chromium] Wire windows scrollByPage enum up to compositor thread input handling
https://bugs.webkit.org/show_bug.cgi?id=113117

Reviewed by Adrienne Walker.

Source/Platform:

chromium/public/WebInputHandlerClient.h:

Source/WebKit/chromium:

src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):

tests/WebCompositorInputHandlerImplTest.cpp:

(MockWebInputHandlerClient):

4:15 PM Changeset in webkit [146735] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r190276. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-24

DEPS:

3:45 PM Changeset in webkit [146734] by mhahnenberg@apple.com

12 edits
2 adds in trunk/Source/JavaScriptCore

HandleSet should use HeapBlocks for storing handles
https://bugs.webkit.org/show_bug.cgi?id=113145

Reviewed by Geoffrey Garen.

GNUmakefile.list.am: Build project changes.
JavaScriptCore.gypi: Ditto.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Ditto.
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
heap/BlockAllocator.cpp: Rename the RegionSet to m_fourKBBlockRegionSet because there are

too many block types to include them all in the name now.
(JSC::BlockAllocator::BlockAllocator):

heap/BlockAllocator.h:

(BlockAllocator): Add the appropriate override for regionSetFor.
(JSC::WeakBlock):
(JSC::MarkStackSegment):
(JSC::HandleBlock):

heap/HandleBlock.h: Added.

(HandleBlock): New class for HandleBlocks.
(JSC::HandleBlock::blockFor): Static method to get the block of the given HandleNode pointer. Allows
us to quickly figure out which HandleSet the HandleNode belongs to without storing the pointer to it
in the HandleNode.
(JSC::HandleBlock::handleSet): Getter.

heap/HandleBlockInlines.h: Added.

(JSC::HandleBlock::create):
(JSC::HandleBlock::HandleBlock):
(JSC::HandleBlock::payloadEnd):
(JSC::HandleBlock::payload):
(JSC::HandleBlock::nodes):
(JSC::HandleBlock::nodeAtIndex):
(JSC::HandleBlock::nodeCapacity):

heap/HandleSet.cpp:

(JSC::HandleSet::~HandleSet):
(JSC::HandleSet::grow):

heap/HandleSet.h:

(HandleNode): Move the internal Node class from HandleSet to be its own public class so it can be
used by HandleBlock.
(HandleSet): Add a typedef so that Node refers to the new HandleNode class.
(JSC::HandleSet::toHandle):
(JSC::HandleSet::toNode):
(JSC::HandleSet::allocate):
(JSC::HandleSet::deallocate):
(JSC::HandleNode::HandleNode):
(JSC::HandleNode::slot):
(JSC::HandleNode::handleSet): Use the new blockFor static function to get the right HandleBlock and lookup
the HandleSet.
(JSC::HandleNode::setPrev):
(JSC::HandleNode::prev):
(JSC::HandleNode::setNext):
(JSC::HandleNode::next):
(JSC::HandleSet::forEachStrongHandle):

heap/Heap.h: Friend HandleSet so that it can access the BlockAllocator when allocating HandleBlocks.

12:16 PM Changeset in webkit [146733] by kareng@chromium.org

9 edits
2 copies in branches/chromium/1451/Source/WebCore

Revert 146458 "[EFL][WebGL] Implement a common GraphicsSurface I..."

[EFL][WebGL] Implement a common GraphicsSurface Implementation.
https://bugs.webkit.org/show_bug.cgi?id=111759

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This is in preparation to add transport surface support for GLES2.
This patch makes it easy to share the core logic of using
Transport Surface and client on GLX and GLES2 backends without
any code duplication.

PlatformEfl.cmake:
platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::releaseResources):
(WebCore::GraphicsContext3DPrivate::prepareBuffer):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::didResizeCanvas):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):

platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):

TransportSurface related code is moved to GraphicsSurfaceCommon.
As GraphicsSurface is deleted on resize, added logic to ensure that
current buffer is not deleted before having the shared buffer
with correct size. This would avoid any flashing during resize.

platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createTransportSurface):

platform/graphics/opengl/GLPlatformSurface.h:
platform/graphics/surfaces/efl/GLTransportSurface.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp.
(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):
(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::~GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::destroy):
(WebCore::GLTransportSurfaceClient::prepareTexture):
(WebCore::GLTransportSurfaceClient::createTexture):

platform/graphics/surfaces/efl/GLTransportSurface.h: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.h.
(WebCore):
(GLTransportSurface):
(GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::texture):
(WebCore::GLTransportSurfaceClient::hasAlpha):

Moved TransportSurface to EFL folder as this is being used by EFL port only.
Added a base class for TransportSurfaceClient.

platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp: Added.
(WebCore):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::destroy):
(WebCore::GraphicsSurfacePrivate::initializeTransportSurface):
(WebCore::GraphicsSurfacePrivate::makeContextCurrent):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::handle):
(WebCore::GraphicsSurfacePrivate::updateClientBuffer):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::rect):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::textureId):
(WebCore::GraphicsSurfacePrivate::initializeClient):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformSize):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

GraphicsSurface implementation to be shared by both GLX and GLES2.

platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):

platform/graphics/surfaces/egl/EGLSurface.h:
(EGLWindowTransportSurface):

platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore):
(WebCore::resolveGLMethods):
(WebCore::isMesaGLX):
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurfaceClient::GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::~GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::destroy):
(WebCore::GLXTransportSurfaceClient::prepareTexture):

platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXTransportSurfaceClient):
(WebCore):
GLXTransportSurfaceClient implementation.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13046002

12:13 PM Changeset in webkit [146732] by kareng@chromium.org

1 add in branches/chromium/1451/codereview.settings

for drovering

12:12 PM Changeset in webkit [146731] by kareng@chromium.org

1 copy in branches/chromium/1451

branching to revert a change for canary.

8:57 AM Changeset in webkit [146730] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[EFL] Add support to check for current Drawable.
https://bugs.webkit.org/show_bug.cgi?id=113103

Patch by KondapallyKalyan <kalyan.kondapally@intel.com> on 2013-03-24
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

In MakeCurrent we do an early return if it is
the current GL context but ignore Surface. This
patch fixes the issue, we now check for both
context and surface before doing an early return
in MakeCurrent.

platform/graphics/opengl/GLPlatformContext.cpp:

(WebCore::GLPlatformContext::makeCurrent):
(WebCore::GLPlatformContext::releaseCurrent):
(WebCore::GLPlatformContext::destroy):

platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore):
(WebCore::GLPlatformSurface::isCurrentDrawable):
(WebCore::GLPlatformSurface::onMakeCurrent):

platform/graphics/opengl/GLPlatformSurface.h:

8:47 AM Changeset in webkit [146729] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

BUILD FIX (r146704): Settings::setHiddenPageDOMTimerThrottlingEnabled() isn't always built
<http://webkit.org/b/112308>

WebCore.exp.in: Export

Settings::setHiddenPageDOMTimerThrottlingEnabled()
conditionally based on ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING).

7:43 AM Changeset in webkit [146728] by Christophe Dumez

2 edits in trunk/Source/WebCore

[EFL] NetworkStateNotifier::updateState() is called too often
https://bugs.webkit.org/show_bug.cgi?id=113152

Reviewed by Kenneth Rohde Christiansen.

Wait until we have read all the data on the Netlink socket before
reporting a possible network interface change. This way, we make
sure we don't call NetworkStateNotifier::updateState() several
times in a row for no reason.

We also call NetworkStateNotifier::updateState() only if we get a
RTM_NEWADDR event and we are currently offline, or if we get a
RTM_DELADDR and we are currently online. This avoids calling
NetworkStateNotifier::updateState() uselessly as there is no way
the online state can change otherwise.

No new tests, no behavior change for layout tests.

platform/network/efl/NetworkStateNotifierEfl.cpp:

(WebCore::NetworkStateNotifier::readSocketCallback):

3:36 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:20 AM Changeset in webkit [146727] by Chris Fleizach

5 edits
2 adds in trunk

AX: Crash in WebCore::AccessibilitySpinButton::incrementButton()
https://bugs.webkit.org/show_bug.cgi?id=111582

Reviewed by Tim Horton.

Source/WebCore:

There are two ways to create a spin button: from a textfield counter or from ARIA.
If an ARIA spin button is created, it was returning true for isSpinButton, so we were
casting to the other kind of spin button, leading to a crash.

We need to be more specific about our class types.

Test: platform/mac/accessibility/aria-spinbutton-crash.html

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isNativeSpinButton):

accessibility/AccessibilitySpinButton.h:

(WebCore::AccessibilitySpinButton::isNativeSpinButton):
(WebCore::toAccessibilitySpinButton):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

platform/mac/accessibility/aria-spinbutton-crash-expected.txt: Added.
platform/mac/accessibility/aria-spinbutton-crash.html: Added.

12:37 AM Changeset in webkit [146726] by Chris Fleizach

34 edits in trunk/Source/WebCore

AXObjectCache gets recreated during document tear-down.
https://bugs.webkit.org/show_bug.cgi?id=112525

Reviewed by Simon Fraser.

In many cases, a document's AXObjectCache was being created after the
document had detached, which is wasteful and could potentially lead to
crashes because the AXObjectCache has a timer and relies on its document
to exist.

This patch provides a way to get the existing AX object cache, instead of
always creating a new one.
It moves the accessibilityEnabled() checks into the axObjectCache retrieval
for easier readability.
It adds a number of ASSERTs to vieryf that only the correct (top) document is used
for cache manipulation.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):

dom/ContainerNode.cpp:

(WebCore::ContainerNode::~ContainerNode):

dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::setFocusedNode):

dom/Document.h:

(Document):

dom/Element.cpp:

(WebCore::Element::attributeChanged):

dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::isEditableToAccessibility):
(WebCore::Node::attach):
(WebCore::Node::rootEditableElement):
(WebCore::Node::didMoveToNewDocument):

editing/AppendNodeCommand.cpp:

(WebCore::sendAXTextChangedIgnoringLineBreaks):

editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):

editing/Editor.cpp:

(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):

editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

editing/atk/FrameSelectionAtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

editing/chromium/FrameSelectionChromium.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

editing/mac/FrameSelectionMac.mm:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::optionElementChildrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setInnerTextValue):

html/InputType.cpp:

(WebCore::InputType::applyStep):

html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

page/FocusController.cpp:

(WebCore::FocusController::setInitialFocus):

page/Frame.cpp:

(WebCore::Frame::disconnectOwnerElement):

page/FrameView.cpp:

(WebCore::FrameView::removeFromAXObjectCache):
(WebCore::FrameView::layout):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::axObjectCache):

platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

platform/Scrollbar.cpp:

(WebCore::Scrollbar::~Scrollbar):
(WebCore):
(WebCore::Scrollbar::existingAXObjectCache):

platform/Scrollbar.h:

(Scrollbar):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createRootInlineBox):
(WebCore::RenderBlock::createAndAppendRootInlineBox):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::selectionChanged):

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::addChild):
(WebCore::RenderMenuList::didUpdateActiveOption):

rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::willBeDestroyed):

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

rendering/RenderText.cpp:

(WebCore::RenderText::setText):

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::willBeDestroyed):

Mar 23, 2013:

10:50 PM Changeset in webkit [146725] by mkwst@chromium.org

13 edits in trunk

Drop full URLs from cross-origin access errors caused by sandboxing.
https://bugs.webkit.org/show_bug.cgi?id=113029

Reviewed by Timothy Hatcher.

Source/WebCore:

Following up on http://wkbug.com/112042, this patch brings cross-origin
access error messages into line with the newly origin-only default
message, and changes the error message text to explicitly refer to the
missing 'allow-same-origin' sandbox flag that's the root cause of the
error.

page/DOMWindow.cpp:

(WebCore::DOMWindow::crossDomainAccessErrorMessage):

Note that we're using the origin of the frames' URLs rather than
their actual origin in these messages. This seems like a reasonable
thing to do, since we know that at least one of the two origins will
be "null" in this scenario.

LayoutTests:

http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-expected.txt:
http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt:
http/tests/security/sandboxed-iframe-origin-add-expected.txt:
http/tests/security/sandboxed-iframe-origin-remove-expected.txt:
http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt:
platform/chromium/http/tests/security/sandboxed-iframe-modify-self-expected.txt:
platform/chromium/http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt:

9:48 PM Changeset in webkit [146724] by dmazzoni@google.com

21 edits
9 adds in trunk/Source

Implement Web Speech Synthesis for Chromium
https://bugs.webkit.org/show_bug.cgi?id=111695

Reviewed by Adam Barth.

Source/Platform:

Exposes a platform API that the embedder can implement to
provide speech synthesis for the Chromium port.

Platform.gypi:
chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::speechSynthesizer):

chromium/public/WebSpeechSynthesisUtterance.h: Added.

(WebKit):
(WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::~WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::isNull):

chromium/public/WebSpeechSynthesisVoice.h: Added.

(WebCore):
(WebKit):
(WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::~WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::operator=):

chromium/public/WebSpeechSynthesizer.h: Added.

(WebKit):
(WebSpeechSynthesizer):
(WebKit::WebSpeechSynthesizer::~WebSpeechSynthesizer):

chromium/public/WebSpeechSynthesizerClient.h: Added.

(WebKit):
(WebSpeechSynthesizerClient):
(WebKit::WebSpeechSynthesizerClient::~WebSpeechSynthesizerClient):

Source/WebCore:

Straightforward implementation of speech synthesis
for Chromium by exposing interfaces for the platform
to implement.

Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
(WebCore):

Modules/speech/SpeechSynthesis.h:

(SpeechSynthesis):

Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore):
(WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):

Modules/speech/SpeechSynthesisUtterance.h:

(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):

Modules/speech/SpeechSynthesisVoice.h:

(WebCore::SpeechSynthesisVoice::~SpeechSynthesisVoice):

WebCore.exp.in:
WebCore.gypi:
platform/PlatformSpeechSynthesis.h:

(PlatformSpeechSynthesis):

platform/PlatformSpeechSynthesisUtterance.cpp:

(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::create):

platform/PlatformSpeechSynthesisUtterance.h:

(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setClient):

platform/PlatformSpeechSynthesisVoice.cpp:

(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):

platform/PlatformSpeechSynthesisVoice.h:

(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::setVoiceURI):
(WebCore::PlatformSpeechSynthesisVoice::setName):
(WebCore::PlatformSpeechSynthesisVoice::setLang):
(WebCore::PlatformSpeechSynthesisVoice::setLocalService):
(WebCore::PlatformSpeechSynthesisVoice::setIsDefault):

platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::setVoiceList):
(WebCore):

platform/PlatformSpeechSynthesizer.h:

(WebKit):
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):

platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Added.

(WebCore):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::cancel):

platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Added.

(WebKit):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::assign):
(WebKit::WebSpeechSynthesisUtterance::reset):
(WebKit::WebSpeechSynthesisUtterance::operator PassRefPtr<PlatformSpeechSynthesisUtterance>):
(WebKit::WebSpeechSynthesisUtterance::operator PlatformSpeechSynthesisUtterance*):
(WebKit::WebSpeechSynthesisUtterance::text):
(WebKit::WebSpeechSynthesisUtterance::lang):
(WebKit::WebSpeechSynthesisUtterance::voice):
(WebKit::WebSpeechSynthesisUtterance::volume):
(WebKit::WebSpeechSynthesisUtterance::rate):
(WebKit::WebSpeechSynthesisUtterance::pitch):
(WebKit::WebSpeechSynthesisUtterance::startTime):

platform/chromium/support/WebSpeechSynthesisVoice.cpp: Added.

(WebKit):
(WebKit::WebSpeechSynthesisVoice::assign):
(WebKit::WebSpeechSynthesisVoice::reset):
(WebKit::WebSpeechSynthesisVoice::setVoiceURI):
(WebKit::WebSpeechSynthesisVoice::setName):
(WebKit::WebSpeechSynthesisVoice::setLanguage):
(WebKit::WebSpeechSynthesisVoice::setIsLocalService):
(WebKit::WebSpeechSynthesisVoice::setIsDefault):
(WebKit::WebSpeechSynthesisVoice::operator PassRefPtr<WebCore::PlatformSpeechSynthesisVoice>):

platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Added.

(WebCore):
(WebCore::WebSpeechSynthesizerClientImpl::WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::~WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::setVoiceList):
(WebCore::WebSpeechSynthesizerClientImpl::didStartSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didFinishSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didPauseSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didResumeSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::speakingErrorOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::wordBoundaryEventOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::sentenceBoundaryEventOccurred):

platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Added.

(WebCore):
(WebSpeechSynthesizerClientImpl):

platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::speak):

platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):

platform/mock/PlatformSpeechSynthesizerMock.h:

(PlatformSpeechSynthesizerMock):

6:24 PM Changeset in webkit [146723] by dcheng@chromium.org

4 edits in trunk

[Qt] editing/pasteboard/can-read-in-dragstart-event.html and /can-read-in-copy-and-cut-events.html are crashing
https://bugs.webkit.org/show_bug.cgi?id=113126

Reviewed by Ryosuke Niwa.

Source/WebCore:

The ClipboardQt implementation only allows reading or writing, not both. Attempting to read
when the clipboard is only writable will lead to a crash since the corresponding member will
be null. To prevent crashes, change the asserts to early returns. In the long term, the
correct fix is to unify the m_readableData and m_writableData members.

No new tests since no functionality in Qt port should change.

platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):

LayoutTests:

platform/qt/TestExpectations:

1:18 PM Changeset in webkit [146722] by ggaren@apple.com

2 edits in trunk/Source/WebKit2

Added a setting for whether JavaScript markup is enabled
https://bugs.webkit.org/show_bug.cgi?id=112999

Rolled out a line from r146664 that was left over from before I adopted
the Settings.in way of adding a new setting.

Reviewed by Ryosuke Niwa.

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): No need
to initialize / override -- Settings.in settings do this automatically.

Also, dydx noticed that this line of code had a typo, and was totaly wrong.

10:47 AM Changeset in webkit [146721] by commit-queue@webkit.org

6 edits in trunk/Source

[GTK][Regression] webkit_dom_html_table_element_insert_row returns value that doesn't pass WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT macro
https://bugs.webkit.org/show_bug.cgi?id=111714

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-23
Reviewed by Martin Robinson.

Source/WebCore:

Add custom kit implementation for HTMLElements so that the HTML
wrappers are used in that case instead of wrapHTMLElement.

bindings/gobject/WebKitDOMBinding.cpp:

(WebKit::kit):
(WebKit):

bindings/gobject/WebKitDOMBinding.h:

(WebCore):
(WebKit):

bindings/scripts/CodeGeneratorGObject.pm:

(UsesManualKitImplementation):

Source/WebKit/gtk:

Add test that checks webkit_dom_html_table_element_insert_row() to
also preproduce this issue.

tests/testdomdocument.c:

(test_dom_document_insert_row):
(main):

7:44 AM Changeset in webkit [146720] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

Revert "BUILD FIX (r146667): ResourceRequest constructor in SynchronousLoaderClient.cpp is ambiguous on iOS"

This is platform-agnositic code, so the previous solution won't work.

7:41 AM Changeset in webkit [146719] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

BUILD FIX (r146667): ResourceRequest constructor in SynchronousLoaderClient.cpp is ambiguous on iOS

Fixes the following build failure:

Source/WebCore/platform/network/SynchronousLoaderClient.cpp:52:15: error: conversion from 'int' to 'const WebCore::ResourceRequest' is ambiguous

request = 0;

In file included from Source/WebCore/platform/network/SynchronousLoaderClient.cpp:30:
In file included from Source/WebCore/platform/network/ResourceHandle.h:37:
In file included from Source/WebCore/platform/network/ios/QuickLook.h:13:
Source/WebCore/platform/network/cf/ResourceRequest.h:79:9: note: candidate constructor

ResourceRequest(NSURLRequest *);

Source/WebCore/platform/network/cf/ResourceRequest.h:83:9: note: candidate constructor

ResourceRequest(CFURLRequestRef cfRequest)

1 error generated.

platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::willSendRequest): If
USE(CFNETWORK) is defined, use static_cast<CFURLRequestRef>(0),
otherwise use static_cast<NSURLRequest *>(0).

7:16 AM Changeset in webkit [146718] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

BUILD FIX (r146687): setDefaultMIMEType() is unused in ResourceHandleCFNet.cpp on iOS

Fixes the following build failure:

Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:98:13: error: unused function 'setDefaultMIMEType' [-Werror,-Wunused-function]
static void setDefaultMIMEType(CFURLResponseRef response)

1 error generated.

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::setDefaultMIMEType): Add #if !PLATFORM(MAC)/#endif
guard.

Mar 22, 2013:

11:36 PM Changeset in webkit [146717] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Stupid picky bug syntax...

Unreviewed, test expectations updates.

platform/chromium/TestExpectations:

10:58 PM Changeset in webkit [146716] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Mark flaky test.
https://bugs.webkit.org/show_bug.cgi?id=113129

Unreviewed, test expectations updates.

platform/chromium/TestExpectations:

10:47 PM Changeset in webkit [146715] by pkasting@chromium.org

4 edits
2 deletes in trunk/LayoutTests

[chromium] Last bits of post-Skia-change fallout, plus other bits.
https://bugs.webkit.org/show_bug.cgi?id=109507
https://bugs.webkit.org/show_bug.cgi?id=113067
https://bugs.webkit.org/show_bug.cgi?id=113128
https://code.google.com/p/chromium/issues/detail?id=67442

Unreviewed, test expectations updates.

Deleted a few new baselines added during Skia rebaselining that were
existing expected failures from bug 109507 whose failure lines were
left in TestExpectations.

Added a flaky test and a failing test (which for some reason has no new
baselines so I can't rebaseline), and removed a passing test.

Re-added some "Pass" expectations I'd previously removed, as they're
necessary after all.

platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
platform/chromium/TestExpectations:
platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.

9:59 PM Changeset in webkit [146714] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add a timeout expectation to media/track/track-prefer-captions.html after
r146380 on GTK+. The failure is tracked by http://webkit.org/b/113127

platform/gtk/TestExpectations:

9:54 PM Changeset in webkit [146713] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add crash test expectations to tests added in r146644.
The failures are tracked by http://webkit.org/b/113126

platform/qt/TestExpectations:

9:51 PM Changeset in webkit [146712] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

BUILD FIX (r145119): Make JSValue* properties default to (assign)
<rdar://problem/13380794>

Reviewed by Mark Hahnenberg.

Fixes the following build failures:

Source/JavaScriptCore/API/tests/testapi.mm:106:1: error: no 'assign', 'retain', or 'copy' attribute is specified - 'assign' is assumed [-Werror,-Wobjc-property-no-attribute]
@property JSValue *onclick;
^{Source/JavaScriptCore/API/tests/testapi.mm:106:1: error: default property attrib ute 'assign' not appropriate for non-GC object [-Werror,-Wobjc-property-no-attribute]

Source/JavaScriptCore/API/tests/testapi.mm:107:1: error: no 'assign', 'retain', or 'copy' attribute is specified - 'assign' is assumed [-Werror,-Wobjc-property-no-attribute]

@property JSValue *weakOnclick;}
Source/JavaScriptCore/API/tests/testapi.mm:107:1: error: default property attribute 'assign' not appropriate for non-GC object [-Werror,-Wobjc-property-no-attribute]
4 errors generated.

API/tests/testapi.mm: Default to (assign) for JSValue*

properties.

9:20 PM Changeset in webkit [146711] by rniwa@webkit.org

2 edits in trunk/Source/JavaScriptCore

testLeakingPrototypesAcrossContexts added in r146682 doesn't compile on Win and fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=113125

Reviewed by Mark Hahnenberg

Remove the test added in r146682 as it's now failing on Mac.
This is the test that was causing a compilation failure on Windows.

API/tests/testapi.c:

(main):

8:35 PM Changeset in webkit [146710] by rniwa@webkit.org

4 edits in trunk/Source/WebKit

The second part of the build fix for r146702. This should do it.
I had to see the mangled name for the new signature.

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

WebKit.vcproj/WebKitExports.def.in:

8:34 PM Changeset in webkit [146709] by noel.gordon@gmail.com

2 edits in trunk/LayoutTests

[chromium] Mark canvas-toDataURL-webp.html imageOnlyFailure Pass
https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

libwebp will be updated to 0.3.0 in chrome, changing the encoder
output, after which these test results will need to be updated.

platform/chromium/TestExpectations:

8:24 PM Changeset in webkit [146708] by rniwa@webkit.org

2 edits in trunk/Source/JavaScriptCore

Fix the typo: WIN -> WINDOWS.

API/tests/testapi.c:

(main):

8:12 PM Changeset in webkit [146707] by rniwa@webkit.org

2 edits in trunk/Source/JavaScriptCore

I really can't figure out what's wrong with this one.
Temporarily disable the test added by r146682 on Windows since it doesn't compile.

API/tests/testapi.c:

(main):

8:09 PM Changeset in webkit [146706] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Mark more tests as crashing.
https://bugs.webkit.org/show_bug.cgi?id=113067

Unreviewed, test expectations update.

platform/chromium/TestExpectations:

7:50 PM Changeset in webkit [146705] by rniwa@webkit.org

4 edits in trunk/Source/WebKit

Build fix attempt after r146702.

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

WebKit.vcproj/WebKitExports.def.in:

7:15 PM Changeset in webkit [146704] by cmuppala@apple.com

19 edits in trunk

Add runtime setting for hidden page DOM timer throttling and CSS animation suspension
https://bugs.webkit.org/show_bug.cgi?id=112308

Reviewed by Gavin Barraclough.

Source/WebCore:

No new tests. Only adding settings to enable/disable existing features
and hence existing tests suffice.

WebCore.exp.in:
page/Page.cpp:

(WebCore::Page::setVisibilityState): Check if DOM timer throttling
and CSS animation suspension are enabled before turning them on.
(WebCore::Page::hiddenPageDOMTimerThrottlingStateChanged): Start or stop
DOM timer throttling based on page visibility and the new setting state.
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged): Ditto
for CSS animation suspension.

page/Page.h:
page/Settings.cpp:

(WebCore::Settings::Settings): Initialize the flags for enabling hidden
page DOM timer throttling and CSS animation suspension to false.
(WebCore::Settings::setHiddenPageDOMTimerThrottlingEnabled): Update flag
and notify page that the state of the setting has changed.
(WebCore::Settings::setHiddenPageCSSAnimationSuspensionEnabled): Ditto.

page/Settings.h:

(WebCore::Settings::hiddenPageDOMTimerThrottlingEnabled):
(WebCore::Settings::hiddenPageCSSAnimationSuspensionEnabled):

Source/WebKit/mac:

Add private preference for enabling/disabling hidden page DOM timer
throttling and CSS animation suspension. The preference should be
disabled by default to avoid compatibility issues.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences hiddenPageDOMTimerThrottlingEnabled]):
(-[WebPreferences setHiddenPageDOMTimerThrottlingEnabled:]):
(-[WebPreferences hiddenPageCSSAnimationSuspensionEnabled]):
(-[WebPreferences setHiddenPageCSSAnimationSuspensionEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Add private preference for enabling/disabling hidden page DOM timer
throttling and CSS animation suspension. The preference should be
enabled by default only on Mac, where WebKit2 is a private API and
hence compatibility is less of a issue.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetHiddenPageDOMTimerThrottlingEnabled):
(WKPreferencesGetHiddenPageDOMTimerThrottlingEnabled):
(WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled):
(WKPreferencesGetHiddenPageCSSAnimationSuspensionEnabled):

UIProcess/API/C/WKPreferencesPrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Allow
WebKitTestRunner to override hiddenPageDOMTimerThrottlingEnabled.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

Hidden page DOM timer throttling is disabled by default in WebKit1 and
in WebKit2 for platforms other than Mac. Override the preference to
enable it during the test.

fast/dom/timer-throttling-hidden-page.html:

7:01 PM Changeset in webkit [146703] by cmuppala@apple.com

2 edits in trunk/Tools

Unreviewed. Move self from contributor to committer list.

Scripts/webkitpy/common/config/committers.py:

6:35 PM Changeset in webkit [146702] by benjamin@webkit.org

7 edits in trunk/Source

Remove 2 bad branches from StringHash::equal() and CaseFoldingHash::equal()
https://bugs.webkit.org/show_bug.cgi?id=113003

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-22
Reviewed by Eric Seidel.

Source/WebCore:

Fix two unfortunate use of StringHash and use the correct StringImpl function.

html/parser/HTMLParserIdioms.cpp:

(WebCore::threadSafeEqual):

html/parser/HTMLTreeBuilderSimulator.cpp:

(WebCore::tokenExitsSVG):

Source/WTF:

StringHash::equal() and CaseFoldingHash::equal() were both testing for
the nullity of the two input pointers. The catch is: neither traits handle
null pointers, and any client code would have crashed on hash(), before equal()
is called.
Consequently, the two branches had a pass rate of zero when called from a HashMap code.

The function is also never inlined because it is too big (the code of equal() for characters
is always inlined, causing the function to be quite big).

This patch introduces two new functions in the StringImpl API: equalNonNull() and
equalIgnoringCaseNonNull(). Those functions are similar to their equal() equivalent
but make the assumtion the input is never null.

The functions are used for StringHash to avoid the useless branches.

wtf/text/StringHash.h:

(WTF::StringHash::equal):
(WTF::CaseFoldingHash::equal):

wtf/text/StringImpl.cpp:

(WTF::stringImplContentEqual):
(WTF::equal):
(WTF::equalNonNull):
(WTF::equalIgnoringCase):
(WTF::equalIgnoringCaseNonNull):
(WTF::equalIgnoringNullity):

wtf/text/StringImpl.h:

(WTF::equalIgnoringCase):

6:19 PM Changeset in webkit [146701] by aestes@apple.com

2 edits in trunk/Source/WebCore

Set the cache partition property on CFURLRequests
https://bugs.webkit.org/show_bug.cgi?id=113116

Patch by Jeffrey Pfau
Reviewed by David Kilzer.

platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):

6:17 PM Changeset in webkit [146700] by schenney@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

Adding bug numbers for two failing tests.

platform/chromium/TestExpectations:

6:10 PM Changeset in webkit [146699] by schenney@chromium.org

81 edits
6 adds
5 deletes in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

The rest.

platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
platform/chromium-linux/fast/borders/border-radius-with-box-shadow-01-expected.png:
platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png:
platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
platform/chromium-linux/fast/box-shadow/inset-expected.png:
platform/chromium-linux/fast/box-shadow/scaled-box-shadow-expected.png: Added.
platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png:
platform/chromium-mac-lion/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
platform/chromium-mac-lion/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
platform/chromium-mac-lion/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
platform/chromium-mac-lion/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
platform/chromium-mac-lion/editing/selection/select-text-overflow-ellipsis-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
platform/chromium-mac-lion/fast/backgrounds/animated-svg-as-mask-expected.png:
platform/chromium-mac-lion/fast/borders/border-antialiasing-expected.png:
platform/chromium-mac-lion/fast/borders/border-radius-split-inline-expected.png:
platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-mac-lion/fast/box-shadow/box-shadow-transformed-expected.png:
platform/chromium-mac-lion/fast/box-shadow/inset-expected.png:
platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
platform/chromium-mac-snowleopard/editing/selection/select-text-overflow-ellipsis-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png:
platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-transformed-expected.png:
platform/chromium-mac/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
platform/chromium-mac/editing/selection/select-text-overflow-ellipsis-expected.png:
platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png:
platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
platform/chromium-mac/fast/borders/border-radius-with-box-shadow-01-expected.png:
platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png:
platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png:
platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
platform/chromium-mac/fast/box-shadow/inset-expected.png:
platform/chromium-mac/fast/box-shadow/scaled-box-shadow-expected.png:
platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
platform/chromium-mac/fast/box-shadow/shadow-tiling-artifact-expected.png:
platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png:
platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
platform/chromium-win/fast/borders/border-radius-with-box-shadow-01-expected.png:
platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png:
platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
platform/chromium-win/fast/box-shadow/inset-expected.png:
platform/chromium-win/fast/box-shadow/scaled-box-shadow-expected.png:
platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png:
platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
platform/chromium/TestExpectations:
platform/efl-wk2/fast/borders/border-radius-split-inline-expected.png: Added.
platform/efl-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
platform/efl-wk2/fast/box-shadow/box-shadow-transformed-expected.png: Added.
platform/efl-wk2/fast/box-shadow/inset-expected.png: Added.
platform/efl-wk2/fast/box-shadow/scaled-box-shadow-expected.png: Added.
platform/efl/fast/borders/border-radius-split-inline-expected.png: Removed.
platform/efl/fast/box-shadow/basic-shadows-expected.png: Removed.
platform/efl/fast/box-shadow/box-shadow-transformed-expected.png: Removed.
platform/efl/fast/box-shadow/inset-expected.png: Removed.
platform/efl/fast/box-shadow/scaled-box-shadow-expected.png: Removed.

6:09 PM Changeset in webkit [146698] by rniwa@webkit.org

3 edits in trunk/Source/JavaScriptCore

Another build fix (after r146693) for r146682.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

6:07 PM Changeset in webkit [146697] by jchaffraix@webkit.org

4 edits
4 adds in trunk

[CSS Grid Layout] content-sized row tracks with percentage logical height grid items don't resolve properly
https://bugs.webkit.org/show_bug.cgi?id=113085

Reviewed by Tony Chang.

Source/WebCore:

The core issue is that because overrideContainingBlockLogicalHeight() is unset in
logicalContentHeightForChild, RenderBox::computePercentageLogicalHeight would try to
resolve percentage logical height against the grid element (wrong containing block
as a grid item's containing block is the grid area).

Tests: fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html

fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::logicalContentHeightForChild):
Set our override logical height to -1, so that we don't try to constrain a grid item's logical height
based on resolving (badly) its percentage.

LayoutTests:

fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution-expected.txt:

Updated the result to pass.

fast/css-grid-layout/grid-item-multiple-minmax-content-resolution-expected.txt: Added.
fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html: Added.
fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution-expected.txt: Added.
fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html: Added.

Added more testing to ensure that we properly do the resolution.

6:03 PM Changeset in webkit [146696] by schenney@chromium.org

65 edits
2 adds
1 delete in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

fast/canvas/...
fast/css/...
fast/forms/...
fast/multicol/...

platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
platform/chromium-linux/fast/css/color-correction-on-box-shadow-expected.png:
platform/chromium-linux/fast/css/color-correction-on-text-shadow-expected.png:
platform/chromium-linux/fast/css/font-family-pictograph-expected.png:
platform/chromium-linux/fast/css/font-family-pictograph-expected.txt:
platform/chromium-linux/fast/css/shadow-multiple-expected.png:
platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
platform/chromium-mac-lion/fast/css/color-correction-on-box-shadow-expected.png:
platform/chromium-mac-lion/fast/css/color-correction-on-text-shadow-expected.png:
platform/chromium-mac-lion/fast/css/empty-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/first-child-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/first-of-type-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/last-child-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/last-of-type-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/only-child-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/only-of-type-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
platform/chromium-mac-lion/fast/dynamic/text-combine-expected.png:
platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
platform/chromium-mac-lion/fast/line-grid/line-grid-contains-value-expected.png:
platform/chromium-mac-lion/fast/multicol/nested-columns-expected.png:
platform/chromium-mac-lion/fast/multicol/shadow-breaking-expected.png:
platform/chromium-mac-snowleopard/fast/css/color-correction-on-box-shadow-expected.png:
platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-shadow-expected.png:
platform/chromium-mac-snowleopard/fast/css/empty-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/first-child-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/first-of-type-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/last-child-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/last-of-type-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/only-child-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/only-of-type-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png:
platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png:
platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png:
platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png:
platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png:
platform/chromium-mac/fast/css/empty-pseudo-class-expected.png:
platform/chromium-mac/fast/css/first-child-pseudo-class-expected.png:
platform/chromium-mac/fast/css/first-of-type-pseudo-class-expected.png:
platform/chromium-mac/fast/css/last-child-pseudo-class-expected.png:
platform/chromium-mac/fast/css/last-of-type-pseudo-class-expected.png:
platform/chromium-mac/fast/css/only-child-pseudo-class-expected.png:
platform/chromium-mac/fast/css/only-of-type-pseudo-class-expected.png:
platform/chromium-mac/fast/css/shadow-multiple-expected.png:
platform/chromium-mac/fast/dynamic/text-combine-expected.png:
platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
platform/chromium-mac/fast/line-grid/line-grid-contains-value-expected.png:
platform/chromium-mac/fast/multicol/nested-columns-expected.png:
platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
platform/chromium-win/fast/css/color-correction-on-box-shadow-expected.png:
platform/chromium-win/fast/css/color-correction-on-text-shadow-expected.png:
platform/chromium-win/fast/css/shadow-multiple-expected.png:
platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
platform/chromium/TestExpectations:
platform/efl-wk2/fast/multicol: Added.
platform/efl-wk2/fast/multicol/shadow-breaking-expected.png: Added.
platform/efl/fast/multicol/shadow-breaking-expected.png: Removed.

5:52 PM Changeset in webkit [146695] by schenney@chromium.org

44 edits
9 adds
17 deletes in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

fast/repaint/...
fast/ruby/...

fast/repaint/moving-shadow-on-container-expected.png: Added.
fast/repaint/search-field-cancel-expected.txt: Added.
platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.png: Removed.
platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
platform/chromium-mac-lion/fast/repaint/box-shadow-h-expected.png:
platform/chromium-mac-lion/fast/repaint/box-shadow-v-expected.png:
platform/chromium-mac-lion/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-mac-lion/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium-mac-lion/fast/repaint/scale-page-shrink-expected.png: Added.
platform/chromium-mac-lion/fast/repaint/search-field-cancel-expected.png: Added.
platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/scale-page-shrink-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/ruby/base-shorter-than-text-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/ruby/base-shorter-than-text-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/ruby/position-after-expected.png:
platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium-mac/fast/repaint/scale-page-shrink-expected.png: Added.
platform/chromium-mac/fast/repaint/search-field-cancel-expected.png: Added.
platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
platform/chromium-mac/fast/repaint/transform-replaced-shadows-expected.png:
platform/chromium-mac/fast/ruby/position-after-expected.png:
platform/chromium-win-xp/fast/repaint/box-shadow-h-expected.png: Removed.
platform/chromium-win-xp/fast/repaint/box-shadow-v-expected.png: Removed.
platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.png: Removed.
platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Removed.
platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
platform/chromium/TestExpectations:
platform/chromium/fast/repaint/search-field-cancel-expected.png: Removed.
platform/chromium/fast/repaint/search-field-cancel-expected.txt: Removed.
platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.png: Added.
platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.png: Added.
platform/efl-wk2/fast/repaint/transform-replaced-shadows-expected.png: Added.
platform/efl/fast/repaint/moving-shadow-on-container-expected.png: Removed.
platform/efl/fast/repaint/moving-shadow-on-path-expected.png: Removed.
platform/efl/fast/repaint/transform-replaced-shadows-expected.png: Removed.
platform/gtk/fast/repaint/moving-shadow-on-container-expected.png: Removed.
platform/mac/fast/repaint/moving-shadow-on-container-expected.png: Removed.
platform/mac/fast/repaint/search-field-cancel-expected.txt: Removed.

5:45 PM Changeset in webkit [146694] by zmo@google.com

7 edits in trunk/Source/WebCore

Check WEBGL_draw_buffers requirements before exposing the extension
https://bugs.webkit.org/show_bug.cgi?id=112359

Reviewed by Kenneth Russell.

html/canvas/EXTDrawBuffers.cpp:

(WebCore::EXTDrawBuffers::supported): call satisfies*().
(WebCore::EXTDrawBuffers::drawBuffersEXT):
(WebCore):
(WebCore::EXTDrawBuffers::satisfiesWebGLRequirements): check WebGL requirements.

html/canvas/EXTDrawBuffers.h:

(EXTDrawBuffers):

html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::getDrawBuffer):
(WebCore):

html/canvas/WebGLFramebuffer.h:

(WebGLFramebuffer):

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
(WebCore::WebGLRenderingContext::getMaxDrawBuffers):
(WebCore::WebGLRenderingContext::getMaxColorAttachments):
(WebCore::WebGLRenderingContext::setBackDrawBuffer):
(WebCore::WebGLRenderingContext::restoreCurrentFramebuffer):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
(WebCore::WebGLRenderingContext::supportsDrawBuffers): a cached version of EXTDrawBuffers::supports()

html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

5:44 PM Changeset in webkit [146693] by roger_fong@apple.com

3 edits in trunk/Source/JavaScriptCore

Unreviewed. AppleWin build fix.

JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
JavaScriptCore.vcxproj/copy-files.cmd:

5:37 PM Changeset in webkit [146692] by schenney@chromium.org

41 edits
6 adds
3 deletes in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

fast/text/...

platform/chromium-linux/fast/text/emphasis-avoid-ruby-expected.png: Added.
platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-linux/fast/text/stroking-decorations-expected.png:
platform/chromium-linux/fast/text/stroking-expected.png:
platform/chromium-linux/fast/transforms/shadows-expected.png:
platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png:
platform/chromium-mac-lion/fast/text/international/bold-bengali-expected.png:
platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.png:
platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.png:
platform/chromium-mac-lion/fast/text/justify-ideograph-vertical-expected.png:
platform/chromium-mac-lion/fast/text/orientation-sideways-expected.png:
platform/chromium-mac-lion/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-mac-lion/fast/text/stroking-decorations-expected.png:
platform/chromium-mac-lion/fast/text/stroking-expected.png:
platform/chromium-mac-lion/fast/text/whitespace/024-expected.png:
platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-001-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-002-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-003-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.png:
platform/chromium-mac-snowleopard/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-mac-snowleopard/fast/text/whitespace/024-expected.png:
platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png:
platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
platform/chromium-mac/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-mac/fast/text/stroking-decorations-expected.png:
platform/chromium-mac/fast/text/stroking-expected.png:
platform/chromium-mac/fast/text/whitespace/024-expected.png:
platform/chromium-mac/fast/transforms/shadows-expected.png:
platform/chromium-win-xp/fast/text/stroking-decorations-expected.png:
platform/chromium-win-xp/fast/text/stroking-expected.png:
platform/chromium-win/fast/text/international/bold-bengali-expected.png:
platform/chromium-win/fast/text/international/bold-bengali-expected.txt:
platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-win/fast/text/stroking-decorations-expected.png:
platform/chromium-win/fast/text/stroking-expected.png:
platform/chromium-win/fast/transforms/shadows-expected.png:
platform/chromium/TestExpectations:
platform/chromium/fast/text/international/bold-bengali-expected.png: Removed.
platform/efl-wk2/fast/text/shadow-translucent-fill-expected.png: Added.
platform/efl/fast/text/shadow-translucent-fill-expected.png: Removed.
platform/qt-unknown/fast: Added.
platform/qt-unknown/fast/text: Added.
platform/qt-unknown/fast/text/international: Added.
platform/qt-unknown/fast/text/international/text-spliced-font-expected.png: Added.
platform/qt/fast/text/international/text-spliced-font-expected.png: Removed.

5:31 PM Changeset in webkit [146691] by rniwa@webkit.org

6 edits in trunk/Tools

EWS should use a human readable port name when uploading layout test archives
https://bugs.webkit.org/show_bug.cgi?id=113099

Reviewed by Dirk Pranke.

Use new port's object's name() method to report human readable port names.
This will also help us resolving the bug to apply layout test results posted by EWS.

Scripts/webkitpy/tool/bot/botinfo.py:

(BotInfo.init): Take port's name.
(BotInfo.summary_text):

Scripts/webkitpy/tool/bot/botinfo_unittest.py:

(BotInfoTest.test_summary_text):

Scripts/webkitpy/tool/bot/flakytestreporter.py:

(FlakyTestReporter.init): Preserve the old behavior since we don't have a real port object here.

Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue.init): Initialize self._port.
(PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
and use that for the attachment filename and the comment posted.

Scripts/webkitpy/tool/commands/queues_unittest.py:

(PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
"mac-snowleopard" as expected for TestPort.

5:26 PM Changeset in webkit [146690] by schenney@chromium.org

4 edits in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

One I missed.

platform/chromium-mac-lion/svg/custom/preserve-aspect-ratio-syntax-expected.png:
platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:

5:24 PM Changeset in webkit [146689] by roger_fong@apple.com

2 edits in trunk/Tools

Unreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100.
Patch by Alexey Proskuryakov.

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::platformLoadResourceSynchronously):

5:21 PM Changeset in webkit [146688] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

-[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled
https://bugs.webkit.org/show_bug.cgi?id=113054

Reviewed by Geoffrey Garen.

API/tests/testapi.mm:

(-[TinyDOMNode dealloc]):

5:14 PM Changeset in webkit [146687] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Unreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100.
Patch by Alexey Proskuryakov.

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::platformLoadResourceSynchronously):

5:10 PM Changeset in webkit [146686] by kov@webkit.org

2 edits in trunk/Source/WebKit/gtk

Trivial fixes to the gyp-build autogen.sh script.

Reviewed by Martin Robinson (mrobinson).

gyp/autogen.sh: add /bin/sh -e as hashbang, so stricter shells will be happy to

run the script; deal with automake exiting with an error code because there is no
Makefile.am for it to work on.

5:00 PM Changeset in webkit [146685] by timothy_horton@apple.com

1 edit
2 adds in trunk/LayoutTests

Plugin Snapshotting: Auto-start dominant plugins
https://bugs.webkit.org/show_bug.cgi?id=113111
<rdar://problem/13475726>

Reviewed by Dean Jackson.

Add a test for http://trac.webkit.org/changeset/146679.

platform/mac-wk2/plugins/snapshotting/autoplay-dominant-expected.txt: Added.
plugins/snapshotting/autoplay-dominant.html: Added.

4:58 PM Changeset in webkit [146684] by tony@chromium.org

3 edits
2 adds in trunk

REGRESSION (r146272): layout issues for flex boxes that have -webkit-flex-wrap: wrap
https://bugs.webkit.org/show_bug.cgi?id=113071

Reviewed by Ojan Vafai.

Source/WebCore:

The refactor in r139535 introduced this bug, where a variable name wasn't updated properly.
In combination with r146272, this bug became more visible when nesting multiline flexboxen.

Test: css3/flexbox/multiline-min-preferred-width.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths): We want the width of the widest
flexitem, the value in m_minPreferredWidth isn't relevant. Also update the comment for max
preferred width.

LayoutTests:

css3/flexbox/multiline-min-preferred-width-expected.txt: Added.
css3/flexbox/multiline-min-preferred-width.html: Added.

4:56 PM Changeset in webkit [146683] by mvujovic@adobe.com

3 edits
4 adds in trunk

[CSS Shaders] Clamp css_MixColor before the blending and compositing steps
https://bugs.webkit.org/show_bug.cgi?id=113088

Reviewed by Dean Jackson.

Source/WebCore:

The blending and compositing operations from the spec [1] expect that they are operating on
valid color inputs, in the range [0.0, 1.0]. Thus, we should clamp the css_MixColor input to
this range to avoid implementation-dependent behavior for invalid color inputs.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blending

Tests: css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html

css3/filters/custom/custom-filter-clamp-css-mix-color.html

platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):

Clamp css_MixColor as clampedMixColor before using it in the blending and compositing
steps.

LayoutTests:

css3/filters/custom/custom-filter-clamp-css-mix-color-expected.html: Added.
css3/filters/custom/custom-filter-clamp-css-mix-color-negative-expected.html: Added.
css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html: Added.
css3/filters/custom/custom-filter-clamp-css-mix-color.html: Added.

4:49 PM Changeset in webkit [146682] by mhahnenberg@apple.com

10 edits in trunk/Source/JavaScriptCore

opaqueJSClassData should be cached on JSGlobalObject, not the JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=113086

Reviewed by Geoffrey Garen.

opaqueJSClassData stores cached prototypes for JSClassRefs in the C API. It doesn't make sense to
share these prototypes within a JSGlobalData across JSGlobalObjects, and in fact doing so will cause
a leak of the original JSGlobalObject that these prototypes were created in. Therefore we should move
this cache to JSGlobalObject where it belongs and where it won't cause memory leaks.

API/JSBase.cpp: Needed to add an extern "C" so that testapi.c can use the super secret GC function.
API/JSClassRef.cpp: We now grab the cached context data from the global object rather than the global data.

(OpaqueJSClass::contextData):

API/JSClassRef.h: Remove this header because it's unnecessary and causes circular dependencies.
API/tests/testapi.c: Added a new test that makes sure that using the same JSClassRef in two different contexts

doesn't cause leaks of the original global object.
(leakFinalize):
(nestedAllocateObject): This is a hack to bypass the conservative scan of the GC, which was unnecessarily marking
objects and keeping them alive, ruining the test result.
(testLeakingPrototypesAcrossContexts):
(main):

API/tests/testapi.mm: extern "C" this so we can continue using it here.
runtime/JSGlobalData.cpp: Remove JSClassRef related stuff.

(JSC::JSGlobalData::~JSGlobalData):

runtime/JSGlobalData.h:

(JSGlobalData):

runtime/JSGlobalObject.h: Add the stuff that JSGlobalData had. We add it to JSGlobalObjectRareData so that

clients who don't use the C API don't have to pay the memory cost of this extra HashMap.
(JSGlobalObject):
(JSGlobalObjectRareData):
(JSC::JSGlobalObject::opaqueJSClassData):

4:48 PM Changeset in webkit [146681] by Martin Robinson

2 edits in trunk/Source/WebCore

[GTK] Add WebCoreDOM to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112737

Reviewed by Nico Weber.

WebCore.gyp/WebCoreGTK.gyp: Add WebCoreDOM to the gyp build.

4:47 PM Changeset in webkit [146680] by Martin Robinson

3 edits in trunk/Source

[GTK] Add WebCoreHTML to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112727

Reviewed by Nico Weber.

WebCore.gyp/WebCoreGTK.gyp: Add support for building all files under

the HTML directory. This includes splitting off common WebCore dependencies
into an aggregate target and adding a top-level WebCore target.

4:43 PM Changeset in webkit [146679] by timothy_horton@apple.com

8 edits in trunk/Source

Plugin Snapshotting: Auto-start dominant plugins
https://bugs.webkit.org/show_bug.cgi?id=113111
<rdar://problem/13475726>

Reviewed by Dean Jackson.

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):
Acknowledge the new "Restarting" DisplayState.

html/HTMLPlugInElement.h:

Rename PlayingWithPendingMouseClick to RestartingWithPendingMouseClick for accuracy.
Add "Restarting" DisplayState, so we can be aware that the plugin is intentionally restarting and not re-snapshot it.

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::classNameForShadowRoot): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Restart the plugin when it becomes primary.
(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):
Move the plugin to Restarting unless it's already marked as PendingMouseClick.
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired): Match the PlayingWithPendingMouseClick rename.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Don't snapshot if we're restarting.

html/HTMLPlugInImageElement.h: Remove m_isPrimarySnapshottedPlugIn.
rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paint): Acknowledge the new "Restarting" DisplayState.
(WebCore::RenderSnapshottedPlugIn::getCursor): Acknowledge the new "Restarting" DisplayState.
(WebCore::RenderSnapshottedPlugIn::handleEvent): Match the PlayingWithPendingMouseClick rename.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::didInitializePlugin):
(WebKit::PluginView::paint):
(WebKit::PluginView::invalidateRect):
(WebKit::PluginView::isAcceleratedCompositingEnabled):
Acknowledge the new "Restarting" DisplayState.

4:43 PM Changeset in webkit [146678] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Mark test as expected to timeout.
https://bugs.webkit.org/show_bug.cgi?id=113114

Unreviewed, test expectations update.

platform/chromium/TestExpectations:

4:40 PM Changeset in webkit [146677] by Martin Robinson

8 edits
2 copies in trunk/Source

[GTK] Add support for building the WebCore bindings to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112638

Reviewed by Nico Weber.

Source/JavaScriptCore:

JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Export all include directories to direct

dependents and fix the indentation of the libjavascriptcore target.

Source/WebCore:

Add targets, actions, and rules for building the WebCore bindings. This is
the first part of the WebCoreGTK build.

WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Added.
WebCore.gyp/MakeNames.gypi: Added.
WebCore.gyp/WebCoreGTK.gyp: Added WebCore bindings build. This has been adapted

from the Chromium build.

WebCore.gypi: Updated list of derived sources files and added a parameter

for adjusting the location of the built files. We don't want to force the
Mac build to change, but we'd still like to reuse the scripts that the
Chromium build uses.

Source/WebKit/gtk:

gyp/Configuration.gypi.in: Added options for enabling SVG and setting the location of

the WebCore derived sources.

gyp/run-gyp: Include the gyp scripts directory on the Python path and make the WebCoreGTK

gyp file the default for the build.

4:29 PM Changeset in webkit [146676] by Martin Robinson

2 edits in trunk/Source/WebKit/gtk

[GTK] [gyp] Expose a few more compiler defines for the gyp build
https://bugs.webkit.org/show_bug.cgi?id=113109

Reviewed by Gustavo Noronha Silva.

gyp/Configuration.gypi.in: Expose the version number string and data

directory to the gyp build as command-line arguments.

4:28 PM Changeset in webkit [146675] by Martin Robinson

2 edits in trunk/Source/WebKit/gtk

[GTK] [gyp] Feature defines are not space separated
https://bugs.webkit.org/show_bug.cgi?id=113108

Reviewed by Gustavo Noronha Silva.

gyp/configure.ac: Properly export feature defines for gyp during

configure phase.

4:23 PM Changeset in webkit [146674] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Build fix in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=113092

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
Reviewed by Rob Buis.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementUnfocused):

4:12 PM Changeset in webkit [146673] by jer.noble@apple.com

2 edits in trunk/Source/WebKit2

After switching to another space and back, video races to catch up with audio
https://bugs.webkit.org/show_bug.cgi?id=113006

Reviewed by Anders Carlsson.

Add an observer for the NSWorkspaceActiveSpaceDidChangeNotification notification, and trigger
a visibility update when that notification is observed.

UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]): Unregister the observer.
(-[WKView _activeSpaceDidChange:]): Notify the view that its visibility may have changed.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): Add the observer.

4:11 PM Changeset in webkit [146672] by commit-queue@webkit.org

11 edits in trunk/Source

Add client callbacks to notify of changes of associated from controls
https://bugs.webkit.org/show_bug.cgi?id=110375

Patch by Dane Wallinga <dgwallinga@chromium.org> on 2013-03-22
Reviewed by Ryosuke Niwa.

Source/WebCore:

Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded.
Will be used to add autofill support for ajax-y webpages. e.g if while filling out a form, new fields
are dynamically created, autofill can know to re-query the autofill server and keep going.
https://bugs.webkit.org/show_bug.cgi?id=110375

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didAssociateFormControl):
(WebCore):
(WebCore::Document::didAssociateFormControlsTimerFired):

dom/Document.h:

(Document):
added method didAssociateFormControl, which batches form changes
and calls out to ChromeClient on a timer.

html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::resetFormOwner):
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore):

html/FormAssociatedElement.h:

(FormAssociatedElement):
add calls to Document::didAssociateFormControl when form changes

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedInto):
(WebCore):

html/HTMLFormElement.h:

add call to Document::didAssociateFormControl

loader/EmptyClients.h:

(EmptyChromeClient):
(WebCore::EmptyChromeClient::didAssociateFormControls):
(WebCore::EmptyChromeClient::shouldNotifyOnFormChanges):

page/ChromeClient.h:

(ChromeClient):
add new method didAssociateFormControls

Source/WebKit/chromium:

Implement form association methods of ChromeClient
to inform autofill of form changes after a page has loaded

public/WebAutofillClient.h:

(WebAutofillClient):
(WebKit::WebAutofillClient::didAssociateInput):
(WebKit::WebAutofillClient::didAddForm):
(WebKit::WebAutofillClient::didAssociateFormControls):

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::didAssociateFormControls):
(WebKit):
(WebKit::ChromeClientImpl::shouldNotifyOnFormChanges):

src/ChromeClientImpl.h:

(ChromeClientImpl):

4:04 PM Changeset in webkit [146671] by zmo@google.com

3 edits in branches/chromium/1410/Source/WebCore

Merge 145856 "Check to ensure MultisampleRenderbuffer creation s..."

Check to ensure MultisampleRenderbuffer creation succeeds
https://bugs.webkit.org/show_bug.cgi?id=111780

Patch by Brandon Jones <bajones@google.com> on 2013-03-14
Reviewed by Kenneth Russell.

On OSX systems using AMD graphics chips the allocation of large
Multisample Renderbuffers in Chromium would fail without any indication
of failure. Attempting to draw to the buffer resulted in garbage being
rendered onscreen. This could be reproduced by opening a full-page
WebGL app and pressing (Command + "-") several times. This patch adds an
additional check during DrawingBuffer resize to verify that the resized
buffer is valid.

platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
(WebCore::DrawingBuffer::checkBufferIntegrity):
(WebCore::DrawingBuffer::reset):

platform/graphics/gpu/DrawingBuffer.h:
(DrawingBuffer):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12843018

4:02 PM Changeset in webkit [146670] by schenney@chromium.org

139 edits
14 adds
11 deletes in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

The next round.

Too many files to list, plus ...

platform/chromium/TestExpectations:

4:00 PM Changeset in webkit [146669] by fpizlo@apple.com

11 edits in trunk/Source/JavaScriptCore

Fix some minor issues in the DFG's profiling of heap accesses
https://bugs.webkit.org/show_bug.cgi?id=113010

Reviewed by Goeffrey Garen.

1) If a CodeBlock gets jettisoned by GC, we should count the exit sites.

2) If a CodeBlock clears a structure stub during GC, it should record this, and
the DFG should prefer to not inline that access (i.e. treat it as if it had an
exit site).

3) If a PutById was seen by the baseline JIT, and the JIT attempted to cache it,
but it chose not to, then assume that it will take slow path.

4) If we frequently exited because of a structure check on a weak constant,
don't try to inline that access in the future.

5) Treat all exits that were counted as being frequent.

81% speed-up on Octane/gbemu. Small speed-ups elsewhere, and no regressions.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):
(JSC):
(JSC::CodeBlock::resetStubDuringGCInternal):
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::jettison):
(JSC::ProgramCodeBlock::jettisonImpl):
(JSC::EvalCodeBlock::jettisonImpl):
(JSC::FunctionCodeBlock::jettisonImpl):
(JSC::CodeBlock::tallyFrequentExitSites):

bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::tallyFrequentExitSites):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):

bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::StructureStubInfo):
(StructureStubInfo):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

dfg/DFGOSRExit.h:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
(OSRExit):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/Options.h:

(JSC):

3:49 PM Changeset in webkit [146668] by benjamin@webkit.org

2 edits in trunk/Source/WTF

Name correctly the argument of StringImpl::setIsAtomic()
https://bugs.webkit.org/show_bug.cgi?id=113000

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-22
Reviewed by Geoffrey Garen.

wtf/text/StringImpl.h:

(WTF::StringImpl::setIsAtomic):
The argument was probably an unfortunate copy-paste from setIsIdentifier().
Fix the name.

3:44 PM Changeset in webkit [146667] by ap@apple.com

7 edits
5 adds in trunk/Source/WebCore

Split ResourceHandleMac into multiple files
https://bugs.webkit.org/show_bug.cgi?id=113100

Reviewed by Geoff Garen.

It's grown too big to navigate, and I'm going to make WebCoreResourceHandleAsDelegate
substantially more complicated yet.

Mechanically moved WebCoreResourceHandleAsDelegate into separate files.
Refactored WebCoreSynchronousLoaderClient to be cross-platform, and moved it into separate files.

WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
platform/network/SynchronousLoaderClient.cpp: Added.
platform/network/SynchronousLoaderClient.h: Added.
platform/network/cf/ResourceHandleCFNet.cpp:
platform/network/mac/SynchronousLoaderClient.mm: Added.
platform/network/mac/WebCoreResourceHandleAsDelegate.h: Added.
platform/network/mac/WebCoreResourceHandleAsDelegate.mm: Added.

3:38 PM Changeset in webkit [146666] by schenney@chromium.org

491 edits
17 adds
13 deletes in trunk/LayoutTests

[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

SVG and Compositing tests

Too many files to list, plus ...

platform/chromium/TestExpectations:

3:24 PM Changeset in webkit [146665] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Fix the expected image result as r78910 committed a bad expected result.
See http://trac.webkit.org/changeset/78910/trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.png

platform/mac/editing/deleting/deletionUI-single-instance-expected.png:

3:19 PM Changeset in webkit [146664] by ggaren@apple.com

10 edits in trunk/Source

Added a setting for whether JavaScript markup is enabled
https://bugs.webkit.org/show_bug.cgi?id=112999

Reviewed by Maciej Stachowiak.

This setting is useful for clients that want protection from script
injection attacks.

../WebCore:

page/Settings.h:

(Settings): Clarified which clients should call canExecuteScripts().

page/Settings.in: Added the new setting.

../WebKit2:

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesGetJavaScriptMarkupEnabled):
(WKPreferencesSetJavaScriptMarkupEnabled):
(WKPreferencesGetJavaScriptEnabled):

UIProcess/API/C/WKPreferences.h:
UIProcess/API/mac/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup allowsJavaScriptMarkup]):
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]):

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Plumbed through to API.

3:19 PM Changeset in webkit [146663] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add a failing test expectation to media/track/track-prefer-captions.html on Windows after r146647.
The failure is tracked by the bug 113106.

platform/win/TestExpectations:

3:06 PM Changeset in webkit [146662] by rniwa@webkit.org

2 edits in trunk/LayoutTests

[Win] editing/pasteboard/can-read-in-copy-and-cut-events.html fails
https://bugs.webkit.org/show_bug.cgi?id=113102

Skip a test added by r146644 since writing into clipboard is not supported on Windows port.

platform/win/TestExpectations:

3:04 PM Changeset in webkit [146661] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix.

bindings/scripts/preprocessor.pm:

(applyPreprocessor):

3:03 PM Changeset in webkit [146660] by pdr@google.com

2 edits
8 adds in trunk/LayoutTests

Update svg/custom/marker-orient-auto expectations

Unreviewed update of test expectations.

platform/chromium-mac-lion/svg/custom/marker-orient-auto-expected.png: Added.
platform/chromium-mac-lion/svg/custom/marker-orient-auto-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/custom/marker-orient-auto-expected.png: Added.
platform/chromium-mac-snowleopard/svg/custom/marker-orient-auto-expected.txt: Added.
platform/chromium-mac/svg/custom/marker-orient-auto-expected.png: Added.
platform/chromium-mac/svg/custom/marker-orient-auto-expected.txt: Added.
platform/chromium-win/svg/custom/marker-orient-auto-expected.png: Added.
platform/chromium-win/svg/custom/marker-orient-auto-expected.txt: Added.
platform/chromium/TestExpectations:

2:14 PM Changeset in webkit [146659] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add failing test expectations for two more position: sticky tests to make Mac EWS happy.

platform/mac/TestExpectations:

2:12 PM Changeset in webkit [146658] by eric.carlson@apple.com

3 edits in branches/safari-536.30-branch/LayoutTests

Update results where white-space changed because of the change from testRunner" to "layoutTestController.

fast/block/float/float-not-removed-from-pre-block-expected.txt:
fast/css/image-set-value-not-removed-crash-expected.txt:

2:05 PM Changeset in webkit [146657] by rniwa@webkit.org

9 edits in trunk

NRWT: Enable pixel tests when retrying tests
https://bugs.webkit.org/show_bug.cgi?id=112898

Reviewed by Dirk Pranke.

Tools:

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
if we've forced pixel tests in the retry.
(Manager._run_tests):
(Manager._clean_up_run): Fixed the capitalizations.
(Manager._force_pixel_tests_if_needed): Added.

Scripts/webkitpy/layout_tests/models/test_run_results.py:

(_interpret_test_failures): Now that this function maybe called multiple times, only set
'image_diff_percent' if it doesn't already exist.

(summarize_results): When the first attempt resulted in a text failure and the second attempt
resulted in image and text failures and we've forced to run pixel tests in the retry run,
treat this as a regular regression instead of a flakiness.

Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
run had image diffs.

Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:

(summarized_results):

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
Also removed some dead code.

(RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
is set and pixel_tests_enabled is set to false.
(EndToEndTest.test_reftest_with_two_notrefs):

LayoutTests:

Link to images and image diff in retries when they're only available in retries.

fast/harness/resources/results-test.js: Added a test case.
fast/harness/results-expected.txt:
fast/harness/results.html:

(imageResultsCell): Extracted from tableRow.
(tableRow): Split the actual result into two tokens (first attempt and retry),
and then check if the image failure was detected in the first attempt. If not,
add hyperlinks to the actual results in the retry run.

2:00 PM Changeset in webkit [146656] by pdr@google.com

2 edits in trunk/LayoutTests

Update svg/custom/marker-orient-auto-expected test expectation.

Unreviewed update of test expectations.

platform/chromium/TestExpectations:

1:59 PM Changeset in webkit [146655] by schenney@chromium.org

4 edits in trunk/LayoutTests

[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

One more not-expected failure, fixed.

platform/chromium-mac-lion/fast/multicol/vertical-lr/nested-columns-expected.png:
platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:

1:57 PM Changeset in webkit [146654] by schenney@chromium.org

3 edits
4 adds in trunk/LayoutTests

[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

Some more currently failing (not expected) tests.

platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.png:
platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-expected.png:
platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.

1:51 PM Changeset in webkit [146653] by fpizlo@apple.com

4 edits
3 adds in trunk

DFG folding of PutById to SimpleReplace should consider the specialized function case
https://bugs.webkit.org/show_bug.cgi?id=113093

Reviewed by Geoffrey Garen and Mark Hahnenberg.

Source/JavaScriptCore:

bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

LayoutTests:

fast/js/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function-expected.txt: Added.
fast/js/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.html: Added.
fast/js/jsc-test-list:
fast/js/script-tests/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.js: Added.

(foo):
(baz):
(fuzz):

1:41 PM Changeset in webkit [146652] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add failing test expectations to the test added by r146644 on Mac.
The failure is tracked by http://webkit.org/b/113094.

platform/mac/TestExpectations:

1:36 PM Changeset in webkit [146651] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Unreviewed. Force kill gcc-3.exe during bindings generation tests to avoid process hangs.

This problem is occuring on the WinEWS bots where there are somehow multiple gcc-3 processes existing at the same time.
This is a speculative fix. There should only be 1 gcc-3.exe process running at a time ever.

bindings/scripts/preprocessor.pm:

(applyPreprocessor):

1:34 PM Changeset in webkit [146650] by timothy_horton@apple.com

5 edits in trunk/Tools

Make it possible to run layout tests on Retina MBP
https://bugs.webkit.org/show_bug.cgi?id=93673

Reviewed by Ryosuke Niwa.

Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
windows on 2x machines still run at 1x.

DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):
Reset the window resolution to 1x on creation.

DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
(WTR::PlatformWebView::PlatformWebView):
Add NSWindow details, reset the window resolution to 1x on creation.

1:30 PM Changeset in webkit [146649] by eric.carlson@apple.com

6 edits in branches/safari-536.30-branch/LayoutTests

<rdar://problem/13465764> Many merged tests are failing

Change all instances of "testRunner" back to "layoutTestController" in svg files, which
my initial commit missed.

fast/css/font-size-nan.svg:
svg/custom/stale-resource-data-crash.svg:
svg/custom/use-href-update-crash.svg:
svg/custom/use-rebuild-resources-crash.svg:
svg/text/alt-glpyh-on-fallback-font-crash.svg:

1:28 PM Changeset in webkit [146648] by wangxianzhu@chromium.org

1 edit in branches/chromium/1410/Source/WebCore/rendering/RenderLayerCompositor.cpp

Merge 144642 "Don't apply page scale to clipRect if applyPageSca..."

Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true
https://bugs.webkit.org/show_bug.cgi?id=111229

Patch by Min Qin <qinmin@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.

If applyPageScaleFactorInCompositor is set to true, webcore should use css coordinates.
As a result, we shouldn't apply page scale to clipRect in RenderLayerCompositor.
Layout tests set the flag to false, so we don't have anything to test against.

rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12797016

1:24 PM Changeset in webkit [146647] by eric.carlson@apple.com

11 edits in trunk/Source/WebCore

Cleanup text track selection logic
https://bugs.webkit.org/show_bug.cgi?id=113062

Reviewed by Jer Noble.

No new tests, covered by existing tests.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Remove.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Don't look at track attributes directly,

use captionPreferences->textTrackSelectionScore to calculate track rank.

(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_processingPreferenceChange here

instead of in captionPreferencesChanged.

(WebCore::HTMLMediaElement::captionPreferencesChanged): Don't suppress calls to setClosedCaptionsVisible,

existing code already makes sure we don't do unnecessary work.

html/HTMLMediaElement.h:

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Drive by cleanup, don't

process inactive cues.

html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::changedClosedCaptionsVisibility): Call resetTrackListMenu instead

of updateDisplay so we only mark the menu as needing a recalculation and do the work when
it is displayed.

page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::shouldShowCaptions): When in testing mode, return true if

the caption or subtitle preference has been set.

(WebCore::CaptionUserPreferences::setShouldShowCaptions): In testing mode, clear the caption

and subtitle preference when passed false.

(WebCore::CaptionUserPreferences::textTrackSelectionScore): Calculate the track score based on

track type preference and preferred language.

(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Score a track according to

the language presence and position in the preferred languages list.

page/CaptionUserPreferences.h:

page/CaptionUserPreferencesMac.h:
page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Calculate track language score

according to user preferences.

platform/Language.cpp:

(WebCore::indexOfBestMatchingLanguageInList): Repurposed the static bestMatchingLanguage

function to return the location of a language in a Vector.

(WebCore::preferredLanguageFromList): Removed.

platform/Language.h:

1:16 PM Changeset in webkit [146646] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Build fix for TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=113087

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-22
Reviewed by Martin Robinson.

This is a trivial build fix for clutter ac backend. Clutter AC backend doesn't use
TextureMapper so there is nowhere including TransformationMatrix.h.
For the reason, we include it explicitly.

No new tests because of no functionality change.

platform/graphics/clutter/GraphicsContext3DPrivate.cpp:
platform/graphics/clutter/GraphicsContext3DPrivate.h:

(WebCore):

1:14 PM Changeset in webkit [146645] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Coordinates.idl lacks Conditional=GEOLOCATION
https://bugs.webkit.org/show_bug.cgi?id=112949

Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Steve Block.

No new tests, build optimization only.

page/Coordinates.idl: Added GEOLOCATION conditional guard.

1:04 PM Changeset in webkit [146644] by dcheng@chromium.org

12 edits
4 adds in trunk

Data store should be readable in dragstart/copy/cut events
https://bugs.webkit.org/show_bug.cgi?id=23695

Reviewed by Tony Chang.

Source/WebCore:

There were several events where data could be written but not read back due to the fact that
different Clipboard method implementations checked permissions inconsistently. This patch
adds helper methods to check if an operation is permitted on a Clipboard and refactors all
direct comparisons against Clipboard::m_policy to use the new helpers instead. This fixes
several bugs where Clipboard::types and Clipboard::getData are not usable inside the
aforementioned events.

Tests: editing/pasteboard/can-read-in-copy-and-cut-events.html

editing/pasteboard/can-read-in-dragstart-event.html

dom/Clipboard.cpp:

(WebCore::Clipboard::canReadTypes): Formerly restricted to ClipboardReadable and

ClipboardTypesReadable; now allows ClipboardWritable as
well.

(WebCore::Clipboard::canReadData): Formerly restricted to ClipboardReadable; now allows

ClipboardWritable as well.

(WebCore::Clipboard::canWriteData):
(WebCore::Clipboard::canSetDragImage):
(WebCore::Clipboard::hasFileOfType):
(WebCore::Clipboard::hasStringOfType):
(WebCore::Clipboard::setDropEffect):
(WebCore::Clipboard::setEffectAllowed):

dom/Clipboard.h:

(Clipboard):

platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::clearData):
(WebCore::ClipboardBlackBerry::clearAllData):
(WebCore::ClipboardBlackBerry::getData):
(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::types):

platform/chromium/ClipboardChromium.cpp:

(WebCore::DataTransferItemPolicyWrapper::kind):
(WebCore::DataTransferItemPolicyWrapper::type):
(WebCore::DataTransferItemPolicyWrapper::getAsString):
(WebCore::DataTransferItemPolicyWrapper::getAsFile):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::clearAllData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::files):
(WebCore::ClipboardChromium::setDragImage):

platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::clearData):
(WebCore::ClipboardGtk::clearAllData):
(WebCore::ClipboardGtk::getData):
(WebCore::ClipboardGtk::setData):
(WebCore::ClipboardGtk::types):
(WebCore::ClipboardGtk::files):
(WebCore::ClipboardGtk::setDragImage):

platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::clearData):
(WebCore::ClipboardMac::clearAllData):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::types):
(WebCore::ClipboardMac::files):
(WebCore::ClipboardMac::setDragImage):

platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::clearData):
(WebCore::ClipboardQt::clearAllData):
(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::setData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):
(WebCore::ClipboardQt::setDragImage):
(WebCore::ClipboardQt::items):

platform/qt/DataTransferItemListQt.cpp:

(WebCore::DataTransferItemListQt::length):
(WebCore::DataTransferItemListQt::item):
(WebCore::DataTransferItemListQt::deleteItem):
(WebCore::DataTransferItemListQt::clear):
(WebCore::DataTransferItemListQt::add):

platform/qt/DataTransferItemQt.cpp:

(WebCore::DataTransferItemQt::getAsString):

platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::clearData):
(WebCore::ClipboardWin::clearAllData):
(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::setData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):
(WebCore::ClipboardWin::setDragImage):

LayoutTests:

editing/pasteboard/can-read-in-copy-and-cut-events-expected.txt: Added.
editing/pasteboard/can-read-in-copy-and-cut-events.html: Added.
editing/pasteboard/can-read-in-dragstart-event-expected.txt: Added.
editing/pasteboard/can-read-in-dragstart-event.html: Added.

1:00 PM Changeset in webkit [146643] by schenney@chromium.org

16 edits
1 add in trunk/LayoutTests

[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

Only the things failing on the bots, not already accounted for.

platform/chromium-linux/fast/text/international/danda-space-expected.png:
platform/chromium-mac-lion/fast/multicol/vertical-rl/nested-columns-expected.png:
platform/chromium-mac-lion/fast/ruby/base-shorter-than-text-expected.png:
platform/chromium-mac-lion/fast/text/emphasis-combined-text-expected.png:
platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png:
platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
platform/chromium/TestExpectations:

12:44 PM Changeset in webkit [146642] by abucur@adobe.com

2 edits in trunk/Source/WebCore

[CSS Regions] Remove pushLayoutState(RenderFlowThread*) from RenderView
https://bugs.webkit.org/show_bug.cgi?id=113084

Reviewed by Dirk Schulze.

Remove void pushLayoutState(RenderFlowThread*, bool regionsChanged) from RenderView.h because it's not used.

Tests: Code cleanup. No tests needed.

rendering/RenderView.h:

(RenderView):

12:34 PM Changeset in webkit [146641] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

Check focused node reference when traversing through history
https://bugs.webkit.org/show_bug.cgi?id=113082

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
Reviewed by Rob Buis.

PR312101
Check if we have a valid node and document before attempting to access its frame and
frame selection. This is causing issues when going back to a page after a redirect
where a stale pointer is used.
Further, the focused node should be changed after the frame is fully loaded.

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::restoreViewState):

12:23 PM Changeset in webkit [146640] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

[EFL] Fix build issues to enable CSS Filter and Shaders support.
https://bugs.webkit.org/show_bug.cgi?id=111274

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-22
Reviewed by Noam Rosenthal.

This is in preperation to enable CSS Filter and Shaders support.
This patch fixes related build issues to enable the support.

platform/graphics/surfaces/efl/GLTransportSurface.cpp:
platform/graphics/texmap/TextureMapper.cpp:
platform/graphics/texmap/TextureMapper.h:

(WebCore):

platform/graphics/texmap/TextureMapperGL.cpp:
platform/graphics/texmap/TextureMapperGL.h:

(WebCore):

platform/graphics/texmap/TextureMapperShaderProgram.h:

12:11 PM Changeset in webkit [146639] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Remove Android platform expectations from Chromium TestExpectations.
(Too many bug URLs to list)

Unreivewed, test expectations update.

platform/chromium/TestExpectations:

12:01 PM Changeset in webkit [146638] by falken@chromium.org

4 edits in trunk/Source/WebCore

Implement isEnabledFormControl() for SliderThumbElement and SpinButtonElement in terms of disabled()
https://bugs.webkit.org/show_bug.cgi?id=112993

Reviewed by Kent Tamura.

This is an intermediate step for refactoring Node::disabled and
Element::isEnabledFormControl. All classes that override
isEnabledFormControl just return !disabled(), except for
SliderThumbElement and SpinButtonElement. This patch changes those two
classes to do so, which shows that the two functions are redundant and
easy to refactor into a single function in a subsequent patch.

No new tests, there should be no behavior change.

html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::disabled):
(WebCore):
(WebCore::SliderThumbElement::isEnabledFormControl):

html/shadow/SliderThumbElement.h:

(SliderThumbElement):

html/shadow/SpinButtonElement.h: The check of shadowHost() is

necessary because it can be detached by JavaScript that runs during
event handling (see r76566)

11:47 AM Changeset in webkit [146637] by mario@webkit.org

4 edits in trunk/Source

[GTK] Include the right GL header for GLES2
https://bugs.webkit.org/show_bug.cgi?id=113034

Reviewed by Martin Robinson.

Include GLES2/gl2.h when using GLES2.

Source/WebKit/gtk:

WebCoreSupport/AcceleratedCompositingContextGL.cpp:

Source/WebKit2:

WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

11:38 AM Changeset in webkit [146636] by eric.carlson@apple.com

2 edits in branches/safari-536.30-branch/LayoutTests

Add the newline at end of the test results, apparently lost when merging r131709.

fast/forms/textarea/textarea-autofocus-removal-while-focusing-with-style-expected.txt:

11:30 AM Changeset in webkit [146635] by pdr@google.com

3 edits
2 copies in branches/chromium/1410

Merge 146227 "Separate SVG image size and container size"

Separate SVG image size and container size
https://bugs.webkit.org/show_bug.cgi?id=112651

Reviewed by Stephen Chenney.

Source/WebCore:

Previously, SVG images could retain their cached size between reloads due to a bug where an
old container size would be re-used if the image's new container size was not available yet.

This patch changes SVGImage::size() to return the intrinsic size of the image before a
container size has been set. SVGImageCache::imageSizeForRenderer will now return the
image's intrinsic size instead of a cached value if the container size cannot be looked up.
In javascript, querying [SVGImage].width will now return either the image's intrinsic size
or the size of 'imageForContainer'.

Test: svg/as-image/svg-container-size-after-reload.html

svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::dataChanged):

svg/graphics/SVGImage.h:

The member variable 'm_intrinsicSize' has been added to track the image's intrinsic
size. This term can be found in: http://www.w3.org/TR/css3-images/#default-sizing

svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageSizeForRenderer):
(WebCore::SVGImageCache::imageForRenderer):

In both of these functions, image has been renamed to imageForContainer here to clarify
that the cached container size is being returned, not the image's intrinsic size.

LayoutTests:

svg/as-image/svg-container-size-after-reload-expected.txt: Added.
svg/as-image/svg-container-size-after-reload.html: Added.

TBR=pdr@google.com
Review URL: https://codereview.chromium.org/13008026

11:28 AM Changeset in webkit [146634] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Hit Test doesn't need to be active
https://bugs.webkit.org/show_bug.cgi?id=113072

Patch by Genevieve Mak <gmak@rim.com> on 2013-03-22
Reviewed by Rob Buis.

Reviewed Internally By Mike Lattanzio.
PR #306074

WebKitSupport/ProximityDetector.cpp:

(BlackBerry::WebKit::ProximityDetector::findBestPoint):

11:27 AM Changeset in webkit [146633] by alecflett@chromium.org

6 edits
2 adds in trunk/Source/WebKit/chromium

[chromium] Support Quota API in Worker
https://bugs.webkit.org/show_bug.cgi?id=112713

Hook up WebKit side of queryUsageAndQuota. Tests
and WebCore code will come in https://bugs.webkit.org/show_bug.cgi?id=112972

Reviewed by David Levin.

WebKit.gyp:
public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::queryUsageAndQuota):

src/StorageQuotaChromium.cpp:

(WebCore::StorageQuota::queryUsageAndQuota):
(WebCore::StorageQuota::requestQuota):

src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::queryUsageAndQuota):
(WebKit):

src/WebWorkerClientImpl.h:
src/WorkerStorageQuotaCallbacksBridge.cpp: Added.

(WebKit):
(MainThreadStorageQuotaCallbacks):
(WebKit::MainThreadStorageQuotaCallbacks::createLeakedPtr):
(WebKit::MainThreadStorageQuotaCallbacks::~MainThreadStorageQuotaCallbacks):
(WebKit::MainThreadStorageQuotaCallbacks::didQueryStorageUsageAndQuota):
(WebKit::MainThreadStorageQuotaCallbacks::didFail):
(WebKit::MainThreadStorageQuotaCallbacks::didGrantStorageQuota):
(WebKit::MainThreadStorageQuotaCallbacks::MainThreadStorageQuotaCallbacks):
(WorkerStorageQuotaContextObserver):
(WebKit::WorkerStorageQuotaContextObserver::create):
(WebKit::WorkerStorageQuotaContextObserver::notifyStop):
(WebKit::WorkerStorageQuotaContextObserver::WorkerStorageQuotaContextObserver):
(WebKit::WorkerStorageQuotaCallbacksBridge::stop):
(WebKit::WorkerStorageQuotaCallbacksBridge::cleanUpAfterCallback):
(WebKit::WorkerStorageQuotaCallbacksBridge::WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::~WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::postQueryUsageAndQuotaToMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::queryUsageAndQuotaOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didFailOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didQueryStorageUsageAndQuotaOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didFailOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didQueryStorageUsageAndQuotaOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::runTaskOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::runTaskOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::mayPostTaskToWorker):

src/WorkerStorageQuotaCallbacksBridge.h: Added.

(WebCore):
(WebKit):
(WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::create):

11:13 AM Changeset in webkit [146632] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add a failure test expectation to media/track/track-user-preferences.html after r146380.
The failure is tracked by the webkit.org/b/113083.

platform/mac/TestExpectations:

11:08 AM Changeset in webkit [146631] by eric.carlson@apple.com

2 edits in branches/safari-536.30-branch/LayoutTests

Merge r135523 to get the updated test results.

2012-11-22 Daniel Bates <dbates@webkit.org>

JavaScript fails to concatenate large strings
<https://bugs.webkit.org/show_bug.cgi?id=102963>

Update test result.

fast/js/concat-large-strings-crash-expected.txt:

10:51 AM Changeset in webkit [146630] by allan.jensen@digia.com

5 edits in trunk

[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt.
https://bugs.webkit.org/show_bug.cgi?id=112668

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Qt adds word-spacing to leading spaces, but WebCore only expects
us to add for trailing spaces. We only corrected for this in width
calculation but do need to also do it for drawing.

Instead of subtracting the extra word-spacing we now configure the
FormatRange not to apply to leading spaces. This means this behavior
will be applied everywhere reliably.

platform/graphics/Font.h:

(Font):

platform/graphics/qt/FontQt.cpp:

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::initFormatForTextLayout):

LayoutTests:

platform/qt/TestExpectations:

10:41 AM Changeset in webkit [146629] by jsbell@chromium.org

2 edits in trunk/Source/WebCore

REGRESSION (r146540?): Crashes in storage/indexeddb/factory-basics-workers.html, storage/indexeddb/transaction-error.html
https://bugs.webkit.org/show_bug.cgi?id=113019

Reviewed by Tony Chang.

Also manifesting flakily under Chromium's content_shell. It's an ASSERT being hit in
the IDBTransaction destructor. The cause was r146540 which allows a stopped context
to reclaim script wrappers. This allows the IDBTransaction to be deref'd at times where
it previously would have just leaked. Modulate the destructor assertions to account
for this case.

No new tests; failures already manifest as flaky crashes in some ports.

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::~IDBTransaction): If context is stopped, expected state
transitions/cleanup may not have occurred before destructor runs.

10:34 AM Changeset in webkit [146628] by dgrogan@chromium.org

4 edits in trunk/Source

IndexedDB: Histogram available disk space on attempt to open database
https://bugs.webkit.org/show_bug.cgi?id=112862

Reviewed by Tony Chang.

Source/Platform:

chromium/public/Platform.h:

(WebKit::Platform::availableDiskSpaceInBytes):
(Platform):

Source/WebCore:

ChromeOS suspects they might be hitting disk corruption when the disks
are nearly full. This patch logs the available space to either the
"success" or the "fail" histogram as appropriate so that the
distributions can be compared.

No new tests - I don't know of a good way to test histograms. Local
printf testing didn't turn up any bugs.

platform/leveldb/LevelDBDatabase.cpp:

(WebCore::HistogramFreeSpace):
(WebCore):
(WebCore::LevelDBDatabase::open):

10:11 AM Changeset in webkit [146627] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection overlay clipped incorrectly
https://bugs.webkit.org/show_bug.cgi?id=113069

Patch by Andrew Lo <anlo@rim.com> on 2013-03-22
Reviewed by George Staikos.
Internally reviewed by Arvid Nilsson.

As a follow-up to r146278, the clip rect also needs to be
adjusted by the parent's offset when drawing the
selection overlay.

WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::paintContents):

10:05 AM Changeset in webkit [146626] by Nate Chapin

5 edits
3 adds in trunk

REGRESSION (r146239): Reproducible crash in WebCore::DocumentLoader::responseReceived.
https://bugs.webkit.org/show_bug.cgi?id=112811

Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/cache/x-frame-options-304.html

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::switchClientsToRevalidatedResource):

loader/cache/CachedRawResource.h:

LayoutTests:

http/tests/cache/resources/x-frame-options.php: Added.
http/tests/cache/x-frame-options-304-expected.txt: Added.
http/tests/cache/x-frame-options-304.html: Added.

10:03 AM Changeset in webkit [146625] by rniwa@webkit.org

3 edits in trunk/Tools

Leak bots shouldn't build
https://bugs.webkit.org/show_bug.cgi?id=112774

Reviewed by Simon Fraser.

Since leak bots use regular debug builds, there is no need to build on these bots.
Simply downloading builds will dramatically improve the cycle time of these bots.

BuildSlaveSupport/build.webkit.org-config/config.json:
BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
TestFactory instead of BuildAndTestFactory.

9:58 AM Changeset in webkit [146624] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add flaky crash expectations on some media tests per bugs 113075 and 113076.

platform/win/TestExpectations:

9:41 AM Changeset in webkit [146623] by wangxianzhu@chromium.org

10 edits
3 copies in branches/chromium/1410

Merge 146129 "Variant of non-primary fell-back SVGFont causes cr..."

Variant of non-primary fell-back SVGFont causes crash.
https://bugs.webkit.org/show_bug.cgi?id=112367

Reviewed by Stephen Chenney.

Source/WebCore:

Don't go to PlatformFontData path for SimpleFontData::createScaledFontData()
for SVG fonts.

Test: svg/css/font-face-variant-crash.html

platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::~SimpleFontData):
(WebCore::SimpleFontData::createScaledFontData): Don't go to PlatformFontData path for SVG fonts.
(WebCore):

platform/graphics/SimpleFontData.h:
(SimpleFontData): Added createScaledFontData and renamed the original createScaledFontData to platformCreateScaledFontData.

BTW, Removed unreferenced commonInit.

platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Renamed from createScaledFontData.

platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

LayoutTests:

resources/SpaceOnly.otf: Added. A font containing only the space glyph for testing font fallback.
svg/css/font-face-variant-crash-expected.txt: Added.
svg/css/font-face-variant-crash.html: Added.

TBR=wangxianzhu@chromium.org

9:24 AM Changeset in webkit [146622] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

REGRESSION: -webkit-box-reflect does not show on video elements
https://bugs.webkit.org/show_bug.cgi?id=112397

Reviewed by Eric Carlson.

Work around the ASSERTs generated when setting an AVPlayerLayer's player property
during a CA flush by setting the player property during the next runloop, outside
of a CA flush.

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::clone):

9:22 AM Changeset in webkit [146621] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Curl] Performance fix, avoid loading cookie file on every request.
https://bugs.webkit.org/show_bug.cgi?id=113023

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-22
Reviewed by Brent Fulgham.

We currently load the cookie file on every request, and when setting cookies from JavaScript, by using the option CURLOPT_COOKIEFILE.
This is very inefficient as the cookie file can get quite large, and file I/O is slow.
It is sufficient to load the cookie file on startup, as we use a shared cookie database between the requests.

platform/network/curl/CookieJarCurl.cpp:

(WebCore::setCookiesFromDOM): Avoid loading cookie file when setting cookies from JavaScript.

platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle): Avoid loading cookie file on every request.
(WebCore::ResourceHandleManager::initCookieSession): Load the cookie file to shared database on startup.

9:08 AM Changeset in webkit [146620] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Update Input field Background Color
https://bugs.webkit.org/show_bug.cgi?id=113063

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-22
Reviewed by George Staikos.

RIM PR 307463.
Internally reviewed by Ed Baker.

platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintTextFieldOrTextAreaOrSearchField):

8:56 AM Changeset in webkit [146619] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: FlameChart. Draw function names over flame chart bar if they fit into the bar.
https://bugs.webkit.org/show_bug.cgi?id=113052

Reviewed by Vsevolod Vlasov.

The draw function will draw the bar title if the text is less than bar width.
Unfortunately almost all the projects which need to be profiled
use long function names with dots. So if the function name has dots and
doesn't fit into the space then prepareTitle will try to drop the prefix before dot.
If the title has no dots then the function will strip the tail of the title.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._prepareTitle):

8:55 AM Changeset in webkit [146618] by yurys@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Update test expectations for a bunch of softwarecompositing tests.

platform/chromium/TestExpectations:

8:44 AM Changeset in webkit [146617] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Add "hidden" attribute to the recently added APIs in Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=113061

Added "hidden": true to the APIs introduced since version 1.0.

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-22
Reviewed by Pavel Feldman.

inspector/Inspector.json:

8:39 AM Changeset in webkit [146616] by schenney@chromium.org

4 edits in trunk

Source/WebKit/chromium: Skia flag removal to enable bug fixes and performance improvements.

Unreviewed code enabling.

skia_webkit.gyp:

LayoutTests: Enabling Skia features/modifications.

Unreviewed Chromium expectations, all of which will be removed later today.

platform/chromium/TestExpectations:

8:22 AM Changeset in webkit [146615] by vsevik@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: Correctly implement scrollToLine, revealLine and setSelection on CodeMirror editor.
https://bugs.webkit.org/show_bug.cgi?id=113028

Reviewed by Pavel Feldman.

Added focus event handler to CodeMirror editor view elememnt to support inspector's focus model.
Added selection and scroll listeners to correctly save editor scroll and selection in history.
Implemented revealLine, scrollToLine and setSelection.
Note: CodeMirror's coordsChar method does not work correctly in "local" mode, implemented as binary search
as a temporary workaround.

inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.defaultFocusedElement):
(WebInspector.CodeMirrorTextEditor.prototype._handleElementFocus):
(WebInspector.CodeMirrorTextEditor.prototype.revealLine):
(WebInspector.CodeMirrorTextEditor.prototype._coordsChar):
(WebInspector.CodeMirrorTextEditor.prototype._topScrolledLine):
(WebInspector.CodeMirrorTextEditor.prototype._bottomScrolledLine):
(WebInspector.CodeMirrorTextEditor.prototype._scroll):
(WebInspector.CodeMirrorTextEditor.prototype._selectionChange):
(WebInspector.CodeMirrorTextEditor.prototype.scrollToLine):
(WebInspector.CodeMirrorTextEditor.prototype.setSelection):
(WebInspector.CodeMirrorTextEditor.prototype.copyRange):

inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.copyRange):

8:16 AM Changeset in webkit [146614] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: [Regression] Editor scroll is not restored after inspector reload.
https://bugs.webkit.org/show_bug.cgi?id=113027

Reviewed by Pavel Feldman.

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype._isEditorShowing):
(WebInspector.SourceFrame.prototype._innerHighlightLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerRevealLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerScrollToLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerSetSelectionIfNeeded):

8:15 AM WebKitGTK/2.0.x edited by dimstar@opensuse.org

Add bug 113036 to the list. (diff)

8:04 AM Changeset in webkit [146613] by allan.jensen@digia.com

5 edits in trunk/Source/WebCore

[Qt] Fix build with OPENCL 1.2
https://bugs.webkit.org/show_bug.cgi?id=113056

Reviewed by Kenneth Rohde Christiansen.

Switch qmake checks to the modern style which means we can enable OpenCL with
WEBKIT_CONFIG+=opencl.

Upgrade OpenCL 1.1 clCreateImage2D to OpenCL 1.2 clCreateImage calls.

Target.pri:
WebCore.pri:
platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::createOpenCLImageResult):

platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:

(WebCore::FilterContextOpenCL::createOpenCLImage):

7:59 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

7:57 AM Changeset in webkit [146612] by kov@webkit.org

1 edit
1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146611 - Telugu [te] language translation submission for WebKitGTK+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=103052

Patch by Krishnababu Krothapalli <kkrothap@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

te.po: Added.

7:54 AM Changeset in webkit [146611] by kov@webkit.org

1 edit
1 add in trunk/Source/WebCore/platform/gtk/po

Telugu [te] language translation submission for WebKitGTK+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=103052

Patch by Krishnababu Krothapalli <kkrothap@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

te.po: Added.

7:45 AM Changeset in webkit [146610] by eae@chromium.org

8 edits
1 add
2 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines for r146600.

platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
platform/chromium-mac-lion/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:

7:42 AM Changeset in webkit [146609] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK][AC] Opacity animation doesn't work with clutter backend
https://bugs.webkit.org/show_bug.cgi?id=110347

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-22
Reviewed by Gustavo Noronha Silva.

The static casting in ternary operator doesn't change actual inputted argument type.
So I replaced it with if-else statement.

Covered by existing animation tests.

platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):

7:38 AM Changeset in webkit [146608] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[GTK][AC] Add removing animations procedure with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=110607

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-22
Reviewed by Gustavo Noronha Silva.

This changes is based on mac port implementation. The only different thing is
that updateAnimations is called explicitly in destructor of GraphicsLayerClutter
to remove uncommitted animations. Because even though we call notifyFlushRequired
to remove existing animations in removeAnimation(), removeClutterAnimationFromLayer
has been never reached since the root layer is destroyed before. It means
that we haven't lost a change to remove actual animations from clutterActor.

Covered by existing animation tests.

platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::removeAnimation):
(WebCore):
(WebCore::GraphicsLayerClutter::removeClutterAnimationFromLayer):

platform/graphics/clutter/GraphicsLayerClutter.h:

(WebCore::GraphicsLayerClutter::animationIsRunning):
(GraphicsLayerClutter):

7:28 AM Changeset in webkit [146607] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[EFL][WebGL] Optimize AlphaOp for HTMLVideoElement input.
https://bugs.webkit.org/show_bug.cgi?id=113049

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-22
Reviewed by Kenneth Rohde Christiansen.

Covered by existing tests.

Changeset 137397 implemented optimisation to avoid any
unnecessary Unmultiply or Premultiply operation in unpack/pack
provided the Image source is from HTMLVideoElement. This patch
enables the same for EFL port.

platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

7:27 AM Changeset in webkit [146606] by eae@chromium.org

8 edits
5 adds in trunk/LayoutTests

Unreviewed chromium and apple mac rebaselines for r146600.

platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
platform/chromium-mac-lion/fast/transforms/bounding-rect-zoom-expected.txt: Added.
platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
platform/chromium/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
platform/chromium/fast/transforms/bounding-rect-zoom-expected.txt: Added.
platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:

7:24 AM Changeset in webkit [146605] by timothy@apple.com

2 edits in trunk/Source/WebKit2

Fix an assert when opening the Web Inspector window for the first time.

rdar://problem/13471765
https://webkit.org/b/113053

Reviewed by Eric Carlson.

UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Assign m_inspectorWindow
earlier so it is ready for when center is called and windowDidMove: gets called.

7:22 AM Changeset in webkit [146604] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

BUILD FIX (r146558): Build testapi.mm with ARC enabled for armv7s
<http://webkit.org/b/112608>

Fixes the following build failure:

Source/JavaScriptCore/API/tests/testapi.mm:205:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]
}
^{1 error generated.}

Configurations/ToolExecutable.xcconfig: Enable ARC for armv7s

architecture.

6:53 AM Changeset in webkit [146603] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

Revert "BUILD FIX (r146558): Call [super dealloc] from -[TinyDOMNode dealloc]"

This fixes a build failure introduced by this change:

Source/JavaScriptCore/API/tests/testapi.mm:206:6: error: ARC forbids explicit message send of 'dealloc'

[super dealloc];

^~

1 error generated.

Not sure why this didn't fail locally on my Mac Pro.

API/tests/testapi.mm:

(-[TinyDOMNode dealloc]): Remove call to [super dealloc].

6:46 AM Changeset in webkit [146602] by zarvai@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Missed one in r146589.

platform/qt/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Rebaselining after r146531.

6:43 AM Changeset in webkit [146601] by tommyw@google.com

13 edits in trunk

Source/WebCore: Clean up the speech recognintion API
https://bugs.webkit.org/show_bug.cgi?id=112916

Reviewed by Adam Barth.

This patch cleans away deprecated parts, fixes so that stop() can be called more than once and adds
the missing emma attribute on SpeechRecognitionEvent (which is always null).

Patch covered by existing tests.

Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::stopFunction):
(WebCore::SpeechRecognition::abort):
(WebCore::SpeechRecognition::didEnd):
(WebCore::SpeechRecognition::SpeechRecognition):

Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

Modules/speech/SpeechRecognitionEvent.cpp:

(WebCore::SpeechRecognitionEvent::createResult):
(WebCore::SpeechRecognitionEvent::createNoMatch):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):

Modules/speech/SpeechRecognitionEvent.h:

(WebCore):
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::emma):

Modules/speech/SpeechRecognitionEvent.idl:

Source/WebKit/chromium: Clean up the speach recognintion API
https://bugs.webkit.org/show_bug.cgi?id=112916

Reviewed by Adam Barth.

public/WebSpeechRecognizerClient.h:
src/SpeechRecognitionClientProxy.cpp:
src/SpeechRecognitionClientProxy.h:

(SpeechRecognitionClientProxy):

LayoutTests: Clean up the speech recognintion API
https://bugs.webkit.org/show_bug.cgi?id=112916

Reviewed by Adam Barth.

fast/events/constructors/speech-recognition-event-constructor-expected.txt:
fast/events/constructors/speech-recognition-event-constructor.html:

6:40 AM Changeset in webkit [146600] by eae@chromium.org

8 edits
2 adds in trunk

Floor cell widths in AutoTableLayout::recalcColumn
https://bugs.webkit.org/show_bug.cgi?id=112922

Reviewed by Levi Weintraub.

Source/WebCore:

Table cells widths are floored to ensure even distribution of available
space across columns. The code path that computes the width of the
_table_ failed to take this into account and thus can over report the
total width of the table.

Test: fast/sub-pixel/table-with-subpixel-cell-size.html

rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn): Floor width to match column sizing logic.

LayoutTests:

Add test for table with subpixel cells and update existing baselines as needed.

fast/sub-pixel/table-with-subpixel-cell-size-expected.html: Added.
fast/sub-pixel/table-with-subpixel-cell-size.html: Added.
platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

6:35 AM Changeset in webkit [146599] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

BUILD FIX (r146558): Call [super dealloc] from -[TinyDOMNode dealloc]
<http://webkit.org/b/112608>

Fixes the following build failure:

Source/JavaScriptCore/API/tests/testapi.mm:205:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]
}
^{1 error generated.}

API/tests/testapi.mm:

(-[TinyDOMNode dealloc]): Call [super dealloc].

6:27 AM Changeset in webkit [146598] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

BUILD FIX (r146208): Export shouldPrintExceptions methods for iOS

Fixes the following build failure:

Undefined symbols for architecture i386:

"ZN7WebCore11PageConsole24setShouldPrintExceptionsEb", referenced from:

+[WebCoreStatistics setShouldPrintExceptions:] in WebCoreStatistics.o

"ZN7WebCore11PageConsole21shouldPrintExceptionsEv", referenced from:

+[WebCoreStatistics shouldPrintExceptions] in WebCoreStatistics.o

ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

WebCore.exp.in: Move symbols so they're exported for iOS as

well.

6:18 AM Changeset in webkit [146597] by commit-queue@webkit.org

6 edits
2 adds in trunk/Source/WebKit

[BlackBerry] Add custom BackForwardList client implementation
https://bugs.webkit.org/show_bug.cgi?id=113024

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-22
Reviewed by Rob Buis.

PR 310030
Internally reviewed by Joe Mason.

Source/WebKit:

PlatformBlackBerry.cmake: Add new files to compilation.

Source/WebKit/blackberry:

Adds a new class BackForwardListBlackBerry that implements
BackForwardList client and wraps the BackForwardListImpl including
the BlackBerry specific changes to notify the API layer when the
BackForwardList changes.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init): Create a
BackForwardListBlackBerry.
(BlackBerry::WebKit::WebPage::getBackForwardList): Use
BackForwardListBlackBerry instead of BackForwardListImpl.
(BlackBerry::WebKit::WebPage::clearBackForwardList): Ditto.

WebCoreSupport/BackForwardListBlackBerry.cpp: Added.

(WebCore):
(WebCore::BackForwardListBlackBerry::BackForwardListBlackBerry):
(WebCore::BackForwardListBlackBerry::~BackForwardListBlackBerry):
(WebCore::BackForwardListBlackBerry::current):
(WebCore::BackForwardListBlackBerry::notifyBackForwardListChanged):
(WebCore::BackForwardListBlackBerry::addItem):
(WebCore::BackForwardListBlackBerry::goToItem):
(WebCore::BackForwardListBlackBerry::itemAtIndex):
(WebCore::BackForwardListBlackBerry::backListCount):
(WebCore::BackForwardListBlackBerry::forwardListCount):
(WebCore::BackForwardListBlackBerry::isActive):
(WebCore::BackForwardListBlackBerry::close):
(WebCore::BackForwardListBlackBerry::clear):
(WebCore::BackForwardListBlackBerry::entries):
(WebCore::BackForwardListBlackBerry::currentItem):

WebCoreSupport/BackForwardListBlackBerry.h: Added.

(WebKit):
(WebCore):
(BackForwardListBlackBerry):
(WebCore::BackForwardListBlackBerry::create):

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

5:32 AM Changeset in webkit [146596] by kov@webkit.org

1 edit
1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146594 - [kn] Kannada Translation for webkit
https://bugs.webkit.org/show_bug.cgi?id=106301

Patch by Shankar Prasad <svenkate@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

kn.po: Added.

5:32 AM Changeset in webkit [146595] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146474 - [l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
https://bugs.webkit.org/show_bug.cgi?id=103035

Patch by Sandeep Shedmake <sshedmak@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

mr.po: updated.

5:31 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

5:29 AM Changeset in webkit [146594] by kov@webkit.org

1 edit
1 add in trunk/Source/WebCore/platform/gtk/po

[kn] Kannada Translation for webkit
https://bugs.webkit.org/show_bug.cgi?id=106301

Patch by Shankar Prasad <svenkate@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

kn.po: Added.

5:24 AM Changeset in webkit [146593] by jocelyn.turcotte@digia.com

2 edits in trunk/Tools

[Qt] Fix the TestWebKitAPI build
https://bugs.webkit.org/show_bug.cgi?id=113044

Reviewed by Tor Arne Vestbø.

The generate-forwarding-headers script would only be run
after the targets in InjectedBundle.pri since the second
addStrictSubdirOrderBetween call in
Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
the derived_sources -> injected_bundle order in SUBDIRS.

Fix it by only moving the dependent target at the end of
SUBDIRS, don't touch its dependency.

qmake/mkspecs/features/functions.prf:

5:14 AM Changeset in webkit [146592] by yurys@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed. Fix Chromium Win compilation after r146583.

bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::invokeReadyCallbackIfNeeded):

5:04 AM Changeset in webkit [146591] by loislo@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Chart has to be zoomed around the mouse pointer.
https://bugs.webkit.org/show_bug.cgi?id=113031

Reviewed by Yury Semikhatsky.

Overview grid is able to zoom around the mouse pointer.
So the simplest way is to translate x coordinate of the mouse pointer hovered over the chart
to x coordinate in term of overview window and pass it to the zoom function.

Minor unrelated fix: draw small border at bottom of the overview grid.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._onMouseWheel):

inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.prototype.zoom):

inspector/front-end/flameChart.css:

(#flame-chart-overview-container):

4:58 AM Changeset in webkit [146590] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Texmap] TextureMapperImageBuffer should not use rendering code for filters.
https://bugs.webkit.org/show_bug.cgi?id=113040

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-22
Reviewed by Kenneth Rohde Christiansen.

Disable TextureMapperImageBuffer filters, until they can be done the right way.
This should only disrupt accelerated filters in fallback mode, which is a very rare
use case.

No new testable functionality.

platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::applyFilters):

4:54 AM Changeset in webkit [146589] by zarvai@inf.u-szeged.hu

3 edits
8 moves
8 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r146469 and r146531. Cleaning up duplicated expecteds.

platform/qt-5.0-wk1/compositing/iframes/iframe-size-from-zero-expected.txt:
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed.
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Removed.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Removed.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Removed.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed.
platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.png.
platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png.
platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.png.
platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png.
platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
platform/qt/css3/filters/effect-reference-expected.txt:

4:29 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com

(diff)

4:26 AM Changeset in webkit [146588] by commit-queue@webkit.org

5 edits in trunk

Web Inspector: Report more CSS errors
https://bugs.webkit.org/show_bug.cgi?id=113022

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-22
Reviewed by Pavel Feldman.

Source/WebCore:

Reporting next few CSS syntax errors in declaration_list.

css/CSSGrammar.y.in:

LayoutTests:

inspector/console/console-css-warnings-expected.txt:
inspector/console/console-css-warnings.html:

4:00 AM Changeset in webkit [146587] by yurys@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: use individual samples to construct CPU profile flame chart
https://bugs.webkit.org/show_bug.cgi?id=112569

Reviewed by Pavel Feldman.

Added an optional array of samples to the CPU profile returned over the
protocol. Each sample is id of the profile node corresponding to the top frame
of the sample's stack trace. The array of samples if present is used to draw
the flame chart on the CPU profile panel, otherwise flame chart is drawn based
on the aggregated profile data.

bindings/js/ScriptProfile.cpp:

(WebCore::ScriptProfile::buildInspectorObjectForSamples):

bindings/js/ScriptProfile.h:

(ScriptProfile):

bindings/v8/ScriptProfile.cpp:

(WebCore::buildInspectorObjectFor):
(WebCore):
(WebCore::ScriptProfile::buildInspectorObjectForSamples):

bindings/v8/ScriptProfile.h:

(ScriptProfile):

bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::start):

inspector/Inspector.json:
inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getCPUProfile):

inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
(WebInspector.CPUProfileView.prototype._buildIdToNodeMap):

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._calculateTimelineData):

3:34 AM Changeset in webkit [146586] by commit-queue@webkit.org

2 edits in trunk

Cannot run All Source (target WebProcess) on Xcode.
https://bugs.webkit.org/show_bug.cgi?id=111042

Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-03-22
Reviewed by Alexey Proskuryakov.

WebProcessShim is renamed by r139066.
However, WebProcessShim is not renamed to SecItemShim in WebKit.xcworkspace.
This make WebProcess.app load WebProcessShim.dylib, and it cause dyld loading error.

WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme: Renamed WebProcessShim to SecItemShim.

3:08 AM Changeset in webkit [146585] by commit-queue@webkit.org

14 edits
1 move
1 delete in trunk/Source/WebCore

Use generated bindings for the Coordinates type used by Geolocation
https://bugs.webkit.org/show_bug.cgi?id=112975

Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Kentaro Hara.

No new tests, refactoring only.

CMakeLists.txt:
GNUmakefile.list.am:
Modules/geolocation/Coordinates.cpp: Renamed from Source/WebCore/bindings/js/JSCoordinatesCustom.cpp.

(WebCore):
(WebCore::Coordinates::altitude):
(WebCore::Coordinates::altitudeAccuracy):
(WebCore::Coordinates::heading):
(WebCore::Coordinates::speed):

Modules/geolocation/Coordinates.h:

(Coordinates):

Modules/geolocation/Coordinates.idl:
Target.pri:
UseJSC.cmake:
UseV8.cmake:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/v8/custom/V8CoordinatesCustom.cpp: Removed.

3:04 AM Changeset in webkit [146584] by commit-queue@webkit.org

16 edits
12 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: Incomplete datetime format should fallback to default
https://bugs.webkit.org/show_bug.cgi?id=113005

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-22
Reviewed by Kent Tamura.

Source/WebCore:

Use fallback format when datetime format from locale is not complete.

Tests: fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html

fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format.html
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html
fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html
fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html
fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html

html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(DateTimeFormatValidator): A helper class that parses datetime format and tests existence of fields.
(WebCore::DateTimeFormatValidator::DateTimeFormatValidator):
(WebCore::DateTimeFormatValidator::visitField):
(WebCore::DateTimeFormatValidator::validateFormat): Parses datetime format and validates by calling BaseMultipleFieldsDateAndTimeInputType::isValidFormat.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Checks if dateTimeFormat is valid, and uses fallback format if not.

html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Declare isValidFormat.

html/DateInputType.cpp:

(WebCore::DateInputType::isValidFormat): Added.

html/DateInputType.h:

(DateInputType):

html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::isValidFormat): Added.

html/DateTimeInputType.h:

(DateTimeInputType):

html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::isValidFormat): Added.

html/DateTimeLocalInputType.h:

(DateTimeLocalInputType):

html/MonthInputType.cpp:

(WebCore::MonthInputType::isValidFormat): Added.

html/MonthInputType.h:

(MonthInputType):

html/TimeInputType.cpp:

(WebCore::TimeInputType::isValidFormat): Added.

html/TimeInputType.h:

(TimeInputType):

html/WeekInputType.cpp:

(WebCore::WeekInputType::isValidFormat): Added.

html/WeekInputType.h:

(WeekInputType):

LayoutTests:

fast/forms/date-multiple-fields/date-multiple-fields-fallback-format-expected.txt: Added.
fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html: Added.
fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format-expected.txt: Added.
fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format.html: Added.
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format-expected.txt: Added.
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html: Added.
fast/forms/month-multiple-fields/month-multiple-fields-fallback-format-expected.txt: Added.
fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-fallback-format-expected.txt: Added.
fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html: Added.
fast/forms/week-multiple-fields/week-multiple-fields-fallback-format-expected.txt: Added.
fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html: Added.

2:54 AM Changeset in webkit [146583] by morrita@google.com

24 edits
14 adds in trunk

Custom Elements: "readyCallback" lifecycle callback should be called.
https://bugs.webkit.org/show_bug.cgi?id=112538

Reviewed by Elliott Sprehn.

Source/WebCore:

This change allows each custom element definition to hook up its instantiation,
namely "readyCallback" lifecycle callback.

The change has two parts:

1. Tracking which Element objects to be created.
2. Invoking appropriate JavaScript functions, which are readyCallback(), before the Element object is visible from page script.

For 1, CustomElementRegistry maintains list of "callback
invocaions". Each list item ("invocation") tracks the element
which has a lifecycle callback to be invoked. Each invocation is
registered when - Any custom element C++ object is instantiated.
See changes on CustomElementConstructor.cpp.

This also happens when @is attribute is set by the parser or node
cloning routine, which can turn a non-custom element into a
type-extended custom element. See changes on Element.cpp.

For 2, CustomElementRegistry basically follows what
MutationObserver is doing, and introduces a method called
deliverLifecycleCallbacks(). This function flushes all pending
callback invocations. You can think it as a dual of
MutationObserver::deliverAllMutations().

The delivery function is called places where MutationObserver's
deliverAllMutations() is called. In addition, it is also called
just before returning from a set of DOM APIs. For example, it is
called just before createElement() returns, so that possibly
created custom element becomes ready through its readyCallback().
Such APIs get "V8DeliverCustomElementCallbacks" IDL attribute. In
principle, APIs which can create new custom element instnaces are
marked. See CustomElementRegistry::CallbackDeliveryScope and
changes on CodeGeneratorV8.pm.

We need this extra work because the readyCallback() needs to give
an illusion so that JavaScript programmers feel like the
readyCallback() callback being called just after it is created,
instead of called on arbitrary late timing like MutationObserver
notifications.

Tests: fast/dom/custom/lifecycle-ready-createElement-recursion.html

fast/dom/custom/lifecycle-ready-createElement-reentrancy.html
fast/dom/custom/lifecycle-ready-creation-api.html
fast/dom/custom/lifecycle-ready-innerHTML.html
fast/dom/custom/lifecycle-ready-parser-only.html
fast/dom/custom/lifecycle-ready-parser-script.html
fast/dom/custom/lifecycle-ready-paste.html

bindings/scripts/CodeGeneratorV8.pm:
Hooked up CallbackDeliveryScope through V8DeliverCustomElementCallbacks attriute.

(GenerateCustomElementInvocationScopeIfNeeded):
(GenerateNormalAttrSetter):
(GenerateFunction):

bindings/scripts/IDLAttributes.txt:
bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::invokeReadyCallbackIfNeeded):
(WebCore::CustomElementHelpers::invokeReadyCallbacksIfNeeded):

bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):

bindings/v8/V8RecursionScope.cpp: Added deliverAllLifecycleCallbacks()

(WebCore::V8RecursionScope::didLeaveScriptContext):

dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::createElement):
(WebCore::CustomElementConstructor::createElementInternal):

dom/CustomElementConstructor.h:

(WebCore::CustomElementConstructor::isExtended):
(CustomElementConstructor):

dom/CustomElementRegistry.cpp: Adding element tracking and invocation execution.

(WebCore::CustomElementInvocation::CustomElementInvocation):
(WebCore::CustomElementInvocation::~CustomElementInvocation):
(WebCore::activeCustomElementRegistries):
(WebCore::CustomElementRegistry::~CustomElementRegistry):
(WebCore::CustomElementRegistry::didGiveTypeExtension):
(WebCore::CustomElementRegistry::didCreateElement):
(WebCore::CustomElementRegistry::activate):
(WebCore::CustomElementRegistry::deactivate):
(WebCore::CustomElementRegistry::deliverLifecycleCallbacks):
(WebCore::CustomElementRegistry::deliverAllLifecycleCallbacks):

dom/CustomElementRegistry.h:

(CustomElementInvocation):
(WebCore::CustomElementInvocation::element):
(CallbackDeliveryScope):
(WebCore::CustomElementRegistry::CallbackDeliveryScope::CallbackDeliveryScope):
(WebCore::CustomElementRegistry::CallbackDeliveryScope::~CallbackDeliveryScope):
(CustomElementRegistry):
(WebCore::CustomElementRegistry::deliverAllLifecycleCallbacksIfNeeded):

dom/Document.cpp:

(WebCore::Document::createElement):
(WebCore::Document::didCreateCustomElement):

dom/Document.h:

(Document):

dom/Document.idl:
dom/Element.cpp:

(WebCore::Element::attributeChangedFromParserOrByCloning): Added to catch @is attribute
(WebCore::Element::parserSetAttributes):
(WebCore::Element::cloneAttributesFromElement):

dom/Element.h:
dom/Node.idl:
dom/ShadowRoot.idl:
html/HTMLElement.idl:
html/parser/HTMLScriptRunner.cpp: Added deliverAllLifecycleCallbacks()

(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::runScript):

Source/WebKit/chromium:

src/WebKit.cpp: Added deliverAllLifecycleCallbacks()

Source/WTF:

wtf/HashSet.h:

(WTF::copyToVector): Generalized to let it accept variants like ListHahsSet instead of only HashSet.

LayoutTests:

fast/dom/custom/lifecycle-ready-createElement-recursion-expected.txt: Added.
fast/dom/custom/lifecycle-ready-createElement-recursion.html: Added.
fast/dom/custom/lifecycle-ready-createElement-reentrancy-expected.txt: Added.
fast/dom/custom/lifecycle-ready-createElement-reentrancy.html: Added.
fast/dom/custom/lifecycle-ready-creation-api-expected.txt: Added.
fast/dom/custom/lifecycle-ready-creation-api.html: Added.
fast/dom/custom/lifecycle-ready-innerHTML-expected.txt: Added.
fast/dom/custom/lifecycle-ready-innerHTML.html: Added.
fast/dom/custom/lifecycle-ready-parser-only-expected.html: Added.
fast/dom/custom/lifecycle-ready-parser-only.html: Added.
fast/dom/custom/lifecycle-ready-parser-script-expected.txt: Added.
fast/dom/custom/lifecycle-ready-parser-script.html: Added.
fast/dom/custom/lifecycle-ready-paste-expected.txt: Added.
fast/dom/custom/lifecycle-ready-paste.html: Added.

2:29 AM Changeset in webkit [146582] by tommyw@google.com

18 edits in trunk

MediaStream API: Finalize the RTCPeerConnection states
https://bugs.webkit.org/show_bug.cgi?id=112792

Reviewed by Adam Barth.

Source/Platform:

chromium/public/WebRTCPeerConnectionHandlerClient.h:

Source/WebCore:

This patch finalized the RTCPeerConnection state and events. These changes
have not yet pushed out to the editors draft; but they are uncontroversial
and agreed upon.

readyState will be deleted; please use the replacement signalingState which is already available.
onstatechange -> onsignalingstatechange
onicechange -> oniceconnectionstatechange
ongatheringchange will be deleted since oniceconnectionstatechange can be used for the same purpose.
RTCIceConnectionState::"starting" -> RTCIceConnectionState::"new"

Patch covered by modified tests.

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::iceConnectionState):
(WebCore::RTCPeerConnection::changeSignalingState):
(WebCore::RTCPeerConnection::changeIceGatheringState):
(WebCore::RTCPeerConnection::changeIceConnectionState):

Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

Modules/mediastream/RTCPeerConnection.idl:
dom/EventNames.h:

(WebCore):

platform/mediastream/RTCPeerConnectionHandlerClient.h:

Source/WebKit/chromium:

src/AssertMatchingEnums.cpp:

LayoutTests:

fast/mediastream/RTCPeerConnection-datachannel.html:
fast/mediastream/RTCPeerConnection-dtmf.html:
fast/mediastream/RTCPeerConnection-events-expected.txt:
fast/mediastream/RTCPeerConnection-events.html:
fast/mediastream/RTCPeerConnection-ice.html:
fast/mediastream/RTCPeerConnection-state-expected.txt:
fast/mediastream/RTCPeerConnection-state.html:

2:23 AM Changeset in webkit [146581] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL][WK2] View is not focused when fullscreen mode toggled
https://bugs.webkit.org/show_bug.cgi?id=113009

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-22
Reviewed by Laszlo Gombos.

Set focus on view when fullscreen mode enabled/disabled
by FullScreen API.

MiniBrowser/efl/main.c:

(on_fullscreen_accept):
(on_fullscreen_deny):

2:20 AM Changeset in webkit [146580] by mkwst@chromium.org

4 edits in trunk/Source/WebCore

Prefer 'KURL(ParsedURLString, String)' when dealing with known-good data.
https://bugs.webkit.org/show_bug.cgi?id=112965

Reviewed by Alexey Proskuryakov.

In https://bugs.webkit.org/show_bug.cgi?id=112783#c6, Adam noted that
it would be possible to use 'KURL(ParsedURLString, [url])' rather than
'KURL(KURL(), [url])', since we knew that the URL in question is a
value and absolute URL. This patch fixes the obvious instances of this
pattern; there are several more 'KURL(KURL(), String)' calls in
WebCore but these were the only places I was reasonably sure that bad
data couldn't creep in.

dom/Document.cpp:

(WebCore::Document::updateBaseURL):

'documentURI' is pulled from 'url()->string()'. It's safe.

page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

'CallFrame::sourceURL()' is a known valid/absolute URL.

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
(WebCore::SecurityOrigin::create):

The strings constructed here are certainly valid.

2:17 AM Changeset in webkit [146579] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip a now passing test after r146393.
https://bugs.webkit.org/show_bug.cgi?id=112904.

platform/qt/TestExpectations:

2:09 AM Changeset in webkit [146578] by commit-queue@webkit.org

3 edits
1 add in trunk/LayoutTests

[EFL] New baseline for accessibility/platform-name.html
https://bugs.webkit.org/show_bug.cgi?id=113018

Unreviewed EFL gardening

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-22

platform/efl-wk1/TestExpectations:
platform/efl-wk2/TestExpectations:
platform/efl/accessibility/platform-name-expected.txt: Added.

2:00 AM Changeset in webkit [146577] by loislo@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. move overview window when user scrolls the chart.
https://bugs.webkit.org/show_bug.cgi?id=113014

Reviewed by Yury Semikhatsky.

I found that I could use scaling mechanics in OverviewGrid for scaling the chart.
But the dragging part was not so simple due to the different approaches in
OverviewGrid and FlameChart. OverviewGrid used _windowLeft and _windowRight
when FlameChart used _xOffset and _xScaleFactor and width.
It was not practical and I rewrote the FlameChart mechanics
and now it also uses _windowLeft _windowRight.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.Calculator.prototype._updateBoundaries):
(WebInspector.FlameChart.Calculator.prototype.computePosition):
(WebInspector.FlameChart.prototype._onWindowChanged):
(WebInspector.FlameChart.prototype._startCanvasDragging):
(WebInspector.FlameChart.prototype._canvasDragging):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._onMouseWheel):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
(WebInspector.FlameChart.prototype._drawOverviewCanvas):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._updateBoundaries):
(WebInspector.FlameChart.prototype.update):

inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.prototype.setWindowPosition):
(WebInspector.OverviewGrid.prototype.setWindow):
(WebInspector.OverviewGrid.prototype.addEventListener):
(WebInspector.OverviewGrid.prototype.zoom):
(WebInspector.OverviewGrid.Window.prototype._zoom):

inspector/front-end/inspectorCommon.css:

(.overview-grid-window-rulers):

1:56 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

1:52 AM Changeset in webkit [146576] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Tools

Merge r146504 - [GTK] generate-feature-defines-files is incompatible with Python3
https://bugs.webkit.org/show_bug.cgi?id=112956

Reviewed by Martin Robinson.

Make the generate-feature-defines-files compatible with Python3 by calling the items()
method on the dictionary objects when iterating through said dictionaries.

gtk/generate-feature-defines-files:

(write_feature_defines_header):
(write_flattened_feature_defines_file):

1:38 AM Changeset in webkit [146575] by commit-queue@webkit.org

6 edits
1 move in trunk/Source/WebCore

Move GeolocationClient.h to Modules/geolocation/
https://bugs.webkit.org/show_bug.cgi?id=112997

Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Kentaro Hara.

No new tests, no functional change.

GNUmakefile.list.am:
Modules/geolocation/GeolocationClient.h: Renamed from Source/WebCore/page/GeolocationClient.h.

(WebCore):
(GeolocationClient):
(WebCore::GeolocationClient::~GeolocationClient):

WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:

1:29 AM Changeset in webkit [146574] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add a flaky crash test expectations on Mac WebKit2 per bug 113020.

platform/mac-wk2/TestExpectations:

1:24 AM Changeset in webkit [146573] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Skipping fast/dom/custom tests as the custom elements support is not yet enabled

on the GTK port. Adding crashing expectations for two IDB tests that regressed with r146540.

1:12 AM Changeset in webkit [146572] by commit-queue@webkit.org

35 edits
14 deletes in trunk

Unreviewed, rolling out r146534 and r146565.
http://trac.webkit.org/changeset/146534
http://trac.webkit.org/changeset/146565
https://bugs.webkit.org/show_bug.cgi?id=113017

"r146534 caused perf regression on Chromium Linux x64"
(Requested by yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-22

Source/WebCore:

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):

bindings/scripts/IDLAttributes.txt:
bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):

bindings/v8/CustomElementHelpers.cpp:
bindings/v8/CustomElementHelpers.h:

(WebCore):
(CustomElementHelpers):

bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

bindings/v8/V8DOMConfiguration.h:

(BatchedMethod):
(V8DOMConfiguration):

bindings/v8/V8RecursionScope.cpp:

(WebCore::V8RecursionScope::didLeaveScriptContext):

dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::createElement):

dom/CustomElementConstructor.h:

(CustomElementConstructor):

dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::~CustomElementRegistry):

dom/CustomElementRegistry.h:

(WebCore):
(CustomElementRegistry):

dom/Document.cpp:

(WebCore::Document::createElement):
(WebCore::Document::registerElement):

dom/Document.h:
dom/Document.idl:
dom/Element.cpp:

(WebCore::Element::parserSetAttributes):
(WebCore::Element::cloneAttributesFromElement):

dom/Element.h:
dom/Element.idl:
dom/Node.idl:
dom/ShadowRoot.idl:
html/HTMLElement.idl:
html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::runScript):

Source/WebKit/chromium:

src/WebKit.cpp:

Source/WTF:

wtf/HashSet.h:

(WTF):
(WTF::copyToVector):

LayoutTests:

fast/dom/custom/lifecycle-ready-createElement-recursion-expected.txt: Removed.
fast/dom/custom/lifecycle-ready-createElement-recursion.html: Removed.
fast/dom/custom/lifecycle-ready-createElement-reentrancy-expected.txt: Removed.
fast/dom/custom/lifecycle-ready-createElement-reentrancy.html: Removed.
fast/dom/custom/lifecycle-ready-creation-api-expected.txt: Removed.
fast/dom/custom/lifecycle-ready-creation-api.html: Removed.
fast/dom/custom/lifecycle-ready-innerHTML-expected.txt: Removed.
fast/dom/custom/lifecycle-ready-innerHTML.html: Removed.
fast/dom/custom/lifecycle-ready-parser-only-expected.html: Removed.
fast/dom/custom/lifecycle-ready-parser-only.html: Removed.
fast/dom/custom/lifecycle-ready-parser-script-expected.txt: Removed.
fast/dom/custom/lifecycle-ready-parser-script.html: Removed.
fast/dom/custom/lifecycle-ready-paste-expected.txt: Removed.
fast/dom/custom/lifecycle-ready-paste.html: Removed.

1:07 AM Changeset in webkit [146571] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GStreamer] Memory leak in AudioFileReader::createBus()
https://bugs.webkit.org/show_bug.cgi?id=112925

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-22
Reviewed by Martin Robinson.

Adopt the reference returned by g_timeout_source_new()
to fix a memory leak.

No new tests. No change in behavior.

platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

12:52 AM Changeset in webkit [146570] by commit-queue@webkit.org

11 edits
2 moves in trunk/Source/WebCore

Move page/Coordinates.[h|idl] to Modules/geolocation/
https://bugs.webkit.org/show_bug.cgi?id=112945

Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Kentaro Hara.

No new tests, no functional change.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Modules/geolocation/Coordinates.h: Renamed from Source/WebCore/page/Coordinates.h.

(WebCore):
(Coordinates):
(WebCore::Coordinates::create):
(WebCore::Coordinates::isolatedCopy):
(WebCore::Coordinates::latitude):
(WebCore::Coordinates::longitude):
(WebCore::Coordinates::altitude):
(WebCore::Coordinates::accuracy):
(WebCore::Coordinates::altitudeAccuracy):
(WebCore::Coordinates::heading):
(WebCore::Coordinates::speed):
(WebCore::Coordinates::canProvideAltitude):
(WebCore::Coordinates::canProvideAltitudeAccuracy):
(WebCore::Coordinates::canProvideHeading):
(WebCore::Coordinates::canProvideSpeed):
(WebCore::Coordinates::Coordinates):

Modules/geolocation/Coordinates.idl: Renamed from Source/WebCore/page/Coordinates.idl.
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:

12:41 AM Changeset in webkit [146569] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add a flaky test failure expectation per bug 113012.

platform/win/TestExpectations:

12:36 AM Changeset in webkit [146568] by rniwa@webkit.org

3 edits in trunk/Source/JavaScriptCore

Leak bots erroneously report JSC::WatchpointSet as leaking
https://bugs.webkit.org/show_bug.cgi?id=107781

Reviewed by Filip Pizlo.

Since leaks doesn't support tagged pointers, avoid using it by flipping the bit flag to indicate
the entry is "fat". We set the flag when the entry is NOT fat; i.e. slim.

Replaced FatFlag by SlimFlag and initialized m_bits with this flag to indicate that the entry is
initially "slim".

runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::copySlow): Don't set FatFlag since it has been replaced by SlimFlag.
(JSC::SymbolTableEntry::inflateSlow): Ditto.

runtime/SymbolTable.h:

(JSC::SymbolTableEntry::Fast::Fast): Set SlimFlag by default.
(JSC::SymbolTableEntry::Fast::isNull): Ignore SlimFlag.
(JSC::SymbolTableEntry::Fast::isFat): An entry is fat when m_bits is not entirely zero and SlimFlag
is not set.

(JSC::SymbolTableEntry::SymbolTableEntry): Set SlimFlag by default.
(JSC::SymbolTableEntry::SymbolTableEntry::getFast): Set SlimFlag when creating Fast from a fat entry.
(JSC::SymbolTableEntry::isNull): Ignore SlimFlag.
(JSC::SymbolTableEntry::FatEntry::FatEntry): Strip SlimFlag.
(JSC::SymbolTableEntry::isFat): An entry is fat when m_bits is not entirely zero and SlimFlag is unset.
(JSC::SymbolTableEntry::fatEntry): Don't strip FatFlag as this flag doesn't exist anymore.
(JSC::SymbolTableEntry::pack): Preserve SlimFlag.

(JSC::SymbolTableIndexHashTraits): empty value is no longer zero so don't set emptyValueIsZero true.

12:25 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

12:19 AM Changeset in webkit [146567] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Final Mac rebaseline attempt for r146531 since r146564 wasn't enough.

I'm sorry I made a huge mess here.

platform/mac/compositing/rtl/rtl-fixed-expected.txt:

12:09 AM Changeset in webkit [146566] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[chromium] Mark virtual/gpu/fast/canvas/canvas-toDataURL-webp.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

libwebp will be updated to 0.3.0 in chrome changing the encoder
output after which this test will need to be rebaselined.

Patch by James Zern <jzern@chromium.org> on 2013-03-22

platform/chromium/TestExpectations:

Mar 21, 2013:

11:16 PM Changeset in webkit [146565] by morrita@google.com

24 edits
14 adds in trunk

Custom Elements: "readyCallback" lifecycle callback should be called.
https://bugs.webkit.org/show_bug.cgi?id=112538

Reviewed by Elliott Sprehn.

Source/WebCore:

This change allows each custom element definition to hook up its instantiation,
namely "readyCallback" lifecycle callback.

The change has two parts:

1. Tracking which Element objects to be created.
2. Invoking appropriate JavaScript functions, which are readyCallback(), before the Element object is visible from page script.

This also happens when @is attribute is set by the parser or node
cloning routine, which can turn a non-custom element into a
type-extended custom element. See changes on Element.cpp.

Tests: fast/dom/custom/lifecycle-ready-createElement-recursion.html

fast/dom/custom/lifecycle-ready-createElement-reentrancy.html
fast/dom/custom/lifecycle-ready-creation-api.html
fast/dom/custom/lifecycle-ready-innerHTML.html
fast/dom/custom/lifecycle-ready-parser-only.html
fast/dom/custom/lifecycle-ready-parser-script.html
fast/dom/custom/lifecycle-ready-paste.html

bindings/scripts/CodeGeneratorV8.pm:
Hooked up CallbackDeliveryScope through V8DeliverCustomElementCallbacks attriute.

(GenerateCustomElementInvocationScopeIfNeeded):
(GenerateNormalAttrSetter):
(GenerateFunction):

bindings/scripts/IDLAttributes.txt:
bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::invokeReadyCallbackIfNeeded):
(WebCore::CustomElementHelpers::invokeReadyCallbacksIfNeeded):

bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):

bindings/v8/V8RecursionScope.cpp: Added deliverAllLifecycleCallbacks()

(WebCore::V8RecursionScope::didLeaveScriptContext):

dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::createElement):
(WebCore::CustomElementConstructor::createElementInternal):

dom/CustomElementConstructor.h:

(WebCore::CustomElementConstructor::isExtended):
(CustomElementConstructor):

dom/CustomElementRegistry.cpp: Adding element tracking and invocation execution.

dom/CustomElementRegistry.h:

dom/Document.cpp:

(WebCore::Document::createElement):
(WebCore::Document::didCreateCustomElement):

dom/Document.h:

(Document):

dom/Document.idl:
dom/Element.cpp:

(WebCore::Element::attributeChangedFromParserOrByCloning): Added to catch @is attribute
(WebCore::Element::parserSetAttributes):
(WebCore::Element::cloneAttributesFromElement):

dom/Element.h:
dom/Node.idl:
dom/ShadowRoot.idl:
html/HTMLElement.idl:
html/parser/HTMLScriptRunner.cpp: Added deliverAllLifecycleCallbacks()

(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::runScript):

Source/WebKit/chromium:

src/WebKit.cpp: Added deliverAllLifecycleCallbacks()

Source/WTF:

wtf/HashSet.h:

(WTF::copyToVector): Generalized to let it accept variants like ListHahsSet instead of only HashSet.

LayoutTests:

fast/dom/custom/lifecycle-ready-createElement-recursion-expected.txt: Added.
fast/dom/custom/lifecycle-ready-createElement-recursion.html: Added.
fast/dom/custom/lifecycle-ready-createElement-reentrancy-expected.txt: Added.
fast/dom/custom/lifecycle-ready-createElement-reentrancy.html: Added.
fast/dom/custom/lifecycle-ready-creation-api-expected.txt: Added.
fast/dom/custom/lifecycle-ready-creation-api.html: Added.
fast/dom/custom/lifecycle-ready-innerHTML-expected.txt: Added.
fast/dom/custom/lifecycle-ready-innerHTML.html: Added.
fast/dom/custom/lifecycle-ready-parser-only-expected.html: Added.
fast/dom/custom/lifecycle-ready-parser-only.html: Added.
fast/dom/custom/lifecycle-ready-parser-script-expected.txt: Added.
fast/dom/custom/lifecycle-ready-parser-script.html: Added.
fast/dom/custom/lifecycle-ready-paste-expected.txt: Added.
fast/dom/custom/lifecycle-ready-paste.html: Added.

11:05 PM Changeset in webkit [146564] by rniwa@webkit.org

5 edits in trunk/LayoutTests

Yet another Mac rebaseline attempt for r146531 since r146538 and r146554 didn't work.

platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
platform/mac/compositing/rtl/rtl-fixed-expected.txt:
platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt:

10:50 PM Changeset in webkit [146563] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Crash in WebCore::MediaPlayer::cachedResourceLoader + 4
https://bugs.webkit.org/show_bug.cgi?id=112977

Reviewed by Geoffrey Garen.

Speculative fix for a NULL-dereference crash. MediaPlayerPrivateAVFoundationObjC is the
sole owner of a WebCoreAVFLoaderDelegate instance. It releases this instance in its destructor,
but it is possible that, on another thread, the AVAssetResourceLoader has already begun
using the delegate and in so doing has retained it. By the time the delegate method is fired
on the main thread, the MediaPlayerPrivateAVFoundationObjC owner of the delegate has already
been deleted, and the delegate's m_callback pointer is now pointing at freed memory.

In addition to calling -[AVAssetResourceLoader setDelegate:queue:] to avoid any not-yet-started
delegate callbacks, MediaPlayerPrivateAVFoundationObjC should clear the WebCoreAVFLoaderDelegate
m_callback ivar, to avoid calling into freed memory for already queued delegate callbacks.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Clear the m_loaderDelegate's callback pointer.
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]): Check the value of m_callback before continuing.
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]): Ditto.
(-[WebCoreAVFLoaderDelegate setCallback:]): Added simple setter.

10:22 PM Changeset in webkit [146562] by tasak@google.com

3 edits
2 adds in trunk

XMLDocumentParser doesn't parse <template> correctly.
https://bugs.webkit.org/show_bug.cgi?id=112328

Reviewed by Hajime Morrita.

Source/WebCore:

XMLDocumentParser should check whether a parent node is attached or not
when a new element is appended.

Test: fast/dom/HTMLTemplateElement/xhtml-with-titleElement-parsing-crash.xhtml

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):
m_currentNode is a parent node of newElement, but it is updated by
pushCurrentNode. So firstly stored copied m_curretNode's value into
local currentNode and used the currentNode to check whether
newElement's parent is attached or not.

LayoutTests:

fast/dom/HTMLTemplateElement/xhtml-with-titleElement-parsing-crash-expected.txt: Added.
fast/dom/HTMLTemplateElement/xhtml-with-titleElement-parsing-crash.xhtml: Added.

9:58 PM Changeset in webkit [146561] by dgrogan@chromium.org

4 edits in trunk/Source

Unreviewed, rolling out r146560.
http://trac.webkit.org/changeset/146560
https://bugs.webkit.org/show_bug.cgi?id=112862

invalid parameter to histogram

Source/Platform:

chromium/public/Platform.h:

Source/WebCore:

platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::open):

9:03 PM Changeset in webkit [146560] by dgrogan@chromium.org

4 edits in trunk/Source

IndexedDB: Histogram available disk space on attempt to open database
https://bugs.webkit.org/show_bug.cgi?id=112862

Reviewed by Adam Barth.

Source/Platform:

chromium/public/Platform.h:

(WebKit::Platform::availableDiskSpaceInBytes):
(Platform):

Source/WebCore:

No new tests - I don't know of a good way to test histograms. Local
printf testing didn't turn up any bugs.

platform/leveldb/LevelDBDatabase.cpp:

(WebCore::HistogramFreeSpace):
(WebCore):
(WebCore::LevelDBDatabase::open):

8:48 PM Changeset in webkit [146559] by dpranke@chromium.org

6 edits in trunk/Tools

nrwt is no longer saving retry results in the retries/ subdirectory
https://bugs.webkit.org/show_bug.cgi?id=112995

Reviewed by Ojan Vafai.

I think this has been broken a long time, unfortunately. This
patch should fix that.

In order to do so, I had to pass the directory to use from
the Worker object through the SingleTestWriter to the
TestResultWriter. While I was plumbing that through, I rationalized
the order of the parameter arguments a bit ...

Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(Worker._run_single_test):

Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(run_single_test):
(SingleTestRunner.init):
(SingleTestRunner._run_compare_test):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._run_reftest):

Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:

(TestResultWriterTest.test_reftest_diff_image):

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_retrying_uses_retries_directory):

8:12 PM Changeset in webkit [146558] by mhahnenberg@apple.com

11 edits in trunk/Source/JavaScriptCore

Objective-C API: Need a good way to preserve custom properties on JS wrappers
https://bugs.webkit.org/show_bug.cgi?id=112608

Reviewed by Geoffrey Garen.

Currently, we just use a weak map, which means that garbage collection can cause a wrapper to
disappear if it isn't directly exported to JavaScript.

The most straightforward and safe way (with respect to garbage collection and concurrency) is to have
clients add and remove their external references along with their owners. Effectively, the client is
recording the structure of the external object graph so that the garbage collector can make sure to
mark any wrappers that are reachable through either the JS object graph of the external Obj-C object
graph. By keeping these wrappers alive, this has the effect that custom properties on these wrappers
will also remain alive.

The rule for if an object needs to be tracked by the runtime (and therefore whether the client should report it) is as follows:
For a particular object, its references to its children should be added if:

The child is referenced from JavaScript.
The child contains references to other objects for which (1) or (2) are true.

API/JSAPIWrapperObject.mm:

(JSAPIWrapperObjectHandleOwner::finalize):
(JSAPIWrapperObjectHandleOwner::isReachableFromOpaqueRoots): A wrapper object is kept alive only if its JSGlobalObject
is marked and its corresponding Objective-C object was added to the set of opaque roots.
(JSC::JSAPIWrapperObject::visitChildren): We now call out to scanExternalObjectGraph, which handles adding all Objective-C
objects to the set of opaque roots.

API/JSAPIWrapperObject.h:

(JSAPIWrapperObject):

API/JSContext.mm: Moved dealloc to its proper place in the main implementation.

(-[JSContext dealloc]):

API/JSVirtualMachine.h:
API/JSVirtualMachine.mm:

(-[JSVirtualMachine initWithContextGroupRef:]):
(-[JSVirtualMachine dealloc]):
(getInternalObjcObject): Helper funciton to get the Objective-C object out of JSManagedValues or JSValues if there is one.
(-[JSVirtualMachine addManagedReference:withOwner:]): Adds the Objective-C object to the set of objects
owned by the owner object in that particular virtual machine.
(-[JSVirtualMachine removeManagedReference:withOwner:]): Removes the relationship between the two objects.
(-[JSVirtualMachine externalObjectGraph]):
(scanExternalObjectGraph): Does a depth-first search of the external object graph in a particular virtual machine starting at
the specified root. Each new object it encounters it adds to the set of opaque roots. These opaque roots will keep their
corresponding wrapper objects alive if they have them.

API/JSManagedReferenceInternal.h: Added.
API/JSVirtualMachine.mm: Added the per-JSVirtualMachine map between objects and the objects they own, which is more formally

known as that virtual machine's external object graph.

API/JSWrapperMap.mm:

(-[JSWrapperMap dealloc]): We were leaking this before :-(
(-[JSVirtualMachine initWithContextGroupRef:]):
(-[JSVirtualMachine dealloc]):
(-[JSVirtualMachine externalObjectGraph]):

API/JSVirtualMachineInternal.h:
API/tests/testapi.mm: Added two new tests using the TinyDOMNode class. The first tests that a custom property added to a wrapper

doesn't vanish after GC, even though that wrapper isn't directly accessible to the JS garbage collector but is accessible through
the external Objective-C object graph. The second test makes sure that adding an object to the external object graph with the same
owner doesn't cause any sort of problems.
(+[TinyDOMNode sharedVirtualMachine]):
(-[TinyDOMNode init]):
(-[TinyDOMNode dealloc]):
(-[TinyDOMNode appendChild:]):
(-[TinyDOMNode numberOfChildren]):
(-[TinyDOMNode childAtIndex:]):
(-[TinyDOMNode removeChildAtIndex:]):

JavaScriptCore.xcodeproj/project.pbxproj:
heap/SlotVisitor.h:

(SlotVisitor):

heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::containsOpaqueRootTriState): Added a new method to SlotVisitor to allow scanExternalObjectGraph to have a
thread-safe view of opaque roots during parallel marking. The set of opaque roots available to any one SlotVisitor isn't guaranteed
to be 100% correct, but that just results in a small duplication of work in scanExternalObjectGraph. To indicate this change for
false negatives we return a TriState that's either true or mixed, but never false.

8:11 PM Changeset in webkit [146557] by li.yin@intel.com

8 edits in trunk

FileAPI: Remove deprecation warning when ArrayBuffer is in Blob constructor.
https://bugs.webkit.org/show_bug.cgi?id=88389

Reviewed by Kenneth Russell.

Source/WebCore:

Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob
Both ArrayBuffer and ArrayBufferView should be supported for Blob constructor.

Test: fast/files/blob-constructor.html.

bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

fileapi/WebKitBlobBuilder.cpp:

(WebCore::BlobBuilder::append): Remove the deprecated warning.

fileapi/WebKitBlobBuilder.h:

(WebCore):
(BlobBuilder):

LayoutTests:

fast/files/blob-constructor-expected.txt:
fast/files/script-tests/blob-constructor.js:

8:02 PM Changeset in webkit [146556] by tasak@google.com

3 edits
2 adds in trunk

[Shadow]: @host styles are not applied dynamically
https://bugs.webkit.org/show_bug.cgi?id=112869

Reviewed by Elliott Sprehn.

Source/WebCore:

Need to add features of @host @-rules to rule feature set.

Test: fast/dom/shadow/athost-apply-dynamically.html

css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::collectFeaturesTo):

LayoutTests:

fast/dom/shadow/athost-apply-dynamically-expected.html: Added.
fast/dom/shadow/athost-apply-dynamically.html: Added.

8:00 PM Changeset in webkit [146555] by hayato@chromium.org

6 edits
2 adds in trunk

[Shadow] Provide an api of insertionParent().
https://bugs.webkit.org/show_bug.cgi?id=112866

Source/WebCore:

Add insertinParent binding to Element and Text.
It's prefixed (webkitInsertionParent) and guarded by SHADOW_DOM flag.

The bug in the Shadow DOM spec is here:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=21067

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/insertion-parent.html

dom/Element.idl:
dom/Node.cpp:

(WebCore::Node::insertionParentForBinding):
(WebCore):

dom/Node.h:

(Node):

dom/Text.idl:

LayoutTests:

Reviewed by Dimitri Glazkov.

fast/dom/shadow/insertion-parent-expected.txt: Added.
fast/dom/shadow/insertion-parent.html: Added.

7:23 PM Changeset in webkit [146554] by rniwa@webkit.org

5 edits in trunk/LayoutTests

Another Mac rebaseline attempt for r146531 since r146538 didn't work.

platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
platform/mac/compositing/rtl/rtl-fixed-expected.txt:
platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt:

7:02 PM Changeset in webkit [146553] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Test expectations updates.
https://bugs.webkit.org/show_bug.cgi?id=88833
https://bugs.webkit.org/show_bug.cgi?id=107935
https://bugs.webkit.org/show_bug.cgi?id=109507

Unreviewed, test expectations updates.

platform/chromium/TestExpectations:

6:56 PM Changeset in webkit [146552] by mark.lam@apple.com

12 edits in trunk/Source

Source/JavaScriptCore: Fix O(n^{2) op_debug bytecode charPosition to column computation.

https://bugs.webkit.org/show_bug.cgi?id=112957.}

Reviewed by Geoffrey Garen.

The previous algorithm does a linear reverse scan of the source string
to find the line start for any given char position. This results in a
O(n^{2) algortithm when the source string has no line breaks.}

The new algorithm computes a line start column table for a
SourceProvider on first use. This line start table is used to fix up
op_debug's charPosition operand into a column operand when an
UnlinkedCodeBlock is linked into a CodeBlock. The initialization of
the line start table is O(n), and the CodeBlock column fix up is
O(log(n)).

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock): - do column fix up.

interpreter/Interpreter.cpp:

(JSC::Interpreter::debug): - no need to do column fixup anymore.

interpreter/Interpreter.h:
jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

parser/SourceProvider.cpp:

(JSC::SourceProvider::lineStarts):
(JSC::charPositionExtractor):
(JSC::SourceProvider::charPositionToColumnNumber):

initialize line start column table if needed.
look up line start for the given char position.
parser/SourceProvider.h:

Source/WTF: Introducing String::findNextLineStart().
https://bugs.webkit.org/show_bug.cgi?id=112957.

Reviewed by Geoffrey Garen.

This is replaces String::reverseFindLineTerminator() in the JSC
debugger's code for computing column numbers.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::findNextLineStart):

wtf/text/StringImpl.h:

(WTF::findNextLineStart):

wtf/text/WTFString.h:

(WTF::String::findNextLineStart):

6:39 PM Changeset in webkit [146551] by timothy_horton@apple.com

5 edits in trunk/Source/WebKit2

[wk2] Page Overlays: Don't create backing store until the client asks us to paint
https://bugs.webkit.org/show_bug.cgi?id=112989
<rdar://problem/13355759>

Reviewed by Anders Carlsson.

WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::highlight):

WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll):
Invalidate the entire overlay on installation, to maintain existing behavior
on platforms where the fade-in animation is not performed by invalidating the overlay.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::installPageOverlay):
Don't invalidate the overlay upon installation.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
Create backing store for the page overlay layer the first time it is painted into.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Don't update the size of the page overlay layer unless we intend for it to have backing store.
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Don't create backing store when we create the page overlay layer.

6:32 PM Changeset in webkit [146550] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/win

WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=112892

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-21
Reviewed by Kentaro Hara.

WebKit.vcproj/WebKitExports.def.in: Added ENABLE(VIDEO_TRACK) guard.

6:26 PM Changeset in webkit [146549] by tsepez@chromium.org

3 edits
2 adds in trunk

Bypass XSSAuditor for asp.net servers.
https://bugs.webkit.org/show_bug.cgi?id=112235

Reviewed by Adam Barth.

Source/WebCore:

Similar to https://bugs.webkit.org/show_bug.cgi?id=81283, but the
fix to that bug failed to cover this particular comma-splicing case.

Test: http/tests/security/xssAuditor/img-tag-with-comma.html

html/parser/XSSAuditor.cpp:

(WebCore::isTerminatingCharacter):
Beware of comma-splicing tricks by stopping at commas.

LayoutTests:

http/tests/security/xssAuditor/img-tag-with-comma-expected.txt: Added.
http/tests/security/xssAuditor/img-tag-with-comma.html: Added.

6:17 PM Changeset in webkit [146548] by fpizlo@apple.com

7 edits in trunk

JSC profiler should have an at-a-glance report of the success of DFG optimization
https://bugs.webkit.org/show_bug.cgi?id=112988

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

profiler/ProfilerCompilation.cpp:

(JSC::Profiler::Compilation::Compilation):
(JSC::Profiler::Compilation::toJS):

profiler/ProfilerCompilation.h:

(JSC::Profiler::Compilation::noticeInlinedGetById):
(JSC::Profiler::Compilation::noticeInlinedPutById):
(JSC::Profiler::Compilation::noticeInlinedCall):
(Compilation):

runtime/CommonIdentifiers.h:

Tools:

Scripts/display-profiler-output:

5:58 PM Changeset in webkit [146547] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Test expectations updates: mark flaky tests; fix overlapping expectations; convert [ Pass Slow ] to [ Slow ].
https://bugs.webkit.org/show_bug.cgi?id=88833
https://bugs.webkit.org/show_bug.cgi?id=93569
https://bugs.webkit.org/show_bug.cgi?id=109507
https://bugs.webkit.org/show_bug.cgi?id=112980
https://bugs.webkit.org/show_bug.cgi?id=112981
https://bugs.webkit.org/show_bug.cgi?id=112984
https://bugs.webkit.org/show_bug.cgi?id=112987
http://crbug.com/24182

Unreviewed, test expectations updates.

platform/chromium/TestExpectations:

5:25 PM Changeset in webkit [146546] by dpranke@chromium.org

3 edits in trunk/Tools

[chromium] Linux ASAN WebKit canary is running out of memory
https://bugs.webkit.org/show_bug.cgi?id=112978

Reviewed by Tony Chang.

Running the AddressSanitizer on a crash takes a lot of
memory, so we should serialize access to it to avoid running
out of memory on a machine.

Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._get_crash_log):

Scripts/webkitpy/layout_tests/port/http_lock.py:

(HttpLock.init):
(HttpLock.wait_for_httpd_lock):

5:14 PM Changeset in webkit [146545] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add Mac baseline after r146510.

platform/mac/svg/custom/marker-orient-auto-expected.png: Added.
platform/mac/svg/custom/marker-orient-auto-expected.txt: Added.

5:14 PM Changeset in webkit [146544] by beidson@apple.com

21 edits in trunk/Source

If a previously loaded resource is later stored to the disk cache, replace the buffer with MMAP'ed memory.
<rdar://problem/13414154> and https://bugs.webkit.org/show_bug.cgi?id=112943

Reviewed by Geoff Garen.

Source/WebCore:

No new tests (No change in behavior.)

Give SharedBuffer the ability to replace its contents from another SharedBuffer:

platform/SharedBuffer.h:
platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer:: tryReplaceContentsWithPlatformBuffer):

Forward along SharedBuffer's new ability to ResourceBuffer:

loader/mac/ResourceBuffer.mm:

(WebCore::ResourceBuffer:: tryReplaceSharedBufferContents):

loader/ResourceBuffer.h:

Give CachedResource the ability to replace its encoded data buffer if appropriate:

loader/cache/CachedResource.cpp:

(WebCore::CachedResource:: tryReplaceEncodedData):

loader/cache/CachedResource.h:

WebCore.exp.in:

Source/WebKit2:

Add a timer that will try to look up the disk cached buffer for the resource a few seconds after the load
completes and - if the resource is disk backed - send it to the WebProcess for sharing:

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::diskCacheTimerFired):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveData):
(WebKit::NetworkResourceLoader::didFinishLoading):

NetworkProcess/NetworkResourceLoader.h:

NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::tryGetShareableHandleForResource):

Refactor SharedMemory to remove the unnecessary vm_copy and only vm_allocate when an appropriate buffer
doesn't already exist:

Platform/SharedMemory.h:
Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::create):
(WebKit::SharedMemory::createFromVMBuffer):
(WebKit::SharedMemory::~SharedMemory):

Give ShareableResource the ability to create a CFDataRef that wraps "this", and return it in a SharedBuffer:

Shared/ShareableResource.cpp:

(WebKit::shareableResourceDeallocate):
(WebKit::createShareableResourceDeallocator):
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):

Shared/ShareableResource.h:

Shared/WebCoreArgumentCoders.cpp: Encode/decode the cache partition for ResourceRequest.

WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didCacheResource): Lookup the CachedResource in the WebCore memory cache

and try to replace its encoded data with the shared mmap'ed buffer.

WebProcess/Network/NetworkProcessConnection.h:
WebProcess/Network/NetworkProcessConnection.messages.in:

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResource):

5:08 PM Changeset in webkit [146543] by rniwa@webkit.org

4 edits
5 adds in trunk/LayoutTests

[Mac] Add baselines for css3/filters/effect-reference*.html
https://bugs.webkit.org/show_bug.cgi?id=112962

Reviewed by Dean Jackson.

Add Mac rebaselines for the following tests and removed the corresponding entries in TestExpectations.

platform/mac/TestExpectations:
platform/mac/css3/filters/effect-reference-expected.png: Added.
platform/mac/css3/filters/effect-reference-expected.txt:
platform/mac/css3/filters/effect-reference-external-expected.png: Added.
platform/mac/css3/filters/effect-reference-hw-expected.png: Added.
platform/mac/css3/filters/effect-reference-hw-expected.txt:
platform/mac/css3/filters/effect-reference-ordering-expected.png: Added.
platform/mac/css3/filters/effect-reference-ordering-hw-expected.png: Added.

5:04 PM Changeset in webkit [146542] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Unreviewed build fix, forgot to stage one file.

WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::didChangeScrollOffsetForAnyFrame):
(DrawingArea):

4:58 PM Changeset in webkit [146541] by alokp@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening.
Suppressed text failures due to r146531.

platform/chromium/TestExpectations:

4:52 PM Changeset in webkit [146540] by jsbell@chromium.org

4 edits in trunk/Source/WebCore

IndexedDB: Ensure script wrappers can be collected after context is stopped
https://bugs.webkit.org/show_bug.cgi?id=112976

Reviewed by Adam Barth.

ActiveDOMObject::hasPendingActivity is called to see if script wrappers
can be disposed of. Once the script execution context has stopped they
should be free to go - include this in the checks.

No new tests - suggestions welcome.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::hasPendingActivity): Return false if stopped.
(WebCore::IDBDatabase::stop): Don't bother calling empty super impl.

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::hasPendingActivity): Return false if stopped.
(WebCore::IDBRequest::stop): Don't bother calling empty super impl.

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::hasPendingActivity): Return false if stopped.
(WebCore::IDBTransaction::stop): Don't bother calling empty super impl.

4:47 PM Changeset in webkit [146539] by timothy_horton@apple.com

4 edits in trunk/Source/WebKit2

[wk2] Page overlays shouldn't dirty the entire layer when flushing if the main frame can't scroll
https://bugs.webkit.org/show_bug.cgi?id=111662
<rdar://problem/13355808>

Reviewed by Dean Jackson.

Instead of setNeedsDisplay()ing the whole page overlay layer every time through
TCADA::flushLayers, do it at scroll time instead. Repainting on scroll is
necessary to keep things painted in the right place when we scroll (the overlay
is fixed to the size of the view), but is quite wasteful in apps that don’t scroll.

This works with threaded scrolling because overlay installation forces us
into main-thread scrolling mode.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didChangeScrollOffset):
Plumb scroll offset changes through to the drawing area, so it can invalidate the page overlay.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):
Add didChangeScrollOffsetForAnyFrame, for WebFrameLoaderClient to call us back when any frame scrolls.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame):
Invalidate the page overlay when any frame scrolls, so that find indicators in subframes are kept in the right place.
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
Stop unconditionally invalidating the page overlay when we flush layers.

4:41 PM Changeset in webkit [146538] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

Mac rebaseline r146531.

platform/mac/compositing/rtl/rtl-fixed-expected.txt: Added.
platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.

4:28 PM Changeset in webkit [146537] by commit-queue@webkit.org

37 edits in trunk/Source/WebCore

Remove upcastPointer from ActiveDOMObject constructor
https://bugs.webkit.org/show_bug.cgi?id=112858

Patch by Russell McClellan <russell.mcclellan@gmail.com> on 2013-03-21
Reviewed by Alexey Proskuryakov.

Removed pesky argument to ActiveDOMObject constructor that is no longer
used.

No new tests (no change in behavior).

Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::BatteryManager):

Modules/filesystem/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::DOMFileSystem):

Modules/filesystem/FileWriter.cpp:

(WebCore::FileWriter::FileWriter):

Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::Geolocation):

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction):

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::MediaSource):

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):

Modules/mediastream/RTCDTMFSender.cpp:

(WebCore::RTCDTMFSender::RTCDTMFSender):

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):

Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:

(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):

Modules/mediastream/RTCStatsRequestImpl.cpp:

(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):

Modules/mediastream/RTCVoidRequestImpl.cpp:

(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):

Modules/networkinfo/NetworkInfoConnection.cpp:

(WebCore::NetworkInfoConnection::NetworkInfoConnection):

Modules/notifications/Notification.cpp:

(WebCore::Notification::Notification):

Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::NotificationCenter):

Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::SpeechRecognition):

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):

Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::DatabaseContext):

Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::WebSocket):

css/FontLoader.cpp:

(WebCore::FontLoader::FontLoader):

dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):

dom/ActiveDOMObject.h:

(ActiveDOMObject):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::didCreateActiveDOMObject):

dom/ScriptExecutionContext.h:

(ScriptExecutionContext):
(WebCore::ScriptExecutionContext::activeDOMObjects):

fileapi/FileReader.cpp:

(WebCore::FileReader::FileReader):

html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::HTMLMarqueeElement):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):

loader/Prerenderer.cpp:

(WebCore::Prerenderer::Prerenderer):

page/EventSource.cpp:

(WebCore::EventSource::EventSource):

page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::AbstractWorker):

workers/WorkerContext.cpp:

(WebCore::WorkerContext::hasPendingActivity):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):

3:54 PM Changeset in webkit [146536] by ap@apple.com

8 edits in trunk/Source

[Mac] Move NSOperationQueue out of NetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=112970

Reviewed by Brady Eidson.

WebCore clients do not need explicit control over what queue ResourceHandle works on,
they just want to avoid blocking main thread.

platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::usesAsyncCallbacks): Added. The name doesn't quite match what ResourceHandleMac currently does, but it will very soon.

platform/network/NetworkingContext.h: (WebCore::NetworkingContext::scheduledRunLoopPairs):
platform/network/mac/ResourceHandleMac.mm: (WebCore::operationQueueForAsyncClients): (WebCore::ResourceHandle::start):

3:53 PM Changeset in webkit [146535] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Revert bad change to resize-corner-tracking-transformed-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=112974

In bug 9221, I accidentally overwrite
resize-corner-tracking-transformed-expected.txt with a win/linux
version, which broke Mac. Unfortunately, the gardener didn't realize
this and just added the test to TestExpectations. This change restores
the original expectation to fix mac and removes the test from
TestExpectations.

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-21
Reviewed by Tony Chang.

platform/chromium/TestExpectations:
platform/chromium/fast/css/resize-corner-tracking-transformed-expected.txt:

3:52 PM Changeset in webkit [146534] by commit-queue@webkit.org

15 edits in trunk/Source/WebCore

[V8] Generate specialized callbacks for the main world
https://bugs.webkit.org/show_bug.cgi?id=112430

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-21
Reviewed by Jochen Eisinger.

The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.

This patch generates main world bindings for getters and setters of Node,
Element and Document.

No new tests (updated existing binding tests).

bindings/scripts/CodeGeneratorV8.pm:

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):

bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

bindings/v8/V8DOMConfiguration.h:

(BatchedMethod):
(V8DOMConfiguration):

dom/Document.idl:
dom/Element.idl:
dom/Node.idl:

3:50 PM Changeset in webkit [146533] by esprehn@chromium.org

2 edits in trunk/Source/WebCore

Remove RenderObject::canHaveRegionStyle since nothing uses it
https://bugs.webkit.org/show_bug.cgi?id=112973

Reviewed by Eric Seidel.

Nothing uses canHaveRegionStyle so we can remove it.

rendering/RenderObject.h:

3:35 PM Changeset in webkit [146532] by pkasting@chromium.org

17 edits
1 delete in trunk/LayoutTests

[chromium] Minor test expectations updates and some Skia rebaselines.
https://bugs.webkit.org/show_bug.cgi?id=94240
https://bugs.webkit.org/show_bug.cgi?id=104595
https://code.google.com/p/chromium/issues/detail?id=181700
https://code.google.com/p/chromium/issues/detail?id=222382

Unreviewed, gardening.

platform/chromium-linux-x86/platform/chromium/virtual/gpu: Removed.
platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast: Removed.
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-win-xp/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium/TestExpectations:

3:29 PM Changeset in webkit [146531] by alokp@chromium.org

326 edits
11 copies
6 adds
2 deletes in trunk

Mark GraphicsLayers as opaque when possible
https://bugs.webkit.org/show_bug.cgi?id=70634

Reviewed by Simon Fraser.

Source/WebCore:

Mark layers as opaque in a very simple case - any child renderer has an opaque background and covers the entire composited bounds. It is important to note that since we only consider the background, the only layer that can be marked opaque is the primary GraphicsLayer of a RenderLayer.

Tests: compositing/contents-opaque/background-clip.html

compositing/contents-opaque/background-color.html
compositing/contents-opaque/body-background-painted.html
compositing/contents-opaque/body-background-skipped.html
compositing/contents-opaque/layer-opacity.html
compositing/contents-opaque/layer-transform.html

rendering/RenderBox.cpp:

(WebCore::skipBodyBackground):
(WebCore):
(WebCore::RenderBox::paintBackground):
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):

rendering/RenderBox.h:

(RenderBox):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
(WebCore):
(WebCore::RenderLayer::listBackgroundIsKnownToBeOpaqueInRect):

rendering/RenderLayer.h:

(RenderLayer):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

rendering/RenderLayerModelObject.h:

(RenderLayerModelObject):
(WebCore::RenderLayerModelObject::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

compositing/absolute-inside-out-of-view-fixed-expected.txt:
compositing/backing/no-backing-for-clip-expected.txt:
compositing/backing/no-backing-for-clip-overlap-expected.txt:
compositing/backing/no-backing-for-perspective-expected.txt:
compositing/clip-child-by-non-stacking-ancestor-expected.txt:
compositing/columns/composited-in-paginated-expected.txt:
compositing/contents-opaque/background-clip-expected.txt: Copied from LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt.
compositing/contents-opaque/background-clip.html: Added.
compositing/contents-opaque/background-color-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
compositing/contents-opaque/background-color.html: Added.
compositing/contents-opaque/body-background-painted-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt.
compositing/contents-opaque/body-background-painted.html: Added.
compositing/contents-opaque/body-background-skipped-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt.
compositing/contents-opaque/body-background-skipped.html: Added.
compositing/contents-opaque/layer-opacity-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
compositing/contents-opaque/layer-opacity.html: Added.
compositing/contents-opaque/layer-transform-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
compositing/contents-opaque/layer-transform.html: Added.
compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
compositing/geometry/bounds-ignores-hidden-expected.txt:
compositing/geometry/clip-expected.txt:
compositing/geometry/clip-inside-expected.txt:
compositing/geometry/fixed-position-composited-switch-expected.txt:
compositing/geometry/flipped-writing-mode-expected.txt:
compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
compositing/geometry/limit-layer-bounds-fixed-expected.txt:
compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
compositing/geometry/limit-layer-bounds-positioned-expected.txt:
compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
compositing/geometry/limit-layer-bounds-transformed-expected.txt:
compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
compositing/geometry/preserve-3d-switching-expected.txt:
compositing/iframes/become-composited-nested-iframes-expected.txt:
compositing/iframes/become-overlapped-iframe-expected.txt:
compositing/iframes/composited-parent-iframe-expected.txt:
compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
compositing/iframes/connect-compositing-iframe-expected.txt:
compositing/iframes/connect-compositing-iframe2-expected.txt:
compositing/iframes/connect-compositing-iframe3-expected.txt:
compositing/iframes/enter-compositing-iframe-expected.txt:
compositing/iframes/iframe-resize-expected.txt:
compositing/iframes/invisible-nested-iframe-hide-expected.txt:
compositing/iframes/invisible-nested-iframe-show-expected.txt:
compositing/iframes/overlapped-iframe-expected.txt:
compositing/iframes/overlapped-iframe-iframe-expected.txt:
compositing/iframes/overlapped-nested-iframes-expected.txt:
compositing/iframes/page-cache-layer-tree-expected.txt:
compositing/iframes/scrolling-iframe-expected.txt:
compositing/layer-creation/animation-overlap-with-children-expected.txt:
compositing/layer-creation/fixed-position-and-transform-expected.txt:
compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
compositing/layer-creation/fixed-position-out-of-view-expected.txt:
compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
compositing/layer-creation/fixed-position-under-transform-expected.txt:
compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
compositing/layer-creation/overflow-scroll-overlap-expected.txt:
compositing/layer-creation/overlap-animation-clipping-expected.txt:
compositing/layer-creation/overlap-animation-expected.txt:
compositing/layer-creation/overlap-child-layer-expected.txt:
compositing/layer-creation/overlap-clipping-expected.txt:
compositing/layer-creation/overlap-transformed-3d-expected.txt:
compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
compositing/layer-creation/overlap-transformed-layer-expected.txt:
compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
compositing/layer-creation/overlap-transforms-expected.txt:
compositing/layer-creation/spanOverlapsCanvas-expected.txt:
compositing/layer-creation/stacking-context-overlap-expected.txt:
compositing/layer-creation/translatez-overlap-expected.txt:
compositing/masks/mask-layer-size-expected.txt:
compositing/overflow-trumps-transform-style-expected.txt:
compositing/overflow/clip-descendents-expected.txt:
compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
compositing/overflow/textarea-scroll-touch-expected.txt:
compositing/plugins/no-backing-store-expected.txt:
compositing/repaint/invalidations-on-composited-layers-expected.txt:
compositing/rtl/rtl-absolute-expected.txt:
compositing/rtl/rtl-absolute-overflow-expected.txt:
compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
compositing/rtl/rtl-fixed-expected.txt:
compositing/rtl/rtl-fixed-overflow-expected.txt:
compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
compositing/rtl/rtl-iframe-absolute-expected.txt:
compositing/rtl/rtl-iframe-fixed-expected.txt:
compositing/rtl/rtl-iframe-relative-expected.txt:
compositing/rtl/rtl-relative-expected.txt:
compositing/tiled-layers-hidpi-expected.txt:
compositing/tiling/backface-preserve-3d-tiled-expected.txt:
compositing/tiling/crash-reparent-tiled-layer-expected.txt:
compositing/tiling/huge-layer-add-remove-child-expected.txt:
compositing/tiling/huge-layer-with-layer-children-expected.txt:
compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
compositing/tiling/rotated-tiled-clamped-expected.txt:
compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
compositing/tiling/tile-cache-zoomed-expected.txt:
compositing/tiling/tiled-layer-resize-expected.txt:
compositing/visible-rect/2d-transformed-expected.txt:
compositing/visible-rect/3d-transform-style-expected.txt:
compositing/visible-rect/3d-transformed-expected.txt:
compositing/visible-rect/animated-expected.txt:
compositing/visible-rect/animated-from-none-expected.txt:
compositing/visible-rect/clipped-by-viewport-expected.txt:
compositing/visible-rect/clipped-visible-rect-expected.txt:
compositing/visible-rect/iframe-and-layers-expected.txt:
compositing/visible-rect/iframe-no-layers-expected.txt:
compositing/visible-rect/nested-transform-expected.txt:
compositing/visible-rect/scrolled-expected.txt:
css3/filters/filtered-compositing-descendant-expected.txt:
platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt:
platform/chromium-linux/compositing/iframes/composited-parent-iframe-expected.txt:
platform/chromium-linux/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
platform/chromium-linux/compositing/iframes/connect-compositing-iframe-expected.txt:
platform/chromium-linux/compositing/iframes/connect-compositing-iframe2-expected.txt:
platform/chromium-linux/compositing/iframes/connect-compositing-iframe3-expected.txt:
platform/chromium-linux/compositing/iframes/enter-compositing-iframe-expected.txt:
platform/chromium-linux/compositing/iframes/iframe-resize-expected.txt:
platform/chromium-linux/compositing/iframes/iframe-size-from-zero-expected.txt:
platform/chromium-linux/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/chromium-linux/compositing/iframes/overlapped-iframe-expected.txt:
platform/chromium-linux/compositing/iframes/resizer-expected.txt:
platform/chromium-linux/compositing/overflow/textarea-scroll-touch-expected.txt:
platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/become-overlapped-iframe-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/composited-parent-iframe-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe-delayed-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe2-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe3-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/enter-compositing-iframe-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/iframe-resize-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/iframe-size-from-zero-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/overlapped-iframe-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/resizer-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/scrolling-iframe-expected.txt: Removed.
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/chromium-mac/compositing/overflow/textarea-scroll-touch-expected.txt:
platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
platform/chromium/TestExpectations:
platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
platform/chromium/compositing/contents-opaque/background-color-expected.txt: Copied from LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt.
platform/chromium/compositing/contents-opaque/body-background-painted-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt.
platform/chromium/compositing/contents-opaque/body-background-skipped-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt.
platform/chromium/compositing/contents-opaque/layer-opacity-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
platform/chromium/compositing/contents-opaque/layer-transform-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
platform/chromium/compositing/geometry/clip-expected.txt:
platform/chromium/compositing/geometry/clip-inside-expected.txt:
platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
platform/chromium/compositing/iframes/iframe-resize-expected.txt:
platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
platform/chromium/compositing/iframes/resizer-expected.txt:
platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
platform/chromium/compositing/overflow/clip-descendents-expected.txt:
platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium/compositing/rtl/rtl-relative-expected.txt:
platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
platform/mac/compositing/iframes/resizer-expected.txt:
platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
platform/qt-5.0-wk1/compositing/iframes/page-cache-layer-tree-expected.txt:
platform/qt-5.0-wk1/compositing/overflow/textarea-scroll-touch-expected.txt:
platform/qt-5.0-wk1/compositing/repaint/invalidations-on-composited-layers-expected.txt:
platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt: Removed.
platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:

3:29 PM Changeset in webkit [146530] by roger_fong@apple.com

134 edits
10 moves in trunk

Move common props files for VS2010 solution to WebKitLibraries folder and update all projects accordingly.

WebKit.vcxproj/FeatureDefines.props: Removed.
WebKit.vcxproj/FeatureDefinesCairo.props: Removed.
WebKit.vcxproj/WebKit/cURL.props: Removed.
WebKit.vcxproj/WinCairo.props: Removed.
WebKit.vcxproj/common.props: Removed.
WebKit.vcxproj/debug.props: Removed.
WebKit.vcxproj/debug_wincairo.props: Removed.
WebKit.vcxproj/debugsuffix.props: Removed.
WebKit.vcxproj/production.props: Removed.
WebKit.vcxproj/release.props: Removed.
win/tools/vsprops/FeatureDefines.props: Copied from ../Source/WebKit/WebKit.vcxproj/FeatureDefines.props.
win/tools/vsprops/FeatureDefinesCairo.props: Copied from ../Source/WebKit/WebKit.vcxproj/FeatureDefinesCairo.props.
win/tools/vsprops/WinCairo.props: Copied from ../Source/WebKit/WebKit.vcxproj/WinCairo.props.
win/tools/vsprops/cURL.props: Copied from ../Source/WebKit/WebKit.vcxproj/WebKit/cURL.props.
win/tools/vsprops/common.props: Copied from ../Source/WebKit/WebKit.vcxproj/common.props.
win/tools/vsprops/debug.props: Copied from ../Source/WebKit/WebKit.vcxproj/debug.props.
win/tools/vsprops/debug_wincairo.props: Copied from ../Source/WebKit/WebKit.vcxproj/debug_wincairo.props.
win/tools/vsprops/debugsuffix.props: Copied from ../Source/WebKit/WebKit.vcxproj/debugsuffix.props.
win/tools/vsprops/production.props: Copied from ../Source/WebKit/WebKit.vcxproj/production.props.
win/tools/vsprops/release.props: Copied from ../Source/WebKit/WebKit.vcxproj/release.props.

3:17 PM Changeset in webkit [146529] by Alexandru Chiculita

17 edits
2 copies
3 adds in trunk

[CSS Shaders] Implement a StyleCustomFilterProgram cache
https://bugs.webkit.org/show_bug.cgi?id=112602

Reviewed by Dean Jackson.

Source/WebCore:

When the style is recalculated, the new computed RenderStyle is saved as the m_style of the
RenderObject, even if the style was not different.

In the case of Custom Filters, a new StyleCustomFilterProgram was created at all times, but the
actual equality check was done by comparing the pair of cached shaders from inside the StyleCustomFilterProgram.

Because of that the RenderLayer::styleChanged was not called when the new StyleCustomFilterProgram was created, so it
will end up still knowing only about the previous StyleCustomFilterProgram.

The RenderLayer sets itself as a client of the StyleCustomFilterProgram, so that it can repaint itself
when the program is loaded, but because RenderLayer::styleChanged is not called, it will not add itself as a client of the new
StyleCustomFilterProgram.

StyleCustomFilterProgram waits until the first client to load the programs, so in this case it will just remain unloaded.

There was no crash, but just an assert in debug mode. Also, as a visible side-effect some frames were rendered using blank shaders,
resulting in a pass-through filter.

The fix would be to actually make the RenderStyle::diff detect the change of the StyleCustomFilterProgram
using the pointer value and not the values. However, that will always invalidate the "filter" property because
of the StyleCustomFilterProgram that always gets created during the recalculation time.

I've added StyleCustomFilterProgramCache to cache all the instances of the StyleCustomFilterPrograms that a
StyleResolver allocates. This way, next time it will try to reuse previously allocated StyleCustomFilterPrograms.
The key of the cache is the CustomFilterProgramInfo, that combines the URLs to the shaders and a couple of other program settings.

StyleCustomFilterProgramCache is owned by the StyleResovler and StyleCustomFilterPrograms are responsible with
removing themselves from the cache when the last reference goes away.

This change makes the previous "platform level" program cache obsolete and I will remove that in a future patch.
https://bugs.webkit.org/show_bug.cgi?id=112844

Test: css3/filters/custom/custom-filter-reload.html

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/StyleResolver.cpp:

(WebCore::StyleResolver::lookupCustomFilterProgram): Lookup any similar programs in the cache. It will create a new pending
StyleCustomFilterProgram if there is no pre-cached version of the program.
if no program is found. loadPendingShaders is responsible for adding the program in the cache if it is actually going to be used.
(WebCore::StyleResolver::loadPendingShaders): At this point the program is final, so it's safe to add it to the cache.
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):

css/StyleResolver.h:

(StyleResolver):

css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::completeURL): Factored out the function to compute the complete URL of the resource.
(WebCore::WebKitCSSShaderValue::cachedShader):

css/WebKitCSSShaderValue.h:

(WebCore::toWebKitCSSShaderValue):
(WebKitCSSShaderValue):

platform/graphics/filters/CustomFilterOperation.cpp:

(WebCore::CustomFilterOperation::blend):

platform/graphics/filters/CustomFilterOperation.h:

(WebCore::CustomFilterOperation::operator==): Removed. Programs should now compare by pointer. Kept it as
private to catch any potential use of it.

rendering/style/StyleCustomFilterProgram.cpp: Copied from Source/WebCore/css/WebKitCSSShaderValue.h.

(WebCore::StyleCustomFilterProgram::~StyleCustomFilterProgram): Destructor removes the program from the cache.

rendering/style/StyleCustomFilterProgram.h:

(WebCore::StyleCustomFilterProgram::setVertexShader): Added an assert to check that the shader is not in the
cache while the mutation happens. Otherwise the cache might have the wrong key.
(WebCore::StyleCustomFilterProgram::setFragmentShader): Ditto.
(WebCore::StyleCustomFilterProgram::isLoaded): Added more asserts to catch cases when the program is used with no clients.
(StyleCustomFilterProgram):
(WebCore::StyleCustomFilterProgram::hasPendingShaders):
(WebCore::StyleCustomFilterProgram::inCache):
(WebCore::StyleCustomFilterProgram::setCache): Function called when a program is added to / removed from the cache.
(WebCore::StyleCustomFilterProgram::vertexShaderURL): Added methods to store the KURL that we used as keys in the cache.
The same KURLs will be used to lookup and remove the filter at the end.
(WebCore::StyleCustomFilterProgram::setVertexShaderURL):
(WebCore::StyleCustomFilterProgram::fragmentShaderURL):
(WebCore::StyleCustomFilterProgram::setFragmentShaderURL):
(WebCore::StyleCustomFilterProgram::StyleCustomFilterProgram):

rendering/style/StyleCustomFilterProgramCache.cpp: Added.

(WebCore::StyleCustomFilterProgramCache::programCacheKey):
(WebCore::StyleCustomFilterProgramCache::StyleCustomFilterProgramCache):
(WebCore::StyleCustomFilterProgramCache::~StyleCustomFilterProgramCache): Destructor removes itself from all the
referenced StyleCustomFilterPrograms. This is to avoid issues with different destruction orders.
(WebCore::StyleCustomFilterProgramCache::lookup):
(WebCore::StyleCustomFilterProgramCache::add):
(WebCore::StyleCustomFilterProgramCache::remove):

rendering/style/StyleCustomFilterProgramCache.h:

(StyleCustomFilterProgramCache):

platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h:

(WebCore::CoordinatedCustomFilterProgram::operator==: Removed. Programs should now compare by pointer.

LayoutTests:

Added a new test to check for the case when the style is recalculated but the
filter property is not changed. All the other cases for the new StyleCustomFilterProgramCache
class should be tested by existing tests.

css3/filters/custom/custom-filter-reload-expected.txt: Added.
css3/filters/custom/custom-filter-reload.html: Added.

3:11 PM Changeset in webkit [146528] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Last paragraph can't be selected by touch hold selection if there is no new line after it in subframe.
https://bugs.webkit.org/show_bug.cgi?id=112966

Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-21
Reviewed by Rob Buis.

PR 312044
Reviewed Internally By Genevieve Mak.

If selection reaches the bottom of content, ignore scroll margin
so the text on the bottom can be selected.
Stop expanding selection only if the end of document is selected
or touch is released.

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::expandSelection):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):

2:53 PM Changeset in webkit [146527] by jsbell@chromium.org

5 edits in trunk/Source/WebCore

IndexedDB: Ensure all API methods have IDB_TRACE macros
https://bugs.webkit.org/show_bug.cgi?id=112963

Reviewed by Tony Chang.

Anntotate methods and callbacks that weren't already annotated
with IDB_TRACE macros to assist in debugging, e.g. when using
the chromium port's chrome://tracing visualization.

No new tests - just harmless diagnostic sprinkles.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore): Added IDB_TRACE macro call here.
(WebCore::IDBDatabase::deleteObjectStore): ...and here.
(WebCore::IDBDatabase::transaction): ...etc.
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::onVersionChange):

Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::deleteDatabase):

Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::open):

Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onBlocked):

2:52 PM Changeset in webkit [146526] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] addSearchProvider shouldn't match the full host, only the server
https://bugs.webkit.org/show_bug.cgi?id=112960

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-03-21
Reviewed by Rob Buis.
Internally Reviewed by Jeff Rogers.

Remove full host matching. only check if domains are from the same server.

Also, check user gesture before dispatching the addSearchProvider event to the browser.

WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::addSearchProvider):
(WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):

WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

WebCoreSupport/ExternalExtension.cpp:

(IsSearchProviderInstalledMethod):

2:51 PM Changeset in webkit [146525] by jochen@chromium.org

2 edits in trunk/LayoutTests

Skip triaged crashes on content shell

Unreviewed gardening

platform/chromium/ContentShellTestExpectations:

2:49 PM Changeset in webkit [146524] by rniwa@webkit.org

2 edits in trunk/Websites/bugs.webkit.org

EWS bubbles need more space
https://bugs.webkit.org/show_bug.cgi?id=112964

Reviewed by Philip Rogers.

Increased the width from 500px to 600px so that all bubbles fit.

template/en/custom/attachment/list.html.tmpl:

2:47 PM Changeset in webkit [146523] by tkent@chromium.org

2 edits in trunk/LayoutTests

fast/frames/detach-frame-during-focus.html fails on some platforms
https://bugs.webkit.org/show_bug.cgi?id=112904

fast/frames/detach-frame-during-focus.html:

Do not run the test sequence twice.

2:37 PM Changeset in webkit [146522] by commit-queue@webkit.org

3 edits
2 adds in trunk

http://trac.webkit.org/changeset/146375 causing CrOS crashes
https://bugs.webkit.org/show_bug.cgi?id=112958

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-21
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/flexbox/crash-anonymous-box.html

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
Anonymous renderers don't have a node in their constructor, so
don't get document() in there.

LayoutTests:

fast/flexbox/crash-anonymous-box-expected.txt: Added.
fast/flexbox/crash-anonymous-box.html: Added.

2:30 PM Changeset in webkit [146521] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/chromium

[chromium] Add possibleUserNames to WebPasswordFormData
https://bugs.webkit.org/show_bug.cgi?id=112375

Patch by Garrett Casto <gcasto@chromium.org> on 2013-03-21
Reviewed by Adam Barth.

public/WebPasswordFormData.h:

(WebPasswordFormData):

src/WebPasswordFormData.cpp:

(WebKit::WebPasswordFormData::WebPasswordFormData):

src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

src/WebPasswordFormUtils.h:

(PasswordFormFields):

2:25 PM Changeset in webkit [146520] by mkwst@chromium.org

3 edits
2 adds in trunk

CSP 1.1: Fire a SecurityPolicyViolationEvent when violations occur.
https://bugs.webkit.org/show_bug.cgi?id=112783

Reviewed by Adam Barth.

Source/WebCore:

A new event type for Content Security Policy violations landed in
http://wkrev.com/146305; this patch takes that stub, and wires it up to
ContentSecurityPolicy::reportViolation such that violation events fire
when resources are blocked.

This should bring WebKit up to date with the current description of
CSP's event model in sections 3.3[1] and 3.4.1.3[2] of the editor's
draft.

[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#processing-model
[2]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#firing-events-using-the-securitypolicyviolationevent-interface

Test: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html

page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):

Populate a SecurityPolicyViolationEventInit object with the various
bits of data that should be passed into the event constructor.

This static method is strictly an implementation detail; it's not
part of ContentSecurityPolicy's public API.

(WebCore::ContentSecurityPolicy::reportViolation):

Regardless of whether the policy has set a 'report-uri' directive
or not, gather together all the data we'll need to fire an event,
create the event, and queue it up for dispatching on the Document.

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html: Added.

2:22 PM Changeset in webkit [146519] by tdanderson@chromium.org

8 edits in trunk/Source

[chromium] Remove SK_SUPPORT_HINTING_SCALE_FACTOR flag and code
https://bugs.webkit.org/show_bug.cgi?id=112928

Reviewed by Stephen White.

This flag was only for ChromeOS builds with HighDPI. It is no longer needed and can be removed.
See http://crbug.com/17550

Source/WebCore:

No new tests needed since this is just removing unused code.

platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setupPaintCommon):

platform/graphics/skia/PlatformContextSkia.h:

Source/WebKit/chromium:

features.gypi:
tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
tests/PlatformContextSkiaTest.cpp:

2:16 PM Changeset in webkit [146518] by timothy@apple.com

14 edits in trunk/Source/WebKit2

Support connecting the Web Inspector without showing it.

This allows you to get the debugger attached in the background. When a breakpoint is hit
the Inspector will open. This change also reduces some WebProcess messaging by removing
the DidLoadInspectorPage message and stops sending the SetAttachedWindow message on close.

https://bugs.webkit.org/show_bug.cgi?id=112445

Reviewed by Sam Weinig.

UIProcess/API/C/WKInspector.cpp:

(WKInspectorIsConnected): Added.
(WKInspectorConnect): Added.
(WKInspectorHide): Added.

UIProcess/API/C/WKInspector.h:

Added new APIs.

UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):
Initialize new state booleans.

(WebKit::WebInspectorProxy::invalidate):
Don't set state booleans that didClose already resets.

(WebKit::WebInspectorProxy::connect): Added.
(WebKit::WebInspectorProxy::show):
Open if we are already connected. Call connect().

(WebKit::WebInspectorProxy::hide): Added.

(WebKit::WebInspectorProxy::close):
Call didClose we can detach or close the window immediately instead of waiting for a
message from the WebProcess.

(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
Check for !m_page to match other functions.

(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::didLoadInspectorPage):
Removed. Moved logic to open().

(WebKit::WebInspectorProxy::open): Added.

(WebKit::WebInspectorProxy::didClose):
Clear new state booleans. Don't perform work again if already closed. Use platformDetach()
instead of detach() to avoid sending the SetAttachedWindow message.

(WebKit::WebInspectorProxy::bringToFront):
Call open() if we are not visible yet, otherwise platformBringToFront.

UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::isConnected): Added.

UIProcess/WebInspectorProxy.messages.in: Removed DidLoadInspectorPage.

UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformHide): Added stub.

UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformHide): Added.

UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformHide): Added stub.

WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:

Removed frontendLoaded().

WebProcess/WebPage/WebInspector.cpp:
WebProcess/WebPage/WebInspector.h:

Removed didLoadInspectorPage().

2:02 PM Changeset in webkit [146517] by commit-queue@webkit.org

2 edits in trunk/Tools

Cleanup android media layout test code
https://bugs.webkit.org/show_bug.cgi?id=112944

Patch by Min Qin <qinmin@chromium.org> on 2013-03-21
Reviewed by Adam Barth.

Chromium change: https://codereview.chromium.org/12892010/
The current android layout tests are using WebmediaPlayerInProcessAndroid class.
The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
Instead, we should switch to use content shell for layout tests.

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetTestController):

2:02 PM Changeset in webkit [146516] by mkwst@chromium.org

54 edits in trunk

Drop full URLs from cross-origin access errors caused by protocol mismatches.
https://bugs.webkit.org/show_bug.cgi?id=112894

Reviewed by Timothy Hatcher.

Source/WebCore:

Following up on http://wkbug.com/112813, this patch brings protocol
mismatch errors into line with the new origin-only hotness. The message
is also changed to display the URL's protocol rather than the origin's
protocol: it makes a big difference for 'data:' URLs, for instance.

page/DOMWindow.cpp:

(WebCore::DOMWindow::crossDomainAccessErrorMessage):

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt:
http/tests/security/cross-frame-access-protocol-expected.txt:
http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
http/tests/security/view-source-no-javascript-url-expected.txt:
http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt:
http/tests/security/xssAuditor/full-block-base-href-expected.txt:
http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
platform/chromium/http/tests/security/window-named-proto-expected.txt:

1:57 PM Changeset in webkit [146515] by schenney@chromium.org

3 edits
2 adds in trunk

SVG text path referencing parent text infinite loops
https://bugs.webkit.org/show_bug.cgi?id=112078

Reviewed by Philip Rogers.

Source/WebCore:

We do not check the target type when adding a resource reference for
SVG Text Path's URI. This goes horribly wrong when the target is the
text path's parent text element. In this patch we check that the target
element of the text path is indeed a path element, as the spec
requires. No other element type is allowed.

Note that RenderSVGTextPath enforces this check in the renderer code
also, so if we get past this check via pending resources, it doesn't
matter. You can't get into this situation with a pending reference
because, by definition, the parent must be defined before the text
path child.

Test: svg/text/textpath-referencing-text-crash.svg

svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::buildPendingResource):

LayoutTests:

svg/text/textpath-referencing-text-crash-expected.txt: Added.
svg/text/textpath-referencing-text-crash.svg: Added.

1:56 PM Changeset in webkit [146514] by dpranke@chromium.org

2 edits in trunk/Tools

[chromium] add missing project dependencies to DRT to fix Mac Valgrind
https://bugs.webkit.org/show_bug.cgi?id=112953

Reviewed by Tony Chang.

When I created the DumpRenderTree_resources target in r144863 I
forgot to declare the needed dependencies on the other resource
targets. Due to a quirk of ordering, this appears to have been fine
w/ ninja but not w/ Xcode (which is still being used on the chromium
mac valgrind bots). Declaring the dependencies fixes the build
failures.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

1:53 PM Changeset in webkit [146513] by ap@apple.com

2 edits in trunk/Source/WebKit2

Build fix.

NetworkProcess/mac/NetworkResourceLoaderMac.mm: Include CurrentTime.h, as needed to call currentTime().

1:49 PM Changeset in webkit [146512] by pilgrim@chromium.org

2 edits in trunk/Source/Platform

[Chromium] Removed unused WEBKIT_USE_NEW_WEBFILESYSTEMTYPE flag
https://bugs.webkit.org/show_bug.cgi?id=112931

Reviewed by Adam Barth.

Migration complete; flag no longer needed.

chromium/public/WebFileSystemType.h:

1:43 PM Changeset in webkit [146511] by jsbell@chromium.org

14 edits in trunk/Source

IndexedDB: Remove onVersionChange(string) plumbing
https://bugs.webkit.org/show_bug.cgi?id=112712

Reviewed by Adam Barth.

Source/WebCore:

Delete unused onVersionChange(string) overload.

No new tests - just deleting dead code.

Modules/indexeddb/IDBDatabase.cpp: Delete onVersionChange(string) overload.
Modules/indexeddb/IDBDatabase.h: Ditto.
Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Ditto.
Modules/indexeddb/IDBDatabaseCallbacks.h: Ditto.
Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: Ditto.
Modules/indexeddb/IDBDatabaseCallbacksImpl.h: Ditto.

Source/WebKit/chromium:

public/WebIDBDatabaseCallbacks.h: Remove onVersionChange(string) overload.
src/IDBDatabaseCallbacksProxy.cpp: Ditto.
src/IDBDatabaseCallbacksProxy.h: Ditto.
src/WebIDBDatabaseCallbacksImpl.cpp: Ditto.
src/WebIDBDatabaseCallbacksImpl.h: Ditto.
tests/IDBAbortOnCorruptTest.cpp: Ditto.
tests/IDBDatabaseBackendTest.cpp: Ditto.

1:35 PM Changeset in webkit [146510] by pdr@google.com

4 edits
3 adds in trunk

Correct bisector angle calculation for markers
https://bugs.webkit.org/show_bug.cgi?id=112054

Reviewed by Stephen Chenney.

Source/WebCore:

The SVG marker spec states that mid markers with orient=auto should be aligned with their
x-axis along the bisector of the incoming (in) and outgoing (out) angles. Previously we
calculated this bisector angle as:

bisector = (in + out) / 2;

Angles cannot be averaged this way! Consider in=90deg and out=-180deg: the bisector should
be 135deg but a naive average gives -45deg. This patch corrects for the discontinuity in
angle values with:

bisector = (in + out + 360) / 2 if |in - out| > 180
bisector = (in + out) / 2 otherwise

This patch includes an exhaustive test of angle values.

Test: svg/custom/marker-orient-auto.html

rendering/svg/SVGMarkerData.h:

(WebCore::SVGMarkerData::currentAngle):

LayoutTests:

platform/chromium-linux/svg/custom/marker-orient-auto-expected.png: Added.
platform/chromium-linux/svg/custom/marker-orient-auto-expected.txt: Added.
platform/chromium/TestExpectations:
svg/custom/marker-orient-auto.html: Added.

1:28 PM Changeset in webkit [146509] by commit-queue@webkit.org

6 edits in trunk

Expose the Type field of an RTCStatsReport
https://bugs.webkit.org/show_bug.cgi?id=112951

Patch by Harald Alvestrand <hta@google.com> on 2013-03-21
Reviewed by Adam Barth.

Source/WebCore:

Covered by an extension of an existing test.

Modules/mediastream/RTCStatsReport.h:

(WebCore::RTCStatsReport::type):

Modules/mediastream/RTCStatsReport.idl:

LayoutTests:

fast/mediastream/RTCPeerConnection-stats-expected.txt:
fast/mediastream/RTCPeerConnection-stats.html:

1:27 PM Changeset in webkit [146508] by ap@apple.com

11 edits
1 add in trunk/Source/WebCore

Move non-trivial virtual functions out of ResourceHandleClient.h
https://bugs.webkit.org/show_bug.cgi?id=112950

Reviewed by Brady Eidson.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
platform/network/ResourceHandleClient.cpp: Added. (WebCore::ResourceHandleClient::ResourceHandleClient): (WebCore::ResourceHandleClient::~ResourceHandleClient): (WebCore::ResourceHandleClient::didReceiveBuffer): (WebCore::ResourceHandleClient::getBuffer):
platform/network/ResourceHandleClient.h:

1:19 PM Changeset in webkit [146507] by bfulgham@webkit.org

2 edits in trunk/Tools

[WinCairo] Correct assert in Empty BitmapImage Test.
https://bugs.webkit.org/show_bug.cgi?id=112934

Reviewed by Tim Horton.

TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:

(TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
to avoid ref counting assertion when leaving test scope.

1:11 PM Changeset in webkit [146506] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Windows rebaseline after r146469.

platform/win/css3/filters/effect-reference-expected.txt:
platform/win/css3/filters/effect-reference-hw-expected.txt:

1:06 PM Changeset in webkit [146505] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

Fix lexer charPosition computation when "rewind"ing the lexer.
https://bugs.webkit.org/show_bug.cgi?id=112952.

Reviewed by Michael Saboff.

Changed the Lexer to no longer keep a m_charPosition. Instead, we compute
currentCharPosition() from m_code and m_codeStartPlusOffset, where
m_codeStartPlusOffset is the SourceProvider m_codeStart + the SourceCode
start offset. This ensures that the charPosition is always in sync with
m_code.

parser/Lexer.cpp:

(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):

parser/Lexer.h:

(JSC::Lexer::currentCharPosition):
(JSC::::lexExpectIdentifier):

1:05 PM Changeset in webkit [146504] by zandobersek@gmail.com

2 edits in trunk/Tools

[GTK] generate-feature-defines-files is incompatible with Python3
https://bugs.webkit.org/show_bug.cgi?id=112956

Reviewed by Martin Robinson.

Make the generate-feature-defines-files compatible with Python3 by calling the items()
method on the dictionary objects when iterating through said dictionaries.

gtk/generate-feature-defines-files:

(write_feature_defines_header):
(write_flattened_feature_defines_file):

1:03 PM WebKitGTK/2.0.x edited by Martin Robinson

(diff)

1:02 PM Changeset in webkit [146503] by fmalita@chromium.org

13 edits
1 delete in trunk/Source/WebCore

[SVG] Remove explicit LightSource dispatchers
https://bugs.webkit.org/show_bug.cgi?id=112827

Reviewed by Stephen Chenney.

Convert LightSource setters to dynamic dispatch. This allows us to remove LightSource.cpp
altogether.

No new tests: refactoring only.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/filters/DistantLightSource.h:

(DistantLightSource):

platform/graphics/filters/LightSource.cpp: Removed.
platform/graphics/filters/LightSource.h:

(WebCore::LightSource::setAzimuth):
(WebCore::LightSource::setElevation):
(WebCore::LightSource::setX):
(WebCore::LightSource::setY):
(WebCore::LightSource::setZ):
(WebCore::LightSource::setPointsAtX):
(WebCore::LightSource::setPointsAtY):
(WebCore::LightSource::setPointsAtZ):
(WebCore::LightSource::setSpecularExponent):
(WebCore::LightSource::setLimitingConeAngle):

platform/graphics/filters/PointLightSource.h:

(PointLightSource):

platform/graphics/filters/SpotLightSource.h:

(SpotLightSource):

12:55 PM Changeset in webkit [146502] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[BlackBerry] GCActivityCallback: replace JSLock with JSLockHolder
https://bugs.webkit.org/show_bug.cgi?id=112448

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Xan Lopez.

This changed in r121381.

runtime/GCActivityCallbackBlackBerry.cpp:

(JSC::DefaultGCActivityCallback::doWork):

12:51 PM Changeset in webkit [146501] by igor.o@sisa.samsung.com

2 edits in trunk/Source/WebCore

[Texmap] Implement support for OpenGLES EXT_unpack_subimage extension
https://bugs.webkit.org/show_bug.cgi?id=108716

If the extension GL_EXT_unpack_subimage is supported, it adds GL_UNPACK_ROW_LENGTH,
GL_UNPACK_SKIP_ROWS and GL_UNPACK_SKIP_PIXELS as valid enums to PixelStore.

Reviewed by Noam Rosenthal.

platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::driverSupportsSubImage):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):

12:42 PM Changeset in webkit [146500] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Regression: drawer resizes slowly with animation.
https://bugs.webkit.org/show_bug.cgi?id=112920

Drawer status bar opacity wasn't set to zero on inialization, so no transition event
was fired on first time drawer appeared,thus animation styles wasn't removed properly.

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-21
Reviewed by Vsevolod Vlasov.

inspector/front-end/Drawer.js:

(WebInspector.Drawer):

12:36 PM Changeset in webkit [146499] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[BlackBerry] GraphicsLayer: fix code that was accidentally reverted
https://bugs.webkit.org/show_bug.cgi?id=112143

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Rob Buis.

Several changes were accidentally reverted in r144465 due to the
upstreaming of some new code:

clearBackgroundColor() and m_contentsLayerHasBackgroundColor had been removed in r137798.

showDebugBorders() had been renamed to isShowingDebugBorder() in r133517.

A new GraphicsLayer::create() overload had been introduced in r130185.

This patch fixes them all.

platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayer::create):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):

platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(GraphicsLayerBlackBerry):

12:25 PM Changeset in webkit [146498] by zandobersek@gmail.com

6 edits
1 add in trunk

[GTK] Move libLevelDB.la setup into a separate GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=112947

Reviewed by Martin Robinson.

GNUmakefile.am: Include the new GNUmakefile.am, located under Source/ThirdParty/leveldb.

Source/ThirdParty:

leveldb/GNUmakefile.am: Added, sets up the libLevelDB.la library.

Source/WebCore:

No new tests - no new functionality.

GNUmakefile.am: Move the libLevelDD.la setup into the new GNUmakefile.am that's placed in

the third-party leveldb source directory.

GNUmakefile.list.am: Move the LevelDB sources listing there as well.

12:25 PM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos

(diff)

12:23 PM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos

(diff)

12:22 PM Changeset in webkit [146497] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] DrawingBuffer: add clearPlatformLayer() implementation
https://bugs.webkit.org/show_bug.cgi?id=112696

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Rob Buis.

DrawingBuffer::clearPlatformLayer() was added in r139142.

This is not needed in the BlackBerry port, so this patch only
contains a dummy implementation.

platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:

(WebCore):
(WebCore::DrawingBuffer::clearPlatformLayer):

12:19 PM Changeset in webkit [146496] by rniwa@webkit.org

2 edits in trunk/Tools

kill-old-processes spits out error messages on Mac
https://bugs.webkit.org/show_bug.cgi?id=112878

Reviewed by Jessie Berlin.

Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
included in the list of options grep --help shows.

Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.

BuildSlaveSupport/kill-old-processes:

(main):

12:14 PM Changeset in webkit [146495] by fmalita@chromium.org

15 edits
2 adds in trunk

[SVG] Suppress painting when an empty viewBox is specified
https://bugs.webkit.org/show_bug.cgi?id=112623

Reviewed by Philip Rogers.

Source/WebCore:

Per spec, elements with an empty viewBox should not be rendered:
http://www.w3.org/TR/SVG/coords.html#ViewBoxAttribute.

This patch adds the missing viewBox checks to RenderSVGRoot, RenderSVGViewPortContainer,
RenderSVGResourceMarker and RenderSVGResourceMarker's paint methods.

In order to detect the case of "viewBox present but invalid", the patch also introduces
SVGAnimatedProperty plumbing for tracking property validity: the baseVal setter now takes
an additional optional 'validValue' boolean parameter, which can later be queried via a
macroed getter (LowerProperty##IsValid()).

Test: svg/custom/viewBox-empty.html

rendering/svg/RenderSVGResourceMarker.cpp:

(WebCore::RenderSVGResourceMarker::draw):

rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::paint):
(WebCore):

rendering/svg/RenderSVGViewportContainer.h:

(RenderSVGViewportContainer):

svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::collectPatternAttributes):

svg/SVGSVGElement.h:

(WebCore::SVGSVGElement::hasEmptyViewBox):
(SVGSVGElement):
Suppress painting if a valid empty viewBox is found.

svg/SVGFitToViewBox.h:

(WebCore::SVGFitToViewBox::parseAttribute):
Mark the viewBox property as invalid if not successfully parsed.

svg/SVGExternalResourcesRequired.h:

(SVGExternalResourcesRequired):

svg/SVGURIReference.h:

(SVGURIReference):

svg/properties/SVGAnimatedPropertyMacros.h:

(WebCore::SVGSynchronizableAnimatedProperty::SVGSynchronizableAnimatedProperty):
(SVGSynchronizableAnimatedProperty):
(WebCore):
Plumbing for tracking property value validation.

LayoutTests:

svg/custom/script-tests/svg-viewBox-dynamic.js:
svg/custom/svg-viewBox-dynamic-expected.txt:
svg/custom/viewBox-empty-expected.html: Added.
svg/custom/viewBox-empty.html: Added.

12:09 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

(diff)

12:06 PM Changeset in webkit [146494] by mhahnenberg@apple.com

16 edits
1 move in trunk/Source/JavaScriptCore

Objective-C API: wrapperClass holds a static JSClassRef, which causes JSGlobalObjects to leak
https://bugs.webkit.org/show_bug.cgi?id=112856

Reviewed by Geoffrey Garen.

Through a very convoluted path that involves the caching of prototypes on the JSClassRef, we can leak
JSGlobalObjects when inserting an Objective-C object into multiple independent JSContexts.

API/JSAPIWrapperObject.cpp: Removed.
API/JSAPIWrapperObject.h:

(JSAPIWrapperObject):

API/JSAPIWrapperObject.mm: Copied from Source/JavaScriptCore/API/JSAPIWrapperObject.cpp. Made this an

Objective-C++ file so that we can call release on the wrappedObject. Also added a WeakHandleOwner for
JSAPIWrapperObjects. This will also be used in a future patch for https://bugs.webkit.org/show_bug.cgi?id=112608.
(JSAPIWrapperObjectHandleOwner):
(jsAPIWrapperObjectHandleOwner):
(JSAPIWrapperObjectHandleOwner::finalize): This finalize replaces the old finalize that was done through
the C API.
(JSC::JSAPIWrapperObject::finishCreation): Allocate the WeakImpl. Balanced in finalize.
(JSC::JSAPIWrapperObject::setWrappedObject): We now do the retain of the wrappedObject here rather than in random
places scattered around JSWrapperMap.mm

API/JSObjectRef.cpp: Added some ifdefs for platforms that don't support the Obj-C API.

(JSObjectGetPrivate): Ditto.
(JSObjectSetPrivate): Ditto.
(JSObjectGetPrivateProperty): Ditto.
(JSObjectSetPrivateProperty): Ditto.
(JSObjectDeletePrivateProperty): Ditto.

API/JSValueRef.cpp: Ditto.

(JSValueIsObjectOfClass): Ditto.

API/JSWrapperMap.mm: Remove wrapperClass().

(objectWithCustomBrand): Change to no longer use a parent class, which was only used to give the ability to
finalize wrapper objects.
(-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]): Change to no longer use wrapperClass().
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): Ditto.
(tryUnwrapObjcObject): We now check if the object inherits from JSAPIWrapperObject.

API/tests/testapi.mm: Added a test that exports an Objective-C object to two different JSContexts and makes

sure that the first one is collected properly by using a weak JSManagedValue for the wrapper in the first JSContext.

CMakeLists.txt: Build file modifications.
GNUmakefile.list.am: Ditto.
JavaScriptCore.gypi: Ditto.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Ditto.
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
runtime/JSGlobalObject.cpp: More ifdefs for unsupported platforms.

(JSC::JSGlobalObject::reset): Ditto.
(JSC::JSGlobalObject::visitChildren): Ditto.

runtime/JSGlobalObject.h: Ditto.

(JSGlobalObject): Ditto.
(JSC::JSGlobalObject::objcCallbackFunctionStructure): Ditto.

11:54 AM Changeset in webkit [146493] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: Hide toolbar customization experimental setting
https://bugs.webkit.org/show_bug.cgi?id=112942

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.

inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

inspector/front-end/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._isToolbarCustomizable):

11:52 AM Changeset in webkit [146492] by senorblanco@chromium.org

10 edits
10 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

New test results for effect-reference and effect-reference-hw.

platform/chromium-linux-x86/css3/filters/effect-reference-expected.png: Removed.
platform/chromium-linux-x86/css3/filters/effect-reference-expected.txt: Removed.
platform/chromium-linux/css3/filters/effect-reference-expected.png: Removed.
platform/chromium-linux/css3/filters/effect-reference-expected.txt: Removed.
platform/chromium-mac-lion/css3/filters/effect-reference-expected.png: Removed.
platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Removed.
platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Removed.
platform/chromium-mac/css3/filters/effect-reference-expected.png:
platform/chromium-mac/css3/filters/effect-reference-expected.txt:
platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
platform/chromium-win-xp/css3/filters/effect-reference-expected.png: Removed.
platform/chromium-win-xp/css3/filters/effect-reference-expected.txt: Removed.
platform/chromium-win/css3/filters/effect-reference-expected.png:
platform/chromium-win/css3/filters/effect-reference-expected.txt:
platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
platform/chromium-win/css3/filters/effect-reference-hw-expected.txt:
platform/chromium/TestExpectations:

11:52 AM Changeset in webkit [146491] by commit-queue@webkit.org

2 edits in trunk/Tools

[BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
https://bugs.webkit.org/show_bug.cgi?id=112597

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Xan Lopez.

These were introduced for the Chromium port in r105295. We need
dummy implementations in order to compile the BlackBerry port.

DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:

(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):

11:45 AM Changeset in webkit [146490] by Claudio Saavedra

2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening.

platform/gtk/TestExpectations: Remove redundant entry.

11:26 AM Changeset in webkit [146489] by antonm@chromium.org

22 edits
9 deletes in trunk/Source

Unreviewed, rolling out r146483.
http://trac.webkit.org/changeset/146483
https://bugs.webkit.org/show_bug.cgi?id=111695

Source/JavaScriptCore:

Breaks debug builds.

bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.

Source/Platform:

Breaks

Platform.gypi:
chromium/public/Platform.h:

(WebKit):
(Platform):

chromium/public/WebSpeechSynthesisUtterance.h: Removed.
chromium/public/WebSpeechSynthesisVoice.h: Removed.
chromium/public/WebSpeechSynthesizer.h: Removed.
chromium/public/WebSpeechSynthesizerClient.h: Removed.

Source/WebCore:

Breaks

Modules/speech/SpeechSynthesis.cpp:

Modules/speech/SpeechSynthesis.h:

(SpeechSynthesis):

Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):

Modules/speech/SpeechSynthesisUtterance.h:

(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
(SpeechSynthesisUtterance):

Modules/speech/SpeechSynthesisVoice.h:

(SpeechSynthesisVoice):

WebCore.exp.in:
WebCore.gypi:
platform/PlatformSpeechSynthesis.h:

(PlatformSpeechSynthesis):

platform/PlatformSpeechSynthesisUtterance.cpp:
platform/PlatformSpeechSynthesisUtterance.h:

(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::client):

platform/PlatformSpeechSynthesisVoice.cpp:

(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):

platform/PlatformSpeechSynthesisVoice.h:

(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::voiceURI):
(WebCore::PlatformSpeechSynthesisVoice::name):
(WebCore::PlatformSpeechSynthesisVoice::lang):
(WebCore::PlatformSpeechSynthesisVoice::localService):

platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):

platform/PlatformSpeechSynthesizer.h:

(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(PlatformSpeechSynthesizer):

platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Removed.
platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Removed.
platform/chromium/support/WebSpeechSynthesisVoice.cpp: Removed.
platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Removed.
platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Removed.
platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::speak):

platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::create):
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):

platform/mock/PlatformSpeechSynthesizerMock.h:

(PlatformSpeechSynthesizerMock):

11:19 AM Changeset in webkit [146488] by ap@apple.com

2 edits in trunk/Source/WebCore

[Mac] Consolidate bits of willSendRequest implementation
https://bugs.webkit.org/show_bug.cgi?id=112932

Reviewed by Brady Eidson.

Moved some logic from WebCoreResourceHandleAsDelegate to ResourceHandle for clarity.

platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):

11:08 AM Changeset in webkit [146487] by danakj@chromium.org

2 edits in trunk/Source/Platform

[chromium] Add isOrphan() to the WebLayer API
https://bugs.webkit.org/show_bug.cgi?id=112649

Reviewed by James Robinson.

This method will be used by WebMediaPlayerClientImpl to tell
if the compositing video layer is currently being used to
display the video content or not.

chromium/public/WebLayer.h:

(WebLayer):

11:08 AM Changeset in webkit [146486] by commit-queue@webkit.org

17 edits
2 adds
2 deletes in trunk

Remove AudioGain.idl from compilation.
https://bugs.webkit.org/show_bug.cgi?id=112650

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-03-21
Reviewed by Chris Rogers.

Source/WebCore:

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#GainNode

https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioBufferSourceNode

AudioParam serves the same purpose as AudioGain. Infact, AudioGain inherits
AudioParam class and doesn't have its own member functions/parameters. Also,
AudioGain is not part of WebAudio W3C specifications.

Test: webaudio/gain-basic.html

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):

Modules/webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::gain):

Modules/webaudio/AudioBufferSourceNode.idl:
Modules/webaudio/AudioGain.h: Removed.
Modules/webaudio/AudioGain.idl: Removed.
Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::GainNode):

Modules/webaudio/GainNode.h:

(WebCore):
(WebCore::GainNode::create):
(GainNode):
(WebCore::GainNode::gain):

Modules/webaudio/GainNode.idl:
Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):

Modules/webaudio/PannerNode.h:

(WebCore::PannerNode::distanceGain):
(WebCore::PannerNode::coneGain):

Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Test to verify GainNode attributes.

webaudio/gain-basic-expected.txt: Added.
webaudio/gain-basic.html: Added.

10:56 AM Changeset in webkit [146485] by roger_fong@apple.com

2 edits in trunk/Tools

Re-enable WinEWS tests following r146376.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

10:31 AM Changeset in webkit [146484] by antonm@chromium.org

2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky

platform/chromium/TestExpectations:

10:24 AM Changeset in webkit [146483] by dmazzoni@google.com

21 edits
9 adds in trunk/Source

Implement Web Speech Synthesis for Chromium
https://bugs.webkit.org/show_bug.cgi?id=111695

Reviewed by Adam Barth.

Source/Platform:

Exposes a platform API that the embedder can implement to
provide speech synthesis for the Chromium port.

Platform.gypi:
chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::speechSynthesizer):

chromium/public/WebSpeechSynthesisUtterance.h: Added.

chromium/public/WebSpeechSynthesisVoice.h: Added.

chromium/public/WebSpeechSynthesizer.h: Added.

(WebKit):
(WebSpeechSynthesizer):
(WebKit::WebSpeechSynthesizer::~WebSpeechSynthesizer):

chromium/public/WebSpeechSynthesizerClient.h: Added.

(WebKit):
(WebSpeechSynthesizerClient):
(WebKit::WebSpeechSynthesizerClient::~WebSpeechSynthesizerClient):

Source/WebCore:

Straightforward implementation of speech synthesis
for Chromium by exposing interfaces for the platform
to implement.

Modules/speech/SpeechSynthesis.cpp:

Modules/speech/SpeechSynthesis.h:

(SpeechSynthesis):

Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore):
(WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):

Modules/speech/SpeechSynthesisUtterance.h:

Modules/speech/SpeechSynthesisVoice.h:

(WebCore::SpeechSynthesisVoice::~SpeechSynthesisVoice):

WebCore.exp.in:
WebCore.gypi:
platform/PlatformSpeechSynthesis.h:

(PlatformSpeechSynthesis):

platform/PlatformSpeechSynthesisUtterance.cpp:

(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::create):

platform/PlatformSpeechSynthesisUtterance.h:

(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setClient):

platform/PlatformSpeechSynthesisVoice.cpp:

(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):

platform/PlatformSpeechSynthesisVoice.h:

platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::setVoiceList):
(WebCore):

platform/PlatformSpeechSynthesizer.h:

(WebKit):
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):

platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Added.

platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Added.

platform/chromium/support/WebSpeechSynthesisVoice.cpp: Added.

platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Added.

platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Added.

(WebCore):
(WebSpeechSynthesizerClientImpl):

platform/mac/PlatformSpeechSynthesizerMac.mm:

platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):

platform/mock/PlatformSpeechSynthesizerMock.h:

(PlatformSpeechSynthesizerMock):

10:14 AM Changeset in webkit [146482] by jchaffraix@webkit.org

7 edits
4 adds in trunk

[CSS Grid Layout] Properly layout spanning grid items with minmax grid tracks
https://bugs.webkit.org/show_bug.cgi?id=112389

Reviewed by Tony Chang.

Source/WebCore:

This change updates our core minmax resolution function to be spanning grid
items aware. The new implementation of the algorithm doesn't totally match
the specification but it is fairly close that it's a good first pass. The
extra complexity in the specification needs to be carefully examinated
first (not to mention the probable change in the core layout algorithm).

Tests: fast/css-grid-layout/minmax-spanning-resolution-columns.html

fast/css-grid-layout/minmax-spanning-resolution-rows.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Updated this function to account for spanning grid items by:

iterating over all spanned grid tracks.
removing any used breadth from all spanned grid tracks.

LayoutTests:

fast/css-grid-layout/grid-item-spanning-resolution.html:
fast/css-grid-layout/resources/grid.css:

(.firstRowBothColumn):
(.secondRowBothColumn):
(.bothRowFirstColumn):
(.bothRowSecondColumn):
(.bothRowBothColumn):
Moved the previous classes for maximum reuse.

fast/css-grid-layout/minmax-spanning-resolution-columns-expected.txt: Added.
fast/css-grid-layout/minmax-spanning-resolution-columns.html: Added.
fast/css-grid-layout/minmax-spanning-resolution-rows-expected.txt: Added.
fast/css-grid-layout/minmax-spanning-resolution-rows.html: Added.

New tests.

fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:

Unintended consistent progression from this change, it's unclear why these baselines
change as the tests involve no spanning.

9:55 AM Changeset in webkit [146481] by antonm@chromium.org

2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky

platform/chromium/TestExpectations:

9:51 AM Changeset in webkit [146480] by zoltan@webkit.org

2 edits in trunk/Tools

Unreviewed. Add Bem Jones-Bey to the list of contributors.

Scripts/webkitpy/common/config/committers.py:

9:45 AM Changeset in webkit [146479] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GStreamer] New reference returned by g_main_context_new() must be freed
https://bugs.webkit.org/show_bug.cgi?id=112899

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.

Fix a memory leak by adopting the new reference returned
by g_main_context_new().

No new tests. No change in behavior.

platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

9:32 AM Changeset in webkit [146478] by commit-queue@webkit.org

4 edits
3 adds in trunk/Source/WebCore

[BlackBerry] Add ScrollingCoordinatorBlackBerry implementation
https://bugs.webkit.org/show_bug.cgi?id=112915

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-03-21
Reviewed by Rob Buis.

PlatformBlackBerry.cmake: Add page/scrolling/blackberry to the

indlude dir list.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create): Create a
ScrollingCoordinatorBlackBerry for the BlackBerry platform.

page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp: Added.

(WebCore):
(WebCore::ScrollingCoordinatorBlackBerry::ScrollingCoordinatorBlackBerry):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsFixedToContainerLayer):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerFixedToContainerLayerEdge):
(WebCore::ScrollingCoordinatorBlackBerry::frameViewFrameRectDidChange):
(WebCore::ScrollingCoordinatorBlackBerry::frameViewContentsSizeDidChange):

page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.h: Added.

(WebCore):
(ScrollingCoordinatorBlackBerry):
(WebCore::ScrollingCoordinatorBlackBerry::supportsFixedPositionLayers):

platform/graphics/PlatformLayer.h:

(WebCore): Add PlatformLayer definition for BlackBerry.

9:28 AM Changeset in webkit [146477] by antonm@chromium.org

2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky

platform/chromium/TestExpectations:

8:57 AM Changeset in webkit [146476] by caseq@chromium.org

9 edits
1 add in trunk

Web Inspector: Paint rectangles shown on hover over Timeline's paint records occasionally have wrong offsets
https://bugs.webkit.org/show_bug.cgi?id=112371

Reviewed by Pavel Feldman.

Source/WebCore:

pass frame to InspectorTimelineAgent::didPaint();
convert paint coordinates to root view.

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didPaint):

inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

LayoutTests:

http/tests/inspector/timeline-test.js:

(initialize_Timeline.InspectorTest.startTimeline.InspectorTest._addTimelineEvent):
(initialize_Timeline.InspectorTest.startTimeline):
(initialize_Timeline.addEvent):
(initialize_Timeline.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
(initialize_Timeline.InspectorTest.stopTimeline):

inspector/timeline/timeline-paint-expected.txt:
inspector/timeline/timeline-paint.html:

8:49 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

8:49 AM Changeset in webkit [146475] by caseq@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: do not use inspector cookie in InspectorInstrumentation::{will,did}Paint
https://bugs.webkit.org/show_bug.cgi?id=112787

Reviewed by Pavel Feldman.

pass frame, not inspector cookie to InspectorInstrumentation::didPaint;
use frame to determine timeline agent in InspectorInstrumentation::didPaint.

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):

page/FrameView.cpp:

(WebCore::FrameView::paintContents):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

8:36 AM Changeset in webkit [146474] by kov@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
https://bugs.webkit.org/show_bug.cgi?id=103035

Patch by Sandeep Shedmake <sshedmak@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

mr.po: updated.

8:30 AM Changeset in webkit [146473] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146463 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100590

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

pl.po: Updated.

8:28 AM Changeset in webkit [146472] by Claudio Saavedra

2 edits in trunk/Tools

[GTK] Missing atk in install-dependencies script
https://bugs.webkit.org/show_bug.cgi?id=112272

Reviewed by Gustavo Noronha Silva.

gtk/install-dependencies: Add missing atk dependency.

8:16 AM Changeset in webkit [146471] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Marking http/tests/appcache/abort-cache-ondownloading-resource-404.html as flaky.
Unskipping tests under perf/ to see how they behave.

platform/gtk/TestExpectations:

8:09 AM Changeset in webkit [146470] by jchaffraix@webkit.org

3 edits
2 adds in trunk

[CSS Grid Layout] OOB access in RenderGrid with a grid item with negative position index
https://bugs.webkit.org/show_bug.cgi?id=112853

Reviewed by Tony Chang.

Source/WebCore:

This issue was caused by us casting a negative int to a size_t by mistake. This
would make us not size the grid properly thus yielding to OOB access during the
rest of the layout.

Test: fast/css-grid-layout/grid-item-negative-indexes.html

rendering/RenderGrid.cpp:

(WebCore::estimatedGridSizeForPosition):
Added this helper function to do the proper estimation and checks that our
position can be represented by a size_t.

(WebCore::RenderGrid::maximumIndexInDirection):
Updated to use estimatedGridSizeForPosition.

LayoutTests:

fast/css-grid-layout/grid-item-negative-indexes-expected.txt: Added.
fast/css-grid-layout/grid-item-negative-indexes.html: Added.

7:58 AM Changeset in webkit [146469] by senorblanco@chromium.org

7 edits
1 add in trunk

[skia] feConvolveMatrix should use accelerated path
https://bugs.webkit.org/show_bug.cgi?id=112828

Reviewed by James Robinson.

Source/WebCore:

Covered by layout tests css3/filters/effect-reference*.html.

WebCore.gypi:

Add FEConvolveMatrixSkia.cpp to the build.

platform/graphics/filters/FEConvolveMatrix.h:

Enable the skia accelerated path for feConvolveMatrix.

platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp:

(WebCore::FEConvolveMatrix::createImageFilter):
Implement building/conversion from FEConvolveMatrix to
SkMatrixConvolutionImageFilter.

LayoutTests:

css3/filters/effect-reference-hw.html:
css3/filters/effect-reference.html:

Add new test case for feConvolveMatrix as a reference filter.

platform/chromium/TestExpectations:

Suppress failures until the test can be rebaselined.

7:56 AM Changeset in webkit [146468] by commit-queue@webkit.org

5 edits in trunk

Source/ThirdParty/leveldb/db/builder.cc does not build on systems without <endian.h>
https://bugs.webkit.org/show_bug.cgi?id=111817

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva.

Improve processing of the autoconf host variable. Setup up the wiring to detect
whether or not we are compiling for Darwin.

Source/autotools/CheckSystemAndBasicDependencies.m4: Improve host detection.
Source/autotools/SetupAutomake.m4: Tell automake if we are compiling for Darwin or not.

Source/WebCore:

GNUmakefile.am: Add the appropriate flags to the LevelDB build if we are on FreeBSD

or OS X.

7:53 AM Changeset in webkit [146467] by jchaffraix@webkit.org

3 edits
6 adds in trunk

[CSS Grid Layout] Support default grid items sizing
https://bugs.webkit.org/show_bug.cgi?id=103333

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html

fast/css-grid-layout/grid-auto-columns-rows-resolution.html
fast/css-grid-layout/grid-auto-columns-rows-update.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::gridTrackSize):
Core of the change: return the grid-auto-{rows|columns} instead of a pre-defined value.

(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Fixed a latent bug: we need to iterate over the internal grid representation instead of the
style's rows / columns as the latter doesn't account for implicit rows / columns.

LayoutTests:

fast/css-grid-layout/grid-auto-columns-rows-resolution-expected.txt: Added.
fast/css-grid-layout/grid-auto-columns-rows-resolution.html: Added.

This test covers the simple implicit column / row case.

fast/css-grid-layout/grid-auto-columns-rows-update-expected.txt: Added.
fast/css-grid-layout/grid-auto-columns-rows-update.html: Added.

This test covers that modifying grid-auto-{rows|columns} updates the grid items' sizes.

fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution-expected.txt: Added.
fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html: Added.

This test covers the implicit rows / columns generated by the auto placement. We are failing
2 sub-tests due to a bug involving percentage grid items in grid rows.

7:46 AM Changeset in webkit [146466] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip some failing tests.

platform/qt/TestExpectations:

7:43 AM Changeset in webkit [146465] by Claudio Saavedra

2 edits in trunk/Tools

[GTK] Missing backslash in install-dependencies script
https://bugs.webkit.org/show_bug.cgi?id=112907

Reviewed by Philippe Normand.

gtk/install-dependencies: Add missing backslash to dependencies

list.

7:30 AM Changeset in webkit [146464] by abarth@webkit.org

11 edits
1 add in trunk/Source

HTMLNames should construct strings at compile time
https://bugs.webkit.org/show_bug.cgi?id=112831

Reviewed by Darin Adler.

Source/WebCore:

This patch teaches make_names how to construct strings at compile time,
eliminating a large number of startup mallocs.

WebCore.gyp/WebCore.gyp:
WebCore.gyp/scripts/action_makenames.py:
- Teach the Chromium build how to deal with Perl modules.
bindings/scripts/StaticString.pm: Added.
- A Perl module for constructing static strings.

(GenerateStrings):
(GenerateValidateStrings):

dom/QualifiedName.cpp:

(WebCore::createQualifiedName):

createQualifiedName now takes an already-constructed StringImpl object.

dom/QualifiedName.h:
dom/make_names.pl:

(valueForName):
(namesToStrings):
(printNamesCppFile):
(printDefinitions):

Teach make_names how to use StaticString.pm.

Source/WTF:

wtf/text/StringImpl.h:

(StringImpl):
(StaticASCIILiteral):

This struct lets us construct StringImpl objects at compile time.

(WTF::StringImpl::assertHashIsCorrect):

This function lets us sanity check StringImpl objects created from StaticData.

(WTF::StringImpl::find): Remove a stray ;
(WTF::StringImpl::findIgnoringCase): ditto
(WTF::StringImpl::startsWith): ditto
(WTF::ValueCheck<StringImpl*>):

wtf/text/AtomicStringImpl.h:

(WTF::ValueCheck<AtomicStringImpl*>):

7:09 AM Changeset in webkit [146463] by kov@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100590

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

pl.po: Updated.

6:50 AM Changeset in webkit [146462] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146461 - [as-IN] Translations of WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=112791

Patch by Nilamdyuti Goswami <ngoswami@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

as.po: Updated.

6:49 AM Changeset in webkit [146461] by kov@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

[as-IN] Translations of WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=112791

Patch by Nilamdyuti Goswami <ngoswami@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

as.po: Updated.

6:43 AM Changeset in webkit [146460] by commit-queue@webkit.org

10 edits
10 adds in trunk/LayoutTests

[EFL] Rebaseline most "needs rebaseline" sections of EFL test expectations, and update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=112901

https://bugs.webkit.org/show_bug.cgi?id=105437
https://bugs.webkit.org/show_bug.cgi?id=65643
https://bugs.webkit.org/show_bug.cgi?id=14664
https://bugs.webkit.org/show_bug.cgi?id=110654

Unreviewed, rebaselining.
Adding failure expectation for the test added in r133834.

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-21

platform/efl/TestExpectations:
platform/efl/css2.1/20110323/replaced-elements-001-expected.txt:
platform/efl/fast/block/float/024-expected.txt:
platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
platform/efl/fast/repaint/moving-shadow-on-container-expected.png: Added.
platform/efl/fast/repaint/moving-shadow-on-container-expected.txt: Added.
platform/efl/svg/css/arrow-with-shadow-expected.txt:
platform/efl/svg/css/clippath-with-shadow-expected.txt:
platform/efl/svg/css/composite-shadow-example-expected.png: Added.
platform/efl/svg/css/composite-shadow-example-expected.txt: Added.
platform/efl/svg/css/composite-shadow-with-opacity-expected.png: Added.
platform/efl/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/efl/svg/custom/feDisplacementMap-01-expected.png: Added.
platform/efl/svg/custom/feDisplacementMap-01-expected.txt: Added.
platform/efl/svg/custom/foreign-object-skew-expected.png: Added.
platform/efl/svg/custom/foreign-object-skew-expected.txt:
platform/efl/svg/custom/simple-text-double-shadow-expected.png: Added.
platform/efl/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:

6:19 AM Changeset in webkit [146459] by rgabor@webkit.org

9 edits in trunk/Source

Implement LLInt for CPU(ARM_TRADITIONAL)
https://bugs.webkit.org/show_bug.cgi?id=97589

Reviewed by Zoltan Herczeg.

Enable LLInt for ARMv5 and ARMv7 traditional as well.

Source/JavaScriptCore:

llint/LLIntOfflineAsmConfig.h:
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
offlineasm/arm.rb:
offlineasm/backends.rb:
offlineasm/instructions.rb:

Source/WTF:

wtf/Platform.h:

6:14 AM Changeset in webkit [146458] by commit-queue@webkit.org

10 edits
2 moves
2 adds in trunk/Source/WebCore

[EFL][WebGL] Implement a common GraphicsSurface Implementation.
https://bugs.webkit.org/show_bug.cgi?id=111759

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This is in preparation to add transport surface support for GLES2.
This patch makes it easy to share the core logic of using
Transport Surface and client on GLX and GLES2 backends without
any code duplication.

PlatformEfl.cmake:
platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::releaseResources):
(WebCore::GraphicsContext3DPrivate::prepareBuffer):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::didResizeCanvas):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):

platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

TransportSurface related code is moved to GraphicsSurfaceCommon.
As GraphicsSurface is deleted on resize, added logic to ensure that
current buffer is not deleted before having the shared buffer
with correct size. This would avoid any flashing during resize.

platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::createTransportSurface):

platform/graphics/opengl/GLPlatformSurface.h:
platform/graphics/surfaces/efl/GLTransportSurface.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp.

(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):
(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::~GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::destroy):
(WebCore::GLTransportSurfaceClient::prepareTexture):
(WebCore::GLTransportSurfaceClient::createTexture):

platform/graphics/surfaces/efl/GLTransportSurface.h: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.h.

(WebCore):
(GLTransportSurface):
(GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::texture):
(WebCore::GLTransportSurfaceClient::hasAlpha):

Moved TransportSurface to EFL folder as this is being used by EFL port only.
Added a base class for TransportSurfaceClient.

platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp: Added.

(WebCore):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::destroy):
(WebCore::GraphicsSurfacePrivate::initializeTransportSurface):
(WebCore::GraphicsSurfacePrivate::makeContextCurrent):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::handle):
(WebCore::GraphicsSurfacePrivate::updateClientBuffer):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::rect):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::textureId):
(WebCore::GraphicsSurfacePrivate::initializeClient):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformSize):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

GraphicsSurface implementation to be shared by both GLX and GLES2.

platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):

platform/graphics/surfaces/egl/EGLSurface.h:

(EGLWindowTransportSurface):

platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore):
(WebCore::resolveGLMethods):
(WebCore::isMesaGLX):
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurfaceClient::GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::~GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::destroy):
(WebCore::GLXTransportSurfaceClient::prepareTexture):

platform/graphics/surfaces/glx/GLXSurface.h:

(GLXTransportSurface):
(GLXTransportSurfaceClient):
(WebCore):
GLXTransportSurfaceClient implementation.

5:58 AM Changeset in webkit [146457] by commit-queue@webkit.org

7 edits
1 delete in trunk

Unreviewed, rolling out r146454.
http://trac.webkit.org/changeset/146454
https://bugs.webkit.org/show_bug.cgi?id=112906

compile failures (Requested by antonm on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-21

Source/WebCore:

WebCore.gypi:
platform/graphics/filters/FEConvolveMatrix.h:

(FEConvolveMatrix):

platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp: Removed.

LayoutTests:

css3/filters/effect-reference-hw.html:
css3/filters/effect-reference.html:
platform/chromium/TestExpectations:

5:49 AM Changeset in webkit [146456] by reed@google.com

2 edits in trunk/Source/WebCore

Remove obsolete conditionals around calling SkTypeface::getUnitsPerEm()
https://bugs.webkit.org/show_bug.cgi?id=112846

Reviewed by Stephen White.

Existing complex-text layouttests exercise this code.

platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::emSizeInFontUnits):

5:28 AM Changeset in webkit [146455] by antonm@chromium.org

39 edits
44 adds
14 deletes in trunk/LayoutTests

2013-03-21 Anton Muhin <antonm@chromium.org>

Unreviewed Chromium gardening.

Mass rebaselining.

fast/repaint/moving-shadow-on-container-expected.txt: Removed.
platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.png: Added.
platform/chromium-linux-x86/platform/chromium/fast: Added.
platform/chromium-linux-x86/platform/chromium/fast/forms: Added.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker: Added.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
platform/chromium-linux-x86/svg/css/composite-shadow-example-expected.txt:
platform/chromium-linux-x86/svg/css/composite-shadow-with-opacity-expected.txt:
platform/chromium-linux-x86/svg/css/shadow-changes-expected.txt: Added.
platform/chromium-linux-x86/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-linux-x86/svg/repaint: Added.
platform/chromium-linux-x86/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-linux/svg/css/composite-shadow-example-expected.png:
platform/chromium-linux/svg/css/composite-shadow-example-expected.txt: Added.
platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.png:
platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/chromium-linux/svg/css/shadow-changes-expected.png:
platform/chromium-linux/svg/css/shadow-changes-expected.txt: Added.
platform/chromium-linux/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-linux/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium-mac-lion/fast/repaint/moving-shadow-on-container-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-mac-lion/svg/css/composite-shadow-example-expected.png:
platform/chromium-mac-lion/svg/css/composite-shadow-example-expected.txt: Added.
platform/chromium-mac-lion/svg/css/composite-shadow-text-expected.png:
platform/chromium-mac-lion/svg/css/composite-shadow-with-opacity-expected.png:
platform/chromium-mac-lion/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/chromium-mac-lion/svg/css/shadow-changes-expected.png:
platform/chromium-mac-lion/svg/css/shadow-changes-expected.txt: Added.
platform/chromium-mac-lion/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-mac-lion/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-mac-snowleopard/svg/css/composite-shadow-example-expected.png:
platform/chromium-mac-snowleopard/svg/css/composite-shadow-example-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/css/composite-shadow-text-expected.png:
platform/chromium-mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png:
platform/chromium-mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/css/shadow-changes-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-mac/svg/css/arrow-with-shadow-expected.png:
platform/chromium-mac/svg/css/composite-shadow-example-expected.png:
platform/chromium-mac/svg/css/composite-shadow-example-expected.txt: Added.
platform/chromium-mac/svg/css/composite-shadow-text-expected.png:
platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.png:
platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/chromium-mac/svg/css/shadow-changes-expected.png:
platform/chromium-mac/svg/css/shadow-changes-expected.txt:
platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-mac/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.png: Added.
platform/chromium-win-xp/svg/css/composite-shadow-example-expected.txt: Added.
platform/chromium-win-xp/svg/css/composite-shadow-text-expected.png:
platform/chromium-win-xp/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/chromium-win-xp/svg/css/shadow-changes-expected.png:
platform/chromium-win-xp/svg/css/shadow-changes-expected.txt: Added.
platform/chromium-win-xp/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-win-xp/svg/repaint: Added.
platform/chromium-win-xp/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-win/svg/css/arrow-with-shadow-expected.png:
platform/chromium-win/svg/css/composite-shadow-example-expected.png:
platform/chromium-win/svg/css/composite-shadow-example-expected.txt: Added.
platform/chromium-win/svg/css/composite-shadow-text-expected.png:
platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png:
platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/chromium-win/svg/css/shadow-changes-expected.png:
platform/chromium-win/svg/css/shadow-changes-expected.txt:
platform/chromium-win/svg/custom/simple-text-double-shadow-expected.txt:
platform/chromium-win/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium/TestExpectations:
platform/chromium/fast/repaint/moving-shadow-on-container-expected.txt: Added.
platform/chromium/svg/css/arrow-with-shadow-expected.txt: Removed.
platform/chromium/svg/css/clippath-with-shadow-expected.txt: Removed.
platform/efl/fast/repaint/moving-shadow-on-container-expected.txt: Added.
platform/gtk/svg/css/arrow-with-shadow-expected.txt: Removed.
platform/gtk/svg/css/clippath-with-shadow-expected.txt: Removed.
platform/gtk/svg/css/composite-shadow-text-expected.png: Removed.
platform/mac/svg/css/arrow-with-shadow-expected.txt: Removed.
platform/mac/svg/css/clippath-with-shadow-expected.txt: Removed.
platform/mac/svg/css/composite-shadow-text-expected.png: Removed.
platform/qt/svg/css/arrow-with-shadow-expected.txt: Removed.
platform/qt/svg/css/clippath-with-shadow-expected.txt: Removed.
platform/qt/svg/repaint/repaint-webkit-svg-shadow-expected.txt: Removed.
svg/css/arrow-with-shadow-expected.txt: Added.
svg/css/clippath-with-shadow-expected.txt: Added.
svg/css/composite-shadow-text-expected.png: Added.

5:16 AM Changeset in webkit [146454] by senorblanco@chromium.org

7 edits
1 add in trunk

[skia] feConvolveMatrix should use accelerated path
https://bugs.webkit.org/show_bug.cgi?id=112828

Reviewed by James Robinson.

Source/WebCore:

Covered by layout tests css3/filters/effect-reference*.html.

WebCore.gypi:

Add FEConvolveMatrixSkia.cpp to the build.

platform/graphics/filters/FEConvolveMatrix.h:

Enable the skia accelerated path for feConvolveMatrix.

platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp:

(WebCore::FEConvolveMatrix::createImageFilter):
Implement building/conversion from FEConvolveMatrix to
SkMatrixConvolutionImageFilter.

LayoutTests:

css3/filters/effect-reference-hw.html:
css3/filters/effect-reference.html:

Add new test case for feConvolveMatrix as a reference filter.

platform/chromium/TestExpectations:

Suppress failures until the test can be rebaselined.

4:54 AM Changeset in webkit [146453] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Refactoring: Reorganize datetime field element parameters
https://bugs.webkit.org/show_bug.cgi?id=112877

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-21
Reviewed by Kent Tamura.

Before this patch, the field element constructors took minimum/maximum
as a pair of integers, and step/stepbase as a DateTimeNumericFieldElement::Parameters.
This patch makes these constructors to take a Range (for minimum/maximum)
and a Step (for step/stepbase).

No new tests. Just refactoring.

html/shadow/DateTimeEditElement.cpp:

(DateTimeEditBuilder): Replaced min/max data members by Ranges.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::shouldAMPMFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled):
(WebCore::DateTimeEditBuilder::createStep):

html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour11FieldElement::create):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour12FieldElement::create):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour23FieldElement::create):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeHour24FieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement):
(WebCore::DateTimeWeekFieldElement::create):

html/shadow/DateTimeFieldElements.h:

(DateTimeDayFieldElement):
(DateTimeHourFieldElementBase):
(DateTimeHour11FieldElement):
(DateTimeHour12FieldElement):
(DateTimeHour23FieldElement):
(DateTimeHour24FieldElement):
(DateTimeMillisecondFieldElement):
(DateTimeMinuteFieldElement):
(DateTimeMonthFieldElement):
(DateTimeSecondFieldElement):
(DateTimeWeekFieldElement):

html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore):
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::roundDown):
(WebCore::DateTimeNumericFieldElement::roundUp):

html/shadow/DateTimeNumericFieldElement.h:

(WebCore::DateTimeNumericFieldElement::Step::Step): Renamed from Parameters.
(WebCore::DateTimeNumericFieldElement::Range::Range):
(WebCore::DateTimeNumericFieldElement::Range::isSingleton): Returns true if the range is a singleton range (i.e. contains exactly one value).
(Range): Now it's parameter type, hence public.
(DateTimeNumericFieldElement): Replaced two int members (m_step and m_stepBase) by a Range.

4:41 AM Changeset in webkit [146452] by commit-queue@webkit.org

5 edits
2 adds in trunk

Web Inspector: Track CSS error location information.
https://bugs.webkit.org/show_bug.cgi?id=111314

Source/WebCore:

Added CSS syntax error reporting to some (other rules will be covered later) error recovery grammar rules.
Added code to CSSParser to allow track error location information.
Added empty rule to declaration_list. Needed to not report error about declarations like "body {}".
Added helper grammar rule "errors: error | errors error". Handles the same grammar as "error" but simplifies error location tracking.

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.

Test: inspector/console/console-css-warnings.html

css/CSSGrammar.y.in:
css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::currentLocation):
(WebCore):
(WebCore::CSSParser::realLex):

css/CSSParser.h:

(CSSParser):

LayoutTests:

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.

inspector/console/console-css-warnings-expected.txt: Added.
inspector/console/console-css-warnings.html: Added.

4:17 AM Changeset in webkit [146451] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Changing "#define YYDEBUG 0" to 1 causing compilation error
https://bugs.webkit.org/show_bug.cgi?id=111178

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.

Code that reference tokens can't be placed into CSSGrammar.yy.include because it's included before tokens defined.
YYDEBUG can't be used in CSSGrammar.yy.in because the #define is only defined in CSSGrammar.yy.include. This
change simplifies CSS debugging letting manipulate only #define YYDEBUG in CSSGrammar.yy.include and/or in CSSParser.cpp.

css/CSSGrammar.y.in:
css/CSSGrammar.y.includes:

3:40 AM Changeset in webkit [146450] by kadam@inf.u-szeged.hu

2 edits
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/TestExpectations: Skip failing tests after r146361 and r146399.
platform/qt/fast/repaint/caret-with-transformation-expected.png: Added after r139282.
platform/qt/fast/repaint/caret-with-transformation-expected.txt: Added after r139282.

2:05 AM Changeset in webkit [146449] by rniwa@webkit.org

13 edits
2 deletes in trunk/Source/WebCore

Merge MainResourceLoader into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=104969

Patch by Nate Chapin <Nate Chapin> on 2013-03-21
Reviewed by Adam Barth.

No new tests, refactor only.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::~DocumentLoader): Move main resource clearing from

~MainResourceLoader.

(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::notifyFinished): Moved from MainResourceLoader::notifyFinished.
(WebCore):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore::DocumentLoader::dataReceived):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::setDefersLoading):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
(WebCore::DocumentLoader::addSubresourceLoader):
(WebCore::DocumentLoader::maybeLoadEmpty):
(WebCore::DocumentLoader::startLoadingMainResource): Don't keep separate checks

for normal and empty loads, just use a single boolean.

loader/DocumentLoader.h:

(WebCore::DocumentLoader::isLoadingMainResource):

loader/MainResourceLoader.cpp: Removed.
loader/MainResourceLoader.h: Removed.
loader/mac/DocumentLoaderMac.cpp:

(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):

1:02 AM Changeset in webkit [146448] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. draw background for the FlameChart overview pane with the CPU aggregated data.
https://bugs.webkit.org/show_bug.cgi?id=112823

Reviewed by Yury Semikhatsky.

The idea of the patch is to collect the data about stack depth for the each X
and draw a line with help of this data.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype._drawOverviewCanvas):
(WebInspector.FlameChart.prototype.update):

12:52 AM Changeset in webkit [146447] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

Tiled page overlay layers don't create tiles until the first flush after they switch to being tiled
https://bugs.webkit.org/show_bug.cgi?id=112860
<rdar://problem/13468400>

Reviewed by Simon Fraser.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea): Add storage for m_clipsToExposedRect.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
The page overlay layer will never have children, so we can use flushCompositingState instead of the ForThisLayerOnly variant.
Pass the visible rect of the page overlay layer (computed by intersecting its bounds with the exposed
rect that comes from the WKView) to flushCompositingState; don't bother setting the visible rect manually.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
Store m_clipsToExposedRect so we can use it in flushLayers.

12:49 AM Changeset in webkit [146446] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.
Adding failure expectation for the test added in r146427.
Removing failure expectations for tests fixed by r146430.

platform/gtk/TestExpectations:

12:42 AM Changeset in webkit [146445] by rniwa@webkit.org

2 edits in trunk/Source/WebKit

Windows build fix after r146430.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

12:42 AM Changeset in webkit [146444] by pkasting@chromium.org

7 edits
1 add
1 delete in trunk/LayoutTests

Correct some apparent problems in previous rebaselines.

Unreviewed, rebaselining.

css2.1/20110323/replaced-elements-001-expected.txt: Added.
platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
platform/chromium-win-xp/css3/flexbox: Removed.
platform/chromium-win/css3/flexbox/button-expected.png:

12:30 AM Changeset in webkit [146443] by rniwa@webkit.org

7 edits in trunk/Tools

EWS bots have stopped uploading results to bugzilla
https://bugs.webkit.org/show_bug.cgi?id=101091

Reviewed by Adam Barth.

The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
this relative file path resoled to a file inside a non-existent directory for "zip".

Fixed the bug by resolving both test results directory and zip archive paths in
LayoutTestResultsReader.archive.

Also made workspace.create_zip print the source_path so that we may debug these issues more easily
in the future.

Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".

Scripts/webkitpy/common/system/workspace.py:

(Workspace.create_zip): Log the source path when "zip" failed.

Scripts/webkitpy/common/system/workspace_mock.py:

(MockWorkspace.create_zip): Record zip_path and source_path for testing.

Scripts/webkitpy/common/system/workspace_unittest.py:

(WorkspaceTest.test_create_zip_exception): Test that.

Scripts/webkitpy/tool/bot/layouttestresultsreader.py:

(LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
This is the actual bug fix.

Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:

(test_archive_last_layout_test_results_with_relative_path): Added a test case.

12:15 AM Changeset in webkit [146442] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Settings] Fix JS compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=112879

Reviewed by Pavel Feldman.

Removed erroneous JSDoc.

inspector/front-end/Settings.js: Removed erroneous JSDoc.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed