Timeline



Jun 1, 2013:

9:42 PM Changeset in webkit [151079] by Chris Fleizach
  • 3 edits
    2 adds in trunk

WebKit ignores aria-hidden when traversing nodes for name calculation
​https://bugs.webkit.org/show_bug.cgi?id=117101

Reviewed by Tim Horton.

Source/WebCore:

When calculating the inner text, aria-hidden should be considered.

Test: accessibility/text-role-with-aria-hidden-inside.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::shouldUseAccessiblityObjectInnerText):

LayoutTests:

  • accessibility/text-role-with-aria-hidden-inside-expected.txt: Added.
  • accessibility/text-role-with-aria-hidden-inside.html: Added.
4:41 PM Changeset in webkit [151078] by jberlin@webkit.org
  • 8 edits in branches/safari-537.43-branch/Source/WebKit2

Merge r151054.

4:31 PM Changeset in webkit [151077] by jberlin@webkit.org
  • 17 edits in branches/safari-537.43-branch/Source/WebKit2

Merge r151043.

4:26 PM Changeset in webkit [151076] by Darin Adler
  • 6 edits in trunk/Source/WebCore

window.speechSynthesis needs to be cheap
​https://bugs.webkit.org/show_bug.cgi?id=117111
rdar://problem/14042030

Reviewed by Dean Jackson.

Add the traditional laziness to all of the speech synthesis code, wherever
it was omitted.

  • Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::create): Tweaked style (took out unneeded parentheses).
(WebCore::SpeechSynthesis::SpeechSynthesis): Don't create m_platformSpeechSynthesizer.
(WebCore::SpeechSynthesis::setPlatformSynthesizer): Clear state when changing the
platform speech synthesizer. Since this code is only used to set up a mock in the
test runner, the fact that it was wrong before was harmless, but still not good.
(WebCore::SpeechSynthesis::getVoices): Create the platform speech synthesizer here
so we can get the voice list from it.
(WebCore::SpeechSynthesis::startSpeakingImmediately): Create the platform speech
synthesizer here.
(WebCore::SpeechSynthesis::cancel): Check the platform speech synthesizer for
null and do nothing if it's not present.
(WebCore::SpeechSynthesis::pause): Ditto.
(WebCore::SpeechSynthesis::resume): Ditto.

  • platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::create): Don't call initializeVoiceList just
to create a synthesizer.
(WebCore::PlatformSpeechSynthesizer::voiceList): Do call initializeVoiceList once
when asked for a voice list.

  • platform/PlatformSpeechSynthesizer.h: The voiceList function is no longer inlined.

The unused setVoiceList function has been removed. The initializeVoiceList is now
private rather than protected. Added a new m_voiceListIsInitialized boolean.

  • platform/mac/PlatformSpeechSynthesizerMac.mm:

(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer): Initialize
m_voiceListIsInitialized to false.

  • platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::create): Don't call initializeVoiceList just
to create a synthesizer.
(WebCore::PlatformSpeechSynthesizerMock::~PlatformSpeechSynthesizerMock):
Removed unneeded call to m_speakingFinishedTimer.stop() since timers automatically
stop when you destroy them.
(WebCore::PlatformSpeechSynthesizerMock::initializeVoiceList): Removed unneeded
call to m_voiceList.clear(), since the caller only calls this once when the
voice list is already clear.

4:09 PM Changeset in webkit [151075] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Add a preferred email address and "expertise" for me.

  • Scripts/webkitpy/common/config/contributors.json:
4:09 PM Changeset in webkit [151074] by jberlin@webkit.org
  • 2 edits in branches/safari-537.43-branch/Tools

Merge r150636.

3:24 PM Changeset in webkit [151073] by fpizlo@apple.com
  • 11 edits in branches/dfgFourthTier/Source/JavaScriptCore

Fix some minor issues in the DFG's profiling of heap accesses
​https://bugs.webkit.org/show_bug.cgi?id=113010

Reviewed by Goeffrey Garen.

Carefully merge r146669 from trunk. This required some fiddling since it
wasn't a clean apply.

Original changelog:

1) If a CodeBlock gets jettisoned by GC, we should count the exit sites.


2) If a CodeBlock clears a structure stub during GC, it should record this, and
the DFG should prefer to not inline that access (i.e. treat it as if it had an
exit site).


3) If a PutById was seen by the baseline JIT, and the JIT attempted to cache it,
but it chose not to, then assume that it will take slow path.


4) If we frequently exited because of a structure check on a weak constant,
don't try to inline that access in the future.


5) Treat all exits that were counted as being frequent.


81% speed-up on Octane/gbemu. Small speed-ups elsewhere, and no regressions.


  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):
(JSC):
(JSC::CodeBlock::resetStubDuringGCInternal):
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::jettison):
(JSC::ProgramCodeBlock::jettisonImpl):
(JSC::EvalCodeBlock::jettisonImpl):
(JSC::FunctionCodeBlock::jettisonImpl):
(JSC::CodeBlock::tallyFrequentExitSites):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::tallyFrequentExitSites):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::StructureStubInfo):
(StructureStubInfo):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGOSRExitBase.cpp:

(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):

  • dfg/DFGOSRExitBase.h:

(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):
(OSRExitBase):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Options.h:

(JSC):

11:02 AM Changeset in webkit [151072] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix typo in r151071.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

3:20 AM Changeset in webkit [151071] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Move Node::hasName() to Element.
<​http://webkit.org/b/117107>

Reviewed by Antti Koivisto.

A Node can't have attributes, and thus can't have a name.
Use a bit on ElementData instead of (half) a Node flag to track whether we have a name.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::ElementData::ElementData):

  • dom/Element.h:

(WebCore::ElementData::hasName):
(WebCore::Element::hasName):

  • dom/Node.h:

(WebCore::Node::isEditingText):

2:48 AM Changeset in webkit [151070] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Remove unnused WebDOMNodeOperationsInternal category.
<​http://webkit.org/b/117105>

Reviewed by Ryosuke Niwa.

_subresourceURLs had no clients.

  • DOM/WebDOMOperations.mm:
2:39 AM Changeset in webkit [151069] by akling@apple.com
  • 8 edits in trunk/Source

Move Node::hasID() and hasClass() to Element.
<​http://webkit.org/b/117104>

Reviewed by Ryosuke Niwa.

Source/WebCore:

A Node can't have attributes, and thus can't have an ID or a class.
Move these to Element instead, and fix up a few call sites that called through on a Node*.

  • dom/Element.h:
  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::namedItem):

  • dom/Node.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::name):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeRenderRegionList):

Source/WebKit/mac:

  • WebView/WebRenderLayer.mm:

(+[WebRenderLayer nameForLayer:]):

May 31, 2013:

11:00 PM Changeset in webkit [151068] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Remove passed accessibility test from EFL WK1.

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
10:41 PM Changeset in webkit [151067] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk/Source

[Curl] Unable to download files.
​https://bugs.webkit.org/show_bug.cgi?id=116150

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-05-31
Reviewed by Brent Fulgham.

Implemented basic download functionality for Curl.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj: Added file.
  • WebCore.vcxproj/WebCore.vcxproj: Added file.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Added file.
  • platform/network/curl/CurlDownload.h: Added.
  • platform/network/curl/CurlDownload.cpp: Added.

Source/WebKit/win:

  • WebDownload.h:
  • WebDownloadCurl.cpp:

(WebDownload::init):
(WebDownload::start):
(WebDownload::cancel):
(WebDownload::deletesFileUponFailure):
(WebDownload::setDeletesFileUponFailure):
(WebDownload::setDestination):
(WebDownload::useCredential):
(WebDownload::didReceiveResponse):
(WebDownload::didReceiveDataOfLength):
(WebDownload::didFinish):
(WebDownload::didFail):

9:21 PM Changeset in webkit [151066] by roger_fong@apple.com
  • 3 edits in trunk/Tools

Unreviewed. Make windows test bots search in the correct directory for build output.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.start):

  • Scripts/webkitdirs.pm:

(determineConfigurationProductDir):

8:54 PM Changeset in webkit [151065] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Windows build fix...

  • BuildSlaveSupport/built-product-archive:

(createZip):

8:34 PM Changeset in webkit [151064] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Windows build fix. One more time!

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):
(extractBuiltProduct):

8:04 PM Changeset in webkit [151063] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Windows build fix.

  • Scripts/build-webkit:
7:59 PM Changeset in webkit [151062] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Add a null checking condition to in hide() of EwkContextMenu
​https://bugs.webkit.org/show_bug.cgi?id=117014

Reviewed by Christophe Dumez.

m_viewImpl is able to be null. So, we need to protect this function against such case.

  • UIProcess/API/efl/ewk_context_menu.cpp:

(EwkContextMenu::hide):
(ewk_context_menu_hide):

  • UIProcess/API/efl/ewk_context_menu_private.h:

(EwkContextMenu):

6:43 PM Changeset in webkit [151061] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Versioning.

6:39 PM Changeset in webkit [151060] by oliver@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix bug in active page tracking that lead to plugins hanging during destruction
​https://bugs.webkit.org/show_bug.cgi?id=117099

Reviewed by Anders Carlsson.

NPRuntimeObjectMap no longer keeps its own reference to the
throttler, and no longer reports activity during destruction.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::evaluate):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):

6:07 PM Changeset in webkit [151059] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Windows build fix.

  • Scripts/build-webkit:
5:45 PM Changeset in webkit [151058] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.6

New Tag.

5:18 PM EfficientStrings edited by rafael.lobo@openbossa.org
This is a summary of what was discussed on "[webkit-dev] When should I … (diff)
5:01 PM Changeset in webkit [151057] by timothy_horton@apple.com
  • 6 edits in trunk/Source/WebKit2

[wk2] All intrinsic content size changes should go through the 0-delay timer
​https://bugs.webkit.org/show_bug.cgi?id=117058
<rdar://problem/13935042>

Reviewed by Anders Carlsson.

In r146913, I added a 0-delay timer so that we'd coalesce intrinsic
content size changes. However, didUpdateGeometry was still immediately
invalidating the intrinsic content size without coalescing.

Move that update to the WebProcess to share the timer.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::didUpdateGeometry):

  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
Remove the newIntrinsicContentSize argument, and don't invalidate intrinsic
content size inside didUpdateGeometry.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Start the intrinsic content size update timer when we finish updateGeometry.

4:47 PM Changeset in webkit [151056] by roger_fong@apple.com
  • 2 edits
    2 deletes in trunk/Tools

Make build-webkit output VCExpress 2010 build logs properly.
​https://bugs.webkit.org/show_bug.cgi?id=117096

Reviewed by Brent Fulgham.

Make it so that output from VCExpress is always printed to console.
Get build log results from AssembleBuildLogs project output.
We don't need those old VCExpress scripts anymore either.

  • Scripts/build-webkit:
  • Scripts/print-msvc-project-dependencies: Removed.
  • Scripts/print-vse-failure-logs: Removed.
4:40 PM Changeset in webkit [151055] by ap@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

Sandbox violations when trying to access fonts in non-standard locations
​https://bugs.webkit.org/show_bug.cgi?id=117097
<rdar://problem/9264746>

Reviewed by Anders Carlsson.

The issue was that lack of a main xib was resulting in font machinery being
initialized too early, before we entered sandbox.

  • Resources/WebContentProcess.xib: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
4:32 PM Changeset in webkit [151054] by jberlin@webkit.org
  • 8 edits in trunk/Source/WebKit2

Need the ability to get the information for a plug-in with a particular process id that may
be running on a page
​https://bugs.webkit.org/show_bug.cgi?id=117090

Rubber-stamped by Anders Carlsson.

Follow-up to r151043 incorprating some feedback I got from Darin after I had already
committed the patch.

  • UIProcess/API/C/mac/WKPagePrivateMac.cpp:

(callGetPlugInInformationBlockAndDispose):
Renamed to be less wordy.
(WKPageGetPlugInInformation):
Ditto.

  • UIProcess/API/C/mac/WKPagePrivateMac.h:

Ditto.

  • UIProcess/Plugins/PluginProcessManager.h:
  • UIProcess/Plugins/mac/PluginProcessManagerMac.mm:

(WebKit::PluginProcessManager::findPlugInProcessByID):
Renamed to not use "Cocoa method style" in non-Cocoa functions.
(WebKit::PluginProcessManager::findPlugInProcessByToken):
Ditto.

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::getPlugInInformation):
Reduce ref count churn and fix a variable name.
Updated for the change to findPlugInProcessByID.
(WebKit::WebPageProxy::containsPlugInCallback):
Updated for the change to findPlugInProcessByToken.

  • WebProcess/Plugins/PDF/SimplePDFPlugin.h:

Move the override of a virtual function to the private section.

4:32 PM Changeset in webkit [151053] by fpizlo@apple.com
  • 14 edits in branches/dfgFourthTier/LayoutTests

fourthTier: convert more fast/js/dfg-* tests to wait for the concurrent JIT

Rubber stamped by Mark Hahnenberg.

  • fast/js/dfg-arguments-alias-one-block-overwrite-expected.txt:
  • fast/js/dfg-arguments-out-of-bounds-expected.txt:
  • fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int-expected.txt:
  • fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers-expected.txt:
  • fast/js/dfg-array-length-dead-expected.txt:
  • fast/js/dfg-array-pop-side-effects-expected.txt:
  • fast/js/resources/js-test-pre.js:

(testFailed):
(dfgIncrement):
(isSuccessfullyParsed):

  • fast/js/script-tests/dfg-arguments-alias-one-block-overwrite.js:
  • fast/js/script-tests/dfg-arguments-out-of-bounds.js:
  • fast/js/script-tests/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js:
  • fast/js/script-tests/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js:
  • fast/js/script-tests/dfg-array-length-dead.js:
  • fast/js/script-tests/dfg-array-pop-side-effects.js:
4:13 PM Changeset in webkit [151052] by fpizlo@apple.com
  • 1 edit in branches/dfgFourthTier/Source/JavaScriptCore/ChangeLog

Fix ChangeLog. That revision was no longer a work in progress.

3:49 PM Changeset in webkit [151051] by Lucas Forschler
  • 9 edits in branches/safari-537.43-branch/Source

Merged r151040. <rdar://problem/14027095>

3:47 PM Changeset in webkit [151050] by Lucas Forschler
  • 9 edits in branches/safari-537.43-branch/Source

Rollout of r151048.

3:32 PM Changeset in webkit [151049] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/14036464> Sandbox violation when using Web SpeechSynthesis

Reviewed by Anders Carlsson

  • WebProcess/com.apple.WebProcess.sb.in: Allow com.apple.speech.synthesis.console.
3:23 PM Changeset in webkit [151048] by Lucas Forschler
  • 9 edits in branches/safari-537.43-branch/Source

Merged r51945. <rdar://problem/14027095>

3:14 PM Changeset in webkit [151047] by Brent Fulgham
  • 3 edits in trunk/Tools

[Windows] Use WinLauncher to display LayoutTest results
​https://bugs.webkit.org/show_bug.cgi?id=117085

Reviewed by Oliver Hunt.

  • Scripts/webkitdirs.pm:

(runSafari): Use WinLauncher to display content

  • WinLauncher/WinLauncher.cpp:

(dllLauncherEntryPoint): Check for URL argument.

3:13 PM Changeset in webkit [151046] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebCore

Merged r151042. <rdar://problem/13812355>

3:08 PM Changeset in webkit [151045] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Incorrect assertion in DFG::Graph::uncheckedActivationRegisterFor()
<rdar://problem/13989324>

Rubber stamped by Mark Hahnenberg.

This has a bogus assertion that checks that the passed CodeOrigin doesn't have
an inline call frame. This was well intentioned in the sense that it is true
that inlined call frames wouldn't have an activation register. But that doesn't
mean that people won't ask. Removing the assertion fixes a debug-only crash and
has no impact on production code. This change adds a comment to that effect.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::uncheckedActivationRegisterFor):

3:01 PM Changeset in webkit [151044] by roger_fong@apple.com
  • 4 edits in trunk

Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
Add it to the WebKit solution as well.

  • win/AssembleBuildLogs/AssembleLogs.cmd:
2:59 PM Changeset in webkit [151043] by jberlin@webkit.org
  • 17 edits in trunk/Source/WebKit2

Need the ability to get the information for a plug-in with a particular process id that may
be running on a page
​https://bugs.webkit.org/show_bug.cgi?id=117090

Reviewed by Anders Carlsson.

  • UIProcess/API/C/mac/WKPagePrivateMac.cpp:

(callGetInformationForPlugInWithProcessIDBlockAndDispose):
Get the block from the context, invoke it with the result, and dispose of it.
(WKPageGetInformationForPlugInWithProcessID):
Ask the WebPageProxy and provide it with a dictionary callback that uses the
above function to invoke the passed in block.

  • UIProcess/API/C/mac/WKPagePrivateMac.h:

Add WKPageGetInformationForPlugInWithProcessID and a typedef for the callback block.

  • UIProcess/Plugins/PluginProcessManager.h:

Add ways to get the PluginProcessProxy associated with a process id or process token.

  • UIProcess/Plugins/mac/PluginProcessManagerMac.mm:

(WebKit::PluginProcessManager::plugInProcessWithProcessID):
Return the first PluginProcessProxy with the passed in process ID.
(WebKit::PluginProcessManager::plugInProcessWithToken):
Return the first PluginProcessProxy with the passed in process token.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
Invalidate any outstanding requests for plug-in information.

  • UIProcess/WebPageProxy.h:

Keep track of the callbacks for the requests for plug-in information.

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::getInformationForPlugInWithProcessID):
If there are no known plug-ins with the provided process ID, invoke the callback with a null
dictionary of plug-in information.
Otherwise, keep track of the callback and send a message to the web process asking for the
information.
(WebKit::WebPageProxy::containsPlugInCallback):
If the page did not contain the plug-in, invoke the callback with a null dictionary of
plug-in information.
Invoke the callback with a dictionary containing the PlugInModuleInfo.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Return 0 for the plugInProcessToken.

  • WebProcess/Plugins/PDF/SimplePDFPlugin.h:

Ditto.

  • WebProcess/Plugins/Plugin.h:

Add a pure virtual method for plugInProcessToken so it can be accessed from from the Plugin
on the PluginView.

  • WebProcess/Plugins/PluginProxy.h:

Return the actual plug-in process token.

  • WebProcess/Plugins/PluginView.h:

(WebKit::PluginView::plugIn):
Make it possible to get at the plug-in process token through the Plugin.

  • WebProcess/WebPage/WebPageMac.mm:

(WebKit::WebPage::containsPluginViewsWithPluginProcessToken):
If there is an instance of the plug-in with that token, send a confirmation to the ui
process.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
2:55 PM Changeset in webkit [151042] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Take the normal NSView code path when drawing into an inclusive layer
​https://bugs.webkit.org/show_bug.cgi?id=117094
<rdar://problem/13812355>

Reviewed by Sam Weinig.

For now, take the normal code path when drawing into an inclusive layer.

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

2:48 PM Changeset in webkit [151041] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier/Source/JavaScriptCore

Remove CodeOrigin::valueProfileOffset since it was only needed for op_call_put_result.

Rubber stamped by Mark Hahnenberg.

  • bytecode/CodeOrigin.h:

(CodeOrigin):
(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isSet):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::currentCodeOrigin):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::valueProfileFor):

2:44 PM Changeset in webkit [151040] by Stephanie Lewis
  • 9 edits in trunk/Source

Source/WebCore: Update low memory handler to use new memory pressure notifications on new OS versions.
<rdar://problem/14027095>

Reviewed by Mark Rowe.

No change in functionality.

  • WebCore.exp.in:
  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::install): Call new API

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac: Update low memory handler to use new memory pressure notifications on new OS versions.
<rdar://problem/14027095>

Reviewed by Mark Rowe.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2: Update low memory handler to use new memory pressure notifications on new OS versions.
<rdar://problem/14027095>

Reviewed by Mark Rowe.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

2:40 PM Changeset in webkit [151039] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

Remove finalDestinationOrIgnored since it isn't called anymore.

Rubber stamped by Mark Hahnenberg.

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

2:37 PM Changeset in webkit [151038] by fpizlo@apple.com
  • 20 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: get rid of op_call_put_result
​https://bugs.webkit.org/show_bug.cgi?id=117047

Reviewed by Gavin Barraclough.

Work in progress. This still makes like 20 tests crash.

op_call_put_result is an oddball. Its semantics are that it takes the return
value of a call instruction, which is set aside in regT0/regT1, and places them
into some stack slot. This is weird since there is an implicit contract with the
preceding bytecode instruction, and it's even weirder since it means that it
doesn't make sense to jump to it; for example OSR exit from the preceding call
instruction must make sure to jump over the op_call_put_result.

So this patch gets rid of op_call_put_result:

  • In bytecode, all calls return a value and we always allocate a temporary for that value even if it isn't used.


  • The LLInt does the return value saving as part of dispatchAfterCall().


  • The JIT and DFG do the return value saving as part of normal code generation. The DFG already did the right thing.


  • DFG->JIT OSR exit in the case of inlining will make the return PC's point at the CallLinkInfo::callReturnLocation, rather than the machine PC associated with the op_call_put_result instruction.


  • Tons of code gets removed. The DFG had to track whether or not a call had a return value in a bunch of places. It had to track the fact that we would exit to after the op_call_put_result. It was a mess. That mess is now gone.
  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::dumpArrayProfiling):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:
  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/NodesCodegen.cpp:

(JSC::NewExprNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:

(JIT):

  • jit/JITCall.cpp:

(JSC::JIT::emitPutCallResult):
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::emit_op_call):
(JSC):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emit_op_construct):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct):

  • jit/JITCall32_64.cpp:

(JSC::JIT::emitPutCallResult):
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOpcodes.cpp:

(JSC):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::genericCall):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
1:44 PM Changeset in webkit [151037] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Update Button UX.
​https://bugs.webkit.org/show_bug.cgi?id=116992

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-05-31
Reviewed by Rob Buis.

BlackBerry PR 342298.
Internally Review by Jeff Rogers.

  • css/themeBlackBerry.css:
1:27 PM Changeset in webkit [151036] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

DerivedSources.make: any rules that use $(FEATURE_DEFINES) should be rebuilt when FeatureDefines.xcconfig changes
<​http://webkit.org/b/117081>

Reviewed by Mark Rowe.

  • DerivedSources.make: Add $(PLATFORM_FEATURE_DEFINES)

dependency for all rules that use $(FEATURE_DEFINES) to generate
files.
(PLATFORM_FEATURE_DEFINES): Set this variable to
Configurations/FeatureDefines.xcconfig if not already set on
Mac OS X.

1:16 PM Changeset in webkit [151035] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r141445): MPEG-4 videos do not play on certain hardware configurations
​https://bugs.webkit.org/show_bug.cgi?id=117089
<rdar://problem/13839717>

Reviewed by Mark Rowe.

  • Configurations/WebContentProcess.xcconfig: Statically link to a framework that uses an XPC service to work around a libxpc limitation on Lion.
12:08 PM Changeset in webkit [151034] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Text Field UX updates.
​https://bugs.webkit.org/show_bug.cgi?id=116996

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-05-31
Reviewed by Rob Buis.

BlackBerry PR 342333.
Internally Reviewed by Jeff Rogers.

Update disabled text field font color.

  • css/themeBlackBerry.css:
11:22 AM Changeset in webkit [151033] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Fix Overflow case of branchMul32 in baseline JIT.
​https://bugs.webkit.org/show_bug.cgi?id=117057

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.

Current implementation of Overflow case in branchMul32 performs an
unsigned multiplication whereas a signed multiplication is expected.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchMul32):

11:22 AM Changeset in webkit [151032] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Fix floating point comparisons in baseline JIT.
​https://bugs.webkit.org/show_bug.cgi?id=117066.

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.

Current implementation of branchDouble function in baseline JIT is wrong
for some conditions and overkill for others. For instance:

  • With DoubleGreaterThanOrEqual condition, branch will be taken if either operand is NaN with current implementation whereras it should not.
  • With DoubleNotEqualOrUnordered condition, performed NaN checks are useless (because comparison result is false if either operand is NaN).
  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchDouble):

11:21 AM Changeset in webkit [151031] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[sh4] Fix double floating point transfer in baseline JIT.
​https://bugs.webkit.org/show_bug.cgi?id=117054

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.

In current implementation, dmovRegReg function transfers only one single
FPRegister as PR=1 and SZ=0 in floating point status/control register.
Double transfers must be performed with two fmov.s opcodes.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::moveDouble):
(JSC::MacroAssemblerSH4::addDouble): Handle (op2==dest) case properly.
(JSC::MacroAssemblerSH4::sqrtDouble):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::fmovsRegReg):

11:19 AM Changeset in webkit [151030] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Handle branchType properly in branchTruncateDoubleToInt32.
​https://bugs.webkit.org/show_bug.cgi?id=117062

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.

Current implementation of branchTruncateDoubleToInt32 is incorrect
when branchType == BranchIfTruncateSuccessful in sh4 baseline JIT.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32):

10:45 AM Changeset in webkit [151029] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Update CheckedInt.h to latest version from Mozilla
​https://bugs.webkit.org/show_bug.cgi?id=117009

Reviewed by Darin Adler.

Mozilla have updated their version of CheckedInt and suggested
we sync. Here are the improvements:

  • CheckedInt now consistently rejects unsupported types. Before, you

could sometimes construct a CheckedInt from an unsupported type (like,
float) or multiply a CheckedInt by a float, and have it not caught! See
​https://bugzilla.mozilla.org/show_bug.cgi?id=869194

  • Fixed a possibility of undefined behavior in unary operator-. See bug

​https://bugzilla.mozilla.org/show_bug.cgi?id=849666

  • CheckedInt now supports the "long long" and "unsigned long long"

types. We don't like "long long" (and neither does the Google C++ style
guide!) but we had to do that because libogg exposes typedefs to those
types. See Bug ​https://bugzilla.mozilla.org/show_bug.cgi?id=869685

  • CheckedInt also now supports "signed char" in addition to "char" ---

they are not the same type! See Bug ​https://bugzilla.mozilla.org/show_bug.cgi?id=847521

  • Fixed and simplified usage of CheckedInt outside of Mozilla. You'll

like this one! See Bug ​https://bugzilla.mozilla.org/show_bug.cgi?id=849667

  • html/canvas/CheckedInt.h: Updated.
10:29 AM Changeset in webkit [151028] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r151026. <rdar://problem/14030364>

10:27 AM Changeset in webkit [151027] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebCore

Merged r150836. <rdar://problem/13925131>

10:04 AM Changeset in webkit [151026] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Don't create an accelerated compositing layer unless we have to for snapshotting plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=117076
<rdar://problem/14030364>

Reviewed by Beth Dakin and Anders Carlsson.

If a plug-in can support software snapshotting, then don't create an
accelerated compositing layer for it while in snapshot mode. This is a
better user experience -- otherwise the page/plug-in looks like it broke.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::isAcceleratedCompositingEnabled): If we are in snapshotting mode
and we are a Flash plugin (the only one that supports software snapshots at the moment)
then do not create an accelerated compositing layer.

10:02 AM Changeset in webkit [151025] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed build fix for VS2005 builders.

missing export for WTF::SHA1::computeHexDigest

9:57 AM Changeset in webkit [151024] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r151022.
​http://trac.webkit.org/changeset/151022
​https://bugs.webkit.org/show_bug.cgi?id=117084

Also breaks build by introducing duplicate symbols (Requested
by bfulgham on #webkit).

  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
9:54 AM WebKitGTK/2.0.x edited by kalevlember@gmail.com
Link to changesets instead of bugzilla, for two issues where fixes … (diff)
9:45 AM Changeset in webkit [151023] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed build fix to NRWT

  • Scripts/webkitpy/port/win.py:

(WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.

9:31 AM Changeset in webkit [151022] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed build fix after r151012

  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on

WTF library to support SHA tests

9:17 AM Changeset in webkit [151021] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make sure gstreamer source element is thread-safe
​https://bugs.webkit.org/show_bug.cgi?id=115352

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-05-31
Reviewed by Philippe Normand.

GStreamer source element may be created by any gstreamer element on any thread by calling
gst_element_make_from_uri with the URIs handled by the source element.
This patch makes sure the gstreamer source element is thread-safe to avoid issues with it
being created outside the main thread.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(_WebKitWebSrcPrivate):
(webkit_web_src_init):
(webKitWebSrcFinalize):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetMediaPlayer):
(StreamingClient::StreamingClient):
(StreamingClient::~StreamingClient):
(StreamingClient::didReceiveResponse):
(StreamingClient::didReceiveData):
(StreamingClient::didFinishLoading):
(StreamingClient::wasBlocked):
(StreamingClient::cannotShowURL):

9:16 AM Changeset in webkit [151020] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WTF

Fix double hash lookup in PageMapMemoryUsageRecorder::visit
​https://bugs.webkit.org/show_bug.cgi?id=117071

Reviewed by Andreas Kling.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

9:14 AM Changeset in webkit [151019] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed build fix after r151012

  • TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide

snprintf definition for Windows.

9:01 AM Changeset in webkit [151018] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Windows] Speculative build fix for pre-VS2010 compilers

  • wtf/Platform.h: Only treat WTF as DLL for VS2010 builds
8:53 AM Changeset in webkit [151017] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Update test-expectations after r151000.

  • fast/js/date-DST-time-cusps-expected.txt:
8:52 AM Changeset in webkit [151016] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix when CSSParser debugging is enabled
​https://bugs.webkit.org/show_bug.cgi?id=117075

Reviewed by Andreas Kling.

Build fails when enabling parser debugging by setting YYDEBUG to
1 because of a missing include.

  • css/CSSGrammar.y.includes:
8:21 AM Changeset in webkit [151015] by eustas@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Newly added editing/selection/caret-after-keypress.html crashing
​https://bugs.webkit.org/show_bug.cgi?id=117070

Unreviewed test expectations update.

WebKitTestRunner needs a more-complete implementation of eventSender.
Until then caret-after-keypress test is disabled

See ​https://bugs.webkit.org/show_bug.cgi?id=42194

  • platform/qt-5.0-wk2/TestExpectations:
6:29 AM Changeset in webkit [151014] by zarvai@inf.u-szeged.hu
  • 3 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk1/TestExpectations: Skip flaky test.
  • platform/qt-5.0-wk2/TestExpectations: Skip crashing test.
  • platform/qt/fast/js/date-DST-time-cusps-expected.txt: Rebaselining after r151000.
3:25 AM Changeset in webkit [151013] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Soup] [Gstreamer] ASSERT in StreamingClient::getOrCreateReadBuffer
​https://bugs.webkit.org/show_bug.cgi?id=116686

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-31
Reviewed by Carlos Garcia Campos.

We were using g_input_stream_read_async() to handle redirections
because of Gnome bug #691489.

This produces an unexpected read attempt which triggers an assert
in StreamingClient::getOrCreateReadBuffer().

Now that the Gnome bug is fixed we can replace read_async() with
skip_async().

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::ensureReadBuffer):
(WebCore::redirectSkipCallback):
(WebCore::sendRequestCallback):

3:06 AM Changeset in webkit [151012] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
​https://bugs.webkit.org/show_bug.cgi?id=116445

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2013-05-31
Reviewed by Benjamin Poulain.

Source/WTF:

Remove the MD5 and SHA1 test cases from the WTF code. The same cases are now built and run under TestWebKitAPI.

  • wtf/MD5.cpp:

(WTF::MD5::MD5):

  • wtf/SHA1.cpp:

(WTF::SHA1::SHA1):

Tools:

Add the MD5 and SHA1 unit tests that were previously located inside WTF.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/MD5.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::expectMD5):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::expectSHA1):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/WTF.pro:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
1:58 AM Changeset in webkit [151011] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Update EFL TextExpectation for WebAudio cases.
​https://bugs.webkit.org/show_bug.cgi?id=117061.

Unreviewed EFL Gardening.

WebAudio test cases delaynode-max-nondefault-delay.html, delaynode-scheduling.html
and javascriptaudionode.html pass with latest updates in efl port. Updating
TestExpectation accordingly.

Patch by Praveen R Jadhav <​praveen.j@samsung.com> on 2013-05-31

  • platform/efl/TestExpectations:
12:15 AM Changeset in webkit [151010] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[Mac] Should pass http/tests/images/png-partial-load-no-alpha.html
​https://bugs.webkit.org/show_bug.cgi?id=97170

Unreviewed test expectations update.

  • platform/mac/TestExpectations: Passing after r150340: remove the

Mac-specfic [ImageOnlyFailure] for this test.

May 30, 2013:

10:14 PM Changeset in webkit [151009] by eustas@chromium.org
  • 4 edits
    2 adds in trunk

selectionStart/selectionEnd return "obsolete" values when requested during "input" event
​https://bugs.webkit.org/show_bug.cgi?id=110742

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch defers firing "webkitEditableContentChanged" until new
selection is applied to control. This makes selection during "input"
more consistent and reliable.

Background: "input" event is fired by "webkitEditableContentChanged"
dispatcher. But "input" is scoped event, so under some conditions its
dispatching may be deferred. When "input" dispatching is deferred,
dispatcher observes updated selectionStart and selectionEnd.
Otherwise values repersent state before applying editing command.

So, to make selectionStart/End to be more predictable and useful, we
need either always dispatch "input" before selection is updated, or
always dispatch "input" after selection is updated.

As it was mentioned, dispatching could be deferred by scoping. So
dispatching before updating selection couldn't be guaranteed.
Moreover, it will be hard to calculate updated selection in user
code. On the other side - old selection could be easily tracked.

So, it looks logically that we should guarantee dispatching "input"
after updating selection. There are no execution paths in
"webkitEditableContentChanged" dispatched that depends on current
selection. So it is safe to fire this event after selection is updated.

Test: editing/selection/caret-after-keypress.html

  • editing/Editor.cpp:

Dispatch "input" event after new selection in applied.

LayoutTests:

Test that cursor is up-to-date during "input" event.

  • editing/selection/caret-after-keypress-expected.txt: Added.
  • editing/selection/caret-after-keypress.html: Added.
  • platform/mac-wk2/TestExpectations: Exclude new test.
9:53 PM Changeset in webkit [151008] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Versioning.

9:51 PM Changeset in webkit [151007] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.5

New Tag.

9:32 PM Changeset in webkit [151006] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/LayoutTests

Unreviewed, EFL gardening.

Some of tests in printing are passing on EFL WK2. But, they are still failing on EFL WK1.

  • platform/efl/TestExpectations:
8:59 PM Changeset in webkit [151005] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed build correction.

  • Scripts/webkitpy/port/win.py:

(WinPort.create_debugger_command_file): The directory needs to be
a string, not a temporary directory object.

8:31 PM Changeset in webkit [151004] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] NRWT doesn't save crash logs on Apple's Windows port.
​https://bugs.webkit.org/show_bug.cgi?id=76935

Reviewed by Ryosuke Niwa.

Extend the WinPort class with commands to set and clean up various registry
values needed to invoke the correct debugger to get crash files.

  • Scripts/webkitpy/port/win.py:

(WinPort): Added global caches for registry keys and settings
(WinPort._ntsd_location): Added
(WinPort.create_debugger_command_file): Added
(WinPort.read_registry_string): Added
(WinPort.write_registry_string): Added
(WinPort.setup_crash_log_saving): Added
(WinPort.restore_crash_log_saving): Added
(WinPort.setup_test_run): Added overload to add registry settings.
(WinPort.clean_up_test_run): Added overload to clean up registry settings.

7:32 PM Changeset in webkit [151003] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

WebKit's Enter Full Screen for <video> elements isn't working
​https://bugs.webkit.org/show_bug.cgi?id=117001

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-05-30
Reviewed by Jer Noble.

Fix workflow to allow a video to enter into full screen
mode from a kWKContextMenuItemTagEnterVideoFullscreen
context menu item by denoting the enterFullscreenForVideo
call as a user gesture, so Document::requestFullScreenForElement
will execute correctly.

No new tests. Covered by media/context-menu-actions.html,
which is disabled due to bug #116651.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::enterFullscreenForVideo):

7:30 PM Changeset in webkit [151002] by Lucas Forschler
  • 24 edits
    2 deletes in branches/safari-537.43-branch/Source

Rollout of r150981. <rdar://problem/13785764>

7:05 PM Changeset in webkit [151001] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

It's easy to hit ASSERT_NOT_REACHED in WKDOMNodeClass
​https://bugs.webkit.org/show_bug.cgi?id=117051

Reviewed by Anders Carlsson.

Re-add the ASSERT_NOT_REACHED, and return [WKDOMNode class] in the case
where we don't have a specific subclass.

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:

(WebKit::WKDOMNodeClass):

6:52 PM Changeset in webkit [151000] by barraclough@apple.com
  • 3 edits in trunk/LayoutTests

fast/js/date-DST-time-cusps.html fails after ​http://trac.webkit.org/changeset/150833
​https://bugs.webkit.org/show_bug.cgi?id=116895
<rdar://problem/4777813> Safari incorrectly handles times that shouldn't exist
​https://bugs.webkit.org/show_bug.cgi?id=11157

Reviewed by Alexey Proskuryakov.

Accidental progression, updating results to expect success.

  • TestExpectations:
    • Remove expectations of failure.
  • fast/js/script-tests/date-DST-time-cusps.js:
    • Prefer the latter option for non-existent time (due to clock rolling forward).
6:52 PM Changeset in webkit [150999] by roger_fong@apple.com
  • 2 edits in trunk/Source/WTF

Another unreviewed speculative build fix for Mac.

  • wtf/text/WTFString.h:

(WTF::String::fromUTF8WithLatin1Fallback):

6:46 PM Changeset in webkit [150998] by dfarler@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix jscore-test when not using --sdk option with jsDriver.pl
​https://bugs.webkit.org/show_bug.cgi?id=116339

Reviewed by Joe Pecoraro.

  • tests/mozilla/jsDriver.pl:

(execute_tests):
With each test, the shell_command needs to be started from scratch.

This fix will clear the shell_command and start over as before with
the opt_arch option when not using --sdk with jsDriver.pl.

6:09 PM WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
6:07 PM Changeset in webkit [150997] by roger_fong@apple.com
  • 3 edits in trunk/Source/WTF

Unreviewed build fix for Mac.

  • wtf/OSAllocator.h:
  • wtf/text/WTFString.h:

(WTF::String::fromUTF8):

5:53 PM Changeset in webkit [150996] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WebCore

Fix double hash lookup in RenderTableSection::paintObject loop
​https://bugs.webkit.org/show_bug.cgi?id=117055

Reviewed by Antonio Gomes.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintObject):

5:38 PM Changeset in webkit [150995] by roger_fong@apple.com
  • 35 edits
    1 delete in trunk

Get rid of JavaScript exports file on AppleWin port.
​https://bugs.webkit.org/show_bug.cgi?id=117050.

Reviewed by Darin Adler.

This requires turning WTF into a shared library and adding the WTF_EXPORT_PRIVATE to some methods where it was missed.
Start linking in WTF.lib now that it's a shared library.
Also, delete the JavaScriptCoreExportGenerator folder and remove dependencies.

  • JavaScriptCore.vcxproj/JavaScriptCore.submit.sln:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorBuildCmd.cmd: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorDebug.props: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPreBuild.cmd: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorProduction.props: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorRelease.props: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/make-export-file-generator: Removed.
  • JavaScriptCore.vcxproj/jsc/jscCommon.props:
  • JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
  • JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.filters:
  • JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props:
  • JavaScriptCore.vcxproj/testapi/testapiCommon.props:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTFCommon.props:
  • wtf/DateMath.h:
  • wtf/ExportMacros.h:
  • wtf/FilePrintStream.h:
  • wtf/OSAllocator.h:
  • wtf/PageAllocationAligned.h:
  • wtf/Platform.h:
  • wtf/PrintStream.h:
  • wtf/StackBounds.h:
  • wtf/StringPrintStream.h:
  • wtf/ThreadSpecific.h:
  • wtf/WTFThreadData.h:
  • wtf/dtoa/cached-powers.h:
  • wtf/dtoa/double-conversion.h:
  • wtf/text/WTFString.h:
  • wtf/unicode/Collator.h:
  • wtf/unicode/UTF8.h:
  • WebKit.vcxproj/WebKit.sln:
  • WebKit.vcxproj/WebKit/WebKitCommon.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
5:16 PM Changeset in webkit [150994] by dfarler@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add --sdk option to jsDriver.pl to run with iOS Simulator
​https://bugs.webkit.org/show_bug.cgi?id=116339

Reviewed by David Kilzer.

  • tests/mozilla/jsDriver.pl:

(execute_tests):
Prefix shell command with the path to the "sim" tool.
(parse_args):
Add -d / --sdk option.
(usage):
Help message for -d / --sdk option.

4:29 PM Changeset in webkit [150993] by fpizlo@apple.com
  • 11 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: LLInt shouldn't store an offset call PC during op_call-like calls
​https://bugs.webkit.org/show_bug.cgi?id=117048

Reviewed by Mark Hahnenberg.

This just makes everything consistent in the LLInt: anytime any op calls out,
it stores its PC and never the next op's PC.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::bytecodeOffset):

  • bytecode/CodeBlock.h:
  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCallVarargs):

  • llint/LLIntExceptions.cpp:

(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
4:21 PM Changeset in webkit [150992] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Optimize NaN checks in LLINT for floating point comparisons.
​https://bugs.webkit.org/show_bug.cgi?id=117049

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-05-30
Reviewed by Oliver Hunt.

Use the fcmp/eq opcode in sh4 LLINT to test if a double is NaN.
This is more efficient, doesn't require two tmp registers and requires
less code than current implementation (which converts double to float,
then checks 'E = Emax + 1' and 'f != 0').

  • offlineasm/sh4.rb:
4:15 PM WebKitGTK/2.0.x edited by kov@webkit.org
as translation update (diff)
4:15 PM Changeset in webkit [150991] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WebCore

Fix double hash lookup in WebSocket::connect loop
​https://bugs.webkit.org/show_bug.cgi?id=117052

Reviewed by Anders Carlsson.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

3:58 PM Changeset in webkit [150990] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSCallbackObject does not correctly initialise the PropertySlot for getOwnPropertyDescriptor
​https://bugs.webkit.org/show_bug.cgi?id=117053

Reviewed by Mark Hahnenberg.

Set appropriate thisValue on the PropertySlot

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyDescriptor):

  • API/tests/testapi.mm:
3:55 PM Changeset in webkit [150989] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove ASSERT_NOT_REACHED from WKDOMNodeClass
​https://bugs.webkit.org/show_bug.cgi?id=117051

Reviewed by Anders Carlsson.

It's easy to fail this assertion in seemingly-legitimate cases.

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:

(WebKit::WKDOMNodeClass):

3:47 PM Changeset in webkit [150988] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK] Updated as-IN translations
​https://bugs.webkit.org/show_bug.cgi?id=116953

Patch by Nilamdyuti Goswami <​ngoswami@redhat.com> on 2013-05-30
Reviewed by Gustavo Noronha Silva (kov).

  • as.po: Updated.
2:31 PM Changeset in webkit [150987] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

fast/dom/location-new-window-no-crash.html times out flakily on mac-wk2
​https://bugs.webkit.org/show_bug.cgi?id=117037

Reviewed by Alexey Proskuryakov.

Close the window on a zero-delay timer, working around a bug where WKTR
will hang if a window is closed while a load is in progress.

Doesn't affect the test in an important way.

  • fast/dom/script-tests/location-new-window-no-crash.js:
2:18 PM Changeset in webkit [150986] by Lucas Forschler
  • 5 edits in branches/safari-537.43-branch/Source/WebCore

Merged r150977. <rdar://problem/13916291>

2:15 PM Changeset in webkit [150985] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove some 16bits conversion.
​https://bugs.webkit.org/show_bug.cgi?id=116935

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-05-30
Reviewed by Darin Adler.

Merge chromium ce35a544d09e6cb907457535340eb0e9984e57b8.
​https://chromium.googlesource.com/chromium/blink/+/ce35a544d09e6cb907457535340eb0e9984e57b8

  • html/parser/InputStreamPreprocessor.h:
  • platform/FileSystem.cpp:

(WebCore::encodeForFileName):

2:11 PM Changeset in webkit [150984] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Rollout of r150819. <rdar://problem/14025590>

2:08 PM Changeset in webkit [150983] by Lucas Forschler
  • 12 edits in branches/safari-537.43-branch/Source

Merged r150950. <rdar://problem/13992853>

2:03 PM Changeset in webkit [150982] by Lucas Forschler
  • 6 edits in branches/safari-537.43-branch/Source

Merged r150948. <rdar://problem/13886753>

2:00 PM Changeset in webkit [150981] by Lucas Forschler
  • 24 edits
    2 copies in branches/safari-537.43-branch/Source

Merged r150935. <rdar://problem/13785764>

1:55 PM Changeset in webkit [150980] by Lucas Forschler
  • 3 edits in branches/safari-537.43-branch/Source/JavaScriptCore

Merged r150831. <rdar://problem/14004998>

1:53 PM Changeset in webkit [150979] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r150925. <rdar://problem/13976781>

1:51 PM Changeset in webkit [150978] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r150648. <rdar://problem/13976781>

1:50 PM Changeset in webkit [150977] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

REGRESSION (r119759): Adobe Flash Player "smaller" installer relies on the incorrect firing of a load event and needs an app-specific hack for compatibility
​https://bugs.webkit.org/show_bug.cgi?id=117042
<rdar://problem/13916291>

Reviewed by Mark Rowe.

Ignore HTTP errors for scripts requested from within the installer. Instead of just checking for the
Adobe Flash installer, we use the "com.solidstatenetworks.awkhost" bundle identifier to determine
whether to apply the workaround. This could in theory fix other installers that use the same mechanism.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::shouldIgnoreHTTPStatusCodeErrors):

  • loader/cache/CachedScript.h:
  • platform/RuntimeApplicationChecks.cpp:

(WebCore::applicationIsSolidStateNetworksDownloader):

  • platform/RuntimeApplicationChecks.h:
1:39 PM Changeset in webkit [150976] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Fix pass_by_value coverity warning in ChromeClientGtk
​https://bugs.webkit.org/show_bug.cgi?id=117021

Patch by Enrique Ocana Gonzalez <​eocanha@igalia.com> on 2013-05-30
Reviewed by Anders Carlsson.

Pass dirtyRegion parameter in paintWebView() by reference to avoid object copying.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::paintWebView):

12:21 PM Changeset in webkit [150975] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Versioning.

12:18 PM Changeset in webkit [150974] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.4

New Tag.

11:34 AM Changeset in webkit [150973] by zandobersek@gmail.com
  • 14 edits
    12 adds in trunk/LayoutTests

Update XMLHttpRequest timeout tests to a newer version from W3C
​https://bugs.webkit.org/show_bug.cgi?id=117023

Reviewed by Alexey Proskuryakov.

The XMLHttpRequest Timeout tests have gone through a bit of restructuring and should
be updated. This is being primarily done because of the intention of updating the
testharness scripts which would break these tests if they were left not updated.

These tests were updated from the W3C web-platform-tests GitHub repository.
​https://github.com/w3c/web-platform-tests

  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-runner.js:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconworker.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overrides-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overrides.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout.js:

(RequestTracker.prototype.startXHR):
(AbortedRequest.prototype.startXHR.handleEvent):
(runTestRequests):

11:20 AM Changeset in webkit [150972] by sergio@webkit.org
  • 6 edits in trunk

Allow no space between "background-position:" dimensions
​https://bugs.webkit.org/show_bug.cgi?id=116870

Reviewed by Darin Adler.

From Blink r149314 by <​ericwilligers@chromium.org>

Source/WebCore:

Specs allow no spaces between the dimensions of a
"background-position:" like "1px+1px", we should support
that.

Whitespaces are no longer early consumed, dramatically dropping
the shift/reduce conflicts to half. The productions unary_term,
calc_func_term, calc_func_expr and calc_func_paren_expr no longer
consume whitespaces.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::realLex):

LayoutTests:

  • fast/backgrounds/background-position-parsing-2-expected.txt:
  • fast/backgrounds/background-position-parsing-2.html:
11:19 AM Changeset in webkit [150971] by jer.noble@apple.com
  • 14 edits
    2 copies in trunk/Source/WebCore

HTMLMediaElement will not unthrottle page when playback stops for nreasons other than user-initiated pause.
​https://bugs.webkit.org/show_bug.cgi?id=117016

Reviewed by Oliver Hunt.

Add a new class PageActivityAssertionToken to allow HTMLMediaElement to decouple
knowledge of and control over the lifetime of PageThrottler. The new class will
have weak references to and from the PageThrottler so that holders of the token
will not need to care if the Page or PageThrottler has been destroyed.

HTMLMediaElement will create one of these PageActivityAssertionTokens when playback
begins and destroy it when playback stops for any reason, or when the element is
destroyed.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::updatePlayState):

  • html/HTMLMediaElement.h:
  • page/Page.cpp:

(WebCore::createActivityToken): Added simple factory method.

  • page/Page.h:
  • page/PageActivityAssertionToken.cpp:

(WebCore::PageActivityAssertionToken::PageActivityAssertionToken): Call addActivityToken();
(WebCore::PageActivityAssertionToken::~PageActivityAssertionToken): Call removeActivityToken();
(WebCore::PageActivityAssertionToken::invalidate): Clear m_throttler.

  • page/PageActivityAssertionToken.h:
  • page/PageThrottler.cpp:

(WebCore::PageThrottler::~PageThrottler): Invalidate all outstanding tokens.
(WebCore::PageThrottler::addActivityToken): Bump the activity count.
(WebCore::PageThrottler::removeActivityToken): Lower the activity count.

  • page/PageThrottler.h:

Add the new files to the various build systems:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
10:52 AM Changeset in webkit [150970] by jpfau@apple.com
  • 12 edits in trunk

[Mac] Enable cache partitioning and the public suffix list on 10.8
<rdar://problem/13679019>

Rubber-stamped by David Kilzer.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
10:09 AM Changeset in webkit [150969] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix double hash lookup in DocumentEventQueue::cancelEvent().
<​http://webkit.org/b/117031>

Reviewed by Anders Carlsson.

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::cancelEvent):

10:06 AM Changeset in webkit [150968] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix double hash lookup in WebPage::determinePrimarySnapshottedPlugIn() loop.
<​http://webkit.org/b/117032>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

10:05 AM Changeset in webkit [150967] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix double hash lookup in DocumentLoader::removeSubresourceLoader().
<​http://webkit.org/b/117030>

Reviewed by Anders Carlsson.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::removeSubresourceLoader):

10:03 AM Changeset in webkit [150966] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix double hash lookup in RenderView::repaintSelection() loop.
<​http://webkit.org/b/117029>

Reviewed by Anders Carlsson.

  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintSelection):

9:44 AM Changeset in webkit [150965] by zarvai@inf.u-szeged.hu
  • 4 edits
    5 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk1/TestExpectations: Skip new failures after r150868.
  • platform/qt-5.0-wk2/TestExpectations: re-skip still failing tests after r150892.
  • platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Rebaselining after r150798.
  • platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
  • platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
  • platform/qt/TestExpectations: Skip new failre after r150853.
8:12 AM Changeset in webkit [150964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CURL: Incorrect stripping of query from file URL
​https://bugs.webkit.org/show_bug.cgi?id=104307

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2013-05-30
Reviewed by Darin Adler.

Clear the query part of the file URL if there is any.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle):

7:55 AM Changeset in webkit [150963] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Needs to check for harfbuzz-icu
​https://bugs.webkit.org/show_bug.cgi?id=116978

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-30
Reviewed by Xan Lopez.

HarfBuzz 0.9.18 splits harbuzz-icu into a separate library so we
also need to check for it in order to get the necessary flags for
the compiler and the linker.

We keep this conditional for now since we still want to support
earlier versions of HarfBuzz.

  • Source/autotools/FindDependencies.m4:
7:26 AM Changeset in webkit [150962] by Antti Koivisto
  • 10 edits
    2 adds in trunk/Source/WebCore

Separate generic font family settings to a class
​https://bugs.webkit.org/show_bug.cgi?id=117027

Reviewed by Andreas Kling.

The new class is under platform/ and can be accessed by the font code directly without platform violations.

  • WebCore.xcodeproj/project.pbxproj:
  • page/Settings.cpp:

(WebCore::invalidateAfterGenericFamilyChange):
(WebCore::Settings::Settings):
(WebCore::Settings::~Settings):
(WebCore::Settings::create):
(WebCore::Settings::standardFontFamily):
(WebCore::Settings::setStandardFontFamily):
(WebCore::Settings::fixedFontFamily):
(WebCore::Settings::setFixedFontFamily):
(WebCore::Settings::serifFontFamily):
(WebCore::Settings::setSerifFontFamily):
(WebCore::Settings::sansSerifFontFamily):
(WebCore::Settings::setSansSerifFontFamily):
(WebCore::Settings::cursiveFontFamily):
(WebCore::Settings::setCursiveFontFamily):
(WebCore::Settings::fantasyFontFamily):
(WebCore::Settings::setFantasyFontFamily):
(WebCore::Settings::pictographFontFamily):
(WebCore::Settings::setPictographFontFamily):

  • page/Settings.h:
  • platform/graphics/FontGenericFamilies.cpp: Added.

(WebCore::setGenericFontFamilyForScript):
(WebCore::genericFontFamilyForScript):
(WebCore::FontGenericFamilies::FontGenericFamilies):
(WebCore::FontGenericFamilies::standardFontFamily):
(WebCore::FontGenericFamilies::fixedFontFamily):
(WebCore::FontGenericFamilies::serifFontFamily):
(WebCore::FontGenericFamilies::sansSerifFontFamily):
(WebCore::FontGenericFamilies::cursiveFontFamily):
(WebCore::FontGenericFamilies::fantasyFontFamily):
(WebCore::FontGenericFamilies::pictographFontFamily):
(WebCore::FontGenericFamilies::setStandardFontFamily):
(WebCore::FontGenericFamilies::setFixedFontFamily):
(WebCore::FontGenericFamilies::setSerifFontFamily):
(WebCore::FontGenericFamilies::setSansSerifFontFamily):
(WebCore::FontGenericFamilies::setCursiveFontFamily):
(WebCore::FontGenericFamilies::setFantasyFontFamily):
(WebCore::FontGenericFamilies::setPictographFontFamily):

  • platform/graphics/FontGenericFamilies.h: Added.

(WebCore::UScriptCodeHashTraits::emptyValue):
(WebCore::UScriptCodeHashTraits::constructDeletedValue):
(WebCore::UScriptCodeHashTraits::isDeletedValue):
(WebCore::FontGenericFamilies::create):

7:15 AM Changeset in webkit [150961] by zarvai@inf.u-szeged.hu
  • 91 edits
    43 copies
    483 adds in trunk/LayoutTests

[Qt][WK2] Unreviewed expected pixel result rebaselining after r150798.

  • platform/qt-5.0-wk2/compositing/checkerboard-expected.png:
  • platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png:
  • platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.png:
  • platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.png:
  • platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.png:
  • platform/qt-5.0-wk2/compositing/overflow/nested-scrolling-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/patterns/direct-pattern-compositing-contain-no-repeat-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/newly-composited-on-scroll-expected.png:
  • platform/qt-5.0-wk2/compositing/repaint/page-scale-repaint-expected.png:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.png:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.png:
  • platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/qt-5.0-wk2/css1/basic/containment-expected.png: Added.
  • platform/qt-5.0-wk2/css1/basic/id_as_selector-expected.png: Added.
  • platform/qt-5.0-wk2/css1/basic/inheritance-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_bottom-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_bottom_width-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_left-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_left_width-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_right_inline-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_right_width-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_style-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_top-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_top_width-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_width-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/clear-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/clear_float-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/float_elements_in_series-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/float_margin-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/float_on_text_elements-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/height-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/margin-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/margin_bottom-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/margin_inline-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/margin_left-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/margin_right-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/margin_top-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/padding-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/padding_bottom-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/padding_inline-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/padding_left-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/padding_right-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/padding_top-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/width-expected.png: Added.
  • platform/qt-5.0-wk2/css1/cascade/cascade_order-expected.png: Added.
  • platform/qt-5.0-wk2/css1/classification/display-expected.png: Added.
  • platform/qt-5.0-wk2/css1/classification/list_style_type-expected.png: Added.
  • platform/qt-5.0-wk2/css1/classification/white_space-expected.png: Added.
  • platform/qt-5.0-wk2/css1/color_and_background/background-expected.png: Added.
  • platform/qt-5.0-wk2/css1/color_and_background/background_attachment-expected.png: Added.
  • platform/qt-5.0-wk2/css1/color_and_background/background_position-expected.png: Added.
  • platform/qt-5.0-wk2/css1/color_and_background/background_repeat-expected.png: Added.
  • platform/qt-5.0-wk2/css1/conformance/forward_compatible_parsing-expected.png: Added.
  • platform/qt-5.0-wk2/css1/font_properties/font-expected.png: Added.
  • platform/qt-5.0-wk2/css1/font_properties/font_family-expected.png: Added.
  • platform/qt-5.0-wk2/css1/font_properties/font_size-expected.png: Added.
  • platform/qt-5.0-wk2/css1/font_properties/font_weight-expected.png: Added.
  • platform/qt-5.0-wk2/css1/formatting_model/floating_elements-expected.png: Added.
  • platform/qt-5.0-wk2/css1/formatting_model/height_of_lines-expected.png: Added.
  • platform/qt-5.0-wk2/css1/formatting_model/horizontal_formatting-expected.png: Added.
  • platform/qt-5.0-wk2/css1/formatting_model/inline_elements-expected.png: Added.
  • platform/qt-5.0-wk2/css1/formatting_model/replaced_elements-expected.png: Added.
  • platform/qt-5.0-wk2/css1/formatting_model/vertical_formatting-expected.png: Added.
  • platform/qt-5.0-wk2/css1/pseudo/anchor-expected.png: Added.
  • platform/qt-5.0-wk2/css1/pseudo/firstletter-expected.png: Added.
  • platform/qt-5.0-wk2/css1/pseudo/firstline-expected.png: Added.
  • platform/qt-5.0-wk2/css1/pseudo/multiple_pseudo_elements-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/letter_spacing-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/line_height-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/text_decoration-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/text_indent-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/text_transform-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/vertical_align-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/word_spacing-expected.png: Added.
  • platform/qt-5.0-wk2/css1/units/color_units-expected.png: Added.
  • platform/qt-5.0-wk2/css1/units/length_units-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png.
  • platform/qt-5.0-wk2/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-002-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-004-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-008-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-010-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-012-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-014-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-016-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0803-c5505-mrgn-02-c-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t1508-c527-font-07-b-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/qt-5.0-wk2/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/qt-5.0-wk2/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/qt-5.0-wk2/editing/deleting/delete-line-end-ws-001-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-line-end-ws-002-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/insert-div-023-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/extend-by-character-004-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/focus_editable_html-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/move-by-character-004-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/select-all-001-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/select-all-002-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/select-all-003-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/select-all-004-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png.
  • platform/qt-5.0-wk2/editing/selection/unrendered-001-expected.png:
  • platform/qt-5.0-wk2/editing/selection/unrendered-002-expected.png:
  • platform/qt-5.0-wk2/editing/selection/unrendered-003-expected.png:
  • platform/qt-5.0-wk2/editing/selection/unrendered-004-expected.png:
  • platform/qt-5.0-wk2/editing/selection/unrendered-005-expected.png:
  • platform/qt-5.0-wk2/fast/backgrounds/background-inherit-color-bug-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize15-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/basic/016-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/008-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/013-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/019-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/021-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/025-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/027-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/032-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/033-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/035-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/repaint/newly-composited-on-scroll-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/br-with-clear-2-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/float-avoidance-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/nested-clearance-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/relative-painted-twice-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/margin-collapse/103-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/margin-collapse/104-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/margin-collapse/empty-clear-blocks-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/047-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/051-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/055-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/auto/007-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-lr/005-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-rl/005-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/negative-rel-position-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
  • platform/qt-5.0-wk2/fast/block/positioning/relative-overflow-block-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/relative-overflow-replaced-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/relative-overflow-replaced-float-expected.png: Added.
  • platform/qt-5.0-wk2/fast/body-propagation/overflow/001-expected.png: Added.
  • platform/qt-5.0-wk2/fast/body-propagation/overflow/001-xhtml-expected.png: Added.
  • platform/qt-5.0-wk2/fast/body-propagation/overflow/005-declarative-expected.png: Added.
  • platform/qt-5.0-wk2/fast/body-propagation/overflow/005-expected.png: Added.
  • platform/qt-5.0-wk2/fast/body-propagation/overflow/005-xhtml-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-massive-scale-expected.png:
  • platform/qt-5.0-wk2/fast/borders/border-image-rotate-transform-expected.png:
  • platform/qt-5.0-wk2/fast/borders/border-image-scale-transform-expected.png:
  • platform/qt-5.0-wk2/fast/borders/border-image-scaled-expected.png:
  • platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/qt-5.0-wk2/fast/borders/rtl-border-01-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/rtl-border-02-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/rtl-border-03-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-sizing/box-sizing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/canvas-bg-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css-generated-content/014-expected.png:
  • platform/qt-5.0-wk2/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/005-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/qt-5.0-wk2/fast/css/border-height-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/clip-text-in-scaled-div-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/empty-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/first-child-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/first-of-type-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/font_property_normal-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/hsl-color-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/last-child-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/last-of-type-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/line-height-overflow-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/nested-floating-relative-position-percentages-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/only-child-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/only-of-type-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/shadow-multiple-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/text-overflow-ellipsis-text-align-justify-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/text-overflow-ellipsis-text-align-left-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/text-overflow-ellipsis-text-align-right-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png: Added.
  • platform/qt-5.0-wk2/fast/dom/clone-node-dynamic-style-expected.png: Added.
  • platform/qt-5.0-wk2/fast/dynamic/008-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/custom/text-xy-updates-SVGList-expected.png.
  • platform/qt-5.0-wk2/fast/dynamic/anchor-lock-expected.png: Added.
  • platform/qt-5.0-wk2/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
  • platform/qt-5.0-wk2/fast/encoding/utf-16-big-endian-expected.png: Added.
  • platform/qt-5.0-wk2/fast/encoding/utf-16-little-endian-expected.png: Added.
  • platform/qt-5.0-wk2/fast/events/pointer-events-2-expected.png:
  • platform/qt-5.0-wk2/fast/events/resize-events-expected.png: Added.
  • platform/qt-5.0-wk2/fast/flexbox/016-expected.png: Added.
  • platform/qt-5.0-wk2/fast/flexbox/flex-hang-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/button-default-title-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/button-table-styles-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/disabled-select-change-index-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/fieldset-align-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/file/file-input-direction-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/form-hides-table-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-simple-expected.png:
  • platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/iframe-scrolling-attribute-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/transparent-scrollbar-expected.png:
  • platform/qt-5.0-wk2/fast/gradients/background-clipped-expected.png:
  • platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png:
  • platform/qt-5.0-wk2/fast/html/details-position-expected.png: Added.
  • platform/qt-5.0-wk2/fast/html/details-writing-mode-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline/inline-borders-with-bidi-override-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline/inline-continuation-borders-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline/long-wrapped-line-expected.png: Added.
  • platform/qt-5.0-wk2/fast/layers/layer-content-visibility-change-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/qt-5.0-wk2/fast/line-grid/line-grid-inside-columns-expected.png: Added.
  • platform/qt-5.0-wk2/fast/lists/001-expected.png: Added.
  • platform/qt-5.0-wk2/fast/lists/001-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/lists/008-expected.png: Added.
  • platform/qt-5.0-wk2/fast/lists/008-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/lists/li-br-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/fast/lists/ol-start-parsing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/lists/olstart-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/client-rects-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/column-rules-stacking-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/columns-shorthand-parsing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/float-multicol-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/float-paginate-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/layers-split-across-columns-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/paginate-block-replaced-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/pagination-h-horizontal-bt-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-h-horizontal-tb-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-h-vertical-lr-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-h-vertical-rl-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-v-horizontal-bt-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-v-horizontal-tb-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-v-vertical-lr-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-v-vertical-rl-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/repaint/newly-composited-on-scroll-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/positioned-with-constrained-height-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/progression-reverse-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-margin-collapsing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/006-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/overflow-auto-table-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/overflow-stacking-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/paged-x-on-root-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/paged-y-on-root-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/qt-5.0-wk2/fast/reflections/reflection-direction-expected.png: Added.
  • platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png:
  • platform/qt-5.0-wk2/fast/regions/region-style-inline-background-color-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/float-new-in-block-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/qt-5.0-wk2/fast/replaced/005-expected.png: Added.
  • platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
  • platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png:
  • platform/qt-5.0-wk2/fast/selectors/166-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/023-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/027-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/034-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/038-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/040-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/040-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/002-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/004-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/empty-cells-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/frame-and-rules-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/height-percent-test-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/table/height-percent-test-vertical-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/fast/table/overflowHidden-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/prepend-in-anonymous-table-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/table-display-types-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/wide-colspan-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png.
  • platform/qt-5.0-wk2/fast/table/wide-column-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/softHyphen-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/text-letter-spacing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/wbr-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/word-break-expected.png: Added.
  • platform/qt-5.0-wk2/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
  • platform/qt-5.0-wk2/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
  • platform/qt-5.0-wk2/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png: Added.
  • platform/qt-5.0-wk2/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/qt-5.0-wk2/fast/writing-mode/box-shadow-vertical-rl-expected.png: Added.
  • platform/qt-5.0-wk2/fast/writing-mode/fieldsets-expected.png: Added.
  • platform/qt-5.0-wk2/fonts/cursive-expected.png: Added.
  • platform/qt-5.0-wk2/fonts/default-expected.png: Added.
  • platform/qt-5.0-wk2/fonts/fantasy-expected.png: Added.
  • platform/qt-5.0-wk2/fonts/monospace-expected.png: Added.
  • platform/qt-5.0-wk2/fonts/sans-serif-expected.png: Added.
  • platform/qt-5.0-wk2/fonts/serif-expected.png: Added.
  • platform/qt-5.0-wk2/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
  • platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
  • platform/qt-5.0-wk2/printing/return-from-printing-mode-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/qt-5.0-wk2/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
  • platform/qt-5.0-wk2/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/qt-5.0-wk2/svg/custom/altglyph-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/external-paintserver-reference-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png.
  • platform/qt-5.0-wk2/svg/custom/js-late-pattern-creation-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/junk-data-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/linking-base-external-reference-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png.
  • platform/qt-5.0-wk2/svg/custom/missing-xlink-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/path-bad-data-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/pattern-scaling-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/qt-5.0-wk2/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/qt-5.0-wk2/svg/custom/use-font-face-crash-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/css-transforms-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/qt-5.0-wk2/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-multiple-targets-id-change-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/svg/hixie/error/012-expected.png: Added.
  • platform/qt-5.0-wk2/svg/in-html/circle-expected.png: Added.
  • platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png:
  • platform/qt-5.0-wk2/svg/text/kerning-expected.png: Added.
  • platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.png: Added.
  • platform/qt-5.0-wk2/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/qt-5.0-wk2/svg/wicd/test-rightsizing-b-expected.png:
  • platform/qt-5.0-wk2/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/qt-5.0-wk2/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug101674-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug10269-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug10296-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug1055-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug113235-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug113235-3-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug11944-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug120364-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug12384-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug1302-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug131020-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug131020_iframe-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug137388-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug16252-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug194024-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug22019-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug23151-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug2479-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug2479-4-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug27038-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug29314-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug2947-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug32205-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug38916-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug3977-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug43039-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug43854-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug44505-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug46480-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug46480-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug50695-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug56405-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug5797-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug5835-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug625-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug650-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug67915-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug7112-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug7112-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug73321-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug92143-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug96343-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/bloomberg-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/core/captions-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/cell_heights-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/col_span-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/col_widths_auto_fix-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/col_widths_fix_fixPer-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/nested1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/one_row-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/row_span-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_index-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_table_bgcolor_name-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_bgcolor_name-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_height-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_nowrap-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_bgcolor_name-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_height-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_nowrap-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/other/cell_widths-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/other/nestedTables-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/other/test3-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/other/test6-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/other/wa_table_tr_align-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug101759-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug19526-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug22122-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug7243-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug91057-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/backgrounds-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/col_span2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/columns-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/conflicts-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/standards1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/other/empty_cells-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/other/test4-expected.png: Added.
  • platform/qt-5.0-wk2/transforms/2d/transform-fixed-container-expected.png:
5:53 AM Changeset in webkit [150960] by akling@apple.com
  • 11 edits in trunk/Source/WebCore

Avoid using CSSOM style declarations in HTML editing.
<​http://webkit.org/b/117019>

Reviewed by Antti Koivisto.

Convert the editing code to use ComputedStyleExtractor instead of instantiating CSSOM wrappers.

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::getFontSizeCSSValuePreferringKeyword):
(WebCore::ComputedStyleExtractor::useFixedFontDefaultSize):
(WebCore::ComputedStyleExtractor::propertyMatches):
(WebCore::ComputedStyleExtractor::copyProperties):
(WebCore::ComputedStyleExtractor::copyPropertiesInSet):

Moved here from CSSComputedStyleDeclaration. These methods are used by HTML editing.

(WebCore::CSSComputedStyleDeclaration::copyProperties):

Reimplemented to call ComputedStyleExtractor.

  • css/CSSStyleDeclaration.h:
  • css/PropertySetCSSStyleDeclaration.h:
  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::copyProperties):

Removed CSSStyleDeclaration::cssPropertyMatches(), the remaining code lives in
ComputedStyleExtractor::propertyMatches() and is only used by HTML editing.

  • css/StylePropertySet.h:
  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::removeEquivalentProperties):

Added an overload that takes a ComputedStyleExtractor.
This code should move into EditingStyle.cpp, material for a follow-up patch.

  • editing/ApplyStyleCommand.cpp:

(WebCore::toIdentifier):

Add a file-local helper for yanking the identifier value (if any) out of a CSSPrimitiveValue.

(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::highestEmbeddingAncestor):

  • editing/EditingStyle.h:
  • editing/EditingStyle.cpp:

(WebCore::editingStyleFromComputedStyle):
(WebCore::extractPropertyValue):
(WebCore::identifierForStyleProperty):
(WebCore::textColorFromStyle):
(WebCore::backgroundColorFromStyle):
(WebCore::EditingStyle::init):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::StyleChange::StyleChange):
(WebCore::fontWeightIsBold):
(WebCore::extractPropertiesNotIn):
(WebCore::getPropertiesNotIn):

Use ComputedStyleExtractor instead of CSSComputedStyleDeclaration in all of this code.
Templatized a bunch of the code so we don't have to repeat ourselves for both StylePropertySet
and ComputedStyleExtractor inputs.

5:41 AM Changeset in webkit [150959] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove "hidden"=true from Inspector.json
​https://bugs.webkit.org/show_bug.cgi?id=114116

Patch by Roland Takacs <​rtakacs@inf.u-szeged.hu> on 2013-05-30
Reviewed by Timothy Hatcher.

Remove "hidden"=true because it's a Chromium concept.
Patch created by Timothy Hatcher.

  • inspector/Inspector.json:
5:28 AM Changeset in webkit [150958] by kalyan.kondapally@intel.com
  • 9 edits in trunk/Source/WebCore

[EFL][EGL] Implement TransportSurface client.
​https://bugs.webkit.org/show_bug.cgi?id=114122

Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This patch implements the client support for Transport
Surface with EGL backend using GLES2.

  • platform/graphics/surfaces/efl/GLTransportSurface.cpp:

(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::GLTransportSurfaceClient):

  • platform/graphics/surfaces/efl/GLTransportSurface.h:

(GLTransportSurfaceClient):

  • platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:

(WebCore::GraphicsSurfacePrivate::initializeClient):

  • platform/graphics/surfaces/egl/EGLConfigSelector.cpp:

(WebCore):
(WebCore::EGLConfigSelector::surfaceClientConfig):
(WebCore::EGLConfigSelector::findMatchingConfigWithVisualId):

  • platform/graphics/surfaces/egl/EGLConfigSelector.h:

(WebCore):
(EGLConfigSelector):

Support for retrieving valid EGLConfig on client side.

  • platform/graphics/surfaces/egl/EGLHelper.cpp:

(WebCore):
(WebCore::resolveDisplay):
(WebCore::EGLHelper::resolveEGLBindings):
(WebCore::EGLHelper::createEGLImage):
(WebCore::EGLHelper::destroyEGLImage):
(WebCore::EGLHelper::imageTargetTexture2DOES):

  • platform/graphics/surfaces/egl/EGLHelper.h:

Helper functions to create and destroy EGLImage.

  • platform/graphics/surfaces/egl/EGLXSurface.cpp:

(WebCore::EGLXTransportSurfaceClient::EGLXTransportSurfaceClient):
(WebCore):
(WebCore::EGLXTransportSurfaceClient::~EGLXTransportSurfaceClient):
(WebCore::EGLXTransportSurfaceClient::destroy):
(WebCore::EGLXTransportSurfaceClient::prepareTexture):
(WebCore::EGLTextureFromPixmap::EGLTextureFromPixmap):
(WebCore::EGLTextureFromPixmap::~EGLTextureFromPixmap):
(WebCore::EGLTextureFromPixmap::destroy):
(WebCore::EGLTextureFromPixmap::isValid):
(WebCore::EGLTextureFromPixmap::bindTexImage):
(WebCore::EGLTextureFromPixmap::reBindTexImage):

  • platform/graphics/surfaces/egl/EGLXSurface.h:

(EGLXTransportSurfaceClient):

TransportSurfaceClient implementation.

(WebCore):

  • platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurfaceClient::GLXTransportSurfaceClient):

  • platform/graphics/surfaces/glx/GLXSurface.h:

(GLXTransportSurfaceClient):

  • platform/graphics/surfaces/glx/X11Helper.cpp:

(WebCore::X11Helper::createOffScreenWindow):
(WebCore):
(WebCore::X11Helper::createPixmap):

  • platform/graphics/surfaces/glx/X11Helper.h:

(X11Helper):

5:08 AM Changeset in webkit [150957] by mkwst@chromium.org
  • 22 edits in trunk/Source/WebCore

Rename 'KURL::elidedString' and inspector's 'String.prototype.trimMiddle' for clarity.
​https://bugs.webkit.org/show_bug.cgi?id=111700

Reviewed by Darin Adler.

Darin suggested that 'KURL::elidedString' is inaccurately named[1], this
patch is an attempt to do better. It additionally brings the Inspector's
'String.prototype.trimMiddle' method into line, as the two methods do
more or less the same thing.

After a bit of discussion with Maciej and Daniel Bates on IRC, I've
settled on 'KURL::stringCenterEllipsizedToLength(unsigned)' and
'String.prototype.centerEllipsizedToLength(number)' respectively.

No new tests are added, as this patch shouldn't have any visible effect
on the web. It's strictly an internal refactoring.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::fail):

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeScript):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::isSafeToLoadURL):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
(WebCore::createWindow):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived):

  • loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::logWarning):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFail):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::printAccessDeniedMessage):

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowScriptNonce):
(WebCore::CSPDirectiveList::allowPluginType):

  • platform/KURL.cpp:

(WebCore::KURL::stringCenterEllipsizedToLength):

  • platform/KURL.h:

Rename 'KURL::elidedString' to 'KURL::stringCenterEllipsizedToLength',
and adjust callsites accordingly.

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.Placard.prototype._update):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):

  • inspector/front-end/Linkifier.js:

(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyURLAsNode):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._titleForFile):

  • inspector/front-end/utilities.js:

Rename 'String.prototype.trimMiddle' to 'String.prototype.centerEllipsizedToLength'
and adjust callsites accordingly.

3:44 AM Changeset in webkit [150956] by Antti Koivisto
  • 15 edits
    2 moves in trunk/Source/WebCore

Rename FontFallbackList.cpp/h to FontGlyphs.cpp/h
​https://bugs.webkit.org/show_bug.cgi?id=117022

Reviewed by Andreas Kling.

Rename to match the class name.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Font.h:
  • platform/graphics/FontCache.cpp:
  • platform/graphics/FontFallbackList.cpp: Removed.
  • platform/graphics/FontFallbackList.h: Removed.
  • platform/graphics/FontFastPath.cpp:
  • platform/graphics/FontGlyphs.cpp: Copied from Source/WebCore/platform/graphics/FontFallbackList.cpp.
  • platform/graphics/FontGlyphs.h: Copied from Source/WebCore/platform/graphics/FontFallbackList.h.
  • platform/graphics/mac/FontComplexTextMac.cpp:
3:43 AM Changeset in webkit [150955] by rniwa@webkit.org
  • 6 edits
    11 deletes in trunk

Web Inspector: tests in PerformanceTests/inspector/ are timing out
​https://bugs.webkit.org/show_bug.cgi?id=77024

Reviewed by Andreas Kling.

PerformanceTests:

These tests have been disabled for ages and don't conform to the standard format.

  • Skipped:
  • inspector: Removed.
  • inspector/console-300-lines.html: Removed.
  • inspector/first-open-elements.html: Removed.
  • inspector/first-open-resources.html: Removed.
  • inspector/first-open-scripts.html.broken: Removed.
  • inspector/heap-snapshot-advanced.html: Removed.
  • inspector/heap-snapshot-performance-test.js: Removed.
  • inspector/heap-snapshot.html: Removed.
  • inspector/inspector-startup-time.html: Removed.
  • inspector/network-append-30-requests.html.broken: Removed.
  • inspector/performance-test.js: Removed.
  • inspector/show-panel.html.broken: Removed.

Tools:

Remove inspector performance tests since they have been disabled for ages,
and they don't use the standard parser-style performance output.

It's adding a lot of code complexity to our infrastructure.

  • Scripts/webkitpy/performance_tests/perftest.py:

(SingleProcessPerfTest.init):
(PerfTestFactory):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTestFactory.test_regular_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(TestDriver.run_test):
(MainTest.run_test):
(MainTest._tests_for_runner):
(MainTest.test_run_test_set_kills_drt_per_run):
(MainTest._test_run_with_json_output):
(MainTest):
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):

3:42 AM Changeset in webkit [150954] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Get rid of Position::computedStyle
​https://bugs.webkit.org/show_bug.cgi?id=117024

Reviewed by Andreas Kling.

Removed the function.

  • dom/Position.cpp:
  • dom/Position.h:
  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::positionToComputeInlineStyleChange): We need a position
inside the dummy element since we'll get the containing element's style instead
if we had the position before the dummy element.

  • editing/EditingStyle.cpp:

(WebCore::StyleChange::StyleChange):

1:14 AM Changeset in webkit [150953] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove obsolete forward declaration from InspectorFrontendHost.h
​https://bugs.webkit.org/show_bug.cgi?id=117017

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-30
Reviewed by Joseph Pecoraro.

Remove obsolete forward declaration and fix style issue as well.

No change in behavior, no new tests.

  • inspector/InspectorFrontendHost.h:

(WebCore):
(InspectorFrontendHost):

12:34 AM Changeset in webkit [150952] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Cleanup TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=117005

Unreviewed GTK gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-30

  • platform/gtk/TestExpectations: Get rid of duplicate entry line.
12:32 AM Changeset in webkit [150951] by rniwa@webkit.org
  • 6 edits in trunk/Tools

Remove requires_http_server as Chromium Android was the only port that needed this
​https://bugs.webkit.org/show_bug.cgi?id=117018

Reviewed by Benjamin Poulain.

Removed the unused code that existed for Chromium Android port.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.run_tests):
(LayoutTestRunner._handle_finished_test_list):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._collect_tests):
(PerfTestsRunner.run):

  • Scripts/webkitpy/port/base.py:

(Port.to.start_helper):

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_build_path):

May 29, 2013:

11:24 PM Changeset in webkit [150950] by timothy_horton@apple.com
  • 12 edits in trunk/Source

Expose incrementalRenderingSuppressionTimeout via WK2
​https://bugs.webkit.org/show_bug.cgi?id=117015
<rdar://problem/13992853>

Reviewed by Darin Adler.

  • dom/Document.cpp:

(WebCore::Document::setVisualUpdatesAllowed):
Inform the FrameLoader that we're ready to transition the page, if
nothing else already has. This will be forwarded to the FrameLoaderClient,
and WebKit2's implementation will go ahead and un-freeze the layer tree,
so that the incremental rendering suppression watchdog timer actually works.

(WebCore::Document::setVisualUpdatesAllowedByClient):
Make incremental rendering suppression extension tokens play nice with the
watchdog timer; allow setVisualUpdatesAllowedByClient=true to re-enable updates
if either the page is in the "completed" state or the watchdog has already fired.

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:

(WebCore::FrameLoader::forcePageTransitionIfNeeded): Added.
Forward to the client.

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::forcePageTransitionIfNeeded): Added.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferencesPrivate.h:

Add IncrementalRenderingSuppressionTimeout preference.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetIncrementalRenderingSuppressionTimeout): Added.
(WKPreferencesGetIncrementalRenderingSuppressionTimeout): Added.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebKit::WebFrameLoaderClient::forcePageTransitionIfNeeded): Added.
Call didCompletePageTransition, which un-freezes the layer tree.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCompletePageTransition):
Fix some indentation.

(WebKit::WebPage::updatePreferences):
Forward the timeout value through to WebCore.

11:04 PM Changeset in webkit [150949] by commit-queue@webkit.org
  • 8 edits in trunk

ProgressEvent should not be cancelable
​https://bugs.webkit.org/show_bug.cgi?id=114444

Patch by Praveen R Jadhav <​praveen.j@samsung.com> on 2013-05-29
Reviewed by Darin Adler.

Source/WebCore:

Parameter "cancelable" in ProgressEvent is set to false, by default, as mentioned in the specification. The spec link is given below.

Spec: ​http://www.w3.org/TR/2011/CR-progress-events-20110922/#suggested-names-for-events-using-the-progressevent-interface

No new tests. file-reader-event-listener.html and infoOnProgressEvent-expected.txt are updated.

  • dom/ProgressEvent.cpp:

(WebCore::ProgressEvent::ProgressEvent):
(WebCore):

LayoutTests:

file-reader-event-listener.html, xmlhttprequest-get-expected.txt and infoOnProgressEvent-expected.txt are updated.

  • fast/files/file-reader-event-listener-expected.txt:
  • fast/files/file-reader-event-listener.html:
  • fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
  • http/tests/xmlhttprequest/infoOnProgressEvent-expected.txt:
  • platform/efl/TestExpectations:
9:34 PM Changeset in webkit [150948] by Simon Fraser
  • 6 edits in trunk/Source

Fix paint-related milestones to not fire when the layer tree is frozen
​https://bugs.webkit.org/show_bug.cgi?id=117012

Source/WebCore:

Reviewed by Tim Horton.

In the previous code, it was possible to paint some layer and schedule
the m_paintRelatedMilestonesTimer, but then the layer tree was put into
a frozen state because the page redirected. However, the paint-related
milestones timer would still fire. This caused woes with header/footer
banners.

Fix by not firing paint-related milestones if the layer tree is frozen,
which we know via a new ChromeClient callback. When unfrozen, we'll
paint again, and fire the timer later.

  • page/ChromeClient.h:

(WebCore::ChromeClient::layerTreeStateIsFrozen):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):

Source/WebKit2:

Reviewed by Tim Horton.

Implement ChromeClient::layerTreeStateIsFrozen() to return
the frozen state of the drawing area.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::layerTreeStateIsFrozen):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

9:30 PM Changeset in webkit [150947] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Web Inspector: get rid of obsolete InspectorFrontendHost.hiddenPanels()
​https://bugs.webkit.org/show_bug.cgi?id=60152

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-29
Reviewed by Andreas Kling.

  • WebCoreSupport/WebInspectorClient.mm:
9:17 PM Changeset in webkit [150946] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

Store form control list with RefPtr
​https://bugs.webkit.org/show_bug.cgi?id=116910

Reviewed by Kent Tamura.

Merge ​https://chromium.googlesource.com/chromium/blink/+/582132773280455ead1d42b0073be37efdeaf989.

Unfortunately, the Blink change doesn't provide much insight as to what kind of crashes are fixed
by this code change but it cleans up the way form elements with state are registered to the form
controller so it seems benefitial to merge it anyway.

  • dom/Document.cpp:

(WebCore::Document::dispose):

  • html/FormController.cpp:

(WebCore::FormController::createSavedFormStateMap):
(WebCore::FormController::registerFormElementWithState):
(WebCore::FormController::unregisterFormElementWithState):
(WebCore):

  • html/FormController.h:

(FormController):

  • html/HTMLFormControlElementWithState.cpp:

(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::insertedInto):
(WebCore):
(WebCore::HTMLFormControlElementWithState::removedFrom):

  • html/HTMLFormControlElementWithState.h:

(HTMLFormControlElementWithState):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::insertedInto):

9:11 PM Changeset in webkit [150945] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Take ComputedStyleExtractor for a spin.
<​http://webkit.org/b/116968>

Reviewed by Antti Koivisto.

Convert some editing and SVG code to use ComputedStyleExtractor instead of creating full
blown CSSComputedStyleDeclaration objects.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::highestEmbeddingAncestor):
(WebCore::ApplyStyleCommand::computedFontSize):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::getIdentifierValue):
(WebCore::backgroundColorInEffect):

  • editing/EditingStyle.h:
  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::computeCSSPropertyValue):

8:26 PM WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
Update Known issues (diff)
8:02 PM Changeset in webkit [150944] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Add a special case for SelectorDataList::execute when there is only one selector
​https://bugs.webkit.org/show_bug.cgi?id=116891

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-05-29
Reviewed by Andreas Kling.

In the vast majority of cases, querySelector is called with a single selector.

This patch takes that input into account to improve the performance of
SelectorDataList::execute(). For the case of a single selector, we avoid three
branches executed for every node of the traversal.

This improves QuerySelector's time by 2.3%.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::execute):

7:34 PM Changeset in webkit [150943] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Versioning.

7:31 PM Changeset in webkit [150942] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.3

New Tag.

6:21 PM Changeset in webkit [150941] by dino@apple.com
  • 10 edits in trunk

-webkit-text-underline-position should not be inherited
​https://bugs.webkit.org/show_bug.cgi?id=116363

Reverting ​http://trac.webkit.org/changeset/150366
It was an incorrect fix referring to an old specification.

Source/WebCore:

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt:
  • fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js:
6:19 PM Changeset in webkit [150940] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[CMAKE] cmake errors when CMAKE_BUILD_TYPE is not specified.
​https://bugs.webkit.org/show_bug.cgi?id=116899

Reviewed by Laszlo Gombos.

  • CMakeLists.txt: Fixed if statement to escape when find command fails.
6:07 PM Changeset in webkit [150939] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
​https://bugs.webkit.org/show_bug.cgi?id=113221

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-05-29
Reviewed by Ryosuke Niwa.

Teach prepare-Changelog to not list the names of modified namespaces,
classes, or structs in C++ files. Thus, if a change is made
within a namespace/class/struct yet outside a function, it will
not be reflected in the ChangeLog entry.
See ​https://bugs.webkit.org/show_bug.cgi?id=113221#c8
for more details on how ChangeLog entries are affected.

  • Scripts/prepare-ChangeLog:

(get_function_line_ranges_for_cpp):
(delete_namespaces_from_ranges_for_cpp): Added.
(is_function_in_namespace): Added.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated

to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)

5:10 PM Changeset in webkit [150938] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

WebKit should expose HSTS APIs to determine whether a host is in the HSTS cache and to reset HSTS policies
​https://bugs.webkit.org/show_bug.cgi?id=117010
<rdar://problem/13689666>

Reviewed by Tim Horton.

  • UIProcess/API/C/mac/WKContextPrivateMac.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm:
  • UIProcess/API/C/mac/WKPagePrivateMac.cpp:
  • UIProcess/API/C/mac/WKPagePrivateMac.h:
  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/mac/WebContextMac.mm:

(WebKit):
(WebKit::privateBrowsingSession):
(WebKit::WebContext::isURLKnownHSTSHost):
(WebKit::WebContext::resetHSTSHosts):

4:57 PM Changeset in webkit [150937] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r150936. <rdar://problem/14007440>

4:52 PM Changeset in webkit [150936] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

WKViews using shouldClipToVisibleRect=YES should respect prepareContentInRect: if called
​https://bugs.webkit.org/show_bug.cgi?id=116989
<rdar://problem/14007440>

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView prepareContentInRect:]):
If prepareContentInRect: is called, save the rect and set a flag so we know we should use it.

(-[WKView _updateViewExposedRect]):
Give the WebPage (and later the DrawingArea) the union of the rect handed to prepareContentInRect:
and the WKView's visibleRect, if we're in that mode, so that applications that do their own scrolling
can cause tiles to be created in currently offscreen views (for overdraw).

(-[WKView setFrameSize:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView setShouldClipToVisibleRect:]):
(-[WKView forceAsyncDrawingAreaSizeUpdate:]):
Use [_updateViewExposedRect].

4:17 PM Changeset in webkit [150935] by oliver@apple.com
  • 24 edits
    2 adds in trunk/Source

Add more accurate activity state tracking
​https://bugs.webkit.org/show_bug.cgi?id=116893

Reviewed by Gavin Barraclough.

Source/WebCore:

Add a hysteresis to Page activity throttling. We do this
through a PageThrottler class that now handles entering and
exiting throttling state, and adds a hysteresis to we can
limit the amount of on/off bouncing on the throttle.

Media elements now make use of this to disable timer throttling
while they are playing, and plugins use it to momentarily bounce
from throttled to unthrottled state.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::pageThrottlerIfPossible):
(WebCore):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pauseInternal):

  • html/HTMLMediaElement.h:

(WebCore):

  • html/MediaController.cpp:

(MediaController::unpause):

  • page/ChromeClient.h:

(WebCore::ChromeClient::incrementActivePageCount):
(WebCore::ChromeClient::decrementActivePageCount):
(ChromeClient):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::setThrottled):

  • page/Page.h:

(WebCore):
(Page):
(WebCore::Page::pageThrottler):

  • page/PageThrottleState.h: Added.
  • page/PageThrottler.cpp: Added.

(WebCore):
(WebCore::PageThrottler::PageThrottler):
(WebCore::PageThrottler::~PageThrottler):
(WebCore::PageThrottler::clearPage):
(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):
(WebCore::PageThrottler::setThrottled):
(WebCore::PageThrottler::preventThrottling):
(WebCore::PageThrottler::allowThrottling):
(WebCore::PageThrottler::stopThrottleHysteresisTimer):
(WebCore::PageThrottler::reportInterestingEvent):
(WebCore::PageThrottler::startThrottleHysteresisTimer):
(WebCore::PageThrottler::throttleHysteresisTimerFired):

  • page/PageThrottler.h: Added.

(WebCore):
(PageThrottler):
(WebCore::PageThrottler::create):
(WebCore::PageThrottler::shouldThrottleAnimations):
(WebCore::PageThrottler::shouldThrottleTimers):

Source/WebKit2:

This extends the logic in WebCore from a Page to Process
granularity, so we will avoid lowering the child process
priority if there is active content. This also plumbs in
the logic to allow plugins to report that they have done
something "interesting". Currently this is somewhat conservative
but even this is sufficient to fix some stuttering issues
that we've seen.

  • Shared/ChildProcess.cpp:

(WebKit::ChildProcess::ChildProcess):

  • Shared/ChildProcess.h:

(ChildProcess):
(WebKit::ChildProcess::processSuppressionEnabled):
(WebKit::ChildProcess::incrementActiveTaskCount):
(WebKit::ChildProcess::decrementActiveTaskCount):

  • Shared/mac/ChildProcessMac.mm:

(WebKit):
(WebKit::ChildProcess::setProcessSuppressionEnabledInternal):
(WebKit::ChildProcess::setProcessSuppressionEnabled):
(WebKit::ChildProcess::incrementActiveTaskCount):
(WebKit::ChildProcess::decrementActiveTaskCount):
(WebKit::ChildProcess::suspensionHysteresisTimerFired):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::evaluate):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:

(WebCore):
(NPRuntimeObjectMap):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::incrementActivePageCount):
(WebKit):
(WebKit::WebChromeClient::decrementActivePageCount):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

3:16 PM Changeset in webkit [150934] by tkent@chromium.org
  • 2 edits
    10 deletes in trunk

Remove leftover files for ENABLE_PAGE_POPUP and ENABLE_CALENDAR_PICKER
​https://bugs.webkit.org/show_bug.cgi?id=116999

Reviewed by Anders Carlsson.

.:

  • ManualTests/forms/calendar-picker-crash-by-type-change.html: Removed.
  • ManualTests/forms/calendar-picker.html: Removed.
  • ManualTests/forms/color-suggestion-picker.html: Removed.
  • ManualTests/forms/date-suggestion-picker.html: Removed.

Source/WebCore:

  • Resources/pagepopups/colorSuggestionPicker.css: Removed.
  • Resources/pagepopups/colorSuggestionPicker.js: Removed.
  • Resources/pagepopups/pickerCommon.css: Removed.
  • Resources/pagepopups/pickerCommon.js: Removed.
  • Resources/pagepopups/suggestionPicker.css: Removed.
  • Resources/pagepopups/suggestionPicker.js: Removed.
2:59 PM Changeset in webkit [150933] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; remove unintentional semicolon.

  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::finish):

2:53 PM Changeset in webkit [150932] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Merge PODArea::Chunk into PODFreeListArena::FreeListChunk
​https://bugs.webkit.org/show_bug.cgi?id=117000

Reviewed by Oliver Hunt.

  • platform/PODArena.h:

(WebCore::PODArena::roundUp):

  • platform/PODFreeListArena.h:

(PODFreeListArena):
(WebCore::PODFreeListArena::FreeListChunk::FreeListChunk):
(FreeListChunk):
(WebCore::PODFreeListArena::FreeListChunk::~FreeListChunk):
(WebCore::PODFreeListArena::FreeListChunk::allocate):

2:41 PM EnableFormFeatures edited by tkent@chromium.org
(diff)
2:37 PM FeatureFlags edited by tkent@chromium.org
Remove CALENDAR_PICKER, INPUT_MULTIPLE_FIELDS_UI, and PAGE_POPUP (diff)
2:28 PM Changeset in webkit [150931] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Move some PODArena members to PODFreeListArena
​https://bugs.webkit.org/show_bug.cgi?id=116993

Reviewed by Sam Weinig.

This is more work towards merging the two classes.

  • platform/PODArena.h:

(PODArena):

  • platform/PODFreeListArena.h:

(PODFreeListArena):
(WebCore::PODFreeListArena::PODFreeListArena):

2:28 PM Changeset in webkit [150930] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit/win

[Windows] Be consistent with allocation/deallocation behavior
​https://bugs.webkit.org/show_bug.cgi?id=116998

Reviewed by Anders Carlsson.

  • WebPreferences.cpp:

(WebPreferences::setStringValue): Switch from using _wcsdup and
CFStringCreateWithCharactersNoCopy to just use the standard
CFStringCreateWithCharacters call.

2:20 PM Changeset in webkit [150929] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

[Mac] Scrubbing long movie files results in timeline snapping back to 0 during scrub.
​https://bugs.webkit.org/show_bug.cgi?id=116986

Reviewed by Eric Carlson.

Source/WebCore:

Keep a count of the number of in-flight seek requests, and only issue a timeupdate
(which triggers a "seeked" event) when the final seek completes.

Test: media/video-seek-multiple.html

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::seek):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(MediaPlayerPrivateAVFoundation):

LayoutTests:

  • media/video-seek-multiple-expected.txt: Added.
  • media/video-seek-multiple.html: Added.
1:55 PM Changeset in webkit [150928] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

media/video-pause-immediately.html test failing on some platforms.
​https://bugs.webkit.org/show_bug.cgi?id=116985

video-pause-immediately.html will fail on some platforms if the <video> element issues a
timeupdate event at currentTime=0. Fix the test by only removing the timeupdate listener
inside the currentTime>0 conditional.

Reviewed by Eric Carlson.

  • media/video-pause-immediately.html:
1:43 PM Changeset in webkit [150927] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unused code from PODArena
​https://bugs.webkit.org/show_bug.cgi?id=116990

Reviewed by Sam Weinig.

PODArena is only used as a base class of PODFreeListArena so remove unused member functions and make all
members protected to make it impossible to use it without subclassing.

PODArena is a risky class to use since it doesn't return memory to the system unless the arena object is destroyed.
This was the reason why PODFreeListArea was added. An upcoming patch will merge PODArena with PODFreeListArena and
this is a small step towards that goal.

  • platform/PODArena.h:
12:48 PM Changeset in webkit [150926] by Darin Adler
  • 6 edits in trunk/Source/WebCore

Remove custom binding for Clipboard setDragImage function
​https://bugs.webkit.org/show_bug.cgi?id=116422

Reviewed by Sam Weinig.

  • bindings/js/JSClipboardCustom.cpp: Removed setDragImage binding.
  • dom/Clipboard.cpp:

(WebCore::Clipboard::canSetDragImage): Added a condition that this is a drag
and drop clipboard. That used to be checked in the setDragImage binding.
(WebCore::Clipboard::setDragImage): Added a version that takes an Element
and calls through to the existing functions (in the legacy code path), or handles
both the Element and HTMLImageElement not-in-document cases (in the new code path).

  • dom/Clipboard.h: Updated for changes above.
  • dom/Clipboard.idl: Removed [Custom] from setDragImage.
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag): Call the new setDragImage instead of the
old setDragImageElement.

12:43 PM Changeset in webkit [150925] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Return earlier if there's no session storage namespace
​https://bugs.webkit.org/show_bug.cgi?id=116984
<rdar://problem/13976781>

Reviewed by Tim Horton.

If we can't find a session storage namespace, return before creating an entry in the m_storageAreasByConnection
hash map since then we'll crash trying to remove it later.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createSessionStorageMap):

12:41 PM Changeset in webkit [150924] by commit-queue@webkit.org
  • 22 edits
    2 deletes in trunk

Cleanup AudioSourceNode.idl from WebKit build.
​https://bugs.webkit.org/show_bug.cgi?id=116905.

Patch by Praveen R Jadhav <​praveen.j@samsung.com> on 2013-05-29
Reviewed by Darin Adler.

AudioSourceNode.idl is not part of WebAudio Specifications anymore.
AudioNode is inherited directly in all the audio source nodes.

Source/WebCore:

No new tests. Current test cases will cover all the scenarios.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):

  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/AudioSourceNode.h: Removed.
  • Modules/webaudio/AudioSourceNode.idl: Removed.
  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):

  • Modules/webaudio/MediaElementAudioSourceNode.h:

(MediaElementAudioSourceNode):

  • Modules/webaudio/MediaElementAudioSourceNode.idl:
  • Modules/webaudio/MediaStreamAudioDestinationNode.idl:
  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):

  • Modules/webaudio/MediaStreamAudioSourceNode.h:

(MediaStreamAudioSourceNode):

  • Modules/webaudio/MediaStreamAudioSourceNode.idl:
  • Modules/webaudio/OscillatorNode.h:
  • Modules/webaudio/OscillatorNode.idl:
  • Target.pri:
  • WebCore.xcodeproj/project.pbxproj:

Tools:

  • Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
12:32 PM Changeset in webkit [150923] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add more cellular technologies into the NetworkInfo enum
​https://bugs.webkit.org/show_bug.cgi?id=116982

PR 340189
Patch by Otto Derek Cheung <​otcheung@rim.com> on 2013-05-29
Reviewed by Rob Buis.

Provide more specific bandwidth speeds on different network
services our devices provide.

  • WebCoreSupport/NetworkInfoClientBlackBerry.cpp:

(WebCore):
(WebCore::NetworkInfoClientBlackBerry::bandwidth):

12:26 PM Changeset in webkit [150922] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

Optimize RenderText::offsetNext for 8 bit strings
​https://bugs.webkit.org/show_bug.cgi?id=116877

Reviewed by Darin Adler.

Source/WebCore:

Previously, this function was always upconverting strings to 16 bits in
order to create a cursorMovementIterator. This patch adds a fast path
for ASCII and Latin-1 strings, which don't need this complicated cursor
movement logic.

I ran into this code because nextOffset showed up as a memory pig on a
memory profile of Mobile Gmail.

Test: editing/selection/move-by-character-brute-force.html

  • rendering/RenderText.cpp:

(WebCore::RenderText::previousOffset):
(WebCore::RenderText::nextOffset):

LayoutTests:

Test that caret movement works correctly for many code points.

  • editing/selection/move-by-character-brute-force-expected.txt: Added.
  • editing/selection/move-by-character-brute-force.html: Added.
12:24 PM Changeset in webkit [150921] by Martin Robinson
  • 5 edits in trunk

Fix more CMake GTK+ build issues after r150336

.:

  • Source/cmake/OptionsGTK.cmake: Actually set the new output name variable

and be sure to set WTF_USE_EGL when EGL is enabled.

Source/WebKit2:

  • CMakeLists.txt: We need to allow for setting the WebProcess output name, since

WebKitGTK+ expects it to be called WebKitWebProcess.

  • PlatformGTK.cmake: No longer set WebProcess_EXECUTABLE_NAME as it's been replaced

by WebKit2_WebProcess_OUTPUT_NAME.

12:23 PM Changeset in webkit [150920] by anlo@rim.com
  • 2 edits in trunk/Tools

Add Andrew Lo to contributors.json
​https://bugs.webkit.org/show_bug.cgi?id=116981

Reviewed by Rob Buis.

Adding Andrew Lo to contributors.json.

  • Scripts/webkitpy/common/config/contributors.json:
11:57 AM Changeset in webkit [150919] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[Windows] Correct copy command (form versus forms)

  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.vcxproj/copyForwardingHeaders.cmd:
11:57 AM Changeset in webkit [150918] by cavalcantii@gmail.com
  • 2 edits in trunk/Tools

Adding myself as a committer.

Signed-off-by: Adenilson Cavalcanti <​cavalcantii@gmail.com>

11:49 AM Changeset in webkit [150917] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

[CSS Shapes] Fix style issues in BasicShapes
​https://bugs.webkit.org/show_bug.cgi?id=116734

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-29
Reviewed by Alexandru Chiculita.

Fix indentation in BasicShapes.cpp, and change enums to respect the
style rules CamelCase instead of HAVING_UNDERSCORES.

No new tests, only style changes.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):

  • css/CSSBasicShapes.cpp:

(WebCore::buildRectangleString):
(WebCore::CSSBasicShapeRectangle::equals):
(WebCore::CSSBasicShapeCircle::equals):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::CSSBasicShapePolygon::equals):
(WebCore::CSSBasicShapeInsetRectangle::equals):

  • css/CSSBasicShapes.h:

(WebCore::CSSBasicShapeRectangle::type):
(WebCore::CSSBasicShapeInsetRectangle::type):
(WebCore::CSSBasicShapeCircle::type):
(WebCore::CSSBasicShapeEllipse::type):
(WebCore::CSSBasicShapePolygon::type):

  • rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape):

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::isEnabledFor):

  • rendering/ExclusionShapeOutsideInfo.cpp:

(WebCore::ExclusionShapeOutsideInfo::isEnabledFor):

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend):
(WebCore::BasicShapeRectangle::path):
(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapeInsetRectangle::path):

  • rendering/style/BasicShapes.h:

(WebCore::BasicShapeRectangle::type):
(WebCore::BasicShapeCircle::type):
(WebCore::BasicShapeEllipse::type):
(WebCore::BasicShapePolygon::type):
(WebCore::BasicShapeInsetRectangle::type):

11:46 AM Changeset in webkit [150916] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Handle Host-Only cookies
​https://bugs.webkit.org/show_bug.cgi?id=116969

PR 338809
Patch by Otto Derek Cheung <​otcheung@rim.com> on 2013-05-29
Reviewed by Rob Buis.
Internally Reviewed by Joe Mason.

Adding support for host-only cookies (cookies with no
specified domains). These cookies should only be returned
when the host matches the cookie domain exactly.

Tested using Opera and Browser cookie test suite. Tested
that host cookies are being stored in it's own map using
Web Inspector.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::findOrCreateCookieMap):

  • platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::CookieParser):
(WebCore::CookieParser::parseOneCookie):

  • platform/blackberry/ParsedCookie.h:

(WebCore::ParsedCookie::isHostOnly):
(ParsedCookie):

11:43 AM Changeset in webkit [150915] by yoli@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] about:memory should use malloc_stats instead of mallinfo
​https://bugs.webkit.org/show_bug.cgi?id=96420

Reviewed by Rob Buis.

PR 206297
Use mallopt to get malloc_stats.

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::mallocStats):
(BlackBerry::WebKit::memoryPage):
(BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):

11:39 AM Changeset in webkit [150914] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Notify client of selection deletion
​https://bugs.webkit.org/show_bug.cgi?id=116843

Patch by Nima Ghanavatian <​nghanavatian@blackberry.com> on 2013-05-29
Reviewed by Rob Buis.

Internally reviewed by Mike Fenton.

PR342106
Our change guard was preventing caret change notification to be sent to IMF.
This put us out of state when a selection was deleted because it is not a simple
single character deletion. Ensure that selection deletions always send a caret
update.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::deleteSelection):
(BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
(BlackBerry::WebKit::InputHandler::deleteText):

11:37 AM Changeset in webkit [150913] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use StringBuilder instead of + operator to build strings in AboutData
​https://bugs.webkit.org/show_bug.cgi?id=116954

Patch by Rob Buis <​rbuis@rim.com> on 2013-05-29
Reviewed by Carlos Garcia Campos.

PR 206152
Internally reviewed by Konrad Piascik

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::configPage):
(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
(BlackBerry::WebKit::mallocStats):
(BlackBerry::WebKit::memoryPage):
(BlackBerry::WebKit::memoryPeaksToHtmlTable):
(BlackBerry::WebKit::memoryLivePage):

11:37 AM Changeset in webkit [150912] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove the size of DataVector in HTMLToken
​https://bugs.webkit.org/show_bug.cgi?id=116931

Reviewed by Sam Weinig.

Merge ​https://chromium.googlesource.com/chromium/blink/+/7977721e62c471bfa17b84d82cd5d8243a4eb9a9.

Shink HTMLToken by 1.5 kB

HTMLToken has an inline vector for buffering characters during tokenization. We
originally picked the inline capacity of this buffer somewhat arbitrarily. This
CL tunes the number based on a somewhat non-scientific browse of a number of
popular web sites.

I (abarth) instrumented content_shell to log the length of each complete DataVector. I
then browsed around a variety of web sites to collect data. The 99% percentile
of DataVector lengths was just shy of 250 characters. I rounded that up to 256
because powers of two are pretty. That means we'll malloc an external buffer
less than 1% of the time, which seems fine.

  • html/parser/HTMLToken.h:

(HTMLToken):

11:28 AM Changeset in webkit [150911] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening, managing media layout tests failures on GTK WK2.

  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
11:15 AM Changeset in webkit [150910] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[Windows] Build correction after r150837

New 'forms' sub-folder of html needs to be included in
copy operations.

  • WebCore.vcproj/copyForwardingHeaders.cmd: copy html/forms.
  • WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters: Use correct

'obj32' folder for build output.

  • WebCore.vcxproj/copyForwardingHeaders.cmd: copy html/forms.
10:47 AM Changeset in webkit [150909] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Radio Button UX updates.
​https://bugs.webkit.org/show_bug.cgi?id=116881

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-05-29
Reviewed by Rob Buis.

BlackBerry PR 342322.
Internally Reviewed by Jeff Rogers.
Change images.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintRadio):

10:41 AM Changeset in webkit [150908] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Datetime string is not centred in form controls.
​https://bugs.webkit.org/show_bug.cgi?id=100760

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-05-29
Reviewed by Rob Buis.

BlackBerry PR 343512
Internally Reviewed by Jeff Rogers.

Adjust margin for inner text node of datetime form controls.

  • css/themeBlackBerry.css:

(input::-webkit-date-and-time-value):

10:23 AM Changeset in webkit [150907] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[Windows] Build correction after r150876

A clean build will now fail because the BaseMultipleFieldsDateAndTimeInputType sources have
been removed, but are still referenced in the project file.

  • WebCore.vcxproj/WebCore.vcxproj: Remove reference to BaseMultipleFieldsDateAndTimeInputType
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto
10:22 AM Changeset in webkit [150906] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, managing accessibility layout tests failures on GTK WK2.

  • platform/gtk-wk2/TestExpectations:
10:11 AM Changeset in webkit [150905] by jer.noble@apple.com
  • 6 edits
    4 adds in trunk

Support the 'onended' EventListener property for AudioBufferSourceNode and OscillatorNode.
​https://bugs.webkit.org/show_bug.cgi?id=116798

Reviewed by Eric Carlson.

Source/WebCore:

Tests: webaudio/audiobuffersource-ended.html

webaudio/oscillator-ended.html

  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
(WebCore::AudioScheduledSourceNode::setOnended): Set m_hasEndedListener.
(WebCore::AudioScheduledSourceNode::finish): Call notifyEndedDispatch on the main thread.
(WebCore::AudioScheduledSourceNode::notifyEndedDispatch): Call notifyEnded().
(WebCore::AudioScheduledSourceNode::notifyEnded): Call the onended event listener.

  • Modules/webaudio/AudioScheduledSourceNode.h:

(WebCore::AudioScheduledSourceNode::onended): Added boilerplate.

  • Modules/webaudio/AudioBufferSourceNode.idl: Added the onerror attribute.
  • Modules/webaudio/OscillatorNode.idl: Ditto.

LayoutTests:

  • webaudio/audiobuffersource-ended-expected.txt: Added.
  • webaudio/audiobuffersource-ended.html: Added.
  • webaudio/oscillator-ended-expected.txt: Added.
  • webaudio/oscillator-ended.html: Added.
9:54 AM Changeset in webkit [150904] by commit-queue@webkit.org
  • 16 edits in trunk

[CSS Shapes] Support parsing inset-rectangle shapes
​https://bugs.webkit.org/show_bug.cgi?id=116638

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-29
Reviewed by Dean Jackson.

Source/WebCore:

Add parsing for inset-rectangle. It's very similar to parsing for
rectangle.

No new tests, updated existing tests to cover this.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape): Add support for inset rectangles.
(WebCore::basicShapeForValue): Add support for inset rectangles.

  • css/CSSBasicShapes.cpp:

(WebCore::buildInsetRectangleString): Create an inset-rectangle css

string.

(WebCore::CSSBasicShapeInsetRectangle::cssText): Convert inset

rectangle shape to a CSS string.

(WebCore::CSSBasicShapeInsetRectangle::equals): Compare two inset

rectangles.

(WebCore::CSSBasicShapeInsetRectangle::serializeResolvingVariables):

Create an inset rectangle string, with CSS variables resolved.

(WebCore::CSSBasicShapeInsetRectangle::hasVariableReference):

Determine if this inset rectangle has any CSS Variable references.

  • css/CSSBasicShapes.h:

(CSSBasicShapeInsetRectangle): Add inset rectangle class. This is a

direct representation of the CSS property. All the methods below
are just simple getters and setters, along with a construtor and a
factory method.

(WebCore::CSSBasicShapeInsetRectangle::create):
(WebCore::CSSBasicShapeInsetRectangle::top):
(WebCore::CSSBasicShapeInsetRectangle::right):
(WebCore::CSSBasicShapeInsetRectangle::bottom):
(WebCore::CSSBasicShapeInsetRectangle::left):
(WebCore::CSSBasicShapeInsetRectangle::radiusX):
(WebCore::CSSBasicShapeInsetRectangle::radiusY):
(WebCore::CSSBasicShapeInsetRectangle::setTop):
(WebCore::CSSBasicShapeInsetRectangle::setRight):
(WebCore::CSSBasicShapeInsetRectangle::setBottom):
(WebCore::CSSBasicShapeInsetRectangle::setLeft):
(WebCore::CSSBasicShapeInsetRectangle::setRadiusX):
(WebCore::CSSBasicShapeInsetRectangle::setRadiusY):
(WebCore::CSSBasicShapeInsetRectangle::type):
(WebCore::CSSBasicShapeInsetRectangle::CSSBasicShapeInsetRectangle):
(WebCore):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseBasicShapeInsetRectangle): Parse the

inset-rectangle CSS property and create a
CSSBasicShapeInsetRectangle.

(WebCore::CSSParser::parseBasicShape): Add a call to parse

inset-rectangle.

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Disable

inset-rectangles, since only the parsing has been implemented so
far.

  • rendering/ExclusionShapeOutsideInfo.cpp:

(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Disable

inset-rectangles, since only the parsing has been implemented so
far.

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeInsetRectangle::path): Calculate the Path for an

inset-rectangle.

(WebCore::BasicShapeInsetRectangle::blend): Blend two inset rectangles

together at a point depending on the "progress" and return the
blended rectangle.

  • rendering/style/BasicShapes.h:

(BasicShapeInsetRectangle): Add higher level inset rectangle class.

This is used outside of the CSS representation. The methods below
are just simple getters and setters, along with a constructor and
a factory method.

(WebCore::BasicShapeInsetRectangle::create):
(WebCore::BasicShapeInsetRectangle::top):
(WebCore::BasicShapeInsetRectangle::right):
(WebCore::BasicShapeInsetRectangle::bottom):
(WebCore::BasicShapeInsetRectangle::left):
(WebCore::BasicShapeInsetRectangle::cornerRadiusX):
(WebCore::BasicShapeInsetRectangle::cornerRadiusY):
(WebCore::BasicShapeInsetRectangle::setTop):
(WebCore::BasicShapeInsetRectangle::setRight):
(WebCore::BasicShapeInsetRectangle::setBottom):
(WebCore::BasicShapeInsetRectangle::setLeft):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusY):
(WebCore::BasicShapeInsetRectangle::type):
(WebCore::BasicShapeInsetRectangle::BasicShapeInsetRectangle):

LayoutTests:

Updated to test for inset-rectangle cases.

  • fast/exclusions/parsing/parsing-shape-inside-expected.txt:
  • fast/exclusions/parsing/parsing-shape-lengths-expected.txt:
  • fast/exclusions/parsing/script-tests/parsing-shape-lengths.js:
  • fast/exclusions/parsing/script-tests/parsing-test-utils.js:
9:38 AM Changeset in webkit [150903] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source/WebCore

Merged r150898. <rdar://problem/14007430>

9:34 AM Changeset in webkit [150902] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebCore

Merged r150863. <rdar://problem/13991927>

9:30 AM Changeset in webkit [150901] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Move computed style extraction out of CSSComputedStyleDeclaration.
<​http://webkit.org/b/116965>

Reviewed by Antti Koivisto.

Make it possible to get computed CSSValues from a Node without creating a CSSOM
style declaration object.

The bulk of the logic moves to a new class; ComputedStyleExtractor, which can be created
on the stack, and takes the same setup variables as CSSComputedStyleDeclaration.

This is prep to enable futuristic optimizations in editing and elsewhere.

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Create a ComputedStyleExtractor to do the work!

(WebCore::ComputedStyleExtractor::currentColorOrValidColor):
(WebCore::ComputedStyleExtractor::valueForFilter):
(WebCore::ComputedStyleExtractor::ComputedStyleExtractor):
(WebCore::ComputedStyleExtractor::valueForShadow):
(WebCore::ComputedStyleExtractor::styledNode):
(WebCore::ComputedStyleExtractor::propertyValue):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForShorthandProperties):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForSidesShorthand):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForGridShorthand):
(WebCore::ComputedStyleExtractor::getBackgroundShorthandValue):

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::adjustSVGPaintForCurrentColor):
(WebCore::ComputedStyleExtractor::svgPropertyValue):

Moved all of these from CSSComputedStyleDeclaration to the new class.

  • rendering/style/RenderStyle.h:
  • svg/SVGPaint.h:

Have these two befriend ComputedStyleExtractor.

9:22 AM Changeset in webkit [150900] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Another attempt to fix windows build.

Not reviewed.

  • css/CSSFontSelector.h:
9:09 AM Changeset in webkit [150899] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Try to fix window build.

Not reviewed.

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionFontDataCacheKey::computeHash):

9:04 AM Changeset in webkit [150898] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Fix the firing of m_paintRelatedMilestonesTimer
​https://bugs.webkit.org/show_bug.cgi?id=116919

Reviewed by Tim Horton.

r150671 intended to change things so that paint-related milestones
only fire when painting has actually happened, so that WebKit clients
are notified when we actually have bits to present.

However, it made an incorrect assumption that painting would happen
inside of flushCompositingState(). This is not the case; flushCompositingState()
will just dirty CALayers, and later on Core Animation will ask us to paint them.

This incorrect assumption meant that we would never start the
m_paintRelatedMilestonesTimer, so never fire the milestones.

Fix by starting the m_paintRelatedMilestonesTimer via the RenderLayerBacking
paintContents call back. At this time we know we're painting, so we can both
set the FrameView's last paint time, and start up the timer. We also only
want to start the timer if there are pending milestones.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):
(WebCore::RenderLayerBacking::paintContents):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::didPaintBacking):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

8:49 AM Changeset in webkit [150897] by Antti Koivisto
  • 11 edits in trunk/Source/WebCore

Share FontGlyphs
​https://bugs.webkit.org/show_bug.cgi?id=116863

Reviewed by Anreas Kling.

Style system generates many Font objects that are identical or similar enough to have identical FontGlyphs.
We can figure out that the FontGlyphs are going to be the same and share them. This reduces memory usage.
It also improves performance as the glyph cache and the width cache hang from FontGlyphs and their hit rate
increases.

On PLT3 this takes the number of live FontGlyphs at the end from 40k+ to <1k. Width cache hit rate improves
from ~42% to ~55%.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):

Add unique id we can use in cache key.

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

Bump the version number on invalidation so we don't reuse cache entries after web font is loaded.

(WebCore::CSSFontSelector::resolvesFamilyFor):

Test if FontSelector is needed for resolving a particular FontDescription.

  • css/CSSFontSelector.h:
  • page/Settings.cpp:

(WebCore::setGenericFontFamilyMap):

Invalidate the cache if standard font settings change.

  • platform/graphics/Font.cpp:

(FontGlyphsCacheKey):
(FontGlyphsCacheEntry):
(WebCore::operator==):
(WebCore::fontGlyphsCache):
(WebCore::invalidateFontGlyphsCache):
(WebCore::makeFontSelectorFlags):
(WebCore::makeFontGlyphsCacheKey):

The cache key consists of


  • all families.
  • shared key with the lower level FontData cache (FontCache), guaranteeing FontDatas would be identical.
  • font selector specific keys.

These guarantee the FontData will be identical.

(WebCore::computeFontGlyphsCacheHash):
(WebCore::pruneUnreferencedFromFontGlyphsCache):

Don't accumulate unused entries.

(WebCore::retrieveOrAddCachedFontGlyphs):
(WebCore::Font::update):

  • platform/graphics/Font.h:
  • platform/graphics/FontCache.cpp:

(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
(WebCore::FontPlatformDataCacheKey::operator==):
(FontPlatformDataCacheKey):
(WebCore::computeHash):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::invalidate):

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionFontDataCacheKey::FontDescriptionFontDataCacheKey):
(WebCore::FontDescriptionFontDataCacheKey::makeFlagKey):
(WebCore::FontDescriptionFontDataCacheKey::operator==):
(WebCore::FontDescriptionFontDataCacheKey::operator!=):
(WebCore::FontDescriptionFontDataCacheKey::computeHash):

Separate part of the key for sharing.

(FontDescriptionFontDataCacheKey):

  • platform/graphics/FontFallbackList.cpp:

(WebCore::FontGlyphs::FontGlyphs):
(WebCore::FontGlyphs::releaseFontData):

  • platform/graphics/FontFallbackList.h:

(WebCore::FontGlyphs::create):
(WebCore::FontGlyphs::~FontGlyphs):

Remove invalidate(). If FontGlyphs needs invalidation it is reconstructed.

  • platform/graphics/FontSelector.h:
8:37 AM Changeset in webkit [150896] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use lazily-backed backingstore tiles
​https://bugs.webkit.org/show_bug.cgi?id=116879
Internal PR 344523

Patch by Jakob Petsovits <​jpetsovits@blackberry.com> on 2013-05-29
Reviewed by Carlos Garcia Campos.
Informally reviewed by Arvid Nilsson and Mike Lattanzio.

As a consequence, also don't use fixed-size
shared pixmap buffers for these tiles anymore.

  • WebKitSupport/AboutData.cpp:

(BlackBerry::WebKit::configPage):

  • WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::TileBuffer::nativeBuffer):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::initialize):

  • WebKitSupport/SurfacePool.h:

(SurfacePool):

8:24 AM Changeset in webkit [150895] by Simon Hausmann
  • 2 edits
    1 add in trunk/Source/WebKit/qt

[Qt] Add all plugins.qmltypes files and update qmldir files

Patch by Liang Qi <​liang.qi@digia.com> on 2013-05-29
Reviewed by Simon Hausmann.

These are required for code completion in Qt Creator.

  • declarative/plugins.qmltypes: Added.
  • declarative/qmldir:
8:23 AM Changeset in webkit [150894] by thakis@chromium.org
  • 1 edit
    1 delete in trunk/Source/WebCore

Remove unused file PlatformGestureEvent.cpp
​https://bugs.webkit.org/show_bug.cgi?id=116894

Reviewed by Darin Adler.

This was added in ​https://bugs.webkit.org/show_bug.cgi?id=49345 but
not removed in ​https://bugs.webkit.org/show_bug.cgi?id=77492 which
removed most of that code again.

  • platform/PlatformGestureRecognizer.cpp: Removed.
7:34 AM Changeset in webkit [150893] by marcelo.lira@openbossa.org
  • 8 edits
    2 adds in trunk

[WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
​https://bugs.webkit.org/show_bug.cgi?id=116683

Reviewed by Noam Rosenthal.

Source/WebKit2:

WKViewUserViewportToContents now converts WebView coordinates to
page contents coordinates, taking into account factors as content
scale and scroll, and also device scale.

The function WKViewUserViewportToScene was added to convert WebView
coordinates to the coordinates of the canvas/scene where the view
is drawn, and EwkView was fixed to use it, instead of
WKViewUserViewportToContents.

  • UIProcess/API/C/CoordinatedGraphics/WKView.cpp:

(WKViewUserViewportToScene):

  • UIProcess/API/C/CoordinatedGraphics/WKView.h:
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::createGLSurface):

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::userViewportToContents):
(WebKit):
(WebKit::WebView::userViewportToScene):
(WebKit::WebView::transformToScene):

  • UIProcess/CoordinatedGraphics/WebView.h:

(WebView):

Tools:

A coordinates conversion test for WKViewUserViewportToContents was
added to WebKit2 API tests.

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

7:21 AM Changeset in webkit [150892] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Unskipping passing test.
​https://bugs.webkit.org/show_bug.cgi?id=70907
​https://bugs.webkit.org/show_bug.cgi?id=93231
​https://bugs.webkit.org/show_bug.cgi?id=89645
​https://bugs.webkit.org/show_bug.cgi?id=109291
​https://bugs.webkit.org/show_bug.cgi?id=92543
​https://bugs.webkit.org/show_bug.cgi?id=82895
​https://bugs.webkit.org/show_bug.cgi?id=87395
​https://bugs.webkit.org/show_bug.cgi?id=87631
​https://bugs.webkit.org/show_bug.cgi?id=89473
​https://bugs.webkit.org/show_bug.cgi?id=92490

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-05-29

  • platform/qt-5.0-wk2/TestExpectations:
7:18 AM Changeset in webkit [150891] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Update my info.

Patch by Yong Li <​yong.li.webkit@outlook.com> on 2013-05-29

  • Scripts/webkitpy/common/config/contributors.json:
6:24 AM Changeset in webkit [150890] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[texmap][GStreamer][GTK] Composited Video support
​https://bugs.webkit.org/show_bug.cgi?id=86410

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2013-05-29
Reviewed by Noam Rosenthal.

Enable the video accelerated compositing using the WebKit's
TextureMapper.

This patch does not use hardware accelerated video decoding. It
provides a generic path for system memory buffers.

This new functionality is only available when the coordinated graphics
system is not used.

No new tests, already covered by existing tests.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): update the
texture content with the new received video buffer.
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint): choose to
use the accelerated compositing or the normal code path
(WebCore::MediaPlayerPrivateGStreamerBase::paint): if accelerated
compositing is used this method is halted.
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper): get
a texture from the pool and draws it if it is already available.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

(MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::platformLayer): returns itself
(WebCore::MediaPlayerPrivateGStreamerBase::supportsAcceleratedRendering):
returns true

6:19 AM Changeset in webkit [150889] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.
Adding flaky failure expectations for two perf/ layout tests.

  • platform/gtk/TestExpectations:
6:05 AM Changeset in webkit [150888] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.1.1

Tagging the WebKitGTK+ 2.1.1 release

5:53 AM Changeset in webkit [150887] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk-wk1/TestExpectations: Remove an unnecessary expectation.
  • platform/gtk/TestExpectations: Add timeout expectations for tests that are currently timing out.
5:43 AM Changeset in webkit [150886] by dongseong.hwang@intel.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as committer in contributors.json.

  • Scripts/webkitpy/common/config/contributors.json:
5:19 AM Changeset in webkit [150885] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and Versions.m4 for 2.1.1 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 2.1.1.
5:15 AM Changeset in webkit [150884] by Carlos Garcia Campos
  • 6 edits in trunk

Unreviewed. Fix make distcheck.

.:

DISTCLEANFILES.

Source/WebKit2:

  • GNUmakefile.am: Add WebCoreLayerGtk2.a to DISTCLEANFILES.

Tools:

  • TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to

DISTCLEANFILES.

4:51 AM Changeset in webkit [150883] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed: update my email address in contributors.json.

Patch by Mary Wu <​mawu@blackberry.com> on 2013-05-29

  • Scripts/webkitpy/common/config/contributors.json:
4:01 AM Changeset in webkit [150882] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Missing files from build after r150853
​https://bugs.webkit.org/show_bug.cgi?id=116932

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2013-05-29
Reviewed by Csaba Osztrogonác.

  • Target.pri: Added missing include path.
3:57 AM Changeset in webkit [150881] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

[CSS Regions] Content that has overflow: scroll cannot be scrolled by dragging the scroll thumbs with the mouse
​https://bugs.webkit.org/show_bug.cgi?id=113703

Patch by Mihai Maerean <Mihai Maerean> on 2013-05-29
Reviewed by Darin Adler.

Source/WebCore:

The point inside a box that's inside a region has its coordinates relative to the region, not the FlowThread
that is its container in the RenderObject tree.

Previously, the coordinates were computed relatively to the FlowThread which doesn't really have a location in
the page.

Tests: fast/regions/drag-scrollbars-of-content.html

fast/regions/hover-in-second-region.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::offsetFromContainer):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

LayoutTests:

  • fast/regions/drag-scrollbars-of-content-expected.html: Added.
  • fast/regions/drag-scrollbars-of-content.html: Added.
  • fast/regions/hover-in-second-region-expected.html: Added.
  • fast/regions/hover-in-second-region.html: Added.
3:20 AM Changeset in webkit [150880] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix dumb typo in r150879.

  • editing/htmlediting.cpp:

(WebCore::nextLeafNode):

1:57 AM Changeset in webkit [150879] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Move leaf Node traversal helpers to htmlediting.cpp
<​http://webkit.org/b/116940>

Reviewed by Antti Koivisto.

Move Node::previousLeafNode() and Node::nextLeafNode() to htmlediting.cpp along with their helpers.
Fixes an 8-year old FIXME. \o/

  • dom/Node.h:
  • dom/Node.cpp:
  • dom/Position.cpp:

(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):

  • editing/VisibleUnits.cpp:

(WebCore::previousLeafWithSameEditability):
(WebCore::nextLeafWithSameEditability):

  • editing/htmlediting.h:
  • editing/htmlediting.cpp:

(WebCore::previousNodeConsideringAtomicNodes):
(WebCore::nextNodeConsideringAtomicNodes):
(WebCore::previousLeafNode):
(WebCore::nextLeafNode):

1:56 AM Changeset in webkit [150878] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Missing files from build after r150853
​https://bugs.webkit.org/show_bug.cgi?id=116932

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2013-05-29
Reviewed by Csaba Osztrogonác.

  • Target.pri: Added the CFURLExtras.{cpp,h} files to the projectfile.
1:53 AM Changeset in webkit [150877] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

PresentationAttributeCacheCleaner::m_hitCount is never initialized
​https://bugs.webkit.org/show_bug.cgi?id=116946

Reviewed by Andreas Kling.

Merge ​https://chromium.googlesource.com/chromium/blink/+/70be7ddc41141ef6dec7795d37842c27dab2e194.

  • dom/StyledElement.cpp:

(WebCore::PresentationAttributeCacheCleaner::PresentationAttributeCacheCleaner):

1:47 AM Changeset in webkit [150876] by tkent@chromium.org
  • 47 edits
    228 deletes in trunk

Remove ENABLE_INPUT_MULTIPLE_FIELDS_UI.
​https://bugs.webkit.org/show_bug.cgi?id=116796

Reviewed by Ryosuke Niwa.

Source/WebCore:

This feature was used only by Chromium port.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/html.css:

(input::-webkit-date-and-time-value):

  • dom/Element.cpp:
  • dom/Element.h:
  • html/BaseChooserOnlyDateAndTimeInputType.cpp:
  • html/BaseChooserOnlyDateAndTimeInputType.h:
  • html/BaseMultipleFieldsDateAndTimeInputType.cpp: Removed.
  • html/BaseMultipleFieldsDateAndTimeInputType.h: Removed.
  • html/DateInputType.cpp:
  • html/DateInputType.h:

(DateInputType):

  • html/DateTimeFieldsState.cpp: Removed.
  • html/DateTimeFieldsState.h: Removed.
  • html/DateTimeInputType.cpp:
  • html/DateTimeInputType.h:

(DateTimeInputType):

  • html/DateTimeLocalInputType.cpp:
  • html/DateTimeLocalInputType.h:

(DateTimeLocalInputType):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:
  • html/InputType.h:

(InputType):

  • html/MonthInputType.cpp:
  • html/MonthInputType.h:

(MonthInputType):

  • html/TimeInputType.cpp:
  • html/TimeInputType.h:

(TimeInputType):

  • html/WeekInputType.cpp:
  • html/WeekInputType.h:

(WeekInputType):

  • html/shadow/ClearButtonElement.cpp: Removed.
  • html/shadow/ClearButtonElement.h: Removed.
  • html/shadow/DateTimeEditElement.cpp: Removed.
  • html/shadow/DateTimeEditElement.h: Removed.
  • html/shadow/DateTimeFieldElement.cpp: Removed.
  • html/shadow/DateTimeFieldElement.h: Removed.
  • html/shadow/DateTimeFieldElements.cpp: Removed.
  • html/shadow/DateTimeFieldElements.h: Removed.
  • html/shadow/DateTimeNumericFieldElement.cpp: Removed.
  • html/shadow/DateTimeNumericFieldElement.h: Removed.
  • html/shadow/DateTimeSymbolicFieldElement.cpp: Removed.
  • html/shadow/DateTimeSymbolicFieldElement.h: Removed.
  • html/shadow/PickerIndicatorElement.cpp: Removed.
  • html/shadow/PickerIndicatorElement.h: Removed.
  • page/ChromeClient.h:

(ChromeClient):

  • platform/LocalizedStrings.h:

(WebCore):

  • platform/text/PlatformLocale.cpp:
  • platform/text/PlatformLocale.h:

(Locale):

  • rendering/RenderDetailsMarker.cpp:
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderObject.h:

(RenderObject):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WTF:

  • wtf/FeatureDefines.h:

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-blur-and-focus-events-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-blur-and-focus-events.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-fallback-format-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-focus-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-focus.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-mouse-events-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-reset-value-after-reloads.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-validity-badinput-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-validity-badinput.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-wheel-event-expected.txt: Removed.
  • fast/forms/date-multiple-fields/date-multiple-fields-wheel-event.html: Removed.
  • fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
  • fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format-expected.txt: Removed.
  • fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format.html: Removed.
  • fast/forms/datetime-multiple-fields/datetime-multiple-fields-validity-badinput-expected.txt: Removed.
  • fast/forms/datetime-multiple-fields/datetime-multiple-fields-validity-badinput.html: Removed.
  • fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt: Removed.
  • fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-aria-attributes-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-aria-attributes.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-blur-and-focus-events-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-blur-and-focus-events.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-change-layout-by-value-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-change-layout-by-value.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-reset-value-after-reloads.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-spinbutton-change-and-input-events.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-validity-badinput-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-validity-badinput.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-wheel-event-expected.txt: Removed.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-wheel-event.html: Removed.
  • fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-blur-and-focus-events-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-blur-and-focus-events.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-change-layout-by-value-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-change-layout-by-value.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-fallback-format-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-mouse-events-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-reset-value-after-reloads.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-validity-badinput-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-validity-badinput.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-wheel-event-expected.txt: Removed.
  • fast/forms/month-multiple-fields/month-multiple-fields-wheel-event.html: Removed.
  • fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
  • fast/forms/time-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-blur-and-focus-events-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-blur-and-focus-events.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-change-layout-by-value-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-change-layout-by-value.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-change-type-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-2-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-2.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-change-type.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-fallback-format-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-focus-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-focus-style-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-focus.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-localization.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-losing-renderer-on-click-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-losing-renderer-on-click.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-reset-value-after-reload-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-reset-value-after-reload.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-static-relayout-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-static-relayout.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-step-attribute-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-step-attribute.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-tabindex-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-validity-badinput-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-validity-badinput.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-wheel-event-expected.txt: Removed.
  • fast/forms/time-multiple-fields/time-multiple-fields-wheel-event.html: Removed.
  • fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-blur-and-focus-events-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-blur-and-focus-events.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-change-layout-by-value-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-change-layout-by-value.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-fallback-format-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-mouse-events-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-mouse-events.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-reset-value-after-reloads.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-validity-badinput-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-validity-badinput.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-wheel-event-expected.txt: Removed.
  • fast/forms/week-multiple-fields/week-multiple-fields-wheel-event.html: Removed.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
1:36 AM Changeset in webkit [150875] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove SnowLeopard expected results.

Rubber-stamped by Andreas Kling.

  • platform/mac-snowleopard: Removed.
  • platform/mac-snowleopard/animations: Removed.
  • platform/mac-snowleopard/canvas: Removed.
  • platform/mac-snowleopard/canvas/philip: Removed.
  • platform/mac-snowleopard/canvas/philip/tests: Removed.
  • platform/mac-snowleopard/compositing: Removed.
  • platform/mac-snowleopard/compositing/color-matching: Removed.
  • platform/mac-snowleopard/compositing/framesets: Removed.
  • platform/mac-snowleopard/compositing/geometry: Removed.
  • platform/mac-snowleopard/compositing/iframes: Removed.
  • platform/mac-snowleopard/compositing/images: Removed.
  • platform/mac-snowleopard/compositing/layer-creation: Removed.
  • platform/mac-snowleopard/compositing/masks: Removed.
  • platform/mac-snowleopard/compositing/overflow: Removed.
  • platform/mac-snowleopard/compositing/reflections: Removed.
  • platform/mac-snowleopard/compositing/repaint: Removed.
  • platform/mac-snowleopard/compositing/scaling: Removed.
  • platform/mac-snowleopard/compositing/shadows: Removed.
  • platform/mac-snowleopard/compositing/tiling: Removed.
  • platform/mac-snowleopard/compositing/transitions: Removed.
  • platform/mac-snowleopard/compositing/video: Removed.
  • platform/mac-snowleopard/compositing/visibility: Removed.
  • platform/mac-snowleopard/compositing/webgl: Removed.
  • platform/mac-snowleopard/css1: Removed.
  • platform/mac-snowleopard/css1/box_properties: Removed.
  • platform/mac-snowleopard/css1/cascade: Removed.
  • platform/mac-snowleopard/css1/classification: Removed.
  • platform/mac-snowleopard/css1/color_and_background: Removed.
  • platform/mac-snowleopard/css1/font_properties: Removed.
  • platform/mac-snowleopard/css1/formatting_model: Removed.
  • platform/mac-snowleopard/css1/pseudo: Removed.
  • platform/mac-snowleopard/css1/text_properties: Removed.
  • platform/mac-snowleopard/css1/units: Removed.
  • platform/mac-snowleopard/css2.1: Removed.
  • platform/mac-snowleopard/css2.1/20110323: Removed.
  • platform/mac-snowleopard/css3: Removed.
  • platform/mac-snowleopard/css3/filters: Removed.
  • platform/mac-snowleopard/css3/flexbox: Removed.
  • platform/mac-snowleopard/css3/images: Removed.
  • platform/mac-snowleopard/css3/selectors3: Removed.
  • platform/mac-snowleopard/css3/selectors3/html: Removed.
  • platform/mac-snowleopard/css3/selectors3/xhtml: Removed.
  • platform/mac-snowleopard/css3/selectors3/xml: Removed.
  • platform/mac-snowleopard/editing: Removed.
  • platform/mac-snowleopard/editing/input: Removed.
  • platform/mac-snowleopard/editing/inserting: Removed.
  • platform/mac-snowleopard/editing/pasteboard: Removed.
  • platform/mac-snowleopard/editing/selection: Removed.
  • platform/mac-snowleopard/editing/unsupported-content: Removed.
  • platform/mac-snowleopard/fast: Removed.
  • platform/mac-snowleopard/fast/backgrounds: Removed.
  • platform/mac-snowleopard/fast/backgrounds/repeat: Removed.
  • platform/mac-snowleopard/fast/backgrounds/size: Removed.
  • platform/mac-snowleopard/fast/block: Removed.
  • platform/mac-snowleopard/fast/block/basic: Removed.
  • platform/mac-snowleopard/fast/block/float: Removed.
  • platform/mac-snowleopard/fast/block/margin-collapse: Removed.
  • platform/mac-snowleopard/fast/block/positioning: Removed.
  • platform/mac-snowleopard/fast/borders: Removed.
  • platform/mac-snowleopard/fast/canvas: Removed.
  • platform/mac-snowleopard/fast/css: Removed.
  • platform/mac-snowleopard/fast/dom: Removed.
  • platform/mac-snowleopard/fast/encoding: Removed.
  • platform/mac-snowleopard/fast/forms: Removed.
  • platform/mac-snowleopard/fast/forms/file: Removed.
  • platform/mac-snowleopard/fast/forms/range: Removed.
  • platform/mac-snowleopard/fast/gradients: Removed.
  • platform/mac-snowleopard/fast/images: Removed.
  • platform/mac-snowleopard/fast/inline: Removed.
  • platform/mac-snowleopard/fast/layers: Removed.
  • platform/mac-snowleopard/fast/lists: Removed.
  • platform/mac-snowleopard/fast/multicol: Removed.
  • platform/mac-snowleopard/fast/multicol/span: Removed.
  • platform/mac-snowleopard/fast/multicol/vertical-lr: Removed.
  • platform/mac-snowleopard/fast/multicol/vertical-rl: Removed.
  • platform/mac-snowleopard/fast/overflow: Removed.
  • platform/mac-snowleopard/fast/parser: Removed.
  • platform/mac-snowleopard/fast/preloader: Removed.
  • platform/mac-snowleopard/fast/reflections: Removed.
  • platform/mac-snowleopard/fast/repaint: Removed.
  • platform/mac-snowleopard/fast/replaced: Removed.
  • platform/mac-snowleopard/fast/ruby: Removed.
  • platform/mac-snowleopard/fast/selectors: Removed.
  • platform/mac-snowleopard/fast/table: Removed.
  • platform/mac-snowleopard/fast/text: Removed.
  • platform/mac-snowleopard/fast/text/international: Removed.
  • platform/mac-snowleopard/fast/text/whitespace: Removed.
  • platform/mac-snowleopard/fast/writing-mode: Removed.
  • platform/mac-snowleopard/fast/xsl: Removed.
  • platform/mac-snowleopard/fonts: Removed.
  • platform/mac-snowleopard/fullscreen: Removed.
  • platform/mac-snowleopard/http: Removed.
  • platform/mac-snowleopard/http/tests: Removed.
  • platform/mac-snowleopard/http/tests/inspector: Removed.
  • platform/mac-snowleopard/http/tests/security: Removed.
  • platform/mac-snowleopard/http/tests/security/contentSecurityPolicy: Removed.
  • platform/mac-snowleopard/http/tests/xmlhttprequest: Removed.
  • platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps: Removed.
  • platform/mac-snowleopard/mathml: Removed.
  • platform/mac-snowleopard/media: Removed.
  • platform/mac-snowleopard/platform: Removed.
  • platform/mac-snowleopard/platform/mac: Removed.
  • platform/mac-snowleopard/platform/mac/compositing: Removed.
  • platform/mac-snowleopard/platform/mac/compositing/canvas: Removed.
  • platform/mac-snowleopard/platform/mac/editing: Removed.
  • platform/mac-snowleopard/platform/mac/editing/selection: Removed.
  • platform/mac-snowleopard/platform/mac/fast: Removed.
  • platform/mac-snowleopard/platform/mac/fast/loader: Removed.
  • platform/mac-snowleopard/platform/mac/fast/text: Removed.
  • platform/mac-snowleopard/platform/mac/fast/text/international: Removed.
  • platform/mac-snowleopard/platform/mac/scrollbars: Removed.
  • platform/mac-snowleopard/plugins: Removed.
  • platform/mac-snowleopard/printing: Removed.
  • platform/mac-snowleopard/scrollbars: Removed.
  • platform/mac-snowleopard/sputnik: Removed.
  • platform/mac-snowleopard/sputnik/Unicode: Removed.
  • platform/mac-snowleopard/svg: Removed.
  • platform/mac-snowleopard/svg/W3C-I18N: Removed.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1: Removed.
  • platform/mac-snowleopard/svg/W3C-SVG-1.1-SE: Removed.
  • platform/mac-snowleopard/svg/as-background-image: Removed.
  • platform/mac-snowleopard/svg/as-border-image: Removed.
  • platform/mac-snowleopard/svg/as-image: Removed.
  • platform/mac-snowleopard/svg/as-object: Removed.
  • platform/mac-snowleopard/svg/batik: Removed.
  • platform/mac-snowleopard/svg/batik/paints: Removed.
  • platform/mac-snowleopard/svg/carto.net: Removed.
  • platform/mac-snowleopard/svg/clip-path: Removed.
  • platform/mac-snowleopard/svg/css: Removed.
  • platform/mac-snowleopard/svg/custom: Removed.
  • platform/mac-snowleopard/svg/dom: Removed.
  • platform/mac-snowleopard/svg/dynamic-updates: Removed.
  • platform/mac-snowleopard/svg/filters: Removed.
  • platform/mac-snowleopard/svg/foreignObject: Removed.
  • platform/mac-snowleopard/svg/hixie: Removed.
  • platform/mac-snowleopard/svg/hixie/data-types: Removed.
  • platform/mac-snowleopard/svg/hixie/error: Removed.
  • platform/mac-snowleopard/svg/hixie/intrinsic: Removed.
  • platform/mac-snowleopard/svg/hixie/mixed: Removed.
  • platform/mac-snowleopard/svg/hixie/perf: Removed.
  • platform/mac-snowleopard/svg/hixie/processing-model: Removed.
  • platform/mac-snowleopard/svg/hixie/rendering-model: Removed.
  • platform/mac-snowleopard/svg/hixie/text: Removed.
  • platform/mac-snowleopard/svg/hixie/viewbox: Removed.
  • platform/mac-snowleopard/svg/hixie/viewbox/preserveAspectRatio: Removed.
  • platform/mac-snowleopard/svg/in-html: Removed.
  • platform/mac-snowleopard/svg/overflow: Removed.
  • platform/mac-snowleopard/svg/repaint: Removed.
  • platform/mac-snowleopard/svg/text: Removed.
  • platform/mac-snowleopard/svg/transforms: Removed.
  • platform/mac-snowleopard/svg/webarchive: Removed.
  • platform/mac-snowleopard/svg/wicd: Removed.
  • platform/mac-snowleopard/svg/zoom: Removed.
  • platform/mac-snowleopard/svg/zoom/page: Removed.
  • platform/mac-snowleopard/tables: Removed.
  • platform/mac-snowleopard/tables/mozilla: Removed.
  • platform/mac-snowleopard/tables/mozilla/bugs: Removed.
  • platform/mac-snowleopard/tables/mozilla/collapsing_borders: Removed.
  • platform/mac-snowleopard/tables/mozilla/core: Removed.
  • platform/mac-snowleopard/tables/mozilla/marvin: Removed.
  • platform/mac-snowleopard/tables/mozilla/other: Removed.
  • platform/mac-snowleopard/transforms: Removed.
  • platform/mac-snowleopard/transforms/2d: Removed.
  • platform/mac-snowleopard/transforms/3d: Removed.
  • platform/mac-snowleopard/transforms/3d/general: Removed.
  • platform/mac-snowleopard/transforms/3d/point-mapping: Removed.
  • platform/mac-snowleopard/webarchive: Removed.
1:23 AM Changeset in webkit [150874] by kalyan.kondapally@intel.com
  • 2 edits in trunk/Tools

adding myself to committers list

12:49 AM Changeset in webkit [150873] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove setFullScreenRendererSize and setFullScreenRendererBackgroundColor
​https://bugs.webkit.org/show_bug.cgi?id=116914

Reviewed by Benjamin Poulain.

Merge ​https://chromium.googlesource.com/chromium/blink/+/508eb21a07f69ed38b9be9ff92fe75dcb907861f

  • dom/Document.cpp:
  • dom/Document.h:
12:46 AM Changeset in webkit [150872] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Make WidgetHierarchyUpdatesSuspensionScope use swap instead of copy
​https://bugs.webkit.org/show_bug.cgi?id=116927

Reviewed by Andreas Kling.

Merge ​https://chromium.googlesource.com/chromium/blink/+/1d577e1fd5c5716a06e4007e04fc3d9d0a88f5e4

This is equivalent behavior code that is unambiguously better performance. swap is O(1) time and memory,
copying a hash table is at least linear with the number of elements.

  • rendering/RenderWidget.cpp:

(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):

12:43 AM Changeset in webkit [150871] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove Document::nodeAbsIndex() and Document::nodeWithAbsIndex().

Rubber-stamped by Antti "Lucky" Koivisto.

  • dom/Document.h:
  • dom/Document.cpp:
12:39 AM Changeset in webkit [150870] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Clean up WebKit2 GNUmakefile.am
​https://bugs.webkit.org/show_bug.cgi?id=116907

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-29
Reviewed by Martin Robinson.

Removed WebNotificationManagerProxy.messages.in after r150785.

  • GNUmakefile.am:
12:36 AM Changeset in webkit [150869] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

FocusController should operate on Elements internally.
<​http://webkit.org/b/116781>

Reviewed by Antti Koivisto.

Switch from Node* to Element* as much as possible inside FocusController.
Mostly mechanical, gets rid of some unnecessary isElementNode() checks and casts.

  • page/FocusController.h:
  • page/FocusController.cpp:

(WebCore::dispatchEventsOnWindowAndFocusedElement):
(WebCore::isNonFocusableShadowHost):
(WebCore::adjustedTabIndex):
(WebCore::shouldVisit):
(WebCore::FocusController::setFocused):
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
(WebCore::FocusController::findFocusableElementRecursively):
(WebCore::FocusController::findFocusableElement):
(WebCore::FocusController::nextFocusableElement):
(WebCore::FocusController::previousFocusableElement):
(WebCore::FocusController::setActive):

12:18 AM Changeset in webkit [150868] by commit-queue@webkit.org
  • 4 edits
    10 adds in trunk

[CSS Regions] Mouse over an element does not trigger :hover state for parent when the element is flowed in a region
​https://bugs.webkit.org/show_bug.cgi?id=111749

Patch by Radu Stavila <​stavila@adobe.com> on 2013-05-29
Reviewed by Antti Koivisto.

Source/WebCore:

When searching for the hover ancestor and encountering a named flow thread,
the search will continue with the DOM ancestor of the top-most element
in the named flow thread.

Tests: fast/regions/hover-in-region-grandparent.html

fast/regions/hover-in-region-parent-skip.html
fast/regions/hover-in-region-parent-skip-inlines-anonymous.html
fast/regions/hover-on-child-in-region.html
fast/regions/hover-on-child-in-region-in-region.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::hoverAncestor):

  • rendering/RenderObject.h:

LayoutTests:

  • fast/regions/hover-in-region-grandparent-expected.txt: Added.
  • fast/regions/hover-in-region-grandparent.html: Added.
  • fast/regions/hover-in-region-parent-skip-expected.txt: Added.
  • fast/regions/hover-in-region-parent-skip.html: Added.
  • fast/regions/hover-in-region-parent-skip-inlines-anonymous-expected.txt: Added.
  • fast/regions/hover-in-region-parent-skip-inlines-anonymous.html: Added.
  • fast/regions/hover-on-child-in-region-expected.txt: Added.
  • fast/regions/hover-on-child-in-region.html: Added.
  • fast/regions/hover-on-child-in-region-in-region-expected.txt: Added.
  • fast/regions/hover-on-child-in-region-in-region.html: Added.

May 28, 2013:

10:29 PM Changeset in webkit [150867] by Nate Chapin
  • 7 edits in trunk/Source/WebCore

Crash in WebCore::SubresourceLoader::releaseResources when connection fails
​https://bugs.webkit.org/show_bug.cgi?id=87743

Don't do anything complicated in SubresourceLoader::releaseResources(),
just clear variables. With this patch, releaseResources() will still
assert in debug builds if it is called twice, but it will safely execute
in release.

Reviewed by Darin Adler.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::cleanupForError): Pull shared cleanup code out of didFail()

and cancel() into a helper.

(WebCore::ResourceLoader::cancel): Merge a couple variables into an enum, check for

reentrancy from within didCancel().

  • loader/ResourceLoader.h: Replace m_calledWillCancel and m_cancelled with an enum.
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading): Don't call ResourceLoader::didFinishLoading(),

put finish() in the middle of the process.

(WebCore::SubresourceLoader::didFail): Don't call ResourceLoader::didFail(), put finish()

in the middle of the process.

(WebCore::SubresourceLoader::didCancel):
(WebCore::SubresourceLoader::notifyDone): Do the non-trivial work previous done in releaseResources(),

most importantly calling loadDone().

(WebCore::SubresourceLoader::releaseResources): Only do simple variable clearing here.

  • loader/SubresourceLoader.h:

(SubresourceLoader):

  • loader/cache/CachedResource.cpp: Split stopLoading() into cancelLoad() (which notifies clients)

and clearLoader() (which just nulls m_loader).

  • loader/cache/CachedResource.h:
  • loader/chromium/ResourceLoaderChromium.cpp:
10:29 PM Changeset in webkit [150866] by a.bah@samsung.com
  • 2 edits in trunk/Tools

Unreviewed: Adding myself to committers list.

10:21 PM Changeset in webkit [150865] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[GTK] Build fix after r150837
​https://bugs.webkit.org/show_bug.cgi?id=116904

Unreviewed build fix.

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-28

  • GNUmakefile.am:
10:04 PM Changeset in webkit [150864] by Lucas Forschler
  • 2 edits in tags/Safari-537.43.2a/Source/WebCore

Merged r150863. <rdar://problem/13991927>

9:56 PM Changeset in webkit [150863] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r150169): Images from file: URLs display after a delay even though they were preloaded by JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=116906
<rdar://problem/13991927>

Reviewed by Andreas Kling.

Writing a test for this is blocked on ​https://webkit.org/b/116199.

Some WebKit clients use JavaScript to preload images from disk so that
subsequent loads will display immediately from the memory cache. By not
caching non-HTTP sub-resources in memory, we break this common pattern.
This change restricts r150169 to only apply to cached main resources.
Sub-resources will again be cached indefinitely as they were prior to
r150169.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::freshnessLifetime): If this is a non-HTTP
main resource from a scheme that should not be cached indefinitely,
return 0 for the freshness lifetime. For other non-HTTP cached
resources, return an indefinite freshness lifetime.

8:14 PM Changeset in webkit [150862] by dino@apple.com
  • 3 edits
    3 adds in trunk

Animations do not restart after exiting page cache
​https://bugs.webkit.org/show_bug.cgi?id=116900

Reviewed by Tim Horton.

Source/WebCore:

Animations are suspended as they enter the page cache, but
were not getting correctly resumed when exiting. The cause
was an error in r149576 which was checking a global flag for suspension
on the AnimationController and thus not trying to resume anything.

Test: animations/resume-after-page-cache.html

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):

LayoutTests:

New test to make sure an animation will resume if it
enters and leaves the page cache.

  • animations/resources/page-cache-helper.html: Added.
  • animations/resume-after-page-cache-expected.txt: Added.
  • animations/resume-after-page-cache.html: Added.
7:23 PM Changeset in webkit [150861] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

Drag to move DOM nodes does not work
​https://bugs.webkit.org/show_bug.cgi?id=116865

Do not block drag events on the WebKit 1 Web Inspector WebView.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-28
Reviewed by Timothy Hatcher.

  • WebCoreSupport/WebInspectorClient.mm:
6:39 PM Changeset in webkit [150860] by fpizlo@apple.com
  • 7 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support ArithAbs
​https://bugs.webkit.org/show_bug.cgi?id=116890

Reviewed by Oliver Hunt.

Implements ArithAbs in the FTL, and cleans up the DFG implementation. The
DFG implementation was previously doing zero extensions manually when it
is probably better to just use StrictInt32Operand instead.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:

(FTL):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithAbs):
(LowerDFGToLLVM):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::doubleAbs):

5:38 PM Changeset in webkit [150859] by Lucas Forschler
  • 3 edits in tags/Safari-537.43.2a/Source/WebKit2

Merged r150532. <rdar://problem/13962816>

5:35 PM Changeset in webkit [150858] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.2a

New Tag.

5:19 PM Changeset in webkit [150857] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Windows] Silence last crash to get bots green.

  • platform/win/TestExpectations:
4:42 PM Changeset in webkit [150856] by crogers@google.com
  • 11 edits in trunk/Source/WebCore

Support multiple HRTFDatabases for different sample-rates
​https://bugs.webkit.org/show_bug.cgi?id=116183

Reviewed by Kenneth Russell.

Adapted from Blink:
​https://codereview.chromium.org/14636011/

This removes the limitation which required OfflineAudioContexts to be created at native sample-rate

  • Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::hrtfDatabaseLoader):
(AudioContext):

  • Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::create):

  • Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::offlineRender):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::initialize):
(WebCore::PannerNode::setPanningModel):

  • platform/audio/HRTFDatabaseLoader.cpp:

(WebCore):
(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
(WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):

  • platform/audio/HRTFDatabaseLoader.h:

(HRTFDatabaseLoader):
(WebCore::HRTFDatabaseLoader::loaderMap):

  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::HRTFPanner):
(WebCore::HRTFPanner::calculateDesiredAzimuthIndexAndBlend):
(WebCore::HRTFPanner::pan):

  • platform/audio/HRTFPanner.h:

(HRTFPanner):

  • platform/audio/Panner.cpp:

(WebCore::Panner::create):

  • platform/audio/Panner.h:

(WebCore):

4:35 PM Changeset in webkit [150855] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Windows build fix.

  • platform/cf/KURLCFNet.cpp: (WebCore::KURL::createCFURL):
4:27 PM Changeset in webkit [150854] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit

[Windows] Many css2.1 tests fail on Apple's Windows port.
​https://bugs.webkit.org/show_bug.cgi?id=75707

Reviewed by Darin Adler.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Export the WebCore::directoryName method for use by DRT.

4:26 PM Changeset in webkit [150853] by ap@apple.com
  • 14 edits
    5 adds in trunk

Freeze when loading a particular page on washingtonpost.com with NetworkProcess enabled
​https://bugs.webkit.org/show_bug.cgi?id=116887
<rdar://problem/12965959>

Reviewed by Darin Adler.

  • Shared/cf/ArgumentCodersCF.cpp: (CoreIPC::encode): (CoreIPC::decode): Fix for the bug: use good shared WebCore code to manipulate CFURLs. Also, added a FIXME about empty URLs.
  • Shared/API/c/cf/WKURLCF.cpp: (WKURLCreateWithCFURL): Fixed to not use CFURLGetString, as that could prevent loading certain resources, like ones with curly braces in resource specifiers. We want KURL normalization, not CFURL one.
4:26 PM Changeset in webkit [150852] by Brent Fulgham
  • 1 edit in trunk/Source/WebKit/win/ChangeLog

[Windows] Many css2.1 tests fail on Apple's Windows port.
​https://bugs.webkit.org/show_bug.cgi?id=75707

Reviewed by Darin Adler.

  • WebKit.vcproj/WebKitExports.def.in: Export the

WebCore::directoryName method for DRT use.

4:18 PM Changeset in webkit [150851] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Many CSS2.1 tests fail under NRWT.
​https://bugs.webkit.org/show_bug.cgi?id=75707

Patch by Brent Fulgham <​bfulgham@webkit.org> on 2013-05-28
Reviewed by Darin Adler.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(findFontFallback): Added
(addFontFallbackIfPresent): Added
(removeFontFallbackIfPresent): Added
(runTest): Set up/remove font fallbacks when needed.

3:59 PM Changeset in webkit [150850] by Brent Fulgham
  • 3 edits in trunk/Tools

[Windows] NRWT reports failure for 'mac' test cases.
​https://bugs.webkit.org/show_bug.cgi?id=116698

Reviewed by Ryosuke Niwa.

The Windows port falls back to the Mac port for many test results,
and so adds the mac and mac-wk2 to its set of fallbacks.
Unfortunately, NRWT thinks that this means that tests in these
folders should be executed, resulting in many failures on
Windows.

This change overloads the '_tests_for_other_platforms' method
to return a subset of the result fallback list so that we do
not attempt to execute Mac tests on Windows.

  • Scripts/webkitpy/port/base.py:

(Port.test_search_path): Added. Defaults to just calling the
baseline_search_path method, which is how most ports behave.
(Port._test_for_other_platforms): Modified to call the new
test_search_path method.

  • Scripts/webkitpy/port/win.py:

(WinPort.test_search_path): Added custom overload. Strips
out mac-specific test paths.

3:57 PM Changeset in webkit [150849] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Windows] More attempts to make the bot green.

  • platform/win/TestExpectations: Exclude another two flaky tests.
3:40 PM Changeset in webkit [150848] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

fast/js/date-DST-time-cusps.html fails after ​http://trac.webkit.org/changeset/150833
​https://bugs.webkit.org/show_bug.cgi?id=116895

Unreviewed, add failing test expectation.

3:33 PM Changeset in webkit [150847] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r150774. <rdar://problem/13458534>

3:32 PM Changeset in webkit [150846] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r150773. <rdar://problem/13458534>

3:31 PM Changeset in webkit [150845] by Lucas Forschler
  • 13 edits in branches/safari-537.43-branch/Source

Merged r150771. <rdar://problem/13458534>

3:26 PM Changeset in webkit [150844] by mark.lam@apple.com
  • 16 edits
    1 add in branches/dfgFourthTier/Source/JavaScriptCore

Misc JIT probe enhacements.
​https://bugs.webkit.org/show_bug.cgi?id=116586.

Reviewed by Michael Saboff.

  1. Added JIT probe support for ARMv7 and traditional ARM. Built and tested on ARMv7. ARM version not tested nor built.
  2. Fix the following bugs in the X86 and X86_64 probes:
    1. Cannot assume that the stack pointer is already aligned when we push args for the probe. Instead, we ensure the stack alignment at runtime when we set up the probe call. This is now done in the ctiMasmProbeTrampoline.
    2. On return, the user probe function may have altered the stack pointer value to be restored. Previously, if the sp restore value points to some of the other register restore values in the ProbeContext record, we will fail to return from the probe having those user specified value as we're expected to do. This is now fixed.
  3. Rearranged the X86/X86_64 registers order to organize them like gdb expects on X86_64.
  4. We also now preserve the condition code registers.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:

(ARMRegisters):

  • assembler/MacroAssemblerARM.cpp:

(JSC::isVFPPresent):
(JSC::MacroAssemblerARM::ProbeContext::dumpCPURegisters):
(JSC::MacroAssemblerARM::ProbeContext::dump):
(JSC::MacroAssemblerARM::probe):

  • assembler/MacroAssemblerARM.h:

(MacroAssemblerARM):
(CPUState):
(ProbeContext):
(JSC::MacroAssemblerARM::trustedImm32FromPtr):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):
(CPUState):
(ProbeContext):
(JSC::MacroAssemblerARMv7::trustedImm32FromPtr):

  • assembler/MacroAssemblerX86.h:

(MacroAssemblerX86):
(JSC::MacroAssemblerX86::probe):

  • assembler/MacroAssemblerX86Common.cpp:

(JSC::MacroAssemblerX86Common::ProbeContext::dumpCPURegisters):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::probe):

  • assembler/X86Assembler.h:
  • config.h:
  • jit/JITStubsARM.h:
  • jit/JITStubsARMv7.h:
  • jit/JITStubsX86.h:
  • jit/JITStubsX86Common.h:
  • jit/JITStubsX86_64.h:
3:24 PM Changeset in webkit [150843] by fpizlo@apple.com
  • 13 edits in branches/dfgFourthTier/LayoutTests

fourthTier: convert more fast/js/dfg-* tests to wait for the concurrent JIT

Rubber stamped by Oliver Hunt.

  • fast/js/dfg-arguments-alias-one-block-expected.txt:
  • fast/js/dfg-arguments-cross-code-origin-expected.txt:
  • fast/js/dfg-arguments-mixed-alias-expected.txt:
  • fast/js/dfg-arguments-osr-exit-expected.txt:
  • fast/js/dfg-arguments-osr-exit-multiple-blocks-before-exit-expected.txt:
  • fast/js/dfg-arguments-unexpected-escape-expected.txt:
  • fast/js/script-tests/dfg-arguments-alias-one-block.js:
  • fast/js/script-tests/dfg-arguments-cross-code-origin.js:
  • fast/js/script-tests/dfg-arguments-mixed-alias.js:
  • fast/js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js:
  • fast/js/script-tests/dfg-arguments-osr-exit.js:
  • fast/js/script-tests/dfg-arguments-unexpected-escape.js:
3:22 PM Changeset in webkit [150842] by Brent Fulgham
  • 3 edits in trunk/Source/JavaScriptCore

[Windows] Put correct byteCompile symbol in file. Previous version
had an extra 'i' appended to the end.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
3:07 PM Changeset in webkit [150841] by Brent Fulgham
  • 3 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed build fix. Remove ?byteCompile symbol that
is no longer accessible during link.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
3:01 PM Changeset in webkit [150840] by roger_fong@apple.com
  • 12 edits
    2 adds in branches/safari-537.43-branch

Disable some feature flags.
<rdar://problem/12952646>.
Rubberstamped by Jon Lee.
Disabled flags:
ENABLE_CSS_COMPOSITING
ENABLE_CSS_EXCLUSIONS
ENABLE_CSS_SHADERS
ENABLE_IFRAME_SEAMLESS
ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED
ENABLE_SHARED_WORKERS

  • Configurations/FeatureDefines.xcconfig:
  • rendering/RenderBlock.cpp:

(WebCore::exclusionInfoRequiresRelayout):
(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

  • platform/mac/TestExpectations:
  • platform/mac/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
  • platform/mac/fast/js/constructor-length-expected.txt:
  • platform/mac/fast/js/global-constructors-attributes-expected.txt: Added.
2:53 PM Changeset in webkit [150839] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should call masqueradesAsUndefinedWatchpointIfIsStillValid() in all of the places where it currently calls masqueradesAsUndefinedWatchpointIsStillValid()
​https://bugs.webkit.org/show_bug.cgi?id=116892

Reviewed by Oliver Hunt.

All of those places mean to plant the watchpoint if it's still valid.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::LowerDFGToLLVM::speculateNonNullObject):

2:52 PM Changeset in webkit [150838] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Rendering suppression extension tokens shouldn't be 0, should handle overflow
​https://bugs.webkit.org/show_bug.cgi?id=116886
<rdar://problem/14004474>

Reviewed by Darin Adler.

Don't use invalid HashSet values as tokens, and ensure that
we're not already using a token before returning it.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::extendIncrementalRenderingSuppression):

2:50 PM Changeset in webkit [150837] by andersca@apple.com
  • 12 edits
    2 moves
    1 add in trunk/Source

Create a html/forms subdirectory and move FileIconLoader there
​https://bugs.webkit.org/show_bug.cgi?id=116880

Reviewed by Jessie Berlin.

A lot (if not the majority) of files in html/ are forms related, so it makes sense to begin splitting
them out into a separate subdirectory, html/forms.

Begin my moving FileIconLoader from platform to html/forms. It is related to HTML forms (it's only used by
the file upload element), and is not really a platform abstraction so it doesn't belong in platform.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/forms/FileIconLoader.cpp: Renamed from Source/WebCore/platform/FileIconLoader.cpp.
  • html/forms/FileIconLoader.h: Renamed from Source/WebCore/platform/FileIconLoader.h.
2:47 PM Changeset in webkit [150836] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: WKView is unable to set AXFocused to YES and does not handle keyboard events as expected
​https://bugs.webkit.org/show_bug.cgi?id=116756

Reviewed by Tim Horton.

If AXFocused is set to true, but the WebView is not the first responder, then the call will
not do anything. This change asks the Chrome to make the WebView the first responder before
trying to set focus within the page.

Was not able to make a test, it requires on interplay between areas outside the web view.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

2:45 PM Changeset in webkit [150835] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

String(new Date(2010,10,1)) is wrong in KRAT, YAKT
​https://bugs.webkit.org/show_bug.cgi?id=106750

Reviewed by Darin Adler.

  • runtime/JSDateMath.cpp:

(JSC::msToGregorianDateTime):

  • Additional review comment fix.
2:45 PM Changeset in webkit [150834] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed build fix after r150833

A CR/LF combination was lost in the file, combining two symbols.

2:33 PM Changeset in webkit [150833] by barraclough@apple.com
  • 11 edits in trunk/Source

String(new Date(2010,10,1)) is wrong in KRAT, YAKT
​https://bugs.webkit.org/show_bug.cgi?id=106750

Reviewed by Darin Adler.

First part of a fix, simplfy date handling code, instead of operating separately
on the UTC-standard and standard-DST offsets, just generate a combined UTC-local
offset (this is what we actually need, and what the OS gives us).

../JavaScriptCore:

  • runtime/JSDateMath.cpp:

(JSC::getLocalTimeOffset):

  • removed getUTCOffset, converted getDSTOffset -> getLocalTimeOffset

(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):

  • call getLocalTimeOffset instead of getUTCOffset/getDSTOffset
  • runtime/VM.cpp:

(JSC::VM::resetDateCache):

  • removed cachedUTCOffset, converted DSTOffsetCache -> LocalTimeOffsetCache
  • runtime/VM.h:

(JSC::LocalTimeOffsetCache::LocalTimeOffsetCache):
(JSC::LocalTimeOffsetCache::reset):
(LocalTimeOffsetCache):

  • removed cachedUTCOffset, converted DSTOffsetCache -> LocalTimeOffsetCache

../WTF:

  • wtf/DateMath.cpp:

(WTF::calculateUTCOffset):
(WTF::calculateDSTOffset):

  • made static, now not called from outside of this file.

(WTF::calculateLocalTimeOffset):

  • This combines the 2038 related adjustment from calculateDSTOffset with the maxUnixTime adjustment from calculateDSTOffsetSimple. Then, if HAVE(TM_GMTOFF) just call getLocalTime, if not use calculateUTCOffset/calculateDSTOffset.

(WTF::parseDateFromNullTerminatedCharacters):

  • call calculateLocalTimeOffset instead of calculateUTCOffset/calculateDSTOffset
  • wtf/DateMath.h:

(WTF::LocalTimeOffset::LocalTimeOffset):
(LocalTimeOffset):
(WTF::LocalTimeOffset::operator==):

  • new struct type, a tuple of UTC-local offset & isDST flag.
  • replaced calculateUTCOffset/calculateDSTOffset with calculateLocalTimeOffset
  • wtf/GregorianDateTime.cpp:

(WTF::GregorianDateTime::setToCurrentLocalTime):

  • call calculateLocalTimeOffset instead of calculateUTCOffset/calculateDSTOffset
2:33 PM Changeset in webkit [150832] by Lucas Forschler
  • 3 edits in branches/safari-537.43-branch/Source/WebCore

Merged r150618. <rdar://problem/13984706>

2:18 PM Changeset in webkit [150831] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

r150199 is very wrong
​https://bugs.webkit.org/show_bug.cgi?id=116876

JSValue needs to protect its internal JSValueRef.

Reviewed by Darin Adler.

  • API/JSValue.mm:

(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):

  • API/tests/testapi.mm: Added a simple test to make sure that we protect the

underlying JavaScript value across garbage collections.

2:04 PM Changeset in webkit [150830] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Windows] Silence a few failures to get bot green.
​https://bugs.webkit.org/show_bug.cgi?id=116564

  • platform/win/TestExpectations: Disable some tests.
1:55 PM Changeset in webkit [150829] by fpizlo@apple.com
  • 5 edits in branches/dfgFourthTier/LayoutTests

fourthTier: convert more fast/js/dfg-* tests to wait for the concurrent JIT

Rubber stamped by Oliver Hunt.

  • fast/js/dfg-arguments-alias-activation-expected.txt:
  • fast/js/dfg-arguments-alias-activation.html:
  • fast/js/dfg-arguments-alias-expected.txt:
  • fast/js/script-tests/dfg-arguments-alias.js:
1:50 PM Changeset in webkit [150828] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support ArithMin/ArithMax
​https://bugs.webkit.org/show_bug.cgi?id=116885

Reviewed by Oliver Hunt.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileArithMinOrMax):

1:17 PM Changeset in webkit [150827] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in DumpRenderTree at com.apple.WebCore: WebCore::RenderTextTrackCue::repositionGenericCue + 154
​https://bugs.webkit.org/show_bug.cgi?id=116882

Reviewed by Eric Carlson.

Remove an inappropriate assert. No cues coming through repositionGenericCue will be WebVTT ones.

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::repositionGenericCue):

1:05 PM Changeset in webkit [150826] by fpizlo@apple.com
  • 10 edits in branches/dfgFourthTier/LayoutTests

fourthTier: convert more fast/js/dfg-* tests to wait for the concurrent JIT

Rubber stamped by Oliver Hunt.

  • fast/js/dfg-abs-backwards-propagation-expected.txt:
  • fast/js/dfg-add-not-number-expected.txt:
  • fast/js/dfg-arguments-alias-escape-expected.txt:
  • fast/js/resources/js-test-pre.js:

(dfgCompiled):
(dfgIncrement):

  • fast/js/script-tests/dfg-abs-backwards-propagation.js:
  • fast/js/script-tests/dfg-add-not-number.js:
  • fast/js/script-tests/dfg-arguments-alias-escape.js:
  • fast/js/script-tests/dfg-arguments-alias-one-block-osr-exit.js:
  • fast/js/script-tests/dfg-arguments-alias-one-block-overwrite-arguments.js:
12:36 PM Changeset in webkit [150825] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier/LayoutTests

fourthTier: fast/js should have a way of running tests long enough to wait for the concurrent JIT to tier up
​https://bugs.webkit.org/show_bug.cgi?id=116878

Reviewed by Oliver Hunt.

This adds three things to js-test-pre and uses them in one representative test:

silentTestPass: If you set this to true, then testPassed() won't print anything, and will instead just have

isSuccessfullyParsed() print a message saying that some tests passed silently. This allows tests to call
shouldBe() and friends in a loop whose running time is dependent on concurrent JIT behavior, and still
be sure that the resulting test will be deterministic.


noInline(): If testRunner is present, disable inlining of the relevant function.

dfgIncrement({f:function, i:index, n:limit}): Returns index either if index < limit, or if the function is

DFG compiled. Otherwise, if index >= limit and the function isn't DFG compiled, return 0. This means
that the 'i++' in the fast/js/dfg-* warm-up loops can be replaced with:

i = dfgIncrement({f:<function you're interested in>, i:i + 1, n:<some number smaller than the loop condition>)

This has the effect of having the loop repeat the first 'n' iterations until the function is DFG
compiled. See the modified test, where we do n:100 and the loop condition is i < 200. So the loop will
repeat the first 100 iterations until the function is DFG compiled and will only do the last 100
iterations once DFG compilation kicks in.

  • fast/js/dfg-arguments-osr-exit-multiple-blocks-expected.txt:
  • fast/js/resources/js-test-pre.js:

(testPassed):
(dfgIncrement):
(noInline):
(isSuccessfullyParsed):

  • fast/js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js:
12:04 PM Changeset in webkit [150824] by Lucas Forschler
  • 3 edits in branches/safari-537.43-branch/Source/WebCore

Merged r150731. <rdar://problem/13695911>

12:01 PM Changeset in webkit [150823] by Lucas Forschler
  • 35 edits in branches/safari-537.43-branch

Merged r150695. <rdar://problem/13743484>

11:55 AM Changeset in webkit [150822] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

Fix line endings in test added in r150602

Unreviewed.

  • fast/css/text-overflow-ellipsis-behind-floats.html:
11:50 AM Changeset in webkit [150821] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebCore

Merged r150671. <rdar://problem/13886753>

11:46 AM Changeset in webkit [150820] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] GraphicsContext: add missing definitions.
​https://bugs.webkit.org/show_bug.cgi?id=115515

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-05-28
Reviewed by Rob Buis.

  • platform/graphics/GraphicsContext.h:

(Graphics):
Add definition for PlatformGraphicsContext.

  • platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:

Include RoundedRect.h

11:45 AM Changeset in webkit [150819] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Merged r150653. <rdar://problem/13747883>

11:43 AM Changeset in webkit [150818] by Lucas Forschler
  • 13 edits
    4 copies in branches/safari-537.43-branch/Source

Merged r150651. <rdar://problem/13885606>

11:40 AM Changeset in webkit [150817] by anilsson@rim.com
  • 14 edits in trunk/Source

[BlackBerry] Fix style issues in BlackBerry accelerated compositing backend
​https://bugs.webkit.org/show_bug.cgi?id=116604

Reviewed by Carlos Garcia Campos.

Source/WebCore:

PR 273550, 99638

Remove the "get" prefix from getters in the WebKit- and compositing-
thread layer classes, as well as LayerRendererSurface. Clarify which
geometry-related getters return normalized device coordinates by adding
a comment.

Also remove dead code related to LayerData::m_holePunchClipRect, which
was part of an eventually disabled fix for video clipping in iframes,
PR 99638. Since we now use AC layers for iframes, the bug is no longer
reproducible, and the dead code will never need to be enabled again.

No change in behavior, no new tests.

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:

(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::LayerCompositingThread::transformedHolePunchRect):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerCompositingThread::sublayers): Removed "get" prefix
(LayerCompositingThread):
(WebCore::LayerCompositingThread::boundingBox): Renamed from "getDrawRect"
(WebCore::LayerCompositingThread::transformedBounds): Removed "get" prefix
(WebCore::LayerCompositingThread::transformedHolePunchRect): Removed "get" prefix

  • platform/graphics/blackberry/LayerData.h:

(LayerData): Removed unused data member "m_holePunchClipRect"

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRenderer::applyActions):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::prepareFrameRecursive):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::collect3DPreservingLayers):
(WebCore::LayerRenderer::compositeLayersRecursive):

  • platform/graphics/blackberry/LayerRendererSurface.cpp:

(WebCore::LayerRendererSurface::boundingBox):

  • platform/graphics/blackberry/LayerRendererSurface.h:

(WebCore::LayerRendererSurface::boundingBox): Renamed from "drawRect" because that sounds like a verb, and this is a getter

  • platform/graphics/blackberry/LayerWebKitThread.h:

(WebCore::LayerWebKitThread::sublayers): Removed "get" prefix

  • platform/graphics/blackberry/VideoLayerWebKitThread.cpp:

(WebCore::VideoLayerWebKitThread::setHolePunchRect):
(WebCore::VideoLayerWebKitThread::boundsChanged):

Source/WebKit/blackberry:

Adapt to the removal of "get" prefix from getters in the WebKit- and
compositing-thread layer classes.

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
(BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):
(BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):

11:33 AM Changeset in webkit [150816] by fpizlo@apple.com
  • 10 edits in branches/dfgFourthTier

testRunner should have a way of disabling inlining of functions
​https://bugs.webkit.org/show_bug.cgi?id=116875

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • API/JSCTestRunnerUtils.cpp:

(JSC::getExecutable):
(JSC):
(JSC::numberOfDFGCompiles):
(JSC::setNeverInline):

  • API/JSCTestRunnerUtils.h:

(JSC):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpAssumingJITType):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForClosureCall):
(JSC::DFG::mightInlineFunctionForConstruct):

  • runtime/Executable.h:

(JSC::ScriptExecutable::ScriptExecutable):
(ScriptExecutable):
(JSC::ScriptExecutable::setNeverInline):
(JSC::ScriptExecutable::neverInline):
(JSC::ScriptExecutable::isInliningCandidate):

Tools:

  • DumpRenderTree/TestRunner.cpp:

(neverInlineFunction):
(TestRunner::staticFunctions):

LayoutTests:

  • fast/js/script-tests/dfg-min-max.js:
11:32 AM Changeset in webkit [150815] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebCore

Merged r150547. <rdar://problem/13946443>

11:31 AM Changeset in webkit [150814] by fpizlo@apple.com
  • 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support ArithMod
​https://bugs.webkit.org/show_bug.cgi?id=116792

Reviewed by Oliver Hunt.

  • ftl/FTLAbbreviations.h:

(JSC::FTL::buildFRem):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):
(LowerDFGToLLVM):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::doubleRem):

11:30 AM Changeset in webkit [150813] by Lucas Forschler
  • 3 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r150532. <rdar://problem/13962816>

11:27 AM Changeset in webkit [150812] by Lucas Forschler
  • 3 edits
    6 copies in branches/safari-537.43-branch

Merged r150529. <rdar://problem/13946443>

11:18 AM Changeset in webkit [150811] by fpizlo@apple.com
  • 24 edits in branches/dfgFourthTier/Source

It should be possible to record heap operations (both FastMalloc and JSC GC)
​https://bugs.webkit.org/show_bug.cgi?id=116848

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Record GC heap operations if ENABLE(ALLOCATION_LOGGING).

  • API/JSManagedValue.mm:
  • dfg/DFGOperations.cpp:
  • heap/Heap.cpp:

(JSC::Heap::collect):

  • heap/Heap.h:

(Heap):
(JSC::Heap::allocateWithNormalDestructor):
(JSC::Heap::allocateWithImmortalStructureDestructor):
(JSC::Heap::allocateWithoutDestructor):
(JSC::Heap::tryAllocateStorage):
(JSC::Heap::tryReallocateStorage):
(JSC):
(JSC::Heap::ascribeOwner):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::append):
(JSC::SlotVisitor::internalAppend):

  • heap/SlotVisitor.h:

(SlotVisitor):

  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::append):
(JSC::SlotVisitor::appendUnbarrieredPointer):
(JSC::SlotVisitor::appendUnbarrieredValue):
(JSC::SlotVisitor::appendUnbarrieredWeak):
(JSC::SlotVisitor::internalAppend):
(JSC):
(JSC::SlotVisitor::appendValues):

  • jit/JITWriteBarrier.h:

(JSC::SlotVisitor::append):

  • llint/LLIntCommon.h:
  • runtime/Butterfly.h:

(Butterfly):

  • runtime/ButterflyInlines.h:

(JSC::Butterfly::createUninitialized):
(JSC::Butterfly::create):
(JSC::Butterfly::growPropertyStorage):
(JSC::Butterfly::createOrGrowArrayRight):
(JSC):
(JSC::Butterfly::growArrayRight):
(JSC::Butterfly::resizeArray):

  • runtime/JSArray.cpp:

(JSC::createArrayButterflyInDictionaryIndexingMode):
(JSC::JSArray::unshiftCountSlowCase):

  • runtime/JSArray.h:

(JSC::createContiguousArrayButterfly):
(JSC::createArrayButterfly):
(JSC):
(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized):

  • runtime/JSObject.cpp:

(JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists):
(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::constructConvertedArrayStorageWithoutCopyingElements):
(JSC::JSObject::increaseVectorLength):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::growOutOfLineStorage):

  • runtime/JSObject.h:

(JSC::JSObject::JSObject):

  • runtime/Operations.h:
  • runtime/RegExpMatchesArray.cpp:

(JSC::RegExpMatchesArray::create):

  • runtime/StructureInlines.h:

(JSC):

  • runtime/WriteBarrier.h:

(JSC):

Source/WTF:

Reviewed by Mark Hahnenberg.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/DataLog.cpp:

(WTF):
(WTF::initializeLogFileOnce):

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

  • wtf/Platform.h:
10:54 AM Changeset in webkit [150810] by jer.noble@apple.com
  • 12 edits in trunk

Made AudioNode an EventTarget
​https://bugs.webkit.org/show_bug.cgi?id=116871

Source/WebCore:

Merge: ​https://chromium.googlesource.com/chromium/blink/+/ef37484162ddb95d677dcfdcdd778ec60590928b

Reviewed by Darin Adler.

Tests: webaudio/audionode-expected.txt:

webaudio/audionode.html:

Add the requisite boilerplate to allow AudioNode to become an EventTarget. Remove
all that same boilerplate from ScriptProcessorNode now that it's base class
is an EventTarget.

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::interfaceName): Added boilerplate.
(WebCore::AudioNode::scriptExecutionContext): Return the AudioContext's context.
(WebCore::AudioNode::processIfNecessary): Whitespace.

  • Modules/webaudio/AudioNode.h:
  • Modules/webaudio/AudioNode.idl: Make AudioNode an EventTarget.
  • Modules/webaudio/ScriptProcessorNode.cpp: Remove EventTarget boilerplate.
  • Modules/webaudio/ScriptProcessorNode.h: Ditto.
  • Modules/webaudio/ScriptProcessorNode.idl: Ditto.
  • dom/EventTarget.h: Mark AudioNode as an EventTarget.
  • dom/EventTargetFactory.in: Ditto.

LayoutTests:

Reviewed by Darin Adler.

  • webaudio/audionode-expected.txt:
  • webaudio/audionode.html:
10:28 AM Changeset in webkit [150809] by anilsson@rim.com
  • 9 edits in trunk/Source/WebCore

[BlackBerry] backface-visibility: hidden doesn't work properly with masks and filters
​https://bugs.webkit.org/show_bug.cgi?id=116616

Reviewed by Carlos Garcia Campos.

The BlackBerry::Platform::Graphics::GraphicsContext generates geometry
with a different winding order than the accelerated compositing backend
of the BlackBerry port. So, when we switched from Skia to this new
rendering engine, we switched from glFrontFace(GL_CCW) to
glFrontFace(GL_CW), and all was well when drawing display lists.
However, we forgot to update the winding order of geometry generated
within the accelerated compositing backend, which is used for masks and
filters, so they were getting erroneously culled out when
backface-visibility: hidden was applied to them. Fixed by switching the
winding order of all geometry generated up here, which has the added
benefit of enabling us to use TransformationMatrix::mapQuad instead of
transforming point-by-point.

To further complicate matters, a right-side up transform is used when
drawing layers into surfaces, reversing the winding order and requiring
us to switch back to glFrontFace(GL_CCW) temporarily, when drawing
layers to surfaces, or the layers will get culled out inside the
surface.

Also fix spelling error, "drawed" should be "drawn".

No new tests, this is only detectable by pixel tests, which the
BlackBerry port currently doesn't support.

PR 341945.

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:

(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::getTransformedRect):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):
(WebCore::LayerCompositingThread::origin):

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::compositeLayers):
(WebCore):
(WebCore::LayerRenderer::drawLayersOnSurfaces):

  • platform/graphics/blackberry/LayerRendererSurface.cpp:

(WebCore::LayerRendererSurface::drawRect):
(WebCore::LayerRendererSurface::transformedBounds):

  • platform/graphics/blackberry/LayerRendererSurface.h:

(WebCore::LayerRendererSurface::origin):
(LayerRendererSurface):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore):
(WebCore::loadBufferingImageData):
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):

10:12 AM Changeset in webkit [150808] by lauro.neto@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[GTK] Connection issues in repeated WebProcess crash/reloads.
​https://bugs.webkit.org/show_bug.cgi?id=115880

Reviewed by Anders Carlsson.

When stressing the WebProcess creation/destruction, WebKitGTK can
often run into socket issues like bad file descriptor errors or
polling a socket indefinitely.

Currently WebKitGTK has three places where a socket can be
closed.

  • childFinishedFunction (in ProcessLauncherGtk.cpp)
  • Connection::platformInvalidate (in ConnectionUnix.cpp)
  • WorkQueue EventSource destruction (in WorkQueueGtk.cpp)

To avoid these race conditions, socket closing will be handled
by the event source callback in WorkQueueGtk.cpp.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::platformInvalidate): Do not close the socket
when the connection is invalidated, the socket event source is
unregistered in this method and the socket is closed when the
GSocket associated to the event source is destroyed.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess): Do not monitor child
process to close the connection on termination. This was needed in
the past when we used DGRAM sockets, we currently use always
connection oriented sockets, so that when the other end closes
the connection we are notified and the connection is invalidated.

10:08 AM Changeset in webkit [150807] by fpizlo@apple.com
  • 13 edits
    3 adds in branches/dfgFourthTier

testRunner should be able to tell you if a function is DFG compiled
​https://bugs.webkit.org/show_bug.cgi?id=116847

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • API/JSCTestRunnerUtils.cpp: Added.

(JSC):
(JSC::numberOfDFGCompiles):

  • API/JSCTestRunnerUtils.h: Added.

(JSC):

(JSC::CodeBlock::numberOfDFGCompiles):
(JSC):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::runThread):

  • runtime/Executable.h:

(JSC):

  • runtime/JSFunctionInlines.h: Added.

(JSC):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::jsExecutable):
(JSC::JSFunction::isHostFunction):
(JSC::JSFunction::nativeFunction):
(JSC::JSFunction::nativeConstructor):

  • runtime/Operations.h:

Source/WebCore:

Bail early if we're in the compilation thread. This is only relevant for
debug dumps.

No new tests becase no new behavior.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):

Tools:

  • DumpRenderTree/TestRunner.cpp:

(numberOfDFGCompiles):
(TestRunner::staticFunctions):

LayoutTests:

  • fast/js/script-tests/dfg-min-max.js:
9:03 AM Changeset in webkit [150806] by Martin Robinson
  • 4 edits in trunk

Fix GTK+ CMake build

Source/WebKit2:

  • PlatformGTK.cmake: After r150336, the name of the WebKit2

library target is simply "WebKit2."

Tools:

  • MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2

library target is simply "WebKit2."

7:41 AM Changeset in webkit [150805] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Move Node::dispatchChangeEvent() to HTMLFormControlElement.
<​http://webkit.org/b/116866>

Reviewed by Anders Carlsson.

...and devirtualize it, since it had no overrides.

  • dom/Node.h:
  • dom/Node.cpp:
  • html/HTMLFormControlElement.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::dispatchChangeEvent):
(WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):

  • html/FileInputType.cpp:

(WebCore::FileInputType::setFiles):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):

7:37 AM Changeset in webkit [150804] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

Refactoring CSS grammar
​https://bugs.webkit.org/show_bug.cgi?id=116679

Reviewed by Andreas Kling.

From Blink r149948 by <​serya@chromium.org>

Added "closing_parenthesis:" and "error_recovery:" to avoid code
duplication in a couple of error recovery rules. Some other rules
were also refactored which allows to reduce the the number of
shift/reduce conflicts by 2.

No new tests required as this is just a refactoring, no new
functionality added.

  • css/CSSGrammar.y.in:
7:31 AM Changeset in webkit [150803] by sergio@webkit.org
  • 4 edits in trunk

Invalid block doesn't make declaration invalid
​https://bugs.webkit.org/show_bug.cgi?id=115709

Reviewed by Andreas Kling.

From Blink r149446 by <​serya@chromium.org>

Source/WebCore:

Added a new rule "declaration_recovery:" which covers any kind of
"invalid_block_list maybe_space" sequence. By appending this new
rule to every rule reductable to "declaration:" we can remove some
redundant rules and improve error recovery of some others that
were only accepting exactly one error.

One of the rules being removed was preventing invalid blocks in a
declaration to invalidate the whole declaration. The rule was
reporting the syntax error but at the same time accepting the
invalid block as part of a valid declaration.

  • css/CSSGrammar.y.in:

LayoutTests:

  • fast/css/parsing-error-recovery.html: Added 2 new test cases.
7:08 AM Changeset in webkit [150802] by marcelo.lira@openbossa.org
  • 2 edits in trunk/Source/WebKit2

[WK2][CoordinatedGraphics] DrawingArea's visible content area must be updated when contents size changes
​https://bugs.webkit.org/show_bug.cgi?id=116845

Reviewed by Noam Rosenthal.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::didChangeContentsSize):

7:01 AM Changeset in webkit [150801] by akling@apple.com
  • 11 edits in trunk/Source/WebCore

Move dispatching of focus-related events from Node to Element.
<​http://webkit.org/b/116864>

Reviewed by Antti Koivisto.

...and pass around pointers to Element instead of Node.

  • dom/Node.cpp:
  • dom/Node.h:
  • dom/Element.h:
  • dom/Element.cpp:

(WebCore::Element::dispatchFocusInEvent):
(WebCore::Element::dispatchFocusOutEvent):
(WebCore::Element::dispatchFocusEvent):
(WebCore::Element::dispatchBlurEvent):

Moved here from Node.

  • html/HTMLFormControlElement.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::dispatchBlurEvent):

  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::dispatchFocusEvent):
(WebCore::HTMLSelectElement::dispatchBlurEvent):

  • html/HTMLTextFormControlElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
(WebCore::HTMLTextFormControlElement::dispatchBlurEvent):

Update subclass overrides and sprinkle OVERRIDE/FINAL.

6:34 AM Changeset in webkit [150800] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

[webkitpy] Explicitly specify the reference file extensions
​https://bugs.webkit.org/show_bug.cgi?id=116333

Reviewed by Benjamin Poulain.

Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
between valid reference files required by reftests and text baselines that have the same extension as
potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
that were until this change recognized as reference files).

Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.

  • Scripts/webkitpy/port/base.py:

(Port.reference_files): Iterate through the _supported_reference_extensions set.
(Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
_supported_reference_extensions set, containing the extensions allowed for reference files.
(Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
(Port._has_supported_extension): Use _supported_test_extensions.

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
Port.is_reference_html_file method.

6:22 AM Changeset in webkit [150799] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

Remove CachedResourceRequest::initiatorElement
​https://bugs.webkit.org/show_bug.cgi?id=116862

Reviewed by Andreas Kling.

The CachedResourceRequest::initiatorElement method is not used anywhere and should be removed.

  • loader/cache/CachedResourceRequest.cpp: Remove the initiatorElement method definition.
  • loader/cache/CachedResourceRequest.h:

(CachedResourceRequest): Remove the initiatorElement method declaration.

6:07 AM Changeset in webkit [150798] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] REGRESSION(r149292): broke scrolling in Qt WK2 desktop mode
​https://bugs.webkit.org/show_bug.cgi?id=116597

ScrollingCoordinatorCoordinatedGraphics is tailored specifically for
fixedLayout mode. When fixedLayout is not set, it should be turned off.

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-05-28
Reviewed by Allan Sandfeld Jensen.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

6:01 AM Changeset in webkit [150797] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip now passing tests.

  • platform/qt/TestExpectations:
5:54 AM QtWebKitGardening edited by Csaba Osztrogonác
Add a hint for x86 users (diff)
5:46 AM Changeset in webkit [150796] by akling@apple.com
  • 55 edits in trunk/Source

Document::setFocusedNode() should be setFocusedElement().
<​http://webkit.org/b/116857>

Reviewed by Antti Koivisto.

Source/WebCore:

Only Elements can be focused, so tighten Document's idea of what's focused.

Most of this patch is just updating call sites for the new names and removing
now-unnecessary isElementNode() checks and casts.

  • WebCore.exp.in:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedUIElementForPage):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canSetFocusAttribute):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isFocused):
(WebCore::AccessibilityRenderObject::setFocused):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):

  • bindings/objc/DOM.mm:

(-[DOMElement isFocused]):

  • dom/Document.cpp:

(WebCore::Document::dispose):
(WebCore::Document::detach):
(WebCore::Document::focusedNodeRemoved):
(WebCore::Document::removeFocusedNodeOfSubtree):
(WebCore::Document::setFocusedElement):
(WebCore::Document::updateFocusAppearanceTimerFired):
(WebCore::eventTargetNodeForDocument):

  • dom/Document.h:

(Document):
(WebCore::Document::focusedElement):

  • dom/Element.cpp:

(WebCore::Element::attach):
(WebCore::Element::focus):
(WebCore::Element::blur):
(WebCore::Element::cancelFocusAppearanceUpdate):

  • dom/Node.cpp:

(WebCore::Node::rendererIsEditable):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::focusedElement):

  • dom/UserTypingGestureIndicator.cpp:

(WebCore::UserTypingGestureIndicator::UserTypingGestureIndicator):

  • editing/Editor.cpp:

(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::setComposition):
(WebCore::Editor::guessesForMisspelledOrUngrammatical):

  • editing/EditorCommand.cpp:

(WebCore::verticalScrollDistance):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::setFocusedElementIfNeeded):
(WebCore::FrameSelection::currentForm):

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::attach):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setValueCommon):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
(WebCore::HTMLTextFormControlElement::selectionStart):
(WebCore::HTMLTextFormControlElement::selectionEnd):
(WebCore::HTMLTextFormControlElement::selectionDirection):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::focusedFieldIndex):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::focus):

  • page/EventHandler.cpp:

(WebCore::EventHandler::scrollOverflow):
(WebCore::EventHandler::logicalScrollOverflow):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::capsLockStateMayHaveChanged):

  • page/FocusController.cpp:

(WebCore::dispatchEventsOnWindowAndFocusedNode):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::setFocusedElement):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor):

  • plugins/PluginView.cpp:

(WebCore::PluginView::focusPluginElement):

  • plugins/efl/PluginViewEfl.cpp:

(WebCore::PluginView::setFocus):

  • plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::platformStart):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintAreaElementFocusRing):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
(WebCore::RenderTextControlSingleLine::textShouldBeTruncated):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isFocused):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
(BlackBerry::WebKit::WebPage::setNodeFocus):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
(BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_focused_element_geometry_get):

  • ewk/ewk_view.cpp:

(ewk_view_input_method_state_set):

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(getFocusedNode):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView clearFocus]):
(-[WebHTMLView becomeFirstResponder]):

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::hasFocus):
(QWebElement::setFocus):

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState):

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::mousePressEvent):
(QWebPageAdapter::handleSoftwareInputPanel):
(QWebPageAdapter::inputMethodQuery):
(QWebPageAdapter::hasFocusedNode):

Source/WebKit/win:

  • DOMCoreClasses.cpp:

(DOMElement::isFocused):

  • WebView.cpp:

(WebView::setInitialFocus):

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::focusPluginElement):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::focusedPluginViewForFrame):
(WebKit::WebPage::setInitialFocus):

3:43 AM Changeset in webkit [150795] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit/blackberry

Unreviewed. Fix BlackBerry debug build after r150756.

  • WebKitSupport/PagePopup.cpp:

(BlackBerry::WebKit::PagePopup::writeDocument): Fix typo in
assert.

3:22 AM Changeset in webkit [150794] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unskip now passing tests.

  • platform/qt-arm/TestExpectations:
2:37 AM Changeset in webkit [150793] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests after parallel gc is enabled.

  • platform/qt/TestExpectations:
2:29 AM Changeset in webkit [150792] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Clean up duplicated include files.
​https://bugs.webkit.org/show_bug.cgi?id=116851

Reviewed by Christophe Dumez.

Remove some of duplicated include file in ewk files.

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/API/efl/ewk_color_picker.cpp:
  • UIProcess/API/efl/ewk_context_menu.cpp:
  • UIProcess/API/efl/ewk_security_origin_private.h:
12:21 AM Changeset in webkit [150791] by sergio@webkit.org
  • 6 edits in trunk

Web Inspector: Enable CSS logging
​https://bugs.webkit.org/show_bug.cgi?id=113401

Reviewed by Benjamin Poulain.

From Blink r149265 by <​serya@chromium.org>

Source/WebCore:

CSS logging was disabled in r147028 to prevent message overflow in
the inspector console. This change restores it by modifying the
CSS grammar in order to reduce as much consecutive errors as
possible in 'declaration_list' and 'decl_list' rules.

This way, for rules like 'x { color: ### }' only the first '#'
will be reported as error (instead of 3 identical errors).

The rule 'declaration' still produces multiple errors, because it
does not eat as much errors as possible. So in order not to create
a complex risky patch we just disable logging in the parser for
that rule.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::syntaxError):
(WebCore::CSSParser::isLoggingErrors):
(WebCore::CSSParser::rewriteSpecifiers):

  • css/CSSParser.h:

(CSSParser):

LayoutTests:

Unskipped console-css-warnings.html now that it's working.

12:18 AM Changeset in webkit [150790] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source

[EFL] pc files should have harfbuzz dependency.
​https://bugs.webkit.org/show_bug.cgi?id=116852

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

  • ewebkit.pc.in: Added harfbuzz as Required package.

Source/WebKit2:

  • efl/ewebkit2.pc.in: Added harfbuzz as Required package.
12:02 AM Changeset in webkit [150789] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r150730.

  • platform/graphics/FontFallbackList.cpp:

(WebCore::FontGlyphs::glyphDataAndPageForCharacter):

Note: See TracTimeline for information about the timeline view.