Timeline



Aug 9, 2013:

8:29 PM Changeset in webkit [153920] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in com.apple.WebKit.WebContent at com.apple.MediaToolbox.
https://bugs.webkit.org/show_bug.cgi?id=119645

Reviewed by Eric Carlson.

Work around crash caused by <rdar://problem/14688471> by releasing
m_request as soon as keys have been added to it.

  • Modules/encryptedmedia/CDMPrivateAVFoundation.mm:

(WebCore::CDMSessionAVFoundation::update):

6:43 PM Changeset in webkit [153919] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

6:41 PM Changeset in webkit [153918] by Lucas Forschler
  • 1 copy in tags/Safari-537.56

New Tag.

5:36 PM Changeset in webkit [153917] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Artifacts seen sometimes with layer backed WebKit1 plug-in
https://bugs.webkit.org/show_bug.cgi?id=119647
<rdar://problem/14002715>

Reviewed by Beth Dakin.

Don't try to paint layer backed views - they will be painted by Core Animation.

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

5:07 PM Changeset in webkit [153916] by ap@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Merge an encoding test from Blink
https://bugs.webkit.org/show_bug.cgi?id=116943

Original patch by Adam Barth.

  • fast/encoding/meta-overrules-auto-expected.txt: Added.
  • fast/encoding/meta-overrules-auto.html: Added.
  • fast/encoding/resources/meta-input-encoding.html: Added.
5:01 PM Changeset in webkit [153915] by ap@apple.com
  • 36 edits
    5 deletes in trunk/LayoutTests

Tests that dump delegate calls are flaky because of cached redirects
https://bugs.webkit.org/show_bug.cgi?id=119641

Reviewed by Brady Eidson.

Made redirect.php emit Cache-Control: no store as a workaround for bug 77538.
Removed several reimplementations of it, and changed the test to use the
central copy.

  • http/tests/permissionclient/resources/redir.php: Removed.
  • http/tests/resources/redirect.php:
  • http/tests/security/beforeload-iframe-server-redirect-expected.txt:
  • http/tests/security/beforeload-iframe-server-redirect.html:
  • http/tests/security/cannot-read-cssrules-redirect.html:
  • http/tests/security/canvas-remote-read-redirect-to-remote-image.html:
  • http/tests/security/canvas-remote-read-remote-image-redirect.html:
  • http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked.html:
  • http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:
  • http/tests/security/contentSecurityPolicy/resources/redir.php: Removed.
  • http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
  • http/tests/security/contentSecurityPolicy/script-src-redirect.html:
  • http/tests/security/cross-origin-css.html:
  • http/tests/security/cross-origin-script-window-onerror-redirected.html:
  • http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
  • http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-frame.html:
  • http/tests/security/mixedContent/resources/frame-with-redirect-http-to-https-script.html:
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-frame.html:
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-script.html:
  • http/tests/security/redirect-BLOCKED-to-localURL.html:
  • http/tests/security/resources/cross-origin-xsl-redirect.xml:
  • http/tests/security/resources/redir.php: Removed.
  • http/tests/security/resources/xsl-using-document-redirect.xsl:
  • http/tests/security/resources/xsl-using-external-entity-redirect.xsl:
  • http/tests/security/stylesheet-href-redirect-expected.txt:
  • http/tests/security/stylesheet-href-redirect.html:
  • http/tests/security/xssAuditor/block-does-not-leak-referrer.html:
  • http/tests/security/xssAuditor/resources/redir.php: Removed.
  • http/tests/security/xssAuditor/script-tag-open-redirect.html:
  • http/tests/security/xssAuditor/script-tag-redirect.html:
  • http/tests/xmlhttprequest/redirect-cross-origin-2.html:
  • http/tests/xmlhttprequest/redirect-cross-origin-post-sync.html:
  • http/tests/xmlhttprequest/redirect-cross-origin-post.html:
  • http/tests/xmlhttprequest/redirect-cross-origin-sync-double.html:
  • http/tests/xmlhttprequest/redirect-cross-origin-sync.html:
  • http/tests/xmlhttprequest/redirect-cross-origin.html:
  • http/tests/xmlhttprequest/resources/redirect.php: Removed.
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html:
4:30 PM Changeset in webkit [153914] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff
https://bugs.webkit.org/show_bug.cgi?id=119623

Reviewed by Dirk Schulze.

Source/WebCore:

Include all the stroke attributes in the style diff comparison, the visited links ones were missing.

Test: svg/animations/animate-stroke-crasher.html

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::diff):

LayoutTests:

Add testcase from bug with small adjustments.

  • svg/animations/animate-stroke-crasher-expected.txt: Added.
  • svg/animations/animate-stroke-crasher.html: Added.
4:25 PM Changeset in webkit [153913] by ap@apple.com
  • 8 edits
    2 adds in trunk

REGRESSION (r142755): window.open creates an invisible window when width and height are 0
https://bugs.webkit.org/show_bug.cgi?id=119633

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/Window/open-zero-size-as-default.html

Relying on each WebKit to refuse setting size to zero was fragile - because this
required each one to have the check, and because by the time the client was called,
the initially zero size was not necessarily zero.

  • loader/FrameLoader.cpp: (WebCore::createWindow): When sizes are zero, keep the

size the window was created with, because that's the default one by definition.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::adjustWindowRect): It's too late to

check for zero size now, it's been mangled to adjust for the difference between
window and viewport size.

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::setWindowRect):

Once again, the passed rect cannot be empty.

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setWindowRect):

Once again, the passed rect cannot be empty.

LayoutTests:

  • fast/dom/Window/open-zero-size-as-default-expected.txt: Added.
  • fast/dom/Window/open-zero-size-as-default.html: Added.
4:09 PM Changeset in webkit [153912] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] some track language tags are not recognized
https://bugs.webkit.org/show_bug.cgi?id=119643

Reviewed by Dean Jackson.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Always call languageOfPrimaryAudioTrack(),

a track may have changed so we may have a new language.

(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Call [AVAssetTrack languageCode]

if [AVAssetTrack extendedLanguageTag] returns NULL in case the media file has an old
QuickTime language code.

4:00 PM Changeset in webkit [153911] by Lucas Forschler
  • 10 edits
    1 copy in branches/safari-537-branch

Merged r153907. <rdar://problem/14281275>

3:56 PM Changeset in webkit [153910] by ap@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/navigation/back-twice-without-commit.html times out
https://bugs.webkit.org/show_bug.cgi?id=82980

  • platform/mac/TestExpectations: Marked as such again, reverting r153842.
3:46 PM Changeset in webkit [153909] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Captions menu needs to reset text-align
https://bugs.webkit.org/show_bug.cgi?id=119637

Reviewed by Eric Carlson.

Reset the text-align property on the menu so that it
doesn't get the inherited value. The full fix for all
controls is http://webkit.org/b/116100.

  • css/mediaControlsQuickTime.css:

(video::-webkit-media-controls-closed-captions-container):

2:12 PM Changeset in webkit [153908] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK] Misses mod_ssl and php in the list of packages required for tests for yum
https://bugs.webkit.org/show_bug.cgi?id=115751

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-08-09
Reviewed by Martin Robinson.

  • gtk/install-dependencies: add mod_ssl and php to the packages installed for tests

with yum.

12:58 PM Changeset in webkit [153907] by Beth Dakin
  • 10 edits
    1 add in trunk

AX: Not able to use arrow keys to read text in a WK2 app
https://bugs.webkit.org/show_bug.cgi?id=119605
-and corresponding-
<rdar://problem/14281275>

Reviewed by Darin Adler.

Source/WebCore:

This code from defaultKeyboardEventHandler() is the magic that makes this AX
functionality work. This patch moves that into a separate function so that we can
call it from WK2.

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleKeyboardSelectionMovementForAccessibility):
(WebCore::EventHandler::defaultKeyboardEventHandler):

  • page/EventHandler.h:

Source/WebKit2:

Make all of these scrolling functions actually return the WebCore bools that
indicate whether or not scrolling happened.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scroll):
(WebKit::WebPage::logicalScroll):
(WebKit::WebPage::scrollBy):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::executeKeypressCommandsInternal):

This function now gives accessibility a chance to handle the event too. And it
also actually tracks whether or not the event was handled by scrolling instead of
assuming that it was and universally returning true.
(WebKit::WebPage::performNonEditingBehaviorForSelector):

Tools:

New test verifies that didNotHandleKeyEvent will be called when there is nothing
to scroll.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didNotHandleKeyEventCallback):
(TestWebKitAPI::TEST):

12:44 PM Changeset in webkit [153906] by Antti Koivisto
  • 15 edits
    4 adds in trunk/Source/WebCore

Move static StyleResolver functions to Style namespace
https://bugs.webkit.org/show_bug.cgi?id=119629

Reviewed by Sam Weinig and Andreas Kling.

  • Move static font size computation functions to StyleFontSizeFunctions.h/.cpp
  • Move StyleResolver::styleForDocument to Style::resolveForDocument
  • WebCore.xcodeproj/project.pbxproj:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyFontFamily::applyInitialValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::checkForOrientationChange):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::checkForGenericFamilyChange):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):

  • css/StyleResolver.h:
  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • editing/EditingStyle.cpp:

(WebCore::legacyFontSizeFromCSSValue):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getFontAndGlyphOrientation):

Moved from StyleResolver.cpp so it can be used by Style::resolveForDocument().
This depends on RenderStyle only so it is a natural member function.

  • rendering/style/RenderStyle.h:
  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

  • style/StyleFontSizeFunctions.cpp: Copied from Source/WebCore/css/StyleResolver.cpp.

(WebCore::Style::computedFontSizeFromSpecifiedSize):
(WebCore::Style::computedFontSizeFromSpecifiedSizeForSVGInlineText):
(WebCore::Style::fontSizeForKeyword):
(WebCore::Style::legacyFontSizeForPixelSize):

  • style/StyleFontSizeFunctions.h: Added.
  • style/StyleResolveForDocument.cpp: Added.

(WebCore::Style::resolveForDocument):

  • style/StyleResolveForDocument.h: Added.
11:56 AM Changeset in webkit [153905] by Christophe Dumez
  • 26 edits in trunk

Add support for KeyboardEvent.location attribute
https://bugs.webkit.org/show_bug.cgi?id=119326

Reviewed by Benjamin Poulain.

Source/WebCore:

Add support for KeyboardEvent.location attribute as per the latest specification:
http://dev.w3.org/2006/webapi/DOM-Level-3-Events/html/DOM3-Events.html#events-KeyboardEvent

IE10, Firefox 22 and recently Blink all support KeyboardEvent.location already.

The deprecated 'keyLocation' attribute was not removed to maintain backward
compatibility.

No new tests, covered by existing tests.

  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

  • dom/KeyboardEvent.cpp:

(WebCore::KeyboardEventInit::KeyboardEventInit):
(WebCore::KeyboardEvent::KeyboardEvent):
(WebCore::KeyboardEvent::initKeyboardEvent):

  • dom/KeyboardEvent.h:

(WebCore::KeyboardEvent::location):

  • dom/KeyboardEvent.idl:

Source/WebKit/win:

Add new location attribute to DOMKeyboardEvent.

  • DOMEventsClasses.cpp:

(DOMKeyboardEvent::location):

  • DOMEventsClasses.h:
  • Interfaces/DOMEvents.idl:

Tools:

Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.

  • DumpRenderTree/mac/EventSendingController.mm:

(-[EventSendingController keyDown:withModifiers:withLocation:]):
(-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
(-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
(-[EventSendingController handleEvent:]):
(-[EventSendingController fireKeyboardEventsToElement:]):

LayoutTests:

Rename KeyboardEvent.keyLocation to KeyboardEvent.location in the
tests and add test cases to make sure that the deprecated
KeyboardEvent.keyLocation still works.

  • fast/events/arrow-keys-on-body-expected.txt:
  • fast/events/arrow-keys-on-body.html:
  • fast/events/constructors/keyboard-event-constructor-expected.txt:
  • fast/events/constructors/keyboard-event-constructor.html:
  • fast/events/init-events-expected.txt:
  • fast/events/js-keyboard-event-creation.html:
  • fast/events/keydown-leftright-keys-expected.txt:
  • fast/events/keydown-leftright-keys.html:
  • fast/events/keydown-numpad-keys-expected.txt:
  • fast/events/script-tests/init-events.js:
  • fast/events/script-tests/keydown-numpad-keys.js:

(recordKeyEvent):
(testKeyEventWithLocation):

  • platform/mac/fast/events/objc-keyboard-event-creation.html:
  • platform/win/fast/events/keyLocation-numpad.html:
11:54 AM Changeset in webkit [153904] by Christophe Dumez
  • 8 edits in trunk

Make atob() throw an InvalidCharacterError on excess padding characters
https://bugs.webkit.org/show_bug.cgi?id=118898

Reviewed by Darin Adler.

Source/WebCore:

According to the latest specification, window.atob() should throw an
InvalidCharacterError on excess padding characters:
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#dom-windowbase64-atob

This behavior is consistent with both Firefox, IE10 and recently Blink.

No new tests, already covered by:
fast/dom/Window/atob-btoa.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::atob):

Source/WTF:

Add a Base64FailOnInvalidCharacterOrExcessPadding value to the Base64DecodePolicy
enumeration so that the caller can request strict padding validation in addition
to strict character validation. This is needed so that we can use
WTF::base64Decode() for window.atob().

  • wtf/text/Base64.cpp:

(WTF::base64DecodeInternal):

  • wtf/text/Base64.h:

LayoutTests:

Update and rebaseline fast/dom/Window/atob-btoa.html now that window.atob()'s
behavior has changed and now that we throw an InvalidCharacterError on excess
pad characters.

  • fast/dom/Window/atob-btoa-expected.txt:
  • fast/dom/Window/atob-btoa.html:
11:40 AM Changeset in webkit [153903] by ap@apple.com
  • 44 edits in trunk

<unknown> is often dumped instead of path in test output
https://bugs.webkit.org/show_bug.cgi?id=119590

Reviewed by Anders Carlsson.

Tools:

There were two reasons for <unknown>:

  1. When delegate logging is enabled via a testRunner call, that obviously happens

after main resource load starts, so we don't record its URL.

  1. Authentication delegate logging relied on URL recording, but it's only turned on

when enabling resource loading delegate logging, not auth one.

URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
landed without posted rationale and unreviewed. Just undoing that change now.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm:

(-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didInitiateLoadForResource):

LayoutTests:

Updating test results.

  • fast/loader/file-protocol-fragment-expected.txt:
  • fast/loader/main-document-url-for-non-http-loads-expected.txt:
  • http/tests/cache/iframe-304-crash-expected.txt:
  • http/tests/cache/willsendrequest-returns-null-for-memory-cache-load-expected.txt:
  • http/tests/loading/307-after-303-after-post-expected.txt:
  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt:
  • http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
  • http/tests/loading/basic-credentials-sent-automatically-expected.txt:
  • http/tests/loading/redirect-methods-expected.txt:
  • http/tests/misc/401-alternative-content-expected.txt:
  • http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt:
  • http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt:
  • http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt:
  • http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
  • http/tests/misc/link-rel-icon-beforeload-expected.txt:
  • http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
  • http/tests/misc/window-dot-stop-expected.txt:
  • http/tests/security/401-logout/401-logout-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/xmlhttprequest/failed-auth-expected.txt:
  • http/tests/xmlhttprequest/remember-bad-password-expected.txt:
  • loader/go-back-cached-main-resource-expected.txt:
  • platform/efl-wk2/loader/go-back-cached-main-resource-expected.txt:
  • platform/mac/fast/images/support-broken-image-delegate-expected.txt:
  • platform/mac/security/block-test-expected.txt:
  • platform/mac/security/block-test-no-port-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
  • webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt:
10:35 AM Changeset in webkit [153902] by commit-queue@webkit.org
  • 45 edits in trunk/LayoutTests

Modify the existing canvas blending test suite to test both
accelerated and non accelerated modes.
https://bugs.webkit.org/show_bug.cgi?id=119628

Patch by Mihai Tica <mitica@adobe.com> on 2013-08-09
Reviewed by Dirk Schulze.

  • fast/canvas/canvas-blending-clipping-expected.txt:
  • fast/canvas/canvas-blending-clipping.html:
  • fast/canvas/canvas-blending-color-over-color-expected.txt:
  • fast/canvas/canvas-blending-color-over-color.html:
  • fast/canvas/canvas-blending-color-over-gradient-expected.txt:
  • fast/canvas/canvas-blending-color-over-gradient.html:
  • fast/canvas/canvas-blending-color-over-image-expected.txt:
  • fast/canvas/canvas-blending-color-over-image.html:
  • fast/canvas/canvas-blending-color-over-pattern-expected.txt:
  • fast/canvas/canvas-blending-color-over-pattern.html:
  • fast/canvas/canvas-blending-fill-style-expected.txt:
  • fast/canvas/canvas-blending-fill-style.html:
  • fast/canvas/canvas-blending-global-alpha-expected.txt:
  • fast/canvas/canvas-blending-global-alpha.html:
  • fast/canvas/canvas-blending-gradient-over-color-expected.txt:
  • fast/canvas/canvas-blending-gradient-over-color.html:
  • fast/canvas/canvas-blending-gradient-over-gradient-expected.txt:
  • fast/canvas/canvas-blending-gradient-over-gradient.html:
  • fast/canvas/canvas-blending-gradient-over-image-expected.txt:
  • fast/canvas/canvas-blending-gradient-over-image.html:
  • fast/canvas/canvas-blending-gradient-over-pattern-expected.txt:
  • fast/canvas/canvas-blending-gradient-over-pattern.html:
  • fast/canvas/canvas-blending-image-over-color-expected.txt:
  • fast/canvas/canvas-blending-image-over-color.html:
  • fast/canvas/canvas-blending-image-over-gradient-expected.txt:
  • fast/canvas/canvas-blending-image-over-gradient.html:
  • fast/canvas/canvas-blending-image-over-image-expected.txt:
  • fast/canvas/canvas-blending-image-over-image.html:
  • fast/canvas/canvas-blending-image-over-pattern-expected.txt:
  • fast/canvas/canvas-blending-image-over-pattern.html:
  • fast/canvas/canvas-blending-pattern-over-color-expected.txt:
  • fast/canvas/canvas-blending-pattern-over-color.html:
  • fast/canvas/canvas-blending-pattern-over-gradient-expected.txt:
  • fast/canvas/canvas-blending-pattern-over-gradient.html:
  • fast/canvas/canvas-blending-pattern-over-image-expected.txt:
  • fast/canvas/canvas-blending-pattern-over-image.html:
  • fast/canvas/canvas-blending-pattern-over-pattern-expected.txt:
  • fast/canvas/canvas-blending-pattern-over-pattern.html:
  • fast/canvas/canvas-blending-shadow-expected.txt:
  • fast/canvas/canvas-blending-shadow.html:
  • fast/canvas/canvas-blending-text-expected.txt:
  • fast/canvas/canvas-blending-text.html:
  • fast/canvas/canvas-blending-transforms-expected.txt:
  • fast/canvas/canvas-blending-transforms.html:
10:31 AM Changeset in webkit [153901] by Christophe Dumez
  • 44 edits in trunk

Make DOMImplementation::hasFeature() behave according to specification
https://bugs.webkit.org/show_bug.cgi?id=119329

Reviewed by Ryosuke Niwa.

Source/WebCore:

Make DOMImplementation::hasFeature() behave according to the latest specification:
http://dom.spec.whatwg.org/#dom-domimplementation-hasfeature

Specifically, the function should now return true unconditionally for any non-SVG feature.
This behavior is consistent with Firefox and since recently Blink.

hasFeature() originally would report whether the user agent claimed to support a
given DOM feature, but experience proved it was not nearly as reliable or granular
as simply checking whether the desired interfaces, attributes, or methods existed.
As such, it should no longer be used, but continues to exist (and simply returns
true) so that old pages don't stop working.

No new tests, covered by existing tests.

  • dom/DOMImplementation.cpp:

(WebCore::isSupportedSVG10Feature):
(WebCore::isSupportedSVG11Feature):
(WebCore::DOMImplementation::hasFeature):

LayoutTests:

Rebaseline several test cases now that DOMImplementation::hasFeature() returns
true unconditionally for non-SVG features.

Also use a valid svg prefix for unknown features in SVG tests so that they are
properly recognized as SVG features and so that hasFeature() returns false as
expected.

  • dom/xhtml/level3/core/hasFeature01-expected.txt:
  • dom/xhtml/level3/core/hasFeature02-expected.txt:
  • dom/xhtml/level3/core/hasFeature03-expected.txt:
  • dom/xhtml/level3/core/hasFeature04-expected.txt:
  • fast/dom/features-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • svg/custom/outer-svg-unknown-feature.svg:
  • svg/dynamic-updates/script-tests/SVGCircleElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGEllipseElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGGElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGGElement-svgdom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGImageElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGImageElement-svgdom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGLineElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGLineElement-svgdom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGPathElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGPathElement-svgdom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGPolygonElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGPolygonElement-svgdom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGPolylineElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGPolylineElement-svgdom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGRectElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGRectElement-svgdom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGSVGElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGSVGElement-svgdom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGTextElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGTextElement-svgdom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGUseElement-dom-requiredFeatures.js:

(repaintTest):

  • svg/dynamic-updates/script-tests/SVGUseElement-svgdom-requiredFeatures.js:

(repaintTest):

10:25 AM Changeset in webkit [153900] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge 153749 - webkit-gtk fails to build with bison-3.0
https://bugs.webkit.org/show_bug.cgi?id=119373

Reviewed by Gustavo Noronha Silva.

Source/ThirdParty/ANGLE:

  • GNUmakefile.am: Stop relying on generated glslang_tab.(cpp|h) and glslang.cpp sources as Bison 3.0

produces non-compilable source code. Instead, compile these pregenerated files as they're included in
the tree. Originally, the ANGLE source tree provides these files as generated by Bison 2.7, but they're
at the moment regenerated with Bison 2.3 when the third-party ANGLE source is being updated.

Source/WebCore:

  • GNUmakefile.am: Remove rules for generating ANGLE's glslang source files with Bison.

Conflicts:

Source/ThirdParty/ANGLE/GNUmakefile.am
Source/WebCore/GNUmakefile.am

10:24 AM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
10:09 AM Changeset in webkit [153899] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153809. <rdar://problem/14669029>

10:00 AM Changeset in webkit [153898] by alex
  • 3 edits in trunk/Source/WebCore

[GTK] [EFL] Enable tiled shadow blur for the inset shadows.
https://bugs.webkit.org/show_bug.cgi?id=119078

Reviewed by Martin Robinson.

Already covered in the tests.

  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::fillCurrentCairoPath): Added to allow fill the path
without the shadow.
(WebCore::shadowAndFillCurrentCairoPath):
(WebCore::GraphicsContext::fillRectWithRoundedHole): Added cairo
implementation.

9:53 AM Changeset in webkit [153897] by Simon Fraser
  • 7 edits in trunk/LayoutTests

move-by-word-visually-multi-space.html takes 21s and spends most of its time doing spelling and grammar checking
https://bugs.webkit.org/show_bug.cgi?id=119613

Reviewed by Darin Adler.

editing/selection tests are very slow, and much of the time is spent
doing spelling and grammar checking (which is not what these tests are
testing). So call internals.setContinuousSpellCheckingEnabled(false)
to turn that off.

  • editing/selection/caret-at-bidi-boundary.html:
  • editing/selection/move-by-character-brute-force.html:
  • editing/selection/move-left-right.html:
  • editing/selection/programmatic-selection-on-mac-is-directionless.html:
  • editing/selection/resources/extend-selection.js:
  • editing/selection/resources/move-by-word-visually.js:

(runTest):

9:07 AM Changeset in webkit [153896] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Viewport allows scrolling when it shouldn't after rotation to landscape
https://bugs.webkit.org/show_bug.cgi?id=119595

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-08-09
Reviewed by Rob Buis.
Internally reviewed by Konrad Piascik, Max Feil, Arvid Nilsson and John Griggs.

JIRA 466384
Initial scales of portrait mode and landscape mode can be different due
to different viewport size and contents size. In this case, we restored
to the intial scale of portrait mode instead of the initial scale of current
landscape mode which zoomed in the WebPage a little bit and made the WebPage
scallable as the scale is larger than the initial scale of the current
landscape mode WebPage.
To fix that, we should restore to the current initial scale instead if
the WebPage was at initial scale before fullscreen.
Meanwhile, move the FIXME comments to the right place.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):

  • Api/WebPage_p.h:
8:28 AM Changeset in webkit [153895] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Don't release the canvas Drawable, flush it directly instead.
https://bugs.webkit.org/show_bug.cgi?id=119589
https://jira.bbqnx.net/browse/BRWSR-12531
JIRA 444857

Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-08-09
Reviewed by George Staikos.

The previous code here used releaseBufferDrawable() to
flush painted ImageBuffer contents, but then proceeded
to use that released Drawable for further painting
without ever locking a new one.

In an implementation that actually releases the Drawable
rather than keeping it around and just flushing it,
this will wreak havoc as bad as black screens or crashes.

As a solution that doesn't require the ImageBuffer object
to swap out its m_canvas member for a new Drawable, we can
access the PlatformGraphicsContext::flush() method directly
to achieve the same effect as was previously intended by
calling releaseBufferDrawable(). All it needs is letting
the canvas layer know about the Drawable so it can call
that flush() method by itself.

No new tests, verified by not crashing with an aforementioned
implementation of releaseBufferDrawable().

  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(WebCore::CanvasLayerCompositingThreadClient::CanvasLayerCompositingThreadClient):
(WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):

  • platform/graphics/blackberry/CanvasLayerWebKitThread.h:

(WebCore::CanvasLayerWebKitThread::create):

  • platform/graphics/blackberry/ImageBufferBlackBerry.cpp:

(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):

8:26 AM Changeset in webkit [153894] by timothy@apple.com
  • 25 edits
    42 deletes in trunk/Source/WebInspectorUI

Switch the generated images off of PDFs and onto SVGs now that bug 119492 is fixed.

https://bugs.webkit.org/show_bug.cgi?id=118677

Reviewed by Joseph Pecoraro.

  • UserInterface/ApplicationCacheDetailsSidebarPanel.js:

(WebInspector.ApplicationCacheDetailsSidebarPanel):

  • UserInterface/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection):

  • UserInterface/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel):

  • UserInterface/ContentBrowser.js:

(WebInspector.ContentBrowser):

  • UserInterface/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel):

  • UserInterface/DOMTreeContentView.js:

(WebInspector.DOMTreeContentView):

  • UserInterface/DataGrid.js:

(WebInspector.DataGrid.prototype._generateSortIndicatorImagesIfNeeded):

  • UserInterface/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel):

  • UserInterface/DetailsSection.js:

(WebInspector.DetailsSection.prototype._generateDisclosureTrianglesIfNeeded):

  • UserInterface/FindBanner.js:

(WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded):

  • UserInterface/Images/BackArrow.pdf: Removed.
  • UserInterface/Images/BottomUpTree.pdf: Removed.
  • UserInterface/Images/Breakpoints.pdf: Removed.
  • UserInterface/Images/Close.pdf: Removed.
  • UserInterface/Images/Crosshair.pdf: Removed.
  • UserInterface/Images/DisclosureTriangleSmallClosed.pdf: Removed.
  • UserInterface/Images/DisclosureTriangleSmallOpen.pdf: Removed.
  • UserInterface/Images/DisclosureTriangleTinyClosed.pdf: Removed.
  • UserInterface/Images/DisclosureTriangleTinyOpen.pdf: Removed.
  • UserInterface/Images/DockBottom.pdf: Removed.
  • UserInterface/Images/DockRight.pdf: Removed.
  • UserInterface/Images/ForwardArrow.pdf: Removed.
  • UserInterface/Images/GoToArrow.pdf: Removed.
  • UserInterface/Images/LayerBorders.pdf: Removed.
  • UserInterface/Images/LessColumns.pdf: Removed.
  • UserInterface/Images/Locked.pdf: Removed.
  • UserInterface/Images/MoreColumns.pdf: Removed.
  • UserInterface/Images/NavigationItemAngleBrackets.pdf: Removed.
  • UserInterface/Images/NavigationItemBrushAndRuler.pdf: Removed.
  • UserInterface/Images/NavigationItemBug.pdf: Removed.
  • UserInterface/Images/NavigationItemCurleyBraces.pdf: Removed.
  • UserInterface/Images/NavigationItemFile.pdf: Removed.
  • UserInterface/Images/NavigationItemLayers.pdf: Removed.
  • UserInterface/Images/NavigationItemLog.pdf: Removed.
  • UserInterface/Images/NavigationItemMagnifyingGlass.pdf: Removed.
  • UserInterface/Images/NavigationItemStopwatch.pdf: Removed.
  • UserInterface/Images/NavigationItemStorage.pdf: Removed.
  • UserInterface/Images/NavigationItemTrash.pdf: Removed.
  • UserInterface/Images/NavigationItemVariable.pdf: Removed.
  • UserInterface/Images/Pause.pdf: Removed.
  • UserInterface/Images/Percent.pdf: Removed.
  • UserInterface/Images/Plus.pdf: Removed.
  • UserInterface/Images/Resume.pdf: Removed.
  • UserInterface/Images/ShadowDOM.pdf: Removed.
  • UserInterface/Images/SortIndicatorDownArrow.pdf: Removed.
  • UserInterface/Images/SortIndicatorUpArrow.pdf: Removed.
  • UserInterface/Images/SplitToggleDown.pdf: Removed.
  • UserInterface/Images/SplitToggleUp.pdf: Removed.
  • UserInterface/Images/StepInto.pdf: Removed.
  • UserInterface/Images/StepOut.pdf: Removed.
  • UserInterface/Images/StepOver.pdf: Removed.
  • UserInterface/Images/Undock.pdf: Removed.
  • UserInterface/InstrumentSidebarPanel.js:

(WebInspector.InstrumentSidebarPanel):

  • UserInterface/JavaScriptProfileView.js:

(WebInspector.JavaScriptProfileView):

  • UserInterface/LayerTreeSidebarPanel.js:

(WebInspector.LayerTreeSidebarPanel):

  • UserInterface/LogContentView.js:

(WebInspector.LogContentView):

  • UserInterface/Main.js:

(WebInspector.contentLoaded):
(WebInspector._updateDockNavigationItems):
(WebInspector._generateDisclosureTriangleImages):

  • UserInterface/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype._generateDisclosureTrianglesIfNeeded):

  • UserInterface/ProfileView.js:

(WebInspector.ProfileView):

  • UserInterface/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel):

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):

  • UserInterface/ScopeChainDetailsSidebarPanel.js:

(WebInspector.ScopeChainDetailsSidebarPanel):

  • UserInterface/ScriptContentView.js:

(WebInspector.ScriptContentView):

  • UserInterface/TextContentView.js:

(WebInspector.TextContentView):

  • UserInterface/TextResourceContentView.js:

(WebInspector.TextResourceContentView):

  • UserInterface/TimelinesContentView.js:
8:00 AM Changeset in webkit [153893] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Composited and transformed links asserts in tap highlight
https://bugs.webkit.org/show_bug.cgi?id=94345

Reviewed by Jocelyn Turcotte.

Use a mapping that does not assert when hitting transforms. We still skip
transforms that produces non-rectangular areas.

  • page/GestureTapHighlighter.cpp:
7:41 AM Changeset in webkit [153892] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/Source/WebCore

Buildfix. Fix warning after r153887:
control reaches end of non-void function [-Werror=return-type]

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-08-09
Reviewed by Csaba Osztrogonác.

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::animatedPropertyTypeSupportsAddition):

7:15 AM Changeset in webkit [153891] by Bruno de Oliveira Abinader
  • 7 edits in trunk

Text decorations should be listed as non-inheritable
https://bugs.webkit.org/show_bug.cgi?id=119608

Reviewed by Andreas Kling.

Source/WebCore:

Both "text-decoration" specs (CSS 2.1, CSS 3) and "text-decoration-line"
spec (CSS 3) states these properties are not inherited (w/ exceptions,
which are currently handled by -in-effect property), however those were
listed as inherited for no reason - thus preserving behavior as shown by
layout test results.

Backported from Blink: https://codereview.chromium.org/20751008

Updated getComputedStyle tests for both 'text-decoration' and
'text-decoration-line' properties to check that both are not implicitly
inherited.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

LayoutTests:

Added test to verify that 'text-decoration' and 'text-decoration-line'
properties are not implicitly inherited.

  • fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt:
  • fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js:
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt:
  • fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js:
7:14 AM Changeset in webkit [153890] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

I wish we had a Windows EWS. :(

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::doCollectMatchingRulesForList): No range-based for today.

7:05 AM Changeset in webkit [153889] by zarvai@inf.u-szeged.hu
  • 6 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselinnig some new tests.

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt-5.0-wk2/compositing/overflow-trumps-transform-style-expected.txt:
  • platform/qt-5.0-wk2/fast/repaint/caret-jump-between-nodes-expected.txt: Added.
  • platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.png:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/repaint/caret-jump-between-nodes-expected.txt: Added.
6:26 AM Changeset in webkit [153888] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/Source/ThirdParty/ANGLE

[Qt] Buidfix after r153664. Adding ANGLE_WEBKIT_WIN definition.
https://bugs.webkit.org/show_bug.cgi?id=119577

Reviewed by Allan Sandfeld Jensen.

  • Target.pri:
6:23 AM Changeset in webkit [153887] by rwlbuis@webkit.org
  • 4 edits
    4 adds in trunk

ASSERT_NOT_REACHED() touched in WebCore::SVGAnimatedStringAnimator::addAnimatedTypes
https://bugs.webkit.org/show_bug.cgi?id=113224

Source/WebCore:

Reviewed by Darin Adler.

Do not perform from-by animations for non-additive attributes.

Test: svg/animations/non-additive-type-from-by-animation.html

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::animatedPropertyTypeSupportsAddition):
(WebCore::SVGAnimateElement::isAdditive):

  • svg/SVGAnimateElement.h:

LayoutTests:

Reviewed by Dirk Schulze.

Add a test for animating non-additive attributes in from-by animations

  • svg/animations/non-additive-type-from-by-animation-expected.txt: Added.
  • svg/animations/non-additive-type-from-by-animation.html: Added.
  • svg/animations/resources/non-additive-type-from-by-animation.svg: Added.
  • svg/animations/script-tests/non-additive-type-from-by-animation.js: Added.

(sample):
(executeTest):

6:05 AM Changeset in webkit [153886] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

ASSERT(m_type == toSVGTransform.type())
https://bugs.webkit.org/show_bug.cgi?id=113217

Reviewed by Darin Adler.

Source/WebCore:

For to animations clear the transform list while animating and reset to it after the animation is done.
This matches Firefox and Opera 12 behavior.

Tests: svg/animations/animateTransform-to-scale-expected.svg

svg/animations/animateTransform-to-scale.svg

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::calculateAnimatedValue):

LayoutTests:

Add reftest for additive to animation where from and to transform types differ.

  • svg/animations/animateTransform-to-scale-expected.svg: Added.
  • svg/animations/animateTransform-to-scale.svg: Added.
5:48 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com
Add r153749 to the list of proposed merges for 2.0.5. (diff)
5:46 AM Changeset in webkit [153885] by zandobersek@gmail.com
  • 4 edits in trunk

[Automake] Clean up OpenGL graphics configuration sections
https://bugs.webkit.org/show_bug.cgi?id=119554

Reviewed by Martin Robinson.

Clean up sections in the Automake configuration process that are configuring the OpenGL graphics
features and dependencies. Remove unnecessary variable assignments, merge similar code paths,
clarify a couple of comments and error messages and fix a few whitespace problems.

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/ReadCommandLineArguments.m4:
  • Source/autotools/SetupAutomake.m4:
5:11 AM Changeset in webkit [153884] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Qt] QtWebKit should allow sending domain specific keycode to HTML applications
https://bugs.webkit.org/show_bug.cgi?id=118445

Patch by Arunprasad Rajkumar <arurajku@cisco.com> on 2013-08-09
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

No new test required, it is covered by QtWebKit API test.

This fix allows sending QKeyEvent::nativeVirtualKey as the DOM KeyboardEvent keyCode value instead
of Windows virtual key code. It can be enabled/disabled using "_q_useNativeVirtualKeyAsDOMKey"
dynamic property present in QWebPage.

  • platform/PlatformKeyboardEvent.h:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/qt/PlatformKeyboardEventQt.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):

Source/WebKit/qt:

Added API test.

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::QWebPageAdapter):
(QWebPageAdapter::dynamicPropertyChangeEvent):
(QWebPageAdapter::handleKeyEvent):

  • WebCoreSupport/QWebPageAdapter.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::domainSpecificKeyEvent):

5:08 AM Changeset in webkit [153883] by reni@webkit.org
  • 3 edits
    2 adds in trunk

Missing NULL check in ApplyStyleCommand::applyInlineStyleToNodeRange()
https://bugs.webkit.org/show_bug.cgi?id=119570

Reviewed by Ryosuke Niwa.

Source/WebCore:

The m_mutableStyleSet of EditingStyle can be NULL in ApplyStyleCommand::applyInlineStyleToNodeRange but
this scenario was not checked earlier.

Test: editing/execCommand/null-style-crash.html

  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::mergeAndOverrideOnConflict):

  • css/StylePropertySet.h:
  • css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::addViewportRule):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):

  • editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):

LayoutTests:

  • editing/execCommand/null-style-crash-expected.txt: Added.
  • editing/execCommand/null-style-crash.html: Added.
3:53 AM WebKitGTK/WebKit2Roadmap edited by brian.holt@samsung.com
(diff)
3:52 AM WebKitGTK/WebKit2Roadmap edited by brian.holt@samsung.com
(diff)
3:48 AM Changeset in webkit [153882] by commit-queue@webkit.org
  • 11 edits
    6 adds in trunk/Source/WebKit2

[GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=99352

Patch by Brian Holt <brian.holt@samsung.com> on 2013-08-09
Reviewed by Carlos Garcia Campos.

Add a new public class to the API, WebKitAuthenticationRequest, to be
emitted along with a new WebKitWebView::authenticate signal to
let client applications to provide their own authentication
when the user is challenged with HTTP authentication. The
credential is exposed through a new class WebKitCredential.

  • GNUmakefile.list.am:
  • UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(okButtonClicked): Use new API for authentication.
(cancelButtonClicked): Ditto.
(webkitAuthenticationDialogInitialize):Get
authenticationChallenge from request object.
(webkitAuthenticationDialogNew): Ditto.

  • UIProcess/API/gtk/WebKitAuthenticationDialog.h:
  • UIProcess/API/gtk/WebKitAuthenticationRequest.cpp: Added new

class representing a HTTP authentication request.
(webkitAuthenticationRequestDispose):
(webkit_authentication_request_class_init):
(webkitAuthenticationRequestCreate):
(webkitAuthenticationRequestGetAuthenticationChallenge):
(webkit_authentication_request_can_save_credentials):
(webkit_authentication_request_get_proposed_credential):
(webkit_authentication_request_get_host):
(webkit_authentication_request_get_port):
(webkit_authentication_request_get_realm):
(webkit_authentication_request_get_scheme):
(webkit_authentication_request_is_for_proxy):
(webkit_authentication_request_is_retry):
(webkit_authentication_request_authenticate):
(webkit_authentication_request_cancel):

  • UIProcess/API/gtk/WebKitAuthenticationRequest.h: Added.
  • UIProcess/API/gtk/WebKitAuthenticationRequestPrivate.h: Added.
  • UIProcess/API/gtk/WebKitCredential.cpp: Added new class to

support credentials for HTTP authentication.
(_WebKitCredential::_WebKitCredential):
(webkitCredentialCreate):
(webkitCredentialGetCredential):
(webkit_credential_new):
(webkit_credential_copy):
(webkit_credential_free):
(webkit_credential_get_username):
(webkit_credential_get_password):
(webkit_credential_has_password):
(webkit_credential_get_persistence):

  • UIProcess/API/gtk/WebKitCredential.h: Added.
  • UIProcess/API/gtk/WebKitCredentialPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp: Added authenticate signal.

(webkitWebViewAuthenticate): Default signal handler for authenticate.
(webkit_web_view_class_init): Ditto.
(webkitWebViewHandleAuthenticationChallenge): Create an
authentication request and emit it with authenticate signal.

  • UIProcess/API/gtk/WebKitWebView.h: Replaced reserved function

pointer slot with for WebViewClass with function pointer to
authenticate signal handler.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Added new section for

the authentication request.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Added authentication

request and credential types.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp: Created a new

unit test for HTTP authentication. A libsoup server callback
handler is installed that creates soup messages with appropriate
headers and body to test HTTP authentication.
(testWebViewAuthenticationRequest): Test the authentication
request and credential API.
(testWebViewAuthenticationCancel): Test cancelled authentication.
(testWebViewAuthenticationFailure): Test repeated authentication failures.
(testWebViewAuthenticationNoCredential): Test continue without
credentials.
(testWebViewAuthenticationStorage): Test credential storage.
(testWebViewAuthenticationSuccess): Test successful authentication.
(beforeAll): Added tests.

  • UIProcess/API/gtk/webkit2.h: Added WebKitAuthenticationRequest and

WebKitCredential headers.

3:15 AM Changeset in webkit [153881] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

ElementRuleCollector: Use range-based for syntax in rule collection loop.
<http://webkit.org/b/119617>
<rdar://problem/14695311>

Reviewed by Antti Koivisto.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::doCollectMatchingRulesForList):

2:58 AM Changeset in webkit [153880] by akling@apple.com
  • 27 edits in trunk/Source

StyleRule*::properties() should return const references.
<http://webkit.org/b/119596>

Reviewed by Antti Koivisto.

Source/WebCore:

Make StyleRule::properties() & friends return const-references instead of
pointers. This exposed some pointless null checking, since rules should
always have properties.

All rule objects that contain properties now require a StylePropertySet at
the time of construction instead having you call setProperties() later.

The only rules that could ever have null properties were the default-inserted
animation keyframe rules for 0% and 100% that we'd conjure up if the author
didn't provide them. Now they just have an empty property set instead.

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::cssText):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::cssText):

  • css/CSSParser.cpp:

(WebCore::CSSParser::createFilterRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::rewriteSpecifiers):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::cssText):

  • css/ElementRuleCollector.cpp:

(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::doCollectMatchingRulesForList):

  • css/PageRuleCollector.cpp:

(WebCore::PageRuleCollector::matchPageRulesForList):

  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::mergeAndOverrideOnConflict):

  • css/StylePropertySet.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):

  • css/StyleResolver.h:
  • css/StyleRule.cpp:

(WebCore::StyleRule::StyleRule):
(WebCore::StyleRule::create):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleViewport::StyleRuleViewport):
(WebCore::StyleRuleViewport::mutableProperties):
(WebCore::StyleRuleFilter::StyleRuleFilter):

  • css/StyleRule.h:

(WebCore::StyleRule::create):
(WebCore::StyleRule::properties):
(WebCore::StyleRuleFontFace::create):
(WebCore::StyleRuleFontFace::properties):
(WebCore::StyleRulePage::create):
(WebCore::StyleRulePage::properties):
(WebCore::StyleRuleViewport::create):
(WebCore::StyleRuleViewport::properties):
(WebCore::StyleRuleFilter::create):
(WebCore::StyleRuleFilter::properties):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::addSubresourceStyleURLs):
(WebCore::childRulesHaveFailedOrCanceledSubresources):

  • css/WebKitCSSFilterRule.cpp:

(WebCore::WebKitCSSFilterRule::cssText):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::StyleKeyframe):
(WebCore::StyleKeyframe::mutableProperties):

  • css/WebKitCSSKeyframeRule.h:

(WebCore::StyleKeyframe::create):
(WebCore::StyleKeyframe::properties):

  • css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::cssText):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::revalidateStyle):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::retrieveResourcesForRule):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::fontFamily):
(WebCore::SVGFontFaceElement::rebuildFontFace):

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

2:12 AM Changeset in webkit [153879] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

PDFPlugin is disabled by default in nightlies on Mac accidentally
https://bugs.webkit.org/show_bug.cgi?id=119615

Rubber-stamped by Andreas Kling.

Enable PDFPlugin by default on Mac at the WebKit2 level.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferencesPrivate.h:
2:09 AM WebKitGTK/Releasing edited by Andres Gomez
Added suggestions for "after release" (diff)
2:04 AM Changeset in webkit [153878] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix build (broken by changeset r153826).
https://bugs.webkit.org/show_bug.cgi?id=119616

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-08-09
Reviewed by Andreas Kling.

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

2:03 AM WebKitGTK/StartHacking edited by Andres Gomez
Minor change (diff)
2:01 AM WebKitGTK/StartHacking edited by Andres Gomez
Added branches and dependencies (diff)
12:53 AM WebKitGTK/StartHacking edited by Andres Gomez
Minor typo (diff)

Aug 8, 2013:

11:44 PM Changeset in webkit [153877] by timothy_horton@apple.com
  • 11 edits
    2 adds in trunk

navigator.plugins has plugins in it when plugins are disabled
https://bugs.webkit.org/show_bug.cgi?id=119607
<rdar://problem/14678030>

Reviewed by Anders Carlsson.

Test: plugins/navigator-plugins-disabled.html

  • page/Settings.cpp:

(WebCore::Settings::setPluginsEnabled):
Refresh the plugin database when plugins are enabled or disabled.
This is necessary to ensure that navigator.plugins will have the
correct set of plugins after dynamically changing whether plugins
are enabled, which makes the test for this patch possible (but it
makes sense in the browser as well).

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPlugins):
Return a list of all plugins, and a list of only application plugins.

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPluginInfo):
Add applicationPlugin parameter to getPlugins, and storage for the returned list.

(WebKit::WebPlatformStrategies::populatePluginCache):
If plugins are disabled for the given page, give WebCore the list that
only includes application plugins. Otherwise, give it the whole list
as we are doing currently.

  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::getPluginInfo):
If plugins are disabled for the given page, give WebCore an empty list of
plugins. If WebKit1 had any application plugins, we'd return just them
instead.

Add a test that ensures that navigator.plugins only contains
application plugins when plugins are disabled.

  • plugins/navigator-plugins-disabled-expected.txt: Added.
  • plugins/navigator-plugins-disabled.html: Added.
11:39 PM Changeset in webkit [153876] by timothy@apple.com
  • 9 edits
    1 move
    7 adds
    5 deletes in trunk

Allow SVG images to be drawn into canvas without tainting.
https://bugs.webkit.org/show_bug.cgi?id=119492

Reviewed by Darin Adler.

Source/WebCore:

Tests: svg/as-image/svg-canvas-not-tainted.html

svg/as-image/svg-canvas-link-not-colored.html
svg/as-image/svg-canvas-xhtml-tainted.html

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute): Call shouldProhibitLinks.
(WebCore::shouldProhibitLinks): Added.

  • html/HTMLAnchorElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute): Call shouldProhibitLinks.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::isEmbeddedThroughSVGImage): Use isInSVGImage.

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::svgAttributeChanged): Call shouldProhibitLinks.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::hasSingleSecurityOrigin): Added.
(WebCore::isInSVGImage): Added.

  • svg/graphics/SVGImage.h:

LayoutTests:

  • fast/canvas/svg-taint-expected.txt: Removed.
  • fast/canvas/svg-taint.html: Removed. Obsolete.
  • http/tests/security/canvas-remote-read-data-url-svg-image-expected.txt: Removed.
  • http/tests/security/canvas-remote-read-data-url-svg-image.html: Removed. Obsolete.
  • http/tests/security/canvas-remote-read-svg-image-expected.txt: Removed.
  • http/tests/security/canvas-remote-read-svg-image.html: Removed. Obsolete.
  • svg/as-image/resources/link-xhtml-svg.svg: Added.
  • svg/as-image/resources/link-xhtml.svg: Added.
  • svg/as-image/resources/link.svg: Added.
  • svg/as-image/svg-canvas-link-not-colored-expected.txt: Added.
  • svg/as-image/svg-canvas-link-not-colored.html: Added.
  • svg/as-image/svg-canvas-not-tainted-expected.txt: Added.
  • svg/as-image/svg-canvas-not-tainted.html: Added.
  • svg/as-image/svg-canvas-xhtml-tainted-expected.txt: Added.
  • svg/as-image/svg-canvas-xhtml-tainted.html: Added.
7:40 PM Changeset in webkit [153875] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix ASSERT(m_contentsSolidColor.isValid()) assertion on iOS at nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=119603

Reviewed by Dean Jackson.

On iOS it's possible for a GraphicsLayer to transition between having
a solid background color, and containing media. This happens on nytimes.com
when playing video.

In this case, GraphicsLayerCA::updateContentsColorLayer() would assert
because m_contentsLayer had been already set up to contain media, but
it would be trying to update the color.

Fix by bailing from all the updateContents* functions if there is no
contents layer, or that layer exists for a different purpose.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateContentsMediaLayer):
(WebCore::GraphicsLayerCA::updateContentsCanvasLayer):
(WebCore::GraphicsLayerCA::updateContentsColorLayer):

7:12 PM Changeset in webkit [153874] by achristensen@apple.com
  • 5 edits
    2 adds in trunk/Source/ThirdParty/ANGLE

Link to correct DirectX libraries for Win64 ANGLE build.
https://bugs.webkit.org/show_bug.cgi?id=119600

Reviewed by Brent Fulgham.

  • ANGLE.vcxproj/DirectX32.props: Added with x86 DirectX library directory.
  • ANGLE.vcxproj/DirectX64.props: Added with x64 DirectX library directory.
  • ANGLE.vcxproj/libEGL.vcxproj:
  • ANGLE.vcxproj/libGLESv2.vcxproj:

Use DirectX32.props and DirectX64.props.

  • ANGLE.vcxproj/libEGLCommon.props:
  • ANGLE.vcxproj/libGLESv2Common.props:

Removed DirectX library directory.

5:49 PM Changeset in webkit [153873] by commit-queue@webkit.org
  • 3 edits
    4 deletes in trunk

Unreviewed, rolling out r153847.
http://trac.webkit.org/changeset/153847
https://bugs.webkit.org/show_bug.cgi?id=119609

caused new SVG animation test failures (Requested by smfr on
#webkit).

Source/WebCore:

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateFromAndByValues):

LayoutTests:

  • svg/animations/non-additive-type-from-by-animation-expected.txt: Removed.
  • svg/animations/non-additive-type-from-by-animation.html: Removed.
  • svg/animations/resources/non-additive-type-from-by-animation.svg: Removed.
  • svg/animations/script-tests/non-additive-type-from-by-animation.js: Removed.
5:47 PM Changeset in webkit [153872] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Kill updateStyleForAllDocuments()
https://bugs.webkit.org/show_bug.cgi?id=118093

Reviewed by Geoff Garen.

We should never have to eagerly update style, especially for all documents
that the process knows about. The WebKit model is to update style when
required for layout etc, not to update it eagerly.

This is historical code whose origins are lost in the mists of KHTML.
r42384 makes it possible to do away with this eager updating, and
r55568 removed some calls. Discussion in bug 32580 suggests that
form control code still need this, but tests still pass without it.

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::unscheduleStyleRecalc):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::setActive):

5:40 PM Changeset in webkit [153871] by jer.noble@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening; update test after addKey() was renamed to update().

  • media/encrypted-media/encrypted-media-v2-events-expected.txt:
  • media/encrypted-media/encrypted-media-v2-events.html:
5:16 PM Changeset in webkit [153870] by Lucas Forschler
  • 17 edits in branches/safari-537-branch

Merged r153867. <rdar://problem/14691925>

5:14 PM Changeset in webkit [153869] by Lucas Forschler
  • 17 edits in tags/Safari-537.55.1

Merged r153867. <rdar://problem/14691925>

5:11 PM Changeset in webkit [153868] by benjamin@webkit.org
  • 5 edits
    2 adds in trunk/Websites/webkit.org

Fix webkit.org content overflowing their content box

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-08-08
Rubberstamped by Simon Fraser.

More fixes to have webkit.org show properly on iPad and iPhone.

  • blog/wp-content/themes/webkit/header.php:

Add the correct viewport width for the blog.

  • building/debug.html:
  • building/launch-debugger-vs2010-small.png: Added.
  • building/set-debugging-properties-vs2010-small.png: Added.

Fix the images to make them fit in the page.

  • coding/adding-features.html:

Using <pre> for the example of email just make it looks like our code examples.
Change the source to use <blockquote> so that the text can reflow to the content box.

  • css/main.css:

(.code, pre, tt, code):
Scroll the content when it overflows the box for code and pre.

5:07 PM Changeset in webkit [153867] by jer.noble@apple.com
  • 17 edits in trunk

[EME] MediaKey APIs should be prefixed.
https://bugs.webkit.org/show_bug.cgi?id=119606

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests; updated exsisting tests with new names.

Prefix all new classes with "WebKit" and new methods on existing unprefixed
classes with "webkit"

  • Modules/encryptedmedia/MediaKeyMessageEvent.idl: MediaKeyMessageEvent -> WebKitMediaKeyMessageEvent
  • Modules/encryptedmedia/MediaKeySession.idl: MediaKeySession -> WebKitMediaKeySession
  • Modules/encryptedmedia/MediaKeys.idl: MediaKeys -> WebKitMediaKeys
  • html/HTMLMediaElement.idl: keys -> webkitKeys, setMediaKeys -> webkitSetMediaKeys
  • html/MediaKeyError.idl: MediaKeyError -> WebKitMediaKeyError

LayoutTests:

  • media/encrypted-media/encrypted-media-constants-expected.txt:
  • media/encrypted-media/encrypted-media-constants.html:
  • media/encrypted-media/encrypted-media-events-expected.txt:
  • media/encrypted-media/encrypted-media-events.html:
  • media/encrypted-media/encrypted-media-is-type-supported-expected.txt:
  • media/encrypted-media/encrypted-media-is-type-supported.html:
  • media/encrypted-media/encrypted-media-v2-events-expected.txt:
  • media/encrypted-media/encrypted-media-v2-events.html:
  • media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
  • media/encrypted-media/encrypted-media-v2-syntax.html:
5:06 PM Changeset in webkit [153866] by Lucas Forschler
  • 4 edits in branches/safari-537-branch

Merged r153851. <rdar://problem/14688700>

5:04 PM Changeset in webkit [153865] by Lucas Forschler
  • 13 edits
    2 copies in branches/safari-537-branch

Merged r153838. <rdar://problem/14688350>

5:02 PM Changeset in webkit [153864] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153856. <rdar://problem/14267843>

4:57 PM Changeset in webkit [153863] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source/WebCore

Merged r153810. <rdar://problem/14669010>

4:47 PM Changeset in webkit [153862] by Lucas Forschler
  • 4 edits in tags/Safari-537.55.1

Merged r153851. <rdar://problem/14688700>

4:41 PM Changeset in webkit [153861] by Lucas Forschler
  • 13 edits
    2 copies in tags/Safari-537.55.1

Merged r153838. <rdar://problem/14688350>

4:28 PM Changeset in webkit [153860] by dino@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Remove use of prefixed transition event
https://bugs.webkit.org/show_bug.cgi?id=119598

Reviewed by Joseph Pecoraro.

"webkitTransitionEnd" -> "transitionend".

  • UserInterface/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype.handleEvent):

4:28 PM Changeset in webkit [153859] by achristensen@apple.com
  • 4 edits in trunk

Windows build fixes.

Rubberstamped by Brent Fulgham.

Tools:

  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:

Removed /SAFESEH link option which doesn't work with x64.

WebKitLibraries:

  • win/tools/vsprops/debug_wincairo.props: Removed MinimalRebuild option preventing parallel compiling.
4:25 PM Changeset in webkit [153858] by Lucas Forschler
  • 5 edits in tags/Safari-537.55.1/Source

Versioning.

4:19 PM Changeset in webkit [153857] by Lucas Forschler
  • 1 copy in tags/Safari-537.55.1

New Tag.

4:19 PM Changeset in webkit [153856] by barraclough@apple.com
  • 2 edits in trunk/Source/WebKit2

Disable suppression of plugin process for Java
https://bugs.webkit.org/show_bug.cgi?id=119604

Reviewed by Sam Weinig.

Workaround, the Java plugin doesn't like this.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializeProcess):

  • +1 active task count on the java plugin, to inhibit supression.
4:12 PM Changeset in webkit [153855] by timothy_horton@apple.com
  • 4 edits in trunk/LayoutTests

Unreviewed, remove TestExpectations for removed microdata tests.

  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
3:51 PM Changeset in webkit [153854] by dbates@webkit.org
  • 2 edits in trunk/Tools

Add iOS support to run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=119602

Reviewed by Joseph Pecoraro.

Make run-javascriptcore-tests work for iOS WebKit.

  • Scripts/run-javascriptcore-tests:
3:46 PM Changeset in webkit [153853] by benjamin@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Give a smaller viewport to webkit.org on devices

Rubberstamped by Simon Fraser.

The CSS of WebKit.org layout the content on 615px + a right margin of
215px + a left margin of 20px. The total layout width is 850px.

The standard viewport size on mobile devices is 980px. This leaves a gap
on the right side of the content when opening the size on iPhone/iPad.

This patch changes the layout width to be 860 to display more content on devices
while keeping a little margin.

  • header.inc:
3:38 PM Changeset in webkit [153852] by ap@apple.com
  • 10 edits
    1 delete in trunk

[WK2] loader/go-back-cached-main-resource.html fails
https://bugs.webkit.org/show_bug.cgi?id=116491

Reviewed by Tim Horton.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  • DumpRenderTree/gtk/DumpRenderTree.cpp:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  • DumpRenderTree/win/DumpRenderTree.cpp: Added FIXMEs about making path printing normalization more compatible.
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]): Return last path component in cases where we used to return a full path, which is never desirable. Added a null check to basePath to prevent potentially getting an Objective C exception.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::pathSuitableForTestResult): Changed to use path for main test window, not for a currently loading one (which is different for tests that use multiple windows). Changed to return "(null)" for empty URLs to match WK1 output. Changed to return last path component as last fallback. (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main frame URL here, and it was potentially a wrong frame. (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto. (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto. (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto. (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto. (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
3:29 PM Changeset in webkit [153851] by jer.noble@apple.com
  • 4 edits in trunk

[EME] setMediaKeys function as defined in the EME specification does not work
https://bugs.webkit.org/show_bug.cgi?id=119597

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests; updated media/encrypted-media/encrypted-media-v2-syntax.html

Rename the mediaKeys attribute 'keys' and make readonly, and add an explicit
setMediaKeys() method in HTMLMediaElement's IDL.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::keys):

  • html/HTMLMediaElement.idl:

LayoutTests:

  • media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
  • media/encrypted-media/encrypted-media-v2-syntax.html:
3:01 PM Changeset in webkit [153850] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Hashing SecurityOrigin's can lead to trouble if you mutate them :(
https://bugs.webkit.org/show_bug.cgi?id=119533
<rdar://problem/12978338>

Reviewed by Andreas Kling.

We are getting into trouble in the following circumstance:

  • You have a HashMap<RefPtr<SecurityOrigin>, Value> map.
  • You add security origin A (http, www.webkit.org, 80) to the map.
  • You mutate security origin A by domain relaxation, so that it has the domain webkit.org.
  • You add security origin B (http, www.webkit.org, 80) to the map.
  • You mutate security origin B by domain relaxation, so that it has the domain webkit.org.

You now have two identical keys in the map.

  • Add few more items to the map causing a rehash.
  • When you try to add A and B back into the map, you will have a collision, because they now equal each other.

We should probably stop using SecurityOrigins as keys in HashMaps (and move to using a non-mutable SecurityOriginTuple,
or something), but for now, we can just only use the scheme / host / port part for equality, which is what all the users
really want.

  • page/SecurityOriginHash.h:

(WebCore::SecurityOriginHash::equal):
Switch to using isSameSchemeHostPort() for SecurityOriginHash::equal().

2:37 PM Changeset in webkit [153849] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source/WebCore

Merged r153845. <rdar://problem/14688769>

2:33 PM Changeset in webkit [153848] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Add logging to the primary plugin detection
https://bugs.webkit.org/show_bug.cgi?id=119594

Reviewed by Tim Horton.

Add some simple logging to our primary plug-in detection.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

2:19 PM Changeset in webkit [153847] by rwlbuis@webkit.org
  • 3 edits
    4 adds in trunk

ASSERT_NOT_REACHED() touched in WebCore::SVGAnimatedStringAnimator::addAnimatedTypes
https://bugs.webkit.org/show_bug.cgi?id=113224

Reviewed by Dirk Schulze.

Source/WebCore:

Do not perform from-by animations for non-additive attributes.

Test: svg/animations/non-additive-type-from-by-animation.html

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateFromAndByValues):

LayoutTests:

Add a test for animating non-additive attributes in from-by animations

  • svg/animations/non-additive-type-from-by-animation-expected.txt: Added.
  • svg/animations/non-additive-type-from-by-animation.html: Added.
  • svg/animations/resources/non-additive-type-from-by-animation.svg: Added.
  • svg/animations/script-tests/non-additive-type-from-by-animation.js: Added.

(sample):
(executeTest):

2:17 PM Changeset in webkit [153846] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

fullscreen/exit-full-screen-iframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90708

Unreviewed gardening.

  • platform/mac/TestExpectations: Mark test as flakey, it doesn't always pass.
2:12 PM Changeset in webkit [153845] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[Windows] Improper Caption Button Displayed to Users
https://bugs.webkit.org/show_bug.cgi?id=119593

Reviewed by Eric Carlson.

Remove the custom drawing code for the Windows port, and
have it render using the CSS/SVG markup like we do on OS X.

  • rendering/RenderThemeWin.cpp: Remove drawing code.
  • rendering/RenderThemeWin.h: Remove declaration.
2:05 PM Changeset in webkit [153844] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

fast/events/scroll-div-with-prevent-default-in-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82747

Unreviewed gardening.

  • platform/mac/TestExpectations: Mark test as flakey, it doesn't always pass.
1:19 PM Changeset in webkit [153843] by achristensen@apple.com
  • 6 edits in trunk/Source/WebCore

Work towards WebGL on AppleWin port.
https://bugs.webkit.org/show_bug.cgi?id=119562

Reviewed by Brent Fulgham.

  • WebCore.vcxproj/WebCore.vcxproj:

Build GLContext.cpp and GraphicsContext3DPrivate.cpp on AppleWin port.

  • WebCore.vcxproj/WebCore.vcxproj.filters:

Moved GLContext and GraphicsContext3DPrivate from Cairo filter to graphics.

  • platform/graphics/GraphicsContext3D.h:

Added m_webGLLayer for AppleWin port.

  • platform/graphics/GraphicsContext3DPrivate.cpp:

Protected inclusion of PlatformContextCairo.h in USE(CAIRO) macro for non-cairo ports.

  • platform/graphics/win/GraphicsContext3DWin.cpp:

Removed stub GraphicsContext3DPrivate implementation in favor of GraphicsContext3DPrivate.cpp.
(WebCore::GraphicsContext3D::GraphicsContext3D):
Added GraphicsContext3DPrivate and PlatformCALayer initialization.
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
Added implementation based on Cairo ports' to be refactored soon.
(WebCore::GraphicsContext3D::platformLayer):
Return PlatformCALayer's PlatformLayer instead of 0.

12:53 PM Changeset in webkit [153842] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/navigation/back-twice-without-commit.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82980

Unreviewed gardening.

  • platform/mac/TestExpectations: Unskip passing test.
12:48 PM Changeset in webkit [153841] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple Mac WK1 and GTK.
https://bugs.webkit.org/show_bug.cgi?id=104104

Unreviewed gardening.

  • platform/mac/TestExpectations: Unskip passing test.
12:22 PM Changeset in webkit [153840] by dino@apple.com
  • 5 edits in trunk/Source/WebInspectorUI

Unprefix use of transitions in Web Inspector code
https://bugs.webkit.org/show_bug.cgi?id=119588

Reviewed by Tim Hatcher.

Replace "-webkit-transition" with "transition".

  • UserInterface/CSSCompletions.js:

(WebInspector.CSSCompletions.requestCSSNameCompletions.collectPropertyNameForCodeMirror):

  • UserInterface/FindBanner.css:

(.find-banner):
(.find-banner.showing):
(.supports-find-banner.no-find-banner-transition):
(.supports-find-banner):
(.supports-find-banner.showing-find-banner):

  • UserInterface/NetworkTimeline.css:

(.network-graph-side:hover .network-graph-label):

  • UserInterface/Popover.css:

(.popover.fade-out):

12:22 PM Changeset in webkit [153839] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

WKBundleFrameCopyProvisionalURL crashes when there is no provisional loader
https://bugs.webkit.org/show_bug.cgi?id=119587

Reviewed by Darin Adler.

  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::provisionalURL): Added a null check, like we already have in WebFrame::url().
12:17 PM Changeset in webkit [153838] by jer.noble@apple.com
  • 13 edits
    2 adds in trunk

[EME] Implement MediaKeys.isTypeSupported()
https://bugs.webkit.org/show_bug.cgi?id=119586

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/encrypted-media/encrypted-media-is-type-supported.html

The EME spec has removed the extra keySystem parameter from
HTMLMediaElement.canPlayType() in favor of a new isTypeSupported()
method on MediaKeys.

To implement this method, the CDMFactory needs to know whether the
registered CDM supports the specified mime type. CDMs must register
this new factory method, which requires changes to CDMPrivateAVFoundation
and MockCDM.

Add the new MediaKeys.isTypeSupported() method:

  • Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::isTypeSupported):

  • Modules/encryptedmedia/MediaKeys.h:
  • Modules/encryptedmedia/MediaKeys.idl:

Add the new factory CDMSupportsKeySystemAndMimeType method:

  • Modules/encryptedmedia/CDM.cpp:

(WebCore::CDMFactory::CDMFactory): Now takes a third parameter.
(WebCore::installedCDMFactories): When adding the AVFoundation CDM, pass its new method.
(WebCore::CDM::registerCDMFactory): Now takes a third parameter.
(WebCore::CDM::keySystemSupportsMimeType): Added.

  • Modules/encryptedmedia/CDM.h:
  • WebCore.exp.in:

Register this new method with the factory for all concrete CDMs:

  • Modules/encryptedmedia/CDMPrivateAVFoundation.h:
  • Modules/encryptedmedia/CDMPrivateAVFoundation.mm:

(WebCore::CDMPrivateAVFoundation::supportsKeySystem):
(WebCore::CDMPrivateAVFoundation::supportsKeySystemAndMimeType):

  • testing/Internals.cpp:

(WebCore::Internals::initializeMockCDM):

  • testing/MockCDM.cpp:

(WebCore::MockCDM::supportsKeySystem):
(WebCore::MockCDM::supportsKeySystemAndMimeType):

  • testing/MockCDM.h:

LayoutTests:

  • media/encrypted-media/encrypted-media-is-type-supported-expected.txt: Added.
  • media/encrypted-media/encrypted-media-is-type-supported.html: Added.
11:47 AM Changeset in webkit [153837] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

fast/events/scroll-div-with-prevent-default-in-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82747

Unreviewed gardening.

  • platform/mac/TestExpectations: Unskip passing test.
11:40 AM Changeset in webkit [153836] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION(r130839): fast/canvas/webgl/arraybuffer-transfer-of-control.html is failing
https://bugs.webkit.org/show_bug.cgi?id=99096

Unreviewed gardening.

  • platform/mac/TestExpectations: Unskip passing test.
11:38 AM Changeset in webkit [153835] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

Crash in WTF::RefPtr<WebCore::SpaceSplitStringData>::operator UnspecifiedBoolType
https://bugs.webkit.org/show_bug.cgi?id=118839

Reviewed by Darin Adler.

Source/WebCore:

Take into account that elementData() can be null in classAttributeChanged.

Test: svg/animations/classAttributeSettingCrash.html

  • dom/Element.cpp:

(WebCore::Element::classAttributeChanged):

LayoutTests:

Add testcase that showed up to cause a crash by the fuzzer.

  • svg/animations/classAttributeSettingCrash-expected.txt: Added.
  • svg/animations/classAttributeSettingCrash.html: Added.
11:35 AM Changeset in webkit [153834] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

fullscreen/exit-full-screen-iframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90708

Unreviewed gardening.

  • platform/mac/TestExpectations: Unskip passing test.
11:17 AM Changeset in webkit [153833] by rwlbuis@webkit.org
  • 6 edits in trunk/LayoutTests

svg/custom/use-href-update-crash.svg failing on certain platforms
https://bugs.webkit.org/show_bug.cgi?id=104054

Reviewed by Darin Adler.

Fix mistake in use-href-update-crash.svg which caused the gc() not found problem. Update the test expectations
that had this marked as failure, it passes after the test fix.

  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • svg/custom/use-href-update-crash.svg:
11:13 AM Changeset in webkit [153832] by robert@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r147019): Page has extra space
https://bugs.webkit.org/show_bug.cgi?id=119424

Reviewed by David Hyatt.

Clear the overflow rect before recomputing it in table sections.

No new tests: the reduction uses jquery and I was unable to simulate the reduction without it.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::computeOverflowFromCells):

10:47 AM Changeset in webkit [153831] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/JavaScriptCore

Merge 153819 for <rdar://problem/14680524>

10:41 AM Changeset in webkit [153830] by ap@apple.com
  • 5 edits in trunk

WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
https://bugs.webkit.org/show_bug.cgi?id=116125

Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::pathSuitableForTestResult): Changed string operations to match _drt_descriptionSuitableForTestResult. (WTR::dumpRequestDescriptionSuitableForTestResult): (WTR::dumpResponseDescriptionSuitableForTestResult): (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): (WTR::InjectedBundlePage::didInitiateLoadForResource): (WTR::InjectedBundlePage::willSendRequestForFrame): (WTR::InjectedBundlePage::didReceiveResponseForResource): Pass the main frame's URL to pathSuitableForTestResult.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added WKBundlePageRef to willPerformClientRedirectForFrame.
10:41 AM Changeset in webkit [153829] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

Inserting multiple rules into an empty style sheet should avoid style recalc if possible.
<http://webkit.org/b/119568>

Reviewed by Antti Koivisto.

As a follow-up to <http://webkit.org/b/119475>, where I added a hack for inserting
a single rule into an empty style sheet, this broadens the optimization to support
any number of rules.

This optimizes the scenario where a style sheet is added to the DOM and then populated
rule-by-rule via CSSOM insertRule()/addRule() calls. Previously we'd do a full style
recalc for this case, but now we'll treat it the same as a full sheet added at once.

  • css/CSSStyleSheet.h:
  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::willMutateRules):

Made willMutateRules() return whether the style sheet contents were cloned by the
copy-on-write mechanism.

  • dom/Document.h:

(WebCore::CSSStyleSheet::didMutateRules):
(WebCore::CSSStyleSheet::insertRule):

Replaced the InsertionIntoEmptySheet mutation type by a general RuleInsertion.
The mutation callback checks if we're inserting into a rule that's not (yet) part
of the document's active sheet set. In that case, we defer doing the style sheet
until all the insertions are done (or something forces us to style+layout.)

Note that this optimization only happens if the style sheet had a single client.
Shared style sheets that just got cloned before mutation may have pointers into
them from the Document's StyleResolver, so we're forced to do an immediate sheet
update in that case.

(WebCore::CSSStyleSheet::RuleMutationScope::RuleMutationScope):
(WebCore::CSSStyleSheet::RuleMutationScope::~RuleMutationScope):

Moved these out-of-line.

(WebCore::CSSStyleSheet::didMutateRuleFromCSSStyleDeclaration):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::StyleRuleCSSStyleDeclaration::didMutate):

Made a separate mutation callback for CSSStyleDeclaration since its needs are
so simple compared to the mutation callback from CSSStyleSheet. Seems better
than adding yet another mode to the enum.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::scheduleOptimizedStyleSheetUpdate):

Added mechanism to defer doing a RecalcStyleIfNeeded.

(WebCore::Document::updateStyleIfNeeded):

Synchronize the optimized style sheet update if there's one scheduled.
This ensures that stuff like layout-dependent property access won't operate
on stale style.

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::pendingUpdateType):
(WebCore::DocumentStyleSheetCollection::setPendingUpdateType):
(WebCore::DocumentStyleSheetCollection::flushPendingUpdates):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

Have DSSC track the kind of style sheet update it needs to do (instead of just
a boolean "needs update.") This is used by Document::recalcStyle() to make sure
the right kind of update happens if there's one scheduled.

(WebCore::DocumentStyleSheetCollection::activeStyleSheetsContains):

Added helper to check if a CSSStyleSheet is part of the active set.

10:38 AM Changeset in webkit [153828] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[WK1] NPStream::headers not initialized
https://bugs.webkit.org/show_bug.cgi?id=119574

Reviewed by Alexey Proskuryakov.

Initialize the header field. According to user feedback that should solve some
cases of random crashes when loading plugins on Mac and Windows.

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::PluginStream):

10:27 AM Changeset in webkit [153827] by akling@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Oops, didn't mean to implicate Mark Lam in the ChangeLog there.

10:25 AM Changeset in webkit [153826] by akling@apple.com
  • 30 edits in trunk/Source

Element: Modernize attribute storage accessor functions.
<http://webkit.org/b/119578>

Source/WebCore:

Patch by Mark Lam <mark.lam@apple.com> on 2013-08-08
Reviewed by Antti Koivisto.

Rename these functions to more WebKit-style names.

  • const Attribute* attributeItem(index) => const Attribute& attributeAt(index)
  • const Attribute* getAttributeItem(name) => const Attribute* findAttributeByName(name)
  • unsigned getAttributeItemIndex(name) => unsigned findAttributeIndexByName(name)

Note that attributeAt() now returns a reference instead of a pointer. That's right.

  • css/SelectorChecker.cpp:

(WebCore::attributeValueMatches):
(WebCore::anyAttributeMatches):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::checkExactAttribute):

  • dom/Attr.cpp:

(WebCore::Attr::elementAttribute):

  • dom/DatasetDOMStringMap.cpp:

(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::setSynchronizedLazyAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::computeInheritedLanguage):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
(WebCore::Element::detachAllAttrNodesFromElement):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::ElementData::isEquivalent):
(WebCore::ElementData::findAttributeIndexByNameSlowCase):
(WebCore::ElementData::findAttributeIndexByNameForAttributeNode):
(WebCore::UniqueElementData::findAttributeByName):
(WebCore::UniqueElementData::attributeAt):

  • dom/Element.h:

(WebCore::Element::findAttributeIndexByName):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::attributeAt):
(WebCore::Element::findAttributeByName):
(WebCore::ElementData::findAttributeByName):
(WebCore::ElementData::findAttributeIndexByName):
(WebCore::ElementData::attributeAt):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::item):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespaceURI):
(WebCore::Node::lookupNamespacePrefix):
(WebCore::Node::compareDocumentPosition):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::makePresentationAttributeCacheKey):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendElement):

  • editing/markup.cpp:

(WebCore::completeURLs):
(WebCore::StyledMarkupAccumulator::appendElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parametersForPlugin):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore::DOMPatchSupport::createDigest):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):

  • page/PageSerializer.cpp:

(WebCore::isCharsetSpecifyingNode):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunLang::evaluate):

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::traversalSort):

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

Source/WebKit/blackberry:

Reviewed by Antti Koivisto.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

Source/WebKit/qt:

Reviewed by Antti Koivisto.

  • Api/qwebelement.cpp:

(QWebElement::attributeNames):

9:57 AM Changeset in webkit [153825] by mark.lam@apple.com
  • 6 edits in trunk/Source

Restoring use of StackIterator instead of Interpreter::getStacktrace().
https://bugs.webkit.org/show_bug.cgi?id=119575.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • interpreter/Interpreter.h:
  • Made getStackTrace() private.
  • interpreter/StackIterator.cpp:

(JSC::StackIterator::StackIterator):
(JSC::StackIterator::numberOfFrames):

  • Computes the number of frames by iterating through the whole stack from the starting frame. The iterator will save its current frame position before counting the frames, and then restoring it after the counting.

(JSC::StackIterator::gotoFrameAtIndex):
(JSC::StackIterator::gotoNextFrame):
(JSC::StackIterator::resetIterator):

  • Points the iterator to the starting frame.
  • interpreter/StackIteratorPrivate.h:

Source/WebCore:

No new tests.

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

9:55 AM Changeset in webkit [153824] by commit-queue@webkit.org
  • 12 edits
    5 copies
    34 adds in trunk

SunSpider: Move the 3d-morph fix from version 1.0 to version 1.0.1
https://bugs.webkit.org/show_bug.cgi?id=117993

Patch by Cosmin Truta <ctruta@blackberry.com> on 2013-08-08
Reviewed by George Staikos.

PerformanceTests/SunSpider:

Bump the SunSpider version to 1.0.1.

Unroll r149548 in order to restore version 1.0 to its original,
and add the 3d-morph fix to version 1.0.1 instead.

  • hosted/sunspider.html: Updated to version 1.0.1.
  • hosted/versions.html: Updated to version 1.0.1.
  • make-hosted: Added support for version 1.0.1.
  • resources/driver-TEMPLATE.html: Updated to version 1.0.1.
  • resources/results-TEMPLATE.html: Updated to version 1.0.1.
  • sunspider: Updated to version 1.0.1.
  • sunspider-compare-results: Updated to version 1.0.1.
  • tests/sunspider-1.0/3d-morph.js: Rolled back to the original version.
  • tests/sunspider-1.0.1/LIST: Added.
  • tests/sunspider-1.0.1/3d-cube.js: Added.
  • tests/sunspider-1.0.1/3d-morph.js: Added.
  • tests/sunspider-1.0.1/3d-raytrace.js: Added.
  • tests/sunspider-1.0.1/access-binary-trees.js: Added.
  • tests/sunspider-1.0.1/access-fannkuch.js: Added.
  • tests/sunspider-1.0.1/access-nbody.js: Added.
  • tests/sunspider-1.0.1/access-nsieve.js: Added.
  • tests/sunspider-1.0.1/bitops-3bit-bits-in-byte.js: Added.
  • tests/sunspider-1.0.1/bitops-bits-in-byte.js: Added.
  • tests/sunspider-1.0.1/bitops-bitwise-and.js: Added.
  • tests/sunspider-1.0.1/bitops-nsieve-bits.js: Added.
  • tests/sunspider-1.0.1/controlflow-recursive.js: Added.
  • tests/sunspider-1.0.1/crypto-aes.js: Added.
  • tests/sunspider-1.0.1/crypto-md5.js: Added.
  • tests/sunspider-1.0.1/crypto-sha1.js: Added.
  • tests/sunspider-1.0.1/date-format-tofte.js: Added.
  • tests/sunspider-1.0.1/date-format-xparb.js: Added.
  • tests/sunspider-1.0.1/math-cordic.js: Added.
  • tests/sunspider-1.0.1/math-partial-sums.js: Added.
  • tests/sunspider-1.0.1/math-spectral-norm.js: Added.
  • tests/sunspider-1.0.1/regexp-dna.js: Added.
  • tests/sunspider-1.0.1/string-base64.js: Added.
  • tests/sunspider-1.0.1/string-fasta.js: Added.
  • tests/sunspider-1.0.1/string-tagcloud.js: Added.
  • tests/sunspider-1.0.1/string-unpack-code.js: Added.
  • tests/sunspider-1.0.1/string-validate-input.js: Added.

Websites/webkit.org:

  • perf/sunspider-1.0.1/json2.js: Added.
  • perf/sunspider-1.0.1/sunspider-1.0.1/driver.html: Added.
  • perf/sunspider-1.0.1/sunspider-1.0.1/results.html: Added.
  • perf/sunspider-1.0.1/sunspider-1.0.1/sunspider-test-contents.js: Added.
  • perf/sunspider-1.0.1/sunspider-1.0.1/sunspider-test-prefix.js: Added.
  • perf/sunspider-1.0.1/sunspider-analyze-results.js: Added.
  • perf/sunspider-1.0.1/sunspider-compare-results.js: Added.
  • perf/sunspider-1.0.1/sunspider.css: Added.
  • perf/sunspider-1.0.1/sunspider.html: Added.
  • perf/sunspider/sunspider.html: Updated to version 1.0.1.
  • perf/sunspider/versions.html: Updated to version 1.0.1.
9:38 AM Changeset in webkit [153823] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Moved ErrorConstructor and NativeErrorConstructor helper functions into
the Interpreter class.
https://bugs.webkit.org/show_bug.cgi?id=119576.

Reviewed by Oliver Hunt.

This change is needed to prepare for making Interpreter::getStackTrace()
private. It does not change the behavior of the code, only the lexical
scoping.

  • interpreter/Interpreter.h:
  • Added helper functions for ErrorConstructor and NativeErrorConstructor.
  • runtime/ErrorConstructor.cpp:

(JSC::Interpreter::constructWithErrorConstructor):
(JSC::ErrorConstructor::getConstructData):
(JSC::Interpreter::callErrorConstructor):
(JSC::ErrorConstructor::getCallData):

  • Don't want ErrorConstructor to call Interpreter::getStackTrace() directly. So, we moved the helper functions into the Interpreter class.
  • runtime/NativeErrorConstructor.cpp:

(JSC::Interpreter::constructWithNativeErrorConstructor):
(JSC::NativeErrorConstructor::getConstructData):
(JSC::Interpreter::callNativeErrorConstructor):
(JSC::NativeErrorConstructor::getCallData):

  • Don't want NativeErrorConstructor to call Interpreter::getStackTrace() directly. So, we moved the helper functions into the Interpreter class.
7:49 AM Changeset in webkit [153822] by Alan Bujtas
  • 5 edits
    2 adds in trunk

REGRESSION (r121551) Incorrect handling of invalid media query list.
https://bugs.webkit.org/show_bug.cgi?id=119164

Reviewed by Antti Koivisto.

Differentiate between syntactically invalid media queries and media queries with empty expressions.

Introduce a dedicated function for valid, but empty expression queries, so that passing NULL MediaQuerySet
object to CSSParser::createMediaRule() can indicate invalid media query.

Source/WebCore:

Test: fast/media/invalid-media-query-list.html

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createEmptyMediaRule):

  • css/CSSParser.h:

LayoutTests:

  • fast/media/invalid-media-query-list-expected.html: Added.
  • fast/media/invalid-media-query-list.html: Added.
6:30 AM Changeset in webkit [153821] by zarvai@inf.u-szeged.hu
  • 25 edits
    3 adds in trunk/LayoutTests

[Qt] Unreviewed rebaselining after r153647.

  • platform/qt/fast/css/input-search-padding-expected.png:
  • platform/qt/fast/css/input-search-padding-expected.txt:
  • platform/qt/fast/css/text-overflow-input-expected.png:
  • platform/qt/fast/css/text-overflow-input-expected.txt:
  • platform/qt/fast/forms/box-shadow-override-expected.png:
  • platform/qt/fast/forms/box-shadow-override-expected.txt:
  • platform/qt/fast/forms/control-restrict-line-height-expected.png:
  • platform/qt/fast/forms/control-restrict-line-height-expected.txt:
  • platform/qt/fast/forms/placeholder-position-expected.png:
  • platform/qt/fast/forms/placeholder-position-expected.txt:
  • platform/qt/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.png:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.png:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.png:
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
  • platform/qt/fast/forms/search/search-size-with-decorations-expected.png: Added.
  • platform/qt/fast/forms/search/search-size-with-decorations-expected.txt: Added.
  • platform/qt/fast/repaint/search-field-cancel-expected.png:
  • platform/qt/fast/repaint/search-field-cancel-expected.txt:
4:00 AM Changeset in webkit [153820] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebCore

Introduce toSVGMPathElement(), and use it
https://bugs.webkit.org/show_bug.cgi?id=119566

Reviewed by Andreas Kling.

As a step to change static_cast with toSVGXXX, static_cast<SVGMPathElement*> can
be changed with toSVGMPathElement().

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::updateAnimationPath):

  • svg/SVGMPathElement.h:

(WebCore::toSVGMPathElement):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::invalidateMPathDependencies):

3:25 AM Changeset in webkit [153819] by Stephanie Lewis
  • 2 edits in trunk/Source/JavaScriptCore

<rdar://problem/14680524> REGRESSION(153806): Crash @ yahoo.com when WebKit is built with a .order file

Unreviewed.

Ensure llint symbols are in source order.

2:54 AM Changeset in webkit [153818] by allan.jensen@digia.com
  • 2 edits in trunk/LayoutTests

[Qt] Skip more tests depending on canvas blending.
https://bugs.webkit.org/show_bug.cgi?id=100072

Unreviewed gardening.

  • platform/qt/TestExpectations:
12:58 AM Changeset in webkit [153817] by vivek.vg@samsung.com
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Use granular DOMStorage modification events to avoid complete DataGrid update.
https://bugs.webkit.org/show_bug.cgi?id=119541

Reviewed by Joseph Pecoraro.

InspectorDOMStorageAgent sends more granular events about the storage modifications.
Using these would avoid the complete rebuilding of the DataGrid.

  • UserInterface/DOMStorageContentView.js:

(WebInspector.DOMStorageContentView.prototype.itemsCleared):
(WebInspector.DOMStorageContentView.prototype.itemRemoved):
(WebInspector.DOMStorageContentView.prototype.itemAdded):
(WebInspector.DOMStorageContentView.prototype.itemUpdated):

  • UserInterface/DOMStorageObserver.js:

(WebInspector.DOMStorageObserver.prototype.domStorageItemsCleared):
(WebInspector.DOMStorageObserver.prototype.domStorageItemRemoved):
(WebInspector.DOMStorageObserver.prototype.domStorageItemAdded):
(WebInspector.DOMStorageObserver.prototype.domStorageItemUpdated):

  • UserInterface/StorageManager.js:

(WebInspector.StorageManager.prototype.domStorageItemsCleared):
(WebInspector.StorageManager.prototype.domStorageItemRemoved):
(WebInspector.StorageManager.prototype.domStorageItemAdded):
(WebInspector.StorageManager.prototype.domStorageItemUpdated):

12:18 AM Changeset in webkit [153816] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Move more style recalc code to StyleResolveTree.cpp
https://bugs.webkit.org/show_bug.cgi?id=119553

Reviewed by Andreas Kling.

  • css/StyleResolver.cpp:
  • css/StyleResolver.h:


Remove now unused StyleResolver::styleForText.

  • dom/ElementShadow.cpp:
  • dom/ElementShadow.h:


Remove ElementShadow::recalcStyle.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setResetStyleInheritance):

Use Style::resolveTree instead of ElementShadow::recalcStyle.

  • dom/ShadowRoot.h:


Remove ShadowRoot::recalcStyle.

  • dom/Text.cpp:
  • dom/Text.h:


Remove Text::recalcTextStyle.

  • style/StyleResolveTree.cpp:

(WebCore::Style::updateTextStyle):

Moved from Text::recalcTextStyle. Speed up by just setting the parent style on common case.

(WebCore::Style::resolveShadowTree):

Moved from ShadowRoot::recalcStyle.
Simplified to cover only cases that can occur with the current shadow DOM support.

(WebCore::Style::resolveTree):

12:16 AM Changeset in webkit [153815] by akling@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION(r139282): Old caret sometimes gets "stuck" (not repainted) in contenteditable elements.
<http://webkit.org/b/119520>
<rdar://problem/14658929>

Reviewed by Simon Fraser.

Source/WebCore:

When computing a new caret rect, don't forget to repaint the old rect if the caret jumped
from one node to another.
We were being a little too clever, assuming that oldRect==newRect meant that no repaint was
necessary, but moving from (0,0) in one node to (0,0) in another would cause a ghost caret
in the old node.

Test: fast/repaint/caret-jump-between-nodes.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::recomputeCaretRect):

Fall through all the way down to caret repaints if the selection's new anchor node is not
the same as m_previousCaretNode.

LayoutTests:

  • fast/repaint/caret-jump-between-nodes-expected.txt: Added.
  • fast/repaint/caret-jump-between-nodes.html: Added.

Aug 7, 2013:

11:28 PM Changeset in webkit [153814] by abucur@adobe.com
  • 12 edits
    12 adds in trunk

[CSS Regions] Propagate overflow from the flow thread to the first and last region
https://bugs.webkit.org/show_bug.cgi?id=118526

Reviewed by David Hyatt.

Source/WebCore:

The patch implements layout overflow propagation for the first and last regions. The approach
taken is triggering a simple layout on the regions after the named flows are laid out
that extracts the layout overflow from the flow thread and adds it to the regions.

The process is based on adding two new layout phases: the overflow phase and the final phase.
The overflow phase is set after the flow threads are laid out and it marks the regions as
needing to extract the overflow from the flow thread. In case there are blocks with auto overflow
it's possible the overflow to create scrollbars that shrink the regions. In this case the flow
thread is relaid out and set in the final phase, forcing the regions to recollect the layout
overflow. In theory this would be an N-step layout because scrollbars can force content to change
regions and create overflow for other blocks (and thus creating more scrollbars). For now, we are
limiting this to the first pass by inserting this new final layout phase.

A short description of the processing model for a document:

  • layout the document (all the flow threads should be in the constrained layout phase after this step)
  • reverse iterate through the flow threads and mark the regions for simplified layout (we need to

reverse iterate so the overflow can correctly propagate with nested regions)

  • if the layout changes the size of a region, invalidate the flow thread and when laying it out mark

it as needing a new pass

  • make a secondary pass through the flow threads that changed after scrollbars have been added and

recompute the overflow for their regions; mark the flow threads in the final phase (flow threads can't
be invalidated in the final phase)

  • after the overflow was propagated update all the flow threads in the normal layout phase

There are some issues with the patch:

  • the simplified layout doesn't compute correct overflow values for inline blocks
  • the layout overflow from the flow thread doesn't take the region size into account

The first issue is not related to regions and will be fixed in a future patch. The second issue
will be fixed when box overflow will be region bound.

Tests: fast/regions/overflow-scrollable-1.html

fast/regions/overflow-scrollable-2.html
fast/regions/overflow-scrollable-3.html
fast/regions/overflow-scrollable-fit-complex.html
fast/regions/overflow-scrollable-fit.html
fast/regions/overflow-scrollable-nested.html

  • rendering/FlowThreadController.cpp: Flow threads layout driver functions.

(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsIntoConstrainedPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoOverflowPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoMeasureContentPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoFinalPhase):

  • rendering/FlowThreadController.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::simplifiedNormalFlowLayout):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::firstRegion): This getter should work even though the region chain is invalid.
(WebCore::RenderFlowThread::lastRegion): This getter should work even though the region chain is invalid.
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::markRegionsForOverflowLayoutIfNeeded): If the flow thread has no overflow do nothing.
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):

  • rendering/RenderFlowThread.h:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::maxPageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::flowThreadPortionOverflowRect):
(WebCore::RenderRegion::overflowRectForFlowThreadPortion): Used to get the flow thread visual or layout overflow.
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::computeOverflowFromFlowThread):
(WebCore::RenderRegion::updateLogicalHeight):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::layoutContentToComputeOverflowInRegions):
(WebCore::RenderView::layout):

  • rendering/RenderView.h:

LayoutTests:

Add tests for scrolling of regions in containers in different situations: regions with
transforms, nested regions, regions affected by scrollbars etc.

  • fast/regions/overflow-scrollable-1-expected.html: Added.
  • fast/regions/overflow-scrollable-1.html: Added.
  • fast/regions/overflow-scrollable-2-expected.html: Added.
  • fast/regions/overflow-scrollable-2.html: Added.
  • fast/regions/overflow-scrollable-3-expected.html: Added.
  • fast/regions/overflow-scrollable-3.html: Added.
  • fast/regions/overflow-scrollable-fit-complex-expected.html: Added.
  • fast/regions/overflow-scrollable-fit-complex.html: Added.
  • fast/regions/overflow-scrollable-fit-expected.html: Added.
  • fast/regions/overflow-scrollable-fit.html: Added.
  • fast/regions/overflow-scrollable-nested-expected.txt: Added.
  • fast/regions/overflow-scrollable-nested.html: Added.
9:20 PM Changeset in webkit [153813] by benjamin@webkit.org
  • 1 edit
    3 adds in trunk/Websites/webkit.org

Update the images for the blog size-matters

  • blog-files/size-matters/JavaScriptCore-relative-binary-growth.png: Added.
  • blog-files/size-matters/WebCore-relative-binary-growth.png: Added.
  • blog-files/size-matters/WebKit-relative-binary-growth.png: Added.
9:08 PM Changeset in webkit [153812] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix on Efl port after r153785.

  • CMakeLists.txt: Added "${WEBCORE_DIR}/style" in include list.
7:13 PM Changeset in webkit [153811] by Simon Fraser
  • 2 edits in trunk/Tools

Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
https://bugs.webkit.org/show_bug.cgi?id=119317

Reviewed by Tim Horton.

The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
the test to complete, which is not power friendly. Although DRT instances
are generally busy anyway, not sitting in a busy loop should free up some CPU
cycles for other instances of DRT.

Editing tests continue to pass. All Java tests are skipped and were not
tested, but when run fail similarly with and without the patch.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dump):
(runTest):

7:00 PM Changeset in webkit [153810] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Avoid spurious "all repaint" layouts when scrolling WebViews on Retina displays
https://bugs.webkit.org/show_bug.cgi?id=119564

Reviewed by Beth Dakin.

When scrolling WebViews on Macs with Retina displays, AppKit uses
device pixels for the scroll offset, so [scrollView() documentVisibleRect]
can return a CGRect with non-integral origin. This rect is used by layout,
via layoutSize(), to decide whether the view size changed, which prompts
a full repaint. However, FrameView gets a value which has been rounded
by enclosingIntRect(), which increases the height or width by 1px if the
y or x offset is on a half-pixel, causing spurious full repaints.

Fix by plumbing through platformVisibleContentSize(), which just
gets the size of the -documentVisibleRect.

  • page/FrameView.cpp:

(WebCore::FrameView::layout): Don't get layoutHeight and layoutWidth
separately, since that is two calls down into platformVisibleContentSize.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::platformVisibleContentSize):

  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformVisibleContentSize):

6:31 PM Changeset in webkit [153809] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Be more aggressive about sending fake mouse events less frequently
https://bugs.webkit.org/show_bug.cgi?id=119563
<rdar://problem/14669029>

Reviewed by Tim Horton.

r109151 added code that throttles back the fake mouse events that we
send during scrolling, but in such a way that a page could take up to
100ms to handle a single mousemove, and we'd still send fake mousemove
events every 100ms. This could cause serious scrolling stutter.

Fix by changing when we drop back to sending events every 250ms, rather than every
100ms: if the slowest mousemove takes 10ms or more (less than one frame), drop back
to a 250ms fake move interval.

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):

5:51 PM Changeset in webkit [153808] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove pointless const in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=119550

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-08-07
Reviewed by Rob Buis.
Internally reviewed by Leo Yang and Mike Fenton.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
(BlackBerry::WebKit::InputHandler::redrawSpellCheckDialogIfRequired):

  • WebKitSupport/InputHandler.h:
4:05 PM Changeset in webkit [153807] by cavalcantii@gmail.com
  • 2 edits in trunk/Source/WebCore

[rendering] Implement PaintInfo interfaces
https://bugs.webkit.org/show_bug.cgi?id=119388

Reviewed by Benjamin Poulain.

In discussion in IRC, it was decided to remove this comment since implementing such change
would have a vast impact on rendering classes.

  • rendering/PaintInfo.h:
3:41 PM Changeset in webkit [153806] by Lucas Forschler
  • 8 edits in branches/safari-537-branch/Source

Merged r153775. <rdar://problem/14517392>

3:16 PM Changeset in webkit [153805] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Don't remove contents layer from its parent unless necessary
https://bugs.webkit.org/show_bug.cgi?id=119560

Reviewed by Simon Fraser.

RenderLayerBacking::updateInternalHierarchy() is called in some
instances where there doesn't need to be a complete reparenting of the
the m_graphicsLayer. For example, on OS X when the user changes the
scrollbar styles to/from always visible. We don't need to always
remove the graphics layer from its parent - any reparenting does that
automatically.

Unfortunately we can't trigger this situation in an automated test.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateInternalHierarchy): Don't call removeFromParent().

3:00 PM Changeset in webkit [153804] by dbates@webkit.org
  • 2 edits in trunk/Tools

Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
<https://bugs.webkit.org/show_bug.cgi?id=119558>

Reviewed by Martin Robinson.

Currently we build the command line to execute jsDriver.pl twice so as to both
print it to standard output and actually execute it. We should only build up
this command line once. Moreover, we should print to standard output the actual
command line that we are going to use including the GTK- and EFL-specific call
to /Tools/jhbuild/jhbuild-wrapper.

  • Scripts/run-javascriptcore-tests:
2:49 PM Changeset in webkit [153803] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/JavaScriptCore

Merge patch for <rdar://problem/14655517>

2:44 PM Changeset in webkit [153802] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/JavaScriptCore

Merged r153793. <rdar://problem/14666354>

2:38 PM Changeset in webkit [153801] by achristensen@apple.com
  • 2 edits in trunk/Source/WTF

Fixed wrong definition for AppleWin port's WebGL after r153768.

Rubberstamped by Benjamin Poulain.

  • wtf/Platform.h: Replaced WTF_USE_SURFACE with WTF_USE_GRAPHICS_SURFACE.
2:31 PM Changeset in webkit [153800] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153773. <rdar://problem/14652681>

2:27 PM Changeset in webkit [153799] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-537-branch

Merged r153374. <rdar://problem/14443495>

2:13 PM Changeset in webkit [153798] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] REGRESSION after r153432: some accessibility tests crash.
https://bugs.webkit.org/show_bug.cgi?id=119333

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-08-07
Reviewed by Darin Adler.

Use a RefPtr to store a reference to the parent element of
an AccessibilityUIElement instead of the raw pointer, so we
never derefence a function from an invalid pointer.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.

12:52 PM Changeset in webkit [153797] by timothy_horton@apple.com
  • 7 edits
    3 adds in trunk

Fall out of simple image layer optimization if the image has EXIF rotation
https://bugs.webkit.org/show_bug.cgi?id=119535
<rdar://problem/14071174>

Reviewed by Simon Fraser.

Test: fast/images/exif-orientation-composited.html

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameOrientationAtIndex):
Ensure that the frame is cached if we're requesting the orientation,
so we can acquire orientation information at any given time.

  • platform/mac/DragImageMac.mm:

(WebCore::createDragImageFromImage):

  • platform/graphics/BitmapImage.h:

Rename currentFrameOrientation to frameOrientationForCurrentFrame to match
the similarly-behaving nativeImageForCurrentFrame.

  • platform/graphics/Image.h:

(WebCore::Image::orientationForCurrentFrame): Added. Virtual, overriden by BitmapImage.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
If the given image has a non-default image orientation, don't use direct compositing.

Add a test that ensures that composited images with EXIF orientation paint correctly.

  • fast/images/exif-orientation-composited-expected.txt: Added.
  • fast/images/exif-orientation-composited.html: Added.
  • platform/mac/fast/images/exif-orientation-composited-expected.png: Added.
12:13 PM Changeset in webkit [153796] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

fast/frames/seamless/seamless-custom-font-pruning-crash.html asserts
https://bugs.webkit.org/show_bug.cgi?id=119557

Rubber-stamped by Eric Carlson.

Pass Style::Detach style change to seamless document as Style::Force. Style::resolveTree does not expect to be called with Detach.

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::didRecalcStyle):

11:40 AM Changeset in webkit [153795] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Disable HTTP request "Accept-Encoding:" header field on gstreamer source element to avoid receiving the wrong size when retrieving data
https://bugs.webkit.org/show_bug.cgi?id=115354

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-08-07
Reviewed by Philippe Normand.

The default value for the HTTP "Accept-Encoding:" header field in the request allows
compressed data to be received on requests.
While this works fine for most cases, it can break the webkit source that needs to rely on the
the proper data size when receiving the response (even though the received data is already
uncompressed the size reported in ResourceResponse::expectedContentLength() is the same
represented by the HTTP header field "Content-Length" which is the size of the compressed data).

This patch disables the HTTP "Accept-Encoding:" header field when using the request
as we don't want the received response to be encoded in any way, as we need to rely on the proper
size of the returned data on ResourceHandle::didReceiveResponse().

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

  • platform/network/soup/ResourceRequest.h:

(ResourceRequestBase):
(WebCore::ResourceRequest::acceptEncoding):
(WebCore::ResourceRequest::setAcceptEncoding):
(WebCore::ResourceRequest::ResourceRequestBase):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::toSoupMessage):

11:40 AM Changeset in webkit [153794] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit/win

Try to fix Win WK1 build.

Not reviewed.

  • WebFrame.cpp:

(WebFrame::invalidate):

11:36 AM Changeset in webkit [153793] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32-bit code gen for TypeOf doesn't properly update the AbstractInterpreter state
https://bugs.webkit.org/show_bug.cgi?id=119555

Reviewed by Geoffrey Garen.

It uses a speculationCheck where it should be using a DFG_TYPE_CHECK like the 64-bit backend does.
This was causing crashes on maps.google.com in 32-bit debug builds.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:30 AM Changeset in webkit [153792] by ctruta@gmail.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/contributors.json:
9:56 AM Changeset in webkit [153791] by allan.jensen@digia.com
  • 2 edits in trunk/LayoutTests

[Qt] Skip background-blending-mode tests

Unreviewed gardening.

  • platform/qt/TestExpectations:
9:34 AM Changeset in webkit [153790] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r) Two pixel result fail after r153522
https://bugs.webkit.org/show_bug.cgi?id=119392

Reviewed by Jocelyn Turcotte.

Consider scaling transform on the painter to determine final destination size.

Covered by existing tests.

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::prescaleImageIfRequired):
(WebCore::BitmapImage::draw):

9:17 AM Changeset in webkit [153789] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=119405

Reviewed by Geoffrey Garen.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString): For X86 32 bit, construct an indexed address
ourselves to save a register and then load from it.

8:02 AM Changeset in webkit [153788] by Antti Koivisto
  • 6 edits in trunk

2.5% regression on page cycler moz
https://bugs.webkit.org/show_bug.cgi?id=102822

Source/WebCore:

Reviewed by Andreas Kling.

DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache() triggers a style recalc for quirks mode
documents in the beginning of document parsing via Document::setCompatibilityMode. This often coalesces
with style recalc triggered by stylesheet loading. However on very simple documents it can generate genuinely
unnecessary work.

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache):

Check that we actually have cached injected stylesheets before triggering style recalc.


  • page/PageGroup.cpp:

(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
(WebCore::PageGroup::removeAllUserContent):

Fix a misspelling.

(WebCore::PageGroup::invalidateInjectedStyleSheetCacheInAllFrames):

Always invalidate style when user sheets change since we don't do that in
DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache anymore.

  • page/PageGroup.h:

LayoutTests:

Reviewed by Andreas Kling.

This is a progression.

  • inspector/timeline/timeline-script-tag-1-expected.txt:
8:00 AM Changeset in webkit [153787] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Do no check seek offset against internal size on gstreamer source element
https://bugs.webkit.org/show_bug.cgi?id=116533

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-08-07
Reviewed by Philippe Normand.

The internal size on gstreamer source element may be wrong in case the received size in
didReceiveResponse is not accurate. Lets just try to seek and let it fail if necessary.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcSeekDataCb):

7:31 AM Changeset in webkit [153786] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit2

Try to fix EFL build.

Not reviewed.

  • CMakeLists.txt:
7:22 AM Changeset in webkit [153785] by Antti Koivisto
  • 10 edits
    2 moves
    1 add in trunk/Source/WebCore

Create WebCore/style and move StyleResolveTree there
https://bugs.webkit.org/show_bug.cgi?id=119543

Reviewed by Andreas Kling.

WebCore/css is bloated. We should move the internal style representation and the style resolver
related code to a directory of their own. CSS language related code including parser and
CSSOM stays under css.

Things named StyleFoo should generally move under WebCore/style. They should also be moved to
the Style namespace at the same time.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.pri:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCoreCommon.props:
  • WebCore.vcxproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • css/StyleResolveTree.cpp: Removed.
  • css/StyleResolveTree.h: Removed.
  • style: Added.
  • style/StyleResolveTree.cpp: Copied from Source/WebCore/css/StyleResolveTree.cpp.
  • style/StyleResolveTree.h: Copied from Source/WebCore/css/StyleResolveTree.h.
6:42 AM Changeset in webkit [153784] by commit-queue@webkit.org
  • 1 edit
    17 adds in trunk/LayoutTests

[CSS Blending] Add test suite to validate background blending with different properties
https://bugs.webkit.org/show_bug.cgi?id=118243

Patch by Mirela Budaes <mbudaes@adobe.com> on 2013-08-07
Reviewed by Dirk Schulze.

  • css3/compositing/background-blend-mode-background-attachement-fixed-expected.html: Added.
  • css3/compositing/background-blend-mode-background-attachement-fixed.html: Added.
  • css3/compositing/background-blend-mode-background-clip-content-box-expected.html: Added.
  • css3/compositing/background-blend-mode-background-clip-content-box.html: Added.
  • css3/compositing/background-blend-mode-background-clip-padding-box-expected.html: Added.
  • css3/compositing/background-blend-mode-background-clip-padding-box.html: Added.
  • css3/compositing/background-blend-mode-background-origin-border-box-expected.html: Added.
  • css3/compositing/background-blend-mode-background-origin-border-box.html: Added.
  • css3/compositing/background-blend-mode-background-position-percentage-expected.html: Added.
  • css3/compositing/background-blend-mode-background-position-percentage.html: Added.
  • css3/compositing/background-blend-mode-background-repeat-no-repeat-expected.html: Added.
  • css3/compositing/background-blend-mode-background-repeat-no-repeat.html: Added.
  • css3/compositing/background-blend-mode-background-size-contain-expected.html: Added.
  • css3/compositing/background-blend-mode-background-size-contain.html: Added.
  • css3/compositing/background-blend-mode-background-size-cover-expected.html: Added.
  • css3/compositing/background-blend-mode-background-size-cover.html: Added.
  • css3/compositing/resources/white_square.svg: Added.
5:02 AM Changeset in webkit [153783] by Antti Koivisto
  • 42 edits
    2 adds in trunk/Source/WebCore

Move style recalculation out from Element
https://bugs.webkit.org/show_bug.cgi?id=119497

Reviewed by Andreas Kling.

Element currently does too much. Element::recalcStyle() and the related functions can be turned into
standalone functions that operate on DOM tree. This will also give more freedom for future refactoring,
for example making style recalculation non-recursive.

  • WebCore.xcodeproj/project.pbxproj:
  • css/StyleResolveTree.cpp: Added.

(WebCore::Style::determineChange):

  • moved and renamed from Node::diff
  • factored to use early return style
  • simplifield the null input logic

(WebCore::Style::pseudoStyleCacheIsInvalid):

  • moved from Element::pseudoStyleCacheIsInvalid
  • narrowed to take RenderObject rather than operate on Element

(WebCore::Style::resolveLocal):

  • split from Element::recalcStyle
  • factored to use early return style

(WebCore::Style::resolveTree):

  • moved and renamed from Element::recalcStyle
  • css/StyleResolveTree.h: Added.


  • introcuduce Style namespace for style related classes and functions
  • move and rename Node::StyleChange -> Style::Change
  • css/StyleResolver.h:

(WebCore::StyleResolverParentPusher::StyleResolverParentPusher):
(WebCore::StyleResolverParentPusher::push):
(WebCore::StyleResolverParentPusher::~StyleResolverParentPusher):

Moved this stack helper to StyleResolver.h for now since it is needed by both
StyleRecalculation and Element.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::attach):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::webkitWillEnterFullScreenForElement):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::shouldIgnoreAttributeCase):
(WebCore::Element::updatePseudoElement):
(WebCore::Element::resetComputedStyle):
(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):

  • dom/Element.h:


  • remove Element::recalcStyle
  • make a few private functions needed by StyleRecalculation public
  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::recalcStyle):

  • dom/ElementShadow.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • remove Node::StyleChange
  • remove Node::diff
  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::didRecalcStyle):

  • dom/PseudoElement.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcStyle):
(WebCore::ShadowRoot::setResetStyleInheritance):

  • dom/ShadowRoot.h:
  • dom/Text.cpp:

(WebCore::Text::recalcTextStyle):

  • dom/Text.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::didRecalcStyle):

  • html/HTMLFormControlElement.h:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::willRecalcStyle):

  • html/HTMLFrameSetElement.h:
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::didRecalcStyle):

  • html/HTMLIFrameElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didRecalcStyle):

  • html/HTMLMediaElement.h:
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::didRecalcStyle):

  • html/HTMLOptionElement.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willRecalcStyle):
(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache):
(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache):

  • html/HTMLPlugInImageElement.h:
  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::reportDataReceived):

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::willRecalcStyle):

  • svg/SVGElement.h:
  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::willRecalcStyle):

  • svg/SVGUseElement.h:
4:41 AM Changeset in webkit [153782] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Build fix after r153751

Unreviewed build fix.

Fix build when PAGE_VISIBILITY_API is disabled.

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::visibilityState):

2:11 AM Changeset in webkit [153781] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSSRegions] Wrong auto-height region computation for nested named flows
https://bugs.webkit.org/show_bug.cgi?id=119517

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/abspos-autoheight-nested-region.html

In the case of an (inner) auto-height region that is absolutely positioned in a named flow that is displayed in an (outer) auto-height region,
when we are doing the layout for the named flow we need to add a "forced region break" also for the case of simplified layout, otherwise
the outer auto-height region will not get the chance to compute its auto-height, ending up with a huge value that was used to initialize
the auto-height computed value before the start of the layout algorithm.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::simplifiedLayout):

LayoutTests:

  • fast/regions/abspos-autoheight-nested-region-expected.txt: Added.
  • fast/regions/abspos-autoheight-nested-region.html: Added.
2:09 AM Changeset in webkit [153780] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] REGRESSION after r153432: marking crashing tests.
https://bugs.webkit.org/show_bug.cgi?id=119539

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-08-07

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
12:19 AM Changeset in webkit [153779] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/win

Remove dependency on CoreFoundation from WebURLResponse
https://bugs.webkit.org/show_bug.cgi?id=119390

Reviewed by Brent Fulgham.

  • WebURLResponse.cpp:

(localizedShortDescriptionForStatusCode):
(WebURLResponse::localizedStringForStatusCode):

Aug 6, 2013:

9:04 PM Changeset in webkit [153778] by fpizlo@apple.com
  • 9 edits
    3 adds in trunk

DFG FixupPhase should insert Int32ToDouble nodes for number uses in NewArray, and SpeculativeJIT 64-bit should not try to coerce integer constants to double constants
https://bugs.webkit.org/show_bug.cgi?id=119528

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Either of the two fixes would solve the crash I saw. Basically, for best performance, we want the DFG register allocator to track double uses and non-double
uses of a node separately, and we accomplish this by inserting Int32ToDouble nodes in the FixupPhase. But even if FixupPhase fails to do this, we still want
the DFG register allocator to do the right thing: if it encounters a double use of an integer, it should perform a conversion and preserve the original
format of the value (namely, that it was an integer). For constants, the best format to preserve is None, so that future integer uses rematerialize the int
from scratch. This only affects the 64-bit backend; the 32-bit backend was already doing the right thing.

This also fixes some more debug dumping code, and adds some stronger assertions for integer arrays.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

  • runtime/JSObject.h:

(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly):

LayoutTests:

  • fast/js/dfg-new-array-double-const-then-int-const.html: Added.
  • fast/js/dfg-new-array-double-const-then-int-const-expected.txt: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-new-array-double-const-then-int-const.js: Added.

(bar):
(foo):

8:07 PM Changeset in webkit [153777] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

8:05 PM Changeset in webkit [153776] by Lucas Forschler
  • 1 copy in tags/Safari-537.55

New Tag.

7:41 PM Changeset in webkit [153775] by Stephanie Lewis
  • 8 edits in trunk/Source

Update Order Files for Safari
<rdar://problem/14517392>

Unreviewed.

Source/JavaScriptCore:

Source/WebCore:

No change in functionality.

  • WebCore.order:

Source/WebKit/mac:

  • WebKit.order:

Source/WebKit2:

  • mac/WebKit2.order:
5:19 PM Changeset in webkit [153774] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Assertion failure in emitExpressionInfo when reloading with Web Inspector open.
https://bugs.webkit.org/show_bug.cgi?id=119532.

Reviewed by Oliver Hunt.

  • parser/Parser.cpp:

(JSC::::Parser):

  • Just need to initialize the Parser's JSTokenLocation's initial line and startOffset as well during Parser construction.
5:13 PM Changeset in webkit [153773] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when entering fullscreen video playback from a WebView using WebKit2
https://bugs.webkit.org/show_bug.cgi?id=119531

Reviewed by Tim Horton.

Initialize wkWindowSetScaledFrame and wkWindowSetAlpha when initializing WebCoreSystemInterface.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

4:22 PM Changeset in webkit [153772] by weinig@apple.com
  • 75 edits
    15 deletes in trunk

.: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore: Remove support for HTML5 Microdata
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::nameGetter):

  • bindings/js/JSHTMLElementCustom.cpp:
  • bindings/js/JSMicroDataItemValueCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Document.idl:
  • dom/Element.cpp:

(WebCore::Element::ensureCachedHTMLCollection):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeListBase::rootNode):
(WebCore::LiveNodeListBase::invalidateCache):
(WebCore::LiveNodeList::namedItem):

  • dom/LiveNodeList.h:

(WebCore::LiveNodeListBase::shouldInvalidateTypeOnAttributeChange):

  • dom/MicroDataItemList.cpp: Removed.
  • dom/MicroDataItemList.h: Removed.
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/NodeRareData.cpp:
  • dom/NodeRareData.h:
  • dom/PropertyNodeList.cpp: Removed.
  • dom/PropertyNodeList.h: Removed.
  • dom/PropertyNodeList.idl: Removed.
  • html/CollectionType.h:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.cpp:
  • html/HTMLAreaElement.h:
  • html/HTMLCollection.cpp:

(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::isMatchingElement):
(WebCore::LiveNodeListBase::item):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::isURLAttribute):

  • html/HTMLElement.h:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLEmbedElement.h:
  • html/HTMLIFrameElement.cpp:
  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.cpp:
  • html/HTMLImageElement.h:
  • html/HTMLLinkElement.cpp:
  • html/HTMLLinkElement.h:
  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • html/HTMLMetaElement.cpp:
  • html/HTMLMetaElement.h:
  • html/HTMLObjectElement.cpp:
  • html/HTMLObjectElement.h:
  • html/HTMLPropertiesCollection.cpp: Removed.
  • html/HTMLPropertiesCollection.h: Removed.
  • html/HTMLPropertiesCollection.idl: Removed.
  • html/HTMLSourceElement.cpp:
  • html/HTMLSourceElement.h:
  • html/HTMLTrackElement.cpp:
  • html/HTMLTrackElement.h:
  • html/MicroDataAttributeTokenList.cpp: Removed.
  • html/MicroDataAttributeTokenList.h: Removed.
  • html/MicroDataItemValue.cpp: Removed.
  • html/MicroDataItemValue.h: Removed.
  • html/MicroDataItemValue.idl: Removed.

Source/WebKit/blackberry: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/mac: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • wtf/FeatureDefines.h:

Tools: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

LayoutTests: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

  • fast/dom/MicroData: Removed.
  • fast/dom/MicroData/001-expected.txt: Removed.
  • fast/dom/MicroData/001.html: Removed.
  • fast/dom/MicroData/002-expected.txt: Removed.
  • fast/dom/MicroData/002.html: Removed.
  • fast/dom/MicroData/003-expected.txt: Removed.
  • fast/dom/MicroData/003.html: Removed.
  • fast/dom/MicroData/004-expected.txt: Removed.
  • fast/dom/MicroData/004.html: Removed.
  • fast/dom/MicroData/005-expected.txt: Removed.
  • fast/dom/MicroData/005.html: Removed.
  • fast/dom/MicroData/006-expected.txt: Removed.
  • fast/dom/MicroData/006.html: Removed.
  • fast/dom/MicroData/007-expected.txt: Removed.
  • fast/dom/MicroData/007.html: Removed.
  • fast/dom/MicroData/008-expected.txt: Removed.
  • fast/dom/MicroData/008.html: Removed.
  • fast/dom/MicroData/009-expected.txt: Removed.
  • fast/dom/MicroData/009.html: Removed.
  • fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree-expected.txt: Removed.
  • fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree.html: Removed.
  • fast/dom/MicroData/domsettabletokenlist-attributes-add-token-expected.txt: Removed.
  • fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html: Removed.
  • fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index-expected.txt: Removed.
  • fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index.html: Removed.
  • fast/dom/MicroData/element-with-empty-itemprop-expected.txt: Removed.
  • fast/dom/MicroData/element-with-empty-itemprop.html: Removed.
  • fast/dom/MicroData/getitems-empty-string-as-arg-expected.txt: Removed.
  • fast/dom/MicroData/getitems-empty-string-as-arg.html: Removed.
  • fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt: Removed.
  • fast/dom/MicroData/getitems-multiple-itemtypes.html: Removed.
  • fast/dom/MicroData/item-not-attached-to-domtree-expected.txt: Removed.
  • fast/dom/MicroData/item-not-attached-to-domtree.html: Removed.
  • fast/dom/MicroData/item-with-itemprop-attr-expected.txt: Removed.
  • fast/dom/MicroData/item-with-itemprop-attr.html: Removed.
  • fast/dom/MicroData/item-with-itemref-pointing-to-itself-expected.txt: Removed.
  • fast/dom/MicroData/item-with-itemref-pointing-to-itself.html: Removed.
  • fast/dom/MicroData/itemid-attribute-test-001-expected.txt: Removed.
  • fast/dom/MicroData/itemid-attribute-test-001.html: Removed.
  • fast/dom/MicroData/itemid-attribute-test-expected.txt: Removed.
  • fast/dom/MicroData/itemid-attribute-test.html: Removed.
  • fast/dom/MicroData/itemid-must-see-resolved-url-expected.txt: Removed.
  • fast/dom/MicroData/itemid-must-see-resolved-url.html: Removed.
  • fast/dom/MicroData/itemprop-add-remove-tokens-expected.txt: Removed.
  • fast/dom/MicroData/itemprop-add-remove-tokens.html: Removed.
  • fast/dom/MicroData/itemprop-for-an-element-must-be-correct-expected.txt: Removed.
  • fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html: Removed.
  • fast/dom/MicroData/itemprop-must-be-read-only-expected.txt: Removed.
  • fast/dom/MicroData/itemprop-must-be-read-only.html: Removed.
  • fast/dom/MicroData/itemprop-names-override-builtin-properties-expected.txt: Removed.
  • fast/dom/MicroData/itemprop-names-override-builtin-properties.html: Removed.
  • fast/dom/MicroData/itemprop-reflected-by-itemProp-property-expected.txt: Removed.
  • fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html: Removed.
  • fast/dom/MicroData/itemref-add-remove-tokens-expected.txt: Removed.
  • fast/dom/MicroData/itemref-add-remove-tokens.html: Removed.
  • fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property-expected.txt: Removed.
  • fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html: Removed.
  • fast/dom/MicroData/itemref-for-an-element-must-be-correct-expected.txt: Removed.
  • fast/dom/MicroData/itemref-for-an-element-must-be-correct.html: Removed.
  • fast/dom/MicroData/itemref-must-be-read-only-expected.txt: Removed.
  • fast/dom/MicroData/itemref-must-be-read-only.html: Removed.
  • fast/dom/MicroData/itemref-pointing-to-root-node-expected.txt: Removed.
  • fast/dom/MicroData/itemref-pointing-to-root-node.html: Removed.
  • fast/dom/MicroData/itemref-refers-first-element-with-given-id-expected.txt: Removed.
  • fast/dom/MicroData/itemref-refers-first-element-with-given-id.html: Removed.
  • fast/dom/MicroData/itemscope-attribute-test-expected.txt: Removed.
  • fast/dom/MicroData/itemscope-attribute-test.html: Removed.
  • fast/dom/MicroData/itemscope-must-be-read-write-expected.txt: Removed.
  • fast/dom/MicroData/itemscope-must-be-read-write.html: Removed.
  • fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt: Removed.
  • fast/dom/MicroData/itemtype-add-remove-tokens.html: Removed.
  • fast/dom/MicroData/itemtype-attribute-test-expected.txt: Removed.
  • fast/dom/MicroData/itemtype-attribute-test.html: Removed.
  • fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html: Removed.
  • fast/dom/MicroData/itemvalue-reflects-href-attr-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-reflects-href-attr.html: Removed.
  • fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html: Removed.
  • fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html: Removed.
  • fast/dom/MicroData/itemvalue-reflects-the-src-attr-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-reflects-the-src-attr.html: Removed.
  • fast/dom/MicroData/itemvalue-returns-element-itself-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-returns-element-itself.html: Removed.
  • fast/dom/MicroData/itemvalue-returns-null-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-returns-null.html: Removed.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html: Removed.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002-expected.txt: Removed.
  • fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html: Removed.
  • fast/dom/MicroData/microdata-domtokenlist-attribute-add-remove-tokens-expected.txt: Removed.
  • fast/dom/MicroData/microdata-domtokenlist-attribute-add-remove-tokens.html: Removed.
  • fast/dom/MicroData/nameditem-must-be-case-sensitive-expected.txt: Removed.
  • fast/dom/MicroData/nameditem-must-be-case-sensitive.html: Removed.
  • fast/dom/MicroData/nameditem-must-return-correct-item-properties-expected.txt: Removed.
  • fast/dom/MicroData/nameditem-must-return-correct-item-properties.html: Removed.
  • fast/dom/MicroData/nameditem-returns-propertynodelist-expected.txt: Removed.
  • fast/dom/MicroData/nameditem-returns-propertynodelist.html: Removed.
  • fast/dom/MicroData/names-item-out-of-range-index-expected.txt: Removed.
  • fast/dom/MicroData/names-item-out-of-range-index.html: Removed.
  • fast/dom/MicroData/names-property-must-be-correct-expected.txt: Removed.
  • fast/dom/MicroData/names-property-must-be-correct.html: Removed.
  • fast/dom/MicroData/names-property-test-expected.txt: Removed.
  • fast/dom/MicroData/names-property-test.html: Removed.
  • fast/dom/MicroData/properties-collection-add-remove-itemref-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-add-remove-itemref.html: Removed.
  • fast/dom/MicroData/properties-collection-add-remove-property-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-add-remove-property.html: Removed.
  • fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr.html: Removed.
  • fast/dom/MicroData/properties-collection-must-be-correct-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-must-be-correct.html: Removed.
  • fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items.html: Removed.
  • fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html: Removed.
  • fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html: Removed.
  • fast/dom/MicroData/properties-collection-nameditem-test-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-nameditem-test.html: Removed.
  • fast/dom/MicroData/properties-collection-test-expected.txt: Removed.
  • fast/dom/MicroData/properties-collection-test.html: Removed.
  • fast/dom/MicroData/propertiescollection-crash-expected.txt: Removed.
  • fast/dom/MicroData/propertiescollection-crash.html: Removed.
  • fast/dom/MicroData/propertiescollection-on-changing-id-attr-expected.txt: Removed.
  • fast/dom/MicroData/propertiescollection-on-changing-id-attr.html: Removed.
  • fast/dom/MicroData/propertynodelist-add-remove-itemprop-tokens-expected.txt: Removed.
  • fast/dom/MicroData/propertynodelist-add-remove-itemprop-tokens.html: Removed.
  • fast/dom/MicroData/propertynodelist-add-remove-itemref-tokens-expected.txt: Removed.
  • fast/dom/MicroData/propertynodelist-add-remove-itemref-tokens.html: Removed.
  • fast/dom/MicroData/propertynodelist-crash-expected.txt: Removed.
  • fast/dom/MicroData/propertynodelist-crash.html: Removed.
  • fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element-expected.txt: Removed.
  • fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element.html: Removed.
  • fast/dom/MicroData/propertynodelist-getvalues-test-expected.txt: Removed.
  • fast/dom/MicroData/propertynodelist-getvalues-test.html: Removed.
  • fast/dom/MicroData/propertynodelist-test-add-remove-element-expected.txt: Removed.
  • fast/dom/MicroData/propertynodelist-test-add-remove-element.html: Removed.
  • fast/dom/MicroData/resources: Removed.
  • fast/dom/MicroData/resources/microdata-common.js: Removed.
4:21 PM Changeset in webkit [153771] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebCore

Remove PlatformCALayer::contentsTransform and ::setContentsTransform
https://bugs.webkit.org/show_bug.cgi?id=119529

Reviewed by Sam Weinig.

No new tests, removing dead code.

These methods are not used and are currently unimplemented.

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:
4:01 PM Changeset in webkit [153770] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Implement gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=102643

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-08-06
Reviewed by Gyuyoung Kim.

Recognize tap, pan and pinch gestures using touch events.
The tap gesture is separated into single tap, double tap and
'tap and hold'.

This patch references the webkit NIX port.
https://github.com/WebKitNix/webkitnix

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::doneWithTouchEvent):

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/API/efl/GestureRecognizer.cpp: Added.

(WebKit::GestureHandler::create):
(WebKit::GestureHandler::GestureHandler):
(WebKit::GestureHandler::handleSingleTap):
(WebKit::GestureHandler::handleDoubleTap):
(WebKit::GestureHandler::handleTapAndHold):
(WebKit::GestureHandler::handlePanStarted):
(WebKit::GestureHandler::handlePan):
(WebKit::GestureHandler::handlePanFinished):
(WebKit::GestureHandler::handlePinchStarted):
(WebKit::GestureHandler::handlePinch):
(WebKit::GestureHandler::handlePinchFinished):
(WebKit::GestureRecognizer::GestureRecognizer):
(WebKit::GestureRecognizer::~GestureRecognizer):
(WebKit::GestureRecognizer::processTouchEvent):
(WebKit::GestureRecognizer::doubleTapTimerCallback):
(WebKit::GestureRecognizer::tapAndHoldTimerCallback):
(WebKit::GestureRecognizer::exceedsPanThreshold):
(WebKit::GestureRecognizer::exceedsDoubleTapThreshold):
(WebKit::getPointAtIndex):
(WebKit::createVectorWithWKArray):
(WebKit::GestureRecognizer::noGesture):
(WebKit::GestureRecognizer::singleTapGesture):
(WebKit::GestureRecognizer::doubleTapGesture):
(WebKit::GestureRecognizer::panGesture):
(WebKit::GestureRecognizer::pinchGesture):
(WebKit::GestureRecognizer::reset):
(WebKit::GestureRecognizer::stopTapTimers):

  • UIProcess/API/efl/GestureRecognizer.h: Added.

(WebKit::GestureRecognizer::create):

3:16 PM Changeset in webkit [153769] by hmuller@adobe.com
  • 6 edits in trunk/LayoutTests

[CSS Shapes] New positioning model: scripted shape-margin tests
https://bugs.webkit.org/show_bug.cgi?id=119491

Update some of the shape-margin tests to work with the new positioning model. Floats
that specify shape-outside are now positioned according to their margin box, not the
bounding box of the shape-outside shape. The tests have been revised to reflect the
change.

Reviewed by Alexandru Chiculita.

  • TestExpectations:
  • fast/shapes/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:
3:11 PM Changeset in webkit [153768] by achristensen@apple.com
  • 6 edits in trunk/Source

Enabled WebGL on WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=119502

Reviewed by Benjamin Poulain.

Source/WebKit:

  • WebKit.vcxproj/WebKit.sln: Build ANGLE libraries.
  • WebKit.vcxproj/WebKit/WebKitCFLite.props: Link to ANGLE libraries.

Source/WTF:

  • wtf/FeatureDefines.h: Enabled WebGL.
  • wtf/Platform.h: Added definitions required for WebGL on Windows.
3:10 PM Changeset in webkit [153767] by mrowe@apple.com
  • 2 edits in trunk/Source/WTF

<rdar://problem/5927399> FastMalloc should support MallocStackLogging

Call the malloc stack logging function from within the various entry points to FastMalloc
when stack logging is enabled.

Reviewed by Oliver Hunt and Geoff Garen.

  • wtf/FastMalloc.cpp:

Call in to MallocHook::InvokeNewHook / MallocHook::InvokeDeleteHook at the appropriate entry
points to FastMalloc. The naming comes from TCMalloc's existing, unused concept of malloc hooks.
(WTF::MallocHook::record): Call the stack logging function with appropriate argument types.
(WTF::MallocHook::recordAllocation): Out-of-line slow path for when stack logging is enabled
that calls record with the values in the right arguments.
(WTF::MallocHook::recordDeallocation): Ditto.
(WTF::MallocHook::init): Stack logging is enabled if the system allocator has enabled stack logging.
(WTF::MallocHook::InvokeNewHook): Call recordAllocation in the unlikely event that stack logging is
enabled.
(WTF::MallocHook::InvokeDeleteHook): Ditto for recordDeallocation.
(WTF::TCMalloc_ThreadCache::InitModule): Initialize the malloc hook.

2:55 PM Changeset in webkit [153766] by achristensen@apple.com
  • 5 edits
    2 moves in trunk/Source/WebCore

Moved GraphicsContext3DPrivate out of cairo directory to be used by the AppleWin port.
https://bugs.webkit.org/show_bug.cgi?id=119525

Reviewed by Dean Jackson.

  • GNUmakefile.list.am:
  • PlatformGTK.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

Changed location of GraphicsContext3DPrivate.cpp and GraphicsContext3DPrivate.h.

  • platform/graphics/GraphicsContext3DPrivate.cpp: Copied from WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp.
  • platform/graphics/GraphicsContext3DPrivate.h: Copied from WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.h.
  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Removed.
  • platform/graphics/cairo/GraphicsContext3DPrivate.h: Removed.
2:38 PM Changeset in webkit [153765] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove stale code in ResourceContentView
https://bugs.webkit.org/show_bug.cgi?id=119527

The handling of Resource Type changes moved to ResourceClusterContentView,
this removeEventListener is stale and doesn't do anything anymore.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-08-06
Reviewed by Timothy Hatcher.

  • UserInterface/ResourceContentView.js:

(WebInspector.ResourceContentView.prototype.closed):

2:31 PM Changeset in webkit [153764] by Brent Fulgham
  • 4 edits in trunk/Source

[Windows] Unreviewed build correction after r153754 and r153757.

Source/WebCore:

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc): Don't force std::remainder, since we are using our own
custom implementation on Windows.

Source/WTF:

  • wtf/MathExtras.h:

(remainder): Provide implementation of C99 remainder for VS2010 (and earlier).

2:20 PM Changeset in webkit [153763] by oliver@apple.com
  • 8 edits
    3 adds in trunk

Delay Arguments creation in strict mode
https://bugs.webkit.org/show_bug.cgi?id=119505

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Make use of the write tracking performed by the parser to
allow us to know if we're modifying the parameters to a function.
Then use that information to make strict mode function opt out
of eager arguments creation.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::createArgumentsIfNecessary):
(JSC::BytecodeGenerator::emitReturn):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::shouldTearOffArgumentsEagerly):

  • parser/Nodes.h:

(JSC::ScopeNode::modifiesParameter):

  • parser/Parser.cpp:

(JSC::::parseInner):

  • parser/Parser.h:

(JSC::Scope::declareParameter):
(JSC::Scope::getCapturedVariables):
(JSC::Parser::declareWrite):

  • parser/ParserModes.h:

LayoutTests:

Add performance testcase for lazy creation of arguments in strict mode

  • fast/js/regress/delay-tear-off-arguments-strictmode-expected.txt: Added.
  • fast/js/regress/delay-tear-off-arguments-strictmode.html: Added.
  • fast/js/regress/script-tests/delay-tear-off-arguments-strictmode.js: Added.

(bar):

1:51 PM Changeset in webkit [153762] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Remove useless code from COMPILER(RVCT) JITStubs
https://bugs.webkit.org/show_bug.cgi?id=119521

Reviewed by Geoffrey Garen.

  • jit/JITStubsARMv7.h:

(JSC::ctiVMThrowTrampoline): "ldr r6, [sp, #PRESERVED_R6_OFFSET]" was called twice.
(JSC::ctiOpThrowNotCaught): Ditto.

1:37 PM Changeset in webkit [153761] by timothy@apple.com
  • 29 edits
    17 copies
    76 adds
    53 deletes in trunk/Source/WebInspectorUI

Convert all Web Inspector PDFs to SVGs.

Some PDFs need to stay around until bug 119492 is fixed. But the SVGs are there for when they are needed.
Updated some of the existing SVGs to be consistent with the format of the new SVGs.

https://bugs.webkit.org/show_bug.cgi?id=118677

Rubber-stamped by Joseph Pecoraro.

  • UserInterface/BreakpointIcons.css:
  • UserInterface/BreakpointTreeElement.css:
  • UserInterface/CallFrameIcons.css:
  • UserInterface/DatabaseContentView.css:
  • UserInterface/FilterBar.css:
  • UserInterface/HierarchicalPathComponent.css:
  • UserInterface/Images/BackArrow.svg: Added.
  • UserInterface/Images/BottomUpTree.svg: Added.
  • UserInterface/Images/BreakpointButton.pdf: Removed.
  • UserInterface/Images/BreakpointButton.svg: Added.
  • UserInterface/Images/BreakpointInactiveButton.pdf: Removed.
  • UserInterface/Images/BreakpointInactiveButton.svg: Added.
  • UserInterface/Images/Breakpoints.svg: Added.
  • UserInterface/Images/Close.svg: Added.
  • UserInterface/Images/Crosshair.svg: Added.
  • UserInterface/Images/DOMCharacterData.pdf: Removed.
  • UserInterface/Images/DOMCharacterData.svg: Added.
  • UserInterface/Images/DOMComment.pdf: Removed.
  • UserInterface/Images/DOMComment.svg: Added.
  • UserInterface/Images/DOMDocument.pdf: Removed.
  • UserInterface/Images/DOMDocument.svg: Added.
  • UserInterface/Images/DOMDocumentType.pdf: Removed.
  • UserInterface/Images/DOMDocumentType.svg: Added.
  • UserInterface/Images/DOMElement.pdf: Removed.
  • UserInterface/Images/DOMElement.svg: Added.
  • UserInterface/Images/DOMNode.pdf: Removed.
  • UserInterface/Images/DOMNode.svg: Added.
  • UserInterface/Images/DOMTextNode.pdf: Removed.
  • UserInterface/Images/DOMTextNode.svg: Added.
  • UserInterface/Images/DOMTree.pdf: Removed.
  • UserInterface/Images/DOMTree.svg: Added.
  • UserInterface/Images/DisclosureTriangleSmallClosed.svg: Added.
  • UserInterface/Images/DisclosureTriangleSmallOpen.svg: Added.
  • UserInterface/Images/DisclosureTriangleTinyClosed.svg: Added.
  • UserInterface/Images/DisclosureTriangleTinyOpen.svg: Added.
  • UserInterface/Images/DockBottom.svg: Added.
  • UserInterface/Images/DockRight.svg: Added.
  • UserInterface/Images/Error.pdf: Removed.
  • UserInterface/Images/Error.svg: Added.
  • UserInterface/Images/ErrorSmall.pdf: Removed.
  • UserInterface/Images/Errors.svg:
  • UserInterface/Images/ErrorsEnabled.svg:
  • UserInterface/Images/EventListener.pdf: Removed.
  • UserInterface/Images/EventListener.svg: Added.
  • UserInterface/Images/Exception.pdf: Removed.
  • UserInterface/Images/Exception.svg: Added.
  • UserInterface/Images/FilterFieldGlyph.pdf: Removed.
  • UserInterface/Images/FilterFieldGlyph.svg: Added.
  • UserInterface/Images/ForwardArrow.svg: Added.
  • UserInterface/Images/Function.pdf: Removed.
  • UserInterface/Images/Function.svg: Added.
  • UserInterface/Images/GoToArrow.svg: Added.
  • UserInterface/Images/HierarchicalNavigationItemChevron.pdf: Removed.
  • UserInterface/Images/HierarchicalNavigationItemChevron.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner1.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner1.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner10.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner10.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner11.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner11.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner12.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner12.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner2.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner2.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner3.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner3.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner4.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner4.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner5.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner5.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner6.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner6.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner7.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner7.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner8.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner8.svg: Added.
  • UserInterface/Images/IndeterminateProgressSpinner9.pdf: Removed.
  • UserInterface/Images/IndeterminateProgressSpinner9.svg: Added.
  • UserInterface/Images/Issues.svg:
  • UserInterface/Images/IssuesEnabled.svg:
  • UserInterface/Images/LayerBorders.svg: Added.
  • UserInterface/Images/LessColumns.svg: Added.
  • UserInterface/Images/Locked.svg: Added.
  • UserInterface/Images/Logs.svg:
  • UserInterface/Images/Memory.svg:
  • UserInterface/Images/MoreColumns.svg: Added.
  • UserInterface/Images/Native.pdf: Removed.
  • UserInterface/Images/Native.svg: Added.
  • UserInterface/Images/NavigationItemAngleBrackets.svg: Added.
  • UserInterface/Images/NavigationItemBrushAndRuler.svg: Added.
  • UserInterface/Images/NavigationItemBug.svg: Added.
  • UserInterface/Images/NavigationItemCurleyBraces.svg: Added.
  • UserInterface/Images/NavigationItemFile.svg: Added.
  • UserInterface/Images/NavigationItemLayers.svg: Added.
  • UserInterface/Images/NavigationItemLog.svg: Added.
  • UserInterface/Images/NavigationItemMagnifyingGlass.svg: Added.
  • UserInterface/Images/NavigationItemStopwatch.svg: Added.
  • UserInterface/Images/NavigationItemStorage.svg: Added.
  • UserInterface/Images/NavigationItemTrash.svg: Added.
  • UserInterface/Images/NavigationItemVariable.svg: Added.
  • UserInterface/Images/NetworkBarLabelCalloutLeft.pdf: Removed.
  • UserInterface/Images/NetworkBarLabelCalloutLeft.svg: Added.
  • UserInterface/Images/NetworkBarLabelCalloutRight.pdf: Removed.
  • UserInterface/Images/NetworkBarLabelCalloutRight.svg: Added.
  • UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.pdf: Removed.
  • UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.svg: Added.
  • UserInterface/Images/NetworkBarLabelCalloutWhiteRight.pdf: Removed.
  • UserInterface/Images/NetworkBarLabelCalloutWhiteRight.svg: Added.
  • UserInterface/Images/Pause.svg: Added.
  • UserInterface/Images/Percent.svg: Added.
  • UserInterface/Images/Plus.svg: Added.
  • UserInterface/Images/PseudoElement.pdf: Removed.
  • UserInterface/Images/PseudoElement.svg: Added.
  • UserInterface/Images/Reflection.pdf: Removed.
  • UserInterface/Images/Reflection.svg: Added.
  • UserInterface/Images/Reload.svg:
  • UserInterface/Images/ReloadSelected.svg:
  • UserInterface/Images/Request.pdf: Removed.
  • UserInterface/Images/Request.svg: Added.
  • UserInterface/Images/Resources.svg:
  • UserInterface/Images/Response.pdf: Removed.
  • UserInterface/Images/Response.svg: Added.
  • UserInterface/Images/ResultLine.pdf: Removed.
  • UserInterface/Images/ResultLine.svg: Added.
  • UserInterface/Images/Resume.svg: Added.
  • UserInterface/Images/ShadowDOM.svg: Added.
  • UserInterface/Images/SortIndicatorDownArrow.svg: Added.
  • UserInterface/Images/SortIndicatorUpArrow.svg: Added.
  • UserInterface/Images/SourceCode.pdf: Removed.
  • UserInterface/Images/SourceCode.svg: Added.
  • UserInterface/Images/SplitToggleDown.svg: Added.
  • UserInterface/Images/SplitToggleUp.svg: Added.
  • UserInterface/Images/StepInto.svg: Added.
  • UserInterface/Images/StepOut.svg: Added.
  • UserInterface/Images/StepOver.svg: Added.
  • UserInterface/Images/StyleRuleAuthor.pdf: Removed.
  • UserInterface/Images/StyleRuleAuthor.svg: Added.
  • UserInterface/Images/StyleRuleInherited.pdf: Removed.
  • UserInterface/Images/StyleRuleInherited.svg: Added.
  • UserInterface/Images/StyleRuleInheritedElement.pdf: Removed.
  • UserInterface/Images/StyleRuleInheritedElement.svg: Added.
  • UserInterface/Images/StyleRuleInspector.pdf: Removed.
  • UserInterface/Images/StyleRuleInspector.svg: Added.
  • UserInterface/Images/StyleRuleUser.pdf: Removed.
  • UserInterface/Images/StyleRuleUser.svg: Added.
  • UserInterface/Images/StyleRuleUserAgent.pdf: Removed.
  • UserInterface/Images/StyleRuleUserAgent.svg: Added.
  • UserInterface/Images/Time.svg:
  • UserInterface/Images/Undock.svg: Added.
  • UserInterface/Images/UpDownArrows.svg:
  • UserInterface/Images/UserInputPrompt.pdf: Removed.
  • UserInterface/Images/UserInputPrompt.svg: Added.
  • UserInterface/Images/UserInputPromptPrevious.pdf: Removed.
  • UserInterface/Images/UserInputPromptPrevious.svg: Added.
  • UserInterface/Images/UserInputPromptPreviousSelected.pdf: Removed.
  • UserInterface/Images/UserInputPromptPreviousSelected.svg: Added.
  • UserInterface/Images/UserInputResult.pdf: Removed.
  • UserInterface/Images/UserInputResult.svg: Added.
  • UserInterface/Images/UserInputResultSelected.pdf: Removed.
  • UserInterface/Images/UserInputResultSelected.svg: Added.
  • UserInterface/Images/Warning.pdf: Removed.
  • UserInterface/Images/Warning.svg: Added.
  • UserInterface/Images/WarningSmall.pdf: Removed.
  • UserInterface/Images/Weight.svg:
  • UserInterface/IndeterminateProgressSpinner.css:
  • UserInterface/LayerTreeSidebarPanel.css:
  • UserInterface/LogContentView.css:
  • UserInterface/Main.css:
  • UserInterface/NetworkTimeline.css:
  • UserInterface/PathComponentIcons.css:
  • UserInterface/QuickConsole.css:
  • UserInterface/RulesStyleDetailsPanel.css:
  • UserInterface/SearchIcons.css:
  • UserInterface/StyleRuleIcons.css:
12:33 PM Changeset in webkit [153760] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153758. <rdar://problem/14627254>

11:53 AM Changeset in webkit [153759] by Bem Jones-Bey
  • 2 edits
    4 moves in trunk/LayoutTests

[CSS Shapes] New positioning model: support for shape-margin
https://bugs.webkit.org/show_bug.cgi?id=118088

Reviewed by Alexandru Chiculita.

Update simple shape-margin tests to work with new positioning model.
Also move them to the CSSWG's repo.

  • TestExpectations: Remove replaced tests.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon-expected.html.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon.html.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon-expected.html.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon.html.
11:39 AM Changeset in webkit [153758] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Improper Calculation of In-band Cue Colors
https://bugs.webkit.org/show_bug.cgi?id=119523

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::makeRGBA32FromARGBCFArray): Remove redundant multiplication by

  1. The internal conversion logic already converts to bytes.
11:11 AM Changeset in webkit [153757] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative build fix after r153754.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

10:43 AM Changeset in webkit [153756] by dfarler@apple.com
  • 37 edits
    3 adds in trunk

Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
https://bugs.webkit.org/show_bug.cgi?id=117762

Reviewed by Mark Rowe.

Source/JavaScriptCore:

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • Configurations/JavaScriptCore.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • Configurations/ToolExecutable.xcconfig:

Don't use ASAN for build tools.

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • gtest/xcode/Config/StaticLibraryTarget.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS.

Source/ThirdParty/ANGLE:

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS.

Source/WebCore:

No new tests necessary.

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • Configurations/WebCore.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • Configurations/WebCoreTestShim.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • Configurations/WebCoreTestSupport.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • WebCore.xcodeproj/project.pbxproj:

Don't use ASAN for build tools.

Source/WebInspectorUI:

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

Source/WebKit/mac:

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • Configurations/WebKit.xcconfig:

Add ASAN_OTHER_LDFLAGS.

Source/WebKit2:

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • Configurations/WebContentProcess.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • Configurations/WebKit2.xcconfig:

Add ASAN_OTHER_LDFLAGS.

Source/WTF:

  • Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS.

Tools:

  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • MiniBrowser/Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • Scripts/check-for-weak-vtables-and-externals:

Ignore _asan externals, these are populated by compiler-rt.

  • TestWebKitAPI/Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • WebKitLauncher/Configurations/Base.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:

Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig:

Add ASAN_OTHER_LDFLAGS.

  • asan/asan.xcconfig: Added.
  • asan/webkit-asan-ignore.txt: Added.
9:16 AM Changeset in webkit [153755] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153753. <rdar://problem/14648086>

8:54 AM Changeset in webkit [153754] by rwlbuis@webkit.org
  • 6 edits in trunk

SVG stroke-dasharray is not animatable
https://bugs.webkit.org/show_bug.cgi?id=118574

Reviewed by Dirk Schulze.

Source/WebCore:

Make stroke-dasharray a property that can be animated using CSS transitions.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::CSSPropertyAnimation::ensurePropertyMap):

  • rendering/style/RenderStyle.h:

LayoutTests:

Add test for animating stroke-dasharray in addition to the original SVG tests.

  • transitions/svg-transitions-expected.txt:
  • transitions/svg-transitions.html:
8:40 AM Changeset in webkit [153753] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r151403): Resizing is extremely laggy on many sites when plugins are disallowed.
<http://webkit.org/b/119516>
<rdar://problem/14648086>

Reviewed by Simon Fraser.

The web process relies on the WindowAndViewFramesChanged mechanism for caching a copy
of the window rect for fast access from DOMWindow APIs.

We retain part of the optimization introduced in r151403, namely not computing the
viewFrameInWindowCoordinates and accessibilityPosition unless the web process needs them.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowAndViewFrames]):

8:08 AM Changeset in webkit [153752] by sergio@webkit.org
  • 8 edits
    2 adds in trunk

[CSS Grid Layout] Allow defining named grid lines on the grid element
https://bugs.webkit.org/show_bug.cgi?id=118255

Reviewed by Andreas Kling.

From Blink r149798 by <jchaffraix@chromium.org>

Source/WebCore:

This change adds parsing, style resolution and getComputedStyle
support for named grid lines at the grid element level
(i.e. extends our <track-list> support). Per the specification, we
allow multiple grid lines with the same name.

To fully support resolving the grid lines to a position on our
grid, we need to add the parsing at the grid item's level (which
means extending our <grid-line> support). This will be done in a
follow-up change.

Test: fast/css-grid-layout/named-grid-line-get-set.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::addValuesForNamedGridLinesAtIndex):
(WebCore::valueForGridTrackList):
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTrackList):

  • css/StyleResolver.cpp:

(WebCore::createGridTrackList):
(WebCore::StyleResolver::applyProperty):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData):

  • rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):

LayoutTests:

  • fast/css-grid-layout/named-grid-line-get-set-expected.txt: Added.
  • fast/css-grid-layout/named-grid-line-get-set.html: Added.
6:58 AM Changeset in webkit [153751] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/qt

[Qt] Add Page Visibility API support
https://bugs.webkit.org/show_bug.cgi?id=109422

Patch by Benjamin Dupont <bdupont@nds.com> on 2013-08-06
Reviewed by Simon Hausmann.

  • WebCoreSupport/QWebPageAdapter.cpp:

(webPageVisibilityStateToWebCoreVisibilityState):
(webCoreVisibilityStateToWebPageVisibilityState):
(QWebPageAdapter::setVisibilityState):
(QWebPageAdapter::visibilityState):

  • WebCoreSupport/QWebPageAdapter.h:
  • WidgetApi/qwebpage.cpp:

(QWebPage::setVisibilityState):
(QWebPage::visibilityState):

  • WidgetApi/qwebpage.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::changeVisibilityState):

5:52 AM Changeset in webkit [153750] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Fix minimal build.

Unreviewed build fix.

Fix build witt XSLT disabled

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::hasNoStyleInformation):

5:45 AM Changeset in webkit [153749] by zandobersek@gmail.com
  • 4 edits in trunk/Source

webkit-gtk fails to build with bison-3.0
https://bugs.webkit.org/show_bug.cgi?id=119373

Reviewed by Gustavo Noronha Silva.

Source/ThirdParty/ANGLE:

  • GNUmakefile.am: Stop relying on generated glslang_tab.(cpp|h) and glslang.cpp sources as Bison 3.0

produces non-compilable source code. Instead, compile these pregenerated files as they're included in
the tree. Originally, the ANGLE source tree provides these files as generated by Bison 2.7, but they're
at the moment regenerated with Bison 2.3 when the third-party ANGLE source is being updated.

Source/WebCore:

  • GNUmakefile.am: Remove rules for generating ANGLE's glslang source files with Bison.
4:45 AM Changeset in webkit [153748] by sergio@webkit.org
  • 16 edits in trunk

[CSS Grid Layout] Add support for parsing <grid-line> that includes a 'span'
https://bugs.webkit.org/show_bug.cgi?id=118051

Reviewed by Andreas Kling.

From Blink r148766 by <jchaffraix@chromium.org>

Source/WebCore:

This adds the parsing, style resolution and getComputedStyle bits
to our code. The rendering code was not made aware of the new type
of GridPosition yet.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridPosition):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridPosition):

  • css/CSSParser.h:
  • css/CSSValueKeywords.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustGridItemPosition):
(WebCore::createGridPosition):

  • css/StyleResolver.h:
  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveGridPositionFromStyle):

  • rendering/style/GridPosition.h:

(WebCore::GridPosition::isInteger):
(WebCore::GridPosition::isSpan):
(WebCore::GridPosition::setSpanPosition):
(WebCore::GridPosition::spanPosition):

LayoutTests:

Added several test cases to check that we properly parse the
keyword 'span' in <grid-line>.

  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:
  • fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-end-after-get-set.html:
  • fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-start-before-get-set.html:
4:08 AM Changeset in webkit [153747] by simon.pena@samsung.com
  • 2 edits in trunk

Build fix for GTK 32-bit after r153736

  • Source/autotools/symbols.filter: expose WebCore::SerializedScriptValue::create.
3:33 AM Changeset in webkit [153746] by sergio@webkit.org
  • 19 edits in trunk

[CSS Grid Layout] Rename grid placement properties
https://bugs.webkit.org/show_bug.cgi?id=117878

Reviewed by Andreas Kling.

Renamed the grid placement properties to match the latest version
of the spec. The new names are -webkit-grid-column-{start|end} and
-webkit-grid-row-{start|end}.

Source/WebCore:

No new tests needed as we're just renaming some properties,
functionality already covered by existing tests in
fast/css-grid-layout.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StylePropertyShorthand.cpp:

(WebCore::webkitGridColumnShorthand):
(WebCore::webkitGridRowShorthand):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
(WebCore::RenderGrid::resolveGridPositionFromStyle):

  • rendering/RenderGrid.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridItemData.cpp:

(WebCore::StyleGridItemData::StyleGridItemData):

  • rendering/style/StyleGridItemData.h:

(WebCore::StyleGridItemData::operator==):

LayoutTests:

  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:
  • fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-end-after-get-set.html:
  • fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-start-before-get-set.html:
3:04 AM Changeset in webkit [153745] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for ARM MSVC after r153222 and r153648.

  • jit/JITStubsARM.h: Added ctiVMThrowTrampolineSlowpath.
3:03 AM Changeset in webkit [153744] by Patrick Gansterer
  • 4 edits in trunk/Source/JavaScriptCore

Build fix for ARM MSVC after r150109.

Read the stub template from a header files instead of the JITStubs.cpp.

  • CMakeLists.txt:
  • DerivedSources.pri:
  • create_jit_stubs:
2:36 AM Changeset in webkit [153743] by simon.pena@samsung.com
  • 2 edits in trunk

Build fix for GTK after r153736

  • Source/autotools/symbols.filter: expose missing symbols

WebCore::SerializedScriptValue::create and WebCore::toJS to Internals.

Aug 5, 2013:

11:45 PM Changeset in webkit [153742] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WebGL] validateRenderingState method name change
https://bugs.webkit.org/show_bug.cgi?id=119485

According to validateRenderingState method functionality its name should be
changed. This method validates only vertex attributes.

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-08-05
Reviewed by Dean Jackson.

No new tests. Covered by existing tests. No changes in functionality.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateVertexAttributes):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):

  • html/canvas/WebGLRenderingContext.h:
11:21 PM Changeset in webkit [153741] by dino@apple.com
  • 1 edit in trunk/Websites/webkit.org/demos/srcset/index.html

Forgot to add alt text to the example image :(

  • demos/srcset/index.html:
11:01 PM Changeset in webkit [153740] by dino@apple.com
  • 1 edit
    4 moves
    1 add in trunk/Websites/webkit.org

Move previous commit into /demos.

  • demos/srcset/image-1x.png: Renamed from Websites/webkit.org/blog-files/srcset/image-1x.png.
  • demos/srcset/image-2x.png: Renamed from Websites/webkit.org/blog-files/srcset/image-2x.png.
  • demos/srcset/image-src.png: Renamed from Websites/webkit.org/blog-files/srcset/image-src.png.
  • demos/srcset/index.html: Renamed from Websites/webkit.org/blog-files/srcset/index.html.
8:16 PM Changeset in webkit [153739] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit/win

Another Windows release build fix.

  • WebKitLogging.cpp: Wrap the implementation file in !LOG_DISABLED #if's too.
8:10 PM Changeset in webkit [153738] by mrowe@apple.com
  • 2 edits in trunk/Source/WTF

Build fix for Windows.

  • wtf/Assertions.cpp: Include StringExtras.h rather than StdLibExtras.h, since the former is where

strncasecmp is declared.

8:03 PM Changeset in webkit [153737] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit/win

Build fix for Windows release build.

  • WebKitLogging.h: Wrap things in !LOG_DISABLED so that we don't attempt to use macros that have not been defined.
7:53 PM Changeset in webkit [153736] by mrowe@apple.com
  • 44 edits
    1 delete in trunk/Source

Logging should be configurable using human-readable channel names rather than crazy bitmasks
<http://webkit.org/b/119031>

Implement shared logic for initializing logging channels based on human-readable channel names in WTF,
and rework the WebCore, WebKit and WebKit2 logging initialization on top of it.

Logging channels may now be enabled by providing a comma-separated list of channel names, with the special
"all" name enabling all channels. Channel names prefixed with a leading "-" will result in the named channel
being disabled. For instance, specifying "all,-history,-loading" will result in all logging channels except
for history and loading being enabled.

For OS X developers, this also changes the name of the user defaults used to enable logging. This is done to allow
the old user defaults to remain set for those people that need to switch between version of WebKit before and
after this change. Where the old user default keys were WebCoreLogLevel, WebKitLogLevel and WebKit2LogLevel,
the new user default keys are WebCoreLogging, WebKitLogging and WebKit2Logging.

For GTK developers, this changes the separator used in the WEBKIT_DEBUG environment variable to a comma for
consistency with the other platforms and to enable more code sharing.

While doing this work I've also taken the opportunity to eliminate the need to touch multiple files when
adding a new logging channel. Now only the header in the relevant project needs to be updated.

Reviewed by Sam Weinig.

Source/WebCore:

  • GNUmakefile.list.am: Remove the now-unused InitializeLogging.h
  • Target.pri: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/InitializeLogging.h: Removed. Ditto.
  • platform/Logging.cpp: Use WEBCORE_LOG_CHANNELS to define all of the channels.

(WebCore::logChannelByName): Renamed to match our naming conventions. Calls through to the new WTF function
to find a log channel rather than repeating the names of the log channels a further two times each.
(WebCore::initializeLoggingChannelsIfNecessary): Pass the channels and the log level string to the new
WTF function that handles the initialization.

  • platform/Logging.h: Declare a WEBCORE_LOG_CHANNELS macro that can be used to apply a preprocessor macro

across the set of all logging channels. Use this macro to declare the logging channels.

  • platform/blackberry/LoggingBlackBerry.cpp:

(WebCore::logLevelString): Pull the value out of the WEBKIT_DEBUG environment variable.

  • platform/efl/LoggingEfl.cpp:

(WebCore::logLevelString): Pull the value out of the WEBKIT_DEBUG environment variable, and then prepend
NotYetImplemented to it so that that channel will be enabled by default.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink): Accommodate the rename to logChannelByName.

  • platform/gtk/LoggingGtk.cpp:

(WebCore::logLevelString): Pull the value out of the WEBKIT_DEBUG environment variable, and then prepend
NotYetImplemented to it so that that channel will be enabled by default.

  • platform/mac/LoggingMac.mm:

(WebCore::logLevelString): Pull the value out of the WebCoreLogging user default key.

  • platform/qt/LoggingQt.cpp:

(WebCore::logLevelString): Pull the value out of the QT_WEBKIT_LOG environment variable, and then prepend
NotYetImplemented to it so that the channel will be enabled by default.

  • platform/win/LoggingWin.cpp:

(WebCore::logLevelString): Pull the value out of the WebCoreLogging environment variable.

Source/WebKit/blackberry:

  • Api/BlackBerryGlobal.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/efl:

  • ewk/ewk_main.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/gtk:

  • webkit/webkitglobals.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/mac:

  • Misc/WebKitLogging.h: Declare a WEBKIT_LOG_CHANNELS macro that can be used to apply a preprocessor macro

across the set of all logging channels. Use this macro to declare the logging channels.

  • Misc/WebKitLogging.m: Use WEBKIT_LOG_CHANNELS to define all of the channels. Pass the channels and the

preference value to the new WTF function that handles the initialization.

  • WebView/WebPreferenceKeysPrivate.h: Remove a key that does not need to be here.
  • WebView/WebView.mm: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/qt:

  • WebCoreSupport/InitWebCoreQt.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit/win:

  • WebKitLogging.cpp: Declare a WEBKIT_LOG_CHANNELS macro that can be used to apply a preprocessor macro across

the set of all logging channels. Use this macro to declare the logging channels.

  • WebKitLogging.h: Use WEBKIT_LOG_CHANNELS to define all of the channels. Pass the channels to the new WTF

function that handles the initialization. As per the previous implementation a developer needs to hard-code
their desired log level here.

  • WebView.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WebKit2:

  • NetworkProcess/NetworkProcess.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.
  • Platform/Logging.cpp: Use WEBKIT2_LOG_CHANNELS to define all of the channels.

(WebKit::initializeLogChannelsIfNecessary): Pass the channels and the log level string to the new WTF function
that handles the initialization.
(WebKit::logChannelByName): Renamed to match our naming conventions. Calls through to the new WTF function
to find a log channel rather than repeating the names of the log channels a further two times each.
(WebKit::logLevelString): Provide a no-op implementation.

  • Platform/Logging.h: Declare a WEBKIT2_LOG_CHANNELS macro that can be used to apply a preprocessor macro

across the set of all logging channels. Use this macro to declare the logging channels.

  • Platform/efl/LoggingEfl.cpp:

(WebKit::logLevelString): Pull the value out of the WEBKIT_DEBUG environment variable.

  • Platform/gtk/LoggingGtk.cpp:

(WebKit::logLevelString): Ditto.

  • Platform/mac/Logging.mac.mm:

(WebKit::logLevelString): Pull the value out of the WebKit2Logging user default key.

  • Platform/qt/LoggingQt.cpp:

(WebKit::logLevelString): Pull the value out of the QT_WEBKIT_LOG environment variable.

  • Shared/WebKit2Initialize.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.
  • UIProcess/WebContext.cpp: Switch from WebCore's InitializeLogging.h to Logging.h.

Source/WTF:

  • wtf/Assertions.cpp:

(WTFLogChannelByName): Iterate over the provided array of log channels, returning the first whose name
matches case-insensitively.
(setStateOfAllChannels): Helper function to set the state of all channels to a single value.
(WTFInitializeLogChannelStatesFromString): Parse a string containing a case-insensitive, comma-separated list
of channel names to enable or disable, with the latter being prefixed by a "-".

  • wtf/Assertions.h: Update the layout of WTFLogChannel to include only the state of the channel and its name.

Declare WTFLogChannelByName and WTFInitializeLogChannelStatesFromString.

  • wtf/RefCountedLeakCounter.cpp: Update to the new format of WTFLogChannel.
7:03 PM Changeset in webkit [153735] by dino@apple.com
  • 1 edit
    5 adds in trunk/Websites/webkit.org

Upload example for a blog post.

  • blog-files/srcset/image-1x.png: Added.
  • blog-files/srcset/image-2x.png: Added.
  • blog-files/srcset/image-src.png: Added.
  • blog-files/srcset/index.html: Added.
7:02 PM Changeset in webkit [153734] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Editor::updateMarkersForWordsAffectedByEditing(bool) shouldn't compute start and end of words when there are nor markers
https://bugs.webkit.org/show_bug.cgi?id=119501

Reviewed by Enrica Casucci.

Exit early in updateMarkersForWordsAffectedByEditing before calling startOfWord and endOfWord if there are no document markers.

  • dom/DocumentMarkerController.h:

(WebCore::DocumentMarkerController::hasMarkers): Added.

  • editing/Editor.cpp:

(WebCore::Editor::updateMarkersForWordsAffectedByEditing):

6:13 PM Changeset in webkit [153733] by dino@apple.com
  • 9 edits
    2 adds in trunk

Update HTMLPreloadScanner to handle img srcset
https://bugs.webkit.org/show_bug.cgi?id=119360

Reviewed by Sam Weinig.

This patch is a merge of similar patches from Yoav Weiss <yoav@yoav.ws>
and Dean Jackson.

Source/WebCore:

Test: fast/preloader/image-srcset.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute): Move srcset parsing into
HTMLParserIdioms, and call it when we hit src or srcset.

  • html/HTMLImageElement.h: Remove code that was moved to HTMLParserIdioms.
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer): Pass device scale into preloader.
(WebCore::HTMLDocumentParser::insert):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner): Takes device scale as a parameter.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): Resolve between src and srcSet if necessary.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): Add support for srcset attribute.
(WebCore::TokenPreloadScanner::StartTagScanner::setUrlToLoad): New flag to indicate if we should
replace any existing value.
(WebCore::TokenPreloadScanner::TokenPreloadScanner): Takes device scale.
(WebCore::TokenPreloadScanner::scanCommon): Pass device scale.
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):

  • html/parser/HTMLPreloadScanner.h: New attribute to constructor for device scale. New member

variable on TokenPreloadScanner that holds the srcset value.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::ImageWithScale::operator==): Used for sorting.
(WebCore::compareByScaleFactor): Used for sorting.
(WebCore::bestFitSourceForImageAttributes): New method that takes the code from HTMLImageElement
for parsing src and srcset attributes, and finding the best match.

  • html/parser/HTMLParserIdioms.h:

LayoutTests:

New test to make sure the HTML preloader takes the
value of srcset if available.

  • fast/preloader/image-srcset-expected.txt: Added.
  • fast/preloader/image-srcset.html: Added.
5:41 PM Changeset in webkit [153732] by achristensen@apple.com
  • 7 edits
    1 add in trunk/Source/ThirdParty/ANGLE

Added optimizations to Windows ANGLE builds.
https://bugs.webkit.org/show_bug.cgi?id=119500

Reviewed by Brent Fulgham.

  • ANGLE.vcxproj/ANGLERelease.props: Added.
  • ANGLE.vcxproj/libEGL.vcxproj:
  • ANGLE.vcxproj/libGLESv2.vcxproj:
  • ANGLE.vcxproj/preprocessor.vcxproj:
  • ANGLE.vcxproj/translator_common.vcxproj:
  • ANGLE.vcxproj/translator_glsl.vcxproj:
  • ANGLE.vcxproj/translator_hlsl.vcxproj:

Use ANGLERelease.props for Release, Release_WinCairo, and Production configurations.

5:39 PM Changeset in webkit [153731] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebKit

Gardening: fix build after r153728.

Not reviewed.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
5:28 PM Changeset in webkit [153730] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Disable <meter> by default on iOS, it is enabled through the xconfig files
https://bugs.webkit.org/show_bug.cgi?id=119503

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-08-05
Reviewed by Alexey Proskuryakov.

  • wtf/FeatureDefines.h:
4:06 PM Changeset in webkit [153729] by ap@apple.com
  • 2 edits in trunk/LayoutTests

<rdar://problem/13128990> chunked-progress-event-expectedLength.html is flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=119498

Reviewed by Brady Eidson.

  • http/tests/xmlhttprequest/resources/chunked-transfer.php: This test relies on length not being known upfront, which is not the case when the resource is served form cache.
3:11 PM Changeset in webkit [153728] by oliver@apple.com
  • 122 edits
    15 moves
    13 adds in trunk/Source

Move TypedArray implementation into JSC
https://bugs.webkit.org/show_bug.cgi?id=119489

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Move TypedArray implementation into JSC in advance of re-implementation

  • GNUmakefile.list.am:
  • JSCTypedArrayStubs.h:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/ArrayBuffer.cpp: Renamed from Source/WTF/wtf/ArrayBuffer.cpp.

(JSC::ArrayBuffer::transfer):
(JSC::ArrayBuffer::addView):
(JSC::ArrayBuffer::removeView):

  • runtime/ArrayBuffer.h: Renamed from Source/WTF/wtf/ArrayBuffer.h.

(JSC::ArrayBufferContents::ArrayBufferContents):
(JSC::ArrayBufferContents::data):
(JSC::ArrayBufferContents::sizeInBytes):
(JSC::ArrayBufferContents::transfer):
(JSC::ArrayBufferContents::copyTo):
(JSC::ArrayBuffer::isNeutered):
(JSC::ArrayBuffer::~ArrayBuffer):
(JSC::ArrayBuffer::clampValue):
(JSC::ArrayBuffer::create):
(JSC::ArrayBuffer::createUninitialized):
(JSC::ArrayBuffer::ArrayBuffer):
(JSC::ArrayBuffer::data):
(JSC::ArrayBuffer::byteLength):
(JSC::ArrayBuffer::slice):
(JSC::ArrayBuffer::sliceImpl):
(JSC::ArrayBuffer::clampIndex):
(JSC::ArrayBufferContents::tryAllocate):
(JSC::ArrayBufferContents::~ArrayBufferContents):

  • runtime/ArrayBufferView.cpp: Renamed from Source/WTF/wtf/ArrayBufferView.cpp.

(JSC::ArrayBufferView::ArrayBufferView):
(JSC::ArrayBufferView::~ArrayBufferView):
(JSC::ArrayBufferView::neuter):

  • runtime/ArrayBufferView.h: Renamed from Source/WTF/wtf/ArrayBufferView.h.

(JSC::ArrayBufferView::buffer):
(JSC::ArrayBufferView::baseAddress):
(JSC::ArrayBufferView::byteOffset):
(JSC::ArrayBufferView::setNeuterable):
(JSC::ArrayBufferView::isNeuterable):
(JSC::ArrayBufferView::verifySubRange):
(JSC::ArrayBufferView::clampOffsetAndNumElements):
(JSC::ArrayBufferView::setImpl):
(JSC::ArrayBufferView::setRangeImpl):
(JSC::ArrayBufferView::zeroRangeImpl):
(JSC::ArrayBufferView::calculateOffsetAndLength):

  • runtime/Float32Array.h: Renamed from Source/WTF/wtf/Float32Array.h.

(JSC::Float32Array::set):
(JSC::Float32Array::getType):
(JSC::Float32Array::create):
(JSC::Float32Array::createUninitialized):
(JSC::Float32Array::Float32Array):
(JSC::Float32Array::subarray):

  • runtime/Float64Array.h: Renamed from Source/WTF/wtf/Float64Array.h.

(JSC::Float64Array::set):
(JSC::Float64Array::getType):
(JSC::Float64Array::create):
(JSC::Float64Array::createUninitialized):
(JSC::Float64Array::Float64Array):
(JSC::Float64Array::subarray):

  • runtime/Int16Array.h: Renamed from Source/WTF/wtf/Int16Array.h.

(JSC::Int16Array::getType):
(JSC::Int16Array::create):
(JSC::Int16Array::createUninitialized):
(JSC::Int16Array::Int16Array):
(JSC::Int16Array::subarray):

  • runtime/Int32Array.h: Renamed from Source/WTF/wtf/Int32Array.h.

(JSC::Int32Array::getType):
(JSC::Int32Array::create):
(JSC::Int32Array::createUninitialized):
(JSC::Int32Array::Int32Array):
(JSC::Int32Array::subarray):

  • runtime/Int8Array.h: Renamed from Source/WTF/wtf/Int8Array.h.

(JSC::Int8Array::getType):
(JSC::Int8Array::create):
(JSC::Int8Array::createUninitialized):
(JSC::Int8Array::Int8Array):
(JSC::Int8Array::subarray):

  • runtime/IntegralTypedArrayBase.h: Renamed from Source/WTF/wtf/IntegralTypedArrayBase.h.

(JSC::IntegralTypedArrayBase::set):
(JSC::IntegralTypedArrayBase::IntegralTypedArrayBase):

  • runtime/TypedArrayBase.h: Renamed from Source/WTF/wtf/TypedArrayBase.h.

(JSC::TypedArrayBase::data):
(JSC::TypedArrayBase::set):
(JSC::TypedArrayBase::setRange):
(JSC::TypedArrayBase::zeroRange):
(JSC::TypedArrayBase::length):
(JSC::TypedArrayBase::byteLength):
(JSC::TypedArrayBase::item):
(JSC::TypedArrayBase::checkInboundData):
(JSC::TypedArrayBase::TypedArrayBase):
(JSC::TypedArrayBase::create):
(JSC::TypedArrayBase::createUninitialized):
(JSC::TypedArrayBase::subarrayImpl):
(JSC::TypedArrayBase::neuter):

  • runtime/Uint16Array.h: Renamed from Source/WTF/wtf/Uint16Array.h.

(JSC::Uint16Array::getType):
(JSC::Uint16Array::create):
(JSC::Uint16Array::createUninitialized):
(JSC::Uint16Array::Uint16Array):
(JSC::Uint16Array::subarray):

  • runtime/Uint32Array.h: Renamed from Source/WTF/wtf/Uint32Array.h.

(JSC::Uint32Array::getType):
(JSC::Uint32Array::create):
(JSC::Uint32Array::createUninitialized):
(JSC::Uint32Array::Uint32Array):
(JSC::Uint32Array::subarray):

  • runtime/Uint8Array.h: Renamed from Source/WTF/wtf/Uint8Array.h.

(JSC::Uint8Array::getType):
(JSC::Uint8Array::create):
(JSC::Uint8Array::createUninitialized):
(JSC::Uint8Array::Uint8Array):
(JSC::Uint8Array::subarray):

  • runtime/Uint8ClampedArray.h: Renamed from Source/WTF/wtf/Uint8ClampedArray.h.

(JSC::Uint8ClampedArray::getType):
(JSC::Uint8ClampedArray::create):
(JSC::Uint8ClampedArray::createUninitialized):
(JSC::Uint8ClampedArray::zeroFill):
(JSC::Uint8ClampedArray::set):
(JSC::Uint8ClampedArray::Uint8ClampedArray):
(JSC::Uint8ClampedArray::subarray):

  • runtime/VM.h:

Source/WebCore:

Update WebCore for new location of TypedArray implementation.

  • ForwardingHeaders/runtime/ArrayBuffer.h: Added.
  • ForwardingHeaders/runtime/ArrayBufferView.h: Added.
  • ForwardingHeaders/runtime/Float32Array.h: Added.
  • ForwardingHeaders/runtime/Float64Array.h: Added.
  • ForwardingHeaders/runtime/Int16Array.h: Added.
  • ForwardingHeaders/runtime/Int32Array.h: Added.
  • ForwardingHeaders/runtime/Int8Array.h: Added.
  • ForwardingHeaders/runtime/IntegralTypedArrayBase.h: Added.
  • ForwardingHeaders/runtime/TypedArrayBase.h: Added.
  • ForwardingHeaders/runtime/Uint16Array.h: Added.
  • ForwardingHeaders/runtime/Uint32Array.h: Added.
  • ForwardingHeaders/runtime/Uint8Array.h: Added.
  • ForwardingHeaders/runtime/Uint8ClampedArray.h: Added.
  • Modules/webaudio/AnalyserNode.h:

(WebCore::AnalyserNode::getFloatFrequencyData):
(WebCore::AnalyserNode::getByteFrequencyData):
(WebCore::AnalyserNode::getByteTimeDomainData):

  • Modules/webaudio/AsyncAudioDecoder.cpp:
  • Modules/webaudio/AsyncAudioDecoder.h:

(WebCore::AsyncAudioDecoder::DecodingTask::audioData):

  • Modules/webaudio/AudioBuffer.h:
  • Modules/webaudio/AudioContext.cpp:
  • Modules/webaudio/AudioParam.h:
  • Modules/webaudio/AudioParamTimeline.h:
  • Modules/webaudio/PeriodicWave.h:
  • Modules/webaudio/RealtimeAnalyser.cpp:
  • Modules/webaudio/RealtimeAnalyser.h:
  • Modules/webaudio/ScriptProcessorNode.cpp:
  • Modules/webaudio/WaveShaperProcessor.h:
  • Modules/websockets/ThreadableWebSocketChannel.h:
  • Modules/websockets/WebSocket.cpp:
  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocketChannel.cpp:
  • Modules/websockets/WebSocketChannel.h:
  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
  • Modules/websockets/WorkerThreadableWebSocketChannel.h:
  • WebCore.exp.in:
  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSArrayBufferViewHelper.h:
  • bindings/js/JSAudioContextCustom.cpp:
  • bindings/js/JSCryptoCustom.cpp:
  • bindings/js/JSDictionary.h:
  • bindings/js/JSFileReaderCustom.cpp:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::transferArrayBuffers):

  • bindings/js/SerializedScriptValue.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
(GenerateHeader):
(NativeToJSValue):

  • dom/MessageEvent.h:
  • fileapi/FileReader.cpp:
  • fileapi/FileReader.h:
  • fileapi/FileReaderLoader.cpp:
  • fileapi/FileReaderLoader.h:
  • fileapi/FileReaderSync.cpp:
  • fileapi/FileReaderSync.h:
  • fileapi/WebKitBlobBuilder.cpp:
  • fileapi/WebKitBlobBuilder.h:
  • html/HTMLMediaElement.cpp:
  • html/ImageData.h:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/DataView.h:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/canvas/WebGLBuffer.h:

(WebCore::WebGLBuffer::elementArrayBuffer):

  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLGetInfo.h:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • inspector/InspectorMemoryAgent.cpp:
  • page/Crypto.cpp:
  • page/Crypto.h:
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/filters/FEBlend.cpp:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEComponentTransfer.cpp:
  • platform/graphics/filters/FEComposite.cpp:
  • platform/graphics/filters/FEConvolveMatrix.cpp:
  • platform/graphics/filters/FECustomFilter.cpp:
  • platform/graphics/filters/FEDisplacementMap.cpp:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FEGaussianBlur.cpp:
  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMorphology.cpp:
  • platform/graphics/filters/FETurbulence.cpp:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
  • testing/Internals.h:
  • xml/XMLHttpRequest.cpp:
  • xml/XMLHttpRequest.h:

(WebCore::XMLHttpRequest::optionalResponseArrayBuffer):

Source/WTF:

Remove TypedArray implementation from WTF

  • GNUmakefile.list.am:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/Forward.h:
3:11 PM Changeset in webkit [153727] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-537-branch

Merged r153725. <rdar://problem/14637103>

3:05 PM Changeset in webkit [153726] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r153724. <rdar://problem/14610818>

2:56 PM Changeset in webkit [153725] by ap@apple.com
  • 4 edits
    2 adds in trunk

<rdar://problem/14637103> REGRESSION (r153060?): Microphone appears in the way
of text when dictating an e-mail
https://bugs.webkit.org/show_bug.cgi?id=119496

Reviewed by Ryosuke Niwa.

Test: platform/mac/editing/input/firstrectforcharacterrange-caret-in-br.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRectForRange): FloatRect::unite() doesn't preserve empty rects, which we need here. We alrady handle the case of collapsed range in Editor::firstRectForRange(), and this is similar, but we can't currently cover both with one simple fix.
2:26 PM Changeset in webkit [153724] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Ignore the Apple Java placeholder plug-in
https://bugs.webkit.org/show_bug.cgi?id=119494
<rdar://problem/14610818>

Reviewed by Beth Dakin.

Never attempt to load the Java placeholder plug-in.

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::shouldUsePlugin):

2:20 PM Changeset in webkit [153723] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

Region based columns not painted correctly in non-default writing-modes
https://bugs.webkit.org/show_bug.cgi?id=118506

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-08-05
Reviewed by David Hyatt.

Source/WebCore:

The column translation offset was calculated incorrectly.
The dirty rect intersection check was also wrong.

Added some documentation, to make it clear what's going on.

Tests: fast/multicol/newmulticol/hide-box-horizontal-bt.html

fast/multicol/newmulticol/hide-box-vertical-lr.html
fast/multicol/newmulticol/hide-box-vertical-rl.html

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::collectLayerFragments):

LayoutTests:

  • fast/multicol/newmulticol/hide-box-horizontal-bt-expected.html: Added.
  • fast/multicol/newmulticol/hide-box-horizontal-bt.html: Added.
  • fast/multicol/newmulticol/hide-box-vertical-lr-expected.html: Added.
  • fast/multicol/newmulticol/hide-box-vertical-lr.html: Added.
  • fast/multicol/newmulticol/hide-box-vertical-rl-expected.html: Added.
  • fast/multicol/newmulticol/hide-box-vertical-rl.html: Added.
2:17 PM Changeset in webkit [153722] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

Region based columns not clipped properly
https://bugs.webkit.org/show_bug.cgi?id=118499

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-08-05
Reviewed by David Hyatt.

Source/WebCore:

Need to call RenderRegion::overflowRectForFlowThreadPortion() first,
and THEN clip in the column gaps. overflowRectForFlowThreadPortion()
expands the logical left and right to the flow thread's overflow
rectangle, effectively defeating inline direction clipping completely.

Tests: fast/multicol/newmulticol/clipping-overflow-hidden.html

fast/multicol/newmulticol/clipping-top-overflow.html
fast/multicol/newmulticol/clipping.html

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):

LayoutTests:

  • fast/multicol/newmulticol/clipping-expected.html: Added.
  • fast/multicol/newmulticol/clipping-overflow-hidden-expected.html: Added.
  • fast/multicol/newmulticol/clipping-overflow-hidden.html: Added.
  • fast/multicol/newmulticol/clipping-top-overflow-expected.html: Added.
  • fast/multicol/newmulticol/clipping-top-overflow.html: Added.
  • fast/multicol/newmulticol/clipping.html: Added.
1:26 PM Changeset in webkit [153721] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Implement leak checking with valgrind
https://bugs.webkit.org/show_bug.cgi?id=118785

Patch by Brian Holt <brian.holt@samsung.com> on 2013-08-05
Reviewed by Dirk Pranke.

Launch the DRT under Valgrind to generate xml files with details
of leaks found.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.init):
(GtkPort.default_timeout_ms): Allow extra time to run under
Valgrind.
(GtkPort.setup_environ_for_server): Pass Valgrind instructions
using environment variables.

12:52 PM Changeset in webkit [153720] by fpizlo@apple.com
  • 17 edits
    1 add in trunk/Source/JavaScriptCore

Copied space should be able to handle more than one copied backing store per JSCell
https://bugs.webkit.org/show_bug.cgi?id=119471

Reviewed by Mark Hahnenberg.

This allows a cell to call copyLater() multiple times for multiple different
backing stores, and then have copyBackingStore() called exactly once for each
of those. A token tells it which backing store to copy. All backing stores
must be named using the CopyToken, an enumeration which currently cannot
exceed eight entries.

When copyBackingStore() is called, it's up to the callee to (a) use the token
to decide what to copy and (b) call its base class's copyBackingStore() in
case the base class had something that needed copying. The only exception is
that JSCell never asks anything to be copied, and so if your base is JSCell
then you don't have to do anything.

  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/CopiedBlock.h:
  • heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes):

  • heap/CopyToken.h: Added.
  • heap/CopyVisitor.cpp:

(JSC::CopyVisitor::copyFromShared):

  • heap/CopyVisitor.h:
  • heap/CopyVisitorInlines.h:

(JSC::CopyVisitor::visitItem):

  • heap/CopyWorkList.h:

(JSC::CopyWorklistItem::CopyWorklistItem):
(JSC::CopyWorklistItem::cell):
(JSC::CopyWorklistItem::token):
(JSC::CopyWorkListSegment::get):
(JSC::CopyWorkListSegment::append):
(JSC::CopyWorkListSegment::data):
(JSC::CopyWorkListIterator::get):
(JSC::CopyWorkListIterator::operator*):
(JSC::CopyWorkListIterator::operator->):
(JSC::CopyWorkList::append):

  • heap/SlotVisitor.h:
  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::copyLater):

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::copyBackingStore):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::visitButterfly):
(JSC::JSObject::copyBackingStore):

  • runtime/JSObject.h:
12:38 PM Changeset in webkit [153719] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r152884. <rdar://problem/14472043>

12:35 PM Changeset in webkit [153718] by Lucas Forschler
  • 7 edits in branches/safari-537-branch/Source/WebCore

Merged r152876. <rdar://problem/14472043>

12:31 PM Changeset in webkit [153717] by Lucas Forschler
  • 11 edits in branches/safari-537-branch

Merged r153628. <rdar://problem/14498362>

12:27 PM Changeset in webkit [153716] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153377. <rdar://problem/13011371>

12:25 PM Changeset in webkit [153715] by Lucas Forschler
  • 17 edits
    6 copies in branches/safari-537-branch

Merged r152861. <rdar://problem/13011371>

11:04 AM Changeset in webkit [153714] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source/WebCore

Merged r153706. <rdar://problem/14637544>

10:49 AM Changeset in webkit [153713] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source/WebCore

Merged r153699. <rdar://problem/14643481>

10:42 AM Changeset in webkit [153712] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source/WebCore

Merged r153696. <rdar://problem/14643349>

10:33 AM Changeset in webkit [153711] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source/WebCore

Merged r153695. <rdar://problem/14616012>

10:27 AM Changeset in webkit [153710] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r153591. <rdar://problem/14616012>

10:20 AM Changeset in webkit [153709] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WTF

Merged r153455. <rdar://problem/14528244>

10:13 AM Changeset in webkit [153708] by Lucas Forschler
  • 4 edits
    3 adds in branches/safari-537-branch

Merge patch for <rdar://problem/14624998>

9:26 AM Changeset in webkit [153707] by vivek.vg@samsung.com
  • 4 edits in trunk/Source/WebCore

XMLTreeViewer should be created only in the XML viewer mode
https://bugs.webkit.org/show_bug.cgi?id=119483

Reviewed by Alexey Proskuryakov.

XMLTreeViewer is created even for the XSL transform which is avoided by the patch.
The XMLTreeViewer::hasNoStyleInformation() is moved to XMLDocumentParserLibxml2.cpp
as static inline method as XMLTreeViewer should not have the responsibility for it.
Also removes an unnecessary conditional check while deciding for XML viewer mode.

Blink patch review links:
https://codereview.chromium.org/19552003/
https://codereview.chromium.org/22150003/

No new tests as the patch is about code refactoring.

  • xml/XMLTreeViewer.cpp:
  • xml/XMLTreeViewer.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::hasNoStyleInformation):
(WebCore::XMLDocumentParser::doEnd):

8:29 AM Changeset in webkit [153706] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

Loading a video with a custom URL scheme will result in stalling playback
https://bugs.webkit.org/show_bug.cgi?id=119469

Reviewed by Eric Carlson.

Break the assumption that only one AVAssetResourceRequest will be outstanding simultaneously
by storing a HashMap of AVAssetResourceRequests and their resulting WebCoreAVFResourceLoader.
When loading is stopped (due to completion or error), notify the MediaPlayerPrivateAVFoundation
parent so that the map can be emptied.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource): Store the request

in m_resourceLoaderMap.

(WebCore::MediaPlayerPrivateAVFoundationObjC::didCancelLoadingRequest): Pull the request from

m_resourceLoaderMap.

(WebCore::MediaPlayerPrivateAVFoundationObjC::didStopLoadingRequest): Remove the requset from

m_resourceLoaderMap.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::create): Return a PassRefPtr, rather than a PassOwnPtr.
(WebCore::WebCoreAVFResourceLoader::stopLoading): Call didStopLoadingRequest.

7:23 AM Changeset in webkit [153705] by commit-queue@webkit.org
  • 47 edits in trunk/LayoutTests

Make tests platform agnostic, fix async tests, remove broken blend modes: hue, saturation, color, luminosity, soft-light.
The test suite should now pass on windows.

https://bugs.webkit.org/show_bug.cgi?id=119463

Patch by Mihai Tica <mitica@adobe.com> on 2013-08-05
Reviewed by Dirk Schulze.

  • fast/canvas/canvas-blending-clipping-expected.txt:
  • fast/canvas/canvas-blending-clipping.html:
  • fast/canvas/canvas-blending-color-over-color-expected.txt:
  • fast/canvas/canvas-blending-color-over-color.html:
  • fast/canvas/canvas-blending-color-over-gradient-expected.txt:
  • fast/canvas/canvas-blending-color-over-gradient.html:
  • fast/canvas/canvas-blending-color-over-image-expected.txt:
  • fast/canvas/canvas-blending-color-over-image.html:
  • fast/canvas/canvas-blending-color-over-pattern-expected.txt:
  • fast/canvas/canvas-blending-color-over-pattern.html:
  • fast/canvas/canvas-blending-fill-style-expected.txt:
  • fast/canvas/canvas-blending-fill-style.html:
  • fast/canvas/canvas-blending-global-alpha-expected.txt:
  • fast/canvas/canvas-blending-global-alpha.html:
  • fast/canvas/canvas-blending-gradient-over-color-expected.txt:
  • fast/canvas/canvas-blending-gradient-over-color.html:
  • fast/canvas/canvas-blending-gradient-over-gradient-expected.txt:
  • fast/canvas/canvas-blending-gradient-over-gradient.html:
  • fast/canvas/canvas-blending-gradient-over-image-expected.txt:
  • fast/canvas/canvas-blending-gradient-over-image.html:
  • fast/canvas/canvas-blending-gradient-over-pattern-expected.txt:
  • fast/canvas/canvas-blending-gradient-over-pattern.html:
  • fast/canvas/canvas-blending-helpers.js:

(separateBlendFunctions.hardLight):
(nonSeparateBlendFunctions.hue):
(nonSeparateBlendFunctions.saturation):
(nonSeparateBlendFunctions.color):
(nonSeparateBlendFunctions.luminosity):

  • fast/canvas/canvas-blending-image-over-color-expected.txt:
  • fast/canvas/canvas-blending-image-over-color.html:
  • fast/canvas/canvas-blending-image-over-gradient-expected.txt:
  • fast/canvas/canvas-blending-image-over-gradient.html:
  • fast/canvas/canvas-blending-image-over-image-expected.txt:
  • fast/canvas/canvas-blending-image-over-image.html:
  • fast/canvas/canvas-blending-image-over-pattern-expected.txt:
  • fast/canvas/canvas-blending-image-over-pattern.html:
  • fast/canvas/canvas-blending-pattern-over-color-expected.txt:
  • fast/canvas/canvas-blending-pattern-over-color.html:
  • fast/canvas/canvas-blending-pattern-over-gradient-expected.txt:
  • fast/canvas/canvas-blending-pattern-over-gradient.html:
  • fast/canvas/canvas-blending-pattern-over-image-expected.txt:
  • fast/canvas/canvas-blending-pattern-over-image.html:
  • fast/canvas/canvas-blending-pattern-over-pattern-expected.txt:
  • fast/canvas/canvas-blending-pattern-over-pattern.html:
  • fast/canvas/canvas-blending-shadow-expected.txt:
  • fast/canvas/canvas-blending-shadow.html:
  • fast/canvas/canvas-blending-text-expected.txt:
  • fast/canvas/canvas-blending-text.html:
  • fast/canvas/canvas-blending-transforms-expected.txt:
  • fast/canvas/canvas-blending-transforms.html:
  • platform/win/TestExpectations:
6:09 AM Changeset in webkit [153704] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

Spatial Navigation should avoid unwanted calculation while deciding focus candidate.
https://bugs.webkit.org/show_bug.cgi?id=117265

Patch by Abhijeet Kandalkar <abhijeet.k@samsung.com> on 2013-08-05
Reviewed by Antonio Gomes.

Source/WebCore:

Spatial Navigation should consider only those nodes as candidate which are exactly in the focus-direction.
e.g. If we are moving down then the nodes that are above CURRENT focused node should be considered as invalid.
Added isValidCandidate() which checks whether node is exactly in the focus-direction.

Test: fast/spatial-navigation/snav-search-optimization.html

  • page/FocusController.cpp:

(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionally):

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(WebCore::Page::setLastSpatialNavigationCandidateCount):
(WebCore::Page::lastSpatialNavigationCandidateCount):

  • page/SpatialNavigation.cpp:

(WebCore::isValidCandidate):

  • page/SpatialNavigation.h:
  • testing/Internals.cpp:

(WebCore::Internals::lastSpatialNavigationCandidateCount):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Added testcases to count how many target nodes were tested before choosing a final target.

  • fast/spatial-navigation/snav-search-optimization-expected.txt: Added.
  • fast/spatial-navigation/snav-search-optimization.html: Added.
12:58 AM Changeset in webkit [153703] by zandobersek@gmail.com
  • 6 edits in trunk

[Automake] Define ENABLE_JIT through the Autoconf header
https://bugs.webkit.org/show_bug.cgi?id=119445

Reviewed by Martin Robinson.

.:

Instead of defining the ENABLE_JIT value through JSC_CPPFLAGS, the feature define is
set to be either enabled or disabled through the Autoconf header, based on the value
passed through the configuration flag. The 'auto' value is used as default, meaning
that the feature is enabled or disabled in the Platform.h header based on the platform
configuration (OS, architecture etc.).

  • Source/autotools/FindDependencies.m4: Remove the JSC_CPPFLAGS definition.
  • Source/autotools/ReadCommandLineArguments.m4: Change the default value to 'auto' instead

of 'autodetect', as used by other configuration options that take a similar approach to enabling
a specific feature.

  • Source/autotools/SetupAutoconfHeader.m4: Set a strict value for the ENABLE_JIT define through

the Autoconf header if the feature was specifically enabled or disabled.

Source/JavaScriptCore:

  • GNUmakefile.am: Remove JSC_CPPFLAGS from the cpp flags for the JSC library.
12:16 AM Changeset in webkit [153702] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Source/WebCore: [CSS Background Blending] Specifying background-image and background-color
with opaque image doesn't trigger blending. The fix consists of adding a
check whether blend mode is set in hasOpaqueImage.

https://bugs.webkit.org/show_bug.cgi?id=119434

Patch by Mihai Tica <mitica@adobe.com> on 2013-08-05
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-separate-layer-declaration.html

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::hasOpaqueImage):

LayoutTests: [CSS Background Blending] Specifying background-image and background-color with opaque
image doesn't trigger blending. Adding ref test to validate the fix.

https://bugs.webkit.org/show_bug.cgi?id=119434i

Patch by Mihai Tica <mitica@adobe.com> on 2013-08-05
Reviewed by Dirk Schulze.

  • css3/compositing/background-blend-mode-separate-layer-declaration-expected.html: Added.
  • css3/compositing/background-blend-mode-separate-layer-declaration.html: Added.
  • css3/compositing/resources/gray_square.svg: Added.
Note: See TracTimeline for information about the timeline view.