Timeline



Jan 27, 2014:

11:52 PM Changeset in webkit [162920] by Carlos Garcia Campos
  • 26 edits in trunk

[GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
https://bugs.webkit.org/show_bug.cgi?id=127614

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Add API to set the page identifier that initiated the request to
ResourceRequest, and remove the initiatingPageID() method from the
NetworkingContext class.

  • platform/network/NetworkingContext.h:
  • platform/network/ResourceHandle.h:
  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::createSoupRequestAndMessageForHandle):

  • platform/network/soup/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::initiatingPageID):
(WebCore::ResourceRequest::setInitiatingPageID):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupRequest):
(WebCore::ResourceRequest::updateFromSoupRequest):

Source/WebKit/efl:

Remove initiatingPageID() method form the FrameNetworkingContext.

  • WebCoreSupport/FrameNetworkingContextEfl.cpp:
  • WebCoreSupport/FrameNetworkingContextEfl.h:

Source/WebKit/gtk:

Remove initiatingPageID() method from FrameNetworkingContext.

  • WebCoreSupport/FrameNetworkingContextGtk.cpp:
  • WebCoreSupport/FrameNetworkingContextGtk.h:

Source/WebKit2:

  • NetworkProcess/RemoteNetworkingContext.h: Remove

initiatingPageID() method.

  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp: Ditto.
  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:

(WebKit::CustomProtocolManagerImpl::send): Create the request with
the ResourceRequest constructor that receives a SoupRequest.

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData): Encode initiatingPageID.
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData): Decode initiatingPageID.

  • UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestCreate): Remove initiatingPageID parameter
and get it from the given ResourceRequest.

  • UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextStartLoadingCustomProtocol): Update to
webkitURISchemeRequestCreate API change.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(willSendRequestForFrame): Set the initiatingPageID to the ResourceRequest.

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
Remove initiatingPageID() method.

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
  • WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::send): Get the initiatingPageID
from the SoupRequest using the ResourceRequest API.

Tools:

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring

back the custom URI scheme WebView check.

11:43 PM Changeset in webkit [162919] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

[EFL][WK1] Remove ewk_history_item_time_last_visited_get and ewk_history_item_visit_count
https://bugs.webkit.org/show_bug.cgi?id=127662

Reviewed by Gyuyoung Kim.

These APIs are exposing WebCore's internal structure, but they removed
from WebCore since 162808.

This patch removed not to support them because applications can do it
if they want.

  • ewk/ewk_history.cpp:
  • ewk/ewk_history.h:
11:29 PM Changeset in webkit [162918] by Joseph Pecoraro
  • 11 edits in trunk/Source/JavaScriptCore

-[JSContext evaluteScript:] calls JSEvaluteScript with startingLineNumber 0, later interpreted as a oneBasedInt
https://bugs.webkit.org/show_bug.cgi?id=127648

Reviewed by Geoffrey Garen.

The actual bug being fixed here is that the line number for
scripts evaluated via the JSC APIs is now sane. However,
there is no good infrastructure in place right now to test that.

  • API/tests/testapi.c:

(main):

  • API/tests/testapi.mm:

(testObjectiveCAPI):
Add tests for exception line numbers and handling of bad
startingLineNumbers in public APIs. These tests were already
passing, I just add them to make sure they are not regressed
in the future.

  • API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

  • API/JSBase.h:
  • API/JSObjectRef.cpp:

(JSObjectMakeFunction):

  • API/JSObjectRef.h:
  • API/JSScriptRef.cpp:
  • API/JSScriptRefPrivate.h:
  • API/JSStringRef.h:
  • Clarify documentation that startingLineNumber is 1 based and clamped.
  • Add clamping in the implementation to put sane values into JSC::SourceProvider.
  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::didParseSource):
Remove the FIXME now that the SourceProvider is giving us expected values.

11:25 PM Changeset in webkit [162917] by timothy_horton@apple.com
  • 3 edits in trunk/Tools

Revert yet one more tiny part of r162629 that didn't get reverted in r162883

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::pluginLoadPolicy):

  • WebKitTestRunner/TestController.h:
11:20 PM Changeset in webkit [162916] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Revert one more tiny part of r162629 that didn't get reverted in r162883.

... which was also causing test failures!

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

11:16 PM Changeset in webkit [162915] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Lots of varied and random crashes on the scrolling thread (ScrollbarPainters are going away)
https://bugs.webkit.org/show_bug.cgi?id=127734
<rdar://problem/15906263>

Reviewed by Simon Fraser.

  • page/scrolling/ScrollingStateScrollingNode.h:

Retain the ScrollbarPainters in the scrolling state tree.

9:29 PM Changeset in webkit [162914] by mhahnenberg@apple.com
  • 211 edits
    5 adds in branches/jsCStack

Merge branch up to ToT r162909.

9:19 PM Changeset in webkit [162913] by Joseph Pecoraro
  • 4 edits in trunk/Source

Unreviewed iOS build fix. FALLTHROUGHs for iOS.

Source/WebCore:

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):

Source/WebKit/ios:

  • Misc/WebNSStringDrawing.mm:

(needsBidiLayout):

9:09 PM Changeset in webkit [162912] by roger_fong@apple.com
  • 6 edits in trunk/Source

WebGLLoadPolicy::WebGLAsk is an unnecessary value.
https://bugs.webkit.org/show_bug.cgi?id=127755

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toWebGLLoadPolicy):

  • UIProcess/API/C/WKPageLoaderClient.h:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

  • loader/FrameLoaderTypes.h:
9:03 PM Changeset in webkit [162911] by beidson@apple.com
  • 15 edits in trunk/Source

IDB: Cursor support - Messaging, IPC, Threading plumbing
https://bugs.webkit.org/show_bug.cgi?id=127736

Reviewed by Sam Weinig.

Source/WebCore:

  • Modules/indexeddb/IDBCursorBackendOperations.h:

(WebCore::CursorIterationOperation::cursorID):
(WebCore::CursorAdvanceOperation::cursorID):

  • Modules/indexeddb/IDBTransactionBackendOperations.h:

(WebCore::OpenCursorOperation::transactionID):

  • WebCore.exp.in:

Source/WebKit2:

Pipe three cursor-related calls to the DatabaseProcess, and handle messages
from the database process when it is done handling them:

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::didOpenCursor):
(WebKit::WebIDBServerConnection::didAdvanceCursor):
(WebKit::WebIDBServerConnection::didIterateCursor):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:

Pipe the calls through to the appropriate UniqueIDBDatabase:

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::openCursor):
(WebKit::DatabaseProcessIDBConnection::cursorAdvance):
(WebKit::DatabaseProcessIDBConnection::cursorIterate):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

Pass the calls to the backing store thread, then message back to the WebProcess
when the requests are complete.

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didOpenCursorInBackingStore):
(WebKit::UniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didAdvanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didIterateCursorInBackingStore):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • Shared/WebCrossThreadCopier.cpp:

(WebCore::Vector<char>>::copy):

  • Shared/WebCrossThreadCopier.h:
8:55 PM Changeset in webkit [162910] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Web Inspector: CRASH when debugger closes remote inspecting JSContext
https://bugs.webkit.org/show_bug.cgi?id=127738

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-27
Reviewed by Timothy Hatcher.

RemoteInspectorXPCConnection could be accessed in a background dispatch
queue, while being deallocated on the main thread when a connection
was suddenly terminated.

Make RemoteInspectorXPCConnection a ThreadSafeRefCounted object. Always
keep the connection object ref'd until the main thread calls close()
and removes its reference. At that point we can close the connection,
queue, and deref safely on the background queue.

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
(Inspector::RemoteInspector::xpcConnectionFailed):
For simplicity RemoteInspectorXPCConnections's don't have any threading
primatives to prevent client callbacks after they are closed. RemoteInspector
does, so it just ignores possible callbacks from connections it no longer
cares about.

  • inspector/remote/RemoteInspectorXPCConnection.h:
  • inspector/remote/RemoteInspectorXPCConnection.mm:

(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
(Inspector::RemoteInspectorXPCConnection::~RemoteInspectorXPCConnection):
(Inspector::RemoteInspectorXPCConnection::close):
Keep the connection alive as long as the queue it can be used on
is alive. Clean up everything on the queue when close() is called.

(Inspector::RemoteInspectorXPCConnection::handleEvent):
Checking if closed here is not thread safe so it is meaningless.
Remove the check.

(Inspector::RemoteInspectorXPCConnection::sendMessage):
Bail based on the m_closed state.

8:04 PM Changeset in webkit [162909] by Joseph Pecoraro
  • 4 edits in trunk/Source/WebKit2

WebKit2: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127665

Reviewed by Anders Carlsson.

  • Shared/UserData.cpp:

(WebKit::UserData::encode):
These look like they should not have fallen through!

  • Configurations/Base.xcconfig:
  • Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):

8:04 PM Changeset in webkit [162908] by Joseph Pecoraro
  • 4 edits in trunk/Source/WebKit/mac

WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127664

Reviewed by Darin Adler.

  • Configurations/Base.xcconfig:
  • History/BinaryPropertyList.cpp:

(BinaryPropertyListSerializer::appendObjectReference):
(BinaryPropertyListSerializer::startObject):
(BinaryPropertyListSerializer::addAggregateObjectReference):

  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

8:04 PM Changeset in webkit [162907] by Joseph Pecoraro
  • 45 edits in trunk/Source

WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127671

Source/WebCore:

Reviewed by Ryosuke Niwa.

  • Configurations/Base.xcconfig:

Enable the warning.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Caught a bug. CSSPropertyWebkitAlt could fall through to CSSPropertyQuotes.

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):
Caught a bug. CSSPropertyWebkitSvgShadow could fall through to CSSPropertyMaskType.

  • platform/Decimal.cpp:

(WebCore::Decimal::fromString):
Possible bug. Implementation doesn't seem to match its documentation.
Filed an issue to follow-up on this unclear function.

  • css/makeprop.pl:
  • css/makevalues.pl:
  • platform/ColorData.gperf:

Ignore implicit fallthrough warnings in generated code. gperf outputs
a "/*FALLTHROUGH*/" comment, but is not easily customizable to change
this output. Easiest to just ignore the warning for now.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
There has been a "fall through" comment immediately followed by a break
since its introduction in 2003. Removing the inaccurate comment.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase accessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase accessibilityHelpText]):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::deserialize):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::realLex):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::selectorText):

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::asText):

  • css/StyleSheetContents.cpp:

(WebCore::childRulesHaveFailedOrCanceledSubresources):

  • dom/Node.cpp:

(WebCore::appendTextContent):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

  • page/EventSource.cpp:

(WebCore::EventSource::parseEventStream):

  • platform/DateComponents.cpp:

(WebCore::DateComponents::toStringForTime):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::updateStates):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformInit):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::totalBytes):

  • platform/graphics/win/FullScreenController.cpp:

(FullScreenController::Private::fullscreenClientWndProc):

  • platform/text/BidiResolver.h:

(WebCore::Run>::updateStatusLastFromCurrentDirection):
(WebCore::Run>::createBidiRunsForLine):

  • platform/text/win/LocaleWin.cpp:

(WebCore::LocaleWin::initializeLocaleData):

  • rendering/PointerEventsHitRules.cpp:

(WebCore::PointerEventsHitRules::PointerEventsHitRules):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::newLine):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::updateLogicalWidthForAlignment):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::originalText):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::replacedContentRect):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setWordSpacing):

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::requestPaintingResource):

  • rendering/svg/SVGMarkerData.h:

(WebCore::SVGMarkerData::updateMarkerDataForPathElement):

  • svg/SVGPathParser.cpp:

(WebCore::SVGPathParser::parsePathDataFromSource):

  • svg/SVGTransformDistance.cpp:

(WebCore::SVGTransformDistance::SVGTransformDistance):
(WebCore::SVGTransformDistance::scaledDistance):
(WebCore::SVGTransformDistance::addSVGTransforms):
(WebCore::SVGTransformDistance::addToSVGTransform):
(WebCore::SVGTransformDistance::distance):
Add annotation or break before falling into a default:break;

Source/WTF:

Reviewed by Ryosuke Niwa.

  • wtf/text/WTFString.h:

(WTF::appendNumber):

8:04 PM Changeset in webkit [162906] by Joseph Pecoraro
  • 16 edits in trunk/Source/JavaScriptCore

JavaScriptCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127647

Reviewed by Anders Carlsson.

Explicitly annotate switch case fallthroughs in JavaScriptCore and
enable warnings for unannotated fallthroughs.

  • dfg/DFGArithMode.h:

(doesOverflow):
Only insert FALLTHROUGH in release builds. In debug builds, the
FALLTHROUGH would be unreachable (due to the ASSERT_NOT_REACHED)
and would through a warning.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
Due to the templatized nature of this function, a fallthrough
in one of the template expansions would be unreachable. Disable
the warning for this function.

  • Configurations/Base.xcconfig:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validateCPS):

  • parser/Lexer.cpp:

(JSC::Lexer<T>::lex):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseProperty):

  • runtime/JSArray.cpp:

(JSC::JSArray::push):

  • runtime/JSONObject.cpp:

(JSC::Walker::walk):

  • runtime/JSObject.cpp:

(JSC::JSObject::putByIndex):
(JSC::JSObject::putByIndexBeyondVectorLength):

  • runtime/JSObject.h:

(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::parse):

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
(JSC::Yarr::Parser::parseEscape):
(JSC::Yarr::Parser::parseTokens):

7:36 PM Changeset in webkit [162905] by fpizlo@apple.com
  • 2 edits
    1 add in branches/jsCStack/Source/JavaScriptCore

DFG ArrayPush implementation does strange things to the result register on the slow path
https://bugs.webkit.org/show_bug.cgi?id=127754

Reviewed by Michael Saboff.

This told the slow path machinery that there was NoResult, which then sort of worked
by accident because it would invoke a callOperation and pass the result register
(i.e. storageLengthGPR) thinking it was giving it the first argument when in reality
that callOperation would use it as the result register. The downside is that we would
probably fail to omit the result register from silent spilling, but that probably
doesn't even matter since storageLengthGPR doesn't appear as an in-use register (it's
locked, but not attached to a Node, and so it's not "in use").

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • tests/stress/array-push.js: Added.

(foo):

6:56 PM Changeset in webkit [162904] by aestes@apple.com
  • 10 edits in trunk/Source/WebKit2

[WebKit2] Add SPI to disable the WebCore memory cache
https://bugs.webkit.org/show_bug.cgi?id=127747

Reviewed by Tim Horton.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
Initialized memoryCacheDisabled to false.
(WebKit::WebProcessCreationParameters::encode):
Encoded memoryCacheDisabled.
(WebKit::WebProcessCreationParameters::decode):
Decoded memoryCacheDisabled.

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetMemoryCacheDisabled):
Called WebContext::setMemoryCacheDisabled().

  • UIProcess/API/C/WKContextPrivate.h: Declared new SPI.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialized m_memoryCacheDisabled to false.
(WebKit::WebContext::createNewWebProcess):
Set WebProcessCreationParameters::memoryCacheDisabled to m_memoryCacheDisabled.
(WebKit::WebContext::setMemoryCacheDisabled): Set m_memoryCacheDisabled
and sent new value to all existing processes.

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Called WebProcess::setMemoryCacheDisabled().
(WebKit::WebProcess::setMemoryCacheDisabled):
Called MemoryCache::setDisabled() if the disabled state changed.

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
6:50 PM Changeset in webkit [162903] by fpizlo@apple.com
  • 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog

Mark appropriate things as reviewed

6:31 PM Changeset in webkit [162902] by fpizlo@apple.com
  • 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog

Mark appropriate things as reviewed

6:12 PM Changeset in webkit [162901] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-537.75.1

New Tag

6:12 PM Changeset in webkit [162900] by msaboff@apple.com
  • 1 edit in branches/jsCStack/Source/WebKit/mac/postprocess-headers.sh

Set exectueable property to match trunk.

6:04 PM Changeset in webkit [162899] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add -[WKWebView loadRequest:] API
https://bugs.webkit.org/show_bug.cgi?id=127727

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView loadRequest:]):

6:02 PM Changeset in webkit [162898] by dfarler@apple.com
  • 3 edits in trunk/Tools

iOS DumpRenderTree.app dies loading fonts
https://bugs.webkit.org/show_bug.cgi?id=127730

Reviewed by Daniel Bates.

  • DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
  • Add Ahem to the DATA section
  • DumpRenderTree/mac/DumpRenderTree.mm:

(activateFontsIOS):

  • Load "WeightWatcher100" instead.
5:59 PM Changeset in webkit [162897] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Allow mmap encoded data replacement for WOFF fonts.
<https://webkit.org/b/127737>

We always have to convert WOFF fonts to SFNT format. This happens
in a separate buffer from the CachedFont's internal resource buffer.
Because of this, there's no need to protect the original buffer from
mmap replacement.

With this change, WOFF web fonts are no longer duplicated between
the network and web processes.

Reviewed by Brady Eidson.

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::mayTryReplaceEncodedData):

  • loader/cache/CachedFont.h:
5:56 PM Changeset in webkit [162896] by BJ Burg
  • 7 edits in trunk/LayoutTests

Web Inspector: clean up initialization of managers and observers in InspectorTest
https://bugs.webkit.org/show_bug.cgi?id=127707

Reviewed by Timothy Hatcher.

The test harness was setting up managers and observers before
telling the frontend host that the page loaded. The InspectorObserver
was also not being initialized.

For clarity, rename importInspectorScripts to initializeInspectorModels.
For easier debugging, make model test assertions use InspectorTest.log.

  • http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.initializeInspectorModels.console.error.window.onerror):
(InspectorTest.initializeInspectorModels.console.assert):
(InspectorTest.initializeInspectorModels):

  • inspector-protocol/model/content-flow-content-nodes.html:
  • inspector-protocol/model/content-flow-content-removal.html:
  • inspector-protocol/model/content-flow-list.html:
  • inspector-protocol/model/content-node-region-info.html:
  • inspector-protocol/model/main-frame-resource.html:
5:50 PM Changeset in webkit [162895] by ap@apple.com
  • 2 edits in trunk/Tools

[Mac] Extra logging output from run-safari --no-saved-state
https://bugs.webkit.org/show_bug.cgi?id=127732

Reviewed by Daniel Bates.

  • Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that

disables saved state without logging.

5:45 PM Changeset in webkit [162894] by mhahnenberg@apple.com
  • 969 edits
    17 adds
    4 deletes in branches/jsCStack

Getting all layout tests passing on the branch.

5:35 PM Changeset in webkit [162893] by fpizlo@apple.com
  • 2 edits in branches/jsCStack/Source/JavaScriptCore

Structure::dump() should say things about specific values
https://bugs.webkit.org/show_bug.cgi?id=127741

Not yet reviewed.

  • runtime/Structure.cpp:

(JSC::Structure::dump):

5:26 PM Changeset in webkit [162892] by hyatt@apple.com
  • 13 edits
    4 adds in trunk

[New Multicolumn] Add support for block progression axis and reverse direction
https://bugs.webkit.org/show_bug.cgi?id=127715

Reviewed by thorton.

This patch adds support for -webkit-progression-direction and -webkit-progression-axis
to the new column code. This allows columns to stack along the block axis instead of
the inline axis or to reverse directions along that progression axis.

Added fast/multicol/newmulticol/progression-reverse.html and

fast/multicol/newmulticol/progression-reverse-overflow.html

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isTopLayoutOverflowAllowed):
(WebCore::RenderBlock::isLeftLayoutOverflowAllowed):
New functions have been added for top and left layout overflow in order to get
a bunch of code out of RenderBox that didn't belong there. RenderBlock is overriding
the functions for the old multicolumn layout code to keep it working.

  • rendering/RenderBlock.h:

Added the new top/left overflow functions.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::determineLogicalLeftPositionForChild):
Moved from RenderBlock, since it didn't belong there.

(WebCore::RenderBlockFlow::isTopLayoutOverflowAllowed):
(WebCore::RenderBlockFlow::isLeftLayoutOverflowAllowed):

  • rendering/RenderBlockFlow.h:

Overridden for the new multi-column code to specify when top/left overflow are
allowed (e.g., when the columns go backwards).

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addLayoutOverflow):
Overridden to use the new top/left overflow functions.

  • rendering/RenderBox.h:

(WebCore::RenderBox::isTopLayoutOverflowAllowed):
(WebCore::RenderBox::isLeftLayoutOverflowAllowed):
Added base definitions that look at direction and writing-mode.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::isTopLayoutOverflowAllowed):
(WebCore::RenderFlexibleBox::isLeftLayoutOverflowAllowed):

  • rendering/RenderFlexibleBox.h:

Overrides for flexible box of the top/left overflow functions.

  • rendering/RenderMultiColumnFlowThread.h:

Make sure requiresBalancing() is set to false if the axis of the columns
is block, since at least right now, we don't support balancing columns
along the block axis. (In theory we could support this in the future, but
nobody has requested it.)

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::updateLogicalWidth):
Remove the code that expands the width of multi column sets. We now always
let their logical width match the containing block's content width and instead
add the overflow to the set itself.

(WebCore::RenderMultiColumnSet::columnRectAt):
(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
(WebCore::RenderMultiColumnSet::paintColumnRules):
(WebCore::RenderMultiColumnSet::initialBlockOffsetForPainting):
(WebCore::RenderMultiColumnSet::collectLayerFragments):
(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):
Patch all of these functions to know how to handle a block axis or reversed
direction.

(WebCore::RenderMultiColumnSet::addOverflowFromChildren):

  • rendering/RenderMultiColumnSet.h:

Make multi-column set add in its overflow in the same way that the old
multi-column code did, by looking at the last column rect. (This is really
not a very good way to do it, but it's the same as the old code for now.)

LayoutTests:

  • fast/multicol/newmulticol/progression-reverse-expected.html: Added.
  • fast/multicol/newmulticol/progression-reverse-overflow-expected.html: Added.
  • fast/multicol/newmulticol/progression-reverse-overflow.html: Added.
  • fast/multicol/newmulticol/progression-reverse.html: Added.
5:17 PM Changeset in webkit [162891] by beidson@apple.com
  • 9 edits in trunk/Source/WebKit2

IDB: Rename "IDBTransactionIdentifier" to be more general purpose (take 2)
https://bugs.webkit.org/show_bug.cgi?id=127717

Reviewed by Tim Horton.

Update all related variable names since the type no longer contains the relevant info.

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:
  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
  • Shared/WebCrossThreadCopier.cpp:
5:12 PM Changeset in webkit [162890] by jinwoo7.song@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Add test expectations for failing tests.

  • platform/efl/TestExpectations:
5:01 PM Changeset in webkit [162889] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the Mac build following <http://trac.webkit.org/changeset/162887>
(https://bugs.webkit.org/show_bug.cgi?id=127703)

Export symbol for WebCore::AXObjectCache::enableAccessibility().

  • WebCore.exp.in:
4:49 PM Changeset in webkit [162888] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Unreviewed build fix. Add missing export symbol.

  • WebCore.exp.in:
4:31 PM Changeset in webkit [162887] by roger_fong@apple.com
  • 5 edits in trunk/Source

[Windows] Tests crashing on Windows after r162816.
https://bugs.webkit.org/show_bug.cgi?id=127703.

Reviewed by Alexey Proskuryakov.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::enableAccessibility):
(WebCore::AXObjectCache::disableAccessibility):

  • accessibility/AXObjectCache.h: Un-inline some methods so that they can be exported.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Remove variable export in favor of function export.
4:24 PM Changeset in webkit [162886] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Copy relevant code from the iOS version of WKView to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=127721

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView setFrame:]):
(-[WKWebView setBounds:]):
(-[WKWebView scrollView]):
(-[WKWebView browsingContextController]):
(-[WKWebView contentView:contentsSizeDidChange:]):
(-[WKWebView contentViewDidCommitLoadForMainFrame:]):
(-[WKWebView contentViewDidReceiveMobileDocType:]):
(-[WKWebView contentView:didChangeViewportArgumentsSize:initialScale:minimumScale:maximumScale:allowsUserScaling:]):
(-[WKWebView viewportHandlerDidChangeScales:]):
(-[WKWebView viewportHandler:didChangeViewportSize:]):
(-[WKWebView viewForZoomingInScrollView:]):
(-[WKWebView scrollViewWillBeginZooming:withView:]):
(-[WKWebView _didFinishScroll]):
(-[WKWebView scrollViewDidEndDragging:willDecelerate:]):
(-[WKWebView scrollViewDidEndDecelerating:]):
(-[WKWebView scrollViewDidScrollToTop:]):
(-[WKWebView scrollViewDidScroll:]):
(-[WKWebView scrollViewDidEndZooming:withView:atScale:]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _setDocumentScale:]):

4:20 PM Changeset in webkit [162885] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

Update bindings test expectations after r162872

  • bindings/scripts/test/ObjC/DOMTestInterface.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
4:18 PM Changeset in webkit [162884] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening, unskip now passing webgl tests on EFL port.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
4:07 PM Changeset in webkit [162883] by timothy_horton@apple.com
  • 12 edits in trunk

Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.

We're leaving the parts that make us use PDFPlugin instead of showing the blocked
plugin indicator intact, though.

  • UIProcess/API/APILoaderClient.h:

(API::LoaderClient::pluginLoadPolicy):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):

  • UIProcess/API/C/WKPageLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::handleContextMenuEvent):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

4:04 PM Changeset in webkit [162882] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add a WKContentView initializer that takes a WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=127718

Reviewed by Tim Horton.

This initializer will be used by WKWebView.

  • UIProcess/API/ios/WKContentView.h:
  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):

4:01 PM Changeset in webkit [162881] by aestes@apple.com
  • 18 edits in trunk

Scrub WebKit API headers of WTF macros
https://bugs.webkit.org/show_bug.cgi?id=127706

Reviewed by David Kilzer.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
  • bindings/objc/DOMEvents.h: Guarded include of

DOM{Gesture,Touch}Event.h with TARGET_OS_IPHONE, since those features
are always enabled on iOS.

  • platform/graphics/mac/MediaPlayerProxy.h: Replaced PLATFORM(IOS) with

TARGET_OS_IPHONE and ensured ENABLE_IOS_AIRPLAY is defined.

  • platform/ios/SystemMemory.h: Replaced PLATFORM(IOS) with

TARGET_OS_IPHONE.

  • platform/ios/wak/WKGraphics.h: Replaced PLATFORM(IOS_SIMULATOR) with

TARGET_IPHONE_SIMULATOR.

Source/WebKit/ios:

  • WebCoreSupport/WebMIMETypeRegistry.h: Changed PLATFORM(IOS) to

TARGET_OS_IPHONE.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.
  • WebView/WebPreferenceKeysPrivate.h: Changed ENABLE(REMOTE_INSPECTOR)
to !defined(ENABLE_REMOTE_INSPECTOR)
ENABLE_REMOTE_INSPECTOR. We are

in a TARGET_OS_IPHONE block, and ENABLE_REMOTE_INSPECTOR is enabled by
default on iOS, so include this block unless the feature is explicitly
disabled.

  • postprocess-headers.sh: Stopped processing ENABLE_IOS_TOUCH_EVENTS

and ENABLE_IOS_GESTURE_EVENTS. These are now defined in DOMEvents.h.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_INSPECTOR.

Tools:

  • Scripts/check-for-inappropriate-macros-in-external-headers: Modified

the regex to require a '(' after the macro name in order to be
considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
from being flagged as an ENABLE() macro.

3:56 PM Changeset in webkit [162880] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Crashes in RemoteScrollingCoordinatorProxy::rootScrollingNodeID

Reviewed by Simon Fraser.

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::rootScrollingNodeID):
Null-check the root scrolling node, in case something scrolls before
we've made the first remote layer/scrolling tree commit.

3:51 PM Changeset in webkit [162879] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] Use callOnMainThread() not dispatch_async() in MediaPlayerPrivateAVFoundationObjC
https://bugs.webkit.org/show_bug.cgi?id=127701

Reviewed by Eric Carlson.

dispatch_async(dispatch_get_main_queue(), ...) used to be fine so long as the main
thread was also the web thread. But since that's not the case on iOS, we should be
using callOnMainThread() instead (because it dispatches to the web thread, not as
its name implies, the main thread).

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createWeakPtr):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime):
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
(-[WebCoreAVFMovieObserver outputSequenceWasFlushed:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForResponseToAuthenticationChallenge:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):

3:50 PM Changeset in webkit [162878] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

Move Conditional=BLOB from URL interface to Blob-related methods, to prepare for adding URL API
https://bugs.webkit.org/show_bug.cgi?id=127719

Reviewed by Sam Weinig.

  • html/DOMURL.idl:
3:48 PM Changeset in webkit [162877] by beidson@apple.com
  • 12 edits
    1 move in trunk/Source/WebKit2

IDB: Rename "IDBTransactionIdentifier" to be more general purpose
https://bugs.webkit.org/show_bug.cgi?id=127717

Reviewed by Tim Horton.

Global rename of IDBTransactionIdentifier to IDBIdentifier.

  • DatabaseProcess/IndexedDB/IDBIdentifier.h: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/IDBTransactionIdentifier.h.
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:
  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
  • Shared/WebCrossThreadCopier.cpp:
  • Shared/WebCrossThreadCopier.h:
  • WebKit2.xcodeproj/project.pbxproj:
3:39 PM Changeset in webkit [162876] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Move underlying C++ objects to class extensions
https://bugs.webkit.org/show_bug.cgi?id=127716

Reviewed by Tim Horton.

This allows us to get at the internals without calling any Obj-C methods.

  • UIProcess/API/Cocoa/WKProcessClass.mm:
  • UIProcess/API/Cocoa/WKProcessClassInternal.h:
  • UIProcess/API/ios/WKContentView.mm:
  • UIProcess/API/ios/WKContentViewInternal.h:
3:29 PM Changeset in webkit [162875] by akling@apple.com
  • 6 edits
    2 deletes in trunk/Source/WebCore

Remove unused USE(OPENTYPE_SANITIZER) code.
<https://webkit.org/b/127710>

This code was only used by the Chromium port.

Reviewed by Darin Adler.

  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::ensureCustomFontData):

  • platform/graphics/WOFFFileFormat.cpp:
  • platform/graphics/WOFFFileFormat.h:
  • platform/graphics/opentype/OpenTypeSanitizer.cpp: Removed.
  • platform/graphics/opentype/OpenTypeSanitizer.h: Removed.
3:25 PM Changeset in webkit [162874] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebInspectorUI

Web Inspector: Feature Check all Protocol Generated Interfaces to get JSContext Inspection working
https://bugs.webkit.org/show_bug.cgi?id=127712

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-27
Reviewed by Timothy Hatcher.

Feature check protocol generated interfaces (e.g. FooAgent and registerFooObserver).
Also drive by handle a possible exception if a SourceCode's URL is null, which is possible.

  • UserInterface/ApplicationCacheManager.js:

(WebInspector.ApplicationCacheManager):
(WebInspector.ApplicationCacheManager.prototype.initialize):

  • UserInterface/CSSCompletions.js:

(WebInspector.CSSCompletions.requestCSSNameCompletions):

  • UserInterface/CSSStyleManager.js:

(WebInspector.CSSStyleManager):
(WebInspector.CSSStyleManager.prototype.canForcePseudoClasses):

  • UserInterface/DebuggerManager.js:
  • UserInterface/FrameResourceManager.js:

(WebInspector.FrameResourceManager):
(WebInspector.FrameResourceManager.prototype.initialize):

  • UserInterface/Main.js:

(WebInspector.loaded):

  • UserInterface/ProfileManager.js:

(WebInspector.ProfileManager):

  • UserInterface/StorageManager.js:

(WebInspector.StorageManager):
Type check generated interfaces.

(WebInspector.DebuggerManager):
(WebInspector.DebuggerManager.prototype.debuggerDidPause):
Null check a SourceCode URL, which can be null for a Script with no URL.

3:22 PM Changeset in webkit [162873] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Implement the _injectedBundleURL property
https://bugs.webkit.org/show_bug.cgi?id=127714

Reviewed by Tim Horton.

Properties declared in class categories need to be implemented. Do this
for the _injectedBundleURL property.

  • UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:

(-[WKProcessClassConfiguration _injectedBundleURL]):
(-[WKProcessClassConfiguration _setInjectedBundleURL:]):

3:15 PM Changeset in webkit [162872] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Stop the code generator from adding ENABLE() macros to Objective-C DOM headers
https://bugs.webkit.org/show_bug.cgi?id=127706

Reviewed by David Kilzer.

Instead of adding ENABLE() macros to generated Objective-C DOM
headers, which might become Public or Private headers, elide generated
code for disabled features.

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateInterface): Passed $defines to GenerateHeader.
(ConditionalIsEnabled): Checked if the given conditional is found in
$defines. Handled conditionals with '&' and '|'.
(GenerateHeader): Rather than calling GenerateConditionalString to
generate an "#if ENABLE(...)", called ConditionalIsEnabled() to see
whether we should generate code for the given constant, attribute, or
function.

3:03 PM Changeset in webkit [162871] by zoltan@webkit.org
  • 5 edits in trunk

[CSS Shapes] Remove restriction of negative values for inset parameters
https://bugs.webkit.org/show_bug.cgi?id=127704

Reviewed by Darin Adler.

Source/WebCore:

The latest version of CSS Shapes (http://www.w3.org/TR/css-shapes/) specification
doesn't contain any restriction of using negative values for the inset sizing.
I removed the restriction from the code and added testing for them.

Existing tests have been extended with the new cases.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseBasicShapeInset):

LayoutTests:

  • fast/shapes/parsing/parsing-shape-lengths-expected.txt:
  • fast/shapes/parsing/parsing-shape-lengths.html:
2:47 PM Changeset in webkit [162870] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] preload=none prevents play()
https://bugs.webkit.org/show_bug.cgi?id=127702

Reviewed by Jer Noble.

No new tests, covered by existing tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::potentiallyPlaying): Cleanup logic to make it simpler to understand,

fix logic error introduced in r161973

(WebCore::HTMLMediaElement::updatePlayState): Conditionalize some iOS-only code on whether or not

we are using the plug-in proxy.

2:38 PM Changeset in webkit [162869] by beidson@apple.com
  • 9 edits in trunk/Source

IDB: LevelDB backing store shouldn't know about IDBCursor or IDBCallbacks
https://bugs.webkit.org/show_bug.cgi?id=127708

Reviewed by Tim Horton.

Source/WebCore:

Move that knowledge to the IDBCursorBackendOperations inside the callback.

  • Modules/indexeddb/IDBCursorBackendOperations.cpp:

(WebCore::CursorAdvanceOperation::perform):
(WebCore::CursorIterationOperation::perform):

  • Modules/indexeddb/IDBCursorBackendOperations.h:
  • Modules/indexeddb/IDBServerConnection.h:
  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::cursorAdvance):
(WebCore::IDBServerConnectionLevelDB::cursorIterate):

  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

Source/WebKit2:

Update to new callback signatures:

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
2:37 PM Changeset in webkit [162868] by fpizlo@apple.com
  • 2 edits in branches/jsCStack/Source/JavaScriptCore

FTL ArithMod case needs to be factored for hackability and correctness rather than just minimizing the amount of code
https://bugs.webkit.org/show_bug.cgi?id=127709

Rubber stamped by Mark Hahnenberg.

Roll out part of r156784. 60% progression on Kraken/audio-oscillator.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):

2:20 PM Changeset in webkit [162867] by mhahnenberg@apple.com
  • 8 edits
    2 adds
    1 delete in branches/jsCStack

Added missing files to the branch.

1:52 PM Changeset in webkit [162866] by fpizlo@apple.com
  • 3 edits
    6 adds in branches/jsCStack/Source/JavaScriptCore

FTL should support NewArrayWithSize
https://bugs.webkit.org/show_bug.cgi?id=127698

Reviewed by Mark Hahnenberg.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayWithSize):

  • tests/stress/new-array-storage-array-with-size.js: Added.

(foo):
(test):

  • tests/stress/new-array-with-size-with-bad-time.js: Added.

(foo):

  • tests/stress/new-contiguous-array-with-size.js: Added.

(foo):
(test):

  • tests/stress/new-double-array-with-size.js: Added.

(foo):
(test):

  • tests/stress/new-int32-array-with-size.js: Added.

(foo):
(test):

  • tests/stress/new-undecided-array-with-size.js: Added.

(foo):
(test):

1:45 PM Changeset in webkit [162865] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Tweak the WKWebView and WKWebViewConfiguration headers
https://bugs.webkit.org/show_bug.cgi?id=127705

Reviewed by Dan Bernstein.

Add WK_API_CLASS to WKWebView and make WKWebView.h and WKWebViewConfiguration.h public.

  • UIProcess/API/Cocoa/WKWebView.h:
  • WebKit2.xcodeproj/project.pbxproj:
1:29 PM Changeset in webkit [162864] by beidson@apple.com
  • 11 edits in trunk/Source

IDB: Remove unused concept of "cursor prefetch"
https://bugs.webkit.org/show_bug.cgi?id=127700

Reviewed by Tim Horton.

Source/WebCore:

  • Modules/indexeddb/IDBCursorBackend.cpp:
  • Modules/indexeddb/IDBCursorBackend.h:
  • Modules/indexeddb/IDBCursorBackendOperations.cpp:
  • Modules/indexeddb/IDBCursorBackendOperations.h:
  • Modules/indexeddb/IDBServerConnection.h:
  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
1:24 PM Changeset in webkit [162863] by Brent Fulgham
  • 3 edits
    3 adds
    3 deletes in branches/safari-537.75-branch/Source

Merge r162723.

2014-01-24 Brent Fulgham <Brent Fulgham>

[Win] Convert some NMake files to MSBuild project files
https://bugs.webkit.org/show_bug.cgi?id=127579

Reviewed by Tim Horton.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.vcxproj/WebCore.make: Removed.
  • WebCore.vcxproj/WebCore.proj: Added.

Source/WTF:

  • WTF.vcxproj/WTF.make: Removed.
  • WTF.vcxproj/WTF.proj: Added.
1:16 PM Changeset in webkit [162862] by jer.noble@apple.com
  • 2 edits in trunk/Source/WTF

[WK2] callOnMainThread() from main thread sometimes results in ASSERTs.
https://bugs.webkit.org/show_bug.cgi?id=127370

Reviewed by Alexey Proskuryakov.

When WEB_THREAD is enabled, and callOnMainThread() is called from the main
thread, if the web thread is locked, a timer is set and the passed-in function
is called on the next run-loop. However, by that time the web thread may have
been unlocked, and isMainThread() will no longer return true, resulting in
an assert.

Instead, scheduleDispatchFunctionsOnMainThread() should check isWebThread(),
which is equivalent to isMainThread() when the WEB_THREAD is disabled, but
will do the correct thing when WEB_THREAD is enabled.

  • wtf/mac/MainThreadMac.mm:

(WTF::scheduleDispatchFunctionsOnMainThread):

1:03 PM Changeset in webkit [162861] by msaboff@apple.com
  • 2 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: [X86-32] testapi crashes in gatherConservativeRoots()
https://bugs.webkit.org/show_bug.cgi?id=127699

Reviewed by Mark Hahnenberg.

sanitizeStackForVMImpl was using "t4" (edi) which is a callee save register, which
trashed its prior contents. Change to use t2 (ecx) on X86 which is a scratch register.

  • llint/LowLevelInterpreter.asm:
1:00 PM Changeset in webkit [162860] by Brent Fulgham
  • 2 edits in branches/safari-537.75-branch/Source/WebCore

Unreviewed build fix after r162631.

  • WebCore.vcxproj/WebCore.submit.sln: Do not build QTMovieWin for 64-bit architecture.
12:53 PM Changeset in webkit [162859] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build on case-sensitive filesystems

  • WebProcess/WebPage/ViewGestureGeometryCollector.h:
12:52 PM Changeset in webkit [162858] by Antti Koivisto
  • 2 edits in trunk/LayoutTests

REGRESSION(r162837): fast/writing-mode/ruby-text-logical-left.html fails on WK1

12:51 PM Changeset in webkit [162857] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

Build fix.

  • wtf/ThreadSafeRefCounted.h: Added a necessary #include.
12:48 PM UsingGitHub edited by Ricky de Laveaga
typo you/your (diff)
12:34 PM Changeset in webkit [162856] by beidson@apple.com
  • 9 edits in trunk/Source

IDB: Refactor out the last of the operation callbacks that are called by the LevelDB backing store
https://bugs.webkit.org/show_bug.cgi?id=127592

Reviewed by Tim Horton.

Source/WebCore:

For each of the 3 remaining operations where the backing store calls callbacks directly,
factor out the callbacks to the operation itself.

  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):

  • Modules/indexeddb/IDBTransactionBackendOperations.h:
  • Modules/indexeddb/IDBServerConnection.h:
  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::openCursor):
(WebCore::IDBServerConnectionLevelDB::count):
(WebCore::IDBServerConnectionLevelDB::deleteRange):

  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

Source/WebKit2:

Update the WebIDBServerConnection to the new callback signatures:

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::count):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
12:31 PM Changeset in webkit [162855] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r162755.
http://trac.webkit.org/changeset/162755
https://bugs.webkit.org/show_bug.cgi?id=127696

not quite right, breaks subframe scrolling in some cases
(Requested by thorton on #webkit).

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::removeDestroyedNodes):

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):

12:28 PM Changeset in webkit [162854] by mhahnenberg@apple.com
  • 776 edits
    162 adds
    1 delete in branches/jsCStack

Source/JavaScriptCore: Merge branch up to ToT r162844.

12:21 PM Changeset in webkit [162853] by timothy_horton@apple.com
  • 23 edits in trunk/Source/WebKit2

WebKit2 View Gestures: Fluid back-forward swipe
https://bugs.webkit.org/show_bug.cgi?id=127363

Reviewed by Anders Carlsson.

Add support for a "back-forward swipe", which allows fluid swiping between
items in the back-forward list. Currently disabled by default.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetViewGestureDebuggingEnabled):
(WKPreferencesGetViewGestureDebuggingEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:

Add a ViewGestureDebuggingEnabled preference, which currently causes snapshots to be blurred.
Additional view gesture debugging features could come in the future.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _ensureGestureController]):
(-[WKView scrollWheel:]):
If back-forward navigation gestures are enabled, intercept scrollWheel events
on the WKView and let the ViewGestureController take the first crack at them.

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):

  • UIProcess/API/mac/WKViewInternal.h:

Add allowsBackForwardNavigationGesture property, which enables the gesture.

  • UIProcess/mac/ViewGestureController.h:

Add swipe-related methods, which will be described below.

Add an enum for the swipe transition style. Currently only Overlap is accessible,
but in the future one could see having API to choose the style.
'Overlap' has the outgoing page swipe out to the right (when swiping right)
or the incoming page swipe in from the right (when swiping left).
'Push' has the pages push each other along in sync, as if all the pages in the
back-forward list were oriented from left to right.

  • UIProcess/mac/ViewGestureController.messages.in:
  • UIProcess/mac/ViewGestureController.mm: Renamed from Source/WebKit2/UIProcess/mac/ViewGestureController.cpp.

Use some CAFilter SPI to blur the snapshot if ViewGestureDebuggingEnabled is on.

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::~ViewGestureController):
(WebKit::ViewGestureController::endMagnificationGesture):
Move m_activeGestureType clearing to each end* function instead of one global place,
so that each gesture can handle when it ends separately.

(WebKit::ViewGestureController::handleScrollWheelEvent):
If we receive a scroll wheel event which is appropriate for starting a
fluid swipe, in a direction where the main frame is pinned to the appropriate
edge of the view, start tracking a swipe.

This should eventually have some hysterisis to avoid stealing scrolls that
venture into the wrong direction, but for now it starts tracking immediately.

Forward events from the tracking loop to {begin, handle, end}SwipeGesture.

(WebKit::ViewGestureController::beginSwipeGesture):
Create a layer with the destination page's snapshot, and set it up.

(WebKit::ViewGestureController::handleSwipeGesture):
Appropriately adjust the position of the root layer and snapshot layer,
given the transition style and swipe direction.

(WebKit::ViewGestureController::endSwipeGesture):
When the gesture ends, do the navigation, and tell the WebProcess to
inform us when the render tree hits half the size it was when the
snapshot was taken (when that happens, we will remove the snapshot
and the gesture will be truly complete). Also, start a watchdog timer
in case the render tree never hits that size, after which we will
also remove the snapshot.

(WebKit::ViewGestureController::didHitRenderTreeSizeThreshold):
(WebKit::ViewGestureController::swipeSnapshotWatchdogTimerFired):
(WebKit::ViewGestureController::removeSwipeSnapshot):
Tear down the swipe snapshot layer, and mark our current gesture as complete.

(WebKit::ViewGestureController::endActiveGesture):
Simplify endActiveGesture; it only has work to do for a pinch-zoom gesture,
as those are the only gestures where the user is directly in control of when they end.

  • WebProcess/WebPage/ViewGestureGeometryCollector.cpp:

(WebKit::ViewGestureGeometryCollector::ViewGestureGeometryCollector):
(WebKit::ViewGestureGeometryCollector::mainFrameDidLayout):
(WebKit::ViewGestureGeometryCollector::renderTreeSizeNotificationTimerFired):

  • WebProcess/WebPage/ViewGestureGeometryCollector.h:

(WebKit::ViewGestureGeometryCollector::setRenderTreeSizeNotificationThreshold):

  • WebProcess/WebPage/ViewGestureGeometryCollector.messages.in:

ViewGestureController pushes a render-tree size threshold to the WebProcess;
ViewGestureGeometryCollector (whose name is now more unfortunate than before)
monitors render-tree size changes and informs ViewGestureController when
it reaches that threshold via the 'DidHitRenderTreeSizeThreshold' message.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/ios/PageClientImplIOS.h:
  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::acceleratedCompositingRootLayer):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::acceleratedCompositingRootLayer):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _acceleratedCompositingModeRootLayer]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::acceleratedCompositingRootLayer):
Add a getter for the accelerated compositing root layer.

  • UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::snapshotAndRenderTreeSize):
Don't extract the CGImageRef from a RetainPtr just to put it back in one.

12:04 PM Changeset in webkit [162852] by Brent Fulgham
  • 7 edits in branches/safari-537.75-branch/Source/JavaScriptCore

Merge r154513, r154354.

2013-08-23 Alex Christensen <alex.christensen@flexsim.com>

Re-separating Win32 and Win64 builds.
https://bugs.webkit.org/show_bug.cgi?id=120178

Reviewed by Brent Fulgham.

Pass PlatformArchitecture as a command line parameter to bash scripts.

for build conditions.

11:54 AM Changeset in webkit [162851] by Brent Fulgham
  • 4 edits in branches/safari-537.75-branch/Source/WTF

Merge r162850

2014-01-27 Brent Fulgham <Brent Fulgham>

[Win] Unreviewed build correction.

  • WTF.vcxproj/WTFGeneratedCommon.props: Export PLATFORMARCHITECTURE macro for use in Makefiles and shell scripts.
  • WTF.vcxproj/build-generated-files.sh: Output header search path to identify when the build is confused about build architecture.
11:49 AM Changeset in webkit [162850] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r162846.
http://trac.webkit.org/changeset/162846
https://bugs.webkit.org/show_bug.cgi?id=127695

"Broke the WebKit Bot Watcher's Dashboard; will fix offline"
(Requested by dydz on #webkit).

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.update.):

11:42 AM Changeset in webkit [162849] by fpizlo@apple.com
  • 4 edits
    1 add in branches/jsCStack/Source/JavaScriptCore

FTL should do polyvariant PutById inlining
https://bugs.webkit.org/show_bug.cgi?id=127692

Reviewed by Mark Hahnenberg.

Expanded the existign GetById polyvariance support to include PutByIds as well.

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::hasExitSite):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):

  • bytecode/PutByIdStatus.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • tests/stress/simple-polyvariant-put-by-id-inlining-example.js: Added.

(foo):
(fuzz):
(bar):

11:15 AM Changeset in webkit [162848] by zoltan@webkit.org
  • 6 edits in trunk

[CSS Shapes] inset() function with multiple spaces on element style
https://bugs.webkit.org/show_bug.cgi?id=127617

Reviewed by Dirk Schulze.

Source/WebCore:

When only a subset of parameters were defined for an inset shape, the built
inset string contained some extra spaces. This patch fixes the behavior and
adds tests for the case. I also removed the string allocation optimization from
buildInsetString, since it's not worthwhile to always allocate as many memory
as needed for a fully defined inset.

I added the new test cases to the shapes parser code test.

  • css/CSSBasicShapes.cpp:

(WebCore::buildInsetString):

LayoutTests:

  • fast/shapes/parsing/parsing-shape-inside-expected.txt:
  • fast/shapes/parsing/parsing-shape-outside-expected.txt:
  • fast/shapes/parsing/parsing-test-utils.js:
11:08 AM Changeset in webkit [162847] by dbates@webkit.org
  • 3 edits in trunk/Tools

Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
https://bugs.webkit.org/show_bug.cgi?id=127564

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
11:06 AM Changeset in webkit [162846] by dbates@webkit.org
  • 2 edits in trunk/Tools

Teach Buildbot dashboard to parse alternative revision format
https://bugs.webkit.org/show_bug.cgi?id=127561

Reviewed by Alexey Proskuryakov.

Add support for extracting the OpenSource and Internal revision numbers when Buildbot
returns a dictionary for the value of property got_revision.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
string or a dictionary.
(BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
the OpenSource and Internal revision numbers.

10:53 AM Changeset in webkit [162845] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove unused CodeBlock::createActivation().
<https://webkit.org/b/127686>

Reviewed by Filip Pizlo.

  • bytecode/CodeBlock.cpp:
  • bytecode/CodeBlock.h:
9:48 AM Changeset in webkit [162844] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore
  • WebCore.exp.in: Add export needed for iOS.
9:12 AM Changeset in webkit [162843] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION(r133214): Don't invalidate style when adding classes that don't match rules
https://bugs.webkit.org/show_bug.cgi?id=126177

Reviewed by Anders Carlsson.

Spotted by Elliott Sprehn in Chromium.

  • dom/Element.cpp:

(WebCore::checkSelectorForClassChange):

Remove unnecessary templating.

(WebCore::Element::classAttributeChanged):

Fix logic error with 'continue'.

8:57 AM Changeset in webkit [162842] by b.long@cablelabs.com
  • 2 edits in trunk/Source/WebCore

[GStreamer] Lockup when playing Icecast radio
https://bugs.webkit.org/show_bug.cgi?id=127452

Reviewed by Philippe Normand.

No new tests. This bug can only be demonstrated with an Icecast stream, and it's
not clear how to do that in our testing framework.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::handleResponseReceived): Wait until we unlock to send notifications.

8:49 AM Changeset in webkit [162841] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Typo fix after r162838.

  • platform/wk2/TestExpectations:
8:31 AM Changeset in webkit [162840] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r162838.

  • page/FrameView.cpp:

Remove an unused constant.

8:27 AM Changeset in webkit [162839] by hyatt@apple.com
  • 9 edits in trunk/Source/WebCore

Remove repaint throttling
https://bugs.webkit.org/show_bug.cgi?id=127681

Patch by Antti Koivisto <Antti Koivisto> on 2014-01-27
Reviewed by Sam Weinig.

Nowadays we throttle layer flushes. This code is unnecessary.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • dom/Element.cpp:

(WebCore::Element::classAttributeChanged):

  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::insertDictatedText):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkCompleted):

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::layout):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

  • page/FrameView.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection):

8:18 AM Changeset in webkit [162838] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, unskip now passing tests.

  • platform/wk2/TestExpectations:
7:11 AM Changeset in webkit [162837] by Antti Koivisto
  • 12 edits in trunk/Source

Remove repaint throttling
https://bugs.webkit.org/show_bug.cgi?id=127681

Reviewed by Sam Weinig.

Nowadays we throttle layer flushes. This code is unnecessary.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • dom/Element.cpp:

(WebCore::Element::classAttributeChanged):

  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::insertDictatedText):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkCompleted):

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::layout):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

  • page/FrameView.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection):

7:05 AM Changeset in webkit [162836] by eric.carlson@apple.com
  • 8 edits in trunk/Source/WebCore

Merge Chromium TextTrack cleanups
https://bugs.webkit.org/show_bug.cgi?id=127483

Reviewed by Darin Adler.

Merge some TextTrack cleanups:
https://chromium.googlesource.com/chromium/blink/+/b571b9fbc6e62e05aa77a402cf8f447e681b8ee3
https://chromium.googlesource.com/chromium/blink/+/6b1940151258150ea01bcf21ebfd958e2af247f4
https://chromium.googlesource.com/chromium/blink/+/397c2a2d9416f5c0d79bca22d6979f174eefcce2
https://chromium.googlesource.com/chromium/blink/+/f42ad93e25c6310b2b0327ab7ce5d82d3c4a6c1b
https://chromium.googlesource.com/chromium/blink/+/d55b52b53b7da05bba5fe378a4278250b9347430
https://chromium.googlesource.com/chromium/blink/+/cac766ecaaac477a08879f0b3157d0327cc75d96
https://chromium.googlesource.com/chromium/blink/+/6197ce278696cdd52fc2ad81893f369492468ca0

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::loadTimerFired): Remove the LoadableTextTrack* parameter, it isn't used.
(WebCore::HTMLTrackElement::didCompleteLoad): Ditto.

  • html/HTMLTrackElement.h: didCompleteLoad doesn't need to be virtual.
  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired): Pass a reference, not a pointer.
(WebCore::LoadableTextTrack::cueLoadingStarted): Removed, it wasn't used.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Pass a reference, not a pointer.

  • html/track/LoadableTextTrack.h: Delete LoadableTextTrackClient, it is no longer used.
  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::TextTrackLoader): Take a TextTrackLoaderClient reference.
(WebCore::TextTrackLoader::~TextTrackLoader): Rename m_cachedCueData m_resource.
(WebCore::TextTrackLoader::cueLoadTimerFired): m_client is a reference.
(WebCore::TextTrackLoader::cancelLoad): m_cachedCueData -> m_resource.
(WebCore::TextTrackLoader::processNewCueData): Ditto.
(WebCore::TextTrackLoader::deprecatedDidReceiveCachedResource): Ditto.
(WebCore::TextTrackLoader::notifyFinished): Ditto.
(WebCore::TextTrackLoader::load): shouldLoadCues was removed from the client interface because

the only implementation always returned true.

(WebCore::TextTrackLoader::newRegionsParsed): m_client is a reference

  • loader/TextTrackLoader.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest): Remove an outdated comment.

5:14 AM Changeset in webkit [162835] by Carlos Garcia Campos
  • 14 edits in trunk

[GTK] Implement custom URI schemes with CustomProtocols
https://bugs.webkit.org/show_bug.cgi?id=127091

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

The old classes are no longer built for GTK+ and should be removed once
other ports using soup backend switch to custom protocols implementation.

  • GNUmakefile.am: Remove include path.
  • GNUmakefile.list.am: Remove files from compilation.
  • PlatformGTK.cmake: Ditto.
  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitRequestManagerClient.cpp:

(startLoading):
(stopLoading):
(attachRequestManagerClientToContext):

  • UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestCreate):
(webkit_uri_scheme_request_get_web_view):
(webkitURISchemeRequestReadCallback):
(webkit_uri_scheme_request_finish):
(webkit_uri_scheme_request_finish_error):

  • UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(createDefaultWebContext):
(webkit_web_context_register_uri_scheme):
(webkitWebContextGetRequestManager):
(webkitWebContextStartLoadingCustomProtocol):
(webkitWebContextStopLoadingCustomProtocol):
(webkitWebContextDidFinishLoadingCustomProtocol):

  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebKit2Prefix.h: Enable CustomProtocols unconditionally for the

GTK+ port.

Tools:

Temporarily disable the WebKitWebView check until we figure out
how to implement it with CustomProtocols.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
4:40 AM Changeset in webkit [162834] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

AX: Disable accessibility after every test run
https://bugs.webkit.org/show_bug.cgi?id=127439

Patch by Chris Fleizach <Chris Fleizach> on 2014-01-27
Reviewed by Csaba Osztrogonác.

Speculative fix for EFL build. Don't process these notifications unless accessibility is enabled.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForLoadStart):

3:13 AM Changeset in webkit [162833] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Buildfix for !ENABLE(COMPARE_AND_SWAP) platforms after r162774
https://bugs.webkit.org/show_bug.cgi?id=127678

Reviewed by Zoltan Herczeg.

  • platform/text/TextBreakIterator.cpp:

(WebCore::compareAndSwapNonSharedCharacterBreakIterator):
Use std::mutex instead of Mutex and std::lock_guard instead of MutexLocker.

2:46 AM Changeset in webkit [162832] by Csaba Osztrogonác
  • 5 edits
    1 delete in trunk/LayoutTests

[Mac] fast/profiler/stop-profiling-after-setTimeout.html and fast/profiler/dead-time.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=84102

Reviewed by Darin Adler.

  • fast/profiler/dead-time-expected.txt: Updated.
  • fast/profiler/stop-profiling-after-setTimeout-expected.txt: Updated.
  • platform/efl/TestExpectations: Unskip tests.
  • platform/gtk/fast/profiler/dead-time-expected.txt: Removed.
  • platform/gtk/fast/profiler/stop-profiling-after-setTimeout-expected.txt: Removed.
  • platform/mac/TestExpectations: Unskip tests.
1:09 AM Changeset in webkit [162831] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Another iOS build fix.

  • Misc/WebElementDictionary.mm:

(-[WebElementDictionary _image]):
We were apparently depending on Image::getNSImage() being defined
(yet always returning nullptr) on iOS.

12:27 AM Changeset in webkit [162830] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[SOUP] WebProcess sometimes crashes when a download is cancelled
https://bugs.webkit.org/show_bug.cgi?id=127650

Reviewed by Martin Robinson.

The problem is that when the download is cancelled, the download
manager removes the download from the map and it's deleted. The
Download destructor calls platformInvalidate() that cancels the
resource handle if there's still one. We set to nullptr the
ResourceHandle when the download is cancelled to avoid cancelling
it twice, but it's done after calling Download::didCancel(). It
should be done before, because at that moment, when the download
is deleted, the resource handle pointer is still valid.

  • Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::Download::cancel):

12:18 AM Changeset in webkit [162829] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit/gtk

Unreviewed. Fix GTK+ build after r162808.

  • webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_new_with_data):
(webkit_web_history_item_get_last_visited_time):

Jan 26, 2014:

11:33 PM Changeset in webkit [162828] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the iOS build (failed to correctly revert some broken changes in the last patch).

  • platform/graphics/cg/BitmapImageCG.cpp:
11:16 PM Changeset in webkit [162827] by timothy_horton@apple.com
  • 24 edits in trunk/Source/WebCore

Start cleaning up iOS upstreaming #ifs in platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=127641

Reviewed by Sam Weinig.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/mac/ColorMac.h:

Use USE(APPKIT) instead of PLATFORM(MAC) && !PLATFORM(IOS) for NSImage/getNSImage().

  • platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:

(WebCore::AVTrackPrivateAVFObjCImpl::label):

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
Remove some code that was only used on OS X on Lion or below.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformInit):
ToT WebKit doesn't build on Lion or earlier anymore, so this code can always run.

  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/GradientCG.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/ImageCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/cg/PatternCG.cpp:
  • platform/graphics/mac/FontCustomPlatformData.cpp:

Use CoreGraphics/CoreGraphics.h instead of ApplicationServices/ApplicationServices.h
even on Mac, so we can share the include.

  • platform/graphics/cg/IntSizeCG.cpp:

Remove a random comment of a style we don't tend to use in WebKit,
and from a file not large enough to need it.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
Remove some more always-true #ifs.

  • platform/graphics/mac/WebLayer.mm:

Move a #if'd include out to its own block as per the style guide.

10:23 PM Changeset in webkit [162826] by ap@apple.com
  • 2 edits in trunk/Tools

REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.

  • DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):

Fixed an incorrect ifdef.

9:45 PM Changeset in webkit [162825] by akling@apple.com
  • 10 edits
    2 adds in trunk/Source/JavaScriptCore

JSC: Pack unlinked instructions harder.
<https://webkit.org/b/127660>

Store UnlinkedCodeBlock's instructions in a variable-length stream
to reduce memory usage. Compression rate ends up around 60-61%.

The format is very simple. Every instruction starts with a 1 byte
opcode. It's followed by an opcode-dependent number of argument
values, each encoded separately for maximum packing. There are
7 packed value formats:

5-bit positive integer
5-bit negative integer
13-bit positive integer
13-bit positive integer
5-bit constant register index
13-bit constant register index
32-bit value (fallback)

27.5 MB progression on Membuster3. (~2% of total memory.)

Reviewed by Filip Pizlo.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/UnlinkedInstructionStream.h: Added.

(JSC::UnlinkedInstructionStream::count):
(JSC::UnlinkedInstructionStream::Reader::atEnd):

  • bytecode/UnlinkedInstructionStream.cpp: Added.

(JSC::UnlinkedInstructionStream::Reader::Reader):
(JSC::UnlinkedInstructionStream::Reader::read8):
(JSC::UnlinkedInstructionStream::Reader::read32):
(JSC::UnlinkedInstructionStream::Reader::next):
(JSC::append8):
(JSC::append32):
(JSC::UnlinkedInstructionStream::UnlinkedInstructionStream):
(JSC::UnlinkedInstructionStream::unpackForDebugging):

  • bytecompiler/BytecodeGenerator.cpp:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::lineNumberForBytecodeOffset):
(JSC::dumpLineColumnEntry):
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
(JSC::UnlinkedCodeBlock::setInstructions):
(JSC::UnlinkedCodeBlock::instructions):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::BytecodeGenerator::generate):

9:44 PM Changeset in webkit [162824] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Remove duplicate settings for ENABLE(DISK_IMAGE_CACHE)
<http://webkit.org/b/127669>

Reviewed by Joseph Pecoraro.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Remove duplicate code.

9:21 PM Changeset in webkit [162823] by b.long@cablelabs.com
  • 2 edits in trunk/Tools

[GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
https://bugs.webkit.org/show_bug.cgi?id=110602

Reviewed by Philippe Normand.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
(initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).

7:57 PM Changeset in webkit [162822] by hyatt@apple.com
  • 4 edits in trunk/Source/WebCore

[New Multicolumn] Change the axis property to be a boolean like other isInline checks
https://bugs.webkit.org/show_bug.cgi?id=127661

Reviewed by Simon Fraser.

  • rendering/ColumnInfo.h:

(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::progressionIsInline):
(WebCore::ColumnInfo::setProgressionIsInline):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::initialBlockOffsetForPainting):
(WebCore::RenderBlock::blockDeltaForPaintingNextColumn):
(WebCore::RenderBlock::setComputedColumnCountAndWidth):
(WebCore::RenderBlock::updateColumnInfoFromStyle):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):

  • rendering/RenderMultiColumnFlowThread.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::columnNumberForOffset):

6:22 PM Changeset in webkit [162821] by benjamin@webkit.org
  • 11 edits
    1 delete in trunk/Source/WebCore

Make DOMStringMap a typedef of DatasetDOMStringMap
https://bugs.webkit.org/show_bug.cgi?id=127658

Reviewed by Sam Weinig.

The only concrete implementation of DOMStringMap is DatasetDOMStringMap.
The abstract interface for a single definition is adding complexity for no gain.

This patch removes DOMStringMap and simply keeps the name through a typedef.
I used a typedef instead of just renaming DatasetDOMStringMap because I think
having both name has value. DatasetDOMStringMap is a better description of what
the implementation does. DOMStringMap is the public name and the classname is
the same as the JavaScript type by convention.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/DOMStringMap.cpp: Removed.
  • dom/DOMStringMap.h:
  • dom/DatasetDOMStringMap.h:
  • dom/Element.cpp:

(WebCore::Element::dataset):

  • dom/Element.h:
5:34 PM Changeset in webkit [162820] by ddkilzer@apple.com
  • 5 edits in trunk/Source/WebCore

Part 2: Assertion failure in WebCore::PseudoElement::didRecalcStyle()
<https://bugs.webkit.org/show_bug.cgi?id=126761>
<rdar://problem/15793540>

Reviewed by Simon Fraser.

  • bindings/objc/DOM.mm:

(-[DOMElement image]):
(-[DOMElement _imageTIFFRepresentation]):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeImage):

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeImage):
(WebCore::getCachedImage):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::image):

  • More places where toRenderImage() should be used instead of toImage().
  • Fixed last two places where static_cast<WebCore::RenderImage*> was being used instead of toRenderImage().
5:28 PM Changeset in webkit [162819] by jinwoo7.song@samsung.com
  • 71 edits
    4 deletes in trunk/LayoutTests

Unreviewed EFL gardening after r162742, r162791 and r162803.

  • platform/efl-wk1/fast/forms/basic-inputs-expected.png: Removed.
  • platform/efl-wk1/fast/forms/indeterminate-expected.png: Removed.
  • platform/efl-wk2/fast/forms/basic-inputs-expected.png: Removed.
  • platform/efl-wk2/fast/forms/indeterminate-expected.png: Removed.
  • platform/efl/compositing/overflow/theme-affects-visual-overflow-expected.png:
  • platform/efl/compositing/overflow/theme-affects-visual-overflow-expected.txt:
  • platform/efl/css1/box_properties/acid_test-expected.png:
  • platform/efl/css1/box_properties/acid_test-expected.txt:
  • platform/efl/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/efl/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/efl/css3/selectors3/html/css3-modsel-25-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/efl/css3/selectors3/html/css3-modsel-70-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/efl/css3/selectors3/xml/css3-modsel-25-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/efl/css3/selectors3/xml/css3-modsel-70-expected.txt:
  • platform/efl/fast/block/basic/011-expected.png:
  • platform/efl/fast/block/basic/011-expected.txt:
  • platform/efl/fast/block/margin-collapse/103-expected.png:
  • platform/efl/fast/block/margin-collapse/103-expected.txt:
  • platform/efl/fast/css/non-standard-checkbox-size-expected.png:
  • platform/efl/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/efl/fast/forms/001-expected.png:
  • platform/efl/fast/forms/001-expected.txt:
  • platform/efl/fast/forms/basic-inputs-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.png:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/file/file-input-disabled-expected.png:
  • platform/efl/fast/forms/file/file-input-disabled-expected.txt:
  • platform/efl/fast/forms/form-element-geometry-expected.png:
  • platform/efl/fast/forms/form-element-geometry-expected.txt:
  • platform/efl/fast/forms/formmove-expected.png:
  • platform/efl/fast/forms/formmove-expected.txt:
  • platform/efl/fast/forms/formmove2-expected.png:
  • platform/efl/fast/forms/formmove2-expected.txt:
  • platform/efl/fast/forms/indeterminate-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.png:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/input-value-expected.png:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/forms/search-vertical-alignment-expected.png:
  • platform/efl/fast/forms/search-vertical-alignment-expected.txt:
  • platform/efl/fast/forms/searchfield-heights-expected.png:
  • platform/efl/fast/forms/searchfield-heights-expected.txt:
  • platform/efl/fast/inline/positionedLifetime-expected.png:
  • platform/efl/fast/inline/positionedLifetime-expected.txt:
  • platform/efl/fast/parser/bad-xml-slash-expected.png:
  • platform/efl/fast/parser/bad-xml-slash-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-expected.png:
  • platform/efl/fast/replaced/replaced-breaking-expected.txt:
  • platform/efl/fast/replaced/width100percent-checkbox-expected.png:
  • platform/efl/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/efl/fast/replaced/width100percent-radio-expected.png:
  • platform/efl/fast/replaced/width100percent-radio-expected.txt:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.png:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1318-expected.png:
  • platform/efl/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4527-expected.png:
  • platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/core/captions2-expected.txt:
4:44 PM Changeset in webkit [162818] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

Unreviewed build fix on the EFL build since r162808

lastVisitedTime and visitCount are removed from WebCore::HistoryItem

  • ewk/ewk_history.cpp:

(ewk_history_item_new):
(ewk_history_item_time_last_visited_get):
(ewk_history_item_visit_count):

4:01 PM Changeset in webkit [162817] by aestes@apple.com
  • 56 edits
    4 copies
    18 adds in trunk

[iOS] Upstream changes in Tools/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=127412

Reviewed by Simon Fraser.

Source/WebKit/mac:

  • Misc/WebCoreStatistics.h: Included CGContext.h.

Tools:

Upstream all iOS changes. Added a new target called DumpRenderTree.app,
which builds the DumpRenderTree static library into an app bundle as
expected by the iOS Simulator.

  • DumpRenderTree/AccessibilityTextMarker.h:
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
  • DumpRenderTree/DumpRenderTreePrefix.h:
  • DumpRenderTree/PixelDumpSupport.cpp:
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
  • DumpRenderTree/TestNetscapePlugIn/TestObject.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
  • DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
  • DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
  • DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
  • DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
  • DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
  • DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
  • DumpRenderTree/TestNetscapePlugIn/main.cpp:
  • DumpRenderTree/TestRunner.cpp:
  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/cg/ImageDiffCG.cpp:
  • DumpRenderTree/cg/PixelDumpSupportCG.cpp:
  • DumpRenderTree/ios/AccessibilityControllerIOS.mm:
  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
  • DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
  • DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
  • DumpRenderTree/ios/Info.plist: Added.
  • DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
  • DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
  • DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
  • DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
  • DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
  • DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
  • DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
  • DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
  • DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
  • DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
  • DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
  • DumpRenderTree/ios/PerlSupport/Makefile: Added.
  • DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
  • DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
  • DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
  • DumpRenderTree/mac/AppleScriptController.m:
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  • DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
  • DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
  • DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
  • DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
  • DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
  • DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/DumpRenderTreePasteboard.h:
  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:
  • DumpRenderTree/mac/DumpRenderTreeWindow.h:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  • DumpRenderTree/mac/EditingDelegate.h:
  • DumpRenderTree/mac/EventSendingController.h:
  • DumpRenderTree/mac/EventSendingController.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/mac/HistoryDelegate.h:
  • DumpRenderTree/mac/LayoutTestHelper.m:
  • DumpRenderTree/mac/MockGeolocationProvider.mm:
  • DumpRenderTree/mac/NavigationController.h:
  • DumpRenderTree/mac/ObjCPlugin.h:
  • DumpRenderTree/mac/ObjCPlugin.m:
  • DumpRenderTree/mac/ObjCPluginFunction.h:
  • DumpRenderTree/mac/PolicyDelegate.h:
  • DumpRenderTree/mac/ResourceLoadDelegate.h:
  • DumpRenderTree/mac/ResourceLoadDelegate.mm:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/mac/TextInputController.h:
  • DumpRenderTree/mac/TextInputController.m:
  • DumpRenderTree/mac/UIDelegate.h:
  • DumpRenderTree/mac/UIDelegate.mm:
3:40 PM Changeset in webkit [162816] by Chris Fleizach
  • 8 edits in trunk/Source

AX: Disable accessibility after every test run
https://bugs.webkit.org/show_bug.cgi?id=127439

Reviewed by Alexey Proskuryakov.

../WebCore:

If accessibility is disabled, we may still need to return the existing
AXObjectCache, so that objects can be cleaned up appropriately.

A such we have to be prepared to handle a nullptr return value in more cases.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::disableAccessibility):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::childrenChanged):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remoteSVGRootElement):

  • dom/Document.cpp:

(WebCore::Document::existingAXObjectCache):

../WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
2:55 PM Changeset in webkit [162815] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Follow-up build fix.

  • WebHistoryItem.cpp:

(WebHistoryItem::visitedWithTitle):

2:52 PM Changeset in webkit [162814] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/win

Remove even more Windows history code.

  • WebHistory.cpp:

(WebHistory::removeItemForURLString):

  • WebHistoryItem.cpp:

(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
(WebHistoryItem::getDailyVisitCounts):
(WebHistoryItem::getWeeklyVisitCounts):
(WebHistoryItem::recordInitialVisit):
(WebHistoryItem::initWithURLString):

2:46 PM Changeset in webkit [162813] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/win

Another follow-up build fix.

  • WebHistory.cpp:

(WebHistory::removeAllItems):
(WebHistory::orderedItemsLastVisitedOnDay):

  • WebHistoryItem.cpp:

(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
(WebHistoryItem::visitCount):
(WebHistoryItem::setVisitCount):

2:41 PM Changeset in webkit [162812] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit/win

Remove more history gunk.

  • WebHistory.cpp:

(WebHistory::orderedLastVisitedDays):
(WebHistory::addItem):
(WebHistory::visitedURL):
(WebHistory::removeItemForURLString):

  • WebHistory.h:
  • WebHistoryItem.cpp:

(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
(WebHistoryItem::mergeAutoCompleteHints):
(WebHistoryItem::setLastVisitedTimeInterval):
(WebHistoryItem::initWithURLString):
(WebHistoryItem::lastVisitedTimeInterval):

2:39 PM Changeset in webkit [162811] by fpizlo@apple.com
  • 8 edits
    1 add in branches/jsCStack/Source/JavaScriptCore

FTL should do polyvariant GetById inlining
https://bugs.webkit.org/show_bug.cgi?id=127639

Not yet reviewed.

This does polyvariant inlining for GetByIds. It's pretty easy to do this, now that we
have all of that infrastructure from polyvariant Call/Construct inlining. Basically we
just keep around the StubInfoMaps of the DFG code block when compiling the FTL code
block.

The combination of Call, Construct, and GetById inlining causes a 17% speed-up on
V8v7/raytrace.

GetById inlining alone appears to be a speed-up on other benchmarks as well.

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeDFGStatuses):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::getStubInfoMap):
(JSC::CodeBlock::addStubInfo):

  • bytecode/CodeBlock.h:
  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::hasExitSite):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):

  • bytecode/GetByIdStatus.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):

  • runtime/Options.h:
  • tests/stress/simple-polyvariant-get-by-id-inlining-example.js: Added.

(foo):
(fuzz):
(bar):

2:34 PM Changeset in webkit [162810] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Build fix.

  • WebHistoryItem.cpp:

(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):

2:29 PM Changeset in webkit [162809] by Alan Bujtas
  • 1 edit
    1 add in trunk/LayoutTests

Some more Apple Windows port rebaseline.

  • platform/win/svg/custom/foreign-object-skew-expected.txt: Added.
2:22 PM Changeset in webkit [162808] by andersca@apple.com
  • 8 edits in trunk/Source

Move history item visit count handling to WebKit
https://bugs.webkit.org/show_bug.cgi?id=127659

Reviewed by Dan Bernstein.

Source/WebCore:

Remove all members dealing with visit handling - they're going back to WebKit.

  • WebCore.exp.in:
  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::decodeBackForwardTree):

  • history/HistoryItem.h:

(WebCore::HistoryItem::create):

Source/WebKit/mac:

Move code to deal with visit count and visit dates here from WebCore.

  • History/HistoryPropertyList.mm:

(HistoryPropertyListWriter::writeHistoryItem):

  • History/WebHistoryItem.mm:

(-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
(-[WebHistoryItem copyWithZone:]):
(-[WebHistoryItem lastVisitedTimeInterval]):
(-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
(-[WebHistoryItem setVisitCount:]):
(-[WebHistoryItem _mergeAutoCompleteHints:]):
(-[WebHistoryItem initFromDictionaryRepresentation:]):
(-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
(-[WebHistoryItem _recordInitialVisit]):
(timeToDay):
(-[WebHistoryItem _padDailyCountsForNewVisit:]):
(-[WebHistoryItem _collapseDailyVisitsToWeekly]):
(-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]):
(-[WebHistoryItem _setLastVisitedTimeInterval:]):

  • History/WebHistoryItemInternal.h:
1:32 PM Changeset in webkit [162807] by andersca@apple.com
  • 6 edits
    1 move in trunk/Source/WebKit

Source/WebKit: Fix build.

Make HistoryPropertyList an Objective-C++ class.

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac: Fix build.

Pass a WebHistoryItem to writeHistoryItem so we can extract _lastVisitWasHTTPNonGet from it.

  • History/HistoryPropertyList.h:
  • History/HistoryPropertyList.mm:

(HistoryPropertyListWriter::HistoryPropertyListWriter):
(HistoryPropertyListWriter::buffer):
(HistoryPropertyListWriter::releaseData):
(HistoryPropertyListWriter::writeObjects):
(HistoryPropertyListWriter::writeHistoryItem):

  • History/WebHistory.mm:

(WebHistoryWriter::writeHistoryItems):

  • History/WebHistoryItem.mm:
1:21 PM Changeset in webkit [162806] by andersca@apple.com
  • 11 edits in trunk/Source

Move lastVisitWasHTTPNonGet out to WebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=127657

Reviewed by Dan Bernstein.

Source/WebCore:

Remove m_lastVisitWasHTTPNonGet, it's only used by WebKit.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::reset):

  • history/HistoryItem.h:

Source/WebKit/mac:

Keep track of _lastVisitWasHTTPNonGet inside WebHistoryItem.

  • History/WebHistory.mm:

(-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
Set entry->_private->_lastVisitWasHTTPNonGet.

  • History/WebHistoryItem.h:

Change @private to @package so we can get at WebHistoryItemPrivate from WebHistory.

  • History/WebHistoryItem.mm:

(-[WebHistoryItem copyWithZone:]):
Assign _private->_lastVisitWasHTTPNonGet.

(-[WebHistoryItem initFromDictionaryRepresentation:]):
Set _private->_lastVisitWasHTTPNonGet.

  • History/WebHistoryItemInternal.h:

Move WebHistoryItemPrivate interface here.

Source/WebKit/win:

Remove uses of lastVisitWasHTTPNonGet.

  • WebHistory.cpp:

(WebHistory::visitedURL):

  • WebHistoryItem.cpp:

(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::lastVisitWasHTTPNonGet):
(WebHistoryItem::setLastVisitWasHTTPNonGet):

12:04 PM Changeset in webkit [162805] by Alan Bujtas
  • 1 edit
    58 adds in trunk/LayoutTests

Unreviewed Apple Windows port rebaseline after r162803.

  • platform/win/editing/selection/3690703-2-expected.txt: Added.
  • platform/win/editing/selection/3690703-expected.txt: Added.
  • platform/win/editing/selection/3690719-expected.txt: Added.
  • platform/win/editing/selection/4397952-expected.txt: Added.
  • platform/win/editing/selection/5240265-expected.txt: Added.
  • platform/win/editing/selection/selection-button-text-expected.txt: Added.
  • platform/win/fast/block/float/float-avoidance-expected.txt: Added.
  • platform/win/fast/css/continuationCrash-expected.txt: Added.
  • platform/win/fast/css/margin-top-bottom-dynamic-expected.txt: Added.
  • platform/win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
  • platform/win/fast/forms/001-expected.txt: Added.
  • platform/win/fast/forms/blankbuttons-expected.txt: Added.
  • platform/win/fast/forms/button-table-styles-expected.txt: Added.
  • platform/win/fast/forms/control-restrict-line-height-expected.txt: Added.
  • platform/win/fast/forms/file/file-input-direction-expected.txt: Added.
  • platform/win/fast/forms/file/input-file-re-render-expected.txt: Added.
  • platform/win/fast/forms/formmove3-expected.txt: Added.
  • platform/win/fast/forms/input-appearance-height-expected.txt: Added.
  • platform/win/fast/forms/input-button-sizes-expected.txt: Added.
  • platform/win/fast/forms/input-value-expected.txt: Added.
  • platform/win/fast/forms/targeted-frame-submission-expected.txt: Added.
  • platform/win/fast/html/details-replace-summary-child-expected.txt: Added.
  • platform/win/fast/html/details-replace-text-expected.txt: Added.
  • platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Added.
  • platform/win/fast/overflow/scrollRevealButton-expected.txt: Added.
  • platform/win/fast/replaced/width100percent-button-expected.txt: Added.
  • platform/win/fast/text/textIteratorNilRenderer-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug138725-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug18359-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug2479-4-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug26178-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug28928-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug33855-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug39209-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug4429-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug46368-1-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug46368-2-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug51037-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug51727-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug52505-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug52506-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug60749-expected.txt: Added.
  • platform/win/tables/mozilla/bugs/bug7342-expected.txt: Added.
  • platform/win/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Added.
  • platform/win/tables/mozilla/dom/tableDom-expected.txt: Added.
  • platform/win/tables/mozilla/other/move_row-expected.txt: Added.
  • platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt: Added.
  • platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
  • platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Added.
10:54 AM Changeset in webkit [162804] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Turn WebHistoryItemPrivate back into a real Objective-C class
https://bugs.webkit.org/show_bug.cgi?id=127653

Reviewed by Sam Weinig.

This is a first step towards moving some history specific code from WebCore::HistoryItem back into WebKit.

  • History/WebHistoryItem.mm:

(-[WebHistoryItem dealloc]):
(-[WebHistoryItem finalize]):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):

10:28 AM Changeset in webkit [162803] by Alan Bujtas
  • 129 edits
    1 add in trunk

Subpixel Layout: Align <input type="button", submit etc (PushButtonPart) top and bottom paddings with <button>
https://bugs.webkit.org/show_bug.cgi?id=127640

Reviewed by Simon Fraser.

<button> sets padding-top: 2px and padding-bottom: 3px as default values (html.css),
while <input type="button" (submit, etc) has the hardcoded values of 0, 0 and we center the text using the available space.
This results in different baseline text position in normal cases. This adjustment puts the <input type='button'
rendering back to the pre-subpixel layout state.

Source/WebCore:

  • platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::controlPadding):

LayoutTests:

  • platform/mac/css3/flexbox/button-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4397952-expected.txt:
  • platform/mac/editing/selection/5240265-expected.txt:
  • platform/mac/editing/selection/selection-button-text-expected.txt:
  • platform/mac/fast/block/float/float-avoidance-expected.txt:
  • platform/mac/fast/css/continuationCrash-expected.txt:
  • platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/mac/fast/forms/001-expected.png:
  • platform/mac/fast/forms/001-expected.txt:
  • platform/mac/fast/forms/basic-buttons-expected.png:
  • platform/mac/fast/forms/basic-buttons-expected.txt:
  • platform/mac/fast/forms/blankbuttons-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.png:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/button-positioned-expected.png:
  • platform/mac/fast/forms/button-positioned-expected.txt:
  • platform/mac/fast/forms/button-sizes-expected.png:
  • platform/mac/fast/forms/button-sizes-expected.txt:
  • platform/mac/fast/forms/button-style-color-expected.png:
  • platform/mac/fast/forms/button-style-color-expected.txt:
  • platform/mac/fast/forms/button-table-styles-expected.png:
  • platform/mac/fast/forms/button-table-styles-expected.txt:
  • platform/mac/fast/forms/button-text-transform-expected.png:
  • platform/mac/fast/forms/button-text-transform-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/file/file-input-direction-expected.png:
  • platform/mac/fast/forms/file/file-input-direction-expected.txt:
  • platform/mac/fast/forms/file/file-input-disabled-expected.txt:
  • platform/mac/fast/forms/file/input-file-re-render-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/formmove3-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.png:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-button-sizes-expected.png:
  • platform/mac/fast/forms/input-button-sizes-expected.txt:
  • platform/mac/fast/forms/input-value-expected.png:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/targeted-frame-submission-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.png:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/html/details-replace-summary-child-expected.txt:
  • platform/mac/fast/html/details-replace-text-expected.txt:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/width100percent-button-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/svg/custom/foreign-object-skew-expected.txt: Added.
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla/other/move_row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
5:39 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
5:33 AM Changeset in webkit [162802] by zandobersek@gmail.com
  • 56 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r162553, r162742, r162791 and possibly other revisions.

  • platform/gtk/css1/box_properties/padding-expected.txt:
  • platform/gtk/css1/box_properties/padding_top-expected.txt:
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/gtk/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
  • platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-25-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-70-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-25-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-70-expected.txt:
  • platform/gtk/fast/block/basic/011-expected.txt:
  • platform/gtk/fast/block/float/032-expected.txt:
  • platform/gtk/fast/block/margin-collapse/103-expected.txt:
  • platform/gtk/fast/css/empty-pseudo-class-expected.txt:
  • platform/gtk/fast/css/fieldset-display-row-expected.txt:
  • platform/gtk/fast/css/first-child-pseudo-class-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/last-child-pseudo-class-expected.txt:
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/gtk/fast/css/only-child-pseudo-class-expected.txt:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/formmove-expected.txt:
  • platform/gtk/fast/forms/formmove2-expected.txt:
  • platform/gtk/fast/forms/indeterminate-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/large-toggle-elements-expected.txt:
  • platform/gtk/fast/inline/positionedLifetime-expected.txt:
  • platform/gtk/fast/parser/bad-xml-slash-expected.txt:
  • platform/gtk/fast/repaint/reflection-redraw-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/gtk/fast/replaced/width100percent-radio-expected.txt:
  • platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk/tables/mozilla/marvin/body_col-expected.txt:
  • platform/gtk/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
  • platform/gtk/tables/mozilla/other/body_col-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
2:30 AM Changeset in webkit [162801] by benjamin@webkit.org
  • 4 edits
    2 adds in trunk

Improve the bindings of NodeList's name accessor
https://bugs.webkit.org/show_bug.cgi?id=127358

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-26
Reviewed by Geoffrey Garen.

Source/WebCore:

When accessing an item of NodeList by name, the default bindings was
going through the list of node twice:
-First, getOwnProperty calls canGetItemsForName() to find if a property exists for

the given name. This in turn used NodeList::namedItem() which is a slow operation.

-Then, the value itself was queried through nameGetter(), calling NodeList::namedItem()

a second time to find the same value.

This patch kills the default name getter in favor of a getOwnPropertySlotDelegate() returning
the value directly on the PropertySlot.

Ad Hoc testing show about 15% speed up for simple cases.

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeList::getOwnPropertySlotDelegate):

  • dom/NodeList.idl:

LayoutTests:

  • fast/dom/NodeList/nodelist-name-getter-properties-expected.txt: Added.
  • fast/dom/NodeList/nodelist-name-getter-properties.html: Added.
2:26 AM Changeset in webkit [162800] by benjamin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

ASSERTION FAILED: !m_hasPendingCharacter
https://bugs.webkit.org/show_bug.cgi?id=110118

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-26
Reviewed by Sam Weinig.

Add more test coverage for r144552 with a use case that use to hit the assertion.

  • fast/dom/xml-parser-entity-in-attribute-value-expected.txt: Added.
  • fast/dom/xml-parser-entity-in-attribute-value.html: Added.
12:39 AM Changeset in webkit [162799] by Joseph Pecoraro
  • 26 edits
    2 moves
    12 adds in trunk

Web Inspector: Move InspectorDebuggerAgent into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=127629

Rubber-stamped by Sam Weinig.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Add new files to the build.
  • Also, since non REMOTE_INSPECTOR ports cannot yet connect to a JSGlobalObject for inspection remove those files as they don't need to be built.
  • inspector/EventLoop.cpp: Added.

(Inspector::EventLoop::cycle):

  • inspector/EventLoop.h: Added.

(Inspector::EventLoop::EventLoop):
(Inspector::EventLoop::ended):
Add a JavaScriptCore version of EventLoop. This is currently only
used by the Mac port for JSGlobalObject remote inspection. Keep
the WebCore/platform version alive because for the Mac port it does
slightly different things involving AppKit.

  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
Create DebuggerAgent and hook up ScriptDebugServer where needed.

  • inspector/JSGlobalObjectScriptDebugServer.cpp: Added.

(Inspector::JSGlobalObjectScriptDebugServer::JSGlobalObjectScriptDebugServer):
(Inspector::JSGlobalObjectScriptDebugServer::addListener):
(Inspector::JSGlobalObjectScriptDebugServer::removeListener):
(Inspector::JSGlobalObjectScriptDebugServer::recompileAllJSFunctions):
(Inspector::JSGlobalObjectScriptDebugServer::runEventLoopWhilePaused):

  • inspector/JSGlobalObjectScriptDebugServer.h: Added.

Simple implementation of ScriptDebugServer with a JSGlobalObject.

  • inspector/agents/InspectorDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorDebuggerAgent.cpp.
  • inspector/agents/InspectorDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorDebuggerAgent.h.

Copied from WebCore. A few methods need to be made virtual so that Web implementations
can override and extend the funcitonality. E.g. sourceMapURLForScript and enable/disable.

  • inspector/agents/JSGlobalObjectDebuggerAgent.cpp: Added.
  • inspector/agents/JSGlobalObjectDebuggerAgent.h: Added.

(Inspector::JSGlobalObjectDebuggerAgent::JSGlobalObjectDebuggerAgent):
(Inspector::JSGlobalObjectDebuggerAgent::startListeningScriptDebugServer):
(Inspector::JSGlobalObjectDebuggerAgent::stopListeningScriptDebugServer):
(Inspector::JSGlobalObjectDebuggerAgent::injectedScriptForEval):
Simple implementation of DebuggerAGent with a JSGlobalObject.

Source/WebCore:

Test: inspector-protocol/debugger/pause-on-assert.html

  • CMakeLists.txt:
  • ForwardingHeaders/inspector/agents/InspectorDebuggerAgent.h: Added.
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:
  • Remove InspectorDebuggerAgent.
  • Add WebDebuggerAgent (shared between Page and Worker).
  • inspector/WebDebuggerAgent.h: Added.

(WebCore::WebDebuggerAgent::~WebDebuggerAgent):

  • inspector/WebDebuggerAgent.cpp: Added.

(WebCore::WebDebuggerAgent::WebDebuggerAgent):
(WebCore::WebDebuggerAgent::enable):
(WebCore::WebDebuggerAgent::disable):
Shared code for Page and Worker debugger agents.
Instrumenting agents is a concept in WebCore only,
and the Debugger agent is only in the instrumenting
agents list when it is enabled and removed when disabled.

  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::inspectorDebuggerAgent):
(WebCore::InstrumentingAgents::setInspectorDebuggerAgent):

  • inspector/InspectorDOMDebuggerAgent.cpp:
  • inspector/InspectorDOMDebuggerAgent.h:

Update namespace for debugger agent.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::isConsoleAssertMessage):
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
DebuggerAgent in JavaScriptCore does not yet know about console
types. So temporarily handle it here. We need to give JavaScriptCore
some concept of Console messages and types.

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::enable):
(WebCore::PageDebuggerAgent::disable):
(WebCore::PageDebuggerAgent::sourceMapURLForScript):
(WebCore::PageDebuggerAgent::injectedScriptForEval):

  • inspector/PageDebuggerAgent.h:
  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::injectedScriptForEval):

  • inspector/WorkerDebuggerAgent.h:

Modernize the Page and Worker debugger agents.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorController.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
New constructors for the debugger agents.

LayoutTests:

Add a test that we pause in the debugger for console.assert failures
when the DebuggerAgent is enabled.

  • inspector-protocol/debugger/pause-on-assert-expected.txt: Added.
  • inspector-protocol/debugger/pause-on-assert.html: Added.
  • inspector-protocol/debugger/resources/assert.js: Added.

(assertTrue):
(assertFalse):
(assertCondition):
(assertConditionWithMessage):

Jan 25, 2014:

11:19 PM Changeset in webkit [162798] by fpizlo@apple.com
  • 4 edits in branches/jsCStack/Source

StubInfoMap should use CodeOriginApproximateHash
https://bugs.webkit.org/show_bug.cgi?id=127646

Not yet reviewed.

Source/JavaScriptCore:

  • bytecode/StructureStubInfo.h:

Source/WTF:

  • wtf/BagToHashMap.h:

(WTF::toHashMap):

10:53 PM Changeset in webkit [162797] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: fix build breakage from previous commit.

Not reviewed.

  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintData):

  • Removed obsolete references to "visible" timers.
10:30 PM Changeset in webkit [162796] by timothy@apple.com
  • 14 edits in trunk

Remove dead code from the JSC profiler.

https://bugs.webkit.org/show_bug.cgi?id=127643

Reviewed by Mark Lam.

Source/JavaScriptCore:

  • profiler/Profile.cpp:
  • profiler/Profile.h:
  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::stopProfiling):

  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::stopProfiling):
(JSC::ProfileNode::endAndRecordCall):
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

  • profiler/ProfileNode.h:

(JSC::ProfileNode::totalTime):
(JSC::ProfileNode::setTotalTime):
(JSC::ProfileNode::selfTime):
(JSC::ProfileNode::setSelfTime):
(JSC::ProfileNode::totalPercent):
(JSC::ProfileNode::selfPercent):
Remove support for things like focus and exclude. The Inspector does those in JS now.

Source/WebCore:

Passes existing tests in fast/profiler.

  • bindings/js/ScriptProfile.cpp:

(WebCore::buildInspectorObjectFor): Remove visible.

  • inspector/ScriptProfileNode.idl: Ditto.
  • inspector/protocol/Profiler.json: Ditto.

Source/WebInspectorUI:

  • Versions/Inspector-iOS-7.0.json: Remove visible from CPUProfileNode.

LayoutTests:

  • fast/profiler/resources/profiler-test-JS-resources.js:

(printProfileNodeWithoutTime): Don't use visible. It was always true.

10:25 PM Changeset in webkit [162795] by commit-queue@webkit.org
  • 34 edits in trunk/Source

Remove unused support for DRAGGABLE_REGION
https://bugs.webkit.org/show_bug.cgi?id=127642

Patch by Sam Weinig <sam@webkit.org> on 2014-01-25
Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • WebCore.exp.in:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:
  • page/Chrome.cpp:
  • page/ChromeClient.h:
  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::paintContents):

  • page/FrameView.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::styleWillChange):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::addAnnotatedRegions):

  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::setHasVerticalScrollbar):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addAnnotatedRegions):

  • rendering/RenderObject.h:

(WebCore::AnnotatedRegionValue::operator==):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:
8:15 PM Changeset in webkit [162794] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Remove FIXME in CSSKeywordCompletions.js about "inherit" keyword
https://bugs.webkit.org/show_bug.cgi?id=127638

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-25
Reviewed by Timothy Hatcher.

  • UserInterface/CSSKeywordCompletions.js:

(WebInspector.CSSKeywordCompletions.forProperty):
Replace FIXME with a descriptive comment about why the code is what it is.

7:54 PM Changeset in webkit [162793] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WTF

Add FALLTHROUGH and -Wimplicit-fallthrough to warn about unannotated implicit fallthroughs in switches
https://bugs.webkit.org/show_bug.cgi?id=127637

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-25
Reviewed by Darin Adler.

For information about [[clang::fallthrough]], see:
<http://clang.llvm.org/docs/LanguageExtensions.html#the-clang-fallthrough-attribute>

  • Configurations/Base.xcconfig:

Enable -Wimplicit-fallthrough warnings.

  • wtf/Compiler.h:

Define FALLTHROUGH on clang and fallback to outputing nothing when unsupported.

  • wtf/dtoa/fast-dtoa.cc:
  • wtf/unicode/UTF8.cpp:

(WTF::Unicode::convertLatin1ToUTF8):
(WTF::Unicode::convertUTF16ToUTF8):
(WTF::Unicode::isLegalUTF8):
(WTF::Unicode::readUTF8Sequence):
Explicitly annotate implicit fallthroughs with FALLTHROUGH.

7:43 PM Changeset in webkit [162792] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Clean up SVGPatternElement::collectPatternAttributes
https://bugs.webkit.org/show_bug.cgi?id=127612

Reviewed by Andreas Kling.

This patch refactors SVGPatternElement::collectPatternAttributes() by extracting
the setPatternAttributes logic into a new function. This patch also changes the
while loop to be easier to understand and similar to collectGradientAttributes.

  • svg/SVGPatternElement.cpp:

(WebCore::setPatternAttributes):
(WebCore::SVGPatternElement::collectPatternAttributes):

5:27 PM Changeset in webkit [162791] by Alan Bujtas
  • 10 edits in trunk

Subpixel layout: RenderInline is not centered when child RenderTextControl's innerTextRenderer needs bias centering.
https://bugs.webkit.org/show_bug.cgi?id=125659

Source/WebCore:

Reviewed by Andreas Kling

layoutMod(logicalHeightDiff, 2) fails to bias round when subpixel layout is enabled. It sets
the denominator value to 2, which returns incorrect modulo result.
(subpixel off: 3px % 2 = 1 vs subpixel on: (3px * 64) -> 192 % 2 = 0)

Covered by existing tests.

  • platform/LayoutUnit.h:
  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::centerContainerIfNeeded):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::centerRenderer):
(WebCore::RenderTextControlSingleLine::layout):

  • rendering/RenderTextControlSingleLine.h:

LayoutTests:

Reviewed by Andreas Kling.

layoutMod(logicalHeightDiff, 2) fails to bias round when subpixel layout is enabled. It sets
the denominator value to 2, which returns incorrect modulo result.
(subpixel off: 3px % 2 = 1 vs subpixel on: (3px * 64) -> 192 % 2 = 0)

Covered by existing tests.

  • platform/mac/fast/block/float/032-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.txt:
5:08 PM Changeset in webkit [162790] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Position the completion suggestions popup below if there is room
https://bugs.webkit.org/show_bug.cgi?id=127615

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-01-25
Reviewed by Joseph Pecoraro.

  • UserInterface/CompletionSuggestionsView.js:

(WebInspector.CompletionSuggestionsView.prototype.show):

4:50 PM Changeset in webkit [162789] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Remove more unnecessary #if PLATFORM(IOS)s in ApplicationCacheStorage.cpp
https://bugs.webkit.org/show_bug.cgi?id=127635

Reviewed by Antti Koivisto.

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::executeSQLCommand):
(WebCore::ApplicationCacheStorage::verifySchemaVersion):
(WebCore::ApplicationCacheStorage::executeStatement):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::ensureOriginRecord):
(WebCore::ApplicationCacheStorage::loadCache):

4:44 PM Changeset in webkit [162788] by fpizlo@apple.com
  • 40 edits
    2 adds in branches/jsCStack/Source/JavaScriptCore

FTL should do polyvariant Call/Construct inlining
https://bugs.webkit.org/show_bug.cgi?id=127335

Reviewed by Oliver Hunt.

Imagine that you have a call stack like foo calls bar, which calls baz. Lets say that
there's another call stack where bar calls something other than baz at the same
callsite, but whenver bar is called from foo, it always calls baz.

This bar->baz callsite can be said to be polymorphic, because it may call things other
than baz in some cases.

But if we conduct a polyvariant analysis - that is, one that accounts for the call
stack when reporting results - then this call appears monomorphic whenever bar gets
called from foo. A polyvariant analysis of callsites will report results of the form
"when statement S ran on a call stack that included functions f, g, etc then the set
of possible callees is bounded by ...". This is in contrast to a monovariant analysis
that will attempt to construct a bounding set of callees without adding the call stack
as a contingency.

Prior to this patch, all inlining decisions were made based on a monovariant dynamic
analysis.

This patch allows the FTL to make its Call/Construct inlining decisions based on a
polyvariant analysis. That analysis is cleverly simple: we just ask the DFG to do the
same "analysis" that the LLInt and Baseline JIT perform. That "analysis" is just an
inline cache plus a slow-path count. But the DFG has performed inlining. Hence each
callsite that the DFG reports information for is actually sitting on a static call
stack. When the DFG reports the status of its call inline caches, it can report the
information with a (short) snippet of call stack as a kind of contingency, much like a
polyvariant analysis would.

Consider the foo->bar->baz example. Lets say that foo's call to bar is trivially
monomorphic, and the DFG inlines it. The DFG won't be able to then inline the call
from foo->bar to baz because when we ask the Baseline JIT profiling what the status of
the bar->baz call is, the profiling will say "polymorphic". That's because that
profiling doesn't have any context sensitivity, and so it doesn't know that the call
would be monomorphic if foo was bar's caller.

But, with this patch, once we tier-up from the DFG to the FTL, the FTL will be able to
ask the DFG: "hey, what do you know about the callsite to baz in foo->bar?" The DFG
had, as we said above, inlined bar into foo and so it sees that callsite in its
proper context. That call inline cache would be monomorphic. The FTL would then be
able to inline baz into foo->bar.

This will eventually benefit V8v7/raytrace, but we still have some more things to do
before we can close the loop on this. Right now, the callsite in question is not an
inlining candidate because it's op_call_varargs. We'll fix that eventually.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFor):
(JSC::CallLinkStatus::computeDFGStatuses):

  • bytecode/CallLinkStatus.h:

(JSC::CallLinkStatus::makeClosureCall):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::specialFastCaseProfileForBytecodeOffset):

  • bytecode/CodeOrigin.cpp:

(JSC::CodeOrigin::isApproximatelyEqualTo):
(JSC::CodeOrigin::approximateHash):

  • bytecode/CodeOrigin.h:

(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::deletedMarker):
(JSC::CodeOriginApproximateHash::hash):
(JSC::CodeOriginApproximateHash::equal):

  • bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::add):
(JSC::DFG::ExitProfile::hasExitSite):

  • bytecode/DFGExitProfile.h:

(JSC::DFG::FrequentExitSite::FrequentExitSite):
(JSC::DFG::FrequentExitSite::operator==):
(JSC::DFG::FrequentExitSite::subsumes):
(JSC::DFG::FrequentExitSite::hash):
(JSC::DFG::FrequentExitSite::jitType):
(JSC::DFG::FrequentExitSite::withJITType):
(JSC::DFG::QueryableExitProfile::hasExitSite):

  • bytecode/ExitKind.h:
  • bytecode/ExitingJITType.h: Added.

(JSC::exitingJITTypeFor):

  • bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:

(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGCapabilities.h:

(JSC::DFG::inlineFunctionForCallCapabilityLevel):
(JSC::DFG::inlineFunctionForClosureCallCapabilityLevel):
(JSC::DFG::inlineFunctionForConstructCapabilityLevel):
(JSC::DFG::inlineFunctionForCapabilityLevel):

  • dfg/DFGCommon.h:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):
(JSC::DFG::compile):

  • dfg/DFGDriver.h:
  • dfg/DFGFailedFinalizer.cpp:

(JSC::DFG::FailedFinalizer::codeSize):

  • dfg/DFGFailedFinalizer.h:
  • dfg/DFGFinalizer.h:
  • dfg/DFGJITCode.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::currentJSCallIndex):

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::codeSize):

  • dfg/DFGJITFinalizer.h:
  • dfg/DFGOSRExit.h:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):

  • dfg/DFGOSRExitBase.cpp:

(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):

  • dfg/DFGOSRExitBase.h:

(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::compileInThread):

  • dfg/DFGPlan.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::prepareJITCodeForTierUp):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::codeSize):

  • ftl/FTLJITFinalizer.h:
  • ftl/FTLOSRExit.h:

(JSC::FTL::OSRExit::considerAddingAsFrequentExitSite):

  • jit/JITCode.h:
  • jit/JITOperations.cpp:
  • runtime/Options.h:
  • tests/stress/simple-polyvariant-call-inlining-example.js: Added.

(foo):
(fuzz):
(bar):
(baz1):
(baz2):

4:36 PM Changeset in webkit [162787] by weinig@apple.com
  • 11 edits
    3 copies
    1 delete in trunk/Source/WebCore

Remove some iOS #ifdefs by adding SQLiteDatabaseTracker to all the builds
https://bugs.webkit.org/show_bug.cgi?id=127632

Reviewed by Darin Adler.

Move the SQLiteDatabaseTracker and client from platform/sql/ios to platform/sql,
as there is nothing iOS specific about it. Then, un-#ifdef all its uses. For
ports that don't setup a client, this has no change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webdatabase/DatabaseBackendBase.cpp:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/appcache/ApplicationCacheStorage.cpp:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::sendWillRevealEdgeEventsIfNeeded):

  • platform/sql/SQLiteDatabaseTracker.cpp: Copied from Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.cpp.
  • platform/sql/SQLiteDatabaseTracker.h: Copied from Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.h.
  • platform/sql/SQLiteDatabaseTrackerClient.h: Copied from Source/WebCore/platform/sql/ios/SQLiteDatabaseTrackerClient.h.
  • platform/sql/ios: Removed.
  • platform/sql/ios/SQLiteDatabaseTracker.cpp: Removed.
  • platform/sql/ios/SQLiteDatabaseTracker.h: Removed.
  • platform/sql/ios/SQLiteDatabaseTrackerClient.h: Removed.
  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::openDatabase):
(WebCore::StorageAreaSync::sync):

  • storage/StorageTracker.cpp:
3:04 PM Changeset in webkit [162786] by andersca@apple.com
  • 22 edits in trunk/Source

Remove an unused FrameLoaderClient function
https://bugs.webkit.org/show_bug.cgi?id=127628

Reviewed by Andreas Kling.

Source/WebCore:

All implementations of FrameLoaderClient::shouldStopLoadingForHistoryItem return true and this function
was only used by Chromium so we can get rid of it.

  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:
  • loader/HistoryController.cpp:

(WebCore::HistoryController::shouldStopLoadingForHistoryItem):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:
  • WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2:58 PM Changeset in webkit [162785] by Darin Adler
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix Mac build.

  • runtime/DatePrototype.cpp: Put the include of <unicode/udat.h> inside

a conditional since we don't have that header in our Mac build configuration.

2:47 PM Changeset in webkit [162784] by Darin Adler
  • 31 edits in trunk

Call deprecatedCharacters instead of characters at more call sites
https://bugs.webkit.org/show_bug.cgi?id=127631

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • API/JSValueRef.cpp:

(JSValueMakeFromJSONString):

  • API/OpaqueJSString.cpp:

(OpaqueJSString::~OpaqueJSString):

  • bindings/ScriptValue.cpp:

(Deprecated::jsToInspectorValue):

  • inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::createSearchRegexSource):

  • inspector/InspectorValues.cpp:
  • runtime/Identifier.h:

(JSC::Identifier::deprecatedCharacters):

  • runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::append):
Use the new name.

Source/WebCore:

  • bindings/objc/WebScriptObject.mm:

(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):

  • editing/CompositeEditCommand.cpp:

(WebCore::containsOnlyWhitespace):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertText):

  • editing/VisibleUnits.cpp:

(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces):
(WebCore::parseHTMLNonNegativeInteger):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):

  • inspector/InspectorStyleTextEditor.cpp:

(WebCore::InspectorStyleTextEditor::insertProperty):
(WebCore::InspectorStyleTextEditor::internalReplaceProperty):

  • platform/Length.cpp:

(WebCore::newCoordsArray):

  • platform/LinkHash.cpp:

(WebCore::visitedLinkHash):

  • platform/graphics/Color.cpp:

(WebCore::Color::parseHexColor):
(WebCore::Color::Color):

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::atomicCanonicalTextEncodingName):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::constructTextRun):

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::width):

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::registerLigaturesInGlyphCache):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunId::evaluate):
Use the new name.

Source/WTF:

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::replace):

  • wtf/text/WTFString.h:

(WTF::String::isAllSpecialCharacters):
Use the new name.

Tools:

  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

(TestWebKitAPI::expectBuilderContent):
(TestWebKitAPI::expectEmpty):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):
Use the new name.

2:46 PM Changeset in webkit [162783] by Darin Adler
  • 6 edits
    1 add in trunk/Source/WTF

Add a new separate LChar.h header file, to be used after we remove Unicode.h
https://bugs.webkit.org/show_bug.cgi?id=127630

Reviewed by Sam Weinig.

  • GNUmakefile.list.am: Added the new file
  • WTF.vcxproj/WTF.vcxproj: Ditto.
  • WTF.vcxproj/WTF.vcxproj.filters: Ditto.
  • WTF.xcodeproj/project.pbxproj: Ditto.
  • wtf/CMakeLists.txt: Ditto.
  • wtf/text/LChar.h: Added.
1:36 PM Changeset in webkit [162782] by Darin Adler
  • 28 edits
    1 delete in trunk

Get rid of ICU_UNICODE and WCHAR_UNICODE remnants
https://bugs.webkit.org/show_bug.cgi?id=127623

Reviewed by Anders Carlsson.

.:

  • Source/cmake/OptionsEfl.cmake: Removed ICU_UNICODE and WCHAR_UNICODE flags.
  • Source/cmake/OptionsGTK.cmake: Ditto.
  • Source/cmake/OptionsWinCE.cmake: Ditto.

Source/JavaScriptCore:

  • runtime/DatePrototype.cpp: Removed USE(ICU_UNICODE) checks, since that's always true now.

Source/WebCore:

  • CMakeLists.txt: Removed SmartReplaceICU.cpp.
  • GNUmakefile.list.am: Ditto.
  • PlatformEfl.cmake: Ditto.
  • PlatformGTK.cmake: Ditto.
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::modifyMovingRight): Ditto.
(WebCore::FrameSelection::modifyMovingLeft): Ditto.

  • editing/SmartReplace.cpp: Moved code here from SmartReplaceICU,

since we always support ICU now. Added some FIXME comments about
bugs and mistakes I spotted in the code as I was moving it.

  • editing/SmartReplaceICU.cpp: Removed.
  • editing/TextIterator.cpp: Removed unneeded checks.
  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData): Ditto.
(WebCore::ThreadGlobalData::destroy): Ditto.

  • platform/ThreadGlobalData.h: Ditto.
  • platform/URL.cpp:

(WebCore::appendEncodedHostname): Ditto.

  • platform/graphics/SurrogatePairAwareTextIterator.cpp: Ditto.

Also removed unneeded "using namespace".

  • platform/text/TextCodecICU.cpp: Ditto.
  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode): Ditto.

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps): Ditto.

Source/WTF:

  • wtf/CMakeLists.txt: Removed WTF_USE_ICU_UNICODE and

WTF_USE_WCHAR_UNICODE since they are true and false respectively.

  • wtf/Platform.h: Removed code to set WTF_USE_ICU_UNICODE.
  • wtf/unicode/Collator.h: Removed ifdefs.
  • wtf/unicode/CollatorDefault.cpp: Ditto.
  • wtf/unicode/Unicode.h: Ditto.
  • wtf/unicode/icu/CollatorICU.cpp: Ditto.
1:31 PM Changeset in webkit [162781] by Darin Adler
  • 2 edits in trunk/Source/JavaScriptCore

[Mac] Rewrite locale-specific date formatting code to remove strange string creation
https://bugs.webkit.org/show_bug.cgi?id=127624

Reviewed by Anders Carlsson.

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate): Use some smart pointers and conversion operators we already
have to do the formatting in a more straightforward way.

1:31 PM Changeset in webkit [162780] by Darin Adler
  • 10 edits
    2 deletes in trunk/Source/WebCore

Get rid of UnicodeRange.h/cpp, using ICU instead
https://bugs.webkit.org/show_bug.cgi?id=127622

Reviewed by Anders Carlsson.

  • CMakeLists.txt: Remove UnicodeRange.h/cpp.
  • GNUmakefile.list.am: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::systemFallbackForCharacters): To check if a character has
multiple code pages, use UCHAR_UNIFIED_IDEOGRAPH instead of cRangeSetCJK.

  • platform/graphics/wince/FontCacheWinCE.cpp:

(WebCore::FontCache::systemFallbackForCharacters): Ditto. Also, to check if a
character is in the Thai block, use UBLOCK_THAI.

  • platform/graphics/wince/FontPlatformData.cpp: Removed include of UnicodeRange.h.
  • platform/text/UnicodeRange.cpp: Removed.
  • platform/text/UnicodeRange.h: Removed.
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp:

(WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle): To figure
out if a character is full width, use UCHAR_EAST_ASIAN_WIDTH, instead of hard-coding
"not Latin or Arabic" as the rule.

1:25 PM Changeset in webkit [162779] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Remove an unnecessary platform #if in BitmapImage(CG)::checkForSolidColor()
https://bugs.webkit.org/show_bug.cgi?id=127610

Reviewed by Simon Fraser.

  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::checkForSolidColor):
Over time, the two sides of this #if !PLATFORM(IOS) converged. Remove the #if
and merge the code. We explicitly use kCGBitmapByteOrder32Big to be correct everywhere.

1:24 PM Changeset in webkit [162778] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

[cg] Look in the PNG dictionary for image duration information
https://bugs.webkit.org/show_bug.cgi?id=127611
<rdar://problem/15408643>

Reviewed by Simon Fraser.

We should look in the PNG properties dictionary for frame duration and loop count data.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::repetitionCount):
Mush repetitionCount a bit more to make it easier to read (early returns, etc.)
Also, look in the PNG properties dictionary for a loop count.

(WebCore::ImageSource::frameDurationAtIndex):
Look in the PNG properties dictionary for delay time.
Get rid of WebCoreCGImagePropertyGIFUnclampedDelayTime; it hasn't
been needed since Snow Leopard.

1:16 PM Changeset in webkit [162777] by andersca@apple.com
  • 19 edits in trunk/Source

Remove atomicIncrement/atomicDecrement
https://bugs.webkit.org/show_bug.cgi?id=127625

Reviewed by Andreas Kling.

Replace atomicIncrement/atomicDecrement with std::atomic.

Source/JavaScriptCore:

  • bytecode/Watchpoint.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):

  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::addDatabaseToAtExit):

Source/WebCore:

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::incrementActiveSourceCount):
(WebCore::AudioContext::decrementActiveSourceCount):

  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):

  • Modules/webaudio/AudioNode.h:
  • Modules/webdatabase/OriginLock.h:

Source/WebKit2:

  • Platform/IPC/Connection.cpp:

(IPC::Connection::createSyncMessageEncoder):

  • Shared/mac/SecItemShim.cpp:

(WebKit::generateSecItemRequestID):

  • UIProcess/StatisticsRequest.cpp:

(WebKit::StatisticsRequest::addOutstandingRequest):

Source/WTF:

  • wtf/Atomics.h:
  • wtf/RefCountedLeakCounter.cpp:

(WTF::RefCountedLeakCounter::~RefCountedLeakCounter):
(WTF::RefCountedLeakCounter::increment):
(WTF::RefCountedLeakCounter::decrement):

  • wtf/RefCountedLeakCounter.h:
  • wtf/ThreadSafeRefCounted.h:

(WTF::ThreadSafeRefCountedBase::ref):
(WTF::ThreadSafeRefCountedBase::refCount):
(WTF::ThreadSafeRefCountedBase::derefBase):

12:49 PM Changeset in webkit [162776] by alex.christensen@flexsim.com
  • 4 edits in trunk/Source

Source/WebCore: Unreviewed build fix for WinCairo.

  • platform/network/curl/CurlDownload.h:

Included wtf/Threading.h for ThreadIdentifier definition.

Source/WebKit: Unreviewed build fix for Win64.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Corrected 64-bit linker symbol.

12:10 PM Changeset in webkit [162775] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Build fix.

  • WebView/WebViewData.h:
11:24 AM Changeset in webkit [162774] by andersca@apple.com
  • 16 edits in trunk

Modernize HashTable threading code
https://bugs.webkit.org/show_bug.cgi?id=127621

Reviewed by Darin Adler.

Source/WebCore:

Explicitly include headers that used to be brought in by HashTable.h

  • platform/DragData.h:

Change a Windows-specific typedef to avoid having to include WindDef.h from a header.

  • platform/audio/AudioSession.h:
  • platform/network/cf/SocketStreamHandle.h:

Source/WebKit/win:

Explicitly include headers that used to be brought in by HashTable.h

  • WebLocalizableStrings.cpp:

Source/WebKit2:

Explicitly include headers that used to be brought in by HashTable.h

  • Shared/BlockingResponseMap.h:

Source/WTF:

Use std::mutex and std::atomic instead of WTF threading primitives.

  • wtf/DynamicAnnotations.h:

Include Platform.h here since this file relies on USE macros.

  • wtf/HashTable.cpp:

(WTF::HashTableStats::recordCollisionAtCount):
Change this to take an unsigned.

(WTF::HashTableStats::dumpStats):

  • wtf/HashTable.h:

(WTF::KeyTraits>::HashTable):
(WTF::KeyTraits>::remove):
(WTF::KeyTraits>::invalidateIterators):
Use a single probe counter.

(WTF::addIterator):
(WTF::removeIterator):

Tools:

Explicitly include headers that used to be brought in by HashTable.h

  • DumpRenderTree/JavaScriptThreading.cpp:
10:55 AM Changeset in webkit [162773] by zandobersek@gmail.com
  • 8 edits in trunk/Source/WebCore

Move CSSGroupingRule, CSSStyleSheet, ElementRuleCollector to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127575

Reviewed by Andreas Kling.

Use std::unique_ptr and std::make_unique in place of OwnPtr and adoptPtr
in the CSSGroupingRule, CSSStyleSheet and ElementRuleCollector classes.

  • css/CSSFunctionValue.cpp: Remove the unnecessary PassOwnPtr header inclusion.
  • css/CSSGroupingRule.cpp:

(WebCore::CSSGroupingRule::cssRules):

  • css/CSSGroupingRule.h:
  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::cssRules):

  • css/CSSStyleSheet.h:
  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::addMatchedRule):

  • css/ElementRuleCollector.h:
10:54 AM Changeset in webkit [162772] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

Move MediaQueryMatcher, SelectorFilter to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127574

Reviewed by Andreas Kling.

Replace the use of OwnPtr and adoptPtr with std::unique_ptr and std::make_unique
in the MediaQueryMatcher and SelectorFilter classes.

  • css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::prepareEvaluator):
(WebCore::MediaQueryMatcher::evaluate):
(WebCore::MediaQueryMatcher::addListener):
(WebCore::MediaQueryMatcher::styleResolverChanged):

  • css/MediaQueryMatcher.h:
  • css/SelectorFilter.cpp:

(WebCore::SelectorFilter::popParentStackFrame):
(WebCore::SelectorFilter::setupParentStack):

  • css/SelectorFilter.h:
10:52 AM Changeset in webkit [162771] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

Move PropertySetCSSStyleDeclaration, WebKitCSSKeyframesRule to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127572

Reviewed by Andreas Kling.

Switch the PropertySetCSSStyleDeclaration and WebKitCSSKeyframesRule classes from using
OwnPtr and adoptPtr to using std::unique_ptr and std::make_unique.

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::didMutate):

  • css/PropertySetCSSStyleDeclaration.h:
  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::cssRules):

  • css/WebKitCSSKeyframesRule.h:
10:51 AM Changeset in webkit [162770] by zandobersek@gmail.com
  • 6 edits in trunk/Source/WebCore

Move StyleProperties, StyleResolver to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127570

Reviewed by Andreas Kling.

Move the StyleProperties and StyleResolver classes from using OwnPtr and adoptPtr
to using std::unique_ptr and std::make_unique.

  • css/StyleInvalidationAnalysis.h: Remove the PassOwnPtr.h header inclusion.
  • css/StyleProperties.cpp:

(WebCore::MutableStyleProperties::ensureCSSStyleDeclaration):
(WebCore::MutableStyleProperties::ensureInlineCSSStyleDeclaration):

  • css/StyleProperties.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addViewportDependentMediaQueryResult):

  • css/StyleResolver.h:
  • css/StyleScopeResolver.h:
10:49 AM Changeset in webkit [162769] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

Move CSSFontFace, CSSFontSelector to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127569

Reviewed by Andreas Kling.

Move the CSSFontFace and CSSFontSelector classes from using OwnPtr, PassOwnPtr and adoptPtr
to using std::unique_ptr, move semantics and std::make_unique.

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::addSource):

  • css/CSSFontFace.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontFace):

  • css/CSSFontSelector.h:
10:48 AM Changeset in webkit [162768] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Remove null check for WebPopupMenuProxy::Client in WebPopupMenuProxyGtk::showPopupMenu
https://bugs.webkit.org/show_bug.cgi?id=107036

Reviewed by Andreas Kling.

  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Don't perform an early return
if the client is not available - it always should be. The client is set to null
only when the proxy is invalidated. This happens immediately after this function
returns, either with the popup being forced to close or being closed by the user
with possibly an item being chosen. Rather than the early return, use an ASSERT.

9:48 AM Changeset in webkit [162767] by Joseph Pecoraro
  • 21 edits
    2 moves
    3 adds in trunk/Source

Web Inspector: Move InspectorRuntimeAgent into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=127605

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Add new files to the build.

  • inspector/agents/InspectorRuntimeAgent.h: Renamed from Source/WebCore/inspector/InspectorRuntimeAgent.h.
  • inspector/agents/InspectorRuntimeAgent.cpp: Renamed from Source/WebCore/inspector/InspectorRuntimeAgent.cpp.

(Inspector::InspectorRuntimeAgent::InspectorRuntimeAgent):
(Inspector::InspectorRuntimeAgent::parse):
(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getProperties):

  • Move the agent into JavaScriptCore.
  • Modernize and cleanup.
  • Make globalVM a pure virtual function for subclasses to implement.
  • inspector/agents/JSGlobalObjectRuntimeAgent.h: Added.
  • inspector/agents/JSGlobalObjectRuntimeAgent.cpp: Added.

(Inspector::JSGlobalObjectRuntimeAgent::JSGlobalObjectRuntimeAgent):
(Inspector::JSGlobalObjectRuntimeAgent::didCreateFrontendAndBackend):
(Inspector::JSGlobalObjectRuntimeAgent::willDestroyFrontendAndBackend):
(Inspector::JSGlobalObjectRuntimeAgent::globalVM):
(Inspector::JSGlobalObjectRuntimeAgent::injectedScriptForEval):
Straightforward JSGlobalObject implementation.

  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
Add a runtime agent when inspecting a JSContext!

Source/WebCore:

Covered by existing tests. No change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:

Remove WebCore InspectorRuntimeAgent.

  • ForwardingHeaders/inspector/agents/InspectorRuntimeAgent.h: Added.

Add JavaScriptCore InspectorRuntimeAgent.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/WorkerInspectorController.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
New constructors for the runtime agent.

  • inspector/PageRuntimeAgent.h:
  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::disable):
(WebCore::PageRuntimeAgent::didCreateMainWorldContext):
(WebCore::PageRuntimeAgent::didCreateIsolatedContext):
(WebCore::PageRuntimeAgent::globalVM):
Modernize and implement globalVM.

  • inspector/WorkerRuntimeAgent.h:
  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::injectedScriptForEval):
(WebCore::WorkerRuntimeAgent::globalVM):
Modernize and implement globalVM.

9:25 AM Changeset in webkit [162766] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Add parameters from 'DOM Object Model Core' spec and 'DOM CSS' spec that can be NULL

https://bugs.webkit.org/show_bug.cgi?id=117536

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-01-25
Reviewed by Xan Lopez.

  • bindings/scripts/CodeGeneratorGObject.pm:

(ParamCanBeNull): Add new pairs (function, parameter) that can be NULL

9:18 AM Changeset in webkit [162765] by Darin Adler
  • 2 edits in trunk/Source/WTF

Restore alphabetical order in Compiler.h
https://bugs.webkit.org/show_bug.cgi?id=127620

Reviewed by Sam Weinig.

  • wtf/Compiler.h: Resorted some things into alphabetical order
9:16 AM Changeset in webkit [162764] by andersca@apple.com
  • 8 edits in trunk/Source

Get rid of BackForwardController::isActive()
https://bugs.webkit.org/show_bug.cgi?id=127604

Reviewed by Sam Weinig.

Source/WebCore:

BackForwardController::isActive() used to mean "my page maintains a back forward
list that has zero capacity". Move that logic into WebKit instead, namely the
WebFrameLoaderClient::canCachePage function so we can simplify WebCore.

  • history/BackForwardClient.h:
  • history/BackForwardController.cpp:
  • history/BackForwardController.h:
  • history/BackForwardList.h:
  • history/PageCache.cpp:

(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::canCachePage):
Move isActive logic here.

9:15 AM Changeset in webkit [162763] by Antti Koivisto
  • 3 edits
    2 adds in trunk

REGRESSION(r162744): wsj.com paints white
https://bugs.webkit.org/show_bug.cgi?id=127619

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/css/stylesheet-layout-with-pending-paint.html

  • dom/Document.cpp:

(WebCore::Document::styleResolverChanged):

Ensure we switch out from IgnoreLayoutWithPendingSheets state after stylesheet loads complete.

LayoutTests:

  • fast/css/stylesheet-layout-with-pending-paint-expected.html: Added.
  • fast/css/stylesheet-layout-with-pending-paint.html: Added.
6:19 AM Changeset in webkit [162762] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL][WK1] Fix broken rendering while navigating history in EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=127601

Reviewed by Anders Carlsson.

When scrolled after requested repaints, rendering was broken because scrollDelta
changed repaints area.

  • ewk/ewk_view.cpp:

(ewk_view_scroll):

1:07 AM WebKitGTK/2.2.x edited by vjaquez@igalia.com
(diff)

Jan 24, 2014:

11:44 PM Changeset in webkit [162761] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Reverted r162760. It broke more things.

  • WebCore.exp.in:
11:10 PM Changeset in webkit [162760] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix some 32-bit builds.

  • WebCore.exp.in:
10:40 PM Changeset in webkit [162759] by jinwoo7.song@samsung.com
  • 4 edits in trunk/Source/WebCore

[EFL] Replace usage of DEFINE_STATIC_LOCAL with NeverDestroyed in WebCore/platform/efl
https://bugs.webkit.org/show_bug.cgi?id=127607

Reviewed by Anders Carlsson.

  • platform/efl/EflKeyboardUtilities.cpp:

(WebCore::keyMap): Use NeverDestroyed instead of DEFINE_STATIC_LOCAL.
(WebCore::windowsKeyMap): Ditto.
(WebCore::keyDownCommandsMap): Ditto.
(WebCore::keyPressCommandsMap): Ditto.

  • platform/efl/GamepadsEfl.cpp:

(WebCore::sampleGamepads): Ditto.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::systemFont): Do not use unnecessary DEFINE_STATIC_LOCAL.

10:01 PM Changeset in webkit [162758] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

WebKit2 View Gestures (Smart Zoom): Can't double-tap zoom-out on the body
https://bugs.webkit.org/show_bug.cgi?id=127602

Reviewed by Anders Carlsson.

  • UIProcess/mac/ViewGestureController.h:
  • UIProcess/mac/ViewGestureController.mm:

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::didCollectGeometryForSmartMagnificationGesture):
Use an explicit boolean instead of the emptiness of the renderRect() to determine
whether or not the user has already smart-zoomed. renderRect() can be 0x0
if our hit-test hits the body element.

8:42 PM Changeset in webkit [162757] by Joseph Pecoraro
  • 30 edits
    2 copies
    5 moves
    2 adds
    1 delete in trunk/Source

Move JavaScriptCallFrame and ScriptDebugServer into JavaScriptCore for inspector
https://bugs.webkit.org/show_bug.cgi?id=127543

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add new files.

  • inspector/ScriptDebugListener.h:

Extract WebCore knowledge from ScriptDebugServer. This will
eventually be made to work outside of WebCore.

  • inspector/ScriptDebugServer.h: Renamed from Source/WebCore/bindings/js/ScriptDebugServer.h.
  • inspector/ScriptDebugServer.cpp: Renamed from Source/WebCore/bindings/js/ScriptDebugServer.cpp.

(Inspector::ScriptDebugServer::evaluateBreakpointAction):
(Inspector::ScriptDebugServer::dispatchDidPause):
(Inspector::ScriptDebugServer::dispatchBreakpointActionLog):
(Inspector::ScriptDebugServer::dispatchBreakpointActionSound):
(Inspector::ScriptDebugServer::sourceParsed):
(Inspector::ScriptDebugServer::dispatchFunctionToListeners):
(Inspector::ScriptDebugServer::handlePause):
Modernize code, and call the new ScriptDebugListener callbacks where appropriate.

  • inspector/JSJavaScriptCallFrame.cpp: Renamed from Source/WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp.

(Inspector::JSJavaScriptCallFrame::JSJavaScriptCallFrame):
(Inspector::JSJavaScriptCallFrame::finishCreation):
(Inspector::JSJavaScriptCallFrame::createPrototype):
(Inspector::JSJavaScriptCallFrame::destroy):
(Inspector::JSJavaScriptCallFrame::releaseImpl):
(Inspector::JSJavaScriptCallFrame::~JSJavaScriptCallFrame):
(Inspector::JSJavaScriptCallFrame::evaluate):
(Inspector::JSJavaScriptCallFrame::scopeType):
(Inspector::JSJavaScriptCallFrame::caller):
(Inspector::JSJavaScriptCallFrame::sourceID):
(Inspector::JSJavaScriptCallFrame::line):
(Inspector::JSJavaScriptCallFrame::column):
(Inspector::JSJavaScriptCallFrame::functionName):
(Inspector::JSJavaScriptCallFrame::scopeChain):
(Inspector::JSJavaScriptCallFrame::thisObject):
(Inspector::JSJavaScriptCallFrame::type):
(Inspector::toJS):
(Inspector::toJSJavaScriptCallFrame):

  • inspector/JSJavaScriptCallFrame.h: Added.

(Inspector::JSJavaScriptCallFrame::createStructure):
(Inspector::JSJavaScriptCallFrame::create):
(Inspector::JSJavaScriptCallFrame::impl):

  • inspector/JSJavaScriptCallFramePrototype.cpp: Added.

(Inspector::JSJavaScriptCallFramePrototype::finishCreation):
(Inspector::jsJavaScriptCallFramePrototypeFunctionEvaluate):
(Inspector::jsJavaScriptCallFramePrototypeFunctionScopeType):
(Inspector::jsJavaScriptCallFrameAttributeCaller):
(Inspector::jsJavaScriptCallFrameAttributeSourceID):
(Inspector::jsJavaScriptCallFrameAttributeLine):
(Inspector::jsJavaScriptCallFrameAttributeColumn):
(Inspector::jsJavaScriptCallFrameAttributeFunctionName):
(Inspector::jsJavaScriptCallFrameAttributeScopeChain):
(Inspector::jsJavaScriptCallFrameAttributeThisObject):
(Inspector::jsJavaScriptCallFrameAttributeType):
(Inspector::jsJavaScriptCallFrameConstantGLOBAL_SCOPE):
(Inspector::jsJavaScriptCallFrameConstantLOCAL_SCOPE):
(Inspector::jsJavaScriptCallFrameConstantWITH_SCOPE):
(Inspector::jsJavaScriptCallFrameConstantCLOSURE_SCOPE):
(Inspector::jsJavaScriptCallFrameConstantCATCH_SCOPE):

  • inspector/JSJavaScriptCallFramePrototype.h: Added.

(Inspector::JSJavaScriptCallFramePrototype::create):
(Inspector::JSJavaScriptCallFramePrototype::createStructure):
(Inspector::JSJavaScriptCallFramePrototype::JSJavaScriptCallFramePrototype):

  • inspector/JavaScriptCallFrame.cpp: Renamed from Source/WebCore/bindings/js/JavaScriptCallFrame.cpp.

(Inspector::JavaScriptCallFrame::caller):

  • inspector/JavaScriptCallFrame.h: Renamed from Source/WebCore/bindings/js/JavaScriptCallFrame.h.

Port of JavaScriptCallFrame.idl to a set of native JS classes.

Source/WebCore:

Covered by existing tests.

  • ForwardingHeaders/inspector/ScriptDebugServer.h: Added.
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • inspector/JavaScriptCallFrame.idl: Removed.

Update builds now that ScriptDebugServer moved to JavaScriptCore.

  • bindings/js/PageScriptDebugServer.h:
  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::runEventLoopWhilePaused):
(WebCore::PageScriptDebugServer::isContentScript):
(WebCore::PageScriptDebugServer::reportException):

  • bindings/js/WorkerScriptDebugServer.h:
  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
(WebCore::WorkerScriptDebugServer::reportException):
Handle ScriptDebugServer functionality depending on WebCore knowledge.

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::breakpointActionSound):
Handle ScriptDebugServer functionality that depended on WebCore knowledge.
This will eventually be written in a non-WebCore specific way.

  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorRuntimeAgent.h:

Update ScriptDebugServer type now that it is in namespace Inspector.

  • workers/WorkerGlobalScope.h:

Make addConsoleMessage public again so the inspector can call it.

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::breakpointActionLog):

  • inspector/PageDebuggerAgent.h:
  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::breakpointActionLog):

  • inspector/WorkerDebuggerAgent.h:

Let each of these handle console logs in their own way. Both of these
eventually go through the PageConsole and log through the InspectorConsoleAgent
and ChromeClient.

8:42 PM Changeset in webkit [162756] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebKit2

Fix EFL WebKit2 build.

  • WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

8:33 PM Changeset in webkit [162755] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

Improve latching behavior for wheel events
https://bugs.webkit.org/show_bug.cgi?id=127386
<rdar://problem/12176858>

Reviewed by Simon Fraser.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree): Initialize new values used for tracking
scroll latching state.
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously): Check for an existing
latched node and stay in fast scrolling mode if possible.
(WebCore::ScrollingTree::removeDestroyedNodes): Clear latched node if it's being removed.
(WebCore::ScrollingTree::latchedNode): Added
(WebCore::ScrollingTree::setLatchedNode): Added
(WebCore::ScrollingTree::clearLatchedNode): Added

  • page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::hasLatchedNode): Added

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::shouldConsiderLatching): Added
(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent): Determine latching state
based on wheel event state and position of mouse pointer in the document.

7:38 PM Changeset in webkit [162754] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix GTK+ WebKit2 build.

  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

7:25 PM Changeset in webkit [162753] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

ASSERT(time.isFinite()) in SVGSMILElement::createInstanceTimesFromSyncbase
<https://webkit.org/b/108184>

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-01-24
Reviewed by Philip Rogers.

Additional test to detect the crash in debug mode. It is merged back
from blink commit https://src.chromium.org/viewvc/blink?revision=165498&view=revision

  • svg/animations/self-dependency-crash-expected.txt: Added.
  • svg/animations/self-dependency-crash.html: Added.
7:15 PM Changeset in webkit [162752] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DebuggerCallFrame::evaluateWithCallFrame() should not execute a null executable.
<https://webkit.org/b/127600>

Reviewed by Oliver Hunt.

In DebuggerCallFrame::evaluateWithCallFrame(), if the script string that
is passed in is bad, it will fail to create an Executable i.e.
EvalExecutable::create() returns a null pointer. However,
DebuggerCallFrame::evaluateWithCallFrame() was just clearing the
exception and proceeded to execute the null pointer as an Executable.
A crash ensues.

Now, if an exception is detected while creating the Executable, we
abort instead.

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluateWithCallFrame):

7:00 PM Changeset in webkit [162751] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/gtk

GTK+ build fix.

  • webkit/webkitwebview.cpp:

(webkit_web_view_can_go_back):

6:58 PM Changeset in webkit [162750] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Another attempted build fix.

Use wildcards in the the std::duration symbol.

  • WebCore.exp.in:
6:58 PM Changeset in webkit [162749] by Alan Bujtas
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed Apple Windows port gardering.

  • platform/win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/win/tables/mozilla/marvin/body_col-expected.txt: Added.
6:32 PM Changeset in webkit [162748] by Simon Fraser
  • 9 edits in trunk/Source

Start using the RemoteScrollingCoordinatorProxy on iOS
https://bugs.webkit.org/show_bug.cgi?id=127598

Reviewed by Tim Horton.

Source/WebCore:

Add a scrollPositionChangedViaDelegatedScrolling() function to
ScrollingTree, allowing the ScrollingTree to be informed about
external sources of scrolling.

Also add a convenience getter for nodes, nodeForID().

  • WebCore.exp.in:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::scrollPositionChangedViaDelegatedScrolling):
(WebCore::ScrollingTree::nodeForID):

  • page/scrolling/ScrollingTree.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
To avoid assertions on iOS, bail from iOS WK1 fixed position code if
we have a ScrollingCoordinator.
(WebCore::RenderLayerCompositor::unregisterAllViewportConstrainedLayers):
Ditto.

Source/WebKit2:

Add a scrollPositionChangedViaDelegatedScrolling() function to
ScrollingTree, allowing the ScrollingTree to be informed about
external sources of scrolling.

Call it from -[WKContentView didScrollTo:] for the root node.

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView didScrollTo:]):

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::rootScrollingNodeID):
(WebKit::RemoteScrollingCoordinatorProxy::scrollPositionChangedViaDelegatedScrolling):

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:
6:32 PM Changeset in webkit [162747] by Simon Fraser
  • 9 edits in trunk/Source/WebCore

Add typesafe casts for ScrollingTreeNode classes
https://bugs.webkit.org/show_bug.cgi?id=127597

Reviewed by Tim Horton.

Add a ScrollingNodeType member to ScrollingTreeNodes and
use it for type-safe casting.

  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::ScrollingTreeNode):

  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::nodeType):
(WebCore::ScrollingTreeNode::scrollingNodeID):

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):

  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):

  • page/scrolling/mac/ScrollingTreeStickyNode.h:
  • page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::ScrollingTreeStickyNode):

6:11 PM Changeset in webkit [162746] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the GTK+ build.

  • GNUmakefile.list.am:
6:08 PM Changeset in webkit [162745] by andersca@apple.com
  • 19 edits in trunk/Source

Remove back/forward list related functions from Page
https://bugs.webkit.org/show_bug.cgi?id=127596

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:
  • history/BackForwardController.cpp:

(WebCore::BackForwardController::canGoBackOrForward):
(WebCore::BackForwardController::goBackOrForward):
(WebCore::BackForwardController::goBack):
(WebCore::BackForwardController::goForward):
(WebCore::BackForwardController::count):

  • page/EventHandler.cpp:

(WebCore::EventHandler::defaultBackspaceEventHandler):

  • page/Page.cpp:
  • page/Page.h:

Source/WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_navigate):
(ewk_frame_navigate_possible):

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_set_maintains_back_forward_list):
(webkit_web_view_get_back_forward_list):
(webkit_web_view_go_back):
(webkit_web_view_go_back_or_forward):
(webkit_web_view_go_forward):
(webkit_web_view_can_go_back_or_forward):
(webkit_web_view_can_go_forward):

Source/WebKit/mac:

  • WebView/WebFrameView.mm:

(-[WebFrameView keyDown:keyDown:]):

  • WebView/WebView.mm:

(-[WebView _loadBackForwardListFromOtherView:]):
(-[WebView initWithCoder:]):
(-[WebView encodeWithCoder:]):
(-[WebView backForwardList]):
(-[WebView setMaintainsBackForwardList:]):
(-[WebView goBack]):
(-[WebView goForward]):
(-[WebView canGoBack]):
(-[WebView canGoForward]):

Source/WebKit/win:

  • WebView.cpp:

(WebView::keyDown):
(WebView::goBack):
(WebView::goForward):

Source/WebKit2:

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performNonEditingBehaviorForSelector):

6:04 PM Changeset in webkit [162744] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Update style asynchronously after style sheet load
https://bugs.webkit.org/show_bug.cgi?id=127563

Reviewed by Andreas Kling.

Since we don't attach synchronously we don't need to recalc style synchronously either.

  • dom/Document.cpp:

(WebCore::Document::didRemoveAllPendingStylesheet):

6:02 PM Changeset in webkit [162743] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix attemp on the EFL after r162728.

  • CMakeLists.txt: Removed WebLoaderClient.cpp
5:34 PM Changeset in webkit [162742] by Alan Bujtas
  • 47 edits in trunk

Subpixel layout: Default style of input type=checkbox/radio (0.5ex) adds 1px extra margin on both left and right.
https://bugs.webkit.org/show_bug.cgi?id=125728

Reviewed by Simon Fraser.

Using the 0.5ex value to set checkbox/radio left and right margins is a long-standing
(khtml) behavior. While it indicates dynamic behavior, in order to get the margins changed,
the widget's font size needs to be set, which is rather rare for such input types.
It also results in odd layout, where the checkbox's indentation may seem to change randomly.

'<input style="font-size: 30px;" type="checkbox">foo' changes neither the checkbox
nor the text size, but it indents the line by about 15px.

Other browsers (FF, Opera with Presto) disagree and they set static margins values.
2px is the current default computed value.

Source/WebCore:

  • css/html.css:

(input[type="radio"], input[type="checkbox"]):

LayoutTests:

  • platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt:
  • platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt:
  • platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt:
  • platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-value-expected.txt:
  • platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac-mountainlion/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/compositing/overflow/theme-affects-visual-overflow-expected.txt:
  • platform/mac/css1/box_properties/acid_test-expected.txt:
  • platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-25-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-70-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-25-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-70-expected.txt:
  • platform/mac/fast/block/basic/011-expected.txt:
  • platform/mac/fast/block/margin-collapse/103-expected.txt:
  • platform/mac/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/mac/fast/forms/001-expected.txt:
  • platform/mac/fast/forms/basic-inputs-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/file/file-input-disabled-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/formmove-expected.txt:
  • platform/mac/fast/forms/formmove2-expected.txt:
  • platform/mac/fast/forms/indeterminate-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/inline/positionedLifetime-expected.txt:
  • platform/mac/fast/parser/bad-xml-slash-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/mac/fast/replaced/width100percent-radio-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
5:26 PM Changeset in webkit [162741] by oliver@apple.com
  • 29 edits
    3 adds in trunk

Put functions need to take a base object and a this value, and perform type checks on |this|
https://bugs.webkit.org/show_bug.cgi?id=127594

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Change the signature for static setter functions, and update uses

  • create_hash_table:
  • runtime/Lookup.h:

(JSC::putEntry):

  • runtime/PutPropertySlot.h:
  • runtime/RegExpConstructor.cpp:

(JSC::setRegExpConstructorInput):
(JSC::setRegExpConstructorMultiline):

Source/WebCore:

Update bindings generator to emit setters with correct type, and perform
type checks on |this|, instead of the baseObject.

Test: js/dom/dom-as-prototype-assignment-exception.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateHashTable):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::setJSTestInterfaceConstructorImplementsStaticAttr):
(WebCore::setJSTestInterfaceImplementsStr2):
(WebCore::setJSTestInterfaceImplementsStr3):
(WebCore::setJSTestInterfaceImplementsNode):
(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalNode):

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
  • bindings/scripts/test/JS/JSTestNode.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjConstructorStaticStringAttr):
(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjEnumAttr):
(WebCore::setJSTestObjByteAttr):
(WebCore::setJSTestObjOctetAttr):
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjTypedArrayAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjCustomAttr):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjAnyAttribute):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjStrictFloat):
(WebCore::setJSTestObjId):
(WebCore::setJSTestObjReplaceableAttribute):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):
(WebCore::setJSTestObjAttributeWithReservedEnumType):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsImmutableSerializedScriptValue):
(WebCore::setJSTestTypedefsAttrWithGetterException):
(WebCore::setJSTestTypedefsAttrWithSetterException):
(WebCore::setJSTestTypedefsStringAttrWithGetterException):
(WebCore::setJSTestTypedefsStringAttrWithSetterException):

  • bindings/scripts/test/JS/JSTestTypedefs.h:
  • bindings/scripts/test/JS/JSattribute.cpp:
  • bindings/scripts/test/JS/JSreadonly.cpp:

LayoutTests:

Add tests, and update expectation for previously failing test.

  • js/dom/dom-as-prototype-assignment-exception-expected.txt: Added.
  • js/dom/dom-as-prototype-assignment-exception.html: Added.
  • js/dom/script-tests/dom-as-prototype-assignment-exception.js: Added.
  • media/network-no-source-const-shadow-expected.txt:
5:03 PM Changeset in webkit [162740] by oliver@apple.com
  • 53 edits
    3 adds in trunk

Generic JSObject::put should handle static properties in the classinfo hierarchy
https://bugs.webkit.org/show_bug.cgi?id=127523

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch makes JSObject::put correctly call static setters
defined by the ClassInfo.

To make this not clobber performance, the ClassInfo HashTable
now includes a flag to indicate that it contains setters. This
required updating the lut generator so that it tracked (and emitted)
this.

The rest of the change was making a number of the methods take
a VM rather than an ExecState*, so that Structure could set the
getter/setter flags during construction (if necessary).

This also means most objects do not need to perform a lookupPut
manually anymore, so most custom ::put's are no longer needed.
DOMWindow is the only exception as it has interesting security
related semantics.

  • create_hash_table:
  • interpreter/CallFrame.h:

(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dataViewTable):
(JSC::ExecState::dateTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::jsonTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectConstructorTable):
(JSC::ExecState::privateNamePrototypeTable):
(JSC::ExecState::regExpTable):
(JSC::ExecState::regExpConstructorTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable):
(JSC::ExecState::promisePrototypeTable):
(JSC::ExecState::promiseConstructorTable):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlot):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):

  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):

  • runtime/ClassInfo.h:

(JSC::ClassInfo::propHashTable):

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):

  • runtime/JSDataViewPrototype.cpp:

(JSC::JSDataViewPrototype::getOwnPropertySlot):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertySlot):

  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):

  • runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::getOwnPropertySlot):

  • runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::getOwnPropertySlot):

  • runtime/Lookup.h:

(JSC::HashTable::copy):
(JSC::putEntry):
(JSC::lookupPut):

  • runtime/NamePrototype.cpp:

(JSC::NamePrototype::getOwnPropertySlot):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):

  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::put):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::freezeTransition):
(JSC::ClassInfo::hasStaticSetterOrReadonlyProperties):

Source/WebCore:

Update the bindings generator to emit the flag indicating the presence
of setters, and remove the many (now unnecessary) put overrides.
Tested with run-jsc-benchmarks and shows neutral performance. A few of the
micro benchmarks actually get a significant performance increase which
is nice.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::put):

We still need a custom call to lookupPut here in order
to get the magic security semantics of the window object.

  • bindings/scripts/CodeGeneratorJS.pm:

(hashTableAccessor):
(prototypeHashTableAccessor):
(constructorHashTableAccessor):
(GenerateImplementation):
(GenerateHashTable):
(GenerateConstructorHelperMethods):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::put):

  • bindings/scripts/CodeGeneratorJS.pm:

(hashTableAccessor):
(prototypeHashTableAccessor):
(constructorHashTableAccessor):
(InstanceOverridesPutImplementation):
(InstanceOverridesPutDeclaration):
(GenerateHeader):
(GenerateImplementation):
(GenerateHashTable):
(GenerateConstructorHelperMethods):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::put):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
  • bindings/scripts/test/JS/JSTestNode.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.h:
  • bindings/scripts/test/JS/JSattribute.cpp:
  • bindings/scripts/test/JS/JSreadonly.cpp:
  • html/canvas/WebGLRenderingContext.idl: Remove bogus attribute, as it has never been in the spec and should not have been added.

LayoutTests:

Yay tests!

  • fast/canvas/webgl/constants.html: Remove incorrect constant
  • js/script-tests/static-put-in-prototype-chain.js: Added.
  • js/static-put-in-prototype-chain-expected.txt: Added.
  • js/static-put-in-prototype-chain.html: Added.
4:59 PM Changeset in webkit [162739] by fpizlo@apple.com
  • 5 edits
    2 adds in branches/jsCStack/Source/JavaScriptCore

DFG should allow inlining of op_call_varargs calls
https://bugs.webkit.org/show_bug.cgi?id=127538

Reviewed by Michael Saboff and Mark Hahnenberg.

Previously, op_call_varargs was directly lowered to a Call by the ByteCodeParser and
we bypassed all of the call optimizations (intrinsics, inlining) provided by
ByteCodeParser::handleCall().

This changes op_call_varargs handling so that it first sets up the stack to look like
it would have if it had been a normal call, and then it calls handleCall(). This
gives us inlining of op_call_varargs.

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):

  • bytecode/CodeOrigin.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isLiveInBytecode):

  • tests/stress/inline-call-varargs-and-call.js: Added.

(foo):
(bar):
(baz):

  • tests/stress/inline-call-varargs.js: Added.

(foo):
(bar):
(baz):

4:52 PM Changeset in webkit [162738] by commit-queue@webkit.org
  • 53 edits
    3 deletes in trunk

Unreviewed, rolling out r162713.
http://trac.webkit.org/changeset/162713
https://bugs.webkit.org/show_bug.cgi?id=127593

broke media/network-no-source-const-shadow (Requested by
thorton on #webkit).

Source/JavaScriptCore:

  • create_hash_table:
  • interpreter/CallFrame.h:

(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dataViewTable):
(JSC::ExecState::dateTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::jsonTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectConstructorTable):
(JSC::ExecState::privateNamePrototypeTable):
(JSC::ExecState::regExpTable):
(JSC::ExecState::regExpConstructorTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable):
(JSC::ExecState::promisePrototypeTable):
(JSC::ExecState::promiseConstructorTable):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlot):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):

  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):

  • runtime/ClassInfo.h:

(JSC::ClassInfo::propHashTable):

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):

  • runtime/JSDataViewPrototype.cpp:

(JSC::JSDataViewPrototype::getOwnPropertySlot):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertySlot):

  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):

  • runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::getOwnPropertySlot):

  • runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::getOwnPropertySlot):

  • runtime/Lookup.h:

(JSC::HashTable::copy):
(JSC::putEntry):
(JSC::lookupPut):

  • runtime/NamePrototype.cpp:

(JSC::NamePrototype::getOwnPropertySlot):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::put):

  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::RegExpConstructor::put):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::put):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::freezeTransition):

Source/WebCore:

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::put):

  • bindings/scripts/CodeGeneratorJS.pm:

(hashTableAccessor):
(prototypeHashTableAccessor):
(constructorHashTableAccessor):
(GenerateHeader):
(GenerateImplementation):
(GenerateHashTable):
(GenerateConstructorHelperMethods):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::put):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
  • bindings/scripts/test/JS/JSTestNode.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::put):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::put):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefs::put):

  • bindings/scripts/test/JS/JSTestTypedefs.h:
  • bindings/scripts/test/JS/JSattribute.cpp:
  • bindings/scripts/test/JS/JSreadonly.cpp:
  • html/canvas/WebGLRenderingContext.idl:

LayoutTests:

  • fast/canvas/webgl/constants.html:
  • js/script-tests/static-put-in-prototype-chain.js: Removed.
  • js/static-put-in-prototype-chain-expected.txt: Removed.
  • js/static-put-in-prototype-chain.html: Removed.
4:21 PM Changeset in webkit [162737] by Alan Bujtas
  • 8 edits in trunk/Source/WebCore

Replace LayoutUnit() calls to a more descriptive LayoutUnit::fromPixel(int).
https://bugs.webkit.org/show_bug.cgi?id=127580

Reviewed by Simon Fraser.

LayoutUnit(1) statement is ambiguous. While it is intended to set one (CSS) pixel, it
could be interpreted as 1 layout unit (1/64th of a CSS pixel atm).

No change in behavior.

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForRegionHighlight):

  • rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatTypeValue>::heightRemaining):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutShapeInsideInfo):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::collapseMargins):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::alignChildren):

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::addForcedRegionBreak):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset):
(WebCore::RenderMultiColumnSet::calculateBalancedHeight):

4:04 PM Changeset in webkit [162736] by Simon Fraser
  • 17 edits in trunk/Source

Prepare scrolling tree to handle > 1 scrolling node
https://bugs.webkit.org/show_bug.cgi?id=127590

Source/WebCore:

Reviewed by Tim Horton.

Clean up the code path called after the ScrollingTree has scrolled a node,
to prepare for multiple scrolling nodes.

Change "updateMainFrameScrollPosition" terminology to "updateScrollPositionAfterAsyncScroll",
and pass along the ScrollingNodeID that scrolled.

Move updateMainFrameScrollPosition-related code from ScrollingCoordinator to
AsyncScrollingCoordinator, since this sync-up is only necessary when doing
async scrolling.

  • WebCore.exp.in:
  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::AsyncScrollingCoordinator):
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::AsyncScrollingCoordinator::scheduleUpdateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScrollTimerFired):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):

  • page/scrolling/AsyncScrollingCoordinator.h:

(WebCore::AsyncScrollingCoordinator::ScheduledScrollUpdate::ScheduledScrollUpdate):
(WebCore::AsyncScrollingCoordinator::ScheduledScrollUpdate::matchesUpdateType):
Package up the data related to a scheduled scroll into a ScheduledScrollUpdate struct,
for easier comparison and cleaner code.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator):

  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingTree.h:
  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):

  • page/scrolling/ThreadedScrollingTree.h:
  • page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::scrollingTreeNodeDidScroll):

  • page/scrolling/ios/ScrollingTreeIOS.h:
  • page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm:

(WebCore::ScrollingTreeScrollingNodeIOS::setScrollPositionWithoutContentEdgeConstraints):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::setScrollPositionWithoutContentEdgeConstraints):

Source/WebKit2:

Reviewed by Tim Horton.

Clean up the code path called after the ScrollingTree has scrolled a node,
to prepare for multiple scrolling nodes.

Change "updateMainFrameScrollPosition" terminology to "updateScrollPositionAfterAsyncScroll",
and pass along the ScrollingNodeID that scrolled.

  • UIProcess/Scrolling/RemoteScrollingTree.cpp:

(WebKit::RemoteScrollingTree::scrollingTreeNodeDidScroll):

  • UIProcess/Scrolling/RemoteScrollingTree.h:
  • WebProcess/Scrolling/RemoteScrollingCoordinator.mm:

(WebKit::RemoteScrollingCoordinator::scrollPositionChangedForNode):

3:44 PM Changeset in webkit [162735] by mark.lam@apple.com
  • 7 edits in trunk/Source

ASSERT(!m_markedSpace.m_currentDelayedReleaseScope) reloading page in inspector.
<https://webkit.org/b/127582>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  1. We should not enter a HeapIterationScope when we iterate the CodeBlocks. Apparently, iterating the CodeBlocks does not count as heap iteration.
  1. If we're detaching the debugger due to the JSGlobalObject destructing, then we don't need to clear the debugger requests in the associated CodeBlocks. The JSGlobalObject destructing would mean that those CodeBlocks would be destructing too, and it may not be safe to access them anyway at this point.

The assertion failure is because we had entered a HeapIterationScope
while the JSGlobalObject is destructing, which in turn means that GC
sweeping is in progress. It's not legal to iterate the heap while the GC
is sweeping. Once we fixed the above 2 issues, we will no longer have
the conditions that manifests this assertion failure.

  • debugger/Debugger.cpp:

(JSC::Debugger::detach):
(JSC::Debugger::setSteppingMode):
(JSC::Debugger::toggleBreakpoint):
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::clearDebuggerRequests):

  • debugger/Debugger.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::~JSGlobalObject):

Source/WebCore:

No new tests.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::attachDebugger):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::detachDebugger):

  • Adding reasons for detaching a globalObject from the debugger.
3:39 PM Changeset in webkit [162734] by mhahnenberg@apple.com
  • 263 edits
    42 adds
    951 deletes in branches/jsCStack

Merge branch up to ToT r162711.

3:38 PM Changeset in webkit [162733] by eric.carlson@apple.com
  • 3 edits in trunk/Tools

Unreviewed. Add Philip Jägenstedt to watch and contributor lists.

  • Scripts/webkitpy/common/config/contributors.json:
  • Scripts/webkitpy/common/config/watchlist:
3:35 PM Changeset in webkit [162732] by Alan Bujtas
  • 13 edits in trunk/Source/WebCore

Subpixel rendering: Make PaintInfo layout unit aware.
https://bugs.webkit.org/show_bug.cgi?id=127562

Reviewed by Simon Fraser.

Replace PaintInfo's IntRect with LayoutRect to be able to render to
subpixel positions.

No functional changes.

  • platform/graphics/LayoutRect.h:
  • rendering/PaintInfo.h:

(WebCore::PaintInfo::PaintInfo):
(WebCore::PaintInfo::applyTransform):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderLayer.cpp:

(WebCore::cornerRect):
(WebCore::RenderLayer::scrollCornerRect):
(WebCore::resizerCornerRect):
(WebCore::RenderLayer::scrollCornerAndResizerRect):
(WebCore::RenderLayer::horizontalScrollbarStart):
(WebCore::RenderLayer::drawPlatformResizerImage):
(WebCore::RenderLayer::paintResizer):
(WebCore::RenderLayer::hitTestOverflowControls):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintScrollbar):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paintContents):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::fillWithExtensionGlyph):

  • rendering/svg/SVGRenderingContext.h:
3:29 PM Changeset in webkit [162731] by Simon Fraser
  • 8 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=127583

Reviewed by Tim Horton.

handleWheelEventPhase() doesn't make any sense for iOS, which
has no wheel events.

Source/WebCore:

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/ThreadedScrollingTree.cpp:
  • page/scrolling/ThreadedScrollingTree.h:
  • page/scrolling/ios/ScrollingTreeIOS.h:

Source/WebKit2:

  • UIProcess/Scrolling/RemoteScrollingTree.cpp:
  • UIProcess/Scrolling/RemoteScrollingTree.h:
3:29 PM Changeset in webkit [162730] by Simon Fraser
  • 9 edits in trunk/Source/WebKit2

Push a custom fixed position rect down to the WebProcess in iOS WK2
https://bugs.webkit.org/show_bug.cgi?id=127573

Reviewed by Tim Horton.

Make it possible for WKContentView to specify a custom rect
used to layout fixed position elements on iOS.

This is computed in WKContentView, and pushed down
through the RemoteLayerTreeDrawingArea, and eventually
pushed onto FrameView.

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView fixedPositionRectFromExposedRect:scale:]):
(-[WKContentView _updateFixedPositionRect]):
(-[WKContentView didFinishScrollTo:]):
(-[WKContentView didZoomToScale:]):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::setCustomFixedPositionRect):

  • UIProcess/DrawingAreaProxy.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::setCustomFixedPositionRect):

3:20 PM Changeset in webkit [162729] by dfarler@apple.com
  • 13 edits
    6 copies
    21 adds in trunk/Tools

Make WebKitTestRunner work with iOS
https://bugs.webkit.org/show_bug.cgi?id=127448

Reviewed by Simon Fraser.

Combined patch from Simon below with some additional xcconfig cleanups,
rebasing and stubbing out a couple of new functions that popped up
since then.

2013-12-03 Simon Fraser <Simon Fraser>

<rdar://problem/15515469> Get WebKitTestRunner working on iOS

Get WebKitTestRunner limping on iOS. Main parts:

  • Stub out lots of accessibility-related functions.
  • Stub out EventSender
  • Create target to make a bundled app that runs in the simulator, and copy the injected bundle library into it.
  • Make a UIWindow and WKView to load tests in

It runs, load tests, and dumps results to output. More work will be
required once we can execute it via the webkitpy scripts.

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  • WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.

(WTR::AccessibilityController::addNotificationListener):
(WTR::AccessibilityController::removeNotificationListener):
(WTR::AccessibilityController::platformName):
(WTR::AccessibilityController::logAccessibilityEvents):
(WTR::AccessibilityController::resetToConsistentState):
(WTR::findAccessibleObjectById):
(WTR::AccessibilityController::accessibleElementById):

  • WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
  • WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.

(WTR::AccessibilityTextMarker::isEqual):

  • WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.

(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::AccessibilityUIElement::getLinkedUIElements):
(WTR::AccessibilityUIElement::getDocumentLinks):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::rowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::isPressActionSupported):
(WTR::AccessibilityUIElement::isIncrementActionSupported):
(WTR::AccessibilityUIElement::isDecrementActionSupported):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isSelectedOptionActive):
(WTR::AccessibilityUIElement::isIndeterminate):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::hierarchicalLevel):
(WTR::AccessibilityUIElement::classList):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::ariaIsGrabbed):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::scrollToMakeVisible):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild):
(WTR::AccessibilityUIElement::accessibilityValue):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::isVisible):
(WTR::AccessibilityUIElement::isOffScreen):
(WTR::AccessibilityUIElement::isCollapsed):
(WTR::AccessibilityUIElement::isIgnored):
(WTR::AccessibilityUIElement::hasPopup):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR::AccessibilityUIElement::startTextMarker):
(WTR::AccessibilityUIElement::endTextMarker):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):
(WTR::AccessibilityUIElement::pathDescription):
(WTR::AccessibilityUIElement::supportedActions):

  • WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.

(WTR::activateFonts):

  • WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::~EventSenderProxy):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::continuousMouseScrollBy):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::setTouchPointRadius):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::touchCancel):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::cancelTouchPoint):

  • WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.

(WTR::InjectedBundle::platformInitialize):

  • WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.

(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):

  • WebKitTestRunner/Makefile:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
  • WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.

(-[AppDelegate application:didFinishLaunchingWithOptions:]):
(-[AppDelegate applicationWillResignActive:]):
(-[AppDelegate applicationDidEnterBackground:]):
(-[AppDelegate applicationWillEnterForeground:]):
(-[AppDelegate applicationDidBecomeActive:]):
(-[AppDelegate applicationWillTerminate:]):

  • WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
  • WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
  • WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
  • WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
  • WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
  • WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.

(main):

  • WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
  • WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
  • WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.

(-[WebKitTestRunnerAppTests setUp]):
(-[WebKitTestRunnerAppTests tearDown]):
(-[WebKitTestRunnerAppTests testExample]):

  • WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
  • WebKitTestRunner/WebKitTestRunnerPrefix.h:
  • WebKitTestRunner/cg/TestInvocationCG.cpp:
  • WebKitTestRunner/iOS.xcconfig: Added.
  • WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.

(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
(-[TestRunnerWKView _shouldUseTiledDrawingArea]):
(-[WebKitTestRunnerWindow isKeyWindow]):
(-[WebKitTestRunnerWindow setFrameOrigin:]):
(-[WebKitTestRunnerWindow setFrame:]):
(-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
(-[WebKitTestRunnerWindow backingScaleFactor]):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
(WTR::PlatformWebView::didInitializeClients):
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):
(WTR::PlatformWebView::windowSnapshotImage):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/ios/TestControllerIOS.mm: Added.

(WTR::TestController::notifyDone):
(WTR::TestController::platformInitialize):
(WTR::TestController::platformDestroy):
(WTR::TestController::initializeInjectedBundlePath):
(WTR::TestController::initializeTestPluginDirectory):
(WTR::TestController::platformRunUntil):
(WTR::TestController::platformInitializeContext):
(WTR::TestController::runModal):
(WTR::TestController::platformLibraryPathForTesting):

  • WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.

(createCFURLResponseFromResponseData):
(supportedNonImageMIMETypes):

  • WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.

(-[WebKitTestRunnerApp _runTestController]):
(-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
(main):

3:14 PM Changeset in webkit [162728] by andersca@apple.com
  • 5 edits
    2 deletes in trunk/Source/WebKit2

Get rid of WebLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=127587

Reviewed by Andreas Kling.

Move WebLoaderClient into WKPage.cpp.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController setLoadDelegate:]):

  • UIProcess/WebLoaderClient.cpp: Removed.
  • UIProcess/WebLoaderClient.h: Removed.
  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
3:05 PM Changeset in webkit [162727] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

IDB: Support createIndex/deleteIndex
<rdar://problem/15779642> and https://bugs.webkit.org/show_bug.cgi?id=127585

Reviewed by Tim Horton.

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::createIndex):
(WebKit::UniqueIDBDatabase::deleteIndex):
(WebKit::UniqueIDBDatabase::createIndexInBackingStore):
(WebKit::UniqueIDBDatabase::deleteIndexInBackingStore):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteObjectStore): Also drop all associated indexes.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteIndex):

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
2:52 PM Changeset in webkit [162726] by hyatt@apple.com
  • 11 edits in trunk/Source/WebCore

[New Multicolumn] Don't destroy all the renderers when a multi-column block stops being multi-column (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=127584

Make the logic for when you need columns and when you don't shared between the
old multi-column code and the new multi-column code. Make sure that the flow thread
and sets get created lazily and destroyed on-demand when whether or not we should
have multiple columns changes.

Reviewed by Beth Dakin.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateLogicalWidthAndColumnWidth):
No longer virtual. The new column code now uses this function too.

(WebCore::RenderBlock::availableLogicalWidth):
Renamed desiredColumnWidth() to computedColumnWidth().

(WebCore::RenderBlock::computeColumnCountAndWidth):
Renamed calcColumnWidth to computeColumnCountAndWidth.

(WebCore::RenderBlock::setComputedColumnCountAndWidth):
Rename setDesiredColumnCountAndWidth to computed.

(WebCore::RenderBlock::computedColumnWidth):
(WebCore::RenderBlock::computedColumnCount):
Renamed desiredColumnWidth/Count to computedColumnWidth/Count and made them virtual.

(WebCore::RenderBlock::updateFirstLetterStyle):
desired -> computed rename.

  • rendering/RenderBlock.h:

Renames and made a few functions virtual so that RenderBlockFlow can override.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::RenderBlockFlow):
Don't create the flow thread at construction time any longer.

(WebCore::RenderBlockFlow::createMultiColumnFlowThread):
(WebCore::RenderBlockFlow::destroyMultiColumnFlowThread):
The methods to create and destroy flow threads. These work at any time now and will
fix up the render tree accordingly.

(WebCore::RenderBlockFlow::setComputedColumnCountAndWidth):
Virtual override that creates/destroys the new multi-column information as needed.

(WebCore::RenderBlockFlow::computedColumnWidth):
(WebCore::RenderBlockFlow::computedColumnCount):
Overrides to return the cached column width and count from the flow thread.

  • rendering/RenderBlockFlow.h:

Has overrides of the virtual functions needed to turn multi-column state on/off and
to hand back computed count/width information.

  • rendering/RenderMultiColumnFlowThread.cpp:
  • rendering/RenderMultiColumnFlowThread.h:

Removed the algorithm to compute column count and width, since this has been combined
with the old multi-column layout code.

  • rendering/RenderView.cpp:

(WebCore::RenderView::computeColumnCountAndWidth):
Renamed desired -> computed.

  • rendering/RenderView.h:

Renamed desired -> computed.

  • style/StyleResolveTree.cpp:

(WebCore::Style::determineChange):
(WebCore::Style::resolveLocal):
(WebCore::Style::resolveTree):

  • style/StyleResolveTree.h:

The Settings argument is no longer needed now that we don't destroy and re-create
the renderer for a block flow if it stops being (or becomes) multi-column.

2:29 PM Changeset in webkit [162725] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix 32-bit build.

  • WebCore.exp.in:
2:05 PM Changeset in webkit [162724] by vjaquez@igalia.com
  • 3 edits in trunk/Source/WebKit2

[GTK] youtube HTML5 videos in fullscreen, after <Esc>, can't go fullscreen again
https://bugs.webkit.org/show_bug.cgi?id=127064

When pressing <Esc> or <f> at full screen, the WebView shall emit the
event webkitfullscreenchange, but wk2gtk does not emit it. This is
because the WebView manages directly the exit of the full screen.

With this patch the WebView calls requestExitFullScreen to the full
screen manager, instead of managing directly the exit of the full
screen, and the event webkitfullscreenchange will be dispatched
correctly.

Reviewed by Martin Robinson.

No tests are included because there is a bug in WKTR that prevents the
execution of a test for this patch. See
https://bugs.webkit.org/show_bug.cgi?id=127348

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseKeyPressEvent): Call
webkitWebViewBaseRequestExitFullScreen.
(webkitWebViewBaseRequestExitFullScreen): Added.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Ditto.
2:01 PM Changeset in webkit [162723] by Brent Fulgham
  • 3 edits
    3 adds
    3 deletes in trunk/Source

[Win] Convert some NMake files to MSBuild project files
https://bugs.webkit.org/show_bug.cgi?id=127579

Reviewed by Tim Horton.

../JavaScriptCore:

../WebCore:

  • WebCore.vcxproj/WebCore.make: Removed.
  • WebCore.vcxproj/WebCore.proj: Added.

../WTF:

  • WTF.vcxproj/WTF.make: Removed.
  • WTF.vcxproj/WTF.proj: Added.
1:46 PM Changeset in webkit [162722] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixed a bad assertion in CodeBlock::removeBreakpoint().
<https://webkit.org/b/127581>

Reviewed by Joseph Pecoraro.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::removeBreakpoint):

1:28 PM Changeset in webkit [162721] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS build fix after r162710.

This is why these sorts of comments are bad.

  • UIProcess/WebPageProxy.cpp:
1:27 PM Changeset in webkit [162720] by Joseph Pecoraro
  • 6 edits in trunk/Source

fast/profiler tests ASSERTing after moving recompileAllJSFunctions off a timer
https://bugs.webkit.org/show_bug.cgi?id=127566

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Make the VM handle recompilation as soon as possible after it is requested.

  • debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions):
When in a JavaScript stack, mark for recompilation when possible.

  • runtime/VMEntryScope.h:

(JSC::VMEntryScope::setRecompilationNeeded):

  • runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):
Handle recompilation when the top VMEntryScope is popped.
Pass the needs recompilation flag up the stack if needed.

Source/WebCore:

Covered by existing tests.

  • testing/Internals.cpp:

(WebCore::Internals::closeDummyInspectorFrontend):
Now that we don't have to fake that this is a page being destroyed to
avoid recompilation. Use the InspectorDestroyed reason.

1:25 PM Changeset in webkit [162719] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Use a side table to map WebPageProxy objects to WKBrowsingContextController objects
https://bugs.webkit.org/show_bug.cgi?id=127577

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(browsingContextControllerMap):
(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController _initWithPageRef:]):
(+[WKBrowsingContextController _browsingContextControllerForPageRef:]):

  • UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:
  • UIProcess/WebPageProxy.h:
1:23 PM Changeset in webkit [162718] by mark.lam@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Generic JSObject::put should handle static properties in the classinfo hierarchy
https://bugs.webkit.org/show_bug.cgi?id=127523

Patch by Oliver Hunt <oliver@apple.com> on 2014-01-24
Reviewed by Geoffrey Garen.

This patch makes JSObject::put correctly call static setters
defined by the ClassInfo.

To make this not clobber performance, the ClassInfo HashTable
now includes a flag to indicate that it contains setters. This
required updating the lut generator so that it tracked (and emitted)
this.

The rest of the change was making a number of the methods take
a VM rather than an ExecState*, so that Structure could set the
getter/setter flags during construction (if necessary).

This also means most objects do not need to perform a lookupPut
manually anymore, so most custom ::put's are no longer needed.
DOMWindow is the only exception as it has interesting security
related semantics.

  • create_hash_table:
  • interpreter/CallFrame.h:

(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dataViewTable):
(JSC::ExecState::dateTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::jsonTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectConstructorTable):
(JSC::ExecState::privateNamePrototypeTable):
(JSC::ExecState::regExpTable):
(JSC::ExecState::regExpConstructorTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable):
(JSC::ExecState::promisePrototypeTable):
(JSC::ExecState::promiseConstructorTable):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlot):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):

  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):

  • runtime/ClassInfo.h:

(JSC::ClassInfo::propHashTable):

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):

  • runtime/JSDataViewPrototype.cpp:

(JSC::JSDataViewPrototype::getOwnPropertySlot):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertySlot):

  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):

  • runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::getOwnPropertySlot):

  • runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::getOwnPropertySlot):

  • runtime/Lookup.h:

(JSC::HashTable::copy):
(JSC::putEntry):
(JSC::lookupPut):

  • runtime/NamePrototype.cpp:

(JSC::NamePrototype::getOwnPropertySlot):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):

  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::put):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::freezeTransition):
(JSC::ClassInfo::hasStaticSetterOrReadonlyProperties):

1:19 PM Changeset in webkit [162717] by fpizlo@apple.com
  • 3 edits
    2 adds in branches/jsCStack/Source/JavaScriptCore

PutByIdDirect in FTL
https://bugs.webkit.org/show_bug.cgi?id=127442

Patch by Matthew Mirman <mmirman@apple.com> on 2014-01-24
Reviewed by Filip Pizlo.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):

  • tests/stress/ftl-putbyid.js: Added.
  • tests/stress/ftl-putbyiddirect.js: Added.

(foo):

12:41 PM Changeset in webkit [162716] by andersca@apple.com
  • 16 edits in trunk/Source

Get rid of monotonicallyIncreasingTimeMS and start using std::chrono instead
https://bugs.webkit.org/show_bug.cgi?id=127571

Reviewed by Antti Koivisto.

Source/WebCore:

WebCore.exp.in:
Update symbols.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::implicitClose):
(WebCore::Document::setParsing):
(WebCore::Document::isLayoutTimerActive):
(WebCore::Document::minimumLayoutDelay):
(WebCore::Document::elapsedTime):
(WebCore::Document::write):
(WebCore::Document::styleResolverChanged):

  • dom/Document.h:

Use std::chrono instead of doubles for the times and durations.

  • fileapi/FileReader.cpp:

(WebCore::FileReader::FileReader):
(WebCore::FileReader::didReceiveData):

  • fileapi/FileReader.h:

Switch over to std::chrono.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::layoutTimerFired):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
Update for Document::elapsedTime() changes.

  • page/Settings.cpp:

(WebCore::Settings::setLayoutInterval):

  • page/Settings.h:

(WebCore::Settings::layoutInterval):
Change layoutInterval to be std::chrono::milliseconds instead of int.

  • platform/Timer.h:

(WebCore::TimerBase::startOneShot):
Add an overload that takes std::chrono::milliseconds.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Convert the layout interval to std::chrono::milliseconds.

Source/WTF:

  • wtf/Compiler.h:

Add a CONSTEXPR define so we can still use constexpr on compilers that don't support them (MSVC).

  • wtf/CurrentTime.h:

Remove monotonicallyIncreasingTimeMS().

  • wtf/StdLibExtras.h:

(std::literals::chrono_literals::operator _s):
(std::literals::chrono_literals::operator _ms):
Add _s and _ms literals. Once we switch over to C++14, we can drop them and just use the built-in ones.

12:27 PM Changeset in webkit [162715] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

iOS build fix after r162710.

  • UIProcess/API/ios/PageClientImplIOS.h:
  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::takeViewSnapshot):

12:06 PM Changeset in webkit [162714] by commit-queue@webkit.org
  • 7 edits in trunk

[GTK] Put cache files in XDG_CACHE_HOME
https://bugs.webkit.org/show_bug.cgi?id=123458

Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-01-24
Reviewed by Martin Robinson.

Source/WebKit/gtk:

  • webkit/webkitglobals.cpp:

(webkitInit):

  • webkit/webkiticondatabase.cpp:

Source/WebKit2:

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultIconDatabasePath):

Tools:

  • GtkLauncher/main.c:

(createBrowser):

12:03 PM Changeset in webkit [162713] by oliver@apple.com
  • 53 edits
    3 adds in trunk

Generic JSObject::put should handle static properties in the classinfo hierarchy
https://bugs.webkit.org/show_bug.cgi?id=127523

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch makes JSObject::put correctly call static setters
defined by the ClassInfo.

To make this not clobber performance, the ClassInfo HashTable
now includes a flag to indicate that it contains setters. This
required updating the lut generator so that it tracked (and emitted)
this.

The rest of the change was making a number of the methods take
a VM rather than an ExecState*, so that Structure could set the
getter/setter flags during construction (if necessary).

This also means most objects do not need to perform a lookupPut
manually anymore, so most custom ::put's are no longer needed.
DOMWindow is the only exception as it has interesting security
related semantics.

  • create_hash_table:
  • interpreter/CallFrame.h:

(JSC::ExecState::arrayConstructorTable):
(JSC::ExecState::arrayPrototypeTable):
(JSC::ExecState::booleanPrototypeTable):
(JSC::ExecState::dataViewTable):
(JSC::ExecState::dateTable):
(JSC::ExecState::dateConstructorTable):
(JSC::ExecState::errorPrototypeTable):
(JSC::ExecState::globalObjectTable):
(JSC::ExecState::jsonTable):
(JSC::ExecState::numberConstructorTable):
(JSC::ExecState::numberPrototypeTable):
(JSC::ExecState::objectConstructorTable):
(JSC::ExecState::privateNamePrototypeTable):
(JSC::ExecState::regExpTable):
(JSC::ExecState::regExpConstructorTable):
(JSC::ExecState::regExpPrototypeTable):
(JSC::ExecState::stringConstructorTable):
(JSC::ExecState::promisePrototypeTable):
(JSC::ExecState::promiseConstructorTable):

  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlot):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):

  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):

  • runtime/ClassInfo.h:

(JSC::ClassInfo::propHashTable):

  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):

  • runtime/JSDataViewPrototype.cpp:

(JSC::JSDataViewPrototype::getOwnPropertySlot):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertySlot):

  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):

  • runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::getOwnPropertySlot):

  • runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::getOwnPropertySlot):

  • runtime/Lookup.h:

(JSC::HashTable::copy):
(JSC::putEntry):
(JSC::lookupPut):

  • runtime/NamePrototype.cpp:

(JSC::NamePrototype::getOwnPropertySlot):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):

  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):

  • runtime/RegExpConstructor.h:
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::put):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::freezeTransition):
(JSC::ClassInfo::hasStaticSetterOrReadonlyProperties):

Source/WebCore:

Update the bindings generator to emit the flag indicating the presence
of setters, and remove the many (now unnecessary) put overrides.
Tested with run-jsc-benchmarks and shows neutral performance. A few of the
micro benchmarks actually get a significant performance increase which
is nice.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::put):

We still need a custom call to lookupPut here in order
to get the magic security semantics of the window object.

  • bindings/scripts/CodeGeneratorJS.pm:

(hashTableAccessor):
(prototypeHashTableAccessor):
(constructorHashTableAccessor):
(GenerateImplementation):
(GenerateHashTable):
(GenerateConstructorHelperMethods):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::put):

  • bindings/scripts/CodeGeneratorJS.pm:

(hashTableAccessor):
(prototypeHashTableAccessor):
(constructorHashTableAccessor):
(InstanceOverridesPutImplementation):
(InstanceOverridesPutDeclaration):
(GenerateHeader):
(GenerateImplementation):
(GenerateHashTable):
(GenerateConstructorHelperMethods):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::put):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
  • bindings/scripts/test/JS/JSTestNode.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.h:
  • bindings/scripts/test/JS/JSattribute.cpp:
  • bindings/scripts/test/JS/JSreadonly.cpp:
  • html/canvas/WebGLRenderingContext.idl: Remove bogus attribute, as it has never been in the spec and should not have been added.

LayoutTests:

Yay tests!

  • fast/canvas/webgl/constants.html: Remove incorrect constant
  • js/script-tests/static-put-in-prototype-chain.js: Added.
  • js/static-put-in-prototype-chain-expected.txt: Added.
  • js/static-put-in-prototype-chain.html: Added.
11:55 AM Changeset in webkit [162712] by hyatt@apple.com
  • 17 edits
    2 deletes in trunk/Source/WebCore

[New Multicolumn] Eliminate RenderMultiColumnBlock
https://bugs.webkit.org/show_bug.cgi?id=127565

Reviewed by Antti Koivisto.

This patch eliminates RenderMultiColumnBlock and folds all of its remaining code
back into RenderBlockFlow. This allows all block flows to support multi-column
layout, including table cells, list items, and the RenderView itself.

  • CMakeLists.txt:
  • WebCore.order:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

Remove RenderMultiColumnBlock from the makefiles.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustIntrinsicLogicalWidthsForColumns):
Tweak the comment, since it was no longer accurate.

  • rendering/RenderBlock.h:

Move some functions down into RenderBlockFlow.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::RenderBlockFlow):
(WebCore::RenderBlockFlow::createMultiColumnFlowThreadIfNeeded):
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::relayoutForPagination):
(WebCore::RenderBlockFlow::layoutSpecialExcludedChild):
(WebCore::RenderBlockFlow::updateLogicalWidthAndColumnWidth):
(WebCore::RenderBlockFlow::addChild):
(WebCore::RenderBlockFlow::checkForPaginationLogicalHeightChange):

  • rendering/RenderBlockFlow.h: Move a bunch of functions from RenderMultiColumnBlock up into RenderBlockFlow.
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::isUnsplittableForPagination):
Calls isMultiColumnBlockFlow() now instead of testing for a specific renderer type.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):
Remove the multicolumn block creation code, since we always make a block flow now.

  • rendering/RenderMultiColumnBlock.cpp: Removed.
  • rendering/RenderMultiColumnBlock.h: Removed.

Nuke the files.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::initialLogicalWidth):
(WebCore::RenderMultiColumnFlowThread::autoGenerateRegionsToBlockOffset):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset):
(WebCore::RenderMultiColumnSet::addForcedBreak):
(WebCore::RenderMultiColumnSet::recalculateBalancedHeight):
(WebCore::RenderMultiColumnSet::updateLogicalWidth):
(WebCore::RenderMultiColumnSet::prepareForLayout):
(WebCore::RenderMultiColumnSet::columnGap):
(WebCore::RenderMultiColumnSet::paintColumnRules):
Change all of the functions in the multicolumnset and multicolumnflowthread classes
to cast the parent to a RenderBlockFlow now instead of a RenderMultiColumnBlock.
Change the code to call through to multiColumnFlowThread() for column-specific information
for that parent block.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isMultiColumnBlockFlow):
Remove isRenderMultiColumnBlock() and replace with isMultiColumnBlockFlow().

  • rendering/RenderingAllInOne.cpp:

Remove RenderMultiColumnBlock include.

11:07 AM Changeset in webkit [162711] by mark.lam@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Removing the need for Debugger* and m_shouldPause op_debug check.
<https://webkit.org/b/127532>

Reviewed by Geoffrey Garen.

This patch replaces the checking of the Debugger::m_shouldPause flag
with a procedure to set a SteppingMode flag on all CodeBlocks under
the management of the debugger. This simplifies the op_debug checking
logic in all the execution engines.

  • bytecode/CodeBlock.cpp:
  • bytecode/CodeBlock.h:

(JSC::CodeBlock::hasDebuggerRequests):
(JSC::CodeBlock::debuggerRequestsAddress):
(JSC::CodeBlock::setSteppingMode):
(JSC::CodeBlock::clearDebuggerRequests):

  • CodeBlock::m_debuggerRequests is a union of m_numBreakpoints and the new m_steppingMode. The debugger can add/remove breakpoints to the CodeBlock as well as set the stepping mode. By having m_debuggerRequests as a union of the 2 bit fields, the op_debug code can now check if any of the 2 requests made on the CodeBlock is still in effect just by testing a single int.
  • debugger/Debugger.cpp:

(JSC::Debugger::Debugger):
(JSC::Debugger::detach):

  • This was bug from before where I forgot to clear the CodeBlock breakpoints before detaching. We now take care of it by clearing all debugger requests made to the CodeBlock.

(JSC::Debugger::SetSteppingModeFunctor::SetSteppingModeFunctor):
(JSC::Debugger::SetSteppingModeFunctor::operator()):
(JSC::Debugger::setSteppingMode):
(JSC::Debugger::ClearCodeBlockDebuggerRequestsFunctor::ClearCodeBlockDebuggerRequestsFunctor):
(JSC::Debugger::ClearCodeBlockDebuggerRequestsFunctor::operator()):
(JSC::Debugger::clearBreakpoints):

(JSC::Debugger::ClearDebuggerRequestsFunctor::ClearDebuggerRequestsFunctor):
(JSC::Debugger::ClearDebuggerRequestsFunctor::operator()):
(JSC::Debugger::clearDebuggerRequests):

  • We need a distinct clearDebuggerRequests() from clearBreakpoints() because:
    1. When we detach a globalObject, we only want to clear the debugger requests in CodeBlocks from that global.
    2. Clearing the debugger requests in the CodeBlocks is not the same as clearing the breakpoints. The breakpoints are still in effect for the next time a globalObject is attached, or for other globalObjects that are still attached.

(JSC::Debugger::setPauseOnNextStatement):
(JSC::Debugger::breakProgram):
(JSC::Debugger::stepIntoStatement):
(JSC::Debugger::updateCallFrameAndPauseIfNeeded):
(JSC::Debugger::pauseIfNeeded):
(JSC::Debugger::exception):
(JSC::Debugger::willExecuteProgram):
(JSC::Debugger::didReachBreakpoint):

  • debugger/Debugger.h:
  • We're always going to support the debugger. So, there's no longer a need to check ENABLE(JAVASCRIPT_DEBUGGER). Removed the unneeded code.
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::debug):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_debug):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_debug):

  • llint/LowLevelInterpreter.asm:
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::setDebugger):

10:56 AM Changeset in webkit [162710] by timothy_horton@apple.com
  • 13 edits
    2 adds in trunk/Source/WebKit2

WebKit2 View Gestures (Swipe): Add a simple cache of view snapshots
https://bugs.webkit.org/show_bug.cgi?id=127438

Reviewed by Sam Weinig.

Add a cache of bitmap snapshots of the WKView, taken via OS X's window server
snapshotting mechanism. For now, we store all snapshots; refinements to the
caching strategy (or really having one at all) will come in future patches.

Snapshots are stored in a side map, with a UUID that allows references
to be stored inside WebBackForwardListItem (and serialized along with
the back-forward list when it is copied).

  • Shared/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::setSnapshotUUID):
(WebKit::WebBackForwardListItem::snapshotUUID):

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
(WebKit::extractBackForwardListEntriesFromArray):
Store and serialize a UUID along with each back-forward list item which
identifies that item's view snapshot in the ViewSnapshotStore.

  • UIProcess/cf/WebPageProxyCF.cpp:

Bump the session state data version, as we changed the WebBackForwardList format.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::takeViewSnapshot):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _takeViewSnapshot]):
Add _takeViewSnapshot IPI, which is used by ViewSnapshotStore via the PageClient
to take a snapshot of the view.

(-[WKView saveBackForwardSnapshotForCurrentItem]):
Add saveBackForwardSnapshotForCurrentItem SPI, which clients could potentially
use when they know they're about to manipulate the view hierarchy in such a way
that they want the current back-forward item's snapshot to be up to date.

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::recordNavigationSnapshot):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
Update the current back-forward item's snapshot immediately before navigating.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::shouldRecordNavigationSnapshots):
(WebKit::WebPageProxy::setShouldRecordNavigationSnapshots):
Expose the ability to enable taking view snapshots on every navigation.
This is off by default, so we won't be taking any snapshots yet.

  • UIProcess/mac/ViewSnapshotStore.h: Added.

(WebKit::ViewSnapshotStore::disableSnapshotting):
(WebKit::ViewSnapshotStore::enableSnapshotting):

  • UIProcess/mac/ViewSnapshotStore.mm: Added.

(WebKit::ViewSnapshotStore::ViewSnapshotStore):
(WebKit::ViewSnapshotStore::~ViewSnapshotStore):
(WebKit::ViewSnapshotStore::shared):
(WebKit::ViewSnapshotStore::recordSnapshot):
(WebKit::ViewSnapshotStore::snapshotAndRenderTreeSize):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::takeViewSnapshot):

  • WebKit2.xcodeproj/project.pbxproj:
10:46 AM Changeset in webkit [162709] by beidson@apple.com
  • 12 edits in trunk/Source

IDB: support createIndex/deleteIndex messaging
https://bugs.webkit.org/show_bug.cgi?id=127546

Reviewed by Tim Horton.

Source/WebCore:

  • WebCore.exp.in: Export a needed CrossThreadCopier

Source/WebKit2:

Message create/delete requests over to the DatabaseProcess, and listen to its replies:

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::createIndex):
(WebKit::WebIDBServerConnection::didCreateIndex):
(WebKit::WebIDBServerConnection::deleteIndex):
(WebKit::WebIDBServerConnection::didDeleteIndex):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:

Pass create/delete requests to the appropriate unique IDB database:

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::createIndex):
(WebKit::DatabaseProcessIDBConnection::deleteIndex):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

Message the create/delete request to the database thread for the backing store to handle:

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::didCreateIndex):
(WebKit::UniqueIDBDatabase::didDeleteIndex):
(WebKit::UniqueIDBDatabase::createIndex):
(WebKit::UniqueIDBDatabase::deleteIndex):
(WebKit::UniqueIDBDatabase::createIndexInBackingStore):
(WebKit::UniqueIDBDatabase::deleteIndexInBackingStore):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • Scripts/webkit2/messages.py:

(struct_or_class):

10:30 AM Changeset in webkit [162708] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

The CXX_EXPLICIT_CONVERSIONS COMPILER_SUPPORTS macro has been removed, and all
compilers support explicit conversions now so simply remove the #ifdef.

  • wtf/RetainPtr.h:
10:20 AM Changeset in webkit [162707] by andersca@apple.com
  • 5 edits in trunk/Source/WTF

Simplify Compiler.h
https://bugs.webkit.org/show_bug.cgi?id=127491

Patch by Darin Adler <Darin Adler> on 2014-01-24
Reviewed by Anders Carlsson.

  • wtf/Assertions.h: Remove COMPILER_SUPPORTS(CXX_STATIC_ASSERT), since

we now have that for all compilers that can build WebKit.

  • wtf/Compiler.h: Removed always true feature flags, including:

COMPILER_SUPPORTS(CXX_VARIADIC_TEMPLATES), COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES),
COMPILER_SUPPORTS(CXX_DELETED_FUNCTIONS), COMPILER_SUPPORTS(CXX_NULLPTR),
COMPILER_SUPPORTS(CXX_EXPLICIT_CONVERSIONS), COMPILER_SUPPORTS(CXX_STATIC_ASSERT),
COMPILER_SUPPORTS(CXX_OVERRIDE_CONTROL), COMPILER_SUPPORTS(CXX_STRONG_ENUMS), and
COMPILER_SUPPORTS(CXX_AUTO_TYPE). Sorted sections alphabetically. Separated out
nested #if and #else into separate checks for greater readability. Removed obsolete
check for COMPILER(RVCT). Removed unused COMPILER(GCCE) detection.

  • wtf/RefPtr.h: Remove COMPILER_SUPPORTS(CXX_NULLPTR), since we now have

that for all compilers that can build WebKit.

  • wtf/RetainPtr.h: Ditto.
10:09 AM Changeset in webkit [162706] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the Windows build after <http://trac.webkit.org/changeset/162704>
(https://bugs.webkit.org/show_bug.cgi?id=127293)

Only include TargetConditionals.h when building on a Darwin-based OS.
Also, check that TARGET_OS_IPHONE is defined before referencing its value
since it will be undefined when building on Windows.

  • bindings/objc/PublicDOMInterfaces.h:
10:06 AM Changeset in webkit [162705] by msaboff@apple.com
  • 9 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Get ARM working
https://bugs.webkit.org/show_bug.cgi?id=127510

Reviewed by Geoffrey Garen.

Fixed nativeCallTrampoline in the LLInt to account for the prior changes made for running on the
C stack.

Updated maxFrameExtentForSlowPathCall to take into account the stack aligning that needs
to happen as well.

In LowLevelInterpreter.asm::callToJavaScriptPrologue() for 32 bit variants of ARM,
we align the stack to a 16 byte boundary since the ARM calling convention allows any
4 byte alignment. Added code in callToJavaScriptEpilogue() to restore the unaligned
stack pointer before returning.

Added pop and push register list opcodes to ARMv7 assember and added popPair and pushPair in the
ARMv7 macro assembler for use saving and restoring lr & fp. Also add the ARM only "clrbp"
(stands for clear bits for pointer) that maps to the bic (bit clear) instruction used to
align the stack.

Fixed ARMv7 add instructions where the destination is the stack pointer. Some instructions
only allow the "Rn" source to be the stack pointer. In those cases, the source register is
moved into the stack pointer and then an "add sp, ..." or "add sp, sp, ..." instruction is used.

Fixed the test32 macro instruction handle the case where we want to test the stack pointer.
The instruction set doesn't allow that directly, so we move the stack pointer into a temp
register first.

Reviewed by Geoffrey Garen.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::add):
(JSC::ARMv7Assembler::pop):
(JSC::ARMv7Assembler::push):
(JSC::ARMv7Assembler::ARMInstructionFormatter::twoWordOp16Imm16):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::add32):
(JSC::MacroAssemblerARMv7::popPair):
(JSC::MacroAssemblerARMv7::pushPair):
(JSC::MacroAssemblerARMv7::test32):

  • assembler/MaxFrameExtentForSlowPathCall.h:
  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • offlineasm/arm.rb:
  • offlineasm/instructions.rb:
9:49 AM Changeset in webkit [162704] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Bindings generation tests hit an error trying to include wtf/Platform.h after r161638
https://bugs.webkit.org/show_bug.cgi?id=127293

Reviewed by Alexey Proskuryakov.

Include TargetConditionals.h instead of wtf/Platform.h as the latter isn't available
in the public SDK.

As a side effect of this change, replace usage of PLATFORM(IOS) with TARGET_OS_IPHONE.

  • bindings/objc/PublicDOMInterfaces.h:
9:33 AM Changeset in webkit [162703] by msaboff@apple.com
  • 2 edits in branches/jsCStack/Source/JavaScriptCore

Merge trunk change set r162701.

9:14 AM Changeset in webkit [162702] by hyatt@apple.com
  • 8 edits in trunk/Source/WebCore

[New Multicolumn] Table cells and list items need to work as multicolumn blocks.
https://bugs.webkit.org/show_bug.cgi?id=127365

This patch is a first step towards eliminating RenderMultiColumnBlock and moving
all its functionality into RenderBlockFlow. Doing so will allow table cells, list
items and the RenderView to use the new multi-column layout.

Reviewed by Simon Fraser.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::setMultiColumnFlowThread):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::multiColumnFlowThread):
Add the flow thread pointer to the multi-column flow thread to RenderBlockFlow's
rare data. This lets us use only one pointer in the rare data to point to an object
that can hold all of the rest of the multi-column info.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
Move the construction of the flow thread to the constructor. This ensures we
never have a null flow thread and lets us avoid having to null check it for
empty multi-column blocks.

(WebCore::RenderMultiColumnBlock::columnHeightAvailable):
(WebCore::RenderMultiColumnBlock::columnWidth):
(WebCore::RenderMultiColumnBlock::columnCount):
(WebCore::RenderMultiColumnBlock::updateLogicalWidthAndColumnWidth):
The above functions now call through to the multi-column flow thread for results.

(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):

Set the column height available on the flow thread.

(WebCore::RenderMultiColumnBlock::relayoutForPagination):
The balancing pass and guard is in the multi-column flow thread now.

(WebCore::RenderMultiColumnBlock::addChild):
Don't have to create the flow thread here any longer, since we do it up front
in the constructor of RenderMultiColumnBlock.

(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
Don't need the null check of the flow thread any more.

  • rendering/RenderMultiColumnBlock.h:

Change the inlined functions to not be inlined, since they need to call
RenderMultiColumnFlowThread functions now.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
Init the new member variables we moved here from RenderMultiColumnBlock.

(WebCore::RenderMultiColumnFlowThread::computeColumnCountAndWidth):
Moved from RenderMultiColumnBlock.

  • rendering/RenderMultiColumnFlowThread.h:

Add public getters/setters to the member variables so that RenderMultiColumnBlock can
still see them. Move the member variables here from RenderMultiColumnBlock.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::calculateBalancedHeight):
(WebCore::RenderMultiColumnSet::prepareForLayout):
(WebCore::RenderMultiColumnSet::columnCount):
Call through to the flow thread instead.

8:34 AM Changeset in webkit [162701] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARM Offline assembler temporary register allocator has duplicate register when building fat binaries
https://bugs.webkit.org/show_bug.cgi?id=127545

Reviewed by Mark Lam.

Eliminate the conditional addition of r11/r7 from getModifiedListARMCommon as the
.concat will add the new register to ARM_EXTRA_GPRS. If getModifiedListARMCommon is
invoked a second time, there will be a second r11 or r7, which messes things up.
Instead, r6 was added to ARM_EXTRA_GPRS. r6 is currently an unused register.

  • offlineasm/arm.rb:
8:19 AM Changeset in webkit [162700] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Add expectations for two flaky media layout tests
https://bugs.webkit.org/show_bug.cgi?id=127557

Unreviewed EFL gardening.

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-01-24

  • platform/efl/TestExpectations:
4:02 AM Changeset in webkit [162699] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Debug buildfix
https://bugs.webkit.org/show_bug.cgi?id=127496

Reviewed by Gyuyoung Kim.

  • Shared/SessionTracker.cpp:
3:44 AM Changeset in webkit [162698] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Skip crashing http tests.

  • platform/efl-wk2/TestExpectations:
1:59 AM Changeset in webkit [162697] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r162663.

  • platform/gtk/ScrollViewGtk.cpp:

(WebCore::ScrollView::visibleContentRectInternal): Renamed from visibleContentRect.

1:25 AM Changeset in webkit [162696] by zandobersek@gmail.com
  • 9 edits in trunk/Source

Move HistoryItem to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127275

Reviewed by Darin Adler.

Source/WebCore:

Replace the uses of OwnPtr and PassOwnPtr in the HistoryItem class with std::unique_ptr.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::addRedirectURL):
(WebCore::HistoryItem::setRedirectURLs):

  • history/HistoryItem.h:
  • history/mac/HistoryItemMac.mm:

(WebCore::HistoryItem::setTransientProperty):
WebCore.exp.in: Update the symbol.

Source/WebKit/mac:

  • History/WebHistoryItem.mm: The Vector object that's passed to HistoryItem::setRedirectURLs

should now be handled by std::unique_ptr and passed on through move semantics.
(-[WebHistoryItem initFromDictionaryRepresentation:]):

Source/WebKit/win:

  • WebHistoryItem.cpp: The Vector object that's passed to HistoryItem::setRedirectURLs

should now be handled by std::unique_ptr and passed on through move semantics.
(WebHistoryItem::initFromDictionaryRepresentation):

12:33 AM Changeset in webkit [162695] by jinwoo7.song@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Remove failure expectations which are passing now.

  • platform/efl/TestExpectations: fast/css3-text/css3-text-decoration/
12:00 AM Changeset in webkit [162694] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

Region based multicol: unresolvable percent height results in 1px tall multicol
https://bugs.webkit.org/show_bug.cgi?id=122826

Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-23
Reviewed by David Hyatt.

Source/WebCore:

If a box has a percentage height, but the computed height of its
containing block is auto, the computed height of the box also becomes
auto. computeContentLogicalHeight() returns -1 if the height isn't
resolvable, and we need to make sure that such a value doesn't
constrain the height of the multicol container.

Tests: fast/multicol/newmulticol/unresolvable-percent-height-2.html

fast/multicol/newmulticol/unresolvable-percent-height.html
fast/multicol/newmulticol/unresolvable-percent-max-height-2.html
fast/multicol/newmulticol/unresolvable-percent-max-height.html

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::calculateBalancedHeight):
(WebCore::RenderMultiColumnSet::recalculateBalancedHeight):
(WebCore::RenderMultiColumnSet::prepareForLayout):

LayoutTests:

  • fast/multicol/newmulticol/unresolvable-percent-height-2-expected.html: Added.
  • fast/multicol/newmulticol/unresolvable-percent-height-2.html: Added.
  • fast/multicol/newmulticol/unresolvable-percent-height-expected.html: Added.
  • fast/multicol/newmulticol/unresolvable-percent-height.html: Added.
  • fast/multicol/newmulticol/unresolvable-percent-max-height-2-expected.html: Added.
  • fast/multicol/newmulticol/unresolvable-percent-max-height-2.html: Added.
  • fast/multicol/newmulticol/unresolvable-percent-max-height-expected.html: Added.
  • fast/multicol/newmulticol/unresolvable-percent-max-height.html: Added.

Jan 23, 2014:

10:12 PM Changeset in webkit [162693] by rniwa@webkit.org
  • 2 edits in trunk/Websites/test-results

Upstream changes to json-shared.php from the perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=127544

Reviewed by Joseph Pecoraro.

json-shared.php originated from the perf dashboard.
Upstream changes made to the version in the perf. dashboard so that two apps could share the same code.

  • public/include/json-shared.php:

(exit_with_error):
(echo_success):
(exit_with_success):
(set_exit_detail):
(merge_additional_details):

10:07 PM Changeset in webkit [162692] by Joseph Pecoraro
  • 24 edits
    4 moves
    3 adds in trunk/Source

Move ContentSearchUtils, ScriptBreakpoint, and ScriptDebugListener into JavaScriptCore for inspector
https://bugs.webkit.org/show_bug.cgi?id=127537

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • inspector/ContentSearchUtilities.cpp: Renamed from Source/WebCore/inspector/ContentSearchUtils.cpp.

(Inspector::ContentSearchUtilities::createSearchRegexSource):
(Inspector::ContentSearchUtilities::sizetExtractor):
(Inspector::ContentSearchUtilities::textPositionFromOffset):
(Inspector::ContentSearchUtilities::getRegularExpressionMatchesByLines):
(Inspector::ContentSearchUtilities::lineEndings):
(Inspector::ContentSearchUtilities::buildObjectForSearchMatch):
(Inspector::ContentSearchUtilities::createSearchRegex):
(Inspector::ContentSearchUtilities::countRegularExpressionMatches):
(Inspector::ContentSearchUtilities::searchInTextByLines):
(Inspector::ContentSearchUtilities::scriptCommentPattern):
(Inspector::ContentSearchUtilities::stylesheetCommentPattern):
(Inspector::ContentSearchUtilities::findMagicComment):
(Inspector::ContentSearchUtilities::findScriptSourceURL):
(Inspector::ContentSearchUtilities::findScriptSourceMapURL):
(Inspector::ContentSearchUtilities::findStylesheetSourceMapURL):

  • inspector/ContentSearchUtilities.h: Renamed from Source/WebCore/inspector/ContentSearchUtils.h.
  • inspector/ScriptBreakpoint.h: Renamed from Source/WebCore/inspector/ScriptBreakpoint.h.

(Inspector::ScriptBreakpointAction::ScriptBreakpointAction):
(Inspector::ScriptBreakpoint::ScriptBreakpoint):

  • inspector/ScriptDebugListener.h: Renamed from Source/WebCore/inspector/ScriptDebugListener.h.

(Inspector::ScriptDebugListener::Script::Script):
(Inspector::ScriptDebugListener::~ScriptDebugListener):

  • runtime/RegExp.cpp:

(JSC::RegExp::match):

Source/WebCore:

  • Rename ContentSearchUtils => ContentSearchUtilities and move to JavaScriptCore.
  • Move ScriptBreakpoint and ScriptDebugListener to JavaScriptCore.
  • Move them all to namespace Inspector.
  • Update build files and users to the new names.

No change in functionality, just moving code.

  • CMakeLists.txt:
  • ForwardingHeaders/inspector/ContentSearchUtilities.h: Added.
  • ForwardingHeaders/inspector/ScriptBreakpoint.h: Added.
  • ForwardingHeaders/inspector/ScriptDebugListener.h: Added.
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/PageScriptDebugServer.cpp:
  • bindings/js/PageScriptDebugServer.h:
  • bindings/js/ScriptDebugServer.cpp:
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/WorkerScriptDebugServer.cpp:
  • bindings/js/WorkerScriptDebugServer.h:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
(WebCore::InspectorDebuggerAgent::didParseSource):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::sourceMapURLForResource):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::buildSourceRangeObject):
(WebCore::InspectorStyleSheet::lineEndings):
(WebCore::InspectorStyleSheetForInlineStyle::lineEndings):

10:07 PM Changeset in webkit [162691] by Joseph Pecoraro
  • 30 edits
    2 moves
    1 add in trunk/Source

Move RegularExpression into JavaScriptCore for inspector
https://bugs.webkit.org/show_bug.cgi?id=127526

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Move RegularExpression into JavaScriptCore/yarr so it can
be used later on by JavaScriptCore/inspector. Convert to
the JSC::Yarr namespace.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • yarr/RegularExpression.cpp: Renamed from Source/WebCore/platform/text/RegularExpression.cpp.

(JSC::Yarr::RegularExpression::Private::create):
(JSC::Yarr::RegularExpression::Private::Private):
(JSC::Yarr::RegularExpression::Private::compile):
(JSC::Yarr::RegularExpression::RegularExpression):
(JSC::Yarr::RegularExpression::~RegularExpression):
(JSC::Yarr::RegularExpression::operator=):
(JSC::Yarr::RegularExpression::match):
(JSC::Yarr::RegularExpression::searchRev):
(JSC::Yarr::RegularExpression::matchedLength):
(JSC::Yarr::replace):
(JSC::Yarr::RegularExpression::isValid):

  • yarr/RegularExpression.h: Renamed from Source/WebCore/platform/text/RegularExpression.h.

Source/WebCore:

Update as appropriate for the moved file and namespace
change for class RegularExpression.

  • CMakeLists.txt:
  • ForwardingHeaders/yarr/RegularExpression.h: Added.
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMImplementation.h:
  • html/BaseCheckableInputType.cpp:
  • html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::patternMismatch):

  • html/EmailInputType.cpp:

(WebCore::isValidEmailAddress):

  • html/InputType.cpp:
  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
(WebCore::ContentSearchUtils::createSearchRegex):
(WebCore::ContentSearchUtils::countRegularExpressionMatches):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::matches):
(WebCore::InspectorDebuggerAgent::breakpointActionLog):
(WebCore::InspectorDebuggerAgent::breakpointActionSound):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::searchInResources):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:
  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::selectorsFromSource):

  • inspector/WorkerDebuggerAgent.cpp:
  • page/Frame.cpp:

(WebCore::createRegExpForLabels):
(WebCore::Frame::searchForLabelsAboveCell):
(WebCore::Frame::searchForLabelsBeforeElement):
(WebCore::matchLabelsAgainstString):

  • page/Frame.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::getUnmangledInfoLog):

Source/WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:
9:45 PM Changeset in webkit [162690] by beidson@apple.com
  • 16 edits in trunk/Source

Source/WebCore: IDB: Support IDBObjectStore.clear()
https://bugs.webkit.org/show_bug.cgi?id=127541

Reviewed by Anders Carlsson.

The backing store should never be performing callbacks directly:

  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::clearObjectStore):

Instead, the transaction operations should do that themselves:

  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::ClearObjectStoreOperation::perform):

  • Modules/indexeddb/IDBTransactionBackendOperations.h:

(WebCore::ClearObjectStoreOperation::transaction):

Source/WebKit2: IDB: Support IDBObjectStore.clear()
https://bugs.webkit.org/show_bug.cgi?id=127541

Reviewed by Anders Carlsson.

Make the WebProcess call out to the DatabaseProcess with a clear request, and handle the
response from the DatabaseProcess:

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::clearObjectStore):
(WebKit::WebIDBServerConnection::didClearObjectStore):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:

Pass the clear request to the appropriate UniqueIDBDatabase:

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::clearObjectStore):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

Pass the clear request to the backing store:

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::didClearObjectStore):
(WebKit::UniqueIDBDatabase::clearObjectStore):
(WebKit::UniqueIDBDatabase::clearObjectStoreInBackingStore):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

Actually drop the records in the database:

  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::clearObjectStore):

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
9:43 PM Changeset in webkit [162689] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix crash when opening the inspector
https://bugs.webkit.org/show_bug.cgi?id=127542
<rdar://problem/15899544>

Reviewed by Joseph Pecoraro.

Create default clients so we won't crash if they're never set.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

9:29 PM Changeset in webkit [162688] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit2

Unreviewed build fix attemp on the EFL and GTK build after r162678

  • CMakeLists.txt: Removed WebPolicyClient.cpp
  • GNUmakefile.list.am: Removed WebPolicyClient.cpp and WebPolicyClient.h
9:21 PM Changeset in webkit [162687] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/15875326> REGRESSION (r162257): Assertion failure (should not be reached) in CSSPreloadScanner::tokenize()
https://bugs.webkit.org/show_bug.cgi?id=127540

Reviewed by Anders Carlsson.

No new tests, because I could not reproduce the bug reliably and I don’t know how to trigger
it.

  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::scan): Check for the DoneParsingImportRules before tokenizing
a character, not after. This restores the logic from before r162257.

9:15 PM Changeset in webkit [162686] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Protect against possbile deadlock by delaying video layer creation
https://bugs.webkit.org/show_bug.cgi?id=127505

Reviewed by Eric Carlson.

Work around a possible deadlock on iOS when creating a media element
backed by AVFoundation by delaying creation of the AVPlayerLayer.
The deadlock can occur when the web thread is doing CALayer layout
while taking the web thread lock, while CoreMedia is doing property
access on an async thread while taking the CM lock, and each is waiting
for the other's lock to be released.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):

8:59 PM Changeset in webkit [162685] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[MSE][Mac] Crash when reloading a page during playback
https://bugs.webkit.org/show_bug.cgi?id=126903

Reviewed by Eric Carlson.

Periodic time observers added to AVSampleBufferRenderSynchronizer will execute their
callback block even after being removed with -removeTimeObserver:, which is tracked by
<rdar://problem/15798050>. Work around this problem by passing a WeakPtr into the block
and bail early if the owning media player has been destroyed.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::createWeakPtr):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):

8:51 PM Changeset in webkit [162684] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Support NSInteger argument type for encoding/decoding invocations.
https://bugs.webkit.org/show_bug.cgi?id=127522

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-23
Reviewed by Dan Bernstein.

Add support for NSInteger argument type ('q') for remote invocations.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeInvocation):
(decodeInvocationArguments):

8:12 PM Changeset in webkit [162683] by ChangSeok Oh
  • 3 edits
    2 adds in trunk

Dragging from inner side of video to outside causes a crash
https://bugs.webkit.org/show_bug.cgi?id=126338

Reviewed by Jer Noble.

Source/WebCore:

The crash happens while dragging mouse cursor through timeline control to outside
of video region. This is beacause media controls are selected with the drag.
The media controls disappear when mouse cursor goes outside of video though
the dragging/selection proceeds. If once media controls are hidden, related element
lose their renderers. However the drag is still under going. it requires shadowPseudoId
of the selected controls. Untorntunately, SliderThumbElement/SliderContainerElement
don't return a static value for the shadowPseudoId unlike other media controls,
but they need a renderer to determine it. This is the reason of crash.

Test: media/media-controller-drag-crash.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::shadowPseudoId):
(WebCore::SliderContainerElement::shadowPseudoId):

LayoutTests:

This tests that dragging through timeslider control to outside of video causes a crash.
The crash happened on both gtk+ and efl ports not using MEDIA_CONTROL_SCRIPT.

  • media/media-controller-drag-crash-expected.txt: Added.
  • media/media-controller-drag-crash.html: Added.
7:52 PM Changeset in webkit [162682] by beidson@apple.com
  • 11 edits in trunk/Source

IDB: Implement SQLite backing store 'get' support
https://bugs.webkit.org/show_bug.cgi?id=127502

Reviewed by Tim Horton.

Source/WebCore:

Get a KeyRange from a KeyRangeData:

  • Modules/indexeddb/IDBKeyRangeData.cpp:

(WebCore::IDBKeyRangeData::maybeCreateIDBKeyRange):

  • Modules/indexeddb/IDBKeyRangeData.h:

Add collation function support to SQLiteDatabase:

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::destroyCollationFunction):
(WebCore::callCollationFunction):
(WebCore::SQLiteDatabase::setCollationFunction):
(WebCore::SQLiteDatabase::removeCollationFunction):

  • platform/sql/SQLiteDatabase.h:
  • WebCore.exp.in:

Source/WebKit2:

This makes get of a single IDBKey work, and lays the groundwork for getting an IDBKeyRange.

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::getRecordFromBackingStore):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata): Add custom collation

to the Records table.

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getOrEstablishMetadata): Install the custom collator.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRecordFromObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRangeRecordFromObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::collate): Collation function to be filled in later.

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
7:41 PM Changeset in webkit [162681] by timothy@apple.com
  • 8 edits in trunk/Source/WebInspectorUI

Refactor TimelineRecordBar combining logic into a helper function.

https://bugs.webkit.org/show_bug.cgi?id=127530

Reviewed by Joseph Pecoraro.

  • UserInterface/LayoutTimelineOverviewGraph.js:

(WebInspector.LayoutTimelineOverviewGraph.prototype.updateLayout.createBar):
(WebInspector.LayoutTimelineOverviewGraph.prototype.updateLayout):
Use TimelineRecordBar.createCombinedBars.

  • UserInterface/NetworkTimelineOverviewGraph.css:

(.timeline-overview-graph.network):
(.timeline-overview-graph.network > .graph-row > .timeline-record-bar):
Cleaned up since we are using TimelineRecordBar.

  • UserInterface/NetworkTimelineOverviewGraph.js:

(WebInspector.NetworkTimelineOverviewGraph.prototype.reset):
(WebInspector.NetworkTimelineOverviewGraph.prototype.updateLayout.createBar):
(WebInspector.NetworkTimelineOverviewGraph.prototype.updateLayout):
Use TimelineRecordBar.createCombinedBars.

  • UserInterface/ScriptTimelineOverviewGraph.js:

(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout.createBar):
(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
Use TimelineRecordBar.createCombinedBars.

  • UserInterface/TimelineDataGridNode.js:

(WebInspector.TimelineDataGridNode.prototype.refreshGraph.createBar):
(WebInspector.TimelineDataGridNode.prototype.refreshGraph):
Use TimelineRecordBar.createCombinedBars.

  • UserInterface/TimelineRecordBar.css:

(.timeline-record-bar.unfinished > .segment):
(.timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(:focus .selected .timeline-record-bar > .segment.inactive):
Improved selected appearance and don't assume .segment.inactive exists.

  • UserInterface/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar):
(WebInspector.TimelineRecordBar.createCombinedBars.compareByActiveStartTime): Added.
(WebInspector.TimelineRecordBar.createCombinedBars): Added.
(WebInspector.TimelineRecordBar.prototype.get renderMode): Added.
(WebInspector.TimelineRecordBar.prototype.set renderMode): Added.
(WebInspector.TimelineRecordBar.prototype.set records):
(WebInspector.TimelineRecordBar.prototype.refresh):
Lazy create DOM elements. Support rendering one or both segments. Doing this lets
combined inactive segments to sit behind multiple active segments.

7:08 PM Changeset in webkit [162680] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

Remote Inspector uses the Page pointer before the page is created on iOS
https://bugs.webkit.org/show_bug.cgi?id=127534

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-23
Reviewed by Joseph Pecoraro.

  • WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

6:55 PM Changeset in webkit [162679] by jhoneycutt@apple.com
  • 14 edits
    2 adds in trunk

Assertion failure in WebCore::PseudoElement::didRecalcStyle()
<https://bugs.webkit.org/show_bug.cgi?id=126761>
<rdar://problem/15793540>

Source/WebCore:

Reviewed by Andy Estes.

Test: fast/images/animate-list-item-image-assertion.html

  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::didRecalcStyle):
Check isRenderImage() rather than isImage() before casting to
RenderImage.

  • editing/ios/EditorIOS.mm:

(WebCore::getImage):
Ditto.

  • editing/mac/EditorMac.mm:

(WebCore::getImage):
Ditto.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::didAttachRenderers):
Ditto.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::renderImageResource):
Ditto.

  • page/DragController.cpp:

(WebCore::getCachedImage):
Ditto.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
(WebCore::RenderLayerBacking::updateImageContents):
Ditto.

Source/WebKit/mac:

Some areas of code were erroneously checking the value of
RenderObject::isImage() rather than RenderObject::isRenderImage()
before casting the object to RenderImage.

This could lead to an assertion failure for RenderListMarkers, which
may return true for isImage(), but are not RenderImages.

Reviewed by Andy Estes.

  • Misc/WebNSPasteboardExtras.mm:

(-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
Check isRenderImage() rather than isImage() before casting to
RenderImage.

Source/WebKit2:

Reviewed by Andy Estes.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):
Check isRenderImage() rather than isImage() before casting to
RenderImage.

LayoutTests:

Reviewed by Andy Estes.

  • fast/images/animate-list-item-image-assertion-expected.txt: Added.
  • fast/images/animate-list-item-image-assertion.html: Added.
6:49 PM Changeset in webkit [162678] by andersca@apple.com
  • 3 edits
    2 deletes in trunk/Source/WebKit2

Move policy client into WKPage.cpp and get rid of WebPolicyClient files
https://bugs.webkit.org/show_bug.cgi?id=127536

Reviewed by Tim Horton.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPagePolicyClient):

  • UIProcess/WebPolicyClient.cpp: Removed.
  • UIProcess/WebPolicyClient.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
6:42 PM Changeset in webkit [162677] by Simon Fraser
  • 2 edits in trunk/Source/WebKit

Attempt to fix Windows DRT link issue.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
6:38 PM Changeset in webkit [162676] by Joseph Pecoraro
  • 132 edits in trunk

Web Inspector: Remove recompileAllJSFunctions timer in ScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=127409

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • inspector/InspectorAgentBase.h:

When disconnecting agents, provide a InspectorDisconnectReason for
the disconnection. It could be that an inspector frontend is just
disconnecting or that the inspected object is going away entirely
and we can avoid doing some work.

  • runtime/JSGlobalObjectDebuggable.h:
  • runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::~JSGlobalObjectDebuggable):
(JSC::JSGlobalObjectDebuggable::disconnect):
(JSC::JSGlobalObjectDebuggable::disconnectInternal):
Pass different reasons for the different disconnects.

  • inspector/InspectorAgentRegistry.cpp:

(Inspector::InspectorAgentRegistry::willDestroyFrontendAndBackend):

  • inspector/InspectorAgentRegistry.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::willDestroyFrontendAndBackend):

  • inspector/agents/InspectorAgent.h:

Pass InspectorDisconnectReason around where needed.

Source/WebCore:

No new tests (OOPS!).

  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
Remove m_recompileTimer and the recompile soon function.
We can just recompile immediately in all existing cases.

  • bindings/js/PageScriptDebugServer.h:
  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):
(WebCore::PageScriptDebugServer::removeListener):
(WebCore::PageScriptDebugServer::recompileAllJSFunctions):
(WebCore::PageScriptDebugServer::didAddFirstListener):
(WebCore::PageScriptDebugServer::didRemoveLastListener):
Add a "didAddFirstListener" to match "didRemoveLastListener".
Only recompile functions when we attach the debugger and when
we detach the last listener.

  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
Same thing. Also rearrange the functions to read better.

  • inspector/InspectorProfilerAgent.cpp:

Use the direct recompile function instead of the removed "soon" version.

  • WebCore.exp.in:

Update disconnectFrontend symbol.

  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::disconnect):

  • testing/Internals.cpp:

(WebCore::Internals::closeDummyInspectorFrontend):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::disconnectFromWorkerGlobalScopeInspectorTask):
Include an InspectorDisconnectReason when calling disconnectFrontend.

  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::willDestroyFrontendAndBackend):
If the disconnect reason is the page will be destroyed, don't recompile when disconnecting.

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::willDestroyFrontendAndBackend):
If the disconnect reason is the page will be destroyed, don't recompile when disconnecting.

  • inspector/InspectorController.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::close):
Pass different reasons for the different disconnect reasons.

  • inspector/WorkerInspectorController.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::~WorkerInspectorController):
(WebCore::WorkerInspectorController::disconnectFrontend):
Pass different reasons for the different disconnect reasons.

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorCanvasAgent.h:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorHeapProfilerAgent.cpp:

(WebCore::InspectorHeapProfilerAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorHeapProfilerAgent.h:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorInputAgent.cpp:

(WebCore::InspectorInputAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorInputAgent.h:
  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorLayerTreeAgent.h:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorTimelineAgent.h:
  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorWorkerAgent.h:
  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::disable):
(WebCore::PageDebuggerAgent::stopListeningScriptDebugServer):

  • inspector/PageDebuggerAgent.h:
  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::willDestroyFrontendAndBackend):

  • inspector/PageRuntimeAgent.h:
  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):

  • inspector/WorkerDebuggerAgent.h:
  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::willDestroyFrontendAndBackend):

  • inspector/WorkerRuntimeAgent.h:

Include InspectorDisconnectReason param.

Source/WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorFrontendClientEfl::destroyInspectorWindow):
Include InspectorDisconnectReason.

Source/WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorFrontendClient::destroyInspectorWindow):
Include InspectorDisconnectReason.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController destroyInspectorView:]):
Include InspectorDisconnectReason.

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorFrontendClient::destroyInspectorView):
Include InspectorDisconnectReason.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::closeWindow):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::remoteFrontendDisconnected):
Include InspectorDisconnectReason.

LayoutTests:

Remove "Breakpoints Enabled" output in tests. Breakpoints are already
enabled by default in tests. Also since the DebuggerAgent.enable() call
now immediately recompiles scripts, sourceParsed events are now sent to
the frontend earlier even before the setBreakpointsActive message has
been processed, so the "Breakpoints Enabled" output was showing up
later, seemingly randomly in tests, and is no longer helpful.

  • inspector-protocol/debugger/breakpoint-action-detach-expected.txt:
  • inspector-protocol/debugger/breakpoint-action-detach.html:
  • inspector-protocol/debugger/breakpoint-action-with-exception-expected.txt:
  • inspector-protocol/debugger/breakpoint-action-with-exception.html:
  • inspector-protocol/debugger/breakpoint-condition-detach-expected.txt:
  • inspector-protocol/debugger/breakpoint-condition-detach.html:
  • inspector-protocol/debugger/breakpoint-condition-with-exception-expected.txt:
  • inspector-protocol/debugger/breakpoint-condition-with-exception.html:
  • inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt:
  • inspector-protocol/debugger/breakpoint-eval-with-exception.html:
  • inspector-protocol/debugger/breakpoint-inside-conditons-and-actions-expected.txt:
  • inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html:
  • inspector-protocol/debugger/call-frame-function-name-expected.txt:
  • inspector-protocol/debugger/call-frame-function-name.html:
  • inspector-protocol/debugger/call-frame-this-host-expected.txt:
  • inspector-protocol/debugger/call-frame-this-host.html:
  • inspector-protocol/debugger/call-frame-this-nonstrict-expected.txt:
  • inspector-protocol/debugger/call-frame-this-nonstrict.html:
  • inspector-protocol/debugger/call-frame-this-strict-expected.txt:
  • inspector-protocol/debugger/call-frame-this-strict.html:
  • inspector-protocol/debugger/didSampleProbe-multiple-probes-expected.txt:
  • inspector-protocol/debugger/didSampleProbe-multiple-probes.html:
  • inspector-protocol/debugger/nested-inspectors-expected.txt:
  • inspector-protocol/debugger/nested-inspectors.html:
  • inspector-protocol/debugger/removeBreakpoint-expected.txt:
  • inspector-protocol/debugger/removeBreakpoint.html:
  • inspector-protocol/debugger/setBreakpoint-actions-expected.txt:
  • inspector-protocol/debugger/setBreakpoint-actions.html:
  • inspector-protocol/debugger/setBreakpoint-autoContinue-expected.txt:
  • inspector-protocol/debugger/setBreakpoint-autoContinue.html:
  • inspector-protocol/debugger/setBreakpoint-column-expected.txt:
  • inspector-protocol/debugger/setBreakpoint-column.html:
  • inspector-protocol/debugger/setBreakpoint-condition-expected.txt:
  • inspector-protocol/debugger/setBreakpoint-condition.html:
  • inspector-protocol/debugger/setBreakpoint-expected.txt:
  • inspector-protocol/debugger/setBreakpoint-options-exception-expected.txt:
  • inspector-protocol/debugger/setBreakpoint-options-exception.html:
  • inspector-protocol/debugger/setBreakpoint.html:
  • inspector-protocol/debugger/setBreakpointByUrl-sourceURL-expected.txt:
  • inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html:
  • inspector-protocol/debugger/setPauseOnExceptions-all-expected.txt:
  • inspector-protocol/debugger/setPauseOnExceptions-all.html:
  • inspector-protocol/debugger/setPauseOnExceptions-none-expected.txt:
  • inspector-protocol/debugger/setPauseOnExceptions-none.html:
  • inspector-protocol/debugger/setPauseOnExceptions-uncaught-expected.txt:
  • inspector-protocol/debugger/setPauseOnExceptions-uncaught.html:
  • inspector-protocol/dom-debugger/node-removed-expected.txt:
  • inspector-protocol/dom-debugger/node-removed.html:
6:33 PM Changeset in webkit [162675] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Only WKPage should know about WebPolicyClient
https://bugs.webkit.org/show_bug.cgi?id=127535

Reviewed by Andreas Kling.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPagePolicyClient):
(-[WKBrowsingContextController setPolicyDelegate:]):

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage):

6:24 PM Changeset in webkit [162674] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/win

Another Windows fix.

  • WebFrame.cpp:

(WebFrame::frameBounds):

6:20 PM Changeset in webkit [162673] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Simplify API::LoaderClient management
https://bugs.webkit.org/show_bug.cgi?id=127531

Reviewed by Tim Horton.

Add default implementations to API::LoaderClient and change WebPageProxy::setLoaderClient to
always create a policy client, even if the loader client set is null. That way we don't have to null
check the loader client everywhere.

  • UIProcess/API/APILoaderClient.h:

(API::LoaderClient::didStartProvisionalLoadForFrame):
(API::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(API::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
(API::LoaderClient::didCommitLoadForFrame):
(API::LoaderClient::didFinishDocumentLoadForFrame):
(API::LoaderClient::didFinishLoadForFrame):
(API::LoaderClient::didFailLoadWithErrorForFrame):
(API::LoaderClient::didSameDocumentNavigationForFrame):
(API::LoaderClient::didReceiveTitleForFrame):
(API::LoaderClient::didFirstLayoutForFrame):
(API::LoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(API::LoaderClient::didRemoveFrameFromHierarchy):
(API::LoaderClient::didDisplayInsecureContentForFrame):
(API::LoaderClient::didRunInsecureContentForFrame):
(API::LoaderClient::didDetectXSSForFrame):
(API::LoaderClient::didLayout):
(API::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame):
(API::LoaderClient::didReceiveAuthenticationChallengeInFrame):
(API::LoaderClient::didStartProgress):
(API::LoaderClient::didChangeProgress):
(API::LoaderClient::didFinishProgress):
(API::LoaderClient::processDidBecomeUnresponsive):
(API::LoaderClient::interactionOccurredWhileProcessUnresponsive):
(API::LoaderClient::processDidBecomeResponsive):
(API::LoaderClient::processDidCrash):
(API::LoaderClient::didChangeBackForwardList):
(API::LoaderClient::willGoToBackForwardListItem):
(API::LoaderClient::pluginLoadPolicy):
(API::LoaderClient::didFailToInitializePlugin):
(API::LoaderClient::didBlockInsecurePluginVersion):
(API::LoaderClient::webGLLoadPolicy):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setLoaderClient):
(WebKit::WebPageProxy::didChangeBackForwardList):
(WebKit::WebPageProxy::willGoToBackForwardListItem):
(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::didStartProgress):
(WebKit::WebPageProxy::didChangeProgress):
(WebKit::WebPageProxy::didFinishProgress):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::didFirstLayoutForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebPageProxy::didLayout):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
(WebKit::WebPageProxy::didDisplayInsecureContentForFrame):
(WebKit::WebPageProxy::didRunInsecureContentForFrame):
(WebKit::WebPageProxy::didDetectXSSForFrame):
(WebKit::WebPageProxy::webGLPolicyForURL):
(WebKit::WebPageProxy::processDidBecomeUnresponsive):
(WebKit::WebPageProxy::interactionOccurredWhileProcessUnresponsive):
(WebKit::WebPageProxy::processDidBecomeResponsive):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::canAuthenticateAgainstProtectionSpaceInFrame):
(WebKit::WebPageProxy::didReceiveAuthenticationChallengeProxy):
(WebKit::WebPageProxy::didFailToInitializePlugin):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

6:08 PM Changeset in webkit [162672] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Simplify API::PolicyClient management
https://bugs.webkit.org/show_bug.cgi?id=127529

Reviewed by Tim Horton.

Add default implementations to API::PolicyClient and change WebPageProxy::setPolicyClient to
always create a policy client, even if the policy object set is null. That way we don't have to null
check the policy client everywhere.

  • UIProcess/API/APIPolicyClient.h:

(API::PolicyClient::decidePolicyForNavigationAction):
(API::PolicyClient::decidePolicyForNewWindowAction):
(API::PolicyClient::decidePolicyForResponse):
(API::PolicyClient::unableToImplementPolicy):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setPolicyClient):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::unableToImplementPolicy):

6:04 PM Changeset in webkit [162671] by Simon Fraser
  • 4 edits in trunk/Source

Source/WebKit/efl: Fix EFL.

  • ewk/ewk_frame.cpp:

(ewk_frame_visible_content_geometry_get):

Source/WebKit2: Fix GTK.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkitWebPageDidReceiveMessage):

6:00 PM Changeset in webkit [162670] by andersca@apple.com
  • 8 edits
    1 add in trunk/Source/WebKit2

Add an APILoaderClient base class
https://bugs.webkit.org/show_bug.cgi?id=127527

Reviewed by Tim Horton.

  • UIProcess/API/APILoaderClient.h: Added.

(API::LoaderClient::~LoaderClient):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPageLoaderClient):
(-[WKBrowsingContextController setLoadDelegate:]):
(+[WKBrowsingContextController _browsingContextControllerForPageRef:]):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::WebLoaderClient):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setLoaderClient):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didChangeBackForwardList):
(WebKit::WebPageProxy::willGoToBackForwardListItem):
(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::didStartProgress):
(WebKit::WebPageProxy::didChangeProgress):
(WebKit::WebPageProxy::didFinishProgress):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::didFirstLayoutForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebPageProxy::didLayout):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
(WebKit::WebPageProxy::didDisplayInsecureContentForFrame):
(WebKit::WebPageProxy::didRunInsecureContentForFrame):
(WebKit::WebPageProxy::didDetectXSSForFrame):
(WebKit::WebPageProxy::webGLPolicyForURL):
(WebKit::WebPageProxy::processDidBecomeUnresponsive):
(WebKit::WebPageProxy::interactionOccurredWhileProcessUnresponsive):
(WebKit::WebPageProxy::processDidBecomeResponsive):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::canAuthenticateAgainstProtectionSpaceInFrame):
(WebKit::WebPageProxy::didReceiveAuthenticationChallengeProxy):
(WebKit::WebPageProxy::didFailToInitializePlugin):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::loaderClient):

  • WebKit2.xcodeproj/project.pbxproj:
5:52 PM Changeset in webkit [162669] by mhahnenberg@apple.com
  • 4046 edits
    703 adds
    1 delete in branches/jsCStack

Merge branch up to ToT r162666.

5:52 PM Changeset in webkit [162668] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Another Windows fix: include <algorithm> for std::min and std::max.

  • platform/graphics/IntSize.h:
5:28 PM Changeset in webkit [162667] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

Build break after r162650
https://bugs.webkit.org/show_bug.cgi?id=127525

Reviewed by Anders Carlsson.

WKPreferences.h was renamed to WKPreferencesRef.

  • UIProcess/API/C/WKPreferences.cpp:
5:18 PM Changeset in webkit [162666] by fpizlo@apple.com
  • 8 edits in branches/jsCStack/Source/JavaScriptCore

3x splay regression in FTL with experimental coverage that is entirely due to Bartlett weirdness
https://bugs.webkit.org/show_bug.cgi?id=127463

Reviewed by Mark Hahnenberg.

This turned out to be entirely due to misuse of the scratch buffer in an FTL thunk.
We need to mark a scratch buffer as unused after we're done with it or else the GC
will have a bad time.

But, this also introduces some debugging-related things that were useful on my
journey.

Finally, this turns all experimental FTL coverage into non-experimental coverage for
now. I'm keeping the option because we will probably make other things "experimental"
in the near future, if they cause regressions.

  • dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run): Made it possible to disable FTL OSR entry.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile): Make the new NodeTypes non-experimental.

  • ftl/FTLThunks.cpp:

(JSC::FTL::osrExitGenerationThunkGenerator): Fix the actual bug.

  • llint/LowLevelInterpreter.asm:
  • runtime/Options.h:
  • runtime/VM.cpp:

(JSC::logSanitizeStack):

  • runtime/VM.h:

(JSC::sanitizeStackForVM): This is all about making it possible to print things when the stack is sanitized.

5:15 PM Changeset in webkit [162665] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a refactoring bug that crept in and is causing the inspector to crash.

  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForResponse):

5:08 PM Changeset in webkit [162664] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Try to fix Windows build.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::visibleSize):

  • platform/win/PopupMenuWin.h:
4:39 PM Changeset in webkit [162663] by Simon Fraser
  • 33 edits in trunk/Source

Make visibleContentRect() return actualVisibleContentRect() on iOS most of the time
https://bugs.webkit.org/show_bug.cgi?id=127456

Reviewed by Antti Koivisto.

On iOS, visibleContentRect() returns the entire document rect for historical
reasons, and actualVisibleContentRect() returns what visibleContentRect()
returns on other platforms.

In addition, actualVisibleContentRect() was returning an empty rect in WK2.

Reduce the confusion of #ifdefs by making visibleContentRect() behave like
actualVisibleContentRect() by default on iOS. Where it needs the old behavior,
an optional parameter, LegacyIOSDocumentVisibleRect, provides this.

Achieve this by having the virtual ScrollableArea::visibleContentRectInternal(),
which is called by non-virtual visibleContentRect() and visibleContentRectIncludingScrollbars().

Similarly clean up visibleHeight/visibleWidth functions by having visibleSize() be virtual,
with non-virtual visibleHeight() and visibleWidth().

ScrollableArea subclasses override visibleContentRectInternal() and visibleSize() where necessary.

Mechanically change all the call sites of actualVisibleContentRect() to
use visibleContentRect(), and the call sites of visibleContentRect()
to visibleContentRect(..., LegacyIOSDocumentVisibleRect), adding comments
where this may not be appropriate.

Change callers of visibleContentRect(IncludeScrollbars...) to visibleContentRectIncludingScrollbars().

Also add actualScrollPosition(), and clean up some actualScroll* call sites.

No behavior change.

Source/WebCore:

  • WebCore.exp.in:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isOnscreen):
(WebCore::AccessibilityObject::scrollToMakeVisibleWithSubFocus):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isOffScreen):

  • dom/Document.cpp:

(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale):
(WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale):

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

  • editing/Editor.cpp:

(WebCore::Editor::countMatchesForText):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::bounds):
(WebCore::FrameSelection::getClippedVisibleTextRectangles):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::scrollLeft):
(WebCore::HTMLBodyElement::scrollTop):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::imageFitsInWindow):
(WebCore::ImageDocument::windowSizeChanged):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollBy):

  • page/FrameView.cpp:

(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::layout):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::sendResizeEventIfNeeded):
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::isScrollable):
(WebCore::FrameView::paintControlTints):

  • page/SpatialNavigation.cpp:

(WebCore::canScrollInDirection):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::visibleContentRectInternal):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::paint):

  • platform/ScrollView.h:

(WebCore::ScrollView::scrollOffset):
(WebCore::ScrollView::actualScrollX):
(WebCore::ScrollView::actualScrollY):
(WebCore::ScrollView::actualScrollPosition):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::visibleContentRect):
(WebCore::ScrollableArea::visibleContentRectIncludingScrollbars):
(WebCore::ScrollableArea::visibleContentRectInternal):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::visibleWidth):
(WebCore::ScrollableArea::visibleHeight):

  • platform/graphics/IntSize.h:

(WebCore::IntSize::expandedTo): Drive-by cleanup.
(WebCore::IntSize::shrunkTo):

  • platform/gtk/ScrollViewGtk.cpp:

(WebCore::ScrollView::visibleContentRect):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::maximumScrollPosition):
(WebCore::RenderLayer::visibleContentRectInternal):
(WebCore::RenderLayer::hitTest):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):

  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::viewRect):
(WebCore::RenderView::viewportSize):

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/WebPage/ViewGestureGeometryCollector.cpp:

(WebKit::ViewGestureGeometryCollector::collectGeometryForMagnificationGesture):
(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::visibleContentBounds):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToPage):

4:36 PM Changeset in webkit [162662] by timothy_horton@apple.com
  • 10 edits in trunk/Source/WebKit2

[wk2] Page Overlays: Add API to clear the page overlay (and get rid of its backing store)
https://bugs.webkit.org/show_bug.cgi?id=127518

Reviewed by Anders Carlsson.

Add WKBundlePageOverlayClear, to allow clients of the page overlay API to
manually clear the page overlay's backing store, for memory, power, and performance gains.

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(WKBundlePageOverlayClear):

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::clearPageOverlay):

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::clear):

  • WebProcess/WebPage/PageOverlay.h:

Add WKBundlePageOverlayClear and plumb it through PageOverlay to the DrawingArea.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::clearPageOverlay):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::clearPageOverlay):
Set the layer to drawsContent=false and give it 0x0 size, effectively
removing its backing store.

4:36 PM Changeset in webkit [162661] by fpizlo@apple.com
  • 1 edit
    1 add in branches/jsCStack/Source/WTF

Unreviewed, fix build by adding a missing file.

  • wtf/IteratorPair.h: Added.
4:23 PM Changeset in webkit [162660] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Turn text-decoration-skip: ink on for all underlines
https://bugs.webkit.org/show_bug.cgi?id=127331

Reviewed by Antti Koivisto.

No new tests are necessary because tests already exist

  • rendering/style/RenderStyle.h:
4:06 PM Changeset in webkit [162659] by hmuller@adobe.com
  • 5 edits
    8 adds in trunk

[CSS Shapes] Image valued shape size and position should conform to the spec
https://bugs.webkit.org/show_bug.cgi?id=123295

Reviewed by Andreas Kling.

Source/WebCore:

Implement image valued shape-outside scaling and translation per the spec,
http://dev.w3.org/csswg/css-shapes/#shapes-from-image:

"The image is sized and positioned as if it were a replaced element whose
specified width and height are the same as the element’s used content box size."

This change doesn't completely fulfill the spec, it's limited to image elements
and shape-outside.

Tests: fast/shapes/shape-outside-floats/shape-outside-image-fit-001.html

fast/shapes/shape-outside-floats/shape-outside-image-fit-002.html
fast/shapes/shape-outside-floats/shape-outside-image-fit-003.html
fast/shapes/shape-outside-floats/shape-outside-image-fit-004.html

  • rendering/shapes/Shape.h:
  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):
Added an imageRect parameter which specifies where the shape image is to
appear relative to the content box. The imageRect implies both scaling and
translation of the shape image.

  • rendering/shapes/ShapeInfo.cpp:

(WebCore::ShapeInfo<RenderType>::computedShape):
(WebCore::getShapeImageRect):
For replaced elements, compute the shape's imageRect with
RenderReplaced::replacedContentRect().

LayoutTests:

  • fast/shapes/shape-outside-floats/shape-outside-image-fit-001-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-image-fit-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-image-fit-002-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-image-fit-002.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-image-fit-003-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-image-fit-003.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-image-fit-004-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-image-fit-004.html: Added.
4:01 PM Changeset in webkit [162658] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Explicitly link XPC services with AppKit
https://bugs.webkit.org/show_bug.cgi?id=127520
<rdar://problem/15759718>

Reviewed by Mark Rowe.

Explicitly link XPC services that use the _NSApplicationMain run loop type with AppKit.

  • Configurations/PluginService.32.xcconfig:
  • Configurations/PluginService.64.xcconfig:
  • Configurations/PluginService.Development.xcconfig:
  • Configurations/WebContentService.Development.xcconfig:
  • Configurations/WebContentService.xcconfig:
3:50 PM Changeset in webkit [162657] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build again.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _windowDidChangeBackingProperties:]):

3:45 PM Changeset in webkit [162656] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Another 32-bit build fix.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _windowDidChangeBackingProperties:]):

3:28 PM Changeset in webkit [162655] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Clean up WKView.mm a little
https://bugs.webkit.org/show_bug.cgi?id=127517

Reviewed by Tim Horton.

Remove an unused ivar and migrate to API constants that were added in Lion.

  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):
(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidResize:]):
(-[WKView _windowDidChangeBackingProperties:]):

3:23 PM Changeset in webkit [162654] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build.

  • UIProcess/API/Cocoa/WKPreferences.mm:
3:22 PM Changeset in webkit [162653] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

Remove an unneeded synchronous back/forward message
https://bugs.webkit.org/show_bug.cgi?id=127516

Reviewed by Tim Horton.

  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeLoaderClient):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
3:13 PM Changeset in webkit [162652] by mark.lam@apple.com
  • 18 edits in trunk/Source/JavaScriptCore

Enable DFG for the Debugger and Profiler.
<https://webkit.org/b/122847>

Reviewed by Geoffrey Garen.

In this patch, we implement DFG op_debug as a series of 3 checks:

  1. Check if the debugger pointer is non-null. This is needed in case the debugger has been detached but the DFG code is still running on the stack.
  2. Check if Debugger::m_shouldPause is true.
  3. Check if CodeBlock::m_numBreakpoints is non-zero.

These are the same 3 checks done in the LLINT and baselineJIT. But unlike
the LLINT and baselineJIT, these DFG checks are implemented as
speculationChecks. If the check fails, we OSR exit to the baselineJIT and
let it do the work of servicing the op_debug callback.

Stepping through code in the debugger would work the same way. The top
function being debugged has to be a LLINT or baselineJIT function because
we would have OSR exited if there is a breakpoint in that function. When
we step out of that function to its caller, we expect that the caller will
call back to the debugger at the next op_debug. If the caller function is
a DFG function, the op_debug site will fail its speculation check on
Debugger::m_shouldPause and deopt into a baselineJIT function. Execution
continues from there as usual, and the debugger gets its callback.

For the profile, op_profile_will_call and op_profile_did_call are
implemented as simple runtime calls to service the profiler.

With this patch, Octane performance with the WebInspector open jump from
~2000 to ~2500 (25% progression).

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numBreakpointsAddress):

  • bytecode/ExitKind.cpp:

(JSC::exitKindToString):

  • bytecode/ExitKind.h:
  • debugger/Debugger.cpp:

(JSC::Debugger::toggleBreakpoint):

  • removed an obsolete assertion. The debugger can now handle DFG CodeBlocks too.
  • debugger/Debugger.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::debuggerAddress):

3:10 PM Changeset in webkit [162651] by mhahnenberg@apple.com
  • 3458 edits
    738 adds in branches/jsCStack

.: Merge branch up to ToT r161658.

PerformanceTests: Merge branch up to ToT r161658.

Source/JavaScriptCore: Merge branch up to ToT r161658.

Source/ThirdParty: Merge branch up to ToT r161658.

Source/ThirdParty/ANGLE: Merge branch up to ToT r161658.

Source/WebCore: Merge branch up to ToT r161658.

Source/WebCore/platform/gtk/po: Merge branch up to ToT r161658.

Source/WebInspectorUI: Merge branch up to ToT r161658.

Source/WebKit: Merge branch up to ToT r161658.

Source/WebKit/blackberry: Merge branch up to ToT r161658.

Source/WebKit/efl: Merge branch up to ToT r161658.

Source/WebKit/gtk: Merge branch up to ToT r161658.

Source/WebKit/ios: Merge branch up to ToT r161658.

Source/WebKit/mac: Merge branch up to ToT r161658.

Source/WebKit/win: Merge branch up to ToT r161658.

Source/WebKit2: Merge branch up to ToT r161658.

Source/WTF: Merge branch up to ToT r161658.

Tools: Merge branch up to ToT r161658.

WebKitLibraries: Merge branch up to ToT r161658.

Websites/bugs.webkit.org: Merge branch up to ToT r161658.

Websites/webkit.org: Merge branch up to ToT r161658.

LayoutTests: Merge branch up to ToT r161658.

3:03 PM Changeset in webkit [162650] by andersca@apple.com
  • 4 edits
    1 move
    2 adds in trunk/Source/WebKit2

Rename WKPreferences.h to WKPreferencesRef.h and add a stubbed out WKPreferences class
https://bugs.webkit.org/show_bug.cgi?id=127512

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPreferencesRef.h: Renamed from Source/WebKit2/UIProcess/API/C/WKPreferences.h.
  • UIProcess/API/C/WebKit2_C.h:
  • UIProcess/API/Cocoa/WKPreferences.h: Added.
  • UIProcess/API/Cocoa/WKPreferences.mm: Added.
  • WebKit2.xcodeproj/project.pbxproj:
3:00 PM Changeset in webkit [162649] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

Rebaseline after r162640.

  • platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt:
2:59 PM Changeset in webkit [162648] by Lucas Forschler
  • 1 edit in tags/Safari-538.13/Source/WebInspectorUI/UserInterface/Main.html

Merged r162634. <rdar://problem/15888967>

2:54 PM Changeset in webkit [162647] by Lucas Forschler
  • 11 edits
    3 deletes in tags/Safari-538.13

Rollout 161455.

2:45 PM Changeset in webkit [162646] by Brent Fulgham
  • 12 edits
    2 copies in branches/safari-537.75-branch

Source/WebCore: Merge r154470.

2013-08-22 Simon Fraser <Simon Fraser>

compositing/geometry/bounds-ignores-hidden-dynamic.html has incorrect initial rendering
https://bugs.webkit.org/show_bug.cgi?id=119825

Reviewed by Tim Horton.


r137526 and some earlier commits attempted to avoid unconditionally
repainting layers when their size changes, because this was causing
TiledBacking layers to repaint when the document size changed.


However, the approach required that we have good information about
whether size changes require a repaint, which in some cases is hard
to determine, especially when RenderLayer changes affect our
decisions about which layers are composited.


Fix by pushing the decision about whether to repaint on size change
into GraphicsLayer. The default is to repaint on size change,
but GraphicsLayer provides a function that can be overridden to
modify this behavior; GraphicsLayerCA does so to avoid repaints
when layers with TiledBackings get resized.

Test: compositing/repaint/repaint-on-layer-grouping-change.html

  • WebCore.exp.in: WebKit2 needs GraphicsLayer::setSize, which is no longer inline.
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setOffsetFromRenderer): (WebCore::GraphicsLayer::setSize):
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::shouldRepaintOnSizeChange):
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::shouldRepaintOnSizeChange):
  • platform/graphics/ca/GraphicsLayerCA.h:
  • rendering/RenderLayerBacking.h: No longer need m_boundsConstrainedByClipping
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::updateCompositedBounds): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): setSize takes care of repainting for us now, so we can remove all the conditional code.

LayoutTests: Merge r154470

2013-08-22 Simon Fraser <Simon Fraser>

compositing/geometry/bounds-ignores-hidden-dynamic.html has incorrect initial rendering
https://bugs.webkit.org/show_bug.cgi?id=119825

Reviewed by Tim Horton.


Test that dumps repaint rects on layers after visibility changes affect
the layer hierarchy.

  • compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Added.
  • compositing/repaint/repaint-on-layer-grouping-change.html: Added.
  • compositing/repaint/resize-repaint-expected.txt: Update result.
2:32 PM Changeset in webkit [162645] by Lucas Forschler
  • 2 edits in tags/Safari-538.13/Source/WebCore

Rollout 161778.

2:31 PM Changeset in webkit [162644] by mvujovic@adobe.com
  • 156 edits
    116 deletes in trunk

Remove CSS Custom Filters code and tests
https://bugs.webkit.org/show_bug.cgi?id=127382

Reviewed by Simon Fraser.

.:

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests. Removing functionality.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.order:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJS):

  • bindings/objc/DOMCSS.mm:

(kitClass):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForFilter):
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseValue):
(WebCore::filterInfoForName):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::detectAtToken):

  • css/CSSParser.h:
  • css/CSSParserMode.h:
  • css/CSSPropertyNames.in:
  • css/CSSPropertySourceData.h:
  • css/CSSRule.h:
  • css/CSSRule.idl:
  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

  • css/CSSValue.h:
  • css/CSSValueKeywords.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::applyProperty):
(WebCore::filterOperationForType):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingResources):

  • css/StyleResolver.h:

(WebCore::StyleResolver::State::State):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):

  • css/StyleRule.h:
  • css/StyleSheetContents.cpp:

(WebCore::childRulesHaveFailedOrCanceledSubresources):

  • css/WebKitCSSArrayFunctionValue.cpp: Removed.
  • css/WebKitCSSArrayFunctionValue.h: Removed.
  • css/WebKitCSSFilterRule.cpp: Removed.
  • css/WebKitCSSFilterRule.h: Removed.
  • css/WebKitCSSFilterRule.idl: Removed.
  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
(WebCore::WebKitCSSFilterValue::customCSSText):

  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSMatFunctionValue.cpp: Removed.
  • css/WebKitCSSMatFunctionValue.h: Removed.
  • css/WebKitCSSMixFunctionValue.cpp: Removed.
  • css/WebKitCSSMixFunctionValue.h: Removed.
  • css/WebKitCSSMixFunctionValue.idl: Removed.
  • css/WebKitCSSShaderValue.cpp: Removed.
  • css/WebKitCSSShaderValue.h: Removed.
  • loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedShader.cpp: Removed.
  • loader/cache/CachedShader.h: Removed.
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFilter):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::filtersCanBeComposited):

  • platform/graphics/filters/CustomFilterArrayParameter.h: Removed.
  • platform/graphics/filters/CustomFilterColorParameter.h: Removed.
  • platform/graphics/filters/CustomFilterCompiledProgram.cpp: Removed.
  • platform/graphics/filters/CustomFilterCompiledProgram.h: Removed.
  • platform/graphics/filters/CustomFilterConstants.h: Removed.
  • platform/graphics/filters/CustomFilterGlobalContext.cpp: Removed.
  • platform/graphics/filters/CustomFilterGlobalContext.h: Removed.
  • platform/graphics/filters/CustomFilterMesh.cpp: Removed.
  • platform/graphics/filters/CustomFilterMesh.h: Removed.
  • platform/graphics/filters/CustomFilterMeshGenerator.cpp: Removed.
  • platform/graphics/filters/CustomFilterMeshGenerator.h: Removed.
  • platform/graphics/filters/CustomFilterNumberParameter.h: Removed.
  • platform/graphics/filters/CustomFilterOperation.cpp: Removed.
  • platform/graphics/filters/CustomFilterOperation.h: Removed.
  • platform/graphics/filters/CustomFilterParameter.h: Removed.
  • platform/graphics/filters/CustomFilterParameterList.cpp: Removed.
  • platform/graphics/filters/CustomFilterParameterList.h: Removed.
  • platform/graphics/filters/CustomFilterProgram.cpp: Removed.
  • platform/graphics/filters/CustomFilterProgram.h: Removed.
  • platform/graphics/filters/CustomFilterProgramClient.h: Removed.
  • platform/graphics/filters/CustomFilterProgramInfo.cpp: Removed.
  • platform/graphics/filters/CustomFilterProgramInfo.h: Removed.
  • platform/graphics/filters/CustomFilterRenderer.cpp: Removed.
  • platform/graphics/filters/CustomFilterRenderer.h: Removed.
  • platform/graphics/filters/CustomFilterTransformParameter.h: Removed.
  • platform/graphics/filters/CustomFilterValidatedProgram.cpp: Removed.
  • platform/graphics/filters/CustomFilterValidatedProgram.h: Removed.
  • platform/graphics/filters/FECustomFilter.cpp: Removed.
  • platform/graphics/filters/FECustomFilter.h: Removed.
  • platform/graphics/filters/FilterOperation.h:
  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::outsets):

  • platform/graphics/filters/FilterOperations.h:
  • platform/graphics/filters/ValidatedCustomFilterOperation.cpp: Removed.
  • platform/graphics/filters/ValidatedCustomFilterOperation.h: Removed.
  • platform/graphics/filters/texmap/CustomFilterValidatedProgramTextureMapper.cpp: Removed.
  • platform/graphics/filters/texmap/TextureMapperPlatformCompiledProgram.h: Removed.
  • platform/graphics/gpu/Texture.cpp:
  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::getPassesRequiredForFilter):
(WebCore::BitmapTextureGL::applyFilters):

  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::clearPendingStateChanges):
(WebCore::CompositingCoordinator::syncLayerState):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.h:
  • platform/graphics/texmap/coordinated/CoordinatedCustomFilterOperation.h: Removed.
  • platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h: Removed.
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::setLayerFiltersIfNeeded):
(WebCore::CoordinatedGraphicsScene::commitSceneState):
(WebCore::CoordinatedGraphicsScene::setLayerAnimationsIfNeeded):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):

  • rendering/FilterEffectRenderer.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateFilters):

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayer::FilterInfo::~FilterInfo):

  • rendering/RenderLayerFilterInfo.h:
  • rendering/RenderView.cpp:
  • rendering/RenderView.h:
  • rendering/style/StyleCachedShader.cpp: Removed.
  • rendering/style/StyleCachedShader.h: Removed.
  • rendering/style/StyleCustomFilterProgram.cpp: Removed.
  • rendering/style/StyleCustomFilterProgram.h: Removed.
  • rendering/style/StyleCustomFilterProgramCache.cpp: Removed.
  • rendering/style/StyleCustomFilterProgramCache.h: Removed.
  • rendering/style/StylePendingShader.h: Removed.
  • rendering/style/StyleShader.h: Removed.

Source/WebCore/platform/gtk/po:

No new tests. Removing functionality.

  • ar.po:
  • as.po:
  • bg.po:
  • cs.po:
  • de.po:
  • el.po:
  • en_CA.po:
  • en_GB.po:
  • eo.po:
  • es.po:
  • et.po:
  • eu.po:
  • fr.po:
  • gl.po:
  • gu.po:
  • he.po:
  • hi.po:
  • hu.po:
  • id.po:
  • it.po:
  • kn.po:
  • ko.po:
  • lt.po:
  • lv.po:
  • ml.po:
  • mr.po:
  • nb.po:
  • nl.po:
  • or.po:
  • pa.po:
  • pl.po:
  • pt.po:
  • pt_BR.po:
  • ro.po:
  • ru.po:
  • sl.po:
  • sr.po:
  • sr@latin.po:
  • sv.po:
  • ta.po:
  • te.po:
  • uk.po:
  • vi.po:
  • zh_CN.po:

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(IPC::ArgumentCoder<WebCore::FilterOperations>::encode):
(IPC::ArgumentCoder<WebCore::FilterOperations>::decode):
(IPC::ArgumentCoder<CoordinatedGraphicsState>::encode):
(IPC::ArgumentCoder<CoordinatedGraphicsState>::decode):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
  • Shared/CoordinatedGraphics/WebCustomFilterProgramProxy.cpp: Removed.
  • Shared/CoordinatedGraphics/WebCustomFilterProgramProxy.h: Removed.
  • Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeFilterOperation):
(IPC::decodeFilterOperation):

  • Shared/WebPreferencesStore.h:
  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::operator<<):

  • UIProcess/API/C/WKPreferences.cpp:
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • mac/WebKit2.order:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::overridePreference):

LayoutTests:

  • animations/resources/animation-test-helpers.js:

(parseFilterFunctionList):
(compareFilterFunctions):

  • css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid-expected.txt: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid.html: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid-expected.txt: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid.html: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid.html: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid.html: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid-expected.txt: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid.html: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid-expected.txt: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid.html: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid-expected.txt: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid.html: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid-expected.txt: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid.html: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid.html: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid.html: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-src-property-invalid-expected.txt: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-src-property-invalid.html: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid-expected.txt: Removed.
  • css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid.html: Removed.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-invalid.js: Removed.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-valid.js: Removed.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js: Removed.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js: Removed.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-geometry-property-invalid.js: Removed.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-geometry-property-valid.js: Removed.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-mix-property-invalid.js: Removed.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-mix-property-valid.js: Removed.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js: Removed.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js: Removed.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-src-property-invalid.js: Removed.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-src-property-valid.js: Removed.
  • css3/filters/custom/composited/custom-filter-blend-modes-expected.html: Removed.
  • css3/filters/custom/composited/custom-filter-blend-modes.html: Removed.
  • css3/filters/custom/custom-filter-a-tex-coord-optional-expected.html: Removed.
  • css3/filters/custom/custom-filter-a-tex-coord-optional.html: Removed.
  • css3/filters/custom/custom-filter-animation-expected.txt: Removed.
  • css3/filters/custom/custom-filter-animation.html: Removed.
  • css3/filters/custom/custom-filter-array-blending-expected.txt: Removed.
  • css3/filters/custom/custom-filter-array-blending.html: Removed.
  • css3/filters/custom/custom-filter-array-expected.html: Removed.
  • css3/filters/custom/custom-filter-array-uniform-indirect-index-expected.html: Removed.
  • css3/filters/custom/custom-filter-array-uniform-indirect-index.html: Removed.
  • css3/filters/custom/custom-filter-array.html: Removed.
  • css3/filters/custom/custom-filter-blend-fractional-destination-alpha-expected.html: Removed.
  • css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html: Removed.
  • css3/filters/custom/custom-filter-blend-modes-expected.html: Removed.
  • css3/filters/custom/custom-filter-blend-modes.html: Removed.
  • css3/filters/custom/custom-filter-change-blend-mode-expected.html: Removed.
  • css3/filters/custom/custom-filter-change-blend-mode.html: Removed.
  • css3/filters/custom/custom-filter-clamp-css-color-matrix-expected.html: Removed.
  • css3/filters/custom/custom-filter-clamp-css-color-matrix-negative-expected.html: Removed.
  • css3/filters/custom/custom-filter-clamp-css-color-matrix-negative.html: Removed.
  • css3/filters/custom/custom-filter-clamp-css-color-matrix.html: Removed.
  • css3/filters/custom/custom-filter-clamp-css-mix-color-expected.html: Removed.
  • css3/filters/custom/custom-filter-clamp-css-mix-color-negative-expected.html: Removed.
  • css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html: Removed.
  • css3/filters/custom/custom-filter-clamp-css-mix-color.html: Removed.
  • css3/filters/custom/custom-filter-color-expected.html: Removed.
  • css3/filters/custom/custom-filter-color-matrix-expected.png: Removed.
  • css3/filters/custom/custom-filter-color-matrix-expected.txt: Removed.
  • css3/filters/custom/custom-filter-color-matrix.html: Removed.
  • css3/filters/custom/custom-filter-color.html: Removed.
  • css3/filters/custom/custom-filter-composite-fractional-source-alpha-expected.html: Removed.
  • css3/filters/custom/custom-filter-composite-fractional-source-alpha.html: Removed.
  • css3/filters/custom/custom-filter-composite-operators-expected.png: Removed.
  • css3/filters/custom/custom-filter-composite-operators-expected.txt: Removed.
  • css3/filters/custom/custom-filter-composite-operators.html: Removed.
  • css3/filters/custom/custom-filter-composite-source-atop-expected.png: Removed.
  • css3/filters/custom/custom-filter-composite-source-atop-expected.txt: Removed.
  • css3/filters/custom/custom-filter-composite-source-atop.html: Removed.
  • css3/filters/custom/custom-filter-crash-inline-computed-style-expected.txt: Removed.
  • css3/filters/custom/custom-filter-crash-inline-computed-style.html: Removed.
  • css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Removed.
  • css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.txt: Removed.
  • css3/filters/custom/custom-filter-css-keyword-as-parameter-name.html: Removed.
  • css3/filters/custom/custom-filter-detached-mesh-with-mesh-box-type-expected.html: Removed.
  • css3/filters/custom/custom-filter-detached-mesh-with-mesh-box-type.html: Removed.
  • css3/filters/custom/custom-filter-matN-expected.html: Removed.
  • css3/filters/custom/custom-filter-matN.html: Removed.
  • css3/filters/custom/custom-filter-mesh-column-row-order-expected.html: Removed.
  • css3/filters/custom/custom-filter-mesh-column-row-order.html: Removed.
  • css3/filters/custom/custom-filter-mix-bindings-expected.txt: Removed.
  • css3/filters/custom/custom-filter-mix-bindings.html: Removed.
  • css3/filters/custom/custom-filter-no-element-texture-access-expected.html: Removed.
  • css3/filters/custom/custom-filter-no-element-texture-access.html: Removed.
  • css3/filters/custom/custom-filter-nonseparable-blend-mode-color-expected.html: Removed.
  • css3/filters/custom/custom-filter-nonseparable-blend-mode-color.html: Removed.
  • css3/filters/custom/custom-filter-nonseparable-blend-mode-hue-expected.html: Removed.
  • css3/filters/custom/custom-filter-nonseparable-blend-mode-hue.html: Removed.
  • css3/filters/custom/custom-filter-nonseparable-blend-mode-luminosity-expected.html: Removed.
  • css3/filters/custom/custom-filter-nonseparable-blend-mode-luminosity.html: Removed.
  • css3/filters/custom/custom-filter-nonseparable-blend-mode-saturation-expected.html: Removed.
  • css3/filters/custom/custom-filter-nonseparable-blend-mode-saturation.html: Removed.
  • css3/filters/custom/custom-filter-property-computed-style-expected.txt: Removed.
  • css3/filters/custom/custom-filter-property-computed-style.html: Removed.
  • css3/filters/custom/custom-filter-property-parsing-expected.txt: Removed.
  • css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt: Removed.
  • css3/filters/custom/custom-filter-property-parsing-invalid.html: Removed.
  • css3/filters/custom/custom-filter-property-parsing.html: Removed.
  • css3/filters/custom/custom-filter-reload-expected.txt: Removed.
  • css3/filters/custom/custom-filter-reload.html: Removed.
  • css3/filters/custom/custom-filter-shader-cache-expected.png: Removed.
  • css3/filters/custom/custom-filter-shader-cache-expected.txt: Removed.
  • css3/filters/custom/custom-filter-shader-cache.html: Removed.
  • css3/filters/custom/custom-filter-shader-reuse-expected.txt: Removed.
  • css3/filters/custom/custom-filter-shader-reuse.html: Removed.
  • css3/filters/custom/custom-filter-transforms-animation-expected.txt: Removed.
  • css3/filters/custom/custom-filter-transforms-animation.html: Removed.
  • css3/filters/custom/custom-filter-u-mesh-box-expected.html: Removed.
  • css3/filters/custom/custom-filter-u-mesh-box.html: Removed.
  • css3/filters/custom/custom-filter-u-mesh-size-expected.html: Removed.
  • css3/filters/custom/custom-filter-u-mesh-size.html: Removed.
  • css3/filters/custom/custom-filter-u-texture-size-expected.html: Removed.
  • css3/filters/custom/custom-filter-u-texture-size.html: Removed.
  • css3/filters/custom/custom-filter-u-tile-size-expected.html: Removed.
  • css3/filters/custom/custom-filter-u-tile-size.html: Removed.
  • css3/filters/custom/custom-filter-unavailable-varying-expected.html: Removed.
  • css3/filters/custom/custom-filter-unavailable-varying.html: Removed.
  • css3/filters/custom/effect-color-check-expected.png: Removed.
  • css3/filters/custom/effect-color-check-expected.txt: Removed.
  • css3/filters/custom/effect-color-check.html: Removed.
  • css3/filters/custom/effect-custom-combined-missing-expected.png: Removed.
  • css3/filters/custom/effect-custom-combined-missing-expected.txt: Removed.
  • css3/filters/custom/effect-custom-combined-missing.html: Removed.
  • css3/filters/custom/effect-custom-disabled-expected.txt: Removed.
  • css3/filters/custom/effect-custom-disabled.html: Removed.
  • css3/filters/custom/effect-custom-expected.png: Removed.
  • css3/filters/custom/effect-custom-expected.txt: Removed.
  • css3/filters/custom/effect-custom-parameters-expected.png: Removed.
  • css3/filters/custom/effect-custom-parameters-expected.txt: Removed.
  • css3/filters/custom/effect-custom-parameters.html: Removed.
  • css3/filters/custom/effect-custom-transform-parameters-expected.html: Removed.
  • css3/filters/custom/effect-custom-transform-parameters.html: Removed.
  • css3/filters/custom/effect-custom.html: Removed.
  • css3/filters/custom/filter-fallback-to-software-expected.html: Removed.
  • css3/filters/custom/filter-fallback-to-software.html: Removed.
  • css3/filters/custom/filter-repaint-custom-clipped-expected.png: Removed.
  • css3/filters/custom/filter-repaint-custom-clipped-expected.txt: Removed.
  • css3/filters/custom/filter-repaint-custom-clipped.html: Removed.
  • css3/filters/custom/filter-repaint-custom-expected.png: Removed.
  • css3/filters/custom/filter-repaint-custom-expected.txt: Removed.
  • css3/filters/custom/filter-repaint-custom-rotated-expected.png: Removed.
  • css3/filters/custom/filter-repaint-custom-rotated-expected.txt: Removed.
  • css3/filters/custom/filter-repaint-custom-rotated.html: Removed.
  • css3/filters/custom/filter-repaint-custom.html: Removed.
  • css3/filters/custom/invalid-custom-filter-attribute-types-expected.html: Removed.
  • css3/filters/custom/invalid-custom-filter-attribute-types.html: Removed.
  • css3/filters/custom/invalid-custom-filter-shader-expected.html: Removed.
  • css3/filters/custom/invalid-custom-filter-shader.html: Removed.
  • css3/filters/custom/invalid-custom-filter-uniform-types-expected.html: Removed.
  • css3/filters/custom/invalid-custom-filter-uniform-types.html: Removed.
  • css3/filters/custom/missing-custom-filter-shader-expected.png: Removed.
  • css3/filters/custom/missing-custom-filter-shader-expected.txt: Removed.
  • css3/filters/custom/missing-custom-filter-shader.html: Removed.
  • css3/filters/resources/a-tex-coord-defined.vs: Removed.
  • css3/filters/resources/a-tex-coord-undefined.vs: Removed.
  • css3/filters/resources/a-triangle-coord-defined.vs: Removed.
  • css3/filters/resources/array-uniform-indirect-index.vs: Removed.
  • css3/filters/resources/checkerboard.vs: Removed.
  • css3/filters/resources/color-fill.fs: Removed.
  • css3/filters/resources/color-offset.fs: Removed.
  • css3/filters/resources/composite.fs: Removed.
  • css3/filters/resources/css-keyword-as-parameter-name.fs: Removed.
  • css3/filters/resources/custom-filter-clamp-css-color-matrix-negative.fs: Removed.
  • css3/filters/resources/custom-filter-clamp-css-color-matrix.fs: Removed.
  • css3/filters/resources/custom-filter-parser.js: Removed.
  • css3/filters/resources/fragment-color.fs: Removed.
  • css3/filters/resources/fragment-colors.fs: Removed.
  • css3/filters/resources/fragment-matN.fs: Removed.
  • css3/filters/resources/grayscale-color-matrix.fs: Removed.
  • css3/filters/resources/invalid-a-triangle-coord-with-attached-mesh.vs: Removed.
  • css3/filters/resources/invalid-custom-attribute.vs: Removed.
  • css3/filters/resources/invalid-shader.vs: Removed.
  • css3/filters/resources/invalid-type-a-mesh-coord.vs: Removed.
  • css3/filters/resources/invalid-type-a-position.vs: Removed.
  • css3/filters/resources/invalid-type-a-tex-coord.vs: Removed.
  • css3/filters/resources/invalid-type-a-triangle-coord.vs: Removed.
  • css3/filters/resources/invalid-type-attribute-array.vs: Removed.
  • css3/filters/resources/invalid-type-u-mesh-box.fs: Removed.
  • css3/filters/resources/invalid-type-u-mesh-size.fs: Removed.
  • css3/filters/resources/invalid-type-u-projection-matrix.fs: Removed.
  • css3/filters/resources/invalid-type-u-texture-size.fs: Removed.
  • css3/filters/resources/invalid-type-u-tile-size.fs: Removed.
  • css3/filters/resources/invalid-type-uniform-array.fs: Removed.
  • css3/filters/resources/mix-color.fs: Removed.
  • css3/filters/resources/pass-tex-coord.vs: Removed.
  • css3/filters/resources/sample-defined-css-u-texture-mix.fs: Removed.
  • css3/filters/resources/sample-defined-css-u-texture.fs: Removed.
  • css3/filters/resources/sample-u-texture-mix.fs: Removed.
  • css3/filters/resources/sample-u-texture.fs: Removed.
  • css3/filters/resources/sample-undefined-css-u-texture-mix.fs: Removed.
  • css3/filters/resources/sample-undefined-css-u-texture.fs: Removed.
  • css3/filters/resources/u-mesh-box-is-unit-square.fs: Removed.
  • css3/filters/resources/u-mesh-size.fs: Removed.
  • css3/filters/resources/u-texture-size.fs: Removed.
  • css3/filters/resources/u-tile-size.fs: Removed.
  • css3/filters/resources/unavailable-varying.fs: Removed.
  • css3/filters/resources/varying-mix-color.fs: Removed.
  • css3/filters/resources/vertex-explode-detached.vs: Removed.
  • css3/filters/resources/vertex-horizontal-offset.vs: Removed.
  • css3/filters/resources/vertex-offset-parameters.vs: Removed.
  • css3/filters/resources/vertex-offset.vs: Removed.
  • css3/filters/resources/vertex-rotate.vs: Removed.
  • css3/filters/resources/vertex-transform-parameter.vs: Removed.
  • css3/filters/script-tests/custom-filter-mix-bindings.js: Removed.
  • css3/filters/script-tests/custom-filter-parsing-common.js: Removed.
  • css3/filters/script-tests/custom-filter-property-computed-style.js: Removed.
  • css3/filters/script-tests/custom-filter-property-parsing-invalid.js: Removed.
  • css3/filters/script-tests/custom-filter-property-parsing.js: Removed.
  • css3/filters/script-tests/effect-custom-disabled.js: Removed.
  • js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
2:24 PM Changeset in webkit [162643] by jhoneycutt@apple.com
  • 7 edits
    4 adds in trunk

REGRESSION(r161967): Crash in WebCore::CachedSVGDocumentReference::load
<https://webkit.org/b/127151>
<rdar://problem/15840760>

Source/WebCore:

There were two issues introduced here; the first is a use-after-free of
CachedSVGDocumentReference objects.

The previous code kept a map from FilterOperation ->
RefPtr<WebKitCSSSVGDocumentValue>, which retained the
CachedSVGDocument. In r161967, this was changed to use a weak HashSet,
which allows stale CachedSVGDocumentReferences in the pending document
set if the owning FilterOperation is deleted. To fix this, we'll keep a
vector of RefPtr<FilterOperation> with pending SVG documents.

The second issue is a null deref in CachedSVGDocumentReference::load();
CachedResourceLoader::requestSVGDocument() can return 0 if (for
example) an invalid URL is passed. r161967 removed a null check as part
of the refactoring.

Reviewed by Dirk Schulze.

Tests: css3/filters/crash-filter-animation-invalid-url.html

css3/filters/crash-invalid-url.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::clear):
Use new member var name.
(WebCore::StyleResolver::loadPendingSVGDocuments):
For each FilterOperation with a pending SVG document, get or create a
CachedSVGDocumentReference, and tell it to load. Changed to use new
function names.
(WebCore::StyleResolver::createFilterOperations):
Append the FilterOperation to the list of FilterOperations with
unloaded SVG documents.

  • css/StyleResolver.h:

Changed from using PendingSVGDocumentSet, a weak set, to
a Vector<RefPtr<ReferenceFilterOperation>>.
(WebCore::StyleResolver::State::filtersWithPendingSVGDocuments):
Return the vector.

  • loader/cache/CachedSVGDocumentReference.cpp:

(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
Null check m_document rather than checking m_loadRequested.
m_loadRequested may be true when m_document is 0.
(WebCore::CachedSVGDocumentReference::load):
Null check the result of CachedResourceLoader::requestSVGDocument().

  • platform/graphics/filters/FilterOperation.cpp:

(WebCore::ReferenceFilterOperation::getOrCreateCachedSVGDocumentReference):
Create, if necessary, and return the CachedSVGDocumentReference.

  • platform/graphics/filters/FilterOperation.h:

Replaced createCachedSVGDocumentReference() with
getOrCreateCachedSVGDocumentReference(), which makes for slightly
cleaner code.

LayoutTests:

Reviewed by Dirk Schulze.

  • css3/filters/crash-filter-animation-invalid-url-expected.txt: Added.
  • css3/filters/crash-filter-animation-invalid-url.html: Added.
  • css3/filters/crash-invalid-url-expected.txt: Added.
  • css3/filters/crash-invalid-url.html: Added.
2:12 PM Changeset in webkit [162642] by roger_fong@apple.com
  • 2 edits in trunk/WebKitLibraries

[Windows] Unreviewed. Disable unnecessary warning C4309, "truncation of constant value".

  • win/tools/vsprops/common.props:
2:09 PM Changeset in webkit [162641] by Brent Fulgham
  • 2 edits in branches/safari-537.75-branch/Source/WebKit

Unreviewed build correction.

  • WebKit.vcxproj/WebKit/WebKit.vcxproj: Link 32-bit builds against QTMovieWin for the time being.
2:03 PM Changeset in webkit [162640] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Don't enable speculative tiles immediately after main load stops progressing
https://bugs.webkit.org/show_bug.cgi?id=127507

Reviewed by Andreas Kling.

It is common for timers and events to trigger more loading after the initial main frame loading
has completed. We should delay a bit before enabling speculative tiles and keep them disabled
if loading still continues.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::adjustTiledBackingCoverage):
(WebCore::shouldEnableSpeculativeTilingDuringLoading):
(WebCore::FrameView::enableSpeculativeTilingIfNeeded):

When load progression stops wait 0.5s before enabling speculative tiles.

(WebCore::FrameView::speculativeTilingEnableTimerFired):

Don't enable speculative tiles if the progression has started again. Instead restart the timer.

  • page/FrameView.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::computeTileCoverage):

Move the FrameView level code to FrameView (so we don't need to add a timer to every RenderLayerBacking).

  • rendering/RenderLayerBacking.h:
2:01 PM Changeset in webkit [162639] by andersca@apple.com
  • 9 edits
    1 copy in trunk/Source/WebKit2

Add API::PolicyClient base class
https://bugs.webkit.org/show_bug.cgi?id=127509

Reviewed by Tim Horton.

  • UIProcess/API/APIPolicyClient.h: Copied from Source/WebKit2/UIProcess/WebPolicyClient.h.

(API::PolicyClient::~PolicyClient):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPagePolicyClient):

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPagePolicyClient):
(-[WKBrowsingContextController setPolicyDelegate:]):

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setPolicyClient):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::unableToImplementPolicy):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::WebPolicyClient):
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForResponse):

  • UIProcess/WebPolicyClient.h:
  • WebKit2.xcodeproj/project.pbxproj:
1:27 PM Changeset in webkit [162638] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add init methods that create default configurations
https://bugs.webkit.org/show_bug.cgi?id=127503

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKProcessClass.mm:

(-[WKProcessClass init]):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:]):

1:20 PM Changeset in webkit [162637] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Loads started soon after main frame completion should be considered part of the main load
https://bugs.webkit.org/show_bug.cgi?id=127504

Reviewed by Andreas Kling.

ProgressTracker currently decides that main load is complete when the main frame stops loading.
However it is common that timers and onload events trigger more loads immediately (for example
by inserting iframes) and loading continues visually. These should be considered as part of the
main load for paint throttling and speculative tiling coverage purposes.

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::progressStarted):

Track whether this is considered part of the main load or not with a boolean.
It is set for subframe loads too if they start loading soon (within 1s) after the main frame load completes.

(WebCore::ProgressTracker::finalProgressComplete):

Get a timestamp.

(WebCore::ProgressTracker::isMainLoadProgressing):

New definition of "main load".

  • loader/ProgressTracker.h:
1:19 PM Changeset in webkit [162636] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=127499

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-23
Reviewed by Brent Fulgham.

  • platform/network/curl/ResourceError.h: Include <winsock2.h> before <curl/curl.h>.
1:18 PM Changeset in webkit [162635] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

[WinCairo] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=127500

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-23
Reviewed by Brent Fulgham.

  • WebCache.cpp:

(WebCache::cacheFolder): CurlCacheManager::getCacheDirectory() has changed name to cacheDirectory().

12:56 PM Changeset in webkit [162634] by timothy@apple.com
  • 1 edit in trunk/Source/WebInspectorUI/UserInterface/Main.html

Production build fix.

12:25 PM Changeset in webkit [162633] by beidson@apple.com
  • 21 edits
    2 copies in trunk/Source

IDB: Implement cross-thread and IPC plumbing for 'get' support
https://bugs.webkit.org/show_bug.cgi?id=127501

Reviewed by Anders Carlsson.

Source/WebCore:

Add isolatedCopy to the IDBGetResult object:

  • Modules/indexeddb/IDBGetResult.h:

(WebCore::IDBGetResult::isolatedCopy):

Add a cross-thread and cross-IPC appropriate object for IDBKeyRanges:

  • Modules/indexeddb/IDBKeyRangeData.cpp: Copied from Source/WebCore/Modules/indexeddb/IDBGetResult.h.

(WebCore::IDBKeyRangeData::isolatedCopy):

  • Modules/indexeddb/IDBKeyRangeData.h: Copied from Source/WebCore/Modules/indexeddb/IDBGetResult.h.

(WebCore::IDBKeyRangeData::IDBKeyRangeData):

Add a few more cross-thread copiers:

  • platform/CrossThreadCopier.cpp:

(WebCore::IDBGetResult>::copy):
(WebCore::IDBKeyRangeData>::copy):

  • platform/CrossThreadCopier.h:

Project file gunk:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Make the WebProcess call out to the DatabaseProcess with a get request, and handle the
response from the DatabaseProcess:

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::get):
(WebKit::WebIDBServerConnection::didGetRecord):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:

Get the request from the WebProcess and forward it to the appropriate unique IDB database:

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::getRecord):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:

Forward the request to the database thread, and response to the result from that thread:

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::getRecord):
(WebKit::UniqueIDBDatabase::getRecordFromBackingStore):
(WebKit::UniqueIDBDatabase::didGetRecordFromBackingStore):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

IPC and asynchronous request infrastructure:

  • Scripts/webkit2/messages.py:

(struct_or_class):

  • Shared/AsyncTask.h:

(WebKit::createAsyncTask):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<IDBGetResult>::encode):
(IPC::ArgumentCoder<IDBGetResult>::decode):
(IPC::ArgumentCoder<IDBKeyRangeData>::encode):
(IPC::ArgumentCoder<IDBKeyRangeData>::decode):

  • Shared/WebCoreArgumentCoders.h:
12:12 PM Changeset in webkit [162632] by ap@apple.com
  • 1 edit
    2 deletes in trunk/LayoutTests

svg/animations/smil-syncbase-self-dependency.svg is very flaky

This is a newly landed test for <https://bugs.webkit.org/show_bug.cgi?id=108184>
that wasn't actually testing for what the bug fixed. The plan is to add a better
test soon, so deleting this one.

  • svg/animations/smil-syncbase-self-dependency-expected.txt: Removed.
  • svg/animations/smil-syncbase-self-dependency.svg: Removed.
12:08 PM Changeset in webkit [162631] by Brent Fulgham
  • 3 edits in branches/safari-537.75-branch/Source/WebCore

Unreviewed build fix after last commit. We haven't completely removed
QTMovieWin uses.

  • WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj: Build for 32-bit.
  • WebCore.vcxproj/WebCore.submit.sln: Build QTMovieWin for 32-bit.
11:42 AM Changeset in webkit [162630] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[MSE][Mac] Adopt new AVStreamDataParser delegate API
https://bugs.webkit.org/show_bug.cgi?id=127498

Reviewed by Eric Carlson.

Adopt a new delegate API which passes in whether or not the new AVAsset
is discontinuous, implying the AVAsset is entirely new rather than
just updated with new information.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:withDiscontinuity:]):

11:31 AM Changeset in webkit [162629] by timothy_horton@apple.com
  • 18 edits in trunk

PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
https://bugs.webkit.org/show_bug.cgi?id=127415
<rdar://problem/12482452>

Reviewed by Sam Weinig.

Allow use of PDFPlugin even if an external plugin is installed but blocked.
If an external plugin is installed and not blocked, we will continue to use that.

Inject a context menu item into the PDFPlugin context menu that allows the client
to unblock the plugin and reload the page (via the same mechanism that the
unavailable plugin button uses).

  • UIProcess/API/C/WKPageLoaderClient.h:
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPageLoaderClient):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::pluginLoadPolicy):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Add a new PluginLoadPolicy callback for the V4 client with
yet another string out-argument, to allow clients to customize the string
that will appear in the PDFPlugin context menu when it is used in place
of a blocked plugin.

  • WebProcess/Plugins/PDF/PDFPlugin.h:

Add setUsedInPlaceOfBlockedPlugin(), which determines whether or not
we should include an item in the PDFPlugin context menu that acts identically
to the unavailable plugin button, allowing the client to potentially unblock
the plugin.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFPluginContextMenuTarget initWithPDFPlugin:WebKit::]):
(-[WKPDFPluginContextMenuTarget useBlockedPlugin:]):
Added WKPDFPluginContextMenuTarget, which is the Objective-C object that the
aforementioned context menu item targets.

(WebKit::PDFPlugin::PDFPlugin):
By default, we won't show the extra context menu item.

(WebKit::PDFPlugin::handleContextMenuEvent):
If we were used in place of a blocked plugin, inject our additional context
menu item into the menu. If we were handed a custom string via setUsedInPlaceOfBlockedPlugin,
use that. Otherwise, use the generic string from WebCore's localized strings.

(WebKit::PDFPlugin::openWithPlugin):
Pretend that the user clicked the unavailable plugin button when they click
the injected context menu item.

(WebKit::PDFPlugin::setUsedInPlaceOfBlockedPlugin):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
If we end up with a blocked plugin, but could have used PDFPlugin to display
the content, do so instead of showing the unavailable plugin indicator.

Pass PDFPlugin the custom context menu item title acquired from the client.

(WebKit::WebPage::canPluginHandleResponse):

  • English.lproj/Localizable.strings:
  • WebCore.exp.in:
  • platform/LocalizedStrings.cpp:

(WebCore::useBlockedPlugInContextMenuTitle):

  • platform/LocalizedStrings.h:

Add a localizable string for the generic case, where the client
didn't provide a more specific string for the context menu item.

Adopt the new page loader client plugin load callback.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::pluginLoadPolicy):

  • WebKitTestRunner/TestController.h:
11:20 AM Changeset in webkit [162628] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Remove failure/timeout expectations for the following passed tests:

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-01-23

  • platform/gtk/TestExpectations:

http/tests/navigation/redirect-to-random-url-versus-memory-cache.html

  • platform/gtk-wk2/TestExpectations:

http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html
accessibility/multiselect-list-reports-active-option.html

11:12 AM Changeset in webkit [162627] by mhahnenberg@apple.com
  • 1154 edits
    198 adds in branches/jsCStack

Merge branch up to ToT r160556.

.:

  • .gitignore:
  • Source/autotools/SetupAutomake.m4:
  • Source/autotools/SetupCompilerFlags.m4:
  • Source/autotools/SetupLibtool.m4:
  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/WebKitHelpers.cmake:

Source/JavaScriptCore:

  • API/JSBasePrivate.h:
  • API/JSContext.h:
  • API/JSContext.mm:

(-[JSContext init]):
(-[JSContext initWithVirtualMachine:]):
(-[JSContext initWithGlobalContextRef:]):

  • API/JSContextRef.h:
  • API/JSContextRefPrivate.h:
  • API/JSManagedValue.h:
  • API/JSManagedValue.mm:

(-[JSManagedValue init]):
(-[JSManagedValue initWithValue:]):

  • API/JSObjectRef.h:
  • API/JSStringRefCF.h:
  • API/JSValue.h:
  • API/JSValueRef.h:
  • API/JSVirtualMachine.h:
  • API/JSVirtualMachine.mm:

(-[JSVirtualMachine init]):
(-[JSVirtualMachine initWithContextGroupRef:]):

  • API/tests/testapi.c:

(globalContextNameTest):
(main):

(Deprecated::ScriptCallArgumentHandler::appendArgument):
(Deprecated::ScriptFunctionCall::ScriptFunctionCall):
(Deprecated::ScriptFunctionCall::call):

  • bindings/ScriptFunctionCall.h: Added.
  • bindings/ScriptObject.cpp: Added.

(Deprecated::ScriptObject::ScriptObject):

  • bindings/ScriptObject.h: Added.

(Deprecated::ScriptObject::ScriptObject):
(Deprecated::ScriptObject::jsObject):
(Deprecated::ScriptObject::scriptState):

  • bindings/ScriptValue.cpp: Added.

(Deprecated::ScriptValue::~ScriptValue):
(Deprecated::ScriptValue::getString):
(Deprecated::ScriptValue::toString):
(Deprecated::ScriptValue::isEqual):
(Deprecated::ScriptValue::isNull):
(Deprecated::ScriptValue::isUndefined):
(Deprecated::ScriptValue::isObject):
(Deprecated::ScriptValue::isFunction):
(Deprecated::jsToInspectorValue):
(Deprecated::ScriptValue::toInspectorValue):

  • bindings/ScriptValue.h: Added.
  • bytecode/CodeBlockHash.cpp:

(JSC::CodeBlockHash::CodeBlockHash):
(JSC::CodeBlockHash::dump):

  • bytecode/Opcode.cpp:

(JSC::OpcodeStats::~OpcodeStats):

  • dfg/DFGCSEPhase.cpp:
  • docs/make-bytecode-docs.pl:
  • ftl/FTLAbstractHeap.h:
  • heap/Heap.cpp:

(JSC::Heap::collect):

  • heap/Heap.h:
  • heap/MarkedSpace.h:
  • heap/RecursiveAllocationScope.h: Added.

(JSC::RecursiveAllocationScope::RecursiveAllocationScope):
(JSC::RecursiveAllocationScope::~RecursiveAllocationScope):

  • inspector/InspectorAgentBase.h: Added.

(Inspector::InspectorAgentBase::~InspectorAgentBase):
(Inspector::InspectorAgentBase::discardAgent):
(Inspector::InspectorAgentBase::InspectorAgentBase):

  • inspector/InspectorAgentRegistry.cpp: Added.

(Inspector::InspectorAgentRegistry::append):
(Inspector::InspectorAgentRegistry::didCreateFrontendAndBackend):
(Inspector::InspectorAgentRegistry::willDestroyFrontendAndBackend):
(Inspector::InspectorAgentRegistry::discardAgents):

  • inspector/InspectorAgentRegistry.h: Added.
  • inspector/InspectorBackendDispatcher.cpp: Added.

(Inspector::InspectorBackendDispatcher::CallbackBase::CallbackBase):
(Inspector::InspectorBackendDispatcher::CallbackBase::isActive):
(Inspector::InspectorBackendDispatcher::CallbackBase::sendFailure):
(Inspector::InspectorBackendDispatcher::CallbackBase::sendIfActive):
(Inspector::InspectorBackendDispatcher::create):
(Inspector::InspectorBackendDispatcher::registerDispatcherForDomain):
(Inspector::InspectorBackendDispatcher::dispatch):
(Inspector::InspectorBackendDispatcher::sendResponse):
(Inspector::InspectorBackendDispatcher::reportProtocolError):
(Inspector::getPropertyValue):
(Inspector::AsMethodBridges::asInt):
(Inspector::AsMethodBridges::asDouble):
(Inspector::AsMethodBridges::asString):
(Inspector::AsMethodBridges::asBoolean):
(Inspector::AsMethodBridges::asObject):
(Inspector::AsMethodBridges::asArray):
(Inspector::InspectorBackendDispatcher::getInt):
(Inspector::InspectorBackendDispatcher::getDouble):
(Inspector::InspectorBackendDispatcher::getString):
(Inspector::InspectorBackendDispatcher::getBoolean):
(Inspector::InspectorBackendDispatcher::getObject):
(Inspector::InspectorBackendDispatcher::getArray):

  • inspector/InspectorBackendDispatcher.h: Added.

(Inspector::InspectorSupplementalBackendDispatcher::InspectorSupplementalBackendDispatcher):
(Inspector::InspectorSupplementalBackendDispatcher::~InspectorSupplementalBackendDispatcher):

  • inspector/InspectorTypeBuilder.h: Added.

(Inspector::TypeBuilder::OptOutput::OptOutput):
(Inspector::TypeBuilder::OptOutput::operator=):
(Inspector::TypeBuilder::OptOutput::isAssigned):
(Inspector::TypeBuilder::OptOutput::getValue):
(Inspector::TypeBuilder::ExactlyInt::ExactlyInt):
(Inspector::TypeBuilder::ExactlyInt::operator int):
(Inspector::TypeBuilder::ExactlyInt::cast_to_int):
(Inspector::TypeBuilder::int):
(Inspector::TypeBuilder::RuntimeCastHelper::assertType):
(Inspector::TypeBuilder::RuntimeCastHelper::assertAny):
(Inspector::TypeBuilder::RuntimeCastHelper::assertInt):
(Inspector::TypeBuilder::Array::Array):
(Inspector::TypeBuilder::Array::openAccessors):
(Inspector::TypeBuilder::Array::addItem):
(Inspector::TypeBuilder::Array::create):
(Inspector::TypeBuilder::Array::runtimeCast):
(Inspector::TypeBuilder::Array::assertCorrectValue):
(Inspector::TypeBuilder::StructItemTraits::pushRefPtr):
(Inspector::TypeBuilder::StructItemTraits::assertCorrectValue):

  • inspector/InspectorValues.cpp: Added.

(Inspector::InspectorValue::asBoolean):
(Inspector::InspectorValue::asNumber):
(Inspector::InspectorValue::asString):
(Inspector::InspectorValue::asValue):
(Inspector::InspectorValue::asObject):
(Inspector::InspectorValue::asArray):
(Inspector::InspectorValue::parseJSON):
(Inspector::InspectorValue::toJSONString):
(Inspector::InspectorValue::writeJSON):
(Inspector::InspectorBasicValue::asBoolean):
(Inspector::InspectorBasicValue::asNumber):
(Inspector::InspectorBasicValue::writeJSON):
(Inspector::InspectorString::asString):
(Inspector::InspectorString::writeJSON):
(Inspector::InspectorObjectBase::~InspectorObjectBase):
(Inspector::InspectorObjectBase::asObject):
(Inspector::InspectorObjectBase::openAccessors):
(Inspector::InspectorObjectBase::getBoolean):
(Inspector::InspectorObjectBase::getString):
(Inspector::InspectorObjectBase::getObject):
(Inspector::InspectorObjectBase::getArray):
(Inspector::InspectorObjectBase::get):
(Inspector::InspectorObjectBase::remove):
(Inspector::InspectorObjectBase::writeJSON):
(Inspector::InspectorObjectBase::InspectorObjectBase):
(Inspector::InspectorArrayBase::~InspectorArrayBase):
(Inspector::InspectorArrayBase::asArray):
(Inspector::InspectorArrayBase::writeJSON):
(Inspector::InspectorArrayBase::InspectorArrayBase):
(Inspector::InspectorArrayBase::get):
(Inspector::InspectorObject::create):
(Inspector::InspectorArray::create):
(Inspector::InspectorValue::null):
(Inspector::InspectorString::create):
(Inspector::InspectorBasicValue::create):

  • inspector/InspectorValues.h: Added.

(Inspector::InspectorObjectBase::find):
(Inspector::InspectorObjectBase::setBoolean):
(Inspector::InspectorObjectBase::setNumber):
(Inspector::InspectorObjectBase::setString):
(Inspector::InspectorObjectBase::setValue):
(Inspector::InspectorObjectBase::setObject):
(Inspector::InspectorObjectBase::setArray):
(Inspector::InspectorArrayBase::pushBoolean):
(Inspector::InspectorArrayBase::pushInt):
(Inspector::InspectorArrayBase::pushNumber):
(Inspector::InspectorArrayBase::pushString):
(Inspector::InspectorArrayBase::pushValue):
(Inspector::InspectorArrayBase::pushObject):
(Inspector::InspectorArrayBase::pushArray):

  • inspector/scripts: Added.
  • jit/JITOperations.cpp:
  • jsc.cpp:
  • make-generated-sources.sh:
  • offlineasm/mips.rb:
  • offlineasm/sh4.rb:
  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createProperty):

  • parser/Parser.cpp:

(JSC::::parseInner):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclarationList):
(JSC::::createBindingPattern):
(JSC::::tryParseDeconstructionPatternExpression):
(JSC::::parseDeconstructionPattern):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseBlockStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseMemberExpression):

  • parser/Parser.h:
  • parser/ParserArena.h:
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createGetterOrSetterProperty):

  • runtime/CodeCache.h:
  • runtime/DateInstanceCache.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObject.h:
  • runtime/JSString.h:
  • runtime/LiteralParser.h:
  • runtime/NumericStrings.h:
  • runtime/RegExpCache.h:
  • runtime/SmallStrings.h:
  • runtime/VM.h:
  • testRegExp.cpp:

Source/Platform:

  • GNUmakefile.am:

Source/ThirdParty:

  • gtest/msvc/gtest-md.vcxproj:

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj/project.pbxproj:
  • src/compiler/glslang_tab.cpp:

(yysyntax_error):
(glslang_parse):

  • src/compiler/glslang_tab.h:
  • src/compiler/preprocessor/ExpressionParser.cpp:

(yy_symbol_print):
(yy_stack_print):
(yy_reduce_print):
(yystrlen):
(yystpcpy):
(yytnamerr):
(yysyntax_error):
(yydestruct):
(yyparse):

Source/WebCore:

Tests: accessibility/alt-tag-on-image-with-nonimage-role.html

accessibility/children-changed-sends-notification.html
crypto/subtle/aes-postMessage.html
crypto/subtle/hmac-postMessage.html
crypto/subtle/postMessage-worker.html
crypto/subtle/rsa-oaep-generate-non-extractable-key.html
crypto/subtle/rsa-postMessage.html
crypto/subtle/rsaes-pkcs1-v1_5-decrypt.html
crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html
crypto/subtle/unwrapKey-check-usage.html
crypto/subtle/wrapKey-check-usage.html
fast/css/nth-last-child-recalc.html
fast/css/pending-image-crash.xhtml
fast/css/style-sharing-grand-parent-invalidate.html
fast/dom/Document/clone-node.html
fast/dom/HTMLDocument/clone-node-quirks-mode.html
fast/dom/HTMLTableElement/empy-table-cell-with-background-color.html
fast/dom/Window/postMessage-clone-port-error.html
inspector-protocol/model/highlight-shape-outside-margin.html
inspector-protocol/page/deny-X-FrameOption.html
media/media-source/media-source-end-of-stream.html
media/media-source/media-source-video-playback-quality.html
platform/gtk/accessibility/text-at-offset-embedded-objects.html
platform/gtk/accessibility/text-at-offset-newlines.html
platform/gtk/accessibility/text-at-offset-preformatted.html
platform/gtk/accessibility/text-at-offset-simple.html
platform/gtk/accessibility/text-at-offset-special-chars.html
platform/gtk/accessibility/text-at-offset-textarea.html
platform/gtk/accessibility/text-at-offset-textinput.html
platform/gtk/accessibility/text-at-offset-wrapped-lines.html
platform/gtk/accessibility/text-for-range-combo-box.html
platform/gtk/accessibility/text-for-range-embedded-objects.html
platform/gtk/accessibility/text-for-range-entry-and-password.html
platform/gtk/accessibility/text-for-range-extraneous-whitespace.html
platform/gtk/accessibility/text-for-range-formatted.html
platform/gtk/accessibility/text-for-range-heading.html
platform/gtk/accessibility/text-for-range-list-items.html
platform/gtk/accessibility/text-for-range-simple.html
platform/gtk/accessibility/text-for-range-table-cells.html
platform/gtk/accessibility/text-for-range-with-link.html
platform/gtk/accessibility/text-for-table.html
svg/custom/clone-node.html
svg/dom/SVGScriptElement/script-type-attribute.svg

  • CMakeLists.txt:
  • Configurations/Version.xcconfig:
  • DerivedSources.make:
  • ForwardingHeaders/bindings: Added.
  • ForwardingHeaders/bindings/ScriptFunctionCall.h: Added.
  • ForwardingHeaders/bindings/ScriptObject.h: Added.
  • ForwardingHeaders/bindings/ScriptValue.h: Added.
  • ForwardingHeaders/inspector/InspectorAgentBase.h: Added.
  • ForwardingHeaders/inspector/InspectorAgentRegistry.h: Added.
  • ForwardingHeaders/inspector/InspectorBackendDispatcher.h: Added.
  • ForwardingHeaders/inspector/InspectorTypeBuilder.h: Added.
  • ForwardingHeaders/inspector/InspectorValues.h: Added.
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/battery/BatteryManager.idl:
  • Modules/battery/NavigatorBattery.idl:
  • Modules/indexeddb/IDBAny.cpp:

(WebCore::IDBAny::scriptValue):
(WebCore::IDBAny::IDBAny):

  • Modules/indexeddb/IDBAny.h:
  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::key):
(WebCore::IDBCursor::primaryKey):
(WebCore::IDBCursor::value):
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::setValueReady):

  • Modules/indexeddb/IDBCursor.h:
  • Modules/indexeddb/IDBDatabaseMetadata.cpp: Added.

(WebCore::IDBDatabaseMetadata::isolatedCopy):
(WebCore::IDBObjectStoreMetadata::isolatedCopy):
(WebCore::IDBIndexMetadata::isolatedCopy):

  • Modules/indexeddb/IDBDatabaseMetadata.h:
  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::cmp):

  • Modules/indexeddb/IDBFactory.h:
  • Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • Modules/indexeddb/IDBIndex.h:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):

  • Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::IDBKeyPath::isolatedCopy):

  • Modules/indexeddb/IDBKeyPath.h:
  • Modules/indexeddb/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::lowerValue):
(WebCore::IDBKeyRange::upperValue):
(WebCore::IDBKeyRange::only):
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):

  • Modules/indexeddb/IDBKeyRange.h:

(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::get):
(WebCore::generateIndexKeysForValue):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):

  • Modules/indexeddb/IDBObjectStore.h:
  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::setResultCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessInternal):

  • Modules/indexeddb/IDBRequest.h:
  • Modules/mediasource/DOMURLMediaSource.cpp:

(WebCore::DOMURLMediaSource::createObjectURL):

  • Modules/mediasource/DOMURLMediaSource.h:
  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::openKeyword):
(WebCore::MediaSource::closedKeyword):
(WebCore::MediaSource::endedKeyword):
(WebCore::MediaSource::setPrivateAndOpen):
(WebCore::MediaSource::addedToRegistry):
(WebCore::MediaSource::removedFromRegistry):
(WebCore::MediaSource::duration):
(WebCore::MediaSource::buffered):
(WebCore::SourceBufferBufferedDoesNotContainTime::SourceBufferBufferedDoesNotContainTime):
(WebCore::SourceBufferBufferedDoesNotContainTime::operator()):
(WebCore::SourceBufferBufferedHasEnough::SourceBufferBufferedHasEnough):
(WebCore::SourceBufferBufferedHasEnough::operator()):
(WebCore::SourceBufferBufferedHasFuture::SourceBufferBufferedHasFuture):
(WebCore::SourceBufferBufferedHasFuture::operator()):
(WebCore::MediaSource::monitorSourceBuffers):
(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::setReadyState):
(WebCore::SourceBufferIsUpdating):
(WebCore::MediaSource::endOfStream):
(WebCore::MediaSource::streamEndedWithError):
(WebCore::MediaSource::removeSourceBuffer):
(WebCore::MediaSource::isOpen):
(WebCore::MediaSource::isClosed):
(WebCore::MediaSource::close):
(WebCore::MediaSource::attachToElement):
(WebCore::MediaSource::openIfInEndedState):
(WebCore::MediaSource::hasPendingActivity):
(WebCore::MediaSource::stop):
(WebCore::MediaSource::onReadyStateChange):
(WebCore::MediaSource::activeRanges):
(WebCore::MediaSource::createSourceBufferPrivate):
(WebCore::MediaSource::scheduleEvent):
(WebCore::MediaSource::scriptExecutionContext):
(WebCore::MediaSource::eventTargetInterface):
(WebCore::MediaSource::registry):

  • Modules/mediasource/MediaSource.h:

(WebCore::MediaSource::readyState):
(WebCore::MediaSource::mediaElement):
(WebCore::MediaSource::asyncEventQueue):

  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/MediaSourceBase.cpp:
  • Modules/mediasource/MediaSourceBase.h:
  • Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::registerURL):
(WebCore::MediaSourceRegistry::unregisterURL):

  • Modules/mediasource/MediaSourceRegistry.h:
  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::TrackBuffer::TrackBuffer):
(WebCore::SourceBuffer::appendBufferTimerFired):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::sourceBufferPrivateHasAudio):
(WebCore::SourceBuffer::sourceBufferPrivateHasVideo):
(WebCore::SourceBuffer::didDropSample):

  • Modules/mediasource/SourceBuffer.h:
  • Modules/mediasource/VideoPlaybackQuality.cpp: Added.

(WebCore::VideoPlaybackQuality::create):
(WebCore::VideoPlaybackQuality::VideoPlaybackQuality):

  • Modules/mediasource/VideoPlaybackQuality.h: Added.

(WebCore::VideoPlaybackQuality::creationTime):
(WebCore::VideoPlaybackQuality::totalVideoFrames):
(WebCore::VideoPlaybackQuality::droppedVideoFrames):
(WebCore::VideoPlaybackQuality::corruptedVideoFrames):
(WebCore::VideoPlaybackQuality::totalFrameDelay):

  • Modules/mediasource/VideoPlaybackQuality.idl: Added.
  • Modules/mediastream/CapabilityRange.cpp:

(WebCore::scriptValue):
(WebCore::CapabilityRange::min):
(WebCore::CapabilityRange::max):

  • Modules/mediastream/CapabilityRange.h:
  • Modules/mediastream/HTMLMediaElementMediaStream.idl:
  • Modules/mediastream/MediaTrackConstraint.h:
  • Modules/mediastream/RTCErrorCallback.h:
  • Modules/mediastream/RTCErrorCallback.idl:
  • Modules/mediastream/RTCIceCandidate.cpp:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::addIceCandidate):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCPeerConnectionErrorCallback.h: Added.

(WebCore::RTCPeerConnectionErrorCallback::~RTCPeerConnectionErrorCallback):

  • Modules/mediastream/RTCPeerConnectionErrorCallback.idl: Added.
  • Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:

(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):

  • Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
  • Modules/mediastream/RTCVoidRequestImpl.cpp:

(WebCore::RTCVoidRequestImpl::create):
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::requestFailed):

  • Modules/mediastream/RTCVoidRequestImpl.h:
  • Modules/networkinfo/NavigatorNetworkInfoConnection.idl:
  • Modules/networkinfo/NetworkInfoConnection.idl:
  • Modules/plugins/QuickTimePluginReplacement.cpp:
  • Modules/plugins/QuickTimePluginReplacement.h:
  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::getExpectedWebSocketAccept):

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformNix.cmake:
  • UseJSC.cmake:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.vcxproj/WebCoreCommon.props:
  • WebCore.vcxproj/WebCoreTestSupport.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::usesAltTagForTextComputation):
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::accessibilityDescription):
(WebCore::AccessibilityNodeObject::text):

  • accessibility/AccessibilityNodeObject.h:
  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):
(atkRole):

  • bindings/gobject/GNUmakefile.am:
  • bindings/gobject/WebKitDOMCustom.cpp:
  • bindings/gobject/WebKitDOMCustom.h:
  • bindings/gobject/WebKitDOMCustom.symbols:
  • bindings/gobject/WebKitDOMDeprecated.cpp:
  • bindings/gobject/WebKitDOMDeprecated.h:
  • bindings/gobject/WebKitDOMDeprecated.symbols:
  • bindings/gobject/webkitdom.symbols:
  • bindings/js/Dictionary.h:

(WebCore::Dictionary::getEventListener):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):
(WebCore::deserializeIDBValue):
(WebCore::deserializeIDBValueBuffer):
(WebCore::idbKeyToScriptValue):
(WebCore::scriptValueToIDBKey):

  • bindings/js/IDBBindingUtilities.h:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey):

  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid):
(WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON):

  • bindings/js/JSDOMBinding.h:

(WebCore::toJS):
(WebCore::toRefPtrNativeArray):
(WebCore::toNativeArray):
(WebCore::toNativeArguments):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h:
  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::scriptValueAsNode):
(WebCore::InjectedScriptHost::nodeAsScriptValue):
(WebCore::JSInjectedScriptHost::inspectedObject):
(WebCore::JSInjectedScriptHost::inspect):

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

  • bindings/js/JSMainThreadExecState.cpp:

(WebCore::functionCallHandlerFromAnyThread):

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::currentState):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):
(WebCore::handleInitMessageEvent):

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::wrapKey):

  • bindings/js/ScheduledAction.cpp:
  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptArguments):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::evaluate):
(WebCore::ScriptController::executeScriptInWorld):
(WebCore::ScriptController::executeScript):
(WebCore::ScriptController::executeIfJavaScriptURL):

  • bindings/js/ScriptController.h:
  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::updateCallStack):
(WebCore::ScriptDebugServer::dispatchDidPause):
(WebCore::ScriptDebugServer::runScript):

  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptFunctionCall.cpp:
  • bindings/js/ScriptFunctionCall.h:
  • bindings/js/ScriptGlobalObject.cpp: Added.

(WebCore::handleException):
(WebCore::ScriptGlobalObject::set):
(WebCore::ScriptGlobalObject::get):
(WebCore::ScriptGlobalObject::remove):

  • bindings/js/ScriptGlobalObject.h: Added.

(WebCore::ScriptGlobalObject::ScriptGlobalObject):

  • bindings/js/ScriptObject.cpp:
  • bindings/js/ScriptObject.h:
  • bindings/js/ScriptProfile.cpp:

(WebCore::buildInspectorObjectFor):
(WebCore::ScriptProfile::buildInspectorObjectForHead):
(WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead):

  • bindings/js/ScriptProfile.h:
  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):
(WebCore::ScriptProfiler::getHeapObjectId):

  • bindings/js/ScriptProfiler.h:
  • bindings/js/ScriptState.h:
  • bindings/js/ScriptValue.cpp:
  • bindings/js/ScriptValue.h:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::ENUM_CLASS):
(WebCore::countUsages):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::read):
(WebCore::CloneDeserializer::readHMACKey):
(WebCore::CloneDeserializer::readAESKey):
(WebCore::CloneDeserializer::readRSAKey):
(WebCore::CloneDeserializer::readCryptoKey):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::SerializedScriptValue::deserializeForInspector):
(WebCore::SerializedScriptValue::serialize):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/js/SerializedScriptValue.h:
  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setException):

  • bindings/js/WorkerScriptController.h:
  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute):
(SkipFunction):
(GetWriteableProperties):
(GenerateProperty):
(GenerateFunction):
(GenerateFunctions):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjAnyAttribute):

  • crypto/CommonCryptoUtilities.h:
  • crypto/CryptoAlgorithmIdentifier.h:

(WebCore::ENUM_CLASS):

  • crypto/CryptoAlgorithmRegistry.cpp:

(WebCore::CryptoAlgorithmRegistry::shared):
(WebCore::registryMutex):
(WebCore::CryptoAlgorithmRegistry::getIdentifierForName):
(WebCore::CryptoAlgorithmRegistry::nameForIdentifier):
(WebCore::CryptoAlgorithmRegistry::create):
(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):

  • crypto/CryptoAlgorithmRegistry.h:
  • crypto/CryptoKey.cpp:

(WebCore::CryptoKey::usages):

  • crypto/CryptoKey.idl:
  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
  • crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmAES_KW::encryptForWrapKey):
(WebCore::CryptoAlgorithmAES_KW::decryptForUnwrapKey):

  • crypto/algorithms/CryptoAlgorithmAES_KW.h:
  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp: Added.

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::CryptoAlgorithmRSAES_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::~CryptoAlgorithmRSAES_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::create):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::identifier):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::keyAlgorithmMatches):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::generateKey):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey):

  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h: Added.
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA1.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA224.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA256.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA384.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA512.cpp:
  • crypto/keys/CryptoKeyAES.cpp:

(WebCore::CryptoKeyAES::CryptoKeyAES):
(WebCore::CryptoKeyAES::isValidAESAlgorithm):

  • crypto/keys/CryptoKeyAES.h:
  • crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp: Added.

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::generatePair):

  • crypto/parameters/CryptoAlgorithmAesCbcParams.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusShorthandValue):
(WebCore::ComputedStyleExtractor::valueForFilter):

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSCrossfadeValue.cpp:

(WebCore::subimageKnownToBeOpaque):
(WebCore::CSSCrossfadeValue::knownToBeOpaque):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::detachPendingImage):
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::clearCachedImage):

  • css/CSSCursorImageValue.h:
  • css/CSSFilterImageValue.h:

(WebCore::CSSFilterImageValue::create):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::saveCachedImageForSize):
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):

  • css/CSSImageGeneratorValue.h:
  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::detachPendingImage):
(WebCore::CSSImageSetValue::~CSSImageSetValue):
(WebCore::CSSImageSetValue::cachedImageSet):

  • css/CSSImageSetValue.h:
  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::detachPendingImage):
(WebCore::CSSImageValue::~CSSImageValue):
(WebCore::CSSImageValue::cachedImage):

  • css/CSSImageValue.h:
  • css/CSSParser.cpp:

(WebCore::filterProperties):
(WebCore::CSSParser::createStyleProperties):
(WebCore::CSSParser::parseFilterImage):
(WebCore::CSSParser::parseFilter):

  • css/CSSValue.cpp:
  • css/StyleProperties.cpp:

(WebCore::StyleProperties::asText):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::addIntrinsicMargins):
(WebCore::doesNotInheritTextDecoration):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustGridItemPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):

  • css/StyleResolver.h:
  • dom/CustomEvent.cpp:

(WebCore::CustomEvent::initCustomEvent):

  • dom/CustomEvent.h:

(WebCore::CustomEvent::detail):

  • dom/Document.cpp:

(WebCore::Document::cloneNode):
(WebCore::Document::cloneDocumentWithoutChildren):
(WebCore::Document::cloneDataFromDocument):

  • dom/Document.h:
  • dom/Document.idl:
  • dom/Element.cpp:

(WebCore::Element::computedStyle):

  • dom/Element.h:
  • dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::InlineStyleSheetOwner):

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):

  • dom/MessageEvent.h:

(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataAsScriptValue):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage):

  • dom/Node.cpp:

(WebCore::Node::computedStyle):

  • dom/Node.h:

(WebCore::Node::nonRendererStyle):

  • dom/PopStateEvent.h:

(WebCore::PopStateEvent::state):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::ScriptElement):

  • dom/ScriptableDocumentParser.h:
  • dom/StyledElement.cpp:

(WebCore::StyledElement::styleAttributeChanged):

  • editing/VisibleUnits.cpp:

(WebCore::endWordBoundary):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::cloneDocumentWithoutChildren):

  • html/HTMLDocument.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(HTMLMediaElement::mediaLoadingFailedFatally):
(HTMLMediaElement::mediaLoadingFailed):
(HTMLMediaElement::mediaPlayerEngineUpdated):
(HTMLMediaElement::getVideoPlaybackQuality):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::incrementDroppedFrameCount):

  • html/HTMLMediaElement.idl:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):

  • html/HTMLTextAreaElement.cpp:
  • html/ImageInputType.cpp:

(WebCore::ImageInputType::handleDOMActivateEvent):

  • html/TextFieldInputType.cpp:
  • html/TextInputType.cpp:
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/XSSAuditor.cpp:
  • html/parser/XSSAuditorDelegate.cpp:
  • inspector/CodeGeneratorInspector.py:

(RawTypes.BaseType.get_raw_validator_call_text):
(RawTypes.Object.get_array_item_raw_c_type_text):
(RawTypes.Any.get_array_item_raw_c_type_text):
(RawTypes.Array.get_array_item_raw_c_type_text):
(CommandReturnPassModel.OptOutput.get_return_var_type):
(CommandReturnPassModel.OptOutput.get_output_parameter_type):
(TypeModel.ExactlyInt.get_input_param_type_text):
(TypeModel.ExactlyInt.get_opt_output_type_):
(TypeModel.init_class):
(TypeBindings.create_named_type_declaration.Helper):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator.CodeGenerator.generate_type_builder):
(Inspector):
(ArrayBinding.get_array_item_c_type_text):
(Generator.go):
(Generator.EventMethodStructTemplate.append_epilog):
(Generator.process_command):

  • inspector/CodeGeneratorInspectorStrings.py:

(void):
(InspectorFrontend_h):
(InspectorBackendDispatchers_h):

  • inspector/ConsoleMessage.cpp:

(WebCore::messageSourceValue):
(WebCore::messageTypeValue):
(WebCore::messageLevelValue):
(WebCore::ConsoleMessage::addToFrontend):

  • inspector/ConsoleMessage.h:
  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:
  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::createDigest):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::getInternalProperties):
(WebCore::InjectedScript::nodeForObjectId):
(WebCore::InjectedScript::releaseObject):
(WebCore::InjectedScript::wrapCallFrames):
(WebCore::InjectedScript::wrapObject):
(WebCore::InjectedScript::wrapTable):
(WebCore::InjectedScript::wrapNode):
(WebCore::InjectedScript::findObjectById):
(WebCore::InjectedScript::inspectNode):
(WebCore::InjectedScript::releaseObjectGroup):
(WebCore::InjectedScript::nodeAsScriptValue):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptBase.cpp:

(WebCore::InjectedScriptBase::InjectedScriptBase):
(WebCore::InjectedScriptBase::initialize):
(WebCore::InjectedScriptBase::injectedScriptObject):
(WebCore::InjectedScriptBase::callFunctionWithEvalEnabled):
(WebCore::InjectedScriptBase::makeCall):
(WebCore::InjectedScriptBase::makeEvalCall):

  • inspector/InjectedScriptBase.h:
  • inspector/InjectedScriptCanvasModule.cpp:

(WebCore::InjectedScriptCanvasModule::wrapCanvas2DContext):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::callWrapContextFunction):
(WebCore::InjectedScriptCanvasModule::markFrameEnd):
(WebCore::InjectedScriptCanvasModule::callStartCapturingFunction):
(WebCore::InjectedScriptCanvasModule::callVoidFunctionWithTraceLogIdArgument):
(WebCore::InjectedScriptCanvasModule::traceLog):
(WebCore::InjectedScriptCanvasModule::replayTraceLog):
(WebCore::InjectedScriptCanvasModule::resourceInfo):
(WebCore::InjectedScriptCanvasModule::resourceState):

  • inspector/InjectedScriptCanvasModule.h:
  • inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::inspectImpl):
(WebCore::InjectedScriptHost::InspectableObject::get):

  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::injectedScriptFor):

  • inspector/InjectedScriptManager.h:
  • inspector/InjectedScriptModule.cpp:

(WebCore::InjectedScriptModule::ensureInjected):

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::didCreateFrontendAndBackend):
(WebCore::InspectorAgent::inspect):

  • inspector/InspectorAgent.h:
  • inspector/InspectorAgentRegistry.cpp:
  • inspector/InspectorAgentRegistry.h:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::didCreateFrontendAndBackend):
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):
(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBackendDispatcher.cpp:
  • inspector/InspectorBackendDispatcher.h:
  • inspector/InspectorBaseAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::toInspectorObject):
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setStyleText):
(WebCore::InspectorCSSAgent::setPropertyText):
(WebCore::InspectorCSSAgent::toggleProperty):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::stopSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):
(WebCore::InspectorCSSAgent::buildObjectForRule):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
(WebCore::InspectorCSSAgent::buildArrayForRegions):
(WebCore::InspectorCSSAgent::buildObjectForNamedFlow):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
(WebCore::InspectorCanvasAgent::injectedScriptCanvasModule):

  • inspector/InspectorCanvasAgent.h:
  • inspector/InspectorCanvasInstrumentation.h:

(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):

  • inspector/InspectorClient.cpp:
  • inspector/InspectorClient.h:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::didCreateFrontendAndBackend):
(WebCore::InspectableHeapObject::get):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
(WebCore::InspectorDOMAgent::didCommitLoad):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::styleAttributeInvalidated):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):

  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):

  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDatabaseResource.cpp:

(WebCore::InspectorDatabaseResource::bind):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::breakpointActionTypeForString):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::scriptToInspectorObject):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::compileScript):
(WebCore::InspectorDebuggerAgent::runScript):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::didContinue):
(WebCore::InspectorDebuggerAgent::clear):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorForwarding.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::evaluateAsBoolean):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::FrontendMenuProvider::create):
(WebCore::FrontendMenuProvider::disconnect):
(WebCore::FrontendMenuProvider::FrontendMenuProvider):
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
(WebCore::FrontendMenuProvider::contextMenuCleared):
(WebCore::InspectorFrontendHost::showContextMenu):
(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):

  • inspector/InspectorHeapProfilerAgent.cpp:

(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorHeapProfilerAgent::createSnapshotHeader):
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
(WebCore::InspectorHeapProfilerAgent::getObjectByHeapObjectId):
(WebCore::InspectorHeapProfilerAgent::getHeapObjectId):

  • inspector/InspectorHeapProfilerAgent.h:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::didCreateFrontendAndBackend):

  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorInputAgent.cpp:

(WebCore::InspectorInputAgent::InspectorInputAgent):
(WebCore::InspectorInputAgent::didCreateFrontendAndBackend):

  • inspector/InspectorInputAgent.h:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::didCreateFrontendAndBackend):
(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderObjectHierarchy):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderLayerHierarchy):
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
(WebCore::InspectorLayerTreeAgent::buildObjectForIntRect):
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):

  • inspector/InspectorLayerTreeAgent.h:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::didCreateFrontendAndBackend):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForShapeOutside):

  • inspector/InspectorOverlay.h:
  • inspector/InspectorOverlayPage.js:

(_drawShapeHighlight):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::resourceTypeJson):
(WebCore::InspectorPageAgent::cachedResourceTypeJson):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::didCreateFrontendAndBackend):
(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::buildObjectForSearchResult):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::createProfileHeader):
(WebCore::InspectorProfilerAgent::createSnapshotHeader):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::getCPUProfile):
(WebCore::InspectorProfilerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
(WebCore::InspectorProfilerAgent::getHeapObjectId):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didCreateFrontendAndBackend):
(WebCore::buildObjectForTiming):
(WebCore::buildObjectForResourceRequest):
(WebCore::buildObjectForResourceResponse):
(WebCore::buildObjectForCachedResource):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::buildInitiatorObject):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrame):
(WebCore::InspectorResourceAgent::didSendWebSocketFrame):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):

  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::buildErrorRangeObject):
(WebCore::InspectorRuntimeAgent::parse):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::buildSourceRangeObject):
(WebCore::buildMediaObject):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::buildObjectForStyle):
(WebCore::InspectorStyle::buildArrayForComputedStyle):
(WebCore::InspectorStyle::styleWithProperties):
(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
(WebCore::selectorsFromSource):
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::buildObjectForStyle):
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

  • inspector/InspectorStyleSheet.h:

(WebCore::InspectorCSSId::InspectorCSSId):
(WebCore::InspectorStyleSheet::canBind):

  • inspector/InspectorStyleTextEditor.cpp:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
(WebCore::toProtocol):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setDOMCounters):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::sendEvent):

  • inspector/InspectorTimelineAgent.h:

(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):

  • inspector/InspectorValues.cpp:
  • inspector/InspectorValues.h:
  • inspector/InspectorWebAgentBase.h: Added.

(WebCore::InspectorAgentBase::InspectorAgentBase):

  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::didCreateFrontendAndBackend):

  • inspector/InspectorWorkerAgent.h:
  • inspector/InstrumentingAgents.cpp:
  • inspector/NetworkResourcesData.cpp:
  • inspector/PageConsoleAgent.cpp:

(WebCore::InspectableNode::get):

  • inspector/PageDebuggerAgent.cpp:
  • inspector/PageDebuggerAgent.h:
  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::didCreateFrontendAndBackend):

  • inspector/PageRuntimeAgent.h:
  • inspector/ScriptArguments.cpp:

(WebCore::ScriptArguments::create):
(WebCore::ScriptArguments::ScriptArguments):
(WebCore::ScriptArguments::argumentAt):
(WebCore::ScriptArguments::getFirstArgumentAsString):

  • inspector/ScriptArguments.h:
  • inspector/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::buildInspectorObject):

  • inspector/ScriptCallFrame.h:
  • inspector/ScriptCallStack.cpp:

(WebCore::ScriptCallStack::buildInspectorArray):

  • inspector/ScriptCallStack.h:
  • inspector/ScriptDebugListener.h:
  • inspector/TimelineRecordFactory.cpp:
  • inspector/TimelineRecordFactory.h:

(WebCore::TimelineRecordFactory::createWebSocketCreateData):
(WebCore::TimelineRecordFactory::createGenericWebSocketData):

  • inspector/WorkerConsoleAgent.cpp:
  • inspector/WorkerDebuggerAgent.cpp:
  • inspector/WorkerInspectorController.cpp:
  • inspector/WorkerInspectorController.h:
  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::didCreateFrontendAndBackend):

  • inspector/WorkerRuntimeAgent.h:
  • inspector/protocol/Runtime.json:
  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.h:

(WebCore::CachedResource::decodedDataIsPurgeable):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::pruneLiveResourcesToSize):

  • page/Console.cpp:

(WebCore::internalAddMessage):

  • page/ContentSecurityPolicy.cpp:
  • page/Frame.cpp:
  • page/FrameView.cpp:

(WebCore::paginationModeForRenderStyle):
(WebCore::FrameView::FrameView):
(WebCore::FrameView::applyPaginationToViewport):

  • page/FrameView.h:
  • page/Page.cpp:

(WebCore::Page::jettisonStyleResolversInAllDocuments):

  • page/Page.h:
  • page/PageConsole.cpp:

(WebCore::PageConsole::printSourceURLAndPosition):
(WebCore::PageConsole::addMessage):

  • page/PageConsole.h:
  • page/Settings.in:
  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFilter):
(WebCore::crossfadeBlend):
(WebCore::blendFunc):

  • platform/CrossThreadCopier.cpp:

(WebCore::::copy):

  • platform/CrossThreadCopier.h:
  • platform/MediaSample.h:

(WebCore::MediaSample::isSync):
(WebCore::MediaSample::isNonDisplaying):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::createPurgeableBuffer):

  • platform/SharedBuffer.h:
  • platform/glib: Added.
  • platform/glib/BatteryProviderUPower.cpp: Added.

(powerDeviceAlterationCallback):
(BatteryProviderUPower::BatteryProviderUPower):
(BatteryProviderUPower::startUpdating):
(BatteryProviderUPower::stopUpdating):
(BatteryProviderUPower::updateBatteryStatus):

  • platform/glib/BatteryProviderUPower.h: Added.
  • platform/glib/BatteryProviderUPowerClient.h: Added.
  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedDataIfNecessary):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/Font.cpp:

(WebCore::clearWidthCaches):

  • platform/graphics/Font.h:
  • platform/graphics/GlyphMetricsMap.h:
  • platform/graphics/Image.h:

(WebCore::Image::decodedDataIsPurgeable):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines):
(WebCore::MediaPlayer::totalVideoFrames):
(WebCore::MediaPlayer::droppedVideoFrames):
(WebCore::MediaPlayer::corruptedVideoFrames):
(WebCore::MediaPlayer::totalFrameDelay):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::seekWithTolerance):
(WebCore::MediaPlayerPrivateInterface::totalVideoFrames):
(WebCore::MediaPlayerPrivateInterface::droppedVideoFrames):
(WebCore::MediaPlayerPrivateInterface::corruptedVideoFrames):
(WebCore::MediaPlayerPrivateInterface::totalFrameDelay):

  • platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.cpp: Added.

(WebCore::AudioTrackPrivateMediaSourceAVFObjC::AudioTrackPrivateMediaSourceAVFObjC):
(WebCore::AudioTrackPrivateMediaSourceAVFObjC::resetPropertiesFromTrack):
(WebCore::AudioTrackPrivateMediaSourceAVFObjC::setAssetTrack):
(WebCore::AudioTrackPrivateMediaSourceAVFObjC::assetTrack):
(WebCore::AudioTrackPrivateMediaSourceAVFObjC::enabled):
(WebCore::AudioTrackPrivateMediaSourceAVFObjC::setEnabled):

  • platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h: Added.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: Added.

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setLoadingProgresssed):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setHasAvailableVideoFrame):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: Added.

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::~MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::registerMediaEngine):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::create):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isAvailable):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::getSupportedTypes):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::load):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cancelLoad):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::prepareToPlay):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::platformMedia):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::platformLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::play):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pause):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pauseInternal):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paused):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsScanning):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::naturalSize):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasVideo):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasAudio):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVisible):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentTimeDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::startTimeDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::initialTime):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seeking):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setRateDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::networkState):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::readyState):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekable):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::maxTimeSeekableDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::minTimeSeekable):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::buffered):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::didLoadingProgress):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setSize):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paint):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsAcceleratedRendering):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::acceleratedRenderingStateChanged):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::movieLoadType):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::prepareForRendering):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::engineDescription):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::languageOfPrimaryAudioTrack):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::extraMemoryCost):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::totalVideoFrames):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::droppedVideoFrames):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::corruptedVideoFrames):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::totalFrameDelay):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::destroyLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setReadyState):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setNetworkState):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeDisplayLayer):

  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h: Added.
  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm: Added.

(WebCore::MediaSourcePrivateAVFObjC::create):
(WebCore::MediaSourcePrivateAVFObjC::MediaSourcePrivateAVFObjC):
(WebCore::MediaSourcePrivateAVFObjC::~MediaSourcePrivateAVFObjC):
(WebCore::MediaSourcePrivateAVFObjC::addSourceBuffer):
(WebCore::MediaSourcePrivateAVFObjC::removeSourceBuffer):
(WebCore::MediaSourcePrivateAVFObjC::duration):
(WebCore::MediaSourcePrivateAVFObjC::setDuration):
(WebCore::MediaSourcePrivateAVFObjC::markEndOfStream):
(WebCore::MediaSourcePrivateAVFObjC::unmarkEndOfStream):
(WebCore::MediaSourcePrivateAVFObjC::readyState):
(WebCore::MediaSourcePrivateAVFObjC::setReadyState):
(WebCore::MediaSourcePrivateAVFObjC::sourceBufferPrivateDidChangeActiveState):
(WebCore::MediaSourcePrivateAVFObjCHasAudio):
(WebCore::MediaSourcePrivateAVFObjC::hasAudio):
(WebCore::MediaSourcePrivateAVFObjCHasVideo):
(WebCore::MediaSourcePrivateAVFObjC::hasVideo):
(WebCore::MediaSourcePrivateAVFObjC::seekToTime):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h: Added.
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: Added.

(-[WebAVStreamDataParserListener initWithParser:parent:WebCore::]):
(-[WebAVStreamDataParserListener dealloc]):
(-[WebAVStreamDataParserListener streamDataParser:didParseStreamDataAsAsset:]):
(-[WebAVStreamDataParserListener streamDataParser:didFailToParseStreamDataWithError:]):
(-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]):
(-[WebAVStreamDataParserListener streamDataParser:didReachEndOfTrackWithTrackID:mediaType:]):
(WebCore::MediaSampleAVFObjC::platformSample):
(WebCore::CMSampleBufferIsRandomAccess):
(WebCore::MediaSampleAVFObjC::flags):
(WebCore::SourceBufferPrivateAVFObjC::create):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset):
(WebCore::SourceBufferPrivateAVFObjC::didFailToParseStreamDataWithError):
(WebCore::callProcessCodedFrameForEachSample):
(WebCore::SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackID):
(WebCore::SourceBufferPrivateAVFObjC::processCodedFrame):
(WebCore::SourceBufferPrivateAVFObjC::didReachEndOfTrackWithTrackID):
(WebCore::SourceBufferPrivateAVFObjC::setClient):
(WebCore::SourceBufferPrivateAVFObjC::append):
(WebCore::SourceBufferPrivateAVFObjC::abort):
(WebCore::SourceBufferPrivateAVFObjC::removedFromMediaSource):
(WebCore::SourceBufferPrivateAVFObjC::readyState):
(WebCore::SourceBufferPrivateAVFObjC::setReadyState):
(WebCore::SourceBufferPrivateAVFObjC::evictCodedFrames):
(WebCore::SourceBufferPrivateAVFObjC::isFull):
(WebCore::SourceBufferPrivateAVFObjC::hasVideo):
(WebCore::SourceBufferPrivateAVFObjC::hasAudio):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::createNonDisplayingCopy):
(WebCore::SourceBufferPrivateAVFObjC::flushAndEnqueueNonDisplayingSamples):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):
(WebCore::SourceBufferPrivateAVFObjC::isReadyForMoreSamples):
(WebCore::SourceBufferPrivateAVFObjC::setActive):
(WebCore::SourceBufferPrivateAVFObjC::fastSeekTimeForMediaTime):
(WebCore::SourceBufferPrivateAVFObjC::seekToTime):

  • platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h: Added.
  • platform/graphics/gstreamer/TextCombinerGStreamer.cpp:

(webkitTextCombinerPadGetProperty):
(webkitTextCombinerPadEvent):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::TrackPrivateBaseGStreamer):
(WebCore::TrackPrivateBaseGStreamer::disconnect):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(ResourceHandleStreamingClient::didReceiveData):
(ResourceHandleStreamingClient::didReceiveBuffer):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::texSubImage2D):

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::cpuDescriptionForUAString):
(WebCore::platformVersionForUAString):
(WebCore::standardUserAgent):

  • platform/gtk/WidgetBackingStoreGtkX11.cpp:

(WebCore::WidgetBackingStoreGtkX11::~WidgetBackingStoreGtkX11):

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::releaseMemory):

  • platform/mac/PlatformClockCM.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::ScrollbarThemeMac::setPaintCharacteristicsForScrollbar):
(WebCore::scrollbarPainterPaint):

  • platform/mac/SoftLinking.h:
  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(WebCore::RTCPeerConnectionHandler::incompatibleConstraintsErrorName):
(WebCore::RTCPeerConnectionHandler::invalidSessionDescriptionErrorName):
(WebCore::RTCPeerConnectionHandler::incompatibleSessionDescriptionErrorName):
(WebCore::RTCPeerConnectionHandler::internalErrorName):

  • platform/mediastream/RTCPeerConnectionHandler.h:
  • platform/mock/RTCNotifiersMock.cpp:

(WebCore::SessionRequestNotifier::SessionRequestNotifier):
(WebCore::SessionRequestNotifier::fire):
(WebCore::VoidRequestNotifier::VoidRequestNotifier):
(WebCore::VoidRequestNotifier::fire):

  • platform/mock/RTCNotifiersMock.h:
  • platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::createOffer):
(WebCore::RTCPeerConnectionHandlerMock::createAnswer):

  • platform/mock/mediasource/MockBox.h:
  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::setNetworkState):
(WebCore::MockMediaPlayerMediaSource::totalVideoFrames):
(WebCore::MockMediaPlayerMediaSource::droppedVideoFrames):
(WebCore::MockMediaPlayerMediaSource::corruptedVideoFrames):
(WebCore::MockMediaPlayerMediaSource::totalFrameDelay):

  • platform/mock/mediasource/MockMediaPlayerMediaSource.h:
  • platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate):
(WebCore::MockMediaSourcePrivate::~MockMediaSourcePrivate):
(WebCore::MockMediaSourcePrivate::markEndOfStream):

  • platform/mock/mediasource/MockMediaSourcePrivate.h:
  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::MockSourceBufferPrivate):
(WebCore::MockSourceBufferPrivate::removedFromMediaSource):
(WebCore::MockSourceBufferPrivate::readyState):
(WebCore::MockSourceBufferPrivate::setReadyState):
(WebCore::MockSourceBufferPrivate::setActive):
(WebCore::MockSourceBufferPrivate::enqueueSample):

  • platform/mock/mediasource/MockSourceBufferPrivate.h:

(WebCore::MockSourceBufferPrivate::clearMediaSource):

  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.cpp:

(WebCore::ResourceHandleClient::willCacheResponseAsync):

  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::shouldUseCredentialStorage):
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::continueWillSendRequest):
(WebCore::ResourceHandle::continueDidReceiveResponse):
(WebCore::ResourceHandle::continueShouldUseCredentialStorage):
(WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::continueWillCacheResponse):

  • platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp: Added.

(WebCore::ResourceHandleCFURLConnectionDelegate::ResourceHandleCFURLConnectionDelegate):
(WebCore::ResourceHandleCFURLConnectionDelegate::~ResourceHandleCFURLConnectionDelegate):
(WebCore::ResourceHandleCFURLConnectionDelegate::releaseHandle):
(WebCore::ResourceHandleCFURLConnectionDelegate::willSendRequestCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveResponseCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveDataCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didFinishLoadingCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didFailCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::willCacheResponseCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveChallengeCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didSendBodyDataCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::shouldUseCredentialStorageCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::canRespondToProtectionSpaceCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveDataArrayCallback):
(WebCore::ResourceHandleCFURLConnectionDelegate::synthesizeRedirectResponseIfNecessary):
(WebCore::ResourceHandleCFURLConnectionDelegate::createResourceRequest):
(WebCore::ResourceHandleCFURLConnectionDelegate::makeConnectionClient):

  • platform/network/cf/ResourceHandleCFURLConnectionDelegate.h: Added.
  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp: Added.

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::ResourceHandleCFURLConnectionDelegateWithOperationQueue):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::~ResourceHandleCFURLConnectionDelegateWithOperationQueue):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::hasHandle):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupConnectionScheduling):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveChallenge):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::shouldUseCredentialStorage):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueWillSendRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueDidReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueShouldUseCredentialStorage):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueWillCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueCanAuthenticateAgainstProtectionSpace):

  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h: Added.
  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp: Added.

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::SynchronousResourceHandleCFURLConnectionDelegate):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::setupRequest):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::setupConnectionScheduling):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::willSendRequest):
(WebCore::setDefaultMIMEType):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveData):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didFinishLoading):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didFail):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::willCacheResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveChallenge):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didSendBodyData):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::shouldUseCredentialStorage):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::canRespondToProtectionSpace):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveDataArray):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::continueWillSendRequest):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::continueDidReceiveResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::continueShouldUseCredentialStorage):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::continueWillCacheResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::continueCanAuthenticateAgainstProtectionSpace):

  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h: Added.
  • platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::generateBaseFilename):

  • platform/network/mac/CertificateInfo.h: Added.

(WebCore::CertificateInfo::setCertificateChain):
(WebCore::CertificateInfo::certificateChain):

  • platform/network/mac/CertificateInfoMac.mm: Added.

(WebCore::CertificateInfo::CertificateInfo):
(WebCore::CertificateInfo::dump):

  • platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):

  • platform/network/soup/CertificateInfo.cpp: Added.

(WebCore::CertificateInfo::CertificateInfo):
(WebCore::CertificateInfo::~CertificateInfo):

  • platform/network/soup/CertificateInfo.h: Added.

(WebCore::CertificateInfo::certificate):
(WebCore::CertificateInfo::setCertificate):
(WebCore::CertificateInfo::tlsErrors):
(WebCore::CertificateInfo::setTLSErrors):

  • platform/network/soup/GOwnPtrSoup.cpp:

(WTF::SoupBuffer):

  • platform/network/soup/GOwnPtrSoup.h:
  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didReceiveBuffer):
(WebCore::HostTLSCertificateSet::computeCertificateHash):
(WebCore::ResourceHandle::ensureReadBuffer):
(WebCore::redirectSkipCallback):
(WebCore::cleanupSoupRequestOperation):
(WebCore::ResourceHandle::currentStreamPosition):
(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):
(WebCore::readCallback):

  • platform/soup: Added.
  • platform/soup/SharedBufferSoup.cpp: Added.

(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::wrapSoupBuffer):
(WebCore::SharedBuffer::clearPlatformData):
(WebCore::SharedBuffer::tryReplaceContentsWithPlatformBuffer):
(WebCore::SharedBuffer::maybeTransferPlatformData):
(WebCore::SharedBuffer::hasPlatformData):
(WebCore::SharedBuffer::platformData):
(WebCore::SharedBuffer::platformDataSize):

  • platform/text/TextBoundaries.cpp:

(WebCore::findEndWordBoundary):

  • platform/text/TextBoundaries.h:
  • platform/text/mac/TextBoundaries.mm:

(WebCore::findEndWordBoundary):

  • plugins/PluginView.cpp:

(WebCore::PluginView::performRequest):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::previousOnLineExists):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):

  • rendering/InlineElementBox.cpp:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::~InlineFlowBox):
(WebCore::InlineFlowBox::checkConsistency):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::setHasBadChildList):

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::nextBreakablePosition):
(WebCore::InlineIterator::setNextBreakablePosition):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::lineStyleForMarkerType):
(WebCore::InlineTextBox::paintDocumentMarkers):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint):
(WebCore::positionForPointRespectingEditingBoundaries):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRunsForSegment):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::borderRadii):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::customContainingBlockWidth):
(WebCore::customContainingBlockHeight):
(WebCore::customContainingBlockLogicalWidth):
(WebCore::customContainingBlockLogicalHeight):
(WebCore::customContainingBlockAvailableLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::stickyPositionOffset):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::layout):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::styleWillChange):
(WebCore::RenderElement::styleDidChange):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing):
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
(WebCore::RenderEmbeddedObject::setPluginUnavailabilityReasonWithDescription):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::nodeHeight):
(WebCore::RenderFileUploadControl::maxFilenameWidth):
(WebCore::RenderFileUploadControl::paintObject):
(WebCore::RenderFileUploadControl::fileTextValue):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::positionFrames):

  • rendering/RenderIFrame.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::collectSelectionRects):
(WebCore::RenderImage::paintAreaElementFocusRing):

  • rendering/RenderImage.h:
  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::image):

  • rendering/RenderImageResource.h:
  • rendering/RenderImageResourceStyleImage.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::absoluteQuadsForSelection):

  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::willBeDestroyed):
(WebCore::RenderLayer::hasAcceleratedTouchScrolling):
(WebCore::RenderLayer::handleTouchEvent):
(WebCore::RenderLayer::registerAsTouchEventListenerForScrolling):
(WebCore::RenderLayer::unregisterAsTouchEventListenerForScrolling):
(WebCore::RenderLayer::updateNeedsCompositedScrolling):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::visibleContentRect):
(WebCore::RenderLayer::didStartScroll):
(WebCore::RenderLayer::didEndScroll):
(WebCore::RenderLayer::didUpdateScroll):
(WebCore::RenderLayer::invalidateScrollbarRect):
(WebCore::RenderLayer::invalidateScrollCornerRect):
(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::layerWillBeDestroyed):
(WebCore::layerOrAncestorIsTransformedOrScrolling):
(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling):
(WebCore::RenderLayerBacking::shouldClipCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::registerScrollingLayers):
(WebCore::RenderLayerBacking::updateScrollingLayers):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::parentForSublayers):
(WebCore::RenderLayerBacking::paintsIntoWindow):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::paintIntoLayer):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::scheduleLayerFlush):
(WebCore::RenderLayerCompositor::chromeClient):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::scrollbarHasDisplayNone):
(WebCore::updateScrollingLayerWithClient):
(WebCore::RenderLayerCompositor::updateCustomLayersAfterFlush):
(WebCore::RenderLayerCompositor::didFlushChangesForLayer):
(WebCore::RenderLayerCompositor::didChangeVisibleRect):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::setIsInWindow):
(WebCore::RenderLayerCompositor::allowsIndependentlyCompositedFrames):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
(WebCore::RenderLayerCompositor::requiresCompositingForScrolling):
(WebCore::isStickyInAcceleratedScrollingLayerOrViewport):
(WebCore::isViewportConstrainedFixedOrStickyLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::contentsScaleMultiplierForNewTiles):
(WebCore::RenderLayerCompositor::ensureRootLayer):
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints):
(WebCore::RenderLayerCompositor::registerOrUpdateViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::unregisterViewportConstrainedLayer):
(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
(WebCore::RenderLayerCompositor::unregisterAllViewportConstrainedLayers):
(WebCore::RenderLayerCompositor::registerAllScrollingLayers):
(WebCore::RenderLayerCompositor::unregisterAllScrollingLayers):
(WebCore::RenderLayerCompositor::scrollingLayerAddedOrUpdated):
(WebCore::RenderLayerCompositor::scrollingLayerRemoved):
(WebCore::RenderLayerCompositor::startInitialLayerFlushTimerIfNeeded):

  • rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::layerForContentShadow):

  • rendering/RenderLayerFilterInfo.h:
  • rendering/RenderMenuList.cpp:

(WebCore::selectedOptionCount):
(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::~RenderMenuList):
(WebCore::RenderMenuList::adjustInnerStyle):
(RenderMenuList::updateFromElement):
(RenderMenuList::setTextFromOption):
(RenderMenuList::showPopup):
(RenderMenuList::hidePopup):
(RenderMenuList::popupDidHide):

  • rendering/RenderMenuList.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::columnNumberForOffset):
(WebCore::RenderObject::collectSelectionRects):
(WebCore::RenderObject::destroy):
(WebCore::RenderObject::innerLineHeight):
(WebCore::RenderObject::willRenderImage):

  • rendering/RenderObject.h:

(WebCore::RenderObject::absoluteQuadsForSelection):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::updateDepth):

  • rendering/RenderScrollbar.h:
  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::itemText):

  • rendering/RenderText.cpp:

(WebCore::originalTextMap):
(WebCore::RenderText::RenderText):
(WebCore::RenderText::~RenderText):
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::originalText):
(WebCore::RenderText::collectSelectionRects):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::setText):

  • rendering/RenderText.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::adjustInnerTextStyle):
(WebCore::RenderTextControl::canScroll):
(WebCore::RenderTextControl::innerLineHeight):

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::getAvgCharWidth):
(WebCore::RenderTextControlMultiLine::createInnerTextStyle):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::getAvgCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentLogicalWidth):

  • rendering/RenderTextFragment.cpp:
  • rendering/RenderTextFragment.h:
  • rendering/RenderTextLineBoxes.cpp:

(WebCore::lineDirectionPointFitsInBox):
(WebCore::RenderTextLineBoxes::positionForPoint):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::paintCheckboxDecorations):
(WebCore::RenderTheme::paintRadioDecorations):
(WebCore::RenderTheme::paintButtonDecorations):
(WebCore::RenderTheme::paintTextFieldDecorations):
(WebCore::RenderTheme::paintTextAreaDecorations):
(WebCore::RenderTheme::paintMenuListDecorations):
(WebCore::RenderTheme::paintPushButtonDecorations):
(WebCore::RenderTheme::paintSquareButtonDecorations):
(WebCore::RenderTheme::paintFileUploadIconDecorations):
(WebCore::RenderTheme::paintSliderThumbDecorations):
(WebCore::RenderTheme::paintSearchFieldDecorations):

  • rendering/RenderThemeIOS.h: Added.

(WebCore::RenderThemeIOS::~RenderThemeIOS):

  • rendering/RenderThemeIOS.mm: Added.

(WebCore::IOSGradient::IOSGradient):
(WebCore::interpolateLinearGradient):
(WebCore::interpolateExponentialGradient):
(WebCore::getSharedFunctionRef):
(WebCore::drawAxialGradient):
(WebCore::drawRadialGradient):
(WebCore::getInsetGradient):
(WebCore::getShineGradient):
(WebCore::getShadeGradient):
(WebCore::getConvexGradient):
(WebCore::getConcaveGradient):
(WebCore::getSliderTrackGradient):
(WebCore::getReadonlySliderTrackGradient):
(WebCore::getSliderThumbOpaquePressedGradient):
(WebCore::gradientWithName):
(WebCore::contentSizeCategoryDidChange):
(WebCore::RenderThemeIOS::RenderThemeIOS):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeIOS::create):
(WebCore::RenderThemeIOS::contentSizeCategory):
(WebCore::RenderThemeIOS::shadowColor):
(WebCore::RenderThemeIOS::addRoundedBorderClip):
(WebCore::RenderThemeIOS::adjustCheckboxStyle):
(WebCore::shortened):
(WebCore::RenderThemeIOS::paintCheckboxDecorations):
(WebCore::RenderThemeIOS::baselinePosition):
(WebCore::RenderThemeIOS::isControlStyled):
(WebCore::RenderThemeIOS::adjustRadioStyle):
(WebCore::RenderThemeIOS::paintRadioDecorations):
(WebCore::RenderThemeIOS::paintTextFieldDecorations):
(WebCore::RenderThemeIOS::paintTextAreaDecorations):
(WebCore::RenderThemeIOS::popupInternalPaddingRight):
(WebCore::RenderThemeIOS::adjustRoundBorderRadius):
(WebCore::applyCommonButtonPaddingToStyle):
(WebCore::adjustSelectListButtonStyle):
(WebCore::adjustInputElementButtonStyle):
(WebCore::RenderThemeIOS::adjustMenuListButtonStyle):
(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):
(WebCore::RenderThemeIOS::adjustSliderTrackStyle):
(WebCore::RenderThemeIOS::paintSliderTrack):
(WebCore::RenderThemeIOS::adjustSliderThumbSize):
(WebCore::RenderThemeIOS::paintSliderThumbDecorations):
(WebCore::RenderThemeIOS::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeIOS::animationDurationForProgressBar):
(WebCore::RenderThemeIOS::paintProgressBar):
(WebCore::RenderThemeIOS::sliderTickSize):
(WebCore::RenderThemeIOS::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeIOS::adjustSearchFieldStyle):
(WebCore::RenderThemeIOS::paintSearchFieldDecorations):
(WebCore::RenderThemeIOS::adjustButtonStyle):
(WebCore::RenderThemeIOS::paintButtonDecorations):
(WebCore::RenderThemeIOS::paintPushButtonDecorations):
(WebCore::RenderThemeIOS::setButtonSize):
(WebCore::RenderThemeIOS::paintFileUploadIconDecorations):
(WebCore::RenderThemeIOS::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeIOS::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeIOS::shouldShowPlaceholderWhenFocused):
(WebCore::RenderThemeIOS::shouldHaveSpinButton):
(WebCore::fromCTFontWeight):
(WebCore::RenderThemeIOS::systemFont):
(WebCore::RenderThemeIOS::mediaControlsStyleSheet):
(WebCore::RenderThemeIOS::mediaControlsScript):

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:
  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::calculateIntrinsicSize):

  • rendering/RenderView.cpp:

(WebCore::RenderView::availableLogicalHeight):
(WebCore::fixedPositionOffset):
(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::pushMappingToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):
(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::computeRectForRepaint):
(WebCore::isFixedPositionInViewport):
(WebCore::RenderView::hasCustomFixedPosition):

  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::willBeDestroyed):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/break_lines.cpp:
  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::handleText):

  • rendering/line/LineBreaker.h:
  • rendering/line/LineWidth.cpp:
  • rendering/shapes/BoxShape.cpp:

(WebCore::addRoundedRect):
(WebCore::BoxShape::buildDisplayPaths):

  • rendering/shapes/BoxShape.h:
  • rendering/shapes/PolygonShape.cpp:

(WebCore::addPolygon):
(WebCore::PolygonShape::buildDisplayPaths):

  • rendering/shapes/PolygonShape.h:
  • rendering/shapes/RasterShape.h:
  • rendering/shapes/RectangleShape.cpp:

(WebCore::RectangleShape::buildDisplayPaths):

  • rendering/shapes/RectangleShape.h:
  • rendering/shapes/Shape.h:
  • rendering/shapes/ShapeInfo.cpp:

(WebCore::::computedShape):

  • rendering/shapes/ShapeInfo.h:

(WebCore::ShapeInfo::writingMode):

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::writingMode):

  • rendering/shapes/ShapeOutsideInfo.h:
  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShape::canBlend):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::StyleGeneratedImage):
(WebCore::StyleGeneratedImage::cssValue):
(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::image):

  • rendering/style/StyleGeneratedImage.h:
  • rendering/style/StyleGridItemData.cpp:

(WebCore::StyleGridItemData::StyleGridItemData):

  • rendering/style/StyleImage.h:
  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::cssCursorImageValue):
(WebCore::StylePendingImage::cssImageSetValue):
(WebCore::StylePendingImage::detachFromCSSValue):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::originalText):

  • rendering/svg/RenderSVGInlineText.h:
  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::cloneDocumentWithoutChildren):

  • svg/SVGDocument.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::computedStyle):

  • svg/SVGElement.h:
  • svg/SVGScriptElement.cpp:

(WebCore::SVGScriptElement::parseAttribute):
(WebCore::SVGScriptElement::typeAttributeValue):
(WebCore::SVGScriptElement::isAnimatableAttribute):

  • svg/SVGScriptElement.h:
  • svg/SVGScriptElement.idl:
  • svg/graphics/SVGImage.h:
  • testing/Internals.cpp:

(WebCore::Internals::parserMetaData):
(WebCore::Internals::initializeMockMediaSource):

  • testing/Internals.h:
  • workers/SharedWorkerGlobalScope.cpp:

(WebCore::createConnectEvent):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::importScripts):

  • workers/WorkerThread.cpp:
  • xml/XMLTreeViewer.cpp:
  • xml/parser/XMLDocumentParser.cpp:
  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::error):

Source/WebInspectorUI:

  • Configurations/Version.xcconfig:
  • Tools/PrettyPrinting/codemirror.css:

(.cm-s-default .cm-meta):
(.cm-s-default .cm-error):

  • Tools/PrettyPrinting/codemirror.js:

(window.CodeMirror):
(window.CodeMirror.):

  • Tools/PrettyPrinting/css.js:

(.):

  • Tools/PrettyPrinting/javascript.js:

(.):
(maybeoperatorNoComma):
(quasi):
(continueQuasi):
(arrowBody):
(arrowBodyNoComma):
(objprop):
(getterSetter):
(afterprop):
(maybetype):
(typedef):
(vardef):
(pattern):
(proppattern):
(maybeAssign):
(vardefCont):
(forspec):
(forspec1):
(formaybeinof):
(forspec2):
(functiondef):
(funarg):
(className):
(classNameAfter):
(objlit):
(afterModule):
(afterExport):
(afterImport):
(importSpec):
(maybeFrom):
(maybeArrayComprehension):
(comprehension):
(return.startState):
(return.token):
(return.indent):

  • UserInterface/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype.):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):

  • UserInterface/CodeMirrorAdditions.js:
  • UserInterface/CodeMirrorColorEditingController.js: Added.

(WebInspector.CodeMirrorColorEditingController):
(WebInspector.CodeMirrorColorEditingController.prototype.get marker):
(WebInspector.CodeMirrorColorEditingController.prototype.get range):
(WebInspector.CodeMirrorColorEditingController.prototype.get color):
(WebInspector.CodeMirrorColorEditingController.prototype.set color):
(WebInspector.CodeMirrorColorEditingController.prototype.get delegate):
(WebInspector.CodeMirrorColorEditingController.prototype.set delegate):
(WebInspector.CodeMirrorColorEditingController.prototype.get text):
(WebInspector.CodeMirrorColorEditingController.prototype.set text):
(WebInspector.CodeMirrorColorEditingController.prototype.presentHoverMenu):
(WebInspector.CodeMirrorColorEditingController.prototype.dismissHoverMenu):
(WebInspector.CodeMirrorColorEditingController.prototype.handleEvent):
(WebInspector.CodeMirrorColorEditingController.prototype.hoverMenuButtonWasPressed):
(WebInspector.CodeMirrorColorEditingController.prototype.didDismissPopover):
(WebInspector.CodeMirrorColorEditingController.prototype._colorPickerColorChanged):

  • UserInterface/CodeMirrorTokenTrackingController.js:

(WebInspector.CodeMirrorTokenTrackingController):
(WebInspector.CodeMirrorTokenTrackingController.prototype.set mode):
(WebInspector.CodeMirrorTokenTrackingController.prototype.get hoveredMarker):
(WebInspector.CodeMirrorTokenTrackingController.prototype.set hoveredMarker):
(WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
(WebInspector.CodeMirrorTokenTrackingController.prototype._processNewHoveredToken):
(WebInspector.CodeMirrorTokenTrackingController.prototype._processMarkedToken):

  • UserInterface/Color.js:

(WebInspector.Color):

  • UserInterface/External/CodeMirror/codemirror.css:

(.cm-s-default .cm-meta):
(.cm-s-default .cm-error):

  • UserInterface/External/CodeMirror/codemirror.js:

(window.CodeMirror):
(window.CodeMirror.):

  • UserInterface/External/CodeMirror/coffeescript.js:
  • UserInterface/External/CodeMirror/css.js:

(.):

  • UserInterface/External/CodeMirror/htmlmixed.js:
  • UserInterface/External/CodeMirror/javascript.js:

(.):
(maybeoperatorNoComma):
(quasi):
(continueQuasi):
(arrowBody):
(arrowBodyNoComma):
(objprop):
(getterSetter):
(afterprop):
(maybetype):
(typedef):
(vardef):
(pattern):
(proppattern):
(maybeAssign):
(vardefCont):
(forspec):
(forspec1):
(formaybeinof):
(forspec2):
(functiondef):
(funarg):
(className):
(classNameAfter):
(objlit):
(afterModule):
(afterExport):
(afterImport):
(importSpec):
(maybeFrom):
(maybeArrayComprehension):
(comprehension):
(return.startState):
(return.token):
(return.indent):

  • UserInterface/External/CodeMirror/less.js:

(.else.):

  • UserInterface/External/CodeMirror/matchbrackets.js:
  • UserInterface/External/CodeMirror/placeholder.js:
  • UserInterface/External/CodeMirror/runmode.js:

(CodeMirror.runMode):

  • UserInterface/External/CodeMirror/searchcursor.js:

(.):

  • UserInterface/External/CodeMirror/sql.js:
  • UserInterface/External/CodeMirror/xml.js:
  • UserInterface/HoverMenu.js:

(WebInspector.HoverMenu.prototype._handleClickEvent):

  • UserInterface/Main.html:
  • UserInterface/SourceCodeTextEditor.css:

(.hover-menu.color):
(.hover-menu.color > img):

  • UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.close):
(WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
(WebInspector.SourceCodeTextEditor.prototype._contentDidPopulate):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
(WebInspector.SourceCodeTextEditor.prototype._sourceCodeSourceMapAdded):
(WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
(WebInspector.SourceCodeTextEditor.prototype._hasColorMarkers):
(WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):
(WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerNewHighlightCandidate):
(WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerMouseOutOfHoveredMarker):
(WebInspector.SourceCodeTextEditor.prototype._showPopover):
(WebInspector.SourceCodeTextEditor.prototype._popoverMouseout):
(WebInspector.SourceCodeTextEditor.prototype._updateColorMarkers):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedMarkedExpression):
(WebInspector.SourceCodeTextEditor.prototype._dismissCodeMirrorColorEditingController):
(WebInspector.SourceCodeTextEditor.prototype.colorEditingControllerDidStartEditing):
(WebInspector.SourceCodeTextEditor.prototype.colorEditingControllerDidFinishEditing):

  • UserInterface/TextEditor.js:

(WebInspector.TextEditor.prototype.contentDidChange):
(WebInspector.TextEditor.prototype.boundsForRange):
(WebInspector.TextEditor.prototype.get markers):
(WebInspector.TextEditor.prototype.markersAtPosition):
(WebInspector.TextEditor.prototype.createColorMarkers):
(WebInspector.TextEditor.prototype.colorEditingControllerForMarker):
(WebInspector.TextEditor.prototype._contentChanged):

  • UserInterface/TextMarker.js: Added.

(WebInspector.TextMarker):
(WebInspector.TextMarker.textMarkerForCodeMirrorTextMarker):
(WebInspector.TextMarker.prototype.get codeMirrorTextMarker):
(WebInspector.TextMarker.prototype.get type):
(WebInspector.TextMarker.prototype.get range):
(WebInspector.TextMarker.prototype.get bounds):
(WebInspector.TextMarker.prototype.clear):

  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:

Source/WebKit:

  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
  • WebKit.vcxproj/WebKit.sln:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj:
  • WebKit.vcxproj/WebKit/WebKitVersion.cmd:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • ewk/ewk_frame.cpp:

Source/WebKit/gtk:

  • GNUmakefile.am:
  • WebCoreSupport/BatteryClientGtk.cpp: Added.

(WebKit::BatteryClientGtk::BatteryClientGtk):
(WebKit::BatteryClientGtk::startUpdating):
(WebKit::BatteryClientGtk::stopUpdating):
(WebKit::BatteryClientGtk::batteryControllerDestroyed):

  • WebCoreSupport/BatteryClientGtk.h: Added.
  • tests/testatk.c:

(testWebkitAtkCaretOffsets):
(testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces):
(testWebkitAtkComboBox):
(updateLoadingEventsResult):
(documentLoadingEventCallback):
(testWebkitAtkDocumentLoadingEvents):
(testWebkitAtkEmbeddedObjects):
(testWebkitAtkTextSelections):
(testWebkitAtkListsOfItems):
(main):

  • tests/testatkroles.c:

(finish_loading):
(test_webkit_atk_get_role_document_frame):
(test_webkit_atk_get_role_heading):
(test_webkit_atk_get_role_image):
(test_webkit_atk_get_role_link):
(test_webkit_atk_get_role_list_and_item):
(test_webkit_atk_get_role_paragraph):
(test_webkit_atk_get_role_section):
(test_webkit_atk_get_role_table):
(test_webkit_atk_get_role_separator):
(test_webkit_atk_get_role_combobox):
(test_webkit_atk_get_role_form):
(test_webkit_atk_get_role_check_box):
(test_webkit_atk_get_role_entry):
(test_webkit_atk_get_role_label):
(test_webkit_atk_get_role_listbox):
(test_webkit_atk_get_role_password_text):
(test_webkit_atk_get_role_push_button):
(test_webkit_atk_get_role_radio_button):

  • tests/testwebsettings.c:

(test_webkit_web_settings_copy):

  • webkit/webkitdownload.cpp:

(DownloadClient::didReceiveData):
(DownloadClient::didReceiveBuffer):

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

  • webkit/webkitwebsettingsprivate.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
(webkit_web_view_init):

Source/WebKit/mac:

  • Configurations/Version.xcconfig:
  • DOM/WebDOMOperations.h:
  • History/WebBackForwardList.h:
  • History/WebHistory.h:
  • History/WebHistoryItem.h:
  • History/WebHistoryItem.mm:

(-[WebHistoryItem init]):
(-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:
  • Plugins/WebPlugin.h:
  • Plugins/WebPluginContainer.h:
  • WebCoreSupport/WebInspectorClient.mm:
  • WebView/WebAllowDenyPolicyListener.h:
  • WebView/WebArchive.h:
  • WebView/WebArchive.mm:

(-[WebArchivePrivate init]):
(-[WebArchivePrivate initWithCoreArchive:]):
(-[WebArchive init]):
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive initWithData:]):
(-[WebArchive initWithCoder:]):

  • WebView/WebDataSource.h:
  • WebView/WebDataSource.mm:

(-[WebDataSource initWithRequest:]):

  • WebView/WebEditingDelegate.h:

(NS_ENUM):

  • WebView/WebFrame.h:
  • WebView/WebFrame.mm:

(-[WebFrame init]):
(-[WebFrame initWithName:webFrameView:webView:]):

  • WebView/WebFrameView.h:
  • WebView/WebPolicyDelegate.h:

(NS_ENUM):

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.h:

(NS_ENUM):

  • WebView/WebPreferences.mm:

(-[WebPreferences init]):
(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences initWithCoder:]):
(+[WebPreferences initialize]):
(-[WebPreferences cacheModel]):
(-[WebPreferences mediaSourceEnabled]):
(-[WebPreferences setMediaSourceEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebResource.h:
  • WebView/WebResource.mm:

(-[WebResourcePrivate init]):
(-[WebResourcePrivate initWithCoreResource:]):
(-[WebResource init]):
(-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]):
(-[WebResource initWithCoder:]):

  • WebView/WebUIDelegate.h:

(NS_OPTIONS):

  • WebView/WebView.h:
  • WebView/WebView.mm:

(createUserVisibleWebKitVersionString):
(-[WebView _preferencesChanged:]):
(-[_WebSafeForwarder initWithTarget:defaultTarget:]):
(-[WebView initWithFrame:]):
(-[WebView initWithFrame:frameName:groupName:]):
(-[WebView initWithCoder:]):
(+[WebView _didSetCacheModel]):

Source/WebKit/win:

  • WebFrame.cpp:
  • WebView.cpp:

Source/WebKit2:

  • CMakeLists.txt:
  • Configurations/Version.xcconfig:
  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::removeUniqueIDBDatabase):
(WebKit::DatabaseProcess::initializeDatabaseProcess):
(WebKit::DatabaseProcess::ensureIndexedDatabaseRelativePathExists):
(WebKit::DatabaseProcess::ensurePathExists):
(WebKit::DatabaseProcess::absoluteIndexedDatabasePathFromDatabaseRelativePath):
(WebKit::DatabaseProcess::postDatabaseTask):
(WebKit::DatabaseProcess::performNextDatabaseTask):

  • DatabaseProcess/DatabaseProcess.h:

(WebKit::DatabaseProcess::queue):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::~UniqueIDBDatabase):
(WebKit::UniqueIDBDatabase::filenameForDatabaseName):
(WebKit::UniqueIDBDatabase::databaseFilenameIdentifier):
(WebKit::UniqueIDBDatabase::canShareDatabases):
(WebKit::UniqueIDBDatabase::unregisterConnection):
(WebKit::UniqueIDBDatabase::shutdown):
(WebKit::UniqueIDBDatabase::getOrEstablishIDBDatabaseMetadata):
(WebKit::UniqueIDBDatabase::openBackingStoreAndReadMetadata):
(WebKit::UniqueIDBDatabase::didOpenBackingStoreAndReadMetadata):
(WebKit::UniqueIDBDatabase::absoluteDatabaseDirectory):
(WebKit::UniqueIDBDatabase::postMainThreadTask):
(WebKit::UniqueIDBDatabase::performNextMainThreadTask):
(WebKit::UniqueIDBDatabase::postDatabaseTask):
(WebKit::UniqueIDBDatabase::performNextDatabaseTask):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h: Added.

(WebKit::UniqueIDBDatabaseBackingStore::~UniqueIDBDatabaseBackingStore):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.cpp:

(WebKit::UniqueIDBDatabaseIdentifier::isolatedCopy):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.h:
  • DatabaseProcess/IndexedDB/sqlite: Added.
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp: Added.

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::UniqueIDBDatabaseBackingStoreSQLite):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::extractExistingMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openSQLiteDatabaseAtPath):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getOrEstablishMetadata):

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h: Added.
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkResourceLoader.cpp:
  • NetworkProcess/mac/NetworkProcessMac.mm:
  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::getCacheDiskFreeSize):
(WebKit::getMemorySize):
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::platformSetCacheModel):
(WebKit::NetworkProcess::setIgnoreTLSErrors):
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
(WebKit::NetworkProcess::clearCacheForAllOrigins):

  • NetworkProcess/unix/NetworkProcessMainUnix.cpp:

(WebKit::NetworkProcessMain):

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::decodeValueFromBuffer):
(CoreIPC::ArgumentDecoder::decode):

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::copyValueToBuffer):
(CoreIPC::ArgumentEncoder::encode):

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):

  • Platform/CoreIPC/MessageReceiverMap.cpp:

(CoreIPC::MessageReceiverMap::addMessageReceiver):

  • Platform/CoreIPC/MessageReceiverMap.h:
  • Platform/CoreIPC/MessageSender.cpp:
  • Platform/CoreIPC/MessageSender.h:
  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::createPlatformConnection):

  • Platform/IPC/DataReference.cpp:
  • Platform/IPC/DataReference.h:
  • Platform/IPC/MessageSender.cpp: Added.

(IPC::MessageSender::~MessageSender):
(IPC::MessageSender::sendMessage):

  • Platform/IPC/MessageSender.h: Added.

(IPC::MessageSender::send):
(IPC::MessageSender::sendSync):

  • Platform/IPC/StringReference.cpp:
  • Platform/IPC/StringReference.h:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::createWebProcessConnection):

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectEncoder encodeBool:forKey:]):
(-[WKRemoteObjectEncoder encodeInt64:forKey:]):
(-[WKRemoteObjectEncoder encodeDouble:forKey:]):
(-[WKRemoteObjectDecoder decodeBoolForKey:]):
(-[WKRemoteObjectDecoder decodeInt64ForKey:]):
(-[WKRemoteObjectDecoder decodeDoubleForKey:]):

  • Shared/API/c/WKContextMenuItem.cpp:

(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemCreateAsSubmenu):
(WKContextMenuItemGetTag):
(WKContextMenuItemGetType):
(WKContextMenuItemCopyTitle):
(WKContextMenuItemGetEnabled):
(WKContextMenuItemGetChecked):
(WKContextMenuCopySubmenuItems):
(WKContextMenuItemGetUserData):
(WKContextMenuItemSetUserData):

  • Shared/API/c/WKDictionary.cpp:

(WKDictionaryCreate):

  • Shared/API/c/WKDictionary.h:
  • Shared/API/c/WKGeometry.cpp:

(WKSizeGetTypeID):
(WKPointGetTypeID):
(WKRectGetTypeID):
(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):

  • Shared/API/c/WKNumber.cpp:

(WKBooleanGetTypeID):
(WKBooleanCreate):
(WKDoubleGetTypeID):
(WKDoubleCreate):
(WKUInt64GetTypeID):
(WKUInt64Create):

  • Shared/API/c/WKSharedAPICast.h:
  • Shared/API/c/WKURLRequest.cpp:

(WKURLRequestCopyURL):

  • Shared/API/c/mac/WKCertificateInfoMac.mm:
  • Shared/API/c/mac/WKURLRequestNS.mm:

(WKURLRequestCopyNSURLRequest):

  • Shared/API/c/mac/WKURLResponseNS.mm:

(WKURLResponseCopyNSURLResponse):

  • Shared/APIArray.h:
  • Shared/APIFrameHandle.cpp: Added.

(API::FrameHandle::create):
(API::FrameHandle::FrameHandle):
(API::FrameHandle::~FrameHandle):

  • Shared/APIFrameHandle.h: Added.

(API::FrameHandle::frameID):

  • Shared/APIGeometry.cpp: Added.

(API::Point::encode):
(API::Point::decode):
(API::Size::encode):
(API::Size::decode):
(API::Rect::encode):
(API::Rect::decode):

  • Shared/APIGeometry.h: Added.

(API::Size::create):
(API::Size::size):
(API::Size::Size):
(API::Point::create):
(API::Point::point):
(API::Point::Point):
(API::Rect::create):
(API::Rect::rect):
(API::Rect::Rect):

  • Shared/APINumber.h: Added.

(API::Number::create):
(API::Number::value):
(API::Number::encode):
(API::Number::decode):
(API::Number::Number):

  • Shared/APIObject.h:

(API::ObjectImpl::~ObjectImpl):
(API::ObjectImpl::ObjectImpl):

  • Shared/APIPageHandle.cpp: Added.

(API::PageHandle::create):
(API::PageHandle::PageHandle):
(API::PageHandle::~PageHandle):

  • Shared/APIPageHandle.h: Added.

(API::PageHandle::pageID):

  • Shared/AsyncTask.h: Added.

(WebKit::AsyncTask::~AsyncTask):
(WebKit::AsyncTask::AsyncTask):
(WebKit::createAsyncTask):

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::AuthenticationManager):

  • Shared/Authentication/AuthenticationManager.h:
  • Shared/Authentication/AuthenticationManager.messages.in:
  • Shared/Authentication/mac/AuthenticationManager.mac.mm:
  • Shared/ChildProcess.cpp:

(WebKit::ChildProcess::addMessageReceiver):

  • Shared/ChildProcess.h:
  • Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::addMessageReceiver):

  • Shared/ChildProcessProxy.h:
  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

  • Shared/Cocoa/WKNSData.h: Added.

(WebKit::wrapper):

  • Shared/Cocoa/WKNSData.mm: Added.

(-[WKNSData dealloc]):
(-[WKNSData length]):
(-[WKNSData bytes]):
(-[WKNSData copyWithZone:]):
(-[WKNSData API::]):

  • Shared/Cocoa/WKNSDictionary.mm:

(-[WKNSDictionary copyWithZone:]):

  • Shared/ImmutableDictionary.cpp:

(WebKit::ImmutableDictionary::create):
(WebKit::ImmutableDictionary::ImmutableDictionary):

  • Shared/ImmutableDictionary.h:
  • Shared/MutableDictionary.cpp:

(WebKit::MutableDictionary::MutableDictionary):

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:
  • Shared/Plugins/Netscape/PluginInformation.cpp:

(WebKit::getPluginModuleInformation):
(WebKit::createPluginInformationDictionary):

  • Shared/Plugins/Netscape/mac/PluginInformationMac.mm:

(WebKit::getPlatformPluginModuleInformation):

  • Shared/SecurityOriginData.cpp:

(WebKit::SecurityOriginData::isolatedCopy):

  • Shared/SecurityOriginData.h:
  • Shared/UserData.cpp: Added.

(WebKit::UserData::UserData):
(WebKit::UserData::~UserData):
(WebKit::UserData::transform):
(WebKit::UserData::encode):
(WebKit::UserData::decode):

  • Shared/UserData.h: Added.

(WebKit::UserData::object):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebArchive.h:
  • Shared/WebArchiveResource.h:
  • Shared/WebBackForwardListItem.h:
  • Shared/WebBatteryStatus.h:
  • Shared/WebCertificateInfo.h:

(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::certificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):

  • Shared/WebConnection.cpp:

(WebKit::WebConnection::postMessage):

  • Shared/WebConnection.h:
  • Shared/WebContextMenuItem.h:
  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebCrossThreadCopier.cpp: Added.

(WebCore::::copy):

  • Shared/WebCrossThreadCopier.h: Added.
  • Shared/WebData.h:
  • Shared/WebError.h:
  • Shared/WebGeolocationPosition.h:
  • Shared/WebGeometry.h:
  • Shared/WebHitTestResult.h:
  • Shared/WebImage.h:
  • Shared/WebNetworkInfo.h:
  • Shared/WebNumber.h:
  • Shared/WebOpenPanelParameters.h:
  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • Shared/WebPreferencesStore.h:
  • Shared/WebRenderLayer.h:
  • Shared/WebRenderObject.h:
  • Shared/WebSecurityOrigin.h:
  • Shared/WebSerializedScriptValue.h:
  • Shared/WebString.h:
  • Shared/WebURL.h:
  • Shared/WebURLRequest.cpp:
  • Shared/WebURLRequest.h:
  • Shared/WebURLResponse.h:
  • Shared/WebUserContentURLPattern.h:
  • Shared/mac/CertificateInfo.h:
  • Shared/mac/CertificateInfo.mm:
  • Shared/mac/ObjCObjectGraph.h:
  • Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/mac/WebURLRequestMac.mm:
  • Shared/mac/WebURLResponseMac.mm:
  • Shared/soup/CertificateInfo.cpp:
  • Shared/soup/CertificateInfo.h:
  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • UIProcess/API/C/CoordinatedGraphics/WKView.cpp:

(WKViewExitFullScreen):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetBackgroundExtendsBeyondPage):
(WKPageBackgroundExtendsBeyondPage):
(WKPageSetPageContextMenuClient):
(WKPageSelectContextMenuItem):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPagePolicyClientInternal.h: Added.
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMediaSourceEnabled):
(WKPreferencesGetMediaSourceEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • UIProcess/API/C/gtk/WKInspectorClientGtk.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm:
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(processDidCrash):
(setUpPageLoaderClient):
(setUpPagePolicyClient):

  • UIProcess/API/Cocoa/WKBrowsingContextLoadDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h:
  • UIProcess/API/Cocoa/WKConnection.mm:

(-[WKConnection dealloc]):
(-[WKConnection setDelegate:]):
(-[WKConnection sendMessageWithName:body:]):
(-[WKConnection remoteObjectRegistry]):
(-[WKConnection _connection]):
(-[WKConnection API::]):

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::fullScreenManagerProxyClient):
(WebKit::PageClientImpl::closeFullScreenManager):
(WebKit::PageClientImpl::isFullScreen):
(WebKit::PageClientImpl::enterFullScreen):
(WebKit::PageClientImpl::exitFullScreen):
(WebKit::PageClientImpl::beganEnterFullScreen):
(WebKit::PageClientImpl::beganExitFullScreen):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitBatteryProvider.cpp: Added.

(toBatteryProvider):
(startUpdatingCallback):
(stopUpdatingCallback):
(WebKitBatteryProvider::create):
(WebKitBatteryProvider::WebKitBatteryProvider):
(WebKitBatteryProvider::~WebKitBatteryProvider):
(WebKitBatteryProvider::startUpdating):
(WebKitBatteryProvider::stopUpdating):
(WebKitBatteryProvider::updateBatteryStatus):

  • UIProcess/API/gtk/WebKitBatteryProvider.h: Added.
  • UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:
  • UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:

(didReceiveWebViewMessageFromInjectedBundle):

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_mediasource):
(webkit_settings_set_enable_mediasource):

  • UIProcess/API/gtk/WebKitSettings.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(createDefaultWebContext):
(webkit_web_context_prefetch_dns):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_tls_info):
(webkit_web_view_get_snapshot):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseAddWebInspector):
(webkitWebViewBaseContainerRemove):
(resizeWebKitWebViewBaseFromAllocation):
(webkitWebViewBaseCreateWebPage):
(webkitWebViewBaseSetInspectorViewSize):

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/WebKitWindowProperties.cpp:

(webkitWindowPropertiesUpdateFromWebWindowFeatures):

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/tests/DOMNodeTest.cpp:

(WebKitDOMNodeTest::testTagNames):
(WebKitDOMNodeTest::runTest):
(registerTests):

  • UIProcess/API/gtk/tests/TestDOMNode.cpp:

(testWebKitDOMNodeTagNames):
(beforeAll):

  • UIProcess/API/gtk/tests/TestMain.cpp:

(main):

  • UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:

(testAtspiBasicHierarchy):

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings):

  • UIProcess/API/gtk/tests/WebProcessTestRunner.cpp:

(WebProcessTestRunner::WebProcessTestRunner):

  • UIProcess/API/ios/PageClientImplIOS.h:
  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::fullScreenManagerProxyClient):
(WebKit::PageClientImpl::closeFullScreenManager):
(WebKit::PageClientImpl::isFullScreen):
(WebKit::PageClientImpl::enterFullScreen):
(WebKit::PageClientImpl::exitFullScreen):
(WebKit::PageClientImpl::beganEnterFullScreen):
(WebKit::PageClientImpl::beganExitFullScreen):

  • UIProcess/API/ios/WKGeolocationProviderIOS.mm:

(-[WKGeolocationProviderIOS init]):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::fullScreenManagerProxyClient):
(WebKit::PageClientImpl::closeFullScreenManager):
(WebKit::PageClientImpl::isFullScreen):
(WebKit::PageClientImpl::enterFullScreen):
(WebKit::PageClientImpl::exitFullScreen):
(WebKit::PageClientImpl::beganEnterFullScreen):
(WebKit::PageClientImpl::beganExitFullScreen):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _hasFullScreenWindowController]):
(-[WKView _fullScreenWindowController]):
(-[WKView _closeFullScreenWindowController]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView fullScreenPlaceholderView]):
(-[WKView createFullScreenWindow]):
(-[WKView waitForAsyncDrawingAreaSizeUpdate]):
(-[WKView _ensureGestureController]):
(-[WKView setAllowsMagnification:]):
(-[WKView allowsMagnification]):
(-[WKView magnifyWithEvent:]):
(-[WKView endGestureWithEvent:]):
(-[WKView setMagnification:centeredAtPoint:]):
(-[WKView setMagnification:]):
(-[WKView magnification]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/APINavigationData.h:
  • UIProcess/Authentication/AuthenticationChallengeProxy.cpp:

(WebKit::AuthenticationChallengeProxy::useCredential):

  • UIProcess/Authentication/AuthenticationChallengeProxy.h:
  • UIProcess/Authentication/AuthenticationDecisionListener.h:
  • UIProcess/Authentication/WebCredential.h:
  • UIProcess/Authentication/WebProtectionSpace.h:
  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::fullScreenManagerProxyClient):
(WebKit::WebView::requestExitFullScreen):

  • UIProcess/CoordinatedGraphics/WebView.h:
  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::createDownloadProxy):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::beginTransientZoom):
(WebKit::DrawingAreaProxy::adjustTransientZoom):
(WebKit::DrawingAreaProxy::commitTransientZoom):

  • UIProcess/GeolocationPermissionRequestProxy.h:
  • UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:

(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::networkProcessCrashedOrFailedToLaunch):
(WebKit::NetworkProcessProxy::didCreateNetworkConnectionToWebProcess):

  • UIProcess/Network/soup/NetworkProcessProxySoup.cpp:

(WebKit::NetworkProcessProxy::platformGetLaunchOptions):

  • UIProcess/Notifications/NotificationPermissionRequest.h:
  • UIProcess/Notifications/WebNotification.h:
  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::populateCopyOfNotificationPermissions):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::clearNotifications):

  • UIProcess/PageClient.h:
  • UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::PageLoadState):
(WebKit::PageLoadState::endTransaction):
(WebKit::PageLoadState::commitChanges):
(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::isLoading):
(WebKit::PageLoadState::activeURL):
(WebKit::PageLoadState::estimatedProgress):
(WebKit::PageLoadState::pendingAPIRequestURL):
(WebKit::PageLoadState::setPendingAPIRequestURL):
(WebKit::PageLoadState::clearPendingAPIRequestURL):
(WebKit::PageLoadState::didStartProvisionalLoad):
(WebKit::PageLoadState::didReceiveServerRedirectForProvisionalLoad):
(WebKit::PageLoadState::didFailProvisionalLoad):
(WebKit::PageLoadState::didCommitLoad):
(WebKit::PageLoadState::didFinishLoad):
(WebKit::PageLoadState::didFailLoad):
(WebKit::PageLoadState::didSameDocumentNavigation):
(WebKit::PageLoadState::setUnreachableURL):
(WebKit::PageLoadState::title):
(WebKit::PageLoadState::setTitle):
(WebKit::PageLoadState::didStartProgress):
(WebKit::PageLoadState::didChangeProgress):
(WebKit::PageLoadState::didFinishProgress):

  • UIProcess/PageLoadState.h:

(WebKit::PageLoadState::Transaction::Transaction):
(WebKit::PageLoadState::Transaction::~Transaction):
(WebKit::PageLoadState::Transaction::Token::Token):
(WebKit::PageLoadState::transaction):
(WebKit::PageLoadState::provisionalURL):
(WebKit::PageLoadState::url):
(WebKit::PageLoadState::unreachableURL):
(WebKit::PageLoadState::beginTransaction):
(WebKit::PageLoadState::Data::Data):

  • UIProcess/Plugins/PlugInAutoStartProvider.cpp:

(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy):
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTable):

  • UIProcess/Plugins/WebPluginSiteDataManager.h:
  • UIProcess/StatisticsRequest.cpp:

(WebKit::addToDictionaryFromHashMap):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):

  • UIProcess/WebApplicationCacheManagerProxy.h:
  • UIProcess/WebBackForwardList.h:
  • UIProcess/WebBatteryManagerProxy.cpp:

(WebKit::WebBatteryManagerProxy::WebBatteryManagerProxy):

  • UIProcess/WebBatteryManagerProxy.h:
  • UIProcess/WebColorPickerResultListenerProxy.h:
  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::addMessageReceiver):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):

  • UIProcess/WebContext.h:

(WebKit::WebContext::sendToNetworkingProcess):
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):

  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy):
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebEditCommandProxy.h:
  • UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didCommitLoad):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::create):
(WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy):
(WebKit::WebFullScreenManagerProxy::invalidate):
(WebKit::WebFullScreenManagerProxy::close):
(WebKit::WebFullScreenManagerProxy::isFullScreen):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::beganExitFullScreen):

  • UIProcess/WebFullScreenManagerProxy.h:

(WebKit::WebFullScreenManagerProxyClient::~WebFullScreenManagerProxyClient):

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):

  • UIProcess/WebGeolocationManagerProxy.h:
  • UIProcess/WebGrammarDetail.h:
  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::WebIconDatabase):

  • UIProcess/WebIconDatabase.h:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::isMainInspectorPage):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebKeyValueStorageManager.h:
  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.h:
  • UIProcess/WebNetworkInfoManagerProxy.cpp:

(WebKit::WebNetworkInfoManagerProxy::WebNetworkInfoManagerProxy):

  • UIProcess/WebNetworkInfoManagerProxy.h:
  • UIProcess/WebOpenPanelResultListenerProxy.h:
  • UIProcess/WebOriginDataManagerProxy.cpp:

(WebKit::WebOriginDataManagerProxy::WebOriginDataManagerProxy):

  • UIProcess/WebOriginDataManagerProxy.h:
  • UIProcess/WebPageGroup.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::setBackgroundExtendsBeyondPage):
(WebKit::WebPageProxy::backgroundExtendsBeyondPage):
(WebKit::WebPageProxy::didStartProgress):
(WebKit::WebPageProxy::didChangeProgress):
(WebKit::WebPageProxy::didFinishProgress):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::didFindStringMatches):
(WebKit::WebPageProxy::sendMessage):
(WebKit::WebPageProxy::messageSenderConnection):
(WebKit::WebPageProxy::messageSenderDestinationID):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::initializeCreationParameters):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):

  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebPreferences.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::apiObjectByConvertingToHandles):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::WebResourceCacheManagerProxy):

  • UIProcess/WebResourceCacheManagerProxy.h:
  • UIProcess/WebTextChecker.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::createNewPage):

  • UIProcess/WebVibrationProxy.cpp:

(WebKit::WebVibrationProxy::WebVibrationProxy):

  • UIProcess/WebVibrationProxy.h:
  • UIProcess/WebViewportAttributes.h:
  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData):

  • UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:
  • UIProcess/efl/WebPopupItemEfl.h:
  • UIProcess/efl/WebViewEfl.cpp:

(WebKit::WebViewEfl::WebViewEfl):
(WebKit::WebViewEfl::setEwkView):
(WebKit::WebViewEfl::isFullScreen):
(WebKit::WebViewEfl::enterFullScreen):
(WebKit::WebViewEfl::exitFullScreen):

  • UIProcess/efl/WebViewEfl.h:
  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::setIgnoreTLSErrors):

  • UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
  • UIProcess/gtk/WebInspectorClientGtk.cpp:

(WebKit::WebInspectorClientGtk::didChangeAttachedWidth):

  • UIProcess/gtk/WebInspectorClientGtk.h:
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
(WebKit::WebInspectorProxy::platformSetAttachedWindowWidth):

  • UIProcess/ios/WebFullScreenManagerProxyIOS.mm:
  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::insertText):

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::RemoteLayerTreeHost):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::beginTransientZoom):
(WebKit::TiledCoreAnimationDrawingAreaProxy::adjustTransientZoom):
(WebKit::TiledCoreAnimationDrawingAreaProxy::commitTransientZoom):

  • UIProcess/mac/ViewGestureController.h: Added.
  • UIProcess/mac/ViewGestureController.messages.in: Added.
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]):

  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::userVisibleWebKitVersionString):

  • UIProcess/soup/WebContextSoup.cpp:

(WebKit::WebContext::platformInitializeNetworkProcess):

  • UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::WebSoupRequestManagerProxy):

  • UIProcess/soup/WebSoupRequestManagerProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::WebApplicationCacheManager):

  • WebProcess/Battery/WebBatteryManager.cpp:

(WebKit::WebBatteryManager::WebBatteryManager):

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::WebCookieManager):

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::WebGeolocationManager):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::WebIconDatabaseProxy):

  • WebProcess/InjectedBundle/API/Cocoa: Added.
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: Added.
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm: Added.

(-[WKWebProcessPlugInFrame dealloc]):
(-[WKWebProcessPlugInFrame jsContextForWorld:]):
(-[WKWebProcessPlugInFrame hitTest:]):
(-[WKWebProcessPlugInFrame jsNodeForNodeHandle:inWorld:]):
(-[WKWebProcessPlugInFrame API::]):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrameInternal.h: Added.

(WebKit::wrapper):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.h: Added.
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm: Added.

(-[WKWebProcessPlugInHitTestResult dealloc]):
(-[WKWebProcessPlugInHitTestResult nodeHandle]):
(-[WKWebProcessPlugInHitTestResult API::]):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResultInternal.h: Added.

(WebKit::wrapper):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h: Added.
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm: Added.

(-[WKWebProcessPlugInNodeHandle dealloc]):
(-[WKWebProcessPlugInNodeHandle API::]):
(-[WKWebProcessPlugInNodeHandle _nodeHandle]):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandleInternal.h: Added.

(WebKit::wrapper):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.h: Added.
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm: Added.

(+[WKWebProcessPlugInScriptWorld world]):
(+[WKWebProcessPlugInScriptWorld normalWorld]):
(-[WKWebProcessPlugInScriptWorld dealloc]):
(-[WKWebProcessPlugInScriptWorld API::]):
(-[WKWebProcessPlugInScriptWorld _scriptWorld]):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorldInternal.h: Added.

(WebKit::wrapper):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetContextMenuClient):
(WKBundlePageClickMenuItem):
(WKBundlePageCopyContextMenuItems):
(WKBundlePageCopyContextMenuAtPointInWindow):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(didInitiateLoadForResource):
(willSendRequestForFrame):
(didReceiveResponseForResource):
(didReceiveContentLengthForResource):
(didFinishLoadForResource):
(didFailLoadForResource):
(webkitWebPageDidReceiveMessage):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

(-[WKWebProcessPlugInController dealloc]):
(didCreatePage):
(willDestroyPage):
(setUpBundleClient):
(-[WKWebProcessPlugInController _setPrincipalClassInstance:]):
(-[WKWebProcessPlugInController connection]):
(-[WKWebProcessPlugInController API::]):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController dealloc]):
(-[WKWebProcessPlugInBrowserContextController mainFrameDocument]):
(-[WKWebProcessPlugInBrowserContextController selectedRange]):
(-[WKWebProcessPlugInBrowserContextController API::]):
(-[WKWebProcessPlugInBrowserContextController _bundlePageRef]):
(-[WKWebProcessPlugInBrowserContextController handle]):
(+[WKWebProcessPlugInBrowserContextController lookUpBrowsingContextFromHandle:]):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:

(WebKit::wrapper):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:

(WebKit::wrapper):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
(WebKit::InjectedBundlePageFormClient::willSubmitForm):

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):

  • WebProcess/MediaCache/WebMediaCacheManager.cpp:

(WebKit::WebMediaCacheManager::WebMediaCacheManager):

  • WebProcess/Network/WebResourceLoader.cpp:
  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
  • WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:

(WebKit::WebNetworkInfoManager::WebNetworkInfoManager):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::WebNotificationManager):

  • WebProcess/OriginData/WebOriginDataManager.cpp:

(WebKit::WebOriginDataManager::WebOriginDataManager):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performJavaScriptURLRequest):

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::WebResourceCacheManager):

  • WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::StorageAreaMap):

  • WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::WebConnectionToUIProcess):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::print):

  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::WebDatabaseManager):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::beginTransientZoom):
(WebKit::DrawingArea::adjustTransientZoom):
(WebKit::DrawingArea::commitTransientZoom):

  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/PageBanner.h:
  • WebProcess/WebPage/PageOverlay.h:
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebInspector.cpp:
  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::trackedRepaintRects):
(WebKit::WebPage::setBackgroundExtendsBeyondPage):
(WebKit::WebPage::updatePreferences):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/WebPageGroupProxy.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::insertText):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::beginTransientZoom):
(WebKit::TiledCoreAnimationDrawingArea::adjustTransientZoom):
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:

(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureNetworkProcessConnection):
(WebKit::WebProcess::apiObjectByConvertingFromHandles):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
  • WebProcess/gtk/WebGtkExtensionManager.h:
  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformClearResourceCaches):
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost):

  • WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::WebSoupRequestManager):

  • config.h:

Source/WTF:

  • GNUmakefile.list.am:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/AVLTree.h:
  • wtf/Assertions.h:
  • wtf/BitArray.h:
  • wtf/Bitmap.h:
  • wtf/CMakeLists.txt:
  • wtf/Compiler.h:
  • wtf/FixedArray.h:
  • wtf/HashMap.h:

(WTF::HashMap::HashMap):

  • wtf/MD5.cpp:

(WTF::toLittleEndian):
(WTF::MD5::addBytes):
(WTF::MD5::checksum):

  • wtf/MD5.h:
  • wtf/MathExtras.h:
  • wtf/PlatformGTK.cmake:
  • wtf/RetainPtr.h:

(WTF::RetainPtr::operator bool):

  • wtf/SHA1.cpp:

(WTF::SHA1::computeHash):
(WTF::SHA1::hexDigest):
(WTF::SHA1::computeHexDigest):

  • wtf/SHA1.h:
  • wtf/SixCharacterHash.cpp:

(WTF::integerToSixCharacterHashString):

  • wtf/SixCharacterHash.h:
  • wtf/StdLibExtras.h:
  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):

  • wtf/text/WTFString.h:

Tools:

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunPythonTests):

  • DumpRenderTree/AccessibilityUIElement.cpp:

(characterAtOffsetCallback):
(wordAtOffsetCallback):
(lineAtOffsetCallback):
(sentenceAtOffsetCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
  • DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
  • DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::role):
(AccessibilityUIElement::stringForRange):
(stringAtOffset):
(AccessibilityUIElement::characterAtOffset):
(AccessibilityUIElement::wordAtOffset):
(AccessibilityUIElement::lineAtOffset):
(AccessibilityUIElement::sentenceAtOffset):

  • DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:

(computeMD5HashStringForBitmapContext):

  • DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:

(computeMD5HashStringForBitmapContext):

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::overridePreference):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):
(initializeGlobalsFromCommandLineOptions):

  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm:
  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c:
  • DumpRenderTree/mac/PerlSupport/Makefile:
  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setCacheModel):

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/gtk/CMakeLists.txt:
  • MiniBrowser/mac/AppDelegate.h:
  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate applicationWillTerminate:]):
(-[BrowserAppDelegate openDocument:]):

  • MiniBrowser/mac/WK2BrowserWindowController.h:
  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController fetch:]):
(-[WK2BrowserWindowController reload:]):
(-[WK2BrowserWindowController goBack:]):
(-[WK2BrowserWindowController goForward:]):
(-[WK2BrowserWindowController validateUserInterfaceItem:]):
(-[WK2BrowserWindowController currentZoomFactor]):
(-[WK2BrowserWindowController setCurrentZoomFactor:]):
(-[WK2BrowserWindowController zoomIn:]):
(-[WK2BrowserWindowController zoomOut:]):
(-[WK2BrowserWindowController canResetZoom]):
(-[WK2BrowserWindowController resetZoom:]):
(-[WK2BrowserWindowController toggleZoomMode:]):
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
(createNewPage):
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController updateTextFieldFromURL:]):
(-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
(-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
(-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
(-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]):
(-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]):
(-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
(-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
(-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
(-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):

  • Scripts/build-jsc:
  • Scripts/compare-webkit-configurations: Added.

(main):
(flag_for_comparison):
(run_webkit_tests):

  • Scripts/old-run-webkit-tests:

(dumpToolDidCrash):

  • Scripts/run-gtk-tests:

(TestRunner._run_test_glib):
(TestRunner):
(TestRunner._get_tests_from_google_test_suite):
(TestRunner._run_google_test):
(TestRunner._run_google_test_suite):
(TestRunner._run_test):

  • Scripts/run-javascriptcore-tests:
  • Scripts/webkitdirs.pm:

(visualStudioInstallDir):
(visualStudioVersion):
(setupAppleWinEnv):
(setupCygwinEnv):

  • Scripts/webkitperl/FeatureList.pm:
  • Scripts/webkitpy/common/config/contributors.json:
  • Scripts/webkitpy/common/config/watchlist:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(CommitQueueFlag):
(Bugzilla._commit_queue_flag):
(Bugzilla._fill_attachment_form):
(Bugzilla.add_patch_to_bug):
(Bugzilla.create_bug):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(test_commit_queue_flag.assert_commit_queue_flag):
(test_commit_queue_flag):

  • Scripts/webkitpy/common/prettypatch.py:

(PrettyPatch.init):
(PrettyPatch.pretty_diff):
(PrettyPatch):
(PrettyPatch.pretty_patch_available):
(PrettyPatch.check_pretty_patch):
(PrettyPatch.pretty_patch_text):

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._run_compare_test):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.create_text_diff_and_write_result):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

  • Scripts/webkitpy/layout_tests/reftests/init.py:
  • Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py:
  • Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/port/base.py:

(Port.init):
(Port.wdiff_available):
(Port.check_image_diff):
(Port.reference_files):
(Port.wdiff_text):
(Port._build_driver):
(Port.logging_patterns_to_strip):

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

  • Scripts/webkitpy/port/driver.py:

(DriverOutput):
(DriverOutput.strip_metrics):
(DriverOutput.strip_patterns):
(Driver.cmd_line):

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server):

  • Scripts/webkitpy/port/mac.py:

(MacPort.xcrun_find):
(MacPort):
(MacPort.logging_patterns_to_strip):

  • Scripts/webkitpy/port/westondriver_unittest.py: Added.

(WestonDriverTest):
(WestonDriverTest.make_driver):
(WestonDriverTest.test_start):
(WestonDriverTest.test_stop):
(WestonDriverTest.test_stop.FakeWestonProcess):
(WestonDriverTest.test_stop.FakeWestonProcess.terminate):

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_for_missing_new_line_at_eof):
(check_for_extra_new_line_at_eof):
(check_spacing):
(check_member_initialization_list):
(_process_lines):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_spacing_for_binary_ops):
(CppStyleTest.test_extra_newlines_at_eof):
(CppStyleTest.test_extra_newlines_at_eof.do_test):
(WebKitStyleTest.test_member_initialization_list):

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/MD5.cpp:

(TestWebKitAPI::expectMD5):

  • WebKitTestRunner/CMakeLists.txt:
  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::characterAtOffset):
(WTR::AccessibilityUIElement::wordAtOffset):
(WTR::AccessibilityUIElement::lineAtOffset):
(WTR::AccessibilityUIElement::sentenceAtOffset):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::stringAtOffset):
(WTR::AccessibilityUIElement::characterAtOffset):
(WTR::AccessibilityUIElement::wordAtOffset):
(WTR::AccessibilityUIElement::lineAtOffset):
(WTR::AccessibilityUIElement::sentenceAtOffset):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::resetPreferencesToConsistentValues):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::shouldUseRemoteLayerTree):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::updateThreadedScrollingForCurrentTest):

  • WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::computeMD5HashStringForCairoSurface):

  • WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::computeMD5HashStringForContext):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

  • WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
  • gdb/webkit.py:

(WTFCStringPrinter.to_string):
(JSCJSStringPrinter.to_string):

  • gtk/common.py:

(get_build_path):

  • gtk/generate-gtkdoc:

(get_webkit2_options):

  • gtk/install-dependencies:
  • gtk/jhbuild.modules:
  • gtk/ycm_extra_conf.py: Added.

(transform_relative_paths_to_absolute_paths):
(create_make_trace_file):
(make_trace_file_up_to_date):
(ensure_make_trace_file):
(get_compilation_flags_from_build_commandline):
(get_compilation_flags_for_file):
(FlagsForFile):

  • win/record-memory/record-memory.vcxproj:

LayoutTests:

  • TestExpectations:
  • accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
  • accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Added.
  • accessibility/alt-tag-on-image-with-nonimage-role.html: Added.
  • accessibility/aria-hidden-negates-no-visibility-expected.txt: Added.
  • accessibility/aria-mappings-expected.txt:
  • accessibility/children-changed-sends-notification-expected.txt: Added.
  • accessibility/children-changed-sends-notification.html: Added.
  • accessibility/div-within-anchors-causes-crash-expected.txt:
  • accessibility/press-targets-center-point.html:
  • animations/resources/animation-test-helpers.js:

(parseBasicShape):
(basicShapeParametersMatch):

  • crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt:
  • crypto/subtle/aes-cbc-192-encrypt-decrypt.html:
  • crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt:
  • crypto/subtle/aes-cbc-256-encrypt-decrypt.html:
  • crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt:
  • crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
  • crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html:
  • crypto/subtle/aes-cbc-encrypt-decrypt.html:
  • crypto/subtle/aes-cbc-generate-key-expected.txt:
  • crypto/subtle/aes-cbc-generate-key.html:
  • crypto/subtle/aes-cbc-import-jwk-expected.txt:
  • crypto/subtle/aes-cbc-import-jwk.html:
  • crypto/subtle/aes-cbc-invalid-length-expected.txt:
  • crypto/subtle/aes-cbc-invalid-length.html:
  • crypto/subtle/aes-cbc-unwrap-failure-expected.txt:
  • crypto/subtle/aes-cbc-unwrap-failure.html:
  • crypto/subtle/aes-cbc-unwrap-rsa-expected.txt:
  • crypto/subtle/aes-cbc-unwrap-rsa.html:
  • crypto/subtle/aes-cbc-wrap-rsa-expected.txt:
  • crypto/subtle/aes-cbc-wrap-rsa-non-extractable-expected.txt:
  • crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html:
  • crypto/subtle/aes-cbc-wrap-rsa.html:
  • crypto/subtle/aes-kw-key-manipulation-expected.txt:
  • crypto/subtle/aes-kw-key-manipulation.html:
  • crypto/subtle/aes-kw-wrap-unwrap-aes-expected.txt:
  • crypto/subtle/aes-kw-wrap-unwrap-aes.html:
  • crypto/subtle/aes-postMessage-expected.txt: Added.
  • crypto/subtle/aes-postMessage.html: Added.
  • crypto/subtle/hmac-generate-key-expected.txt:
  • crypto/subtle/hmac-generate-key.html:
  • crypto/subtle/hmac-import-jwk-expected.txt:
  • crypto/subtle/hmac-import-jwk.html:
  • crypto/subtle/hmac-postMessage-expected.txt: Added.
  • crypto/subtle/hmac-postMessage.html: Added.
  • crypto/subtle/hmac-sign-verify-empty-key-expected.txt:
  • crypto/subtle/hmac-sign-verify-empty-key.html:
  • crypto/subtle/hmac-sign-verify-expected.txt:
  • crypto/subtle/hmac-sign-verify.html:
  • crypto/subtle/jwk-import-use-values-expected.txt:
  • crypto/subtle/jwk-import-use-values.html:
  • crypto/subtle/postMessage-worker-expected.txt: Added.
  • crypto/subtle/postMessage-worker.html: Added.
  • crypto/subtle/resources/postMessage-worker.js: Added.

(onmessage):

  • crypto/subtle/rsa-oaep-generate-non-extractable-key-expected.txt: Added.
  • crypto/subtle/rsa-oaep-generate-non-extractable-key.html: Added.
  • crypto/subtle/rsa-oaep-key-manipulation-expected.txt:
  • crypto/subtle/rsa-oaep-key-manipulation.html:
  • crypto/subtle/rsa-oaep-wrap-unwrap-aes-expected.txt:
  • crypto/subtle/rsa-oaep-wrap-unwrap-aes.html:
  • crypto/subtle/rsa-postMessage-expected.txt: Added.
  • crypto/subtle/rsa-postMessage.html: Added.
  • crypto/subtle/rsaes-pkcs1-v1_5-decrypt-expected.txt: Added.
  • crypto/subtle/rsaes-pkcs1-v1_5-decrypt.html: Added.
  • crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt: Added.
  • crypto/subtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html: Added.
  • crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt:
  • crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html:
  • crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt:
  • crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html:
  • crypto/subtle/unwrapKey-check-usage-expected.txt: Added.
  • crypto/subtle/unwrapKey-check-usage.html: Added.
  • crypto/subtle/wrapKey-check-usage-expected.txt: Added.
  • crypto/subtle/wrapKey-check-usage.html: Added.
  • dom/xhtml/level3/core/documentgetinputencoding04-expected.txt:
  • dom/xhtml/level3/core/documentgetxmlencoding05-expected.txt:
  • dom/xhtml/level3/core/nodeisequalnode01-expected.txt:
  • dom/xhtml/level3/core/nodeisequalnode21-expected.txt:
  • dom/xhtml/level3/core/nodeisequalnode25-expected.txt:
  • dom/xhtml/level3/core/nodeisequalnode26-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:
  • fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-end-after-get-set.html:
  • fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-start-before-get-set.html:
  • fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js:
  • fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-border-radius-shorthand.html:
  • fast/css/nth-last-child-recalc-expected.html: Added.
  • fast/css/nth-last-child-recalc.html: Added.
  • fast/css/pending-image-crash-expected.txt: Added.
  • fast/css/pending-image-crash.xhtml: Added.
  • fast/css/style-sharing-grand-parent-invalidate-expected.txt: Added.
  • fast/css/style-sharing-grand-parent-invalidate.html: Added.
  • fast/dom/Document/clone-node-expected.txt: Added.
  • fast/dom/Document/clone-node.html: Added.
  • fast/dom/HTMLDocument/clone-node-quirks-mode-expected.txt: Added.
  • fast/dom/HTMLDocument/clone-node-quirks-mode.html: Added.
  • fast/dom/HTMLTableElement/empy-table-cell-with-background-color-expected.txt: Added.
  • fast/dom/HTMLTableElement/empy-table-cell-with-background-color.html: Added.
  • fast/dom/Window/postMessage-clone-port-error-expected.txt: Added.
  • fast/dom/Window/postMessage-clone-port-error.html: Added.
  • fast/events/message-port-clone-expected.txt:
  • fast/events/message-port-multi-expected.txt:
  • fast/events/stopPropagation-submit-expected.txt:
  • fast/forms/input-image-submit.html:
  • fast/mediastream/RTCPeerConnection-createAnswer-expected.txt:
  • fast/mediastream/RTCPeerConnection-createAnswer.html:
  • fast/mediastream/RTCPeerConnection-createOffer-expected.txt:
  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
  • fast/shapes/shape-outside-floats/shape-outside-animation.html:
  • fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html:
  • fast/table/auto-100-percent-width-expected.txt:
  • inspector-protocol/model/highlight-shape-outside-margin-expected.txt: Added.
  • inspector-protocol/model/highlight-shape-outside-margin.html: Added.
  • inspector-protocol/model/highlight-shape-outside.html:
  • inspector-protocol/page/deny-X-FrameOption-expected.txt: Added.
  • inspector-protocol/page/deny-X-FrameOption.html: Added.
  • inspector-protocol/resources/shape-info-helper.js:

(window.ShapeInfoHelper.):
(window.ShapeInfoHelper):

  • media/media-source/media-source-canplaythrough.html:
  • media/media-source/media-source-end-of-stream-expected.txt: Added.
  • media/media-source/media-source-end-of-stream.html: Added.
  • media/media-source/media-source-play.html:
  • media/media-source/media-source-video-playback-quality-expected.txt: Added.
  • media/media-source/media-source-video-playback-quality.html: Added.
  • media/media-source/mock-media-source.js:

(var):

  • platform/efl-wk1/accessibility/image-map2-expected.txt:
  • platform/efl-wk1/accessibility/lists-expected.txt:
  • platform/efl-wk1/accessibility/transformed-element-expected.txt:
  • platform/efl-wk2/TestExpectations:
  • platform/efl-wk2/accessibility/image-map2-expected.txt:
  • platform/efl-wk2/accessibility/lists-expected.txt:
  • platform/efl-wk2/accessibility/transformed-element-expected.txt:
  • platform/efl/TestExpectations:
  • platform/efl/accessibility/media-emits-object-replacement-expected.txt:
  • platform/efl/fast/forms/validation-message-appearance-expected.txt:
  • platform/efl/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/efl/fast/table/empty-cells-expected.txt:
  • platform/efl/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
  • platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/aria-roles-unignored-expected.txt:
  • platform/gtk/accessibility/aria-roles-unignored.html:
  • platform/gtk/accessibility/entry-and-password-expected.txt:
  • platform/gtk/accessibility/image-map2-expected.txt:
  • platform/gtk/accessibility/lists-expected.txt:
  • platform/gtk/accessibility/media-emits-object-replacement-expected.txt:
  • platform/gtk/accessibility/object-with-title-expected.txt:
  • platform/gtk/accessibility/object-with-title.html:
  • platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt:
  • platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt:
  • platform/gtk/accessibility/spans-paragraphs-and-divs.html:
  • platform/gtk/accessibility/text-at-offset-embedded-objects-expected.txt: Added.
  • platform/gtk/accessibility/text-at-offset-embedded-objects.html: Added.
  • platform/gtk/accessibility/text-at-offset-newlines-expected.txt: Added.
  • platform/gtk/accessibility/text-at-offset-newlines.html: Added.
  • platform/gtk/accessibility/text-at-offset-preformatted-expected.txt: Added.
  • platform/gtk/accessibility/text-at-offset-preformatted.html: Added.
  • platform/gtk/accessibility/text-at-offset-simple-expected.txt: Added.
  • platform/gtk/accessibility/text-at-offset-simple.html: Added.
  • platform/gtk/accessibility/text-at-offset-special-chars-expected.txt: Added.
  • platform/gtk/accessibility/text-at-offset-special-chars.html: Added.
  • platform/gtk/accessibility/text-at-offset-textarea-expected.txt: Added.
  • platform/gtk/accessibility/text-at-offset-textarea.html: Added.
  • platform/gtk/accessibility/text-at-offset-textinput-expected.txt: Added.
  • platform/gtk/accessibility/text-at-offset-textinput.html: Added.
  • platform/gtk/accessibility/text-at-offset-wrapped-lines-expected.txt: Added.
  • platform/gtk/accessibility/text-at-offset-wrapped-lines.html: Added.
  • platform/gtk/accessibility/text-for-range-combo-box-expected.txt: Added.
  • platform/gtk/accessibility/text-for-range-combo-box.html: Added.
  • platform/gtk/accessibility/text-for-range-embedded-objects-expected.txt: Added.
  • platform/gtk/accessibility/text-for-range-embedded-objects.html: Added.
  • platform/gtk/accessibility/text-for-range-entry-and-password-expected.txt: Added.
  • platform/gtk/accessibility/text-for-range-entry-and-password.html: Added.
  • platform/gtk/accessibility/text-for-range-extraneous-whitespace-expected.txt: Added.
  • platform/gtk/accessibility/text-for-range-extraneous-whitespace.html: Added.
  • platform/gtk/accessibility/text-for-range-formatted-expected.txt: Added.
  • platform/gtk/accessibility/text-for-range-formatted.html: Added.
  • platform/gtk/accessibility/text-for-range-heading-expected.txt: Added.
  • platform/gtk/accessibility/text-for-range-heading.html: Added.
  • platform/gtk/accessibility/text-for-range-list-items-expected.txt: Added.
  • platform/gtk/accessibility/text-for-range-list-items.html: Added.
  • platform/gtk/accessibility/text-for-range-simple-expected.txt: Added.
  • platform/gtk/accessibility/text-for-range-simple.html: Added.
  • platform/gtk/accessibility/text-for-range-table-cells-expected.txt: Added.
  • platform/gtk/accessibility/text-for-range-table-cells.html: Added.
  • platform/gtk/accessibility/text-for-range-with-link-expected.txt: Added.
  • platform/gtk/accessibility/text-for-range-with-link.html: Added.
  • platform/gtk/accessibility/text-for-table-expected.txt: Added.
  • platform/gtk/accessibility/text-for-table.html: Added.
  • platform/gtk/accessibility/transformed-element-expected.txt:
  • platform/gtk/fast/events/stopPropagation-submit-expected.txt:
  • platform/mac/accessibility/aria-hidden-negates-no-visibility-expected.txt:
  • platform/mac/fast/table/empty-cells-expected.txt:
  • svg/custom/clone-node-expected.txt: Added.
  • svg/custom/clone-node.html: Added.
  • svg/dom/SVGScriptElement/script-type-attribute-expected.txt: Added.
  • svg/dom/SVGScriptElement/script-type-attribute.svg: Added.
  • tables/mozilla/bugs/bug1818-6-expected.txt:
10:52 AM Changeset in webkit [162626] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] [WK2] WKContentView has a black background
https://bugs.webkit.org/show_bug.cgi?id=127471
<rdar://problem/12287363>

Reviewed by Sam Weinig.

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
Instead of giving it a (black!) background to make hit-testing work, use CALayer SPI
to tell CA that the whole layer should be treated as opaque when it comes to hit-testing.

10:48 AM Changeset in webkit [162625] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] Mark test mathml/presentation/maction-toggle.html as failing in TestExpectation

For now, mark the test mathml/presentation/maction-toggle.html as failing. See
<https://bugs.webkit.org/show_bug.cgi?id=127495> for more details.

  • platform/win/TestExpectations:
10:47 AM Changeset in webkit [162624] by Brent Fulgham
  • 28 edits in branches/safari-537.75-branch/Source

Merge r162621

2014-01-22 Brent Fulgham <Brent Fulgham>

Source/JavaScriptCore:

[Win] Update project and solution files for 64-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=127457

Reviewed by Eric Carlson.

  • JavaScriptCore.vcxproj/JavaScriptCore.submit.sln: Add 64-bit target.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Specify v100 target for all builds on this branch.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Add missing file from project view.
  • JavaScriptCore.vcxproj/jsc/jsc.vcxproj: Specify v100 target for all builds on this branch.
  • JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj: Ditto
  • JavaScriptCore.vcxproj/testapi/testapi.vcxproj: Ditto

Source/WebCore:

[Win] Update project and solution files for 64-bit builds
https://bugs.webkit.org/show_bug.cgi?id=127457

Reviewed by Eric Carlson.

  • WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj: Specify v100 target
  • WebCore.vcxproj/WebCore.submit.sln: Add x64 targets
  • WebCore.vcxproj/WebCore.vcxproj: Specify v100 target for all builds on this branch. Also exclude 32-bit specific assembly when building 64-bit target, and correct bad merge from branch.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Correct branch merge
  • config.h: Handle 64-bit type definitions.
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (PlatformCAAnimation::setFromValue): Use CGFloat to support 64-bit builds (PlatformCAAnimation::setToValue): Ditto (PlatformCAAnimation::setValues): Ditto
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): Add cast to support 32- and 64-bit targets.
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawLineForDocumentMarker): Use CGFloat to support 64-bit builds.
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeURLToDataObject): Specialize std::min to work on 32- and 64-bit code. (WebCore::createGlobalImageFileDescriptor): Ditto
  • platform/win/StructuredExceptionHandlerSuppressor.cpp: (WebCore::StructuredExceptionHandlerSuppressor::StructuredExceptionHandlerSuppressor): Comment out 32-bit inline assembly. (WebCore::StructuredExceptionHandlerSuppressor::~StructuredExceptionHandlerSuppressor): Ditto

Source/WebKit:

[Win] Update project and solution files for 64-bit builds
https://bugs.webkit.org/show_bug.cgi?id=127457

Reviewed by Eric Carlson.

  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Specify v100 target for all builds on this branch.
  • WebKit.vcxproj/WebKit.submit.sln: Add 64-bit target.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj: Specify v100 target for all builds on this branch.
  • WebKit.vcxproj/WebKit/WebKitApple.props: Remove unused QTMovieWin library dependency.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj: Specify v100 target for all builds on this branch.
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Ditto

Source/WTF:

[Win] Update project and solution files for 64-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=127457

Reviewed by Eric Carlson.

  • WTF.vcxproj/WTF.submit.sln: Add x64 targets.
  • WTF.vcxproj/WTF.vcxproj: Specify v100 target for all builds on this branch.
10:20 AM Changeset in webkit [162623] by commit-queue@webkit.org
  • 8 edits in trunk

[Curl] There is no way to specify cache folder.
https://bugs.webkit.org/show_bug.cgi?id=125028

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-23
Reviewed by Brent Fulgham.

Source/WebCore:

Fixed logical test, disc cache should be disabled if creating cache folder fails.

  • platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::setCacheDirectory):

Source/WebKit/win:

Added interface methods to set and get cache folder location.

  • Interfaces/IWebCache.idl:
  • WebCache.cpp:

(WebCache::disabled):
(WebCache::cacheFolder):
(WebCache::setCacheFolder):

  • WebCache.h:

Tools:

Enable disc cache in WinLauncher by setting cache folder location.

  • WinLauncher/WinLauncher.cpp:

(getAppDataFolder): Added function to get app data folder.
(setCacheFolder): Added function to set cache folder.
(createCrashReport): Use new getAppDataFolder function.
(wWinMain): Use function setCacheFolder to set cache folder location.

10:15 AM Changeset in webkit [162622] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • WebCore.xcodeproj/project.pbxproj: Export the new header so WebKit can see it
10:14 AM Changeset in webkit [162621] by Brent Fulgham
  • 24 edits in trunk/Source

../JavaScriptCore: [Win] Update project and solution files for 64-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=127457

Reviewed by Eric Carlson.

file from project view.

../WebCore: [Win] Update project and solution files for 64-bit builds
https://bugs.webkit.org/show_bug.cgi?id=127457

Reviewed by Eric Carlson.

  • WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj: Update for VS2013
  • WebCore.vcxproj/WebCore.submit.sln: Add x64 targets
  • WebCore.vcxproj/WebCore.vcxproj: Update for VS2013. Also exclude 32-bit specific

assembly when building 64-bit target.

  • WebCore.vcxproj/WebCore.vcxproj.filters: Update for VS2013
  • config.h: Handle 64-bit type definitions.
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(PlatformCAAnimation::setFromValue): Use CGFloat to support 64-bit builds
(PlatformCAAnimation::setToValue): Ditto
(PlatformCAAnimation::setValues): Ditto

  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Add cast to
support 32- and 64-bit targets.

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker): Use CGFloat to
support 64-bit builds.

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeURLToDataObject): Specialize std::min to
work on 32- and 64-bit code.
(WebCore::createGlobalImageFileDescriptor): Ditto

  • platform/win/StructuredExceptionHandlerSuppressor.cpp:

(WebCore::StructuredExceptionHandlerSuppressor::StructuredExceptionHandlerSuppressor):
Comment out 32-bit inline assembly.
(WebCore::StructuredExceptionHandlerSuppressor::~StructuredExceptionHandlerSuppressor):
Ditto

../WebKit: [Win] Update project and solution files for 64-bit builds
https://bugs.webkit.org/show_bug.cgi?id=127457

Reviewed by Eric Carlson.

  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Update for VS2013.
  • WebKit.vcxproj/WebKit.submit.sln: Add 64-bit target.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj: Update for VS2013
  • WebKit.vcxproj/WebKit/WebKitApple.props: Remove unused QTMovieWin

library dependency.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:

Update for VS2013.

  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Ditto

../WTF: [Win] Update project and solution files for 64-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=127457

Reviewed by Eric Carlson.

  • WTF.vcxproj/WTF.submit.sln: Add x64 targets.
  • WTF.vcxproj/WTF.vcxproj: Update for VS2013
10:07 AM Changeset in webkit [162620] by dbates@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[Win] Mark test js/dom/date-big-constructor.html as failing and add Windows expected result

Mark the test js/dom/date-big-constructor.html as failing while we investigate
regression in <https://bugs.webkit.org/show_bug.cgi?id=127492>. Also add Windows expected
result for test fast/css/relative-position-replaced-in-table-display-crash.html as the test
passes but differs in whitespace. We'll investigate this whitespace difference in
<https://bugs.webkit.org/show_bug.cgi?id=127479>.

  • platform/win/TestExpectations:
  • platform/win/fast/css/relative-position-replaced-in-table-display-crash-expected.txt: Added.
10:03 AM Changeset in webkit [162619] by beidson@apple.com
  • 4 edits
    1 add in trunk/Source/WebCore

Make IDBGetResult work with IDBKeyData instead of IDBKey.
https://bugs.webkit.org/show_bug.cgi?id=127493

Reviewed by Eric Carlson.

Also break it into its own header to work better with IPC messages.

  • Modules/indexeddb/IDBGetResult.h: Added.

(WebCore::IDBGetResult::IDBGetResult):

  • Modules/indexeddb/IDBServerConnection.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::GetOperation::perform):

  • WebCore.xcodeproj/project.pbxproj:
9:53 AM Changeset in webkit [162618] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[curl] Add storage limit to cache manager
https://bugs.webkit.org/show_bug.cgi?id=125779

Patch by Mátyás Mustoha <mmatyas@inf.u-szeged.hu> on 2014-01-23
Reviewed by Brent Fulgham.

Sets a local disc storage size limit for the cache manager
used by the curl network backend.

  • platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::CurlCacheEntry):
(WebCore::CurlCacheEntry::isCached):
(WebCore::CurlCacheEntry::saveCachedData):
(WebCore::CurlCacheEntry::readCachedData):
(WebCore::CurlCacheEntry::didFail):
(WebCore::CurlCacheEntry::didFinishLoading):
(WebCore::CurlCacheEntry::loadFileToBuffer):
(WebCore::CurlCacheEntry::parseResponseHeaders):
(WebCore::CurlCacheEntry::entrySize):

  • platform/network/curl/CurlCacheEntry.h:

(WebCore::CurlCacheEntry::requestHeaders):

  • platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::CurlCacheManager):
(WebCore::CurlCacheManager::setStorageSizeLimit):
(WebCore::CurlCacheManager::loadIndex):
(WebCore::CurlCacheManager::saveIndex):
(WebCore::CurlCacheManager::makeRoomForNewEntry):
(WebCore::CurlCacheManager::didReceiveResponse):
(WebCore::CurlCacheManager::didReceiveData):
(WebCore::CurlCacheManager::invalidateCacheEntry):
(WebCore::CurlCacheManager::readCachedData):

  • platform/network/curl/CurlCacheManager.h:

(WebCore::CurlCacheManager::cacheDirectory):

9:33 AM Changeset in webkit [162617] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for failing tests.

  • platform/efl/TestExpectations:
9:25 AM Changeset in webkit [162616] by dbates@webkit.org
  • 2 edits
    1 add in trunk/Tools

build-webkit --sdk=iphonesimulator doesn't think it's building iOS
https://bugs.webkit.org/show_bug.cgi?id=127379

Reviewed by Simon Fraser.

Teach build-webkit to recognize --sdk=X.

Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).

  • Scripts/webkitdirs.pm:

(checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
(checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().

  • Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
9:23 AM Changeset in webkit [162615] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] Update expected result for test svg/W3C-SVG-1.1/paths-data-03-f.html

The expected result for the test test svg/W3C-SVG-1.1/paths-data-03-f.html on Windows
shows a progression towards matching the Mac expected result. Currently, there are many
numerical differences between the expected results for these platforms, described within
three diff chunks. After this commit there will be a single numerical difference (described
in one diff chunk) between the Mac and Windows results. See <https://bugs.webkit.org/show_bug.cgi?id=127490>
for more details.

  • platform/win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
9:21 AM Changeset in webkit [162614] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

[Win] Update expected result for test svg/W3C-SVG-1.1/paths-data-03-f.html

The expected result for the test test svg/W3C-SVG-1.1/paths-data-03-f.html on Windows
shows a progression towards matching the Mac expected result. Currently, there are many
numerical differences between the expected results for these platforms, described within
three diff chunks. After this commit there will be a single numerical difference (described
in one diff chunk) between the Mac and Windows results. See <https://bugs.webkit.org/show_bug.cgi?id=127490>
for more details.

  • platform/win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
9:19 AM Changeset in webkit [162613] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/Tools

Unreviewed, rolling out r162612.
http://trac.webkit.org/changeset/162612
https://bugs.webkit.org/show_bug.cgi?id=127488

broke the build (Requested by mhahnenberg on #webkit).

  • Scripts/build-jsc:
  • jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
  • jsc-cli/jsc-cli/CLIInstance.h: Removed.
  • jsc-cli/jsc-cli/CLIInstance.m: Removed.
  • jsc-cli/jsc-cli/JSModule.h: Removed.
  • jsc-cli/jsc-cli/JSModule.m: Removed.
  • jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
  • jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
  • jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
  • jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
  • jsc-cli/jsc-cli/RunLoopThread.h: Removed.
  • jsc-cli/jsc-cli/RunLoopThread.m: Removed.
  • jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
  • jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
  • jsc-cli/jsc-cli/main.m: Removed.
9:09 AM Changeset in webkit [162612] by mhahnenberg@apple.com
  • 2 edits
    17 adds in trunk/Tools

Basic framework for a modern jsc CLI
https://bugs.webkit.org/show_bug.cgi?id=127435

Reviewed by Geoffrey Garen.

The most basic components of a modern jsc command line interface consist of the following:

  • A simple REPL to enter commands and receive results
  • The ability to define a module (which consists of various internal methods as well as a set of externally visible methods)
  • The ability to load other modules at runtime
  • The ability to interact with the underlying platform to perform various "privileged" functions (e.g. opening files, printing to the stdout, etc.)

The basic architecture will look something like the following:

  • If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL on the main thread and start a secondary thread with a run loop to handle various inputs from the REPL thread.
  • If the tool is given a script to run, it will evaluate that script (and any scripts that it might transitively load) within the run loop on the secondary thread while the main thread blocks until it has completed.
  • Scripts/build-jsc:
  • jsc-cli: Added.
  • jsc-cli/jsc-cli: Added.
  • jsc-cli/jsc-cli.xcodeproj: Added.
  • jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
  • jsc-cli/jsc-cli/CLIInstance.h: Added.
  • jsc-cli/jsc-cli/CLIInstance.m: Added.

(-[CLIInstance init]):
(-[CLIInstance loadFile:]):
(-[CLIInstance run]):

  • jsc-cli/jsc-cli/JSModule.h: Added.
  • jsc-cli/jsc-cli/JSModule.m: Added.

(coreModules):
(isCoreModule):
(classForModule):
(coreModuleFullPath):
(resolveModuleAsFile):
(resolveModuleAsDirectory):
(nodeModulePaths):
(resolveAsNodeModule):
(+[JSModule resolve:atPath:]):
(globalModuleCache):
(isCached):
(cachedModule):
(cacheModule):
(+[JSModule require:atPath:]):
(+[JSModule require:atPath:inContext:]):
(-[JSModule platformObjectInContext:]):
(-[JSModule initWithId:filename:context:]):
(-[JSModule dealloc]):
(-[JSModule didStartLoading]):
(-[JSModule didFinishLoading]):
(-[JSModule require:]):
(-[JSModule exports]):

  • jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
  • jsc-cli/jsc-cli/JSRunLoopThread.m: Added.

(jsThreadMain):
(+[JSRunLoopThread threadMain]):
(-[JSRunLoopThread initWithFiles:andContext:]):
(-[JSRunLoopThread startRunLoop]):
(-[JSRunLoopThread start]):
(-[JSRunLoopThread join]):
(-[JSRunLoopThread didReceiveInput:]):
(-[JSRunLoopThread performCallback:withError:]):
(-[JSRunLoopThread performCallback:withArguments:]):
(-[JSRunLoopThread didFinishRunLoopInitialization]):

  • jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
  • jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.

(-[ReadEvalPrintLoop initWithJSThread:]):
(prompt):
(escapeStringForOutput):
(-[ReadEvalPrintLoop processNextInput]):
(-[ReadEvalPrintLoop run]):

  • jsc-cli/jsc-cli/RunLoopThread.h: Added.
  • jsc-cli/jsc-cli/RunLoopThread.m: Added.

(+[RunLoopThread threadMain]):
(-[RunLoopThread init]):
(-[RunLoopThread dealloc]):
(-[RunLoopThread didFinishRunLoopInitialization]):
(-[RunLoopThread start]):
(-[RunLoopThread join]):

  • jsc-cli/jsc-cli/ScriptInputSource.h: Added.
  • jsc-cli/jsc-cli/ScriptInputSource.m: Added.

(scriptInputSourceScheduleRoutine):
(scriptInputSourcePerformRoutine):
(scriptInputSourceCancelRoutine):
(-[ScriptInputSource initWithContext:]):
(-[ScriptInputSource dealloc]):
(-[ScriptInputSource addToCurrentRunLoop]):
(-[ScriptInputSource removeFromRemoteRunLoop]):
(-[ScriptInputSource didReceiveScript:]):
(-[ScriptInputSource didReceiveSignal]):
(-[ScriptInputSource runScriptRemotely:]):
(-[ScriptInputSource finishAsyncCallback:withResult:]):

  • jsc-cli/jsc-cli/main.m: Added.

(main):

9:05 AM Changeset in webkit [162611] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed gardening

  • platform/efl-wk2/TestExpectations: Skip failing tests only on WK2.
  • platform/efl/TestExpectations: Unskip now passing tests on WK1.
8:42 AM Changeset in webkit [162610] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix automake warning.

  • GNUmakefile.list.am: Remove trailing whitespaces.
8:04 AM Changeset in webkit [162609] by dbates@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

[Win] Remove Windows-specific result for test fast/css-generated-content/table-row-group-to-inline.html

As of the time of writing, the Windows expected results for test fast/css-generated-content/table-row-group-to-inline.html
are identical to the results on Mac.

  • platform/win/fast/css-generated-content/table-row-group-to-inline-expected.txt: Removed.
8:01 AM Changeset in webkit [162608] by commit-queue@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

[EFL] Updated test expectations for failing tests
https://bugs.webkit.org/show_bug.cgi?id=127478

Unreviewed EFL gardening

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2014-01-23

  • platform/efl/TestExpectations:
  • platform/efl/css2.1/t1604-c542-letter-sp-00-b-a-expected.png:

Removed incorrect test expectation for css2.1/t1604-c542-letter-sp-00-b-a.html

  • platform/efl/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt:

Ditto.

7:50 AM Changeset in webkit [162607] by dbates@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

[Win] Whitespace differences in test results for fast/{css, dom, forms, multicolor, ruinin}
https://bugs.webkit.org/show_bug.cgi?id=127479

Add Windows-specific expected results for some tests that PASS, but differ in whitespace
in their output. We should further investigate such whitespace differences.

  • platform/win/fast/css/first-letter-block-form-controls-crash-expected.txt: Added.
  • platform/win/fast/dom/adopt-node-crash-2-expected.txt: Added.
  • platform/win/fast/forms/access-key-for-all-elements-expected.txt: Added.
  • platform/win/fast/forms/form-associated-element-crash3-expected.txt: Added.
  • platform/win/fast/multicol/renderer-positioned-assert-crash-expected.txt: Added.
  • platform/win/fast/runin/nonblock-runin-expected.txt: Added.
6:57 AM Changeset in webkit [162606] by Michał Pakuła vel Rutka
  • 4 edits in trunk/LayoutTests

Unreviewed EFL gardening

Update test expectations for failing or crashing http/tests/websocket/tests/hybi tests.

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
6:19 AM Changeset in webkit [162605] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

[CSS Regions] Fix positioning composited layers when the region has overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=124042

Patch by Mihai Maerean <Mihai Maerean> on 2014-01-23
Reviewed by Mihnea Ovidenie.

Source/WebCore:

If there's a clipping GraphicsLayer on the hierarchy, substract its offset, since it's its
parent that positions us.

Tests: compositing/regions/position-layer-inside-region-overflow-hidden.html

compositing/regions/position-layer-inside-overflow-hidden.html
compositing/regions/position-layers-inside-region-overflow-hidden.html
compositing/regions/position-layers-inside-regions-overflow-hidden.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): The position
must also be correct when the region has box-shadow that inflates the region's layer. The
composited layers from the flow thread should be rendered in the same position whether the
associated region has clipping or not.
Using the position of the clipping layer instead of the location of the clipbox makes it
also work with box-shadow that inflates the region's graphics layer.

LayoutTests:

  • compositing/regions/position-layer-inside-region-overflow-hidden.html: Added.
  • compositing/regions/position-layer-inside-region-overflow-hidden-expected.html: Added.
  • compositing/regions/position-layer-inside-overflow-hidden.html: Added.
  • compositing/regions/position-layer-inside-overflow-hidden-expected.html: Added.
  • compositing/regions/position-layers-inside-region-overflow-hidden.html: Added.
  • compositing/regions/position-layers-inside-region-overflow-hidden-expected.html: Added.
  • compositing/regions/position-layers-inside-regions-overflow-hidden.html: Added.
  • compositing/regions/position-layers-inside-regions-overflow-hidden-expected.html: Added.
4:38 AM Changeset in webkit [162604] by Csaba Osztrogonác
  • 7 edits in trunk/LayoutTests

Unreviewed gardening.

Move fast/harness/sample-fail-mismatch-reftest.html to the platform
independent TestExpectations, since all ports skip it as expected.

  • TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
2:46 AM Changeset in webkit [162603] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove a FIXME comment that is already fixed.
https://bugs.webkit.org/show_bug.cgi?id=127468

Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-23
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/style/filereader.py:

(TextFileReader.init):

2:02 AM Changeset in webkit [162602] by abucur@adobe.com
  • 7 edits in trunk/Source/WebCore

[CSS Regions] Convert regions iterator loops to range-based loops
https://bugs.webkit.org/show_bug.cgi?id=127464

Reviewed by Antti Koivisto.

Replace most of the iterator loops in the region implementation with
range based for loops. The for loops that iterate only over subsets
of collections have not been changed.

Tests: no new tests, this is a refactoring patch.

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore::WebKitNamedFlow::getRegionsByContent):
(WebCore::WebKitNamedFlow::getRegions):
(WebCore::WebKitNamedFlow::getContent):

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForCSSRegionsHighlight):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::updateLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
(WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):
(WebCore::RenderFlowThread::clearRenderBoxRegionInfoAndCustomStyle):
(WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
(WebCore::RenderFlowThread::markRegionsForOverflowLayoutIfNeeded):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::collectLayerFragments):
(WebCore::RenderFlowThread::fragmentsBoundingBox):

  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::setRegionObjectsRegionStyle):
(WebCore::RenderNamedFlowFragment::restoreRegionObjectsOriginalStyle):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::clearContentElements):
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::RenderNamedFlowThread::computeOversetStateForRegions):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):
(WebCore::RenderNamedFlowThread::pushDependencies):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
(WebCore::isContainedInElements):
(WebCore::RenderNamedFlowThread::getRanges):
(WebCore::RenderNamedFlowThread::checkRegionsWithStyling):
(WebCore::RenderNamedFlowThread::clearRenderObjectCustomStyle):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderRegionList):

12:36 AM Changeset in webkit [162601] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Range should be constructable.
https://bugs.webkit.org/show_bug.cgi?id=115639

Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-23
Reviewed by Ryosuke Niwa.

Source/WebCore:

http://www.w3.org/TR/2013/WD-dom-20131107/#interface-range
Now we can do new Range() instead of document.createRange().

Backported from Blink: https://chromium.googlesource.com/chromium/blink/+/47ca40efdf58a4787aa33aa75a35778899b1c002%5E%21

Test: fast/dom/Range/range-constructor.html

  • dom/Range.cpp:

(WebCore::Range::create):

  • dom/Range.h:
  • dom/Range.idl:

LayoutTests:

  • fast/dom/Range/range-constructor-expected.txt: Added.
  • fast/dom/Range/range-constructor.html: Added.
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
12:10 AM Changeset in webkit [162600] by ChangSeok Oh
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for gles after r162565. Add missing definitions.

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::drawArraysInstanced):
(WebCore::GraphicsContext3D::drawElementsInstanced):
(WebCore::GraphicsContext3D::vertexAttribDivisor):

Note: See TracTimeline for information about the timeline view.