Timeline
Apr 29, 2014:
- 10:52 PM Changeset in webkit [167984] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: reduce per-protocol method function creation in InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=130701
Reviewed by Timothy Hatcher.
Instead of creating 4 bound functions for every backend method on startup, we
can share common functionality on the InspectorBackendCommand prototype. This
also splits the various client-facing protocol introspection mechanisms from
the message encoding/decoding code.
We use a workaround to make the command instances themselves callable as well
as having .invoke, .promise, and .supports. InspectorAgent.methodName returns a
trampoline function that performs the default method invocation. The trampoline's
proto is patched to point to InspectorBackendClass.prototype, and the command
instance is saved in the closure and on the trampoline function itself.
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackendClass.prototype._registerPendingResponse):
(InspectorBackendClass.prototype._invokeMethod):
(InspectorBackendClass.prototype.registerCommand):
(InspectorBackendClass.prototype.registerEvent):
(InspectorBackendCommand):
(.callable):
(InspectorBackendCommand.create):
(InspectorBackendCommand.prototype.invoke):
(InspectorBackendCommand.prototype.promise):
(InspectorBackendCommand.prototype.supports):
(InspectorBackendCommand.prototype._invokeWithArguments):
(InspectorBackendClass.prototype._wrap): Deleted.
(InspectorBackendClass.prototype._invoke): Deleted.
(InspectorBackendClass.prototype._promise): Deleted.
(InspectorBackendClass.prototype._supports): Deleted.
(InspectorBackendClass.prototype._sendMessageToBackend): Deleted.
(InspectorBackendClass.prototype._wrapCallbackAndSendMessageObject): Deleted.
(InspectorBackendClass.prototype.sendMessageObjectToBackend): Deleted.
- 10:42 PM Changeset in webkit [167983] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed, rolling out r167962 and r167975.
https://bugs.webkit.org/show_bug.cgi?id=132376
Mysteriously broke many tests (Requested by ap on #webkit).
Reverted changesets:
"[Mac, iOS] Support caption activation via JS
webkitHasClosedCaptions method"
https://bugs.webkit.org/show_bug.cgi?id=132320
http://trac.webkit.org/changeset/167962
"Unreviewed test fix after r167962."
http://trac.webkit.org/changeset/167975
- 10:15 PM Changeset in webkit [167982] by
-
- 3 edits in trunk/Source/WebCore
[New Multicolumn] Multiple tests assert in RenderGeometryMap
https://bugs.webkit.org/show_bug.cgi?id=132285
Reviewed by Simon Fraser.
Implement offsetFromContainer for RenderMultiColumnFlowThread so that the
geometry map gets the right offsets. This is really only relevant for the
geometry map, since I already overrode mapAbsoluteToLocalPoint and multicolumn
flow threads are repaint containers (so mapLocalToAbsolute never needs offsetFromContainer).
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::offsetFromContainer):
- rendering/RenderMultiColumnFlowThread.h:
- 9:54 PM Changeset in webkit [167981] by
-
- 2 edits in trunk/Tools
<rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
Rubber stamped by Jessie Berlin.
JSON.pm was removed from our tools setup.
- Scripts/generate-coverage-data:
- 9:03 PM Changeset in webkit [167980] by
-
- 4 edits in trunk/Source
[iOS][WK2] When pageScaleFactor * deviceScaleFactor = 1, the tile grid is completely messed up
https://bugs.webkit.org/show_bug.cgi?id=132368
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-29
Reviewed by Simon Fraser.
Source/WebCore:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
The initial device scale factor was initialized to 1. We were returning the wrong zoomedOutContentsScale() and
contentsScale() on retina devices until the next successful scale update.
Source/WebKit2:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::PlatformCALayerRemote):
PlatformCALayerRemote always initialized the content scale to 1. Since contentsScale is supposed to reflect
zoomScale * deviceScaleFactor, the value should be 2.
This was causing bugs whenever the page scale factor was 1/2 on retina device (device scale factor = 2).
When the page is initialized, GraphicsLayerCA::updateContentsScale(0.5) computes a contentsScale of 1. There is an early
return on if (contentsScale == m_layer->contentsScale()). Since PlatformCALayerRemote->contentsScale() was incorreclty
returning one, we were leaving the tile backing unmodified.
Later, when the transaction is commited, the tile backing would still be default initialized and would render everything
at the wrong scale.
- 8:36 PM Changeset in webkit [167979] by
-
- 3 edits in trunk/Source/WebCore
Remove an unused override of BlobRegistryImpl::appendStorageItems
https://bugs.webkit.org/show_bug.cgi?id=132365
Reviewed by Andreas Kling.
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::appendStorageItems): Deleted.
- platform/network/BlobRegistryImpl.h:
- 8:34 PM Changeset in webkit [167978] by
-
- 2 edits in trunk/LayoutTests
Fix test up so that it looks the same as it did before my landing in r167965.
- fast/multicol/mixed-positioning-stacking-order.html:
- 7:52 PM Changeset in webkit [167977] by
-
- 4 edits in trunk/Source
[Mac] tag the video layers with descriptive name to aid debugging
https://bugs.webkit.org/show_bug.cgi?id=132371
Reviewed by Darin Adler.
Source/WebCore:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Set the AVPlayerLayer
name in a debug build.
Source/WebKit2:
- WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::enterFullscreenForNode): Set the
fullscreen host layer name in a debug build.
- 6:53 PM Changeset in webkit [167976] by
-
- 2 edits in trunk/Source/WebCore
[GTK][cmake] CMake variable (non)expansion causing 'File name too long' build error.
https://bugs.webkit.org/show_bug.cgi?id=132244
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2014-04-29
Reviewed by Martin Robinson.
Removing quotes around include directory variable ${WebCore_INCLUDE_DIRECTORIES} in
the include_directories cmake macro enables the variable to be expanded correctly.
No tests created as this fixes a platform specific build issue.
- PlatformGTK.cmake:
- 6:09 PM Changeset in webkit [167975] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed test fix after r167962.
- Modules/mediacontrols/mediaControlsApple.css:
(.hidden): Use common '.hidden' class for controls.
(video::-webkit-media-text-track-container .hidden): Deleted.
- 6:04 PM Changeset in webkit [167974] by
-
- 15 edits in trunk/Source
Handle selection services menu.
<rdar://problem/16727798> and https://bugs.webkit.org/show_bug.cgi?id=132362
Reviewed by Tim Horton.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
Add members for the relevant info for showing a service menu for a selection:
- Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::controlledDataIsEditable):
- Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::controlledSelectionData):
(WebKit::ContextMenuContextData::needsServicesMenu):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::replaceSelectionWithPasteboardData): Changed to allow for multiple types on the overridden pasteboard.
(WebKit::WebPageProxy::showSelectionServiceMenu):
Update the services menu code to know the difference between an image service and a selection service:
- UIProcess/mac/WebContextMenuProxyMac.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKSharingServicePickerDelegate sharingServicePicker:sharingServicesForItems:mask:proposedSharingServices:]):
(-[WKSharingServicePickerDelegate sharingService:willShareItems:]):
(-[WKSharingServicePickerDelegate sharingService:didShareItems:]):
(WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
(WebKit::WebContextMenuProxyMac::clearServicesMenu):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::WebContextMenuProxyMac::setupImageServicesMenu): Deleted.
(WebKit::WebContextMenuProxyMac::clearImageServicesMenu): Deleted.
- WebProcess/WebCoreSupport/WebPasteboardOverrides.cpp:
(WebKit::WebPasteboardOverrides::getDataForOverride):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::replaceSelectionWithPasteboardData): Changed to allow for multiple types on the overridden pasteboard.
(WebKit::WebPage::handleSelectionServiceClick): Pass the relevant selection data through to the UIProcess as RTFD data.
- WebProcess/WebPage/mac/SelectionOverlayControllerMac.mm:
(WebKit::SelectionOverlayController::handleClick): Notify the WebPage of the click.
- 5:36 PM Changeset in webkit [167973] by
-
- 4 edits in trunk/Source/WebCore
Removing unused argument in InlineFlowBox::placeBoxesInInlineDirection()
https://bugs.webkit.org/show_bug.cgi?id=132369
Reviewed by Darin Adler.
This was not caught by our compiler because placeBoxesInInlineDirection()
is mutually-recursive with placeBoxRangeInInlineDirection().
No new tests are necessary because there should be no behavior change.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):
- rendering/InlineFlowBox.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
- 5:34 PM Changeset in webkit [167972] by
-
- 3 edits2 copies in branches/safari-537.76-branch
Merge r160010.
- 5:11 PM Changeset in webkit [167971] by
-
- 9 edits in trunk
[WinCairo] Switch video from GStreamer to Media Foundation.
https://bugs.webkit.org/show_bug.cgi?id=132358
Patch by Alex Christensen <achristensen@webkit.org> on 2014-04-29
Reviewed by Brent Fulgham.
Source/WebCore:
- WebCore.vcxproj/WebCore.vcxproj:
Removed dependencies on GStreamer.
Source/WebKit:
- WebKit.vcxproj/WebKit/WebKit.vcxproj:
Removed dependencies on GStreamer.
Source/WTF:
- WTF.vcxproj/WTF.vcxproj:
Removed dependencies on GStreamer.
- wtf/Platform.h:
Use Media Foundation instead of GStreamer and GLib.
Websites/webkit.org:
- building/tools.html:
Removed requirement of installing GStreamer.
- 4:53 PM Changeset in webkit [167970] by
-
- 4 edits in trunk/Source/WebCore
Remove some PLATFORM(IOS) #ifdefs related to hasAcceleratedTouchScrolling()
https://bugs.webkit.org/show_bug.cgi?id=132353
Reviewed by Tim Horton & Darin Adler.
Minor cleanup and refactoring to remove #idefs.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo): No need for this #ifdef, usesCompositedScrolling()
gives the right answser already.
(WebCore::RenderLayer::visibleContentRectInternal): Use showsOverflowControls() to
avoid #ifdef.
(WebCore::RenderLayer::invalidateScrollbarRect): Ditto.
(WebCore::RenderLayer::invalidateScrollCornerRect): Ditto.
(WebCore::RenderLayer::verticalScrollbarWidth): Ditto.
(WebCore::RenderLayer::horizontalScrollbarHeight): Ditto.
(WebCore::RenderLayer::showsOverflowControls): Return false on iOS.
(WebCore::RenderLayer::paintOverflowControls): Ditto.
(WebCore::RenderLayer::calculateClipRects): Ditto.
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling):
Just #ifdef in side of this function rather than having two similar functions.
(WebCore::RenderLayerBacking::shouldClipCompositedBounds):
(WebCore::hasNonZeroTransformOrigin):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Use a local bool
to reduce #ifdefs.
(WebCore::layerOrAncestorIsTransformedOrScrolling): Deleted.
- 4:53 PM Changeset in webkit [167969] by
-
- 6 edits2 deletes in trunk
Remove Settings::compositedScrollingForFramesEnabled
https://bugs.webkit.org/show_bug.cgi?id=132352
Reviewed by Andreas Kling.
Source/WebCore:
The usesCompositedScrolling setting was only used by Chromium, so
remove it and associated code.
- page/FrameView.cpp:
(WebCore::FrameView::usesCompositedScrolling): Deleted.
- page/FrameView.h:
- page/Settings.in:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollLayerPosition):
LayoutTests:
- compositing/iframes/iframe-composited-scrolling-expected.txt: Removed.
- compositing/iframes/iframe-composited-scrolling.html: Removed.
- 4:40 PM Changeset in webkit [167968] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/16745596> [Cocoa] Crash when invoking a method with an unsigned parameter on a remote object
https://bugs.webkit.org/show_bug.cgi?id=132366
Reviewed by Anders Carlsson.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeInvocation): Handle the 'I' type code. Interpret the 'q' and 'Q' type codes in an
architecture-independent manner.
(decodeInvocationArguments): Ditto.
- 4:34 PM Changeset in webkit [167967] by
-
- 5 edits in trunk/Source/WebCore
Move removeEquivalentProperties functions to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=131093
Patch by Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> on 2014-04-29
Reviewed by Darin Adler.
Moved the removeEquivalentProperties functions
from StyleProperties to EditingStyle class.
- css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::removeEquivalentProperties): Deleted.
- css/StyleProperties.h:
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::removeEquivalentProperties):
(WebCore::extractPropertiesNotIn):
- editing/EditingStyle.h:
- 4:20 PM Changeset in webkit [167966] by
-
- 7 edits4 deletes in tags/Safari-538.32
Rollout r167889
- 3:59 PM Changeset in webkit [167965] by
-
- 94 edits in trunk
[New Multicolumn] Implement support for compositing
https://bugs.webkit.org/show_bug.cgi?id=132298
Source/WebCore:
Reviewed by Simon Fraser.
- rendering/RenderLayer.cpp:
(WebCore::accumulateOffsetTowardsAncestor):
Add in a case for the new columns that calls into the multi-column flow thread
to get an offset to adjust by.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread):
Make sure this code only runs for named flow threads.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::canBeComposited):
Turn on compositing support for in-flow RenderFlowThreads instead of always returning
false
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::physicalTranslationOffsetFromFlowToRegion):
Changed this function to fix a couple of bugs exposed by compositing/columns tests. Its
end goal is the same, but the approach is improved.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::endFlow):
Don't pad out to a multiple of column height. You can't flip around a flow thread
to get back to accurate physical coordinates if bogus padding is introduced. This
seemed to have no effect on any layout tests when removed, so I don't think it
was really serving any useful purpose.
(WebCore::RenderMultiColumnSet::columnTranslationForOffset):
Don't factor in the overall flow thread portion, since this is handled by the callers
now.
(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):
- rendering/RenderMultiColumnSet.h:
Change this function to be ASSERT_NOT_REACHED(), since we want to know if someone calls
it. It only runs for named flow thread compositing code, so it would be a mistake if
this ever gets invoked.
LayoutTests:
Reviewed by Simon Fraser.
Minor pixel test changes based off how we flip now.
- platform/mac/fast/multicol/block-axis-horizontal-bt-expected.png:
- platform/mac/fast/multicol/block-axis-horizontal-tb-expected.png:
- platform/mac/fast/multicol/block-axis-vertical-lr-expected.png:
- platform/mac/fast/multicol/block-axis-vertical-rl-expected.png:
- platform/mac/fast/multicol/border-padding-pagination-expected.png:
- platform/mac/fast/multicol/client-rects-spanners-complex-expected.txt:
- platform/mac/fast/multicol/client-rects-spanners-expected.txt:
- platform/mac/fast/multicol/column-break-with-balancing-expected.png:
- platform/mac/fast/multicol/column-count-with-rules-expected.png:
- platform/mac/fast/multicol/column-rules-expected.png:
- platform/mac/fast/multicol/column-rules-stacking-expected.png:
- platform/mac/fast/multicol/columns-shorthand-parsing-expected.png:
- platform/mac/fast/multicol/float-avoidance-expected.png:
- platform/mac/fast/multicol/float-multicol-expected.png:
- platform/mac/fast/multicol/float-paginate-complex-expected.png:
- platform/mac/fast/multicol/float-paginate-empty-lines-expected.png:
- platform/mac/fast/multicol/float-paginate-expected.png:
- platform/mac/fast/multicol/layers-in-multicol-expected.png:
- platform/mac/fast/multicol/layers-split-across-columns-expected.png:
- platform/mac/fast/multicol/margin-collapse-expected.png:
- platform/mac/fast/multicol/max-height-columns-block-expected.png:
- platform/mac/fast/multicol/nested-columns-expected.png:
- platform/mac/fast/multicol/newmulticol/client-rects-expected.txt:
- platform/mac/fast/multicol/overflow-across-columns-expected.png:
- platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.png:
- platform/mac/fast/multicol/overflow-unsplittable-expected.png:
- platform/mac/fast/multicol/paginate-block-replaced-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-bt-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-lr-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-rl-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-tb-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-bt-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-lr-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-tb-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-bt-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-lr-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-rl-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-tb-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-lr-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-rl-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-tb-expected.png:
- platform/mac/fast/multicol/positioned-split-expected.png:
- platform/mac/fast/multicol/positive-leading-expected.png:
- platform/mac/fast/multicol/scrolling-overflow-expected.png:
- platform/mac/fast/multicol/shadow-breaking-expected.png:
- platform/mac/fast/multicol/single-line-expected.png:
- platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
- platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
- platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.png:
- platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt:
- platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
- platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
- platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
- platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.png:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
- platform/mac/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
- platform/mac/fast/multicol/span/span-margin-collapsing-expected.png:
- platform/mac/fast/multicol/table-margin-collapse-expected.png:
- platform/mac/fast/multicol/table-vertical-align-expected.png:
- platform/mac/fast/multicol/unsplittable-inline-block-expected.png:
- platform/mac/fast/multicol/vertical-lr/border-padding-pagination-expected.png:
- platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
- platform/mac/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
- platform/mac/fast/multicol/vertical-lr/column-rules-expected.png:
- platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
- platform/mac/fast/multicol/vertical-lr/float-multicol-expected.png:
- platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
- platform/mac/fast/multicol/vertical-lr/float-paginate-expected.png:
- platform/mac/fast/multicol/vertical-lr/nested-columns-expected.png:
- platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
- platform/mac/fast/multicol/vertical-rl/border-padding-pagination-expected.png:
- platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
- platform/mac/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
- platform/mac/fast/multicol/vertical-rl/column-rules-expected.png:
- platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
- platform/mac/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
- platform/mac/fast/multicol/vertical-rl/float-paginate-expected.png:
- platform/mac/fast/multicol/vertical-rl/nested-columns-expected.png:
- platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
- 3:31 PM FTLJIT edited by
- (diff)
- 3:23 PM Changeset in webkit [167964] by
-
- 11 edits in trunk
Source/JavaScriptCore: Don't hold on to parameterBindingNodes forever
https://bugs.webkit.org/show_bug.cgi?id=132360
Reviewed by Geoffrey Garen.
Don't keep the parameter nodes anymore. Instead we store the
original parameter string and reparse whenever we actually
need them. Because we only actually need them for compilation
this only results in a single extra parse.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::UnlinkedFunctionExecutable::visitChildren):
(JSC::UnlinkedFunctionExecutable::finishCreation):
(JSC::UnlinkedFunctionExecutable::paramString):
(JSC::UnlinkedFunctionExecutable::parameters):
(JSC::UnlinkedFunctionExecutable::parameterCount): Deleted.
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedFunctionExecutable::create):
(JSC::UnlinkedFunctionExecutable::parameterCount):
(JSC::UnlinkedFunctionExecutable::parameters): Deleted.
(JSC::UnlinkedFunctionExecutable::finishCreation): Deleted.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::setFunctionBodyParameters):
- parser/Nodes.h:
(JSC::FunctionBodyNode::parametersStartOffset):
(JSC::FunctionBodyNode::parametersEndOffset):
(JSC::FunctionBodyNode::setParameterLocation):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::parseParameters):
- parser/Parser.h:
(JSC::parse):
- parser/SourceCode.h:
(JSC::SourceCode::subExpression):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::setFunctionBodyParameters):
LayoutTests: Don't hold on to parameter BindingNodes forever
https://bugs.webkit.org/show_bug.cgi?id=132360
Reviewed by Geoffrey Garen.
We don't regenerate the parameter string anymore, so these tests now
match the original input.
- js/destructuring-assignment-expected.txt:
- 3:21 PM Changeset in webkit [167963] by
-
- 12 edits1 add in trunk/Source
JSProxies should be cacheable
https://bugs.webkit.org/show_bug.cgi?id=132351
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Whenever we encounter a proxy in an inline cache we should try to cache on the
proxy's target instead of giving up.
This patch adds support for a simple "recursive" inline cache if the base object
we're accessing is a pure forwarding proxy. JSGlobalObject and its subclasses
are the only ones to benefit from this right now.
This is performance neutral on the benchmarks we track. Currently we won't
cache on JSDOMWindow due to HasImpureGetOwnPropertySlot, but this issue will be fixed soon.
- jit/Repatch.cpp:
(JSC::generateByIdStub):
(JSC::tryBuildGetByIDList):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionCreateProxy):
- runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::isNormalized):
- runtime/JSCellInlines.h:
(JSC::JSCell::isProxy):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::finishCreation):
- runtime/JSProxy.h:
(JSC::JSProxy::createStructure):
(JSC::JSProxy::targetOffset):
- runtime/JSType.h:
- runtime/Operations.h:
(JSC::isPrototypeChainNormalized):
- runtime/Structure.h:
(JSC::Structure::isProxy):
- tests/stress/proxy-inline-cache.js: Added.
(cacheOnTarget.getX):
(cacheOnTarget):
(cacheOnPrototypeOfTarget.getX):
(cacheOnPrototypeOfTarget):
(dontCacheOnProxyInPrototypeChain.getX):
(dontCacheOnProxyInPrototypeChain):
(dontCacheOnTargetOfProxyInPrototypeChainOfTarget.getX):
(dontCacheOnTargetOfProxyInPrototypeChainOfTarget):
Source/WebCore:
No new tests.
Whenever we encounter a proxy in an inline cache we should try to cache on the
proxy's target instead of giving up.
This patch adds support for a simple "recursive" inline cache if the base object
we're accessing is a pure forwarding proxy. JSGlobalObject and its subclasses
are the only ones to benefit from this right now.
This is performance neutral on the benchmarks we track. Currently we won't
cache on JSDOMWindow due to HasImpureGetOwnPropertySlot, but this issue will be fixed soon.
- bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::createStructure):
- 3:19 PM Changeset in webkit [167962] by
-
- 6 edits in trunk/Source/WebCore
[Mac, iOS] Support caption activation via JS webkitHasClosedCaptions method
https://bugs.webkit.org/show_bug.cgi?id=132320
Reviewed by Eric Carlson.
- Modules/mediacontrols/mediaControlsApple.css:
(video::-webkit-media-text-track-container .hidden): Added.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackGroup): Added call to
new 'updateCaptionsContainer'.
(WebCore::HTMLMediaElement::updateCaptionContainer): Added.
- html/HTMLMediaElement.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::hide): Use CSS class .hidden instead of
hard-coded "display:none".
(WebCore::MediaControlTextTrackContainerElement::show): Ditto.
- html/shadow/MediaControlElements.h:
- 3:14 PM Changeset in webkit [167961] by
-
- 2 edits in trunk/Source/WebKit2
Don't immediately snapshot plugin to allow for proper dominant plugin detection.
https://bugs.webkit.org/show_bug.cgi?id=132294.
<rdar://problem/16745679>
Reviewed by Dean Jackson.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin):
Instead of immediately setting the display state to DisplaySnapshot,
put it on a timer to let the page fully layout and get hit test properly.
- 3:10 PM Changeset in webkit [167960] by
-
- 5 edits6 adds in trunk
Plugins hidden by images should autoplay.
https://bugs.webkit.org/show_bug.cgi?id=132222.
<rdar://problem/16653536>
Reviewed by Jon Lee and Darin Adler.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
If the image on top of the plugin is similarly sized and similarly positioned as the plugin rect,
set the plugin to autoplay. This is assuming that the previous snapshot checks have passed as well.
- WebCore.exp.in: Add exports needed by WK2.
- platform/mac-wk2/plugins/snapshotting/autoplay-plugin-blocked-by-image-expected.txt: Added.
- platform/mac-wk2/plugins/snapshotting/autoplay-plugin-mostly-blocked-by-image-expected.txt: Added.
- platform/mac-wk2/plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image-expected.txt: Added.
- plugins/snapshotting/autoplay-plugin-blocked-by-image.html: Added.
- plugins/snapshotting/autoplay-plugin-mostly-blocked-by-image.html: Added.
- plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html: Added.
- 3:07 PM Changeset in webkit [167959] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, fix cloop build.
- wtf/Platform.h:
- 3:02 PM Changeset in webkit [167958] by
-
- 12 edits in trunk
Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
https://bugs.webkit.org/show_bug.cgi?id=112840
Rubber stamped by Geoffrey Garen.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
It already has a lot of tests.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/build-jsc: Enable it on Mac.
- Scripts/build-webkit: Enable it on Mac.
- Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
- 2:58 PM Changeset in webkit [167957] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py
Fix check-webkit-style after r167926.
- 2:54 PM Changeset in webkit [167956] by
-
- 21 edits2 adds in trunk/Source
Change Image Controls replacement to use selection and paste
<rdar://problem/16302722> and https://bugs.webkit.org/show_bug.cgi?id=131992
Reviewed by Tim Horton.
Source/WebCore:
- WebCore.exp.in: Remove deleted symbol.
- html/shadow/mac/ImageControlsButtonElementMac.cpp:
(WebCore::ImageControlsButtonElementMac::defaultEventHandler):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showImageControlsMenu): Select the image element
before showing the menu.
(WebCore::ContextMenuController::replaceControlledImage): Deleted.
- page/ContextMenuController.h:
Source/WebKit/mac:
- Misc/WebSharingServicePickerController.mm:
(-[WebSharingServicePickerController sharingService:didShareItems:]): Write the
replacement data to a special pasteboard, then replace the current selection from
that pasteboard.
Source/WebKit2:
Add a "pasteboard override" mechanism which allows WebKit to keep pasteboard content local
to the WebProcess and access it there without having to message up to the UI process:
- WebProcess/WebCoreSupport/WebPasteboardOverrides.cpp: Added.
(WebKit::WebPasteboardOverrides::sharedPasteboardOverrides):
(WebKit::WebPasteboardOverrides::WebPasteboardOverrides):
(WebKit::WebPasteboardOverrides::addOverride):
(WebKit::WebPasteboardOverrides::removeOverride):
(WebKit::WebPasteboardOverrides::overriddenTypes):
(WebKit::WebPasteboardOverrides::getDataForOverride):
- WebProcess/WebCoreSupport/WebPasteboardOverrides.h: Added.
Change the pasteboard strategy to consult the pasteboard overrides before consulting the native pasteboard:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
Add "replaceSelectionWithPasteboardData" which uses the new pasteboard overrides mechanism
and then has WebCore perform the replacement:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::replaceSelectionPasteboardName):
(WebKit::WebPage::replaceSelectionWithPasteboardData):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::replaceSelectionWithPasteboardData):
- UIProcess/mac/WebContextMenuProxyMac.h:
(WebKit::WebContextMenuProxyMac::page):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKSharingServicePickerDelegate sharingService:didShareItems:]): Use "replaceSelectionWithPasteboardData".
(WebKit::WebContextMenuProxyMac::WebContextMenuProxyMac):
(WebKit::WebContextMenuProxyMac::replaceControlledImage): Deleted.
Remain other remnants of "replaceControlledImage":
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::replaceControlledImage): Deleted.
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::replaceControlledImage): Deleted.
- WebProcess/WebPage/WebContextMenu.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::replaceControlledImage): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- 1:51 PM Changeset in webkit [167955] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: DataGrid columns should be objects not Maps
https://bugs.webkit.org/show_bug.cgi?id=129383
Reviewed by Timothy Hatcher.
This reverts an earlier conversion to maps, so that column properties
(which rarely change) can be optimized.
String literals for column properties have been preserved so columns
can be easily converted into objects with methods.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.autoSizeColumns):
(WebInspector.DataGrid.prototype.set var):
(WebInspector.DataGrid.prototype.set if):
(WebInspector.DataGrid.prototype.insertColumn):
(WebInspector.DataGrid.prototype.removeColumn.get this):
(WebInspector.DataGrid.prototype.removeColumn):
(WebInspector.DataGrid.prototype.columnWidthsMap):
(WebInspector.DataGrid.prototype.applyColumnWidthsMap):
(WebInspector.DataGrid.prototype._collapseColumnGroupWithCell):
(WebInspector.DataGridNode.prototype.createCell.get if):
(WebInspector.DataGridNode.prototype.createCell):
(WebInspector.DataGrid.prototype.get length): Deleted.
- UserInterface/Views/ProbeSetDataGrid.js:
(WebInspector.ProbeSetDataGrid.prototype._probeExpressionChanged.get this):
(WebInspector.ProbeSetDataGrid.prototype._probeExpressionChanged):
- UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters.scopeBar.this.columns.get string_appeared_here):
(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters):
- 1:33 PM Changeset in webkit [167954] by
-
- 4 edits in trunk/LayoutTests
REGRESSION (r167906?): js/dom/basic-weakmap.html is much more flaky than before
<https://webkit.org/b/132322>
Remove the part of js/dom/basic-weakmap.html that expects deterministic behavior
from our non-deterministic GC.
Rubber-stamped by Phil Pizlo.
- TestExpectations:
- js/dom/basic-weakmap-expected.txt:
- js/dom/script-tests/basic-weakmap.js:
- 1:28 PM Changeset in webkit [167953] by
-
- 2 edits in trunk/Source/WTF
For DARWIN platforms, use system temporary directory for DataLog output
https://bugs.webkit.org/show_bug.cgi?id=132346
Reviewed by Geoffrey Garen.
Added code to call confstr() to access the process's temporary directory to use that
location instead of /tmp/. Put the code behind #ifdef DATA_LOG_TO_DARWIN_TEMP_DIR.
- wtf/DataLog.cpp:
(WTF::initializeLogFileOnce):
- 1:25 PM Changeset in webkit [167952] by
-
- 8 edits2 copies in tags/Safari-538.32
Merged r167942.
- 12:47 PM Changeset in webkit [167951] by
-
- 5 edits in trunk
String.prototype.trim removes U+200B from strings.
https://bugs.webkit.org/show_bug.cgi?id=130184
Reviewed by Michael Saboff.
Source/JavaScriptCore:
- runtime/StringPrototype.cpp:
(JSC::trimString):
(JSC::isTrimWhitespace): Deleted.
LayoutTests:
- js/script-tests/string-trim.js:
- js/string-trim-expected.txt:
- 12:23 PM Changeset in webkit [167950] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: Intermittent crash in SpeechSynthesis::didFinishSpeaking
https://bugs.webkit.org/show_bug.cgi?id=111613
<rdar://problem/13407093>
- platform/mac/TestExpectations: Remove test expectation, now that the bug is fixed.
- 11:56 AM Changeset in webkit [167949] by
-
- 2 edits in trunk/Source/WebKit2
Build fix.
- DatabaseProcess/ios/DatabaseProcessIOS.mm:
- 11:20 AM Changeset in webkit [167948] by
-
- 4 edits in trunk/Source/JavaScriptCore
Zombifying sweep should ignore retired blocks.
<https://webkit.org/b/132344>
Reviewed by Mark Hahnenberg.
By definition, retired blocks do not have "dead" objects, or at least
none that we know of yet until the next marking phase has been run
over it. So, we should not be sweeping them (even for zombie mode).
- heap/Heap.cpp:
(JSC::Heap::zombifyDeadObjects):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::zombifySweep):
- heap/MarkedSpace.h:
(JSC::ZombifySweep::operator()):
- 11:09 AM Changeset in webkit [167947] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r167906?): js/dom/basic-weakmap.html is much more flaky than before
https://bugs.webkit.org/show_bug.cgi?id=132322
Mark the test as flaky.
- 10:54 AM Changeset in webkit [167946] by
-
- 10 edits1 copy2 adds in trunk/Source/WebKit2
[WK2] DatabaseProcess should be sandboxed
https://bugs.webkit.org/show_bug.cgi?id=132324
<rdar://problem/15961708>
Reviewed by Darin Adler.
- Configurations/WebKit2.xcconfig: Added the profile to the list of files skipped
on iOS.
- DatabaseProcess/DatabaseProcess.cpp: (WebKit::DatabaseProcess::initializeDatabaseProcess):
Consume a sandbox extension for IndexedDB directory (which we get with initialization
message after entering sandbox).
- DatabaseProcess/ios: Added.
- DatabaseProcess/ios/DatabaseProcessIOS.mm: Copied from Source/WebKit2/DatabaseProcess/mac/DatabaseProcessMac.mm.
Separated from Mac version to match how other processes are implemented.
- DatabaseProcess/mac/DatabaseProcessMac.mm: (WebKit::DatabaseProcess::initializeProcessName):
Removed ifdefs.
- DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in: Added.
- DerivedSources.make: Generate the profile from .sb.in.
- Shared/Databases/DatabaseProcessCreationParameters.cpp:
(WebKit::DatabaseProcessCreationParameters::encode):
(WebKit::DatabaseProcessCreationParameters::decode):
- Shared/Databases/DatabaseProcessCreationParameters.h:
Added a sandbox extension for indexedDatabaseDirectory.
- Shared/SecurityOriginData.h: Added an unrelated FIXME.
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureDatabaseProcess): Create
a sandbox extension for indexedDatabaseDirectory.
- WebKit2.xcodeproj/project.pbxproj: Added new files.
- 10:45 AM Changeset in webkit [167945] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix bit rot in zombie mode heap code.
<https://webkit.org/b/132342>
Reviewed by Mark Hahnenberg.
Need to enter a DelayedReleaseScope before doing a sweep.
- heap/Heap.cpp:
(JSC::Heap::zombifyDeadObjects):
- 10:42 AM Changeset in webkit [167944] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Remove workaround for <rdar://problem/16578727>.
https://bugs.webkit.org/show_bug.cgi?id=132338
Reviewed by Darin Adler.
Now that <rdar://problem/16578727> is fixed, remove the workaround by replacing the
call to -_updatePlaybackControlsViewController with one to -layoutIfNeeded.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
- 10:41 AM Changeset in webkit [167943] by
-
- 36 edits in trunk/Source/WebCore
ScriptExecutionContext::Task should work well with C++11 lambdas
https://bugs.webkit.org/show_bug.cgi?id=129795
Reviewed by Darin Adler.
Instead of having classes that subclass ScriptExecutionContext::Task and override
the performTask(ScriptExecutionContext*) method, have the ScriptExecutionContext::Task
take in a std::function<void (ScriptExecutionContext*)>-like object trough the constructor
which would contain the code currently kept in the performTask() methods.
This enables inlining C++11 lambdas into ScriptExecutionContext::postTask() calls. For
cleanup tasks, the Task object can be implicitly constructed by using the initializer list
constructor with the first argument being the ScriptExecutionContext::Task::CleanupTask tag.
The ScriptExecutionContext class remains non-copyable and now stores the passed-in invokable
object in the std::function wrapper, along with a boolean member that indicates whether the
task is of cleanup nature.
- Modules/quota/StorageErrorCallback.cpp:
(WebCore::StorageErrorCallback::CallbackTask::CallbackTask):
(WebCore::StorageErrorCallback::CallbackTask::performTask): Deleted.
- Modules/quota/StorageErrorCallback.h:
(WebCore::StorageErrorCallback::CallbackTask::create): Deleted.
- Modules/webdatabase/Database.cpp:
(WebCore::Database::~Database):
(WebCore::Database::runTransaction):
(WebCore::Database::scheduleTransactionCallback):
(WebCore::DerefContextTask::create): Deleted.
(WebCore::DerefContextTask::performTask): Deleted.
(WebCore::DerefContextTask::isCleanupTask): Deleted.
(WebCore::DerefContextTask::DerefContextTask): Deleted.
(WebCore::callTransactionErrorCallback): Deleted.
(WebCore::DeliverPendingCallbackTask::create): Deleted.
(WebCore::DeliverPendingCallbackTask::performTask): Deleted.
(WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask): Deleted.
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseCreationCallbackTask::create): Deleted.
(WebCore::DatabaseCreationCallbackTask::performTask): Deleted.
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask): Deleted.
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::CloseSyncDatabaseOnContextThreadTask::create): Deleted.
(WebCore::CloseSyncDatabaseOnContextThreadTask::performTask): Deleted.
(WebCore::CloseSyncDatabaseOnContextThreadTask::CloseSyncDatabaseOnContextThreadTask): Deleted.
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::create): Deleted.
(WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask): Deleted.
(WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask): Deleted.
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask): Deleted.
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::create): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::~WorkerGlobalScopeDidInitializeTask): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask): Deleted.
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
- bindings/js/JSCallbackData.h:
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
(WebCore::DeleteCallbackDataTask::create): Deleted.
(WebCore::DeleteCallbackDataTask::performTask): Deleted.
(WebCore::DeleteCallbackDataTask::isCleanupTask): Deleted.
- bindings/js/JSDOMGlobalObjectTask.cpp:
(WebCore::JSGlobalObjectTask::JSGlobalObjectTask):
(WebCore::JSGlobalObjectTask::~JSGlobalObjectTask): Deleted.
(WebCore::JSGlobalObjectTask::performTask): Deleted.
- bindings/js/JSDOMGlobalObjectTask.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::~JSTestCallback):
(GenerateCallbackImplementation):
- dom/CrossThreadTask.h:
(WebCore::CrossThreadTask1::performTask):
(WebCore::CrossThreadTask2::performTask):
(WebCore::CrossThreadTask3::performTask):
(WebCore::CrossThreadTask4::performTask):
(WebCore::CrossThreadTask5::performTask):
(WebCore::CrossThreadTask6::performTask):
(WebCore::CrossThreadTask7::performTask):
(WebCore::CrossThreadTask8::performTask):
(WebCore::createCallbackTask):
(WebCore::CrossThreadTask1::create): Deleted.
(WebCore::CrossThreadTask2::create): Deleted.
(WebCore::CrossThreadTask3::create): Deleted.
(WebCore::CrossThreadTask4::create): Deleted.
(WebCore::CrossThreadTask5::create): Deleted.
(WebCore::CrossThreadTask6::create): Deleted.
(WebCore::CrossThreadTask7::create): Deleted.
(WebCore::CrossThreadTask8::create): Deleted.
- dom/Document.cpp:
(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::PerformTaskContext::PerformTaskContext): Deleted.
(WebCore::Document::didReceiveTask): Deleted.
- dom/Document.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):
(WebCore::ScriptExecutionContext::timerAlignmentInterval):
(WebCore::ProcessMessagesSoonTask::create): Deleted.
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask): Deleted.
(WebCore::ScriptExecutionContext::Task::~Task): Deleted.
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::Task::Task):
(WebCore::ScriptExecutionContext::Task::performTask):
(WebCore::ScriptExecutionContext::Task::isCleanupTask):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create): Deleted.
- dom/StringCallback.cpp:
(WebCore::StringCallback::scheduleCallback):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::postListenerTask):
(WebCore::CallCacheListenerTask::create): Deleted.
(WebCore::CallCacheListenerTask::CallCacheListenerTask): Deleted.
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):
(WebCore::SharedWorkerConnectTask::create): Deleted.
(WebCore::SharedWorkerConnectTask::performTask): Deleted.
- workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::EventDispatcher::EventDispatcher):
(WebCore::WorkerEventQueue::EventDispatcher::~EventDispatcher):
(WebCore::WorkerEventQueue::EventDispatcher::dispatch):
(WebCore::WorkerEventQueue::enqueueEvent):
(WebCore::WorkerEventQueue::cancelEvent):
(WebCore::WorkerEventQueue::close):
- workers/WorkerEventQueue.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
(WebCore::CloseWorkerGlobalScopeTask::create): Deleted.
(WebCore::CloseWorkerGlobalScopeTask::performTask): Deleted.
(WebCore::CloseWorkerGlobalScopeTask::isCleanupTask): Deleted.
- workers/WorkerGlobalScope.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):
(WebCore::MessageWorkerGlobalScopeTask::create): Deleted.
(WebCore::MessageWorkerGlobalScopeTask::MessageWorkerGlobalScopeTask): Deleted.
(WebCore::MessageWorkerGlobalScopeTask::performTask): Deleted.
(WebCore::MessageWorkerTask::create): Deleted.
(WebCore::MessageWorkerTask::MessageWorkerTask): Deleted.
(WebCore::MessageWorkerTask::performTask): Deleted.
(WebCore::WorkerExceptionTask::create): Deleted.
(WebCore::WorkerExceptionTask::WorkerExceptionTask): Deleted.
(WebCore::WorkerExceptionTask::performTask): Deleted.
(WebCore::WorkerGlobalScopeDestroyedTask::create): Deleted.
(WebCore::WorkerGlobalScopeDestroyedTask::WorkerGlobalScopeDestroyedTask): Deleted.
(WebCore::WorkerGlobalScopeDestroyedTask::performTask): Deleted.
(WebCore::WorkerTerminateTask::create): Deleted.
(WebCore::WorkerTerminateTask::WorkerTerminateTask): Deleted.
(WebCore::WorkerTerminateTask::performTask): Deleted.
(WebCore::WorkerThreadActivityReportTask::create): Deleted.
(WebCore::WorkerThreadActivityReportTask::WorkerThreadActivityReportTask): Deleted.
(WebCore::WorkerThreadActivityReportTask::performTask): Deleted.
(WebCore::PostMessageToPageInspectorTask::create): Deleted.
(WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask): Deleted.
(WebCore::PostMessageToPageInspectorTask::performTask): Deleted.
(WebCore::NotifyNetworkStateChangeTask::create): Deleted.
(WebCore::NotifyNetworkStateChangeTask::NotifyNetworkStateChangeTask): Deleted.
(WebCore::NotifyNetworkStateChangeTask::performTask): Deleted.
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::performTask):
(WebCore::WorkerRunLoop::Task::Task):
- workers/WorkerRunLoop.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):
(WebCore::WorkerThreadShutdownFinishTask::create): Deleted.
(WebCore::WorkerThreadShutdownFinishTask::performTask): Deleted.
(WebCore::WorkerThreadShutdownFinishTask::isCleanupTask): Deleted.
(WebCore::WorkerThreadShutdownStartTask::create): Deleted.
(WebCore::WorkerThreadShutdownStartTask::performTask): Deleted.
(WebCore::WorkerThreadShutdownStartTask::isCleanupTask): Deleted.
- 10:34 AM Changeset in webkit [167942] by
-
- 8 edits2 adds in trunk
REGRESSION (r167879): Heap-use-after-free in WebCore::RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=132337
Reviewed by Simon Fraser.
From Blink r154582 by <jchaffraix@chromium.org>
Source/WebCore:
This is a regression from the changes in OrderIterator. The issue is
that we don't invalidate our iterator when a child is removed. This
means that we could hold onto free'd memory until the next layout
when we will recompute the iterator.
The solution is simple: just clear the memory when we remove a child.
Note that RenderGrid is not impacted by this bug as we don't use the
iterator outside layout yet, but if we do it at some point the very same
problem will arise, so the same treatment was applied to the class.
Test: fast/flexbox/order-iterator-crash.html
- rendering/OrderIterator.cpp:
(WebCore::OrderIterator::invalidate): Clear m_children Vector.
- rendering/OrderIterator.h:
(WebCore::OrderIteratorPopulator::OrderIteratorPopulator): Use
invalidate() method.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::removeChild): Invalidate m_orderIterator.
- rendering/RenderFlexibleBox.h: Add removeChild() signature.
- rendering/RenderGrid.cpp: Invalidate m_orderIterator.
(WebCore::RenderGrid::removeChild):
- rendering/RenderGrid.h: Add removeChild() header.
LayoutTests:
Add new layout test to check that removing a child doesn't cause a crash
in OrderIterator.
- fast/flexbox/order-iterator-crash-expected.txt: Added.
- fast/flexbox/order-iterator-crash.html: Added.
- 10:28 AM Changeset in webkit [167941] by
-
- 2 edits in trunk/Source/WebCore
iOS build fix after http://trac.webkit.org/changeset/167937.
Unreviewed.
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustButtonStyle):
- 9:56 AM Changeset in webkit [167940] by
-
- 9 edits in trunk/Source/WebKit2
[iOS] Introduce -didNotHandleTapAsClickAtPoint: to WKUIDelegatePrivate
https://bugs.webkit.org/show_bug.cgi?id=132316
Reviewed by Darin Adler.
One WebKit2 client is interested to know if a tap was not handled by an element that responds to clicks.
Introduce a new, private WKUIDelegate method telling it that a tap at a location was not handled as a click on
an element.
- UIProcess/API/APIUIClient.h:
(API::UIClient::didNotHandleTapAsClick):
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didNotHandleTapAsClick):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didNotHandleTapAsClick):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleTap): Sent Messages::WebPageProxy::DidNotHandleTapAsClick if the tap wasn't handled, no
node responded to the click event, or the responding node wasn't an element.
- 9:50 AM Changeset in webkit [167939] by
-
- 2 edits in trunk/Tools
REGRESSION (r167751): svn-create-patch is very slow
https://bugs.webkit.org/show_bug.cgi?id=132300
Reviewed by Alexey Proskuryakov.
- Scripts/svn-create-patch:
Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
by callingsvn-create-patch --style.
- 9:40 AM Changeset in webkit [167938] by
-
- 6 edits in trunk
[CSS Shapes] off-by-one error in Shape::createRasterShape()
https://bugs.webkit.org/show_bug.cgi?id=132154
Reviewed by Bem Jones-Bey.
Source/WebCore:
This is a port of a patch for a bug that was reported by and fixed in Blink by
David Vest: https://codereview.chromium.org/237123002/. Shape::createRasterShape()
now consistently reports "end-point exclusive" intervals. Before the patch
an entire row of pixels was above the shape-image-threshold, the interval's end
index was reported as image.width. Now it's image.width + 1, which is consistent
with the way the end index is reported if the last above threshold pixel is within
an image row.
Two existing tests were revised to account for this change.
- rendering/shapes/RasterShape.cpp:
(WebCore::RasterShape::getExcludedIntervals):
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createRasterShape):
LayoutTests:
Change two tests that had incorrect X values to account for the off-by-one
in Shape::createRasterShape().
- fast/shapes/shape-outside-floats/shape-outside-insert-svg-shape.html:
- fast/shapes/shape-outside-floats/shape-outside-linear-gradient-expected.html:
- 9:36 AM Changeset in webkit [167937] by
-
- 24 edits2 adds in trunk/Source/WebCore
Wrap CSS length conversion arguments in an object
https://bugs.webkit.org/show_bug.cgi?id=131552
Reviewed by Andreas Kling.
This patch introduces a class CSSToLengthConversionData to wrap the
data required to convert CSS lengths to Lengths. This simplifies the
plumbing that goes on whenever we need to resolve CSS lengths and
makes it easier to update the arguments needed for resolving these (in
particular adding a RenderView for resolving viewport units at style
recalc time; removing the computingFontSize bool also appears
possible).
Note that the zoom argument, which was previously a float in some
places and a double in others is now a float.
This is a port of a Blink patch by timloh@chromium.org.
No new tests, no behavior change.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- css/BasicShapeFunctions.cpp:
(WebCore::convertToLength):
(WebCore::convertToLengthSize):
(WebCore::convertToCenterCoordinate):
(WebCore::cssValueToBasicShapeRadius):
(WebCore::basicShapeForValue):
- css/BasicShapeFunctions.h:
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::determineCategory):
- css/CSSCalculationValue.h:
(WebCore::CSSCalcValue::createCalculationValue):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::computeEndPoint):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):
- css/CSSGradientValue.h:
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
- css/CSSPrimitiveValue.h:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
- css/CSSToLengthConversionData.cpp: Added.
(WebCore::CSSToLengthConversionData::zoom):
- css/CSSToLengthConversionData.h: Added.
(WebCore::CSSToLengthConversionData::CSSToLengthConversionData):
(WebCore::CSSToLengthConversionData::style):
(WebCore::CSSToLengthConversionData::rootStyle):
(WebCore::CSSToLengthConversionData::computingFontSize):
(WebCore::CSSToLengthConversionData::copyWithAdjustedZoom):
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::CSSToStyleMap):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
- css/CSSToStyleMap.h:
(WebCore::CSSToStyleMap::CSSToStyleMap): Deleted.
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::csstoLengthConversionDataWithTextZoomFactor):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
(WebCore::ApplyPropertyWordSpacing::applyValue):
(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- css/MediaQueryEvaluator.cpp:
(WebCore::colorMediaFeatureEval):
(WebCore::color_indexMediaFeatureEval):
(WebCore::monochromeMediaFeatureEval):
(WebCore::orientationMediaFeatureEval):
(WebCore::aspect_ratioMediaFeatureEval):
(WebCore::device_aspect_ratioMediaFeatureEval):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
(WebCore::gridMediaFeatureEval):
(WebCore::computeLength):
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
(WebCore::min_colorMediaFeatureEval):
(WebCore::max_colorMediaFeatureEval):
(WebCore::min_color_indexMediaFeatureEval):
(WebCore::max_color_indexMediaFeatureEval):
(WebCore::min_monochromeMediaFeatureEval):
(WebCore::max_monochromeMediaFeatureEval):
(WebCore::min_aspect_ratioMediaFeatureEval):
(WebCore::max_aspect_ratioMediaFeatureEval):
(WebCore::min_device_aspect_ratioMediaFeatureEval):
(WebCore::max_device_aspect_ratioMediaFeatureEval):
(WebCore::min_device_pixel_ratioMediaFeatureEval):
(WebCore::max_device_pixel_ratioMediaFeatureEval):
(WebCore::min_heightMediaFeatureEval):
(WebCore::max_heightMediaFeatureEval):
(WebCore::min_widthMediaFeatureEval):
(WebCore::max_widthMediaFeatureEval):
(WebCore::min_device_heightMediaFeatureEval):
(WebCore::max_device_heightMediaFeatureEval):
(WebCore::min_device_widthMediaFeatureEval):
(WebCore::max_device_widthMediaFeatureEval):
(WebCore::min_resolutionMediaFeatureEval):
(WebCore::max_resolutionMediaFeatureEval):
(WebCore::animationMediaFeatureEval):
(WebCore::transitionMediaFeatureEval):
(WebCore::transform_2dMediaFeatureEval):
(WebCore::transform_3dMediaFeatureEval):
(WebCore::view_modeMediaFeatureEval):
(WebCore::video_playable_inlineMediaFeatureEval):
(WebCore::hoverMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
(WebCore::MediaQueryEvaluator::eval):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::convertToIntLength):
(WebCore::StyleResolver::convertToFloatLength):
(WebCore::createGridTrackBreadth):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::createFilterOperations):
- css/StyleResolver.h:
(WebCore::StyleResolver::State::setStyle):
(WebCore::StyleResolver::State::cssToLengthConversionData):
- css/TransformFunctions.cpp:
(WebCore::convertToFloatLength):
(WebCore::transformsForValue):
- css/TransformFunctions.h:
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- rendering/RenderThemeIOS.mm:
(WebCore::applyCommonButtonPaddingToStyle):
(WebCore::RenderThemeIOS::adjustButtonStyle):
- 9:17 AM Changeset in webkit [167936] by
-
- 8 edits in trunk
[CSS Shapes] complex calc args for inset round vanish
https://bugs.webkit.org/show_bug.cgi?id=132293
Reviewed by Bem Jones-Bey.
Source/WebCore:
In order to use calc in the rounded parameters for inset shapes, we need
to pass RenderStyle for the value creation as we did for the width arguments.
Without taking RenderStyle into account, we hit an assert not reache
in CSSPrimitiveValue::init in the debug builds.
I've added new parsing test.
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::init):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::create):
- css/CSSValuePool.h:
(WebCore::CSSValuePool::createValue):
LayoutTests:
- fast/shapes/parsing/parsing-shape-outside-expected.txt:
- fast/shapes/parsing/parsing-test-utils.js:
- 9:16 AM Changeset in webkit [167935] by
-
- 5 edits in trunk
[CSS Shapes] complex calc values for shape-margin return null for computed style
https://bugs.webkit.org/show_bug.cgi?id=132313
Reviewed by Bem Jones-Bey.
Source/WebCore:
We need to pass RenderStyle* to the cssValuePool when parsing
shape-margin in order to use calc() as a parameter.
I've added the new test case to parsing-shape-margin.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
LayoutTests:
- fast/shapes/parsing/parsing-shape-margin.html:
- 9:15 AM Changeset in webkit [167934] by
-
- 6 edits2 adds in trunk
AX: Row span info is wrong for table cells when a footer section is placed above a body section
https://bugs.webkit.org/show_bug.cgi?id=131832
Reviewed by Mario Sanchez Prada.
Source/WebCore:
If a <footer> section is placed before the body, it renders AX row information and order incorrectly.
This also affects ARIA tables because they add their children by looking at renderer children, instead
interrogating the RenderTable directly.
Test: accessibility/table-with-footer-section-above-body.html
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addTableCellChild):
(WebCore::AccessibilityARIAGrid::addChildren):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::addChildrenFromSection):
- accessibility/AccessibilityTable.h:
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::rowIndexRange):
(WebCore::AccessibilityTableCell::columnIndexRange):
LayoutTests:
- accessibility/table-with-footer-section-above-body-expected.txt: Added.
- accessibility/table-with-footer-section-above-body.html: Added.
- 9:04 AM Changeset in webkit [167933] by
-
- 4 edits in trunk
AX: SpeechSynthesisUtterance cannot addEventListener
https://bugs.webkit.org/show_bug.cgi?id=132321
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Modified an existing test (speech-synthesis-speak.html) to use addEventTarget.
- Modules/speech/SpeechSynthesisUtterance.idl:
LayoutTests:
- platform/mac/fast/speechsynthesis/speech-synthesis-speak.html:
- 8:17 AM Changeset in webkit [167932] by
-
- 2 edits in trunk/Tools
Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
https://bugs.webkit.org/show_bug.cgi?id=132190
Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-04-29
Reviewed by Gustavo Noronha Silva.
- Scripts/webkitdirs.pm:
(canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
if ninja is in the path.
(generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
to the previous ninja generator if not.
- 8:01 AM Changeset in webkit [167931] by
-
- 4 edits2 adds in trunk
[CSS Shapes] shape-outside polygon fails when first vertex is 0,0
https://bugs.webkit.org/show_bug.cgi?id=132132
Reviewed by Bem Jones-Bey.
Source/WebCore:
ShapeInterval now distinguishes between x1==x2 - isEmpty() and x1,x2 haven't been
set yet - isUndefined(). Removed the ShapeInterval setX1() and setX2() methods, since
they're no longer used.
The polygon algorithm for computing excluded intervals now ignores horizontal
edges. It also ignores edges whose lower vertex matches the top of the line, if
the edge's Y direction is upwards (away from the top of the line). The rationale
for this was explained here:
http://hansmuller-webkit.blogspot.com/2012/11/revised-horizontal-box-algorithm.html
Test: fast/shapes/shape-outside-floats/shape-outside-polygon-zero-vertex.html
- rendering/shapes/PolygonShape.cpp:
(WebCore::OffsetPolygonEdge::clippedEdgeXRange):
(WebCore::PolygonShape::getExcludedIntervals):
- rendering/shapes/ShapeInterval.h:
(WebCore::ShapeInterval::ShapeInterval):
(WebCore::ShapeInterval::isUndefined):
(WebCore::ShapeInterval::x1):
(WebCore::ShapeInterval::x2):
(WebCore::ShapeInterval::width):
(WebCore::ShapeInterval::isEmpty):
(WebCore::ShapeInterval::setX1):
(WebCore::ShapeInterval::setX2):
(WebCore::ShapeInterval::overlaps):
(WebCore::ShapeInterval::contains):
(WebCore::ShapeInterval::unite):
LayoutTests:
- fast/shapes/shape-outside-floats/shape-outside-polygon-zero-vertex-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-polygon-zero-vertex.html: Added.
- 7:54 AM Changeset in webkit [167930] by
-
- 13 edits20 adds in trunk
[CSS Regions] Fix getClientRects() for content nodes
https://bugs.webkit.org/show_bug.cgi?id=117407
Reviewed by David Hyatt.
Source/WebCore:
This patch modifies getClientRects() to return a list of fragments
for a fragmented box instead of a single rectangle positioned inside
the region where the box center would appear.
The approach is to split the border box of the element in regions using
the layout positioning. Then each fragment is mapped to the view coordinates
and the result added to the list of rectangles. To preserve the originating
region when mapping the fragment through the ancestor tree I've introduced
the concept of a current region. The current region is stored inside a
CurrentRenderRegionMaintainer object, created whenever an algorithm needing
it needs to run. When the maintainer is destroyed, the cleanup is made
automatically. The RenderFlowThread holds a pointer to this structure for
easy access.
Tests: fast/regions/cssom/client-rects-fixed-content.html
fast/regions/cssom/client-rects-forced-breaks.html
fast/regions/cssom/client-rects-inline-complex.html
fast/regions/cssom/client-rects-inline.html
fast/regions/cssom/client-rects-nested-regions.html
fast/regions/cssom/client-rects-positioned.html
fast/regions/cssom/client-rects-relative-position.html
fast/regions/cssom/client-rects-simple-block.html
fast/regions/cssom/client-rects-transforms.html
fast/regions/cssom/client-rects-unsplittable-float.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::absoluteQuads): Split the box in fragments.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::absoluteQuads): Split the box in fragments.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::mapLocalToContainer):
(WebCore::RenderFlowThread::currentRegion):
- rendering/RenderFlowThread.h:
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::absoluteQuadsForBoxInRegion): Get
the fragments for this box in the region.
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::absoluteQuadsForBox): Virtual function
that can be used to implement fragments to client rects mapping.
- rendering/RenderNamedFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::rectFlowPortionForBox): Small change to correctly
map empty rectangles to containers.
(WebCore::CurrentRenderRegionMaintainer::CurrentRenderRegionMaintainer):
(WebCore::CurrentRenderRegionMaintainer::~CurrentRenderRegionMaintainer):
- rendering/RenderRegion.h:
(WebCore::RenderRegion::absoluteQuadsForBoxInRegion):
(WebCore::CurrentRenderRegionMaintainer::region):
LayoutTests:
Tests verifying getClientRects works correctly in different situations.
- fast/regions/cssom/client-rects-fixed-content-expected.txt: Added.
- fast/regions/cssom/client-rects-fixed-content.html: Added.
- fast/regions/cssom/client-rects-forced-breaks-expected.txt: Added.
- fast/regions/cssom/client-rects-forced-breaks.html: Added.
- fast/regions/cssom/client-rects-inline-complex-expected.txt: Added.
- fast/regions/cssom/client-rects-inline-complex.html: Added.
- fast/regions/cssom/client-rects-inline-expected.txt: Added.
- fast/regions/cssom/client-rects-inline.html: Added.
- fast/regions/cssom/client-rects-nested-regions-expected.txt: Added.
- fast/regions/cssom/client-rects-nested-regions.html: Added.
- fast/regions/cssom/client-rects-positioned-expected.txt: Added.
- fast/regions/cssom/client-rects-positioned.html: Added.
- fast/regions/cssom/client-rects-relative-position-expected.txt: Added.
- fast/regions/cssom/client-rects-relative-position.html: Added.
- fast/regions/cssom/client-rects-simple-block-expected.txt: Added.
- fast/regions/cssom/client-rects-simple-block.html: Added.
- fast/regions/cssom/client-rects-transforms-expected.txt: Added.
- fast/regions/cssom/client-rects-transforms.html: Added.
- fast/regions/cssom/client-rects-unsplittable-float-expected.txt: Added.
- fast/regions/cssom/client-rects-unsplittable-float.html: Added.
- fast/regions/resources/helper.js:
(testClientRects): Function that compares the actual client rects for an
element to a list of expected client rects.
- 7:06 AM Changeset in webkit [167929] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLINT loadisFromInstruction doesn't need special case for big endians
https://bugs.webkit.org/show_bug.cgi?id=132330
Patch by Tomas Popela <tpopela@redhat.com> on 2014-04-29
Reviewed by Mark Lam.
The change introduced in r167076 was wrong. We should not apply the offset
adjustment on loadisFromInstruction usage as the instruction
(UnlinkedInstruction) is declared as an union (i.e. with the int32_t
operand variable). The offset of the other union members will be the
same as the offset of the first one, that is 0. The behavior here is the
same on little and big endian architectures. Thus we don't need
special case for big endians.
- llint/LowLevelInterpreter.asm:
- 5:38 AM Changeset in webkit [167928] by
-
- 7 edits2 adds in trunk
Store the containing region map inside the flow thread
https://bugs.webkit.org/show_bug.cgi?id=131647
Reviewed by Mihnea Ovidenie.
Source/WebCore:
The patch moves the containing region map inside the flow thread where
it can be better handled in case the region chain changes and the map
needs to be cleared.
As a result of this move we are able to also cleanup the lines region
information of a block flow when it is removed from the tree.
Test: fast/regions/inline-strike-through.html
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore::RenderFlowThread::removeLineRegionInfo):
(WebCore::RenderFlowThread::checkLinesConsistency):
(WebCore::RenderFlowThread::containingRegionMap):
- rendering/RenderFlowThread.h:
- rendering/RootInlineBox.cpp:
(WebCore::containingRegionMap):
(WebCore::RootInlineBox::~RootInlineBox):
(WebCore::RootInlineBox::paint):
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::clearContainingRegion):
(WebCore::RootInlineBox::setContainingRegion):
LayoutTests:
Add a test that verifies the containing region map is properly cleared
when the region chain changes.
- fast/regions/inline-strike-through-expected.txt: Added.
- fast/regions/inline-strike-through.html: Added.
- 4:42 AM Changeset in webkit [167927] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Removed remaining editing/pasteboard which are already skipped.
- platform/efl/TestExpectations:
- 3:19 AM Changeset in webkit [167926] by
-
- 5 edits in trunk/Tools
check-webkit-style should understand --git-index
https://bugs.webkit.org/show_bug.cgi?id=125364
Patch by Jozsef Berta <jberta.u-szeged@partner.samsung.com> on 2014-04-29
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.create_patch): The command now supports the --cached option.
- Scripts/webkitpy/style/main.py:
(CheckWebKitStyle.main): Passing the --git-index option.
- Scripts/webkitpy/style/optparser.py:
(CommandOptionValues.init): The git-index option is switched off by default.
(CommandOptionValues.eq): Equality check for the new option.
(ArgumentParser._create_option_parser):Adding the --git-index option
(ArgumentParser.parse):
- Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
(CommandOptionValuesTest.test_init):
(CommandOptionValuesTest.test_eq):
- 2:34 AM Changeset in webkit [167925] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Flagged some tests.
- 1:47 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:44 AM Changeset in webkit [167924] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] Avoid Vector copies in WebViewBaseInputMethodFilter::setPreedit()
https://bugs.webkit.org/show_bug.cgi?id=132323
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebViewBaseInputMethodFilter.cpp:
(WebKit::WebViewBaseInputMethodFilter::setPreedit): Inline the Vector object construction into
the WebPageProxy::setComposition() call to avoid extra Vector copies and moves.
Apr 28, 2014:
- 9:20 PM Changeset in webkit [167923] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/16750708> REGRESSION (r159358): Crash in InjectedBundleHitTestResult::frame
https://bugs.webkit.org/show_bug.cgi?id=132318
Reviewed by Andy Estes.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction): Fixed a typo: set
the source frame, not the destination frame.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Changed to get the
frame for the action not from a hit test result, because some link activation actions are
not mouse events, but rather from the event’s target.
- 8:10 PM Changeset in webkit [167922] by
-
- 2 edits in trunk/Source/JavaScriptCore
Simplify tryCacheGetById
https://bugs.webkit.org/show_bug.cgi?id=132314
Reviewed by Oliver Hunt and Filip Pizlo.
This is neutral across all benchmarks we track, although it looks like a wee 0.5% progression on sunspider.
- jit/Repatch.cpp:
(JSC::tryCacheGetByID): If we fail to cache on self, we just repatch to call tryBuildGetByIDList next time.
- 7:29 PM Changeset in webkit [167921] by
-
- 3 edits2 adds in trunk
SelectorCodeGenerator::generateElementIsNthChild() leaks the parent register :nth-child() is non-filtering
https://bugs.webkit.org/show_bug.cgi?id=132311
Reviewed by Andreas Kling.
Source/WebCore:
In two cases, the parent register was never returned to the register allocator:
-Non filtering selectors (the early return).
-Non marking selectors (at the moment: only querySelector API).
Unfortunately, generateElementIsNthChild() makes function call, which forces us to do this manual allocation
of the parentElement register. Long term, I want RegisterAllocator and FunctionCall to have a special type for that.
Test: fast/selectors/several-nth-child.html
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
LayoutTests:
- fast/selectors/several-nth-child-expected.txt: Added.
- fast/selectors/several-nth-child.html: Added.
- 6:58 PM Changeset in webkit [167920] by
-
- 3 edits4 adds in trunk
CSS JIT: backtracking with current / parent element for child
https://bugs.webkit.org/show_bug.cgi?id=132057
Patch by Yusuke Suzuki <Yusuke Suzuki> on 2014-04-28
Reviewed by Benjamin Poulain.
Calculate appropriate backtracking start height from the closest
descendant. And at first, we use it for a simple optimization.
- When backtracking start height equals to current height, we
can simply jump to a descendant element check phase.
- When backtracking start height equals to current height + 1, we
can simply jump to a descendant element traversing phase.
We can apply this optimization to fragments with adjacent combinators.
But, in the meantime, we start to implement it for a fragment with
child combinator.
Source/WebCore:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorFragment::SelectorFragment):
(WebCore::SelectorCompiler::TagNamePattern::TagNamePattern):
(WebCore::SelectorCompiler::solveDescendantBacktrackingActionForChild):
(WebCore::SelectorCompiler::solveBacktrackingAction):
(WebCore::SelectorCompiler::equalTagNames):
(WebCore::SelectorCompiler::equalTagNamePatterns):
(WebCore::SelectorCompiler::computeBacktrackingStartHeightFromDescendant):
(WebCore::SelectorCompiler::computeBacktrackingHeightFromDescendant):
(WebCore::SelectorCompiler::requiresAdjacentTail):
(WebCore::SelectorCompiler::requiresDescendantTail):
(WebCore::SelectorCompiler::SelectorCodeGenerator::computeBacktrackingInformation):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateWalkToParentNode):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateWalkToParentElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateParentElementTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateAncestorTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateDirectAdjacentTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateIndirectAdjacentTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
LayoutTests:
- fast/selectors/backtracking-child-combinator-with-tail-expected.txt: Added.
- fast/selectors/backtracking-child-combinator-with-tail.html: Added.
- fast/selectors/backtracking-child-combinator-without-tail-expected.txt: Added.
- fast/selectors/backtracking-child-combinator-without-tail.html: Added.
- 6:54 PM Changeset in webkit [167919] by
-
- 5 edits in trunk/Source
Versioning.
- 6:52 PM Changeset in webkit [167918] by
-
- 1 copy in tags/Safari-538.32
New Tag.
- 6:36 PM Changeset in webkit [167917] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r153142) ASSERT from CodeBlock::dumpBytecode dumping String Switch Jump Tables
https://bugs.webkit.org/show_bug.cgi?id=132315
Reviewed by Mark Hahnenberg.
Used the StringImpl version of utf8() instead of creating a String first.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- 6:30 PM Changeset in webkit [167916] by
-
- 11 edits in trunk/Source
[iOS][WK2] Restore the scroll position and scale from the HistoryItem (mostly)
https://bugs.webkit.org/show_bug.cgi?id=132307
Source/WebCore:
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-28
Reviewed by Simon Fraser.
- WebCore.exp.in:
Source/WebKit2:
<rdar://problem/16031704>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-28
Reviewed by Simon Fraser.
Restore the scroll position and scale on back-forward by restoring the values from HistoryItem.
This covers the common cases, see <rdar://problem/16031704>.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:WebKit::]):
(-[WKWebView _didCommitLoadForMainFrame]): Deleted.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _didCommitLoadForMainFrame]):
Get rid of the old code restoring the scroll position. This is now done by the WebProcess.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
Update the scrolling tree after invoking didCommitLayerTree() on the WebPageProxy.
WKContentView and WKWebView states are updated in response to didCommitLayerTree(), the content size
and scale in particular are set there.
After that, the content size/scale is in the same state as the layerTree update, and we can scroll
the content as needed.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/ios/WebFrameLoaderClientIOS.mm:
(WebKit::WebFrameLoaderClient::restoreViewState):
iOS WebKit1 uses a custom restoreViewState(), do the same for WebKit2 since the generic code is #ifdefed out.
This is also necessary for the main frame's state update.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::restorePageState):
Restore the scale and position of the main frame. For now, we assume m_userHasChangedPageScaleFactor is set otherwise
the initial-scale would override the restored value. We will need to fix that, the value should probably be saved with
the history.
- 6:13 PM Changeset in webkit [167915] by
-
- 4 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip editing/pasteboard which EFL port does not support.
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 5:46 PM Changeset in webkit [167914] by
-
- 3 edits in trunk/Source/WebKit2
[iOS][WK2] iOS fix after r167867
https://bugs.webkit.org/show_bug.cgi?id=132302
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-28
Reviewed by Simon Fraser.
iOS Touch Points uses "phase" for describing the touch points state for historical reasons.
This patch adds state() as a synonym for phase, and revert r167893.
- Shared/WebEvent.h:
(WebKit::WebPlatformTouchPoint::state):
- UIProcess/WebPageProxy.cpp:
(WebKit::areAllTouchPointsReleased):
- 5:31 PM Changeset in webkit [167913] by
-
- 6 edits in trunk/Tools
Crash in platform/mac/accessibility/table-visible-rows.html
https://bugs.webkit.org/show_bug.cgi?id=132146
Reviewed by Filip Pizlo.
Instead of creating a local JSValueRef array on the stack and passing that to
JSObjectMakeArray(), changed to create an empty JSArray and then populate the
values using the JSObjectSetPropertyAtIndex() API.
- DumpRenderTree/AccessibilityUIElement.cpp:
(elementsForRangeCallback):
(convertElementsToObjectArray):
- DumpRenderTree/mac/TestRunnerMac.mm:
(originsArrayToJS):
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::contextClick):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::stringArrayToJS):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::convertElementsToObjectArray):
- 4:23 PM Changeset in webkit [167912] by
-
- 2 edits in trunk/Source/WebKit2
Fix a transcription error from r167901.
When addressing Darin's review feedback, I moved the iteration of dataArray from
QuickLookDocumentData::append() to WebQuickLookHandleClient::didReceiveDataArray(),
but I forgot to update the context argument to CFArrayApplyFunction() accordingly.
- WebProcess/WebCoreSupport/ios/WebQuickLookHandleClient.cpp:
(WebKit::WebQuickLookHandleClient::didReceiveDataArray):
- 4:19 PM Changeset in webkit [167911] by
-
- 2 edits in trunk/Source/WebCore
Scrollbars do not update properly when topContentInset changes dynamically
https://bugs.webkit.org/show_bug.cgi?id=132309
-and corresponding-
<rdar://problem/16642232>
Reviewed by Tim Horton.
It is not sufficient to do a layout and call updateScrollbars(). We must also call
RenderLayerCompositor::frameViewDidChangeSize() in order to properly adjust the
size and position of all of the scrolling-related layers.
- page/FrameView.cpp:
(WebCore::FrameView::topContentInsetDidChange):
- 3:35 PM Changeset in webkit [167910] by
-
- 4 edits in trunk/Source/WebCore
[New Multicolumn] event.offsetX/offsetY don't work correctly
https://bugs.webkit.org/show_bug.cgi?id=132284
Reviewed by Simon Fraser.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):
Change the code here to only trigger for CSS Regions and not for
multi-column. Add a FIXME pointing out that the code is broken even for
CSS regions.
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::mapAbsoluteToLocalPoint):
Override mapAbsoluteToLocalPoint in order to guess a region and attempt
to translate the point from that region to the flow thread local coordinate
space.
(WebCore::RenderMultiColumnFlowThread::physicalTranslationFromRegionToFlow):
- rendering/RenderMultiColumnFlowThread.h:
New helper function that just wraps calling the region's logical translation
function and converting to/from physical coordinates.
- 3:00 PM Changeset in webkit [167909] by
-
- 2 edits in trunk/Source/WebKit2
[WK2 iOS] Need to show title in the action sheet for images not inside an anchor element.
https://bugs.webkit.org/show_bug.cgi?id=132304
<rdar://problem/16535227>
Reviewed by Benjamin Poulain.
If the image in not inside an anchor tag, we must use the title attribute as
title for the action sheet.
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant _createSheetWithElementActions:showLinkTitle:]):
- 2:54 PM Changeset in webkit [167908] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r167857.
https://bugs.webkit.org/show_bug.cgi?id=132305
the change was rolled out, roll out the new expectations as
well (Requested by thorton on #webkit).
Reverted changeset:
"Unreviewed. Updating one bindings test baseline after
r167855."
http://trac.webkit.org/changeset/167857
- 2:17 PM Changeset in webkit [167907] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Use the animated version of setHighlighted on NSButtonCell where available
https://bugs.webkit.org/show_bug.cgi?id=132295
<rdar://problem/16747240>
Reviewed by Beth Dakin.
Like setState, there is an animated version of setHighlighted available.
- platform/mac/ThemeMac.mm:
(WebCore::updateStates): Use private version of _setHighlighted where possible.
- 2:14 PM Changeset in webkit [167906] by
-
- 4 edits in trunk
Source/JavaScriptCore: The LLInt is awesome and it should get more of the action.
Rubber stamped by Geoffrey Garen.
5% speed-up on JSBench and no meaningful regressions. Should be a PLT/DYE speed-up also.
- runtime/Options.h:
Tools: Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
"no-cjit" runs force the old-school threshold.
Rubber stamped by Mark Hahnenberg.
- Scripts/run-jsc-stress-tests:
- 2:07 PM Changeset in webkit [167905] by
-
- 7 edits in trunk/Source/WebKit2
WebKit2 View Gestures (Swipe): Discard snapshots made with a different view size/pixel density
https://bugs.webkit.org/show_bug.cgi?id=132115
Reviewed by Simon Fraser.
We shouldn't try to use snapshots if they no longer match the destination view size.
To do this, we need an accurate understanding of the topContentInset, both for the Web view,
and for any custom views, because we don't want to include the inset area in the snapshot,
and we don't want to reject snapshots that differ from the current view only because they have an inset or not.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _takeViewSnapshot]):
(-[WKView _setCustomSwipeViewsTopContentInset:]):
Add and plumb through a topContentInset property to apply to the custom swipe views.
For simplicitly's sake in the multi-view case, it is applied in window coordinates,
so clients will have to do conversions if necessary.
Don't include the top content inset in the snapshot that is taken.
- UIProcess/mac/ViewGestureController.h:
(WebKit::ViewGestureController::setCustomSwipeViewsTopContentInset):
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::windowRelativeBoundsForCustomSwipeViews):
Apply the aforementioned custom swipe view top content inset.
(WebKit::ViewGestureController::determineSnapshotLayerParent):
(WebKit::ViewGestureController::determineLayerAdjacentToSnapshotForParent):
Factor these out of beginSwipeGesture.
(WebKit::ViewGestureController::retrieveSnapshotForItem):
Don't return a snapshot if the current deviceScaleFactor doesn't match that
at which the snapshot was taken, or if the size of the snapshot doesn't match
the unobscured part of the snapshot layer (the layer's size sans top content inset).
(WebKit::layerGeometryFlippedToRoot): Added.
Determine whether geometry flipping occurs between a layer and the root of the tree it is in.
(WebKit::ViewGestureController::applyDebuggingPropertiesToSwipeViews):
Factor out debugging layer properties, and add some borders and backgrounds to our layers.
I switched to invert instead of blur because blur makes the borders hard to use.
(WebKit::ViewGestureController::beginSwipeGesture):
Add an additional layer, the swipeLayer, which is the parent of the swipeSnapshotLayer.
We use this layer to compensate for geometry flipping, since we don't necessarily
know the structure of the layer tree ahead of time when inserting snapshots into the
client's layer tree, in the custom swipe view case.
The swipe layer is always the full size of the view, including topContentInset, and
has a white background in order to fill in that space. The snapshot layer is the size
of the view *excluding* the topContentInset, which should match the size of the snapshot image
itself (and we reject the image and just paint white if this is not the case).
(WebKit::ViewGestureController::handleSwipeGesture):
(WebKit::ViewGestureController::removeSwipeSnapshot):
Move and remove the new swipeLayer.
- UIProcess/mac/ViewSnapshotStore.h:
- UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::recordSnapshot):
Store the deviceScaleFactor at the time the snapshot was taken.
Fix a bug where the count of snapshots with live images was too high
because we were failing to decrement it when replacing a snapshot of
an existing item with a fresh one.
- 1:55 PM Changeset in webkit [167904] by
-
- 35 edits in trunk/Source/WebCore
Unreviewed, rolling out r167855.
https://bugs.webkit.org/show_bug.cgi?id=132301
Broke the windows build (Requested by bfulgham on #webkit).
Reverted changeset:
"ScriptExecutionContext::Task should work well with C++11
lambdas"
https://bugs.webkit.org/show_bug.cgi?id=129795
http://trac.webkit.org/changeset/167855
- 1:50 PM Changeset in webkit [167903] by
-
- 2 edits in trunk/Source/WebKit2
WK2 iOS: crash when handling a synthetic keyboard event.
https://bugs.webkit.org/show_bug.cgi?id=132296
<rdar://problem/16469726>
Reviewed by Benjamin Poulain.
Adding a null check, since synthetic keyboard events do not
have a corresponding platform event. We already do this on OS X.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleEditingKeyboardEvent):
- 1:39 PM Changeset in webkit [167902] by
-
- 2 edits in trunk/Tools
[GTK] install-dependencies should also install ruby-json and ruby-highline
https://bugs.webkit.org/show_bug.cgi?id=132292
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-04-28
Reviewed by Philippe Normand.
- gtk/install-dependencies: Install ruby json and highline packages.
- 1:02 PM Changeset in webkit [167901] by
-
- 15 edits5 copies1 add in trunk/Source
[iOS] Implement WebQuickLookHandleClient for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=132157
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.exp.in: Exported QuickLookHandle::previewUTI().
- platform/network/ios/QuickLook.h:
- platform/network/ios/QuickLook.mm:
(WebCore::QuickLookHandle::previewFileName): Changed to return a WTF::String.
(WebCore::QuickLookHandle::previewUTI): Added.
Source/WebKit2:
- Shared/API/Cocoa/_WKNSFileManagerExtras.h: Added.
- Shared/API/Cocoa/_WKNSFileManagerExtras.mm: Added.
(+[NSFileManager _web_createTemporaryFileForQuickLook:]): Called WebCore::createTemporaryFileForQuickLook().
- Shared/ios/QuickLookDocumentData.cpp: Added.
(WebKit::QuickLookDocumentData::QuickLookDocumentData):
(WebKit::QuickLookDocumentData::append): Appened each CFDataRef to m_data and added their sizes to m_size.
(WebKit::QuickLookDocumentData::decodedData): Returned the combined CFDataRef created by decode().
Named this method 'decodedData' to indicate that it should only be called on objects populated by decode().
(WebKit::QuickLookDocumentData::clear): Cleared m_data and reset m_size to 0.
(WebKit::QuickLookDocumentData::encode): Implemented a custom encoding function to avoid having to combine
m_data into contiguous memory at encoding time. Encoded m_size then sequentially encoded each member of m_data.
(WebKit::QuickLookDocumentData::decode): Decoded the byte stream into a single CFDataRef. Eagerly copied the
decoded data rather than using a DataReference since we know this will outlive the decoder.
- Shared/ios/QuickLookDocumentData.h: Added.
- UIProcess/API/APILoaderClient.h:
(API::LoaderClient::didStartLoadForQuickLookDocumentInMainFrame):
(API::LoaderClient::didFinishLoadForQuickLookDocumentInMainFrame):
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::LoaderClient::didStartLoadForQuickLookDocumentInMainFrame):
(WebKit::NavigationState::LoaderClient::didFinishLoadForQuickLookDocumentInMainFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didStartLoadForQuickLookDocumentInMainFrame):
(WebKit::WebPageProxy::didFinishLoadForQuickLookDocumentInMainFrame):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebCoreSupport/ios/WebFrameLoaderClientIOS.mm:
(WebKit::WebFrameLoaderClient::didCreateQuickLookHandle):
- WebProcess/WebCoreSupport/ios/WebQuickLookHandleClient.cpp: Added.
(WebKit::WebQuickLookHandleClient::WebQuickLookHandleClient): Sent DidStartLoadForQuickLookDocumentInMainFrame
to WebPageProxy.
(WebKit::WebQuickLookHandleClient::didReceiveDataArray): Appended dataArray to m_data.
(WebKit::WebQuickLookHandleClient::didFinishLoading): Sent DidFinishLoadForQuickLookDocumentInMainFrame to
WebPageProxy and then cleared m_data.
(WebKit::WebQuickLookHandleClient::didFail): Cleared m_data.
- WebProcess/WebCoreSupport/ios/WebQuickLookHandleClient.h: Added.
(WebKit::WebQuickLookHandleClient::create):
- 1:01 PM Changeset in webkit [167900] by
-
- 2 edits1 add in trunk/LayoutTests
Layout Test fast/events/shadow-event-path[-2].html is failing
https://bugs.webkit.org/show_bug.cgi?id=132238
Add the file that was supposed to be committed in r167840.
- TestExpectations:
- fast/events/resources/shadow-event-path-shared.js: Added.
- 12:57 PM Changeset in webkit [167899] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: Intermittent crash in SpeechSynthesis::didFinishSpeaking
https://bugs.webkit.org/show_bug.cgi?id=111613
Reviewed by Mark Lam.
I think it's possible that didFinishSpeaking ends up calling directly back into start speaking, and the utterance reference
we were holding can get cleared, so protecting this should avoid a few asserts.
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
- 12:56 PM Changeset in webkit [167898] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r167845): ASSERT(!m_renderView.needsLayout()) in svg/custom/bug79798.html
https://bugs.webkit.org/show_bug.cgi?id=132297
- platform/wk2/TestExpectations:
Skip the test.
- 12:01 PM Changeset in webkit [167897] by
-
- 22 edits in trunk/Source
GC should be able to remove things from the DFG worklist and cancel on-going compilations if it knows that the compilation would already be invalidated
https://bugs.webkit.org/show_bug.cgi?id=132166
Reviewed by Oliver Hunt and Mark Hahnenberg.
The GC can aid type inference by removing structures that are dead and jettisoning
code that relies on those structures. This can dramatically accelerate type inference
for some tricky programs.
Unfortunately, we previously pinned any structures that enqueued compilations depended
on. This means that if you're on a machine that only runs a single compilation thread
and where compilations are relatively slow, you have a high chance of large numbers of
structures being pinned during any GC since the compilation queue is likely to be full
of random stuff.
This comprehensively fixes this issue by allowing the GC to remove compilation plans
if the things they depend on are dead, and to even cancel safepointed compilations.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):
(JSC::CodeBlock::isKnownToBeLiveDuringGC):
(JSC::CodeBlock::finalizeUnconditionally):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan): Deleted.
- dfg/DFGDesiredIdentifiers.cpp:
(JSC::DFG::DesiredIdentifiers::DesiredIdentifiers):
- dfg/DFGDesiredIdentifiers.h:
- dfg/DFGDesiredWatchpoints.h:
- dfg/DFGDesiredWeakReferences.cpp:
(JSC::DFG::DesiredWeakReferences::DesiredWeakReferences):
- dfg/DFGDesiredWeakReferences.h:
- dfg/DFGGraphSafepoint.cpp:
(JSC::DFG::GraphSafepoint::GraphSafepoint):
- dfg/DFGGraphSafepoint.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::notifyCompiling):
(JSC::DFG::Plan::notifyCompiled):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::DFG::Plan::isKnownToBeLiveDuringGC):
(JSC::DFG::Plan::cancel):
(JSC::DFG::Plan::visitChildren): Deleted.
- dfg/DFGPlan.h:
- dfg/DFGSafepoint.cpp:
(JSC::DFG::Safepoint::Result::~Result):
(JSC::DFG::Safepoint::Result::didGetCancelled):
(JSC::DFG::Safepoint::Safepoint):
(JSC::DFG::Safepoint::~Safepoint):
(JSC::DFG::Safepoint::checkLivenessAndVisitChildren):
(JSC::DFG::Safepoint::isKnownToBeLiveDuringGC):
(JSC::DFG::Safepoint::cancel):
(JSC::DFG::Safepoint::visitChildren): Deleted.
- dfg/DFGSafepoint.h:
(JSC::DFG::Safepoint::Result::Result):
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::compilationState):
(JSC::DFG::Worklist::waitUntilAllPlansForVMAreReady):
(JSC::DFG::Worklist::removeAllReadyPlansForVM):
(JSC::DFG::Worklist::completeAllReadyPlansForVM):
(JSC::DFG::Worklist::visitWeakReferences):
(JSC::DFG::Worklist::removeDeadPlans):
(JSC::DFG::Worklist::runThread):
(JSC::DFG::Worklist::visitChildren): Deleted.
- dfg/DFGWorklist.h:
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLCompile.h:
- heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
- heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::visitCompilerWorklistWeakReferences):
(JSC::Heap::removeDeadCompilerWorklistEntries):
(JSC::Heap::visitWeakHandles):
(JSC::Heap::collect):
(JSC::Heap::visitCompilerWorklists): Deleted.
- heap/Heap.h:
- 11:45 AM Changeset in webkit [167896] by
-
- 5 edits in trunk/Source/WebKit2
Hide service controls for selection behind a runtime switch
<rdar://problem/16736616> and https://bugs.webkit.org/show_bug.cgi?id=132291
Reviewed by Tim Horton.
- Shared/WebPreferencesStore.h:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::selectionRectsDidChange): Do nothing if the UI is disabled.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::serviceControlsEnabled):
- 11:05 AM Changeset in webkit [167895] by
-
- 7 edits2 deletes in trunk
Unreviewed, rolling out r167871.
https://bugs.webkit.org/show_bug.cgi?id=132290
broke a newmulticol test (spanner-nested-dynamic) (Requested
by thorton on #webkit).
Reverted changeset:
"Store the containing region map inside the flow thread"
https://bugs.webkit.org/show_bug.cgi?id=131647
http://trac.webkit.org/changeset/167871
- 10:57 AM Changeset in webkit [167894] by
-
- 9 edits in trunk/Source
Unreviewed, rolling out r167853.
https://bugs.webkit.org/show_bug.cgi?id=132288
caused crashes+timeouts+layout test failures described in the
bug (Requested by thorton on #webkit).
Reverted changeset:
"Coalesce responses on network process side"
https://bugs.webkit.org/show_bug.cgi?id=132229
http://trac.webkit.org/changeset/167853
- 10:38 AM Changeset in webkit [167893] by
-
- 2 edits in trunk/Source/WebKit2
Fix the iOS buld.
- UIProcess/WebPageProxy.cpp:
(WebKit::areAllTouchPointsReleased):
- 10:28 AM Changeset in webkit [167892] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] Make subview rebuilding more incremental
https://bugs.webkit.org/show_bug.cgi?id=132162
<rdar://problem/16718916>
Reviewed by Sam Weinig.
Previously we did bulk replacement of subviews, but that triggers
UIKit to send spurious will/DidMoveToWindow messages, which can
interfere with UIScrollView scrolling.
Make _web_setSubviews more incremental, only removing
deleted subviews, adding new ones, and moving existing ones
into the correct order.
- Shared/mac/RemoteLayerTreePropertyApplier.mm:
(-[UIView _web_setSubviews:]):
- 10:28 AM Changeset in webkit [167891] by
-
- 4 edits in trunk/Source
[iOS WK2] flickery scrolling with overflow-scrolling:touch
https://bugs.webkit.org/show_bug.cgi?id=132150
Source/WebCore:
Reviewed by Tim Horton.
Fix typo in a comment.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::scheduleUpdateScrollPositionAfterAsyncScroll):
Source/WebKit2:
<rdar://problem/16683006>
Reviewed by Tim Horton.
Maintain a flag that tells us if the user is interacting
with the UIScrollView, and while set, don't clobber the contentOffset
via scrolling tree updates.
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(-[WKOverflowScrollViewDelegate initWithScrollingTreeNode:WebKit::]):
(-[WKOverflowScrollViewDelegate scrollViewWillBeginDragging:]):
(-[WKOverflowScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]):
(-[WKOverflowScrollViewDelegate scrollViewDidEndDecelerating:]): We need this one,
not scrollViewDidEndScrollingAnimation:, to detect the end of decleration.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
(-[WKOverflowScrollViewDelegate scrollViewDidEndScrollingAnimation:]): Deleted.
- 10:27 AM Changeset in webkit [167890] by
-
- 2 edits in trunk/Source/WebKit2
[X11] Add missing case for mime type application/x-webkit-test-netscape
https://bugs.webkit.org/show_bug.cgi?id=132278
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2014-04-28
Reviewed by Darin Adler.
Case for x-webkit-test-netscape has been omitted along with r167759.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::initialize):
- 10:26 AM Changeset in webkit [167889] by
-
- 7 edits4 adds in trunk
Deleting properties poisons objects
https://bugs.webkit.org/show_bug.cgi?id=131551
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This is ~3% progression on Dromaeo with a ~6% progression on the jslib portion of Dromaeo in particular.
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::hasDeletedOffset):
(JSC::PropertyTable::hadDeletedOffset): If we ever had deleted properties we can no longer cache offsets when
iterating properties because we're required to iterate properties in insertion order.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap): We now re-use deleted properties when materializing the property map.
(JSC::Structure::removePropertyTransition): We allow up to 5 deletes for a particular path through the tree of
Structure transitions. After that, we convert to an uncacheable dictionary like we used to. We don't cache
delete transitions, but we allow transitioning from them.
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::pin): Now does only what it says it does--marks the property table as pinned.
(JSC::Structure::pinAndPreventTransitions): More descriptive version of what the old pin() was doing.
- runtime/Structure.h:
- runtime/StructureInlines.h:
(JSC::Structure::setEnumerationCache):
(JSC::Structure::hadDeletedOffsets):
(JSC::Structure::propertyTable):
(JSC::Structure::checkOffsetConsistency): Rearranged variables to be more sensible.
- tests/stress/for-in-after-delete.js: Added.
(foo):
LayoutTests:
New JS regress test. We're ~3.5x faster on this microbenchmark now.
- js/regress/delete-a-few-properties-then-get-by-id-expected.txt: Added.
- js/regress/delete-a-few-properties-then-get-by-id.html: Added.
- js/regress/script-tests/delete-a-few-properties-then-get-by-id.js: Added.
(MyObject):
(foo):
- 10:11 AM WebKitGTK/2.4.x edited by
- (diff)
- 10:09 AM WebKitGTK/2.4.x edited by
- (diff)
- 9:24 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 8:59 AM Changeset in webkit [167888] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Flagged some tests.
- 8:18 AM Changeset in webkit [167887] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Builtin cursors do not properly handle transparency
https://bugs.webkit.org/show_bug.cgi?id=131866
Reviewed by Gustavo Noronha Silva.
Tested by ManualTests/cursor.html.
- platform/gtk/CursorGtk.cpp:
(WebCore::createNamedCursor): Instead of interpreting the source bitmap as an A1 image, use
it as a 1-bit black and white image. We do this by:
- Painting the result to a full color image with transparency instead of an alpha-only surface.
- Masking a white background using the cursor alpha surface.
- Painting the black parts of the cursor by painting the source surface, where black pixels will be interpreted as full opaque pixels.
- 8:06 AM Changeset in webkit [167886] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Flagged some tests.
- 7:27 AM Changeset in webkit [167885] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][X11] NetscapePluginModule::scanPlugin() should write UTF-8 strings to stdout
https://bugs.webkit.org/show_bug.cgi?id=132245
Reviewed by Carlos Garcia Campos.
NetscapePluginModule::scanPlugin(), in the helper writeLine function, takes each character
of the given string and writes it out as a UChar, doing two fputc calls for each byte of the
16-bit type.
This fails badly with characters with integer value less than 256 as the most significant byte
of the UChar is written out as a null character. This effectively chops the output that's gathered
in the UIProcess and is parsed in PluginProcessProxy::scanPlugin().
To avoid all this, the UTF-8 encoding of the string is written out in the PluginProcess, and
String::fromUTF8() is called in the UIProcess to properly decode the received string.
- Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::writeCharacter):
(WebKit::writeLine):
(WebKit::writeByte): Deleted.
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):
- 7:24 AM Changeset in webkit [167884] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] Missing return statement in webkit_plugin_get_description()
https://bugs.webkit.org/show_bug.cgi?id=132263
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebKitPlugin.cpp:
(webkit_plugin_get_description): Actually return the data of the cached
plugin description CString.
- 4:10 AM Changeset in webkit [167883] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Crash in debug build with removing windowed plugin child widgets from the view
https://bugs.webkit.org/show_bug.cgi?id=132252
Reviewed by Philippe Normand.
It crashes due to an assert in HashTable that checks the iterators
validity. The problem is that we are iterating the children map
and the callback called on every iteration might modify the map,
making the iterators invalid. This happens when the WebView is
destroyed, GtkContainer calls gtk_container_foreach() with
gtk_widget_destroy as callback. When a widget inside a container
is destroyed, it's removed from the container, and in our case,
the child widget is removed from the map. This fixes several
crashes when running layout tests in debug bot.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseContainerForall): Use copyKeysToVector() instead
of using a range iterator for the map keys and check in every
iteration that the child widget from the keys vector is still
present in the map before calling the callback.
- 3:57 AM WebKitGTK/2.4.x edited by
- (diff)
- 3:50 AM Changeset in webkit [167882] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Adding failure expectations for 6
failing and flaky tests. Removed 1.
- platform/gtk/TestExpectations:
- 2:35 AM Changeset in webkit [167881] by
-
- 2 edits in trunk/LayoutTests
[GTK] Review media bugs flags
https://bugs.webkit.org/show_bug.cgi?id=132246
Reviewed by Philippe Normand.
- platform/gtk/TestExpectations: Review flags of the GTK media
bugs.
- 1:29 AM Changeset in webkit [167880] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Update GObject DOM bindings symbols file.
- bindings/gobject/webkitdom.symbols: Add missing symbols.
- 1:27 AM Changeset in webkit [167879] by
-
- 6 edits in trunk/Source/WebCore
OrderIterator refactoring to avoid extra loops
https://bugs.webkit.org/show_bug.cgi?id=119061
Reviewed by Darin Adler.
This patch removes order values Vector and use a Vector of pairs instead. The pairs are formed by a child
(RenderBox) and the index of this child. In addition, OrderIterator code is simplified.
It provides a helper class OrderIteratorPopulator, used for manipulating the Vector directly. Which allows to
consolidate the code into a single implementation across flexbox and grid. OrderIteratorPopulator part is based
on a patch from Blink r153971 by <jchaffraix@chromium.org>.
Current implementation is O(number of children * number of order values). Now it will just do a sort operation
and then a regular loop. So if you have different order values in a flexbox or grid the performance will
improve.
Comparing results of perf-tests:
- Layout/auto-grid-lots-of-data: ~0.5% worse.
- Layout/fixed-grid-lots-of-data: ~0.5% worse.
- Layout/fixed-grid-lots-of-data (setting 100 different order values): ~50% better.
- Layout/flexbox-lots-of-data: ~5% better.
No new tests, already covered by current tests.
- rendering/OrderIterator.cpp:
(WebCore::OrderIterator::currentChild): Return current child according to m_childrenIndex.
(WebCore::OrderIterator::first): Initialize m_childrenIndex and return current child.
(WebCore::OrderIterator::next): Increase m_childrenIndex and return current child.
(WebCore::compareByOrderValueAndIndex): Sorts the Vector by order value and index.
(WebCore::OrderIteratorPopulator::~OrderIteratorPopulator): Calls compareByOrderValueAndIndex() if there is any
child with non default order value.
(WebCore::OrderIteratorPopulator::collectChild): Adds the child and index to the Vector. Update
m_allChildrenHaveDefaultOrderValue accordingly.
(WebCore::OrderIterator::OrderIterator): Deleted.
(WebCore::OrderIterator::setOrderValues): Deleted.
(WebCore::OrderIterator::reset): Deleted.
- rendering/OrderIterator.h:
(WebCore::OrderIteratorPopulator::OrderIteratorPopulator): New helper class to manipulate the Vector.
(WebCore::OrderIterator::currentChild): Deleted.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::RenderFlexibleBox): Remove OrderIterator intialization.
(WebCore::RenderFlexibleBox::layoutBlock): Remove unneeded code related to old OrderValues vector.
(WebCore::RenderFlexibleBox::prepareOrderIteratorAndMargins): Populate OrderIterator using collectChild().
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Deleted.
- rendering/RenderFlexibleBox.h: Rename computeMainAxisPreferredSizes() to prepareOrderIteratorAndMargins().
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::RenderGrid): Remove OrderIterator initialization.
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator): Populate OrderIterator using collectChild().
- 1:16 AM Changeset in webkit [167878] by
-
- 2 edits in trunk/Source/WebCore
std::bitset<>::test() does unnecessary bounds checks on CSSPropertyID bitsets
https://bugs.webkit.org/show_bug.cgi?id=131685
Patch by Zan Dobersek <zdobersek@igalia.com> on 2014-04-28
Reviewed by Darin Adler.
Use std::bitset<>::operator[]() instead of std::bitset<>::test() to avoid
bounds checks which are not necessary as long as a CSSPropertyID value is used.
- css/CSSParser.cpp:
(WebCore::filterProperties):
- css/StyleProperties.cpp:
(WebCore::StyleProperties::asText):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::CascadedProperties::hasProperty):
(WebCore::StyleResolver::CascadedProperties::set):
- 1:12 AM Changeset in webkit [167877] by
-
- 4 edits in trunk/Source/WebCore
std::bitset<>::test() does unnecessary bounds checks on CSSPropertyID bitsets
https://bugs.webkit.org/show_bug.cgi?id=131685
Reviewed by Darin Adler.
Use std::bitset<>::operator[]() instead of std::bitset<>::test() to avoid
bounds checks which are not necessary as long as a CSSPropertyID value is used.
- css/CSSParser.cpp:
(WebCore::filterProperties):
- css/StyleProperties.cpp:
(WebCore::StyleProperties::asText):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::CascadedProperties::hasProperty):
(WebCore::StyleResolver::CascadedProperties::set):
- 1:06 AM Changeset in webkit [167876] by
-
- 4 edits in trunk/Source/WebCore
[GTK] TextTrack kind and mode attributes are enums since r166180
https://bugs.webkit.org/show_bug.cgi?id=132228
Reviewed by Martin Robinson.
We don't support enum values yet in GObject DOM bindings, but they
are internally strings anyway, so we can keep the old
implementations using strings as custom functions until we
properly support enums.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_text_track_get_kind):
(webkit_dom_text_track_get_mode):
(webkit_dom_text_track_set_mode):
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols:
- 1:03 AM Changeset in webkit [167875] by
-
- 6 edits in trunk/Source/WebCore
[GTK] TextTrack::addCue can raise an exception since r163974
https://bugs.webkit.org/show_bug.cgi?id=132227
Reviewed by Martin Robinson.
webkit_dom_text_track_add_cue() now receives a GError paramater
which is an API break. Add
webkit_dom_text_track_add_cue_with_error and keep
webkit_dom_text_track_add_cue as deprecated to keep API
compatibility.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_text_track_add_cue):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- bindings/gobject/webkitdom.symbols:
- bindings/scripts/CodeGeneratorGObject.pm:
(GetEffectiveFunctionName):
- 12:57 AM Changeset in webkit [167874] by
-
- 9 edits in trunk/Source/WebCore
[GTK] TextTrackCue API changed in r163649
https://bugs.webkit.org/show_bug.cgi?id=132226
Reviewed by Martin Robinson.
TextTrackCue is now a base class and part of its API was moved to
the derived class VTTCue. Update the GObject DOM bindings to keep
backwards compatibility.
- PlatformGTK.cmake: Generate bindings for DataCue and VTTCue.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_text_track_cue_get_cue_as_html): Mark as deprecated in
favor of VTTCue API.
(webkit_dom_text_track_cue_get_vertical): Ditto.
(webkit_dom_text_track_cue_set_vertical): Ditto.
(webkit_dom_text_track_cue_get_snap_to_lines): Ditto.
(webkit_dom_text_track_cue_set_snap_to_lines): Ditto.
(webkit_dom_text_track_cue_get_line): Ditto.
(webkit_dom_text_track_cue_set_line): Ditto.
(webkit_dom_text_track_cue_get_position): Ditto.
(webkit_dom_text_track_cue_set_position): Ditto.
(webkit_dom_text_track_cue_get_size): Ditto.
(webkit_dom_text_track_cue_set_size): Ditto.
(webkit_dom_text_track_cue_get_align): Ditto.
(webkit_dom_text_track_cue_set_align): Ditto.
(webkit_dom_text_track_cue_get_text): Ditto.
(webkit_dom_text_track_cue_set_text): Ditto.
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols: Add new deprecated symbols.
- bindings/gobject/WebKitDOMPrivate.cpp:
(WebKit::wrap): Add generic wrap for TextTrackCue now that it's a
base class to generate DataCue or VTTCue objects.
- bindings/gobject/WebKitDOMPrivate.h:
- bindings/gobject/webkitdom.symbols: Add DataCue symbols.
- bindings/scripts/CodeGeneratorGObject.pm:
(IsPolymorphic): Add TextTrackCue to the list of polymorphic classes.
- 12:51 AM Changeset in webkit [167873] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] GObject introspection links to installed libs when using jhbuild
https://bugs.webkit.org/show_bug.cgi?id=132220
Reviewed by Martin Robinson.
The problem is that gobject-introspection is linking the temporary
binaries adding the library paths present LDFLAGS environment
variable first, taking precedence over the libraries in the build
dir. Since the libraries paths of the dependencies are already
correctly deduced by gobject-introspection using ldd, we can
just unset the LDFLAGS variable before calling g-ir-scanner to
make sure the libraries in the build dir take predence.
- PlatformGTK.cmake:
Apr 27, 2014:
- 11:15 PM Changeset in webkit [167872] by
-
- 4 edits in trunk
[EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
https://bugs.webkit.org/show_bug.cgi?id=132176
Patch by Joonghun Park <jh718.park@samsung.com> on 2014-04-27
Reviewed by Gyuyoung Kim.
.:
EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency for now.
- Source/cmake/OptionsEfl.cmake:
Tools:
EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
and turn off indexedDB feature until the sqlite implementation is introduced.
- Scripts/webkitperl/FeatureList.pm:
- 10:52 PM Changeset in webkit [167871] by
-
- 7 edits2 adds in trunk
Store the containing region map inside the flow thread
https://bugs.webkit.org/show_bug.cgi?id=131647
Reviewed by Mihnea Ovidenie.
Source/WebCore:
The patch moves the containing region map inside the flow thread where
it can be better handled in case the region chain changes and the map
needs to be cleared.
As a result of this move we are able to also cleanup the lines region
information of a block flow when it is removed from the tree.
Test: fast/regions/inline-strike-through.html
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore::RenderFlowThread::removeLineRegionInfo):
(WebCore::RenderFlowThread::checkLinesConsistency):
(WebCore::RenderFlowThread::containingRegionMap):
- rendering/RenderFlowThread.h:
- rendering/RootInlineBox.cpp:
(WebCore::containingRegionMap):
(WebCore::RootInlineBox::~RootInlineBox):
(WebCore::RootInlineBox::paint):
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::clearContainingRegion):
(WebCore::RootInlineBox::setContainingRegion):
LayoutTests:
Add a test that verifies the containing region map is properly cleared
when the region chain changes.
- fast/regions/inline-strike-through-expected.txt: Added.
- fast/regions/inline-strike-through.html: Added.
- 9:19 PM Changeset in webkit [167870] by
-
- 5 edits2 adds in trunk
REGRESSION (r159345): The hover state for links in the top navigation of Yahoo.com doesn't work
https://bugs.webkit.org/show_bug.cgi?id=132241
rdar://problem/16501924
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/text/simple-lines-hover-underline.html
Checked that this does not hurt performance by running the
run-perf-tests PerformanceTests/Layout/line-layout.html command before and after.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::hitTestInlineChildren): Use simpleLineLayout function rather than
getting at the data member directly.
(WebCore::RenderBlockFlow::firstLineBaseline): Ditto.
(WebCore::RenderBlockFlow::inlineBlockBaseline): Ditto.
(WebCore::RenderBlockFlow::lineCount): Ditto.
(WebCore::RenderBlockFlow::paintInlineChildren): Ditto.
(WebCore::RenderBlockFlow::hasLines): Ditto.
(WebCore::RenderBlockFlow::simpleLineLayout): Added logic to determine which path to use if
m_lineLayoutPath is undetermined, and call createLineBoxes if it's not simple.
(WebCore::RenderBlockFlow::ensureLineBoxes): Factored out most of the code into a new
createLineBoxes function.
(WebCore::RenderBlockFlow::createLineBoxes): Ditto.
- rendering/RenderBlockFlow.h: Made simpleLineLayout function no longer an inline.
Added a private createLineBoxes function.
LayoutTests:
- fast/text/simple-lines-hover-underline-expected.html: Added.
- fast/text/simple-lines-hover-underline.html: Added.
- fast/text/simple-lines-hover.html: Removed an unneeded style element with a style rule that
does nothing.
- 9:07 PM Changeset in webkit [167869] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r164702): Double tap doesn't stay under the new element once the animation finishes
https://bugs.webkit.org/show_bug.cgi?id=132239
<rdar://problem/16192842>
Reviewed by Darin Adler.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scalePage):
The change in r167864 broke iOS animated resize, because it was depending on
the dynamic size update code not running if the scale wasn't going to change.
So, as a band-aid we should bail from doing that work if the scales aren't different.
In the long term we should try to untangle this code and make it less platform dependent.
- 7:37 PM Changeset in webkit [167868] by
-
- 10 edits in trunk
[MediaStream] .ended shouldn't be part of MediaStream IDL
https://bugs.webkit.org/show_bug.cgi?id=132104
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2014-04-27
Reviewed by Eric Carlson.
Source/WebCore:
.ended attribute is spec'ed out of MediaStream IDL. Instead, .active
is introduced to handle more scenarios. This patch replaces all 'ended'
attribute calls with corresponding 'active' attributes.
MediaStream-add-remove-tracks.html is updated.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addTrack): Replaced ended() with active().
(WebCore::MediaStream::removeTrack): setEnded() isn't called. setActive()
is retained which propagates oninactive event.
(WebCore::MediaStream::trackDidEnd): setEnded() isn't called.
(WebCore::MediaStream::removeRemoteSource): Replaced ended() with active().
(WebCore::MediaStream::addRemoteTrack): Replaced ended() with active().
(WebCore::MediaStream::removeRemoteTrack): Replaced ended() with active().
(WebCore::MediaStream::ended): Deleted.
(WebCore::MediaStream::setEnded): Deleted.
(WebCore::MediaStream::streamDidEnd): Deleted.
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::didRemoveRemoteStream): Replaced setEnded()
with setActive().
- platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::MediaStreamPrivate):
(WebCore::MediaStreamPrivate::setActive): Updated comment from bug
https://bugs.webkit.org/show_bug.cgi?id=131973
(WebCore::MediaStreamPrivate::setEnded): Deleted.
- platform/mediastream/MediaStreamPrivate.h:
(WebCore::MediaStreamPrivate::ended): Deleted.
LayoutTests:
.ended is not part of MediaStream IDL. Updated test case.
- fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
- fast/mediastream/MediaStream-add-remove-tracks.html:
- 7:09 PM Changeset in webkit [167867] by
-
- 2 edits in trunk/Source/WebKit2
TouchEvent is not handled after releasing any point among touched points.
https://bugs.webkit.org/show_bug.cgi?id=132043
Reviewed by Benjamin Poulain.
Handle TouchEvent until all touched points are released by setting
trackingTouchEvents variable to false when all points are released.
- UIProcess/WebPageProxy.cpp:
(WebKit::areAllTouchPointsReleased):
(WebKit::WebPageProxy::handleTouchEventSynchronously):
(WebKit::WebPageProxy::handleTouchEventAsynchronously):
(WebKit::WebPageProxy::handleTouchEvent):
- 6:55 PM Changeset in webkit [167866] by
-
- 4 edits in trunk/Source/WebKit2
Don't use DispatchMessageEvenWhenWaitingForSyncReply for messages from NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=132144
Reviewed by Darin Adler.
- NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::willSendRequest):
(WebKit::AsynchronousNetworkLoaderClient::canAuthenticateAgainstProtectionSpace):
Dont use the IPC::DispatchMessageEvenWhenWaitingForSyncReply flag. It's not needed,
almost never works in NetworkProcess, but may cause trouble if it did.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess): Removed
setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage()
function call, because there are no more any messages in NetworkProcess it could affect.
- Platform/IPC/Connection.cpp: (IPC::Connection::dispatchMessage): Added a FIXME
for an unrelated bug Anders and myself noticed while looking into this.
- 4:13 PM Changeset in webkit [167865] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] -[WKWebProcessPlugInController parameters] returns nil if no parameters have been set yet
https://bugs.webkit.org/show_bug.cgi?id=132223
Reviewed by Sam Weinig.
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::bundleParameters): Create the WKWebProcessBundleParameters if
needed.
- 3:47 PM Changeset in webkit [167864] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r164702): Double tap doesn't stay under the new element once the animation finishes
https://bugs.webkit.org/show_bug.cgi?id=132239
<rdar://problem/16192842>
Reviewed by Sam Weinig.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scalePage):
The early-return added to WebPage::scalePage breaks callers who depend
on being able to call scalePage() with the same scale but a different
origin and having that change take effect.
Page::setPageScaleFactor already has the requisite logic, so move
the early return down after that call, and guard only notification
of page scale changes.
- 3:28 PM Changeset in webkit [167863] by
-
- 8 edits1 delete in trunk/Source
[iOS] Stop creating a WKWebResourceQuickLookDelegate for every WebResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=132215
Reviewed by Dan Bernstein.
Source/WebCore:
- WebCore.exp.in: Moved QuickLook symbols to the USE(QUICK_LOOK) stanza.
- platform/network/ios/QuickLook.h: Changed one of the create() overloads to no longer take a delegate argument.
- platform/network/ios/QuickLook.mm: Moved WKWebResourceQuickLookDelegate to here and renamed to WebResourceLoaderQuickLookDelegate.
(WebCore::QuickLookHandle::create): Created a WebResourceLoaderQuickLookDelegate only if QuickLook can handle the response.
Source/WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo): Called QuickLookHandle::create() directly.
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/ios/WebResourceLoaderIOS.mm: Removed.
- 2:33 PM Changeset in webkit [167862] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (167840): Layout Test fast/events/shadow-event-path[-2].html is failing
Mark as failing until the shared JS file can be recovered.
- 1:43 PM Changeset in webkit [167861] by
-
- 16 edits in trunk/Source
[iOS WebKit2] Add support for text autosizing
<rdar://problem/16545245>
https://bugs.webkit.org/show_bug.cgi?id=132237
Reviewed by Tim Horton.
../WebCore:
Move text autosizing width from Frame to Page, as it is a Page level concept.
- WebCore.exp.in:
- page/Frame.cpp:
(WebCore::Frame::textAutosizingWidth): Deleted.
(WebCore::Frame::setTextAutosizingWidth): Deleted.
- page/Frame.h:
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(WebCore::Page::textAutosizingWidth):
(WebCore::Page::setTextAutosizingWidth):
../WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _setTextAutosizingWidth:]):
Forward setting of the text autosizing width to the Page.
../WebKit2:
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::textAutosizingWidth):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Pass the text autosizing width from the UIProcess to WebProcess.
- 1:42 PM Changeset in webkit [167860] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2 View Gestures (Zoom): Pages with 'background-attachment: fixed' don't behave correctly when zoomed
https://bugs.webkit.org/show_bug.cgi?id=132225
<rdar://problem/15729975>
Reviewed by Darin Adler.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::layerForTransientZoom):
(WebKit::TiledCoreAnimationDrawingArea::shadowLayerForTransientZoom):
(WebKit::TiledCoreAnimationDrawingArea::adjustTransientZoom):
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToPage):
Factor out code to choose which layer (and shadow layer) to apply the transient zoom to.
If we have a contentsContainmentLayer (because we have composited background-attachment: fixed),
it applies page scale, so we should apply the transient zoom to that layer
instead of the RenderView's main GraphicsLayer.
- 12:47 PM Changeset in webkit [167859] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. iOS build fix.
- UIProcess/ios/SmartMagnificationController.h:
- 11:32 AM Changeset in webkit [167858] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Adding failure expectations for 6 failing reference tests.
- platform/gtk/TestExpectations:
- 10:03 AM Changeset in webkit [167857] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Updating one bindings test baseline after r167855.
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::~JSTestCallback):
- 9:06 AM Changeset in webkit [167856] by
-
- 9 edits in trunk/Source/WebCore
Webpages can trigger loads with invalid URLs
https://bugs.webkit.org/show_bug.cgi?id=132224
rdar://problem/16697142
Reviewed by Alexey Proskuryakov.
Invalid URLs can be a way to trick the user about what website they
are looking at. Still trying to figure out a good way to regression-test this.
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv): Pass a URL rather than a String to
the navigation scheduler.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData): Ditto.
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledURLNavigation::ScheduledURLNavigation): Take a URL rather
than a string.
(WebCore::ScheduledURLNavigation::url): Ditto.
(WebCore::ScheduledRedirect::ScheduledRedirect): Ditto.
(WebCore::ScheduledLocationChange::ScheduledLocationChange): Ditto.
(WebCore::ScheduledRefresh::ScheduledRefresh): Ditto.
(WebCore::NavigationScheduler::shouldScheduleNavigation): Added a check that
prevents navigation to any URL that is invalid, except for JavaScript URLs,
which need not be valid.
(WebCore::NavigationScheduler::scheduleRedirect): Use URL instead of String.
(WebCore::NavigationScheduler::scheduleLocationChange): Use URL instead of
String. Also got rid of empty string check since empty URLs are also invalid,
and so shouldScheduleNavigation will take care of it.
(WebCore::NavigationScheduler::scheduleRefresh): Use URL instead of String.
- loader/NavigationScheduler.h: Take URL instead of String. Also removed some
unneeded incldues and uses of WTF_MAKE_NONCOPYABLE. NavigationScheduler is
already noncopyable because it has a reference for a data member, and the
disabler doesn't have any real reason to be noncopyable.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadOrRedirectSubframe): Pass a URL rather than a
String to the NavigationScheduler.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow): Ditto.
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::urlWithUniqueSecurityOrigin): Return a URL instead
of a String.
- page/SecurityOrigin.h: Updated for above change.
- 7:07 AM Changeset in webkit [167855] by
-
- 35 edits in trunk/Source/WebCore
ScriptExecutionContext::Task should work well with C++11 lambdas
https://bugs.webkit.org/show_bug.cgi?id=129795
Reviewed by Darin Adler.
Instead of having classes that subclass ScriptExecutionContext::Task and override
the performTask(ScriptExecutionContext*) method, have the ScriptExecutionContext::Task
take in a std::function<void (ScriptExecutionContext*)>-like object trough the constructor
which would contain the code currently kept in the performTask() methods.
This enables inlining C++11 lambdas into ScriptExecutionContext::postTask() calls. For
cleanup tasks, the Task object can be implicitly constructed by using the initializer list
constructor with the first argument being the ScriptExecutionContext::Task::CleanupTask tag.
The ScriptExecutionContext class remains non-copyable and now stores the passed-in invokable
object in the std::function wrapper, along with a boolean member that indicates whether the
task is of cleanup nature.
- Modules/quota/StorageErrorCallback.cpp:
(WebCore::StorageErrorCallback::CallbackTask::CallbackTask):
(WebCore::StorageErrorCallback::CallbackTask::performTask): Deleted.
- Modules/quota/StorageErrorCallback.h:
(WebCore::StorageErrorCallback::CallbackTask::create): Deleted.
- Modules/webdatabase/Database.cpp:
(WebCore::Database::~Database):
(WebCore::Database::runTransaction):
(WebCore::Database::scheduleTransactionCallback):
(WebCore::DerefContextTask::create): Deleted.
(WebCore::DerefContextTask::performTask): Deleted.
(WebCore::DerefContextTask::isCleanupTask): Deleted.
(WebCore::DerefContextTask::DerefContextTask): Deleted.
(WebCore::callTransactionErrorCallback): Deleted.
(WebCore::DeliverPendingCallbackTask::create): Deleted.
(WebCore::DeliverPendingCallbackTask::performTask): Deleted.
(WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask): Deleted.
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseCreationCallbackTask::create): Deleted.
(WebCore::DatabaseCreationCallbackTask::performTask): Deleted.
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask): Deleted.
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::CloseSyncDatabaseOnContextThreadTask::create): Deleted.
(WebCore::CloseSyncDatabaseOnContextThreadTask::performTask): Deleted.
(WebCore::CloseSyncDatabaseOnContextThreadTask::CloseSyncDatabaseOnContextThreadTask): Deleted.
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::create): Deleted.
(WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask): Deleted.
(WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask): Deleted.
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask): Deleted.
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadDestroy):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::create): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::~WorkerGlobalScopeDidInitializeTask): Deleted.
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask): Deleted.
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
- bindings/js/JSCallbackData.h:
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
(WebCore::DeleteCallbackDataTask::create): Deleted.
(WebCore::DeleteCallbackDataTask::performTask): Deleted.
(WebCore::DeleteCallbackDataTask::isCleanupTask): Deleted.
- bindings/js/JSDOMGlobalObjectTask.cpp:
(WebCore::JSGlobalObjectTask::JSGlobalObjectTask):
(WebCore::JSGlobalObjectTask::~JSGlobalObjectTask): Deleted.
(WebCore::JSGlobalObjectTask::performTask): Deleted.
- bindings/js/JSDOMGlobalObjectTask.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
- dom/CrossThreadTask.h:
(WebCore::CrossThreadTask1::performTask):
(WebCore::CrossThreadTask2::performTask):
(WebCore::CrossThreadTask3::performTask):
(WebCore::CrossThreadTask4::performTask):
(WebCore::CrossThreadTask5::performTask):
(WebCore::CrossThreadTask6::performTask):
(WebCore::CrossThreadTask7::performTask):
(WebCore::CrossThreadTask8::performTask):
(WebCore::createCallbackTask):
(WebCore::CrossThreadTask1::create): Deleted.
(WebCore::CrossThreadTask2::create): Deleted.
(WebCore::CrossThreadTask3::create): Deleted.
(WebCore::CrossThreadTask4::create): Deleted.
(WebCore::CrossThreadTask5::create): Deleted.
(WebCore::CrossThreadTask6::create): Deleted.
(WebCore::CrossThreadTask7::create): Deleted.
(WebCore::CrossThreadTask8::create): Deleted.
- dom/Document.cpp:
(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::PerformTaskContext::PerformTaskContext): Deleted.
(WebCore::Document::didReceiveTask): Deleted.
- dom/Document.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):
(WebCore::ScriptExecutionContext::timerAlignmentInterval):
(WebCore::ProcessMessagesSoonTask::create): Deleted.
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask): Deleted.
(WebCore::ScriptExecutionContext::Task::~Task): Deleted.
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::Task::Task):
(WebCore::ScriptExecutionContext::Task::performTask):
(WebCore::ScriptExecutionContext::Task::isCleanupTask):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create): Deleted.
- dom/StringCallback.cpp:
(WebCore::StringCallback::scheduleCallback):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::postListenerTask):
(WebCore::CallCacheListenerTask::create): Deleted.
(WebCore::CallCacheListenerTask::CallCacheListenerTask): Deleted.
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):
(WebCore::SharedWorkerConnectTask::create): Deleted.
(WebCore::SharedWorkerConnectTask::performTask): Deleted.
- workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::EventDispatcher::EventDispatcher):
(WebCore::WorkerEventQueue::EventDispatcher::~EventDispatcher):
(WebCore::WorkerEventQueue::EventDispatcher::dispatch):
(WebCore::WorkerEventQueue::enqueueEvent):
(WebCore::WorkerEventQueue::cancelEvent):
(WebCore::WorkerEventQueue::close):
- workers/WorkerEventQueue.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
(WebCore::CloseWorkerGlobalScopeTask::create): Deleted.
(WebCore::CloseWorkerGlobalScopeTask::performTask): Deleted.
(WebCore::CloseWorkerGlobalScopeTask::isCleanupTask): Deleted.
- workers/WorkerGlobalScope.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):
(WebCore::MessageWorkerGlobalScopeTask::create): Deleted.
(WebCore::MessageWorkerGlobalScopeTask::MessageWorkerGlobalScopeTask): Deleted.
(WebCore::MessageWorkerGlobalScopeTask::performTask): Deleted.
(WebCore::MessageWorkerTask::create): Deleted.
(WebCore::MessageWorkerTask::MessageWorkerTask): Deleted.
(WebCore::MessageWorkerTask::performTask): Deleted.
(WebCore::WorkerExceptionTask::create): Deleted.
(WebCore::WorkerExceptionTask::WorkerExceptionTask): Deleted.
(WebCore::WorkerExceptionTask::performTask): Deleted.
(WebCore::WorkerGlobalScopeDestroyedTask::create): Deleted.
(WebCore::WorkerGlobalScopeDestroyedTask::WorkerGlobalScopeDestroyedTask): Deleted.
(WebCore::WorkerGlobalScopeDestroyedTask::performTask): Deleted.
(WebCore::WorkerTerminateTask::create): Deleted.
(WebCore::WorkerTerminateTask::WorkerTerminateTask): Deleted.
(WebCore::WorkerTerminateTask::performTask): Deleted.
(WebCore::WorkerThreadActivityReportTask::create): Deleted.
(WebCore::WorkerThreadActivityReportTask::WorkerThreadActivityReportTask): Deleted.
(WebCore::WorkerThreadActivityReportTask::performTask): Deleted.
(WebCore::PostMessageToPageInspectorTask::create): Deleted.
(WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask): Deleted.
(WebCore::PostMessageToPageInspectorTask::performTask): Deleted.
(WebCore::NotifyNetworkStateChangeTask::create): Deleted.
(WebCore::NotifyNetworkStateChangeTask::NotifyNetworkStateChangeTask): Deleted.
(WebCore::NotifyNetworkStateChangeTask::performTask): Deleted.
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::performTask):
(WebCore::WorkerRunLoop::Task::Task):
- workers/WorkerRunLoop.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):
(WebCore::WorkerThreadShutdownFinishTask::create): Deleted.
(WebCore::WorkerThreadShutdownFinishTask::performTask): Deleted.
(WebCore::WorkerThreadShutdownFinishTask::isCleanupTask): Deleted.
(WebCore::WorkerThreadShutdownStartTask::create): Deleted.
(WebCore::WorkerThreadShutdownStartTask::performTask): Deleted.
(WebCore::WorkerThreadShutdownStartTask::isCleanupTask): Deleted.
- 6:40 AM Changeset in webkit [167854] by
-
- 44 edits in trunk/Source/WebKit2
Move cross-port WebKit2 code to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=129670
Reviewed by Darin Adler.
Replace uses of OwnPtr, PassOwnPtr in cross-port WebKit2 code with std::unique_ptr.
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
- NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::addSupplement):
- NetworkProcess/SynchronousNetworkLoaderClient.cpp:
(WebKit::SynchronousNetworkLoaderClient::didReceiveBuffer):
- NetworkProcess/SynchronousNetworkLoaderClient.h:
- Platform/IPC/Connection.cpp:
(IPC::Connection::dispatchWorkQueueMessageReceiverMessage):
- Platform/IPC/Connection.h:
- Platform/IPC/MessageReceiver.h:
- Platform/Module.h:
- Platform/WorkQueue.h:
- Platform/efl/ModuleEfl.cpp:
(WebKit::Module::load):
- Platform/mac/LayerHostingContext.mm:
- Shared/APIURL.h:
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
- Shared/Plugins/NPRemoteObjectMap.cpp:
- Shared/ShareableBitmap.h:
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/InspectorServer/WebSocketServer.cpp:
(WebKit::WebSocketServer::didAcceptConnection):
(WebKit::WebSocketServer::didCloseWebSocketServerConnection):
- UIProcess/InspectorServer/WebSocketServer.h:
- UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp:
(WebKit::connectionCallback):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::createDownloadProxy):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
(WebKit::WebPluginSiteDataManager::didGetSitesWithDataForAllPlugins):
(WebKit::WebPluginSiteDataManager::didClearSiteDataForAllPlugins):
- UIProcess/Plugins/WebPluginSiteDataManager.h:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::callCallbackFunction):
(WebKit::StorageManager::getOriginsInternal):
- UIProcess/WebPageProxy.cpp:
(WebKit::ExceededDatabaseQuotaRecords::areBeingProcessed):
(WebKit::ExceededDatabaseQuotaRecords::createRecord):
(WebKit::ExceededDatabaseQuotaRecords::add):
(WebKit::ExceededDatabaseQuotaRecords::next):
(WebKit::WebPageProxy::handleMouseEvent):
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::processNextQueuedWheelEvent):
(WebKit::WebPageProxy::internalShowContextMenu):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createDownloadProxy):
- UIProcess/WebProcessProxy.h:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::PluginDestructionProtector::PluginDestructionProtector):
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::deliverData):
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- WebProcess/Plugins/PluginProcessConnectionManager.h:
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::didCreatePluginInternal):
(WebKit::PluginProxy::didFailToCreatePluginInternal):
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::createWebEvent):
(WebKit::PluginView::handleEvent):
- WebProcess/Plugins/PluginView.h:
- WebProcess/WebCoreSupport/WebPopupMenu.h:
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::EventDispatcher):
- WebProcess/WebPage/EventDispatcher.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::beginPrinting):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.h:
(WebKit::WebProcess::addSupplement):
- 4:53 AM Changeset in webkit [167853] by
-
- 9 edits in trunk/Source
Coalesce responses on network process side
https://bugs.webkit.org/show_bug.cgi?id=132229
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
To reduce IPC we should coalesce response data in the network process and send it over with single IPC call.
- NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::AsynchronousNetworkLoaderClient):
(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):
(WebKit::AsynchronousNetworkLoaderClient::didReceiveBuffer):
(WebKit::AsynchronousNetworkLoaderClient::didFinishLoading):
(WebKit::AsynchronousNetworkLoaderClient::didFail):
(WebKit::AsynchronousNetworkLoaderClient::dispatchPartialCoalescedResponse):
(WebKit::AsynchronousNetworkLoaderClient::clearCoalescedResponse):
(WebKit::AsynchronousNetworkLoaderClient::responseCoalesceTimerFired):
Coalesce the response. Completed response is sent on didFinishLoading. If the coalesce timer fires
before that the data accumulated so far is dispatched.
- NetworkProcess/AsynchronousNetworkLoaderClient.h:
- NetworkProcess/NetworkResourceLoader.h:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveCompleteResponse):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
Add a new message type that covers didReceiveResponse, didReceiveBuffer and didFinishLoading in a single message.
- 1:15 AM Changeset in webkit [167852] by
-
- 3 edits in trunk/Source/WebCore
Roll out changes not part of the patch reviewed for Bug 132089
<http://webkit.org/b/132089>
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadOrRedirectSubframe):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):
Apr 26, 2014:
- 9:09 PM Changeset in webkit [167851] by
-
- 4 edits in trunk/Source/WebCore
Frame and page lifetime fixes in WebCore::createWindow
https://bugs.webkit.org/show_bug.cgi?id=132089
Reviewed by Sam Weinig.
Speculative fix because I was unable to reproduce the crash that was
reported with the test case attached to this bug.
- loader/FrameLoader.cpp:
(WebCore::createWindow): Changed code to remove the assumption that calls
out will not destroy the page or frame. Use RefPtr for the frame, and
added early exits if frame->page() becomes null at any point before we
use a page pointer.
- 7:48 PM Changeset in webkit [167850] by
-
- 4 edits2 adds in trunk
Local files should not be allowed to read pasteboard data during drag
https://bugs.webkit.org/show_bug.cgi?id=131767
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/files/local-file-drag-security.html
- page/DragController.cpp:
(WebCore::DragController::dragExited):
(WebCore::DragController::tryDHTMLDrag):
Make an old Dashboard quirk really Dashboard only.
LayoutTests:
- fast/files/local-file-drag-security-expected.txt: Added.
- fast/files/local-file-drag-security.html: Added.
- platform/wk2/TestExpectations:
- 7:43 PM Changeset in webkit [167849] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r167775): Safari crashes in ViewSnapshotStore::pruneSnapshots after loading 20 pages
https://bugs.webkit.org/show_bug.cgi?id=132204
<rdar://problem/16735622>
Reviewed by Dan Bernstein and Sam Weinig.
- UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::pruneSnapshots):
(WebKit::ViewSnapshotStore::recordSnapshot):
Fix a bug where the count of snapshots with live images was too high
because we were failing to decrement it when replacing a snapshot of
an existing item with a fresh one.
- 5:03 PM Changeset in webkit [167848] by
-
- 5 edits in tags/Safari-538.31.2/Source
Versioning.
- 5:01 PM Changeset in webkit [167847] by
-
- 1 copy in tags/Safari-538.31.2
New tag.
- 4:29 PM Changeset in webkit [167846] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Rename a bundle form delegate method
https://bugs.webkit.org/show_bug.cgi?id=132221
Reviewed by Adele Peterson.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Renamed.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Check for the method
under the old (“new”) name and under the new name.
- 2:28 PM Changeset in webkit [167845] by
-
- 3 edits4 adds in trunk
REGRESSION (r164133): Selection doesn't paint when scrolling some pages
https://bugs.webkit.org/show_bug.cgi?id=132172
Source/WebCore:
rdar://problem/16719473
Reviewed by Brent Fulgham.
Tests: fast/dynamic/remove-invisible-node-inside-selection.html
fast/dynamic/remove-node-inside-selection.html
- editing/FrameSelection.cpp:
(WebCore::clearRenderViewSelection): Changed to take a Node& because having
this take a Position& was unnecessary and strange, when really it just needs
to take a document as an argument.
(WebCore::DragCaretController::nodeWillBeRemoved): Updated for the above.
(WebCore::FrameSelection::respondToNodeModification): Added code to set the
m_pendingSelectionUpdate flag and call RenderView::setNeedsLayout so the
selection will be recomputed after it's temporarily cleared when one of
the selected nodes is removed.
LayoutTests:
Reviewed by Brent Fulgham.
- fast/dynamic/remove-invisible-node-inside-selection-expected.html: Added.
- fast/dynamic/remove-invisible-node-inside-selection.html: Added.
- fast/dynamic/remove-node-inside-selection-expected.html: Added.
- fast/dynamic/remove-node-inside-selection.html: Added.
- 12:15 PM Changeset in webkit [167844] by
-
- 5 edits in tags/Safari-538.31.1/Source
Versioning.
- 12:13 PM Changeset in webkit [167843] by
-
- 1 copy in tags/Safari-538.31.1
New tag.
Apr 25, 2014:
- 11:00 PM Changeset in webkit [167842] by
-
- 4 edits in trunk/Source/JavaScriptCore
Inline (C++) GetByVal with numeric indices more aggressively.
<https://webkit.org/b/132218>
We were already inlining the string indexed GetByVal path pretty well,
while the path for numeric indices got neglected. No more!
~9.5% improvement on Dromaeo/dom-traverse.html on my MBP:
Before: 199.50 runs/s
After: 218.58 runs/s
Reviewed by Phil Pizlo.
- dfg/DFGOperations.cpp:
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::get):
ALWAYS_INLINE all the things.
- runtime/JSObject.h:
(JSC::JSObject::getPropertySlot):
Avoid fetching the Structure more than once. We have the same
optimization in the string-indexed code path.
- 10:53 PM Changeset in webkit [167841] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] Synthesized getter for WKNavigationAction's _userInitiated property has the wrong name
https://bugs.webkit.org/show_bug.cgi?id=132219
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKNavigationActionInternal.h:
- 9:41 PM Changeset in webkit [167840] by
-
- 4 edits2 adds in trunk
REGRESSION (r167689): Hovering file name in a file input causes a crash
https://bugs.webkit.org/show_bug.cgi?id=132214
Reviewed by Andreas Kling.
Source/WebCore:
The bug was caused by callDefaultEventHandlersInTheBubblingOrder unconditionally
accessing path.contextAt(0) even if the event path was empty.
Fixed the bug by exiting early when the event path is empty.
Test: fast/events/shadow-event-path-2.html
- dom/EventDispatcher.cpp:
(WebCore::callDefaultEventHandlersInTheBubblingOrder):
LayoutTests:
Add a regression test.
- fast/events/shadow-event-path-2-expected.txt: Added.
- fast/events/shadow-event-path-2.html: Added.
- fast/events/shadow-event-path.html:
- 8:54 PM Changeset in webkit [167839] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] getAssistedNodeInformation crashes getting the bounding box if it doesn't have a renderer
https://bugs.webkit.org/show_bug.cgi?id=132217
<rdar://problem/16671662>
Patch by Simon Fraser <Simon Fraser> on 2014-04-25
Reviewed by Dean Jackson.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getAssistedNodeInformation): Check that m_assistedNode has
a renderer before asking for its bounding box.
- 8:30 PM Changeset in webkit [167838] by
-
- 7 edits1 add in trunk/PerformanceTests
Bump jQuery to same version that dromaeo.com uses.
Rubber-stamped by Ryosuke Niwa.
- Dromaeo/resources/dromaeo/web/lib/jquery-1.10.2.min.js: Added.
- Dromaeo/resources/dromaeo/web/tests/cssquery-jquery.html:
- Dromaeo/resources/dromaeo/web/tests/jslib-attr-jquery.html:
- Dromaeo/resources/dromaeo/web/tests/jslib-event-jquery.html:
- Dromaeo/resources/dromaeo/web/tests/jslib-modify-jquery.html:
- Dromaeo/resources/dromaeo/web/tests/jslib-style-jquery.html:
- Dromaeo/resources/dromaeo/web/tests/jslib-traverse-jquery.html:
- 5:31 PM Changeset in webkit [167837] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r167828): http/tests/media/hls/video-controls-live-stream.html fails
- English.lproj/mediaControlsLocalizedStrings.js:
Add 'Live Broadcast' to the localized strings list.
- 5:12 PM Changeset in webkit [167836] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Add an intermediary view to do the target transform and adjustment transform
https://bugs.webkit.org/show_bug.cgi?id=132175
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-25
Reviewed by Enrica Casucci.
Some utility views of WKContentView account for the transforms between the content view
and the utility view.
Since the dynamic resize relies on setting subLayerTransforms, it is getting in the way.
This patch adds a layer in between for the animation. That way the content view remains
unscaled.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:WebKit::]):
(-[WKWebView _dynamicViewportUpdateChangedTargetToScale:position:]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):
- 5:06 PM Changeset in webkit [167835] by
-
- 4 edits in trunk/Source/WebKit2
REGRESSION (iOS WebKit2): Selection is not being repainted during live resize.
https://bugs.webkit.org/show_bug.cgi?id=132216
<rdar://problem/16628819>
Reviewed by Benjamin Poulain.
Since the selection is drawn in the UIProcess on iOS,
we need to update the selection rects and force a repaint
during a live resize.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateSelectionAppearance):
- 4:48 PM Changeset in webkit [167834] by
-
- 2 edits in trunk/Tools
Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
https://bugs.webkit.org/show_bug.cgi?id=132209
Reviewed by Daniel Bates.
Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
Run check-webkit-style before generating changelogs to avoid additional spurious errors.
- Scripts/prepare-ChangeLog:
(main):
- 4:43 PM Changeset in webkit [167833] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: DOM Tree debugger popover obscures dashboard
https://bugs.webkit.org/show_bug.cgi?id=132205
Patch by Jonathan Wells <jonowells@apple.com> on 2014-04-25
Reviewed by Timothy Hatcher.
- UserInterface/Views/DashboardContainerView.css:
(.toolbar .dashboard.visible): Change z-index to 1. Force stacking context.
- UserInterface/Views/Popover.css:
(.popover): Add z-index: 100.
- 4:14 PM Changeset in webkit [167832] by
-
- 3 edits3 adds in trunk
Need earlier cell test
https://bugs.webkit.org/show_bug.cgi?id=132211
Reviewed by Mark Lam.
Source/JavaScriptCore:
Move cell test to before the function call repatch
location, as the repatch logic for 32bit assumes that the
caller will already have performed a cell check.
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
LayoutTests:
Tests
- js/regress/polymorphic-array-call-expected.txt: Added.
- js/regress/polymorphic-array-call.html: Added.
- js/regress/script-tests/polymorphic-array-call.js: Added.
(func.C.this.m):
(func.C):
(func):
- 4:08 PM Changeset in webkit [167831] by
-
- 2 edits in trunk/Source/JavaScriptCore
Un-fast-allocate JSGlobalObjectRareData because Windows doesn't build and I'm not in the mood.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectRareData::JSGlobalObjectRareData):
(JSC::JSGlobalObject::JSGlobalObjectRareData::~JSGlobalObjectRareData): Deleted.
- 4:05 PM Applications using WebKit edited by
- (diff)
- 4:04 PM Applications using WebKit edited by
- (diff)
- 4:03 PM Applications using WebKit edited by
- (diff)
- 3:22 PM Changeset in webkit [167830] by
-
- 11 edits5 adds in trunk/Source
Add a selection overlay.
<rdar://problem/16727797> and https://bugs.webkit.org/show_bug.cgi?id=132200
Reviewed by David Hyatt.
Source/WebCore:
No new tests (WK2 feature in development).
- WebCore.xcodeproj/project.pbxproj:
Add a SelectionRectGathterer class.
It creates a Notifier (given a RenderView) then accepts Rects from the RenderView.
When the Notifier is destroyed, the appropriate EditorClient is notified of the gathered rects.
- editing/SelectionRectGatherer.cpp: Added.
(WebCore::SelectionRectGatherer::SelectionRectGatherer):
(WebCore::SelectionRectGatherer::addRect):
(WebCore::SelectionRectGatherer::addRects):
(WebCore::SelectionRectGatherer::Notifier::Notifier):
(WebCore::SelectionRectGatherer::Notifier::~Notifier):
(WebCore::SelectionRectGatherer::clearAndCreateNotifier):
- editing/SelectionRectGatherer.h: Added.
- page/EditorClient.h:
(WebCore::EditorClient::selectionRectsDidChange):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::setSelection): Clear the gatherer’s rects then create a Notifier.
(WebCore::RenderView::setSubtreeSelection): Give all the selection rects to be painted to
the SelectionRectGatherer.
- rendering/RenderView.h:
Source/WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::selectionRectsDidChange): Pass the new selection rects on
to the selection overlay controller.
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebPage/SelectionOverlayController.cpp: Added.
(WebKit::SelectionOverlayController::SelectionOverlayController):
(WebKit::SelectionOverlayController::createOverlayIfNeeded):
(WebKit::SelectionOverlayController::destroyOverlay):
(WebKit::SelectionOverlayController::pageOverlayDestroyed):
(WebKit::SelectionOverlayController::willMoveToWebPage):
(WebKit::SelectionOverlayController::didMoveToWebPage):
(WebKit::SelectionOverlayController::selectionRectsDidChange):
(WebKit::SelectionOverlayController::drawRect):
(WebKit::SelectionOverlayController::mouseEvent):
- WebProcess/WebPage/SelectionOverlayController.h: Added.
(WebKit::SelectionOverlayController::create):
- WebProcess/WebPage/mac/SelectionOverlayControllerMac.mm: Added.
(WebKit::SelectionOverlayController::drawRect):
(WebKit::SelectionOverlayController::mouseEvent):
(WebKit::SelectionOverlayController::handleClick):
(WebKit::SelectionOverlayController::clearHighlight):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::selectionOverlayController):
- WebProcess/WebPage/WebPage.h:
- 3:18 PM Changeset in webkit [167829] by
-
- 2 edits in trunk/WebKitLibraries
Update WKSI for https://webkit.org/b/132195
<rdar://problem/16175750>
Sorry, I forgot to update the header. This should fix
the Mac builds.
- WebKitSystemInterface.h:
- 3:18 PM Changeset in webkit [167828] by
-
- 10 edits6 adds in trunk
Support "Live" streams in media controls.
https://bugs.webkit.org/show_bug.cgi?id=131390
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/media/hls/video-controls-live-stream.html
Support "Live" streams by adding an isLive property to our media controls.
- Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-status-display):
(video:-webkit-full-screen::-webkit-media-controls-status-display):
- Modules/mediacontrols/mediaControlsApple.js:
(Controller): isLive defaults to false.
(Controller.prototype.setIsLive): Set the isLive property and conditionally reconfigure the controls.
(Controller.prototype.configureInlineControls): Don't add the timeline if we are live.
(Controller.prototype.configureFullScreenControls): Ditto.
(Controller.prototype.updateStatusDisplay): Added.
(Controller.prototype.handleLoadStart): Call updateStatusDisplay().
(Controller.prototype.handleError): Ditto.
(Controller.prototype.handleAbort): Ditto.
(Controller.prototype.handleSuspend): Ditto.
(Controller.prototype.handleStalled): Ditto.
(Controller.prototype.handleWaiting): Ditto.
(Controller.prototype.updateDuration): Ditto.
(Controller.prototype.updateReadyState): Ditto.
LayoutTests:
- http/tests/media/hls/video-controls-live-stream-expected.txt: Added.
- http/tests/media/hls/video-controls-live-stream.html: Added.
- http/tests/media/resources/hls/test-live.php: Added.
- http/tests/media/resources/hls/test-vod.m3u8: Added.
- http/tests/media/resources/hls/test.ts: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/mac/fast/layers/video-layer-expected.txt:
- platform/mac/media/media-controls-clone-expected.txt:
- platform/wincairo/TestExpectations:
- 3:02 PM Changeset in webkit [167827] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r167818): editing/inserting/typing-space-to-trigger-smart-link.html fails on WebKit1 bots
https://bugs.webkit.org/show_bug.cgi?id=132207
- platform/mac-wk1/TestExpectations:
Mark as failing in WebKit1.
- 2:47 PM Changeset in webkit [167826] by
-
- 2 edits in trunk/Source/WebKit2
Remove duplicate member variable in WKAutocorrectionRects and WKAutocorrectionContext.
https://bugs.webkit.org/show_bug.cgi?id=132206
Reviewed by Benjamin Poulain.
- UIProcess/ios/WKContentViewInteraction.mm:
- 2:42 PM Changeset in webkit [167825] by
-
- 18 edits in trunk/Source
Allow a platform-specific size enumeration to be passed into popup-menu display
https://bugs.webkit.org/show_bug.cgi?id=132195
Reviewed by Brent Fulgham. With some in-person review comments from Sam Weinig.
Platforms like OS X use a set of predefined sizes for built-in controls
used for <select>: normal, small and mini. Expose that information to
the PopupMenuClient via the PopupMenuStyle, allowing it to be passed
into the platform code in WebKitSystemInterface.
Source/WebCore:
- platform/PopupMenuStyle.h: Add a menu size enum.
(WebCore::PopupMenuStyle::PopupMenuStyle):
(WebCore::PopupMenuStyle::menuSize):
- platform/mac/WebCoreSystemInterface.h: Pass in NSControlSize as a parameter
to WKPopupMenu.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
- rendering/RenderMenuList.cpp:
(RenderMenuList::menuStyle): Ask the RenderTheme to calculate the size
of the menu button, so that it can be added to the PopupMenuStyle.
- rendering/RenderTheme.h: New method to retrieve the menu size.
(WebCore::RenderTheme::popupMenuSize): Convert an NSControlSize into a PopupMenuSize.
- rendering/RenderThemeMac.h: Override the base function, and add a
controlSizeForCell helper.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::controlSizeForCell): Used by this new
code and the old setControlSizeForCell to calculate the NSControlSize
that would be used for the button.
(WebCore::RenderThemeMac::setControlSize): Call the new helper.
(WebCore::RenderThemeMac::popupMenuSize): Return the value from the helper.
Source/WebKit/mac:
- WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::show): Convert the WebCore menu size type into the
WebCoreSystemInterface type.
Source/WebKit2:
- Shared/PlatformPopupMenuData.cpp: Encode and decode the PopupMenuSize enum.
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
- Shared/PlatformPopupMenuData.h: Add PopupMenuSize member variable.
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu): Convert the PopupMenuSize
into a WKControlSize, and pass that into WKPopupMenu.
- WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData): Add the PopupMenuSize to
the PlatformPopupMenuData.
- 2:40 PM Changeset in webkit [167824] by
-
- 4 edits in trunk/WebKitLibraries
Update WKSI for https://webkit.org/b/132195
<rdar://problem/16175750>
Reviewed by Jessie Berlin.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceMavericks.a:
- libWebKitSystemInterfaceMountainLion.a:
- 2:32 PM Changeset in webkit [167823] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix attempt.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::JSGlobalObjectRareData::~JSGlobalObjectRareData):
- 2:28 PM Changeset in webkit [167822] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (r167775): Safari crashes in ViewSnapshotStore::pruneSnapshots after loading 20 pages
https://bugs.webkit.org/show_bug.cgi?id=132204
<rdar://problem/16729123>
Reviewed by Anders Carlsson.
- UIProcess/mac/ViewSnapshotStore.h:
- UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::ViewSnapshotStore):
(WebKit::ViewSnapshotStore::pruneSnapshots):
(WebKit::ViewSnapshotStore::recordSnapshot):
Keep track of the number of snapshots that actually have live images; the
size of the snapshot map no longer represents that.
Also, fix the crash by using the UUID from the current item instead of from
the (potentially null) most distant item; r167775 accidentally typo'd this.
- 2:17 PM Changeset in webkit [167821] by
-
- 6 edits in trunk
REGRESSION(r167799): ASSERTION in parseGridTemplateShorthand in fast/css-grid-layout/grid-template-shorthand-get-set.html
https://bugs.webkit.org/show_bug.cgi?id=132194
Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-04-25
Reviewed by Martin Robinson.
Source/WebCore:
Properly resolving the grid-template shorthand for the corresponding longhand
properties.
No new tests, grid-template-shorthand-get-set.html already covers this case.
- css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue):
- css/StylePropertyShorthand.cpp:
(WebCore::shorthandForProperty):
(WebCore::matchingShorthandsForLonghand):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
LayoutTests:
- TestExpectations: Unskip fast/css-grid-layout/grid-template-shorthand-get-set.html.
- 2:05 PM Changeset in webkit [167820] by
-
- 6 edits3 adds in trunk
Column rules not respecting scroll offsets.
https://bugs.webkit.org/show_bug.cgi?id=109683
Reviewed by Dean Jackson.
Source/WebCore:
Added fast/multicol/scrolling-column-rules.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
Make paintColumnRules virtual so that it works with both column implementations.
(WebCore::RenderBlock::paintObject):
Changed to call paintColumnRules with the adjusted scroll offset and to do it after
bailing on the root background only check.
- rendering/RenderBlock.h:
paintColumnRules is now virtual.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::paintColumnRules):
(WebCore::RenderBlockFlow::paintBoxDecorations): Deleted.
- rendering/RenderBlockFlow.h:
Got rid of paintBoxDecorations override since it failed when hasBoxDecorations was false
anyway. Override paintColumnRules instead to paint at the right time.
LayoutTests:
- fast/multicol/scrolling-column-rules.html: Added.
- platform/mac/fast/multicol/scrolling-column-rules-expected.png: Added.
- platform/mac/fast/multicol/scrolling-column-rules-expected.txt: Added.
- 1:34 PM Changeset in webkit [167819] by
-
- 4 edits in trunk/Tools
Crash in platform/mac/accessibility/table-visible-rows.html
https://bugs.webkit.org/show_bug.cgi?id=132146
Reviewed by Mark Lam.
Changed to use a local JSValueRef array temporary instead of a
std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
JSValues are visited during garbage collection when the stack is scanned. Otherwise,
the temporary values could be collected.
- DumpRenderTree/AccessibilityUIElement.cpp:
(convertElementsToObjectArray):
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::contextClick):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::convertElementsToObjectArray):
- 1:30 PM Changeset in webkit [167818] by
-
- 3 edits2 adds in trunk
Crash applying editing commands from iframe onload event
<https://bugs.webkit.org/show_bug.cgi?id=132103>
<rdar://problem/15696351>
Source/WebCore:
This patch merges the Chromium bug workaround from
<http://src.chromium.org/viewvc/blink?revision=162080&view=revision>,
which prevents reentrancy in CompositeEditCommand::apply().
Reviewed by Darin Adler.
Test: editing/apply-style-iframe-crash.html
- editing/CompositeEditCommand.cpp:
(WebCore::HTMLNames::ReentrancyGuard::isRecursiveCall):
(WebCore::HTMLNames::ReentrancyGuard::Scope::Scope):
(WebCore::HTMLNames::ReentrancyGuard::Scope::~Scope):
(WebCore::CompositeEditCommand::apply):
If this is a recursive call, return early.
LayoutTests:
Reviewed by Darin Adler.
- editing/apply-style-iframe-crash-expected.txt: Added.
- editing/apply-style-iframe-crash.html: Added.
- 1:20 PM Changeset in webkit [167817] by
-
- 6 edits16 adds in trunk
[New Multicolumn] fast/multicol/hit-test-* layout tests all fail
https://bugs.webkit.org/show_bug.cgi?id=132081
Reviewed by Dean Jackson.
Source/WebCore:
Added a bunch of tests in fast/multicol/newmulticol/compare-with-old-impl/hit-test-*.html
- rendering/RenderBlock.h:
Make offsetForContents public, since I need to call it from RenderMultiColumnSet.
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::populate):
Stop an ASSERT in the new columns code on the hit tests by making sure layout state is
disabled when moving children around.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::positionForPoint):
Refactor this function to call a helper function instead, translateRegionPointToFlowThread.
(WebCore::RenderMultiColumnSet::translateRegionPointToFlowThread):
This function is logical (unlike the mistaken physical function I first implemented in
positionForPoint).
(WebCore::RenderMultiColumnSet::updateHitTestResult):
- rendering/RenderMultiColumnSet.h:
Overridden to fill in the correct local coordinate when the HTML document is inside a paginated
RenderView. Note that column spans don't actually work, but once we move over to a
non-column based pagination API, that will become irrelevant.
LayoutTests:
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-above-or-below-expected.txt: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-above-or-below.html: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-block-axis-flipped-expected.txt: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-block-axis-flipped.html: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column-expected.txt: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column-with-line-height-expected.txt: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column-with-line-height.html: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column.html: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-float-expected.txt: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-float.html: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-expected.txt: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-flipped-expected.txt: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-flipped.html: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages.html: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-block-axis-expected.txt: Added.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-block-axis.html: Added.
- 12:45 PM Changeset in webkit [167816] by
-
- 6 edits in trunk/Source/JavaScriptCore
Refactor debugging code to use BreakpointActions instead of Vector<ScriptBreakpointAction>.
<https://webkit.org/b/132201>
Reviewed by Joseph Pecoraro.
BreakpointActions is Vector<ScriptBreakpointAction>. Let's just consistently use
BreakpointActions everywhere.
- inspector/ScriptBreakpoint.h:
(Inspector::ScriptBreakpoint::ScriptBreakpoint):
- inspector/ScriptDebugServer.cpp:
(Inspector::ScriptDebugServer::setBreakpoint):
(Inspector::ScriptDebugServer::getActionsForBreakpoint):
- inspector/ScriptDebugServer.h:
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::removeBreakpoint):
- inspector/agents/InspectorDebuggerAgent.h:
- 12:41 PM Changeset in webkit [167815] by
-
- 2 edits in trunk/Source/WTF
Figure out how many cores are available for realsies.
Rubber stamped by Andreas Kling.
HW_AVAILCPU is more canonical than HW_NCPU. For example if you use hacks to tell Darwin
to make it seem like there are fewer CPUs, HW_AVAILCPU will change but HW_NCPU won't.
HW_NCPU doesn't reflect how much actual paralellism you'll get; it's merely reporting
facts about the machine you're running on. HW_AVAILCPU is almost always what WebKit
wants since it uses this information to decide how many threads to launch for various
things.
- wtf/NumberOfCores.cpp:
(WTF::numberOfProcessorCores):
- 12:39 PM Changeset in webkit [167814] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG worklist scanning should not treat the key as a separate entity
https://bugs.webkit.org/show_bug.cgi?id=132167
Reviewed by Mark Hahnenberg.
This simplifies the interface to the GC and will enable more optimizations.
- dfg/DFGCompilationKey.cpp:
(JSC::DFG::CompilationKey::visitChildren): Deleted.
- dfg/DFGCompilationKey.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::visitChildren):
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::visitChildren):
- 11:51 AM Changeset in webkit [167813] by
-
- 4 edits in trunk/Source/JavaScriptCore
Remove unused parameter from codeblock linking function
https://bugs.webkit.org/show_bug.cgi?id=132199
Reviewed by Anders Carlsson.
No change in behaviour. This is just a small change to make it
slightly easier to reason about what the offsets in UnlinkedFunctionExecutable
actually mean.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::link):
- bytecode/UnlinkedCodeBlock.h:
- runtime/Executable.cpp:
(JSC::ProgramExecutable::initializeGlobalProperties):
- 11:17 AM Changeset in webkit [167812] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r167799): ASSERTION in parseGridTemplateShorthand in fast/css-grid-layout/grid-template-shorthand-get-set.html
https://bugs.webkit.org/show_bug.cgi?id=132194
Skip the test on debug testers.
Also unmark js/slow-stress/new-spread.html because it is fixed (https://bugs.webkit.org/show_bug.cgi?id=132022)
- 11:15 AM Changeset in webkit [167811] by
-
- 31 edits in trunk/Source
Mark some things with WTF_MAKE_FAST_ALLOCATED.
<https://webkit.org/b/132198>
Use FastMalloc for more things.
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- builtins/BuiltinExecutables.h:
- heap/GCThreadSharedData.h:
- inspector/JSConsoleClient.h:
- inspector/agents/InspectorAgent.h:
- runtime/CodeCache.h:
- runtime/JSGlobalObject.h:
- runtime/Lookup.cpp:
(JSC::HashTable::createTable):
(JSC::HashTable::deleteTable):
- runtime/WeakGCMap.h:
Source/WebCore:
- bindings/js/ScriptController.h:
- dom/DocumentOrderedMap.h:
- inspector/InspectorCSSAgent.h:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorPageAgent.h:
- inspector/InspectorResourceAgent.h:
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.h:
- inspector/PageRuntimeAgent.h:
- loader/HistoryController.h:
- page/DeviceClient.h:
- page/DeviceController.h:
- page/EventHandler.h:
- page/Page.h:
- page/scrolling/ScrollingStateNode.h:
- platform/graphics/FontGenericFamilies.h:
- platform/graphics/FontPlatformData.h:
- 10:58 AM Changeset in webkit [167810] by
-
- 8 edits in trunk/Source/WebCore
[CSS Regions] Rename objectShouldPaintInFlowRegion to something more clear
https://bugs.webkit.org/show_bug.cgi?id=132050
Reviewed by Andreas Kling.
The objectShouldPaintInFlowRegion is no longer used only by the painting process
but also for hit-testing, so it was renamed to something more generic (objectShouldFragmentInFlowRegion).
No new tests required, it's just a method rename.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::positionForPoint):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::objectShouldFragmentInFlowRegion):
(WebCore::RenderFlowThread::objectShouldPaintInFlowRegion): Deleted.
- rendering/RenderFlowThread.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::hitTestLayer):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::ensureOverflowForBox):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
- 10:53 AM Changeset in webkit [167809] by
-
- 3 edits in trunk/Source/WebCore
iOS build fix after http://trac.webkit.org/changeset/167803
Unreviewed.
- page/Frame.cpp:
(WebCore::Frame::checkOverflowScroll):
- rendering/RenderBlock.cpp:
(WebCore::positionForPointRespectingEditingBoundaries):
- 9:21 AM Changeset in webkit [167808] by
-
- 7 edits5 adds in trunk
[New Multicolumn] Add support for offsetLeft and offsetTop.
https://bugs.webkit.org/show_bug.cgi?id=132080
Reviewed by Andrei Bucur.
Source/WebCore:
Added fast/multicol/client-spanners-complex.html and offset-top-left.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):
Patch the offsetLeft/Top loop to handle calling into RenderMultiColumnFlowThread
in order to adjust the coordinates for the new multicolumn layout.
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::mapFromFlowToRegion):
Modified to use a helper that can be shared by offsetLeft/Top code. This code
ran for client rects, and I'm moving/refactoring it for more sharing.
(WebCore::RenderMultiColumnFlowThread::physicalTranslationOffsetFromFlowToRegion):
(WebCore::RenderMultiColumnFlowThread::physicalTranslationFromFlowToRegion):
- rendering/RenderMultiColumnFlowThread.h:
New functions that beef up what was in mapFromFlowToRegion and fix some bugs
with the translation code.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnTranslationForOffset):
Patched to factor in the flow thread portion rect of the specific multicolumn set.
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderMultiColumnFlowThread):
Added for toRenderMultiColumnFlowThread capability.
LayoutTests:
- fast/multicol/client-rects-spanners-complex.html: Added.
- fast/multicol/client-rects-spanners.html:
- fast/multicol/offset-top-left-expected.txt: Added.
- fast/multicol/offset-top-left.html: Added.
- platform/mac/fast/multicol/client-rects-spanners-complex-expected.png: Added.
- platform/mac/fast/multicol/client-rects-spanners-complex-expected.txt: Added.
- 8:27 AM Changeset in webkit [167807] by
-
- 3 edits2 adds in trunk
ScrollingCoordinator is unaware of topContentInset
https://bugs.webkit.org/show_bug.cgi?id=132158
<rdar://problem/16706152>
Reviewed by Darin Adler.
Source/WebCore:
Test: platform/mac/fast/scrolling/scroll-select-bottom-test.html
The calculation of non-fast-scrollable regions does not currently take
the topContentOffset into account. Consequently, the logic that decides
whether to stay on the scrolling thread, or drop down to an individual
page element, can make the wrong choice. This is especially true for
small scrollable regions (such as <select> elements), where the
topContentInset may be quite close to the size of the scrollable
element itself.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion): Also
include the topContentInset value in our calculation.
LayoutTests:
- platform/mac/fast/scrolling/scroll-select-bottom-test-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-select-bottom-test.html: Added.
- 8:15 AM Changeset in webkit [167806] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r167799): Breaks debug build
https://bugs.webkit.org/show_bug.cgi?id=132194
Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-04-25
Reviewed by Andrei Bucur.
Fix the debug bots after r167799
No new tests, no new functionality.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateShorthand):
- 7:28 AM Changeset in webkit [167805] by
-
- 3 edits2 adds in trunk
Web process is crashed during dispatching touchEvent created by JS.
https://bugs.webkit.org/show_bug.cgi?id=113225
Patch by Miyoung Shin <myid.shin@samsung.com> on 2014-04-25
Reviewed by Benjamin Poulain.
TouchEvent created by JS should have the necessary attributes
of touches, targetTouches and changedTouches.
It should be verified weather there are touchLists before dispatching touch event.
Source/WebCore:
Test: fast/events/touch/create-touch-event-without-touchList.html
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventPath::updateTouchLists):
(WebCore::addRelatedNodeResolversForTouchList): Deleted.
LayoutTests:
- fast/events/touch/create-touch-event-without-touchList-expected.txt: Added.
- fast/events/touch/create-touch-event-without-touchList.html: Added.
- 7:17 AM Changeset in webkit [167804] by
-
- 4 edits in trunk/Source/WebCore
[GTK] File webkitRelativePath attribute was removed in r163483
https://bugs.webkit.org/show_bug.cgi?id=132193
Patch by Philippe Normand <pnormand@igalia.com> on 2014-04-25
Reviewed by Carlos Garcia Campos.
Add the removed getter as deprecated API to keep backwards compatibility.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_file_get_webkit_relative_path):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- 6:56 AM Changeset in webkit [167803] by
-
- 34 edits6 adds in trunk
[CSS Regions] Overflow selection doesn't work properly
https://bugs.webkit.org/show_bug.cgi?id=130715
Reviewed by David Hyatt.
Source/WebCore:
When hit-testing, painting block selection gaps and searching for the node at a specific point inside a flow thread,
the region range of the box being checked must be validated in order to not return false positives. Otherwise, hit-testing
at the top of region B could hit elements that overflow the bottom of region A.
Tests: fast/regions/selection-in-overflow-hit-testing.html
fast/regions/selection-in-overflow.html
fast/regions/selection-in-text-after-overflow-hit-testing.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
- dom/Document.cpp:
(WebCore::Document::caretRangeFromPoint):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::contains):
- editing/VisibleUnits.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
- page/EventHandler.cpp:
(WebCore::EventHandler::selectClosestWordFromHitTestResult):
(WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
(WebCore::EventHandler::handleMousePressEventTripleClick):
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::selectionExtentRespectingEditingBoundary):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::handleMouseReleaseEvent):
- page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::isChildHitTestCandidate):
(WebCore::RenderBlock::positionForPoint):
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::positionForPoint):
- rendering/RenderBlockFlow.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::positionForPoint):
- rendering/RenderBox.h:
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::positionForPoint):
- rendering/RenderFileUploadControl.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::positionForPoint):
- rendering/RenderInline.h:
- rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::positionForPoint):
- rendering/RenderLineBreak.h:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::positionForPoint):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::positionForPoint):
- rendering/RenderObject.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::positionForPoint):
- rendering/RenderRegion.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::positionForPoint):
- rendering/RenderReplaced.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
- rendering/RenderText.h:
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::positionForPoint):
- rendering/svg/RenderSVGInlineText.h:
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::positionForPoint):
- rendering/svg/RenderSVGText.h:
LayoutTests:
Added tests for hit-testing and painting selection gaps in the region's overflow area.
- fast/regions/selection-in-overflow-expected.html: Added.
- fast/regions/selection-in-overflow-hit-testing-expected.html: Added.
- fast/regions/selection-in-overflow-hit-testing.html: Added.
- fast/regions/selection-in-overflow.html: Added.
- fast/regions/selection-in-text-after-overflow-hit-testing-expected.html: Added.
- fast/regions/selection-in-text-after-overflow-hit-testing.html: Added.
- 6:35 AM Changeset in webkit [167802] by
-
- 4 edits in trunk/Source/WebCore
[GTK] Iframe seamless support was removed in r163427
https://bugs.webkit.org/show_bug.cgi?id=132192
Patch by Philippe Normand <pnormand@igalia.com> on 2014-04-25
Reviewed by Carlos Garcia Campos.
Add the removed get and set methods as deprecated API to keep
backwards compatibility.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_processing_instruction_set_data):
(webkit_dom_html_iframe_element_get_seamless):
(webkit_dom_html_iframe_element_set_seamless):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- 6:24 AM Changeset in webkit [167801] by
-
- 4 edits in trunk/Source/WebCore
[GTK] HTMLInputElement webkitdirectory property was removed in r163483
https://bugs.webkit.org/show_bug.cgi?id=132191
Patch by Philippe Normand <pnormand@igalia.com> on 2014-04-25
Reviewed by Carlos Garcia Campos.
Add the removed get and set methods as deprecated API to keep
backwards compatibility.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_html_input_element_get_webkitdirectory):
(webkit_dom_html_input_element_set_webkitdirectory):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- 5:38 AM Changeset in webkit [167800] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Added test expectations for the following flaky tests:
Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-04-25
- platform/gtk/TestExpectations:
fast/loader/submit-form-while-parsing-2.html
css3/calc/transitions-dependent.html
fast/dom/adopt-node-crash-2.html
fast/multicol/span/span-as-immediate-columns-child-dynamic.html
platform/gtk/editing/pasteboard/middle-button-paste.html
- 5:06 AM Changeset in webkit [167799] by
-
- 9 edits3 adds in trunk
[CSS Grid Layout] Implementation of the grid-template shorthand.
https://bugs.webkit.org/show_bug.cgi?id=128980
Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-04-25
Reviewed by Darin Adler.
Source/WebCore:
This shorthand sets the values for the grid-template-columns,
grid-template-rows and grid-template-areas, so the implementation
tries to reuse as much available parsing functions as possible.
The "parsingGridTrackList" was refactored to return a CSSValue and
let the "parseValue" function to assign the property value. The
"forwardSlash" operator is now valid when the track-list clause is
part of a shorthand. The "parseValue" function checkouts that only
additional clauses are allowed when processing shorthands; the
grid-columns-rows-get-set.html tests was modified to verify this.
The "parseGridTemplateAreas" was refactored too, in order to
process single areas's rows. This is very useful for the
gris-template secondary syntax, which mixes areas and rows values.
Finally, the "parseGirdLineNames" function was modified as well by
defining an new argument to concatenate head/tail custom-ident
elements and ensure the identList is at the heading index, since
it's now possible the parseList was rewound.
The implementation of the grid-template shorthand tries first to
match the <grid-template-columns> / <grid-template-rows> syntax,
failing back to the secondary syntax if needed. This approach
requires to rewind the parseList but it produces a clearer code.
Test: fast/css-grid-layout/grid-template-shorthand-get-set.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTemplateRowsAndAreas):
(WebCore::CSSParser::parseGridTemplateShorthand):
(WebCore::CSSParser::parseGridLineNames):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseGridTemplateAreasRow):
(WebCore::CSSParser::parseGridTemplateAreas):
- css/CSSParser.h:
- css/CSSParserValues.h:
(WebCore::CSSParserValueList::setCurrentIndex):
- css/CSSPropertyNames.in:
- css/StylePropertyShorthand.cpp:
(WebCore::webkitGridTemplateShorthand):
- css/StylePropertyShorthand.h:
LayoutTests:
Layout Test for the basic functionality of the grid-template shorthand. It was
also added a new javascript file with some utility functions.
This shorthand sets the values for the grid-template-columns,
grid-template-rows and grid-template-areas, so the implementation
tries to reuse as much available parsing functions as possible.
- fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-template-shorthand-get-set.html: Added.
- fast/css-grid-layout/resources/grid-template-shorthand-parsing-utils.js: Added.
(testGridDefinitionsValues):
(testGridDefinitionsSetJSValues):
(testNonGridDefinitionsSetJSValues):
(checkGridDefinitionsSetJSValues):
(testGridDefinitionsSetBadJSValues):
- 4:27 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 2:23 AM Changeset in webkit [167798] by
-
- 3 edits in trunk/Source/WebCore
Remove two unused SVGDocument functions.
<https://webkit.org/b/132178>
Reviewed by Antti Koivisto.
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::dispatchZoomEvent): Deleted.
(WebCore::SVGDocument::dispatchScrollEvent): Deleted.
- svg/SVGDocument.h:
- 1:25 AM Changeset in webkit [167797] by
-
- 6 edits6 adds in trunk
Implement Array.prototype.find()
https://bugs.webkit.org/show_bug.cgi?id=130966
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Implement Array.prototype.find() and Array.prototype.findIndex() as proposed in the Harmony spec.
- builtins/Array.prototype.js:
(find):
(findIndex):
- runtime/ArrayPrototype.cpp:
LayoutTests:
- js/Object-getOwnPropertyNames-expected.txt:
- js/array-find-expected.txt: Added.
- js/array-find.html: Added.
- js/array-findIndex-expected.txt: Added.
- js/array-findIndex.html: Added.
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/array-find.js: Added.
- js/script-tests/array-findIndex.js: Added.
- 1:13 AM WebKitGTK/2.4.x edited by
- (diff)
- 1:04 AM Changeset in webkit [167796] by
-
- 3 edits2 adds in trunk
Incomplete body painting when using blend modes
https://bugs.webkit.org/show_bug.cgi?id=131889
Source/WebCore:
The incomplete painting was caused by the transparency layer created for
the root renderer. We can safely skip creating this transparency layer at
the root level, as there is nothing else being painted behind this layer that
could be used erroneously as a backdrop.
Patch by Ion Rosca <Ion Rosca> on 2014-04-25
Reviewed by Simon Fraser.
Test: css3/compositing/blend-mode-with-body.html
- rendering/RenderLayer.h:
Changing RenderLayer::paintsWithTransparency so that it will not
return true when the root renderer needs to isolate blending.
LayoutTests:
Patch by Ion Rosca <Ion Rosca> on 2014-04-25
Reviewed by Simon Fraser.
- css3/compositing/blend-mode-with-body-expected.html: Added.
- css3/compositing/blend-mode-with-body.html: Added.
- 12:58 AM Changeset in webkit [167795] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Plugin process crashes with GTK2 windowed plugins
https://bugs.webkit.org/show_bug.cgi?id=132127
Reviewed by Martin Robinson.
It happens sometimes because the socket is used before the plug
has been added. A runtime critical warnings is shown and it
sometimes ends up crashing.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPostInitializeWindowed): Do not
show the plug widget until the socket is connected.
- 12:55 AM Changeset in webkit [167794] by
-
- 29 edits in trunk/Source/WebCore
ASSERTION FAILED: "!m_isolatedWorld->isNormal() m_wrapper !m_jsFunction" in svg/custom/use-instanceRoot-event-listeners.xhtml https://bugs.webkit.org/show_bug.cgi?id=132148
Reviewed by Andreas Kling.
Changed how JSCustomMarkFunction generation works. Instead of leaving out
the generated visitChildren function, just generate a call to visitAdditionalChildren.
This eliminates the need to repeat boilerplate.
The fix for the above bug was to correct mistaken logic where JSSVGElementInstance
had a visitChildren that did not properly mark event listeners because it explicitly
did not call through to the base class visitChildren. The new arrangement makes that
mistake impossible.
- bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::visitAdditionalChildren): Use this instead of visitChildren.
- bindings/js/JSAudioTrackCustom.cpp:
(WebCore::JSAudioTrack::visitAdditionalChildren): Ditto.
- bindings/js/JSAudioTrackListCustom.cpp:
(WebCore::JSAudioTrackList::visitAdditionalChildren): Ditto.
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::JSCSSRule::visitAdditionalChildren): Ditto.
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::visitAdditionalChildren): Ditto.
- bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::JSCanvasRenderingContext::visitAdditionalChildren): Ditto.
- bindings/js/JSCryptoKeyPairCustom.cpp:
(WebCore::JSCryptoKeyPair::visitAdditionalChildren): Ditto.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitAdditionalChildren): Ditto.
- bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::visitAdditionalChildren): Ditto.
- bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::visitAdditionalChildren): Ditto.
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::visitAdditionalChildren): Ditto.
- bindings/js/JSNodeFilterCustom.cpp:
(WebCore::JSNodeFilter::visitAdditionalChildren): Ditto.
- bindings/js/JSNodeIteratorCustom.cpp:
(WebCore::JSNodeIterator::visitAdditionalChildren): Ditto.
- bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::visitAdditionalChildren): Ditto.
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::visitAdditionalChildren): Ditto.
- bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::visitAdditionalChildren): Ditto.
- bindings/js/JSTextTrackCueCustom.cpp:
(WebCore::JSTextTrackCue::visitAdditionalChildren): Ditto.
- bindings/js/JSTextTrackCustom.cpp:
(WebCore::JSTextTrack::visitAdditionalChildren): Ditto.
- bindings/js/JSTextTrackListCustom.cpp:
(WebCore::JSTextTrackList::visitAdditionalChildren): Ditto.
- bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::visitAdditionalChildren): Ditto.
- bindings/js/JSVideoTrackCustom.cpp:
(WebCore::JSVideoTrack::visitAdditionalChildren): Ditto.
- bindings/js/JSVideoTrackListCustom.cpp:
(WebCore::JSVideoTrackList::visitAdditionalChildren): Ditto.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::visitAdditionalChildren): Ditto.
- bindings/js/JSWorkerGlobalScopeCustom.cpp:
(WebCore::JSWorkerGlobalScope::visitAdditionalChildren): Ditto.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitAdditionalChildren): Ditto.
- bindings/js/JSXPathResultCustom.cpp:
(WebCore::JSXPathResult::visitAdditionalChildren): Ditto.
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildren): Rewrote to use modern for loops.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Generate declaration of visitAdditionalChildren.
(GenerateImplementation): Generate call to visitAdditionalChildren.
- 12:19 AM Changeset in webkit [167793] by
-
- 6 edits in trunk/Source
[iOS WebKit2] Enable optimization to mmap downloaded resources once they become file-backed.
<https://webkit.org/b/132171>
<rdar://problem/16720733>
Source/WebCore:
Add a missing export for the USE(CFNETWORK) + WebKit2 combo.
Reviewed by Antti Koivisto.
- WebCore.exp.in:
Source/WebKit2:
Implement a CFNetwork-based version of NetworkResourceLoader::willCacheResponseAsync()
and activate the DiskCacheMonitor code path. This means that once resources go into
file system cache, we get notified and mmap them from disk, saving heaps of memory.
Reviewed by Antti Koivisto.
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/mac/DiskCacheMonitor.mm:
- NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::willCacheResponseAsync):
