Timeline
Jun 2, 2014:
- 11:51 PM Changeset in webkit [169558] by
-
- 3 edits in trunk/Tools
Add a verbose flag to binding tests
https://bugs.webkit.org/show_bug.cgi?id=122303
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-06-02
Reviewed by Csaba Osztrogonác.
This patch will:
- Add a verbose keyword argument to the BindingsTests constructor,
- Add --no-verbose option to the run-bindigs-test.
Verbose mode, which is on by default, prints positive results to stdout as before.
When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
Original patch from Matthew Hanson <matthew_hanson@apple.com>
- Scripts/run-bindings-tests:
(main):
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.init):
(BindingsTests.detect_changes):
- 10:47 PM Changeset in webkit [169557] by
-
- 11 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaseline after r169522.
- platform/efl/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png:
- platform/efl/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png:
- platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.png:
- platform/efl/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png:
- platform/efl/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
- svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt:
- 9:59 PM Changeset in webkit [169556] by
-
- 5 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaseline.
- platform/efl/mathml/opentype/large-operators-LatinModern-expected.txt:
- platform/efl/mathml/opentype/opentype-stretchy-expected.txt:
- platform/efl/mathml/opentype/vertical-LatinModern-expected.txt:
- platform/efl/mathml/presentation/mo-stretch-expected.txt:
- 7:04 PM Changeset in webkit [169555] by
-
- 1 edit1 move in trunk/LayoutTests
Unreviewed EFL gardening.
Move the EFL specific test result to platform directory.
- platform/efl/fast/events/ghostly-mousemoves-in-subframe-expected.txt: Renamed from LayoutTests/fast/events/ghostly-mousemoves-in-subframe-expected.txt.
- 6:59 PM Changeset in webkit [169554] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed EFL gardening.
Added expectation result after r167684, r169257, and r169390.
- fast/events/ghostly-mousemoves-in-subframe-expected.txt: Added.
- platform/efl/fast/box-shadow/hidpi-webkit-box-shadow-subpixel-position-expected.txt: Added.
- platform/efl/fast/multicol/pagination/nested-transforms-expected.txt: Added.
- 6:26 PM Changeset in webkit [169553] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (iOS WebKit2): Single tap in pages with focus on load will clear the selection after the keyboard appears.
https://bugs.webkit.org/show_bug.cgi?id=133465
<rdar://problem/17059189>
Reviewed by Benjamin Poulain.
If a page focuses an input field on load we don't bring the keyboard on screen
since the keyboard is only shown when the user interacts with the page with gestures.
Still the WebProcess sets the focus and the selection according to the rules.
We need to make sure the UI process doesn't accidentally clear this selection
when the user starts the interaction with the page.
This patch also improves the function that retrieves the autocorrection data
to be returned to the keyboard, making sure that we always send back a reply
even when we don't have a valid selection.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _singleTapCommited:]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestAutocorrectionData):
- 6:15 PM Changeset in webkit [169552] by
-
- 2 edits in trunk/WebKitLibraries
Error running copy-webkitlibraries-to-product-directory
<http://webkit.org/b/133449>
<rdar://problem/17047638>
Reviewed by Filip Pizlo.
- Makefile: Ignore the mysterious future. Use "@true" to
suppress the annoying "Nothing to be done for `libs'." message.
- 5:37 PM Changeset in webkit [169551] by
-
- 2 edits in trunk/Source/WebCore
[iOS] WebCore fails to build: platform/network/mac/ResourceHandleMac.mm:729:62: error: use of undeclared identifier '_CFURLConnectionCopyTimingData'
<http://webkit.org/b/133445>
<rdar://problem/17090035>
Reviewed by Alexey Proskuryakov.
- platform/network/mac/ResourceHandleMac.mm: Attempt to fix the
build by including a private header and local declaration.
- 4:44 PM Changeset in webkit [169550] by
-
- 25 edits in trunk/Source
Change DeferrableOneShotTimer to use std::function instead of being a class template
https://bugs.webkit.org/show_bug.cgi?id=133423
Reviewed by Antti Koivisto.
Source/WebCore:
Also, add a new constructor to DeferrableOneShotTimer that takes an std::function. Change the callback
to not pass a DeferrableOneShotTimer& anymore. Change the delay parameter to use std::chrono::milliseconds.
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::evictionTimerFired):
- css/CSSImageGeneratorValue.h:
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired):
- html/HTMLPlugInImageElement.h:
- loader/cache/CachedResource.cpp:
(WebCore::deadDecodedDataDeletionIntervalForResourceType):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore::CachedResource::decodedDataDeletionTimerFired):
- loader/cache/CachedResource.h:
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::MemoryCache):
- loader/cache/MemoryCache.h:
(WebCore::MemoryCache::setDeadDecodedDataDeletionInterval):
(WebCore::MemoryCache::deadDecodedDataDeletionInterval):
- platform/Timer.h:
(WebCore::Timer::Timer):
(WebCore::DeferrableOneShotTimer::DeferrableOneShotTimer):
- platform/graphics/cg/SubimageCacheWithTimer.cpp:
(WebCore::SubimageCacheWithTimer::invalidateCacheTimerFired):
- platform/graphics/cg/SubimageCacheWithTimer.h:
Source/WebKit/mac:
- WebView/WebView.mm:
(+[WebView _setCacheModel:]):
Source/WebKit2:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformSetCacheModel):
- Shared/CacheModel.cpp:
(WebKit::calculateCacheSizes):
- Shared/CacheModel.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginSnapshotTimerFired):
- WebProcess/Plugins/PluginView.h:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformSetCacheModel):
- 3:18 PM Changeset in webkit [169549] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Round the UIScrollView content size to device pixel
https://bugs.webkit.org/show_bug.cgi?id=133417
<rdar://problem/15922440>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-02
Reviewed by Simon Fraser.
We should really have the scaled content size floored to device pixels, but that will be for another
time.
This patch ensure the content size as seen by the API is rounded to device pixels. The value is floored
to avoid showing partial pixels when the content is stable.
- UIProcess/API/Cocoa/WKWebView.mm:
(floorFloatToPixels):
(roundScrollViewCountentSize):
(-[WKWebView _setHasCustomContentView:loadedMIMEType:WTF::]):
(-[WKWebView _didCommitLayerTree:WebKit::]):
(-[WKWebView scrollView:contentSizeForZoomScale:withProposedSize:]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):
- 3:13 PM Changeset in webkit [169548] by
-
- 2 edits in trunk/Source/WebKit2
Move ifdef to the right place.
- 3:07 PM Changeset in webkit [169547] by
-
- 8 edits2 adds in trunk
Make pseudo element matching for style resolution more JIT friendly
https://bugs.webkit.org/show_bug.cgi?id=133441
Reviewed by Antti Koivisto.
Source/WebCore:
Sharing pseudo elements is a complicated mess shared between the SelectorChecker
and the RuleCollector.
For compiling pseudo element matching, it would be best if all the complexity could
be moved to compile time instead of runtime. It is also preferable to keep the compiler
independant of the RuleCollector implementation's detail.
This patch is a first step toward that goal. The main objective here is to make
"dynamicPseudo" completely internal to the SelectorChecker.
This is mostly a mechanical change, it is likely PseudoElement matching could be simplified
further but that is not attempted here.
Test: fast/css/style-sharing-empty-rule-modification.html
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
The condition regarding pseudo element matching has been moved into SelectorChecker::match().
This creates an extra cost for querySelector(), but that should be fine since the vast majority
of selectors are JIT compiled and never use SelectorChecker in the first place.
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
The loop is changed such that the tree marking (Style::setHasPseudoStyle) could be moved
to SelectorChecker.
The conditions about the security origin for getMatchedCSSRules() and the empty style rules
are moved prior to the call to ElementRuleCollector::ruleMatches(). This ensure we keep the same
behavior of not adding the pseudo style for empty rules (this could also help with tree marking
in general but empty rules are probably uncommon).
There is one behavior change from making this loop simpler: the SharingRules and StyleInvalidation
modes now update their ruleRange. It is useless but it is simpler.
- css/ElementRuleCollector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
The tree marking has been moved here.
- css/SelectorChecker.h:
(WebCore::SelectorChecker::match):
The pseudo element matching has been moved here.
- css/StyleResolver.h:
(WebCore::checkRegionSelector):
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches):
LayoutTests:
Add more coverage for style sharing with empty rules, just in case.
- fast/css/style-sharing-empty-rule-modification-expected.txt: Added.
- fast/css/style-sharing-empty-rule-modification.html: Added.
- 2:54 PM Changeset in webkit [169546] by
-
- 3 edits in trunk/Source/WebKit2
Set default voucher for XPC client processes
https://bugs.webkit.org/show_bug.cgi?id=133458
Reviewed by Geoff Garen.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
- add voucher_replace_default_voucher.
- config.h:
- add HAVE_VOUCHERS.
- 2:13 PM Changeset in webkit [169545] by
-
- 13 edits in trunk/Source
Send external playback properties to fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=133366
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-02
Reviewed by Simon Fraser.
Source/WebCore:
Refactor property updates in WebVideoFullscreenModelMediaElement and update
setExternalPlayback on webkitcurrentplaybacktargetiswirelesschangedEvent.
- WebCore.exp.in: Add export for setExternalPlayback.
- platform/ios/WebVideoFullscreenInterface.h: add setExternalPlayback
- platform/ios/WebVideoFullscreenInterfaceAVKit.h: add setExternalPlayback
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController isPlayingOnExternalScreen]): added
(+[WebAVPlayerController keyPathsForValuesAffectingPlayingOnExternalScreen]): added
(WebVideoFullscreenInterfaceAVKit::setExternalPlayback): added
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): added
- platform/ios/WebVideoFullscreenModelMediaElement.h: add updateForEventName
- platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::setMediaElement): refactor property changes into updateForEventName()
(WebVideoFullscreenModelMediaElement::handleEvent): refactor property changes into updateForEventName()
(WebVideoFullscreenModelMediaElement::updateForEventName): remove duplicate code, implement for setExternalPlayback
Source/WebKit2:
Forward setExternalPlayback.
- UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in: add setExternalPlaybackProperties
- WebProcess/ios/WebVideoFullscreenManager.h: add setExternalPlaybackProperties
- WebProcess/ios/WebVideoFullscreenManager.mm: add setExternalPlaybackProperties
(WebKit::WebVideoFullscreenManager::setExternalPlaybackProperties): added
- 1:53 PM Changeset in webkit [169544] by
-
- 4 edits in trunk/Source/WebCore
WebCore build fix for webreplay
https://bugs.webkit.org/show_bug.cgi?id=133401
Patch by Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> on 2014-06-02
Reviewed by Darin Adler.
- replay/MemoizedDOMResult.cpp:
(WebCore::MemoizedDOMResultBase::createFromEncodedResult):
Add a default nullptr return in order to avoid a gcc warning.
The warning is because of a non-void method that has a case which doesn't return.
- replay/ReplayController.cpp:
(WebCore::ReplayController::setForceDeterministicSettings):
Guard the ScrollingCoordinator with the appropriate #ifdef.
- replay/SerializationMethods.cpp:
Guard the KeypressCommand with COCOA as it is only present there.
- 1:42 PM Changeset in webkit [169543] by
-
- 2 edits in trunk/Source/WebKit2
Remove unintentional changes to WKContentViewInteraction.mm
introduced in r169500.
Unreviewed.
- UIProcess/ios/WKContentViewInteraction.mm:
(+[WKAutocorrectionContext autocorrectionContextWithData:markedText:selectedText:afterText:selectedRangeInMarkedText:]):
- 1:22 PM Changeset in webkit [169542] by
-
- 3 edits in trunk/Source/WebKit2
Address some review comments on bug 133408
https://bugs.webkit.org/show_bug.cgi?id=133410
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKBackForwardListItem.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- 1:08 PM Changeset in webkit [169541] by
-
- 4 edits1 move in trunk
Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
https://bugs.webkit.org/show_bug.cgi?id=133455
Reviewed by Timothy Hatcher.
PerformanceTests:
- Speedometer/: Renamed from DoYouEvenBench.
- Skipped: Updated the path for InteractiveRunner.html
Tools:
Since the perf. dashboard doesn't support following renamed benchmarks,
keep reporting Speedometer results as DoYouEvenBench results.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(_generate_results_dict):
- 12:57 PM Changeset in webkit [169540] by
-
- 6 edits4 adds in trunk/PerformanceTests
Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
https://bugs.webkit.org/show_bug.cgi?id=133455
Reviewed by Timothy Hatcher.
Renamed the benchmark to Speedometer and added the new look designed by Timothy Hatcher.
Also changed the unit of measurements from milliseconds to runs-per-minute averaged over the number
of the benchmark suites (7 for 1.0). You can divide 420000 by the old benchmark score (in milliseconds)
to get the new value for the set of tests that are enabled by default in 1.0. You can continue to see
results in milliseconds on Full.html#ms.
- DoYouEvenBench/Full.html: Added a bunch of sections and the description of the benchmark.
- DoYouEvenBench/resources/benchmark-report.js: Remove the newly added content when ran inside a DRT or
WTR so that run-perf-tests wouldn't error.
- DoYouEvenBench/resources/benchmark-runner.js:
(BenchmarkRunner.prototype._appendFrame): Call a newly added willAddTestFrame callback when it exists.
- DoYouEvenBench/resources/gauge.png: Added.
- DoYouEvenBench/resources/gauge@2x.png: Added.
- DoYouEvenBench/resources/logo.png: Added.
- DoYouEvenBench/resources/logo@2x.png: Added.
- DoYouEvenBench/resources/main.css: Replaced the style.
- DoYouEvenBench/resources/main.js:
(window.benchmarkClient.willAddTestFrame): Place the iframe right where #testContainer is shown.
(window.benchmarkClient.willRunTest): Show the name of the suite (e.g. EmberJS-TodoMVC) to run next.
(window.benchmarkClient.didRunSuites):
(window.benchmarkClient.willStartFirstIteration): Initialize _timeValues and _finishedTestCount now that
we have an UI to run the benchmark multiple times without reloading the page.
(window.benchmarkClient.didFinishLastIteration): Split into smaller pieces.
(window.benchmarkClient._computeResults): Computes the mean and the statistics for the given time values,
and also format them in a human readable form.
(window.benchmarkClient._computeResults.totalTimeInDisplayUnit): Converts ms to runs/min.
(window.benchmarkClient._computeResults.sigFigFromPercentDelta): Given a percentage error (e.g. 1%),
returns the number of significant digits required for the mean.
(window.benchmarkClient._computeResults.toSigFigPrecision): Calls toPrecision with the specified precision
constrained to be at least the number of non-decimal digits and at most 6.
(window.benchmarkClient._addDetailedResultsRow): Renamed from _addResult. It now takes the table to which
to add a row and the iteration number.
(window.benchmarkClient._updateGaugeNeedle): Added. Controls the angle of the speed indicator.
(window.benchmarkClient._populateDetailedResults): Added.
(window.benchmarkClient.prepareUI): Added. It adds an event listener to show a specified section when
the push state of the document changes, and shows a warning sign when the view port size is too small.
We do this inside a callback to avoid running it inside DRT / WTR.
(startBenchmark):
(showSection): Added.
(startTest): Added.
(showResultsSummary): Added.
(showResultDetails): Added.
(showAbout): Added.
- 12:57 PM Changeset in webkit [169539] by
-
- 2 edits in trunk/Source/WebCore
Further unreviewed GTK build fix after r169536.
Update the m_duration contructor in MediaSourceGStreamer.
- platform/graphics/gstreamer/MediaSourceGStreamer.cpp:
(WebCore::MediaSourceGStreamer::MediaSourceGStreamer):
- 12:50 PM Changeset in webkit [169538] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] -[WKWebView activeURL] is unused
https://bugs.webkit.org/show_bug.cgi?id=133440
Reviewed by Mark Rowe.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView activeURL]): Deleted.
- UIProcess/API/Cocoa/WKWebViewPrivate.h: Removed the property declaration.
- 12:42 PM Changeset in webkit [169537] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed GTK build fix after r169536.
Update MediaSourceGStreamer to match new duration parameters.
- platform/graphics/gstreamer/MediaSourceGStreamer.cpp:
(WebCore::MediaSourceGStreamer::setDuration): Ditto.
- platform/graphics/gstreamer/MediaSourceGStreamer.h:
- platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
- 11:58 AM Changeset in webkit [169536] by
-
- 11 edits in trunk/Source/WebCore
[MSE][Mac] Media does not generate 'ended' event when playing to duration.
https://bugs.webkit.org/show_bug.cgi?id=133452
Reviewed by Eric Carlson.
Add a boundaryTimeObserver to the AVSampleBufferRenderSynchronizer to detect when
playback crosses the duration boundary, and pause in that event. Also refuse to begin
playback if the currentTime is beyond the duration. Also, pause playback if duration
becomes less than currentTime.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::~MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentMediaTime):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentTimeDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged):
Update MediaSource::duration() and ::setDuration() to take and give MediaTimes rather than doubles:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::duration): double -> MediaTime.
(WebCore::MediaSource::setDuration): Ditto.
(WebCore::MediaSource::streamEndedWithError): Ditto.
- platform/graphics/MediaSourcePrivate.h: Ditto.
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
(WebCore::MediaSourcePrivateAVFObjC::MediaSourcePrivateAVFObjC): Ditto.
(WebCore::MediaSourcePrivateAVFObjC::duration): Ditto.
(WebCore::MediaSourcePrivateAVFObjC::setDuration): Ditto.
- platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::MockMediaPlayerMediaSource): Ditto.
(WebCore::MockMediaPlayerMediaSource::maxTimeSeekableDouble): Ditto.
(WebCore::MockMediaPlayerMediaSource::durationDouble): Ditto.
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime): Ditto.
(WebCore::MockMediaPlayerMediaSource::updateDuration): Ditto.
- platform/mock/mediasource/MockMediaPlayerMediaSource.h:
- platform/mock/mediasource/MockMediaSourcePrivate.cpp:
(WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate): Ditto.
(WebCore::MockMediaSourcePrivate::duration): Ditto.
(WebCore::MockMediaSourcePrivate::setDuration): Ditto.
- platform/mock/mediasource/MockMediaSourcePrivate.h:
- 11:19 AM Changeset in webkit [169535] by
-
- 2 edits in trunk/LayoutTests
Unreviewed TestExpectations gardening after r169532.
Update fast/table/border-collapsing/collapsed-borders-adjoining-sections.html
from [ Failure ] to [ ImageOnlyFailure ].
- 10:39 AM Changeset in webkit [169534] by
-
- 11 edits in trunk/Source/WebCore
Rename ImagePaintingContext to ImagePaintingOptions.
https://bugs.webkit.org/show_bug.cgi?id=133451
Reviewed by Simon Fraser.
No change in functionality.
- WebCore.exp.in:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):
- platform/graphics/GraphicsContext.h:
(WebCore::ImagePaintingOptions::ImagePaintingOptions):
(WebCore::ImagePaintingContext::ImagePaintingContext): Deleted.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintSnapshotImage):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paintSnapshot):
- 10:22 AM Changeset in webkit [169533] by
-
- 6 edits5 adds1 delete in trunk/Source/WebKit2
Restructure initial distinct sandbox profiles
https://bugs.webkit.org/show_bug.cgi?id=133415
Reviewed by Alexey Proskuryakov.
Add support for manually instantiating the network and
content process sandboxes, and add initial profiles.
These profiles are completely generic so we can make sure
nothing is broken by enabling them.
This also adds a target to the WebKit2 project to correctly
process the profiles.
- DatabaseProcess/ios/DatabaseProcessIOS.mm:
(WebKit::DatabaseProcess::initializeSandbox):
- DatabaseProcess/ios/com.apple.WebKit.DatabasesIOS.sb: Removed.
- NetworkProcess/ios/NetworkProcessIOS.mm:
(WebKit::NetworkProcess::initializeSandbox):
- Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb: Added.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: Added.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Added.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::initializeSandbox):
- 9:37 AM Changeset in webkit [169532] by
-
- 4 edits in trunk
REGRESSION (r154622): Borders disappear when hovering over cells in table
https://bugs.webkit.org/show_bug.cgi?id=133057
<rdar://problem/15922359>
Reviewed by Tim Horton.
Source/WebCore:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders): Revert recent
non-edge collapsed border optimization due to drawing
regressions.
LayoutTests:
- TestExpectations: Mark the test we added in r154622 as failing
until we provide a permanent fix.
- 9:05 AM Changeset in webkit [169531] by
-
- 14 edits in trunk/Source/WebCore
Provide better encapsulation for image related painting properties.
https://bugs.webkit.org/show_bug.cgi?id=133434
Reviewed by Darin Adler.
Image related drawing property list keeps growing for the functions below and results in
multiple overloadings with seemingly random default parameters.
GraphicsContext::drawImage()
GraphicsContext::drawTiledImage()
GraphicsContext::drawImageBuffer()
This patch provides encapsulation for the image drawing properties. Encapsulation ensures that
introducing a new property does not result in yet another overloaded function.
No change in functionality.
- WebCore.exp.in:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):
- platform/graphics/GraphicsContext.h:
(WebCore::ImagePaintingContext::ImagePaintingContext):
- platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::endShadowLayer):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::draw):
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformApplySoftware):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintSnapshotImage):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paintSnapshot):
- 8:03 AM Changeset in webkit [169530] by
-
- 14 edits in trunk/Source/WebCore
Unreviewed, rolling out r169529.
https://bugs.webkit.org/show_bug.cgi?id=133447
caused assert in drawImage() (Requested by zalan on #webkit).
Reverted changeset:
"Provide better encapsulation for image related painting
properties."
https://bugs.webkit.org/show_bug.cgi?id=133434
http://trac.webkit.org/changeset/169529
- 7:23 AM Changeset in webkit [169529] by
-
- 14 edits in trunk/Source/WebCore
Provide better encapsulation for image related painting properties.
https://bugs.webkit.org/show_bug.cgi?id=133434
Reviewed by Darin Adler.
Image related drawing property list keeps growing for the functions below and results in
multiple overloadings with seemingly random default parameters.
GraphicsContext::drawImage()
GraphicsContext::drawTiledImage()
GraphicsContext::drawImageBuffer()
This patch provides encapsulation for the image drawing properties. Encapsulation ensures that
introducing a new property does not result in yet another overloaded function.
No change in functionality.
- WebCore.exp.in:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):
- platform/graphics/GraphicsContext.h:
(WebCore::ImagePaintingContext::ImagePaintingContext):
- platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::endShadowLayer):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::draw):
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformApplySoftware):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintSnapshotImage):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paintSnapshot):
- 3:55 AM Changeset in webkit [169528] by
-
- 6 edits2 adds in trunk
Add mock DTMFSender support.
https://bugs.webkit.org/show_bug.cgi?id=133298
Patch by Kiran <kiran.guduru@samsung.com> on 2014-06-02
Reviewed by Eric Carlson.
Source/WebCore:
Implemented mock implementation for RTCPeerConnectionHandler. Now creating
RTCDTMFSenderHandlerMock and returning while creating DTMFSender instead of
returning null.
Test: fast/mediastream/RTCPeerConnection-dtmf.html.
- CMakeLists.txt:
- platform/mock/RTCDTMFSenderHandlerMock.cpp: Added.
(WebCore::RTCDTMFSenderHandlerMock::RTCDTMFSenderHandlerMock):
(WebCore::RTCDTMFSenderHandlerMock::setClient):
(WebCore::RTCDTMFSenderHandlerMock::insertDTMF):
- platform/mock/RTCDTMFSenderHandlerMock.h: Added.
- platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::createDTMFSender):
LayoutTests:
- fast/mediastream/RTCPeerConnection-dtmf-expected.txt:
- fast/mediastream/RTCPeerConnection-dtmf.html:
- 1:31 AM Changeset in webkit [169527] by
-
- 2 edits in trunk/Source/WebCore
[GTK] media controls should prevent 'click' events from reaching the page
https://bugs.webkit.org/show_bug.cgi?id=133402
Reviewed by Eric Carlson.
When handling events, we events we need to return true in order
that the superclass gets the value and prevents the execution of
the default event handler in the page.
Test: media/media-controls-cancel-events.html
- Modules/mediacontrols/mediaControlsGtk.js:
(ControllerGtk.prototype.handleMuteButtonMouseOver):
(ControllerGtk.prototype.handleVolumeBoxMouseOut):
(ControllerGtk.prototype.handleCaptionButtonClicked):
(ControllerGtk.prototype.handleCaptionButtonMouseOver):
(ControllerGtk.prototype.handleCaptionButtonShowMenu):
(ControllerGtk.prototype.handleCaptionButtonMouseOut):
(ControllerGtk.prototype.handleCaptionMouseOut): Return true to
prevent forwarding the event execution.
- 12:32 AM Changeset in webkit [169526] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Below test cases are passing after r169403.
- fast/dom/webtiming-document-open.html
- fast/dom/webtiming-navigate-within-document.html
- platform/efl/TestExpectations:
- 12:00 AM Changeset in webkit [169525] by
-
- 3 edits8 adds in trunk
CSS JIT: add support for the "not" pseudo class
https://bugs.webkit.org/show_bug.cgi?id=133314
Source/WebCore:
Patch by Yusuke Suzuki <Yusuke Suzuki> on 2014-06-02
Reviewed by Benjamin Poulain.
Add :not pseudo class support to CSS JIT. Current implementation
doesn't support visitedMatchType. So when link pseudo class appears in
:not sub fragment, fallback to the non-JIT implementation.
Tests: fast/selectors/not-active-hover-quirks.html
fast/selectors/not-active-hover-strict.html
fast/selectors/pseudo-class-not.html
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::constructFragments):
(WebCore::SelectorCompiler::minimumRegisterRequirements):
(WebCore::SelectorCompiler::computeBacktrackingInformation):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::fragmentOnlyMatchesLinksInQuirksMode):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementDataMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesNotPseudoClass):
(WebCore::SelectorCompiler::SelectorCodeGenerator::computeBacktrackingInformation): Deleted.
LayoutTests:
Add :not pseudo class support to CSS JIT. Current implementation
doesn't support visitedMatchType. So when link pseudo class appears in
:not sub fragment, fallback to the non-JIT implementation.
Patch by Yusuke Suzuki <Yusuke Suzuki> on 2014-06-02
Reviewed by Benjamin Poulain.
- fast/selectors/not-active-hover-quirks-expected.txt: Added.
- fast/selectors/not-active-hover-quirks.html: Added.
- fast/selectors/not-active-hover-strict-expected.txt: Added.
- fast/selectors/not-active-hover-strict.html: Added.
- fast/selectors/pseudo-class-not-expected.txt: Added.
- fast/selectors/pseudo-class-not.html: Added.
- fast/selectors/resources/not-hover-active-quirks-utility.js: Added.
(testQuerySelector):
(test):
- fast/selectors/resources/not-hover-active-strict-utility.js: Added.
(testQuerySelector):
(test):
Jun 1, 2014:
- 11:52 PM Changeset in webkit [169524] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
gradient-background-leakage-hidpi.html and canvas-as-image-hidpi.html pass after r169445.
- platform/efl-wk2/TestExpectations:
- 10:16 PM Changeset in webkit [169523] by
-
- 19 edits2 adds in trunk
[MSE] Appends of overlapping sample data do not clear existing samples properly.
https://bugs.webkit.org/show_bug.cgi?id=133435
Reviewed by Darin Adler.
Source/WebCore:
Test: media/media-source/media-source-overlapping-append.html
The MSE spec has a spec error in how it removes overlapping frames. The intention seems to be
to check for overlapping samples only when the incoming sample increases the highest presentation time
field. But due to a mismatch in the range of a sample, defined as [start, end), and the check, which
treats the end as inclusive, the overlapping check is almost never run.
Add the sample comparison logic to match [start, end) ranges, and rename the existing check to differentiate
it from the new one:
- Modules/mediasource/SampleMap.cpp:
(WebCore::SamplePresentationTimeIsInsideRangeComparator::operator()):
(WebCore::SamplePresentationTimeIsWithinRangeComparator::operator()):
(WebCore::SampleMap::findSamplesBetweenPresentationTimes):
(WebCore::SampleMap::findSamplesWithinPresentationRange):
- Modules/mediasource/SampleMap.h:
Update the overlapping check to occur whenever the highest presentation time increases, and update the
logic within that check to catch all overlapping frames.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::bufferedSamplesForTrackID):
- Modules/mediasource/SourceBuffer.h:
- WebCore.exp.in:
Add a dump method to MediaSample so that samples can be easily converted to a string for testing.
- platform/MediaSample.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::MediaSampleAVFObjC::presentationSize):
(WebCore::MediaSampleAVFObjC::dump):
Update the Mock MSE implementation to pass along a "generation" field, to aid in testing.
- platform/mock/mediasource/MockBox.cpp:
(WebCore::MockSampleBox::MockSampleBox):
- platform/mock/mediasource/MockBox.h:
- platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockMediaSample::dump):
Add a method to internals to dump the buffered samples to string.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::bufferedSamplesForTrackID):
- Modules/mediasource/SourceBuffer.h:
- testing/Internals.cpp:
(WebCore::Internals::bufferedSamplesForTrackID):
- testing/Internals.h:
- testing/Internals.idl:
Source/WTF:
Add a dump method to MediaTime, so that MediaTimes can be easily converted to strings (for logging purposes).
- wtf/MediaTime.cpp:
(WTF::MediaTime::dump):
- wtf/MediaTime.h:
LayoutTests:
- media/media-source/media-source-overlapping-append-expected.txt: Added.
- media/media-source/media-source-overlapping-append.html: Added.
- media/media-source/mock-media-source.js:
- 10:01 PM Changeset in webkit [169522] by
-
- 14 edits6 adds in trunk
getBBox() returns (0,0) when width or height is zero.
https://bugs.webkit.org/show_bug.cgi?id=93290
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2014-06-01
Reviewed by Philip Rogers.
Source/WebCore:
The SVG spec states that a width or height of zero for rects, circles and
ellipses is valid but disables rendering of that shape.
In this case, getBBox() should return the actual bounding box of the element.
Previously, WebKit always returned (0,0,0,0) rather than the
correct bounding box. This patch fixes that.
Rects and ellipses both now follow the same behaviour where
the fall-back code path is only used when the shape will render (e.g. not
when a dimension <= 0).
This necessitates calling calculateRadiiAndCenter for ellipses even
when the calculated values will be discarded in the fall back code path.
But calculateRadiiAndCenter is cheap and this avoids making changes
elsewhere to stop CG drawing a zero width (or height) ellipse.
Tests: svg/custom/getBBox-js-circle-zerodimension.html
svg/custom/getBBox-js-ellipse-zerodimension.html
svg/custom/getBBox-js-rect-zerodimension.html
- rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::updateShapeFromElement):
Only follow fall-back code path when shape renders.
width height==0 is not an error case so calculate bounding box. - rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::updateShapeFromElement):
Only follow fall-back code path when shape renders.
rx ry==0 is not an error case so calculate bounding box. LayoutTests:
- platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt:
- svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
- svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt:
- svg/custom/getBBox-js-circle-zerodimension-expected.txt: Added.
- svg/custom/getBBox-js-circle-zerodimension.html: Added.
- svg/custom/getBBox-js-ellipse-zerodimension-expected.txt: Added.
- svg/custom/getBBox-js-ellipse-zerodimension.html: Added.
- svg/custom/getBBox-js-rect-zerodimension-expected.txt: Added.
- svg/custom/getBBox-js-rect-zerodimension.html: Added.
- 6:53 PM Changeset in webkit [169521] by
-
- 2 edits in trunk/LayoutTests
EFL gardening. Unskip some iframe tests which have passed since buildbot OS bump up.
- platform/efl-wk1/TestExpectations:
- 5:33 PM Changeset in webkit [169520] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Add SPI to get a WebArchive of the WKWebView
<rdar://problem/16748120>
https://bugs.webkit.org/show_bug.cgi?id=133439
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _getWebArchiveDataWithCompletionHandler:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 4:07 PM Changeset in webkit [169519] by
-
- 2 edits in trunk/Source/WebCore
Don't scroll to non-integral scroll offsets
https://bugs.webkit.org/show_bug.cgi?id=133436
<rdar://problem/17088336>
Reviewed by Darin Adler.
With the gradual migration of scroll offsets to floating point, we ended
up with a fully floating point code path been event scroll deltas and
setting scroll positions in the scrolling tree.
With some input devices (e.g. Logitech scrollwheel mice), the scroll deltas
come in with non-integral values, and that caused the scroll offset to be non-integral,
resulting in fuzzy layer contents. So round the scroll position.
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollPosition):
- 3:31 PM Changeset in webkit [169518] by
-
- 20 edits in trunk/Source
Add a LazyNeverDestroyed class template and use it
https://bugs.webkit.org/show_bug.cgi?id=133425
Reviewed by Darin Adler.
Source/JavaScriptCore:
- dfg/DFGFunctionWhitelist.cpp:
(JSC::DFG::FunctionWhitelist::ensureGlobalWhitelist):
- dfg/DFGFunctionWhitelist.h:
Source/WebCore:
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::guidMutex):
- crypto/CryptoAlgorithmRegistry.cpp:
(WebCore::registryMutex):
- inspector/WorkerDebuggerAgent.cpp:
- loader/CrossOriginAccessControl.cpp:
(WebCore::isOnAccessControlResponseHeaderWhitelist):
- platform/network/NetworkStateNotifier.cpp:
(WebCore::networkStateNotifier):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::DefaultSharedWorkerRepository::instance):
- workers/DefaultSharedWorkerRepository.h:
- workers/WorkerThread.cpp:
(WebCore::threadSetMutex):
- xml/XMLHttpRequest.cpp:
(WebCore::staticData):
Source/WebKit2:
- Shared/mac/SecItemShim.cpp:
(WebKit::responseMap):
Source/WTF:
LazyNeverDestroyed is similar to NeverDestroyed, except it's lazily constructed
by calling construct(). This makes it useful for using inside std::call_once functions.
- wtf/Forward.h:
- wtf/NeverDestroyed.h:
(WTF::LazyNeverDestroyed::construct):
(WTF::LazyNeverDestroyed::operator T&):
(WTF::LazyNeverDestroyed::get):
(WTF::LazyNeverDestroyed::asPtr):
(WTF::LazyNeverDestroyed::MaybeRelax::MaybeRelax):
- wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
(WTF::atomicallyInitializedStaticMutex):
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::cachedCollatorMutex):
- 2:12 PM Changeset in webkit [169517] by
-
- 3 edits in trunk/PerformanceTests
DYEBench: Move test states into benchmarkClient and remove the closure
https://bugs.webkit.org/show_bug.cgi?id=133438
Reviewed by Benjamin Poulain.
Moved all local variables in the closure wrapping benchmarkClient onto the object itself
and removed the closure to improve the readability of the code.
- DoYouEvenBench/Full.html:
- DoYouEvenBench/resources/main.js:
(window.benchmarkClient.willRunTest):
(window.benchmarkClient.didRunTest):
(window.benchmarkClient.didRunSuites):
(window.benchmarkClient.willStartFirstIteration):
(window.benchmarkClient.didFinishLastIteration):
(window.benchmarkClient._addResult): Moved.
(.): Deleted.
- 1:38 PM Changeset in webkit [169516] by
-
- 2 edits2 adds in trunk/PerformanceTests
DYEBench: Split stylesheets and scripts in Full.html into separate files
https://bugs.webkit.org/show_bug.cgi?id=133437
Reviewed by Benjamin Poulain.
Extracted main.js and main.css.
Also fixed a bug in startBenchmark that disabled suites were counted towards the total number of tests.
- DoYouEvenBench/Full.html:
- DoYouEvenBench/resources/main.css: Added.
- DoYouEvenBench/resources/main.js: Added.
(.addResult):
(window.benchmarkClient):
(startBenchmark): Renamed from startTest.
- 9:30 AM Changeset in webkit [169515] by
-
- 4 edits4 adds in trunk
Subpixel rendering: Selection gap produces a pixel line overlap on inline boxes.
https://bugs.webkit.org/show_bug.cgi?id=133429
Reviewed by Simon Fraser.
Do not floor logical right/left values when selection gap is calculated for RenderBlocks.
It produces overlapping line/gap because the floored value is intersecting/too far from the
non-floored content selection rect.
Source/WebCore:
Tests: fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html
fast/inline/hidpi-selection-gap-overlaps-inline-selection.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
LayoutTests:
- platform/mac/TestExpectations: add ML failure due to font sizing. (Ahem can't be used here)
- fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl-expected.html: Added.
- fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html: Added.
- fast/inline/hidpi-selection-gap-overlaps-inline-selection-expected.html: Added.
- fast/inline/hidpi-selection-gap-overlaps-inline-selection.html: Added.
- 6:44 AM Changeset in webkit [169514] by
-
- 9 edits in trunk/PerformanceTests
DYEBench: CSS parser warning at line 106 of base.css
https://bugs.webkit.org/show_bug.cgi?id=133433
Reviewed by Maciej Stachowiak.
Removed the old filter CSS property for Internet Explorer. The latest Internet Explorer supports -ms-linear-gradient
on background CSS property anyways.
It's interesting that some of the tests only have -webkit- prefixes. Perhaps we should update those subtests.
- DoYouEvenBench/Full.html:
- DoYouEvenBench/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css:
(#header:before):
- DoYouEvenBench/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.css:
(#header:before):
- DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css:
(#header:before):
- DoYouEvenBench/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.css:
(#header:before):
- DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.css:
(#header:before):
- DoYouEvenBench/resources/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.css:
(#header:before):
- DoYouEvenBench/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.css:
(#header:before):
- 12:01 AM Changeset in webkit [169513] by
-
- 3 edits in trunk/PerformanceTests
DYEBench: Ember.js assertion hit at line 20593
https://bugs.webkit.org/show_bug.cgi?id=133431
Reviewed by Darin Adler.
The assertion was hit because ToDoMVC includes jQuery 2.1 and Ember.js 1.3.1 only recognizes jQuery 2.0.
Port the assertion from Ember.js 1.5.1 to suppress the assertion.
We should update the entire Ember.js at some point but this would do the job for now.
- DoYouEvenBench/Full.html:
- DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:
May 31, 2014:
- 11:26 PM Changeset in webkit [169512] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION (r169412): Garbage pixels when vertical rubber-banding on http://yvoschaap.com/pmarca/
https://bugs.webkit.org/show_bug.cgi?id=133418
<rdar://problem/17065494>
Reviewed by Sam Weinig.
- WebCore.exp.in:
- platform/graphics/FloatPoint.h:
(WebCore::toFloatPoint):
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
The manual tiling code previously adjusted the initial
tiling source rect so that if the pattern was out of phase,
the first row and column would paint only the necessary part
of the tile. However, it did not also adjust the destination rect,
so the tile was painted in entirely the wrong place.
Additional testing (by enabling manual tiling mode for all patterned
images and running all of the layout tests) exposed another bug
where the last row and column would paint too much, which
was resolved by clipping to the outer image's destination rect.
- 11:26 PM Changeset in webkit [169511] by
-
- 2 edits in trunk/LayoutTests
One more missed piece of that last check-in.
- TestExpectations: Removed the flakiness expectation from the
css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size.html
test since that now works reliably.
- 11:25 PM Changeset in webkit [169510] by
-
- 2 edits in trunk/Source/WebKit2
View snapshots are sometimes taken at the wrong scale
https://bugs.webkit.org/show_bug.cgi?id=133419
<rdar://problem/17087497>
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKView.mm:
(-[WKView _takeViewSnapshot]):
Work around <rdar://problem/17084993> by re-requesting the snapshot at
kCGWindowImageNominalResolution if it was captured at the wrong scale.
- 11:14 PM Changeset in webkit [169509] by
-
- 3 edits in trunk/LayoutTests
Try to fix another failure from the previous check-in seen on some bots.
- platform/mac-wk2/TestExpectations: Removed a couple obsolete lines.
- platform/wk2/TestExpectations: Added expectation for filter-hidden-content.svg, which
seems to be affected by the resizing for tests before it.
- 8:48 PM Changeset in webkit [169508] by
-
- 3 edits in trunk/LayoutTests
Fix test failure from the previous check-in.
- fast/dynamic/window-resize-scrollbars-test.html: Add resize handler so this test works
with asynchronous resizing.
- platform/wk2/TestExpectations: Expect failure for the test above; it's showing scrollbars,
and it should not. Before, the test was not running correctly so it seemed to pass.
- 8:04 PM Changeset in webkit [169507] by
-
- 3 edits in trunk/PerformanceTests
DYEBench: Prevent frame flattening on iOS
https://bugs.webkit.org/show_bug.cgi?id=133428
Reviewed by Andreas Kling.
Prevent frame flattening on iOS by setting scrolling=no.
- DoYouEvenBench/Full.html:
- DoYouEvenBench/resources/benchmark-runner.js:
(BenchmarkRunner.prototype._appendFrame):
- 6:34 PM Changeset in webkit [169506] by
-
- 2 edits in trunk/Source/WebCore
CSS JIT cleanup: move two utility functions out of the properties-matcher section
https://bugs.webkit.org/show_bug.cgi?id=133427
Reviewed by Andreas Kling.
Just move the code, no other modification.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::jumpIfNoPreviousAdjacentElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::jumpIfNoNextAdjacentElement):
- 5:01 PM Changeset in webkit [169505] by
-
- 26 edits in trunk
Viewport percentage tests that resize the viewport are flaky
https://bugs.webkit.org/show_bug.cgi?id=133351
Reviewed by Anders Carlsson.
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect): Removed code that explicitly sends a resize event here.
The resize event will be sent as a side effect of layout instead.
(WebCore::FrameView::sendResizeEventIfNeeded): Don't send a resize event until layout is done,
since this is what propagates the new geometry in so the JavaScript code can detect it. Also
simplified the logic and streamlined a little, and added a FIXME about the bad idea here where
the code enqueues an event for an unknown time in the future. Removed the unneeded code that
passes in the DOM window as the target to dispatchWindowEvent, since that gets filled in as the
target by default.
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(sizeWebViewForCurrentTest): Added a call to reset the window origin, which
happens to be stored in the UI delegate object. This is part of resetting the
window position.
- DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
a frame rectangle. The size is stored in the size of the web view itself.
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate resetWindowOrigin]): Added.
(-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
old version would store the frame, but not resize the web view!
(-[UIDelegate webViewFrame:]): Get the size from the web view.
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
- WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
the window.
- WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
window gets resized too, not just the web view.
(WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
window gets resized too, not just the web view.
(WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
LayoutTests:
- css3/viewport-percentage-lengths/resources/resize-test.js:
Added code to compensate for the difference between innerWidth/Height and outerWidth/Height
so this works well in a browser window. Added code to "warm up" so the first resize triggers
a resize event. Tweaked style of the code a bit. Use resize events to avoid flakiness due
to race conditions. One thing I did not fix is the "out of order" problem where all the
test results get written out after the words TEST COMPLETE.
- css3/viewport-percentage-lengths/viewport-percentage-lengths-anonymous-block-expected.txt:
Updated due to changes to the underlying test machinery, and also to show actual expected success.
The old results said PASS with various obviously wrong results.
- css3/viewport-percentage-lengths/viewport-percentage-lengths-anonymous-block.html:
Changed this test to use the shared resize-test.js.
- css3/viewport-percentage-lengths/viewport-percentage-lengths-percent-size-child-expected.txt:
Updated due to changes to the underlying test machinery, and also to show actual expected success.
The old results said PASS with various obviously wrong results.
- css3/viewport-percentage-lengths/viewport-percentage-lengths-percent-size-child.html:
Streamlined this test a little.
- css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size-expected.txt:
Updated due to changes to the underlying test machinery, and also to show actual expected success.
The old results said PASS with various obviously wrong results.
- css3/viewport-percentage-lengths/viewport-percentage-lengths-relative-font-size.html:
Streamlined this test a little.
- css3/viewport-percentage-lengths/viewport-percentage-lengths-resize-expected.txt:
Updated due to changes to the underlying test machinery, and also to show both expected success,
and some expected failures. These failures were going unnoticed before since the test didn't
successfully do any resizing of the web view.
- css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html:
Streamlined this test a little.
- fast/dom/Window/window-resize-contents-expected.txt: Updated to reflect the test actually
resizing. The old test results expected no resizing to occur.
- fast/dom/Window/window-resize-contents.html: Updated to use a resize event handler so the
test can successfully test asynchronous resizes like the ones done by WebKit2.
- fast/dom/rtl-scroll-to-leftmost-and-resize.html: Updated to use a resize event handler so
this can test asynchronous resizes. Also fixed code that was treating the arguments to resizeTo
as if they were inner coordinates rather than outer. However, the bug this tests for has not
been fixed, so need to expect failures.
- platform/mac/TestExpectations: Added a failure expection for the test above.
- platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.png: Updated to expect a result
that successfully resized.
- platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.txt: Ditto.
- 1:29 PM Changeset in webkit [169504] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] WebKit2.framework is unused
https://bugs.webkit.org/show_bug.cgi?id=133424
Reviewed by Anders Carlsson.
- Configurations/WebKit2.xcconfig: Set SKIP_INSTALL to YES when targeting iOS.
- 10:41 AM Changeset in webkit [169503] by
-
- 2 edits in trunk/Source/WebCore
Don't use std::mutex::try_lock to check if we own a mutex
https://bugs.webkit.org/show_bug.cgi?id=133421
Reviewed by Dan Bernstein.
According the C++ standard, calling try_lock on a mutex that's already owned by the current thread
is undefined behavior, so don't do that.
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::guidToVersionMap):
(WebCore::updateGuidVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
May 30, 2014:
- 10:12 PM Changeset in webkit [169502] by
-
- 2 edits1 add in trunk/PerformanceTests
DYEBench spits out 404 errors for learn.json
https://bugs.webkit.org/show_bug.cgi?id=133416
Reviewed by Oliver Hunt.
Add an empty learn.json file so that it won't cause a 404 error when hosted on a http server.
Bumped the version number to 0.12.
- DoYouEvenBench/Full.html:
- DoYouEvenBench/resources/todomvc/learn.json:
- 5:56 PM Changeset in webkit [169501] by
-
- 8 edits in trunk/Source/WebKit2
[iOS][WK2] When a page does not finish rotation before the end of the animation, synchronize explicitely
https://bugs.webkit.org/show_bug.cgi?id=133364
<rdar://problem/17026333>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-05-30
Reviewed by Sam Weinig.
When a page that does layout on rotation does not respond before the end of the animation, we end up with
a completely inconsistent state on the UIProcess (because it is unware of the new states).
The perfect way to fix this would be to make animated resize transactional and have the WebProcess resolve
conflicts. That is very complicated and the issue is uncommon, so this patch does not do that.
This patch force the synchronization whenever we finish the animation before we heard back
from the WebProcess.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _endAnimatedResize]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::dynamicViewportSizeUpdate):
(WebKit::WebPageProxy::synchronizeDynamicViewportUpdate):
(WebKit::WebPageProxy::dynamicViewportUpdateChangedTarget):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::synchronizeDynamicViewportUpdate):
- 5:12 PM Changeset in webkit [169500] by
-
- 12 edits in trunk/Source
REGRESSION (WebKit2): space space to insert period doesn't work in web forms.
https://bugs.webkit.org/show_bug.cgi?id=133413
<rdar://problem/16948333>
Reviewed by Benjamin Poulain.
Source/WebCore:
Adding utility functions and their exports.
- WebCore.exp.in:
- editing/TextIterator.cpp:
(WebCore::plainTextReplacingNoBreakSpace):
- editing/TextIterator.h:
- editing/VisibleUnits.cpp:
(WebCore::charactersAroundPosition):
(WebCore::characterBeforePosition): Deleted.
- editing/VisibleUnits.h:
Source/WebKit2:
iOS TextInput needs to know about content surrounding the
current position while editing. Since we don't want to
query this information synchronously when asked, we cache it
as part of the EditorState. EditorState now contains a vector of
three characters representing the content after, before and two
position before the caret position.
The patch also replaces all calls to plainText with plainTextReplacingNoBreakSpace
to work well with iOS text input.
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
- Shared/EditorState.h:
(WebKit::EditorState::EditorState):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _characterInRelationToCaretSelection:]):
(+[WKAutocorrectionContext autocorrectionContextWithData:markedText:selectedText:afterText:selectedRangeInMarkedText:]):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestDictationContext):
(WebKit::WebPage::replaceSelectedText):
(WebKit::WebPage::replaceDictatedText):
(WebKit::WebPage::requestAutocorrectionData):
(WebKit::WebPage::syncApplyAutocorrection):
(WebKit::computeAutocorrectionContext):
- 4:10 PM Changeset in webkit [169499] by
-
- 1 copy in tags/Safari-537.77.3
Tagging it
- 4:03 PM Changeset in webkit [169498] by
-
- 2 edits in trunk/Source/WebCore
Cleanup temporary setting of image interpolation quality in GraphicsContext::drawImage*
https://bugs.webkit.org/show_bug.cgi?id=133407
Reviewed by Darin Adler.
Add helper class to set/reset image interpolation quality value.
No change in functionality.
- platform/graphics/GraphicsContext.cpp:
(WebCore::InterpolationQualityMaintainer::InterpolationQualityMaintainer):
(WebCore::InterpolationQualityMaintainer::~InterpolationQualityMaintainer):
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):
- 2:51 PM Changeset in webkit [169497] by
-
- 2 edits in trunk/Source/WebKit2
Fixed the build by adding back a declaration I deleted by accident :(.
Unreviewed.
- UIProcess/API/Cocoa/WKWebView.h:
- 2:41 PM Changeset in webkit [169496] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Fixed some ChangeLog grammar.
- 2:41 PM Changeset in webkit [169495] by
-
- 16 edits in trunk/Source/WebKit2
Unreviewed, rolling in r169490.
I change a non-ASCII apostrophe to ASCII.
Restored changeset:
"Some more copy-editing of the Modern WebKit headerdoc"
https://bugs.webkit.org/show_bug.cgi?id=133408
http://trac.webkit.org/changeset/169490
- UIProcess/API/Cocoa/WKBackForwardList.h:
- UIProcess/API/Cocoa/WKBackForwardListItem.h:
- UIProcess/API/Cocoa/WKFrameInfo.h:
- UIProcess/API/Cocoa/WKNavigation.h:
- UIProcess/API/Cocoa/WKNavigationAction.h:
(NS_ENUM):
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
(NS_ENUM):
- UIProcess/API/Cocoa/WKNavigationResponse.h:
- UIProcess/API/Cocoa/WKPreferences.h:
- UIProcess/API/Cocoa/WKProcessPool.h:
- UIProcess/API/Cocoa/WKScriptMessage.h:
- UIProcess/API/Cocoa/WKScriptMessageHandler.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- 2:25 PM Changeset in webkit [169494] by
-
- 2 edits in branches/safari-537.77-branch/Source/WebCore
Supplementary build fix for <rdar://problem/16848509>, borrowed from <rdar://problem/16701806>.
- 2:07 PM Changeset in webkit [169493] by
-
- 16 edits in trunk/Source/WebKit2
Unreviewed, rolling out r169490.
It broke the build with a mysterious warning about ASCII
Reverted changeset:
"Some more copy-editing of the Modern WebKit headerdoc"
https://bugs.webkit.org/show_bug.cgi?id=133408
http://trac.webkit.org/changeset/169490
- 1:59 PM Changeset in webkit [169492] by
-
- 2 edits in trunk/Source/WebCore
Support -apple-system-font on OS X
https://bugs.webkit.org/show_bug.cgi?id=133382
Addressing post-review comments.
- platform/mac/WebFontCache.mm:
(+[WebFontCache internalFontWithFamily:traits:weight:size:]):
- 12:26 PM Changeset in webkit [169491] by
-
- 2 edits in trunk/Source/WebCore
Remove repetitive header in HTMLInputElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=133376
Patch by Prashant Hiremath <hiremathprashants@gmail.com> on 2014-05-30
Reviewed by Anders Carlsson.
It is just removal repeative headers hence no test needed.
- html/HTMLInputElement.cpp:
- 12:11 PM Changeset in webkit [169490] by
-
- 16 edits in trunk/Source/WebKit2
Some more copy-editing of the Modern WebKit headerdoc
https://bugs.webkit.org/show_bug.cgi?id=133408
Reviewed by Beth Dakin.
A copy-editor suggested some edits to the headerdoc for clarity,
style, and formatting.
I reviewed the edits and accepted about 80% of them.
- UIProcess/API/Cocoa/WKBackForwardList.h:
- UIProcess/API/Cocoa/WKBackForwardListItem.h:
- UIProcess/API/Cocoa/WKFrameInfo.h:
- UIProcess/API/Cocoa/WKNavigation.h:
- UIProcess/API/Cocoa/WKNavigationAction.h:
(NS_ENUM):
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
(NS_ENUM):
- UIProcess/API/Cocoa/WKNavigationResponse.h:
- UIProcess/API/Cocoa/WKPreferences.h:
- UIProcess/API/Cocoa/WKProcessPool.h:
- UIProcess/API/Cocoa/WKScriptMessage.h:
- UIProcess/API/Cocoa/WKScriptMessageHandler.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- 11:19 AM Changeset in webkit [169489] by
-
- 2 edits in trunk/Tools
Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
https://bugs.webkit.org/show_bug.cgi?id=133409
Reviewed by Filip Pizlo.
Handle creating a tarball the same way as running remote when processing
paths in prepareBundle.
- Scripts/run-jsc-stress-tests:
- 9:49 AM Changeset in webkit [169488] by
-
- 4 edits in trunk/LayoutTests
[GTK] Don't use logAccessibilityEvents() in aria-slider-required-attributes.html
https://bugs.webkit.org/show_bug.cgi?id=133405
Reviewed by Chris Fleizach.
Change the test to use addNotificationListener() instead.
- platform/gtk/TestExpectations: Removed failure expectation
- platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Updated
- platform/gtk/accessibility/aria-slider-required-attributes.html: Updated
- 9:47 AM Changeset in webkit [169487] by
-
- 6 edits in trunk
[ATK] Deprecate usage of logAccessibilityEvents() in layout tests
https://bugs.webkit.org/show_bug.cgi?id=132280
Reviewed by Chris Fleizach.
Tools:
Remove implementation of logAccessibilityEvents() for ATK based
ports, as this has proved to be a flaky method of checking that
ATK events are being properly emitted. Instead, it's better to use
the addNotificationListener() functions and provide a JS callback
to check that the right events are being emmitted from the tests.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::logAccessibilityEvents): Replaced
with dummy implementation.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
LayoutTests:
Removed 36 flaky expectations from TestExpectations for tests that
were ocassionally showing the output of logAccessibilityEvents()
even if they did not make use of that feature (thus the flakiness).
- platform/gtk/TestExpectations: Updated.
- 8:43 AM Changeset in webkit [169486] by
-
- 3 edits in trunk/Source/WebKit2
Crash loading skydrive.com (assertion under RemoteLayerTreeDisplayRefreshMonitor)
https://bugs.webkit.org/show_bug.cgi?id=133370
<rdar://problem/17061361>
Reviewed by Darin Adler.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::willDestroyDisplayRefreshMonitor):
(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
Post-landing review comments from Darin noted that checking if the
DrawingArea's m_displayRefreshMonitors contains the monitor in the
list to notify is insufficient, because a new one could have been
added with the same address. Instead, copy the HashSet, removing
at random from it and firing didUpdateLayers, but *also* removing
from it in the willDestroyDisplayRefreshMonitor callback.
This is very similar to what DisplayRefreshMonitor itself does internally
(we don't have to duplicate its code to avoid re-entry because it is
already impossible to re-enter didUpdate).
- 8:20 AM Changeset in webkit [169485] by
-
- 3 edits in trunk/Tools
[ATK] Deprecate usage of logAccessibilityEvents() in layout tests
https://bugs.webkit.org/show_bug.cgi?id=132280
Rubber stamped by Carlos Garcia Campos.
Fix two small issues with previous patch (r169483), that caused some tests to break.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
duplicated entry.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
- 7:16 AM Changeset in webkit [169484] by
-
- 7 edits in trunk/Source/WebCore
Remove redundant GraphicsContext::drawImage() function.
https://bugs.webkit.org/show_bug.cgi?id=133347
Reviewed by Simon Fraser.
There are 2 GraphicsContext::drawImage functions with very similar parameter list. This looks
to be a source of confusion and results in passing unneeded parameters.
No change in functionality.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::drawImageToContext):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
- platform/graphics/GraphicsContext.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::updateContents):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintNinePieceImage):
- 3:58 AM Changeset in webkit [169483] by
-
- 10 edits6 adds in trunk
Tools: [ATK] Added new accessibility signal: text-caret-moved.
Make AccessibilityUIElement.setSelectedTextRange work
as atk_text_set_caret_offset when given offset == 0.
https://bugs.webkit.org/show_bug.cgi?id=132527
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-05-30
Reviewed by Mario Sanchez Prada.
text-caret-moved signal in accessibilityController is needed to
implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
as LayoutTests. Add the signal to the controller.
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(setSelectedTextRange): Change return type to bool.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(axObjectEventListener): Add notification name AXTextCaretMoved, allow
for extra arguments passed to handler and use it for text-caret-moved offset.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connect callback to new listener for ATK:AtkText:text-caret-moved.
Refactor so that failures be reported.
Initialize atk interfaces before trying to connect to them, see
https://bugzilla.gnome.org/show_bug.cgi?id=729922
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Simplify code by using a vector in place of dozen variables.
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
Comment about not synchronizing with accessibilityController.
LayoutTests: [ATK] Convert caret offset tests from testatk.c.
https://bugs.webkit.org/show_bug.cgi?id=132527
Patch by Jarek Czekalski <Jarek Czekalski> on 2014-05-30
Reviewed by Mario Sanchez Prada.
The tests are replicated from testatk.c file, functions
testWebkitAtkCaretOffsets()
testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces()
The file was present in webkit1. Removed from trunk in r166977, so
the last version was
https://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c?rev=166976
What could not be verified in the same way:
- Whether element implements ATK_TEXT. If setCaretOffset
succeeds, it confirms that element is text as well. But in cases
when setCaretOffset must fail I see no way to confirm it is text
element.
- Whether position is correct through a call to
atk_text_get_caret_offset. text-caret-moved signal value is
tested instead.
Anyway these cases don't look crucial, so they are skipped.
- platform/gtk/resources/atk-helpers.js: Added.
(setCaretOffset): Added.
- platform/gtk/accessibility/caret-offsets-and-extraneous-white-spaces-expected.txt: Added.
- platform/gtk/accessibility/caret-offsets-and-extraneous-white-spaces.html: Added.
- platform/gtk/accessibility/caret-offsets-expected.txt: Added.
- platform/gtk/accessibility/caret-offsets.html: Added.
May 29, 2014:
- 7:11 PM Changeset in webkit [169482] by
-
- 5 edits in branches/safari-537.77-branch/Source
Bump versioning to 537.77.3
- 5:56 PM Changeset in webkit [169481] by
-
- 1 copy in tags/Safari-537.77.2
New TaG
- 5:52 PM Changeset in webkit [169480] by
-
- 2 edits in trunk/Source/WTF
Enable css jit by default on arm64.
https://bugs.webkit.org/show_bug.cgi?id=133246
<rdar://problem/17073407>
Reviewed by Benjamin Poulain.
- wtf/Platform.h:
Added arm64 to list of supported architectures.
- 5:25 PM Changeset in webkit [169479] by
-
- 4 edits in trunk/Source/WebCore
Prepare css jit for arm64 and other architectures.
https://bugs.webkit.org/show_bug.cgi?id=133394
Reviewed by Benjamin Poulain.
- cssjit/FunctionCall.h:
(WebCore::FunctionCall::swapArguments):
- cssjit/RegisterAllocator.h:
Use a designated temporary register on arm64 to prevent using a deallocated argument register to swap argument registers in.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
Added assertion to make sure there are enough registers.
- 5:15 PM Changeset in webkit [169478] by
-
- 14 edits in trunk/Source/WebCore
CSS JIT: add support for the pseudo classes :hover and :active
https://bugs.webkit.org/show_bug.cgi?id=133295
Reviewed by Andreas Kling.
This patch adds compilation support for :hover and :active. The code generation of both of them is trivial,
most of the patch is improving the infrastructure and safety.
The document compatibility mode is moved to its own typed enum. This ensure the values are exclusives and
the native type is known (unsigned char here). The values are changes to binary flags to take advantage of
test-and-branch on ARM64 (not used explicitely, it is automatically generated by the MacroAssembler).
The other important refactoring is the code updating the flags on RenderStyle::NonInheritedFlags.
The code was duplicated in some places so it is move into its own function addFlagToElementStyleFromContext().
The generators themself are very simple. First we check the quirks-mode exceptions, that is generally excluded
at compile time because the conditions are almost never met, even in strict mode.
Then we have two cases: style resolution and query selector. Almost everything is just function calls.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorFragment::SelectorFragment):
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagToElementStyleFromContext):
(WebCore::SelectorCompiler::fragmentOnlyMatchesLinksInQuirksMode):
(WebCore::SelectorCompiler::getDocument):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSpecialFailureInQuirksModeForActiveAndHoverIfNeeded):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::elementIsActive):
(WebCore::SelectorCompiler::elementIsActiveForStyleResolution):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
(WebCore::SelectorCompiler::elementIsHovered):
(WebCore::SelectorCompiler::elementIsHoveredForStyleResolution):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsOnlyChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::implicitOpen):
(WebCore::Document::cloneDataFromDocument):
- dom/Document.h:
(WebCore::Document::compatibilityModeMemoryOffset):
(WebCore::Document::inQuirksMode):
(WebCore::Document::inLimitedQuirksMode):
(WebCore::Document::inNoQuirksMode):
(WebCore::Document::compatibilityMode): Deleted.
- html/ImageDocument.cpp:
(WebCore::ImageDocument::ImageDocument):
- html/MediaDocument.cpp:
(WebCore::MediaDocument::MediaDocument):
- html/PluginDocument.cpp:
(WebCore::PluginDocument::PluginDocument):
- html/TextDocument.cpp:
(WebCore::TextDocument::TextDocument):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::setDefaultCompatibilityMode):
(WebCore::HTMLConstructionSite::setCompatibilityMode):
(WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype):
(WebCore::HTMLConstructionSite::insertDoctype):
- html/parser/HTMLConstructionSite.h:
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
- loader/SinkDocument.cpp:
(WebCore::SinkDocument::SinkDocument):
- page/ios/FrameIOS.mm:
(WebCore::Frame::initWithSimpleHTMLDocument):
- rendering/style/RenderStyle.h:
- 5:09 PM Changeset in webkit [169477] by
-
- 2 edits in trunk/Source/WebKit2
-[WKProcessPoolConfiguration setCachePartitionedURLSchemes:] should do a deep copy
https://bugs.webkit.org/show_bug.cgi?id=133393
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration setCachePartitionedURLSchemes:]):
- 4:56 PM Changeset in webkit [169476] by
-
- 2 edits in branches/safari-537.77-branch/Source/WebCore
Build fix for Mavericks
- WebCore.exp.in:
- 4:52 PM Changeset in webkit [169475] by
-
- 34 edits7 adds in trunk
Roll r168668 back in.
<https://bugs.webkit.org/show_bug.cgi?id=132621>
Reviewed by Brent Fulgham.
Source/WebCore:
Tests: fast/events/beforeload-assertion.html
fast/events/beforeload-iframe-crash.html
fast/events/beforeload-input-time-crash.html
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
- dom/Document.h:
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::renderWidgetForJSBindings):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::renderWidgetForJSBindings):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderWidgetForJSBindings):
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::updateEmbeddedObjectsTimerFired):
(WebCore::FrameView::flushAnyPendingPostLayoutTasks):
(WebCore::FrameView::performPostLayoutTasks):
- page/FrameView.h:
- testing/Internals.cpp:
(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
LayoutTests:
- compositing/plugins/composited-plugin.html:
- compositing/plugins/no-backing-store.html:
- fast/dom/beforeload/flash-before-load.html:
- fast/events/beforeload-assertion-expected.txt: Added.
- fast/events/beforeload-assertion.html: Added.
- fast/events/beforeload-iframe-crash-expected.txt: Added.
- fast/events/beforeload-iframe-crash.html: Added.
- fast/events/beforeload-input-time-crash-expected.txt: Added.
- fast/events/beforeload-input-time-crash.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-notype-data.html:
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-nourl-blocked.html:
- http/tests/security/contentSecurityPolicy/object-src-no-url-allowed.html:
- http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html:
- http/tests/security/contentSecurityPolicy/object-src-none-allowed.html:
- http/tests/security/contentSecurityPolicy/object-src-none-blocked.html:
- http/tests/security/contentSecurityPolicy/resources/multiple-iframe-plugin-test.js:
(testImpl.iframe.onload):
(testImpl):
- http/tests/security/mixedContent/insecure-plugin-in-iframe.html:
- platform/mac/plugins/supports-carbon-event-model.html:
- platform/mac/plugins/testplugin-onnew-onpaint.html:
- plugins/get-user-agent-with-null-npp-from-npp-new.html:
- plugins/mouse-click-plugin-clears-selection.html:
- plugins/netscape-plugin-map-data-to-src.html:
- plugins/no-mime-with-valid-extension.html:
- plugins/plugin-initiate-popup-window.html:
- plugins/windowless_plugin_paint_test.html:
- resources/plugin.js: Added.
(runAfterPluginLoad):
- 4:41 PM Changeset in webkit [169474] by
-
- 6 edits in trunk
Support -apple-system-font on OS X
https://bugs.webkit.org/show_bug.cgi?id=133382
Source/WebCore:
Reviewed by Simon Fraser.
Guard on both family names: "-apple-system-font" and "-webkit-system-font"
Test: platform/mac/fast/text/systemFont.html
- platform/mac/WebFontCache.mm:
(+[WebFontCache internalFontWithFamily:traits:weight:size:]):
LayoutTests:
This test makes sure that -apple-system-font is rendered the same way as -webkit-system-font.
Reviewed by Simon Fraser.
- platform/mac-mountainlion/platform/mac/fast/text/systemFont-expected.txt: Updated.
- platform/mac/fast/text/systemFont.html: Tests -apple-system-font in addition to -webkit-system-font.
- platform/mac/platform/mac/fast/text/systemFont-expected.txt: Updated.
- 4:24 PM Changeset in webkit [169473] by
-
- 2 edits in branches/safari-537.77-branch/Source/WebCore
Build fix
- WebCore.exp.in:
- 4:04 PM Changeset in webkit [169472] by
-
- 3 edits3 adds in trunk
Loading <object> from WebArchive crashes
https://bugs.webkit.org/show_bug.cgi?id=133386
<rdar://problem/13345509>
Reviewed by Brady Eidson.
Source/WebCore:
Test: webarchive/loading/object.html
This (a) fixes the crash, and (b) avoids the crash.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::continueAfterContentPolicy):
Some types of substitute data - such as WebArchive - don't contain HTTP result codes,
so let's not drop to <object> fallback content when status is 0.
And if the load somehow failed anyway, don't crash by trying to deliver substitute data
to a finished loader.
LayoutTests:
- webarchive/loading/object-expected.txt: Added.
- webarchive/loading/object.html: Added.
- webarchive/loading/resources/object.webarchive: Added.
- 4:00 PM Changeset in webkit [169471] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Add an instruction on how to backup the database.
https://bugs.webkit.org/show_bug.cgi?id=133391
Rubber-stamped by Andreas Kling.
- Install.md:
- 3:50 PM Changeset in webkit [169470] by
-
- 2 edits in tags/Safari-538.37/Source/WebKit2
Merge r169468. <rdar://problem/17067920>
- 3:47 PM Changeset in webkit [169469] by
-
- 6 edits1 copy in branches/safari-537.77-branch
Merge r166628.
- 3:26 PM Changeset in webkit [169468] by
-
- 2 edits in trunk/Source/WebKit2
Restoring FloatingPointEnvironment initialization that was accidentally rolled out by r169176.
<https://webkit.org/b/133389>
Rubber stamped by Oliver Hunt.
- Shared/ios/ChildProcessIOS.mm:
(WebKit::ChildProcess::platformInitialize):
- 3:10 PM Changeset in webkit [169467] by
-
- 3 edits in trunk/Source/WebCore
[iOS WebGL] Fix depth buffer clearing issue.
https://bugs.webkit.org/show_bug.cgi?id=133388
Patch by Alex Christensen <achristensen@webkit.org> on 2014-05-29
Reviewed by Dean Jackson.
No new tests, but this fixes webgl/1.0.1/conformance/canvas/buffer-preserve-test.html.
- platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer display]):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture):
Moved marking the layer as composited from the mac-only prepareTexture to
the end of [WebGLLayer display] which is called by mac and iOS.
- 2:47 PM Changeset in webkit [169466] by
-
- 4 edits in trunk/Source/WebKit2
Need to notify the keyboard about every KeyDown event.
https://bugs.webkit.org/show_bug.cgi?id=133383
<rdar://problem/16633975>
Reviewed by Benjamin Poulain.
A key down will generate most of the time a call to the keyboard to add input or delete.
But the event could be handled by JavaScript and its default prevented.
We need to notify the keyboard in every case to allow updating its internal state about what has been typed.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::doneWithKeyEvent):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didHandleKeyEvent:]):
- 2:44 PM Changeset in webkit [169465] by
-
- 17 edits in trunk/Source/WebKit2
Roll out r169439. <rdar://problem/17069364>
- 2:38 PM Changeset in webkit [169464] by
-
- 2 edits in branches/safari-537.77-branch/Source/WebCore
Workaround for <rdar://problem/16848509>
Reviewed by David Kilzer.
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
- 2:37 PM Changeset in webkit [169463] by
-
- 17 edits in tags/Safari-538.37/Source/WebKit2
Roll out r169439.
- 1:23 PM Changeset in webkit [169462] by
-
- 2 edits in trunk/Source/WebInspectorUI
Fix an exception in InspectorBackend.Command.prototype.supports.
https://bugs.webkit.org/show_bug.cgi?id=133384
Reviewed by Joseph Pecoraro.
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackend.Command.prototype.supports): Use some not any.
- 1:14 PM Changeset in webkit [169461] by
-
- 2 edits in trunk/Tools
[GTK] Add a WebKit2 Performance bot.
https://bugs.webkit.org/show_bug.cgi?id=132862
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-05-29
Reviewed by Csaba Osztrogonác.
This adds a GTK WebKit2 perf bot.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 1:01 PM Changeset in webkit [169460] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Can’t recover from subframe load errors
https://bugs.webkit.org/show_bug.cgi?id=133385
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Declared new delegate method.
- UIProcess/Cocoa/NavigationState.h: Added flag in m_navigationDelegateMethods struct.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate): Initialize
webViewNavigationDidFailProvisionalLoadInSubframeWithError flag in the delegate methods
struct.
(WebKit::NavigationState::LoaderClient::didFailProvisionalLoadWithErrorForFrame): If the
error occurred in a subframe, invoke the new delegate method.
- 11:40 AM Changeset in webkit [169459] by
-
- 2 edits in trunk/LayoutTests
Gardening: marking js/primitive-property-access-edge-cases.html as crashy.
<https://webkit.org/b/133356>
Not reviewed.
- 11:38 AM Changeset in webkit [169458] by
-
- 2 edits in trunk/Source/WebKit2
Added a missing @result to WKPreferences headerdoc
https://bugs.webkit.org/show_bug.cgi?id=133381
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKPreferences.h:
- 11:24 AM Changeset in webkit [169457] by
-
- 10 edits2 adds in trunk/Source/WebKit2
[Mac] Always use plug-in sandbox with sandboxed clients
https://bugs.webkit.org/show_bug.cgi?id=133358
<rdar://problem/15637695>
Reviewed by Anders Carlsson.
- PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::initializeSandbox):
Refuse to start if parent process is sandboxed, and plug-in process is not going to be.
None of this should run in normal case, because there are also checks on UI process side.
- Shared/Plugins/PluginModuleInfo.h:
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::getPluginInfo):
Added a member to PluginModuleInfo, telling whether the plug-in has a sandbox profile.
- Shared/Plugins/Netscape/mac/PluginInformationMac.mm:
(WebKit::getPlatformPluginModuleInformation): Use the new PluginModuleInfo member,
we no longer need to check the file system here.
- WebKit2.xcodeproj/project.pbxproj:
- Shared/mac/SandboxUtilities.h: Added.
- Shared/mac/SandboxUtilities.cpp: Added. (WebKit::processIsSandboxed):
This code is simple, but include magic is not. Moved it to a separate file to
avoid repeating.
- UIProcess/API/C/mac/WKContextPrivateMac.mm: Removed an unused include.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin): Don't use unsandboxed plug-ins in
sandboxed applications.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformGetLaunchOptions): Don't ever pass disable-sandbox
from sandboxed processes.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::isClientSandboxed):
Use the new shared code in SandboxUtilities.h.
- 11:19 AM Changeset in webkit [169456] by
-
- 2 edits in trunk/Source/WebKit2
Crash loading skydrive.com (assertion under RemoteLayerTreeDisplayRefreshMonitor)
https://bugs.webkit.org/show_bug.cgi?id=133370
<rdar://problem/17061361>
Reviewed by Anders Carlsson.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
Copy the set of refresh monitors so that we don't try to mutate the list we're iterating,
and don't try to fire refresh monitors that were removed in a previous iteration of the loop.
- 11:06 AM Changeset in webkit [169455] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (iOS WebKit2): Find-in-Page doesn't work in subframes
https://bugs.webkit.org/show_bug.cgi?id=133372
<rdar://problem/17045070>
Reviewed by Simon Fraser.
- WebProcess/WebPage/ios/FindControllerIOS.mm:
(WebKit::FindController::willFindString):
(WebKit::FindController::didFailToFindString):
(WebKit::FindController::didHideFindIndicator):
Flip ignoreCompositionSelectionChange and updateAppearanceEnabled on all
frames, not just the main frame, because the found string can be in a subframe.
Ideally we would flip it on/off for each frame as we move the selection between them,
but would require a lot of work (and the overhead of touching each frame shouldn't be significant).
- 10:49 AM Changeset in webkit [169454] by
-
- 2 edits in trunk/LayoutTests
Gardening: marking js/primitive-property-access-edge-cases.html as flaky.
<https://webkit.org/b/133356>
Not reviewed.
- 10:40 AM Changeset in webkit [169453] by
-
- 2 edits in trunk/Tools
Fixed the WebKitTestRunner build after r169452.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize):
- 10:27 AM Changeset in webkit [169452] by
-
- 7 edits in trunk/Source/WebKit2
WKBundleActivateMacFontAscentHack is unused
https://bugs.webkit.org/show_bug.cgi?id=133379
Reviewed by Anders Carlsson.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleActivateMacFontAscentHack): Deleted.
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:
(WebKit::InjectedBundle::activateMacFontAscentHack): Deleted.
- WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
(WebKit::InjectedBundle::activateMacFontAscentHack): Deleted.
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::activateMacFontAscentHack): Deleted.
- 10:09 AM Changeset in webkit [169451] by
-
- 5 edits in trunk/Source
Versioning.
- 9:41 AM Changeset in webkit [169450] by
-
- 3 edits in trunk/Source/WebCore
Perserve caption selection in fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=133350
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-29
Reviewed by Eric Carlson.
Use the logic from the inline player to calculate the selected caption index.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::mediaControlsHost):
Expose mediaControlsHost() for use by WebVideoFullscreenModelMediaElement.
- platform/ios/WebVideoFullscreenModelMediaElement.mm:
(WebVideoFullscreenModelMediaElement::updateLegibleOptions):
Use logic from buildCaptionsMenu from mediaControlsApple.js.
- 9:26 AM Changeset in webkit [169449] by
-
- 3 edits2 adds in trunk
Use correct version of requiresFullscreenForVideoPlayback().
https://bugs.webkit.org/show_bug.cgi?id=133331
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-05-29
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-fullscreeen-only-controls.html
Update the last place not yet using m_mediaSession->requiresFullscreenForVideoPlayback.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
switch to media session version for requriesFullscreenForVideoPlayback.
LayoutTests:
- media/video-fullscreeen-only-controls-expected.txt: Added.
- media/video-fullscreeen-only-controls.html: Added. Make sure video element
controls show even when not specified if inline playback is restricted.
- 9:10 AM Changeset in webkit [169448] by
-
- 3 edits1 add in trunk/Source/WebKit2
Add a sandbox profile for com.apple.appstore.CodeRedeemerNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=133360
Reviewed by Sam Weinig.
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Looks like
anyone using camera would need access to CoreMedia preferences.
- Resources/PlugInSandboxProfiles/com.apple.appstore.CodeRedeemerNetscapePlugin.sb: Added.
- WebKit2.xcodeproj/project.pbxproj: Added the profile.
- 9:09 AM Changeset in webkit [169447] by
-
- 4 edits1 add in trunk/Source
DFG::DCEPhase inserts into an insertion set in reverse, causing hilarious basic block corruption if you kill a lot of NewArrays
https://bugs.webkit.org/show_bug.cgi?id=133368
Reviewed by Mark Lam.
Source/JavaScriptCore:
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::fixupBlock): Loop in the right order so that we insert in the right order.
- tests/stress/new-array-dead.js: Added.
(foo):
Source/WTF:
- wtf/Insertion.h:
(WTF::executeInsertions): This algorithm is only correct if insertions are added in the right order. Assert that the order is right.
- 9:05 AM Changeset in webkit [169446] by
-
- 4 edits in trunk/Source
[GTK] Add support for HiDPI icons
https://bugs.webkit.org/show_bug.cgi?id=133377
Reviewed by Martin Robinson.
Source/WebCore:
Use the GTK+ missing icon at 16 or 32 size depending on the device
scale factor.
- platform/graphics/gtk/ImageGtk.cpp:
(WebCore::loadMissingImageIconFromTheme):
(WebCore::Image::loadPlatformResource):
Source/WebKit2:
- PlatformGTK.cmake: Compile also the @2x versions for the builtin icons.
- 8:10 AM Changeset in webkit [169445] by
-
- 12 edits in trunk/Source
[GTK] Add HighDPI support for non-accelerated compositing contents
https://bugs.webkit.org/show_bug.cgi?id=131562
Patch by Owen Taylor <otaylor@redhat.com> on 2014-05-29
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests. This will be tested once we have the proper dependencies in the WebKit testing
JHBuild.
- platform/cairo/WidgetBackingStore.h:
(WebCore::WidgetBackingStore::WidgetBackingStore): Accept a device scale argument.
- platform/cairo/WidgetBackingStoreCairo.cpp: Use the device scale argument to make the surface the proper size and set the surface device scale.
- platform/cairo/WidgetBackingStoreCairo.h: Accept a device scale argument.
- platform/graphics/cairo/CairoUtilities.cpp: Add a new helper to set the device scale if Cairo built against is new enough.
- platform/graphics/cairo/CairoUtilities.h:
- platform/gtk/GtkVersioning.h: Add the HAVE_GTK_SCALE_FACTOR macro.
- platform/gtk/WidgetBackingStoreGtkX11.cpp: Use the device scale argument to make the surface the proper size and set the surface device scale.
- platform/gtk/WidgetBackingStoreGtkX11.h: Accept a device scale argument.
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(deviceScaleFactorChanged): Added this callback to pass scale changes to the page proxy.
(webkitWebViewBaseCreateWebPage): Attach the callback to the notify signal.
- UIProcess/WebPageProxy.cpp:
- UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::WebPageProxy::setCustomDeviceScaleFactor): Do not set a
custom device scale factor for cairo when it's not supported.
(WebKit::createBackingStoreForGTK): Pass the scale factor to the WebCore backing store.
(WebKit::BackingStore::incorporateUpdate): Ditto.
- 3:33 AM Changeset in webkit [169444] by
-
- 8 edits in trunk/Source/WebKit2
[GTK] Use GMainLoopSource for idle and timeout sources in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=130081
Reviewed by Martin Robinson.
- Platform/WorkQueue.h:
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::registerSocketEventHandler): Stop pretending it's
possible to register a socket event handler for more than one
descriptor.
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):
- Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::~DownloadClient):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::handleResponse):
(WebKit::DownloadClient::handleResponseLater):
- UIProcess/Plugins/gtk/PluginInfoCache.cpp:
(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::~PluginInfoCache):
(WebKit::PluginInfoCache::saveToFile):
(WebKit::PluginInfoCache::updatePluginInfo):
- UIProcess/Plugins/gtk/PluginInfoCache.h:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::LayerTreeHostGtk):
(WebKit::LayerTreeHostGtk::layerFlushTimerFired):
(WebKit::LayerTreeHostGtk::scheduleLayerFlush):
(WebKit::LayerTreeHostGtk::cancelPendingLayerFlush):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- 2:38 AM Changeset in webkit [169443] by
-
- 3 edits in trunk
[WK2][GTK] ASSERTION FAILED: m_status == Scheduled in GMainLoopSource
https://bugs.webkit.org/show_bug.cgi?id=131220
Reviewed by Philippe Normand.
Unskip inspector-protocol/dom/remove-multiple-nodes.html.
- platform/gtk/TestExpectations:
