Timeline



Aug 20, 2014:

8:33 PM Changeset in webkit [172826] by benjamin@webkit.org
  • 22 edits
    12 adds in trunk

CSS: Implement the :placeholder-shown pseudo-class from Selectors Level 4
​https://bugs.webkit.org/show_bug.cgi?id=118162

Reviewed by Antti Koivisto.

Source/WebCore:

Previously, HTMLTextFormControlElement was using some mix of its own state
and style to change the visibility of the placeholder. That approach was a little
bit too fragile, and we do not want the style to depends on the renderer() since
that creates circular dependencies.

The biggest change here is refactoring HTMLTextFormControlElement to have
1) An explicit "visible placeholder" state.
2) Separate the textUpdate() from the visibilityUpdate().
3) Remove the dependencies between the Element's style and the placeholder's style.

This is done by simply using display:none; on the placeholder so that its parent's visibility
is irrelevant.

When matching the selector, the style is set as unique since style sharing does not deal with
the changes of HTMLTextFormControlElement.

Tests: fast/css/placeholder-shown-basics.html

fast/selectors/placeholder-shown-long-adjacent-backtracking.html
fast/selectors/placeholder-shown-sibling-style-update.html
fast/selectors/placeholder-shown-style-update.html
fast/selectors/placeholder-shown-with-input-basics.html
fast/selectors/placeholder-shown-with-textarea-basics.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):
Add the CSS Selector description for CSSOM.

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isPlaceholderShown):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • css/html.css:

(::-webkit-input-placeholder):
Previously, the display was forced through the UA stylesheet. Since the display is now part
of the placeholder visibility, it is explicitly handled by HTMLTextFormControlElement and
its subclasses.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::makeUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPlaceholderShown):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateValue):
(WebCore::HTMLTextAreaElement::setValueCommon):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement):
(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
(WebCore::HTMLTextFormControlElement::dispatchBlurEvent):
(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
(WebCore::HTMLTextFormControlElement::selectionDirection):
(WebCore::HTMLTextFormControlElement::restoreCachedSelection):
(WebCore::HTMLTextFormControlElement::parseAttribute):
(WebCore::HTMLTextFormControlElement::hidePlaceholder):
(WebCore::HTMLTextFormControlElement::showPlaceholderIfNecessary):

  • html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::isPlaceholderVisible):
(WebCore::HTMLTextFormControlElement::cachedSelectionDirection):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):
(WebCore::TextFieldInputType::subtreeHasChanged):
(WebCore::TextFieldInputType::updateInnerTextValue):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::styleDidChange):

  • testing/Internals.cpp:

(WebCore::Internals::visiblePlaceholder):

LayoutTests:

Add basic test coverage for common operations: styling, querySelector, CSSOM.

The layout test failure of placeholder-shown-sibling-style-update.html seems unrelated
to this patch, it fails in many more cases. This will be investigated separately, the failure
are used as expected values for now.

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/css/placeholder-shown-basics-expected.html: Added.
  • fast/css/placeholder-shown-basics.html: Added.
  • fast/selectors/placeholder-shown-long-adjacent-backtracking-expected.txt: Added.
  • fast/selectors/placeholder-shown-long-adjacent-backtracking.html: Added.
  • fast/selectors/placeholder-shown-sibling-style-update-expected.txt: Added.
  • fast/selectors/placeholder-shown-sibling-style-update.html: Added.
  • fast/selectors/placeholder-shown-style-update-expected.txt: Added.
  • fast/selectors/placeholder-shown-style-update.html: Added.
  • fast/selectors/placeholder-shown-with-input-basics-expected.txt: Added.
  • fast/selectors/placeholder-shown-with-input-basics.html: Added.
  • fast/selectors/placeholder-shown-with-textarea-basics-expected.txt: Added.
  • fast/selectors/placeholder-shown-with-textarea-basics.html: Added.
8:24 PM Changeset in webkit [172825] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed, EFL build fix since r172814.

  • WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
8:20 PM Changeset in webkit [172824] by dburkart@apple.com
  • 1 copy in tags/Safari-600.1.14

Tag 600.1.14

7:45 PM Changeset in webkit [172823] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

7:29 PM Changeset in webkit [172822] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix how CodeBlock dumps the opcode op_profile_type
​https://bugs.webkit.org/show_bug.cgi?id=136088

Patch by Saam Barati <​sbarati@apple.com> on 2014-08-20
Reviewed by Filip Pizlo.

op_profile_type was modified to receive two extra arguments,
but its dump in CodeBlock::dumpBytecode wasn't changed to
account for this, so it broke CodeBlock::dumpBytecode when
op_profile_type was in the stream of bytecode instructions.
CodeBlock::dumpBytecode now accounts for the change in
op_profile_type's arity.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

6:18 PM Changeset in webkit [172821] by dburkart@apple.com
  • 1 copy in tags/Safari-600.1.13

Tagging.

6:03 PM Changeset in webkit [172820] by commit-queue@webkit.org
  • 38 edits
    4 moves in trunk/Source

Rename HighFidelityTypeProfiling variables for more clarity
​https://bugs.webkit.org/show_bug.cgi?id=135899

Patch by Saam Barati <​sbarati@apple.com> on 2014-08-20
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Many names that are used in the type profiling infrastructure
prefix themselves with "HighFidelity" or include the words "high"
and/or "fidelity" in some way. But the words "high" and "fidelity" don't
add anything descriptive to the names surrounding type profiling.
So this patch removes all uses of "HighFidelity" and its variants.

Most renamings change "HighFidelity*" to "TypeProfiler*" or simply
drop the prefix "HighFidelity" all together. Now, almost all names
in relation to type profiling contain in them "TypeProfiler" or
"TypeProfiling" or some combination of the words "type" and "profile".

This patch also changes how we check if type profiling is enabled:
We no longer call vm::isProfilingTypesWithHighFidelity. We now just
check that vm::typeProfiler is not null.

This patch also changes all calls to TypeProfilerLog::processLogEntries
to use ASCIILiteral to form WTFStrings instead of vanilla C string literals.

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecode/TypeLocation.h:
  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::UnlinkedCodeBlock::typeProfilerExpressionInfoForBytecodeOffset):
(JSC::UnlinkedCodeBlock::addTypeProfilerExpressionInfo):
(JSC::UnlinkedCodeBlock::highFidelityTypeProfileExpressionInfoForBytecodeOffset): Deleted.
(JSC::UnlinkedCodeBlock::addHighFidelityTypeProfileExpressionInfo): Deleted.

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::typeProfilingStartOffset):
(JSC::UnlinkedFunctionExecutable::typeProfilingEndOffset):
(JSC::UnlinkedFunctionExecutable::highFidelityTypeProfilingStartOffset): Deleted.
(JSC::UnlinkedFunctionExecutable::highFidelityTypeProfilingEndOffset): Deleted.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::emitTypeProfilerExpressionInfo):
(JSC::BytecodeGenerator::emitProfileType):
(JSC::BytecodeGenerator::emitHighFidelityTypeProfilingExpressionInfo): Deleted.
(JSC::BytecodeGenerator::emitProfileTypesWithHighFidelity): Deleted.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::isProfilingTypesWithHighFidelity): Deleted.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ThisNode::emitBytecode):
(JSC::ResolveNode::emitBytecode):
(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
(JSC::PrefixNode::emitResolve):
(JSC::PrefixNode::emitBracket):
(JSC::PrefixNode::emitDot):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::AssignDotNode::emitBytecode):
(JSC::ReadModifyDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode):
(JSC::ReadModifyBracketNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::EmptyVarExpression::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):

  • heap/Heap.cpp:

(JSC::Heap::collect):

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
(Inspector::recompileAllJSFunctionsForTypeProfiling):
(Inspector::InspectorRuntimeAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorRuntimeAgent::enableTypeProfiler):
(Inspector::InspectorRuntimeAgent::disableTypeProfiler):
(Inspector::InspectorRuntimeAgent::setTypeProfilerEnabledState):
(Inspector::InspectorRuntimeAgent::enableHighFidelityTypeProfiling): Deleted.
(Inspector::InspectorRuntimeAgent::disableHighFidelityTypeProfiling): Deleted.
(Inspector::InspectorRuntimeAgent::setHighFidelityTypeProfilingEnabledState): Deleted.

  • inspector/agents/InspectorRuntimeAgent.h:
  • inspector/protocol/Runtime.json:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_type):
(JSC::JIT::emit_op_profile_types_with_high_fidelity): Deleted.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_type):
(JSC::JIT::emit_op_profile_types_with_high_fidelity): Deleted.

  • jit/JITOperations.cpp:
  • jsc.cpp:

(functionDumpTypesForAllVariables):

  • llint/LLIntSlowPaths.cpp:
  • llint/LowLevelInterpreter.asm:
  • runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:
  • runtime/Executable.cpp:

(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::ProgramExecutable::initializeGlobalProperties):

  • runtime/Executable.h:

(JSC::ScriptExecutable::typeProfilingStartOffset):
(JSC::ScriptExecutable::typeProfilingEndOffset):
(JSC::ScriptExecutable::highFidelityTypeProfilingStartOffset): Deleted.
(JSC::ScriptExecutable::highFidelityTypeProfilingEndOffset): Deleted.

  • runtime/HighFidelityLog.cpp: Removed.
  • runtime/HighFidelityLog.h: Removed.
  • runtime/HighFidelityTypeProfiler.cpp: Removed.
  • runtime/HighFidelityTypeProfiler.h: Removed.
  • runtime/Options.h:
  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::prepareForTypeProfiling):
(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::uniqueIDForRegister):
(JSC::SymbolTable::prepareForHighFidelityTypeProfiling): Deleted.

  • runtime/SymbolTable.h:
  • runtime/TypeProfiler.cpp: Added.

(JSC::TypeProfiler::logTypesForTypeLocation):
(JSC::TypeProfiler::insertNewLocation):
(JSC::TypeProfiler::getTypesForVariableAtOffsetForInspector):
(JSC::descriptorMatchesTypeLocation):
(JSC::TypeProfiler::findLocation):

  • runtime/TypeProfiler.h: Added.

(JSC::QueryKey::QueryKey):
(JSC::QueryKey::isHashTableDeletedValue):
(JSC::QueryKey::operator==):
(JSC::QueryKey::hash):
(JSC::QueryKeyHash::hash):
(JSC::QueryKeyHash::equal):
(JSC::TypeProfiler::functionHasExecutedCache):
(JSC::TypeProfiler::typeLocationCache):

  • runtime/TypeProfilerLog.cpp: Added.

(JSC::TypeProfilerLog::initializeLog):
(JSC::TypeProfilerLog::~TypeProfilerLog):
(JSC::TypeProfilerLog::processLogEntries):

  • runtime/TypeProfilerLog.h: Added.

(JSC::TypeProfilerLog::LogEntry::structureIDOffset):
(JSC::TypeProfilerLog::LogEntry::valueOffset):
(JSC::TypeProfilerLog::LogEntry::locationOffset):
(JSC::TypeProfilerLog::TypeProfilerLog):
(JSC::TypeProfilerLog::recordTypeInformationForLocation):
(JSC::TypeProfilerLog::logEndPtr):
(JSC::TypeProfilerLog::logStartOffset):
(JSC::TypeProfilerLog::currentLogEntryOffset):

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::enableTypeProfiler):
(JSC::VM::disableTypeProfiler):
(JSC::VM::dumpTypeProfilerData):
(JSC::VM::enableHighFidelityTypeProfiling): Deleted.
(JSC::VM::disableHighFidelityTypeProfiling): Deleted.
(JSC::VM::dumpHighFidelityProfilingTypes): Deleted.

  • runtime/VM.h:

(JSC::VM::typeProfilerLog):
(JSC::VM::typeProfiler):
(JSC::VM::isProfilingTypesWithHighFidelity): Deleted.
(JSC::VM::highFidelityLog): Deleted.
(JSC::VM::highFidelityTypeProfiler): Deleted.

Source/WebInspectorUI:

Change a reference in a comment to a JavaScriptCore file to its
newly renamed variant.

  • UserInterface/Models/ScriptSyntaxTree.js:
5:32 PM Changeset in webkit [172819] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

4:55 PM Changeset in webkit [172818] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the release build after r172806.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError): Add a missing semicolon.

3:55 PM Changeset in webkit [172817] by benjamin@webkit.org
  • 16 edits
    4 deletes in trunk

Remove HTMLInputElement's suggestedValue
​https://bugs.webkit.org/show_bug.cgi?id=136094

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-08-20
Reviewed by Darin Adler.

Source/WebCore:

That code is Chrome specific. It is unused now.

  • WebCore.exp.in:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueFromRenderer):
(WebCore::HTMLInputElement::suggestedValue): Deleted.
(WebCore::HTMLInputElement::setSuggestedValue): Deleted.

  • html/HTMLInputElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):

  • html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::isEmptySuggestedValue): Deleted.

  • html/InputType.cpp:

(WebCore::InputType::canSetSuggestedValue): Deleted.

  • html/InputType.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updateInnerTextValue):
(WebCore::TextFieldInputType::canSetSuggestedValue): Deleted.

  • html/TextFieldInputType.h:
  • testing/Internals.cpp:

(WebCore::Internals::suggestedValue): Deleted.
(WebCore::Internals::setSuggestedValue): Deleted.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

LayoutTests:

  • fast/forms/suggested-value-after-setvalue-expected.txt: Removed.
  • fast/forms/suggested-value-after-setvalue.html: Removed.
  • fast/forms/suggested-value-expected.txt: Removed.
  • fast/forms/suggested-value.html: Removed.
3:39 PM Changeset in webkit [172816] by dino@apple.com
  • 3 edits
    2 adds in trunk

WebAudio FFT analysis uses incorrect scaling
​https://bugs.webkit.org/show_bug.cgi?id=136120

Reviewed by Tim Horton.

Source/WebCore:

This is a port of Blink r166687 (author rtoy)
​https://codereview.chromium.org/156993002

Currently, for a fixed sine-wave input, the peak FFT amplitude changes
depending on the selected FFT size. This is incorrect; the FFT amplitude
should not appreciably change when the FFT size changes.

Layout test added to verify the FFT result stays approximately constant,
independent of the FFT size used.

When this test is run using an older version of WebKit, the peak varies
from about -44 dB (FFT size 32) to -7 dB (FFT size 2048). With this CL,
the peak is about -7 dB. (It's not 0 dB because of the Blackman window that is applied.)

Note: this change may break existing applications that depended on this strange scaling effect.

Test: webaudio/realtimeanalyser-fft-scaling.html

  • Modules/webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::doFFTAnalysis):

LayoutTests:

Test from Blink r166687.

  • webaudio/realtimeanalyser-fft-scaling.html: Added.
  • webaudio/realtimeanalyser-fft-scaling-expected.txt: Added.
3:08 PM Changeset in webkit [172815] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.11.2

New tag.

2:56 PM Changeset in webkit [172814] by achristensen@apple.com
  • 107 edits in trunk

Introducing WEBCORE_EXPORT macro.
​https://bugs.webkit.org/show_bug.cgi?id=136108

Reviewed by Antti Koivisto.

Source/WebCore:

This should eventually replace WebCore.exp.in.

  • platform/PlatformExportMacros.h:

Define WEBCORE_EXPORT to nothing to not cause problems while I'm working on it.

  • Modules/encryptedmedia/CDM.h:
  • Modules/speech/DOMWindowSpeechSynthesis.h:
  • Modules/webdatabase/DatabaseManager.h:
  • Modules/webdatabase/DatabaseTracker.h:
  • accessibility/AXObjectCache.h:
  • bindings/js/DOMWrapperWorld.h:
  • bridge/jsc/BridgeJSC.h:
  • bridge/runtime_method.h:
  • bridge/runtime_object.h:
  • bridge/runtime_root.h:
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSParserMode.h:
  • css/CSSValue.h:
  • css/DOMWindowCSS.h:
  • css/StyleSheetContents.h:
  • dom/CharacterData.h:
  • dom/ClientRect.h:
  • dom/ClientRectList.h:
  • dom/ContainerNode.h:
  • dom/ContextDestructionObserver.h:
  • dom/DOMImplementation.h:
  • dom/DataTransfer.h:
  • dom/DeviceMotionData.h:
  • dom/DeviceOrientationData.h:
  • dom/Document.h:

(WebCore::Document::setAnnotatedRegionsDirty):

  • dom/DocumentMarker.h:
  • dom/DocumentMarkerController.h:
  • dom/DocumentStyleSheetCollection.h:
  • dom/Element.h:
  • dom/Event.h:

(WebCore::Event::create):

  • dom/EventListenerMap.h:
  • editing/DictationAlternative.h:
  • editing/EditCommand.h:
  • editing/EditingStyle.h:
  • editing/Editor.h:
  • editing/mac/AlternativeTextUIController.h:
  • history/BackForwardController.h:
  • history/BackForwardList.h:
  • history/CachedFrame.h:
  • loader/CookieJar.h:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentLoader.h:
  • loader/DocumentWriter.h:
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheHost.h:
  • loader/appcache/ApplicationCacheStorage.h:
  • loader/archive/ArchiveResource.h:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceHandle.h:
  • loader/cache/CachedResourceLoader.h:
  • page/Chrome.h:
  • page/ContextMenuController.h:
  • page/DOMWindow.h:
  • page/DOMWindowExtension.h:
  • page/DragController.h:
  • page/EventHandler.h:
  • page/animation/AnimationController.h:
  • page/scrolling/AsyncScrollingCoordinator.h:
  • platform/CalculationValue.h:
  • platform/ContentFilter.h:
  • platform/ContextMenu.h:
  • platform/ContextMenuItem.h:
  • platform/CrossThreadCopier.h:
  • platform/Cursor.h:
  • platform/DatabaseStrategy.h:
  • platform/DisplaySleepDisabler.h:
  • platform/DragData.h:
  • platform/LocalizedStrings.h:
  • platform/audio/AudioHardwareListener.h:
  • platform/audio/AudioSession.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Color.h:
  • platform/graphics/DisplayRefreshMonitor.h:
  • platform/graphics/transforms/AffineTransform.h:
  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/ios/WebVideoFullscreenModelMediaElement.h:
  • platform/ios/wak/WAKView.mm:
  • platform/ios/wak/WKContentObservation.h:
  • platform/ios/wak/WKView.h:
  • platform/ios/wak/WebCoreThread.h:
  • platform/ios/wak/WebCoreThreadMessage.h:
  • platform/mac/BlockExceptions.h:
  • platform/mock/DeviceOrientationClientMock.h:
  • platform/network/AuthenticationChallengeBase.h:
  • platform/network/BlobData.h:
  • platform/network/BlobDataFileReference.h:
  • platform/network/BlobRegistry.h:
  • platform/network/BlobRegistryImpl.h:
  • platform/network/CredentialBase.h:
  • platform/network/CredentialStorage.h:
  • platform/network/PlatformCookieJar.h:
  • platform/network/cf/AuthenticationChallenge.h:
  • platform/network/cocoa/CredentialCocoa.h:
  • platform/network/mac/CertificateInfo.h:
  • platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::disableThreadingChecks):

  • platform/sql/SQLiteDatabaseTracker.h:
  • platform/sql/SQLiteStatement.h:
  • platform/sql/SQLiteTransaction.h:
  • platform/text/BidiContext.h:

Added WEBCORE_EXPORT macros.

Source/WebKit2:

  • config.h:

Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.

Tools:

  • TestWebKitAPI/config.h:

Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.

2:43 PM Changeset in webkit [172813] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

URTBF after r172799.

  • disassembler/ARM64/A64DOpcode.cpp:
  • disassembler/ARM64Disassembler.cpp:
2:43 PM Changeset in webkit [172812] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit

<​https://webkit.org/b/136119> WebKit1 plug-in test failures in production builds after r172595

Reviewed by Alexey Proskuryakov.

  • WebKit.xcodeproj/project.pbxproj: Add the symlinks at the top level of WebKitLegacy.framework

even in Production builds. Add the symlinks in the right locations too.

2:07 PM Changeset in webkit [172811] by psolanki@apple.com
  • 8 edits
    4 copies
    1 add in trunk/Source

Move DiskCacheMonitor to WebCore so that WebKit1 clients can use it as well
​https://bugs.webkit.org/show_bug.cgi?id=135896

Reviewed by Andreas Kling.

Source/WebCore:

Refactor code and move it to WebCore.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/ResourceLoader.h:

Make willCacheResponse protected so that SubresourceLoader can override it.

  • loader/SubresourceLoader.h:
  • loader/cocoa/DiskCacheMonitorCocoa.h: Added.

Mostly the same as the existing NetworkDiskCacheMonitor class in WebKit2. In the
CFNetwork callback block, it calls a virtual function that is overridden by
NetworkDiskCacheMonitor to send a message to WebContent process.

(WebCore::DiskCacheMonitor::~DiskCacheMonitor):
(WebCore::DiskCacheMonitor::resourceRequest):
(WebCore::DiskCacheMonitor::sessionID):

  • loader/cocoa/DiskCacheMonitorCocoa.mm:

(WebCore::DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse):

Copied from NetworkResourceLoader::tryGetFileBackedSharedBufferFromCFURLCachedResponse.

(WebCore::DiskCacheMonitor::monitorFileBackingStoreCreation):
(WebCore::DiskCacheMonitor::DiskCacheMonitor):
(WebCore::DiskCacheMonitor::resourceBecameFileBacked):

Replace the cached resource data with the contents of the file backed buffer. This is
used in WebKit1 (and also for any resource loads that happen from the WebContent
process).

  • loader/cocoa/SubresourceLoaderCocoa.mm: Added.

(WebCore::SubresourceLoader::willCacheResponse):

Override willCacheresponse from ResourceLoader to listen for disk cache notifications.

Source/WebKit2:

  • NetworkProcess/mac/NetworkDiskCacheMonitor.h:

Inherit from WebCore::DiskCacheMonitor which has the bulk of the functionality now.

(WebKit::NetworkDiskCacheMonitor::~NetworkDiskCacheMonitor):

  • NetworkProcess/mac/NetworkDiskCacheMonitor.mm:

(WebKit::NetworkDiskCacheMonitor::monitorFileBackingStoreCreation):
(WebKit::NetworkDiskCacheMonitor::NetworkDiskCacheMonitor):
(WebKit::NetworkDiskCacheMonitor::resourceBecameFileBacked):

Override virtual method and send the data to the WebContent process as before.

2:04 PM Changeset in webkit [172810] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/JavaScriptCore

Merged r172805. <rdar://problem/18075852>

2:02 PM Changeset in webkit [172809] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

Cleanup MediaSession
​https://bugs.webkit.org/show_bug.cgi?id=136116

Reviewed by Brent Fulgham.

MediaSessionManagerClient interface isn't used, remove it.
No new tests, this doesn't change behavior.

  • WebCore.exp.in:
  • platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::addSession):
(WebCore::MediaSessionManager::removeSession):
(WebCore::MediaSessionManager::sessionWillBeginPlayback):
(WebCore::MediaSessionManager::addClient): Deleted.
(WebCore::MediaSessionManager::removeClient): Deleted.

  • platform/audio/MediaSessionManager.h:

(WebCore::MediaSessionManagerClient::~MediaSessionManagerClient): Deleted.
(WebCore::MediaSessionManagerClient::MediaSessionManagerClient): Deleted.

1:47 PM Changeset in webkit [172808] by oliver@apple.com
  • 19 edits in trunk/Source/JavaScriptCore

Stop implicitly skipping a function's own activation when walking the scope chain
​https://bugs.webkit.org/show_bug.cgi?id=136118

Reviewed by Geoffrey Garen.

Remove the current logic that implicitly skips a function's
own activation when walking the scope chain. This is ground
work for ensuring that all closed variable access is made
through the function's activation. This leads to a further
10% regression on earley, but we're already tracking the
overall performance regression.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getScope):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

  • dfg/DFGHeapLocation.h:
  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitResolveClosure):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSScope.cpp:

(JSC::JSScope::abstractResolve):

  • runtime/JSScope.h:
1:28 PM Changeset in webkit [172807] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION: Web Inspector crashes when reloading apple.com with Timeline recording active
​https://bugs.webkit.org/show_bug.cgi?id=136034

Reviewed by Mark Lam.

DebuggerCallFrame::positionForCallFrame is trying to unwind starting somewhere in the middle
of the stack. Hardened StackVisitor to skip over the frames between the current top frame
and the requested start frame.

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::StackVisitor):

1:19 PM Changeset in webkit [172806] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[MSE] add additional SourceBuffer and MediaSource logging
​https://bugs.webkit.org/show_bug.cgi?id=136114

Reviewed by Brent Fulgham.

No new tests, this adds debug-only logging.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setReadyState): Fix a typo.
(WebCore::MediaSource::streamEndedWithError): Log the error.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Log when parsing fails.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError): Log error.
(WebCore::SourceBuffer::sourceBufferPrivateDidEndStream): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): Log.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Log error.

12:46 PM Changeset in webkit [172805] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Win] JavaScriptCore.dll is missing version information.
​https://bugs.webkit.org/show_bug.cgi?id=136105
<rdar://problem/18075852>

Reviewed by Dean Jackson.

  • JavaScriptCore.vcxproj/JavaScriptCorePreBuild.cmd: Add missing step to generate

version information for intermediary build path.

12:27 PM Changeset in webkit [172804] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Fix a memory leak in TypeSet
​https://bugs.webkit.org/show_bug.cgi?id=135913

Patch by Saam Barati <​sbarati@apple.com> on 2014-08-20
Reviewed by Filip Pizlo.

Currently, TypeSet unconditionally allocates memory for its member
variable m_structureHistory, but never deallocates it. Change this
from being a pointer that is unconditionally allocated to a member
variable that will be deallocated when TypeSet itself is deallocated.

  • runtime/TypeSet.cpp:

(JSC::TypeSet::TypeSet):
(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::seenTypes):
(JSC::TypeSet::displayName):
(JSC::TypeSet::allStructureRepresentations):
(JSC::StructureShape::leastCommonAncestor):

  • runtime/TypeSet.h:
12:10 PM Changeset in webkit [172803] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

import-w3c-tests doesn't import .svg support files
​https://bugs.webkit.org/show_bug.cgi?id=135928

Patch by Rebecca Hauck <​rhauck@adobe.com> on 2014-08-20
Reviewed by Bem Jones-Bey.

This patch fixes the W3C import script to not treat all
files with an xml mimetype as convertible tests, which
was causing SVG support files to not be imported.

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.find_importable_tests):

11:37 AM Changeset in webkit [172802] by commit-queue@webkit.org
  • 105 edits in trunk/Source/WebCore

Unreviewed, rolling out r172798.
​https://bugs.webkit.org/show_bug.cgi?id=136113

Broke builds (Requested by msaboff on #webkit).

Reverted changeset:

"Introducing WEBCORE_EXPORT macro."
​https://bugs.webkit.org/show_bug.cgi?id=136108
​http://trac.webkit.org/changeset/172798

11:11 AM Changeset in webkit [172801] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Assertion fails when running JSC stress tests.
​https://bugs.webkit.org/show_bug.cgi?id=136103

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-08-20
Reviewed by Darin Adler.

Use unsigned bitfield member instead of enum bitfield member to avoid negative values.

  • bytecode/CodeOrigin.h: Use unsigned bitfield member.

(JSC::InlineCallFrame::specializationKind): Compile fix.

11:05 AM Changeset in webkit [172800] by ap@apple.com
  • 2 edits in trunk/LayoutTests

fast/multicol/mixed-opacity-fixed-test.html fails in compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=136109

  • platform/mac-wk2/TestExpectations: Updated test expectations to a non-flaky failure,

and to point to the new bug.

10:59 AM Changeset in webkit [172799] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Enable ARM64 disassembler on EFL
​https://bugs.webkit.org/show_bug.cgi?id=136089

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-08-20
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

  • CMakeLists.txt:

Added disassembler/ARM64Disassembler.cpp and
disassembler/ARM64/A64DOpcode.cpp to JavaScriptCore_SOURCES.

  • disassembler/ARM64/A64DOpcode.cpp:

Added USE(ARM64_DISASSEMBLER) guard around implementation.

  • disassembler/ARM64/A64DOpcode.h:

(JSC::ARM64Disassembler::A64DOpcode::appendUnsignedImmediate64):
(JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset):
Made format strings portable by changing "%llx" to "%" PRIx64 for
uint64_t arguments.

Source/WTF:

  • wtf/Platform.h:

Enable WTF_USE_ARM64_DISASSEMBLER for EFL as well.

10:56 AM Changeset in webkit [172798] by achristensen@apple.com
  • 105 edits in trunk/Source/WebCore

Introducing WEBCORE_EXPORT macro.
​https://bugs.webkit.org/show_bug.cgi?id=136108

Reviewed by Antti Koivisto.

This should eventually replace WebCore.exp.in.

  • platform/PlatformExportMacros.h:

Define WEBCORE_EXPORT to nothing to not cause problems while I'm working on it.

  • Modules/encryptedmedia/CDM.h:
  • Modules/speech/DOMWindowSpeechSynthesis.h:
  • Modules/webdatabase/DatabaseManager.h:
  • Modules/webdatabase/DatabaseTracker.h:
  • accessibility/AXObjectCache.h:
  • bindings/js/DOMWrapperWorld.h:
  • bridge/jsc/BridgeJSC.h:
  • bridge/runtime_method.cpp:
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:
  • bridge/runtime_root.h:
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSParserMode.h:
  • css/CSSValue.h:
  • css/DOMWindowCSS.h:
  • css/StyleSheetContents.h:
  • dom/CharacterData.h:
  • dom/ClientRect.h:
  • dom/ClientRectList.h:
  • dom/ContainerNode.h:
  • dom/ContextDestructionObserver.h:
  • dom/DOMImplementation.h:
  • dom/DataTransfer.h:
  • dom/DeviceMotionData.h:
  • dom/DeviceOrientationData.h:
  • dom/Document.h:

(WebCore::Document::setAnnotatedRegionsDirty):

  • dom/DocumentMarker.h:
  • dom/DocumentMarkerController.h:
  • dom/DocumentStyleSheetCollection.h:
  • dom/Element.h:
  • dom/Event.h:

(WebCore::Event::create):

  • dom/EventListenerMap.h:
  • editing/DictationAlternative.h:
  • editing/EditCommand.h:
  • editing/EditingStyle.h:
  • editing/Editor.h:
  • editing/mac/AlternativeTextUIController.h:
  • history/BackForwardController.h:
  • history/BackForwardList.h:
  • history/CachedFrame.h:
  • loader/CookieJar.h:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentLoader.h:
  • loader/DocumentWriter.h:
  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheHost.h:
  • loader/appcache/ApplicationCacheStorage.h:
  • loader/archive/ArchiveResource.h:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceHandle.h:
  • loader/cache/CachedResourceLoader.h:
  • page/Chrome.h:
  • page/ContextMenuController.h:
  • page/DOMWindow.h:
  • page/DOMWindowExtension.h:
  • page/DragController.h:
  • page/EventHandler.h:
  • page/animation/AnimationController.h:
  • page/scrolling/AsyncScrollingCoordinator.h:
  • platform/CalculationValue.h:
  • platform/ContentFilter.h:
  • platform/ContextMenu.h:
  • platform/ContextMenuItem.h:
  • platform/CrossThreadCopier.h:
  • platform/Cursor.h:
  • platform/DatabaseStrategy.h:
  • platform/DisplaySleepDisabler.h:
  • platform/DragData.h:
  • platform/LocalizedStrings.h:
  • platform/audio/AudioHardwareListener.h:
  • platform/audio/AudioSession.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Color.h:
  • platform/graphics/DisplayRefreshMonitor.h:
  • platform/graphics/transforms/AffineTransform.h:
  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/ios/WebVideoFullscreenModelMediaElement.h:
  • platform/ios/wak/WAKView.mm:
  • platform/ios/wak/WKContentObservation.h:
  • platform/ios/wak/WKView.h:
  • platform/ios/wak/WebCoreThread.h:
  • platform/ios/wak/WebCoreThreadMessage.h:
  • platform/mac/BlockExceptions.h:
  • platform/mock/DeviceOrientationClientMock.h:
  • platform/network/AuthenticationChallengeBase.h:
  • platform/network/BlobData.h:
  • platform/network/BlobDataFileReference.h:
  • platform/network/BlobRegistry.h:
  • platform/network/BlobRegistryImpl.h:
  • platform/network/CredentialBase.h:
  • platform/network/CredentialStorage.h:
  • platform/network/PlatformCookieJar.h:
  • platform/network/cf/AuthenticationChallenge.h:
  • platform/network/cocoa/CredentialCocoa.h:
  • platform/network/mac/CertificateInfo.h:
  • platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::disableThreadingChecks):

  • platform/sql/SQLiteDatabaseTracker.h:
  • platform/sql/SQLiteStatement.h:
  • platform/sql/SQLiteTransaction.h:
  • platform/text/BidiContext.h:

Added WEBCORE_EXPORT macros.

7:44 AM Changeset in webkit [172797] by Alan Bujtas
  • 4 edits
    32 adds in trunk

Dashed/dotted borders do not paint.
​https://bugs.webkit.org/show_bug.cgi?id=135898

Reviewed by Simon Fraser.

Source/WebCore:

Remove the empty line checks for drawLines. There's no need to protect the graphics
context from empty lines.

Tests: fast/borders/border-painting-dashed-at-all.html

fast/borders/border-painting-dashed.html
fast/borders/border-painting-dotted-at-all.html
fast/borders/border-painting-dotted.html
fast/borders/border-painting-double-at-all.html
fast/borders/border-painting-double.html
fast/borders/border-painting-groove-at-all.html
fast/borders/border-painting-inset-at-all.html
fast/borders/border-painting-inset.html
fast/borders/border-painting-outset-at-all.html
fast/borders/border-painting-outset.html
fast/borders/border-painting-ridge-at-all.html
fast/borders/border-painting-solid-at-all.html
fast/borders/border-painting-solid.html
fast/borders/hidpi-border-painting-groove.html
fast/borders/hidpi-border-painting-ridge.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::drawBorderLineRect): Deleted.
(WebCore::drawBorderLine): Deleted.

LayoutTests:

*-at-all files test that we always paint borders.
The other set of files test that borders are painted properly. They take
advantage of the fact that borders with radius use a different painting code path.

  • TestExpectations:
  • fast/borders/border-painting-dashed-at-all-expected.html: Added.
  • fast/borders/border-painting-dashed-at-all.html: Added.
  • fast/borders/border-painting-dashed-expected.html: Added.
  • fast/borders/border-painting-dashed.html: Added.
  • fast/borders/border-painting-dotted-at-all-expected.html: Added.
  • fast/borders/border-painting-dotted-at-all.html: Added.
  • fast/borders/border-painting-dotted-expected.html: Added.
  • fast/borders/border-painting-dotted.html: Added.
  • fast/borders/border-painting-double-at-all-expected.html: Added.
  • fast/borders/border-painting-double-at-all.html: Added.
  • fast/borders/border-painting-double-expected.html: Added.
  • fast/borders/border-painting-double.html: Added.
  • fast/borders/border-painting-groove-at-all-expected.html: Added.
  • fast/borders/border-painting-groove-at-all.html: Added.
  • fast/borders/border-painting-inset-at-all-expected.html: Added.
  • fast/borders/border-painting-inset-at-all.html: Added.
  • fast/borders/border-painting-inset-expected.html: Added.
  • fast/borders/border-painting-inset.html: Added.
  • fast/borders/border-painting-outset-at-all-expected.html: Added.
  • fast/borders/border-painting-outset-at-all.html: Added.
  • fast/borders/border-painting-outset-expected.html: Added.
  • fast/borders/border-painting-outset.html: Added.
  • fast/borders/border-painting-ridge-at-all-expected.html: Added.
  • fast/borders/border-painting-ridge-at-all.html: Added.
  • fast/borders/border-painting-solid-at-all-expected.html: Added.
  • fast/borders/border-painting-solid-at-all.html: Added.
  • fast/borders/border-painting-solid-expected.html: Added.
  • fast/borders/border-painting-solid.html: Added.
  • fast/borders/hidpi-border-painting-groove-expected.html: Added.
  • fast/borders/hidpi-border-painting-groove.html: Added.
  • fast/borders/hidpi-border-painting-ridge-expected.html: Added.
  • fast/borders/hidpi-border-painting-ridge.html: Added.

Aug 19, 2014:

9:32 PM Changeset in webkit [172796] by jinwoo7.song@samsung.com
  • 4 edits
    2 adds in trunk

Ignore usemap attributes without '#' in img element
​https://bugs.webkit.org/show_bug.cgi?id=133336

Reviewed by Ryosuke Niwa.

HTML5 specification says we should ignore usemap attributes without #.
​http://www.w3.org/TR/html5/infrastructure.html#valid-hash-name-reference

Source/WebCore:

Test: fast/dom/replaced-image-map-valid-hash-name.html

  • dom/TreeScope.cpp:

(WebCore::TreeScope::getImageMap):

LayoutTests:

  • fast/dom/replaced-image-map-valid-hash-name-expected.txt: Added.
  • fast/dom/replaced-image-map-valid-hash-name.html: Added.
  • fast/images/image-map-multiple-xhtml.xhtml: Modified usemap attribute value to use '#'.
8:02 PM Changeset in webkit [172795] by mitz@apple.com
  • 2 edits in trunk/Tools

update-webkit should not check for the presence of Apple’s Internal directory
Last part of ​https://bugs.webkit.org/show_bug.cgi?id=135815

Reviewed by Tim Horton.

  • Scripts/update-webkit:
7:38 PM Changeset in webkit [172794] by fpizlo@apple.com
  • 7 edits
    5 adds in trunk

REGRESSION(r172401): for-in optimization no longer works at all
​https://bugs.webkit.org/show_bug.cgi?id=136056

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Roll this back in, along with a fix to make proxies work. Previously, for-in over proxies
would instacrash every time.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::pushIndexedForInScope):
(JSC::BytecodeGenerator::pushStructureForInScope):

  • bytecompiler/BytecodeGenerator.h:

(JSC::ForInContext::ForInContext):
(JSC::StructureForInContext::StructureForInContext):
(JSC::IndexedForInContext::IndexedForInContext):
(JSC::ForInContext::base): Deleted.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitMultiLoopBytecode):

  • runtime/JSProxy.cpp:

(JSC::JSProxy::getStructurePropertyNames):
(JSC::JSProxy::getGenericPropertyNames):

  • tests/stress/for-in-base-reassigned-later-and-change-structure.js: Added.

(foo):

  • tests/stress/for-in-base-reassigned-later.js: Added.

(foo):

  • tests/stress/for-in-base-reassigned.js: Added.

(foo):

  • tests/stress/for-in-proxy-target-changed-structure.js: Added.

(deleteAll):
(foo):

  • tests/stress/for-in-proxy.js: Added.

(foo):

LayoutTests:

This just needs a rebase because the number of calls into the DOM has changed and so the
number of console messages about security stuff has now changed.

  • http/tests/security/cross-frame-access-enumeration-expected.txt:
7:17 PM Changeset in webkit [172793] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix EFL build after r17275

Fix error: ignoring #pragma clang diagnostic [-Werror=unknown-pragmas]

  • runtime/JSDataViewPrototype.cpp:

Add #if COMPILER(CLANG) and #endif.

5:36 PM Changeset in webkit [172792] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Crash in jsc-layout-tests.yaml/js/script-tests/reentrant-caching.js
​https://bugs.webkit.org/show_bug.cgi?id=136080

Reviewed by Mark Lam.

Update VM::topVMEntryFrame via NativeCallFrameTracer() when we pass the caller's frame
to NativeCallFrameTracer() as the callee's frame may be the first callee from an entry
frame. In that case, the caller will have the prior VM entry frame.

The new NativeCallFrameTracer with a VMEntryFrame parameter should be used when throwing
an exception from a caller frame. The value to use for the VMEntryFrame should be a
value possibly modified by CallFrame::callerFrame(&*VMEntryFrame) used to find the caller.

  • interpreter/Interpreter.h:

(JSC::NativeCallFrameTracer::NativeCallFrameTracer): Added a new constructor that takes a
VMEntryFrame. Added an ASSERT to both constructors to check that the updated topCallFrame
is below the current vmEntryFrame.

  • jit/JITOperations.cpp:

(JSC::operationThrowStackOverflowError):
(JSC::operationCallArityCheck):
(JSC::operationConstructArityCheck):
Set VM::topVMEntryFrame to the possibly updated VMEntryFrame after getting the caller's frame.

5:22 PM Changeset in webkit [172791] by dburkart@apple.com
  • 3 edits in branches/safari-600.1-branch/Source/WebCore

Merge r172317. <rdar://problem/18052514>

4:55 PM Changeset in webkit [172790] by psolanki@apple.com
  • 31 edits
    3 deletes in trunk/Source

Remove PurgeableBuffer since it is not very useful any more
​https://bugs.webkit.org/show_bug.cgi?id=135939

Reviewed by Andreas Kling.

Source/WebCore:

The usefulness of having purgeable memory for cached resources has diminished now that
WebKit uses file backed resources when possible. Since this is read only memory, it is in
essence "purgeable". Having the PurgeableBuffer code adds additional complexity that we
don't need. e.g. on my Mac, I am not seeing any entry for "WebCore purgeable data" when I
run vmmap against the web processes that I have running. It is used on iOS, however even
there much of the purgeable memory we create gets replaced by file backed memory once we get
the notification from CFNetwork.

No new tests because no functional changes.

  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorPageAgent.cpp:

(WebCore::prepareCachedResourceBuffer):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::subresource):

  • loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::hasPurgeableBuffer): Deleted.
(WebCore::ResourceBuffer::setShouldUsePurgeableMemory): Deleted.
(WebCore::ResourceBuffer::createPurgeableBuffer): Deleted.
(WebCore::ResourceBuffer::releasePurgeableBuffer): Deleted.

  • loader/ResourceBuffer.h:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::sheetText):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):

  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::image):
(WebCore::CachedImage::imageForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::destroyDecodedData):
(WebCore::CachedImage::canUseDiskImageCache):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::isSafeToMakePurgeable): Deleted.
(WebCore::CachedResource::makePurgeable): Deleted.
(WebCore::CachedResource::isPurgeable): Deleted.
(WebCore::CachedResource::wasPurged): Deleted.

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::resourceBuffer):
(WebCore::CachedResource::purgePriority): Deleted.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):
(WebCore::CachedScript::destroyDecodedData):

  • loader/cache/CachedScript.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::resourceForRequestImpl):
(WebCore::MemoryCache::pruneDeadResourcesToSize):
(WebCore::MemoryCache::evict):
(WebCore::MemoryCache::TypeStatistic::addResource):
(WebCore::MemoryCache::dumpStats):
(WebCore::MemoryCache::dumpLRULists):
(WebCore::MemoryCache::makeResourcePurgeable): Deleted.

  • loader/cache/MemoryCache.h:

(WebCore::MemoryCache::TypeStatistic::TypeStatistic):
(WebCore::MemoryCache::shouldMakeResourcePurgeableOnEviction): Deleted.

  • platform/PurgePriority.h: Removed.
  • platform/PurgeableBuffer.h: Removed.
  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::size):
(WebCore::SharedBuffer::data):
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::clear):
(WebCore::SharedBuffer::copy):
(WebCore::SharedBuffer::getSomeData):
(WebCore::SharedBuffer::adoptPurgeableBuffer): Deleted.
(WebCore::SharedBuffer::createPurgeableBuffer): Deleted.
(WebCore::SharedBuffer::releasePurgeableBuffer): Deleted.

  • platform/SharedBuffer.h:

(WebCore::SharedBuffer::hasPurgeableBuffer): Deleted.
(WebCore::SharedBuffer::shouldUsePurgeableMemory): Deleted.

  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::SharedBuffer):

  • platform/mac/PurgeableBufferMac.cpp: Removed.
  • platform/mac/SharedBufferMac.mm:

(WebCore::SharedBuffer::createCFData):

  • platform/soup/SharedBufferSoup.cpp:

Source/WebKit/mac:

  • Misc/WebCache.mm:

(+[WebCache statistics]):

Source/WebKit/win:

  • WebCache.cpp:

(WebCache::statistics):

Source/WebKit2:

  • WebProcess/WebProcess.cpp:

(WebKit::getWebCoreMemoryCacheStatistics):

Source/WTF:

  • wtf/Platform.h: Remove ENABLE_PURGEABLE_MEMORY define.
  • wtf/VMTags.h: Remove VM tags used by WebCore for cached resource purgeable memory.
4:53 PM Changeset in webkit [172789] by dburkart@apple.com
  • 4 edits
    2 copies in branches/safari-600.1-branch

Merge r172727. <rdar://problem/18051847>

4:50 PM Changeset in webkit [172788] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merge r172720. <rdar://problem/17767169>

4:49 PM Changeset in webkit [172787] by dburkart@apple.com
  • 13 edits
    12 copies
    10 deletes in branches/safari-600.1-branch

Merge r172709. <rdar://problem/17850158>

4:45 PM Changeset in webkit [172786] by dburkart@apple.com
  • 4 edits in branches/safari-600.1-branch/Source/WebCore

Merge r172705. <rdar://problem/17767169>

4:43 PM Changeset in webkit [172785] by dburkart@apple.com
  • 4 edits in branches/safari-600.1-branch/Source/WebCore

Merge r172703. <rdar://problem/17767169>

4:39 PM Changeset in webkit [172784] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merge r172693. <rdar://problem/17577321>

4:38 PM Changeset in webkit [172783] by aestes@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Cocoa] Offline Assembler build phase fails when $BUILT_PRODUCTS_DIR contains spaces
​https://bugs.webkit.org/show_bug.cgi?id=136086

Reviewed by Filip Pizlo.

Enclosed arguments to asm.rb containing $BUILT_PRODUCTS_DIR in double quotes so that they don't get split on
whitespace. Also let Xcode have its way with an unrelated part of the project file.

4:35 PM Changeset in webkit [172782] by dburkart@apple.com
  • 6 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merge r172689. <rdar://problem/18040028>

4:33 PM Changeset in webkit [172781] by dburkart@apple.com
  • 5 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merge r172682. <rdar://problem/18038767>

4:33 PM Changeset in webkit [172780] by commit-queue@webkit.org
  • 14 edits in trunk/Source

Expose injected bundle SPI to get a node's URL element, get the visible selection range of that
element, and snapshot that range
​https://bugs.webkit.org/show_bug.cgi?id=136076

Patch by Peyton Randolph <​prandolph@apple.com> on 2014-08-19
Reviewed by Tim Horton.

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultCopyURLElementHandle): Added.

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCopyVisibleRange): Added.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:

(WKBundleRangeHandleGetBoundingRectInWindowCoordinates): Added.
(WKBundleRangeHandleCopySnapshotWithOptions): Added.

  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::visibleRange): Added.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::boundingRectInWindowCoordinates): Added.
(WebKit::InjectedBundleRangeHandle::renderedImage): Added.

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::urlElementHandle): Added.

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
4:29 PM Changeset in webkit [172779] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merge r172662. <rdar://problem/17971908>

4:26 PM Changeset in webkit [172778] by dburkart@apple.com
  • 16 edits in branches/safari-600.1-branch/Source/WebCore

Merge r172657. <rdar://problem/17896828>

4:25 PM Changeset in webkit [172777] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

LLInt build should be way faster
​https://bugs.webkit.org/show_bug.cgi?id=136085

Reviewed by Geoffrey Garen.

This does three things to improve the LLInt build performance. One of them is only for
Xcode for now while the others should benefit all platforms:

  • Don't exponentially build settings combinations that correspond to being on two backends simultaneously. This is by far the biggest win.


  • Don't generate offset extraction code for backends that aren't supported by the current port. This currently only works on Xcode-based ports. This is a relatively small win.


  • Remove the ALWAYS_ALLOCATE_SLOW option. Each option increases build time, and we haven't used this one in a long time. Anyway, setting this option could be emulated by just directly hacking the code.


This is an enormous speed-up in the LLInt build.

  • JavaScriptCore.xcodeproj/project.pbxproj: Prune the set of backends that we should consider on Xcode-based platforms.
  • llint/LLIntOfflineAsmConfig.h: Remove ALWAYS_ALLOCATE_SLOW
  • llint/LowLevelInterpreter.asm: Remove ALWAYS_ALLOCATE_SLOW
  • offlineasm/backends.rb: Add infrastructure for reasoning about valid backends.
  • offlineasm/generate_offset_extractor.rb: Allow the client to specify a filtered set of valid backends.
  • offlineasm/settings.rb: Improve the construction of settings combinations so that it doesn't traverse the enourmous set of obviously invalid multi-backend combinations. Also glue into support for valid backends.
4:20 PM Changeset in webkit [172776] by dburkart@apple.com
  • 6 edits
    2 copies in branches/safari-600.1-branch

Merge r172656. <rdar://problem/17961698>

4:12 PM Changeset in webkit [172775] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merge r172650. <rdar://problem/18034356>

4:09 PM Changeset in webkit [172774] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merge r172643. <rdar://problem/18032571>

4:06 PM Changeset in webkit [172773] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merge r172640. <rdar://problem/18025668>

4:02 PM Changeset in webkit [172772] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merge r172639. <rdar://problem/17957716>

4:00 PM Changeset in webkit [172771] by dburkart@apple.com
  • 6 edits in branches/safari-600.1-branch/Source/WebKit2

Merge r172636. <rdar://problem/17957716>

3:54 PM Changeset in webkit [172770] by dburkart@apple.com
  • 12 edits in branches/safari-600.1-branch/Source/WebKit2

Merge r172635. <rdar://problem/18006149>

3:47 PM Changeset in webkit [172769] by dburkart@apple.com
  • 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merge r172617. <rdar://problem/18023242>

3:43 PM Changeset in webkit [172768] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merge r172615. <rdar://problem/18024530>

3:25 PM Changeset in webkit [172767] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation and style in LowLevelInterpreter.asm
​https://bugs.webkit.org/show_bug.cgi?id=136083

Reviewed by Mark Lam.

  • llint/LowLevelInterpreter.asm:
3:25 PM Changeset in webkit [172766] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172606. <rdar://problem/18022467>

3:18 PM Changeset in webkit [172765] by dburkart@apple.com
  • 3 edits
    3 copies in branches/safari-600.1-branch

Merged r172603. <rdar://problem/17989469>

3:05 PM Changeset in webkit [172764] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172601. <rdar://problem/18021462>

2:39 PM Changeset in webkit [172763] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172600. <rdar://problem/18021928>

2:34 PM Changeset in webkit [172762] by dburkart@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172596. <rdar://problem/17957690>

2:31 PM Changeset in webkit [172761] by dburkart@apple.com
  • 6 edits in branches/safari-600.1-branch/Source

Merged r172502. <rdar://problem/18022784>

2:28 PM Changeset in webkit [172760] by dburkart@apple.com
  • 3 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172481. <rdar://problem/17954473>

2:25 PM Changeset in webkit [172759] by berto@igalia.com
  • 4 edits in trunk/Source

TEXTREL in libjavascriptcoregtk-1.0.so.0.11.0 on x86 (or i586)
​https://bugs.webkit.org/show_bug.cgi?id=70610

Patch by Magnus Granberg <​zorry@gentoo.org> on 2014-08-19
Reviewed by Darin Adler.

Source/JavaScriptCore:

Setup %ebx so we can use the plt.

  • jit/ThunkGenerators.cpp:

Source/WTF:

Add PLT if we're building with PIC.

  • wtf/InlineASM.h:
2:02 PM Changeset in webkit [172758] by Alan Bujtas
  • 29 edits in trunk

Remove ENABLE(SUBPIXEL_LAYOUT).
​https://bugs.webkit.org/show_bug.cgi?id=136077

Reviewed by Simon Fraser.

Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLength):

  • dom/Element.cpp:

(WebCore::adjustForLocalZoom):
(WebCore::Element::offsetWidth):
(WebCore::Element::offsetHeight):
(WebCore::Element::clientLeft):
(WebCore::Element::clientTop):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):

  • platform/LayoutUnit.h:

(WebCore::LayoutUnit::LayoutUnit):
(WebCore::LayoutUnit::ceilToFloat):
(WebCore::LayoutUnit::ceil):
(WebCore::LayoutUnit::round):
(WebCore::LayoutUnit::floor):
(WebCore::boundedMultiply):
(WebCore::operator*):
(WebCore::operator/):
(WebCore::intMod):
(WebCore::operator%):
(WebCore::roundedLayoutUnit):
(WebCore::ceiledLayoutUnit):
(WebCore::LayoutUnit::toInt): Deleted.
(WebCore::LayoutUnit::toFloat): Deleted.
(WebCore::LayoutUnit::toDouble): Deleted.
(WebCore::LayoutUnit::epsilon): Deleted.

  • platform/graphics/LayoutPoint.h:

(WebCore::roundedForPainting):
(WebCore::flooredForPainting):
(WebCore::ceiledForPainting):
(WebCore::roundedLayoutPoint):

  • platform/graphics/LayoutRect.cpp:

(WebCore::enclosingLayoutRect):

  • platform/graphics/LayoutRect.h:

(WebCore::pixelSnappedIntRect):
(WebCore::pixelSnappedForPainting):

  • platform/graphics/LayoutSize.h:

(WebCore::roundedLayoutSize):
(WebCore::flooredForPainting):

  • rendering/RenderBlock.cpp:

(WebCore::adjustFloatForSubPixelLayout):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutBlockChild):

  • rendering/RenderElement.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

  • rendering/style/RenderStyle.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1:41 PM Changeset in webkit [172757] by Bem Jones-Bey
  • 6 edits in trunk

[CSS Shapes] A few calc() test failures in the shape-image-threshold parsing tests
​https://bugs.webkit.org/show_bug.cgi?id=135926

Reviewed by Dirk Schulze.

Source/WebCore:

shape-image-threshold is a Number, so it should be parsed as one. The
default parsing doesn't support calcs, but numbers do.

No new tests, fixes exitsing test to pass.

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): Use

ApplyPropertyNumber instead of ApplyPropertyDefault for
shape-image-threshold.

LayoutTests:

  • TestExpectations: Remove Failure and Crash expectations.
  • css3/shapes/shape-outside/values/shape-image-threshold-001-expected.txt:

Proper expected results now that the test passes.

  • css3/shapes/shape-outside/values/shape-image-threshold-001.html:

Adding together calcs isn't valid, so move the addition inside of
the calc expression. This will also be updated upstream.

11:57 AM Changeset in webkit [172756] by mmirman@apple.com
  • 12 edits
    1 delete in trunk/Source/JavaScriptCore

Merges the two native inlining passes from the build.
Also adds the AvailableExternallyLinkage assertion to linked
functions to allow unused and duplicate ones to be removed.
​https://bugs.webkit.org/show_bug.cgi?id=135526

Reviewed by Filip Pizlo.

Removed second generation of llvm binary files.
Fixed the flags on the first pass.

  • build-symbol-table-index.py: Modified some paths.
  • build-symbol-table-index.sh: Removed.
  • copy-llvm-ir-to-derived-sources.sh: Now calls build-symbol-table-index directly.
  • ftl/FTLLowerDFGToLLVM.cpp: Added LLVMAvailableExternallyLinkage assertion.

(JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol):

  • runtime/ArrayPrototype.cpp: Removed static declarations.
  • runtime/DateConstructor.cpp: ditto.

(JSC::dateParse):
(JSC::dateNow):
(JSC::dateUTC):

  • runtime/DatePrototype.cpp: ditto.
  • runtime/JSDataViewPrototype.cpp: ditto on both.

(JSC::dataViewProtoFuncGetInt8):
(JSC::dataViewProtoFuncGetInt16):
(JSC::dataViewProtoFuncGetInt32):
(JSC::dataViewProtoFuncGetUint8):
(JSC::dataViewProtoFuncGetUint16):
(JSC::dataViewProtoFuncGetUint32):
(JSC::dataViewProtoFuncGetFloat32):
(JSC::dataViewProtoFuncGetFloat64):
(JSC::dataViewProtoFuncSetInt8):
(JSC::dataViewProtoFuncSetInt16):
(JSC::dataViewProtoFuncSetInt32):
(JSC::dataViewProtoFuncSetUint8):
(JSC::dataViewProtoFuncSetUint16):
(JSC::dataViewProtoFuncSetUint32):
(JSC::dataViewProtoFuncSetFloat32):
(JSC::dataViewProtoFuncSetFloat64):

  • runtime/JSONObject.cpp: ditto.
  • runtime/ObjectConstructor.cpp: ditto.
  • runtime/StringPrototype.cpp: ditto.
11:32 AM Changeset in webkit [172755] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Extend injected bundle node snapshotting to support forced white and black text
​https://bugs.webkit.org/show_bug.cgi?id=136061

Patch by Peyton Randolph <​prandolph@apple.com> on 2014-08-19
Reviewed by Beth Dakin.

  • Shared/API/c/WKImage.h:

Add -ForceBlackText and -ForceWhiteText snapshotting options.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toSnapshotOptions):
Support aforementioned text snapshotting options.

  • Shared/ImageOptions.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::imageForRect):
Respect text color snapshotting options by setting appropriate paint behaviors.

10:36 AM Changeset in webkit [172754] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[CMake] Generate LLInt assembly correctly on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=135888

Patch by Alex Christensen <​achristensen@webkit.org> on 2014-08-19
Reviewed by Oliver Hunt.

  • CMakeLists.txt:

Generate LowLevelInterpreterWin.asm instead of LLIntAssembly.h on Windows like the existing build system.

  • PlatformWin.cmake:

Don't build JSGlobalObjectInspectorController.cpp on Windows.

  • offlineasm/x86.rb:

Detect non-cygwin ruby installations correctly.

10:04 AM Changeset in webkit [172753] by ap@apple.com
  • 2 edits in trunk/LayoutTests

ASSERT_NOT_REACHED on css3/shapes/shape-outside/values/shape-image-threshold-001.html
​https://bugs.webkit.org/show_bug.cgi?id=136075

8:43 AM Changeset in webkit [172752] by bshafiei@apple.com
  • 7 edits in branches/safari-600.1.4.11-branch

Merged r172213. <rdar://problem/18052523>

6:09 AM Changeset in webkit [172751] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Let the caller define JSC_timeout for run-javascriptcore-tests
​https://bugs.webkit.org/show_bug.cgi?id=136068

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-08-19
Reviewed by Csaba Osztrogonác.

Keep the 60 second timeout for jsc tests as the default setting but
don't override the value of JSC_timeout if already set.

  • Scripts/run-javascriptcore-tests:
5:05 AM Changeset in webkit [172750] by clopez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Mark tests failing after r172733 (W3C CSS Shapes test suite import)

Update list of flaky tests. Report and mark new failures. Remove expectations for new passing tests.

2:41 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
1:37 AM Changeset in webkit [172749] by mjs@apple.com
  • 20 edits
    3 adds in trunk/Source

Use NSURLFileTypeMappings directly instead of depending on WebKitSystemInterface wrappers for it
​https://bugs.webkit.org/show_bug.cgi?id=136035

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in: Remove reference to no longer existent sumbols.
  • WebCore.order: ditto
  • WebCore.xcodeproj/project.pbxproj: Install new NSURLFileTyeMappings.h header.
  • platform/ios/MIMETypeRegistryIOS.mm:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension): Use NSURLFileTypeMappings
directly instead of via WKSI wrapper.

  • platform/mac/MIMETypeRegistryMac.mm:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension): ditto
(WebCore::MIMETypeRegistry::getExtensionsForMIMEType): ditto
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): ditto

  • platform/mac/WebCoreSystemInterface.h: Remove references to the no-longer-used

WKGetExtensionsForMIMEType, WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension

  • platform/mac/WebCoreSystemInterface.mm: ditto
  • platform/spi: Added. This is where headers to declare SPI go.
  • platform/spi/cocoa: Added. See above.
  • platform/spi/cocoa/NSURLFileTypeMappingsSPI.h: Added. Header to declare

the internal class NSURLFileTypeMappings and some of its methods.

Source/WebKit/mac:

  • Misc/WebNSViewExtras.m:

(-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]): Remove comment
reference to obsolete WKSI function.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Don't initialize the no-longer-used WKGetExtensionsForMIMEType,
WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension

  • Plugins/WebPluginDatabase.mm:

(-[WebPluginDatabase pluginForExtension:]): Include SPI header from WebCore; use
NSURLFileTypeMappings directly instead of via WKSI wrapper.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::objectContentType): ditto

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _imageExistsAtPaths:]): ditto

  • WebView/WebView.mm:

(+[WebView _supportedFileExtensions]): ditto
(+[WebView suggestedFileExtensionForMIMEType:]): ditto
(+[WebView _MIMETypeForFile:]): ditto

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Don't initialize the no-longer-used WKGetExtensionsForMIMEType,
WKGetPreferredExtensionForMIMEType, or WKGetMIMETypeForExtension

  • mac/WebKit2.order: Remove exports related to above.

Source/WTF:

  • wtf/Platform.h: Define USE(APPLE_INTERNAL_SDK) by default on platforms that have it.
1:09 AM Changeset in webkit [172748] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Remove obsolete run-javascriptcore-tests result parsing from master.cfg
​https://bugs.webkit.org/show_bug.cgi?id=136039

Patch by Renato Nagy <​nagy.renato@stud.u-szeged.hu> on 2014-08-19
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunJavaScriptCoreTests.commandComplete):

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunJavaScriptCoreTestsTest.test_no_failure_new_output):
(RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
(RunJavaScriptCoreTestsTest):
(RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
(RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
(test_layout_failure_new_output): Deleted.
(test_layout_crash_new_output): Deleted.
(test_mozilla_and_layout_failure_new_output): Deleted.
(test_jsc_stress_failure_new_output): Deleted.
(test_js_crashes_and_jsc_stress_failures_new_output): Deleted.

12:37 AM Changeset in webkit [172747] by ap@apple.com
  • 3 edits in trunk/Tools

build.webkit.org/dashboard should not request 50 revisions from trac each time
​https://bugs.webkit.org/show_bug.cgi?id=127130

build.webkit.org/dashboard sometimes fetches a Trac revision in an intermediate state, and never updates later
​https://bugs.webkit.org/show_bug.cgi?id=127131

Reviewed by Timothy Hatcher.

Turns out that requesting 50 builds is much slower than requesting by date - even
if the request ends up returning more than 50 results. There is no way to only
request updates, but this change brings request time from 6-8 seconds down to
less than a second.

This patch generalizes date handling for later use in metrics code. As part of the
rewrite, I made newly fetched data update author e-mail in previously fetched
revisions, as it changes after commit queue first lands.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

Updated for event rename. I changed the trac event to not contain the list of new
commits, as we now sometimes update old commits, and that couldn't be expressed
in event data. We never used the list anywhere in the first place.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:

(Trac.prototype._xmlTimelineURL): Made this function take arbitrary dates. When called
without arguments, return commits for today and yesterday.
(Trac.prototype._loaded):
(Trac.prototype.update): Moved the function for processing loaded results out of
here for clarity, and also because I'm going to have a separate loading code path
for metrics.

12:14 AM Changeset in webkit [172746] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r163179): It broke the build on ARM Thumb2 with GCC
​https://bugs.webkit.org/show_bug.cgi?id=136028

Patch by Michael Saboff <​msaboff@apple.com> on 2014-08-19
Reviewed by Oliver Hunt.

Added back ARMv7 conditionals around three op addp and subp since ARM Thumb2 spec says that
the behavior for those ops are undefined. This was originally done in changeset 163179.

  • llint/LowLevelInterpreter32_64.asm:

Aug 18, 2014:

11:12 PM Changeset in webkit [172745] by bshafiei@apple.com
  • 3 edits in branches/safari-600.1.4.11-branch/Source/WebCore

Merged r172317. <rdar://problem/18052514>

10:10 PM Changeset in webkit [172744] by commit-queue@webkit.org
  • 31 edits
    3 adds in trunk/Source

Unreviewed, rolling out r172736.
​https://bugs.webkit.org/show_bug.cgi?id=136060

Caused 14% PLT regressions (Requested by rniwa on #webkit).

Reverted changeset:

"Remove PurgeableBuffer since it is not very useful any more"
​https://bugs.webkit.org/show_bug.cgi?id=135939
​http://trac.webkit.org/changeset/172736

10:04 PM Changeset in webkit [172743] by dburkart@apple.com
  • 5 edits in branches/safari-600.1-branch/Source

Bump versioning

9:41 PM Changeset in webkit [172742] by commit-queue@webkit.org
  • 4 edits
    3 deletes in trunk/Source/JavaScriptCore

Unreviewed, rolling out r172741.
​https://bugs.webkit.org/show_bug.cgi?id=136058

This change is breaking PLT. (Requested by mlam on #webkit).

Reverted changeset:

"REGRESSION(r172401): for-in optimization no longer works at
all"
​https://bugs.webkit.org/show_bug.cgi?id=136056
​http://trac.webkit.org/changeset/172741

7:48 PM Changeset in webkit [172741] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk/Source/JavaScriptCore

REGRESSION(r172401): for-in optimization no longer works at all
​https://bugs.webkit.org/show_bug.cgi?id=136056

Reviewed by Mark Hahnenberg.

This is a partial roll-out of r172401. It turns out that the fix wasn't actually fixing a
real bug (since it's fine to use op_get_direct_pname on the wrong base because it has a
structure check) and it was actually breaking the entire for-in optimization (since there is
no way that we can statically prove that the base matches, because the base we see is a
newly created temporary, and anyway doing it right would be really hard in our bytecode
because it's 3AC form).

But, I added a new test for the problem, and kept the original test. Both the old test and
the new test prove that r172401 wasn't fixing what it thought it was fixing. To the extent
that it resolved crashes it was because it just disabled the for-in optimization entirely.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::pushIndexedForInScope):
(JSC::BytecodeGenerator::pushStructureForInScope):

  • bytecompiler/BytecodeGenerator.h:

(JSC::ForInContext::ForInContext):
(JSC::StructureForInContext::StructureForInContext):
(JSC::IndexedForInContext::IndexedForInContext):
(JSC::ForInContext::base): Deleted.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitMultiLoopBytecode):

  • tests/stress/for-in-base-reassigned.js: Added.
  • tests/stress/for-in-base-reassigned-later.js: Added.
  • tests/stress/for-in-base-reassigned-later-and-change-structure.js: Added.
7:46 PM Changeset in webkit [172740] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Mark shape-image-threshold-001.html as crashing in debug

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-08-18

The test css3/shapes/shape-outside/values/shape-image-threshold-001.html systematically assert
in debug. Skip the results until the author investigate.

7:31 PM Changeset in webkit [172739] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Gardening: build fix for non-Mac builds after r172737.
​https://bugs.webkit.org/show_bug.cgi?id=135750

Not reviewed.

6:04 PM Changeset in webkit [172738] by Simon Fraser
  • 7 edits in trunk/Source

Provide default implementations of all GraphicsLayerClient methods
​https://bugs.webkit.org/show_bug.cgi?id=136054

Reviewed by Tim Horton.
Source/WebCore:

Make none of the functions in GraphicsLayerClient pure virtual, since in many cases
subclasses don't need to provide their own implementations.

  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::notifyAnimationStarted):
(WebCore::GraphicsLayerClient::notifyFlushRequired):
(WebCore::GraphicsLayerClient::paintContents):

  • rendering/RenderLayerCompositor.h:

Source/WebKit2:

Remove overrides which are no longer required.

  • WebProcess/WebPage/PageOverlayController.h:
  • WebProcess/WebPage/ServicesOverlayController.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
5:55 PM Changeset in webkit [172737] by fpizlo@apple.com
  • 15 edits
    2 moves in trunk/Source/JavaScriptCore

REGRESSION(r172129): ftlopt branch merge made performance tests flakey crash
​https://bugs.webkit.org/show_bug.cgi?id=135750

Reviewed by Mark Lam.

This was caused by a rather embarrassing oversight in how the DFG tracks structures: we
could sometimes perform an optimization that requires a structure to be alive but forget to
ensure that the structure is actually kept alive. In particular, any watchpoint-based
optimizations involve setting watchpoints even if the code that got optimized is eventually
deleted because it is unreachable. All such optimizations would leave behind something in
the IR to tell us that we are interested in the structure and that therefore it should be
kept alive. But, IR can be deleted if it is unreachable.

The solution is to ensure that as soon as the DFG is made aware of a structure, it adds it
to the set of weak references.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::setOSREntryValue):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::normalizeClarity):
(JSC::DFG::AbstractValue::assertIsRegistered):
(JSC::DFG::AbstractValue::assertIsWatched): Deleted.

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::assertIsRegistered):
(JSC::DFG::AbstractValue::assertIsWatched): Deleted.

  • dfg/DFGCommon.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):

  • dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::addLazily):
(JSC::DFG::DesiredWeakReferences::contains):
(JSC::DFG::DesiredWeakReferences::reallyAdd):
(JSC::DFG::DesiredWeakReferences::visitChildren):

  • dfg/DFGDesiredWeakReferences.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::registerFrozenValues):
(JSC::DFG::Graph::convertToConstant):
(JSC::DFG::Graph::registerStructure):
(JSC::DFG::Graph::assertIsRegistered):
(JSC::DFG::Graph::assertIsWatched): Deleted.

  • dfg/DFGGraph.h:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGStructureAbstractValue.cpp:

(JSC::DFG::StructureAbstractValue::assertIsRegistered):
(JSC::DFG::StructureAbstractValue::assertIsWatched): Deleted.

  • dfg/DFGStructureAbstractValue.h:

(JSC::DFG::StructureAbstractValue::assertIsRegistered):
(JSC::DFG::StructureAbstractValue::assertIsWatched): Deleted.

  • dfg/DFGStructureRegistrationPhase.cpp: Copied from Source/JavaScriptCore/dfg/DFGWatchableStructureWatchingPhase.cpp.

(JSC::DFG::StructureRegistrationPhase::StructureRegistrationPhase):
(JSC::DFG::StructureRegistrationPhase::run):
(JSC::DFG::StructureRegistrationPhase::registerStructures):
(JSC::DFG::StructureRegistrationPhase::registerStructure):
(JSC::DFG::performStructureRegistration):
(JSC::DFG::WatchableStructureWatchingPhase::WatchableStructureWatchingPhase): Deleted.
(JSC::DFG::WatchableStructureWatchingPhase::run): Deleted.
(JSC::DFG::WatchableStructureWatchingPhase::tryWatch): Deleted.
(JSC::DFG::performWatchableStructureWatching): Deleted.

  • dfg/DFGStructureRegistrationPhase.h: Copied from Source/JavaScriptCore/dfg/DFGWatchableStructureWatchingPhase.h.
  • dfg/DFGWatchableStructureWatchingPhase.cpp: Removed.
  • dfg/DFGWatchableStructureWatchingPhase.h: Removed.
4:25 PM Changeset in webkit [172736] by psolanki@apple.com
  • 31 edits
    3 deletes in trunk/Source

Remove PurgeableBuffer since it is not very useful any more
​https://bugs.webkit.org/show_bug.cgi?id=135939

Reviewed by Geoffrey Garen.

Source/WebCore:

The usefulness of having purgeable memory for cached resources has diminished now that
WebKit uses file backed resources when possible. Since this is read only memory, it is in
essence "purgeable". Having the PurgeableBuffer code adds additional complexity that we
don't need. e.g. on my Mac, I am not seeing any entry for "WebCore purgeable data" when I
run vmmap against the web processes that I have running. It is used on iOS, however even
there much of the purgeable memory we create gets replaced by file backed memory once we get
the notification from CFNetwork.

No new tests because no functional changes.

  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorPageAgent.cpp:

(WebCore::prepareCachedResourceBuffer):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::subresource):

  • loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::hasPurgeableBuffer): Deleted.
(WebCore::ResourceBuffer::setShouldUsePurgeableMemory): Deleted.
(WebCore::ResourceBuffer::createPurgeableBuffer): Deleted.
(WebCore::ResourceBuffer::releasePurgeableBuffer): Deleted.

  • loader/ResourceBuffer.h:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::sheetText):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):

  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::image):
(WebCore::CachedImage::imageForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::destroyDecodedData):
(WebCore::CachedImage::canUseDiskImageCache):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::isSafeToMakePurgeable): Deleted.
(WebCore::CachedResource::makePurgeable): Deleted.
(WebCore::CachedResource::isPurgeable): Deleted.
(WebCore::CachedResource::wasPurged): Deleted.

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::resourceBuffer):
(WebCore::CachedResource::purgePriority): Deleted.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):
(WebCore::CachedScript::destroyDecodedData):

  • loader/cache/CachedScript.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::resourceForRequestImpl):
(WebCore::MemoryCache::pruneDeadResourcesToSize):
(WebCore::MemoryCache::evict):
(WebCore::MemoryCache::TypeStatistic::addResource):
(WebCore::MemoryCache::dumpStats):
(WebCore::MemoryCache::dumpLRULists):
(WebCore::MemoryCache::makeResourcePurgeable): Deleted.

  • loader/cache/MemoryCache.h:

(WebCore::MemoryCache::TypeStatistic::TypeStatistic):
(WebCore::MemoryCache::shouldMakeResourcePurgeableOnEviction): Deleted.

  • platform/PurgePriority.h: Removed.
  • platform/PurgeableBuffer.h: Removed.
  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::size):
(WebCore::SharedBuffer::data):
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::clear):
(WebCore::SharedBuffer::copy):
(WebCore::SharedBuffer::getSomeData):
(WebCore::SharedBuffer::adoptPurgeableBuffer): Deleted.
(WebCore::SharedBuffer::createPurgeableBuffer): Deleted.
(WebCore::SharedBuffer::releasePurgeableBuffer): Deleted.

  • platform/SharedBuffer.h:

(WebCore::SharedBuffer::hasPurgeableBuffer): Deleted.
(WebCore::SharedBuffer::shouldUsePurgeableMemory): Deleted.

  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::SharedBuffer):

  • platform/mac/PurgeableBufferMac.cpp: Removed.
  • platform/mac/SharedBufferMac.mm:

(WebCore::SharedBuffer::createCFData):

  • platform/soup/SharedBufferSoup.cpp:

Source/WebKit/mac:

  • Misc/WebCache.mm:

(+[WebCache statistics]):

Source/WebKit/win:

  • WebCache.cpp:

(WebCache::statistics):

Source/WebKit2:

  • WebProcess/WebProcess.cpp:

(WebKit::getWebCoreMemoryCacheStatistics):

Source/WTF:

  • wtf/Platform.h: Remove ENABLE_PURGEABLE_MEMORY define.
  • wtf/VMTags.h: Remove VM tags used by WebCore for cached resource purgeable memory.
4:22 PM Changeset in webkit [172735] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Use modern for loop instead of iterators in SharedBufferCF.cpp
​https://bugs.webkit.org/show_bug.cgi?id=136000

Reviewed by Andreas Kling.

  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::copyBufferAndClear):
(WebCore::SharedBuffer::copySomeDataFromDataArray):
(WebCore::SharedBuffer::maybeAppendDataArray): Use auto& instead of auto for less RetainPtr/refcount churn.

4:20 PM Changeset in webkit [172734] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix ASSERT in ARM64's JSC::GPRInfo::debugName
​https://bugs.webkit.org/show_bug.cgi?id=136050

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-08-18
Reviewed by Darin Adler.

Remove cast of GPRReg to unsigned to prevent signed/unsigned comparison
error.

  • jit/GPRInfo.h:

(JSC::GPRInfo::debugName):

4:10 PM Changeset in webkit [172733] by commit-queue@webkit.org
  • 2 edits
    405 adds in trunk/LayoutTests

[CSS Shapes] Import the CSS Shapes W3C test suite
​https://bugs.webkit.org/show_bug.cgi?id=135921

Patch by Rebecca Hauck <​rhauck@adobe.com> on 2014-08-18
Reviewed by Bem Jones-Bey.

This patch contains the imported CSS Shapes W3C test suite
brought in and converted to WebKit style using
Tools/Scripts/impoart-w3c-tests.

  • TestExpectations:
  • css3/shapes/shape-outside-invalid-001-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-001.html: Added.
  • css3/shapes/shape-outside-invalid-circle-000-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-circle-000.html: Added.
  • css3/shapes/shape-outside-invalid-circle-001-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-circle-001.html: Added.
  • css3/shapes/shape-outside-invalid-circle-002-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-circle-002.html: Added.
  • css3/shapes/shape-outside-invalid-circle-003-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-circle-003.html: Added.
  • css3/shapes/shape-outside-invalid-ellipse-001-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-ellipse-001.html: Added.
  • css3/shapes/shape-outside-invalid-ellipse-002-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-ellipse-002.html: Added.
  • css3/shapes/shape-outside-invalid-ellipse-003-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-ellipse-003.html: Added.
  • css3/shapes/shape-outside-invalid-ellipse-004-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-ellipse-004.html: Added.
  • css3/shapes/shape-outside-invalid-ellipse-005-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-ellipse-005.html: Added.
  • css3/shapes/shape-outside-invalid-ellipse-006-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-ellipse-006.html: Added.
  • css3/shapes/shape-outside-invalid-inset-001-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-inset-001.html: Added.
  • css3/shapes/shape-outside-invalid-inset-002-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-inset-002.html: Added.
  • css3/shapes/shape-outside-invalid-inset-003-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-inset-003.html: Added.
  • css3/shapes/shape-outside-invalid-inset-004-expected.txt: Added.
  • css3/shapes/shape-outside-invalid-inset-004.html: Added.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-002-expected.html: Added.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-002.html: Added.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-003-expected.html: Added.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-003.html: Added.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-004-expected.html: Added.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-004.html: Added.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-006-expected.html: Added.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-006.html: Added.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-007-expected.html: Added.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-007.html: Added.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-008-expected.html: Added.
  • css3/shapes/shape-outside/shape-box/shape-outside-box-008.html: Added.
  • css3/shapes/shape-outside/shape-box/w3c-import.log: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-001-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-001.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-002-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-002.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-003-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-003.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-004-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-004.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-001-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-001.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-002-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-002.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-003-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-003.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-004-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-004.html: Added.
  • css3/shapes/shape-outside/shape-image/gradients/w3c-import.log: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-000-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-000.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-001-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-001.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-002-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-002.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-003-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-003.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-004-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-004.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-005-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-005.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-012-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-012.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-013-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-013.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-014-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-014.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-015-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-015.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-016-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-016.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-017-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-017.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-018-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-018.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-019-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-019.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-020-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-020.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-021-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-021.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-022-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-022.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-023-expected.html: Added.
  • css3/shapes/shape-outside/shape-image/shape-image-023.html: Added.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle-20.png: Added.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle-20.svg: Added.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle-50.png: Added.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle-50.svg: Added.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle-70.png: Added.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle-70.svg: Added.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle.jpg: Added.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle.png: Added.
  • css3/shapes/shape-outside/shape-image/support/left-half-rectangle.svg: Added.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle-20.png: Added.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle-50.png: Added.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle-70.png: Added.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle-70.svg: Added.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle.gif: Added.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle.jpg: Added.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle.png: Added.
  • css3/shapes/shape-outside/shape-image/support/right-half-rectangle.svg: Added.
  • css3/shapes/shape-outside/shape-image/support/w3c-import.log: Added.
  • css3/shapes/shape-outside/shape-image/w3c-import.log: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-013-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-013.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-014-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-014.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-015-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-015.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-016-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-016.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-017-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-017.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-018-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-018.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-019-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-019.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-020-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-020.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-021-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-021.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-022-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-022.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-024-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-024.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-025-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-025.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-026-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-026.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-028-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-028.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-029-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-029.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-030-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-030.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-031-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-031.html: Added.
  • css3/shapes/shape-outside/supported-shapes/circle/w3c-import.log: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-013-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-013.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-014-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-014.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-016-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-016.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-018-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-018.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-019-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-019.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-020-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-020.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-021-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-021.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-022-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-022.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-023-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-023.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-024-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-024.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-025-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-025.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-030-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-030.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-031-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-031.html: Added.
  • css3/shapes/shape-outside/supported-shapes/ellipse/w3c-import.log: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-010-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-010.html: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-011-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-011.html: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-012-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-012.html: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-013-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-013.html: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-014-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-014.html: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-015-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-015.html: Added.
  • css3/shapes/shape-outside/supported-shapes/inset/w3c-import.log: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-007-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-007.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-008-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-008.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-009-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-009.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-010-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-010.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-011-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-011.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-012-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-012.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-013-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-013.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-014-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-014.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-015-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-015.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-016-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-016.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-017-expected.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-017.html: Added.
  • css3/shapes/shape-outside/supported-shapes/polygon/w3c-import.log: Added.
  • css3/shapes/shape-outside/supported-shapes/support/rounded-rectangle.js: Added.

(ellipseXIntercept):
(scanConvertRoundedRectangleOutside):
(genLeftRoundedRectFloatShapeOutsideRefTest):
(getRoundedRectLeftEdge):
(genRightRoundedRectFloatShapeOutsideRefTest):

  • css3/shapes/shape-outside/supported-shapes/support/subpixel-utils.js: Added.

(SubPixelLayout):
(SubPixelLayout.):

  • css3/shapes/shape-outside/supported-shapes/support/test-utils.js: Added.

(verifyTextPoints):

  • css3/shapes/shape-outside/values/shape-image-threshold-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-image-threshold-000.html: Added.
  • css3/shapes/shape-outside/values/shape-image-threshold-001-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-image-threshold-001.html: Added.
  • css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-image-threshold-002.html: Added.
  • css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-image-threshold-003.html: Added.
  • css3/shapes/shape-outside/values/shape-margin-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-margin-000.html: Added.
  • css3/shapes/shape-outside/values/shape-margin-001-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-margin-001.html: Added.
  • css3/shapes/shape-outside/values/shape-margin-002-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-margin-002.html: Added.
  • css3/shapes/shape-outside/values/shape-margin-003-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-margin-003.html: Added.
  • css3/shapes/shape-outside/values/shape-margin-004-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-margin-004.html: Added.
  • css3/shapes/shape-outside/values/shape-margin-005-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-margin-005.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-box-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-box-000.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-000.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-001-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-001.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-002-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-002.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-003.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-004-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-004.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-005-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-005.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-006.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-007.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-008.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-009-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-009.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-010-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-010.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-011-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-circle-011.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-computed-shape-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-computed-shape-000.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-computed-shape-001-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-computed-shape-001.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-000.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-001-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-001.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-002-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-002.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-003.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-004-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-004.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-005-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-005.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-006.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-007.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-008.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-009-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-009.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-010-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-010.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-011-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-ellipse-011.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-000.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-001-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-001.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-002-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-002.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-003-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-003.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-004-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-004.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-005.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-006.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-007.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-008-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-008.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-009-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-inset-009.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-000.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-001-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-001.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-002-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-002.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-003.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-004-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-004.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-005-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-005.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-006-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-polygon-006.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-arguments-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-arguments-000.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-arguments-001-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-arguments-001.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-box-pair-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-box-pair-000.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-inherit-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-inherit-000.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-initial-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-initial-000.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-none-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-none-000.html: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-notation-000-expected.txt: Added.
  • css3/shapes/shape-outside/values/shape-outside-shape-notation-000.html: Added.
  • css3/shapes/shape-outside/values/support/parsing-utils.js: Added.

(ParsingUtils):
(ParsingUtils.):

  • css3/shapes/shape-outside/values/support/w3c-import.log: Added.
  • css3/shapes/shape-outside/values/w3c-import.log: Added.
  • css3/shapes/spec-examples/shape-outside-001-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-001.html: Added.
  • css3/shapes/spec-examples/shape-outside-002-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-002.html: Added.
  • css3/shapes/spec-examples/shape-outside-003-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-003.html: Added.
  • css3/shapes/spec-examples/shape-outside-004-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-004.html: Added.
  • css3/shapes/spec-examples/shape-outside-005-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-005.html: Added.
  • css3/shapes/spec-examples/shape-outside-006-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-006.html: Added.
  • css3/shapes/spec-examples/shape-outside-007-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-007.html: Added.
  • css3/shapes/spec-examples/shape-outside-008-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-008.html: Added.
  • css3/shapes/spec-examples/shape-outside-010-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-010.html: Added.
  • css3/shapes/spec-examples/shape-outside-011-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-011.html: Added.
  • css3/shapes/spec-examples/shape-outside-012-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-012.html: Added.
  • css3/shapes/spec-examples/shape-outside-013-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-013.html: Added.
  • css3/shapes/spec-examples/shape-outside-014-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-014.html: Added.
  • css3/shapes/spec-examples/shape-outside-015-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-015.html: Added.
  • css3/shapes/spec-examples/shape-outside-016-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-016.html: Added.
  • css3/shapes/spec-examples/shape-outside-017-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-017.html: Added.
  • css3/shapes/spec-examples/shape-outside-018-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-018.html: Added.
  • css3/shapes/spec-examples/shape-outside-019-expected.html: Added.
  • css3/shapes/spec-examples/shape-outside-019.html: Added.
  • css3/shapes/spec-examples/support/circle-no-shadow.png: Added.
  • css3/shapes/spec-examples/support/circle-shadow.png: Added.
  • css3/shapes/spec-examples/support/rounded-triangle.svg: Added.
  • css3/shapes/spec-examples/support/w3c-import.log: Added.
  • css3/shapes/spec-examples/w3c-import.log: Added.
  • css3/shapes/w3c-import.log: Added.
3:42 PM Changeset in webkit [172732] by dburkart@apple.com
  • 4 edits in branches/safari-600.1-branch

Merged r172680. <rdar://problem/18049780>

3:39 PM Changeset in webkit [172731] by dburkart@apple.com
  • 5 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172660. <rdar://problem/18049780>

3:16 PM Changeset in webkit [172730] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Tighten RenderCounter typing
​https://bugs.webkit.org/show_bug.cgi?id=136049

Reviewed by Andreas Kling.

RenderObject* -> RenderElement&

  • rendering/CounterNode.cpp:

(WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::create):
(WebCore::showTreeAndMark):

  • rendering/CounterNode.h:

(WebCore::CounterNode::owner):

  • rendering/RenderCounter.cpp:

(WebCore::previousInPreOrder):
(WebCore::parentOrPseudoHostElement):
(WebCore::previousSiblingOrParent):
(WebCore::areRenderersElementsSiblings):
(WebCore::nextInPreOrder):
(WebCore::planCounter):
(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
(WebCore::RenderCounter::originalText):
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::RenderCounter::rendererRemovedFromTree):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererSubtreeAttached):
(WebCore::RenderCounter::rendererStyleChanged):
(showCounterRendererTree):

  • rendering/RenderCounter.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::styleDidChange):
(WebCore::RenderElement::willBeDestroyed):

  • rendering/RenderElement.h:

(WebCore::RenderElement::hasCounterNodeMap):
(WebCore::RenderElement::setHasCounterNodeMap):

Move CounterNodeMap to RenderElement from RenderObject.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderObject.h:

(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::hasCounterNodeMap): Deleted.
(WebCore::RenderObject::setHasCounterNodeMap): Deleted.

3:03 PM Changeset in webkit [172729] by commit-queue@webkit.org
  • 19 edits in trunk/Source

Expose long mouse press WebKit API. Part of 135257 - Add long mouse press gesture
​https://bugs.webkit.org/show_bug.cgi?id=136048

Patch by Peyton Randolph <​prandolph@apple.com> on 2014-08-18
Reviewed by Dan Bernstein.

This patch exposes long mouse press API callbacks in both the injected bundle and on the UI process
through their respective page UI clients. The callbacks are modeled off of the mouseDidMoveOverElement
callback. Like the mouseDidMoveOverElement callback, these callbacks allow the bundle to pass
information to the UI process via a userData out parameter.

Source/WebCore:

  • page/Chrome.cpp:

(WebCore::Chrome::didBeginTrackingPotentialLongMousePress): Added.
(WebCore::Chrome::didRecognizeLongMousePress): Added.
(WebCore::Chrome::didCancelTrackingPotentialLongMousePress): Added.

  • page/Chrome.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::didBeginTrackingPotentialLongMousePress): Added.
(WebCore::ChromeClient::didRecognizeLongMousePress): Added.
(WebCore::ChromeClient::didCancelTrackingPotentialLongMousePress): Added.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
Pass the press hit test result to kick off the long mouse press.
(WebCore::EventHandler::beginTrackingPotentialLongMousePress): Notify the chrome.
(WebCore::EventHandler::recognizeLongMousePress): Ditto.
(WebCore::EventHandler::cancelTrackingPotentialLongMousePress):
Ditto. Also opportunistically remove a runtime switch check to see if long pressing is enabled. The
runtime switch check was only triggered when long pressing was disabled in the middle of a long press.

  • page/EventHandler.h:

Source/WebKit2:

  • UIProcess/API/APIUIClient.h:

(API::UIClient::didBeginTrackingPotentialLongMousePress): Added.
(API::UIClient::didRecognizeLongMousePress): Added.
(API::UIClient::didCancelTrackingPotentialLongMousePress): Added.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/C/WKPageUIClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didBeginTrackingPotentialLongMousePress): Added.
(WebKit::WebPageProxy::didRecognizeLongMousePress): Added.
(WebKit::WebPageProxy::didCancelTrackingPotentialLongMousePress): Added.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:

(API::InjectedBundle::PageUIClient::didBeginTrackingPotentialLongMousePress): Added.
(API::InjectedBundle::PageUIClient::didRecognizeLongMousePress): Added.
(API::InjectedBundle::PageUIClient::didCancelTrackingPotentialLongMousePress): Added.

  • WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Added.

(WebKit::InjectedBundlePageUIClient::didBeginTrackingPotentialLongMousePress): Added.
(WebKit::InjectedBundlePageUIClient::didRecognizeLongMousePress): Added.
(WebKit::InjectedBundlePageUIClient::didCancelTrackingPotentialLongMousePress): Added.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::didBeginTrackingPotentialLongMousePress): Added.
(WebKit::WebChromeClient::didRecognizeLongMousePress): Added.
(WebKit::WebChromeClient::didCancelTrackingPotentialLongMousePress): Added.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
2:44 PM Changeset in webkit [172728] by mitz@apple.com
  • 3 edits in trunk/Tools

Added an update-webkit option to override the ../Internal check.
Part of ​https://bugs.webkit.org/show_bug.cgi?id=135815

Reviewed by Tim Horton.

  • Scripts/update-webkit:

Added an explicit --internal option to control updating ../Internal, defaulting to whether
../Internal exists.
(runSvnUpdate): Moved to webkitdirs.pm.
(runGitUpdate): Ditto.

  • Scripts/webkitdirs.pm:

(runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
(runGitUpdate): Moved from update-webkit.

2:33 PM Changeset in webkit [172727] by akling@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION(r168256): JSString can get 8-bit flag wrong when re-using AtomicStrings.
<​https://webkit.org/b/133574>
<rdar://problem/18051847>

Source/JavaScriptCore:

The optimization that resolves JSRopeStrings into an existing
AtomicString (to save time and memory by avoiding StringImpl allocation)
had a bug that it wasn't copying the 8-bit flag from the AtomicString.

This could lead to a situation where a 16-bit StringImpl containing
only 8-bit characters is sitting in the AtomicString table, is found
by the rope resolution optimization, and gives you a rope that thinks
it's all 8-bit, but has a fiber with 16-bit characters.

Resolving that rope will then yield incorrect results.

This was all caught by an assertion, but very hard to reproduce.

Test: js/dopey-rope-with-16-bit-propertyname.html

Reviewed by Darin Adler.

  • runtime/JSString.cpp:

(JSC::JSRopeString::resolveRopeToAtomicString):
(JSC::JSRopeString::resolveRopeToExistingAtomicString):

  • runtime/JSString.h:

(JSC::JSString::setIs8Bit):
(JSC::JSString::toExistingAtomicString):

LayoutTests:

Add a tests that creates a 16-bit AtomicString with only 8-bit characters,
then tiers up into baseline JIT and uses that string as part of a rope-within-a-rope
and serializes that rope to get an incorrect concatenation.

Reviewed by Darin Adler.

  • js/dopey-rope-with-16-bit-propertyname-expected.txt: Added.
  • js/dopey-rope-with-16-bit-propertyname.html: Added.
2:14 PM Changeset in webkit [172726] by psolanki@apple.com
  • 2 edits in trunk/Tools

Make update-webkit more lenient for pure git svn repositories
​https://bugs.webkit.org/show_bug.cgi?id=135805

Reviewed by Oliver Hunt.

Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
provide an optimization when you have a git repository setup. We should not fail if the
git setup does not have svn-remote.svn.fetch set.

  • Scripts/update-webkit:

(runGitUpdate):

2:14 PM Changeset in webkit [172725] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Fix unintentional integer overflow before widen
​https://bugs.webkit.org/show_bug.cgi?id=135463

Patch by Przemyslaw Kuczynski <​p.kuczynski@samsung.com> on 2014-08-18
Reviewed by Oliver Hunt.

Overflowing expression is evaluated using operands arithmetic but then is used in
context which expects an wider integer type. To avoid overflow at least one operand
has to be representative of the wider type.

Source/WebCore:

  • loader/FTPDirectoryParser.cpp:

(WebCore::parseOneFTPLine): Changed strtoul to strtoull.

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::incrementProgress): Added static_cast to long long.

  • platform/efl/FileSystemEfl.cpp:

(WebCore::getVolumeFreeSizeForPath): Added static_cast to uint64_t.

Source/WebKit2:

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::getMemorySize): Added long long literal.

2:11 PM Changeset in webkit [172724] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix resource leak in unclosed file descriptor handles
​https://bugs.webkit.org/show_bug.cgi?id=135458

Patch by Przemyslaw Kuczynski <​p.kuczynski@samsung.com> on 2014-08-18
Reviewed by Oliver Hunt.

Leaving descriptor unclosed will cause the resources associated with the open
file description never be freed (they are freed on closing the last descriptor
refering to the underlying file).

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::StdoutDevNullRedirector::StdoutDevNullRedirector): Closed newStdout descriptor.
(WebKit::StdoutDevNullRedirector::~StdoutDevNullRedirector): Closed m_savedStdout descriptor.

1:58 PM Changeset in webkit [172723] by vivek.vg@samsung.com
  • 5 edits
    2 adds in trunk

Implement CanvasRenderingContext2D direction attribute
​https://bugs.webkit.org/show_bug.cgi?id=135878

Reviewed by Darin Adler.

Source/WebCore:

The attribute, 'direction', represents the text directionality.
This is an important attribute for the bi-directional text within the CanvasRenderingContext2D.
The allowed set of values are 'rtl', 'ltr' and 'inherit'.

Specification URL: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting.html#dom-context-2d-direction

Test: fast/canvas/canvas-direction.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::inheritedDirection):
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::reset):
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::direction):
(WebCore::CanvasRenderingContext2D::setDirection):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

  • fast/canvas/canvas-direction-expected.txt: Added.
  • fast/canvas/canvas-direction.html: Added.
1:54 PM Changeset in webkit [172722] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: Introduce an inspector Abstract Syntax Tree.
​https://bugs.webkit.org/show_bug.cgi?id=135763

Patch by Saam Barati <​sbarati@apple.com> on 2014-08-18
Reviewed by Joseph Pecoraro.

This patch adds an Abstract Syntax Tree to the Web inspector.
This syntax tree is modeled off the Esprima.js syntax tree
which complies with the Mozilla Parser API:
​https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Parser_API
Script is the owner of the Web Inspector syntax tree, and has an API
for accessing its syntax tree property.

  • UserInterface/External/Esprima/esprima.js:
  • UserInterface/Main.html:
  • UserInterface/Models/Script.js:

(WebInspector.Script):
(WebInspector.Script.prototype.requestScriptSyntaxTree.makeSyntaxTreeAndCallCallback):
(WebInspector.Script.prototype._resolveResource):
(WebInspector.Script.prototype._makeSyntaxTree):

  • UserInterface/Models/ScriptSyntaxTree.js: Added.

(WebInspector.ScriptSyntaxTree):
(WebInspector.ScriptSyntaxTree.prototype.get parsedSuccessfully):
(WebInspector.ScriptSyntaxTree.prototype.forEachNode):
(WebInspector.ScriptSyntaxTree.prototype.):
(WebInspector.ScriptSyntaxTree.prototype.filter):
(WebInspector.ScriptSyntaxTree.prototype.filterForNodesInRange):
(WebInspector.ScriptSyntaxTree.prototype.filterByRange):
(WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
(WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
(WebInspector.ScriptSyntaxTree.prototype.updateTypes):
(WebInspector.ScriptSyntaxTree.prototype._defaultParserState):
(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._recurseArray):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):

1:52 PM Changeset in webkit [172721] by benjamin@webkit.org
  • 11 edits
    6 adds in trunk

The style is not updated correctly when the pseudo class :empty is applied on anything but the rightmost element
​https://bugs.webkit.org/show_bug.cgi?id=135999

Reviewed by Antti Koivisto.

Source/WebCore:

In Element's checkForEmptyStyleChange(), the style invalidation was only considering the invalidation of the element
for which the subtree has changed. When the pseudo class :empty is used with a sibling combinator (e.g. foo:empty+bar),
we were never invalidating the style of the element on which the selector applies.

This patch fixes the issue by invalidating the whole subtree rooted at the parent if the :empty rules applies
to siblings. A new flag "styleOfSiblingsAffectedByEmpty" is introduced to cover this case.

SelectorChecker just sets the flag all the time if any sibling rule exists.
This is overkill but that code is just there for non-jit cases.

SelectorCompiler does a better job and only sets the flag if matching anything else than the rightmost element.
There is a case not optimized, :empty with descendant (e.g. foo:empty>bar). Those cases are useless in practice,
it is not worth optimizing them.

Tests: fast/css/pseudo-element-updates-on-empty.html

fast/selectors/not-empty-adjacent-style-update.html
fast/selectors/not-empty-style-update.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::fragmentMatchesTheRightmostElement):
shouldUseRenderStyleFromCheckingContext() is renamed fragmentMatchesTheRightmostElement() because
it is now also used by generateElementIsEmpty() in a context where the Context's style is irrelevant.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::setStyleOfSiblingsAffectedByEmpty):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsEmpty):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsOnlyChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateRequestedPseudoElementEqualsToSelectorPseudoElement):
(WebCore::SelectorCompiler::shouldUseRenderStyleFromCheckingContext): Deleted.
(WebCore::SelectorCompiler::setElementStyleIsAffectedByEmptyAndUpdateRenderStyleIfNecessary): Deleted.

  • dom/Element.cpp:

(WebCore::checkForEmptyStyleChange):
(WebCore::Element::setStyleOfSiblingsAffectedByEmpty):
(WebCore::Element::rareDataStyleOfSiblingsAffectedByEmpty):

  • dom/Element.h:

(WebCore::Element::styleOfSiblingsAffectedByEmpty):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::styleOfSiblingsAffectedByEmpty):
(WebCore::ElementRareData::setStyleOfSiblingsAffectedByEmpty):
(WebCore::ElementRareData::ElementRareData):

LayoutTests:

  • fast/css/pseudo-element-updates-on-empty-expected.html: Added.
  • fast/css/pseudo-element-updates-on-empty.html: Added.
  • fast/selectors/empty-adjacent-style-update-expected.txt:
  • fast/selectors/empty-adjacent-style-update.html:
  • fast/selectors/empty-style-update-expected.txt:
  • fast/selectors/empty-style-update.html:
  • fast/selectors/not-empty-adjacent-style-update-expected.txt: Copied from LayoutTests/fast/selectors/empty-adjacent-style-update-expected.txt.
  • fast/selectors/not-empty-adjacent-style-update.html: Copied from LayoutTests/fast/selectors/empty-adjacent-style-update.html.
  • fast/selectors/not-empty-style-update-expected.txt: Copied from LayoutTests/fast/selectors/empty-style-update-expected.txt.
  • fast/selectors/not-empty-style-update.html: Copied from LayoutTests/fast/selectors/empty-style-update.html.
1:41 PM Changeset in webkit [172720] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Mac] Unreviewed merge correction.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformCompleteWheelEvent): Revert an
unintended change from r172705.

1:25 PM Changeset in webkit [172719] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit/ios

Fix the iOS build after r172709.

  • WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

12:52 PM Changeset in webkit [172718] by aestes@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

Remove a test inadvertently landed in r172709.

  • fast/loader/redirect-to-invalid-url-using-javascript-disallowed-after-load.html: Removed.
12:11 PM Changeset in webkit [172717] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

The parser should generate AST nodes the var declarations with no initializers
​https://bugs.webkit.org/show_bug.cgi?id=135545

Patch by Saam Barati <​sbarati@apple.com> on 2014-08-18
Reviewed by Geoffrey Garen.

Currently, JSC's parser ignores variable declarations
that have no assignment initializer value because all
variables are implicitly assigned to undefined. But,
type profiling needs an AST node to be generated for these
empty variable declarations because it needs to be able to
profile their text locations and to see that their type
is undefined.

  • bytecompiler/NodesCodegen.cpp:

(JSC::EmptyVarExpression::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createEmptyVarExpression):

  • parser/NodeConstructors.h:

(JSC::EmptyVarExpression::EmptyVarExpression):

  • parser/Nodes.h:
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseVarDeclarationList):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createEmptyVarExpression):

12:07 PM Changeset in webkit [172716] by Bem Jones-Bey
  • 2 edits in trunk/Source/WebCore

Small cleanup for ShapeOutsideDeltas
​https://bugs.webkit.org/show_bug.cgi?id=136043

Reviewed by Zoltan Horvath.

Remove explicit initializtion of LayoutUnit members and explicitly
size the boolean flags so they pack properly.

No new tests, no behavior change.

  • rendering/shapes/ShapeOutsideInfo.h:
11:55 AM Changeset in webkit [172715] by Simon Fraser
  • 2 edits in trunk/Tools

Enable Web Inspector in MiniBrowser WK2 windows
​https://bugs.webkit.org/show_bug.cgi?id=136045

Reviewed by Tim Horton.

Set the pref to enable developer extras for all WK2 windows.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

11:24 AM Changeset in webkit [172714] by dburkart@apple.com
  • 4 edits in tags/Safari-600.1.10.2

Merged r172680. <rdar://problem/18049780>

11:23 AM Changeset in webkit [172713] by dburkart@apple.com
  • 5 edits in tags/Safari-600.1.10.2/Source/WebKit2

Merged r172660. <rdar://problem/18049780>

11:21 AM Changeset in webkit [172712] by dburkart@apple.com
  • 5 edits in tags/Safari-600.1.10.2/Source

Bump versioning.

11:18 AM Changeset in webkit [172711] by krit@webkit.org
  • 20 edits
    2 adds in trunk

calc() doesn't work for SVG CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=136026

Reviewed by Andreas Kling.

Source/WebCore:

Make calc() work on SVG CSS properties as well. stroke-width and
stroke-dashoffset used SVGLength. SVGLength doesn't work together with
cross units length arguments like % and px (just returns 0 in these
cases). I moved these properties over to Length. All modified files
beside to SVGCSSParser are related to this switch.

Test: svg/css/parse-calc-length.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::svgPropertyValue):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • rendering/style/RenderStyle.h:
  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::setStrokeWidth):
(WebCore::SVGRenderStyle::setStrokeDashOffset):
(WebCore::SVGRenderStyle::strokeWidth):
(WebCore::SVGRenderStyle::strokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeDashOffset): Deleted.
(WebCore::SVGRenderStyle::initialStrokeWidth): Deleted.

  • rendering/style/SVGRenderStyleDefs.cpp:

(WebCore::StyleStrokeData::StyleStrokeData):

  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeWidth):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::strokeBoundingBox):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::applyStrokeStyleToContext):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeStyle):

  • svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::valueForLength):

LayoutTests:

Test calc() on length properties for SVG.

  • svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/parse-calc-length-expected.txt: Added.
  • svg/css/parse-calc-length.html: Added.
10:55 AM Changeset in webkit [172710] by dburkart@apple.com
  • 1 copy in tags/Safari-600.1.10.2

Tagging

10:48 AM Changeset in webkit [172709] by aestes@apple.com
  • 13 edits
    12 adds
    10 deletes in trunk

REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
​https://bugs.webkit.org/show_bug.cgi?id=136010

Reviewed by Darin Adler.

Source/WebCore:

r167856 caused WebKit to stop scheduling certain kinds of navigations (window.location changes, meta-refresh,
and some calls to window.open) when the request URL is invalid. Adobe.com performs one of these navigations to
an invalid URL with an external scheme (aam:), relying on Safari's navigation policy delegate to ignore the
navigation and launch the external app registered to handle aam: URLs. Since the navigation is no longer
scheduled, the policy delegate is never executed and the external app never launches.

Instead of not scheduling the navigation, allow it to proceed until the client's policy delegate has executed
and made a decision. Only disallow the navigation if the policy delegate told WebKit to proceed with the load.
This exposes these navigations to clients via the policy delegate and via willPerformClientRedirectToURL and
didCancelClientRedirectForFrame on the frame load delegate.

To constrain this check only to the navigation types covered by r167856, only two NavigationSchedulers
(ScheduledRedirect and ScheduledLocationChange) enable the invalid URL check.

Note that r167856 also caused an iOS regression, and this was resolved in r170120 by adding a linked-on-or-after
check and a WebCore setting. Since the iOS regression is also resolved by the approach described above, this
patch reverts r170120 (but keeps some of its tests).

Tests: fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html

fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
fast/loader/window-open-to-invalid-url-calls-policy-delegate.html
fast/loader/window-open-to-invalid-url-disallowed.html

  • WebCore.exp.in: Updated the symbol FrameLoader::loadFrameRequest.
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation): Added an AllowNavigationToInvalidURL argument; passed down to urlSelected.
(WebCore::FrameLoader::urlSelected): Added an AllowNavigationToInvalidURL argument; passed down to loadFrameRequest.
(WebCore::FrameLoader::loadURLIntoChildFrame): Passed AllowNavigationToInvalidURL::Yes to loadURL.
(WebCore::FrameLoader::loadFrameRequest): Added an AllowNavigationToInvalidURL argument; passed down to loadURL and loadPostRequest.
(WebCore::FrameLoader::loadURL): Added an AllowNavigationToInvalidURL argument; passed down to continueLoadAfterNewWindowPolicy and loadWithNavigationAction.
(WebCore::FrameLoader::loadPostRequest): Ditto.
(WebCore::FrameLoader::load): Passed AllowNavigationToInvalidURL::Yes to continueLoadAfterNewWindowPolicy.
(WebCore::FrameLoader::loadWithNavigationAction): Added an AllowNavigationToInvalidURL argument; passed down to loadWithDocumentLoader.
(WebCore::FrameLoader::loadWithDocumentLoader): Added an AllowNavigationToInvalidURL argument; passed down to continueLoadAfterNavigationPolicy.
(WebCore::FrameLoader::reloadWithOverrideEncoding): Passed AllowNavigationToInvalidURL::Yes to loadWithDocumentLoader.
(WebCore::FrameLoader::reload): Ditto.
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

Added an AllowNavigationToInvalidURL argument; if its value is No and the request's URL is invalid, do not continue.
Added a FIXME about calling clientRedirectCancelledOrFinished on non-quick redirect cancellations.

(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Added an AllowNavigationToInvalidURL argument; passed down to loadWithNavigationAction.
(WebCore::FrameLoader::loadDifferentDocumentItem): Passed AllowNavigationToInvalidURL::Yes to either loadWithDocumentLoader or loadWithNavigationAction.

  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h: Defined AllowNavigationToInvalidURL to have values of Yes and No.
  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledRedirect::fire): Passed AllowNavigationToInvalidURL::No to FrameLoader::changeLocation.
(WebCore::ScheduledLocationChange::fire): Ditto.
(WebCore::NavigationScheduler::shouldScheduleNavigation): Removed the URL::isValid check.
(WebCore::NavigationScheduler::scheduleLocationChange): Passed AllowNavigationToInvalidURL::No to FrameLoder::changeLocation during fragment navigations.

  • page/ContextMenuController.cpp:

(WebCore::openNewWindow): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.

  • page/Settings.in: Removed allowNavigationToInvalidURL.

Source/WebKit/mac:

  • Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary.

LayoutTests:

Removed tests that verified the behavior of setAllowNavigationToInvalidURL(true), which no longer exists:

  • fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt: Removed.
  • fast/loader/allow-redirect-to-invalid-url-using-javascript.html: Removed.
  • fast/loader/allow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Removed.
  • fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html: Removed.

Added tests that verify the policy delegate is executed on some navigations to invalid URLs:

  • fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate-expected.txt: Added.
  • fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html: Added.
  • fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-expected.txt: Added.
  • fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html: Added.
  • fast/loader/window-open-to-invalid-url-calls-policy-delegate-expected.txt: Added.
  • fast/loader/window-open-to-invalid-url-calls-policy-delegate.html: Added.

Renamed some existing tests added in r170120, modified them to log willPerformClientRedirectToURL and
didCancelClientRedirectForFrame, and added a test to verify navigations in existing frames via window.open:

  • fast/loader/redirect-to-invalid-url-using-javascript-disallowed-expected.txt: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-javascript-expected.txt.
  • fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-javascript.html.
  • fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed-expected.txt: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh-expected.txt.
  • fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html.
  • fast/loader/window-open-to-invalid-url-disallowed-expected.txt: Added.
  • fast/loader/window-open-to-invalid-url-disallowed.html: Added.
10:08 AM Changeset in webkit [172708] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

10:08 AM Changeset in webkit [172707] by commit-queue@webkit.org
  • 11 edits in trunk

Completed iterator can be revived by adding more than one new entry to the target object
​https://bugs.webkit.org/show_bug.cgi?id=129993

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-08-18
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

When iterator reaches end, finish iterator.

  • runtime/JSMapIterator.h:

(JSC::JSMapIterator::finish):

  • runtime/JSSetIterator.h:

(JSC::JSSetIterator::finish):

  • runtime/MapData.h:

(JSC::MapData::const_iterator::finish): set index of iterator to max
Int32.

  • runtime/MapIteratorPrototype.cpp:

(JSC::MapIteratorPrototypeFuncNext):

  • runtime/SetIteratorPrototype.cpp:

(JSC::SetIteratorPrototypeFuncNext):

LayoutTests:

Test a Map or Set iterator should remain dead after using it.

  • js/basic-map-expected.txt:
  • js/basic-set-expected.txt:
  • js/script-tests/basic-map.js:

(set var):
(set map):

  • js/script-tests/basic-set.js:

(keys.set keys):
(set add.set add):

10:02 AM Changeset in webkit [172706] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Fix keyTimes list length of from/to/by animations.
​https://bugs.webkit.org/show_bug.cgi?id=136037

Patch by Renata Hodovan <​rhodovan.u-szeged@partner.samsung.com> on 2014-08-18
Reviewed by Darin Adler.

Source/WebCore:

For from/to/by animations, the length of keyTimes and keyPoints
attribute if are specified must be equal and must have at least
2 values.

This is backport of my fix in Blink: ​https://codereview.chromium.org/453243003/

Test: svg/animations/invalid-keytime-number-crash.html

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::startedActiveInterval):

LayoutTests:

  • svg/animations/invalid-keytime-number-crash-expected.txt: Added.
  • svg/animations/invalid-keytime-number-crash.html: Added.
9:51 AM Changeset in webkit [172705] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[Mac] Follow-up to r136040 based on Darin Adler's comments.

Pass Widget* as a Widget&, since it can never be null.

  • page/EventHandler.cpp:

(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent):
(WebCore::EventHandler::handleWheelEvent):

  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformCompleteWheelEvent):
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent):

9:35 AM Changeset in webkit [172704] by Bem Jones-Bey
  • 2 edits in trunk/Websites/webkit.org

Remove people that have left Adobe from Security Contact list
​https://bugs.webkit.org/show_bug.cgi?id=135256

Reviewed by Alexey Proskuryakov.

  • security/security-group-members.html:
8:54 AM Changeset in webkit [172703] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[Mac] Gesture scrolls don't work in the WebKit1 clients after scrolling a non-scrollable iFrame
​https://bugs.webkit.org/show_bug.cgi?id=136029
<rdar://problem/17767169>

Reviewed by Maciej Stachowiak.

This is difficult to test in our layout tests, since it relies on specific host application
behavior.

If the platform widget is a frame view (IFrame), and we are in WebKit1, 'passWheelEventToWidget'
has already called 'scrollWheel' on the underlying platform widget. We need to return true in
this case to avoid getting multiple copies of the scrollWheel event sent to the platform widget.

  • page/EventHandler.cpp:

(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Revise default stub to
accept a Widget* argument.
(WebCore::EventHandler::handleWheelEvent):

  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Check for WK1 case and
return 'true' when the underlying NSScrollView has been issues a scrollWheel event.

3:01 AM Changeset in webkit [172702] by zandobersek@gmail.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed GTK gardening. Adding a GTK-specific baseline
that's required after changes in r172620.

  • platform/gtk/editing/pasteboard/onpaste-text-html-expected.txt: Added.
2:52 AM Changeset in webkit [172701] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

master.cfg should handle special return codes of run-perf-tests
​https://bugs.webkit.org/show_bug.cgi?id=135974

Patch by Renato Nagy <​nagy.renato@stud.u-szeged.hu> on 2014-08-18
Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunAndUploadPerfTests.getText2):

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunAndUploadPerfTestsTest):
(RunAndUploadPerfTestsTest.assertResults):
(RunAndUploadPerfTestsTest.test_tests_failed):
(RunAndUploadPerfTestsTest.test_build_bad_build):
(RunAndUploadPerfTestsTest.test_build_bad_source_json):
(RunAndUploadPerfTestsTest.test_build_bad_marge):
(RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
(RunAndUploadPerfTestsTest.test_build_bad_preparation):

1:16 AM Changeset in webkit [172700] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL] ewk_init() is sufficient to initialize EFL components
​https://bugs.webkit.org/show_bug.cgi?id=136036

Reviewed by Gyuyoung Kim.

Developers do not have to initialize EFL components as ewk_init()
already does it.

  • UIProcess/API/efl/ewk_intro.h:
12:35 AM Changeset in webkit [172699] by aestes@apple.com
  • 8 edits
    1 move
    10 adds
    11 deletes in trunk

Revert r172697.

It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects.

Source/WebCore:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

  • loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::shouldScheduleNavigation):

  • page/Settings.in:

Source/WebKit/mac:

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

LayoutTests:

  • fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt: Added.
  • fast/loader/allow-redirect-to-invalid-url-using-javascript.html: Added.
  • fast/loader/allow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Added.
  • fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html: Added.
  • fast/loader/disallow-redirect-to-invalid-url-using-javascript-expected.txt: Added.
  • fast/loader/disallow-redirect-to-invalid-url-using-javascript.html: Added.
  • fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Added.
  • fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html: Added.
  • fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate-expected.txt: Removed.
  • fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html: Removed.
  • fast/loader/redirect-to-invalid-url-using-javascript-disallowed-expected.txt: Removed.
  • fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html: Removed.
  • fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-expected.txt: Removed.
  • fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html: Removed.
  • fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed-expected.txt: Removed.
  • fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html: Removed.
  • fast/loader/resources/redirect-to-invalid-url-using-javascript.html: Added.
  • fast/loader/resources/redirect-to-invalid-url-using-meta-refresh.html: Added.
  • fast/loader/window-open-to-invalid-url-calls-policy-delegate-expected.txt: Removed.
  • fast/loader/window-open-to-invalid-url-calls-policy-delegate.html: Removed.
  • fast/loader/window-open-to-invalid-url-disallowed-expected.txt: Removed.
  • fast/loader/window-open-to-invalid-url-disallowed.html: Removed.

Aug 17, 2014:

11:03 PM Changeset in webkit [172698] by zandobersek@gmail.com
  • 4 edits in trunk

[CMake] Optimization-disabling compiler flags should be appended to CMAKE_C(XX)_FLAGS_RELEASE
​https://bugs.webkit.org/show_bug.cgi?id=135980

Reviewed by Martin Robinson.

CMAKE_C(XX)_FLAGS_RELEASE variables usually contain the -On flag which
overrides any other disabled optimization that was prepended to these
variables or was added to the CMAKE_C(XX)_FLAGS variables which CMake
lists first in the final list of compilation flags.

To avoid -On re-enabling optimizations that we'd like to keep disabled,
the specific compiler flags must be appended to CMAKE_C(XX)_FLAGS_RELEASE.

  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/OptionsEfl.cmake: Also do the appending with CMAKE_SHARED_LINKER_FLAGS_RELEASE.
  • Source/cmake/OptionsGTK.cmake:
9:37 PM Changeset in webkit [172697] by aestes@apple.com
  • 8 edits
    12 adds
    10 deletes in trunk

REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
​https://bugs.webkit.org/show_bug.cgi?id=136010

Reviewed by Darin Adler.

Source/WebCore:

r167856 caused WebKit to stop scheduling certain kinds of navigations (window.location changes, meta-refresh,
and some calls to window.open) when the request URL is invalid. Adobe.com performs one of these navigations to
an invalid URL with an external scheme (aam:), relying on Safari's navigation policy delegate to ignore the
navigation and launch the external app registered to handle aam: URLs. Since the navigation is no longer
scheduled, the policy delegate is never executed and the external app never launches.

Instead of not scheduling the navigation, allow it to proceed until the client's policy delegate has executed
and made a decision. Only disallow the navigation if the policy delegate told WebKit to proceed with the load.
This exposes these navigations to clients via the policy delegate and via willPerformClientRedirectToURL and
didCancelClientRedirectForFrame on the frame load delegate.

Note that r167856 also caused an iOS regression, and this was resolved in r170120 by adding a linked-on-or-after
check and a WebCore setting. Since the iOS regression is also resolved by the approach described above, this
patch reverts r170120 (but keeps some of its tests).

Tests: fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html

fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
fast/loader/window-open-to-invalid-url-calls-policy-delegate.html
fast/loader/window-open-to-invalid-url-disallowed.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Do not continue if the navigation will be a redirect
to an invalid URL.

  • loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::shouldScheduleNavigation): Resumed scheduling navigations to invalid URLs.

  • page/Settings.in: Removed the allowNavigationToInvalidURL setting.

Source/WebKit/mac:

Reverted the linked-on-or-after check added in r170120 since it is no longer necessary.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

LayoutTests:

Removed tests that verified the behavior of setAllowNavigationToInvalidURL(true), which no longer exists:

  • fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt: Removed.
  • fast/loader/allow-redirect-to-invalid-url-using-javascript.html: Removed.
  • fast/loader/allow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Removed.
  • fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html: Removed.

Added tests that verify the policy delegate is executed on some navigations to invalid URLs:

  • fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate-expected.txt: Added.
  • fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html: Added.
  • fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-expected.txt: Added.
  • fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html: Added.
  • fast/loader/window-open-to-invalid-url-calls-policy-delegate-expected.txt: Added.
  • fast/loader/window-open-to-invalid-url-calls-policy-delegate.html: Added.

Renamed some existing tests added in r170120, modified them to log willPerformClientRedirectToURL and
didCancelClientRedirectForFrame, and added a test to verify navigations in existing frames via window.open:

  • fast/loader/redirect-to-invalid-url-using-javascript-disallowed-expected.txt: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-javascript-expected.txt.
  • fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-javascript.html.
  • fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed-expected.txt: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh-expected.txt.
  • fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html.
  • fast/loader/window-open-to-invalid-url-disallowed-expected.txt: Added.
  • fast/loader/window-open-to-invalid-url-disallowed.html: Added.
12:54 PM Changeset in webkit [172696] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Unreviewed change to force rebuild
(plus drive-by add an accessor I wanted for
some future tooling).

  • WinLauncher/WinLauncher.h:

(WinLauncher::webView): Added.

8:35 AM Changeset in webkit [172695] by Brent Fulgham
  • 2 edits in trunk/WebKitLibraries

[Win] Unreviewed build fix.

Upload static VS2013 version of WebKitSystemInterface.

  • win/lib32/WebKitSystemInterface.lib:

Aug 16, 2014:

3:52 PM Changeset in webkit [172694] by mjs@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove the obsolete WebKitEnableCoalescedUpdatesPreferenceKey
​https://bugs.webkit.org/show_bug.cgi?id=136024

Reviewed by Filip Pizlo.

  • WebView/WebFrameView.mm:

(-[WebFrameView initWithFrame:]): Remove code that respects
this key. It was SPI and is no longer used; also it was
only relevant for versions of OS X that WebKit no longer supports.

  • WebView/WebPreferenceKeysPrivate.h: Remove declaration.
1:32 PM Changeset in webkit [172693] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r164173): Safari AutoFill button in popover, default buttons on iCloud control panel and Safari Safe Browsing pages don't have default appearance
​https://bugs.webkit.org/show_bug.cgi?id=136011

Reviewed by Sam Weinig.

When we render some controls, we need to make sure the NSWindow subclass we
use as the host of the AppKit views identifies itself as the key window (if
the control state is correct). We already have a flag tracking this for
key appearance - just make sure we do the same for isKeyWindow.

  • platform/mac/ThemeMac.mm:

(-[WebCoreThemeWindow isKeyWindow]): New override to mirror the static
variable for key appearance.

12:26 PM Changeset in webkit [172692] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Update contributors.json for my new email
​https://bugs.webkit.org/show_bug.cgi?id=136021

Patch by Mark Hahnenberg <​mhahnenb@gmail.com> on 2014-08-16
Reviewed by Filip Pizlo.

  • Scripts/webkitpy/common/config/contributors.json:
12:01 PM Changeset in webkit [172691] by psolanki@apple.com
  • 3 edits
    2 moves in trunk/Source/WebKit2

Rename DiskCacheMonitor to NetworkDiskCacheMonitor
​https://bugs.webkit.org/show_bug.cgi?id=135897

Reviewed by Andreas Kling.

In preparation for moving DiskCacheMonitor code to WebCore in bug 135896, rename the WebKit2
class to NetworkDiskCacheMonitor.

  • NetworkProcess/mac/NetworkDiskCacheMonitor.h: Renamed from Source/WebKit2/NetworkProcess/mac/DiskCacheMonitor.h.

(WebKit::NetworkDiskCacheMonitor::resourceRequest):

  • NetworkProcess/mac/NetworkDiskCacheMonitor.mm: Renamed from Source/WebKit2/NetworkProcess/mac/DiskCacheMonitor.mm.

(WebKit::NetworkDiskCacheMonitor::monitorFileBackingStoreCreation):
(WebKit::NetworkDiskCacheMonitor::NetworkDiskCacheMonitor):
(WebKit::NetworkDiskCacheMonitor::messageSenderConnection):
(WebKit::NetworkDiskCacheMonitor::messageSenderDestinationID):

  • NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::willCacheResponseAsync):

  • WebKit2.xcodeproj/project.pbxproj:
7:26 AM Changeset in webkit [172690] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] build fails with error: cannot allocate an object of abstract type 'WebKit::PageClientImpl'
​https://bugs.webkit.org/show_bug.cgi?id=136017

Patch by Byungseon Shin <​sun.shin@lge.com> on 2014-08-16
Reviewed by Gyuyoung Kim.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
(WebKit::PageClientImpl::didFinishLoadForMainFrame):

  • UIProcess/API/gtk/PageClientImpl.h:
2:25 AM Changeset in webkit [172689] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Improve performance of selection range changes viewing Scripts timeline
​https://bugs.webkit.org/show_bug.cgi?id=136015

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-16
Reviewed by Timothy Hatcher.

  • UserInterface/Base/Utilities.js:

(clamp):
Helper function to clamp a value between a min and max.

  • UserInterface/Models/ProfileNode.js:

(WebInspector.ProfileNode.prototype.get startTime):
(WebInspector.ProfileNode.prototype.get endTime):
These can be quickly calculated, so avoid full calculation to grab the values.

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype.updateLayout):
Update ranges with a smart helper, instead of blindly doing it and needing refresh.

  • UserInterface/Views/ProfileNodeDataGridNode.js:

(WebInspector.ProfileNodeDataGridNode.prototype.get rangeEndTime):
(WebInspector.ProfileNodeDataGridNode.prototype.get data):
(WebInspector.ProfileNodeDataGridNode.prototype.updateRangeTimes):
(WebInspector.ProfileNodeDataGridNode.prototype.set rangeStartTime): Deleted.
(WebInspector.ProfileNodeDataGridNode.prototype.set rangeEndTime): Deleted.

  • UserInterface/Views/ScriptTimelineDataGridNode.js:

(WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
(WebInspector.ScriptTimelineDataGridNode.prototype.set rangeStartTime): Deleted.
(WebInspector.ScriptTimelineDataGridNode.prototype.set rangeEndTime): Deleted.
When updating the range selection, compare to the last range selection
on this DataGridNode. If the visible portion of this node's time range
changes, we need a refresh. Otherwise, we don't need a refresh.

Note: See TracTimeline for information about the timeline view.