Timeline
Apr 4, 2015:
- 11:51 PM Changeset in webkit [182355] by
-
- 3 edits2 adds2 deletes in trunk
AX: Heuristic: Avoid exposing an element as clickable if mouse event delegation is handled on an AXElement with more than one descendant AXElement
https://bugs.webkit.org/show_bug.cgi?id=136247
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Modify the logic for determining whether an element supports the press action by trying to filter out objects being handled by event delegation.
The heuristic is if an element handles click actions and has more than one of a {static text, image, control, link, heading}, then we think
it's using event delegation, and do not expose the press action.
Test: platform/mac/accessibility/press-action-not-exposed-for-event-delegation.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsPressAction):
LayoutTests:
- platform/mac/accessibility/press-action-not-exposed-when-body-is-click-handler-expected.txt: Removed.
- platform/mac/accessibility/press-action-not-exposed-when-body-is-click-handler.html: Removed.
- platform/mac/accessibility/press-action-not-exposed-for-event-delegation-expected.txt: Added.
- platform/mac/accessibility/press-action-not-exposed-for-event-delegation.html: Added.
- 11:11 PM Changeset in webkit [182354] by
-
- 5 edits in trunk/Source/WebCore
More const in CSSToStyleMap
https://bugs.webkit.org/show_bug.cgi?id=143409
Reviewed by Andreas Kling.
The CSSValues passed to CSSToStyleMap functions can mostly be treated
as |const|, except for CSSImageValues which have special behavior.
This makes it clearer what the inputs and outputs of these
functions are.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeDegrees):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::computeTime):
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapAnimationTrigger):
- css/CSSToStyleMap.h:
- 8:09 PM Changeset in webkit [182353] by
-
- 4 edits in trunk/LayoutTests
Fix some bad test results committed earlier.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-element-with-multiple-handlers-crash-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-crash-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-parent-crash-expected.txt:
- 8:01 PM Changeset in webkit [182352] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix the build.
- loader/icon/IconController.cpp:
(WebCore::iconsFromLinkElements):
- 6:01 PM Changeset in webkit [182351] by
-
- 26 edits3 deletes in trunk
Streamline icon-related code, mostly unused
https://bugs.webkit.org/show_bug.cgi?id=143306
Reviewed by Antti Koivisto.
Source/WebCore:
I started on this path because Document::iconURLs had a poor implementation,
storing results in a data member with no benefit, using HTMLCollection for
iteration of the children of the head element instead of using the simpler
faster technique we use inside the engine. Then, I discovered this function was
mostly-unused code left over from before the Blink fork. I removed most of it.
We can add this back later if someone finds a use for it, but if we do we
should do a higher quality implementation without the quirks of the old one.
Refactoring also made it clear that logic isn't exactly sensible. There's a
set of rules about what order to return the list in that is not followed by
the code that tries to find the "default touch icon". Later we could add some
more test coverage and tighten up the logic. But the reality is that at this
time, with some small exceptions, icon logic is in the web browsers, not in WebKit.
- CMakeLists.txt: Removed IconURL.cpp.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/DOMAllInOne.cpp: Ditto.
- dom/Document.cpp:
(WebCore::Document::evaluate): Tweaked formatting.
(WebCore::Document::shortcutIconURLs): Removed. Unused function.
(WebCore::Document::iconURLs): Removed. Moved code to IconController.
(WebCore::Document::addIconURL): Removed. Moved code to LinkLoader.
- dom/Document.h: Removed shortcutIconURLs, iconURLs, addIconURL,
and m_iconURLs.
- dom/IconURL.cpp: Removed.
- dom/IconURL.h: Removed everything from this header except for the
IconType enum. Added a FIXME about possibly renaming the header.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement): Pass a reference when creating
the link loading.
(WebCore::HTMLLinkElement::setDisabledState): Access members of the struct
LinkRelElement without "m_" prefix.
(WebCore::HTMLLinkElement::parseAttribute): Changed to use early return style,
and made the part of this for parsing title use a more normal idiom.
(WebCore::HTMLLinkElement::process): Removed many unneeded arguments, made the
logic of the code a little easier to follow.
(WebCore::HTMLLinkElement::removedFrom): Removed a call to a function that had
an empty body.
(WebCore::HTMLLinkElement::iconType): Updated for change to LinkRelElement.
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLLinkElement.h: More of the same.
- html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute): Initialize data members in the
struct itself. Got rid of "m_" prefix since this is a struct, not a class.
Changed code to use modern for loop; even better would be to eliminate the
splitting into a vector entirely and use StringView (do that next time).
- html/LinkRelAttribute.h: See above.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::relAttributeIsStyleSheet):
Updated for chnages to LinkRelAttribute and give the local variable a clearer name.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::didChangeIcons): Removed.
- loader/FrameLoader.h: Removed didChangeIcons.
- loader/FrameLoaderClient.h: Added include for String since it's no longer
taken care of by IconURLs.h.
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::LinkLoader): Take a reference instead of a pointer.
(WebCore::LinkLoader::linkLoadTimerFired): Use m_client reference instead of pointer.
(WebCore::LinkLoader::linkLoadingErrorTimerFired): Ditto.
(WebCore::LinkLoader::notifyFinished): Use nullptr.
(WebCore::LinkLoader::loadLink): Tweak formatting. Move the dispatchDidChangeIcons
call in here instead of going through Document to FrameLoader and then FrameLoader to
FrameLoaderClient, and passing extra unused arguments, the way the old code did.
Use a reference instead of a pointer for the document.
(WebCore::LinkLoader::released): Removed. Empty function.
- loader/LinkLoader.h: Changed constructor argument to be a reference. Made more
things private. Removed empty released function.
- loader/icon/IconController.cpp:
(WebCore::IconController::IconController): Moved initialization of data members to
the class definition in the header.
(WebCore::iconsFromLinkElements): Added. This function replaces the existing
Document::iconURLs function, but has a simpler implementation and interface.
It focuses on exactly what the code in this file needs. If we want to add some
more features to the icon controller we might make this more complex again.
Even now, building a vector is not necessarily helpful; the only client of this
function ends up extracting only one of the URLs this function returns.
(WebCore::IconController::url): Rewrote this. It's the only function actually
using the icon URLs. This contains a combination of the logic from the various
functions in this class before, including iconURL, urlsForTypes, appendToIconURLs,
and defaultURL. Among other improvements, replaced the unusual code to construct
the icon URL with a call to Document::completeURL.
(WebCore::IconController::startLoader): Refactored a bit to remove a local variable.
(WebCore::IconController::continueLoadWithDecision): Ditto.
- loader/icon/IconController.h: Removed unneeded includes, unneeded use of
WTF_MAKE_NONCOPYABLE (since classes with data members of reference type are
automatically noncopyable), unused fucntions. Also initialize m_waitingForLoadDecision.
- testing/Internals.cpp:
(WebCore::Internals::iconURLs): Removed.
(WebCore::Internals::shortcutIconURLs): Left this in place since it is used by
tests. Changed it to return the actual value from the IconController::url function,
since that's the interface to our icon machinery that is actually exposed on some
platforms. That means this returns only a single URL.
(WebCore::Internals::allIconURLs): Removed.
- testing/Internals.h: Removed allIconURLs and iconURLs.
- testing/Internals.idl: Removed allIconURLs.
LayoutTests:
- fast/dom/icon-url-list-apple-touch-expected.txt: Removed.
- fast/dom/icon-url-list-apple-touch.html: Removed. This tested code that was
not actually used in any WebKit port.
- fast/dom/icon-url-list.html: Updated to expect only a single icon URL;
the icon machinery in WebKit doesn't return arrays at this time. It's better to
test what we actually expose.
- 5:53 PM Changeset in webkit [182350] by
-
- 2 edits in trunk/Source/WebCore
Fix EFL and Gtk build.
- dom/Document.cpp:
(WebCore::Document::didRemoveTouchEventHandler):
- 5:51 PM Changeset in webkit [182349] by
-
- 5 edits6 adds in trunk
Crash under Document::absoluteRegionForEventTargets on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=143406
rdar://problem/20407080
Reviewed by Ryosuke Niwa.
Source/WebCore:
We failed to remove elements from Document's m_wheelEventTargets HashSet when the
elements were destroyed with wheel handlers still on them. Fix by removing the
node from the set via Node::willBeDeletedFrom().
Tests: platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-element-with-multiple-handlers-crash.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-crash.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-parent-crash.html
- dom/Document.cpp:
(WebCore::removeHandlerFromSet): Helper to remove one or all handlers on the given node.
(WebCore::Document::didRemoveWheelEventHandler): Add a parameter to specify whether we're
removing all handlers on the given node.
(WebCore::Document::didRemoveTouchEventHandler): Use removeHandlerFromSet().
- dom/Document.h:
- dom/Node.cpp:
(WebCore::Node::willBeDeletedFrom): Tell the document we're removing all handlers
for this node.
LayoutTests:
Test configurations of elements with different parenting and event handlers adding orders, and multiple handlers on
the same node.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-element-with-multiple-handlers-crash-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-element-with-multiple-handlers-crash.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-crash-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-crash.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-parent-crash-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-parent-crash.html: Added.
- 5:19 PM Changeset in webkit [182348] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Cocoa] Add a way to temporarily disable the WebKit Network Cache for testing
https://bugs.webkit.org/show_bug.cgi?id=143392
<rdar://problem/20315669>
Reviewed by Antti Koivisto.
Add a way to temporarily disable the WebKit Network Cache for testing.
It will be used temporarily for comparing page load times with and
without the WebKit network disk cache enabled.
This is in addition to the existing "WebKitNetworkCacheEnabled"
NSUserDefaults:
webkitNetworkCacheIsEnabled = [defaults boolForKey:WebKitNetworkCacheEnabledDefaultsKey]
&& ![defaults boolForKey:WebKitNetworkCacheTemporarilyDisabledForTestingKey];
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
- 4:16 PM Changeset in webkit [182347] by
-
- 8 edits in trunk/Source/JavaScriptCore
Logically empty WeakBlocks should not pin down their MarkedBlocks indefinitely.
<https://webkit.org/b/143210>
Reviewed by Geoffrey Garen.
Since a MarkedBlock cannot be destroyed until all the WeakBlocks pointing into it are gone,
we had a little problem where WeakBlocks with only null pointers would still keep their
MarkedBlock alive.
This patch fixes that by detaching WeakBlocks from their MarkedBlock once a sweep discovers
that the WeakBlock contains no pointers to live objects. Ownership of the WeakBlock is passed
to the Heap, which will sweep the list of these detached WeakBlocks as part of a full GC,
destroying them once they're fully dead.
This allows the garbage collector to reclaim the 64kB MarkedBlocks much sooner, and resolves
a mysterious issue where doing two full garbage collections back-to-back would free additional
memory in the second collection.
Management of detached WeakBlocks is implemented as a Vector<WeakBlock*> in Heap, along with
an index of the next block in that vector that needs to be swept. The IncrementalSweeper then
calls into Heap::sweepNextLogicallyEmptyWeakBlock() to sweep one block at a time.
- heap/Heap.h:
- heap/Heap.cpp:
(JSC::Heap::collectAllGarbage): Add a final pass where we sweep the logically empty WeakBlocks
owned by Heap, after everything else has been swept.
(JSC::Heap::notifyIncrementalSweeper): Set up an incremental sweep of logically empty WeakBlocks
after a full garbage collection ends. Note that we don't do this after Eden collections, since
they are unlikely to cause entire WeakBlocks to go empty.
(JSC::Heap::addLogicallyEmptyWeakBlock): Added. Interface for passing ownership of a WeakBlock
to the Heap when it's detached from a WeakSet.
(JSC::Heap::sweepAllLogicallyEmptyWeakBlocks): Helper for collectAllGarbage() that sweeps all
of the logically empty WeakBlocks owned by Heap.
(JSC::Heap::sweepNextLogicallyEmptyWeakBlock): Sweeps one logically empty WeakBlock if needed
and updates the next-logically-empty-weak-block-to-sweep index.
(JSC::Heap::lastChanceToFinalize): call sweepAllLogicallyEmptyWeakBlocks() here, since there
won't be another chance after this.
- heap/IncrementalSweeper.h:
(JSC::IncrementalSweeper::hasWork): Deleted.
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::fullSweep):
(JSC::IncrementalSweeper::doSweep):
(JSC::IncrementalSweeper::sweepNextBlock): Restructured IncrementalSweeper a bit to simplify
adding a new sweeping stage for the Heap's logically empty WeakBlocks. sweepNextBlock() is
changed to return a bool (true if there's more work to be done.)
- heap/WeakBlock.cpp:
(JSC::WeakBlock::sweep): This now figures out if the WeakBlock is logically empty, i.e doesn't
contain any pointers to live objects. The answer is stored in a new SweepResult member.
- heap/WeakBlock.h:
(JSC::WeakBlock::isLogicallyEmptyButNotFree): Added. Can be queried after a sweep to determine
if the WeakBlock could be detached from the MarkedBlock.
(JSC::WeakBlock::SweepResult::SweepResult): Deleted in favor of initializing member variables
when declaring them.
- 3:39 PM Changeset in webkit [182346] by
-
- 10 edits2 adds in trunk
REGRESSION (r182215): Feedly crashes when closing article
https://bugs.webkit.org/show_bug.cgi?id=143405
rdar://problem/20382734, rdar://problem/20395497
Reviewed by Tim Horton.
Source/WebCore:
Calling computeNonFastScrollableRegion() eagerly when scrollable areas come and go
is bad, because it can cause FrameView::layout() to get called in the middle of
RenderObject destruction, which leaves the render tree in a bad state.
Fix by calling computeNonFastScrollableRegion() lazily, just before scrolling tree commit.
AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged() now just sets
a flag to say that the non-fast region needs to be recomputed, and that schedules
a scrolling tree commit. When the commit happens, we recompute the region. If the
region didn't change, and no other changes are pending, there's no need to commit.
Test: platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/compute-region-inside-delete-renderer-crash.html
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::setNonFastScrollableRegionDirty):
(WebCore::AsyncScrollingCoordinator::willCommitTree):
(WebCore::AsyncScrollingCoordinator::updateNonFastScrollableRegion):
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
(WebCore::AsyncScrollingCoordinator::scrollingStateTreeAsText): Need to eagerly update
the non-fast scrollable region.
- page/scrolling/AsyncScrollingCoordinator.h:
(WebCore::AsyncScrollingCoordinator::nonFastScrollableRegionDirty):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::willCommitTree):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeStateIfNeeded):
(WebCore::ScrollingCoordinatorMac::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinatorMac::commitTreeState):
Source/WebKit2:
Calling computeNonFastScrollableRegion() eagerly when scrollable areas come and go
is bad, because it can cause FrameView::layout() to get called in the middle of
RenderObject destruction, which leaves the render tree in a bad state.
Fix by calling computeNonFastScrollableRegion() lazily, just before scrolling tree commit.
AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged() now just sets
a flag to say that the non-fast region needs to be recomputed, and that schedules
a scrolling tree commit. When the commit happens, we recompute the region. If the
region didn't change, and no other changes are pending, there's no need to commit.
- WebProcess/Scrolling/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::buildTransaction):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers): Outdent #ifdefs.
LayoutTests:
Test that triggers a crash without the fix (thanks to Zalan for the test).
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/compute-region-inside-delete-renderer-crash-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/compute-region-inside-delete-renderer-crash.html: Added.
- 12:24 PM Changeset in webkit [182345] by
-
- 11 edits in trunk
Differentiate between composited scrolling, and async scrolling
https://bugs.webkit.org/show_bug.cgi?id=143291
Reviewed by Sam Weinig.
Source/WebCore:
ScrollableArea::usesCompositedScrolling() meant "uses aysnc scrolling", but
FrameView::contentsInCompositedLayer() covered a related concept, that scrolling
happens by moving compositing layers around.
Make the difference between these more explicit by adding ScrollableArea::usesAsyncScrolling(),
which means that scrolling for that ScrollableArea is asynchronous and managed
by a ScrollingCoordinator. This is the meaning that ScrollingCoordinator::computeNonFastScrollableRegion()
understands.
ScrollableArea::usesCompositedScrolling() is now repurposed to mean "scrolling
occurs by moving layers around, not requiring repaint". FrameView::contentsInCompositedLayer()
is renamed to usesCompositedScrolling(), and overrides the base class function.
This only changes behavior in tests that call setScrollingTreeIncludesFrames(true).
- page/FrameView.cpp:
(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::usesCompositedScrolling):
(WebCore::FrameView::usesAsyncScrolling):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::contentsInCompositedLayer): Deleted.
- page/FrameView.h:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::usesAsyncScrolling):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::usesAsyncScrolling):
- rendering/RenderLayer.h:
LayoutTests:
Rebaseline tests that call setScrollingTreeIncludesFrames(true), where those subframes
are now excluded from the non-fast scrollable region.
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt:
- 10:16 AM Changeset in webkit [182344] by
-
- 8 edits in trunk
[Streams API] Collecting a ReadableStreamReader should not unlock its stream
https://bugs.webkit.org/show_bug.cgi?id=143333
Reviewed by Benjamin Poulain.
Source/WebCore:
This patch stores as a boolean whether the stream is locked to a reader.
In case the reader forget to unlock the stream, the reader can be collected and destructor called.
In that case, the link between reader and stream will be reset but the stream will remain in locked state.
Covered by new test in streams/readablestreamreader-constructor.html.
- Modules/streams/ReadableStream.h:
(WebCore::ReadableStream::isLocked):
(WebCore::ReadableStream::lock):
(WebCore::ReadableStream::release):
(WebCore::ReadableStream::releaseButKeepLocked): Introduced to cut the link between reader and stream but stil keeping the stream locked.
- Modules/streams/ReadableStreamReader.cpp:
(WebCore::ReadableStreamReader::~ReadableStreamReader):
- bindings/js/JSReadableStreamCustom.cpp:
(WebCore::JSReadableStream::getReader):
- bindings/js/JSReadableStreamReaderCustom.cpp:
(WebCore::constructJSReadableStreamReader):
LayoutTests:
- streams/readablestreamreader-constructor-expected.txt:
- streams/readablestreamreader-constructor.html:
- 7:32 AM Changeset in webkit [182343] by
-
- 16 edits5 adds in trunk
Implement ES6 Object.getOwnPropertySymbols
https://bugs.webkit.org/show_bug.cgi?id=141106
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This patch implements
Object.getOwnPropertySymbols
.
One technical issue is that, since we use private symbols (such as@Object
) in the
privileged JS code inbuiltins/
, they should not be exposed.
To distinguish them from the usual symbols, check the targetStringImpl*
is a not private name
before adding it into PropertyNameArray.
To check the target
StringImpl*
is a private name, we leverage privateToPublic map inBuiltinNames
since all private symbols are held in this map.
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createExecutableInternal):
- builtins/BuiltinNames.h:
(JSC::BuiltinNames::isPrivateName):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::isPrivateName):
- runtime/CommonIdentifiers.h:
- runtime/EnumerationMode.h:
(JSC::EnumerationMode::EnumerationMode):
(JSC::EnumerationMode::includeSymbolProperties):
- runtime/ExceptionHelpers.cpp:
(JSC::createUndefinedVariableError):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSLexicalEnvironment.cpp:
(JSC::JSLexicalEnvironment::getOwnNonIndexPropertyNames):
- runtime/JSSymbolTableObject.cpp:
(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
(JSC::objectConstructorGetOwnPropertySymbols):
(JSC::defineProperties):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
- runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::create):
- runtime/Structure.cpp:
(JSC::Structure::getPropertyNamesFromStructure):
- tests/stress/object-get-own-property-symbols-perform-to-object.js: Added.
(compare):
- tests/stress/object-get-own-property-symbols.js: Added.
(forIn):
- tests/stress/symbol-define-property.js: Added.
(testSymbol):
- tests/stress/symbol-seal-and-freeze.js: Added.
- tests/stress/symbol-with-json.js: Added.
LayoutTests:
- js/Object-getOwnPropertyNames-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
Apr 3, 2015:
- 11:08 PM Changeset in webkit [182342] by
-
- 2 edits in trunk/Source/WebCore
MediaDevices possesses a vtable despite using ImplementationLacksVTable IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=143367
Reviewed by Eric Carlson.
- Modules/mediastream/MediaDevices.idl: MediaDevices ends up with a vtable
because of inheriting from ContextDestructionObserver. This collides with
the ImplementationLacksVTable IDL attribute, causing compilation errors
with Clang. Since MediaDevices isn't being inherited from, but will still
end up with a vtable, the IDL attribute should be removed.
- 6:55 PM Changeset in webkit [182341] by
-
- 2 edits in trunk/Source/WebKit2
Attempted build fix.
- UIProcess/API/mac/WKView.mm:
- 5:42 PM Changeset in webkit [182340] by
-
- 2 edits in trunk/Source/WebKit2
Fix the firing of the ReachedSessionRestorationRenderTreeSizeThreshold milestone on iOS
https://bugs.webkit.org/show_bug.cgi?id=143394
Reviewed by Tim Horton.
A client reshuffle at some point broke the dispatch of the ReachedSessionRestorationRenderTreeSizeThreshold
milestone. Fix by using WebPageProxy::didLayout() to fire the milestone.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didCommitLayerTree):
- 5:07 PM Changeset in webkit [182339] by
-
- 4 edits in trunk/LayoutTests
fast/fixed-layout/fixed-layout.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=143379
Reviewed by Simon Fraser.
Un-flakify the fixed layout test.
- fast/css-grid-layout/flex-content-sized-columns-resize-expected.html:
Remove a mistaken line in the original test; this function doesn't exist in WebKit
and was presumably ported directly from the Blink test (and then never noticed because
JS exceptions thrown in -expected files go nowhere).
- fast/fixed-layout/fixed-layout.html:
Make the fixed layout test less racy by waiting for the resize event (which can be
very asynchronous). Also, force a layout before resizing to ensure that we
always do get a resize event.
- 4:52 PM Changeset in webkit [182338] by
-
- 8 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=143387
Improvements to webkitmouseforce web API
-and corresponding-
rdar://problem/20281808
rdar://problem/20281853
Reviewed by Darin Adler.
This patch:
- Dispatches webkitmouseforceup and webkitmouseforceclick at the right time.
- Dispatches webkitmouseforcechanged from mousedown all the way through through
mouseup.
- Uses force values from pressureChangeWithEvent instead of the immediate action
gesture recognizer.
Listen for this NSResponder method, and pass the relevant info to WebPageProxy to
dispatch to the web process.
- UIProcess/API/mac/WKView.mm:
(-[WKView pressureChangeWithEvent:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::inputDeviceForceDidChange):
(WebKit::WebPageProxy::immediateActionDidUpdate):
- UIProcess/WebPageProxy.h:
The web process still needs to know when the immediate action gesture recognizer
is updating, but it doesn’t need the force information. That will come from
pressureChangeWithEvent.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController immediateActionRecognizerDidUpdateAnimation:]):
Cache m_lastForceStage so that we can determine if we are
transitioning to a new stage.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
New message for InputDeviceForceDidChange and modified message for
ImmediateActionDidUpdate
- WebProcess/WebPage/WebPage.messages.in:
inputDeviceForceDidChange now takes care of dispatching mouseforcechanged,
mouseforcedown, mouseforceup, and mouseforceclick.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::inputDeviceForceDidChange):
We still need to keep track of the ImmediateActionStages in WebCore::EventHandler
so that we can have the right default behavior on mouseup based on whether or not
that action began and was completed. (In other words, to ensure we don’t navigate
to a link after force clicking it.)
(WebKit::WebPage::immediateActionDidUpdate):
(WebKit::WebPage::immediateActionDidComplete):
- 3:52 PM Changeset in webkit [182337] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add Options::jitPolicyScale() as a single knob to make all compilations happen sooner.
<https://webkit.org/b/143385>
Reviewed by Geoffrey Garen.
For debugging purposes, sometimes, we want to be able to make compilation happen
sooner to see if we can accelerate the manifestation of certain events / bugs.
Currently, in order to achieve this, we'll have to tweak multiple JIT thresholds
which make up the compilation policy. Let's add a single knob that can tune all
the thresholds up / down in one go proportionately so that we can easily tweak
how soon compilation occurs.
- runtime/Options.cpp:
(JSC::scaleJITPolicy):
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- 3:18 PM Changeset in webkit [182336] by
-
- 3 edits in trunk/Source/JavaScriptCore
is* API methods should be @properties
https://bugs.webkit.org/show_bug.cgi?id=143388
Reviewed by Mark Lam.
This appears to be the preferred idiom in WebKit, CA, AppKit, and
Foundation.
- API/JSValue.h: Be @properties.
- API/tests/testapi.mm:
(testObjectiveCAPI): Use the @properties.
- 2:44 PM Changeset in webkit [182335] by
-
- 9 edits in trunk/Source/WebCore
[Content Extensions] Add memory reporting.
https://bugs.webkit.org/show_bug.cgi?id=143386
Reviewed by Benjamin Poulain.
- contentextensions/CompiledContentExtension.cpp:
(WebCore::ContentExtensions::CompiledContentExtension::globalDisplayNoneSelectors):
- contentextensions/CompiledContentExtension.h:
- contentextensions/ContentExtension.cpp:
(WebCore::ContentExtensions::ContentExtension::globalDisplayNoneStyleSheet):
- contentextensions/ContentExtension.h:
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):
- contentextensions/ContentExtensionsDebugging.h:
- contentextensions/DFABytecodeInterpreter.cpp:
(WebCore::ContentExtensions::getBits):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretTestFlagsAndAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsFromDFARoot):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
- contentextensions/DFABytecodeInterpreter.h:
(WebCore::ContentExtensions::DFABytecodeInterpreter::DFABytecodeInterpreter):
(WebCore::ContentExtensions::DFABytecodeInterpreter::~DFABytecodeInterpreter):
Keep track of which memory pages in the bytecode are being hit if CONTENT_EXTENSIONS_MEMORY_REPORTING is 1.
When CONTENT_EXTENSIONS_MEMORY_REPORTING is 0, this makes an empty vector in ContentExtension
and passes some pointers on the stack, many of which can be optimized out by the C++ compiler.
- 2:32 PM Changeset in webkit [182334] by
-
- 10 edits in trunk/Source/WebCore
Expand test infrastructure to support scrolling tests
https://bugs.webkit.org/show_bug.cgi?id=143383
Reviewed by Darin Adler.
No new tests: No change in behavior.
This is an initial set of changes that clean up a few things I noticed while extending testing support
for scroll animations and wheel event gestures.
- Reduce the amount of #ifdef code in EventHandler{Mac}.
- Consolidate the idea of an "End Gesture" in the PlatformWheelEvent class.
- Remove a number of unneeded null checks in EventHandler.
- ScrollController must always have a client, so hold a reference instead of using a pointer.
- page/EventHandler.cpp:
(WebCore::EventHandler::platformNotifyIfEndGesture): Renamed from 'platformNotifySnapIfNecessary'.
(WebCore::EventHandler::handleWheelEvent): Call 'platformNotifySnapIfNecessary' at method exit points.
(WebCore::EventHandler::platformNotifySnapIfNecessary): Deleted.
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformCompleteWheelEvent): Remove unneeded null checks for 'view'. Remove
CSS_SNAP-specific call to 'platformNotifySnapIfNecessary'. This logic is now handled in the new
'platformNotifyIfEndGesture' method.
(WebCore::EventHandler::platformNotifyIfEndGesture): Renamed from 'platformNotifySnapIfNecessary'.
(WebCore::EventHandler::platformNotifySnapIfNecessary): Deleted.
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::ScrollingTreeFrameScrollingNodeMac): Pass 'this' as
reference to ScrollController constructor.
- platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::shouldResetLatching): Call new 'isEndGesture' method.
(WebCore::PlatformWheelEvent::isEndGesture): Added method to encapsulate some code that was duplicated
in a number of places.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::ScrollAnimator): Pass 'this' as reference to ScrollController constructor.
- platform/cocoa/ScrollController.h:
- platform/cocoa/ScrollController.mm:
(WebCore::ScrollController::ScrollController): Update to reflect m_client is now a reference.
(WebCore::ScrollController::handleWheelEvent): Ditto.
(WebCore::ScrollController::snapRubberBandTimerFired): Ditto. Also, a drive-by fix for ending rubberband
snapping. This end-state wasn't deactivating the timer (even when the animation finished). This isn't a
huge problem, but I (will) rely on the state of the animation timer in a future patch to decide if
tests should run or continue waiting.
(WebCore::ScrollController::isRubberBandInProgress): Ditto.
(WebCore::ScrollController::startSnapRubberbandTimer): Ditto.
(WebCore::ScrollController::stopSnapRubberbandTimer): Ditto.
(WebCore::ScrollController::shouldRubberBandInHorizontalDirection): Ditto.
(WebCore::ScrollController::processWheelEventForScrollSnapOnAxis): Ditto.
(WebCore::ScrollController::startScrollSnapTimer): Ditto.
(WebCore::ScrollController::stopScrollSnapTimer): Ditto.
(WebCore::ScrollController::scrollSnapAnimationUpdate): Ditto.
(WebCore::ScrollController::beginScrollSnapAnimation): Ditto.
(WebCore::ScrollController::computeSnapDelta): Ditto.
(WebCore::ScrollController::computeGlideDelta): Ditto.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::gestureShouldBeginSnap): Use new PlatformWheelEvent::isEndGesture() method.
- 2:21 PM Changeset in webkit [182333] by
-
- 3 edits2 adds in trunk
AX: Toggling check box state not speaking using plain space, not VO space.
https://bugs.webkit.org/show_bug.cgi?id=143356
Reviewed by Darin Adler.
Source/WebCore:
The checkbox state change needs to result in a value change being generated, otherwise accessibility won't know the value has changed through keyboard usage.
Test: platform/mac/accessibility/checkbox-posts-value-change-notification-after-activation-with-space.html
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
- platform/mac/accessibility/checkbox-posts-value-change-notification-after-activation-with-space-expected.txt: Added.
- platform/mac/accessibility/checkbox-posts-value-change-notification-after-activation-with-space.html: Added.
- 2:20 PM Changeset in webkit [182332] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
https://bugs.webkit.org/show_bug.cgi?id=143372
Reviewed by Darin Adler.
- Scripts/run-jsc-stress-tests:
- 2:01 PM Changeset in webkit [182331] by
-
- 3 edits in trunk/Source/JavaScriptCore
Some JSC Options refactoring and enhancements.
<https://webkit.org/b/143384>
Rubber stamped by Benjamin Poulain.
Create a better encapsulated Option class to make working with options easier. This
is a building block towards a JIT policy scaling debugging option I will introduce later.
This work entails:
- Convert Options::Option into a public class Option (who works closely with Options).
- Convert Options::EntryType into an enum class Options::Type and make it public.
- Renamed Options::OPT_<option name> to Options::<option name>ID because it reads better.
- Add misc methods to class Option to make it more useable.
- runtime/Options.cpp:
(JSC::Options::dumpOption):
(JSC::Option::dump):
(JSC::Option::operator==):
(JSC::Options::Option::dump): Deleted.
(JSC::Options::Option::operator==): Deleted.
- runtime/Options.h:
(JSC::Option::Option):
(JSC::Option::operator!=):
(JSC::Option::name):
(JSC::Option::description):
(JSC::Option::type):
(JSC::Option::isOverridden):
(JSC::Option::defaultOption):
(JSC::Option::boolVal):
(JSC::Option::unsignedVal):
(JSC::Option::doubleVal):
(JSC::Option::int32Val):
(JSC::Option::optionRangeVal):
(JSC::Option::optionStringVal):
(JSC::Option::gcLogLevelVal):
(JSC::Options::Option::Option): Deleted.
(JSC::Options::Option::operator!=): Deleted.
- 1:46 PM Changeset in webkit [182330] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Add time series segmentation algorithms as moving averages
https://bugs.webkit.org/show_bug.cgi?id=143362
Reviewed by Chris Dumez.
This patch implements two preliminary time series segmentation algorithms as moving averages.
Recursive t-test: Compute Welch's t-statistic at each point in a given segment of the time series.
If Welch's t-test implicates a statistically significance difference, then split the segment into two
sub segments with the maximum t-statistic (i.e. the point at which if split would yield the highest
probability that two segments do not share the same "underlying" mean in classical / frequentist sense).
We repeat this process recursively. See [1] for the evaluation of this particular algorithm.
Schwarz criterion: Use Schwarz or Bayesian information criterion to heuristically find the optimal
segmentation. Intuitively, the problem of finding the best segmentation comes down to minimizing the
residual sum of squares in each segment as in linear regressions. That is, for a given segment with
values y_1 through y_n with mean y_avg, we want to minimize the sum of (y_i - y_avg)2 over i = 1
through i = n. However, we also don't want to split every data point into a separate segment so we need
to account the "cost" of introducing new segments. We use a cost function that's loosely based on two
models discussed in [2] for simplicity. We will tune this cost function further in the future.
The problem of finding the best segmentation then reduces to a search problem. Unfortunately, our problem
space is exponential with respect to the size of the time series since we could split at each data point.
We workaround this problem by first splitting the time series into a manageable smaller grids, and only
considering segmentation of a fixed size (i.e. the number of segments is constant). Since time series
tend to contain a lot more data points than segments, this strategy finds the optimal solution without
exploring much of the problem space.
Finding the optimal segmentation of a fixed size is, itself, another search problem that is equivalent to
finding the shortest path of a fixed length in DAG. Here, we use dynamic programming with a matrix of size
n by n where n is the length of the time series (grid). Each entry in this matrix at (i, k) stores
the minimum cost of segmenting data points 1 through i using k segments. We start our search at i = 1.
Clearly C(1, 0) = 0 (note the actual code uses 0-based index). In i-th iteration, we compute the cost
S(i, j) of each segment starting at i and ending at another point j after i and update C(j, k + 1) by
min( C(j, k + 1), C(i, k) + S(i, j) ) for all values of j above i.
[1] Kensuke Fukuda, H. Eugene Stanley, and Luis A. Nunes Amaral, "Heuristic segmentation of
a nonstationary time series", Physical Review E 69, 021108 (2004)
[2] Marc Lavielle, Gilles Teyssi`ere, "Detection of Multiple Change–Points in Multivariate Time Series"
Lithuanian Mathematical Journal, vol 46, 2006
- public/v2/index.html: Show the optional description for the chosen moving average strategy.
- public/v2/js/statistics.js:
(Statistics.testWelchsT):
(Statistics.computeWelchsT): Extracted from testWelchsT. Generalized to take the offset and the length
of each value array between which Welch's t-statistic is computed. This generalization helps the
Schwarz criterion segmentation algorithm avoid splitting values array O(n2) times.
(.sampleMeanAndVarianceForValues): Ditto for the generalization.
(.recursivelySplitIntoTwoSegmentsAtMaxTIfSignificantlyDifferent): Added. Implements recursive t-test.
(.splitIntoSegmentsUntilGoodEnough): Added. Implements Schwarz criterion.
(.findOptimalSegmentation): Added. Implements the algorithm to find the optimal segmentation of a fixed
segment count.
(.SampleVarianceUpperTriangularMatrix): Added. Stores S(i, j) used by findOptimalSegmentation.
(.SampleVarianceUpperTriangularMatrix.prototype.costBetween): Added.
- 1:43 PM Changeset in webkit [182329] by
-
- 4 edits in trunk/Websites/perf.webkit.org
REGRESSION: Perf dashboard sometimes fails to update zooming level
https://bugs.webkit.org/show_bug.cgi?id=143359
Reviewed by Darin Adler.
The bug was caused by various bugs that ended up in an exception.
- public/v2/app.js:
(App.Pane._handleFetchErrors): Removed superfluous console.log.
(App.Pane.computeStatus): Fixed the bug in r182185 that previousPoint could be null.
(App.PaneController.actions.zoomed): Update the overview when the main chart triggered a zoom.
- public/v2/index.html: Replaced all instances of href="#" by href="javascript:false" to avoid navigating
to # when Ember.js fails to attach event listeners on time.
- public/v2/interactive-chart.js:
(App.InteractiveChartComponent._updateDimensionsIfNeeded): Avoid using a negative width or height when
the containing element's size is 0.
(App.InteractiveChartComponent._updateBrush): Ditto.
- 1:16 PM Changeset in webkit [182328] by
-
- 2 edits in trunk/Source/JavaScriptCore
2015-04-03 Geoffrey Garen <ggaren@apple.com>
JavaScriptCore API should support type checking for Array and Date
https://bugs.webkit.org/show_bug.cgi?id=143324
Follow-up to address a comment by Dan.
- API/WebKitAvailability.h: MAC_OS_X_VERSION_MIN_REQUIRED <= 101100 is wrong, since this API is available when MAC_OS_X_VERSION_MIN_REQUIRED is equal to 101100.
- 1:12 PM Changeset in webkit [182327] by
-
- 3 edits in trunk/Source/WebKit2
InjectedBundleNodeHandle::renderedImage() needs to be exposed from the Cocoa WebAPI layer.
https://bugs.webkit.org/show_bug.cgi?id=143341.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-04-03
Reviewed by Anders Carlsson.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
(-[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]): Expose rendered
image injected bundle API from the Cocoa layer. A node in the page can be
rendered to an NSImage on MacOS and to a UIImage on iOS.
- 11:49 AM Changeset in webkit [182326] by
-
- 2 edits in trunk
Unreviewed, kick the GTK bots to fix an incremental build issue.
- Source/cmake/OptionsGTK.cmake:
- 11:27 AM Changeset in webkit [182325] by
-
- 4 edits in trunk/Source/WebCore
Simple line layout: Use pre-computed simple line runs to produce innerText content.
https://bugs.webkit.org/show_bug.cgi?id=143351
Reviewed by Antti Koivisto.
This is in preparation to cover <br> with simple line layout.
Runs provide line layout information that can be used to cover hard line break cases.
(similar to TextIterator::handleTextBox())
Covered by existing tests.
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::emitCharacter):
(WebCore::TextIterator::emitText):
- editing/TextIterator.h:
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::Run::isEndOfLine):
- 10:55 AM Changeset in webkit [182324] by
-
- 2 edits in trunk/Source/JavaScriptCore
2015-04-03 Geoffrey Garen <ggaren@apple.com>
JavaScriptCore API should support type checking for Array and Date
https://bugs.webkit.org/show_bug.cgi?id=143324
Follow-up to address a comment by Dan.
- API/WebKitAvailability.h: Do use 10.0 because it was right all along. Added a comment explaining why.
- 10:54 AM Changeset in webkit [182323] by
-
- 9 edits2 moves in trunk/Source/WebKit2
[WK2][iOS] We should prevent NetworkProcess suspension while it has pending SQL transactions
https://bugs.webkit.org/show_bug.cgi?id=143278
<rdar://problem/20180799>
Reviewed by Anders Carlsson.
Prevent NetworkProcess suspension while it has pending SQL transactions,
similarly to what we already did for WebProcesses. This patch moves the
WebSQLiteDatabaseTracker from WebProcess/ to Shared/ and make it usable
by the NetworkProcess class as well.
Whenever there are locked files to due SQL transactions, the
NetworkProcess will send an IPC message to the NetworkProcessProxy
which will hold a background process assertion until the NetworkProcess'
SQL transactions are complete. This way, it is no longer possible for
the NetworkProcess to get suspended while SQL transactions are running
and a database file is locked.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
- NetworkProcess/NetworkProcess.h:
- Shared/WebSQLiteDatabaseTracker.cpp: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/WebSQLiteDatabaseTracker.cpp.
(WebKit::WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker):
(WebKit::m_childProcessType):
(WebKit::WebSQLiteDatabaseTracker::willBeginFirstTransaction):
(WebKit::WebSQLiteDatabaseTracker::didFinishLastTransaction):
(WebKit::WebSQLiteDatabaseTracker::hysteresisUpdated):
- Shared/WebSQLiteDatabaseTracker.h: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/WebSQLiteDatabaseTracker.h.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::setIsHoldingLockedFiles):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):
- WebProcess/WebProcess.h:
- 10:24 AM Changeset in webkit [182322] by
-
- 2 edits in trunk/LayoutTests
Re-skip tests that got recently enabled, but time out.
- platform/mac-wk2/TestExpectations:
- 10:23 AM Changeset in webkit [182321] by
-
- 9 edits1 add in trunk
Source/WebCore:
Add non-counting bloom filter class
https://bugs.webkit.org/show_bug.cgi?id=143366
Reviewed by Sam Weinig.
- css/SelectorFilter.cpp:
(WebCore::SelectorFilter::setupParentStack):
- css/SelectorFilter.h:
Update names.
Source/WebKit2:
Add non-counting Bloom filter implementation
https://bugs.webkit.org/show_bug.cgi?id=143366
Reviewed by Sam Weinig.
- NetworkProcess/cache/NetworkCacheStorage.h:
Source/WTF:
Add non-counting Bloom filter implementation
https://bugs.webkit.org/show_bug.cgi?id=143366
Reviewed by Sam Weinig.
Add a traditional single-bit-per-bucket Bloom filter in addition to the existing counting implementation.
- rename BloomFilter -> CountingBloomFilter.
- add a new basic BloomFilter type.
- update some terminology to match http://en.wikipedia.org/wiki/Bloom_filter and modernize the code a bit.
- add API tests.
- wtf/BloomFilter.h:
(WTF::BloomFilter::BloomFilter):
(WTF::BloomFilter::add):
Also support merging.
(WTF::BloomFilter::mayContain):
(WTF::BloomFilter::arrayIndex):
(WTF::BloomFilter::bitMask):
(WTF::BloomFilter<keyBits>::mayContain):
(WTF::BloomFilter<keyBits>::add):
(WTF::BloomFilter<keyBits>::isBitSet):
(WTF::BloomFilter<keyBits>::setBit):
(WTF::BloomFilter<keyBits>::clear):
(WTF::CountingBloomFilter::CountingBloomFilter):
(WTF::CountingBloomFilter::mayContain):
(WTF::CountingBloomFilter::firstBucket):
(WTF::CountingBloomFilter::secondBucket):
(WTF::CountingBloomFilter<keyBits>::add):
(WTF::CountingBloomFilter<keyBits>::remove):
(WTF::CountingBloomFilter<keyBits>::clear):
(WTF::CountingBloomFilter<keyBits>::likelyEmpty):
(WTF::CountingBloomFilter<keyBits>::isClear):
(WTF::BloomFilter::maximumCount): Deleted.
(WTF::BloomFilter::firstSlot): Deleted.
(WTF::BloomFilter::secondSlot): Deleted.
(WTF::BloomFilter<keyBits>::remove): Deleted.
(WTF::BloomFilter<keyBits>::likelyEmpty): Deleted.
(WTF::BloomFilter<keyBits>::isClear): Deleted.
Tools:
Add non-counting bloom filter class
https://bugs.webkit.org/show_bug.cgi?id=143366
Reviewed by Sam Weinig.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
(TestWebKitAPI::generateRandomHashes):
(TestWebKitAPI::TEST):
- 9:46 AM Changeset in webkit [182320] by
-
- 7 edits in trunk/Source/WebCore
Remove dead code.
https://bugs.webkit.org/show_bug.cgi?id=143352
Patch by Alex Christensen <achristensen@webkit.org> on 2015-04-03
Reviewed by Gyuyoung Kim.
- html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
- loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::openDateTimeChooser): Deleted.
- loader/EmptyClients.h:
- page/Chrome.cpp:
(WebCore::Chrome::openDateTimeChooser): Deleted.
- page/Chrome.h:
- page/ChromeClient.h:
Remove ChromeClient::openDateTimeChooser.
- 9:38 AM Changeset in webkit [182319] by
-
- 2 edits in trunk/LayoutTests
fast/fixed-layout/fixed-layout.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=143379
- TestExpectations: Marking it as such.
- 9:01 AM Changeset in webkit [182318] by
-
- 5 edits in trunk
FTL JIT tests should fail if LLVM library isn't available
https://bugs.webkit.org/show_bug.cgi?id=143374
Reviewed by Mark Lam.
Source/JavaScriptCore:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- runtime/Options.h:
Tools:
- Scripts/run-jsc-stress-tests:
- 5:52 AM Changeset in webkit [182317] by
-
- 2 edits in trunk/Tools
[EFL] Speedup jhbuild with disable running autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=143369
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules:
- 5:30 AM Changeset in webkit [182316] by
-
- 3 edits in trunk/LayoutTests
[WK2] Unskip now passing tests after r135595
https://bugs.webkit.org/show_bug.cgi?id=127428
Unreviewed gardening.
- platform/mac-wk2/TestExpectations: Mark editing/selection/context-menu-text-selection.html as timeouting test.
- platform/wk2/TestExpectations: Unskip now passing tests.
- 5:23 AM Changeset in webkit [182315] by
-
- 6 edits in trunk
Fix the EFL and GTK build after r182243
https://bugs.webkit.org/show_bug.cgi?id=143361
Reviewed by Csaba Osztrogonác.
.:
- Source/PlatformEfl.cmake: Add a custom command that copies
the InspectorBackendCommands.js file into the proper directory
under DerivedSources/WebInspectorUI/.
Source/JavaScriptCore:
- CMakeLists.txt: InspectorBackendCommands.js is generated in the
DerivedSources/JavaScriptCore/inspector/ directory.
Source/WebKit2:
- PlatformGTK.cmake: Add a custom command that copies the
InspectorBackendCommands.js file into the proper directory
under DerivedSources/WebInspectorUI/.
- 5:20 AM Changeset in webkit [182314] by
-
- 4 edits in trunk/Source
Unreviewed, fixing Clang builds of the GTK port on Linux.
Source/JavaScriptCore:
- runtime/Options.cpp:
Include the <math.h> header for isnan().
Source/WebCore:
- Modules/mediastream/MediaDevices.h:
Include the <functional> header for uses of std::function<>.
- 4:23 AM Changeset in webkit [182313] by
-
- 2 edits in trunk/LayoutTests
[EFL] Fix 18 crashing compositing tests after r182101
https://bugs.webkit.org/show_bug.cgi?id=143214
Unreviewed gardening, comment out the original expectations after r182311.
- platform/efl/TestExpectations:
- 3:55 AM Changeset in webkit [182312] by
-
- 2 edits in trunk/LayoutTests
[EFL] Fix 18 crashing compositing tests after r182101
https://bugs.webkit.org/show_bug.cgi?id=143214
Unreviewed gardening, add crash expectations until proper fix.
- platform/efl/TestExpectations:
- 3:27 AM Changeset in webkit [182311] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Skip fast/fixed-layout, because it made the following tests fail.
- platform/efl/TestExpectations:
- 2:17 AM Changeset in webkit [182310] by
-
- 4 edits in trunk/Source/WebKit2
Unreviewed, GTK build fix.
- UIProcess/API/gtk/WebKitContextMenuClient.cpp:
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
- UIProcess/gtk/WebContextMenuProxyGtk.h:
- 1:07 AM Changeset in webkit [182309] by
-
- 10 edits in trunk/Source/WebCore
[Streams API] Split ReadableStream/Reader implementation according source type (JS vs native)
https://bugs.webkit.org/show_bug.cgi?id=143130
Reviewed by Benjamin Poulain.
Introduce ReadableJSStream and ReadableJSStreamReader as subclasses of ReadableStream and ReadableStreamReader.
These classes manage JS based sources: ReadableStream JS constructor instantiates ReadableJStream.
These classes are expected to handle JS source specific handling, in particular JSValue error storage and JSValue chunk queue.
Making ReadableStream and ReadableStreamReader abstract, to be subclassed for native sources.
Current tests cover the changes.
- Modules/streams/ReadableStream.cpp:
(WebCore::ReadableStream::ReadableStream): Moved suspendIfNeeded inside constructor to ease subclassing.
(WebCore::ReadableStream::create): Deleted as ReadableStream is now abstarct.
- Modules/streams/ReadableStream.h: Made createReader virtual pure.
- Modules/streams/ReadableStream.idl: Skipping VTable validation as subclasses of ReadableStream may be JS wrapped.
- Modules/streams/ReadableStreamReader.cpp: Removed ReadableStreamReader::create.
- Modules/streams/ReadableStreamReader.h: Ditto.
- Modules/streams/ReadableStreamReader.idl: Skipping VTable validation as subclasses of ReadableStreamReader may be JS wrapped.
- bindings/js/JSReadableStreamCustom.cpp:
(WebCore::constructJSReadableStream): Instantiating ReadableJSStream in lieu of ReadableStream within JS constructor.
- bindings/js/ReadableStreamJSSource.cpp:
(WebCore::ReadableJSStream::create):
(WebCore::ReadableJSStream::createReader): Instantiating ReadableJSStreamReader.
(WebCore::ReadableJSStream::ReadableJSStream):
(WebCore::ReadableJSStreamReader::create):
(WebCore::ReadableJSStreamReader::ReadableJSStreamReader):
- bindings/js/ReadableStreamJSSource.h: Definition of ReadableJSStream and ReadableJSStreamReader.
Apr 2, 2015:
- 11:39 PM Changeset in webkit [182308] by
-
- 2 edits in trunk/Source/WebKit2
Typo fix.
- PlatformGTK.cmake:
- 11:37 PM Changeset in webkit [182307] by
-
- 6 edits4 adds in trunk
Scrollbars are left in the wrong position when resizing a fixed layout view
https://bugs.webkit.org/show_bug.cgi?id=143360
Reviewed by Beth Dakin.
Test: fast/fixed-layout/fixed-layout.html
- platform/ScrollView.cpp:
(WebCore::ScrollView::setFrameRect):
Update scrollbars when the ScrollView frameRect changes. We were previously
depending on the layout that always happens after this to update scrollbars,
but with fixed layout mode, there won't be a layout! Also, FrameView's
setFrameRect override will sync this scrollbar update with the scrollbar
layers (via RenderLayerCompositor::frameViewDidChangeSize) immediately afterwards.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
Turn off fixed layout when resetting state.
(WebCore::Internals::setUseFixedLayout):
(WebCore::Internals::setFixedLayoutSize):
- testing/Internals.h:
- testing/Internals.idl:
Add internals functions to set the fixed layout size and to turn on fixed layout.
- fast/fixed-layout/fixed-layout-expected.png: Added.
- fast/fixed-layout/fixed-layout-expected.txt: Added.
- fast/fixed-layout/fixed-layout.html: Added.
Add a simple fixed layout test. We can add more (or recover some from
when the Qt tests were purged) now that it's testable again.
This test also happens to test the aforementioned setFrameRect change,
because without it, the RenderView's layer would be left at the wrong
size (800x600) because the scrollbars would be left behind in the resize.
- 11:36 PM Changeset in webkit [182306] by
-
- 3 edits2 adds in trunk/Source/WebKit2
URTBF after r182303, stub NativeContextMenuItem implemetations added for EFL and GTK.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- Shared/efl/NativeContextMenuItemEfl.cpp: Added.
(WebKit::NativeContextMenuItem::NativeContextMenuItem):
- Shared/gtk/NativeContextMenuItemGtk.cpp: Added.
(WebKit::NativeContextMenuItem::NativeContextMenuItem):
- 10:02 PM Changeset in webkit [182305] by
-
- 3 edits in trunk/Source/WebKit2
De-PLATFORM(IOS)-ify LayerHostingContext::setFencePort
https://bugs.webkit.org/show_bug.cgi?id=143342
- Platform/mac/LayerHostingContext.h:
- Platform/mac/LayerHostingContext.mm:
Actually, not available on Mavericks. Fix the build.
- 8:51 PM JSC edited by
- (diff)
- 8:46 PM Changeset in webkit [182304] by
-
- 4 edits in trunk/Source/JavaScriptCore
Enhance ability to dump JSC Options.
<https://webkit.org/b/143357>
Reviewed by Benjamin Poulain.
Some enhancements to how the JSC options work:
- Add a JSC_showOptions option which take values: 0 = None, 1 = Overridden only, 2 = All, 3 = Verbose.
The default is 0 (None). This dumps nothing.
With the Overridden setting, at VM initialization time, we will dump all
option values that have been changed from their default.
With the All setting, at VM initialization time, we will dump all option values.
With the Verbose setting, at VM initialization time, we will dump all option
values along with their descriptions (if available).
- We now store a copy of the default option values.
We later use this for comparison to tell if an option has been overridden, and
print the default value for reference. As a result, we no longer need the
didOverride flag since we can compute whether the option is overridden at any time.
- Added description strings to some options to be printed when JSC_showOptions=3 (Verbose).
This will come in handy later when we want to rename some of the options to more sane
names that are easier to remember. For example, we can change
Options::dfgFunctionWhitelistFile() to Options::dfgWhiteList(), and
Options::slowPathAllocsBetweenGCs() to Options::forcedGcRate(). With the availability
of the description, we can afford to use shorter and less descriptive option names,
but they will be easier to remember and use for day to day debugging work.
In this patch, I did not change the names of any of the options yet. I only added
description strings for options that I know about, and where I think the option name
isn't already descriptive enough.
- Also deleted some unused code.
- jsc.cpp:
(CommandLine::parseArguments):
- runtime/Options.cpp:
(JSC::Options::initialize):
(JSC::Options::setOption):
(JSC::Options::dumpAllOptions):
(JSC::Options::dumpOption):
(JSC::Options::Option::dump):
(JSC::Options::Option::operator==):
- runtime/Options.h:
(JSC::OptionRange::rangeString):
(JSC::Options::Option::Option):
(JSC::Options::Option::operator!=):
- 6:16 PM Changeset in webkit [182303] by
-
- 31 edits2 adds in trunk/Source
Source/WebCore:
Unreviewed: Reapplied Change after rollout.
Expose the "Share" menu for text selections on platforms where it's available.
rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
Patch by Brady Eidson <beidson@apple.com> on 2015-04-02
- page/ContextMenuClient.h:
(WebCore::ContextMenuClient::shareSelectedTextMenuItem):
- page/ContextMenuContext.h:
(WebCore::ContextMenuContext::setSelectedText):
(WebCore::ContextMenuContext::selectedText):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate): Add a Share menu item returned from the client.
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
- platform/ContextMenuItem.cpp:
(WebCore::ContextMenuItem::shareSelectedTextMenuItem):
- platform/ContextMenuItem.h:
(WebCore::ContextMenuItem::supportsShareMenu):
- platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::shareSelectedTextMenuItem):
- platform/mac/ContextMenuItemMac.mm:
(WebCore::ContextMenuItem::releasePlatformDescription):
(WebCore::ContextMenuItem::getPlatformDescription):
(WebCore::ContextMenuItem::supportsShareMenu):
(WebCore::ContextMenuItem::shareSelectedTextMenuItem): Use NSMenu SPI to get the Share menu.
- platform/spi/mac/NSMenuSPI.h: Forward declare instead of #include
Source/WebKit/mac:
Unreviewed: Reland change after rollout.
Expose the "Share" menu for text selections on platforms where it's available.
rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
Patch by Brady Eidson <beidson@apple.com> on 2015-04-02
- WebView/WebImmediateActionController.mm: Update for required #include
Source/WebKit2:
Unreviewed: Re-applied change after rollout.
Expose the "Share" menu for text selections on platforms where it's available.
rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
Patch by Brady Eidson <beidson@apple.com> on 2015-04-02
- Shared/API/c/WKContextMenuItemTypes.h: Add a constant for the Share menu.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
- Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):
- Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::selectedText):
Add a "cross platform" menu item wrapper, right now only for NSMenuItem.
- Shared/NativeContextMenuItem.h:
(WebKit::NativeContextMenuItem::~NativeContextMenuItem):
(WebKit::NativeContextMenuItem::nsMenuItem):
- Shared/mac/NativeContextMenuItem.mm:
(WebKit::NativeContextMenuItem::NativeContextMenuItem):
Let WebContextMenuItem hold on to a NativeContextMenuItem to maintain full fidelity of the platform.
- Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::WebContextMenuItem):
- Shared/WebContextMenuItem.h:
(WebKit::WebContextMenuItem::create):
(WebKit::WebContextMenuItem::nativeContextMenuItem):
- UIProcess/API/APIContextMenuClient.h:
(API::ContextMenuClient::getContextMenuFromProposedMenu):
(API::ContextMenuClient::showContextMenu):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient):
- UIProcess/WebContextMenuProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::internalShowContextMenu): Translate the placeholder item from the web process into the
native Share menu before consulting the context menu client. Also create the API items here so the native NSMenuItem
can be attached to them.
- UIProcess/mac/WebContextMenuProxyMac.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKMenuTarget forwardContextMenuAction:]):
(WebKit::nsMenuItem):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::shareSelectedTextMenuItem): In the web process, mark the Share menu's place in the
context menu with a placeholder item. It will be translated into the real Share menu in the UI process.
- 6:07 PM Changeset in webkit [182302] by
-
- 5 edits in trunk/Websites/perf.webkit.org
Perf dashboard should have UI to test out anomaly detection strategies
https://bugs.webkit.org/show_bug.cgi?id=143290
Reviewed by Benjamin Poulain.
Added the UI to select anomaly detection strategies. The detected anomalies are highlighted in the graph.
Implemented the Western Electric Rules 1 through 4 in http://en.wikipedia.org/wiki/Western_Electric_rules
as well as Welch's t-test that compares the last five points to the prior twenty points.
The latter is what Mozilla uses (or at least did in the past) to detect performance regressions on their
performance tests although they compare medians instead of means.
All of these strategies don't quite work for us since our data points are too noisy but this is a good start.
- public/v2/app.js:
(App.Pane.updateStatisticsTools): Clone anomaly detection strategies.
(App.Pane._updateMovingAverageAndEnvelope): Highlight anomalies detected by the enabled strategies.
(App.Pane._movingAverageOrEnvelopeStrategyDidChange): Observe changes to anomaly detection strategies.
(App.Pane._computeMovingAverageAndOutliers): Detect anomalies by each strategy and aggregate results.
Only report the first data point when multiple consecutive data points are detected as anomalies.
- public/v2/chart-pane.css: Updated styles.
- public/v2/index.html: Added the pane for selecting anomaly detection strategies.
- public/v2/js/statistics.js:
(Statistics.testWelchsT): Added. Implements Welch's t-test.
(.sampleMeanAndVarianceForValues): Added.
(.createWesternElectricRule): Added.
(.countValuesOnSameSide): Added.
(Statistics.AnomalyDetectionStrategy): Added.
- 5:53 PM Changeset in webkit [182301] by
-
- 31 edits2 deletes in trunk/Source
Unreviewed, rolling out r182293.
https://bugs.webkit.org/show_bug.cgi?id=143355
Broke GTK and EFL builds. (Requested by bfulgham on #webkit).
Reverted changeset:
"Expose the "Share" menu for text selections on platforms
where it's available."
https://bugs.webkit.org/show_bug.cgi?id=143318
http://trac.webkit.org/changeset/182293
- 5:43 PM Changeset in webkit [182300] by
-
- 4 edits in trunk/LayoutTests
New ruby tests are failing on all non-Mac platforms.
https://bugs.webkit.org/show_bug.cgi?id=143354
Add skip commands for these new tests.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/win/TestExpectations:
- 5:40 PM Changeset in webkit [182299] by
-
- 3 edits in trunk/LayoutTests
http/tests/security/cross-frame-access-call.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=143344
Reviewed by Anders Carlsson.
- TestExpectations:
- http/tests/security/cross-frame-access-call-expected.txt:
Correct the results. Not sure where I got the different results from.
- 5:27 PM Changeset in webkit [182298] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION: Caption Menus show language codes instead of display names.
https://bugs.webkit.org/show_bug.cgi?id=143350
<rdar://problem/20094145>
Reviewed by Jer Noble.
The generic caption/track label handling in CaptionUserPreferences does not convert language codes
(e.g. 'fr-CA') into display names (e.g., 'French (Canada)'). Because we did not have an AudioTrack
override to process these types of menu items, they were being handled using the generic code.
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::buildStringForTrackBase): Helper function to share code with the two flavors
of 'trackDisplayName'.
(WebCore::trackDisplayName): Add a version to support AudioTracks, and modify the TextTrack
version to use the new 'buildStringForTrackBase' function.
(WebCore::CaptionUserPreferencesMediaAF::displayNameForTrack): Add an AudioTrack override so
our AVFoundation tracks are processed in our CaptionUserPreferencesMediaAF implementation, not the
generic version.
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu): Add an AudioTrack override so
that the menu items are sorted in order of display name, not language code.
- page/CaptionUserPreferencesMediaAF.h:
- 5:09 PM Changeset in webkit [182297] by
-
- 8 edits in trunk/Source/JavaScriptCore
JavaScriptCore API should support type checking for Array and Date
https://bugs.webkit.org/show_bug.cgi?id=143324
Reviewed by Darin Adler, Sam Weinig, Dan Bernstein.
- API/JSValue.h:
- API/JSValue.mm:
(-[JSValue isArray]):
(-[JSValue isDate]): Added an ObjC API.
- API/JSValueRef.cpp:
(JSValueIsArray):
(JSValueIsDate):
- API/JSValueRef.h: Added a C API.
- API/WebKitAvailability.h: Brought our availability macros up to date
and fixed a harmless bug where "10_10" translated to "10.0".
- API/tests/testapi.c:
(main): Added a test and corrected a pre-existing leak.
- API/tests/testapi.mm:
(testObjectiveCAPI): Added a test.
- 4:19 PM Changeset in webkit [182296] by
-
- 4 edits in trunk/Source/WebKit2
[WK2][NetworkCache] Drop HTTP method from NetworkCache::Key
https://bugs.webkit.org/show_bug.cgi?id=143348
Reviewed by Antti Koivisto.
Drop HTTP method from NetworkCache::Key as we only cache GET responses
for now. Even when we start caching HEAD responses, we likely will not
want the method to be part of the key because:
- A HEAD response can be used to update the headers of a previously cached response to GET
- A cached GET response may be used to satisfy subsequent HEAD requests
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::makeCacheKey):
- NetworkProcess/cache/NetworkCacheKey.cpp:
(WebKit::NetworkCache::Key::Key):
(WebKit::NetworkCache::Key::operator=):
(WebKit::NetworkCache::Key::computeHash):
(WebKit::NetworkCache::Key::operator==):
(WebKit::NetworkCache::Key::encode):
(WebKit::NetworkCache::Key::decode):
- NetworkProcess/cache/NetworkCacheKey.h:
(WebKit::NetworkCache::Key::method): Deleted.
- 3:50 PM Changeset in webkit [182295] by
-
- 2 edits in trunk/Source/WebKit2
[Mac][WK2] Fullscreen animation incorrect when initiated on non-primary monitor
https://bugs.webkit.org/show_bug.cgi?id=143237
Reviewed by Brent Fulgham.
The animation calculations have an implicit assumptions of a screen whose origin is 0,0. Account
for the screen origin by passing the window's screen's frame into the zoomAnimation() and maskAnimation()
methods.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController initWithWindow:webView:]):
(zoomAnimation):
(maskAnimation):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
- 3:46 PM Changeset in webkit [182294] by
-
- 5 edits in trunk/Source/JavaScriptCore
Add Options::dumpSourceAtDFGTime().
<https://webkit.org/b/143349>
Reviewed by Oliver Hunt, and Michael Saboff.
Sometimes, we will want to see the JS source code that we're compiling, and it
would be nice to be able to do this without having to jump thru a lot of hoops.
So, let's add a Options::dumpSourceAtDFGTime() option just like we have a
Options::dumpBytecodeAtDFGTime() option.
Also added versions of CodeBlock::dumpSource() and CodeBlock::dumpBytecode()
that explicitly take no arguments (instead of relying on the version that takes
the default argument). These versions are friendlier to use when we want to call
them from an interactive debugging session.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpSource):
(JSC::CodeBlock::dumpBytecode):
- bytecode/CodeBlock.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseCodeBlock):
- runtime/Options.h:
- 3:40 PM Changeset in webkit [182293] by
-
- 31 edits2 copies in trunk/Source
Expose the "Share" menu for text selections on platforms where it's available.
rdar://problem/20034174 and https://bugs.webkit.org/show_bug.cgi?id=143318
Reviewed by Sam Weinig.
Source/WebCore:
- page/ContextMenuClient.h:
(WebCore::ContextMenuClient::shareSelectedTextMenuItem):
- page/ContextMenuContext.h:
(WebCore::ContextMenuContext::setSelectedText):
(WebCore::ContextMenuContext::selectedText):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate): Add a Share menu item returned from the client.
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
- platform/ContextMenuItem.cpp:
(WebCore::ContextMenuItem::shareSelectedTextMenuItem):
- platform/ContextMenuItem.h:
(WebCore::ContextMenuItem::supportsShareMenu):
- platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::shareSelectedTextMenuItem):
- platform/mac/ContextMenuItemMac.mm:
(WebCore::ContextMenuItem::releasePlatformDescription):
(WebCore::ContextMenuItem::getPlatformDescription):
(WebCore::ContextMenuItem::supportsShareMenu):
(WebCore::ContextMenuItem::shareSelectedTextMenuItem): Use NSMenu SPI to get the Share menu.
- platform/spi/mac/NSMenuSPI.h: Forward declare instead of #include
Source/WebKit/mac:
- WebView/WebImmediateActionController.mm: Update for required #include
Source/WebKit2:
- Shared/API/c/WKContextMenuItemTypes.h: Add a constant for the Share menu.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
- Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):
- Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::selectedText):
Add a "cross platform" menu item wrapper, right now only for NSMenuItem.
- Shared/NativeContextMenuItem.h:
(WebKit::NativeContextMenuItem::~NativeContextMenuItem):
(WebKit::NativeContextMenuItem::nsMenuItem):
- Shared/mac/NativeContextMenuItem.mm:
(WebKit::NativeContextMenuItem::NativeContextMenuItem):
Let WebContextMenuItem hold on to a NativeContextMenuItem to maintain full fidelity of the platform.
- Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::WebContextMenuItem):
- Shared/WebContextMenuItem.h:
(WebKit::WebContextMenuItem::create):
(WebKit::WebContextMenuItem::nativeContextMenuItem):
- UIProcess/API/APIContextMenuClient.h:
(API::ContextMenuClient::getContextMenuFromProposedMenu):
(API::ContextMenuClient::showContextMenu):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient):
- UIProcess/WebContextMenuProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::internalShowContextMenu): Translate the placeholder item from the web process into the
native Share menu before consulting the context menu client. Also create the API items here so the native NSMenuItem
can be attached to them.
- UIProcess/mac/WebContextMenuProxyMac.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKMenuTarget forwardContextMenuAction:]):
(WebKit::nsMenuItem):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::shareSelectedTextMenuItem): In the web process, mark the Share menu's place in the
context menu with a placeholder item. It will be translated into the real Share menu in the UI process.
- 3:31 PM Changeset in webkit [182292] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Only pass in the AVURLAssetClientBundleIdentifierKey on iOS.
https://bugs.webkit.org/show_bug.cgi?id=143347
Reviewed by Brent Fulgham.
Only pass in the main app bundle id into AVURLAsset via the AVURLAssetClientBundleIdentifierKey option
on iOS. On OS X, setting this key can cause media playback to fail.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
- 3:23 PM Changeset in webkit [182291] by
-
- 3 edits in trunk/Source/WebKit2
De-PLATFORM(IOS)-ify LayerHostingContext::setFencePort
https://bugs.webkit.org/show_bug.cgi?id=143342
Reviewed by Myles C. Maxfield.
- Platform/mac/LayerHostingContext.h:
- Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::setFencePort):
There's nothing iOS specific about this.
- 3:22 PM Changeset in webkit [182290] by
-
- 3 edits in trunk/LayoutTests
Test gardening.
Unreviewed.
- fast/ruby/ruby-expansion-cjk-4-expected.html:
- fast/ruby/ruby-expansion-cjk-4.html:
- 2:52 PM Changeset in webkit [182289] by
-
- 2 edits in trunk/Source/WebKit2
Ensure that we always set network ATS context in the network process
https://bugs.webkit.org/show_bug.cgi?id=143343
Reviewed by Dan Bernstein.
If a custom cache location or size we were early returning before setting
the CFNetwork ATS context. This is clearly an error.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
- 2:48 PM Changeset in webkit [182288] by
-
- 2 edits in trunk/Source/WebCore
Show audio media controls on OSX.
https://bugs.webkit.org/show_bug.cgi?id=143346.
<rdar://problem/20306240>
Reviewed by Dean Jackson.
- Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-panel:hover):
Revert part of r180893.
- 2:25 PM Changeset in webkit [182287] by
-
- 2 edits in trunk/LayoutTests
http/tests/security/cross-frame-access-call.html is flaky.
Skip this test for now. Fixing it is being tracked by webkit.org/b/143344.
- 1:29 PM Changeset in webkit [182286] by
-
- 12 edits13 adds in trunk
Disallow ruby base from having leading or trailing expansions
https://bugs.webkit.org/show_bug.cgi?id=142608
Reviewed by David Hyatt.
Source/WebCore:
If we determine that a ruby base should have either a leading or trailing expansion,
we shunt that expansion over to the neighboring RenderText, assuming one exists. This
requires that we teach RenderText how to force leading or trailing expansions if one
wouldn't naturally be present.
Tests: fast/ruby/ruby-expansion-cjk-2.html
fast/ruby/ruby-expansion-cjk-3.html
fast/ruby/ruby-expansion-cjk-4.html
fast/ruby/ruby-expansion-cjk-5.html
fast/ruby/ruby-expansion-cjk.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::removeChild): Delete contentIsKnownToFollow.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::expansionBehavior): Support forced leading and trailing
expansions.
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::expansionBehavior): Moved to .cpp
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateRubyForJustifiedText): Perform relayout even if
there are no expansions left. This is so that ruby bases with no expansions will get
centered.
(WebCore::expansionBehaviorForInlineTextBox): Update to inspect neighboring rubies.
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment): Use updated
expansionBehaviorForInlineTextBox(). Also center ruby bases if they have no expansion
opportunities.
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns): Use nullptr.
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange): Ditto.
- rendering/RenderText.cpp:
(WebCore::RenderText::RenderText): Delete contentIsKnownToFollow.
- rendering/RenderText.h:
(WebCore::RenderText::contentIsKnownToFollow): Deleted.
(WebCore::RenderText::setContentIsKnownToFollow): Deleted.
LayoutTests:
Test combinations of CJK, Latin, ruby-in-ruby, simple text codepath, complex
text codepath, RTL, and LTR codepaths.
- fast/ruby/positioned-ruby-text-expected.txt:
- fast/ruby/positioned-ruby-text.html:
- fast/ruby/resources/green.png: Added.
- fast/ruby/resources/ruby-expansion.svg: Added.
- fast/ruby/ruby-expansion-cjk-2-expected.html: Added.
- fast/ruby/ruby-expansion-cjk-2.html: Added.
- fast/ruby/ruby-expansion-cjk-3-expected.html: Added.
- fast/ruby/ruby-expansion-cjk-3.html: Added.
- fast/ruby/ruby-expansion-cjk-4-expected.html: Added.
- fast/ruby/ruby-expansion-cjk-4.html: Added.
- fast/ruby/ruby-expansion-cjk-5-expected.html: Added.
- fast/ruby/ruby-expansion-cjk-5.html: Added.
- fast/ruby/ruby-expansion-cjk-expected.html: Added.
- fast/ruby/ruby-expansion-cjk.html: Added.
- fast/ruby/ruby-justification-expected.html:
- fast/ruby/ruby-justification.html:
- 12:53 PM Changeset in webkit [182285] by
-
- 2 edits in trunk/Source/WebKit2
Make checkURLReceivedFromWebProcess not rely on details of platform URL implementation.
https://bugs.webkit.org/show_bug.cgi?id=143222
rdar://problem/19978997
Reviewed by Sam Weinig.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
- 12:50 PM Changeset in webkit [182284] by
-
- 5 edits in trunk
Clean up access checks in JSHistoryCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=143227
Reviewed by Sam Weinig.
Source/WebCore:
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::putDelegate):
(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::deletePropertyByIndex):
(WebCore::JSHistory::getOwnPropertyNames):
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
LayoutTests:
- http/tests/security/cross-frame-access-call-expected.txt:
- http/tests/security/cross-frame-access-call.html:
- 12:46 PM Changeset in webkit [182283] by
-
- 2 edits in trunk/Source/WebCore
[Content Extensions] Only add unique universal action locations.
https://bugs.webkit.org/show_bug.cgi?id=143325
Reviewed by Benjamin Poulain.
- contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
Use a HashSet instead of a Vector for the universal action locations to remove duplicates.
- 12:41 PM Changeset in webkit [182282] by
-
- 2 edits in trunk/Source/WebCore
Fix slider colors for media controls on OSX.
https://bugs.webkit.org/show_bug.cgi?id=143328.
<rdar://problem/20357858>
Reviewed by Darin Adler.
Fill in bottom portion of volume slider.
Adjust colors to make slider controls look better. Will likely be tweaked later.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.drawTimelineBackground):
(Controller.prototype.drawVolumeBackground):
- 12:14 PM Changeset in webkit [182281] by
-
- 2 edits in trunk/LayoutTests
media/track/track-forced-subtitles-in-band.html times out
- platform/mac/TestExpectations: Update the expectations - the test doens't only fail
flakily, it times out too.
- 11:53 AM Changeset in webkit [182280] by
-
- 35 edits in trunk/Source
Clean up EnumerationMode to easily extend
https://bugs.webkit.org/show_bug.cgi?id=143276
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
To make the followings easily,
- Adding new flag Include/ExcludeSymbols in the Object.getOwnPropertySymbols patch
- Make ExcludeSymbols implicitly default for the existing flags
we encapsulate EnumerationMode flags into EnumerationMode class.
And this class manages 2 flags. Later it will be extended to 3.
- DontEnumPropertiesMode (default is Exclude)
- JSObjectPropertiesMode (default is Include)
- SymbolPropertiesMode (default is Exclude)
SymbolPropertiesMode will be added in Object.getOwnPropertySymbols patch.
This patch replaces places using ExcludeDontEnumProperties
to EnumerationMode() value which represents default mode.
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject<Parent>::getOwnNonIndexPropertyNames):
- API/JSObjectRef.cpp:
(JSObjectCopyPropertyNames):
- bindings/ScriptValue.cpp:
(Deprecated::jsToInspectorValue):
- bytecode/ObjectAllocationProfile.h:
(JSC::ObjectAllocationProfile::possibleDefaultPropertyCount):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
- runtime/EnumerationMode.h:
(JSC::EnumerationMode::EnumerationMode):
(JSC::EnumerationMode::includeDontEnumProperties):
(JSC::EnumerationMode::includeJSObjectProperties):
(JSC::shouldIncludeDontEnumProperties): Deleted.
(JSC::shouldExcludeDontEnumProperties): Deleted.
(JSC::shouldIncludeJSObjectPropertyNames): Deleted.
(JSC::modeThatSkipsJSObject): Deleted.
- runtime/GenericArgumentsInlines.h:
(JSC::GenericArguments<Type>::getOwnPropertyNames):
- runtime/JSArray.cpp:
(JSC::JSArray::getOwnNonIndexPropertyNames):
- runtime/JSArrayBuffer.cpp:
(JSC::JSArrayBuffer::getOwnNonIndexPropertyNames):
- runtime/JSArrayBufferView.cpp:
(JSC::JSArrayBufferView::getOwnNonIndexPropertyNames):
- runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnNonIndexPropertyNames):
- runtime/JSFunction.h:
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnNonIndexPropertyNames):
- runtime/JSLexicalEnvironment.cpp:
(JSC::JSLexicalEnvironment::getOwnNonIndexPropertyNames):
- runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):
- runtime/JSObject.cpp:
(JSC::getClassPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::getOwnNonIndexPropertyNames):
(JSC::JSObject::getGenericPropertyNames):
- runtime/JSPropertyNameEnumerator.h:
(JSC::propertyNameEnumerator):
- runtime/JSSymbolTableObject.cpp:
(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::defineProperties):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::getOwnNonIndexPropertyNames):
(JSC::RegExpObject::getPropertyNames):
(JSC::RegExpObject::getGenericPropertyNames):
- runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames):
- runtime/Structure.cpp:
(JSC::Structure::getPropertyNamesFromStructure):
Source/WebCore:
Use default EnumerationMode().
- bindings/js/Dictionary.cpp:
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bindings/scripts/test/JS/JSFloat64Array.h:
- bindings/scripts/test/JS/JSTestEventTarget.h:
- bridge/NP_jsobject.cpp:
(_NPN_Enumerate):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertyNames):
Source/WebKit/mac:
Use default EnumerationMode().
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate):
Source/WebKit2:
Use default EnumerationMode().
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::enumerate):
- 11:34 AM Changeset in webkit [182279] by
-
- 17 edits6 adds in trunk
[New Block-Inside-Inline Model] Implement the correct paint order for blocks inside inlines.
https://bugs.webkit.org/show_bug.cgi?id=143320
Reviewed by Darin Adler.
Source/WebCore:
Added new tests in fast/block/inside-inlines.
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::nodeAtPoint):
- rendering/EllipsisBox.h:
- rendering/InlineBox.h:
- rendering/InlineElementBox.cpp:
(WebCore::InlineElementBox::paint):
(WebCore::InlineElementBox::nodeAtPoint):
- rendering/InlineElementBox.h:
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
- rendering/InlineTextBox.h:
The HitTestAction has to be passed to nodeAtPoint so that hit test actions can be honored. All the nodeAtPoint
functions have been patched to include this argument. Painting and hit testing have been patched for InlineElementBox
to honor phases/actions when the element is an anonymous inline block.
The phase filter on RenderLineBoxList has been pushed in to InlineFlowBox::paint and InlineFlowBox::nodeAtPoint so that
we can respect it properly when inlines are painting by themselves (e.g., because they have a layer).
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::createLineBoxes):
(WebCore::RenderBlockFlow::constructLine):
Go ahead and include all of the inline flow boxes between the root and the anonymous inline block if it turns out they
need to be constructed. This will end up being relevant for outlines and for self-painting layers (e.g., opacity).
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):
Remove the filters here, since they get pushed in to InlineFlowBox.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::nodeAtPoint):
- rendering/RootInlineBox.h:
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):
- rendering/svg/SVGInlineTextBox.h:
More patching to pass the HitTestAction into nodeAtPoint.
LayoutTests:
- fast/block/inside-inlines/new-model/paint-order-expected.html: Added.
- fast/block/inside-inlines/new-model/paint-order.html: Added.
- fast/block/inside-inlines/opacity-on-inline-expected.html: Added.
- fast/block/inside-inlines/opacity-on-inline.html: Added.
- fast/block/inside-inlines/paint-order-expected.html: Added.
- fast/block/inside-inlines/paint-order.html: Added.
- 11:31 AM Changeset in webkit [182278] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][iOS] Update the WebContent process' sandbox profile for AWD
https://bugs.webkit.org/show_bug.cgi?id=143340
<rdar://problem/20375170>
Reviewed by Alexey Proskuryakov.
Update the WebContent process' sandbox profile for AWD.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 10:50 AM Changeset in webkit [182277] by
-
- 5 edits in branches/safari-600.5-branch/Source
Versioning.
- 10:38 AM Changeset in webkit [182276] by
-
- 3 edits in tags/Safari-601.1.25/Source/WebCore
Merged r182274. rdar://problem/20391647
- 10:37 AM Changeset in webkit [182275] by
-
- 9 edits9 adds in trunk
WebRTC: Add support for Promise-based MediaDevices.getUserMedia()
https://bugs.webkit.org/show_bug.cgi?id=143255
Reviewed by Eric Carlson.
Source/WebCore:
The MediaDevices object collects functionality related to local media
devices. This patch adds the Promise-based version of getUserMedia()
(unprefixed). Other functionality, like enumerateDevices(), will be
added in later patches.
The old callback-based webkitGetUserMedia() (on Navigator) is kept for
legacy purposes (according to the Media Capture and Streams API spec [1]).
Both versions of getUserMedia are backed up by UserMediaRequest where
the callbacks from the callback-based version are wrapped inside c++
lambda functions. The new Promise-based getUserMedia() uses the lambda
functions directly as created by the Promise bindings.
[1] http://w3c.github.io/mediacapture-main/archives/20150324/getusermedia.html#navigatorusermedia-interface-extensions
Test: fast/mediastream/MediaDevices-getUserMedia.html
- CMakeLists.txt:
- DerivedSources.make:
- Modules/mediastream/MediaDevices.cpp: Added.
(WebCore::MediaDevices::create):
(WebCore::MediaDevices::MediaDevices):
(WebCore::MediaDevices::~MediaDevices):
(WebCore::MediaDevices::document):
(WebCore::MediaDevices::getUserMedia):
- Modules/mediastream/MediaDevices.h: Added.
- Modules/mediastream/MediaDevices.idl: Added.
- Modules/mediastream/NavigatorMediaDevices.cpp: Added.
(WebCore::NavigatorMediaDevices::NavigatorMediaDevices):
(WebCore::NavigatorMediaDevices::~NavigatorMediaDevices):
(WebCore::NavigatorMediaDevices::from):
(WebCore::NavigatorMediaDevices::mediaDevices):
(WebCore::NavigatorMediaDevices::supplementName):
- Modules/mediastream/NavigatorMediaDevices.h: Added.
- Modules/mediastream/NavigatorMediaDevices.idl: Added.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::didCreateStream):
(WebCore::UserMediaRequest::failedToCreateStreamWithConstraintsError):
(WebCore::UserMediaRequest::failedToCreateStreamWithPermissionError):
- Modules/mediastream/UserMediaRequest.h:
- PlatformGTK.cmake:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSMediaDevicesCustom.cpp: Added.
(WebCore::JSMediaDevices::getUserMedia):
LayoutTests:
Added test for new Promise-based getUserMedia() (on MediaDevices).
- fast/dom/navigator-detached-no-crash.html:
- fast/mediastream/MediaDevices-getUserMedia-expected.txt: Added.
- fast/mediastream/MediaDevices-getUserMedia.html: Added.
- 10:15 AM Changeset in webkit [182274] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Fix AirPlay problem caused by r182240
https://bugs.webkit.org/show_bug.cgi?id=143337
Reviewed by Jer Noble.
- html/HTMLMediaSession.cpp:
(WebCore::HTMLMediaSession::wirelessVideoPlaybackDisabled): Return false if the legacy attribute
"x-webkit-airplay" has the value "allow".
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::parseAttribute): Don't call webkitWirelessVideoPlaybackDisabled when
processing "x-webkit-airplay" and "x-webkit-wirelessvideoplaybackdisabled", just consider
the attribute/value.
- 9:44 AM Changeset in webkit [182273] by
-
- 2 edits in trunk/LayoutTests
Reinstate expectations for fast/events/mouse-cursor-image-set.html now that r182247
was rolled out.
- platform/mac/TestExpectations:
- 9:43 AM Changeset in webkit [182272] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r182265.
https://bugs.webkit.org/show_bug.cgi?id=143338
Caused an assertion on
http/tests/contentextensions/whitelist.html (Requested by ap
on #webkit).
Reverted changeset:
"[Content Extensions] Only add unique universal action
locations."
https://bugs.webkit.org/show_bug.cgi?id=143325
http://trac.webkit.org/changeset/182265
- 8:45 AM Changeset in webkit [182271] by
-
- 19 edits in trunk/Source
Use std::chrono types to represent time in response and cache classes
https://bugs.webkit.org/show_bug.cgi?id=143316
Reviewed by Andreas Kling.
Source/WebCore:
Use std::chrono::system_clock::time_point to represent clock times and std::chrono::microseconds to
represent durations. Also use WTF::Optional for optional values (instead of coding them as NaNs).
- dom/Document.cpp:
(WebCore::Document::lastModified):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::freshnessLifetime):
(WebCore::CachedResource::responseReceived):
(WebCore::CachedResource::updateResponseAfterRevalidation):
- loader/cache/CachedResource.h:
- platform/network/CacheValidation.cpp:
(WebCore::computeCurrentAge):
(WebCore::computeFreshnessLifetimeForHTTPFamily):
(WebCore::updateRedirectChainStatus):
(WebCore::redirectChainAllowsReuse):
(WebCore::parseCacheControlDirectives):
- platform/network/CacheValidation.h:
(WebCore::RedirectChainCacheStatus::RedirectChainCacheStatus):
- platform/network/HTTPParsers.cpp:
(WebCore::parseHTTPDate):
(WebCore::parseDate): Deleted.
- platform/network/HTTPParsers.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::ResourceResponseBase):
(WebCore::ResourceResponseBase::cacheControlMaxAge):
(WebCore::parseDateValueInHeader):
(WebCore::ResourceResponseBase::date):
(WebCore::ResourceResponseBase::age):
(WebCore::ResourceResponseBase::expires):
(WebCore::ResourceResponseBase::lastModified):
- platform/network/ResourceResponseBase.h:
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didFinishLoading):
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::responseHasExpired):
(WebKit::NetworkCache::responseNeedsRevalidation):
(WebKit::NetworkCache::makeStoreDecision):
(WebKit::NetworkCache::Cache::store):
- NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::Entry):
(WebKit::NetworkCache::Entry::asJSON):
- NetworkProcess/cache/NetworkCacheEntry.h:
(WebKit::NetworkCache::Entry::timeStamp):
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::decodeRecordMetaData):
(WebKit::NetworkCache::decodeRecord):
Sanity check the timestamp on decode.
(WebKit::NetworkCache::encodeRecordMetaData):
(WebKit::NetworkCache::encodeRecordHeader):
(WebKit::NetworkCache::Storage::traverse):
- NetworkProcess/cache/NetworkCacheStorage.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::lastModifiedDateMS):
(WebKit::PluginView::Stream::didReceiveResponse):
(WebKit::PluginView::manualLoadDidReceiveResponse):
(WebKit::lastModifiedDate): Deleted.
- 1:51 AM Changeset in webkit [182270] by
-
- 6 edits2 adds in trunk
[CSS MultiColumn] Parse "columns: auto <length>" shorthand property value properly
https://bugs.webkit.org/show_bug.cgi?id=143248
Patch by Joonghun Park <jh718.park@samsung.com> on 2015-04-02
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/multicol/columns-shorthand-parsing-2.html
The two longhands for the 'columns' property ('column-count' and
'column-width') may both take 'auto' as a value. When we encounter
'auto' during parsing the value list of a declaration, we cannot just
make a guess at which property/properties that's meant for. Instead,
don't assign anything to 'auto' right away, but wait until all values
have been processed and at that point set the still unassigned
properties to 'auto'. If 'auto' isn't in the value list at all, set
unassigned properties to 'initial' for the 'columns' property, just
like we do for any other property.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColumnWidth):
(WebCore::CSSParser::parseColumnCount):
(WebCore::CSSParser::parseColumnsShorthand):
- css/CSSParser.h:
LayoutTests:
- fast/css/getPropertyValue-columns-expected.txt:
- fast/css/getPropertyValue-columns.html:
- fast/multicol/columns-shorthand-parsing-2-expected.txt: Added.
- fast/multicol/columns-shorthand-parsing-2.html: Added.
Apr 1, 2015:
- 11:29 PM Changeset in webkit [182269] by
-
- 2 edits in trunk/Tools
filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
https://bugs.webkit.org/show_bug.cgi?id=143282
Reviewed by Daniel Bates.
- Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
- 11:28 PM Changeset in webkit [182268] by
-
- 5 edits in trunk/Tools
When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
https://bugs.webkit.org/show_bug.cgi?id=143240
rdar://problem/19990425
Reviewed by Tim Horton.
- DumpRenderTree/mac/LayoutTestHelper.m:
(colorProfileURLForDisplay):
(saveDisplayColorProfiles):
Gracefully handle it when the current profile cannot be retrieved, fixing at
least one case when LayoutTestHelper couldn't start.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._set_up_run):
(Manager._force_pixel_tests_if_needed):
- Scripts/webkitpy/port/base.py: (Port.to.start_helper):
- Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
Return and check an error from start_helper().
- 10:58 PM Changeset in webkit [182267] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][Cocoa] Add didFailProvisionalLoadWithErrorForFrame callback to WKWebProcessPlugInLoadDelegate
https://bugs.webkit.org/show_bug.cgi?id=143319
<rdar://problem/19463834>
Reviewed by Dan Bernstein.
Add didFailProvisionalLoadWithErrorForFrame callback to
WKWebProcessPlugInLoadDelegate so that the client side can track all
types page load completions:
- didFailProvisionalLoadWithErrorForFrame
- didFailLoadWithErrorForFrame
- didFinishLoadForFrame
Note that this event is already exposed on UIProcess side via the
WKPageLoaderClient.didFailLoadWithErrorForFrame callback.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didFailProvisionalLoadWithErrorForFrame):
(setUpPageLoaderClient):
- 5:22 PM Changeset in webkit [182266] by
-
- 24 edits4 deletes in trunk
Unreviewed, rolling out r182247.
https://bugs.webkit.org/show_bug.cgi?id=143326
unfortunately broke some tests (Requested by dino on #webkit).
Reverted changeset:
"Async loading of image resources"
https://bugs.webkit.org/show_bug.cgi?id=134488
http://trac.webkit.org/changeset/182247
- 5:16 PM Changeset in webkit [182265] by
-
- 2 edits in trunk/Source/WebCore
[Content Extensions] Only add unique universal action locations.
https://bugs.webkit.org/show_bug.cgi?id=143325
Reviewed by Benjamin Poulain.
- contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
Use a HashSet instead of a Vector for the universal action locations to remove duplicates.
- 4:59 PM Changeset in webkit [182264] by
-
- 2 edits in trunk/LayoutTests
fast/events/mouse-cursor-image-set.html is timing out on Apple platforms
https://bugs.webkit.org/show_bug.cgi?id=143323
Removing old flakiness setting now that we should be skipping.
- platform/mac/TestExpectations:
- 4:47 PM Changeset in webkit [182263] by
-
- 3 edits in trunk/Source/WebCore
Fixes to material of inline media controls on OSX.
https://bugs.webkit.org/show_bug.cgi?id=143317
<rdar://problem/20357847>
Reviewed by Dean Jackson.
There are many existing tests for the media controls appearance.
They are currently skipped while we are still updating the controls.
Expand backgrounds of control panel and volume box.
Clip the darker edges away.
- Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-panel):
(audio::-webkit-media-controls-panel-background-container):
(audio::-webkit-media-controls-panel-tint):
(audio::-webkit-media-controls-panel-background):
(audio::-webkit-media-controls-panel .volume-box):
(audio::-webkit-media-controls-volume-slider-container-background):
(audio::-webkit-media-controls-volume-slider-container-tint):
(audio::-webkit-media-controls-panel .volume-box:active):
(video::-webkit-media-controls-volume-slider):
This needs to be above the background so it can be interacted with.
(video:-webkit-full-screen::-webkit-media-controls-panel .volume-box):
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls): Create a new div for the control material.
We need to clip the material and not the controls themselves.
(Controller.prototype.configureInlineControls): Use new div.
Remove some unnecessary logic involving hiding materials here.
It just causes the materials to turn on and off at the wrong times.
(Controller.prototype.handlePanelTransitionEnd):
(Controller.prototype.setPlaying):
(Controller.prototype.showControls):
(Controller.prototype.hideControls):
- 4:43 PM Changeset in webkit [182262] by
-
- 3 edits in trunk/Source/WebCore
Media controls should not always auto-hide
https://bugs.webkit.org/show_bug.cgi?id=143322
Reviewed by Dean Jackson.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller): Intialize new properties.
(Controller.prototype.hideControls): Do nothing if controlsAlwaysVisible() returns true;
(Controller.prototype.controlsAlwaysVisible): New.
(Controller.prototype.controlsAreHidden): Consult controlsAlwaysVisible().
(Controller.prototype.currentPlaybackTargetIsWireless): Use new properties.
(Controller.prototype.updateWirelessTargetAvailable): Cache video.webkitCurrentPlaybackTargetIsWireless
and video.webkitWirelessVideoPlaybackDisabled because we know when they change and
use them frequently.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.controlsAlwaysVisible): New.
- platform/graphics/MediaPlaybackTarget.h:
- 4:43 PM Changeset in webkit [182261] by
-
- 2 edits in trunk/Tools
[Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
https://bugs.webkit.org/show_bug.cgi?id=143321
Reviewed by Alexey Proskuryakov.
- EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
- 4:22 PM Changeset in webkit [182260] by
-
- 22 edits3 adds in trunk
Injected bundle messages should be at the page level.
https://bugs.webkit.org/show_bug.cgi?id=143283
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
All the messages between the injected bundle and the UI
process should be page level messages instead of context.
The author of this patch is Tim Horton, I just finished it.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageInjectedBundleClient):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKPageInjectedBundleClient.h: Added.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _pageForTesting]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/WebPageInjectedBundleClient.cpp: Added.
(WebKit::WebPageInjectedBundleClient::didReceiveMessageFromInjectedBundle):
(WebKit::WebPageInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):
- UIProcess/WebPageInjectedBundleClient.h: Added.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setInjectedBundleClient):
(WebKit::WebPageProxy::handleMessage):
(WebKit::WebPageProxy::handleSynchronousMessage):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::injectedBundleClient):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::handleMessage):
- WebKit2.xcodeproj/project.pbxproj:
- CMakeLists.txt:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePagePostMessage):
(WKBundlePagePostSynchronousMessage):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::postMessage):
(WebKit::WebPage::postSynchronousMessage):
- WebProcess/WebPage/WebPage.h:
Tools:
Updating WebKitTestRunner to use the new page level messaging.
The author of this patch is Tim Horton, I just finished it.
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::scheduleAsynchronousClick):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::scheduleAsynchronousKeyDown):
(WTR::EventSendingController::mouseScrollBy):
(WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
(WTR::EventSendingController::continuousMouseScrollBy):
(WTR::EventSendingController::addTouchPoint):
(WTR::EventSendingController::updateTouchPoint):
(WTR::EventSendingController::setTouchModifier):
(WTR::EventSendingController::setTouchPointRadius):
(WTR::EventSendingController::touchStart):
(WTR::EventSendingController::touchMove):
(WTR::EventSendingController::touchEnd):
(WTR::EventSendingController::touchCancel):
(WTR::EventSendingController::clearTouchPoints):
(WTR::EventSendingController::releaseTouchPoint):
(WTR::EventSendingController::cancelTouchPoint):
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::didReceiveMessageToPage):
(WTR::InjectedBundle::done):
(WTR::InjectedBundle::outputText):
(WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
(WTR::InjectedBundle::postAddChromeInputField):
(WTR::InjectedBundle::postRemoveChromeInputField):
(WTR::InjectedBundle::postFocusWebView):
(WTR::InjectedBundle::postSetBackingScaleFactor):
(WTR::InjectedBundle::postSetWindowIsKey):
(WTR::InjectedBundle::postSimulateWebNotificationClick):
(WTR::InjectedBundle::postSetAddsVisitedLinks):
(WTR::InjectedBundle::setGeolocationPermission):
(WTR::InjectedBundle::setMockGeolocationPosition):
(WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
(WTR::InjectedBundle::setUserMediaPermission):
(WTR::InjectedBundle::setCustomPolicyDelegate):
(WTR::InjectedBundle::setHidden):
(WTR::InjectedBundle::setCacheModel):
(WTR::InjectedBundle::shouldProcessWorkQueue):
(WTR::InjectedBundle::processWorkQueue):
(WTR::InjectedBundle::queueBackNavigation):
(WTR::InjectedBundle::queueForwardNavigation):
(WTR::InjectedBundle::queueLoad):
(WTR::InjectedBundle::queueLoadHTMLString):
(WTR::InjectedBundle::queueReload):
(WTR::InjectedBundle::queueLoadingScript):
(WTR::InjectedBundle::queueNonLoadingScript):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setHandlesAuthenticationChallenges):
(WTR::TestRunner::setAuthenticationUsername):
(WTR::TestRunner::setAuthenticationPassword):
(WTR::TestRunner::secureEventInputIsEnabled):
(WTR::TestRunner::setBlockAllPlugins):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::didReceivePageMessageFromInjectedBundle):
(WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
- 3:50 PM Changeset in webkit [182259] by
-
- 10 edits in trunk/Source/WebKit2
[iOS] WebContent should have access to the entirety of its caches directory
https://bugs.webkit.org/show_bug.cgi?id=143312
rdar://problem/20314916
Reviewed by Oliver Hunt.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
- Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):
- Shared/Network/NetworkProcessCreationParameters.h:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::networkingCachesDirectory):
(WebKit::WebProcessPool::webContentCachesDirectory):
(WebKit::WebProcessPool::openGLCacheDirectory): Deleted.
(WebKit::WebProcessPool::networkingHSTSDatabasePath): Deleted.
(WebKit::WebProcessPool::webContentHSTSDatabasePath): Deleted.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::createNewWebProcess):
- UIProcess/WebProcessPool.h:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 3:48 PM Changeset in webkit [182258] by
-
- 2 edits in trunk/LayoutTests
fast/events/mouse-cursor-image-set.html is timing out on Apple platforms
https://bugs.webkit.org/show_bug.cgi?id=143323
The change r182247 has caused this test to timeout. Rather than rollout
the commit I'm skipping the test and will contact Yoav.
- platform/mac/TestExpectations:
- 3:37 PM Changeset in webkit [182257] by
-
- 2 edits in tags/Safari-601.1.25/Source/WebCore
Merged r182255. rdar://problem/19130597
- 3:13 PM Changeset in webkit [182256] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r182121): SVG animation macros cause warnings in MSVC
https://bugs.webkit.org/show_bug.cgi?id=143313
Reviewed by Darin Adler.
- svg/SVGExternalResourcesRequired.h: Undo the change that caused a type mismatch.
- 2:26 PM Changeset in webkit [182255] by
-
- 2 edits in trunk/Source/WebCore
Another attempt to fixi the iOS build after r182240.
Reviewed by Dean Jackson.
- platform/graphics/MediaPlaybackTarget.h:
(WebCore::MediaPlaybackTarget::hasActiveRoute):
- 2:01 PM Changeset in webkit [182254] by
-
- 2 edits in trunk/Source/WTF
015-04-01 Antti Koivisto <Antti Koivisto>
Value assignment operator of Optional should be stricter
https://bugs.webkit.org/show_bug.cgi?id=143303
Reviewed by Andreas Kling.
struct Foo { mutable Optional<std::chrono::seconds> s; };
Foo foo, foo2;
foo = foo2;
doesn't build because it tries to use wrong operator=.
- wtf/Optional.h:
Add enable_if test similar to std::experimental::optional.
- 12:58 PM Changeset in webkit [182253] by
-
- 2 edits in tags/Safari-601.1.25/Source/WebCore
Merged r182250. rdar://problem/19130597
- 12:55 PM Changeset in webkit [182252] by
-
- 2 edits in trunk/LayoutTests
accessibility/textarea-selected-text-range.html failing on Windows WK1 Release
https://bugs.webkit.org/show_bug.cgi?id=143315
Removing clashing entry but changing the old entry to Skip.
- platform/win/TestExpectations:
- 12:51 PM Changeset in webkit [182251] by
-
- 27 edits in tags/Safari-601.1.25/Source/WebCore
Merged r182240. rdar://problem/19130597
- 12:49 PM Changeset in webkit [182250] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS build after r182240.
- platform/graphics/MediaPlaybackTarget.h:
- 12:33 PM Changeset in webkit [182249] by
-
- 2 edits in trunk/LayoutTests
accessibility/textarea-selected-text-range.html failing on Windows WK1 Release
https://bugs.webkit.org/show_bug.cgi?id=143315
Skipping this on Windows.
- platform/win/TestExpectations:
- 12:20 PM Changeset in webkit [182248] by
-
- 6 edits1 delete in trunk/Tools
Unreviewed, rolling out r182174 and r182177.
https://bugs.webkit.org/show_bug.cgi?id=143314
Try to correct EWS failures (Requested by bfulgham on
#webkit).
Reverted changesets:
"Python SCM should be able to retrieve untracked files"
https://bugs.webkit.org/show_bug.cgi?id=143135
http://trac.webkit.org/changeset/182174
"[buildbot] clean-build script should remove untracked files
and revert local changes too"
https://bugs.webkit.org/show_bug.cgi?id=142400
http://trac.webkit.org/changeset/182177
- 12:02 PM Changeset in webkit [182247] by
-
- 24 edits4 adds in trunk
Async loading of image resources
https://bugs.webkit.org/show_bug.cgi?id=134488
Reviewed by Dean Jackson.
Source/WebCore:
This patch changes image loading to be asynchronous (per spec), in order
for it to be agnostic to property setting order when it comes to src, srcset and crossorigin,
as well as to enable future hooking of the <picture>-based selection logic on top of it.
Tests: fast/dom/HTMLImageElement/image-load-post-onload.html
fast/dom/HTMLImageElement/sizes/image-sizes-js-change-reverse.html
- WebCore.xcodeproj/project.pbxproj: Change MicroTask.h to be private.
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent): Add a microtask checkpoint after event handling.
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute): Add a microtask checkpoint after running of a scheduled action.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::didMoveToNewDocument): Add the old document to call of elementDidMoveToNewDocument.
- html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::notifyFinished): Avoid a crash when notifyFinished is called and there's no CachedImage.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::didMoveToNewDocument): Add the old document to call of elementDidMoveToNewDocument.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didMoveToNewDocument): Add the old document to call of elementDidMoveToNewDocument.
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::didMoveToNewDocument): Add the old document to call of elementDidMoveToNewDocument.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd): Add a microtask checkpoint.
- loader/ImageLoader.cpp: Move image resource loading to be asynchronous.
(WebCore::ImageLoader::ImageLoaderTask::create):
(WebCore::ImageLoader::ImageLoaderTask::run): Run the image loading microtask and called doUpdateFromElement.
(WebCore::ImageLoader::ImageLoaderTask::ImageLoaderTask):
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::doUpdateFromElement): This is split from the previous updateFromElement, and performs the actual resource loading.
(WebCore::ImageLoader::updateFromElement): Now only prepares the stage for the actual image resource loading.
(WebCore::ImageLoader::shouldLoadImmediately): If this returns true, the image resource is loaded immediately, without queueing a microtask.
(WebCore::ImageLoader::notifyFinished): Add asserts.
(WebCore::ImageLoader::elementDidMoveToNewDocument): Handle document load event counters decrementing and incrementing.
- loader/ImageLoader.h:
(WebCore::ImageLoader::imageComplete): Make sure that the image is complete only if there aren't any pending tasks.
(WebCore::ImageLoader::hasPendingActivity): Make sure that pending activity takes pending tasks into account.
(WebCore::ImageLoader::hasPendingTask): Getter to know if an ImageLoader has a pending task. (Used by the image loading microtask)
(WebCore::ImageLoader::createWeakPtr): Create a weakPtr to be used by the microtask, so it can called back the loader if it's still alive.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest): Add a 'shouldBypassMainWorldContentSecurityPolicy' flag and act upon it.
(WebCore::CachedResourceLoader::requestImage): Add a 'shouldBypassMainWorldContentSecurityPolicy' flag.
(WebCore::CachedResourceLoader::requestResource): Add a 'shouldBypassMainWorldContentSecurityPolicy' flag.
- loader/cache/CachedResourceLoader.h:
(WebCore::CachedResourceLoader::canRequest): Add a 'shouldBypassMainWorldContentSecurityPolicy' flag and act upon it.
(WebCore::CachedResourceLoader::requestImage): Add a 'shouldBypassMainWorldContentSecurityPolicy' flag.
(WebCore::CachedResourceLoader::requestResource): Add a 'shouldBypassMainWorldContentSecurityPolicy' flag.
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::didMoveToNewDocument): Add the old document to call of elementDidMoveToNewDocument.
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::end): Add a microtask checkpoint after XML finishes parsing.
LayoutTests:
- fast/dom/HTMLImageElement/image-load-post-onload-expected.txt: Added.
- fast/dom/HTMLImageElement/image-load-post-onload.html: Added.
- fast/dom/HTMLImageElement/image-loading-gc.html: Cosmetic changes.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-change-reverse-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-change-reverse.html: Added.
- fast/dom/image-object.html: Cosmetic changes.
- http/tests/misc/image-blocked-src-change-expected.txt: Removed line numbers from console.
- http/tests/misc/image-blocked-src-no-change-expected.txt: Removed line numbers from console.
- http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Removed line numbers from console.
- http/tests/security/frame-loading-via-document-write-expected.txt: Removed line numbers from console.
- http/tests/security/local-image-from-remote-expected.txt: Removed line numbers from console.
- 12:00 PM Changeset in webkit [182246] by
-
- 2 edits in trunk/Source/WebKit/win
Fix Windows build.
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient::numWheelEventHandlersChanged): Deleted.
- 11:57 AM Changeset in webkit [182245] by
-
- 2 edits in trunk/Source/WebKit2
Smart magnification gesture sometimes shoots to the middle of the page
https://bugs.webkit.org/show_bug.cgi?id=143296
<rdar://problem/18209280>
Reviewed by Dean Jackson.
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::didCollectGeometryForSmartMagnificationGesture):
Constrain the target rect to the viewport, and if it had overflowed the viewport,
scroll halfway towards the gesture origin.
- 11:42 AM Changeset in webkit [182244] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix when using content extensions performance reporting.
- contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
Time how long it takes to build the DFAs.
- 11:36 AM Changeset in webkit [182243] by
-
- 35 edits1 add in trunk
Progress towards CMake on Windows and Mac.
https://bugs.webkit.org/show_bug.cgi?id=143293
Reviewed by Filip Pizlo.
.:
- CMakeLists.txt:
Set DERIVED_SOURCES_WTF_DIR for Windows.
- Source/CMakeLists.txt:
Don't compile bmalloc on Windows.
- Source/cmake/OptionsCommon.cmake:
Use the absolute path of the C preprocessor.
- Source/cmake/OptionsWinCairo.cmake:
Added needed definitions.
- Source/cmake/OptionsWindows.cmake:
Set some default values and removed support for old Visual Studio versions before /MP.
- Source/cmake/WebKitFS.cmake:
Make WTF DerivedSources directory.
- Source/cmake/WebKitMacros.cmake:
Added ADD_PRECOMPILED_HEADER macro based on
http://stackoverflow.com/questions/148570/using-pre-compiled-headers-with-cmake
Source/bmalloc:
- bmalloc/BAssert.h:
Removed ellipses from macros to appease Visual Studio.
Source/JavaScriptCore:
- CMakeLists.txt:
Enabled using assembly on Windows.
Replaced unix commands with CMake commands.
- PlatformMac.cmake:
Tell open source builders where to find unicode headers.
Source/ThirdParty/ANGLE:
- include/GLES2/gl2.h:
Temporarily disabled WebGL on Windows CMake builds.
Source/WebCore:
- PlatformMac.cmake:
Tell open source builders where to find unicode headers.
- PlatformWin.cmake:
Include PlatformWinCairo.cmake.
- PlatformWinCairo.cmake:
Added from bug 115944 by Patrick Gansterer.
- bindings/js/JSDOMStringListCustom.cpp:
- bindings/js/JSDOMWrapper.cpp:
- bindings/js/JSMessageChannelCustom.cpp:
- bindings/js/JSPopStateEventCustom.cpp:
- bindings/js/JSReadableStreamCustom.cpp:
- bindings/js/ReadableStreamJSSource.cpp:
- bindings/js/ScriptController.cpp:
- css/CSSComputedStyleDeclaration.cpp:
- dom/Attr.cpp:
- dom/CollectionIndexCache.cpp:
- platform/graphics/ANGLEWebKitBridge.h:
Fixed include quirks.
Source/WebKit:
- PlatformMac.cmake:
Fixed some include directories.
Source/WTF:
- wtf/CMakeLists.txt:
Don't use bmalloc on Windows yet.
- wtf/FeatureDefines.h:
Temporarily disabled WebGL on Windows CMake builds.
- wtf/PlatformMac.cmake:
Tell open source builders where to find unicode headers.
- 11:30 AM Changeset in webkit [182242] by
-
- 29 edits in trunk
Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
https://bugs.webkit.org/show_bug.cgi?id=143288
rdar://problem/16049624
Reviewed by Beth Dakin.
Remove the wheel event counting that Document does, and passes into the scrolling tree.
The ScrollingTree now just uses the non-fast scrollable region to determine when to
fast scroll on pages with wheel event handlers.
If a handler includes position:fixed renderers, we just cover the whole document
with the slow-scrolling region currently. This could be improved.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::wheelEventHandlersChanged):
(WebCore::Document::didAddWheelEventHandler):
(WebCore::Document::didRemoveWheelEventHandler):
(WebCore::Document::wheelEventHandlerCount):
(WebCore::Document::touchEventHandlerCount):
(WebCore::Document::absoluteRegionForEventTargets): Changed to return a pair<Region, bool>
where the bool indicates whether any handler includes position:fixed content.
(WebCore::pageWheelEventHandlerCountChanged): Deleted.
(WebCore::wheelEventHandlerCountChanged): Deleted.
- dom/Document.h:
(WebCore::Document::wheelEventHandlerCount): Deleted.
- loader/EmptyClients.h:
- page/ChromeClient.h:
- page/DebugPageOverlays.cpp:
(WebCore::MouseWheelRegionOverlay::updateRegion):
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
(WebCore::AsyncScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView): Deleted.
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinator::computeCurrentWheelEventHandlerCount): Deleted.
(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged): Deleted.
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView): Deleted.
- page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
(WebCore::ScrollingStateFrameScrollingNode::setWheelEventHandlerCount): Deleted.
- page/scrolling/ScrollingStateFrameScrollingNode.h:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::commitNewTreeState):
- page/scrolling/ScrollingTree.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::updateTiledScrollingIndicator):
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):
(WebCore::logWheelEventHandlerCountChanged): Deleted.
- testing/Internals.cpp:
(WebCore::Internals::touchEventHandlerCount):
Source/WebKit/mac:
Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
https://bugs.webkit.org/show_bug.cgi?id=143288
Reviewed by Beth Dakin.
Remove the wheel event counting that Document does, and passes into the scrolling tree.
The ScrollingTree now just uses the non-fast scrollable region to determine when to
fast scroll on pages with wheel event handlers.
- WebCoreSupport/WebChromeClient.h:
Source/WebKit2:
Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
https://bugs.webkit.org/show_bug.cgi?id=143288
rdar://problem/16049624
Reviewed by Beth Dakin.
Remove the wheel event counting that Document does, and passes into the scrolling tree.
The ScrollingTree now just uses the non-fast scrollable region to determine when to
fast scroll on pages with wheel event handlers.
If a handler includes position:fixed renderers, we just cover the whole document
with the slow-scrolling region currently. This could be improved.
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoder<ScrollingStateFrameScrollingNode>::encode):
(ArgumentCoder<ScrollingStateFrameScrollingNode>::decode):
(WebKit::RemoteScrollingTreeTextStream::dump):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::wheelEventHandlersChanged):
(WebKit::WebChromeClient::numWheelEventHandlersChanged): Deleted.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::wheelEventHandlersChanged):
(WebKit::WebPage::recomputeShortCircuitHorizontalWheelEventsState):
(WebKit::WebPage::numWheelEventHandlersChanged): Deleted.
- WebProcess/WebPage/WebPage.h:
LayoutTests:
Make it possible to compute a region for elements on the page that have wheel event handlers
https://bugs.webkit.org/show_bug.cgi?id=142807
Reviewed by Beth Dakin.
Update results, since any handler with position:fixed now causes the region to cover the document.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed-expected.txt:
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed-expected.txt:
- 11:10 AM Changeset in webkit [182241] by
-
- 9 edits4 adds in trunk
[New Block-Inside-Inline Model] Floats need to be allowed to intrude into anonymous inline-blocks.
https://bugs.webkit.org/show_bug.cgi?id=143307
Reviewed by Dean Jackson.
Source/WebCore:
Added fast/block/inside-inlines/basic-float-intrusion.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
Make sure to exclude the margins of an anonymous inline-block when considering the height of the line.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::baselinePosition):
Anonymous inline-block lines ignore line-height and just return the height of the block. For baseline position, the baseline
is considered to be at the bottom border edge of the anonymous inline-block.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::addIntrudingFloats):
- rendering/RenderBlockFlow.h:
Patch float intrusion to handle the case of anonymous inline-blocks. Instead of collecting the floats from our parent(), we
collect them from the containingBlock() in the anonymous inline-block case. Patch addIntrudingFloats to pass in the container
that acts as the "parent", since it is not the parent() in the anonymous inline-block case.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::updateLogicalInlinePositions):
Make sure to use the full available width for content always in the anonymous inline-block case, since we don't avoid the
floats, but instead let them intrude into the inline-block.
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
Patch callers of updateLogicalInlinePositions to pass in the root line box that we're checking for.
(WebCore::RenderBlockFlow::layoutLineBoxes):
Defer the layout of anonymous inline-blocks, since they need to only lay out once the vertical position to lay them out
at is known.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::createsNewFormattingContext):
(WebCore::RenderBox::avoidsFloats):
Anonymous inline-blocks do not establish a new block formatting context, nor do they avoid floats.
- rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleReplaced):
Add code to do a just-in-time layout of the anonymous inline-block at the time it is being examined (after the break before
it was handled).
LayoutTests:
- fast/block/inside-inlines/basic-float-intrusion-expected.html: Added.
- fast/block/inside-inlines/basic-float-intrusion.html: Added.
- fast/block/inside-inlines/new-model/basic-float-intrusion-expected.html: Added.
- fast/block/inside-inlines/new-model/basic-float-intrusion.html: Added.
- 11:07 AM Changeset in webkit [182240] by
-
- 27 edits in trunk/Source/WebCore
[Mac] Do not include route button if element does not support target playback
https://bugs.webkit.org/show_bug.cgi?id=143251
Reviewed by Jer Noble.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.currentPlaybackTargetIsWireless): Return false if target playback is disabled.
(Controller.prototype.updateWirelessTargetAvailable): Do not show the picker if target
playback is disabled.
(Controller.prototype.handleWirelessPlaybackChange): Call updateWirelessTargetAvailable.
- dom/Document.cpp:
(WebCore::Document::showPlaybackTargetPicker): Update for Page::showPlaybackTargetPicker change.
(WebCore::Document::didChoosePlaybackTarget): Notify clients in vector-order, lower level code
now tracks which one requested the picker.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource): Don't call applyMediaPlayerRestrictions, it is done
in mediaPlayerEngineFailedToLoad.
(WebCore::HTMLMediaElement::setReadyState): Enqueue a target availability event if there are
listeners readyState reaches HAVE_METADATA so controls are setup correctly.
(WebCore::HTMLMediaElement::mediaPlayerEngineFailedToLoad): Call applyMediaPlayerRestrictions.
(WebCore::HTMLMediaElement::clearMediaPlayer): Enqueue a target availability event in so controls
have a chance to hide the picker.
(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsSupported): New, passthrough to the
media engine.
(WebCore::HTMLMediaElement::canPlayToWirelessPlaybackTarget): Ditto.
(WebCore::HTMLMediaElement::startPlayingToPlaybackTarget): Ditto.
(WebCore::HTMLMediaElement::stopPlayingToPlaybackTarget): Ditto.
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- html/HTMLMediaSession.cpp:
(WebCore::HTMLMediaSession::HTMLMediaSession): Initialize m_playbackTarget.
(WebCore::HTMLMediaSession::currentPlaybackTargetIsSupported): New.
(WebCore::HTMLMediaSession::showPlaybackTargetPicker): Pull logic from showingPlaybackTargetPickerPermitted
inline. Don't refuse to show a picker if the element doesn't support target playback, it is up
to script to decide which elements can display a picker.
(WebCore::HTMLMediaSession::wirelessVideoPlaybackDisabled): Return true if there is no player.
(WebCore::HTMLMediaSession::didChoosePlaybackTarget): Call startPlayingToPlaybackTarget or
stopPlayingToPlaybackTarget because setWirelessPlaybackTarget doesn't apply the target.
(WebCore::HTMLMediaSession::externalOutputDeviceAvailableDidChange): Add logging.
(WebCore::HTMLMediaSession::showingPlaybackTargetPickerPermitted): Deleted.
- html/HTMLMediaSession.h:
- page/Page.cpp:
(WebCore::Page::Page): Initialize m_playbackTarget.
(WebCore::Page::showPlaybackTargetPicker): Don't set m_documentRequestingPlaybackTargetPicker.
(WebCore::Page::didChoosePlaybackTarget): Notify Pages in vector-order, lower level code
now tracks which one requested the picker.
(WebCore::Page::configurePlaybackTargetMonitoring): Don't track m_requiresPlaybackTargetMonitoring, it
is too easy for it to get out of sync with the UI process state.
- page/Page.h:
- platform/audio/MediaSession.cpp:
(WebCore::MediaSession::canPlayToWirelessPlaybackTarget): New, client passthrough.
(WebCore::MediaSession::startPlayingToPlaybackTarget): Ditto.
(WebCore::MediaSession::stopPlayingToPlaybackTarget): Ditto.
- platform/audio/MediaSession.h:
(WebCore::MediaSessionClient::canPlayToWirelessPlaybackTarget):
(WebCore::MediaSessionClient::startPlayingToPlaybackTarget):
(WebCore::MediaSessionClient::stopPlayingToPlaybackTarget):
- platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::sessionWillBeginPlayback): Call startPlayingToPlaybackTarget &
stopPlayingToPlaybackTarget as necessary.
- platform/audio/MediaSessionManager.h:
- platform/graphics/MediaPlaybackTarget.h:
(WebCore::MediaPlaybackTarget::hasActiveRoute): New.
- platform/graphics/MediaPlaybackTargetPickerClient.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::isCurrentPlaybackTargetSupported): New, engine passthrough.
(WebCore::MediaPlayer::canPlayToWirelessPlaybackTarget): Ditto.
(WebCore::MediaPlayer::startPlayingToPlaybackTarget): Ditto.
(WebCore::MediaPlayer::stopPlayingToPlaybackTarget): Ditto.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::isCurrentPlaybackTargetSupported):
(WebCore::MediaPlayerPrivateInterface::wirelessVideoPlaybackDisabled):
(WebCore::MediaPlayerPrivateInterface::canPlayToWirelessPlaybackTarget):
(WebCore::MediaPlayerPrivateInterface::startPlayingToPlaybackTarget):
(WebCore::MediaPlayerPrivateInterface::stopPlayingToPlaybackTarget):
- platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:
(WebCore::MediaPlaybackTarget::hasActiveRoute): New.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
(WebCore::MediaPlayerPrivateAVFoundationObjC::canPlayToWirelessPlaybackTarget):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Use playerKVOProperties. Drive-by
code cleanup.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Use playerKVOProperties.
(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessPlaybackTargetName): Implement for Mac.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessVideoPlaybackDisabled): Delay callbacks
while setting AVPlayer property.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessPlaybackTarget): Add logging. Don't set
the AVPlayer outputContext immediately.
(WebCore::MediaPlayerPrivateAVFoundationObjC::startPlayingToPlaybackTarget): New.
(WebCore::MediaPlayerPrivateAVFoundationObjC::stopPlayingToPlaybackTarget): New.
(WebCore::playerKVOProperties): New.
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Notify when
allowsExternalPlayback changes.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isCurrentPlaybackTargetSupported): New.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setWirelessPlaybackTarget): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::togglePlayingToPlaybackTarget): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::startPlayingToPlaybackTarget): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::stopPlayingToPlaybackTarget): Ditto.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::isCurrentPlaybackTargetSupported): Ditto.
(WebCore::MediaPlayerPrivateQTKit::setWirelessPlaybackTarget): Ditto.
(WebCore::MediaPlayerPrivateQTKit::togglePlayingToPlaybackTarget): Ditto.
(WebCore::MediaPlayerPrivateQTKit::startPlayingToPlaybackTarget): Ditto.
(WebCore::MediaPlayerPrivateQTKit::stopPlayingToPlaybackTarget): Ditto.
- 10:48 AM Changeset in webkit [182239] by
-
- 6 edits in trunk
[Content Extensions] Properly handle regexes that match everything.
https://bugs.webkit.org/show_bug.cgi?id=143281
Reviewed by Benjamin Poulain.
Source/WebCore:
- contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
Make sure we always have at least one NFA for rule lists with triggers that all match everything.
- contentextensions/DFABytecodeInterpreter.cpp:
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretTestFlagsAndAppendAction):
Add helper functions to reduce duplicate code.
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsFromDFARoot):
Get all actions without flags from the DFA root.
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
Remove branches when interpreting.
- contentextensions/DFABytecodeInterpreter.h:
Add helper functions to reduce duplicate code.
Tools:
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::testRequest):
(TestWebKitAPI::makeBackend):
(TestWebKitAPI::TEST_F):
Removed duplicate code and added test.
- 10:43 AM Changeset in webkit [182238] by
-
- 2 edits in trunk/Source/WebCore
Addressing post-review comments.
https://bugs.webkit.org/show_bug.cgi?id=143292
Unreviewed.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::leadingExpansionOpportunity):
(WebCore::FontCascade::trailingExpansionOpportunity):
- 10:32 AM Changeset in webkit [182237] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Link errors, unresolved texture mapper methods.
https://bugs.webkit.org/show_bug.cgi?id=143308
Patch by Per Arne Vollan <peavo@outlook.com> on 2015-04-01
Reviewed by Alex Christensen.
New texture mapper files should be included in the project.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 9:58 AM Changeset in webkit [182236] by
-
- 13 edits in trunk/Source/WebCore
Support forcing expansion opportunities at the beginning and ending of a run
https://bugs.webkit.org/show_bug.cgi?id=143292
Reviewed by David Hyatt.
Migrate ExpansionBehavior to an enum comprised of two values: one for leading behavior
and one for trailing behavior. Each of these two values can take on a value of
"force," "forbid," and neither. All calls that interact with justification are
migrated to use this new structure.
Note that in this terminology, "leading" and "trailing" are with respect to the order
that elements get laid out in a line. Therefore, leading is always on the left, since
lines get laid out that way regardless of their bidi attributes.
This is getting ready for https://bugs.webkit.org/show_bug.cgi?id=142608
No new tests because there is no behavior change.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::expansionOpportunityCountInternal): Migrate to these new
values.
(WebCore::FontCascade::expansionOpportunityCount): Ditto.
(WebCore::FontCascade::leadingExpansionOpportunity): Returns whether one is present
or not.
(WebCore::FontCascade::trailingExpansionOpportunity): Ditto.
- platform/graphics/FontCascade.h:
- platform/graphics/GlyphBuffer.h: New leading expansion field.
(WebCore::GlyphBuffer::setLeadingExpansion):
(WebCore::GlyphBuffer::leadingExpansion):
- platform/graphics/TextRun.h: m_expansionBehavior needs more bits.
(WebCore::TextRun::expansionBehavior):
(WebCore::TextRun::allowsLeadingExpansion): Deleted.
(WebCore::TextRun::allowsTrailingExpansion): Deleted.
- platform/graphics/WidthIterator.cpp: Update to support new type.
(WebCore::WidthIterator::WidthIterator):
(WebCore::expansionLocation): Where should we insert expansions?
(WebCore::WidthIterator::advanceInternal): Use expansionLocation()
- platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::FontCascade::adjustSelectionRectForComplexText):
(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText):
- platform/graphics/mac/ComplexTextController.cpp: Same as WidthIterator
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::advance):
(WebCore::expansionLocation):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::leadingExpansion):
- platform/text/TextFlags.h: Add new enum values
- rendering/InlineBox.h: Update to include new values.
(WebCore::InlineBox::InlineBoxBitfields::InlineBoxBitfields):
(WebCore::InlineBox::canHaveTrailingExpansion):
(WebCore::InlineBox::setCanHaveTrailingExpansion):
(WebCore::InlineBox::setForceTrailingExpansion):
(WebCore::InlineBox::forceTrailingExpansion):
(WebCore::InlineBox::setForceLeadingExpansion):
(WebCore::InlineBox::forceLeadingExpansion):
- rendering/InlineTextBox.h:
- rendering/RenderBlockLineLayout.cpp: Update to use new FontCascade signatures.
(WebCore::expansionBehaviorForInlineTextBox):
(WebCore::applyExpansionBehavior):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
- 8:56 AM Changeset in webkit [182235] by
-
- 9 edits in trunk/Source/WebCore
Lots of time spent querying table cell borders, when there are none.
https://bugs.webkit.org/show_bug.cgi?id=143277
Reviewed by Simon Fraser.
This patch speeds up collapsed border queries by using existing collapsed border
cache to calculate repaint rects and by introducing a fast path for zero width collapsed borders.
It reduces the number of calls to recompute collapsed borders from 36 000 to 1 600, while loading a page with a table of 400 rows (1 cell per row).
When scrolling the same page all the way down to the bottom, the number of calls to recompute collapsed borders falls from 290 000 to 0.
Covered by existing tests.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::styleDidChange): This moves invalidation time from RenderTable::layout() to styleDidChange().
(WebCore::RenderTable::invalidateCollapsedBorders):
(WebCore::RenderTable::recalcCollapsedBorders):
- rendering/RenderTable.h:
(WebCore::RenderTable::collapsedBordersAreValid):
(WebCore::RenderTable::invalidateCollapsedBorders): Deleted.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
(WebCore::RenderTableCell::willBeRemovedFromTree): Invalidate caches so that when repaint rect is calculated, we don't end up using stale values.
(WebCore::RenderTableCell::styleDidChange): Same as willBeRemovedFromTree.
(WebCore::RenderTableCell::collapsedStartBorder): Check if collapsed border is zero -also query cache.
(WebCore::RenderTableCell::collapsedEndBorder):
(WebCore::RenderTableCell::collapsedBeforeBorder):
(WebCore::RenderTableCell::collapsedAfterBorder):
(WebCore::RenderTableCell::cachedCollapsedLeftBorder):
(WebCore::RenderTableCell::cachedCollapsedRightBorder):
(WebCore::RenderTableCell::cachedCollapsedTopBorder):
(WebCore::RenderTableCell::cachedCollapsedBottomBorder):
(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::cellAtLeft): Deleted.
(WebCore::RenderTableCell::cellAtRight): Deleted.
(WebCore::RenderTableCell::cellAtTop): Deleted.
(WebCore::RenderTableCell::cellAtBottom): Deleted.
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::invalidateHasEmptyCollapsedBorders):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::addChild):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::styleDidChange):
(WebCore::RenderTableSection::clearCachedCollapsedBorders): This is just an extra safety to invalidate collapsed border cache. This is always
called together with RenderTable::invalidateCollapsedBorders() -and that should prevent the RenderCells to use the cache.
(WebCore::RenderTableSection::removeCachedCollapsedBorders):
(WebCore::RenderTableSection::setCachedCollapsedBorder):
(WebCore::RenderTableSection::cachedCollapsedBorder):
- rendering/RenderTableSection.h:
- 8:41 AM Changeset in webkit [182234] by
-
- 1 copy in tags/Safari-601.1.25
New tag.
- 8:39 AM Changeset in webkit [182233] by
-
- 5 edits in trunk/Source
Versioning.
- 7:30 AM Changeset in webkit [182232] by
-
- 2 edits in trunk/Source/WebCore
[CMake][GTK] Use the right variable to include the Wayland headers.
https://bugs.webkit.org/show_bug.cgi?id=143304
Reviewed by Carlos Garcia Campos.
No new tests, no behavior changes.
- PlatformGTK.cmake: Use the right variable WAYLAND_INCLUDE_DIRS.
- 6:39 AM Changeset in webkit [182231] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening. Remove warning message in layoutTest.
https://bugs.webkit.org/show_bug.cgi?id=143268
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-04-01
- platform/efl/TestExpectations:
- 4:15 AM Changeset in webkit [182230] by
-
- 2 edits in trunk
Use colored diagnostics when building with cmake + ninja + clang
https://bugs.webkit.org/show_bug.cgi?id=143297
Reviewed by Žan Doberšek.
Because that ninja sets subprocess stdout/stderr to a pipe, clang
disables colored output.
This patch forces clang to use colored diagnostics when we are using
the ninja.
- Source/cmake/OptionsCommon.cmake:
- 3:46 AM Changeset in webkit [182229] by
-
- 5 edits in trunk/Source/WebCore
[GStreamer] Move synchronous message handler to MediaPlayerPrivateGStreamerBase
https://bugs.webkit.org/show_bug.cgi?id=143218
Reviewed by Carlos Garcia Campos.
Moved the pipeline pointer to the base class, sub-classes should
now invoke setPipeline() when loading a resource. The base class
now takes care of configuring the GL shared context, this is more
logical because video rendering is also managed by this class.
No new tests, this is only a code refactoring.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
(WebCore::MediaPlayerPrivateGStreamer::pause):
(WebCore::MediaPlayerPrivateGStreamer::duration):
(WebCore::MediaPlayerPrivateGStreamer::currentTime):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::doSeek):
(WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate):
(WebCore::MediaPlayerPrivateGStreamer::paused):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::buffered):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress):
(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
(WebCore::MediaPlayerPrivateGStreamer::cancelLoad):
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
(WebCore::MediaPlayerPrivateGStreamer::cacheDuration):
(WebCore::MediaPlayerPrivateGStreamer::setDownloadBuffering):
(WebCore::MediaPlayerPrivateGStreamer::audioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
(WebCore::MediaPlayerPrivateGStreamer::simulateAudioInterruption):
(WebCore::mediaPlayerPrivateSyncMessageCallback): Deleted.
(WebCore::MediaPlayerPrivateGStreamer::handleSyncMessage): Deleted.
(WebCore::MediaPlayerPrivateGStreamer::ensureGstGLContext): Deleted.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::mediaPlayerPrivateNeedContextMessageCallback):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::setPipeline):
(WebCore::MediaPlayerPrivateGStreamerBase::handleNeedContextMessage):
(WebCore::MediaPlayerPrivateGStreamerBase::ensureGstGLContext):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- 3:38 AM Changeset in webkit [182228] by
-
- 2 edits in trunk/Source/ThirdParty
[CMake] Make gtest/CMakeLists.txt more readable
https://bugs.webkit.org/show_bug.cgi?id=143295
Patch by Gyuyoung Kim <Gyuyoung Kim> on 2015-04-01
Reviewed by Csaba Osztrogonác.
gtest/CMakeLists.txt has used add_library() and include_directory() directly.
This patch adds GTEST_INCLUDE_DIRECTORIES and GTEST_SOURCES, and use it.
- gtest/CMakeLists.txt:
- 3:19 AM Changeset in webkit [182227] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] GstGL support in the video sink
https://bugs.webkit.org/show_bug.cgi?id=138562
Use GStreamer's glimagesink for video rendering instead of our
custom video sink if a recent-enough version of GstGL is found
during the build. When glimagesink is used it passes a texture to
the media player which then wraps it inside a TextureMapper
texture later used for actual rendering.
Using this new code path will allow us to remove our custom sink
entirely in the long term.
Patch by Philippe Normand <philn@igalia.com> on 2015-03-24
Reviewed by Carlos Garcia Campos.
No new test, existing media tests cover video rendering already.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::mediaPlayerPrivateDrawCallback): client-draw signal callback.
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize): Better
check for sample validity.
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): Ditto.
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint): Trigger a
repaint and wait its completion.
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
Extract texture ID and video dimensions from the sample and do actual paint.
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink): Use
glimagesink if GstGL is available.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- 2:36 AM Changeset in webkit [182226] by
-
- 4 edits2 adds in trunk/Source/JavaScriptCore
IteratorClose should be called when jumping over the target for-of loop
https://bugs.webkit.org/show_bug.cgi?id=143140
Reviewed by Geoffrey Garen.
This patch fixes labeled break/continue behaviors with for-of and iterators.
- Support IteratorClose beyond multiple loop contexts
Previously, IteratorClose is only executed in for-of's breakTarget().
However, this misses IteratorClose execution when statement roll-ups multiple control flow contexts.
For example,
outer: for (var e1 of outer) {
inner: for (var e2 of inner) {
break outer;
}
}
In this case, return method of inner should be called.
We leverage the existing system forfinally
to execute inner.return method correctly.
Leveragingfinally
system fixesbreak
,continue
andreturn
cases.
throw
case is already supported by emitting try-catch handlers in for-of.
- Incorrect LabelScope creation is done in ForOfNode
ForOfNode creates duplicated LabelScope.
It causes infinite loop when executing the following program that contains
explicitly labeled for-of loop.
For example,
inner: for (var elm of array) {
continue inner;
}
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::pushFinallyContext):
(JSC::BytecodeGenerator::pushIteratorCloseContext):
(JSC::BytecodeGenerator::popFinallyContext):
(JSC::BytecodeGenerator::popIteratorCloseContext):
(JSC::BytecodeGenerator::emitComplexPopScopes):
(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::emitIteratorClose):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ForOfNode::emitBytecode):
- tests/stress/iterator-return-beyond-multiple-iteration-scopes.js: Added.
(createIterator.iterator.return):
(createIterator):
- tests/stress/raise-error-in-iterator-close.js: Added.
(createIterator.iterator.return):
(createIterator):
- 2:03 AM Changeset in webkit [182225] by
-
- 6 edits2 adds in trunk/Source/JavaScriptCore
[ES6] Implement Symbol.unscopables
https://bugs.webkit.org/show_bug.cgi?id=142829
Reviewed by Geoffrey Garen.
This patch introduces Symbol.unscopables functionality.
In ES6, some generic names (like keys, values) are introduced
as Array's method name. And this breaks the web since some web sites
use like the following code.
var values = ...;
with (array) {
values; This values is trapped by array's method "values".
}
To fix this, Symbol.unscopables introduces blacklist
for with scope's trapping. When resolving scope,
if name is found in the target scope and the target scope is with scope,
we check Symbol.unscopables object to filter generic names.
This functionality is only active for with scopes.
Global scope does not have unscopables functionality.
And since
1) op_resolve_scope for with scope always return Dynamic resolve type,
2) in that case, JSScope::resolve is always used in JIT and LLInt,
3) the code which contains op_resolve_scope that returns Dynamic cannot be compiled with DFG and FTL,
to implement this functionality, we just change JSScope::resolve and no need to change JIT code.
So performance regression is only visible in Dynamic resolving case, and it is already much slow.
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
- runtime/CommonIdentifiers.h:
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::runtimeFlags):
- runtime/JSScope.cpp:
(JSC::isUnscopable):
(JSC::JSScope::resolve):
- runtime/JSScope.h:
(JSC::ScopeChainIterator::scope):
- tests/stress/global-environment-does-not-trap-unscopables.js: Added.
(test):
- tests/stress/unscopables.js: Added.
(test):
(.):
- 12:24 AM Changeset in webkit [182224] by
-
- 3 edits in trunk/Source/WebCore
nullptr cleanup in StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=143260
Patch by Joonghun Park <jh718.park@samsung.com> on 2015-04-01
Reviewed by Ryosuke Niwa.
No new tests, no behavior changes
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::findFromMatchedPropertiesCache):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::MatchedProperties::MatchedProperties):
- css/StyleResolver.h:
(WebCore::PseudoStyleRequest::PseudoStyleRequest):
(WebCore::StyleResolverParentPusher::StyleResolverParentPusher):
- 12:07 AM Changeset in webkit [182223] by
-
- 6 edits in trunk/LayoutTests
REGRESSION (r179820): accessibility/textarea-selected-text-range.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=142976
Reviewed by Chris Fleizach.
- platform/mac/TestExpectations: Removed an expectation.
- accessibility/textarea-selected-text-range-expected.txt:
- accessibility/textarea-selected-text-range.html:
Don't race a timer with an internal dispatch_async.
- platform/mac/accessibility/select-element-selection-with-optgroups-expected.txt:
- platform/mac/accessibility/select-element-selection-with-optgroups.html:
This test had the same issue.
Mar 31, 2015:
- 11:18 PM Changeset in webkit [182222] by
-
- 2 edits in trunk/Source/WTF
Fix the build after <http://trac.webkit.org/changeset/182205>.
- wtf/text/StringImpl.h: (WTF::StringImpl::extractFoldedStringInSymbol):
A function cannot be both exported and inline.
- 11:16 PM Changeset in webkit [182221] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: console.error(object) has double disclosure triangles
https://bugs.webkit.org/show_bug.cgi?id=142069
Use inline-block instead of "float: left" or "position: absolute" to
make layout more predictable and easier to understand.
Reviewed by Timothy Hatcher.
- UserInterface/Views/LogContentView.css:
(.outline-disclosure, .outline-disclosure ol):
(.outline-disclosure > li.parent):
(.outline-disclosure > li.parent::before):
(.outline-disclosure li.parent): Deleted.
(.outline-disclosure li.parent::before): Deleted.
- UserInterface/Views/ObjectTreePropertyTreeElement.css:
(.object-tree-property > .titles):
(.object-tree-property > .disclosure-button):
(.object-tree-property > .icon):
- UserInterface/Views/ObjectTreeView.css:
(.object-tree > :matches(.title, .object-preview)::before):
(.object-tree:not(.lossless-preview) > :matches(.title, .object-preview)):
- 10:00 PM Changeset in webkit [182220] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION: Filtering no longer works
https://bugs.webkit.org/show_bug.cgi?id=143099
Reviewed by Brian Burg.
Add a check for an empty array of filter functions and return true in this case to ensure text
and timeline filters work correctly.
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.matchTreeElementAgainstFilterFunctions):
- 9:06 PM Changeset in webkit [182219] by
-
- 5 edits in trunk/Source/WebKit2
<rdar://problem/20365675> [iOS] Include Add to Reading List link action only where supported
https://bugs.webkit.org/show_bug.cgi?id=143289
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/_WKElementAction.h: Excluded _WKElementActionTypeAddToReadingList from
the _WKElementActionType enum when Reading List is not supported.
- UIProcess/API/Cocoa/_WKElementAction.mm:
(+[_WKElementAction elementActionWithType:customTitle:]): Made Add to Reading List code
conditional on HAVE(SAFARI_SERVICES_FRAMEWORK).
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant showImageSheet]): Ditto.
(-[WKActionSheetAssistant showLinkSheet]): Ditto.
- config.h: Defined HAVE_SAFARI_SERVICES_FRAMEWORK.
- 7:35 PM Changeset in webkit [182218] by
-
- 7 edits in trunk
ES6 class syntax should allow static setters and getters
https://bugs.webkit.org/show_bug.cgi?id=143180
Source/JavaScriptCore:
Reviewed by Filip Pizlo
Apparently I misread the spec when I initially implemented parseClass.
ES6 class syntax allows static getters and setters so just allow that.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseClass):
LayoutTests:
Reviewed by Filip Pizlo.
Added test cases.
- js/class-syntax-declaration-expected.txt:
- js/class-syntax-expression-expected.txt:
- js/script-tests/class-syntax-declaration.js:
- js/script-tests/class-syntax-expression.js:
- 7:05 PM Changeset in webkit [182217] by
-
- 4 edits in trunk/Source
TextIndicator for <span> inside an <a> only highlights the <span>, should highlight the whole <a>
https://bugs.webkit.org/show_bug.cgi?id=143287
<rdar://problem/20318342>
Reviewed by Beth Dakin.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _defaultAnimationController]):
Instead of just highlighting the hit element, highlight the whole
element that the link URL comes from.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performActionMenuHitTestAtLocation):
Instead of just highlighting the hit element, highlight the whole
element that the link URL comes from.
- 6:51 PM EFLWebKitReleasePlan edited by
- (diff)
- 6:15 PM Changeset in webkit [182216] by
-
- 4 edits in trunk/Source/WebKit2
WKView should stop using endGestureWithEvent
https://bugs.webkit.org/show_bug.cgi?id=143285
<rdar://problem/20357007>
Reviewed by Simon Fraser.
- UIProcess/API/mac/WKView.mm:
(-[WKView magnifyWithEvent:]):
(-[WKView endGestureWithEvent:]): Deleted.
- UIProcess/mac/ViewGestureController.h:
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::endMagnificationGesture):
(WebKit::ViewGestureController::endActiveGesture): Deleted.
While there is no visible symptom, it is recommended that we check
the phase of normal magnification events instead of using the
special gesture end events.
- 4:42 PM Changeset in webkit [182215] by
-
- 12 edits23 adds in trunk
Make it possible to compute a region for elements on the page that have wheel event handlers
https://bugs.webkit.org/show_bug.cgi?id=142807
Reviewed by David Hyatt.
Source/WebCore:
Make it possible to compute a region that covers the elements on the page that have
a wheel event handler. This region may overestimate, but must not underestimate the area.
Elements with wheel handlers are registered on the document, and when a document gains
its first wheel handler, it registers the ownerElement in the parent document. Thus, on
the main frame, the region encompasses elements with handlers, and iframes whose subdocuments
have handlers.
Element gains some functions that allow it to return a rect which is the bounds of the element's
renderer, and renders for its descendant elements, which is the size or larger than the event
handling region for that element. Some configurations (e.g. position:fixed) require special
treatment.
Document::absoluteRegionForEventTargets() can then iterate over all elements in the given set,
and build a Region for those (short-circuiting if the document itself has a handler).
The new code is exercised for the debug MouseWheelRegionOverlay, and also added to the
non-fast scrollable region, used by threaded scrolling.
Tests: platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-columns.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-document.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic.html
- dom/ContainerNode.h:
(WebCore::ContainerNode::absoluteEventHandlerBounds): Base class implementation; returns empty rect.
- dom/Document.cpp:
(WebCore::Document::prepareForDestruction): Unregister from the parent document.
(WebCore::Document::didAddWheelEventHandler): Add to the wheel handler set. Tell the parent
document if we are adding wheel handlers for the first time. Eventually the wheelEventHandlerCountChanged()
code will be removed, now we have the set. Tell debug overlays that we changed.
(WebCore::Document::didRemoveWheelEventHandler): Remove from the set, and unregister with the parent
document if necessary. Tell debug overlays that we changed.
(WebCore::Document::didAddTouchEventHandler): Minor cleanup.
(WebCore::Document::didRemoveTouchEventHandler): Ditto.
(WebCore::Document::didRemoveEventTargetNode): Remove from wheel targets.
(WebCore::Document::absoluteEventHandlerBounds): Implementation of the ContainerNode
function, just return the document bounds.
(WebCore::Document::absoluteRegionForEventTargets): Iterate over the given event targets,
and call absoluteEventHandlerBounds() on each.
- dom/Document.h:
(WebCore::Document::wheelEventTargets):
- dom/Element.cpp:
(WebCore::layoutOverflowRectContainsAllDescendants): Return true if we can determine that the
layoutOverflow bounds of the given renderer contains the renderers of all descendant elements.
(WebCore::Element::eventBounds): Get the "event handling" bounds of this element (excluding
descendants), and while doing so, compute whether any descendants are position:fixed, and whether
these bounds are known to include descendants.
(WebCore::Element::eventBoundsOfElementAndDescendants): Recursive function that short-circuits
if it can determine that descendants are enclosed by the bounds.
(WebCore::Element::absoluteEventHandlerBounds):
- dom/Element.h:
- page/DebugPageOverlays.cpp:
(WebCore::MouseWheelRegionOverlay::updateRegion): Ask the document for the region of wheel
event handlers.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion): Add the wheel handler region
to the non-fast scrollable region.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo): Overflow scrolling needs to dirty event regions.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteBoundingBoxRect): Need to pass the "wasFixed" flag out
of this function.
(WebCore::RenderObject::localToAbsolute): Ditto.
- rendering/RenderObject.h:
LayoutTests:
Tests that dump the non-fast-scrollable region, for various rendering configurations.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/handlers-in-iframes-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/resources/gain-wheel-handler.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/resources/lose-wheel-handler.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/resources/wheel-handler-region-helper.js: Added.
(rectsAsString):
(dumpRegion):
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-columns.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-document-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-document.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic.html: Added.
- 4:38 PM Changeset in webkit [182214] by
-
- 4 edits in trunk/Source/WebKit2
Swipes occur in the wrong direction in RTL
https://bugs.webkit.org/show_bug.cgi?id=143257
<rdar://problem/20300862>
Reviewed by Simon Fraser.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]):
When choosing which edge to attach our gesture recognizers to,
flip them in RTL.
(-[WKSwipeTransitionController directionForTransition:]):
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::canSwipeInDirection):
- UIProcess/mac/ViewGestureController.h:
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::scrollEventCanBecomeSwipe):
(WebKit::ViewGestureController::trackSwipeGesture):
(WebKit::ViewGestureController::determineLayerAdjacentToSnapshotForParent):
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::handleSwipeGesture):
Adjust SwipeDirection to be in logical back-forward list direction
instead of physical edge direction.
- 4:15 PM Changeset in webkit [182213] by
-
- 2 edits in trunk/Source/JavaScriptCore
PutClosureVar CSE def() rule has a wrong base
https://bugs.webkit.org/show_bug.cgi?id=143280
Reviewed by Michael Saboff.
I think that this code was incorrect in a benign way, since the base of a
PutClosureVar is not a JS-visible object. But it was preventing some optimizations.
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- 4:07 PM Changeset in webkit [182212] by
-
- 2 edits in trunk/Source/WebCore
Fix bindings tests results after <http://trac.webkit.org/changeset/182205>.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjReplaceableAttribute):
- 3:59 PM Changeset in webkit [182211] by
-
- 10 edits3 adds in trunk
Content Extensions: split the state machines to minimize prefix states
https://bugs.webkit.org/show_bug.cgi?id=143253
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-03-31
Reviewed by Alex Christensen.
Source/WebCore:
With this patch, we refine how the URLs are partitioned to make
multiple small machines instead of a big one.
Here, considering each pattern as a language, I took the simplest
partitioning: take the union minimizing the states
that differentiate languages.
The idea is the following: every time a subgraph can be skipped
or repeated, it is an opportunity for a merged language to start
with a distinguishable state.
To avoid accumulating those differences, we only merge languages
that share the exact same "variable" subgraph as a prefix.
A side effect is that we could create as many machines as we have patterns.
We'll have to address that in a follow-up by merging small machines
until they reach a certain size.
In the common cases, patterns look very much alike so that is not a problem
at the moment.
- WebCore.xcodeproj/project.pbxproj:
- contentextensions/CombinedURLFilters.cpp: Added.
I moved the prefix tree and graph construction out of URLFilterParser for clarity.
CombinedURLFilters maintain the term prefix tree. Instead of generating on the fly
as we build the prefix tree, we first generate the entire tree of terms, then generate
NFAs for each branch without a variable prefix.
(WebCore::ContentExtensions::CombinedURLFilters::CombinedURLFilters):
(WebCore::ContentExtensions::CombinedURLFilters::~CombinedURLFilters):
(WebCore::ContentExtensions::CombinedURLFilters::addPattern):
Note here that we keep track of which subtree contains a any variable length term.
Instead of anotating the edges, the destination vertex is anotated with the information
from the edge.
The flag "inVariableLengthPrefix" is there to simplify traversal.
(WebCore::ContentExtensions::generateNFAForSubtree):
(WebCore::ContentExtensions::CombinedURLFilters::createNFAs):
Since we are traversing a tree generated by string, using the stack for recursion
is out of the question.
Fortunately, the entire state is very simple when going depth first: we only need
the active vertex and edge, and traverse the edges in order.
To do keep track of the edges, I used the HashTable iterator on the current term.
Since no vertex is modified for generation, storing the iterators is safe.
- contentextensions/CombinedURLFilters.h:
- contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
- contentextensions/NFA.cpp:
(WebCore::ContentExtensions::NFA::setActions):
(WebCore::ContentExtensions::NFA::debugPrintDot):
(WebCore::ContentExtensions::NFA::setFinal): Deleted.
(WebCore::ContentExtensions::NFA::addRuleId): Deleted.
- contentextensions/NFA.h:
- contentextensions/NFAGraphBuilder.cpp: Added.
- contentextensions/NFAGraphBuilder.h: Added.
- contentextensions/NFANode.h:
- contentextensions/Term.h: Added.
Move the Term to its own file since it is now shared between the parser
and the CombinedURLFilters.
(WebCore::ContentExtensions::Term::CharacterSet::operator==):
(WebCore::ContentExtensions::Term::CharacterSet::hash):
(WebCore::ContentExtensions::Term::Group::operator==):
(WebCore::ContentExtensions::Term::Group::hash):
(WebCore::ContentExtensions::TermHash::hash):
(WebCore::ContentExtensions::TermHash::equal):
(WebCore::ContentExtensions::Term::Term):
(WebCore::ContentExtensions::Term::~Term):
(WebCore::ContentExtensions::Term::isValid):
(WebCore::ContentExtensions::Term::addCharacter):
(WebCore::ContentExtensions::Term::extendGroupSubpattern):
(WebCore::ContentExtensions::Term::quantify):
(WebCore::ContentExtensions::Term::Term::generateGraph):
(WebCore::ContentExtensions::Term::isEndOfLineAssertion):
(WebCore::ContentExtensions::Term::matchesAtLeastOneCharacter):
(WebCore::ContentExtensions::Term::isKnownToMatchAnyString):
(WebCore::ContentExtensions::Term::hasFixedLength):
(WebCore::ContentExtensions::Term::operator=):
(WebCore::ContentExtensions::Term::operator==):
(WebCore::ContentExtensions::Term::hash):
(WebCore::ContentExtensions::Term::isEmptyValue):
(WebCore::ContentExtensions::Term::isDeletedValue):
(WebCore::ContentExtensions::Term::isUniversalTransition):
(WebCore::ContentExtensions::Term::generateSubgraphForAtom):
(WebCore::ContentExtensions::Term::destroy):
- contentextensions/URLFilterParser.cpp:
(WebCore::ContentExtensions::PatternParser::PatternParser):
(WebCore::ContentExtensions::PatternParser::finalize):
(WebCore::ContentExtensions::PatternParser::assertionBOL):
(WebCore::ContentExtensions::URLFilterParser::URLFilterParser):
(WebCore::ContentExtensions::URLFilterParser::addPattern):
(WebCore::ContentExtensions::Term::Term): Deleted.
(WebCore::ContentExtensions::Term::~Term): Deleted.
(WebCore::ContentExtensions::Term::isValid): Deleted.
(WebCore::ContentExtensions::Term::addCharacter): Deleted.
(WebCore::ContentExtensions::Term::extendGroupSubpattern): Deleted.
(WebCore::ContentExtensions::Term::quantify): Deleted.
(WebCore::ContentExtensions::Term::generateGraph): Deleted.
(WebCore::ContentExtensions::Term::isEndOfLineAssertion): Deleted.
(WebCore::ContentExtensions::Term::matchesAtLeastOneCharacter): Deleted.
(WebCore::ContentExtensions::Term::isKnownToMatchAnyString): Deleted.
(WebCore::ContentExtensions::Term::operator=): Deleted.
(WebCore::ContentExtensions::Term::operator==): Deleted.
(WebCore::ContentExtensions::Term::hash): Deleted.
(WebCore::ContentExtensions::Term::isEmptyValue): Deleted.
(WebCore::ContentExtensions::Term::isDeletedValue): Deleted.
(WebCore::ContentExtensions::Term::isUniversalTransition): Deleted.
(WebCore::ContentExtensions::Term::generateSubgraphForAtom): Deleted.
(WebCore::ContentExtensions::Term::destroy): Deleted.
(WebCore::ContentExtensions::Term::CharacterSet::operator==): Deleted.
(WebCore::ContentExtensions::Term::CharacterSet::hash): Deleted.
(WebCore::ContentExtensions::Term::Group::operator==): Deleted.
(WebCore::ContentExtensions::Term::Group::hash): Deleted.
(WebCore::ContentExtensions::TermHash::hash): Deleted.
(WebCore::ContentExtensions::TermHash::equal): Deleted.
(WebCore::ContentExtensions::GraphBuilder::GraphBuilder): Deleted.
(WebCore::ContentExtensions::GraphBuilder::finalize): Deleted.
(WebCore::ContentExtensions::GraphBuilder::assertionBOL): Deleted.
- contentextensions/URLFilterParser.h:
Tools:
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::testPatternStatus):
- 3:58 PM Changeset in webkit [182210] by
-
- 1 copy in tags/Safari-600.5.17
New tag.
- 3:45 PM Changeset in webkit [182209] by
-
- 8 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r182200.
https://bugs.webkit.org/show_bug.cgi?id=143279
Probably causing assertion extravaganza on bots. (Requested by
kling on #webkit).
Reverted changeset:
"Logically empty WeakBlocks should not pin down their
MarkedBlocks indefinitely."
https://bugs.webkit.org/show_bug.cgi?id=143210
http://trac.webkit.org/changeset/182200
- 3:15 PM Changeset in webkit [182208] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merged r182204. rdar://problem/20371107
- 2:34 PM Changeset in webkit [182207] by
-
- 47 edits1 move in trunk/Source
Move ExpansionBehaviorFlags and TextDirection to their own file
https://bugs.webkit.org/show_bug.cgi?id=143273
Reviewed by Simon Fraser.
This is a mechanical change. It just moves code around.
This is getting ready for https://bugs.webkit.org/show_bug.cgi?id=142608
Source/WebCore:
No new tests because there is no behavior change.
- Modules/notifications/Notification.h:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSPrimitiveValueMappings.h:
- css/CSSProperty.h:
- dom/Position.h:
- editing/VisiblePosition.h:
- editing/VisibleUnits.h:
- editing/htmlediting.h:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/canvas/CanvasRenderingContext2D.h:
- platform/LengthBox.h:
- platform/PopupMenuStyle.h:
- platform/graphics/FontCascade.h:
- platform/graphics/LayoutBoxExtent.h:
- platform/graphics/TextRun.h:
- platform/ios/SelectionRect.h:
- platform/text/BidiResolver.h:
- platform/text/StringWithDirection.h:
- platform/text/TextHelpers.h: Renamed from Source/WebCore/platform/text/TextDirection.h.
(WebCore::isLeftToRightDirection):
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::paint):
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
- rendering/HitTestLocation.h:
- rendering/HitTestResult.h:
- rendering/InlineBox.h:
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::expansionBehavior):
- rendering/RenderBlock.cpp:
(WebCore::constructTextRunInternal):
(WebCore::RenderBlock::constructTextRun):
- rendering/RenderBlock.h:
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/RenderMenuList.cpp:
(RenderMenuList::updateOptionsWidth):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::getAverageCharWidth):
- rendering/RenderThemeIOS.mm:
- rendering/style/RenderStyle.h:
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun):
- rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::constructTextRun):
Source/WebKit/ios:
- WebCoreSupport/WebFrameIOS.mm:
- WebCoreSupport/WebVisiblePosition.mm:
Source/WebKit2:
- Shared/WebPopupItem.h:
- UIProcess/API/C/efl/WKAPICastEfl.h:
- UIProcess/API/efl/EwkView.h:
- UIProcess/WebPopupMenuProxy.h:
- UIProcess/efl/WebUIPopupMenuClient.h:
- 2:34 PM Changeset in webkit [182206] by
-
- 2 deletes in trunk/Source/WebInspectorUI/WebInspectorUI.esproj
Remove user project file left in tree by accident.
- WebInspectorUI.esproj/Project.espressostorage: Removed.
- WebInspectorUI.esproj/user.jonowells.espressostorage: Removed.
- 2:25 PM Changeset in webkit [182205] by
-
- 119 edits in trunk
Clean up Identifier factories to clarify the meaning of StringImpl*
https://bugs.webkit.org/show_bug.cgi?id=143146
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
In the a lot of places,
Identifier(VM*/ExecState*, StringImpl*)
constructor is used.
However, it's ambiguous becauseStringImpl*
has 2 different meanings.
1) normal string, it is replacable withWTFString
and
2)uid
, which holdsisSymbol
information to represent Symbols.
So we dropped Identifier constructors for strings and instead, introduced 2 factory functions.
+Identifier::fromString(VM*/ExecState*, const String&)
.
Just construct Identifier from strings. The symbol-ness of StringImpl* is not kept.
+Identifier::fromUid(VM*/ExecState*, StringImpl*)
.
This function is used for 2)uid
. So symbol-ness ofStringImpl*
is kept.
And to clean up
StringImpl
which is used as uid,
we introduceStringKind
intoStringImpl
. There's 3 kinds
- StringNormal (non-atomic, non-symbol)
- StringAtomic (atomic, non-symbol)
- StringSymbol (non-atomic, symbol)
They are mutually exclusive. And (atomic, symbol) case should not exist.
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject<Parent>::getOwnNonIndexPropertyNames):
- API/JSObjectRef.cpp:
(JSObjectMakeFunction):
- API/OpaqueJSString.cpp:
(OpaqueJSString::identifier):
- bindings/ScriptFunctionCall.cpp:
(Deprecated::ScriptFunctionCall::call):
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createExecutableInternal):
- builtins/BuiltinNames.h:
(JSC::BuiltinNames::BuiltinNames):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitThrowTypeError):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):
(JSC::BytecodeGenerator::emitEnumeration):
- dfg/DFGDesiredIdentifiers.cpp:
(JSC::DFG::DesiredIdentifiers::reallyAdd):
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::functionDetails):
(Inspector::constructInternalProperty):
(Inspector::JSInjectedScriptHost::weakMapEntries):
(Inspector::JSInjectedScriptHost::iteratorEntries):
- inspector/JSInjectedScriptHostPrototype.cpp:
(Inspector::JSInjectedScriptHostPrototype::finishCreation):
- inspector/JSJavaScriptCallFramePrototype.cpp:
- inspector/ScriptCallStackFactory.cpp:
(Inspector::extractSourceInformationFromException):
- jit/JITOperations.cpp:
- jsc.cpp:
(GlobalObject::finishCreation):
(GlobalObject::addFunction):
(GlobalObject::addConstructableFunction):
(functionRun):
(runWithScripts):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LowLevelInterpreter.asm:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::addVar):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::createBindingPattern):
- parser/ParserArena.h:
(JSC::IdentifierArena::makeIdentifier):
(JSC::IdentifierArena::makeIdentifierLCharFromUChar):
(JSC::IdentifierArena::makeNumericIdentifier):
- runtime/ArgumentsIteratorPrototype.cpp:
(JSC::ArgumentsIteratorPrototype::finishCreation):
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
(JSC::arrayProtoFuncPush):
- runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::getOwnPropertySlot):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
- runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::hasErrorInfo):
- runtime/ExceptionHelpers.cpp:
(JSC::createUndefinedVariableError):
- runtime/GenericArgumentsInlines.h:
(JSC::GenericArguments<Type>::getOwnPropertySlot):
- runtime/Identifier.h:
(JSC::Identifier::isSymbol):
(JSC::Identifier::Identifier):
(JSC::Identifier::from): Deleted.
- runtime/IdentifierInlines.h:
(JSC::Identifier::Identifier):
(JSC::Identifier::fromUid):
(JSC::Identifier::fromString):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::dumpInContextAssumingStructure):
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::toPropertyKey):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSLexicalEnvironment.cpp:
(JSC::JSLexicalEnvironment::getOwnNonIndexPropertyNames):
- runtime/JSObject.cpp:
(JSC::getClassPropertyNames):
(JSC::JSObject::reifyStaticFunctionsForDelete):
- runtime/JSObject.h:
(JSC::makeIdentifier):
- runtime/JSPromiseConstructor.cpp:
(JSC::JSPromiseConstructorFuncRace):
(JSC::JSPromiseConstructorFuncAll):
- runtime/JSString.h:
(JSC::JSString::toIdentifier):
- runtime/JSSymbolTableObject.cpp:
(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):
- runtime/LiteralParser.cpp:
(JSC::LiteralParser<CharType>::tryJSONPParse):
(JSC::LiteralParser<CharType>::makeIdentifier):
- runtime/Lookup.h:
(JSC::reifyStaticProperties):
- runtime/MapConstructor.cpp:
(JSC::constructMap):
- runtime/MapIteratorPrototype.cpp:
(JSC::MapIteratorPrototype::finishCreation):
- runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
- runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::finishCreation):
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
- runtime/PrivateName.h:
(JSC::PrivateName::PrivateName):
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::find):
(JSC::PropertyTable::get):
- runtime/PropertyName.h:
(JSC::PropertyName::PropertyName):
(JSC::PropertyName::publicName):
(JSC::PropertyName::asIndex):
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::addKnownUnique):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::finishCreation):
- runtime/SetConstructor.cpp:
(JSC::constructSet):
- runtime/SetIteratorPrototype.cpp:
(JSC::SetIteratorPrototype::finishCreation):
- runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):
- runtime/StringIteratorPrototype.cpp:
(JSC::StringIteratorPrototype::finishCreation):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
- runtime/Structure.cpp:
(JSC::Structure::getPropertyNamesFromStructure):
- runtime/SymbolConstructor.cpp:
- runtime/VM.cpp:
(JSC::VM::throwException):
- runtime/WeakMapConstructor.cpp:
(JSC::constructWeakMap):
Source/WebCore:
Just change Identifier creations.
- If the code creates Identifier from StringImpl*
which is treated as symbol or string(unique id), use Identifier::fromUid.
- If the code creates Identifier from string, use Identifier::fromString.
- Modules/plugins/QuickTimePluginReplacement.mm:
(WebCore::QuickTimePluginReplacement::ensureReplacementScriptInjected):
(WebCore::QuickTimePluginReplacement::installReplacement):
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::get):
(WebCore::set):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getOwnPropertyNames):
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSCommandLineAPIHostCustom.cpp:
(WebCore::getJSListenerFunctions):
(WebCore::JSCommandLineAPIHost::getEventListeners):
- bindings/js/JSCryptoAlgorithmBuilder.cpp:
(WebCore::JSCryptoAlgorithmBuilder::add):
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::getProperty):
(WebCore::getHashAlgorithm):
- bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::getJSArrayFromJSON):
(WebCore::getStringFromJSON):
(WebCore::getBooleanFromJSON):
(WebCore::addToJSON):
(WebCore::buildJSONForRSAComponents):
(WebCore::addBoolToJSON):
(WebCore::addUsagesToJSON):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::getOwnPropertyNames):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::defineOwnProperty):
(WebCore::JSDOMWindow::setLocation):
(WebCore::DialogHandler::dialogCreated):
(WebCore::DialogHandler::returnValue):
- bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::readAccelerationArgument):
(WebCore::readRotationRateArgument):
(WebCore::createAccelerationObject):
(WebCore::createRotationRateObject):
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::tryGetProperty):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::all):
(WebCore::JSHTMLDocument::setAll):
(WebCore::JSHTMLDocument::open):
- bindings/js/JSHTMLFormControlsCollectionCustom.cpp:
(WebCore::JSHTMLFormControlsCollection::namedItem):
- bindings/js/JSIDBDatabaseCustom.cpp:
(WebCore::JSIDBDatabase::createObjectStore):
- bindings/js/JSIDBObjectStoreCustom.cpp:
(WebCore::JSIDBObjectStore::createIndex):
- bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
- bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::populateContextMenuItems):
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
- bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
- bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::getOwnPropertyNames):
- bindings/js/ReadableStreamJSSource.cpp:
(WebCore::setInternalSlotToObject):
(WebCore::getInternalSlotFromObject):
- bindings/js/ScriptGlobalObject.cpp:
(WebCore::ScriptGlobalObject::set):
(WebCore::ScriptGlobalObject::get):
(WebCore::ScriptGlobalObject::remove):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::deserialize):
- bindings/objc/WebScriptObject.mm:
(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):
(-[WebScriptObject hasWebScriptKey:]):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64Array::getOwnPropertyNames):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertyNames):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjReplaceableAttribute):
- bridge/c/c_utility.cpp:
(JSC::Bindings::identifierFromNPIdentifier):
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
- bridge/testbindings.cpp:
(main):
- bridge/testbindings.mm:
(main):
- contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::loadTrigger):
(WebCore::ContentExtensions::loadAction):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::injectInternalsObject):
Source/WebKit/mac:
Just change to Identifier::fromString.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(identifierFromIdentifierRep):
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::getPropertyNames):
Source/WebKit2:
Just change to Identifier::fromString.
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getOwnPropertyNames):
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::identifierFromIdentifierRep):
Source/WTF:
Introduce StringKind into
StringImpl
. There's 3 kinds
- StringNormal (non-atomic, non-symbol)
- StringAtomic (atomic, non-symbol)
- StringSymbol (non-atomic, symbol)
They are mutually exclusive.
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::addSlowCase):
(WTF::AtomicString::findSlowCase):
When registering a string into AtomicStringTable,
it should not be a symbol string
because symbol and atomic types are mutually exclusive.
When a symbol string comes, we extract an owner string
from a symbol string by usingStringImpl::extractFoldedStringInSymbol()
.
It always succeeds because a symbol (non empty) string
is always BufferSubstring and has an owner string.
Empty symbol string doesn't have an owner string.
This case is filtered by!string.length()
guard.
- wtf/text/AtomicString.h:
(WTF::AtomicString::add):
(WTF::AtomicString::addWithStringTableProvider):
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::createSymbol):
(WTF::StringImpl::createUnique): Deleted.
- wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::createSymbolEmpty):
(WTF::StringImpl::flagIsAtomic):
(WTF::StringImpl::flagIsSymbol):
(WTF::StringImpl::maskStringKind):
(WTF::StringImpl::stringKind):
(WTF::StringImpl::isSymbol):
(WTF::StringImpl::isAtomic):
(WTF::StringImpl::setIsAtomic):
(WTF::StringImpl::extractFoldedStringInSymbol):
(WTF::StringImpl::createUniqueEmpty): Deleted.
(WTF::StringImpl::flagIsUnique): Deleted.
(WTF::StringImpl::isUnique): Deleted.
- wtf/text/StringStatics.cpp:
(WTF::StringImpl::hashAndFlagsForSymbol):
(WTF::StringImpl::hashAndFlagsForUnique): Deleted.
Tools:
Simple API tests for StringImpl are added.
- TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
- 2:18 PM Changeset in webkit [182204] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Songza.com fails to play; QTKit path reports it is always "seeking".
https://bugs.webkit.org/show_bug.cgi?id=143274
Rubber-stamped by Eric Carlson.
MediaTime::invalidTime() is always greater than any valid time. So when
checking to see if MediaPlayerPrivateQTKit is seeking, first check if the
m_seekTo time is valid before checking whether it's > 0.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::seeking):
- 1:53 PM Changeset in webkit [182203] by
-
- 16 edits in trunk/Source/WebKit2
WebKit briefly shows wrong webpage after swiping back (gigaom.com, or any site on a slow network)
https://bugs.webkit.org/show_bug.cgi?id=143256
<rdar://problem/19458648>
Reviewed by Dan Bernstein.
Instead of allowing a flash of the previous page when the swipe snapshot
timeouts fire (removing the snapshot before the new page is loaded), show
the snapshotted background color.
This fixes the problem on iOS, where UI-side compositing makes it easy to fix,
but not yet on OS X.
- UIProcess/API/Cocoa/WKWebView.mm:
(baseScrollViewBackgroundColor):
(scrollViewBackgroundColor):
If the ViewGestureController returns a valid background color, use that
instead of the page's background color.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
Expose _updateScrollViewBackground.
- UIProcess/PageClient.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didChangeBackgroundColor):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didChangeBackgroundColor):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackgroundColor):
- UIProcess/WebPageProxy.h:
Add and plumb didChangeBackgroundColor, which calls
_updateScrollViewBackground on iOS.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::endSwipeGesture):
Hide the content of the drawing area until the next commit. This way,
even if the snapshot is removed (say, because a timeout fired), we won't
ever show the old page content (but we will show background color).
Store the background color associated with the current snapshot.
Let WKWebView know that it needs to recompute the background color.
(WebKit::ViewGestureController::removeSwipeSnapshot):
Clear the background color so that the next time we commit, WKWebView
will get an invalid color from ViewGestureController and fall back
to the page's extended background color instead.
- UIProcess/mac/ViewGestureController.h:
(WebKit::ViewGestureController::backgroundColorForCurrentSnapshot):
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::removeSwipeSnapshot):
Keep backgroundColorForCurrentSnapshot up to date on Mac too, even
though we don't use it yet.
- 1:50 PM Changeset in webkit [182202] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Rotating PDF in Safari scrolls to the wrong position
https://bugs.webkit.org/show_bug.cgi?id=143259
<rdar://problem/19872693>
Reviewed by Dan Bernstein.
- UIProcess/ios/WKPDFView.mm:
(-[WKPDFView web_setMinimumSize:]):
Maintan the relative top/left within the rescaled document.
- 1:37 PM Changeset in webkit [182201] by
-
- 2 edits in trunk/LayoutTests
accessibility/aria-hidden-hides-all-elements.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=143275
Mark as Pass/Fail.
- platform/win/TestExpectations:
- 1:01 PM Changeset in webkit [182200] by
-
- 8 edits in trunk/Source/JavaScriptCore
Logically empty WeakBlocks should not pin down their MarkedBlocks indefinitely.
<https://webkit.org/b/143210>
Reviewed by Geoffrey Garen.
Since a MarkedBlock cannot be destroyed until all the WeakBlocks pointing into it are gone,
we had a little problem where WeakBlocks with only null pointers would still keep their
MarkedBlock alive.
This patch fixes that by detaching WeakBlocks from their MarkedBlock once a sweep discovers
that the WeakBlock contains no pointers to live objects. Ownership of the WeakBlock is passed
to the Heap, which will sweep the list of these detached WeakBlocks as part of a full GC,
destroying them once they're fully dead.
This allows the garbage collector to reclaim the 64kB MarkedBlocks much sooner, and resolves
a mysterious issue where doing two full garbage collections back-to-back would free additional
memory in the second collection.
Management of detached WeakBlocks is implemented as a Vector<WeakBlock*> in Heap, along with
an index of the next block in that vector that needs to be swept. The IncrementalSweeper then
calls into Heap::sweepNextLogicallyEmptyWeakBlock() to sweep one block at a time.
- heap/Heap.h:
- heap/Heap.cpp:
(JSC::Heap::collectAllGarbage): Add a final pass where we sweep the logically empty WeakBlocks
owned by Heap, after everything else has been swept.
(JSC::Heap::notifyIncrementalSweeper): Set up an incremental sweep of logically empty WeakBlocks
after a full garbage collection ends. Note that we don't do this after Eden collections, since
they are unlikely to cause entire WeakBlocks to go empty.
(JSC::Heap::addLogicallyEmptyWeakBlock): Added. Interface for passing ownership of a WeakBlock
to the Heap when it's detached from a WeakSet.
(JSC::Heap::sweepAllLogicallyEmptyWeakBlocks): Helper for collectAllGarbage() that sweeps all
of the logically empty WeakBlocks owned by Heap.
(JSC::Heap::sweepNextLogicallyEmptyWeakBlock): Sweeps one logically empty WeakBlock if needed
and updates the next-logically-empty-weak-block-to-sweep index.
(JSC::Heap::lastChanceToFinalize): call sweepAllLogicallyEmptyWeakBlocks() here, since there
won't be another chance after this.
- heap/IncrementalSweeper.h:
(JSC::IncrementalSweeper::hasWork): Deleted.
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::fullSweep):
(JSC::IncrementalSweeper::doSweep):
(JSC::IncrementalSweeper::sweepNextBlock): Restructured IncrementalSweeper a bit to simplify
adding a new sweeping stage for the Heap's logically empty WeakBlocks. sweepNextBlock() is
changed to return a bool (true if there's more work to be done.)
- heap/WeakBlock.cpp:
(JSC::WeakBlock::sweep): This now figures out if the WeakBlock is logically empty, i.e doesn't
contain any pointers to live objects. The answer is stored in a new SweepResult member.
- heap/WeakBlock.h:
(JSC::WeakBlock::isLogicallyEmptyButNotFree): Added. Can be queried after a sweep to determine
if the WeakBlock could be detached from the MarkedBlock.
(JSC::WeakBlock::SweepResult::SweepResult): Deleted in favor of initializing member variables
when declaring them.
- 12:43 PM Changeset in webkit [182199] by
-
- 4 edits in trunk/Websites/perf.webkit.org
REGRESSION: Searching commits can highlight wrong data points
https://bugs.webkit.org/show_bug.cgi?id=143272
Reviewed by Antti Koivisto.
The bug was caused by /api/commits returning commit times with millisecond precision whereas /api/runs
return commit times with only second precision. This resulted in the frontend code to match a commit
with the data point that included the next commit when the millisecond component of commit's timestamp
wasn't identically 0.
This discrepancy was caused by the fact PHP's strtotime only ignores milliseconds and /api/commits
was returning timestamp as string instead of parsing via Database::to_js_time as done in /api/runs
so miliseconds component was only preserved in /api/commits.
Fixed the bug by always using Database::to_js_time to return commit time. Also fixed to_js_time so that
it returns time in milisecond precision.
- public/api/commits.php:
(fetch_commits_between): Use Database::to_js_time for format commit times.
(format_commit): Ditto.
- public/include/db.php:
(Database::to_js_time): Parse and append millisecond component. Ignore sub-milliseconds for simplicity.
- public/v2/data.js:
(CommitLogs.fetchForTimeRange): The commit time is now an integer so don't call "replace" on it.
- 12:42 PM Changeset in webkit [182198] by
-
- 19 edits2 adds in trunk/Source/JavaScriptCore
eval("this.foo") causes a crash if this had not been initialized in a derived class's constructor
https://bugs.webkit.org/show_bug.cgi?id=142883
Reviewed by Filip Pizlo.
The crash was caused by eval inside the constructor of a derived class not checking TDZ.
Fixed the bug by adding a parser flag that forces the TDZ check to be always emitted when accessing "this"
in eval inside a derived class' constructor.
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::getSlow):
- bytecompiler/NodesCodegen.cpp:
(JSC::ThisNode::emitBytecode):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
- interpreter/Interpreter.cpp:
(JSC::eval):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::thisExpr):
- parser/NodeConstructors.h:
(JSC::ThisNode::ThisNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parsePrimaryExpression):
- parser/Parser.h:
(JSC::parse):
- parser/ParserModes.h:
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::thisExpr):
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
- runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey):
- runtime/Executable.cpp:
(JSC::EvalExecutable::create):
- runtime/Executable.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::createEvalCodeBlock):
- runtime/JSGlobalObject.h:
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
- tests/stress/class-syntax-no-tdz-in-eval.js: Added.
- tests/stress/class-syntax-tdz-in-eval.js: Added.
- 12:32 PM Changeset in webkit [182197] by
-
- 8 edits7 adds in trunk
border-image with 'fill' keyword does not fill the middle area unless the border width is greater than zero.
https://bugs.webkit.org/show_bug.cgi?id=142650.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-03-31
Reviewed by Simon Fraser.
Source/WebCore:
The decoration of a RenderBox, a RenderTable or an InlineFlowBox should be
drawn if its RenderStyle has a non-zero width border or the border-image
has the keyword fill.
Tests: fast/borders/border-image-fill-inline-no-border.html
fast/borders/border-image-fill-no-border.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::hasBoxDecorationStyle):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations):
- rendering/style/BorderData.h:
(WebCore::BorderData::hasFill):
- rendering/style/RenderStyle.h:
LayoutTests:
Add tests to ensure the middle area of a RenderBox is going to be drawn
even if the border width is not greater than zero.
- fast/borders/border-image-fill-inline-no-border-expected.html: Added.
- fast/borders/border-image-fill-inline-no-border.html: Added.
- fast/borders/border-image-fill-no-border-expected.html: Added.
- fast/borders/border-image-fill-no-border.html: Added.
- fast/borders/resources/button-border-cropped.svg: Added.
- fast/borders/resources/button-border.svg: Added.
- fast/borders/resources/svg-100x100-intrinsic.svg: Added.
- 12:25 PM Changeset in webkit [182196] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed build fix.
- WebCore.vcxproj/WebCore.vcxproj:
Don't include inspector files twice in debug builds.
InspectorAllInOne.cpp is now used on debug builds.
- 12:14 PM Changeset in webkit [182195] by
-
- 3 edits4 adds in trunk
[New Block-Inside-Inline Model] Anonymous inline-blocks should size as though they are block-level.
https://bugs.webkit.org/show_bug.cgi?id=143271
Reviewed by Dean Jackson.
Source/WebCore:
Added fast/block/inside-inlines/block-width-check.html.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
Return false when an anonymous inline-block is encountered, since we want to treat it like a regular
block instead.
LayoutTests:
- fast/block/inside-inlines/block-width-check-expected.html: Added.
- fast/block/inside-inlines/block-width-check.html: Added.
- fast/block/inside-inlines/new-model/block-width-check-expected.html: Added.
- fast/block/inside-inlines/new-model/block-width-check.html: Added.
- 12:03 PM Changeset in webkit [182194] by
-
- 14 edits1 add in trunk/Source/WebKit2
[WK2][iOS] Extend ProcessThrottler use to the NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=143249
<rdar://problem/20231539>
Reviewed by Gavin Barraclough.
Extend ProcessThrottler use to the NetworkProcess instead of only the
WebProcesses. This is needed so that the NetworkProcess gets notified
before suspension. We now use this notification to free-up memory
before suspending by calling the critical memory pressure handler, as
we already do for WebProcesses (rdar://problem/20231539). In the
future, this infrastructure will be used to delay suspension until the
pending SQL transactions are done as well (rdar://problem/20180799).
Previously, the NetworkProcessProxy would hold a foreground assertion
on behalf of the NetworkProcess but would never release that assertion.
In this patch, we change this so that WebProcessProxies hold assertions
on behalf of the NetworkProcess, and release those assertions before
suspending. As a result, the NetworkProcess gets suspended when all
WebProcesses are suspended.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processWillSuspend):
(WebKit::NetworkProcess::cancelProcessWillSuspend):
(WebKit::NetworkProcess::processDidResume):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::didFinishLaunching):
(WebKit::NetworkProcessProxy::sendProcessWillSuspend):
(WebKit::NetworkProcessProxy::sendCancelProcessWillSuspend):
(WebKit::NetworkProcessProxy::didCancelProcessSuspension):
(WebKit::NetworkProcessProxy::sendProcessDidResume):
(WebKit::NetworkProcessProxy::processReadyToSuspend):
- UIProcess/Network/NetworkProcessProxy.h:
(WebKit::NetworkProcessProxy::throttler):
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::ProcessThrottler):
(WebKit::ProcessThrottler::didConnectToProcess):
(WebKit::ProcessThrottler::didConnnectToProcess): Deleted.
- UIProcess/ProcessThrottler.h:
- UIProcess/ProcessThrottlerClient.h: Added.
(WebKit::ProcessThrottlerClient::~ProcessThrottlerClient):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didFinishLaunching):
(WebKit::WebProcessProxy::initializeNetworkProcessActivityToken):
(WebKit::WebProcessProxy::sendProcessDidResume):
(WebKit::WebProcessProxy::processReadyToSuspend):
- UIProcess/WebProcessProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- 12:01 PM Changeset in webkit [182193] by
-
- 27 edits13 deletes in trunk/Source
Unreviewed, rolling out r182186.
https://bugs.webkit.org/show_bug.cgi?id=143270
it crashes all the WebGL tests on the Debug bots (Requested by
dino on #webkit).
Reverted changeset:
"Web Inspector: add 2D/WebGL canvas instrumentation
infrastructure"
https://bugs.webkit.org/show_bug.cgi?id=137278
http://trac.webkit.org/changeset/182186
- 11:53 AM Changeset in webkit [182192] by
-
- 3 edits in trunk/Source/WebCore
Crash in CGContextShowGlyphsWithAdvances when passing kCGFontIndexInvalid
https://bugs.webkit.org/show_bug.cgi?id=143114
This is a workaround for <rdar://problem/20230073>. Please remove when it is no longer necessary.
Reviewed by Alexey Proskuryakov.
Covered by:
compositing/regions/floated-region-with-transformed-child.html
compositing/regions/floated-region-with-transformed-child-expected.html
fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html
fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html
fast/regions/overflow/overflow-content-transform-rotate.html
fast/regions/overflow/overflow-content-transform-rotate-expected.html
- platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::shrink): Performing shaping may remove glyphs, so we need to shrink the GlyphBuffer.
- platform/graphics/WidthIterator.cpp:
(WebCore::applyFontTransforms): Filter out kCGFontIndexInvalid.
(WebCore::WidthIterator::advanceInternal): Moved code into applyFontTransforms, and trigger the
shrink of the GlyphBuffer.
- 11:26 AM Changeset in webkit [182191] by
-
- 3 edits4 adds in trunk
REGRESSION (r173484): Reducing content of scrollable region does not reset scroll
position
https://bugs.webkit.org/show_bug.cgi?id=138525
-and corresponding-
rdar://problem/18166043
Reviewed by Simon Fraser.
Source/WebCore:
The change that caused this regression was correct. That change does not allow
RenderLayer to update scroll position after a layout if a rubber-band is currently
happening. The change caused this regression because all of the member variables
in ScrollController that attempt to keep track of the current state of the scroll
gesture (m_inScrollGesture, m_momentumScrollInProgress, and
m_snapRubberbandTimerIsActive) all indicated that a momentum scroll gesture was
still in action for this div even though it very much is not when the bug happens.
Those variables were never properly re-set because the
PlatformWheelEventPhaseEnded events never got dispatched to the ScrollController,
which brought the investigation back to Element.
We must still dispatch events that have zero delta so that the default event
handlers can handle them, but we should stopPropagation() so that these events are
not sent to the DOM. Websites will break if they get wheel events with no delta.
- dom/Element.cpp:
(WebCore::Element::dispatchWheelEvent):
LayoutTests:
- platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-reduced-content-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-reduced-content.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-zero-delta-wheel-events-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-zero-delta-wheel-events.html: Added.
- 11:22 AM Changeset in webkit [182190] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed debug build fix after r182186.
- WebCore.vcxproj/WebCore.vcxproj:
Include InspectorAllInOne.cpp in debug builds.
- 10:44 AM Changeset in webkit [182189] by
-
- 8 edits10 adds in trunk
[ES6] Object type restrictions on a first parameter of several Object.* functions are relaxed
https://bugs.webkit.org/show_bug.cgi?id=142937
Reviewed by Darin Adler.
Source/JavaScriptCore:
In ES6, Object type restrictions on a first parameter of several Object.* functions are relaxed.
In ES5 or prior, when a first parameter is not object type, these functions raise TypeError.
But now, several functions perform ToObject onto a non-object parameter.
And others behaves as if a parameter is a non-extensible ordinary object with no own properties.
It is described in ES6 Annex E.
Functions different from ES5 are following.
- An attempt is make to coerce the argument using ToObject.
Object.getOwnPropertyDescriptor
Object.getOwnPropertyNames
Object.getPrototypeOf
Object.keys
- Treated as if it was a non-extensible ordinary object with no own properties.
Object.freeze
Object.isExtensible
Object.isFrozen
Object.isSealed
Object.preventExtensions
Object.seal
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructorGetPrototypeOfFunctor::operator()):
(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
(JSC::objectConstructorIsExtensible):
- tests/stress/object-freeze-accept-non-object.js: Added.
- tests/stress/object-get-own-property-descriptor-perform-to-object.js: Added.
(canary):
- tests/stress/object-get-own-property-names-perform-to-object.js: Added.
(compare):
- tests/stress/object-get-prototype-of-perform-to-object.js: Added.
- tests/stress/object-is-extensible-accept-non-object.js: Added.
- tests/stress/object-is-frozen-accept-non-object.js: Added.
- tests/stress/object-is-sealed-accept-non-object.js: Added.
- tests/stress/object-keys-perform-to-object.js: Added.
(compare):
- tests/stress/object-prevent-extensions-accept-non-object.js: Added.
- tests/stress/object-seal-accept-non-object.js: Added.
LayoutTests:
Several LayoutTests are updated with the new behavior.
Test cases in IETestCenter contain test for the outdated behavior.
But IETestCenter is brought from the external source, so instead of modifying it,
we mark them as Failure in TestExpectations.
- TestExpectations:
- js/dom/getOwnPropertyDescriptor-expected.txt:
- js/prototypes-expected.txt:
- js/resources/getOwnPropertyDescriptor.js:
- js/script-tests/prototypes.js:
- 10:42 AM Changeset in webkit [182188] by
-
- 8 edits4 adds in trunk
[New Block-Inside-Inline Model] Make sure line breaks occur before and after the anonymous inline-block.
https://bugs.webkit.org/show_bug.cgi?id=143238.
Reviewed by Dean Jackson.
Source/WebCore:
Added fast/blocks/inside-inlines/breaking-behavior.html (and new-model equivalent).
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::hasAnonymousInlineBlock):
(WebCore::InlineFlowBox::setHasAnonymousInlineBlock):
Add a bit to root line boxes (stored in the InlineFlowBox since it has free bits) that indicates whether
or not a line is an anonymous inline-block line.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths):
Patch the preferred logical width computation to break both before and after an anonymous inline-block.
Also make sure to strip trailing spaces from the line before the anonymous inline-block.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::constructLine):
Patch line construction so that no intermediate boxes are constructed between the InlineBox for the anonymous
inline-block and the root line box.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::ascentAndDescentForBox):
The height of a "line" that holds an anonymous inline-block should ignore line-box-contain and also make sure
that the margins of the replaced element are "outside" the line, since those margins will collapse.
- rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleReplaced):
Patch handleReplaced to make sure breaks occur both before and after an anonymous inline-block. In the case of
a break after the block, we setPreviousLineBrokeCleanly to true so that <br>s that follow the anonymous inline-block
are respected.
LayoutTests:
- fast/block/inside-inlines/breaking-behavior-expected.html: Added.
- fast/block/inside-inlines/breaking-behavior.html: Added.
- fast/block/inside-inlines/new-model/breaking-behavior-expected.html: Added.
- fast/block/inside-inlines/new-model/breaking-behavior.html: Added.
- fast/block/inside-inlines/new-model/empty-block.html:
- 10:32 AM Changeset in webkit [182187] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Add nullptr check to GraphicsContext3D::makeContextCurrent()
https://bugs.webkit.org/show_bug.cgi?id=143214
Reviewed by Žan Doberšek.
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::makeContextCurrent):
- 10:23 AM Changeset in webkit [182186] by
-
- 27 edits13 adds in trunk/Source
Web Inspector: add 2D/WebGL canvas instrumentation infrastructure
https://bugs.webkit.org/show_bug.cgi?id=137278
Patch by Matt Baker <Matt Baker> on 2015-03-31
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Added Canvas protocol which defines types used by InspectorCanvasAgent.
- CMakeLists.txt:
- DerivedSources.make:
- inspector/protocol/Canvas.json: Added.
- inspector/scripts/codegen/generator.py:
(Generator.stylized_name_for_enum_value):
Added special handling for 2D (always uppercase) and WebGL (rename mapping) enum strings.
Source/WebCore:
Added backend agent for canvas inspection. A canvas is instrumented once its CanvasRenderingContext has been
created. WebGLRenderingContext is instrumented to track the lifetime of shader program objects.
To instrument off-screen rendering contexts (CSS canvases and detached canvas elements), the canvas agent must
track all CanvasRenderingContexts as they are created, even in the absense of the frontend. As far as I know,
there is no practical way to identify rendering contexts belonging to a frame that are not in the DOM. In the
absence of the inspector frontend the agent does only the minimum required to track the lifetime of rendering
contexts and their resources, to avoid creating a negative performance impact.
Tests: inspector/canvas/canvas-add-remove-events.html
inspector/canvas/canvas-context-attributes.html
inspector/canvas/canvas-css-name.html
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::getCSSCanvasElement):
Instrumentation for CSS canvases.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
Instrumentation for context creation.
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::attachShader):
(WebCore::WebGLRenderingContextBase::createProgram):
(WebCore::WebGLRenderingContextBase::deleteProgram):
(WebCore::WebGLRenderingContextBase::detachShader):
Instrumentation for programs and shaders.
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorCanvasAgent.cpp: Added.
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCanvasAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::didCreateCSSCanvas):
(WebCore::InspectorCanvasAgent::didCreateCanvasRenderingContext):
(WebCore::InspectorCanvasAgent::didAttachShader):
(WebCore::InspectorCanvasAgent::didDetachShader):
(WebCore::InspectorCanvasAgent::didCreateProgram):
(WebCore::InspectorCanvasAgent::didDeleteProgram):
(WebCore::InspectorCanvasAgent::getCanvases):
(WebCore::InspectorCanvasAgent::canvasDestroyed):
(WebCore::InspectorCanvasAgent::canvasDestroyedTimerFired):
(WebCore::InspectorCanvasAgent::reset):
(WebCore::InspectorCanvasAgent::getCanvasEntry):
(WebCore::InspectorCanvasAgent::getProgramEntry):
(WebCore::InspectorCanvasAgent::removeShaderFromShaderMap):
(WebCore::InspectorCanvasAgent::contextTypeJson):
(WebCore::InspectorCanvasAgent::buildObjectForCanvas):
- inspector/InspectorCanvasAgent.h: Added.
New backend agent.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
Support for new backend agent.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didCreateCSSCanvasImpl):
(WebCore::InspectorInstrumentation::didCreateCanvasRenderingContextImpl):
(WebCore::InspectorInstrumentation::didAttachShaderImpl):
(WebCore::InspectorInstrumentation::didDetachShaderImpl):
(WebCore::InspectorInstrumentation::didCreateProgramImpl):
(WebCore::InspectorInstrumentation::didDeleteProgramImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForRenderingContext):
Plumbing for canvas instrumentation.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didCreateCSSCanvas):
(WebCore::InspectorInstrumentation::didCreateCanvasRenderingContext):
(WebCore::InspectorInstrumentation::didAttachShader):
(WebCore::InspectorInstrumentation::didDetachShader):
(WebCore::InspectorInstrumentation::didCreateProgram):
(WebCore::InspectorInstrumentation::didDeleteProgram):
- inspector/InstrumentingAgents.cpp:
(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::reset):
- inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::inspectorCanvasAgent):
(WebCore::InstrumentingAgents::setInspectorCanvasAgent):
Support for new backend agent.
Source/WebInspectorUI:
Added models, views, and controller classes for 2D and WebGL canvas inspection. Each canvas is shown in the
Resources navigation sidebar under its parent frame. Shader programs are displayed as child nodes of
their respective canvas. Canvases will get an associated content view and details sidebar in a later patch
(see https://bugs.webkit.org/show_bug.cgi?id=138941).
Shader programs will get an associated content view for editing shader source in a later patch (see
https://bugs.webkit.org/show_bug.cgi?id=138593). Individual shaders are not shown in the Resource navigation
sidebar, and at this time there are no plans to instrument shaders that aren't attached to a program.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/Main.js:
(WebInspector.loaded):
(WebInspector.sidebarPanelForRepresentedObject):
- UserInterface/Base/Test.js:
(WebInspector.loaded):
- UserInterface/Main.html:
- UserInterface/Test.html:
Updated for new canvas/shader program types.
- UserInterface/Controllers/CanvasManager.js: Added.
(WebInspector.CanvasManager):
(WebInspector.CanvasManager.prototype.canvasesForFrame):
(WebInspector.CanvasManager.prototype.canvasAdded.set this):
(WebInspector.CanvasManager.prototype.canvasAdded):
(WebInspector.CanvasManager.prototype.canvasRemoved):
(WebInspector.CanvasManager.programDeleted.get console):
(WebInspector.CanvasManager.prototype.programCreated.get console):
(WebInspector.CanvasManager.prototype.programCreated):
(WebInspector.CanvasManager.prototype._mainResourceDidChange):
Frontend controller for canvases and their shader programs.
- UserInterface/Images/Canvas.svg: Added.
- UserInterface/Images/DocumentGL.png: Added.
- UserInterface/Images/DocumentGL@2x.png: Added.
New art for canvas and shader program tree elements.
- UserInterface/Models/Canvas.js: Added.
(WebInspector.Canvas):
(WebInspector.Canvas.prototype.set fromPayload):
(WebInspector.Canvas.displayNameForContextType):
(WebInspector.Canvas.resetUniqueDisplayNameNumbers):
(WebInspector.Canvas.prototype.get id):
(WebInspector.Canvas.prototype.get parentFrame):
(WebInspector.Canvas.prototype.get name):
(WebInspector.Canvas.prototype.get cssCanvas):
(WebInspector.Canvas.prototype.get contextType):
(WebInspector.Canvas.prototype.get contextAttributes):
(WebInspector.Canvas.prototype.get programs):
(WebInspector.Canvas.prototype.get displayName):
(WebInspector.Canvas.programForId):
(WebInspector.Canvas.get programWasCreated.set this):
(WebInspector.Canvas.prototype.get programWasCreated):
(WebInspector.Canvas.prototype.programWasDeleted):
(WebInspector.Canvas.prototype.saveIdentityToCookie):
Model for DOM or CSS canvas (2D or WebGL).
- UserInterface/Models/ShaderProgram.js: Added.
(WebInspector.ShaderProgram):
(WebInspector.ShaderProgram.prototype.get id):
(WebInspector.ShaderProgram.prototype.get canvas):
(WebInspector.ShaderProgram.prototype.get displayName):
(WebInspector.ShaderProgram.prototype.saveIdentityToCookie):
(WebInspector.ShaderProgram.prototype.updateCanvas):
- UserInterface/Models/WebGLContextAttributes.js: Added.
(WebInspector.WebGLContextAttributes):
(WebInspector.WebGLContextAttributes.fromPayload):
(WebInspector.WebGLContextAttributes.prototype.get alpha):
(WebInspector.WebGLContextAttributes.prototype.get depth):
(WebInspector.WebGLContextAttributes.prototype.get stencil):
(WebInspector.WebGLContextAttributes.prototype.get antialias):
(WebInspector.WebGLContextAttributes.prototype.get premultipliedAlpha):
(WebInspector.WebGLContextAttributes.prototype.get preserveDrawingBuffer):
Model for WebGL canvas context attributes.
- UserInterface/Protocol/CanvasObserver.js: Added.
(WebInspector.CanvasObserver.prototype.canvasAdded):
(WebInspector.CanvasObserver.prototype.canvasRemoved):
(WebInspector.CanvasObserver.prototype.programCreated):
(WebInspector.CanvasObserver.prototype.programDeleted):
(WebInspector.CanvasObserver):
Model for WebGL canvas shader program.
- UserInterface/Views/CanvasTreeElement.js: Added.
(WebInspector.CanvasTreeElement.validateRepresentedObject):
(WebInspector.CanvasTreeElement.countChildren):
(WebInspector.CanvasTreeElement):
(WebInspector.CanvasTreeElement.prototype.onexpand):
(WebInspector.CanvasTreeElement.prototype.oncollapse):
(WebInspector.CanvasTreeElement.prototype.onpopulate):
(WebInspector.CanvasTreeElement.prototype._programWasCreated):
(WebInspector.CanvasTreeElement.prototype._programWasDeleted):
Folderized tree element for canvases and their child objects (shader programs).
- UserInterface/Views/FrameTreeElement.js:
(WebInspector.FrameTreeElement.prototype.onattach):
(WebInspector.FrameTreeElement.prototype.ondetach):
(WebInspector.FrameTreeElement.prototype.onpopulate):
(WebInspector.FrameTreeElement.prototype._canvasesAvailable):
(WebInspector.FrameTreeElement.prototype._canvasWasAdded):
(WebInspector.FrameTreeElement.prototype._canvasWasRemoved):
Updated to support canvas tree elements.
- UserInterface/Views/ResourceIcons.css:
(.canvas-icon .icon):
(.shader-program-icon .icon):
Styles for new canvas and shader program icons.
- UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
Updated for new tree element types.
- UserInterface/Views/ShaderProgramTreeElement.js: Added.
(WebInspector.ShaderProgramTreeElement):
Tree element for shader programs. Shown as children of CanvasTreeElement.
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
- 10:17 AM Changeset in webkit [182185] by
-
- 4 edits in trunk/Websites/perf.webkit.org
Perf dashboard should show relative change in values
https://bugs.webkit.org/show_bug.cgi?id=143252
Reviewed by Antti Koivisto.
When a range of values are selected, show the percentage difference between the start and the end
in addition to the absolute value difference. When a single point is selected, show the relative
difference with respect to the previous point. Use two significant figures and always show plus sign
when the difference is positive.
- public/v2/app.js: Compute and format the relative difference.
- public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
- public/v2/index.html: Show the relative difference.
- 10:16 AM Changeset in webkit [182184] by
-
- 2 edits in trunk/Websites/perf.webkit.org
REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph
https://bugs.webkit.org/show_bug.cgi?id=143254
Reviewed by Antti Koivisto.
The bug was caused by App.Pane no longer replacing 'chartData' property when updating the moving average
or the enveloping values. Fixed the bug by creating a new chartData object when the strategy is changed
so that the interactive chart component will observe a change to 'chartData'.
- public/v2/app.js:
(App.Pane._movingAverageOrEnvelopeStrategyDidChange): Added.
- 5:35 AM Changeset in webkit [182183] by
-
- 2 edits in trunk/LayoutTests
GTK+ Gardening 30th March
https://bugs.webkit.org/show_bug.cgi?id=143220
Unreviewed.
Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-31
- platform/gtk/TestExpectations:
- 5:23 AM Changeset in webkit [182182] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, revert accidental change by r182138.
- Scripts/generate-forwarding-headers.pl:
(createForwardingHeadersForFramework):
- 3:59 AM Changeset in webkit [182181] by
-
- 1 edit1 add in trunk/LayoutTests
http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy.html failing on Mavericks wk2 debug
https://bugs.webkit.org/show_bug.cgi?id=143258
The test relies on resource priorities. Those don't roundtrip when serializing via NSURLRequest on Mavericks due
to ResourceRequest::resourcePrioritiesEnabled() returning false.
It is bit surprising it works on release but not on debug. I suspect some debug code forces NSURLRequest construction
and so we end up on the roundtrip code path.
- platform/mac-mavericks/TestExpectations: Added.
Skip the test on Mavericks.
- 3:09 AM Changeset in webkit [182180] by
-
- 20 edits3 copies3 adds in trunk
[Streams API] Implement a barebone ReadableStreamReader interface
https://bugs.webkit.org/show_bug.cgi?id=142866
Reviewed by Benjamin Poulain.
Source/WebCore:
This patch implements a barebone ReadableStreamReader as described in https://streams.spec.whatwg.org/#reader-class.
It implements the IDL without implementing most of the functionality behind.
It implements ReadableStreamReader JS constructor and the link with ReadableStream.getReader:
- Raise an error if stream is already locked
- Set the stream reader to the newly created ReadableStreamReader instance.
Test: streams/readablestreamreader-constructor.html
- CMakeLists.txt: Adding ReadableStreamReader files.
- DerivedSources.cpp: Ditto.
- DerivedSources.make: Ditto.
- Modules/streams/ReadableStream.cpp:
(WebCore::ReadableStream::createReader): Used by JS binding to get access to the reader.
- Modules/streams/ReadableStream.h: Declaration of createReader, reader and lock.
(WebCore::ReadableStream::reader):
(WebCore::ReadableStream::lock):
- Modules/streams/ReadableStream.idl: Cleaning-up the IDL.
- Modules/streams/ReadableStreamReader.cpp: Added.
(WebCore::ReadableStreamReader::create):
(WebCore::ReadableStreamReader::ReadableStreamReader):
(WebCore::ReadableStreamReader::~ReadableStreamReader):
(WebCore::ReadableStreamReader::closed):
(WebCore::ReadableStreamReader::activeDOMObjectName):
(WebCore::ReadableStreamReader::canSuspend):
- Modules/streams/ReadableStreamReader.h: Added.
(WebCore::ReadableStreamReader::stream):
- Modules/streams/ReadableStreamReader.idl: Added.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSReadableStreamCustom.cpp:
(WebCore::JSReadableStream::getReader):
- bindings/js/JSReadableStreamReaderCustom.cpp: Added.
(WebCore::JSReadableStreamReader::read):
(WebCore::getOrCreatePromiseDeferredFromObject):
(WebCore::closedPromiseSlotName):
(WebCore::JSReadableStreamReader::closed):
(WebCore::JSReadableStreamReader::cancel):
(WebCore::JSReadableStreamReader::releaseLock):
(WebCore::constructJSReadableStreamReader):
LayoutTests:
Adding tests to check API, constructor and link with ReadableStream.getReader.
Rebasing of global-constructors-attributes.html to include ReadableStreamReader.
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- streams/readablestreamreader-constructor-expected.txt: Added.
- streams/readablestreamreader-constructor.html: Added.
- 3:05 AM Changeset in webkit [182179] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
unreviewed config fix after r182178.
- 2:19 AM Changeset in webkit [182178] by
-
- 4 edits in trunk/Tools
[EFL] Add AArch64 builder and tester bot to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=143092
Reviewed by Gyuyoung Kim.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(Factory.init):
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
- 1:58 AM Changeset in webkit [182177] by
-
- 4 edits1 add in trunk/Tools
[buildbot] clean-build script should remove untracked files and revert local changes too
https://bugs.webkit.org/show_bug.cgi?id=142400
Reviewed by Ryosuke Niwa.
This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
A helper routine SCM.discard_untracked_files is added for that purpose.
- BuildSlaveSupport/clean-build:
(main): Making call to Scripts/clean-webkit
- Scripts/clean-webkit: Added.
(main): Revert changes and delete untracked files.
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(SCMTest._shared_test_discard_untracked_files):
(test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
- 1:37 AM Changeset in webkit [182176] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix GTK+ build with REDIRECTED_XCOMPOSITE_WINDOW disabled in X11 platform.
Also fix some unused parameter warnings when
REDIRECTED_XCOMPOSITE_WINDOW is disabled.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewRenderAcceleratedCompositingResults):
(resizeWebKitWebViewBaseFromAllocation):
- 12:49 AM Changeset in webkit [182175] by
-
- 6 edits2 deletes in trunk/Source
[GTK] DnD icon/widget has odd background
https://bugs.webkit.org/show_bug.cgi?id=143217
Reviewed by Martin Robinson.
Source/WebCore:
Remove DragIcon class since it's no longer needed with GTK+3 and
the GTK+2 code there is unused. GTK+ knows what to do with a cairo
surface, I guess we migrated the GTK+2 code to GTK+3 without
realizing that using the surface was enough.
- PlatformGTK.cmake:
- platform/gtk/DragIcon.cpp: Removed.
- platform/gtk/DragIcon.h: Removed.
Source/WebKit2:
Use gtk_drag_set_icon_surface() to set the drag icon image,
instead of DragIcon class.
- UIProcess/API/gtk/WebKitWebView.cpp:
- UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::startDrag):
- UIProcess/gtk/DragAndDropHandler.h:
- 12:34 AM Changeset in webkit [182174] by
-
- 5 edits in trunk/Tools
Python SCM should be able to retrieve untracked files
https://bugs.webkit.org/show_bug.cgi?id=143135
Reviewed by Ryosuke Niwa.
This patch introduces SCM.untracked_files to retrieve a list of untracked files.
Ignored files may be included or not in this list according boolean passed to the function.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.untracked_files):
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.untracked_files):
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(SCMTest._shared_test_untracked_files):
(test_untracked_files):
(GitSVNTest.test_untracked_files):
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.untracked_files):