Timeline
May 24, 2015:
- 11:55 PM Changeset in webkit [184849] by
-
- 2 edits in trunk
[GTK] Bump GCC requirements to 4.9.0
https://bugs.webkit.org/show_bug.cgi?id=145211
Reviewed by Žan Doberšek.
It's required to build with IndexedDB support when using GCC,
clang works just fine. See https://bugs.webkit.org/show_bug.cgi?id=98932.
- Source/cmake/OptionsGTK.cmake:
- 8:51 PM Changeset in webkit [184848] by
-
- 7 edits in trunk
Array#findIndex/find should not skip holes
https://bugs.webkit.org/show_bug.cgi?id=145361
Source/JavaScriptCore:
per https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.findindex
and https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.find
Patch by Jordan Harband <ljharb@gmail.com> on 2015-05-24
Reviewed by Yusuke Suzuki.
- builtins/Array.prototype.js:
(find): Deleted.
(findIndex): Deleted.
LayoutTests:
Patch by Jordan Harband <ljharb@gmail.com> on 2015-05-24
Reviewed by Yusuke Suzuki.
- js/array-find-expected.txt:
- js/array-findIndex-expected.txt:
- js/script-tests/array-find.js:
- js/script-tests/array-findIndex.js:
- 7:38 PM Changeset in webkit [184847] by
-
- 2 edits in trunk/Source/JavaScriptCore
Web Inspector: Uncaught exception when using Inspect tool on SVG elements
https://bugs.webkit.org/show_bug.cgi?id=145363
Reviewed by Joseph Pecoraro.
The injected script failed by chaining a call to String.prototype.trim to the result of
SVG*Element.className, which is an SVGAnimatedString and lacks useful methods. So, obtain
the class name using Node.getAttribute, which always returns a DOMString.
- inspector/InjectedScriptSource.js:
(InjectedScriptSource.prototype._getDescription): use getAttribute instead of className.
- 4:22 PM Changeset in webkit [184846] by
-
- 13 edits in trunk
Crash when using a removed ScriptMessageHandler
<rdar://problem/20888499>
https://bugs.webkit.org/show_bug.cgi?id=145359
Reviewed by Dan Bernstein.
Source/WebCore:
Added tests:
WKUserContentController.ScriptMessageHandlerBasicRemove
WKUserContentController.ScriptMessageHandlerCallRemovedHandler
- page/UserMessageHandler.cpp:
(WebCore::UserMessageHandler::~UserMessageHandler):
(WebCore::UserMessageHandler::postMessage):
(WebCore::UserMessageHandler::name):
- page/UserMessageHandler.h:
(WebCore::UserMessageHandler::create):
- page/UserMessageHandler.idl:
- page/UserMessageHandlerDescriptor.cpp:
(WebCore::UserMessageHandlerDescriptor::UserMessageHandlerDescriptor):
- page/UserMessageHandlerDescriptor.h:
(WebCore::UserMessageHandlerDescriptor::client):
(WebCore::UserMessageHandlerDescriptor::invalidateClient):
Add support for invalidating the descriptor and throw an exception if someone tries
to post a message using an invalidated descriptor.
- page/UserMessageHandlersNamespace.cpp:
(WebCore::UserMessageHandlersNamespace::handler):
Add logic to remove message handlers if their descriptor has been invalidated.
Source/WebKit2:
- WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserMessageHandlerDescriptorProxy::~WebUserMessageHandlerDescriptorProxy):
Invalidate the descriptor when the message handler client (as implemented by WebUserMessageHandlerDescriptorProxy)
goes away. This will happen if a script message handler is removed at the API level or the WebUserContentController
is destroyed (which will happen if all the pages get destroyed).
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
Add tests for removing script message handlers.
- 12:30 PM Changeset in webkit [184845] by
-
- 17 edits in trunk
Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
https://bugs.webkit.org/show_bug.cgi?id=145345
Reviewed by Sam Weinig.
Source/bmalloc:
- Configurations/Base.xcconfig: Also changed to use $(inherited).
Source/JavaScriptCore:
- Configurations/Base.xcconfig: Also changed to use $(inherited).
Source/WebCore:
- Configurations/WebCore.xcconfig: Also changed to use $(inherited).
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
Source/WebKit/mac:
- Configurations/WebKitLegacy.xcconfig: Also changed to use $(inherited).
Source/WTF:
- Configurations/Base.xcconfig: Also changed to use $(inherited).
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- LayoutTestRelay/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- 11:31 AM Changeset in webkit [184844] by
-
- 19 edits in trunk/Source/WebCore
Use modern for-loops in WebCore/svg.
https://bugs.webkit.org/show_bug.cgi?id=145209
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-05-24
Reviewed by Darin Adler.
No new tests, no behavior changes.
- svg/SVGAnimateElementBase.cpp:
(WebCore::propertyTypesAreConsistent):
- svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
- svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::executeAction):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::parseAttribute):
- svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::~SVGCursorElement):
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::isElementWithPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):
- svg/SVGElement.cpp:
(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
(WebCore::hasLoadListener):
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):
- svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::append):
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseBeginOrEnd):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
(WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):
- svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::clearResultsRecursive):
- svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::addBuiltinEffects):
- svg/properties/SVGAnimatedProperty.cpp:
(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):
- svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::detachListWrappersAndResize):
- svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):
- 10:43 AM Changeset in webkit [184843] by
-
- 9 edits in trunk/Source
Register media MIME types as supported by HTML view in WebKit1.
https://bugs.webkit.org/show_bug.cgi?id=145356
Patch by Jeremy Jones <jeremyj@apple.com> on 2015-05-24
Reviewed by Eric Carlson.
Source/WebCore:
getSupportedMediaMIMETypes is now used in WebKit1.
- platform/MIMETypeRegistry.h: Export getSupportedMediaMIMETypes.
Source/WebKit/mac:
WebDataSource and WebFrame view knew about suppotedImageMIMETypes and supportedNonImageMIMETypes,
but not a third category supportedMediaMIMETypes. These are now included along-side
supportedNonImageMIMETypes.
- WebView/WebDataSource.mm:
(+[WebDataSource _repTypesAllowImageTypeOmission:]): use supportedMediaMIMETypes.
- WebView/WebFrameView.mm:
(+[WebFrameView _viewTypesAllowImageTypeOmission:]): use supportedMediaMIMETypes.
- WebView/WebHTMLRepresentation.h: declare -supportedMediaMIMETypes
- WebView/WebHTMLRepresentation.mm:
(+[WebHTMLRepresentation supportedMIMETypes]): include supportedMediaMIMETypes
(+[WebHTMLRepresentation supportedMediaMIMETypes]): added
- WebView/WebHTMLView.mm:
(+[WebHTMLView supportedMediaMIMETypes]): added
- WebView/WebHTMLViewPrivate.h: declare -supportedMediaMIMETypes
May 23, 2015:
- 9:00 PM Changeset in webkit [184842] by
-
- 5 edits in branches/safari-601.1.32.2-branch/Source
Versioning.
- 8:28 PM Changeset in webkit [184841] by
-
- 1 copy in tags/Safari-601.1.32.2.8
New tag.
- 8:21 PM Changeset in webkit [184840] by
-
- 2 edits in tags/Safari-601.1.32.2.82/Source/WebKit2
Merged r184834. rdar://problem/21090327
- 8:17 PM Changeset in webkit [184839] by
-
- 5 edits in tags/Safari-601.1.32.2.82/Source
Versioning.
- 8:15 PM Changeset in webkit [184838] by
-
- 1 copy in tags/Safari-601.1.32.2.82
New tag.
- 8:15 PM Changeset in webkit [184837] by
-
- 5 edits in trunk
Permanent redirects should have long implicit cache lifetime
https://bugs.webkit.org/show_bug.cgi?id=145348
Source/WebCore:
rdar://problem/20680519
Reviewed by Sam Weinig.
301 Moved Permanently response that doesn't specify explicit lifetime should have long implicit lifetime.
This matches other browsers.
- platform/network/CacheValidation.cpp:
(WebCore::computeFreshnessLifetimeForHTTPFamily):
Give 301 Moved Permanently (and similarly semantically permanent 410 Gone) long implicit lifetime.
(WebCore::updateRedirectChainStatus):
LayoutTests:
Reviewed by Sam Weinig.
- http/tests/cache/cache-redirections.html:
- http/tests/cache/resources/cache-control-redirect.php:
Use less confusing name (max_age->expiration vs. max-age) and fix logic.
- 8:14 PM Changeset in webkit [184836] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Merged r184834. rdar://problem/21090327
- 8:08 PM Changeset in webkit [184835] by
-
- 5 edits in branches/safari-601.1.32.2-branch/Source
Versioning.
- 7:50 PM Changeset in webkit [184834] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/21090327> /S/L/PrivateFrameworks/WebKit.framework is missing Headers and PrivateHeaders symlinks
https://bugs.webkit.org/show_bug.cgi?id=145354
Reviewed by David Kilzer.
- WebKit2.xcodeproj/project.pbxproj: Create Headers and PrivateHeaders symlinks alongside
the dylib symlink.
- 6:26 PM Changeset in webkit [184833] by
-
- 3 edits in trunk/Source/WebKit2
Rename ShareableResource::create(Handle&) to map(Handle&) to match SharedMemory.
https://bugs.webkit.org/show_bug.cgi?id=145288
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-05-23
Reviewed by Sam Weinig.
- Shared/ShareableResource.cpp:
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):
(WebKit::ShareableResource::map):
(WebKit::ShareableResource::create): Deleted.
- Shared/ShareableResource.h:
- 6:22 PM Changeset in webkit [184832] by
-
- 2 edits in trunk/Source/WebCore
Cleanup after r184796
https://bugs.webkit.org/show_bug.cgi?id=145333
Reviewed by Alexey Proskuryakov.
No new tests because there is no behavior change.
- platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::RenderingStyleSaver::RenderingStyleSaver): Deleted.
(WebCore::RenderingStyleSaver::~RenderingStyleSaver): Deleted.
- 2:32 PM Changeset in webkit [184831] by
-
- 1 copy in tags/Safari-601.1.32.2.7
New tag.
- 2:04 PM Changeset in webkit [184830] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebCore
Merge patch for rdar://problem/21084541.
- 12:28 PM Changeset in webkit [184829] by
-
- 6 edits in trunk/LayoutTests
Rebaseline after r184825. Remove artificial extra space between 2 text renderers.
Reviewed by Antti Koivisto.
- animations/lineheight-animation-expected.txt:
- animations/simultaneous-start-transform-expected.txt:
- animations/width-using-ems-expected.txt:
- fast/events/window-events-bubble-expected.txt:
- fast/events/window-events-bubble2-expected.txt:
- 11:41 AM Changeset in webkit [184828] by
-
- 80 edits2 copies in trunk
Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
https://bugs.webkit.org/show_bug.cgi?id=144848
Reviewed by Darin Adler.
Source/JavaScriptCore:
Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
- API/JSCallbackObject.h:
- builtins/BuiltinNames.h:
(JSC::BuiltinNames::isPrivateName):
- bytecode/BytecodeIntrinsicRegistry.h:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/ComplexGetStatus.cpp:
(JSC::ComplexGetStatus::computeFor):
- bytecode/ComplexGetStatus.h:
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):
- bytecode/GetByIdStatus.h:
- bytecode/Instruction.h:
(JSC::Instruction::Instruction):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):
- bytecode/PutByIdStatus.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::visibleNameForParameter):
(JSC::BytecodeGenerator::hasConstant):
(JSC::BytecodeGenerator::addConstant):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGDesiredIdentifiers.cpp:
(JSC::DFG::DesiredIdentifiers::addLazily):
(JSC::DFG::DesiredIdentifiers::at):
(JSC::DFG::DesiredIdentifiers::reallyAdd):
- dfg/DFGDesiredIdentifiers.h:
(JSC::DFG::DesiredIdentifiers::operator[]):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIn):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::identifierUID):
(JSC::DFG::SpeculativeJIT::callOperation):
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLInlineCacheDescriptor.h:
(JSC::FTL::InlineCacheDescriptor::InlineCacheDescriptor):
(JSC::FTL::InlineCacheDescriptor::uid):
(JSC::FTL::GetByIdDescriptor::GetByIdDescriptor):
(JSC::FTL::PutByIdDescriptor::PutByIdDescriptor):
(JSC::FTL::CheckInDescriptor::CheckInDescriptor):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compilePutById):
(JSC::FTL::LowerDFGToLLVM::compileIn):
(JSC::FTL::LowerDFGToLLVM::compileMaterializeCreateActivation):
(JSC::FTL::LowerDFGToLLVM::getById):
- ftl/FTLOperations.cpp:
(JSC::FTL::operationMaterializeObjectInOSR):
- ftl/FTLSlowPathCall.cpp:
(JSC::FTL::callOperation):
- ftl/FTLSlowPathCall.h:
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- parser/Nodes.cpp:
(JSC::ProgramNode::setClosedVariables):
- parser/Nodes.h:
(JSC::ScopeNode::captures):
(JSC::ScopeNode::setClosedVariables):
(JSC::ProgramNode::closedVariables):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::didFinishParsing):
(JSC::Parser<LexerType>::parseContinueStatement):
- parser/Parser.h:
(JSC::Scope::Scope):
(JSC::Scope::pushLabel):
(JSC::Scope::getLabel):
(JSC::Scope::declareCallee):
(JSC::Scope::declareVariable):
(JSC::Scope::declareParameter):
(JSC::Scope::declareBoundParameter):
(JSC::Scope::useVariable):
(JSC::Scope::copyCapturedVariablesToVector):
(JSC::Parser::closedVariables):
(JSC::ScopeLabelInfo::ScopeLabelInfo): Deleted.
- parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::usedVariables):
(JSC::SourceProviderCacheItem::writtenVariables):
(JSC::SourceProviderCacheItem::create):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::isPrivateName):
- runtime/CommonIdentifiers.h:
- runtime/Identifier.h:
(JSC::Identifier::impl):
(JSC::Identifier::Identifier):
(JSC::parseIndex):
(JSC::IdentifierRepHash::hash):
- runtime/IdentifierInlines.h:
(JSC::Identifier::fromUid):
- runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::mayInterceptStoreTo):
- runtime/IntendedStructureChain.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/Lookup.h:
(JSC::HashTable::entry):
- runtime/MapData.h:
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertySymbols):
- runtime/PrivateName.h:
(JSC::PrivateName::PrivateName):
(JSC::PrivateName::uid):
- runtime/PropertyMapHashTable.h:
- runtime/PropertyName.h:
(JSC::PropertyName::PropertyName):
(JSC::PropertyName::uid):
(JSC::PropertyName::publicName):
(JSC::parseIndex):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::addKnownUnique):
(JSC::PropertyNameArray::add):
- runtime/Structure.cpp:
(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::StructureTransitionTable::add):
(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::getConcurrently):
(JSC::Structure::add):
(JSC::Structure::remove):
(JSC::Structure::toStructureShape):
- runtime/Structure.h:
(JSC::PropertyMapEntry::PropertyMapEntry):
- runtime/StructureInlines.h:
(JSC::Structure::getConcurrently):
- runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::Hash::hash):
- runtime/Symbol.cpp:
(JSC::Symbol::Symbol):
- runtime/Symbol.h:
- runtime/SymbolConstructor.cpp:
(JSC::symbolConstructorFor):
(JSC::symbolConstructorKeyFor):
- runtime/SymbolTable.cpp:
(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::globalTypeSetForVariable):
- runtime/SymbolTable.h:
- runtime/TypeSet.cpp:
(JSC::StructureShape::addProperty):
(JSC::StructureShape::propertyHash):
- runtime/TypeSet.h:
Source/WebCore:
Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::write):
Source/WTF:
he current AtomicStringImpl accidentally means the symbol OR atomic StringImpl.
t's not correct to its name and it's error prone.
In this patch, we'll introduce/changes classes into WTF.
- UniquedStringImpl
It's derived class from StringImpl. And it represents symbol atomic StringImpl. - SymbolImpl
It's derived class from UniquedStringImpl. Only symbol strings can become this.
It ensures the given StringImpl is symbol in compile time.
- AtomicStringImpl
It's derived class from UniquedStringImpl. Only atomic (non-normal && non-symbol) strings can become this.
It ensures the given StringImpl is atomic in compile time.
And, in this time, I just accept UniqueStringImpl in AtomicString. As the result,
- Now AtomicStringImpl issue is fixed. Its SymbolImpl is separated and UniquedStringImpl is introduced.
- But AtomicString still have both symbol and atomic strings.
This should be solved in the separated patch.
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/PrintStream.cpp:
- wtf/PrintStream.h:
(WTF::printInternal):
- wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
- wtf/text/AtomicStringImpl.h:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::createSymbol):
(WTF::StringImpl::createSymbolEmpty):
- wtf/text/StringImpl.h:
- wtf/text/SymbolImpl.h: Copied from Source/JavaScriptCore/runtime/PrivateName.h.
- wtf/text/SymbolRegistry.cpp:
(WTF::SymbolRegistry::symbolForKey):
(WTF::SymbolRegistry::keyForSymbol):
(WTF::SymbolRegistry::remove):
- wtf/text/SymbolRegistry.h:
- wtf/text/UniquedStringImpl.h: Copied from Source/JavaScriptCore/runtime/PrivateName.h.
Tools:
Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
- TestWebKitAPI/Tests/WTF/StringImpl.cpp:
- 9:21 AM Changeset in webkit [184827] by
-
- 5 edits in branches/safari-601.1.32-branch/Source
Versioning.
- 9:21 AM Changeset in webkit [184826] by
-
- 5 edits in branches/safari-601.1.32.2-branch/Source
Versioning.
- 9:06 AM Changeset in webkit [184825] by
-
- 4 edits2 adds in trunk
Simple line layout: Ignore -webkit-flow-*content while collecting text content for innerText.
https://bugs.webkit.org/show_bug.cgi?id=145344
rdar://problem/20959522
Reviewed by Antti Koivisto.
This patch ensures that when a -webkit-flow-into content is present in a simple line layout container,
we skip it while collecting the text content for innerText.
It's not always guaranteed that a simple line layout container only contains simple text nodes. In such cases,
we need to ensure that text offset computing only takes the simple text nodes into account.
Source/WebCore:
Test: fast/text/simple-line-layout-inner-text-with-flow-content.html
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextNode):
- editing/TextIterator.h:
LayoutTests:
- fast/text/simple-line-layout-inner-text-with-flow-content-expected.txt: Added.
- fast/text/simple-line-layout-inner-text-with-flow-content.html: Added.
- 8:07 AM Changeset in webkit [184824] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove code related with unused style classes
https://bugs.webkit.org/show_bug.cgi?id=145332
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-23
Reviewed by Timothy Hatcher.
- UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.append):
(WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString):
The "type-string" class has no styles associated with it. So the entire span can be removed.
- UserInterface/Views/DOMTreeElement.js:
Both of these style classes have no styles associated with them. Remove the class names.
- 8:03 AM Changeset in webkit [184823] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Improve native parameter lists a bit
https://bugs.webkit.org/show_bug.cgi?id=145338
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-23
Reviewed by Timothy Hatcher.
- UserInterface/Models/NativeFunctionParameters.js:
- UserInterface/Views/ObjectTreePropertyTreeElement.js:
(WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
- 8:01 AM Changeset in webkit [184822] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Update CSS Autocompletion properties and values
https://bugs.webkit.org/show_bug.cgi?id=145341
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-23
Reviewed by Timothy Hatcher.
- UserInterface/Models/CSSKeywordCompletions.js:
May 22, 2015:
- 11:40 PM Changeset in webkit [184821] by
-
- 2 edits in trunk/Tools
Fix one more merge error in static analyzer support.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
(BuildbotStaticAnalyzerQueueView):
- 11:31 PM Changeset in webkit [184820] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Adopt Object.setPrototypeOf
https://bugs.webkit.org/show_bug.cgi?id=145335
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-22
Reviewed by Timothy Hatcher.
For a case that won't easily move to ES6 classes use Object.setPrototypeOf.
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackend.Command.create):
- 11:27 PM Changeset in webkit [184819] by
-
- 39 edits in trunk/Source/WebInspectorUI
Web Inspector: Inline use once class names and remove some unused class names
https://bugs.webkit.org/show_bug.cgi?id=145334
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-22
Reviewed by Timothy Hatcher.
- UserInterface/Views/ApplicationCacheFrameContentView.js:
(WebInspector.ApplicationCacheFrameContentView):
- UserInterface/Views/BoxModelDetailsSectionRow.js:
(WebInspector.BoxModelDetailsSectionRow):
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection):
- UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel):
- UserInterface/Views/ClusterContentView.js:
(WebInspector.ClusterContentView):
- UserInterface/Views/CompletionSuggestionsView.js:
(WebInspector.CompletionSuggestionsView):
- UserInterface/Views/ConsolePrompt.js:
(WebInspector.ConsolePrompt):
- UserInterface/Views/ContentBrowser.js:
(WebInspector.ContentBrowser):
- UserInterface/Views/ContentFlowTreeElement.js:
(WebInspector.ContentFlowTreeElement):
- UserInterface/Views/ContentView.js:
(WebInspector.ContentView):
- UserInterface/Views/ContentViewContainer.js:
(WebInspector.ContentViewContainer):
- UserInterface/Views/CookieStorageContentView.js:
(WebInspector.CookieStorageContentView):
- UserInterface/Views/CookieStorageTreeElement.js:
(WebInspector.CookieStorageTreeElement):
- UserInterface/Views/DOMStorageContentView.js:
(WebInspector.DOMStorageContentView):
- UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView):
- UserInterface/Views/DashboardView.js:
(WebInspector.DashboardView):
- UserInterface/Views/DatabaseTableContentView.js:
(WebInspector.DatabaseTableContentView):
- UserInterface/Views/DebuggerDashboardView.js:
(WebInspector.DebuggerDashboardView):
(WebInspector.DebuggerDashboardView.prototype._rebuildLocation):
- UserInterface/Views/DetailsSection.js:
(WebInspector.DetailsSection):
- UserInterface/Views/DetailsSectionSimpleRow.js:
- UserInterface/Views/FontResourceContentView.js:
(WebInspector.FontResourceContentView):
(WebInspector.FontResourceContentView.prototype.createMetricElement):
(WebInspector.FontResourceContentView.prototype.contentAvailable):
- UserInterface/Views/HierarchicalPathComponent.js:
(WebInspector.HierarchicalPathComponent):
(WebInspector.HierarchicalPathComponent.prototype.set selectorArrows):
- UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
- UserInterface/Views/LayoutTimelineOverviewGraph.js:
(WebInspector.LayoutTimelineOverviewGraph):
- UserInterface/Views/NetworkTimelineOverviewGraph.js:
(WebInspector.NetworkTimelineOverviewGraph):
- UserInterface/Views/OverviewTimelineView.js:
- UserInterface/Views/ProbeSetDetailsSection.js:
- UserInterface/Views/QuickConsole.js:
- UserInterface/Views/ReplayDashboardView.js:
- UserInterface/Views/ScriptContentView.js:
(WebInspector.ScriptContentView):
- UserInterface/Views/ScriptTimelineOverviewGraph.js:
(WebInspector.ScriptTimelineOverviewGraph):
- UserInterface/Views/TextContentView.js:
(WebInspector.TextContentView):
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview):
- UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph):
- UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar):
- UserInterface/Views/TimelineRecordFrame.js:
(WebInspector.TimelineRecordFrame):
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView):
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler):
(WebInspector.TimelineRuler.prototype.set allowsTimeRangeSelection):
- 11:04 PM Changeset in webkit [184818] by
-
- 4 edits in trunk/LayoutTests
Update tests broken by MediaPlaybackRequiresUserGesture renaming.
- media/no-autoplay-with-user-gesture-requirement.html:
- media/video-load-require-user-gesture.html:
- media/video-play-require-user-gesture.html:
- 10:50 PM Changeset in webkit [184817] by
-
- 2 edits in trunk/LayoutTests
New test media/accessiblity-describes-video.html is flaky.
- platform/mac/TestExpectations: Marking as such, as suggested by Jer.
- 8:54 PM Changeset in webkit [184816] by
-
- 2 edits in trunk/Source/WebCore
Document::ensurePlugInsInjectedScript() should evaluate the injected script on its own frame.
https://bugs.webkit.org/show_bug.cgi?id=145328
Reviewed by Jon Lee.
trac.webkit.org/r184329 fixed HTMLPlugInImageElement::didAddUserAgentShadowRoot()
to use the document's frame instead of the page's main frame. However,
Document::ensurePlugInsInjectedScript() is still evaluating the injected script on
the main frame.
As a result, HTMLPlugInImageElement::didAddUserAgentShadowRoot()'s attempt to get
the injected createOverlay function from the document frame's global object will
fail. Fixing Document::ensurePlugInsInjectedScript() to evaluating the injected
script on the document's frame fixes the issue.
No new tests.
- dom/Document.cpp:
(WebCore::Document::ensurePlugInsInjectedScript):
- 7:12 PM Changeset in webkit [184815] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: DOMTree Keyboard Shortcut 'H' to toggle element visibility is not working
https://bugs.webkit.org/show_bug.cgi?id=145331
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-22
Reviewed by Brian Burg.
We no longer have CSSProperty.value setters. Instead of attempting
to toggle and clobber inline style values on the element we:
- inject a <style> on the page like ".WebInspectorHide { visibility:hidden }"
- toggle the WebInspectorHide class on the selected element
This approach is inspired by the original WebKit change in the
old inspector frontend: <https://webkit.org/b/110641>.
The old approach toggled a few properties (opacity and pointer events)
while the new approach uses visibility, matching other browsers.
- UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype._hideElement.resolvedNode.injectStyleAndToggleClass):
(WebInspector.DOMTreeOutline.prototype._hideElement.resolvedNode):
(WebInspector.DOMTreeOutline.prototype._hideElement):
(WebInspector.DOMTreeOutline.prototype._hideElement.toggleProperties): Deleted.
- 7:11 PM Changeset in webkit [184814] by
-
- 10 edits in trunk/Source/WebCore
MediaPlayer doesn't need isPlayingToWirelessPlaybackTarget and isCurrentPlaybackTargetWireless
https://bugs.webkit.org/show_bug.cgi?id=145325
Reviewed by Brent Fulgham.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsWireless): Call isCurrentPlaybackTargetWireless
directly.
(WebCore::HTMLMediaElement::wirelessRoutesAvailableDidChange): Ditto.
(WebCore::HTMLMediaElement::isPlayingToWirelessPlaybackTarget): Ditto.
(WebCore::HTMLMediaElement::mediaState): Ditto.
- html/HTMLMediaSession.cpp:
(WebCore::HTMLMediaSession::currentPlaybackTargetIsWireless): Deleted.
- html/HTMLMediaSession.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::isPlayingToWirelessPlaybackTarget): Deleted.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::isPlayingToWirelessPlaybackTarget): Deleted.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::isPlayingToWirelessPlaybackTarget): Deleted.
- platform/ios/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::updateForEventName): Call webkitCurrentPlaybackTargetIsWireless.
- 6:57 PM Changeset in webkit [184813] by
-
- 22 edits in trunk/Source
Rename MediaPlaybackAllowsInline
https://bugs.webkit.org/show_bug.cgi?id=145315
Reviewed by Eric Carlson.
Our API uses allowsInlineMediaPlayback. Our symbols should reflect the same.
Source/WebCore:
- page/Settings.cpp: Update the static variable name as well as the setting.
- page/Settings.in: Ditto.
- Modules/mediacontrols/MediaControlsHost.idl: Rename to allowsInlineMediaPlayback.
Affects the media controls code.
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::allowsInlineMediaPlayback):
(WebCore::MediaControlsHost::mediaPlaybackAllowsInline): Deleted.
Update to use the new name in the media controls.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.shouldHaveControls):
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.shouldHaveStartPlaybackButton):
- css/MediaQueryEvaluator.cpp:
(WebCore::video_playable_inlineMediaFeatureEval):
- html/HTMLMediaSession.cpp:
(WebCore::HTMLMediaSession::requiresFullscreenForVideoPlayback):
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h: Update the name of the key, but not its
value, for backwards compatibility.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Update the symbol.
(-[WebPreferences mediaPlaybackAllowsInline]): Ditto. This setting will not
be renamed in a future patch.
(-[WebPreferences setMediaPlaybackAllowsInline:]): Ditto.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Update the call to settings.
Source/WebKit/win:
- WebView.cpp:
(WebView::notifyPreferencesChanged): Use the new name.
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetMediaPlaybackAllowsInline): Update the call to preferences.
The C API will not change in a future patch.
(WKPreferencesGetMediaPlaybackAllowsInline): Ditto.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]): Update the name of the key.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Ditto.
- UIProcess/API/gtk/WebKitSettings.cpp: Update the call.
(webkit_settings_get_media_playback_allows_inline):
(webkit_settings_set_media_playback_allows_inline):
- 6:57 PM Changeset in webkit [184812] by
-
- 1 copy in tags/Safari-601.1.32.6
New tag.
- 6:55 PM Changeset in webkit [184811] by
-
- 13 edits in trunk/Source
Rename MediaPlaybackAllowsAirPlay
https://bugs.webkit.org/show_bug.cgi?id=145316
Reviewed by Eric Carlson.
In preparation for an API rename, update internal symbols from mediaPlaybackAllowsAirPlay
to allowsAirPlayForMediaPlayback.
Source/WebCore:
- page/Settings.in: Update the setting name.
- html/HTMLMediaSession.cpp:
(WebCore::HTMLMediaSession::wirelessVideoPlaybackDisabled): Update the call to settings.
- testing/InternalSettings.h: Update the name of the member variable.
- testing/InternalSettings.cpp: Update the names and calls to settings.
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::resetToConsistentState):
(WebCore::InternalSettings::setWirelessPlaybackDisabled):
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h: Update the name but keep its value, for backwards
compatibility.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Update to reference the new key name.
(-[WebPreferences mediaPlaybackAllowsAirPlay]): Ditto. This API will not change in a future
patch.
(-[WebPreferences setMediaPlaybackAllowsAirPlay:]): Ditto.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Update the call to settings.
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h: Update the name.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]): Ditto.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Update the call to settings.
- 6:15 PM Changeset in webkit [184810] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed build fix for Windows.
- WebView.cpp:
(WebView::notifyPreferencesChanged):
- 5:54 PM Changeset in webkit [184809] by
-
- 2 edits in trunk/Tools
Fix internal dashboard breakage from recent commit.
https://bugs.webkit.org/show_bug.cgi?id=144814
Unreviewed build fix.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
(BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
(BuildbotStaticAnalyzerQueueView.prototype.update):
- 5:38 PM Changeset in webkit [184808] by
-
- 1 copy in tags/Safari-601.1.32.2.6
New tag.
- 5:26 PM Changeset in webkit [184807] by
-
- 3 edits in trunk/Tools
REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
https://bugs.webkit.org/show_bug.cgi?id=130463
rdar://problem/20461342
Reviewed by Tim Horton.
This was more of a timing related flakiness than an actual OS version specific bug,
we weren't getting window visibility notifications.
I will look into adding this function call to DumpRenderTree separately, layout tests
might actually rely on the broken behavior.
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(TestWebKitAPI::TEST_F):
- TestWebKitAPI/mac/mainMac.mm:
(main):
- 5:25 PM Changeset in webkit [184806] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Show results and status before revisions for A/B testing results
https://bugs.webkit.org/show_bug.cgi?id=145327
Reviewed by Chris Dumez.
Place the results and the status columns before the columns for revisions.
Also show the absolute difference as well as the relative difference between the averages of A and B.
- public/v2/app.js:
(App.TestGroupPane._populate):
(App.TestGroupPane._computeStatisticalSignificance):
- public/v2/index.html:
- 5:19 PM Changeset in webkit [184805] by
-
- 1 edit1 add in trunk/Tools
Add missing file from r184804 (mis-applied diff).
https://bugs.webkit.org/show_bug.cgi?id=144814
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
(BuildbotStaticAnalyzerQueueView):
(BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
(BuildbotStaticAnalyzerQueueView.prototype.update):
- 5:11 PM Changeset in webkit [184804] by
-
- 6 edits in trunk/Tools
Add support to the botwatchers dashboard for a static analyzer bot.
https://bugs.webkit.org/show_bug.cgi?id=144814
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
scan-build should be considered a productive step.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue):
Adds support for the staticAnalyzer property
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
(BuildbotTestResults.prototype._parseResults):
Get bug count from the scan-build step output
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady):
Rename the performance column 'Other', and merge the current 'Other' column with it.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
Now that performance bots are part of the 'Other' column, give them better headings.
- 4:57 PM Changeset in webkit [184803] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK fix after r184802.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_get_media_playback_requires_user_gesture):
(webkit_settings_set_media_playback_requires_user_gesture):
- 4:56 PM Changeset in webkit [184802] by
-
- 14 edits in trunk/Source
Rename MediaPlaybackRequiresUserGesture
https://bugs.webkit.org/show_bug.cgi?id=145314
Reviewed by Anders Carlsson.
In preparation for an API rename, update internal symbols from mediaPlaybackRequiresUserGesture
to requiresUserGestureForMediaPlayback.
Source/WebCore:
- page/Settings.cpp: update static const default variable name.
- page/Settings.in: update the setting name and static const default variable name.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::constructCommon): Update settings call.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Ditto.
Source/WebKit/mac:
No changes are being made to the API in this patch.
- WebView/WebPreferenceKeysPrivate.h: Update the name of the key, but not its value, for backwards
compatibility.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Update the symbol.
(-[WebPreferences mediaPlaybackRequiresUserGesture]): Ditto. This setting will not be renamed
in a future patch.
(-[WebPreferences setMediaPlaybackRequiresUserGesture:]): Ditto.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Update the call to settings.
Source/WebKit2:
No changes are being made to the API in this patch.
- Shared/WebPreferencesDefinitions.h: Update the name of the macro and the setting.
- UIProcess/API/C/WKPreferences.cpp: The C API will not change in a future patch.
(WKPreferencesSetMediaPlaybackRequiresUserGesture): Update the call to preferences.
(WKPreferencesGetMediaPlaybackRequiresUserGesture): Ditto.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]): Update the name of the key.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Ditto.
- 4:44 PM Changeset in webkit [184801] by
-
- 2 edits in trunk/Source/WebCore
AX: Figure out why list-detection2.html test fails on GTK
https://bugs.webkit.org/show_bug.cgi?id=145273
Reviewed by Chris Fleizach.
Only consider the text under the pseudo element for GTK and EFL.
The other platforms expose rendered text content through their
own accessible objects. This will fix the crash on Windows until
it can be looked into properly.
No new tests. This should stop list-detection2.html to stop crashing on Windows.
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers):
- 4:29 PM Changeset in webkit [184800] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r183647.
https://bugs.webkit.org/show_bug.cgi?id=145326
broke some toolbar blurring behavior (Requested by thorton on
#webkit).
Reverted changeset:
"Asynchronous (or timed-out synchronous) resize flashes white
instead of page background color"
https://bugs.webkit.org/show_bug.cgi?id=144468
http://trac.webkit.org/changeset/183647
- 4:15 PM Changeset in webkit [184799] by
-
- 24 edits9 adds in trunk
[Mac] Audio tracks tagged as 'describes-video' are not automatically selected when that system accessibility option is set.
https://bugs.webkit.org/show_bug.cgi?id=145228
Reviewed by Eric Carlson.
Source/WebCore:
Tests: http/tests/media/hls/hls-accessiblity-describes-video.html
media/accessiblity-describes-video.html
Add support to CaptionUserPreferences to return the user's preferred audio characteristics,
including "public.accessibility.describes-video". When the media accessibility options change,
trigger the HTMLMediaElement to update the list of tracks, and chose a new audio track if
appropriate. Manually filter those tracks matching the requested characteristics in
MediaSelectionGroupAVFObjC. Allow these characteristics to be overrided by Internals for
testing purposes.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::captionPreferencesChanged): Call tracksChanged().
(WebCore::HTMLMediaElement::mediaPlayerPreferredAudioCharacteristics): Pass through to the page's caption preferences.
- html/HTMLMediaElement.h:
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::setPreferredAudioCharacteristic): Simple setter.
(WebCore::CaptionUserPreferences::preferredAudioCharacteristics): Simple getter.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::~CaptionUserPreferencesMediaAF): Unregister for audio characteristics change notifications.
(WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges): Register for same.
(WebCore::CaptionUserPreferencesMediaAF::setPreferredAudioCharacteristic): If in testing mode, pass to superclass; otherwise no-op.
(WebCore::CaptionUserPreferencesMediaAF::preferredAudioCharacteristics): If in testing mode, pass to superclass;
otherwise, ask the media accessibility framework.
- page/CaptionUserPreferencesMediaAF.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::tracksChanged): Pass through to m_private.
(WebCore::MediaPlayer::preferredAudioCharacteristics): Pass through to HTMLMediaElement.
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerPreferredAudioCharacteristics): Added; return empty vector by default.
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::tracksChanged): Added; no-op by default.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:
- platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
(WebCore::MediaSelectionGroupAVFObjC::create): Added characteristics parameter.
(WebCore::MediaSelectionGroupAVFObjC::MediaSelectionGroupAVFObjC): Ditto.
(WebCore::MediaSelectionGroupAVFObjC::updateOptions): Add an additional filter against the
passed-in characteristics.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::determineChangedTracksFromNewTracksAndOldItems): Pass the characteristics to the media selection group.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks): Pass in the user's preferred characteristics.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks): Pass in an empty vector.
- testing/Internals.cpp:
(WebCore::Internals::userPreferredAudioCharacteristics): Added; return the current setting.
(WebCore::Internals::setUserPreferredAudioCharacteristic): Added; pass through to CaptionUserPreferences.
- testing/Internals.h:
- testing/Internals.idl:
Add soft link macros which account for a possible failure to look up constants.
- platform/cf/MediaAccessibilitySoftLink.cpp:
- platform/cf/MediaAccessibilitySoftLink.h:
- platform/mac/SoftLinking.h:
- platform/win/SoftLinking.h:
LayoutTests:
- http/tests/media/hls/hls-accessiblity-describes-video-expected.txt: Added.
- http/tests/media/hls/hls-accessiblity-describes-video.html: Added.
- http/tests/media/resources/hls/audio-describes-video.m3u8: Added.
- http/tests/media/resources/hls/english/description.aac: Added.
- http/tests/media/resources/hls/english/description.m3u8: Added.
- media/accessiblity-describes-video-expected.txt: Added.
- media/accessiblity-describes-video.html: Added.
- media/content/audio-describes-video.mp4: Added.
- platform/mac-mavericks/TestExpectations:
- 3:52 PM Changeset in webkit [184798] by
-
- 2 edits in trunk/Source/WebKit2
Image link doesn't create a preview view controller.
https://bugs.webkit.org/show_bug.cgi?id=145320
Also try to create the preview view controller if the hit-tested node
is a image link.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-05-22
Reviewed by Beth Dakin.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView previewViewControllerForPosition:inSourceView:]):
- 2:48 PM Changeset in webkit [184797] by
-
- 3 edits in trunk/Source/WebKit2
Avoid doing an extra layout in some cases while doing scale-to-fit
https://bugs.webkit.org/show_bug.cgi?id=145321
<rdar://problem/21051165>
Reviewed by Beth Dakin.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):
If we make it to scaleViewToFitDocumentIfNeeded with valid layout,
the view width is still less than the last-known minimum document size,
and the document size hasn't changed, update the view scale without
doing an extra layout, keeping the fixed layout size at the previously
computed minimum document size.
- 2:43 PM Changeset in webkit [184796] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Use CTFontDrawGlyphs() instead of CGContextShowGlyphsWithAdvances()/CGContextShowGlyphsAtPositions()
https://bugs.webkit.org/show_bug.cgi?id=145234
Reviewed by Enrica Casucci.
Eventually, we want to migrate entirely off of text-related CoreGraphics calls
and onto CoreText calls (in order to reduce complexity as well as eventually
removing the need for FontPlatformData to hold a CGFontRef). There is an
equivalent call to CGContextShowGlyphsWithAdvances() and
CGContextShowGlyphsAtPositions(), namely, CTFontDrawGlyphs(), which we have
found is as performant as its CoreGraphics counterparts. This patch simply
migrates these two CG calls to its CT counterpart.
Performance was measured on a iPhone 4s as well as a Mid 2010 Mac Pro.
No new tests because there is no behavior change.
- platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::showGlyphsWithAdvances):
(WebCore::FontCascade::drawGlyphs):
- 2:23 PM Changeset in webkit [184795] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Build fix after r184774.
- 2:01 PM Changeset in webkit [184794] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Don't show default controls after playing to wireless target
https://bugs.webkit.org/show_bug.cgi?id=145317
Reviewed by Dean Jackson.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handlePanelTransitionEnd): Don't show controls unless the video
element has the 'controls' attribute.
(Controller.prototype.setPlaying): Check this.video.controls directly because we never want
to show controls unless the attribute is present.
(Controller.prototype.showControls): Ditto.
(Controller.prototype.updateWirelessPlaybackStatus): Call reconnectControls.
(Controller.prototype.handleWirelessPlaybackChange): Don't call reconnectControls, it will
happen in updateWirelessPlaybackStatus.
(Controller.prototype.showInlinePlaybackPlaceholderOnly): Deleted.
- 1:47 PM Changeset in webkit [184793] by
-
- 3 edits in trunk/Source/WebCore
[CG] Regression(r78652): Partially decoded images are not properly removed from MemoryCache when pruning
https://bugs.webkit.org/show_bug.cgi?id=145310
Reviewed by Antti Koivisto.
r78652 added partially decoded images to the MemoryCache's list of live
decoded resources so that they can be pruned on memory pressure. This
was needed because CG decodes part of the image to determine its
properties (e.g. its size). On memory pressure, we call
BitmapImage::destroyDecodedData() which clears the ImageSource and
frees up this extra decoded data.
However, we would fail to remove such partially decoded images from the
MemoryCache's list of live resources when pruning. This is because
BitmapImage::destroyMetadataAndNotify() fails to take into account the
decoded properties size when no frame has been cleared. We would thus
fail to detect a decoded size change and not call
CachedImage::decodedSizeChanged(). As a result, the CachedImage's
decoded size is not reset to 0 and we don't remove it from live decoded
resources.
This patch updates BitmapImage::destroyMetadataAndNotify() to account
for m_decodedPropertiesSize even if frameBytesCleared is 0. This way,
images for which we have't decoded any frames yet will correctly report
that we cleared the decoded data used to determine the image properties
and their decoded size will be properly reset to 0. As a result, these
will be removed from the MemoryCache's list of live decoded resources.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::destroyMetadataAndNotify):
(WebCore::BitmapImage::dataChanged):
- platform/graphics/BitmapImage.h:
- 1:31 PM Changeset in webkit [184792] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Unable to get cursor in new Rule section after creating multiple New Rules
https://bugs.webkit.org/show_bug.cgi?id=145294
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-22
Reviewed by Timothy Hatcher.
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::ensureParsedDataReady):
Allow stylesheets with mutations for the inspector stylesheet
which we control mutations of.
- 1:30 PM Changeset in webkit [184791] by
-
- 2 edits in trunk/Tools
Turn on autosaving of toolbar configuration in MiniBrowser
Rubber-stamped by Dan Bernstein.
- MiniBrowser/mac/BrowserWindow.xib:
- 1:23 PM Changeset in webkit [184790] by
-
- 3 edits in trunk/Source/WebKit2
Yellow highlight and DD popover don't go away when scrolling an iframe
https://bugs.webkit.org/show_bug.cgi?id=145312
-and corresponding-
rdar://problem/19692334
Reviewed by Tim Horton.
Match what Lookup already does for their popover and dismiss our popovers on
scroll.
- UIProcess/API/mac/WKView.mm:
(-[WKView scrollWheel:]):
This should not be needed anymore.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::pageDidScroll):
- 1:00 PM Changeset in webkit [184789] by
-
- 7 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Merged r184774. rdar://problem/21033029
- 12:14 PM Changeset in webkit [184788] by
-
- 5 edits in trunk/Source/WebCore
[Mac] Device picker menu should be persistent
https://bugs.webkit.org/show_bug.cgi?id=145311
Reviewed by Brent Fulgham.
- Modules/mediasession/WebMediaSessionManager.cpp:
(WebCore::WebMediaSessionManager::addPlaybackTargetPickerClient): Add logging.
(WebCore::WebMediaSessionManager::removePlaybackTargetPickerClient): Ditto.
(WebCore::WebMediaSessionManager::removeAllPlaybackTargetPickerClients): Ditto.
(WebCore::WebMediaSessionManager::showPlaybackTargetPicker): Ditto.
(WebCore::WebMediaSessionManager::clientStateDidChange): Ditto.
(WebCore::WebMediaSessionManager::externalOutputDeviceAvailableDidChange): Ditto.
(WebCore::WebMediaSessionManager::configurePlaybackTargetMonitoring): Ditto.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaState): Don't set ExternalDeviceAutoPlayCandidate unless
there is an event listener.
- platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
(WebCore::MediaPlaybackTargetPickerMac::~MediaPlaybackTargetPickerMac): Release the menu
controller and remove observers.
(WebCore::MediaPlaybackTargetPickerMac::create): Add logging.
(WebCore::MediaPlaybackTargetPickerMac::pendingActionTimerFired): Ditto.
(WebCore::MediaPlaybackTargetPickerMac::availableDevicesDidChange): Ditto.
(WebCore::MediaPlaybackTargetPickerMac::devicePicker): Ditto.
(WebCore::MediaPlaybackTargetPickerMac::showPlaybackTargetPicker): Ditto.
(WebCore::MediaPlaybackTargetPickerMac::addPendingAction): Start the timer after
a brief pause to debounce multiple identical notifications.
(WebCore::MediaPlaybackTargetPickerMac::currentDeviceDidChange): Add logging.
(WebCore::MediaPlaybackTargetPickerMac::startingMonitoringPlaybackTargets): Add logging.
(WebCore::MediaPlaybackTargetPickerMac::stopMonitoringPlaybackTargets): Don't release
the menu controller delegate.
(-[WebAVOutputDeviceMenuControllerHelper observeValueForKeyPath:ofObject:change:context:]): Add logging.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessPlaybackTarget): Update logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldPlayToPlaybackTarget): Ditto.
- 12:11 PM Changeset in webkit [184787] by
-
- 4 edits3 copies in branches/safari-601.1.32-branch/Source/JavaScriptCore
Merged r184781. rdar://problem/21030149
- 12:11 PM Changeset in webkit [184786] by
-
- 4 edits3 copies in branches/safari-601.1.32.2-branch/Source/JavaScriptCore
Merged r184781. rdar://problem/21030149
- 12:05 PM Changeset in webkit [184785] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Merged r184692. rdar://problem/20967937
- 12:03 PM Changeset in webkit [184784] by
-
- 7 edits in trunk/Tools
build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
https://bugs.webkit.org/show_bug.cgi?id=145297
Reviewed by Tim Horton.
This is a refactoring to simplify code, and to make it more logical.
It is up to the view to decide how to present the queues, and whether to split
them into debug and release, or in some different way.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.filterQueues):
(BuildbotBuilderQueueView):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
(BuildbotLeaksQueueView):
(BuildbotLeaksQueueView.prototype.update):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
(BuildbotPerformanceQueueView):
(BuildbotPerformanceQueueView.prototype.update):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView):
(BuildbotQueueView.prototype._updateQueues):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady):
- 11:57 AM Changeset in webkit [184783] by
-
- 2 edits in trunk/Source/WebCore
Build fix. Added a platform ifdef.
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::isUserInitiatedKey):
- 11:54 AM Changeset in webkit [184782] by
-
- 3 edits in tags/Safari-601.1.32.2.81/Source/JavaScriptCore
Merged r184581. rdar://problem/20968297
- 11:48 AM Changeset in webkit [184781] by
-
- 4 edits3 adds in trunk/Source/JavaScriptCore
Arguments elimination phase mishandles arity check failure in its reduction of LoadVarargs to GetStack/PutStacks
https://bugs.webkit.org/show_bug.cgi?id=145298
Reviewed by Geoffrey Garen.
- dfg/DFGArgumentsEliminationPhase.cpp: Fix the bug. I restructured the loop to make it more obvious that we're initializing everything that we're supposed to initialize.
- dfg/DFGNode.h: Add a comment to clarify something I was confused about while writing this code.
- dfg/DFGPutStackSinkingPhase.cpp: Hacking on PutStacks made me think deep thoughts, and I added some FIXMEs.
- tests/stress/fold-load-varargs-arity-check-fail-barely.js: Added. This test crashes or fails before this patch.
- tests/stress/fold-load-varargs-arity-check-fail.js: Added. This is even more sure to crash or fail.
- tests/stress/simplify-varargs-mandatory-minimum-smaller-than-limit.js: Added. Not sure if we had coverage for this case before.
- 11:43 AM Changeset in webkit [184780] by
-
- 44 edits10 deletes in trunk
Remove action menu support
https://bugs.webkit.org/show_bug.cgi?id=145305
<rdar://problem/21070771>
Reviewed by Anders Carlsson.
- WebCore.xcodeproj/project.pbxproj:
- platform/spi/mac/NSMenuSPI.h:
- platform/spi/mac/NSViewSPI.h: Removed.
Remove some SPI.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
- TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
- TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
- TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
- TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
Remove the tests.
- WebKit.xcodeproj/project.pbxproj:
Remove some files.
- Configurations/WebKitLegacy.xcconfig:
- WebView/WebActionMenuController.h: Removed.
- WebView/WebActionMenuController.mm: Removed.
- WebView/WebHTMLView.mm:
(-[WebHTMLView otherMouseDown:]):
(-[WebHTMLView scrollWheel:scrollWheel:]): Deleted.
(-[WebHTMLView mouseDown:mouseDown:]): Deleted.
- WebView/WebUIDelegatePrivate.h:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Deleted.
(-[WebView _close]): Deleted.
(-[WebView prepareForMenu:withEvent:]): Deleted.
(-[WebView willOpenMenu:withEvent:]): Deleted.
(-[WebView didCloseMenu:withEvent:]): Deleted.
(-[WebView _actionMenuController]): Deleted.
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]): Deleted.
- WebView/WebViewInternal.h:
Remove everything, except some enums that clients still refer to.
- Configurations/WebKit.xcconfig:
- Shared/API/c/WKActionMenuItemTypes.h:
- Shared/API/c/WKActionMenuTypes.h:
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _didPerformImmediateActionHitTest:contentPreventsDefault:userData:]):
(-[WKView dealloc]): Deleted.
(-[WKView mouseDown:]): Deleted.
(-[WKView initWithFrame:processPool:configuration:webView:]): Deleted.
(-[WKView prepareForMenu:withEvent:]): Deleted.
(-[WKView willOpenMenu:withEvent:]): Deleted.
(-[WKView didCloseMenu:withEvent:]): Deleted.
(-[WKView _didPerformActionMenuHitTest:forImmediateAction:contentPreventsDefault:userData:]): Deleted.
(-[WKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:]): Deleted.
(-[WKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]): Deleted.
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performImmediateActionHitTestAtLocation):
(WebKit::WebPageProxy::didPerformImmediateActionHitTest):
(WebKit::WebPageProxy::performActionMenuHitTestAtLocation): Deleted.
(WebKit::WebPageProxy::selectLastActionMenuRange): Deleted.
(WebKit::WebPageProxy::focusAndSelectLastActionMenuHitTestResult): Deleted.
(WebKit::WebPageProxy::didPerformActionMenuHitTest): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformImmediateActionHitTest):
(WebKit::PageClientImpl::didPerformActionMenuHitTest): Deleted.
- UIProcess/mac/WKActionMenuController.h: Removed.
- UIProcess/mac/WKActionMenuController.mm: Removed.
- UIProcess/mac/WKImmediateActionController.h:
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController didPerformImmediateActionHitTest:contentPreventsDefault:userData:]):
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WKImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
(-[WKImmediateActionController didPerformActionMenuHitTest:contentPreventsDefault:userData:]): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/APIInjectedBundlePageContextMenuClient.h:
(API::InjectedBundle::PageContextMenuClient::prepareForImmediateAction):
(API::InjectedBundle::PageContextMenuClient::prepareForActionMenu): Deleted.
- WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
(WebKit::InjectedBundlePageContextMenuClient::prepareForImmediateAction):
(WebKit::InjectedBundlePageContextMenuClient::prepareForActionMenu): Deleted.
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/WebPageOverlay.cpp:
(WebKit::WebPageOverlay::actionContextForResultAtPoint):
- WebProcess/WebPage/WebPageOverlay.h:
(WebKit::WebPageOverlay::Client::actionContextForResultAtPoint):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::textIndicatorTransitionForImmediateAction):
(WebKit::WebPage::performImmediateActionHitTestAtLocation):
(WebKit::textIndicatorTransitionForActionMenu): Deleted.
(WebKit::WebPage::performActionMenuHitTestAtLocation): Deleted.
(WebKit::WebPage::selectLastActionMenuRange): Deleted.
(WebKit::WebPage::focusAndSelectLastActionMenuHitTestResult): Deleted.
Remove everything, except some enums that clients still refer to.
Also, leave SPI that used to be shared between immediate actions and
action menus intact, even if it had "action menu" in the name. We can
deprecate and rename in another patch... except for the very recently-added
support from r184106, which we'll revert entirely, removing WKBundlePageOverlayV2,
which was not adopted by any clients.
- 10:41 AM Changeset in webkit [184779] by
-
- 2 edits in trunk/Source/WebCore
MaskImageOperation code does not manage CachedImageClients correctly
https://bugs.webkit.org/show_bug.cgi?id=145276
rdar://problem/20959822
- rendering/RenderLayerMaskImageInfo.cpp:
(WebCore::RenderLayer::MaskImageInfo::removeMaskImageClients):
Followup fix: clear m_maskImageOperations vector.
- 10:36 AM Changeset in webkit [184778] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Merged r184773. rdar://problem/20830673
- 10:34 AM Changeset in webkit [184777] by
-
- 2 edits in tags/Safari-601.1.32.2.81/Source/WebKit2
Merged r184773. rdar://problem/20830673
- 10:24 AM Changeset in webkit [184776] by
-
- 13 edits4 adds in trunk
Allow DFGClobberize to return non-node constants that must be later created
https://bugs.webkit.org/show_bug.cgi?id=145272
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This adds a new LazyNode class in DFG that represents either a Node*,
or a FrozenValue* with a way to convert it to a Node* provided a block
to insert it into. DFGClobberize is converted to use LazyNode instead
of Node* when def()'ing values, which allows to now define the array's
length as well as the value of its various fields in NewArray and
NewArrayBuffer nodes.
We also introduce a Vector<uint32_t> in DFG::Graph to collect all the
values that can be used as index, in order to avoid def()'ing too many
values at once for big NewArrayBuffers.
HeapLocation had to be updated to use a LazyNode as its index to be
able to define array values.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGCSEPhase.cpp:
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
(JSC::DFG::DefMethodClobberize::operator()):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::freezeFragile):
- dfg/DFGGraph.h:
- dfg/DFGHeapLocation.h:
(JSC::DFG::HeapLocation::HeapLocation):
(JSC::DFG::HeapLocation::index):
(JSC::DFG::HeapLocation::hash):
- dfg/DFGLazyNode.cpp: Added.
(JSC::DFG::LazyNode::dump):
- dfg/DFGLazyNode.h: Added.
(JSC::DFG::LazyNode::LazyNode):
(JSC::DFG::LazyNode::setNode):
(JSC::DFG::LazyNode::isHashTableDeletedValue):
(JSC::DFG::LazyNode::isNode):
(JSC::DFG::LazyNode::op):
(JSC::DFG::LazyNode::asNode):
(JSC::DFG::LazyNode::asValue):
(JSC::DFG::LazyNode::hash):
(JSC::DFG::LazyNode::operator==):
(JSC::DFG::LazyNode::operator!=):
(JSC::DFG::LazyNode::ensureIsNode):
(JSC::DFG::LazyNode::operator->):
(JSC::DFG::LazyNode::operator*):
(JSC::DFG::LazyNode::operator!):
(JSC::DFG::LazyNode::operator UnspecifiedBoolType*):
(JSC::DFG::LazyNode::setFrozenValue):
- dfg/DFGPreciseLocalClobberize.h:
(JSC::DFG::PreciseLocalClobberizeAdaptor::def):
- dfg/DFGPutStackSinkingPhase.cpp:
LayoutTests:
- js/regress/script-tests/cse-new-array-buffer.js: Added.
(foo):
- js/regress/script-tests/cse-new-array.js: Added.
(foo):
- 10:24 AM Changeset in webkit [184775] by
-
- 10 edits in trunk/Source
Rework how the ResourceRequest user initiated property key is used.
Followup to https://bugs.webkit.org/show_bug.cgi?id=145281
Source/WebCore:
Reviewed by NOBODY (OOPS!).
- platform/mac/WebCoreSystemInterface.h:
- platform/network/cf/ResourceRequest.h:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::isUserInitiatedKey):
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
Source/WebKit/mac:
Reviewed by NOBODY (OOPS!).
- WebCoreSupport/WebSystemInterface.mm:
(WKResourceRequestIsUserInitiatedKey): Deleted.
(InitWebCoreSystemInterface): Deleted.
Source/WebKit2:
Reviewed by NOBODY (OOPS!).
- Shared/API/Cocoa/_WKNSURLRequestExtras.mm:
(-[NSURLRequest _web_isUserInitiated]):
(-[NSMutableURLRequest _web_setIsUserInitiated:]):
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(WKResourceRequestIsUserInitiatedKey): Deleted.
(InitWebCoreSystemInterface): Deleted.
- 10:19 AM Changeset in webkit [184774] by
-
- 7 edits in trunk/Source/WebKit2
Networking process sometimes suspended while WebContent runnable
https://bugs.webkit.org/show_bug.cgi?id=145291
<rdar://problem/21033029>
Reviewed by Andreas Kling.
There is an asymmetry in how the Networking process suspension is managed.
We drop the assertion (& suspend the process) whenever the WebProcess says
it is ready to suspend, but we only take the assertion (& resume execution)
when the WebContent process is actually resumed. This leaves a race – where
the WebContent process was willing to be suspended, but the UI app changed
its mind suspending it. Since the WebContent process never actually suspended
(we only prepared it to), we never send a resume, and since we never resume,
we never wake the Networking process.
The fix is pretty clean. A web process should take a token on the networking
process precisely whenever it holds an assertion on the web content process.
This also enables a nice refinement, that when holding a BG assertion on the
WebContent process we only need to hold a BG assertion on the networking
process.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didSetAssertionState):
- no-op
- UIProcess/Network/NetworkProcessProxy.h:
- added didSetAssertionState.
- UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::updateAssertionNow):
(WebKit::ProcessThrottler::updateAssertion):
(WebKit::ProcessThrottler::didConnectToProcess):
- whenever taking/updating the assertion, inform the client via didSetAssertionState.
- UIProcess/ProcessThrottlerClient.h:
- added didSetAssertionState.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didFinishLaunching):
removed initializeNetworkProcessActivityToken - this is taken via ProcessThrottler::didConnectToProcess.
(WebKit::WebProcessProxy::sendProcessDidResume):
- removed call to initializeNetworkProcessActivityToken - updated via didSetAssertionState.
(WebKit::WebProcessProxy::processReadyToSuspend):
- removed update of m_tokenForNetworkProcess - updated via didSetAssertionState.
(WebKit::WebProcessProxy::didSetAssertionState):
- update m_backgroundTokenForNetworkProcess/m_foregroundTokenForNetworkProcess.
(WebKit::WebProcessProxy::initializeNetworkProcessActivityToken): Deleted.
- updated via didSetAssertionState.
- UIProcess/WebProcessProxy.h:
- added didSetAssertionState, added separate FG/BG activity tokens for Networking process.
- 10:09 AM Changeset in webkit [184773] by
-
- 2 edits in trunk/Source/WebKit2
Fixed the fix for <rdar://problem/20830673> Symlink the WebKit dylib instead of just the framework directory
https://bugs.webkit.org/show_bug.cgi?id=145287
Reviewed by Anders Carlsson.
- WebKit2.xcodeproj/project.pbxproj: Give the symlink the correct destination.
- 10:04 AM Changeset in webkit [184772] by
-
- 5 edits in tags/Safari-601.1.32.2.81/Source
Versioning.
- 10:02 AM Changeset in webkit [184771] by
-
- 1 copy in tags/Safari-601.1.32.2.81
New tag.
- 9:31 AM Changeset in webkit [184770] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed build fix for ENABLE(TREE_DEBUGGING)
- editing/VisibleSelection.h:
- html/parser/HTMLElementStack.h:
- html/parser/HTMLFormattingElementList.h:
- 8:52 AM Changeset in webkit [184769] by
-
- 2 edits in trunk/Tools
Removed the Use Shrink To Fit button from the toolbar’s default set.
Rubber-stamped by Tim Horton.
- MiniBrowser/mac/BrowserWindow.xib:
- 4:36 AM Changeset in webkit [184768] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening 21st May.
https://bugs.webkit.org/show_bug.cgi?id=145250
Unreviewed.
Patch by Marcos Chavarría Teijeiro <mchavarria@igalia.com> on 2015-05-22
- platform/gtk/TestExpectations:
- 3:18 AM Changeset in webkit [184767] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Speed up new array construction in Array.prototype.splice().
<https://webkit.org/b/145303>
Reviewed by Benjamin Poulain.
Give splice() a fast path just like slice(), for indexing types where the backing
store can be memcpy'd. I generalized JSArray::fastSlice() a little bit so it works
for this optimization as well.
7% progression on Kraken/stanford-crypto-pbkdf2.
- runtime/JSArray.h:
- runtime/JSArray.cpp:
(JSC::JSArray::fastSlice): Tweak this to return JSArray*, and don't bother throwing
out-of-memory exceptions. Let the caller worry about that.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSlice): Update for fastSlice() changes.
(JSC::arrayProtoFuncSplice): If the object we're splicing out of is a bona fide
JSArray, use fastSlice() to create the returned array instead of doing a generic
get/put loop.
- 1:15 AM Changeset in webkit [184766] by
-
- 1 edit1 add in trunk/Source/WebCore/platform/gtk/po
[l10n] Add Catalan translation for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=142928
Patch by Jordi Mas <jmas@softcatala.org> on 2015-05-22
Reviewed by Carlos Garcia Campos.
- ca.po: Added.
- 1:03 AM Changeset in webkit [184765] by
-
- 4 edits in trunk
AX: Figure out why list-detection2.html test fails on GTK
https://bugs.webkit.org/show_bug.cgi?id=145273
Reviewed by Chris Fleizach.
Source/WebCore:
Platforms which expose rendered text content through the parent element "ignore" the
child renderers. This was causing AccessibilityList::childHasPseudoVisibleListItemMarker
to fail, which in turn caused the list detection heuristic to fail. Therefore add one
final check to this method to look for non-empty, non-whitespace text under the ::before
pseudo element.
No new tests; list-detection2.html now passes on GTK.
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers):
LayoutTests:
- platform/gtk/TestExpectations: Removed list-detection2.html from the list of expected failures.
- 1:01 AM Changeset in webkit [184764] by
-
- 9 edits in branches/safari-601.1.32.2-branch/Source/WebCore
Merged r184760. rdar://problem/21064692
- 1:00 AM Changeset in webkit [184763] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit/mac
Merged r184678.
- 12:59 AM Changeset in webkit [184762] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit/mac
Merged r184674.
- 12:59 AM Changeset in webkit [184761] by
-
- 29 edits2 copies in branches/safari-601.1.32.2-branch/Source
Merged r184670.
May 21, 2015:
- 11:57 PM Changeset in webkit [184760] by
-
- 9 edits in trunk/Source/WebCore
[iOS] Tell AVPlayerLayer when we enter optimized fullscreen mode.
https://bugs.webkit.org/show_bug.cgi?id=145289
Reviewed by Eric Carlson.
AVFoundation would normally already know that its AVPlayerLayer is in optimized
fullscreen mode, but because of the WebProcess/UIProcess split, they need to be
told explicitly in the WebProcess when the UIProcess enters optimized fullscreen
mode.
- html/HTMLMediaElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::fullscreenModeChanged): Pass to private().
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::setVideoFullscreenMode): Pass to m_private.
(WebCore::MediaPlayer::fullscreenMode): Pass to m_client.
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerFullscreenMode): Default implementation returns None.
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::setVideoFullscreenMode): Default implementation is a no-op.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): Get the fullscreen
mode from MediaPlayer and tell the AVPlayerLayer if the mode is optimized.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenMode):
Ditto.
- platform/spi/mac/AVFoundationSPI.h:
- 11:36 PM Changeset in webkit [184759] by
-
- 15 edits in branches/safari-601.1.32.2-branch/Source
Merged r184740. rdar://problem/21068522
- 11:35 PM Changeset in webkit [184758] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Merged r184739. rdar://problem/20892362
- 11:35 PM Changeset in webkit [184757] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Merged r184738. rdar://problem/20830673
- 11:34 PM Changeset in webkit [184756] by
-
- 5 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Merged r184726. rdar://problem/21031414
- 11:32 PM Changeset in webkit [184755] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
CPS rethreading should really get rid of GetLocals
https://bugs.webkit.org/show_bug.cgi?id=145290
Reviewed by Benjamin Poulain.
CPS rethreading is intended to get rid of redundant GetLocals. CSE can also do it, but
the idea is that you should be able to disable CSE and everything would still work. This
fixes a bug in CPS rethreading's GetLocal elimination: we should be calling replaceWith
rather than setReplacement, since setReplacement still leaves the original node.
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor): Fix the bug.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode): Eliminating GetLocals means that they turn into Check. We should handle Checks that have zero inputs.
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validateCPS): Add a validation for what a GetLocal should look like in ThreadedCPS.
- tests/stress/get-local-elimination.js: Added.
(foo):
- 11:12 PM Changeset in webkit [184754] by
-
- 15 edits3 adds in trunk
AX: [GTK] Implement computedRoleString in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=128420
Reviewed by Chris Fleizach.
Source/WebCore:
Expose all ARIA roles (not just landmark-related roles) via an "xml-roles" AtkObject
attribute as per http://www.w3.org/TR/core-aam-1.1/#roleMappingGeneralRules
Expose non-empty computed role strings via AtkObject attribute named "computed-role".
Currently the computed role and the ARIA role value happen to be the same string, but
that might not always be the case. And AtkObject attributes are cheap.
Test: platform/gtk/accessibility/xml-roles-exposed.html.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
Tools:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::computedRoleString): Implemented.
LayoutTests:
- platform/gtk/TestExpectations: Removed roles-computedRoleString from the failing test.
- platform/gtk/accessibility/image-link-expected.txt: Updated to reflect the new object attribute.
- platform/gtk/accessibility/image-map2-expected.txt: Updated to reflect the new object attribute.
- platform/gtk/accessibility/lists-expected.txt: Updated to reflect the new object attribute.
- platform/gtk/accessibility/roles-computedRoleString-expected.txt: Added.
- platform/gtk/accessibility/table-attributes-expected.txt: Updated to reflect the new object attribute.
- platform/gtk/accessibility/table-cell-spans-expected.txt: Updated to reflect the new object attribute.
- platform/gtk/accessibility/table-cells-expected.txt: Updated to reflect the new object attribute.
- platform/gtk/accessibility/table-detection-expected.txt: Updated to reflect the new object attribute.
- platform/gtk/accessibility/table-sections-expected.txt: Updated to reflect the new object attribute.
- platform/gtk/accessibility/table-with-rules-expected.txt: Updated to reflect the new object attribute.
- platform/gtk/accessibility/xml-roles-exposed-expected.txt: Added.
- platform/gtk/accessibility/xml-roles-exposed.html: Added.
- 10:46 PM Changeset in webkit [184753] by
-
- 5 edits in branches/safari-600.7-branch/Source
Versioning.
- 10:46 PM Changeset in webkit [184752] by
-
- 5 edits in branches/safari-601.1.32-branch/Source
Versioning.
- 10:46 PM Changeset in webkit [184751] by
-
- 5 edits in branches/safari-601.1.32.2-branch/Source
Versioning.
- 9:35 PM Changeset in webkit [184750] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Give Toolbar buttons an active style
https://bugs.webkit.org/show_bug.cgi?id=145292
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-21
Reviewed by Timothy Hatcher.
- UserInterface/Views/ButtonToolbarItem.css:
(.toolbar .item.button:active):
- 8:59 PM Changeset in webkit [184749] by
-
- 8 edits2 adds in trunk
MaskImageOperation code does not manage CachedImageClients correctly
https://bugs.webkit.org/show_bug.cgi?id=145276
Source/WebCore:
rdar://problem/20959822
Reviewed by Andreas Kling.
Test: css3/masking/mask-image-client-crash.html
- platform/graphics/MaskImageOperation.cpp:
(WebCore::MaskImageOperation::isMaskLoaded):
(WebCore::MaskImageOperation::setImage):
If image changes transfer the clients to the new image.
(WebCore::MaskImageOperation::setRenderLayerImageClient):
Always use setImage.
(WebCore::MaskImageOperation::notifyFinished):
- platform/graphics/MaskImageOperation.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerMaskImageInfo.cpp:
(WebCore::RenderLayer::MaskImageInfo::~MaskImageInfo):
(WebCore::RenderLayer::MaskImageInfo::updateMaskImageClients):
Store the MaskImageOperations where we added clients.
(WebCore::RenderLayer::MaskImageInfo::removeMaskImageClients):
Make sure we remove the clients from the same MaskImageOperations we added them to.
- rendering/RenderLayerMaskImageInfo.h:
LayoutTests:
Reviewed by Andreas Kling.
- css3/masking/mask-image-client-crash-expected.txt: Added.
- css3/masking/mask-image-client-crash.html: Added.
- 7:54 PM Changeset in webkit [184748] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Dashboard debugger information can be clipped
https://bugs.webkit.org/show_bug.cgi?id=144209
Reviewed by Timothy Hatcher.
- UserInterface/Views/DashboardContainerView.css:
(.toolbar .dashboard-container):
Make dashboard flexible by using vw (viewport width units).
- UserInterface/Views/DefaultDashboardView.css:
(.toolbar .dashboard.default):
Center default dashboard icons in the middle, don't spread them along the dashboard.
- 7:39 PM Changeset in webkit [184747] by
-
- 10 edits2 adds in trunk/Source/JavaScriptCore
Object allocation sinking phase should explicitly create bottom values for CreateActivation sink candidates and CreateActivation should have SymbolTable as a child node
https://bugs.webkit.org/show_bug.cgi?id=145192
Reviewed by Filip Pizlo.
When we sink CreateActivation and generate MaterializeCreateActivation
in the object allocation sinking phase, we now explictly add PutHints for
all variables on the activation setting those variables to their default value
(undefined for Function activations and soon to be JS Empty Value for block scope activations).
This allows us to remove code that fills FTL fast activation allocations with Undefined.
This patch also adds the constant SymbolTable as an OpInfo of CreateActivation and MaterializeCreateActivation
nodes. This is in preparation for ES6 block scoping which will introduce a new
op code that gets lowered to CreateActivation.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasCellOperand):
(JSC::DFG::Node::cellOperand):
- dfg/DFGObjectAllocationSinkingPhase.cpp:
(JSC::DFG::ObjectAllocationSinkingPhase::lowerNonReadingOperationsOnPhantomAllocations):
(JSC::DFG::ObjectAllocationSinkingPhase::handleNode):
(JSC::DFG::ObjectAllocationSinkingPhase::createMaterialize):
(JSC::DFG::ObjectAllocationSinkingPhase::populateMaterialize):
- dfg/DFGPromotedHeapLocation.cpp:
(WTF::printInternal):
- dfg/DFGPromotedHeapLocation.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCreateActivation):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCreateActivation):
(JSC::FTL::LowerDFGToLLVM::compileMaterializeCreateActivation):
- ftl/FTLOperations.cpp:
(JSC::FTL::operationMaterializeObjectInOSR):
- tests/stress/activation-sink-default-value.js: Added.
(bar):
- tests/stress/activation-sink-osrexit-default-value.js: Added.
(foo.set result):
- 6:22 PM Changeset in webkit [184746] by
-
- 1 copy in tags/Safari-601.1.32.5
New tag.
- 6:15 PM Changeset in webkit [184745] by
-
- 5 edits in trunk
Update Autofill button icon
https://bugs.webkit.org/show_bug.cgi?id=145191
<rdar://problem/20178942>
Reviewed by Jessie Berlin.
Source/WebCore:
- css/html.css:
(input::-webkit-auto-fill-button):
(input::-webkit-auto-fill-button:active):
(input::-webkit-auto-fill-button:hover):
LayoutTests:
Update expected results.
- fast/forms/input-auto-fill-button-expected.txt:
- platform/mac-mavericks/fast/forms/input-auto-fill-button-expected.txt:
- 5:43 PM Changeset in webkit [184744] by
-
- 2 edits in tags/Safari-601.1.32.2.80/Source/WebKit2
Merged r184738. rdar://problem/20830673
- 5:41 PM Changeset in webkit [184743] by
-
- 5 edits in tags/Safari-601.1.32.2.80/Source
Versioning.
- 5:39 PM Changeset in webkit [184742] by
-
- 1 copy in tags/Safari-601.1.32.2.80
New tag.
- 5:35 PM Changeset in webkit [184741] by
-
- 12 edits2 adds in trunk/Source
Add an "initiated by user gesture" flag to ResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=145281
Reviewed by Alex Christensen.
Source/WebCore:
Allow WebKit to tell WebCore what the new property key is:
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Add the flag to ResourceRequest, and make sure it encodes/decodes:
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::initiatedByUserGesture):
(WebCore::ResourceRequestBase::setInitiatedByUserGesture):
(WebCore::ResourceRequestBase::encodeWithoutPlatformData):
(WebCore::ResourceRequestBase::decodeWithoutPlatformData):
Set/get the property on native CFURLRequestRefs:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
Set/get the property on native NSURLRequests:
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(WKResourceRequestIsUserInitiatedKey):
(InitWebCoreSystemInterface):
Source/WebKit2:
Expose a new category on NSURLRequest to allow SPI clients to easily set/get the flag:
- Shared/API/Cocoa/_WKNSURLRequestExtras.h: Added.
- Shared/API/Cocoa/_WKNSURLRequestExtras.mm: Added.
(-[NSURLRequest _web_isUserInitiated]):
(-[NSMutableURLRequest _web_setIsUserInitiated:]):
- WebKit2.xcodeproj/project.pbxproj:
Expose the new property key to WebCore:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(WKResourceRequestIsUserInitiatedKey):
(InitWebCoreSystemInterface):
- 5:34 PM Changeset in webkit [184740] by
-
- 15 edits in trunk/Source
Rollout <http://trac.webkit.org/changeset/183909>
(https://bugs.webkit.org/show_bug.cgi?id=144657)
Revert <http://trac.webkit.org/changeset/183909> since pausing the database
thread prevents in-progress transactions from completing. We need to think
about this change some more.
Source/WebCore:
- Modules/webdatabase/AbstractDatabaseServer.h:
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::setPauseAllDatabases): Deleted.
- Modules/webdatabase/DatabaseManager.h:
- Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::setPauseAllDatabases): Deleted.
- Modules/webdatabase/DatabaseServer.h:
Source/WebKit2:
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _applicationDidEnterBackground:]): Deleted.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applicationDidEnterBackground): Deleted.
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::setPauseAllDatabases): Deleted.
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::applicationWillEnterForeground): Deleted.
(WebKit::WebPage::applicationDidEnterBackground): Deleted.
- 5:31 PM Changeset in webkit [184739] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Crash when taking a snapshot of a large PDF.
https://bugs.webkit.org/show_bug.cgi?id=145286
rdar://problem/20892362
Reviewed by Tim Horton.
The code for the PDF case was incorrectly computing the snapshot rect.
On top of that drawViewHierarchyInRect was ignoring the rect and
always creating an image using the view bounds causing the crash.
We are now always using the IOSurface if we are parented or
an image context when we are not.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
- 5:29 PM Changeset in webkit [184738] by
-
- 2 edits in trunk/Source/WebKit2
Symlink the WebKit dylib instead of just the framework directory
https://bugs.webkit.org/show_bug.cgi?id=145287
rdar://problem/20830673
Reviewed by Dan Bernstein.
- WebKit2.xcodeproj/project.pbxproj:
- 5:12 PM Changeset in webkit [184737] by
-
- 1 copy in tags/Safari-601.1.32.2.5
New tag.
- 4:33 PM Changeset in webkit [184736] by
-
- 10 edits1 move5 adds3 deletes in trunk/Source/WebInspectorUI
Web Inspector: Improve the UI of the type profiler popover
https://bugs.webkit.org/show_bug.cgi?id=140737
Reviewed by Timothy Hatcher.
Display TypeDescriptions in a Tree similiar to ObjectTrees.
Currently the only information we have in a TypeDescription
is the property names, and not their types, so all we can
display in the tree are names.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Controllers/TypeTokenAnnotator.js:
(WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
- UserInterface/Main.html:
- UserInterface/Models/ScriptSyntaxTree.js:
(WebInspector.ScriptSyntaxTree.prototype.updateTypes):
- UserInterface/Models/StructureDescription.js: Added.
(WebInspector.StructureDescription):
(WebInspector.StructureDescription.fromPayload):
(WebInspector.StructureDescription.prototype.get fields):
(WebInspector.StructureDescription.prototype.get optionalFields):
(WebInspector.StructureDescription.prototype.get constructorName):
(WebInspector.StructureDescription.prototype.get prototypeStructure):
(WebInspector.StructureDescription.prototype.get imprecise):
- UserInterface/Models/TypeDescription.js: Added.
(WebInspector.TypeDescription):
(WebInspector.TypeDescription.fromPayload):
(WebInspector.TypeDescription.prototype.get leastCommonAncestor):
(WebInspector.TypeDescription.prototype.get typeSet):
(WebInspector.TypeDescription.prototype.get structures):
(WebInspector.TypeDescription.prototype.get valid):
(WebInspector.TypeDescription.prototype.get truncated):
- UserInterface/Models/TypeSet.js:
(WebInspector.TypeSet):
(WebInspector.TypeSet.prototype.get primitiveTypeNames):
- UserInterface/Views/ObjectTreeView.js:
(WebInspector.ObjectTreeView.prototype._updateChildren):
- UserInterface/Views/Section.css: Removed.
- UserInterface/Views/Section.js: Removed.
- UserInterface/Views/SourceCodeTextEditor.css:
(.popover .expandable):
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.showPopoverForTypes):
(WebInspector.SourceCodeTextEditor.prototype._populateWithScriptContent):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForObject):
- UserInterface/Views/TypePropertiesSection.js: Removed.
- UserInterface/Views/TypeTokenView.js:
(WebInspector.TypeTokenView):
(WebInspector.TypeTokenView.titleForPopover):
(WebInspector.TypeTokenView.prototype.update):
(WebInspector.TypeTokenView.prototype._setUpMouseoverHandlers):
(WebInspector.TypeTokenView.prototype._shouldShowPopover):
(WebInspector.TypeTokenView.prototype._displayTypeName):
- UserInterface/Views/TypeTreeElement.css: Added.
(.type-tree-element):
(.type-tree-element > .titles):
(.type-tree-element > .disclosure-button):
(.type-tree-element.parent > .disclosure-button):
(.type-tree-element.parent.expanded > .disclosure-button):
(.type-tree-element > .icon):
(.type-tree-element.prototype):
(.type-tree-element.prototype:focus):
(.type-tree-element.prototype + ol):
- UserInterface/Views/TypeTreeElement.js: Added.
(WebInspector.TypeTreeElement):
(WebInspector.TypeTreeElement.prototype.get name):
(WebInspector.TypeTreeElement.prototype.get isPrototype):
(WebInspector.TypeTreeElement.prototype.onpopulate):
(WebInspector.TypeTreeElement.prototype.onexpand):
- UserInterface/Views/TypeTreeView.css: Renamed from Source/WebInspectorUI/UserInterface/Views/PropertiesSection.js.
(.type-tree):
(.type-tree-outline):
(.type-tree-outline li):
(.type-tree-outline ol):
(.type-tree-outline ol.expanded):
(.type-tree-outline li .empty-message):
- UserInterface/Views/TypeTreeView.js: Added.
(WebInspector.TypeTreeView):
(WebInspector.TypeTreeView.prototype.get typeDescription):
(WebInspector.TypeTreeView.prototype.get element):
(WebInspector.TypeTreeView.prototype.get treeOutline):
(WebInspector.TypeTreeView.prototype._populate):
- 4:30 PM Changeset in webkit [184735] by
-
- 1 copy in tags/Safari-600.7.9
New tag.
- 3:45 PM Changeset in webkit [184734] by
-
- 19 edits in trunk/Source/WebCore
r184718 and r184725 caused four tests to begin crashing
Unreviewed rollback.
Tests that started crashing:
svg/carto.net/textbox.svg svg/custom/tref-clone-crash.html svg/custom/use-animation-in-fill.html svg/custom/use-multiple-on-nested-disallowed-font.html
- svg/SVGAnimateElementBase.cpp:
(WebCore::propertyTypesAreConsistent):
- svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
- svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::executeAction):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::parseAttribute):
- svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::~SVGCursorElement):
(WebCore::SVGCursorElement::isSupportedAttribute):
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::isElementWithPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):
(WebCore::SVGDocumentExtensions::rebuildElements):
- svg/SVGElement.cpp:
(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap):
(WebCore::attributeNameToAnimatedPropertyTypeMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
(WebCore::cssPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
(WebCore::hasLoadListener):
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):
- svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::begin):
(WebCore::SVGPathByteStream::end):
(WebCore::SVGPathByteStream::append):
(WebCore::SVGPathByteStream::clear):
(WebCore::SVGPathByteStream::isEmpty):
- svg/SVGPathUtilities.cpp:
(WebCore::appendSVGPathByteStreamFromSVGPathSeg):
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseBeginOrEnd):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
(WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):
- svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::clearResultsRecursive):
- svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::addBuiltinEffects):
- svg/properties/SVGAnimatedProperty.cpp:
(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):
- svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::detachListWrappersAndResize):
- svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):
- 1:27 PM Changeset in webkit [184733] by
-
- 6 edits in branches/safari-601.1.32.2-branch/Source/WebCore
Merged r184728. rdar://problem/21051039
- 1:26 PM Changeset in webkit [184732] by
-
- 6 edits in branches/safari-601.1.32-branch/Source/WebCore
Merged r184728. rdar://problem/21051039
- 12:53 PM Changeset in webkit [184731] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Merged r184514. rdar://problem/20368630
- 12:52 PM Changeset in webkit [184730] by
-
- 12 edits1 copy in branches/safari-601.1.32.2-branch/Source/WebKit2
Merged r184503. rdar://problem/20368630
- 12:51 PM Changeset in webkit [184729] by
-
- 17 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Merged r184370. rdar://problem/20368630
- 12:37 PM Changeset in webkit [184728] by
-
- 6 edits in trunk/Source/WebCore
Scroll-snap points needs to be updated during programmatic scrolls
https://bugs.webkit.org/show_bug.cgi?id=145216
<rdar://problem/21051039>
Reviewed by Dean Jackson.
Whenever we adjust the current scroll position, make sure we also update the current
active scroll snap offset index (if applicable).
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation): Call the new 'updateActiveScrollSnapIndexForOffset'
method after moving to a new position.
(WebCore::ScrollAnimator::setCurrentPosition): Ditto.
(WebCore::ScrollAnimator::updateActiveScrollSnapIndexForOffset): New method. Asks the scroll controller to
identify the closest scroll snap offset index. If it finds something relevant, update the ScrollableArea state
to track these new values.
- platform/ScrollAnimator.h:
- platform/cocoa/ScrollController.h:
(WebCore::ScrollController::activeScrollSnapIndexDidChange):
(WebCore::ScrollController::setScrollSnapIndexDidChange):
- platform/cocoa/ScrollController.mm:
(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset): Added. Find the closest relevant scroll snap offset
index for the given scroll offset, and update the internal scroll snap state to reflect it.
(WebCore::ScrollController::setActiveScrollSnapIndicesForOffset): Given the x and y offset for a scroll,
set the relevant scroll snap offset indices.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollTo): Call the new 'updateActiveScrollSnapIndexForOffset' method
after moving to a new position.
(WebCore::ScrollAnimatorMac::immediateScrollBy): Ditto.
- 12:12 PM Changeset in webkit [184727] by
-
- 2 edits in trunk/Source/WebKit2
WKWebsiteDataStore doesn't track and remove iOS Safari's offline application cache entries
https://bugs.webkit.org/show_bug.cgi?id=145279
rdar://problem/20657912
Reviewed by Dan Bernstein.
Special-case iOS Safari and WebApp when computing the default application cache directory.
- UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:
(API::applicationCacheDirectory):
(API::WebsiteDataStore::defaultDataStoreConfiguration):
- 11:54 AM Changeset in webkit [184726] by
-
- 5 edits in trunk/Source/WebKit2
Add a _WKWebKitContentExtensionStore initializer that takes a path.
https://bugs.webkit.org/show_bug.cgi?id=145269 and work towards <rdar://problem/21031414>
Reviewed by Anders Carlsson.
- UIProcess/API/APIUserContentExtensionStore.cpp:
(API::UserContentExtensionStore::storeWithPath):
- UIProcess/API/APIUserContentExtensionStore.h:
- UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
- UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:
(+[_WKUserContentExtensionStore storeWithURL:]):
- 11:32 AM Changeset in webkit [184725] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- svg/SVGAnimateElementBase.cpp:
(WebCore::propertyTypesAreConsistent): should be type.properties, not type.properties().
- 11:24 AM Changeset in webkit [184724] by
-
- 6 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Merged r184716.
- 11:08 AM Changeset in webkit [184723] by
-
- 4 edits in trunk/Source/WebCore
[Streams API] Remove ReadableStreamReader closed promise internal slot
https://bugs.webkit.org/show_bug.cgi?id=145215
Reviewed by Darin Adler.
Using the new JSPromiseDeferred member generated by binding generator to handle closed promise attribute.
Removed internal slots routines previously used to ensure persistency of the promise.
Existing tests cover the changes.
- bindings/js/JSReadableStreamReaderCustom.cpp:
(WebCore::JSReadableStreamReader::closed):
(WebCore::JSReadableStreamReader::cancel): Deleted.
(WebCore::JSReadableStreamReader::releaseLock): Deleted.
- bindings/js/ReadableJSStream.cpp:
(WebCore::getPropertyFromObject): Deleted.
(WebCore::callFunction): Deleted.
(WebCore::ReadableJSStream::Source::create): Deleted.
(WebCore::ReadableJSStream::Source::Source): Deleted.
- bindings/js/ReadableJSStream.h:
- 10:52 AM Changeset in webkit [184722] by
-
- 3 edits in trunk/Source/WebCore
Media Controls stop updating after hovering for a few seconds.
https://bugs.webkit.org/show_bug.cgi?id=144770.
<rdar://problem/19823121>
Reviewed by Jer Noble.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createBase):
We should never hide controls immediately as a result of mousing out of the controls.
It should only happen when the mouse leaves the video entirely.
(Controller.prototype.updateTimelineMetricsIfNeeded):
Don’t update if controls are hidden, timeline dimensions will be 0.
(Controller.prototype.handlePanelTransitionEnd):
Instead of adjusting visibility via adding and removing classes,
remove controls entirely from the tree.
(Controller.prototype.showControls):
Add controls back into the tree when showing controls.
(Controller.prototype.updateForShowingControls):
Helper method for showControls.
(Controller.prototype.controlsAreHidden):
Controls also hidden if removed from tree.
Remove forceUpdate logic, no longer necessary.
(Controller.prototype.handleDurationChange):
(Controller.prototype.updateProgress):
(Controller.prototype.updateTime):
Override methods to use add and remove panelContainer for iOS.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handlePanelTransitionEnd):
(ControllerIOS.prototype.showControls):
(ControllerIOS.prototype.controlsAreHidden):
- 10:45 AM Changeset in webkit [184721] by
-
- 4 edits in trunk/LayoutTests
AX: improve list heuristics (presentational use versus actual lists)
https://bugs.webkit.org/show_bug.cgi?id=134187
Unreviewed layout test fixage.
Skip the list-detection2.html test on GTK until it can be investigated.
Fix a failing test on GTK that needed an update after the last set of changes.
Skip the test on windows until a time someone can decide if we even expose or need lists in Windows AX API.
- platform/gtk/TestExpectations:
- platform/gtk/accessibility/list-detection-expected.txt:
- platform/win/TestExpectations:
- 10:45 AM Changeset in webkit [184720] by
-
- 2 edits in trunk/Source/WebCore
Regression(r179293): We no longer call destroyDecodedData() on CachedResources on memory pressure
https://bugs.webkit.org/show_bug.cgi?id=145270
<rdar://problem/20734901>
Reviewed by Andreas Kling.
We no longer call destroyDecodedData() on CachedResources on memory
pressure after r179293. In r179293, we started calling
MemoryCache::evictResources() on memory pressure instead of
MemoryCache::pruneToPercentage(0). However, unlike
MemoryCache::pruneToPercentage(), it appears
MemoryCache::evictResources() removes the CachedResources from the
memory cache without calling destroyDecodedData() on them.
This caused a regression on Membuster.
This patch now calls MemoryCache::pruneLiveResourcesToSize(0) on
critical memory pressure, instead of evictResources(). We don't need to
call pruneDeadResourcesToSize(0) here because the non-critical memory
pressure handler already takes care of this.
During local testing, this change seemed to decrease the overall memory
usage of WebProcesses by ~10MB on Membuster (tested on Yosemite).
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseNoncriticalMemory):
(WebCore::MemoryPressureHandler::releaseCriticalMemory):
- 10:36 AM Changeset in webkit [184719] by
-
- 3 edits2 adds in trunk
SVG as image uses very tiny default font-size
https://bugs.webkit.org/show_bug.cgi?id=68090
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-05-21
Reviewed by Darin Adler.
Source/WebCore:
When loading a document, WebKit creates a Page object and then changes its setting
from the browser's preferences. This is true for interactive resources also, such as a
stand-alone SVG or an SVG embedded in an <object> tag for example. For non-interactive
resources, like an SVG embedded in an <img> tag for example, this function is called
after loading the resource is finished. This function creates an artificial page and
fabricates a scoped settings for it. This turns out to be problematic for cases like
the default font size because its initial value is zero. We cannot go from WebCore to
WebKit to ask for the global settings. But we can inherit the global settings from the
the master page. This is not the best solution because of two reasons. (1) Once the
resource is cached and the styles for the text elements are calculated, nothing can
change the values of styles except removing the resource itself from the cache if the
browser's preferences change. Also there is no mechanism to notify this artificial
page if the browser's preferences change. (2) An image like a non-interactive SVG,
should be displayed the same way regardless of the browser's preferences. A user may
be able to change the default font size for other text. But this should not affect
images even if they are vector images like SVG. An easy and more agreeable solution
is to hard-code the default font size for this case and do not depend on the global
settings at all.
Test: svg/text/text-default-font-size.html
- page/Settings.in: Set the initial value of the setting defaultFontSize to be 16.
LayoutTests:
- svg/text/text-default-font-size-expected.html: Added.
- svg/text/text-default-font-size.html: Added.
Ensure the default font size for non-interactive SVG images is not zero.
- 10:34 AM Changeset in webkit [184718] by
-
- 19 edits in trunk/Source/WebCore
Use modern for-loops in WebCore/svg.
https://bugs.webkit.org/show_bug.cgi?id=145209
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-05-21
Reviewed by Darin Adler.
No new tests, no new tests.
- svg/SVGAnimateElementBase.cpp:
(WebCore::propertyTypesAreConsistent):
- svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
- svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::executeAction):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::parseAttribute):
- svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::~SVGCursorElement):
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::isElementWithPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeAllTargetReferencesForElement):
- svg/SVGElement.cpp:
(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):
(WebCore::hasLoadListener):
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):
- svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::append):
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseBeginOrEnd):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
(WebCore::SVGSMILElement::notifyDependentsIntervalChanged):
(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):
- svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::clearResultsRecursive):
- svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::addBuiltinEffects):
- svg/properties/SVGAnimatedProperty.cpp:
(WebCore::SVGAnimatedProperty::~SVGAnimatedProperty):
- svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::detachListWrappersAndResize):
- svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::clearContextAndRoles):
- 10:27 AM Changeset in webkit [184717] by
-
- 2 edits in trunk/Source/JavaScriptCore
MSVC internal compiler error when compiling TemplateRegistryKey class.
https://bugs.webkit.org/show_bug.cgi?id=145259
Reviewed by Alex Christensen.
MSVC is not able to handle the brace initialization of a class member in this case.
- runtime/TemplateRegistryKey.h:
- 10:10 AM Changeset in webkit [184716] by
-
- 6 edits in trunk/Source/WebKit2
Build fix. Silence some deprecation warnings.
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel _presentPopoverWithContentViewController:animated:]):
- UIProcess/ios/forms/WKFormInputControl.mm:
(-[WKDateTimePopover initWithView:datePickerMode:]):
- UIProcess/ios/forms/WKFormPopover.h:
- UIProcess/ios/forms/WKFormPopover.mm:
- UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectPopover initWithView:hasGroups:]):
- 8:49 AM Changeset in webkit [184715] by
-
- 2 edits in trunk/LayoutTests
streams/reference-implementation/readable-stream.html should now pass
https://bugs.webkit.org/show_bug.cgi?id=145266
Unreviewed.
- TestExpectations: removing falky expectation of streams/reference-implementation/readable-stream.html.
- 8:24 AM Changeset in webkit [184714] by
-
- 5 edits2 copies in branches/safari-601.1.32.2-branch
Merged r184308. rdar://problem/20895753
- 5:29 AM Changeset in webkit [184713] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix the !ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) build after r184337
https://bugs.webkit.org/show_bug.cgi?id=145248
Reviewed by Yusuke Suzuki.
- bytecompiler/BytecodeGenerator.cpp:
- bytecompiler/BytecodeGenerator.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseMemberExpression):
- 5:28 AM Changeset in webkit [184712] by
-
- 2 edits2 deletes in trunk/Tools
[EFL] Bump libsoup version to 2.50.0
https://bugs.webkit.org/show_bug.cgi?id=145127
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules:
- efl/patches/soup-clang-warning-fix1.patch: Removed.
- efl/patches/soup-clang-warning-fix2.patch: Removed.
- 5:02 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 3:51 AM Changeset in webkit [184711] by
-
- 3 edits in trunk/Source/WebKit2
[EFL] Remove an unused private field from EwkPopupMenuItem class
https://bugs.webkit.org/show_bug.cgi?id=145249
Reviewed by Gyuyoung Kim.
- UIProcess/API/efl/ewk_popup_menu.cpp:
(EwkPopupMenu::EwkPopupMenu):
- UIProcess/API/efl/ewk_popup_menu_private.h:
- 2:27 AM Changeset in webkit [184710] by
-
- 32 edits in trunk/Source/WebKit2
[EFL] Fix mismatched-tags warnings in UIProcess/API/efl
https://bugs.webkit.org/show_bug.cgi?id=145129
Reviewed by Gyuyoung Kim.
- UIProcess/API/efl/EwkViewCallbacks.h:
- UIProcess/API/efl/ewk_application_cache_manager.h:
- UIProcess/API/efl/ewk_auth_request.h:
- UIProcess/API/efl/ewk_back_forward_list.h:
- UIProcess/API/efl/ewk_back_forward_list_item.h:
- UIProcess/API/efl/ewk_color_picker.h:
- UIProcess/API/efl/ewk_context.h:
- UIProcess/API/efl/ewk_context_menu_item.h:
- UIProcess/API/efl/ewk_cookie_manager.h:
- UIProcess/API/efl/ewk_database_manager.h:
- UIProcess/API/efl/ewk_download_job.h:
- UIProcess/API/efl/ewk_error.h:
- UIProcess/API/efl/ewk_favicon_database.h:
- UIProcess/API/efl/ewk_file_chooser_request.h:
- UIProcess/API/efl/ewk_form_submission_request.h:
- UIProcess/API/efl/ewk_navigation_data.h:
- UIProcess/API/efl/ewk_navigation_policy_decision.h:
- UIProcess/API/efl/ewk_object.h:
- UIProcess/API/efl/ewk_page_group.h:
- UIProcess/API/efl/ewk_popup_menu.h:
- UIProcess/API/efl/ewk_popup_menu_item.h:
- UIProcess/API/efl/ewk_security_origin.h:
- UIProcess/API/efl/ewk_settings.h:
- UIProcess/API/efl/ewk_storage_manager.h:
- UIProcess/API/efl/ewk_url_request.h:
- UIProcess/API/efl/ewk_url_response.h:
- UIProcess/API/efl/ewk_url_scheme_request.h:
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/ewk_window_features.h:
- WebProcess/InjectedBundle/API/efl/ewk_extension.h:
- WebProcess/InjectedBundle/API/efl/ewk_page.h:
- 2:23 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 12:26 AM Changeset in webkit [184709] by
-
- 47 edits in trunk/Source/WebCore
Purge PassRefPtr in WebCore/Modules
https://bugs.webkit.org/show_bug.cgi?id=145112
Reviewed by Darin Adler.
As a step to remove PassRefPtr, this patch replaces PassRefPtr with Ref or RefPtr
depends on null of return value.
No new tests, no behavior changes.
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::create):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::create):
(WebCore::MediaKeys::createSession):
- Modules/encryptedmedia/MediaKeys.h:
- Modules/gamepad/Gamepad.h:
- Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::gamepadFromPlatformGamepad):
- Modules/gamepad/deprecated/Gamepad.h:
- Modules/geolocation/GeolocationError.h:
(WebCore::GeolocationError::create):
- Modules/geolocation/GeolocationPosition.h:
(WebCore::GeolocationPosition::create):
- Modules/geolocation/Geoposition.h:
(WebCore::Geoposition::create):
- Modules/geolocation/PositionError.h:
(WebCore::PositionError::create):
- Modules/geolocation/PositionOptions.h:
(WebCore::PositionOptions::create):
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::create):
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::create):
- Modules/mediasource/MediaSource.h:
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::create):
- Modules/mediastream/RTCDataChannel.h:
- Modules/mediastream/RTCIceCandidate.cpp:
(WebCore::RTCIceCandidate::create):
- Modules/mediastream/RTCIceCandidate.h:
- Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::create):
- Modules/webaudio/OfflineAudioContext.h:
- Modules/webaudio/OfflineAudioDestinationNode.h:
(WebCore::OfflineAudioDestinationNode::create):
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::create):
- Modules/webaudio/OscillatorNode.h:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::runTransaction):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::originLockFor):
- Modules/webdatabase/DatabaseTracker.h:
- Modules/webdatabase/SQLError.h:
(WebCore::SQLError::create):
- Modules/webdatabase/SQLResultSet.h:
(WebCore::SQLResultSet::create):
- Modules/webdatabase/SQLResultSetRowList.h:
(WebCore::SQLResultSetRowList::create):
- Modules/webdatabase/SQLStatementBackend.cpp:
(WebCore::SQLStatementBackend::create):
- Modules/webdatabase/SQLStatementBackend.h:
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
- Modules/webdatabase/SQLTransactionBackend.h:
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::create):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::create):
- Modules/websockets/WebSocket.h:
- Modules/websockets/WebSocketChannel.h:
(WebCore::WebSocketChannel::create):
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):
- editing/InsertListCommand.h:
(WebCore::InsertListCommand::create):
- workers/Worker.cpp:
(WebCore::Worker::create):
- workers/Worker.h:
- xml/XPathExpression.cpp:
(WebCore::XPathExpression::createExpression):
(WebCore::XPathExpression::evaluate):
- xml/XPathExpression.h:
- 12:26 AM Changeset in webkit [184708] by
-
- 4 edits in trunk/Source/WebKit2
Fix mismatched-tags warnings related to CoordinatedGraphics
https://bugs.webkit.org/show_bug.cgi?id=145130
Reviewed by Darin Adler.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
May 20, 2015:
- 11:39 PM Changeset in webkit [184707] by
-
- 5 edits in branches/safari-601.1.32.2-branch/Source/WebCore
Merge r184654. rdar://problem/21044514
- 11:39 PM Changeset in webkit [184706] by
-
- 4 edits in branches/safari-601.1.32.2-branch/Source/JavaScriptCore
Merge r184652. rdar://problem/21002666
- 11:39 PM Changeset in webkit [184705] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Merge r184679. rdar://problem/20990162
- 11:39 PM Changeset in webkit [184704] by
-
- 5 edits in branches/safari-601.1.32.2-branch/Source
Merge r184681. rdar://problem/20924495
- 10:55 PM Changeset in webkit [184703] by
-
- 4 edits6 adds2 deletes in trunk
[GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
https://bugs.webkit.org/show_bug.cgi?id=145117
Reviewed by Csaba Osztrogonác.
Source/WTF:
Move the MainThreadGtk, RunLoopGtk and WorkQueueGtk implementation files from
Source/WTF/wtf/gtk/ to Source/WTF/wtf/glib/. These implementations are not
GTK-specific and only depend on GLib, so they are renamed as well.
There are other such implementations under Source/WTF/wtf/gobject/ (GObject
is just a subset of GLib) that will be moved under the new directory in
future patches.
- wtf/PlatformGTK.cmake:
- wtf/glib/MainThreadGLib.cpp: Renamed from Source/WTF/wtf/gtk/MainThreadGtk.cpp.
(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):
- wtf/glib/RunLoopGLib.cpp: Renamed from Source/WTF/wtf/gtk/RunLoopGtk.cpp.
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):
- wtf/glib/WorkQueueGLib.cpp: Renamed from Source/WTF/wtf/gtk/WorkQueueGtk.cpp.
(WTF::WorkQueue::platformInitialize):
(WTF::WorkQueue::platformInvalidate):
(WTF::WorkQueue::registerSocketEventHandler):
(WTF::WorkQueue::unregisterSocketEventHandler):
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
Tools:
Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
Tools/TestWebKitAPI/Tests/WTF/glib/.
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
(TestWebKitAPI::TEST):
- 10:52 PM Changeset in webkit [184702] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r184667 and r184682.
https://bugs.webkit.org/show_bug.cgi?id=145245
Broke media/media-controls-timeline-updates.html on WebKit2
(Requested by ap on #webkit).
Reverted changesets:
"Media Controls stop updating after hovering for a few
seconds."
https://bugs.webkit.org/show_bug.cgi?id=144770
http://trac.webkit.org/changeset/184667
"Unreviewed. Media Controls stop updating after hovering for a
few seconds."
https://bugs.webkit.org/show_bug.cgi?id=144770
http://trac.webkit.org/changeset/184682
- 10:16 PM Changeset in webkit [184701] by
-
- 4 edits in branches/safari-601.1.32-branch/Source/JavaScriptCore
Merge r184652. rdar://problem/21002666
- 10:16 PM Changeset in webkit [184700] by
-
- 7 edits in trunk/Source/WebCore
[iOS] Update optimized fullscreen controls artwork
https://bugs.webkit.org/show_bug.cgi?id=145208
rdar://problem/21034032
Reviewed by Jer Noble.
Update the artwork when media goes into optimized fullscreen. Add a new UI part
representing return-from-optimized.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::mediaUIImageData): Return data for the return button.
- Modules/mediacontrols/MediaControlsHost.idl: Add a new part ID.
- Modules/mediacontrols/mediaControlsApple.js: Add a new ClassName to apply to the
button when in the proper state.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handlePresentationModeChange): Add the ClassName when the
video goes into optimized fullscreen mode. Remove it otherwise.
- platform/ios/WebCoreSystemInterfaceIOS.h:
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::mediaControlsStyleSheet): Add the return button data to the
stylesheet.
- 10:13 PM Changeset in webkit [184699] by
-
- 4 edits in trunk
Web Inspector: array previews should have a much smaller cap on values
https://bugs.webkit.org/show_bug.cgi?id=145195
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-20
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/InjectedScriptSource.js:
(InjectedScript.RemoteObject.prototype._generatePreview):
Reduce the indexes threshold for previews.
LayoutTests:
- inspector/model/remote-object-expected.txt:
Update expected results now that array previews include
a smaller number of items.
- 10:12 PM Changeset in webkit [184698] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix WebInspector.StackTrace style
https://bugs.webkit.org/show_bug.cgi?id=145240
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-20
Reviewed by Timothy Hatcher.
- UserInterface/Models/StackTrace.js:
Reorder and add our usual marker comments.
- 10:12 PM Changeset in webkit [184697] by
-
- 3 edits in trunk/Source/JavaScriptCore
Web Inspector: Use native Arguments detection instead of using toString
https://bugs.webkit.org/show_bug.cgi?id=145235
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-20
Reviewed by Timothy Hatcher.
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype._subtype):
Deleted the old string code.
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::subtype):
Replaced with a stricter, more accurate check.
- 9:48 PM Changeset in webkit [184696] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix since r184686.
Patch by Gyuyoung Kim <Gyuyoung Kim> on 2015-05-20
- UIProcess/gtk/WebProcessPoolGtk.cpp:
(WebKit::WebProcessPool::legacyPlatformDefaultApplicationCacheDirectory): Add *legacy* prefix.
(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory): Deleted.
- 8:17 PM Changeset in webkit [184695] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Build fix after r184591.
- public/v2/manifest.js:
- 8:09 PM Changeset in webkit [184694] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed EFL build fix since r184686.
Patch by Gyuyoung Kim <Gyuyoung Kim> on 2015-05-20
- UIProcess/efl/WebProcessPoolEfl.cpp:
(WebKit::WebProcessPool::legacyPlatformDefaultApplicationCacheDirectory): Add *legacy* prefix.
(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory): Deleted.
- 8:06 PM Changeset in webkit [184693] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][iOS] Update WebContent process sandbox profile for AWD logging
https://bugs.webkit.org/show_bug.cgi?id=145229
<rdar://problem/20543269>
Reviewed by Alexey Proskuryakov.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 7:36 PM Changeset in webkit [184692] by
-
- 2 edits in trunk/Source/WebKit2
dispatchViewStateChange should not wait for sync reply if the page isn't visible
https://bugs.webkit.org/show_bug.cgi?id=145242
<rdar://problem/20967937>
Reviewed by Ben Poulain.
This is particularly problematic on iOS, since if the page isn't visible the process is likely suspended.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dispatchViewStateChange):
(WebKit::WebPageProxy::waitForDidUpdateViewState):
- 7:33 PM Changeset in webkit [184691] by
-
- 2 edits in trunk/Tools
[EFL] fix efreet error
https://bugs.webkit.org/show_bug.cgi?id=143670
Reviewed by Gyuyoung Kim.
Fix efreet error by using external variable efreet_cache_update.
As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
efreet error for efreet_cache does not occur.
- MiniBrowser/efl/main.c:
(elm_main):
- 7:09 PM Changeset in webkit [184690] by
-
- 7 edits2 adds in trunk
Enable disk cache for range requests
https://bugs.webkit.org/show_bug.cgi?id=144682
Patch by Marcos Chavarría Teijeiro <mchavarria@igalia.com> on 2015-05-20
Reviewed by Antti Koivisto.
Source/WebKit2:
Add Range header value to the network cache key constructor so we take
into account this value. The 206 response code is also marked to be cached.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::makeCacheKey):
(WebKit::NetworkCache::isStatusCodeCacheableByDefault):
- NetworkProcess/cache/NetworkCacheKey.cpp:
(WebKit::NetworkCache::Key::Key):
(WebKit::NetworkCache::Key::operator=):
(WebKit::NetworkCache::Key::computeHash):
(WebKit::NetworkCache::Key::operator==):
(WebKit::NetworkCache::Key::encode):
(WebKit::NetworkCache::Key::decode):
(WebKit::NetworkCache::Key::stringToHash): Deleted.
- NetworkProcess/cache/NetworkCacheKey.h:
LayoutTests:
- http/tests/cache/disk-cache/disk-cache-range-expected.txt: Added. Add Test.
- http/tests/cache/disk-cache/disk-cache-range.html: Added.
- http/tests/cache/disk-cache/resources/generate-response.cgi: Modify script to return 206 and 416 response codes if Range header is present.
- platform/gtk/TestExpectations: Remove failing test.
- 6:37 PM Changeset in webkit [184689] by
-
- 5 edits in branches/safari-601.1.32-branch/Source
Versioning.
- 6:37 PM Changeset in webkit [184688] by
-
- 5 edits in branches/safari-600.1.4.16-branch/Source
Versioning.
- 6:37 PM Changeset in webkit [184687] by
-
- 5 edits in branches/safari-601.1.32.2-branch/Source
Versioning.
- 6:30 PM Changeset in webkit [184686] by
-
- 4 edits in trunk/Source/WebKit2
WKWebsiteDataStore API doesn't report webkit.org as using Databases or App Cache after visiting http://www.webkit.org/demos/sticky-notes/
https://bugs.webkit.org/show_bug.cgi?id=145238
rdar://problem/20581175
Reviewed by Tim Horton.
Make sure to set the application cache and WebSQL directories when using the legacy data store.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::legacyPlatformDefaultApplicationCacheDirectory):
(WebKit::WebProcessPool::platformDefaultApplicationCacheDirectory):
Rename this and move it to the right place.
- UIProcess/WebProcessPool.cpp:
(WebKit::legacyWebsiteDataStoreConfiguration):
Rename this and add the application cache and WebSQL directories.
(WebKit::WebProcessPool::WebProcessPool):
Call legacyWebsiteDataStoreConfiguration.
(WebKit::WebProcessPool::applicationCacheDirectory):
Call legacyPlatformDefaultApplicationCacheDirectory.
- UIProcess/WebProcessPool.h:
- 6:28 PM Changeset in webkit [184685] by
-
- 2 edits in trunk/Source/WebCore
Label text for default buttons don’t have the correct white color
https://bugs.webkit.org/show_bug.cgi?id=145221
<rdar://problem/20985817>
Follow-up commit. After discussion with the AppKit team, we've
concluded that a solid white is the color that best matches
the system.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor): Use Color::white.
- 6:15 PM Changeset in webkit [184684] by
-
- 2 edits in trunk/Source/WebCore
[ContentExtensions] Properly initialize ActionKey.state
https://bugs.webkit.org/show_bug.cgi?id=145237
rdar://problem/20716683
Reviewed by Benjamin Poulain.
- contentextensions/DFAMinimizer.cpp:
Initialize ActionKey.state to Valid if it is a valid ActionKey.
Inlining can now be done safely.
- 6:14 PM Changeset in webkit [184683] by
-
- 2 edits in trunk/Tools
Add option to run_jsc_stress_tests to disable JIT testing
https://bugs.webkit.org/show_bug.cgi?id=145233
Reviewed by Mark Lam.
Added --no-jit option.
- Scripts/run-jsc-stress-tests:
- 5:58 PM Changeset in webkit [184682] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Media Controls stop updating after hovering for a few seconds.
https://bugs.webkit.org/show_bug.cgi?id=144770.
<rdar://problem/19823121>
Followup to r184667.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.showControls):
Only put controls back into the tree if they don’t yet exist in the tree.
Otherwise we interrupt operations like scrubbing.
- 5:52 PM Changeset in webkit [184681] by
-
- 5 edits in trunk/Source
[iOS] Using CSS viewport units causes incorrect layout.
https://bugs.webkit.org/show_bug.cgi?id=145225
rdar://problem/20924495
Reviewed by Benjamin Poulain.
Source/WebCore:
- page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::initialScaleFromSize):
(WebCore::ViewportConfiguration::initialScale):
(WebCore::ViewportConfiguration::initialScaleIgnoringContentSize):
- page/ViewportConfiguration.h:
(WebCore::ViewportConfiguration::initialScaleFromSize):
(WebCore::ViewportConfiguration::initialScaleIgnoringContentSize):
Source/WebKit2:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateViewportSizeForCSSViewportUnits):
- 5:51 PM Changeset in webkit [184680] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix build.
- WebView/WebViewInternal.h:
- 5:14 PM Changeset in webkit [184679] by
-
- 2 edits in trunk/Source/WebKit2
Allow overriding the waitForDidUpdateViewState timeout
https://bugs.webkit.org/show_bug.cgi?id=145230
<rdar://problem/20990162>
Reviewed by Darin Adler.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateViewState):
Use the value from NSUserDefaults, if it exists.
We'll only check once, so changing the default requires a restart of the UI process.
- 5:11 PM Changeset in webkit [184678] by
-
- 2 edits in trunk/Source/WebKit/mac
Unreviewed build fix; LocalizedStrings.h is in WebCore.
- WebView/WebActionMenuController.mm:
- 5:10 PM Changeset in webkit [184677] by
-
- 2 edits in trunk/Source/WebKit2
Make sure we always have a process pool to perform data store operations with
https://bugs.webkit.org/show_bug.cgi?id=145231
rdar://problem/20618248
Reviewed by Tim Horton.
Make sure that we always return a process pool. If we're a legacy C SPI per-context data store,
find the process pool we're a part of and use that. Otherwise, create a new one.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::processPools):
- 4:42 PM Changeset in webkit [184676] by
-
- 6 edits2 adds in trunk
AX: improve list heuristics (presentational use versus actual lists)
https://bugs.webkit.org/show_bug.cgi?id=134187
Reviewed by Darin Adler.
Source/WebCore:
Improve heuristics for list detection by:
- Not exposing lists without list markers (unless explicitly marked as lists)
- Recognizing css: before-content as list markers
Test: accessibility/list-detection2.html
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::isDescriptionList):
(WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers):
(WebCore::AccessibilityList::determineAccessibilityRole):
- accessibility/AccessibilityList.h:
LayoutTests:
- accessibility/list-detection-expected.txt:
- accessibility/list-detection.html:
- accessibility/list-detection2-expected.txt: Added.
- accessibility/list-detection2.html: Added.
- 4:34 PM Changeset in webkit [184675] by
-
- 4 edits2 adds in trunk
REGRESSION (r172591): Can no longer style <optgroup> with colors (LayoutTests/fast/forms/select/optgroup-rendering.html)
https://bugs.webkit.org/show_bug.cgi?id=145227
Source/WebCore:
rdar://problem/20967472
Reviewed by Darin Adler.
Test: fast/forms/select/select-painting.html
Use computedStyle() consistently for option and optgroup items.
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
We can always use computedStyle() and it can't be null. If there was renderer style it would return that.
- rendering/RenderMenuList.cpp:
(RenderMenuList::itemStyle):
(RenderMenuList::getItemBackgroundColor):
LayoutTests:
Reviewed by Darin Adler.
Add ref test for select painting.
- fast/forms/select/select-painting-expected.html: Added.
- fast/forms/select/select-painting.html: Added.
- 4:33 PM Changeset in webkit [184674] by
-
- 2 edits in trunk/Source/WebKit/mac
Unreviewed build fix; WebActionMenuController.mm should directly include LocalizedStrings.h
- WebView/WebActionMenuController.mm:
- 4:27 PM Changeset in webkit [184673] by
-
- 1 copy in tags/Safari-600.1.4.16.4
New tag.
- 4:26 PM Changeset in webkit [184672] by
-
- 1 copy in tags/Safari-601.1.32.2.4
New tag.
- 4:26 PM Changeset in webkit [184671] by
-
- 1 copy in tags/Safari-601.1.32.4
New tag.
- 4:12 PM Changeset in webkit [184670] by
-
- 29 edits1 copy1 add in trunk/Source
Touching HTMLMediaElement.h or MediaPlayer.h causes a world rebuild.
https://bugs.webkit.org/show_bug.cgi?id=145193
Reviewed by Eric Carlson.
Source/WebCore:
HTMLMediaElement.h and MediaPlayer.h are included in a number of headers solely for access to the enums
defined within the classes contained within. Move these enums into their own--otherwise empty--classes.
Then addusing
declarations to pull those inherited enums back into the namespace of HTMLMediaElement
and MediaPlayer.
Classes and headers which do not need to directly include HTMLMediaElement.h can now include HTMLMediaElementEnums.h
instead; the same goes for MediaPlayer.h and MediaPlayerEnums.h.
- WebCore.xcodeproj/project.pbxproj: Add new files to project.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::TrackGroup::TrackGroup): Move definition here from the header.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::videoFullscreenGravity): MediaPlayer -> MediaPlayerEnums.
(WebCore::HTMLMediaElement::preloadValue): Ditto.
(WebCore::HTMLMediaElement::TrackGroup::TrackGroup): Deleted; moved to implementation file.
- html/HTMLMediaElementEnums.h: Added.
- html/MediaControllerInterface.h: Inherit from HTMLMediaElementEnums.
- page/ChromeClient.h: HTMLMediaElement -> HTMLMediaElementEnums.
- platform/graphics/MediaPlayer.h: MediaPlayer -> MediaPlayerEnums.
- platform/graphics/MediaPlayerEnums.h: Added.
- platform/ios/WebVideoFullscreenControllerAVKit.h:
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController enterFullscreen:mode:]): HTMLMediaElement -> HTMLMediaElementEnums.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h:
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::setupFullscreenInternal): Ditto.
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::exitFullscreenInternal): Ditto.
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal): Ditto.
(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::mayAutomaticallyShowVideoOptimized): Ditto.
(WebVideoFullscreenInterfaceAVKit::willStartOptimizedFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::didStopOptimizedFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::didCancelOptimizedFullscreen): Ditto.
(WebVideoFullscreenInterfaceAVKit::setMode): Ditto.
(WebVideoFullscreenInterfaceAVKit::clearMode): Ditto.
- platform/ios/WebVideoFullscreenModel.h:
- platform/ios/WebVideoFullscreenModelVideoElement.h:
- platform/ios/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::setVideoElement): Ditto.
(WebVideoFullscreenModelVideoElement::fullscreenModeChanged): Ditto.
Source/WebKit/mac:
Use HTMLMediaElementEnums instead of HTMLMediaElement.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::enterVideoFullscreenForVideoElement): HTMLMediaElement -> HTMLMediaElementEnums.
- WebView/WebView.mm:
(-[WebView _enterVideoFullscreenForVideoElement:mode:]): Ditto.
- WebView/WebViewInternal.h:
Source/WebKit2:
Use HTMLMediaElementEnums instead of HTMLMediaElement.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _isShowingVideoOptimized]): HTMLMediaElement -> HTMLMediaElementEnums.
- UIProcess/ios/WebVideoFullscreenManagerProxy.h:
- UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::hasMode): Ditto.
(WebKit::WebVideoFullscreenModelContext::fullscreenModeChanged): Ditto.
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID): Ditto.
(WebKit::WebVideoFullscreenManagerProxy::fullscreenModeChanged): Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::enterVideoFullscreenForVideoElement): Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/ios/WebVideoFullscreenManager.h:
(WebKit::WebVideoFullscreenInterfaceContext::fullscreenMode): Ditto.
(WebKit::WebVideoFullscreenInterfaceContext::setFullscreenMode): Ditto.
- WebProcess/ios/WebVideoFullscreenManager.messages.in:
- WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement): Ditto.
(WebKit::WebVideoFullscreenManager::fullscreenModeChanged): Ditto.
(WebKit::WebVideoFullscreenManager::didCleanupFullscreen): Ditto.
- 4:04 PM Changeset in webkit [184669] by
-
- 3 edits in trunk/Source/WebKit2
Refactor process pool enumeration code in WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=145218
Reviewed by Tim Horton.
Also make sure to keep the WebProcessPool objects alive for the duration of the various data store
operations. This is the first step towards having the data store create a single process pool lazily if
there are no web views associated with the data store.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::processPools):
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 4:01 PM Changeset in webkit [184668] by
-
- 2 edits in trunk/Tools
Use correct String for StringView in WTF API tests
https://bugs.webkit.org/show_bug.cgi?id=145226
rdar://problem/20361786
Reviewed by Benjamin Poulain.
- TestWebKitAPI/Tests/WTF/StringView.cpp:
(TestWebKitAPI::TEST):
Use patternHolder for pattern.
- 3:40 PM Changeset in webkit [184667] by
-
- 3 edits in trunk/Source/WebCore
Media Controls stop updating after hovering for a few seconds.
https://bugs.webkit.org/show_bug.cgi?id=144770.
<rdar://problem/19823121>
Reviewed by Jer Noble.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createBase):
We should never hide controls immediately as a result of mousing out of the controls.
It should only happen when the mouse leaves the video entirely.
(Controller.prototype.updateTimelineMetricsIfNeeded):
Don’t update if controls are hidden, timeline dimensions will be 0.
(Controller.prototype.handlePanelTransitionEnd):
Instead of adjusting visibility via adding and removing classes,
remove controls entirely from the tree.
(Controller.prototype.showControls):
Add controls back into the tree when showing controls.
(Controller.prototype.updateForShowingControls):
Helper method for showControls.
(Controller.prototype.controlsAreHidden):
Controls also hidden if removed from tree.
Remove forceUpdate logic, no longer necessary.
(Controller.prototype.handleDurationChange):
(Controller.prototype.updateProgress):
(Controller.prototype.updateTime):
Override methods to use add and remove panelContainer for iOS.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handlePanelTransitionEnd):
(ControllerIOS.prototype.showControls):
(ControllerIOS.prototype.controlsAreHidden):
- 3:25 PM Changeset in webkit [184666] by
-
- 6 edits in trunk/Source/JavaScriptCore
Remove unused MarkedBlock::m_rememberedSet.
<https://webkit.org/b/145224>
Reviewed by Mark Hahnenberg.
The MarkedBlock had a copy of the remembered bit for each of its cells,
and we were maintaining that bitmap despite no one actually ever consulting it.
This patch removes MarkedBlock::m_rememberedSet, freeing up 128 bytes in each
block and making write barriers a little faster.
- heap/Heap.cpp:
(JSC::Heap::clearRememberedSet):
(JSC::Heap::addToRememberedSet):
- heap/HeapInlines.h:
(JSC::Heap::isRemembered):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::clearRememberedSet): Deleted.
(JSC::MarkedBlock::clearMarksWithCollectionType):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::setRemembered): Deleted.
(JSC::MarkedBlock::clearRemembered): Deleted.
(JSC::MarkedBlock::atomicClearRemembered): Deleted.
(JSC::MarkedBlock::isRemembered): Deleted.
- heap/MarkedSpace.h:
(JSC::ClearRememberedSet::operator()): Deleted.
(JSC::MarkedSpace::clearRememberedSet): Deleted.
- 3:23 PM Changeset in webkit [184665] by
-
- 982 edits587 adds in trunk/Websites/webkit.org
Upgrading WordPress to 4.2.2 release.
- 3:07 PM Changeset in webkit [184664] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Build fix. Use POSIX timestamp instead of human readable string for the commit time.
- public/include/build-requests-fetcher.php:
- 3:03 PM Changeset in webkit [184663] by
-
- 8 edits in tags/Safari-601.1.32.2.50/Source
Merged r184600. rdar://problem/21024426
- 2:53 PM Changeset in webkit [184662] by
-
- 2 edits in trunk/Source/WebCore
[Mac] inform media session of all state changes
https://bugs.webkit.org/show_bug.cgi?id=145222
Reviewed by Dean Jackson.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Call updateMediaState.
(WebCore::HTMLMediaElement::mediaPlayerEngineUpdated): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): Ditto.
(WebCore::HTMLMediaElement::removeEventListener): Ditto.
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent): Ditto.
- 2:52 PM Changeset in webkit [184661] by
-
- 8 edits in trunk/Websites/perf.webkit.org
UI to associate bugs with an analysis task is crappy
https://bugs.webkit.org/show_bug.cgi?id=145198
Reviewed by Andreas Kling.
Make the UI less crappy by linkifying bug numbers and adding an explicit button to disassociate
a bug and a separate select view with a text field to associate a new bug instead of implicitly
updating or deleting the existing record based on what the user had typed.
- init-database.sql: Removed the constraint that each bug tracker should appear exactly once for
a given analysis task since it's perfectly reasonable for a given task to be associated with
multiple WebKit bugs.
- public/privileged-api/associate-bug.php:
(main): Only remove the bug specified by newly added bugToDelete instead of implicitly deleting
one that matches the analysis task and the bug tracker when the bug number is falsey.
- public/v2/analysis.js:
(App.Bug.url): Added.
(App.BugAdapter.deleteRecord): Added. Uses the privileged API to delete the record.
- public/v2/app.css:
- public/v2/app.js:
(App.AnalysisTaskController.actions.addBug): Added.
(App.AnalysisTaskController.actions.deleteBug): Added.
(App.AnalysisTaskController.associateBug): Deleted.
- public/v2/index.html: Updated the templates.
- public/v2/manifest.js:
(App.BugTracker.urlFromBugNumber): Added.
- 2:38 PM Changeset in webkit [184660] by
-
- 9 edits2 adds in trunk
AX: AutoFill button is not accessible with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=145200
<rdar://problem/20507480>
Reviewed by Chris Fleizach.
Source/WebCore:
Add ARIA label and role attributes to the AutoFill button markup so that VoiceOver
can identify and interact with it.
Test: accessibility/input-auto-fill-button.html
- English.lproj/Localizable.strings: Add placeholder localized string for AutoFill button.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createAutoFillButton): Add ARIA label and role attributes.
- platform/LocalizedStrings.cpp:
(WebCore::AXAutoFillButtonText): Added; returns the localized string for the AutoFill button.
- platform/LocalizedStrings.h:
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXAutoFillButtonText): Ditto.
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXAutoFillButtonText): Ditto.
LayoutTests:
Test that there is an accessibility element for the AutoFill button.
- accessibility/input-auto-fill-button-expected.txt: Added.
- accessibility/input-auto-fill-button.html: Added.
- platform/win/TestExpectations: For now, mark tests as failing. I suspect the cause
- 2:36 PM Changeset in webkit [184659] by
-
- 2 edits in trunk/Source/WebCore
Label text for default buttons don’t have the correct white color
https://bugs.webkit.org/show_bug.cgi?id=145221
<rdar://problem/20985817>
Reviewed by Tim Horton.
Use a 85% solid white for the active text color on buttons.
As has been disappointingly pointed out in other patches, we don't
have a good way to test ActiveButtonText since it only applies at
paint time.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor): Move to an 85% solid white.
- 2:22 PM Changeset in webkit [184658] by
-
- 3 edits in trunk/Websites/perf.webkit.org
A/B testing rootSets should provide commit times as well as revisions
https://bugs.webkit.org/show_bug.cgi?id=145207
Reviewed by Andreas Kling.
Some continuous build systems need the commit time as well as the revision number / hash so provide one
in the root sets but maintain the backwards compatibility with buildbots that use revision number directly.
- public/include/build-requests-fetcher.php:
(BuildRequestsFetcher::fetch_roots_for_set): Made the revision info an associative array that contains
the revision number as well as the commit time.
- tools/sync-with-buildbot.py:
(schedule_request): Removed "replacement" which was a superfluous copy of "roots". Use "revision" values
when the JSON configuration refers to "root". This is necessary in buildbot instances that require WebKit
revision to be specified on its own field instead of it being a JSON that contains "revision" and "time".
- 2:08 PM Changeset in webkit [184657] by
-
- 3 edits in trunk/Source/WebCore
ThreadableLoaderOptions::isolatedCopy() doesn't produce a copy that is safe for sending to another thread
https://bugs.webkit.org/show_bug.cgi?id=145217
Reviewed by Anders Carlsson.
Caught by existing tests, rarely. I don't know how to catch such bugs more reliably.
- loader/ThreadableLoader.cpp: (WebCore::ThreadableLoaderOptions::isolatedCopy):
- loader/ThreadableLoader.h:
- 2:07 PM Changeset in webkit [184656] by
-
- 5 edits in branches/safari-600.7-branch/Source
Versioning.
- 1:57 PM Changeset in webkit [184655] by
-
- 1 copy in tags/Safari-600.7.8
New tag.
- 1:42 PM Changeset in webkit [184654] by
-
- 5 edits in trunk/Source/WebCore
Add a mechanism to opt-out of the automatic scaling applied to not-really-responsive sites
https://bugs.webkit.org/show_bug.cgi?id=144760
Reviewed by Darin Adler.
Add a new viewport property, shrink-to-fit, which can be used to disable
the automatic scaling introduced in r181400. This provides sites with a
way to tell WebKit that they're really sure they want to be laid out at
window-width/height, even if they fail to fit within that size.
- dom/ViewportArguments.cpp:
(WebCore::ViewportArguments::resolve):
(WebCore::findBooleanValue):
(WebCore::setViewportFeature):
- dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::operator==):
- page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::shouldIgnoreHorizontalScalingConstraints):
(WebCore::ViewportConfiguration::shouldIgnoreVerticalScalingConstraints):
(WebCore::ViewportConfiguration::webpageParameters):
(WebCore::ViewportConfiguration::textDocumentParameters):
(WebCore::ViewportConfiguration::imageDocumentParameters):
(WebCore::ViewportConfiguration::testingParameters):
(WebCore::booleanViewportArgumentIsSet):
(WebCore::ViewportConfiguration::updateConfiguration):
(WebCore::ViewportConfigurationTextStream::operator<<):
(WebCore::viewportArgumentUserZoomIsSet): Deleted.
- page/ViewportConfiguration.h:
(WebCore::ViewportConfiguration::Parameters::Parameters):
Plumb the shrink-to-fit viewport property through.
If shrink-to-fit is set to yes, or not set, we behave as usual; if it is
set to no, we will bail from shouldIgnore[Horizontal|Vertical]ScalingConstraints,
effectively disabling the automatic scaling introduced in r181400.
- 1:34 PM Changeset in webkit [184653] by
-
- 4 edits2 adds in trunk
Assertion failure in WebCore::BidiRun::BidiRun()
https://bugs.webkit.org/show_bug.cgi?id=145203
rdar://problem/20958973
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/text/text-combine-crash.html
- rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleText):
Renove !isCombined() check. RenderCombineText::combineText() doesn't
do any work unless needed and text may become uncombined too.
- rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::skipLeadingWhitespace):
Same here.
LayoutTests:
- fast/text/text-combine-crash-expected.txt: Added.
- fast/text/text-combine-crash.html: Added.
- 1:30 PM Changeset in webkit [184652] by
-
- 4 edits in trunk/Source/JavaScriptCore
Eden collections should extend the IncrementalSweeper work list, not replace it.
<https://webkit.org/b/145213>
<rdar://problem/21002666>
Reviewed by Geoffrey Garen.
After an eden collection, the garbage collector was adding all MarkedBlocks containing
new objects to the IncrementalSweeper's work list, to make sure they didn't have to
wait until the next full collection before getting swept.
Or at least, that's what it thought it was doing. It turns out that IncrementalSweeper's
internal work list is really just a reference to Heap::m_blockSnapshot. I didn't realize
this when writing the post-eden sweep code, and instead made eden collections cancel
all pending sweeps and *replace* them with the list of blocks with new objects.
This made it so that rapidly occurring eden collections could prevent large numbers of
heap blocks from ever getting swept. This would manifest as accumulation of MarkedBlocks
when a system under heavy load was also allocating short lived objects at a high rate.
Things would eventually get cleaned up when there was a lull and a full collection was
allowed to run its heap sweep to completion.
Fix this by moving all management of the block snapshot to Heap. snapshotMarkedSpace()
now handles eden collections by merging the list of blocks with new objects into the
existing block snapshot.
- heap/Heap.cpp:
(JSC::Heap::snapshotMarkedSpace):
(JSC::Heap::notifyIncrementalSweeper):
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::startSweeping):
(JSC::IncrementalSweeper::addBlocksAndContinueSweeping): Deleted.
- heap/IncrementalSweeper.h:
- 1:20 PM Changeset in webkit [184651] by
-
- 13 edits2 adds in trunk
AudioContext resume/close/suspend should reject promises with a DOM exception in lieu of throwing exceptions
https://bugs.webkit.org/show_bug.cgi?id=145064
Reviewed by Darin Adler.
Source/JavaScriptCore:
Added default message for TypeError.
- runtime/Error.cpp:
(JSC::throwTypeError):
- runtime/Error.h:
Source/WebCore:
Rejecting resume/suspend/close promises with InvalidStateError values in case context is offline.
Removed unneeded calls to postTask for resolving/rejecting promises.
Adding promise rejection of DOM Exception values, 0 being equivalent of no error passed to reject callback.
Test: webaudio/audiocontext-promise-throwing.html
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::suspendContext): Rejecting promise in lieu of throwing exception.
(WebCore::AudioContext::resumeContext): Ditto.
(WebCore::AudioContext::closeContext): Ditto.
- Modules/webaudio/AudioContext.h:
- bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContext::suspend): Removing ExceptionCode handling.
(WebCore::JSAudioContext::resume): Ditto.
(WebCore::JSAudioContext::close): Ditto.
- bindings/js/JSDOMBinding.cpp:
(WebCore::createDOMException): Splitting DOM exception creation from throwing.
(WebCore::setDOMException): Ditto.
- bindings/js/JSDOMBinding.h: Adding createDOMException prototype.
- bindings/js/JSDOMPromise.h:
(WebCore::DeferredWrapper::reject<ExceptionCode>):
LayoutTests:
Adding test to cover resume/close/suspend rejecting with InvalidStateError.
Updating existing test to cover resume and suspend rejection with no error.
- webaudio/audiocontext-promise-throwing-expected.txt: Added.
- webaudio/audiocontext-promise-throwing.html: Added.
- webaudio/audiocontext-state-expected.txt:
- webaudio/audiocontext-state.html:
- 1:12 PM Changeset in webkit [184650] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r184645.
https://bugs.webkit.org/show_bug.cgi?id=145220
Broken build (Requested by jacob_nielsen on #webkit).
Reverted changeset:
"AX: AutoFill button is not accessible with VoiceOver"
https://bugs.webkit.org/show_bug.cgi?id=145200
http://trac.webkit.org/changeset/184645
- 1:08 PM Changeset in webkit [184649] by
-
- 5 edits in tags/Safari-601.1.32.2.50/Source
Versioning.
- 1:05 PM Changeset in webkit [184648] by
-
- 1 copy in tags/Safari-601.1.32.2.50
New tag.
- 12:35 PM Changeset in webkit [184647] by
-
- 2 edits in trunk/Source/JavaScriptCore
No LLInt Test Failure: jsc-layout-tests.yaml/js/script-tests/object-literal-duplicate-properties.js.layout-no-llint
https://bugs.webkit.org/show_bug.cgi?id=145219
Reviewed by Mark Lam.
- jit/JITOperations.cpp:
Throw the error we just got, instead of a stack overflow exception.
This matches other error handling for callers of prepareForExecution.
- 11:40 AM Changeset in webkit [184646] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add some assertions about the CFG in the loop pre-header creation phase
https://bugs.webkit.org/show_bug.cgi?id=145205
Reviewed by Geoffrey Garen.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::currentNodeOrigin): Add a FIXME.
- dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::run): Add a FIXME.
- dfg/DFGLoopPreHeaderCreationPhase.cpp:
(JSC::DFG::LoopPreHeaderCreationPhase::run): Add the assertions.
- 10:58 AM Changeset in webkit [184645] by
-
- 8 edits2 adds in trunk
AX: AutoFill button is not accessible with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=145200
<rdar://problem/20507480>
Reviewed by Chris Fleizach.
Source/WebCore:
Add ARIA label and role attributes to the AutoFill button markup so that VoiceOver
can identify and interact with it.
Test: accessibility/input-auto-fill-button.html
- English.lproj/Localizable.strings: Add placeholder localized string for AutoFill button.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createAutoFillButton): Add ARIA label and role attributes.
- platform/LocalizedStrings.cpp:
(WebCore::AXAutoFillButtonText): Added; returns the localized string for the AutoFill button.
- platform/LocalizedStrings.h:
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXAutoFillButtonText): Ditto.
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXAutoFillButtonText): Ditto.
LayoutTests:
Test that there is an accessibility element for the AutoFill button.
- accessibility/input-auto-fill-button-expected.txt: Added.
- accessibility/input-auto-fill-button.html: Added.
- 10:56 AM Changeset in webkit [184644] by
-
- 17 edits in trunk
[Content Extensions] Relax restrictions on triggers that match everything.
https://bugs.webkit.org/show_bug.cgi?id=145069
Reviewed by Benjamin Poulain.
Source/WebCore:
Added API tests that cover the new functionality and test for correctness in behavior.
- contentextensions/CompiledContentExtension.cpp:
(WebCore::ContentExtensions::CompiledContentExtension::globalDisplayNoneSelectors):
- contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::addUniversalActionsToDFA):
(WebCore::ContentExtensions::compileRuleList):
Put universalActionsWithoutDomains into the DFA from filtersWithoutDomains and
put universalActionsWithDomains into the DFA from filtersWithDomains.
- contentextensions/ContentExtensionError.cpp:
(WebCore::ContentExtensions::contentExtensionErrorCategory):
- contentextensions/ContentExtensionError.h:
Remove error codes for errors that are not errors any more.
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):
- contentextensions/ContentExtensionsBackend.h:
- contentextensions/DFABytecode.h:
(WebCore::ContentExtensions::instructionSizeWithArguments):
- contentextensions/DFABytecodeCompiler.cpp:
(WebCore::ContentExtensions::set32Bits):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitAppendAction):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitJump):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitCheckValue):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitCheckValueRange):
(WebCore::ContentExtensions::DFABytecodeCompiler::compileNode):
(WebCore::ContentExtensions::DFABytecodeCompiler::compile):
(WebCore::ContentExtensions::DFABytecodeCompiler::emitTestFlagsAndAppendAction): Deleted.
- contentextensions/DFABytecodeCompiler.h:
- contentextensions/DFABytecodeInterpreter.cpp:
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretTestFlagsAndAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsForDefaultStylesheetFromDFARoot):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsFromDFARoot): Deleted.
- contentextensions/DFABytecodeInterpreter.h:
Add a new bytecode AppendActionDefaultStylesheet to mark actions that are css-display-none
that need to be put in the default stylesheet to be ignored or not as a whole.
css-display-none actions with flags or domain rules and css-display-none actions
after ignore-previous-rules actions are not to be in this precompiled stylesheet, but
they will be applied as needed per page. The precompiled stylesheet is already applied
if no ignore-previous-rules action is triggered.
- loader/ResourceLoadInfo.h:
Source/WebKit2:
- UIProcess/API/APIUserContentExtensionStore.h:
Increment version number to reflect changes in DFABytecode.
Tools:
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::TEST_F):
Update and add tests for new possibilities with .*
- 10:39 AM Changeset in webkit [184643] by
-
- 7 edits in trunk/Source/WebCore
JS binding generator should create a member variable for each Promise attribute of an interface
https://bugs.webkit.org/show_bug.cgi?id=145056
Reviewed by Darin Adler.
For each attribute XXX whose type is Promise, a member m_XXXPromiseDeferred is created, its type being a JSC::Strong of JSPromiseDeferred.
The purpose is to enable custom getters to create the JSPromiseDeferred and store ino the class member to ensure the same promise is returned each time
the custom getter is called.
This patch will enable simplifying ReadableStreamReader custom binding.
Covered by added attribute in TestObj.idl.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_get_test_promise_attr):
(webkit_dom_test_obj_set_nullable_string_value): Deleted.
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjTestPromiseAttr):
(WebCore::jsTestObjAttributeWithReservedEnumType): Deleted.
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj testPromiseAttr]):
(-[DOMTestObj attribute]): Deleted.
- bindings/scripts/test/TestObj.idl:
- 10:23 AM Changeset in webkit [184642] by
-
- 11 edits6 adds in trunk
ES6: Implement Object.setPrototypeOf
https://bugs.webkit.org/show_bug.cgi?id=145202
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-20
Reviewed by Darin Adler.
Source/JavaScriptCore:
- runtime/JSGlobalObjectFunctions.h:
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncProtoSetter):
(JSC::checkProtoSetterAccessAllowed):
Extract a helper to share this code between proto setter and setPrototypeOf.
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorSetPrototypeOf):
Implementation is very similiar to proto setter.
LayoutTests:
- http/tests/security/cross-frame-access-object-setPrototypeOf-expected.txt: Added.
- http/tests/security/cross-frame-access-object-setPrototypeOf.html: Added.
- http/tests/security/resources/cross-frame-iframe-for-object-setPrototypeOf-test.html: Added.
Test covering cross origin restriction behavior.
- js/Object-getOwnPropertyNames-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
Updated for the new exposed property.
- js/cyclic-prototypes-expected.txt:
- js/script-tests/cyclic-prototypes.js:
Extend this test to include setPrototypeOf cyclic checks.
Note that setPrototypeOf can still change the prototype
where proto cannot.
- js/prototypes-expected.txt:
- js/script-tests/prototypes.js:
Extend this test to cover more types previously overlooked.
- js/script-tests/setPrototypeOf.js: Added.
(debugEval):
(getObjectDescriptions.myFunction):
(getObjectDescriptions):
- js/setPrototypeOf-expected.txt: Added.
- js/setPrototypeOf.html: Added.
Test coverage for all the different object / prototype combinations.
This is modeled after the other browser tests with coverage of a
few more basic functionality tests and object types.
- 10:02 AM Changeset in webkit [184641] by
-
- 3 edits2 adds in trunk
AudioContext suspend/resume/close should resolve promises immediately when state is already suspended/active/closed
https://bugs.webkit.org/show_bug.cgi?id=145164
Reviewed by Jer Noble.
Source/WebCore:
Test: webaudio/audiocontext-promise.html
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::suspendContext): Immediatly call callbacks whenever possible to resolve/reject promises.
(WebCore::AudioContext::resumeContext): Ditto.
(WebCore::AudioContext::closeContext): Ditto
LayoutTests:
- webaudio/audiocontext-promise-expected.txt: Added.
- webaudio/audiocontext-promise.html: Added.
- 9:54 AM Changeset in webkit [184640] by
-
- 13 edits3 adds in trunk
ES6: Should not allow duplicate basic proto properties in Object Literals
https://bugs.webkit.org/show_bug.cgi?id=145138
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-20
Reviewed by Darin Adler.
Source/JavaScriptCore:
Implement ES6 Annex B.3.1, which disallows duplicate basic proto
properties in object literals. This doesn't affect computed properties,
shorthand properties, or getters/setters all of which avoid setting
the actual prototype of the object anyway.
- interpreter/Interpreter.cpp:
(JSC::eval):
Remove out of date comment. Duplicate property names are allowed
now in ES6, they were not in ES5 strict mode.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::getName):
(JSC::ASTBuilder::getType):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::getName):
Add back getName to get the property name depending on the tree builder.
Also tighten up the parameter types.
- runtime/LiteralParser.cpp:
(JSC::LiteralParser<CharType>::parse):
In quick JSON literal parsing for eval, we actually need to evaluate
the proto property assignment, instead of just building up a list
of direct properties. Only do this when not doing a strict JSON parse.
- parser/Nodes.h:
Add "Shorthand" to the list of PropertyNode types to allow it to
be distinguished without relying on other information.
- parser/Parser.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseProperty):
Add the Shorthand type when parsing a shorthand property.
(JSC::Parser<LexerType>::shouldCheckPropertyForUnderscoreProtoDuplicate):
(JSC::Parser<LexerType>::parseObjectLiteral):
(JSC::Parser<LexerType>::parseStrictObjectLiteral):
Check for duplicate proto properties, and throw a SyntaxError
if that was the case.
LayoutTests:
- js/dom/JSON-parse-expected.txt:
- js/resources/JSON-parse.js:
Update expected results for JSON parsing using eval() versus JSON.parse.
In eval, an object literal with a "proto" property modifies the prototype.
In JSON.parse, all properties are direct/own properties, no matter their name,
so "proto" does not get special treatment.
- js/eval-json-proto-expected.txt: Added.
- js/eval-json-proto.html: Added.
- js/script-tests/eval-json-proto.js: Added.
Direct test for LiteralParser behavior, in both eval and JSON.parse.
- js/object-literal-duplicate-properties-expected.txt:
- js/script-tests/object-literal-duplicate-properties.js:
(runProtoTestShouldThrow):
(runProtoTestShouldNotThrow):
Test for all cases of acceptable and unacceptable proto duplicate
properties in literals.
- 9:18 AM Changeset in webkit [184639] by
-
- 3 edits in trunk/Source/WebKit2
Minor cleanups to PluginProcessProxy.
https://bugs.webkit.org/show_bug.cgi?id=145199
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-05-20
Reviewed by Anders Carlsson.
- Remove unnecessary forward declaration.
- Remove unnecessary #include.
- UIProcess/Plugins/PluginProcessProxy.cpp:
- UIProcess/Plugins/PluginProcessProxy.h:
- 9:13 AM Changeset in webkit [184638] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Add some documentation to WebKitWebExtension
https://bugs.webkit.org/show_bug.cgi?id=142786
Patch by Marcos Chavarría Teijeiro <mchavarria@igalia.com> on 2015-05-20
Reviewed by Carlos Garcia Campos.
WebKitWebExtension API documentation lacks of some details and the information
available is in some contributors blog posts. I add the section
documentation with a small guide about how to use WebExtensions.
The code examples were taken from Carlos García and Adrián Pérez blog
posts.
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
- 8:53 AM Changeset in webkit [184637] by
-
- 4 edits in trunk/Source/WebKit2
Rename WebsiteDataStore::isNonPersistent() to WebsiteDataStore::isPersistent().
https://bugs.webkit.org/show_bug.cgi?id=145111
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-05-20
Reviewed by Darin Adler.
This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=144158.
- UIProcess/API/APIWebsiteDataStore.cpp:
(API::WebsiteDataStore::isPersistent):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
- UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::isPersistent):
(WebKit::WebsiteDataStore::isNonPersistent): Deleted.
- 8:49 AM Changeset in webkit [184636] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Add missing copyrights and licenses for some scripts
https://bugs.webkit.org/show_bug.cgi?id=145044
Reviewed by Darin Adler.
- build-symbol-table-index.py:
- create-llvm-ir-from-source-file.py:
- create-symbol-table-index.py:
- 8:46 AM Changeset in webkit [184635] by
-
- 5 edits in trunk
Web Inspector: Slightly better node previews in arrays
https://bugs.webkit.org/show_bug.cgi?id=145188
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-20
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype._nodeDescription):
(InjectedScript.prototype._nodePreview):
Different stringified representations for a basic object description or in a preview.
(InjectedScript.RemoteObject.prototype._appendPropertyPreviews):
Use the node preview string representation inside previews.
LayoutTests:
- inspector/model/remote-object-expected.txt:
- inspector/model/remote-object.html:
- 3:25 AM Changeset in webkit [184634] by
-
- 1 copy in releases/WebKitGTK/webkit-2.4.9
WebKitGTK+ 2.4.9
- 3:24 AM Changeset in webkit [184633] by
-
- 4 edits in releases/WebKitGTK/webkit-2.4
Unreviewed. Update NEWS and Versions.m4 for 2.4.9 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.4.9.
- 3:12 AM Changeset in webkit [184632] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Fix build failure, linker does not find libXext.
https://bugs.webkit.org/show_bug.cgi?id=144100
Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-05-20
Reviewed by Gyuyoung Kim.
Move Xext library from WebProcess_LIBRARIES to WebKit2_LIBRARIES.
- PlatformEfl.cmake:
- 2:14 AM Changeset in webkit [184631] by
-
- 7 edits in branches/safari-601.1.32.2-branch/Source/WebCore
Merged r184611. rdar://problem/21031188
- 2:09 AM Changeset in webkit [184630] by
-
- 19 edits in branches/safari-601.1.32.2-branch/Source
Merged r184596. rdar://problem/21023785
- 2:07 AM Changeset in webkit [184629] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebCore
Merged r184589. rdar://problem/21009192
- 2:06 AM Changeset in webkit [184628] by
-
- 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2
Merged r184583. rdar://problem/20964171
- 2:05 AM Changeset in webkit [184627] by
-
- 6 edits in branches/safari-601.1.32.2-branch/Source
Merged r184404. rdar://problem/20619179
- 12:58 AM Changeset in webkit [184626] by
-
- 19 edits in branches/safari-601.1.32-branch/Source
Merged r184596. rdar://problem/21023785
- 12:56 AM Changeset in webkit [184625] by
-
- 4 edits in branches/safari-601.1.32-branch/Source/JavaScriptCore
Merged r184542. rdar://problem/20679710
- 12:55 AM Changeset in webkit [184624] by
-
- 4 edits in branches/safari-601.1.32-branch/Source/JavaScriptCore
Merged r184540. rdar://problem/20679710
- 12:55 AM Changeset in webkit [184623] by
-
- 5 edits in trunk/Source/WebCore
REGRESSION(r184420): [GTK] webkit_dom_html_element_get_children has been removed
https://bugs.webkit.org/show_bug.cgi?id=145174
Reviewed by Philippe Normand.
children property has been moved to Element, Document and
DocumentFragment to match the spec, so we need to expose the new
get_children and bring back webkit_dom_html_element_get_children()
as deprecated.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_html_element_get_children):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- bindings/gobject/webkitdom.symbols:
- 12:39 AM Changeset in webkit [184622] by
-
- 12 edits in trunk/Source/WebCore
nullptr cleanup in WebCore/xml.
https://bugs.webkit.org/show_bug.cgi?id=145165
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-05-20
Reviewed by Csaba Osztrogonác.
No new tests, no behavior changes
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseXML):
(WebCore::XMLHttpRequest::internalAbort):
(WebCore::XMLHttpRequest::clearResponseBuffers):
(WebCore::XMLHttpRequest::clearRequest):
(WebCore::XMLHttpRequest::didFinishLoading):
- xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent):
- xml/XSLImportRule.cpp:
(WebCore::XSLImportRule::XSLImportRule):
(WebCore::XSLImportRule::~XSLImportRule):
(WebCore::XSLImportRule::setXSLStyleSheet):
(WebCore::XSLImportRule::loadSheet):
- xml/XSLStyleSheet.h:
- xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::~XSLStyleSheet):
(WebCore::XSLStyleSheet::clearDocuments):
- xml/XSLTProcessorLibxslt.cpp:
(WebCore::saveResultToString):
(WebCore::xsltParamArrayFromParameterMap):
(WebCore::xmlDocPtrFromNode):
(WebCore::XSLTProcessor::transformToString):
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::clearCurrentNodeStack):
(WebCore::XMLDocumentParser::exitText):
(WebCore::XMLDocumentParser::notifyFinished):
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::openFunc):
(WebCore::XMLDocumentParser::XMLDocumentParser):
- xml/parser/XMLDocumentParserScope.cpp:
- xml/parser/XMLDocumentParserScope.h:
- 12:26 AM Changeset in webkit [184621] by
-
- 2 edits in trunk/Tools
[EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=144992
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2015-05-20
Reviewed by Gyuyoung Kim.
- MiniBrowser/efl/main.c:
(toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
(on_key_down):
(on_fullscreen_enter):
(on_fullscreen_exit):
(window_create):
- 12:04 AM Changeset in webkit [184620] by
-
- 16 edits in trunk/Source
[SOUP] Network Cache: Implement ShareableResource for Soup and enable it for GTK platform
https://bugs.webkit.org/show_bug.cgi?id=144380
Reviewed by Antti Koivisto.
Source/WebCore:
Add a soup implementation of SharedBuffer::tryReplaceContentsWithPlatformBuffer().
Covered by http/tests/cache/disk-cache/ tests.
- loader/cache/CachedResource.cpp: Define
CachedResource::tryReplaceEncodedData() also for Soup.
- loader/cache/CachedResource.h: Ditto.
- platform/soup/SharedBufferSoup.cpp:
(WebCore::SharedBuffer::tryReplaceContentsWithPlatformBuffer):
Source/WebKit2:
It improves the network cache performance, by mmaping big
resources and sending only the file descriptor to the web process
instead of the actual file data. It needs some changes in
cross-platform code, because we can't use the same approach as
mac (it uses a platform specific implementation not available in
other platforms).
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::store): Use
Data::tryCreateSharedMemory() to create the shared memory used by
the ShareableResource. Also add an ASSERT instead of checking the
shareable resource created is not nullptr, because the
ShareableResource::create() that receives a shared memory should
never return nullptr.
- NetworkProcess/cache/NetworkCacheData.h:
- NetworkProcess/cache/NetworkCacheDataCocoa.mm:
(WebKit::NetworkCache::Data::tryCreateSharedMemory):
- NetworkProcess/cache/NetworkCacheDataSoup.cpp:
(WebKit::NetworkCache::Data::tryCreateSharedMemory): Create a
SharedMemory object to wrap the mapped file, but keeping the ownership.
- NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord):
Use Data::tryCreateSharedMemory() to create the shared memory used
bythe ShareableResource. Also add an ASSERT instead of checking
the shareable resource created is not nullptr, because the
ShareableResource::create() that receives a shared memory should
never return nullptr.
- Platform/SharedMemory.h:
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::map): Use wrapMap() and initialize
m_isWrappingMap to false.
(WebKit::SharedMemory::wrapMap): Create a SharedMemory object for
the given map, without taking its ownership.
(WebKit::SharedMemory::~SharedMemory): Do not unmap and close the
file descriptor if m_isWrappingMap is true.
- Shared/ShareableResource.cpp:
(WebKit::createShareableResourceDeallocator):
(WebKit::ShareableResource::wrapInSharedBuffer): Create a SharedBuffer
wrapping the ShareableResource data.
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer): Create
a ShareableResource for the handle and create a SharedBuffer
wrapping it.
- Shared/ShareableResource.h:
- WebKit2Prefix.h: Enable ENABLE_SHAREABLE_RESOURCE for GTK.
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResource): Get the CFData
from the SharedBuffer for QuickLook instead of wrapping the handle again.