Timeline



Jun 27, 2016:

11:53 PM Changeset in webkit [202548] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.38.2.1/Source

Versioning.

11:52 PM Changeset in webkit [202547] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.38.2.1

New tag.

11:44 PM Changeset in webkit [202546] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

REGRESSION?(r202466): http/tests/security/canvas-remote-read-remote-video-redirect.html failing on Sierra
https://bugs.webkit.org/show_bug.cgi?id=159172
<rdar://problem/27030025>

Reviewed by Brent Fulgham.

Add a hasSingleSecurityOrigin property to WebCoreNSURLSession that gets updated each time one of that
sessions' tasks receieves a response or a redirect request. Check that property from the MediaPlayerPrivate.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin):

  • platform/network/cocoa/WebCoreNSURLSession.h:
  • platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSession updateHasSingleSecurityOrigin:]):
(-[WebCoreNSURLSession dataTaskWithRequest:]):
(-[WebCoreNSURLSession dataTaskWithURL:]):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]):

11:38 PM Changeset in webkit [202545] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

CMake build fix.

  • PlatformMac.cmake:
11:22 PM Changeset in webkit [202544] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline test on iOS after r202539.

  • platform/ios-simulator/fast/dom/event-handler-attributes-expected.txt:
11:11 PM Changeset in webkit [202543] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test commit. Please ignore.

11:09 PM Changeset in webkit [202542] by commit-queue@webkit.org
  • 14 edits in trunk

Remove didFailAccessControlCheck ThreadableLoaderClient callback
https://bugs.webkit.org/show_bug.cgi?id=159149

Patch by Youenn Fablet <youenn@apple.com> on 2016-06-27
Reviewed by Daniel Bates.

LayoutTests/imported/w3c:

  • web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt:

Source/WebCore:

Adding an AccessControl ResourceError type.
Replacing didFailAccessControlCheck callback by a direct call to didFail with an error of type AccessControl.

Making CrossOriginPreflightChecker always return an AccessControl error. Previously some errors created below
were passed directly to threadable loader clients.

When doing preflight on unauthorized web sites, WTR/DRT will trigger a cancellation error which was translating into an abort event in XMLHttpRequest.
This patch is changing the error type to AccessControl, which translates into an error event in XMLHttpReauest.

This change of behavior is seen in imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred.htm.
No other observable change of behavior should be expected.

  • inspector/InspectorNetworkAgent.cpp: Computing error message in didFail according the error type.
  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::validatePreflightResponse): Setting preflightFailure error type to AccessControl.
(WebCore::CrossOriginPreflightChecker::notifyFinished): Ditto.
(WebCore::CrossOriginPreflightChecker::doPreflight): Ditto.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Replacing didFailAccessControlCheck
callback by a direct call to didFail with an error of type AccessControl.
(WebCore::reportContentSecurityPolicyError): Ditto.
(WebCore::reportCrossOriginResourceSharingError): Ditto.
(WebCore::DocumentThreadableLoader::didReceiveResponse): Ditto.
(WebCore::DocumentThreadableLoader::preflightFailure): Calling didFail directly.

  • loader/ThreadableLoaderClient.h: Removing didFailAccessControlCheck.
  • loader/ThreadableLoaderClientWrapper.h: Ditto.
  • loader/WorkerThreadableLoader.cpp: Ditto.
  • loader/WorkerThreadableLoader.h: Ditto.
  • page/EventSource.cpp:

(WebCore::EventSource::didFail): Removing didFailAccessControlCheck and putting handling code in didFail.

  • page/EventSource.h:
  • platform/network/ResourceErrorBase.cpp:

(WebCore::ResourceErrorBase::setType): Softening the assertion to cover the case of migration to AccessControl.

  • platform/network/ResourceErrorBase.h: Adding AccessControl error type.

(WebCore::ResourceErrorBase::isAccessControl):

11:07 PM Changeset in webkit [202541] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Mark some tests as image failures.

These tests started to fail with the render server snapshotting enabled in r202532.

  • platform/ios-simulator-wk2/TestExpectations:
10:56 PM Changeset in webkit [202540] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Fix TestWebKitAPI crash introduced in r202532.

WebPageProxy::forceRepaint() could trigger a call to the didForceRepaintCallback()
after the WebPageProxy had been invalidated, causing a null de-ref of m_drawingArea.
Fix by checking for error and isValid().

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::forceRepaint):

10:10 PM Changeset in webkit [202539] by Chris Dumez
  • 9 edits in trunk

HTMLElement / SVGElement should implement GlobalEventHandlers, not Element
https://bugs.webkit.org/show_bug.cgi?id=159191
<rdar://problem/27019299>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline test now that more checks are passing.

  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

HTMLElement / SVGElement should implement GlobalEventHandlers, not Element:

Firefox and Chrome behave as per the specification.

Fixing this also fixes rendering on http://survey123.arcgis.com/.

No new tests, covered by existing tests that were rebaselined.

  • dom/Element.idl:
  • html/HTMLElement.idl:
  • svg/SVGElement.idl:

LayoutTests:

  • fast/dom/event-handler-attributes-expected.txt:

Rebaseline tests now that more checks are passing.

  • js/dom/dom-static-property-for-in-iteration-expected.txt:

Rebaseline test now that enumeration order is different.

9:04 PM Changeset in webkit [202538] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[macOS] Test gardening: Generic font families should not map to fonts which aren't installed
https://bugs.webkit.org/show_bug.cgi?id=159111
<rdar://problem/25807529>

Unreviewed.

Osaka-Mono does not come preinstalled on macOS Sierra. However, many Japanese users
will have the font installed. Before setting the generic font family, we should check
to see if the font is present.

  • page/cocoa/SettingsCocoa.mm:

(WebCore::osakaMonoIsInstalled):
(WebCore::Settings::initializeDefaultFontFamilies):

8:25 PM Changeset in webkit [202537] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't keep all newly created potential custom elements alive when the feature is disabled
https://bugs.webkit.org/show_bug.cgi?id=159113

Reviewed by Daniel Bates.

Don't keep all HTML unknown elements which has a valid custom element alive when the feature is turned off.

Ideally we want to conform to the behavior in the Custom Elements specification and only upgrade an element
that is inserted into the document. We'll implement that later.

  • dom/Document.cpp:

(WebCore::createHTMLElementWithNameValidation):

7:58 PM Changeset in webkit [202536] by Simon Fraser
  • 7 edits
    4 adds in trunk

[iOS] -webkit-overflow-scrolling: touch prevents repaint with RTL
https://bugs.webkit.org/show_bug.cgi?id=159186
rdar://problem/26659341

Reviewed by Zalan Bujtas.
Source/WebCore:

There were two issues with repaints in -webkit-overflow-scrolling:touch scrolling
layers.

First, if the scrolled contents were inline (e.g. a <span>), then repaints were
broken because RenderInline didn't call shouldApplyClipAndScrollPositionForRepaint().
Fix by making shouldApplyClipAndScrollPositionForRepaint() a member function of RenderBox
and calling it from RenderBox::computeRectForRepaint() and RenderInline::clippedOverflowRectForRepaint().

Second, repaints were broken in RTL because RenderLayerBacking::setContentsNeedDisplayInRect()
confused scroll offset and scroll position; it needs to subtract scrollPosition.

Finally renamed to applyCachedClipAndScrollOffsetForRepaint() to applyCachedClipAndScrollPositionForRepaint()
to make it clear that it uses scrollPosition, not scrollOffset.

Tests: compositing/scrolling/touch-scrolling-repaint-spans.html

compositing/scrolling/touch-scrolling-repaint.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::applyCachedClipAndScrollPositionForRepaint):
(WebCore::RenderBox::shouldApplyClipAndScrollPositionForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::applyCachedClipAndScrollOffsetForRepaint): Deleted.
(WebCore::shouldApplyContainersClipAndOffset): Deleted.

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::computeRectForRepaint):

LayoutTests:

  • compositing/scrolling/touch-scrolling-repaint-expected.html: Added.
  • compositing/scrolling/touch-scrolling-repaint-spans-expected.html: Added.
  • compositing/scrolling/touch-scrolling-repaint-spans.html: Added.
  • compositing/scrolling/touch-scrolling-repaint.html: Added.
7:47 PM Changeset in webkit [202535] by Michael Catanzaro
  • 2 edits in trunk/Tools

[GTK][EFL] Disable subtle-crypto in FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=155073

Reviewed by Daniel Bates.

  • Scripts/webkitperl/FeatureList.pm:
7:38 PM Changeset in webkit [202534] by dino@apple.com
  • 12 edits in trunk/Websites/webkit.org

Updated content for the color blog post.

  • blog-files/color-gamut/Iceland-P3.jpg:
  • blog-files/color-gamut/Iceland-oog.jpg:
  • blog-files/color-gamut/Iceland-sRGB.jpg:
  • blog-files/color-gamut/Italy-P3.jpg:
  • blog-files/color-gamut/Italy-sRGB.jpg:
  • blog-files/color-gamut/Sunset-P3.jpg:
  • blog-files/color-gamut/Sunset-sRGB.jpg:
  • blog-files/color-gamut/YellowFlower-P3.jpg:
  • blog-files/color-gamut/YellowFlower-oog.jpg:
  • blog-files/color-gamut/YellowFlower-sRGB.jpg:
  • blog-files/color-gamut/index.html:
7:00 PM Changeset in webkit [202533] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r202436.
https://bugs.webkit.org/show_bug.cgi?id=159190

We don't need to make this change. (Requested by thorton on
#webkit).

Reverted changeset:

"Do not use iOS specific telephone detection on macOS."
https://bugs.webkit.org/show_bug.cgi?id=159096
http://trac.webkit.org/changeset/202436

6:44 PM Changeset in webkit [202532] by Simon Fraser
  • 9 edits in trunk

[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
https://bugs.webkit.org/show_bug.cgi?id=159077

Reviewed by Tim Horton.

Source/WebKit2:

Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
which is necessary for UI-side compositing.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::forceRepaint):

Tools:

Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.

Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
which is necessary for UI-side compositing.

Add some null checks to fix issues when the WKWebView gets resized to be empty, which
seems to happen for some tests that call window.resizeTo().

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Deleted.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpResults):

  • WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromImage):
(WTR::computeMD5HashStringForContext):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::windowSnapshotImage):

LayoutTests:

fast/harness/snapshot-captures-compositing.html passes now.

  • platform/ios-simulator-wk2/TestExpectations:
6:13 PM Changeset in webkit [202531] by benjamin@webkit.org
  • 6 edits
    12 adds in trunk

Adopt the iOS TouchEventHandler API for cases that must have synchronous dispatch
https://bugs.webkit.org/show_bug.cgi?id=159179
rdar://problem/27006387

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state.html

fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state.html
fast/events/touch/ios/block-without-overflow-scroll-scrolling-state.html
fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html
fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html
fast/events/touch/ios/drag-block-without-overflow-scroll.html

  • dom/Document.cpp:

(WebCore::Document::prepareForDestruction):
(WebCore::Document::removeAllEventListeners):

  • dom/Node.cpp:

(WebCore::Node::willBeDeletedFrom):
(WebCore::tryAddEventListener):
(WebCore::tryRemoveEventListener):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::registerForTouchEvents):
(WebCore::SliderThumbElement::unregisterForTouchEvents):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::registerAsTouchEventListenerForScrolling):
(WebCore::RenderLayer::unregisterAsTouchEventListenerForScrolling):

LayoutTests:

Several of those tests expose existing bugs with overflow scrolling.
They are not using PASS/FAIL at the moment, just dump the called listeners.

  • fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt: Added.
  • fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state.html: Added.
  • fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt: Added.
  • fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state.html: Added.
  • fast/events/touch/ios/block-without-overflow-scroll-scrolling-state-expected.txt: Added.
  • fast/events/touch/ios/block-without-overflow-scroll-scrolling-state.html: Added.
  • fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt: Added.
  • fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html: Added.
  • fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt: Added.
  • fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html: Added.
  • fast/events/touch/ios/drag-block-without-overflow-scroll-expected.txt: Added.
  • fast/events/touch/ios/drag-block-without-overflow-scroll.html: Added.
6:00 PM Changeset in webkit [202530] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Windows build.

  • bindings/js/SerializedScriptValue.h:

WTF

5:55 PM Changeset in webkit [202529] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

Web Inspector: When modifying sessionStorage, localStorage gets updated
https://bugs.webkit.org/show_bug.cgi?id=159181
<rdar://problem/27043447>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-27
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

  • UserInterface/Test/Test.js:

(WebInspector.loaded):
Add registration for StorageManager and StorageObserver.

Source/WebKit2:

  • WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
This should be dispatching storage events.

LayoutTests:

  • inspector/storage/domStorage-events-expected.txt: Added.
  • inspector/storage/domStorage-events.html: Added.

Add a new test for DOMStorage domain events. Ensures that sessionStorage
and localStorage events are dispatched for the appropriate DOMStorageObject.

5:42 PM Changeset in webkit [202528] by keith_miller@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

Fix bad assert in StructureRareData::setObjectToStringValue
https://bugs.webkit.org/show_bug.cgi?id=159171
<rdar://problem/26987355>

Reviewed by Mark Lam.

We should not have expected the generateConditionsForPrototypePropertyHit would succeed.
There are many reasons it might fail including that there is a proxy somewhere on the
prototype chain of the object.

  • runtime/StructureRareData.cpp:

(JSC::StructureRareData::setObjectToStringValue):

  • tests/stress/object-toString-with-proxy.js: Added.

(get target):

5:36 PM Changeset in webkit [202527] by Ryan Haddad
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r202520.
https://bugs.webkit.org/show_bug.cgi?id=159185

This change broke the 32-bit El Capitan build (Requested by
ryanhaddad on #webkit).

Reverted changeset:

"REGRESSION?(r202466): http/tests/security/canvas-remote-read-
remote-video-redirect.html failing on Sierra"
https://bugs.webkit.org/show_bug.cgi?id=159172
http://trac.webkit.org/changeset/202520

Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-27

5:36 PM Changeset in webkit [202526] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

[Cocoa] Test gardening for the system font in macOS Sierra and iOS 10
https://bugs.webkit.org/show_bug.cgi?id=159175
<rdar://problem/26478081>

Unreviewed.

  • fast/text/trak-optimizeLegibility.html:
5:34 PM Changeset in webkit [202525] by achristensen@apple.com
  • 5 edits
    3 deletes in trunk

Fix flakiness on Sierra after r202511
https://bugs.webkit.org/show_bug.cgi?id=159071

Source/WebKit2:

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSession::clearCredentials):
Replacing the NSURLSessions immediately caused assertions because the tasks are not always all stopped immediately when tearing down a test.
Stopping an NSURLSession needs to be done asynchronously. I'll try a different testing technique for r202511.

LayoutTests:

  • http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt: Removed.
  • http/tests/xmlhttprequest/sync-delegate-callbacks.html: Removed.
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/wk2/http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt: Removed.
5:33 PM Changeset in webkit [202524] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit/mac

REGRESSION (r189052): Clipping occurs when using context menu to Look Up words within the Dictionary app
https://bugs.webkit.org/show_bug.cgi?id=159184
<rdar://problem/26370206>

Reviewed by Beth Dakin.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _lookUpInDictionaryFromMenu:]):

  • WebView/WebImmediateActionController.h:
  • WebView/WebImmediateActionController.mm:

(+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
(-[WebImmediateActionController _animationControllerForText]):
(dictionaryPopupInfoForRange): Deleted.
WebImmediateActionController's code to make a DictionaryPopupInfo and TextIndicator
from a Range in WebKit1 is much better than WebHTMLView's; use it in both cases.

5:26 PM Changeset in webkit [202523] by Gyuyoung Kim
  • 2 edits in trunk/Tools

[EFL] Support to build on Debian linux
https://bugs.webkit.org/show_bug.cgi?id=159123

Reviewed by Antonio Gomes.

  • efl/install-dependencies: Install libgnutls28-dev.
5:23 PM Changeset in webkit [202522] by Brian Burg
  • 6 edits
    4 adds in trunk

Web Inspector: RuntimeManager should not use view object WebInspector.quickConsole
https://bugs.webkit.org/show_bug.cgi?id=128092
<rdar://problem/15966526>

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

This is a layering violation which makes it harder to use RuntimeManager.evaluateInInspectedWindow
from a testing context where the QuickConsole view does not exist.

Store the selected execution context identifier on RuntimeManager and use it
when doing subsequent evaluations that act on the currently selected frame.

  • UserInterface/Controllers/RuntimeManager.js:

(WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
(WebInspector.RuntimeManager.prototype.saveResult):
Use local state.

(WebInspector.RuntimeManager.prototype.get defaultExecutionContextIdentifier):
(WebInspector.RuntimeManager.prototype.set defaultExecutionContextIdentifier):
Added.

(WebInspector.RuntimeManager):

  • UserInterface/Models/ExecutionContext.js:

(WebInspector.ExecutionContext):
Move the symbolic name for the top level execution context to RuntimeManager.

  • UserInterface/Test/Test.js:

(WebInspector.loaded): No need to stub out WebInspector.QuickConsole any more.

  • UserInterface/Views/QuickConsole.js:

(WebInspector.QuickConsole.prototype._framePageExecutionContextsChanged):
(WebInspector.QuickConsole.prototype._removeExecutionContextPathComponentForFrame):
(WebInspector.QuickConsole.prototype._updateExecutionContextPathComponentForFrame):
(WebInspector.QuickConsole.prototype._pathComponentSelected):
For now, set RuntimeManager's selected execution context whenever we set the
selected path component. In a future patch, we should invert the dependency and have
the selected component change whenever RuntimeManager.defaultExecutionContext changes.

LayoutTests:

Add some really basic coverage for RuntimeManager.defaultExecutionContextIdentifier
and using it in RuntimeManager.evaluateInInspectedWindow.

  • inspector/runtime/change-execution-context-identifier-expected.txt: Added.
  • inspector/runtime/change-execution-context-identifier.html: Added.
  • inspector/runtime/resources/change-execution-context-identifier-subframe.html: Added.
4:59 PM Changeset in webkit [202521] by Jon Davis
  • 2 edits in trunk/Websites/webkit.org

Set a default image for sharing webkit.org links via social.
https://bugs.webkit.org/show_bug.cgi?id=159167

Reviewed by Timothy Hatcher.

  • wp-content/plugins/social-meta.php:
4:56 PM Changeset in webkit [202520] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

REGRESSION?(r202466): http/tests/security/canvas-remote-read-remote-video-redirect.html failing on Sierra
https://bugs.webkit.org/show_bug.cgi?id=159172
<rdar://problem/27030025>

Reviewed by Brent Fulgham.

Add a hasSingleSecurityOrigin property to WebCoreNSURLSession that gets updated each time one of that
sessions' tasks receieves a response or a redirect request. Check that property from the MediaPlayerPrivate.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin):

  • platform/network/cocoa/WebCoreNSURLSession.h:
  • platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSession updateHasSingleSecurityOrigin:]):
(-[WebCoreNSURLSession dataTaskWithRequest:]):
(-[WebCoreNSURLSession dataTaskWithURL:]):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]):

4:26 PM Changeset in webkit [202519] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Crashing at an unreachable code trap in FTL should give more information
https://bugs.webkit.org/show_bug.cgi?id=159177

Reviewed by Saam Barati.

This stuffs information into registers so that we have some chance of seeing what happened
by looking at the register dumps.

  • assembler/AbortReason.h:
  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::ftlUnreachable):
(JSC::FTL::DFG::LowerDFGToB3::compileBlock):
(JSC::FTL::DFG::LowerDFGToB3::crash):

3:26 PM Changeset in webkit [202518] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Clean up resetting reachability in B3/Air
https://bugs.webkit.org/show_bug.cgi?id=159170

Reviewed by Geoffrey Garen.

When I fixed bug 159165, I took the brute force approach. I still used the
B3::resetReachability() method, and changed the callback to record the set of deleted values
instead of deleting them eagerly. But this means tracking the set of deleted values, even
though resetReachability() already internally tracks the set of deleted blocks. You can find
out if a value is deleted by asking if its owning block was deleted.

So, this change refactors B3::resetReachability() into a new helper called
B3::recomputePredecessors(). This new helper skips the block deletion step, and lets the
client delete blocks. This lets Air delete blocks the same way that it did before, and it
lets B3 use the isBlockDead() method (which is a glorified proxy for
block->predecessors().isEmpty()) to track which values are deleted. This allows B3 to turn
Upsilons that point to dead Phis into Nops before deleting the blocks.

This shouldn't affect performance or anything real. It just makes the code cleaner.

  • b3/B3BasicBlockUtils.h:

(JSC::B3::updatePredecessorsAfter):
(JSC::B3::recomputePredecessors):
(JSC::B3::isBlockDead):
(JSC::B3::resetReachability): Deleted.

  • b3/B3Procedure.cpp:

(JSC::B3::Procedure::resetReachability):
(JSC::B3::Procedure::invalidateCFG):

  • b3/air/AirCode.cpp:

(JSC::B3::Air::Code::resetReachability):
(JSC::B3::Air::Code::dump):

3:20 PM Changeset in webkit [202517] by benjamin@webkit.org
  • 5 edits
    14 adds in trunk

Fix style invalidation for :active when the activated node has no renderer
https://bugs.webkit.org/show_bug.cgi?id=159125

Reviewed by Antti Koivisto.

Source/WebCore:

Same old bug: a style invalidation path was depending
on the style.

Here we really need both flags. An element can have
childrenAffectedByActive() false and renderStyle->affectedByActive() true
if it was subject to style sharing.

The element state "childrenAffectedByActive" should be renamed
"styleAffectedByActive" since it is not a parent invalidation flag.
That will be done separately.

Tests: fast/css/pseudo-active-on-labeled-control-without-renderer.html

fast/css/pseudo-active-style-sharing-1.html
fast/css/pseudo-active-style-sharing-2.html
fast/css/pseudo-active-style-sharing-3.html
fast/css/pseudo-active-style-sharing-4.html
fast/css/pseudo-active-style-sharing-5.html
fast/css/pseudo-active-style-sharing-6.html

  • dom/Element.cpp:

(WebCore::Element::setActive):

  • style/StyleRelations.cpp:

(WebCore::Style::commitRelationsToRenderStyle):

LayoutTests:

There was no bug with style sharing but I wanted that covered anyway.
Style sharing depends on 2 flags which is uncommon.
There was no test coverage whatsoever, breaking it did not fail any test.

  • fast/css/pseudo-active-on-labeled-control-without-renderer-expected.txt: Added.
  • fast/css/pseudo-active-on-labeled-control-without-renderer.html: Added.
  • fast/css/pseudo-active-style-sharing-1-expected.txt: Added.
  • fast/css/pseudo-active-style-sharing-1.html: Added.
  • fast/css/pseudo-active-style-sharing-2-expected.txt: Added.
  • fast/css/pseudo-active-style-sharing-2.html: Added.
  • fast/css/pseudo-active-style-sharing-3-expected.txt: Added.
  • fast/css/pseudo-active-style-sharing-3.html: Added.
  • fast/css/pseudo-active-style-sharing-4-expected.txt: Added.
  • fast/css/pseudo-active-style-sharing-4.html: Added.
  • fast/css/pseudo-active-style-sharing-5-expected.txt: Added.
  • fast/css/pseudo-active-style-sharing-5.html: Added.
  • fast/css/pseudo-active-style-sharing-6-expected.txt: Added.
  • fast/css/pseudo-active-style-sharing-6.html: Added.
3:13 PM Changeset in webkit [202516] by jdiggs@igalia.com
  • 3 edits
    3 adds in trunk

AX: REGRESSION (r202063): ARIA role attribute is being ignored for label element
https://bugs.webkit.org/show_bug.cgi?id=159162

Reviewed by Chris Fleizach.

Source/WebCore:

createFromRenderer() was creating an AccessibilityLabel for any HTMLLabelElement which
lacked an explicitly-handled ARIA role. We should instead create an AccessibilityLabel
when there is no ARIA role.

Test: accessibility/aria-role-on-label.html

  • accessibility/AXObjectCache.cpp:

(WebCore::createFromRenderer):

LayoutTests:

This regression was caught by a GTK-specific layout test. Adding a cross-platform
test for additional coverage.

  • accessibility/aria-role-on-label.html: Added.
  • platform/gtk/accessibility/aria-role-on-label-expected.txt: Added.
  • platform/mac/accessibility/aria-role-on-label-expected.txt: Added.
2:50 PM Changeset in webkit [202515] by Brian Burg
  • 2 edits in trunk/Source/JavaScriptCore

Web Inspector: CRASH in backend at Inspector::HeapFrontendDispatcher::garbageCollected + 552 when closing frontend/inspected page
https://bugs.webkit.org/show_bug.cgi?id=159075
<rdar://problem/26094341>

Reviewed by Filip Pizlo.

This change caused JSC stress tests to all hit an assertion in RunLoop.
We should use RunLoop::current() to create the RunLoop::Timer since JSC-only
clients like testapi and jsc don't ever call initializeMainRunLoop().

  • inspector/agents/InspectorHeapAgent.cpp:

(Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):

2:45 PM Changeset in webkit [202514] by Ryan Haddad
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r202505.
https://bugs.webkit.org/show_bug.cgi?id=159169

The test added with this change is flaky and it caused an
existing test to time out on El Capitan. (Requested by
ryanhaddad on #webkit).

Reverted changeset:

"[iOS] Media controls are too cramped with small video"
https://bugs.webkit.org/show_bug.cgi?id=158815
http://trac.webkit.org/changeset/202505

Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-27

2:44 PM Changeset in webkit [202513] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Add :focus-within to the status page

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-27

  • features.json:

I forgot to update the json file when landing the feature.

2:36 PM Changeset in webkit [202512] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

B3::Procedure::resetReachability() can create dangling references from Upsilons to Phis
https://bugs.webkit.org/show_bug.cgi?id=159165

Reviewed by Mark Lam.

You can delete an unreachable block that has a Phi but some prior block may still have an
Upsilon pointing to that Phi. This can happen if the Upsilon precedes a Check that always
exits or it can happen if we remove some successor of a block and this block had an Upsilon
for one of the removed successors. These things are valid IR even if they are not canonical.
Our policy for not-canonical-but-valid IR is that the compiler should still emit valid code
in the end.

The solution is to have Procedure::resetReachability() turn those Upsilons into Nops.

  • b3/B3Procedure.cpp:

(JSC::B3::Procedure::resetReachability): Fix the bug.

  • b3/B3Validate.h:
  • b3/testb3.cpp:

(JSC::B3::testResetReachabilityDanglingReference): Add a test. This always crashes prior to this change.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::killUnreachableBlocks): Add a FIXME about a possible similar bug.

1:59 PM Changeset in webkit [202511] by commit-queue@webkit.org
  • 32 edits
    3 adds in trunk

Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
https://bugs.webkit.org/show_bug.cgi?id=159071

Patch by Alex Christensen <achristensen@webkit.org> on 2016-06-27
Reviewed by Brady Eidson.

Source/WebKit2:

When CFNetwork asks the NetworkProcess if we can authenticate against this protection space, we used to ask
the WebProcess, which would call ResourceLoader::canAuthenticateAgainstProtectionSpace which would ask the FrameLoaderClient,
which would synchronously ask the UIProcess. Going directly from the NetworkProcess to the UIProcess gives us many advantages:

  1. It reduces IPC because we ask fewer loads.
  2. It reduces synchronous IPC because we are not using the same code path as WebKit1 any more.
  3. It allows us to check if the NetworkProcess is still valid in sendToNetworkingProcess, possibly fixing rdar://problem/26825408
  4. It allows us to ask the UIProcess when we get authentication challenges for synchronous xhr.

I added a new test http/tests/xmlhttprequest/sync-delegate-callbacks.html to verify the change in behavior of synchronous xhr.
In order to make this test not flaky on platforms using NSURLSession, we clear the NSURLSessions used by WebKitTestRunner
to make sure that the TLS session cache is cleared so we get NSURLAuthenticationChallenges corresponding to the NSURLConnection
canAuthenticateAgainstProtectionSpace callback when we initiate the first HTTPS connection to 127.0.0.1 with this session.

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::didReceiveChallenge):
(WebKit::NetworkLoad::didReceiveResponseNetworkSession):
(WebKit::NetworkLoad::canAuthenticateAgainstProtectionSpaceAsync):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::clearCachedCredentials):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::cancelDownload):
(WebKit::NetworkProcess::canAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcess::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcess::continueCanAuthenticateAgainstProtectionSpaceDownload):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/NetworkResourceLoader.messages.in:
  • NetworkProcess/NetworkSession.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSession::networkStorageSession):
(WebKit::NetworkSession::clearCredentials):
(WebKit::NetworkSession::dataTaskForIdentifier):

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::canAuthenticateAgainstProtectionSpace):
(WebKit::DownloadProxy::willSendRequest):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::logSampledDiagnosticMessageWithValue):
(WebKit::NetworkProcessProxy::canAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcessProxy::sendProcessWillSuspendImminently):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.messages.in:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::backForwardClear):
(WebKit::WebPageProxy::canAuthenticateAgainstProtectionSpace):
(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):
(WebKit::WebPageProxy::canAuthenticateAgainstProtectionSpaceInFrame): Deleted.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResource):
(WebKit::WebResourceLoader::isAlwaysOnLoggingAllowed):
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace): Deleted.

  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::clearCachedCredentials):
(WebKit::WebProcess::focusedWebPage):

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setHandlesAuthenticationChallenges):
(WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
(WTR::TestRunner::setAuthenticationUsername):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::didFinishNavigation):
(WTR::TestController::canAuthenticateAgainstProtectionSpace):
(WTR::TestController::didReceiveAuthenticationChallenge):
(WTR::TestController::didCommitNavigation):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::setBlockAllPlugins):
(WTR::TestController::setShouldLogHistoryClientCallbacks):
(WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
(WTR::TestController::isCurrentInvocation):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.

LayoutTests:

  • http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt: Added.
  • http/tests/xmlhttprequest/sync-delegate-callbacks.html: Added.
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/wk2/http/tests/xmlhttprequest/sync-delegate-callbacks-expected.txt: Added.
1:52 PM Changeset in webkit [202510] by ap@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

Remove OS X Mavericks test results

Rubber-stamped by Lucas Forschler.

  • platform/mac-mavericks: Removed.
1:37 PM Changeset in webkit [202509] by eric.carlson@apple.com
  • 5 edits in trunk

[Mac] PiP placeholder should remain visible when 'controls' attribute is removed
https://bugs.webkit.org/show_bug.cgi?id=159158
<rdar://problem/26727435>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, existing test updated.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.shouldHaveControls): Always return true when in PiP or AirPlay mode.

LayoutTests:

  • media/controls/picture-in-picture-expected.txt: Updated.
  • media/controls/picture-in-picture.html: Ditto.
12:52 PM Changeset in webkit [202508] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add comment to Module feature in features.json
https://bugs.webkit.org/show_bug.cgi?id=159159

Reviewed by Saam Barati.

  • features.json:
12:17 PM Changeset in webkit [202507] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Update ATS WebContent exception for more robust framework information
https://bugs.webkit.org/show_bug.cgi?id=159151

Reviewed by Alex Christensen.

We found some unexpected poor interaction with AVFoundation in the existing
CFNetwork SPI. This new SPI is more solid and let's us provide more useful
information while also being more future proof against new frameworks and
ATS modes.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):

12:11 PM Changeset in webkit [202506] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WTF

Remove now unused WTF::findNextLineStart
https://bugs.webkit.org/show_bug.cgi?id=159157

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-27
Reviewed by Mark Lam.

Unused after r202498.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::findNextLineStart): Deleted.

  • wtf/text/StringImpl.h:

(WTF::findNextLineStart): Deleted.

  • wtf/text/WTFString.h:

(WTF::String::findNextLineStart): Deleted.

12:06 PM Changeset in webkit [202505] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

[iOS] Media controls are too cramped with small video
https://bugs.webkit.org/show_bug.cgi?id=158815
<rdar://problem/26824238>

Patch by Antoine Quint <Antoine Quint> on 2016-06-27
Reviewed by Dean Jackson.

Source/WebCore:

In updateLayoutForDisplayedWidth(), we try to ensure a minimum width is guaranteed
for the progress indicator. However, we were not accounting for the width used by
the current and remaining time labels on either side of it, so we would incorrectly
conclude that we were guaranteeing the minimum time and yield incorrect layouts since
we were trying to fit more buttons than we had room for.

In order to correctly compute the available width for the progress indicator, we now
have clones of the current and remaining time labels, hidden from video and VoiceOver,
that we update along with the originals. The same styles apply to both clones and
originals, so we may measure the clones to determine the space used by the time labels.
The reason we need to use clones is that if the time labels had previously been hidden
from view, precisely because there was not enough space to display them along with the
progress indicator, then trying to obtain metrics from them would yield 0 since they had
"display: none" styles applied. In order to avoid extra layouts and possible flashing, we
use the clones so that we never have to toggle the "display" property of the originals
just to obtain their measurements.

As a result of this change, we adjust the constant used to set the minimum required
width available to display the progress indicator after all other essential controls
and labels have been measured. That constant used to account for the width of the
time labels, and this is no longer correct.

Test: media/video-controls-drop-and-restore-timeline.html

  • Modules/mediacontrols/mediaControlsApple.css:

(::-webkit-media-controls-time-remaining-display.clone):

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller):
(Controller.prototype.createTimeClones):
(Controller.prototype.removeTimeClass):
(Controller.prototype.addTimeClass):
(Controller.prototype.updateDuration):
(Controller.prototype.updateLayoutForDisplayedWidth):
(Controller.prototype.updateTime):
(Controller.prototype.updateControlsWhileScrubbing):

  • Modules/mediacontrols/mediaControlsiOS.css:

(::-webkit-media-controls-time-remaining-display.clone):

  • Modules/mediacontrols/mediaControlsiOS.js:

LayoutTests:

Adjust the output of this test to account for the time label clones and add a new test.

  • media/video-controls-drop-and-restore-timeline-expected.txt: Added.
  • media/video-controls-drop-and-restore-timeline.html: Added.
  • platform/mac-yosemite/http/tests/media/hls/video-controls-live-stream-expected.txt:
  • platform/mac/http/tests/media/hls/video-controls-live-stream-expected.txt:
12:06 PM Changeset in webkit [202504] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Discounted items are displayed with positive values
https://bugs.webkit.org/show_bug.cgi?id=159160
rdar://problem/26980772

Reviewed by Dean Jackson.

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toDecimalNumber):
Add new helper function. Correctly compute the mantissa.

(WebKit::toPKPaymentSummaryItem):
(WebKit::toPKShippingMethod):
Use toDecimalNumber.

11:52 AM Changeset in webkit [202503] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Update features.json for ES6 completed features.
https://bugs.webkit.org/show_bug.cgi?id=159152

Reviewed by Mark Lam.

  • features.json:
11:35 AM Changeset in webkit [202502] by fpizlo@apple.com
  • 12 edits
    2 adds in trunk/Source/JavaScriptCore

B3 should not use Nops when deleting unreachable code
https://bugs.webkit.org/show_bug.cgi?id=159120
rdar://problem/26500743

Reviewed by Michael Saboff.

Prior to this change, transformations that obviated the need for some value could choose
from these ways to kill it:

  • replaceWithIdentity() if we're replacing with another value.
  • replaceWithNop() if the type is Void or if we know that we'll fix any users of this value.
  • deleteValue() if the code is unreachable.


The bug here is that reduceStrength() was being clever about how to get rid of a value.
reduceStrength() may find a Check that must always exit. The goal is to remove any code
dominated by the Check. But it would be awkward to eagerly delete all of the blocks
dominated by this one. So this code took a much simpler approach: it would
replaceWithNop() for all of the values in this block after the Check and it would replace
the terminal with Oops.

But this corrupts the IR in a subtle way: some of those values may have been non-Void but
now they are Nops so they are Void. reduceStrength() will not yet realize that the blocks
dominated by the one with the Check are unreachable, so it will run all sorts of
optimizations on those blocks. This could have probably manifested as many different kinds
of badness, but the way I found out about this issue was through a crash in
IntRange::top(Type) when inlined into ReduceStrength::rangeFor(). We'd die in a switch
statement over a child's type.

We could fix this by making rangeFor() tolerate Void. But I think that this would be
dangerous. There could easily be other places in reduceStrength() that assume that value's
children are non-Void. So, this change fixes the Check optimization and adds mechanisms to
prevent other optimizations from breaking the children-are-not-Void rule.

This introduces two high-level changes:

  • It's no longer legal to replaceWithNop() if the value is not Void. This change alone would cause reduceStrength() to instacrash in its Check optimization. Almost all other uses of replaceWithNop() were already following this rule, so they were fine. One other place was using replaceWithNop() on non-Void values after arranging for them to no longer have any parents. That was changed to call replaceWithNopIgnoringType(), which doesn't have any type assertions.


  • For reduceStrength() there is a new Value::replaceWithBottom() method that works with Void or non-Void and behaves like you would want replaceWithNop() to behave: if you know that the code is unreachable then it produces something that is guaranteed to be deleted by later optimizations, and if it's not unreachable, then it's guaranteed to be compiled to something harmless and cheap. This means replacing the value with an identity that points to a bottom constant (the 0 for whatever type we have), or just replacing it with Nop if it's Void.


This also adds a test case for the reason why we do this: we may have two blocks, where
the first block unconditionally exits while dominating the second block. The second block
references values in the part of the first block that is unreachable. In trunk, this test
would assert in ReduceStrength::rangeFor() because the CheckAdd in the second block would
reference a Nop in the first block.

This fixes a high volume crash in ReduceStrength::rangeFor(). This crash was very
confusing. Even though we were crashing at a RELEASE_ASSERT_NOT_REACHED() in a switch
statement in IntRange::top(Type), clang was merging that trap with the trap it used for
Vector OOB. The top of the stack in crash dumps looked like:

JSC::B3::(anonymous namespace)::ReduceStrength::rangeFor(JSC::B3::Value*, unsigned int) + 4477 (Vector.h:655)


Where Vector.h:655 is:

OverflowHandler::overflowed();

But this crash was not at Vector.h:655. It was at B3ReduceStrength.cpp:121. The two lines
are both traps, so they got merged despite differences in debug info. This bug would have
been so much easier to fix if I had the right line number.

  • b3/B3BottomProvider.h: Added. This is a utility for creating bottom values.

(JSC::B3::BottomProvider::BottomProvider):
(JSC::B3::BottomProvider::operator()):

  • b3/B3InsertionSet.cpp: Optimized adding bottom values a bit. We will no longer create pointless duplicates.

(JSC::B3::InsertionSet::insertBottom):
(JSC::B3::InsertionSet::execute):
(JSC::B3::InsertionSet::bottomForType):

  • b3/B3InsertionSet.h:
  • b3/B3MoveConstants.cpp: Use replaceWithNopIgnoringType() because we *know* that we can replaceWithNop even for non-Void.
  • b3/B3Procedure.h:
  • b3/B3ReduceStrength.cpp: Use replaceWithBottom().
  • b3/B3ReduceStrength.h:
  • b3/B3TypeMap.h: I figured if I wrote type-casing code like this once then I'd never want to write it again.
  • b3/B3Value.cpp:

(JSC::B3::Value::replaceWithIdentity):
(JSC::B3::Value::replaceWithNop):
(JSC::B3::Value::replaceWithNopIgnoringType):

  • b3/B3Value.h:
  • b3/B3ValueInlines.h:

(JSC::B3::Value::replaceWithBottom): This is the new method of killing unreachable code.
(JSC::B3::Value::as):

  • b3/testb3.cpp: Add new tests!

(JSC::B3::testLateRegister):
(JSC::B3::testReduceStrengthCheckBottomUseInAnotherBlock):
(JSC::B3::zero):
(JSC::B3::run):

11:30 AM Changeset in webkit [202501] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

11:29 AM Changeset in webkit [202500] by bshafiei@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

11:28 AM Changeset in webkit [202499] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

No error message when passing an invalid API version to ApplePaySession constructor
https://bugs.webkit.org/show_bug.cgi?id=159154

Reviewed by Tim Horton.

Log an error message if the version is not supported. Also, check for version 0 since that is also not supported.

  • Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::create):

11:18 AM Changeset in webkit [202498] by Joseph Pecoraro
  • 5 edits in trunk

REGRESSION: Web Inspector: Text search broken in resources with <CR>
https://bugs.webkit.org/show_bug.cgi?id=159110
<rdar://problem/27008485>

Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::lineEndings):
The frontend moved to only treated newlines as line endings in
the TextEditor. The backend however was looking for many
different types of line endings (\r\n, \r, \n). This caused
the line endings to ultimately differ between the frontend
and the backend, so the frontend couldn't find the lines that
the backend was claiming search results were on. Change the
backend to only look for \n line endings.

LayoutTests:

  • inspector/debugger/searchInContent-linebreaks-expected.txt:
  • inspector/debugger/searchInContent-linebreaks.html:

Now that the backend responds with lines that end in \n, this test changes
the number of line results. The frontend interprets this correctly.

10:57 AM Changeset in webkit [202497] by jdiggs@igalia.com
  • 11 edits
    6 adds in trunk

AX: Anonymous RenderMathMLOperators are not exposed to the accessibility tree
https://bugs.webkit.org/show_bug.cgi?id=139582
<rdar://problem/26938849>

Reviewed by Chris Fleizach.

This is based on a patch by Frederic Wang <fwang@igalia.com>.

Source/WebCore:

WebCore assigns the generic MathElementRole AccessibilityRole to elements
which are expected to be included in the accessibility tree. This assignment
is based on the AccessibilityRenderObject's node being a MathMLElement. The
anonymous RenderMathMLOperators fail that test.

From the perspective of accessibility support, these operators function
like MathMLElements. Furthermore, both WebCore and the platforms rely
upon MathElementRole to identify accessible MathML objects. The simplest
fix is to have AccessibilityRenderObject::isMathElement() treat anonymous
MathML operators as if they were MathMLElements.

Now that these operators are being exposed, we need to handle them in
AccessibilityRenderObject::textUnderElement() which assumes that anonymous
objects either have nodes or have children with nodes. And crashes when
that fails to be the case. Making RenderMathMLOperator::textContent()
public and then using it to get the text under anonymous operators solves
this problem. We also assign StaticTextRole to these operators on the Mac
because the default platform mapping of MathElementRole is GroupRole, which
made sense when we had a child RenderText object holding the operator.

Lastly, AccessibilityRenderObject::isIgnoredElementWithinMathTree() no
longer needs to special-case anonymous operators because they now have
MathElementRole.

Tests: accessibility/math-fenced.html

accessibility/math-foreign-content.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isAnonymousMathOperator):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::isMathElement):
(WebCore::AccessibilityRenderObject::isAnonymousMathOperator):
(WebCore::AccessibilityRenderObject::isIgnoredElementWithinMathTree):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper role]):

  • rendering/mathml/RenderMathMLMath.h:
  • rendering/mathml/RenderMathMLOperator.h:

(WebCore::RenderMathMLOperator::textContent):

LayoutTests:

One of the things making it difficult to tell that the operators were not
exposed on the Mac is the fact that the operator text is present. But the
operator text is simply a StaticTextRole object corresponding to the
RenderText descendant of the operator. Furthermore, on the Mac, accessible
math operators have subroles which are missing from the StaticTextRole
object which is exposed. In order to make issues like this more obvious,
add an option to include the subrole to dumpAccessibilityTree() and use it
in the new math-fenced.html.

This change also fixes the mfenced in mac/mathml-elements.html that was
broken after r202420. We enable it again and update the expectations of
that test because the operators are now in the accessibility tree.

We also add a new test to verify the render tree of foreign content in
MathML formulas.

  • accessibility/mac/mathml-elements-expected.txt: Updated.
  • accessibility/mac/mathml-elements.html: Re-enable the mfenced test.
  • accessibility/math-fenced.html: Added.
  • accessibility/math-foreign-content.html: Added.
  • platform/gtk/accessibility/math-fenced-expected.txt: Added.
  • platform/gtk/accessibility/math-foreign-content-expected.txt: Added.
  • platform/mac/accessibility/math-fenced-expected.txt: Added.
  • platform/mac/accessibility/math-foreign-content-expected.txt: Added.
  • resources/accessibility-helper.js: Add option to include subrole in tree.

(dumpAccessibilityTree):

10:57 AM Changeset in webkit [202496] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Remove flaky expectation for imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_loadeddata.html
https://bugs.webkit.org/show_bug.cgi?id=150956

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:53 AM Changeset in webkit [202495] by adam.bergkvist@ericsson.com
  • 4 edits in trunk/LayoutTests

WebRTC: Unskip RTCPeerConnection-AddRemoveStream test
https://bugs.webkit.org/show_bug.cgi?id=159133

Reviewed by Eric Carlson.

Unskip RTCPeerConnection-AddRemoveStream test (on GTK+ port). RTCPeerConnection implements
the legacy MediaStream-based API as JS built-ins so we can run this test again.

  • fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt:
  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • platform/gtk/TestExpectations:
10:52 AM Changeset in webkit [202494] by adam.bergkvist@ericsson.com
  • 1 edit
    1 delete in trunk/Source/WebCore

WebRTC: Remove unused RTCOfferAnswerOptionsPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=159130

Reviewed by Eric Carlson.

Remove unused RTCOfferAnswerOptionsPrivate.h file.

  • platform/mediastream/RTCOfferAnswerOptionsPrivate.h: Removed.
10:50 AM Changeset in webkit [202493] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in layout test /media/video-buffered-range-contains-currentTime.html
https://bugs.webkit.org/show_bug.cgi?id=159109
<rdar://problem/26535750>

Reviewed by Alex Christensen.

Guard against a dealloc race condition by holding a retain on the session
until the task's _resource:loadFinishedWithError: completes, including
main thread callbacks.

  • platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionDataTask _resource:loadFinishedWithError:]):

10:50 AM Changeset in webkit [202492] by Brian Burg
  • 3 edits in trunk/Source/JavaScriptCore

Web Inspector: CRASH in backend at Inspector::HeapFrontendDispatcher::garbageCollected + 552 when closing frontend/inspected page
https://bugs.webkit.org/show_bug.cgi?id=159075
<rdar://problem/26094341>

Reviewed by Timothy Hatcher.

Move the asynchronous work to a task class that can be cancelled when the
heap agent is reset, disabled or destroyed.

  • inspector/agents/InspectorHeapAgent.cpp:

(Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
(Inspector::SendGarbageCollectionEventsTask::addGarbageCollection):
(Inspector::SendGarbageCollectionEventsTask::reset):
(Inspector::SendGarbageCollectionEventsTask::timerFired):
Added. This holds onto GarbageCollectionData that needs to be sent asynchronously.
It uses the RunLoop variant of Timer and can queue multiple collections to be sent.
The data vector is guarded with a lock so that garbageCollected() can safely add
collection data from a non-main thread while the main thread sends out events.

(Inspector::InspectorHeapAgent::InspectorHeapAgent):
(Inspector::InspectorHeapAgent::~InspectorHeapAgent):
(Inspector::InspectorHeapAgent::disable):
Reset the task when disabling or tearing down the agent so the timer doesn't fire after destruction.

(Inspector::InspectorHeapAgent::didGarbageCollect):
Add the collection data to the task, which will dispatch an event for it asynchronously.

  • inspector/agents/InspectorHeapAgent.h:
10:44 AM Changeset in webkit [202491] by fred.wang@free.fr
  • 5 edits in trunk/LayoutTests

Update TestExpectations for some dynamic MathML tests
https://bugs.webkit.org/show_bug.cgi?id=159142

Patch by Frederic Wang <fwang@igalia.com> on 2016-06-27
Reviewed by Brent Fulgham.

  • TestExpectations: Enable this test again after r199980.
  • platform/efl/TestExpectations: This is already claimed to pass in the platform independent TestExpectations.
  • platform/gtk/TestExpectations: Ditto.
  • platform/ios-simulator/TestExpectations: This test passes after the refactoring of RenderMathMLOperator.
10:38 AM Changeset in webkit [202490] by msaboff@apple.com
  • 7 edits in trunk

ES6 Change: Unify handling of RegExp CharacterClassEscapes \w and \W and Word Asserts \b and \B
https://bugs.webkit.org/show_bug.cgi?id=158505

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This change makes it so that the CharacterClassEscape \w matches the inverse of
\W and vice versa for unicode, ignore case RegExp's.

Before this change, both /\w/ui and /\W/ui RegExp's would match the characters
k, K, s, S, \u017f (Latin Small Letter Long S) and \u212a (Kelvin Sign).
This was due to how the ES6 standard defined matching of character classes
specifically that the abstract operation "Canonicalize()" is called for the
character to be matched AND for the characters in the character class we are
matching against. This change is to make \W always be the inverse of \w.
It is still the case that the characters that match against \w changes
depending on a regular expression's flags.

The only real changes occur for regular expressions with both the unicode and
ignore case flags set. Updated the character class generator to make
nonwordUnicodeIgnoreCaseChar not include k, K, s, S, \u017f and \u212a.
Changed BytecodePattern.wordcharCharacterClass to use the correct
word character class for the flags. Simplfied character class set up in
in the pattern to use m_pattern.wordUnicodeIgnoreCaseCharCharacterClass and
invert as appropriate when unicode and ignore case are both set.

  • create_regex_tables:
  • yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::atomBuiltInCharacterClass):

LayoutTests:

Updated and added test cases.

  • js/regexp-unicode-expected.txt:
  • js/script-tests/regexp-unicode.js:
10:36 AM Changeset in webkit [202489] by fred.wang@free.fr
  • 8 edits in trunk

Set an upper limit for the size or number of pieces of stretchy operators
https://bugs.webkit.org/show_bug.cgi?id=155434

Source/WebCore:

Patch by Frederic Wang <fwang@igalia.com> on 2016-06-27
Reviewed by Brent Fulgham.

Stretchy MathML operators can currently use an arbitrary number of extension glyphs to cover
a target size. This may result in hangs if large stretch sizes are requested. This change
only allow at most the 128 first extensions to be painted by the MathOperator class, which
should really be enough for mathematical formulas used in practice.

No new tests, already tested by very-large-stretchy-operators.

  • rendering/mathml/MathOperator.cpp: Add a new kMaximumExtensionCount constant.

(WebCore::MathOperator::fillWithVerticalExtensionGlyph): Limit the number of step in this loop to kMaximumExtensionCount.
(WebCore::MathOperator::fillWithHorizontalExtensionGlyph): Ditto.

LayoutTests:

Update test expectations for very-large-stretchy-operators.

Patch by Frederic Wang <fwang@igalia.com> on 2016-06-27
Reviewed by Brent Fulgham.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
10:33 AM Changeset in webkit [202488] by fred.wang@free.fr
  • 2 edits in trunk/Source/WebCore

Small refactoring MathMLInlineContainerElement::createElementRenderer
https://bugs.webkit.org/show_bug.cgi?id=159131

Reviewed by Brent Fulgham.

Many of the MathML renderer classes have been merged during the MathML refactoring. We
simplify how instances are created in MathMLInlineContainerElement::createElementRenderer
by removing duplicate createRenderer calls.

No new tests, behavior unchanged.

  • mathml/MathMLInlineContainerElement.cpp:

(WebCore::MathMLInlineContainerElement::createElementRenderer):

9:48 AM Changeset in webkit [202487] by keith_miller@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

DFGByteCodeParsing does not handle calling the Object constructor with no arguments correctly
https://bugs.webkit.org/show_bug.cgi?id=159117
<rdar://problem/26996781>

Reviewed by Saam Barati.

DFGByteCodeParsing always assumed there would be an argument to the Object constructor.
This is clearly not always the case and we should be able to handle it.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):

  • tests/stress/indirect-call-object-constructor-with-no-arguments.js: Added.

(let.foo.Object.test):

9:01 AM Changeset in webkit [202486] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip two LayoutTests that rely on mouse events on ios-simulator

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
8:10 AM WebKitGTK/Gardening/Calendar edited by jfernandez@igalia.com
(diff)
7:47 AM Changeset in webkit [202485] by jfernandez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening. Added Failure Test Expectations because of r194502 and r194513.
https://bugs.webkit.org/show_bug.cgi?id=159147

  • platform/gtk/TestExpectations:
7:23 AM WebKitGTK/Gardening/Calendar edited by jfernandez@igalia.com
(diff)
3:57 AM Changeset in webkit [202484] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[GTK][EFL] Build with threaded compositor enabled is broken
https://bugs.webkit.org/show_bug.cgi?id=159138

Patch by Miguel Gomez <magomez@igalia.com> on 2016-06-27
Reviewed by Carlos Garcia Campos.

Source/WebCore:

No need to set the device scale. The compositor buffer is only used for the accelerated
canvas scenario, and the device scale is always 1 there.
This change was introduced in r202421.

Covered by existing tests.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::createCompositorBuffer):

Source/WebKit2:

Replace the usage of NoncopyableFunction with Function, to follow the changes in r202439.

  • Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::performTask):
(WebKit::CompositingRunLoop::performTaskSync):

  • Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:
2:22 AM Changeset in webkit [202483] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-control-infrastructure/ is failing on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=159136

Unreviewed.

Patch by Youenn Fablet <youennf@gmail.com> on 2016-06-27

  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/form-control-infrastructure/form-expected.txt: Added.
2:21 AM Changeset in webkit [202482] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] top/bottom black bars added needlessly in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=158980

Patch by Philippe Normand <philn@igalia.com> on 2016-06-27
Reviewed by Carlos Garcia Campos.

The natural video size calculation depends on the validity of the
current sample, so whenever the first sample reached the sink it's a
good idea to reflect this on the player which will update its natural
size accordingly.

Fixes an issue where black borders were added on top and bottom of
fullscreen video.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):

2:01 AM Changeset in webkit [202481] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] The test fast/events/wheel-event-outside-body.html is timing out.
https://bugs.webkit.org/show_bug.cgi?id=159129

Reviewed by Alex Christensen.

Implement the function mouseScrollBy in the Windows event sender.

  • DumpRenderTree/win/EventSender.cpp:

(mouseScrollBy):
(mouseScrollByWithWheelAndMomentumPhasesCallback):

1:28 AM Changeset in webkit [202480] by commit-queue@webkit.org
  • 21 edits in trunk

Remove didFailRedirectCheck ThreadableLoaderClient callback
https://bugs.webkit.org/show_bug.cgi?id=159085

Patch by Youenn Fablet <youenn@apple.com> on 2016-06-27
Reviewed by Daniel Bates.

Source/WebCore:

Removing didFailRedirectCheck and using didFailAccessControlCheck instead.
The change in behavior is that additional error messages are outputted in the console.
These messages give additional debugging information.

Covered by rebased tests.

  • Modules/fetch/FetchLoader.cpp: Removing didFailRedirectCheck.
  • Modules/fetch/FetchLoader.h: Ditto.
  • inspector/InspectorNetworkAgent.cpp: Ditto.
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::redirectReceived): Calling didFailAccessControlCheck with information on failing
URL.
(WebCore::DocumentThreadableLoader::loadRequest): Ditto.

  • loader/ThreadableLoaderClient.h: Removing didFailRedirectCheck.
  • loader/ThreadableLoaderClientWrapper.h: Ditto.
  • loader/WorkerThreadableLoader.cpp: Ditto.
  • loader/WorkerThreadableLoader.h: Ditto.
  • page/EventSource.cpp: Ditto.
  • page/EventSource.h: Ditto.
  • workers/WorkerScriptLoader.cpp: Ditto.
  • workers/WorkerScriptLoader.h: Ditto.
  • xml/XMLHttpRequest.cpp: Ditto.
  • xml/XMLHttpRequest.h: Ditto.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/connect-src-eventsource-redirect-to-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-redirect-to-blocked-expected.txt:
  • http/tests/security/contentSecurityPolicy/worker-csp-blocks-xhr-redirect-cross-origin-expected.txt:
  • http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
  • http/tests/xmlhttprequest/access-control-and-redirects-expected.txt:

Jun 26, 2016:

10:10 PM Changeset in webkit [202479] by Gyuyoung Kim
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build warning when using geoclue2
https://bugs.webkit.org/show_bug.cgi?id=159128

Reviewed by Antonio Gomes.

EFL port has handled build warning as error. So EFL port
hasn't been built when we use geoclue2 library because a generated geoclue2 file
has unused-parameter build warning. To fix it this patch set to ignore the build warning
in the generated geoclue2 file.

  • PlatformEfl.cmake:
6:29 PM Changeset in webkit [202478] by Chris Dumez
  • 3 edits
    2 adds in trunk

Regression: HTMLOptionsCollection's named properties have precedence over indexed properties
https://bugs.webkit.org/show_bug.cgi?id=159058
<rdar://problem/26988542>

Reviewed by Ryosuke Niwa.

Source/WebCore:

HTMLOptionsCollection's named properties had precedence over indexed properties,
which is wrong as per:
http://heycam.github.io/webidl/#getownproperty-guts

The reason is that there was a named property getter defined on HTMLOptionsCollection
but no indexed property getter. As a result, HTMLOptionsCollection would fall back to
using HTMLCollection's indexed property getter but HTMLOptionsCollection's named getter
would take precedence. This patch defines an indexed property getter on
HTMLOptionsCollection to fix the problem.

Ideally, HTMLOptionsCollection would have no indexed / named property getters and would
entirely rely on the ones from HTMLCollection. However, our bindings generator currently
has trouble with this and requires HTMLOptionsCollection to have a named getter.

Test: fast/dom/HTMLSelectElement/options-indexed-getter-precedence.html

  • html/HTMLOptionsCollection.idl:

LayoutTests:

Add layout test coverage.

  • fast/dom/HTMLSelectElement/options-indexed-getter-precedence-expected.txt: Added.
  • fast/dom/HTMLSelectElement/options-indexed-getter-precedence.html: Added.
3:31 PM Changeset in webkit [202477] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.38-branch/Source

Versioning.

3:25 PM WebKitGTK/Gardening/Calendar edited by jfernandez@igalia.com
(diff)
3:22 PM Changeset in webkit [202476] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.38.2

New tag.

2:57 PM Changeset in webkit [202475] by jfernandez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening.

Several hidpi tests pass now thanks to r202421.

2:34 PM WebKitGTK/Gardening/Calendar edited by jfernandez@igalia.com
(diff)
11:02 AM Changeset in webkit [202474] by mmaxfield@apple.com
  • 9 edits
    4 adds
    3 deletes in trunk/LayoutTests

[macOS] Font-related test gardening for macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=159106
<rdar://problem/25807529>

Unreviewed.

  • fast/ruby/bopomofo-letter-spacing.html:
  • fast/ruby/bopomofo-rl.html:
  • fast/ruby/bopomofo.html:
  • svg/W3C-SVG-1.1/text-fonts-01-t.svg:
  • svg/text/text-fonts-01-t.svg:
10:21 AM Changeset in webkit [202473] by bshafiei@apple.com
  • 2 edits in branches/safari-602.1.38-branch/Source/WebCore

Merged r202472. rdar://problem/27014649

9:25 AM Changeset in webkit [202472] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Regression(r202262): Infinite loop under searchForLinkRemovingExistingDDLinks()
https://bugs.webkit.org/show_bug.cgi?id=159122
<rdar://problem/27014649>

Reviewed by Ryosuke Niwa.

Infinite loop under searchForLinkRemovingExistingDDLinks() because the
value returned by NodeTraversal::next() was ignored and the node iterator
was never updated.

  • editing/cocoa/DataDetection.mm:

(WebCore::searchForLinkRemovingExistingDDLinks):

3:04 AM Changeset in webkit [202471] by commit-queue@webkit.org
  • 157 edits
    1 copy
    108 adds in trunk/LayoutTests

Refreshing WPT tests up to 12b7800
https://bugs.webkit.org/show_bug.cgi?id=158872

Patch by Youenn Fablet <youennf@gmail.com> on 2016-06-26
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • resources/ImportExpectations:
  • resources/TestRepositories:
  • resources/web-platform-tests-modules.json:
  • web-platform-tests/XMLHttpRequest/open-url-bogus-expected.txt:
  • web-platform-tests/XMLHttpRequest/open-url-bogus.htm:
  • web-platform-tests/XMLHttpRequest/open-url-multi-window-4-expected.txt:
  • web-platform-tests/XMLHttpRequest/resources/init.htm:
  • web-platform-tests/XMLHttpRequest/send-entity-body-document-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-usp-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-usp.js:
  • web-platform-tests/XMLHttpRequest/w3c-import.log:
  • web-platform-tests/common/form-submission.py: Added.
  • web-platform-tests/common/w3c-import.log:
  • web-platform-tests/dom/events/Event-defaultPrevented-expected.txt:
  • web-platform-tests/dom/events/Event-defaultPrevented.html:
  • web-platform-tests/dom/events/w3c-import.log:
  • web-platform-tests/dom/historical-expected.txt:
  • web-platform-tests/dom/historical.html:
  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/dom/interfaces.html:
  • web-platform-tests/dom/lists/w3c-import.log:
  • web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
  • web-platform-tests/dom/nodes/DOMImplementation-createDocument.html:
  • web-platform-tests/dom/nodes/Document-characterSet-normalization-expected.txt:
  • web-platform-tests/dom/nodes/Document-characterSet-normalization.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_bmp-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_bmp.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_css-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_css.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_gif-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_gif.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_html-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_html.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_javascripturi-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_javascripturi.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_jpg-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_jpg.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_mimeheader_01-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_mimeheader_01.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_mimeheader_02-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_mimeheader_02.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_png-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_png.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_txt-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_txt.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_xml-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_xml.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/createDocument-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/createDocument.html:
  • web-platform-tests/dom/nodes/Document-createElement-namespace-expected.txt:
  • web-platform-tests/dom/nodes/Document-createElement-namespace.html:
  • web-platform-tests/dom/nodes/Element-classlist-expected.txt:
  • web-platform-tests/dom/nodes/Element-classlist.html:
  • web-platform-tests/dom/nodes/Node-cloneNode.html:
  • web-platform-tests/dom/nodes/remove-unscopable-expected.txt:
  • web-platform-tests/dom/nodes/remove-unscopable.html:
  • web-platform-tests/dom/nodes/w3c-import.log:
  • web-platform-tests/domparsing/DOMParser-parseFromString-html-expected.txt:
  • web-platform-tests/domparsing/DOMParser-parseFromString-html.html:
  • web-platform-tests/domparsing/OWNERS:
  • web-platform-tests/domparsing/w3c-import.log:
  • web-platform-tests/fetch/api/redirect/redirect-method.js:
  • web-platform-tests/fetch/api/redirect/w3c-import.log:
  • web-platform-tests/fetch/api/request/request-cache-expected.txt:
  • web-platform-tests/fetch/api/request/request-cache.html:
  • web-platform-tests/fetch/api/request/request-error-expected.txt:
  • web-platform-tests/fetch/api/request/request-error.html:
  • web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt:
  • web-platform-tests/fetch/api/request/request-init-001.sub.html:
  • web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt:
  • web-platform-tests/fetch/api/request/request-init-003.sub.html:
  • web-platform-tests/fetch/api/request/resources/cache.py:
  • web-platform-tests/fetch/api/request/resources/get-host-info.sub.js: Added.
  • web-platform-tests/fetch/api/request/resources/w3c-import.log:
  • web-platform-tests/fetch/api/resources/utils.js:
  • web-platform-tests/fetch/api/resources/w3c-import.log:
  • web-platform-tests/fetch/api/response/response-cancel-stream-expected.txt:
  • web-platform-tests/fetch/api/response/response-cancel-stream.html:
  • web-platform-tests/fetch/api/response/response-consume-stream.html:
  • web-platform-tests/fetch/api/response/response-stream-disturbed-4.html:
  • web-platform-tests/fetch/api/response/response-stream-disturbed-5.html:
  • web-platform-tests/fetch/api/response/w3c-import.log:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/w3c-import.log:
  • web-platform-tests/html/dom/elements-embedded.js:
  • web-platform-tests/html/dom/elements-metadata.js:
  • web-platform-tests/html/dom/elements-tabular.js:
  • web-platform-tests/html/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/interfaces.html:
  • web-platform-tests/html/dom/reflection-embedded-expected.txt:
  • web-platform-tests/html/dom/reflection-embedded.html:
  • web-platform-tests/html/dom/reflection-forms-expected.txt:
  • web-platform-tests/html/dom/reflection-forms.html:
  • web-platform-tests/html/dom/reflection-grouping-expected.txt:
  • web-platform-tests/html/dom/reflection-grouping.html:
  • web-platform-tests/html/dom/reflection-metadata-expected.txt:
  • web-platform-tests/html/dom/reflection-metadata.html:
  • web-platform-tests/html/dom/reflection-misc-expected.txt:
  • web-platform-tests/html/dom/reflection-misc.html:
  • web-platform-tests/html/dom/reflection-obsolete-expected.txt:
  • web-platform-tests/html/dom/reflection-obsolete.html:
  • web-platform-tests/html/dom/reflection-sections-expected.txt:
  • web-platform-tests/html/dom/reflection-sections.html:
  • web-platform-tests/html/dom/reflection-tabular-expected.txt:
  • web-platform-tests/html/dom/reflection-tabular.html:
  • web-platform-tests/html/dom/reflection-text-expected.txt:
  • web-platform-tests/html/dom/reflection-text.html:
  • web-platform-tests/html/dom/w3c-import.log:
  • web-platform-tests/html/resources/common.js:
  • web-platform-tests/html/semantics/document-metadata/the-base-element/w3c-import.log:
  • web-platform-tests/html/semantics/document-metadata/the-link-element/link-rellist-expected.txt:
  • web-platform-tests/html/semantics/document-metadata/the-link-element/link-rellist.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/kind-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/kind.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/kind-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/kind.html:
  • web-platform-tests/html/semantics/embedded-content/the-embed-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/sizes-iframed.sub.html:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validate.html:
  • web-platform-tests/html/semantics/forms/form-control-infrastructure/form-expected.txt:
  • web-platform-tests/html/semantics/forms/form-control-infrastructure/form.html:
  • web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log:
  • web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt:
  • web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange.html:
  • web-platform-tests/html/semantics/forms/the-input-element/checkbox.html:
  • web-platform-tests/html/semantics/forms/the-input-element/radio.html:
  • web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt:
  • web-platform-tests/html/semantics/forms/the-input-element/selection.html:
  • web-platform-tests/html/semantics/forms/the-label-element/label-attributes-expected.txt:
  • web-platform-tests/html/semantics/forms/the-label-element/label-attributes.html:
  • web-platform-tests/html/semantics/interfaces-expected.txt:
  • web-platform-tests/html/semantics/interfaces.html:
  • web-platform-tests/html/semantics/interfaces.js:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/w3c-import.log:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/checked.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/default.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/dir-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/dir.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/dir01.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/disabled.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/enabled.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/focus.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/indeterminate.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/link.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/required-optional.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/utils.js:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid.html:
  • web-platform-tests/html/semantics/tabular-data/the-table-element/table-rows.html:
  • web-platform-tests/lint.whitelist:
  • web-platform-tests/service-workers/cache-storage/script-tests/cache-storage-match.js:
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/close.https.html: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https.html: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/close-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/registration-attribute-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-controlling-worker.html: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/update-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/update-worker.py: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/w3c-import.log: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/unregister.https.html: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html: Added.
  • web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/w3c-import.log: Added.
  • web-platform-tests/service-workers/service-worker/activate-event-after-install-state-change.https.html: Added.
  • web-platform-tests/service-workers/service-worker/activation-after-registration.https.html: Added.
  • web-platform-tests/service-workers/service-worker/active.https.html: Added.
  • web-platform-tests/service-workers/service-worker/appcache-ordering-main.https.html: Added.
  • web-platform-tests/service-workers/service-worker/claim-not-using-registration.https.html: Added.
  • web-platform-tests/service-workers/service-worker/claim-using-registration.https.html: Added.
  • web-platform-tests/service-workers/service-worker/clients-get-cross-origin.https.html: Added.
  • web-platform-tests/service-workers/service-worker/clients-get.https.html: Added.
  • web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https.html: Added.
  • web-platform-tests/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html: Added.
  • web-platform-tests/service-workers/service-worker/clients-matchall.https.html: Added.
  • web-platform-tests/service-workers/service-worker/controller-on-load.https.html: Added.
  • web-platform-tests/service-workers/service-worker/controller-on-reload.https.html: Added.
  • web-platform-tests/service-workers/service-worker/extendable-event-async-waituntil.https.html: Added.
  • web-platform-tests/service-workers/service-worker/extendable-event-waituntil.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-csp.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-after-navigation-within-page.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-network-error.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-redirect.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-frame-resource.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-header-visibility.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-mixed-content-to-inscope.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-mixed-content-to-outscope.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-css-base-url.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-css-images.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-fallback.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-resources.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-request-xhr.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-response-xhr.https.html: Added.
  • web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html: Added.
  • web-platform-tests/service-workers/service-worker/getregistration.https.html: Added.
  • web-platform-tests/service-workers/service-worker/getregistrations.https.html: Added.
  • web-platform-tests/service-workers/service-worker/indexeddb.https.html: Added.
  • web-platform-tests/service-workers/service-worker/install-event-type.https.html: Added.
  • web-platform-tests/service-workers/service-worker/installing.https.html: Added.
  • web-platform-tests/service-workers/service-worker/interfaces.https.html: Added.
  • web-platform-tests/service-workers/service-worker/invalid-blobtype.https.html: Added.
  • web-platform-tests/service-workers/service-worker/invalid-header.https.html: Added.
  • web-platform-tests/service-workers/service-worker/multiple-register.https.html: Added.
  • web-platform-tests/service-workers/service-worker/multiple-update.https.html: Added.
  • web-platform-tests/service-workers/service-worker/navigate-window.https.html: Added.
  • web-platform-tests/service-workers/service-worker/navigation-redirect.https.html: Added.
  • web-platform-tests/service-workers/service-worker/onactivate-script-error.https.html: Added.
  • web-platform-tests/service-workers/service-worker/oninstall-script-error.https.html: Added.
  • web-platform-tests/service-workers/service-worker/performance-timeline.https.html: Added.
  • web-platform-tests/service-workers/service-worker/postmessage-msgport-to-client.https.html: Added.
  • web-platform-tests/service-workers/service-worker/postmessage-to-client.https.html: Added.
  • web-platform-tests/service-workers/service-worker/postmessage.https.html: Added.
  • web-platform-tests/service-workers/service-worker/ready.https.html: Added.
  • web-platform-tests/service-workers/service-worker/referer.https.html: Added.
  • web-platform-tests/service-workers/service-worker/register-closed-window.https.html: Added.
  • web-platform-tests/service-workers/service-worker/register-default-scope.https.html: Added.
  • web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https.html: Added.
  • web-platform-tests/service-workers/service-worker/register-wait-forever-in-install-worker.https.html: Added.
  • web-platform-tests/service-workers/service-worker/registration-end-to-end.https.html: Added.
  • web-platform-tests/service-workers/service-worker/registration-events.https.html: Added.
  • web-platform-tests/service-workers/service-worker/registration-iframe.https.html: Added.
  • web-platform-tests/service-workers/service-worker/registration-service-worker-attributes.https.html: Added.
  • web-platform-tests/service-workers/service-worker/registration.https.html: Added.
  • web-platform-tests/service-workers/service-worker/rejections.https.html: Added.
  • web-platform-tests/service-workers/service-worker/request-end-to-end.https.html: Added.
  • web-platform-tests/service-workers/service-worker/resource-timing.https.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/404.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/appcache-ordering.install.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/appcache-ordering.is-appcached.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/appcache-ordering.is-appcached.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/appcache-ordering.manifest: Added.
  • web-platform-tests/service-workers/service-worker/resources/blank.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/claim-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/clients-get-frame.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/clients-get-other-origin.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/clients-get-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/clients-matchall-client-types-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/clients-matchall-client-types-shared-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/clients-matchall-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/dummy-shared-worker-interceptor.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/dummy-worker-interceptor.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/dummy-worker-script.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/dummy.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/dummy.txt: Added.
  • web-platform-tests/service-workers/service-worker/resources/empty-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/empty.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/end-to-end-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/events-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/extendable-event-async-waituntil.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/extendable-event-waituntil.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fail-on-fetch-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-access-control-login.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-access-control.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-canvas-tainting-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-cors-xhr-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-csp-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-csp-iframe.html.sub.headers: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-event-after-navigation-within-page-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-event-async-respond-with-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-event-network-error-controllee-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-event-network-error-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-event-redirect-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-event-respond-with-stops-propagation-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-event-test-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-header-visibility-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-mixed-content-iframe-inscope-to-inscope.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-mixed-content-iframe-inscope-to-outscope.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-mixed-content-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-css-base-url-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-css-base-url-style.css: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-css-base-url-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-fallback-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-fallback-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-no-freshness-headers-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-no-freshness-headers-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-redirect-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-resources-iframe.https.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-resources-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-xhr-iframe.https.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-xhr-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-response-xhr-iframe.https.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-response-xhr-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-rewrite-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-waits-for-activate-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/frame-for-getregistrations.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/get-host-info.sub.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/indexeddb-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/install-event-type-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/interfaces-worker.sub.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/interfaces.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/invalid-blobtype-iframe.https.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/invalid-blobtype-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/invalid-chunked-encoding-with-flush.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/invalid-chunked-encoding.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/invalid-header-iframe.https.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/invalid-header-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/load_worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/loaded.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/malformed-worker.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/mime-type-worker.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/navigate-window-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/navigation-redirect-other-origin.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/navigation-redirect-out-scope.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/navigation-redirect-scope1.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/navigation-redirect-scope2.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/navigation-redirect-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/onactivate-throw-error-from-nested-event-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/onactivate-throw-error-then-cancel-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/onactivate-throw-error-then-prevent-default-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/onactivate-throw-error-with-empty-onerror-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/onactivate-throw-error-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/oninstall-throw-error-from-nested-event-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/oninstall-throw-error-then-cancel-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/oninstall-throw-error-then-prevent-default-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/oninstall-throw-error-with-empty-onerror-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/oninstall-throw-error-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/other.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/override_assert_object_equals.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/performance-timeline-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/postmessage-msgport-to-client-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/postmessage-to-client-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/postmessage-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/redirect.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/referer-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/register-closed-window-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/registration-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/reject-install-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/request-end-to-end-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/request-headers.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/resource-timing-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/resource-timing-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/service-worker-csp-worker.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/shared-worker-controlled.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/shared-worker-import.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/silence.oga: Added.
  • web-platform-tests/service-workers/service-worker/resources/simple-intercept-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/simple.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/simple.txt: Added.
  • web-platform-tests/service-workers/service-worker/resources/skip-waiting-installed-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/skip-waiting-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/square.png: Added.
  • web-platform-tests/service-workers/service-worker/resources/success.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/test-helpers.sub.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/testharness-helpers.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/unregister-controller-page.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/update-nocookie-worker.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/update-recovery-worker.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/update-worker.py: Added.
  • web-platform-tests/service-workers/service-worker/resources/update/update-after-oneday.https.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/update/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/resources/w3c-import.log.
  • web-platform-tests/service-workers/service-worker/resources/w3c-import.log: Added.
  • web-platform-tests/service-workers/service-worker/resources/wait-forever-in-install-worker.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/websocket.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/worker-interception-iframe.https.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/worker-load-interceptor.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/worker-testharness.js: Added.
  • web-platform-tests/service-workers/service-worker/resources/xhr.js: Added.
  • web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https.html: Added.
  • web-platform-tests/service-workers/service-worker/service-worker-csp-default.https.html: Added.
  • web-platform-tests/service-workers/service-worker/service-worker-csp-script.https.html: Added.
  • web-platform-tests/service-workers/service-worker/serviceworkerobject-scripturl.https.html: Added.
  • web-platform-tests/service-workers/service-worker/shared-worker-controlled.https.html: Added.
  • web-platform-tests/service-workers/service-worker/skip-waiting-installed.https.html: Added.
  • web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https.html: Added.
  • web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https.html: Added.
  • web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https.html: Added.
  • web-platform-tests/service-workers/service-worker/skip-waiting.https.html: Added.
  • web-platform-tests/service-workers/service-worker/state.https.html: Added.
  • web-platform-tests/service-workers/service-worker/synced-state.https.html: Added.
  • web-platform-tests/service-workers/service-worker/uncontrolled-page.https.html: Added.
  • web-platform-tests/service-workers/service-worker/unregister-controller.https.html: Added.
  • web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html: Added.
  • web-platform-tests/service-workers/service-worker/unregister-then-register.https.html: Added.
  • web-platform-tests/service-workers/service-worker/unregister.https.html: Added.
  • web-platform-tests/service-workers/service-worker/update-after-navigation-fetch-event.https.html: Added.
  • web-platform-tests/service-workers/service-worker/update-after-oneday.https.html: Added.
  • web-platform-tests/service-workers/service-worker/update-recovery.https.html: Added.
  • web-platform-tests/service-workers/service-worker/update.https.html: Added.
  • web-platform-tests/service-workers/service-worker/w3c-import.log: Added.
  • web-platform-tests/service-workers/service-worker/waiting.https.html: Added.
  • web-platform-tests/service-workers/service-worker/websocket.https.html: Added.
  • web-platform-tests/service-workers/service-worker/worker-interception.https.html: Added.
  • web-platform-tests/service-workers/service-worker/xhr.https.html: Added.
  • web-platform-tests/streams/OWNERS: Added.
  • web-platform-tests/streams/byte-length-queuing-strategy.https.html:
  • web-platform-tests/streams/count-queuing-strategy.https.html:
  • web-platform-tests/streams/readable-streams/bad-strategies.https.html:
  • web-platform-tests/streams/readable-streams/bad-underlying-sources.https.html:
  • web-platform-tests/streams/readable-streams/brand-checks.https.html:
  • web-platform-tests/streams/readable-streams/cancel.https.html:
  • web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.https.html:
  • web-platform-tests/streams/readable-streams/garbage-collection.https.html:
  • web-platform-tests/streams/readable-streams/general.https.html:
  • web-platform-tests/streams/readable-streams/general.js:
  • web-platform-tests/streams/readable-streams/pipe-through.https.html:
  • web-platform-tests/streams/readable-streams/readable-stream-reader.https.html:
  • web-platform-tests/streams/readable-streams/tee.https.html:
  • web-platform-tests/streams/readable-streams/templated.https.html:
  • web-platform-tests/streams/w3c-import.log:

LayoutTests:

  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/form-control-infrastructure/form-expected.txt: Added.
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:
  • platform/wk2/imported/w3c/web-platform-tests/html/semantics/document-metadata/styling/LinkStyle-expected.txt:

Jun 25, 2016:

9:34 PM Changeset in webkit [202470] by benjamin@webkit.org
  • 5 edits
    4 adds in trunk

The active state of elements can break when focus changes
https://bugs.webkit.org/show_bug.cgi?id=159112

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-25
Reviewed by Antti Koivisto.

Source/WebCore:

The pseudo class :active was behaving weirdly when used
with label elements with an associated form element.
The form element would get the :active state on the first click
then no longer get the state until the focus changes.

What was happenning is setFocusedElement() was clearing active
for some unknown reason. When you really do that on an active element,
you end up in an inconsistent state where no invalidation works.

The two tests illustrates 2 ways this breaks.

The test "pseudo-active-on-labeled-element-not-canceled-by-focus" clicks
several time on a lable element. The first time, the input element gets
the focus. The second time, it already has the focus, setFocusedElement()
clears :active before finding the focusable element and end up clearing
the active state on a target in the active chain.

The test "pseudo-active-with-programmatic-focus.html" shows how to invalidate
arbitrary elements using JavaScript. This can cause severely broken active
chains where invalidation never cleans some ancestors.

Tests: fast/css/pseudo-active-on-labeled-element-not-canceled-by-focus.html

fast/css/pseudo-active-with-programmatic-focus.html

  • dom/Document.cpp:

(WebCore::Document::setFocusedElement): Deleted.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDoubleClickEvent):
This is WebKit1 specific. The double click event was dispatching
the mouseUp and Click with after doing an Active hit test.
This causes us to have :active state in and after mouseUp in WebKit1.

LayoutTests:

  • fast/css/pseudo-active-on-labeled-element-not-canceled-by-focus-expected.txt: Added.
  • fast/css/pseudo-active-on-labeled-element-not-canceled-by-focus.html: Added.
  • fast/css/pseudo-active-with-programmatic-focus-expected.txt: Added.
  • fast/css/pseudo-active-with-programmatic-focus.html: Added.
12:07 PM Changeset in webkit [202469] by fpizlo@apple.com
  • 4 edits in trunk/Tools

REGRESSION: Weak symbol warning when linking TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=159104

Reviewed by Dan Bernstein.

This uses a better approach to turn on -fvisility=hidden. All of the other projects set
this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".

  • TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
  • TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
2:00 AM Changeset in webkit [202468] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
https://bugs.webkit.org/show_bug.cgi?id=159086

Reviewed by Alex Christensen.

Implement required wheel event function in event sender.

  • DumpRenderTree/win/EventSender.cpp:

(mouseScrollByWithWheelAndMomentumPhasesCallback):

12:07 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr
(diff)

Jun 24, 2016:

7:33 PM Changeset in webkit [202467] by dino@apple.com
  • 3 edits
    13 adds in trunk/Websites/webkit.org

More examples for the wide-gamut demo.

  • blog-files/color-gamut/Iceland-P3.jpg: Added.
  • blog-files/color-gamut/Iceland-oog.jpg: Added.
  • blog-files/color-gamut/Iceland-sRGB.jpg: Added.
  • blog-files/color-gamut/Italy-P3.jpg: Added.
  • blog-files/color-gamut/Italy-oog.jpg: Added.
  • blog-files/color-gamut/Italy-sRGB.jpg: Added.
  • blog-files/color-gamut/Sunset-AdobeRGB.jpg: Added.
  • blog-files/color-gamut/Sunset-P3.jpg: Added.
  • blog-files/color-gamut/Sunset-oog.jpg: Added.
  • blog-files/color-gamut/Sunset-sRGB.jpg: Added.
  • blog-files/color-gamut/Webkit-logo-sRGB.png:
  • blog-files/color-gamut/YellowFlower-P3.jpg: Added.
  • blog-files/color-gamut/YellowFlower-oog.jpg: Added.
  • blog-files/color-gamut/YellowFlower-sRGB.jpg: Added.
  • blog-files/color-gamut/index.html:
5:46 PM Changeset in webkit [202466] by jer.noble@apple.com
  • 4 edits in trunk

Consider exposing or hiding knowledge of a redirect from clients of WebCoreNSURLSession
https://bugs.webkit.org/show_bug.cgi?id=156722
<rdar://problem/25780035>

Reviewed by Alex Christensen.

Source/WebCore:

Fixes tests: http/tests/security/contentSecurityPolicy/audio-redirect-allowed2.html

http/tests/security/contentSecurityPolicy/video-redirect-allowed2.html

When receieving a NSURLResponse containing a redirected URL, AVFoundadtion will use the
URL in the response for subsequent requests. This violates the HTTP specification if the
redirect was temporary, and it also breaks two CSP tests by bypassing the redirect step
for subsequent requests.

Work around this behavior in AVFoundation by recreating the NSURLResponse with the original
request URL in the case of a temporary redirect.

  • platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]):

LayoutTests:

Un-skip http/tests/security/contentSecurityPolicy/audio-redirect-allowed2.html &
http/tests/security/contentSecurityPolicy/video-redirect-allowed2.html.

  • platform/mac/TestExpectations:
5:40 PM Changeset in webkit [202465] by dino@apple.com
  • 1 edit in trunk/Websites/webkit.org/ChangeLog

Change something in the webkit.org directory in the hope
it will kick off a website update.

5:36 PM Changeset in webkit [202464] by Brian Burg
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r201171): CRASH at WebKit::WebInspectorProxy::open() + 31 when running inspector layout tests
https://bugs.webkit.org/show_bug.cgi?id=159070
<rdar://problem/26768628>

Reviewed by Joseph Pecoraro.

We have been seeing a few crashes underneath WebInspectorProxy::bringToFront() on the bots.
Previously, this code didn't use m_inspectorPage so there was nothing to null-dereference.

However, it doesn't make sense that we would hit the null dereference here:

  • The only caller of bringToFront() on the WebProcess side is InspectorController::show(). It only tries to bring to front if there is already a local frontend connection, which shouldn't be the case if m_inspectorPage is null.
  • It's guarded by m_underTest, which should have been set to true in createInspectorPage().

These clues lead me to believe that we may be improperly tearing down the inspector between tests.
For example, it seems possible that a local frontend connection is not being torn down, so
InspectorController never asks to create a inspector page when the next test calls showWebInspector.

Since this crash is not easy to reproduce, we don't have much to go on. For now, this patch
adds an early return in the case where m_inspectorPage is null when calling open().

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::open):

5:03 PM Changeset in webkit [202463] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

B3 should die sooner if a Value has the wrong number of children
https://bugs.webkit.org/show_bug.cgi?id=159108

Reviewed by Mark Lam.

I've been looking at a bug (rdar://problem/26500743) that's about a Vector OOB crash in
ReduceStrength::rangeFor(). The only Vector accesses are to Value::m_children, and all of
the accesses in rangeFor() are for child(0) or child(1) of binary arithmetic opcodes.
Clearly those should never go out-of-bounds.

Maybe we have horrible memory corruption. Or maybe some path creates a Value with the
wrong number of children, and that path is not tested by any of our tests. This patch adds
release assertions that will catch the latter.

I've tested this a lot. It's not a regression on our benchmarks.

  • b3/B3Opcode.h:
  • b3/B3Value.cpp:

(JSC::B3::Value::dumpMeta):
(JSC::B3::Value::typeFor):
(JSC::B3::Value::badOpcode):
(JSC::B3::Value::checkOpcode): Deleted.

  • b3/B3Value.h:
4:54 PM Changeset in webkit [202462] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

MSE gets confused by in-band text tracks
https://bugs.webkit.org/show_bug.cgi?id=159107
<rdar://problem/26871330>

Reviewed by Eric Carlson.

We can't currently handle text track samples in SourceBufferPrivateAVFObjC,
so don't pass them up to SourceBuffer.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset):
(WebCore::SourceBufferPrivateAVFObjC::processCodedFrame):

4:49 PM Changeset in webkit [202461] by fpizlo@apple.com
  • 2 edits in trunk/Tools

REGRESSION: Weak symbol warning when linking TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=159104

Reviewed by Mark Lam.

The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
WK.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4:34 PM Changeset in webkit [202460] by mark.lam@apple.com
  • 6 edits
    5 adds in trunk

[JSC] Error prototypes are called on remote scripts.
https://bugs.webkit.org/show_bug.cgi?id=52192

Reviewed by Keith Miller.

Source/JavaScriptCore:

Added a sanitizedToString() to the Error instance object so that it can be used
to get an error string without invoking getters and proxies.

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::finishCreation):
(JSC::ErrorInstance::sanitizedToString):

  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::createStructure):
(JSC::ErrorInstance::runtimeTypeForCause):
(JSC::ErrorInstance::clearRuntimeTypeForCause):

Source/WebCore:

Test: http/tests/security/regress-52192.html

Parsing errors are reported to the main script's window.onerror function. AFAIK,
both Chrome and Firefox have the error reporting mechanism use an internal
sanitized version of Error.prototype.toString() that will not invoke any getters
or proxies instead.

This patch fixes this issue by matching Chrome and Firefox's behavior.

Note: we did not choose to make error objects and prototypes read-only because
that was observed to have broken the web.
See https://bugs.chromium.org/p/chromium/issues/detail?id=69187#c73

Credit for reporting this issue goes to Daniel Divricean (http://divricean.ro).

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

  • ForwardingHeaders/runtime/ErrorInstance.h: Added.

LayoutTests:

The added test will test the following combinations of factors:

  1. Explicitly throwing an error of each of the types of JS errors i.e. Error, EvalError, RangeError, ReferenceError, SyntaxError, TypeError, URIError.
  2. Validating that the error received in window.onerror does not leak any info.
  3. Validating that the 'name' and 'toString' getters set on the error prototype object does not get invoked for creating the error message to be passed to window.error.
  • http/tests/security/regress-52192-expected.txt: Added.
  • http/tests/security/regress-52192.html: Added.
  • http/tests/security/resources/regress-52192-syntax-error.js: Added.
  • http/tests/security/resources/regress-52192-throw-error.js: Added.

(catch):

4:01 PM Changeset in webkit [202459] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Media elements should not lose playback controls when muted by a user gesture
https://bugs.webkit.org/show_bug.cgi?id=159078
<rdar://problem/26925904>

Reviewed by Beth Dakin.

Rearrange canControlControlsManager() so that the muted check only occurs if
a user gesture is required.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::canControlControlsManager):

3:52 PM Changeset in webkit [202458] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r202443.
https://bugs.webkit.org/show_bug.cgi?id=159105

Introduced memory corruption crashes (Requested by ap on
#webkit).

Reverted changeset:

"Web Inspector: CRASH in backend at
Inspector::HeapFrontendDispatcher::garbageCollected + 552 when
closing frontend/inspected page"
https://bugs.webkit.org/show_bug.cgi?id=159075
http://trac.webkit.org/changeset/202443

3:44 PM Changeset in webkit [202457] by dino@apple.com
  • 1 edit
    6 adds in trunk/Websites/webkit.org/blog-files/color-gamut

More examples for a blog post on color.

  • blog-files/color-gamut/Shoes-oog.jpg: Added.
  • blog-files/color-gamut/Shoes-sRGB.jpg: Added.
  • blog-files/color-gamut/Webkit-logo-P3.png: Added.
  • blog-files/color-gamut/Webkit-logo-oog.png: Added.
  • blog-files/color-gamut/Webkit-logo-sRGB.png: Added.
  • blog-files/color-gamut/index.html:
  • blog-files/color-gamut/shoes-AdobeRGB.jpg: Added.
3:39 PM Changeset in webkit [202456] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

Update to test gardening in r202300

Unreviewed.

  • platform/mac/TestExpectations:
3:25 PM Changeset in webkit [202455] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Vimeo.com videos do not get playback controls
https://bugs.webkit.org/show_bug.cgi?id=159082
<rdar://problem/26586630>

Reviewed by Eric Carlson.

When the HasAudioOrVideo media state changes, let the video controls recalculate
by calling videoControlsManagerDidChange().

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isPlayingMediaDidChange):

3:25 PM Changeset in webkit [202454] by Beth Dakin
  • 7 edits in trunk/Source

Include enclosingListType in EditorState
https://bugs.webkit.org/show_bug.cgi?id=159102
-and corresponding-
rdar://problem/26932490

Reviewed by Enrica Casucci.

Source/WebCore:

Make HTMLOListElement.h and HTMLUListElement.h Private instead of Project.

  • WebCore.xcodeproj/project.pbxproj:

Export enclosingList(Node*)

  • editing/htmlediting.h:

Source/WebKit2:

  • Shared/EditorState.cpp:

(WebKit::EditorState::PostLayoutData::encode):
(WebKit::EditorState::PostLayoutData::decode):

  • Shared/EditorState.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):

3:00 PM Changeset in webkit [202453] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.38-branch/Source

Versioning.

2:59 PM Changeset in webkit [202452] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.38.1

New tag.

2:58 PM Changeset in webkit [202451] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Another Windows build fix.

  • platform/network/BlobRegistry.h:
2:54 PM Changeset in webkit [202450] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.38-branch/Source

Versioning.

2:54 PM Changeset in webkit [202449] by Jon Davis
  • 2 edits in trunk/Websites/webkit.org

Rewrite the WebKit Nightly build download URLs to use the correct secure URL.
https://bugs.webkit.org/show_bug.cgi?id=159100.

Reviewed by Joseph Pecoraro.

  • wp-content/plugins/sync-nightly-builds.php:
2:33 PM Changeset in webkit [202448] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Yeat another Windows build fix.

  • dom/ActiveDOMCallbackMicrotask.h:
2:09 PM Changeset in webkit [202447] by Konstantin Tokarev
  • 6 edits
    1 delete in trunk/LayoutTests

Removed tests of STYLE_SCOPED which was removed in r156683.
https://bugs.webkit.org/show_bug.cgi?id=159098

Reviewed by Ryosuke Niwa.

  • fast/css/style-scoped/basic-attribute-expected.txt: Removed.
  • fast/css/style-scoped/basic-attribute.html: Removed.
  • fast/css/style-scoped/registering-expected.txt: Removed.
  • fast/css/style-scoped/registering-shadowroot-expected.txt: Removed.
  • fast/css/style-scoped/registering-shadowroot.html: Removed.
  • fast/css/style-scoped/registering.html: Removed.
  • fast/css/style-scoped/style-scoped-apply-author-styles-expected.txt: Removed.
  • fast/css/style-scoped/style-scoped-apply-author-styles.html: Removed.
  • fast/css/style-scoped/style-scoped-attach-expected.txt: Removed.
  • fast/css/style-scoped/style-scoped-attach.html: Removed.
  • fast/css/style-scoped/style-scoped-basic-expected.txt: Removed.
  • fast/css/style-scoped/style-scoped-basic.html: Removed.
  • fast/css/style-scoped/style-scoped-change-scoped-in-shadow-expected.txt: Removed.
  • fast/css/style-scoped/style-scoped-change-scoped-in-shadow.html: Removed.
  • fast/css/style-scoped/style-scoped-detach-expected.txt: Removed.
  • fast/css/style-scoped/style-scoped-detach.html: Removed.
  • fast/css/style-scoped/style-scoped-in-shadow-expected.txt: Removed.
  • fast/css/style-scoped/style-scoped-in-shadow.html: Removed.
  • fast/css/style-scoped/style-scoped-nested-expected.txt: Removed.
  • fast/css/style-scoped/style-scoped-nested.html: Removed.
  • fast/css/style-scoped/style-scoped-remove-scoped-expected.txt: Removed.
  • fast/css/style-scoped/style-scoped-remove-scoped.html: Removed.
  • fast/css/style-scoped/style-scoped-set-scoped-expected.txt: Removed.
  • fast/css/style-scoped/style-scoped-set-scoped.html: Removed.
  • fast/css/style-scoped/style-scoped-with-dom-operation-expected.txt: Removed.
  • fast/css/style-scoped/style-scoped-with-dom-operation.html: Removed.
  • fast/css/style-scoped/style-scoped-with-important-rule-expected.txt: Removed.
  • fast/css/style-scoped/style-scoped-with-important-rule.html: Removed.
  • platform/efl/TestExpectations: Don't skip fast/css/style-scoped.
  • platform/gtk/TestExpectations: Ditto.
  • platform/ios-simulator/TestExpectations: Ditto.
  • platform/mac/TestExpectations: Ditto.
  • platform/win/TestExpectations: Ditto.
1:59 PM Changeset in webkit [202446] by fpizlo@apple.com
  • 2 edits
    13 adds in trunk/PerformanceTests

Add a ES6 generator benchmark
https://bugs.webkit.org/show_bug.cgi?id=159101

Rubber stamped by Keith Miller.

This adds a Basic interpreter loosely based on ECMA-55:

http://www.ecma-international.org/publications/files/ECMA-ST-WITHDRAWN/ECMA-55,%201st%20Edition,%20January%201978.pdf

It includes a lexer that is a generator, a parser that uses regular expressions, and an AST
walk interpreter where the walking functions for statements are generators that call each
other with yield*. This enables the interpreter to look like an AST walk even though it can
yield at INPUT and PRINT statements.

This also uses for-of, classes, Map, and WeakMap. It also uses deprecated-but-awesome RegExp
features like RegExp.lastMatch and RegExp.rightContext. I did it that way because this is
how I've always written lexers in dynamic languages; see offlineasm's lex() method in
parser.rb for example.

The benchmark runs a handful of simple Basic programs. The longest-running one computes
prime numbers.

Includes a command-line and web harness. On my machine it runs in 2-3 seconds.

  • Basic: Added.
  • Basic/ast.js: Added.

(Basic.NumberApply):
(Basic.Variable):
(Basic.Const):
(Basic.NumberPow):
(Basic.NumberMul):
(Basic.NumberDiv):
(Basic.NumberNeg):
(Basic.NumberAdd):
(Basic.NumberSub):
(Basic.StringVar):
(Basic.Equals):
(Basic.NotEquals):
(Basic.LessThan):
(Basic.GreaterThan):
(Basic.LessEqual):
(Basic.GreaterEqual):
(Basic.GoTo):
(Basic.GoSub):
(Basic.Def):
(Basic.Let):
(Basic.If):
(Basic.Return):
(Basic.Stop):
(Basic.On):
(sideState.shouldStop):
(Basic.For):
(Basic.Next):
(Basic.Print):
(Basic.Input):
(Basic.Read):
(Basic.Restore):
(Basic.Dim):
(Basic.Randomize):
(Basic.End):
(Basic.Program):

  • Basic/basic.js: Added.

(prepare):
(simulate):

  • Basic/benchmark.js: Added.

(Benchmark):
(Benchmark.prototype.runIteration.expect):
(Benchmark.prototype.runIteration):
(runBenchmark):

  • Basic/caseless_map.js: Added.

(CaselessMap):

  • Basic/lexer.js: Added.

(lex.consumeWhitespace):
(lex.consume):
(lex):

  • Basic/lexer_test.js: Added.
  • Basic/number.js: Added.

(NumberValue):
(NumberValue.prototype.get value):
(NumberValue.prototype.apply):
(NumberValue.prototype.leftApply):
(NumberValue.prototype.assign):
(NumberArray.):
(NumberArray):
(NumberArray.prototype.apply):
(NumberArray.prototype.leftApply):
(NumberFunction):
(NumberFunction.prototype.apply):
(NumberFunction.prototype.leftApply):
(NativeFunction):
(NativeFunction.prototype.apply):
(NativeFunction.prototype.leftApply):

  • Basic/parser.js: Added.

(parse):
(parse.pushToken):
(parse.peekToken):
(parse.consumeKind):
(parse.consumeToken):
(parse.parseVariable):
(parse.parseNumericExpression.parsePrimary):
(parse.parseNumericExpression.parseFactor):
(parse.parseNumericExpression.parseTerm):
(parse.parseNumericExpression):
(parse.parseConstant):
(parse.parseStringExpression):
(parse.isStringExpression):
(parse.parseRelationalExpression):
(parse.parseNonNegativeInteger):
(parse.parseGoToStatement):
(parse.parseGoSubStatement):
(parse.parseStatement):
(parse.parseStatements):

  • Basic/random.js: Added.

(createRNG):
(createRNGWithFixedSeed):
(createRNGWithRandomSeed):

  • Basic/state.js: Added.

(State):
(State.prototype.getValue):
(State.prototype.getSideState):
(State.prototype.abort):
(State.prototype.validate):

  • Basic/test.html: Added.
  • Basic/test.js: Added.
  • Basic/util.js: Added.

(this.performance.performance.now.currentTime):
(else.this.preciseTime.currentTime):
(else.currentTime):

  • Skipped: Make sure that we don't run Basic yet.
1:53 PM Changeset in webkit [202445] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Another Windows build fix.

  • page/FrameView.h:
1:49 PM Changeset in webkit [202444] by andersca@apple.com
  • 13 edits
    1 delete in trunk/Source

Inline more of the Apple Pay source code
https://bugs.webkit.org/show_bug.cgi?id=159099

Reviewed by Andreas Kling.

Source/WebCore:

  • page/Settings.h:

(WebCore::Settings::applePayEnabled):
(WebCore::Settings::setApplePayEnabled):
(WebCore::Settings::applePayCapabilityDisclosureAllowed):
(WebCore::Settings::setApplePayCapabilityDisclosureAllowed):

Source/WebKit2:

  • Shared/Cocoa/WebCoreArgumentCodersCocoa.h: Removed.
  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _applePayCapabilityDisclosureAllowed]):
(-[WKPreferences _setApplePayCapabilityDisclosureAllowed:]):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _applePayEnabled]):
(-[WKWebViewConfiguration _setApplePayEnabled:]):
(-[WKWebViewConfiguration _paymentsEnabled]):
(-[WKWebViewConfiguration _setPaymentsEnabled:]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::resetState):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_userInterfaceLayoutDirection):
(WebKit::WebPage::updatePreferences):

1:30 PM Changeset in webkit [202443] by Brian Burg
  • 3 edits in trunk/Source/JavaScriptCore

Web Inspector: CRASH in backend at Inspector::HeapFrontendDispatcher::garbageCollected + 552 when closing frontend/inspected page
https://bugs.webkit.org/show_bug.cgi?id=159075
<rdar://problem/26094341>

Reviewed by Joseph Pecoraro.

Move the asynchronous work to a task class that can be cancelled when the
heap agent is reset, disabled or destroyed.

  • inspector/agents/InspectorHeapAgent.cpp:

(Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
(Inspector::SendGarbageCollectionEventsTask::addGarbageCollection):
(Inspector::SendGarbageCollectionEventsTask::reset):
(Inspector::SendGarbageCollectionEventsTask::timerFired):
Added. This holds onto GarbageCollection objects that need to be sent asynchronously.
It uses the RunLoop variant of Timer and can queue multiple pending objects to be sent.

(Inspector::InspectorHeapAgent::InspectorHeapAgent):
(Inspector::InspectorHeapAgent::~InspectorHeapAgent):
(Inspector::InspectorHeapAgent::disable):
Reset the task when disabling or tearing down the agent so the timer doesn't fire after destruction.

(Inspector::InspectorHeapAgent::didGarbageCollect):
Send the object to the task to be dispatched asynchronously.

  • inspector/agents/InspectorHeapAgent.h:
1:18 PM Changeset in webkit [202442] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Windows build fix.

  • platform/GenericTaskQueue.h:

(WebCore::TaskDispatcher::postTask):

1:17 PM Changeset in webkit [202441] by fred.wang@free.fr
  • 9 edits in trunk/Source/WebCore

Use auto* for MathML elements and renderers when possible
https://bugs.webkit.org/show_bug.cgi?id=159090

Patch by Frederic Wang <fwang@igalia.com> on 2016-06-24
Reviewed by Alex Christensen.

No new tests, behavior is unchanged.

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::attributeChanged):

  • mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::getSelectedActionChildAndIndex):
(WebCore::MathMLSelectElement::getSelectedActionChild):
(WebCore::MathMLSelectElement::getSelectedSemanticsChild):
(WebCore::MathMLSelectElement::updateSelectedChild):

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::isValid):

  • rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::layoutBlock):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::isValid):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::firstLineBaseline):
(WebCore::RenderMathMLRow::computeLineVerticalStretch):
(WebCore::RenderMathMLRow::computePreferredLogicalWidths):
(WebCore::RenderMathMLRow::layoutRowItems):

  • rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::unembellishedOperator):
(WebCore::RenderMathMLScripts::getBaseAndScripts):
(WebCore::RenderMathMLScripts::computePreferredLogicalWidths):
(WebCore::RenderMathMLScripts::getScriptMetricsAndLayoutIfNeeded):
(WebCore::RenderMathMLScripts::layoutBlock):
(WebCore::RenderMathMLScripts::firstLineBaseline):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::firstLineBaseline):
(WebCore::RenderMathMLUnderOver::isValid):
(WebCore::RenderMathMLUnderOver::over):

1:14 PM Changeset in webkit [202440] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unused and static return value from InspectorStyle::populateAllProperties
https://bugs.webkit.org/show_bug.cgi?id=159069

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-24
Reviewed by Andreas Kling.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::populateAllProperties):

  • inspector/InspectorStyleSheet.h:
12:40 PM Changeset in webkit [202439] by andersca@apple.com
  • 65 edits
    1 move in trunk/Source

Rename NoncopyableFunction to Function
https://bugs.webkit.org/show_bug.cgi?id=158354

Reviewed by Chris Dumez.

Source/WebCore:

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::runTask):

  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::resume):
(WebCore::AudioDestinationNode::suspend):
(WebCore::AudioDestinationNode::close):

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):

  • Modules/webaudio/DefaultAudioDestinationNode.h:
  • dom/ActiveDOMCallbackMicrotask.cpp:

(WebCore::ActiveDOMCallbackMicrotask::ActiveDOMCallbackMicrotask):

  • dom/ActiveDOMCallbackMicrotask.h:
  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::Task::Task):

  • fileapi/AsyncFileStream.cpp:

(WebCore::callOnFileThread):
(WebCore::AsyncFileStream::perform):

  • fileapi/AsyncFileStream.h:
  • page/FrameView.cpp:

(WebCore::FrameView::queuePostLayoutCallback):
(WebCore::FrameView::flushPostLayoutTasksQueue):

  • page/FrameView.h:
  • page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::dispatchBarrier):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):

  • page/scrolling/ScrollingThread.h:
  • platform/GenericTaskQueue.cpp:

(WebCore::TaskDispatcher<Timer>::postTask):

  • platform/GenericTaskQueue.h:

(WebCore::TaskDispatcher::postTask):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::scheduleDeferredTask):

  • platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::scheduleDeferredTask):

  • platform/mediastream/MediaStreamPrivate.h:
  • platform/mediastream/mac/AVMediaCaptureSource.h:
  • platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::scheduleDeferredTask):

  • style/StyleTreeResolver.cpp:

(WebCore::Style::postResolutionCallbackQueue):
(WebCore::Style::queuePostResolutionCallback):

  • style/StyleTreeResolver.h:

Source/WebKit:

  • Storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::dispatch):

  • Storage/StorageSyncManager.h:
  • Storage/StorageThread.cpp:

(WebCore::StorageThread::dispatch):
(WebCore::StorageThread::terminate):

  • Storage/StorageThread.h:

Source/WebKit2:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::fetchDiskCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::clearDiskCacheEntries):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::traverse):

  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:

(WebKit::NetworkCache::runTaskInQueue):

  • NetworkProcess/cache/NetworkCacheStorage.h:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CrossThreadTask.h:

(WTF::CrossThreadTask::CrossThreadTask):

  • wtf/Function.h: Renamed from Source/WTF/wtf/NoncopyableFunction.h.
  • wtf/FunctionDispatcher.h:
  • wtf/MainThread.cpp:

(WTF::functionQueue):
(WTF::dispatchFunctionsFromMainThread):
(WTF::callOnMainThread):

  • wtf/MainThread.h:
  • wtf/RunLoop.cpp:

(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):

  • wtf/RunLoop.h:
  • wtf/WorkQueue.h:
  • wtf/cocoa/WorkQueueCocoa.cpp:

(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):

  • wtf/efl/DispatchQueueWorkItemEfl.h:

(WorkItem::WorkItem):
(TimerWorkItem::create):
(TimerWorkItem::TimerWorkItem):

  • wtf/efl/WorkQueueEfl.cpp:

(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):

  • wtf/generic/RunLoopGeneric.cpp:

(WTF::RunLoop::TimerBase::ScheduledTask::create):
(WTF::RunLoop::TimerBase::ScheduledTask::ScheduledTask):
(WTF::RunLoop::dispatchAfter):

  • wtf/generic/WorkQueueGeneric.cpp:

(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

  • wtf/glib/RunLoopGLib.cpp:

(WTF::DispatchAfterContext::DispatchAfterContext):
(WTF::RunLoop::dispatchAfter):

  • wtf/win/WorkItemWin.cpp:

(WTF::WorkItemWin::WorkItemWin):
(WTF::WorkItemWin::create):
(WTF::HandleWorkItem::HandleWorkItem):
(WTF::HandleWorkItem::createByAdoptingHandle):

  • wtf/win/WorkItemWin.h:

(WTF::WorkItemWin::function):

  • wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):

12:26 PM Changeset in webkit [202438] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use _CFHTTPCookieStorageGetDefault directly instead of NSHTTPCookieStorage to get default cookie storage
https://bugs.webkit.org/show_bug.cgi?id=159095
rdar://problem/26630073

Patch by Amir Alavi <aalavi@apple.com> on 2016-06-24
Reviewed by Brent Fulgham.

No new tests, it isn't possible to test this in a LayoutTest.

  • platform/network/mac/CookieJarMac.mm:

(WebCore::httpCookiesForURL): Get a CFHTTPCookieStorageRef when no cookie storage is provided to match the case when cookie storage is provided.

12:15 PM Changeset in webkit [202437] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Update test expectations for rdar://problem/27000853

  • platform/mac/TestExpectations:
11:52 AM Changeset in webkit [202436] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Do not use iOS specific telephone detection on macOS.
https://bugs.webkit.org/show_bug.cgi?id=159096
rdar://problem/25870571

Reviewed by Anders Carlsson.

Adding platform guard.

  • platform/cocoa/TelephoneNumberDetectorCocoa.cpp:

(WebCore::TelephoneNumberDetector::phoneNumbersScanner):

11:51 AM Changeset in webkit [202435] by commit-queue@webkit.org
  • 44 edits
    48 deletes in trunk

Unreviewed, rolling out r202413.
https://bugs.webkit.org/show_bug.cgi?id=159097

Broke many JSC tests (Requested by ap on #webkit).

Reverted changeset:

"[JSC] Implement isFinite / isNaN in JS and make DFG ToNumber
accept non number values"
https://bugs.webkit.org/show_bug.cgi?id=154022
http://trac.webkit.org/changeset/202413

11:38 AM Changeset in webkit [202434] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r202429; AVStreamDataParser does not exist on iOS.

  • platform/spi/mac/AVFoundationSPI.h:
11:34 AM Changeset in webkit [202433] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

parser_unittests.pl should not hardcode list of tests
<https://webkit.org/b/159074>

Reviewed by Daniel Bates.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:

Update to read the list of tests from the 'resources' directory,
and instead map file extensions to subroutine names. Switch to
use File::Basename::fileparse() to get basename and file
extension for each test.
(readTestFiles): Added. Reads files from the directory passed
in and ignores: hidden files, anything that isn't a plain file,
and expected test results files.

11:31 AM Changeset in webkit [202432] by andersca@apple.com
  • 6 edits
    17 adds
    1 delete in trunk/Source/WebKit2

Move WebKit2 Apple Pay code to the open source repository
https://bugs.webkit.org/show_bug.cgi?id=159041

Reviewed by Sam Weinig.

  • DerivedSources.make:
  • Shared/Cocoa/WebCoreArgumentCodersCocoa.h: Added.
  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: Added.
  • UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp: Added.
  • UIProcess/ApplePay/WebPaymentCoordinatorProxy.h: Added.
  • UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in: Added.
  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h: Added.
  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: Added.
  • UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm: Added.
  • UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm: Added.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/ApplePay/WebPaymentCoordinator.cpp: Added.
  • WebProcess/ApplePay/WebPaymentCoordinator.h: Added.
  • WebProcess/ApplePay/WebPaymentCoordinator.messages.in: Added.
11:21 AM Changeset in webkit [202431] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix after r202429; Fix the type of the delegate property on AVStreamDataParser.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
  • platform/spi/mac/AVFoundationSPI.h:
11:19 AM Changeset in webkit [202430] by bshafiei@apple.com
  • 3 edits in branches/safari-602.1.38-branch/Source/WebKit2

Merged r202389. rdar://problem/26975138

10:46 AM Changeset in webkit [202429] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

[MSE] Adopt +[AVStreamDataParser outputMIMECodecParameterForInputMIMECodecParameter:]
https://bugs.webkit.org/show_bug.cgi?id=158312

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):

Move the declaration of AVStreamDataParser into AVFoundationSPI.h:

  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::update):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener streamDataParser:didProvideMediaData:forTrackID:mediaType:flags:]):

  • platform/spi/mac/AVFoundationSPI.h:
10:34 AM Changeset in webkit [202428] by wilander@apple.com
  • 6 edits in trunk/LayoutTests

Make window.open layout tests for about: URLs work on iOS
https://bugs.webkit.org/show_bug.cgi?id=159072

Reviewed by Alex Christensen.

Fix two window.open layout tests for iOS. They previously used click events.
Now they instead turn off the popup blocker and just call window.open() on
the load event.

  • http/tests/dom/window-open-about-blank-and-access-document-expected.txt:
  • http/tests/dom/window-open-about-blank-and-access-document.html:
  • http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt:
  • http/tests/dom/window-open-about-webkit-org-and-access-document.html:
  • platform/ios-simulator/TestExpectations:

Removed the skipping of these two test cases.

10:32 AM Changeset in webkit [202427] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS, Mac] Assume a media file has audio during AirPlay
https://bugs.webkit.org/show_bug.cgi?id=159088
<rdar://problem/24616592>

Reviewed by Jer Noble.

No new tests, it isn't possible to test this in a LayoutTest.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged): Call

mediaSession->setCanProduceAudio(true) when AirPlay becomes active.

10:13 AM Changeset in webkit [202426] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2] PageConfiguration.m_relatedPage keeps WebPageProxy alive after its WebView has been destroyed
https://bugs.webkit.org/show_bug.cgi?id=159080
<rdar://problem/26982642>

Reviewed by Anders Carlsson.

PageConfiguration.m_relatedPage keeps WebPageProxy alive after its WebView has been destroyed.
This leads to WebPageProxy object leaks when the client keeps chaining related views.

In this patch, we null our the PageConfiguration's relatedPage in WebPageProxy::close()
to break the chain and make sure we only keep alive 1 relatedPage rather than a chain of
them.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

10:12 AM Changeset in webkit [202425] by jer.noble@apple.com
  • 18 edits in trunk/Source

Playback controls refer to wrong element when playing multiple items in a page.
https://bugs.webkit.org/show_bug.cgi?id=159076
<rdar://problem/26953532>

Reviewed by Beth Dakin.

Source/WebCore:

Use a new method PlatformMediaSessionManager::currentSessionMatching() to get
the most recently active media element which qualifies for playback controls.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updatePlaybackControlsManager): Get the most recently active session.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::canControlControlsManager): Make virtual; no longer takes an element.

  • html/MediaElementSession.h:

(isType): Allow downcasting from PlatformMediaSession -> MediaElementSession.

  • page/ChromeClient.h:
  • platform/audio/PlatformMediaSession.h:

(WebCore::PlatformMediaSession::canControlControlsManager): Defaults to false;

  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::currentSessionMatching): Added.

  • platform/audio/PlatformMediaSessionManager.h:

Source/WebKit/mac:

clearPlaybackControlsManager() no longer takes a parameter.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::clearPlaybackControlsManager):

  • WebView/WebView.mm:

(-[WebView _clearPlaybackControlsManager]): Renamed from _clearPlaybackControlsManagerForMediaElement:.

  • WebView/WebViewInternal.h:

Source/WebKit2:

clearPlaybackControlsManager() no longer takes a parameter.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::clearPlaybackControlsManager):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/cocoa/WebPlaybackSessionManager.h:
  • WebProcess/cocoa/WebPlaybackSessionManager.mm:

(WebKit::WebPlaybackSessionManager::setUpPlaybackControlsManager): Make sure to removeClientForContext()

if the old context refers to a live media element.

(WebKit::WebPlaybackSessionManager::clearPlaybackControlsManager):

10:05 AM Changeset in webkit [202424] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

IDB tests crashing attempting to register sandbox extensions for blob files.
https://bugs.webkit.org/show_bug.cgi?id=159094.

Reviewed by Sam Weinig.

Already tested by storage/indexeddb/modern/handle-user-delete.html

  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::preregisterSandboxExtensionsIfNecessary): Check whether the IDBResultData actually contains

a getResult before trying to access it.

9:57 AM Changeset in webkit [202423] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed the macOS build.

  • platform/spi/cocoa/DataDetectorsCoreSPI.h:
9:24 AM Changeset in webkit [202422] by mitz@apple.com
  • 5 edits in trunk/Source/WebCore

[iOS] Inline DataDetectorsAdditions.h
https://bugs.webkit.org/show_bug.cgi?id=159093

Reviewed by Anders Carlsson.

  • editing/cocoa/DataDetection.mm:

(WebCore::constructURLStringForResult): Use soft-linked constant directly.

  • platform/cocoa/DataDetectorsCoreSoftLink.h: Declare soft-linked constant.
  • platform/cocoa/DataDetectorsCoreSoftLink.mm: Define soft-linked constant.
  • platform/spi/cocoa/DataDetectorsCoreSPI.h: Declare constant.
9:05 AM Changeset in webkit [202421] by Yusuke Suzuki
  • 4 edits
    2 adds in trunk

[GTK][EFL] ImageBufferCairo should accept resolution factor
https://bugs.webkit.org/show_bug.cgi?id=157848

Reviewed by Martin Robinson.

Source/WebCore:

ImageBufferCairo ignored the resolution factor passed in its constructor.
This resolution factor is originally introduced for HiDPI Canvas,
and since HiDPI canvas is not enabled in the ports using Cairo,
the lack of this implementation does not cause any problems.
And now, HiDPI Canvas is removed from the tree.

However, WebKit CSS filter uses this path.
The missing implementation is required under the HiDPI environment.

Since Cairo surface can have the device scale factor transparently,
the operations onto the surface is correctly done in the logical coordinate system.
So all we need to handle carefully is the direct surface modification done
in filter effects.

In this patch, we extend the image buffer size according to the resolution factor,
as the same to the CoreGraphics' implementation (ImageBufferCG). And by setting the
device scale factor of the surface correctly, we ensure that the rest of the Cairo
painting stack works with the existing logical coordinate system. And in ImageBufferCairo,
we carefully handle the logical and backing store coordinate system.

The attached test applies the CSS filter onto the svg image. And we resize the image size,
and perform scrolling. It incurs the paint, and filter effect recalcuation.
In that path, the filter effect side assumes that the image buffer size is scaled with the
resolution factor. So without this patch, it incurs buffer overflow and leads WebProcess crash.

  • platform/graphics/IntPoint.h:

(WebCore::IntPoint::scale):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::createCompositorBuffer):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::logicalUnit):
(WebCore::backingStoreUnit):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::copyToPlatformTexture):

LayoutTests:

  • fast/hidpi/filters-and-image-buffer-resolution-expected.html: Added.
  • fast/hidpi/filters-and-image-buffer-resolution.html: Added.
7:39 AM Changeset in webkit [202420] by fred.wang@free.fr
  • 55 edits in trunk

Refactor RenderMathMLOperator and RenderMathMLToken to avoid using anonymous renderers.
https://bugs.webkit.org/show_bug.cgi?id=155018

Patch by Frederic Wang <fwang@igalia.com> on 2016-06-24
Reviewed by Martin Robinson.

Source/WebCore:

No new tests, already covered by existing tests.

We use MathOperator for RenderMathMLOperator to avoid creating anonymous text nodes again
and again. We reimplement implicit mathvariant="italic" on single-char mi in a way that does
not rely on creating anonymous text nodes. Finally, we improve the determination/update of
when mathvariant is italic to avoid breaking foreign-mi-dynamic test.
The change in the render tree structure breaks mfenced accessibility support but that will
be fixed in follow-up patches. The simplifications made here will also allow to simplify the
accessibility code.

  • css/mathml.css:

(mo): Deleted. This flexbox rule is no longer needed.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::createAnonymousMathMLBlock): Deleted. We no longer need to
create anonymous renderer with this function.

  • rendering/mathml/RenderMathMLBlock.h: Delete createAnonymousMathMLBlock.
  • rendering/mathml/RenderMathMLOperator.cpp: Implement layout functions without relying on

flexbox or anonymous.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Handle the case of !useMathOperator()
for which we need to add extra operator spacing after the RenderMathMLToken layout.
(WebCore::RenderMathMLOperator::layoutBlock): Ditto.
(WebCore::RenderMathMLOperator::isChildAllowed): Deleted. We allow the non-anonymous text.
(WebCore::RenderMathMLOperator::rebuildTokenContent): No longer destroy and rebuild
anonymous wrapper. Remove updateStyle call.
(WebCore::RenderMathMLOperator::updateStyle): Deleted. We no longer need anonymous style for the spacing.

  • rendering/mathml/RenderMathMLOperator.h: Remove updateStyle() and isChildAllowed().

Make textContent() public so that it can be accessed from the accessibility code.

  • rendering/mathml/RenderMathMLToken.cpp: Reimplement implicit mathvariant="italic" by

painting MATHEMATICAL ITALIC characters instead of styling an anonymous wrapper.
(WebCore::RenderMathMLToken::RenderMathMLToken): Init m_mathVariantGlyph and m_mathVariantGlyphDirty
(WebCore::RenderMathMLToken::updateTokenContent): Set mathvariant glyph dirty when the content changes.
(WebCore::transformToItalic): Helper function to map latin and greek alphabets to their
MATHEMATICAL ITALIC counterpart.
(WebCore::RenderMathMLToken::computePreferredLogicalWidths): Implement this function to
handle the case where the mathvariant glyph is used.
(WebCore::RenderMathMLToken::updateMathVariantGlyph): Helper function to update the mathvariant glyph.
For now, we try and keep with the old (and limited) implementation: a mathvariant glyph may
only used for single-char <mi> without mathvariant attribute attached to it.
(WebCore::RenderMathMLToken::styleDidChange): Set the mathvariant glyph dirty when the style
changes.
(WebCore::RenderMathMLToken::updateFromElement): Remove updateStyle call and set mathvariant
glyph dirty.
(WebCore::RenderMathMLToken::firstLineBaseline): Implement this function to handle the case

where the mathvariant glyph is used.

(WebCore::RenderMathMLToken::layoutBlock): Ditto.
(WebCore::RenderMathMLToken::paint): Ditto.
(WebCore::RenderMathMLToken::paintChildren): Ditto.
(WebCore::RenderMathMLToken::addChild): Deleted. No need to bother with anonymous renderer
or style.
(WebCore::RenderMathMLToken::createWrapperIfNeeded): Deleted. Ditto.
(WebCore::RenderMathMLToken::updateStyle): Deleted. Ditto.

  • rendering/mathml/RenderMathMLToken.h: Update declarations of functions.

(WebCore::RenderMathMLToken::setMathVariantGlyphDirty): Helper function to indicate that the
mathvariant glyph will need to be updated.

LayoutTests:

We update the test expectations. Most of the adjustments are irrelevant visual
modifications (small shift and size differences) or due to changes in the renderer tree
structure (removal of anonymous, operator text appearing in the dumped text).
We disable the accessibility for mfenced for now, but this will be enabled again and improved
in follow-up accessibility patches.

  • platform/ios-simulator/TestExpectations: We disable two reftests that use a character from

the Mathematical Alphanumeric Symbols block as a reference, since iOS does not have
appropriate fonts pre-installed.

  • accessibility/mac/mathml-elements.html: Disable the mfenced test for now.
  • accessibility/mac/mathml-elements-expected.txt: Ditto.
  • accessibility/ios-simulator/math-expected.txt: Update the reference now that the text of

the operator appears in the render tree.

  • accessibility/mac/math-alttext-expected.txt: Ditto.
  • mathml/opentype/large-operators-italic-correction-expected.txt: Ditto.
  • mathml/opentype/large-operators-munderover-expected.txt: Ditto.
  • mathml/presentation/inferred-mrow-stretchy-expected.txt: Ditto.
  • mathml/presentation/mfrac-nested-expected.txt: Ditto.
  • mathml/presentation/stretchy-depth-height-expected.txt: Ditto.
  • mathml/presentation/stretchy-depth-height-symmetric-expected.txt: Ditto.
  • mathml/presentation/sup-nested-expected.txt: Ditto.
  • mathml/very-large-stretchy-operators-expected.txt: Ditto.
  • platform/mac/accessibility/math-text-expected.txt: Ditto.
  • platform/gtk/accessibility/math-text-expected.txt: Ditto.
  • fast/css/readonly-pseudoclass-common-element-expected.txt: Ditto.
  • fast/css/readwrite-pseudoclass-editable-expected.txt: Ditto.
  • imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-expected.txt: Ditto.
  • imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-xhtml-expected.txt: Ditto.
  • mathml/presentation/attributes-background-color.html: Add some padding to workaround some

small rendering failures.

  • mathml/presentation/attributes-background-color-expected.html: Ditto.
  • mathml/presentation/attributes-display.html: Ditto.
  • mathml/presentation/attributes-display-expected.html: Ditto.
  • mathml/presentation/bug97990-expected.html: Ditto.
  • mathml/presentation/bug97990.html: Ditto.
  • mathml/presentation/attributes-mathvariant-expected.html: Update the reftest to use italic

characters from the Mathematical Alphanumeric Symbols.

  • mathml/presentation/tokenElements-mathvariant-expected.html: Ditto.
  • mathml/presentation/mo-whitespaces-expected.html: Adjust one edge case since we now only

collapse whitespace for operators that use MathOperator.

  • accessibility/math-multiscript-attributes-expected.txt: Small size/coordinate adjustment.
  • platform/gtk/accessibility/math-multiscript-attributes-expected.txt: Dottp.
  • platform/gtk/mathml/presentation/roots-expected.txt: Size/coordinate adjustment, removal

of anonymous renderers and use italic characters from the Mathematical Alphanumeric Symbols.

  • platform/gtk/mathml/presentation/roots-expected.png: Ditto.
  • platform/ios-simulator/mathml/presentation/roots-expected.txt: Ditto.
  • platform/gtk/mathml/opentype/horizontal-expected.txt: Size/coordinate adjustment and

removal of anonymous renderers.

  • platform/gtk/mathml/opentype/horizontal-munderover-expected.txt: Ditto.
  • platform/gtk/mathml/opentype/large-operators-expected.txt: Ditto.
  • platform/gtk/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
  • platform/gtk/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Ditto.
  • platform/gtk/mathml/opentype/vertical-expected.txt: Ditto.
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt: Ditto.
  • platform/ios-simulator/mathml/opentype/horizontal-munderover-expected.txt: Ditto.
  • platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
  • platform/mac/mathml/opentype/large-operators-expected.txt: Ditto.
  • platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
  • platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Ditto.
  • platform/mac/mathml/opentype/vertical-expected.txt: Ditto.
12:39 AM Changeset in webkit [202419] by Gyuyoung Kim
  • 2 edits in trunk/Source/WebCore

Unreviewed EFL build fix.

There is forward declaration build error on EFL port.

  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Include DOMWindow.h and Document.h.

Jun 23, 2016:

11:07 PM Changeset in webkit [202418] by Simon Fraser
  • 3 edits in trunk/Tools

Fix Windows build.

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp:
  • DumpRenderTree/cg/PixelDumpSupportCG.h:
10:20 PM Changeset in webkit [202417] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit/win

[Win] The test accessibility/aria-labelledby-overrides-label.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=159057

Reviewed by Brent Fulgham.

The test expects the label to have a static text role, but currently it has a
group role.

  • AccessibleBase.cpp:

(MSAARole): Change the role of labels to static text.

9:51 PM Changeset in webkit [202416] by Gyuyoung Kim
  • 2 edits in trunk/Tools

[EFL] Change download path of libxslt

Unreviewed EFL build fix.

In Korea current download path can't be accessed. Change it.

  • efl/jhbuild.modules:
9:39 PM Changeset in webkit [202415] by commit-queue@webkit.org
  • 3 edits
    9 adds in trunk

OOM Assertion failure in Array.prototype.toString
https://bugs.webkit.org/show_bug.cgi?id=158793

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-23
Reviewed by Saam Barati.

Source/JavaScriptCore:

JSString::create() taking a StringImpl was using a signed integer
for the length of the string.
The problem is StringImpl uses an unsigned integer. When a large string
was passed to JSString, the signed integer would be negative and crash
JSString.

  • runtime/JSString.h:

(JSC::JSString::create):

LayoutTests:

  • js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js: Added.

(string_appeared_here.createStrings):

  • js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js: Added.

(string_appeared_here.createRegexp):
(catch):

  • js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js: Added.

(string_appeared_here.createStrings):
(catch):

  • js/stringimpl-to-jsstring-on-large-strings-1-expected.txt: Added.
  • js/stringimpl-to-jsstring-on-large-strings-1.html: Added.
  • js/stringimpl-to-jsstring-on-large-strings-2-expected.txt: Added.
  • js/stringimpl-to-jsstring-on-large-strings-2.html: Added.
  • js/stringimpl-to-jsstring-on-large-strings-3-expected.txt: Added.
  • js/stringimpl-to-jsstring-on-large-strings-3.html: Added.
9:08 PM Changeset in webkit [202414] by beidson@apple.com
  • 14 edits
    7 adds in trunk

Retrieving Blobs from IndexedDB using cursors fails in WK2 (Sandboxing)
https://bugs.webkit.org/show_bug.cgi?id=158991

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/blob-cursor.html

  • platform/network/BlobDataFileReference.cpp:

(WebCore::BlobDataFileReference::startTrackingModifications): Deleted.

Source/WebKit2:

  • CMakeLists.txt:
  • WebKit2.xcodeproj/project.pbxproj:
  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::getSandboxExtensionsForBlobFiles):
(WebKit::DatabaseProcess::didGetSandboxExtensionsForBlobFiles):

  • DatabaseProcess/DatabaseProcess.h:
  • DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::handleGetResult): Handle creation of sandbox extensions

for any result that might contain blob values.

(WebKit::WebIDBConnectionToClient::didGetRecord):
(WebKit::WebIDBConnectionToClient::didOpenCursor):
(WebKit::WebIDBConnectionToClient::didIterateCursor):

  • DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h:
  • Shared/Databases/IndexedDB/WebIDBResult.cpp: Added.

(WebKit::WebIDBResult::encode):
(WebKit::WebIDBResult::decode):

  • Shared/Databases/IndexedDB/WebIDBResult.h: Added.

(WebKit::WebIDBResult::WebIDBResult):
(WebKit::WebIDBResult::resultData):
(WebKit::WebIDBResult::handles):

  • Shared/SandboxExtension.h: Make SandboxExtension handles moveable.
  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::preregisterSandboxExtensionsIfNecessary): Register sandbox extensions with the

Networking process for any result that might contain blob values.

(WebKit::WebIDBConnectionToServer::didGetRecord):
(WebKit::WebIDBConnectionToServer::didOpenCursor):
(WebKit::WebIDBConnectionToServer::didIterateCursor):
(WebKit::WebIDBConnectionToServer::didGetRecordWithSandboxExtensions): Deleted.

  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:

LayoutTests:

  • storage/indexeddb/modern/blob-cursor-expected.txt: Added.
  • storage/indexeddb/modern/blob-cursor.html: Added.
  • storage/indexeddb/modern/resources/blob-cursor.js: Added.
  • storage/indexeddb/modern/resources/blob-cursor1.html: Added.
  • storage/indexeddb/modern/resources/blob-cursor2.html: Added.
8:41 PM Changeset in webkit [202413] by Yusuke Suzuki
  • 44 edits
    1 copy
    47 adds in trunk

[JSC] Implement isFinite / isNaN in JS and make DFG ToNumber accept non number values
https://bugs.webkit.org/show_bug.cgi?id=154022

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

We aim at optimizing @toInteger operation.
While it still has an unoptimized part[1], this patch should be a first step.

We introduce the @toNumber builtin intrinsic operation.
This converts the given value to the JS number by emitting op_to_number bytecode.
Previously @toInteger called C++ @Number constructor for that purpose.

And in DFG, op_to_number is converted to DFG ToNumber node.
During DFG, we attempt to convert this to edge filtering and Identity, but if we fail,
we just fall back to calling the C++ function.

To utilize ToNumber in user-land side, we add a path attempting to convert Number constructor calls
to ToNumber DFG nodes. This conversion is useful because Number(value) is used to convert a value to a number in JS.

Before this patch, we emit simple edge filtering (NumberUse) instead of emitting DFG node like ToNumber for op_to_number.
But emitting ToNumber is useful, because in the case of Number(value), considering value may not be a number is reasonable.

By leveraging @toNumber operation, we rewrite Number.{isFinite, isNaN}, global.{isFinite, isNaN} and @toInteger.

ToNumber DFG node has a value profiling. This profiling is leveraged to determine the result number type of the ToNumber operation.
This value profiling is provided from either NumberConstructor's call operation or op_to_number.

The results (with the added performance tests) show that, while existing cases are performance neutral, the newly added cases gain the performance benefit.
And ASMBench/n-body.c also shows stable ~2% progression.

[1]: https://bugs.webkit.org/show_bug.cgi?id=153738

  • CMakeLists.txt:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • builtins/BuiltinNames.h:
  • builtins/GlobalObject.js:

(globalPrivate.isFinite):
(globalPrivate.isNaN):
(globalPrivate.toInteger): Deleted.
(globalPrivate.toLength): Deleted.
(globalPrivate.isDictionary): Deleted.
(globalPrivate.speciesGetter): Deleted.
(globalPrivate.speciesConstructor): Deleted.

  • builtins/GlobalOperations.js: Copied from Source/JavaScriptCore/builtins/GlobalObject.js.

(globalPrivate.toInteger):
(globalPrivate.toLength):
(globalPrivate.isDictionary):
(globalPrivate.speciesGetter):
(globalPrivate.speciesConstructor):

  • builtins/NumberConstructor.js: Added.

(isFinite):
(isNaN):

  • bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecode/BytecodeList.json:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitUnaryOp):
(JSC::BytecodeGenerator::emitUnaryOpProfiled):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitToNumber):

  • bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_toNumber):
(JSC::UnaryPlusNode::emitBytecode):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):
We use getPrediction() to retrieve the heap prediction from the to_number bytecode.
According to the benchmark results, choosing getPredictionWithoutOSRExit() causes performance regression (1.5%) in kraken stanford-crypto-aes.

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToNumber):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

Alway rely on the heap prediction.

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
As of 64bit version, we carefully manage the register reuse. The largest difference between 32bit and 64bit is
branchIfNotNumber() requires the temporary register. We should not use the result registers for that since
it may be reuse the argument registers and it can break the argument registers before using them to call the operation.
Currently, we allocate the additional temporary register for that scratch register.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
Reuse the argument register for the result if possible. And manually decrement the use count in the middle of the node.
This is similar technique used in ToPrimitive. Typically, the child of ToNumber is only used by this ToNumber node since
we would like to perform the type conversion onto this child node here. So this careful register reuse effectively removes
the spills to call the operation. The example of the actually emitted code is the following.

76:<!2:loc11> ToNumber(Untyped:@68, JS|MustGen|UseAsOther, DoubleimpurenanTopEmpty, R:World, W:Heap, Exits, ClobbersExit, bc#48) predicting DoubleimpurenanTopEmpty

0x7f986d5fe693: test %rax, %r14
0x7f986d5fe696: jz 0x7f986d5fe6a1
0x7f986d5fe69c: jmp 0x7f986d5fe6d1
0x7f986d5fe6a1: mov %rax, %rsi
0x7f986d5fe6a4: mov %rbp, %rdi
0x7f986d5fe6a7: mov $0x2, 0x24(%rbp)
0x7f986d5fe6ae: mov $0x7f98711ea5f0, %r11
0x7f986d5fe6b8: call *%r11
0x7f986d5fe6bb: mov $0x7f982d3f72d0, %r11
0x7f986d5fe6c5: mov (%r11), %r11
0x7f986d5fe6c8: test %r11, %r11
0x7f986d5fe6cb: jnz 0x7f986d5fe88c

It effectively removes the unnecessary spill to call the operation!

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumber):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::branchIfNumber):
(JSC::AssemblyHelpers::branchIfNotNumber):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_number):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_to_number):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • parser/Nodes.h:

(JSC::UnaryOpNode::opcodeID):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncIsNaN): Deleted.
(JSC::globalFuncIsFinite): Deleted.

  • runtime/JSGlobalObjectFunctions.h:
  • runtime/MathCommon.h:

(JSC::maxSafeInteger):
(JSC::minSafeInteger):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::finishCreation):
(JSC::numberConstructorFuncIsFinite): Deleted.
(JSC::numberConstructorFuncIsNaN): Deleted.

  • runtime/NumberConstructor.h:
  • tests/stress/Number-isNaN-basics.js: Added.

(numberIsNaNOnInteger):
(testNumberIsNaNOnIntegers):
(verifyNumberIsNaNOnIntegerWithOtherTypes):
(numberIsNaNOnDouble):
(testNumberIsNaNOnDoubles):
(verifyNumberIsNaNOnDoublesWithOtherTypes):
(numberIsNaNNoArguments):
(numberIsNaNTooManyArguments):
(testNumberIsNaNOnConstants):
(numberIsNaNStructTransition):
(Number.isNaN):

  • tests/stress/global-is-finite.js: Added.

(shouldBe):

  • tests/stress/global-is-nan.js: Added.

(shouldBe):

  • tests/stress/global-isNaN-basics.js: Added.

(isNaNOnInteger):
(testIsNaNOnIntegers):
(verifyIsNaNOnIntegerWithOtherTypes):
(isNaNOnDouble):
(testIsNaNOnDoubles):
(verifyIsNaNOnDoublesWithOtherTypes):
(verifyIsNaNOnCoercedTypes):
(isNaNNoArguments):
(isNaNTooManyArguments):
(testIsNaNOnConstants):
(isNaNTypeCoercionSideEffects):
(i.value.isNaNTypeCoercionSideEffects.valueOf):
(isNaNStructTransition):
(isNaN):

  • tests/stress/number-is-finite.js: Added.

(shouldBe):
(test2):
(test3):

  • tests/stress/number-is-nan.js: Added.

(shouldBe):
(test2):
(test3):

  • tests/stress/to-number-basics.js: Added.

(shouldBe):

  • tests/stress/to-number-convert-identity-without-execution.js: Added.

(shouldBe):
(object.valueOf):
(valueOf):

  • tests/stress/to-number-int52.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-intrinsic-convert-to-identity-without-execution.js: Added.

(shouldBe):
(object.valueOf):
(valueOf):

  • tests/stress/to-number-intrinsic-int52.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-intrinsic-object-without-execution.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-intrinsic-value-profiling.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-object-without-execution.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-object.js: Added.

(shouldBe):
(test12):
(object1.valueOf):
(test2):
(test22):
(object2.valueOf):
(test3):
(test32):
(object3.valueOf):

  • tests/stress/to-number-value-profiling.js: Added.

(shouldBe):
(object.valueOf):

LayoutTests:

  • js/regress/Number-isNaN-expected.txt: Added.
  • js/regress/Number-isNaN.html: Added.
  • js/regress/global-isNaN-expected.txt: Added.
  • js/regress/global-isNaN.html: Added.
  • js/regress/script-tests/Number-isNaN.js: Added.
  • js/regress/script-tests/global-isNaN.js: Added.
  • js/regress/script-tests/many-foreach-calls.js:

(i.4.forEach):
(i.array.forEach): Deleted.

  • js/regress/script-tests/to-number-constructor-number-string-number-string.js: Added.

(test):

  • js/regress/script-tests/to-number-constructor-only-number.js: Added.

(test):

  • js/regress/script-tests/to-number-constructor-only-string.js: Added.

(test):

  • js/regress/script-tests/to-number-constructor-string-number-string-number.js: Added.

(test):

  • js/regress/script-tests/to-number-number-string-number-string.js: Added.

(test):

  • js/regress/script-tests/to-number-only-number.js: Added.

(test):

  • js/regress/script-tests/to-number-only-string.js: Added.

(test):

  • js/regress/script-tests/to-number-string-number-string-number.js: Added.

(test):

  • js/regress/to-number-constructor-number-string-number-string-expected.txt: Added.
  • js/regress/to-number-constructor-number-string-number-string.html: Added.
  • js/regress/to-number-constructor-only-number-expected.txt: Added.
  • js/regress/to-number-constructor-only-number.html: Added.
  • js/regress/to-number-constructor-only-string-expected.txt: Added.
  • js/regress/to-number-constructor-only-string.html: Added.
  • js/regress/to-number-constructor-string-number-string-number-expected.txt: Added.
  • js/regress/to-number-constructor-string-number-string-number.html: Added.
  • js/regress/to-number-number-string-number-string-expected.txt: Added.
  • js/regress/to-number-number-string-number-string.html: Added.
  • js/regress/to-number-only-number-expected.txt: Added.
  • js/regress/to-number-only-number.html: Added.
  • js/regress/to-number-only-string-expected.txt: Added.
  • js/regress/to-number-only-string.html: Added.
  • js/regress/to-number-string-number-string-number-expected.txt: Added.
  • js/regress/to-number-string-number-string-number.html: Added.
8:34 PM Changeset in webkit [202412] by Simon Fraser
  • 4 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=159077

Tools:

Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
snapshot the final state of the test in release builds.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):

LayoutTests:

Mark fast/harness/snapshot-captures-compositing.html as an image failure.

  • platform/ios-simulator-wk2/TestExpectations:
7:50 PM Changeset in webkit [202411] by Simon Fraser
  • 3 edits in trunk/Tools

Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.

  • DumpRenderTree/ios/PixelDumpSupportIOS.mm:

(createBitmapContextFromWebView):

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::windowSnapshotImage):

7:47 PM Changeset in webkit [202410] by achristensen@apple.com
  • 30 edits in trunk/Source

Remove unused didCancelAuthenticationChallenge
https://bugs.webkit.org/show_bug.cgi?id=158819

Reviewed by David Kilzer.

Source/WebCore:

No change in behavior. This callback was deprecated in Yosemite. It is never called.

  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): Deleted.

  • loader/ResourceLoadNotifier.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didCancelAuthenticationChallenge): Deleted.

  • loader/ResourceLoader.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didCancelAuthenticationChallenge): Deleted.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::didCancelAuthenticationChallenge): Deleted.

  • platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Deleted.

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didCancelAuthenticationChallenge:]): Deleted.

  • platform/spi/cocoa/NSURLDownloadSPI.h:

Source/WebKit/ios:

  • DefaultDelegates/WebDefaultResourceLoadDelegate.m:

(-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
(-[WebDefaultResourceLoadDelegate webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:]):
(-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]): Deleted.

Source/WebKit/mac:

  • Misc/WebDownload.mm:

(-[WebDownloadInternal download:didCancelAuthenticationChallenge:]): Deleted.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebView.mm:

(-[WebView _cacheResourceLoadDelegateImplementations]):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit2:

  • NetworkProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:didCancelAuthenticationChallenge:]): Deleted.

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::didCancelAuthenticationChallenge): Deleted.

  • NetworkProcess/NetworkLoad.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
7:44 PM Changeset in webkit [202409] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Add "shippingType" to the list of valid payment request properties
https://bugs.webkit.org/show_bug.cgi?id=159079
<rdar://problem/26988429>

Reviewed by Dean Jackson.

  • Modules/applepay/ApplePaySession.cpp:

(WebCore::isValidPaymentRequestPropertyName):

7:38 PM Changeset in webkit [202408] by benjamin@webkit.org
  • 29 edits
    14 adds in trunk

Specialize synchronous event tracking per event type
https://bugs.webkit.org/show_bug.cgi?id=158826

Reviewed by Simon Fraser.

Source/WebCore:

First, kudos to Rick Byers for all his helps on passive event dispatch.
The specs are pretty damn good and his help reviewing patches is very useful.

This patch change synchronous event dispatch to happen per event
instead of per sequence touchstart->touchend.

The big advantage of this is we can dispatch more events asynchronously.
For example, to handle a tap programmatically, you can limit the active listener
to the touchend event. The touchstart and touchmove are now dispatched asynchronously.

The implementation is a simple extension to EventTrackingRegions.
Instead of a single synchronous region, we have one region per event type.
When processing the events, we only need to send the events synchronously
if that particular event type has a synchronous region.

Note that EventDispatcher's touch event support already supports
mixing synchronous and asynchronous events. The events are always processed
in order even if asynchronous events are pending when a synchronous dispatch
happens.

Tests: fast/events/touch/ios/tap-with-active-listener-inside-document-with-passive-listener.html

fast/events/touch/ios/tap-with-active-listener-inside-window-with-passive-listener.html
fast/events/touch/ios/tap-with-active-touch-end-listener.html
fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html
fast/events/touch/ios/tap-with-passive-touch-end-listener.html
fast/events/touch/ios/tap-with-passive-touch-start-active-touch-end-listeners-on-elements.html
fast/events/touch/ios/tap-with-passive-touch-start-active-touch-move-listeners-on-elements.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::hasActiveTouchEventListeners): Deleted.

  • dom/EventTarget.h:
  • page/DebugPageOverlays.cpp:

(WebCore::NonFastScrollableRegionOverlay::updateRegion):

  • page/Page.cpp:

(WebCore::Page::nonFastScrollableRects):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame):

  • page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::eventTrackingTypeForPoint):

  • page/scrolling/ScrollingTree.h:
  • platform/EventTrackingRegions.cpp: Added.

(WebCore::EventTrackingRegions::trackingTypeForPoint):
(WebCore::EventTrackingRegions::isEmpty):
(WebCore::EventTrackingRegions::translate):
(WebCore::EventTrackingRegions::uniteSynchronousRegion):
(WebCore::EventTrackingRegions::unite):
(WebCore::operator==):

  • platform/EventTrackingRegions.h:

(WebCore::EventTrackingRegions::isEmpty): Deleted.
(WebCore::EventTrackingRegions::trackingTypeForPoint): Deleted.
(WebCore::operator==): Deleted.

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<EventTrackingRegions>::encode):
(IPC::ArgumentCoder<EventTrackingRegions>::decode):

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::eventTrackingTypeForPoint):

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::mergeTrackingTypes):
(WebKit::WebPageProxy::updateTouchEventTracking):
(WebKit::WebPageProxy::touchEventTrackingType):
(WebKit::WebPageProxy::handleTouchEventSynchronously):
(WebKit::WebPageProxy::handleTouchEventAsynchronously):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::resetState):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::TouchEventTracking::isTrackingAnything):
(WebKit::WebPageProxy::TouchEventTracking::reset):

LayoutTests:

  • fast/events/touch/ios/tap-with-active-listener-inside-document-with-passive-listener-expected.txt: Added.
  • fast/events/touch/ios/tap-with-active-listener-inside-document-with-passive-listener.html: Added.
  • fast/events/touch/ios/tap-with-active-listener-inside-window-with-passive-listener-expected.txt: Added.
  • fast/events/touch/ios/tap-with-active-listener-inside-window-with-passive-listener.html: Added.
  • fast/events/touch/ios/tap-with-active-touch-end-listener-expected.txt: Added.
  • fast/events/touch/ios/tap-with-active-touch-end-listener.html: Added.
  • fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html: Added.
  • fast/events/touch/ios/tap-with-passive-touch-end-listener-expected.txt: Added.
  • fast/events/touch/ios/tap-with-passive-touch-end-listener.html: Added.
  • fast/events/touch/ios/tap-with-passive-touch-start-active-touch-end-listeners-on-elements-expected.txt: Added.
  • fast/events/touch/ios/tap-with-passive-touch-start-active-touch-end-listeners-on-elements.html: Added.
  • fast/events/touch/ios/tap-with-passive-touch-start-active-touch-move-listeners-on-elements-expected.txt: Added.
  • fast/events/touch/ios/tap-with-passive-touch-start-active-touch-move-listeners-on-elements.html: Added.
5:59 PM Changeset in webkit [202407] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

More attempting to fix external iOS builds.

  • platform/spi/cocoa/QuartzCoreSPI.h:
5:25 PM Changeset in webkit [202406] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Update TestExpectations for a couple video track tests.

  • platform/mac/TestExpectations:
5:12 PM Changeset in webkit [202405] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Try to fix the non-internal builds by defining CARenderServerBufferRef.

  • platform/spi/cocoa/QuartzCoreSPI.h:
5:08 PM Changeset in webkit [202404] by Simon Fraser
  • 12 edits
    2 adds in trunk

[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
https://bugs.webkit.org/show_bug.cgi?id=159077

Reviewed by Tim Horton.

Source/WebCore:

Add CARenderServer SPIs.

Test: fast/harness/snapshot-captures-compositing.html

  • platform/spi/cocoa/QuartzCoreSPI.h:

Tools:

Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
This allows them to capture compositing layers in snapshots, rather than doing a software paint,
thus enabling testing of more things.

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp:

(createBitmapContext): Moved to this file to share it.

  • DumpRenderTree/cg/PixelDumpSupportCG.h:
  • DumpRenderTree/ios/PixelDumpSupportIOS.mm:

(createBitmapContextFromWebView):
(BitmapContext::createFromUIImage): Deleted.
(BitmapContext::pixelData): Deleted.
(BitmapContext::BitmapContext): Deleted.
(computeMD5HashStringForBitmapContext): Deleted.
(dumpBitmap): Deleted.

  • DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:

(createPagedBitmapContext):
(createBitmapContext): Deleted.

  • WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Deleted.

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::windowSnapshotImage):

LayoutTests:

Test that fails if snapshotting doesn't correctly snapshot 3D transforms.

  • fast/harness/snapshot-captures-compositing-expected.html: Added.
  • fast/harness/snapshot-captures-compositing.html: Added.
5:00 PM Changeset in webkit [202403] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

4:28 PM Changeset in webkit [202402] by sbarati@apple.com
  • 8 edits
    1 add in trunk/Source/JavaScriptCore

DFGSpeculativeJIT's m_slowPathLambdas should restore the current node field and DFG OSR entry functions should use DeferGCForAWhile instead of DeferGC
https://bugs.webkit.org/show_bug.cgi?id=159064
<rdar://problem/26599119>

Reviewed by Filip Pizlo.

The DFG has a list of m_slowPathLambdas that are code generators it emits
amongst its slow paths. These lambdas, however, did not update the m_currentNode field.
This caused us to use whatever Node happened to be used as the currentNode at the time
we call the slowPathLambda. This means the wrong CallSiteIndex was stored into the call
frame when we made a call. This may lead to a crash if the CallSiteIndex corresponds to
the wrong CodeOrigin. For example, the wrong CodeOrigin could have an InlineCallFrame with
a calleeRecovery that will not be in sync with the current stack state. Trying
to recover that callee will often lead to a crash. The solution is to update
m_currentNode to the DFG::Node* it corresponds to when emitting these slowPathLambdas.

I found this bug because we were inside this bad state when calling an operation
that happened to have a DeferGC. When this DeferGC actually GCed, it would
take a StackTrace, which would lead to a crash because we were updating
ShadowChicken with vm.topCallFrame. It just so happened that the CallSiteIndex
in the call frame in this program corresponded to an InlineCallFrame with a calleeRecover.
However, this CallSiteIndex didn't correspond to the actual state of execution
of the program. I'm adding new options to make reproducing DeferGC related
bugs easier by making DeferGC force a GC according to some probability. To
always have DeferGC force a GC, you can set that probability to 1.

There is a second bug that I discovered after solving the above bug. We were
using DeferGC instead of DeferGCForAWhile in the OSR entry related functions
in the DFG. This would cause us to take a stack trace when the call frame was
in an inconsistent state. For example, the operation would call FTL::prepareOSREntry,
which would replace the DFG CodeBlock in the call frame with the FTL CodeBlock.
However, we wouldn't update the CallSiteIndex to correspond to an FTL CallSiteIndex.
This would lead to a crash when taking a stack trace. The solution is to prevent
stack traces from being taken when the program is in this state by using
DeferGCForAWhie instead of DeferGC.

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):

  • dfg/DFGSpeculativeJIT.h:
  • heap/Heap.h:
  • heap/HeapInlines.h:

(JSC::Heap::collectIfNecessaryOrDefer):
(JSC::Heap::collectAccordingToDeferGCProbability):
(JSC::Heap::decrementDeferralDepthAndGCIfNeeded):
(JSC::Heap::markListSet):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):
(JSC::Options::initialize):

  • runtime/Options.h:
  • tests/stress/slow-path-generator-updating-current-node-dfg.js: Added.

(foo):
(bar):

4:22 PM Changeset in webkit [202401] by Brian Burg
  • 3 edits in trunk/Source/WebCore

Web Inspector: add assertions to catch dangling frontends that persist between tests
https://bugs.webkit.org/show_bug.cgi?id=159073

Reviewed by Joseph Pecoraro.

Based on the analysis in https://webkit.org/b/159070, we suspect that some test
flakiness might be caused by dangling frontends from previous test cases. Add an
assertion that should catch any frontends that are attached to the inspected page's
backend. There should never be any frontends connected when a test first starts.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::setIsUnderTest):

  • inspector/InspectorController.h:
3:52 PM Changeset in webkit [202400] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

REGRESSION (r202380): iOS 9.x internal builds are broken

Follow-up fix for: Enable window.open() for existing versions of Secret Society
<https://webkit.org/b/159049>
<rdar://problem/26528349>

  • wtf/spi/darwin/dyldSPI.h: Define DYLD_IOS_VERSION_10_0 when

building on internal SDKs older than iOS 10.

3:46 PM Changeset in webkit [202399] by commit-queue@webkit.org
  • 26 edits
    4 adds in trunk

requestFrameAnimation() callback timestamp should be very close to Performance.now()
https://bugs.webkit.org/show_bug.cgi?id=159038

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-06-23
Reviewed by Simon Fraser.

Source/WebCore:

Pass the Performance.now() to requestFrameAnimation() callback. Do not add
the timeUntilOutput which is the difference between outputTime and now since
this addition makes us report a timestamp ahead in the future by almost 33ms.

A new function named "nowTimestamp()" is added to the DOMWindow class. It
calls Performance.now() if WEB_TIMING is enabled, otherwise it calls
monotonicallyIncreasingTime(). The returned timestamp is seconds and it is
relative to the document loading time.

The timestamp passing will be removed all the down till the callers of
ScriptedAnimationController::serviceScriptedAnimations(). The callers will
getting the now timestamp by calling DOMWindow::nowTimestamp().

Tests: animations/animation-callback-timestamp.html

animations/animation-multiple-callbacks-timestamp.html

  • dom/Document.cpp:

(WebCore::Document::monotonicTimestamp):
(WebCore::Document::serviceScriptedAnimations):

  • dom/Document.h:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::animationTimerFired):
(WebCore::ScriptedAnimationController::displayRefreshFired):

  • dom/ScriptedAnimationController.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::getVideoPlaybackQuality):

  • loader/DocumentLoadTiming.h:

(WebCore::DocumentLoadTiming::referenceWallTime):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::nowTimestamp):

  • page/DOMWindow.h:
  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

  • page/FrameView.h:
  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayDidRefresh):

  • platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::setMonotonicAnimationStartTime): Deleted.

  • platform/graphics/DisplayRefreshMonitorClient.cpp:

(WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded):

  • platform/graphics/DisplayRefreshMonitorClient.h:
  • platform/graphics/GraphicsLayerUpdater.cpp:

(WebCore::GraphicsLayerUpdater::displayRefreshFired):

  • platform/graphics/GraphicsLayerUpdater.h:
  • platform/graphics/ios/DisplayRefreshMonitorIOS.h:
  • platform/graphics/ios/DisplayRefreshMonitorIOS.mm:

(-[WebDisplayLinkHandler handleDisplayLink:]):
(WebCore::DisplayRefreshMonitorIOS::displayLinkFired):
(WebCore::mediaTimeToCurrentTime): Deleted.

  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::displayLinkCallback):
(WebCore::DisplayRefreshMonitorMac::displayLinkFired):

  • platform/graphics/mac/DisplayRefreshMonitorMac.h:
  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::syncDisplayState):
(WebCore::CompositingCoordinator::nextAnimationServiceTime):

Source/WebKit2:

  • WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.mm:

(WebKit::RemoteLayerTreeDisplayRefreshMonitor::didUpdateLayers):

LayoutTests:

  • animations/animation-callback-timestamp-expected.txt: Added.
  • animations/animation-callback-timestamp.html: Added.
  • animations/animation-multiple-callbacks-timestamp-expected.txt: Added.
  • animations/animation-multiple-callbacks-timestamp.html: Added.
2:28 PM Changeset in webkit [202398] by ddkilzer@apple.com
  • 1 edit
    1 delete in trunk/Source/WebCore

Remove unused HarfBuzzFaceCoreText.cpp
<https://webkit.org/b/159065>

Reviewed by Myles C. Maxfield.

  • platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp: Removed.
1:55 PM Changeset in webkit [202397] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Failing baseline JIT compilation of a code block and then trying to compile it from OSR from DFG/FTL will corrupt the CodeBlock
https://bugs.webkit.org/show_bug.cgi?id=158806

Reviewed by Saam Barati.

If we try to compile a CodeBlock that we already tried compiling in the past then we need
to clean up the data structures that were partly filled in by the failed compile. That
causes some races, since the DFG may be trying to parse those data structures while we are
clearing them. This patch introduces such a clean-up (CodeBlock::resetJITData()) and fixes
the races.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::getStubInfoMap):
(JSC::CodeBlock::getCallLinkInfoMap):
(JSC::CodeBlock::getByValInfoMap):
(JSC::CodeBlock::getCallLinkInfoForBytecodeIndex):
(JSC::CodeBlock::resetJITData):
(JSC::CodeBlock::visitOSRExitTargets):
(JSC::CodeBlock::setSteppingMode):
(JSC::CodeBlock::addRareCaseProfile):
(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):
(JSC::CodeBlock::rareCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::resultProfileForBytecodeOffset):
(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::ensureResultProfile):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getFromAllValueProfiles):
(JSC::CodeBlock::numberOfRareCaseProfiles):
(JSC::CodeBlock::numberOfResultProfiles):
(JSC::CodeBlock::numberOfArrayProfiles):
(JSC::CodeBlock::arrayProfiles):
(JSC::CodeBlock::addRareCaseProfile): Deleted.
(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset): Deleted.
(JSC::CodeBlock::couldTakeSpecialFastCase): Deleted.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

  • jit/JIT.cpp:

(JSC::JIT::link):

  • jit/JITWorklist.cpp:

(JSC::JITWorklist::compileNow):

1:21 PM Changeset in webkit [202396] by bshafiei@apple.com
  • 2 edits in branches/safari-602.1.38-branch/Source/WebKit2

Merged r202393. rdar://problem/17665473

1:16 PM Changeset in webkit [202395] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Land test expectations for rdar://problem/26952627.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
1:05 PM Changeset in webkit [202394] by commit-queue@webkit.org
  • 21 edits in trunk/Source

Web Inspector: Memory Timeline sometimes shows impossible value for bmalloc size (underflowed)
https://bugs.webkit.org/show_bug.cgi?id=158110
<rdar://problem/26498584>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-23
Reviewed by Andreas Kling.

Source/JavaScriptCore:

  • heap/Heap.cpp:

(JSC::Heap::willStartCollection):
(JSC::Heap::didFinishCollection):

  • heap/Heap.h:

(JSC::Heap::externalMemorySize):

  • heap/HeapInlines.h:

(JSC::Heap::reportExternalMemoryVisited):
Keep count of external memory we visit.

  • heap/SlotVisitor.h:
  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::reportExternalMemoryVisited):
Report external memory visited like we do extra memory, since
it will be some subset of extra memory that is external.

Source/WebCore:

IOSurface memory backing Canvas element buffers should be classified as "GC Owned",
but should not be considered a part of bmalloc. In fact, the actual memory cost is
external to the Web Content Process. The majority of extra memory reporters tend
to report extra memory that is also allocated in bmalloc. However, some report
non-bmalloc memory, such as the IOSurfaces here.

Continue to report the memory cost without changes to inform the Heap for garbage
collection. However, also keep better accounting of GCOwned memory that is external
to the process for better accounting for the Resource Usage overlay and Web Inspector
Memory timeline.

This is a bit of a game where we want to display the best possible number for
"GCOwned memory" in the tools, but some of that memory shows up in the other
regions (bmalloc, system malloc, etc). Already many sizes are estimates
(ReportExtraMemory, reportExtraMemory ignores small allocations), so we just focus
on getting the largest sources of allocations, such as Canvas IOSurfaces here,
into the right bucket. ResourceUsageThreadCocoa continues to subtract the "extra"
memory from bmalloc. So, we should address other large sources of "extra memory"
not in bmalloc. A likely candidate is HTMLMediaElement which uses the deprecated
reporting right now.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:

Add a way to report External memory, dependent on reporting Extra memory.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::externalMemoryCost):

  • html/HTMLCanvasElement.h:
  • html/HTMLCanvasElement.idl:

Report external memory cost just like extra memory.

  • page/ResourceUsageData.cpp:

(WebCore::ResourceUsageData::ResourceUsageData):

  • page/ResourceUsageData.h:

(WebCore::MemoryCategoryInfo::totalSize):

  • page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::RingBuffer::at):
(WebCore::appendDataToHistory):
(WebCore::ResourceUsageOverlay::platformDraw):

  • page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::categoryForVMTag):
(WebCore::ResourceUsageThread::platformThreadBody):
Do not count the GCOwned External memory as dirty memory.
Include External memory output in the overlay.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::collectSample):
When sizing the JavaScript portion, include both the GC Owned
category's dirty and external memory. Ultimately we will
want this everywhere in case things change.

  • platform/graphics/ImageBuffer.cpp:

(WebCore::memoryCost):
(WebCore::externalMemoryCost):

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::memoryCost):
(WebCore::ImageBuffer::externalMemoryCost):
Report IOSurface total bytes as extra memory and external memory
so that it can be tracked as GC Owned memory that is separate from
regular (bmalloc/other) in process memory.

12:58 PM Changeset in webkit [202393] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[iOS] A WebPageProxy in closed state should not be allowed to hold a process assertion
https://bugs.webkit.org/show_bug.cgi?id=159068
<rdar://problem/17665473>

Reviewed by Tim Horton.

A WebPageProxy in closed state should not be allowed to hold a process assertion. It
currently happens that WebPageProxy::close() gets called but that the WebPageProxy is
kept alive by Safari (e.g. In case of top-hit preloading). In such cases, we fail to
release the foreground process assertion that the WebPageProxy holds.

We should clear the foreground process assertion that the WebPageProxy holds as soon
as WebPageProxy::close() is called.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

12:24 PM Changeset in webkit [202392] by Konstantin Tokarev
  • 3 edits in trunk/Tools

[jhbuild] Added libxslt module.
https://bugs.webkit.org/show_bug.cgi?id=159034

Unreviewed, followup for r202373.

  • efl/install-dependencies: Removed libxslt
  • gtk/install-dependencies: Ditto.
12:20 PM Changeset in webkit [202391] by bshafiei@apple.com
  • 12 edits in branches/safari-602.1.38-branch/Source

Merge patch for rdar://problem/26831566.

12:17 PM Changeset in webkit [202390] by ap@apple.com
  • 4 edits in trunk

Handle (0, 0) ranges from Lookup
https://bugs.webkit.org/show_bug.cgi?id=159062
rdar://problem/26960385

Reviewed by Tim Horton.

Source/WebCore:

  • editing/mac/DictionaryLookup.mm: (WebCore::DictionaryLookup::rangeAtHitTestResult):

Paper over <https://bugs.webkit.org/show_bug.cgi?id=159063>, which seems too involved
to fix now.

LayoutTests:

  • platform/mac/TestExpectations: Unmark the test that was broken due to this.
12:16 PM Changeset in webkit [202389] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit2

[OS X][WK2] Expand sandbox for new mach endpoints
https://bugs.webkit.org/show_bug.cgi?id=159040
<rdar://problem/25238336>

Reviewed by Alexey Proskuryakov.

Grant the WebContent and Networking processes the mach lookup capability for
various Security-related mach endpoints..

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
12:12 PM Changeset in webkit [202388] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.38-branch/Source

Versioning.

12:11 PM Changeset in webkit [202387] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.38-branch/Source

Versioning.

12:07 PM Changeset in webkit [202386] by bshafiei@apple.com
  • 1 copy in branches/safari-602.1.38-branch

New Branch.

12:07 PM Changeset in webkit [202385] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.38

New tag.

11:52 AM Changeset in webkit [202384] by Joseph Pecoraro
  • 12 edits in trunk/Source

Web Inspector: first heap snapshot taken when a page is reloaded happens before the reload navigation
https://bugs.webkit.org/show_bug.cgi?id=158995
<rdar://problem/26923778>

Reviewed by Brian Burg.

Source/WebCore:

When the "Heap" instrument is included in the Timeline list
of instruments, defer starting it in an auto-capture scenario
until after the page does its first navigation.

AutoCapture on the backend happens when it is enabled at
the main resource starts loading. In that case it proceeds
through the following phases:

No Auto Capture:

None

Auto Capture:

BeforeLoad -> FirstNavigation -> AfterFirstNavigation

When toggling instruments for backend initiated capture
most instruments do not care and will just start/stop.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):
Inform the TimelineAgent that the main frame navigated.
Do this after informing the HeapAgent (so any potential
snapshot does not get cleared) and PageAgent (so the
frontend knows the page navigated before the agent starts).

  • inspector/InspectorTimelineAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::mainFrameStartedLoading):
(WebCore::InspectorTimelineAgent::mainFrameNavigated):
Update the auto capture phase transitions.

(WebCore::InspectorTimelineAgent::toggleHeapInstrument):
Only start the heap agent during the None phase (console.profile)
or with the first navigation (auto capture page navigation).

Source/WebInspectorUI:

Let instruments decide to do work or not based on programmatic
(backend initiated) starts and stop.

Programmatic start can happen due to Auto Capture or console.profile.
Programmatic stop can happen due to console.profileEnd.

For example, this allows the frontend to avoid sending agents start/stop
messages when the backend would have already started/stopped the agents.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.startCapturing):
(WebInspector.TimelineManager.prototype.capturingStopped):
(WebInspector.TimelineManager.prototype.autoCaptureStarted):
(WebInspector.TimelineManager.prototype.programmaticCaptureStarted):
Call Recording.start/stop with a programmatic flag so the frontend
instruments can perform a more informed start/stop.

  • UserInterface/Models/TimelineRecording.js:

(WebInspector.TimelineRecording.prototype.start):
(WebInspector.TimelineRecording.prototype.stop):
Let the instruments decide to do work based on the start/stop
being initiated by the backend or not.

  • UserInterface/Models/HeapAllocationsInstrument.js:

(WebInspector.HeapAllocationsInstrument.prototype.startInstrumentation):
(WebInspector.HeapAllocationsInstrument.prototype.stopInstrumentation):

  • UserInterface/Models/Instrument.js:

(WebInspector.Instrument.startLegacyTimelineAgent):
(WebInspector.Instrument.prototype.startInstrumentation):
(WebInspector.Instrument.prototype.stopInstrumentation):
(WebInspector.Instrument):

  • UserInterface/Models/MemoryInstrument.js:

(WebInspector.MemoryInstrument.prototype.startInstrumentation):
(WebInspector.MemoryInstrument.prototype.stopInstrumentation):
(WebInspector.MemoryInstrument):

  • UserInterface/Models/NetworkInstrument.js:
  • UserInterface/Models/ScriptInstrument.js:

(WebInspector.ScriptInstrument.prototype.startInstrumentation):
(WebInspector.ScriptInstrument.prototype.stopInstrumentation):
(WebInspector.ScriptInstrument):
Avoid sending start/stop tracking messages when programmatic.
This still allows the instruments to do their own frontend tracking,
such as the Heap agent triggering periodic snapshots.

11:52 AM Changeset in webkit [202383] by Joseph Pecoraro
  • 24 edits
    3 copies in trunk/Source

Web Inspector: Snapshots should be cleared at some point
https://bugs.webkit.org/show_bug.cgi?id=157907
<rdar://problem/26373610>

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • heap/HeapSnapshotBuilder.h:
  • heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::resetNextAvailableObjectIdentifier):
Provide a way to reset the object identifier counter.

  • inspector/agents/InspectorHeapAgent.h:
  • inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::clearHeapSnapshots):
Make clearHeapSnapshots protected, so it can be called from a
a PageHeapAgent on page navigations.

Source/WebCore:

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:

New specialized agent.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
Construct a specialized HeapAgent.

  • inspector/PageHeapAgent.h:
  • inspector/PageHeapAgent.cpp:

(WebCore::PageHeapAgent::PageHeapAgent):
(WebCore::PageHeapAgent::enable):
(WebCore::PageHeapAgent::disable):
(WebCore::PageHeapAgent::mainFrameNavigated):
Clear backend snapshots on page navigations.
Set the PageHeapAgent instrumenting agent on enable/disable.

  • inspector/InstrumentingAgents.cpp:

(WebCore::InstrumentingAgents::reset):

  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::pageHeapAgent):
(WebCore::InstrumentingAgents::setPageHeapAgent):
Active PageHeapAgent.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):
Inform the PageHeapAgent when the mainframe navigates.

Source/WebInspectorUI:

Invalidate HeapSnapshotProxy objects when the page navigates.
This allows us to clear our frontend data for the snapshots.
When a snapshot is invalidated, it is disabled in the UI.
This means you cannot select the snapshot or see content
views for the snapshot. If you are in a snapshot when it is
invalidated, you are taken out to the snapshot list.

  • UserInterface/Main.html:

New files.

  • UserInterface/Proxies/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy):
(WebInspector.HeapSnapshotProxy.invalidateSnapshotProxies):
(WebInspector.HeapSnapshotProxy.prototype.get invalid):
(WebInspector.HeapSnapshotProxy.prototype._invalidate):
Keep track of valid snapshots, and provide a static method to invalidate them.

(WebInspector.HeapSnapshotProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotProxy.prototype.allocationBucketCounts):
(WebInspector.HeapSnapshotProxy.prototype.instancesWithClassName):
(WebInspector.HeapSnapshotProxy.prototype.update):
(WebInspector.HeapSnapshotProxy.prototype.nodeWithIdentifier):
UI should only act on valid snapshots.

  • UserInterface/Proxies/HeapSnapshotDiffProxy.js:

(WebInspector.HeapSnapshotDiffProxy.prototype.get invalid):
(WebInspector.HeapSnapshotDiffProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotDiffProxy.prototype.allocationBucketCounts):
(WebInspector.HeapSnapshotDiffProxy.prototype.instancesWithClassName):
(WebInspector.HeapSnapshotDiffProxy.prototype.update):
(WebInspector.HeapSnapshotDiffProxy.prototype.nodeWithIdentifier):
UI should only act on valid snapshots.

  • UserInterface/Proxies/HeapSnapshotWorkerProxy.js:

(WebInspector.HeapSnapshotWorkerProxy.prototype._mainResourceDidChange):
Invalidate and discard snapshots when the main frame navigates.

(WebInspector.HeapSnapshotWorkerProxy.prototype._handleMessage):
(WebInspector.HeapSnapshotWorkerProxy):

  • UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js:

(HeapSnapshotWorker.prototype.clearSnapshots):
(HeapSnapshotWorker.prototype._handleMessage):
(HeapSnapshotWorker):
A message may come in for a snapshot before it has been cleared.
If that is the case, the object may not exist. Return an error so
that the callback can be deleted on the calling side.

  • UserInterface/Views/HeapAllocationsTimelineDataGridNodePathComponent.js:

(WebInspector.HeapAllocationsTimelineDataGridNodePathComponent.prototype.get previousSibling):
(WebInspector.HeapAllocationsTimelineDataGridNodePathComponent.prototype.get nextSibling):
(WebInspector.HeapAllocationsTimelineDataGridNodePathComponent):
Don't show invalid snapshots in page component picker.

  • UserInterface/Views/HeapAllocationsTimelineOverviewGraph.css:

(.timeline-overview-graph.heap-allocations > img.snapshot.invalid):

  • UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:

(WebInspector.HeapAllocationsTimelineDataGridNode):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCells):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype._heapSnapshotInvalidated):
Give invalid snapshots an invalidated appearance in the snapshot list.

  • UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:

(WebInspector.HeapAllocationsTimelineOverviewGraph.prototype.layout):

  • UserInterface/Views/HeapAllocationsTimelineView.css:

(.timeline-view.heap-allocations > .data-grid tr.invalid):
(.timeline-view.heap-allocations > .data-grid:not(:focus, .force-focus) tr.selected.invalid):
Give invalid snapshots an invalidated appearance in the overview graph.

  • UserInterface/Views/HeapAllocationsTimelineView.js:

(WebInspector.HeapAllocationsTimelineView):
(WebInspector.HeapAllocationsTimelineView.prototype.get selectionPathComponents):
(WebInspector.HeapAllocationsTimelineView.prototype.closed):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotCollectionEvent.updateHeapSnapshotForEvent):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotCollectionEvent):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotInvalidated):
(WebInspector.HeapAllocationsTimelineView.prototype._updateCompareHeapSnapshotButton):
(WebInspector.HeapAllocationsTimelineView.prototype._dataGridNodeSelected):
Handle interactions when snapshots in the list are invalidated.

11:43 AM Changeset in webkit [202382] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSSComputedStyleDeclaration::length should recalculate styles if needed to provide the correct value
https://bugs.webkit.org/show_bug.cgi?id=159053
<rdar://problem/26638119>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-23
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/variables/custom-property-computed-style-length-update.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::length):

LayoutTests:

  • fast/css/variables/custom-property-computed-style-length-update-expected.txt: Added.
  • fast/css/variables/custom-property-computed-style-length-update.html: Added.
9:56 AM Changeset in webkit [202381] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r201194.
https://bugs.webkit.org/show_bug.cgi?id=159059

Not needed for iOS (Requested by bfulgham on #webkit).

Reverted changeset:

"[OS X][WK2] Expand sandbox for new mach endpoints"
https://bugs.webkit.org/show_bug.cgi?id=157919
http://trac.webkit.org/changeset/201194

9:35 AM Changeset in webkit [202380] by wilander@apple.com
  • 9 edits in trunk/Source

Source/WebCore:
Enable window.open() for existing versions of Secret Society
https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>

Reviewed by Andy Estes.

The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.

No new tests. Tested manually in the app.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::allowPopUp):

Now checks with Settings whether it should allow a popup even though it is
not processing a user gesture.

  • page/Settings.in:

Added setting allowWindowOpenWithoutUserGesture.

  • platform/RuntimeApplicationChecks.h:
  • platform/RuntimeApplicationChecks.mm:

(WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):

Added.

Source/WebKit/mac:
Enable window.open() for existing versions of Secret Society app
https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>

Reviewed by Andy Estes.

The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.

  • WebView/WebView.mm:

(shouldAllowWindowOpenWithoutUserGesture):

Added.

(shouldConvertInvalidURLsToBlank):

Changed hex number to constant DYLD_IOS_VERSION_10_0.

Source/WTF:
Enable window.open() for existing versions of Secret Society
https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>

Reviewed by Andy Estes.

The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.

  • wtf/spi/darwin/dyldSPI.h:

Added DYLD_IOS_VERSION_10_0.

9:03 AM Changeset in webkit [202379] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Only call sqlite3_initialize() when a SQLite database is actually being opened
https://bugs.webkit.org/show_bug.cgi?id=159033

Reviewed by Brady Eidson.

Only call sqlite3_initialize() when a SQLite database is actually being opened
instead of doing it unconditionally. sqlite3_initialize() was previously called
in the SQLiteDatabase constructor which gets called on WebContent process
initialization because a DatabaseTracker is constructed on initialization and
DatabaseTracker has a SQLiteDatabase data member.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::initializeSQLiteIfNecessary):
(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::SQLiteDatabase): Deleted.

  • platform/sql/SQLiteDatabase.h:
8:10 AM Changeset in webkit [202378] by adam.bergkvist@ericsson.com
  • 2 edits in trunk/Source/WebCore

WebRTC: Align 'update ICE connection/gathering state' steps with the WebRTC 1.0 specification
https://bugs.webkit.org/show_bug.cgi?id=159054

Reviewed by Eric Carlson.

Add checks for same state and closed RTCPeerConnection in the 'update ICE connection state'
and 'update ICE gathering state' routines as described in [1].

[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#update-ice-gathering-state

No change in current behavior.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):

8:05 AM Changeset in webkit [202377] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Tools

[EFL] Bump gstreamer version from 1.6.3 to 1.8.0
https://bugs.webkit.org/show_bug.cgi?id=159050

Patch by Gyuyoung Kim <gyuyoung.kim@samsung.com> on 2016-06-23
Reviewed by Antonio Gomes.

To be sync with GTK port, this patch bumps gstreamer version for EFL port.

  • efl/jhbuild.modules:
  • efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
  • efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
6:52 AM Changeset in webkit [202376] by adam.bergkvist@ericsson.com
  • 12 edits
    2 adds in trunk

WebRTC: Add support for RTCPeerConnection legacy MediaStream-based API
https://bugs.webkit.org/show_bug.cgi?id=158940

Reviewed by Eric Carlson.

Source/WebCore:

Implement the legacy MediaStream-based RTCPeerConnection API as JS built-ins. The
getRemoteStreams() function and the 'addstream' event are partly implemented with native
code.

Test: fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::setRemoteDescriptionTask):
(WebCore::MediaEndpointPeerConnection::getRemoteStreams):
The getRemoteStreams() function and the 'addstream' event is backed up by native code.

  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/PeerConnectionBackend.h:
  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCPeerConnection.js:

(initializeRTCPeerConnection):
(getLocalStreams):
(getRemoteStreams):
(getStreamById):
(addStream):
(removeStream):
Legacy API implemented as JS built-ins.

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

  • bindings/js/WebCoreBuiltinNames.h:

LayoutTests:

Add test for RTCPeerConnection legacy MediaStream-based API.

  • fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html: Added.
  • platform/mac/TestExpectations:

Skip test for mac port (not building with WEB_RTC yet)

3:08 AM Changeset in webkit [202375] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening.

Update test expectations for passing accessibility tests after r202149,
and fix style issues in test expectations file.

  • platform/win/TestExpectations:
3:08 AM Changeset in webkit [202374] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.13.2

WebKitGTK+ 2.13.2

2:51 AM Changeset in webkit [202373] by Konstantin Tokarev
  • 3 edits in trunk/Tools

[jhbuild] Added libxslt module.
https://bugs.webkit.org/show_bug.cgi?id=159034

Reviewed by Michael Catanzaro.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
2:16 AM Changeset in webkit [202372] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.13.2 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.13.2.
1:50 AM Changeset in webkit [202371] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix the build with CSS Shapes disabled.

  • css/StyleBuilderConverter.h:
12:23 AM Changeset in webkit [202370] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

[Soup] Clean up SocketStreamHandle soup implementation
https://bugs.webkit.org/show_bug.cgi?id=159024

Reviewed by Žan Doberšek.

Stop using a global HashMap to "acivate"/"deactivate" handles, and just take a reference of the handle and
pass the ownership to the callbacks, using a GCancellable to cancel all async operations.

  • platform/network/soup/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::create):
(WebCore::SocketStreamHandle::id): Deleted.

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::connectedCallback):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::readReadyCallback):
(WebCore::SocketStreamHandle::didFail):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::beginWaitingForSocketWritability):
(WebCore::SocketStreamHandle::writeReadyCallback):
(WebCore::getHandleFromId): Deleted.
(WebCore::deactivateHandle): Deleted.
(WebCore::activateHandle): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::connectedCallback): Deleted.
(WebCore::readReadyCallback): Deleted.
(WebCore::writeReadyCallback): Deleted.

Note: See TracTimeline for information about the timeline view.