Timeline



Mar 15, 2017:

11:48 PM Changeset in webkit [214032] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix CMake build.

  • PlatformMac.cmake:
11:29 PM Changeset in webkit [214031] by dewei_zhu@apple.com
  • 3 edits in trunk/Websites/perf.webkit.org

Fix unit test and bug fix for 'pull-os-versions.js' script.
https://bugs.webkit.org/show_bug.cgi?id=169701

Reviewed by Ryosuke Niwa.

Fix unit tests warnings on node-6.10.0.
Fix 'pull-os-versions.js' does not fetch new builds and report.

  • server-tests/tools-os-build-fetcher-tests.js:

(then):
(beforeEach):
(afterEach):

  • tools/pull-os-versions.js:

(syncLoop):

11:10 PM Changeset in webkit [214030] by jonlee@apple.com
  • 23 edits
    6 adds in trunk/Source/WebCore

Flatten RTC enum naming
https://bugs.webkit.org/show_bug.cgi?id=169664

Reviewed by Youenn Fablet.

Use consistent names of RTC enums throughout WebCore. This means surfacing
ICE enums out of PeerConnectionState. Keep the old names around for other
ports.

Add RTCIceConnectionState, RTCIceGatheringState, and RTCSignalingState enums.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/mediastream/RTCIceConnectionState.h: Added. The enum is defined in

PeerConnectionStates.h, so just include that file.

  • Modules/mediastream/RTCIceConnectionState.idl: Added.
  • Modules/mediastream/RTCIceGatheringState.h: Added.
  • Modules/mediastream/RTCIceGatheringState.idl: Added.
  • Modules/mediastream/RTCSignalingState.h: Added.
  • Modules/mediastream/RTCSignalingState.idl: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/PeerConnectionStates.h: Move the existing enums into

WebCore, but keep aliases to the old names within the PeerConnectionStates
namespace.

Refactor to use the new enum names.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp: Refactor.
  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/mediastream/PeerConnectionBackend.cpp:
  • Modules/mediastream/PeerConnectionBackend.h:
  • Modules/mediastream/RTCConfiguration.h:
  • Modules/mediastream/RTCConfiguration.idl: Add FIXMEs for bringing this up

to spec.

  • Modules/mediastream/RTCIceTransport.h:
  • Modules/mediastream/RTCPeerConnection.cpp: Refactor the three functions

below to using the enum instead of returning strings. This allows remove of
the internal* versions of these functions.
(WebCore::RTCPeerConnection::signalingState): Deleted.
(WebCore::RTCPeerConnection::iceGatheringState): Deleted.
(WebCore::RTCPeerConnection::iceConnectionState): Deleted.

  • Modules/mediastream/RTCPeerConnection.h: Replace internalSignalingState,

internalIceGatheringState, and internalIceConnectionState.

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
  • platform/mediastream/MediaEndpoint.h:
  • platform/mediastream/MediaEndpointConfiguration.cpp:
  • platform/mediastream/MediaEndpointConfiguration.h:
  • platform/mock/MockMediaEndpoint.cpp:
  • platform/mock/MockMediaEndpoint.h:
  • platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:

(WebCore::MediaEndpointOwr::processIceTransportStateChange):

10:12 PM Changeset in webkit [214029] by Yusuke Suzuki
  • 16 edits
    2 adds in trunk

[JSC] Default parameter part should be retrieved by op_get_argument opcode instead of changing arity
https://bugs.webkit.org/show_bug.cgi?id=164582

Reviewed by Saam Barati.

JSTests:

  • stress/function-with-defaults-inlining.js: Added.

(shouldBe):
(ok):
(a):

  • stress/function-with-defaults-non-inlining.js: Added.

(shouldBe):
(ok):
(a):

Source/JavaScriptCore:

Previously we implement the default parameters as follows.

  1. We count the default parameters as the usual parameters.
  2. We just get the argument register.
  3. Check it with op_is_undefined.
  4. And fill the binding with either the argument register or default value.

The above is simple. However, it has the side effect that it always increase the arity of the function.
While function.length does not increase, internally, the number of parameters of CodeBlock increases.
This effectively prevent our DFG / FTL to perform inlining: currently we only allows DFG to inline
the function with the arity less than or equal the number of passing arguments. It is OK. But when using
default parameters, we frequently do not pass the argument for the parameter with the default value.
Thus, in our current implementation, we frequently need to fixup the arity. And we frequently fail
to inline the function.

This patch fixes the above problem by not increasing the arity of the function. When we encounter the
parameter with the default value, we use op_argument to get the argument instead of using the argument
registers.

This improves six-speed defaults.es6 performance by 4.45x.

defaults.es6 968.4126+-101.2350 217.6602+-14.8831 definitely 4.4492x faster

  • bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

  • bytecode/UnlinkedFunctionExecutable.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack):
(JSC::BytecodeGenerator::initializeNextParameter):
(JSC::BytecodeGenerator::initializeParameters):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionNode::emitBytecode):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::inliningCost):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionMetadata):

  • parser/Nodes.cpp:

(JSC::FunctionMetadataNode::FunctionMetadataNode):

  • parser/Nodes.h:

(JSC::FunctionParameters::size):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::append):
(JSC::FunctionParameters::isSimpleParameterList):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::isArrowFunctionParameters):
(JSC::Parser<LexerType>::parseGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::parseAsyncFunctionSourceElements):
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::Parser<LexerType>::parseFunctionBody):
(JSC::Parser<LexerType>::parseFunctionParameters):
(JSC::Parser<LexerType>::parseFunctionInfo):

  • parser/Parser.h:
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFunctionMetadata):

  • runtime/FunctionExecutable.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::createBuiltinFunction):
(JSC::JSFunction::reifyLength):

9:49 PM Changeset in webkit [214028] by Yusuke Suzuki
  • 10 edits
    2 adds in trunk

[DFG] ToString operation should have fixup for primitives to say this node does not have side effects
https://bugs.webkit.org/show_bug.cgi?id=169544

Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/template-string-array.js: Added.

(test):

  • stress/to-string-non-cell-use.js: Added.

(shouldBe):
(shouldThrow):

Source/JavaScriptCore:

Our DFG ToString only considers well about String operands. While ToString(non cell operand) does not have
any side effect, it is not modeled well in DFG.

This patch introduces a fixup for ToString with NonCellUse edge. If this edge is set, ToString does not
clobber things (like ToLowerCase, producing String). And ToString(NonCellUse) allows us to perform CSE!

Our microbenchmark shows 32.9% improvement due to dropped GetButterfly and CSE for ToString().

baseline patched

template-string-array 12.6284+-0.2766 9.4998+-0.2295 definitely 1.3293x faster

And SixSpeed template_string.es6 shows 16.68x performance improvement due to LICM onto this non-side-effectful ToString().

baseline patched

template_string.es6 3229.7343+-40.5705 193.6077+-36.3349 definitely 16.6818x faster

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupToStringOrCallStringConstructor):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToStringOrCallStringConstructorOnCell):
(JSC::DFG::SpeculativeJIT::speculateNotCell):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructor):
(JSC::FTL::DFG::LowerDFGToB3::lowNotCell):
(JSC::FTL::DFG::LowerDFGToB3::speculateNotCell):

9:10 PM Changeset in webkit [214027] by jer.noble@apple.com
  • 17 edits
    1 copy
    5 adds
    1 delete in trunk/Source

Optionally capture audio in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=169609

Reviewed by Alex Christensen.

Source/WebCore:

Export some previously un-exported symbols from WebCore for use in WebKit2.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/WebAudioBufferList.h:
  • platform/mediastream/RealtimeMediaSource.h:

Source/WebKit2:

Add a new class pair, UserMediaCaptureManager/Proxy, to allow a RealtimeMediaSource
requested in a WebProcess to be created in the UIProcess and push its audio data across the
process boundary to its clients in the WebProcess. Because these classes are clients of the
RealtimeMediaSourceCenter::singleton(), they must be a singleton in the WebProcess as well,
so they are attached to the WebProcess class in the web process and to WebProcessProxy in
the UIProcess.

  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp: Added.

(WebKit::UserMediaCaptureManagerProxy::SourceProxy::SourceProxy):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::~SourceProxy):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::source):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::description):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::numberOfFrames):
(WebKit::UserMediaCaptureManagerProxy::UserMediaCaptureManagerProxy):
(WebKit::UserMediaCaptureManagerProxy::~UserMediaCaptureManagerProxy):
(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManagerProxy::startProducingData):
(WebKit::UserMediaCaptureManagerProxy::stopProducingData):

  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:

(WebKit::UserMediaCaptureManagerProxy::process):

  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in: Added.
  • WebProcess/cocoa/UserMediaCaptureManager.cpp: Added.

(WebKit::nextSessionID):
(WebKit::UserMediaCaptureManager::Source::Source):
(WebKit::UserMediaCaptureManager::Source::~Source):
(WebKit::UserMediaCaptureManager::Source::setCapabilities):
(WebKit::UserMediaCaptureManager::Source::setSettings):
(WebKit::UserMediaCaptureManager::Source::description):
(WebKit::UserMediaCaptureManager::Source::setStorage):
(WebKit::UserMediaCaptureManager::Source::setRingBufferFrameBounds):
(WebKit::UserMediaCaptureManager::Source::audioSamplesAvailable):
(WebKit::UserMediaCaptureManager::UserMediaCaptureManager):
(WebKit::UserMediaCaptureManager::~UserMediaCaptureManager):
(WebKit::UserMediaCaptureManager::supplementName):
(WebKit::UserMediaCaptureManager::initialize):
(WebKit::UserMediaCaptureManager::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManager::sourceStopped):
(WebKit::UserMediaCaptureManager::sourceMutedChanged):
(WebKit::UserMediaCaptureManager::sourceEnabledChanged):
(WebKit::UserMediaCaptureManager::sourceSettingsChanged):
(WebKit::UserMediaCaptureManager::storageChanged):
(WebKit::UserMediaCaptureManager::ringBufferFrameBoundsChanged):
(WebKit::UserMediaCaptureManager::audioSamplesAvailable):
(WebKit::UserMediaCaptureManager::startProducingData):
(WebKit::UserMediaCaptureManager::stopProducingData):

  • WebProcess/cocoa/UserMediaCaptureManager.h: Added.
  • WebProcess/cocoa/UserMediaCaptureManager.messages.in: Added.

Initialize UserMediaCaptureManager/Proxy:

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

WebUserMediaClientMac is no longer necessary now that the UserMediaCaptureManager overrides
the factories:

  • WebProcess/WebCoreSupport/WebUserMediaClient.cpp:

(WebKit::WebUserMediaClient::WebUserMediaClient):
(WebKit::WebUserMediaClient::initializeFactories): Deleted.

Add a new preference and WebProcessCreationParameters member to control whether
capturing is done in the UIProcess:

  • Shared/WebPreferencesDefinitions.h:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Add new files to the project:

  • DerivedSources.make:
  • WebKit2.xcodeproj/project.pbxproj:
8:41 PM Changeset in webkit [214026] by Ryan Haddad
  • 2 edits in trunk/Source/JavaScriptCore

Revert part of r213978 to see if it resolves LayoutTest crashes.
https://bugs.webkit.org/show_bug.cgi?id=169729

Reviewed by Alexey Proskuryakov.

8:15 PM Changeset in webkit [214025] by clopez@igalia.com
  • 3 edits in trunk/Source/WTF

[CMake][JSCOnly] Fix build with GLib event loop
https://bugs.webkit.org/show_bug.cgi?id=169730

Reviewed by Michael Catanzaro.

  • wtf/MainThread.cpp:
  • wtf/PlatformJSCOnly.cmake: WorkQueueGLib was removed in r199713.
7:48 PM Changeset in webkit [214024] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Selecting text in the console does not do what I expect
https://bugs.webkit.org/show_bug.cgi?id=169570

Reviewed by Matt Baker.

  • UserInterface/Views/ConsoleMessageView.css:

(.console-message-text > span > :matches(.console-message-enclosed, .console-message-preview, .console-message-preview-divider)):
(.console-message .console-message-location):
(.console-message-location.call-frame):
Prevent text selection on anything other than the message text. The other information that
is not selectable can still be copied by selecting the message itself and copying.

6:56 PM Changeset in webkit [214023] by zalan@apple.com
  • 5 edits
    2 adds in trunk

Do not reparent floating object until after intruding/overhanging dependency is cleared.
https://bugs.webkit.org/show_bug.cgi?id=169711
<rdar://problem/30959743>

Reviewed by Simon Fraser.

Source/WebCore:

This patch ensures that we cleanup the m_floatingObjects for siblings before reparenting the fresh float.

Test: fast/block/float/inline-becomes-float-and-moves-around.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::styleDidChange):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::styleDidChange):

  • rendering/RenderElement.h:

(WebCore::RenderElement::noLongerAffectsParentBlock):

LayoutTests:

  • fast/block/float/inline-becomes-float-and-moves-around-expected.txt: Added.
  • fast/block/float/inline-becomes-float-and-moves-around.html: Added.
6:01 PM Changeset in webkit [214022] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[jsc][mips] Fix compilation error introduced in r213652
https://bugs.webkit.org/show_bug.cgi?id=169723

Patch by Guillaume Emont <guijemont@igalia.com> on 2017-03-15
Reviewed by Mark Lam.

The new replaceWithBkpt() contains a lapsus in it
(s/code/instructionStart) and won't compile.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::replaceWithBkpt):

6:01 PM Changeset in webkit [214021] by nvasilyev@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: WebSockets: Update Arrow Up icon to fit in with the rest of our iconography
https://bugs.webkit.org/show_bug.cgi?id=169696
<rdar://problem/31073748>

Reviewed by Matt Baker.

  • UserInterface/Images/ArrowUp.svg:
  • UserInterface/Images/gtk/ArrowUp.svg:
4:40 PM Changeset in webkit [214020] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Switch back to ISO 4217 for Intl CurrencyDigits data
https://bugs.webkit.org/show_bug.cgi?id=169182

Previously, a patch switched Intl.NumberFormat to use CLDR data through
ICU to get the default number of decimal digits for a currency.
However, that change actually violated the ECMA 402 specification,
which references ISO 4217 as the data source. This patch reverts to
an in-line implementation of that data.

Patch by Daniel Ehrenberg <littledan@chromium.org> on 2017-03-15
Reviewed by Saam Barati.

  • runtime/IntlNumberFormat.cpp:

(JSC::computeCurrencySortKey):
(JSC::extractCurrencySortKey):
(JSC::computeCurrencyDigits):

4:29 PM Changeset in webkit [214019] by timothy_horton@apple.com
  • 4 edits
    1 add in trunk

Null deref under callAfterNextPresentationUpdate
https://bugs.webkit.org/show_bug.cgi?id=169710
<rdar://problem/30987863>

Reviewed by Simon Fraser.

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::callAfterNextPresentationUpdate):
Call the callback with an error if we don't have a web process or drawing area.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm: Added.

(TEST):

4:17 PM Changeset in webkit [214018] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

WebAssembly: When we GC to try to get a fast memory, we should call collectAllGarbage(), not collectSync()
https://bugs.webkit.org/show_bug.cgi?id=169704

Reviewed by Mark Lam.

We weren't always sweeping the memory needed to free
the WasmMemory we wanted to use. collectAllGarbage()
will do this if the JS objects wrapping WasmMemory
are dead.

This patch also moves the increment of the allocatedFastMemories
integer to be thread safe.

  • wasm/WasmMemory.cpp:

(JSC::Wasm::tryGetFastMemory):

3:56 PM Changeset in webkit [214017] by dino@apple.com
  • 10 edits
    1 add in trunk/Source/WebCore

Make a base class for WebGL and WebGPU contexts
https://bugs.webkit.org/show_bug.cgi?id=169651
<rdar://problem/31053489>

Reviewed by Simon Fraser.

Add a new pure virtual base class, GPUBasedCanvasRenderingContext, that
will be used by WebGL and WebGPU rendering contexts. This allows us
to avoid some code duplication, since many places treat the two
as the same.

Also rename is3d() -> isWebGL() and isGPU() -> isWebGPU().

  • WebCore.xcodeproj/project.pbxproj: New file.
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContextWebGL):
(WebCore::HTMLCanvasElement::getContextWebGPU):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::isGPUBased):
(WebCore::HTMLCanvasElement::getImageData):
(WebCore::HTMLCanvasElement::isGPU): Deleted.
(WebCore::HTMLCanvasElement::is3D): Deleted.

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext.h:

(WebCore::CanvasRenderingContext::isWebGL):
(WebCore::CanvasRenderingContext::isWebGPU):
(WebCore::CanvasRenderingContext::isGPUBased):
(WebCore::CanvasRenderingContext::is3d): Deleted.
(WebCore::CanvasRenderingContext::isGPU): Deleted.

  • html/canvas/GPUBasedCanvasRenderingContext.h: Added.

(WebCore::GPUBasedCanvasRenderingContext::GPUBasedCanvasRenderingContext):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):

  • html/canvas/WebGLRenderingContextBase.h:
  • html/canvas/WebGPURenderingContext.cpp:

(WebCore::WebGPURenderingContext::WebGPURenderingContext):

  • html/canvas/WebGPURenderingContext.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::canvasCompositingStrategy):

3:49 PM Changeset in webkit [214016] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix exception scope verification failures in jsc.cpp.
https://bugs.webkit.org/show_bug.cgi?id=164968

Reviewed by Saam Barati.

  • jsc.cpp:

(WTF::CustomGetter::customGetter):

(GlobalObject::moduleLoaderResolve):
(GlobalObject::moduleLoaderFetch):

  • The only way modules would throw an exception is if we encounter an OutOfMemory error. This should be extremely rare. At this point, I don't think it's worth doing the dance to propagate the exception when this happens. Instead, we'll simply do a RELEASE_ASSERT that we don't see any exceptions here.

(functionRun):
(functionRunString):
(functionLoadModule):
(functionCheckModuleSyntax):
(box):
(dumpException):
(runWithScripts):

3:46 PM Changeset in webkit [214015] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-604.1.30.4.5

Tag Safari-604.1.30.4.5.

3:44 PM Changeset in webkit [214014] by dbates@webkit.org
  • 6 edits in trunk/Source/WebCore

Iteratively dispatch DOM events after restoring a cached page
https://bugs.webkit.org/show_bug.cgi?id=169703
<rdar://problem/31075903>

Reviewed by Brady Eidson.

Make dispatching of DOM events when restoring a page from the page cache symmetric with
dispatching of events when saving a page to the page cache.

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Move code to dispatch events from here to FrameLoader::didRestoreFromCachedPage().

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad): Ensure that no DOM events are dispatched during
restoration of a cached page. Call didRestoreFromCachedPage() after restoring the page to
dispatch DOM events on the restored frames.
(WebCore::FrameLoader::willRestoreFromCachedPage): Renamed; formerly named prepareForCachedPageRestore().
(WebCore::FrameLoader::didRestoreFromCachedPage): Added.
(WebCore::FrameLoader::prepareForCachedPageRestore): Renamed to willRestoreFromCachedPage().

  • loader/FrameLoader.h:
  • page/FrameTree.cpp:

(WebCore::FrameTree::traverseNextInPostOrderWithWrap): Returns the next Frame* in a post-order
traversal of the frame tree optionally wrapping around to the deepest first child in the tree.
(WebCore::FrameTree::deepFirstChild): Added.

  • page/FrameTree.h:
3:43 PM Changeset in webkit [214013] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603.1.30.4-branch/Source/WebCore

Merge r213847. rdar://problem/30983702

3:43 PM Changeset in webkit [214012] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603.1.30.4-branch/Source/WebKit/win

Merge r213737. rdar://problem/30983702

3:29 PM Changeset in webkit [214011] by webkit@devinrousso.com
  • 3 edits
    4 adds in trunk/Source/WebInspectorUI

Web Inspector: Add icons for SVG Image cluster path components
https://bugs.webkit.org/show_bug.cgi?id=169687

Reviewed by Joseph Pecoraro.

  • UserInterface/Images/Image.svg: Added.
  • UserInterface/Images/Source.svg: Added.
  • UserInterface/Images/gtk/Image.svg: Added.
  • UserInterface/Images/gtk/Source.svg: Added.
  • UserInterface/Views/PathComponentIcons.css:

(.image-icon .icon):
(.source-icon .icon):

  • UserInterface/Views/SVGImageResourceClusterContentView.js:

(WebInspector.SVGImageResourceClusterContentView):

3:09 PM Changeset in webkit [214010] by hyatt@apple.com
  • 10 edits
    2 adds in trunk

Positioned SVG not sized correctly
https://bugs.webkit.org/show_bug.cgi?id=169693
<rdar://problem/30996893>

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: svg/in-html/rect-positioned.html

Change computeReplacedLogicalHeight to take an estimatedUsedWidth. This
value is used instead of the available logical width to resolve replaced
elements without intrinsic sizes but with aspect ratios set.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeight):

  • rendering/RenderBox.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeConstrainedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

  • rendering/RenderReplaced.h:
  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::computeReplacedLogicalHeight): Deleted.

  • rendering/RenderVideo.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):

  • rendering/svg/RenderSVGRoot.h:

LayoutTests:

  • svg/in-html/rect-positioned-expected.html: Added.
  • svg/in-html/rect-positioned.html: Added.
3:04 PM Changeset in webkit [214009] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: flip Memory timelines
https://bugs.webkit.org/show_bug.cgi?id=169694

Reviewed by Brian Burg.

  • UserInterface/Views/MemoryCategoryView.css:

(body[dir=rtl] .memory-category-view > .graph):

2:59 PM Changeset in webkit [214008] by rniwa@webkit.org
  • 9 edits
    1 add in trunk/Websites/perf.webkit.org

In-browser and node.js implementations of RemoteAPI should share some code
https://bugs.webkit.org/show_bug.cgi?id=169695

Rubber-stamped by Antti Koivisto.

Extracted CommonRemoteAPI out of RemoteAPI implementations for node.js and browser.

  • public/shared/common-remote.js: Added.

(CommonRemoteAPI): Added.
(CommonRemoteAPI.prototype.postJSON): Extracted from RemoteAPI.
(CommonRemoteAPI.prototype.postJSONWithStatus): Ditto.
(CommonRemoteAPI.prototype.getJSON): Ditto.
(CommonRemoteAPI.prototype.getJSONWithStatus): Ditto.
(CommonRemoteAPI.prototype.sendHttpRequest): Added. Needs to implemented by a subclass.
(CommonRemoteAPI.prototype._asJSON): Added.
(CommonRemoteAPI.prototype._checkStatus): Added.

  • public/v3/index.html: Include common-remote.js.
  • public/v3/privileged-api.js:

(PrivilegedAPI): Use class now that we don't include data.js.
(PrivilegedAPI.sendRequest): Modernized the code.
(PrivilegedAPI.requestCSRFToken): Ditto.

  • public/v3/remote.js:

(BrowserRemoteAPI): Renamed from RemoteAPI. window.RemoteAPI is now an instance of this class.
(BrowserRemoteAPI.prototype.sendHttpRequest): Moved from RemoteAPI.sendHttpRequest.
(BrowserRemoteAPI.prototype.sendHttpRequest):

  • server-tests/privileged-api-create-analysis-task-tests.js: Updated tests since NodeJSRemoteAPI

now throws the JSON status as an error to be consistent with BrowserRemoteAPI.

  • server-tests/privileged-api-create-test-group-tests.js: Ditto.
  • server-tests/privileged-api-upate-run-status.js: Ditto.
  • tools/js/buildbot-triggerable.js:

(BuildbotTriggerable.prototype.syncOnce): Just use postJSONWithStatus instead of manually
checking the status.

  • tools/js/remote.js:

(NodeRemoteAPI): Renamed from RemoteAPI. Still exported as RemoteAPI.
(NodeRemoteAPI.prototype.constructor):
(NodeRemoteAPI.prototype.sendHttpRequest): Modernized the code.

2:47 PM Changeset in webkit [214007] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Clean up TestExpectations for some WPT LayoutTests.

Unreviewed test gardening.

2:31 PM Changeset in webkit [214006] by Chris Dumez
  • 6 edits
    1 add in trunk

Document state (e.g. form data) is lost after a tab is terminated in the background for power reasons
https://bugs.webkit.org/show_bug.cgi?id=169635
<rdar://problem/31046729>

Reviewed by Andreas Kling.

Source/WebKit2:

Document state (e.g. form data) was lost after a tab was terminated in the background for power
reasons. To address the issue, we now save the document state whenever a page is backgrounded.
This document state automatically gets restored when reloading the page after termination.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::visibilityDidChange):
(WebKit::WebPage::setActivityState):

  • WebProcess/WebPage/WebPage.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/mac/RestoreStateAfterTermination.mm: Added.

(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::didCrash):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/simple-form.html:
1:19 PM Changeset in webkit [214005] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix missing exception checks in Interpreter.cpp.
https://bugs.webkit.org/show_bug.cgi?id=164964

Reviewed by Saam Barati.

  • interpreter/Interpreter.cpp:

(JSC::eval):
(JSC::sizeOfVarargs):
(JSC::sizeFrameForVarargs):
(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::execute):

1:00 PM Changeset in webkit [214004] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

JSContext Inspector: NetworkAgent may be unavailable
https://bugs.webkit.org/show_bug.cgi?id=169691

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-03-15
Reviewed by Brian Burg.

  • UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):
Check that NetworkAgent even exists. An augmented JSContext may have Resources
without having a NetworkAgent.

12:56 PM Changeset in webkit [214003] by wenson_hsieh@apple.com
  • 2 edits in trunk/Source/WebKit2

WebContent crash due to bad variant access in WebKit: WebKit::WebPage::expandedRangeFromHandle
https://bugs.webkit.org/show_bug.cgi?id=169657
<rdar://problem/30631070>

Reviewed by Tim Horton.

In WebPageIOS.mm, the call to unionDOMRanges from WebPage::expandedRangeFromHandle invokes
Range::compareBoundaryPoints, assuming that the return value is not an exception, and then attempts to perform
integer comparison on the result. This is one speculative cause of the web content crash in the radar.

There isn't a known way to reproduce this crash.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::unionDOMRanges):

12:35 PM Changeset in webkit [214002] by nvasilyev@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r213622): Web Inspector: DataGrid headers should NOT be centered
https://bugs.webkit.org/show_bug.cgi?id=169645
<rdar://problem/31051520>

Reviewed by Matt Baker.

  • UserInterface/Views/DataGrid.css:

(.data-grid th):
(body[dir=ltr] .data-grid th):
(body[dir=rtl] .data-grid th):

12:34 PM Changeset in webkit [214001] by timothy_horton@apple.com
  • 7 edits
    3 deletes in trunk/Source/WebKit2

Un-deprecate the original PDFPlugin
https://bugs.webkit.org/show_bug.cgi?id=169655

Reviewed by Anders Carlsson.

  • Shared/mac/PDFKitImports.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PDF/DeprecatedPDFLayerControllerSPI.h: Removed.
  • WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h: Removed.
  • WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm: Removed.
  • WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
  • WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

The transition to the non-deprecated PDFPlugin never happened,
and we have a very different plan now.

12:34 PM Changeset in webkit [214000] by rniwa@webkit.org
  • 6 edits in trunk/Websites/perf.webkit.org

Fix server tests after r213998 and r213969
https://bugs.webkit.org/show_bug.cgi?id=169690

Reviewed by Antti Koivisto.

Fixed the existing server tests.

  • public/v3/models/analysis-task.js:

(AnalysisTask.prototype._updateRemoteState): Use the relative path from the root so that it works inside tests.
(AnalysisTask.prototype.associateBug): Ditto.
(AnalysisTask.prototype.dissociateBug): Ditto.
(AnalysisTask.prototype.associateCommit): Ditto.
(AnalysisTask.prototype.dissociateCommit): Ditto.
(AnalysisTask._fetchSubset): Ditto.
(AnalysisTask.fetchAll): Ditto.

  • public/v3/models/test-group.js:

(TestGroup.prototype.updateName): Ditto.
(TestGroup.prototype.updateHiddenFlag): Ditto.
(TestGroup.createAndRefetchTestGroups): Ditto.
(TestGroup.cachedFetch): Ditto.

  • server-tests/api-manifest.js: Reverted an inadvertant change in r213969.
  • tools/js/database.js:

(tableToPrefixMap): Added analysis_strategies.

  • unit-tests/analysis-task-tests.js: Updated expectations per changes to AnalysisTask.
12:15 PM Changeset in webkit [213999] by webkit@devinrousso.com
  • 4 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: SVG image content view should toggle between image and source
https://bugs.webkit.org/show_bug.cgi?id=16079

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Main.html:
  • UserInterface/Views/ResourceClusterContentView.js:

(WebInspector.ResourceClusterContentView.prototype.get responseContentView):
Show the SVG cluster content view if the MIME type matches an SVG file.

  • UserInterface/Views/SVGImageResourceClusterContentView.js: Added.

(WebInspector.SVGImageResourceClusterContentView):
(WebInspector.SVGImageResourceClusterContentView.prototype.get resource):
(WebInspector.SVGImageResourceClusterContentView.prototype.get selectionPathComponents):
(WebInspector.SVGImageResourceClusterContentView.prototype.shown):
(WebInspector.SVGImageResourceClusterContentView.prototype.closed):
(WebInspector.SVGImageResourceClusterContentView.prototype.saveToCookie):
(WebInspector.SVGImageResourceClusterContentView.prototype.restoreFromCookie):
(WebInspector.SVGImageResourceClusterContentView.prototype._pathComponentForContentView):
(WebInspector.SVGImageResourceClusterContentView.prototype._identifierForContentView):
(WebInspector.SVGImageResourceClusterContentView.prototype._showContentViewForIdentifier):
(WebInspector.SVGImageResourceClusterContentView.prototype._pathComponentSelected):

12:15 PM Changeset in webkit [213998] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk/Websites/perf.webkit.org

Add tests for privileged-api/create-analysis-task and privileged-api/create-test-group
https://bugs.webkit.org/show_bug.cgi?id=169688

Rubber-stamped by Antti Koivisto.

Added tests for privileged-api/create-analysis-task and privileged-api/create-test-group, and fixed newly found bugs.

  • public/privileged-api/create-analysis-task.php:

(main): Fixed the bug that we were not explicitly checking whether start_run and end_run were integers or not.
Also return InvalidTimeRange when start and end times are identical as that makes no sense for an analysis task.

  • public/privileged-api/create-test-group.php:

(main): Fixed a bug that we were not explicitly checking task and repetitionCount to be an integer.
(ensure_commit_sets): Fixed the bug that the number of commit sets weren't checked.

  • server-tests/privileged-api-create-analysis-task-tests.js: Added.
  • server-tests/privileged-api-create-test-group-tests.js: Added.
  • server-tests/resources/common-operations.js:

(prepareServerTest): Increase the timeout from 1s to 5s.

  • server-tests/resources/mock-data.js:

(MockData.addMockData): Use a higher database ID of 20 for a mock build_slave to avoid a conflict with auto-generated IDs.

12:07 PM Changeset in webkit [213997] by webkit@devinrousso.com
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add support for Timeline ruler selections/movement
https://bugs.webkit.org/show_bug.cgi?id=169588

Reviewed by Matt Baker.

  • UserInterface/Views/TimelineOverview.css:

(body[dir=ltr] .timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .selection-handle.right):
(body[dir=rtl] .timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .selection-handle.left):
(body[dir=ltr] .timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .shaded-area.right):
(body[dir=rtl] .timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .shaded-area.left):
(.timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .selection-handle.right): Deleted.
(.timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .shaded-area.right): Deleted.
Fixes alignment of selection handles when in Frames view.

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview.prototype._handleScrollEvent):
Support horizontal scrolling in timelines by treating the current scroll value as negative
when in RTL, flipping the scroll direction.

  • UserInterface/Views/TimelineRuler.css:

(body[dir=ltr] .timeline-ruler > .selection-handle.left):
(body[dir=rtl] .timeline-ruler > .selection-handle.left):
(body[dir=ltr] .timeline-ruler > .selection-handle.right):
(body[dir=rtl] .timeline-ruler > .selection-handle.right):
(body[dir=ltr] .timeline-ruler > .shaded-area.left):
(body[dir=rtl] .timeline-ruler > .shaded-area.left):
(body[dir=ltr] .timeline-ruler > .shaded-area.right):
(body[dir=rtl] .timeline-ruler > .shaded-area.right):
(.timeline-ruler > .selection-handle.left): Deleted.
(.timeline-ruler > .selection-handle.right): Deleted.
(.timeline-ruler > .shaded-area.left): Deleted.
(.timeline-ruler > .shaded-area.right): Deleted.
Flip the position alignment of the selection handles and shaded areas when in RTL.

  • UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype._handleMouseDown):
(WebInspector.TimelineRuler.prototype._handleMouseMove):
(WebInspector.TimelineRuler.prototype._handleMouseUp):
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseDown):
(WebInspector.TimelineRuler.prototype._handleSelectionHandleMouseMove):
Treat the current mouse position (event.pageX) as a negative value when in RTL, meaning that
the delta movement from the starting position is flipped.

11:51 AM Changeset in webkit [213996] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Modern Media Controls] Using the arrow keys to navigate in the tracks menu also scrolls the page
https://bugs.webkit.org/show_bug.cgi?id=169671
<rdar://problem/31060091>

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Eric Carlson.

Source/WebCore:

We need to call preventDefault() when handling a "keydown" event that we recognize.

Test: media/modern-media-controls/tracks-panel/tracks-panel-prevent-default-on-keydown.html

  • Modules/modern-media-controls/controls/tracks-panel.js:

(TracksPanel.prototype._handleKeydown):

LayoutTests:

Add a test that checks that preventDefault() is called on "keydown" events that we know to handle.

  • media/modern-media-controls/tracks-panel/tracks-panel-prevent-default-on-keydown-expected.txt: Added.
  • media/modern-media-controls/tracks-panel/tracks-panel-prevent-default-on-keydown.html: Added.
11:26 AM Changeset in webkit [213995] by jbedard@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

Remove TestExpectations.orig after r213882

Unreviewed, removing file committed by mistake.

11:21 AM Changeset in webkit [213994] by commit-queue@webkit.org
  • 6 edits in trunk

[Modern Media Controls] Tracks menu overlaps controls bar in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=169670
<rdar://problem/31060086>
Source/WebCore:

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Eric Carlson.

It used to be that the top of the tracks button was the same as the top of the controls
bar, but that changed when we fixed https://bugs.webkit.org/show_bug.cgi?id=169412. We
now use the top of the controls bar to computed the y-position for the tracks panel.

We are not adding a new test, instead we're unflaking a test that started failing
reliably once we fixed https://bugs.webkit.org/show_bug.cgi?id=169412.

  • Modules/modern-media-controls/controls/macos-media-controls.js:

(MacOSMediaControls.prototype.showTracksPanel):

LayoutTests:

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Eric Carlson.

Unflake a test that checks the tracks panel position in fullscreen.

  • media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen-expected.txt:
  • media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html:
  • platform/mac/TestExpectations:
11:15 AM Changeset in webkit [213993] by rniwa@webkit.org
  • 5 edits in trunk/Websites/perf.webkit.org

Make unit tests return a promise instead of manually calling done
https://bugs.webkit.org/show_bug.cgi?id=169663

Reviewed by Antti Koivisto.

Make the existing unit tests always reutrn a promise instead of manually calling "done" callback as done
in r213969. The promise tests are a lot more stable and less error prone.

Also use MockRemoteAPI.waitForRequest() instead of chaining two resolved promises where appropriate.

  • unit-tests/analysis-task-tests.js:
  • unit-tests/buildbot-syncer-tests.js:
  • unit-tests/checkconfig.js:
  • unit-tests/privileged-api-tests.js:
11:15 AM Changeset in webkit [213992] by jonlee@apple.com
  • 11 edits
    8 adds in trunk/Source/WebCore

Clean up RTCPeerConnection IDL
https://bugs.webkit.org/show_bug.cgi?id=169660

Reviewed by Youenn Fablet.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::addTransceiver): Refactor to use RTCRtpTransceiverInit.
(WebCore::RTCPeerConnection::completeAddTransceiver):

  • Modules/mediastream/RTCPeerConnection.h: Remove redundant definitions.
  • Modules/mediastream/RTCPeerConnection.idl: Using 13 March 2017 Editor's Draft of

WebRTC spec. Move RTCOfferAnswerOptions out to separate IDLs. Keep RTCDataChannelInit and
RTCRtpTransceiverInit since they appear to be used only in RTCPeerConnection.

Reorder the properties, functions, and events based on their appearance in the spec.

Legacy MediaStream calls are placed at the end. I tried to use "partial interface" in the
same file, but in the end nothing was generated, so everything is contained in one interface
block.

  • Modules/mediastream/RTCEnums.h: Added. This will be an all-in-one header to hold the

enums.

Move RTCAnswerOptions, RTCOfferAnswerOptions, RTCOfferOptions, RTCRtpTransceiverDirection
out to their own IDL's.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/mediastream/RTCAnswerOptions.h: Added.
  • Modules/mediastream/RTCAnswerOptions.idl: Added.
  • Modules/mediastream/RTCOfferAnswerOptions.h:
  • Modules/mediastream/RTCOfferAnswerOptions.idl: Added.
  • Modules/mediastream/RTCOfferOptions.h: Added. Remove |offerToReceiveVideo| and

|offerToReceiveAudio|, which are not used.

  • Modules/mediastream/RTCOfferOptions.idl: Added.
  • Modules/mediastream/RTCRtpTransceiverDirection.h: Added.
  • Modules/mediastream/RTCRtpTransceiverDirection.idl: Added. Use a typedef for

RTCRtpTransceiverDirection to prevent the code generator from prefixing RTCRtpTransceiver.

  • Modules/mediastream/RTCRtpTransceiver.idl: Move RTCRtpTransceiverDirection.
  • WebCore.xcodeproj/project.pbxproj: Add IDLs and derived sources. Remove unused

HTMLMediaElementMediaStream.h. Reorder.

Refactor.

  • Modules/mediastream/RTCRtpTransceiver.h: Use RTCRtpTransceiverDirection.
  • Modules/mediastream/MediaEndpointPeerConnection.cpp:
11:15 AM Changeset in webkit [213991] by joepeck@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Elements Tab > Node Details Sidebar > Properties Section is spammed with TypeErrors
https://bugs.webkit.org/show_bug.cgi?id=153911
<rdar://problem/24520098>

Reviewed by Devin Rousso.

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties.nodeResolved.inspectedPage_node_collectPrototypes):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties.nodeResolved):
Update due to naming conventions for code that evalutes in the inspected page.

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties.fillSection):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties):
Create a more complete ObjectTreeView for the different sections.

  • UserInterface/Views/ObjectTreePropertyTreeElement.js:

(WebInspector.ObjectTreePropertyTreeElement.prototype._updateChildren):
PureAPI behaves the same as ClassAPI and just shows own properties.

  • UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView.prototype.showOnlyProperties):
In only properties mode don't show the Prototype expander at the end.

(WebInspector.ObjectTreeView.prototype.setPrototypeNameOverride):
Allow a prototype name override at the top level. This will allow clients
to specify that the object at the top level is a Prototype object, so that
ObjectTreePropertyTreeElements can infer the right NativeFunctionParameter
information knowing that those properties are on a particular prototype.

(WebInspector.ObjectTreeView.prototype.update):
For the PureAPI use getOwnProperties instead of getDisplayableProperties.
This avoids the special handling we have for DOM native properties which
we bubble up to the top as value descriptors even though they are actually
accessor descriptors on prototypes.

(WebInspector.ObjectTreeView.prototype._updateProperties):
Pass the prototype name override onward for object properties.

11:03 AM Changeset in webkit [213990] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] Initialize m_button, m_clickCount members in PlatformMouseEvent constructors
https://bugs.webkit.org/show_bug.cgi?id=169666

Reviewed by Michael Catanzaro.

Initialize the m_button and m_clickCount class members in the GTK+-specific
implementation of PlatformMouseEvent constructors to NoButton and 0,
respectively. The constructors expect to operate on passed-in GTK+ events
that will be able to initialize those two members to some valid values, but
this is not guaranteed.

  • platform/gtk/PlatformMouseEventGtk.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

11:02 AM Changeset in webkit [213989] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[TexMap] Add missing class member initializations
https://bugs.webkit.org/show_bug.cgi?id=169665

Reviewed by Michael Catanzaro.

Zero-initialize the members in various TextureMapper classes
that are missing the proper initialization, as reported by
the Coverity tool.

  • platform/graphics/texmap/BitmapTexturePool.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):

  • platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h:
10:59 AM Changeset in webkit [213988] by achristensen@apple.com
  • 14 edits in trunk

Compiled content extensions should include the JSON source
https://bugs.webkit.org/show_bug.cgi?id=169643

Reviewed by Geoffrey Garen.

Source/WebCore:

Serializing the JSON string from which a content extension was compiled
to disk with the compiled content extension will allow us to validate content
extensions and automatically migrate older content extensions to new versions.
It less than doubles the size of the compiled content extension on disk, and when
interpreting the bytecode that memory is never read, so it doesn't increase our
dirty memory usage.

Covered by new API tests.

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):

  • contentextensions/ContentExtensionCompiler.h:

Source/WebKit2:

  • UIProcess/API/APIContentExtensionStore.cpp:

(API::ContentExtensionStore::ContentExtensionStore):
(API::ContentExtensionMetaData::fileSize):
(API::encodeContentExtensionMetaData):
(API::decodeContentExtensionMetaData):
(API::compiledToFile):
(API::createExtension):
(API::ContentExtensionStore::getContentExtensionSource):

  • UIProcess/API/APIContentExtensionStore.h:
  • UIProcess/API/Cocoa/WKContentExtensionStore.mm:

(toWKErrorCode):
(-[WKContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
(-[WKContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):
(-[WKContentExtensionStore _getContentExtensionSourceForIdentifier:completionHandler:]):

  • UIProcess/API/Cocoa/WKContentExtensionStorePrivate.h:
  • UIProcess/API/Cocoa/WKError.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:

(toUserContentExtensionStoreError):
(-[_WKUserContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]):
(-[_WKUserContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:

(TEST_F):

10:40 AM Changeset in webkit [213987] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

[Modern Media Controls] Captions do not default to Auto when language is changed
https://bugs.webkit.org/show_bug.cgi?id=169675
<rdar://problem/30423369>

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Eric Carlson.

Source/WebCore:

Ensure we correctly mark the Off and Auto items as selected when we are using the
Off and Auto tracks.

Tests: media/modern-media-controls/tracks-support/tracks-support-auto-text-track.html

media/modern-media-controls/tracks-support/tracks-support-off-text-track.html

  • Modules/modern-media-controls/media/tracks-support.js:

(TracksSupport.prototype.tracksPanelIsTrackInSectionSelected):
(TracksSupport.prototype.tracksPanelSelectionDidChange):

LayoutTests:

Add new tests that check the cases where the expected selected track should be "Off" or "Auto".

  • media/modern-media-controls/tracks-support/tracks-support-auto-text-track-expected.txt: Added.
  • media/modern-media-controls/tracks-support/tracks-support-auto-text-track.html: Added.
  • media/modern-media-controls/tracks-support/tracks-support-off-text-track-expected.txt: Added.
  • media/modern-media-controls/tracks-support/tracks-support-off-text-track.html: Added.
10:21 AM Changeset in webkit [213986] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Use git's -C flag when possible in VCSUtils.pm
https://bugs.webkit.org/show_bug.cgi?id=169003

Patch by Kocsen Chung <kocsen_chung@apple.com> on 2017-03-15
Reviewed by Sam Weinig.

Use the git -C flag where appropriate to perform the
operation on a target directory and avoid unnecessary logic
to cd in and out of the target directory.

  • Scripts/VCSUtils.pm:

(isGitDirectory):
(isGitSVNDirectory):
(svnRevisionForDirectory):
(svnInfoForPath):
For all four subroutines, use git's -C flag and strip cd logic.

10:06 AM Changeset in webkit [213985] by Ryan Haddad
  • 10 edits
    1 delete in trunk/Source/WebCore

Unreviewed, rolling out r213977.

This change broke the Windows build.

Reverted changeset:

"Make a base class for WebGL and WebGPU contexts"
https://bugs.webkit.org/show_bug.cgi?id=169651
http://trac.webkit.org/changeset/213977

10:04 AM Changeset in webkit [213984] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/tests/media/modern-media-controls/time-labels-support/long-time.html as flaky on mac-wk1.
https://bugs.webkit.org/show_bug.cgi?id=169677

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
9:38 AM Changeset in webkit [213983] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk

run-webkit-tests is always creating mock libwebrtc tracks
https://bugs.webkit.org/show_bug.cgi?id=169658

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-15
Reviewed by Alex Christensen.

Source/WebCore:

Tests: webrtc/peer-connection-audio-mute.html

webrtc/video-mute.html

Creating real libwebrtc av tracks in case of RealTwoPeerConnections mock factory.

  • testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::MockLibWebRTCPeerConnectionFactory::CreateVideoTrack):
(WebCore::MockLibWebRTCPeerConnectionFactory::CreateAudioTrack):

  • testing/MockLibWebRTCPeerConnection.h:

LayoutTests:

  • TestExpectations:
  • webrtc/audio-peer-connection-webaudio.html:
  • webrtc/peer-connection-audio-mute-expected.txt: Added.
  • webrtc/peer-connection-audio-mute.html: Added.
  • webrtc/routines.js:

(analyseAudio):

  • webrtc/video-expected.txt:
  • webrtc/video-mute-expected.txt: Added.
  • webrtc/video-mute.html: Added.
  • webrtc/video.html:
9:35 AM Changeset in webkit [213982] by commit-queue@webkit.org
  • 5 edits in trunk

Preventive clean-up: ensure RTCPeerConnection stays valid when calling postTask
https://bugs.webkit.org/show_bug.cgi?id=169661

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-15
Reviewed by Alex Christensen.

Source/WebCore:

Protecting the RTCPeerConnection object when calling postTask since it might get collected between the task post
and task run. Also do not send negotiationNeeded event if RTCPeerConnection is closed (covered by added test).

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):
(WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent):

LayoutTests:

  • webrtc/negotiatedneeded-event-addStream-expected.txt:
  • webrtc/negotiatedneeded-event-addStream.html:
8:58 AM Changeset in webkit [213981] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/volume-down-support/volume-down-support.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169568

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:42 AM Changeset in webkit [213980] by commit-queue@webkit.org
  • 7 edits
    2 moves in trunk

[Modern Media Controls] Always use six digits to display time when overall media duration is an hour or more
https://bugs.webkit.org/show_bug.cgi?id=169668
<rdar://problem/31059699>

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Dean Jackson.

Source/WebCore:

Always use six digits to display times when the overall media duration is an hour or more. This
ensures that we don't display too much white space around labels when we know we will eventually
need six digits to display the full time, but the current time to display is under an hour.

Test: media/modern-media-controls/time-control/time-control-use-six-digits-for-time-labels.html

  • Modules/modern-media-controls/controls/time-control.js:

(TimeControl.prototype.get useSixDigitsForTimeLabels):
(TimeControl.prototype.set useSixDigitsForTimeLabels):
(TimeControl.prototype.set width):
(TimeControl.prototype.get isSufficientlyWide):
(TimeControl.prototype._availableWidthHasChanged):
(TimeControl.prototype.get labelsMayDisplayTimesOverAnHour): Deleted.
(TimeControl.prototype.set labelsMayDisplayTimesOverAnHour): Deleted.

  • Modules/modern-media-controls/controls/time-label.js:

(TimeLabel.prototype._formattedTime):

  • Modules/modern-media-controls/media/time-labels-support.js:

(TimeLabelsSupport.prototype.syncControl):
(TimeLabelsSupport):

LayoutTests:

Rebase some tests due to the rename of the labelsMayDisplayTimesOverAnHour property to
useSixDigitsForTimeLabels. We also add an assertion in long-time.html to check that
we currently use six digits to display a time that is under an hour but where the
media duration is over an hour.

  • http/tests/media/modern-media-controls/time-labels-support/long-time-expected.txt:
  • http/tests/media/modern-media-controls/time-labels-support/long-time.html:
  • media/modern-media-controls/time-control/time-control-use-six-digits-for-time-labels-expected.txt: Renamed from LayoutTests/media/modern-media-controls/time-control/time-control-labels-may-display-times-over-an-hour-expected.txt.
  • media/modern-media-controls/time-control/time-control-use-six-digits-for-time-labels.html: Renamed from LayoutTests/media/modern-media-controls/time-control/time-control-labels-may-display-times-over-an-hour.html.
3:19 AM Changeset in webkit [213979] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[mac-wk1 debug] LayoutTest media/modern-media-controls/airplay-placard/airplay-placard-text-section.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=169654
<rdar://problem/31059092>

Patch by Antoine Quint <Antoine Quint> on 2017-03-15
Reviewed by Dean Jackson.

Using an asynchronous assertion to improve reliability.

  • media/modern-media-controls/airplay-placard/airplay-placard-text-section-expected.txt:
  • media/modern-media-controls/airplay-placard/airplay-placard-text-section.html:
2:51 AM Changeset in webkit [213978] by dino@apple.com
  • 12 edits in trunk/Source

Sort Xcode project files
https://bugs.webkit.org/show_bug.cgi?id=169669

Reviewed by Antoine Quint.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
2:43 AM Changeset in webkit [213977] by dino@apple.com
  • 10 edits
    1 add in trunk/Source/WebCore

Make a base class for WebGL and WebGPU contexts
https://bugs.webkit.org/show_bug.cgi?id=169651
<rdar://problem/31053489>

Reviewed by Simon Fraser.

Add a new pure virtual base class, GPUBasedCanvasRenderingContext, that
will be used by WebGL and WebGPU rendering contexts. This allows us
to avoid some code duplication, since many places treat the two
as the same.

Also rename is3d() -> isWebGL() and isGPU() -> isWebGPU().

  • WebCore.xcodeproj/project.pbxproj: New file.
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContextWebGL):
(WebCore::HTMLCanvasElement::getContextWebGPU):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::isGPUBased):
(WebCore::HTMLCanvasElement::getImageData):
(WebCore::HTMLCanvasElement::isGPU): Deleted.
(WebCore::HTMLCanvasElement::is3D): Deleted.

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext.h:

(WebCore::CanvasRenderingContext::isWebGL):
(WebCore::CanvasRenderingContext::isWebGPU):
(WebCore::CanvasRenderingContext::isGPUBased):
(WebCore::CanvasRenderingContext::is3d): Deleted.
(WebCore::CanvasRenderingContext::isGPU): Deleted.

  • html/canvas/GPUBasedCanvasRenderingContext.h: Added.

(WebCore::GPUBasedCanvasRenderingContext::GPUBasedCanvasRenderingContext):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):

  • html/canvas/WebGLRenderingContextBase.h:
  • html/canvas/WebGPURenderingContext.cpp:

(WebCore::WebGPURenderingContext::WebGPURenderingContext):

  • html/canvas/WebGPURenderingContext.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::canvasCompositingStrategy):

1:35 AM Changeset in webkit [213976] by dewei_zhu@apple.com
  • 10 edits
    7 adds in trunk/Websites/perf.webkit.org

Rewrite 'pull-os-versions' script in Javascript to add support for reporting os revisions with sub commits.
https://bugs.webkit.org/show_bug.cgi?id=169542

Reviewed by Ryosuke Niwa.

Extend '/api/commits/<repository>/last-reported' to accept a range and return last reported commits in given range.
Rewrite 'pull-os-versions' in JavaScript and add unit tests for it.
Instead of writing query manually while searching criteria contains null columns, use the methods provided in 'db.php'.
Add '.gitignore' file to ommit files generated by while running tests/instances locally.

  • .gitignore: Added.
  • public/api/commits.php:
  • public/api/report-commits.php:
  • public/include/commit-log-fetcher.php:
  • public/include/db.php: 'null_columns' of prepare_params should be a reference.
  • public/include/report-processor.php:
  • server-tests/api-commits.js:

(then):

  • server-tests/api-report-commits-tests.js:
  • server-tests/resources/mock-logger.js: Added.

(MockLogger):
(MockLogger.prototype.log):
(MockLogger.prototype.error):

  • server-tests/resources/mock-subprocess.js: Added.

(MockSubprocess.call):
(MockSubprocess.waitingForInvocation):
(MockSubprocess.inject):
(MockSubprocess.reset):

  • server-tests/tools-buildbot-triggerable-tests.js:

(MockLogger): Deleted.
(MockLogger.prototype.log): Deleted.
(MockLogger.prototype.error): Deleted.

  • server-tests/tools-os-build-fetcher-tests.js: Added.

(beforeEach):
(return.waitingForInvocationPromise.then):
(then):
(string_appeared_here.return.waitingForInvocationPromise.then):
(return.addSlaveForReport.emptyReport.then):

  • tools/js/os-build-fetcher.js: Added.

(OSBuildFetcher):
(OSBuildFetcher.prototype._fetchAvailableBuilds):
(OSBuildFetcher.prototype._computeOrder):
(OSBuildFetcher.prototype._commitsForAvailableBuilds.return.this._subprocess.call.then.):
(OSBuildFetcher.prototype._commitsForAvailableBuilds):
(OSBuildFetcher.prototype._addSubCommitsForBuild):
(OSBuildFetcher.prototype._submitCommits):
(OSBuildFetcher.prototype.fetchAndReportNewBuilds):

  • tools/js/subprocess.js: Added.

(const.childProcess.require.string_appeared_here.Subprocess.prototype.call):
(const.childProcess.require.string_appeared_here.Subprocess):

  • tools/pull-os-versions.js: Added.

(main):
(syncLoop):

  • tools/sync-commits.py:

(Repository.fetch_commits_and_submit):

12:47 AM Changeset in webkit [213975] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

Unreviewed GTK+ build fix. Sprinkle ENABLE(MEDIA_STREAM) build guards
in the Internals class to avoid compilation failures when building
with this feature disabled.

  • testing/Internals.cpp:

(WebCore::Internals::~Internals):

  • testing/Internals.h:
  • testing/Internals.idl:

Mar 14, 2017:

11:18 PM Changeset in webkit [213974] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

start-queue-mac.sh should create logs directory if it doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=169634

Reviewed by Alexey Proskuryakov.

  • EWSTools/start-queue-mac.sh: Creating logs directory if it doesn't exist.
10:52 PM Changeset in webkit [213973] by tpopela@redhat.com
  • 2 edits in trunk/Source/JavaScriptCore

Wrong condition in offlineasm/risc.rb
https://bugs.webkit.org/show_bug.cgi?id=169597

Reviewed by Mark Lam.

It's missing the 'and' operator between the conditions.

  • offlineasm/risc.rb:
10:21 PM Changeset in webkit [213972] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

CanvasCapture should not generate a frame per each canvas draw command
https://bugs.webkit.org/show_bug.cgi?id=169498

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-14
Reviewed by Simon Fraser & Eric Carlson.

Source/WebCore:

Test: fast/mediastream/captureStream/canvas2d-heavy-drawing.html

Making Canvas capture be asynchronous.
This ensures that one frame will be created for a set of synchronous draw commands.
In the future, we should find a better approach, like aligning with requestAnimationFrame.
Adding internals observer API for media stream tracks.

  • Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::Source):
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):

  • Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:
  • platform/mediastream/RealtimeMediaSource.h:
  • testing/Internals.cpp:

(WebCore::Internals::~Internals):
(WebCore::Internals::observeMediaStreamTrack):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • fast/mediastream/captureStream/canvas2d-heavy-drawing-expected.txt: Added.
  • fast/mediastream/captureStream/canvas2d-heavy-drawing.html: Added.
8:28 PM Changeset in webkit [213971] by wenson_hsieh@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, skip fast/media/video-element-in-details-collapse.html on iOS

  • platform/ios-simulator/TestExpectations:
8:27 PM Changeset in webkit [213970] by aestes@apple.com
  • 4 edits
    2 adds in trunk

[iOS] -[WKWebView _dataForDisplayedPDF] returns nil when called before an encrypted PDF has been unlocked
https://bugs.webkit.org/show_bug.cgi?id=169653
<rdar://problem/24137675>

Reviewed by Tim Horton.

Source/WebKit2:

  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView pdfDocument]): Changed to return _cgPDFDocument directly instead of via the
UIPDFDocument, which is only created after the PDF has been unlocked.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/encrypted.pdf: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFView.mm: Added.

(runTest):
(TEST):

8:19 PM Changeset in webkit [213969] by rniwa@webkit.org
  • 13 edits in trunk/Websites/perf.webkit.org

Make server tests return a promise instead of manually calling done
https://bugs.webkit.org/show_bug.cgi?id=169648

Rubber-stamped by Chris Dumez.

Make the existing server tests always reutrn a promise instead of manually calling "done" callback.
The promise tests are a lot more stable and less error prone.

Also use arrow functions everywhere and use prepareServerTest, renamed from connectToDatabaseInEveryTest,
in more tests instead of manually connecting to database in every test, and reset v3 models.

  • server-tests/admin-platforms-tests.js:
  • server-tests/admin-reprocess-report-tests.js:
  • server-tests/api-build-requests-tests.js:
  • server-tests/api-manifest.js:
  • server-tests/api-measurement-set-tests.js:

(.postReports): Deleted. Not used in any test.

  • server-tests/api-report-commits-tests.js:
  • server-tests/api-report-tests.js:
  • server-tests/api-update-triggerable.js:
  • server-tests/privileged-api-upate-run-status.js:
  • server-tests/resources/common-operations.js:

(prepareServerTest): Renamed from connectToDatabaseInEveryTest. Increase the timeout and reset v3 models.

  • server-tests/tools-buildbot-triggerable-tests.js:
7:08 PM Changeset in webkit [213968] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

REGRESSION (r213882): 12 new/updated web-platform-tests failing
https://bugs.webkit.org/show_bug.cgi?id=169615

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-14

6:20 PM Changeset in webkit [213967] by wenson_hsieh@apple.com
  • 3 edits
    2 adds in trunk

RenderElements should unregister for viewport visibility callbacks when they are destroyed
https://bugs.webkit.org/show_bug.cgi?id=169521
<rdar://problem/30959545>

Reviewed by Simon Fraser.

Source/WebCore:

When registering a RenderElement for viewport visibility callbacks, we always need to make sure that it is unregistered
before it is destroyed. While we account for this in the destructor of RenderElement, we only unregister in the destructor
if we are already registered for visibility callbacks. In the call to RenderObject::willBeDestroyed(), we clear out rare
data, which holds RenderElement's viewport callback registration state, so upon entering the destructor of RenderElement,
we skip unregistration because RenderElement thinks that it is not registered.

We can mitigate this by unregistering the RenderElement earlier, in RenderElement::willBeDestroyed, prior to clearing out
the rare data. However, we'd ideally want to move the cleanup logic out of the destructor altogether and into willBeDestroyed
(see https://bugs.webkit.org/show_bug.cgi?id=169650).

Test: fast/media/video-element-in-details-collapse.html

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::willBeDestroyed):

LayoutTests:

Adds a new layout test covering this regression. See WebCore ChangeLog for more details.

  • fast/media/video-element-in-details-collapse-expected.txt: Added.
  • fast/media/video-element-in-details-collapse.html: Added.
5:53 PM Changeset in webkit [213966] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

BytecodeGenerator should use the same function to determine if it needs to store the DerivedConstructor in an ArrowFunction lexical environment.
https://bugs.webkit.org/show_bug.cgi?id=169647
<rdar://problem/31051832>

Reviewed by Michael Saboff.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::usesDerivedConstructorInArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::emitPutDerivedConstructorToArrowFunctionContextScope):

  • bytecompiler/BytecodeGenerator.h:
5:18 PM Changeset in webkit [213965] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-603.1.30.0.34

Tag Safari-603.1.30.0.34.

5:18 PM Changeset in webkit [213964] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-603.1.30.1.33

Tag Safari-603.1.30.1.33.

5:17 PM Changeset in webkit [213963] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Rename LayerTypeWebGLLayer and use it for both WebGL and WebGPU
https://bugs.webkit.org/show_bug.cgi?id=169628
<rdar://problems/31047025>

Fix Windows build.

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(printLayer):

5:09 PM Changeset in webkit [213962] by matthew_hanson@apple.com
  • 1 delete in tags/Safari-603.1.30.0.34

Delete tag.

5:05 PM Changeset in webkit [213961] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Exception when fetching computed styles can break future updates of section
https://bugs.webkit.org/show_bug.cgi?id=169638
<rdar://problem/30588688>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-03-14
Reviewed by Devin Rousso.

  • UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype.refresh.wrap):
(WebInspector.DOMNodeStyles.prototype.refresh):
Gracefully handle exceptions. If an exception did happen we
would be unable to update these in the future.

4:44 PM Changeset in webkit [213960] by Brian Burg
  • 6 edits in trunk/Source/JavaScriptCore

[Cocoa] Web Inspector: generated code for parsing an array of primitive-type enums from payload does not work
https://bugs.webkit.org/show_bug.cgi?id=169629

Reviewed by Joseph Pecoraro.

This was encountered while trying to compile new protocol definitions that support the Actions API.

  • inspector/scripts/codegen/models.py:

(EnumType.repr): Improve debug logging so fields match the class member names.

  • inspector/scripts/codegen/objc_generator.py:

(ObjCGenerator.payload_to_objc_expression_for_member):
If the array elements are actually a primitive type, then there's no need to do any
conversion from a payload. This happens for free since the payload is a tree of
NSDictionary, NSString, NSNumber, etc.

  • inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
  • inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:

Rebaseline.

  • inspector/scripts/tests/generic/type-declaration-object-type.json:

Add new cases for properties that contain an array with enum type references and an array of anonymous enums.

4:41 PM Changeset in webkit [213959] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603.1.30.1-branch/LayoutTests

Merge r213953. rdar://problem/31049877

4:41 PM Changeset in webkit [213958] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603.1.30.1-branch/Source/WebCore

Merge r213949. rdar://problem/31049877

4:41 PM Changeset in webkit [213957] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603.1.30.1-branch/Source

Versioning.

4:35 PM Changeset in webkit [213956] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603.1.30.0-branch/LayoutTests

Merge r213953. rdar://problem/31049771

4:34 PM Changeset in webkit [213955] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603.1.30.0-branch/Source/WebCore

Merge r213949. rdar://problem/31049771

4:18 PM Changeset in webkit [213954] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

Let PDFLayerController drive cursor updates so that it's correct more often
https://bugs.webkit.org/show_bug.cgi?id=169626
<rdar://problem/30762943>

Reviewed by Simon Fraser.

  • WebProcess/Plugins/PDF/DeprecatedPDFLayerControllerSPI.h:
  • WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h:
  • WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:

(-[WKPDFLayerControllerDelegate setMouseCursor:]):
(WebKit::PDFPlugin::handleMouseEvent):
(WebKit::PDFPlugin::handleMouseEnterEvent):
(WebKit::pdfLayerControllerCursorTypeToCursor):
(WebKit::PDFPlugin::notifyCursorChanged):
Disable updateCursor and use the setMouseCursor delegate method when possible.

4:17 PM Changeset in webkit [213953] by aestes@apple.com
  • 3 edits in trunk/LayoutTests

Update ApplePaySession.html after r213949

Rubber-stamped by Beth Dakin.

  • http/tests/ssl/applepay/ApplePaySession-expected.txt:
  • http/tests/ssl/applepay/ApplePaySession.html:
4:06 PM Changeset in webkit [213952] by rniwa@webkit.org
  • 31 edits
    1 move
    1 delete in trunk/Websites/perf.webkit.org

Rename RootSet to CommitSet
https://bugs.webkit.org/show_bug.cgi?id=169580

Rubber-stamped by Chris Dumez.

Renamed root_sets to commit_sets and roots to commit_set_relationships in the database schema, and renamed
related classes in public/v3/ and tools accordingly.

RootSet, MeasurementRootSet, and CustomRootSet are respectively renamed to CommitSet, MeasurementCommitSet,
and CustomCommitSet.

In order to migrate the database, run:
`
BEGIN;
ALTER TABLE root_sets RENAME TO commit_sets;
ALTER TABLE commit_sets RENAME COLUMN rootset_id TO commitset_id;
ALTER TABLE roots RENAME TO commit_set_relationships;
ALTER TABLE commit_set_relationships RENAME COLUMN root_set TO commitset_set;
ALTER TABLE commit_set_relationships RENAME COLUMN root_commit TO commitset_commit;
ALTER TABLE build_requests RENAME COLUMN request_root_set TO request_commit_set;
END;
`

  • browser-tests/index.html:
  • init-database.sql:
  • public/api/build-requests.php:

(main):

  • public/api/test-groups.php:

(main):
(format_test_group):

  • public/include/build-requests-fetcher.php:

(BuildRequestsFetcher::construct):
(BuildRequestsFetcher::results_internal):
(BuildRequestsFetcher::commit_sets): Renamed from root_sets.
(BuildRequestsFetcher::commits): Renamed from roots.
(BuildRequestsFetcher::fetch_commits_for_set_if_needed): Renamed from fetch_roots_for_set_if_needed.

  • public/privileged-api/create-test-group.php:

(main):
(ensure_commit_sets): Renamed from commit_sets_from_root_sets.

  • public/v3/components/analysis-results-viewer.js:

(AnalysisResultsViewer.prototype.buildRowGroups):
(AnalysisResultsViewer.prototype._collectCommitSetsInTestGroups): Renamed from _collectRootSetsInTestGroups.
(AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups):
(AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups):
(AnalysisResultsViewer.CommitSetInTestGroup): Renamed from RootSetInTestGroup.
(AnalysisResultsViewer.CommitSetInTestGroup.prototype.constructor):
(AnalysisResultsViewer.CommitSetInTestGroup.prototype.commitSet): Renamed from rootSet.
(AnalysisResultsViewer.CommitSetInTestGroup.prototype.succeedingCommitSet): Renamed from succeedingRootSet.
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.constructor):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.addRowIndex):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.isComplete):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.startRowIndex):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.endRowIndex):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype._computeTestGroupStatus):

  • public/v3/components/chart-revision-range.js:

(ChartRevisionRange.prototype._revisionForPoint):
(ChartRevisionRange.prototype._computeRevisionList):

  • public/v3/components/customizable-test-group-form.js:

(CustomizableTestGroupForm.prototype.constructor):
(CustomizableTestGroupForm.prototype.setCommitSetMap): Renamed from setRootSetMap.
(CustomizableTestGroupForm.prototype._submitted):
(CustomizableTestGroupForm.prototype._computeCommitSetMap): Renamed from _computeRootSetMap.
(CustomizableTestGroupForm.prototype.render): Renamed from render.
(CustomizableTestGroupForm.prototype._constructRevisionRadioButtons):

  • public/v3/components/results-table.js:

(ResultsTable.prototype.render):
(ResultsTable.prototype._createRevisionListCells):
(ResultsTable.prototype._computeRepositoryList):
(ResultsTableRow.prototype.constructor):
(ResultsTableRow.prototype.commitSet): Renamed from rootSet.

  • public/v3/components/test-group-results-table.js:

(TestGroupResultsTable.prototype.buildRowGroups):

  • public/v3/index.html:
  • public/v3/models/build-request.js:

(BuildRequest.prototype.constructor):
(BuildRequest.prototype.updateSingleton):
(BuildRequest.prototype.commitSet): Renamed from rootSet.
(BuildRequest.constructBuildRequestsFromData):

  • public/v3/models/commit-set.js: Renamed from public/v3/models/root-set.js.

(CommitSet): Renamed from RootSet.
(CommitSet.containsMultipleCommitsForRepository):
(MeasurementCommitSet): Renamed from MeasurementRootSet.
(MeasurementCommitSet.prototype.namedStaticMap):
(MeasurementCommitSet.prototype.ensureNamedStaticMap):
(MeasurementCommitSet.namedStaticMap):
(MeasurementCommitSet.ensureNamedStaticMap):
(MeasurementCommitSet.ensureSingleton):
(CustomCommitSet): Renamed from CustomRootSet.

  • public/v3/models/measurement-adaptor.js:

(MeasurementAdaptor.prototype.applyTo):

  • public/v3/models/test-group.js:

(TestGroup.prototype.constructor):
(TestGroup.prototype.addBuildRequest):
(TestGroup.prototype.repetitionCount):
(TestGroup.prototype.requestedCommitSets): Renamed from requestedRootSets.
(TestGroup.prototype.requestsForCommitSet): Renamed from requestsForRootSet.
(TestGroup.prototype.labelForCommitSet): Renamed from labelForRootSet.
(TestGroup.prototype.didSetResult):
(TestGroup.prototype.compareTestResults):
(TestGroup.prototype._valuesForCommitSet): Renamed from _valuesForRootSet.
(TestGroup.prototype.createAndRefetchTestGroups):

  • public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage.prototype.render):
(AnalysisTaskPage.prototype._retryCurrentTestGroup):
(AnalysisTaskPage.prototype._createNewTestGroupFromChart):
(AnalysisTaskPage.prototype._createNewTestGroupFromViewer):
(AnalysisTaskPage.prototype._createTestGroupAfterVerifyingCommitSetList):

  • server-tests/api-build-requests-tests.js:
  • server-tests/resources/mock-data.js:

(MockData.resetV3Models):
(MockData.addMockData):
(MockData.addAnotherMockTestGroup):

  • tools/detect-changes.js:

(createAnalysisTaskAndNotify):

  • tools/js/buildbot-syncer.js:

(BuildbotSyncer.prototype._propertiesForBuildRequest):
(BuildbotSyncer.prototype._revisionSetFromCommitSetWithExclusionList):

  • tools/js/database.js:

(tableToPrefixMap):

  • tools/js/v3-models.js:
  • tools/sync-buildbot.js:

(syncLoop):

  • tools/sync-with-buildbot.py: Deleted. No longer used.
  • unit-tests/analysis-task-tests.js:
  • unit-tests/build-request-tests.js:

(sampleBuildRequestData):

  • unit-tests/buildbot-syncer-tests.js:

(sampleCommitSetData):

  • unit-tests/measurement-adaptor-tests.js:
  • unit-tests/measurement-set-tests.js:
  • unit-tests/resources/mock-v3-models.js:

(MockModels.inject):

  • unit-tests/test-groups-tests.js:

(sampleTestGroup):

4:03 PM Changeset in webkit [213951] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-javascript.html as failing on ios-simulator-wk2.
https://bugs.webkit.org/show_bug.cgi?id=169640

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
3:59 PM Changeset in webkit [213950] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-javascript.html as failing on mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=169640

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
3:53 PM Changeset in webkit [213949] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r209760): Apple Pay doesn't work on sites that specify empty contact fields
https://bugs.webkit.org/show_bug.cgi?id=169639
<rdar://problem/30957789>

Reviewed by Anders Carlsson.

Shipping and billing contact fields are allowed to be empty.

  • Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):

3:38 PM Changeset in webkit [213948] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Extend WKPreferences to include preferences for testing MediaCapture.
https://bugs.webkit.org/show_bug.cgi?id=169560

Patch by Andrew Gold <agold@apple.com> on 2017-03-14
Reviewed by Youenn Fablet.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _mockCaptureDevicesEnabled]):
(-[WKPreferences _setMockCaptureDevicesEnabled:]):
(-[WKPreferences _mediaCaptureRequiresSecureConnection]):
(-[WKPreferences _setMediaCaptureRequiresSecureConnection:]):
(-[WKPreferences _enumeratingAllNetworkInterfacesEnabled]):
(-[WKPreferences _setEnumeratingAllNetworkInterfacesEnabled:]):
(-[WKPreferences _iceCandidateFiltertingEnabled]):
(-[WKPreferences _setICECandidateFilteringEnabled:]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
3:36 PM Changeset in webkit [213947] by beidson@apple.com
  • 14 edits
    5 moves in trunk

Rename WKHTTPCookieStorage to WKHTTPCookieStore.
https://bugs.webkit.org/show_bug.cgi?id=169630

Reviewed by Tim Horton.

Source/WebKit2:

  • CMakeLists.txt:
  • Shared/API/APIObject.h:
  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

  • UIProcess/API/APIHTTPCookieStore.cpp: Renamed from Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.cpp.

(API::HTTPCookieStore::HTTPCookieStore):
(API::HTTPCookieStore::~HTTPCookieStore):
(API::HTTPCookieStore::cookies):
(API::HTTPCookieStore::setCookie):
(API::HTTPCookieStore::setCookies):
(API::HTTPCookieStore::deleteCookie):
(API::HTTPCookieStore::removeCookiesSinceDate):
(API::HTTPCookieStore::setHTTPCookieAcceptPolicy):
(API::HTTPCookieStore::getHTTPCookieAcceptPolicy):

  • UIProcess/API/APIHTTPCookieStore.h: Renamed from Source/WebKit2/UIProcess/API/APIHTTPCookieStorage.h.
  • UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::httpCookieStore):
(API::WebsiteDataStore::httpCookieStorage): Deleted.

  • UIProcess/API/APIWebsiteDataStore.h:
  • UIProcess/API/Cocoa/WKHTTPCookieStore.h: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKHTTPCookieStorage.h.
  • UIProcess/API/Cocoa/WKHTTPCookieStore.mm: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKHTTPCookieStorage.mm.

(coreCookiesToNSCookies):
(-[WKHTTPCookieStore dealloc]):
(-[WKHTTPCookieStore fetchCookies:]):
(-[WKHTTPCookieStore fetchCookiesForURL:completionHandler:]):
(-[WKHTTPCookieStore setCookie:completionHandler:]):
(-[WKHTTPCookieStore deleteCookie:completionHandler:]):
(-[WKHTTPCookieStore setCookies:forURL:mainDocumentURL:completionHandler:]):
(-[WKHTTPCookieStore removeCookiesSinceDate:completionHandler:]):
(-[WKHTTPCookieStore setCookieAcceptPolicy:completionHandler:]):
(kitCookiePolicyToNSCookiePolicy):
(-[WKHTTPCookieStore fetchCookieAcceptPolicy:]):
(-[WKHTTPCookieStore _apiObject]):

  • UIProcess/API/Cocoa/WKHTTPCookieStoreInternal.h: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKHTTPCookieStorageInternal.h.

(WebKit::wrapper):

  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _httpCookieStore]):
(-[WKWebsiteDataStore _httpCookieStorage]): Deleted.

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/WebProcessPool.cpp:
  • UIProcess/WebProcessPool.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::processPoolForCookieStorageOperations):

  • WebKit2.xcodeproj/project.pbxproj:

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStorage.mm:

(TEST):

3:32 PM Changeset in webkit [213946] by andersca@apple.com
  • 6 edits in trunk/Source

Propagate PassKit errors
https://bugs.webkit.org/show_bug.cgi?id=169633
rdar://problem/31043392

Reviewed by Dean Jackson.

Source/WebCore:

  • Modules/applepay/ApplePayError.idl:
  • Modules/applepay/ApplePaySession.cpp:

(WebCore::convert):
(WebCore::convertAndValidate):

  • Modules/applepay/PaymentRequest.h:

Source/WebKit2:

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toNSError):

3:23 PM Changeset in webkit [213945] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Fix some typos in this benchmark.

Rubber stamped by Saam Barati.

  • benchmarks/HashSetDFGReplay.cpp:

(main):

2:58 PM Changeset in webkit [213944] by zalan@apple.com
  • 4 edits
    2 adds in trunk

Simple line layout: Adjust hyphenation constrains based on the normal line layout line-breaking logic.
https://bugs.webkit.org/show_bug.cgi?id=169617

Source/WebCore:

Reviewed by Antti Koivisto.

This patch ensures that simple line layout ends up with the same hyphenation context as normal line layout.

Test: fast/text/simple-line-layout-hyphenation-constrains.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::hyphenPositionForFragment): see webkit.org/b/169613
(WebCore::SimpleLineLayout::splitFragmentToFitLine):

  • rendering/line/BreakingContext.h: Integral -> fractional.

(WebCore::tryHyphenating):

LayoutTests:

Reviewed by Antti Koivisto.

  • fast/text/simple-line-layout-hyphenation-constrains-expected.html: Added.
  • fast/text/simple-line-layout-hyphenation-constrains.html: Added.
2:48 PM Changeset in webkit [213943] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-603.1.30.0.34

Tag Safari-603.1.30.0.34.

2:41 PM Changeset in webkit [213942] by webkit@devinrousso.com
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add support for Memory timeline
https://bugs.webkit.org/show_bug.cgi?id=169584

Reviewed by Brian Burg.

  • UserInterface/Views/MemoryCategoryView.css:

(.memory-category-view > .details):
(body[dir=ltr] .memory-category-view > .details):
(body[dir=rtl] .memory-category-view > .details):

  • UserInterface/Views/MemoryTimelineOverviewGraph.css:

(.timeline-overview-graph.memory > .legend):
(body[dir=ltr] .timeline-overview-graph.memory > .legend):
(body[dir=rtl] .timeline-overview-graph.memory > .legend):
(.timeline-overview-graph.memory .memory-pressure-event):
(body[dir=ltr] .timeline-overview-graph.memory .memory-pressure-event):
(body[dir=rtl] .timeline-overview-graph.memory .memory-pressure-event):

  • UserInterface/Views/MemoryTimelineOverviewGraph.js:

(WebInspector.MemoryTimelineOverviewGraph.prototype.layout):
Rework the calculation for the marker offset to use "right" in RTL.

  • UserInterface/Views/MemoryTimelineView.css:

(.timeline-view.memory > .content > .details > .timeline-ruler):
(body[dir=ltr] .timeline-view.memory > .content > .details > .timeline-ruler):
(body[dir=rtl] .timeline-view.memory > .content > .details > .timeline-ruler):
(.timeline-view.memory > .content > .overview > .divider):
(body[dir=ltr] .timeline-view.memory > .content > .overview > .divider):
(body[dir=rtl] .timeline-view.memory > .content > .overview > .divider):
(.timeline-view.memory .legend):
(body[dir=ltr] .timeline-view.memory .legend):
(body[dir=rtl] .timeline-view.memory .legend):
(.timeline-view.memory .legend > .row):
(.timeline-view.memory .legend > .row > .swatch):
(body[dir=ltr] .timeline-view.memory .legend > .row > .swatch):
(body[dir=rtl] .timeline-view.memory .legend > .row > .swatch):
(body[dir=ltr] .timeline-view.memory .legend > .row > :matches(.label, .size)):
(body[dir=rtl] .timeline-view.memory .legend > .row > :matches(.label, .size)):
(.timeline-view.memory .legend > .row > .label):
(.timeline-view.memory .legend > .row > .size):

2:41 PM Changeset in webkit [213941] by jer.noble@apple.com
  • 25 edits
    2 adds in trunk/Source

Refactor: Allow WebKit2 to override the creation of RealtimeMediaSources
https://bugs.webkit.org/show_bug.cgi?id=169227

Reviewed by Eric Carlson.

Source/WebCore:

Allow clients of RealtimeMediaSourceCenter to specify a factory for creating
RealtimeMediaSources, to be used by subclasess of RealtimeMediaSourceCenter. Add virtual
methods to retrieve the "default" factories for the RealtimeMediaSourceCenter subclass. The
requires moving the creation of sources up from CaptureDeviceManager into
RealtimeMediaSourceCenterMac, and the addition of factory methods to AVAudioCaptureSource
and AVVideoCaptureSource.

  • platform/mediastream/CaptureDeviceManager.cpp:

(CaptureDeviceManager::deviceWithUID):
(CaptureDeviceManager::bestSourcesForTypeAndConstraints): Deleted.
(CaptureDeviceManager::sourceWithUID): Deleted.

  • platform/mediastream/CaptureDeviceManager.h:
  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::setAudioFactory):
(WebCore::RealtimeMediaSourceCenter::unsetAudioFactory):
(WebCore::RealtimeMediaSourceCenter::setVideoFactory):
(WebCore::RealtimeMediaSourceCenter::unsetVideoFactory):

  • platform/mediastream/RealtimeMediaSourceCenter.h:

(WebCore::RealtimeMediaSourceCenter::audioFactory):
(WebCore::RealtimeMediaSourceCenter::videoFactory):

  • platform/mediastream/mac/AVAudioCaptureSource.h:
  • platform/mediastream/mac/AVAudioCaptureSource.mm:

(WebCore::AVAudioCaptureSource::factory):

  • platform/mediastream/mac/AVCaptureDeviceManager.h:
  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::AVCaptureDeviceManager::createMediaSourceForCaptureDeviceWithConstraints): Deleted.

  • platform/mediastream/mac/AVMediaCaptureSource.h:
  • platform/mediastream/mac/AVVideoCaptureSource.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::factory):

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::RealtimeMediaSourceCenterMac):
(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints):
(WebCore::RealtimeMediaSourceCenterMac::createMediaStream):
(WebCore::RealtimeMediaSourceCenterMac::bestSourcesForTypeAndConstraints):
(WebCore::RealtimeMediaSourceCenterMac::defaultAudioFactory):
(WebCore::RealtimeMediaSourceCenterMac::defaultVideoFactory):

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
  • platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::factory):

  • platform/mock/MockRealtimeAudioSource.h:
  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::defaultAudioFactory):
(WebCore::MockRealtimeMediaSourceCenter::defaultVideoFactory):

  • platform/mock/MockRealtimeMediaSourceCenter.h:
  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::factory):

  • platform/mock/MockRealtimeVideoSource.h:

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebUserMediaClient.cpp:

(WebKit::WebUserMediaClient::WebUserMediaClient):
(WebKit::WebUserMediaClient::initializeFactories): Add empty non-Cocoa implementation.

  • WebProcess/WebCoreSupport/WebUserMediaClient.h:
  • WebProcess/WebCoreSupport/cocoa/WebUserMediaClientMac.mm: Added.

(WebKit::WebUserMediaClient::initializeFactories): Initialize a (for now) pass-through factory.

2:39 PM Changeset in webkit [213940] by dino@apple.com
  • 10 edits in trunk/Source

Rename LayerTypeWebGLLayer and use it for both WebGL and WebGPU
https://bugs.webkit.org/show_bug.cgi?id=169628
<rdar://problems/31047025>

Reviewed by Simon Fraser.

Rename LayerTypeWebGLLayer to LayerTypeContentsProvidedLayer
and use it for both WebGLLayer and WebGPULayer, to avoid
code duplication.

Source/WebCore:

  • platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::operator<<):

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::layerTypeForPlatformLayer):
(PlatformCALayerCocoa::PlatformCALayerCocoa):
(PlatformCALayerCocoa::commonInit):

Source/WebKit2:

  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::description):

  • UIProcess/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::createLayer):

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::createLayer):

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(WebKit::PlatformCALayerRemoteCustom::clone):

2:37 PM Changeset in webkit [213939] by fpizlo@apple.com
  • 13 edits
    7 adds in trunk/Source

Record the HashSet/HashMap operations in DFG/FTL/B3 and replay them in a benchmark
https://bugs.webkit.org/show_bug.cgi?id=169590

Reviewed by Saam Barati.

Source/JavaScriptCore:

Adds code to support logging some hashtable stuff in the DFG.

  • dfg/DFGAvailabilityMap.cpp:

(JSC::DFG::AvailabilityMap::pruneHeap):

  • dfg/DFGCombinedLiveness.cpp:

(JSC::DFG::liveNodesAtHead):
(JSC::DFG::CombinedLiveness::CombinedLiveness):

  • dfg/DFGCombinedLiveness.h:
  • dfg/DFGLivenessAnalysisPhase.cpp:

(JSC::DFG::LivenessAnalysisPhase::run):
(JSC::DFG::LivenessAnalysisPhase::processBlock):

  • dfg/DFGNode.cpp:
  • dfg/DFGNode.h:
  • dfg/DFGObjectAllocationSinkingPhase.cpp:

Source/WTF:

This adds LoggingHashSet and LoggingHashMap, which are drop-in replacements for HashSet and
HashMap that log everything that they do, so that you can replay it later.

This also adds a benchmark (HashSetDFGReplay) based on doing a recording of some of the HashSets
in the DFG compiler.

  • WTF.xcodeproj/project.pbxproj:
  • benchmarks/HashSetDFGReplay.cpp: Added.

(benchmark):
(main):

  • wtf/CMakeLists.txt:
  • wtf/GlobalVersion.cpp: Added.

(WTF::newGlobalVersion):

  • wtf/GlobalVersion.h: Added.
  • wtf/HashMap.h:

(WTF::X>::swap):

  • wtf/HashSet.h:

(WTF::V>::addVoid):

  • wtf/LoggingHashID.h: Added.

(WTF::LoggingHashID::LoggingHashID):
(WTF::LoggingHashID::dump):

  • wtf/LoggingHashMap.h: Added.
  • wtf/LoggingHashSet.h: Added.
  • wtf/LoggingHashTraits.h: Added.

(WTF::LoggingHashKeyTraits::print):
(WTF::LoggingHashValueTraits::print):

2:16 PM Changeset in webkit [213938] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/cors/status.htm as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169625

Unreviewed test gardening.

1:55 PM Changeset in webkit [213937] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603.1.30.0-branch/Source

‘Versioning.’

1:50 PM Changeset in webkit [213936] by jer.noble@apple.com
  • 9 edits in trunk/Source

Make classes used by Media Stream encode/decode friendly
https://bugs.webkit.org/show_bug.cgi?id=169567

Reviewed by Eric Carlson.

Source/WebCore:

Add encode() and decode() methods and implementations to a variety of media stream related classes.

  • platform/audio/mac/CAAudioStreamDescription.h:

(WebCore::CAAudioStreamDescription::encode):
(WebCore::CAAudioStreamDescription::decode):

  • platform/mediastream/RealtimeMediaSourceSettings.h:

(WebCore::RealtimeMediaSourceSettings::width):
(WebCore::RealtimeMediaSourceSettings::setWidth):
(WebCore::RealtimeMediaSourceSettings::height):
(WebCore::RealtimeMediaSourceSettings::setHeight):
(WebCore::RealtimeMediaSourceSettings::sampleRate):
(WebCore::RealtimeMediaSourceSettings::setSampleRate):
(WebCore::RealtimeMediaSourceSettings::sampleSize):
(WebCore::RealtimeMediaSourceSettings::setSampleSize):
(WebCore::RealtimeMediaSourceSettings::encode):
(WebCore::RealtimeMediaSourceSettings::decode):

  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:

(WebCore::RealtimeMediaSourceSupportedConstraints::encode):
(WebCore::RealtimeMediaSourceSupportedConstraints::decode):

Source/WebKit2:

Make the encoder and decoder for MediaConstraintsData a little less wordy.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<MediaConstraintsData>::encode):
(IPC::ArgumentCoder<MediaConstraintsData>::decode):

Source/WTF:

  • wtf/MediaTime.h:

(WTF::MediaTime::encode):
(WTF::MediaTime::decode):

1:45 PM Changeset in webkit [213935] by jer.noble@apple.com
  • 5 edits
    2 adds in trunk/Source

Adapt CARingBuffer to be usable across processes
https://bugs.webkit.org/show_bug.cgi?id=169591

Reviewed by Alex Christensen.

Source/WebCore:

When used with a SharedMemory backing store, storing the pointers to channel data at the beginning
of the channel data itself is problematic: when the SharedMemory is mapped on the far side of the
process boundary, it will not exist at the same memory location as it did on the near side. Instead
of storing these pointers inside the channel data, store them in a small (usually 1 or 2 entry) vector
recreated when the backing store is (re-)allocated.

  • platform/audio/mac/CARingBuffer.cpp:

(WebCore::CARingBuffer::CARingBuffer):
(WebCore::CARingBuffer::allocate):
(WebCore::CARingBuffer::deallocate):
(WebCore::ZeroRange):
(WebCore::StoreABL):
(WebCore::FetchABL):
(WebCore::CARingBuffer::store):
(WebCore::CARingBuffer::getCurrentFrameBounds):
(WebCore::CARingBuffer::fetch):

  • platform/audio/mac/CARingBuffer.h:

Source/WebKit2:

Add a new class which wraps a SharedMemory object and uses that shared memory as the
backing store of a CARingBuffer. This backing store can be set to "read only", which
prevents the backing from being de- or re-allocated.

  • WebKit2.xcodeproj/project.pbxproj:
  • Shared/Cocoa/SharedRingBufferStorage.cpp: Added.

(WebKit::SharedRingBufferStorage::setStorage):
(WebKit::SharedRingBufferStorage::setReadOnly):
(WebKit::SharedRingBufferStorage::allocate):
(WebKit::SharedRingBufferStorage::deallocate):
(WebKit::SharedRingBufferStorage::data):

  • Shared/Cocoa/SharedRingBufferStorage.h: Added.

(WebKit::SharedRingBufferStorage::SharedRingBufferStorage):
(WebKit::SharedRingBufferStorage::invalidate):
(WebKit::SharedRingBufferStorage::storage):
(WebKit::SharedRingBufferStorage::readOnly):

1:07 PM Changeset in webkit [213934] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html as flaky on mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=169621

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:03 PM Changeset in webkit [213933] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebKit2

[iOS] The web process should inherit application state from UI process
https://bugs.webkit.org/show_bug.cgi?id=169156
<rdar://problem/30845473>

Reviewed by Brady Eidson.

Move PID proxy setup to platformInitializeWebProcess as suggested in
post-landing feedback.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformInitialize):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

1:01 PM Changeset in webkit [213932] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Web Inspector: Remove unused Network protocol event
https://bugs.webkit.org/show_bug.cgi?id=169619

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-03-14
Reviewed by Mark Lam.

  • inspector/protocol/Network.json:

This became unused in r213621 and should have been removed
from the protocol file then.

12:57 PM Changeset in webkit [213931] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Pulling more frames from AudioSampleDataSource than the last push added will always fail.
https://bugs.webkit.org/show_bug.cgi?id=168644

Reviewed by Eric Carlson.

Rather than use the delta between the ring buffer's end time and the last pushed timestamp
(or what is effectively the number of samples in the last push operation) to determine if
there is enough buffered data to satisfy a pull operation, use the ring buffer's actual
buffered duration.

Then, instead of saving the last pushed timestamp, explicitly save the last push count, and
use that data to inform how much to offset the output timestamps (or what is effectively how
much to allow the source to pre-buffer).

  • platform/audio/mac/AudioSampleDataSource.cpp:

(WebCore::AudioSampleDataSource::pushSamplesInternal):
(WebCore::AudioSampleDataSource::pullSamplesInternal):

  • platform/audio/mac/AudioSampleDataSource.h:
12:29 PM Changeset in webkit [213930] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add a null check in VMTraps::willDestroyVM() to handle a race condition.
https://bugs.webkit.org/show_bug.cgi?id=169620

Reviewed by Filip Pizlo.

There exists a race between VMTraps::willDestroyVM() (which removed SignalSenders
from its m_signalSenders list) and SignalSender::send() (which removes itself
from the list). In the event that SignalSender::send() removes itself between
the time that VMTraps::willDestroyVM() checks if m_signalSenders is empty and the
time it takes a sender from m_signalSenders, VMTraps::willDestroyVM() may end up
with a NULL sender pointer. The fix is to add the missing null check before using
the sender pointer.

  • runtime/VMTraps.cpp:

(JSC::VMTraps::willDestroyVM):
(JSC::VMTraps::fireTrap):

  • runtime/VMTraps.h:
12:22 PM Changeset in webkit [213929] by megan_gardner@apple.com
  • 4 edits in trunk/Source

Correctly export WebItemProviderPasteboard
https://bugs.webkit.org/show_bug.cgi?id=169578

Reviewed by Tim Horton.

Source/WebCore:

  • platform/ios/WebItemProviderPasteboard.h:

Source/WebKit/mac:

  • MigrateHeaders.make:
12:20 PM Changeset in webkit [213928] by webkit@devinrousso.com
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add support for Timeline graphs
https://bugs.webkit.org/show_bug.cgi?id=169585

Reviewed by Brian Burg.

  • UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:

(WebInspector.HeapAllocationsTimelineOverviewGraph.prototype.layout):
Rework the calculation for the icon offset to use "right" in RTL.

  • UserInterface/Views/MemoryTimelineOverviewGraph.css:

(body[dir=rtl] .timeline-overview-graph.memory > .stacked-line-chart):
Flip the chart when in RTL.

  • UserInterface/Views/TimelineRecordBar.css:

(.timeline-record-bar):
(body[dir=ltr] .timeline-record-bar > .segment.inactive):
(body[dir=rtl] .timeline-record-bar > .segment.inactive):
(body[dir=ltr] .timeline-record-bar.unfinished > .segment):
(body[dir=rtl] .timeline-record-bar.unfinished > .segment):
(body[dir=ltr] .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(body[dir=rtl] .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(body[dir=ltr] :matches(:focus, .force-focus) .selected .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(body[dir=rtl] :matches(:focus, .force-focus) .selected .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(.timeline-record-bar > .segment.inactive,): Deleted.
(.timeline-record-bar.has-inactive-segment > .segment:not(.inactive)): Deleted.
(:matches(:focus, .force-focus) .selected .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)): Deleted.

  • UserInterface/Views/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar.prototype.refresh):
Apply the position updates to "right" in RTL.

  • UserInterface/Views/TimelineRecordFrame.js:

(WebInspector.TimelineRecordFrame.prototype.refresh):
Apply the position updates to "right" in RTL.

  • UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype.layout):
(WebInspector.TimelineRuler.prototype._updatePositionOfElement):
(WebInspector.TimelineRuler.prototype._updateMarkers):
(WebInspector.TimelineRuler.prototype._updateSelection):
Apply the position updates to "right" in RTL.

12:16 PM Changeset in webkit [213927] by Ryan Haddad
  • 6 edits in trunk/Source/WebKit2

Unreviewed, rolling out r213915.

Caused WK2 LayoutTests to exit early with timeouts.

Reverted changeset:

"Fix uninitialized public members in NetworkProcess"
https://bugs.webkit.org/show_bug.cgi?id=169598
http://trac.webkit.org/changeset/213915

12:16 PM Changeset in webkit [213926] by jbedard@apple.com
  • 3 edits in trunk/Tools

webkitpy: Efficient app installation for device testing
https://bugs.webkit.org/show_bug.cgi?id=169054
<rdar://problem/30790207>

Reviewed by Daniel Bates.

We should only install an app on a device once, not every time the app is run.
Move app installation to setup.

  • Scripts/webkitpy/port/ios.py:

(IOSPort.setup_test_run): Install app to device.

  • Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.init): Remove app installation.

12:12 PM Changeset in webkit [213925] by webkit@devinrousso.com
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add support for DataGrid disclosure arrows and indentation
https://bugs.webkit.org/show_bug.cgi?id=169582

Reviewed by Brian Burg.

  • UserInterface/Views/DataGrid.css:

(body[dir=rtl] .data-grid tr.parent td.disclosure::before):
Flip the image in RTL.

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype._updateScrollbarPadding):
Rework the padding calculation for the scrollbar offset to use "right" in RTL.

  • UserInterface/Views/DataGridNode.js:

(WebInspector.DataGridNode.prototype.get indentPadding):
(WebInspector.DataGridNode.prototype.createCell):
Rework the padding calculation for indenting (as a child) to use "right" in RTL.

(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle):
Calculate the position of the ::before triangle based on the layout direction.

(WebInspector.DataGridNode.prototype.get leftPadding): Deleted.

12:07 PM Changeset in webkit [213924] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add support for TimelineOverview sidebar and container layout
https://bugs.webkit.org/show_bug.cgi?id=169583

Reviewed by Brian Burg.

  • UserInterface/Views/TimelineOverview.css:

(body[dir=ltr] .timeline-overview > :matches(.navigation-bar.timelines, .tree-outline.timelines)):
(body[dir=rtl] .timeline-overview > :matches(.navigation-bar.timelines, .tree-outline.timelines)):
(body[dir=ltr] .timeline-overview:not(.frames) > :matches(.scroll-container, .timeline-ruler, .graphs-container)):
(body[dir=rtl] .timeline-overview:not(.frames) > :matches(.scroll-container, .timeline-ruler, .graphs-container)):
(.timeline-overview > .navigation-bar.timelines):
(.timeline-overview > .tree-outline.timelines):
(.timeline-overview > .scroll-container):
(.timeline-overview > .timeline-ruler):
(.timeline-overview > .graphs-container):
(.timeline-overview > .scroll-container > .scroll-width-sizer):
(body[dir=ltr] .timeline-overview > .scroll-container > .scroll-width-sizer):
(body[dir=rtl] .timeline-overview > .scroll-container > .scroll-width-sizer):
(.timeline-overview.frames > .graphs-container): Deleted.

11:53 AM Changeset in webkit [213923] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove redundant check for "firstLine" in RenderBlock::lineHeight()
https://bugs.webkit.org/show_bug.cgi?id=169610

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-03-14
Reviewed by Michael Catanzaro.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight): Remove test of "firstLine" that
was already checked in the condition for the enclosing if-clause.

11:36 AM Changeset in webkit [213922] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.12

Tag Safari-604.1.12.

11:35 AM Changeset in webkit [213921] by jmarcell@apple.com
  • 7 edits in trunk/Source

Versioning.

11:29 AM Changeset in webkit [213920] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk

[Modern Media Controls] Fullscreen controls during Live Broadcast is completely broken
https://bugs.webkit.org/show_bug.cgi?id=169354
<rdar://problem/30636370>

Patch by Antoine Quint <Antoine Quint> on 2017-03-14
Reviewed by Dean Jackson.

Source/WebCore:

When playing a Live Broadcast video in fullscreen, we should not show any scrubbing-related
piece of UI and ensure that we show the status label.

Test: http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html

  • Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:

(.media-controls.mac.fullscreen > .controls-bar .status-label):

  • Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:

(MacOSFullscreenMediaControls.prototype.layout):

  • Modules/modern-media-controls/media/seek-support.js:

(SeekSupport.prototype.get mediaEvents):
(SeekSupport.prototype.syncControl):

LayoutTests:

Add a new test, skipped on iOS, to check scrubbing controls are disabled in fullscreen
for a Live Broadcast video and that the status label is visible. We also rebaseline a
couple of tests now that the time control is added on first layout instead of inside
the constructor.

  • http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast-expected.txt: Added.
  • http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html: Added.
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles.html:
  • platform/ios-simulator/TestExpectations:
11:24 AM Changeset in webkit [213919] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip 12 web-platform-tests until wptserver is upgraded.
https://bugs.webkit.org/show_bug.cgi?id=169615

Unreviewed test gardening.

11:22 AM Changeset in webkit [213918] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Nwtr ignores ImageDiff's errors for ref tests
https://bugs.webkit.org/show_bug.cgi?id=168033

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-14
Reviewed by Alexey Proskuryakov.

Nwtr checks ImageDiff's errors only for pixel tests, but for ref
tests. Those errors of ref tests also should be checked.

In the current implementation of expected mismatch ref tests,
diff_image was called if the image hashes match. This is useless
because two images are ensured identical in that case. Calling
image_hash is considered unnecessary for expected mismatch ref
tests. Do not call diff_image for them.

As the result, check the error only for expected match ref tests.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._compare_image): Rename a variable 'err_str' to 'error_string'.
(SingleTestRunner._compare_output_with_reference): Do not call
diff_image for expected mismatch ref tests. Check the error and
marked the test failed for expected match ref tests.

11:19 AM Changeset in webkit [213917] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Web Inspector: More accurate Resource Timing data in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=169577

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-03-14
Reviewed by Youenn Fablet.

Source/WebCore:

  • inspector/InspectorNetworkAgent.h:
  • inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::didFinishLoading):
Use the ResourceLoader to get the start time that responseEnd is relative to
so we can send the more accurate responseEnd when available.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishLoadingImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didFinishLoading):

  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):

  • loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::didFinishLoad):
(WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):

  • loader/ResourceLoadNotifier.h:
  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoading):
Pass ResourceLoader through to Web Inspector in didFinishLoading.

  • platform/network/cocoa/NetworkLoadMetrics.mm:

(WebCore::copyTimingData):
The differences from the reference start are in Seconds, not milliseconds.

Source/WebInspectorUI:

  • UserInterface/Models/ResourceTimingData.js:

(WebInspector.ResourceTimingData.prototype.get requestStart):
(WebInspector.ResourceTimingData.prototype.get responseStart):
Fallback to the startTime if available instead of using the
inaccurate WebContentProcess gathered timestamps.

(WebInspector.ResourceTimingData.prototype.markResponseEndTime):
Verify responseEnd compared to other times we may have.

10:58 AM Changeset in webkit [213916] by beidson@apple.com
  • 4 edits in trunk

REGRESSION (r213877): WebKit2.CookieManager fails.
https://bugs.webkit.org/show_bug.cgi?id=169581

Reviewed by Tim Horton.

Source/WebKit2:

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::processPoolDestroyed): Invalidate the new sets of callbacks.
(WebKit::WebCookieManagerProxy::processDidClose): Ditto.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Reenable the test.
10:39 AM Changeset in webkit [213915] by tpopela@redhat.com
  • 6 edits in trunk/Source/WebKit2

Fix uninitialized public members in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=169598

Reviewed by Alex Christensen.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):

  • UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

10:30 AM Changeset in webkit [213914] by commit-queue@webkit.org
  • 6 edits
    53 adds in trunk/LayoutTests

Import web-platform-tests/cors
https://bugs.webkit.org/show_bug.cgi?id=169565

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-14
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/cors/304-expected.txt: Added.
  • web-platform-tests/cors/304.htm: Added.
  • web-platform-tests/cors/OWNERS: Added.
  • web-platform-tests/cors/README.md: Added.
  • web-platform-tests/cors/allow-headers-expected.txt: Added.
  • web-platform-tests/cors/allow-headers.htm: Added.
  • web-platform-tests/cors/basic-expected.txt: Added.
  • web-platform-tests/cors/basic.htm: Added.
  • web-platform-tests/cors/credentials-flag-expected.txt: Added.
  • web-platform-tests/cors/credentials-flag.htm: Added.
  • web-platform-tests/cors/late-upload-events-expected.txt: Added.
  • web-platform-tests/cors/late-upload-events.htm: Added.
  • web-platform-tests/cors/origin-expected.txt: Added.
  • web-platform-tests/cors/origin.htm: Added.
  • web-platform-tests/cors/preflight-cache-expected.txt: Added.
  • web-platform-tests/cors/preflight-cache.htm: Added.
  • web-platform-tests/cors/preflight-failure-expected.txt: Added.
  • web-platform-tests/cors/preflight-failure.htm: Added.
  • web-platform-tests/cors/redirect-origin-expected.txt: Added.
  • web-platform-tests/cors/redirect-origin.htm: Added.
  • web-platform-tests/cors/redirect-preflight-2-expected.txt: Added.
  • web-platform-tests/cors/redirect-preflight-2.htm: Added.
  • web-platform-tests/cors/redirect-preflight-expected.txt: Added.
  • web-platform-tests/cors/redirect-preflight.htm: Added.
  • web-platform-tests/cors/redirect-userinfo-expected.txt: Added.
  • web-platform-tests/cors/redirect-userinfo.htm: Added.
  • web-platform-tests/cors/remote-origin-expected.txt: Added.
  • web-platform-tests/cors/remote-origin.htm: Added.
  • web-platform-tests/cors/request-headers-expected.txt: Added.
  • web-platform-tests/cors/request-headers.htm: Added.
  • web-platform-tests/cors/resources/304.py: Added.

(error):
(main):

  • web-platform-tests/cors/resources/checkandremove.py: Added.

(main):

  • web-platform-tests/cors/resources/cors-cookie.py: Added.

(main):

  • web-platform-tests/cors/resources/cors-headers.asis: Added.
  • web-platform-tests/cors/resources/cors-makeheader.py: Added.

(main):

  • web-platform-tests/cors/resources/preflight.py: Added.

(main):

  • web-platform-tests/cors/resources/remote-xhrer.html: Added.
  • web-platform-tests/cors/resources/status.py: Added.

(main):

  • web-platform-tests/cors/resources/w3c-import.log: Added.
  • web-platform-tests/cors/response-headers-expected.txt: Added.
  • web-platform-tests/cors/response-headers.htm: Added.
  • web-platform-tests/cors/simple-requests-expected.txt: Added.
  • web-platform-tests/cors/simple-requests.htm: Added.
  • web-platform-tests/cors/status-async-expected.txt: Added.
  • web-platform-tests/cors/status-async.htm: Added.
  • web-platform-tests/cors/status-expected.txt: Added.
  • web-platform-tests/cors/status-preflight-expected.txt: Added.
  • web-platform-tests/cors/status-preflight.htm: Added.
  • web-platform-tests/cors/status.htm: Added.
  • web-platform-tests/cors/support.js: Added.

(dirname):

  • web-platform-tests/cors/w3c-import.log: Added.

LayoutTests:

  • tests-options.json:
10:21 AM Changeset in webkit [213913] by adachan@apple.com
  • 2 edits
    2 adds in trunk/Source/WebKit2

[Mac] Add API to get the NSURLProtectionSpace from WKProtectionSpaceRef
https://bugs.webkit.org/show_bug.cgi?id=169494
<rdar://problem/11872163>

Reviewed by Dan Bernstein.

  • UIProcess/API/C/mac/WKProtectionSpaceNS.h: Added.
  • UIProcess/API/C/mac/WKProtectionSpaceNS.mm: Added.

(WKProtectionSpaceCopyNSURLProtectionSpace):

  • WebKit2.xcodeproj/project.pbxproj:
10:13 AM Changeset in webkit [213912] by matthew_hanson@apple.com
  • 4 edits in branches/safari-603-branch/Source/WebCore

Roll out r212554 via r212893. rdar://problem/30812551

10:13 AM Changeset in webkit [213911] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/Source/JavaScriptCore

rdar://problem/30675867

10:13 AM Changeset in webkit [213910] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/Source/WebCore

rdar://problem/30657889

10:13 AM Changeset in webkit [213909] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603-branch/Source/WebCore

Merge r213211. rdar://problem/30742143

10:13 AM Changeset in webkit [213908] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/Source/WebCore

Merge r212822. rdar://problem/30682429

10:13 AM Changeset in webkit [213907] by matthew_hanson@apple.com
  • 19 edits in branches/safari-603-branch

Roll out r212459 via r212537. rdar://problem/30699480

10:13 AM Changeset in webkit [213906] by matthew_hanson@apple.com
  • 1 edit in branches/safari-603-branch/Source/WebCore/ChangeLog

Merge r212828. rdar://problem/30636288

10:13 AM Changeset in webkit [213905] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/Source

Merge r212692. rdar://problem/30635854

10:02 AM Changeset in webkit [213904] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: Speculative build fix for CLoop after r213886.
https://bugs.webkit.org/show_bug.cgi?id=169436

Not reviewed.

  • runtime/MachineContext.h:
10:01 AM Changeset in webkit [213903] by wenson_hsieh@apple.com
  • 6 edits in trunk/Source/WebKit2

[WK2] Adopt updated data operation interfaces for data interaction
https://bugs.webkit.org/show_bug.cgi?id=169414
<rdar://problem/30948186>

Reviewed by Tim Horton.

Plumb additional information about the data interaction caret over to the UI process after handling a data
interaction action in the web process.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didPerformDragControllerAction):
(WebKit::WebPageProxy::resetCurrentDragInformation):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::currentDragCaretRect):
(WebKit::WebPageProxy::resetCurrentDragInformation): Deleted.

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/WKContentViewInteraction.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

10:01 AM Changeset in webkit [213902] by wenson_hsieh@apple.com
  • 21 edits in trunk

[WK2] Data interaction tests occasionally hit assertions in debug builds
https://bugs.webkit.org/show_bug.cgi?id=169002
<rdar://problem/30994806>

Reviewed by Tim Horton.

Source/WebCore:

Data interaction unit tests occasionally fail due to the UI process expecting the latest received EditorState to
contain post layout data, but finding that it does not in -[WKContentView selectedTextRange]. The incomplete
EditorStates in question are sent while performing a data interaction operation, due to transient changes in the
frame selection. The UI process does not need to (and should not) be informed of these selection changes at all.

We can fix this by preventing the editor client from responding to selection changes during data interaction
operation. This patch also renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges to better
reflect the fact that it is used outside of the context of holding selection change updates during IME. We
already use this affordance in various places, such as TextIndicator (while taking a snapshot on iOS), in
FindController on iOS, and when replacing selected or dictated text. Additionally, there is no logic in
setIgnoreCompositionSelectionChange that limits its use to composition.

  • editing/Editor.cpp:

(WebCore::Editor::cancelCompositionIfSelectionIsInvalid):
(WebCore::Editor::setComposition):
(WebCore::Editor::revealSelectionAfterEditingOperation):
(WebCore::Editor::setIgnoreSelectionChanges):
(WebCore::Editor::changeSelectionAfterCommand):
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::setIgnoreCompositionSelectionChange): Deleted.

  • editing/Editor.h:

(WebCore::Editor::ignoreSelectionChanges):
(WebCore::Editor::ignoreCompositionSelectionChange): Deleted.

  • editing/mac/EditorMac.mm:

(WebCore::Editor::selectionWillChange):

  • page/TextIndicator.cpp:

(WebCore::TextIndicator::createWithRange):

Source/WebKit/mac:

Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateSelectionForInputManager]):

  • WebView/WebView.mm:

(-[WebView updateTextTouchBar]):

Source/WebKit2:

Renames setIgnoreCompositionSelectionChange to setIgnoreSelectionChanges. See WebCore ChangeLog for more details.

  • Shared/EditorState.cpp:

(WebKit::EditorState::encode):
(WebKit::EditorState::decode):

  • Shared/EditorState.h:
  • UIProcess/gtk/WebPageProxyGtk.cpp:
  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::editorStateChanged):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::editorStateChanged):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):
(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::setComposition):
(WebKit::WebPage::didChangeSelection):

  • WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::setSelectionChangeUpdatesEnabledInAllFrames):
(WebKit::FindController::willFindString):
(WebKit::FindController::didFailToFindString):
(WebKit::FindController::didHideFindIndicator):
(WebKit::setCompositionSelectionChangeEnabledInAllFrames): Deleted.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateSelectionAppearance):
(WebKit::WebPage::replaceSelectedText):
(WebKit::WebPage::replaceDictatedText):

Tools:

Reenables and refactors data interaction tests.

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
  • TestWebKitAPI/ios/DataInteractionSimulator.h:
  • TestWebKitAPI/ios/DataInteractionSimulator.mm:

(-[DataInteractionSimulator _resetSimulatedState]):
(-[DataInteractionSimulator runFrom:to:]):
(-[DataInteractionSimulator _advanceProgress]):

9:59 AM Changeset in webkit [213901] by Yusuke Suzuki
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] Drop unnecessary pthread_attr_t for JIT enabled Linux / FreeBSD environment
https://bugs.webkit.org/show_bug.cgi?id=169592

Reviewed by Carlos Garcia Campos.

Since suspended mcontext_t has all the necessary information, we can drop
pthread_attr_t allocation and destroy for JIT enabled Linux / FreeBSD environment.

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::Thread::getRegisters):
(JSC::MachineThreads::Thread::Registers::stackPointer):
(JSC::MachineThreads::Thread::Registers::framePointer):
(JSC::MachineThreads::Thread::Registers::instructionPointer):
(JSC::MachineThreads::Thread::Registers::llintPC):
(JSC::MachineThreads::Thread::freeRegisters):

  • heap/MachineStackMarker.h:
9:16 AM Changeset in webkit [213900] by commit-queue@webkit.org
  • 5 edits in trunk

[Modern Media Controls] iOS may attempt to load fullscreen icon variants
https://bugs.webkit.org/show_bug.cgi?id=169608
<rdar://problem/31037369>

Patch by Antoine Quint <Antoine Quint> on 2017-03-14
Reviewed by Eric Carlson.

Source/WebCore:

Only return fullscreen or compact variants for macOS.

  • Modules/modern-media-controls/controls/icon-service.js:

(const.iconService.new.IconService.prototype._fileNameAndPlatformForIconNameAndLayoutTraits):
(const.iconService.new.IconService):

LayoutTests:

Amend an existing test to check that we disregard fullscreen and compact variants on iOS.

  • media/modern-media-controls/icon-service/icon-service-expected.txt:
  • media/modern-media-controls/icon-service/icon-service.html:
9:13 AM Changeset in webkit [213899] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[Modern Media Controls] Controls are laid out incorrectly with RTL languages
https://bugs.webkit.org/show_bug.cgi?id=169605
<rdar://problem/30975709>

Patch by Antoine Quint <Antoine Quint> on 2017-03-14
Reviewed by Eric Carlson.

Source/WebCore:

Encorce "direction: ltr" on the controls since the controls layout should not be changed
by the host page's direction.

Test: media/modern-media-controls/media-controls/media-controls-controls-bar-always-ltr.html

  • Modules/modern-media-controls/controls/controls-bar.css:

(.controls-bar):

LayoutTests:

Add a test that enforces "direction: rtl" on a parent element to check that the controls
bar use "direction: ltr" anyway.

  • media/modern-media-controls/media-controls/media-controls-controls-bar-always-ltr-expected.txt: Added.
  • media/modern-media-controls/media-controls/media-controls-controls-bar-always-ltr.html: Added.
8:52 AM Changeset in webkit [213898] by beidson@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r213877): WebKit2.CookieManager fails.
https://bugs.webkit.org/show_bug.cgi?id=169581

Unreviewed gardening

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Skip for now until I can fix.
8:11 AM Changeset in webkit [213897] by wenson_hsieh@apple.com
  • 7 edits
    3 adds in trunk

Make RepaintRegionAccumulator hold a WeakPtr to its root RenderView
https://bugs.webkit.org/show_bug.cgi?id=168480
<rdar://problem/30566976>

Reviewed by Antti Koivisto.

Source/WebCore:

Implements two mitigations to prevent the symptoms of the bug from occurring (see the bugzilla for more details).

Test: editing/execCommand/show-modal-dialog-during-execCommand.html

  • editing/EditorCommand.cpp:

(WebCore::Editor::Command::execute):

Do not allow edit commands to execute if the frame's document before and after layout differ (that is, edit commands
triggered by a certain document should not run on a different document).

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator):

Turns RepaintRegionAccumulator's reference to its root RenderView into a WeakPtr to gracefully handle the case
where its RenderView is destroyed before RepaintRegionAccumulator's destructor gets a chance to flush the
RenderView's repaint regions.

  • rendering/RenderView.h:

LayoutTests:

Introduces a new layout test. See WebCore ChangeLog for more details.

  • TestExpectations:
  • editing/execCommand/show-modal-dialog-during-execCommand-expected.txt: Added.
  • editing/execCommand/show-modal-dialog-during-execCommand.html: Added.
  • editing/execCommand/resources/self-closing-modal-dialog.html: Added.
  • platform/mac-wk1/TestExpectations:
6:20 AM Changeset in webkit [213896] by Yusuke Suzuki
  • 7 edits in trunk

Source/WTF:
Add secondsAs<T> methods to Seconds to convert it to integers with clamp
https://bugs.webkit.org/show_bug.cgi?id=169537

Reviewed by Carlos Garcia Campos.

When using the usual static_cast, infinity becomes 0 accidentally.
It is not intended value when using Seconds for timeout value.
Instead, we use clampToAccepting64 to convert Seconds to
integer values to pass them to the system functions.

  • wtf/MathExtras.h:

(clampToAccepting64):

  • wtf/Seconds.h:

(WTF::Seconds::minutesAs):
(WTF::Seconds::secondsAs):
(WTF::Seconds::millisecondsAs):
(WTF::Seconds::microsecondsAs):
(WTF::Seconds::nanosecondsAs):

  • wtf/cocoa/WorkQueueCocoa.cpp:

(WTF::WorkQueue::dispatchAfter):

  • wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::dispatchAfter):
(WTF::RunLoop::TimerBase::updateReadyTime):

Tools:
[WTF] Clean up RunLoop and WorkQueue with Seconds and Function
https://bugs.webkit.org/show_bug.cgi?id=169537

Reviewed by Carlos Garcia Campos.

  • TestWebKitAPI/Tests/WTF/Time.cpp:

(TestWebKitAPI::TEST):

2:01 AM Changeset in webkit [213895] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.15.92

WebKitGTK+ 2.15.92

2:01 AM Changeset in webkit [213894] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.16

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.15.92 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.15.92.
1:30 AM Changeset in webkit [213893] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[GLib] Use USE(GLIB) guards in WebCore/workers/
https://bugs.webkit.org/show_bug.cgi?id=169595

Reviewed by Carlos Garcia Campos.

Utilize the USE(GLIB) build guards in the WorkerRunLoop and WorkerThread
class implementations to guard GLib-specific header inclusions and GLib
API invocations, instead of the more specific PLATFORM(GTK) guards.

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

1:29 AM Changeset in webkit [213892] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

[GLib] Use USE(GLIB) guards in JavaScriptCore/inspector/EventLoop.cpp
https://bugs.webkit.org/show_bug.cgi?id=169594

Reviewed by Carlos Garcia Campos.

Instead of PLATFORM(GTK) guards, utilize the USE(GLIB) build guards
to guard the GLib-specific includes and invocations in the JSC
inspector's EventLoop class implementation.

  • inspector/EventLoop.cpp:

(Inspector::EventLoop::cycle):

1:28 AM Changeset in webkit [213891] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[Soup] Suppress compiler warnings in NetworkStorageSession
https://bugs.webkit.org/show_bug.cgi?id=169593

Reviewed by Carlos Garcia Campos.

Return default-constructed Vector objects in the NetworkStorageSession's
getAllCookies() and getCookies() methods, avoiding compiler warnings.

  • platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::getAllCookies):
(WebCore::NetworkStorageSession::getCookies):

1:28 AM Changeset in webkit [213890] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unnecessary assert for Number.percentageString
https://bugs.webkit.org/show_bug.cgi?id=169589

Reviewed by Matt Baker.

  • UserInterface/Base/Utilities.js:

(Number.percentageString):

1:22 AM Changeset in webkit [213889] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r213888 - Unreviewed. Fix syntax error in GTK+ API docs.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):

1:21 AM Changeset in webkit [213888] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix syntax error in GTK+ API docs.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):

12:57 AM Changeset in webkit [213887] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: allow the user to copy locked CSS selectors in Style - Rules
https://bugs.webkit.org/show_bug.cgi?id=169587

Reviewed by Matt Baker.

  • UserInterface/Views/CSSStyleDeclarationSection.css:

(.style-declaration-section:matches(.locked, .selector-locked) > .header > .selector):

12:33 AM Changeset in webkit [213886] by Yusuke Suzuki
  • 12 edits
    1 add in trunk/Source

[JSC][Linux] Implement VMTrap in Linux ports
https://bugs.webkit.org/show_bug.cgi?id=169436

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch port VMTrap to Linux ports.
We extract MachineContext accessors from various places (wasm/, heap/ and tools/)
and use them in all the JSC code.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::Thread::Registers::stackPointer):
(JSC::MachineThreads::Thread::Registers::framePointer):
(JSC::MachineThreads::Thread::Registers::instructionPointer):
(JSC::MachineThreads::Thread::Registers::llintPC):

  • heap/MachineStackMarker.h:
  • runtime/MachineContext.h: Added.

(JSC::MachineContext::stackPointer):
(JSC::MachineContext::framePointer):
(JSC::MachineContext::instructionPointer):
(JSC::MachineContext::argumentPointer<1>):
(JSC::MachineContext::argumentPointer):
(JSC::MachineContext::llintInstructionPointer):

  • runtime/PlatformThread.h:

(JSC::platformThreadSignal):

  • runtime/VMTraps.cpp:

(JSC::SignalContext::SignalContext):
(JSC::SignalContext::adjustPCToPointToTrappingInstruction):

  • tools/CodeProfiling.cpp:

(JSC::profilingTimer):

  • tools/SigillCrashAnalyzer.cpp:

(JSC::SignalContext::SignalContext):
(JSC::SignalContext::dump):

  • tools/VMInspector.cpp:
  • wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):

Source/WTF:

Enable VMTrap mechanism for Linux and FreeBSD.

  • wtf/Platform.h:

Mar 13, 2017:

11:51 PM Changeset in webkit [213885] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove unused methods of ResourceRequestBase
https://bugs.webkit.org/show_bug.cgi?id=169579

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-03-13
Reviewed by Youenn Fablet.

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::reportUploadProgress): Deleted.
(WebCore::ResourceRequestBase::setReportUploadProgress): Deleted.
(WebCore::ResourceRequestBase::reportLoadTiming): Deleted.
(WebCore::ResourceRequestBase::setReportLoadTiming): Deleted.
(WebCore::ResourceRequestBase::reportRawHeaders): Deleted.
(WebCore::ResourceRequestBase::setReportRawHeaders): Deleted.
Remove unused code.

  • inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::willSendRequest):

  • loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):
Remove callers of setters that did nothing.

10:58 PM Changeset in webkit [213884] by commit-queue@webkit.org
  • 20 edits in trunk/Source/WebCore

Make RealtimeMediaSource::type an enum class
https://bugs.webkit.org/show_bug.cgi?id=169491

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-13
Reviewed by Sam Weinig.

No change of behavior.

  • Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::Source):

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::getAudioTracks):
(WebCore::MediaStream::getVideoTracks):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::kind):

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::addTrack):

  • Modules/webaudio/MediaStreamAudioSource.cpp:

(WebCore::MediaStreamAudioSource::MediaStreamAudioSource):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::sampleBufferUpdated):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):

  • platform/mediastream/CaptureDeviceManager.cpp:

(CaptureDeviceManager::bestSourcesForTypeAndConstraints):
(CaptureDeviceManager::sourceWithUID):

  • platform/mediastream/MediaEndpoint.cpp:
  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/AVAudioCaptureSource.mm:

(WebCore::AVAudioCaptureSource::AVAudioCaptureSource):

  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::createMediaStream):

  • platform/mock/MockMediaEndpoint.cpp:

(WebCore::MockMediaEndpoint::createMutedRemoteSource):

  • platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::MockRealtimeAudioSource):

  • platform/mock/MockRealtimeMediaSource.cpp:

(WebCore::MockRealtimeMediaSource::MockRealtimeMediaSource):

  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):

5:39 PM Changeset in webkit [213883] by mark.lam@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Make the HeapVerifier useful again.
https://bugs.webkit.org/show_bug.cgi?id=161752

Reviewed by Filip Pizlo.

Resurrect the HeapVerifier. Here's what the verifier now offers:

  1. It captures the list of cells before and after GCs up to N GC cycles. N is set by JSC_numberOfGCCyclesToRecordForVerification. Currently, N defaults to 3.

This is useful if we're debugging in lldb and want to check if a candidate
cell pointer was observed by the GC during the last N GC cycles. We can do
this check buy calling HeapVerifier::checkIfRecorded() with the cell address.

HeapVerifier::checkIfRecorded() is robust and can be used on bogus addresses.
If the candidate cell was previously recorded by the HeapVerifier during a
GC cycle, checkIfRecorded() will dump any useful info it has on that cell.

  1. The HeapVerifier will verify that cells in its captured list after a GC are sane. Some examples of cell insanity are:
    • the cell claims to belong to a different VM.
    • the cell has a NULL structureID.
    • the cell has a NULL structure.
    • the cell's structure has a NULL structureID.
    • the cell's structure has a NULL structure.
    • the cell's structure's structure has a NULL structureID.
    • the cell's structure's structure has a NULL structure.

These are all signs of corruption or a GC bug. The verifier will report any
insanity it finds, and then crash with a RELEASE_ASSERT.

  1. Since the HeapVerifier captures list of cells in the heap before and after GCs for the last N GCs, it will also automatically "trim" dead cells those list after the most recent GC.

"trim" here means that the CellProfile in the HeapVerifier's lists will be
updated to reflect that the cell is now dead. It still keeps a record of the
dead cell pointer and the meta data collected about it back when it was alive.
As a result, checkIfRecorded() will also report if the candidate cell passed
to it is a dead object from a previous GC cycle.

  1. Each CellProfile captured by the HeapVerifier now track the following info:
    • the cell's HeapCell::Kind.
    • the cell's liveness.
    • if is JSCell, the cell's classInfo()->className.
    • an associated timestamp.
    • an associated stack trace.

Currently, the timestamp is only used for the time when the cell was recorded
by the HeapVerifier during GC. The stack trace is currently unused.

However, these fields are kept there so that we can instrument the VM (during
a debugging session, which requires rebuilding the VM) and record interesting
stack traces like that of the time of allocation of the cell. Since
capturing the stack traces for each cell is a very heavy weight operation,
the HeapVerifier code does not do this by default. Instead, we just leave
the building blocks for doing so in place to ease future debugging efforts.

  • heap/Heap.cpp:

(JSC::Heap::runBeginPhase):
(JSC::Heap::runEndPhase):
(JSC::Heap::didFinishCollection):

  • heap/Heap.h:

(JSC::Heap::verifier):

  • heap/MarkedAllocator.h:

(JSC::MarkedAllocator::takeLastActiveBlock): Deleted.

  • heap/MarkedSpace.h:
  • heap/MarkedSpaceInlines.h:

(JSC::MarkedSpace::forEachLiveCell):

  • tools/CellList.cpp:

(JSC::CellList::find):
(JSC::CellList::reset):
(JSC::CellList::findCell): Deleted.

  • tools/CellList.h:

(JSC::CellList::CellList):
(JSC::CellList::name):
(JSC::CellList::size):
(JSC::CellList::cells):
(JSC::CellList::add):
(JSC::CellList::reset): Deleted.

  • tools/CellProfile.h:

(JSC::CellProfile::CellProfile):
(JSC::CellProfile::cell):
(JSC::CellProfile::jsCell):
(JSC::CellProfile::isJSCell):
(JSC::CellProfile::kind):
(JSC::CellProfile::isLive):
(JSC::CellProfile::isDead):
(JSC::CellProfile::setIsLive):
(JSC::CellProfile::setIsDead):
(JSC::CellProfile::timestamp):
(JSC::CellProfile::className):
(JSC::CellProfile::stackTrace):
(JSC::CellProfile::setStackTrace):

  • tools/HeapVerifier.cpp:

(JSC::HeapVerifier::startGC):
(JSC::HeapVerifier::endGC):
(JSC::HeapVerifier::gatherLiveCells):
(JSC::trimDeadCellsFromList):
(JSC::HeapVerifier::trimDeadCells):
(JSC::HeapVerifier::printVerificationHeader):
(JSC::HeapVerifier::verifyCellList):
(JSC::HeapVerifier::validateCell):
(JSC::HeapVerifier::validateJSCell):
(JSC::HeapVerifier::verify):
(JSC::HeapVerifier::reportCell):
(JSC::HeapVerifier::checkIfRecorded):
(JSC::HeapVerifier::initializeGCCycle): Deleted.
(JSC::GatherCellFunctor::GatherCellFunctor): Deleted.
(JSC::GatherCellFunctor::visit): Deleted.
(JSC::GatherCellFunctor::operator()): Deleted.
(JSC::HeapVerifier::verifyButterflyIsInStorageSpace): Deleted.

  • tools/HeapVerifier.h:

(JSC::HeapVerifier::GCCycle::reset):

5:38 PM Changeset in webkit [213882] by commit-queue@webkit.org
  • 238 edits
    14 copies
    1 move
    192 adds
    1 delete in trunk/LayoutTests

Sync web-platform-tests up to revision a5b95cb31914507088a4eda16f7674bbc6f3313f
https://bugs.webkit.org/show_bug.cgi?id=169523

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-13
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • csswg-test/LICENSE.md: Added.
  • csswg-test/README.md:
  • csswg-test/build-css-testsuites.sh: Added.
  • csswg-test/config.default.json: Added.
  • csswg-test/css-grid-1/grid-items/w3c-import.log:
  • csswg-test/css-grid-1/grid-model/w3c-import.log:
  • csswg-test/css-scoping-1/OWNERS: Added.
  • csswg-test/css-scoping-1/css-scoping-shadow-slot-style-expected.html: Added.
  • csswg-test/css-scoping-1/css-scoping-shadow-slot-style.html: Added.
  • csswg-test/css-scoping-1/w3c-import.log:
  • csswg-test/lint: Added.
  • csswg-test/lint.whitelist: Added.
  • csswg-test/manifest: Added.
  • csswg-test/requirements.txt: Added.
  • csswg-test/serve: Added.
  • csswg-test/serve.py: Added.

(main):

  • csswg-test/w3c-import.log:
  • resources/TestRepositories:
  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/IndexedDB/abort-in-initial-upgradeneeded.html:
  • web-platform-tests/IndexedDB/close-in-upgradeneeded.html:
  • web-platform-tests/IndexedDB/event-dispatch-active-flag-expected.txt: Added.
  • web-platform-tests/IndexedDB/event-dispatch-active-flag.html: Added.
  • web-platform-tests/IndexedDB/fire-error-event-exception-expected.txt: Added.
  • web-platform-tests/IndexedDB/fire-error-event-exception.html: Added.
  • web-platform-tests/IndexedDB/fire-success-event-exception-expected.txt: Added.
  • web-platform-tests/IndexedDB/fire-success-event-exception.html: Added.
  • web-platform-tests/IndexedDB/fire-upgradeneeded-event-exception-expected.txt: Added.
  • web-platform-tests/IndexedDB/fire-upgradeneeded-event-exception.html: Added.
  • web-platform-tests/IndexedDB/idb-binary-key-roundtrip.htm:
  • web-platform-tests/IndexedDB/idbcursor_continue_objectstore.htm:
  • web-platform-tests/IndexedDB/idbfactory-deleteDatabase-opaque-origin-expected.txt: Added.
  • web-platform-tests/IndexedDB/idbfactory-deleteDatabase-opaque-origin.html: Added.
  • web-platform-tests/IndexedDB/idbfactory-open-error-properties-expected.txt: Added.
  • web-platform-tests/IndexedDB/idbfactory-open-error-properties.html: Added.
  • web-platform-tests/IndexedDB/idbfactory-open-opaque-origin-expected.txt: Added.
  • web-platform-tests/IndexedDB/idbfactory-open-opaque-origin.html: Added.
  • web-platform-tests/IndexedDB/idbfactory_deleteDatabase4-expected.txt:
  • web-platform-tests/IndexedDB/idbfactory_deleteDatabase4.htm:
  • web-platform-tests/IndexedDB/idbindex_get.htm:
  • web-platform-tests/IndexedDB/idbindex_get4.htm:
  • web-platform-tests/IndexedDB/idbindex_getKey4.htm:
  • web-platform-tests/IndexedDB/idbobjectstore_createIndex13.htm:
  • web-platform-tests/IndexedDB/idbobjectstore_get4.htm:
  • web-platform-tests/IndexedDB/idbobjectstore_getKey.html:
  • web-platform-tests/IndexedDB/key-conversion-exceptions.htm:
  • web-platform-tests/IndexedDB/keygenerator-explicit-expected.txt: Added.
  • web-platform-tests/IndexedDB/keygenerator-explicit.html: Added.
  • web-platform-tests/IndexedDB/keygenerator-inject-expected.txt: Added.
  • web-platform-tests/IndexedDB/keygenerator-inject.html: Added.
  • web-platform-tests/IndexedDB/keypath_invalid.htm:
  • web-platform-tests/IndexedDB/support.js:

(auto_fail):
(createdb_for_multiple_tests):
(indexeddb_test):
(is_transaction_active):
(spin):
(keep_alive):

  • web-platform-tests/IndexedDB/transaction-abort-request-error-expected.txt: Added.
  • web-platform-tests/IndexedDB/transaction-abort-request-error.html: Added.
  • web-platform-tests/IndexedDB/transaction-deactivation-timing-expected.txt: Added.
  • web-platform-tests/IndexedDB/transaction-deactivation-timing.html: Added.
  • web-platform-tests/IndexedDB/transaction-lifetime-blocked.htm:
  • web-platform-tests/IndexedDB/transaction-lifetime.htm:
  • web-platform-tests/IndexedDB/upgrade-transaction-deactivation-timing-expected.txt: Added.
  • web-platform-tests/IndexedDB/upgrade-transaction-deactivation-timing.html: Added.
  • web-platform-tests/IndexedDB/w3c-import.log:
  • web-platform-tests/IndexedDB/writer-starvation.htm:
  • web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2-expected.txt:
  • web-platform-tests/WebCryptoAPI/import_export/symmetric_importKey.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/import_export/test_symmetric_importKey-expected.txt:
  • web-platform-tests/XMLHttpRequest/OWNERS:
  • web-platform-tests/XMLHttpRequest/README.md: Added.
  • web-platform-tests/XMLHttpRequest/abort-after-receive.htm:
  • web-platform-tests/XMLHttpRequest/abort-after-timeout.htm:
  • web-platform-tests/XMLHttpRequest/anonymous-mode-unsupported-expected.txt:
  • web-platform-tests/XMLHttpRequest/anonymous-mode-unsupported.htm:
  • web-platform-tests/XMLHttpRequest/data-uri-expected.txt:
  • web-platform-tests/XMLHttpRequest/data-uri.htm:
  • web-platform-tests/XMLHttpRequest/event-abort.htm:
  • web-platform-tests/XMLHttpRequest/event-load.htm:
  • web-platform-tests/XMLHttpRequest/event-loadend.htm:
  • web-platform-tests/XMLHttpRequest/event-loadstart-upload-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/event-loadstart-upload.htm: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/event-progress.htm.
  • web-platform-tests/XMLHttpRequest/event-loadstart.htm:
  • web-platform-tests/XMLHttpRequest/event-progress.htm:
  • web-platform-tests/XMLHttpRequest/event-readystatechange-loaded.htm:
  • web-platform-tests/XMLHttpRequest/event-timeout.htm:
  • web-platform-tests/XMLHttpRequest/event-upload-progress-crossorigin.htm:
  • web-platform-tests/XMLHttpRequest/event-upload-progress.htm:
  • web-platform-tests/XMLHttpRequest/getallresponseheaders-cl-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/getallresponseheaders-cl.htm: Added.
  • web-platform-tests/XMLHttpRequest/getallresponseheaders-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/getallresponseheaders.htm: Added.
  • web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive.htm:
  • web-platform-tests/XMLHttpRequest/loadstart-and-state-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/loadstart-and-state.html: Added.
  • web-platform-tests/XMLHttpRequest/open-after-setrequestheader-expected.txt:
  • web-platform-tests/XMLHttpRequest/open-after-setrequestheader.htm:
  • web-platform-tests/XMLHttpRequest/open-during-abort-event-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/open-during-abort-event.htm: Added.
  • web-platform-tests/XMLHttpRequest/open-during-abort-processing-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/open-during-abort-processing.htm: Added.
  • web-platform-tests/XMLHttpRequest/open-referer-expected.txt:
  • web-platform-tests/XMLHttpRequest/open-referer.htm:
  • web-platform-tests/XMLHttpRequest/open-send-during-abort-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/open-send-during-abort.htm: Added.
  • web-platform-tests/XMLHttpRequest/open-url-redirected-worker-origin-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/open-url-redirected-worker-origin.htm: Added.
  • web-platform-tests/XMLHttpRequest/overridemimetype-blob-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/overridemimetype-blob.html: Added.
  • web-platform-tests/XMLHttpRequest/overridemimetype-invalid-mime-type-expected.txt:
  • web-platform-tests/XMLHttpRequest/overridemimetype-invalid-mime-type.htm:
  • web-platform-tests/XMLHttpRequest/resources/corsenabled.py:

(main):

  • web-platform-tests/XMLHttpRequest/resources/delay.py:

(main):

  • web-platform-tests/XMLHttpRequest/resources/echo-headers.py: Added.

(main):

  • web-platform-tests/XMLHttpRequest/resources/header-content-length.asis: Added.
  • web-platform-tests/XMLHttpRequest/resources/headers-basic.asis: Added.
  • web-platform-tests/XMLHttpRequest/resources/headers.asis: Added.
  • web-platform-tests/XMLHttpRequest/resources/inspect-headers.py:

(get_response):
(main):

  • web-platform-tests/XMLHttpRequest/resources/redirect.py:

(main):

  • web-platform-tests/XMLHttpRequest/resources/w3c-import.log:
  • web-platform-tests/XMLHttpRequest/responsetext-decoding-expected.txt:
  • web-platform-tests/XMLHttpRequest/responsetext-decoding.htm:
  • web-platform-tests/XMLHttpRequest/send-accept-language-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-accept-language.htm:
  • web-platform-tests/XMLHttpRequest/send-data-formdata-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-data-formdata.htm:
  • web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub.htm:
  • web-platform-tests/XMLHttpRequest/send-redirect-to-cors.htm:
  • web-platform-tests/XMLHttpRequest/send-sync-blocks-async.htm:
  • web-platform-tests/XMLHttpRequest/send-sync-timeout.htm:
  • web-platform-tests/XMLHttpRequest/setrequestheader-allow-empty-value-expected.txt:
  • web-platform-tests/XMLHttpRequest/setrequestheader-allow-empty-value.htm:
  • web-platform-tests/XMLHttpRequest/setrequestheader-allow-whitespace-in-value-expected.txt:
  • web-platform-tests/XMLHttpRequest/setrequestheader-allow-whitespace-in-value.htm:
  • web-platform-tests/XMLHttpRequest/setrequestheader-case-insensitive-expected.txt:
  • web-platform-tests/XMLHttpRequest/setrequestheader-case-insensitive.htm:
  • web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm:
  • web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed-expected.txt:
  • web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed.htm:
  • web-platform-tests/XMLHttpRequest/setrequestheader-header-forbidden-expected.txt:
  • web-platform-tests/XMLHttpRequest/setrequestheader-header-forbidden.htm:
  • web-platform-tests/XMLHttpRequest/setrequestheader-open-setrequestheader-expected.txt:
  • web-platform-tests/XMLHttpRequest/setrequestheader-open-setrequestheader.htm:
  • web-platform-tests/XMLHttpRequest/status-error.htm:
  • web-platform-tests/XMLHttpRequest/template-element-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/template-element.html: Added.
  • web-platform-tests/XMLHttpRequest/timeout-multiple-fetches-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/timeout-multiple-fetches.html: Added.
  • web-platform-tests/XMLHttpRequest/w3c-import.log:
  • web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-reused-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-reused.html: Added.
  • web-platform-tests/check_stability.py:

(replace_streams.on_write):
(replace_streams):
(Firefox.install):
(setup_log_handler.LogHandler.init):
(setup_log_handler.LogHandler):
(setup_log_handler.LogHandler.find_or_create_test):
(setup_log_handler.LogHandler.find_or_create_subtest):
(setup_log_handler.LogHandler.test_status):
(setup_log_handler.LogHandler.test_end):
(err_string):
(process_results):
(write_inconsistent):
(write_results):

  • web-platform-tests/common/get-host-info.sub.js:

(get_host_info):

  • web-platform-tests/dom/OWNERS:
  • web-platform-tests/dom/lists/DOMTokenList-coverage-for-attributes-expected.txt:
  • web-platform-tests/dom/lists/DOMTokenList-coverage-for-attributes.html:
  • web-platform-tests/dom/nodes/Element-matches-expected.txt:
  • web-platform-tests/dom/nodes/Element-matches.html:
  • web-platform-tests/dom/nodes/Element-matches.js:

(interfaceCheckMatches):
(runSpecialMatchesTests):
(runInvalidSelectorTestMatches):
(runMatchesTest):

  • web-platform-tests/dom/nodes/Element-webkitMatchesSelector-expected.txt: Added.
  • web-platform-tests/dom/nodes/Element-webkitMatchesSelector.html: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-matches.html.
  • web-platform-tests/dom/nodes/Node-lookupNamespaceURI-expected.txt:
  • web-platform-tests/dom/nodes/Node-lookupNamespaceURI.html:
  • web-platform-tests/dom/nodes/w3c-import.log:
  • web-platform-tests/encrypted-media/content/video_512x288_h264-360k_multikey_key1_dashinit.mp4: Added.
  • web-platform-tests/fetch/OWNERS:
  • web-platform-tests/fetch/README.md: Added.
  • web-platform-tests/fetch/api/basic/request-referrer-expected.txt:
  • web-platform-tests/fetch/api/basic/request-referrer-redirected-worker-expected.txt: Added.
  • web-platform-tests/fetch/api/basic/request-referrer-redirected-worker.html: Added.
  • web-platform-tests/fetch/api/basic/request-referrer-worker-expected.txt: Added.
  • web-platform-tests/fetch/api/basic/request-referrer-worker.html: Added.
  • web-platform-tests/fetch/api/basic/request-referrer.js:

(testReferrer):

  • web-platform-tests/fetch/api/basic/request-upload-expected.txt:
  • web-platform-tests/fetch/api/basic/request-upload-worker-expected.txt:
  • web-platform-tests/fetch/api/basic/request-upload.js:

(testUpload):

  • web-platform-tests/fetch/api/basic/w3c-import.log:
  • web-platform-tests/fetch/api/cors/cors-expose-star-expected.txt: Added.
  • web-platform-tests/fetch/api/cors/cors-expose-star-worker-expected.txt: Added.
  • web-platform-tests/fetch/api/cors/cors-expose-star-worker.html: Added.
  • web-platform-tests/fetch/api/cors/cors-expose-star.html: Added.
  • web-platform-tests/fetch/api/cors/cors-expose-star.js: Added.

(sharedHeaders.string_appeared_here.promise_test):
(string_appeared_here.promise_test):

  • web-platform-tests/fetch/api/cors/cors-preflight-star-expected.txt: Added.
  • web-platform-tests/fetch/api/cors/cors-preflight-star-worker-expected.txt: Added.
  • web-platform-tests/fetch/api/cors/cors-preflight-star-worker.html: Added.
  • web-platform-tests/fetch/api/cors/cors-preflight-star.html: Added.
  • web-platform-tests/fetch/api/cors/cors-preflight-star.js: Added.

(origin.location.origin.preflightTest):

  • web-platform-tests/fetch/api/cors/cors-redirect-credentials-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-redirect-credentials-worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-redirect-credentials.js:

(corsRedirectCredentials):

  • web-platform-tests/fetch/api/cors/w3c-import.log:
  • web-platform-tests/fetch/api/headers/headers-combine-expected.txt:
  • web-platform-tests/fetch/api/headers/headers-combine.html:
  • web-platform-tests/fetch/api/headers/headers-record-expected.txt: Added.
  • web-platform-tests/fetch/api/headers/headers-record.html: Added.
  • web-platform-tests/fetch/api/headers/w3c-import.log:
  • web-platform-tests/fetch/api/policies/nested-policy.js: Added.
  • web-platform-tests/fetch/api/policies/nested-policy.js.headers: Added.
  • web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https-expected.txt: Added.
  • web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin.html.
  • web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https-expected.txt: Added.
  • web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin.html.
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt: Added.
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin.html.
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-worker-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin.js:
  • web-platform-tests/fetch/api/policies/referrer-origin.html:
  • web-platform-tests/fetch/api/policies/referrer-origin.js:

(promise_test):

  • web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https-expected.txt: Added.
  • web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https.html: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin.html.
  • web-platform-tests/fetch/api/policies/referrer-unsafe-url.js:
  • web-platform-tests/fetch/api/policies/w3c-import.log:
  • web-platform-tests/fetch/api/request/request-cache-default-conditional-expected.txt:
  • web-platform-tests/fetch/api/request/request-cache-default-expected.txt:
  • web-platform-tests/fetch/api/request/request-cache-force-cache-expected.txt:
  • web-platform-tests/fetch/api/request/request-cache-no-cache-expected.txt:
  • web-platform-tests/fetch/api/request/request-cache-no-store-expected.txt:
  • web-platform-tests/fetch/api/request/request-cache-reload-expected.txt:
  • web-platform-tests/fetch/api/request/request-cache.js:
  • web-platform-tests/fetch/api/request/request-headers-expected.txt:
  • web-platform-tests/fetch/api/request/request-headers.html:
  • web-platform-tests/fetch/api/request/request-keepalive-quota-expected.txt: Added.
  • web-platform-tests/fetch/api/request/request-keepalive-quota.html: Added.
  • web-platform-tests/fetch/api/request/resources/cache.py:

(main):

  • web-platform-tests/fetch/api/request/w3c-import.log:
  • web-platform-tests/fetch/api/resources/preflight.py:

(main):

  • web-platform-tests/fetch/api/response/response-idl-expected.txt:
  • web-platform-tests/fetch/api/response/response-idl.html:
  • web-platform-tests/fetch/api/response/response-trailer-expected.txt: Added.
  • web-platform-tests/fetch/api/response/response-trailer.html: Added.
  • web-platform-tests/fetch/api/response/w3c-import.log:
  • web-platform-tests/fetch/w3c-import.log:
  • web-platform-tests/html/OWNERS:
  • web-platform-tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name_cross_origin-0.html: Added.
  • web-platform-tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name_cross_origin-expected.txt:
  • web-platform-tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name_cross_origin.html:
  • web-platform-tests/html/browsers/browsing-the-web/history-traversal/w3c-import.log:
  • web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-with-colon.sub-expected.txt: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-with-colon.sub.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location-stringifier-expected.txt:
  • web-platform-tests/html/browsers/history/the-location-interface/location-stringifier.html:
  • web-platform-tests/html/browsers/history/the-location-interface/location-tojson-expected.txt: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location-tojson.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/resources/post-your-protocol.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/browsers/offline/w3c-import.log.
  • web-platform-tests/html/browsers/history/the-location-interface/w3c-import.log:
  • web-platform-tests/html/browsers/offline/no-appcache-in-shared-workers-historical-expected.txt: Added.
  • web-platform-tests/html/browsers/offline/no-appcache-in-shared-workers-historical.html: Added.
  • web-platform-tests/html/browsers/offline/no-appcache-in-shared-workers-historical.js: Added.

(test):

  • web-platform-tests/html/browsers/offline/w3c-import.log:
  • web-platform-tests/html/browsers/the-window-object/support/noopener-target.html:
  • web-platform-tests/html/browsers/the-window-object/window-open-noopener-expected.txt:
  • web-platform-tests/html/browsers/the-window-object/window-open-noopener.html:
  • web-platform-tests/html/browsers/windows/browsing-context-expected.txt: Added.
  • web-platform-tests/html/browsers/windows/browsing-context-window-expected.txt: Added.
  • web-platform-tests/html/browsers/windows/browsing-context-window.html: Added.
  • web-platform-tests/html/browsers/windows/browsing-context.html: Added.
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/resources/frameElement-nested-frame.html: Added.
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/resources/frameElement-window-post.html: Added.
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/resources/post-to-opener.html: Added.
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/nested-browsing-contexts/w3c-import.log.
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/w3c-import.log:
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/window-parent-expected.txt: Added.
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/window-parent-null-expected.txt: Added.
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/window-parent-null.html: Added.
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/window-parent.html: Added.
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/window-top-expected.txt: Added.
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/window-top-null-expected.txt: Added.
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/window-top-null.html: Added.
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/window-top.html: Added.
  • web-platform-tests/html/browsers/windows/noreferrer-cross-origin-close-manual.sub.html:
  • web-platform-tests/html/browsers/windows/noreferrer-cross-origin-window-name-manual.sub.html: Added.
  • web-platform-tests/html/browsers/windows/noreferrer-null-opener-expected.txt: Added.
  • web-platform-tests/html/browsers/windows/noreferrer-null-opener.html: Added.
  • web-platform-tests/html/browsers/windows/noreferrer-window-name.html:
  • web-platform-tests/html/browsers/windows/resources/browsing-context-window.html: Added.
  • web-platform-tests/html/browsers/windows/resources/echo-window-name.html: Added.
  • web-platform-tests/html/browsers/windows/resources/nested-post-to-opener.html: Added.
  • web-platform-tests/html/browsers/windows/resources/noreferrer-window-name.html: Added.
  • web-platform-tests/html/browsers/windows/resources/post-to-opener.html: Added.
  • web-platform-tests/html/browsers/windows/resources/target-cross-origin.sub.html: Added.
  • web-platform-tests/html/browsers/windows/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/w3c-import.log.
  • web-platform-tests/html/browsers/windows/resources/window-close-button.html: Added.
  • web-platform-tests/html/browsers/windows/resources/window-opener.html: Added.
  • web-platform-tests/html/browsers/windows/targeting-multiple-cross-origin-manual.sub.html:
  • web-platform-tests/html/browsers/windows/w3c-import.log:
  • web-platform-tests/html/dom/elements/elements-in-the-dom/historical-expected.txt:
  • web-platform-tests/html/dom/elements/elements-in-the-dom/historical.html:
  • web-platform-tests/html/dom/interfaces.html:
  • web-platform-tests/html/dom/interfaces.worker-expected.txt: Added.
  • web-platform-tests/html/dom/interfaces.worker.html: Added.
  • web-platform-tests/html/dom/interfaces.worker.js: Added.

(doTest):
(fetchData):
(promise_test):

  • web-platform-tests/html/dom/reflection.js:
  • web-platform-tests/html/dom/resources/self-origin-subframe.html: Added.
  • web-platform-tests/html/dom/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/w3c-import.log.
  • web-platform-tests/html/dom/self-origin.any-expected.txt: Added.
  • web-platform-tests/html/dom/self-origin.any.html: Added.
  • web-platform-tests/html/dom/self-origin.any.js: Added.

(test):

  • web-platform-tests/html/dom/self-origin.sub-expected.txt: Added.
  • web-platform-tests/html/dom/self-origin.sub.html: Added.
  • web-platform-tests/html/dom/self-origin.worker-expected.txt: Added.
  • web-platform-tests/html/dom/self-origin.worker.html: Added.
  • web-platform-tests/html/dom/w3c-import.log:
  • web-platform-tests/html/semantics/document-metadata/styling/LinkStyle.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-with-slow-text-tracks-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/autoplay-with-slow-text-tracks.html: Added.
  • web-platform-tests/html/semantics/embedded-content/media-elements/ready-states/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/w3c-import.log.
  • web-platform-tests/html/semantics/embedded-content/resources/should-load.html: Added.
  • web-platform-tests/html/semantics/embedded-content/resources/should-not-load.html: Added.
  • web-platform-tests/html/semantics/embedded-content/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/w3c-import.log.
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.whitespace.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.null-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.null.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-ignored-in-media-element.html:
  • web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-in-object-fallback-2-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-in-object-fallback-2.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-embed-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation_by_user_activation_without_user_gesture-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation_by_user_activation_without_user_gesture.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/iframe-that-performs-top-navigation-without-user-gesture-failed.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/iframe-that-performs-top-navigation.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/navigation-changed-iframe.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/Image-constructor-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/Image-constructor.html:
  • web-platform-tests/html/semantics/embedded-content/the-object-element/object-ignored-in-media-element-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-object-element/object-ignored-in-media-element.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-object-element/object-in-object-fallback-2-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-object-element/object-in-object-fallback-2.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-object-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt:
  • web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application.html:
  • web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt:
  • web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange.html:
  • web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt:
  • web-platform-tests/html/semantics/forms/the-input-element/valueMode.html:
  • web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-expected.txt:
  • web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection.html:
  • web-platform-tests/html/semantics/forms/the-select-element/selected-index-expected.txt:
  • web-platform-tests/html/semantics/forms/the-select-element/selected-index.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/data-url-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/data-url.html:
  • web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt:
  • web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot.html:
  • web-platform-tests/html/semantics/tabular-data/the-table-element/tHead-expected.txt:
  • web-platform-tests/html/semantics/tabular-data/the-table-element/tHead.html:
  • web-platform-tests/html/semantics/tabular-data/the-tr-element/insertCell-expected.txt:
  • web-platform-tests/html/semantics/tabular-data/the-tr-element/insertCell.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/w3c-import.log:
  • web-platform-tests/html/syntax/parsing/test.js:

(init_tests):

  • web-platform-tests/html/webappapis/scripting/events/body-exposed-window-event-handlers-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/body-exposed-window-event-handlers.html:
  • web-platform-tests/html/webappapis/scripting/events/compile-event-handler-settings-objects-expected.txt: Added.
  • web-platform-tests/html/webappapis/scripting/events/compile-event-handler-settings-objects.html: Added.
  • web-platform-tests/html/webappapis/scripting/events/event-handler-onauxclick.html:
  • web-platform-tests/html/webappapis/scripting/events/event-handler-processing-algorithm-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/event-handler-processing-algorithm.html:
  • web-platform-tests/html/webappapis/scripting/events/resources/compiled-event-handler-settings-objects-support.html: Added.
  • web-platform-tests/html/webappapis/scripting/events/resources/open-window.html: Added.
  • web-platform-tests/html/webappapis/scripting/events/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/browsers/offline/w3c-import.log.
  • web-platform-tests/html/webappapis/scripting/events/w3c-import.log:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setTimeout.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-setInterval.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-setTimeout.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-setTimeout.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/runtime-error-in-setInterval.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/runtime-error-in-setTimeout.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/support/syntax-error-in-setInterval.js:

(step_timeout):

  • web-platform-tests/html/webappapis/scripting/processing-model-2/support/undefined-variable-in-setInterval.js:

(step_timeout):

  • web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/NavigatorID-expected.txt:
  • web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/NavigatorID.worker-expected.txt:
  • web-platform-tests/lint.whitelist:
  • web-platform-tests/media/CanvasTest.ttf: Added.
  • web-platform-tests/media/w3c-import.log:
  • web-platform-tests/streams/piping/general.js:

(false.promise_test):

  • web-platform-tests/streams/piping/pipe-through.js:

(promise_test):
(test):

  • web-platform-tests/streams/readable-byte-streams/general-expected.txt:
  • web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt:
  • web-platform-tests/streams/readable-byte-streams/general.js:

(test):

  • web-platform-tests/streams/readable-streams/bad-underlying-sources.js:

(promise_test):

  • web-platform-tests/streams/readable-streams/brand-checks-expected.txt:
  • web-platform-tests/streams/readable-streams/brand-checks.dedicatedworker-expected.txt:
  • web-platform-tests/streams/readable-streams/brand-checks.js:

(test):
(fakeReadableStream):

  • web-platform-tests/streams/readable-streams/cancel.js:

(promise_test):

  • web-platform-tests/streams/readable-streams/default-reader-expected.txt: Added.
  • web-platform-tests/streams/readable-streams/default-reader.dedicatedworker-expected.txt: Added.
  • web-platform-tests/streams/readable-streams/default-reader.dedicatedworker.html: Added.
  • web-platform-tests/streams/readable-streams/default-reader.html: Added.
  • web-platform-tests/streams/readable-streams/default-reader.js: Added.

(test):
(promise_test):
(promise_test.t.const.rs.new.ReadableStream.start):
(promise_test.t.const.rs.new.ReadableStream.cancel):

  • web-platform-tests/streams/readable-streams/default-reader.serviceworker.https-expected.txt: Added.
  • web-platform-tests/streams/readable-streams/default-reader.serviceworker.https.html: Added.
  • web-platform-tests/streams/readable-streams/default-reader.sharedworker-expected.txt: Added.
  • web-platform-tests/streams/readable-streams/default-reader.sharedworker.html: Added.
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size-expected.txt: Added.
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.dedicatedworker-expected.txt: Added.
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.dedicatedworker.html: Added.
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.html: Added.
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.js: Added.

(promise_test):
(setupTestStream):

  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt: Added.
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https.html: Added.
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.sharedworker-expected.txt: Added.
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.sharedworker.html: Added.
  • web-platform-tests/streams/readable-streams/garbage-collection-expected.txt:
  • web-platform-tests/streams/readable-streams/garbage-collection.dedicatedworker-expected.txt:
  • web-platform-tests/streams/readable-streams/garbage-collection.js:

(promise_test):

  • web-platform-tests/streams/readable-streams/general-expected.txt:
  • web-platform-tests/streams/readable-streams/general.dedicatedworker-expected.txt:
  • web-platform-tests/streams/readable-streams/general.js:

(promise_test):
(test):

  • web-platform-tests/streams/readable-streams/pipe-through.js:

(test):

  • web-platform-tests/streams/readable-streams/w3c-import.log:
  • web-platform-tests/url/OWNERS:
  • web-platform-tests/url/a-element-expected.txt:
  • web-platform-tests/url/a-element-origin-expected.txt:
  • web-platform-tests/url/a-element-origin-xhtml-expected.txt:
  • web-platform-tests/url/a-element-xhtml-expected.txt:
  • web-platform-tests/url/failure-expected.txt: Added.
  • web-platform-tests/url/failure.html: Added.
  • web-platform-tests/url/setters_tests.json:
  • web-platform-tests/url/url-constructor-expected.txt:
  • web-platform-tests/url/url-origin-expected.txt:
  • web-platform-tests/url/url-setters-expected.txt:
  • web-platform-tests/url/urltestdata.json:
  • web-platform-tests/url/w3c-import.log:
  • web-platform-tests/w3c-import.log:
  • web-platform-tests/webrtc/rtcpeerconnection/setRemoteDescription-expected.txt: Added.
  • web-platform-tests/webrtc/rtcpeerconnection/setRemoteDescription.html: Added.
  • web-platform-tests/webrtc/rtcpeerconnection/w3c-import.log:

LayoutTests:

  • platform/mac/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt:
  • tests-options.json:
5:34 PM Changeset in webkit [213881] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

JSC: fix compilation errors for MIPS
https://bugs.webkit.org/show_bug.cgi?id=168402

Patch by SKumarMetro <s.kumar@metrological.com> on 2017-03-13
Reviewed by Mark Lam.

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::fillNops):
Added.

  • assembler/MacroAssemblerMIPS.h:

Added MacroAssemblerMIPS::numGPRs and MacroAssemblerMIPS::numFPRs .

  • bytecode/InlineAccess.h:

(JSC::InlineAccess::sizeForPropertyAccess):
(JSC::InlineAccess::sizeForPropertyReplace):
(JSC::InlineAccess::sizeForLengthAccess):
Added MIPS cases.

5:30 PM Changeset in webkit [213880] by eric.carlson@apple.com
  • 20 edits in trunk

[MediaStream] Move paintCurrentFrameInContext from RealtimeMediaSources to MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=169474
<rdar://problem/30976747>

Reviewed by Youenn Fablet.

Source/WebCore:

Every video capture source has extremely similar code to render the current frame to
a graphics context. Because the media player gets every video sample buffer, have it
hang onto the most recent frame so it can implement paintCurrentFrameInContext directly.
Fix an existing race condition that occasionally caused the readyState to advance to
"have enough data" before a video was ready to paint by defining a MediaStreamTrackPrivate
readyState and observing that.

No new tests, covered by existing tests. These changes uncovered a bug in
fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html, which
was updated.

  • Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::captureCanvas):
(WebCore::CanvasCaptureMediaStreamTrack::Source::paintCurrentFrameInContext): Deleted.
(WebCore::CanvasCaptureMediaStreamTrack::Source::currentFrameImage): Deleted.

  • Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):
Drive-by change - don't pass status to parent callback, it is a property of the layer.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::isAvailable): Drive-by cleanup - we don't
use AVSampleBufferRenderSynchronizer so don't fail if it isn't available.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample): Hang onto new frame,
invalidate cached image, update readyState.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::layerStatusDidChange): No more "updatePausedImage".
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayer): Drive-by cleanup - Add an early

return if there is no need for a layer.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::destroyLayer): renderingModeChanged -> updateRenderingMode.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::currentDisplayMode): Minor cleanup.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateDisplayMode): Renamed from renderingModeChanged,
add a bool return to signal when the mode changes.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::play): No more m_haveEverPlayed. Update display
mode immediately.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::pause): No more paused image.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::currentReadyState): Only return HaveNothing, HaveMetadata,
or HaveEnoughData. Don't return HaveEnoughData until all enabled tracks are providing data and never
drop back to HaveMetadata.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateRenderingMode): Renamed from renderingModeChanged.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::characteristicsChanged): Update intrinsic
size directly.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::sampleBufferUpdated): No more m_hasReceivedMedia.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::readyStateChanged): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::checkSelectedVideoTrack): Reset imagePainter
when active video track changes.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateCurrentFrameImage): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paintCurrentFrameInContext): Paint current
frame image.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::CurrentFramePainter::reset): New.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::shouldEnqueueVideoSampleBuffer): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updatePausedImage): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateIntrinsicSize): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::renderingModeChanged): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::audioSamplesAvailable): Deleted.

  • platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::paintCurrentFrameInContext): Deleted.
(WebCore::MediaStreamPrivate::currentFrameImage): Deleted.

  • platform/mediastream/MediaStreamPrivate.h:
  • platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
(WebCore::MediaStreamTrackPrivate::endTrack): Update readyState.
(WebCore::MediaStreamTrackPrivate::clone): Clone readyState.
(WebCore::MediaStreamTrackPrivate::sourceStopped): Update readyState.
(WebCore::MediaStreamTrackPrivate::videoSampleAvailable): Ditto.
(WebCore::MediaStreamTrackPrivate::audioSamplesAvailable): Ditto.
(WebCore::MediaStreamTrackPrivate::updateReadyState): New, update readyState and notify observers.
(WebCore::MediaStreamTrackPrivate::paintCurrentFrameInContext): Deleted.

  • platform/mediastream/MediaStreamTrackPrivate.h:
  • platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::paintCurrentFrameInContext): Deleted.

  • platform/mediastream/RealtimeMediaSource.h:

(WebCore::RealtimeMediaSource::currentFrameImage): Deleted.
(WebCore::RealtimeMediaSource::paintCurrentFrameInContext): Deleted.

  • platform/mediastream/mac/AVMediaCaptureSource.mm:

(-[WebCoreAVMediaCaptureSourceObserver disconnect]): Drive-by fix - clear m_callback
after calling removeNotificationObservers.
(-[WebCoreAVMediaCaptureSourceObserver removeNotificationObservers]): Drive-by fix - remove
the correct listener.
(-[WebCoreAVMediaCaptureSourceObserver endSessionInterrupted:]):

  • platform/mediastream/mac/AVVideoCaptureSource.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::currentFrameImage): Deleted.
(WebCore::AVVideoCaptureSource::currentFrameCGImage): Deleted.
(WebCore::AVVideoCaptureSource::paintCurrentFrameInContext): Deleted.

  • platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:

(WebCore::drawImage): Deleted.
(WebCore::RealtimeIncomingVideoSource::currentFrameImage): Deleted.
(WebCore::RealtimeIncomingVideoSource::paintCurrentFrameInContext): Deleted.

  • platform/mediastream/mac/RealtimeIncomingVideoSource.h:
  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::paintCurrentFrameInContext): Deleted.
(WebCore::MockRealtimeVideoSource::currentFrameImage): Deleted.

  • platform/mock/MockRealtimeVideoSource.h:

LayoutTests:

  • fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled-expected.txt:
  • fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html: Fix

bug uncovered by patch.

5:18 PM Changeset in webkit [213879] by clopez@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK][SOUP] Fix build after r213877
https://bugs.webkit.org/show_bug.cgi?id=140191

Unreviewed build fix.

  • platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::setCookie): Add missing setCookie() declaration.

4:05 PM Changeset in webkit [213878] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip WebGPU tests on ios-simulator.

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
4:00 PM Changeset in webkit [213877] by beidson@apple.com
  • 33 edits
    1 copy
    5 adds in trunk

WKWebView provides no access to cookies.
https://bugs.webkit.org/show_bug.cgi?id=140191

Reviewed by Tim Horton.

Source/WebCore:

Covered by API tests.

  • platform/Cookie.h:
  • platform/network/NetworkStorageSession.h:
  • platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::setCookie):
(WebCore::NetworkStorageSession::deleteCookie):
(WebCore::nsCookiesToCookieVector):
(WebCore::NetworkStorageSession::getAllCookies):
(WebCore::NetworkStorageSession::getCookies):

  • platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::deleteCookie):
(WebCore::NetworkStorageSession::getAllCookies):
(WebCore::NetworkStorageSession::getCookies):

Source/WebKit2:

This adds a new WKHTTPCookieManager SPI.
It follows the NSHTTPCookieStorage API but asynchronous (with completion handlers).

  • CMakeLists.txt:
  • WebKit2.xcodeproj/project.pbxproj:
  • Shared/API/APIObject.h:
  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

  • UIProcess/API/APIHTTPCookieStorage.cpp: Added.

(API::HTTPCookieStorage::HTTPCookieStorage):
(API::HTTPCookieStorage::~HTTPCookieStorage):
(API::HTTPCookieStorage::cookies):
(API::HTTPCookieStorage::setCookie):
(API::HTTPCookieStorage::setCookies):
(API::HTTPCookieStorage::deleteCookie):
(API::HTTPCookieStorage::removeCookiesSinceDate):
(API::HTTPCookieStorage::setHTTPCookieAcceptPolicy):
(API::HTTPCookieStorage::getHTTPCookieAcceptPolicy):

  • UIProcess/API/APIHTTPCookieStorage.h: Added.
  • UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::defaultDataStore):
(API::WebsiteDataStore::httpCookieStorage):

  • UIProcess/API/APIWebsiteDataStore.h:
  • UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerDeleteAllCookiesModifiedAfterDate):
(WKCookieManagerSetHTTPCookieAcceptPolicy):
(WKCookieManagerGetHTTPCookieAcceptPolicy):

  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreGetDefaultDataStore):

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setCookieAcceptPolicy:]):

  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore defaultDataStore]):
(-[WKWebsiteDataStore _httpCookieStorage]):

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/API/Cocoa/WKHTTPCookieStorage.h:
  • UIProcess/API/Cocoa/WKHTTPCookieStorage.mm: Added.

(coreCookiesToNSCookies):
(-[WKHTTPCookieStorage dealloc]):
(-[WKHTTPCookieStorage fetchCookies:]):
(-[WKHTTPCookieStorage fetchCookiesForURL:completionHandler:]):
(-[WKHTTPCookieStorage setCookie:completionHandler:]):
(-[WKHTTPCookieStorage deleteCookie:completionHandler:]):
(-[WKHTTPCookieStorage setCookies:forURL:mainDocumentURL:completionHandler:]):
(-[WKHTTPCookieStorage removeCookiesSinceDate:completionHandler:]):
(-[WKHTTPCookieStorage setCookieAcceptPolicy:completionHandler:]):
(kitCookiePolicyToNSCookiePolicy):
(-[WKHTTPCookieStorage fetchCookieAcceptPolicy:]):
(-[WKHTTPCookieStorage _apiObject]):

  • UIProcess/API/Cocoa/WKHTTPCookieStorageInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h.

(WebKit::wrapper):

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::addSingleCookie):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::deleteCookie):
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManagerProxy::setCookie):
(WebKit::WebCookieManagerProxy::setCookies):
(WebKit::WebCookieManagerProxy::getAllCookies):
(WebKit::WebCookieManagerProxy::getCookies):
(WebKit::WebCookieManagerProxy::didSetCookies):
(WebKit::WebCookieManagerProxy::didGetCookies):
(WebKit::WebCookieManagerProxy::didDeleteCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setCookieObserverCallback):
(WebKit::WebCookieManagerProxy::cookiesDidChange):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::didGetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::didSetHTTPCookieAcceptPolicy):

  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebCookieManagerProxy.messages.in:
  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebProcessPool.cpp:
  • UIProcess/WebProcessPool.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::processPoolForCookieStorageOperations):
(WebKit::WebsiteDataStore::processPools):

  • UIProcess/WebsiteData/WebsiteDataStore.h:
  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::deleteCookie):
(WebKit::WebCookieManager::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManager::getAllCookies):
(WebKit::WebCookieManager::getCookies):
(WebKit::WebCookieManager::setCookie):
(WebKit::WebCookieManager::setCookies):
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):

  • WebProcess/Cookies/WebCookieManager.h:
  • WebProcess/Cookies/WebCookieManager.messages.in:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3:52 PM Changeset in webkit [213876] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

FTL should not flush strict arguments unless it really needs to
https://bugs.webkit.org/show_bug.cgi?id=169519

Reviewed by Mark Lam.

This is a refinement that we should have done ages ago. This kills some pointless PutStacks
in DFG SSA IR. It can sometimes unlock other optimizations.

Relanding after I fixed the special cases for CreateArguments-style nodes.

  • dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

3:35 PM Changeset in webkit [213875] by nvasilyev@apple.com
  • 5 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: WebSockets: color of outgoing message icon should match text color
https://bugs.webkit.org/show_bug.cgi?id=169512
<rdar://problem/30994284>

Reviewed by Devin Rousso.

Include SVG icon as an inline SVG element to make currentColor work.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Main.html:
  • UserInterface/Views/WebSocketContentView.css:

(.web-socket.content-view .outgoing .icon): Deleted.

  • UserInterface/Views/WebSocketContentView.js:

(WebInspector.WebSocketContentView):
(WebInspector.WebSocketContentView.prototype.addFrame):
(WebInspector.WebSocketContentView.prototype._addRow):
(WebInspector.WebSocketContentView.prototype._timeStringFromTimestamp): Deleted.

  • UserInterface/Views/WebSocketDataGridNode.js: Added.

(WebInspector.WebSocketDataGridNode.prototype.createCellContent):
(WebInspector.WebSocketDataGridNode.prototype._timeStringFromTimestamp):
(WebInspector.WebSocketDataGridNode):

3:29 PM Changeset in webkit [213874] by webkit@devinrousso.com
  • 7 edits
    1 move in trunk/Source/WebInspectorUI

Web Inspector: Event Listeners detail section is unhelpful, default should show listeners by element rather than by event
https://bugs.webkit.org/show_bug.cgi?id=167077

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Main.html:
  • UserInterface/Views/EventListenerSection.js: Removed.
  • UserInterface/Models/DOMNode.js:

(WebInspector.DOMNode.prototype.eventListeners): Renamed to getEventListeners.

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.css: Added.

(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter):
(body[dir=ltr] .sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter):
(body[dir=rtl] .sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter):
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter:hover):
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter:active):
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners.collapsed > .header > .filter):
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter > select):

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.createOption):
(WebInspector.DOMNodeDetailsSidebarPanel):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshEventListeners.createEventListenerSection):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshEventListeners.generateGroupsByEvent):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshEventListeners.generateGroupsByNode):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshEventListeners.eventListenersCallback):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshEventListeners):
Add a filter to the Event Listeners section that changes the way in which event listeners
are grouped. Currently supports two methods:

  • Group by Event
  • Group by Node
  • UserInterface/Views/EventListenerSectionGroup.js:

(WebInspector.EventListenerSectionGroup):
Add ability to display the event type.

  • UserInterface/Views/DetailsSection.css:

(.details-section):
Drive-by fix: CSS variable was named incorrectly.

3:27 PM Changeset in webkit [213873] by webkit@devinrousso.com
  • 8 edits
    2 adds in trunk

Web Inspector: Event Listeners section is missing 'once', 'passive' event listener flags
https://bugs.webkit.org/show_bug.cgi?id=167080

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • inspector/protocol/DOM.json:

Add "passive" and "once" items to the EventListener type.

Source/WebCore:

Test: inspector/dom/getEventListenersForNode.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForEventListener):
Add "passive" and "once" values to the EventListener protocol object when applicable.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/EventListenerSectionGroup.js:

(WebInspector.EventListenerSectionGroup):
(WebInspector.EventListenerSectionGroup.prototype._type): Deleted.

LayoutTests:

Tests the result of DOMAgent.getEventListenersForNode and ensures that additional options
are passed to the frontend.

  • inspector/dom/getEventListenersForNode-expected.txt: Added.
  • inspector/dom/getEventListenersForNode.html: Added.
3:06 PM Changeset in webkit [213872] by mark.lam@apple.com
  • 3 edits
    1 delete in trunk/Source/JavaScriptCore

Remove obsolete experimental ObjC SPI.
https://bugs.webkit.org/show_bug.cgi?id=169569

Reviewed by Saam Barati.

  • API/JSVirtualMachine.mm:

(-[JSVirtualMachine enableSigillCrashAnalyzer]): Deleted.

  • API/JSVirtualMachinePrivate.h: Removed.
  • JavaScriptCore.xcodeproj/project.pbxproj:
2:50 PM Changeset in webkit [213871] by wilander@apple.com
  • 21 edits in trunk/Source

Resource Load Statistics: More efficient network process messaging + Fix bug in user interaction reporting
https://bugs.webkit.org/show_bug.cgi?id=169506

Reviewed by Alex Christensen.

Source/WebCore:

Covered by previous test which now follows the code path more closely to when reporting
happens in the web process.

  • loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

No longer explicitly calls ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler().
Instead just calls ResourceLoadStatisticsStore::fireDataModificationHandler().

(WebCore::ResourceLoadObserver::logUserInteraction):

Updated to call the new ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler().

(WebCore::ResourceLoadObserver::fireShouldPartitionCookiesHandler):

Now takes two vectors – domainsToRemove and domainsToAdd.

  • loader/ResourceLoadObserver.h:
  • loader/ResourceLoadStatistics.cpp:

(WebCore::ResourceLoadStatistics::toString):

Added boolean field isMarkedForCookiePartitioning.

(WebCore::ResourceLoadStatistics::merge):

Added boolean field isMarkedForCookiePartitioning.

  • loader/ResourceLoadStatistics.h:

Added boolean field isMarkedForCookiePartitioning.

  • loader/ResourceLoadStatisticsStore.cpp:

(WebCore::ResourceLoadStatisticsStore::readDataFromDecoder):

Now marks statistics with isMarkedForCookiePartitioning before sending them off to
ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler().

(WebCore::ResourceLoadStatisticsStore::setShouldPartitionCookiesCallback):

Now accepts a handler with two vectors.

(WebCore::ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler):

Now the only exported version of this function is the one without arguments.
The one internal to WebCore accepts two vectors – domainsToRemove and domainsToAdd.
The exported one generates the two vectors and then calls the internal one.

(WebCore::ResourceLoadStatisticsStore::hasHadRecentUserInteraction):

No longer explicitly calls ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler().

  • loader/ResourceLoadStatisticsStore.h:
  • platform/network/NetworkStorageSession.h:
  • platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::setShouldPartitionCookiesForHosts):

Now takes two vectors – domainsToRemove and domainsToAdd.

Source/WebKit2:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::shouldPartitionCookiesForTopPrivatelyOwnedDomains):

Now takes two vectors – domainsToRemove and domainsToAdd.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:

The message now takes two vectors – domainsToRemove and domainsToAdd.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::shouldPartitionCookiesForTopPrivatelyOwnedDomains):

Now takes two vectors – domainsToRemove and domainsToAdd.

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.messages.in:

The message now takes two vectors – domainsToRemove and domainsToAdd.

  • UIProcess/WebResourceLoadStatisticsManager.cpp:

(WebKit::WebResourceLoadStatisticsManager::fireShouldPartitionCookiesHandler):

Now converts to the two vectors needed by
WebCore::ResourceLoadObserver::fireShouldPartitionCookiesHandler().

  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::classifyResource):

No longer explicitly calls ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler().

(WebKit::WebResourceLoadStatisticsStore::removeDataRecords):

Changed the order of two blocks to not build a vector if we are to return early.

(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):

Now calls WebCore::ResourceLoadObserver::fireShouldPartitionCookiesHandler().

(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):

Now takes a handler with two vectors – domainsToRemove and domainsToAdd.

  • UIProcess/WebResourceLoadStatisticsStore.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::shouldPartitionCookiesForTopPrivatelyOwnedDomains):

Now takes two vectors – domainsToRemove and domainsToAdd.

(WebKit::WebsiteDataStore::registerSharedResourceLoadObserver):

Now submits a handler that takes two vectors – domainsToRemove and domainsToAdd.

  • UIProcess/WebsiteData/WebsiteDataStore.h:
2:44 PM Changeset in webkit [213870] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Database's query functions should support querying for a row with NULL value
https://bugs.webkit.org/show_bug.cgi?id=169504

Reviewed by Antti Koivisto.

Add the support for calling select_* with one of column values set to NULL.
This feature is useful in webkit.org/b/146374 and webkit.org/b/168962.

  • public/include/db.php:

(Database::prepare_params): Added $null_columns as an optional argument.
(Database::select_conditions_with_null_columns): Added. Builds up a query string by appending AND x is NULL
to match columns whose value must be NULL.
(Database::_select_update_or_insert_row):
(Database::select_rows):

2:36 PM Changeset in webkit [213869] by dino@apple.com
  • 5 edits
    3 adds in trunk

Source/WebCore:
Respect the runtime flag for WebGPU, default feature to off.
https://bugs.webkit.org/show_bug.cgi?id=169564
<rdar://problems/31018864>

Reviewed by Tim Horton.

Make sure WebGPU respects its runtime feature flag. Also, since
this implementation doesn't validate content, it should default
to being disabled.

Test: fast/canvas/webgpu/webgpu-runtime-flag.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::getContextWebGPU):

Source/WebKit2:
Respect the runtime flag for WebGPU, default feature to off, and print a warning
https://bugs.webkit.org/show_bug.cgi?id=169564
<rdar://problems/31018864>

Reviewed by Tim Horton.

Make sure WebGPU respects its runtime feature flag. Also, since
this implementation doesn't validate content, it should default
to being disabled.

  • Shared/WebPreferencesDefinitions.h:

LayoutTests:
Respect the runtime flag for WebGPU, default feature to off, and print a warning
https://bugs.webkit.org/show_bug.cgi?id=169564
<rdar://problem/31018864>

Reviewed by Tim Horton.

  • fast/canvas/webgpu/webgpu-runtime-flag-expected.txt: Added.
  • fast/canvas/webgpu/webgpu-runtime-flag.html: Added.
2:26 PM Changeset in webkit [213868] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] install-dependencies needs to install Perl CGI modules on Debian based distros
https://bugs.webkit.org/show_bug.cgi?id=169563

Reviewed by Michael Catanzaro.

  • gtk/install-dependencies:
2:14 PM Changeset in webkit [213867] by webkit@devinrousso.com
  • 2 edits in trunk/Tools

Unreviewed, fix accidental comma.

  • Scripts/webkitpy/common/config/contributors.json:
2:11 PM Changeset in webkit [213866] by webkit@devinrousso.com
  • 2 edits in trunk/Tools

Unreviewed, change my email.

  • Scripts/webkitpy/common/config/contributors.json:
1:17 PM Changeset in webkit [213865] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix CMake build.

  • PlatformMac.cmake:

Add new files.

1:16 PM Changeset in webkit [213864] by andersca@apple.com
  • 4 edits in trunk/Tools

Fix build warnings.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate openDocument:]):

  • MiniBrowser/mac/ExtensionManagerWindowController.m:

(-[ExtensionManagerWindowController add:]):

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):

1:08 PM Changeset in webkit [213863] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix more build warnings.

  • UIProcess/mac/WKWebInspectorWKWebView.mm:

(WebKit::runOpenPanel):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformSave):

12:46 PM Changeset in webkit [213862] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove my email from some of the watchlists
https://bugs.webkit.org/show_bug.cgi?id=169541

Patch by Martin Robinson <mrobinson@igalia.com> on 2017-03-13
Reviewed by Manuel Rego Casasnovas.

  • Scripts/webkitpy/common/config/watchlist: Remove my name from some lists.
12:42 PM Changeset in webkit [213861] by andersca@apple.com
  • 4 edits in trunk/Source

Fix build warnings.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::save):
(-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):

Source/WebKit2:

  • UIProcess/mac/RemoteWebInspectorProxyMac.mm:

(WebKit::RemoteWebInspectorProxy::platformSave):

12:36 PM Changeset in webkit [213860] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk

Unreviewed, rolling out r213856.
https://bugs.webkit.org/show_bug.cgi?id=169562

Breaks JSC stress test stress/super-property-access.js.ftl-
eager failing (Requested by mlam|g on #webkit).

Reverted changeset:

"FTL should not flush strict arguments unless it really needs
to"
https://bugs.webkit.org/show_bug.cgi?id=169519
http://trac.webkit.org/changeset/213856

12:09 PM Changeset in webkit [213859] by Yusuke Suzuki
  • 3 edits in trunk/Source/JavaScriptCore

[JSC][Linux] Allow profilers to demangle C++ names
https://bugs.webkit.org/show_bug.cgi?id=169559

Reviewed by Michael Catanzaro.

Linux also offers dladdr & demangling feature.
Thus, we can use it to show the names in profilers.
For example, SamplingProfiler tells us the C function names.

  • runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::StackFrame::displayName):

  • tools/CodeProfile.cpp:

(JSC::symbolName):

11:56 AM Changeset in webkit [213858] by Yusuke Suzuki
  • 18 edits in trunk

[WTF] Clean up RunLoop and WorkQueue with Seconds and Function
https://bugs.webkit.org/show_bug.cgi?id=169537

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/Watchdog.cpp:

(JSC::Watchdog::startTimer):

Source/WebKit2:

  • Shared/ChildProcess.cpp:

(WebKit::didCloseOnConnectionWorkQueue):

  • UIProcess/Storage/LocalStorageDatabase.cpp:
  • WebProcess/WebPage/gtk/AcceleratedSurfaceX11.cpp:

(WebKit::AcceleratedSurfaceX11::resize):

Source/WTF:

This patch modernizes RunLoop and WorkQueue.

  1. Use Ref<> aggressively
  2. Use Seconds instead of chrono times
  3. Use Function<> instead of std::function
  • wtf/MainThread.cpp:

(WTF::dispatchFunctionsFromMainThread):

  • wtf/RunLoop.h:
  • wtf/WorkQueue.h:
  • wtf/cocoa/WorkQueueCocoa.cpp:

(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
(WTF::WorkQueue::concurrentApply):

  • wtf/generic/MainThreadGeneric.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):

  • wtf/generic/RunLoopGeneric.cpp:

(WTF::RunLoop::TimerBase::ScheduledTask::create):
(WTF::RunLoop::TimerBase::ScheduledTask::EarliestSchedule::operator()):
(WTF::RunLoop::populateTasks):
(WTF::RunLoop::runImpl):
(WTF::RunLoop::schedule):
(WTF::RunLoop::scheduleAndWakeUp):
(WTF::RunLoop::dispatchAfter):
(WTF::RunLoop::TimerBase::start):

  • wtf/generic/WorkQueueGeneric.cpp:

(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

  • wtf/glib/RunLoopGLib.cpp:

(WTF::DispatchAfterContext::DispatchAfterContext):
(WTF::RunLoop::dispatchAfter):
(WTF::RunLoop::TimerBase::updateReadyTime):
(WTF::RunLoop::TimerBase::start):

  • wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::performWorkOnRegisteredWorkThread):
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):

Tools:

  • TestWebKitAPI/Tests/WTF/WorkQueue.cpp:

(TestWebKitAPI::TEST):

11:09 AM Changeset in webkit [213857] by Chris Dumez
  • 19 edits
    2 adds in trunk/Source

Allow termination of background WebProcesses that go over a given CPU usage threshold
https://bugs.webkit.org/show_bug.cgi?id=169456
<rdar://problem/30960968>

Reviewed by Andreas Kling.

Source/WebCore:

Add CPUMonitor utility class to monitor CPU usage and call a provided lambda
whenever the process exceeds the provided CPU limit over a given period of
time.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/CPUMonitor.cpp: Added.

(WebCore::CPUMonitor::CPUMonitor):
(WebCore::CPUMonitor::setCPULimit):
(WebCore::CPUMonitor::timerFired):

  • platform/CPUMonitor.h: Added.

Source/WebKit2:

Allow termination of background WebProcesses that go over a given CPU usage threshold.
This can be enabled client side via the WKPageConfigurationSetBackgroundCPULimit()
SPI. The client provides the actual CPU threshold it wants to use at page level.

If such limit is set, whenever a WebContent process has no visible pages, we start
monitoring its CPU usage over 15 minutes periods. At the end of each period, we
check if the process' average CPU usage over this period was greater than the
background CPU limit. If it greater, the WebContent process send an IPC message to
the UIProcess letting it know that it exceeded the CPU limit. The UI process will
then log a message and terminate the process unless it has any audio playing.

Once a WebProcess has been terminated, we do not let the client know until one of its
pages becomes visible again. When this happens, we call the processDidCrash
delegate and Safari will take care of reloading the tab and showing the crash
banner then. This is done because we do not want to reload content that is
using a lot of CPU while in the background.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:

Add backgroundCPULimit to WebPageCreationParameters.

  • UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::copy):

  • UIProcess/API/APIPageConfiguration.h:

(API::PageConfiguration::backgroundCPULimit):
(API::PageConfiguration::setBackgroundCPULimit):
Add backgroundCPULimit to APIPageConfiguration.

  • UIProcess/API/C/WKPageConfigurationRef.cpp:

(WKPageConfigurationSetBackgroundCPULimit):

  • UIProcess/API/C/WKPageConfigurationRef.h:

Add SPI to set background CPU limit.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcess):
Reset m_wasTerminatedDueToResourceExhaustionWhileInBackground flag
as the process was restarted.

(WebKit::WebPageProxy::dispatchActivityStateChange):
When the visibility state changes for a page that was terminated
while in the background due to exceeded CPU limit, notify the
client that the process crashed via the processDidCrash delegate.
Safari will use this delegate to reload the tab and show the crash
banner.

(WebKit::WebPageProxy::terminateProcess):
Add parameter to terminateProcess() to provide the reason. If the
page was terminated due to reaching CPU limit, set a flag so we
can delay calling processDidCrash until the page becomes visible
again.

(WebKit::WebPageProxy::creationParameters):
Set backgroundCPULimit on the WebPageCreationParameters.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::pagesCopy):
Add utility function to copy the list of pages to a Vector.

(WebKit::WebProcessProxy::didExceedBackgroundCPULimit):
When we get an IPC message from a WebContent process to let us
know that the process exceeded the background CPU limit, we log
a message and we terminate it if it has no audio playing.

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:

Add DidExceedBackgroundCPULimit IPC message so the WebContent process
can let us know when it goes over the background CPU limit.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_backgroundCPULimit):
(WebKit::WebPage::setActivityState):
Notify the WebProcess whenever the activity state of a WebPage changes.
The WebProcess currently uses this information to determine when the
visibility of a page changes. This is needed as we only want to monitor
CPU usage of *background* WebContent processes (processes that have no
visible WebPage).

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::backgroundCPULimit):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::removeWebPage):
Call updateBackgroundCPULimit() whenever a WebPage is added or removed
since the limit is per page.

(WebKit::WebProcess::updateBackgroundCPULimit):
(WebKit::WebProcess::updateBackgroundCPUMonitorState):
No-ops on other platforms than Mac at the moment.

(WebKit::WebProcess::pageActivityStateDidChange):
Call updateBackgroundCPUMonitorState() whenever the visibility of the
WebPage changes as we only monitor the CPU usage of *background* WebContent
processes.

(WebKit::WebProcess::hasVisibleWebPage):
Add utility function to determine if there is any visible WebPage in this
WebContent process. If the function returns false, then we consider the
WebContent process to be a *background* WebContent process.

  • WebProcess/WebProcess.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::updateBackgroundCPULimit):
Compute the WebProcess' background CPU limit given the limit set for each
of its WebPages. We use the largest (i.e. most permissive) background CPU
limit among all the pages.

(WebKit::WebProcess::updateBackgroundCPUMonitorState):
Update the state of the background CPU monitor. This is called whenever
the background CPU limit of the process changes or whenever the visibility
of a WebPage changes.

11:00 AM Changeset in webkit [213856] by fpizlo@apple.com
  • 3 edits
    1 add in trunk

FTL should not flush strict arguments unless it really needs to
https://bugs.webkit.org/show_bug.cgi?id=169519

Reviewed by Mark Lam.

JSTests:

This benchmark runs 3.5x faster thanks to this patch.

  • microbenchmarks/strict-arguments-no-escape.js: Added.

(foo):
(bar):
(baz):

Source/JavaScriptCore:

This is a refinement that we should have done ages ago. This kills some pointless PutStacks
in DFG SSA IR. It can sometimes unlock other optimizations.

  • dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

10:54 AM Changeset in webkit [213855] by mcatanzaro@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Updated Swedish translation
https://bugs.webkit.org/show_bug.cgi?id=169549

Patch by Josef Andersson <l10nl18nsweja@gmail.com> on 2017-03-13
Rubber-stamped by Michael Catanzaro.

  • sv.po:
10:51 AM Changeset in webkit [213854] by msaboff@apple.com
  • 8 edits in trunk/Source/WebKit2

Add iOS plumbing to WebProcess to enable JavaScriptCore configuration and logging
https://bugs.webkit.org/show_bug.cgi?id=169489

Reviewed by Geoffrey Garen.

Added new preference for enabling the use of a JavaScript configuration file
in iOS builds. The preference is used to enable the processing of the
configuration file.

(API::ProcessPoolConfiguration::ProcessPoolConfiguration):

  • UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::defaultJavaScriptConfigurationDirectory):

  • UIProcess/API/APIWebsiteDataStore.h:
  • UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:

(API::WebsiteDataStore::defaultJavaScriptConfigurationDirectory):
(API::WebsiteDataStore::tempDirectoryFileSystemRepresentation):
(API::WebsiteDataStore::defaultDataStoreConfiguration):

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::setJavaScriptConfigurationFileEnabledFromDefaults):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):

  • UIProcess/WebProcessPool.h:
10:42 AM Changeset in webkit [213853] by jmarcell@apple.com
  • 7 edits in tags/Safari-604.1.11/Source

Versioning.

10:40 AM Changeset in webkit [213852] by jmarcell@apple.com
  • 7 edits in trunk/Source

Versioning.

10:31 AM Changeset in webkit [213851] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.11

Tag Safari-604.1.11.

10:03 AM Changeset in webkit [213850] by commit-queue@webkit.org
  • 7 edits in trunk

[JSC] It should be possible create a label named let when parsing Statement in non strict mode
https://bugs.webkit.org/show_bug.cgi?id=168684

Patch by Caio Lima <ticaiolima@gmail.com> on 2017-03-13
Reviewed by Saam Barati.

JSTests:

  • ChakraCore/test/LetConst/DeclOutofBlock.baseline-jsc:

Source/JavaScriptCore:

This patch is fixing a Parser bug to allow define a label named
let in sloppy mode when parsing a Statement.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseStatement):

LayoutTests:

  • js/let-syntax-expected.txt:
  • js/script-tests/let-syntax.js:

(shouldNotHaveSyntaxErrorSloopyOnly):

9:57 AM Changeset in webkit [213849] by Ryan Haddad
  • 4 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html.

Unreviewed test gardening.

  • platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
9:39 AM Changeset in webkit [213848] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[Modern Media Controls] Volume icon doesn't turn to mute when the knob is set to 0
https://bugs.webkit.org/show_bug.cgi?id=169553
<rdar://problem/30754543>

Patch by Antoine Quint <Antoine Quint> on 2017-03-13
Reviewed by Eric Carlson.

Source/WebCore:

When we start changing the volume using the mouse, we record the volume at that point
and as we drag the volume slider, we set the mute button to show that the media is
muted if the volume is 0, and set the actual media volume to be the initial volume
prior to dragging. This way, when we toggle the "muted" property by pressing the
mute button, the original volume is restored.

To function correctly, this required some changed to Slider. The volume slider would
fail to update if the value set was the same as the initial value since we would use
only the "change" event to identify the end of a slider drag interaction. This was
incorrect since if the initial value and the final value while dragging the slider
were the same, no "change" event would be fired. So we now use mouse events to
identify when the slider is being dragged.

Test: media/modern-media-controls/volume-support/volume-support-drag-to-mute.html

  • Modules/modern-media-controls/controls/slider.js:

(Slider.prototype.set value):
(Slider.prototype.handleEvent):
(Slider.prototype._handleMousedownEvent):
(Slider.prototype._handleInputEvent):
(Slider.prototype._handleMouseupEvent):
(Slider.prototype._handleChangeEvent): Deleted.

  • Modules/modern-media-controls/controls/volume-slider.js:

(VolumeSlider):
(VolumeSlider.prototype.draw):
(VolumeSlider.prototype.handleEvent): Deleted.

  • Modules/modern-media-controls/media/volume-support.js:

(VolumeSupport.prototype.controlValueWillStartChanging):
(VolumeSupport.prototype.controlValueDidChange):

LayoutTests:

Adding a new test where we drag the volume slider to 0 and ensure that the volume gets muted
and that clicking on the mute button resets the volume to be the same value as prior to the
dragging interaction.

  • media/modern-media-controls/volume-support/volume-support-drag-to-mute-expected.txt: Added.
  • media/modern-media-controls/volume-support/volume-support-drag-to-mute.html: Added.
9:29 AM Changeset in webkit [213847] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=169546

Reviewed by Brent Fulgham.

There is no matching constructor in the Cookie class.

  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::getRawCookies):

9:26 AM Changeset in webkit [213846] by pvollan@apple.com
  • 3 edits in trunk/Source/WebKit/win

[Win] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=169545

Reviewed by Brent Fulgham.

Fix inconsistent dll linkage warnings.

  • WebKitDLL.cpp:
  • WebKitDLL.h:
8:46 AM Changeset in webkit [213845] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] Remove dead code from previous autotools build in build-jsc
https://bugs.webkit.org/show_bug.cgi?id=169555

Reviewed by Carlos Garcia Campos.

  • Scripts/build-jsc:

(buildMyProject):

7:42 AM Changeset in webkit [213844] by zandobersek@gmail.com
  • 2 edits
    2 adds
    2 deletes in trunk/Source/WebKit2

[WK2] Move AcceleratedSurface files under WebProcess/WebPage/CoordinatedGraphics
https://bugs.webkit.org/show_bug.cgi?id=169348

Reviewed by Carlos Garcia Campos.

Move the AcceleratedSurface header and implementation files under the
WebProcess/WebPage directory since that class is not specific to the
GTK+ port.

  • PlatformGTK.cmake:
  • WebProcess/WebPage/AcceleratedSurface.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/gtk/AcceleratedSurface.cpp.

(WebKit::AcceleratedSurface::create):
(WebKit::AcceleratedSurface::AcceleratedSurface):
(WebKit::AcceleratedSurface::resize):

  • WebProcess/WebPage/AcceleratedSurface.h: Renamed from Source/WebKit2/WebProcess/WebPage/gtk/AcceleratedSurface.h.

(WebKit::AcceleratedSurface::window):
(WebKit::AcceleratedSurface::surfaceID):
(WebKit::AcceleratedSurface::shouldPaintMirrored):

7:04 AM Changeset in webkit [213843] by Konstantin Tokarev
  • 2 edits in trunk/Source/WebKit2

[cmake] [WK2] Guard flags intended for GCC-like compilers with COMPILER_IS_GCC_OR_CLANG
https://bugs.webkit.org/show_bug.cgi?id=169551

Reviewed by Yusuke Suzuki.

This change allows building WK2 code with MSVC.

  • CMakeLists.txt:
6:26 AM Changeset in webkit [213842] by Carlos Garcia Campos
  • 8 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213833 - ImageDecoder can be deleted while the async decoder thread is still using it
https://bugs.webkit.org/show_bug.cgi?id=169199

Reviewed by Carlos Garcia Campos.

Make the image decoder used by ImageSource and ImageFrameCache into a RefPtr instead of
and unique_ptr, and pass a reference to the decoder thread. This ensures that the decoder
will stay alive as long as the decoding thread is processing frames. Also, stop the async
decoding queue if a new decoder is set to ImageFrameCache.

No new tests.

  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::setDecoder):
(WebCore::ImageFrameCache::decoder):
(WebCore::ImageFrameCache::startAsyncDecodingQueue):
(WebCore::ImageFrameCache::metadata):

  • platform/graphics/ImageFrameCache.h:

(WebCore::ImageFrameCache::setDecoder): Deleted.
Moved to source file so we can keep the ImageDecoder forward declaration.
(WebCore::ImageFrameCache::decoder): Deleted.
Moved to source file so we can keep the ImageDecoder forward declaration.

  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageDecoderCG.h:

(WebCore::ImageDecoder::create):

  • platform/graphics/win/ImageDecoderDirect2D.h:

(WebCore::ImageDecoder::create):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

  • platform/image-decoders/ImageDecoder.h:
6:24 AM Changeset in webkit [213841] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Tools

Merge r213789 - MiniBrowser: a tab closed from javascript always closes the window
https://bugs.webkit.org/show_bug.cgi?id=169415

Reviewed by Michael Catanzaro.

When I implemented tabs support in MiniBrowser I forgot about web view close. We connect to the signal (only for
the active tab) and close the window. That worked when we didn't have tabs, but now we should close the tab, or
the window if it's the last tab.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewClose): Destroy the window if therte's only one tab, otherwise search for the tab corresponding to the web
view and destroy it.
(browserWindowSwitchTab): Re-connect to close signal, we want to handle close on all tabs.

6:24 AM Changeset in webkit [213840] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore

Merge r213773 - Structure::willStoreValueSlow needs to keep the property table alive until the end
https://bugs.webkit.org/show_bug.cgi?id=169520

Reviewed by Michael Saboff.

We use pointers logically interior to propertyTable after doing a GC. We need to prevent the
compiler from optimizing away pointers to propertyTable.

  • heap/HeapCell.cpp:

(JSC::HeapCell::use):

  • heap/HeapCell.h:

(JSC::HeapCell::use): Introduce API for keeping a pointer alive until some point in execution.

  • runtime/Structure.cpp:

(JSC::Structure::willStoreValueSlow): Use HeapCell::use() to keep the pointer alive.

5:59 AM Changeset in webkit [213839] by Carlos Garcia Campos
  • 3 edits
    1 add in releases/WebKitGTK/webkit-2.16

Merge r213742 - JSC: BindingNode::bindValue doesn't increase the scope's reference count.
https://bugs.webkit.org/show_bug.cgi?id=168546
<rdar://problem/30589551>

Reviewed by Saam Barati.

JSTests:

  • stress/regress-168546.js: Added.

Source/JavaScriptCore:

We should protect the scope RegisterID with a RefPtr while it is still needed.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitLoopHeader):
(JSC::ForOfNode::emitBytecode):
(JSC::BindingNode::bindValue):

5:56 AM Changeset in webkit [213838] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.16

Merge r213711 - imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html is unreliable
https://bugs.webkit.org/show_bug.cgi?id=169465

Reviewed by Zalan Bujtas.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt:

Source/WebCore:

It shows all subtests passing but that is a bug. We don't even support all the unit types.
The test occasionally fails when reloading, that failing results are actually the correct ones.

  • css/parser/SizesAttributeParser.cpp:

(WebCore::SizesAttributeParser::SizesAttributeParser):

Ensure we have correct size for the iframe before parsing 'sizes' attribute values. The interpretation of
these may depend on the iframe dimensions.

5:45 AM Changeset in webkit [213837] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore

Merge r213648 - WebKit: JSC: JSObject::ensureLength doesn't check if ensureLengthSlow failed
https://bugs.webkit.org/show_bug.cgi?id=169215

Reviewed by Mark Lam.

This doesn't have a test because it would be a very complicated test.

  • runtime/JSObject.h:

(JSC::JSObject::ensureLength): If ensureLengthSlow returns false, we need to return false.

5:26 AM Changeset in webkit [213836] by Carlos Garcia Campos
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r213646 - Align Document.elementFromPoint() with the CSSOM specification
https://bugs.webkit.org/show_bug.cgi?id=169403

Reviewed by Sam Weinig.

Source/WebCore:

Align Document.elementFromPoint() with the CSSOM specification:

In particular, the parameters should be mandatory and of type double.

The parameters are mandatory in both Firefox and Chrome already. Parameters
are finite floating point in Firefox and integers in Chrome.

Test: fast/dom/elementFromPoint-parameters.html

  • dom/DocumentOrShadowRoot.idl:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::elementFromPoint):

  • dom/TreeScope.h:

LayoutTests:

Add layout test coverage.

  • fast/dom/elementFromPoint-parameters-expected.txt: Added.
  • fast/dom/elementFromPoint-parameters.html: Added.
  • fast/dom/non-numeric-values-numeric-parameters-expected.txt:
  • fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
5:09 AM Changeset in webkit [213835] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r213638 - Correctly process the return value of gdk_drag_context_get_selected_action()

Reviewed by Carlos Garcia Campos.

It returns the action itself and not the bitmask.

  • UIProcess/gtk/DragAndDropHandler.cpp:

(WebKit::DragAndDropHandler::drop):

5:06 AM Changeset in webkit [213834] by Carlos Garcia Campos
  • 12 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r213606 - Parameter to input.setCustomValidity() should not be nullable
https://bugs.webkit.org/show_bug.cgi?id=169332

Reviewed by Sam Weinig.

Source/WebCore:

Parameter to input.setCustomValidity() should not be nullable:

Firefox and Chrome agree with the specification so the change
should be safe.

Test: fast/forms/setCustomValidity-null-parameter.html

  • html/HTMLButtonElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLKeygenElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTextAreaElement.idl:

LayoutTests:

  • fast/forms/ValidityState-customError-expected.txt:
  • fast/forms/ValidityState-customError.html:

Rebaseline now that behavior has changed when passing null or undefined
to setCustomValidity().

  • fast/forms/setCustomValidity-null-parameter-expected.txt: Added.
  • fast/forms/setCustomValidity-null-parameter.html: Added.

Add layout test coverage.

5:01 AM Changeset in webkit [213833] by magomez@igalia.com
  • 8 edits in trunk/Source/WebCore

ImageDecoder can be deleted while the async decoder thread is still using it
https://bugs.webkit.org/show_bug.cgi?id=169199

Reviewed by Carlos Garcia Campos.

Make the image decoder used by ImageSource and ImageFrameCache into a RefPtr instead of
and unique_ptr, and pass a reference to the decoder thread. This ensures that the decoder
will stay alive as long as the decoding thread is processing frames. Also, stop the async
decoding queue if a new decoder is set to ImageFrameCache.

No new tests.

  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::setDecoder):
(WebCore::ImageFrameCache::decoder):
(WebCore::ImageFrameCache::startAsyncDecodingQueue):
(WebCore::ImageFrameCache::metadata):

  • platform/graphics/ImageFrameCache.h:

(WebCore::ImageFrameCache::setDecoder): Deleted.
Moved to source file so we can keep the ImageDecoder forward declaration.
(WebCore::ImageFrameCache::decoder): Deleted.
Moved to source file so we can keep the ImageDecoder forward declaration.

  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageDecoderCG.h:

(WebCore::ImageDecoder::create):

  • platform/graphics/win/ImageDecoderDirect2D.h:

(WebCore::ImageDecoder::create):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

  • platform/image-decoders/ImageDecoder.h:
4:45 AM Changeset in webkit [213832] by Carlos Garcia Campos
  • 9 edits
    12 deletes in releases/WebKitGTK/webkit-2.16

Merge r213593 - CSS Multicolumn should not clip columns horizontally
https://bugs.webkit.org/show_bug.cgi?id=169363

Reviewed by Sam Weinig.

Source/WebCore:

Revised multiple tests in fast/multicol.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
Stop clipping horizontally. Section 8.1 of the spec changed from "clip" to "don't clip",
so we're changing to match the latest draft. Keep iBooks-based pagination clipping though.

LayoutTests:

  • fast/multicol/newmulticol/adjacent-spanners-expected.html:
  • fast/multicol/newmulticol/adjacent-spanners.html:
  • fast/multicol/newmulticol/clipping-expected.html:
  • fast/multicol/newmulticol/clipping.html:
  • fast/multicol/newmulticol/spanner-inline-block-expected.html:
  • fast/multicol/newmulticol/spanner-inline-block.html:
4:44 AM Changeset in webkit [213831] by Manuel Rego Casasnovas
  • 100 edits in trunk

Unprefix -webkit-min-content, -webkit-max-content and -webkit-fit-content
https://bugs.webkit.org/show_bug.cgi?id=169195

Reviewed by Sergio Villar Senin.

Based on Blink r200846 by <cbiesinger@chromium.org>.
https://src.chromium.org/viewvc/blink?revision=200846&view=revision

Source/WebCore:

This patch adds support for the unprefixed version of these properties,
while it keeps the prefixed ones working too.
-webkit-fill-available is left out of this change, as the CSS WG
is still defining the final keyword and behavior.

With this patch WebKit will be in the same situation than Blink
regarding these intrinsic sizing keywords (see http://crbug.com/245157).

Test: fast/css-intrinsic-dimensions/height-property-value.html

fast/css-intrinsic-dimensions/width-property-value.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init):

  • css/CSSValueKeywords.in:
  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertLengthSizing):
(WebCore::StyleBuilderConverter::createGridTrackBreadth):

  • css/html.css:

(fieldset):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::validWidthOrHeightKeyword):
(WebCore::isGridTrackFixedSized):
(WebCore::consumeGridBreadth):

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):

  • html/track/VTTCue.cpp:

(WebCore::VTTCueBox::applyCSSProperties):

LayoutTests:

For most of the tests the only change is that we remove the prefix in these properties.
Additionally we're checking the behavior of both the prefixed and unprefixed versions in:

  • fast/css-intrinsic-dimensions/height-property-value.html
  • fast/css-intrinsic-dimensions/width-property-value.html

On top of that, a few tests from the CSS Grid Layout W3C test suite are now passing.

  • TestExpectations:
  • css3/flexbox/flexitem.html:
  • css3/flexbox/orthogonal-writing-modes-and-intrinsic-sizing-expected.txt: Update results

as tests is now passing (it was using "min-content" already and thus failing on WebKit).

  • css3/flexbox/overflow-auto-resizes-correctly.html:
  • fast/css-grid-layout/fit-content-columns-expected.html:
  • fast/css-grid-layout/fit-content-columns.html:
  • fast/css-grid-layout/fit-content-rows-expected.html:
  • fast/css-grid-layout/fit-content-rows.html:
  • fast/css-grid-layout/flex-and-content-sized-resolution-columns.html:
  • fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html:
  • fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
  • fast/css-grid-layout/float-not-protruding-into-next-grid-item.html:
  • fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
  • fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-auto-columns-rows-get-set.html:
  • fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
  • fast/css-grid-layout/grid-auto-columns-rows-update.html:
  • fast/css-grid-layout/grid-auto-fill-columns.html:
  • fast/css-grid-layout/grid-auto-fill-rows.html:
  • fast/css-grid-layout/grid-auto-fit-columns.html:
  • fast/css-grid-layout/grid-auto-fit-rows.html:
  • fast/css-grid-layout/grid-auto-repeat-intrinsic.html:
  • fast/css-grid-layout/grid-automatic-minimum-for-auto-columns.html:
  • fast/css-grid-layout/grid-automatic-minimum-for-auto-rows.html:
  • fast/css-grid-layout/grid-change-intrinsic-size-with-auto-repeat-tracks.html:
  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
  • fast/css-grid-layout/grid-columns-rows-get-set.html:
  • fast/css-grid-layout/grid-content-alignment-overflow.html:
  • fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks.html:
  • fast/css-grid-layout/grid-content-sized-columns-resolution.html:
  • fast/css-grid-layout/grid-dynamic-updates-relayout.html:
  • fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt:
  • fast/css-grid-layout/grid-element-auto-repeat-get-set.html:
  • fast/css-grid-layout/grid-element-repeat-get-set.html:
  • fast/css-grid-layout/grid-grow-tracks-to-their-max.html:
  • fast/css-grid-layout/grid-gutters-and-flex-content.html:
  • fast/css-grid-layout/grid-gutters-and-tracks.html:
  • fast/css-grid-layout/grid-gutters-get-set.html:
  • fast/css-grid-layout/grid-indefinite-calculated-height-crash-expected.txt:
  • fast/css-grid-layout/grid-indefinite-calculated-height-crash.html:
  • fast/css-grid-layout/grid-initialize-span-one-items.html:
  • fast/css-grid-layout/grid-intrinsic-maximums.html:
  • fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
  • fast/css-grid-layout/grid-item-auto-margins-must-respect-specified-margins.html:
  • fast/css-grid-layout/grid-item-order-in-content-sized-columns-resolution.html:
  • fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
  • fast/css-grid-layout/grid-item-sizing-with-orthogonal-flows.html:
  • fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows.html:
  • fast/css-grid-layout/grid-item-with-border-in-intrinsic.html:
  • fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
  • fast/css-grid-layout/grid-preferred-logical-widths.html:
  • fast/css-grid-layout/grid-template-shorthand-get-set.html:
  • fast/css-grid-layout/grid-update-sizes-after-distributing-all.html:
  • fast/css-grid-layout/implicit-position-dynamic-change.html:
  • fast/css-grid-layout/mark-as-infinitely-growable.html:
  • fast/css-grid-layout/min-content-row-must-shrink-when-column-grows.html:
  • fast/css-grid-layout/minmax-max-content-resolution-columns.html:
  • fast/css-grid-layout/minmax-max-content-resolution-rows.html:
  • fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
  • fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
  • fast/css-grid-layout/minmax-spanning-resolution-columns.html:
  • fast/css-grid-layout/minmax-spanning-resolution-rows.html:
  • fast/css-grid-layout/named-grid-line-get-set-expected.txt:
  • fast/css-grid-layout/named-grid-line-get-set.html:
  • fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html:
  • fast/css-grid-layout/non-grid-columns-rows-get-set.html:
  • fast/css-grid-layout/non-named-grid-line-get-set-expected.txt:
  • fast/css-grid-layout/non-named-grid-line-get-set.html:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
  • fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js:
  • fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js:
  • fast/css-intrinsic-dimensions/css-tables.html:
  • fast/css-intrinsic-dimensions/height-property-value-expected.txt:
  • fast/css-intrinsic-dimensions/height-property-value.html:
  • fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html:
  • fast/css-intrinsic-dimensions/intrinsic-sized-blocks.html:
  • fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html:
  • fast/css-intrinsic-dimensions/tables.html:
  • fast/css-intrinsic-dimensions/width-property-value-expected.txt:
  • fast/css-intrinsic-dimensions/width-property-value.html:
  • fast/events/key-events-in-editable-gridbox.html:
  • fast/regions/intrinsic-sized-regions.html:
  • fast/regions/overflow/overflow-scrollable-fit-complex-expected.html:
  • fast/replaced/before-content-intrinsic-crash.html:
  • fast/table/assert-on-min-max-content-values.html:
  • imported/blink/svg/css/replaced-intrinsic-ratio-min-width-min-content.html:
4:44 AM Changeset in webkit [213830] by Carlos Garcia Campos
  • 17 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213563 - Asynchronous image decoding should consider the drawing size if it is smaller than the size of the image
https://bugs.webkit.org/show_bug.cgi?id=168814

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-03-07
Reviewed by Simon Fraser.

If the image destinationRect.size() is smaller than the imageSourceSize
(e.g. 3000x3000 pixels), CGImageSourceCreateThumbnailAtIndex() is slower
than CGImageSourceCreateImageAtIndex() in decoding this image. To overcome
this problem, the entry (kCGImageSourceThumbnailMaxPixelSize,
max(destinationRect.width, destinationRect.height)) is added to the options
dictionary when calling CGImageSourceCreateThumbnailAtIndex(). This will
avoid copying a large block of memory for the unscaled bitmap image.

An argument named 'sizeForDrawing' of type std::optional<IntSize> will be passed
all the way from BitmapImage to ImageDecoder. If bool(sizeForDrawing) equals
true that means we want async image decoding. Otherwise the image will be decoded
synchronously.

The subsamplingLevel argument will be passed as std::optional<SubsamplingLevel>.
to ImageFrame query functions. When combined with sizeForDrawing, the meaning of
these two arguments will be the following:
-- !bool(subsamplingLevel): No caching is required. return what is stored in ImageFrameCache.
-- bool(subsamplingLevel) && !bool(sizeForDrawing): Match subsamplingLevel only. Recache if it's different.
-- bool(subsamplingLevel) && bool(sizeForDrawing): Match both both. . Recache if one of them is different.

We are going to allow decoding the same ImageFrame for different sizeForDrawings.
The rule is a new decoding is allowed only if the maxPixelSize(sizeForDrawing) of
the last requested image decoding is less than the new request sizeForDrawing.

  • loader/cache/CachedImage.h: Add a helper function which returns the URL of a CachedImage.
  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameImageAtIndex): Add a new argument for sizeForDrawing.
(WebCore::BitmapImage::nativeImage): Pass an empty sizeForDrawing to frameImageAtIndex(). We an image with the native size.
(WebCore::BitmapImage::nativeImageForCurrentFrame): Ditto.
(WebCore::BitmapImage::nativeImageOfSize): Ditto.
(WebCore::BitmapImage::draw): Pass the destRect.size() to internalStartAnimation().
(WebCore::BitmapImage::isAsyncDecodingRequired): A helper function to answer the question
whether the async image decoding is required. It takes into account the animated images, the
large image, and the image size.
(WebCore::BitmapImage::internalStartAnimation): If async image decoding is requested for this frame m_sizeForDraw
will be set. If internalStartAnimation() is called from startAnimation(), sizeForDraw will be empty. In this
case no async image decoding will be requested. This happens only when startAnimation() is called from outside
BitmapImage::draw().
(WebCore::BitmapImage::advanceAnimation): Change the log message.
(WebCore::BitmapImage::newFrameNativeImageAvailableAtIndex): Ditto.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/ImageFrame.cpp:

(WebCore::ImageFrame::operator=): Include m_sizeForDraw in the properties of ImageFrame.
(WebCore::maxPixelSize): Returns the maximum of the width() and the height of an IntSize.
(WebCore::ImageFrame::isBeingDecoded): Returns true if the ImageFrame is currently being decoded for a specific sizeForDrawing.
(WebCore::ImageFrame::hasValidNativeImage): Ditto.

  • platform/graphics/ImageFrame.h:

(WebCore::ImageFrame::enqueueSizeForDecoding): Adds a new sizeForDrawing; this sets the ImageFrame is being decoded for this sizeForDrawing.
(WebCore::ImageFrame::dequeueSizeForDecoding): Removes the first sizeForDrawing was enqueued; this marks this ImageFrame has finished decoding for this sizeForDrawing.
(WebCore::ImageFrame::clearSizeForDecoding): Clears the sizeForDecoding queue. Marks the ImageFrame for not being decoded.
(WebCore::ImageFrame::isEmpty): Replace Decoding::Empty by Decoding::None.
(WebCore::ImageFrame::sizeForDrawing): Returns the ImageFrame sizeForDraw.
(WebCore::ImageFrame::hasDecodedNativeImage): Returns true if the ImageFrame doesn't need decoding before drawing.
(WebCore::ImageFrame::hasValidNativeImage): Deleted. Moved to the source file.

  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::setFrameNativeImageAtIndex): Take a new argument for sizeForDraw.
(WebCore::ImageFrameCache::setFrameMetadataAtIndex): When sizeForDraw is set, use the decoder to get the image
frame size. Otherwise, get the size of the nativeImage.
(WebCore::ImageFrameCache::replaceFrameNativeImageAtIndex): Take a new argument for sizeForDraw.
(WebCore::ImageFrameCache::cacheFrameNativeImageAtIndex): Ditto.
(WebCore::ImageFrameCache::startAsyncDecodingQueue): Pass the sizeForDraw as a new property of the ImageFrame.
(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex): Store sizeForDraw in ImageFrameRequest. Delete unneeded check.
This function always receives a valid subsamplingLevel.
(WebCore::ImageFrameCache::stopAsyncDecodingQueue): Marks all the queued ImageFrames for not being decoded.
(WebCore::ImageFrameCache::frameAtIndexCacheIfNeeded): Take a new argument for sizeForDraw. If this function fixes the
properties of ImageFrame properties, keep the old sizeForDraw and/or subsamplingLevel. If a new frame is
decoded, no async image decoding will be done in this code path. So pass an empty std::optional<IntSize> to
ImageDecoder::createFrameImageAtIndex() and store std::optional<IntSize> in ImageFrame.
(WebCore::ImageFrameCache::frameMetadataAtIndex): A new helper function which takes a variable number of arguments which
will be passed to the (ImageFrame::*functor).
(WebCore::ImageFrameCache::frameMetadataAtIndexCacheIfNeeded): Make this function takes a variable number of arguments which
will be passed to the frameAtIndexCacheIfNeeded().
(WebCore::ImageFrameCache::size): Pass an Metadata, valid SubsamplingLevel and empty sizeForDraw to frameMetadataAtIndexCacheIfNeeded().
(WebCore::ImageFrameCache::sizeRespectingOrientation): Ditto.
(WebCore::ImageFrameCache::singlePixelSolidColor): Pass MetadataAndImage, empty SubsamplingLevel and empty sizeForDraw to
frameMetadataAtIndexCacheIfNeeded(); we can use the current frame image regardless of its size.
(WebCore::ImageFrameCache::frameIsBeingDecodedAtIndex): Pass the ImageFrame method as a function argument instead of
passing it as a template argument.
(WebCore::ImageFrameCache::frameIsCompleteAtIndex): Ditto.
(WebCore::ImageFrameCache::frameHasAlphaAtIndex): Ditto.
(WebCore::ImageFrameCache::frameHasImageAtIndex): Ditto.
(WebCore::ImageFrameCache::frameHasValidNativeImageAtIndex): Pass subsamplingLevel and sizeForDrawing to frameMetadataAtIndex().
(WebCore::ImageFrameCache::frameHasDecodedNativeImage): New helper function to answer the question whether an ImageFrame will need
decoding when drawing or not.
(WebCore::ImageFrameCache::frameSubsamplingLevelAtIndex): Pass the ImageFrame method as a function argument instead of
passing it as a template argument.
(WebCore::ImageFrameCache::frameSizeAtIndex): Ditto.
(WebCore::ImageFrameCache::frameBytesAtIndex): Ditto.
(WebCore::ImageFrameCache::frameDurationAtIndex): Ditto.
(WebCore::ImageFrameCache::frameOrientationAtIndex):
(WebCore::ImageFrameCache::frameImageAtIndex): Ditto.
(WebCore::ImageFrameCache::frameAtIndex): Deleted. Renamed to frameAtIndexCacheIfNeeded().

  • platform/graphics/ImageFrameCache.h:

(WebCore::ImageFrameCache::frameAtIndexCacheIfNeeded):

  • platform/graphics/ImageObserver.h: Define a virtual function for image sourceUrl().
  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::frameImageAtIndex): Take a new argument for sizeForDrawing.

  • platform/graphics/ImageSource.h:

(WebCore::ImageSource::requestFrameAsyncDecodingAtIndex): Take a new argument for sizeForDrawing.
(WebCore::ImageSource::frameHasValidNativeImageAtIndex): Ditto.
(WebCore::ImageSource::frameHasDecodedNativeImage): New helper function.
(WebCore::ImageSource::frameImageAtIndex): Ditto.

  • platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::createImageSourceOptions): Create a dictionary with the basic image decoding options.
(WebCore::createImageSourceAsyncOptions): Create a dictionary with the basic asynchronous image decoding options.
(WebCore::appendImageSourceOption): Append the SubsamplingLevel or the MaxPixelSize option to an CGImageSource options dictionary.
(WebCore::appendImageSourceOptions): Append the SubsamplingLevel and the MaxPixelSize option to an CGImageSource options dictionary.
(WebCore::imageSourceOptions): Creates a dictionary for the synchronous image decoding options.
(WebCore::imageSourceAsyncOptions): Creates a dictionary for the asynchronous image decoding options.
(WebCore::ImageDecoder::createFrameImageAtIndex): Replace the DecodingMode argument by an std::optional<IntSize>.

  • platform/graphics/cg/ImageDecoderCG.h: Change a prototype.
  • platform/graphics/win/ImageDecoderDirect2D.cpp:

(WebCore::ImageDecoder::createFrameImageAtIndex): Replace the DecodingMode argument by an std::optional<IntSize>.

  • platform/graphics/win/ImageDecoderDirect2D.h: Change a prototype.
  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::createFrameImageAtIndex): Replace the DecodingMode argument by an std::optional<IntSize>.

  • platform/image-decoders/ImageDecoder.h: Change a prototype.
4:40 AM Changeset in webkit [213829] by Carlos Garcia Campos
  • 8 edits in releases/WebKitGTK/webkit-2.16

Merge r213546 - [URLParser] Fix file URLs that are just file:// and a Windows drive letter
https://bugs.webkit.org/show_bug.cgi?id=169242

Patch by Alex Christensen <achristensen@webkit.org> on 2017-03-07
Reviewed by Tim Horton.

LayoutTests/imported/w3c:

  • web-platform-tests/url/a-element-expected.txt:
  • web-platform-tests/url/a-element-xhtml-expected.txt:
  • web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

This is specified in https://url.spec.whatwg.org/#file-host-state and tested by a newly-passing
web platform test. I added the check for the windows drive quirk in the FileHost state of the
parser but I forgot it when FileHost is the terminal state.

  • platform/URLParser.cpp:

(WebCore::URLParser::parse):

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

4:39 AM Changeset in webkit [213828] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r213534 - Simple line layout: Do not use invalid m_lastNonWhitespaceFragment while removing trailing whitespace.
https://bugs.webkit.org/show_bug.cgi?id=169288
rdar://problem/30576976

Reviewed by Antti Koivisto.

Source/WebCore:

When the current line has nothing but whitespace, m_lastNonWhitespaceFragment is invalid so
we should not use the start/end values to decide how many characters we need to revert.
This patch makes m_lastNonWhitespaceFragment optional. When it's invalid we just remove
all the runs from the current line since they are all considered whitespace runs.

Test: fast/text/simple-line-layout-line-is-all-whitespace.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::revertAllRunsOnCurrentLine):
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):

LayoutTests:

  • fast/text/simple-line-layout-line-is-all-whitespace-expected.txt: Added.
  • fast/text/simple-line-layout-line-is-all-whitespace.html: Added.
4:38 AM Changeset in webkit [213827] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213522 - ShadowBlur::calculateLayerBoundingRect doesn't need to return the enclosingIntRect of layerRect
https://bugs.webkit.org/show_bug.cgi?id=168650

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-07
Reviewed by Simon Fraser.

No new tests, no behavior change.

  • platform/graphics/ShadowBlur.h: Change the type of return value

from IntRect to IntSize.

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::calculateLayerBoundingRect): Ditto.
(WebCore::ShadowBlur::drawRectShadow): Rename a variable layerRect layerSize.
(WebCore::ShadowBlur::drawInsetShadow): Ditto.
(WebCore::ShadowBlur::drawRectShadowWithoutTiling): Ditto.
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling): Ditto.
(WebCore::ShadowBlur::beginShadowLayer): Ditto.

4:38 AM Changeset in webkit [213826] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213523 - Animated GIFs fail to play in multi-column layout
https://bugs.webkit.org/show_bug.cgi?id=167901
<rdar://problem/30382262>

Reviewed by Zalan Bujtas.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):
Make sure to handle the case where we pass in a null repaintContainer and need
to cross a multicolumn flow thread -> region boundary as a result.

4:34 AM Changeset in webkit [213825] by Carlos Garcia Campos
  • 20 edits
    1 copy
    2 adds
    2 deletes in releases/WebKitGTK/webkit-2.16

Merge r213517 - Align initEvent / initCustomEvent / initMessageEvent with the latest specification
https://bugs.webkit.org/show_bug.cgi?id=169176

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Re-sync web-platform tests from upstream after:

  • web-platform-tests/dom/events/CustomEvent-expected.txt:
  • web-platform-tests/dom/events/CustomEvent.html:
  • web-platform-tests/dom/events/Event-initEvent-expected.txt:
  • web-platform-tests/dom/events/Event-initEvent.html:
  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/dom/interfaces.html:
  • web-platform-tests/html/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/interfaces.html:
  • web-platform-tests/html/dom/resources/interfaces.idl: Copied from LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces.html.
  • web-platform-tests/html/dom/resources/untested-interfaces.idl: Added.
  • web-platform-tests/html/webappapis/scripting/events/messageevent-constructor-expected.txt: Removed.
  • web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.html: Removed.
  • web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html:

Source/WebCore:

Align initEvent / initCustomEvent / initMessageEvent with the latest specification
after:

In particular, the following changes were made:

  • initEvent: The length property now properly returns 1 instead of 3 as only the first parameter is mandatory. We were already behaving correcting the the length property value was wrong because we forgot to drop a hack from the bindings generator.
  • initCustomEvent: Make all parameters except the first optional. Previously, all parameters were mandatory so this is safe.
  • initMessageEvent: Drop the custom code and mark the first parameter as mandatory. A side effect of dropping the custom code is that null is no longer considered as valid input for the last parameter. The parameter is of type sequence<> and the new behavior is consistent with the specification and Firefox. If it turns out to break existing content, I'll make the parameter nullable in a follow-up.

No new tests, updated existing tests.

  • bindings/js/JSMessageEventCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:

(GeneratePropertiesHashTable):

  • dom/CustomEvent.idl:
  • dom/MessageEvent.idl:

LayoutTests:

Updated existing tests to reflect behavior change.

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
  • fast/eventsource/eventsource-attribute-listeners.html:
4:16 AM Changeset in webkit [213824] by Chris Dumez
  • 17 edits in trunk/Source

[WK2] Only report background WebProcesses as unresponsive in the background after 90 seconds
https://bugs.webkit.org/show_bug.cgi?id=169425
<rdar://problem/30954003>

Reviewed by Andreas Kling.

Source/WebKit2:

The background responsiveness checking was previously relying on the
isResponsive(std::function<void(bool)>) API which uses the ResponsivenessTimer
and has a timeout of 3 seconds. We believe this is too aggressive for background
tabs. Update BackgroundResponsiveTimer to stop relying on ResponsivenessTimer
and have its own timeout Timer which a delay of 90 seconds instead.

  • UIProcess/API/C/mac/WKPagePrivateMac.mm:

(-[WKObservablePageState _webProcessIsResponsive]):

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController _webProcessIsResponsive]):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _webProcessIsResponsive]):

  • UIProcess/BackgroundProcessResponsivenessTimer.cpp:

(WebKit::BackgroundProcessResponsivenessTimer::BackgroundProcessResponsivenessTimer):
(WebKit::BackgroundProcessResponsivenessTimer::~BackgroundProcessResponsivenessTimer):
(WebKit::BackgroundProcessResponsivenessTimer::updateState):
(WebKit::BackgroundProcessResponsivenessTimer::didReceiveBackgroundResponsivenessPong):
(WebKit::BackgroundProcessResponsivenessTimer::invalidate):
(WebKit::BackgroundProcessResponsivenessTimer::processTerminated):
(WebKit::BackgroundProcessResponsivenessTimer::responsivenessCheckTimerFired):
(WebKit::BackgroundProcessResponsivenessTimer::timeoutTimerFired):
(WebKit::BackgroundProcessResponsivenessTimer::setResponsive):
(WebKit::BackgroundProcessResponsivenessTimer::shouldBeActive):
(WebKit::BackgroundProcessResponsivenessTimer::scheduleNextResponsivenessCheck):
(WebKit::BackgroundProcessResponsivenessTimer::client):

  • UIProcess/BackgroundProcessResponsivenessTimer.h:

(WebKit::BackgroundProcessResponsivenessTimer::isResponsive):

  • UIProcess/ResponsivenessTimer.h:

(WebKit::ResponsivenessTimer::isResponsive):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetStateAfterProcessExited):
(WebKit::WebPageProxy::updateBackingStoreDiscardableState):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::isResponsive):
(WebKit::WebProcessProxy::didReceiveBackgroundResponsivenessPing):
(WebKit::WebProcessProxy::processTerminated):
(WebKit::WebProcessProxy::updateBackgroundResponsivenessTimer):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::backgroundResponsivenessPing):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Source/WTF:

  • wtf/RunLoop.h:

(WTF::RunLoop::TimerBase::startRepeating):
(WTF::RunLoop::TimerBase::startOneShot):
Add overloads to RunLoop::Timer that take Seconds in parameter,
for convenience.

  • wtf/Seconds.h:

(WTF::Seconds::fromHours):
(WTF::seconds_literals::operator _h):
Allow _h suffix for initializing Seconds type to hours.

4:12 AM Changeset in webkit [213823] by pvollan@apple.com
  • 3 edits in trunk/Source/WebKit/win

Unreviewed Win build fix.

WebCore::CookiesStrategy::addCookie has been removed, we should also remove the override.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::addCookie): Deleted.
(WebPlatformStrategies::addCookie): Deleted.

  • WebCoreSupport/WebPlatformStrategies.h:
4:07 AM Changeset in webkit [213822] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r213501 - Validate DOM after potentially destructive actions during parser insert operations
https://bugs.webkit.org/show_bug.cgi?id=169222
<rdar://problem/30689729>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Do not perform an insert operation if the next child's parent is no longer
part of the tree. This can happen if JavaScript runs during node removal
events and modifies the contents of the document.

This patch was inspired by a similar Blink change by Marius Mlynski:
<https://src.chromium.org/viewvc/blink?view=revision&revision=200690>

Tests: fast/parser/scriptexec-during-parserInsertBefore.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::executeReparentTask):
(WebCore::executeInsertAlreadyParsedChildTask):

LayoutTests:

This change merges a Blink test case from:
<https://src.chromium.org/viewvc/blink?view=revision&revision=200690>

  • fast/parser/scriptexec-during-parserInsertBefore-expected.txt: Added.
  • fast/parser/scriptexec-during-parserInsertBefore.html: Added.
4:04 AM Changeset in webkit [213821] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213493 - [CMake] SN-DBS fails to build: Cannot open include file: 'WebCoreTestSupportPrefix.h'
https://bugs.webkit.org/show_bug.cgi?id=169244

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-06
Reviewed by Alex Christensen.

A distributed build system SN-DBS can not find
WebCoreTestSupportPrefix.h without an include path to it.

  • CMakeLists.txt: Add 'WebCore/testing/js' to include paths.
4:02 AM Changeset in webkit [213820] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213491 - [cairo] error C2065: 'quality': undeclared identifier since r213412
https://bugs.webkit.org/show_bug.cgi?id=169240

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-06
Reviewed by Ryosuke Niwa.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::toDataURL): Name the unnamed second argument 'quality'.

4:01 AM Changeset in webkit [213819] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Tools

Merge r213485 - [GTK] Mark WTF_Lock.ContendedLongSection and WTF_WordLock.ContendedLongSection as slow.

Unreviewed test gardening.

The ContendedShortSection version of this tests were already marked as slow.
And the ContendedLongSection version takes more or less the same time to run.
They cause time outs on the bot sometimes.

  • Scripts/run-gtk-tests:

(TestRunner):

3:58 AM Changeset in webkit [213818] by Carlos Garcia Campos
  • 11 edits in releases/WebKitGTK/webkit-2.16

Merge r213469 - Fix URLs relative to file URLs with paths beginning with Windows drive letters
https://bugs.webkit.org/show_bug.cgi?id=169178

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

  • web-platform-tests/url/a-element-expected.txt:
  • web-platform-tests/url/a-element-xhtml-expected.txt:
  • web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Windows drives in file URLs can begin with windows drive letters, such as file:///C:/
which should not be removed when making other URLs relative to them.
See https://url.spec.whatwg.org/#file-slash-state

Covered by new API tests and newly passing web-platform-tests.

  • platform/URLParser.cpp:

(WebCore::URLParser::copyBaseWindowsDriveLetter):
(WebCore::URLParser::copyASCIIStringUntil):
(WebCore::URLParser::parse):

  • platform/URLParser.h:

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

LayoutTests:

  • fast/url/relative-win-expected.txt:

Some tests pass now. localhost should indeed be removed according to the latest spec.

3:48 AM Changeset in webkit [213817] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r213452 - Null pointer crash when loading module with unresolved import also as a script file
https://bugs.webkit.org/show_bug.cgi?id=168971

Reviewed by Saam Barati.

JSTests:

  • stress/re-execute-error-module.js: Added.

(shouldBe):
(async):

  • stress/resources/error-module.js: Added.

Source/JavaScriptCore:

If linking throws an error, this error should be re-thrown
when requesting the same module.

  • builtins/ModuleLoaderPrototype.js:

(globalPrivate.newRegistryEntry):

  • runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::link):

3:45 AM Changeset in webkit [213816] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.16

Merge r213449 - [css-grid] Stretch should grow and shrink items to fit its grid area
https://bugs.webkit.org/show_bug.cgi?id=163200

Reviewed by Darin Adler.

Source/WebCore:

After some discussions the CSS WG agreed that stretch should not only
grow items, but also shrink them to fit its grid area.
That way the "min-width|height: auto" is somehow ignored for grid items.
More info at: https://github.com/w3c/csswg-drafts/issues/283

The good part is that this allows us to remove some ugly code we've
in RenderBox that was only used by Grid Layout.

For images, we'll be stretching on both axis right now, so the aspect
ratio won't be preserved. The default behavior might change in those
cases, but that should be implemented in a different patch.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalHeight):

LayoutTests:

The tests have been updated according to the new expected behavior.

  • fast/css-grid-layout/grid-container-percentage-columns.html:
  • fast/css-grid-layout/min-width-height-auto-and-margins.html:
  • fast/css-grid-layout/min-width-height-auto.html:
3:43 AM Changeset in webkit [213815] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213448 - [GTK] WebProcess from WebKitGtk+ 2.15.x SIGSEVs in GIFLZWContext::doLZW(unsigned char const*, unsigned long) at Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:303
https://bugs.webkit.org/show_bug.cgi?id=167304

Reviewed by Carlos Garcia Campos.

Add a lock to ensure that the GIFImageReader that we are using for decoding is not deleted while
the decoding thread is using it.

No new tests.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::clearFrameBufferCache):

3:42 AM Changeset in webkit [213814] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore

Merge r213447 - Currency digits calculation in Intl.NumberFormat should call out to ICU
https://bugs.webkit.org/show_bug.cgi?id=169182

Patch by Daniel Ehrenberg <littledan@igalia.com> on 2017-03-06
Reviewed by Yusuke Suzuki.

  • runtime/IntlNumberFormat.cpp:

(JSC::computeCurrencyDigits):
(JSC::computeCurrencySortKey): Deleted.
(JSC::extractCurrencySortKey): Deleted.

3:41 AM Changeset in webkit [213813] by Carlos Garcia Campos
  • 18 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213445 - [GStreamer] Adopt nullptr
https://bugs.webkit.org/show_bug.cgi?id=123438

Patch by Vanessa Chipirrás Navalón <vchipirras@igalia.com> on 2017-03-06
Reviewed by Xabier Rodriguez-Calvar.

To adapt the code to the C++11 standard, all NULL or 0 pointers have been changed to nullptr.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::decodeAudioForBusCreation):

  • platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:

(WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer):
(WebCore::AudioSourceProviderGStreamer::configureAudioBin):
(WebCore::AudioSourceProviderGStreamer::setClient):
(WebCore::AudioSourceProviderGStreamer::handleNewDeinterleavePad):

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webkit_web_audio_src_init):
(webKitWebAudioSrcLoop):
(webKitWebAudioSrcChangeState):

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::setEnabled):

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::initializeGStreamer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine):
(WebCore::initializeGStreamerAndRegisterWebKitElements):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::newTextSample):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
Removed the unused second argument on processTableOfContentsEntry function.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):
Removed the unused second argument on this function.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Removed the unused second argument on processTableOfContentsEntry function.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::setMuted):
(WebCore::MediaPlayerPrivateGStreamerBase::muted):
(WebCore::MediaPlayerPrivateGStreamerBase::notifyPlayerOfMute):
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:

(WebCore::MediaPlayerPrivateGStreamerOwr::registerMediaEngine):

  • platform/graphics/gstreamer/TextCombinerGStreamer.cpp:

(webkit_text_combiner_init):
(webkitTextCombinerPadEvent):
(webkitTextCombinerRequestNewPad):
(webkitTextCombinerNew):

  • platform/graphics/gstreamer/TextSinkGStreamer.cpp:

(webkitTextSinkNew):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfActiveChanged):

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkit_video_sink_init):
(webkitVideoSinkProposeAllocation):
(webkitVideoSinkNew):

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:

(WebCore::VideoTrackPrivateGStreamer::setSelected):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):
(webKitWebSrcDispose):
(webKitWebSrcSetProperty):
(webKitWebSrcStop):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetProtocols):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(ResourceHandleStreamingClient::didFail):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

  • platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcGetProtocols):

3:40 AM Changeset in webkit [213812] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.16

Merge r213440 - Avoid backing store for layers with empty text nodes in a few more cases
https://bugs.webkit.org/show_bug.cgi?id=169185

Reviewed by Dan Bernstein.

Source/WebCore:

In hasPaintingNonLayerDescendants() we can check whether the RenderText's linesBoundingBox()
is empty to avoid backing store in a few more cases. Also use containsOnlyWhitespace() rather
than isAllCollapsibleWhitespace(), because there's no need for backing store for non-selectable
whitespace text.

Covered by existing tests.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

LayoutTests:

inline-block-no-backing.html enhanced to have a layer with non-collapsible whitespace (an &nbsp;).

Rebaselined other tests.

  • compositing/backing/inline-block-no-backing-expected.txt:
  • compositing/backing/inline-block-no-backing.html:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • css3/blending/blend-mode-clip-accelerated-blending-canvas-expected.txt:
  • platform/ios-simulator-wk2/compositing/backing/inline-block-no-backing-expected.txt:
  • platform/ios-simulator-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
3:38 AM Changeset in webkit [213811] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r213438 - Using <form> in <template> causes following <form> to get swallowed
https://bugs.webkit.org/show_bug.cgi?id=163552

Reviewed by Sam Weinig.

Source/WebCore:

As per the HTML specification [1], when finding a "form" tag in the "in body"
insertion mode, we should insert an HTML element for the token, and, if there
is no template element on the stack of open elements, set the form element
pointer to point to the element created.

We were missing the "if there is no template element on the stack of open
elements" check and setting the form element pointer unconditionally.
This patch fixes the issue.

[1] https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody:form-element-pointer-2

Test: fast/parser/form-after-template.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLFormElement):

LayoutTests:

Add layout test coverage.

  • fast/parser/form-after-template-expected.html: Added.
  • fast/parser/form-after-template.html: Added.
3:37 AM Changeset in webkit [213810] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213435 - Make some RenderLayer tree traversal in RenderLayerBacking more generic
https://bugs.webkit.org/show_bug.cgi?id=169177

Reviewed by Zalan Bujtas.

The real goal of this patch is reduce the number of callers of
RenderLayerBacking::isPaintDestinationForDescendantLayers() to one. To achieve that,
have the setContentsVisible() logic (which is really just about the CSS 'visibility' property)
do its own tree traversal which just consults layer.hasVisibleContent(). So
make descendantLayerPaintsIntoAncestor() a generic traversal function which walks
descendant layers which may paint into the target layer. The "Visible" in the name
reflects the fact that it can bypass a subtree for a layer with !hasVisibleDescendant().

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::traverseVisibleNonCompositedDescendantLayers):
(WebCore::RenderLayerBacking::isPaintDestinationForDescendantLayers):
(WebCore::RenderLayerBacking::hasVisibleNonCompositedDescendants):
(WebCore::descendantLayerPaintsIntoAncestor): Deleted.

  • rendering/RenderLayerBacking.h:
3:36 AM Changeset in webkit [213809] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213429 - Clarify some terminology in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=169174

Reviewed by Zalan Bujtas.

Rename some functions related to directly-composited background images and
box decorations for clarify.

Only behavior change is for canDirectlyCompositeBackgroundBackgroundImage() to check
GraphicsLayer::supportsContentsTiling(), which means that RenderLayerBacking::contentChanged()
will no longer trigger a updateGeometry() when it gets BackgroundImageChanged on non-
CoordinateGraphics platforms.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBoxDecorations):
(WebCore::canDirectlyCompositeBackgroundBackgroundImage):
(WebCore::hasPaintedBoxDecorationsOrBackgroundImage):
(WebCore::supportsDirectlyCompositedBoxDecorations):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents): Deleted.
(WebCore::canCreateTiledImage): Deleted.
(WebCore::hasVisibleBoxDecorationsOrBackgroundImage): Deleted.
(WebCore::supportsDirectBoxDecorationsComposition): Deleted.

  • rendering/RenderLayerBacking.h:
3:34 AM Changeset in webkit [213808] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r213420 - Remove duplicate initialization guard in WebKit2 logging initialization
https://bugs.webkit.org/show_bug.cgi?id=169164

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-03-04
Reviewed by Dan Bernstein.

  • Platform/Logging.cpp:

(WebKit::initializeLogChannelsIfNecessary):

3:32 AM Changeset in webkit [213807] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213405 - Clean up some RenderLayerBacking code
https://bugs.webkit.org/show_bug.cgi?id=169160

Reviewed by Dean Jackson.

Modern loops in descendantLayerPaintsIntoAncestor().

Rename RenderLayerBacking::paintsChildren() to RenderLayerBacking::paintsChildRenderers() to clarify that
it refers to renderers, not RenderLayers.

Rename RenderLayerBacking::paintsNonDirectCompositedBoxDecoration() to RenderLayerBacking::paintsBoxDecorations().
"Paints" already implies non-composited.

No behavior change.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::paintsChildRenderers):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::descendantLayerPaintsIntoAncestor):
(WebCore::RenderLayerBacking::paintsNonDirectCompositedBoxDecoration): Deleted.
(WebCore::RenderLayerBacking::paintsChildren): Deleted.

  • rendering/RenderLayerBacking.h:
3:31 AM Changeset in webkit [213806] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213404 - Clean up RenderImage and a RenderImageResource function
https://bugs.webkit.org/show_bug.cgi?id=169153

Reviewed by Zalan Bujtas.

Change all calls to imageResource().cachedImage() in RenderImage to use the inline
cachedImage() function.

In RenderImage::paintReplaced(), early return after the broken image block (and no need
to test imageResource().hasImage() again in the second condition). Convert height/width to size,
which also forces us to be explicit about using flooredIntSize() when fetching the image
(perhaps this should be a roundedIntSize, but I didn't want to change behavior).

Change RenderImageResource::image() to take an IntSize, rather than int height and width.

No behavior change.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::styleDidChange):
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::notifyFinished):
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
(WebCore::RenderImage::embeddedContentBox):

  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::image):

  • rendering/RenderImageResource.h:

(WebCore::RenderImageResource::image):

  • rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::image):

  • rendering/RenderImageResourceStyleImage.h:
3:28 AM Changeset in webkit [213805] by Carlos Garcia Campos
  • 8 edits in releases/WebKitGTK/webkit-2.16

Merge r213384 - [URLParser] Fix file: as a relative file URL
https://bugs.webkit.org/show_bug.cgi?id=169122

Reviewed by Tim Horton.

Source/WebCore:

This is clearly defined in https://url.spec.whatwg.org/#file-state with the EOF code point.
I got it wrong and didn't test it. It's been added to the web platform tests since we last updated.

  • platform/URLParser.cpp:

(WebCore::URLParser::parse):

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

LayoutTests:

We don't need to skip url-setters.html any more. It used to assert before the new URLParser was enabled.

  • fast/loader/url-parse-1-expected.txt:
  • fast/url/file-expected.txt:

We used to add a strange and unnecessary :/ at the end of the URL.

3:19 AM Changeset in webkit [213804] by Carlos Garcia Campos
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r213311 - We should prevent load of subframes inserted during FrameTree deconstruction
https://bugs.webkit.org/show_bug.cgi?id=169095

Reviewed by Brent Fulgham.

Source/WebCore:

When deconstructing the FrameTree, we fire the unload event in each subframe.
Such unload event handler may insert a new frame, we would previously load
such new frame which was unsafe as we would end up with an attached subframe
on a detached tree. To address the issue, we prevent new subframes from loading
while deconstructing the FrameTree and firing the unload events. This new
behavior is consistent with Chrome and should therefore be safe from a
compatibility standpoint.

Test: fast/frames/insert-frame-unload-handler.html

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::disconnectSubframes):
Update SubframeLoadingDisabler call site now that the constructor takes in
a pointer instead of a reference.

  • html/HTMLFrameOwnerElement.h:

(WebCore::SubframeLoadingDisabler::SubframeLoadingDisabler):
(WebCore::SubframeLoadingDisabler::~SubframeLoadingDisabler):
Update SubframeLoadingDisabler constructor to take in a pointer instead
of a reference, for convenience.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::detachChildren):
Prevent loads in subframes while detaching the subframes. It would be unsafe
as we copy the list of frames before iterating to fire the unload events.
Therefore, newly inserted frames would not get unloaded.

LayoutTests:

Add layout test coverage. Our behavior on this test is consistent with Chrome.

  • fast/frames/insert-frame-unload-handler-expected.txt: Added.
  • fast/frames/insert-frame-unload-handler.html: Added.
3:10 AM Changeset in webkit [213803] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/po

Merge r213288 - Unreviewed, restore inadvertently-removed non-breaking spaces in Polish translation

  • pl.po:
3:10 AM Changeset in webkit [213802] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/po

Merge r213279 - [l10n] Updated Polish translation of WebKitGTK+ for 2.16
https://bugs.webkit.org/show_bug.cgi?id=169072

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2017-03-02
Rubber-stamped by Michael Catanzaro.

  • pl.po:
3:09 AM Changeset in webkit [213801] by Carlos Garcia Campos
  • 16 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r213278 - [WK2] Keyboard menu key should show context menu
https://bugs.webkit.org/show_bug.cgi?id=72099

Source/WebCore:

Reviewed by Carlos Garcia Campos.

Show the context menu when the GtkWidget::popup-menu signal is
emitted. This signal is triggered by pressing a key (usually
the Menu key or the Shift + F10 shortcut) or it could be emitted on
WebKitWebView.

Test: fast/events/context-activated-by-key-event.html

Also could be tested by:

ManualTests/keyboard-menukey-event.html
ManualTests/win/contextmenu-key.html
ManualTests/win/contextmenu-key2.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):
Correctly send the mouse event that used for showing the context menu.
Previously the event was immediately dispatched as it is, but this was
only the right way if some element was focused on the page. If there
was no focused element or non-empty text range then the event lacked
the right node, where it was supposed to be shown. The correct node
is determined and added to the event in the sendContextMenuEvent() so
we have to use this function to send the event.

Also use absoluteBoundingBoxRect() instead of
pixelSnappedAbsoluteClippedOverflowRect() when determining
a coordinate where to show the context menu for the currently focus
element. The latter is not returning a right box (it is bigger) which
could lead to the situation that no menu will be displayed at all,
because the HitTest won't contain the right element as the
determined coordinates could be outside of the element.

  • page/EventHandler.h:

Source/WebKit2:

Reviewed by Carlos Garcia Campos.

Show the context menu when the GtkWidget::popup-menu signal is
emitted. This signal is triggered by pressing a key (usually
the Menu key or the Shift + F10 shortcut) or it could be emitted on
WebKitWebView.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):
(webkit_web_view_class_init): Update the documentation for the
context-menu signal

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBasePopupMenu): Connect to the popup-menu signal and
save the event that was used to trigger the signal. If there is no
such event create a new GdkEvent with GDK_NOTHING type.
(webkitWebViewBasePopupMenu):
(webkit_web_view_base_class_init):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleContextMenuKeyEvent):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::contextMenuForKeyEvent):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

Show the context menu when the GtkWidget::popup-menu signal is
emitted. This signal is triggered by pressing a key (usually
the Menu key or the Shift + F10 shortcut) or it could be emitted on
WebKitWebView.

Reviewed by Carlos Garcia Campos.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(testContextMenuDefaultMenu):

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(WebViewTest::emitPopupMenuSignal):

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:

LayoutTests:

Reviewed by Carlos Garcia Campos.

Skip the fast/events/context-activated-by-key-event.html on Mac as it
does not have a key to activate the context menu and on iOS as well.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
2:55 AM Changeset in webkit [213800] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213276 - [GTK] Crash in WebCore::CoordinatedGraphicsLayer::notifyFlushRequired
https://bugs.webkit.org/show_bug.cgi?id=166420

Reviewed by Žan Doberšek.

This is happening when closing a page that is being inspected. When CoordinatedGraphicsLayer::removeFromParent()
is called, the coordinator has already been invalidated, so all its layers were set a nullptr coordinator. I
think it's safe to simply handle m_coordinator being nullptr in notifyFlushRequired().

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::notifyFlushRequired): Return early if the coordinator is nullptr.

2:54 AM Changeset in webkit [213799] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore

Merge r213275 - Incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals()
https://bugs.webkit.org/show_bug.cgi?id=169034

Reviewed by Mark Lam.

It should not assign to offset, but compare to offset.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addStaticGlobals):

2:49 AM Changeset in webkit [213798] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.16

Merge r213224 - [GTK] fast/canvas/canvas-createPattern-video-loading.html makes its subsequent test timeout
https://bugs.webkit.org/show_bug.cgi?id=169019

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The timeout happens normally when the media player is deleted and the pipeline state is set to NULL. The call to
gst_element_set_state() never returns because of different deadlocks with the video sink. Sometimes the deadlock
happens with the sample mutex used by VideoRenderRequestScheduler. VideoRenderRequestScheduler::requestRender()
calls webkitVideoSinkRepaintRequested() with the lock held, that ends up calling
MediaPlayerPrivateGStreamerBase::triggerRepaint(). When rendering can't be accelerated the draw timer is
scheduled and triggerRepaint blocks until the timer is fired. If the media player is destroyed before the timer
is fired, when setting the pipeline state to NULL, other VideoRenderRequestScheduler methods can be called, like
stop() that tries to get the sample mutex that is still held by requestRender(). So, first we need to make
sure that requestRender() releases the lock before calling webkitVideoSinkRepaintRequested(). But that's not
enough, we also need to ensure that the pipeline is set to NULL state after everyting has been properly
stopped. This is currently done in ~MediaPlayerPrivateGStreamer that happens before
~MediaPlayerPrivateGStreamerBase, so gst_element_set_state() is hanging before allowing the
MediaPlayerPrivateGStreamerBase to be cleaned up. We should move the call to the end of
~MediaPlayerPrivateGStreamerBase and ensure the draw timer and mutex are properly cleaned up before.

Fixes: fast/canvas/canvas-createPattern-video-loading.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): Do not reset pipeline here.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase): Stop the draw mutex and notify the
lock to ensure we unblock. Do the pipeline reset at the end.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(VideoRenderRequestScheduler::requestRender): Release the mutex lock before calling webkitVideoSinkRepaintRequested().

LayoutTests:

Unskip tests previously skipped because of this timeout.

  • platform/gtk/TestExpectations:
2:48 AM Changeset in webkit [213797] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WTF

Merge r213223 - [WTF] va_list is not ended in StringPrintStream
https://bugs.webkit.org/show_bug.cgi?id=169035

Reviewed by Michael Saboff.

Also fix whitespace errors while touching this file.

  • wtf/StringPrintStream.cpp:

(WTF::StringPrintStream::vprintf):
(WTF::StringPrintStream::increaseSize):

2:46 AM Changeset in webkit [213796] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213219 - [Cairo] Incorrectly determining height in GraphicsContext::roundToDevicePixels()
https://bugs.webkit.org/show_bug.cgi?id=169031

Reviewed by Carlos Garcia Campos.

We should compare if height is between -1 and 0 and not mixing height
and width together.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::roundToDevicePixels):

2:46 AM Changeset in webkit [213795] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r213218 - [GTK] Fix problems found by Coverity scan in platform's keyboard and mouse events
https://bugs.webkit.org/show_bug.cgi?id=169028

Reviewed by Carlos Garcia Campos.

  • platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Initialize
the m_handledByInputMethod member.

  • platform/gtk/PlatformMouseEventGtk.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent): Initialize the
m_modifierFlags member.

2:43 AM Changeset in webkit [213794] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r213217 - [GTK] Fix problems found by Coverity scan in WebPrintOperationGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=169027

Reviewed by Carlos Garcia Campos.

Initialize the lastPagePosition variable and remove an unused one

  • totalToPrint.
  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData):

2:38 AM Changeset in webkit [213793] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore

Merge r213171 - Arm64 disassembler prints "ars" instead of "asr"
https://bugs.webkit.org/show_bug.cgi?id=168923

Rubber stamped by Michael Saboff.

  • disassembler/ARM64/A64DOpcode.cpp:

(JSC::ARM64Disassembler::A64DOpcodeBitfield::format):

2:37 AM Changeset in webkit [213792] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r213165 - Use of arguments in arrow function is slow
https://bugs.webkit.org/show_bug.cgi?id=168829

Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/arrowfunciton-direct-arguments.js: Added.

(fn):

  • microbenchmarks/arrowfunciton-reference-arguments.js: Added.

(fn):

Source/JavaScriptCore:

Current patch improves performance access to arguments within arrow functuion
by preventing create arguments variable within arrow function, also allow to cache
arguments variable. Before arguments variable always have Dynamic resolve type, after
patch it can be ClosureVar, that increase performance of access to arguments variable
in 9 times inside of the arrow function.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • runtime/JSScope.cpp:

(JSC::abstractAccess):

2:33 AM Changeset in webkit [213791] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.16

Merge r213631 - [GTK] JSC test stress/arity-check-ftl-throw.js.ftl-no-cjit-validate-sampling-profiler crashing on GTK bot
https://bugs.webkit.org/show_bug.cgi?id=160124

Reviewed by Mark Lam.

JSTests:

  • stress/spread-forward-call-varargs-stack-overflow.js:

Source/JavaScriptCore:

When performing CallVarargs, we will copy values to the stack.
Before actually copying values, we need to adjust the stackPointerRegister
to ensure copied values are in the allocated stack area.
If we do not that, OS can break the values that is stored beyond the stack
pointer. For example, signal stack can be constructed on these area, and
breaks values.

This patch fixes the crash in stress/spread-forward-call-varargs-stack-overflow.js
in Linux port. Since Linux ports use signal to suspend and resume threads,
signal handler is frequently called when enabling sampling profiler. Thus this
crash occurs.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):

  • jit/SetupVarargsFrame.cpp:

(JSC::emitSetupVarargsFrameFastCase):

  • jit/SetupVarargsFrame.h:
2:21 AM Changeset in webkit [213790] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Web Automation: automation commands hang when trying to navigate go/back and it's not possible
https://bugs.webkit.org/show_bug.cgi?id=169407

Reviewed by Michael Catanzaro.

Trying to navigate back or forward when there are no back/forward items makes the automation commands to hang, because
navigation callback is never called. WebPageProxy returns nullptr to indicate no navigation will take place. In
that case we can consider that the operation succeeded.

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::goBackInBrowsingContext):
(WebKit::WebAutomationSession::goForwardInBrowsingContext):

2:15 AM Changeset in webkit [213789] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

MiniBrowser: a tab closed from javascript always closes the window
https://bugs.webkit.org/show_bug.cgi?id=169415

Reviewed by Michael Catanzaro.

When I implemented tabs support in MiniBrowser I forgot about web view close. We connect to the signal (only for
the active tab) and close the window. That worked when we didn't have tabs, but now we should close the tab, or
the window if it's the last tab.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewClose): Destroy the window if therte's only one tab, otherwise search for the tab corresponding to the web
view and destroy it.
(browserWindowSwitchTab): Re-connect to close signal, we want to handle close on all tabs.

2:10 AM Changeset in webkit [213788] by dewei_zhu@apple.com
  • 12 edits in trunk/Websites/perf.webkit.org

Add the ability to report a commit with sub-commits.
https://bugs.webkit.org/show_bug.cgi?id=168962

Reviewed by Ryosuke Niwa.

Introduce 'commit_ownerships' which records ownership between commits.
On existing production server, run `

CREATE TABLE commit_ownerships (

commit_owner integer NOT NULL REFERENCES commits ON DELETE CASCADE,
commit_ownee integer NOT NULL REFERENCES commits ON DELETE CASCADE,
PRIMARY KEY (commit_owner, commit_ownee)

);
ALTER TABLE repositories RENAME repository_parent TO repository_owner;
ALTER TABLE repositories DROP repository_name_must_be_unique;
CREATE UNIQUE INDEX repository_name_owner_unique_index ON repositories (repository_owner, repository_name) WHERE repository_owner IS NOT NULL;
CREATE UNIQUE INDEX repository_name_unique_index ON repositories (repository_name) WHERE repository_owner IS NULL;

` to update database.
Add unit-tests to cover this change.

  • init-database.sql:
  • public/api/report-commits.php:
  • public/include/commit-log-fetcher.php:
  • public/include/db.php:
  • public/include/manifest-generator.php:
  • public/include/report-processor.php:
  • public/v3/models/repository.js:

(Repository):
(Repository.prototype.owner):

  • server-tests/admin-reprocess-report-tests.js:

(addBuilderForReport.simpleReportWithRevisions.0.then):
(then):

  • server-tests/api-manifest.js:

(then):

  • server-tests/api-report-commits-tests.js:

(addSlaveForReport.sameRepositoryNameInSubCommitAndMajorCommit.then):
(then):
(addSlaveForReport.systemVersionCommitWithSubcommits.then):
(addSlaveForReport.multipleSystemVersionCommitsWithSubcommits.then):
(addSlaveForReport.systemVersionCommitWithEmptySubcommits.then):
(addSlaveForReport.systemVersionCommitAndSubcommitWithTimestamp.then):

  • tools/js/database.js:
1:01 AM Changeset in webkit [213787] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

[WK2][CMake] Remove the intermediate NetworkProcess_COMMON_SOURCES variable
https://bugs.webkit.org/show_bug.cgi?id=169524

Reviewed by Michael Catanzaro.

The NetworkProcess-specific source files listed in the
NetworkProcess_COMMON_SOURCES variable definition should be directly
inlined into the list with which the WebKit2_SOURCE variable is defined.
The NetworkProcess_COMMON_SOURCES variable is appended to the
WebKit2_SOURCES variable anyway, and is not used anywhere else. The
separate variable was previously use to support configurations that
allowed disabling NetworkProcess.

  • CMakeLists.txt:
12:54 AM Changeset in webkit [213786] by dino@apple.com
  • 10 edits in trunk/Source

WebGPU remote layer hosting
https://bugs.webkit.org/show_bug.cgi?id=169539
<rdar://problem/31005380>

Reviewed by Jon Lee.

Source/WebCore:

Implement the WebProcess side of WebGPULayer hosting,
via LayerTypeWebGPULayer.

  • platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::operator<<): Provide nice pretty printing.

  • platform/graphics/ca/PlatformCALayer.h: Add LayerTypeWebGPULayer.
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: Support LayerTypeWebGPULayer.

(PlatformCALayerCocoa::layerTypeForPlatformLayer):
(PlatformCALayerCocoa::PlatformCALayerCocoa):
(PlatformCALayerCocoa::commonInit):

Source/WebKit2:

Implement the host-side part of WebGPULayer.

  • Shared/mac/RemoteLayerBackingStore.mm: Add support for LayerTypeWebGPULayer.

(WebKit::RemoteLayerBackingStore::drawInContext):

  • Shared/mac/RemoteLayerTreeTransaction.mm: Ditto.

(WebKit::RemoteLayerTreeTransaction::description):

  • UIProcess/ios/RemoteLayerTreeHostIOS.mm: Ditto.

(WebKit::RemoteLayerTreeHost::createLayer):

  • UIProcess/mac/RemoteLayerTreeHost.mm: Ditto.

(WebKit::RemoteLayerTreeHost::createLayer):

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm: Ditto.

(WebKit::PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(WebKit::PlatformCALayerRemoteCustom::clone):

12:33 AM Changeset in webkit [213785] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK+ build fix. Adjust the Cookie constructor
invocation in CookieJarSoup, using empty values for the
newly-added parameters. This should probably be revised
to determine whether meaningful values can be passed in.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::getRawCookies):

12:30 AM Changeset in webkit [213784] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebKit2

Unreviewed GTK+ build fix. Use WTF::Function<> for the
WebPageProxy::getContentsAsMHTMLData() parameter, fixing
configurations that support enabling ENABLE(MHTML).

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getContentsAsMHTMLData):

  • UIProcess/WebPageProxy.h:
12:18 AM Changeset in webkit [213783] by jonlee@apple.com
  • 6 edits in trunk/Source/WebCore

WebGPU: Backend - hosting WebGPU layers
https://bugs.webkit.org/show_bug.cgi?id=169366
<rdar://problem/30928735>

Reviewed by Dean Jackson.

  • html/canvas/WebGPURenderingContext.cpp:

(WebCore::WebGPURenderingContext::create): Create the device and the
rendering context.

  • platform/graphics/cocoa/GPUCommandBufferMetal.mm:

(WebCore::GPUCommandBuffer::commit):

  • platform/graphics/cocoa/GPUDrawableMetal.mm:

(WebCore::GPUDrawable::release): Fix a log message

  • platform/graphics/gpu/GPUCommandBuffer.cpp:

(WebCore::GPUCommandBuffer::commit): Deleted. Moved to GPUCommandBufferMetal.

  • rendering/RenderLayerBacking.cpp:

(WebCore::canvasCompositingStrategy): WebGPU canvas should return CanvasAsLayerContents.

Mar 12, 2017:

11:17 PM Changeset in webkit [213782] by jonlee@apple.com
  • 29 edits in trunk/Source/WebCore

Remove stubs from WebGPU front end
https://bugs.webkit.org/show_bug.cgi?id=169375

Reviewed by Dean Jackson.

Remove stubs and use the back end.

  • html/canvas/WebGPUCommandBuffer.cpp:
  • html/canvas/WebGPUCommandBuffer.h:
  • html/canvas/WebGPUCommandQueue.cpp:
  • html/canvas/WebGPUCommandQueue.h:
  • html/canvas/WebGPUDepthStencilDescriptor.cpp:

(WebCore::WebGPUDepthStencilDescriptor::setDepthCompareFunction): Remove redundant clause.

  • html/canvas/WebGPUDepthStencilDescriptor.h:
  • html/canvas/WebGPUDepthStencilDescriptor.idl: Remove label property. Not needed yet.
  • html/canvas/WebGPUDepthStencilState.cpp:
  • html/canvas/WebGPUDepthStencilState.h:
  • html/canvas/WebGPUEnums.cpp:
  • html/canvas/WebGPUEnums.h:
  • html/canvas/WebGPURenderCommandEncoder.cpp:
  • html/canvas/WebGPURenderCommandEncoder.h:
  • html/canvas/WebGPURenderPassAttachmentDescriptor.cpp:
  • html/canvas/WebGPURenderPassAttachmentDescriptor.h:
  • html/canvas/WebGPURenderPassColorAttachmentDescriptor.cpp:
  • html/canvas/WebGPURenderPassColorAttachmentDescriptor.h:
  • html/canvas/WebGPURenderPassDepthAttachmentDescriptor.cpp:
  • html/canvas/WebGPURenderPassDepthAttachmentDescriptor.h:
  • html/canvas/WebGPURenderPassDescriptor.cpp:

(WebCore::WebGPURenderPassDescriptor::colorAttachments): Uncomment code with GPURenderPassColorAttachmentDescriptor available.

  • html/canvas/WebGPURenderPassDescriptor.h:
  • html/canvas/WebGPURenderPipelineColorAttachmentDescriptor.cpp:
  • html/canvas/WebGPURenderPipelineColorAttachmentDescriptor.h:
  • html/canvas/WebGPURenderPipelineDescriptor.cpp:
  • html/canvas/WebGPURenderPipelineDescriptor.h:
  • html/canvas/WebGPURenderPipelineDescriptor.idl: Remove label property. Not needed yet.
  • html/canvas/WebGPURenderPipelineState.cpp:
  • html/canvas/WebGPURenderPipelineState.h:
10:38 PM Changeset in webkit [213781] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] Incorrect availability annotations in WKUserContentController.h
https://bugs.webkit.org/show_bug.cgi?id=169536

Reviewed by Alexey Proskuryakov.

  • UIProcess/API/Cocoa/WKUserContentController.h: Use WK_MAC_TBA for macOS availability.
8:40 PM Changeset in webkit [213780] by jonlee@apple.com
  • 20 edits
    35 copies
    5 adds in trunk/Source/WebCore

WebGPU Backend
https://bugs.webkit.org/show_bug.cgi?id=169535
<rdar://problem/31002364>

Patch by Dean Jackson <dino@apple.com> on 2017-03-12
Reviewed by Jon Lee.

Fill in the remainder of the WebGPU backend. This is effectively
a C++ representation of the Metal API.

  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/WebGPUDrawable.cpp:

(WebCore::WebGPUDrawable::WebGPUDrawable):

  • html/canvas/WebGPUDrawable.h:

(WebCore::GPUDrawable::texture): Deleted.

  • platform/graphics/cocoa/GPUBufferMetal.mm:

(WebCore::GPUBuffer::GPUBuffer):
(WebCore::GPUBuffer::platformBuffer):

  • platform/graphics/cocoa/GPUCommandBufferMetal.mm: Copied from Source/WebCore/platform/graphics/cocoa/GPUFunctionMetal.mm.

(WebCore::GPUCommandBuffer::GPUCommandBuffer):
(WebCore::GPUCommandBuffer::platformCommandBuffer):
(WebCore::GPUCommandBuffer::presentDrawable):

  • platform/graphics/cocoa/GPUCommandQueueMetal.mm: Copied from Source/WebCore/platform/graphics/cocoa/GPUFunctionMetal.mm.

(WebCore::GPUCommandQueue::GPUCommandQueue):
(WebCore::GPUCommandQueue::label):
(WebCore::GPUCommandQueue::setLabel):
(WebCore::GPUCommandQueue::platformCommandQueue):

  • platform/graphics/cocoa/GPUDepthStencilDescriptorMetal.mm: Copied from Source/WebCore/platform/graphics/cocoa/GPUTextureMetal.mm.

(WebCore::GPUDepthStencilDescriptor::GPUDepthStencilDescriptor):
(WebCore::GPUDepthStencilDescriptor::depthWriteEnabled):
(WebCore::GPUDepthStencilDescriptor::setDepthWriteEnabled):
(WebCore::GPUDepthStencilDescriptor::depthCompareFunction):
(WebCore::GPUDepthStencilDescriptor::setDepthCompareFunction):
(WebCore::GPUDepthStencilDescriptor::platformDepthStencilDescriptor):

  • platform/graphics/cocoa/GPUDepthStencilStateMetal.mm: Copied from Source/WebCore/platform/graphics/cocoa/GPUFunctionMetal.mm.

(WebCore::GPUDepthStencilState::GPUDepthStencilState):
(WebCore::GPUDepthStencilState::label):
(WebCore::GPUDepthStencilState::setLabel):
(WebCore::GPUDepthStencilState::platformDepthStencilState):

  • platform/graphics/cocoa/GPUDrawableMetal.mm: Copied from Source/WebCore/platform/graphics/cocoa/GPUFunctionMetal.mm.

(WebCore::GPUDrawable::GPUDrawable):
(WebCore::GPUDrawable::release):
(WebCore::GPUDrawable::platformDrawable):
(WebCore::GPUDrawable::platformTexture):

  • platform/graphics/cocoa/GPUFunctionMetal.mm:

(WebCore::GPUFunction::GPUFunction):
(WebCore::GPUFunction::platformFunction):

  • platform/graphics/cocoa/GPULibraryMetal.mm:

(WebCore::GPULibrary::GPULibrary):
(WebCore::GPULibrary::setLabel):
(WebCore::GPULibrary::platformLibrary):

  • platform/graphics/cocoa/GPURenderCommandEncoderMetal.mm: Added.

(WebCore::GPURenderCommandEncoder::GPURenderCommandEncoder):
(WebCore::GPURenderCommandEncoder::setRenderPipelineState):
(WebCore::GPURenderCommandEncoder::setDepthStencilState):
(WebCore::GPURenderCommandEncoder::setVertexBuffer):
(WebCore::GPURenderCommandEncoder::setFragmentBuffer):
(WebCore::GPURenderCommandEncoder::drawPrimitives):
(WebCore::GPURenderCommandEncoder::endEncoding):
(WebCore::GPURenderCommandEncoder::platformRenderCommandEncoder):

  • platform/graphics/cocoa/GPURenderPassAttachmentDescriptorMetal.mm: Added.

(WebCore::GPURenderPassAttachmentDescriptor::GPURenderPassAttachmentDescriptor):
(WebCore::GPURenderPassAttachmentDescriptor::loadAction):
(WebCore::GPURenderPassAttachmentDescriptor::setLoadAction):
(WebCore::GPURenderPassAttachmentDescriptor::storeAction):
(WebCore::GPURenderPassAttachmentDescriptor::setStoreAction):
(WebCore::GPURenderPassAttachmentDescriptor::setTexture):
(WebCore::GPURenderPassAttachmentDescriptor::platformRenderPassAttachmentDescriptor):

  • platform/graphics/cocoa/GPURenderPassColorAttachmentDescriptorMetal.mm: Added.

(WebCore::GPURenderPassColorAttachmentDescriptor::create):
(WebCore::GPURenderPassColorAttachmentDescriptor::GPURenderPassColorAttachmentDescriptor):
(WebCore::GPURenderPassColorAttachmentDescriptor::clearColor):
(WebCore::GPURenderPassColorAttachmentDescriptor::setClearColor):
(WebCore::GPURenderPassColorAttachmentDescriptor::platformRenderPassColorAttachmentDescriptor):

  • platform/graphics/cocoa/GPURenderPassDepthAttachmentDescriptorMetal.mm: Added.

(WebCore::GPURenderPassDepthAttachmentDescriptor::create):
(WebCore::GPURenderPassDepthAttachmentDescriptor::GPURenderPassDepthAttachmentDescriptor):
(WebCore::GPURenderPassDepthAttachmentDescriptor::clearDepth):
(WebCore::GPURenderPassDepthAttachmentDescriptor::setClearDepth):
(WebCore::GPURenderPassDepthAttachmentDescriptor::platformRenderPassDepthAttachmentDescriptor):

  • platform/graphics/cocoa/GPURenderPassDescriptorMetal.mm: Copied from Source/WebCore/platform/graphics/cocoa/GPUBufferMetal.mm.

(WebCore::GPURenderPassDescriptor::GPURenderPassDescriptor):
(WebCore::GPURenderPassDescriptor::colorAttachments):
(WebCore::GPURenderPassDescriptor::depthAttachment):
(WebCore::GPURenderPassDescriptor::platformRenderPassDescriptor):

  • platform/graphics/cocoa/GPURenderPipelineColorAttachmentDescriptorMetal.mm: Copied from Source/WebCore/platform/graphics/cocoa/GPULibraryMetal.mm.

(WebCore::GPURenderPipelineColorAttachmentDescriptor::create):
(WebCore::GPURenderPipelineColorAttachmentDescriptor::GPURenderPipelineColorAttachmentDescriptor):
(WebCore::GPURenderPipelineColorAttachmentDescriptor::pixelFormat):
(WebCore::GPURenderPipelineColorAttachmentDescriptor::setPixelFormat):
(WebCore::GPURenderPipelineColorAttachmentDescriptor::platformRenderPipelineColorAttachmentDescriptor):

  • platform/graphics/cocoa/GPURenderPipelineDescriptorMetal.mm: Added.

(WebCore::GPURenderPipelineDescriptor::GPURenderPipelineDescriptor):
(WebCore::GPURenderPipelineDescriptor::depthAttachmentPixelFormat):
(WebCore::GPURenderPipelineDescriptor::setDepthAttachmentPixelFormat):
(WebCore::GPURenderPipelineDescriptor::setVertexFunction):
(WebCore::GPURenderPipelineDescriptor::setFragmentFunction):
(WebCore::GPURenderPipelineDescriptor::colorAttachments):
(WebCore::GPURenderPipelineDescriptor::reset):
(WebCore::GPURenderPipelineDescriptor::platformRenderPipelineDescriptor):

  • platform/graphics/cocoa/GPURenderPipelineStateMetal.mm: Copied from Source/WebCore/platform/graphics/cocoa/GPUTextureMetal.mm.

(WebCore::GPURenderPipelineState::GPURenderPipelineState):
(WebCore::GPURenderPipelineState::label):
(WebCore::GPURenderPipelineState::setLabel):
(WebCore::GPURenderPipelineState::platformRenderPipelineState):

  • platform/graphics/cocoa/GPUTextureDescriptorMetal.mm:

(WebCore::GPUTextureDescriptor::GPUTextureDescriptor):
(WebCore::GPUTextureDescriptor::platformTextureDescriptor):

  • platform/graphics/cocoa/GPUTextureMetal.mm:

(WebCore::GPUTexture::GPUTexture):
(WebCore::GPUTexture::platformTexture):

  • platform/graphics/gpu/GPUBuffer.cpp:
  • platform/graphics/gpu/GPUBuffer.h:
  • platform/graphics/gpu/GPUCommandBuffer.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUBuffer.cpp.

(WebCore::GPUCommandBuffer::create):
(WebCore::GPUCommandBuffer::~GPUCommandBuffer):
(WebCore::GPUCommandBuffer::commit):
(WebCore::GPUCommandBuffer::createRenderCommandEncoder):
(WebCore::GPUCommandBuffer::presentDrawable):

  • platform/graphics/gpu/GPUCommandBuffer.h: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.h.
  • platform/graphics/gpu/GPUCommandQueue.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUBuffer.cpp.

(WebCore::GPUCommandQueue::create):
(WebCore::GPUCommandQueue::~GPUCommandQueue):
(WebCore::GPUCommandQueue::createCommandBuffer):
(WebCore::GPUCommandQueue::label):
(WebCore::GPUCommandQueue::setLabel):

  • platform/graphics/gpu/GPUCommandQueue.h: Copied from Source/WebCore/platform/graphics/gpu/GPULibrary.h.
  • platform/graphics/gpu/GPUDepthStencilDescriptor.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.cpp.

(WebCore::GPUDepthStencilDescriptor::create):
(WebCore::GPUDepthStencilDescriptor::~GPUDepthStencilDescriptor):
(WebCore::GPUDepthStencilDescriptor::depthWriteEnabled):
(WebCore::GPUDepthStencilDescriptor::setDepthWriteEnabled):
(WebCore::GPUDepthStencilDescriptor::depthCompareFunction):
(WebCore::GPUDepthStencilDescriptor::setDepthCompareFunction):

  • platform/graphics/gpu/GPUDepthStencilDescriptor.h: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.h.
  • platform/graphics/gpu/GPUDepthStencilState.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUBuffer.cpp.

(WebCore::GPUDepthStencilState::create):
(WebCore::GPUDepthStencilState::~GPUDepthStencilState):
(WebCore::GPUDepthStencilState::label):
(WebCore::GPUDepthStencilState::setLabel):

  • platform/graphics/gpu/GPUDepthStencilState.h: Copied from Source/WebCore/platform/graphics/gpu/GPULibrary.h.
  • platform/graphics/gpu/GPUDevice.cpp:

(WebCore::GPUDevice::createCommandQueue):
(WebCore::GPUDevice::getFramebuffer):

  • platform/graphics/gpu/GPUDevice.h:

(WebCore::GPUDevice::markLayerComposited):
(WebCore::GPUDevice::createCommandQueue): Deleted.
(WebCore::GPUDevice::getFramebuffer): Deleted.

  • platform/graphics/gpu/GPUDrawable.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUBuffer.cpp.

(WebCore::GPUDrawable::create):
(WebCore::GPUDrawable::~GPUDrawable):
(WebCore::GPUDrawable::release):

  • platform/graphics/gpu/GPUDrawable.h: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.h.
  • platform/graphics/gpu/GPUEnums.h: Copied from Source/WebCore/platform/graphics/cocoa/GPUFunctionMetal.mm.
  • platform/graphics/gpu/GPUFunction.h:
  • platform/graphics/gpu/GPULibrary.cpp:
  • platform/graphics/gpu/GPULibrary.h:
  • platform/graphics/gpu/GPURenderCommandEncoder.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPULibrary.cpp.

(WebCore::GPURenderCommandEncoder::create):
(WebCore::GPURenderCommandEncoder::~GPURenderCommandEncoder):
(WebCore::GPURenderCommandEncoder::setRenderPipelineState):
(WebCore::GPURenderCommandEncoder::setDepthStencilState):
(WebCore::GPURenderCommandEncoder::setVertexBuffer):
(WebCore::GPURenderCommandEncoder::setFragmentBuffer):
(WebCore::GPURenderCommandEncoder::drawPrimitives):
(WebCore::GPURenderCommandEncoder::endEncoding):

  • platform/graphics/gpu/GPURenderCommandEncoder.h: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.h.
  • platform/graphics/gpu/GPURenderPassAttachmentDescriptor.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.cpp.

(WebCore::GPURenderPassAttachmentDescriptor::~GPURenderPassAttachmentDescriptor):
(WebCore::GPURenderPassAttachmentDescriptor::GPURenderPassAttachmentDescriptor):
(WebCore::GPURenderPassAttachmentDescriptor::loadAction):
(WebCore::GPURenderPassAttachmentDescriptor::setLoadAction):
(WebCore::GPURenderPassAttachmentDescriptor::storeAction):
(WebCore::GPURenderPassAttachmentDescriptor::setStoreAction):
(WebCore::GPURenderPassAttachmentDescriptor::setTexture):

  • platform/graphics/gpu/GPURenderPassAttachmentDescriptor.h: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.h.
  • platform/graphics/gpu/GPURenderPassColorAttachmentDescriptor.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUDevice.cpp.

(WebCore::GPURenderPassColorAttachmentDescriptor::create):
(WebCore::GPURenderPassColorAttachmentDescriptor::GPURenderPassColorAttachmentDescriptor):
(WebCore::GPURenderPassColorAttachmentDescriptor::~GPURenderPassColorAttachmentDescriptor):
(WebCore::GPURenderPassColorAttachmentDescriptor::clearColor):
(WebCore::GPURenderPassColorAttachmentDescriptor::setClearColor):

  • platform/graphics/gpu/GPURenderPassColorAttachmentDescriptor.h: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.h.
  • platform/graphics/gpu/GPURenderPassDepthAttachmentDescriptor.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.cpp.

(WebCore::GPURenderPassDepthAttachmentDescriptor::create):
(WebCore::GPURenderPassDepthAttachmentDescriptor::GPURenderPassDepthAttachmentDescriptor):
(WebCore::GPURenderPassDepthAttachmentDescriptor::~GPURenderPassDepthAttachmentDescriptor):
(WebCore::GPURenderPassDepthAttachmentDescriptor::clearDepth):
(WebCore::GPURenderPassDepthAttachmentDescriptor::setClearDepth):

  • platform/graphics/gpu/GPURenderPassDepthAttachmentDescriptor.h: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.h.
  • platform/graphics/gpu/GPURenderPassDescriptor.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUBuffer.cpp.

(WebCore::GPURenderPassDescriptor::create):
(WebCore::GPURenderPassDescriptor::~GPURenderPassDescriptor):
(WebCore::GPURenderPassDescriptor::depthAttachment):

  • platform/graphics/gpu/GPURenderPassDescriptor.h: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.h.
  • platform/graphics/gpu/GPURenderPipelineColorAttachmentDescriptor.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.cpp.

(WebCore::GPURenderPipelineColorAttachmentDescriptor::~GPURenderPipelineColorAttachmentDescriptor):
(WebCore::GPURenderPipelineColorAttachmentDescriptor::GPURenderPipelineColorAttachmentDescriptor):
(WebCore::GPURenderPipelineColorAttachmentDescriptor::pixelFormat):
(WebCore::GPURenderPipelineColorAttachmentDescriptor::setPixelFormat):

  • platform/graphics/gpu/GPURenderPipelineColorAttachmentDescriptor.h: Copied from Source/WebCore/platform/graphics/gpu/GPUTexture.h.
  • platform/graphics/gpu/GPURenderPipelineDescriptor.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPUDevice.cpp.

(WebCore::GPURenderPipelineDescriptor::create):
(WebCore::GPURenderPipelineDescriptor::~GPURenderPipelineDescriptor):
(WebCore::GPURenderPipelineDescriptor::depthAttachmentPixelFormat):
(WebCore::GPURenderPipelineDescriptor::setDepthAttachmentPixelFormat):
(WebCore::GPURenderPipelineDescriptor::setVertexFunction):
(WebCore::GPURenderPipelineDescriptor::setFragmentFunction):
(WebCore::GPURenderPipelineDescriptor::colorAttachments):

  • platform/graphics/gpu/GPURenderPipelineDescriptor.h: Copied from Source/WebCore/platform/graphics/gpu/GPULibrary.h.
  • platform/graphics/gpu/GPURenderPipelineState.cpp: Copied from Source/WebCore/platform/graphics/gpu/GPULibrary.cpp.

(WebCore::GPURenderPipelineState::create):
(WebCore::GPURenderPipelineState::~GPURenderPipelineState):
(WebCore::GPURenderPipelineState::label):
(WebCore::GPURenderPipelineState::setLabel):

  • platform/graphics/gpu/GPURenderPipelineState.h: Copied from Source/WebCore/platform/graphics/gpu/GPULibrary.h.
  • platform/graphics/gpu/GPUTexture.cpp:

(WebCore::GPUTexture::createFromDrawable):
(WebCore::GPUTexture::createFromExistingTexture): Deleted.

  • platform/graphics/gpu/GPUTexture.h:
  • platform/graphics/gpu/GPUTextureDescriptor.cpp:
  • platform/graphics/gpu/GPUTextureDescriptor.h:
8:16 PM Changeset in webkit [213779] by zalan@apple.com
  • 5 edits
    2 adds in trunk

Simple line layout: Paginated content is not painted properly when font overflows line height.
https://bugs.webkit.org/show_bug.cgi?id=169516

Reviewed by Antti Koivisto.

Source/WebCore:

adjustLineIndexForStruts should take the IndexType::First/Last into account
when searching for the line index in a paginated context.
This also changes the the computed offset height from m_lineHeight to m_ascent + m_descent
so that we can find lines with large fonts (but small line height).

Test: fast/multicol/simple-line-layout-line-index-after-strut.html

  • rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::adjustLineIndexForStruts):
(WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight):
(WebCore::SimpleLineLayout::RunResolver::rangeForRect):

  • rendering/SimpleLineLayoutResolver.h:

LayoutTests:

  • fast/multicol/simple-line-layout-line-index-after-strut-expected.html: Added.
  • fast/multicol/simple-line-layout-line-index-after-strut.html: Added.
6:54 PM Changeset in webkit [213778] by beidson@apple.com
  • 4 edits in trunk/Source/WebCore

Add full NSHTTPCookie fidelity to WebCore::Cookie.
https://bugs.webkit.org/show_bug.cgi?id=169514

Reviewed by Dean Jackson.

No new tests (Refactor, no testable behavior change for now).

  • platform/Cookie.h:

(WebCore::Cookie::Cookie):
(WebCore::Cookie::encode):
(WebCore::Cookie::decode):

  • platform/network/cocoa/CookieCocoa.mm:

(WebCore::portVectorFromList):
(WebCore::portStringFromVector):
(WebCore::Cookie::Cookie):
(WebCore::Cookie::operator NSHTTPCookie *):

  • platform/network/mac/CookieJarMac.mm:

(WebCore::getRawCookies):

6:37 PM Changeset in webkit [213777] by beidson@apple.com
  • 10 edits in trunk/Source/WebKit2

Transition GenericCallback from std::function to WTF::Function.
https://bugs.webkit.org/show_bug.cgi?id=169530

Reviewed by Dean Jackson.

  • UIProcess/GenericCallback.h:

(WebKit::GenericCallback::create):
(WebKit::GenericCallback::performCallbackWithReturnValue):
(WebKit::GenericCallback::GenericCallback):
(WebKit::CallbackMap::put):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):

  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::getWebArchive):
(WebKit::WebFrameProxy::getMainResourceData):
(WebKit::WebFrameProxy::getResourceData):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getSelectionAsWebArchiveData):
(WebKit::WebPageProxy::getMainResourceDataOfFrame):
(WebKit::WebPageProxy::getResourceDataFromFrame):
(WebKit::WebPageProxy::getWebArchiveOfFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::getStatistics):

  • UIProcess/WebProcessPool.h:
5:34 PM Changeset in webkit [213776] by mcatanzaro@igalia.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Unbreak build with GTK+ >=3.20 after r213772
https://bugs.webkit.org/show_bug.cgi?id=169533

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-03-12
Reviewed by Michael Catanzaro.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewRunFileChooser): Add missing cast.

5:16 PM Changeset in webkit [213775] by jfernandez@igalia.com
  • 5 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=169534

Unreviewed GTK+ gardening.

Rebaseline tests:
LayoutTests/imported/w3c:

  • imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive.html
  • web-platform-tests/XMLHttpRequest/getresponseheader-case-insensitive-expected.txt:

LayoutTests:

  • http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers.html
  • platform/gtk/TestExpectations:
    • fast/text/font-selection-font-face-parse.html [ Skip ]
  • platform/gtk/http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers-expected.txt:
4:52 PM Changeset in webkit [213774] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION (r213764): Async image decoding is disabled for animated images
https://bugs.webkit.org/show_bug.cgi?id=169529

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-03-12
Reviewed by Jon Lee.

The change r213764 causes the animated images to be decoded synchronously
because we were calling frameImageAtIndex() with an empty sizeForDrawing
but with a valid subsamplingLevel. This call is translated to be synchronous
image decoding. The fix is get the current image frame without any decoding.
This is because are sure that in the case of animated image, the current
image frame can not be deleted.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::draw):

3:56 PM Changeset in webkit [213773] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Structure::willStoreValueSlow needs to keep the property table alive until the end
https://bugs.webkit.org/show_bug.cgi?id=169520

Reviewed by Michael Saboff.

We use pointers logically interior to propertyTable after doing a GC. We need to prevent the
compiler from optimizing away pointers to propertyTable.

  • heap/HeapCell.cpp:

(JSC::HeapCell::use):

  • heap/HeapCell.h:

(JSC::HeapCell::use): Introduce API for keeping a pointer alive until some point in execution.

  • runtime/Structure.cpp:

(JSC::Structure::willStoreValueSlow): Use HeapCell::use() to keep the pointer alive.

1:19 PM Changeset in webkit [213772] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] File choosers should run as modal by default if possible
https://bugs.webkit.org/show_bug.cgi?id=169526

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-03-12
Reviewed by Michael Catanzaro.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewRunFileChooser): If a top-level window containing the web view is found, call
gtk_native_dialog_set_modal() to configure the dialog accordingly.

11:47 AM Changeset in webkit [213771] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[iOS] Some more -respondsToSelector: checks are unnecessary
https://bugs.webkit.org/show_bug.cgi?id=169525

Reviewed by Tim Horton.

  • Platform/spi/ios/UIKitSPI.h: Moved redeclarations of methods that are declared in the Apple internal SDK into the #if !USE(APPLE_INTERNAL_SDK) section.
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]): Replaced unnecessary -respondsToSelector:

check with compile-time check for the deployment target.

(-[WKWebView _computedContentInset]): Ditto.
(activeMinimumLayoutSize): Ditto.
(-[WKWebView safeAreaInsetsDidChange]): Ditto.

10:27 AM Changeset in webkit [213770] by commit-queue@webkit.org
  • 9 edits in trunk

[Readable Streams API] Implement ReadableStreamBYOBRequest respond() (closed stream state)
https://bugs.webkit.org/show_bug.cgi?id=168781

Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2017-03-12
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Updated WPT expectations for readable byte streams tests.

  • web-platform-tests/streams/readable-byte-streams/general-expected.txt:
  • web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt:

Source/WebCore:

Implemented ReadableStreamBYOBRequest respond() method in the case of a closed stream.

Added tests related to respond() method and updated WPT imported tests expectations.

  • Modules/streams/ReadableByteStreamInternals.js:

(readableByteStreamControllerRespond): Added.
(readableByteStreamControllerRespondInternal): Added.
(readableByteStreamControllerRespondInClosedState): Added.
(readableByteStreamControllerShiftPendingPullInto): Added.
(readableByteStreamControllerInvalidateBYOBRequest): Added.
(readableByteStreamControllerCommitPullIntoDescriptor): Added.
(readableByteStreamControllerConvertPullIntoDescriptor): Added.
(readableStreamFulfillReadIntoRequest): Added.

  • Modules/streams/ReadableStreamBYOBRequest.js:

(respond): Implemented.

LayoutTests:

Added new tests related to ReadableStreamBYOBRequeset respond() method.

  • streams/readable-stream-byob-request-expected.txt:
  • streams/readable-stream-byob-request.js:

Mar 11, 2017:

11:54 PM Changeset in webkit [213769] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, suprress warnings in JSC B3

  • b3/B3Opcode.cpp:
10:27 PM Changeset in webkit [213768] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Allow regular expressions to be used when selecting a process name in JSC config file
https://bugs.webkit.org/show_bug.cgi?id=169495

Reviewed by Saam Barati.

Only added regular expression selectors for unix like platforms.

  • runtime/ConfigFile.cpp:

(JSC::ConfigFileScanner::tryConsumeRegExPattern):
(JSC::ConfigFile::parse):

10:21 PM Changeset in webkit [213767] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

Fix memory estimate for layers supporting subpixel-antialised text
https://bugs.webkit.org/show_bug.cgi?id=169507
rdar://problem/30979337

Reviewed by Alexey Proskuryakov.

Deep color layers on iOS use 5 bytes per pixel, layers supporting subpixel-antialiaed
text on Mac use 8 bytes per pixel.

  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::backingStoreBytesPerPixel):

10:07 PM Changeset in webkit [213766] by commit-queue@webkit.org
  • 10 edits in trunk

XMLHttpRequest: make setRequestHeader() use , as separator (including a space)
https://bugs.webkit.org/show_bug.cgi?id=169285

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-11
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/XMLHttpRequest/setrequestheader-case-insensitive.htm:
  • web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed.htm:
  • web-platform-tests/fetch/api/headers/headers-combine.html:

Source/WebCore:

Covered by updated tests.

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::add): Reverting back to ', '.

LayoutTests:

  • http/tests/xmlhttprequest/check-combining-headers-expected.txt:
  • http/tests/xmlhttprequest/check-combining-headers.html:
  • http/tests/xmlhttprequest/web-apps/005.html:
9:02 PM Changeset in webkit [213765] by Matt Baker
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Add "goto arrow" to DOMNodeTreeElements in the Debugger tab
https://bugs.webkit.org/show_bug.cgi?id=168752

Reviewed by Devin Rousso.

  • UserInterface/Base/DOMUtilities.js:

(WebInspector.linkifyNodeReference):
(WebInspector.linkifyNodeReferenceElement):
Expose linkifying an existing element.

  • UserInterface/Views/DOMNodeTreeElement.js:

(WebInspector.DOMNodeTreeElement):
(WebInspector.DOMNodeTreeElement.prototype.populateContextMenu):
Add "Reveal in DOM Tree" context menu item.

  • UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger .details-section.dom-breakpoints .item.dom-node:not(:hover, .selected) .status .go-to-arrow):
Hide the go-to arrow unless hovering or selected.

7:00 PM Changeset in webkit [213764] by commit-queue@webkit.org
  • 15 edits in trunk

Enable async image decoding for large images
https://bugs.webkit.org/show_bug.cgi?id=165039

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-03-11
Reviewed by Simon Fraser.

Source/WebCore:

When BitmapImage::draw() is called for a large image, we are going to request async
image decoding for the native image instead of drawing it. If a lower resolution
native image is available for this, it is going to be drawn. Otherwise nothing will
be drawn. In both cases, a repaint will be scheduled for the image observer. This
should improve the image first time paint and the scrolling scenarios. It also makes
the scrolling more responsive by removing the decoding step from the main thread.

For now we are going to disable the asynchronous image decoding for the webkit test
runner because drawing the image does not block the page rendering anymore. An image
can be repainted later when its frame is ready for painting. This can cause a test
to fail because the webkit test runner may capture an image for the page before painting
all the images. The asynchronous image decoding can to be explicitly enabled from
the test page. Once the specs of the image 'async' attribute and 'ready' event is
approved, this should be revisited. It is important to test what we ship and eventually
async image decoding should be enabled in the webkit test runner.

  • loader/cache/CachedImage.h: Change the default of LargeImageAsyncDecoding and AnimatedImageAsyncDecoding

to be false. This change fixes a layout test which creates an CachedImage inside an ImageDocument. The
CachedImage in this case does not have a loader so getting the values of these options from the settings
which is false for the DRT/WTR did not happen.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData): ImageSource::hasDecodingQueue() is renamed to ImageSource::hasAsyncDecodingQueue().
(WebCore::BitmapImage::frameImageAtIndex): Use String::utf8().data() instead of String::characters8().
(WebCore::BitmapImage::draw): If drawing the current frame is called while it is being
decoded, draw the current native image if the current frame was decoded but for a
different size and and will not invoke decoding while painting. If the frame is being
decoded and there isn't a decoded frame, return without drawing but set a flag that
that this image needs a repaint.
(WebCore::BitmapImage::shouldUseAsyncDecodingForLargeImage): Renaming a function.
(WebCore::BitmapImage::shouldUseAsyncDecodingForAnimatedImage): Ditto.
(WebCore::BitmapImage::internalStartAnimation): Use String::utf8().data() instead of String::characters8().
(WebCore::BitmapImage::advanceAnimation): Ditto.
(WebCore::BitmapImage::internalAdvanceAnimation): Ditto.
(WebCore::BitmapImage::newFrameNativeImageAvailableAtIndex): Now this callback can be
called form the ImageFrameCache when finishing a frame of an animated image or the
frame of a large image. For large images, we need to call CachedImage::changedInRect()
if this image needs a repaint. If the decoding queue is idle, we should close it.
(WebCore::BitmapImage::isLargeImageAsyncDecodingRequired): Deleted. Function was renamed.
(WebCore::BitmapImage::isAnimatedImageAsyncDecodingRequired): Deleted. Ditto.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::~ImageFrameCache): hasDecodingQueue() was renamed to hasAsyncDecodingQueue().
(WebCore::ImageFrameCache::decodingQueue): Change the QNS of the decoding thread to be WorkQueue::QOS::Default.
WorkQueue::QOS::UserInteractive causes the scrolling thread to preempted which can make the scrolling choppy.
(WebCore::ImageFrameCache::startAsyncDecodingQueue): hasDecodingQueue() was renamed to hasAsyncDecodingQueue().
(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex): Ditto.
(WebCore::ImageFrameCache::isAsyncDecodingQueueIdle): A helper function to tell whether the decoding thread is idle.
(WebCore::ImageFrameCache::stopAsyncDecodingQueue): hasDecodingQueue() was renamed to hasAsyncDecodingQueue().

  • platform/graphics/ImageFrameCache.h:

(WebCore::ImageFrameCache::hasAsyncDecodingQueue): Rename this function to be consistent with the rest of the functions.
(WebCore::ImageFrameCache::hasDecodingQueue): Deleted.

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::shouldUseAsyncDecoding): Renaming a function. Change the heuristic for large images be
a little bigger than the heuristic for animated images.
(WebCore::ImageSource::isAsyncDecodingRequired): Deleted.

  • platform/graphics/ImageSource.h:

(WebCore::ImageSource::hasAsyncDecodingQueue): hasDecodingQueue() was renamed to hasAsyncDecodingQueue().
(WebCore::ImageSource::isAsyncDecodingQueueIdle): A wrapper for ImageFrameCache::isAsyncDecodingQueueIdle().
(WebCore::ImageSource::hasDecodingQueue): Deleted.

  • platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoder::createFrameImageAtIndex): CGImageSourceCreateThumbnailAtIndex() returns a CGImage with
the image native size regardless of the subsamplingLevel unless kCGImageSourceSubsampleFactor is passed. Here
we are trying to see which size is smaller: the image native size or the sizeForDrawing. If we want a CGImage
with the image native size, sizeForDrawing will not passed. So we need to get the image native size with the
default subsampling and then compare it with sizeForDrawing.

Source/WebKit2:

Add WK2 preferences for setting/getting LargeImageAsyncDecoding and
AnimatedImageAsyncDecoding.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLargeImageAsyncDecodingEnabled):
(WKPreferencesGetLargeImageAsyncDecodingEnabled):
(WKPreferencesSetAnimatedImageAsyncDecodingEnabled):
(WKPreferencesGetAnimatedImageAsyncDecodingEnabled):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

Disable LargeImageAsyncDecoding for DRT/WTR.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

5:07 PM Changeset in webkit [213763] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: fix broken font content view
https://bugs.webkit.org/show_bug.cgi?id=169513

Reviewed by Brian Burg.

Add RTL support to the Font content view.

  • UserInterface/Views/FontResourceContentView.css:

(.content-view.resource.font .preview > .line > .metric):
(body[dir=ltr] .content-view.resource.font .preview > .line > .metric):
(body[dir=rtl] .content-view.resource.font .preview > .line > .metric):
Compensate for the flipped z-order of the content and metric elements in
RTL by pushing metrics below the content.

3:09 PM Changeset in webkit [213762] by dino@apple.com
  • 11 edits
    47 copies
    17 adds in trunk/Source

WebGPU prototype - Front-End
https://bugs.webkit.org/show_bug.cgi?id=167952

Patch by Jon Lee <jonlee@apple.com> on 2017-03-11
Reviewed by Dean Jackson.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h: Add WebGPU objects.

Source/WebCore:

This patch adds all of the relevant front-end files, and builds successfully when
ENABLE(WEBGPU) is off. For the back-end components that are not yet
implemented, a stub was added with a FIXME.

  • DerivedSources.make: Add all the new IDL files.
  • WebCore.xcodeproj/project.pbxproj: New IDL, front-end and generated files.

JS custom bindings.

  • bindings/js/JSDocumentCustom.cpp: Add WebGPU clause for getCSSCanvasContext.
  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSWebGPURenderPassAttachmentDescriptorCustom.cpp: Added.
  • bindings/js/JSWebGPURenderingContextCustom.cpp: Added.
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::isWebGPUType):
(WebCore::HTMLCanvasElement::getContextWebGPU):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::isGPU):
(WebCore::HTMLCanvasElement::getContextWebGPU): For release builds, switch to ASSERT_UNUSED.

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext.h:

(WebCore::CanvasRenderingContext::isGPU):

.cpp, .h, .idl files, wrapped in WEBGPU conditional, and enabled at runtime.

  • html/canvas/WebGPUBuffer:
  • html/canvas/WebGPUCommandBuffer:
  • html/canvas/WebGPUCommandQueue:
  • html/canvas/WebGPUDepthStencilDescriptor:
  • html/canvas/WebGPUDepthStencilState:
  • html/canvas/WebGPUDrawable:
  • html/canvas/WebGPUEnums:
  • html/canvas/WebGPUFunction:
  • html/canvas/WebGPULibrary:
  • html/canvas/WebGPUObject (no IDL):
  • html/canvas/WebGPURenderCommandEncoder:
  • html/canvas/WebGPURenderPassAttachmentDescriptor:
  • html/canvas/WebGPURenderPassColorAttachmentDescriptor:
  • html/canvas/WebGPURenderPassDepthAttachmentDescriptor:
  • html/canvas/WebGPURenderPassDescriptor:
  • html/canvas/WebGPURenderPipelineColorAttachmentDescriptor:
  • html/canvas/WebGPURenderPipelineDescriptor:
  • html/canvas/WebGPURenderPipelineState:
  • html/canvas/WebGPURenderingContext:
  • html/canvas/WebGPUTexture:
  • html/canvas/WebGPUTextureDescriptor: Add stubs.
11:59 AM Changeset in webkit [213761] by Jon Davis
  • 1 edit
    1 add in trunk/Websites/webkit.org

Add Swift syntax highlighting to webkit.org
https://bugs.webkit.org/show_bug.cgi?id=163672

Reviewed by Matt Baker.

  • wp-content/plugins/hyperlight/hyperlight/languages/swift.php: Added.
10:03 AM Changeset in webkit [213760] by achristensen@apple.com
  • 5 edits
    1 copy in trunk/Source/WebKit2

Rollout r213746
https://bugs.webkit.org/show_bug.cgi?id=169497

That change broke a bunch of tests in storage/indexeddb.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):

  • NetworkProcess/RemoteNetworkingContext.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp: Copied from WebKit2/NetworkProcess/soup/RemoteNetworkingContextSoup.cpp.
  • PlatformGTK.cmake:
8:44 AM Changeset in webkit [213759] by beidson@apple.com
  • 31 edits
    2 copies in trunk/Source

Cleanup "addCookie" and its sole user.
https://bugs.webkit.org/show_bug.cgi?id=169486

Reviewed by Brian Burg.

Source/WebCore:

No new tests (Refactor, no behavior change)

  • WebCore.xcodeproj/project.pbxproj:
  • loader/CookieJar.cpp:

(WebCore::addCookie): Deleted.

  • loader/CookieJar.h:
  • platform/Cookie.h:

(WebCore::Cookie::Cookie):
(WebCore::CookieHash::hash):
(WebCore::CookieHash::equal):
(WebCore::Cookie::encode):
(WebCore::Cookie::decode):

  • platform/CookiesStrategy.h:
  • platform/network/NetworkStorageSession.h:
  • platform/network/PlatformCookieJar.h:
  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::addCookie): Deleted.

  • platform/network/cocoa/CookieCocoa.mm: Copied from Source/WebCore/loader/CookieJar.h.

(WebCore::Cookie::operator NSHTTPCookie *):

  • platform/network/cocoa/NetworkStorageSessionCocoa.mm: Copied from Source/WebCore/loader/CookieJar.h.

(WebCore::NetworkStorageSession::setCookies):
(WebCore::NetworkStorageSession::nsCookieStorage):

  • platform/network/curl/CookieJarCurl.cpp:

(WebCore::addCookie): Deleted.

  • platform/network/mac/CookieJarMac.mm:

(WebCore::deleteCookiesForHostnames):
(WebCore::deleteAllCookiesModifiedSince):
(WebCore::addCookie): Deleted.
(WebCore::cookieStorage): Deleted.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::toSoupCookie): Deleted.
(WebCore::addCookie): Deleted.

  • platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::toSoupCookie):
(WebCore::NetworkStorageSession::setCookies):

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::addCookie): Deleted.

Source/WebKit2:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::addCookie): Deleted.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Cookie>::encode): Deleted.
(IPC::ArgumentCoder<Cookie>::decode): Deleted.

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::addSingleCookie):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::setCookies):
(WebKit::WebCookieManagerProxy::addCookie): Deleted.

  • UIProcess/WebCookieManagerProxy.h:
  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::setCookies):
(WebKit::WebCookieManager::addCookie): Deleted.

  • WebProcess/Cookies/WebCookieManager.h:
  • WebProcess/Cookies/WebCookieManager.messages.in:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::addCookie): Deleted.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
5:57 AM Changeset in webkit [213758] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WTF

REGRESSION(r213645): It made JSC tests super slow and timeout on AArch64 Linux
https://bugs.webkit.org/show_bug.cgi?id=169510

Unreviewed, disable LL_SC on Linux to unbreak this platform.

  • wtf/Atomics.h:
  • wtf/Platform.h:
12:56 AM Changeset in webkit [213757] by bshafiei@apple.com
  • 12 edits in tags/Safari-604.1.10

Merged r213752. rdar://problem/30990870

12:38 AM Changeset in webkit [213756] by bshafiei@apple.com
  • 12 edits in tags/Safari-604.1.9.1

Merged r213752. rdar://problem/30990870

12:36 AM Changeset in webkit [213755] by bshafiei@apple.com
  • 7 edits in tags/Safari-604.1.9.1/Source

Versioning.

12:32 AM Changeset in webkit [213754] by bshafiei@apple.com
  • 1 copy in tags/Safari-604.1.9.1

New tag.

Note: See TracTimeline for information about the timeline view.