Timeline



Aug 8, 2017:

10:36 PM Changeset in webkit [220443] by wenson_hsieh@apple.com
  • 29 edits
    4 deletes in trunk

Unreviewed, rolling out r220393.

This patch regresses the performance of WebPage::editorState.

Reverted changeset:

"[iOS WK2] WKWebView schedules nonstop layout after pressing
cmb+b,i,u inside a contenteditable div"
https://bugs.webkit.org/show_bug.cgi?id=175116
http://trac.webkit.org/changeset/220393

10:15 PM Changeset in webkit [220442] by Chris Dumez
  • 28 edits
    17 adds in trunk

[Beacon] Add support for CORS-preflighting for WK2 / NETWORK_SESSION
https://bugs.webkit.org/show_bug.cgi?id=175264
<rdar://problem/33547793>

Reviewed by Youenn Fablet.

Source/WebCore:

Pass additional information when creating a PingHandle so that the PingLoad
can deal with CORS-preflighting on Network process side.

Tests: http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html

http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html
http/wpt/beacon/cors/cors-preflight-blob-failure.html
http/wpt/beacon/cors/cors-preflight-blob-success.html
http/wpt/beacon/cors/cors-preflight-cookie.html

  • WebCore.xcodeproj/project.pbxproj:
  • loader/CrossOriginAccessControl.cpp:

(WebCore::validatePreflightResponse):

  • loader/CrossOriginAccessControl.h:
  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):

  • loader/CrossOriginPreflightResultCache.h:
  • loader/LoaderStrategy.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):

  • loader/PingLoader.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • page/SecurityOrigin.h:

Source/WebKit:

Implement CORS-preflighting for beacons with a payload that has a non
safelisted MIME type, as per:

CORS-preflighting is completely handled on Network Process side because
a beacon request can outlive its page and therefore its WebContent
process. This requires us to pass a little more information to the
Network process, in particular the source origin and the corsMode.

The current implementation does not currently deal with CORS preflights
needed upon a redirect. This will be added in a follow-up.

  • CMakeLists.txt:
  • NetworkProcess/NetworkCORSPreflightChecker.cpp: Added.

(WebKit::NetworkCORSPreflightChecker::NetworkCORSPreflightChecker):
(WebKit::NetworkCORSPreflightChecker::~NetworkCORSPreflightChecker):
(WebKit::NetworkCORSPreflightChecker::startPreflight):
(WebKit::NetworkCORSPreflightChecker::willPerformHTTPRedirection):
(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
(WebKit::NetworkCORSPreflightChecker::didReceiveResponseNetworkSession):
(WebKit::NetworkCORSPreflightChecker::didReceiveData):
(WebKit::NetworkCORSPreflightChecker::didCompleteWithError):
(WebKit::NetworkCORSPreflightChecker::didSendData):
(WebKit::NetworkCORSPreflightChecker::wasBlocked):
(WebKit::NetworkCORSPreflightChecker::cannotShowURL):

  • NetworkProcess/NetworkCORSPreflightChecker.h: Added.
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/NetworkResourceLoadParameters.h:
  • NetworkProcess/PingLoad.cpp: Added.

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::startNetworkLoad):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveChallenge):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::didReceiveData):
(WebKit::PingLoad::didCompleteWithError):
(WebKit::PingLoad::didSendData):
(WebKit::PingLoad::wasBlocked):
(WebKit::PingLoad::cannotShowURL):
(WebKit::PingLoad::timeoutTimerFired):
(WebKit::PingLoad::needsCORSPreflight const):
(WebKit::PingLoad::doCORSPreflight):

  • NetworkProcess/PingLoad.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::createPingHandle):

  • WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

createPingHandle() now takes new parameters but there is currently no behavior
change on WebKit1.

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::createPingHandle):

  • WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Add layout test coverage.

  • http/wpt/beacon/cors/cors-preflight-arraybufferview-failure-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html: Added.
  • http/wpt/beacon/cors/cors-preflight-arraybufferview-success-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html: Added.
  • http/wpt/beacon/cors/cors-preflight-blob-failure-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-blob-failure.html: Added.
  • http/wpt/beacon/cors/cors-preflight-blob-success-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-blob-success.html: Added.
  • http/wpt/beacon/cors/cors-preflight-cookie-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-cookie.html: Added.
  • http/wpt/beacon/resources/beacon-preflight.py: Added.

(respondToCORSPreflight):
(main):

  • http/wpt/beacon/resources/set-cookie.py: Added.

(main):

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/win/TestExpectations:
8:48 PM Changeset in webkit [220441] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

ICs should do caging
https://bugs.webkit.org/show_bug.cgi?id=175295

Reviewed by Saam Barati.

Adds the appropriate cage() calls in our inline caches.

  • bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

  • bytecode/InlineAccess.cpp:

(JSC::InlineAccess::dumpCacheSizesAndCrash):
(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::generateArrayLength):

8:24 PM Changeset in webkit [220440] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Address review feedback from https://bugs.webkit.org/show_bug.cgi?id=175246.

  • bindings/js/DOMPromiseProxy.h:
  • css/FontFaceSet.cpp:
  • css/FontFaceSet.h:
8:18 PM Changeset in webkit [220439] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.38.1-branch/Source/WebKitLegacy/mac

Cherry-pick r220429. rdar://problem/33789343

8:18 PM Changeset in webkit [220438] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.38.1-branch

Cherry-pick r220289. rdar://problem/33789082

8:09 PM Changeset in webkit [220437] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.38.0-branch

Cherry-pick r220289. rdar://problem/33789085

6:55 PM Changeset in webkit [220436] by Devin Rousso
  • 12 edits
    2 adds in trunk

Web Inspector: Canvas: support editing WebGL shaders
https://bugs.webkit.org/show_bug.cgi?id=124211
<rdar://problem/15448958>

Reviewed by Matt Baker.

Source/JavaScriptCore:

  • inspector/protocol/Canvas.json:

Add updateShader command that will change the given shader's source to the provided string,
recompile, and relink it to its associated program.
Drive-by: add description to requestShaderSource command.

Source/WebCore:

Test: inspector/canvas/updateShader.html

  • inspector/InspectorCanvasAgent.h:
  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::updateShader):

  • html/canvas/WebGLRenderingContextBase.h:
  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::linkProgram):
(WebCore::WebGLRenderingContextBase::linkProgramWithoutInvalidatingAttribLocations):
Normally, when a program is linked, it invalidates any WebGLUniformLocation associated with
the program by incrementing its linkCount. In order to allow live editing of shaders, we
need to be able to compile and link a shader without invalidating these locations. This
patch moves the shader linking logic to its own function that is called by linkProgram so
that InspectorCanvasAgent can compile and link without invalidation.

Source/WebInspectorUI:

  • UserInterface/Models/ShaderProgram.js:

(WI.ShaderProgram.prototype.updateVertexShader):
(WI.ShaderProgram.prototype.updateFragmentShader):
(WI.ShaderProgram.prototype._updateShader):

  • UserInterface/Views/ShaderProgramContentView.js:

(WI.ShaderProgramContentView):
(WI.ShaderProgramContentView.prototype._contentDidChange):

LayoutTests:

  • inspector/canvas/updateShader-expected.txt: Added.
  • inspector/canvas/updateShader.html: Added.
  • platform/win/TestExpectations:
6:39 PM Changeset in webkit [220435] by Megan Gardner
  • 3 edits in trunk/Source/WebKit

Remove old and unused pointIsInAssistedNode definition
https://bugs.webkit.org/show_bug.cgi?id=175335

Stage removal here to allow removal from UIKit.
Replaced by textInteractionGesture:shouldBeginAtPoint:

Reviewed by Tim Horton.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView pointIsInAssistedNode:]): Deleted.

6:24 PM Changeset in webkit [220434] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

Created Individual EWS Pages
https://bugs.webkit.org/show_bug.cgi?id=174477

Patch by obinna obike <oobike@apple.com> on 2017-08-08
Reviewed by Aakash Jain.

Created individual pages for each EWS. Changed the link within each status bubble
to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.

  • QueueStatusServer/handlers/patch.py:

(Patch.get): Handles the case for individual ews queue as well as for all EWS queues.

  • QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_bubble): Updated url for specific EWS.

  • QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
  • QueueStatusServer/templates/patch.html: Added a link to go directly to the page with

all ews queues.

  • QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it

takes you directly to the individual ews page.

6:01 PM Changeset in webkit [220433] by weinig@apple.com
  • 33 edits
    1 add
    5 deletes in trunk/Source/WebCore

[WebIDL] Add support for Promise<> attributes
https://bugs.webkit.org/show_bug.cgi?id=175246

Reviewed by Yusuke Suzuki.

Introduces and adopts DOMPromiseProxy, a new class for binding promises in a more
straightforward and safe (from a wrapper world perspective) way.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSFontFaceCustom.cpp: Removed.
  • bindings/js/JSFontFaceSetCustom.cpp: Removed.
  • bindings/js/JSMediaKeySessionCustom.cpp: Removed.
  • bindings/js/JSServiceWorkerContainerCustom.cpp: Removed.
  • bindings/js/JSWebGPUCommandBufferCustom.cpp: Removed.

Remove custom bindings only needed for promise attributes. Add DOMPromiseProxy.h

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::sessionClosed):
(WebCore::MediaKeySession::registerClosedPromise): Deleted.

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/MediaKeySession.idl:

Replace custom promise code using the registerPromise idiom with DOMPromiseProxy.

  • bindings/IDLTypes.h:

Add StorageType type alias to allow specifying a specific form for storage. This allows
use to use Ref<> for interfaces in DOMPromiseProxy.

(WebCore::IDLWrapper::convertToParameterType):

Also add convertToParameterType, an annoying hack to workaround the fact WTF::Function
can't return references / no

  • bindings/js/DOMPromiseProxy.h: Added.

(WebCore::DOMPromiseProxy<IDLType>):

DOMPromiseProxy is a new class (set of classes) to represent promises that works with the
standard toJS<> / JSDOMConvert infrastructure used by the bindings generator. From the
implementation perspective, it is similar to DOMPromiseDeferred, but instead of receiving
one as a parameter, you can initialize it directly in your constructor and start using it.

From the bindings perspective, a DOMPromiseProxy can be converted into a JS Promise by calling
its promise function, which will either create a new promise, or return a cached one.

To make this work, DOMPromiseProxy maintains a Vector of DeferredPromises that hold onto those
actualized promises. The reason it has a Vector, is that we need one DeferredPromises per
DOMWrapperWorld, just like we need one wrapper for an interface per DOMWrapperWorld in the
wrapper cache. In most cases, only the normal world will be in play, so the Vector has an inline
capacity of one.


In addition, DOMPromiseProxy maintains a Variant of either an Exception or the result value type.
This allows the DOMPromiseProxy to be resolved or rejected at anytime. Then, when the bindings
request the promise, the stored result / exception can be resolved / rejected into the promise.

(WebCore::DOMPromiseProxy<IDLVoid>):

For void promises, we need slightly different semantics (resolve takes no parameters, Value is
a bit indicating resolved state), so it is specialized.

(WebCore::DOMPromiseProxyWithResolveCallback<IDLType>):

In addition to the void specialization, we have DOMPromiseProxyWithResolveCallback. Instead of
storing the value of the resolution directly, this specialization allows the owner to specify
callback to be called when the resolved value is needed. This is needed to avoid reference
cycles when the resolved value is the owner such as is the case with FontFace and FontFaceSet.

  • bindings/js/JSDOMConvertPromise.h:

(WebCore::JSConverter<IDLPromise<T>>::convert):
Add converter that calls through to the DOMPromiseProxy function promise.

  • bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::callFunction):
(WebCore::DeferredPromise::reject):

  • bindings/js/JSDOMPromiseDeferred.h:

(WebCore::DeferredPromise::create):
(WebCore::DeferredPromise::DeferredPromise):

Add a new create function for DeferredPromise that creates the JSPromiseDeferred for you.
Also adds a mode to DeferredPromise to allow keeping the promise after resolution. Maintain
the old behavior as the default.

Change reject to take an Exception as sink rather than an r-value, to allow DOMPromiseProxy
to copy a Exception into multiple DeferredPromises. For callers already moving into reject,
this should be no change.

  • bindings/scripts/CodeGeneratorJS.pm:

(AddToIncludesForIDLType):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(NativeToJSValueDOMConvertNeedsState):
(NativeToJSValueDOMConvertNeedsGlobalObject):

Add support DOMPromiseProxy. For now, this means a new extended attribute, [PromiseProxy],
but once I convert all the existing promises over to using DOMPromiseProxy, it will be removed.


Also specify the right #includes for promises and necessary parameters for conversion.

  • bindings/scripts/IDLAttributes.json:


Add [PromiseProxy], a temporary extended attribute for using DOMPromiseProxy.

  • css/FontFace.cpp:
  • css/FontFace.h:
  • css/FontFace.idl:
  • css/FontFaceSet.cpp:
  • css/FontFaceSet.h:
  • css/FontFaceSet.idl:

Replace custom promise code using the registerPromise idiom with DOMPromiseProxyWithResolveCallback.
The callback is necessary for these two classes since the value the resolve is themselves, and using
a normal resolve would create a cycle.

  • html/canvas/WebGPUCommandBuffer.cpp:
  • html/canvas/WebGPUCommandBuffer.h:
  • html/canvas/WebGPUCommandBuffer.idl:
  • platform/graphics/cocoa/GPUCommandBufferMetal.mm:
  • platform/graphics/gpu/GPUCommandBuffer.cpp:
  • platform/graphics/gpu/GPUCommandBuffer.h:

Replace custom promise code using the registerPromise idiom with DOMPromiseProxy.

  • page/NavigatorBase.cpp:

(WebCore::NavigatorBase::NavigatorBase):

  • page/NavigatorBase.h:

Forward declare ServiceWorkerContainer and add an explicit constructor to allow
removing #include of ServiceWorkerContainer.h in the header, avoiding an #include cycle.

  • workers/ServiceWorkerContainer.cpp:
  • workers/ServiceWorkerContainer.h:
  • workers/ServiceWorkerContainer.idl:

Replace custom promise code using the registerPromise idiom with DOMPromiseProxy.

  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
  • bindings/scripts/test/TestObj.idl:

Add / update tests.

5:26 PM Changeset in webkit [220432] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Make JSC_validateExceptionChecks=1 succeed on JSTests/slowMicrobenchmarks/spread-small-array.js.
https://bugs.webkit.org/show_bug.cgi?id=175347

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-08
Reviewed by Saam Barati.

This is done by making finishCreation explicitely check for exceptions after setConstantRegister and setConstantIdentifiersSetRegisters.
I chose to have this check replace the boolean returned previously by these functions for readability. The performance impact should be
negligible considering how much more finishCreation does.
This fix then caused another issue to appear as it was now clear that finishCreation can throw. And since it is called by ProgramCodeBlock::create(),
FunctionCodeBlock::create() and friends, that are in turn called by ScriptExecutable::newCodeBlockFor, this last function also required a few tweaks.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setConstantIdentifierSetRegisters):
(JSC::CodeBlock::setConstantRegisters):

  • bytecode/CodeBlock.h:
  • runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):

5:18 PM Changeset in webkit [220431] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Tools

Separate jsc stress test script writer from run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=175216

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-08-08
Reviewed by Mark Lam.

  • Scripts/run-jsc-stress-tests:
  • Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
5:03 PM Changeset in webkit [220430] by wilander@apple.com
  • 2 edits in trunk/Source/WebCore

Resource Load Statistics: Merge of dataRecordsRemoved should use std::max()
https://bugs.webkit.org/show_bug.cgi?id=175348
<rdar://problem/33785695>

Reviewed by Chris Dumez.

No new tests. Online change of a statistic that doesn't affect logic flow.

  • loader/ResourceLoadStatistics.cpp:

(WebCore::ResourceLoadStatistics::merge):

Now uses std::max() instead of addition.

4:53 PM Changeset in webkit [220429] by beidson@apple.com
  • 3 edits in trunk/Source/WebKitLegacy/mac

Don't enable default icon loading in WK1 for apps linked against old SDKs.
<rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342

Reviewed by Andy Estes.

  • Misc/WebKitVersionChecks.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless

the app is linked against new WebKit with the new behavior.

4:36 PM Changeset in webkit [220428] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175195

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
4:27 PM Changeset in webkit [220427] by Brent Fulgham
  • 4 edits
    3 adds in trunk

Sandbox flags do not support document.domain control
https://bugs.webkit.org/show_bug.cgi?id=175281
<rdar://problem/33778936>

Reviewed by Chris Dumez.

Source/WebCore:

Update the 'setDomain' logic to honor the sandbox properties as defined in the current
HTML5 specification. This brings us in line with how Chrome and other browsers have
worked for some time.

Test: fast/frames/sandboxed-iframe-domain.html

  • dom/Document.cpp:

(WebCore::Document::setDomain): Add check for sandbox flag (with appropriate error message)

  • dom/SecurityContext.h:

LayoutTests:

  • fast/frames/resources/sandboxed-iframe-set-domain.html: Added.
  • fast/frames/sandboxed-iframe-domain.html: Added.
  • fast/frames/sandboxed-iframe-domain-expected.txt: Added.
4:24 PM Changeset in webkit [220426] by Matt Lewis
  • 3 edits in trunk/LayoutTests

Skipping imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
<rdar://problem/33555052>

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-highsierra/TestExpectations:
4:03 PM Changeset in webkit [220425] by Michael Catanzaro
  • 9 edits in trunk

Unreviewed, fix Ubuntu LTS build
https://bugs.webkit.org/show_bug.cgi?id=174490

Source/JavaScriptCore:

  • inspector/remote/glib/RemoteInspectorGlib.cpp:
  • inspector/remote/glib/RemoteInspectorServer.cpp:

Source/WebDriver:

  • glib/SessionHostGlib.cpp:

Source/WebKit:

  • UIProcess/glib/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorClient::RemoteInspectorClient):

Tools:

  • TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3:53 PM Changeset in webkit [220424] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:50 PM Changeset in webkit [220423] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

3:46 PM Changeset in webkit [220422] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.1.2

Tag Safari-604.1.38.1.2.

3:45 PM Changeset in webkit [220421] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.2

Tag Safari-604.1.38.0.2.

2:38 PM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
2:06 PM Changeset in webkit [220420] by wenson_hsieh@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed, fix the Mac debug build after r220418.

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::prepareForMoveToWindow):

1:55 PM Changeset in webkit [220419] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip plugins/crash-restoring-plugin-page-from-page-cache.html on macOS debug.
https://bugs.webkit.org/show_bug.cgi?id=175270

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:53 PM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
1:52 PM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
1:45 PM Changeset in webkit [220418] by wenson_hsieh@apple.com
  • 6 edits
    2 moves in trunk

[Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
https://bugs.webkit.org/show_bug.cgi?id=175302
<rdar://problem/33762116>

Reviewed by Tim Horton.

Source/WebKit:

Refactor WebViewImpl's m_view from a raw pointer to a WeakObjCPtr to ensure that it is automatically cleared out
when the WKWebView or WKView are destroyed, and also changes several places where we implicitly block capture
the WebViewImpl to only capture a WeakPtr to the WebViewImpl. Most of the changes here are boilerplate
adjustments for how m_view is now a weak pointer.

Test: WKWebViewMacEditingTests.DoNotCrashWhenInterpretingKeyEventWhileDeallocatingView.

  • Shared/mac/WeakObjCPtr.h:

(WebKit::WeakObjCPtr::operator ValueType * const):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::updateTouchBar):
(WebKit::WebViewImpl::updateMediaTouchBar):
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::~WebViewImpl):
(WebKit::WebViewImpl::window):
(WebKit::WebViewImpl::resignFirstResponder):
(WebKit::WebViewImpl::isFocused const):
(WebKit::WebViewImpl::renewGState):
(WebKit::WebViewImpl::setFrameAndScrollBy):
(WebKit::WebViewImpl::updateWindowAndViewFrames):
(WebKit::WebViewImpl::updateLayer):
(WebKit::WebViewImpl::printOperationWithPrintInfo):
(WebKit::WebViewImpl::updateContentInsetsIfAutomatic):
(WebKit::WebViewImpl::setLayoutMode):
(WebKit::WebViewImpl::intrinsicDeviceScaleFactor const):
(WebKit::WebViewImpl::windowDidBecomeKey):
(WebKit::WebViewImpl::windowDidResignKey):
(WebKit::WebViewImpl::windowDidChangeScreen):
(WebKit::WebViewImpl::mightBeginDragWhileInactive):
(WebKit::WebViewImpl::acceptsFirstMouse):
(WebKit::WebViewImpl::shouldDelayWindowOrderingForEvent):
(WebKit::WebViewImpl::windowResizeMouseLocationIsInVisibleScrollerThumb):
(WebKit::WebViewImpl::viewWillMoveToWindow):
(WebKit::WebViewImpl::viewDidMoveToWindow):
(WebKit::WebViewImpl::viewDidChangeBackingProperties):
(WebKit::WebViewImpl::hitTest):
(WebKit::WebViewImpl::postFakeMouseMovedEventForFlagsChangedEvent):
(WebKit::WebViewImpl::colorSpace):
(WebKit::WebViewImpl::prepareForMoveToWindow):
(WebKit::WebViewImpl::notifyInputContextAboutDiscardedComposition):
(WebKit::WebViewImpl::pressureChangeWithEvent):
(WebKit::WebViewImpl::fullScreenWindowController):
(WebKit::WebViewImpl::executeSavedCommandBySelector):
(WebKit::WebViewImpl::validRequestorForSendAndReturnTypes):
(WebKit::WebViewImpl::handleRequestedCandidates):
(WebKit::WebViewImpl::preferencesDidChange):
(WebKit::WebViewImpl::setTextIndicator):
(WebKit::WebViewImpl::dismissContentRelativeChildWindowsFromViewOnly):
(WebKit::WebViewImpl::accessibilityRegisterUIProcessTokens):
(WebKit::WebViewImpl::sendToolTipMouseExited):
(WebKit::WebViewImpl::sendToolTipMouseEntered):
(WebKit::WebViewImpl::toolTipChanged):
(WebKit::WebViewImpl::setAcceleratedCompositingRootLayer):
(WebKit::WebViewImpl::updateThumbnailViewLayer):
(WebKit::WebViewImpl::setInspectorAttachmentView):
(WebKit::WebViewImpl::inspectorAttachmentView):
(WebKit::WebViewImpl::draggedImage):
(WebKit::WebViewImpl::draggingEntered):
(WebKit::WebViewImpl::draggingUpdated):
(WebKit::WebViewImpl::draggingExited):
(WebKit::WebViewImpl::performDragOperation):
(WebKit::WebViewImpl::hitTestForDragTypes):
(WebKit::WebViewImpl::startWindowDrag):
(WebKit::WebViewImpl::dragImageForView):
(WebKit::WebViewImpl::setPromisedDataForImage):
(WebKit::WebViewImpl::setPromisedDataForAttachment):
(WebKit::WebViewImpl::takeViewSnapshot):
(WebKit::WebViewImpl::scrollWheel):
(WebKit::WebViewImpl::magnifyWithEvent):
(WebKit::WebViewImpl::rotateWithEvent):
(WebKit::WebViewImpl::doneWithKeyEvent):
(WebKit::WebViewImpl::interpretKeyEvent):
(WebKit::WebViewImpl::firstRectForCharacterRange):
(WebKit::WebViewImpl::characterIndexForPoint):
(WebKit::WebViewImpl::performKeyEquivalent):
(WebKit::WebViewImpl::keyUp):
(WebKit::WebViewImpl::keyDown):
(WebKit::WebViewImpl::mouseMoved):
(WebKit::WebViewImpl::windowIsFrontWindowUnderMouse):
(WebKit::WebViewImpl::userInterfaceLayoutDirection):

Tools:

Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
See WebKit ChangeLog for more details.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
  • TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.

(-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
(-[SlowTextInputContext handleEvent:completionHandler:]):
(-[SlowInputWebView inputContext]):
(-[SlowInputWebView _web_superInputContext]):
(TEST):

1:42 PM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
12:58 PM Changeset in webkit [220417] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark fast/images/async-image-body-background-image.html as flaky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=175193

Unreviewed test gardening.

  • platform/mac/TestExpectations:
12:44 PM Changeset in webkit [220416] by fpizlo@apple.com
  • 14 edits in trunk/Source

Baseline JIT should do caging
https://bugs.webkit.org/show_bug.cgi?id=175037

Reviewed by Mark Lam.
Source/bmalloc:


This centralizes the notion of permanently enabling the primitive gigacage, which we only do in jsc
and WebProcess.

This saves the baseline JIT from emitting some code. Otherwise it would always have to emit enabled
checks on each typed array access.

  • bmalloc/Gigacage.cpp:

(Gigacage::primitiveGigacageDisabled):
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::isDisablingPrimitiveGigacageDisabled):

  • bmalloc/Gigacage.h:

(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):

Source/JavaScriptCore:


Adds a AssemblyHelpers::cage and cageConditionally. Uses it in the baseline JIT.

Also modifies FTL caging to be more defensive when caging is disabled.

Relanded with fixed AssemblyHelpers::cageConditionally().

  • bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

  • bytecode/InlineAccess.cpp:

(JSC::InlineAccess::dumpCacheSizesAndCrash):
(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::generateArrayLength):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::cage):
(JSC::AssemblyHelpers::cageConditionally):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDoubleLoad):
(JSC::JIT::emitContiguousLoad):
(JSC::JIT::emitArrayStorageLoad):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

  • jsc.cpp:

(jscmain):
(primitiveGigacageDisabled): Deleted.

Source/WebKit:


Use a better API to disable disabling the primitive gigacage.

  • WebProcess/WebProcess.cpp:

(WebKit::m_webSQLiteDatabaseTracker):
(WebKit::primitiveGigacageDisabled): Deleted.

Source/WTF:

  • wtf/Gigacage.h:

(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::isDisablingPrimitiveGigacageDisabled):
(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):
(Gigacage::basePtr):

12:16 PM Changeset in webkit [220415] by Yusuke Suzuki
  • 2 edits in trunk/JSTests

Unreviewed, gardening test262 for Promise resolve / reject function length
https://bugs.webkit.org/show_bug.cgi?id=175333

  • test262.yaml:
12:03 PM Changeset in webkit [220414] by commit-queue@webkit.org
  • 7 edits in trunk

Change fast seek logic to prevent ping-ponging.
https://bugs.webkit.org/show_bug.cgi?id=175167
rdar://problem/32936116

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-08
Reviewed by Jer Noble.

Source/WebCore:

Updated test: media/video-fast-seek.html

Changed fast seek behavior to always seek early than seek time; and after current time when seeking forward.
This prevents ping-ponging, where a fast seek overshoots the target looking for a keyframe.
A subsequent seek will suddenly be on the other side of current time and
will search in the opposite direction for a key frame; repeat.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::fastSeek):

LayoutTests:

Test now requires forward fast seek result to be between current time and the target time,
and a backward seek to be before the seek time.

  • media/video-fast-seek.html:
  • media/media-source/media-source-fastseek.html:
11:20 AM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
11:17 AM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
10:22 AM Changeset in webkit [220413] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Remove obsolete failure expectations for event_loadedmetadata.html.
https://bugs.webkit.org/show_bug.cgi?id=175027

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-08

10:18 AM Changeset in webkit [220412] by wilander@apple.com
  • 20 edits
    2 adds in trunk

Resource Load Statistics: Clear web processes' state on history removal
https://bugs.webkit.org/show_bug.cgi?id=175271
<rdar://problem/33756560>

Reviewed by Chris Dumez.

Source/WebKit:

https://bugs.webkit.org/show_bug.cgi?id=175090 introduced state
in the web process and that state needs to be cleared when the
UI process' statistics are cleared as part of history removal.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::clearResourceLoadStatistics):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::clearResourceLoadStatisticsInWebProcesses):

  • UIProcess/WebsiteData/WebsiteDataStore.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::clearResourceLoadStatistics):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Tools:

Test infrastructure for asynchronous tests of website data
removal for _WKWebsiteDataTypeResourceLoadStatistics.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
(WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::statisticsClearThroughWebsiteDataRemoval):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):

  • WebKitTestRunner/TestInvocation.h:
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::statisticsClearThroughWebsiteDataRemoval):

LayoutTests:

  • http/tests/loading/resourceLoadStatistics/user-interaction-reported-after-website-data-removal-expected.txt: Added.
  • http/tests/loading/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html: Added.
  • platform/mac-wk2/TestExpectations:

user-interaction-reported-after-website-data-removal.html marked as [ Pass ].

10:15 AM Changeset in webkit [220411] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Correct the function name in a debug message.
https://bugs.webkit.org/show_bug.cgi?id=175262

No new tests: debug logs are not tested.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-08

  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const):

10:14 AM Changeset in webkit [220410] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Fix baseline for http/tests/security/set-domain-remove-subdomain-for-ip-address.html.

Unreviewed test gardening.

  • http/tests/security/set-domain-remove-subdomain-for-ip-address-expected.txt:
10:00 AM Changeset in webkit [220409] by Matt Lewis
  • 1 edit
    1 move in trunk/LayoutTests

Fixed rebaselined expectations for js/dom/global-constructors-attributes.html.
https://bugs.webkit.org/show_bug.cgi?id=175201

Unreviewed test gardening.

  • platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt: Renamed from LayoutTests/platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-dedicated-worker-expected.txt.
9:49 AM Changeset in webkit [220408] by Adrian Perez de Castro
  • 4 edits
    1 move in trunk/Source/WebKit

[WPE] Implement WebsiteDataStore::defaultApplicationCacheDirectory() and friends
https://bugs.webkit.org/show_bug.cgi?id=175322

Reviewed by Carlos Garcia Campos.

This makes WPE use the same implementation as the GTK+ port, with a preprocessor switch to choose the name of
the base directory inside the user XDG cache directory.

  • PlatformGTK.cmake: Add APIWebsiteDataStoreGLib.cpp to the build sources and remove APIWebsiteDataStoreGtk.cpp.
  • PlatformWPE.cmake: Add APIWebsiteDataStoreGLib.cpp to the built sources.
  • UIProcess/API/APIWebsiteDataStore.cpp: Remove now dead code.
  • UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp: Renamed from Source/WebKit/UIProcess/API/gtk/APIWebsiteDataStoreGtk.cpp.

(API::WebsiteDataStore::defaultApplicationCacheDirectory):
(API::WebsiteDataStore::defaultIndexedDBDatabaseDirectory):
(API::WebsiteDataStore::defaultLocalStorageDirectory):
(API::WebsiteDataStore::defaultMediaKeysStorageDirectory):
(API::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(API::WebsiteDataStore::defaultResourceLoadStatisticsDirectory):

9:41 AM Changeset in webkit [220407] by Michael Catanzaro
  • 2 edits in trunk/Tools

Add Alicia Boya García as contributor
https://bugs.webkit.org/show_bug.cgi?id=175326

Patch by Alicia Boya García <aboya@igalia.com> on 2017-08-08
Reviewed by Michael Catanzaro.

  • Scripts/webkitpy/common/config/contributors.json:
9:24 AM Changeset in webkit [220406] by Brent Fulgham
  • 5 edits in trunk/LayoutTests

Unreviewed test results fix after r220376.

Rebaseline for new SecurityException message text.

  • fast/dom/Document/invalid-domain-change-throws-exception-expected.txt:
  • http/tests/dom/document-attributes-null-handling-expected.txt:
  • http/tests/security/set-domain-remove-subdomain-for-ip-address-expected.txt:
  • http/tests/security/xss-DENIED-invalid-domain-change-expected.txt:
9:13 AM Changeset in webkit [220405] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r220376.

Don't attempt to use isPublicSuffix when building without that
feature enabled.

  • dom/Document.cpp:

(WebCore::Document::domainIsRegisterable const):

9:00 AM Changeset in webkit [220404] by Ryan Haddad
  • 14 edits in trunk/Source

Unreviewed, rolling out r220368.

This change caused WK1 tests to exit early with crashes.

Reverted changeset:

"Baseline JIT should do caging"
https://bugs.webkit.org/show_bug.cgi?id=175037
http://trac.webkit.org/changeset/220368

8:03 AM Changeset in webkit [220403] by Michael Catanzaro
  • 46 edits
    1 add in trunk

[CMake] Properly test if compiler supports compiler flags
https://bugs.webkit.org/show_bug.cgi?id=174490

Reviewed by Konstantin Tokarev.

.:

This turned out to be a massive pain. I didn't want to merely check options before using
them: I also wanted to organize the code to avoid setting similar flags in different places.
Right now we set a bunch of global flags in OptionsCommon.cmake, and a bunch more flags in
WEBKIT_SET_EXTRA_COMPILER_FLAGS on a per-target basis.

Setting flags per-target seems better in general, e.g. because it makes it very easy to
disable warnings for particular ThirdParty targets. But it turns out that all the flags set
on a per-target basis get passed to both the C compiler and the C++ compiler, so it's
impossible to pass C++-only flags there. That's terrible. It's possible to make the flags
language-conditional using generator expressions, but that doesn't work for the Visual
Studio backend, so we would have to drop support for that (not going to happen). The CMake
documentation suggests that C and C++ files ought to be built in separate targets to avoid
this. It's a mess, basically.

So I've wound up removing WEBKIT_SET_EXTRA_COMPILER_FLAGS and adding most of those flags to
CMAKE_C_FLAGS and CMAKE_CXX_FLAGS instead. Really the only disadvantage of this is we now
have to suppress individual warnings when building ANGLESupport in WebCore. That's not the
end of the world. The only remaining useful feature of WEBKIT_SET_EXTRA_COMPILER_FLAGS was
to add -fPIC to static library targets, but turns out CMake does that for us if we just set
the variable CMAKE_POSITION_INDEPENDENT_CODE, so we can get rid of it completely.

Of course there are also macros for setting target-specific compiler flags, which we
frequently need in order to suppress specific warnings, particularly warnings coming from
third-party libraries like ANGLE and gtest. But remember the footgun: these macros will test
the flag against only one compiler, but must work with both C and C++ compilers unless the
build target exclusively contains targets built with just one of those compilers. Yuck.

  • CMakeLists.txt:
  • Source/CMakeLists.txt:
  • Source/PlatformGTK.cmake:
  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/WebKitCommon.cmake:
  • Source/cmake/WebKitCompilerFlags.cmake: Added.
  • Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

  • API/tests/PingPongStackOverflowTest.cpp:

(testPingPongStackOverflow):

  • API/tests/testapi.c:
  • b3/testb3.cpp:

(JSC::B3::testPatchpointLotsOfLateAnys):

Source/ThirdParty:

  • brotli/CMakeLists.txt:
  • gtest/CMakeLists.txt:
  • woff2/CMakeLists.txt:
  • xdgmime/CMakeLists.txt:

Source/WebCore:

  • CMakeLists.txt:
  • PlatformGTK.cmake:
  • PlatformWPE.cmake:

Source/WebDriver:

  • WebDriverService.cpp:

(WebDriver::WebDriverService::run):

  • glib/SessionHostGlib.cpp:

Source/WebKit:

  • CMakeLists.txt:
  • PlatformGTK.cmake:

Source/WTF:

  • wtf/Compiler.h:

Tools:

  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
  • MiniBrowser/gtk/CMakeLists.txt:
  • TestRunnerShared/Bindings/JSWrapper.cpp:

(WTR::JSWrapper::initialize):

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

(TestWebKitAPI::CheckedArithmeticTester::run):

  • TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
  • TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
  • TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:

(formControlsAssociatedCallback):

  • TestWebKitAPI/glib/CMakeLists.txt:
  • TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::getResourcesDir):

  • WebKitTestRunner/CMakeLists.txt:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::menuItemClickCallback):
(WTR::staticConvertMenuItemToType):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setUseDashboardCompatibilityMode):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::helpText const):
(WTR::AccessibilityUIElement::attributedStringForRange):

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::releaseTouchPoint):

6:29 AM Changeset in webkit [220402] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[GStreamer] Don't use GraphicsContext3D in VideoTextureCoperGStreamer
https://bugs.webkit.org/show_bug.cgi?id=174774

Reviewed by Carlos Garcia Campos.

VideoTextureCoperGStreamer class creates a new GraphicsContext3D internally
that's used to render to whichever OpenGL context is current. Such usage
doesn't add anything to the user since there's no underlying offscreen-based
OpenGL context created, and instead all GraphicsContext3D calls are directly
translated to usual OpenGL API calls. We should avoid using GraphicsContext3D
in such cases and instead use direct OpenGL API calls.

This patch achieves that for the VideoTextureCoperGStreamer class. A
GraphicsContext3D object is still created because it's needed to construct an
instance of the TextureMapperShaderProgram class, but this will be removed as
soon as TextureMapperShaderProgram drops the GraphicsContext3D dependence.

No new tests -- no change in behavior.

  • platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:

(WebCore::VideoTextureCopierGStreamer::VideoTextureCopierGStreamer):
(WebCore::VideoTextureCopierGStreamer::~VideoTextureCopierGStreamer):
(WebCore::VideoTextureCopierGStreamer::copyVideoTextureToPlatformTexture):

  • platform/graphics/gstreamer/VideoTextureCopierGStreamer.h:

(WebCore::VideoTextureCopierGStreamer::resultTexture):

6:11 AM Changeset in webkit [220401] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

[Linux] Clear WasmMemory with madvice instead of memset
https://bugs.webkit.org/show_bug.cgi?id=175150

Reviewed by Filip Pizlo.

In Linux, zeroing pages with memset populates backing store.
Instead, we should use madvise with MADV_DONTNEED. It discards
pages. And if you access these pages, on-demand-zero-pages will
be shown.

We also commit grown pages in all OSes.

  • wasm/WasmMemory.cpp:

(JSC::Wasm::commitZeroPages):
(JSC::Wasm::Memory::create):
(JSC::Wasm::Memory::grow):

6:05 AM Changeset in webkit [220400] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[TexMap] Drop GC3D* type usage from TextureMapperPlatformLayer{Buffer,Proxy}
https://bugs.webkit.org/show_bug.cgi?id=175314

Reviewed by Carlos Garcia Campos.

Switch to using OpenGL types in the TextureMapperPlatformLayerBuffer and
TextureMapperPlatformLayerProxy classes, instead of the equivalent GC3D*
types provided in the GraphicsTypes3D.h header.

No new tests -- no change in behavior.

  • platform/graphics/texmap/TextureMapperPlatformLayerBuffer.cpp:

(WebCore::TextureMapperPlatformLayerBuffer::TextureMapperPlatformLayerBuffer):
(WebCore::TextureMapperPlatformLayerBuffer::canReuseWithoutReset):

  • platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:
  • platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

(WebCore::TextureMapperPlatformLayerProxy::getAvailableBuffer):

  • platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:
6:04 AM Changeset in webkit [220399] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[TexMap] Don't use GraphicsContext3D in ClipStack
https://bugs.webkit.org/show_bug.cgi?id=174776

Reviewed by Carlos Garcia Campos.

Any GraphicsContext3D object that's passed to ClipStack methods is of the
render-to-current-context nature, meaning there's no internally owned GL
context that has to be properly handled and all calls are simply passed to
OpenGL APIs. We should drop such (non-)usage of GraphicsContext3D in favor
of direct OpenGL API invocations.

This patch covers TextureMapper's ClipStack. Call sites to the apply() and
applyIfNeeded() are modified to not pass a reference to any
GraphicsContext3D object. Internally, OpenGL API entrypoints and constants
are used instead of GraphicsContext3D invocations.

No new tests -- no change in behavior.

  • platform/graphics/texmap/BitmapTextureGL.cpp:

(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::bindAsSurface):

  • platform/graphics/texmap/ClipStack.cpp:

(WebCore::ClipStack::apply):
(WebCore::ClipStack::applyIfNeeded):

  • platform/graphics/texmap/ClipStack.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindDefaultSurface):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):

5:22 AM Changeset in webkit [220398] by jfernandez@igalia.com
  • 3 edits
    16 adds in trunk

Not possible to remove the 'li' element inside the table cell
https://bugs.webkit.org/show_bug.cgi?id=173148

Reviewed by Ryosuke Niwa.

Source/WebCore:

We need to add a new case for breaking out empty list items when they are
at the start of an editable area. Since list items can be also inside
table cells, we need to consider this kind of elements as well.

Tests: editing/deleting/delete-list-items-in-table-cell-1.html

editing/deleting/delete-list-items-in-table-cell-2.html
editing/deleting/delete-list-items-in-table-cell-3.html
editing/deleting/delete-list-items-in-table-cell-4.html
editing/deleting/delete-list-items-in-table-cell-5.html
editing/deleting/delete-list-items-in-table-cell-6.html
editing/deleting/delete-list-items-in-table-cell-7.html
editing/deleting/delete-list-items-in-table-cell-8.html

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteKeyPressed):

LayoutTests:

Regression tests for different scenarios of list items removal.

  • editing/deleting/delete-list-items-in-table-cell-1-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-1.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-2-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-2.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-3-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-3.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-4-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-4.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-5-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-5.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-6-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-6.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-7-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-7.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-8-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-8.html: Added.
3:27 AM Changeset in webkit [220397] by zandobersek@gmail.com
  • 9 edits
    1 add in trunk/Source/WebCore

[TexMap] Isolate the TextureMapperPlatformLayerProxyProvider class
https://bugs.webkit.org/show_bug.cgi?id=175316

Reviewed by Carlos Garcia Campos.

Move the TextureMapperPlatformLayerProxyProvider class (which is the type
aliased to PlatformLayer for threaded CoordGraphics) into its own header
file. This prevents including the TextureMapperPlatformLayerProxy.h header
file in MediaPlayerPrivateGStreamerBase.h, avoiding spilling OpenGL types
and function declarations before the GStreamer GL headers include them
later in the MediaPlayerPrivateGStreamerBase implementation file.

In the MediaPlayerPrivateGStreamerBase.h header file, only the new header
is included, and a forward declaration of the TextureMapperPlatformLayerProxy
class is used. proxy() and swapBuffersIfNeeded() methods are moved into
the implementation file to avoid requiring the full definition of the
TextureMapperPlatformLayerProxy class.

Similar is done for the TextureMapperGC3DPlatformLayer class and the
Cairo-specific implementation of the ImageBufferData class. The
CoordinatedGraphicsLayer implementation file also gains an include of the
TextureMapperPlatformLayerProxyProvider.h header since it requires the full
definition of that class.

No new tests -- no change in behavior.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::proxy const):

  • platform/graphics/cairo/ImageBufferDataCairo.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::proxy const):
(WebCore::MediaPlayerPrivateGStreamerBase::swapBuffersIfNeeded):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:
  • platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
  • platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:
  • platform/graphics/texmap/TextureMapperPlatformLayerProxyProvider.h: Added.
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
3:02 AM WebKitGTK/2.16.x edited by cturner@igalia.com
(diff)
2:45 AM WebKitGTK/2.16.x edited by magomez@igalia.com
(diff)
2:03 AM Changeset in webkit [220396] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Follow-up to r220392 that fixes build on configurations
that disable USE(GSTREAMER_GL).

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
When creating the BitmapTextureGL object, also provide an initialized
TextureMapperContextAttributes object.

1:36 AM Changeset in webkit [220395] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/Source/WebCore

[TexMap] Group GL header file inclusions in a single header file
https://bugs.webkit.org/show_bug.cgi?id=175313

Reviewed by Carlos Garcia Campos.

Add a helper header file to the TextureMapper subsystem that includes
the OpenGL headers, properly addressing the build configuration to
include headers as provided by either libepoxy, the OpenGL ES library,
or the OpenGL library.

TextureMapperContextAttributes implementation file is the only one
that can leverage the header at the moment, but more will follow.

  • platform/graphics/texmap/TextureMapperContextAttributes.cpp:
  • platform/graphics/texmap/TextureMapperGLHeaders.h: Copied from Source/WebCore/platform/graphics/texmap/TextureMapperContextAttributes.cpp.
1:29 AM Changeset in webkit [220394] by Carlos Garcia Campos
  • 11 edits in trunk/Source

Web Automation: setUserInputForCurrentJavaScriptPrompt should fail if current dialog is not a prompt
https://bugs.webkit.org/show_bug.cgi?id=175261

Reviewed by Brian Burg.

Source/WebDriver:

  • CommandResult.cpp:

(WebDriver::CommandResult::CommandResult): Handle ElementNotInteractable protocol error.

Source/WebKit:

According to the spec, send alert text command should fail if the current dialog is not a prompt. This patch
adds JavaScriptDialogType enum to API::AutomationSessionClient and a new virtual method to ask the client about
the type of the current dialog. WebAutomationSession::setUserInputForCurrentJavaScriptPrompt() uses the new
client method to check the type of the current dialog and fail in case it's not a prompt. Cocoa needs an
implementation, for now it always returns Prompt as the type to keep compatibility.

18.4 Send Alert Text.
https://w3c.github.io/webdriver/webdriver-spec.html#send-alert-text

This fixes selenium test testSettingTheValueOfAnAlertThrows.

  • UIProcess/API/APIAutomationSessionClient.h:

(API::AutomationSessionClient::typeOfCurrentJavaScriptDialogOnPage):

  • UIProcess/API/glib/WebKitAutomationSession.cpp:
  • UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewGetCurrentScriptDialogType):

  • UIProcess/API/glib/WebKitWebViewPrivate.h:
  • UIProcess/Automation/Automation.json:
  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::setUserInputForCurrentJavaScriptPrompt):

  • UIProcess/Cocoa/AutomationSessionClient.h:
  • UIProcess/Cocoa/AutomationSessionClient.mm:

(WebKit::AutomationSessionClient::typeOfCurrentJavaScriptDialogOnPage):

1:10 AM Changeset in webkit [220393] by wenson_hsieh@apple.com
  • 29 edits
    4 adds in trunk

[iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
https://bugs.webkit.org/show_bug.cgi?id=175116
<rdar://problem/28279301>

Reviewed by Darin Adler and Ryosuke Niwa.

Source/WebCore:

WebCore support for WebPage::editorState refactoring. See WebKit ChangeLogs for more detail.

Tests: EditorStateTests.TypingAttributesBold

EditorStateTests.TypingAttributesItalic
EditorStateTests.TypingAttributesUnderline
EditorStateTests.TypingAttributesTextAlignmentAbsoluteAlignmentOptions
EditorStateTests.TypingAttributesTextAlignmentStartEnd
EditorStateTests.TypingAttributesTextAlignmentDirectionalText
EditorStateTests.TypingAttributesTextColor
EditorStateTests.TypingAttributesMixedStyles
EditorStateTests.TypingAttributesLinkColor

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::propertyAsColor const):
(WebCore::StyleProperties::propertyAsValueID const):

Introduces some helper functions in StyleProperties to convert CSS property values to Color or a CSSValueID.

  • css/StyleProperties.h:
  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::hasStyle):

Pull out logic in selectionStartHasStyle that asks for a style TriState into EditingStyle::hasStyle. This is
because WebPage::editorState will now query for multiple styles at the selection start, but
selectionStartHasStyle currently recomputes styleAtSelectionStart every time it is called. To prevent extra work
from being done, we can just call selectionStartHasStyle once and use ask for EditingStyle::hasStyle on the
computed EditingStyle at selection start.

  • editing/EditingStyle.h:
  • editing/Editor.cpp:

(WebCore::Editor::selectionStartHasStyle const):

Source/WebKit:

Refactors WebPage::editorState to only use the StyleProperties derived from EditingStyle, instead of inserting
and removing a temporary node to figure out the style. Also adds hooks to notify the UI delegate of EditorState
changes.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(nsTextAlignment):
(dictionaryRepresentationForEditorState):
(-[WKWebView _didChangeEditorState]):

Alerts the private UI delegate of UI-side EditorState updates.

(-[WKWebView _web_editorStateDidChange]):
(-[WKWebView _executeEditCommand:argument:completion:]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _web_editorStateDidChange]):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::selectionDidChange):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::executeEditCommand):

Change executeEditCommand(name, callback) to executeEditCommand(name, argument, callback) and lift out of iOS
platform code and into WebPage.cpp.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView executeEditCommandWithCallback:]):
(-[WKContentView _selectionChanged]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::executeEditCommand): Deleted.

Move the iOS-specific implementation of executeEditCommand that invokes a callback when the web process responds
out of WebPageProxyIOS, and into cross-platform WebPageProxy code. Additionally, add a parameter for the edit
command's argument.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const):

Use EditingStyle::styleAtSelectionStart instead of Editor::styleForSelectionStart when computing an EditorState.
Tweak bold, italic and underline to use EditingStyle TriStates.

(WebKit::shouldEnsureEditorStateUpdateAfterExecutingCommand):
(WebKit::WebPage::executeEditCommandWithCallback):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::executeEditCommandWithCallback): Deleted.

Tools:

Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
EditorStateTests run on both iOS and Mac.

  • TestWebKitAPI/EditingTestHarness.h: Added.
  • TestWebKitAPI/EditingTestHarness.mm: Added.

EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
the state of the latest observed EditorState.

(-[EditingTestHarness initWithWebView:]):
(-[EditingTestHarness dealloc]):
(-[EditingTestHarness webView]):
(-[EditingTestHarness latestEditorState]):
(-[EditingTestHarness editorStateHistory]):
(-[EditingTestHarness insertText:andExpectEditorStateWith:]):
(-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
(-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
(-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
(-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
(-[EditingTestHarness toggleBold]):
(-[EditingTestHarness toggleItalic]):
(-[EditingTestHarness toggleUnderline]):
(-[EditingTestHarness setForegroundColor:]):
(-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
(-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
(-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
(-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
(-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
(-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
(-[EditingTestHarness _execCommand:argument:expectEntries:]):

Dispatches an editing command to the web process, and blocks until a response is received. If an expected
entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
keys and values.

(-[EditingTestHarness latestEditorStateContains:]):
(-[EditingTestHarness _webView:editorStateDidChange:]):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.

(TestWebKitAPI::setUpEditorStateTestHarness):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.

LayoutTests:

Rebaseline some iOS WK2 LayoutTest expectations. These tests currently expect an empty anonymous RenderBlock to
be inserted into the render tree, but this is only a result of us adding and removing a temporary <span> when
computing a RenderStyle in WebPage::editorState -- this patch removes these empty RenderBlocks, making these
expectations' RenderTrees consistent with WebKit1.

  • platform/ios-wk2/editing/inserting/insert-div-024-expected.txt:
  • platform/ios-wk2/editing/inserting/insert-div-026-expected.txt:
  • platform/ios-wk2/editing/style/5084241-expected.txt:
  • platform/ios-wk2/editing/style/unbold-in-bold-expected.txt:
12:46 AM Changeset in webkit [220392] by zandobersek@gmail.com
  • 8 edits
    2 adds in trunk/Source/WebCore

[TexMap] Add TextureMapperContextAttributes
https://bugs.webkit.org/show_bug.cgi?id=175311

Reviewed by Carlos Garcia Campos.

Add and use TextureMapperContextAttributes, a slim struct that holds
information about the type and extensions supported by the OpenGL
context that's being used for one specific TextureMapperGL instance.

This struct is initialized in the TextureMapperGL constructor for the
OpenGL context that's been made current on that thread, and that will
be used for that TextureMapperGL instance through its lifetime. The
struct is then also copied into any BitmapTextureGL objects that have
been created through this TextureMapperGL (or its texture pool).

The struct is initialized with information about GLES2 support (which
is at this point done through the USE_OPENGL_ES_2 macro) and about
specific OpenGL extensions that are supported. These are then used in
TextureMapperGL (NPOT textures) and BitmapTextureGL (BGRA support,
sub-image unpacking) to deploy specific optimizations or workarounds.

This ultimately serves as a replacement for clunky static functions
that need to operate on GraphicsContext3D objects to retrieve this
information.

No new tests -- no change in behavior.

  • platform/TextureMapper.cmake:
  • platform/graphics/texmap/BitmapTextureGL.cpp:

(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::driverSupportsSubImage): Deleted.

  • platform/graphics/texmap/BitmapTextureGL.h:

(WebCore::BitmapTextureGL::create):

  • platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::BitmapTexturePool):
(WebCore::BitmapTexturePool::createTexture):

  • platform/graphics/texmap/BitmapTexturePool.h:
  • platform/graphics/texmap/TextureMapperContextAttributes.cpp: Added.

(WebCore::TextureMapperContextAttributes::initialize):

  • platform/graphics/texmap/TextureMapperContextAttributes.h: Added.
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::TextureMapperGL::createTexture):
(WebCore::driverSupportsNPOTTextures): Deleted.

  • platform/graphics/texmap/TextureMapperGL.h:
12:44 AM Changeset in webkit [220391] by zandobersek@gmail.com
  • 6 edits in trunk/Source

[TexMap] Don't expose GraphicsContext3D object
https://bugs.webkit.org/show_bug.cgi?id=175310

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Remove the GraphicsContext3D getter from the TextureMapperGL class. Instead,
the clearColor() method is added that's to be used by the CoordinatedGraphicsScene
class which was accessing the GraphicsContext3D object for this purpose.

  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::clearColor):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::TextureMapperGL::graphicsContext3D const): Deleted.

Source/WebKit:

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext):
Stop using GraphicsContext3D directly and instead use the
TextureMapper::clearColor() method to achieve the same result.

12:29 AM Changeset in webkit [220390] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220248. rdar://problem/33754458

12:29 AM Changeset in webkit [220389] by jmarcell@apple.com
  • 4 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220247. rdar://problem/33754443

Aug 7, 2017:

11:43 PM Changeset in webkit [220388] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebDriver

WebDriver: implement unhandled prompt behavior
https://bugs.webkit.org/show_bug.cgi?id=175184

Reviewed by Brian Burg.

Handle user prompts before running some of the commands according to the specification.

  • Capabilities.h: Add UnhandledPromptBehavior capability.
  • CommandResult.cpp:

(WebDriver::CommandResult::httpStatusCode const): Add UnexpectedAlertOpen error.
(WebDriver::CommandResult::errorString const): Ditto.

  • CommandResult.h:

(WebDriver::CommandResult::setAdditonalErrorData): New method to set an additional data object that will be sent
as part of the result error message.
(WebDriver::CommandResult::additionalErrorData const): Return the additional data object.

  • Session.cpp:

(WebDriver::Session::handleUserPrompts): Check if there's an active JavaScript dialog and deal with it depeding
on the unhandled prompt behavior.
(WebDriver::Session::reportUnexpectedAlertOpen): Generate an error message with UnexpectedAlertOpen error and
including the alert text as additional error data.
(WebDriver::Session::go): Handle user prompts before running the command.
(WebDriver::Session::getCurrentURL): Ditto.
(WebDriver::Session::back): Ditto.
(WebDriver::Session::forward): Ditto.
(WebDriver::Session::refresh): Ditto.
(WebDriver::Session::getTitle): Ditto.
(WebDriver::Session::closeWindow): Ditto.
(WebDriver::Session::switchToFrame): Ditto.
(WebDriver::Session::switchToParentFrame): Ditto.
(WebDriver::Session::isElementSelected): Ditto.
(WebDriver::Session::getElementText): Ditto.
(WebDriver::Session::getElementTagName): Ditto.
(WebDriver::Session::getElementRect): Ditto.
(WebDriver::Session::isElementEnabled): Ditto.
(WebDriver::Session::isElementDisplayed): Ditto.
(WebDriver::Session::getElementAttribute): Ditto.
(WebDriver::Session::elementSendKeys): Ditto.
(WebDriver::Session::elementSubmit): Ditto.
(WebDriver::Session::executeScript): Ditto.

  • Session.h:
  • WebDriverService.cpp:

(WebDriver::WebDriverService::sendResponse const): Send data object as part of the result error message if present.
(WebDriver::deserializeUnhandledPromptBehavior):
(WebDriver::WebDriverService::parseCapabilities const):
(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::newSession):

11:25 PM Changeset in webkit [220387] by Carlos Garcia Campos
  • 12 edits
    1 copy
    1 add in trunk/Source

[GTK] Implement JavaScript dialog methods of API::AutomationSessionClient
https://bugs.webkit.org/show_bug.cgi?id=175259

Reviewed by Michael Catanzaro.

Source/WebCore/platform/gtk/po:

  • POTFILES.in: Add WebKitScriptDialogGtk.cpp.

Source/WebKit:

Move the default implementation of WebKitScriptDialog from WebKitWebView platform specific files to their own
files. Implement all JavaScript dialog methods of API::AutomationSessionClient in WebKitAutomationSession. For
now it only works when the user doesn't override WebKitWebView::script-dialog signal and default implementation
is used.

  • PlatformGTK.cmake: Add new files to compilation.
  • PlatformWPE.cmake: Ditto.
  • UIProcess/API/glib/WebKitAutomationSession.cpp:

(webkitAutomationSessionCreate): Pass the WebKitWebContext to the constructor and keep a pointer to it in session.

  • UIProcess/API/glib/WebKitAutomationSessionPrivate.h:
  • UIProcess/API/glib/WebKitScriptDialogPrivate.h:
  • UIProcess/API/glib/WebKitWebContext.cpp:
  • UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewRunJavaScriptAlert): Set the currently script dialog for the scope of the function.
(webkitWebViewRunJavaScriptConfirm): Ditto.
(webkitWebViewRunJavaScriptPrompt): Ditto.
(webkitWebViewRunJavaScriptBeforeUnloadConfirm): Ditto.
(webkitWebViewIsShowingScriptDialog): Ask current dialog if there's one.
(webkitWebViewGetCurrentScriptDialogMessage): Ditto.
(webkitWebViewSetCurrentScriptDialogUserInput): Ditto.
(webkitWebViewAcceptCurrentScriptDialog): Ditto.
(webkitWebViewDismissCurrentScriptDialog): Ditto.

  • UIProcess/API/glib/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/WebKitScriptDialogGtk.cpp: Added.

(webkitWebViewCreateJavaScriptDialog): Moved from WebKitWebViewGtk.cpp.
(webkitScriptDialogRun): Run the dialog, this code is moved from WebKitWebViewGtk.cpp.
(webkitScriptDialogIsRunning): Return true if the script dialog has a native dialog running.
(webkitScriptDialogAccept): Send Ok or Close response to the native dialog depending on the dialog type.
(webkitScriptDialogDismiss): Send Close response to the native dialog.
(webkitScriptDialogSetUserInput): Set the given text on the prompt dialog entry.

  • UIProcess/API/gtk/WebKitWebViewGtk.cpp:

(webkitWebViewScriptDialog): Simply call webkitScriptDialogRun() now.

  • UIProcess/API/wpe/WebKitScriptDialogWPE.cpp: Copied from Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h.

(webkitScriptDialogRun):
(webkitScriptDialogIsRunning):
(webkitScriptDialogAccept):
(webkitScriptDialogDismiss):
(webkitScriptDialogSetUserInput):

11:22 PM Changeset in webkit [220386] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebDriver

WebDriver: implement user prompt commands
https://bugs.webkit.org/show_bug.cgi?id=174614

Reviewed by Brian Burg.

  • CommandResult.cpp:

(WebDriver::CommandResult::CommandResult): Handle NoJavaScriptDialog protocol error.
(WebDriver::CommandResult::httpStatusCode const): Add NoSuchAlert.
(WebDriver::CommandResult::errorString const): Ditto.

  • CommandResult.h:
  • Session.cpp:

(WebDriver::Session::dismissAlert):
(WebDriver::Session::acceptAlert):
(WebDriver::Session::getAlertText):
(WebDriver::Session::sendAlertText):

  • Session.h:
  • WebDriverService.cpp:

(WebDriver::WebDriverService::dismissAlert):
(WebDriver::WebDriverService::acceptAlert):
(WebDriver::WebDriverService::getAlertText):
(WebDriver::WebDriverService::sendAlertText):

  • WebDriverService.h:
10:48 PM Changeset in webkit [220385] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.1-branch/Source/WebCore

Cherry-pick r220333. rdar://problem/33601173

8:20 PM Changeset in webkit [220384] by msaboff@apple.com
  • 2 edits in trunk/PerformanceTests

Use more accurate Russian keywords for RexBench/FlightPlanner Unicode mode
https://bugs.webkit.org/show_bug.cgi?id=175298

Reviewed by Saam Barati.

With the help of Alexey Proskuryakov updated the Russian keywords.

  • RexBench/FlightPlanner/use_unicode.js:
7:52 PM Changeset in webkit [220383] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

RenderStyle:diff() was inadvertently doing deep compares of StyleRareNonInheritedData etc
https://bugs.webkit.org/show_bug.cgi?id=175304

Reviewed by Tim Horton.

r210758 changed DataRef::get() from returning a pointer to a reference. This caused all the places
in RenderStyle::diff() and related functions, where we intended to do a quick pointer comparison,
to doing deep compares via operator!=. This made the code slightly slower.

Fix by exposing ptr() on DataRef and using it wherever we wish to do pointer comparison.

  • rendering/style/DataRef.h:

(WebCore::DataRef::ptr const):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::inheritedDataShared const):
(WebCore::RenderStyle::changeAffectsVisualOverflow const):
(WebCore::RenderStyle::changeRequiresLayout const):
(WebCore::RenderStyle::changeRequiresRecompositeLayer const):
(WebCore::RenderStyle::listStyleImage const): Expand the function onto multiple lines.

7:52 PM Changeset in webkit [220382] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Add a fast path for rotate() and rotateZ() transform parsing
https://bugs.webkit.org/show_bug.cgi?id=175308

Reviewed by Zalan Bujtas.

Fast paths only existed for translate-related functions, matrix3d() and scale3d(). Add
rotate() and rotateX(), which gives a small boost to one of the MotionMark tests.

  • css/parser/CSSParserFastPaths.cpp:

(WebCore::parseSimpleAngle):
(WebCore::parseTransformAngleArgument):
(WebCore::parseSimpleTransformValue):
(WebCore::transformCanLikelyUseFastPath):

7:52 PM Changeset in webkit [220381] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Re-order the tests in RenderLayerCompositor::requiresCompositingLayer() for performance
https://bugs.webkit.org/show_bug.cgi?id=175306

Reviewed by Tim Horton.

Re-order the tests for compositing reasons so that reasons more likely to happen are higher in the list.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):

7:52 PM Changeset in webkit [220380] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Avoid a hash lookup in FilterInfo::remove()
https://bugs.webkit.org/show_bug.cgi?id=175301

Reviewed by Sam Weinig.

FilterInfo::remove() always called map().remove(&layer)), even when layer.m_hasFilterInfo
was false (and even asserted that layer.m_hasFilterInfo == map().contains(&layer)).

So we can early return if layer.m_hasFilterInfo is false.

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayer::FilterInfo::getIfExists):
(WebCore::RenderLayer::FilterInfo::remove):

7:46 PM Changeset in webkit [220379] by Simon Fraser
  • 14 edits in trunk/Source/WebCore

Make TransformOperation::type() non-virtual
https://bugs.webkit.org/show_bug.cgi?id=175297

Reviewed by Sam Weinig.

Store the OperationType in the base class so that type() and isSameType() can
be non-virtual.

Small perf win on some benchmarks.

  • platform/graphics/transforms/IdentityTransformOperation.h:
  • platform/graphics/transforms/Matrix3DTransformOperation.h:
  • platform/graphics/transforms/MatrixTransformOperation.h:
  • platform/graphics/transforms/PerspectiveTransformOperation.h:
  • platform/graphics/transforms/RotateTransformOperation.cpp:

(WebCore::RotateTransformOperation::blend):

  • platform/graphics/transforms/RotateTransformOperation.h:
  • platform/graphics/transforms/ScaleTransformOperation.cpp:

(WebCore::ScaleTransformOperation::blend):

  • platform/graphics/transforms/ScaleTransformOperation.h:
  • platform/graphics/transforms/SkewTransformOperation.cpp:

(WebCore::SkewTransformOperation::blend):

  • platform/graphics/transforms/SkewTransformOperation.h:
  • platform/graphics/transforms/TransformOperation.h:

(WebCore::TransformOperation::TransformOperation):
(WebCore::TransformOperation::type const):
(WebCore::TransformOperation::isSameType const):

  • platform/graphics/transforms/TranslateTransformOperation.cpp:

(WebCore::TranslateTransformOperation::blend):

  • platform/graphics/transforms/TranslateTransformOperation.h:
7:46 PM Changeset in webkit [220378] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Inline ~Color and Color::isExtended()
https://bugs.webkit.org/show_bug.cgi?id=175293

Reviewed by Zalan Bujtas.

The Color destructor and Color::isExtended() show up on profiles, so inline them.
Before r207265 the destructor was inlined.

Also make sure that LengthSize::operator== is inlined, which it was not (according
to profiles).

  • platform/LengthSize.h:

(WebCore::operator==):

  • platform/graphics/Color.cpp:

(WebCore::Color::~Color): Deleted.
(WebCore::Color::isExtended const): Deleted.

  • platform/graphics/Color.h:

(WebCore::Color::~Color):
(WebCore::Color::isExtended const):

7:29 PM Changeset in webkit [220377] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

GetOwnProperty of TypedArray indexed fields is wrongly configurable
https://bugs.webkit.org/show_bug.cgi?id=175307

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-07
Reviewed by Saam Barati.

JSTests:

  • stress/typedarray-getownproperty-not-configurable.js: Added.

(assert):
(foo):

Source/JavaScriptCore:

`
let a = new Uint8Array(10);
let b = Object.getOwnPropertyDescriptor(a, 0);
assert(b.configurable === false);
`
should not fail: by section 9.4.5.1 (https://tc39.github.io/ecma262/#sec-integer-indexed-exotic-objects-getownproperty-p)
that applies to integer indexed exotic objects, and section 22.2.7 (https://tc39.github.io/ecma262/#sec-properties-of-typedarray-instances)
that says that typed arrays are integer indexed exotic objects.

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlotByIndex):

7:28 PM Changeset in webkit [220376] by Brent Fulgham
  • 5 edits in trunk

Source/WebCore:
Implement the HTML5 same-origin restriction specification
https://bugs.webkit.org/show_bug.cgi?id=175226
<rdar://problem/11079948>

Reviewed by Chris Dumez.

Follow the algorithms defined in the HTML5 specification for relaxing
the same-origin restriction. We were missing a few steps related to
checking for public suffix and presence of a browsing context.

Tested by new TestWebKitAPI tests.

  • dom/Document.cpp:

(WebCore::Document::domainIsRegisterable): Added helper function.
(WebCore::Document::setDomain):

Tools:
Prevent domain from being set to a TLD
https://bugs.webkit.org/show_bug.cgi?id=175226
<rdar://problem/11079948>

Reviewed by Chris Dumez.

Extend the public suffix tests to include cases used by the
Public Domain 'Public Suffix List'.

  • TestWebKitAPI/Tests/mac/PublicSuffix.cpp:

(TestWebKitAPI::TEST):

6:05 PM Changeset in webkit [220375] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked media/modern-media-controls/fullscreen-support/fullscreen-support-press.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173946

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
5:53 PM Changeset in webkit [220374] by Matt Lewis
  • 1 edit
    3 adds in trunk/LayoutTests

Rebaselined js/dom/global-constructors-attributes.html on El Capitan.
https://bugs.webkit.org/show_bug.cgi?id=175201

Unreviewed test gardening.

  • platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Added.
5:47 PM Changeset in webkit [220373] by commit-queue@webkit.org
  • 11 edits
    10 adds
    2 deletes in trunk/PerformanceTests

Speedometer: Update to modern production Ember version
https://bugs.webkit.org/show_bug.cgi?id=175278

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-07
Reviewed by Ryosuke Niwa.

  • Speedometer/resources/todomvc/architecture-examples/emberjs/README.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/index.html: Made title consistent.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/README.md: Documented build process.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/components/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/index.html: Made title consistent.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/instance-initializers/global.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/models/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/router.js: Update to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/routes/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/services/repo.js: Update to latest version
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/styles/app.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/components/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/bower.json: Update to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/config/environment.js: Update to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/dist/*: Added generated files per build instructions.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/package-lock.json: Pinned dependencies.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/package.json: Update to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/.jshintrc: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/module-for-acceptance.js: Updated to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/start-app.js: Updated to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/index.html: Updated to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/integration/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/unit/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/vendor/.gitkeep: Added.
5:25 PM Changeset in webkit [220372] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Tools

[XCode] webkit-patch should run sort-Xcode-project-file
https://bugs.webkit.org/show_bug.cgi?id=174036
<rdar://problem/33732709>

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-08-07
Reviewed by Simon Fraser.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
4:56 PM Changeset in webkit [220371] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Changed expectations for webrtc/video-rotation.html.
https://bugs.webkit.org/show_bug.cgi?id=175305

Unreviewed test gardening.

4:55 PM Changeset in webkit [220370] by Devin Rousso
  • 36 edits
    8 adds in trunk

Web Inspector: Preview Canvas path when viewing a recording
https://bugs.webkit.org/show_bug.cgi?id=174967

Reviewed by Brian Burg.

Source/WebCore:

Tests: fast/canvas/2d.currentPoint.html

fast/canvas/2d.getPath.modification.html
fast/canvas/2d.getPath.newobject.html
fast/canvas/2d.setPath.html

  • html/canvas/CanvasPath.idl:
  • html/canvas/CanvasPath.h:
  • html/canvas/CanvasPath.cpp:

(WebCore::CanvasPath::currentX const):
(WebCore::CanvasPath::currentY const):

  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setPath):
(WebCore::CanvasRenderingContext2D::getPath const):

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setInspectorAdditionsEnabled):
(WebCore::RuntimeEnabledFeatures::inspectorAdditionsEnabled const):
Add runtime flag for added IDL items above so that they are only usable within the inspector
process. The runtime flag is not enabled from anywhere else as of now.

  • inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildInitialState):
Send current path as part of the InitialState.
Drive-by: deduplicate more string values.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Setting.js:
  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):
(WI.RecordingContentView.supportsCanvasPathDebugging):
(WI.RecordingContentView.prototype.get navigationItems):
(WI.RecordingContentView.prototype.shown):
(WI.RecordingContentView.prototype._generateContentCanvas2D):
(WI.RecordingContentView.prototype._actionModifiesPath):
(WI.RecordingContentView.prototype._updateCanvasPath):
(WI.RecordingContentView.prototype._showPathButtonClicked):
Show each segment of the current path as an overlay when the setting is enabled.
Drive-by: fix forgotten function rename.

  • UserInterface/Views/RecordingContentView.css:

(.content-view:not(.tab).recording canvas.path):

  • UserInterface/Views/RecordingStateDetailsSidebarPanel.js:

(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D):
Show the currentX/currentY in the current state.

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.isFunctionForType):
(WI.RecordingAction.prototype.swizzle):
Use Sets for better performance.

Source/WebKit:

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetInspectorAdditionsEnabled):
(WKPreferencesGetInspectorAdditionsEnabled):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Add plumbing for new InspectorAdditions runtime flag.

  • WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::WebInspectorUI):
Enable InspectorAdditions by default in the WebInspector page.

Source/WebKitLegacy/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences inspectorAdditionsEnabled]):
(-[WebPreferences setInspectorAdditionsEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Add plumbing for new InspectorAdditions runtime flag.

Tools:

  • DumpRenderTree/TestOptions.h:
  • DumpRenderTree/TestOptions.mm:

(TestOptions::TestOptions):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):
Add plumbing for new InspectorAdditions runtime flag.

LayoutTests:

  • fast/canvas/2d.currentPoint-expected.txt: Added.
  • fast/canvas/2d.currentPoint.html: Added.
  • fast/canvas/2d.getPath.modification-expected.txt: Added.
  • fast/canvas/2d.getPath.modification.html: Added.
  • fast/canvas/2d.getPath.newobject-expected.txt: Added.
  • fast/canvas/2d.getPath.newobject.html: Added.
  • fast/canvas/2d.setPath-expected.txt: Added.
  • fast/canvas/2d.setPath.html: Added.
  • inspector/canvas/recording-2d-expected.txt:
  • inspector/canvas/recording-2d.html:

Updated for additional deduplication in InitialState.

4:33 PM Changeset in webkit [220369] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Sorted EWS Queues on Patch page
https://bugs.webkit.org/show_bug.cgi?id=173667

Patch by obinna obike <oobike@apple.com> on 2017-08-07
Reviewed by Aakash Jain.

  • QueueStatusServer/handlers/patch.py:

(Patch.get): Sorted queue_status.

  • QueueStatusServer/templates/patch.html:

Changed queue_status.items to queue_status because it's a list.

4:30 PM Changeset in webkit [220368] by fpizlo@apple.com
  • 14 edits in trunk/Source

Baseline JIT should do caging
https://bugs.webkit.org/show_bug.cgi?id=175037

Reviewed by Mark Lam.
Source/bmalloc:


This centralizes the notion of permanently enabling the primitive gigacage, which we only do in jsc
and WebProcess.

This saves the baseline JIT from emitting some code. Otherwise it would always have to emit enabled
checks on each typed array access.

  • bmalloc/Gigacage.cpp:

(Gigacage::primitiveGigacageDisabled):
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::isDisablingPrimitiveGigacageDisabled):

  • bmalloc/Gigacage.h:

(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):

Source/JavaScriptCore:


Adds a AssemblyHelpers::cage and cageConditionally. Uses it in the baseline JIT.

Also modifies FTL caging to be more defensive when caging is disabled.

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::cage):
(JSC::AssemblyHelpers::cageConditionally):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDoubleLoad):
(JSC::JIT::emitContiguousLoad):
(JSC::JIT::emitArrayStorageLoad):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

  • jsc.cpp:

(jscmain):
(primitiveGigacageDisabled): Deleted.

Source/WebKit:


Use a better API to disable disabling the primitive gigacage.

  • WebProcess/WebProcess.cpp:

(WebKit::m_webSQLiteDatabaseTracker):
(WebKit::primitiveGigacageDisabled): Deleted.

Source/WTF:

  • wtf/Gigacage.h:

(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::isDisablingPrimitiveGigacageDisabled):
(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):

4:25 PM Changeset in webkit [220367] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
https://bugs.webkit.org/show_bug.cgi?id=175286

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-08-07
Reviewed by Myles C. Maxfield.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_braces):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_braces.NS_ERROR_ENUM):
(WebKitStyleTest.test_braces):
(WebKitStyleTest.test_braces.NS_OPTIONS):

4:22 PM Changeset in webkit [220366] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Update sendBeacon() to rely on FetchBody instead of the whole FetchRequest
https://bugs.webkit.org/show_bug.cgi?id=175280

Reviewed by Youenn Fablet.

Update sendBeacon() to rely on FetchBody instead of the whole FetchRequest. FetchBody
for data extraction is really the only thing we need at the moment.
The new code also properly sets the CORS mode, which will be needed for Bug 175264.

  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

4:18 PM Changeset in webkit [220365] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

4:16 PM Changeset in webkit [220364] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

4:12 PM Changeset in webkit [220363] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.1

Tag Safari-604.1.38.0.1.

4:10 PM Changeset in webkit [220362] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.1.1

Tag Safari-604.1.38.1.1.

3:43 PM Changeset in webkit [220361] by msaboff@apple.com
  • 2 edits in trunk/PerformanceTests

REGRESSION(r220307): Perf bot failure trying to run RexBench tests
https://bugs.webkit.org/show_bug.cgi?id=175289

Reviewed by Filip Pizlo.

Add RexBench to the list of benchmarks we skip on the perf bots.

  • Skipped:
3:31 PM Changeset in webkit [220360] by Jon Davis
  • 2 edits in trunk/Websites/webkit.org

Fixed superscript rendering for blog posts
https://bugs.webkit.org/show_bug.cgi?id=175285

Reviewed by Filip Pizlo.

  • wp-content/themes/webkit/style.css:

(sup): Added.

3:26 PM Changeset in webkit [220359] by matthew_hanson@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

3:24 PM Changeset in webkit [220358] by matthew_hanson@apple.com
  • 1 copy in branches/safari-604.1.38.1-branch

New branch.

3:22 PM Changeset in webkit [220357] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604.1.38.0-branch/Source/WebKit

Cherry-pick r220273. rdar://problem/33732757

3:20 PM Changeset in webkit [220356] by matthew_hanson@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:09 PM Changeset in webkit [220355] by matthew_hanson@apple.com
  • 1 copy in branches/safari-604.1.38.0-branch

New branch.

3:01 PM Changeset in webkit [220354] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

-Wimplicit-fallthrough warning in ComputedStyleExtractor::propertyValue
https://bugs.webkit.org/show_bug.cgi?id=174469
<rdar://problem/33311638>

Reviewed by Simon Fraser.

Add a RELEASE_ASSERT_NOT_REACHED to silence this warning.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

2:53 PM Changeset in webkit [220353] by fpizlo@apple.com
  • 3 edits in trunk/Source/WTF

Unreviewed, try to fix Windows build.

  • wtf/Gigacage.cpp:
  • wtf/Gigacage.h:
2:31 PM Changeset in webkit [220352] by fpizlo@apple.com
  • 54 edits
    1 move
    1 add in trunk/Source

Primitive auxiliaries and JSValue auxiliaries should have separate gigacages
https://bugs.webkit.org/show_bug.cgi?id=174919

Reviewed by Keith Miller.
Source/bmalloc:


This introduces two kinds of Gigacage, Primitive and JSValue. This translates to two kinds of
HeapKind, PrimitiveGigacage and JSValueGigacage.

The new support functionality required turning Inline.h into BInline.h, and INLINE into BINLINE, and
NO_INLINE into BNO_INLINE.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::refillAllocatorSlowCase):
(bmalloc::Allocator::refillAllocator):
(bmalloc::Allocator::allocateLarge):
(bmalloc::Allocator::allocateLogSizeClass):

  • bmalloc/AsyncTask.h:
  • bmalloc/BInline.h: Copied from Source/bmalloc/bmalloc/Inline.h.
  • bmalloc/Cache.cpp:

(bmalloc::Cache::tryAllocateSlowCaseNullCache):
(bmalloc::Cache::allocateSlowCaseNullCache):
(bmalloc::Cache::deallocateSlowCaseNullCache):
(bmalloc::Cache::reallocateSlowCaseNullCache):

  • bmalloc/Deallocator.cpp:
  • bmalloc/Gigacage.cpp:

(Gigacage::PrimitiveDisableCallbacks::PrimitiveDisableCallbacks):
(Gigacage::ensureGigacage):
(Gigacage::disablePrimitiveGigacage):
(Gigacage::addPrimitiveDisableCallback):
(Gigacage::removePrimitiveDisableCallback):
(Gigacage::Callbacks::Callbacks): Deleted.
(Gigacage::disableGigacage): Deleted.
(Gigacage::addDisableCallback): Deleted.
(Gigacage::removeDisableCallback): Deleted.

  • bmalloc/Gigacage.h:

(Gigacage::name):
(Gigacage::basePtr):
(Gigacage::forEachKind):
(Gigacage::caged):
(Gigacage::isCaged):

  • bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):
(bmalloc::Heap::usingGigacage):
(bmalloc::Heap::gigacageBasePtr):

  • bmalloc/Heap.h:
  • bmalloc/HeapKind.h:

(bmalloc::isGigacage):
(bmalloc::gigacageKind):
(bmalloc::heapKind):

  • bmalloc/Inline.h: Removed.
  • bmalloc/Map.h:
  • bmalloc/PerProcess.h:

(bmalloc::PerProcess<T>::getFastCase):
(bmalloc::PerProcess<T>::get):
(bmalloc::PerProcess<T>::getSlowCase):

  • bmalloc/PerThread.h:

(bmalloc::PerThread<T>::getFastCase):

  • bmalloc/Vector.h:

(bmalloc::Vector<T>::push):
(bmalloc::Vector<T>::shrinkCapacity):
(bmalloc::Vector<T>::growCapacity):

Source/JavaScriptCore:


This adapts JSC to there being two gigacages.

To make matters simpler, this turns AlignedMemoryAllocators into per-VM instances rather than
singletons. I don't think we were gaining anything by making them be singletons.

This makes it easy to teach GigacageAlignedMemoryAllocator that there are multiple kinds of
gigacages. We'll have one of those allocators per cage.

From there, this change teaches everyone who previously knew about cages that there are two cages.
This means having to specify either Gigacage::Primitive or Gigacage::JSValue. In most places, this is
easy: typed arrays are Primitive and butterflies are JSValue. But there are a few places where it's
not so obvious, so this change introduces some helpers to make it easy to define what cage you want
to use in one place and refer to it abstractly. We do this in DirectArguments and GenericArguments.h

A lot of the magic of this change is due to CagedBarrierPtr, which combines AuxiliaryBarrier and
CagedPtr. This removes one layer of "get()" calls from a bunch of places.

(JSC::AccessCase::generateImpl):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileNewTypedArray):
(JSC::DFG::SpeculativeJIT::emitAllocateButterfly):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetButterfly):
(JSC::FTL::DFG::LowerDFGToB3::compileGetIndexedPropertyStorage):
(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDirectPname):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):
(JSC::FTL::DFG::LowerDFGToB3::allocatePropertyStorageWithSizeImpl):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToB3::caged):

  • heap/FastMallocAlignedMemoryAllocator.cpp:

(JSC::FastMallocAlignedMemoryAllocator::instance): Deleted.

  • heap/FastMallocAlignedMemoryAllocator.h:
  • heap/GigacageAlignedMemoryAllocator.cpp:

(JSC::GigacageAlignedMemoryAllocator::GigacageAlignedMemoryAllocator):
(JSC::GigacageAlignedMemoryAllocator::tryAllocateAlignedMemory):
(JSC::GigacageAlignedMemoryAllocator::freeAlignedMemory):
(JSC::GigacageAlignedMemoryAllocator::dump const):
(JSC::GigacageAlignedMemoryAllocator::instance): Deleted.

  • heap/GigacageAlignedMemoryAllocator.h:
  • jsc.cpp:

(primitiveGigacageDisabled):
(jscmain):
(gigacageDisabled): Deleted.

  • llint/LowLevelInterpreter64.asm:
  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::tryAllocate):
(JSC::ArrayBuffer::createAdopted):
(JSC::ArrayBuffer::createFromBytes):

  • runtime/AuxiliaryBarrier.h:
  • runtime/ButterflyInlines.h:

(JSC::Butterfly::createUninitialized):
(JSC::Butterfly::tryCreate):
(JSC::Butterfly::growArrayRight):

  • runtime/CagedBarrierPtr.h: Added.

(JSC::CagedBarrierPtr::CagedBarrierPtr):
(JSC::CagedBarrierPtr::clear):
(JSC::CagedBarrierPtr::set):
(JSC::CagedBarrierPtr::get const):
(JSC::CagedBarrierPtr::getMayBeNull const):
(JSC::CagedBarrierPtr::operator== const):
(JSC::CagedBarrierPtr::operator!= const):
(JSC::CagedBarrierPtr::operator bool const):
(JSC::CagedBarrierPtr::setWithoutBarrier):
(JSC::CagedBarrierPtr::operator* const):
(JSC::CagedBarrierPtr::operator-> const):
(JSC::CagedBarrierPtr::operator[] const):

  • runtime/DirectArguments.cpp:

(JSC::DirectArguments::overrideThings):
(JSC::DirectArguments::unmapArgument):

  • runtime/DirectArguments.h:

(JSC::DirectArguments::isMappedArgument const):

  • runtime/GenericArguments.h:
  • runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::initModifiedArgumentsDescriptor):
(JSC::GenericArguments<Type>::setModifiedArgumentDescriptor):
(JSC::GenericArguments<Type>::isModifiedArgumentDescriptor):

  • runtime/HashMapImpl.cpp:

(JSC::HashMapImpl<HashMapBucket>::visitChildren):

  • runtime/HashMapImpl.h:

(JSC::HashMapBuffer::create):
(JSC::HashMapImpl::buffer const):
(JSC::HashMapImpl::rehash):

  • runtime/JSArray.cpp:

(JSC::JSArray::tryCreateUninitializedRestricted):
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::fastSlice):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithAnyIndexingType):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):

  • runtime/JSArray.h:

(JSC::JSArray::tryCreate):

  • runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):
(JSC::JSArrayBufferView::finalize):

  • runtime/JSLock.cpp:

(JSC::JSLock::didAcquireLock):

  • runtime/JSObject.cpp:

(JSC::JSObject::heapSnapshot):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::putByIndex):
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToDouble):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::constructConvertedArrayStorageWithoutCopyingElements):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToContiguous):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToContiguous):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::setIndexQuicklyToUndecided):
(JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::putIndexedDescriptor):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
(JSC::JSObject::putDirectIndexSlowOrBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::reallocateAndShrinkButterfly):
(JSC::JSObject::allocateMoreOutOfLineStorage):
(JSC::JSObject::getEnumerableLength):

  • runtime/JSObject.h:

(JSC::JSObject::getArrayLength const):
(JSC::JSObject::getVectorLength):
(JSC::JSObject::putDirectIndex):
(JSC::JSObject::canGetIndexQuickly):
(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly const):
(JSC::JSObject::canSetIndexQuickly):
(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):
(JSC::JSObject::initializeIndexWithoutBarrier):
(JSC::JSObject::hasSparseMap):
(JSC::JSObject::inSparseIndexingMode):
(JSC::JSObject::butterfly const):
(JSC::JSObject::butterfly):
(JSC::JSObject::outOfLineStorage const):
(JSC::JSObject::outOfLineStorage):
(JSC::JSObject::ensureInt32):
(JSC::JSObject::ensureDouble):
(JSC::JSObject::ensureContiguous):
(JSC::JSObject::ensureArrayStorage):
(JSC::JSObject::arrayStorage):
(JSC::JSObject::arrayStorageOrNull):
(JSC::JSObject::ensureLength):

  • runtime/RegExpMatchesArray.h:

(JSC::tryCreateUninitializedRegExpMatchesArray):

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::primitiveGigacageDisabledCallback):
(JSC::VM::primitiveGigacageDisabled):
(JSC::VM::gigacageDisabledCallback): Deleted.
(JSC::VM::gigacageDisabled): Deleted.

  • runtime/VM.h:

(JSC::VM::gigacageAuxiliarySpace):
(JSC::VM::firePrimitiveGigacageEnabledIfNecessary):
(JSC::VM::primitiveGigacageEnabled):
(JSC::VM::fireGigacageEnabledIfNecessary): Deleted.
(JSC::VM::gigacageEnabled): Deleted.

  • wasm/WasmMemory.cpp:

(JSC::Wasm::Memory::create):
(JSC::Wasm::Memory::~Memory):
(JSC::Wasm::Memory::grow):

Source/WebCore:

No new tests because no change in behavior.

Adapting to API changes - we now specify the AlignedMemoryAllocator differently and we need to be
specific about which Gigacage we're using.

  • bindings/js/WebCoreJSClientData.cpp:

(WebCore::JSVMClientData::JSVMClientData):

  • platform/graphics/cocoa/GPUBufferMetal.mm:

(WebCore::GPUBuffer::GPUBuffer):

Source/WebKit:


The disable callback is all about the primitive gigacage.

  • WebProcess/WebProcess.cpp:

(WebKit::primitiveGigacageDisabled):
(WebKit::m_webSQLiteDatabaseTracker):
(WebKit::gigacageDisabled): Deleted.

Source/WTF:


This mirrors the changes from bmalloc/Gigacage.h.

Also it teaches CagedPtr how to reason about multiple gigacages.

  • wtf/CagedPtr.h:

(WTF::CagedPtr::get const):
(WTF::CagedPtr::operator[] const):

  • wtf/Gigacage.cpp:

(Gigacage::tryMalloc):
(Gigacage::tryAllocateVirtualPages):
(Gigacage::freeVirtualPages):
(Gigacage::tryAlignedMalloc):
(Gigacage::alignedFree):
(Gigacage::free):

  • wtf/Gigacage.h:

(Gigacage::disablePrimitiveGigacage):
(Gigacage::addPrimitiveDisableCallback):
(Gigacage::removePrimitiveDisableCallback):
(Gigacage::name):
(Gigacage::basePtr):
(Gigacage::caged):
(Gigacage::isCaged):
(Gigacage::tryAlignedMalloc):
(Gigacage::alignedFree):
(Gigacage::free):
(Gigacage::disableGigacage): Deleted.
(Gigacage::addDisableCallback): Deleted.
(Gigacage::removeDisableCallback): Deleted.

1:58 PM Changeset in webkit [220351] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebCore

[Curl] Add abstraction layer of cookie jar implementation for Curl port
https://bugs.webkit.org/show_bug.cgi?id=174943

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-08-07
Reviewed by Brent Fulgham.

  • platform/network/curl/CookieJarCurl.cpp:

(WebCore::CookieJarCurlFileSystem::setCookiesFromDOM):
(WebCore::CookieJarCurlFileSystem::cookiesForDOM):
(WebCore::CookieJarCurlFileSystem::cookieRequestHeaderFieldValue):
(WebCore::CookieJarCurlFileSystem::cookiesEnabled):
(WebCore::CookieJarCurlFileSystem::getRawCookies):
(WebCore::CookieJarCurlFileSystem::deleteCookie):
(WebCore::CookieJarCurlFileSystem::getHostnamesWithCookies):
(WebCore::CookieJarCurlFileSystem::deleteCookiesForHostnames):
(WebCore::CookieJarCurlFileSystem::deleteAllCookies):
(WebCore::CookieJarCurlFileSystem::deleteAllCookiesModifiedSince):
(WebCore::cookiesForDOM):
(WebCore::setCookiesFromDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostnames):
(WebCore::deleteAllCookies):
(WebCore::deleteAllCookiesModifiedSince):

  • platform/network/curl/CookieJarCurl.h: Added.
  • platform/network/curl/CurlContext.cpp:
  • platform/network/curl/CurlContext.h:

(WebCore::CurlContext::cookieJar):

1:30 PM Changeset in webkit [220350] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip workers/wasm-hashset-many.html and workers/wasm-hashset-many-2.html on El Capitan.
https://bugs.webkit.org/show_bug.cgi?id=175102

Unreviewed test gardening.

  • platform/mac/TestExpectations:
11:58 AM Changeset in webkit [220349] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604.1-branch/Source/WebCore

Cherry-pick r220248. rdar://problem/33754446

11:55 AM Changeset in webkit [220348] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604.1-branch/Source/WebKit

Cherry-pick r220273. rdar://problem/33732754

11:55 AM Changeset in webkit [220347] by matthew_hanson@apple.com
  • 4 edits in branches/safari-604.1-branch/Source/WebCore

Cherry-pick r220247. rdar://problem/33754440

11:42 AM Changeset in webkit [220346] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r220144.
https://bugs.webkit.org/show_bug.cgi?id=175276

"It did not actually speed things up in the way I expected"
(Requested by saamyjoon on #webkit).

Reverted changeset:

"On memory-constrained iOS devices, reduce the rate at which
the JS heap grows before a GC to try to keep more memory
available for the system"
https://bugs.webkit.org/show_bug.cgi?id=175041
http://trac.webkit.org/changeset/220144

11:25 AM Changeset in webkit [220345] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name.html as failing on iOS.
https://bugs.webkit.org/show_bug.cgi?id=175273

Unreviewed test gardening.

  • platform/ios/TestExpectations:
11:22 AM Changeset in webkit [220344] by beidson@apple.com
  • 62 edits
    4 copies in trunk

Implement most of ServiceWorkerContainer::addRegistration.
https://bugs.webkit.org/show_bug.cgi?id=175237

Reviewed by Andy Estes.

LayoutTests/imported/w3c:

  • web-platform-tests/FileAPI/historical.https-expected.txt:
  • web-platform-tests/background-fetch/interfaces-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt:
  • web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https-expected.txt:
  • web-platform-tests/streams/count-queuing-strategy.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/flow-control.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/multiple-propagation.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/transform-streams.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/cancel.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/default-reader.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/templated.serviceworker.https-expected.txt:

Source/WebCore:

No new tests (Covered by changes to existing tests).

There's still so much supporting infrastructure to add with these early patches
that I'm still moving them in baby steps for now, hence not implementing
register() all in one shot.

Things will start moving very quickly once we no longer need to add lots of new
primitives in each change.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::navigator const):

  • page/Navigator.cpp:

(WebCore::Navigator::Navigator): Make the constructor take a ScriptExecutionContext for

creation of objects where its import (e.g. ServiceWorkerContainer).

  • page/Navigator.h:
  • page/WorkerNavigator.cpp:

(WebCore::WorkerNavigator::WorkerNavigator): Ditto.

  • page/WorkerNavigator.h:
  • page/NavigatorBase.cpp:

(WebCore::NavigatorBase::NavigatorBase): Create the ServiceWorkerContainer upfront with

the passed-in ScriptExecutionContext.

(WebCore::NavigatorBase::serviceWorker):

  • page/NavigatorBase.h:

Make ServiceWorkerContainer into an ActiveDOMObject. This will eventually be necessary for
Document suspension reasons, but is also necessary because it also needs to be a
ContextDestructionObserver (which ActiveDOMObject is):

  • workers/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::ready):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::getRegistrations):
(WebCore::ServiceWorkerContainer::activeDOMObjectName const):
(WebCore::ServiceWorkerContainer::canSuspendForDocumentSuspension const):
(WebCore::rejectLater): Deleted.
(WebCore::ServiceWorkerContainer::eventTargetInterface const): Deleted.
(WebCore::ServiceWorkerContainer::scriptExecutionContext const): Deleted.

  • workers/ServiceWorkerContainer.h:
  • workers/ServiceWorkerContainer.idl:

Add updateViaCache, etc:

  • workers/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::updateViaCache const):
(WebCore::ServiceWorkerRegistration::update):
(WebCore::ServiceWorkerRegistration::unregister):

  • workers/ServiceWorkerRegistration.h:
  • workers/ServiceWorkerRegistration.idl:
  • workers/ServiceWorkerUpdateViaCache.h: Copied from Source/WebCore/workers/ServiceWorkerRegistration.idl.
  • workers/ServiceWorkerUpdateViaCache.idl: Copied from Source/WebCore/workers/ServiceWorkerRegistration.idl.
  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::navigator):
(WebCore::WorkerGlobalScope::navigator const): Deleted.

  • workers/WorkerGlobalScope.h:
  • workers/WorkerType.h: Copied from Source/WebCore/workers/ServiceWorkerRegistration.idl.
  • workers/WorkerType.idl: Copied from Source/WebCore/workers/ServiceWorkerRegistration.idl.
10:06 AM Changeset in webkit [220343] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html.

Unreviewed test gardening.

  • platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
9:44 AM Changeset in webkit [220342] by Ryan Haddad
  • 12 edits
    1 delete in trunk

Unreviewed, rolling out r220299.

This change caused LayoutTest inspector/dom-debugger/dom-
breakpoints.html to fail.

Reverted changeset:

"Web Inspector: capture async stack trace when workers/main
context posts a message"
https://bugs.webkit.org/show_bug.cgi?id=167084
http://trac.webkit.org/changeset/220299

9:42 AM Changeset in webkit [220341] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r220273. rdar://problem/33732762

9:42 AM Changeset in webkit [220340] by matthew_hanson@apple.com
  • 6 edits in branches/safari-604-branch

Cherry-pick r220185. rdar://problem/33713534

9:42 AM Changeset in webkit [220339] by matthew_hanson@apple.com
  • 4 edits
    3 adds in branches/safari-604-branch

Cherry-pick r220163. rdar://problem/33711032

9:42 AM Changeset in webkit [220338] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220153. rdar://problem/33711047

9:32 AM Changeset in webkit [220337] by Brian Burg
  • 6 edits in trunk/Source/WebCore

Cleanup: simplify WebSockets code for RuntimeEnabledFeatures
https://bugs.webkit.org/show_bug.cgi?id=175190

Reviewed by Sam Weinig.

This runtime enabled flag is not used by anything. It was added
for V8 in <https://bugs.webkit.org/show_bug.cgi?id=29896>.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::setIsAvailable): Deleted.
(WebCore::WebSocket::isAvailable): Deleted.

  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocket.idl:
  • page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::webSocketEnabled const): Deleted.

  • page/RuntimeEnabledFeatures.h:
9:29 AM Changeset in webkit [220336] by Brian Burg
  • 24 edits in trunk

Remove CANVAS_PATH compilation guard
https://bugs.webkit.org/show_bug.cgi?id=175207

Reviewed by Sam Weinig.

.:

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • html/canvas/DOMPath.h:
  • html/canvas/DOMPath.idl:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9:22 AM Changeset in webkit [220335] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] Use Visual Studio 2017 if installed.
https://bugs.webkit.org/show_bug.cgi?id=175188

Reviewed by Sam Weinig.

If installed, use VS2017 to build WebKit. If not, fall back to VS2015.

  • Scripts/webkitdirs.pm:

(visualStudioInstallDir):
(msBuildInstallDir):

8:44 AM Changeset in webkit [220334] by clopez@igalia.com
  • 4 edits in trunk/Source

[WPE][CMake] Only pass pkg-config CFLAGS from (E)GL when not using libepoxy.
https://bugs.webkit.org/show_bug.cgi?id=175125

Reviewed by Michael Catanzaro.

Source/WebCore:

No change of behavior, covered by existing tests.

  • CMakeLists.txt: Instead of negating 3 times the use of libepoxy

move the logic for (E)GL detection inside an else() block.

Source/WebKit:

  • CMakeLists.txt: When using libepoxy avoid passing the CFLAGS from (E)GL,

and instead pass the libepoxy ones.

6:14 AM Changeset in webkit [220333] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION (r219121): Airmail 3 prints header part only.
https://bugs.webkit.org/show_bug.cgi?id=175258
<rdar://problem/33601173>

Reviewed by Andreas Kling.

When a WK1 WebViw is printed via AppKit view hierarchy it won't explictly set the page width
but uses the existing width. r219121 assumes that all printing code paths set the page width.

No test, there appears to be no good way to test AppKit printing behaviors without adding complicated
new testing infrastructure.

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

If we are in printing layout and don't have page width set yet then use the current view width.
This matches the behavior prior r219121.

6:08 AM Changeset in webkit [220332] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Remove obsolete failure expectations for wpt browsers tests.
https://bugs.webkit.org/show_bug.cgi?id=175073

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-07

3:03 AM WebKitGTK/2.16.x edited by clopez@igalia.com
(diff)
2:53 AM Changeset in webkit [220331] by clopez@igalia.com
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] CFLAGS from pkg-config for (E)GL are not passed to WebKit
https://bugs.webkit.org/show_bug.cgi?id=175125

Unreviewed follow-up fix after r220326.

  • CMakeLists.txt: Move the block appending to WebKit2_LIBRARIES

below where the list itself is created.

12:03 AM Changeset in webkit [220330] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION: wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js failing on JSC Debug bots
https://bugs.webkit.org/show_bug.cgi?id=175256

Reviewed by Saam Barati.

The check in createFromBytes just needed to check that the buffer was not null before
calling isCaged.

  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBuffer::createFromBytes):

Aug 6, 2017:

11:06 PM Changeset in webkit [220329] by Carlos Garcia Campos
  • 24 edits
    3 adds in trunk

[GTK][WPE] Add API to provide browser information required by automation
https://bugs.webkit.org/show_bug.cgi?id=175130

Source/JavaScriptCore:

Reviewed by Brian Burg.

Add browserName and browserVersion to RemoteInspector::Client::Capabilities and virtual methods to the Client to
get them.

  • inspector/remote/RemoteInspector.cpp:

(Inspector::RemoteInspector::updateClientCapabilities): Update also browserName and browserVersion.

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::requestAutomationSession): Call updateClientCapabilities() after the session is
requested to ensure they are updated before StartAutomationSession reply is sent.

  • inspector/remote/glib/RemoteInspectorServer.cpp: Add browserName and browserVersion as return values of

StartAutomationSession mesasage.

Source/WebDriver:

Reviewed by Brian Burg.

  • Session.cpp:

(WebDriver::Session::createTopLevelBrowsingContext): Check if startAutomationSession and complete the command
with error in that case.

  • SessionHost.h:
  • glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::matchCapabilities): Match the capabilities that are known only after the browser has
been launched.
(WebDriver::SessionHost::startAutomationSession): Handle the StartAutomationSession response, extracting the
capabilities and calling matchCapabilities() to match them.
(WebDriver::SessionHost::setTargetList): Return early if the session was rejected before due to invalid
capabilities.

Source/WebKit:

Reviewed by Michael Catanzaro.

When a new automation session is started, the web driver receives some required capabilities from the client,
like browser name and version. The session should be rejected if those required capabilities don't match with
the actual browser that is launched. We don't know that information in WebKit, so we need to add API so that
users can provide it when a new session request is made. This patch adds boxed object WebKitApplicationInfo that
can be used to set the application name and version. This object can be set to a WebKitAutomationSession when
WebKitWebContext::automation-started signal is emitted.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • UIProcess/API/glib/WebKitApplicationInfo.cpp: Added.

(webkit_application_info_new):
(webkit_application_info_ref):
(webkit_application_info_unref):
(webkit_application_info_set_name):
(webkit_application_info_get_name):
(webkit_application_info_set_version):
(webkit_application_info_get_version):

  • UIProcess/API/glib/WebKitAutomationSession.cpp:

(webkitAutomationSessionDispose):
(webkit_automation_session_class_init):
(webkitAutomationSessionGetBrowserName):
(webkitAutomationSessionGetBrowserVersion):
(webkit_automation_session_set_application_info):
(webkit_automation_session_get_application_info):

  • UIProcess/API/glib/WebKitAutomationSessionPrivate.h:
  • UIProcess/API/glib/WebKitWebContext.cpp:
  • UIProcess/API/gtk/WebKitApplicationInfo.h: Added.
  • UIProcess/API/gtk/WebKitAutomationSession.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/gtk/webkit2.h:
  • UIProcess/API/wpe/WebKitApplicationInfo.h: Added.
  • UIProcess/API/wpe/WebKitAutomationSession.h:
  • UIProcess/API/wpe/webkit.h:

Tools:

Reviewed by Michael Catanzaro.

  • MiniBrowser/gtk/main.c:

(automationStartedCallback): Set browser information when a new automation session is started.

  • TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:

(testAutomationSessionApplicationInfo):
(beforeAll):

8:24 PM Changeset in webkit [220328] by Ryan Haddad
  • 6 edits
    1 delete in trunk/Tools

Unreviewed, rolling out r220295.

This change introduced 4 errors in webkitpy tests.

Reverted changeset:

"[XCode] webkit-patch should run sort-Xcode-project-file"
https://bugs.webkit.org/show_bug.cgi?id=174036
http://trac.webkit.org/changeset/220295

8:00 PM Changeset in webkit [220327] by Ryan Haddad
  • 2 edits in trunk/Tools

Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.

Unreviewed test gardening.

  • TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:

(TestWebKitAPI::TEST):

5:06 PM WebKitGTK/2.16.x edited by clopez@igalia.com
(diff)
4:34 PM Changeset in webkit [220326] by clopez@igalia.com
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] CFLAGS from pkg-config for (E)GL are not passed to WebKit
https://bugs.webkit.org/show_bug.cgi?id=175125

Reviewed by Michael Catanzaro.

Some platforms define cflags on the (E)GL pkg-config files that we
need to pass to the build system when including the (E)GL headers.
And we are already doing this when building WebCore (after r184954).

But now we need to do this also on WebKit (former WebKit2) because
we include (E)GL headers (and make use of them) on the UIProcess.

  • CMakeLists.txt:
4:24 PM Changeset in webkit [220325] by jcraig@apple.com
  • 3 edits in trunk/Websites/webkit.org

2017-08-06 James Craig <jcraig@apple.com>

Update prefers-reduced-motion demos to link back to blog post
https://bugs.webkit.org/show_bug.cgi?id=175251

Unreviewed, added some cross links to older demo files.

  • blog-files/prefers-reduced-motion/axi.htm:
  • blog-files/prefers-reduced-motion/prm.htm:
10:57 AM Changeset in webkit [220324] by Yusuke Suzuki
  • 4 edits
    1 add in trunk

Promise resolve and reject function should have length = 1
https://bugs.webkit.org/show_bug.cgi?id=175242

Reviewed by Saam Barati.

JSTests:

  • stress/builtin-function-length.js: Added.

(shouldBe):
(shouldThrow):
(shouldBe.JSON.stringify.Object.getOwnPropertyDescriptor):
(shouldBe.JSON.stringify.Object.getOwnPropertyNames.Array.prototype.filter.sort):

Source/JavaScriptCore:

Previously we have separate system for "length" and "name" for builtin functions.
The builtin functions do not use lazy reifying system. Instead, they have direct
properties when instantiating it. While the function created for properties (like
Array.prototype.filter) is created by JSFunction::createBuiltin(), function inside
these builtin functions are just created by JSFunction::create(). Since it does
not set any values for "length", these functions do not have "length" property.
So, the resolve and reject functions passed to Promise's executor do not have
"length" property.

This patch make builtin functions use standard lazy reifying system for "length".
So, "length" property of the builtin function just works as if the normal functions
do.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::createBuiltinFunction):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):
(JSC::JSFunction::reifyLazyPropertyIfNeeded):
(JSC::JSFunction::reifyLazyPropertyForHostOrBuiltinIfNeeded):
(JSC::JSFunction::reifyLazyLengthIfNeeded):
(JSC::JSFunction::reifyLazyBoundNameIfNeeded):
(JSC::JSFunction::reifyBoundNameIfNeeded): Deleted.

  • runtime/JSFunction.h:
6:04 AM Changeset in webkit [220323] by gskachkov@gmail.com
  • 8 edits
    1 add in trunk

[Next] Async iteration - Implement Async Generator - parser
https://bugs.webkit.org/show_bug.cgi?id=175210

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/async-await-syntax.js:

(testTopLevelAsyncAwaitSyntaxSloppyMode.testSyntax):

  • stress/async-iteration-syntax.js: Added.

(assert):
(checkSyntax):
(checkSyntaxError):
(checkSimpleAsyncGeneratorSloppyMode):
(checkSimpleAsyncGeneratorStrictMode):
(checkNestedAsyncGenerators):
(checkSimpleAsyncGeneratorSyntaxErrorInStrictMode):

  • stress/generator-class-methods-syntax.js:

Source/JavaScriptCore:

Current implementation is draft version of Async Iteration.
Link to spec https://tc39.github.io/proposal-async-iteration/

Current patch implement only parser part of the Async generator
Runtime part will be in next ptches

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionMetadata):

  • parser/Parser.cpp:

(JSC::getAsynFunctionBodyParseMode):
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseAsyncFunctionSourceElements):
(JSC::Parser<LexerType>::parseAsyncGeneratorFunctionSourceElements):
(JSC::stringArticleForFunctionMode):
(JSC::stringForFunctionMode):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseAsyncFunctionDeclaration):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parsePropertyMethod):
(JSC::Parser<LexerType>::parseAsyncFunctionExpression):

  • parser/Parser.h:

(JSC::Scope::setSourceParseMode):

  • parser/ParserModes.h:

(JSC::isFunctionParseMode):
(JSC::isAsyncFunctionParseMode):
(JSC::isAsyncArrowFunctionParseMode):
(JSC::isAsyncGeneratorFunctionParseMode):
(JSC::isAsyncFunctionOrAsyncGeneratorWrapperParseMode):
(JSC::isAsyncFunctionWrapperParseMode):
(JSC::isAsyncFunctionBodyParseMode):
(JSC::isGeneratorMethodParseMode):
(JSC::isAsyncMethodParseMode):
(JSC::isAsyncGeneratorMethodParseMode):
(JSC::isMethodParseMode):
(JSC::isGeneratorOrAsyncFunctionBodyParseMode):
(JSC::isGeneratorOrAsyncFunctionWrapperParseMode):

Aug 5, 2017:

9:43 PM Changeset in webkit [220322] by fpizlo@apple.com
  • 18 edits
    2 adds in trunk

REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
https://bugs.webkit.org/show_bug.cgi?id=175083

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This fixes the leak by making MarkedBlock::specializedSweep call destructors when the block is empty,
even if we are using the pop path.

Also, this fixes HeapCellInlines.h to no longer include MarkedBlockInlines.h. That's pretty
important, since MarkedBlockInlines.h is the GC's internal guts - we don't want to have to recompile
the world just because we changed it.

Finally, this adds a new testing SPI for waiting for all VMs to finish destructing. This makes it
easier to debug leaks.

  • bytecode/AccessCase.cpp:
  • bytecode/PolymorphicAccess.cpp:
  • heap/HeapCell.cpp:

(JSC::HeapCell::isLive):

  • heap/HeapCellInlines.h:

(JSC::HeapCell::isLive): Deleted.

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateWithoutCollecting):
(JSC::MarkedAllocator::endMarking):

  • heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::Handle::specializedSweep):

  • jit/AssemblyHelpers.cpp:
  • jit/Repatch.cpp:
  • runtime/TestRunnerUtils.h:
  • runtime/VM.cpp:

(JSC::waitForVMDestruction):
(JSC::VM::~VM):

Source/WTF:

Adds a classic ReadWriteLock class. I wrote my own because I can never remember if the pthread one is
guaranted to bias in favor of writers or not.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/Condition.h:

(WTF::ConditionBase::construct):
(WTF::Condition::Condition):

  • wtf/Lock.h:

(WTF::LockBase::construct):
(WTF::Lock::Lock):

  • wtf/ReadWriteLock.cpp: Added.

(WTF::ReadWriteLockBase::construct):
(WTF::ReadWriteLockBase::readLock):
(WTF::ReadWriteLockBase::readUnlock):
(WTF::ReadWriteLockBase::writeLock):
(WTF::ReadWriteLockBase::writeUnlock):

  • wtf/ReadWriteLock.h: Added.

(WTF::ReadWriteLockBase::ReadLock::tryLock):
(WTF::ReadWriteLockBase::ReadLock::lock):
(WTF::ReadWriteLockBase::ReadLock::unlock):
(WTF::ReadWriteLockBase::WriteLock::tryLock):
(WTF::ReadWriteLockBase::WriteLock::lock):
(WTF::ReadWriteLockBase::WriteLock::unlock):
(WTF::ReadWriteLockBase::read):
(WTF::ReadWriteLockBase::write):
(WTF::ReadWriteLock::ReadWriteLock):

Tools:

Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
to wait for VM destructions to finish before running the next test. This makes it easier to
understand leaks results from workers tests, and leads to fewer reported leaks.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(runTest):

4:48 PM Changeset in webkit [220321] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

check-webkit-style: fix path-specific rules for WebKit2 rename
https://bugs.webkit.org/show_bug.cgi?id=175182

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-08-05
Reviewed by David Kilzer.

  • Scripts/webkitpy/style/checker.py:
3:11 PM Changeset in webkit [220320] by commit-queue@webkit.org
  • 15 edits in trunk

[Fetch API] Response should keep all ResourceResponse information
https://bugs.webkit.org/show_bug.cgi?id=175099

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-05
Reviewed by Sam Weinig.

Source/WebCore:

No change of behavior, covered by existing tests.

Disabling filtering of resource response at DocumentThreadableLoader for fetch API and doing the filtering at FetchResponse level.
This requires passing the tainting parameter to FetchResponse. For that purpose, we store the tainting on the ResourceResponse itself.
This allows mimicking the concept of internal response from the fetch spec.
This might be useful for future developments related to caching the responses.

The body is now also stored in FetchResponse so a flag is added to ensure we only expose the body if allowed.

Changing storage of opaque redirect information to keep the redirection information in the response.

  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::consumeNullBody):

  • Modules/fetch/FetchBodyOwner.h:
  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
(WebCore::FetchResponse::consume):
(WebCore::FetchResponse::consumeBodyAsStream):
(WebCore::FetchResponse::createReadableStreamSource):

  • Modules/fetch/FetchResponse.h:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::responseReceived):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/DocumentThreadableLoader.h:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::setBodyDataFrom):
(WebCore::CachedResource::setResponse):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::crossThreadData const):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::filter):

  • platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::setTainting):
(WebCore::ResourceResponseBase::tainting const):
(WebCore::ResourceResponseBase::encode const):
(WebCore::ResourceResponseBase::decode):

LayoutTests:

Updating test now that we are no longer cancelling the load in case of opaque responses.

  • http/tests/inspector/network/fetch-network-data-expected.txt:
  • http/tests/inspector/network/fetch-network-data.html:
11:59 AM Changeset in webkit [220319] by commit-queue@webkit.org
  • 10 edits in trunk/LayoutTests/imported/w3c

[Cache API] Add Cache and CacheStorage IDL definitions
https://bugs.webkit.org/show_bug.cgi?id=175201
<rdar://problem/33738001>

Unreviewed.
Rebasing test expectations after http://trac.webkit.org/changeset/220310.

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-05

  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt:
7:10 AM Changeset in webkit [220318] by mark.lam@apple.com
  • 5 edits
    1 delete in trunk/Source/JavaScriptCore

Move DFG::OSRExitCompiler methods into DFG::OSRExit [step 3].
https://bugs.webkit.org/show_bug.cgi?id=175228
<rdar://problem/33735737>

Reviewed by Saam Barati.

Merge the 32-bit OSRExit::compileExit() method into the 64-bit version, and
delete OSRExit32_64.cpp.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileExit):

  • dfg/DFGOSRExit32_64.cpp: Removed.
  • jit/GPRInfo.h:

(JSC::JSValueSource::payloadGPR const):

4:14 AM Changeset in webkit [220317] by Carlos Garcia Campos
  • 9 edits in trunk/Source

WebDriver: Implement page load strategy
https://bugs.webkit.org/show_bug.cgi?id=175183

Reviewed by Brian Burg.

Source/WebDriver:

Validate and parse page load strategy when processing capabilities.

  • Capabilities.h:
  • Session.cpp:

(WebDriver::Session::pageLoadStrategyString const): Helper to get the page load strategy as a String to be
passed to Automation.
(WebDriver::Session::go): Pass page load strategy if present.
(WebDriver::Session::back): Ditto.
(WebDriver::Session::forward): Ditto.
(WebDriver::Session::refresh): Ditto.
(WebDriver::Session::waitForNavigationToComplete): Ditto.

  • Session.h:
  • WebDriverService.cpp:

(WebDriver::deserializePageLoadStrategy):
(WebDriver::WebDriverService::parseCapabilities const):
(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::newSession):

Source/WebKit:

Split pending navigation maps into normal and eager, and use one or the other depending on the received page
load strategy. We need to keep different maps for every page load strategy because every command could use a
different strategy.

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::waitForNavigationToComplete): Extract page load strategy from parameter and pass
it to waitForNavigationToCompleteOnPage() and waitForNavigationToCompleteOnFrame().
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnPage): Return early if page load strategy is
none. Otherwise at the pening callback to the normal or eager map depeding on the page load straegy.
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnFrame): Ditto.
(WebKit::respondToPendingNavigationCallbacksWithTimeout): Helper to send pening navigation callback in case of
timeout failure.
(WebKit::WebAutomationSession::loadTimerFired): Call finishPendingNavigationsWithTimeoutFailure() with all the maps.
(WebKit::WebAutomationSession::navigateBrowsingContext): Extract page load strategy from parameter and pass it
to waitForNavigationToCompleteOnPage().
(WebKit::WebAutomationSession::goBackInBrowsingContext): Ditto.
(WebKit::WebAutomationSession::goForwardInBrowsingContext): Ditto.
(WebKit::WebAutomationSession::reloadBrowsingContext): Ditto.
(WebKit::WebAutomationSession::navigationOccurredForFrame): Use the normal maps.
(WebKit::WebAutomationSession::documentLoadedForFrame): Stop timeout timer and dispatch eager pending navigations.

  • UIProcess/Automation/WebAutomationSession.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFinishDocumentLoadForFrame): Notify the automation session.

3:32 AM Changeset in webkit [220316] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebDriver

Unreviewed. Try to fix build with clang after r220315.

  • WebDriverService.cpp:

(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::mergeCapabilities const):

2:27 AM Changeset in webkit [220315] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebDriver

WebDriver: properly handle capabilities and process firstMatch too
https://bugs.webkit.org/show_bug.cgi?id=174618

Reviewed by Brian Burg.

Implement processing of capabilities following the spec. This patch adds validation, merging and matching of
capabilities.

7.2 Processing Capabilities.
https://w3c.github.io/webdriver/webdriver-spec.html#processing-capabilities

  • Capabilities.h: Make all capabilities optional and move Timeouts struct here.
  • Session.h:
  • WebDriverService.cpp:

(WebDriver::deserializeTimeouts): Helper to extract timeouts from JSON object.
(WebDriver::WebDriverService::parseCapabilities const): At this point capabilities have already been validated,
so we just need to get them without checking the value type.
(WebDriver::WebDriverService::validatedCapabilities const): Validate the given capabilities, ensuring types of
values are the expected one.
(WebDriver::WebDriverService::mergeCapabilities const): Merge the alwaysMatch and firstMatch capabilities into a
single object ensuring that the same capability is not in both.
(WebDriver::WebDriverService::matchCapabilities const): Try to match the merged capabilities againt the platform
expected capabilities.
(WebDriver::WebDriverService::processCapabilities const): Validate, merge and match the capabilities.
(WebDriver::WebDriverService::newSession): Use processCapabilities(). Also initialize the timeouts from
capabilities and add all capabilities to the command result.
(WebDriver::WebDriverService::setTimeouts): Use deserializeTimeouts().

  • WebDriverService.h:
  • glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::launchBrowser): Updated to properly access the capabilities that are now optional.
(WebDriver::SessionHost::startAutomationSession): Add FIXME.

  • gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformCapabilities): Return the Capabilities with the known required ones filled.
(WebDriver::WebDriverService::platformValidateCapability const): Validate webkitgtk:browserOptions.
(WebDriver::WebDriverService::platformMatchCapability const): This does nothing for now.
(WebDriver::WebDriverService::platformCompareBrowserVersions): Compare the given browser versions.
(WebDriver::WebDriverService::platformParseCapabilities const): Updated now that capabilites have already been
validated before.

1:11 AM Changeset in webkit [220314] by Carlos Garcia Campos
  • 17 edits in trunk/Source

WebDriver: use in-view center point for clicks instead of bounding box center point
https://bugs.webkit.org/show_bug.cgi?id=174863

Reviewed by Simon Fraser.

Source/WebCore:

Make DOMRect, and FloatPoint::narrowPrecision() available to WebKit layer. Also add
FrameView::clientToDocumentPoint().

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.h:
  • page/FrameView.h:
  • platform/graphics/FloatPoint.h:

Source/WebDriver:

The center of the element bounding box is not always part of the element, like in multiline links, for example.

11.1 Element Interactability.
https://www.w3.org/TR/webdriver/#dfn-in-view-center-point

  • CommandResult.cpp:

(WebDriver::CommandResult::httpStatusCode): Add ElementClickIntercepted and ElementNotInteractable errors.
(WebDriver::CommandResult::errorString): Ditto.

  • CommandResult.h: Ditto.
  • Session.cpp:

(WebDriver::Session::computeElementLayout): Get the in-view center point and isObscured from the result too.
(WebDriver::Session::getElementRect): Ignore in-view center point and isObscured.
(WebDriver::Session::elementClick): Fail in case the element is not interactable or is obscured.

  • Session.h:

Source/WebKit:

Change computeElementLayout to also return the in-view center point and whether it's obscured by another
element.

  • UIProcess/Automation/Automation.json: Add optional inViewCenterPoint to the result and isObscured.
  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::didComputeElementLayout): Handle inViewCenterPoint and isObscured.

  • UIProcess/Automation/WebAutomationSession.h:
  • UIProcess/Automation/WebAutomationSession.messages.in:
  • WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::elementInViewClientCenterPoint): Get the client in-view center point and whether it's obscured
according to the spec.
(WebKit::WebAutomationSessionProxy::computeElementLayout): Pass inViewCenterPoint and isObscured to
DidComputeElementLayout message.

1:08 AM Changeset in webkit [220313] by Carlos Garcia Campos
  • 3 edits
    6 adds in trunk

getClientRects doesn't work with list box option elements
https://bugs.webkit.org/show_bug.cgi?id=175016

Reviewed by Darin Adler.

Source/WebCore:

Since HTMLOptionElement and HTMLOptGroupElement don't have a renderer, we are always returning an empty list
from getClientRects. This is working fine in both chromium and firefox, option elements return its own bounding
box and group elements return the bounding box of the group label and all its children items.

Test: fast/dom/HTMLSelectElement/listbox-items-client-rects.html

  • dom/Element.cpp:

(WebCore::listBoxElementBoundingBox): Helper function to return the bounding box of a HTMLOptionElement or
HTMLOptGroupElement element.
(WebCore::Element::getClientRects): Use listBoxElementBoundingBox() in case of HTMLOptionElement or
HTMLOptGroupElement.
(WebCore::Element::boundingClientRect): Ditto.

LayoutTests:

Add new test to check list box option elements client rects.

  • fast/dom/HTMLSelectElement/listbox-items-client-rects-expected.txt: Added.
  • fast/dom/HTMLSelectElement/listbox-items-client-rects.html: Added.
  • platform/ios-simulator-wk2/fast/dom/HTMLSelectElement/listbox-items-client-rects-expected.txt: Added.
12:57 AM Changeset in webkit [220312] by Brian Burg
  • 2 edits in trunk/Source/WebKit

Web Automation: files selected for upload should be matched against 'accept' attribute values case-insensitively
https://bugs.webkit.org/show_bug.cgi?id=175191
<rdar://problem/33725790>

Reviewed by Carlos Garcia Campos.

Values of the "accept" attribute are to be compared in a case-insensitive manner, per
https://html.spec.whatwg.org/multipage/input.html#file-upload-state-(type=file)

Except for converting MIME types and extensions to lowercase, most of these changes
were lost in a rebase prior to landing the patch.

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::fileCanBeAcceptedForUpload): Fix some issues:

  • Handle a file ending in a period.
  • Handle MIME type inference failing.
  • Convert extensions and MIMEs to lower case, per specification.

(WebKit::WebAutomationSession::handleRunOpenPanel):

  • Strip the leading period from file extensions.
  • These range converters crash unless the API::Array is retained by a local variable.

Aug 4, 2017:

10:06 PM Changeset in webkit [220311] by commit-queue@webkit.org
  • 29 edits
    1 copy
    47 adds in trunk

[Cache API] Add Cache and CacheStorage IDL definitions
https://bugs.webkit.org/show_bug.cgi?id=175201

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-04
Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/common.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-keys.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/serviceworker/credentials.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/window/cache-add.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/window/cache-delete.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/window/cache-keys.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/window/cache-match.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/window/cache-matchAll.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/window/cache-storage-keys.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/window/cache-storage-match.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/window/cache-storage.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/window/sandboxed-iframes.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/worker/cache-add.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/worker/cache-delete.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/worker/cache-keys.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/worker/cache-match.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/worker/cache-matchAll.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/worker/cache-storage-keys.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/worker/cache-storage-match.https-expected.txt: Added.
  • web-platform-tests/service-workers/cache-storage/worker/cache-storage.https-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.6.2-cache-expected.txt: Added.
  • web-platform-tests/service-workers/stub-4.6.3-cache-storage-expected.txt: Added.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:

Source/WebCore:

Covered by activated tests.
Adding IDLs as per https://www.w3.org/TR/service-workers-1/#idl-index.
Implementation is guarded by a runtime flag which is off by default.
It is off for DRT but on for WTR.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/cache/Cache.cpp: Added.

(WebCore::Cache::match):
(WebCore::Cache::matchAll):
(WebCore::Cache::add):
(WebCore::Cache::addAll):
(WebCore::Cache::put):
(WebCore::Cache::remove):
(WebCore::Cache::keys):

  • Modules/cache/Cache.h: Added.

(WebCore::Cache::create):
(WebCore::Cache::Cache):

  • Modules/cache/Cache.idl: Added.
  • Modules/cache/CacheQueryOptions.h: Added.
  • Modules/cache/CacheQueryOptions.idl: Added.
  • Modules/cache/CacheStorage.cpp: Added.

(WebCore::CacheStorage::match):
(WebCore::CacheStorage::has):
(WebCore::CacheStorage::open):
(WebCore::CacheStorage::remove):
(WebCore::CacheStorage::keys):

  • Modules/cache/CacheStorage.h: Added.

(WebCore::CacheStorage::create):

  • Modules/cache/CacheStorage.idl: Added.
  • Modules/cache/DOMWindowCaches.cpp: Added.

(WebCore::DOMWindowCaches::DOMWindowCaches):
(WebCore::DOMWindowCaches::supplementName):
(WebCore::DOMWindowCaches::from):
(WebCore::DOMWindowCaches::caches):
(WebCore::DOMWindowCaches::caches const):

  • Modules/cache/DOMWindowCaches.h: Added.
  • Modules/cache/DOMWindowCaches.idl: Added.
  • Modules/cache/WorkerGlobalScopeCaches.cpp: Added.

(WebCore::WorkerGlobalScopeCaches::supplementName):
(WebCore::WorkerGlobalScopeCaches::from):
(WebCore::WorkerGlobalScopeCaches::caches):
(WebCore::WorkerGlobalScopeCaches::caches const):

  • Modules/cache/WorkerGlobalScopeCaches.h: Added.
  • Modules/cache/WorkerGlobalScopeCaches.idl: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setCacheAPIEnabled):
(WebCore::RuntimeEnabledFeatures::cacheAPIEnabled const):

Source/WebKit:

  • Shared/WebPreferencesDefinitions.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences cacheAPIEnabled]):
(-[WebPreferences setCacheAPIEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setCacheAPIEnabled):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

  • TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
  • platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
9:59 PM Changeset in webkit [220310] by beidson@apple.com
  • 40 edits
    1 copy
    1 add in trunk

Have navigator.serviceWorker() actually return a ServiceWorkerContainer object.
https://bugs.webkit.org/show_bug.cgi?id=175215

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/FileAPI/historical.https-expected.txt:
  • web-platform-tests/background-fetch/interfaces-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https-expected.txt:
  • web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https-expected.txt:
  • web-platform-tests/streams/count-queuing-strategy.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/flow-control.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/multiple-propagation.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/transform-streams.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/cancel.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/default-reader.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/templated.serviceworker.https-expected.txt:

Source/WebCore:

  • page/NavigatorBase.cpp:

(WebCore::NavigatorBase::serviceWorker): Actually create and remember an object.

  • page/NavigatorBase.h:
  • workers/ServiceWorkerContainer.cpp:

(WebCore::rejectLater): Asynchronously reject the given promise with an error message.
(WebCore::ServiceWorkerContainer::ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::refEventTarget): Ref the underlying Navigator.
(WebCore::ServiceWorkerContainer::derefEventTarget): Deref the underlying Navigator.
(WebCore::ServiceWorkerContainer::ready): rejectLater the promise.
(WebCore::ServiceWorkerContainer::addRegistration): Ditto.
(WebCore::ServiceWorkerContainer::getRegistration): Ditto.
(WebCore::ServiceWorkerContainer::getRegistrations): Ditto.

  • workers/ServiceWorkerContainer.h:

LayoutTests:

  • platform/mac-wk1/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt.
7:14 PM Changeset in webkit [220309] by Brian Burg
  • 3 edits in trunk/Source/WebKit

Expose WKPreferences SPI for toggling mock capture devices prompt
https://bugs.webkit.org/show_bug.cgi?id=175227
<rdar://problem/33734528>

Reviewed by Youenn Fablet.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _mockCaptureDevicesPromptEnabled]):
(-[WKPreferences _setMockCaptureDevicesPromptEnabled:]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
6:01 PM Changeset in webkit [220308] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix typo in testmasm.cpp: ENABLE(JSVALUE64) should be USE(JSVALUE64).
https://bugs.webkit.org/show_bug.cgi?id=175230
<rdar://problem/33735857>

Reviewed by Saam Barati.

  • assembler/testmasm.cpp:

(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):

5:20 PM Changeset in webkit [220307] by msaboff@apple.com
  • 1 edit
    39 adds in trunk/PerformanceTests

Create a new JavaScript RegExp benchmark
https://bugs.webkit.org/show_bug.cgi?id=175225

Reviewed by JF Bastien.

This is a new benchmark for Regular Expressions. It borrows regex-dna from
SunSpider, the regexp test from Octane2, the BASIC parser from ARES-6/Basic,
and adds a new flight planner benchmark that uses RegExp's for textual parsing.

There needs to be some additions and changes to some of the textual content.
This includes adding more BASIC programs to the Basic test and increasing
keyword usage in the Flight Planner to increase the 16-bit coverage.

The intent is to grow this benchmark by adding a JavaScript implementation of the
offline assembler lexer and parser as well as adding some targeted micro benchmark
tests.

  • RexBench: Added.
  • RexBench/Basic: Added.
  • RexBench/Basic/ast.js: Added.
  • RexBench/Basic/basic.js: Added.
  • RexBench/Basic/benchmark.js: Added.
  • RexBench/Basic/caseless_map.js: Added.
  • RexBench/Basic/lexer.js: Added.
  • RexBench/Basic/number.js: Added.
  • RexBench/Basic/parser.js: Added.
  • RexBench/Basic/random.js: Added.
  • RexBench/Basic/state.js: Added.
  • RexBench/Basic/stress-test.js: Added.
  • RexBench/Basic/util.js: Added.
  • RexBench/FlightPlanner: Added.
  • RexBench/FlightPlanner/airways.js: Added.
  • RexBench/FlightPlanner/benchmark.js: Added.
  • RexBench/FlightPlanner/convert-nfdc.py: Added.
  • RexBench/FlightPlanner/expectations.js: Added.
  • RexBench/FlightPlanner/flight_planner.js: Added.
  • RexBench/FlightPlanner/use_unicode.js: Added.
  • RexBench/FlightPlanner/waypoints.js: Added.
  • RexBench/Octane2: Added.
  • RexBench/Octane2/base.js: Added.
  • RexBench/Octane2/regexp.js: Added.
  • RexBench/SunSpider: Added.
  • RexBench/SunSpider/regex-dna.js: Added.
  • RexBench/about.html: Added.
  • RexBench/basic_benchmark.js: Added.
  • RexBench/cli.js: Added.
  • RexBench/driver.js: Added.
  • RexBench/flightplan_benchmark.js: Added.
  • RexBench/flightplan_unicode_benchmark.js: Added.
  • RexBench/glue.js: Added.
  • RexBench/index.html: Added.
  • RexBench/octane2_benchmark.js: Added.
  • RexBench/results.js: Added.
  • RexBench/stats.js: Added.
  • RexBench/styles.css: Added.
  • RexBench/sunspider_benchmark.js: Added.
5:04 PM Changeset in webkit [220306] by mark.lam@apple.com
  • 9 edits
    1 move
    3 deletes in trunk/Source/JavaScriptCore

Move DFG::OSRExitCompiler methods into DFG::OSRExit [step 2].
https://bugs.webkit.org/show_bug.cgi?id=175214
<rdar://problem/33733308>

Rubber-stamped by Michael Saboff.

Copy the 64-bit and common methods into DFGOSRExit.cpp, and delete the unused
DFGOSRExitCompiler files.

Also renamed DFGOSRExitCompiler32_64.cpp to DFGOSRExit32_64.cpp.

Also move debugOperationPrintSpeculationFailure() into DFGOSRExit.cpp. It's only
used by compileOSRExit(), and will be changed to not be a DFG operation function
when we use JIT probes for DFG OSR exits later in
https://bugs.webkit.org/show_bug.cgi?id=175144.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::emitRestoreArguments):
(JSC::DFG::OSRExit::compileOSRExit):
(JSC::DFG::OSRExit::compileExit):
(JSC::DFG::OSRExit::debugOperationPrintSpeculationFailure):

  • dfg/DFGOSRExit.h:
  • dfg/DFGOSRExit32_64.cpp: Copied from Source/JavaScriptCore/dfg/DFGOSRExitCompiler32_64.cpp.
  • dfg/DFGOSRExitCompiler.cpp: Removed.
  • dfg/DFGOSRExitCompiler.h: Removed.
  • dfg/DFGOSRExitCompiler32_64.cpp: Removed.
  • dfg/DFGOSRExitCompiler64.cpp: Removed.
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGThunks.cpp:
4:28 PM Changeset in webkit [220305] by Brian Burg
  • 3 edits in trunk/Source/WebKit

Fix typo in WKPreferences _iceCandidateFiltertingEnabled property
https://bugs.webkit.org/show_bug.cgi?id=175224

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _iceCandidateFilteringEnabled]):
(-[WKPreferences _iceCandidateFiltertingEnabled]): Deleted.

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
4:22 PM Changeset in webkit [220304] by Chris Dumez
  • 1 edit
    4 adds in trunk/LayoutTests

Add test coverage for sendBeacon() keepalive flag
https://bugs.webkit.org/show_bug.cgi?id=175212

Reviewed by Youenn Fablet.

  • http/wpt/beacon/keepalive-after-navigation-expected.txt: Added.
  • http/wpt/beacon/keepalive-after-navigation.html: Added.
  • http/wpt/beacon/support/sendBeacon-onunload-iframe.html: Added.
4:09 PM Changeset in webkit [220303] by Chris Dumez
  • 21 edits in trunk

[Beacon] Update sendBeacon to use the CachedResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=175192
<rdar://problem/33725923>

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline test as our Content-Type header has changed for ArrayBuffer / ArrayBufferView
payloads.

  • web-platform-tests/beacon/headers/header-content-type-expected.txt:

Source/WebCore:

Update sendBeacon to use the FetchRequest / CachedResourceLoader instead of
the PingLoader. This gets us closer to the specification which is based on
Fetch and reduces code duplication. This also fixes an issue where our
Origin header was not properly set on Beacon resquests.

In a follow-up, we will implement in CachedResourceLoader Fetch's quota for
inflight keepalive requests which is needed to fully support sendBeacon().

  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

  • Modules/beacon/NavigatorBeacon.h:
  • loader/LinkLoader.cpp:

(WebCore::createLinkPreloadResourceClient):

  • loader/PingLoader.cpp:
  • loader/PingLoader.h:
  • loader/ResourceLoadInfo.cpp:

(WebCore::toResourceType):

  • loader/SubresourceLoader.cpp:

(WebCore::logResourceLoaded):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::defaultPriorityForResourceType):
(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::contentTypeFromResourceType):
(WebCore::CachedResourceLoader::checkInsecureContent const):
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const):
(WebCore::isResourceSuitableForDirectReuse):

  • loader/cache/CachedResourceLoader.h:

Source/WebKit:

Deal with new Beacon CachedResource type.

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::maximumBufferingTime):

LayoutTests:

Rebaseline a few tests now that the Origin header is properly set of our Beacon
requests. This is a progression and matches the results from Blink.

Our Content-Type header for ArrayBuffer / ArrayBufferView payloads has also
changed. It is unclear which one is best but at least we are now consistent
with Fetch.

  • http/tests/blink/sendbeacon/beacon-cookie-expected.txt:
  • http/tests/blink/sendbeacon/beacon-cross-origin-expected.txt:
  • http/tests/blink/sendbeacon/beacon-same-origin-expected.txt:
  • http/wpt/beacon/headers/header-content-type-same-origin.html:
3:34 PM Changeset in webkit [220302] by wilander@apple.com
  • 14 edits
    2 adds in trunk

Resource Load Statistics: Report user interaction immediately, but only when needed
https://bugs.webkit.org/show_bug.cgi?id=175090
<rdar://problem/33685546>

Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/loading/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time.html

  • loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::ResourceLoadObserver):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

Now tells the UI process immediately but also records that it has
done so to avoid doing it when not needed.

(WebCore::ResourceLoadObserver::scheduleNotificationIfNeeded):

Conditional throttling gone, now always throttles.

(WebCore::ResourceLoadObserver::notifyObserver):

Renamed from ResourceLoadObserver::notificationTimerFired().

(WebCore::ResourceLoadObserver::clearState):

New function to allow the test runner to reset the web process'
statistics state now that we keep track of whether or not we've
reported user interaction to the UI process.

(WebCore::ResourceLoadObserver::setShouldThrottleObserverNotifications): Deleted.
(WebCore::ResourceLoadObserver::notificationTimerFired): Deleted.

  • loader/ResourceLoadObserver.h:

(): Deleted.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setResourceLoadStatisticsShouldThrottleObserverNotifications): Deleted.

No longer needed since user interaction is always communicated
immediately.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleClearResourceLoadStatistics):

Test infrastructure. Ends up calling
WebCore::ResourceLoadObserver::clearState().

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

Now calls WebCore::ResourceLoadObserver::clearState().

LayoutTests:

  • http/tests/loading/resourceLoadStatistics/user-interaction-in-cross-origin-sub-frame.html:

Now no longer needs to disable throttling since reports of
user interaction happen immediately (when needed).

  • http/tests/loading/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time-expected.txt: Added.
  • http/tests/loading/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time.html: Added.
  • platform/mac-wk2/TestExpectations:

user-interaction-only-reported-once-within-short-period-of-time.html marked as [ Pass ].

3:19 PM Changeset in webkit [220301] by matthew_hanson@apple.com
  • 7 edits in branches/safari-604.1-branch/Source

Versioning.

3:14 PM Changeset in webkit [220300] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-604.1.38

Tag Safari-604.1.38.

3:12 PM Changeset in webkit [220299] by Matt Baker
  • 12 edits
    1 add in trunk

Web Inspector: capture async stack trace when workers/main context posts a message
https://bugs.webkit.org/show_bug.cgi?id=167084
<rdar://problem/30033673>

Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/agents/InspectorDebuggerAgent.h:

Add PostMessage async call type.

Source/WebCore:

Add instrumentation to DOMWindow to support showing asynchronous
stack traces when the debugger pauses in a MessageEvent handler.

Test: inspector/debugger/async-stack-trace.html

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didPostMessageImpl):
(WebCore::InspectorInstrumentation::didFailPostMessageImpl):
(WebCore::InspectorInstrumentation::willDispatchPostMessageImpl):
(WebCore::InspectorInstrumentation::didDispatchPostMessageImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didPostMessage):
(WebCore::InspectorInstrumentation::didFailPostMessage):
(WebCore::InspectorInstrumentation::willDispatchPostMessage):
(WebCore::InspectorInstrumentation::didDispatchPostMessage):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::didClearAsyncStackTraceData):
(WebCore::PageDebuggerAgent::didPostMessage):
(WebCore::PageDebuggerAgent::didFailPostMessage):
(WebCore::PageDebuggerAgent::willDispatchPostMessage):
(WebCore::PageDebuggerAgent::didDispatchPostMessage):

  • inspector/PageDebuggerAgent.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

Add a test to check for asynchronous stack trace data when the debugger
pauses inside a MessageEvent handler.

  • inspector/debugger/async-stack-trace-expected.txt:
  • inspector/debugger/async-stack-trace.html:
  • inspector/debugger/resources/postMessage-echo.html: Added.
3:03 PM Changeset in webkit [220298] by mark.lam@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Move DFG::OSRExitCompiler methods into DFG::OSRExit [step 1].
https://bugs.webkit.org/show_bug.cgi?id=175208
<rdar://problem/33732402>

Reviewed by Saam Barati.

This will minimize the code diff and make it easier to review the patch for
https://bugs.webkit.org/show_bug.cgi?id=175144 later. We'll do this patch in 3
steps:

  1. Do the code changes to move methods into OSRExit.
  2. Copy the 64-bit and common methods into DFGOSRExit.cpp, and delete the unused DFGOSRExitCompiler files.
  3. Merge the 32-bit OSRExitCompiler methods into the 64-bit version, and delete DFGOSRExitCompiler32_64.cpp.

Splitting this refactoring into these 3 steps also makes it easier to review this
patch and understand what is being changed.

  • dfg/DFGOSRExit.h:
  • dfg/DFGOSRExitCompiler.cpp:

(JSC::DFG::OSRExit::emitRestoreArguments):
(JSC::DFG::OSRExit::compileOSRExit):
(JSC::DFG::OSRExitCompiler::emitRestoreArguments): Deleted.
(): Deleted.

  • dfg/DFGOSRExitCompiler.h:

(JSC::DFG::OSRExitCompiler::OSRExitCompiler): Deleted.
(): Deleted.

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExit::compileExit):
(JSC::DFG::OSRExitCompiler::compileExit): Deleted.

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExit::compileExit):
(JSC::DFG::OSRExitCompiler::compileExit): Deleted.

  • dfg/DFGThunks.cpp:

(JSC::DFG::osrExitGenerationThunkGenerator):

2:57 PM Changeset in webkit [220297] by Chris Dumez
  • 2 edits in trunk/LayoutTests

LayoutTest imported/w3c/web-platform-tests/beacon/beacon-basic-string.html is a flaky failure (harness timeout)
https://bugs.webkit.org/show_bug.cgi?id=175202

Unreviewed, mark test as flaky.

2:46 PM Changeset in webkit [220296] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Add an API test for r220286
https://bugs.webkit.org/show_bug.cgi?id=175206

Reviewed by Simon Fraser.

  • TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:

(-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
(createAnimatedResizeWebView):
(TEST):
Add a test to ensure that we don't call
_webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
animated resize.

2:45 PM Changeset in webkit [220295] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Tools

[XCode] webkit-patch should run sort-Xcode-project-file
https://bugs.webkit.org/show_bug.cgi?id=174036

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-08-04
Reviewed by Simon Fraser.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
2:39 PM Changeset in webkit [220294] by Devin Rousso
  • 27 edits
    2 copies
    6 adds in trunk

Web Inspector: add source view for WebGL shader programs
https://bugs.webkit.org/show_bug.cgi?id=138593
<rdar://problem/18936194>

Reviewed by Matt Baker.

Source/JavaScriptCore:

  • inspector/protocol/Canvas.json:
    • Add ShaderType enum that contains "vertex" and "fragment".
    • Add requestShaderSource command that will return the original source code for a given shader program and shader type.

Source/WebCore:

Test: inspector/canvas/requestShaderSource.html

  • inspector/InspectorCanvasAgent.h:
  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::requestShaderSource):

  • inspector/InspectorShaderProgram.h:
  • inspector/InspectorShaderProgram.cpp:

(WebCore::InspectorShaderProgram::shaderForType):

Source/WebInspectorUI:

Shader programs are now listed in the Resources sidebar as items within the owner Canvas
context. When selected, the shown content view has two editors, one for the Vertex shader
and one for the Fragment shader. These editors use CodeMirror's "clike" mode for GLSL syntax.

  • Localizations/en.lproj/localizedStrings.js:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
  • UserInterface/Main.html:
  • UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager):
(WI.CanvasManager.prototype.canvasRemoved):
(WI.CanvasManager.prototype.programCreated):
(WI.CanvasManager.prototype.programDeleted):
(WI.CanvasManager.prototype._mainResourceDidChange):

  • UserInterface/Models/Collection.js:
  • UserInterface/Models/Canvas.js:

(WI.Canvas.prototype.get shaderProgramCollection)

  • UserInterface/Models/ShaderProgram.js:

(WI.ShaderProgram.prototype.requestVertexShaderSource):
(WI.ShaderProgram.prototype.requestFragmentShaderSource):
(WI.ShaderProgram.prototype._requestShaderSource):

  • UserInterface/Views/CanvasTreeElement.js:

(WI.CanvasTreeElement):
(WI.CanvasTreeElement.prototype.onattach):
(WI.CanvasTreeElement.prototype.ondetach):
(WI.CanvasTreeElement.prototype.onpopulate):
(WI.CanvasTreeElement.prototype._shaderProgramAdded):
(WI.CanvasTreeElement.prototype._shaderProgramRemoved):

  • UserInterface/Views/ShaderProgramTreeElement.js: Added.

(WI.ShaderProgramTreeElement):

  • UserInterface/Views/ShaderProgramContentView.js: Added.

(WI.ShaderProgramContentView):
(WI.ShaderProgramContentView.prototype.shown):
(WI.ShaderProgramContentView.prototype.hidden):
(WI.ShaderProgramContentView.prototype.closed):
(WI.ShaderProgramContentView.prototype.get supportsSave):
(WI.ShaderProgramContentView.prototype.get saveData):
(WI.ShaderProgramContentView.prototype.get supportsSearch):
(WI.ShaderProgramContentView.prototype.get numberOfSearchResults):
(WI.ShaderProgramContentView.prototype.get hasPerformedSearch):
(WI.ShaderProgramContentView.prototype.set automaticallyRevealFirstSearchResult):
(WI.ShaderProgramContentView.prototype.performSearch):
(WI.ShaderProgramContentView.prototype.searchCleared):
(WI.ShaderProgramContentView.prototype.searchQueryWithSelection):
(WI.ShaderProgramContentView.prototype.revealPreviousSearchResult):
(WI.ShaderProgramContentView.prototype.revealNextSearchResult):
(WI.ShaderProgramContentView.prototype.revealPosition):
(WI.ShaderProgramContentView.prototype._editorFocused):
(WI.ShaderProgramContentView.prototype._numberOfSearchResultsDidChange):

  • UserInterface/Views/ShaderProgramContentView.css: Added.

(.content-view.shader-program > .text-editor.shader):
(body[dir=ltr] .content-view.shader-program > .text-editor.shader.vertex,):
(body[dir=ltr] .content-view.shader-program > .text-editor.shader.fragment,):
(body[dir=ltr] .content-view.shader-program > .text-editor.shader + .text-editor.shader):
(body[dir=rtl] .content-view.shader-program > .text-editor.shader + .text-editor.shader):
(.content-view.shader-program > .text-editor.shader > .type-title):
(.content-view.shader-program > .text-editor.shader > .CodeMirror):

  • UserInterface/Images/DocumentGL.png: Added.
  • UserInterface/Images/DocumentGL@2x.png: Added.
  • UserInterface/Views/ResourceIcons.css:

(.shader-program .icon):

  • UserInterface/Base/Main.js:
  • UserInterface/Views/ContentView.js:

(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.isViewable):

  • UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters.match):
(WI.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
(WI.ResourceSidebarPanel.prototype._treeSelectionDidChange):

  • UserInterface/Views/ResourcesTabContentView.js:

(WI.ResourcesTabContentView.prototype.canShowRepresentedObject):
Plumbing for displaying ShaderProgram content.

  • UserInterface/Views/TextEditor.js:

(WebInspector.TextEditor):
(WebInspector.TextEditor.prototype._editorFocused):

  • Scripts/update-codemirror-resources.rb:
  • UserInterface/External/CodeMirror/clike.js: Added.

Add C-like mode for highlighting GLSL.

LayoutTests:

  • inspector/canvas/requestShaderSource-expected.txt: Added.
  • inspector/canvas/requestShaderSource.html: Added.
  • inspector/canvas/resources/shaderProgram-utilities.js:

(linkProgram):
(linkProgram.typeForScript):
(linkProgram.createShaderFromScript):

  • platform/win/TestExpectations:
2:37 PM Changeset in webkit [220293] by Matt Lewis
  • 6 edits in trunk/Source

Unreviewed, rolling out r220288.

This broke multiple builds.

Reverted changeset:

"Use MPAVRoutingController instead of deprecated versions."
https://bugs.webkit.org/show_bug.cgi?id=175063
http://trac.webkit.org/changeset/220288

2:18 PM Changeset in webkit [220292] by clopez@igalia.com
  • 2 edits in trunk/Tools

REGRESSION(r219857): run-benchmark --allplans broken
https://bugs.webkit.org/show_bug.cgi?id=175186

Reviewed by Saam Barati.

r219857 forgot to update also the calls to BenchmarkRunner() that
is done when the script is run with --allplans.

To fix this (and avoid future issues like this), let's factorize
the calls to the benchhmark runner in a run_benchmark_plan()
function.

  • Scripts/webkitpy/benchmark_runner/run_benchmark.py:

(run_benchmark_plan):
(start):

1:50 PM Changeset in webkit [220291] by fpizlo@apple.com
  • 21 edits
    7 adds
    2 deletes in trunk/Source

The allocator used to allocate memory for MarkedBlocks and LargeAllocations should not be the Subspace itself
https://bugs.webkit.org/show_bug.cgi?id=175141

Reviewed by Mark Lam.
Source/JavaScriptCore:


To make it easier to have multiple gigacages and maybe even fancier methods of allocating, this
decouples the allocator used to allocate memory from the GC Subspace. This means we no longer have
to create a new Subspace subclass to allocate memory a different way. Instead, the allocator is now
determined by the AlignedMemoryAllocator object.

This also simplifies trading of blocks. Before, Subspaces had to determine if other Subspaces could
trade blocks with them using canTradeBlocksWith(). This makes it difficult for two different
Subspaces that both use the same underlying allocator to realize that they can trade blocks with
each other. Now, you just need to ask the block being stolen and the subspace doing the stealing if
they use the same AlignedMemoryAllocator.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/AlignedMemoryAllocator.cpp: Added.

(JSC::AlignedMemoryAllocator::AlignedMemoryAllocator):
(JSC::AlignedMemoryAllocator::~AlignedMemoryAllocator):

  • heap/AlignedMemoryAllocator.h: Added.
  • heap/FastMallocAlignedMemoryAllocator.cpp: Added.

(JSC::FastMallocAlignedMemoryAllocator::singleton):
(JSC::FastMallocAlignedMemoryAllocator::FastMallocAlignedMemoryAllocator):
(JSC::FastMallocAlignedMemoryAllocator::~FastMallocAlignedMemoryAllocator):
(JSC::FastMallocAlignedMemoryAllocator::tryAllocateAlignedMemory):
(JSC::FastMallocAlignedMemoryAllocator::freeAlignedMemory):
(JSC::FastMallocAlignedMemoryAllocator::dump const):

  • heap/FastMallocAlignedMemoryAllocator.h: Added.
  • heap/GigacageAlignedMemoryAllocator.cpp: Added.

(JSC::GigacageAlignedMemoryAllocator::singleton):
(JSC::GigacageAlignedMemoryAllocator::GigacageAlignedMemoryAllocator):
(JSC::GigacageAlignedMemoryAllocator::~GigacageAlignedMemoryAllocator):
(JSC::GigacageAlignedMemoryAllocator::tryAllocateAlignedMemory):
(JSC::GigacageAlignedMemoryAllocator::freeAlignedMemory):
(JSC::GigacageAlignedMemoryAllocator::dump const):

  • heap/GigacageAlignedMemoryAllocator.h: Added.
  • heap/GigacageSubspace.cpp: Removed.
  • heap/GigacageSubspace.h: Removed.
  • heap/LargeAllocation.cpp:

(JSC::LargeAllocation::tryCreate):
(JSC::LargeAllocation::destroy):

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateWithoutCollecting):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::tryCreate):
(JSC::MarkedBlock::Handle::Handle):
(JSC::MarkedBlock::Handle::~Handle):
(JSC::MarkedBlock::Handle::didAddToAllocator):
(JSC::MarkedBlock::Handle::subspace const):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::Handle::alignedMemoryAllocator const):
(JSC::MarkedBlock::Handle::subspace const): Deleted.

  • heap/Subspace.cpp:

(JSC::Subspace::Subspace):
(JSC::Subspace::findEmptyBlockToSteal):
(JSC::Subspace::canTradeBlocksWith): Deleted.
(JSC::Subspace::tryAllocateAlignedMemory): Deleted.
(JSC::Subspace::freeAlignedMemory): Deleted.

  • heap/Subspace.h:

(JSC::Subspace::name const):
(JSC::Subspace::alignedMemoryAllocator const):

  • runtime/JSDestructibleObjectSubspace.cpp:

(JSC::JSDestructibleObjectSubspace::JSDestructibleObjectSubspace):

  • runtime/JSDestructibleObjectSubspace.h:
  • runtime/JSSegmentedVariableObjectSubspace.cpp:

(JSC::JSSegmentedVariableObjectSubspace::JSSegmentedVariableObjectSubspace):

  • runtime/JSSegmentedVariableObjectSubspace.h:
  • runtime/JSStringSubspace.cpp:

(JSC::JSStringSubspace::JSStringSubspace):

  • runtime/JSStringSubspace.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
  • wasm/js/JSWebAssemblyCodeBlockSubspace.cpp:

(JSC::JSWebAssemblyCodeBlockSubspace::JSWebAssemblyCodeBlockSubspace):

  • wasm/js/JSWebAssemblyCodeBlockSubspace.h:

Source/WebCore:

No new tests because no new behavior.

Just adapting to an API change.

  • ForwardingHeaders/heap/FastMallocAlignedMemoryAllocator.h: Added.
  • bindings/js/WebCoreJSClientData.cpp:

(WebCore::JSVMClientData::JSVMClientData):

1:49 PM Changeset in webkit [220290] by Chris Dumez
  • 11 edits
    2 adds in trunk

Match newly-clarified spec on textarea defaultValue/value/child text content
https://bugs.webkit.org/show_bug.cgi?id=173878

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-sync WPT test from upstream and rebaseline to improve test coverage.

  • web-platform-tests/html/semantics/forms/the-textarea-element/value-defaultValue-textContent-expected.txt:
  • web-platform-tests/html/semantics/forms/the-textarea-element/value-defaultValue-textContent.html:

Source/WebCore:

Update HTMLTextArea.defaultValue to match align with other browsers and match the
latest HTML specification:

The defaultValue getter should return the child text content:

Our code was traversing all Text descendants, not just the children.

The defaultValue setter should act as the setter of the Element's textContent
IDL attribute. Previously, we had a custom logic that was only removing the
text children.

Test: imported/w3c/web-platform-tests/html/semantics/forms/the-textarea-element/value-defaultValue-textContent.html

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::scriptContent const):

  • dom/TextNodeTraversal.cpp:

(WebCore::TextNodeTraversal::childTextContent):

  • dom/TextNodeTraversal.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::defaultValue const):
(WebCore::HTMLTextAreaElement::setDefaultValue):

  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::text const):

1:42 PM Changeset in webkit [220289] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

RenderImageResourceStyleImage::image() should return the nullImage() if the image is not available
https://bugs.webkit.org/show_bug.cgi?id=174874
<rdar://problem/33530130>

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-04
Reviewed by Simon Fraser.

Source/WebCore:

If an <img> element has a non-CachedImage content data, e.g. -webkit-named-image,
RenderImageResourceStyleImage will be created and attached to the RenderImage.
RenderImageResourceStyleImage::m_cachedImage will be set to null at the
beginning because the m_styleImage->isCachedImage() is false in this case.
When ImageLoader finishes loading the url of the src attribute,
RenderImageResource::setCachedImage() will be called to set m_cachedImage.

A crash will happen when the RenderImage is destroyed. Destroying the
RenderImage calls RenderImageResourceStyleImage::shutdown() which checks
m_cachedImage and finds it not null, so it calls RenderImageResourceStyleImage::image()
which ends up calling CSSNamedImageValue::image() which returns a null pointer
because the size is empty. RenderImageResourceStyleImage::shutdown() calls
image()->stopAnimation() without checking the return value of image().

Another crash will happen later when deleting the CachedImage from the memory
cache if CachedImage::canDestroyDecodedData() is called because the client
it gets from m_clients is a freed pointer. This happens because RenderImageResourceStyleImage
has m_styleImage of type StyleGeneratedImage but its m_cachedImage is set
by RenderImageResource::setCachedImage(). When RenderImageResourceStyleImage::shutdown()
is called, it calls StyleGeneratedImage::removeClient() which does not
know anything about RenderImageResourceStyleImage::m_cachedImage. So we
end up having a freed pointer in the m_clients of the CachedImage.

Test: fast/images/image-element-image-content-data.html

  • rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::shutdown): Revert back the changes
of r208511 in this function. Add a call to image()->stopAnimation() without
checking the return of image() since it will return the nullImage() if
the image not available. There is no need to check m_cachedImage before
calling image() because image() does not check or access m_cachedImage.

If m_styleImage is not a CachedStyleImage but m_cachedImage is not null,
we need to remove m_renderer from the set of the clients of this m_cachedImage.

(WebCore::RenderImageResourceStyleImage::image const): The base class method
RenderImageResource::image() returns the nullImage() if the image not
available. This is because CachedImage::imageForRenderer() returns
the nullImage() if the image is not available; see CachedImage.h. We should
do the same for the derived class for consistency.

LayoutTests:

  • fast/images/image-element-image-content-data-expected.txt: Added.
  • fast/images/image-element-image-content-data.html: Added.
1:07 PM Changeset in webkit [220288] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Use MPAVRoutingController instead of deprecated versions.
https://bugs.webkit.org/show_bug.cgi?id=175063
Source/WebCore:

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-04
Reviewed by Tim Horton.

No new tests because no behavior change. This uses a different platform class to present
an interface.

Remove deprecated MPAudioVideoRoutingPopoverController and MPAVRoutingSheet
Add MPMediaControlsViewController.

  • platform/spi/ios/MediaPlayerSPI.h:

Source/WebKit:

rdar://problem/33301230

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-04
Reviewed by Tim Horton.

Remove dependence on deprecated classes MPAVRoutingSheet and MPAudioVideoRoutingPopoverController.

  • UIProcess/ios/forms/WKAirPlayRoutePicker.h:
  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker dealloc]):
(-[WKAirPlayRoutePicker show:fromRect:]):
(-[WKAirPlayRoutePicker popoverControllerDidDismissPopover:]): Deleted.
(-[WKAirPlayRoutePicker _presentAirPlayPopoverAnimated:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker _windowWillRotate:]): Deleted.
(-[WKAirPlayRoutePicker _windowDidRotate:]): Deleted.
(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Deleted.

1:01 PM Changeset in webkit [220287] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Dashboard bubbles sometimes show failure count instead of crash count
https://bugs.webkit.org/show_bug.cgi?id=175157
<rdar://problem/33709009>

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:

(BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.

12:50 PM Changeset in webkit [220286] by timothy_horton@apple.com
  • 12 edits in trunk/Source/WebKit

viewport-fit changes during animated resize can cause layout size to get stuck
https://bugs.webkit.org/show_bug.cgi?id=175169
<rdar://problem/33684697>

Reviewed by Simon Fraser.

If we get a commit that changes viewport-fit state while an animated
resize is underway, and that change causes the client to push a new
minimumLayoutSizeOverride, the new size will be lost forever, and we
will get stuck laying out at the wrong size.

This is because we unconditionally apply avoidsUnsafeArea for every commit,
while most other changes that come in from a commit are ignored if we're
inside animated resize. To fix, also ignore avoidsUnsafeArea changes during
animated resize, by moving the code that keeps track of it into WKWebView
like all of the rest, and read it out of the commit in didCommitLayerTree
*after* the animated-resize early-return.

Also, fix the associated layout tests by adding a missing assignment
in _computedContentInset, which was broken in r220138.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setHasCustomContentView:loadedMIMEType:]):
(-[WKWebView _processDidExit]):
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _setAvoidsUnsafeArea:]):
(-[WKWebView _safeAreaShouldAffectObscuredInsets]):
(-[WKWebView _didChangeAvoidsUnsafeArea:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::setAvoidsUnsafeArea): Deleted.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::avoidsUnsafeArea const): Deleted.

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didChangeAvoidsUnsafeArea): Deleted.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didCommitLayerTree):

12:44 PM Changeset in webkit [220285] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Rebaslining fast/text/font-selection-font-loading-api-parse.html for iOS 11.

Unreviewed test gardening.

  • platform/ios-11/fast/text/font-selection-font-loading-api-parse-expected.txt:
12:04 PM Changeset in webkit [220284] by commit-queue@webkit.org
  • 5 edits
    3 copies
    2 adds in trunk/Tools

Add tests for NeverDestroyed
https://bugs.webkit.org/show_bug.cgi?id=175146

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-08-04
Reviewed by Darin Adler.

  • CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

New files and sort.

  • TestWebKitAPI/Tests/WTF/Logger.h:
  • TestWebKitAPI/Tests/WTF/Logger.cpp:

(TestWebKitAPI::log):
(TestWebKitAPI::takeLogStr):

  • TestWebKitAPI/Tests/WTF/RefLogger.h:
  • TestWebKitAPI/Tests/WTF/RefLogger.cpp:

(TestWebKitAPI::log): Deleted.
(TestWebKitAPI::takeLogStr): Deleted.
Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.

  • TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
  • TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.

(TestWebKitAPI::LifecycleLogger::LifecycleLogger):
(TestWebKitAPI::LifecycleLogger::operator=):
(TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
(TestWebKitAPI::LifecycleLogger::setName):
(TestWebKitAPI::TEST):
Add a class that logs construction / assignment / modifications.

  • TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.

(TestWebKitAPI::TEST):
(TestWebKitAPI::list):
Test construction behavior is as expected both directly and using makeNeverDestroyed.

12:03 PM Changeset in webkit [220283] by Lucas Forschler
  • 2 edits in trunk/Tools

minification logic is not implemented for ios builds
<rdar://problem/33726561>

Reviewed by Dean Johnson

  • BuildSlaveSupport/built-product-archive:

(minifyDirectory): refactor minifySource -> minifyDirectory
(archiveBuiltProduct): add ios minification logic
(minifySource): Deleted.

12:01 PM Changeset in webkit [220282] by gskachkov@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

[ESNext] Async iteration - update feature.json
https://bugs.webkit.org/show_bug.cgi?id=175197

Reviewed by Yusuke Suzuki.

Update feature.json to add status of the Async Iteration

  • features.json:
11:57 AM Changeset in webkit [220281] by Matt Baker
  • 2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION (r220233): Check for null pointer passed to WebGLRenderingContextBase::deleteProgram
https://bugs.webkit.org/show_bug.cgi?id=175196
<rdar://problem/33727603>

Reviewed by Devin Rousso.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::deleteProgram):

11:32 AM Changeset in webkit [220280] by Jon Davis
  • 2 edits in trunk/Websites/webkit.org

Fixed loading feature status page queries and anchor link URLs
https://bugs.webkit.org/show_bug.cgi?id=175156

Reviewed by Simon Fraser.

  • wp-content/themes/webkit/status.php:
11:28 AM Changeset in webkit [220279] by Matt Lewis
  • 61 edits in trunk

Unreviewed, rolling out r220271.

Rolling out due to Layout Test failing on iOS Simulator.

Reverted changeset:

"Remove STREAMS_API compilation guard"
https://bugs.webkit.org/show_bug.cgi?id=175165
http://trac.webkit.org/changeset/220271

10:59 AM Changeset in webkit [220278] by weinig@apple.com
  • 10 edits
    2 deletes in trunk/Source

[Cleanup] Remove ScriptGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=175173

Reviewed by Darin Adler.

Source/WebCore:

ScriptGlobalObject's two functions were only being used in
four places. Three of those uses (ScriptGlobalObject::set in
InspectorFrontendClientLocal, WebInspectorUI, and RemoteWebInspectorUI)
were merged into the new function addSelfToGlobalObjectInWorld on
InspectorFrontendHost. The remaining function (ScriptGlobalObject::get
in InspectorFrontendHost) was easily inlined.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/ScriptGlobalObject.cpp: Removed.
  • bindings/js/ScriptGlobalObject.h: Removed.

Removed ScriptGlobalObject.

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::windowObjectCleared):
Remove call to ScriptGlobalObject::set and use addSelfToGlobalObjectInWorld instead.

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::showContextMenu):
Inline ScriptGlobalObject::get.

(WebCore::InspectorFrontendHost::addSelfToGlobalObjectInWorld):
Add helper which inlines ScriptGlobalObject::set and works
as a helper for the three inspector frontends.

Source/WebKit:

  • WebProcess/WebPage/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::windowObjectCleared):

  • WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::windowObjectCleared):
Remove call to ScriptGlobalObject::set and use addSelfToGlobalObjectInWorld instead.

10:10 AM Changeset in webkit [220277] by matthew_hanson@apple.com
  • 8 edits in branches/safari-604.1-branch

Revert r219896. rdar://problem/33711000

9:45 AM Changeset in webkit [220276] by Chris Dumez
  • 3 edits in trunk/LayoutTests

PROGRESSION? Multiple imported/w3c/web-platform-tests/fetch/api/ test have started to fail.
https://bugs.webkit.org/show_bug.cgi?id=175061

Unreviewed, mark Fetch/Cors tests as failing on wk2 ElCapitan only, as those tests seem to be passing
everywhere else.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
9:44 AM Changeset in webkit [220275] by Brian Burg
  • 2 edits in trunk/Source/WebKit

[Cocoa] Web Automation: copy JavaScript atoms to WebKit.framework private headers
https://bugs.webkit.org/show_bug.cgi?id=175088
<rdar://problem/33685818>

Reviewed by Joseph Pecoraro.

  • WebKit.xcodeproj/project.pbxproj:
  • Add a Copy Files phase to WebKit.framework.
  • Copy atoms to the atoms/ directory in WebKit.framework/PrivateHeaders/.
9:17 AM Changeset in webkit [220274] by Ryan Haddad
  • 14 edits
    2 deletes in trunk

Unreviewed, rolling out r220268.

This change caused assertion failures on macOS and iOS Debug
WK2.

Reverted changeset:

"Resource Load Statistics: Report user interaction
immediately, but only when needed"
https://bugs.webkit.org/show_bug.cgi?id=175090
http://trac.webkit.org/changeset/220268

9:02 AM Changeset in webkit [220273] by akling@apple.com
  • 2 edits in trunk/Source/WebKit

NetworkLoad should always invoke its redirect completion handler
https://bugs.webkit.org/show_bug.cgi?id=175179
<rdar://problem/33464999>

Reviewed by Chris Dumez.

Make sure the redirect completion handler is always invoked,
just like we already did for the response completion handler.

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::~NetworkLoad):

8:39 AM Changeset in webkit [220272] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Mark beacon-basic-string.html as slow.

8:20 AM Changeset in webkit [220271] by commit-queue@webkit.org
  • 61 edits in trunk

Remove STREAMS_API compilation guard
https://bugs.webkit.org/show_bug.cgi?id=175165

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-04
Reviewed by Darin Adler.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No change of behavior.

  • Configurations/FeatureDefines.xcconfig:
  • Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consumeAsStream):

  • Modules/fetch/FetchBody.h:
  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::isDisturbedOrLocked const):
(WebCore::FetchBodyOwner::blobLoadingSucceeded):
(WebCore::FetchBodyOwner::blobLoadingFailed):
(WebCore::FetchBodyOwner::blobChunk):

  • Modules/fetch/FetchBodyOwner.h:
  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didSucceed):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::BodyLoader::didReceiveData):

  • Modules/fetch/FetchResponse.h:
  • Modules/fetch/FetchResponse.idl:
  • Modules/fetch/FetchResponse.js:

(initializeFetchResponse):

  • Modules/fetch/FetchResponseSource.cpp:
  • Modules/fetch/FetchResponseSource.h:
  • Modules/streams/ByteLengthQueuingStrategy.idl:
  • Modules/streams/ByteLengthQueuingStrategy.js:
  • Modules/streams/CountQueuingStrategy.idl:
  • Modules/streams/CountQueuingStrategy.js:
  • Modules/streams/ReadableByteStreamController.idl:
  • Modules/streams/ReadableByteStreamController.js:
  • Modules/streams/ReadableByteStreamInternals.js:
  • Modules/streams/ReadableStream.idl:
  • Modules/streams/ReadableStream.js:
  • Modules/streams/ReadableStreamBYOBReader.idl:
  • Modules/streams/ReadableStreamBYOBReader.js:
  • Modules/streams/ReadableStreamBYOBRequest.idl:
  • Modules/streams/ReadableStreamBYOBRequest.js:
  • Modules/streams/ReadableStreamDefaultController.idl:
  • Modules/streams/ReadableStreamDefaultController.js:
  • Modules/streams/ReadableStreamDefaultReader.idl:
  • Modules/streams/ReadableStreamDefaultReader.js:
  • Modules/streams/ReadableStreamInternals.js:
  • Modules/streams/ReadableStreamSource.h:
  • Modules/streams/ReadableStreamSource.idl:
  • Modules/streams/StreamInternals.js:
  • Modules/streams/WritableStream.idl:
  • Modules/streams/WritableStream.js:
  • Modules/streams/WritableStreamInternals.js:
  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::isReadableByteStreamAPIEnabled):
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

  • bindings/js/JSReadableStreamPrivateConstructors.cpp:
  • bindings/js/JSReadableStreamPrivateConstructors.h:
  • bindings/js/JSReadableStreamSourceCustom.cpp:
  • bindings/js/ReadableStreamDefaultController.cpp:
  • bindings/js/ReadableStreamDefaultController.h:
  • page/RuntimeEnabledFeatures.h:
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
8:16 AM Changeset in webkit [220270] by beidson@apple.com
  • 39 edits
    34 copies
    10 adds in trunk

Enable ServiceWorkers at runtime for WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=175174

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/background-fetch/interfaces-expected.txt:
  • web-platform-tests/background-fetch/interfaces-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https-expected.txt:
  • web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https-expected.txt:
  • web-platform-tests/streams/count-queuing-strategy.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/flow-control.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/multiple-propagation.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/transform-streams.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/cancel.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/default-reader.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/templated.serviceworker.https-expected.txt:

Source/WebKit:

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::enableAllExperimentalFeatures):

LayoutTests:

  • fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/background-fetch/interfaces-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/background-fetch/interfaces-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/background-fetch/interfaces-worker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/background-fetch/interfaces-worker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/count-queuing-strategy.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/count-queuing-strategy.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/piping/flow-control.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/piping/flow-control.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/piping/general.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/piping/general.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/piping/multiple-propagation.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/piping/multiple-propagation.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/piping/transform-streams.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/piping/transform-streams.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/piping/general.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/cancel.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/cancel.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/default-reader.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/default-reader.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/general.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/piping/general.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt.
  • platform/mac-wk1/imported/w3c/web-platform-tests/streams/readable-streams/templated.serviceworker.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/templated.serviceworker.https-expected.txt.
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
8:04 AM Changeset in webkit [220269] by zandobersek@gmail.com
  • 41 edits in trunk

[EME][GStreamer] Register ClearKey CDMFactory
https://bugs.webkit.org/show_bug.cgi?id=175136

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Register the ClearKey CDM factory in CDMFactoryGStreamer. A CDMFactoryClearKey
singleton object is introduced and used for that registration.

The basic CDMFactoryClearKey and CDMPrivateClearKey methods are implemented,
marking org.w3.clearkey as the supported key system and keyids as the
supported init data type. Additional logic around key system configurations,
distinctive identifiers, persistent state and related restrictions and
requirements is implemented.

This improves the ClearKey EME tests a bit, now progressing to the point of
failing with a NotAllowedError exception due to the CDMInstance object failing
to properly initialize because of missing implementation.

No new tests -- relevant tests have underlying baselines updated to reflect
changes in behavior.

  • platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::CDMFactoryClearKey::singleton):
(WebCore::CDMFactoryClearKey::supportsKeySystem):
(WebCore::CDMPrivateClearKey::supportsInitDataType const):
(WebCore::CDMPrivateClearKey::supportsConfiguration const):
(WebCore::CDMPrivateClearKey::supportsConfigurationWithRestrictions const):
(WebCore::CDMPrivateClearKey::supportsSessionTypeWithConfiguration const):
(WebCore::CDMPrivateClearKey::supportsRobustness const):
(WebCore::CDMPrivateClearKey::distinctiveIdentifiersRequirement const):
(WebCore::CDMPrivateClearKey::persistentStateRequirement const):

  • platform/encryptedmedia/clearkey/CDMClearKey.h:
  • platform/graphics/gstreamer/eme/CDMFactoryGStreamer.cpp:

(WebCore::CDMFactory::platformRegisterFactories):

LayoutTests:

Update WPE baselines for EME ClearKey tests following some advancements in
ClearKey support.

  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-events-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-events-session-closed-event-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-invalid-license-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses-multiple-sessions-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-immediately-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-playback-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-at-same-time-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-to-multiple-video-elements-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeys-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysession-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysystemaccess-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-not-callable-after-createsession-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-update-non-ascii-input-expected.txt:
7:20 AM Changeset in webkit [220268] by wilander@apple.com
  • 14 edits
    2 adds in trunk

Resource Load Statistics: Report user interaction immediately, but only when needed
https://bugs.webkit.org/show_bug.cgi?id=175090
<rdar://problem/33685546>

Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/loading/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time.html

  • loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::ResourceLoadObserver):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

Now tells the UI process immediately but also records that it has
done so to avoid doing it when not needed.

(WebCore::ResourceLoadObserver::scheduleNotificationIfNeeded):

Conditional throttling gone, now always throttles.

(WebCore::ResourceLoadObserver::notifyObserver):

Renamed from ResourceLoadObserver::notificationTimerFired().

(WebCore::ResourceLoadObserver::clearState):

New function to allow the test runner to reset the web process'
statistics state now that we keep track of whether or not we've
reported user interaction to the UI process.

(WebCore::ResourceLoadObserver::setShouldThrottleObserverNotifications): Deleted.
(WebCore::ResourceLoadObserver::notificationTimerFired): Deleted.

  • loader/ResourceLoadObserver.h:

(): Deleted.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setResourceLoadStatisticsShouldThrottleObserverNotifications): Deleted.

No longer needed since user interaction is always communicated
immediately.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleClearResourceLoadStatistics):

Test infrastructure. Ends up calling
WebCore::ResourceLoadObserver::clearState().

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

Now calls WebCore::ResourceLoadObserver::clearState().

LayoutTests:

  • http/tests/loading/resourceLoadStatistics/user-interaction-in-cross-origin-sub-frame.html:

Now no longer needs to disable throttling since reports of
user interaction happen immediately (when needed).

  • http/tests/loading/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time-expected.txt: Added.
  • http/tests/loading/resourceLoadStatistics/user-interaction-only-reported-once-within-short-period-of-time.html: Added.
  • platform/mac-wk2/TestExpectations:

user-interaction-only-reported-once-within-short-period-of-time.html marked as [ Pass ].

6:25 AM Changeset in webkit [220267] by Antti Koivisto
  • 22 edits in trunk/Source/WebKit

Network cache should be usable as non-singleton
https://bugs.webkit.org/show_bug.cgi?id=175139

Reviewed by Sam Weinig.

We might want to use it as a non-singleton in the future (for example as a backend for the cache API).

This patch makes NetworkCache::Cache and NetworkCache::Storage refcounted objects and takes
care to ref them properly during asynchronous operations.

The patch doesn't actually create any non-shared instances, it just adds the capability.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::storeDerivedDataToCache):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::fetchDiskCacheEntries):
(WebKit::clearDiskCacheEntries):
(WebKit::NetworkProcess::setCacheModel):

  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::cache):

Move the shared cache instance to the network process singleton.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):

Include shared cache as a reffed member for non-ephemeral instances.

(WebKit::NetworkResourceLoader::canUseCache const):
(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::open):

Open now returns null if it fails.
Add RegisterNotify option to set up notify trigger for the shared instance.

(WebKit::NetworkCache::Cache::Cache):
(WebKit::NetworkCache::Cache::~Cache):

Add destructor.

(WebKit::NetworkCache::dumpFileChanged):
(WebKit::NetworkCache::Cache::setCapacity):
(WebKit::NetworkCache::Cache::retrieve):

Protect the cache instance during asynchronous operations.

(WebKit::NetworkCache::Cache::store):
(WebKit::NetworkCache::Cache::storeRedirect):
(WebKit::NetworkCache::Cache::remove):
(WebKit::NetworkCache::Cache::traverse):
(WebKit::NetworkCache::Cache::dumpContentsToFile):
(WebKit::NetworkCache::Cache::clear):
(WebKit::NetworkCache::Cache::recordsPath const):
(WebKit::NetworkCache::Cache::retrieveData):
(WebKit::NetworkCache::Cache::storeData):
(WebKit::NetworkCache::singleton): Deleted.
(WebKit::NetworkCache::Cache::initialize): Deleted.

  • NetworkProcess/cache/NetworkCache.h:

(WebKit::NetworkCache::Cache::canUseSharedMemoryForBodyData const):
(WebKit::NetworkCache::Cache::isEnabled const): Deleted.

Remove isEnabled() state as a cache object now always represents an enabled cache.

  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord const):

  • NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::willSendRedirectedRequest):
(WebKit::NetworkCache::SpeculativeLoad::didReceiveResponse):
(WebKit::NetworkCache::SpeculativeLoad::didFinishLoading):

  • NetworkProcess/cache/NetworkCacheStatistics.cpp:

(WebKit::NetworkCache::Statistics::initialize):
(WebKit::NetworkCache::Statistics::shrinkIfNeeded):

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::ReadOperation::ReadOperation):
(WebKit::NetworkCache::Storage::WriteOperation::WriteOperation):
(WebKit::NetworkCache::Storage::TraverseOperation::TraverseOperation):

Operations now ref the storage. They are already deleted in the main thread so
proper destruction is taken care of.

(WebKit::NetworkCache::Storage::open):
(WebKit::NetworkCache::Storage::~Storage):
(WebKit::NetworkCache::Storage::synchronize):

This and other asynchronous methods now protect the Storage instance.

(WebKit::NetworkCache::Storage::remove):
(WebKit::NetworkCache::Storage::retrieve):
(WebKit::NetworkCache::Storage::store):
(WebKit::NetworkCache::Storage::traverse):
(WebKit::NetworkCache::Storage::clear):
(WebKit::NetworkCache::Storage::shrink):
(WebKit::NetworkCache::Storage::deleteOldVersions):

  • NetworkProcess/cache/NetworkCacheStorage.h:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
(WebKit::NetworkProcess::clearDiskCache):

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::clearDiskCache):

3:12 AM Changeset in webkit [220266] by clopez@igalia.com
  • 2 edits
    1 delete in trunk/LayoutTests

[GTK] Test gardening around MOUSE_CURSOR_SCALE.
https://bugs.webkit.org/show_bug.cgi?id=109469

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-04
Reviewed by Carlos Alberto Lopez Perez.

Remove obsolete expectation for cursor-parsing-image-set.html; it may have
started passing in r209396.

Mark mouse-cursor-image-set.html as failing rather than using an incorrect
-expected file.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/events/mouse-cursor-image-set-expected.txt: Removed.
3:01 AM Changeset in webkit [220265] by clopez@igalia.com
  • 2 edits in trunk/JSTests

JSC test wasm/js-api/test_memory_constructor.js should be skipped on memoryLimited
https://bugs.webkit.org/show_bug.cgi?id=175150

Unreviewed test gardening.

  • wasm/js-api/test_memory_constructor.js:
2:54 AM Changeset in webkit [220264] by zandobersek@gmail.com
  • 10 edits
    3 adds in trunk/Source/WebCore

[EME] Push CDMFactory into the platform layer
https://bugs.webkit.org/show_bug.cgi?id=175129

Reviewed by Xabier Rodriguez-Calvar.

This is a follow-up to r219678 that moved the majority of CDM abstraction
classes into the platform layer, but missed the CDMFactory class.

The CDMFactory abstraction is now also placed in the platform layer. Only
change to the interface is that the createCDM() method can't accept a CDM
object reference anymore since that class is cemented into the WebCore
layer, and no current implementation used it anyway.

Additionally, the static Vector object of registered factories is moved
under the CDMFactory class, along with the register and unregister
functions. The platformRegisterFactories() function is added to allow for
platform-specific factory registrations to occur when the registered
factories are queried for the first time. Empty implementation for this
function is provided for non-GStreamer platforms, while for GStreamer
the implementation is kept in CDMFactoryGStreamer.cpp. It's still empty
for now, but it will register the ClearKey factory there in the near
future.

No new tests -- none affected, only refactoring.

  • CMakeLists.txt:
  • Modules/encryptedmedia/CDM.cpp:

(WebCore::createCDMPrivateForKeySystem):
(WebCore::CDM::supportsKeySystem):
(WebCore::CDM::CDM):
(): Deleted.
(WebCore::CDM::registerCDMFactory): Deleted.
(WebCore::CDM::unregisterCDMFactory): Deleted.

  • Modules/encryptedmedia/CDM.h:

(WebCore::CDMFactory::~CDMFactory): Deleted.

  • PlatformWPE.cmake:
  • platform/GStreamer.cmake:
  • platform/encryptedmedia/CDMFactory.cpp: Added.

(WebCore::CDMFactory::registerFactory):
(WebCore::CDMFactory::unregisterFactory):
(WebCore::CDMFactory::platformRegisterFactories):

  • platform/encryptedmedia/CDMFactory.h: Added.

(WebCore::CDMFactory::~CDMFactory):

  • platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::CDMFactoryClearKey::createCDM):

  • platform/encryptedmedia/clearkey/CDMClearKey.h:
  • platform/encryptedmedia/gstreamer/CDMFactoryGStreamer.cpp: Added.

(WebCore::CDMFactory::platformRegisterFactories):

  • testing/MockCDMFactory.cpp:

(WebCore::m_weakPtrFactory):
(WebCore::MockCDMFactory::unregister):
(WebCore::MockCDMFactory::createCDM):

  • testing/MockCDMFactory.h:
2:08 AM Changeset in webkit [220263] by zandobersek@gmail.com
  • 2 edits
    15 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Update test expectations and layout test baselines
for Web Crypto tests now that the implementation is complete.

  • platform/gtk/TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_cbc.worker-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_cbc.https-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes.worker-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/import_export: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/rsa_pkcs.worker-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/rsa_pss.worker-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pkcs.https-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pss.https-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey.https-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.worker-expected.txt: Added.
1:51 AM Changeset in webkit [220262] by gskachkov@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

[EsNext] Async iteration - Add feature flag
https://bugs.webkit.org/show_bug.cgi?id=166694

Reviewed by Yusuke Suzuki.

Add feature flag to JSC to switch on/off Async Iterator

  • runtime/Options.h:
1:08 AM Changeset in webkit [220261] by fred.wang@free.fr
  • 7 edits
    2 adds in trunk

ScrollingTreeOverflowScrollingNodeIOS uses the wrong fixed position rectangle
https://bugs.webkit.org/show_bug.cgi?id=175135

Patch by Frederic Wang <fwang@igalia.com> on 2017-08-04
Reviewed by Simon Fraser.

Source/WebCore:

This patch modifies ScrollingTreeOverflowScrollingNodeIOS::updateChildNodesAfterScroll so
that it uses the fixed position rectangle relative of the first frame ancestor instead of
the one of the main frame. This makes it consistent with ScrollingTreeFrameScrollingNodeIOS
and RenderLayerCompositor. This fixes some flickering issues on iOS.

Test: fast/scrolling/ios/fixed-inside-overflow-inside-iframe.html

  • page/scrolling/ScrollingTreeFrameScrollingNode.h:

(WebCore::ScrollingTreeFrameScrollingNode::fixedPositionRect): Helper function to get the
fixed position rect to use for that frame.

  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::enclosingFrameNode const): Helper function to get the enclosing
frame for this scrolling node or null if there is none.

  • page/scrolling/ScrollingTreeNode.h: Declare enclosingFrameNode.

Source/WebKit:

This patch modifies ScrollingTreeOverflowScrollingNodeIOS::updateChildNodesAfterScroll so
that it uses the fixed position rectangle relative of the first frame ancestor instead of
the one of the main frame. This makes it consistent with ScrollingTreeFrameScrollingNodeIOS
and RenderLayerCompositor. This fixes some flickering issues on iOS.

  • UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateChildNodesAfterScroll): Use the fixed
position rect of a non-main frame if there is one.

LayoutTests:

This patch adds a new test for a position:fixed element inside an overflow node inside an
iframe. When scrolling the overflow node, the position of such an element should remain fixed
relative to the inner frame. Before that change, ScrollingTreeOverflowScrollingNodeIOS used
to take the main frame as a reference instead, causing the element to flicker and even to
disappear when the user scrolls that overflow node. We add a reftest to verify that the
element is visible and positioned at the correct location when the user scrolls.

  • fast/scrolling/ios/fixed-inside-overflow-inside-iframe-expected.html: Added.
  • fast/scrolling/ios/fixed-inside-overflow-inside-iframe.html: Added.
12:56 AM Changeset in webkit [220260] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

Unreviewed. Removing redundant NotImplemented.h header inclusions
and cleaning up whitespace issues in libgcrypt-specific CryptoKeyEC
and CryptoKeyRSA implementation files.

  • crypto/gcrypt/CryptoKeyECGCrypt.cpp:
  • crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:
12:52 AM Changeset in webkit [220259] by zandobersek@gmail.com
  • 2 edits
    12 adds in trunk/LayoutTests

Unreviewed WPE gardening. Update test expectations and layout test baselines
for Web Crypto tests now that the implementation is complete.

  • platform/wpe/TestExpectations:
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes.worker-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/import_export: Added.
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify: Added.
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/rsa_pkcs.worker-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/rsa_pss.worker-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pkcs.https-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pss.https-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey: Added.
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey.https-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.worker-expected.txt: Added.
12:36 AM Changeset in webkit [220258] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unnecesary call to status bar SPI.
https://bugs.webkit.org/show_bug.cgi?id=175176
rdar://problem/20887306

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-04
Reviewed by Darin Adler.

No new tests because no behavior change.

This removes an obsolete call to SPI.

  • platform/ios/VideoFullscreenInterfaceAVKit.mm:

(VideoFullscreenInterfaceAVKit::cleanupFullscreen):

Note: See TracTimeline for information about the timeline view.