Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Aug 13, 2017:

11:55 PM Changeset in webkit [220645] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220467 - ServiceWorker experimental feature should not be on by default (definitely not ready).
​https://bugs.webkit.org/show_bug.cgi?id=175389

Rubberstamped by Andy Estes.

• Shared/WebPreferencesDefinitions.h: false, not DEFAULT_EXPERIMENTAL_FEATURES_ENABLED

11:53 PM Changeset in webkit [220644] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220464 - [WinCairo] Fix build after rev 220399
​https://bugs.webkit.org/show_bug.cgi?id=175360

Reviewed by Žan Doberšek.

No new tests. No change in behavior.

• platform/graphics/texmap/TextureMapperGLHeaders.h:

11:52 PM Changeset in webkit [220643] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220461 - [GStreamer][MSE] Add missing lock around getStreamByTrackId
​https://bugs.webkit.org/show_bug.cgi?id=175323

Patch by Charlie Turner <​cturner@igalia.com> on 2017-08-09
Reviewed by Xabier Rodriguez-Calvar.

Covered by existing tests.

• platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::enqueueSample): Ensure the media source
lock is taken before modifiying the track queues indirectly via the
iterator use in getTrackId.

11:49 PM Changeset in webkit [220642] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.18/JSTests

Merge r220458 - Skip failing JSC tests stress/regress-169783.js and wasm.yaml/wasm/stress/oom.js.
​https://bugs.webkit.org/show_bug.cgi?id=175255

Unreviewed test gardening.

• stress/regress-169783.js:
• wasm/stress/oom.js:

11:46 PM Changeset in webkit [220641] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220454 - Remove unnecessary copies of PlatformMediaSessionManager::m_sessions
​https://bugs.webkit.org/show_bug.cgi?id=175375

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-09
Reviewed by Sam Weinig.

Remove unnecessary copies of PlatformMediaSessionManager::m_sessions.

These should have been removed in r207688.

No new tests: no behavior change.

• platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive const):
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const):
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground const):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground const):

11:44 PM Changeset in webkit [220640] by Carlos Garcia Campos

• 11 edits in releases/WebKitGTK/webkit-2.18

Merge r220453 - Reinstate active flag for iterators
​https://bugs.webkit.org/show_bug.cgi?id=175312

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Resync WPT tests from upstream to gain test coverage.

• web-platform-tests/dom/traversal/NodeIterator-expected.txt:
• web-platform-tests/dom/traversal/NodeIterator.html:
• web-platform-tests/dom/traversal/TreeWalker-expected.txt:
• web-platform-tests/dom/traversal/TreeWalker.html:

Source/WebCore:

NodeIterator / TreeWalker should no longer allow recursive filters
after the following change to the DOM specification:

• ​https://github.com/whatwg/dom/pull/359

This patch aligns our behavior with the latest specification.

No new tests, updated existing tests.

• dom/NodeIterator.cpp:

(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
Note that we now also call m_candidateNode.clear() before returning an
exception. This was a pre-existing bug that we failed to do so in the
exception case but it became more obvious after this change now that
we throw. This was causing traversal/moz-bug559526.html to fail
otherwise (the filter was called one too many times). The test case
is passing in Firefox (The filter is called 4 times and they throw
each time).

• dom/Traversal.cpp:

(WebCore::NodeIteratorBase::NodeIteratorBase):
(WebCore::NodeIteratorBase::acceptNode):

• dom/Traversal.h:
• dom/TreeWalker.cpp:

11:31 PM Changeset in webkit [220639] by Manuel Rego Casasnovas

• 12 edits
  2 adds in trunk

Composition underline color is always black
​https://bugs.webkit.org/show_bug.cgi?id=174675

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.

Test: editing/composition-underline-color.html

• editing/CompositionUnderline.h:

(WebCore::CompositionUnderline::CompositionUnderline):
Added new attribute compositionUnderlineColor.

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionUnderline):
Use the text color if compositionUnderlineColor is TextColor.

Source/WebKit:

This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.

• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(WebKit::WebViewImpl::setMarkedText): Use text color
for composition underline in the plain text case.

• UIProcess/gtk/InputMethodFilter.cpp:

(WebKit::InputMethodFilter::handleKeyboardEventWithCompositionResults):
Use text color for composition underline.
(WebKit::InputMethodFilter::updatePreedit): Ditto.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setCompositionForTesting): Ditto.

Source/WebKitLegacy/mac:

• WebView/WebHTMLView.mm:

(extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(-[WebHTMLView setMarkedText:selectedRange:]): Use text color
for composition underline in the plain text case.

Source/WebKitLegacy/win:

• WebView.cpp:

(WebView::setCompositionForTesting): Use text color for
composition underline.

LayoutTests:

Added new test to check that the composition underline
is using the text color.
The test hides the text and the caret, so it only shows
the composition underline and checks against an -expected-mismatch
that the color of the composition marker is different.

• editing/composition-underline-color-expected-mismatch.html: Added.
• editing/composition-underline-color.html: Added.

11:23 PM Changeset in webkit [220638] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[GTK] stop kinetic scrolling when a zero movement is reached
​https://bugs.webkit.org/show_bug.cgi?id=175468

Reviewed by Michael Catanzaro.

This is GTK+ change by Christian Hergert.
​https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=4f63d839550f7a9038b391e7d3e1e6fc8bdfafa6

When the kinetic scrolling reduces its speed, there can be multiple frames where the movement is zero pixels,
followed by a 1 pixel movement later on. This causes a "jitter" right at the end of the scroll which makes it
feel less quality than other platforms. Instead, we should just clamp it as soon as we get a zero movement.

• platform/ScrollAnimationKinetic.cpp:

(WebCore::ScrollAnimationKinetic::PerAxisData::animateScroll):

11:06 PM Changeset in webkit [220637] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220450 - [GTK] [WPE] Update expectations for global-constructors-attributes.html.
​https://bugs.webkit.org/show_bug.cgi?id=175373

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-09

• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/wpe/js/dom/global-constructors-attributes-expected.txt:

11:00 PM Changeset in webkit [220636] by Carlos Garcia Campos

• 5 edits in releases/WebKitGTK/webkit-2.18

Merge r220449 - REGRESSION: 2 test262/test/language/statements/async-function failures
​https://bugs.webkit.org/show_bug.cgi?id=175334

Reviewed by Yusuke Suzuki.

JSTests:

Add @skip parameters to tests, and remove test for async iterator from
async await syntax test because it is already covered by async-iterator-syntax.js

• stress/async-await-syntax.js:
• stress/async-iteration-syntax.js:

Source/JavaScriptCore:

Switch off useAsyncIterator by default

• runtime/Options.h:

10:56 PM Changeset in webkit [220635] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r220571. rdar://problem/33829966

10:56 PM Changeset in webkit [220634] by jmarcell@apple.com

• 6 edits
  3 adds in branches/safari-604-branch

Cherry-pick r220551. rdar://problem/33843388

10:55 PM Changeset in webkit [220633] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r220505. rdar://problem/33829966

2:07 PM Changeset in webkit [220632] by Chris Dumez

• 10 edits in trunk/Source/WebCore

Drop non-const getter for CachedResource::resourceRequest()
​https://bugs.webkit.org/show_bug.cgi?id=175524

Reviewed by Youenn Fablet.

Drop non-const getter for CachedResource::resourceRequest(). It would be unsafe to modify the request of a CachedResource
after it has been cached. Exposing such a getter is therefore a footgun.

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):

• loader/cache/CachedImage.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

• loader/cache/CachedResource.h:

(WebCore::CachedResource::resourceRequest const):
(WebCore::CachedResource::ignoreForRequestCount const):
(WebCore::CachedResource::setIgnoreForRequestCount):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

• loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::ignoreForRequestCount const):
(WebCore::CachedResourceRequest::setIgnoreForRequestCount):

• loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::addImageToCache):

• platform/network/ResourceRequestBase.h:

5:13 AM Changeset in webkit [220631] by Adrian Perez de Castro

• 9 edits
  1 move in trunk

[WPE] Implement WebCore::standardUserAgent()
​https://bugs.webkit.org/show_bug.cgi?id=175507

Reviewed by Carlos Alberto Lopez Perez.

Implement missing User-Agent handling for the WPE port by sharing the code with the GTK+ port.

.:

• Source/cmake/OptionsGTK.cmake: Rename "GTK" with "GLIB" in UA version macros.
• Source/cmake/OptionsWPE.cmake: Add UA version macros.

Source/WebCore:

• PlatformGTK.cmake: Handlde renaming of UserAgentGtk.cpp to UserAgentGLib.cpp.
• PlatformWPE.cmake: Add UserAgentGLib.cpp and UserAgentQuirks.cpp to the list of built WebCore sources.
• platform/glib/UserAgentGLib.cpp: Renamed from Source/WebCore/platform/gtk/UserAgentGtk.cpp.

(WebCore::versionForUAString): Change "GTK" in UA version macros to "GLIB".

Source/WebKit:

• UIProcess/API/glib/WebKitSettings.cpp: Remove preprocessor conditionals for the WPE port.

(webkit_settings_set_user_agent):
(webkit_settings_set_user_agent_with_application_details):

• UIProcess/wpe/WebPageProxyWPE.cpp:

(WebKit::WebPageProxy::standardUserAgent): Remove hardcoded value and make use of WebCore::standardUserAgent().

Aug 12, 2017:

11:47 PM Changeset in webkit [220630] by Csaba Osztrogonác

• 3 edits in trunk/Source/JavaScriptCore

[ARM64] Use x29 and x30 instead of fp and lr to make GCC happy
​https://bugs.webkit.org/show_bug.cgi?id=175512
<rdar://problem/33863584>

Reviewed by Mark Lam.

• CMakeLists.txt: Added MacroAssemblerARM64.cpp.
• assembler/MacroAssemblerARM64.cpp: Use x29 and x30 instead of fp and lr to make GCC happy.

11:22 PM Changeset in webkit [220629] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

ARM_TRADITIONAL: static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline
​https://bugs.webkit.org/show_bug.cgi?id=175513

Reviewed by Mark Lam.

• assembler/MacroAssemblerARM.cpp: Added d16-d31 FP registers too.

6:59 PM Changeset in webkit [220628] by fpizlo@apple.com

• 6 edits in trunk/Source/JavaScriptCore

FTL's compileGetTypedArrayByteOffset needs to do caging
​https://bugs.webkit.org/show_bug.cgi?id=175366

Reviewed by Saam Barati.

While implementing boxing in the DFG, I noticed that there was some missing boxing in the FTL. This
fixes the case in GetTypedArrayByteOffset, and files FIXMEs for more such cases.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetTypedArrayByteOffset):
(JSC::FTL::DFG::LowerDFGToB3::cagedMayBeNull):

• runtime/ArrayBuffer.h:
• runtime/ArrayBufferView.h:
• runtime/JSArrayBufferView.h:

3:14 PM Changeset in webkit [220627] by rniwa@webkit.org

• 43 edits
  3 adds in trunk

Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
​https://bugs.webkit.org/show_bug.cgi?id=175474
.:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/WebKitFeatures.cmake:
• Source/cmake/tools/vsprops/FeatureDefines.props:
• Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

• Configurations/FeatureDefines.xcconfig:
• runtime/CommonIdentifiers.h:

Source/WebCore:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Replaced the build flag by a runtime flag and added a stub implementation for DataTransferItemList
and DataTransferItem to make it compile. DataTransferItemList is created lazily by DataTransfer.items,
and its lifetime is tied to DataTransfer by forwarding ref and deref.

See ​https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitemlist-interface

Tests: editing/pasteboard/datatransfer-idl.html

• CMakeLists.txt:
• Configurations/FeatureDefines.xcconfig:
• WebCore.xcodeproj/project.pbxproj:
• dom/DataTransfer.cpp:

(WebCore::DataTransfer::items): Added. Create DataTransferItemList lazily

• dom/DataTransfer.h:
• dom/DataTransfer.idl:
• dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::DataTransferItem): Added a stub implementation.
(WebCore::DataTransferItem::~DataTransferItem): Ditto.
(WebCore::DataTransferItem::getAsString const): Ditto.
(WebCore::DataTransferItem::getAsFile const): Ditto.

• dom/DataTransferItem.h:

(WebCore::DataTransferItemList): Devirtualized functions.
(WebCore::DataTransferItemList::kind const):
(WebCore::DataTransferItemList::type const):

• dom/DataTransferItem.idl:
• dom/DataTransferItemList.cpp: Added.

(WebCore::DataTransferItemList::length const): Added a stub implementation.
(WebCore::DataTransferItemList::item): Ditto.
(WebCore::DataTransferItemList::add): Ditto.
(WebCore::DataTransferItemList::remove): Ditto.
(WebCore::DataTransferItemList::clear): Ditto.

• dom/DataTransferItemList.h:

(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::~DataTransferItemList): Deleted.
(WebCore::DataTransferItemList::ref): Forwards to DataTransfer's ref.
(WebCore::DataTransferItemList::deref): Ditto.

• dom/DataTransferItemList.idl: Updated to match the latest specification.
• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled): Added.
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled const): Added.

Source/WebCore/PAL:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Replaced the build flag by a runtime flag and disabled the feature by default.

• Configurations/FeatureDefines.xcconfig:
• Shared/WebPreferencesDefinitions.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDataTransferItemsEnabled): Added to be used by WebKitTestRunner.
(WKPreferencesGetDataTransferItemsEnabled): Ditto.

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Replaced the build flag by a runtime flag and disabled the feature by default.

• Configurations/FeatureDefines.xcconfig:
• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Disables dataTransfer.items by default.
(-[WebPreferences dataTransferItemsEnabled]): Added.
(-[WebPreferences setDataTransferItemsEnabled:]): Added.

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WTF:

Reviewed by Wenson Hsieh.

• wtf/FeatureDefines.h:

Tools:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Added a W3C-style IDL test.

• editing/pasteboard/datatransfer-idl.html: Added.

2:58 PM Changeset in webkit [220626] by Chris Dumez

• 34 edits in trunk

Address flakiness related to download tests
​https://bugs.webkit.org/show_bug.cgi?id=175338

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several WPT tests now that download callbacks are no longer logged.

• web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click-expected.txt:
• web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-expected.txt:

Tools:

• Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished() is actually queried when a download completes. Previously, this would be identical to a call to testRunner.waitUntilDone() because any download completion would call testRunner.notifyDone().
• Disable logging of download callbacks by default and add a testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to enable such logging.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setShouldLogDownloadCallbacks):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::downloadDidStart):
(WTR::TestController::decideDestinationWithSuggestedFilename):
(WTR::TestController::downloadDidFinish):
(WTR::TestController::downloadDidFail):
(WTR::TestController::downloadDidCancel):

• WebKitTestRunner/TestController.h:

(WTR::TestController::setShouldLogDownloadCallbacks):

• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

• TestExpectations:

Unmark several download tests as flaky.

• fast/dom/HTMLAnchorElement/anchor-download-synthetic-click.html:
• fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html:
• fast/dom/HTMLAnchorElement/anchor-download.html:
• fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html:
• fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html:
• fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html:
• fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html:
• fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html:
• fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html:
• fast/dom/HTMLAnchorElement/anchor-file-blob-download.html:
• fast/dom/HTMLAnchorElement/anchor-nodownload-set.html:
• http/tests/download/anchor-download-attribute-content-disposition.html:
• http/tests/download/anchor-download-no-extension.html:
• http/tests/download/anchor-download-no-value.html:
• http/tests/download/area-download-expected.txt:
• http/tests/download/area-download.html:
• http/tests/security/anchor-download-allow-blob-expected.txt:
• http/tests/security/anchor-download-allow-blob.html:
• http/tests/security/anchor-download-allow-data-expected.txt:
• http/tests/security/anchor-download-allow-data.html:
• http/tests/security/anchor-download-allow-sameorigin.html:

Update download tests to explicitly enable download callbacks logging.

11:44 AM Changeset in webkit [220625] by fpizlo@apple.com

• 14 edits in trunk

Caging shouldn't have to use a patchpoint for adding
​https://bugs.webkit.org/show_bug.cgi?id=175483

Reviewed by Mark Lam.
Source/JavaScriptCore:

Caging involves doing a Add(ptr, largeConstant). All of B3's heuristics for how to deal with
constants and associative operations dictate that you always want to sink constants. For example,
Add(Add(a, constant), b) always becomes Add(Add(a, b), constant). This is profitable because in
typical code, it reveals downstream optimizations. But it's terrible in the case of caging, because
we want the large constant (which is shared by all caging operations) to be hoisted. Reassociating to
sink constants obscures the constant in this case. Currently, moveConstants is not smart enough to
reassociate, so instead of sinking largeConstant, it tries (and often fails) to sink some other
constants instead. Without some hacks, this is a 5% Kraken regression and a 1.6% Octane regression.
It's not clear that moveConstants could ever be smart enough to rematerialize that constant and then
hoist it - that would require quite a bit of algebraic reasoning. But the only case we know of where
our current constant reassociation heuristics are wrong is caging. So, we can get away with some
hacks for just stopping B3's reassociation only in this specific case.

Previously, we achieved this by concealing the Add(ptr, largeConstant) inside a patchpoint. That's
OK, but patchpoints are expensive. They require a SharedTask instance. They require callbacks from
the backend, including during register allocation. And they cannot be CSE'd. We do want B3 to know
that if we cage the same pointer in two places, both places will compute the same value.

This patch improves the situation by introducing the Opaque opcode. This is handled by LowerToAir as
if it was Identity, but all prior phases treat it as an unknown pure unary idempotent operation. I.e.
they know that Opaque(x) == Opaque(x) and that Opaque(Opaque(x)) == Opaque(x). But they don't know
that Opaque(x) == x until LowerToAir. So, you can use Opaque exactly when you know that B3 will mess
up your code but Air won't. (Currently we know of no cases where Air messes things up on a large
enough scale to warrant new opcodes.)

This change is perf-neutral, but may start to help as I add more uses of caged() in the FTL. It also
makes the code a bit less ugly.

• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::shouldCopyPropagate):
(JSC::B3::Air::LowerToAir::lower):

• b3/B3Opcode.cpp:

(WTF::printInternal):

• b3/B3Opcode.h:
• b3/B3ReduceStrength.cpp:
• b3/B3Validate.cpp:
• b3/B3Value.cpp:

(JSC::B3::Value::effects const):
(JSC::B3::Value::key const):
(JSC::B3::Value::isFree const):
(JSC::B3::Value::typeFor):

• b3/B3Value.h:
• b3/B3ValueKey.cpp:

(JSC::B3::ValueKey::materialize const):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

• ftl/FTLOutput.cpp:

(JSC::FTL::Output::opaque):

• ftl/FTLOutput.h:

Websites/webkit.org:

Write documentation for the new Opaque opcode.

• docs/b3/intermediate-representation.html:

11:40 AM Changeset in webkit [220624] by fpizlo@apple.com

• 5 edits in trunk/Source/JavaScriptCore

ScopedArguments overflow storage needs to be in the JSValue gigacage
​https://bugs.webkit.org/show_bug.cgi?id=174923

Reviewed by Saam Barati.

ScopedArguments overflow storage sits at the end of the ScopedArguments object, so we put that
object into the JSValue gigacage.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitScopedArgumentsGetByVal):

• runtime/ScopedArguments.h:

(JSC::ScopedArguments::subspaceFor):
(JSC::ScopedArguments::overflowStorage const):

Aug 11, 2017:

10:18 PM Changeset in webkit [220623] by beidson@apple.com

• 4 edits
  22 moves
  1 add in trunk/Source/WebCore

Move files inside WebCore/workers to WebCore/workers/service.
​https://bugs.webkit.org/show_bug.cgi?id=175495

Rubberstamped by Tim Horton.

• CMakeLists.txt:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:

• workers/service/ServiceWorker.cpp: Renamed from Source/WebCore/workers/ServiceWorker.cpp.
• workers/service/ServiceWorker.h: Renamed from Source/WebCore/workers/ServiceWorker.h.
• workers/service/ServiceWorker.idl: Renamed from Source/WebCore/workers/ServiceWorker.idl.
• workers/service/ServiceWorkerContainer.cpp: Renamed from Source/WebCore/workers/ServiceWorkerContainer.cpp.
• workers/service/ServiceWorkerContainer.h: Renamed from Source/WebCore/workers/ServiceWorkerContainer.h.
• workers/service/ServiceWorkerContainer.idl: Renamed from Source/WebCore/workers/ServiceWorkerContainer.idl.
• workers/service/ServiceWorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/ServiceWorkerGlobalScope.cpp.
• workers/service/ServiceWorkerGlobalScope.h: Renamed from Source/WebCore/workers/ServiceWorkerGlobalScope.h.
• workers/service/ServiceWorkerGlobalScope.idl: Renamed from Source/WebCore/workers/ServiceWorkerGlobalScope.idl.
• workers/service/ServiceWorkerJob.cpp: Renamed from Source/WebCore/workers/ServiceWorkerJob.cpp.
• workers/service/ServiceWorkerJob.h: Renamed from Source/WebCore/workers/ServiceWorkerJob.h.
• workers/service/ServiceWorkerJobClient.h: Renamed from Source/WebCore/workers/ServiceWorkerJobClient.h.
• workers/service/ServiceWorkerProvider.cpp: Renamed from Source/WebCore/workers/ServiceWorkerProvider.cpp.
• workers/service/ServiceWorkerProvider.h: Renamed from Source/WebCore/workers/ServiceWorkerProvider.h.
• workers/service/ServiceWorkerRegistration.cpp: Renamed from Source/WebCore/workers/ServiceWorkerRegistration.cpp.
• workers/service/ServiceWorkerRegistration.h: Renamed from Source/WebCore/workers/ServiceWorkerRegistration.h.
• workers/service/ServiceWorkerRegistration.idl: Renamed from Source/WebCore/workers/ServiceWorkerRegistration.idl.
• workers/service/ServiceWorkerRegistrationOptions.h: Renamed from Source/WebCore/workers/ServiceWorkerRegistrationOptions.h.
• workers/service/ServiceWorkerRegistrationParameters.cpp: Renamed from Source/WebCore/workers/ServiceWorkerRegistrationParameters.cpp.
• workers/service/ServiceWorkerRegistrationParameters.h: Renamed from Source/WebCore/workers/ServiceWorkerRegistrationParameters.h.
• workers/service/ServiceWorkerUpdateViaCache.h: Renamed from Source/WebCore/workers/ServiceWorkerUpdateViaCache.h.
• workers/service/ServiceWorkerUpdateViaCache.idl: Renamed from Source/WebCore/workers/ServiceWorkerUpdateViaCache.idl.

7:51 PM Changeset in webkit [220622] by Chris Dumez

• 37 edits
  4 adds in trunk

Implement quota limitation for keepalive Fetch requests
​https://bugs.webkit.org/show_bug.cgi?id=175482

Reviewed by Sam Weinig and Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt:
• web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt:
• web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt:
• web-platform-tests/fetch/api/cors/cors-multiple-origins-worker-expected.txt:
• web-platform-tests/fetch/api/cors/cors-preflight-star.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker-expected.txt:
• web-platform-tests/fetch/http-cache/cc-request-expected.txt:

Rebaseline tests now that we provide a more helpful error message when rejecting
the fetch() promise.

• web-platform-tests/fetch/api/request/request-keepalive-quota-expected.txt:

Rebaseline test for keepalive Fetch requests quota which is now passing.

Source/WebCore:

Implement quota limitation for keepalive Fetch requests as per:

• ​https://fetch.spec.whatwg.org/#http-network-or-cache-fetch (Step 9)

This partly works for Beacon as well, meaning that no Beacon with a body
over 64Kb can be sent. However, we don't keep track about wether or not
beacon loads are inflight or not.

Also update CachedResourceLoader::requestResource() so that the caller
can get a ResourceError when it returns null. This is useful for both
Fetch and Beacon to return better error messages.

Test: http/wpt/beacon/beacon-quota.html

• CMakeLists.txt:
• Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

• Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::BlobLoader::didReceiveResponse):
(WebCore::FetchBodyOwner::BlobLoader::didFail):

• Modules/fetch/FetchBodyOwner.h:
• Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):
(WebCore::FetchLoader::didFail):

• Modules/fetch/FetchLoaderClient.h:
• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didFail):

• Modules/fetch/FetchResponse.h:
• WebCore.xcodeproj/project.pbxproj:
• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

• loader/cache/CachedResource.h:

(WebCore::CachedResource::isMainOrMediaOrIconOrRawResource const):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestMedia):
(WebCore::CachedResourceLoader::requestIcon):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::CachedResourceLoader::requestMainResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

• loader/cache/CachedResourceLoader.h:
• loader/cache/KeepaliveRequestTracker.cpp: Added.

(WebCore::KeepaliveRequestTracker::~KeepaliveRequestTracker):
(WebCore::KeepaliveRequestTracker::canLoadRequest):
(WebCore::KeepaliveRequestTracker::registerRequest):
(WebCore::KeepaliveRequestTracker::responseReceived):
(WebCore::KeepaliveRequestTracker::notifyFinished):
(WebCore::KeepaliveRequestTracker::unregisterRequest):

• loader/cache/KeepaliveRequestTracker.h: Added.
• platform/network/FormData.cpp:

(WebCore::FormDataElement::lengthInBytes const):
(WebCore::FormData::lengthInBytes const):

• platform/network/FormData.h:

LayoutTests:

• fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
• http/tests/contentextensions/async-xhr-onerror-expected.txt:
• http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-iframe-expected.txt:
• http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-main-frame-expected.txt:
• http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt:

Rebaseline a few tests now that we provide a more helpful error message when an XHR is failing synchronously.

• http/wpt/beacon/beacon-quota-expected.txt: Added.
• http/wpt/beacon/beacon-quota.html: Added.

Add layout test coverage for keepalive Fetch requests quota in the context of sendBeacon().
The second part of the test is still failing because WebCore does not currently know when
ping loads (e.g. beacon loads) complete. This will be addressed via Bug 175443.

6:13 PM Changeset in webkit [220621] by don.olmstead@sony.com

• 13 edits
  1 move in trunk/Source

[WTF] Move ValueToString into WTF
​https://bugs.webkit.org/show_bug.cgi?id=175469

Reviewed by Sam Weinig.

Source/WebCore:

No new tests. No change in behavior.

• WebCore.xcodeproj/project.pbxproj:
• html/HTMLMediaElement.h:

(WTF::ValueToString<WebCore::TextTrackCue::string):
(WebCore::ValueToString<TextTrackCue::string): Deleted.
(WebCore::ValueToString<MediaTime>::string): Deleted.

• platform/LayoutUnit.h:

(WTF::ValueToString<WebCore::LayoutUnit>::string):
(WebCore::ValueToString<LayoutUnit>::string): Deleted.

• platform/PODInterval.h:
• platform/PODIntervalTree.h:
• platform/PODRedBlackTree.h:
• platform/graphics/FloatPolygon.h:

(WTF::ValueToString<WebCore::FloatPolygonEdge::string):
(WebCore::ValueToString<FloatPolygonEdge::string): Deleted.

• rendering/FloatingObjects.h:

(WTF::ValueToString<WebCore::FloatingObject::string):
(WebCore::ValueToString<FloatingObject::string): Deleted.

• rendering/RenderFlowThread.h:

(WTF::ValueToString<WebCore::RenderRegion::string):
(WebCore::ValueToString<RenderRegion::string): Deleted.

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/text/ValueToString.h: Renamed from Source/WebCore/platform/ValueToString.h.

5:32 PM Changeset in webkit [220620] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

[Bindings] Simplify DOMPromiseProxy now that WTF::Function can return references
​https://bugs.webkit.org/show_bug.cgi?id=175394

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

• bindings/IDLTypes.h:

(WebCore::IDLWrapper::convertToParameterType): Deleted.

Remove no longer used convertToParameterType.

• bindings/js/DOMPromiseProxy.h:

• Replace Variant<Value, Exception> with ExceptionOr<Value> / ExceptionOr<void>.
• Update ResolveCallback to have a return type of IDLType::ParameterType, rather than IDLType::ImplementationType, now that WTF::Function supports references as the return type. This is needed, since the IDLType::ParameterType for an interface T is T&.

• css/FontFace.cpp:
• css/FontFace.h:
• css/FontFaceSet.cpp:
• css/FontFaceSet.h:

Update resolve callbacks to return a reference rather than a RefPtr, matching
the new signature requirement.

5:07 PM Changeset in webkit [220619] by commit-queue@webkit.org

• 17 edits
  11 copies
  1 move
  2 deletes in trunk/Source/WebCore

[WebIDL] Replace JSCryptoKeyCustom and JSCryptoAlgorithmBuilder with generated code
​https://bugs.webkit.org/show_bug.cgi?id=175457

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

• CMakeLists.txt:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSCryptoAlgorithmBuilder.cpp: Removed.
• bindings/js/JSCryptoAlgorithmBuilder.h: Removed.
• bindings/js/JSCryptoKeyCustom.cpp: Removed.

Remove JSCryptoAlgorithmBuilder and JSCryptoKeyCustom, add KeyAlgorithm
IDLs and headers.

• crypto/CryptoKey.cpp:
• crypto/CryptoKey.h:
• crypto/CryptoKey.idl:

Replace custom algorithm attribute with a union of the supported key algorithms.

• crypto/keys/CryptoAesKeyAlgorithm.h: Added.
• crypto/keys/CryptoAesKeyAlgorithm.idl: Added.
• crypto/keys/CryptoEcKeyAlgorithm.h: Added.
• crypto/keys/CryptoEcKeyAlgorithm.idl: Added.
• crypto/keys/CryptoHmacKeyAlgorithm.h: Added.
• crypto/keys/CryptoHmacKeyAlgorithm.idl: Added.
• crypto/keys/CryptoKeyAlgorithm.h: Added.
• crypto/keys/CryptoKeyAlgorithm.idl: Added.
• crypto/keys/CryptoRsaHashedKeyAlgorithm.h: Added.
• crypto/keys/CryptoRsaHashedKeyAlgorithm.idl: Added.
• crypto/keys/CryptoRsaKeyAlgorithm.h: Added.
• crypto/keys/CryptoRsaKeyAlgorithm.idl: Added.

Add IDLs and headers fo the supported key algorithms.

• crypto/keys/CryptoKeyAES.h:
• crypto/keys/CryptoKeyEC.h:
• crypto/keys/CryptoKeyHMAC.h:
• crypto/keys/CryptoKeyRSA.h:
• crypto/keys/CryptoKeyRaw.h:

Give each of the existing KeyAlgorithm subclasses a dictionary() function
that returns the populated corresponding spec'd dictionary.

4:18 PM Changeset in webkit [220618] by fpizlo@apple.com

• 4 edits in trunk/Source/JavaScriptCore

JSLexicalEnvironment needs to be in the JSValue gigacage
​https://bugs.webkit.org/show_bug.cgi?id=174922

Reviewed by Michael Saboff.

We can sorta random access the JSLexicalEnvironment. So, we put it in the JSValue gigacage and make
the only random accesses use pointer caging.

We don't need to do anything to normal lexical environment accesses.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

• runtime/JSEnvironmentRecord.h:

(JSC::JSEnvironmentRecord::subspaceFor):
(JSC::JSEnvironmentRecord::variables):

4:12 PM Changeset in webkit [220617] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Update TestExpectations for failing media/video-controls tests.
​https://bugs.webkit.org/show_bug.cgi?id=173978

Unreviewed test gardening.

• platform/mac/TestExpectations:

3:43 PM Changeset in webkit [220616] by Simon Fraser

• 10 edits in trunk/Source/WebCore

Some RenderSVGResource cleanup
​https://bugs.webkit.org/show_bug.cgi?id=175494

Reviewed by Zalan Bujtas.

Use more initializers. Remove spurious use of bitfields that didn't save any space at all.
0 -> nullptr.

No behavior change.

• rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):

• rendering/svg/RenderSVGResourceContainer.h:
• rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::applyResource):

• rendering/svg/RenderSVGResourceGradient.h:
• rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):

• rendering/svg/RenderSVGResourcePattern.h:
• rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::strokeShape):

• rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

• rendering/svg/SVGRenderingContext.h:

(WebCore::SVGRenderingContext::SVGRenderingContext):

3:35 PM Changeset in webkit [220615] by timothy_horton@apple.com

• 5 edits in trunk/Source

Fix the build with modern Clang's -Wexpansion-to-defined
​https://bugs.webkit.org/show_bug.cgi?id=175467
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/WebCore:

• crypto/mac/SerializedCryptoKeyWrapMac.mm:

Source/WTF:

• wtf/FeatureDefines.h:
• wtf/Platform.h:

Avoid object-like macros that expand to include defined(), because this
behaves inconsistently between different compilers (though in ways
that don't matter for these particular defines, which aren't used on MSVC),
and Clang has added a warning for it.

Move ENABLE_WEBASSEMBLY to Platform.h since it depends on things that
are defined there and can't be evaluated at time-of-use because of the
aforementioned new rules. Previously, there was a cycle between
ENABLE_WEBASSEMBLY and ENABLE_B3_JIT -- break that so that it just
goes FTL_JIT->B3_JIT->WASM instead.

3:33 PM Changeset in webkit [220614] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Clicking on suggestion hint should apply it, not dismiss
​https://bugs.webkit.org/show_bug.cgi?id=175409

Reviewed by Matt Baker.

Make clicking on the suggestion hint apply the completion, and place the text caret after it.

• UserInterface/Controllers/CodeMirrorCompletionController.js:

(WI.CodeMirrorCompletionController.prototype._createCompletionHintMarker):

3:21 PM Changeset in webkit [220613] by jmarcell@apple.com

• 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:20 PM Changeset in webkit [220612] by jmarcell@apple.com

• 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

2:27 PM Changeset in webkit [220611] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.38.1.5

Tag Safari-604.1.38.1.5.

2:25 PM Changeset in webkit [220610] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.38.0.5

Tag Safari-604.1.38.0.5.

2:08 PM Changeset in webkit [220609] by Nikita Vasilyev

• 15 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Update the filter icon to match Xcode
​https://bugs.webkit.org/show_bug.cgi?id=175458
<rdar://problem/33838660>

Reviewed by Matt Baker.

• UserInterface/Images/FilterFieldGlyph.svg:

Half-pixel transform is necessary for a cleaner rasterisation.

• UserInterface/Views/FilterBar.css:

(.filter-bar > input[type="search"]::-webkit-search-decoration):
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter):
::-webkit-search-decoration is a flexbox item. Remove vertical-align: bottom,
since it didn't do anything for it.

• UserInterface/Views/DOMNodeDetailsSidebarPanel.css:
• UserInterface/Views/FilterBar.js:

(WI.FilterBar):

• UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WI.CSSStyleDetailsSidebarPanel.prototype.initialLayout):

• UserInterface/Views/DebuggerSidebarPanel.js:
• UserInterface/Views/LogContentView.js:

(WI.LogContentView):

• UserInterface/Views/NetworkSidebarPanel.js:

(WI.NetworkSidebarPanel):

• UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel):

• UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel):

• UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel):

• UserInterface/Views/StorageSidebarPanel.js:

(WI.StorageSidebarPanel):

• UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):

• Localizations/en.lproj/localizedStrings.js:

Replace placeholder text for all filter fields with "Filter".

1:37 PM Changeset in webkit [220608] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

Crash under ServiceWorkerJob::failedWithException.
​https://bugs.webkit.org/show_bug.cgi?id=175488

Reviewed by Tim Horton.

Covered by existing tests.

• workers/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::failedWithException): jobDidFinish might cause the Job to be deleted, so make it last.

1:36 PM Changeset in webkit [220607] by Ryan Haddad

• 5 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviewed test gardening. rdar://problem/33831603

• fast/events/ios/no-touch-events-when-stopping-momentum-scroll-in-mainframe-expected.txt:
• platform/ios-11/TestExpectations:
• platform/ios-simulator-wk2/TestExpectations:
• platform/ios-wk2/fast/dom/elementFromPoint-relative-to-viewport-expected.txt:

1:08 PM Changeset in webkit [220606] by fpizlo@apple.com

• 7 edits in trunk/Source/JavaScriptCore

DirectArguments should be in the JSValue gigacage
​https://bugs.webkit.org/show_bug.cgi?id=174920

Reviewed by Michael Saboff.

This puts DirectArguments in a new subspace for cells that want to be in the JSValue gigacage. All
indexed accesses to DirectArguments now do caging. get_from_arguments/put_to_arguments are exempted
because they always operate on a DirectArguments that is pointed to directly from the stack, they are
required to use fixed offsets, and you can only store JSValues.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnDirectArguments):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDirectArgumentsGetByVal):

• runtime/DirectArguments.h:

(JSC::DirectArguments::subspaceFor):
(JSC::DirectArguments::storage):

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

1:04 PM Changeset in webkit [220605] by Jonathan Bedard

• 2 edits in trunk/Tools

Create mock ITP data in testing to prevent grandfathering
​https://bugs.webkit.org/show_bug.cgi?id=174720

Unreviewed follow-up fix for r220604.

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.

10:30 AM Changeset in webkit [220604] by Jonathan Bedard

• 5 edits in trunk/Tools

Create mock ITP data in testing to prevent grandfathering
​https://bugs.webkit.org/show_bug.cgi?id=174720
<rdar://problem/33457779>

Reviewed by Brent Fulgham.

We don't need to be triggering grandfathering when each test runner starts. On Mac,
this may launch plugins which can cause layout tests to fail later if the test
runner does not shut-down before the plugins unload.

• WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
prevent grandfathering from being triggered.

• WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.

• WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformInitialize): Ditto.

10:26 AM Changeset in webkit [220603] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, add a FIXME.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

10:26 AM Changeset in webkit [220602] by Matt Lewis

• 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

• platform/ios-11/TestExpectations:

9:56 AM Changeset in webkit [220601] by weinig@apple.com

• 10 edits in trunk

WTF::Function does not allow for reference / non-default constructible return types
​https://bugs.webkit.org/show_bug.cgi?id=175244
Source/JavaScriptCore:

Reviewed by Chris Dumez.

• runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

Reviewed by Chris Dumez.

• bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

Reviewed by Chris Dumez.

• UIProcess/WebResourceLoadStatisticsStore.h:

Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

Reviewed by Chris Dumez.

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

• wtf/Function.h:

(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

Tools:

<rdar://problem/33801582>

Reviewed by Chris Dumez.

• TestWebKitAPI/Tests/WTF/Function.cpp:

(TestWebKitAPI::TEST):

9:54 AM Changeset in webkit [220600] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Gardening: fix CLoop build.
​https://bugs.webkit.org/show_bug.cgi?id=175446
<rdar://problem/33836545>

Not reviewed.

• assembler/MacroAssemblerPrinter.cpp:

9:53 AM Changeset in webkit [220599] by jmarcell@apple.com

• 6 edits
  3 adds in branches/safari-604.1.38.1-branch

Cherry-pick r220551. rdar://problem/33843387

9:53 AM Changeset in webkit [220598] by jmarcell@apple.com

• 3 edits
  3 deletes in branches/safari-604.1.38.1-branch

Revert r220587. rdar://problem/33843387

9:53 AM Changeset in webkit [220597] by jmarcell@apple.com

• 7 edits in branches/safari-604.1.38.1-branch

Revert r220588. rdar://problem/33843387

9:47 AM Changeset in webkit [220596] by fpizlo@apple.com

• 5 edits in trunk/Source/JavaScriptCore

DFG should do caging
​https://bugs.webkit.org/show_bug.cgi?id=174918

Reviewed by Saam Barati.

Adds the appropriate cage() calls to the DFG, including a cageTypedArrayStorage() helper that does
the conditional caging with a watchpoint.

This might be a 1% SunSpider slow-down, but it's not clear.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::cageTypedArrayStorage):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
(JSC::DFG::SpeculativeJIT::compileCreateRest):
(JSC::DFG::SpeculativeJIT::compileSpread):
(JSC::DFG::SpeculativeJIT::compileNewArrayWithSpread):
(JSC::DFG::SpeculativeJIT::compileArraySlice):
(JSC::DFG::SpeculativeJIT::compileGetButterfly):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

9:39 AM Changeset in webkit [220595] by Konstantin Tokarev

• 17 edits in trunk

[CMake] Fix broken use of REQUIRED with find modules
​https://bugs.webkit.org/show_bug.cgi?id=175427

Reviewed by Michael Catanzaro.

Module name passed to find_package_handle_standard_args() must exactly
match file name of CMake find module including letter case, e.g. "WebP"
must be used in FindWebP.cmake file. Otherwise find_package() arguments
(REQUIRED, QUIET, version) are not processed correctly.

To continue using old XXX_FOUND variables without case changes porting
to new find_package_handle_standard_args syntax which has FOUND_VAR
parameter. Unfortunately, variable name GTK_UNIX_PRINT_FOUND is not
allowed by find_package_handle_standard_args when package name is
GTKUnixPrint, so it's replaced to GTKUnixPrint_FOUND (default).

• Source/cmake/FindGTKUnixPrint.cmake:
• Source/cmake/FindGeoClue2.cmake:
• Source/cmake/FindHyphen.cmake:
• Source/cmake/FindLibEpoxy.cmake:
• Source/cmake/FindLibGBM.cmake:
• Source/cmake/FindLibsecret.cmake:
• Source/cmake/FindLibtasn1.cmake:
• Source/cmake/FindLibxkbcommon.cmake:
• Source/cmake/FindOpenGL.cmake:
• Source/cmake/FindOpenGLES2.cmake:
• Source/cmake/FindOpenWebRTC.cmake:
• Source/cmake/FindWPEBackend-mesa.cmake:
• Source/cmake/FindWPEBackend.cmake:
• Source/cmake/FindWayland.cmake:
• Source/cmake/FindWebP.cmake:
• Source/cmake/OptionsGTK.cmake:

9:22 AM Changeset in webkit [220594] by Antti Koivisto

• 7 edits in trunk/Source/WebCore

Remove RenderQuote collection from RenderView
​https://bugs.webkit.org/show_bug.cgi?id=175479

Reviewed by Andreas Kling.

We can do it well enough without maintaining this pointer structure.

Global updating doesn't work well with future direction for first-letter and similar anyway.
We need to update quote immediately when updating its style.

• rendering/RenderQuote.cpp:

(WebCore::RenderQuote::insertedIntoTree):
(WebCore::RenderQuote::willBeRemovedFromTree):

Just tell the view that there are renderers to update.

(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::isOpen const):
(WebCore::RenderQuote::updateRenderer):
(WebCore::RenderQuote::updateRenderers): Deleted.

Update single renderer only. RenderTreeUpdater provides the previous renderer to compute the depth.

• rendering/RenderQuote.h:
• rendering/RenderView.cpp:

(WebCore::RenderView::registerQuote): Deleted.
(WebCore::RenderView::unregisterQuote): Deleted.
(WebCore::RenderView::updateSpecialRenderers): Deleted.

Remove the quote list.

• rendering/RenderView.h:
• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::commit):

Ensure that all quotes are updated.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):
(WebCore::RenderTreeUpdater::updateQuotesUpTo):

Traverse render tree to find quotes to update starting from the previous updated quote.

• style/RenderTreeUpdater.h:

8:48 AM Changeset in webkit [220593] by Ryan Haddad

• 2 edits
  46 adds in branches/safari-604.1.38.1-branch/LayoutTests

Cherry-pick r220555.

8:44 AM Changeset in webkit [220592] by Yusuke Suzuki

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for x86 GTK port
​https://bugs.webkit.org/show_bug.cgi?id=175446

Use pushfl/popfl instead of pushfd/popfd.

• assembler/MacroAssemblerX86Common.cpp:

8:44 AM Changeset in webkit [220591] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebCore

[CMake] Many warning about missing “override” keywords in ANGLE with Clang
​https://bugs.webkit.org/show_bug.cgi?id=175475

Reviewed by Michael Catanzaro.

• CMakeLists.txt: Add "-Wno-inconsistent-missing-override" to the

compiler flags using for building the ANGLE sources.

8:43 AM Changeset in webkit [220590] by jmarcell@apple.com

• 2 edits in branches/safari-604.1.38.0-branch/Source/WebKit

Cherry-pick r220571. rdar://problem/33829964

8:41 AM Changeset in webkit [220589] by jmarcell@apple.com

• 2 edits in branches/safari-604.1.38.1-branch/Source/WebKit

Cherry-pick r220571. rdar://problem/33829962

8:17 AM Changeset in webkit [220588] by jmarcell@apple.com

• 7 edits in branches/safari-604.1.38.1-branch

Cherry-pick r220551. rdar://problem/33594320

8:16 AM Changeset in webkit [220587] by jmarcell@apple.com

• 3 edits
  3 adds in branches/safari-604.1.38.1-branch

Cherry-pick r220463. rdar://problem/33594320

6:46 AM Changeset in webkit [220586] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebCore

[GTK][WPE] Overriden virtual function not marked “override” in ImageBufferDataCairo.h
​https://bugs.webkit.org/show_bug.cgi?id=175476

Reviewed by Carlos Garcia Campos.

• platform/graphics/cairo/ImageBufferDataCairo.h: Add missing "override" qualifier.

6:25 AM Changeset in webkit [220585] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

[WPE] Build failure with Clang 4.0.1: no matching conversion for functional-style cast from 'pointer' (aka 'unsigned short *') to 'WTF::String'
​https://bugs.webkit.org/show_bug.cgi?id=175477

Reviewed by Žan Doberšek.

• Shared/wpe/WebEventFactory.cpp:

(WebKit::singleCharacterStringForKeyEvent): Cast to UChar* to make
compiler choose the correct WTF::String constructor.

5:28 AM Changeset in webkit [220584] by clopez@igalia.com

• 2 edits in trunk/Source/WebDriver

Fix build warning in WebDriverService.h
​https://bugs.webkit.org/show_bug.cgi?id=166682

Unreviewed build fix.

• WebDriverService.h: Fixes the warning: class 'Capabilities' was previously declared as a struct [-Wmismatched-tags]

3:06 AM Changeset in webkit [220583] by Carlos Garcia Campos

• 7 edits in trunk

[Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
​https://bugs.webkit.org/show_bug.cgi?id=175378

Reviewed by Sergio Villar Senin.

Source/WebCore:

Bring back part of the code removed in r206732, to keep a reference to the SoupMessage in the
AuthenticationChallenge since it can be different to the resource message.

• platform/network/soup/AuthenticationChallenge.h:

(WebCore::AuthenticationChallenge::AuthenticationChallenge): Deleted.
(WebCore::AuthenticationChallenge::authenticationClient const): Deleted.
(WebCore::AuthenticationChallenge::soupAuth const): Deleted.
(WebCore::AuthenticationChallenge::setProposedCredential): Deleted.

• platform/network/soup/AuthenticationChallengeSoup.cpp:

(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::AuthenticationChallenge::platformCompare):

Source/WebKit:

In case of HTTPS resource with a proxy, libsoup uses a tunnel internally, that uses its own SoupMessage during
the proxy authentication. We were ignoring authentication requests for other messages.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::authenticateCallback): Only return early if the message does't match and it's not
HTTPS resource over a proxy.
(WebKit::NetworkDataTaskSoup::authenticate): Use the soup message from the authentication challenge.
(WebKit::NetworkDataTaskSoup::continueAuthenticate): Ditto.

Tools:

Add two test cases to check proxy authentication.

• TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:

(Tunnel::Tunnel):
(Tunnel::~Tunnel):
(Tunnel::connect):
(Tunnel::connected):
(serverCallback):
(ProxyAuthenticationTest::ProxyAuthenticationTest):
(ProxyAuthenticationTest::~ProxyAuthenticationTest):
(ProxyAuthenticationTest::proxyServerPortAsString):
(testWebViewAuthenticationProxy):
(testWebViewAuthenticationProxyHTTPS):
(beforeAll):

1:15 AM Changeset in webkit [220582] by calvaris@igalia.com

• 3 edits
  6 moves
  3 adds
  5 deletes in trunk/Tools

[GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
​https://bugs.webkit.org/show_bug.cgi?id=175428

Both ports share the GStreamer code as multimedia backend and till
not so long they were using different versions. Now they do use
the same versions and it does not make any sense anymore (and
neither had sense before) to have differences in the modulesets.

In this patch I created a GStreamer moduleset and referenced it
from both GTK+'s and WPE's. GStreamer patches were also moved there.

Reviewed by Žan Doberšek.

• gstreamer/jhbuild.modules: Added.
• gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
• gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
• gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
• gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
• gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
• gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
• gtk/jhbuild.modules:
• wpe/jhbuild.modules:
• wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
• wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
• wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
• wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
• wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.

Aug 10, 2017:

11:02 PM Changeset in webkit [220581] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

[Soup] Do not spawn the network process to setup cookie persistent storage
​https://bugs.webkit.org/show_bug.cgi?id=175424

Reviewed by Sergio Villar Senin.

The persistent storage configuration is saved and passed to network process as creation parameters, so we don't
need to spawn the network process to configure it, when it's created eventually it will use the configuration.

• UIProcess/soup/WebCookieManagerProxySoup.cpp:

(WebKit::WebCookieManagerProxy::setCookiePersistentStorage): Use sendToNetworkingProcess() instead of
endToNetworkingProcessRelaunchingIfNecessary().

11:01 PM Changeset in webkit [220580] by Carlos Garcia Campos

• 4 edits in trunk/Source/WebKit

[GTK][WPE] Assertion failure in TimerBase inside WebCore::IconRecord::setImageData
​https://bugs.webkit.org/show_bug.cgi?id=173866
<rdar://problem/33122050>

Reviewed by Michael Catanzaro.

IconDatabase creates and destroys IconRecord objects in both database and main thread. If the IconRecord has a
valid icon, its Image could be created in one thread and destroyed in another, something that is not expected to
happen, because Image has a Timer member. Since we have all the data and we are decoding it right after creating
the Image, we don't really need to keep the Image object around, we could simply take a reference of the encoded
data and the decoded native image to be returned by synchronousIconForPageURL().

• UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::IconRecord::image): Return NativeImagePtr now.
(WebKit::IconDatabase::IconRecord::setImageData): Create a BitmapImage to decode it and keep a reference to the
encoded data and decoded native image.
(WebKit::IconDatabase::IconRecord::snapshot const): Use m_imageData to get the encoded data.
(WebKit::IconDatabase::synchronousIconForPageURL): Return the native image and whether the icon is known or not.
(WebKit::IconDatabase::IconRecord::loadImageFromResource): Deleted.

• UIProcess/API/glib/IconDatabase.h:
• UIProcess/API/glib/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously): Use new API.

10:31 PM Changeset in webkit [220579] by mark.lam@apple.com

• 18 edits in trunk/Source

Make the MASM_PROBE mechanism mandatory for DFG and FTL builds.
​https://bugs.webkit.org/show_bug.cgi?id=175446
<rdar://problem/33836545>

Reviewed by Saam Barati.

Source/JavaScriptCore:

• assembler/AbstractMacroAssembler.h:
• assembler/MacroAssembler.cpp:

(JSC::MacroAssembler::probe):

• assembler/MacroAssembler.h:
• assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::trustedImm32FromPtr):

• assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::trustedImm32FromPtr):

• assembler/MacroAssemblerPrinter.cpp:
• assembler/MacroAssemblerPrinter.h:
• assembler/MacroAssemblerX86Common.cpp:
• assembler/testmasm.cpp:

(JSC::isSpecialGPR):
(JSC::testProbeModifiesProgramCounter):
(JSC::run):

• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::print):

• b3/air/AirPrintSpecial.cpp:
• b3/air/AirPrintSpecial.h:

Source/WTF:

This is needed in order to support ​https://bugs.webkit.org/show_bug.cgi?id=174645.
One consequence of this is that the DFG will now be disabled for the MIPS and
Windows ports. See:

​https://bugs.webkit.org/show_bug.cgi?id=175447
​https://bugs.webkit.org/show_bug.cgi?id=175449

Also, we should only ENABLE_SIGNAL_BASED_VM_TRAPS if the DFG is enabled. It was
never meaningful to use SIGNAL_BASED_VM_TRAPS with the baseline JIT anyway. This
is a mis-configuration error that is now fixed.

• wtf/Platform.h:

9:47 PM Changeset in webkit [220578] by mitz@apple.com

• 4 edits in trunk/Source

Restored svn:ignore values that went missing when the project got renamed.

Source/WebKit:

• WebKit.xcodeproj: Added property svn:ignore.

Source/WebKitLegacy:

• WebKitLegacy.xcodeproj: Added property svn:ignore.

9:22 PM Changeset in webkit [220577] by mitz@apple.com

• 6 edits in trunk/Source/WebCore

Fixed building for macOS 10.12 with the macOS 10.13 SDK.

Suppressed the unguarded-availability-new warning around uses of AVSampleBufferAudioRenderer
and AVSampleBufferRenderSynchronizer. Even though the 10.13 SDK declares them as available
starting in that release, they have been available as SPI earlier.

• platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setHasAvailableAudioSample):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeAudioRenderer):

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVSampleBufferErrorListener beginObservingRenderer:]):
(-[WebAVSampleBufferErrorListener stopObservingRenderer:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::rendererDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::flush):

8:37 PM Changeset in webkit [220576] by jmarcell@apple.com

• 2 edits in branches/safari-604.1.38.1-branch/Source/WebKit

Cherry-pick r220505. rdar://problem/33829962

8:06 PM Changeset in webkit [220575] by commit-queue@webkit.org

• 1 edit
  4 adds in trunk/Source/WebInspectorUI

Web Inspector: Add three.js in preparation for layer visualization.
​https://bugs.webkit.org/show_bug.cgi?id=174798

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-10
Reviewed by Brian Burg.

• UserInterface/External/three.js/LICENSE: Added.
• UserInterface/External/three.js/OrbitControls.js: Added.
• UserInterface/External/three.js/three.js: Added.

7:59 PM Changeset in webkit [220574] by beidson@apple.com

• 10 edits
  7 moves in trunk/Source

Rename the source files for the WTF persistent coders.
​https://bugs.webkit.org/show_bug.cgi?id=175441

Reviewed by Tim Horton.

Source/WebCore:

• platform/network/NetworkLoadMetrics.h:

Source/WebKit:

• NetworkProcess/cache/NetworkCacheCoders.h:
• NetworkProcess/cache/NetworkCacheKey.cpp:
• NetworkProcess/cache/NetworkCacheKey.h:
• UIProcess/API/APIContentRuleListStore.cpp:

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:

• wtf/persistence/PersistentCoder.h: Renamed from Source/WTF/wtf/persistence/Coder.h.
• wtf/persistence/PersistentCoders.cpp: Renamed from Source/WTF/wtf/persistence/Coders.cpp.
• wtf/persistence/PersistentCoders.h: Renamed from Source/WTF/wtf/persistence/Coders.h.
• wtf/persistence/PersistentDecoder.cpp: Renamed from Source/WTF/wtf/persistence/Decoder.cpp.
• wtf/persistence/PersistentDecoder.h: Renamed from Source/WTF/wtf/persistence/Decoder.h.
• wtf/persistence/PersistentEncoder.cpp: Renamed from Source/WTF/wtf/persistence/Encoder.cpp.
• wtf/persistence/PersistentEncoder.h: Renamed from Source/WTF/wtf/persistence/Encoder.h.

7:58 PM Changeset in webkit [220573] by jmarcell@apple.com

• 2 edits in branches/safari-604.1.38.0-branch/Source/WebKit

Cherry-pick r220505. rdar://problem/33829964

7:17 PM Changeset in webkit [220572] by don.olmstead@sony.com

• 2 edits in trunk/Tools

Unreviewed, adding Ross Kirsling to contributors.json\n\n* Scripts/webkitpy/common/config/contributors.json:\n

6:47 PM Changeset in webkit [220571] by wilander@apple.com

• 2 edits in trunk/Source/WebKit

Resource Load Statistics: Increase grandfathering time to 7 days
​https://bugs.webkit.org/show_bug.cgi?id=175414
<rdar://problem/33818046>

Reviewed by Brent Fulgham.

• UIProcess/WebResourceLoadStatisticsStore.h:

6:41 PM Changeset in webkit [220570] by n_wang@apple.com

• 2 edits in trunk/LayoutTests

Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175272
<rdar://problem/33756962>

Since accessibilityPress is async, we shouldn't rely on the timeout.

Reviewed by Chris Fleizach.

• accessibility/press-target-uses-text-descendant-node.html:

5:41 PM Changeset in webkit [220569] by Yusuke Suzuki

• 3 edits in trunk/Source/WebCore

Make ThreadGlobalData RefCounted for web thread
​https://bugs.webkit.org/show_bug.cgi?id=175439

Reviewed by Mark Lam.

When the web thread is enabled, we share ThreadGlobalData between the web thread and the main thread.
The problem happens when the main thread is dying. It could start deallocating TLS and the web
thread may see the destructed ThreadGlobalData.

Even though, the current implementation is safe because the main thread do not perform TLS deallocation
in the Darwin environment. But this is not true in Windows. And we should not rely on this condition
that depends on the platforms.

In this patch, we make ThreadGlobalData ThreadSafeRefCounted. This type verbosely describes that
ThreadGlobalData could be shared between threads when the web thread enabled. And make the life time
management simple instead of relying on the platform dependent TLS implementation.

• platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):

• platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::cachedResourceRequestInitiators): Deleted.
(WebCore::ThreadGlobalData::eventNames): Deleted.
(WebCore::ThreadGlobalData::threadTimers): Deleted.
(WebCore::ThreadGlobalData::qualifiedNameCache): Deleted.
(WebCore::ThreadGlobalData::cachedConverterICU): Deleted.
(WebCore::ThreadGlobalData::cachedConverterTEC): Deleted.

5:41 PM Changeset in webkit [220568] by wilander@apple.com

• 2 edits in trunk/Source/WebKit

Resource Load Statistics: Add significant figures to telemetry calls
​https://bugs.webkit.org/show_bug.cgi?id=175442
<rdar://problem/33834834>

Reviewed by Brent Fulgham.

With this change, logged values are allowed to have 3 significant figures
as opposed to today's 0 which is wrong.

• UIProcess/WebResourceLoadStatisticsTelemetry.cpp:

(WebKit::submitTopList):
(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):

5:36 PM Changeset in webkit [220567] by Yusuke Suzuki

• 4 edits in trunk

Unreviewed, attempt to fix build failure with VC2017

Source/WTF:

• wtf/PriorityQueue.h:

Tools:

• TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(TEST):

5:36 PM Changeset in webkit [220566] by Yusuke Suzuki

• 3 edits in trunk/Source/WebCore

[JSC] Use @toNumber in builtins
​https://bugs.webkit.org/show_bug.cgi?id=172692

Reviewed by Sam Weinig.

Use @toNumber bytecode intrinsic. It emits op_to_number, which efficiently converts
a given argument to a number.

• Modules/streams/ReadableByteStreamInternals.js:

(privateInitializeReadableByteStreamController):
(readableByteStreamControllerRespond):

• Modules/streams/StreamInternals.js:

(validateAndNormalizeQueuingStrategy):
(enqueueValueWithSize):

5:29 PM Changeset in webkit [220565] by Yusuke Suzuki

• 2 edits in trunk/Tools

Unreviewed, suppress warnings on GCC

• TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

(TestWebKitAPI::CheckedArithmeticTester::run):

5:23 PM Changeset in webkit [220564] by Matt Lewis

• 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

• platform/ios-11/TestExpectations:

4:57 PM Changeset in webkit [220563] by mitz@apple.com

• 2 edits in trunk/Tools

[Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
​https://bugs.webkit.org/show_bug.cgi?id=173223

Reviewed by Tim Horton.

The rebuilds were happening due to a difference in the compiler options that the IDE and
xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
Advanced when a Custom Absolute path is selected.

• Scripts/webkitdirs.pm:

(determineBaseProductDir):

4:42 PM Changeset in webkit [220562] by Yusuke Suzuki

• 7 edits
  1 copy in trunk

Run more WTF tests
​https://bugs.webkit.org/show_bug.cgi?id=174970

Reviewed by Michael Catanzaro.

Source/WTF:

CHAR_BIT is not defined.

• wtf/LEBDecoder.h:

Tools:

Some of WTF tests are not executed in non Apple ports while they are generic ones.
This patch adds these tests to non-Apple port TestWebKitAPI.
Currently, we do not add Signals.cpp since it depends on signal functionality.

• TestWebKitAPI/CMakeLists.txt:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(isHigherPriority):
(TEST):

• TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.

(TEST):

• TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:

(TEST):

4:21 PM Changeset in webkit [220561] by Ryan Haddad

• 3 edits
  2 copies
  3 adds in branches/safari-604.1.38.1-branch/LayoutTests

Unreviwed test gardening. rdar://problem/33789505

• imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt:
• imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt:
• platform/mac-highsierra/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
• platform/mac-highsierra/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt.
• platform/mac-highsierra/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt.

4:20 PM Changeset in webkit [220560] by jmarcell@apple.com

• 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

4:18 PM Changeset in webkit [220559] by jmarcell@apple.com

• 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

4:16 PM Changeset in webkit [220558] by jmarcell@apple.com

• 7 edits in branches/safari-604-branch/Source

Versioning.

4:14 PM Changeset in webkit [220557] by jmarcell@apple.com

• 1 copy in tags/Safari-604.2.2

Tag Safari-604.2.2.

4:00 PM Changeset in webkit [220556] by mark.lam@apple.com

• 15 edits in trunk/Source

Apply the UNLIKELY macro to some unlikely things.
​https://bugs.webkit.org/show_bug.cgi?id=175440
<rdar://problem/33834767>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::jettison):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::disassemble):

• dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalizeCommon):

• dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileOSRExit):

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):

• ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeCommon):

• ftl/FTLLink.cpp:

(JSC::FTL::link):

• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::compileWithoutLinking):
(JSC::JIT::link):

• runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::installCode):

• runtime/VM.cpp:

(JSC::VM::VM):

Source/WebKit:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getBytecodeProfile):

3:57 PM Changeset in webkit [220555] by Ryan Haddad

• 2 edits
  46 adds in trunk/LayoutTests

Unreviewed test gardening for High Sierra.

• platform/mac-highsierra/css1/basic/inheritance-expected.txt: Added.
• platform/mac-highsierra/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Added.
• platform/mac-highsierra/css2.1/t0805-c5522-brdr-02-e-expected.txt: Added.
• platform/mac-highsierra/css3/selectors3/html/css3-modsel-18-expected.txt: Added.
• platform/mac-highsierra/css3/selectors3/xhtml/css3-modsel-18-expected.txt: Added.
• platform/mac-highsierra/css3/selectors3/xml/css3-modsel-18-expected.txt: Added.
• platform/mac-highsierra/fast/block/basic/001-expected.txt: Added.
• platform/mac-highsierra/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
• platform/mac-highsierra/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
• platform/mac-highsierra/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
• platform/mac-highsierra/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
• platform/mac-highsierra/fast/css/css3-nth-child-expected.txt: Added.
• platform/mac-highsierra/fast/css/text-overflow-input-expected.txt: Added.
• platform/mac-highsierra/fast/dom/34176-expected.txt: Added.
• platform/mac-highsierra/fast/dom/clone-node-dynamic-style-expected.txt: Added.
• platform/mac-highsierra/fast/forms/basic-inputs-expected.txt: Added.
• platform/mac-highsierra/fast/forms/input-value-expected.txt: Added.
• platform/mac-highsierra/fast/forms/plaintext-mode-2-expected.txt: Added.
• platform/mac-highsierra/fast/invalid/003-expected.txt: Added.
• platform/mac-highsierra/fast/invalid/004-expected.txt: Added.
• platform/mac-highsierra/fast/invalid/nestedh3s-expected.txt: Added.
• platform/mac-highsierra/fast/selectors/018-expected.txt: Added.
• platform/mac-highsierra/fast/table/frame-and-rules-expected.txt: Added.
• platform/mac-highsierra/fast/text/atsui-multiple-renderers-expected.txt: Added.
• platform/mac-highsierra/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.
• platform/mac-highsierra/fast/text/font-weights-expected.txt: Added.
• platform/mac-highsierra/fast/text/font-weights-zh-expected.txt: Added.
• platform/mac-highsierra/fast/text/indic-expected.txt: Added.
• platform/mac-highsierra/fast/text/international/complex-character-based-fallback-expected.txt:
• platform/mac-highsierra/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
• platform/mac-highsierra/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
• platform/mac-highsierra/svg/batik/text/textStyles-expected.txt: Added.
• platform/mac-highsierra/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
• platform/mac-highsierra/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.

3:44 PM Changeset in webkit [220554] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.38.1.4

Tag Safari-604.1.38.1.4.

3:42 PM Changeset in webkit [220553] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Turn on support for Beacon API by default in STP
​https://bugs.webkit.org/show_bug.cgi?id=175445
<rdar://problem/33836379>

Reviewed by Youenn Fablet.

• Shared/WebPreferencesDefinitions.h:

3:39 PM Changeset in webkit [220552] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.38.0.4

Tag Safari-604.1.38.0.4.

3:15 PM Changeset in webkit [220551] by n_wang@apple.com

• 6 edits
  3 adds in trunk

AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
​https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/33782159>

Reviewed by Chris Fleizach.

Source/WebCore:

The issue here is that we manualy set the parent object of the AccessibilitySVGRoot object
and there are chances that the parent doesn't detach it properly during the parent's destroying
process. Accessing the stale parent object will lead to a crash.
Fixed this by making the parent object a weak pointer so we don't access an invalid memory.

Test: accessibility/add-children-pseudo-element.html

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):

• accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::createWeakPtr):

• accessibility/AccessibilitySVGRoot.cpp:

(WebCore::AccessibilitySVGRoot::AccessibilitySVGRoot):
(WebCore::AccessibilitySVGRoot::setParent):
(WebCore::AccessibilitySVGRoot::parentObject const):

• accessibility/AccessibilitySVGRoot.h:

LayoutTests:

• accessibility/add-children-pseudo-element-expected.txt: Added.
• accessibility/add-children-pseudo-element.html: Added.
• accessibility/resources/svg-circle.svg: Added.

3:08 PM Changeset in webkit [220550] by Ryan Haddad

• 2 edits in trunk/Source/WebKit

Fix iOS simulator build after change "[WTF] Move TextStream into WTF"
​https://bugs.webkit.org/show_bug.cgi?id=175211

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-10
Reviewed by Myles C. Maxfield.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollByContentOffset:]):
(-[WKWebView _navigationGestureDidBegin]):

2:51 PM Changeset in webkit [220549] by Chris Dumez

• 19 edits
  4 adds in trunk

[Beacon] Do connect-src CSP check on redirects as well
​https://bugs.webkit.org/show_bug.cgi?id=175410
<rdar://problem/33815470>

Reviewed by Youenn Fablet.

Source/WebCore:

Pass ContentSecurityPolicy object to createPingHandle so that we can send
enough data to the NetworkProcess so do CSP checks for Ping loads such
as Beacon. For the IPC, we serialize the ContentSecurityPolicy's response
headers. Those headers are now cached in ContentSecurityPolicy for
performance reasons. CSP headers are rarely updated in practice but
sendBeacon() may get called repeatedly for a given document.

Tests: http/wpt/beacon/connect-src-beacon-redirect-allowed.sub.html

http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html

• loader/LoaderStrategy.h:
• loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):

• loader/PingLoader.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

• page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::responseHeaders const):
(WebCore::ContentSecurityPolicy::didReceiveHeader):

• page/csp/ContentSecurityPolicy.h:
• page/csp/ContentSecurityPolicyResponseHeaders.h:

(WebCore::ContentSecurityPolicyResponseHeaders::encode const):
(WebCore::ContentSecurityPolicyResponseHeaders::decode):

Source/WebKit:

Pass CSP Response headers to the NetworkProcess via NetworkResourceLoadParameters
when doing a PingLoad. This allows PingLoad to do CSP checks (in particular
connect-src ones) in case the ping load gets redirected. Those checks need to be
done on the NetworkProcess side at this point because there is no guarantee the
WebContent process is still around.

To do the CSP checks, PingLoad lazily reconstructs a ContentSecurityPolicy object
from the CSP response headers.

• NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

• NetworkProcess/NetworkResourceLoadParameters.h:
• NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::contentSecurityPolicy):

• NetworkProcess/PingLoad.h:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::createPingHandle):

• WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

Update createPingHandle() to take in ContentSecurityPolicy
object in but no behavior change for WK1.

• WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::createPingHandle):

• WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Add layout test coverage.

• http/wpt/beacon/connect-src-beacon-redirect-allowed.sub-expected.txt: Added.
• http/wpt/beacon/connect-src-beacon-redirect-allowed.sub.html: Added.
• http/wpt/beacon/connect-src-beacon-redirect-blocked.sub-expected.txt: Added.
• http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html: Added.

2:19 PM Changeset in webkit [220548] by Yusuke Suzuki

• 7 edits in trunk/Source

[WTF] ThreadSpecific should not introduce additional indirection
​https://bugs.webkit.org/show_bug.cgi?id=175187

Reviewed by Mark Lam.

Source/JavaScriptCore:

• runtime/Identifier.cpp:

Source/WebCore:

We drop ThreadSpecific::replace feature which is only used by
Web thread. Instead, we use ThreadSpecific<std::unique_ptr<T>> here.

While this std::unique_ptr<T> shares one instance between main thread
and web thread, this is the same to the current implementation. It is
safe because the web thread never finishes.

And for non-web thread implementation, we just use ThreadSpecific<T>,
since it is the most efficient.

• platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):
We also drop StringImpl::empty() call since it is not necessary now:
StringImpl::empty data is statically initialized by using constexpr.

• platform/ThreadGlobalData.h:

We make it FAST_ALLOCATED since it is previously allocated by fast malloc
in ThreadSpecific.

Source/WTF:

ThreadSpecific sets Data* to the TLS. And Data holds T*, which
is fast allocated actual data. But ideally, we should store T
instance directly in Data instead of introducing an additional
indirection.

This patch adds storage in Data in order to embed the instance of T. The constructor
for Data will invoke the constructor for T on the embedded storage. We also drop
ThreadSpecific::replace which is only used by the web thread to set its thread specific
ThreadGlobalData to the one shared from the main thread. The existing implementation
relies on the main thread and the web thread never exiting in order for the shared
ThreadGlobalData to stay alive. We can achieve the same semantics by using a
ThreadSpecific<std::unique_ptr<T>> to hold the ThreadGlobalData instance instead.

• wtf/ThreadSpecific.h:

(WTF::ThreadSpecific::Data::construct):
(WTF::ThreadSpecific::Data::Data):
We make it fast allocated since we previously allocated ThreadSpecific T data by fastMalloc.

(WTF::ThreadSpecific::Data::~Data):
(WTF::ThreadSpecific::Data::storagePointer const):
(WTF::canBeGCThread>::get):
We also drop RELEASE_ASSERT from ::get(). We already inserted this assert to setAndConstruct(),
so when creating the member to this TLS, we execute this release assert. So it is
not necessary to execute this assertion every time we get data from this TLS.

(WTF::canBeGCThread>::set):
(WTF::canBeGCThread>::destroy):
(WTF::canBeGCThread>::setAndConstruct):
(WTF::T):
(WTF::canBeGCThread>::replace): Deleted.

2:06 PM Changeset in webkit [220547] by jmarcell@apple.com

• 12 edits in tags/Safari-604.2.1.1

Cherry-pick r220473. rdar://problem/33834103

2:05 PM Changeset in webkit [220546] by jmarcell@apple.com

• 7 edits in tags/Safari-604.2.1.1/Source

Versioning.

1:50 PM Changeset in webkit [220545] by jmarcell@apple.com

• 1 copy in tags/Safari-604.2.1.1

Tag Safari-604.2.1.1.

1:49 PM Changeset in webkit [220544] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Remove obsolete link from webkit-queues status page
​https://bugs.webkit.org/show_bug.cgi?id=175337

Patch by obinna obike <​oobike@apple.com> on 2017-08-10
Reviewed by Aakash Jain.

• QueueStatusServer/templates/recentstatus.html:

Removed the link to the ews-watcher server.

1:47 PM Changeset in webkit [220543] by Jonathan Bedard

• 2 edits in trunk/LayoutTests

Mark webgl/webgl-box-shadow.html and webgl/webgl-border.html as failing for ios-device.
​https://bugs.webkit.org/show_bug.cgi?id=175437

Unreviewed test gardening.

• platform/ios-device/TestExpectations:

1:34 PM Changeset in webkit [220542] by BJ Burg

• 5 edits
  1 add in trunk

WKPreferences should conform to NSCopying
​https://bugs.webkit.org/show_bug.cgi?id=175303
<rdar://problem/33764939>

Reviewed by Dan Bernstein.

Source/WebKit:

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Add conformance in the private header, as there is not consensus that this
needs to be API.

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences copyWithZone:]):
Copy the wrapped WebPreferences instance and return its wrapper.

Tools:

Add unit test to make sure a WKPreference and its copy are
not aliased to each other or affect each other's properties.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.

(TEST):

12:39 PM Changeset in webkit [220541] by timothy_horton@apple.com

• 2 edits in trunk/Source/WTF

Fix a silly typo in Compiler.h

• wtf/Compiler.h:

Heature, indeed.

12:31 PM Changeset in webkit [220540] by Michael Catanzaro

• 6 edits in trunk

REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
​https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Alberto Lopez Perez.

.:

• Source/cmake/FindGeoClue2.cmake:

Source/WebCore:

Also stop using GEOCLUE_LIBRARIES and GEOCLUE_INCLUDE_DIRS, since they are empty. Apparently
we have not actually been using the client library at all this whole time, only the D-Bus
interface.

• PlatformGTK.cmake:

Source/WebKit:

• PlatformGTK.cmake:

12:28 PM Changeset in webkit [220539] by beidson@apple.com

• 14 edits
  2 copies
  14 adds in trunk

Add ServiceWorkerJob.
​https://bugs.webkit.org/show_bug.cgi?id=175241

Reviewed by Tim Horton.

Source/WebCore:

Test: http/tests/workers/service/basic-register.html

This patch does a few things:

• Adds the spec concept of a ServiceWorkerJob (in the WebProcess, at least)
• Adds a ServiceWorkerProvider interface for WebKit to implement
• Actually creates a job for service worker registration and "schedules" it, though it always immediately errors out the promise.

Actually queuing jobs and executing asynchronously is coming up soon.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:

• dom/Document.cpp:

(WebCore::Document::sessionID const):

• dom/Document.h:

• workers/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::~ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::jobDidFinish):

• workers/ServiceWorkerContainer.h:

• workers/ServiceWorkerJob.cpp: Added.

(WebCore::ServiceWorkerJob::ServiceWorkerJob):
(WebCore::ServiceWorkerJob::~ServiceWorkerJob):
(WebCore::ServiceWorkerJob::failedWithException):

• workers/ServiceWorkerJob.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.

(WebCore::ServiceWorkerJob::createRegisterJob):
(WebCore::ServiceWorkerJob::identifier const):

• workers/ServiceWorkerJobClient.h: Added.

(WebCore::ServiceWorkerJobClient::~ServiceWorkerJobClient):

• workers/ServiceWorkerProvider.cpp: Added.

(WebCore::ServiceWorkerProvider::singleton):
(WebCore::ServiceWorkerProvider::setSharedProvider):

• workers/ServiceWorkerProvider.h: Added.
• workers/ServiceWorkerRegistrationOptions.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.
• workers/ServiceWorkerRegistrationParameters.cpp: Added.
• workers/ServiceWorkerRegistrationParameters.h: Added.

Source/WebKit:

• CMakeLists.txt:
• WebKit.xcodeproj/project.pbxproj:

• WebProcess/Storage/WebServiceWorkerProvider.cpp: Added.

(WebKit::WebServiceWorkerProvider::singleton):
(WebKit::WebServiceWorkerProvider::WebServiceWorkerProvider):
(WebKit::WebServiceWorkerProvider::scheduleJob):

• WebProcess/Storage/WebServiceWorkerProvider.h: Added.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

LayoutTests:

Verifies that the "serviceWorker.register()" job we currently schedule fails as expected.

• http/tests/workers/service/basic-register-expected.txt: Added.
• http/tests/workers/service/basic-register.html: Added.
• http/tests/workers/service/resources/basic-register.js: Added.
• http/tests/workers/service/resources/empty-worker.js: Added.
• platform/mac-wk1/TestExpectations:
• platform/win/TestExpectations:

12:05 PM Changeset in webkit [220538] by timothy_horton@apple.com

• 10 edits in trunk

Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
​https://bugs.webkit.org/show_bug.cgi?id=175436
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/JavaScriptCore:

• interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):

Source/WebCore:

• platform/audio/cocoa/MediaSessionManagerCocoa.cpp:

(PlatformMediaSessionManager::updateSessionState):

• platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):

Source/WebKit:

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData):

Tools:

• TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:

(TestWebKitAPI::TEST_F):

11:57 AM Changeset in webkit [220537] by Lucas Forschler

• 2 edits in trunk/Tools

Fix duplicated code from r220534.

Unreviewed cleanup.

• Scripts/bisect-builds:

11:47 AM Changeset in webkit [220536] by jiewen_tan@apple.com

• 4 edits
  1 add in trunk/Tools

[WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
​https://bugs.webkit.org/show_bug.cgi?id=175344
<rdar://problem/28507240>

Reviewed by Alexey Proskuryakov.

Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
Finally enable the existing tests for iOS.

• TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
• TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:

11:27 AM Changeset in webkit [220535] by commit-queue@webkit.org

• 3 edits
  3 deletes in trunk

Unreviewed, rolling out r220463.
​https://bugs.webkit.org/show_bug.cgi?id=175435

unaccepted fix (Requested by n_wang on #webkit).

Reverted changeset:

"AX: crash at
WebCore::AccessibilityObject::supportsARIALiveRegion() const +
24"
​https://bugs.webkit.org/show_bug.cgi?id=175340
​http://trac.webkit.org/changeset/220463

11:22 AM Changeset in webkit [220534] by Lucas Forschler

• 1 edit
  1 add in trunk/Tools

Write a tool to bisect WebKit builds
​https://bugs.webkit.org/show_bug.cgi?id=174596

Reviewed by Dean Johnson and Kocsen Chung.

• Scripts/bisect-builds: Added.

(bisect_builds): main bisection algorithm
(download_archive):download an archive from S3 using existing tools
(extract_archive):extract an archive using existing tools
(find_le):Find rightmost value less than or equal to x
(find_ge):Find leftmost item greater than or equal to x
(get_api_url):generate url for the rest api/database
(get_indices_from_revisions):convert revisions to list indexes for bisection
(get_sorted_revisions):retrieve sorted revision list
(get_s3_location_for_revision):calculate the S3 archive storage location
(parse_args):parse command line arguments
(pick_next_build):compute the next build to bisect
(prompt_did_reproduce):prompt user for direction for bisection
(set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
(test_archive):Platform specific logic to test downloaded archive
(minified_platforms):return a list of minified platforms in the database
(unminified_platforms):return a list of full platforms in the database
(is_supported_platform):check if platform is supported
(validate_options):validate command line options
(main):

11:17 AM Changeset in webkit [220533] by Lucas Forschler

• 1 edit
  1 delete in trunk/Tools

Remove bisect-builds script.
​https://bugs.webkit.org/show_bug.cgi?id=175433

Reviewed by Aakash Jain.

• Scripts/bisect-builds: Removed.

10:04 AM Changeset in webkit [220532] by Michael Catanzaro

• 21 edits
  5 deletes in trunk

Remove ENABLE_GAMEPAD_DEPRECATED
​https://bugs.webkit.org/show_bug.cgi?id=175361

Reviewed by Carlos Garcia Campos.

.:

• Source/cmake/FindGUdev.cmake: Removed.
• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsMac.cmake:
• Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• CMakeLists.txt:
• Configurations/FeatureDefines.xcconfig:
• PlatformGTK.cmake:
• PlatformWPE.cmake:
• platform/Linux.cmake: Removed.
• platform/gamepad/deprecated/Gamepads.h: Removed.
• platform/gamepad/glib/GamepadsGlib.cpp: Removed.
• platform/gamepad/linux/GamepadDeviceLinux.cpp: Removed.
• platform/gamepad/linux/GamepadDeviceLinux.h: Removed.

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

9:59 AM Changeset in webkit [220531] by mmaxfield@apple.com

• 3 edits in trunk/Source/WebCore

Addressing post-review comments after r219173.
​https://bugs.webkit.org/show_bug.cgi?id=174149

Unreviewed.

• css/CSSFontStyleValue.h:
• editing/EditingStyle.cpp:

(WebCore::identifierForStyleProperty):

9:53 AM Changeset in webkit [220530] by Ryan Haddad

• 4 edits in trunk/LayoutTests

Update TestExpectations for imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors.html.
​https://bugs.webkit.org/show_bug.cgi?id=170698

Unreviewed test gardening.

• TestExpectations: Skip test on debug because it times out on every run.
• platform/ios/TestExpectations: Mark as flaky on Release.
• platform/mac/TestExpectations: Ditto.

9:33 AM Changeset in webkit [220529] by clopez@igalia.com

• 4 edits in trunk

REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
​https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Garcia Campos.

.:

Fix the pkg-config file name.
We really require geoclue-2.0 and not libgeoclue-2.0.

• Source/cmake/FindGeoClue2.cmake:

Tools:

• gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.

8:44 AM Changeset in webkit [220528] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Try to fix windows build.

• style/StyleUpdate.h:

(WebCore::Style::TextUpdate::TextUpdate):

5:25 AM Changeset in webkit [220527] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit

[GTK] Don't use --whole-archive linking flags for the WebKit2 target libraries
​https://bugs.webkit.org/show_bug.cgi?id=175416

Reviewed by Carlos Garcia Campos.

• PlatformGTK.cmake: Drop the ADD_WHOLE_ARCHIVE_TO_LIBRARIES instruction

for the WebKit2 target. This unnecessarily bundles complete archive
files both into the main .so library as well as single executables that
are linked against the WebKit2 target.

5:01 AM Changeset in webkit [220526] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Add Ms2ger as contributor.
​https://bugs.webkit.org/show_bug.cgi?id=175325

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-10
Reviewed by Carlos Alberto Lopez Perez.

• Scripts/webkitpy/common/config/contributors.json:

4:02 AM Changeset in webkit [220525] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[GTK] Crashes in WebCore::PasteboardHelper::fillSelectionData when source file of drag is unavailable
​https://bugs.webkit.org/show_bug.cgi?id=174161

Reviewed by Xabier Rodriguez-Calvar.

In r219385 we changed the early return in fillSelectionData() to check the selection data length instead of the
data pointer. However, the gtk_selection_data_get_length() can return -1, so we need to check also if the value
less than 0. The case of setting an empty string could be valid depending on the target type, so it's better to
return early only when data lenght is less than 0 and handle the 0 length case in each target.

• platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillSelectionData):

3:44 AM Changeset in webkit [220524] by magomez@igalia.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Update expectations of several tests failing at r220516.

• platform/gtk/TestExpectations:

3:20 AM Changeset in webkit [220523] by Antti Koivisto

• 9 edits in trunk/Source/WebCore

Text renderer updates should be done by RenderTreeUpdater
​https://bugs.webkit.org/show_bug.cgi?id=175417

Reviewed by Andreas Kling.

All render tree mutations should be done by RenderTreeUpdater. Currently
Text::updateRendererAfterContentChange calls RenderText::setTextWithOffset directly.

• dom/Document.cpp:

(WebCore::Document::updateTextRenderer):

Add range argument.

• dom/Document.h:
• dom/Text.cpp:

(WebCore::Text::updateRendererAfterContentChange):

Remove call to setTextWithOffset and pass the range to updateTextRenderer

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateTextRenderer):

Call setTextWithOffset here.

• style/RenderTreeUpdater.h:
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree):

• style/StyleUpdate.cpp:

(WebCore::Style::Update::textUpdate const):
(WebCore::Style::Update::addText):

Add TextUpdate struct similar to ElementUpdate to pass the range to the RenderTreeUpdater.

• style/StyleUpdate.h:

1:37 AM Changeset in webkit [220522] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Unreviewed GTK+ build fix for ENABLE_GLES2=ON.

• platform/graphics/texmap/TextureMapperGLHeaders.h:

Define various GL constants that are not provided in GLES2 headers
but are only leveraged in OpenGL calls if at runtime the underlying
OpenGL is GLES2-capable.

12:39 AM Changeset in webkit [220521] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebCore

[TexMap] Remove GraphicsContext3D usage from BitmapTexturePool
​https://bugs.webkit.org/show_bug.cgi?id=175319

Reviewed by Carlos Garcia Campos.

Drop the GraphicsContext3D reference in BitmapTexturePool now
that the BitmapTextureGL doesn't require it anymore.

No new tests -- no change in behavior.

• platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::BitmapTexturePool):

• platform/graphics/texmap/BitmapTexturePool.h:
• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::TextureMapperGL):

12:30 AM Changeset in webkit [220520] by jmarcell@apple.com

• 21 edits in branches/safari-604-branch

Cherry-pick r220459. rdar://problem/33820790

12:20 AM Changeset in webkit [220519] by zandobersek@gmail.com

• 6 edits in trunk/Source/WebCore

[TexMap] Drop GraphicsContext3D usage from BitmapTextureGL
​https://bugs.webkit.org/show_bug.cgi?id=175317

Reviewed by Carlos Garcia Campos.

Have BitmapTextureGL use direct OpenGL API entrypoints and constants
instead of leveraging the GraphicsContext3D class. Any GraphicsContext3D
object passed to BitmapTextureGL would assume rendering to the GL context
that's current on that thread, translating method invocations to the
OpenGL API. We can do this by ourselves and benefit by avoiding allocating
GraphicsContext3D resources like the ANGLE compiler that are by most useful
for WebGL.

BitmapTextureGL::create() call sites are adjusted to stop passing a
GraphicsContext3D reference. BitmapTextureGL::bindAsSurface() doesn't need
a replacement for the passed-in GraphicsContext3D object since that object
originated from the TextureMapperGL instance, whose GraphicsContext3D is by
default of the render-to-current-context nature. Other changes are direct
translations of GraphicsContext3D methods to OpenGL API calls, or of
GraphicsContext3D values to OpenGL API constants.

No new tests -- no change in behavior.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):

• platform/graphics/texmap/BitmapTextureGL.cpp:

Also remove an unnecessary GraphicsContext.h header inclusion.
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bindAsSurface):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::copyFromExternalTexture):

• platform/graphics/texmap/BitmapTextureGL.h:

(WebCore::BitmapTextureGL::create):
(WebCore::BitmapTextureGL::textureTarget const):
(WebCore::BitmapTextureGL::internalFormat const):

• platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::createTexture):

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::createTexture):

Aug 9, 2017:

11:52 PM Changeset in webkit [220518] by jmarcell@apple.com

• 21 edits in branches/safari-604.1.38.1-branch

Cherry-pick r220459. rdar://problem/33820786

11:13 PM Changeset in webkit [220517] by jmarcell@apple.com

• 21 edits in branches/safari-604.1.38.0-branch

Cherry-pick r220459. rdar://problem/33820787

11:01 PM Changeset in webkit [220516] by Dewei Zhu

• 2 edits in trunk/Tools

Fix run-benchmark after r220483.
​https://bugs.webkit.org/show_bug.cgi?id=175415
<rdar://problem/33803003>

Reviewed by Ryosuke Niwa.

Update run-benchmark script to adapt new Timeout implementation introduced in r220483.

• Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:

(WebServerBenchmarkRunner._run_one_test):

10:58 PM Changeset in webkit [220515] by Michael Catanzaro

• 5 edits
  1 move
  2 deletes in trunk

[GTK] Remove support for geoclue1
​https://bugs.webkit.org/show_bug.cgi?id=164205

Reviewed by Carlos Garcia Campos.

.:

• Source/cmake/FindGeoClue.cmake: Removed.
• Source/cmake/OptionsGTK.cmake:

Source/WebCore:

• PlatformGTK.cmake:
• platform/geoclue/GeolocationProviderGeoclue.h:
• platform/geoclue/GeolocationProviderGeoclue1.cpp: Removed.
• platform/geoclue/GeolocationProviderGeoclue2.cpp: Removed.

9:31 PM Changeset in webkit [220514] by jmarcell@apple.com

• 12 edits in branches/safari-604-branch

Cherry-pick r220473. rdar://problem/33810961

9:31 PM Changeset in webkit [220513] by jmarcell@apple.com

• 3 edits
  4 adds in branches/safari-604-branch

Cherry-pick r220456. rdar://problem/33810950

9:31 PM Changeset in webkit [220512] by jmarcell@apple.com

• 3 edits in branches/safari-604-branch/Source/WebKitLegacy/mac

Cherry-pick r220429. rdar://problem/33810973

9:31 PM Changeset in webkit [220511] by jmarcell@apple.com

• 3 edits in branches/safari-604-branch/Source/JavaScriptCore

Cherry-pick r220346. rdar://problem/33810976

9:31 PM Changeset in webkit [220510] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220333. rdar://problem/33810934

9:31 PM Changeset in webkit [220509] by jmarcell@apple.com

• 3 edits in branches/safari-604-branch

Cherry-pick r220289. rdar://problem/33810941

9:31 PM Changeset in webkit [220508] by jmarcell@apple.com

• 2 edits in branches/safari-604-branch/Source/WebKitLegacy

Cherry-pick r220205. rdar://problem/33810980

9:19 PM Changeset in webkit [220507] by Chris Dumez

• 16 edits
  2 copies
  8 adds in trunk

Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
​https://bugs.webkit.org/show_bug.cgi?id=175401

Reviewed by Brady Eidson.

Source/WebKit:

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetBeaconAPIEnabled):
(WKPreferencesGetBeaconAPIEnabled):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

• config.h:

Source/WebKitLegacy/mac:

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences beaconAPIEnabled]): Deleted.
(-[WebPreferences setBeaconAPIEnabled:]): Deleted.

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

LayoutTests:

• platform/mac-elcapitan-wk2/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt.
• platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.
• platform/mac-wk1/TestExpectations:
• platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
• platform/mac-wk1/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.
• platform/mac-wk2/TestExpectations:
• platform/win/TestExpectations:
• platform/win/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt.
• platform/win/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.

9:13 PM Changeset in webkit [220506] by commit-queue@webkit.org

• 139 edits
  30 copies
  2 adds
  2 deletes in trunk

[PAL] Move spi/cocoa and spi/cg directories into PAL
​https://bugs.webkit.org/show_bug.cgi?id=175175

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-08-09
Reviewed by Myles C. Maxfield.

Source/WebCore:

• Modules/applepay/cocoa/PaymentCocoa.mm:
• Modules/applepay/cocoa/PaymentContactCocoa.mm:
• Modules/applepay/cocoa/PaymentMerchantSessionCocoa.mm:
• Modules/applepay/cocoa/PaymentMethodCocoa.mm:
• PlatformAppleWin.cmake:
• WebCore.xcodeproj/project.pbxproj:
• editing/cocoa/EditorCocoa.mm:
• editing/cocoa/HTMLConverter.mm:
• editing/ios/EditorIOS.mm:
• page/cocoa/ResourceUsageThreadCocoa.mm:
• page/mac/TextIndicatorWindow.mm:
• platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:
• platform/cocoa/DataDetectorsCoreSoftLink.h:
• platform/cocoa/MIMETypeRegistryCocoa.mm:
• platform/cocoa/NetworkExtensionContentFilter.mm:
• platform/cocoa/ParentalControlsContentFilter.mm:
• platform/cocoa/SleepDisablerCocoa.cpp:
• platform/graphics/Font.cpp:
• platform/graphics/Font.h:
• platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:
• platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
• platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:
• platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:
• platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
• platform/graphics/cg/ColorCG.cpp:
• platform/graphics/cg/GraphicsContextCG.cpp:
• platform/graphics/cg/ImageBufferCG.cpp:
• platform/graphics/cg/ImageBufferDataCG.cpp:
• platform/graphics/cg/ImageDecoderCG.cpp:
• platform/graphics/cg/NativeImageCG.cpp:
• platform/graphics/cocoa/FontCacheCoreText.cpp:
• platform/graphics/cocoa/FontCascadeCocoa.mm:
• platform/graphics/cocoa/FontCocoa.mm:
• platform/graphics/cocoa/FontDescriptionCocoa.cpp:
• platform/graphics/cocoa/FontPlatformDataCocoa.mm:
• platform/graphics/cocoa/IOSurface.mm:
• platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
• platform/graphics/cocoa/WebActionDisablingCALayerDelegate.h:
• platform/graphics/ios/FontAntialiasingStateSaver.h:
• platform/graphics/ios/FontCacheIOS.mm:
• platform/graphics/mac/ComplexTextControllerCoreText.mm:
• platform/graphics/mac/FontCacheMac.mm:
• platform/graphics/mac/GlyphPageMac.cpp:
• platform/graphics/win/FontCacheWin.cpp:
• platform/ios/LegacyTileCache.mm:
• platform/ios/LegacyTileGrid.mm:
• platform/ios/LegacyTileGridTile.mm:
• platform/ios/PlaybackSessionInterfaceAVKit.mm:
• platform/ios/QuickLook.mm:
• platform/ios/VideoFullscreenInterfaceAVKit.mm:
• platform/ios/WebAVPlayerController.h:
• platform/ios/WebAVPlayerController.mm:
• platform/ios/WebVideoFullscreenControllerAVKit.mm:
• platform/ios/wak/WKGraphics.mm:
• platform/mac/DragImageMac.mm:
• platform/mac/PlatformScreenMac.mm:
• platform/mac/PlaybackSessionInterfaceMac.mm:
• platform/mac/ThemeMac.mm:
• platform/mac/VideoFullscreenInterfaceMac.mm:
• platform/mac/WebPlaybackControlsManager.h:
• platform/mac/WebVideoFullscreenHUDWindowController.mm:
• platform/network/cocoa/CookieStorageObserver.mm:
• platform/network/cocoa/NetworkLoadMetrics.mm:
• platform/network/mac/AuthenticationMac.mm:
• platform/network/mac/ResourceHandleMac.mm:
• platform/spi/ios/DataDetectorsUISPI.h:
• platform/spi/mac/DataDetectorsSPI.h:
• platform/spi/mac/NSViewSPI.h:
• rendering/RenderThemeCocoa.mm:
• rendering/RenderThemeIOS.mm:
• rendering/RenderThemeMac.mm:

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:
• pal/PlatformAppleWin.cmake:
• pal/spi/cg/CoreGraphicsSPI.h: Renamed from Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h.

(CGFloatMin):

• pal/spi/cg/ImageIOSPI.h: Renamed from Source/WebCore/platform/spi/cg/ImageIOSPI.h.
• pal/spi/cocoa/AVKitSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/AVKitSPI.h.

(-[AVTouchBarPlaybackControlsControlling NS_ENUM]):

• pal/spi/cocoa/CFNSURLConnectionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CFNSURLConnectionSPI.h.
• pal/spi/cocoa/CoreTextSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CoreTextSPI.h.
• pal/spi/cocoa/DataDetectorsCoreSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h.
• pal/spi/cocoa/IOPMLibSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOPMLibSPI.h.
• pal/spi/cocoa/IOPSLibSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOPSLibSPI.h.
• pal/spi/cocoa/IOReturnSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOReturnSPI.h.
• pal/spi/cocoa/IOSurfaceSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOSurfaceSPI.h.
• pal/spi/cocoa/IOTypesSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOTypesSPI.h.
• pal/spi/cocoa/LinkPresentationSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h.
• pal/spi/cocoa/MachVMSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/MachVMSPI.h.
• pal/spi/cocoa/NEFilterSourceSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h.
• pal/spi/cocoa/NSAttributedStringSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSAttributedStringSPI.h.
• pal/spi/cocoa/NSButtonCellSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSButtonCellSPI.h.
• pal/spi/cocoa/NSCalendarDateSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSCalendarDateSPI.h.
• pal/spi/cocoa/NSColorSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSColorSPI.h.
• pal/spi/cocoa/NSExtensionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSExtensionSPI.h.
• pal/spi/cocoa/NSFileManagerSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSFileManagerSPI.h.
• pal/spi/cocoa/NSStringSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSStringSPI.h.
• pal/spi/cocoa/NSTouchBarSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSTouchBarSPI.h.
• pal/spi/cocoa/NSURLConnectionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLConnectionSPI.h.
• pal/spi/cocoa/NSURLDownloadSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLDownloadSPI.h.
• pal/spi/cocoa/NSURLFileTypeMappingsSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLFileTypeMappingsSPI.h.
• pal/spi/cocoa/PassKitSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/PassKitSPI.h.

(NS_ERROR_ENUM):

• pal/spi/cocoa/QuartzCoreSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h.
• pal/spi/cocoa/ServersSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/ServersSPI.h.
• pal/spi/cocoa/WebFilterEvaluatorSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/WebFilterEvaluatorSPI.h.
• pal/spi/cocoa/pthreadSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/pthreadSPI.h.

Source/WebKit:

• NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm:
• NetworkProcess/Downloads/mac/DownloadMac.mm:
• Platform/cocoa/SharedMemoryCocoa.cpp:
• Platform/mac/LayerHostingContext.mm:
• Shared/Cocoa/DataDetectionResult.mm:
• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
• Shared/cf/CookieStorageUtilsCF.mm:
• Shared/ios/InteractionInformationAtPosition.mm:
• Shared/mac/HangDetectionDisablerMac.mm:
• Shared/mac/RemoteLayerBackingStore.mm:
• Shared/mac/RemoteLayerTreePropertyApplier.mm:
• UIProcess/API/Cocoa/WKWebView.mm:
• UIProcess/API/mac/WKView.mm:
• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
• UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
• UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:
• UIProcess/Launcher/mac/ProcessLauncherMac.mm:
• UIProcess/ios/ViewGestureControllerIOS.mm:
• UIProcess/ios/WKContentView.mm:
• UIProcess/ios/WKContentViewInteraction.mm:
• UIProcess/ios/WKPDFPageNumberIndicator.mm:
• UIProcess/ios/WKScrollView.mm:
• UIProcess/mac/RemoteLayerTreeHost.mm:
• UIProcess/mac/ServicesController.mm:
• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
• UIProcess/mac/ViewGestureControllerMac.mm:
• UIProcess/mac/ViewSnapshotStore.mm:
• UIProcess/mac/WKViewLayoutStrategy.mm:
• WebProcess/Plugins/PDF/PDFPlugin.mm:
• WebProcess/WebPage/WebPage.cpp:
• WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
• WebProcess/cocoa/WebProcessCocoa.mm:

Source/WebKitLegacy/ios:

• Misc/WebNSStringExtrasIOS.m:
• WebCoreSupport/WebFixedPositionContent.mm:

Source/WebKitLegacy/mac:

• History/WebHistory.mm:
• Misc/WebDownload.mm:
• Misc/WebKitNSStringExtras.mm:
• Plugins/Hosted/NetscapePluginHostManager.mm:
• Plugins/WebPluginDatabase.mm:
• WebCoreSupport/WebFrameLoaderClient.mm:
• WebInspector/WebNodeHighlight.mm:
• WebView/WebHTMLView.mm:
• WebView/WebIndicateLayer.mm:
• WebView/WebView.mm:
• WebView/WebViewData.h:

Tools:

• DumpRenderTree/ios/PixelDumpSupportIOS.mm:
• DumpRenderTree/mac/DumpRenderTree.mm:
• TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
• WebKitTestRunner/ios/PlatformWebViewIOS.mm:

• Scripts/webkitpy/style/checker.py:
• Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier):

Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h

• Scripts/webkitpy/style/checkers/cpp.py:

(check_braces):

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_braces.CF_OPTIONS):
(WebKitStyleTest.test_braces):

Prevent CF_OPTIONS() from being handled as funtion definition.

8:21 PM Changeset in webkit [220505] by wilander@apple.com

• 2 edits in trunk/Source/WebKit

Resource Load Statistics: Increase grandfathering time to 3 days
​https://bugs.webkit.org/show_bug.cgi?id=175414
<rdar://problem/33818046>

Reviewed by Brent Fulgham.

• UIProcess/WebResourceLoadStatisticsStore.h:

7:11 PM Changeset in webkit [220504] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebKit

Invalidate PlaybackSessionManager in same fashion as VideoFullscreenManager.
​https://bugs.webkit.org/show_bug.cgi?id=175399
rdar://problem/33663344

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-08-09
Reviewed by Eric Carlson.

Invalidate PlaybackSessionManager when WebPage is destructed.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):

• WebProcess/cocoa/PlaybackSessionManager.h:
• WebProcess/cocoa/PlaybackSessionManager.mm:

(WebKit::PlaybackSessionManager::~PlaybackSessionManager):
(WebKit::PlaybackSessionManager::invalidate):

6:15 PM Changeset in webkit [220503] by don.olmstead@sony.com

• 258 edits
  2 moves in trunk

[WTF] Move TextStream into WTF
​https://bugs.webkit.org/show_bug.cgi?id=175211

Reviewed by Myles C. Maxfield.

Source/WebCore:

No new tests. No change in behavior.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• dom/ComposedTreeIterator.cpp:
• dom/Position.cpp:
• dom/Position.h:
• dom/Range.cpp:

(WebCore::operator<<):

• dom/Range.h:
• dom/ViewportArguments.cpp:
• dom/ViewportArguments.h:
• editing/VisiblePosition.cpp:
• editing/VisiblePosition.h:
• editing/VisibleSelection.cpp:
• editing/VisibleSelection.h:
• html/HTMLVideoElement.cpp:
• html/canvas/CanvasRenderingContext2D.cpp:
• page/FrameView.cpp:
• page/ViewportConfiguration.cpp:
• page/ViewportConfiguration.h:
• page/WheelEventDeltaFilter.cpp:
• page/animation/CSSPropertyAnimation.cpp:
• page/scrolling/AsyncScrollingCoordinator.cpp:
• page/scrolling/ScrollingConstraints.cpp:
• page/scrolling/ScrollingConstraints.h:
• page/scrolling/ScrollingCoordinator.cpp:
• page/scrolling/ScrollingCoordinator.h:
• page/scrolling/ScrollingStateFixedNode.cpp:
• page/scrolling/ScrollingStateFixedNode.h:
• page/scrolling/ScrollingStateFrameScrollingNode.cpp:
• page/scrolling/ScrollingStateFrameScrollingNode.h:
• page/scrolling/ScrollingStateNode.cpp:
• page/scrolling/ScrollingStateNode.h:
• page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
• page/scrolling/ScrollingStateOverflowScrollingNode.h:
• page/scrolling/ScrollingStateScrollingNode.cpp:
• page/scrolling/ScrollingStateScrollingNode.h:
• page/scrolling/ScrollingStateStickyNode.cpp:
• page/scrolling/ScrollingStateStickyNode.h:
• page/scrolling/ScrollingTree.cpp:
• page/scrolling/ScrollingTreeFrameScrollingNode.cpp:
• page/scrolling/ScrollingTreeFrameScrollingNode.h:
• page/scrolling/ScrollingTreeNode.cpp:
• page/scrolling/ScrollingTreeNode.h:
• page/scrolling/ScrollingTreeScrollingNode.cpp:
• page/scrolling/ScrollingTreeScrollingNode.h:
• page/scrolling/mac/ScrollingTreeFixedNode.h:
• page/scrolling/mac/ScrollingTreeFixedNode.mm:
• page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
• page/scrolling/mac/ScrollingTreeStickyNode.h:
• page/scrolling/mac/ScrollingTreeStickyNode.mm:
• platform/CalculationValue.cpp:
• platform/CalculationValue.h:
• platform/LayoutUnit.cpp:
• platform/LayoutUnit.h:
• platform/Length.cpp:
• platform/Length.h:
• platform/LengthBox.cpp:
• platform/LengthBox.h:
• platform/LengthPoint.cpp:
• platform/LengthPoint.h:
• platform/LengthSize.cpp:
• platform/LengthSize.h:
• platform/LogMacros.h:
• platform/ScrollView.cpp:
• platform/ScrollableArea.cpp:
• platform/animation/TimingFunction.cpp:
• platform/animation/TimingFunction.h:
• platform/graphics/BitmapImage.cpp:
• platform/graphics/BitmapImage.h:
• platform/graphics/Color.cpp:
• platform/graphics/Color.h:
• platform/graphics/CrossfadeGeneratedImage.cpp:
• platform/graphics/CrossfadeGeneratedImage.h:
• platform/graphics/FloatPoint.cpp:
• platform/graphics/FloatPoint.h:
• platform/graphics/FloatPoint3D.cpp:
• platform/graphics/FloatPoint3D.h:
• platform/graphics/FloatRect.cpp:
• platform/graphics/FloatRect.h:
• platform/graphics/FloatRoundedRect.cpp:
• platform/graphics/FloatRoundedRect.h:
• platform/graphics/FloatSize.cpp:
• platform/graphics/FloatSize.h:
• platform/graphics/FontTaggedSettings.cpp:
• platform/graphics/FontTaggedSettings.h:
• platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::dump const):

• platform/graphics/GradientImage.h:
• platform/graphics/GraphicsContext.cpp:
• platform/graphics/GraphicsContext.h:
• platform/graphics/GraphicsLayer.cpp:
• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::dumpAdditionalProperties const):

• platform/graphics/GraphicsTypes.cpp:
• platform/graphics/GraphicsTypes.h:
• platform/graphics/Image.cpp:
• platform/graphics/Image.h:
• platform/graphics/ImageSource.h:
• platform/graphics/IntPoint.cpp:
• platform/graphics/IntPoint.h:
• platform/graphics/IntRect.cpp:
• platform/graphics/IntRect.h:
• platform/graphics/IntSize.cpp:
• platform/graphics/IntSize.h:
• platform/graphics/LayoutPoint.cpp:
• platform/graphics/LayoutPoint.h:
• platform/graphics/LayoutRect.cpp:
• platform/graphics/LayoutRect.h:
• platform/graphics/LayoutSize.cpp:
• platform/graphics/LayoutSize.h:
• platform/graphics/NamedImageGeneratedImage.cpp:
• platform/graphics/NamedImageGeneratedImage.h:
• platform/graphics/Path.cpp:
• platform/graphics/Path.h:
• platform/graphics/ca/GraphicsLayerCA.cpp:
• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/ca/PlatformCAAnimation.cpp:
• platform/graphics/ca/PlatformCAAnimation.h:
• platform/graphics/ca/PlatformCALayer.cpp:
• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/TileController.cpp:
• platform/graphics/ca/TileGrid.cpp:
• platform/graphics/cg/GraphicsContextCG.cpp:
• platform/graphics/cg/PDFDocumentImage.cpp:
• platform/graphics/cg/PDFDocumentImage.h:
• platform/graphics/cocoa/IOSurface.h:
• platform/graphics/cocoa/IOSurface.mm:
• platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::description const):

• platform/graphics/displaylists/DisplayList.h:
• platform/graphics/displaylists/DisplayListItems.cpp:
• platform/graphics/displaylists/DisplayListItems.h:
• platform/graphics/displaylists/DisplayListRecorder.cpp:
• platform/graphics/displaylists/DisplayListReplayer.cpp:
• platform/graphics/filters/DistantLightSource.cpp:
• platform/graphics/filters/DistantLightSource.h:
• platform/graphics/filters/FEBlend.cpp:
• platform/graphics/filters/FEBlend.h:
• platform/graphics/filters/FEColorMatrix.cpp:
• platform/graphics/filters/FEColorMatrix.h:
• platform/graphics/filters/FEComponentTransfer.cpp:
• platform/graphics/filters/FEComponentTransfer.h:
• platform/graphics/filters/FEComposite.cpp:
• platform/graphics/filters/FEComposite.h:
• platform/graphics/filters/FEConvolveMatrix.cpp:
• platform/graphics/filters/FEConvolveMatrix.h:
• platform/graphics/filters/FEDiffuseLighting.cpp:
• platform/graphics/filters/FEDiffuseLighting.h:
• platform/graphics/filters/FEDisplacementMap.cpp:
• platform/graphics/filters/FEDisplacementMap.h:
• platform/graphics/filters/FEDropShadow.cpp:
• platform/graphics/filters/FEDropShadow.h:
• platform/graphics/filters/FEFlood.cpp:
• platform/graphics/filters/FEFlood.h:
• platform/graphics/filters/FEGaussianBlur.cpp:
• platform/graphics/filters/FEGaussianBlur.h:
• platform/graphics/filters/FEMerge.cpp:
• platform/graphics/filters/FEMerge.h:
• platform/graphics/filters/FEMorphology.cpp:
• platform/graphics/filters/FEMorphology.h:
• platform/graphics/filters/FEOffset.cpp:
• platform/graphics/filters/FEOffset.h:
• platform/graphics/filters/FESpecularLighting.cpp:
• platform/graphics/filters/FESpecularLighting.h:
• platform/graphics/filters/FETile.cpp:
• platform/graphics/filters/FETile.h:
• platform/graphics/filters/FETurbulence.cpp:
• platform/graphics/filters/FETurbulence.h:
• platform/graphics/filters/FilterEffect.cpp:
• platform/graphics/filters/FilterEffect.h:
• platform/graphics/filters/FilterOperation.cpp:
• platform/graphics/filters/FilterOperation.h:
• platform/graphics/filters/FilterOperations.cpp:
• platform/graphics/filters/FilterOperations.h:
• platform/graphics/filters/LightSource.h:
• platform/graphics/filters/PointLightSource.cpp:
• platform/graphics/filters/PointLightSource.h:
• platform/graphics/filters/SourceAlpha.cpp:
• platform/graphics/filters/SourceAlpha.h:
• platform/graphics/filters/SourceGraphic.cpp:
• platform/graphics/filters/SourceGraphic.h:
• platform/graphics/filters/SpotLightSource.cpp:
• platform/graphics/filters/SpotLightSource.h:
• platform/graphics/transforms/AffineTransform.cpp:
• platform/graphics/transforms/AffineTransform.h:
• platform/graphics/transforms/IdentityTransformOperation.h:
• platform/graphics/transforms/Matrix3DTransformOperation.cpp:
• platform/graphics/transforms/Matrix3DTransformOperation.h:
• platform/graphics/transforms/MatrixTransformOperation.cpp:
• platform/graphics/transforms/MatrixTransformOperation.h:
• platform/graphics/transforms/PerspectiveTransformOperation.cpp:
• platform/graphics/transforms/PerspectiveTransformOperation.h:
• platform/graphics/transforms/RotateTransformOperation.cpp:
• platform/graphics/transforms/RotateTransformOperation.h:
• platform/graphics/transforms/ScaleTransformOperation.cpp:
• platform/graphics/transforms/ScaleTransformOperation.h:
• platform/graphics/transforms/SkewTransformOperation.cpp:
• platform/graphics/transforms/SkewTransformOperation.h:
• platform/graphics/transforms/TransformOperation.cpp:
• platform/graphics/transforms/TransformOperation.h:
• platform/graphics/transforms/TransformOperations.cpp:
• platform/graphics/transforms/TransformOperations.h:
• platform/graphics/transforms/TransformationMatrix.cpp:
• platform/graphics/transforms/TransformationMatrix.h:
• platform/graphics/transforms/TranslateTransformOperation.cpp:
• platform/graphics/transforms/TranslateTransformOperation.h:
• platform/ios/SelectionRect.cpp:

(WebCore::operator<<):

• platform/ios/SelectionRect.h:
• platform/mac/ScrollAnimatorMac.mm:
• platform/text/TextAllInOne.cpp:
• rendering/InlineBox.cpp:
• rendering/InlineBox.h:
• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::outputLineTreeAndMark const):

• rendering/InlineFlowBox.h:
• rendering/InlineTextBox.cpp:
• rendering/InlineTextBox.h:
• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::outputLineTreeAndMark const):

• rendering/RenderBlockFlow.h:
• rendering/RenderLayer.cpp:
• rendering/RenderLayerCompositor.cpp:
• rendering/RenderObject.cpp:
• rendering/RenderObject.h:
• rendering/RenderTreeAsText.cpp:
• rendering/RenderTreeAsText.h:
• rendering/ScrollAlignment.cpp:
• rendering/ScrollAlignment.h:
• rendering/SimpleLineLayoutCoverage.cpp:
• rendering/SimpleLineLayoutFunctions.cpp:
• rendering/SimpleLineLayoutFunctions.h:
• rendering/style/FillLayer.cpp:
• rendering/style/FillLayer.h:
• rendering/style/NinePieceImage.cpp:
• rendering/style/NinePieceImage.h:
• rendering/style/RenderStyleConstants.cpp:
• rendering/style/RenderStyleConstants.h:
• rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

• rendering/svg/SVGRenderTreeAsText.h:

(WebCore::operator<<):

• svg/SVGLengthValue.cpp:
• svg/SVGLengthValue.h:
• svg/graphics/SVGImage.cpp:
• svg/graphics/SVGImage.h:
• svg/graphics/filters/SVGFEImage.cpp:
• svg/graphics/filters/SVGFEImage.h:

Source/WebKit:

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
• Shared/VisibleContentRectUpdateInfo.cpp:
• Shared/VisibleContentRectUpdateInfo.h:
• Shared/mac/RemoteLayerTreeTransaction.mm:
• UIProcess/API/Cocoa/WKWebView.mm:
• UIProcess/ios/WKContentView.mm:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(WebKit::operator<<):

• UIProcess/ios/WebPageProxyIOS.mm:
• WebProcess/WebPage/ios/WebPageIOS.mm:
• WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
• WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/text/TextStream.cpp: Renamed from Source/WebCore/platform/text/TextStream.cpp.

(WTF::TextStream::writeIndent):

• wtf/text/TextStream.h: Renamed from Source/WebCore/platform/text/TextStream.h.

(WTF::TextStream::FormatNumberRespectingIntegers::FormatNumberRespectingIntegers):

Tools:

• TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:

6:12 PM Changeset in webkit [220502] by mmaxfield@apple.com

• 2 edits in trunk/PerformanceTests

font-fallback-font-family.html is failing on perf bots
​https://bugs.webkit.org/show_bug.cgi?id=174989

Unreviewed.

• Layout/resources/font-fallback-font-family.html:

6:07 PM Changeset in webkit [220501] by aestes@apple.com

• 7 edits in trunk

Part 3 of: Rename DatabaseProcess to StorageProcess
​https://bugs.webkit.org/show_bug.cgi?id=175034

Reviewed by Brady Eidson.

Source/WebKit:

We tried renaming com.apple.WebKit.Databases to com.apple.WebKit.Storage in r219986, but
this prevented trunk WebKit from running on iOS 11 devices. This is because launchd keeps a
codesigned cache of XPC services, and refuses to launch services that aren't in the cache.

It's not possibe for us to rebuild the cache with the new service name (only Apple's
production build system can do this), and disabling the cache or opting WebKit's XPC
services out of the cache might have a negative impact on our performance testing.

For now we'll retain the name "com.apple.WebKit.Databases" on iOS 11 devices to work around
this issue. If we find a way to allow the new service to run without impacting performance,
we can revert this change.

We will rename the service to "com.apple.WebKit.Storage" on macOS and iOS Simulator, and in
a follow-up patch we'll use the new service name on post-iOS 11 device builds.

• Configurations/BaseTarget.xcconfig: Defined WK_STORAGE_SERVICE_PRODUCT_NAME to be

com.apple.WebKit.Databases by default, and overrode it to com.apple.WebKit.Storage on macOS
and iOS Simulator.

• Configurations/StorageService.xcconfig: Changed PRODUCT_NAME to $(WK_STORAGE_SERVICE_PRODUCT_NAME).
• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName): Changed to return "com.apple.WebKit.Storage" on macOS and
iOS Simulator platforms.

• WebKit.xcodeproj/project.pbxproj: Updated the "Copy XPC services for engineering builds"

build phase to use WK_STORAGE_SERVICE_PRODUCT_NAME.

Tools:

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::databaseProcessName): Updated to return
"com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.

5:42 PM Changeset in webkit [220500] by Caio Lima

• 4 edits in trunk/Source/JavaScriptCore

[JSC] Create JSSet constructor that accepts it's size as parameter
​https://bugs.webkit.org/show_bug.cgi?id=173297

Reviewed by Saam Barati.

This patch is adding a new constructor to JSSet that gives its
expected initial size. It is important to avoid re-hashing and mutiple
allocations when we know the final size of JSSet, such as in
CodeBlock::setConstantIdentifierSetRegisters.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setConstantIdentifierSetRegisters):

• runtime/HashMapImpl.h:

(JSC::HashMapImpl::HashMapImpl):

• runtime/JSSet.h:

5:35 PM Changeset in webkit [220499] by Ryan Haddad

• 10 edits in trunk

Unreviewed, rolling out r220466, r220477, and r220487.
​https://bugs.webkit.org/show_bug.cgi?id=175411

This change broke existing API tests and follow up fixes did
not resolve all the issues. (Requested by ryanhaddad on
#webkit).

Reverted changesets:

​https://bugs.webkit.org/show_bug.cgi?id=175244
​http://trac.webkit.org/changeset/220466

"WTF::Function does not allow for reference / non-default
constructible return types"
​https://bugs.webkit.org/show_bug.cgi?id=175244
​http://trac.webkit.org/changeset/220477

​https://bugs.webkit.org/show_bug.cgi?id=175244
​http://trac.webkit.org/changeset/220487

Patch by Commit Queue <​commit-queue@webkit.org> on 2017-08-09

4:32 PM Changeset in webkit [220498] by Michael Catanzaro

• 1 edit
  6 deletes in trunk

[CMake] Remove unused find modules
​https://bugs.webkit.org/show_bug.cgi?id=175363

Reviewed by Carlos Alberto Lopez Perez.

• Source/cmake/FindCFLite.cmake: Removed.
• Source/cmake/FindClang.cmake: Removed.
• Source/cmake/FindDBus.cmake: Removed.
• Source/cmake/FindDirectX.cmake: Removed.
• Source/cmake/FindEspeak.cmake: Removed.
• Source/cmake/FindQuickTimeSDK.cmake: Removed.

4:23 PM Changeset in webkit [220497] by Chris Dumez

• 14 edits
  3 copies
  4 adds in trunk

[Beacon][NetworkSession] Support CORS-preflighting on redirects
​https://bugs.webkit.org/show_bug.cgi?id=175386
<rdar://problem/33801370>

Reviewed by Youenn Fablet.

Source/WebCore:

Export a couple of WebCore symbols so I can use them in WebKit2.

Tests: http/wpt/beacon/cors/cors-preflight-redirect-failure.html

http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin.html
http/wpt/beacon/cors/cors-preflight-redirect-success.html

• loader/CrossOriginAccessControl.h:
• page/SecurityOrigin.h:

Source/WebKit:

Add support to Beacon for doing CORS-preflighting upon redirect to a different
domain.

• NetworkProcess/NetworkCORSPreflightChecker.h:
• NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::loadRequest):
(WebKit::PingLoad::securityOrigin const):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::needsCORSPreflight const):
(WebKit::PingLoad::doCORSPreflight):

• NetworkProcess/PingLoad.h:

LayoutTests:

Add layout test coverage.

• http/wpt/beacon/cors/cors-preflight-redirect-failure-expected.txt: Added.
• http/wpt/beacon/cors/cors-preflight-redirect-failure.html: Added.
• http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin-expected.txt: Added.
• http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin.html: Added.
• http/wpt/beacon/cors/cors-preflight-redirect-success-expected.txt: Added.
• http/wpt/beacon/cors/cors-preflight-redirect-success.html: Added.
• http/wpt/beacon/resources/beacon-preflight.py:

(main):

• http/wpt/beacon/resources/redirect.py: Added.

(main):

4:18 PM Changeset in webkit [220496] by commit-queue@webkit.org

• 6 edits in trunk/Source

Use MPAVRoutingController instead of deprecated versions.
​https://bugs.webkit.org/show_bug.cgi?id=175063
Source/WebCore:

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-08-09
Reviewed by Tim Horton.

No new tests because no behavior change. This uses a different platform class to present
an interface.

Remove deprecated MPAudioVideoRoutingPopoverController and MPAVRoutingSheet
Add MPMediaControlsViewController.

• platform/spi/ios/MediaPlayerSPI.h:

Source/WebKit:

rdar://problem/33301230

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-08-09
Reviewed by Tim Horton.

Remove dependence on deprecated classes MPAVRoutingSheet and MPAudioVideoRoutingPopoverController.

• UIProcess/ios/forms/WKAirPlayRoutePicker.h:
• UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker dealloc]):
(-[WKAirPlayRoutePicker show:fromRect:]):
(-[WKAirPlayRoutePicker popoverControllerDidDismissPopover:]): Deleted.
(-[WKAirPlayRoutePicker _presentAirPlayPopoverAnimated:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker _windowWillRotate:]): Deleted.
(-[WKAirPlayRoutePicker _windowDidRotate:]): Deleted.
(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Deleted.

4:03 PM Changeset in webkit [220495] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, deflake http/wpt/beacon/keepalive-after-navigation.html

Temporarily restore previous timeout on this test to address flakiness on the
bots until I can rewrite it.

• http/wpt/beacon/keepalive-after-navigation.html:

4:01 PM Changeset in webkit [220494] by Chris Dumez

• 4 edits
  1 delete in trunk/LayoutTests

Import beacon/headers/header-content-type.html from upstream WPT
​https://bugs.webkit.org/show_bug.cgi?id=175395

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

• web-platform-tests/beacon/headers/header-content-type-expected.txt:
• web-platform-tests/beacon/headers/header-content-type.html:

LayoutTests:

Drop local test that has been upstreamed to WPT.

• http/wpt/beacon/headers/header-content-type-same-origin-expected.txt: Removed.
• http/wpt/beacon/headers/header-content-type-same-origin.html: Removed.

3:59 PM Changeset in webkit [220493] by msaboff@apple.com

• 1 edit
  2 adds in trunk/PerformanceTests

Unreviewed build fix.

Added missing files.

• RexBench/Octane2/benchmark.js: Added.

(Octane2RegExpBenchmark):
(Octane2RegExpBenchmark.prototype.setup.):
(Octane2RegExpBenchmark.prototype.setup.Math.random):
(Octane2RegExpBenchmark.prototype.setup):
(Octane2RegExpBenchmark.prototype.runOnce):
(Octane2RegExpBenchmark.prototype.tearDown):

• RexBench/SunSpider/benchmark.js: Added.

(RegexDNABenchmark):
(RegexDNABenchmark.prototype.runOnce):
(RegexDNABenchmark.prototype.validate):

3:50 PM Changeset in webkit [220492] by jmarcell@apple.com

• 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

3:47 PM Changeset in webkit [220491] by jmarcell@apple.com

• 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:45 PM Changeset in webkit [220490] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.38.1.3

Tag Safari-604.1.38.1.3.

3:44 PM Changeset in webkit [220489] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.38.0.3

Tag Safari-604.1.38.0.3.

3:42 PM Changeset in webkit [220488] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

Mark font-display as in development
​https://bugs.webkit.org/show_bug.cgi?id=175387

Unreviewed.

• features.json:

3:40 PM Changeset in webkit [220487] by weinig@apple.com

• 2 edits in trunk/Tools

Update for ​https://bugs.webkit.org/show_bug.cgi?id=175244.

Remove one addition of null Function test.

3:36 PM Changeset in webkit [220486] by n_wang@apple.com

• 2 edits in trunk/LayoutTests

LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=175194

Reviewed by Chris Fleizach.

In the test we have no way to control which iframe will be loaded first.
Output the logs at the end of the test so that they are in order.

• accessibility/presentation-role-iframe.html:

3:33 PM Changeset in webkit [220485] by msaboff@apple.com

• 11 edits
  1 add
  1 delete in trunk/PerformanceTests

Rex Bench doesn't work from the command line
​https://bugs.webkit.org/show_bug.cgi?id=175349

Reviewed by Saam Barati.

Fixed cli.js to have the same set of benchmarks and .js files as the web
page driver.

Refactored the way benchmarks are run using a new Benchmark base class. That
class will run the benchmark as well. Eliminated the various runBenchmark()
functions that were used for individual tests. This refactoring was threaded
into the web page driver as well. Changed the iteration counts on many of the
individual benchmarks. Also changed the inner loop count for the flight
planner test.

Eliminated Octane2/base.js as it isn't needed to run Octane2/RegExp with the
new test harness. Eliminated other dead code in Octane2/regexp.js.

• RexBench/Basic/benchmark.js:

(BasicBenchmark):
(BasicBenchmark.prototype.runIteration): Deleted.
(runBenchmark): Deleted.

• RexBench/FlightPlanner/benchmark.js:

(FlightPlannerBenchmark):
(FlightPlannerBenchmark.prototype.runOnce):
(this.performance.performance.now.currentTime): Deleted.
(else.this.preciseTime.currentTime): Deleted.
(else.currentTime): Deleted.
(FlightPlannerBenchmark.prototype.runIteration): Deleted.
(FlightPlannerBenchmark.prototype.checkResults): Deleted.
(runBenchmark): Deleted.

• RexBench/Octane2/base.js: Removed.
• RexBench/Octane2/regexp.js:
• RexBench/basic_benchmark.js:
• RexBench/benchmark.js: Added.

(this.performance.performance.now.currentTime):
(else.this.preciseTime.currentTime):
(else.currentTime):
(Benchmark):
(Benchmark.prototype.runIterations):
(Benchmark.prototype.setup):
(Benchmark.prototype.runOnce):
(Benchmark.prototype.validate):
(Benchmark.prototype.tearDown):

• RexBench/cli.js:
• RexBench/flightplan_benchmark.js:
• RexBench/flightplan_unicode_benchmark.js:
• RexBench/octane2_benchmark.js:
• RexBench/stats.js:

(Stats.prototype.toString.return.span.0.span.span):

• RexBench/sunspider_benchmark.js:

3:08 PM Changeset in webkit [220484] by commit-queue@webkit.org

• 3 edits
  2 deletes in trunk

Unreviewed, rolling out r219334.
​https://bugs.webkit.org/show_bug.cgi?id=175398

Caused bug 175023 (Requested by ap on #webkit).

Reverted changeset:

"[SVG] Leak in SVGAnimatedListPropertyTearOff"
​https://bugs.webkit.org/show_bug.cgi?id=172545
​http://trac.webkit.org/changeset/219334

2:58 PM Changeset in webkit [220483] by Jonathan Bedard

• 5 edits
  2 adds in trunk/Tools

Allow nested timeouts in webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=175390
<rdar://problem/33803003>

Reviewed by David Kilzer.

We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
the executive to detect and recover from any issues connecting with devices.

• Scripts/webkitpy/benchmark_runner/utils.py:

(TimeoutError): Deleted.
(timeout): Deleted.

• Scripts/webkitpy/common/timeout_context.py: Added.

(Timeout): A timeout context designed to be nested.
(Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
(Timeout.TimeoutData.init):
(Timeout.default_handler): Timeout handler used if none is specified.
(Timeout.current): Access data about the most urgent timeout.
(Timeout.init): Construct a Timeout object with seconds and an optional handler.
(Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
(Timeout.enter): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
urgent timeout data.
(Timeout.exit): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
most urgent timeout data, if such data exists.

• Scripts/webkitpy/common/timeout_context_unittest.py: Added.

(TimeoutContextTests):
(TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
(TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
(TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
(TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
over a less urgent outer timeout.
(TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
over a less urgent inner timeout.
(TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
(TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
(TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
(TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
(TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.

• Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess._start): Use Timeout class.

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
(SimulatedDevice.launch_app): Ditto.
(SimulatedDevice.launch_app._install_timeout): Deleted.

• Scripts/webkitpy/xcode/simulator.py:

(Simulator.wait_until_device_is_booted):Use Timeout class.
(Simulator.wait_until_device_is_in_state): Ditto.

2:57 PM Changeset in webkit [220482] by Ryan Haddad

• 7 edits in branches/safari-604.1.38.1-branch/LayoutTests

Unreviwed test gardening. rdar://problem/33789505

2:34 PM Changeset in webkit [220481] by caitp@igalia.com

• 6 edits in trunk

Early error on ANY operator before new.target
​https://bugs.webkit.org/show_bug.cgi?id=157970

Reviewed by Saam Barati.

Instead of throwing if any unary operator precedes new.target, only
throw if the unary operator updates the reference.

The following become legal in JSC:

`
!new.target
~new.target
typeof new.target
delete new.target
void new.target
`

All of which are legal in v8 and SpiderMonkey in strict and sloppy mode

JSTests:

• stress/new-target-syntax-errors.js:
• stress/new-target.js:

Source/JavaScriptCore:

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseUnaryExpression):

2:03 PM Changeset in webkit [220480] by mitz@apple.com

• 9 copies
  1 add in releases/Apple/Safari Technology Preview 37

Added a tag for Safari Technology Preview release 37.

2:03 PM Changeset in webkit [220479] by hyatt@apple.com

• 6 edits in trunk/Source/WebCore

[Repaint from Layout Removal] Move layer repaint rects into a map
​https://bugs.webkit.org/show_bug.cgi?id=175393

Reviewed by Zalan Bujtas.

Move the two repaint rects held by RenderLayer into a RenderLayerModelObject -> RepaintLayoutRects hash map.
RepaintLayoutRects is a new struct that holds both rects.

Eventually more objects than just self painting layers will be caching repaint rects, so this takes a first
step towards having a common cache for these repaint rects. In addition this change saves memory, since
layers that aren't self-painting no longer have empty repaint rects taking up space in RenderLayer.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::layoutRunsAndFloats):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::repaintRectIncludingNonCompositingDescendants):
(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::clearRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::scrollTo):

• rendering/RenderLayer.h:
• rendering/RenderLayerModelObject.cpp:

(WebCore::RepaintLayoutRects::RepaintLayoutRects):
(WebCore::RenderLayerModelObject::willBeDestroyed):
(WebCore::RenderLayerModelObject::destroyLayer):
(WebCore::RenderLayerModelObject::styleDidChange):
(WebCore::RenderLayerModelObject::hasRepaintLayoutRects):
(WebCore::RenderLayerModelObject::setRepaintLayoutRects):
(WebCore::RenderLayerModelObject::clearRepaintLayoutRects):
(WebCore::RenderLayerModelObject::repaintLayoutRects):
(WebCore::RenderLayerModelObject::computeRepaintLayoutRects):

• rendering/RenderLayerModelObject.h:

(WebCore::RepaintLayoutRects::RepaintLayoutRects):

2:02 PM Changeset in webkit [220478] by weinig@apple.com

• 4 edits in trunk/Source

Update reviewer

1:57 PM Changeset in webkit [220477] by commit-queue@webkit.org

• 8 edits in trunk/Source

WTF::Function does not allow for reference / non-default constructible return types
​https://bugs.webkit.org/show_bug.cgi?id=175244

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-09
Reviewed by Sam Weinig.

Source/JavaScriptCore:

• runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

• bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

• UIProcess/WebResourceLoadStatisticsStore.h:

Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

• wtf/Function.h:

(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

1:28 PM Changeset in webkit [220476] by dbates@webkit.org

• 6 edits
  570 adds in trunk/LayoutTests

Import CSS-UI-3 Web Platform Tests
​https://bugs.webkit.org/show_bug.cgi?id=175294

Reviewed by Zalan Bujtas.

LayoutTests/imported/w3c:

• resources/import-expectations.json:
• resources/resource-files.json:
• web-platform-tests/css/css-ui-3/OWNERS: Added.
• web-platform-tests/css/css-ui-3/box-sizing-001-expected.html: Added.
• web-platform-tests/css/css-ui-3/box-sizing-001.html: Added.
• web-platform-tests/css/css-ui-3/box-sizing-003-expected.html: Added.
• web-platform-tests/css/css-ui-3/box-sizing-003.html: Added.
• web-platform-tests/css/css-ui-3/box-sizing-005-expected.html: Added.
• web-platform-tests/css/css-ui-3/box-sizing-005.html: Added.
• web-platform-tests/css/css-ui-3/box-sizing-007-expected.html: Added.
• web-platform-tests/css/css-ui-3/box-sizing-007.html: Added.

[truncated]

LayoutTests:

Mark tests that we currently failure.

• TestExpectations:
• platform/ios/TestExpectations:

1:25 PM Changeset in webkit [220475] by beidson@apple.com

• 18 edits in trunk/Source/WebCore

Teach ScriptExecutionContexts about their SessionID.
​https://bugs.webkit.org/show_bug.cgi?id=175391

Reviewed by Andy Estes.

No new tests (No current change in behavior).

Turns out that Workers need to know their SessionID for future feature development.
So let's teach it to them.

• dom/ScriptExecutionContext.h: Expose a pure virtual SessionID accessor.

• dom/Document.cpp:

(WebCore::Document::sessionID const):

• dom/Document.h:

• page/SessionID.cpp:

(WebCore::SessionID::isolatedCopy const):

• page/SessionID.h:

• workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):

• workers/DedicatedWorkerGlobalScope.h:

• workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):

• workers/DedicatedWorkerThread.h:

• workers/Worker.cpp:

(WebCore::Worker::notifyFinished):

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

• workers/WorkerGlobalScope.h:

• workers/WorkerGlobalScopeProxy.h:

• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

• workers/WorkerMessagingProxy.h:

• workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):

• workers/WorkerThread.h:

1:08 PM Changeset in webkit [220474] by Matt Lewis

• 3 edits in trunk/LayoutTests

Marked http/tests/media/video-buffered-range-contains-currentTime.html as flaky on High Sierra
<rdar://problem/33555759>

Unreviewed test gardening.

• platform/mac-highsierra-wk2/TestExpectations:
• platform/mac/TestExpectations:

12:15 PM Changeset in webkit [220473] by Wenson Hsieh

• 12 edits in trunk

[iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
​https://bugs.webkit.org/show_bug.cgi?id=175392
<rdar://problem/33783207>

Reviewed by Tim Horton and Megan Gardner.

Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No change in behavior.

• Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

12:13 PM Changeset in webkit [220472] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

Old subtitle track is not deleted on 'src' attribute change event
​https://bugs.webkit.org/show_bug.cgi?id=175031

Patch by Kirill Ovchinnikov <​kirill.ovchinnikov@lge.com> on 2017-08-09
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/text-track-src-change.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackReadyStateChanged):

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::loadTimerFired):

• html/shadow/MediaControls.cpp:

(WebCore::MediaControls::clearTextDisplayContainer):

• html/shadow/MediaControls.h:

LayoutTests:

• media/track/text-track-src-change-expected.txt: Added.
• media/track/text-track-src-change.html: Added.

11:31 AM Changeset in webkit [220471] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Make JSC_validateExceptionChecks=1 succeed on JSTests/stress/v8-deltablue-strict.js.
​https://bugs.webkit.org/show_bug.cgi?id=175358

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-09
Reviewed by Mark Lam.

• jit/JITOperations.cpp:
• runtime/JSObjectInlines.h:

(JSC::JSObject::putInlineForJSObject):

11:24 AM Changeset in webkit [220470] by jmarcell@apple.com

• 3 edits in branches/safari-604.1.38.1-branch/Source/JavaScriptCore

Cherry-pick r220346. rdar://problem/33805219

11:14 AM Changeset in webkit [220469] by jmarcell@apple.com

• 3 edits
  4 adds in branches/safari-604.1.38.0-branch

Cherry-pick r220456. rdar://problem/33805190

11:14 AM Changeset in webkit [220468] by jmarcell@apple.com

• 3 edits in branches/safari-604.1.38.0-branch/Source/JavaScriptCore

Cherry-pick r220346. rdar://problem/33805223

11:05 AM Changeset in webkit [220467] by beidson@apple.com

• 2 edits in trunk/Source/WebKit

ServiceWorker experimental feature should not be on by default (definitely not ready).
​https://bugs.webkit.org/show_bug.cgi?id=175389

Rubberstamped by Andy Estes.

• Shared/WebPreferencesDefinitions.h: false, not DEFAULT_EXPERIMENTAL_FEATURES_ENABLED

11:03 AM Changeset in webkit [220466] by weinig@apple.com

• 2 edits in trunk/Tools

Update for ​https://bugs.webkit.org/show_bug.cgi?id=175244.

• TestWebKitAPI/Tests/WTF/Function.cpp:

Remove tests of null Functions, as they are no longer supported.

10:58 AM Changeset in webkit [220465] by Ryan Haddad

• 8 edits in trunk/Source

Unreviewed, rolling out r220457.

This change introduced API test failures.

Reverted changeset:

"WTF::Function does not allow for reference / non-default
constructible return types"
​https://bugs.webkit.org/show_bug.cgi?id=175244
​http://trac.webkit.org/changeset/220457

10:53 AM Changeset in webkit [220464] by don.olmstead@sony.com

• 2 edits in trunk/Source/WebCore

[WinCairo] Fix build after rev 220399
​https://bugs.webkit.org/show_bug.cgi?id=175360

Reviewed by Žan Doberšek.

No new tests. No change in behavior.

• platform/graphics/texmap/TextureMapperGLHeaders.h:

10:52 AM Changeset in webkit [220463] by n_wang@apple.com

• 3 edits
  3 adds in trunk

AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
​https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/33782159>

Reviewed by Chris Fleizach.

Source/WebCore:

When adding a psuedo element child to a RenderBlockFlow element, there might be a chance where
the element has already been layed out but we are still holding onto its stale children. Fixed it
by notifying AX correctly when inserting/removing children during layout.

Test: accessibility/add-children-pseudo-element.html

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObject):

LayoutTests:

• accessibility/add-children-pseudo-element-expected.txt: Added.
• accessibility/add-children-pseudo-element.html: Added.
• accessibility/resources/svg-circle.svg: Added.

10:46 AM Changeset in webkit [220462] by Nikita Vasilyev

• 3 edits
  1 add in trunk/Source/WebInspectorUI

Web Inspector: Styles: Add pre-populated data to spreadsheet-style view
​https://bugs.webkit.org/show_bug.cgi?id=174838
<rdar://problem/33523220>

Reviewed by Matt Baker.

This patch adds static content to the experimental RulesStyleSpreadsheetDetailsPanel.
The static content will be replaced with actual data in the follow up patches.

• UserInterface/Main.html:
• UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.css: Added.

(.style-spreadsheet .style-rule):
(.style-spreadsheet .selector-line):
(.style-spreadsheet .selector):
(.style-spreadsheet :matches(.selector .matched, .selector:focus)):
(.style-spreadsheet .name):
(.style-spreadsheet .value):
(.style-spreadsheet :matches(.selector, .name, .value)):
(.style-spreadsheet :matches(.selector, .name, .value):focus):
(.style-spreadsheet .selector-inline):
(.style-spreadsheet .property):
(.style-spreadsheet .property-disabled,):
(.style-spreadsheet .property-disabled :matches(.name, .value)):
(.style-spreadsheet .styles-source):
(.style-spreadsheet :matches(a, .node-link)):
(.style-spreadsheet :matches(a, .node-link):hover):
(.style-spreadsheet .inherited):
(.style-spreadsheet .declarations):
(.style-spreadsheet input[type="checkbox"]):
(.style-spreadsheet input[type="checkbox"]:not(:checked)):
(.style-spreadsheet .declarations:hover input[type="checkbox"]):

• UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.js:

10:23 AM Changeset in webkit [220461] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer][MSE] Add missing lock around getStreamByTrackId
​https://bugs.webkit.org/show_bug.cgi?id=175323

Patch by Charlie Turner <​cturner@igalia.com> on 2017-08-09
Reviewed by Xabier Rodriguez-Calvar.

Covered by existing tests.

• platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::enqueueSample): Ensure the media source
lock is taken before modifiying the track queues indirectly via the
iterator use in getTrackId.

9:41 AM Changeset in webkit [220460] by commit-queue@webkit.org

• 5 edits
  2 adds
  1 delete in trunk/LayoutTests

WPE-focused test gardening.
​https://bugs.webkit.org/show_bug.cgi?id=175385

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-09

• platform/wpe/TestExpectations: Marked failing tests.
• platform/wpe/fast/events/touch/basic-single-touch-events-expected.txt: Added platform-specific expectation.
• platform/wpe/js/date-timeClip-large-values-expected.txt: Removed (the platform-neutral expectation is fine).
• platform/wpe/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Updated for Cache enabling.
• transitions/clip-path-path-transitions-expected.txt: Updated for test change in r219243.
• transitions/resources/transition-test-helpers.js:

(parseClipPath): Updated to support the quotes in clip-path-path-transitions.html

9:30 AM Changeset in webkit [220459] by dbates@webkit.org

• 21 edits in trunk

REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
​https://bugs.webkit.org/show_bug.cgi?id=175247
<rdar://problem/33679804>

Reviewed by Brady Eidson.

Source/WebCore:

Add SPI so that Safari can differentiate between a form submission and a redirected form submission
and have PolicyCheck notify the frame loader client if the navigation was in response to receiving a
redirect response. This is the WebKit portion to fix an issue when a native app makes use of an OAuth
OAuth flow that bounces to Safari for user login and then bounce back to the app. Microsoft Graph's
OAuth flow is one example.

Safari was differentiating between a form submission and a redirected form submission based on the
nullity of WKNavigationAction.sourceFrame because in both cases the navigation type was WKNavigationTypeFormSubmitted.
The navigation type is the same for both navigations because WebKit always used the navigation
action from the original request for the redirect request when the original request redirected.
Prior to r219013, WKNavigationAction.sourceFrame would be nil for a form submission that redirects.
Following r219013, WKNavigationAction.sourceFrame is non-nil unless the navigation was initiated by
API. In particular, WKNavigationAction.sourceFrame is non-nil for the redirect navigation corresponding
to a form submission that redirects.

• loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

• loader/FrameLoaderClient.h:

Have dispatchDecidePolicyForNavigationAction() take a boolean as to whether the navigation was in
response to receiving a redirect response.

• loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy): Notify the frame loader client whether the navigation
is in response to receiving a redirect response.

Source/WebKit:

Add SPI WKNavigationAction._isRedirect to query whether the navigation was in response to receiving
a redirect response. The majority of the WebKit change is plumbing this knowledge through to connect
it with the SPI.

• Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::encode const):
(WebKit::NavigationActionData::decode):
Encode and decode the boolean NavigationActionData::isRedirect.

• Shared/NavigationActionData.h:
• UIProcess/API/APINavigationAction.h:
• UIProcess/API/Cocoa/WKNavigationAction.mm:

(-[WKNavigationAction _isRedirect]): Added.

• UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Set NavigationActionData::isRedirect
depending on whether the navigation is in response to receiving a redirect response.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

Plumb knowledge of whether a navigation was in response to receiving a redirect response.
We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
clients that need to make use of this information at this time. If such a needs comes up
then we can expose API/SPI similar to what we do for WebKit.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Source/WebKitLegacy/win:

Plumb knowledge of whether a navigation was in response to receiving a redirect response.
We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
clients that need to make use of this information at this time. If such a needs comes up
then we can expose API/SPI similar to what we do for WebKit.

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

• WebCoreSupport/WebFrameLoaderClient.h:

Tools:

Add tests for redirects.

• TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:

(TEST):

• TestWebKitAPI/cocoa/TestProtocol.mm:

(createRedirectURL):
(-[TestProtocol startLoading]):

9:02 AM Changeset in webkit [220458] by Ryan Haddad

• 3 edits in trunk/JSTests

Skip failing JSC tests stress/regress-169783.js and wasm.yaml/wasm/stress/oom.js.
​https://bugs.webkit.org/show_bug.cgi?id=175255

Unreviewed test gardening.

• stress/regress-169783.js:
• wasm/stress/oom.js:

8:59 AM Changeset in webkit [220457] by commit-queue@webkit.org

• 8 edits in trunk/Source

WTF::Function does not allow for reference / non-default constructible return types
​https://bugs.webkit.org/show_bug.cgi?id=175244

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-09
Reviewed by Chris Dumez.

Source/JavaScriptCore:

• runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

• bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

• UIProcess/WebResourceLoadStatisticsStore.h:

Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

• wtf/Function.h:

(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

8:52 AM Changeset in webkit [220456] by aestes@apple.com

• 3 edits
  4 adds in trunk

[QuickLook] Use case-insensitive comparison of preview MIME types
​https://bugs.webkit.org/show_bug.cgi?id=175350
<rdar://problem/33761159>

Reviewed by Brady Eidson.

Source/WebCore:

MIME types are case-insensitive, but PreviewLoader was using a case-sensitive comparison to
determine if a MIME type was supported by QLPreviewConverter. As a result we would fail to
preview Excel macro-enabled workbooks, since CFNetwork would sniff a MIME type of
"application/vnd.ms-excel.sheet.macroEnabled.12" but QuickLook contained
"application/vnd.ms-excel.sheet.macroenabled.12" in its set of supported MIME type strings.

Fix this by copying the QuickLook supported MIME type set into a HashSet using
ASCIICaseInsensitiveHash and using that HashSet for MIME type checks.

Test: quicklook/excel-macro-enabled.html

• loader/ios/PreviewLoader.mm:

(WebCore::PreviewLoader::shouldCreateForMIMEType):

LayoutTests:

• platform/ios-11/quicklook/excel-macro-enabled-expected.txt: Added.
• quicklook/excel-macro-enabled-expected.txt: Added.
• quicklook/excel-macro-enabled.html: Added.
• quicklook/resources/excel-macro-enabled.xlsm: Added.

7:35 AM WebKitGTK/StableRelease edited by Adrian Perez de Castro

Added 2.18.x (diff)

6:25 AM Changeset in webkit [220455] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed WPE gardening.

• platform/wpe/TestExpectations: Stop skipping the whole fast/

directory and then unskipping specific subdirectories since
that overrides any expectations coming from the generic WK2
TestExpectations file. Specific subdirectories that we haven't
yet generated results for are now skipped instead.

6:06 AM Changeset in webkit [220454] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Remove unnecessary copies of PlatformMediaSessionManager::m_sessions
​https://bugs.webkit.org/show_bug.cgi?id=175375

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-09
Reviewed by Sam Weinig.

Remove unnecessary copies of PlatformMediaSessionManager::m_sessions.

These should have been removed in r207688.

No new tests: no behavior change.

• platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive const):
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const):
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground const):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground const):

6:04 AM Changeset in webkit [220453] by Chris Dumez

• 11 edits in trunk

Reinstate active flag for iterators
​https://bugs.webkit.org/show_bug.cgi?id=175312

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Resync WPT tests from upstream to gain test coverage.

• web-platform-tests/dom/traversal/NodeIterator-expected.txt:
• web-platform-tests/dom/traversal/NodeIterator.html:
• web-platform-tests/dom/traversal/TreeWalker-expected.txt:
• web-platform-tests/dom/traversal/TreeWalker.html:

Source/WebCore:

NodeIterator / TreeWalker should no longer allow recursive filters
after the following change to the DOM specification:

• ​https://github.com/whatwg/dom/pull/359

This patch aligns our behavior with the latest specification.

No new tests, updated existing tests.

• dom/NodeIterator.cpp:

(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
Note that we now also call m_candidateNode.clear() before returning an
exception. This was a pre-existing bug that we failed to do so in the
exception case but it became more obvious after this change now that
we throw. This was causing traversal/moz-bug559526.html to fail
otherwise (the filter was called one too many times). The test case
is passing in Firefox (The filter is called 4 times and they throw
each time).

• dom/Traversal.cpp:

(WebCore::NodeIteratorBase::NodeIteratorBase):
(WebCore::NodeIteratorBase::acceptNode):

• dom/Traversal.h:
• dom/TreeWalker.cpp:

3:48 AM Changeset in webkit [220452] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.17.90

WebKitGTK+ 2.17.90

3:48 AM Changeset in webkit [220451] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.90 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.17.90.

2:22 AM Changeset in webkit [220450] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[GTK] [WPE] Update expectations for global-constructors-attributes.html.
​https://bugs.webkit.org/show_bug.cgi?id=175373

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-09

• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/wpe/js/dom/global-constructors-attributes-expected.txt:

2:17 AM Changeset in webkit [220449] by gskachkov@gmail.com

• 5 edits in trunk

REGRESSION: 2 test262/test/language/statements/async-function failures
​https://bugs.webkit.org/show_bug.cgi?id=175334

Reviewed by Yusuke Suzuki.

JSTests:

Add @skip parameters to tests, and remove test for async iterator from
async await syntax test because it is already covered by async-iterator-syntax.js

• stress/async-await-syntax.js:
• stress/async-iteration-syntax.js:

Source/JavaScriptCore:

Switch off useAsyncIterator by default

• runtime/Options.h:

2:11 AM WebKitGTK/2.18.x created by Carlos Garcia Campos

1:22 AM WebKitGTK/2.16.x edited by tpopela@redhat.com

(diff)

1:14 AM WebKitGTK/2.16.x edited by tpopela@redhat.com

(diff)

12:46 AM Changeset in webkit [220448] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.18

Branch WebKitGTK+ for 2.18

12:36 AM Changeset in webkit [220447] by Antti Koivisto

• 10 edits in trunk/Source/WebCore

RenderQuote should not mutate render tree
​https://bugs.webkit.org/show_bug.cgi?id=175328

Reviewed by Zalan Bujtas.

RenderQuote text renderers are currently created and deleted in a quirky fashion using a linked list.
This patch moves to a simpler model that guarantees the mutations are always done in controlled fashion
during render tree update.

• dom/Document.cpp:

(WebCore::Document::updateTextRenderer):

Move text renderer updating to Document so we can set the inRenderTreeUpdate bit for it too.

• dom/Document.h:
• dom/Text.cpp:

(WebCore::Text::updateRendererAfterContentChange):

• rendering/RenderDescendantIterator.h:

(WebCore::RenderDescendantIteratorAdapter<T>::at):
(WebCore::RenderDescendantConstIteratorAdapter<T>::at const):

Add at() function for starting iteration from a specified renderer.

• rendering/RenderQuote.cpp:

(WebCore::RenderQuote::insertedIntoTree):
(WebCore::RenderQuote::willBeRemovedFromTree):

Register and unregister quotes to RenderView.
Don't do any mutations.

(WebCore::RenderQuote::styleDidChange):

Invalidate the text renderer but don't mutate it.

(WebCore::RenderQuote::updateTextRenderer):
(WebCore::RenderQuote::computeText const):
(WebCore::RenderQuote::updateRenderers):

Compute depth of all render quotes and update the text renderer as needed.

(WebCore::RenderQuote::willBeDestroyed): Deleted.
(WebCore::RenderQuote::attachQuote): Deleted.
(WebCore::RenderQuote::detachQuote): Deleted.
(WebCore::RenderQuote::updateDepth): Deleted.

Get rid of the linked list.

• rendering/RenderQuote.h:
• rendering/RenderView.cpp:

(WebCore::RenderView::registerQuote):
(WebCore::RenderView::unregisterQuote):

Maintain a render tree order ListHashSet of RenderQuotes.

(WebCore::RenderView::updateSpecialRenderers):

Add a function for making additional render tree mutations at the end of a render tree update.
Currently this just invokes RenderQuote::updateRenderers.

• rendering/RenderView.h:
• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::commit):

Call RenderView::updateSpecialRenderers after committing all other changes.

12:16 AM Changeset in webkit [220446] by zandobersek@gmail.com

• 2 edits in trunk

[WPE] Enable SUBTLE_CRYPTO in release builds
​https://bugs.webkit.org/show_bug.cgi?id=175371

Reviewed by Carlos Garcia Campos.

• Source/cmake/OptionsWPE.cmake:

Use ON as the default port value for ENABLE_SUBTLE_CRYPTO in WPE.

12:13 AM Changeset in webkit [220445] by Carlos Garcia Campos

• 2 edits in trunk

[GTK] Enable SUBTLE_CRYPTO in GTK+ releases
​https://bugs.webkit.org/show_bug.cgi?id=172758

Reviewed by Žan Doberšek.

Add ENABLE_WEB_CRYPTO public option and make ENABLE_SUBTLE_CRYPTO depend on it.

• Source/cmake/OptionsGTK.cmake:

12:00 AM Changeset in webkit [220444] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[Soup] Incorrect conversion in msToSoupDate()
​https://bugs.webkit.org/show_bug.cgi?id=175320

Reviewed by Carlos Garcia Campos.

Original patch by VaL Doroshchuk.

• platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::msToSoupDate): monthFromDayInYear() returns a value in the [0,11] range,
while soup_date_new() expects a month value in the [1,12] range. The return value
must be thus incremented by one to match that expectation.