Timeline



Aug 14, 2017:

11:51 PM Changeset in webkit [220739] by jmarcell@apple.com
  • 6 edits
    2 deletes in branches/safari-604.1.38.0-branch

Revert r217197. rdar://problem/33890636

11:51 PM Changeset in webkit [220738] by jmarcell@apple.com
  • 5 edits
    3 deletes in branches/safari-604.1.38.0-branch

Revert r220112. rdar://problem/33890629

11:45 PM Changeset in webkit [220737] by jmarcell@apple.com
  • 6 edits
    2 deletes in branches/safari-604-branch

Revert r217197. rdar://problem/33890650

11:45 PM Changeset in webkit [220736] by jmarcell@apple.com
  • 5 edits
    3 deletes in branches/safari-604-branch

Revert r220112. rdar://problem/33890661

9:18 PM Changeset in webkit [220735] by keith_miller@apple.com
  • 30 edits
    1 add in trunk

Add testing tool to lie to the DFG about profiles
https://bugs.webkit.org/show_bug.cgi?id=175487

Reviewed by Saam Barati.

JSTests:

  • stress/compare-eq-incomplete-profile.js: Added.

(const.test.createBuiltin):

Source/JavaScriptCore:

This patch adds a new bytecode identity_with_profile that lets
us lie to the DFG about what profiles it has seen as the input to
another bytecode. Previously, there was no reliable way to force
a given profile when we tired up.

  • bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::dumpBytecode):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/SpeculatedType.cpp:

(JSC::speculationFromString):

  • bytecode/SpeculatedType.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitIdWithProfile):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_idWithProfile):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGMayExit.cpp:
  • dfg/DFGNode.h:

(JSC::DFG::Node::getForcedPrediction):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_identity_with_profile):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_identity_with_profile):

  • llint/LowLevelInterpreter.asm:
8:55 PM WebKitGTK/2.16.x edited by tpopela@redhat.com
(diff)
6:49 PM Changeset in webkit [220734] by Simon Fraser
  • 41 edits
    35 deletes in trunk

Remove Proximity Events and related code
https://bugs.webkit.org/show_bug.cgi?id=175545

Reviewed by Daniel Bates.

No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
and other related code.

.:

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • Modules/proximity/DeviceProximityClient.h: Removed.
  • Modules/proximity/DeviceProximityController.cpp: Removed.
  • Modules/proximity/DeviceProximityController.h: Removed.
  • Modules/proximity/DeviceProximityEvent.cpp: Removed.
  • Modules/proximity/DeviceProximityEvent.h: Removed.
  • Modules/proximity/DeviceProximityEvent.idl: Removed.
  • dom/EventNames.h:
  • dom/EventNames.in:
  • history/PageCache.cpp:

(WebCore::canCachePage):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

  • page/DOMWindow.idl:
  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::deviceProximityKey): Deleted.

  • page/DiagnosticLoggingKeys.h:
  • testing/Internals.cpp:

(WebCore::Internals::setDeviceProximity): Deleted.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebInspectorUI:

  • UserInterface/Models/ScriptTimelineRecord.js:

(WI.ScriptTimelineRecord.EventType.displayName):

Source/WebKit:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebDeviceProximityClient.cpp: Removed.
  • WebProcess/WebCoreSupport/WebDeviceProximityClient.h: Removed.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • fast/events/constructors/device-proximity-event-constructor-expected.txt: Removed.
  • fast/events/constructors/device-proximity-event-constructor.html: Removed.
  • platform/gtk/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • proximity/add-listener-from-callback-expected.txt: Removed.
  • proximity/add-listener-from-callback.html: Removed.
  • proximity/basic-operation-expected.txt: Removed.
  • proximity/basic-operation.html: Removed.
  • proximity/check-event-deviceproximity-expected.txt: Removed.
  • proximity/check-event-deviceproximity.html: Removed.
  • proximity/create-event-deviceproximity-expected.txt: Removed.
  • proximity/create-event-deviceproximity.html: Removed.
  • proximity/create-event-expected.txt: Removed.
  • proximity/create-event.html: Removed.
  • proximity/event-after-navigation-expected.txt: Removed.
  • proximity/event-after-navigation.html: Removed.
  • proximity/multiple-frames-expected.txt: Removed.
  • proximity/multiple-frames.html: Removed.
  • proximity/no-page-cache-expected.txt: Removed.
  • proximity/no-page-cache.html: Removed.
  • proximity/optional-event-properties-expected.txt: Removed.
  • proximity/optional-event-properties.html: Removed.
  • proximity/resources/cached-page-1.html: Removed.
  • proximity/resources/cached-page-2.html: Removed.
  • proximity/resources/event-after-navigation-new.html: Removed.
  • proximity/updates-expected.txt: Removed.
  • proximity/updates.html: Removed.
  • proximity/window-property-expected.txt: Removed.
  • proximity/window-property.html: Removed.
6:44 PM Changeset in webkit [220733] by Chris Dumez
  • 5 edits
    115 adds in trunk/LayoutTests

Import eventsource Web-Platform-Tests
https://bugs.webkit.org/show_bug.cgi?id=175556

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/eventsource/OWNERS: Added.
  • web-platform-tests/eventsource/README.md: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-close-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-close.htm: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-constructor-url-bogus-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-constructor-url-bogus.htm: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-eventtarget.worker-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-eventtarget.worker.html: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-eventtarget.worker.js: Added.

(async_test):

  • web-platform-tests/eventsource/dedicated-worker/eventsource-onmesage-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-onmesage.htm: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-onopen-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-onopen.htm: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-prototype-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-prototype.htm: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-url-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-url.htm: Added.
  • web-platform-tests/eventsource/dedicated-worker/w3c-import.log: Added.
  • web-platform-tests/eventsource/event-data-expected.txt: Added.
  • web-platform-tests/eventsource/event-data.html: Added.
  • web-platform-tests/eventsource/eventsource-close-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-close.htm: Added.
  • web-platform-tests/eventsource/eventsource-constructor-document-domain-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-constructor-document-domain.htm: Added.
  • web-platform-tests/eventsource/eventsource-constructor-non-same-origin-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-constructor-non-same-origin.htm: Added.
  • web-platform-tests/eventsource/eventsource-constructor-stringify-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-constructor-stringify.htm: Added.
  • web-platform-tests/eventsource/eventsource-constructor-url-bogus-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-constructor-url-bogus.htm: Added.
  • web-platform-tests/eventsource/eventsource-constructor-url-multi-window-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-constructor-url-multi-window.htm: Added.
  • web-platform-tests/eventsource/eventsource-eventtarget-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-eventtarget.htm: Added.
  • web-platform-tests/eventsource/eventsource-onmessage-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-onmessage-realm-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-onmessage-realm-support.htm: Added.
  • web-platform-tests/eventsource/eventsource-onmessage-realm.htm: Added.
  • web-platform-tests/eventsource/eventsource-onmessage-trusted-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-onmessage-trusted.htm: Added.
  • web-platform-tests/eventsource/eventsource-onmessage.htm: Added.
  • web-platform-tests/eventsource/eventsource-onopen-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-onopen.htm: Added.
  • web-platform-tests/eventsource/eventsource-prototype-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-prototype.htm: Added.
  • web-platform-tests/eventsource/eventsource-reconnect-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-reconnect.htm: Added.
  • web-platform-tests/eventsource/eventsource-url-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-url.htm: Added.
  • web-platform-tests/eventsource/format-bom-2-expected.txt: Added.
  • web-platform-tests/eventsource/format-bom-2.htm: Added.
  • web-platform-tests/eventsource/format-bom-expected.txt: Added.
  • web-platform-tests/eventsource/format-bom.htm: Added.
  • web-platform-tests/eventsource/format-comments-expected.txt: Added.
  • web-platform-tests/eventsource/format-comments.htm: Added.
  • web-platform-tests/eventsource/format-data-before-final-empty-line-expected.txt: Added.
  • web-platform-tests/eventsource/format-data-before-final-empty-line.htm: Added.
  • web-platform-tests/eventsource/format-field-data-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-data.htm: Added.
  • web-platform-tests/eventsource/format-field-event-empty-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-event-empty.htm: Added.
  • web-platform-tests/eventsource/format-field-event-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-event.htm: Added.
  • web-platform-tests/eventsource/format-field-id-2-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-id-2.htm: Added.
  • web-platform-tests/eventsource/format-field-id-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-id.htm: Added.
  • web-platform-tests/eventsource/format-field-parsing-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-parsing.htm: Added.
  • web-platform-tests/eventsource/format-field-retry-bogus-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-retry-bogus.htm: Added.
  • web-platform-tests/eventsource/format-field-retry-empty-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-retry-empty.htm: Added.
  • web-platform-tests/eventsource/format-field-retry-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-retry.htm: Added.
  • web-platform-tests/eventsource/format-field-unknown-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-unknown.htm: Added.
  • web-platform-tests/eventsource/format-leading-space-expected.txt: Added.
  • web-platform-tests/eventsource/format-leading-space.htm: Added.
  • web-platform-tests/eventsource/format-mime-bogus-expected.txt: Added.
  • web-platform-tests/eventsource/format-mime-bogus.htm: Added.
  • web-platform-tests/eventsource/format-mime-trailing-semicolon-expected.txt: Added.
  • web-platform-tests/eventsource/format-mime-trailing-semicolon.htm: Added.
  • web-platform-tests/eventsource/format-mime-valid-bogus-expected.txt: Added.
  • web-platform-tests/eventsource/format-mime-valid-bogus.htm: Added.
  • web-platform-tests/eventsource/format-newlines-expected.txt: Added.
  • web-platform-tests/eventsource/format-newlines.htm: Added.
  • web-platform-tests/eventsource/format-null-character-expected.txt: Added.
  • web-platform-tests/eventsource/format-null-character.html: Added.
  • web-platform-tests/eventsource/format-utf-8-expected.txt: Added.
  • web-platform-tests/eventsource/format-utf-8.htm: Added.
  • web-platform-tests/eventsource/interfaces-expected.txt: Added.
  • web-platform-tests/eventsource/interfaces.html: Added.
  • web-platform-tests/eventsource/request-accept-expected.txt: Added.
  • web-platform-tests/eventsource/request-accept.htm: Added.
  • web-platform-tests/eventsource/request-redirect-expected.txt: Added.
  • web-platform-tests/eventsource/request-redirect.htm: Added.
  • web-platform-tests/eventsource/request-status-error-expected.txt: Added.
  • web-platform-tests/eventsource/request-status-error.htm: Added.
  • web-platform-tests/eventsource/resources/accept.event_stream: Added.
  • web-platform-tests/eventsource/resources/cache-control.event_stream: Added.
  • web-platform-tests/eventsource/resources/cors-cookie.py: Added.

(main):

  • web-platform-tests/eventsource/resources/cors.py: Added.

(run_other):
(main):

  • web-platform-tests/eventsource/resources/init.htm: Added.
  • web-platform-tests/eventsource/resources/last-event-id.py: Added.

(main):

  • web-platform-tests/eventsource/resources/message.py: Added.

(main):

  • web-platform-tests/eventsource/resources/message2.py: Added.

(main):

  • web-platform-tests/eventsource/resources/reconnect-fail.py: Added.

(main):

  • web-platform-tests/eventsource/resources/status-error.py: Added.

(main):

  • web-platform-tests/eventsource/resources/status-reconnect.py: Added.

(main):

  • web-platform-tests/eventsource/resources/w3c-import.log: Added.
  • web-platform-tests/eventsource/w3c-import.log: Added.

LayoutTests:

  • tests-options.json:
6:39 PM Changeset in webkit [220732] by Simon Fraser
  • 27 edits
    6 deletes in trunk

Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
https://bugs.webkit.org/show_bug.cgi?id=175504

Reviewed by Sam Weinig.
Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

REQUEST_AUTOCOMPLETE was added in r133396 then removed in r148731, but brought back in r173596,
however no further work was done, and it was left disabled. So remove the code.

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/AutocompleteErrorEvent.h: Removed.
  • dom/AutocompleteErrorEvent.idl: Removed.
  • dom/EventNames.in:
  • dom/GlobalEventHandlers.idl:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore::HTMLFormElement::requestAutocomplete): Deleted.
(WebCore::HTMLFormElement::finishRequestAutocomplete): Deleted.
(WebCore::HTMLFormElement::requestAutocompleteTimerFired): Deleted.

  • html/HTMLFormElement.h:
  • html/HTMLFormElement.idl:
  • loader/EmptyClients.cpp:
  • loader/FrameLoaderClient.h:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didRequestAutocomplete): Deleted.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:
  • DOM/DOMHTMLFormElement.mm:

(-[DOMHTMLFormElement requestAutocomplete]): Deleted.

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
6:36 PM Changeset in webkit [220731] by Chris Dumez
  • 26 edits
    2 copies in trunk

XHR should only fire an abort event if the cancellation was requested by the client
https://bugs.webkit.org/show_bug.cgi?id=175546

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline several WPT tests now that a different error is sometimes used and that
more checks are passing.

  • web-platform-tests/XMLHttpRequest/open-url-multi-window-4-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub-expected.txt:
  • web-platform-tests/cors/allow-headers-expected.txt:
  • web-platform-tests/cors/origin-expected.txt:
  • web-platform-tests/cors/request-headers-expected.txt:
  • web-platform-tests/cors/response-headers-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_match_origin-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_match_wildcard-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_multi-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_null-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_origin-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_origin_uppercase-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_space-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_wildcard-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_zero-expected.txt:

Source/WebCore:

XHR should only fire an abort event if the cancellation was requested by the client, otherwise it should fire an error event.
Blink and Gecko already match the specification.

Specification:

Test: http/tests/navigation/page-cache-xhr-in-pagehide.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::abort):
(WebCore::XMLHttpRequest::abortError):
(WebCore::XMLHttpRequest::didFail):

  • xml/XMLHttpRequest.h:

LayoutTests:

  • http/tests/navigation/page-cache-xhr-expected.txt:
  • http/tests/navigation/page-cache-xhr-in-pagehide-expected.txt: Copied from LayoutTests/http/tests/navigation/page-cache-xhr-expected.txt.
  • http/tests/navigation/page-cache-xhr-in-pagehide.html: Copied from LayoutTests/http/tests/navigation/page-cache-xhr.html.
  • http/tests/navigation/page-cache-xhr.html:

When an XHR is pending and navigating away, we would send an abort event before the navigation and an error event after
restoring from PageCache. This bug was not seen before because the test only checked for error events, not abort ones.
The expected behavior is now that we fire an error event before navigating away, similar to the non-PageCache case.
The only case where the error event should be fired after restoring from PageCache is when an XHR is done in the pagehide
event handler, because it is too late to send the error event to the page before navigating in this case. I added test
coverage for this case.

  • http/tests/xmlhttprequest/navigation-should-abort-expected.txt:
  • http/tests/xmlhttprequest/navigation-should-abort.html:

This test was expecting an abort event on navigation which is against spec. This test was failing in Blink too.
Update the test to expect an error event instead.

5:53 PM Changeset in webkit [220730] by Simon Fraser
  • 37 edits
    12 deletes in trunk

Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
https://bugs.webkit.org/show_bug.cgi?id=175557

Reviewed by Jon Lee.
.:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSValueKeywords.in:
  • css/MediaFeatureNames.h:
  • css/MediaQueryEvaluator.cpp:

(WebCore::viewModeEvaluate): Deleted.

  • css/MediaQueryExpression.cpp:

(WebCore::featureWithValidIdent):
(WebCore::isFeatureValidWithoutValue):

  • page/Page.cpp:

(WebCore::Page::stringToViewMode): Deleted.
(WebCore::Page::setViewMode): Deleted.

  • page/Page.h:

(WebCore::Page::viewMode const): Deleted.

Source/WebCore/PAL:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • wtf/FeatureDefines.h:

Tools:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):
(setViewModeMediaFeatureCallback): Deleted.

  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setViewModeMediaFeature): Deleted.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setViewModeMediaFeature): Deleted.

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • fast/media/media-query-list-02-expected.txt: Removed.
  • fast/media/media-query-list-02.html: Removed.
  • fast/media/media-query-list-03-expected.txt: Removed.
  • fast/media/media-query-list-03.html: Removed.
  • fast/media/media-query-list-04-expected.txt: Removed.
  • fast/media/media-query-list-04.html: Removed.
  • fast/media/media-query-list-05-expected.txt: Removed.
  • fast/media/media-query-list-05.html: Removed.
  • fast/media/media-query-list-06-expected.txt: Removed.
  • fast/media/media-query-list-06.html: Removed.
  • fast/media/view-mode-media-feature-expected.html: Removed.
  • fast/media/view-mode-media-feature.html: Removed.
  • platform/gtk/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
5:44 PM Changeset in webkit [220729] by Ryan Haddad
  • 1 edit
    1 delete in branches/safari-604.1.38.1-branch/LayoutTests

Unreviewed test gardening, remove unneeded expected.txt file.

  • platform/mac-highsierra/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Removed.
5:36 PM Changeset in webkit [220728] by Ryan Haddad
  • 1 edit
    2 adds in branches/safari-604.1.38.1-branch/LayoutTests

Cherry-pick r220727.

5:33 PM Changeset in webkit [220727] by Ryan Haddad
  • 1 edit
    2 adds in trunk/LayoutTests

Rebaseline editing/mac/input/firstrectforcharacterrange-styled.html.

Unreviewed test gardening.

  • platform/mac-highsierra/editing/mac/input/firstrectforcharacterrange-styled-expected.txt: Added.
5:30 PM Changeset in webkit [220726] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

  • platform/ios-11/TestExpectations:
5:03 PM Changeset in webkit [220725] by mmaxfield@apple.com
  • 12 edits
    3 adds in trunk

Parse font-display
https://bugs.webkit.org/show_bug.cgi?id=175382

Reviewed by Simon Fraser.

Source/WebCore:

The syntax is very simple: font-display: auto | block | swap | fallback | optional.
So, parsing support is quite straightfoward.

Test: fast/text/font-display/parse.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::setLoadingBehavior):

  • css/CSSFontFace.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontLoadingBehavior const):

  • css/CSSProperties.json:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isDescriptorOnly):

  • css/CSSValueKeywords.in:
  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontFaceFontDisplay):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • fast/text/font-display/parse-expected.txt: Added.
  • fast/text/font-display/parse.html: Added.
4:37 PM Changeset in webkit [220724] by commit-queue@webkit.org
  • 17 edits
    1 add in trunk

JSTests:
Support the with keyword in DFG
https://bugs.webkit.org/show_bug.cgi?id=175470

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-14
Reviewed by Saam Barati.

Added a new stress-test for the 'with' keyword, that caught a bug in a
previous version of this code.

  • stress/with.js: Added.

(i.with):

Source/JavaScriptCore:
Support the 'with' keyword in DFG
https://bugs.webkit.org/show_bug.cgi?id=175470

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-14
Reviewed by Saam Barati.

Not particularly optimized at the moment, the goal is just to avoid
the DFG bailing out of any function with this keyword.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePushWithScope):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
4:33 PM Changeset in webkit [220723] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Obj-C exception crash in AVStreamSession when using EME in Private Browsing mode
https://bugs.webkit.org/show_bug.cgi?id=175547

Reviewed by Eric Carlson.

When the storagePath() is empty, do not use those AVStreamSession APIs which require a valid file path to stored
proof-of-key-release data.

Drive-by fix: return emptyString() from HTMLMediaElement::mediaPlayerMediaKeysStorageDirectory() when in Private
Browsing mode, to match the behavior of WebKitMediaKeySession.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerMediaKeysStorageDirectory const):

  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::releaseKeys):
(WebCore::CDMSessionAVStreamSession::update):
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):

4:21 PM Changeset in webkit [220722] by aestes@apple.com
  • 6 edits
    1 copy
    1 add in trunk

REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
https://bugs.webkit.org/show_bug.cgi?id=175548
<rdar://problem/33866206>

Reviewed by Brady Eidson.

Source/WebCore:

New API test: QuickLook.ShouldCreateForMIMEType

  • WebCore.xcodeproj/project.pbxproj:
  • loader/ios/PreviewLoader.h:
  • loader/ios/PreviewLoader.mm:

(WebCore::PreviewLoader::shouldCreateForMIMEType): Check if mimeType is a null String before
calling HashSet::contains().

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.

(TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().

4:04 PM Changeset in webkit [220721] by Ryan Haddad
  • 2 edits in trunk/JSTests

Skip flaky JSC test test/fieldopts/objtypespec-newobj-invalidation.1.js
https://bugs.webkit.org/show_bug.cgi?id=175544

Unreviewed test gardening.

  • ChakraCore.yaml:
3:55 PM Changeset in webkit [220720] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add some convenience utility accessor methods to MacroAssembler::CPUState.
https://bugs.webkit.org/show_bug.cgi?id=175549
<rdar://problem/33884868>

Reviewed by Saam Barati.

Previously, in order to read ProbeContext CPUState registers, we used to need to
do it this way:

ExecState* exec = reinterpret_cast<ExecState*>(cpu.fp());
uint32_t i32 = static_cast<uint32_t>(cpu.gpr(GPRInfo::regT0));
void* p = reinterpret_cast<void*>(cpu.gpr(GPRInfo::regT1));
uint64_t u64 = bitwise_cast<uint64_t>(cpu.fpr(FPRInfo::fpRegT0));

With this patch, we can now read them this way instead:

ExecState* exec = cpu.fp<ExecState*>();
uint32_t i32 = cpu.gpr<uint32_t>(GPRInfo::regT0);
void* p = cpu.gpr<void*>(GPRInfo::regT1);
uint64_t u64 = cpu.fpr<uint64_t>(FPRInfo::fpRegT0);

  • assembler/MacroAssembler.h:

(JSC:: const):
(JSC::MacroAssembler::CPUState::fpr const):
(JSC::MacroAssembler::CPUState::pc const):
(JSC::MacroAssembler::CPUState::fp const):
(JSC::MacroAssembler::CPUState::sp const):
(JSC::ProbeContext::pc):
(JSC::ProbeContext::fp):
(JSC::ProbeContext::sp):

3:38 PM Changeset in webkit [220719] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

WPT server should be able to do logging even if its output folder is not created at launch time
https://bugs.webkit.org/show_bug.cgi?id=175543

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-14
Reviewed by Alexey Proskuryakov.

Removing no longer used stdout/stderr member variables.
Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.

  • Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:

(WebPlatformTestServer.init):
(WebPlatformTestServer._prepare_config):
(WebPlatformTestServer._spawn_process):
(WebPlatformTestServer._stop_running_server):

3:04 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
Add ms2ger and aboya (diff)
3:03 PM Changeset in webkit [220718] by aestes@apple.com
  • 19 edits in trunk

[Apple Pay] Add support for phonetic contact names
https://bugs.webkit.org/show_bug.cgi?id=175537
<rdar://problem/32002644>

Reviewed by Tim Horton.

Source/WebCore:

  • Modules/applepay/ApplePayError.idl: Defined "phoneticName" in ApplePayErrorContactField.
  • Modules/applepay/ApplePayPaymentContact.h: Defined phoneticGivenName and phoneticFamilyName

in ApplePayPaymentContact.

  • Modules/applepay/ApplePayPaymentContact.idl: Ditto.
  • Modules/applepay/ApplePayPaymentRequest.h: Defined PhoneticName in

ApplePayPaymentRequest::ContactField.

  • Modules/applepay/ApplePayPaymentRequest.idl: Defined "phoneticName" in ApplePayContactField.
  • Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate): Added a version parameter. Added code to convert
ContactField::PhoneticName, throwing an exception if version is less than 3.

  • Modules/applepay/PaymentContact.h: Added a version parameter to fromApplePayPaymentContact().
  • Modules/applepay/PaymentRequest.h: Defined phoneticName in PaymentRequest::ContactFields

and defined PhoneticName in PaymentError::ContactField.

  • Modules/applepay/cocoa/PaymentContactCocoa.mm:

(WebCore::convert): Added a version parameter. Set a phoneticRepresentation on the
PKContact's name if there are non-empty phonetic names and version is 3 or greater.
(WebCore::PaymentContact::fromApplePayPaymentContact): Passed version to convert().

Source/WebKit:

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: Soft-linked PKContactFieldPhoneticName.

(WebKit::toPKContactFields): Added code to append PKContactFieldPhoneticName to result if
contactFields.phoneticName is true.
(WebKit::toNSError): Specified PKContactFieldPhoneticName as the contact field for
PaymentError::ContactField::PhoneticName.

LayoutTests:

  • http/tests/ssl/applepay/ApplePayError-expected.txt:
  • http/tests/ssl/applepay/ApplePayError.html:
  • http/tests/ssl/applepay/ApplePaySession-expected.txt:
  • http/tests/ssl/applepay/ApplePaySession.html:
  • http/tests/ssl/applepay/ApplePaySessionV3-expected.txt:
  • http/tests/ssl/applepay/ApplePaySessionV3.html:
3:00 PM Changeset in webkit [220717] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

The none smooth stroke applied to an SVG shape breaks its hit testing
https://bugs.webkit.org/show_bug.cgi?id=175506

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-14
Reviewed by Simon Fraser.

Source/WebCore:

Clear RenderSVGShape::m_path when calling RenderSVGRect::updateShapeFromElement().
The m_path will be recalculated when RenderSVGShape::updateShapeFromElement()
is called from RenderSVGRect::shapeDependentStrokeContains().

Test: svg/stroke/stroke-linejoin-click.html

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::updateShapeFromElement):

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::clearPath):

LayoutTests:

  • svg/stroke/stroke-linejoin-click-expected.html: Added.
  • svg/stroke/stroke-linejoin-click.html: Added.
2:28 PM Changeset in webkit [220716] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

  • platform/ios-11/TestExpectations:
2:14 PM Changeset in webkit [220715] by dbates@webkit.org
  • 9 edits
    1 add in trunk/Tools

webkit-patch: Passing --no-review should submit patch to EWS by default
https://bugs.webkit.org/show_bug.cgi?id=148899

Reviewed by David Kilzer.

Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
to these commands to not submit a non-reviewed patch(es) for EWS analysis.

Frequently I want to post a draft of a patch without review to have the EWS bots process
it to catch build and test breakage before I clean it up and post it for formal review.
Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
parse the attachment id from the response page after adding an attachment to the bug.
(Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
HTTP response after uploading the patch.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(testparse_attachment_id_from_add_patch_to_bug_response): Added.

  • Scripts/webkitpy/tool/commands/upload.py:

(Upload): Add step SubmitToEWS to the list of steps when uploading a patch.
(PostCommits.init): Add --no-ews option to the list of applicable option flags for
this command.
(PostCommits.execute): Submit the patch to EWS, if applicable.

  • Scripts/webkitpy/tool/commands/upload_unittest.py:

(test_upload): Set options.ews to False as the upload command expects this option
to be specified.
(test_upload_with_no_review_and_ews): Added.

  • Scripts/webkitpy/tool/steps/init.py: Import module SubmitToEWS.
  • Scripts/webkitpy/tool/steps/options.py:

(Options): Added command line option --no-ews (defaults: False - submit to EWS).

  • Scripts/webkitpy/tool/steps/postdiff.py:

(PostDiff.options): Add --no-ews option to the list of applicable option flags for
this command.
(PostDiff.run): Submit the patch to EWS, if applicable.

  • Scripts/webkitpy/tool/steps/submittoews.py: Added.

(SubmitToEWS):
(SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
(SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.

12:28 PM Changeset in webkit [220714] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

[css-ui] Implement caret-color support
https://bugs.webkit.org/show_bug.cgi?id=166572
<rdar://problem/33852589>

Update GTK expected results following r220706.

  • platform/gtk/editing/style/5065910-expected.txt:
  • platform/gtk/editing/style/5084241-expected.txt:
11:42 AM Changeset in webkit [220713] by Adrian Perez de Castro
  • 5 edits in trunk

[WPE] Implement WebCore::standardUserAgent()
https://bugs.webkit.org/show_bug.cgi?id=175507

Reviewed by Michael Catanzaro.

Remove "_GLIB" from user-agent version macros.

.:

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:

Source/WebCore:

  • platform/glib/UserAgentGLib.cpp:

(WebCore::versionForUAString):

11:33 AM Changeset in webkit [220712] by fpizlo@apple.com
  • 12 edits
    1 add in trunk/Source

Put the ScopedArgumentsTable's ScopeOffset array in some gigacage
https://bugs.webkit.org/show_bug.cgi?id=174921

Reviewed by Mark Lam.

Source/JavaScriptCore:

Uses CagedUniquePtr<> to cage the ScopeOffset array.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitScopedArgumentsGetByVal):

  • runtime/ScopedArgumentsTable.cpp:

(JSC::ScopedArgumentsTable::create):
(JSC::ScopedArgumentsTable::setLength):

  • runtime/ScopedArgumentsTable.h:

Source/WTF:

If you want to std::unique_ptr a class that knows that it should be in the Gigacage, then we
would create the Gigacage equivalent of WTF_MAKE_FAST_ALLOCATED and it would just work.

But this does not work if we want to std::unique_ptr a primitive type. So, this patch adds a
solution for this problem: CagedUniquePtr<>. This will handle allocation
(CagedUniquePtr<>::create()) and deallocation (in the style of std::unique_ptr). It has three
variants:

  • Non-array types.
  • Arrays that don't have destructors.
  • Arrays that have destructors.


Just like std::unique_ptr, the array case is triggered by saying "[]" at the end of the type.

Unlike std::unique_ptr and most other smart pointers, the whole point of this smart pointer is
to dictate where the thing you're pointing at is allocated. For this reason, it has to know how
to do things like the array destructor protocol. So it creates its own: the CagedUniquePtr for
arrays with destructors is a fat pointer that remembers the length of the array.

CagedUniquePtr<> makes it impossible to leak/release the pointer. This is stricter than what
std::unique_ptr does, and is probably appropriate for all of the places where we would use this
type.

So far, we only use it for ScopedArgumentsTable::m_arguments, but I suspect that it will be
useful in other places.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/CagedUniquePtr.h: Added.

(WTF::CagedUniquePtr::CagedUniquePtr):
(WTF::CagedUniquePtr::create):
(WTF::CagedUniquePtr::operator=):
(WTF::CagedUniquePtr::~CagedUniquePtr):
(WTF::CagedUniquePtr::get const):
(WTF::CagedUniquePtr::getMayBeNull const):
(WTF::CagedUniquePtr::operator== const):
(WTF::CagedUniquePtr::operator!= const):
(WTF::CagedUniquePtr::operator bool const):
(WTF::CagedUniquePtr::operator* const):
(WTF::CagedUniquePtr::operator-> const):
(WTF::CagedUniquePtr::operator[] const):
(WTF::CagedUniquePtr::destroy):

  • wtf/Gigacage.cpp:

(Gigacage::tryMallocArray):
(Gigacage::malloc):
(Gigacage::mallocArray):

  • wtf/Gigacage.h:
11:32 AM Changeset in webkit [220711] by Ryan Haddad
  • 2 edits in trunk/Tools

Disable two flaky VideoControlsManager API tests.

Unreviewed test gardening.

  • TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:

(TestWebKitAPI::TEST):

10:56 AM Changeset in webkit [220710] by Matt Baker
  • 14 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove text-shadow and gradient backgrounds
https://bugs.webkit.org/show_bug.cgi?id=175430

Reviewed by Brian Burg.

Inspector should more closely match flat system look. Remove text-shadow
embossing and replace linear gradients in popover backgrounds and selected
tree item background color.

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content > .pseudo-classes > .group > label):

  • UserInterface/Views/CompletionSuggestionsView.css:

(.completion-suggestions-container:not(:active) > .item.selected,):

  • UserInterface/Views/DebuggerDashboardView.css:

(.toolbar .dashboard.debugger):

  • UserInterface/Views/HierarchicalPathComponent.css:

(.hierarchical-path-component > .title):

  • UserInterface/Views/Main.css:

(.bouncy-highlight):

  • UserInterface/Views/NavigationSidebarPanel.css:

(.sidebar > .panel.navigation > .content .empty-content-placeholder > .message):

  • UserInterface/Views/Popover.js:

(WI.Popover.prototype._drawBackground):

  • UserInterface/Views/RecordingTraceDetailsSidebarPanel.css:

(.sidebar > .details.recording-trace > .content > .no-trace-data > .message):

  • UserInterface/Views/RulesStyleDetailsPanel.css:

(.sidebar > .panel.details.css-style .rules .label):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules.filter-non-matching > .no-filter-results > .no-filter-results-message):
(@media (-webkit-min-device-pixel-ratio: 2)): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label.filter-matching-label,): Deleted.

  • UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.css:

(.style-spreadsheet .inherited):

  • UserInterface/Views/TimelineDataGrid.css:

(.tree-outline.timeline-data-grid .item:hover):

  • UserInterface/Views/TimelineDataGrid.js:

(WI.TimelineDataGrid.prototype._createPopoverContent):

  • UserInterface/Views/Variables.css:

(:root):

10:56 AM Changeset in webkit [220709] by timothy_horton@apple.com
  • 4 edits
    1 add in trunk

Only create directory and sandbox extension handle for storage directories if they are set
https://bugs.webkit.org/show_bug.cgi?id=175522

Reviewed by Brady Eidson.

Source/WebKit:

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
If using a non-persistent WebsiteDataStore, all the storage directories
are unset, but we still try to create them and make sandbox extensions
for them. This has no effect except a ton of noisy logging, but that
is reason enough to stop.

This is similar to r216053, but for more directories.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.

(TEST):
Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
doesn't log anything to stderr.

10:44 AM Changeset in webkit [220708] by Jonathan Bedard
  • 4 edits in trunk/Tools

sub-categorize Sandbox violation logs
https://bugs.webkit.org/show_bug.cgi?id=175536
<rdar://problem/33834416>

Reviewed by David Kilzer.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
a Sandbox violation.
(CrashLogs._find_all_logs_darwin): Update comment.

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing.
(CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
(CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
(CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.

  • Scripts/webkitpy/port/darwin.py:

(DarwinPort._merge_crash_logs): Handle Sandbox violation case.

10:42 AM Changeset in webkit [220707] by Chris Dumez
  • 38 edits
    4 deletes in trunk

Unreviewed, rollout r220622 & r220696
https://bugs.webkit.org/show_bug.cgi?id=175482
<rdar://problem/33860695>

Seems to have caused failures on iOS.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt:
  • web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-star.any-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker-expected.txt:
  • web-platform-tests/fetch/api/redirect/redirect-count-expected.txt:
  • web-platform-tests/fetch/api/redirect/redirect-count-worker-expected.txt:
  • web-platform-tests/fetch/api/request/request-keepalive-quota-expected.txt:
  • web-platform-tests/fetch/http-cache/cc-request-expected.txt:

Source/WebCore:

  • CMakeLists.txt:
  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::BlobLoader::didReceiveResponse):
(WebCore::FetchBodyOwner::BlobLoader::didFail):

  • Modules/fetch/FetchBodyOwner.h:
  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):
(WebCore::FetchLoader::didFail):

  • Modules/fetch/FetchLoaderClient.h:
  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didFail):

  • Modules/fetch/FetchResponse.h:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::finishLoading):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::isMainOrMediaOrIconOrRawResource const):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestMedia):
(WebCore::CachedResourceLoader::requestIcon):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::CachedResourceLoader::requestMainResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/KeepaliveRequestTracker.cpp: Removed.
  • loader/cache/KeepaliveRequestTracker.h: Removed.
  • platform/network/FormData.cpp:

(WebCore::FormData::appendFile):
(WebCore::FormData::appendFileRange):
(WebCore::FormData::appendBlob):
(WebCore::FormData::expandDataStore):

  • platform/network/FormData.h:

LayoutTests:

  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
  • http/tests/contentextensions/async-xhr-onerror-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-iframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt:
  • http/wpt/beacon/beacon-quota-expected.txt: Removed.
  • http/wpt/beacon/beacon-quota.html: Removed.
  • inspector/worker/resources-in-worker-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/http-cache/cc-request-expected.txt:
10:29 AM Changeset in webkit [220706] by dbates@webkit.org
  • 28 edits
    14 adds in trunk

[css-ui] Implement caret-color support
https://bugs.webkit.org/show_bug.cgi?id=166572
<rdar://problem/33852589>

Reviewed by David Hyatt.

Source/WebCore:

Add support for the CSS property caret-color as per <https://www.w3.org/TR/css-ui-3/#caret-color> (02 March 2017).
The property caret-color specifies the color of the text insertion caret in an editable element,
say an HTML textarea element.

Unlike other CSS color properties caret-color can have value "auto" and this is its initial
value. Internally we treat value "auto" as an invalid caret color to simplify the code.

Tests: editing/pasteboard/preserve-caret-color.html

fast/css/caret-color-auto.html
fast/css/caret-color-fallback-to-color.html
fast/css/caret-color-inherit.html
fast/css/caret-color-span-inside-editable-parent.html
fast/css/caret-color.html
fast/history/visited-link-caret-color.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSProperties.json: Add property caret-color. We represent the initial "auto" Also, fix up

wording in a comment while I am here.

  • css/StyleResolver.cpp:

(WebCore::isValidVisitedLinkProperty): Add caret-color to the list of properties that can be
applied to visited hyperlinks.

  • css/parser/CSSParserFastPaths.cpp:

(WebCore::parseCaretColor): Added.
(WebCore::CSSParserFastPaths::maybeParseValue): Unlike other CSS color properties caret-color
can be defined to be "auto". We explicitly check if the property is caret-color and use
parseCaretColor() to parse its value.

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeCaretColor): Added.
(WebCore::CSSPropertyParser::parseSingleValue): Similar to the change to CSSParserFastPaths::maybeParseValue()
use a dedicated code path to parse caret-color.

  • editing/EditingStyle.cpp: Preserve caret-color during editing operations.
  • editing/FrameSelection.cpp:

(WebCore::CaretBase::paintCaret const): Modified code to query property caret-color instead of
color for the color of the text insertion caret. Always honor the caret-color of the editable
element if it is valid color. Note that "caret-color: auto" is treated as an invalid color
internally. A caret-color can have an invalid color if its inherits from the CSS color property
with an invalid color. If caret-color is a valid color then we take it to be the color of the
text insertion caret. Otherwise, we do what we do today and use a heuristic to determine the
color of the text-insertion caret.
(WebCore::disappearsIntoBackground): Deleted; moved logic into CaretBase::paintCaret().

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Add property wrapper
to support animating caret-color.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline const): Modified to consider
changes to caret color.
(WebCore::RenderStyle::colorIncludingFallback const): Modified to compute the appropriate
color for property caret-color with respect to an unvisited or visited link.

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setCaretColor): Added.
(WebCore::RenderStyle::setVisitedLinkCaretColor): Added.
(WebCore::RenderStyle::caretColor const): Added.
(WebCore::RenderStyle::visitedLinkCaretColor const): Added.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Modified to consider caret color.
(WebCore::StyleRareInheritedData::operator== const): Ditto.

  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

Add reference tests to ensure that we do not regress CSS property caret-color.

  • TestExpectations: Unskip Web Platform Tests that now pass.
  • editing/deleting/maintain-style-after-delete-expected.txt: Updated expected result.
  • editing/inserting/insert-paragraph-with-font-and-background-color-expected.txt: Ditto.
  • editing/pasteboard/do-not-copy-unnecessary-styles-2-expected.txt: Ditto.
  • editing/pasteboard/onpaste-text-html-expected.txt: Ditto.
  • editing/pasteboard/preserve-caret-color-expected.txt: Added.
  • editing/pasteboard/preserve-caret-color.html: Added.
  • editing/pasteboard/preserve-underline-color-expected.txt:
  • fast/css/caret-color-auto-expected.html: Added.
  • fast/css/caret-color-auto.html: Added.
  • fast/css/caret-color-expected.html: Added.
  • fast/css/caret-color-fallback-to-color-expected.html: Added.
  • fast/css/caret-color-fallback-to-color.html: Added.
  • fast/css/caret-color-inherit-expected.html: Added.
  • fast/css/caret-color-inherit.html: Added.
  • fast/css/caret-color-span-inside-editable-parent-expected.html: Added.
  • fast/css/caret-color-span-inside-editable-parent.html: Added.
  • fast/css/caret-color.html: Added.
  • fast/events/before-input-events-prevent-drag-and-drop-expected.txt: Updated expected result.
  • fast/events/input-events-paste-rich-datatransfer-expected.txt: Ditto.
  • fast/events/ondrop-text-html-expected.txt: Ditto.
  • fast/history/visited-link-caret-color-expected.html: Added.
  • fast/history/visited-link-caret-color.html: Added.
  • platform/ios/TestExpectations: Skip the tests on iOS as iOS does not enable

ENABLE(TEXT_CARET). UIKit renders the text insertion caret on iOS.

  • platform/mac/editing/style/5065910-expected.txt: Updated expected result.
  • platform/mac/editing/style/5084241-expected.png: Ditto.
  • platform/mac/editing/style/5084241-expected.txt: Ditto.
  • platform/ios-wk2/editing/style/5084241-expected.txt: Ditto.
10:25 AM Changeset in webkit [220705] by dbates@webkit.org
  • 1 edit
    6 adds in trunk/Tools

Add Automator service to copy permalink to Clipboard
https://bugs.webkit.org/show_bug.cgi?id=170978

Reviewed by Joseph Pecoraro.

It is helpful to reference using a hyperlink a particular line of code when having
a discussion on IRC or in a bug. You can get such a link by navigating to the file
in the Trac Browse Source viewer and selecting the line your are interested in.
I found myself doing this often enough that I wrote an Automator service to do it
for me.

This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.

  • CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
  • CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
  • CopyPermalink/README: Added.
10:14 AM Changeset in webkit [220704] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

  • platform/ios-11/TestExpectations:
10:09 AM Changeset in webkit [220703] by Chris Dumez
  • 2 edits in trunk/Tools

Address flakiness related to download tests
https://bugs.webkit.org/show_bug.cgi?id=175338
<rdar://problem/33865119>

Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
between tests.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

10:08 AM Changeset in webkit [220702] by Ryan Haddad
  • 3 edits in branches/safari-604.1.38.1-branch/LayoutTests

Cherry-pick r220474.

9:41 AM Changeset in webkit [220701] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: fix Windows build.
https://bugs.webkit.org/show_bug.cgi?id=175446

Not reviewed.

  • assembler/MacroAssemblerX86Common.cpp:

(JSC::booleanTrueForAvoidingNoReturnDeclaration):
(JSC::ctiMasmProbeTrampoline):

9:41 AM Changeset in webkit [220700] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebKit

[CoordGraphics] Simplify CoordinatedGraphicsScene state updates
https://bugs.webkit.org/show_bug.cgi?id=175528

Reviewed by Carlos Garcia Campos.

Hold the information about state updates in ThreadedCompositor, in the
m_attributes struct. This way we don't need to store the updates in
functors and accumulate them in the CoordinatedGraphicsScene class, but
instead just apply any pending state update or atlas removal before the
scene is rendered.

This removes the need to update the CoordinatedGraphicsScene object from
the main thread with data that ultimately has to be handled on the
composition thread. Similarly, when updating CoordinatedGraphicsScene, we
only need to synchronize on the m_attributes lock object once in order to
retrieve the scene update information, instead of having each functor do
that repeatedly.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::applyStateChanges):
(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebKit::CoordinatedGraphicsScene::detach):
(WebKit::CoordinatedGraphicsScene::setActive):
(WebKit::CoordinatedGraphicsScene::syncRemoteContent): Deleted.
(WebKit::CoordinatedGraphicsScene::appendUpdate): Deleted.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::releaseUpdateAtlases):

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
9:37 AM Changeset in webkit [220699] by zandobersek@gmail.com
  • 4 edits in trunk

REGRESSION(r220517-r220521) [GTK] Various compositing tests fail
https://bugs.webkit.org/show_bug.cgi?id=175478

Reviewed by Sergio Villar Senin.

Source/WebCore:

Fix a regression introduced in r220519. Move a framebuffer binding in TextureMapperGL
away from GraphicsContext3D and onto the OpenGL API to work around the framebuffer
binding state that's kept in the GraphicsContext3D class. This mismatch in how the
framebuffer was bound was causing a couple of test failures in compositing tests.

No new tests -- regressed tests have their failure expectations removed.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindDefaultSurface): Don't use GraphicsContext3D for the
glBindFramebuffer() call. This would be done in subsequent patches that would move
TextureMapperGL off the GraphicsContext3D usage, but this specific use case clashes
with the framebuffer binding that's done in BitmapTextureGL and was causing test
failures.

LayoutTests:

  • platform/gtk/TestExpectations: Remove failure and flakiness expectations.
9:08 AM Changeset in webkit [220698] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220694 - [GTK][WPE] Avoid emitting WebKitFaviconDatabase::favicon-changed multiple times while setting an icon
https://bugs.webkit.org/show_bug.cgi?id=175531

Reviewed by Michael Catanzaro.

When webkitFaviconDatabaseSetIconForPageURL() is called, both setIconURLForPageURL() and setIconDataForIconURL()
might notify the client, which ends up emitting the WebKitFaviconDatabase::favicon-changed signal and calling
webkitFaviconDatabaseSetIconURLForPageURL(). Both things are already done by
webkitFaviconDatabaseSetIconForPageURL() itself, so we can just ignore the client notification while setting a
new icon.

  • UIProcess/API/glib/WebKitFaviconDatabase.cpp:

(webkitFaviconDatabaseSetIconURLForPageURL): Return early if isSettingIcon is true.
(webkitFaviconDatabaseSetIconForPageURL): Set isSettingIcon to true for the scope.

9:06 AM Changeset in webkit [220697] by Carlos Garcia Campos
  • 8 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220685 - Factor text autosizing into a class
https://bugs.webkit.org/show_bug.cgi?id=175530

Reviewed by Andreas Kling.

Move the remaining parts out of Document.

  • css/StyleBuilderCustom.h:

(WebCore::computeLineHeightMultiplierDueToFontSize):

  • dom/Document.cpp:

(WebCore::Document::destroyRenderTree):
(WebCore::Document::textAutoSizing):
(WebCore::TextAutoSizingTraits::constructDeletedValue): Deleted.
(WebCore::TextAutoSizingTraits::isDeletedValue): Deleted.
(WebCore::Document::addAutoSizedNode): Deleted.
(WebCore::Document::updateAutoSizedNodes): Deleted.
(WebCore::Document::clearAutoSizedNodes): Deleted.

  • dom/Document.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustComputedFontSizes):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::adjustComputedFontSizesOnBlocks):
(WebCore::RenderElement::resetTextAutosizing):

  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingTraits::constructDeletedValue):
(WebCore::TextAutoSizingTraits::isDeletedValue):
(WebCore::TextAutoSizing::addTextNode):
(WebCore::TextAutoSizing::updateRenderTree):
(WebCore::TextAutoSizing::reset):

  • rendering/TextAutoSizing.h:
8:54 AM Changeset in webkit [220696] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed fix after r220622 to address crashes on iOS.

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::finishLoading):

8:49 AM Changeset in webkit [220695] by Carlos Garcia Campos
  • 7 edits
    3 adds in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220681 - GTK-focused gardening.
https://bugs.webkit.org/show_bug.cgi?id=175529

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-14

  • http/wpt/css/css-pseudo-4/marker-font-properties-expected.html: Set line-height for more reliable rendering.
  • http/wpt/css/css-pseudo-4/marker-font-properties.html: Set line-height for more reliable rendering.
  • media/video-fullscreen-restriction-removed-expected.txt: DOMException's toString was changed in r219663; rebaseline. (The test is marked as flaky on mac.)
  • platform/gtk/TestExpectations:
  • platform/gtk/http/tests/dom/document-attributes-null-handling-expected.txt: SecurityError got a new message in r220376; rebaseline.
  • platform/gtk/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: Added: GTK does not yet enable the in-progress ServiceWorker implementation.
  • platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt: TypeError got a new message in r220622; rebaseline.
  • platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt: Added: TypeError uses a different message on GTK.
8:44 AM Changeset in webkit [220694] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] Avoid emitting WebKitFaviconDatabase::favicon-changed multiple times while setting an icon
https://bugs.webkit.org/show_bug.cgi?id=175531

Reviewed by Michael Catanzaro.

When webkitFaviconDatabaseSetIconForPageURL() is called, both setIconURLForPageURL() and setIconDataForIconURL()
might notify the client, which ends up emitting the WebKitFaviconDatabase::favicon-changed signal and calling
webkitFaviconDatabaseSetIconURLForPageURL(). Both things are already done by
webkitFaviconDatabaseSetIconForPageURL() itself, so we can just ignore the client notification while setting a
new icon.

  • UIProcess/API/glib/WebKitFaviconDatabase.cpp:

(webkitFaviconDatabaseSetIconURLForPageURL): Return early if isSettingIcon is true.
(webkitFaviconDatabaseSetIconForPageURL): Set isSettingIcon to true for the scope.

8:38 AM Changeset in webkit [220693] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220677 - [GTK][WPE] Crash in IconDatabase::IconRecord::setImageData()
https://bugs.webkit.org/show_bug.cgi?id=175527

Reviewed by Žan Doberšek.

The problem is that when setImageData() is called from IconDatabase::readFromDatabase() the shared buffer might
be nullptr, because getImageDataForIconURLFromSQLDatabase() returns nullptr if the icon data is not in the database.

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::IconRecord::setImageData): Return early if passed in buffer is nullptr.

8:38 AM Changeset in webkit [220692] by Carlos Garcia Campos
  • 1 edit
    5 adds in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220655 - [GTK] Update some test expectations.
https://bugs.webkit.org/show_bug.cgi?id=175480

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-14

  • platform/gtk/TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/webrtc/simplecall-expected.txt: Added.
8:35 AM Changeset in webkit [220691] by Carlos Garcia Campos
  • 15 edits
    1 add
    2 deletes in releases/WebKitGTK/webkit-2.18

Merge r220646 - [Render Tree Mutation] First letter should not mutate the render tree while in layout.
https://bugs.webkit.org/show_bug.cgi?id=163848
Source/WebCore:

Reviewed by Zalan Bujtas.

RenderBlock::updateFirstLetter shouldn't be called during layout. Instead it should
be invoked by the RenderTreeUpdater.

With this future patches can move updateFirstLetter() and the related functions
completely out of the render tree.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layout):

No more updateFirstLetter calls during layout...

(WebCore::RenderBlock::computePreferredLogicalWidths):

...or preferred width computation.

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderBlock.h:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::updateFirstLetter):

  • rendering/RenderRubyRun.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::updateFirstLetter):

  • rendering/RenderTable.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::updateFirstLetter):

  • rendering/svg/RenderSVGText.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent):

Call updateFirstLetter when closing the element. All of of descedant renderers are known here
so this can be resolved correctly.

LayoutTests:

<rdar://problem/33402718>

Reviewed by Zalan Bujtas.

  • fast/text-autosizing/ios/first-letter-expected.html: Added.

Turn into reftest for easier debugging and robustness.

  • imported/blink/fast/css/first-letter-range-insert-expected.txt:

This is crash-or-assert test and the output change here doesn't matter.

  • platform/ios/fast/text-autosizing/ios/first-letter-expected.txt: Removed.
  • platform/mac/fast/text-autosizing/ios/first-letter-expected.txt: Removed.
8:29 AM Changeset in webkit [220690] by Carlos Garcia Campos
  • 12 edits
    2 adds in releases/WebKitGTK/webkit-2.18

Merge r220639 - Composition underline color is always black
https://bugs.webkit.org/show_bug.cgi?id=174675

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.

Test: editing/composition-underline-color.html

  • editing/CompositionUnderline.h:

(WebCore::CompositionUnderline::CompositionUnderline):
Added new attribute compositionUnderlineColor.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionUnderline):
Use the text color if compositionUnderlineColor is TextColor.

Source/WebKit:

This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(WebKit::WebViewImpl::setMarkedText): Use text color
for composition underline in the plain text case.

  • UIProcess/gtk/InputMethodFilter.cpp:

(WebKit::InputMethodFilter::handleKeyboardEventWithCompositionResults):
Use text color for composition underline.
(WebKit::InputMethodFilter::updatePreedit): Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setCompositionForTesting): Ditto.

Source/WebKitLegacy/mac:

  • WebView/WebHTMLView.mm:

(extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(-[WebHTMLView setMarkedText:selectedRange:]): Use text color
for composition underline in the plain text case.

Source/WebKitLegacy/win:

  • WebView.cpp:

(WebView::setCompositionForTesting): Use text color for
composition underline.

LayoutTests:

Added new test to check that the composition underline
is using the text color.
The test hides the text and the caret, so it only shows
the composition underline and checks against an -expected-mismatch
that the color of the composition marker is different.

  • editing/composition-underline-color-expected-mismatch.html: Added.
  • editing/composition-underline-color.html: Added.
8:26 AM Changeset in webkit [220689] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220638 - [GTK] stop kinetic scrolling when a zero movement is reached
https://bugs.webkit.org/show_bug.cgi?id=175468

Reviewed by Michael Catanzaro.

This is GTK+ change by Christian Hergert.
https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=4f63d839550f7a9038b391e7d3e1e6fc8bdfafa6

When the kinetic scrolling reduces its speed, there can be multiple frames where the movement is zero pixels,
followed by a 1 pixel movement later on. This causes a "jitter" right at the end of the scroll which makes it
feel less quality than other platforms. Instead, we should just clamp it as soon as we get a zero movement.

  • platform/ScrollAnimationKinetic.cpp:

(WebCore::ScrollAnimationKinetic::PerAxisData::animateScroll):

8:25 AM Changeset in webkit [220688] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220632 - Drop non-const getter for CachedResource::resourceRequest()
https://bugs.webkit.org/show_bug.cgi?id=175524

Reviewed by Youenn Fablet.

Drop non-const getter for CachedResource::resourceRequest(). It would be unsafe to modify the request of a CachedResource
after it has been cached. Exposing such a getter is therefore a footgun.

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::resourceRequest const):
(WebCore::CachedResource::ignoreForRequestCount const):
(WebCore::CachedResource::setIgnoreForRequestCount):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

  • loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::ignoreForRequestCount const):
(WebCore::CachedResourceRequest::setIgnoreForRequestCount):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::addImageToCache):

  • platform/network/ResourceRequestBase.h:
8:09 AM Changeset in webkit [220687] by Carlos Garcia Campos
  • 9 edits
    1 move in releases/WebKitGTK/webkit-2.18

Merge r220631 - [WPE] Implement WebCore::standardUserAgent()
https://bugs.webkit.org/show_bug.cgi?id=175507

Reviewed by Carlos Alberto Lopez Perez.

Implement missing User-Agent handling for the WPE port by sharing the code with the GTK+ port.

.:

  • Source/cmake/OptionsGTK.cmake: Rename "GTK" with "GLIB" in UA version macros.
  • Source/cmake/OptionsWPE.cmake: Add UA version macros.

Source/WebCore:

  • PlatformGTK.cmake: Handlde renaming of UserAgentGtk.cpp to UserAgentGLib.cpp.
  • PlatformWPE.cmake: Add UserAgentGLib.cpp and UserAgentQuirks.cpp to the list of built WebCore sources.
  • platform/glib/UserAgentGLib.cpp: Renamed from Source/WebCore/platform/gtk/UserAgentGtk.cpp.

(WebCore::versionForUAString): Change "GTK" in UA version macros to "GLIB".

Source/WebKit:

  • UIProcess/API/glib/WebKitSettings.cpp: Remove preprocessor conditionals for the WPE port.

(webkit_settings_set_user_agent):
(webkit_settings_set_user_agent_with_application_details):

  • UIProcess/wpe/WebPageProxyWPE.cpp:

(WebKit::WebPageProxy::standardUserAgent): Remove hardcoded value and make use of WebCore::standardUserAgent().

8:09 AM Changeset in webkit [220686] by Carlos Garcia Campos
  • 13 edits
    1 move in releases/WebKitGTK/webkit-2.18/Source

Merge r220621 - [WTF] Move ValueToString into WTF
https://bugs.webkit.org/show_bug.cgi?id=175469

Reviewed by Sam Weinig.

Source/WebCore:

No new tests. No change in behavior.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.h:

(WTF::ValueToString<WebCore::TextTrackCue::string):
(WebCore::ValueToString<TextTrackCue::string): Deleted.
(WebCore::ValueToString<MediaTime>::string): Deleted.

  • platform/LayoutUnit.h:

(WTF::ValueToString<WebCore::LayoutUnit>::string):
(WebCore::ValueToString<LayoutUnit>::string): Deleted.

  • platform/PODInterval.h:
  • platform/PODIntervalTree.h:
  • platform/PODRedBlackTree.h:
  • platform/graphics/FloatPolygon.h:

(WTF::ValueToString<WebCore::FloatPolygonEdge::string):
(WebCore::ValueToString<FloatPolygonEdge::string): Deleted.

  • rendering/FloatingObjects.h:

(WTF::ValueToString<WebCore::FloatingObject::string):
(WebCore::ValueToString<FloatingObject::string): Deleted.

  • rendering/RenderFlowThread.h:

(WTF::ValueToString<WebCore::RenderRegion::string):
(WebCore::ValueToString<RenderRegion::string): Deleted.

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/text/ValueToString.h: Renamed from Source/WebCore/platform/ValueToString.h.
6:20 AM Changeset in webkit [220685] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

Factor text autosizing into a class
https://bugs.webkit.org/show_bug.cgi?id=175530

Reviewed by Andreas Kling.

Move the remaining parts out of Document.

  • css/StyleBuilderCustom.h:

(WebCore::computeLineHeightMultiplierDueToFontSize):

  • dom/Document.cpp:

(WebCore::Document::destroyRenderTree):
(WebCore::Document::textAutoSizing):
(WebCore::TextAutoSizingTraits::constructDeletedValue): Deleted.
(WebCore::TextAutoSizingTraits::isDeletedValue): Deleted.
(WebCore::Document::addAutoSizedNode): Deleted.
(WebCore::Document::updateAutoSizedNodes): Deleted.
(WebCore::Document::clearAutoSizedNodes): Deleted.

  • dom/Document.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustComputedFontSizes):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::adjustComputedFontSizesOnBlocks):
(WebCore::RenderElement::resetTextAutosizing):

  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingTraits::constructDeletedValue):
(WebCore::TextAutoSizingTraits::isDeletedValue):
(WebCore::TextAutoSizing::addTextNode):
(WebCore::TextAutoSizing::updateRenderTree):
(WebCore::TextAutoSizing::reset):

  • rendering/TextAutoSizing.h:
6:12 AM Changeset in webkit [220684] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220620 - [Bindings] Simplify DOMPromiseProxy now that WTF::Function can return references
https://bugs.webkit.org/show_bug.cgi?id=175394

Patch by Sam Weinig <sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

  • bindings/IDLTypes.h:

(WebCore::IDLWrapper::convertToParameterType): Deleted.

Remove no longer used convertToParameterType.

  • bindings/js/DOMPromiseProxy.h:
  • Replace Variant<Value, Exception> with ExceptionOr<Value> / ExceptionOr<void>.
  • Update ResolveCallback to have a return type of IDLType::ParameterType, rather than IDLType::ImplementationType, now that WTF::Function supports references as the return type. This is needed, since the IDLType::ParameterType for an interface T is T&.
  • css/FontFace.cpp:
  • css/FontFace.h:
  • css/FontFaceSet.cpp:
  • css/FontFaceSet.h:

Update resolve callbacks to return a reference rather than a RefPtr, matching
the new signature requirement.

6:02 AM Changeset in webkit [220683] by Carlos Garcia Campos
  • 17 edits
    11 copies
    1 move
    2 deletes in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220619 - [WebIDL] Replace JSCryptoKeyCustom and JSCryptoAlgorithmBuilder with generated code
https://bugs.webkit.org/show_bug.cgi?id=175457

Patch by Sam Weinig <sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCryptoAlgorithmBuilder.cpp: Removed.
  • bindings/js/JSCryptoAlgorithmBuilder.h: Removed.
  • bindings/js/JSCryptoKeyCustom.cpp: Removed.

Remove JSCryptoAlgorithmBuilder and JSCryptoKeyCustom, add KeyAlgorithm
IDLs and headers.

  • crypto/CryptoKey.cpp:
  • crypto/CryptoKey.h:
  • crypto/CryptoKey.idl:

Replace custom algorithm attribute with a union of the supported key algorithms.

  • crypto/keys/CryptoAesKeyAlgorithm.h: Added.
  • crypto/keys/CryptoAesKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoEcKeyAlgorithm.h: Added.
  • crypto/keys/CryptoEcKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoHmacKeyAlgorithm.h: Added.
  • crypto/keys/CryptoHmacKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoKeyAlgorithm.h: Added.
  • crypto/keys/CryptoKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoRsaHashedKeyAlgorithm.h: Added.
  • crypto/keys/CryptoRsaHashedKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoRsaKeyAlgorithm.h: Added.
  • crypto/keys/CryptoRsaKeyAlgorithm.idl: Added.

Add IDLs and headers fo the supported key algorithms.

  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyEC.h:
  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.h:
  • crypto/keys/CryptoKeyRaw.h:

Give each of the existing KeyAlgorithm subclasses a dictionary() function
that returns the populated corresponding spec'd dictionary.

5:57 AM Changeset in webkit [220682] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220616 - Some RenderSVGResource cleanup
https://bugs.webkit.org/show_bug.cgi?id=175494

Reviewed by Zalan Bujtas.

Use more initializers. Remove spurious use of bitfields that didn't save any space at all.
0 -> nullptr.

No behavior change.

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):

  • rendering/svg/RenderSVGResourceContainer.h:
  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):

  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::strokeShape):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGRenderingContext.h:

(WebCore::SVGRenderingContext::SVGRenderingContext):

5:28 AM Changeset in webkit [220681] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk/LayoutTests

GTK-focused gardening.
https://bugs.webkit.org/show_bug.cgi?id=175529

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-14

  • http/wpt/css/css-pseudo-4/marker-font-properties-expected.html: Set line-height for more reliable rendering.
  • http/wpt/css/css-pseudo-4/marker-font-properties.html: Set line-height for more reliable rendering.
  • media/video-fullscreen-restriction-removed-expected.txt: DOMException's toString was changed in r219663; rebaseline. (The test is marked as flaky on mac.)
  • platform/gtk/TestExpectations:
  • platform/gtk/http/tests/dom/document-attributes-null-handling-expected.txt: SecurityError got a new message in r220376; rebaseline.
  • platform/gtk/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: Added: GTK does not yet enable the in-progress ServiceWorker implementation.
  • platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt: TypeError got a new message in r220622; rebaseline.
  • platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt: Added: TypeError uses a different message on GTK.
5:11 AM Changeset in webkit [220680] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.18

Merge r220601 - WTF::Function does not allow for reference / non-default constructible return types
https://bugs.webkit.org/show_bug.cgi?id=175244
Source/JavaScriptCore:

Reviewed by Chris Dumez.

  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

Reviewed by Chris Dumez.

  • bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

Reviewed by Chris Dumez.

  • UIProcess/WebResourceLoadStatisticsStore.h:

Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

Reviewed by Chris Dumez.

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

  • wtf/Function.h:

(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

Tools:

<rdar://problem/33801582>

Reviewed by Chris Dumez.

  • TestWebKitAPI/Tests/WTF/Function.cpp:

(TestWebKitAPI::TEST):

4:25 AM Changeset in webkit [220679] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220594 - Remove RenderQuote collection from RenderView
https://bugs.webkit.org/show_bug.cgi?id=175479

Reviewed by Andreas Kling.

We can do it well enough without maintaining this pointer structure.

Global updating doesn't work well with future direction for first-letter and similar anyway.
We need to update quote immediately when updating its style.

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::insertedIntoTree):
(WebCore::RenderQuote::willBeRemovedFromTree):

Just tell the view that there are renderers to update.

(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::isOpen const):
(WebCore::RenderQuote::updateRenderer):
(WebCore::RenderQuote::updateRenderers): Deleted.

Update single renderer only. RenderTreeUpdater provides the previous renderer to compute the depth.

  • rendering/RenderQuote.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::registerQuote): Deleted.
(WebCore::RenderView::unregisterQuote): Deleted.
(WebCore::RenderView::updateSpecialRenderers): Deleted.

Remove the quote list.

  • rendering/RenderView.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::commit):

Ensure that all quotes are updated.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):
(WebCore::RenderTreeUpdater::updateQuotesUpTo):

Traverse render tree to find quotes to update starting from the previous updated quote.

  • style/RenderTreeUpdater.h:
4:16 AM Changeset in webkit [220678] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220586 - [GTK][WPE] Overriden virtual function not marked “override” in ImageBufferDataCairo.h
https://bugs.webkit.org/show_bug.cgi?id=175476

Reviewed by Carlos Garcia Campos.

  • platform/graphics/cairo/ImageBufferDataCairo.h: Add missing "override" qualifier.
4:12 AM Changeset in webkit [220677] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] Crash in IconDatabase::IconRecord::setImageData()
https://bugs.webkit.org/show_bug.cgi?id=175527

Reviewed by Žan Doberšek.

The problem is that when setImageData() is called from IconDatabase::readFromDatabase() the shared buffer might
be nullptr, because getImageDataForIconURLFromSQLDatabase() returns nullptr if the icon data is not in the database.

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::IconRecord::setImageData): Return early if passed in buffer is nullptr.

4:08 AM Changeset in webkit [220676] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebDriver

Merge r220584 - Fix build warning in WebDriverService.h
https://bugs.webkit.org/show_bug.cgi?id=166682

Unreviewed build fix.

  • WebDriverService.h: Fixes the warning: class 'Capabilities' was previously declared as a struct [-Wmismatched-tags]
4:07 AM Changeset in webkit [220675] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.18

Merge r220583 - [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
https://bugs.webkit.org/show_bug.cgi?id=175378

Reviewed by Sergio Villar Senin.

Source/WebCore:

Bring back part of the code removed in r206732, to keep a reference to the SoupMessage in the
AuthenticationChallenge since it can be different to the resource message.

  • platform/network/soup/AuthenticationChallenge.h:

(WebCore::AuthenticationChallenge::AuthenticationChallenge): Deleted.
(WebCore::AuthenticationChallenge::authenticationClient const): Deleted.
(WebCore::AuthenticationChallenge::soupAuth const): Deleted.
(WebCore::AuthenticationChallenge::setProposedCredential): Deleted.

  • platform/network/soup/AuthenticationChallengeSoup.cpp:

(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::AuthenticationChallenge::platformCompare):

Source/WebKit:

In case of HTTPS resource with a proxy, libsoup uses a tunnel internally, that uses its own SoupMessage during
the proxy authentication. We were ignoring authentication requests for other messages.

  • NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::authenticateCallback): Only return early if the message does't match and it's not
HTTPS resource over a proxy.
(WebKit::NetworkDataTaskSoup::authenticate): Use the soup message from the authentication challenge.
(WebKit::NetworkDataTaskSoup::continueAuthenticate): Ditto.

Tools:

Add two test cases to check proxy authentication.

  • TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:

(Tunnel::Tunnel):
(Tunnel::~Tunnel):
(Tunnel::connect):
(Tunnel::connected):
(serverCallback):
(ProxyAuthenticationTest::ProxyAuthenticationTest):
(ProxyAuthenticationTest::~ProxyAuthenticationTest):
(ProxyAuthenticationTest::proxyServerPortAsString):
(testWebViewAuthenticationProxy):
(testWebViewAuthenticationProxyHTTPS):
(beforeAll):

4:06 AM Changeset in webkit [220674] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220581 - [Soup] Do not spawn the network process to setup cookie persistent storage
https://bugs.webkit.org/show_bug.cgi?id=175424

Reviewed by Sergio Villar Senin.

The persistent storage configuration is saved and passed to network process as creation parameters, so we don't
need to spawn the network process to configure it, when it's created eventually it will use the configuration.

  • UIProcess/soup/WebCookieManagerProxySoup.cpp:

(WebKit::WebCookieManagerProxy::setCookiePersistentStorage): Use sendToNetworkingProcess() instead of
endToNetworkingProcessRelaunchingIfNecessary().

4:05 AM Changeset in webkit [220673] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220580 - [GTK][WPE] Assertion failure in TimerBase inside WebCore::IconRecord::setImageData
https://bugs.webkit.org/show_bug.cgi?id=173866
<rdar://problem/33122050>

Reviewed by Michael Catanzaro.

IconDatabase creates and destroys IconRecord objects in both database and main thread. If the IconRecord has a
valid icon, its Image could be created in one thread and destroyed in another, something that is not expected to
happen, because Image has a Timer member. Since we have all the data and we are decoding it right after creating
the Image, we don't really need to keep the Image object around, we could simply take a reference of the encoded
data and the decoded native image to be returned by synchronousIconForPageURL().

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::IconRecord::image): Return NativeImagePtr now.
(WebKit::IconDatabase::IconRecord::setImageData): Create a BitmapImage to decode it and keep a reference to the
encoded data and decoded native image.
(WebKit::IconDatabase::IconRecord::snapshot const): Use m_imageData to get the encoded data.
(WebKit::IconDatabase::synchronousIconForPageURL): Return the native image and whether the icon is known or not.
(WebKit::IconDatabase::IconRecord::loadImageFromResource): Deleted.

  • UIProcess/API/glib/IconDatabase.h:
  • UIProcess/API/glib/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously): Use new API.

3:23 AM Changeset in webkit [220672] by zandobersek@gmail.com
  • 6 edits in trunk/Source/WebKit

[ThreadedCompositor] Improve composition and update state handling
https://bugs.webkit.org/show_bug.cgi?id=172448

Reviewed by Carlos Garcia Campos.

In the ThreadedCompositor and related classes, we now track composition
and scene update states separately. This enables properly piping in the
DisplayRefreshMonitor object, leveraging it for both display refresh
notifications and signalling to the client that the scene update is
completed.

In CompositingRunLoop, two separate states are now used, one for
compositing and the other for scene update. Access to both should be done
while the related Lock object is held. The pending update state is also
tracked in order to schedule any required updates as soon as the current
state update is completed.

In ThreadedCompositor, the information about client notification and
update completion coordination is now also kept under a Lock object,
moving away from atomics. DisplayRefreshMonitor can now utilize just
two methods in order to either schedule an update or report that update
as finished.

  • Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::CompositingRunLoop):
(WebKit::CompositingRunLoop::scheduleUpdate):
(WebKit::CompositingRunLoop::stopUpdates):
(WebKit::CompositingRunLoop::compositionCompleted):
(WebKit::CompositingRunLoop::updateCompleted):
(WebKit::CompositingRunLoop::updateTimerFired):
(WebKit::CompositingRunLoop::isActive): Deleted.

  • Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:

(WebKit::CompositingRunLoop::stateLock):

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::m_displayRefreshMonitor):
(WebKit::ThreadedCompositor::sceneUpdateFinished):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::requestDisplayRefreshMonitorUpdate):
(WebKit::ThreadedCompositor::handleDisplayRefreshMonitorUpdate):
(WebKit::ThreadedCompositor::renderNextFrameIfNeeded): Deleted.
(WebKit::ThreadedCompositor::completeCoordinatedUpdateIfNeeded): Deleted.
(WebKit::ThreadedCompositor::coordinateUpdateCompletionWithClient): Deleted.

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

(WebKit::ThreadedDisplayRefreshMonitor::requestRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):

2:46 AM Changeset in webkit [220671] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220570 - Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=175272
<rdar://problem/33756962>

Since accessibilityPress is async, we shouldn't rely on the timeout.

Reviewed by Chris Fleizach.

  • accessibility/press-target-uses-text-descendant-node.html:
2:45 AM Changeset in webkit [220670] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220569 - Make ThreadGlobalData RefCounted for web thread
https://bugs.webkit.org/show_bug.cgi?id=175439

Reviewed by Mark Lam.

When the web thread is enabled, we share ThreadGlobalData between the web thread and the main thread.
The problem happens when the main thread is dying. It could start deallocating TLS and the web
thread may see the destructed ThreadGlobalData.

Even though, the current implementation is safe because the main thread do not perform TLS deallocation
in the Darwin environment. But this is not true in Windows. And we should not rely on this condition
that depends on the platforms.

In this patch, we make ThreadGlobalData ThreadSafeRefCounted. This type verbosely describes that
ThreadGlobalData could be shared between threads when the web thread enabled. And make the life time
management simple instead of relying on the platform dependent TLS implementation.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::cachedResourceRequestInitiators): Deleted.
(WebCore::ThreadGlobalData::eventNames): Deleted.
(WebCore::ThreadGlobalData::threadTimers): Deleted.
(WebCore::ThreadGlobalData::qualifiedNameCache): Deleted.
(WebCore::ThreadGlobalData::cachedConverterICU): Deleted.
(WebCore::ThreadGlobalData::cachedConverterTEC): Deleted.

2:42 AM Changeset in webkit [220669] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18

Merge r220567 - Unreviewed, attempt to fix build failure with VC2017

Source/WTF:

  • wtf/PriorityQueue.h:

Tools:

  • TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(TEST):

2:41 AM Changeset in webkit [220668] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220566 - [JSC] Use @toNumber in builtins
https://bugs.webkit.org/show_bug.cgi?id=172692

Reviewed by Sam Weinig.

Use @toNumber bytecode intrinsic. It emits op_to_number, which efficiently converts
a given argument to a number.

  • Modules/streams/ReadableByteStreamInternals.js:

(privateInitializeReadableByteStreamController):
(readableByteStreamControllerRespond):

  • Modules/streams/StreamInternals.js:

(validateAndNormalizeQueuingStrategy):
(enqueueValueWithSize):

2:40 AM Changeset in webkit [220667] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Tools

Merge r220565 - Unreviewed, suppress warnings on GCC

  • TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

(TestWebKitAPI::CheckedArithmeticTester::run):

2:39 AM Changeset in webkit [220666] by Carlos Garcia Campos
  • 7 edits
    1 copy in releases/WebKitGTK/webkit-2.18

Merge r220562 - Run more WTF tests
https://bugs.webkit.org/show_bug.cgi?id=174970

Reviewed by Michael Catanzaro.

Source/WTF:

CHAR_BIT is not defined.

  • wtf/LEBDecoder.h:

Tools:

Some of WTF tests are not executed in non Apple ports while they are generic ones.
This patch adds these tests to non-Apple port TestWebKitAPI.
Currently, we do not add Signals.cpp since it depends on signal functionality.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(isHigherPriority):
(TEST):

  • TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.

(TEST):

  • TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:

(TEST):

2:38 AM Changeset in webkit [220665] by Carlos Garcia Campos
  • 15 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r220556 - Apply the UNLIKELY macro to some unlikely things.
https://bugs.webkit.org/show_bug.cgi?id=175440
<rdar://problem/33834767>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::jettison):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::disassemble):

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalizeCommon):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileOSRExit):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeCommon):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::compileWithoutLinking):
(JSC::JIT::link):

  • runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::installCode):

  • runtime/VM.cpp:

(JSC::VM::VM):

Source/WebKit:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getBytecodeProfile):

2:37 AM Changeset in webkit [220664] by Carlos Garcia Campos
  • 6 edits
    3 adds in releases/WebKitGTK/webkit-2.18

Merge r220551 - AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/33782159>

Reviewed by Chris Fleizach.

Source/WebCore:

The issue here is that we manualy set the parent object of the AccessibilitySVGRoot object
and there are chances that the parent doesn't detach it properly during the parent's destroying
process. Accessing the stale parent object will lead to a crash.
Fixed this by making the parent object a weak pointer so we don't access an invalid memory.

Test: accessibility/add-children-pseudo-element.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::createWeakPtr):

  • accessibility/AccessibilitySVGRoot.cpp:

(WebCore::AccessibilitySVGRoot::AccessibilitySVGRoot):
(WebCore::AccessibilitySVGRoot::setParent):
(WebCore::AccessibilitySVGRoot::parentObject const):

  • accessibility/AccessibilitySVGRoot.h:

LayoutTests:

  • accessibility/add-children-pseudo-element-expected.txt: Added.
  • accessibility/add-children-pseudo-element.html: Added.
  • accessibility/resources/svg-circle.svg: Added.
2:35 AM Changeset in webkit [220663] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r220548 - [WTF] ThreadSpecific should not introduce additional indirection
https://bugs.webkit.org/show_bug.cgi?id=175187

Reviewed by Mark Lam.

Source/JavaScriptCore:

  • runtime/Identifier.cpp:

Source/WebCore:

We drop ThreadSpecific::replace feature which is only used by
Web thread. Instead, we use ThreadSpecific<std::unique_ptr<T>> here.

While this std::unique_ptr<T> shares one instance between main thread
and web thread, this is the same to the current implementation. It is
safe because the web thread never finishes.

And for non-web thread implementation, we just use ThreadSpecific<T>,
since it is the most efficient.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):
We also drop StringImpl::empty() call since it is not necessary now:
StringImpl::empty data is statically initialized by using constexpr.

  • platform/ThreadGlobalData.h:

We make it FAST_ALLOCATED since it is previously allocated by fast malloc
in ThreadSpecific.

Source/WTF:

ThreadSpecific sets Data* to the TLS. And Data holds T*, which
is fast allocated actual data. But ideally, we should store T
instance directly in Data instead of introducing an additional
indirection.

This patch adds storage in Data in order to embed the instance of T. The constructor
for Data will invoke the constructor for T on the embedded storage. We also drop
ThreadSpecific::replace which is only used by the web thread to set its thread specific
ThreadGlobalData to the one shared from the main thread. The existing implementation
relies on the main thread and the web thread never exiting in order for the shared
ThreadGlobalData to stay alive. We can achieve the same semantics by using a
ThreadSpecific<std::unique_ptr<T>> to hold the ThreadGlobalData instance instead.

  • wtf/ThreadSpecific.h:

(WTF::ThreadSpecific::Data::construct):
(WTF::ThreadSpecific::Data::Data):
We make it fast allocated since we previously allocated ThreadSpecific T data by fastMalloc.

(WTF::ThreadSpecific::Data::~Data):
(WTF::ThreadSpecific::Data::storagePointer const):
(WTF::canBeGCThread>::get):
We also drop RELEASE_ASSERT from ::get(). We already inserted this assert to setAndConstruct(),
so when creating the member to this TLS, we execute this release assert. So it is
not necessary to execute this assertion every time we get data from this TLS.

(WTF::canBeGCThread>::set):
(WTF::canBeGCThread>::destroy):
(WTF::canBeGCThread>::setAndConstruct):
(WTF::T):
(WTF::canBeGCThread>::replace): Deleted.

2:03 AM Changeset in webkit [220662] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.18

Merge r220538 - Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
https://bugs.webkit.org/show_bug.cgi?id=175436
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):

Source/WebCore:

  • platform/audio/cocoa/MediaSessionManagerCocoa.cpp:

(PlatformMediaSessionManager::updateSessionState):

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):

Source/WebKit:

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData):

Tools:

  • TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:

(TestWebKitAPI::TEST_F):

2:00 AM Changeset in webkit [220661] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220531 - Addressing post-review comments after r219173.
https://bugs.webkit.org/show_bug.cgi?id=174149

Unreviewed.

  • css/CSSFontStyleValue.h:
  • editing/EditingStyle.cpp:

(WebCore::identifierForStyleProperty):

1:59 AM Changeset in webkit [220660] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220528 - Try to fix windows build.

  • style/StyleUpdate.h:

(WebCore::Style::TextUpdate::TextUpdate):

1:57 AM Changeset in webkit [220659] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220527 - [GTK] Don't use --whole-archive linking flags for the WebKit2 target libraries
https://bugs.webkit.org/show_bug.cgi?id=175416

Reviewed by Carlos Garcia Campos.

  • PlatformGTK.cmake: Drop the ADD_WHOLE_ARCHIVE_TO_LIBRARIES instruction

for the WebKit2 target. This unnecessarily bundles complete archive
files both into the main .so library as well as single executables that
are linked against the WebKit2 target.

1:56 AM Changeset in webkit [220658] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220525 - [GTK] Crashes in WebCore::PasteboardHelper::fillSelectionData when source file of drag is unavailable
https://bugs.webkit.org/show_bug.cgi?id=174161

Reviewed by Xabier Rodriguez-Calvar.

In r219385 we changed the early return in fillSelectionData() to check the selection data length instead of the
data pointer. However, the gtk_selection_data_get_length() can return -1, so we need to check also if the value
less than 0. The case of setting an empty string could be valid depending on the target type, so it's better to
return early only when data lenght is less than 0 and handle the 0 length case in each target.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillSelectionData):

1:55 AM Changeset in webkit [220657] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220524 - Unreviewed GTK+ gardening. Update expectations of several tests failing at r220516.

  • platform/gtk/TestExpectations:
1:50 AM Changeset in webkit [220656] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220523 - Text renderer updates should be done by RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=175417

Reviewed by Andreas Kling.

All render tree mutations should be done by RenderTreeUpdater. Currently
Text::updateRendererAfterContentChange calls RenderText::setTextWithOffset directly.

  • dom/Document.cpp:

(WebCore::Document::updateTextRenderer):

Add range argument.

  • dom/Document.h:
  • dom/Text.cpp:

(WebCore::Text::updateRendererAfterContentChange):

Remove call to setTextWithOffset and pass the range to updateTextRenderer

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateTextRenderer):

Call setTextWithOffset here.

  • style/RenderTreeUpdater.h:
  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree):

  • style/StyleUpdate.cpp:

(WebCore::Style::Update::textUpdate const):
(WebCore::Style::Update::addText):

Add TextUpdate struct similar to ElementUpdate to pass the range to the RenderTreeUpdater.

  • style/StyleUpdate.h:
1:28 AM Changeset in webkit [220655] by commit-queue@webkit.org
  • 2 edits
    5 adds in trunk/LayoutTests

[GTK] Update some test expectations.
https://bugs.webkit.org/show_bug.cgi?id=175480

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-14

  • platform/gtk/TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/webrtc/simplecall-expected.txt: Added.
1:19 AM Changeset in webkit [220654] by Carlos Garcia Campos
  • 258 edits
    2 moves in releases/WebKitGTK/webkit-2.18

Merge r220503 - [WTF] Move TextStream into WTF
https://bugs.webkit.org/show_bug.cgi?id=175211

Reviewed by Myles C. Maxfield.

Source/WebCore:

No new tests. No change in behavior.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ComposedTreeIterator.cpp:
  • dom/Position.cpp:
  • dom/Position.h:
  • dom/Range.cpp:

(WebCore::operator<<):

  • dom/Range.h:
  • dom/ViewportArguments.cpp:
  • dom/ViewportArguments.h:
  • editing/VisiblePosition.cpp:
  • editing/VisiblePosition.h:
  • editing/VisibleSelection.cpp:
  • editing/VisibleSelection.h:
  • html/HTMLVideoElement.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • page/FrameView.cpp:
  • page/ViewportConfiguration.cpp:
  • page/ViewportConfiguration.h:
  • page/WheelEventDeltaFilter.cpp:
  • page/animation/CSSPropertyAnimation.cpp:
  • page/scrolling/AsyncScrollingCoordinator.cpp:
  • page/scrolling/ScrollingConstraints.cpp:
  • page/scrolling/ScrollingConstraints.h:
  • page/scrolling/ScrollingCoordinator.cpp:
  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingStateFixedNode.cpp:
  • page/scrolling/ScrollingStateFixedNode.h:
  • page/scrolling/ScrollingStateFrameScrollingNode.cpp:
  • page/scrolling/ScrollingStateFrameScrollingNode.h:
  • page/scrolling/ScrollingStateNode.cpp:
  • page/scrolling/ScrollingStateNode.h:
  • page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
  • page/scrolling/ScrollingStateOverflowScrollingNode.h:
  • page/scrolling/ScrollingStateScrollingNode.cpp:
  • page/scrolling/ScrollingStateScrollingNode.h:
  • page/scrolling/ScrollingStateStickyNode.cpp:
  • page/scrolling/ScrollingStateStickyNode.h:
  • page/scrolling/ScrollingTree.cpp:
  • page/scrolling/ScrollingTreeFrameScrollingNode.cpp:
  • page/scrolling/ScrollingTreeFrameScrollingNode.h:
  • page/scrolling/ScrollingTreeNode.cpp:
  • page/scrolling/ScrollingTreeNode.h:
  • page/scrolling/ScrollingTreeScrollingNode.cpp:
  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.mm:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
  • page/scrolling/mac/ScrollingTreeStickyNode.h:
  • page/scrolling/mac/ScrollingTreeStickyNode.mm:
  • platform/CalculationValue.cpp:
  • platform/CalculationValue.h:
  • platform/LayoutUnit.cpp:
  • platform/LayoutUnit.h:
  • platform/Length.cpp:
  • platform/Length.h:
  • platform/LengthBox.cpp:
  • platform/LengthBox.h:
  • platform/LengthPoint.cpp:
  • platform/LengthPoint.h:
  • platform/LengthSize.cpp:
  • platform/LengthSize.h:
  • platform/LogMacros.h:
  • platform/ScrollView.cpp:
  • platform/ScrollableArea.cpp:
  • platform/animation/TimingFunction.cpp:
  • platform/animation/TimingFunction.h:
  • platform/graphics/BitmapImage.cpp:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Color.cpp:
  • platform/graphics/Color.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp:
  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/FloatPoint.cpp:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatPoint3D.cpp:
  • platform/graphics/FloatPoint3D.h:
  • platform/graphics/FloatRect.cpp:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatRoundedRect.cpp:
  • platform/graphics/FloatRoundedRect.h:
  • platform/graphics/FloatSize.cpp:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontTaggedSettings.cpp:
  • platform/graphics/FontTaggedSettings.h:
  • platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::dump const):

  • platform/graphics/GradientImage.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::dumpAdditionalProperties const):

  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/Image.cpp:
  • platform/graphics/Image.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/IntPoint.cpp:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.cpp:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.cpp:
  • platform/graphics/IntSize.h:
  • platform/graphics/LayoutPoint.cpp:
  • platform/graphics/LayoutPoint.h:
  • platform/graphics/LayoutRect.cpp:
  • platform/graphics/LayoutRect.h:
  • platform/graphics/LayoutSize.cpp:
  • platform/graphics/LayoutSize.h:
  • platform/graphics/NamedImageGeneratedImage.cpp:
  • platform/graphics/NamedImageGeneratedImage.h:
  • platform/graphics/Path.cpp:
  • platform/graphics/Path.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCAAnimation.cpp:
  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/PlatformCALayer.cpp:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/TileController.cpp:
  • platform/graphics/ca/TileGrid.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/PDFDocumentImage.cpp:
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/cocoa/IOSurface.mm:
  • platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::description const):

  • platform/graphics/displaylists/DisplayList.h:
  • platform/graphics/displaylists/DisplayListItems.cpp:
  • platform/graphics/displaylists/DisplayListItems.h:
  • platform/graphics/displaylists/DisplayListRecorder.cpp:
  • platform/graphics/displaylists/DisplayListReplayer.cpp:
  • platform/graphics/filters/DistantLightSource.cpp:
  • platform/graphics/filters/DistantLightSource.h:
  • platform/graphics/filters/FEBlend.cpp:
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEConvolveMatrix.cpp:
  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEDiffuseLighting.cpp:
  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/FEDisplacementMap.cpp:
  • platform/graphics/filters/FEDisplacementMap.h:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FEDropShadow.h:
  • platform/graphics/filters/FEFlood.cpp:
  • platform/graphics/filters/FEFlood.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:
  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FEMerge.cpp:
  • platform/graphics/filters/FEMerge.h:
  • platform/graphics/filters/FEMorphology.cpp:
  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp:
  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FESpecularLighting.cpp:
  • platform/graphics/filters/FESpecularLighting.h:
  • platform/graphics/filters/FETile.cpp:
  • platform/graphics/filters/FETile.h:
  • platform/graphics/filters/FETurbulence.cpp:
  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/FilterOperation.cpp:
  • platform/graphics/filters/FilterOperation.h:
  • platform/graphics/filters/FilterOperations.cpp:
  • platform/graphics/filters/FilterOperations.h:
  • platform/graphics/filters/LightSource.h:
  • platform/graphics/filters/PointLightSource.cpp:
  • platform/graphics/filters/PointLightSource.h:
  • platform/graphics/filters/SourceAlpha.cpp:
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp:
  • platform/graphics/filters/SourceGraphic.h:
  • platform/graphics/filters/SpotLightSource.cpp:
  • platform/graphics/filters/SpotLightSource.h:
  • platform/graphics/transforms/AffineTransform.cpp:
  • platform/graphics/transforms/AffineTransform.h:
  • platform/graphics/transforms/IdentityTransformOperation.h:
  • platform/graphics/transforms/Matrix3DTransformOperation.cpp:
  • platform/graphics/transforms/Matrix3DTransformOperation.h:
  • platform/graphics/transforms/MatrixTransformOperation.cpp:
  • platform/graphics/transforms/MatrixTransformOperation.h:
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp:
  • platform/graphics/transforms/PerspectiveTransformOperation.h:
  • platform/graphics/transforms/RotateTransformOperation.cpp:
  • platform/graphics/transforms/RotateTransformOperation.h:
  • platform/graphics/transforms/ScaleTransformOperation.cpp:
  • platform/graphics/transforms/ScaleTransformOperation.h:
  • platform/graphics/transforms/SkewTransformOperation.cpp:
  • platform/graphics/transforms/SkewTransformOperation.h:
  • platform/graphics/transforms/TransformOperation.cpp:
  • platform/graphics/transforms/TransformOperation.h:
  • platform/graphics/transforms/TransformOperations.cpp:
  • platform/graphics/transforms/TransformOperations.h:
  • platform/graphics/transforms/TransformationMatrix.cpp:
  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/graphics/transforms/TranslateTransformOperation.cpp:
  • platform/graphics/transforms/TranslateTransformOperation.h:
  • platform/ios/SelectionRect.cpp:

(WebCore::operator<<):

  • platform/ios/SelectionRect.h:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/text/TextAllInOne.cpp:
  • rendering/InlineBox.cpp:
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::outputLineTreeAndMark const):

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:
  • rendering/InlineTextBox.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::outputLineTreeAndMark const):

  • rendering/RenderBlockFlow.h:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderTreeAsText.cpp:
  • rendering/RenderTreeAsText.h:
  • rendering/ScrollAlignment.cpp:
  • rendering/ScrollAlignment.h:
  • rendering/SimpleLineLayoutCoverage.cpp:
  • rendering/SimpleLineLayoutFunctions.cpp:
  • rendering/SimpleLineLayoutFunctions.h:
  • rendering/style/FillLayer.cpp:
  • rendering/style/FillLayer.h:
  • rendering/style/NinePieceImage.cpp:
  • rendering/style/NinePieceImage.h:
  • rendering/style/RenderStyleConstants.cpp:
  • rendering/style/RenderStyleConstants.h:
  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/svg/SVGRenderTreeAsText.h:

(WebCore::operator<<):

  • svg/SVGLengthValue.cpp:
  • svg/SVGLengthValue.h:
  • svg/graphics/SVGImage.cpp:
  • svg/graphics/SVGImage.h:
  • svg/graphics/filters/SVGFEImage.cpp:
  • svg/graphics/filters/SVGFEImage.h:

Source/WebKit:

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
  • Shared/VisibleContentRectUpdateInfo.cpp:
  • Shared/VisibleContentRectUpdateInfo.h:
  • Shared/mac/RemoteLayerTreeTransaction.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/ios/WKContentView.mm:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(WebKit::operator<<):

  • UIProcess/ios/WebPageProxyIOS.mm:
  • WebProcess/WebPage/ios/WebPageIOS.mm:
  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/text/TextStream.cpp: Renamed from Source/WebCore/platform/text/TextStream.cpp.

(WTF::TextStream::writeIndent):

  • wtf/text/TextStream.h: Renamed from Source/WebCore/platform/text/TextStream.h.

(WTF::TextStream::FormatNumberRespectingIntegers::FormatNumberRespectingIntegers):

Tools:

  • TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
12:40 AM Changeset in webkit [220653] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18/Source/JavaScriptCore

Merge r220500 - [JSC] Create JSSet constructor that accepts it's size as parameter
https://bugs.webkit.org/show_bug.cgi?id=173297

Reviewed by Saam Barati.

This patch is adding a new constructor to JSSet that gives its
expected initial size. It is important to avoid re-hashing and mutiple
allocations when we know the final size of JSSet, such as in
CodeBlock::setConstantIdentifierSetRegisters.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setConstantIdentifierSetRegisters):

  • runtime/HashMapImpl.h:

(JSC::HashMapImpl::HashMapImpl):

  • runtime/JSSet.h:
12:34 AM Changeset in webkit [220652] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220486 - LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=175194

Reviewed by Chris Fleizach.

In the test we have no way to control which iframe will be loaded first.
Output the logs at the end of the test so that they are in order.

  • accessibility/presentation-role-iframe.html:
12:33 AM Changeset in webkit [220651] by Carlos Garcia Campos
  • 3 edits
    2 deletes in releases/WebKitGTK/webkit-2.18

Merge r220484 - Unreviewed, rolling out r219334.
https://bugs.webkit.org/show_bug.cgi?id=175398

Caused bug 175023 (Requested by ap on #webkit).

Reverted changeset:

"[SVG] Leak in SVGAnimatedListPropertyTearOff"
https://bugs.webkit.org/show_bug.cgi?id=172545
http://trac.webkit.org/changeset/219334

12:25 AM Changeset in webkit [220650] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.18

Merge r220481 - Early error on ANY operator before new.target
https://bugs.webkit.org/show_bug.cgi?id=157970

Reviewed by Saam Barati.

Instead of throwing if any unary operator precedes new.target, only
throw if the unary operator updates the reference.

The following become legal in JSC:

`
!new.target
~new.target
typeof new.target
delete new.target
void new.target
`

All of which are legal in v8 and SpiderMonkey in strict and sloppy mode

JSTests:

  • stress/new-target-syntax-errors.js:
  • stress/new-target.js:

Source/JavaScriptCore:

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseUnaryExpression):

12:23 AM Changeset in webkit [220649] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220479 - [Repaint from Layout Removal] Move layer repaint rects into a map
https://bugs.webkit.org/show_bug.cgi?id=175393

Reviewed by Zalan Bujtas.

Move the two repaint rects held by RenderLayer into a RenderLayerModelObject -> RepaintLayoutRects hash map.
RepaintLayoutRects is a new struct that holds both rects.

Eventually more objects than just self painting layers will be caching repaint rects, so this takes a first
step towards having a common cache for these repaint rects. In addition this change saves memory, since
layers that aren't self-painting no longer have empty repaint rects taking up space in RenderLayer.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::layoutRunsAndFloats):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::repaintRectIncludingNonCompositingDescendants):
(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::clearRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::scrollTo):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerModelObject.cpp:

(WebCore::RepaintLayoutRects::RepaintLayoutRects):
(WebCore::RenderLayerModelObject::willBeDestroyed):
(WebCore::RenderLayerModelObject::destroyLayer):
(WebCore::RenderLayerModelObject::styleDidChange):
(WebCore::RenderLayerModelObject::hasRepaintLayoutRects):
(WebCore::RenderLayerModelObject::setRepaintLayoutRects):
(WebCore::RenderLayerModelObject::clearRepaintLayoutRects):
(WebCore::RenderLayerModelObject::repaintLayoutRects):
(WebCore::RenderLayerModelObject::computeRepaintLayoutRects):

  • rendering/RenderLayerModelObject.h:

(WebCore::RepaintLayoutRects::RepaintLayoutRects):

12:15 AM Changeset in webkit [220648] by Carlos Garcia Campos
  • 6 edits
    2 adds in releases/WebKitGTK/webkit-2.18

Merge r220472 - Old subtitle track is not deleted on 'src' attribute change event
https://bugs.webkit.org/show_bug.cgi?id=175031

Patch by Kirill Ovchinnikov <kirill.ovchinnikov@lge.com> on 2017-08-09
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/text-track-src-change.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackReadyStateChanged):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::loadTimerFired):

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::clearTextDisplayContainer):

  • html/shadow/MediaControls.h:

LayoutTests:

  • media/track/text-track-src-change-expected.txt: Added.
  • media/track/text-track-src-change.html: Added.
12:13 AM Changeset in webkit [220647] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/Source/JavaScriptCore

Merge r220471 - Make JSC_validateExceptionChecks=1 succeed on JSTests/stress/v8-deltablue-strict.js.
https://bugs.webkit.org/show_bug.cgi?id=175358

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-09
Reviewed by Mark Lam.

  • jit/JITOperations.cpp:
  • runtime/JSObjectInlines.h:

(JSC::JSObject::putInlineForJSObject):

12:10 AM Changeset in webkit [220646] by Antti Koivisto
  • 15 edits
    1 add
    2 deletes in trunk

[Render Tree Mutation] First letter should not mutate the render tree while in layout.
https://bugs.webkit.org/show_bug.cgi?id=163848
Source/WebCore:

Reviewed by Zalan Bujtas.

RenderBlock::updateFirstLetter shouldn't be called during layout. Instead it should
be invoked by the RenderTreeUpdater.

With this future patches can move updateFirstLetter() and the related functions
completely out of the render tree.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layout):

No more updateFirstLetter calls during layout...

(WebCore::RenderBlock::computePreferredLogicalWidths):

...or preferred width computation.

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderBlock.h:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::updateFirstLetter):

  • rendering/RenderRubyRun.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::updateFirstLetter):

  • rendering/RenderTable.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::updateFirstLetter):

  • rendering/svg/RenderSVGText.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent):

Call updateFirstLetter when closing the element. All of of descedant renderers are known here
so this can be resolved correctly.

LayoutTests:

<rdar://problem/33402718>

Reviewed by Zalan Bujtas.

  • fast/text-autosizing/ios/first-letter-expected.html: Added.

Turn into reftest for easier debugging and robustness.

  • imported/blink/fast/css/first-letter-range-insert-expected.txt:

This is crash-or-assert test and the output change here doesn't matter.

  • platform/ios/fast/text-autosizing/ios/first-letter-expected.txt: Removed.
  • platform/mac/fast/text-autosizing/ios/first-letter-expected.txt: Removed.

Aug 13, 2017:

11:55 PM Changeset in webkit [220645] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220467 - ServiceWorker experimental feature should not be on by default (definitely not ready).
https://bugs.webkit.org/show_bug.cgi?id=175389

Rubberstamped by Andy Estes.

  • Shared/WebPreferencesDefinitions.h: false, not DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
11:53 PM Changeset in webkit [220644] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220464 - [WinCairo] Fix build after rev 220399
https://bugs.webkit.org/show_bug.cgi?id=175360

Reviewed by Žan Doberšek.

No new tests. No change in behavior.

  • platform/graphics/texmap/TextureMapperGLHeaders.h:
11:52 PM Changeset in webkit [220643] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220461 - [GStreamer][MSE] Add missing lock around getStreamByTrackId
https://bugs.webkit.org/show_bug.cgi?id=175323

Patch by Charlie Turner <cturner@igalia.com> on 2017-08-09
Reviewed by Xabier Rodriguez-Calvar.

Covered by existing tests.

  • platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::enqueueSample): Ensure the media source
lock is taken before modifiying the track queues indirectly via the
iterator use in getTrackId.

11:49 PM Changeset in webkit [220642] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/JSTests

Merge r220458 - Skip failing JSC tests stress/regress-169783.js and wasm.yaml/wasm/stress/oom.js.
https://bugs.webkit.org/show_bug.cgi?id=175255

Unreviewed test gardening.

  • stress/regress-169783.js:
  • wasm/stress/oom.js:
11:46 PM Changeset in webkit [220641] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220454 - Remove unnecessary copies of PlatformMediaSessionManager::m_sessions
https://bugs.webkit.org/show_bug.cgi?id=175375

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-09
Reviewed by Sam Weinig.

Remove unnecessary copies of PlatformMediaSessionManager::m_sessions.

These should have been removed in r207688.

No new tests: no behavior change.

  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive const):
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const):
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground const):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground const):

11:44 PM Changeset in webkit [220640] by Carlos Garcia Campos
  • 11 edits in releases/WebKitGTK/webkit-2.18

Merge r220453 - Reinstate active flag for iterators
https://bugs.webkit.org/show_bug.cgi?id=175312

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Resync WPT tests from upstream to gain test coverage.

  • web-platform-tests/dom/traversal/NodeIterator-expected.txt:
  • web-platform-tests/dom/traversal/NodeIterator.html:
  • web-platform-tests/dom/traversal/TreeWalker-expected.txt:
  • web-platform-tests/dom/traversal/TreeWalker.html:

Source/WebCore:

NodeIterator / TreeWalker should no longer allow recursive filters
after the following change to the DOM specification:

This patch aligns our behavior with the latest specification.

No new tests, updated existing tests.

  • dom/NodeIterator.cpp:

(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
Note that we now also call m_candidateNode.clear() before returning an
exception. This was a pre-existing bug that we failed to do so in the
exception case but it became more obvious after this change now that
we throw. This was causing traversal/moz-bug559526.html to fail
otherwise (the filter was called one too many times). The test case
is passing in Firefox (The filter is called 4 times and they throw
each time).

  • dom/Traversal.cpp:

(WebCore::NodeIteratorBase::NodeIteratorBase):
(WebCore::NodeIteratorBase::acceptNode):

  • dom/Traversal.h:
  • dom/TreeWalker.cpp:
11:31 PM Changeset in webkit [220639] by Manuel Rego Casasnovas
  • 12 edits
    2 adds in trunk

Composition underline color is always black
https://bugs.webkit.org/show_bug.cgi?id=174675

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.

Test: editing/composition-underline-color.html

  • editing/CompositionUnderline.h:

(WebCore::CompositionUnderline::CompositionUnderline):
Added new attribute compositionUnderlineColor.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionUnderline):
Use the text color if compositionUnderlineColor is TextColor.

Source/WebKit:

This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(WebKit::WebViewImpl::setMarkedText): Use text color
for composition underline in the plain text case.

  • UIProcess/gtk/InputMethodFilter.cpp:

(WebKit::InputMethodFilter::handleKeyboardEventWithCompositionResults):
Use text color for composition underline.
(WebKit::InputMethodFilter::updatePreedit): Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setCompositionForTesting): Ditto.

Source/WebKitLegacy/mac:

  • WebView/WebHTMLView.mm:

(extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(-[WebHTMLView setMarkedText:selectedRange:]): Use text color
for composition underline in the plain text case.

Source/WebKitLegacy/win:

  • WebView.cpp:

(WebView::setCompositionForTesting): Use text color for
composition underline.

LayoutTests:

Added new test to check that the composition underline
is using the text color.
The test hides the text and the caret, so it only shows
the composition underline and checks against an -expected-mismatch
that the color of the composition marker is different.

  • editing/composition-underline-color-expected-mismatch.html: Added.
  • editing/composition-underline-color.html: Added.
11:23 PM Changeset in webkit [220638] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] stop kinetic scrolling when a zero movement is reached
https://bugs.webkit.org/show_bug.cgi?id=175468

Reviewed by Michael Catanzaro.

This is GTK+ change by Christian Hergert.
https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=4f63d839550f7a9038b391e7d3e1e6fc8bdfafa6

When the kinetic scrolling reduces its speed, there can be multiple frames where the movement is zero pixels,
followed by a 1 pixel movement later on. This causes a "jitter" right at the end of the scroll which makes it
feel less quality than other platforms. Instead, we should just clamp it as soon as we get a zero movement.

  • platform/ScrollAnimationKinetic.cpp:

(WebCore::ScrollAnimationKinetic::PerAxisData::animateScroll):

11:06 PM Changeset in webkit [220637] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220450 - [GTK] [WPE] Update expectations for global-constructors-attributes.html.
https://bugs.webkit.org/show_bug.cgi?id=175373

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-09

  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/wpe/js/dom/global-constructors-attributes-expected.txt:
11:00 PM Changeset in webkit [220636] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.18

Merge r220449 - REGRESSION: 2 test262/test/language/statements/async-function failures
https://bugs.webkit.org/show_bug.cgi?id=175334

Reviewed by Yusuke Suzuki.

JSTests:

Add @skip parameters to tests, and remove test for async iterator from
async await syntax test because it is already covered by async-iterator-syntax.js

  • stress/async-await-syntax.js:
  • stress/async-iteration-syntax.js:

Source/JavaScriptCore:

Switch off useAsyncIterator by default

  • runtime/Options.h:
10:56 PM Changeset in webkit [220635] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r220571. rdar://problem/33829966

10:56 PM Changeset in webkit [220634] by jmarcell@apple.com
  • 6 edits
    3 adds in branches/safari-604-branch

Cherry-pick r220551. rdar://problem/33843388

10:55 PM Changeset in webkit [220633] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r220505. rdar://problem/33829966

2:07 PM Changeset in webkit [220632] by Chris Dumez
  • 10 edits in trunk/Source/WebCore

Drop non-const getter for CachedResource::resourceRequest()
https://bugs.webkit.org/show_bug.cgi?id=175524

Reviewed by Youenn Fablet.

Drop non-const getter for CachedResource::resourceRequest(). It would be unsafe to modify the request of a CachedResource
after it has been cached. Exposing such a getter is therefore a footgun.

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::resourceRequest const):
(WebCore::CachedResource::ignoreForRequestCount const):
(WebCore::CachedResource::setIgnoreForRequestCount):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

  • loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::ignoreForRequestCount const):
(WebCore::CachedResourceRequest::setIgnoreForRequestCount):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::addImageToCache):

  • platform/network/ResourceRequestBase.h:
5:13 AM Changeset in webkit [220631] by Adrian Perez de Castro
  • 9 edits
    1 move in trunk

[WPE] Implement WebCore::standardUserAgent()
https://bugs.webkit.org/show_bug.cgi?id=175507

Reviewed by Carlos Alberto Lopez Perez.

Implement missing User-Agent handling for the WPE port by sharing the code with the GTK+ port.

.:

  • Source/cmake/OptionsGTK.cmake: Rename "GTK" with "GLIB" in UA version macros.
  • Source/cmake/OptionsWPE.cmake: Add UA version macros.

Source/WebCore:

  • PlatformGTK.cmake: Handlde renaming of UserAgentGtk.cpp to UserAgentGLib.cpp.
  • PlatformWPE.cmake: Add UserAgentGLib.cpp and UserAgentQuirks.cpp to the list of built WebCore sources.
  • platform/glib/UserAgentGLib.cpp: Renamed from Source/WebCore/platform/gtk/UserAgentGtk.cpp.

(WebCore::versionForUAString): Change "GTK" in UA version macros to "GLIB".

Source/WebKit:

  • UIProcess/API/glib/WebKitSettings.cpp: Remove preprocessor conditionals for the WPE port.

(webkit_settings_set_user_agent):
(webkit_settings_set_user_agent_with_application_details):

  • UIProcess/wpe/WebPageProxyWPE.cpp:

(WebKit::WebPageProxy::standardUserAgent): Remove hardcoded value and make use of WebCore::standardUserAgent().

Aug 12, 2017:

11:47 PM Changeset in webkit [220630] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

[ARM64] Use x29 and x30 instead of fp and lr to make GCC happy
https://bugs.webkit.org/show_bug.cgi?id=175512
<rdar://problem/33863584>

Reviewed by Mark Lam.

  • CMakeLists.txt: Added MacroAssemblerARM64.cpp.
  • assembler/MacroAssemblerARM64.cpp: Use x29 and x30 instead of fp and lr to make GCC happy.
11:22 PM Changeset in webkit [220629] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

ARM_TRADITIONAL: static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline
https://bugs.webkit.org/show_bug.cgi?id=175513

Reviewed by Mark Lam.

  • assembler/MacroAssemblerARM.cpp: Added d16-d31 FP registers too.
6:59 PM Changeset in webkit [220628] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

FTL's compileGetTypedArrayByteOffset needs to do caging
https://bugs.webkit.org/show_bug.cgi?id=175366

Reviewed by Saam Barati.

While implementing boxing in the DFG, I noticed that there was some missing boxing in the FTL. This
fixes the case in GetTypedArrayByteOffset, and files FIXMEs for more such cases.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetTypedArrayByteOffset):
(JSC::FTL::DFG::LowerDFGToB3::cagedMayBeNull):

  • runtime/ArrayBuffer.h:
  • runtime/ArrayBufferView.h:
  • runtime/JSArrayBufferView.h:
3:14 PM Changeset in webkit [220627] by rniwa@webkit.org
  • 43 edits
    3 adds in trunk

Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
https://bugs.webkit.org/show_bug.cgi?id=175474
.:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

  • Configurations/FeatureDefines.xcconfig:
  • runtime/CommonIdentifiers.h:

Source/WebCore:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Replaced the build flag by a runtime flag and added a stub implementation for DataTransferItemList
and DataTransferItem to make it compile. DataTransferItemList is created lazily by DataTransfer.items,
and its lifetime is tied to DataTransfer by forwarding ref and deref.

See https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitemlist-interface

Tests: editing/pasteboard/datatransfer-idl.html

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::items): Added. Create DataTransferItemList lazily

  • dom/DataTransfer.h:
  • dom/DataTransfer.idl:
  • dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::DataTransferItem): Added a stub implementation.
(WebCore::DataTransferItem::~DataTransferItem): Ditto.
(WebCore::DataTransferItem::getAsString const): Ditto.
(WebCore::DataTransferItem::getAsFile const): Ditto.

  • dom/DataTransferItem.h:

(WebCore::DataTransferItemList): Devirtualized functions.
(WebCore::DataTransferItemList::kind const):
(WebCore::DataTransferItemList::type const):

  • dom/DataTransferItem.idl:
  • dom/DataTransferItemList.cpp: Added.

(WebCore::DataTransferItemList::length const): Added a stub implementation.
(WebCore::DataTransferItemList::item): Ditto.
(WebCore::DataTransferItemList::add): Ditto.
(WebCore::DataTransferItemList::remove): Ditto.
(WebCore::DataTransferItemList::clear): Ditto.

  • dom/DataTransferItemList.h:

(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::~DataTransferItemList): Deleted.
(WebCore::DataTransferItemList::ref): Forwards to DataTransfer's ref.
(WebCore::DataTransferItemList::deref): Ditto.

  • dom/DataTransferItemList.idl: Updated to match the latest specification.
  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled): Added.
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled const): Added.

Source/WebCore/PAL:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Replaced the build flag by a runtime flag and disabled the feature by default.

  • Configurations/FeatureDefines.xcconfig:
  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDataTransferItemsEnabled): Added to be used by WebKitTestRunner.
(WKPreferencesGetDataTransferItemsEnabled): Ditto.

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Replaced the build flag by a runtime flag and disabled the feature by default.

  • Configurations/FeatureDefines.xcconfig:
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Disables dataTransfer.items by default.
(-[WebPreferences dataTransferItemsEnabled]): Added.
(-[WebPreferences setDataTransferItemsEnabled:]): Added.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WTF:

Reviewed by Wenson Hsieh.

  • wtf/FeatureDefines.h:

Tools:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Added a W3C-style IDL test.

  • editing/pasteboard/datatransfer-idl.html: Added.
2:58 PM Changeset in webkit [220626] by Chris Dumez
  • 34 edits in trunk

Address flakiness related to download tests
https://bugs.webkit.org/show_bug.cgi?id=175338

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several WPT tests now that download callbacks are no longer logged.

  • web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click-expected.txt:
  • web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-expected.txt:

Tools:

  • Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished() is actually queried when a download completes. Previously, this would be identical to a call to testRunner.waitUntilDone() because any download completion would call testRunner.notifyDone().
  • Disable logging of download callbacks by default and add a testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to enable such logging.
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setShouldLogDownloadCallbacks):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::downloadDidStart):
(WTR::TestController::decideDestinationWithSuggestedFilename):
(WTR::TestController::downloadDidFinish):
(WTR::TestController::downloadDidFail):
(WTR::TestController::downloadDidCancel):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::setShouldLogDownloadCallbacks):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Unmark several download tests as flaky.

  • fast/dom/HTMLAnchorElement/anchor-download-synthetic-click.html:
  • fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html:
  • fast/dom/HTMLAnchorElement/anchor-download.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download.html:
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set.html:
  • http/tests/download/anchor-download-attribute-content-disposition.html:
  • http/tests/download/anchor-download-no-extension.html:
  • http/tests/download/anchor-download-no-value.html:
  • http/tests/download/area-download-expected.txt:
  • http/tests/download/area-download.html:
  • http/tests/security/anchor-download-allow-blob-expected.txt:
  • http/tests/security/anchor-download-allow-blob.html:
  • http/tests/security/anchor-download-allow-data-expected.txt:
  • http/tests/security/anchor-download-allow-data.html:
  • http/tests/security/anchor-download-allow-sameorigin.html:

Update download tests to explicitly enable download callbacks logging.

11:44 AM Changeset in webkit [220625] by fpizlo@apple.com
  • 14 edits in trunk

Caging shouldn't have to use a patchpoint for adding
https://bugs.webkit.org/show_bug.cgi?id=175483

Reviewed by Mark Lam.
Source/JavaScriptCore:

Caging involves doing a Add(ptr, largeConstant). All of B3's heuristics for how to deal with
constants and associative operations dictate that you always want to sink constants. For example,
Add(Add(a, constant), b) always becomes Add(Add(a, b), constant). This is profitable because in
typical code, it reveals downstream optimizations. But it's terrible in the case of caging, because
we want the large constant (which is shared by all caging operations) to be hoisted. Reassociating to
sink constants obscures the constant in this case. Currently, moveConstants is not smart enough to
reassociate, so instead of sinking largeConstant, it tries (and often fails) to sink some other
constants instead. Without some hacks, this is a 5% Kraken regression and a 1.6% Octane regression.
It's not clear that moveConstants could ever be smart enough to rematerialize that constant and then
hoist it - that would require quite a bit of algebraic reasoning. But the only case we know of where
our current constant reassociation heuristics are wrong is caging. So, we can get away with some
hacks for just stopping B3's reassociation only in this specific case.

Previously, we achieved this by concealing the Add(ptr, largeConstant) inside a patchpoint. That's
OK, but patchpoints are expensive. They require a SharedTask instance. They require callbacks from
the backend, including during register allocation. And they cannot be CSE'd. We do want B3 to know
that if we cage the same pointer in two places, both places will compute the same value.

This patch improves the situation by introducing the Opaque opcode. This is handled by LowerToAir as
if it was Identity, but all prior phases treat it as an unknown pure unary idempotent operation. I.e.
they know that Opaque(x) == Opaque(x) and that Opaque(Opaque(x)) == Opaque(x). But they don't know
that Opaque(x) == x until LowerToAir. So, you can use Opaque exactly when you know that B3 will mess
up your code but Air won't. (Currently we know of no cases where Air messes things up on a large
enough scale to warrant new opcodes.)

This change is perf-neutral, but may start to help as I add more uses of caged() in the FTL. It also
makes the code a bit less ugly.

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::shouldCopyPropagate):
(JSC::B3::Air::LowerToAir::lower):

  • b3/B3Opcode.cpp:

(WTF::printInternal):

  • b3/B3Opcode.h:
  • b3/B3ReduceStrength.cpp:
  • b3/B3Validate.cpp:
  • b3/B3Value.cpp:

(JSC::B3::Value::effects const):
(JSC::B3::Value::key const):
(JSC::B3::Value::isFree const):
(JSC::B3::Value::typeFor):

  • b3/B3Value.h:
  • b3/B3ValueKey.cpp:

(JSC::B3::ValueKey::materialize const):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

  • ftl/FTLOutput.cpp:

(JSC::FTL::Output::opaque):

  • ftl/FTLOutput.h:

Websites/webkit.org:


Write documentation for the new Opaque opcode.

  • docs/b3/intermediate-representation.html:
11:40 AM Changeset in webkit [220624] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

ScopedArguments overflow storage needs to be in the JSValue gigacage
https://bugs.webkit.org/show_bug.cgi?id=174923

Reviewed by Saam Barati.

ScopedArguments overflow storage sits at the end of the ScopedArguments object, so we put that
object into the JSValue gigacage.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitScopedArgumentsGetByVal):

  • runtime/ScopedArguments.h:

(JSC::ScopedArguments::subspaceFor):
(JSC::ScopedArguments::overflowStorage const):

Aug 11, 2017:

10:18 PM Changeset in webkit [220623] by beidson@apple.com
  • 4 edits
    22 moves
    1 add in trunk/Source/WebCore

Move files inside WebCore/workers to WebCore/workers/service.
https://bugs.webkit.org/show_bug.cgi?id=175495

Rubberstamped by Tim Horton.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • workers/service/ServiceWorker.cpp: Renamed from Source/WebCore/workers/ServiceWorker.cpp.
  • workers/service/ServiceWorker.h: Renamed from Source/WebCore/workers/ServiceWorker.h.
  • workers/service/ServiceWorker.idl: Renamed from Source/WebCore/workers/ServiceWorker.idl.
  • workers/service/ServiceWorkerContainer.cpp: Renamed from Source/WebCore/workers/ServiceWorkerContainer.cpp.
  • workers/service/ServiceWorkerContainer.h: Renamed from Source/WebCore/workers/ServiceWorkerContainer.h.
  • workers/service/ServiceWorkerContainer.idl: Renamed from Source/WebCore/workers/ServiceWorkerContainer.idl.
  • workers/service/ServiceWorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/ServiceWorkerGlobalScope.cpp.
  • workers/service/ServiceWorkerGlobalScope.h: Renamed from Source/WebCore/workers/ServiceWorkerGlobalScope.h.
  • workers/service/ServiceWorkerGlobalScope.idl: Renamed from Source/WebCore/workers/ServiceWorkerGlobalScope.idl.
  • workers/service/ServiceWorkerJob.cpp: Renamed from Source/WebCore/workers/ServiceWorkerJob.cpp.
  • workers/service/ServiceWorkerJob.h: Renamed from Source/WebCore/workers/ServiceWorkerJob.h.
  • workers/service/ServiceWorkerJobClient.h: Renamed from Source/WebCore/workers/ServiceWorkerJobClient.h.
  • workers/service/ServiceWorkerProvider.cpp: Renamed from Source/WebCore/workers/ServiceWorkerProvider.cpp.
  • workers/service/ServiceWorkerProvider.h: Renamed from Source/WebCore/workers/ServiceWorkerProvider.h.
  • workers/service/ServiceWorkerRegistration.cpp: Renamed from Source/WebCore/workers/ServiceWorkerRegistration.cpp.
  • workers/service/ServiceWorkerRegistration.h: Renamed from Source/WebCore/workers/ServiceWorkerRegistration.h.
  • workers/service/ServiceWorkerRegistration.idl: Renamed from Source/WebCore/workers/ServiceWorkerRegistration.idl.
  • workers/service/ServiceWorkerRegistrationOptions.h: Renamed from Source/WebCore/workers/ServiceWorkerRegistrationOptions.h.
  • workers/service/ServiceWorkerRegistrationParameters.cpp: Renamed from Source/WebCore/workers/ServiceWorkerRegistrationParameters.cpp.
  • workers/service/ServiceWorkerRegistrationParameters.h: Renamed from Source/WebCore/workers/ServiceWorkerRegistrationParameters.h.
  • workers/service/ServiceWorkerUpdateViaCache.h: Renamed from Source/WebCore/workers/ServiceWorkerUpdateViaCache.h.
  • workers/service/ServiceWorkerUpdateViaCache.idl: Renamed from Source/WebCore/workers/ServiceWorkerUpdateViaCache.idl.
7:51 PM Changeset in webkit [220622] by Chris Dumez
  • 37 edits
    4 adds in trunk

Implement quota limitation for keepalive Fetch requests
https://bugs.webkit.org/show_bug.cgi?id=175482

Reviewed by Sam Weinig and Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt:
  • web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-star.any-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker-expected.txt:
  • web-platform-tests/fetch/http-cache/cc-request-expected.txt:

Rebaseline tests now that we provide a more helpful error message when rejecting
the fetch() promise.

  • web-platform-tests/fetch/api/request/request-keepalive-quota-expected.txt:

Rebaseline test for keepalive Fetch requests quota which is now passing.

Source/WebCore:

Implement quota limitation for keepalive Fetch requests as per:

This partly works for Beacon as well, meaning that no Beacon with a body
over 64Kb can be sent. However, we don't keep track about wether or not
beacon loads are inflight or not.

Also update CachedResourceLoader::requestResource() so that the caller
can get a ResourceError when it returns null. This is useful for both
Fetch and Beacon to return better error messages.

Test: http/wpt/beacon/beacon-quota.html

  • CMakeLists.txt:
  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::BlobLoader::didReceiveResponse):
(WebCore::FetchBodyOwner::BlobLoader::didFail):

  • Modules/fetch/FetchBodyOwner.h:
  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):
(WebCore::FetchLoader::didFail):

  • Modules/fetch/FetchLoaderClient.h:
  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didFail):

  • Modules/fetch/FetchResponse.h:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::isMainOrMediaOrIconOrRawResource const):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestMedia):
(WebCore::CachedResourceLoader::requestIcon):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::CachedResourceLoader::requestMainResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/KeepaliveRequestTracker.cpp: Added.

(WebCore::KeepaliveRequestTracker::~KeepaliveRequestTracker):
(WebCore::KeepaliveRequestTracker::canLoadRequest):
(WebCore::KeepaliveRequestTracker::registerRequest):
(WebCore::KeepaliveRequestTracker::responseReceived):
(WebCore::KeepaliveRequestTracker::notifyFinished):
(WebCore::KeepaliveRequestTracker::unregisterRequest):

  • loader/cache/KeepaliveRequestTracker.h: Added.
  • platform/network/FormData.cpp:

(WebCore::FormDataElement::lengthInBytes const):
(WebCore::FormData::lengthInBytes const):

  • platform/network/FormData.h:

LayoutTests:

  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
  • http/tests/contentextensions/async-xhr-onerror-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-iframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt:

Rebaseline a few tests now that we provide a more helpful error message when an XHR is failing synchronously.

  • http/wpt/beacon/beacon-quota-expected.txt: Added.
  • http/wpt/beacon/beacon-quota.html: Added.

Add layout test coverage for keepalive Fetch requests quota in the context of sendBeacon().
The second part of the test is still failing because WebCore does not currently know when
ping loads (e.g. beacon loads) complete. This will be addressed via Bug 175443.

6:13 PM Changeset in webkit [220621] by don.olmstead@sony.com
  • 13 edits
    1 move in trunk/Source

[WTF] Move ValueToString into WTF
https://bugs.webkit.org/show_bug.cgi?id=175469

Reviewed by Sam Weinig.

Source/WebCore:

No new tests. No change in behavior.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.h:

(WTF::ValueToString<WebCore::TextTrackCue::string):
(WebCore::ValueToString<TextTrackCue::string): Deleted.
(WebCore::ValueToString<MediaTime>::string): Deleted.

  • platform/LayoutUnit.h:

(WTF::ValueToString<WebCore::LayoutUnit>::string):
(WebCore::ValueToString<LayoutUnit>::string): Deleted.

  • platform/PODInterval.h:
  • platform/PODIntervalTree.h:
  • platform/PODRedBlackTree.h:
  • platform/graphics/FloatPolygon.h:

(WTF::ValueToString<WebCore::FloatPolygonEdge::string):
(WebCore::ValueToString<FloatPolygonEdge::string): Deleted.

  • rendering/FloatingObjects.h:

(WTF::ValueToString<WebCore::FloatingObject::string):
(WebCore::ValueToString<FloatingObject::string): Deleted.

  • rendering/RenderFlowThread.h:

(WTF::ValueToString<WebCore::RenderRegion::string):
(WebCore::ValueToString<RenderRegion::string): Deleted.

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/text/ValueToString.h: Renamed from Source/WebCore/platform/ValueToString.h.
5:32 PM Changeset in webkit [220620] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[Bindings] Simplify DOMPromiseProxy now that WTF::Function can return references
https://bugs.webkit.org/show_bug.cgi?id=175394

Patch by Sam Weinig <sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

  • bindings/IDLTypes.h:

(WebCore::IDLWrapper::convertToParameterType): Deleted.

Remove no longer used convertToParameterType.

  • bindings/js/DOMPromiseProxy.h:
  • Replace Variant<Value, Exception> with ExceptionOr<Value> / ExceptionOr<void>.
  • Update ResolveCallback to have a return type of IDLType::ParameterType, rather than IDLType::ImplementationType, now that WTF::Function supports references as the return type. This is needed, since the IDLType::ParameterType for an interface T is T&.
  • css/FontFace.cpp:
  • css/FontFace.h:
  • css/FontFaceSet.cpp:
  • css/FontFaceSet.h:

Update resolve callbacks to return a reference rather than a RefPtr, matching
the new signature requirement.

5:07 PM Changeset in webkit [220619] by commit-queue@webkit.org
  • 17 edits
    11 copies
    1 move
    2 deletes in trunk/Source/WebCore

[WebIDL] Replace JSCryptoKeyCustom and JSCryptoAlgorithmBuilder with generated code
https://bugs.webkit.org/show_bug.cgi?id=175457

Patch by Sam Weinig <sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCryptoAlgorithmBuilder.cpp: Removed.
  • bindings/js/JSCryptoAlgorithmBuilder.h: Removed.
  • bindings/js/JSCryptoKeyCustom.cpp: Removed.

Remove JSCryptoAlgorithmBuilder and JSCryptoKeyCustom, add KeyAlgorithm
IDLs and headers.

  • crypto/CryptoKey.cpp:
  • crypto/CryptoKey.h:
  • crypto/CryptoKey.idl:

Replace custom algorithm attribute with a union of the supported key algorithms.

  • crypto/keys/CryptoAesKeyAlgorithm.h: Added.
  • crypto/keys/CryptoAesKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoEcKeyAlgorithm.h: Added.
  • crypto/keys/CryptoEcKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoHmacKeyAlgorithm.h: Added.
  • crypto/keys/CryptoHmacKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoKeyAlgorithm.h: Added.
  • crypto/keys/CryptoKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoRsaHashedKeyAlgorithm.h: Added.
  • crypto/keys/CryptoRsaHashedKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoRsaKeyAlgorithm.h: Added.
  • crypto/keys/CryptoRsaKeyAlgorithm.idl: Added.

Add IDLs and headers fo the supported key algorithms.

  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyEC.h:
  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.h:
  • crypto/keys/CryptoKeyRaw.h:

Give each of the existing KeyAlgorithm subclasses a dictionary() function
that returns the populated corresponding spec'd dictionary.

4:18 PM Changeset in webkit [220618] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

JSLexicalEnvironment needs to be in the JSValue gigacage
https://bugs.webkit.org/show_bug.cgi?id=174922

Reviewed by Michael Saboff.

We can sorta random access the JSLexicalEnvironment. So, we put it in the JSValue gigacage and make
the only random accesses use pointer caging.

We don't need to do anything to normal lexical environment accesses.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

  • runtime/JSEnvironmentRecord.h:

(JSC::JSEnvironmentRecord::subspaceFor):
(JSC::JSEnvironmentRecord::variables):

4:12 PM Changeset in webkit [220617] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Update TestExpectations for failing media/video-controls tests.
https://bugs.webkit.org/show_bug.cgi?id=173978

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:43 PM Changeset in webkit [220616] by Simon Fraser
  • 10 edits in trunk/Source/WebCore

Some RenderSVGResource cleanup
https://bugs.webkit.org/show_bug.cgi?id=175494

Reviewed by Zalan Bujtas.

Use more initializers. Remove spurious use of bitfields that didn't save any space at all.
0 -> nullptr.

No behavior change.

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):

  • rendering/svg/RenderSVGResourceContainer.h:
  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):

  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::strokeShape):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGRenderingContext.h:

(WebCore::SVGRenderingContext::SVGRenderingContext):

3:35 PM Changeset in webkit [220615] by timothy_horton@apple.com
  • 5 edits in trunk/Source

Fix the build with modern Clang's -Wexpansion-to-defined
https://bugs.webkit.org/show_bug.cgi?id=175467
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/WebCore:

  • crypto/mac/SerializedCryptoKeyWrapMac.mm:

Source/WTF:

  • wtf/FeatureDefines.h:
  • wtf/Platform.h:

Avoid object-like macros that expand to include defined(), because this
behaves inconsistently between different compilers (though in ways
that don't matter for these particular defines, which aren't used on MSVC),
and Clang has added a warning for it.

Move ENABLE_WEBASSEMBLY to Platform.h since it depends on things that
are defined there and can't be evaluated at time-of-use because of the
aforementioned new rules. Previously, there was a cycle between
ENABLE_WEBASSEMBLY and ENABLE_B3_JIT -- break that so that it just
goes FTL_JIT->B3_JIT->WASM instead.

3:33 PM Changeset in webkit [220614] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Clicking on suggestion hint should apply it, not dismiss
https://bugs.webkit.org/show_bug.cgi?id=175409

Reviewed by Matt Baker.

Make clicking on the suggestion hint apply the completion, and place the text caret after it.

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WI.CodeMirrorCompletionController.prototype._createCompletionHintMarker):

3:21 PM Changeset in webkit [220613] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:20 PM Changeset in webkit [220612] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

2:27 PM Changeset in webkit [220611] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.1.5

Tag Safari-604.1.38.1.5.

2:25 PM Changeset in webkit [220610] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.5

Tag Safari-604.1.38.0.5.

2:08 PM Changeset in webkit [220609] by Nikita Vasilyev
  • 15 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Update the filter icon to match Xcode
https://bugs.webkit.org/show_bug.cgi?id=175458
<rdar://problem/33838660>

Reviewed by Matt Baker.

  • UserInterface/Images/FilterFieldGlyph.svg:

Half-pixel transform is necessary for a cleaner rasterisation.

  • UserInterface/Views/FilterBar.css:

(.filter-bar > input[type="search"]::-webkit-search-decoration):
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter):
::-webkit-search-decoration is a flexbox item. Remove vertical-align: bottom,
since it didn't do anything for it.

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.css:
  • UserInterface/Views/FilterBar.js:

(WI.FilterBar):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WI.CSSStyleDetailsSidebarPanel.prototype.initialLayout):

  • UserInterface/Views/DebuggerSidebarPanel.js:
  • UserInterface/Views/LogContentView.js:

(WI.LogContentView):

  • UserInterface/Views/NetworkSidebarPanel.js:

(WI.NetworkSidebarPanel):

  • UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel):

  • UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel):

  • UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel):

  • UserInterface/Views/StorageSidebarPanel.js:

(WI.StorageSidebarPanel):

  • UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):

  • Localizations/en.lproj/localizedStrings.js:

Replace placeholder text for all filter fields with "Filter".

1:37 PM Changeset in webkit [220608] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Crash under ServiceWorkerJob::failedWithException.
https://bugs.webkit.org/show_bug.cgi?id=175488

Reviewed by Tim Horton.

Covered by existing tests.

  • workers/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::failedWithException): jobDidFinish might cause the Job to be deleted, so make it last.

1:36 PM Changeset in webkit [220607] by Ryan Haddad
  • 5 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviewed test gardening. rdar://problem/33831603

  • fast/events/ios/no-touch-events-when-stopping-momentum-scroll-in-mainframe-expected.txt:
  • platform/ios-11/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-wk2/fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
1:08 PM Changeset in webkit [220606] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

DirectArguments should be in the JSValue gigacage
https://bugs.webkit.org/show_bug.cgi?id=174920

Reviewed by Michael Saboff.

This puts DirectArguments in a new subspace for cells that want to be in the JSValue gigacage. All
indexed accesses to DirectArguments now do caging. get_from_arguments/put_to_arguments are exempted
because they always operate on a DirectArguments that is pointed to directly from the stack, they are
required to use fixed offsets, and you can only store JSValues.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnDirectArguments):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDirectArgumentsGetByVal):

  • runtime/DirectArguments.h:

(JSC::DirectArguments::subspaceFor):
(JSC::DirectArguments::storage):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
1:04 PM Changeset in webkit [220605] by Jonathan Bedard
  • 2 edits in trunk/Tools

Create mock ITP data in testing to prevent grandfathering
https://bugs.webkit.org/show_bug.cgi?id=174720

Unreviewed follow-up fix for r220604.

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.

10:30 AM Changeset in webkit [220604] by Jonathan Bedard
  • 5 edits in trunk/Tools

Create mock ITP data in testing to prevent grandfathering
https://bugs.webkit.org/show_bug.cgi?id=174720
<rdar://problem/33457779>

Reviewed by Brent Fulgham.

We don't need to be triggering grandfathering when each test runner starts. On Mac,
this may launch plugins which can cause layout tests to fail later if the test
runner does not shut-down before the plugins unload.

  • WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
prevent grandfathering from being triggered.

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformInitialize): Ditto.

10:26 AM Changeset in webkit [220603] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, add a FIXME.

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

10:26 AM Changeset in webkit [220602] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

  • platform/ios-11/TestExpectations:
9:56 AM Changeset in webkit [220601] by weinig@apple.com
  • 10 edits in trunk

WTF::Function does not allow for reference / non-default constructible return types
https://bugs.webkit.org/show_bug.cgi?id=175244
Source/JavaScriptCore:

Reviewed by Chris Dumez.

  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

Reviewed by Chris Dumez.

  • bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

Reviewed by Chris Dumez.

  • UIProcess/WebResourceLoadStatisticsStore.h:

Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

Reviewed by Chris Dumez.

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

  • wtf/Function.h:

(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

Tools:

<rdar://problem/33801582>

Reviewed by Chris Dumez.

  • TestWebKitAPI/Tests/WTF/Function.cpp:

(TestWebKitAPI::TEST):

9:54 AM Changeset in webkit [220600] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: fix CLoop build.
https://bugs.webkit.org/show_bug.cgi?id=175446
<rdar://problem/33836545>

Not reviewed.

  • assembler/MacroAssemblerPrinter.cpp:
9:53 AM Changeset in webkit [220599] by jmarcell@apple.com
  • 6 edits
    3 adds in branches/safari-604.1.38.1-branch

Cherry-pick r220551. rdar://problem/33843387

9:53 AM Changeset in webkit [220598] by jmarcell@apple.com
  • 3 edits
    3 deletes in branches/safari-604.1.38.1-branch

Revert r220587. rdar://problem/33843387

9:53 AM Changeset in webkit [220597] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch

Revert r220588. rdar://problem/33843387

9:47 AM Changeset in webkit [220596] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG should do caging
https://bugs.webkit.org/show_bug.cgi?id=174918

Reviewed by Saam Barati.

Adds the appropriate cage() calls to the DFG, including a cageTypedArrayStorage() helper that does
the conditional caging with a watchpoint.

This might be a 1% SunSpider slow-down, but it's not clear.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::cageTypedArrayStorage):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
(JSC::DFG::SpeculativeJIT::compileCreateRest):
(JSC::DFG::SpeculativeJIT::compileSpread):
(JSC::DFG::SpeculativeJIT::compileNewArrayWithSpread):
(JSC::DFG::SpeculativeJIT::compileArraySlice):
(JSC::DFG::SpeculativeJIT::compileGetButterfly):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

9:39 AM Changeset in webkit [220595] by Konstantin Tokarev
  • 17 edits in trunk

[CMake] Fix broken use of REQUIRED with find modules
https://bugs.webkit.org/show_bug.cgi?id=175427

Reviewed by Michael Catanzaro.

Module name passed to find_package_handle_standard_args() must exactly
match file name of CMake find module including letter case, e.g. "WebP"
must be used in FindWebP.cmake file. Otherwise find_package() arguments
(REQUIRED, QUIET, version) are not processed correctly.

To continue using old XXX_FOUND variables without case changes porting
to new find_package_handle_standard_args syntax which has FOUND_VAR
parameter. Unfortunately, variable name GTK_UNIX_PRINT_FOUND is not
allowed by find_package_handle_standard_args when package name is
GTKUnixPrint, so it's replaced to GTKUnixPrint_FOUND (default).

  • Source/cmake/FindGTKUnixPrint.cmake:
  • Source/cmake/FindGeoClue2.cmake:
  • Source/cmake/FindHyphen.cmake:
  • Source/cmake/FindLibEpoxy.cmake:
  • Source/cmake/FindLibGBM.cmake:
  • Source/cmake/FindLibsecret.cmake:
  • Source/cmake/FindLibtasn1.cmake:
  • Source/cmake/FindLibxkbcommon.cmake:
  • Source/cmake/FindOpenGL.cmake:
  • Source/cmake/FindOpenGLES2.cmake:
  • Source/cmake/FindOpenWebRTC.cmake:
  • Source/cmake/FindWPEBackend-mesa.cmake:
  • Source/cmake/FindWPEBackend.cmake:
  • Source/cmake/FindWayland.cmake:
  • Source/cmake/FindWebP.cmake:
  • Source/cmake/OptionsGTK.cmake:
9:22 AM Changeset in webkit [220594] by Antti Koivisto
  • 7 edits in trunk/Source/WebCore

Remove RenderQuote collection from RenderView
https://bugs.webkit.org/show_bug.cgi?id=175479

Reviewed by Andreas Kling.

We can do it well enough without maintaining this pointer structure.

Global updating doesn't work well with future direction for first-letter and similar anyway.
We need to update quote immediately when updating its style.

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::insertedIntoTree):
(WebCore::RenderQuote::willBeRemovedFromTree):

Just tell the view that there are renderers to update.

(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::isOpen const):
(WebCore::RenderQuote::updateRenderer):
(WebCore::RenderQuote::updateRenderers): Deleted.

Update single renderer only. RenderTreeUpdater provides the previous renderer to compute the depth.

  • rendering/RenderQuote.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::registerQuote): Deleted.
(WebCore::RenderView::unregisterQuote): Deleted.
(WebCore::RenderView::updateSpecialRenderers): Deleted.

Remove the quote list.

  • rendering/RenderView.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::commit):

Ensure that all quotes are updated.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):
(WebCore::RenderTreeUpdater::updateQuotesUpTo):

Traverse render tree to find quotes to update starting from the previous updated quote.

  • style/RenderTreeUpdater.h:
8:48 AM Changeset in webkit [220593] by Ryan Haddad
  • 2 edits
    46 adds in branches/safari-604.1.38.1-branch/LayoutTests

Cherry-pick r220555.

8:44 AM Changeset in webkit [220592] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for x86 GTK port
https://bugs.webkit.org/show_bug.cgi?id=175446

Use pushfl/popfl instead of pushfd/popfd.

  • assembler/MacroAssemblerX86Common.cpp:
8:44 AM Changeset in webkit [220591] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

[CMake] Many warning about missing “override” keywords in ANGLE with Clang
https://bugs.webkit.org/show_bug.cgi?id=175475

Reviewed by Michael Catanzaro.

  • CMakeLists.txt: Add "-Wno-inconsistent-missing-override" to the

compiler flags using for building the ANGLE sources.

8:43 AM Changeset in webkit [220590] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.0-branch/Source/WebKit

Cherry-pick r220571. rdar://problem/33829964

8:41 AM Changeset in webkit [220589] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.1-branch/Source/WebKit

Cherry-pick r220571. rdar://problem/33829962

8:17 AM Changeset in webkit [220588] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch

Cherry-pick r220551. rdar://problem/33594320

8:16 AM Changeset in webkit [220587] by jmarcell@apple.com
  • 3 edits
    3 adds in branches/safari-604.1.38.1-branch

Cherry-pick r220463. rdar://problem/33594320

6:46 AM Changeset in webkit [220586] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

[GTK][WPE] Overriden virtual function not marked “override” in ImageBufferDataCairo.h
https://bugs.webkit.org/show_bug.cgi?id=175476

Reviewed by Carlos Garcia Campos.

  • platform/graphics/cairo/ImageBufferDataCairo.h: Add missing "override" qualifier.
6:25 AM Changeset in webkit [220585] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebKit

[WPE] Build failure with Clang 4.0.1: no matching conversion for functional-style cast from 'pointer' (aka 'unsigned short *') to 'WTF::String'
https://bugs.webkit.org/show_bug.cgi?id=175477

Reviewed by Žan Doberšek.

  • Shared/wpe/WebEventFactory.cpp:

(WebKit::singleCharacterStringForKeyEvent): Cast to UChar* to make
compiler choose the correct WTF::String constructor.

5:28 AM Changeset in webkit [220584] by clopez@igalia.com
  • 2 edits in trunk/Source/WebDriver

Fix build warning in WebDriverService.h
https://bugs.webkit.org/show_bug.cgi?id=166682

Unreviewed build fix.

  • WebDriverService.h: Fixes the warning: class 'Capabilities' was previously declared as a struct [-Wmismatched-tags]
3:06 AM Changeset in webkit [220583] by Carlos Garcia Campos
  • 7 edits in trunk

[Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
https://bugs.webkit.org/show_bug.cgi?id=175378

Reviewed by Sergio Villar Senin.

Source/WebCore:

Bring back part of the code removed in r206732, to keep a reference to the SoupMessage in the
AuthenticationChallenge since it can be different to the resource message.

  • platform/network/soup/AuthenticationChallenge.h:

(WebCore::AuthenticationChallenge::AuthenticationChallenge): Deleted.
(WebCore::AuthenticationChallenge::authenticationClient const): Deleted.
(WebCore::AuthenticationChallenge::soupAuth const): Deleted.
(WebCore::AuthenticationChallenge::setProposedCredential): Deleted.

  • platform/network/soup/AuthenticationChallengeSoup.cpp:

(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::AuthenticationChallenge::platformCompare):

Source/WebKit:

In case of HTTPS resource with a proxy, libsoup uses a tunnel internally, that uses its own SoupMessage during
the proxy authentication. We were ignoring authentication requests for other messages.

  • NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::authenticateCallback): Only return early if the message does't match and it's not
HTTPS resource over a proxy.
(WebKit::NetworkDataTaskSoup::authenticate): Use the soup message from the authentication challenge.
(WebKit::NetworkDataTaskSoup::continueAuthenticate): Ditto.

Tools:

Add two test cases to check proxy authentication.

  • TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:

(Tunnel::Tunnel):
(Tunnel::~Tunnel):
(Tunnel::connect):
(Tunnel::connected):
(serverCallback):
(ProxyAuthenticationTest::ProxyAuthenticationTest):
(ProxyAuthenticationTest::~ProxyAuthenticationTest):
(ProxyAuthenticationTest::proxyServerPortAsString):
(testWebViewAuthenticationProxy):
(testWebViewAuthenticationProxyHTTPS):
(beforeAll):

1:15 AM Changeset in webkit [220582] by calvaris@igalia.com
  • 3 edits
    6 moves
    3 adds
    5 deletes in trunk/Tools

[GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
https://bugs.webkit.org/show_bug.cgi?id=175428

Both ports share the GStreamer code as multimedia backend and till
not so long they were using different versions. Now they do use
the same versions and it does not make any sense anymore (and
neither had sense before) to have differences in the modulesets.

In this patch I created a GStreamer moduleset and referenced it
from both GTK+'s and WPE's. GStreamer patches were also moved there.

Reviewed by Žan Doberšek.

  • gstreamer/jhbuild.modules: Added.
  • gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
  • gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
  • gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
  • gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
  • gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
  • gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
  • gtk/jhbuild.modules:
  • wpe/jhbuild.modules:
  • wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
  • wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
  • wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
  • wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
  • wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.

Aug 10, 2017:

11:02 PM Changeset in webkit [220581] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[Soup] Do not spawn the network process to setup cookie persistent storage
https://bugs.webkit.org/show_bug.cgi?id=175424

Reviewed by Sergio Villar Senin.

The persistent storage configuration is saved and passed to network process as creation parameters, so we don't
need to spawn the network process to configure it, when it's created eventually it will use the configuration.

  • UIProcess/soup/WebCookieManagerProxySoup.cpp:

(WebKit::WebCookieManagerProxy::setCookiePersistentStorage): Use sendToNetworkingProcess() instead of
endToNetworkingProcessRelaunchingIfNecessary().

11:01 PM Changeset in webkit [220580] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit

[GTK][WPE] Assertion failure in TimerBase inside WebCore::IconRecord::setImageData
https://bugs.webkit.org/show_bug.cgi?id=173866
<rdar://problem/33122050>

Reviewed by Michael Catanzaro.

IconDatabase creates and destroys IconRecord objects in both database and main thread. If the IconRecord has a
valid icon, its Image could be created in one thread and destroyed in another, something that is not expected to
happen, because Image has a Timer member. Since we have all the data and we are decoding it right after creating
the Image, we don't really need to keep the Image object around, we could simply take a reference of the encoded
data and the decoded native image to be returned by synchronousIconForPageURL().

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::IconRecord::image): Return NativeImagePtr now.
(WebKit::IconDatabase::IconRecord::setImageData): Create a BitmapImage to decode it and keep a reference to the
encoded data and decoded native image.
(WebKit::IconDatabase::IconRecord::snapshot const): Use m_imageData to get the encoded data.
(WebKit::IconDatabase::synchronousIconForPageURL): Return the native image and whether the icon is known or not.
(WebKit::IconDatabase::IconRecord::loadImageFromResource): Deleted.

  • UIProcess/API/glib/IconDatabase.h:
  • UIProcess/API/glib/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously): Use new API.

10:31 PM Changeset in webkit [220579] by mark.lam@apple.com
  • 18 edits in trunk/Source

Make the MASM_PROBE mechanism mandatory for DFG and FTL builds.
https://bugs.webkit.org/show_bug.cgi?id=175446
<rdar://problem/33836545>

Reviewed by Saam Barati.

Source/JavaScriptCore:

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssembler.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::trustedImm32FromPtr):

  • assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::trustedImm32FromPtr):

  • assembler/MacroAssemblerPrinter.cpp:
  • assembler/MacroAssemblerPrinter.h:
  • assembler/MacroAssemblerX86Common.cpp:
  • assembler/testmasm.cpp:

(JSC::isSpecialGPR):
(JSC::testProbeModifiesProgramCounter):
(JSC::run):

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::print):

  • b3/air/AirPrintSpecial.cpp:
  • b3/air/AirPrintSpecial.h:

Source/WTF:

This is needed in order to support https://bugs.webkit.org/show_bug.cgi?id=174645.
One consequence of this is that the DFG will now be disabled for the MIPS and
Windows ports. See:

https://bugs.webkit.org/show_bug.cgi?id=175447
https://bugs.webkit.org/show_bug.cgi?id=175449

Also, we should only ENABLE_SIGNAL_BASED_VM_TRAPS if the DFG is enabled. It was
never meaningful to use SIGNAL_BASED_VM_TRAPS with the baseline JIT anyway. This
is a mis-configuration error that is now fixed.

  • wtf/Platform.h:
9:47 PM Changeset in webkit [220578] by mitz@apple.com
  • 4 edits in trunk/Source

Restored svn:ignore values that went missing when the project got renamed.

Source/WebKit:

  • WebKit.xcodeproj: Added property svn:ignore.

Source/WebKitLegacy:

  • WebKitLegacy.xcodeproj: Added property svn:ignore.
9:22 PM Changeset in webkit [220577] by mitz@apple.com
  • 6 edits in trunk/Source/WebCore

Fixed building for macOS 10.12 with the macOS 10.13 SDK.

Suppressed the unguarded-availability-new warning around uses of AVSampleBufferAudioRenderer
and AVSampleBufferRenderSynchronizer. Even though the 10.13 SDK declares them as available
starting in that release, they have been available as SPI earlier.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setHasAvailableAudioSample):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeAudioRenderer):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVSampleBufferErrorListener beginObservingRenderer:]):
(-[WebAVSampleBufferErrorListener stopObservingRenderer:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::rendererDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::flush):

8:37 PM Changeset in webkit [220576] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.1-branch/Source/WebKit

Cherry-pick r220505. rdar://problem/33829962

8:06 PM Changeset in webkit [220575] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebInspectorUI

Web Inspector: Add three.js in preparation for layer visualization.
https://bugs.webkit.org/show_bug.cgi?id=174798

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-10
Reviewed by Brian Burg.

  • UserInterface/External/three.js/LICENSE: Added.
  • UserInterface/External/three.js/OrbitControls.js: Added.
  • UserInterface/External/three.js/three.js: Added.
7:59 PM Changeset in webkit [220574] by beidson@apple.com
  • 10 edits
    7 moves in trunk/Source

Rename the source files for the WTF persistent coders.
https://bugs.webkit.org/show_bug.cgi?id=175441

Reviewed by Tim Horton.

Source/WebCore:

  • platform/network/NetworkLoadMetrics.h:

Source/WebKit:

  • NetworkProcess/cache/NetworkCacheCoders.h:
  • NetworkProcess/cache/NetworkCacheKey.cpp:
  • NetworkProcess/cache/NetworkCacheKey.h:
  • UIProcess/API/APIContentRuleListStore.cpp:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/persistence/PersistentCoder.h: Renamed from Source/WTF/wtf/persistence/Coder.h.
  • wtf/persistence/PersistentCoders.cpp: Renamed from Source/WTF/wtf/persistence/Coders.cpp.
  • wtf/persistence/PersistentCoders.h: Renamed from Source/WTF/wtf/persistence/Coders.h.
  • wtf/persistence/PersistentDecoder.cpp: Renamed from Source/WTF/wtf/persistence/Decoder.cpp.
  • wtf/persistence/PersistentDecoder.h: Renamed from Source/WTF/wtf/persistence/Decoder.h.
  • wtf/persistence/PersistentEncoder.cpp: Renamed from Source/WTF/wtf/persistence/Encoder.cpp.
  • wtf/persistence/PersistentEncoder.h: Renamed from Source/WTF/wtf/persistence/Encoder.h.
7:58 PM Changeset in webkit [220573] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.0-branch/Source/WebKit

Cherry-pick r220505. rdar://problem/33829964

7:17 PM Changeset in webkit [220572] by don.olmstead@sony.com
  • 2 edits in trunk/Tools

Unreviewed, adding Ross Kirsling to contributors.json\n\n* Scripts/webkitpy/common/config/contributors.json:\n

6:47 PM Changeset in webkit [220571] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit

Resource Load Statistics: Increase grandfathering time to 7 days
https://bugs.webkit.org/show_bug.cgi?id=175414
<rdar://problem/33818046>

Reviewed by Brent Fulgham.

  • UIProcess/WebResourceLoadStatisticsStore.h:
6:41 PM Changeset in webkit [220570] by n_wang@apple.com
  • 2 edits in trunk/LayoutTests

Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=175272
<rdar://problem/33756962>

Since accessibilityPress is async, we shouldn't rely on the timeout.

Reviewed by Chris Fleizach.

  • accessibility/press-target-uses-text-descendant-node.html:
5:41 PM Changeset in webkit [220569] by Yusuke Suzuki
  • 3 edits in trunk/Source/WebCore

Make ThreadGlobalData RefCounted for web thread
https://bugs.webkit.org/show_bug.cgi?id=175439

Reviewed by Mark Lam.

When the web thread is enabled, we share ThreadGlobalData between the web thread and the main thread.
The problem happens when the main thread is dying. It could start deallocating TLS and the web
thread may see the destructed ThreadGlobalData.

Even though, the current implementation is safe because the main thread do not perform TLS deallocation
in the Darwin environment. But this is not true in Windows. And we should not rely on this condition
that depends on the platforms.

In this patch, we make ThreadGlobalData ThreadSafeRefCounted. This type verbosely describes that
ThreadGlobalData could be shared between threads when the web thread enabled. And make the life time
management simple instead of relying on the platform dependent TLS implementation.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::cachedResourceRequestInitiators): Deleted.
(WebCore::ThreadGlobalData::eventNames): Deleted.
(WebCore::ThreadGlobalData::threadTimers): Deleted.
(WebCore::ThreadGlobalData::qualifiedNameCache): Deleted.
(WebCore::ThreadGlobalData::cachedConverterICU): Deleted.
(WebCore::ThreadGlobalData::cachedConverterTEC): Deleted.

5:41 PM Changeset in webkit [220568] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit

Resource Load Statistics: Add significant figures to telemetry calls
https://bugs.webkit.org/show_bug.cgi?id=175442
<rdar://problem/33834834>

Reviewed by Brent Fulgham.

With this change, logged values are allowed to have 3 significant figures
as opposed to today's 0 which is wrong.

  • UIProcess/WebResourceLoadStatisticsTelemetry.cpp:

(WebKit::submitTopList):
(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):

5:36 PM Changeset in webkit [220567] by Yusuke Suzuki
  • 4 edits in trunk

Unreviewed, attempt to fix build failure with VC2017

Source/WTF:

  • wtf/PriorityQueue.h:

Tools:

  • TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(TEST):

5:36 PM Changeset in webkit [220566] by Yusuke Suzuki
  • 3 edits in trunk/Source/WebCore

[JSC] Use @toNumber in builtins
https://bugs.webkit.org/show_bug.cgi?id=172692

Reviewed by Sam Weinig.

Use @toNumber bytecode intrinsic. It emits op_to_number, which efficiently converts
a given argument to a number.

  • Modules/streams/ReadableByteStreamInternals.js:

(privateInitializeReadableByteStreamController):
(readableByteStreamControllerRespond):

  • Modules/streams/StreamInternals.js:

(validateAndNormalizeQueuingStrategy):
(enqueueValueWithSize):

5:29 PM Changeset in webkit [220565] by Yusuke Suzuki
  • 2 edits in trunk/Tools

Unreviewed, suppress warnings on GCC

  • TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

(TestWebKitAPI::CheckedArithmeticTester::run):

5:23 PM Changeset in webkit [220564] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

  • platform/ios-11/TestExpectations:
4:57 PM Changeset in webkit [220563] by mitz@apple.com
  • 2 edits in trunk/Tools

[Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
https://bugs.webkit.org/show_bug.cgi?id=173223

Reviewed by Tim Horton.

The rebuilds were happening due to a difference in the compiler options that the IDE and
xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
Advanced when a Custom Absolute path is selected.

  • Scripts/webkitdirs.pm:

(determineBaseProductDir):

4:42 PM Changeset in webkit [220562] by Yusuke Suzuki
  • 7 edits
    1 copy in trunk

Run more WTF tests
https://bugs.webkit.org/show_bug.cgi?id=174970

Reviewed by Michael Catanzaro.

Source/WTF:

CHAR_BIT is not defined.

  • wtf/LEBDecoder.h:

Tools:

Some of WTF tests are not executed in non Apple ports while they are generic ones.
This patch adds these tests to non-Apple port TestWebKitAPI.
Currently, we do not add Signals.cpp since it depends on signal functionality.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(isHigherPriority):
(TEST):

  • TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.

(TEST):

  • TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:

(TEST):

4:21 PM Changeset in webkit [220561] by Ryan Haddad
  • 3 edits
    2 copies
    3 adds in branches/safari-604.1.38.1-branch/LayoutTests

Unreviwed test gardening. rdar://problem/33789505

  • imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt:
  • imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt:
  • platform/mac-highsierra/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
  • platform/mac-highsierra/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt.
  • platform/mac-highsierra/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt.
4:20 PM Changeset in webkit [220560] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

4:18 PM Changeset in webkit [220559] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

4:16 PM Changeset in webkit [220558] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

4:14 PM Changeset in webkit [220557] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.2.2

Tag Safari-604.2.2.

4:00 PM Changeset in webkit [220556] by mark.lam@apple.com
  • 15 edits in trunk/Source

Apply the UNLIKELY macro to some unlikely things.
https://bugs.webkit.org/show_bug.cgi?id=175440
<rdar://problem/33834767>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::jettison):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::disassemble):

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalizeCommon):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileOSRExit):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeCommon):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::compileWithoutLinking):
(JSC::JIT::link):

  • runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::installCode):

  • runtime/VM.cpp:

(JSC::VM::VM):

Source/WebKit:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getBytecodeProfile):

3:57 PM Changeset in webkit [220555] by Ryan Haddad
  • 2 edits
    46 adds in trunk/LayoutTests

Unreviewed test gardening for High Sierra.

  • platform/mac-highsierra/css1/basic/inheritance-expected.txt: Added.
  • platform/mac-highsierra/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Added.
  • platform/mac-highsierra/css2.1/t0805-c5522-brdr-02-e-expected.txt: Added.
  • platform/mac-highsierra/css3/selectors3/html/css3-modsel-18-expected.txt: Added.
  • platform/mac-highsierra/css3/selectors3/xhtml/css3-modsel-18-expected.txt: Added.
  • platform/mac-highsierra/css3/selectors3/xml/css3-modsel-18-expected.txt: Added.
  • platform/mac-highsierra/fast/block/basic/001-expected.txt: Added.
  • platform/mac-highsierra/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
  • platform/mac-highsierra/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
  • platform/mac-highsierra/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
  • platform/mac-highsierra/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
  • platform/mac-highsierra/fast/css/css3-nth-child-expected.txt: Added.
  • platform/mac-highsierra/fast/css/text-overflow-input-expected.txt: Added.
  • platform/mac-highsierra/fast/dom/34176-expected.txt: Added.
  • platform/mac-highsierra/fast/dom/clone-node-dynamic-style-expected.txt: Added.
  • platform/mac-highsierra/fast/forms/basic-inputs-expected.txt: Added.
  • platform/mac-highsierra/fast/forms/input-value-expected.txt: Added.
  • platform/mac-highsierra/fast/forms/plaintext-mode-2-expected.txt: Added.
  • platform/mac-highsierra/fast/invalid/003-expected.txt: Added.
  • platform/mac-highsierra/fast/invalid/004-expected.txt: Added.
  • platform/mac-highsierra/fast/invalid/nestedh3s-expected.txt: Added.
  • platform/mac-highsierra/fast/selectors/018-expected.txt: Added.
  • platform/mac-highsierra/fast/table/frame-and-rules-expected.txt: Added.
  • platform/mac-highsierra/fast/text/atsui-multiple-renderers-expected.txt: Added.
  • platform/mac-highsierra/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.
  • platform/mac-highsierra/fast/text/font-weights-expected.txt: Added.
  • platform/mac-highsierra/fast/text/font-weights-zh-expected.txt: Added.
  • platform/mac-highsierra/fast/text/indic-expected.txt: Added.
  • platform/mac-highsierra/fast/text/international/complex-character-based-fallback-expected.txt:
  • platform/mac-highsierra/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/mac-highsierra/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
  • platform/mac-highsierra/svg/batik/text/textStyles-expected.txt: Added.
  • platform/mac-highsierra/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
  • platform/mac-highsierra/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
3:44 PM Changeset in webkit [220554] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.1.4

Tag Safari-604.1.38.1.4.

3:42 PM Changeset in webkit [220553] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Turn on support for Beacon API by default in STP
https://bugs.webkit.org/show_bug.cgi?id=175445
<rdar://problem/33836379>

Reviewed by Youenn Fablet.

  • Shared/WebPreferencesDefinitions.h:
3:39 PM Changeset in webkit [220552] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.4

Tag Safari-604.1.38.0.4.

3:15 PM Changeset in webkit [220551] by n_wang@apple.com
  • 6 edits
    3 adds in trunk

AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/33782159>

Reviewed by Chris Fleizach.

Source/WebCore:

The issue here is that we manualy set the parent object of the AccessibilitySVGRoot object
and there are chances that the parent doesn't detach it properly during the parent's destroying
process. Accessing the stale parent object will lead to a crash.
Fixed this by making the parent object a weak pointer so we don't access an invalid memory.

Test: accessibility/add-children-pseudo-element.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::createWeakPtr):

  • accessibility/AccessibilitySVGRoot.cpp:

(WebCore::AccessibilitySVGRoot::AccessibilitySVGRoot):
(WebCore::AccessibilitySVGRoot::setParent):
(WebCore::AccessibilitySVGRoot::parentObject const):

  • accessibility/AccessibilitySVGRoot.h:

LayoutTests:

  • accessibility/add-children-pseudo-element-expected.txt: Added.
  • accessibility/add-children-pseudo-element.html: Added.
  • accessibility/resources/svg-circle.svg: Added.
3:08 PM Changeset in webkit [220550] by Ryan Haddad
  • 2 edits in trunk/Source/WebKit

Fix iOS simulator build after change "[WTF] Move TextStream into WTF"
https://bugs.webkit.org/show_bug.cgi?id=175211

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-10
Reviewed by Myles C. Maxfield.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollByContentOffset:]):
(-[WKWebView _navigationGestureDidBegin]):

2:51 PM Changeset in webkit [220549] by Chris Dumez
  • 19 edits
    4 adds in trunk

[Beacon] Do connect-src CSP check on redirects as well
https://bugs.webkit.org/show_bug.cgi?id=175410
<rdar://problem/33815470>

Reviewed by Youenn Fablet.

Source/WebCore:

Pass ContentSecurityPolicy object to createPingHandle so that we can send
enough data to the NetworkProcess so do CSP checks for Ping loads such
as Beacon. For the IPC, we serialize the ContentSecurityPolicy's response
headers. Those headers are now cached in ContentSecurityPolicy for
performance reasons. CSP headers are rarely updated in practice but
sendBeacon() may get called repeatedly for a given document.

Tests: http/wpt/beacon/connect-src-beacon-redirect-allowed.sub.html

http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html

  • loader/LoaderStrategy.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):

  • loader/PingLoader.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::responseHeaders const):
(WebCore::ContentSecurityPolicy::didReceiveHeader):

  • page/csp/ContentSecurityPolicy.h:
  • page/csp/ContentSecurityPolicyResponseHeaders.h:

(WebCore::ContentSecurityPolicyResponseHeaders::encode const):
(WebCore::ContentSecurityPolicyResponseHeaders::decode):

Source/WebKit:

Pass CSP Response headers to the NetworkProcess via NetworkResourceLoadParameters
when doing a PingLoad. This allows PingLoad to do CSP checks (in particular
connect-src ones) in case the ping load gets redirected. Those checks need to be
done on the NetworkProcess side at this point because there is no guarantee the
WebContent process is still around.

To do the CSP checks, PingLoad lazily reconstructs a ContentSecurityPolicy object
from the CSP response headers.

  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/NetworkResourceLoadParameters.h:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::contentSecurityPolicy):

  • NetworkProcess/PingLoad.h:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::createPingHandle):

  • WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

Update createPingHandle() to take in ContentSecurityPolicy
object in but no behavior change for WK1.

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::createPingHandle):

  • WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Add layout test coverage.

  • http/wpt/beacon/connect-src-beacon-redirect-allowed.sub-expected.txt: Added.
  • http/wpt/beacon/connect-src-beacon-redirect-allowed.sub.html: Added.
  • http/wpt/beacon/connect-src-beacon-redirect-blocked.sub-expected.txt: Added.
  • http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html: Added.
2:19 PM Changeset in webkit [220548] by Yusuke Suzuki
  • 7 edits in trunk/Source

[WTF] ThreadSpecific should not introduce additional indirection
https://bugs.webkit.org/show_bug.cgi?id=175187

Reviewed by Mark Lam.

Source/JavaScriptCore:

  • runtime/Identifier.cpp:

Source/WebCore:

We drop ThreadSpecific::replace feature which is only used by
Web thread. Instead, we use ThreadSpecific<std::unique_ptr<T>> here.

While this std::unique_ptr<T> shares one instance between main thread
and web thread, this is the same to the current implementation. It is
safe because the web thread never finishes.

And for non-web thread implementation, we just use ThreadSpecific<T>,
since it is the most efficient.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):
We also drop StringImpl::empty() call since it is not necessary now:
StringImpl::empty data is statically initialized by using constexpr.

  • platform/ThreadGlobalData.h:

We make it FAST_ALLOCATED since it is previously allocated by fast malloc
in ThreadSpecific.

Source/WTF:

ThreadSpecific sets Data* to the TLS. And Data holds T*, which
is fast allocated actual data. But ideally, we should store T
instance directly in Data instead of introducing an additional
indirection.

This patch adds storage in Data in order to embed the instance of T. The constructor
for Data will invoke the constructor for T on the embedded storage. We also drop
ThreadSpecific::replace which is only used by the web thread to set its thread specific
ThreadGlobalData to the one shared from the main thread. The existing implementation
relies on the main thread and the web thread never exiting in order for the shared
ThreadGlobalData to stay alive. We can achieve the same semantics by using a
ThreadSpecific<std::unique_ptr<T>> to hold the ThreadGlobalData instance instead.

  • wtf/ThreadSpecific.h:

(WTF::ThreadSpecific::Data::construct):
(WTF::ThreadSpecific::Data::Data):
We make it fast allocated since we previously allocated ThreadSpecific T data by fastMalloc.

(WTF::ThreadSpecific::Data::~Data):
(WTF::ThreadSpecific::Data::storagePointer const):
(WTF::canBeGCThread>::get):
We also drop RELEASE_ASSERT from ::get(). We already inserted this assert to setAndConstruct(),
so when creating the member to this TLS, we execute this release assert. So it is
not necessary to execute this assertion every time we get data from this TLS.

(WTF::canBeGCThread>::set):
(WTF::canBeGCThread>::destroy):
(WTF::canBeGCThread>::setAndConstruct):
(WTF::T):
(WTF::canBeGCThread>::replace): Deleted.

2:06 PM Changeset in webkit [220547] by jmarcell@apple.com
  • 12 edits in tags/Safari-604.2.1.1

Cherry-pick r220473. rdar://problem/33834103

2:05 PM Changeset in webkit [220546] by jmarcell@apple.com
  • 7 edits in tags/Safari-604.2.1.1/Source

Versioning.

1:50 PM Changeset in webkit [220545] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.2.1.1

Tag Safari-604.2.1.1.

1:49 PM Changeset in webkit [220544] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove obsolete link from webkit-queues status page
https://bugs.webkit.org/show_bug.cgi?id=175337

Patch by obinna obike <oobike@apple.com> on 2017-08-10
Reviewed by Aakash Jain.

  • QueueStatusServer/templates/recentstatus.html:

Removed the link to the ews-watcher server.

1:47 PM Changeset in webkit [220543] by Jonathan Bedard
  • 2 edits in trunk/LayoutTests

Mark webgl/webgl-box-shadow.html and webgl/webgl-border.html as failing for ios-device.
https://bugs.webkit.org/show_bug.cgi?id=175437

Unreviewed test gardening.

  • platform/ios-device/TestExpectations:
1:34 PM Changeset in webkit [220542] by Brian Burg
  • 5 edits
    1 add in trunk

WKPreferences should conform to NSCopying
https://bugs.webkit.org/show_bug.cgi?id=175303
<rdar://problem/33764939>

Reviewed by Dan Bernstein.

Source/WebKit:

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Add conformance in the private header, as there is not consensus that this
needs to be API.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences copyWithZone:]):
Copy the wrapped WebPreferences instance and return its wrapper.

Tools:

Add unit test to make sure a WKPreference and its copy are
not aliased to each other or affect each other's properties.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.

(TEST):

12:39 PM Changeset in webkit [220541] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WTF

Fix a silly typo in Compiler.h

  • wtf/Compiler.h:

Heature, indeed.

12:31 PM Changeset in webkit [220540] by Michael Catanzaro
  • 6 edits in trunk

REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Alberto Lopez Perez.

.:

  • Source/cmake/FindGeoClue2.cmake:

Source/WebCore:

Also stop using GEOCLUE_LIBRARIES and GEOCLUE_INCLUDE_DIRS, since they are empty. Apparently
we have not actually been using the client library at all this whole time, only the D-Bus
interface.

  • PlatformGTK.cmake:

Source/WebKit:

  • PlatformGTK.cmake:
12:28 PM Changeset in webkit [220539] by beidson@apple.com
  • 14 edits
    2 copies
    14 adds in trunk

Add ServiceWorkerJob.
https://bugs.webkit.org/show_bug.cgi?id=175241

Reviewed by Tim Horton.

Source/WebCore:

Test: http/tests/workers/service/basic-register.html

This patch does a few things:

  • Adds the spec concept of a ServiceWorkerJob (in the WebProcess, at least)
  • Adds a ServiceWorkerProvider interface for WebKit to implement
  • Actually creates a job for service worker registration and "schedules" it, though it always immediately errors out the promise.

Actually queuing jobs and executing asynchronously is coming up soon.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::sessionID const):

  • dom/Document.h:
  • workers/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::~ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::jobDidFinish):

  • workers/ServiceWorkerContainer.h:
  • workers/ServiceWorkerJob.cpp: Added.

(WebCore::ServiceWorkerJob::ServiceWorkerJob):
(WebCore::ServiceWorkerJob::~ServiceWorkerJob):
(WebCore::ServiceWorkerJob::failedWithException):

  • workers/ServiceWorkerJob.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.

(WebCore::ServiceWorkerJob::createRegisterJob):
(WebCore::ServiceWorkerJob::identifier const):

  • workers/ServiceWorkerJobClient.h: Added.

(WebCore::ServiceWorkerJobClient::~ServiceWorkerJobClient):

  • workers/ServiceWorkerProvider.cpp: Added.

(WebCore::ServiceWorkerProvider::singleton):
(WebCore::ServiceWorkerProvider::setSharedProvider):

  • workers/ServiceWorkerProvider.h: Added.
  • workers/ServiceWorkerRegistrationOptions.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.
  • workers/ServiceWorkerRegistrationParameters.cpp: Added.
  • workers/ServiceWorkerRegistrationParameters.h: Added.

Source/WebKit:

  • CMakeLists.txt:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Storage/WebServiceWorkerProvider.cpp: Added.

(WebKit::WebServiceWorkerProvider::singleton):
(WebKit::WebServiceWorkerProvider::WebServiceWorkerProvider):
(WebKit::WebServiceWorkerProvider::scheduleJob):

  • WebProcess/Storage/WebServiceWorkerProvider.h: Added.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

LayoutTests:

Verifies that the "serviceWorker.register()" job we currently schedule fails as expected.

  • http/tests/workers/service/basic-register-expected.txt: Added.
  • http/tests/workers/service/basic-register.html: Added.
  • http/tests/workers/service/resources/basic-register.js: Added.
  • http/tests/workers/service/resources/empty-worker.js: Added.
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
12:05 PM Changeset in webkit [220538] by timothy_horton@apple.com
  • 10 edits in trunk

Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
https://bugs.webkit.org/show_bug.cgi?id=175436
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):

Source/WebCore:

  • platform/audio/cocoa/MediaSessionManagerCocoa.cpp:

(PlatformMediaSessionManager::updateSessionState):

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):

Source/WebKit:

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData):

Tools:

  • TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:

(TestWebKitAPI::TEST_F):

11:57 AM Changeset in webkit [220537] by Lucas Forschler
  • 2 edits in trunk/Tools

Fix duplicated code from r220534.

Unreviewed cleanup.

  • Scripts/bisect-builds:
11:47 AM Changeset in webkit [220536] by jiewen_tan@apple.com
  • 4 edits
    1 add in trunk/Tools

[WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
https://bugs.webkit.org/show_bug.cgi?id=175344
<rdar://problem/28507240>

Reviewed by Alexey Proskuryakov.

Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
Finally enable the existing tests for iOS.

  • TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
11:27 AM Changeset in webkit [220535] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r220463.
https://bugs.webkit.org/show_bug.cgi?id=175435

unaccepted fix (Requested by n_wang on #webkit).

Reverted changeset:

"AX: crash at
WebCore::AccessibilityObject::supportsARIALiveRegion() const +
24"
https://bugs.webkit.org/show_bug.cgi?id=175340
http://trac.webkit.org/changeset/220463

11:22 AM Changeset in webkit [220534] by Lucas Forschler
  • 1 edit
    1 add in trunk/Tools

Write a tool to bisect WebKit builds
https://bugs.webkit.org/show_bug.cgi?id=174596

Reviewed by Dean Johnson and Kocsen Chung.

  • Scripts/bisect-builds: Added.

(bisect_builds): main bisection algorithm
(download_archive):download an archive from S3 using existing tools
(extract_archive):extract an archive using existing tools
(find_le):Find rightmost value less than or equal to x
(find_ge):Find leftmost item greater than or equal to x
(get_api_url):generate url for the rest api/database
(get_indices_from_revisions):convert revisions to list indexes for bisection
(get_sorted_revisions):retrieve sorted revision list
(get_s3_location_for_revision):calculate the S3 archive storage location
(parse_args):parse command line arguments
(pick_next_build):compute the next build to bisect
(prompt_did_reproduce):prompt user for direction for bisection
(set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
(test_archive):Platform specific logic to test downloaded archive
(minified_platforms):return a list of minified platforms in the database
(unminified_platforms):return a list of full platforms in the database
(is_supported_platform):check if platform is supported
(validate_options):validate command line options
(main):

11:17 AM Changeset in webkit [220533] by Lucas Forschler
  • 1 edit
    1 delete in trunk/Tools

Remove bisect-builds script.
https://bugs.webkit.org/show_bug.cgi?id=175433

Reviewed by Aakash Jain.

  • Scripts/bisect-builds: Removed.
10:04 AM Changeset in webkit [220532] by Michael Catanzaro
  • 21 edits
    5 deletes in trunk

Remove ENABLE_GAMEPAD_DEPRECATED
https://bugs.webkit.org/show_bug.cgi?id=175361

Reviewed by Carlos Garcia Campos.

.:

  • Source/cmake/FindGUdev.cmake: Removed.
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • platform/Linux.cmake: Removed.
  • platform/gamepad/deprecated/Gamepads.h: Removed.
  • platform/gamepad/glib/GamepadsGlib.cpp: Removed.
  • platform/gamepad/linux/GamepadDeviceLinux.cpp: Removed.
  • platform/gamepad/linux/GamepadDeviceLinux.h: Removed.

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9:59 AM Changeset in webkit [220531] by mmaxfield@apple.com
  • 3 edits in trunk/Source/WebCore

Addressing post-review comments after r219173.
https://bugs.webkit.org/show_bug.cgi?id=174149

Unreviewed.

  • css/CSSFontStyleValue.h:
  • editing/EditingStyle.cpp:

(WebCore::identifierForStyleProperty):

9:53 AM Changeset in webkit [220530] by Ryan Haddad
  • 4 edits in trunk/LayoutTests

Update TestExpectations for imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors.html.
https://bugs.webkit.org/show_bug.cgi?id=170698

Unreviewed test gardening.

  • TestExpectations: Skip test on debug because it times out on every run.
  • platform/ios/TestExpectations: Mark as flaky on Release.
  • platform/mac/TestExpectations: Ditto.
9:33 AM Changeset in webkit [220529] by clopez@igalia.com
  • 4 edits in trunk

REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Garcia Campos.

.:

Fix the pkg-config file name.
We really require geoclue-2.0 and not libgeoclue-2.0.

  • Source/cmake/FindGeoClue2.cmake:

Tools:

  • gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
8:44 AM Changeset in webkit [220528] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Try to fix windows build.

  • style/StyleUpdate.h:

(WebCore::Style::TextUpdate::TextUpdate):

5:25 AM Changeset in webkit [220527] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit

[GTK] Don't use --whole-archive linking flags for the WebKit2 target libraries
https://bugs.webkit.org/show_bug.cgi?id=175416

Reviewed by Carlos Garcia Campos.

  • PlatformGTK.cmake: Drop the ADD_WHOLE_ARCHIVE_TO_LIBRARIES instruction

for the WebKit2 target. This unnecessarily bundles complete archive
files both into the main .so library as well as single executables that
are linked against the WebKit2 target.

5:01 AM Changeset in webkit [220526] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add Ms2ger as contributor.
https://bugs.webkit.org/show_bug.cgi?id=175325

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-10
Reviewed by Carlos Alberto Lopez Perez.

  • Scripts/webkitpy/common/config/contributors.json:
4:02 AM Changeset in webkit [220525] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Crashes in WebCore::PasteboardHelper::fillSelectionData when source file of drag is unavailable
https://bugs.webkit.org/show_bug.cgi?id=174161

Reviewed by Xabier Rodriguez-Calvar.

In r219385 we changed the early return in fillSelectionData() to check the selection data length instead of the
data pointer. However, the gtk_selection_data_get_length() can return -1, so we need to check also if the value
less than 0. The case of setting an empty string could be valid depending on the target type, so it's better to
return early only when data lenght is less than 0 and handle the 0 length case in each target.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillSelectionData):

3:44 AM Changeset in webkit [220524] by magomez@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Update expectations of several tests failing at r220516.

  • platform/gtk/TestExpectations:
3:20 AM Changeset in webkit [220523] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Text renderer updates should be done by RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=175417

Reviewed by Andreas Kling.

All render tree mutations should be done by RenderTreeUpdater. Currently
Text::updateRendererAfterContentChange calls RenderText::setTextWithOffset directly.

  • dom/Document.cpp:

(WebCore::Document::updateTextRenderer):

Add range argument.

  • dom/Document.h:
  • dom/Text.cpp:

(WebCore::Text::updateRendererAfterContentChange):

Remove call to setTextWithOffset and pass the range to updateTextRenderer

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateTextRenderer):

Call setTextWithOffset here.

  • style/RenderTreeUpdater.h:
  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree):

  • style/StyleUpdate.cpp:

(WebCore::Style::Update::textUpdate const):
(WebCore::Style::Update::addText):

Add TextUpdate struct similar to ElementUpdate to pass the range to the RenderTreeUpdater.

  • style/StyleUpdate.h:
1:37 AM Changeset in webkit [220522] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK+ build fix for ENABLE_GLES2=ON.

  • platform/graphics/texmap/TextureMapperGLHeaders.h:

Define various GL constants that are not provided in GLES2 headers
but are only leveraged in OpenGL calls if at runtime the underlying
OpenGL is GLES2-capable.

12:39 AM Changeset in webkit [220521] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

[TexMap] Remove GraphicsContext3D usage from BitmapTexturePool
https://bugs.webkit.org/show_bug.cgi?id=175319

Reviewed by Carlos Garcia Campos.

Drop the GraphicsContext3D reference in BitmapTexturePool now
that the BitmapTextureGL doesn't require it anymore.

No new tests -- no change in behavior.

  • platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::BitmapTexturePool):

  • platform/graphics/texmap/BitmapTexturePool.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::TextureMapperGL):

12:30 AM Changeset in webkit [220520] by jmarcell@apple.com
  • 21 edits in branches/safari-604-branch

Cherry-pick r220459. rdar://problem/33820790

12:20 AM Changeset in webkit [220519] by zandobersek@gmail.com
  • 6 edits in trunk/Source/WebCore

[TexMap] Drop GraphicsContext3D usage from BitmapTextureGL
https://bugs.webkit.org/show_bug.cgi?id=175317

Reviewed by Carlos Garcia Campos.

Have BitmapTextureGL use direct OpenGL API entrypoints and constants
instead of leveraging the GraphicsContext3D class. Any GraphicsContext3D
object passed to BitmapTextureGL would assume rendering to the GL context
that's current on that thread, translating method invocations to the
OpenGL API. We can do this by ourselves and benefit by avoiding allocating
GraphicsContext3D resources like the ANGLE compiler that are by most useful
for WebGL.

BitmapTextureGL::create() call sites are adjusted to stop passing a
GraphicsContext3D reference. BitmapTextureGL::bindAsSurface() doesn't need
a replacement for the passed-in GraphicsContext3D object since that object
originated from the TextureMapperGL instance, whose GraphicsContext3D is by
default of the render-to-current-context nature. Other changes are direct
translations of GraphicsContext3D methods to OpenGL API calls, or of
GraphicsContext3D values to OpenGL API constants.

No new tests -- no change in behavior.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):

  • platform/graphics/texmap/BitmapTextureGL.cpp:

Also remove an unnecessary GraphicsContext.h header inclusion.
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bindAsSurface):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::copyFromExternalTexture):

  • platform/graphics/texmap/BitmapTextureGL.h:

(WebCore::BitmapTextureGL::create):
(WebCore::BitmapTextureGL::textureTarget const):
(WebCore::BitmapTextureGL::internalFormat const):

  • platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::createTexture):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::createTexture):

Note: See TracTimeline for information about the timeline view.