Timeline



Aug 28, 2017:

9:33 PM Changeset in webkit [221289] by Brent Fulgham
  • 3 edits in trunk/Source/WebKitLegacy/win

Unreviewed build fix #2 after r221275.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
to match new API.

  • WebCoreSupport/WebPlatformStrategies.h: Update signatures.
7:59 PM Changeset in webkit [221288] by eric.carlson@apple.com
  • 4 edits in trunk

Logger should use makeString instead of String::format
https://bugs.webkit.org/show_bug.cgi?id=176035

Reviewed by Jer Noble.

Source/WebCore/PAL:

  • pal/Logger.h:

(PAL::LogArgument::toString):
(PAL::Logger::logAlways):
(PAL::Logger::error):
(PAL::Logger::warning):
(PAL::Logger::notice):
(PAL::Logger::info):
(PAL::Logger::debug):
(PAL::Logger::MethodAndPointer::MethodAndPointer):
(PAL::Logger::log):
(PAL::LogArgument<Logger::MethodAndPointer>::toString):

Tools:

  • TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::TEST_F): Update test.

7:18 PM Changeset in webkit [221287] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline accessibility/menu-list-crash2.html after r220930.

Unreviewed test gardening.

  • platform/win/accessibility/menu-list-crash2-expected.txt:
5:55 PM Changeset in webkit [221286] by aestes@apple.com
  • 15 edits
    2 adds in trunk/Source

[Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
https://bugs.webkit.org/show_bug.cgi?id=176039

Reviewed by Alex Christensen.

Source/WebCore:

  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/text/TextEncodingRegistry.cpp:

(WebCore::defaultTextEncodingNameForSystemLanguage):

  • platform/text/TextEncodingRegistry.h:
  • platform/text/ios/TextEncodingRegistryIOS.mm: Added.

(WebCore::webDefaultCFStringEncoding):

  • platform/text/mac/TextEncodingRegistryMac.mm: Added.

(WebCore::webDefaultCFStringEncoding):

Source/WebKit:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebView/WebPreferences.mm:

(+[WebPreferences _systemCFStringEncoding]):

Source/WTF:

  • wtf/spi/cf/CFStringSPI.h:
5:42 PM Changeset in webkit [221285] by Ryan Haddad
  • 2 edits
    1 copy
    3 adds in trunk/LayoutTests

Rebaseline http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl.

Unreviewed test gardening.

  • http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt:
  • platform/mac-highsierra/http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt: Copied from LayoutTests/http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt.
5:40 PM Changeset in webkit [221284] by Michael Catanzaro
  • 5 edits in trunk/Tools

[GStreamer] The glvideoflip GStreamer element isn't available. Video mirroring and rotation functionalities are thus disabled.
https://bugs.webkit.org/show_bug.cgi?id=175576

Reviewed by Carlos Alberto Lopez Perez.

Build graphene to enable the glvideoflip element.

  • gstreamer/jhbuild.modules:
  • gtk/jhbuild.modules:
  • jhbuild/jhbuild-wrapper:
  • wpe/jhbuild.modules:
5:27 PM Changeset in webkit [221283] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r220278): Web Inspector: ContextMenu items are not getting triggered
https://bugs.webkit.org/show_bug.cgi?id=176034

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-08-28
Reviewed by Devin Rousso.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::showContextMenu):
Responses go through InspectorFrontendAPI not InspectorFrontendHost.

5:21 PM Changeset in webkit [221282] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviewed test gardening. <rdar://problem/33381269> <rdar://problem/33903582>

  • platform/ios-11/TestExpectations:
4:56 PM Changeset in webkit [221281] by Megan Gardner
  • 2 edits in trunk/Source/WebKit

Fix incorrect enum in atBoundaryOfGranularity call
https://bugs.webkit.org/show_bug.cgi?id=176004

Reviewed by Wenson Hsieh and Enrica Casucci

Enum that was being used was incorrect, as that case in not covered in called function.
Resulted in a no-op. Should now have correct behavior around line boundaries.

Not possible to add tests for selections with velocity. Will attempt to add this behavior later.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeAtWordBoundaryForPosition):

4:29 PM Changeset in webkit [221280] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening. <rdar://problem/34051745>

  • platform/ios-11/TestExpectations:
4:29 PM Changeset in webkit [221279] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit

[WinCairo] Add PlatformWin cmake for Webkit
https://bugs.webkit.org/show_bug.cgi?id=176027

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-08-28
Reviewed by Brent Fulgham.

  • PlatformWin.cmake: Added.
3:46 PM Changeset in webkit [221278] by Brent Fulgham
  • 2 edits in trunk/Source/WebKitLegacy/win

Unreviewed build fix after r221275.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
to match new API.

3:38 PM Changeset in webkit [221277] by commit-queue@webkit.org
  • 9 edits in trunk

WebRTC MediaStream created without tracks does not update active state after tracks are added
https://bugs.webkit.org/show_bug.cgi?id=175434

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-28
Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test.

Removing active/inactive events.
active attribute is still kept and is updated synchronously on every track change.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::activeStatusChanged):
(WebCore::MediaStream::internalAddTrack):
(WebCore::MediaStream::updateActiveState):
(WebCore::MediaStream::hasPendingActivity const):
(WebCore::MediaStream::scheduleActiveStateChange): Deleted.
(WebCore::MediaStream::activityEventTimerFired): Deleted.

  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/MediaStream.idl:

LayoutTests:

  • fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track-expected.txt:
  • fast/mediacapturefromelement/CanvasCaptureMediaStream-creation-expected.txt:
  • fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
  • fast/mediastream/MediaStream-add-remove-tracks.html:
3:23 PM Changeset in webkit [221276] by aestes@apple.com
  • 20 edits in trunk/Source

[Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176032

Reviewed by Alex Christensen.

Source/WebCore:

  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/NetworkStorageSession.h:
  • platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::ensureSession):

  • platform/network/cf/ResourceRequest.h:
  • platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::createPrivateStorageSession):

  • platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::setStorageSession):
(WebCore::copyRequestWithStorageSession):
(WebCore::cachedResponseForRequest):

  • platform/network/mac/CookieJarMac.mm:

(WebCore::httpCookies):
(WebCore::setHTTPCookiesForURL):
(WebCore::deleteHTTPCookie):
(WebCore::deleteAllHTTPCookies):
(WebCore::setCookiesFromDOM):
(WebCore::httpCookieAcceptPolicy):
(WebCore::cookiesEnabled):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteAllCookies):
(WebCore::deleteCookiesForHostnames):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::privateBrowsingSession):

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::cachedResponseForURL):

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebView/WebView.mm:

(-[WebView _cachedResponseForURL:]):

3:08 PM Changeset in webkit [221275] by Brent Fulgham
  • 26 edits
    4 adds in trunk

Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
https://bugs.webkit.org/show_bug.cgi?id=175992
<rdar://problem/34086613>

Reviewed by Daniel Bates.

Source/WebCore:

The original work in Bug 157053 did not properly handle the case of websockets. This patch completes
the changes to secure cookie handling to make sure websockets are also protected.

Tests: http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl

http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::clientHandshakeRequest): Remove 'const' declaration so we can work with
a mutable Document object. This allows us to mark the Document as having accessed secure cookies.
(WebCore::WebSocketChannel::clientHandshakeRequest const): Deleted.

  • Modules/websockets/WebSocketChannel.h:
  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage): Ditto.
(WebCore::WebSocketHandshake::clientHandshakeRequest): Ditto.
(WebCore::WebSocketHandshake::clientHandshakeMessage const): Deleted.
(WebCore::WebSocketHandshake::clientHandshakeRequest const): Deleted.

  • Modules/websockets/WebSocketHandshake.h:
  • loader/CookieJar.cpp:

(WebCore::cookies): Small naming cleanup.
(WebCore::cookieRequestHeaderFieldValue): Pass a flag indicating whether secure cookies should be
included in the result or not. Set the document flag indicating secure cookies were accessed (if
they were), and return the resulting cookie string.

  • loader/CookieJar.h:
  • platform/CookiesStrategy.h:
  • platform/network/CacheValidation.cpp:

(WebCore::headerValueForVary): Revise to pass a flag indicating whether secure cookies should be included
or not.

  • platform/network/PlatformCookieJar.h:
  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::doesContainSecureCookies): Added helper method.
(WebCore::cookiesForDOM): Revise to use new helper function.
(WebCore::cookieRequestHeaderFieldValue): Revise to accept a flag indicating if secure cookies should
be included in the result. Return a pair consisting of the cookie string, and a flag indicating whether
secure cookies were accessed or not.

  • platform/network/curl/CookieJarCurl.cpp:

(WebCore::CookieJarCurlFileSystem::cookieRequestHeaderFieldValue): Ditto.
(WebCore::cookieRequestHeaderFieldValue): Ditto.

  • platform/network/curl/CookieJarCurl.h:
  • platform/network/mac/CookieJarMac.mm:

(WebCore::cookiesForSession): Ditto.
(WebCore::cookiesForDOM): Update for new 'cookiesForSession' signature.
(WebCore::cookieRequestHeaderFieldValue): Ditto.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieRequestHeaderFieldValue): Revise to accept a flag indicating if secure cookies should
be included in the result. Return a pair consisting of the cookie string, and a flag indicating whether
secure cookies were accessed or not.

Source/WebKit:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::cookiesForDOM): Use a better label than 'result'.
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue): Modify to accept a flag
indicating if secure cookies should be included, and return a pair containing the resulting
cookie string and a boolean indicating if secure cookies were accessed.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in: Ditto.
  • Shared/mac/CookieStorageShim.mm:

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Ditto.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue): Ditto.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
cookies should be included, and return a pair containing the resulting cookie string and a boolean
indicating if secure cookies were accessed.

LayoutTests:

  • http/tests/websocket/tests/hybi/secure-cookie-insecure-connection-expected.txt: Added.
  • http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl: Added.
  • http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt: Added.
  • http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl: Added.
2:57 PM Changeset in webkit [221274] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Unreviewed, remove duplicated TestExpectation entry.

  • platform/mac-highsierra-wk2/TestExpectations:
2:48 PM Changeset in webkit [221273] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r221161. rdar://problem/34113784

2:48 PM Changeset in webkit [221272] by jmarcell@apple.com
  • 4 edits in branches/safari-604-branch

Cherry-pick r221153. rdar://problem/34113728

2:14 PM Changeset in webkit [221271] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Before r220970, these ssl tests were failing. Now they are timing out.

Unreviewed test gardening.

  • platform/win/TestExpectations:
2:13 PM Changeset in webkit [221270] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172544

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:57 PM Changeset in webkit [221269] by jmarcell@apple.com
  • 3 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r221138. rdar://problem/34113574

1:11 PM Changeset in webkit [221268] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKitLegacy/win

[Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
https://bugs.webkit.org/show_bug.cgi?id=176031

Reviewed by Brent Fulgham.

When the function in the FramePolicyFunction parameter is called, it has already been moved
to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
function by using the stored member instead.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

1:10 PM Changeset in webkit [221267] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked svg/in-html/by-reference.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175781

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
12:56 PM Changeset in webkit [221266] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove some unused DataGrid code
https://bugs.webkit.org/show_bug.cgi?id=176029

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-08-28
Reviewed by Matt Baker.

  • UserInterface/Views/DataGrid.js:

(WI.DataGrid.prototype.get copyTextDelimiter):
(WI.DataGrid.prototype.set copyTextDelimiter):
(WI.DataGrid.prototype.resizerDragging):
(WI.DataGrid.prototype.columnWidthsMap): Deleted.
(WI.DataGrid.prototype.applyColumnWidthsMap): Deleted.
(WI.DataGrid.prototype.get resizeMethod): Deleted.
(WI.DataGrid.prototype.set resizeMethod): Deleted.

12:48 PM Changeset in webkit [221265] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Skip service workers tests on Windows.

Unreviewed test gardening.

  • platform/win/TestExpectations:
12:05 PM Changeset in webkit [221264] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Fixed expectations for http/tests/loading/basic-auth-remove-credentials.html by removing double expectations

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:40 AM Changeset in webkit [221263] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html after r221209.

Unreviewed test gardening..

  • platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
11:40 AM WebKitIDL edited by Konstantin Tokarev
JSCustomSetter -> CustomSetter (diff)
11:26 AM WebKitIDL edited by Konstantin Tokarev
Remove uses of obsolete module MODULE_NAME { } blocks which were … (diff)
11:21 AM WebKitIDL edited by Konstantin Tokarev
Remove mentions of CPP bindings which are long gone (diff)
11:20 AM Changeset in webkit [221262] by achristensen@apple.com
  • 4 edits in trunk/Source/WebKit

Add WKUIDelegatePrivate equivalent of WKPageUIClient's didExceedBackgroundResourceLimitWhileInForeground
https://bugs.webkit.org/show_bug.cgi?id=176028
<rdar://problem/29270035>

Reviewed by Andy Estes.

An API test for this did not succeed with either the memory or CPU limit calls,
possibly because the app must be in the foreground for this call to be made.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::toWKResourceLimit):
(WebKit::UIDelegate::UIClient::didExceedBackgroundResourceLimitWhileInForeground):

10:31 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
10:30 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
9:52 AM Changeset in webkit [221261] by commit-queue@webkit.org
  • 5 edits
    1 delete in trunk/LayoutTests

Fix document-create-touch.html.
https://bugs.webkit.org/show_bug.cgi?id=172813

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-28
Reviewed by Michael Catanzaro.

The document.createTouch() call is supposed to throw an exception (as
defined by WebIDL). It has been doing this since r203941, but this
wasn't noticed because the entire fast/events/touch folder is skipped
on mac, ios and win.

  • fast/events/touch/document-create-touch-expected.txt:
  • fast/events/touch/document-create-touch.html:
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/events/touch/document-create-touch-expected.txt: Removed.
  • platform/wpe/TestExpectations:
9:37 AM Changeset in webkit [221260] by clopez@igalia.com
  • 3 edits
    1 move in trunk/Source/WebCore

[GTK] [WPE] Rename EventHandlerGlib to EventHandlerGLib
https://bugs.webkit.org/show_bug.cgi?id=175864

Unreviewed cosmetic follow-up patch after r221075.

No new tests. No change in behavior.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • platform/glib/EventHandlerGLib.cpp: Renamed from Source/WebCore/platform/glib/EventHandlerGlib.cpp.

(WebCore::EventHandler::tabsToAllFormControls const):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passMouseDownEventToWidget):
(WebCore::EventHandler::eventActivatedView const):
(WebCore::EventHandler::widgetDidHandleWheelEvent):
(WebCore::EventHandler::createDraggingDataTransfer const):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::accessKeyModifiers):
(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):

8:54 AM Changeset in webkit [221259] by Ryan Haddad
  • 2 edits in branches/safari-604.1.38.0-branch/Tools

Cherry-pick r221117.

8:50 AM Changeset in webkit [221258] by Ryan Haddad
  • 4 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html after r221209.

Unreviewed test gardening.

  • platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
8:29 AM Changeset in webkit [221257] by Michael Catanzaro
  • 4 edits
    1 add in trunk/LayoutTests

Unreviewed GTK/WPE test gardening

  • platform/gtk/TestExpectations:
  • platform/gtk/compositing/iframes/compositing-for-scrollable-iframe-expected.txt: Added.
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/wpe/js/dom/global-constructors-attributes-expected.txt:
7:38 AM Changeset in webkit [221256] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.18/Source/JavaScriptCore

Merge r221018 - We are using valueProfileForBytecodeOffset when there may not be a value profile
https://bugs.webkit.org/show_bug.cgi?id=175812

Reviewed by Michael Saboff.

This patch uses the type system to aid the code around CodeBlock's ValueProfile
accessor methods. valueProfileForBytecodeOffset used to return ValueProfile*,
so there were callers of this that thought it could return nullptr when there
was no such ValueProfile. This was not the case, it always returned a non-null
pointer. This patch changes valueProfileForBytecodeOffset to return ValueProfile&
and adds a new tryGetValueProfileForBytecodeOffset method that returns ValueProfile*
and does the right thing if there is no such ValueProfile.

This patch also changes the other ValueProfile accessors on CodeBlock to
return ValueProfile& instead of ValueProfile*. Some callers handled the null
case unnecessarily, and using the type system to specify the result can't be
null removes these useless branches.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::dumpValueProfiles):
(JSC::CodeBlock::tryGetValueProfileForBytecodeOffset):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::validate):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::valueProfileForArgument):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::getFromAllValueProfiles):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

  • dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::emitValueProfilingSite):

  • profiler/ProfilerBytecodeSequence.cpp:

(JSC::Profiler::BytecodeSequence::BytecodeSequence):

  • tools/HeapVerifier.cpp:

(JSC::HeapVerifier::validateJSCell):

6:55 AM Changeset in webkit [221255] by Carlos Garcia Campos
  • 17 edits
    2 adds in trunk/Source

WebDriver: implement screen capture commands
https://bugs.webkit.org/show_bug.cgi?id=174615

Reviewed by Brian Burg.

Source/WebDriver:

Implement takeScreenshot and takeElementScreenshot commands.

  1. Screen Capture.

https://w3c.github.io/webdriver/webdriver-spec.html#screen-capture

  • CommandResult.cpp:

(WebDriver::CommandResult::CommandResult): Handle ScreenshotError protocol error.
(WebDriver::CommandResult::httpStatusCode const): Add UnableToCaptureScreen.
(WebDriver::CommandResult::errorString const): Ditto.

  • CommandResult.h:
  • Session.cpp:

(WebDriver::Session::takeScreenshot):

  • Session.h:
  • WebDriverService.cpp:

(WebDriver::WebDriverService::takeScreenshot):
(WebDriver::WebDriverService::takeElementScreenshot):

  • WebDriverService.h:

Source/WebKit:

Extend takeScreenshot command to optionally take a screenshot of an element. When no element is provided, the
screenshot is taken from the page visible area.

  • PlatformGTK.cmake: Add WebAutomationSessionCairo.cpp to compilation.
  • PlatformWPE.cmake: Ditto.
  • UIProcess/Automation/Automation.json: Add ScreenshotError and several optional parameters to takeScreenshot.
  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::takeScreenshot): Receive optional frame, node and scrollIntoView that are
checked and passed to the web process.

  • UIProcess/Automation/WebAutomationSession.h:
  • UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp: Added.

(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData): Cairo implementation.

  • UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:
  • WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::snapshotRectForScreenshot): Helper to get the rectangle to be used for a screenshot.
(WebKit::WebAutomationSessionProxy::takeScreenshot): If a node handle is provided take the snapshot using the
element rectangle, otherwise use the page visible content rectangle.

  • WebProcess/Automation/WebAutomationSessionProxy.h:
  • WebProcess/Automation/WebAutomationSessionProxy.messages.in: Update TakeSnapshot message.
6:39 AM Changeset in webkit [221254] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r221008 - GLContext: zero-initialize the GLContext pointer in ThreadGlobalGLContext
https://bugs.webkit.org/show_bug.cgi?id=175819

Reviewed by Xabier Rodriguez-Calvar.

  • platform/graphics/GLContext.cpp: The ThreadGlobalGLContext object is

allocated on heap, so the embedded GLContext pointer can contain a
non-null value that can cause problems when e.g. checking for a current
GLContext on some specific thread on which a GLContext hasn't yet been
made current. Zero-initializing this pointer will avoid false positives
that can occur in these circumstances.

6:38 AM Changeset in webkit [221253] by Carlos Garcia Campos
  • 3 edits
    1 move
    1 add in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r221007 - [GTK][WPE] Rename StorageProcessMainGtk.cpp to StorageProcessMainGLib.cpp
https://bugs.webkit.org/show_bug.cgi?id=175814

Reviewed by Gyuyoung Kim.

Both GTK+ and WPE ports already compile the StorageProcessMainGtk.cpp
file, but it should be renamed to StorageProcessMainGLib and moved into
the StorageProcess/glib/ directory.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • StorageProcess/glib/StorageProcessMainGLib.cpp: Renamed from Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp.
6:30 AM Changeset in webkit [221252] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220988 - Cleanup TextPainter
https://bugs.webkit.org/show_bug.cgi?id=175782

Reviewed by Myles C. Maxfield.

Remove redundant mention of "text" in the name of TextPainter member functions, add separate
setters for selection and non-selection shadows, and do some other minor cleanups.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Update code for renamed functions.

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow): Ditto.

  • rendering/TextPainter.cpp: Include ShadowData.h.

(WebCore::ShadowApplier::ShadowApplier): Use C++11 brace-initialization syntax.
(WebCore::ShadowApplier::isLastShadowIteration): Moved from TextPainter.h.
(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText): Ditto.
(WebCore::TextPainter::paintTextOrEmphasisMarks): Renamed; formerly named drawTextOrEmphasisMarks.
(WebCore::TextPainter::paintTextWithShadows): Update code for renamed functions.
(WebCore::TextPainter::paintRange): Renamed; formerly named paintTextInRange.
(WebCore::TextPainter::paint): Renamed; formerly named paintText.
(WebCore::TextPainter::drawTextOrEmphasisMarks): Renamed to paintTextOrEmphasisMarks() to match
the naming convention of all the other paint functions in this class.
(WebCore::TextPainter::paintTextInRange): Renamed to paintRange.
(WebCore::TextPainter::paintText): Renamed to paint.

  • rendering/TextPainter.h: Forward declare ShadowData.

(WebCore::TextPainter::setStyle): Renamed; formerly named setTextPaintStyle.
(WebCore::TextPainter::setSelectionStyle): Renamed; formerly named setSelectionPaintStyle.
(WebCore::TextPainter::setShadow): Added.
(WebCore::TextPainter::setSelectionShadow): Added.
(WebCore::TextPainter::setEmphasisMark): Renamed; formerly named addEmphasis.
(WebCore::TextPainter::setTextPaintStyle): Renamed to setStyle.
(WebCore::TextPainter::setSelectionPaintStyle): Renamed to setSelectionStyle.
(WebCore::TextPainter::addEmphasis): Renamed to setEmphasisMark.
(WebCore::TextPainter::addTextShadow): Split functionality into setShadow and setSelectionShadow.
(WebCore::ShadowApplier::isLastShadowIteration): Moved to TextPainter.cpp.
(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText): Ditto.

6:27 AM Changeset in webkit [221251] by Carlos Garcia Campos
  • 4 edits
    1 copy in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220985 - Stop media/video-controls-toggling.html from timing out.
https://bugs.webkit.org/show_bug.cgi?id=116266

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-21
Reviewed by Dean Jackson.

Use getComputedStyle to check the display property. Element::style only
contains properties set in the style attribute, but the display property
is set through CSS using the 'hidden' class.

  • media/video-controls-toggling-expected.txt:
  • media/video-controls-toggling.html:
  • platform/gtk/TestExpectations:
  • platform/gtk/media/video-controls-toggling-expected.txt: Copied from LayoutTests/media/video-controls-toggling-expected.txt. I'm not sure where the console message comes from, but it seems to be in the GTK-specific code.
6:22 AM Changeset in webkit [221250] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18

Merge r220982 - StringView could use a function to strip leading/trailing characters without allocation
https://bugs.webkit.org/show_bug.cgi?id=175757

Reviewed by Darin Adler.

Source/WTF:

There are many places in WebCore/WebKit that we call functions like,
WebCore::stripLeadingAndTrailingHTMLSpaces, or String::stripWhiteSpace() only to use
the allocated String as a temporary for either another transformation or a comparison.
Now that we have StringView, we can avoid that extra allocation, by having returning a
StringView substring in these scenarios.

For instance, the check (from ScriptElement.cpp:287):

if (!stripLeadingAndTrailingHTMLSpaces(sourceURL).isEmpty()) {

...

}

currently allocates a string just to make this check. With a new
stripLeadingAndTrailingHTMLSpaces such as:

StringView stripLeadingAndTrailingHTMLSpaces(StringView stringView)
{

return stringView.stripLeadingAndTrailingMatchedCharacters([] (auto c) {

return isHTMLSpace(c);

});

}

We could instead have exact same code from ScriptElement.cpp now avoid an allocation.

  • wtf/text/StringView.h:

(WTF::StringView::stripLeadingAndTrailingMatchedCharacters):

Tools:

  • TestWebKitAPI/Tests/WTF/StringView.cpp:

Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().

5:46 AM Changeset in webkit [221249] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220978 - [GTK][WPE][GSTREAMER_GL] Overriden virtual function not marked “override” in MediaPlayerPrivateGStreamerBase.h
https://bugs.webkit.org/show_bug.cgi?id=175780

Reviewed by Konstantin Tokarev.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: Add missing "override" qualifier.
5:44 AM Changeset in webkit [221248] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220967 - [GTK][WPE] Rebaseline tests with list item markers.
https://bugs.webkit.org/show_bug.cgi?id=175771

Unreviewed test gardening.

The output was changed in r220858 and rebaselined for ios and mac only.
They're changes in render tree dumps that don't affect rendering.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-21

  • platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/gtk/fast/doctypes/002-expected.txt:
  • platform/gtk/fast/lists/marker-before-empty-inline-expected.txt:
  • platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
5:43 AM Changeset in webkit [221247] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220963 - MemoryCache::setCapacities assertion failure maxDeadBytes <= totalBytes
https://bugs.webkit.org/show_bug.cgi?id=175571

Patch by Charlie Turner <cturner@igalia.com> on 2017-08-21
Reviewed by Antti Koivisto.

  • Shared/CacheModel.cpp:

(WebKit::calculateMemoryCacheSizes): Ensure cacheTotalCapacity is
set to a reasonable value even in low-memory environments.

5:32 AM Changeset in webkit [221246] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

Automation: takeScreenshot should use the visible content rect not the document rect
https://bugs.webkit.org/show_bug.cgi?id=175665

Reviewed by Brian Burg.

According to the spec, we should get the toplevel browsing context document rectangle and take a screenshot of
it using the current viewport width and height. We are currently using the document size.

  1. Screen Capture.

https://w3c.github.io/webdriver/webdriver-spec.html#dfn-draw-a-bounding-box-from-the-framebuffer

  • WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::takeScreenshot): Use FrameView::visibleContentRect().

5:07 AM Changeset in webkit [221245] by Carlos Garcia Campos
  • 8 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220934 - Followup (r220289): RenderImageResourceStyleImage code clean up
https://bugs.webkit.org/show_bug.cgi?id=175444

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-18
Reviewed by Darin Adler.

RenderImageResourceStyleImage may be created with a StyleImage of type
StyleGeneratedImage. It may also be associated with a CachedImage which
is loaded through a source URL. In this case, adding and removing m_renderer
as a client of the CachedImage will be done through
RenderImageResource::setCachedImage().

RenderImageResource::setCachedImage() is already called from
ImageLoader::updateRenderer() when the CachedImage finishes loading. This
call adds m_renderer to the clients of the CachedImage.
RenderImageResource::setCachedImage() will also be called from
RenderImageResourceStyleImage::shutdown() via RenderImageResource::shutdown()
to remove m_renderer from the clients of CachedImage by passing a null pointer.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::styleWillChange):

  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::shutdown):
(WebCore::RenderImageResource::setCachedImage):
(WebCore::RenderImageResource::resetAnimation):
(WebCore::RenderImageResource::image const):
(WebCore::RenderImageResource::setContainerSizeForRenderer):
(WebCore::RenderImageResource::imageSize const):
(WebCore::RenderImageResource::~RenderImageResource): Deleted.
(WebCore::RenderImageResource::errorOccurred const): Deleted.
(WebCore::RenderImageResource::imageHasRelativeWidth const): Deleted.
(WebCore::RenderImageResource::imageHasRelativeHeight const): Deleted.
(WebCore::RenderImageResource::intrinsicSize const): Deleted.
(WebCore::RenderImageResource::getImageSize const): Deleted.

  • rendering/RenderImageResource.h:

(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::renderer const):
(WebCore::RenderImageResource::errorOccurred const):
(WebCore::RenderImageResource::imageHasRelativeWidth const):
(WebCore::RenderImageResource::imageHasRelativeHeight const):
(WebCore::RenderImageResource::imageSize const):
(WebCore::RenderImageResource::intrinsicSize const):
(WebCore::RenderImageResource::imagePtr const):

  • rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::initialize):
(WebCore::RenderImageResourceStyleImage::shutdown):
(WebCore::RenderImageResourceStyleImage::image const):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer):
(WebCore::RenderImageResourceStyleImage::~RenderImageResourceStyleImage): Deleted.

  • rendering/RenderImageResourceStyleImage.h:
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::RenderSVGImage):

5:02 AM Changeset in webkit [221244] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220931 - REGRESSION (r220601): Crash when closing google doc after switching the order of tabs in safari
https://bugs.webkit.org/show_bug.cgi?id=175721
<rdar://problem/33928369>

Reviewed by Geoffrey Garen.

Make sure WebProcess::markAllLayersVolatile() does not call WTFMove() multiple times
on the same completion handler. Use a RefCounter to hold on to the completion handler
and make sure the handler gets called when the RefCounter's value becomes 0.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::markAllLayersVolatile):
(WebKit::WebProcess::cancelMarkAllLayersVolatile):

  • WebProcess/WebProcess.h:
4:57 AM Changeset in webkit [221243] by Carlos Garcia Campos
  • 8 edits
    2 adds in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220916 - Factor render tree mutation code from RenderListItem to RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=175718

Reviewed by Andreas Kling.

We already stopped doing layout time mutations. We can now move the code out too.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderListItem.cpp:

(WebCore::isHTMLListElement):
(WebCore::getParentOfFirstLineBox): Deleted.
(WebCore::firstNonMarkerChild): Deleted.
(WebCore::RenderListItem::updateMarkerRenderer): Deleted.

Moved to RenderTreeUpdater::ListItem.

  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::willBeDestroyed):

  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::pushParent):
(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeDescendants):
(WebCore::RenderTreeUpdater::updateAfterDescendants):

Factor pre/post update into functions.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):

  • style/RenderTreeUpdater.h:
  • style/RenderTreeUpdaterListItem.cpp: Added.

Mutation functions move here.

(WebCore::getParentOfFirstLineBox):
(WebCore::firstNonMarkerChild):
(WebCore::RenderTreeUpdater::ListItem::updateMarker):

  • style/RenderTreeUpdaterListItem.h: Added.
4:53 AM Changeset in webkit [221242] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18

Merge r220910 - [GTK] Show controls if a video element isn't allowed to play inline.
https://bugs.webkit.org/show_bug.cgi?id=141705

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-18
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Test: covered by media/video-fullscreeen-only-controls.html [sic].

  • Modules/mediacontrols/mediaControlsGtk.js:

(ControllerGtk.prototype.shouldHaveControls):

LayoutTests:

  • platform/gtk/TestExpectations: enable test for this case.
4:52 AM Changeset in webkit [221241] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebDriver

WebDriver: implement cookies commands
https://bugs.webkit.org/show_bug.cgi?id=174613

Reviewed by Brian Burg.

Add cookies commands.

  1. Cookies.

https://w3c.github.io/webdriver/webdriver-spec.html#cookies

  • CommandResult.cpp:

(WebDriver::CommandResult::httpStatusCode const): Add NoSuchCookie error.
(WebDriver::CommandResult::errorString const): Ditto.

  • CommandResult.h:
  • Session.cpp:

(WebDriver::parseAutomationCookie): Parse JSON cookie object returned by automation and convert it to a Cookie struct.
(WebDriver::builtAutomationCookie): Build a JSON cookie object as expected by automation from a Cookie struct.
(WebDriver::serializeCookie): Serialize a Cookie struct into a JSON cookie object according to the WebDriver spec.
(WebDriver::Session::getAllCookies):
(WebDriver::Session::getNamedCookie):
(WebDriver::Session::addCookie):
(WebDriver::Session::deleteCookie):
(WebDriver::Session::deleteAllCookies):

  • Session.h:
  • WebDriverService.cpp:

(WebDriver::WebDriverService::getAllCookies):
(WebDriver::WebDriverService::getNamedCookie):
(WebDriver::deserializeCookie):
(WebDriver::WebDriverService::addCookie):
(WebDriver::WebDriverService::deleteCookie):
(WebDriver::WebDriverService::deleteAllCookies):

  • WebDriverService.h:
4:46 AM Changeset in webkit [221240] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Ensure that the alert function is called in TestWebExtensions.
https://bugs.webkit.org/show_bug.cgi?id=175880

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-28
Reviewed by Carlos Garcia Campos.

The test relied on a bug in the HTMLDocument JavaScript bindings: when calling
document.open() with three arguments, it would call any function set as the
"open" property on the window object, rather than just the real Window::open()
method. This bug was fixed by the removal of custom bindings for HTMLDocument
in r218437. As a result, the test no longer called alert(), which caused it to
fail.

Instead, call the window.open() function directly.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(testWebExtensionIsolatedWorld):

4:23 AM Changeset in webkit [221239] by Michael Catanzaro
  • 2 edits
    1 delete in trunk/LayoutTests

New baseline for insecure-audio-video-in-main-frame.html should apply to all ports

The global baseline was never updated because the test has been failing on macOS.

  • http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt:
  • platform/gtk/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Removed.
4:18 AM Changeset in webkit [221238] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit

[GTK][WPE] ASSERTION FAILED: !isOpen() in WebKit::IconDatabase::~IconDatabase()
https://bugs.webkit.org/show_bug.cgi?id=175719

Reviewed by Michael Catanzaro.

This is happening always when running /webkit2/WebKitFaviconDatabase/favicon-database-test in debug builds. The
last step we do is removing all icons, then the test finishes, which destroys the WebKitFaviconDatabase object
that closes the icon database on dispose. The problem is that removing all icons schedules a main thread
notification and IconDatabase is not considered closed until all main thread callbacks have been dispatched. This
is never going to happen in the test, because the main loop is no longer running at that point. I don't think
it's worth it to consider the database open while main thread callbacks are pending, they are just notifications
and the client is no longer insterested on them afer closing the database. I think it's bettter and simpler to
simply cancel the pending callbacks on database close. That ensures that isOpen() after close() is always
false. This patch adds a helper private class to schedule notifications to the main thread that can be cancelled
on database close. It also removes the didClose() notification because it was unused and because it's pointless
now that we know the database is closed after close().

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::open): Mark the main thread notifier as active.
(WebKit::IconDatabase::close): Mark the main thread notifier as not active.
(WebKit::IconDatabase::IconDatabase): Remove m_mainThreadCallbackCount initialization.
(WebKit::IconDatabase::isOpen const): Do what isOpenBesidesMainThreadCallbacks() used to do.
(WebKit::IconDatabase::removeAllIconsOnThread): Remove the notification because it's currently unused.
(WebKit::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread): Use MainThreadNotifier.
(WebKit::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread): Ditto.
(WebKit::IconDatabase::dispatchDidFinishURLImportOnMainThread): Ditto.
(WebKit::IconDatabase::isOpenBesidesMainThreadCallbacks const): Deleted.
(WebKit::IconDatabase::checkClosedAfterMainThreadCallback): Deleted.
(WebKit::IconDatabase::dispatchDidRemoveAllIconsOnMainThread): Deleted.

  • UIProcess/API/glib/IconDatabase.h:

(WebKit::IconDatabaseClient::didChangeIconForPageURL):
(WebKit::IconDatabaseClient::didFinishURLImport):
(WebKit::IconDatabase::MainThreadNotifier::MainThreadNotifier):
(WebKit::IconDatabase::MainThreadNotifier::setActive):
(WebKit::IconDatabase::MainThreadNotifier::notify):
(WebKit::IconDatabase::MainThreadNotifier::stop):
(WebKit::IconDatabase::MainThreadNotifier::timerFired):
(WebKit::IconDatabaseClient::didRemoveAllIcons): Deleted.
(WebKit::IconDatabaseClient::didClose): Deleted.

4:02 AM Changeset in webkit [221237] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[GTK] Rebaseline insecure-audio-video-in-main-frame.html.
https://bugs.webkit.org/show_bug.cgi?id=142482

Unreviewed test gardening.

The test is failing due to a different console message. It seems better
to add a platform-specific baseline so we can catch actual failures.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-28

  • platform/gtk/TestExpectations:
  • platform/gtk/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Added.
3:20 AM Changeset in webkit [221236] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Enable userAgentShadowDOM tests.
https://bugs.webkit.org/show_bug.cgi?id=176015

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-28

  • platform/gtk/TestExpectations:
1:16 AM Changeset in webkit [221235] by zandobersek@gmail.com
  • 21 edits in trunk/Source/WebCore

[WebCrypto] Push WorkQueue dispatches for AES algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175539

Reviewed by Sam Weinig.

Push the WorkQueue dispatch code and other code duplicated between the
Mac and libgcrypt implementations of Web Crypto into the shared layer.
This patch focuses on the AES-based algorithms.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr
value. CryptoAlgorithmParameters objects are passed through non-const
references because data getters could lazily construct the underlying
Vector objects. CryptoKey objects are passed through const references.
Implementations can then manually retrieve and further validate any key
or parameter data, as required for that specific implementation. Input
data is passed through const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):

  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:
  • crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:

(WebCore::CryptoAlgorithmAES_CFB::encrypt):
(WebCore::CryptoAlgorithmAES_CFB::decrypt):

  • crypto/algorithms/CryptoAlgorithmAES_CFB.h:
  • crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:

(WebCore::CryptoAlgorithmAES_CTR::encrypt):
(WebCore::CryptoAlgorithmAES_CTR::decrypt):

  • crypto/algorithms/CryptoAlgorithmAES_CTR.h:
  • crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:

(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):

  • crypto/algorithms/CryptoAlgorithmAES_GCM.h:
  • crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::wrapKey):
(WebCore::CryptoAlgorithmAES_KW::unwrapKey):

  • crypto/algorithms/CryptoAlgorithmAES_KW.h:
  • crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmAES_CFBGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmAES_CTRGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp:

(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_CFBMac.cpp:

(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_CTRMac.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

Aug 27, 2017:

10:12 PM Changeset in webkit [221234] by wenson_hsieh@apple.com
  • 18 edits
    1 add in trunk

Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
https://bugs.webkit.org/show_bug.cgi?id=170955
<rdar://problem/31697653>

Reviewed by Ryosuke Niwa.

Source/WebKit:

Currently, we insert text with TextEventInputAutocompletion as the text event input type if any text range to
replace was specified by the platform. Instead, limit this only to when the text replacement range is not empty.
This more closely matches the intention of the spec, which states that the "insertReplacementText" inputType
should be used when "[replacing] existing text by means of a spell checker, auto-correct or similar".

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::insertTextAsync):

Source/WebKitLegacy/mac:

Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
text is being replaced.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView insertText:]):

Tools:

Replace UIScriptController.insertText with UIScriptController.replaceTextAtRange, and implement
replaceTextAtRange in WebKit1. See corresponding layout tests (input-event-insert-replacement.html and
before-input-prevent-insert-replacement.html) for more detail.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/AppKitTestSPI.h: Added.

Introduce an SPI header for private AppKit headers needed to support DumpRenderTree.

  • DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::replaceTextAtRange):
(WTR::UIScriptController::insertText): Deleted.

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::replaceTextAtRange):
(WTR::UIScriptController::insertText): Deleted.

  • TestRunnerShared/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::replaceTextAtRange):
(WTR::UIScriptController::insertText): Deleted.

Replace UIScriptController.insertText with UIScriptController.replaceTextAtRange, which better describes the
behavior of this function.

LayoutTests:

Augments two existing layout tests to check for additional cases of inserting text with replacement ranges.
Also enables this test for WebKit1 on Mac. Both these tests are currently enabled only for WebKit2, and also only
check the case where we're replacing an existing non-empty range of text.

  • fast/events/before-input-prevent-insert-replacement-expected.txt:
  • fast/events/before-input-prevent-insert-replacement.html:
  • fast/events/input-event-insert-replacement-expected.txt:
  • fast/events/input-event-insert-replacement.html:

Tests for cases of replacing existing text ranges, and inserting text at a position.

  • platform/mac-wk1/TestExpectations:
  • resources/ui-helper.js:

Add a new UIHelper function to insert text at a given replacement range. This codepath is taken when selecting
an emoji using the emoji picker menu on Mac, and also when selecting a dead key option after holding down on a
vowel key.

(window.UIHelper.replaceTextAtRange):

6:22 PM Changeset in webkit [221233] by wenson_hsieh@apple.com
  • 12 edits
    1 add in trunk

[iOS WK2] Web process crashes after changing selection to the end of the document when speaking a selection
https://bugs.webkit.org/show_bug.cgi?id=176011
<rdar://problem/32614095>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adds a null check to visiblePositionForPositionWithOffset. This is a crash point for accessibility codepaths,
since indexForVisiblePosition is not guaranteed to set the given root outparam to a non-null value, yet
visiblePositionForIndex requires root to be non-null. This causes a crash when selecting some text, hitting
'Speak', and then changing the selection to somewhere near the end of the document, since accessibility code
will attempt to speak words at an offset past the end of the document. While this is a bug in and of itself, the
web process should still handle this case gracefully and not crash. To fix this, we simply bail and return a
null VisiblePosition if a root container node was not found.

Currently, visiblePositionForPositionWithOffset is implemented twice, in WebCore (AXObjectCache.cpp) and also in
WebKit (WebPageIOS.mm), as identical static functions. This patch moves this helper into Editing.cpp and removes
it from AXObjectCache and WebPageIOS.

Tests: AccessibilityTests.RectsForSpeakingSelectionBasic

AccessibilityTests.RectsForSpeakingSelectionWithLineWrapping
AccessibilityTests.RectsForSpeakingSelectionDoNotCrashWhenChangingSelection

  • accessibility/AXObjectCache.cpp:

(WebCore::visiblePositionForPositionWithOffset): Deleted.

  • editing/Editing.cpp:

(WebCore::visiblePositionForPositionWithOffset):

  • editing/Editing.h:

Source/WebKit:

Adds an SPI hook to test accessibility codepaths when speaking selected content. This patch does some minor
refactoring by introducing _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:, which takes
and invokes a completion handler block. The existing _accessibilityRetrieveRectsAtSelectionOffset:withText:
method simply turns around and calls the former variant with nil as a completion handler.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _accessibilityRetrieveRectsAtSelectionOffset:withText:]):
(-[WKContentView _accessibilityRetrieveRectsAtSelectionOffset:withText:completionHandler:]):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::visiblePositionForPositionWithOffset): Deleted.

Tools:

Introduces AccessibilityTests, and adds three new tests that traverse selection-rect-finding codepaths when
speaking selected content. See WebKit and WebCore ChangeLogs for more detail.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm: Added.

(-[WKWebView rectsAtSelectionOffset:withText:]):
(checkCGRectValueAtIndex):
(TestWebKitAPI::TEST):

9:12 AM Changeset in webkit [221232] by webkit@devinrousso.com
  • 23 edits
    4 adds in trunk

Web Inspector: Record actions performed on WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=174483
<rdar://problem/34040722>

Reviewed by Matt Baker.

Source/JavaScriptCore:

  • inspector/protocol/Recording.json:
  • inspector/scripts/codegen/generator.py:

Add type and mapping for WebGL: "canvas-webgl" => CanvasWebGL

Source/WebCore:

Tests: inspector/canvas/recording-webgl.html

inspector/canvas/recording-webgl-snapshots.html

  • bindings/js/CallTracerTypes.h:

Add types for WebGL parameters.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeSetterBodyDefinition):
(GenerateImplementationFunctionCall):
(GenerateCallTracerParameter):
Modify the generated code for CallTracingCallback so that optional/nullable types are only
dereferenced if they have a value.

  • html/canvas/WebGLRenderingContext.idl:

Add CallTracingCallback to interface to record all API calls.

  • inspector/InspectorCanvas.h:
  • inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::shouldSnapshotWebGLAction):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::releaseInitialState):
(WebCore::InspectorCanvas::releaseFrames):
(WebCore::InspectorCanvas::appendActionSnapshotIfNeeded):
(WebCore::InspectorCanvas::getCanvasContentAsDataURL):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):
For all non-primitive WebGL objects, send a string corresponding to the object's name. The
value isn't needed since the preview will be generated by the toDataURL snapshots taken
after every visual action.

  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):

  • bindings/scripts/test/TestCallTracer.idl:
  • bindings/scripts/test/JS/JSTestCallTracer.cpp:

(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgument):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgument):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgument):

Source/WebInspectorUI:

  • UserInterface/Models/Recording.js:

(WI.Recording):
(WI.Recording.fromPayload):
(WI.Recording.prototype.swizzle):
Add swizzle types for WebGL parameters.

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction):
(WI.RecordingAction.fromPayload):
(WI.RecordingAction.prototype.get snapshot):
(WI.RecordingAction.prototype.swizzle):
(WI.RecordingAction.prototype.toJSON):
Include an optional fourth parameter snapshot that will be sent for visual actions when
recording WebGL canvas contexts.

  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):
(WI.RecordingContentView.prototype.get navigationItems):
(WI.RecordingContentView.prototype.updateActionIndex):
(WI.RecordingContentView.prototype.shown):
(WI.RecordingContentView.prototype._generateContentCanvasWebGL):

  • UserInterface/Views/RecordingContentView.css:

(.content-view:not(.tab).recording :matches(img, canvas)):
(.content-view:not(.tab).recording canvas): Deleted.
Instead of regenerating the canvas context in the WebInspector frontend, just display the
snapshot image for the last visual action.

  • UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView):

  • UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._generateDOM):

LayoutTests:

  • inspector/canvas/recording-webgl-expected.txt: Added.
  • inspector/canvas/recording-webgl.html: Added.
  • inspector/canvas/recording-webgl-snapshots-expected.txt: Added.
  • inspector/canvas/recording-webgl-snapshots.html: Added.

Created separate test for checking that snapshots differ so that each test doesn't interfere
with the results of the other tests.

  • inspector/canvas/recording-2d-expected.html:
  • inspector/canvas/recording-2d.html:

Drive by: change naming to match inspector/canvas/recording-webgl.html.

Aug 26, 2017:

5:08 PM Changeset in webkit [221231] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r220105): Storage service appears in macOS Activity Monitor as “localized string not found”
https://bugs.webkit.org/show_bug.cgi?id=176007

Reviewed by Tim Horton.

  • English.lproj/Localizable.strings: Updated using update-webkit-localizable-strings.
4:26 PM Changeset in webkit [221230] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Build fix. Creating trying a test group no longer updates the page.

  • public/v3/models/test-group.js:

(TestGroup.createWithCustomConfiguration): Added the missing ignoreCache=true.

12:09 PM Changeset in webkit [221229] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, mark a test as still failing

  • platform/gtk/TestExpectations:
9:58 AM Changeset in webkit [221228] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove PolicyChecker::cancelCheck
https://bugs.webkit.org/show_bug.cgi?id=176002

Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-26
Reviewed by Darin Adler.

cancelCheck is conceptually equivalent to not calling a completion handler.
stopCheck is conceptually equivalent to calling a completion handler with PolicyIgnore just before cleaning up everything,
which is semantically cleaner and necessary when I replace the last use of PolicyCallback with a CompletionHandler.
Before this change, we were probably causing some loading objects to hang right before deleting them, and this cleans them up better.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::cancelPolicyCheckIfNeeded):

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::cancelCheck): Deleted.

  • loader/PolicyChecker.h:
9:54 AM Changeset in webkit [221227] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Unreviewed, tighten up scope of variable in previous commit

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookiesForSession):

9:49 AM Changeset in webkit [221226] by Michael Catanzaro
  • 4 edits in trunk

[SOUP] Update cookie jar implementation to filter out secure cookies
https://bugs.webkit.org/show_bug.cgi?id=175850

Reviewed by Brent Fulgham.

Source/WebCore:

Filter out secure cookies when indicated.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookiesForSession):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):

LayoutTests:

Unskip newly-passing tests.

  • platform/gtk/TestExpectations:
1:40 AM Changeset in webkit [221225] by Yusuke Suzuki
  • 4 edits in trunk/Source

Unreviewed, suppress warnings in GTK port

Source/JavaScriptCore:

The "block" variable hides the argument variable.

  • dfg/DFGLiveCatchVariablePreservationPhase.cpp:

(JSC::DFG::LiveCatchVariablePreservationPhase::isValidFlushLocation):

Source/WTF:

Add printf format attribute.

  • wtf/text/WTFString.cpp:
1:29 AM Changeset in webkit [221224] by calvaris@igalia.com
  • 13 edits in trunk/Source/WebCore

[EME][GStreamer] Connect CDM to GStreamer
https://bugs.webkit.org/show_bug.cgi?id=175983

Reviewed by Žan Doberšek.

This is still a version that will need some changes for some other
use cases but it should be enough to begin with some passes in the
tests and some basic use cases.

We use the attach CDMInstance interface in the private player to
get the instance in time for the initializationDataEncountered
event, which is handled when the demuxer reports synchronously the
events even before configuring the decryptors. We wait there in
case we don't have the CDMInstance attached (which contains info
about the key system now) and when we get it we report it back to
the demuxer and continue sending the event.

We also handled the events when handled by the decryptors but for
now this will remain a FIXME. The events handled by the
AppendPipeline will end up here too for now.

The CDM instance is created with the key system because some CDMs
can handle more than one, not ClearKey yet but others in the
(near) future.

MockCDMFactory is adapted to the changes as expected.

  • Modules/encryptedmedia/CDM.cpp:

(WebCore::CDM::CDM):

  • platform/encryptedmedia/CDMFactory.h:
  • platform/encryptedmedia/CDMInstance.h:
  • platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::CDMFactoryClearKey::createCDM):
(WebCore::CDMInstanceClearKey::keySystem const):

  • platform/encryptedmedia/clearkey/CDMClearKey.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::extractEventsAndSystemsFromMessage):
(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
(WebCore::MediaPlayerPrivateGStreamerBase::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateGStreamerBase::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateGStreamerBase::attemptToDecryptWithInstance):
(WebCore::MediaPlayerPrivateGStreamerBase::attemptToDecryptWithLocalInstance):
(WebCore::MediaPlayerPrivateGStreamerBase::dispatchDecryptionKey):
(WebCore::MediaPlayerPrivateGStreamerBase::handleProtectionEvent):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::appendPipelineElementMessageCallback):
(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::AppendPipeline::handleNeedContextSyncMessage):
(WebCore::AppendPipeline::handleElementMessage):
(WebCore::AppendPipeline::handleAppsrcNeedDataReceived):
(WebCore::AppendPipeline::appsinkNewSample):

  • platform/graphics/gstreamer/mse/AppendPipeline.h:
  • testing/MockCDMFactory.cpp:

(WebCore::MockCDMFactory::createCDM):
(WebCore::MockCDMInstance::keySystem const):

  • testing/MockCDMFactory.h:
1:01 AM Changeset in webkit [221223] by Yusuke Suzuki
  • 12 edits
    2 moves in trunk/Source/JavaScriptCore

Merge WeakMapData into JSWeakMap and JSWeakSet
https://bugs.webkit.org/show_bug.cgi?id=143919

Reviewed by Darin Adler.

This patch changes WeakMapData from JSCell to JSDestructibleObject,
renaming it to WeakMapBase, and JSWeakMap and JSWeakSet simply inherit
it instead of separately allocating WeakMapData. This reduces memory
consumption and allocation times.

Also this patch a bit optimizes sizeof(DeadKeyCleaner) by dropping m_target
field. Since this class is always embedded in WeakMapBase, we can calculate
WeakMapBase address from the address of DeadKeyCleaner.

This patch does not include the optimization changing WeakMapData to Set
for JSWeakSet.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::weakMapSize):
(Inspector::JSInjectedScriptHost::weakMapEntries):
(Inspector::JSInjectedScriptHost::weakSetSize):
(Inspector::JSInjectedScriptHost::weakSetEntries):

  • runtime/JSWeakMap.cpp:

(JSC::JSWeakMap::finishCreation): Deleted.
(JSC::JSWeakMap::visitChildren): Deleted.

  • runtime/JSWeakMap.h:

(JSC::JSWeakMap::createStructure): Deleted.
(JSC::JSWeakMap::create): Deleted.
(JSC::JSWeakMap::weakMapData): Deleted.
(JSC::JSWeakMap::JSWeakMap): Deleted.

  • runtime/JSWeakSet.cpp:

(JSC::JSWeakSet::finishCreation): Deleted.
(JSC::JSWeakSet::visitChildren): Deleted.

  • runtime/JSWeakSet.h:

(JSC::JSWeakSet::createStructure): Deleted.
(JSC::JSWeakSet::create): Deleted.
(JSC::JSWeakSet::weakMapData): Deleted.
(JSC::JSWeakSet::JSWeakSet): Deleted.

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
  • runtime/WeakMapBase.cpp: Renamed from Source/JavaScriptCore/runtime/WeakMapData.cpp.

(JSC::WeakMapBase::WeakMapBase):
(JSC::WeakMapBase::destroy):
(JSC::WeakMapBase::estimatedSize):
(JSC::WeakMapBase::visitChildren):
(JSC::WeakMapBase::set):
(JSC::WeakMapBase::get):
(JSC::WeakMapBase::remove):
(JSC::WeakMapBase::contains):
(JSC::WeakMapBase::clear):
(JSC::WeakMapBase::DeadKeyCleaner::target):
(JSC::WeakMapBase::DeadKeyCleaner::visitWeakReferences):
(JSC::WeakMapBase::DeadKeyCleaner::finalizeUnconditionally):

  • runtime/WeakMapBase.h: Renamed from Source/JavaScriptCore/runtime/WeakMapData.h.

(JSC::WeakMapBase::size const):

  • runtime/WeakMapPrototype.cpp:

(JSC::getWeakMap):
(JSC::protoFuncWeakMapDelete):
(JSC::protoFuncWeakMapGet):
(JSC::protoFuncWeakMapHas):
(JSC::protoFuncWeakMapSet):
(JSC::getWeakMapData): Deleted.

  • runtime/WeakSetPrototype.cpp:

(JSC::getWeakSet):
(JSC::protoFuncWeakSetDelete):
(JSC::protoFuncWeakSetHas):
(JSC::protoFuncWeakSetAdd):
(JSC::getWeakMapData): Deleted.

12:48 AM Changeset in webkit [221222] by zandobersek@gmail.com
  • 19 edits in trunk/Source/WebCore

[WebCrypto] Push WorkQueue dispatches for RSA algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175621

Reviewed by Darin Adler.

Push the WorkQueue dispatch code and other code duplicated between the
Mac and libgcrypt implementations of Web Crypto into the shared layer.
This patch focuses on the RSA-based algorithms.

The WorkQueue dispatch code is condensed into two static functions on
the CryptoAlgorithm class, the first variation handling VectorCallback
as the callback type and the other handling BoolCallback. The operation
is kept in a WTF::Function<> object that returns an ExceptionOr<> value
embedding either a Vector<uint8_t> object or a boolean value, as
appropriate for the callback type.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr
value. CryptoAlgorithmParameters objects are passed through non-const
references because data getters could lazily construct the underlying
Vector objects. CryptoKey objects are passed through const references.
Implementations can then manually retrieve and further validate any key
or parameter data, as required for that specific implementation. Input
data is passed through const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

  • crypto/CryptoAlgorithm.cpp:

(WebCore::dispatchOperationImpl):
(WebCore::CryptoAlgorithm::dispatchOperation):

  • crypto/CryptoAlgorithm.h:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):

  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::encrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::decrypt):

  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
  • crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::sign):
(WebCore::CryptoAlgorithmRSA_PSS::verify):

  • crypto/algorithms/CryptoAlgorithmRSA_PSS.h:
  • crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:

(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

  • crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

  • crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

Aug 25, 2017:

8:30 PM Changeset in webkit [221221] by eric.carlson@apple.com
  • 7 edits in trunk

Add Logger::logAlways
https://bugs.webkit.org/show_bug.cgi?id=175996

Reviewed by Jer Noble.

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/Logger.h:

(PAL::Logger::willLog const):
(PAL::Logger::willLog const):
(PAL::Logger::logAlways): Added.
(PAL::Logger::error const): Add missing WTF_ATTRIBUTE_PRINTF.
(PAL::Logger::warning const): Ditto.
(PAL::Logger::notice const): Ditto.
(PAL::Logger::info const): Ditto.
(PAL::Logger::debug const): Use String::formatWithArguments.

Source/WTF:

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:

Tools:

  • TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::TEST_F):

7:49 PM Changeset in webkit [221220] by achristensen@apple.com
  • 2 edits in trunk/Tools

Disable saveDataToFile API test.
https://bugs.webkit.org/show_bug.cgi?id=176000

  • TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

The test was only working on High Sierra. It needs investigation on older operating systems.

6:43 PM Changeset in webkit [221219] by achristensen@apple.com
  • 4 edits
    3 moves in trunk/Tools

Rename TestWebKitAPI/Tests/WebKit2* to WebKit* following Source directory rename.

Rubber-stamped by Brady Eidson.

  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestBlobURL.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkEnabled.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageQuirkTest.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/PrepareForMoveToWindow.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorldPlugIn.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorldProtocol.h: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFView.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/attachment-element.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/double-click-does-not-select-trailing-space.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/enormous-video-with-sound.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-input-field-focus-onload.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-red-square.png: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/password-protected.pages: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/rendered-image-excluding-overflow.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/text-and-password-inputs.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/DOMClientRectTest.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMClientRect.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2ObjC: Removed.
  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Removed.
  • TestWebKitAPI/Tests/WebKitCocoa: Copied from TestWebKitAPI/Tests/WebKit2Cocoa.
  • TestWebKitAPI/Tests/WebKitGtk: Copied from TestWebKitAPI/Tests/WebKit2Gtk.
  • TestWebKitAPI/Tests/WebKitObjC: Copied from TestWebKitAPI/Tests/WebKit2ObjC.
  • TestWebKitAPI/glib/PlatformGTK.cmake:
5:54 PM Changeset in webkit [221218] by achristensen@apple.com
  • 5 edits
    1 move in trunk/Tools

Rename TestWebKitAPI/Tests/WebKit2 to WebKit following Source directory rename.

Rubber-stamped by Brady Eidson.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/PlatformWin.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit: Copied from TestWebKitAPI/Tests/WebKit2.
  • TestWebKitAPI/Tests/WebKit2: Removed.
  • TestWebKitAPI/Tests/WebKit2/18-characters.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Removed.
  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/Find.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKString.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/WKURL.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/autoplay-inherits-gesture-from-document.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/autoplay-zero-volume-check.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/bundle-file.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/cocoa: Removed.
  • TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/encrypted.pdf: Removed.
  • TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/execCopy.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/file-with-video.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/find.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/findRanges.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/gtk: Removed.
  • TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/icon.png: Removed.
  • TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/link-with-download-attribute-with-slashes.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/link-with-title.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/mac: Removed.
  • TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit2/mac/RestoreStateAfterTermination.mm: Removed.
  • TestWebKitAPI/Tests/WebKit2/many-iframes.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/no-autoplay-with-controls.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/push-state.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/set-long-title.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/simple-accelerated-compositing.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/simple-form.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/simple-tall.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/simple.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/simple2.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/simple3.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Removed.
  • TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Removed.
  • TestWebKitAPI/Tests/WebKit2/test.mp4: Removed.
  • TestWebKitAPI/Tests/WebKit2/test.pdf: Removed.
  • TestWebKitAPI/Tests/WebKit2/webfont.html: Removed.
5:47 PM Changeset in webkit [221217] by achristensen@apple.com
  • 2 edits
    1 move in trunk/Tools

Rename TestWebKitAPI/Tests/WebKit to WebKitLegacy following Source directory rename.

Rubber-stamped by Brady Eidson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit: Removed.
  • TestWebKitAPI/Tests/WebKit/ios: Removed.
  • TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm: Removed.
  • TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Removed.
  • TestWebKitAPI/Tests/WebKit/ios/audio-only.html: Removed.
  • TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: Removed.
  • TestWebKitAPI/Tests/WebKit/ios/video-with-audio.mp4: Removed.
  • TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Removed.
  • TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Removed.
  • TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: Removed.
  • TestWebKitAPI/Tests/WebKit/ios/video-without-audio.mp4: Removed.
  • TestWebKitAPI/Tests/WebKit/win: Removed.
  • TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Removed.
  • TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed.
  • TestWebKitAPI/Tests/WebKitLegacy: Copied from TestWebKitAPI/Tests/WebKit.
5:13 PM Changeset in webkit [221216] by achristensen@apple.com
  • 17 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's saveDataToFileInDownloadsFolder
https://bugs.webkit.org/show_bug.cgi?id=176000
<rdar://problem/29270035>

Reviewed by Andy Estes.
Source/WebKit:


Covered by a new API test.

  • Shared/Cocoa/WKNSData.h:

(wrapper): Deleted.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::saveDataToFileInDownloadsFolder):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::saveDataToFileInDownloadsFolder):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::saveDataToFileInDownloadsFolder):
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::url const):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::savePDFToFileInDownloadsFolder):

  • WebProcess/WebPage/WebPage.h:

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:

(-[FocusDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):
(-[SaveDataToFileDelegate _webView:saveDataToFile:suggestedFilename:mimeType:originatingURL:]):
(-[SaveDataToFileDelegate webView:didFinishNavigation:]):

4:59 PM Changeset in webkit [221215] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebKit

Fix -Wunused-lambda-capture warnings in WebKit with new clang compiler
<https://webkit.org/b/175911>
<rdar://problem/33667497>

Reviewed by Alex Christensen.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::retrieveCaches): Remove unused
lambda capture for 'this'.
(WebKit::CacheStorage::Engine::putRecords): Remove unused
lambda capture for 'cacheIdentifier'.

  • NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::records): Ditto.

4:58 PM Changeset in webkit [221214] by commit-queue@webkit.org
  • 4 edits in trunk

WPT server should not need to copy test harness files
https://bugs.webkit.org/show_bug.cgi?id=175938

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-25
Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

  • resources/config.json: Use aliases to load testharness.css and testharnessreport.js

Tools:

  • Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:

(WebPlatformTestServer.init): Stopping explicit resource files copy when launching the WPT server.
Use aliases instead.

4:42 PM Changeset in webkit [221213] by dbates@webkit.org
  • 16 edits in trunk/Source

Demarcate code added due to lack of NSDMI for aggregates
https://bugs.webkit.org/show_bug.cgi?id=175990

Reviewed by Andy Estes.

Source/bmalloc:

  • bmalloc/BPlatform.h:
  • bmalloc/List.h: Be explicit when initializing m_node to improve readability.

(bmalloc::ListNode::ListNode):

Source/JavaScriptCore:

  • domjit/DOMJITEffect.h:

(JSC::DOMJIT::Effect::Effect):
(JSC::DOMJIT::Effect::forWrite):
(JSC::DOMJIT::Effect::forRead):
(JSC::DOMJIT::Effect::forReadWrite):
(JSC::DOMJIT::Effect::forPure):
(JSC::DOMJIT::Effect::forDef):

  • runtime/HasOwnPropertyCache.h:

(JSC::HasOwnPropertyCache::Entry::Entry):
(JSC::HasOwnPropertyCache::Entry::operator=): Deleted.

  • wasm/WasmFormat.h: Modernize some of the code while I am here. Also

make some comments read well.
(JSC::Wasm::CallableFunction::CallableFunction):

  • wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::WebAssemblyFunction):

  • wasm/js/WebAssemblyWrapperFunction.cpp:

(JSC::WebAssemblyWrapperFunction::create):

Source/WebCore:

  • html/canvas/CanvasStyle.h:
  • platform/mediastream/IceCandidate.h:

(WebCore::IceCandidate::IceCandidate):

  • platform/text/StringWithDirection.h: Replace const String& and String&& constructor

overloads with a single user-defined constructor that takes a String by value to handle
both cases.
(WebCore::StringWithDirection::StringWithDirection):
(WebCore::truncateFromEnd):

  • style/StyleUpdate.h:

(WebCore::Style::ElementUpdate::ElementUpdate):
(WebCore::Style::TextUpdate::TextUpdate):

Source/WTF:

  • wtf/Compiler.h:
4:41 PM Changeset in webkit [221212] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

InlineTextBox::paintDocumentMarker() does not need to special case painting of grammar and
dictation alternatives
https://bugs.webkit.org/show_bug.cgi?id=175966

Reviewed by Tim Horton.

Remove code that forced computing the marker rect for grammar and dictation alternative
regardless of whether the marker spans the entire width of the line box. InlineTextBox::paintDocumentMarker()
has performance optimizations to avoid computing the marker rect if it spans the entire line box.
Prior to r190363 we had to opt out of these optimizations for grammar and dictation alternative
markers so that we could store their computed marker rect. In r190363 we removed the logic in
InlineTextBox::paintDocumentMarker() to store the computed marker rect and hence no longer
needed to opt out of the optimization for these marker types, but inadvertently left in the
conditional code that opts them out.

No functionality changed. So no new tests.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDocumentMarker): Remove unnecessary argument grammar and
code that special cased handling of grammar an dictation alternative markers.
(WebCore::InlineTextBox::paintDocumentMarkers): Update as necessary.

  • rendering/InlineTextBox.h:
4:11 PM Changeset in webkit [221211] by don.olmstead@sony.com
  • 2 edits in trunk/Source/WTF

Define *_GIGACAGE_MASK when Gigacage is not supported
https://bugs.webkit.org/show_bug.cgi?id=175994

Reviewed by Mark Lam.

  • wtf/Gigacage.h:
3:50 PM Changeset in webkit [221210] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix 32-bit after r221196

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch):

3:41 PM Changeset in webkit [221209] by Chris Dumez
  • 8 edits
    22 adds in trunk

Land stubs for File and Directory Entries API interfaces
https://bugs.webkit.org/show_bug.cgi?id=175993
<rdar://problem/34087477>

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

Add CommonIdentifiers needed for [EnabledAtRuntime].

  • runtime/CommonIdentifiers.h:

Source/WebCore:

Land stubs for File and Directory Entries API interfaces:

Those will be needed to support drag and drop.

Test: http/wpt/entries-api/interfaces.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • Modules/entriesapi/DOMFileSystem.cpp: Added.

(WebCore::DOMFileSystem::DOMFileSystem):
(WebCore::DOMFileSystem::~DOMFileSystem):

  • Modules/entriesapi/DOMFileSystem.h: Added.

(WebCore::DOMFileSystem::create):
(WebCore::DOMFileSystem::name const):
(WebCore::DOMFileSystem::root const):

  • Modules/entriesapi/DOMFileSystem.idl: Added.
  • Modules/entriesapi/ErrorCallback.h: Added.
  • Modules/entriesapi/ErrorCallback.idl: Added.
  • Modules/entriesapi/FileCallback.h: Added.
  • Modules/entriesapi/FileCallback.idl: Added.
  • Modules/entriesapi/FileSystemDirectoryEntry.cpp: Added.

(WebCore::FileSystemDirectoryEntry::FileSystemDirectoryEntry):
(WebCore::FileSystemDirectoryEntry::getFile):
(WebCore::FileSystemDirectoryEntry::getDirectory):

  • Modules/entriesapi/FileSystemDirectoryEntry.h: Added.
  • Modules/entriesapi/FileSystemDirectoryEntry.idl: Added.
  • Modules/entriesapi/FileSystemEntry.cpp: Added.

(WebCore::FileSystemEntry::FileSystemEntry):

  • Modules/entriesapi/FileSystemEntry.h: Added.

(WebCore::FileSystemEntry::~FileSystemEntry):
(WebCore::FileSystemEntry::isFile const):
(WebCore::FileSystemEntry::isDirectory const):
(WebCore::FileSystemEntry::name const):
(WebCore::FileSystemEntry::fullPath const):
(WebCore::FileSystemEntry::filesystem const):

  • Modules/entriesapi/FileSystemEntry.idl: Added.
  • Modules/entriesapi/FileSystemEntryCallback.h: Added.
  • Modules/entriesapi/FileSystemEntryCallback.idl: Added.
  • Modules/entriesapi/FileSystemFileEntry.cpp: Added.

(WebCore::FileSystemFileEntry::FileSystemFileEntry):
(WebCore::FileSystemFileEntry::file):

  • Modules/entriesapi/FileSystemFileEntry.h: Added.
  • Modules/entriesapi/FileSystemFileEntry.idl: Added.
  • WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Add layout test coverage.

  • http/wpt/entries-api/interfaces-expected.txt: Added.
  • http/wpt/entries-api/interfaces.html: Added.
3:09 PM Changeset in webkit [221208] by Brian Burg
  • 4 edits in trunk/Source

Web Automation: add capabilities to control ICE candidate filtering and insecure media capture
https://bugs.webkit.org/show_bug.cgi?id=175563
<rdar://problem/33734492>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Add macros for new capability protocol string names. Let's use a reverse
domain name notification for these capabilities so we know whether they are
intended for a particular client/port or any WebKit client, and what feature they
are related to (i.e., webrtc).

  • inspector/remote/RemoteInspectorConstants.h:

Source/WebKit:

  • UIProcess/Cocoa/AutomationClient.mm:

(WebKit::AutomationClient::requestAutomationSessionWithCapabilities):
Translate new capabilities to _WKAutomationSessionConfiguration properties.

3:05 PM Changeset in webkit [221207] by Ryan Haddad
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviewed, land TestExpectations for rdar://problem/33555052.

  • platform/ios-wk2/TestExpectations:
2:59 PM Changeset in webkit [221206] by commit-queue@webkit.org
  • 5 edits
    45 copies
    16 adds
    5 deletes in trunk/PerformanceTests

Speedometer: Restructure Ember example
https://bugs.webkit.org/show_bug.cgi?id=175926

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-25
Reviewed by Ryosuke Niwa.

This patch removes an unused stylesheet from the output, and gets rid of the unneeded intermediate source folder.

  • Speedometer/resources/tests.js: Update path to Ember benchmark.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/*: Moved to ../.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/app/index.html: Removed stylesheet reference.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/app/styles/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/dist/*: Regenerated per build instructions.
2:21 PM Changeset in webkit [221205] by rniwa@webkit.org
  • 2 edits
    1 copy in trunk/PerformanceTests

Speedometer 2.0: Duplicate the current EmberJS test as EmberJS-Debug test
https://bugs.webkit.org/show_bug.cgi?id=175956

Reviewed by Saam Barati.

Made the copy of Ember.js directory at r216946 as emberjs-debug, and added a new test suite "EmberJS-Debug-TodoMVC".

  • Speedometer/resources/tests.js:

(Suites.push.prepare):

  • Speedometer/resources/todomvc/architecture-examples/emberjs-debug: Copied from emberjs@r216946.
2:08 PM Changeset in webkit [221204] by Brian Burg
  • 11 edits
    2 copies in trunk/Source

Web Automation: use automation session configurations to propagate per-session settings
https://bugs.webkit.org/show_bug.cgi?id=175562
<rdar://problem/30853362>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Add a Cocoa-specific code path to forward capabilities when requesting
a new session from the remote inspector (i.e., automation) client.

If other ports want to use this, then we can convert Cocoa types to WebKit types later.

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspectorConstants.h:
  • inspector/remote/cocoa/RemoteInspectorCocoa.mm:

(Inspector::RemoteInspector::receivedAutomationSessionRequestMessage):

Source/WebKit:

Some WebDriver capabilities need WebKit support in order to be implemented correctly.
There is currently no easy way to forward WebDriver capability keys and values to WebKit
at session creation time. This is unfortunate, as it would be best to implement many of
them via existing mechanisms (i.e., WKPreferences properties) that need to be set up
before any windows are opened in the session.

This patch adds WebKit-side plumbing to forward named capabilities from a remote
WebDriver client to the _WKAutomationSession and its delegate in WebKit2 UIProcess.
These capabilities are exposed via API in ways that abstract away details of how the
capabilities are represented in RWI wire protocol messages.

In the Cocoa API, these capabilities are exposed via a session configuration object
that's similar to WKWebView's WKWebViewConfiguration. A session's configuration is copied
and used at initialization and cannot be modified after the session is created.
Code in the Cocoa subclass of API::AutomationClient translates between RWI protocol
capability names and property values on the _WKAutomationSessionConfiguration it
uses to request a new session.

Later patches will hook up the two properties present in the configuration in this patch.
Most of this patch is just generic plumbing without doing any capability-specific work.

  • UIProcess/API/Cocoa/_WKAutomationDelegate.h:
  • UIProcess/API/Cocoa/_WKAutomationSession.h:
  • UIProcess/API/Cocoa/_WKAutomationSession.mm:

(-[_WKAutomationSession init]):
(-[_WKAutomationSession initWithConfiguration:]):
(-[_WKAutomationSession configuration]):

  • UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKAutomationDelegate.h.
  • UIProcess/API/Cocoa/_WKAutomationSessionConfiguration.mm: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.h.

(-[_WKAutomationSessionConfiguration init]):
(-[_WKAutomationSessionConfiguration description]):

  • UIProcess/Cocoa/AutomationClient.h:
  • UIProcess/Cocoa/AutomationClient.mm:

(WebKit::AutomationClient::AutomationClient):
(WebKit::AutomationClient::requestAutomationSession):
(WebKit::AutomationClient::requestAutomationSessionWithCapabilities):

  • WebKit.xcodeproj/project.pbxproj:
1:23 PM Changeset in webkit [221203] by eric.carlson@apple.com
  • 5 edits in trunk

Add String::format variant that takes va_args
https://bugs.webkit.org/show_bug.cgi?id=175988

Reviewed by Jer Noble.

Source/WTF:

  • wtf/text/WTFString.cpp:

(WTF::createWithFormatAndArguments): Created with the guts of String::format.
(WTF::String::formatWithArguments): New, call createWithFormatAndArguments.
(WTF::String::format): Move logic to createWithFormatAndArguments, use it.

  • wtf/text/WTFString.h:

Tools:

  • TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::testWithFormatAndArguments):
(TestWebKitAPI::TEST):

1:10 PM Changeset in webkit [221202] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

REGRESSION(r221017): Quip stuck in a perpetual loading loop
https://bugs.webkit.org/show_bug.cgi?id=175991
<rdar://problem/34044445>

Reviewed by Daniel Bates.

This is a quick fix to return proper function to WebKit. I'll relate a follow-up fix that
addresses WebSockets more completely.

  • platform/network/mac/CookieJarMac.mm:

(WebCore::cookieRequestHeaderFieldValue): Don't hard code a value of 'No' for returning secure
cookies. HTTPS connection should get secure cookies.

1:09 PM Changeset in webkit [221201] by commit-queue@webkit.org
  • 12 edits
    3 adds in trunk

Add support for ReadableStream storage in FetchBody
https://bugs.webkit.org/show_bug.cgi?id=175866

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-25
Reviewed by Sam Weinig.

Source/WebCore:

Test: http/wpt/beacon/beacon-readablestream.html

Add support for IDLInterface<ReadableStream>, in particular to handle union conversions.
Adding a ReadableStream that guards JSReadableStream from being collected.
With this object, FetchBody will be able to store and manipulate ReadableStream.

Ensure conversion of BodyInit union with ReadableStream is working by adding support for beacon rejection in case of request body streams.

  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

  • Modules/beacon/NavigatorBeacon.idl:
  • Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::extract):

  • Modules/fetch/FetchBody.h:
  • Modules/fetch/FetchRequest.idl:
  • Modules/fetch/FetchRequestInit.idl:
  • Modules/fetch/FetchResponse.idl:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMConvertInterface.h:

(WebCore::JSToWrappedOverloader::toWrapped):
(WebCore::Converter<IDLInterface<T>>::convert):

  • bindings/js/JSDOMConvertUnion.h:
  • bindings/js/ReadableStream.h: Added.

(WebCore::JSReadableStreamWrapperConverter::toWrapped):

LayoutTests:

  • http/wpt/beacon/beacon-readablestream-expected.txt: Added.
  • http/wpt/beacon/beacon-readablestream.html: Added.
12:12 PM Changeset in webkit [221200] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG::JITCode::osrEntry should get sorted since we perform a binary search on it
https://bugs.webkit.org/show_bug.cgi?id=175893

Reviewed by Mark Lam.

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::finalizeOSREntrypoints):

  • dfg/DFGJITCode.h:

(JSC::DFG::JITCode::finalizeCatchOSREntrypoints): Deleted.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::linkOSREntries):

12:04 PM Changeset in webkit [221199] by wenson_hsieh@apple.com
  • 3 edits
    2 adds in trunk

Using the touchbar, both align left and align justify send a beforeinput event with the 'formatJustifyLeft' inputType.
https://bugs.webkit.org/show_bug.cgi?id=168669
<rdar://problem/30639155>

Reviewed by Beth Dakin.

Source/WebCore:

Small tweak to add a "formatJustifyFull" inputType when justifying text using the touch bar's rich text
formatting controls. Currently, the EditActionJustify edit command incorrectly maps to "formatJustifyLeft".

Test: fast/events/input-events-text-alignment.html

  • editing/EditCommand.cpp:

(WebCore::inputTypeNameForEditingAction):

LayoutTests:

Adds a new LayoutTest checking that the text alignment editor commands, "Align{Right|Center|Left|Justify}",
correctly propagate input events and beforeinput events of inputType "formatJustify{Right|Center|Left|Justify}",
and that these text alignment style changes can be prevented by calling preventDefault() on the dispatched
beforeinput event.

  • fast/events/input-events-text-alignment-expected.txt: Added.
  • fast/events/input-events-text-alignment.html: Added.
11:57 AM Changeset in webkit [221198] by beidson@apple.com
  • 19 edits
    4 copies
    2 moves
    5 adds in trunk

Introduce ServerWorkerRegistration task queues.
https://bugs.webkit.org/show_bug.cgi?id=175851

Reviewed by Andy Estes.

Source/WebCore:

Test: http/tests/workers/service/registration-task-queue-scheduling-1.html

This change introduces:

  • A task thread/queue owned by each SWServer object.
  • The SWServerRegistration object, which is the in-server representation of a service worker registration scope.
  • A registration job queue per SWServerRegistration object which actually runs the jobs as tasks on the owning SWServer's thread.

With that infrastructure in place, it moves the "register" job to something that is
scheduled and rejected asynchronously, as opposed to synchronously rejected.

The test verifies that two different registration scopes (localhost and 127.0.0.1)
can both spam the SWServer with registration requests, but neither of their queues
starve the other.

The rest of this change is a lot of support and plumbing for making the above happen.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ExceptionData.cpp:

(WebCore::ExceptionData::isolatedCopy const):

  • dom/ExceptionData.h:
  • workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::connectionIdentifier):

  • workers/service/ServiceWorkerContainer.h:
  • workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::ServiceWorkerJob):
(WebCore::ServiceWorkerJob::data const): Deleted.

  • workers/service/ServiceWorkerJob.h:

(WebCore::ServiceWorkerJob::create):
(WebCore::ServiceWorkerJob::data const):
(WebCore::ServiceWorkerJob::createRegisterJob): Deleted.

  • workers/service/ServiceWorkerJobClient.h:
  • workers/service/ServiceWorkerJobData.cpp:

(WebCore::ServiceWorkerJobData::ServiceWorkerJobData):
(WebCore::ServiceWorkerJobData::registrationKey const):
(WebCore::ServiceWorkerJobData::isolatedCopy const):

  • workers/service/ServiceWorkerJobData.h:

(WebCore::ServiceWorkerJobData::jobIdentifier const):
(WebCore::ServiceWorkerJobData::connectionIdentifier const):
(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):

  • workers/service/ServiceWorkerRegistrationKey.cpp:

(WebCore::ServiceWorkerRegistrationKey::emptyKey):
(WebCore::ServiceWorkerRegistrationKey::hash const):
(WebCore::ServiceWorkerRegistrationKey::operator== const):

  • workers/service/ServiceWorkerRegistrationKey.h:

(WTF::ServiceWorkerRegistrationKeyHash::hash):
(WTF::ServiceWorkerRegistrationKeyHash::equal):
(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::emptyValue):
(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::constructDeletedValue):
(WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::isDeletedValue):

  • workers/service/ServiceWorkerRegistrationOptions.cpp:

(WebCore::RegistrationOptions::isolatedCopy const):

  • workers/service/ServiceWorkerRegistrationOptions.h:

(WebCore::RegistrationOptions::encode const):
(WebCore::RegistrationOptions::decode):

  • workers/service/server/SWClientConnection.h:
  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::Connection):
(WebCore::SWServer::~SWServer):
(WebCore::SWServer::Connection::scheduleJobInServer):
(WebCore::SWServer::SWServer):
(WebCore::SWServer::scheduleJob):
(WebCore::SWServer::rejectJob):
(WebCore::SWServer::taskThreadEntryPoint):
(WebCore::SWServer::postTask):
(WebCore::SWServer::postTaskReply):
(WebCore::SWServer::handleTaskRepliesOnMainThread):
(WebCore::SWServer::registerConnection):
(WebCore::SWServer::unregisterConnection):

  • workers/service/server/SWServer.h:

(WebCore::SWServer::Connection::identifier const):

  • workers/service/server/SWServerRegistration.cpp: Added.

(WebCore::SWServerRegistration::SWServerRegistration):
(WebCore::SWServerRegistration::~SWServerRegistration):
(WebCore::SWServerRegistration::enqueueJob):
(WebCore::SWServerRegistration::startNextJob):
(WebCore::SWServerRegistration::performCurrentJob):
(WebCore::SWServerRegistration::rejectCurrentJob):
(WebCore::SWServerRegistration::finishCurrentJob):

  • workers/service/server/SWServerRegistration.h:

Source/WebKit:

  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::WebSWServerConnection):

  • StorageProcess/ServiceWorker/WebSWServerConnection.h:

(WebKit::WebSWServerConnection::identifier const): Deleted.

  • WebProcess/Storage/WebSWClientConnection.h:

(WebKit::WebSWClientConnection::identifier const): Deleted.

LayoutTests:

  • http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt: Added.
  • http/tests/workers/service/registration-task-queue-scheduling-1.html: Added.
  • http/tests/workers/service/resources/registration-task-queue-scheduling-1-second-window.html: Added.
  • http/tests/workers/service/resources/registration-task-queue-scheduling-1.js: Added.
11:54 AM Changeset in webkit [221197] by Jonathan Bedard
  • 2 edits in trunk/Tools

Follow-up Internal build fix for r221187
https://bugs.webkit.org/show_bug.cgi?id=175960
<rdar://problem/34069264>

Unreviewed build fix.

  • TestWebKitAPI/ios/DataInteractionSimulator.h: Move UIItemProvider declaration

into #if block.

11:26 AM Changeset in webkit [221196] by sbarati@apple.com
  • 84 edits
    6 adds in trunk

Support compiling catch in the DFG
https://bugs.webkit.org/show_bug.cgi?id=174590
<rdar://problem/34047845>

Reviewed by Filip Pizlo.

JSTests:

  • microbenchmarks/delta-blue-try-catch.js: Added.

(exception):
(value):
(OrderedCollection):
(OrderedCollection.prototype.add):
(OrderedCollection.prototype.at):
(OrderedCollection.prototype.size):
(OrderedCollection.prototype.removeFirst):
(OrderedCollection.prototype.remove):
(Strength):
(Strength.stronger):
(Strength.weaker):
(Strength.weakestOf):
(Strength.strongest):
(Strength.prototype.nextWeaker):
(Constraint):
(Constraint.prototype.addConstraint):
(Constraint.prototype.satisfy):
(Constraint.prototype.destroyConstraint):
(Constraint.prototype.isInput):
(UnaryConstraint):
(UnaryConstraint.prototype.addToGraph):
(UnaryConstraint.prototype.chooseMethod):
(UnaryConstraint.prototype.isSatisfied):
(UnaryConstraint.prototype.markInputs):
(UnaryConstraint.prototype.output):
(UnaryConstraint.prototype.recalculate):
(UnaryConstraint.prototype.markUnsatisfied):
(UnaryConstraint.prototype.inputsKnown):
(UnaryConstraint.prototype.removeFromGraph):
(StayConstraint):
(StayConstraint.prototype.execute):
(EditConstraint.prototype.isInput):
(EditConstraint.prototype.execute):
(BinaryConstraint):
(BinaryConstraint.prototype.chooseMethod):
(BinaryConstraint.prototype.addToGraph):
(BinaryConstraint.prototype.isSatisfied):
(BinaryConstraint.prototype.markInputs):
(BinaryConstraint.prototype.input):
(BinaryConstraint.prototype.output):
(BinaryConstraint.prototype.recalculate):
(BinaryConstraint.prototype.markUnsatisfied):
(BinaryConstraint.prototype.inputsKnown):
(BinaryConstraint.prototype.removeFromGraph):
(ScaleConstraint):
(ScaleConstraint.prototype.addToGraph):
(ScaleConstraint.prototype.removeFromGraph):
(ScaleConstraint.prototype.markInputs):
(ScaleConstraint.prototype.execute):
(ScaleConstraint.prototype.recalculate):
(EqualityConstraint):
(EqualityConstraint.prototype.execute):
(Variable):
(Variable.prototype.addConstraint):
(Variable.prototype.removeConstraint):
(Planner):
(Planner.prototype.incrementalAdd):
(Planner.prototype.incrementalRemove):
(Planner.prototype.newMark):
(Planner.prototype.makePlan):
(Planner.prototype.extractPlanFromConstraints):
(Planner.prototype.addPropagate):
(Planner.prototype.removePropagateFrom):
(Planner.prototype.addConstraintsConsumingTo):
(Plan):
(Plan.prototype.addConstraint):
(Plan.prototype.size):
(Plan.prototype.constraintAt):
(Plan.prototype.execute):
(chainTest):
(projectionTest):
(change):
(deltaBlue):

  • microbenchmarks/fake-iterators-that-throw-when-finished.js: Added.

(assert):
(Numbers):
(Numbers.prototype.next):
(return.Transpose):
(return.Transpose.prototype.next):
(transpose):
(verifyEven):
(verifyString):
(foo):
(runIterators):

  • microbenchmarks/try-catch-word-count.js: Added.

(let.assert):
(EOF):
(let.texts):
(let.o.apply):
(foo):
(bar):
(f):
(run):
(test1):
(test2):
(test3):
(fn):
(A):
(B):
(A.prototype.getValue):
(B.prototype.getParentValue):
(strlen):
(sum.0):
(test):
(result.test.o):
(set add.set add):
(set forEach):
(stringHash):
(set if):
(testFunction):
(set delete.set has.set add):

  • stress/catch-set-argument-speculation-failure.js: Added.

(o):
(e):
(e2):
(escape):
(baz):
(noInline.run):
(noInline):

  • stress/osr-enter-to-catch-with-set-local-type-check-failure.js: Added.

(foo):
(e):
(baz):
(bar):

Source/JavaScriptCore:

This patch implements OSR entry into op_catch in the DFG. We will support OSR entry
into the FTL in a followup: https://bugs.webkit.org/show_bug.cgi?id=175396

To implement catch in the DFG, this patch introduces the concept of multiple
entrypoints into CPS/LoadStore DFG IR. A lot of this patch is stringing this concept
through the DFG. Many phases used to assume that Graph::block(0) is the only root, and this
patch contains many straight forward changes generalizing the code to handle more than
one entrypoint.

A main building block of this is moving to two CFG types: SSACFG and CPSCFG. SSACFG
is the same CFG we used to have. CPSCFG is a new type that introduces a fake root
that has an outgoing edge to all the entrypoints. This allows our existing graph algorithms
to Just Work over CPSCFG. For example, there is now the concept of SSADominators vs CPSDominators,
and SSANaturalLoops vs CPSNaturalLoops.

The way we compile the catch entrypoint is by bootstrapping the state
of the program by loading all live bytecode locals from a buffer. The OSR
entry code will store all live values into that buffer before jumping to
the entrypoint. The OSR entry code is also responsible for performing type
proofs of the arguments before doing an OSR entry. If there is a type
mismatch, it's not legal to OSR enter into the DFG compilation. Currently,
each catch entrypoint knows the argument type proofs it must perform to enter
into the DFG. Currently, all entrypoints' arguments flush format are unified
via ArgumentPosition, but this is just an implementation detail. The code is
written more generally to assume that each entrypoint may perform its own distinct
proof.

op_catch now performs value profiling for all live bytecode locals in the
LLInt and baseline JIT. This information is then fed into the DFG via the
ExtractCatchLocal node in the prediction propagation phase.

This patch also changes how we generate op_catch in bytecode. All op_catches
are now split out at the end of the program in bytecode. This ensures that
no op_catch is inside a try block. This is needed to ensure correctness in
the DFGLiveCatchVariablePreservationPhase. That phase only inserts flushes
before SetLocals inside a try block. If an op_catch were in a try block, this
would cause the phase to insert a Flush before one of the state bootstrapping
SetLocals, which would generate invalid IR. Moving op_catch to be generated on
its own at the end of a bytecode stream seemed like the most elegant solution since
it better represents that we treat op_catch as an entrypoint. This is true
both in the DFG and in the baseline and LLInt: we don't reach an op_catch
via normal control flow. Because op_catch cannot throw, this will not break
any previous semantics of op_catch. Logically, it'd be valid to split try
blocks around any non-throwing bytecode operation.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::dumpBytecode):

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::ensureCatchLivenessIsComputedForBytecodeOffset):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::validate):

  • bytecode/CodeBlock.h:
  • bytecode/ValueProfile.h:

(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfileAndOperandBuffer::ValueProfileAndOperandBuffer):
(JSC::ValueProfileAndOperandBuffer::~ValueProfileAndOperandBuffer):
(JSC::ValueProfileAndOperandBuffer::forEach):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::emitEnumeration):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::TryNode::emitBytecode):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGBackwardsCFG.h:

(JSC::DFG::BackwardsCFG::BackwardsCFG):

  • dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::BasicBlock):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::findTerminal const):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::DelayedSetLocal::DelayedSetLocal):
(JSC::DFG::ByteCodeParser::DelayedSetLocal::execute):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCFG.h:

(JSC::DFG::CFG::root):
(JSC::DFG::CFG::roots):
(JSC::DFG::CPSCFG::CPSCFG):
(JSC::DFG::selectCFG):

  • dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::specialCaseArguments):

  • dfg/DFGCSEPhase.cpp:
  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGControlEquivalenceAnalysis.h:

(JSC::DFG::ControlEquivalenceAnalysis::ControlEquivalenceAnalysis):

  • dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::run):

  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::createDumpList):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGDominators.h:

(JSC::DFG::Dominators::Dominators):
(JSC::DFG::ensureDominatorsForCFG):

  • dfg/DFGEdgeDominates.h:

(JSC::DFG::EdgeDominates::EdgeDominates):
(JSC::DFG::EdgeDominates::operator()):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupChecksInBlock):

  • dfg/DFGFlushFormat.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::unboxLoopNode):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::invalidateCFG):
(JSC::DFG::Graph::blocksInPreOrder):
(JSC::DFG::Graph::blocksInPostOrder):
(JSC::DFG::Graph::ensureCPSDominators):
(JSC::DFG::Graph::ensureSSADominators):
(JSC::DFG::Graph::ensureCPSNaturalLoops):
(JSC::DFG::Graph::ensureSSANaturalLoops):
(JSC::DFG::Graph::ensureBackwardsCFG):
(JSC::DFG::Graph::ensureBackwardsDominators):
(JSC::DFG::Graph::ensureControlEquivalenceAnalysis):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
(JSC::DFG::Graph::clearCPSCFGData):
(JSC::DFG::Graph::ensureDominators): Deleted.
(JSC::DFG::Graph::ensurePrePostNumbering): Deleted.
(JSC::DFG::Graph::ensureNaturalLoops): Deleted.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::willCatchExceptionInMachineFrame):
(JSC::DFG::Graph::isEntrypoint const):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::shrinkToFit):

  • dfg/DFGJITCode.h:

(JSC::DFG::JITCode::catchOSREntryDataForBytecodeIndex):
(JSC::DFG::JITCode::finalizeCatchOSREntrypoints):
(JSC::DFG::JITCode::appendCatchEntrypoint):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::noticeCatchEntrypoint):
(JSC::DFG::JITCompiler::noticeOSREntry):
(JSC::DFG::JITCompiler::makeCatchOSREntryBuffer):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::run):
(JSC::DFG::LICMPhase::attemptHoist):

  • dfg/DFGLiveCatchVariablePreservationPhase.cpp:

(JSC::DFG::LiveCatchVariablePreservationPhase::run):
(JSC::DFG::LiveCatchVariablePreservationPhase::isValidFlushLocation):
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlockForTryCatch):
(JSC::DFG::LiveCatchVariablePreservationPhase::newVariableAccessData):
(JSC::DFG::LiveCatchVariablePreservationPhase::willCatchException): Deleted.
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlock): Deleted.

  • dfg/DFGLoopPreHeaderCreationPhase.cpp:

(JSC::DFG::createPreHeader):
(JSC::DFG::LoopPreHeaderCreationPhase::run):

  • dfg/DFGMaximalFlushInsertionPhase.cpp:

(JSC::DFG::MaximalFlushInsertionPhase::run):
(JSC::DFG::MaximalFlushInsertionPhase::treatRegularBlock):
(JSC::DFG::MaximalFlushInsertionPhase::treatRootBlock):

  • dfg/DFGMayExit.cpp:
  • dfg/DFGNaturalLoops.h:

(JSC::DFG::NaturalLoops::NaturalLoops):

  • dfg/DFGNode.h:

(JSC::DFG::Node::isSwitch const):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::catchOSREntryIndex const):
(JSC::DFG::Node::catchLocalPrediction):
(JSC::DFG::Node::isSwitch): Deleted.

  • dfg/DFGNodeType.h:
  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareCatchOSREntry):

  • dfg/DFGOSREntry.h:
  • dfg/DFGOSREntrypointCreationPhase.cpp:

(JSC::DFG::OSREntrypointCreationPhase::run):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::handleExitCounts):

  • dfg/DFGObjectAllocationSinkingPhase.cpp:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPrePostNumbering.cpp:

(JSC::DFG::PrePostNumbering::PrePostNumbering): Deleted.
(JSC::DFG::PrePostNumbering::~PrePostNumbering): Deleted.
(WTF::printInternal): Deleted.

  • dfg/DFGPrePostNumbering.h:

(): Deleted.
(JSC::DFG::PrePostNumbering::preNumber const): Deleted.
(JSC::DFG::PrePostNumbering::postNumber const): Deleted.
(JSC::DFG::PrePostNumbering::isStrictAncestorOf const): Deleted.
(JSC::DFG::PrePostNumbering::isAncestorOf const): Deleted.
(JSC::DFG::PrePostNumbering::isStrictDescendantOf const): Deleted.
(JSC::DFG::PrePostNumbering::isDescendantOf const): Deleted.
(JSC::DFG::PrePostNumbering::edgeKind const): Deleted.

  • dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGPutStackSinkingPhase.cpp:
  • dfg/DFGSSACalculator.cpp:

(JSC::DFG::SSACalculator::nonLocalReachingDef):
(JSC::DFG::SSACalculator::reachingDefAtTail):

  • dfg/DFGSSACalculator.h:

(JSC::DFG::SSACalculator::computePhis):

  • dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):
(JSC::DFG::performSSAConversion):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::linkOSREntries):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStaticExecutionCountEstimationPhase.cpp:

(JSC::DFG::StaticExecutionCountEstimationPhase::run):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

  • dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run):
(JSC::DFG::TierUpCheckInjectionPhase::buildNaturalLoopToLoopHintMap):

  • dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):

  • dfg/DFGValidate.cpp:
  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):
(JSC::FTL::DFG::LowerDFGToB3::safelyInvalidateAfterTermination):
(JSC::FTL::DFG::LowerDFGToB3::isValid):

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:

Source/WTF:

This patch generalizes the BackwardsGraph fake root into a more generalizable
class called SingleRootGraph. SingleRootGraph exposes the general graph interface
used in Dominators and NaturalLoops. SingleRootGraph takes as input a graph with
the normal graph interface, but also allows the input graph to contain more than
one root. SingleRootGraph then exposes a single root, which it creates, that has
an outgoing edge to all the roots in the original graph.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/BackwardsGraph.h:

(WTF::BackwardsGraph::dump const):
(WTF::BackwardsGraph::rootName): Deleted.
(WTF::BackwardsGraph::Node::Node): Deleted.
(WTF::BackwardsGraph::Node::root): Deleted.
(WTF::BackwardsGraph::Node::operator== const): Deleted.
(WTF::BackwardsGraph::Node::operator!= const): Deleted.
(WTF::BackwardsGraph::Node::operator bool const): Deleted.
(WTF::BackwardsGraph::Node::isRoot const): Deleted.
(WTF::BackwardsGraph::Node::node const): Deleted.
(): Deleted.
(WTF::BackwardsGraph::Set::Set): Deleted.
(WTF::BackwardsGraph::Set::add): Deleted.
(WTF::BackwardsGraph::Set::remove): Deleted.
(WTF::BackwardsGraph::Set::contains): Deleted.
(WTF::BackwardsGraph::Set::dump const): Deleted.
(WTF::BackwardsGraph::Map::Map): Deleted.
(WTF::BackwardsGraph::Map::clear): Deleted.
(WTF::BackwardsGraph::Map::size const): Deleted.
(WTF::BackwardsGraph::Map::operator[]): Deleted.
(WTF::BackwardsGraph::Map::operator[] const): Deleted.

  • wtf/Dominators.h:

(WTF::Dominators::Dominators):
(WTF::Dominators::forAllBlocksInIteratedDominanceFrontierOf):
(WTF::Dominators::forAllBlocksInPrunedIteratedDominanceFrontierOf):
(WTF::Dominators::iteratedDominanceFrontierOf const):
(WTF::Dominators::forAllBlocksInIteratedDominanceFrontierOfImpl const):

  • wtf/SingleRootGraph.h: Added.

(WTF::SingleRootGraphNode::rootName):
(WTF::SingleRootGraphNode::SingleRootGraphNode):
(WTF::SingleRootGraphNode::root):
(WTF::SingleRootGraphNode::operator== const):
(WTF::SingleRootGraphNode::operator!= const):
(WTF::SingleRootGraphNode::operator bool const):
(WTF::SingleRootGraphNode::isRoot const):
(WTF::SingleRootGraphNode::node const):
(WTF::SingleRootGraphSet::add):
(WTF::SingleRootGraphSet::remove):
(WTF::SingleRootGraphSet::contains):
(WTF::SingleRootGraphSet::dump const):
(WTF::SingleRootMap::SingleRootMap):
(WTF::SingleRootMap::clear):
(WTF::SingleRootMap::size const):
(WTF::SingleRootMap::operator[]):
(WTF::SingleRootMap::operator[] const):
(WTF::SingleRootGraph::SingleRootGraph):
(WTF::SingleRootGraph::root const):
(WTF::SingleRootGraph::newMap):
(WTF::SingleRootGraph::successors const):
(WTF::SingleRootGraph::predecessors const):
(WTF::SingleRootGraph::index const):
(WTF::SingleRootGraph::node const):
(WTF::SingleRootGraph::numNodes const):
(WTF::SingleRootGraph::dump const):
(WTF::SingleRootGraph::assertIsConsistent const):

11:04 AM Changeset in webkit [221195] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Unreviewed, add comment warning that some flags have been copied into Epiphany

  • platform/URLParser.cpp:

(WebCore::URLParser::internationalDomainNameTranscoder):

10:31 AM Changeset in webkit [221194] by Jonathan Bedard
  • 2 edits in trunk/LayoutTests

Add flag allow-modals to iframe sandbox
https://bugs.webkit.org/show_bug.cgi?id=171321

Patch by Frederic Wang <fwang@igalia.com> on 2017-07-25
Reviewed by Brent Fulgham.

The allow-modals flag is added to tests trying to open modal dialogs in sandboxed frames, now
that the default behavior has changed. New tests are also added to verify that the dialogs
are allowed or blocked according to the value of the allow-modals flag.

  • fast/events/popup-blocked-from-sandboxed-frame-via-window-open-named-sibling-frame.html: Add allow-modals.
  • fast/events/popup-blocked-from-sandboxed-frame-via-window-open-named-sibling-frame2.html: Ditto.
  • fast/forms/autofocus-in-sandbox-with-allow-scripts.html: Ditto.
  • fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html: Ditto.
  • fast/frames/sandboxed-iframe-parsing-space-characters.html: Ditto.
  • fast/frames/sandboxed-iframe-scripting-02.html: Ditto.
  • http/tests/security/contentSecurityPolicy/resources/sandboxed-eval.php: Ditto.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control.html: Ditto.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header.html: Ditto.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header2.php: Ditto.
  • http/tests/security/drag-drop-same-unique-origin.html: Ditto.
  • http/tests/security/no-indexeddb-from-sandbox.html: Ditto.
  • http/tests/security/no-popup-from-sandbox-top.html: Ditto.
  • http/tests/security/no-popup-from-sandbox.html: Ditto.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Ditto.
  • http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Ditto.
  • http/tests/security/xss-DENIED-window-name-alert.html: Ditto.
  • http/tests/security/sandboxed-iframe-ALLOWED-modals.html: Added. Verify that alert,

confirm, prompt and print dialogs are allowed when the allow-modals flag is set.

  • http/tests/security/sandboxed-iframe-ALLOWED-modals-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-DENIED-modals.html: Added. Verify that alert,

confirm, prompt and print dialogs are denied when the allow-modals flag not set. The returned
values are also verified.

  • http/tests/security/sandboxed-iframe-DENIED-modals-expected.txt: Added.
  • http/tests/misc/iframe-beforeunload-dialog-allow-modals.html: Added. Verify that the

confirm dialog for beforeunload is displayed when allow-modals is set.

  • http/tests/misc/iframe-beforeunload-dialog-allow-modals-expected.txt: Added.
  • http/tests/misc/iframe-beforeunload-dialog-block-modals.html: Added. Verify that the

confirm dialog for beforeunload is not displayed when allow-modals is unset.

  • http/tests/misc/iframe-beforeunload-dialog-block-modals-expected.txt: Added.
10:28 AM Changeset in webkit [221193] by fred.wang@free.fr
  • 26 edits
    8 adds in trunk

Add flag allow-modals to iframe sandbox
https://bugs.webkit.org/show_bug.cgi?id=171321

Source/WebCore:

This patch implements the "allow-modals" value for the iframe sandbox attribute. It changes
the behavior for sandboxed document so that alert, confirm, prompt, print as well as dialogs
generated from a beforeunload event are blocked when allow-modals is not set, as defined in
the specification. For consistency, we do the same for document.execCommand('print', ...).
Users should use the allow-modals flag in order to explictly allow modal dialogs.

See https://html.spec.whatwg.org/multipage/origin.html#sandboxed-modals-flag

Patch by Frederic Wang <fwang@igalia.com> on 2017-07-25
Reviewed by Brent Fulgham.

Tests: http/tests/security/sandboxed-iframe-ALLOWED-modals.html

http/tests/security/sandboxed-iframe-DENIED-modals.html

  • dom/SecurityContext.cpp: Implement parsing for allow-modals

(WebCore::SecurityContext::isSupportedSandboxPolicy):
(WebCore::SecurityContext::parseSandboxPolicy):

  • dom/SecurityContext.h: Introduce flag for allow-modals
  • loader/FrameLoader.cpp:

(WebCore::shouldAskForNavigationConfirmation): Prevent confirm dialog from beforeunload when
allow-modals is not set.

  • page/Chrome.h: Change the signature of print, so it may return a failure when the

allow-modals flag is not set.

  • page/Chrome.cpp:

(WebCore::Chrome::print): Returns false and print a message error when the allow-modals flag
on the frame's document is not set. Otherwise, execute the command and returns true.

  • editing/EditorCommand.cpp:

(WebCore::executePrint): Ensure that document.execCommand for 'print' returns false when the
allow-modals flag is not set.

  • page/DOMWindow.cpp: Add early exit when alert, confirm or prompt when the allow-modals flag

for that document is not set. Note that print is handled in Chrome.cpp.
(WebCore::DOMWindow::alert): Add early exit.
(WebCore::DOMWindow::confirm): Add early exit with the return value indicated in the spec.
(WebCore::DOMWindow::prompt): Ditto.

LayoutTests:

Patch by Frederic Wang <fwang@igalia.com> on 2017-07-25
Reviewed by Brent Fulgham.

The allow-modals flag is added to tests trying to open modal dialogs in sandboxed frames, now
that the default behavior has changed. New tests are also added to verify that the dialogs
are allowed or blocked according to the value of the allow-modals flag.

  • fast/events/popup-blocked-from-sandboxed-frame-via-window-open-named-sibling-frame.html: Add allow-modals.
  • fast/events/popup-blocked-from-sandboxed-frame-via-window-open-named-sibling-frame2.html: Ditto.
  • fast/forms/autofocus-in-sandbox-with-allow-scripts.html: Ditto.
  • fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html: Ditto.
  • fast/frames/sandboxed-iframe-parsing-space-characters.html: Ditto.
  • fast/frames/sandboxed-iframe-scripting-02.html: Ditto.
  • http/tests/security/contentSecurityPolicy/resources/sandboxed-eval.php: Ditto.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control.html: Ditto.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header.html: Ditto.
  • http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header2.php: Ditto.
  • http/tests/security/drag-drop-same-unique-origin.html: Ditto.
  • http/tests/security/no-indexeddb-from-sandbox.html: Ditto.
  • http/tests/security/no-popup-from-sandbox-top.html: Ditto.
  • http/tests/security/no-popup-from-sandbox.html: Ditto.
  • http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Ditto.
  • http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Ditto.
  • http/tests/security/xss-DENIED-window-name-alert.html: Ditto.
  • http/tests/security/sandboxed-iframe-ALLOWED-modals.html: Added. Verify that alert,

confirm, prompt and print dialogs are allowed when the allow-modals flag is set.

  • http/tests/security/sandboxed-iframe-ALLOWED-modals-expected.txt: Added.
  • http/tests/security/sandboxed-iframe-DENIED-modals.html: Added. Verify that alert,

confirm, prompt and print dialogs are denied when the allow-modals flag not set. The returned
values are also verified.

  • http/tests/security/sandboxed-iframe-DENIED-modals-expected.txt: Added.
  • http/tests/misc/iframe-beforeunload-dialog-allow-modals.html: Added. Verify that the

confirm dialog for beforeunload is displayed when allow-modals is set.

  • http/tests/misc/iframe-beforeunload-dialog-allow-modals-expected.txt: Added.
  • http/tests/misc/iframe-beforeunload-dialog-block-modals.html: Added. Verify that the

confirm dialog for beforeunload is not displayed when allow-modals is unset.

  • http/tests/misc/iframe-beforeunload-dialog-block-modals-expected.txt: Added.
10:27 AM Changeset in webkit [221192] by keith_miller@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Explore increasing max JSString::m_length to UINT_MAX.
https://bugs.webkit.org/show_bug.cgi?id=163955
<rdar://problem/32001499>

Reviewed by JF Bastien.

This can cause us to release assert on some code paths. I don't
see a reason to maintain this restriction.

  • runtime/JSString.h:

(JSC::JSString::length const):
(JSC::JSString::setLength):
(JSC::JSString::isValidLength): Deleted.

  • runtime/JSStringBuilder.h:

(JSC::jsMakeNontrivialString):

10:23 AM Changeset in webkit [221191] by don.olmstead@sony.com
  • 3 edits
    1 move in trunk/Tools

[WinCairo] Use GitHub releases for WinCairoRequirements
https://bugs.webkit.org/show_bug.cgi?id=175972

Reviewed by Brent Fulgham.

  • Scripts/build-webkit:

(cMakeArgsFromFeatures): Deleted.
(writeCongrats): Deleted.

  • Scripts/download-latest-github-release.py:

(Status):
(parse_args):
(main):

  • Scripts/update-webkit-wincairo-libs.py: Renamed from Tools/Scripts/update-webkit-wincairo-libs.
10:01 AM Changeset in webkit [221190] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[Cache API] UIProcess should provide the directory path where to store Cache Storage data
https://bugs.webkit.org/show_bug.cgi?id=175884
<rdar://problem/34072441>

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-25

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::ProcessPoolConfiguration): Fixing typo.

9:52 AM Changeset in webkit [221189] by beidson@apple.com
  • 19 edits in trunk/Source/WebCore

Unreviewed, rolling out r221181.

Broke builds that use CryptoAlgorithmRSA_PSSMac.cpp

Reverted changeset:

"[WebCrypto] Push WorkQueue dispatches for RSA algorithms into
shared code"
https://bugs.webkit.org/show_bug.cgi?id=175621
http://trac.webkit.org/changeset/221181

9:23 AM Changeset in webkit [221188] by Jonathan Bedard
  • 2 edits in trunk/LayoutTests

Manage tests which require different device types better
<https://bugs.webkit.org/show_bug.cgi?id=175987>
<rdar://problem/34082632>

Unreviewed test gardening.

  • platform/ios-device/TestExpectations: Skip tests requiring a device type.
8:27 AM Changeset in webkit [221187] by Jonathan Bedard
  • 6 edits in trunk

Fix build breakage with Public iOS 11 SDK
https://bugs.webkit.org/show_bug.cgi?id=175960
<rdar://problem/34069264>

Reviewed by Wenson Hsieh.

Source/WebCore/PAL:

  • pal/spi/ios/UIKitSPI.h: Use NSItemProvider definition of preferredPresentationSize

instead of re-declaring it.

Source/WebKit:

  • Platform/spi/ios/UIKitSPI.h: Add UIURLDragPreviewView declaration.

Tools:

  • TestWebKitAPI/ios/DataInteractionSimulator.h: Add UIItemProvider declaration.
7:46 AM Changeset in webkit [221186] by commit-queue@webkit.org
  • 7 edits
    1 copy
    1 add
    1 delete in trunk/LayoutTests

Import track-element/cloneNode.html from web-platform-tests.
https://bugs.webkit.org/show_bug.cgi?id=175984

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-25
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/cloneNode-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/cloneNode.html: Renamed from LayoutTests/media/track/opera/track/track-element/cloneNode.html.
  • web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/w3c-import.log:

LayoutTests:

We already had an older copy in LayoutTests/media/track/opera/track/;
remove that in favour of the new and maintained copy.

  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
5:10 AM Changeset in webkit [221185] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

Mark bunch of disk cache tests non-flaky on release
https://bugs.webkit.org/show_bug.cgi?id=175982

Unreviewed.

According to https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcache%2Fdisk-cache
these are no longer flaky on release (after somewhat recent fixes).

Only mark them flaky on debug builds.

  • platform/mac-wk2/TestExpectations:
  • platform/wk2/TestExpectations:
3:59 AM Changeset in webkit [221184] by calvaris@igalia.com
  • 2 edits in trunk/Source/WebCore

[EME][ClearKey] Fixed warning in CDM compilation
https://bugs.webkit.org/show_bug.cgi?id=175979

Reviewed by Žan Doberšek.

  • platform/encryptedmedia/clearkey/CDMClearKey.h: Added a final to

avoid the compiler warning about the missing override keyword.

1:20 AM WebKitGTK/2.18.x edited by magomez@igalia.com
(diff)
1:10 AM Changeset in webkit [221183] by magomez@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] Completely garbled display in Transifex in accelerated compositing mode
https://bugs.webkit.org/show_bug.cgi?id=174632

Reviewed by Michael Catanzaro.

Remove the copy constructor from PlatformContextCairo::State. This is because it will be used by WTF::Vector
to copy the instances around when allocating new memory, but it doesn't copy the m_imageMaskInformation
attribute, so it will be lost when the Vector reallocates its contents. When this happens, renderings that use
GraphicsContext::clipToImageBuffer() fail to render properly.

Covered by existent tests.

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::State::State):
(WebCore::PlatformContextCairo::save):

12:50 AM Changeset in webkit [221182] by calvaris@igalia.com
  • 6 edits in trunk/Source/WebCore

[EME][GStreamer] Move createDescryptor function to GStreamerEMEUtilities
https://bugs.webkit.org/show_bug.cgi?id=175930

Reviewed by Žan Doberšek.

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::createGstDecryptor): Deleted.

  • platform/graphics/gstreamer/GStreamerUtilities.h:
  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp:

(WebCore::GStreamerEMEUtilities::createDecryptor): Created.

  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:
  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::parseDemuxerSrcPadCaps): Use
GStreamerEMEUtilities::createDecryptor instead.

12:20 AM Changeset in webkit [221181] by zandobersek@gmail.com
  • 19 edits in trunk/Source/WebCore

[WebCrypto] Push WorkQueue dispatches for RSA algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175621

Reviewed by Darin Adler.

Push the WorkQueue dispatch code and other code duplicated between the
Mac and libgcrypt implementations of Web Crypto into the shared layer.
This patch focuses on the RSA-based algorithms.

The WorkQueue dispatch code is condensed into two static functions on
the CryptoAlgorithm class, the first variation handling VectorCallback
as the callback type and the other handling BoolCallback. The operation
is kept in a WTF::Function<> object that returns an ExceptionOr<> value
embedding either a Vector<uint8_t> object or a boolean value, as
appropriate for the callback type.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr
value. CryptoAlgorithmParameters objects are passed through non-const
references because data getters could lazily construct the underlying
Vector objects. CryptoKey objects are passed through const references.
Implementations can then manually retrieve and further validate any key
or parameter data, as required for that specific implementation. Input
data is passed through const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

  • crypto/CryptoAlgorithm.cpp:

(WebCore::dispatchOperationImpl):
(WebCore::CryptoAlgorithm::dispatchOperation):

  • crypto/CryptoAlgorithm.h:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):

  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::encrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::decrypt):

  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
  • crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::sign):
(WebCore::CryptoAlgorithmRSA_PSS::verify):

  • crypto/algorithms/CryptoAlgorithmRSA_PSS.h:
  • crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:

(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

  • crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

  • crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

Aug 24, 2017:

10:24 PM Changeset in webkit [221180] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+ for 2.18
https://bugs.webkit.org/show_bug.cgi?id=175720

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2017-08-24
Rubber-stamped by Michael Catanzaro.

  • pl.po:
9:24 PM Changeset in webkit [221179] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, add File and Directory Entries API to status page.

  • features.json:
9:15 PM Changeset in webkit [221178] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, update status of Beacon API.

It is now supported in Safari Technology Preview.

  • features.json:
7:05 PM Changeset in webkit [221177] by Chris Dumez
  • 39 edits
    1 copy
    17 adds in trunk

[Directory Upload] Add basic support for input.webkitdirectory
https://bugs.webkit.org/show_bug.cgi?id=175950
<rdar://problem/33951915>

Reviewed by Geoffrey Garen.

Source/WebCore:

Add basic support for input.webkitdirectory attribute, as per:

The following is supported:

  • input.webkitdirectory IDL and content attributes
  • The webkitdirectory content attribute is properly consulted to communicate to the client that the file picker should allow selecting directories.
  • When WebCore gets the list of selected files from the file picker, it properly resolves folders in a background thread to properly initialize input.files before firing the 'change' event at the input element.
  • When resolving files in a directory, we ignore both hidden files and symbolic links for security reasons. I did not check symlinks but Firefox and Chrome both seem to upload hidden files (such as .DS_Store files).
  • File.webkitRelativePath IDL attribute is properly populated for files coming from a selected directory.
  • Form submission just works because it relies on input.files being properly populated. No change needed in this area.

What is not supported:

  • input.webkitEntries IDL attribute.
  • FileSystemEntry / FileSystemDirectoryEntry / FileSystemDirectoryReader / FileSystemFileEntry / FileSystem IDL interfaces.
  • dataTransferItem.webkitGetAsEntry() for proper drag and drop support.

Those will be taken care of in follow-up patches.

The feature is currently behind an experimental feature flag, disabled by
default.

Tests: fast/forms/file/webkitdirectory-drag-folder.html

fast/forms/file/webkitdirectory-open-panel.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/File.cpp:

(WebCore::File::createWithRelativePath):

  • fileapi/File.h:
  • fileapi/File.idl:
  • html/FileInputType.cpp:

(WebCore::FileInputType::~FileInputType):
(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::allowsDirectories const):
(WebCore::FileInputType::filesChosen):

  • html/FileInputType.h:
  • html/FileListCreator.cpp: Added.

(WebCore::appendDirectoryFiles):
(WebCore::FileListCreator::FileListCreator):
(WebCore::FileListCreator::createFileList):
(WebCore::FileListCreator::cancel):

  • html/FileListCreator.h: Copied from Source/WebKit/UIProcess/API/APIOpenPanelParameters.h.

(WebCore::FileListCreator::create):

  • html/HTMLAttributeNames.in:
  • html/HTMLInputElement.idl:
  • page/Settings.in:
  • platform/FileChooser.h:

(WebCore::FileChooserFileInfo::isolatedCopy const):

  • platform/FileMetadata.h:
  • platform/FileSystem.cpp:

(WebCore::fileIsDirectory):

  • platform/FileSystem.h:
  • platform/glib/FileSystemGlib.cpp:

(WebCore::getFileMetadata):

  • platform/posix/FileSystemPOSIX.cpp:

(WebCore::getFileMetadata):

  • platform/win/FileSystemWin.cpp:

(WebCore::getFileMetadata):

Source/WebKit:

Add private API to toggle Directory Upload support.

Add new member to WKOpenPanelParameters to communicate to the
client that the file picker should allow selecting directories.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<FileChooserSettings>::encode):
(IPC::ArgumentCoder<FileChooserSettings>::decode):

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/APIOpenPanelParameters.h:

(API::OpenPanelParameters::allowDirectories const):

  • UIProcess/API/C/WKOpenPanelParametersRef.cpp:

(WKOpenPanelParametersGetAllowsDirectories):

  • UIProcess/API/C/WKOpenPanelParametersRef.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDirectoryUploadEnabled):
(WKPreferencesGetDirectoryUploadEnabled):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • UIProcess/API/Cocoa/WKOpenPanelParameters.h:
  • UIProcess/API/Cocoa/WKOpenPanelParameters.mm:

(-[WKOpenPanelParameters allowsDirectories]):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

Add private API to toggle Directory Upload support on Mac WebKit1.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences setDirectoryUploadEnabled:]):
(-[WebPreferences directoryUploadEnabled]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
Enable Directory Upload feature for testing, given that it is currently disabled by default.

(WTR::runOpenPanel):
Print additional text when directories are allowed to extend testing coverage.

LayoutTests:

Add layout test coverage for input.webkitdirectory. It covers both
the file picker and the drag and drop code paths.

  • fast/forms/file/resources/testFiles/file1.txt: Added.
  • fast/forms/file/resources/testFiles/file2.txt: Added.
  • fast/forms/file/resources/testFiles/subfolder1/file3.txt: Added.
  • fast/forms/file/resources/testFiles/subfolder2/file4.txt: Added.
  • fast/forms/file/resources/testFiles/subfolder2/subfolder2a/file5.txt: Added.
  • fast/forms/file/webkitdirectory-drag-folder-expected.txt: Added.
  • fast/forms/file/webkitdirectory-drag-folder.html: Added.
  • fast/forms/file/webkitdirectory-open-panel-expected.txt: Added.
  • fast/forms/file/webkitdirectory-open-panel.html: Added.
  • platform/mac-wk1/fast/forms/file/webkitdirectory-open-panel-expected.txt: Added.
  • platform/wk2/TestExpectations:
6:55 PM Changeset in webkit [221176] by commit-queue@webkit.org
  • 82 edits
    1 copy
    1 add
    6 deletes in trunk

Unreviewed, rolling out r221119, r221124, and r221143.
https://bugs.webkit.org/show_bug.cgi?id=175973

"I think it regressed JSBench by 20%" (Requested by saamyjoon
on #webkit).

Reverted changesets:

"Support compiling catch in the DFG"
https://bugs.webkit.org/show_bug.cgi?id=174590
http://trac.webkit.org/changeset/221119

"Unreviewed, build fix in GTK port"
https://bugs.webkit.org/show_bug.cgi?id=174590
http://trac.webkit.org/changeset/221124

"DFG::JITCode::osrEntry should get sorted since we perform a
binary search on it"
https://bugs.webkit.org/show_bug.cgi?id=175893
http://trac.webkit.org/changeset/221143

6:08 PM Changeset in webkit [221175] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebKit

[Cache API] UIProcess should provide the directory path where to store Cache Storage data
https://bugs.webkit.org/show_bug.cgi?id=175884

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-24
Reviewed by Brady Eidson.

Adding API to set the cache storage directory path.
Updating IPC to pass this parameter with its sandbox extension to NetworkProcess at creation time.

  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::cacheStorageDirectory const):

  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::createWithLegacyOptions):
(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration):
(API::ProcessPoolConfiguration::ProcessPoolConfiguration):
(API::ProcessPoolConfiguration::copy):

  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/APIWebsiteDataStore.h:
  • UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:

(API::WebsiteDataStore::defaultCacheStorageDirectory):

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::legacyPlatformDefaultCacheStorageDirectory):

  • UIProcess/WebProcessPool.cpp:

(WebKit::legacyWebsiteDataStoreConfiguration):
(WebKit::WebProcessPool::ensureNetworkProcess):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebsiteData/WebsiteDataStore.h:
5:57 PM Changeset in webkit [221174] by webkit@devinrousso.com
  • 4 edits
    2 moves in trunk/Source/WebInspectorUI

Web Inspector: add filter for draw actions in Recordings
https://bugs.webkit.org/show_bug.cgi?id=175448
<rdar://problem/34040764>

Reviewed by Matt Baker.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel.prototype.initialLayout):
(WI.RecordingNavigationSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
Add button to filter visual actions.
Drive-by fix: ensure that frame folders are still visible when filtering.

  • UserInterface/Images/Paint.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/PaintFlashing.svg.
  • UserInterface/Images/gtk/Paint.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/gtk/PaintFlashing.svg.
  • UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView):
Rename PaintFlashing.svg to Paint.svg.

5:39 PM Changeset in webkit [221173] by Ryan Haddad
  • 6 edits in trunk

Unreviewed, rolling out r221139.

This change did not resolve the LayoutTest assertion failure.

Reverted changeset:

"REGRESSION (r220052): ASSERTION FAILED:

!frame().isMainFrame()
!needsStyleRecalcOrLayout() in

WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()"
https://bugs.webkit.org/show_bug.cgi?id=175270
http://trac.webkit.org/changeset/221139

5:28 PM Changeset in webkit [221172] by achristensen@apple.com
  • 7 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's handleAutoplayEvent
https://bugs.webkit.org/show_bug.cgi?id=175965
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

Covered by updating API tests to use UIDelegate instead of _pageForTesting and WKPageUIClient.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::toWKFocusDirection):
(WebKit::toWKAutoplayEventFlags):
(WebKit::toWKAutoplayEvent):
(WebKit::UIDelegate::UIClient::handleAutoplayEvent):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(-[AutoplayPoliciesDelegate _webView:handleAutoplayEvent:withFlags:]):
(TEST):
(handleAutoplayEvent): Deleted.

5:05 PM Changeset in webkit [221171] by achristensen@apple.com
  • 2 edits in trunk/Tools

didNotHandleWheelEvent test times out
https://bugs.webkit.org/show_bug.cgi?id=175967

  • TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:

Skip the test until WebCore's wheel event handling is reliable enough to test.

4:52 PM Changeset in webkit [221170] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

WPT harness errors on leaks and iOS-sim EWS bots
https://bugs.webkit.org/show_bug.cgi?id=175269
<rdar://problem/33902404>

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-24

  • TestExpectations: Skipping a test that uses a python script run by WPT that makes a lot of noise in the log.
4:43 PM Changeset in webkit [221169] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed.

  • Modules/mediastream/MediaStreamTrack.idl: Remove extraneous and confusing comment in IDL.

The 'new' enum was removed via r215198, so we can remove this specific FIXME.

4:18 PM Changeset in webkit [221168] by Jonathan Bedard
  • 2 edits in trunk/Tools

Update configure-xcode-for-ios-development for iOS 11
https://bugs.webkit.org/show_bug.cgi?id=173937
<rdar://problem/33038924>

Reviewed by Daniel Bates.

Xcode 9 has removed the following headers from the iOS 11 Simulator SDK:

/usr/include/crt_externs.h
/usr/include/mach/mach_types.defs
/usr/include/mach/machine/machine_types.defs
/usr/include/mach/std_types.defs
/usr/include/objc/objc-class.h
/usr/include/objc/objc-runtime.h
/usr/include/objc/Protocol.h
/usr/include/readline/history.h
/usr/include/readline/readline.h

To solve this problem, configure-xcode-for-ios-development copies these headers
from the active macOS SDK into the iOS Simulator SDK.

  • Scripts/configure-xcode-for-ios-development:

(copyMissingHeadersFromSDKToSDKIfNeeded): Copy all missing header from one SDK
into another if those headers do not exist in the destination SDK.
(copyMissingHeadersToIPhoneOSSDKIfNeeded): Deleted.

4:03 PM Changeset in webkit [221167] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Enable moving fixed character class terms after fixed character terms for BMP only character classes
https://bugs.webkit.org/show_bug.cgi?id=175958

Reviewed by Saam Barati.

Currently we don't perform the reordering optimiaztion of fixed character terms that
follow fixed character class terms for Unicode patterns.

This change allows that reordering when the character class contains only BMP
characters.

This fix is covered by existing tests.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::optimizeAlternative):

3:43 PM Changeset in webkit [221166] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk/Source/WebInspectorUI

Web Inspector: Create experimental Layers tab
https://bugs.webkit.org/show_bug.cgi?id=175728

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-24
Reviewed by Devin Rousso.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Main.js:
  • UserInterface/Base/Setting.js:
  • UserInterface/Images/Layers.svg: Added.
  • UserInterface/Main.html:
  • UserInterface/Views/Layers3DContentView.js: Added.
  • UserInterface/Views/LayersTabContentView.js: Added.
  • UserInterface/Views/SettingsTabContentView.js:
3:37 PM Changeset in webkit [221165] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit

Remove duplicate WebCore::URL encoder/decoder
https://bugs.webkit.org/show_bug.cgi?id=175952

Reviewed by Chris Dumez.

Don't need the WebCoreArgumentCoder in WebKit since the URL class defines its own coders.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<URL>::encode): Deleted.
(IPC::ArgumentCoder<URL>::decode): Deleted.

  • Shared/WebCoreArgumentCoders.h:
3:10 PM Changeset in webkit [221164] by achristensen@apple.com
  • 6 edits in trunk

Add WKUIDelegatePrivate callback corresponding to PageUIClient's didNotHandleWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=175957
<rdar://problem/29270035>

Reviewed by Geoffrey Garen.

Source/WebKit:

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didNotHandleWheelEvent):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:

(synthesizeWheelEvents):
(-[WheelDelegate _webView:didNotHandleWheelEvent:]):
(-[WheelDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

2:53 PM Changeset in webkit [221163] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked quicklook/multi-sheet-numbers-09.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175865

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
2:45 PM Changeset in webkit [221162] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Stop using PolicyCallback for new window policies
https://bugs.webkit.org/show_bug.cgi?id=175907

Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-24
Reviewed by Andy Estes.

PolicyCallback is an artifact from the days before C++11. Let's use lambdas instead!
No change in behaviour.

  • loader/PolicyCallback.cpp:

(WebCore::PolicyCallback::set):
(WebCore::PolicyCallback::call):
(WebCore::PolicyCallback::cancel):

  • loader/PolicyCallback.h:
  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):
(WebCore::PolicyChecker::continueAfterNewWindowPolicy): Deleted.

  • loader/PolicyChecker.h:
2:41 PM Changeset in webkit [221161] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Overflow scroll views are inset to avoid safe areas even if the parent view is not
https://bugs.webkit.org/show_bug.cgi?id=175949
<rdar://problem/34063057>

Reviewed by Beth Dakin.

  • UIProcess/ios/RemoteLayerTreeHostIOS.mm:

(WebKit::RemoteLayerTreeHost::createLayer):
Disable automatic content inset adjustment to avoid safe areas on
all of WKWebView's child UIScrollViews.

2:14 PM Changeset in webkit [221160] by msaboff@apple.com
  • 21 edits
    3 adds in trunk

Add support for RegExp "dotAll" flag
https://bugs.webkit.org/show_bug.cgi?id=175924

Reviewed by Keith Miller.

JSTests:

Updated tests for new dotAll ('s' flag) changes.

  • es6/Proxy_internal_get_calls_RegExp.prototype.flags.js:
  • stress/static-getter-in-names.js:

Source/JavaScriptCore:

The dotAll RegExp flag, 's', changes . to match any character including line terminators.
Added a the "dotAll" identifier as well as RegExp.prototype.dotAll getter.
Added a new any character CharacterClass that is used to match . terms in a dotAll flags
RegExp. In the YARR pattern and parsing code, changed the NewlineClassID, which was only
used for '.' processing, to DotClassID. The selection of which builtin character class
that DotClassID resolves to when generating the pattern is conditional on the dotAll flag.
This NewlineClassID to DotClassID refactoring includes the atomBuiltInCharacterClass() in
the WebCore content extensions code in the PatternParser class.

As an optimization, the Yarr JIT actually doesn't perform match checks against the builtin
any character CharacterClass, it merely reads the character. There is another optimization
in our DotStart enclosure processing where a non-capturing regular expression in the form
of .*<expression.*, with options beginning and/or trailing $, match the contained
expression and then look for the extents of the surrounding .*'s. When used with the
dotAll flag, that processing alwys results with the beinning of the string and the end
of the string. Therefore we short circuit the finding the beginning and end of the line
or string with dotAll patterns.

  • bytecode/BytecodeDumper.cpp:

(JSC::regexpToSourceString):

  • runtime/CommonIdentifiers.h:
  • runtime/RegExp.cpp:

(JSC::regExpFlags):
(JSC::RegExpFunctionalTestCollector::outputOneTest):

  • runtime/RegExp.h:
  • runtime/RegExpKey.h:
  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::finishCreation):
(JSC::flagsString):
(JSC::regExpProtoGetterDotAll):

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::matchDotStarEnclosure):

  • yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::dotAll const):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::optimizeAlternative):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generateDotStarEnclosure):

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::parseTokens):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::atomBuiltInCharacterClass):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassBuiltIn):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):
(JSC::Yarr::YarrPattern::YarrPattern):
(JSC::Yarr::PatternTerm::dump):
(JSC::Yarr::anycharCreate):

  • yarr/YarrPattern.h:

(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::anyCharacterClass):
(JSC::Yarr::YarrPattern::dotAll const):

Source/WebCore:

Changed due to refactoring NewlineClassID to DotClassID.

No new tests. No change in behavior.

  • contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::PatternParser::atomBuiltInCharacterClass):

LayoutTests:

  • js/regexp-dotall-expected.txt: Added.
  • js/regexp-dotall.html: Added.
  • js/script-tests/Object-getOwnPropertyNames.js:
  • js/script-tests/regexp-dotall.js: Added.

New tests.

  • js/Object-getOwnPropertyNames-expected.txt:

Updated tests for new dotAll ('s' flag) changes.

2:03 PM Changeset in webkit [221159] by Ryan Haddad
  • 2 edits in trunk/Source/WebCore

Unreviewed, revert part of r221152 to fix internal builds.

  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::create):

1:54 PM Changeset in webkit [221158] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/Tools

Unreviewed test gardening. rdar://problem/33903582

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

1:18 PM Changeset in webkit [221157] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Table grid shouldn't show behind empty state
https://bugs.webkit.org/show_bug.cgi?id=175943

Reviewed by Brian Burg.

  • UserInterface/Views/RecordingNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.recording > .content > .tree-outline):
(.sidebar > .panel.navigation.recording > .content > .tree-outline:not(:empty)):
Only apply the background when the TreeOutline has children.

12:46 PM Changeset in webkit [221156] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

12:44 PM Changeset in webkit [221155] by commit-queue@webkit.org
  • 9 edits in trunk

HTMLTrackElement behavior violates the standard
https://bugs.webkit.org/show_bug.cgi?id=175888

Patch by Kirill Ovchinnikov <kirill.ovchinn@gmail.com> on 2017-08-24
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/text-track-src-change.html: added asserts

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::parseAttribute):
(WebCore::HTMLTrackElement::loadTimerFired):

  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::scheduleLoad):

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::removeAllCues):

  • html/track/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::removeAll):

  • html/track/TextTrackCueList.h:

LayoutTests:

  • media/track/text-track-src-change-expected.txt:
  • media/track/text-track-src-change.html:
12:38 PM Changeset in webkit [221154] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.7

Tag Safari-604.1.38.0.7.

11:57 AM Changeset in webkit [221153] by timothy_horton@apple.com
  • 4 edits in trunk

Layout size override changes during in-flight animated resize are dropped on the floor forever
https://bugs.webkit.org/show_bug.cgi?id=175916
<rdar://problem/33887295>

Reviewed by Beth Dakin.

Source/WebKit:

Layout size override changes that come in during an animated resize
are currently stored, but not sent in a separate message, because
they're sent as part of the resize. However, if a layout size override
change happens after the animated resize message was already sent, but
before the animated resize is ended, that change will be stored, but
not sent in the animated resize message (because it's too late), and
then subsequent calls with the same size will early-return, because
we're testing against the stored size, not the size we last actually
sent to the Web Content process.

Instead, store the last-sent size, so that subsequent layout size override
changes with the same size won't bail, and if it differs from the active
state after the animated resize completes, send an out-of-band update.

All of the above also applies to device orientation, which follows
exactly the same pattern.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _dispatchSetMinimumLayoutSize:]):
(-[WKWebView _dispatchSetMaximumUnobscuredSize:]):
(-[WKWebView _dispatchSetDeviceOrientation:]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _windowDidRotate:]):
(-[WKWebView _didRelaunchProcess]):
(-[WKWebView _setMinimumLayoutSizeOverride:]):
(-[WKWebView _setInterfaceOrientationOverride:]):
(-[WKWebView _setMaximumUnobscuredSizeOverride:]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:

(TEST):
Add a test ensuring that override layout size changes
during an animated resize actually take effect.

11:35 AM Changeset in webkit [221152] by ddkilzer@apple.com
  • 11 edits in trunk/Source/WebCore

Fix -Wcast-qual and -Wunused-lambda-capture warnings in WebCore with new clang compiler
<https://webkit.org/b/175910>
<rdar://problem/33667497>

Reviewed by Alex Christensen.

Fix -Wunused-lambda-capture warnings:

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::setBodyData): Remove unused lambda
capture of 'this'.

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::createRenderer): Add
UNUSED_PARAM(style) when ENABLE(CSS_REGIONS) is turned off.

Fix -Wcast-qual warnings:

  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::create): Switch from C-style cast to
reinterpret_cast with const keyword. This better matches the
argument types used in CCRSACryptorCreateFromData().

  • platform/audio/mac/FFTFrameMac.cpp:

(WebCore::FFTFrame::doFFT): Switch from C-style cast to
reinterpret_cast with const keyword. This better matches the
argument type used in vDSP_ctoz().

  • platform/graphics/FontPlatformData.h: Only define

WebCore::toCTFont() and WebCore::toNSFont() when building for
Objective-C++.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
Switch from C-style cast to reinterpret_cast with const keyword.
This better matches the argument type used in
Uint8Array::setRange().

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::CMTimebaseEffectiveRateChangedCallback): Use
const_cast to avoid warning.

  • platform/mac/SSLKeyGeneratorMac.mm:

(WebCore::signedPublicKeyAndChallengeString): Use const_cast to
avoid warning, and switch C-style cast to reinterpret_cast.

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::transformToString):

  • Use const_cast to avoid warning, and switch C-style cast to reinterpret_cast.
  • Switch C-style cast to reinterpret_cast and add const keyword.
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLParserContext::createMemoryParser): Use const_cast
to avoid warning, and switch C-style cast to reinterpret_cast.

11:27 AM Changeset in webkit [221151] by Matt Lewis
  • 2 edits in trunk/Tools

Disabled VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling.
https://bugs.webkit.org/show_bug.cgi?id=175909

Unreviewed test gardening.

  • TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:

(TestWebKitAPI::TEST):

11:18 AM Changeset in webkit [221150] by Jonathan Bedard
  • 3 edits in trunk/LayoutTests

Move imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm expectation.
<rdar://problem/32826391>

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-wk2/TestExpectations:
11:11 AM Changeset in webkit [221149] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit

_WKThumbnailView snapshots have to be copied by CA on first commit due to bad row alignment
https://bugs.webkit.org/show_bug.cgi?id=175898
<rdar://problem/34029673>

Reviewed by Sam Weinig.

In order to avoid copying, CGImages used as layer contents need to have certain
alignment requirements fulfilled. Align the row stride to the desired value.

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::numBytesForSize):
(WebKit::ShareableBitmap::calculateBytesPerPixel): Deleted.

  • Shared/ShareableBitmap.h:

(WebKit::ShareableBitmap::sizeInBytes const):
(WebKit::ShareableBitmap::numBytesForSize): Deleted.
Merge the interfaces of numBytesPerSize and sizeInBytes between the platforms.
numBytesForSize now makes use of the new calculateBytesPerRow, which is
implemented by each platform ShareableBitmap implementation to do the
requisite alignment for that platform.

  • Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::calculateBytesPerRow):
(WebKit::ShareableBitmap::calculateBytesPerPixel):
(WebKit::createSurfaceFromData):
(WebKit::ShareableBitmap::numBytesForSize): Deleted.
Implement calculateBytesPerRow (which used to be hidden inside of numBytesForSize)
and get rid of the now-duplicative numBytesForSize.

  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::calculateBytesPerRow):
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::createCGImage const):
Implement calculateBytesPerRow and make use of it when providing a row stride
to CoreGraphics.

11:00 AM Changeset in webkit [221148] by fpizlo@apple.com
  • 12 edits in trunk/Source

Reduce Gigacage sizes
https://bugs.webkit.org/show_bug.cgi?id=175920

Reviewed by Mark Lam.

Source/bmalloc:

This introduces the ability to have different gigacage sizes for different gigacages, and uses it to reduce the size of both
gigacages, but to different extents: Primitive gets 32GB with a 16GB runway and JSValue gets 16GB.

This is a ~10% membuster progression on my Mac Pro.

  • bmalloc/Gigacage.cpp:

(Gigacage::ensureGigacage):

  • bmalloc/Gigacage.h:

(Gigacage::size):
(Gigacage::alignment):
(Gigacage::mask):
(Gigacage::runway):
(Gigacage::totalSize):
(Gigacage::caged):

  • bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):
(bmalloc::Heap::gigacageSize):

  • bmalloc/Heap.h:

Source/JavaScriptCore:

Teach all of the code generators to use the right gigacage masks.

Also teach Wasm that it has much less memory for signaling memories. With 32GB, we have room for 7 signaling memories. But if
we actually did that, then we'd have no memory left for anything else. So, this caps us at 4 signaling memories.

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::cage):
(JSC::AssemblyHelpers::cageConditionally):

  • llint/LowLevelInterpreter64.asm:
  • runtime/Options.h:

Source/WTF:

Provide filler API for the no-bmalloc/no-Gigacage case.

  • wtf/Gigacage.h:

(Gigacage::mask):

10:53 AM Changeset in webkit [221147] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

[Repaint Outside Layout] Add a pref for repainting outside of layout
https://bugs.webkit.org/show_bug.cgi?id=175729

Reviewed by Daniel Bates.

  • page/Settings.in:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::checkForRepaintDuringLayout):

10:42 AM Changeset in webkit [221146] by mark.lam@apple.com
  • 1 edit
    1 add in trunk/JSTests

Land regression test for https://bugs.webkit.org/show_bug.cgi?id=164081.
https://bugs.webkit.org/show_bug.cgi?id=175940
<rdar://problem/29003921>

Reviewed by Saam Barati.

  • stress/regress-164081.js: Added.

(shouldEqual):
(testcase):

10:31 AM Changeset in webkit [221145] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.38.0-branch/Source/WebKit

Cherry-pick r221138. rdar://problem/34059603

10:05 AM Changeset in webkit [221144] by Jonathan Bedard
  • 3 edits in trunk/LayoutTests

Move imported/w3c/web-platform-tests/IndexedDB/large-nested-cloning.html expectations.
https://bugs.webkit.org/show_bug.cgi?id=173487

Unreviewed test gardening.

imported/w3c/web-platform-tests/IndexedDB/large-nested-cloning.html is flakey on both
iOS Simulator and iOS Device.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-wk2/TestExpectations:
9:59 AM Changeset in webkit [221143] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

DFG::JITCode::osrEntry should get sorted since we perform a binary search on it
https://bugs.webkit.org/show_bug.cgi?id=175893

Reviewed by Mark Lam.

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::finalizeOSREntrypoints):

  • dfg/DFGJITCode.h:

(JSC::DFG::JITCode::finalizeCatchOSREntrypoints): Deleted.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::linkOSREntries):

9:53 AM Changeset in webkit [221142] by Jonathan Bedard
  • 3 edits in trunk/LayoutTests

Move http/tests/preload/viewport/meta-viewport-link-headers.php back to iOS.
https://bugs.webkit.org/show_bug.cgi?id=172518

Unreviewed test gardening.

This test is flakey on both iOS device and iOS simulator. http/tests/preload/viewport
should be marked as passing for iOS, but we should not re-mark it for iOS Simulator.

  • platform/ios-simulator/TestExpectations:
  • platform/ios/TestExpectations:
9:49 AM Changeset in webkit [221141] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests/imported/w3c

WPT harness errors on leaks and iOS-sim EWS bots
https://bugs.webkit.org/show_bug.cgi?id=175269
<rdar://problem/33902404>

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-24
Reviewed by Alexey Proskuryakov.

Adding more logging to check whether the server is hanging or TCP connection is timing out.

  • web-platform-tests/tools/wptserve/wptserve/response.py:

(Response.write_content):
(ResponseWriter.write):
(ResponseWriter.write_content_file):

  • web-platform-tests/tools/wptserve/wptserve/server.py:

(WebTestRequestHandler.handle_one_request):

9:42 AM Changeset in webkit [221140] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip editing/execCommand/forward-delete-read-write-canvas.html.
https://bugs.webkit.org/show_bug.cgi?id=175939

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
9:37 AM Changeset in webkit [221139] by Darin Adler
  • 6 edits in trunk
REGRESSION (r220052): ASSERTION FAILED: !frame().isMainFrame()
!needsStyleRecalcOrLayout() in WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()

https://bugs.webkit.org/show_bug.cgi?id=175270

Reviewed by Simon Fraser.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::Document): Initialize m_styleRecalcTimer with a lamdba so it can work
with a function that returns a bool and ignore the return value.
(WebCore::Document::updateStyleIfNeeded): Added a boolean return value indicating if the
function did any work or not.

  • dom/Document.h: Updated for above change.
  • page/FrameView.cpp:

(WebCore::appendRenderedChildren): Added helper that will later replace the
FrameView::renderedChildFrameViews function and is used below.
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive): Instead of always doing two
passes of style and layout update do up to four passes, but stop as soon as a pass does
no work. This is slightly more efficient in cases where no layout and style update is
needed, and works correctly when a third pass is needed, which is what happens in the
test that was failing. We can eventually improve this further, but this resolves the
immediate problem we are seeing in the test.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Re-enable the disabled test.
8:59 AM Changeset in webkit [221138] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

[iOS] ViewServices started by StoreKitUIService may get suspended unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=175922
<rdar://problem/34028921>

Reviewed by Tim Horton.

ViewServices started by StoreKitUIService may get suspended unexpectedly. This is
because StoreKitUIService is itself a ViewService and is therefore in the background.
To address the issue, treat StoreKitUIService as initially foreground in
ApplicationStateTracker so that its ViewServices do not get suspended. We don't
have good way to deal with ViewServices started by other ViewServices unfortunately.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):

8:45 AM Changeset in webkit [221137] by Ryan Haddad
  • 2 edits in trunk/JSTests

Skip flaky JSC test stress/test-finally.js.
https://bugs.webkit.org/show_bug.cgi?id=160283

Unreviewed test gardening.

  • stress/test-finally.js:
8:35 AM Changeset in webkit [221136] by tpopela@redhat.com
  • 2 edits in trunk

Bump trunk version to be 2.19.1

Rubber-stamped by Michael Catanzaro.

  • Source/cmake/OptionsGTK.cmake:
7:36 AM Changeset in webkit [221135] by don.olmstead@sony.com
  • 13 edits in trunk

[CMake] Use find_package for SQLite
https://bugs.webkit.org/show_bug.cgi?id=175803

Reviewed by Konstantin Tokarev.

.:

  • Source/cmake/OptionsAppleWin.cmake:
  • Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

No new tests. No change in behavior.

  • CMakeLists.txt:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • PlatformWPE.cmake:
  • PlatformWinCairo.cmake:

Source/WebKitLegacy:

  • PlatformWin.cmake:

Tools:

  • TestWebKitAPI/PlatformWin.cmake:
7:12 AM Changeset in webkit [221134] by commit-queue@webkit.org
  • 4 edits
    7 deletes in trunk/LayoutTests

Remove some duplicated media track tests.
https://bugs.webkit.org/show_bug.cgi?id=175929

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-24
Reviewed by Sam Weinig.

All these tests have been submitted to web-platform-tests and are maintained
there. A copy of them exists in
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/.
Most of the retained tests also exist in web-platform-tests, but in the
webvtt/ top-level directory, which is currently not imported.

  • media/track/opera/interfaces/TextTrack/activeCues.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/onenter.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/onexit.html: Removed.
  • media/track/opera/interfaces/TextTrackCueList/getter.html: Removed.
  • media/track/opera/interfaces/TextTrackList/getter.html: Removed.
  • media/track/opera/interfaces/TrackEvent/constructor.html: Removed.
  • media/track/opera/interfaces/TrackEvent/createEvent.html: Removed.
  • media/track/opera/track/track-element/src-clear-cues.html: Removed.
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
7:03 AM WebKitGTK/Gardening/Calendar edited by magomez@igalia.com
(diff)
6:50 AM Changeset in webkit [221133] by magomez@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Update expectations of several tests failing at r221132.

  • platform/gtk/TestExpectations:
5:28 AM WebKitGTK/2.18.x edited by clopez@igalia.com
(diff)
5:08 AM WebKitGTK/2.18.x edited by clopez@igalia.com
(diff)
5:07 AM WebKitGTK/2.16.x edited by clopez@igalia.com
(diff)
1:45 AM Changeset in webkit [221132] by Adrian Perez de Castro
  • 3 edits in trunk/Source

Geoclue2 based backend should provide the right desktop ID
https://bugs.webkit.org/show_bug.cgi?id=129879

Reviewed by Michael Catanzaro.

  • platform/geoclue/GeolocationProviderGeoclue.cpp:

(GeolocationProviderGeoclue::createGeoclueClientProxyCallback): Try first obtaining the application
identifier using GApplication first, keeping a fallback to the value returned by g_get_prgname().

1:07 AM Changeset in webkit [221131] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[EME] Implement HTMLMediaElement dispatch of the onencrypted event
https://bugs.webkit.org/show_bug.cgi?id=175927

Reviewed by Xabier Rodriguez-Calvar.

Add the MediaPlayerClient::mediaPlayerInitializationDataEncountered()
method that the platform-layer media pipeline can invoke when it hits
encrypted content in the media data. The initialization data and its type
are passed by the caller, allowing the HTMLMediaElement override to
process it further.

This is done in the mediaPlayerInitializationDataEncountered() override
in the HTMLMediaElement class. Partially implementing the 'Initialization
Data Encountered' algorithm, the 'encrypted' event is dispatched, with the
MediaEncryptedEvent interface being leveraged to embed init data and init
data type information. CORS and mixed-content validation of the media data
is skipped for now.

MediaPlayer::initializationDataEncountered() method should be used to
dispatch the corresponding method on the client, passing on the given init
data and init data type values.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerInitializationDataEncountered):

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::initializationDataEncountered):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerInitializationDataEncountered):

Note: See TracTimeline for information about the timeline view.