Timeline



Sep 8, 2017:

10:19 PM Changeset in webkit [221807] by Yusuke Suzuki
  • 3 edits
    1 add in trunk

[DFG] NewArrayWithSize(size)'s size does not care negative zero
https://bugs.webkit.org/show_bug.cgi?id=176300

Reviewed by Saam Barati.

JSTests:

  • stress/new-array-with-size-div.js: Added.

(shouldBe):
(test):
(i.i):

Source/JavaScriptCore:

NewArrayWithSize(size)'s size does not care negative zero as
is the same to NewTypedArray. We propagate this information
in DFGBackwardsPropagationPhase. This removes negative zero
check in kraken fft's deinterleave function.

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

8:32 PM Changeset in webkit [221806] by commit-queue@webkit.org
  • 13 edits
    2 deletes in trunk/Source/WebCore

Replace JS builtin implementation of the FetchResponse constructor with a C++ one
https://bugs.webkit.org/show_bug.cgi?id=176627

Patch by Sam Weinig <sam@webkit.org> on 2017-09-08
Reviewed by Alex Christensen.

Removes the last of the Fetch related JS builtin code.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/fetch/FetchInternals.js: Removed.
  • Modules/fetch/FetchResponse.js: Removed.

Remove FetchInternals.js and FetchResponse.js.

  • Modules/fetch/FetchBody.idl:
  • Modules/fetch/FetchBodyConsumer.h:

Remove no longer correct FIXMEs.

  • Modules/fetch/FetchBodySource.cpp:

Add missing newline between functions.

  • Modules/fetch/FetchHeaders.idl:
  • Modules/fetch/FetchResponse.idl:

Remove builtin related operations and extended attributes.

  • Modules/fetch/FetchHeaders.h:

(WebCore::FetchHeaders::fastHas const):

  • Modules/fetch/FetchHeaders.cpp:

Added fastHas to allow checking for a header using a HTTPHeaderName. Remove
now unused filter function.

  • Modules/fetch/FetchResponse.cpp:

(WebCore::isNullBodyStatus):

Added helper predicate for 'null body status' concept.

(WebCore::FetchResponse::create):

Add spec defined constructor implementation.

(WebCore::FetchResponse::setBodyData):

Reformatted to match more common WTF::switchOn style.

(WebCore::FetchResponse::setStatus): Deleted.
(WebCore::FetchResponse::initializeWith): Deleted.

Removed now unused functions.

  • Modules/fetch/FetchResponse.h:

(WebCore::FetchResponse::create):

Move inline create out of the class definition to make things a bit less crowded.

8:09 PM Changeset in webkit [221805] by commit-queue@webkit.org
  • 10 edits
    10 adds in trunk

Implement HTMLImageElement.decoode() method
https://bugs.webkit.org/show_bug.cgi?id=176016

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-09-08
Reviewed by Simon Fraser.

Source/WebCore:

The specs is:
https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-decode.

-- img.decode() waits till loading the image finishes. Otherwise it starts
decoding the image immediately.
-- If the image frame is already decoded, the promise will be resolved
before return.
-- If an error happens in loading the image or decoding the image frame,
the promise will be rejected with 'EncodingError' exception.
-- Animated image resolves the promise when the next frame is decoded and
the animation is advanced it. If the image is not displayed, decode() will
request the decoding the first frame and start animating the image.

Tests: fast/images/decode-animated-image.html

fast/images/decode-render-animated-image.html
fast/images/decode-render-static-image.html
fast/images/decode-static-image-reject.html
fast/images/decode-static-image-resolve.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::decode):

  • html/HTMLImageElement.h:
  • html/HTMLImageElement.idl:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::decode):
(WebCore::ImageLoader::decodeError):

  • loader/ImageLoader.h:

(WebCore::ImageLoader::hasPendingDecodePromise const):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::internalStartAnimation):
(WebCore::BitmapImage::internalAdvanceAnimation):
(WebCore::BitmapImage::decode):
(WebCore::BitmapImage::imageFrameAvailableAtIndex):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h:

(WebCore::Image::decode):

LayoutTests:

  • fast/images/decode-animated-image-expected.html: Added.
  • fast/images/decode-animated-image.html: Added.
  • fast/images/decode-render-animated-image-expected.html: Added.
  • fast/images/decode-render-animated-image.html: Added.
  • fast/images/decode-render-static-image-expected.html: Added.
  • fast/images/decode-render-static-image.html: Added.
  • fast/images/decode-static-image-reject-expected.txt: Added.
  • fast/images/decode-static-image-reject.html: Added.
  • fast/images/decode-static-image-resolve-expected.html: Added.
  • fast/images/decode-static-image-resolve.html: Added.
5:33 PM Changeset in webkit [221804] by commit-queue@webkit.org
  • 5 edits
    7 adds in trunk

Fetch's Response.statusText is unexpectedly the full http status line for HTTP/2 responses
https://bugs.webkit.org/show_bug.cgi?id=176479

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-08
Reviewed by Alex Christensen.

Source/WebCore:

Test: http/wpt/fetch/response-status-text.html

HTTP/2 doesn't include a status reason phrase. So the "status line"
ends up just being the version and status code. Fallback to the empty
string instead of the full line.

  • platform/network/HTTPParsers.cpp:

(WebCore::extractReasonPhraseFromHTTPStatusLine):

Source/WebKit:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
Initialize AtomicString statics like emptyAtom().

LayoutTests:

  • http/wpt/fetch/resources/status-garbage.asis: Added.
  • http/wpt/fetch/resources/status-normal.txt: Added.
  • http/wpt/fetch/resources/status-with-message.asis: Added.
  • http/wpt/fetch/resources/status-without-message.asis: Added.

Various text HTTP responses with different status lines.

  • http/wpt/fetch/response-status-text-expected.txt: Added.
  • http/wpt/fetch/response-status-text.html: Added.

Test the Fetch Response's status / statusText for different HTTP status lines.
The status without a message is similiar to HTTP/2 because HTTP/2 only
has a :status pseudo-header and lacks a reason phrase.

5:10 PM Changeset in webkit [221803] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Implement the attribute HTMLImageElement.async
https://bugs.webkit.org/show_bug.cgi?id=176204

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-09-08
Reviewed by Darin Adler.

Source/WebCore:

Adding this attribute to the <img> element will force async decoding for
this image all the times. None of the heuristics, which prevents flickering
the image, will be checked.

Test: fast/images/async-attribute-with-small-image.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLImageElement.h:

(WebCore::HTMLImageElement::async const):

  • html/HTMLImageElement.idl:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::decodingModeForImageDraw const):

LayoutTests:

  • fast/images/async-attribute-with-small-image-expected.html: Added.
  • fast/images/async-attribute-with-small-image.html: Added.
4:11 PM Changeset in webkit [221802] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Fix duplicate entry warnings on Windows.

Unreviewed test gardening.

  • platform/win/TestExpectations:
4:00 PM Changeset in webkit [221801] by Lucas Forschler
  • 4 edits in trunk/Tools

bisect-builds doesn't work due to missing requests module
https://bugs.webkit.org/show_bug.cgi?id=175709

Reviewed by Ryosuke Niwa.

  • Scripts/bisect-builds: update import to webkitpy.thirdparty.autoinstalled
  • Scripts/webkitpy/thirdparty/init.py: add logic to install requests module.

(AutoinstallImportHook.find_module):
(AutoinstallImportHook):
(AutoinstallImportHook._install_requests):

  • Scripts/webkitpy/thirdparty/init_unittest.py:

(ThirdpartyTest.test_imports):

3:09 PM Changeset in webkit [221800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Uncaught Exception: TypeError: this._heapSnapshot.addEventListener is not a function.
https://bugs.webkit.org/show_bug.cgi?id=176633

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-08
Reviewed by Michael Saboff.

  • UserInterface/Proxies/HeapSnapshotDiffProxy.js:

(WI.HeapSnapshotDiffProxy):
This class has listeners of another object's events. It should extend WI.Object.

2:27 PM Changeset in webkit [221799] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark http/tests/websocket/tests/hybi/websocket-pending-activity.html as a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=176632

Unreviewed test gardening.

  • platform/win/TestExpectations:
1:37 PM Changeset in webkit [221798] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: changes to currentX/currentY aren't highlighted in the details sidebar
https://bugs.webkit.org/show_bug.cgi?id=176569

Reviewed by Matt Baker.

  • UserInterface/Models/RecordingAction.js:

Add entries to WI.RecordingAction._stateModifiers for each path function.

1:31 PM Changeset in webkit [221797] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Added timeout expectation to imported/w3c/web-platform-tests/IndexedDB/large-nested-cloning.html on mac.
https://bugs.webkit.org/show_bug.cgi?id=173487

Unreviewed test gardening.

  • platform/mac/TestExpectations:
1:24 PM Changeset in webkit [221796] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark http/tests/security/canvas-remote-read-remote-video-allowed-anonymous.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=176626.

Unreviewed test gardening.

  • platform/win/TestExpectations:
12:30 PM Changeset in webkit [221795] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-element.html as slow.

Unreviewed test gardening.

  • platform/win/TestExpectations:
12:03 PM Changeset in webkit [221794] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Unreviewed, rolling out r221773.
https://bugs.webkit.org/show_bug.cgi?id=176614

This caused build failures. (Requested by mlewis13 on
#webkit).

Reverted changeset:

"[Mac] Upstream QTKit-related WebKitSystemInterface functions"
https://bugs.webkit.org/show_bug.cgi?id=176472
http://trac.webkit.org/changeset/221773

11:58 AM Changeset in webkit [221793] by Yusuke Suzuki
  • 11 edits
    2 adds in trunk

[DFG] PutByVal with Array::Generic is too generic
https://bugs.webkit.org/show_bug.cgi?id=176345

Reviewed by Filip Pizlo.

JSTests:

  • stress/object-assign-symbols.js: Added.

(shouldBe):
(test):

  • stress/object-assign.js: Added.

(shouldBe):
(test):
(i.shouldBe.JSON.stringify.test):

Source/JavaScriptCore:

Our DFG/FTL's PutByVal with Array::Generic is too generic implementation.
We could have the case like,

dst[key] = src[key];

with string or symbol keys. But they are handled in slow path.
This patch adds PutByVal(CellUse, StringUse/SymbolUse, UntypedUse). They go
to optimized path that does not have generic checks like (isInt32() / isDouble() etc.).

This improves SixSpeed object-assign.es5 by 9.1%.

object-assign.es5 424.3159+-11.0471 388.8771+-10.9239 definitely 1.0911x faster

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):
(JSC::DFG::putByValInternal):
(JSC::DFG::putByValCellInternal):
(JSC::DFG::putByValCellStringInternal):
(JSC::DFG::operationPutByValInternal): Deleted.

  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForCellWithString):
(JSC::DFG::SpeculativeJIT::compilePutByValForCellWithSymbol):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):

  • jit/JITOperations.h:
11:55 AM Changeset in webkit [221792] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test commit to verify trac sync is working.

11:46 AM Changeset in webkit [221791] by commit-queue@webkit.org
  • 2 edits
    5 adds in trunk/Source/WebKit

[WinCairo] Add Storage Process files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=176567

Patch by Stephan Szabo <stephan.szabo@am.sony.com> on 2017-09-08
Reviewed by Alex Christensen.

  • PlatformWin.cmake:
  • StorageProcess/EntryPoint/win/StorageProcessMain.cpp: Added.

(main):

  • StorageProcess/win/StorageProcessMainWin.cpp: Added.

(WebKit::StorageProcessMainWin):

  • StorageProcess/win/StorageProcessMainWin.h: Added.
11:45 AM Changeset in webkit [221790] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test commit to verify git sync is working.

10:25 AM Changeset in webkit [221789] by Lucas Forschler
  • 2 edits in trunk/Tools

bisect-builds should not print out extracting command
https://bugs.webkit.org/show_bug.cgi?id=175632

Reviewed by Alexey Proskuryakov.

  • Scripts/bisect-builds:

(extract_archive):

9:35 AM Changeset in webkit [221788] by Antti Koivisto
  • 40 edits
    10 deletes in trunk

Remove support for >> descendant combinator syntax
https://bugs.webkit.org/show_bug.cgi?id=175765

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Tests for these have been removed in WPT master, just update expectations until new version is imported.

  • web-platform-tests/dom/nodes/Element-matches-expected.txt:
  • web-platform-tests/dom/nodes/Element-webkitMatchesSelector-expected.txt:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-expected.txt:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht-expected.txt:

Source/WebCore:

This is an alternative syntax for the normal descendant combinator (just space) that was
advertised as being consistent with > (child combinator) and >>> (shadow piercing combinator).
The latter has been killed so it is not consistent with anything anymore.

No other engine besides WebKit has implemented this and the WPT tests have been removed
(in https://github.com/w3c/web-platform-tests/pull/6785). Full removal from spec is still
open (https://github.com/w3c/csswg-drafts/issues/641) but we shouldn't encourage adoption of
this pointless feature.

While this has shipped the compatibility risk is low as no other engine implemented it and
there were no incentives to use it over the standard syntax.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const):

  • css/CSSSelector.h:

(WebCore::CSSSelector::hasDescendantRelation const):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively const):

  • css/SelectorFilter.cpp:

(WebCore::SelectorFilter::collectIdentifierHashes):

  • css/parser/CSSParserSelector.cpp:

(WebCore::CSSParserSelector::appendTagHistory):

  • css/parser/CSSParserSelector.h:
  • css/parser/CSSSelectorParser.cpp:

(WebCore::isDescendantCombinator):
(WebCore::CSSSelectorParser::consumeCombinator):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::fragmentRelationForSelectorRelation):

LayoutTests:

  • fast/css/ancestor-of-hovered-element-removed.html:
  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/css/currentColor-value-style-update.html:
  • fast/css/descendant-combinator-doubled-child-syntax-styling-expected.html: Removed.
  • fast/css/descendant-combinator-doubled-child-syntax-styling.html: Removed.
  • fast/css/parsing-css-attribute-case-insensitive-value-1-expected.txt:
  • fast/css/parsing-css-attribute-case-insensitive-value-1.html:
  • fast/css/parsing-css-attribute-case-insensitive-value-4-expected.txt:
  • fast/css/parsing-css-attribute-case-insensitive-value-4.html:
  • fast/css/parsing-css-descendant-combinator-doubled-child-syntax-expected.txt: Removed.
  • fast/css/parsing-css-descendant-combinator-doubled-child-syntax.html: Removed.
  • fast/selectors/case-insensitive-attribute-register-requirement-2.html:
  • fast/selectors/element-closest-descendant-combinator-doubled-child-syntax-expected.txt: Removed.
  • fast/selectors/element-closest-descendant-combinator-doubled-child-syntax.html: Removed.
  • fast/selectors/element-matches-attribute-ascii-case-insensitive-html.html:
  • fast/selectors/element-matches-descendant-combinator-doubled-child-syntax-expected.txt: Removed.
  • fast/selectors/element-matches-descendant-combinator-doubled-child-syntax.html: Removed.
  • fast/selectors/id-attribute-querySelector-used-as-id-selector-quirks.html:
  • fast/selectors/id-attribute-querySelector-used-as-id-selector.html:
  • fast/selectors/nth-child-matching-first.html:
  • fast/selectors/nth-last-child-matching-first.html:
  • fast/selectors/querySelector-attribute-ascii-case-insensitive-html.html:
  • fast/selectors/querySelector-descendant-combinator-doubled-child-syntax-expected.txt: Removed.
  • fast/selectors/querySelector-descendant-combinator-doubled-child-syntax.html: Removed.
9:19 AM Changeset in webkit [221787] by Ryan Haddad
  • 9 edits in trunk/Source/WebKit

Unreviewed, rolling out r221771.

This change caused two API tests to crash.

Reverted changeset:

"Clean up API::UIClient"
https://bugs.webkit.org/show_bug.cgi?id=176568
http://trac.webkit.org/changeset/221771

9:03 AM Changeset in webkit [221786] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark http/tests/websocket/tests/hybi/close-code-and-reason.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=176609.

Unreviewed test gardening.

  • platform/win/TestExpectations:
8:57 AM Changeset in webkit [221785] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark http/tests/preload/single_download_preload_headers.php as flaky.
https://bugs.webkit.org/show_bug.cgi?id=176606.

Unreviewed test gardening.

  • platform/win/TestExpectations:
8:43 AM Changeset in webkit [221784] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark http/tests/security/contentSecurityPolicy/audio-redirect-allowed2.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=176598.

Unreviewed test gardening.

  • platform/win/TestExpectations:
8:36 AM Changeset in webkit [221783] by Yusuke Suzuki
  • 10 edits
    4 adds in trunk

[DFG][FTL] GetByVal(ObjectUse with Array::Generic, StringUse/SymbolUse) should be supported
https://bugs.webkit.org/show_bug.cgi?id=176590

Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/object-iterate-symbols.js: Added.

(test):

  • microbenchmarks/object-iterate.js: Added.

(test):

  • stress/object-iterate-symbols.js: Added.

(shouldBe):
(test):

  • stress/object-iterate.js: Added.

(shouldBe):
(test):

Source/JavaScriptCore:

We add fixup edges for GetByVal(Array::Generic) to call faster operation instead of generic operationGetByVal.

baseline patched

object-iterate 5.8531+-0.3029 5.7903+-0.2795 might be 1.0108x faster
object-iterate-symbols 7.4099+-0.3993 5.8254+-0.2276 definitely 1.2720x faster

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGOperations.cpp:

(JSC::DFG::getByValObject):

  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValForObjectWithString):
(JSC::DFG::SpeculativeJIT::compileGetByValForObjectWithSymbol):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

8:06 AM WebKitGTK/Gardening/Calendar edited by zandobersek@gmail.com
(diff)
3:57 AM Changeset in webkit [221782] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[GStreamer] initializationDataEncountered() dispatch can outlive MediaPlayerPrivateGStreamerBase
https://bugs.webkit.org/show_bug.cgi?id=176544

Reviewed by Xabier Rodriguez-Calvar.

The RunLoop dispatch that invokes MediaPlayer::initializationDataEncountered()
can outlive the MediaPlayerPrivateGStreamerBase object that is referenced
from the dispatched functor. To avoid this, a WeakPtrFactory is placed onto
MediaPlayerPrivateGStreamerBase and a WeakPtr object is kept in the functor,
bailing during dispatch if the factory (along with MediaPlayerPrivateGStreamerBase)
has already been destroyed since the schedule of this dispatch.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
Also remove the unused sessionId string.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
3:55 AM Changeset in webkit [221781] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[GStreamer] Add GRefPtr specializations for GstGLDisplay, GstGLContext
https://bugs.webkit.org/show_bug.cgi?id=176543

Reviewed by Xabier Rodriguez-Calvar.

Both GstGLDisplay and GstGLContext inherit from GstObject, meaning
gst_object_ref_sink() and gst_object_unref() should be used for
incrementing and decrementing reference count. Template specializations
for the adoptGRef(), refGPtr() and derefGPtr() are added for both types,
preventing GRefPtr<> from falling back to using g_object_ref() and
g_object_unref() for reference count modification purposes.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):
(WTF::refGPtr<GstGLDisplay>):
(WTF::derefGPtr<GstGLDisplay>):
(WTF::refGPtr<GstGLContext>):
(WTF::derefGPtr<GstGLContext>):

  • platform/graphics/gstreamer/GRefPtrGStreamer.h:
3:54 AM Changeset in webkit [221780] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GStreamer] Incorrect GstCaps unreffing in GStreamerEMEUtilities::createDecryptor()
https://bugs.webkit.org/show_bug.cgi?id=176540

Reviewed by Xabier Rodriguez-Calvar.

  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp:

Include the GRefPtrGStreamer.h header in order to use specialized template
functions that correctly adopt and dereference GstCaps object that is
wrapped the GRefPtr<>.

Sep 7, 2017:

11:31 PM Changeset in webkit [221779] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] UI process crash in WebBackForwardList::restoreFromState
https://bugs.webkit.org/show_bug.cgi?id=176303

Reviewed by Michael Catanzaro.

Ensure the current index provided by the session state is not out of actual item list bounds. This is a bug in
the session state decoder, but WebBackForwardList::backForwardListState() is already doing the check and using
the last item index instead, so it's not easy to know where the actual problem is. In any case we should
still protect the decoder.

  • UIProcess/API/glib/WebKitWebViewSessionState.cpp:

(decodeSessionState):

11:21 PM Changeset in webkit [221778] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

WebKit should claim that it can show responses for a broader range of JSON MIMETypes
https://bugs.webkit.org/show_bug.cgi?id=176252
<rdar://problem/34212885>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-07
Reviewed by Ryosuke Niwa.

Source/WebCore:

  • platform/MIMETypeRegistry.h:
  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::canShowMIMEType):
Extend this to support JavaScript and JSON MIMETypes that WebKit
knows how to treat as text.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm: Added.

(-[WKNavigationResponseTestNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[WKNavigationResponseTestNavigationDelegate webView:didCommitNavigation:]):
(-[WKNavigationResponseTestSchemeHandler webView:startURLSchemeTask:]):
(-[WKNavigationResponseTestSchemeHandler webView:stopURLSchemeTask:]):
(TEST):
Test for canShowMIMEType with multiple JSON mime types and a garbage mime type.
Previously canShowMIMEType would have been YES for "application/json" but
NO for "application/vnd.api+json". Now it shows YES for both.

  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/PlatformWPE.cmake:
  • TestWebKitAPI/PlatformWin.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/MIMETypeRegistry.cpp: Added.

(TestWebKitAPI::TEST):
Tests for MIMETypeRegistry's dynamic JSON mime type detection.

7:58 PM Changeset in webkit [221777] by commit-queue@webkit.org
  • 1 edit
    15 adds in trunk/Tools

Add Live PLT implemented with WebDriver
https://bugs.webkit.org/show_bug.cgi?id=176436

Patch by Matthew Stewart <matthew_r_stewart@apple.com> on 2017-09-07
Reviewed by Stephanie Lewis.

Adds a new PLT that runs on live websites.

  • Scripts/run-webdriver-plt.py: Added.

(parse_args):
(start):
(make_suites):
(main):

  • Scripts/webkitpy/webdriver_plt/init.py: Added.
  • Scripts/webkitpy/webdriver_plt/liveplt.py: Added.

(PageLoadTest):
(PageLoadTest.init):
(PageLoadTest.start):
(PageLoadTest.run_suite):
(PageLoadTest._get_driver_for_browser):
(PageLoadTest._setup_browser_window):
(PageLoadTest.run_one_test):
(PageLoadTest.get_results):

  • Scripts/webkitpy/webdriver_plt/pltresults.py: Added.

(PLTResults):
(PLTResults.init):
(PLTResults.add):
(PLTResults.add_timing_result):
(PLTResults.mean):
(PLTResults.geometric_mean):
(PLTResults.mean_coef_variance):
(PLTResults.print_results):
(PLTResults.print_url_results):
(PLTResults._format_time):

  • Scripts/webkitpy/webdriver_plt/suites/init.py: Added.
  • Scripts/webkitpy/webdriver_plt/suites/arabic.suite: Added.
  • Scripts/webkitpy/webdriver_plt/suites/cjk.suite: Added.
  • Scripts/webkitpy/webdriver_plt/suites/news.suite: Added.
  • Scripts/webkitpy/webdriver_plt/suites/search.suite: Added.
  • Scripts/webkitpy/webdriver_plt/suites/shopping.suite: Added.
  • Scripts/webkitpy/webdriver_plt/suites/social.suite: Added.
  • Scripts/webkitpy/webdriver_plt/suites/suite.py: Added.

(Suite):
(Suite.init):
(Suite.get_available_suites):

  • Scripts/webkitpy/webdriver_plt/urlresults.py: Added.

(URLResults):
(URLResults.init):
(URLResults.add):
(URLResults.mean):
(URLResults.coef_variance):
(URLResults.print_results):
(URLResults._format_time):

7:57 PM Changeset in webkit [221776] by mmaxfield@apple.com
  • 12 edits
    1 copy in trunk/Tools

Add "if" statements to WSL
https://bugs.webkit.org/show_bug.cgi?id=176294

Reviewed by Filip Pizlo.

Fairly straightforward implementation. ReturnChecker only returns true iff there is an else block,
and both the if body and the else body recursively return true.

In order to accept both syntaxes:
if (foo)

bar;

... and ...
if (foo) {

bar;

}
This patch lets parseStatement() call parseBlock(). This means that the following is valid:
int x = 7;
if (foo) {

int x = 8;
x is 8 here!

}
x is 7 here!

This production means that these blocks don't require "if" statements, so you can just have:
int foo() {

int x = 7;
{

int x = 8;
x is 8 here!

}
x is 7 here!

}

However, this patch doesn't touch the following use-case:
if (int x = bar()) {

use x here

}

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/Checker.js:
  • WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitIfStatement):

  • WebGPUShadingLanguageRI/IfStatement.js: Copied from Tools/WebGPUShadingLanguageRI/TypeDef.js.

(IfStatement):
(IfStatement.prototype.get origin):
(IfStatement.prototype.get conditional):
(IfStatement.prototype.get body):
(IfStatement.prototype.get elseBody):
(IfStatement.prototype.toString):

  • WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitIfStatement):

  • WebGPUShadingLanguageRI/Parse.js:

(parseTypeParameters):
(parseIfStatement):
(parseStatement):

  • WebGPUShadingLanguageRI/ReturnChecker.js:

(ReturnChecker.prototype.visitIfStatement):

  • WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitIfStatement):
(Rewriter):

  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/Test.js:

(TEST_variableShadowing):
(TEST_ifStatement):
(TEST_ifElseStatement):
(TEST_ifElseIfStatement):
(TEST_ifElseIfElseStatement):
(TEST_returnIf):
(TEST_protocolMonoPolySigDoublePolyDefExplicit): Deleted.

  • WebGPUShadingLanguageRI/TypeDef.js:

(TypeDef.prototype.toString):
(TypeDef):

  • WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitIfStatement):

6:49 PM Changeset in webkit [221775] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test commit after server upgrade from subversion 1.9.5 to 1.9.7

6:14 PM Changeset in webkit [221774] by mark.lam@apple.com
  • 35 edits
    1 add in trunk/Source/JavaScriptCore

Use JIT probes for DFG OSR exit.
https://bugs.webkit.org/show_bug.cgi?id=175144
<rdar://problem/33437050>

Reviewed by Saam Barati.

This patch does the following:

  1. Replaces osrExitGenerationThunkGenerator() with osrExitThunkGenerator(). While osrExitGenerationThunkGenerator() generates a thunk that compiles a unique OSR offramp for each DFG OSR exit site, osrExitThunkGenerator() generates a thunk that just executes the OSR exit.

The osrExitThunkGenerator() generated thunk works by using a single JIT probe
to call OSRExit::executeOSRExit(). The JIT probe takes care of preserving
CPU registers, and providing the Probe::Stack mechanism for modifying the
stack frame.

OSRExit::executeOSRExit() replaces OSRExit::compileOSRExit() and
OSRExit::compileExit(). It is basically a re-write of those functions to
execute the OSR exit work instead of compiling code to execute the work.

As a result, we get the following savings:

  1. no more OSR exit ramp compilation time.
  2. no use of JIT executable memory for storing each unique OSR exit ramp.

On the negative side, we incur these costs:

  1. the OSRExit::executeOSRExit() ramp may be a little slower than the compiled version of the ramp. However, OSR exits are rare. Hence, this small difference should not matter much. It is also offset by the savings from (a).
  1. the Probe::Stack allocates 1K pages for memory for buffering stack modifcations. The number of these pages depends on the span of stack memory that the OSR exit ramp reads from and writes to. Since the OSR exit ramp tends to only modify values in the current DFG frame and the current VMEntryRecord, the number of pages tends to only be 1 or 2.

Using the jsc tests as a workload, the vast majority of tests that do OSR
exit, uses 3 or less 1K pages (with the overwhelming number using just 1 page).
A few tests that are pathological uses up to 14 pages, and one particularly
bad test (function-apply-many-args.js) uses 513 pages.

Similar to the old code, the OSR exit ramp still has 2 parts: 1 part that is
only executed once to compute some values for the exit site that is used by
all exit operations from that site, and a 2nd part to execute the exit. The
1st part is protected by a checking if exit.exitState has already been
initialized. The computed values are cached in exit.exitState.

Because the OSR exit thunk no longer compiles an OSR exit off-ramp, we no
longer need the facility to patch the site that jumps to the OSR exit ramp.
The DFG::JITCompiler has been modified to remove this patching code.

  1. Fixed the bottom most Probe::Context and Probe::Stack get/set methods to use std::memcpy to avoid strict aliasing issues.

Also optimized the implementation of Probe::Stack::physicalAddressFor().

  1. Miscellaneous convenience methods added to make the Probe::Context easier of use.
  1. Added a Probe::Frame class that makes it easier to get/set operands and arguments in a given frame using the deferred write properties of the Probe::Stack. Probe::Frame makes it easier to do some of the recovery work in the OSR exit ramp.
  1. Cloned or converted some functions needed by the OSR exit ramp. The original JIT versions of these functions are still left in place because they are still needed for FTL OSR exit. A FIXME comment has been added to remove them later. These functions include:

DFGOSRExitCompilerCommon.cpp's handleExitCounts() ==>

CodeBlock::updateOSRExitCounterAndCheckIfNeedToReoptimize()

DFGOSRExitCompilerCommon.cpp's reifyInlinedCallFrames() ==>

DFGOSRExit.cpp's reifyInlinedCallFrames()

DFGOSRExitCompilerCommon.cpp's adjustAndJumpToTarget() ==>

DFGOSRExit.cpp's adjustAndJumpToTarget()

MethodOfGettingAValueProfile::emitReportValue() ==>

MethodOfGettingAValueProfile::reportValue()

DFGOperations.cpp's operationCreateDirectArgumentsDuringExit() ==>

DFGOSRExit.cpp's createDirectArgumentsDuringExit()

DFGOperations.cpp's operationCreateClonedArgumentsDuringExit() ==>

DFGOSRExit.cpp's createClonedArgumentsDuringExit()

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssembler.cpp:

(JSC::stdFunctionCallback):

  • assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printCallback):

  • assembler/ProbeContext.h:

(JSC::Probe::CPUState::gpr const):
(JSC::Probe::CPUState::spr const):
(JSC::Probe::Context::Context):
(JSC::Probe::Context::arg):
(JSC::Probe::Context::gpr):
(JSC::Probe::Context::spr):
(JSC::Probe::Context::fpr):
(JSC::Probe::Context::gprName):
(JSC::Probe::Context::sprName):
(JSC::Probe::Context::fprName):
(JSC::Probe::Context::gpr const):
(JSC::Probe::Context::spr const):
(JSC::Probe::Context::fpr const):
(JSC::Probe::Context::pc):
(JSC::Probe::Context::fp):
(JSC::Probe::Context::sp):
(JSC::Probe:: const): Deleted.

  • assembler/ProbeFrame.h: Added.

(JSC::Probe::Frame::Frame):
(JSC::Probe::Frame::getArgument):
(JSC::Probe::Frame::getOperand):
(JSC::Probe::Frame::get):
(JSC::Probe::Frame::setArgument):
(JSC::Probe::Frame::setOperand):
(JSC::Probe::Frame::set):

  • assembler/ProbeStack.cpp:

(JSC::Probe::Page::Page):

  • assembler/ProbeStack.h:

(JSC::Probe::Page::get):
(JSC::Probe::Page::set):
(JSC::Probe::Page::physicalAddressFor):
(JSC::Probe::Stack::lowWatermark):
(JSC::Probe::Stack::get):
(JSC::Probe::Stack::set):

  • bytecode/ArithProfile.cpp:
  • bytecode/ArithProfile.h:
  • bytecode/ArrayProfile.h:

(JSC::ArrayProfile::observeArrayMode):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::updateOSRExitCounterAndCheckIfNeedToReoptimize):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addressOfOSRExitCounter): Deleted.

  • bytecode/ExecutionCounter.h:

(JSC::ExecutionCounter::hasCrossedThreshold const):
(JSC::ExecutionCounter::setNewThresholdForOSRExit):

  • bytecode/MethodOfGettingAValueProfile.cpp:

(JSC::MethodOfGettingAValueProfile::reportValue):

  • bytecode/MethodOfGettingAValueProfile.h:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::findPC): Deleted.

  • dfg/DFGJITCode.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::jsValueFor):
(JSC::DFG::restoreCalleeSavesFor):
(JSC::DFG::saveCalleeSavesFor):
(JSC::DFG::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::saveOrCopyCalleeSavesFor):
(JSC::DFG::createDirectArgumentsDuringExit):
(JSC::DFG::createClonedArgumentsDuringExit):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::emitRestoreArguments):
(JSC::DFG::OSRExit::executeOSRExit):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
(JSC::DFG::printOSRExit):
(JSC::DFG::OSRExit::setPatchableCodeOffset): Deleted.
(JSC::DFG::OSRExit::getPatchableCodeOffsetAsJump const): Deleted.
(JSC::DFG::OSRExit::codeLocationForRepatch const): Deleted.
(JSC::DFG::OSRExit::correctJump): Deleted.
(JSC::DFG::OSRExit::emitRestoreArguments): Deleted.
(JSC::DFG::OSRExit::compileOSRExit): Deleted.
(JSC::DFG::OSRExit::compileExit): Deleted.
(JSC::DFG::OSRExit::debugOperationPrintSpeculationFailure): Deleted.

  • dfg/DFGOSRExit.h:

(JSC::DFG::OSRExitState::OSRExitState):
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):

  • dfg/DFGOSRExitCompilerCommon.cpp:
  • dfg/DFGOSRExitCompilerCommon.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGThunks.cpp:

(JSC::DFG::osrExitThunkGenerator):
(JSC::DFG::osrExitGenerationThunkGenerator): Deleted.

  • dfg/DFGThunks.h:
  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::debugCall): Deleted.

  • jit/AssemblyHelpers.h:
  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • profiler/ProfilerOSRExit.h:

(JSC::Profiler::OSRExit::incCount):

  • runtime/JSCJSValue.h:
  • runtime/JSCJSValueInlines.h:
  • runtime/VM.h:
5:24 PM Changeset in webkit [221773] by aestes@apple.com
  • 11 edits in trunk/Source

[Mac] Upstream QTKit-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176472

Reviewed by Eric Carlson.

Source/WebCore:

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::disableComponentsOnce):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::hasClosedCaptions const):
(WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
(WebCore::selectPreferredAlternateTrackForMediaType):
(WebCore::selectPreferredAlternates):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::mimeModernTypesCache):
(WebCore::MediaPlayerPrivateQTKit::originsInMediaCache):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCache):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForOrigins):
(WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin const):
(WebCore::MediaPlayerPrivateQTKit::movieLoadType const):
(WebCore::MediaPlayerPrivateQTKit::canSaveMediaData const):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/mac/WebVideoFullscreenHUDWindowController.mm:

(createMediaUIControl):
(createControlWithMediaUIControlType):
(createMediaUIBackgroundView):
(-[WebVideoFullscreenHUDWindowController windowDidLoad]):

Source/WebCore/PAL:

  • pal/spi/mac/QTKitSPI.h:

Source/WebKit:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

4:23 PM Changeset in webkit [221772] by commit-queue@webkit.org
  • 24 edits in trunk

Align FetchResponse and FetchRequest body handling
https://bugs.webkit.org/show_bug.cgi?id=176539

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-07
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:
  • web-platform-tests/fetch/api/request/request-consume-expected.txt:
  • web-platform-tests/fetch/api/request/request-idl-expected.txt:
  • web-platform-tests/fetch/api/request/request-structure-expected.txt:
  • web-platform-tests/fetch/api/response/response-consume-empty-expected.txt:
  • web-platform-tests/fetch/api/response/response-consume-expected.txt:
  • web-platform-tests/url/urlencoded-parser-expected.txt:

Source/WebCore:

Covered by rebased tests.

Removing most of FetchResponse JS Builtins now that ReadableStream has full support.
Implementing FetchResponse body cloning through ReadableStream.
Cloning a loading FetchResponse still requires to create a ReadableStream for the purpose of teeing.

Moving exposure of the body from FetchResponse to FetchBodyOwner.
This is controlled by a boolean flag set according response tainting.

Moving handling of body ReadableStream consuming from FetchResponse to FetchBodyConsumer.
For that purpose, a loading boolean flag is added to FetchBodyConsumer so that it will resolve consume promises
when loading is finished.

Added support for getting a body in case the request/response body is already consumed.
In that case, a locked ReadableStream is returned.

  • Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::doMatch):
(WebCore::DOMCache::matchAll):

  • Modules/fetch/FetchBody.h:

(WebCore::FetchBody::loadingBody):
(WebCore::FetchBody::FetchBody):

  • Modules/fetch/FetchBody.idl:
  • Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::resolve):
(WebCore::FetchBodyConsumer::loadingFailed):
(WebCore::FetchBodyConsumer::loadingSucceeded):

  • Modules/fetch/FetchBodyConsumer.h:

(WebCore::FetchBodyConsumer::setAsLoading):

  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):
(WebCore::FetchBodyOwner::readableStream):

  • Modules/fetch/FetchBodyOwner.h:

(WebCore::FetchBodyOwner::isBodyNullOrOpaque const):
(WebCore::FetchBodyOwner::setBodyAsOpaque):
(WebCore::FetchBodyOwner::isBodyOpaque const):

  • Modules/fetch/FetchInternals.js:

(fillFetchHeaders):

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::clone):
(WebCore::FetchResponse::fetch):
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
(WebCore::FetchResponse::setBodyData):
(WebCore::FetchResponse::consumeChunk):
(WebCore::FetchResponse::consumeBodyAsStream):

  • Modules/fetch/FetchResponse.h:
  • Modules/fetch/FetchResponse.idl:
  • Modules/fetch/FetchResponse.js:

(initializeFetchResponse):

  • bindings/js/ReadableStream.cpp:

(WebCore::ReadableStream::create):
(WebCore::ReadableStream::lock):

  • bindings/js/ReadableStream.h:
  • bindings/js/WebCoreBuiltinNames.h:
4:18 PM Changeset in webkit [221771] by achristensen@apple.com
  • 9 edits in trunk/Source/WebKit

Clean up API::UIClient
https://bugs.webkit.org/show_bug.cgi?id=176568

Reviewed by Brady Eidson.

We don't need createNewPage and createNewPageAsync.
An async version can support synchronous delegate calls by just calling the completion handler synchronously.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::createNewPage):
(API::UIClient::createNewPageAsync): Deleted.
(API::UIClient::canCreateNewPageAsync): Deleted.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/glib/WebKitUIClient.cpp:
  • UIProcess/API/glib/WebKitUIClient.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::createNewPage):
(WebKit::UIDelegate::UIClient::createNewPageCommon): Deleted.
(WebKit::UIDelegate::UIClient::canCreateNewPageAsync): Deleted.
(WebKit::UIDelegate::UIClient::createNewPageAsync): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createNewPage):

  • UIProcess/WebPageProxy.h:
4:16 PM Changeset in webkit [221770] by achristensen@apple.com
  • 6 edits in trunk/Source/WebKit

Make DragControllerAction an enum class
https://bugs.webkit.org/show_bug.cgi?id=176565

Reviewed by Andy Estes.

  • Shared/DragControllerAction.h:

(): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDragOperation):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
4:13 PM Changeset in webkit [221769] by msaboff@apple.com
  • 18 edits
    3 adds in trunk

Add support for RegExp named capture groups
https://bugs.webkit.org/show_bug.cgi?id=176435

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added parsing for both naming a captured parenthesis as well and using a named group in
a back reference. Also added support for using named groups with String.prototype.replace().

This patch does not throw Syntax Errors as described in the current spec text for the two
cases of malformed back references in String.prototype.replace() as I believe that it
is inconsistent with the current semantics for handling of other malformed replacement
tokens. I filed an issue for the requested change to the proposed spec and also filed
a FIXME bug https://bugs.webkit.org/show_bug.cgi?id=176434.

This patch does not implement strength reduction in the optimizing JITs for named capture
groups. Filed https://bugs.webkit.org/show_bug.cgi?id=176464.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::haveABadTime):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::regExpMatchesArrayWithGroupsStructure const):

  • runtime/RegExp.cpp:

(JSC::RegExp::finishCreation):

  • runtime/RegExp.h:
  • runtime/RegExpMatchesArray.cpp:

(JSC::createStructureImpl):
(JSC::createRegExpMatchesArrayWithGroupsStructure):
(JSC::createRegExpMatchesArrayWithGroupsSlowPutStructure):

  • runtime/RegExpMatchesArray.h:

(JSC::createRegExpMatchesArray):

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::replaceUsingRegExpSearch):

  • yarr/YarrParser.h:

(JSC::Yarr::Parser::CharacterClassParserDelegate::atomNamedBackReference):
(JSC::Yarr::Parser::parseEscape):
(JSC::Yarr::Parser::parseParenthesesBegin):
(JSC::Yarr::Parser::tryConsumeUnicodeEscape):
(JSC::Yarr::Parser::tryConsumeIdentifierCharacter):
(JSC::Yarr::Parser::isIdentifierStart):
(JSC::Yarr::Parser::isIdentifierPart):
(JSC::Yarr::Parser::tryConsumeGroupName):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::atomParenthesesSubpatternBegin):
(JSC::Yarr::YarrPatternConstructor::atomNamedBackReference):
(JSC::Yarr::YarrPattern::errorMessage):

  • yarr/YarrPattern.h:

(JSC::Yarr::YarrPattern::reset):

  • yarr/YarrSyntaxChecker.cpp:

(JSC::Yarr::SyntaxChecker::atomParenthesesSubpatternBegin):
(JSC::Yarr::SyntaxChecker::atomNamedBackReference):

Source/WebCore:

Implemented stub routines to support named capture groups. These are no-ops
just like for number capture group.

No new tests as this is covered by existing tests.

  • contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::PatternParser::atomNamedBackReference):
(WebCore::ContentExtensions::PatternParser::atomParenthesesSubpatternBegin):

LayoutTests:

New regression tests.

  • js/regexp-named-capture-groups-expected.txt: Added.
  • js/regexp-named-capture-groups.html: Added.
  • js/script-tests/regexp-named-capture-groups.js: Added.
4:11 PM Changeset in webkit [221768] by mmaxfield@apple.com
  • 44 edits
    5 moves
    1 delete in trunk/Source

[PAL] Unify PlatformUserPreferredLanguages.h with Language.h
https://bugs.webkit.org/show_bug.cgi?id=176561

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

  • runtime/IntlObject.cpp:

(JSC::defaultLocale):

Source/WebCore:

No new tests because there is no behavior change.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilitySVGElement.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSWorkerGlobalScopeBase.cpp:
  • dom/Document.cpp:
  • html/HTMLInputElement.cpp:
  • html/HTMLMediaElement.cpp:
  • html/shadow/MediaControlElements.cpp:
  • html/track/TrackBase.cpp:
  • page/CaptionUserPreferences.cpp:
  • page/CaptionUserPreferencesMediaAF.cpp:
  • page/DOMWindow.cpp:
  • page/Navigator.cpp:
  • page/NavigatorBase.cpp:
  • platform/graphics/FontGenericFamilies.cpp:
  • platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
  • platform/network/HTTPParsers.cpp:
  • platform/text/PlatformLocale.h:
  • platform/text/cf/HyphenationCF.cpp:
  • platform/text/mac/LocaleMac.mm:
  • svg/SVGTests.cpp:
  • testing/InternalSettings.cpp:
  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::userPreferredLanguages const):
(WebCore::Internals::setUserPreferredLanguages):

Source/WebKit:

  • UIProcess/WebProcessPool.cpp:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::userPreferredLanguagesChanged const):

Source/WebKitLegacy/mac:

  • Misc/WebNSUserDefaultsExtras.mm:

Source/WTF:

WebCore/platform/Language was the only* user of PlatformUserPreferredLanguages (with 1 exception).
That exception is that JavaScriptCore needed the functionality of WebCore/platform/Language, but it
couldn't get it because of the layering violation, so instead it erroneously called into
PlatformUserPreferredLanguages instead. This patch merges these two files into WTF so JSC gets the
right function and the PAL effort has one less file to move from WebCore/platform into PAL.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/Language.cpp: Renamed from Source/WebCore/platform/Language.cpp.

(WTF::addLanguageChangeObserver):
(WTF::userPreferredLanguages):

  • wtf/Language.h: Renamed from Source/WebCore/platform/Language.h.
  • wtf/PlatformGTK.cmake:
  • wtf/PlatformJSCOnly.cmake:
  • wtf/PlatformMac.cmake:
  • wtf/PlatformUserPreferredLanguages.h: Removed.
  • wtf/PlatformWPE.cmake:
  • wtf/PlatformWin.cmake:
  • wtf/cf/LanguageCF.cpp: Renamed from Source/WTF/wtf/PlatformUserPreferredLanguagesMac.mm.

(WTF::httpStyleLanguageCode):
(WTF::languagePreferencesDidChange):
(WTF::platformUserPreferredLanguages):

  • wtf/unix/LanguageUnix.cpp: Renamed from Source/WTF/wtf/PlatformUserPreferredLanguagesUnix.cpp.
  • wtf/win/LanguageWin.cpp: Renamed from Source/WTF/wtf/PlatformUserPreferredLanguagesWin.cpp.
4:06 PM Changeset in webkit [221767] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Remove entry from CacheStorageEngineConnection lock map when unlocking a Cache
https://bugs.webkit.org/show_bug.cgi?id=176548

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-07
Reviewed by Alex Christensen.

  • NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::dereference):

3:49 PM Changeset in webkit [221766] by Chris Dumez
  • 16 edits in trunk

[WK2] Add C API to retrieve the originating page of a WKDownload
https://bugs.webkit.org/show_bug.cgi?id=176557
<rdar://problem/34314776>

Reviewed by Alex Christensen.

Source/WebKit:

Add C API to retrieve the original page of a WKDownload. This is the C API equivalent to
_WKDownload.originatingWebView which already exists in ObjC. The pointer is weak so as
to not keep alive the page for the duration of the download.

  • UIProcess/API/C/WKDownload.cpp:

(WKDownloadGetOriginatingPage):

  • UIProcess/API/C/WKDownload.h:
  • UIProcess/API/Cocoa/_WKDownload.mm:

(-[_WKDownload originatingWebView]):

  • UIProcess/API/Cocoa/_WKDownloadInternal.h:
  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::originatingPage const):
(WebKit::DownloadProxy::setOriginatingPage):

  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::download):
(WebKit::WebProcessPool::resumeDownload):
(WebKit::WebProcessPool::createDownloadProxy):

  • UIProcess/WebProcessPool.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::handleDownloadRequest):

  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::handleDownloadRequest):

Tools:

Add layout test coverage for both the ObjC and C API.

  • TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:

(TestWebKitAPI::decideDestinationWithSuggestedFilename):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(-[RedirectedDownloadDelegate _downloadDidStart:]):
(TEST):

3:22 PM Changeset in webkit [221765] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Augmented Inspector: Provide a way to inspect a DOM Node (DOM.inspect)
https://bugs.webkit.org/show_bug.cgi?id=176563
<rdar://problem/19639583>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-07
Reviewed by Matt Baker.

Source/JavaScriptCore:

  • inspector/protocol/DOM.json:

Add an event that is useful for augmented inspectors to inspect
a node. Web pages will still prefer Inspector.inspect.

Source/WebInspectorUI:

  • UserInterface/Base/Main.js:

(WI.contentLoaded):
Always create the element search toolbar icon. Only show it if the DOM domain
is available. With augmented agents the DOM domain may be activated later.

  • UserInterface/Protocol/DOMObserver.js:

(WI.DOMObserver.prototype.inspect):
Select the node in the DOM tree outline.

LayoutTests:

  • inspector/dom/inspect-expected.txt: Added.
  • inspector/dom/inspect.html: Added.

Test the frontend on receiving DOM.inspect events.

3:20 PM Changeset in webkit [221764] by achristensen@apple.com
  • 17 edits in trunk/Source/WebKit

Clean up Geolocation request handling
https://bugs.webkit.org/show_bug.cgi?id=176562

Reviewed by Tim Horton.

Instead of passing a GeolocationPermissionRequestProxy& to each client and returning a bool if the request will be handled,
pass a Function<void(bool)>&& completionHandler and return the function if it won't be handled.
This allows to temporarily support our UIClient/PageClient hybrid design while moving towards a sane design.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::Function<void):
(API::UIClient::decidePolicyForGeolocationPermissionRequest): Deleted.

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKGeolocationPermissionRequest.cpp:

(WKGeolocationPermissionRequestGetTypeID):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/GeolocationPermissionRequestProxy.cpp:

(WebKit::GeolocationPermissionRequestProxy::allow):
(WebKit::GeolocationPermissionRequestProxy::deny):
(WebKit::GeolocationPermissionRequestProxy::invalidate):

  • UIProcess/GeolocationPermissionRequestProxy.h:

(WebKit::GeolocationPermissionRequest::create):
(WebKit::GeolocationPermissionRequest::allow):
(WebKit::GeolocationPermissionRequest::deny):
(WebKit::GeolocationPermissionRequest::GeolocationPermissionRequest):

  • UIProcess/PageClient.h:

(WebKit::PageClient::decidePolicyForGeolocationPermissionRequest): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::Function<void):
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest): Deleted.

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKGeolocationProviderIOS.h:
  • UIProcess/ios/WKGeolocationProviderIOS.mm:

(-[WKGeolocationProviderIOS decidePolicyForGeolocationRequestFromOrigin:frame:completionHandler:view:]):
(-[WKGeolocationProviderIOS geolocationAuthorizationGranted]):
(-[WKGeolocationProviderIOS geolocationAuthorizationDenied]):
(-[WKWebAllowDenyPolicyListener initWithCompletionHandler:]):
(-[WKWebAllowDenyPolicyListener allow]):
(-[WKWebAllowDenyPolicyListener deny]):
(-[WKGeolocationProviderIOS decidePolicyForGeolocationRequestFromOrigin:frame:request:view:]): Deleted.
(-[WKWebAllowDenyPolicyListener initWithPermissionRequestProxy:]): Deleted.

3:08 PM Changeset in webkit [221763] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Marked http/tests/misc/delete-frame-during-readystatechange.html as flaky on Windows.
https://bugs.webkit.org/show_bug.cgi?id=176564

Unreviewed test gardening.

  • platform/win/TestExpectations:
3:01 PM Changeset in webkit [221762] by dino@apple.com
  • 11 edits
    6 adds in trunk

[WebGL] accelerated texImage2D for video doesn't respect flipY
https://bugs.webkit.org/show_bug.cgi?id=176491
<rdar://problem/33833511>

Reviewed by Jer Noble.

Source/WebCore:

Previously, if UNPACK_FLIP_Y_WEBGL was set to true, we'd either fall
back to software or fail to upload texture data. Fix this by intercepting
the texImage2D call, checking the orientation of the video, and running
a small shader program to flip it if necessary.

While there, implement UNPACK_PREMULTIPLY_ALPHA_WEBGL as well, although
none of our media decoders support video with alpha, so unfortunately
this will have no visible change.

Tests: fast/canvas/webgl/texImage2D-video-flipY-false.html

fast/canvas/webgl/texImage2D-video-flipY-true.html

  • platform/cocoa/CoreVideoSoftLink.cpp: Add link to CVOpenGL(ES)TextureGetCleanTexCoords,

which is used to check the orientation of the source video.

  • platform/cocoa/CoreVideoSoftLink.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::copyVideoTextureToPlatformTexture): We can
now handle flipped or premultiplied requests.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::copyVideoTextureToPlatformTexture): Ditto.

  • platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::VideoTextureCopierCV::VideoTextureCopierCV): Rename readFramebuffer to
simply framebuffer.
(WebCore::VideoTextureCopierCV::~VideoTextureCopierCV): Delete the program and buffer
if they were created.
(WebCore::VideoTextureCopierCV::initializeContextObjects): Sets up the shader program
and the vertex buffer for drawing. Also records the location of the uniforms.
(WebCore::VideoTextureCopierCV::copyVideoTextureToPlatformTexture): Create a new
framebuffer object, and render the video texture into that framebuffer using a
shader that can flip the coordinates.
(WebCore::VideoTextureCopierCV::GC3DStateSaver::GC3DStateSaver): Helper to restore
the state of the user's GraphicsContext3D while we're intercepting calls.
(WebCore::VideoTextureCopierCV::GC3DStateSaver::~GC3DStateSaver):

  • platform/graphics/cv/VideoTextureCopierCV.h:
  • platform/graphics/GraphicsContext3D.h: Add two new entry points, for direct shader

compilation and attribute access. This avoids going through ANGLE.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::compileShaderDirect):
(WebCore::GraphicsContext3D::getAttribLocationDirect):

LayoutTests:

Test that exercises UNPACK_FLIP_Y_WEBGL for video on the accelerated
path.

  • fast/canvas/webgl/resources/orientation-flipped.mp4: Added.
  • fast/canvas/webgl/resources/orientation-normal.mp4: Added.
  • fast/canvas/webgl/texImage2D-video-flipY-false-expected.txt: Added.
  • fast/canvas/webgl/texImage2D-video-flipY-false.html: Added.
  • fast/canvas/webgl/texImage2D-video-flipY-true-expected.txt: Added.
  • fast/canvas/webgl/texImage2D-video-flipY-true.html: Added.
  • platform/ios/TestExpectations:
2:58 PM Changeset in webkit [221761] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/resource-timing/rt-cors.worker.html as slow.

Unreviewed test gardening.

  • platform/win/TestExpectations:
2:57 PM Changeset in webkit [221760] by achristensen@apple.com
  • 5 edits in trunk/Source/WebKit

Allow modern decoding of enums and OptionSets
https://bugs.webkit.org/show_bug.cgi?id=176480

Reviewed by Andy Estes.

  • Platform/IPC/ArgumentCoders.h:

(IPC::ArgumentCoder<OptionSet<T>>::decode):

  • Platform/IPC/Decoder.h:

(IPC::Decoder::operator>>):

  • Platform/IPC/Encoder.h:
  • Shared/WebsitePolicies.h:

(WebKit::WebsitePolicies::encode const):
(WebKit::WebsitePolicies::decode):

2:52 PM Changeset in webkit [221759] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked media/video-controls-drop-and-restore-timeline.html as flaky on macOS WK2.
https://bugs.webkit.org/show_bug.cgi?id=176122

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:38 PM Changeset in webkit [221758] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-query-exception-order.html as flaky on El Capitan.
https://bugs.webkit.org/show_bug.cgi?id=176229

Unreviewed test gardening.

  • platform/mac-elcapitan/TestExpectations:
2:18 PM Changeset in webkit [221757] by fpizlo@apple.com
  • 7 edits
    1 add in trunk/Tools

WSL Node.prototype.visit should probably do memoization
https://bugs.webkit.org/show_bug.cgi?id=176286

Reviewed by Mark Lam.

Visitors can sometimes revisit the same thing. For example, we may visit a FuncDef because it belongs
to Program and we may visit it again because a CallExpression resolved to it. That's just plain silly.

Our tests don't currently do this, so it's not a performance problem, yet. Also, we usually avoid that
kind of repetitive visiting inside the visitor implementations. But as far as I can tell, this is an
emergent property rather than a deliberate design.

This change just makes the policy super explicit. If you visit something more than once with the same
visitor, you get the same answer back. This is achieved by means of a memo table inside each visitor.

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/FuncInstantiator.js:
  • WebGPUShadingLanguageRI/Node.js:

(Node.prototype.visit):

  • WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter):

  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/Visitor.js:

(Visitor):

  • WebGPUShadingLanguageRI/VisitorBase.js: Added.

(VisitorBase):

1:55 PM Changeset in webkit [221756] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas RecordingAction tree outline virtualization is broken
https://bugs.webkit.org/show_bug.cgi?id=176547

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype.updateVirtualizedElements.walk):
(WI.TreeOutline.prototype.updateVirtualizedElements):
Pass the current count to each recursive call of walk so that the cumulative index of a
TreeElement in any given sub-tree is correct.
Drive-by: if there is a focused TreeElement when scrolling, only change the current
scrollTop if it is not already visible. Also rewrote some loops for clarity.

1:46 PM Changeset in webkit [221755] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

1:41 PM Changeset in webkit [221754] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.2.9

Tag Safari-604.2.9.

1:21 PM Changeset in webkit [221753] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Move more code from ScrollingTreeScrollingNodeDelegateIOS to ScrollingTreeScrollingNodeDelegate
https://bugs.webkit.org/show_bug.cgi?id=174130

Reviewed by Simon Fraser.

  • UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h: Remove some members, headers and pre-declaration that are moved into the delegate. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollLayer): Deleted.
  • UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm: Remove some headers and WKOverflowScrollViewDelegate since they are moved into the delegate file. Also fix the comment to closing the WebKit namespace. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::~ScrollingTreeOverflowScrollingNodeIOS): Remove some code moved into the delegate and call the corresponding helper function to preserve the current behavior. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateBeforeChildren): Ditto. Note that it is only necessary to cast the parameter to a ScrollingStateTreeNode. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateAfterChildren): Ditto. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterAncestorChange): Ditto. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollPosition): Ditto. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::setScrollLayerPosition): Ditto. (-[WKOverflowScrollViewDelegate initWithScrollingTreeNodeDelegate:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewDidScroll:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewWillBeginDragging:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewDidEndDecelerating:]): Deleted.
  • UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h: Import headers and members from ScrollingTreeOverflowScrollingNodeIOS. Define new helper functions for the code imported from ScrollingTreeOverflowScrollingNodeIOS. Remove the friendship with ScrollingTreeOverflowScrollingNodeIOS and only makes public the function used by that class. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollLayer): This function is moved from ScrollingTreeOverflowScrollingNodeIOS.
  • UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: Add headers, WKOverflowScrollViewDelegate (renamed WKScrollingNodeScrollViewDelegate) and some helper code imported from ScrollingTreeOverflowScrollingNodeIOS. (-[WKScrollingNodeScrollViewDelegate scrollViewDidScroll:]): Moved from ScrollingTreeOverflowScrollingNodeIOS. (-[WKScrollingNodeScrollViewDelegate scrollViewWillBeginDragging:]): Ditto. (-[WKScrollingNodeScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Ditto. (-[WKScrollingNodeScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]): Ditto. (-[WKScrollingNodeScrollViewDelegate scrollViewDidEndDecelerating:]): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::~ScrollingTreeScrollingNodeDelegateIOS): Import code from ScrollingTreeOverflowScrollingNodeIOS. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::resetScrollViewDelegate): New helper function importing code from ScrollingTreeOverflowScrollingNodeIOS. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateBeforeChildren): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateAfterChildren): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateLayersAfterAncestorChange): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollPosition): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::setScrollLayerPosition): Ditto.

Patch by Frederic Wang <fwang@igalia.com> on 2017-09-07

1:12 PM Changeset in webkit [221752] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win] tests/security/contentSecurityPolicy/report-only.php is flaky.
https://bugs.webkit.org/show_bug.cgi?id=176541

Reviewed by Brent Fulgham.

The function call rename will sometimes fail on Windows because one of the files is
opened by another process. If rename fails, wait, and try again.

  • http/tests/security/contentSecurityPolicy/resources/save-report.php:
1:12 PM Changeset in webkit [221751] by wenson_hsieh@apple.com
  • 6 edits
    1 add in trunk

[Directory Upload] Extend drag and drop support to iOS
https://bugs.webkit.org/show_bug.cgi?id=176492
<rdar://problem/34291584>

Reviewed by Tim Horton.

Source/WebCore:

Adds support for accepting dropped folders on iOS.

Tests: DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry

DataInteractionTests.ExternalSourceDataTransferItemGetPlainTextFileAsEntry

  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::supportedFileUploadPasteboardTypes):

Add "public.folder" as a compatible pasteboard type for drops on iOS. This means file inputs and custom drop
targets that preventDefault() will, by default, be able to accept incoming folders.

  • platform/ios/WebItemProviderPasteboard.mm:

(linkTemporaryItemProviderFilesToDropStagingDirectory):

Tweak temporaryFileURLForDataInteractionContent to also hard link UIKit's temporary files instead, and return
a non-null destination URL only if the necessary file operations succeeded. Also renames this helper to
linkTemporaryItemProviderFilesToDropStagingDirectory to better reflect its new purpose. This makes logic much
cleaner at the call site, which no longer checks against various conditions before proceeding to set the data
transfer URL.

(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout:]):
(temporaryFileURLForDataInteractionContent): Deleted.

Tools:

Adds two new iOS drag and drop unit tests, which both exercise the DataTransferItem.webKitGetAsEntry codepath
upon drop. (...)GetFolderAsEntry creates a new folder in the temporary directory and uses it to generate an item
provider. This item provider is then dropped over a custom drop handling element, which writes information about
the exposed FileSystemEntries into a textarea. (...)ExternalSourceDataTransferItemGetPlainTextFileAsEntry does
something similar, except that it only drops a plain text file instead.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/DataTransferItem-getAsEntry.html: Added.

Introduce a new test page that dumps information about DataTransferItems' file system entries upon drop.

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(runTestWithTemporaryTextFile):
(runTestWithTemporaryFolder):

Introduce helpers to set up and tear down temporary files and folders over the duration of a test.

(TestWebKitAPI::setUpTestWebViewForDataTransferItems):
(TestWebKitAPI::TEST):

12:56 PM Changeset in webkit [221750] by fpizlo@apple.com
  • 5 edits
    2 adds in trunk/Tools

WSL should check recursion
https://bugs.webkit.org/show_bug.cgi?id=176553

Reviewed by Michael Saboff and Mark Lam.

This adds a recursion checker. Previously, we would only check for recursion during inlining, but that
generally only happens when we call the function.

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/CheckRecursion.js: Added.

(checkRecursion):

  • WebGPUShadingLanguageRI/Prepare.js:

(prepare):

  • WebGPUShadingLanguageRI/RecursionChecker.js: Added.

(RecursionChecker):
(RecursionChecker.prototype.visitFuncDef):
(RecursionChecker.prototype.visitCallExpression):

  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/Test.js:

(TEST_simpleRecursion):

12:51 PM Changeset in webkit [221749] by Chris Dumez
  • 21 edits
    2 adds in trunk

[WK2] Notify client when downloads are redirected
https://bugs.webkit.org/show_bug.cgi?id=176481
<rdar://problem/34309065>

Reviewed by Geoffrey Garen.

Source/WebKit:

Notify client when downloads are redirected via both ObjC and C
API.

  • NetworkProcess/Downloads/Download.cpp:

(WebKit::Download::willSendRedirectedRequest):

  • NetworkProcess/Downloads/Download.h:
  • NetworkProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:willSendRequest:redirectResponse:]):

  • UIProcess/API/APIDownloadClient.h:

(API::DownloadClient::willSendRequest):

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetDownloadClient):

  • UIProcess/API/C/WKContextDownloadClient.h:
  • UIProcess/API/Cocoa/_WKDownloadDelegate.h:
  • UIProcess/Cocoa/DownloadClient.h:
  • UIProcess/Cocoa/DownloadClient.mm:

(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::willSendRequest):

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::willSendRequest):

  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/Downloads/DownloadProxy.messages.in:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::showContextMenuWithItems):
Set menu proxy before calling menuFromProposedMenu() client delegate.
This allows me to perform one of the menu item's action from the
menuFromProposedMenu() client delegate in my API test.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
(-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
(-[RedirectedDownloadDelegate _download:didReceiveServerRedirectToURL:]):
(-[RedirectedDownloadDelegate _downloadDidFinish:]):
(TEST):
Add API test coverage.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::downloadDidReceiveServerRedirectToURL):

  • WebKitTestRunner/TestController.h:

Add layout test infrastructure.

LayoutTests:

Add layout test coverage.

  • http/tests/download/anchor-download-redirect-expected.txt: Added.
  • http/tests/download/anchor-download-redirect.html: Added.
  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk1/TestExpectations:
12:39 PM Changeset in webkit [221748] by webkit@devinrousso.com
  • 32 edits in trunk/Source/WebInspectorUI

Unreviewed, change my copyright email.

  • Scripts/copy-user-interface-resources.pl:
  • UserInterface/Controllers/CodeMirrorSpringEditingController.js:
  • UserInterface/Images/AnimationPlayStatePaused.svg:
  • UserInterface/Images/AnimationPlayStateRunning.svg:
  • UserInterface/Images/CSSVariable.svg:
  • UserInterface/Images/ListStylePositionInside.svg:
  • UserInterface/Images/ListStylePositionOutside.svg:
  • UserInterface/Images/StyleRule.svg:
  • UserInterface/Images/StyleRulePseudoElement.svg:
  • UserInterface/Models/Collection.js:
  • UserInterface/Models/ResourceCollection.js:
  • UserInterface/Views/CollectionContentView.css:
  • UserInterface/Views/CollectionContentView.js:
  • UserInterface/Views/ContextMenuUtilities.js:
  • UserInterface/Views/GeneralTabBarItem.js:
  • UserInterface/Views/GradientEditor.css:
  • UserInterface/Views/GradientEditor.js:
  • UserInterface/Views/InlineSwatch.css:
  • UserInterface/Views/InlineSwatch.js:
  • UserInterface/Views/PinnedTabBarItem.js:
  • UserInterface/Views/SettingsTabContentView.css:
  • UserInterface/Views/SettingsTabContentView.js:
  • UserInterface/Views/SpringEditor.css:
  • UserInterface/Views/SpringEditor.js:
  • UserInterface/Views/StyleRuleIcons.css:
  • UserInterface/Views/TabBarItem.js:
  • UserInterface/Views/TitleView.css:
  • UserInterface/Views/TitleView.js:
  • UserInterface/Views/VisualStyleBackgroundPicker.css:
  • UserInterface/Views/VisualStyleBackgroundPicker.js:
  • UserInterface/Views/VisualStyleBasicInput.js:
12:31 PM Changeset in webkit [221747] by pvollan@apple.com
  • 3 edits in trunk/JSTests

[Win32] 10 JSC stress tests are failing.
https://bugs.webkit.org/show_bug.cgi?id=176538

Reviewed by Mark Lam.

Skip tests on Windows to make the bots green.

  • ChakraCore.yaml:
  • stress/date-relaxed.js:
12:30 PM Changeset in webkit [221746] by pvollan@apple.com
  • 8 edits in trunk

[Win] fast/canvas/2d.getPath.modification.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=176534

Reviewed by Alex Christensen.

We need to enable Inspector additions at runtime in order to expose the getPath function.

Source/WebKitLegacy/win:

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setDataTransferItemsEnabled):
(WebPreferences::inspectorAdditionsEnabled):
(WebPreferences::setInspectorAdditionsEnabled):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

12:25 PM Changeset in webkit [221745] by fpizlo@apple.com
  • 2 edits
    1 add in trunk/Tools

WSL tests should run in run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=176550

Reviewed by Keith Miller.

  • Scripts/run-javascriptcore-tests:

(runJSCStressTests):

  • WebGPUShadingLanguageRI/wsl-tests.yaml: Added.
12:16 PM Changeset in webkit [221744] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/cross_origin_parentage.html as slow.

Unreviewed test gardening.

  • platform/win/TestExpectations:
12:01 PM Changeset in webkit [221743] by achristensen@apple.com
  • 42 edits in trunk/Source

Modernize Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=176496

Reviewed by Andy Estes.

Source/WebCore:

No change in behavior. Just more references instead of pointers.

  • Modules/geolocation/Geolocation.cpp:

(WebCore::createPositionError):
(WebCore::Geolocation::resetAllGeolocationPermission):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::setError):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):

  • Modules/geolocation/Geolocation.h:
  • Modules/geolocation/GeolocationClient.h:
  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::addObserver):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::requestPermission):
(WebCore::GeolocationController::cancelPermissionRequest):
(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::errorOccurred):
(WebCore::GeolocationController::activityStateDidChange):
(WebCore::provideGeolocationTo):

  • Modules/geolocation/GeolocationController.h:

Source/WebKit:

Making the GeolocationPermissionRequestManager take a reference instead of a pointer
spilled into making the other supplement constructors do the same.

  • NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp:

(WebKit::LegacyCustomProtocolManager::LegacyCustomProtocolManager):
(WebKit::LegacyCustomProtocolManager::startLoading):
(WebKit::LegacyCustomProtocolManager::stopLoading):

  • NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h:
  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::addSupplement):

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::AuthenticationManager):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):

  • Shared/Authentication/AuthenticationManager.h:
  • UIProcess/API/APIUIClient.h:

(API::UIClient::decidePolicyForGeolocationPermissionRequest):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::WebCookieManager):
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookie):
(WebKit::WebCookieManager::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManager::getAllCookies):
(WebKit::WebCookieManager::getCookies):
(WebKit::WebCookieManager::setCookie):
(WebKit::WebCookieManager::setCookies):
(WebKit::WebCookieManager::notifyCookiesDidChange):
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):

  • WebProcess/Cookies/WebCookieManager.h:
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:

(WebKit::GeolocationPermissionRequestManager::GeolocationPermissionRequestManager):
(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):

  • WebProcess/Geolocation/GeolocationPermissionRequestManager.h:
  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::WebGeolocationManager):
(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::setEnableHighAccuracyForPage):
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):
(WebKit::WebGeolocationManager::resetPermissions):

  • WebProcess/Geolocation/WebGeolocationManager.h:
  • WebProcess/MediaCache/WebMediaKeyStorageManager.h:

(WebKit::WebMediaKeyStorageManager::WebMediaKeyStorageManager):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::WebNotificationManager):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):

  • WebProcess/Notifications/WebNotificationManager.h:
  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp:

(WebKit::WebGeolocationClient::requestPermission):
(WebKit::WebGeolocationClient::cancelPermissionRequest):

  • WebProcess/WebCoreSupport/WebGeolocationClient.h:

(WebKit::WebGeolocationClient::WebGeolocationClient):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::addSupplement):

  • WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::UserMediaCaptureManager):

  • WebProcess/cocoa/UserMediaCaptureManager.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebGeolocationClient.h:
  • WebCoreSupport/WebGeolocationClient.mm:

(WebGeolocationClient::requestPermission):
(-[WebGeolocationPolicyListener initWithGeolocation:]):
(-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
(-[WebGeolocationProviderInitializationListener initWithGeolocation:]):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidFailWithMessage:]):

Source/WebKitLegacy/win:

  • WebCoreSupport/WebGeolocationClient.cpp:

(WebGeolocationClient::requestPermission):

  • WebCoreSupport/WebGeolocationClient.h:

(WebGeolocationClient::setEnableHighAccuracy): Deleted.
(WebGeolocationClient::cancelPermissionRequest): Deleted.

  • WebGeolocationPolicyListener.h:
  • WebView.cpp:

(WebView::initWithFrame):
(WebView::geolocationDidFailWithError):

11:52 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
11:22 AM Changeset in webkit [221742] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

[ARM] Building FELightningNEON.cpp fails due to missing {Point,Spot}LightSource declarations
https://bugs.webkit.org/show_bug.cgi?id=176531

Reviewed by Žan Doberšek.

The m_lightSource member is a Ref<LightSource>, and its get() method returns
a reference, therefore the casts have to be done to the corresponding reference
types.

  • platform/graphics/cpu/arm/filters/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon): Adjust casts and member accesses accordingly.

10:56 AM Changeset in webkit [221741] by Lucas Forschler
  • 2 edits in trunk/Tools

bisect-builds started failing with invalid json
https://bugs.webkit.org/show_bug.cgi?id=176478

Once we hit 1000 items in our dynamoDB, we ran into an upper limit on the AWS API Gateway looping mechanism.
This prevented us from doing a body mapping template to reformat the json. This fix is to simply return the raw json,
and adjust the json parsing in our code. The AWS rest API has been fixed, and updated to v2.

This change is for the script which operates against the endpoint.

Reviewed by Aakash Jain.

  • Scripts/bisect-builds:

(get_sorted_revisions):

10:53 AM Changeset in webkit [221740] by fpizlo@apple.com
  • 4 edits in trunk/Tools

[WSL] Rationalize how protocol inheritance deals with type parameters
https://bugs.webkit.org/show_bug.cgi?id=176334

Reviewed by Mark Lam.

This adds a bunch of tests for structs, protocols, and functions interacting in interesting
ways. The most complex of these tests triggers the case where the protocol contains a function
with one type parameter and the real function has more than one. This should give a WTypeError,
and now it does.

  • WebGPUShadingLanguageRI/ProtocolDecl.js:

(ProtocolDecl.prototype.hasHeir): Fix the handling of a mismatch of number of type parameters by actually passing the type parameters and then correctly handling the error.

  • WebGPUShadingLanguageRI/Test.js: Add a bunch of tests for this case and a lot of other protocol cases.

(TEST_protocolMonoSigPolyDef):
(TEST_protocolPolySigPolyDef):
(TEST_protocolDoublePolySigDoublePolyDef):
(TEST_protocolDoublePolySigDoublePolyDefExplicit):
(TEST_protocolMonoPolySigDoublePolyDefExplicit):

  • WebGPUShadingLanguageRI/TypeVariable.js:

(TypeVariable.prototype.get origin): This wasn't implemented before, which made error reporting harder.

10:20 AM Changeset in webkit [221739] by matthew_hanson@apple.com
  • 2 edits in tags/Safari-605.1.5/Source/WebCore/PAL

Cherry-pick r221738. rdar://problem/34296289

10:03 AM Changeset in webkit [221738] by wenson_hsieh@apple.com
  • 2 edits in trunk/Source/WebCore/PAL

[Mac] Stop importing NSFunctionBar_Private.h in NSTouchBarSPI.h on the macOS 10.13+ SDK
https://bugs.webkit.org/show_bug.cgi?id=176521
<rdar://problem/34296289>

Reviewed by Andy Estes.

We don't need to import NSFunctionBar_Private.h when building against the macOS 10.13 SDK, or later. Guard this
header import with an SDK version check.

  • pal/spi/cocoa/NSTouchBarSPI.h:
9:43 AM Changeset in webkit [221737] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] Dashboard test is failing.
https://bugs.webkit.org/show_bug.cgi?id=176527

Reviewed by Brent Fulgham.

Skip test on Windows since WebKitTestRunner is required, but not built on Windows.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestFactory.init):

9:40 AM Changeset in webkit [221736] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked svg/animations/smil-leak-elements.svg as flaky on macOS WK1.
https://bugs.webkit.org/show_bug.cgi?id=174180

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
9:20 AM Changeset in webkit [221735] by commit-queue@webkit.org
  • 2 edits in trunk/PerformanceTests

Optimize the call to browserPrefix() in MotionMark
https://bugs.webkit.org/show_bug.cgi?id=176489

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-09-07
Reviewed by Jon Lee.

This function is expensive and it does not change for the browser. No need
to recalculate it every time it is called; just cache the returned value.

  • MotionMark/resources/extensions.js:

(Utilities.browserPrefix):

9:00 AM Changeset in webkit [221734] by Adrian Perez de Castro
  • 2 edits
    3 adds in trunk

[WPE][CMake] Add "dist" and "distcheck" targets
https://bugs.webkit.org/show_bug.cgi?id=176448

Reviewed by Carlos Garcia Campos.

Add "dist" and "distcheck" CMake targets, which create release tarballs.
These are available only when configuring with -DDEVELOPER_MODE=TRUE.

.:

  • Source/PlatformWPE.cmake: Added.
  • Source/cmake/FindXz.cmake: Added.

Tools:

  • wpe/manifest.txt.in: Added.
8:55 AM Changeset in webkit [221733] by pvollan@apple.com
  • 8 edits in trunk

[Win] Enable DatatransferItems in DRT.
https://bugs.webkit.org/show_bug.cgi?id=176424

Reviewed by Brent Fulgham.

Source/WebKitLegacy/win:

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::QueryInterface):
(WebPreferences::isSecureContextAttributeEnabled):
(WebPreferences::dataTransferItemsEnabled):
(WebPreferences::setDataTransferItemsEnabled):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

8:42 AM Changeset in webkit [221732] by Ryan Haddad
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r221716.

This change caused assertion failures on macOS Debug WK2.

Reverted changeset:

"Fetch's Response.statusText is unexpectedly the full http
status line for HTTP/2 responses"
https://bugs.webkit.org/show_bug.cgi?id=176479
http://trac.webkit.org/changeset/221716

8:39 AM Changeset in webkit [221731] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Update test expectations for failing tests on Windows.

Unreviewed test gardening.

  • platform/win/TestExpectations:
8:30 AM Changeset in webkit [221730] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-605.1.5

Tag Safari-605.1.5.

7:53 AM Changeset in webkit [221729] by matthew_hanson@apple.com
  • 7 edits in trunk/Source

Versioning.

5:57 AM Changeset in webkit [221728] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[EME] CDMClearKey: implement remaining methods of CDMPrivate derivative
https://bugs.webkit.org/show_bug.cgi?id=176495

Reviewed by Xabier Rodriguez-Calvar.

Implement the remaining CDMPrivateClearKey methods, following the
ClearKey specification:

  • server certificates are not supported, but sessions are;
  • 'keyids' init data in JSON format is acceptable;
  • JSON responses are acceptable;
  • session IDs must use the 32-bit integer format.

No new tests -- covered by imported W3C tests that utilize ClearKey.

  • platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::parseJSONObject):
(WebCore::CDMPrivateClearKey::loadAndInitialize):
(WebCore::CDMPrivateClearKey::supportsServerCertificates const):
(WebCore::CDMPrivateClearKey::supportsSessions const):
(WebCore::CDMPrivateClearKey::supportsInitData const):
(WebCore::CDMPrivateClearKey::sanitizeResponse const):
(WebCore::CDMPrivateClearKey::sanitizeSessionId const):

5:14 AM Changeset in webkit [221727] by Carlos Garcia Campos
  • 9 edits
    3 adds in trunk

[GTK] Bump libxml2 version to 1.9.5
https://bugs.webkit.org/show_bug.cgi?id=176502

Reviewed by Carlos Alberto Lopez Perez.

Tools:

It has been released very recently, but it fixes the issues that prevented us from upgrading to 1.9.4.

  • gtk/jhbuild.modules:

LayoutTests:

Rebaselines several tests where only the line number changed in error messages.

  • platform/gtk/fast/dom/adopt-attribute-crash-expected.txt:
  • platform/gtk/fast/parser/xml-colon-entity-expected.txt: Added.
  • platform/gtk/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Added.
  • platform/gtk/fast/xsl/xslt-extra-content-at-end-expected.txt:
  • platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
  • platform/gtk/svg/custom/bug78807-expected.txt: Added.
  • platform/gtk/svg/custom/missing-xlink-expected.txt:
  • platform/gtk/svg/custom/path-bad-data-expected.txt:
  • platform/gtk/svg/custom/use-font-face-crash-expected.txt:
3:43 AM WebDriverStatus created by Carlos Garcia Campos
3:12 AM WebKitGTK/2.18.x edited by tpopela@redhat.com
(diff)
2:17 AM Changeset in webkit [221726] by magomez@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Marking some service-worker related tests as crashing.

  • platform/gtk/TestExpectations:
2:04 AM Changeset in webkit [221725] by Carlos Garcia Campos
  • 996 edits
    1 add in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after r221724.

1:52 AM Changeset in webkit [221724] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Bring back line height rounding when computing font metrics
https://bugs.webkit.org/show_bug.cgi?id=176497

Reviewed by Žan Doberšek.

In r221670 we changed the way we get the metrics to avoid rounding that was causing a negative line gap to be
computed. Since the font metrics value is indeed a float value, we also removed the rounding when setting the
line height. However, this caused some test failures because now we report non integer line heights.

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformInit):

1:40 AM WebKitGTK/2.16.x edited by tpopela@redhat.com
(diff)
1:40 AM WebKitGTK/2.18.x edited by tpopela@redhat.com
(diff)
1:36 AM WebKitGTK/2.16.x edited by Adrian Perez de Castro
(diff)
1:36 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
1:21 AM WebKitGTK/2.16.x edited by Adrian Perez de Castro
(diff)
1:20 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
1:14 AM Changeset in webkit [221723] by Yusuke Suzuki
  • 4 edits in trunk/Source/JavaScriptCore

[JSC] Remove "malloc" and "free" from JSC/API
https://bugs.webkit.org/show_bug.cgi?id=176331

Reviewed by Keith Miller.

Remove "malloc" and "free" manual calls in JSC/API.

  • API/JSValue.mm:

(createStructHandlerMap):

  • API/JSWrapperMap.mm:

(parsePropertyAttributes):
(makeSetterName):
(copyPrototypeProperties):
Use RetainPtr<NSString> to keep NSString. We avoid repeated "char*" to "NSString" conversion.

  • API/ObjcRuntimeExtras.h:

(adoptSystem):
Add adoptSystem to automate calling system free().

(protocolImplementsProtocol):
(forEachProtocolImplementingProtocol):
(forEachMethodInClass):
(forEachMethodInProtocol):
(forEachPropertyInProtocol):
(StringRange::StringRange):
(StringRange::operator const char* const):
(StringRange::get const):
Use CString for backend.

(StructBuffer::StructBuffer):
(StructBuffer::~StructBuffer):
(StringRange::~StringRange): Deleted.
Use fastAlignedMalloc/astAlignedFree to get aligned memory.

12:35 AM Changeset in webkit [221722] by bshafiei@apple.com
  • 7 edits in tags/Safari-605.1.4.0.1/Source

Versioning.

12:32 AM Changeset in webkit [221721] by bshafiei@apple.com
  • 1 copy in tags/Safari-605.1.4.0.1

New Tag.

12:32 AM Changeset in webkit [221720] by Carlos Garcia Campos
  • 27 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline more tests after Freetype version bump in r221670.

  • platform/gtk/editing/execCommand/print-expected.png:
  • platform/gtk/editing/execCommand/print-expected.txt:
  • platform/gtk/fast/forms/large-toggle-elements-expected.png:
  • platform/gtk/fast/forms/large-toggle-elements-expected.txt:
  • platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.png:
  • platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.txt:
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.png:
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
  • platform/gtk/fonts/complex-text-shadows-expected.png:
  • platform/gtk/fonts/complex-text-shadows-expected.txt:
  • platform/gtk/fonts/custom-font-missing-glyphs-expected.png:
  • platform/gtk/fonts/custom-font-missing-glyphs-expected.txt:
  • platform/gtk/fonts/font-face-with-complex-text-expected.png:
  • platform/gtk/fonts/font-face-with-complex-text-expected.txt:
  • platform/gtk/fonts/font-with-no-valid-encoding-expected.png:
  • platform/gtk/fonts/font-with-no-valid-encoding-expected.txt:
  • platform/gtk/fonts/fontconfig-aliasing-settings-expected.png:
  • platform/gtk/fonts/fontconfig-aliasing-settings-expected.txt:
  • platform/gtk/fonts/non-bmp-characters-expected.png:
  • platform/gtk/fonts/non-bmp-characters-expected.txt:
  • platform/gtk/fonts/xsettings_antialias_settings-expected.png:
  • platform/gtk/fonts/xsettings_antialias_settings-expected.txt:
  • platform/gtk/fonts/zero-pixel-sized-fonts-expected.png:
  • platform/gtk/fonts/zero-pixel-sized-fonts-expected.txt:
  • platform/gtk/transitions/svg-text-shadow-transition-expected.png:
  • platform/gtk/transitions/svg-text-shadow-transition-expected.txt:

Sep 6, 2017:

11:20 PM Changeset in webkit [221719] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Temporary disable the changes introduced in r221670 for WPE.

It caused a lot of test failures. Once WPE upgrades to Freetype 2.8 and removes the 2.4.11 patch, we can enable
it again.

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformInit):

10:58 PM Changeset in webkit [221718] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

[GStreamer] Implement MediaPlayerPrivateGStreamerMSE::attempToDecryptWithInstance()
https://bugs.webkit.org/show_bug.cgi?id=176445

Reviewed by Xabier Rodriguez-Calvar.

Implement MediaPlayerPrivateGStreamerMSE::attempToDecryptWithInstance(), also
adding support for dispatching ClearKey keys into the append pipelines.

CDMInstanceClearKey::Key is added, containing key ID and value buffers as well
as the key status value. Vector of keys for a specific CDMInstance is
accessible through the CDMInstanceClearKey::keys() getter.

In MediaPlayerPrivateGStreamerMSE, that Vector is retrieved and then iterated
over, constructing corresponding key ID and key value lists that contain
GstBuffer objects into which each key ID and value data is copied. Both lists
are then set on the 'drm-cipher-clearkey' structure before it's dispatched
against each AppendPipeline object.

  • platform/encryptedmedia/clearkey/CDMClearKey.h:
  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::attemptToDecryptWithInstance):

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
9:23 PM Changeset in webkit [221717] by aakash_jain@apple.com
  • 5 edits in trunk/Websites/perf.webkit.org

Add initSyncers method in BuildbotTriggerable
https://bugs.webkit.org/show_bug.cgi?id=176125

Reviewed by Ryosuke Niwa.

  • tools/sync-buildbot.js:

(syncLoop): Use initSyncers() which returns a promise. Modified to handle the promise.

  • tools/js/buildbot-triggerable.js:

(BuildbotTriggerable): Invokes initSyncers() appropriately.
(BuildbotTriggerable.prototype.initSyncers): Returns a promise which initialize all the syncers.

  • server-tests/tools-buildbot-triggerable-tests.js: Updated tests to handle initSyncers().
  • server-tests/tools-sync-buildbot-integration-tests.js: Ditto.
9:05 PM Changeset in webkit [221716] by commit-queue@webkit.org
  • 3 edits
    7 adds in trunk

Fetch's Response.statusText is unexpectedly the full http status line for HTTP/2 responses
https://bugs.webkit.org/show_bug.cgi?id=176479

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-06
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/wpt/fetch/response-status-text.html

HTTP/2 doesn't include a status reason phrase. So the "status line"
ends up just being the version and status code. Fallback to the empty
string instead of the full line.

  • platform/network/HTTPParsers.cpp:

(WebCore::extractReasonPhraseFromHTTPStatusLine):

LayoutTests:

  • http/wpt/fetch/resources/status-garbage.asis: Added.
  • http/wpt/fetch/resources/status-normal.txt: Added.
  • http/wpt/fetch/resources/status-with-message.asis: Added.
  • http/wpt/fetch/resources/status-without-message.asis: Added.

Various text HTTP responses with different status lines.

  • http/wpt/fetch/response-status-text-expected.txt: Added.
  • http/wpt/fetch/response-status-text.html: Added.

Test the Fetch Response's status / statusText for different HTTP status lines.
The status without a message is similiar to HTTP/2 because HTTP/2 only
has a :status pseudo-header and lacks a reason phrase.

9:02 PM Changeset in webkit [221715] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/Tools

Remove new-run-webkit-httpd as it appears to be old
https://bugs.webkit.org/show_bug.cgi?id=176493

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-06
Reviewed by Alexey Proskuryakov.

  • Scripts/new-run-webkit-httpd: Removed.
8:42 PM Changeset in webkit [221714] by achristensen@apple.com
  • 6 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's pageDidScroll
https://bugs.webkit.org/show_bug.cgi?id=176482
<rdar://problem/29270035>

Reviewed by Tim Horton.
Source/WebKit:


Covered by a new API test!

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::pageDidScroll):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[DidScrollDelegate _webViewDidScroll:]):
(TEST):

8:29 PM Changeset in webkit [221713] by Matt Baker
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Relax the maximum sidebar width
https://bugs.webkit.org/show_bug.cgi?id=175808
<rdar://problem/34005339>

Reviewed by Devin Rousso.

This patch introduces a constant, minimumContentBrowserWidth, which
constrains the maximum width of either sidebar:

maxSidebarWidth = window.innerWidth - minimumContentBrowserWidth - otherSidebarWidth

A value of 100px for minimumContentBrowserWidth leaves enough space for
three NavigationItems at their minimum width (32px), with a few pixels
left over for good measure. For most tabs this will ensure that the buttons
for showing the sidebars will be visible, along with an addition button.

  • UserInterface/Base/Main.js:
  • UserInterface/Views/Sidebar.js:

(WI.Sidebar.prototype.get maximumWidth):

7:32 PM Changeset in webkit [221712] by eric.carlson@apple.com
  • 11 edits in trunk

Require LoggingHelper overrides to provide identifier
https://bugs.webkit.org/show_bug.cgi?id=176477

Reviewed by Jer Noble.

Source/WebCore:

No new tests, updated API test.

  • html/HTMLMediaElement.cpp:

(WebCore::nextLogIdentifier): New.
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_logIdendifier. LOGTHIS -> LOGIDENTIFIER.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Ditto.

  • html/HTMLMediaElement.h:

Source/WebCore/PAL:

  • pal/Logger.h:

(PAL::Logger::LogSiteIdentifier::LogSiteIdentifier):
(PAL::LogArgument<Logger::LogSiteIdentifier>::toString):
(PAL::Logger::notice const): Deleted.
(PAL::Logger::MethodAndPointer::MethodAndPointer): Deleted.
(PAL::LogArgument<Logger::MethodAndPointer>::toString): Deleted.

  • pal/LoggerHelper.h:

Source/WTF:

  • wtf/Assertions.cpp: No more WTFLogLevelNotice.
  • wtf/Assertions.h: Ditto.

Tools:

  • TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::TEST_F):

5:57 PM Changeset in webkit [221711] by mark.lam@apple.com
  • 3 edits
    1 add in trunk

constructGenericTypedArrayViewWithArguments() is missing an exception check.
https://bugs.webkit.org/show_bug.cgi?id=176485
<rdar://problem/33898874>

Reviewed by Keith Miller.

JSTests:

  • stress/regress-176485.js: Added.

Source/JavaScriptCore:

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayViewWithArguments):

5:03 PM Changeset in webkit [221710] by commit-queue@webkit.org
  • 24 edits
    2 adds in trunk

NetworkProcess Cache and Caches should be cleared when the last related WebProcess Cache or CacheStorage is destroyed
https://bugs.webkit.org/show_bug.cgi?id=176249

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-06
Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/cache-storage/cache-representation.https.html

Each Cache construction/destruction is notified to the CacheStorageConnection
so that the WebKit2 engine can handle memory management accordingly.

Adding an internal API to grab the representation of an engine at any time.

  • Modules/cache/Cache.cpp:

(WebCore::Cache::Cache):
(WebCore::Cache::~Cache):

  • Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::reference):
(WebCore::CacheStorageConnection::dereference):

  • Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::WorkerCacheStorageConnection::reference):
(WebCore::WorkerCacheStorageConnection::dereference):

  • Modules/cache/WorkerCacheStorageConnection.h:
  • testing/Internals.cpp:

(WebCore::Internals::cacheStorageEngineRepresentation):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

CacheStorageEngineConnection will store the number of Caches references for its related WebProcess.
For a new reference, CacheStorageEngineConnection will notify its engine to lock the related Cache.
When the last reference is gone, CacheStorageEngineConnection will ask the engine to release the lock.

CacheStorageEngine will keep locks as a counter for each Cache object.
When the counter goes to zero, the engine asks the Cache to dispose itself.
Disposal is done by its parent Caches as only Caches knows whether the Cache is persistent or has been removed.

The Caches will remove the Cache from memory.
For removed caches, all information will be lost.
For caches that are not removed, they will keep their identifiers but all in-memory record information will be discarded.
If there is a need to reopen the Cache, it will need to read its information from the filesystem.
If the Caches has no longer any active Cache object, it will ask the engine to release itself.

WebProcess crashing is handled correctly as the CacheStorageEngineConnection will release its locks at destruction
time of the connection to the web process.

Adding the possiblity to grab an engine representation for test purposes.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::readCachesFromDisk):
(WebKit::CacheStorage::Engine::removeCaches):
(WebKit::CacheStorage::Engine::lock):
(WebKit::CacheStorage::Engine::unlock):

  • NetworkProcess/cache/CacheStorageEngine.h:
  • NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::Cache::Cache):
(WebKit::CacheStorage::Cache::dispose):
(WebKit::CacheStorage::Cache::clearMemoryRepresentation):

  • NetworkProcess/cache/CacheStorageEngineCache.h:

(WebKit::CacheStorage::Cache::isActive const):

  • NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::Caches):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::dispose):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::clearMemoryRepresentation):

  • NetworkProcess/cache/CacheStorageEngineCaches.h:

(WebKit::CacheStorage::Caches::create):

  • NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::~CacheStorageEngineConnection):
(WebKit::CacheStorageEngineConnection::reference):
(WebKit::CacheStorageEngineConnection::dereference):

  • NetworkProcess/cache/CacheStorageEngineConnection.h:
  • NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
  • WebProcess/Cache/WebCacheStorageConnection.cpp:

(WebKit::WebCacheStorageConnection::reference):
(WebKit::WebCacheStorageConnection::dereference):

  • WebProcess/Cache/WebCacheStorageConnection.h:

LayoutTests:

  • http/tests/cache-storage/cache-representation.https-expected.txt: Added.
  • http/tests/cache-storage/cache-representation.https.html: Added.
  • http/tests/cache-storage/resources/cache-persistency-iframe.html:
5:02 PM Changeset in webkit [221709] by mrajca@apple.com
  • 2 edits in trunk/Source/WebCore

Support new autoplay quirk for arbitrary user gestures.
https://bugs.webkit.org/show_bug.cgi?id=176402

Reviewed by Eric Carlson.

This quirk allows any user gesture to allow autoplay in a document.

No new tests because this specifically targets one host.

  • html/MediaElementSession.cpp:

(WebCore::needsArbitraryUserGestureAutoplayQuirk):
(WebCore::MediaElementSession::playbackPermitted const):

4:33 PM Changeset in webkit [221708] by Matt Lewis
  • 3 edits in trunk/LayoutTests

Marked media/video-main-content-allow-then-scroll.html as flaky on macOS and failing on iOS.
https://bugs.webkit.org/show_bug.cgi?id=161491

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac/TestExpectations:
4:27 PM Changeset in webkit [221707] by achristensen@apple.com
  • 11 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's pinnedStateDidChange
https://bugs.webkit.org/show_bug.cgi?id=176474
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

Rather than telling the UIClient that the pinned state changed and having the application check 4 bools
like we do with WKPage, I made a KVO property on the WKWebView. I introduce _WKRectEdge for this purpose,
which is like UIRectEdge but unfortunately NSRectEdge and CGRectEdge cannot be used as NS_OPTIONS/flags.
This same structure is used for rubber band state.

Covered by a new API test.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _pinnedState]):
(-[WKWebView _rubberBandState]):
(-[WKWebView _setRubberBandState:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::pinnedState):
(WebKit::WebViewImpl::rubberBandState):
(WebKit::WebViewImpl::setRubberBandState):

  • UIProcess/PageClient.h:

(WebKit::PageClient::pinnedStateWillChange):
(WebKit::PageClient::pinnedStateDidChange):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):

  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::pinnedStateWillChange):
(WebKit::PageClientImpl::pinnedStateDidChange):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
(TEST):

3:01 PM Changeset in webkit [221706] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari Technology Preview 39

Added a tag for Safari Technology Preview release 39.

2:37 PM Changeset in webkit [221705] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit

Introduce asynchronous opening of CacheStorageEngine cache
https://bugs.webkit.org/show_bug.cgi?id=176425

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-06
Reviewed by Alex Christensen.

Introducing Cache::open to allow reading from the filesystem to fill the Cache.
This is called by Caches when engine requests to open an existing Cache.

  • NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::Cache::Cache):
(WebKit::CacheStorage::Cache::open):
(WebKit::CacheStorage::Cache::finishOpening):
(WebKit::CacheStorage::Cache::readRecordsList):

  • NetworkProcess/cache/CacheStorageEngineCache.h:
  • NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::find):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::find const): Deleted.

  • NetworkProcess/cache/CacheStorageEngineCaches.h:
2:25 PM Changeset in webkit [221704] by commit-queue@webkit.org
  • 24 edits
    5 adds in trunk

Support caching of Response with a ReadableStream body
https://bugs.webkit.org/show_bug.cgi?id=176462

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-06
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:

Source/WebCore:

Tests: http/wpt/cache-storage/cache-put-stream.https.any.html

http/wpt/cache-storage/cache-put-stream.https.any.worker.html

Making FetchResponse use more of ReadableStream:

  • Cloning of its body is done through ReadableStream.
  • Computation of disturbed and locked is done through ReadableStream.
  • Storing of the ReadableStream body given at constructor time is done in FetchBody for FetchResponse.

This allows making FetchResponse closer to FetchRequest.
This also allows to correctly compute disturbed and locked in clone cases.

Adding the ability to consume a Response ReadableStream body as a SharedBuffer.
Using that ability in DOMCache.

  • Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::putWithResponseData):
(WebCore::DOMCache::put):

  • Modules/cache/DOMCache.h:
  • Modules/fetch/FetchBody.h:

(WebCore::FetchBody::readableStream const):

  • Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::extract):

  • Modules/fetch/FetchBodyConsumer.h:
  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::isDisturbed const):
(WebCore::FetchBodyOwner::isDisturbedOrLocked const):

  • Modules/fetch/FetchBodyOwner.h:

(WebCore::FetchBodyOwner::hasReadableStreamBody const):

  • Modules/fetch/FetchBodySource.cpp:
  • Modules/fetch/FetchBodySource.h:
  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::consumeBodyFromReadableStream):
(WebCore::FetchResponse::consumeBodyWhenLoaded):
(WebCore::FetchResponse::consumeBodyAsStream):

  • Modules/fetch/FetchResponse.h:
  • Modules/fetch/FetchResponse.idl:
  • Modules/fetch/FetchResponse.js:

(initializeFetchResponse):
(clone):

  • bindings/js/ReadableStream.cpp:

(WebCore::callFunction):
(WebCore::ReadableStream::pipeTo):
(WebCore::ReadableStream::tee):
(WebCore::checkReadableStream):
(WebCore::ReadableStream::isLocked const):
(WebCore::ReadableStream::isDisturbed const):
(WebCore::ReadableStream::isDisturbed):

  • bindings/js/ReadableStream.h:
  • bindings/js/ReadableStreamDefaultController.cpp:
  • bindings/js/ReadableStreamDefaultController.h:
  • bindings/js/WebCoreBuiltinNames.h:
  • testing/Internals.cpp:

(WebCore::Internals::isReadableStreamDisturbed):

LayoutTests:

  • TestExpectations: Removing flakiness expectation for cache-put tests.
  • http/wpt/cache-storage/cache-put-stream.https.any-expected.txt: Added.
  • http/wpt/cache-storage/cache-put-stream.https.any.html: Added.
  • http/wpt/cache-storage/cache-put-stream.https.any.js: Added.

(cache_test.):
(cache_test):
(string_appeared_here.cache_test.return.reader.read.then.):
(string_appeared_here.cache_test):

  • http/wpt/cache-storage/cache-put-stream.https.any.worker-expected.txt: Added.
  • http/wpt/cache-storage/cache-put-stream.https.any.worker.html: Added.
2:04 PM Changeset in webkit [221703] by sbarati@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Air should have a Vector of prologue generators instead of a HashMap representing an optional prologue generator
https://bugs.webkit.org/show_bug.cgi?id=176346

Reviewed by Mark Lam.

  • b3/B3Procedure.cpp:

(JSC::B3::Procedure::Procedure):
(JSC::B3::Procedure::setNumEntrypoints):

  • b3/B3Procedure.h:

(JSC::B3::Procedure::setNumEntrypoints): Deleted.

  • b3/air/AirCode.cpp:

(JSC::B3::Air::defaultPrologueGenerator):
(JSC::B3::Air::Code::Code):
(JSC::B3::Air::Code::setNumEntrypoints):

  • b3/air/AirCode.h:

(JSC::B3::Air::Code::setPrologueForEntrypoint):
(JSC::B3::Air::Code::prologueGeneratorForEntrypoint):
(JSC::B3::Air::Code::setEntrypoints):
(JSC::B3::Air::Code::setEntrypointLabels):

  • b3/air/AirGenerate.cpp:

(JSC::B3::Air::generate):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):

1:54 PM Changeset in webkit [221702] by achristensen@apple.com
  • 11 edits in trunk

Unreviewed, rolling out r221694.

broke build

Reverted changeset:

"Add WKUIDelegatePrivate equivalent of WKPageUIClient's
pinnedStateDidChange"
https://bugs.webkit.org/show_bug.cgi?id=176474
http://trac.webkit.org/changeset/221694

1:51 PM Changeset in webkit [221701] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ASSERTION FAILED: op() == CheckStructure in Source/JavaScriptCore/dfg/DFGNode.h(443)
https://bugs.webkit.org/show_bug.cgi?id=176470

Reviewed by Mark Lam.

Update Node::convertToCheckStructureImmediate's assertion to allow
the node to either be a CheckStructure or CheckStructureOrEmpty.

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToCheckStructureImmediate):

1:48 PM Changeset in webkit [221700] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] test-webkitpy test timeout_context_unittest is failing.
https://bugs.webkit.org/show_bug.cgi?id=176471

Reviewed by Brent Fulgham.

This assert failure is possibly caused by different time resolution on
various platforms.

  • Scripts/webkitpy/common/timeout_context_unittest.py:

(TimeoutContextTests.test_timeout_data):

1:40 PM Changeset in webkit [221699] by Ryan Haddad
  • 24 edits
    1 delete in trunk

Unreviewed, rolling out r221461.

The LayoutTest added with this change crashes under
GuardMalloc.

Reverted changeset:

"Add (entirely incorrect) fetching of ServiceWorker scripts."
https://bugs.webkit.org/show_bug.cgi?id=176179
http://trac.webkit.org/changeset/221461

1:26 PM Changeset in webkit [221698] by achristensen@apple.com
  • 5 edits in trunk/Source/WebKit

Add modern decoders for POD types
https://bugs.webkit.org/show_bug.cgi?id=176456

Reviewed by Geoffrey Garen.

  • Platform/IPC/Decoder.cpp:

(IPC::Decoder::getOptional):
(IPC::Decoder::operator>>):

  • Platform/IPC/Decoder.h:
  • Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::decode):

  • Shared/NavigationActionData.h:
1:24 PM Changeset in webkit [221697] by matthew_hanson@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

1:21 PM Changeset in webkit [221696] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

status-bubbles turn orange after checking relevance of patch
https://bugs.webkit.org/show_bug.cgi?id=176457

Reviewed by Alexey Proskuryakov.

  • QueueStatusServer/handlers/statusbubble.py: Added "Checked relevance of patch" as a progress_statuses.
1:16 PM Changeset in webkit [221695] by webkit@devinrousso.com
  • 16 edits
    1 add in trunk

Web Inspector: Support overloaded CanvasRenderingContext2D actions with identical parameter counts
https://bugs.webkit.org/show_bug.cgi?id=176178
<rdar://problem/34192229>

Reviewed by Matt Baker.

Source/WebCore:

Update existing tests.

  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorCanvas.cpp:

(WebCore::buildArrayForVector):
(WebCore::InspectorCanvas::buildAction):
Add another array to each action that contains a swizzle type for each parameter. This is
used by the frontend to determine how to regenerate the value from what is given in the JSON.

  • inspector/RecordingSwizzleTypes.h: Added.

Contains a value-specified enum of types that translate into int values, which are mirrored
by an object in the frontend, that indicate the type of each parameter. This enum matches
the values in WI.Recording.Swizzle.

Source/WebInspectorUI:

  • UserInterface/Models/Recording.js:

(WI.Recording.displayNameForSwizzleType):
(WI.Recording.prototype.swizzle):
Replace WI.Recording.Swizzle with an object of swizzle type keys to int values. This object
matches the values in WebCore::RecordingSwizzleTypes.h.

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction):
(WI.RecordingAction.fromPayload):
(WI.RecordingAction.prototype.get swizzleTypes):
(WI.RecordingAction.prototype.swizzle):
(WI.RecordingAction.prototype.toJSON):
(WI.RecordingAction.prototype.parameterSwizzleTypeForTypeAtIndex): Deleted.
Replace WI.RecordingAction._parameterSwizzleTypeForTypeAtIndex with an array of parameter
types sent in the payload. This gives more control over the swizzling to the JSON, but also
simplifies the way we regenerate the data in the frontend.

  • UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._generateDOM):

  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype._generateContentCanvas2D):
(WI.RecordingContentView.prototype._applyAction):

  • UserInterface/Views/RecordingNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.recording > .content .action.invalid:not(.selected, .initial-state) > .titles :matches(.name, .parameter.invalid)):
(.sidebar > .panel.navigation.recording > .content .action.invalid:not(.selected, .initial-state) > .titles .name,): Deleted.

LayoutTests:

  • inspector/canvas/recording-2d-expected.txt:
  • inspector/canvas/recording-webgl-expected.txt:
  • inspector/canvas/recording-webgl-snapshots-expected.txt:
  • inspector/model/recording-expected.txt:
  • inspector/model/recording.html:
1:15 PM Changeset in webkit [221694] by achristensen@apple.com
  • 11 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's pinnedStateDidChange
https://bugs.webkit.org/show_bug.cgi?id=176474
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

Rather than telling the UIClient that the pinned state changed and having the application check 4 bools
like we do with WKPage, I made a KVO property on the WKWebView. I introduce _WKRectEdge for this purpose,
which is like UIRectEdge but unfortunately NSRectEdge and CGRectEdge cannot be used as NS_OPTIONS/flags.
This same structure is used for rubber band state.

Covered by a new API test.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _pinnedState]):
(-[WKWebView _rubberBandState]):
(-[WKWebView _setRubberBandState:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::pinnedState):
(WebKit::WebViewImpl::rubberBandState):
(WebKit::WebViewImpl::setRubberBandState):

  • UIProcess/PageClient.h:

(WebKit::PageClient::pinnedStateWillChange):
(WebKit::PageClient::pinnedStateDidChange):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):

  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::pinnedStateWillChange):
(WebKit::PageClientImpl::pinnedStateDidChange):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
(TEST):

1:09 PM Changeset in webkit [221693] by pvollan@apple.com
  • 8 edits
    1 move in trunk/Source

[Win] WebCore failed to build, InbandTextTrackPrivateAVF: base class undefined.
https://bugs.webkit.org/show_bug.cgi?id=176431

Reviewed by Alex Christensen.

Source/WebCore:

AVFoundation header detection should be done in WebCore because of build dependencies.

No new tests, covered by existing tests.

  • AVFoundationSupport.py: Copied from Source/WTF/AVFoundationSupport.py.
  • PlatformWin.cmake:
  • config.h:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:
  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

Source/WTF:

AVFoundation header detection should be done in WebCore because of build dependencies.

  • AVFoundationSupport.py: Removed.
  • wtf/Platform.h:
  • wtf/PlatformWin.cmake:
1:03 PM Changeset in webkit [221692] by fpizlo@apple.com
  • 5 edits in trunk/Tools

WSL: Inliner doesn't allow double-negation
https://bugs.webkit.org/show_bug.cgi?id=176440

Reviewed by Mylex Maxfield.

The problem was that we were visiting the operands to calls while inside doVisit. This is too strict
since it rejects nested calls like foo(foo(x)). The solution is to visit the operands to calls before
entering doVisit.

This also fixes some other issues in the parser that made the Inliner's error really strange.

  • WebGPUShadingLanguageRI/Func.js:

(Func):

  • WebGPUShadingLanguageRI/Inliner.js:

(Inliner.prototype.visitCallExpression):
(Inliner):

  • WebGPUShadingLanguageRI/Parse.js:

(parseOperatorFuncDefValues):
(parseNonOperatorFuncDefValues):
(parseGenericFuncDefValues):
(parseFuncDecl):

  • WebGPUShadingLanguageRI/Test.js:
  • WebGPUShadingLanguageRI/VisitingSet.js:

(VisitingSet.prototype.doVisit):
(VisitingSet):

12:46 PM Changeset in webkit [221691] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: ⌘E and ⌘G do not work in main content area when quick console drawer is open
https://bugs.webkit.org/show_bug.cgi?id=176433

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-06
Reviewed by Brian Burg.

Make the ⌘E and ⌘G keyboard shortcuts behave more like the global ⌘K clear shortcut.
Instead of keeping them inside of FindBanner, and enabling/disabling them when they
make sense to apply, we make a single global instance of the keyboard shortcut and
apply it to whatever content view / content browser is active. This avoids conflicts
in situations where there are two ContentViews that are visible and each can handle
the keyboard shortcut.

  • UserInterface/Base/Main.js:

(WI.contentLoaded):
New keyboard shortcuts.

(WI._populateFind):
(WI._findNext):
(WI._findPrevious):
Perform the shortcut on the active content view or content browser.

  • UserInterface/Views/ContentBrowser.js:

(WI.ContentBrowser.prototype.shown):
(WI.ContentBrowser.prototype.hidden):
(WI.ContentBrowser.prototype.handlePopulateFindShortcut):
(WI.ContentBrowser.prototype.handleFindNextShortcut):
(WI.ContentBrowser.prototype.handleFindPreviousShortcut):
(WI.ContentBrowser.prototype.findBannerSearchQueryForSelection): Deleted.

  • UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.handlePopulateFindShortcut):
(WI.LogContentView.prototype.handleFindNextShortcut):
(WI.LogContentView.prototype.handleFindPreviousShortcut):
ContentBrowser and LogContentView (the only content view with a custom find banner)
now each handle the global keyboard shortcut handlers to do the right thing for
their respective cases.

  • UserInterface/Views/FindBanner.js:

(WI.FindBanner.prototype.enableKeyboardShortcuts): Deleted.
(WI.FindBanner.prototype.disableKeyboardShortcuts): Deleted.
(WI.FindBanner.prototype._populateSearchQueryFromSelection): Deleted.
Move keyboard shortcut handling up to Main.js to be global.

  • UserInterface/Views/ContentView.js:

(WI.ContentView.prototype.searchQueryWithSelection):
Default implementation should grab the selected text from the selection.
Previously shortcut selections only worked for selections in text editors.

12:34 PM Changeset in webkit [221690] by mmaxfield@apple.com
  • 1 edit
    2 adds in trunk/Tools

WSL should support the bool type
https://bugs.webkit.org/show_bug.cgi?id=176285

Reviewed by Filip Pizlo.

I forgot to commit a couple files.

  • WebGPUShadingLanguageRI/StandardLibraryEpilogue.js: Added.

(const.standardLibraryEpilogue.operator.bool.T.Equatable):

  • WebGPUShadingLanguageRI/StandardLibraryPrologue.js: Added.

(operator.T.T):

11:49 AM Changeset in webkit [221689] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION (r221598): Legacy "round" and "bevel" options can no longer be used with the legacy CanvasRenderingContext2D setLineJoin operation
https://bugs.webkit.org/show_bug.cgi?id=176461

Patch by Sam Weinig <sam@webkit.org> on 2017-09-06
Reviewed by Alex Christensen.

Source/WebCore:

Tests: fast/canvas/canvas-strokePath-cap-join-legacy-functions-match-attribute.html

fast/canvas/canvas-strokePath-cap-join-legacy.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setLineJoin):

Fix silly typo, ifs -> else ifs.

LayoutTests:

Add tests showing that the legacy setLineJoin and setLineCap operations are correct
and match the corresponding standard attributes.

  • fast/canvas/canvas-strokePath-cap-join-legacy-functions-match-attribute-expected.html: Added.
  • fast/canvas/canvas-strokePath-cap-join-legacy-functions-match-attribute.html: Added.
  • fast/canvas/canvas-strokePath-cap-join-legacy-expected.txt: Added.
  • fast/canvas/canvas-strokePath-cap-join-legacy.html: Added.
11:45 AM Changeset in webkit [221688] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline printing/width-overflow.html after r219121.

Unreviewed test gardening.

  • platform/win/printing/width-overflow-expected.txt:
11:26 AM Changeset in webkit [221687] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked js/arraybuffer-wrappers.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=155092

Unreviewed test gardening.

  • platform/ios/TestExpectations:
11:25 AM Changeset in webkit [221686] by mmaxfield@apple.com
  • 18 edits
    1 copy
    1 delete in trunk/Tools

WSL should correctly handle the interaction between casting operators and complex types
https://bugs.webkit.org/show_bug.cgi?id=176316

Reviewed by Filip Pizlo.

This allows the standard library to include all identity cast operators for all exsting
and yet-to-exist types. The standard library now has a function with the signature:
operator T<><T>(T). This means "for all T, define a cast operator from T to T<>." The
duplicate <>s lets us say things like operator OutputVector<T><T>(InputVector<T> x).

For testing, this patch also adds the ability to cast an arbitrary Equatable type to bool,
by comparing the value to the default value for that type.

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/CastExpression.js: Copied from Tools/WebGPUShadingLanguageRI/NativeFuncInstance.js.

(CastExpression):
(CastExpression.prototype.get functionName):
(CastExpression.prototype.get returnType):
(CastExpression.prototype.toString):

  • WebGPUShadingLanguageRI/Checker.js:
  • WebGPUShadingLanguageRI/Func.js:

(Func.prototype.toDeclString):

  • WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitNativeFunc):
(FuncInstantiator.prototype.getUnique.Instantiate):
(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):

  • WebGPUShadingLanguageRI/Inliner.js:

(Inliner.prototype.visitCastExpression):
(Inliner):

  • WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

  • WebGPUShadingLanguageRI/NativeFunc.js:
  • WebGPUShadingLanguageRI/NativeFuncInstance.js:

(NativeFuncInstance):

  • WebGPUShadingLanguageRI/Parse.js:

(parsePossiblePrefix):
(parseFuncDecl):
(parseOperatorFuncDefValues): Deleted.
(parseNonOperatorFuncDefValues): Deleted.
(parseGenericFuncDefValues): Deleted.

  • WebGPUShadingLanguageRI/Prepare.js:

(prepare):

  • WebGPUShadingLanguageRI/Program.js:

(Program.prototype.resolveFuncOverload):

  • WebGPUShadingLanguageRI/ResolveOverloadImpl.js:

(resolveOverloadImpl):

  • WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.processDerivedCallData):
(Rewriter.prototype.visitCastExpression):
(Rewriter.prototype.visitCallExpression):

  • WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/Test.js:
  • WebGPUShadingLanguageRI/TypeDefResolver.js:

(TypeDefResolver):
(TypeDefResolver.prototype.visitFuncDef): Deleted.

  • WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitCastExpression):

11:16 AM Changeset in webkit [221685] by fpizlo@apple.com
  • 1 edit
    5 adds in trunk/PerformanceTests

We should have more tests of tail calls
https://bugs.webkit.org/show_bug.cgi?id=175754

Reviewed by Sam Weinig.

This introduces a new test suite called TailBench9000, which will have benchmarks written in
JavaScript that avoid all looping except by tail call. As a warmup, I wrote a mergesort
benchmark and I proted n-body to use tail calls instead of for loops.

  • TailBench9000: Added.
  • TailBench9000/merge-sort-run.js: Added.
  • TailBench9000/merge-sort.js: Added.

(TEST_mergeSort.createRNG):
(TEST_mergeSort.):
(TEST_mergeSort.merge):
(TEST_mergeSort.mergeSorted):
(TEST_mergeSort.checkSorted.check):
(TEST_mergeSort.checkSorted):
(TEST_mergeSort.add):
(TEST_mergeSort.build):
(TEST_mergeSort.compare):
(TEST_mergeSort.checkSpectrum):
(TEST_mergeSort.buildArray):
(TEST_mergeSort):

  • TailBench9000/n-body-run.js: Added.
  • TailBench9000/n-body.js: Added.

(TEST_nBody.Body):
(TEST_nBody.Body.prototype.offsetMomentum):
(TEST_nBody.Jupiter):
(TEST_nBody.Saturn):
(TEST_nBody.Uranus):
(TEST_nBody.Neptune):
(TEST_nBody.Sun):
(TEST_nBody.NBodySystem):
(TEST_nBody.NBodySystem.prototype.advance):
(TEST_nBody.NBodySystem.prototype.energy):
(TEST_nBody):

10:47 AM Changeset in webkit [221684] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Compile errors in Document::updateTitleElement.
https://bugs.webkit.org/show_bug.cgi?id=176381

Reviewed by Alex Christensen.

MSVC is not able to compile the statement:
'auto result = boolExpression ? lambda1 : lambda2;'
where 'lambda1' and 'lambda2' have the same signature.

  • dom/Document.cpp:

(WebCore::findHTMLTitle):
(WebCore::isHTMLTitle):
(WebCore::isHTMLTitleEligible):
(WebCore::findSVGTitle):
(WebCore::isSVGTitle):
(WebCore::isSVGTitleEligible):
(WebCore::Document::updateTitleElement):

10:30 AM Changeset in webkit [221683] by Brent Fulgham
  • 15 edits
    2 adds in trunk

Deny third-party cookie creation for prevalent resources without interaction
https://bugs.webkit.org/show_bug.cgi?id=175232
<rdar://problem/33709386>

Reviewed by Alex Christensen.

Source/WebCore:

Prior to Intelligent Tracking Prevention, WebKit would deny the ability to create a third party cookie if the user's
settings prohibited it. Due to the internal mechanics of cookie partitioning, we now accept the third party cookie,
but destroy it at some arbitrary moment which is difficult for websites to work with.

This patch revises WebKit so that attempts to set third party cookies without user interaction fails immediately,
which is what sites are expecting from Safari.

Tests: http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html

  • platform/network/NetworkStorageSession.h:
  • platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::shouldPartitionCookies const): Revise for new naming.
(WebCore::NetworkStorageSession::shouldAllowThirdPartyCookies const): Allow third party cookies when the
user interaction property applies.
(WebCore::NetworkStorageSession::shouldBlockCookies const): Deny cookies for origins that are not allowed by
user interaction, and that are not being partitioned.
(WebCore::NetworkStorageSession::setPrevalentDomainsWithAndWithoutInteraction): Revise for new naming, and
to track prevalent origins with and without user interaction.
(WebCore::NetworkStorageSession::setShouldPartitionCookiesForHosts): Renamed to setPrevalentDomainsWithAndWithoutInteraction.
(WebCore::NetworkStorageSession::removePrevalentDomains): New helper function for testing.

Source/WebKit:

Prior to Intelligent Tracking Prevention, WebKit would deny the ability to create a third party cookie if the user's
settings prohibited it. Due to the internal mechanics of cookie partitioning, we now accept the third party cookie,
but destroy it at some arbitrary moment which is difficult for websites to work with.

This patch revises WebKit so that attempts to set third party cookies without user interaction fails immediately,
which is what sites are expecting from Safari.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::updatePrevalentDomainsWithAndWithoutInteraction):
(WebKit::NetworkProcess::updateCookiePartitioningForTopPrivatelyOwnedDomains): Renamed to updatePrevalentDomainsWithAndWithoutInteraction.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in: Renamed the UpdateCookiePartitioningForTopPrivatelyOwnedDomains message

to UpdatePrevalentDomainsWithAndWithoutInteraction.

  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): Recognize cases where a network session should block cookies, and
use the stateless session so we fail immediately when attempting an invalid cookie set operation.

  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(WebKit::WKWebsiteDataStore::_resourceLoadStatisticsSetShouldPartitionCookies): Use new helper function to clear partitioning state.

  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore): Update for revised naming.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning): Track domains with and without interaction so that we can recognize
domains that should be immediately blocked from setting cookies.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains): Update for revised naming.
(WebKit::WebResourceLoadStatisticsStore::scheduleClearPartitioningStateForDomains): Added helper function for testing.

  • UIProcess/WebResourceLoadStatisticsStore.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::updatePrevalentDomainsWithAndWithoutInteraction): Update for revised naming.
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback): Ditto.
(WebKit::WebsiteDataStore::updateCookiePartitioningForTopPrivatelyOwnedDomains): Renamed to updatePrevalentDomainsWithAndWithoutInteraction.

  • UIProcess/WebsiteData/WebsiteDataStore.h:

LayoutTests:

  • http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction-expected.txt: Added.
  • http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html: Added.
  • platform/mac-highsierra-wk2/TestExpectations: Add new test expectation.
10:24 AM Changeset in webkit [221682] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test http/tests/preload/single_download_preload.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=176465.

Unreviewed test gardening.

  • platform/win/TestExpectations:
10:05 AM Changeset in webkit [221681] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebKit

[WPE][CMake] Fix path to the WebKitApplicationInfo.h header.

Unreviewed build fix.

This doesn't really make a difference for the build bots, but it makes
it possible to craft working release tarballs of WPE.

  • PlatformWPE.cmake: Use the WPE version of WebKitApplicationInfo.h
10:02 AM Changeset in webkit [221680] by commit-queue@webkit.org
  • 2 edits
    10 adds in trunk/LayoutTests

[WPE] Add missing test expectations
https://bugs.webkit.org/show_bug.cgi?id=176453

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-09-06

  • platform/wpe/TestExpectations:
  • platform/wpe/fast/events/context-no-deselect-expected.txt: Added.
  • platform/wpe/fast/events/event-listener-on-link-expected.txt: Added.
  • platform/wpe/fast/events/ghostly-mousemoves-in-subframe-expected.txt: Added.
  • platform/wpe/fast/events/onload-re-entry-expected.txt: Added.
  • platform/wpe/fast/events/pointer-events-2-expected.txt: Added.
  • platform/wpe/fast/events/resize-events-expected.txt: Added.
  • platform/wpe/fast/events/reveal-link-when-focused-expected.txt: Added.
  • platform/wpe/fast/events/updateLayoutForHitTest-expected.txt: Added.
  • platform/wpe/fast/inspector-support/matchedrules-expected.txt: Added.
9:55 AM Changeset in webkit [221679] by dbates@webkit.org
  • 2 edits in trunk/Tools

Copy WebKit Permalink may generate wrong URL with SVN checkout
https://bugs.webkit.org/show_bug.cgi?id=176427

Reviewed by Darin Adler.

Fixes an issue where Copy WebKit Permalink would generate an incorrect URL for
any file not in the top-level directory of the repository when using an SVN
checkout of WebKit.

Copy WebKit Permalink changes directories to the containing directory D of the
active Xcode document F before running "svn info <path to F>". Currently we use
the value of "Path" from the output of "svn info" when generating the permalink.
This path is relative to D. But we want the path to F relative to the top-level
checkout directory. We need to explicitly compute this.

  • CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow:
9:39 AM Changeset in webkit [221678] by Carlos Garcia Campos
  • 1800 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 7.

9:37 AM Changeset in webkit [221677] by tpopela@redhat.com
  • 2 edits in trunk/Source/WebCore

Missing break in URLParser
https://bugs.webkit.org/show_bug.cgi?id=176357

Reviewed by Darin Adler.

Add a missing break so the currently set state is not overwritten
after the block. Found by Coverity scan.

  • platform/URLParser.cpp:

(WebCore::URLParser::parse):

9:25 AM Changeset in webkit [221676] by Carlos Garcia Campos
  • 945 edits
    304 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 6.

9:15 AM Changeset in webkit [221675] by Carlos Garcia Campos
  • 1457 edits
    1 copy
    4 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 5.

9:11 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com
(diff)
9:04 AM Changeset in webkit [221674] by Carlos Garcia Campos
  • 1806 edits
    1 copy
    2 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 4.

8:51 AM Changeset in webkit [221673] by Carlos Garcia Campos
  • 1791 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 3.

8:37 AM Changeset in webkit [221672] by Carlos Garcia Campos
  • 1562 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 2.

8:25 AM Changeset in webkit [221671] by Carlos Garcia Campos
  • 1853 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 1.

8:10 AM Changeset in webkit [221670] by Carlos Garcia Campos
  • 4 edits
    1 delete in trunk

[GTK] Bump freetype version to 2.8.0
https://bugs.webkit.org/show_bug.cgi?id=176351

Source/WebCore:

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2017-09-06
Reviewed by Carlos Alberto Lopez Perez.

Retrieving line spacing info without metrics hinting - FreeType's metric hinting
uses rounding which results in the sum of ascent and descent being larger
than the line height. To work around this without globally disabling font metrics
hinting, I am temporarily creating a new cairo scaled font with metrics hinting
off and retrieving the height values from this one.

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::scaledFontWithoutMetricsHinting): New function to clone the existing font, only with metrics hinting
disabled.
(WebCore::Font::platformInit): Get height info from non-metrics hinted font, disable rounding for linespacing.

Tools:

Reviewed by Carlos Alberto Lopez Perez.

Remove the patch we were using since it was reverted upstream.

  • gtk/jhbuild.modules:
  • gtk/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Removed.
7:52 AM WebKitGTK/2.16.x edited by Michael Catanzaro
(diff)
5:42 AM Changeset in webkit [221669] by commit-queue@webkit.org
  • 7 edits
    4 adds in trunk/Source

Introduce ScrollingTreeScrollingNodeDelegateIOS to share code between overflow and frame scrolling
https://bugs.webkit.org/show_bug.cgi?id=174097

Patch by Frédéric Wang <fwang@igalia.com> on 2017-09-06
Reviewed by Darin Adler.

Source/WebCore:

No new tests, behavior unchanged.

  • WebCore.xcodeproj/project.pbxproj: Add ScrollingTreeScrollingNodeDelegate.
  • page/scrolling/ScrollingTreeScrollingNode.h: Make ScrollingTreeScrollingNodeDelegate a

friend so that it can access private members.

  • page/scrolling/ScrollingTreeScrollingNodeDelegate.cpp: Added. New delegate class for a

scrolling node, which is used by the UI process.
(WebCore::ScrollingTreeScrollingNodeDelegate::ScrollingTreeScrollingNodeDelegate):
Constructor, taking the scrolling node as a parameter.
(WebCore::ScrollingTreeScrollingNodeDelegate::~ScrollingTreeScrollingNodeDelegate):
(WebCore::ScrollingTreeScrollingNodeDelegate::scrollingTree const): Expose the scrolling
tree containing the scrolling node.
(WebCore::ScrollingTreeScrollingNodeDelegate::lastCommittedScrollPosition const): Expose
the last committed scroll position of the scrolling node.

  • page/scrolling/ScrollingTreeScrollingNodeDelegate.h: Added.

(WebCore::ScrollingTreeScrollingNodeDelegate::scrollingNode): Expose the scrolling node.
(WebCore::ScrollingTreeScrollingNodeDelegate::scrollingNode const): Ditto.

Source/WebKit:

This patch introduces a new ScrollingTreeScrollingNodeDelegateIOS that can be used by
WKOverflowScrollViewDelegate to communicate to the scrolling tree and nodes. It can also be
used as a helper class by ScrollingTreeOverflowScrollingNodeIOS. For now, only the non-
overriden member functions of ScrollingTreeOverflowScrollingNodeIOS are moved to that new
class. In follow-up commits, WKOverflowScrollViewDelegate can become a generic
ScrollViewDelegate and more code can be moved into the ScrollingTreeScrollingNodeDelegateIOS
file. Frame scrolling nodes will then be able to share the same UI code as overflow:auto when
iOS frame scrolling is implemented (bug 149264).

  • UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h: Move non-overriden member

functions and m_updatingFromStateNode into the delegate class. Also define a member to store
that delegate.

  • UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm: Use the node delegate to

communicate to the scrolling tree and node.
(-[WKOverflowScrollViewDelegate initWithScrollingTreeNodeDelegate:]): Init with a delegate.
(-[WKOverflowScrollViewDelegate scrollViewDidScroll:]): Call the delegate function.
(-[WKOverflowScrollViewDelegate scrollViewWillBeginDragging:]): Ditto.
(-[WKOverflowScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]):
Use the delegate functions or pass by ScrollingTreeScrollingNodeDelegateIOS::scrollingNode().
(-[WKOverflowScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]): Use the delegate
functions.
(-[WKOverflowScrollViewDelegate scrollViewDidEndDecelerating:]): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::ScrollingTreeOverflowScrollingNodeIOS):
Init the delegate for this class.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateAfterChildren): Use the delegate.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::setScrollLayerPosition): Use the delegate
function.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterDelegatedScroll): Ditto.
(-[WKOverflowScrollViewDelegate initWithScrollingTreeNode:]): Deleted. This is renamed
initWithScrollingTreeNodeDelegate and accepts a delegate.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateChildNodesAfterScroll): Deleted. Moved
to ScrollingTreeScrollingNodeDelegateIOS.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollWillStart): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollDidEnd): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollViewWillStartPanGesture): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewDidScroll): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::currentSnapPointIndicesDidChange): Ditto.

  • UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h: Added. New delegate class

for ScrollingTreeOverflowScrollingNodeIOS. The members used by WKOverflowScrollViewDelegate
are public and the others are private. ScrollingTreeOverflowScrollingNodeIOS is a friend of
ScrollingTreeScrollingNodeDelegateIOS so that it can access private members e.g.
updateChildNodesAfterScroll() or m_updatingFromStateNode.

  • UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: Added.

(WebKit::ScrollingTreeScrollingNodeDelegateIOS::ScrollingTreeScrollingNodeDelegateIOS):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::~ScrollingTreeScrollingNodeDelegateIOS):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateChildNodesAfterScroll): Code extracted
from ScrollingTreeOverflowScrollingNodeIOS.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollWillStart): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollDidEnd): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollViewWillStartPanGesture): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollViewDidScroll): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::currentSnapPointIndicesDidChange): Ditto.

  • WebKit.xcodeproj/project.pbxproj: Add ScrollingTreeScrollingNodeDelegateIOS files to the

build system.

3:54 AM WebKitGTK/Debugging edited by tpopela@redhat.com
(diff)
2:59 AM Changeset in webkit [221668] by Manuel Rego Casasnovas
  • 8 edits
    2 adds in trunk

[css-grid] grid shorthand should not reset the gutter properties
https://bugs.webkit.org/show_bug.cgi?id=176375

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

Import new test from WPT.

  • web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001-expected.txt: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001.html: Added.
  • web-platform-tests/css/css-grid-1/grid-definition/w3c-import.log:

Source/WebCore:

The CSS WG has resolved that the "grid" shorthand shouldn't reset
the gutter properties anymore:
https://github.com/w3c/csswg-drafts/issues/1036

This was originally implemented in r195529, so this is somehow
a revert of that change.

Test: imported/w3c/web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001.html

  • css/CSSProperties.json:
  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeGridShorthand):

LayoutTests:

Update the test to check the new behavior.

  • fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
  • fast/css-grid-layout/grid-shorthand-get-set.html:
1:17 AM Changeset in webkit [221667] by zandobersek@gmail.com
  • 11 edits
    2 adds in trunk

[WebGL2] Implement getActiveUniforms()
https://bugs.webkit.org/show_bug.cgi?id=175203

Reviewed by Darin Adler.

Source/WebCore:

Align getActiveUniforms() WebIDL signature with the spec -- making it
return a WebGLAny object, making the program parameter non-nullable,
and making the uniformIndices parameter a sequence on GLuint values.

The getActiveUniforms() implementation in WebGL2RenderingContext
validates the passed-in program and parameter name and then calls the
GraphicsContext3D::getActiveUniforms() method, retrieving an array of
integers that represent values of the requested parameter name for
each uniform whose index was passed through uniformIndices.

Test: fast/canvas/webgl/webgl2-getActiveUniforms.html

  • bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getActiveUniforms):

  • html/canvas/WebGL2RenderingContext.h:
  • html/canvas/WebGL2RenderingContext.idl:
  • html/canvas/WebGLAny.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::getActiveUniforms):

LayoutTests:

Add a basic gl.getActiveUniforms() test that checks proper return values
for a mat4 uniform in the simple vertex shader that's used when creating
the 'standard' program through webgl-test.js utilities. The test remains
skipped on GTK+ and Windows (WebGL 2.0 disabled). Mac port skips it as
well since the shader can't be compiled properly. WPE and iOS run the
test and are passing it.

  • fast/canvas/webgl/webgl2-getActiveUniforms-expected.txt: Added.
  • fast/canvas/webgl/webgl2-getActiveUniforms.html: Added.
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
12:23 AM Changeset in webkit [221666] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Win] Tools/TestWebKitAPI/Tests/WTF/PriorityQueue.cpp fails to compile with MSVC 2015
https://bugs.webkit.org/show_bug.cgi?id=176442

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-09-06
Reviewed by Keith Miller.

  • TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(TEST):

Sep 5, 2017:

11:48 PM Changeset in webkit [221665] by zandobersek@gmail.com
  • 57 edits in trunk/Source/WebCore

[WebCrypto] Downcast parameters and keys at the platform operation callsites
https://bugs.webkit.org/show_bug.cgi?id=176392

Reviewed by Sam Weinig.

Downcast to algorithm-specific parameter and key types in the shared
code that then invokes platform-specific operation implementations.
This reduces the duplicated downcasts across different implementations
that don't differ at all in this behavior.

Covered by existing tests.

  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):

  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:
  • crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:

(WebCore::CryptoAlgorithmAES_CFB::encrypt):
(WebCore::CryptoAlgorithmAES_CFB::decrypt):

  • crypto/algorithms/CryptoAlgorithmAES_CFB.h:
  • crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:

(WebCore::CryptoAlgorithmAES_CTR::encrypt):
(WebCore::CryptoAlgorithmAES_CTR::decrypt):

  • crypto/algorithms/CryptoAlgorithmAES_CTR.h:
  • crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:

(WebCore::CryptoAlgorithmAES_GCM::encrypt):
(WebCore::CryptoAlgorithmAES_GCM::decrypt):

  • crypto/algorithms/CryptoAlgorithmAES_GCM.h:
  • crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::wrapKey):
(WebCore::CryptoAlgorithmAES_KW::unwrapKey):

  • crypto/algorithms/CryptoAlgorithmAES_KW.h:
  • crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::deriveBits):

  • crypto/algorithms/CryptoAlgorithmECDH.h:
  • crypto/algorithms/CryptoAlgorithmECDSA.cpp:

(WebCore::CryptoAlgorithmECDSA::sign):
(WebCore::CryptoAlgorithmECDSA::verify):

  • crypto/algorithms/CryptoAlgorithmECDSA.h:
  • crypto/algorithms/CryptoAlgorithmHKDF.cpp:

(WebCore::CryptoAlgorithmHKDF::deriveBits):

  • crypto/algorithms/CryptoAlgorithmHKDF.h:
  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):

  • crypto/algorithms/CryptoAlgorithmHMAC.h:
  • crypto/algorithms/CryptoAlgorithmPBKDF2.cpp:

(WebCore::CryptoAlgorithmPBKDF2::deriveBits):

  • crypto/algorithms/CryptoAlgorithmPBKDF2.h:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):

  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::encrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::decrypt):

  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
  • crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::sign):
(WebCore::CryptoAlgorithmRSA_PSS::verify):

  • crypto/algorithms/CryptoAlgorithmRSA_PSS.h:
  • crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmAES_CFBGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmAES_CTRGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

  • crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:

(WebCore::CryptoAlgorithmECDH::platformDeriveBits):

  • crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:

(WebCore::CryptoAlgorithmECDSA::platformSign):
(WebCore::CryptoAlgorithmECDSA::platformVerify):

  • crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp:

(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):

  • crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:

(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

  • crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp:

(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):

  • crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

  • crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_CFBMac.cpp:

(WebCore::CryptoAlgorithmAES_CFB::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_CTRMac.cpp:

(WebCore::CryptoAlgorithmAES_CTR::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

  • crypto/mac/CryptoAlgorithmECDHMac.cpp:

(WebCore::CryptoAlgorithmECDH::platformDeriveBits):

  • crypto/mac/CryptoAlgorithmECDSAMac.cpp:

(WebCore::CryptoAlgorithmECDSA::platformSign):
(WebCore::CryptoAlgorithmECDSA::platformVerify):

  • crypto/mac/CryptoAlgorithmHKDFMac.cpp:

(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):

  • crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

  • crypto/mac/CryptoAlgorithmPBKDF2Mac.cpp:

(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):

  • crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

  • crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

10:25 PM Changeset in webkit [221664] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Add a button to show two weeks of data to perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=176438

Reviewed by Saam Barati.

Add "2W" button to show 14 days of data on dashboard pages.

  • public/v3/pages/dashboard-toolbar.js:

(DashboardToolbar):

10:02 PM Changeset in webkit [221663] by Chris Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed, rebaseline test after r221639.

  • fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt:
  • fast/forms/file/entries-api/drag-folder-webkitEntries.html:
8:55 PM Changeset in webkit [221662] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: display "Inherited From" section headers
https://bugs.webkit.org/show_bug.cgi?id=176033
<rdar://problem/34116930>

Reviewed by Devin Rousso.

Compared to the old styles sidebar, the new "Inherited From" sections are more compact.
One of the goals of the styles redesign is to make it fit more data vertically.

The contrast is inceased. The text is darker while the background stayed the same.

  • UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css:

(.spreadsheet-style-panel .section-inherited):
(.spreadsheet-style-panel .section-inherited .node-link):
(.spreadsheet-style-panel .section-inherited .node-link:hover):

  • UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.refresh):
Don't show two identical "Inherited From" sections.

8:35 PM Changeset in webkit [221661] by Darin Adler
  • 13 edits in trunk

Fix a few minor problems found while working toward removing unneeded calls to updateStyle
https://bugs.webkit.org/show_bug.cgi?id=176279

Reviewed by Antti Koivisto.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::updateTitleElement): Fix the algorithm so that an SVG title won't
ever become the title when the document element is not an SVG element. We had this wrong
before but we were passing the test because SVGTitleElement::insertedInto had a bug that
hid the problem.
(WebCore::Document::titleElementAdded): Pass a reference instead of a pointer.
(WebCore::Document::titleElementRemoved): Pass a reference instead of nullptr since we
want to know which element is being removed.

  • dom/Document.h: Update the argument name and type for updateTitleElement.
  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::insertedInto): Call titleElementAdded unconditionally.
The checks to see if the title element is connected to the document and not in the
shadow tree are now handled by the Document class.
(WebCore::HTMLTitleElement::removedFrom): Same for titleElementRemoved.

  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::applySize): Removed incorrect caching of FontCascade
objects; these need to be created each time we draw.
(WebCore::MockRealtimeVideoSource::drawText): Create all the fonts here. Since this is
a mock for testing, there is no real performance concern with doing this.

  • platform/mock/MockRealtimeVideoSource.h: Removed the FontCascade data members.
  • rendering/RenderTreeAsText.cpp:

(WebCore::updateLayoutIgnoringPendingStylesheetsIncludingSubframes): Added. Used below
to update layout more thoroughly.
(WebCore::externalRepresentation): Update layout of all descendant frames, not just
the top level frame.

  • svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::insertedInto): Removed bogus firstChild check, bogus isSVGDocument
check, and unneeded isConnected check and call titleElementAdded unconditionally. The checks
are now handled by the Document class.
(WebCore::SVGTitleElement::removedFrom): Same for titleElementRemoved.

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText const): Added missing updateLayoutIgnorePendingStylesheets,
since dumping the layer tree without first doing a layout will yield stale results.
(WebCore::Internals::layerIDForElement): Added missing updateLayoutIgnorePendingStylesheets,
since using a renderer to check if a layer exists without first doing a layout will yield stale results.
(WebCore::Internals::setElementUsesDisplayListDrawing): Ditto.
(WebCore::Internals::setElementTracksDisplayListReplay): Ditto.
(WebCore::Internals::displayListForElement): Ditto.
(WebCore::Internals::replayDisplayListForElement): Ditto.
(WebCore::Internals::isSelectPopupVisible): Added missing updateLayoutIgnorePendingStylesheets,
since working with the RenderMenuList without first doing a layout will yield stale results.
Also removed unneeded strict handling of null renderer, instead just returning false.
(WebCore::Internals::isPluginUnavailabilityIndicatorObscured): Removed unnneeded check of
renderer class, since the HTMLPlugInElement::isReplacementObscured already handles that correctly.
(WebCore::Internals::pageOverlayLayerTreeAsText const): Use updateLayoutIgnorePendingStylesheets
instead of the normal updateLayout for consistency with the behavior of the other functions in this
file, and because we need a real answer here.
(WebCore::Internals::scrollSnapOffsets): Ditto. Also rearranged the code so the renderer check is
done after updating the renderer tree.

Tools:

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::setSelectedChild const): Handle null here. The old code instead
would trigger an Objective-C exception unnecessarily.

LayoutTests:

  • svg/hittest/svg-tooltip.svg: Made this test easier to run outside of WebKitTestRunnner,

by removing some overzealous checks.

7:41 PM Changeset in webkit [221660] by wenson_hsieh@apple.com
  • 21 edits
    1 add in trunk

[iOS WK2] Add plumbing for WKContentView to ask the web process for additional drag items
https://bugs.webkit.org/show_bug.cgi?id=176348
Work towards <rdar://problem/31144674>

Reviewed by Tim Horton.

Source/WebKit:

Adds boilerplate plumbing to request additional items to an existing session. This implements some UI-side logic
in WKContentView to send an additional drag items request and handle a response from the web process.
To start, WebPageProxy::requestAdditionalItemsForDragSession is invoked by -_dragInteraction:
itemsForAddingToSession:withTouchAtPoint:completion: in WKContentView, and the response from the web process is
handled in -[WKContentView _didHandleAdditionalDragItemsRequest:].

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _simulateItemsForAddingToSession:atLocation:completion:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Add SPI to simulate a request for additional drag items. See Tools/ChangeLog for more detail.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Add an IPC message handler for the additional drag items response from the web process.

  • UIProcess/ios/DragDropInteractionState.h:

(WebKit::DragDropInteractionState::BlockPtr<void):

  • UIProcess/ios/DragDropInteractionState.mm:

(WebKit::DragDropInteractionState::shouldRequestAdditionalItemForDragSession const):
(WebKit::DragDropInteractionState::dragSessionWillRequestAdditionalItem):

Invoke the new additional items completion handler when tearing down to avoid getting UIKit into a bad state.

(WebKit::DragDropInteractionState::dragAndDropSessionsDidEnd):

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didHandleAdditionalDragItemsRequest):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _didHandleAdditionalDragItemsRequest:]):
(-[WKContentView _itemsForBeginningOrAddingToSessionWithRegistrationList:stagedDragSource:]):

Factors common logic to convert a staged WebItemProviderRegistrationInfoList and DragSourceState into a list of
drag items, invoking the private UI delegate in the process. This is called both when starting a drag session,
and adding items to an existing drag session.

(-[WKContentView _dragInteraction:itemsForAddingToSession:withTouchAtPoint:completion:]):

Implements a (proposed) additional drag item delegate that serves as an asynchronous alternative to the API
variant, -_dragInteraction:itemsForAddingToSession:withTouchAtPoint:. See <rdar://problem/33146803> for more
information.

(-[WKContentView dragInteraction:itemsForBeginningSession:]):

Refactored to use -_itemsForBeginningOrAddingToSessionWithRegistrationList:stagedDragSource:.

(-[WKContentView _simulateItemsForAddingToSession:atLocation:completion:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didHandleAdditionalDragItemsRequest):
(WebKit::WebPageProxy::requestAdditionalItemsForDragSession):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Add an IPC message handler for the additional drag items request from the UI process.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestAdditionalItemsForDragSession):

Tools:

Introduces new test infrastructure to simulate tapping to add additional items to the current drag session. We
add -[DataInteractionSimulator runFrom:to:additionalItemRequestLocations:], for which the last argument is a
dictionary mapping progress (a double between 0 and 1) to NSValues representing the location from which the drag
and drop simulation will request an additional drag item. During the simulated drag and drop, when the progress
value exceeds a value in the map of remaining additional item request locations, we halt drag simulation
progress for that runloop and instead request additional items from the location specified.

The only (useful) passing test we can create using the new machinery is one that verifies that preventDefault()
on dragstart works as expected, preventing additional items from being added. While this trivially passes now,
since the web-process-side of the additional items flow is not yet implemented, it should continue to pass after
the web process portion is implemented.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/selected-text-image-link-and-editable.html: Added.

Add a new test page that contains some non-editable text, an image, a link, and a rich text editable area.

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/ios/DataInteractionSimulator.h:
  • TestWebKitAPI/ios/DataInteractionSimulator.mm:

(-[MockDragDropSession addItems:]):

Convenience method to add additional mock drag items to a drag or drop session.

(-[DataInteractionSimulator _resetSimulatedState]):
(-[DataInteractionSimulator runFrom:to:]):

Converted into a convenience wrapper around the latter version, passing in nil for the additional item request
locations dictionary.

(-[DataInteractionSimulator runFrom:to:additionalItemRequestLocations:]):
(-[DataInteractionSimulator _enqueuePendingAdditionalItemRequestLocations]):
(-[DataInteractionSimulator _sendQueuedAdditionalItemRequest]):

New helper methods to detect when and where additional items should be "added", and subsequently simulate adding
drag items at these given locations.

(-[DataInteractionSimulator _advanceProgress]):

7:37 PM Changeset in webkit [221659] by rniwa@webkit.org
  • 4 edits in trunk/PerformanceTests

Compute the final score using geometric mean in Speedometer 2.0
https://bugs.webkit.org/show_bug.cgi?id=172968

Reviewed by Saam Barati.

Make Speedometer 2.0 use the geometric mean of the subtotal of each test suite instead of the total..

In Speedometer 1.0, we used the total time to compute the final score because we wanted to make
the slowest framework and library faster. The fastest suite (FlightJS) still accounted for ~6% and
the slowest case (React) accounted for ~25% so we felt the total time, or the arithmetic mean with
a constant factor, was a good metric to track.

In the latest version of Speedometer 2.0, however, the fastest suite (Preact) runs in ~55ms whereas
the slowest suite (Inferno) takes 1.5s on Safari. Since the total time is 6.5s, Preact's suite only
accounts for ~0.8% of the total score while Inferno's suite accounts for ~23% of the total score.
Since the goal of Speedometer is to approximate different kinds of DOM API use patterns on the Web,
we want each framework & library to have some measurement impact on the overall benchmark score.

Furthermore, after r221205, we're testing both debug build of Ember.js as well as release build.
Since debug build is 4x slower, using the total time or the arithmetic mean thereof will effectively
give 4x as much weight to debug build of Ember.js relative to release build of Ember.js. Given only
~5% of websites that deploy Ember.js use debug build, this weighting is clearly not right.

This patch, therefore, replaces the arithmetic mean by the geometric mean to compute the final score.
It also moves the code to compute the final score to BenchmarkRunner to be shared between main.js
and InteractiveRunner.html.

  • Speedometer/InteractiveRunner.html:

(.didRunSuites): Show geometric mean, arithmetic mean, total, as well as the score for completeness
since this is a debugging page for developers.

  • Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype.step): Added mean, geomean, and score as measuredValues' properties.
(BenchmarkRunner.prototype._runTestAndRecordResults): Removed the dead code.
(BenchmarkRunner.prototype._finalize): Compute and add total, arithmetic mean (just mean in the code),
and geometric mean (geomean) to measuredValues.

  • Speedometer/resources/main.js:

(window.benchmarkClient): Replaced testsCount by stepsCount and _timeValues by _measuredValuesList.
(window.benchmarkClient.willRunTest):
(window.benchmarkClient.didRunTest):
(window.benchmarkClient.didRunSuites): Store measuredValues object instead of just the total time.
(window.benchmarkClient.didFinishLastIteration):
(window.benchmarkClient._computeResults):
(window.benchmarkClient._computeResults.valueForUnit): Renamed from totalTimeInDisplayUnit. Now simply
retrieves the values computed by BenchmarkRunner's_finalize.
(startBenchmark):
(computeScore): Deleted.

6:23 PM Changeset in webkit [221658] by commit-queue@webkit.org
  • 13 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's mouseDidMoveOverElement
https://bugs.webkit.org/show_bug.cgi?id=176428
<rdar://problem/29270035>

Patch by Alex Christensen <achristensen@webkit.org> on 2017-09-05
Reviewed by Tim Horton.

Source/WebKit:

Covered by a new API test.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::mouseDidMoveOverElement):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::ContextMenuClient::menuFromProposedMenu):
(WebKit::UIDelegate::UIClient::createNewPageCommon):
(WebKit::UIDelegate::UIClient::runJavaScriptAlert):
(WebKit::UIDelegate::UIClient::runJavaScriptConfirm):
(WebKit::UIDelegate::UIClient::runJavaScriptPrompt):
(WebKit::UIDelegate::UIClient::runBeforeUnloadConfirmPanel):
(WebKit::UIDelegate::UIClient::takeFocus):
(WebKit::UIDelegate::UIClient::focus):
(WebKit::UIDelegate::UIClient::unfocus):
(WebKit::UIDelegate::UIClient::didExceedBackgroundResourceLimitWhileInForeground):
(WebKit::UIDelegate::UIClient::didNotHandleWheelEvent):
(WebKit::toNSEventModifierFlags):
(WebKit::UIDelegate::UIClient::mouseDidMoveOverElement):
(WebKit::UIDelegate::UIClient::toolbarsAreVisible):
(WebKit::UIDelegate::UIClient::didClickAutoFillButton):
(WebKit::UIDelegate::UIClient::handleAutoplayEvent):
(WebKit::requestUserMediaAuthorizationForDevices):
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest):
(WebKit::UIDelegate::UIClient::checkUserMediaPermissionForOrigin):
(WebKit::UIDelegate::UIClient::printFrame):
(WebKit::UIDelegate::UIClient::close):
(WebKit::UIDelegate::UIClient::fullscreenMayReturnToInline):
(WebKit::UIDelegate::UIClient::didEnterFullscreen):
(WebKit::UIDelegate::UIClient::didExitFullscreen):
(WebKit::UIDelegate::UIClient::requestPointerLock):
(WebKit::UIDelegate::UIClient::didLosePointerLock):
(WebKit::UIDelegate::UIClient::hasVideoInPictureInPictureDidChange):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::mouseDidMoveOverElement):

  • UIProcess/WebPageProxy.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
(TEST):

  • TestWebKitAPI/cocoa/TestWKWebView.h:
  • TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView mouseMoveToPoint:withFlags:]):

6:18 PM Changeset in webkit [221657] by sbarati@apple.com
  • 3 edits
    1 add in trunk

isNotCellSpeculation is wrong with respect to SpecEmpty
https://bugs.webkit.org/show_bug.cgi?id=176429

Reviewed by Michael Saboff.

JSTests:

  • microbenchmarks/is-not-cell-speculation-for-empty-value.js: Added.

(Foo):

Source/JavaScriptCore:

The isNotCellSpeculation(SpeculatedType t) function was not taking into account
SpecEmpty in the set for t. It should return false when SpecEmpty is present, since
the empty value will fail a NotCell check. This bug would cause us to erroneously
generate NotCellUse UseKinds for inputs that are the empty value, causing repeated OSR exits.

  • bytecode/SpeculatedType.h:

(JSC::isNotCellSpeculation):

6:01 PM Changeset in webkit [221656] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Benchmark Runner WebDriver maximize window on browser launch
https://bugs.webkit.org/show_bug.cgi?id=175702

Patch by Matthew Stewart <matthew_r_stewart@apple.com> on 2017-09-05
Reviewed by Stephanie Lewis.

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:

(LinuxBrowserDriver.launch_webdriver): added driver.maximize_window()

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:

(OSXBrowserDriver._launch_webdriver): added driver.maximize_window()

  • Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:

(WebDriverBenchmarkRunner._run_one_test): added driver.quit()

6:00 PM Changeset in webkit [221655] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

Fix Benchmark Runner selenium autoinstall imports
https://bugs.webkit.org/show_bug.cgi?id=175727

Patch by Matthew Stewart <matthew_r_stewart@apple.com> on 2017-09-05
Reviewed by Stephanie Lewis.

This fixes run-benchmark taking a long time to start with WebDriver.

Inside webdriver's init.py file, it imports many other modules.
So if we try to directly import autoinstalled.selenium.webdriver, it
will re-run the autoinstall init.py for each new imported module
that contains ".selenium"
TODO: fix this inside the autoinstall code, to only do one install per
import.

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:

(LinuxChromeDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:

(LinuxFirefoxDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:

(OSXChromeDriver.launch_driver):
(OSXChromeCanaryDriver.launch_driver):
(create_chrome_options):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:

(OSXFirefoxDriver.launch_driver):
(OSXFirefoxNightlyDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:

(OSXSafariDriver.launch_driver):

  • Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:

(WebDriverBenchmarkRunner._run_one_test):

5:58 PM Changeset in webkit [221654] by matthew_hanson@apple.com
  • 2 edits in tags/Safari-605.1.4.1/Source/WebKit

Cherry-pick r221457. rdar://problem/34186977

5:58 PM Changeset in webkit [221653] by matthew_hanson@apple.com
  • 7 edits in tags/Safari-605.1.4.1/Source

Versioning.

5:53 PM Changeset in webkit [221652] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-605.1.4.1

New Tag.

5:10 PM Changeset in webkit [221651] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-604.1.38.1.7

Tag Safari-604.1.38.1.7.

5:09 PM Changeset in webkit [221650] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-604.2.8

Tag Safari-604.2.8.

4:54 PM Changeset in webkit [221649] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

EWS should report when a step succeeds
https://bugs.webkit.org/show_bug.cgi?id=176332
<rdar://problem/25224607>

Reviewed by Sam Weinig.

Most of the EWSes report only if a step fails, but do not report when a step succeed. For e.g.: If a build succeeds,
EWS does not report it. Information about a step passing is sometimes very valuable, especially when waiting for a
patch to complete processing. Sometimes, patch authors know that their changes are not covered by any tests. Having EWS
display that build was successful and it is currently running tests is valuable.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.command_passed): Update the EWS status server when a command pass. This is
similar to what is done in Commit Queue and Style Queue.

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSystemTest._default_expected_logs): Updated unit-tests appropriately.

4:38 PM Changeset in webkit [221648] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Layout flashing for internal View.prototype.layout
https://bugs.webkit.org/show_bug.cgi?id=176389

Reviewed by Matt Baker.

Add a checkbox to Settings (Debug panel) to draw an orange outline around an element every time View.prototype.layout is called.
This is similar to paint flashing, except this is only for View.prototype.layout.

  • UserInterface/Base/Setting.js:
  • UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createDebugSettingsView):

  • UserInterface/Views/View.js:

(WI.View.prototype._layoutSubtree):
(WI.View.prototype._drawLayoutFlashingOutline):

4:36 PM Changeset in webkit [221647] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit

Relax keychain access to permit users to permanently allow client certificates
https://bugs.webkit.org/show_bug.cgi?id=175857
<rdar://problem/32293867>

Reviewed by Alex Christensen.

Further relax the write permissions on the user's Keychain directory to support local certificates.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
4:33 PM Changeset in webkit [221646] by Ryan Haddad
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r221495.

This change introduced assertion failures on El Capitan Debug
WK2.

Reverted changeset:

"Move ServiceWorkerJob from FetchLoader to ThreadableLoader."
https://bugs.webkit.org/show_bug.cgi?id=176231
http://trac.webkit.org/changeset/221495

4:28 PM Changeset in webkit [221645] by Chris Dumez
  • 11 edits
    7 adds in trunk

Add support for input.webkitEntries
https://bugs.webkit.org/show_bug.cgi?id=176257
<rdar://problem/34218671>

Reviewed by Andreas Kling.

Source/WebCore:

Add support for input.webkitEntries as per:

Our behavior matches Chrome and Firefox, rather than the specification. This means
that webkitEntries is only populated if the webkitdirectory flag is unset.

Tests: fast/forms/file/entries-api/drag-folder-webkitEntries.html

fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/entriesapi/HTMLInputElementEntriesAPI.cpp: Added.

(WebCore::HTMLInputElementEntriesAPI::webkitEntries):

  • Modules/entriesapi/HTMLInputElementEntriesAPI.h: Added.
  • Modules/entriesapi/HTMLInputElementEntriesAPI.idl: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/generate-bindings.pl:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceReflectAttributeGetter):
(WebCore::jsTestInterfaceReflectAttribute):
(WebCore::setJSTestInterfaceReflectAttributeSetter):
(WebCore::setJSTestInterfaceReflectAttribute):

  • bindings/scripts/test/TestSupplemental.idl:
  • html/HTMLInputElement.idl:

LayoutTests:

Add layout test coverage.

  • fast/forms/file/entries-api/drag-folder-webkitEntries-expected.txt: Added.
  • fast/forms/file/entries-api/drag-folder-webkitEntries.html: Added.
  • fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries-expected.txt: Added.
  • fast/forms/file/entries-api/webkitdirectory-drag-folder-webkitEntries.html: Added.
  • http/wpt/entries-api/interfaces-expected.txt:
  • platform/wk2/TestExpectations:
4:25 PM Changeset in webkit [221644] by matthew_hanson@apple.com
  • 7 edits in tags/Safari-605.1.4/Source

Revert r221640. rdar://problem/34186977

4:25 PM Changeset in webkit [221643] by matthew_hanson@apple.com
  • 2 edits in tags/Safari-605.1.4/Source/WebKit

Revert r221641. rdar://problem/34186977

4:18 PM Changeset in webkit [221642] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/001.html as slow.

Unreviewed test gardening.

  • platform/win/TestExpectations:
4:04 PM Changeset in webkit [221641] by matthew_hanson@apple.com
  • 2 edits in tags/Safari-605.1.4/Source/WebKit

Cherry-pick r221457. rdar://problem/34186977

4:01 PM Changeset in webkit [221640] by matthew_hanson@apple.com
  • 7 edits in tags/Safari-605.1.4/Source

Versioning.

3:53 PM Changeset in webkit [221639] by Chris Dumez
  • 6 edits
    5 adds in trunk

FileSystemEntry API should ignore hidden files
https://bugs.webkit.org/show_bug.cgi?id=176292
<rdar://problem/34257666>

Reviewed by Andreas Kling.

Source/WebCore:

FileSystemEntry API should ignore hidden files as the user likely does not mean
to expose those when drag'n dropping a folder.

Test: editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file.html

  • Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::listDirectoryWithMetadata):
(WebCore::validatePathIsExpectedType):
(WebCore::fileType):
(WebCore::DOMFileSystem::getEntry):

LayoutTests:

Add layout test coverage.

  • editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry-expected.txt:
  • editing/pasteboard/enties-api/datatransfer-items-drop-getAsEntry.html:
  • editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file-expected.txt: Added.
  • editing/pasteboard/enties-api/datatransfer-items-drop-hidden-file.html: Added.
  • fast/forms/file/entries-api/resources/testFiles/.hidden.txt: Added.
  • fast/forms/file/entries-api/resources/testFiles/.hidden/hidden.txt: Added.
  • platform/win/TestExpectations:
3:36 PM Changeset in webkit [221638] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked svg/as-image/svg-image-with-data-uri-background.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172877

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
2:30 PM Changeset in webkit [221637] by sbarati@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Make the distinction between entrypoints and CFG roots more clear by naming things better
https://bugs.webkit.org/show_bug.cgi?id=176336

Reviewed by Mark Lam and Keith Miller and Michael Saboff.

This patch does renaming to make the distinction between Graph::m_entrypoints
and Graph::m_numberOfEntrypoints more clear. The source of confusion is that
Graph::m_entrypoints.size() is not equivalent to Graph::m_numberOfEntrypoints.
Graph::m_entrypoints is really just the CFG roots. In CPS, this vector has
size >= 1. In SSA, the size is always 1. This patch renames Graph::m_entrypoints
to Graph::m_roots. To be consistent, this patch also renames Graph's m_entrypointToArguments
field to m_rootToArguments.

Graph::m_numberOfEntrypoints retains its name. This field is only used in SSA
when compiling with EntrySwitch. It represents the logical number of entrypoints
the compilation will end up with. Each EntrySwitch has m_numberOfEntrypoints
cases.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGCFG.h:

(JSC::DFG::CFG::roots):
(JSC::DFG::CPSCFG::CPSCFG):

  • dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::specialCaseArguments):

  • dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::run):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::blocksInPreOrder):
(JSC::DFG::Graph::blocksInPostOrder):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::isRoot):
(JSC::DFG::Graph::isEntrypoint): Deleted.

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):

  • dfg/DFGLoopPreHeaderCreationPhase.cpp:

(JSC::DFG::createPreHeader):

  • dfg/DFGMaximalFlushInsertionPhase.cpp:

(JSC::DFG::MaximalFlushInsertionPhase::run):
(JSC::DFG::MaximalFlushInsertionPhase::treatRegularBlock):

  • dfg/DFGOSREntrypointCreationPhase.cpp:

(JSC::DFG::OSREntrypointCreationPhase::run):

  • dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

  • dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::linkOSREntries):

  • dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):

  • dfg/DFGValidate.cpp:
2:18 PM Changeset in webkit [221636] by jfbastien@apple.com
  • 2 edits in trunk/PerformanceTests

StitchMarker: build fix

2:17 PM Changeset in webkit [221635] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

DataTransferItem tests are timing out on Windows.
https://bugs.webkit.org/show_bug.cgi?id=176423.

Unreviewed test gardening.

  • platform/win/TestExpectations:
2:11 PM Changeset in webkit [221634] by mmaxfield@apple.com
  • 16 edits
    2 copies in trunk/Tools

WSL should support the bool type
https://bugs.webkit.org/show_bug.cgi?id=176285

Reviewed by Filip Pizlo.

Very similar to the int and uint types. This patch also adds support for a logical negation expression "!x".
This patch also reverts the ability of the program author to create their own "operator!()", and instead
adds the ability of the program author to create their own "operator bool()". The code is generic, so
programmers can make two arbitrary types Foo and Bar, and implement a "operator Bar(Foo)." The logical
negation expression is a built-in, and requires its argument be a bool.

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/BoolLiteral.js: Copied from Tools/WebGPUShadingLanguageRI/NativeFunc.js.

(BoolLiteral):
(BoolLiteral.prototype.get value):
(BoolLiteral.prototype.get isConstexpr):
(BoolLiteral.prototype.toString):

  • WebGPUShadingLanguageRI/Checker.js:
  • WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitBoolLiteral):
(Evaluator.prototype.visitLogicalNot):

  • WebGPUShadingLanguageRI/Func.js:

(Func):
(Func.prototype.get isCast):
(Func.prototype.toDeclString):

  • WebGPUShadingLanguageRI/FuncDef.js:

(FuncDef):
(FuncDef.prototype.get body):
(FuncDef.prototype.rewrite):

  • WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

  • WebGPUShadingLanguageRI/Lexer.js:

(Lexer.prototype.next):
(Lexer):

  • WebGPUShadingLanguageRI/LogicalNot.js: Copied from Tools/WebGPUShadingLanguageRI/NativeFunc.js.

(LogicalNot):
(LogicalNot.prototype.get operand):
(LogicalNot.prototype.toString):

  • WebGPUShadingLanguageRI/NativeFunc.js:

(NativeFunc):

  • WebGPUShadingLanguageRI/Parse.js:

(parseTerm):
(parsePossiblePrefix):
(parsePossibleRelationalEquality):
(parseFuncName):
(parseOperatorFuncDefValues):
(parseNonOperatorFuncDefValues):
(parseGenericFuncDefValues):
(parseFuncDecl):
(parseProtocolFuncDecl):
(parseFuncDef):
(parseNative):
(parse):

  • WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitBoolLiteral):
(Rewriter.prototype.visitLogicalNot):
(Rewriter):

  • WebGPUShadingLanguageRI/StandardLibrary.js:
  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/Test.js:

(makeUInt):
(makeBool):
(checkUInt):
(checkBool):
(TEST_literalBool):
(TEST_identityBool):
(TEST_intSimpleMath):
(TEST_uintSimpleMath):
(TEST_equality):
(TEST_logicalNegation):
(TEST_notEquality):
(TEST_equalityTypeFailure):
(TEST_add1): Deleted.

  • WebGPUShadingLanguageRI/TypeDefResolver.js:

(TypeDefResolver.prototype.visitFuncDef):

  • WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitBoolLiteral):
(Visitor.prototype.visitLogicalNot):

2:00 PM Changeset in webkit [221633] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Cache Storage Engine should not mix different origin caches
https://bugs.webkit.org/show_bug.cgi?id=176394

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-05
Reviewed by Alex Christensen.

Source/WebKit:

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::readCachesFromDisk): Initializing the salt before creating the Caches object
so that its persistency path is correctly computed.

  • NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::cachesRootPath): Setting origin as partition string.

LayoutTests:

  • http/tests/cache-storage/cache-origins.https-expected.txt: Added.
  • http/tests/cache-storage/cache-origins.https.html: Added.
  • http/tests/cache-storage/resources/cache-persistency-iframe.html:
1:41 PM Changeset in webkit [221632] by Brent Fulgham
  • 4 edits in trunk/Source/WebKit

Use a single network storage session for stateless connections
https://bugs.webkit.org/show_bug.cgi?id=176386
<rdar://problem/34262148>

Reviewed by Alex Christensen.

Change the name of 'm_dataTaskMapWithoutCredentials' to 'm_dataTaskMapWithoutState'
to reflect that the data tasks do not involve credential or cookie storage. Ditto for
the change from 'm_sessionWIthoutCredentialStorage' to 'm_statelessSession'.

This update should not change behavior, unless some stateless sessions were depending
on cookies to be persistent (which would be a bug!)

  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): Update for new variable names.
(WebKit::NetworkDataTaskCocoa::~NetworkDataTaskCocoa): Ditto.

  • NetworkProcess/cocoa/NetworkSessionCocoa.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa): Update the configuration to block
cookies as well.
(WebKit::NetworkSessionCocoa::invalidateAndCancel): Update for new names.
(WebKit::NetworkSessionCocoa::clearCredentials): Ditto.
(WebKit::NetworkSessionCocoa::dataTaskForIdentifier): Ditto.

1:19 PM Changeset in webkit [221631] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Unskip two tests which was skipped by mistake.

Unreviewed test gardening.

  • platform/win/TestExpectations:
12:57 PM Changeset in webkit [221630] by mmaxfield@apple.com
  • 4 edits
    2 adds in trunk

Update font selection algorithm to match latest CSS spec
https://bugs.webkit.org/show_bug.cgi?id=175236

Reviewed by Darin Adler.

Source/WebCore:

The CSS WG tweaked the generalization of the font selection
algorithm between levels 3 and 4. In particular, the behavior
of weights between 400 and 500 works a little differently.

https://github.com/w3c/csswg-drafts/commit/f6973a21847f1c200ed38bff05dc543cebe1c827

Test: fast/text/variations/font-selection-font-weight.html

  • platform/graphics/FontSelectionAlgorithm.cpp:

(WebCore::FontSelectionAlgorithm::weightDistance const):

  • platform/graphics/FontSelectionAlgorithm.h:

(WebCore::lowerWeightSearchThreshold):
(WebCore::upperWeightSearchThreshold):
(WebCore::weightSearchThreshold): Deleted.

LayoutTests:

  • fast/text/variations/font-selection-font-weight-expected.html: Added.
  • fast/text/variations/font-selection-font-weight.html: Added.
12:56 PM Changeset in webkit [221629] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked media/W3C/video/events/event_progress.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175678

Unreviewed test gardening.

  • platform/wk2/TestExpectations:
12:02 PM Changeset in webkit [221628] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Compile errors in pathByAppendingComponents.
https://bugs.webkit.org/show_bug.cgi?id=176387

Reviewed by Brent Fulgham.

The pathByAppendingComponents function has changed signature.

  • platform/win/FileSystemWin.cpp:

(WebCore::pathByAppendingComponents):

11:17 AM Changeset in webkit [221627] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Fix capitalization of scheduleinvalidateStyleAndLayerComposition
https://bugs.webkit.org/show_bug.cgi?id=176266

Reviewed by Antti Koivisto.

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::scheduleInvalidateStyleAndLayerComposition):
(WebCore::HTMLFrameOwnerElement::scheduleinvalidateStyleAndLayerComposition): Deleted.

  • html/HTMLFrameOwnerElement.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::attachRootLayer):
(WebCore::RenderLayerCompositor::detachRootLayer):
(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):

11:15 AM Changeset in webkit [221626] by Matt Lewis
  • 13 edits in trunk

Unreviewed, rolling out r221603.

This caused accessibility/mac/select-element-selection-with-
optgroups.html to consistently timeout on macOS

Reverted changeset:

"Fix a few minor problems found while working toward removing
unneeded calls to updateStyle"
https://bugs.webkit.org/show_bug.cgi?id=176279
http://trac.webkit.org/changeset/221603

11:08 AM Changeset in webkit [221625] by commit-queue@webkit.org
  • 2 edits
    12 adds in trunk/Source/WebKit

[WinCairo] Add Network Process files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=176069

Patch by Yousuke Kimoto <yousuke.kimoto@sony.com> on 2017-09-05
Reviewed by Alex Christensen.

  • NetworkProcess/Downloads/curl/DownloadCurl.cpp: Added.

(WebKit::Download::resume):
(WebKit::Download::platformDidFinish):
(WebKit::Download::startNetworkLoadWithHandle):
(WebKit::Download::startNetworkLoad):
(WebKit::Download::platformInvalidate):

  • NetworkProcess/EntryPoint/win/NetworkProcessMain.cpp: Added.

(main):

  • NetworkProcess/curl/NetworkProcessCurl.cpp: Added.

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::platformSetURLCacheSize):
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
(WebKit::NetworkProcess::clearCacheForAllOrigins):
(WebKit::NetworkProcess::clearDiskCache):
(WebKit::NetworkProcess::platformTerminate):

  • NetworkProcess/curl/RemoteNetworkingContextCurl.cpp: Added.

(WebKit::RemoteNetworkingContext::~RemoteNetworkingContext):
(WebKit::RemoteNetworkingContext::isValid const):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
(WebKit::RemoteNetworkingContext::storageSession const):
(WebKit::RemoteNetworkingContext::blockedError const):

  • NetworkProcess/win/NetworkProcessMainWin.cpp: Added.

(WebKit::NetworkProcessMainWin):

  • NetworkProcess/win/NetworkProcessMainWin.h: Added.
  • NetworkProcess/win/SystemProxyWin.cpp: Added.

(WindowsSystemProxy::getSystemHttpProxy):
(WindowsSystemProxy::setCurlHttpProxy):
(WindowsSystemProxy::parseProxyString):

  • NetworkProcess/win/SystemProxyWin.h: Added.
  • PlatformWin.cmake:
10:52 AM Changeset in webkit [221624] by commit-queue@webkit.org
  • 18 edits in trunk/Source

Allow retrieving Cache Storage records for a given URL only
https://bugs.webkit.org/show_bug.cgi?id=176202

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-05
Reviewed by Alex Christensen.

Source/WebCore:

No observable change of behavior.

Adding a URL parameter to CacheStorageConnection::retrieveRecords.
If given URL is null, all records will be retrieved, which is useful for the keys method.
Other operations only need records that share the same URL (modulo query string and frag id).

  • Modules/cache/Cache.cpp:

(WebCore::Cache::matchAll):
(WebCore::Cache::keys):
(WebCore::Cache::retrieveRecords):
(WebCore::Cache::queryCache):

  • Modules/cache/Cache.h:
  • Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::retrieveRecords):

  • Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::doRetrieveRecords):

  • Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::WorkerCacheStorageConnection::doRetrieveRecords):

  • Modules/cache/WorkerCacheStorageConnection.h:
  • platform/URL.h:

Source/WebKit:

Update CacheStorageEngineCache to store records as a map URL -> Vector of Records.
This allows regular record retrieval to be faster.
Retrieval of all records is less efficient but this should happen less often.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::retrieveRecords):

  • NetworkProcess/cache/CacheStorageEngine.h:
  • NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::queryCache):
(WebKit::CacheStorage::Cache::retrieveRecords const):
(WebKit::CacheStorage::computeKeyURL):
(WebKit::CacheStorage::Cache::addNewURLRecord):
(WebKit::CacheStorage::Cache::recordsFromURL):
(WebKit::CacheStorage::Cache::recordsFromURL const):
(WebKit::CacheStorage::Cache::put):
(WebKit::CacheStorage::Cache::remove):

  • NetworkProcess/cache/CacheStorageEngineCache.h:
  • NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::retrieveRecords):

  • NetworkProcess/cache/CacheStorageEngineConnection.h:
  • NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
  • WebProcess/Cache/WebCacheStorageConnection.cpp:

(WebKit::WebCacheStorageConnection::doRetrieveRecords):

  • WebProcess/Cache/WebCacheStorageConnection.h:
10:48 AM Changeset in webkit [221623] by commit-queue@webkit.org
  • 5 edits in trunk

WebKitTestRunner should set the cache storage directory path
https://bugs.webkit.org/show_bug.cgi?id=176373

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-05
Reviewed by Chris Dumez.

Source/WebKit:

  • UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationCopyCacheStorageDirectory):
(WKContextConfigurationSetCacheStorageDirectory):

  • UIProcess/API/C/WKContextConfigurationRef.h:

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::generateContextConfiguration const):

10:43 AM Changeset in webkit [221622] by commit-queue@webkit.org
  • 20 edits
    1 add in trunk

test262: Completion values for control flow do not match the spec
https://bugs.webkit.org/show_bug.cgi?id=171265

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-05
Reviewed by Saam Barati.

JSTests:

  • stress/completion-value.js:

Condensed test for completion values in top level statements.

  • stress/super-get-by-id.js:

ClassDeclaration when evaled no longer produce values. Convert
these to ClassExpressions so they produce the class value.

  • ChakraCore/test/GlobalFunctions/evalreturns3.baseline-jsc:

This is a progression for currect spec behavior.

  • mozilla/mozilla-tests.yaml:

This test is now outdated, so mark it as failing for that reason.

  • test262.yaml:

Passing all "cptn" completion value tests.

Source/JavaScriptCore:

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::shouldBeConcernedWithCompletionValue):
When we care about having proper completion values (global code
in programs, modules, and eval) insert undefined results for
control flow statements.

  • bytecompiler/NodesCodegen.cpp:

(JSC::SourceElements::emitBytecode):
Reduce writing a default undefined value to the completion result to
only once before the last statement we know will produce a value.

(JSC::IfElseNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
Insert an undefined to handle cases where code may break out of an
if/else or with statement (break/continue).

(JSC::TryNode::emitBytecode):
Same handling for break cases. Also, finally block statement completion
values are always ignored for the try statement result.

(JSC::ClassDeclNode::emitBytecode):
Class declarations, like function declarations, produce an empty result.

  • parser/Nodes.cpp:

(JSC::SourceElements::lastStatement):
(JSC::SourceElements::hasCompletionValue):
(JSC::SourceElements::hasEarlyBreakOrContinue):
(JSC::BlockNode::lastStatement):
(JSC::BlockNode::singleStatement):
(JSC::BlockNode::hasCompletionValue):
(JSC::BlockNode::hasEarlyBreakOrContinue):
(JSC::ScopeNode::singleStatement):
(JSC::ScopeNode::hasCompletionValue):
(JSC::ScopeNode::hasEarlyBreakOrContinue):
The only non-trivial cases need to loop through their list of statements
to determine if this has a completion value or not. Likewise for
determining if there is an early break / continue, meaning a break or
continue statement with no preceding statement that has a completion value.

  • parser/Nodes.h:

(JSC::StatementNode::next):
(JSC::StatementNode::hasCompletionValue):
Helper to check if a statement nodes produces a completion value or not.

Tools:

  • Scripts/run-jsc-stress-tests:

Include a :failDueToOutdatedOrBadTest to mark failures with justification.

LayoutTests:

  • js/eval-throw-return-expected.txt:
  • js/kde/completion-expected.txt:
  • js/kde/script-tests/completion.js:
  • js/script-tests/eval-throw-return.js:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A9-expected.txt:
  • sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A9.1-expected.txt:

Rebaseline expectations. These are all outdated. In fact the sputnik
tests were imported into test262 and modified for ES2015.

  • js/script-tests/function-toString-vs-name.js:

ClassDeclarations on their own don't produce a value. So output
the class value so the test behaves as expected.

10:36 AM Changeset in webkit [221621] by achristensen@apple.com
  • 11 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's unavailablePluginButtonClicked
https://bugs.webkit.org/show_bug.cgi?id=176274
<rdar://problem/29270035>

Reviewed by Darin Adler.

Source/WebKit:

  • UIProcess/API/APIUIClient.h:

(API::UIClient::unavailablePluginButtonClicked):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setPluginsEnabled:]):
(-[WKPreferences _pluginsEnabled]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::toWKPluginUnavailabilityReason):
(WebKit::UIDelegate::UIClient::unavailablePluginButtonClicked):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::unavailablePluginButtonClicked):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[PluginDelegate _webView:unavailablePluginButtonClickedWithReason:pluginInfo:]):
(TEST):

10:33 AM Changeset in webkit [221620] by achristensen@apple.com
  • 6 edits in trunk/Source/WebKit

Allow classes to have modern and legacy decoders to aid transition
https://bugs.webkit.org/show_bug.cgi?id=176186

Reviewed by Zan Dobersek.

To illustrate this, I made legacy and modern decoders to WTF::String and transitioned one String decoder.

  • Platform/IPC/ArgumentCoder.h:
  • Platform/IPC/ArgumentCoders.cpp:

(IPC::ArgumentCoder<String>::decode):

  • Platform/IPC/ArgumentCoders.h:
  • Platform/IPC/Decoder.h:
  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::decode):

10:19 AM Changeset in webkit [221619] by jmarcell@apple.com
  • 17 edits in branches/safari-604-branch

Cherry-pick r221444. rdar://problem/34215746

9:44 AM Changeset in webkit [221618] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[WPE] Test gardening.
https://bugs.webkit.org/show_bug.cgi?id=176370

Unreviewed test gardening.

Patch by Charlie Turner <cturner@igalia.com> on 2017-09-05

  • platform/wpe/TestExpectations: Updated accordingly.
  • platform/wpe/js/dom/global-constructors-attributes-expected.txt: Rebaselined
8:52 AM Changeset in webkit [221617] by timothy_horton@apple.com
  • 8 edits
    17 deletes in trunk/Source

Remove some unused bits of code and resources
https://bugs.webkit.org/show_bug.cgi?id=176275

Reviewed by Dan Bernstein.

Source/WebCore:

No new tests, just removing things.

  • Resources/textAreaResizeCorner.tiff: Removed.
  • Resources/missingImage.tiff: Removed.

These files have PNG versions that include more resolutions.

  • Resources/hScrollControl_left.png: Removed.
  • Resources/hScrollControl_middle.png: Removed.
  • Resources/hScrollControl_right.png: Removed.
  • Resources/vScrollControl_bottom.png: Removed.
  • Resources/vScrollControl_middle.png: Removed.
  • Resources/vScrollControl_top.png: Removed.
  • Resources/decrementArrow.tiff: Removed.
  • Resources/incrementArrow.tiff: Removed.
  • Resources/markedLeft.png: Removed.
  • Resources/markedMiddle.png: Removed.
  • Resources/markedRight.png: Removed.

These were added in r161638 as part of the iOS upstreaming, but were
unused even then.

  • Resources/inputSpeech.tiff: Removed.

The feature this image was for was removed in r172259; the PNG version
of this image was removed in r172384.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ios/FileSystemIOS.h: Removed.
  • platform/ios/FileSystemIOS.mm: Removed.

Remove FileSystemIOS; one function is unused, the other is not at all
iOS-specific and can be folded into FileSystemCocoa.

  • platform/FileSystem.h:
  • platform/cocoa/FileSystemCocoa.mm:

(WebCore::createTemporaryDirectory):
Move this in from FileSystemIOS.

  • platform/PlatformEvent.cpp: Removed.

Remove this unused file.

  • platform/ios/QuickLook.mm:
  • platform/ios/WebItemProviderPasteboard.mm:

Include FileSystem instead of FileSystemIOS.

Source/WebKitLegacy/mac:

  • Misc/WebNSFileManagerExtras.mm:

Include FileSystem instead of FileSystemIOS.

8:44 AM Changeset in webkit [221616] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Skip service workers tests on Windows.

Unreviewed test gardening.

  • platform/win/TestExpectations:
7:01 AM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
6:58 AM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
6:38 AM Changeset in webkit [221615] by commit-queue@webkit.org
  • 8 edits
    4 adds in trunk

Use TilesBacking for iframes when async frame scrolling is enabled
https://bugs.webkit.org/show_bug.cgi?id=173644

Patch by Frederic Wang <fwang@igalia.com> on 2017-09-05
Reviewed by Simon Fraser.

Source/WebCore:

This patch adds creation of TilesBacking for non-main frames when async frame scrolling is
enabled. RenderLayerBacking::m_isMainFrameLayerWithTiledBacking is also renamed to reflect
that tiled backing is not exclusive to the main frame. More adjustments might be needed for
non-main frames and will be handled in follow-up commits.

Test: compositing/tiling/tiled-drawing-async-frame-scrolling.html

  • rendering/RenderLayerBacking.cpp: Rename m_isMainFrameLayerWithTiledBacking
  • rendering/RenderLayerBacking.h: Rename isMainFrameLayerWithTiledBacking and

m_isMainFrameLayerWithTiledBacking.

  • rendering/RenderLayerCompositor.cpp: Use isFrameLayerWithTiledBacking

Source/WebKit:

This patch adds creation of TilesBacking for non-main frames when async frame scrolling is
enabled. RenderLayerBacking::m_isMainFrameLayerWithTiledBacking is also renamed to reflect
that tiled backing is not exclusive to the main frame. More adjustments might be needed for
non-main frames and will be handled in follow-up commits.

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::shouldUseTiledBackingForFrameView): Also use tiled
backing when asyncFrameScrollingEnabled is true.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrameView): Ditto.

LayoutTests:

This patch adds a test to verify the graphic layers created for frames when async scrolling
is enabled. On iOS and macOS and WK2, new layers appear for the tiled content, scroll bars...

  • compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Added.
  • compositing/tiling/tiled-drawing-async-frame-scrolling.html: Added.
  • platform/ios-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Added.
  • platform/mac-wk2/compositing/tiling/tiled-drawing-async-frame-scrolling-expected.txt: Added.
4:31 AM Changeset in webkit [221614] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

HTMLMediaElement: attach any existing EME CDMInstance in mediaEngineWasUpdated()
https://bugs.webkit.org/show_bug.cgi?id=176354

Reviewed by Xabier Rodriguez-Calvar.

It's common for MediaKeys to be set on an HTMLMediaElement object before
any resource is loaded for that element, meaning no underlying MediaPlayer
exists at that point. In order to not stall the pipeline when encrypted
content is finally loaded, the CDMInstance object of the current MediaKeys
set on this element should be attached in mediaEngineWasUpdated() that's
called whenever the underlying MediaPlayerPrivate object is replaced.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaEngineWasUpdated):

4:29 AM Changeset in webkit [221613] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[EME] HTMLMediaElement: setMediaKeys() should attach CDMInstance from the arriving MediaKeys
https://bugs.webkit.org/show_bug.cgi?id=176352

Reviewed by Xabier Rodriguez-Calvar.

In HTMLMediaElement::setMediaKeys(), use the incoming MediaKeys object
to retrieve the CDMInstance that is then attached to the current
MediaPlayer, if any.

Covered by existing W3C tests that focus on multi-key use cases.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setMediaKeys):

1:20 AM Changeset in webkit [221612] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[Win] Fix the wincairo build after r221558 and r221583
https://bugs.webkit.org/show_bug.cgi?id=176353

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-09-05
Reviewed by Yusuke Suzuki.

Source/WebCore:

  • platform/win/FileSystemWin.cpp:

(WebCore::isSymbolicLink): Fix a "missing type specifier" error
(WebCore::findDataToFileMetadata): Fix a narrowing convertion error

Source/WTF:

  • wtf/Assertions.cpp:
1:17 AM Changeset in webkit [221611] by commit-queue@webkit.org
  • 3 edits in trunk/PerformanceTests

Speedometer 2.0: Add dummy node to notify app is ready for Backbone suite
https://bugs.webkit.org/show_bug.cgi?id=176142

Patch by Shiyu Zhang <shiyu.zhang@intel.com> on 2017-09-05
Reviewed by Ryosuke Niwa.

Create a dummy node to notify that app is ready for Backbone suite. It prevents Speedometer injecting items before app.js is loaded.

  • Speedometer/resources/tests.js:

(Suites.push.prepare):

  • Speedometer/resources/todomvc/architecture-examples/backbone/js/app.js:
12:59 AM WebKitGTK/2.16.x edited by tpopela@redhat.com
(diff)
12:39 AM Changeset in webkit [221610] by Carlos Garcia Campos
  • 15 edits
    1 copy
    1 add
    1 delete in trunk/Source/WebKit

[GTK] Rename PLUGIN_ARCHITECTURE(X11) as PLUGIN_ARCHITECTURE(UNIX)
https://bugs.webkit.org/show_bug.cgi?id=176330

Reviewed by Michael Catanzaro.

It's no longer X11 specific since it's also used in Wayland when the X11 target is enabled. It should be renamed
as UNIX and make it available when building the wayland target even if the X11 on is disabled.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • PluginProcess/unix/PluginProcessMainUnix.cpp:
  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):

  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • Shared/Plugins/Netscape/unix/NetscapePluginModuleUnix.cpp: Renamed from Source/WebKit/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp.
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/gtk/PluginInfoCache.cpp:

(WebKit::PluginInfoCache::getPluginInfo):
(WebKit::PluginInfoCache::updatePluginInfo):

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_InvalidateRect):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::initialize):
(WebKit::NetscapePlugin::destroy):
(WebKit::NetscapePlugin::geometryDidChange):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp:
  • WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.h:
  • config.h:
12:19 AM WebKitGTK/2.18.x edited by calvaris@igalia.com
(diff)
12:16 AM Changeset in webkit [221609] by Carlos Garcia Campos
  • 26 edits
    1 copy
    1 add
    1 delete in trunk

[GTK] Wrong use of PLUGIN_ARCHITECTURE(X11) in several places
https://bugs.webkit.org/show_bug.cgi?id=176329

Reviewed by Michael Catanzaro.

.:

Only define MOZ_X11 if X11 target is enabled and always define XP_UNIX if NETSCAPE_PLUGIN_API is enabled.

  • Source/cmake/OptionsGTK.cmake:

Source/WebKit:

We are using PLUGIN_ARCHITECTURE(X11) in several places where we should actually be using PLATFORM(X11). This is
confusing because PLUGIN_ARCHITECTURE(X11) is no longer specific to X11, it will be renamed as UNIX in a follow
up patch. Because of this we only support plugins in Wayland when building with both X11 and Wayland targets
enabled.

  • PluginProcess/PluginControllerProxy.cpp:
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/unix/PluginProcessMainUnix.cpp:
  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::NetscapePluginModule::determineQuirks):

  • Shared/Plugins/PluginQuirks.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/gtk/WebPageProxyGtk.cpp:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::shouldLoadSrcURL):
(WebKit::NetscapePlugin::initialize):

  • WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp:

(WebKit::NetscapePlugin::platformHandleMouseEvent):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginProxy.cpp:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/Plugins/PluginView.h:

Tools:

  • CMakeLists.txt: Build TestNetscapePlugIn when NETSCAPE_PLUGIN_API is enabled and only link to X11 libraries

when building the X11 target.

  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
  • DumpRenderTree/TestNetscapePlugIn/Tests/unix/CallInvalidateRectWithNullNPPArgument.cpp: Renamed from Tools/DumpRenderTree/TestNetscapePlugIn/Tests/x11/CallInvalidateRectWithNullNPPArgument.cpp.
  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NP_Initialize):
(NPP_HandleEvent):
(NPP_GetValue):

Sep 4, 2017:

9:55 PM Changeset in webkit [221608] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Use StringView more in DOMFileSystem code
https://bugs.webkit.org/show_bug.cgi?id=176347

Reviewed by Darin Adler.

  • Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::resolveRelativeVirtualPath):
(WebCore::DOMFileSystem::evaluatePath):

  • platform/FileSystem.h:
  • platform/glib/FileSystemGlib.cpp:

(WebCore::pathByAppendingComponents):

  • platform/posix/FileSystemPOSIX.cpp:

(WebCore::pathByAppendingComponents):

  • platform/win/FileSystemWin.cpp:

(WebCore::pathByAppendingComponents):

9:10 PM Changeset in webkit [221607] by sbarati@apple.com
  • 21 edits
    1 add in trunk

typeCheckHoistingPhase may emit a CheckStructure on the empty value which leads to a dereference of zero on 64 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=176317

Reviewed by Keith Miller.

JSTests:

  • stress/dont-crash-when-hoist-check-structure-on-tdz.js: Added.

(Foo):

Source/JavaScriptCore:

It turns out that TypeCheckHoistingPhase may hoist a CheckStructure up to
the SetLocal of a particular value where the value is the empty JSValue.
On 64-bit platforms, the empty value is zero. This means that the empty value
passes a cell check. This will lead to a crash when we dereference null to load
the value's structure. This patch teaches TypeCheckHoistingPhase to be conservative
in the structure checks it hoists. On 64-bit platforms, instead of emitting a
CheckStructure node, we now emit a CheckStructureOrEmpty node. This node allows
the empty value to flow through. If the value isn't empty, it'll perform the normal
structure check that CheckStructure performs. For now, we only emit CheckStructureOrEmpty
on 64-bit platforms since a cell check on 32-bit platforms does not allow the empty
value to flow through.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGArgumentsEliminationPhase.cpp:
  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertCheckStructureOrEmptyToCheckStructure):
(JSC::DFG::Node::hasStructureSet):

  • dfg/DFGNodeType.h:
  • dfg/DFGObjectAllocationSinkingPhase.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::SafeToExecuteEdge):
(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::SafeToExecuteEdge::maySeeEmptyChild):
(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitStructureCheck):
(JSC::DFG::SpeculativeJIT::compileCheckStructure):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):

  • dfg/DFGValidate.cpp:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckStructureOrEmpty):

8:44 PM Changeset in webkit [221606] by eric.carlson@apple.com
  • 13 edits
    1 add in trunk

Switch HTMLMediaElement to release logging
https://bugs.webkit.org/show_bug.cgi?id=176065

Reviewed by Jer Noble.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::privateBrowsingStateDidChange): Disable the logger when private browsing
mode is enabled.
(WebCore::Document::logger const):

  • dom/Document.h:

Convert debug-only logging to configurable release logging.

  • html/HTMLMediaElement.cpp:

(PAL::LogArgument<WebCore::URL>::toString): Logger template for URL that returns the url as a
String when only when the LOG_DISABLED build flag is not defined. Returns "[url]" when it is.

  • html/HTMLMediaElement.h:

Source/WTF:

  • wtf/MediaTime.cpp:

(WTF::MediaTime::dump const): Use toString.
(WTF::MediaTime::toString const): New.

Tools:

  • TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::LogObserver::level const):

8:39 PM Changeset in webkit [221605] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

[Canvas] Move non-standard functionality/aliases back to CanvasRenderingContext2D.idl
https://bugs.webkit.org/show_bug.cgi?id=176340

Patch by Sam Weinig <sam@webkit.org> on 2017-09-04
Reviewed by Darin Adler.

In r221598 (https://webkit.org/b/176276), the CanvasRenderingContext2D was split out into
separate interfaces to the match the spec and prepare for implementing OffscreenCanvas. While
doing that, related non-standard functionality and aliases were moved as well. In retrospect,
that doesn't really makes sense, as we don't want to add these legacy properties to any new
interfaces that happen to implement/use the broken out interfaces. Since they are specific
to CanvasRenderingContext2D, let's move them back.

  • html/canvas/CanvasCompositing.idl:
  • html/canvas/CanvasDrawImage.idl:
  • html/canvas/CanvasFillStrokeStyles.idl:
  • html/canvas/CanvasImageData.idl:
  • html/canvas/CanvasImageSmoothing.idl:
  • html/canvas/CanvasPathDrawingStyles.idl:
  • html/canvas/CanvasShadowStyles.idl:
  • html/canvas/CanvasRenderingContext2D.idl:

Move non-standard operation and attributes back to CanvasRenderingContext2D.idl.

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::stringForCanvasFillRule): Deleted.

Remove unused function.

(WebCore::CanvasRenderingContext2D::setAlpha): Deleted.
(WebCore::CanvasRenderingContext2D::setCompositeOperation): Deleted.

Removed. Instead, the IDL uses [ImplementedAs] to forward to the
underlying setGlobalAlpha/setGlobalCompositeOperation. This reduces
code and makes it clear they are strict aliases.

8:31 PM Changeset in webkit [221604] by yoav@yoav.ws
  • 3 edits in trunk/LayoutTests

[iOS Simulator] http/tests/preload/viewport/meta-viewport-link-headers.php is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=172518

This unflakes the test by downloading a "timer" image and kicking off the timer that runs the
test only once that image was downloaded, while potentially waiting for the preloaded images to arrive,
up to 1 second.
That means that slow test environments would have a longer timer than today, avoiding flakiness.

Reviewed by Youenn Fablet.

  • http/tests/preload/viewport/meta-viewport-link-headers.php: Add a "timer" image, which load event starts the test.
  • platform/ios/TestExpectations: Unflake the test in expectations.
8:29 PM Changeset in webkit [221603] by Darin Adler
  • 13 edits in trunk

Fix a few minor problems found while working toward removing unneeded calls to updateStyle
https://bugs.webkit.org/show_bug.cgi?id=176279

Reviewed by Antti Koivisto.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::updateTitleElement): Fix the algorithm so that an SVG title won't
ever become the title when the document element is not an SVG element. We had this wrong
before but we were passing the test because SVGTitleElement::insertedInto had a bug that
hid the problem.
(WebCore::Document::titleElementAdded): Pass a reference instead of a pointer.
(WebCore::Document::titleElementRemoved): Pass a reference instead of nullptr since we
want to know which element is being removed.

  • dom/Document.h: Update the argument name and type for updateTitleElement.
  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::insertedInto): Call titleElementAdded unconditionally.
The checks to see if the title element is connected to the document and not in the
shadow tree are now handled by the Document class.
(WebCore::HTMLTitleElement::removedFrom): Same for titleElementRemoved.

  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::applySize): Removed incorrect caching of FontCascade
objects; these need to be created each time we draw.
(WebCore::MockRealtimeVideoSource::drawText): Create all the fonts here. Since this is
a mock for testing, there is no real performance concern with doing this.

  • platform/mock/MockRealtimeVideoSource.h: Removed the FontCascade data members.
  • rendering/RenderTreeAsText.cpp:

(WebCore::updateLayoutIgnoringPendingStylesheetsIncludingSubframes): Added. Used below
to update layout more thoroughly.
(WebCore::externalRepresentation): Update layout of all descendant frames, not just
the top level frame.

  • svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::insertedInto): Removed bogus firstChild check, bogus isSVGDocument
check, and unneeded isConnected check and call titleElementAdded unconditionally. The checks
are now handled by the Document class.
(WebCore::SVGTitleElement::removedFrom): Same for titleElementRemoved.

  • testing/Internals.cpp:

(WebCore::Internals::layerTreeAsText const): Added missing updateLayoutIgnorePendingStylesheets,
since dumping the layer tree without first doing a layout will yield stale results.
(WebCore::Internals::layerIDForElement): Added missing updateLayoutIgnorePendingStylesheets,
since using a renderer to check if a layer exists without first doing a layout will yield stale results.
(WebCore::Internals::setElementUsesDisplayListDrawing): Ditto.
(WebCore::Internals::setElementTracksDisplayListReplay): Ditto.
(WebCore::Internals::displayListForElement): Ditto.
(WebCore::Internals::replayDisplayListForElement): Ditto.
(WebCore::Internals::isSelectPopupVisible): Added missing updateLayoutIgnorePendingStylesheets,
since working with the RenderMenuList without first doing a layout will yield stale results.
Also removed unneeded strict handling of null renderer, instead just returning false.
(WebCore::Internals::isPluginUnavailabilityIndicatorObscured): Removed unnneeded check of
renderer class, since the HTMLPlugInElement::isReplacementObscured already handles that correctly.
(WebCore::Internals::pageOverlayLayerTreeAsText const): Use updateLayoutIgnorePendingStylesheets
instead of the normal updateLayout for consistency with the behavior of the other functions in this
file, and because we need a real answer here.
(WebCore::Internals::scrollSnapOffsets): Ditto. Also rearranged the code so the renderer check is
done after updating the renderer tree.

Tools:

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::setSelectedChild const): Handle null here. The old code instead
would trigger an Objective-C exception unnecessarily.

LayoutTests:

  • svg/hittest/svg-tooltip.svg: Made this test easier to run outside of WebKitTestRunnner,

by removing some overzealous checks.

8:21 PM Changeset in webkit [221602] by sbarati@apple.com
  • 41 edits in trunk/Source/JavaScriptCore

Support compiling catch in the FTL
https://bugs.webkit.org/show_bug.cgi?id=175396

Reviewed by Filip Pizlo.

This patch implements op_catch in the FTL. It extends the DFG implementation
by supporting multiple entrypoints in DFG-SSA. This patch implements this
by introducing an EntrySwitch node. When converting to SSA, we introduce a new
root block with an EntrySwitch that has the previous DFG entrypoints as its
successors. By convention, we pick the zeroth entry point index to be the
op_enter entrypoint. Like in B3, in DFG-SSA, EntrySwitch just acts like a
switch over the entrypoint index argument. DFG::EntrySwitch in the FTL
simply lowers to B3::EntrySwitch. The EntrySwitch in the root block that
SSAConversion creates can not exit because we would both not know where to exit
to in the program: we would not have valid OSR exit state. This design also
mandates that anything we hoist above EntrySwitch in the new root block
can not exit since they also do not have valid OSR exit state.

This patch also adds a new metadata node named InitializeEntrypointArguments.
InitializeEntrypointArguments is a metadata node that initializes the flush format for
the arguments at a given entrypoint. For a given entrypoint index, this node
tells AI and OSRAvailabilityAnalysis what the flush format for each argument
is. This allows each individual entrypoint to have an independent set of
argument types. Currently, this won't happen in practice because ArgumentPosition
unifies flush formats, but this is an implementation detail we probably want
to modify in the future. SSAConversion will add InitializeEntrypointArguments
to the beginning of each of the original DFG entrypoint blocks.

This patch also adds the ability to specify custom prologue code generators in Air.
This allows the FTL to specify a custom prologue for catch entrypoints that
matches the op_catch OSR entry calling convention that the DFG uses. This way,
the baseline JIT code OSR enters into op_catch the same way both in the DFG
and the FTL. In the future, we can use this same mechanism to perform stack
overflow checks instead of using a patchpoint.

  • b3/air/AirCode.cpp:

(JSC::B3::Air::Code::isEntrypoint):
(JSC::B3::Air::Code::entrypointIndex):

  • b3/air/AirCode.h:

(JSC::B3::Air::Code::setPrologueForEntrypoint):
(JSC::B3::Air::Code::prologueGeneratorForEntrypoint):

  • b3/air/AirGenerate.cpp:

(JSC::B3::Air::generate):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGBasicBlock.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCFG.h:

(JSC::DFG::selectCFG):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGClobbersExitState.cpp:

(JSC::DFG::clobbersExitState):

  • dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::shrinkToFit):
(JSC::DFG::CommonData::finalizeCatchEntrypoints):

  • dfg/DFGCommonData.h:

(JSC::DFG::CommonData::catchOSREntryDataForBytecodeIndex):
(JSC::DFG::CommonData::appendCatchEntrypoint):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::invalidateCFG):
(JSC::DFG::Graph::ensureCPSCFG):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::isEntrypoint):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::shrinkToFit):
(JSC::DFG::JITCode::finalizeOSREntrypoints):

  • dfg/DFGJITCode.h:

(JSC::DFG::JITCode::catchOSREntryDataForBytecodeIndex): Deleted.
(JSC::DFG::JITCode::appendCatchEntrypoint): Deleted.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::noticeCatchEntrypoint):
(JSC::DFG::JITCompiler::makeCatchOSREntryBuffer):

  • dfg/DFGMayExit.cpp:
  • dfg/DFGNode.h:

(JSC::DFG::Node::isEntrySwitch):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::entrySwitchData):
(JSC::DFG::Node::numSuccessors):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::entrypointIndex):

  • dfg/DFGNodeType.h:
  • dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareCatchOSREntry):

  • dfg/DFGOSREntry.h:
  • dfg/DFGOSREntrypointCreationPhase.cpp:

(JSC::DFG::OSREntrypointCreationPhase::run):

  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::SSAConversionPhase):
(JSC::DFG::SSAConversionPhase::run):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::linkOSREntries):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStaticExecutionCountEstimationPhase.cpp:

(JSC::DFG::StaticExecutionCountEstimationPhase::run):

  • dfg/DFGValidate.cpp:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileExtractCatchLocal):
(JSC::FTL::DFG::LowerDFGToB3::compileGetStack):
(JSC::FTL::DFG::LowerDFGToB3::compileEntrySwitch):
(JSC::FTL::DFG::LowerDFGToB3::speculate):
(JSC::FTL::DFG::LowerDFGToB3::appendOSRExitDescriptor):
(JSC::FTL::DFG::LowerDFGToB3::appendOSRExit):
(JSC::FTL::DFG::LowerDFGToB3::blessSpeculation):

  • ftl/FTLOutput.cpp:

(JSC::FTL::Output::entrySwitch):

  • ftl/FTLOutput.h:
  • jit/JITOperations.cpp:
8:03 PM Changeset in webkit [221601] by Yusuke Suzuki
  • 23 edits
    10 adds in trunk

[DFG][FTL] Efficiently execute number#toString()
https://bugs.webkit.org/show_bug.cgi?id=170007

Reviewed by Keith Miller.

JSTests:

  • microbenchmarks/number-to-string-strength-reduction.js: Added.

(test):

  • microbenchmarks/number-to-string-with-radix-10.js: Added.

(test):

  • microbenchmarks/number-to-string-with-radix-cse.js: Added.

(test):

  • microbenchmarks/number-to-string-with-radix.js: Added.

(test):

  • stress/number-to-string-strength-reduction.js: Added.

(shouldBe):
(test):

  • stress/number-to-string-with-radix-10.js: Added.

(shouldBe):
(test):

  • stress/number-to-string-with-radix-cse.js: Added.

(shouldBe):
(test):

  • stress/number-to-string-with-radix-invalid.js: Added.

(shouldThrow):

  • stress/number-to-string-with-radix-watchpoint.js: Added.

(shouldBe):
(test):
(i.i.1e3.Number.prototype.toString):

  • stress/number-to-string-with-radix.js: Added.

(shouldBe):
(test):

Source/JavaScriptCore:

In JS, the natural way to convert number to string with radix is number.toString(radix).
However, our IC only cares about cells. If the base value is a number, it always goes to the slow path.

While extending our IC for number and boolean, the most meaningful use of this IC is calling number.toString(radix).
So, in this patch, we first add a fast path for this in DFG by using watchpoint. We set up a watchpoint for
Number.prototype.toString. And if this watchpoint is kept alive and GetById(base, "toString")'s base should be
speculated as Number, we emit Number related Checks and convert GetById to Number.prototype.toString constant.
It removes costly GetById slow path, and makes it non-clobbering node (JSConstant).

In addition, we add NumberToStringWithValidRadixConstant node. We have NumberToStringWithRadix node, but it may
throw an error if the valid value is incorrect (for example, number.toString(2000)). So its clobbering rule is
conservatively use read(World)/write(Heap). But in reality, number.toString is mostly called with the constant
radix, and we can easily figure out this radix is valid (2 <= radix && radix < 32).
We add a rule to the constant folding phase to convert NumberToStringWithRadix to NumberToStringWithValidRadixConstant.
It ensures that it has valid constant radix. And we relax our clobbering rule for NumberToStringWithValidRadixConstant.

Added microbenchmarks show performance improvement.

baseline patched

number-to-string-with-radix-cse 43.8312+-1.3017 7.4930+-0.5105 definitely 5.8496x faster
number-to-string-with-radix-10 7.2775+-0.5225 2.1906+-0.1864 definitely 3.3222x faster
number-to-string-with-radix 39.7378+-1.4921 16.6137+-0.7776 definitely 2.3919x faster
number-to-string-strength-reduction 94.9667+-2.7157 9.3060+-0.7202 definitely 10.2049x faster

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::isWatchingGlobalObjectWatchpoint):
(JSC::DFG::Graph::isWatchingArrayIteratorProtocolWatchpoint):
(JSC::DFG::Graph::isWatchingNumberToStringWatchpoint):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToNumberToStringWithValidRadixConstant):
(JSC::DFG::Node::hasValidRadixConstant):
(JSC::DFG::Node::validRadixConstant):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToStringOrCallStringConstructor):
(JSC::DFG::SpeculativeJIT::compileNumberToStringWithValidRadixConstant):
(JSC::DFG::SpeculativeJIT::compileToStringOrCallStringConstructorOnNumber): Deleted.

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileNumberToStringWithValidRadixConstant):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::numberToStringWatchpoint):
(JSC::JSGlobalObject::numberProtoToStringFunction const):

  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::finishCreation):
(JSC::toStringWithRadixInternal):
(JSC::toStringWithRadix):
(JSC::int32ToStringInternal):
(JSC::numberToStringInternal):

  • runtime/NumberPrototype.h:
6:48 PM Changeset in webkit [221600] by Yusuke Suzuki
  • 13 edits in trunk/Source

Remove OS(SOLARIS) support
https://bugs.webkit.org/show_bug.cgi?id=176341

Reviewed by Sam Weinig.

Source/WebCore:

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

  • dom/make_names.pl:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::platform):

  • page/Page.h:

Source/WTF:

WebKit project does not have stake holders supporting Solaris right now.
And Solaris + SPARC in 64bit environment does not work well since its
address space includes non-48bit area. It breaks our JSVALUE64 in JSC.
In addition, Solaris a bit complicates our threading implementation
because of its special threading stack.

This patch removes OS(SOLARIS) and COMPILER(SUNCC) support from WebKit.

  • wtf/Compiler.h:
  • wtf/InlineASM.h:
  • wtf/MathExtras.h:

(std::isfinite): Deleted.
(std::signbit): Deleted.
(std::isinf): Deleted.

  • wtf/NumberOfCores.cpp:

(WTF::numberOfProcessorCores):

  • wtf/Platform.h:
  • wtf/StackBounds.cpp:
  • wtf/ThreadingPthreads.cpp:
6:13 PM Changeset in webkit [221599] by Yusuke Suzuki
  • 2 edits in trunk/Source/WebCore

Unreviewed, fixing unused constant for initial buffer size
https://bugs.webkit.org/show_bug.cgi?id=176310

Follow-up patch after r221583. Pointed by darin@.

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

5:23 PM Changeset in webkit [221598] by weinig@apple.com
  • 39 edits
    3 moves
    29 adds in trunk

[Canvas] Split CanvasRenderingContext2D.idl into separate IDLs to match current HTML spec
https://bugs.webkit.org/show_bug.cgi?id=176276

Reviewed by Dean Jackson.

Source/WebCore:

  • Splits CanvasRenderingContext2D.idl out into:

CanvasState
CanvasTransform
CanvasCompositing
CanvasImageSmoothing
CanvasFillStrokeStyles
CanvasShadowStyles
CanvasFilters
CanvasRect
CanvasDrawPath
CanvasUserInterface
CanvasText
CanvasDrawImage
CanvasImageData
CanvasPathDrawingStyles
CanvasTextDrawingStyles

  • Renames CanvasWindingRule enum to CanvasFillRule, and moves it to its own file so it can be reused by multiple IDLs.
  • Renames DOMPath to Path2D, which is what it is supposed to be called, and doesn't conflict with any WebCore names.
  • Converts lineCap, lineJoin, textAlign, textBaseline, direction to use enums, rather than DOMStrings, allowing us to remove a bunch of custom parsing.
  • Non-standard canvas API was grouped with related functionality in the broken out IDLs and clearly marked as non-standard.
  • Comments were added for places where we break with the standard, mostly around use of float where we should be using double.
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:


Add new files.


  • bindings/js/CallTracerTypes.h:
  • inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):

Update for renames, and use new convertEnumerationToString to
serialize enumerations.


  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateEnumerationImplementationContent):
(GenerateEnumerationHeaderContent):

Split string conversion out of convertEnumerationToJS, and into
its own function, convertEnumerationToString, to allow serialization
to string outside of the bindings context, in this case, for the
InspectorCanvas.

(GenerateParametersCheck):

Improve error message to make it clear which operation has the issue
in order to make debugging easier.

  • html/ImageData.idl:


Re-order constructors to match specification, and add FIXME for incorrect
default argument.


  • html/TextMetrics.idl:


Add spec'd exposure and spec comments, as well a FIXME to convert the
unrestricted float parameters should be doubles.

  • html/canvas/CanvasCompositing.idl: Added.
  • html/canvas/CanvasDirection.h: Added.
  • html/canvas/CanvasDirection.idl: Added.
  • html/canvas/CanvasDrawImage.idl: Added.
  • html/canvas/CanvasDrawPath.idl: Added.
  • html/canvas/CanvasFillRule.h: Added.
  • html/canvas/CanvasFillRule.idl: Added.
  • html/canvas/CanvasFillStrokeStyles.idl: Added.
  • html/canvas/CanvasFilters.idl: Added.
  • html/canvas/CanvasImageData.idl: Added.
  • html/canvas/CanvasImageSmoothing.idl: Added.
  • html/canvas/CanvasLineCap.h: Added.
  • html/canvas/CanvasLineCap.idl: Added.
  • html/canvas/CanvasLineJoin.h: Added.
  • html/canvas/CanvasLineJoin.idl: Added.
  • html/canvas/CanvasPathDrawingStyles.idl: Added.
  • html/canvas/CanvasRect.idl: Added.
  • html/canvas/CanvasShadowStyles.idl: Added.
  • html/canvas/CanvasState.idl: Added.
  • html/canvas/CanvasText.idl: Added.
  • html/canvas/CanvasTextAlign.h: Added.
  • html/canvas/CanvasTextAlign.idl: Added.
  • html/canvas/CanvasTextBaseline.h: Added.
  • html/canvas/CanvasTextBaseline.idl: Added.
  • html/canvas/CanvasTextDrawingStyles.idl: Added.
  • html/canvas/CanvasTransform.idl: Added.
  • html/canvas/CanvasUserInterface.idl: Added.
  • html/canvas/ImageSmoothingQuality.h: Added.
  • html/canvas/ImageSmoothingQuality.idl: Added.

Move CanvasRenderingContext2D.idl content into separate files to
match the specification.

  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasPath.idl:
  • html/canvas/CanvasPattern.idl:

Add exposure and FIXMEs on changes need to match the spec.

  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/CanvasRenderingContext2D.h:

Switch to using enums for lineCap, lineJoin, textAlign, textBaseline, and direction.
Rather than using the parsing / stringifying functions from GraphicsTypes, add simple
switch based to/from converters to convert to/from the canvas type to the platform
type. Also update for rename of DOMPath -> Path2D and WindingRule -> CanvasFillRule.

Unfortunately, not all custom parsing could be removed. To support the legacy functions
setLineCap and setLineJoin, which take Strings, two simply parse paths had to be
brought back. They can't use the enums, because the rules for enums as parameters
is stricter that what was implemented in the custom code (e.g. the bindings would
have thrown for strings not in the enum set).

  • html/canvas/CanvasRenderingContext2D.idl:

Move most of the functions into the new files, which are then 'implemented' by
this.

  • html/canvas/DOMPath.cpp: Removed.
  • html/canvas/DOMPath.h: Removed.
  • html/canvas/DOMPath.idl: Removed.
  • html/canvas/Path2D.cpp: Copied from Source/WebCore/html/canvas/DOMPath.cpp.
  • html/canvas/Path2D.h: Copied from Source/WebCore/html/canvas/DOMPath.h.
  • html/canvas/Path2D.idl: Copied from Source/WebCore/html/canvas/DOMPath.idl.

Rename DOMPath to Path2D to match the spec..

  • platform/graphics/GraphicsTypes.cpp:

(WebCore::parseLineCap): Deleted.
(WebCore::lineCapName): Deleted.
(WebCore::parseLineJoin): Deleted.
(WebCore::lineJoinName): Deleted.
(WebCore::textAlignName): Deleted.
(WebCore::parseTextAlign): Deleted.
(WebCore::textBaselineName): Deleted.
(WebCore::parseTextBaseline): Deleted.

  • platform/graphics/GraphicsTypes.h:

Remove now unused parsing / stringifying functions.

  • testing/Internals.cpp:

Remove unused #include.

  • bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
  • bindings/scripts/test/JS/JSTestCallbackInterface.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:
  • bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
  • bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp:
  • bindings/scripts/test/JS/JSTestStandaloneEnumeration.h:

Update test results to add convertEnumerationToString.

LayoutTests:

  • fast/canvas/canvas-clip-path-expected.txt:
  • fast/canvas/canvas-fill-path-expected.txt:
  • fast/canvas/canvas-path-addPath-expected.txt:
  • fast/canvas/canvas-path-isPointInPath-expected.txt:
  • fast/canvas/canvas-path-isPointInStroke-expected.txt:
  • fast/canvas/canvas-stroke-path-expected.txt:
  • fast/canvas/winding-enumeration-expected.txt:
  • inspector/canvas/recording-2d-expected.txt:
  • js/dom/global-constructors-attributes-dedicated-worker-expected.txt:


Update results.

5:11 PM Changeset in webkit [221597] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

[DFG] Consider increasing the number of DFG worklist threads
https://bugs.webkit.org/show_bug.cgi?id=176222

Reviewed by Saam Barati.

Attempt to add one more thread to DFG worklist. DFG compiler sometimes takes
very long time if the target function is very large. However, DFG worklist
has only one thread before this patch. Therefore, one function that takes
too much time to be compiled can prevent the other functions from being
compiled in DFG or upper tiers.

One example is Octane/zlib. In zlib, compiling "a1" function in DFG takes
super long time (447 ms) because of its super large size of the function.
While this function never gets compiled in FTL due to its large size,
it can be compiled in DFG and takes super long time. Subsequent "a8" function
compilation in DFG is blocked by this "a1". As a consequence, the benchmark
takes very long time in a1/Baseline code, which is slower than DFG of course.

While FTL has a bit more threads, DFG worklist has only one thread. This patch
adds one more thread to DFG worklist to alleviate the above situation. This
change significantly improves Octane/zlib performance.

baseline patched

zlib x2 482.32825+-6.07640 408.66072+-14.03856 definitely 1.1803x faster

  • runtime/Options.h:
4:50 PM Changeset in webkit [221596] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Follow up FrameView::updateLayoutAndStyleIfNeededRecursive changes with related improvements
https://bugs.webkit.org/show_bug.cgi?id=176277

Reviewed by Antti Koivisto.

  • page/FrameView.cpp:

(WebCore::FrameView::needsStyleRecalcOrLayout): Deleted. This function was only used
by an assertion inside updateLayoutAndStyleIfNeededRecursive, and thus there is no reason
for it to be in the header file, or for it to be a public member function.
(WebCore::appendRenderedChildren): Deleted. This function was only used inside
updateLayoutAndStyleIfNeededRecursive, and it is now packaged in an even better way
for efficient use inside that function.
(WebCore::FrameView::renderedChildFrameViews): Deleted. This function was only used
inside needsStyleRecalcOrLayout, and it's now packaged in a better way inside that function.
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive): Created a new lambda called
nextRendereredDescendant that packages up the process of repeatedly iterating this view
and all of its descendants in an easy-to-use way. Replaces both of the functions above.
Rewrote to use it; it made the logic clear enough that it was good to get rid of the
updateOneFrame lambda, too. Added two separate functions, one that checks for needed
style recalculation and a separate one that checked for needed layout. Using those,
replaced the old single assertion with two separate assertions.

  • page/FrameView.h: Removed needsStyleRecalcOrLayout, renderedChildFrameViews, and

FrameViewList.

4:36 PM Changeset in webkit [221595] by wenson_hsieh@apple.com
  • 14 edits
    3 adds in trunk

[iOS DnD] Refactor drag and drop logic in WKContentView in preparation for supporting multiple drag items in a drag session
https://bugs.webkit.org/show_bug.cgi?id=176264
<rdar://problem/31144674>

Reviewed by Darin Adler.

Source/WebCore:

Makes some small adjustments to WebItemProviderPasteboard. Rather than just -setItemProviders: on the
WebItemProviderPasteboard when initiating a drag, also stage the WebItemProviderRegistrationList that will be
used to generate an item provider. While it would be cleaner to avoid directly setting item providers so we
don't overwrite item providers on the WebItemProviderPasteboard when adding items to an existing drag session,
this isn't possible without breaking binary compability with older UIKit versions.

Importantly, WKContentView will now ignore any item providers that have been set on the
WebItemProviderPasteboard when initiating a drag or adding items to an existing drag session, and instead only
consider the staged registration list when generating item providers for dragging. This only has the drawback of
generating an unnecessary item provider, but otherwise maintains backwards compatibility while allowing us to
provide WebKit2 support for multiple items per drag session.

Tests: DataInteractionTests.DragEventClientCoordinatesBasic

DataInteractionTests.DragEventClientCoordinatesWithScrollOffset
DataInteractionTests.DragEventPageCoordinatesBasic
DataInteractionTests.DragEventPageCoordinatesWithScrollOffset

  • platform/ios/AbstractPasteboard.h:
  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::registerItemToPasteboard):

Changed to only stage registration info on the item provider pasteboard, if possible. This has no effect on the
copy/paste codepath, since it uses a UIPasteboard.

  • platform/ios/WebItemProviderPasteboard.h:
  • platform/ios/WebItemProviderPasteboard.mm:

Rename _registrationInfoLists to _stagedRegistrationInfoList, and change it from an array of registration info
lists to a single registration info list. This could be updated in the future to be an array of registration
lists, but currently, it serves no purpose and makes coordination with DragItem info more difficult. This would
need to support multiple registration lists if we are to add a way to begin a drag containing multiple items in
vanilla web content, such as dragging multiple selections.

(-[WebItemProviderPasteboard init]):
(-[WebItemProviderPasteboard setItemProviders:]):
(-[WebItemProviderPasteboard stageRegistrationList:]):

Sets the staged item provider registration list.

(-[WebItemProviderPasteboard takeRegistrationList]):

Removes the staged item provider registration list from the WebItemProviderPasteboard and also returns it.

(-[WebItemProviderPasteboard registrationInfoAtIndex:]): Deleted.
(-[WebItemProviderPasteboard setRegistrationInfoLists:]): Deleted.

Source/WebKit:

Move DataInteractionState from WKContentViewInteraction.h to DragDropInteractionState.h, and also rename it to
DragDropInteractionState. Additionally, refactor drag and drop state in the UI process to capture metadata about
the dragged element in a separate DragSourceState struct. This patch also moves drag and drop state transition
logic that doesn't involve WKContentView internals out of WKContentView, and into the implementation of
DragDropInteractionState.

To support multiple drag items per session, we also introduce a simple mechanism to trace a UIDragItem back to
the DragSourceState used to generate it. When generating a DragSourceState, we assign it a unique identifier,
which we also set as the privateLocalContext of all UIDragItems generated when beginning the drag (this
includes drag items returned by an internal client that uses one of the SPI hooks to augment drag items when
starting a drag). This is subsequently used in the implementation of lift and cancellation preview delegate
methods to supply the appropriate drag preview for each UIDragItem.

Lastly, fix a bug wherein the pageX and pageY of mouse drag events are inconsistent with other synthetic mouse
events, such as synthetic clicks. For synthetic clicks, the PlatformMouseEvent is initialized with the same
position and globalPosition. Whether this is really intended is unclear (see http://webkit.org/b/173855), but
it's a trivial change for now to keep mouse events on iOS consistent by tweaking the behavior during drag and
drop. See Tools/ChangeLog for some more information.

  • Platform/spi/ios/UIKitSPI.h:

Add -[UIDragItem privateLocalContext].

  • UIProcess/ios/DragDropInteractionState.h: Added.

(WebKit::DragDropInteractionState::stagedDragSource const):
(WebKit::DragDropInteractionState::dropSessionDidExit):
(WebKit::DragDropInteractionState::dropSessionWillPerformDrop):
(WebKit::DragDropInteractionState::adjustedPositionForDragEnd const):
(WebKit::DragDropInteractionState::didBeginDragging const):
(WebKit::DragDropInteractionState::isPerformingDrop const):
(WebKit::DragDropInteractionState::dragSession const):
(WebKit::DragDropInteractionState::dropSession const):

Wrap private drag/drop state member variables behind const getters, and move drag and drop logic that involves
only the DragDropInteractionState into helper methods on DragDropInteractionState.

(WebKit::DragDropInteractionState::BlockPtr<void):

  • UIProcess/ios/DragDropInteractionState.mm: Added.

(WebKit::dragItemMatchingIdentifier):
(WebKit::createTargetedDragPreview):
(WebKit::uiImageForImage):

Move drag preview creation logic here, from WKContentViewInteraction.mm.

(WebKit::shouldUseTextIndicatorToCreatePreviewForDragAction):
(WebKit::DragDropInteractionState::activeDragSourceForItem const):
(WebKit::DragDropInteractionState::anyActiveDragSourceIs const):
(WebKit::DragDropInteractionState::prepareForDragSession):
(WebKit::DragDropInteractionState::dragSessionWillBegin):
(WebKit::DragDropInteractionState::previewForDragItem const):
(WebKit::DragDropInteractionState::dragSessionWillDelaySetDownAnimation):
(WebKit::DragDropInteractionState::dropSessionDidEnterOrUpdate):
(WebKit::DragDropInteractionState::stageDragItem):
(WebKit::DragDropInteractionState::hasStagedDragSource const):
(WebKit::DragDropInteractionState::clearStagedDragSource):
(WebKit::DragDropInteractionState::dragAndDropSessionsDidEnd):
(WebKit::DragDropInteractionState::updatePreviewsForActiveDragSources):

  • UIProcess/ios/WKContentViewInteraction.h:

Move drag-and-drop-related state tied to the WKContentView here, from DataInteractionState (for instance, the
UIView for the drop caret, the WKContentView snapshot when dropping, and a flag use to keep track of hiding the
callout bar when dragging a text selection).

(): Deleted.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):
(-[WKContentView actionSheetAssistant:showCustomSheetForElement:]):
(-[WKContentView _didChangeDragInteractionPolicy]):
(-[WKContentView setupDataInteractionDelegates]):
(-[WKContentView teardownDataInteractionDelegates]):
(-[WKContentView _startDrag:item:]):
(-[WKContentView _didHandleStartDataInteractionRequest:]):
(-[WKContentView computeClientAndGlobalPointsForDropSession:outClientPoint:outGlobalPoint:]):
(-[WKContentView cleanUpDragSourceSessionState]):
(-[WKContentView _didConcludeEditDataInteraction:]):
(-[WKContentView _didPerformDataInteractionControllerOperation:]):
(-[WKContentView _didChangeDataInteractionCaretRect:currentRect:]):
(-[WKContentView currentDragOrDropSession]):
(-[WKContentView _restoreCalloutBarIfNeeded]):
(-[WKContentView _dragInteraction:prepareForSession:completion:]):
(-[WKContentView dragInteraction:itemsForBeginningSession:]):
(-[WKContentView dragInteraction:previewForLiftingItem:session:]):
(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):
(-[WKContentView dragInteraction:sessionWillBegin:]):
(-[WKContentView dragInteraction:session:didEndWithOperation:]):
(-[WKContentView dragInteraction:previewForCancellingItem:withDefault:]):
(-[WKContentView _dragInteraction:item:shouldDelaySetDownAnimationWithCompletion:]):
(-[WKContentView dragInteraction:item:willAnimateCancelWithAnimator:]):
(-[WKContentView dropInteraction:sessionDidEnter:]):
(-[WKContentView dropInteraction:sessionDidUpdate:]):
(-[WKContentView dropInteraction:sessionDidExit:]):
(-[WKContentView dropInteraction:performDrop:]):
(-[WKContentView dropInteraction:sessionDidEnd:]):

Pull out logic that mutates drag and drop state into DragDropInteractionState. Adjust places that previously
accessed DataInteractionState's members directly with corresponding getters in DragDropInteractionState.

(-[WKContentView _simulateDataInteractionEntered:]):
(-[WKContentView _simulateDataInteractionUpdated:]):
(-[WKContentView _simulateDataInteractionEnded:]):
(-[WKContentView _simulateDataInteractionPerformOperation:]):
(-[WKContentView _simulateDataInteractionSessionDidEnd:]):
(-[WKContentView _simulateWillBeginDataInteractionWithSession:]):
(-[WKContentView _simulatedItemsForSession:]):
(-[WKContentView _simulatePrepareForDataInteractionSession:completion:]):

Rename _dataInteraction => _dragInteraction and _dataOperation => _dropInteraction.

(uiImageForImage): Deleted.
(shouldUseTextIndicatorToCreatePreviewForDragAction): Deleted.
(-[WKContentView dragPreviewForImage:frameInRootViewCoordinates:clippingRectsInFrameCoordinates:backgroundColor:]): Deleted.
(-[WKContentView dragPreviewForCurrentDataInteractionState]): Deleted.
(-[WKContentView _transitionDragPreviewToImageIfNecessary:]): Deleted.

  • WebKit.xcodeproj/project.pbxproj:

Tools:

Adds two new iOS drag and drop tests to check that the clientX and clientY attributes of mouse events propagated
to the page during drop are correct. Each test drags from an image element and drops into three custom-drop-
handling elements; dragenter, dragover, and drop event listeners on the body then use the clientX and
clientY event attributes to hit-test for drop target elements. The first test is suffixed with "-Basic"; the
second test, suffixed with "-WithScrollOffset", makes the document scrollable to check that clientY is correct
when scrolled.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/drop-targets.html: Added.
  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::testDragAndDropOntoTargetElements):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView stringByEvaluatingJavaScript:]):

Log a warning message when an API test fails due to JavaScript evaluation in TestWKWebView.

1:24 PM Changeset in webkit [221594] by Nikita Vasilyev
  • 5 edits
    1 copy
    1 move
    4 adds
    1 delete in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: hook up real data to spreadsheet style editor
https://bugs.webkit.org/show_bug.cgi?id=175343
<rdar://problem/33784793>

Reviewed by Devin Rousso.

Replace static HTML added in <https://webkit.org/b/174838> with actual data.

Addressed in this patch:

  • CSS rules can be copied.
  • Source links work as expected.
  • Nonmatching selectors are grayed out.

Known limitations:

  • Neither CSS selectors nor CSS properties are editable.
  • "Inherited from" and media query section headers are missing.
  • No syntax highlighting of complex CSS values, e.g. hsl(0, 0%, 70%).
  • UserInterface/Main.html:
  • UserInterface/Models/CSSStyleDeclaration.js:
  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WI.CSSStyleDeclarationTextEditor):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WI.CSSStyleDetailsSidebarPanel):

  • UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.js: Removed.

Rename RulesStyleSpreadsheetDetailsPanel to SpreadsheetRulesStyleDetailsPanel. All files related to the spreadsheet editor start with "Spreadsheet" now.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css: Added.

(.spreadsheet-style-declaration-editor):
(.spreadsheet-style-declaration-editor .name):
(.spreadsheet-style-declaration-editor .value):
(.spreadsheet-style-declaration-editor.no-properties):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js: Added.

(WI.SpreadsheetCSSStyleDeclarationEditor):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.layout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get delegate):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.set delegate):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get style):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.set style):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get _propertiesToRender):
Similar condition is commonly used in CSSStyleDeclarationTextEditor. Abstact it out to its own method.

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._renderProperty):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css: Copied from Source/WebInspectorUI/UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.css.

(.spreadsheet-css-declaration):
(.spreadsheet-css-declaration .origin):
(.spreadsheet-css-declaration.locked .origin::after):
(.spreadsheet-css-declaration .origin .go-to-link):
(.spreadsheet-css-declaration .origin .go-to-link:hover):
(.spreadsheet-css-declaration .styles-source):
(.spreadsheet-css-declaration .selector.style-attribute):
(.spreadsheet-css-declaration .selector > span):
(.spreadsheet-css-declaration .selector > .matched):
(.spreadsheet-css-declaration .properties):
(.spreadsheet-css-declaration.locked):
(.spreadsheet-css-declaration .locked-icon):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js: Added.

(WI.SpreadsheetCSSStyleDeclarationSection):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.get element):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.get style):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.layout):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.cssStyleDeclarationTextEditorFocused):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.get locked):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.get selectorEditable):

  • UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.css.
  • UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js: Added.

(WI.SpreadsheetRulesStyleDetailsPanel):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.refresh):

  • UserInterface/Views/StyleDetailsPanel.js:

(WI.StyleDetailsPanel.prototype.filterDidChange):

  • UserInterface/Views/View.js:

(WI.View.prototype.removeAllSubviews):
Add a method to remove all subviews more efficiently.

1:15 PM Changeset in webkit [221593] by fpizlo@apple.com
  • 15 edits
    1 add in trunk/Tools

WSL IntLiteral should have variable type so that it can unify with things like uint
https://bugs.webkit.org/show_bug.cgi?id=176209

Reviewed by Mylex Maxfield.

This introduces IntLiteralType, which can unify with any number type that can represent the
int literal.

This means that all of the following are legal:

double x = 0; 0 unifies with double
double y = x + 5;
should resolve to double+double
double z = array[0]; 0 unifies with uint


We can do similar things with float literals, so that you don't have to suffix "f" all the
time.

I think that this is very different from what C does. C just supports implicit type
conversions. That's why "double x = 0" works in C. We don't do type conversions. Instead, we
let each literal unify itself with one type.

Also updated Test.html so that it runs again and is better at printing things.

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/Checker.js:
  • WebGPUShadingLanguageRI/IntLiteral.js:

(IntLiteral):
(IntLiteral.prototype.toString):

  • WebGPUShadingLanguageRI/IntLiteralType.js: Added.

(IntLiteralType):
(IntLiteralType.prototype.get origin):
(IntLiteralType.prototype.get value):
(IntLiteralType.prototype.get isPrimitive):
(IntLiteralType.prototype.get isUnifiable):
(IntLiteralType.prototype.typeVariableUnify):
(IntLiteralType.prototype.unifyImpl):
(IntLiteralType.prototype.verifyAsArgument):
(IntLiteralType.prototype.verifyAsParameter):
(IntLiteralType.prototype.commitUnification):
(IntLiteralType.prototype.toString):

  • WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics.):
(Intrinsics):

  • WebGPUShadingLanguageRI/LiteralTypeChecker.js:

(LiteralTypeChecker.prototype.visitIntLiteralType):
(LiteralTypeChecker):

  • WebGPUShadingLanguageRI/NativeType.js:

(NativeType):
(NativeType.prototype.get isNumber):
(NativeType.prototype.set isNumber):
(NativeType.prototype.get isInt):
(NativeType.prototype.set isInt):
(NativeType.prototype.get isFloat):
(NativeType.prototype.set isFloat):

  • WebGPUShadingLanguageRI/Prepare.js:

(prepare):

  • WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitIntLiteral):
(Rewriter.prototype.visitIntLiteralType):

  • WebGPUShadingLanguageRI/StandardLibrary.js:
  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/Test.js:

(this.window.this.print):
(doPrep):
(doLex):
(checkNumber):
(checkInt):
(TEST_nameResolutionFailure):
(TEST_threadArrayLoadIntLiteral):
(TEST_deviceArrayStoreIntLiteral):
(TEST_returnIntLiteralDouble):

  • WebGPUShadingLanguageRI/Type.js:

(Type.prototype.get isNumber):
(Type.prototype.get isInt):
(Type.prototype.get isFloat):

  • WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitIntLiteral):
(Visitor.prototype.visitIntLiteralType):

1:14 PM Changeset in webkit [221592] by fpizlo@apple.com
  • 7 edits in trunk/Tools

Add more tests for null behavior in WSL
https://bugs.webkit.org/show_bug.cgi?id=176318

Reviewed by Myles Maxfield.

This adds more tests for the unification behavior of null. In the process, I found a couple
small bugs and fixed them.

  • WebGPUShadingLanguageRI/Checker.js:
  • WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique.InstantiationSubstitution.prototype.visitCallExpression):
(FuncInstantiator.prototype.getUnique.InstantiationSubstitution):

  • WebGPUShadingLanguageRI/Substitution.js:

(Substitution.prototype.visitTypeRef):

  • WebGPUShadingLanguageRI/Test.js:

(TEST_passNullAndNotNullFullPoly):
(TEST_passNullAndNotNullFullPolyReverse):
(TEST_nullTypeVariableUnify.recurse):
(TEST_nullTypeVariableUnify.everyOrder):
(TEST_nullTypeVariableUnify.everyPair):
(TEST_nullTypeVariableUnify):

  • WebGPUShadingLanguageRI/TypeRef.js:

(TypeRef.wrap):

  • WebGPUShadingLanguageRI/TypeVariable.js:

(TypeVariable.prototype.verifyAsArgument):

12:34 PM Changeset in webkit [221591] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Loosen the check in video-canvas-drawing-output.html.
https://bugs.webkit.org/show_bug.cgi?id=127106

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-09-04
Reviewed by Xabier Rodriguez-Calvar.

GStreamer needs the extra tolerance since version 1.2.1.

  • media/video-canvas-drawing-output.html:
  • platform/gtk/TestExpectations:
10:54 AM Changeset in webkit [221590] by commit-queue@webkit.org
  • 13 edits
    1 delete in trunk

Unreviewed, rolling out r221494 and r221500.
https://bugs.webkit.org/show_bug.cgi?id=176258

This caused the windows build to fail. (Requested by mlewis13
on #webkit).

Reverted changesets:

"Switch HTMLMediaElement to release logging"
https://bugs.webkit.org/show_bug.cgi?id=176065
http://trac.webkit.org/changeset/221494

"Switch HTMLMediaElement to release logging"
https://bugs.webkit.org/show_bug.cgi?id=176065
http://trac.webkit.org/changeset/221500

9:27 AM Changeset in webkit [221589] by Darin Adler
  • 5 edits in trunk/Tools

REGRESSION (r220052): [Sierra] API test VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=175329

Reviewed by Wenson Hsieh.

These tests rely on using setTimeout to wait a run loop iteration for the
video controls to appear. With changes to how loading occurs, it can now
take two run loop iterations. The concept here is inherently a bit flaky
and racy -- end users will not be able to tell how many run loop cycles it
takes for controls to come up, and websites can't tell either -- but for now
changing the tests to wait one more run loop should get rid of the flakiness.

  • TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm: Re-enable test.
  • TestWebKitAPI/Tests/WebKitCocoa/full-size-autoplaying-video-with-audio.html: Add a

second setTimeout and a comment.

  • TestWebKitAPI/Tests/WebKitCocoa/skinny-autoplaying-video-with-audio.html: Ditto.
  • TestWebKitAPI/Tests/WebKitCocoa/wide-autoplaying-video-with-audio.html: Ditto.
7:01 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
7:01 AM Changeset in webkit [221588] by Adrian Perez de Castro
  • 2 edits in trunk/Source/bmalloc

Unreviewed build fix for Clang with libc++

Fixes a build failure when building with Clang, -stdlib=libc++, and gigacage
support enabled, which resulted in "stderr" being undefined.

  • bmalloc/Gigacage.cpp: Add missing <ctsdio> include to pull the definition.
6:38 AM WebKitGTK/2.18.x edited by Carlos Garcia Campos
(diff)
6:38 AM WebKitGTK/2.18.x edited by Carlos Garcia Campos
(diff)
4:45 AM Changeset in webkit [221587] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.17.92

WebKitGTK+ 2.17.92

4:44 AM Changeset in webkit [221586] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.92 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

  • gtk/NEWS: Add release notes for 2.17.92.
3:50 AM Changeset in webkit [221585] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk/Source

Source/JavaScriptCore:
[WebIDL] Unify and simplify EnableBySettings with the rest of the runtime settings
https://bugs.webkit.org/show_bug.cgi?id=176312

Patch by Sam Weinig <sam@webkit.org> on 2017-09-04
Reviewed by Darin Adler.

  • runtime/CommonIdentifiers.h:

Remove WebCore specific identifiers from CommonIdentifiers. They have been moved
to WebCoreBuiltinNames in WebCore.

Source/WebCore:
[WebIDL] Simplify EnabledBySettings generation
https://bugs.webkit.org/show_bug.cgi?id=176312

Patch by Sam Weinig <sam@webkit.org> on 2017-09-04
Reviewed by Darin Adler.

  • bindings/scripts/CodeGeneratorJS.pm:

(NeedsRuntimeCheck):
(OperationShouldBeOnInstance):
(GeneratePropertiesHashTable):
(GenerateRuntimeEnableConditionalString):
(GenerateImplementation):
(GenerateAttributeGetterBodyDefinition):

  • Simplify the [EnabledBySetting] code generation by merging it with the other runtime checks (Exposed, EnabledAtRuntime, EnabledForWorld, and SecureContext).
  • Switches to using WebCoreBuiltinNames for identifiers, rather than relying on the appropriate identifiers being available on JavaScriptCore's CommonIdentifiers which was an unnecessary layering violation. There are still problems with this as we continue to be inconsistent about which identifiers deserve to be in WebCoreBuiltinNames, and which ones can be created each time and there is no automation of WebCoreBuiltinNames from the IDLs.
  • Enforce at code generation time that [EnabledBySetting] can only be used on interfaces that are uniquely exposed to the window environment. This is a condition we should find a way to remove (e.g. propagating necessary settings to an object the ScriptExecutionContext owns), but for now, Settings is a main thread only object.
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::put):
(WebCore::addCrossOriginWindowPropertyNames):
(WebCore::addCrossOriginWindowOwnPropertyNames):

Switch to using WebCoreBuiltinNames for WebCore specific identifiers.

  • bindings/js/WebCoreBuiltinNames.h:

Add WebCore specific identifiers from JavaScriptCore's CommonIdentifiers
as well as some new ones need by the [EnableBySetting] unification.

  • bindings/scripts/test/JS/JSTestEnabledBySetting.cpp: Added.
  • bindings/scripts/test/JS/JSTestEnabledBySetting.h: Added.
  • bindings/scripts/test/TestEnabledBySetting.idl: Added.

Add new test for [EnabledBySetting].

  • bindings/scripts/test/JS/JSTestGlobalObject.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/TestObj.idl:

Remove use of [EnabledBySetting] from TestObj, as it is no longer
valid to use [EnabledBySetting] on interfaces that are no uniquely
exposed to the window environment.

2:24 AM Changeset in webkit [221584] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r221574 - [Threaded Compositor] Deadlock in ThreadedDisplayRefreshMonitor
https://bugs.webkit.org/show_bug.cgi?id=176296

Reviewed by Žan Doberšek.

The main thread tries to schedule a display refresh monitor from RAF, requestDisplayRefreshMonitorUpdate() tries
to take the attributes lock to update coordinateUpdateCompletionWithClient. The compositing thread has finished
a frame and sceneUpdateFinished() takes the attributes lock to update clientRendersNextFrame and then asks the
display refresh monitor if it requires a new callback. ThreadedDisplayRefreshMonitor::requiresDisplayRefreshCallback()
takes its lock to check the state, and requestDisplayRefreshMonitorUpdate() was called by
ThreadedDisplayRefreshMonitor::requestRefreshCallback() with the display refresh monitor lock taken. So,
the compositing thread has the attributes lock and wants the display refresh monitor one, and main thread has the
display refresh monitor lock and wants the attributes one.

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

(WebKit::ThreadedDisplayRefreshMonitor::requestRefreshCallback): Release the mutex before calling
ThreadedCompositor::requestDisplayRefreshMonitorUpdate().

2:24 AM Changeset in webkit [221583] by Yusuke Suzuki
  • 11 edits in trunk/Source

Remove "malloc" and "free" use
https://bugs.webkit.org/show_bug.cgi?id=176310

Reviewed by Darin Adler.

Source/JavaScriptCore:

Use Vector instead.

  • API/JSWrapperMap.mm:

(selectorToPropertyName):

Source/WebCore:

Use MallocPtr<>, fastMalloc/fastFree, or Vector instead of manual call of system malloc/free.
In this patch, we apply the above change if we can easily find the pair of malloc/free.
And we do not touch plugin directory since the external code could call free() onto the
fastMalloc-ed memory.

Also, we still use malloc if the system adopts the allocated memory. Later, the system
will deallocate it by calling the system "free".

  • platform/audio/mac/FFTFrameMac.cpp:

(WebCore::FFTFrame::fftSetupForSize):
(WebCore::FFTFrame::cleanup):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::getLinkedFonts):

  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/mac/WebCoreNSURLExtras.mm:

(WebCore::URLByTruncatingOneCharacterBeforeComponent):
(WebCore::dataForURLComponentType):
(WebCore::URLByRemovingComponentAndSubsequentCharacter):
(WebCore::createStringWithEscapedUnsafeCharacters):
(WebCore::userVisibleString):

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::markupToCFHTML):

Source/WTF:

Use Vector instead.

  • wtf/Assertions.cpp:
2:24 AM Changeset in webkit [221582] by Carlos Garcia Campos
  • 4 edits
    1 copy in releases/WebKitGTK/webkit-2.18/Source

Merge r221572 - [GTK] Libgcrypt warning: missing initialization - please fix the application
https://bugs.webkit.org/show_bug.cgi?id=171230

Reviewed by Michael Catanzaro.

Source/WebCore/PAL:

Add the Initialization.h header, containing the single initialize() static
function that initializes the libgcrypt library. This header only includes
the default libgcrypt header, and nothing else.

It's not added to the existing Utilities.h header because that one pulls in
other unnecessary headers that for instance use the new() operator, but that
collides with the implementation files that define WebKit process entrypoints
and intentionally don't include the config.h that brings in FastMalloc to
properly define the new() and delete() operators, resulting in compilation
errors due to the new and delete operators being defined to warning strings
in always-included WebKit2Prefix.h.

  • pal/crypto/gcrypt/Initialization.h: Copied from Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp.

(PAL::GCrypt::initialize):

Source/WebKit:

Replicate the libgcrypt initialization in the NetworkProcess entrypoint.
This is required due to libgcrypt being used through digest operations
originating from the certificate hash computation in SoupNetworkSession.

The initialization is moved to the PAL library, and the initialize()
function is now leveraged in both NetworkProcess and WebProcess entrypoints.

  • NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:

(main):

  • WebProcess/EntryPoint/unix/WebProcessMain.cpp:

(main):

2:22 AM Changeset in webkit [221581] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r221562 - String#utf8() allocates new CString
https://bugs.webkit.org/show_bug.cgi?id=176302

Reviewed by Sam Weinig.

Source/WebCore:

Several places uses String#utf8() like an accessor. In reality, it allocates new CString per call.
It is very costly. Furthermore, some places uses this incorrectly. For example,
std::vector<char>(srtpAuth.utf8().data(), srtpAuth.utf8().data() + srtpAuth.utf8().length());
is incorrect since each time strpAuth.utf8() allocates different CString.

This patch calls utf8() first and use it.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::startClosingHandshake):

  • platform/wpe/PlatformPasteboardWPE.cpp:

(WebCore::PlatformPasteboard::write):

Source/WebKit:

  • NetworkProcess/webrtc/NetworkRTCSocket.cpp:

(WebKit::NetworkRTCSocket::sendTo):

2:22 AM Changeset in webkit [221580] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r221561 - [SOUP] Use fastMalloced SoupBuffer in ResourcehandleSoup
https://bugs.webkit.org/show_bug.cgi?id=176311

Reviewed by Michael Catanzaro.

Use fastMalloced memory instead of g_malloc for SoupBuffer.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::ensureReadBuffer):

2:14 AM Changeset in webkit [221579] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.18

Merge r221542 - Wrong getComputedStyle result for pseudo-elements in display: none subtrees.
https://bugs.webkit.org/show_bug.cgi?id=176259

Patch by Emilio Cobos Álvarez <emilio> on 2017-09-02
Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt:

Source/WebCore:

Before this patch, we were wrongly returning the parent style when there wasn't
a cached pseudo style.

With this, the only remaining failures in getComputedStyle-pseudo is a
serialisation bug for the "content" property, and the display: contents test,
which is because we don't support pseudo-elements of display: contents elements
yet.

Tests: imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html

  • dom/Document.cpp:

(WebCore::Document::styleForElementIgnoringPendingStylesheets):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::resolvePseudoElementStyle):
(WebCore::Element::computedStyle):

  • dom/Element.h:
1:50 AM Changeset in webkit [221578] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r221539 - Performance / PerformanceObserver leaks seen on bots
https://bugs.webkit.org/show_bug.cgi?id=176269

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-02
Reviewed by Darin Adler.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::removeAllEventListeners):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::removeAllEventListeners):
Also use this opportunity to break up the reference cycle
between PerformanceObservers and the Performance object.

  • page/Performance.h:
  • page/Performance.cpp:

(WebCore::Performance::removeAllObservers):
Disassociate and clear observers.

  • page/PerformanceObserver.h:
  • page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::disassociate):
Clear the back-reference to the Performance object to
break the cycle.

1:49 AM Changeset in webkit [221577] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r221521 - [GTK][Wayland] Use fast malloc to allocate backing store cairo surfaces data
https://bugs.webkit.org/show_bug.cgi?id=176226

Reviewed by Michael Catanzaro.

Source/WebCore:

It reduces the memory consumption and improves the performance. Also, since performance is better we don't need
to keep the scroll surface allocated all the time, we can create it on demand and keep it allocated only while
scrolling too fast.

  • platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp:

(WebCore::createCairoImageSurfaceWithFastMalloc): Helper to create a cairo image surface using fast malloc.
(WebCore::BackingStoreBackendCairoImpl::BackingStoreBackendCairoImpl): Create the main surface, but no the
scroll one. Initialize the hysteresis activity to discard the scroll surface after scrolling.
(WebCore::BackingStoreBackendCairoImpl::scroll): Create the scroll surface only if it's nullptr, and notify the
hysteresis activity.

  • platform/graphics/cairo/BackingStoreBackendCairoImpl.h:

Source/WebKit:

Do not create the cairo surface for BackingStoreBackendCairoImpl. When not using X11 we are going to use an
image surface anyway, so we don't really need to use the create similar. This way we only need to pass the size
and device scale factor to BackingStoreBackendCairoImpl that will create the image surface using fast malloc to
allocate the data.

  • UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::createBackend):

1:49 AM Changeset in webkit [221576] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r221514 - [GTK][Wayland] Opening FedoraProject's pastebin chews CPU
https://bugs.webkit.org/show_bug.cgi?id=175942

Reviewed by Žan Doberšek.

This regressed when we introduced the display refresh monitor. The monitor schedules updates immediately,
because we removed the option to not do frame sync in X11 to let swapBuffers do the throttling, but that's
not happening in Wayland because the nested compositor is dispatching frame callbacks on surface commit.
We need to ensure that frame callbacks are dispatched on every monitor refresh, because swapBuffers waits for
frame callbacks to be queued on display.

  • UIProcess/gtk/WaylandCompositor.cpp:

(WebKit::WaylandCompositor::Surface::~Surface): Destroy pending frame callbacks too.
(WebKit::WaylandCompositor::Surface::setWebPage): Add a tick callback to the web view widget to flush all
committed frame callbacks on every frame update.
(WebKit::WaylandCompositor::Surface::requestFrame): Add the callbacks to m_pendingFrameCallbackList.
(WebKit::WaylandCompositor::Surface::flushFrameCallbacks): Dispatch all committed frame callabcks.
(WebKit::WaylandCompositor::Surface::flushPendingFrameCallbacks): Dispatch all pending frame callbacks.
(WebKit::WaylandCompositor::Surface::commit): Do not dispatch frame callbacks here, move them to the list of
committed frame callbacks that will be dispatched on the next frame clock update.

  • UIProcess/gtk/WaylandCompositor.h:

(WebKit::WaylandCompositor::Surface::setWebPage): Moved to the cpp.

  • WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.cpp:

(WebKit::AcceleratedSurfaceWayland::AcceleratedSurfaceWayland): Move surface initialization and destruction to
the compositing thread.
(WebKit::AcceleratedSurfaceWayland::initialize):
(WebKit::AcceleratedSurfaceWayland::finalize):
(WebKit::AcceleratedSurfaceWayland::~AcceleratedSurfaceWayland): Deleted.

  • WebProcess/WebPage/gtk/AcceleratedSurfaceWayland.h:
1:04 AM Changeset in webkit [221575] by Yusuke Suzuki
  • 2 edits in trunk/Source/WTF

Unreviewed, support libstdc++ use with clang
https://bugs.webkit.org/show_bug.cgi?id=176301

  • wtf/FastMalloc.h:
Note: See TracTimeline for information about the timeline view.