Timeline



Oct 15, 2017:

11:25 PM Changeset in webkit [223336] by Nikita Vasilyev
  • 5 edits
    2 adds in trunk

Web Inspector: Modify CSS number values with up key and down key
https://bugs.webkit.org/show_bug.cgi?id=170779
<rdar://problem/33170633>

Reviewed by Matt Baker.

Source/WebInspectorUI:

Up key increments a number, Down key decrements it.

Holding modifier keys changes the step value:

  • Option modifies the value by 0.1
  • Shift modifies the value by 10
  • Command modifies the value by 100
  • UserInterface/Test.html:
  • UserInterface/Views/EditingSupport.js:

(WI.incrementElementValue):
Abstract away incrementElementValue into a public method.

  • UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField.prototype._handleKeyDown):

LayoutTests:

Add tests for WI.incrementElementValue defined in WebInspectorUI/UserInterface/Views/EditingSupport.js.

  • inspector/unit-tests/editing-support-expected.txt: Added.
  • inspector/unit-tests/editing-support.html: Added.
9:46 PM Changeset in webkit [223335] by webkit@devinrousso.com
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: show warning when recorded Canvas action caused no visual change
https://bugs.webkit.org/show_bug.cgi?id=175282

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction):
(WI.RecordingAction.prototype.get valid):
(WI.RecordingAction.prototype.get hasVisibleEffect):
(WI.RecordingAction.prototype.markInvalid):
(WI.RecordingAction.prototype.apply):
(WI.RecordingAction.prototype.async._swizzle):
If the selected action is visual, save a copy of the preview canvas' dataURL before
applying the action and compare it to its dataURL after. If there is no difference, the
action had no visual effect.

  • UserInterface/Models/Recording.js:

(WI.Recording):

  • UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement):
(WI.RecordingActionTreeElement.prototype._handleValidityChanged):
(WI.RecordingActionTreeElement.prototype._handleHasVisibleEffectChanged):

  • UserInterface/Views/RecordingActionTreeElement.css:

(.item.action.visual.no-visible-effect:not(.invalid) > .status > .warning):

  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):
(WI.RecordingContentView.prototype.async._generateContentCanvas2D):
(WI.RecordingContentView.prototype._applyAction): Deleted.

9:16 PM Changeset in webkit [223334] by tpopela@redhat.com
  • 2 edits in trunk/Source/WebCore

DataTransfer.cpp triggers -Wunused-but-set-variable
https://bugs.webkit.org/show_bug.cgi?id=178209

Reviewed by Wenson Hsieh.

Use the ASSERT_UNUSED to silence it.

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::filesFromPasteboardAndItemList const):

8:42 PM Changeset in webkit [223333] by Nikita Vasilyev
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: [PARITY] Styles Redesign: clicking on the go-to arrow in Computed tab should work
https://bugs.webkit.org/show_bug.cgi?id=178286
<rdar://problem/34986379>

Reviewed by Joseph Pecoraro.

Highlight the matching property using a yellow background and focus on the property value
if the property is editable (e.g., not a User Agent style).

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor):
(.spreadsheet-style-declaration-editor .property):
Move left padding to the property element so there's no awkward gap on the left side
when the property is highlighted.

(.spreadsheet-style-declaration-editor .property.highlighted):
(@keyframes style-property-highlight):
Use the same animation duration as we used in .text-editor > .CodeMirror .highlighted.
The highlight color was changed from light blue to yellow.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.highlightProperty):
Use the same logic as in WI.CSSStyleDeclarationTextEditor.prototype.highlightProperty
to find matching style property to highlight.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.highlightProperty):
Use the same logic as in WI.CSSStyleDeclarationSection.prototype.highlightProperty.

  • UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel.prototype.scrollToSectionAndHighlightProperty):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.nodeStylesRefreshed):
Copied from WI.RulesStyleDetailsPanel.

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype.detached):
(WI.SpreadsheetStyleProperty.prototype.highlight):

7:59 PM Changeset in webkit [223332] by commit-queue@webkit.org
  • 6 edits
    2 copies
    1 move in trunk/Source/WebCore

[Settings] Split non-macro generated parts of Settings into SettingsBase base class
https://bugs.webkit.org/show_bug.cgi?id=178321

Patch by Sam Weinig <sam@webkit.org> on 2017-10-15
Reviewed by Darin Adler.

Working towards getting generated Settings working again, but in smaller patches, split
non-generated part off into SettingsBase as a first step.

One function, effectiveFrameFlattening(), needs to remain in Settings for now, as it directly
references a macro generated function, frameFlattening().

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Page.h:
  • page/Settings.cpp:
  • page/Settings.h:
  • page/SettingsBase.h: Copied from Source/WebCore/page/Settings.h.
  • page/cocoa/SettingsBaseCocoa.mm: Copied from Source/WebCore/page/cocoa/SettingsCocoa.mm.
  • page/cocoa/SettingsCocoa.mm: Removed.
6:55 PM Changeset in webkit [223331] by Yusuke Suzuki
  • 13 edits in trunk/Source

[JSC] Perform module specifier validation at parsing time
https://bugs.webkit.org/show_bug.cgi?id=178256

Reviewed by Darin Adler.

Source/JavaScriptCore:

This patch make module loader's resolve operation synchronous. And we validate
module's requested module names when instantiating the module instead of satisfying
module's dependencies. This change is not observable to users. But this is precise
to the spec and this optimizes & simplifies the current module loader a bit by
reducing object allocations.

Previously, we have an object called pair in the module loader. This is pair of
module's name and module's record. And we use it to link one module to dependent
modules. Now, it is replaced with module's registry entry.

We also change our loader functions to take a registry entry instead of a module key.
Previous design is due to the consideration that these APIs may be exposed to users
in whatwg/loader spec. However, this won't happen. This change removes unnecessary
repeatedly hash map lookups.

  • builtins/ModuleLoaderPrototype.js:

(globalPrivate.newRegistryEntry):
(requestFetch):
(requestInstantiate):
(requestSatisfy):
(link):
(moduleEvaluation):
(loadModule):

  • jsc.cpp:

(GlobalObject::moduleLoaderResolve):

  • runtime/AbstractModuleRecord.cpp:

(JSC::AbstractModuleRecord::finishCreation):
(JSC::AbstractModuleRecord::hostResolveImportedModule):

  • runtime/JSGlobalObject.h:
  • runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::resolveSync):
(JSC::JSModuleLoader::resolve):

  • runtime/JSModuleLoader.h:
  • runtime/ModuleLoaderPrototype.cpp:

(JSC::moduleLoaderPrototypeResolveSync):

Source/WebCore:

No behavior change in the current implementation.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::moduleLoaderResolve):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::resolve):

  • bindings/js/ScriptModuleLoader.h:
2:58 PM Changeset in webkit [223330] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

DOMTokenList shouldn't add empty attributes
https://bugs.webkit.org/show_bug.cgi?id=178280
<rdar://problem/34987431>

Reviewed by Ryosuke Niwa.

Follow-up to r223306, reverse the check conditions to avoid attribute
lookup when possible. Also use m_tokens instead of tokens() to avoid
unnecessary branch.

  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::updateAssociatedAttributeFromTokens):

1:13 PM Changeset in webkit [223329] by Darin Adler
  • 7 edits
    1 add in trunk

UTF-8 decoding produces one replacement character per byte; Encoding standard requires one replacement character per illegal sequence instead
https://bugs.webkit.org/show_bug.cgi?id=178207

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::create): Deleted. Use a lambda instead.
(WebCore::TextCodecUTF8::registerCodecs): Use a lambda.
(WebCore::nonASCIISequenceLength): Changed to return 0 instead of 2 for the range 80-C1 since
none of those are valid sequence leading characters.
(WebCore::decodeNonASCIISequence): Changed the length argument to be in/out so the caller
knows how much of the sequence we decoded for failure cases. Simplified the length 2 section.
(WebCore::TextCodecUTF8::handleError): Deleted.
(WebCore::TextCodecUTF8::handlePartialSequence): Changed this into a pair of plain functions
rather than two template function specializations since the two functions are rather different.
For the one-byte version, got rid of the unused arguments. For the two-byte version, got rid
of the ignored return value, stopped using the handleError function since each error case
needs to be handled differently. In each error case consume the entire incorrect sequence
instead of just one byte.
(WebCore::TextCodecUTF8::decode): Updated for the above change, and changed the non-partial
incorrect sequence to consume the entire incorrect sequence instead of just one byte. Also
use WTF prefixes explicitly so we don't have to do "using namespace".
(WebCore::TextCodecUTF8::encode): Got rid of unneeded type punning, and added some inline
capacity to save one memory allocation when encoding shorter strings.

  • platform/text/TextCodecUTF8.h: Use pragma once. Intialize m_partialSequenceSize where it

is defined and let the compiler generate the constructor. Updated for the changes above.

  • platform/text/TextEncoding.h: Export a constructor now used by a unit test.
  • platform/text/TextEncodingRegistry.h: Export newTextCodec, now used by a unit test.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added test.
  • TestWebKitAPI/Tests/WebCore/TextCodec.cpp: Added.

(TestWebKitAPI::decodeHexTestBytes): Decodes a string so we can write readable tests.
(TestWebKitAPI::escapeNonPrintableASCIICharacters): Encodes a string so we can write readable tests.
(TestWebKitAPI::TEST): Added some UTF-8 tests and UTF-8 invalid sequences tests.
Would be smart to add more tests for other cases, exercising the fast ASCII loop for example, and
other encodings.

6:35 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)

Oct 14, 2017:

6:45 PM Changeset in webkit [223328] by commit-queue@webkit.org
  • 10 edits
    3 deletes in trunk

Remove all Web Animations code
https://bugs.webkit.org/show_bug.cgi?id=178273

Patch by Antoine Quint <Antoine Quint> on 2017-10-14
Reviewed by Sam Weinig.

Source/WebCore:

We remove all existing code related to Web Animations which does not include any functionality,
only stubs. This leaves the build and runtime flags, we'll start a complete implementation from
scratch.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/Animatable.idl: Removed.
  • animation/AnimationEffect.cpp: Removed.
  • animation/AnimationEffect.h: Removed.
  • animation/AnimationEffect.idl: Removed.
  • animation/AnimationTimeline.cpp: Removed.
  • animation/AnimationTimeline.h: Removed.
  • animation/AnimationTimeline.idl: Removed.
  • animation/DocumentAnimation.cpp: Removed.
  • animation/DocumentAnimation.h: Removed.
  • animation/DocumentAnimation.idl: Removed.
  • animation/DocumentTimeline.cpp: Removed.
  • animation/DocumentTimeline.h: Removed.
  • animation/DocumentTimeline.idl: Removed.
  • animation/KeyframeEffect.cpp: Removed.
  • animation/KeyframeEffect.h: Removed.
  • animation/KeyframeEffect.idl: Removed.
  • animation/WebAnimation.cpp: Removed.
  • animation/WebAnimation.h: Removed.
  • animation/WebAnimation.idl: Removed.
  • bindings/js/JSAnimationTimelineCustom.cpp: Removed.
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/WebCoreBuiltinNames.h:
  • dom/Element.cpp:

(WebCore::Element::getAnimations): Deleted.

  • dom/Element.h:
  • dom/Element.idl:

LayoutTests:

Remove the only existing Web Animations test.

  • webanimations/Document-expected.txt: Removed.
  • webanimations/Document.html: Removed.
6:28 PM Changeset in webkit [223327] by commit-queue@webkit.org
  • 246 edits
    2 copies
    8 moves
    10 adds
    4 deletes in trunk/LayoutTests

Resync tests up to c1716b039411090428e7073158b1aea081dafe71
https://bugs.webkit.org/show_bug.cgi?id=178241

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-14
Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

  • resources/TestRepositories:
  • resources/resource-files.json:
  • web-platform-tests/IndexedDB/idb-binary-key-detached.htm:
  • web-platform-tests/IndexedDB/keypath-exceptions.htm:
  • web-platform-tests/WebCryptoAPI/digest/digest.js:

(run_test.):

  • web-platform-tests/XMLHttpRequest/abort-after-stop-expected.txt: Removed.
  • web-platform-tests/XMLHttpRequest/abort-after-stop.htm: Removed.
  • web-platform-tests/XMLHttpRequest/event-error-order.sub-expected.txt: Removed.
  • web-platform-tests/XMLHttpRequest/event-error-order.sub.html: Removed.
  • web-platform-tests/XMLHttpRequest/event-timeout-order-expected.txt: Removed.
  • web-platform-tests/XMLHttpRequest/event-timeout-order.htm: Removed.
  • web-platform-tests/XMLHttpRequest/open-url-worker-origin-expected.txt: Removed.
  • web-platform-tests/XMLHttpRequest/open-url-worker-origin.htm: Removed.
  • web-platform-tests/XMLHttpRequest/responsetype-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-after-setting-document-domain-expected.txt: Removed.
  • web-platform-tests/XMLHttpRequest/send-after-setting-document-domain.htm: Removed.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-cors-expected.txt: Removed.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-cors-not-enabled-expected.txt: Removed.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-cors-not-enabled.htm: Removed.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-cors.htm: Removed.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-repeat-no-args-expected.txt: Removed.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-repeat-no-args.htm: Removed.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-setrequestheader.htm: Removed.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic.htm: Removed.
  • web-platform-tests/XMLHttpRequest/send-authentication-competing-names-passwords-expected.txt: Removed.
  • web-platform-tests/XMLHttpRequest/send-authentication-competing-names-passwords.htm: Removed.
  • web-platform-tests/XMLHttpRequest/send-entity-body-basic-expected.txt: Removed.
  • web-platform-tests/XMLHttpRequest/send-entity-body-basic.htm: Removed.
  • web-platform-tests/XMLHttpRequest/send-network-error-async-events.sub-expected.txt: Removed.
  • web-platform-tests/XMLHttpRequest/send-network-error-async-events.sub.htm: Removed.
  • web-platform-tests/XMLHttpRequest/timeout-sync-expected.txt:
  • web-platform-tests/XMLHttpRequest/w3c-import.log:
  • web-platform-tests/background-fetch/interfaces-expected.txt:
  • web-platform-tests/background-fetch/interfaces.idl:
  • web-platform-tests/background-fetch/interfaces.worker-expected.txt:
  • web-platform-tests/background-fetch/interfaces.worker.js:
  • web-platform-tests/beacon/headers/header-content-type-expected.txt:
  • web-platform-tests/common/vendor-prefix.js: Removed.
  • web-platform-tests/common/w3c-import.log:
  • web-platform-tests/css/css-grid-1/abspos/w3c-import.log:
  • web-platform-tests/css/css-grid-1/support/w3c-import.log:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-image-threshold-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-image-threshold-001.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-image-threshold-002.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-image-threshold-003.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-margin-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-margin-001.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-margin-002.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-margin-003.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-margin-004.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-margin-005.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-box-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-001.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-002.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-003.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-004.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-005.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-006.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-007.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-008.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-009.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-010.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-011.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-computed-shape-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-computed-shape-001.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-001.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-002.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-003.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-004.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-005.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-006.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-007.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-008.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-009.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-010.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-011.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-inset-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-inset-001.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-inset-002.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-inset-003.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-inset-004.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-inset-005.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-inset-006.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-inset-007.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-inset-008.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-inset-009.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-polygon-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-polygon-001.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-polygon-002.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-polygon-003.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-polygon-004.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-polygon-005.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-polygon-006.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-shape-arguments-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-shape-arguments-001.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-shape-box-pair-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-shape-inherit-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-shape-initial-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-shape-none-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-shape-notation-000.html:
  • web-platform-tests/css/css-shapes-1/shape-outside/values/support/parsing-utils.js:

(convertToPx):
(each):
(setupFonts):

  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-012.html:
  • web-platform-tests/css/css-shapes-1/w3c-import.log:
  • web-platform-tests/css/css-ui-3/cursor-image-005-nfs.html:
  • web-platform-tests/css/selectors4/w3c-import.log:
  • web-platform-tests/cssom/OWNERS:
  • web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt:
  • web-platform-tests/cssom/getComputedStyle-pseudo.html:
  • web-platform-tests/cssom/style-sheet-interfaces-001-expected.txt:
  • web-platform-tests/cssom/style-sheet-interfaces-001.html:
  • web-platform-tests/cssom/w3c-import.log:
  • web-platform-tests/custom-elements/Document-createElement-expected.txt:
  • web-platform-tests/custom-elements/Document-createElement.html:
  • web-platform-tests/custom-elements/parser/parser-fallsback-to-unknown-element-expected.txt:
  • web-platform-tests/custom-elements/w3c-import.log:
  • web-platform-tests/dom/events/Event-timestamp-safe-resolution.html:
  • web-platform-tests/dom/nodes/DOMImplementation-createDocument.html:
  • web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument-expected.txt:
  • web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument.html:
  • web-platform-tests/dom/nodes/Document-constructor.html:
  • web-platform-tests/dom/nodes/Element-matches-expected.txt:
  • web-platform-tests/dom/nodes/Element-webkitMatchesSelector-expected.txt:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-expected.txt:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht-expected.txt:
  • web-platform-tests/dom/nodes/selectors.js:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-constructor-non-same-origin.htm:
  • web-platform-tests/eventsource/eventsource-constructor-non-same-origin-expected.txt:
  • web-platform-tests/eventsource/eventsource-constructor-non-same-origin.htm:
  • web-platform-tests/eventsource/resources/last-event-id.py:

(main):

  • web-platform-tests/eventsource/shared-worker/eventsource-constructor-non-same-origin-expected.txt:
  • web-platform-tests/eventsource/shared-worker/eventsource-constructor-non-same-origin.htm:
  • web-platform-tests/fetch/api/basic/integrity-expected.txt:
  • web-platform-tests/fetch/api/basic/integrity-worker-expected.txt:
  • web-platform-tests/fetch/api/basic/integrity.js:

(integrity):

  • web-platform-tests/fetch/api/headers/headers-combine-expected.txt:
  • web-platform-tests/fetch/api/headers/headers-combine.html:
  • web-platform-tests/fetch/api/request/request-error-expected.txt:
  • web-platform-tests/fetch/api/request/request-error.js:
  • web-platform-tests/fetch/api/request/request-headers-expected.txt:
  • web-platform-tests/fetch/api/request/request-headers.html:
  • web-platform-tests/fetch/api/request/request-idl-expected.txt:
  • web-platform-tests/fetch/api/request/request-idl.html:
  • web-platform-tests/fetch/api/request/request-structure-expected.txt:
  • web-platform-tests/fetch/api/request/request-structure.html:
  • web-platform-tests/fetch/api/request/w3c-import.log:
  • web-platform-tests/fetch/api/response/response-clone-expected.txt:
  • web-platform-tests/fetch/api/response/response-init-001-expected.txt:
  • web-platform-tests/fetch/api/response/response-init-001.html:
  • web-platform-tests/fetch/api/response/w3c-import.log:
  • web-platform-tests/fonts/Ahem.ttf:
  • web-platform-tests/hr-time/idlharness-expected.txt:
  • web-platform-tests/hr-time/idlharness.html:
  • web-platform-tests/html/README.md:
  • web-platform-tests/html/browsers/browsing-the-web/history-traversal/w3c-import.log:
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/w3c-import.log:
  • web-platform-tests/html/browsers/origin/origin-of-data-document-expected.txt:
  • web-platform-tests/html/dom/interfaces.html:
  • web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/not-in-shadow-tree-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_canplay.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_canplay_noautoplay.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_canplaythrough.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_canplaythrough_noautoplay.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_loadeddata.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_loadeddata_noautoplay.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_loadedmetadata.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_loadedmetadata_noautoplay.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_order_canplay_canplaythrough.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_order_canplay_playing.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_order_loadedmetadata_loadeddata.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_order_loadstart_progress.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_pause.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_play.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_playing.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_progress.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_progress_noautoplay.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/historical.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/srclang-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/language-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/paused_false_during_play.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplay.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplaythrough.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadeddata.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_loadedmetadata.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_playing.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/video_008.htm:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.cross-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.redirect-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-button-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-fieldset-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-form-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-input-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-progress-element/progress-expected.txt:
  • web-platform-tests/html/semantics/forms/the-progress-element/w3c-import.log:
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/w3c-import.log:
  • web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt:
  • web-platform-tests/html/syntax/serializing-html-fragments/serializing.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-parse-error-expected.txt:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-runtime-error-expected.txt:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-runtime-error-throw-expected.txt:
  • web-platform-tests/lint.whitelist:
  • web-platform-tests/mediacapture-fromelement/capture.html:
  • web-platform-tests/mediacapture-fromelement/creation.html:
  • web-platform-tests/mediacapture-fromelement/ended.html:
  • web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https.sub.html:
  • web-platform-tests/payment-request/PaymentAddress/attributes-and-toJSON-method-manual.https.html:
  • web-platform-tests/resource-timing/idlharness-expected.txt:
  • web-platform-tests/resource-timing/idlharness.html:
  • web-platform-tests/resources/idlharness.js:

(IdlInterface.prototype.test_to_json_operation):

  • web-platform-tests/resources/test/tests/api-tests-1.html:
  • web-platform-tests/resources/test/tests/idlharness/IdlInterface/test_to_json_operation.html:
  • web-platform-tests/resources/testharness.js:
  • web-platform-tests/service-workers/service-worker/fetch-event-redirect.https.html:
  • web-platform-tests/service-workers/service-worker/fetch-frame-resource.https.html:
  • web-platform-tests/service-workers/service-worker/fetch-request-xhr.https.html:
  • web-platform-tests/service-workers/service-worker/navigation-preload/resources/redirect-scope.py:

(main):

  • web-platform-tests/service-workers/service-worker/resources/bytecheck-worker-imported-script.py:

(main):

  • web-platform-tests/service-workers/service-worker/resources/bytecheck-worker.py:

(main):

  • web-platform-tests/service-workers/service-worker/resources/fetch-event-redirect-iframe.html: Removed.
  • web-platform-tests/service-workers/service-worker/resources/fetch-request-xhr-iframe.https.html:
  • web-platform-tests/service-workers/service-worker/resources/navigation-redirect-out-scope.py:

(main):

  • web-platform-tests/service-workers/service-worker/resources/navigation-redirect-scope1.py:

(main):

  • web-platform-tests/service-workers/service-worker/resources/navigation-redirect-scope2.py:

(main):

  • web-platform-tests/service-workers/service-worker/resources/update-max-aged-worker-imported-script.py:

(main):

  • web-platform-tests/service-workers/service-worker/resources/update-max-aged-worker.py:

(main):

  • web-platform-tests/service-workers/service-worker/resources/w3c-import.log:
  • web-platform-tests/service-workers/service-worker/w3c-import.log:
  • web-platform-tests/shadow-dom/Extensions-to-Event-Interface-expected.txt:
  • web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html:
  • web-platform-tests/shadow-dom/event-inside-shadow-tree-expected.txt:
  • web-platform-tests/shadow-dom/event-with-related-target.html:
  • web-platform-tests/shadow-dom/leaktests/get-elements-expected.txt:
  • web-platform-tests/shadow-dom/resources/event-path-test-helpers.js:

(dispatchEventWithEventLog):

  • web-platform-tests/shadow-dom/slotchange-event-expected.txt:
  • web-platform-tests/shadow-dom/w3c-import.log:
  • web-platform-tests/streams/piping/general-expected.txt:
  • web-platform-tests/streams/readable-byte-streams/general.js:

(promise_test):

  • web-platform-tests/streams/readable-byte-streams/w3c-import.log:
  • web-platform-tests/streams/readable-streams/pipe-through-expected.txt: Removed.
  • web-platform-tests/tools/manifest/catalog/xhtml.dtd:
  • web-platform-tests/tools/manifest/sourcefile.py:

(SourceFile.references):
(SourceFile.spec_links):

  • web-platform-tests/tools/manifest/tests/test_sourcefile.py:

(test_relpath_normalized):
(test_reftest_url_whitespace):
(test_spec_links_whitespace):

  • web-platform-tests/tools/wptserve/tests/functional/test_handlers.py:

(TestDirectoryHandler.test_subdirectory_no_trailing_slash):

  • web-platform-tests/tools/wptserve/wptserve/handlers.py:

(DirectoryHandler.call):

  • web-platform-tests/update-built-tests.sh:
  • web-platform-tests/url/a-element-expected.txt:
  • web-platform-tests/url/a-element-xhtml-expected.txt:
  • web-platform-tests/url/url-constructor-expected.txt:
  • web-platform-tests/url/urltestdata.json:
  • web-platform-tests/webrtc/RTCCertificate.html:
  • web-platform-tests/webrtc/RTCConfiguration-iceServers-expected.txt:
  • web-platform-tests/webrtc/RTCDTMFSender-insertDTMF.html: Removed.
  • web-platform-tests/webrtc/RTCDTMFSender-ontonechange-long.html: Removed.
  • web-platform-tests/webrtc/RTCDTMFSender-ontonechange.html: Removed.
  • web-platform-tests/webrtc/RTCPeerConnection-addTrack.html: Removed.
  • web-platform-tests/webrtc/RTCPeerConnection-getStats.html: Removed.
  • web-platform-tests/webrtc/RTCPeerConnection-ontrack.html: Removed.
  • web-platform-tests/webrtc/RTCPeerConnection-removeTrack.html: Removed.
  • web-platform-tests/webrtc/RTCRtpReceiver-getContributingSources.html: Removed.
  • web-platform-tests/webrtc/RTCRtpReceiver-getSynchronizationSources.html: Removed.
  • web-platform-tests/webrtc/historical-expected.txt:
  • web-platform-tests/webrtc/historical.html:
  • web-platform-tests/webrtc/simplecall-expected.txt:
  • web-platform-tests/webrtc/simplecall.html:
  • web-platform-tests/webrtc/w3c-import.log:

LayoutTests:

Rebasing expectations.

  • TestExpectations: Skipping unsupported tests.
  • http/wpt/fetch/request-clone-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt: Added.
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin-expected.txt:
  • platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/background-fetch/interfaces-expected.txt:
  • tests-options.json:
5:24 PM Changeset in webkit [223326] by Adrian Perez de Castro
  • 2 edits in trunk/Tools

[WPE] JHBuild build directory DependenciesWPE/Build is not removed by update-webkit-libs-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=178212

Reviewed by Michael Catanzaro.

  • Scripts/update-webkit-libs-jhbuild:

(cleanJhbuild): The WPE JHBuild also uses a separate "Build" subdirectory, so do not skip
cleaning it when "--wpe" is passed to the script.

4:57 PM Changeset in webkit [223325] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Implement Cache API support for WPE/GTK
https://bugs.webkit.org/show_bug.cgi?id=178316

Unreviewed.

Skip tests until feature is implemented.

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-14

  • platform/gtk/TestExpectations:
  • platform/wpe/TestExpectations:
4:55 PM Changeset in webkit [223324] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

WebRTC test gardening
https://bugs.webkit.org/show_bug.cgi?id=178317

Unreviewed.

Updating expectations according dashboard.
Skipping tests for platforms that do not support WebRTC.

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-14

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/win/TestExpectations:
12:18 PM Changeset in webkit [223323] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r223310): Web Inspector: Class list container is transparent and unreadable
https://bugs.webkit.org/show_bug.cgi?id=178311

Reviewed by Devin Rousso.

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ .class-list-container):
Fix 1px hole below the class container.

12:05 PM Changeset in webkit [223322] by Matt Baker
  • 8 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas tab: recordings should have a unique name
https://bugs.webkit.org/show_bug.cgi?id=178188
<rdar://problem/34943364>

Reviewed by Devin Rousso.

  • Localizations/en.lproj/localizedStrings.js:

New format string "Recording %d".

  • UserInterface/Base/FileUtilities.js:

(WI.loadDataFromFile):
Pass chosen filename to callback.

  • UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.recordingFinished):
Create a unique name for the recording.

  • UserInterface/Models/Recording.js:

(WI.Recording):
(WI.Recording.fromPayload):
(WI.Recording.prototype.get displayName):
(WI.Recording.prototype.createDisplayName):

  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype.get saveData):
Use encodeURI so that special characters can be used in filenames, and
to be consistent with other saveData implementations.

  • UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel.prototype.set recording):
(WI.RecordingNavigationSidebarPanel.prototype._importNavigationItemClicked):
Drive-by fix: wait until actions are resolved before updating UI.

  • UserInterface/Views/RecordingTabContentView.js:

(WI.RecordingTabContentView.prototype._navigationSidebarImport):
Try to use the imported filename as the recording name. If the name
collides with that of another imported recording, append a unique suffix.

11:56 AM Changeset in webkit [223321] by webkit@devinrousso.com
  • 16 edits
    2 adds in trunk

Web Inspector: provide a way to enable/disable event listeners
https://bugs.webkit.org/show_bug.cgi?id=177451

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • inspector/protocol/DOM.json:

Add setEventListenerDisabled command that enables/disables a specific event listener
during event dispatch. When a disabled event listener is fired, the listener's callback will
not be called.

Source/WebCore:

Test: inspector/dom/setEventListenerDisabled.html

  • dom/EventTarget.cpp:

(WebCore::EventTarget::fireEventListeners):
Add InspectorInstrumentation call to isEventListenerDisabled. If true, the event listener's
callback will not be called.

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::setEventListenerDisabled):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
(WebCore::InspectorDOMAgent::willRemoveEventListener):
(WebCore::InspectorDOMAgent::isEventListenerDisabled):
Introduce a mapping of EventListener* to InspectorEventListener, a struct for uniquely
identifying event listeners so they can be referenced from the frontend. We only add items
to this mapping when getEventListenersForNode is called, as that is when EventListener
data is sent to the frontend. This allows us to defer creating an Inspector "mirror" object
for each EventListener until it is needed. Items are removed whenever an event listener is
removed or when the document changes.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::isEventListenerDisabled):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willRemoveEventListenerImpl):
(WebCore::InspectorInstrumentation::isEventListenerDisabledImpl):
Pass additional parameters to InspectorDOMAgent so it can determine if the event listener
actually exists. If not, don't dispatch an event to the frontend as nothing will change.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Controllers/DOMTreeManager.js:

(WI.DOMTreeManager.prototype.setEventListenerDisabled):

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WI.DOMNodeDetailsSidebarPanel.prototype.attached):
(WI.DOMNodeDetailsSidebarPanel.prototype.detached):
(WI.DOMNodeDetailsSidebarPanel.prototype._eventListenersChanged):
(WI.DOMNodeDetailsSidebarPanel.prototype.addEventListeners): Deleted.
(WI.DOMNodeDetailsSidebarPanel.prototype.removeEventListeners): Deleted.
Listen for WI.DOMNode.Event.EventListenersChanged on all instances of WI.DOMNode, since we
will still want to refresh the event listeners section in the event that an event listener
is removed from a parent node.

  • UserInterface/Views/EventListenerSectionGroup.js:

(WI.EventListenerSectionGroup):
(WI.EventListenerSectionGroup.prototype._eventText):
(WI.EventListenerSectionGroup.prototype._nodeTextOrLink):
(WI.EventListenerSectionGroup.prototype._createDisabledToggleElement):
(WI.EventListenerSectionGroup.prototype._createDisabledToggleElement.updateTitle):

  • UserInterface/Views/EventListenerSectionGroup.css:

(.event-listener-section > .content input[type="checkbox"]):

  • UserInterface/Views/DetailsSectionSimpleRow.js:

(WI.DetailsSectionSimpleRow.prototype.get label):
(WI.DetailsSectionSimpleRow.prototype.set label):

LayoutTests:

  • inspector/dom/setEventListenerDisabled-expected.txt: Added.
  • inspector/dom/setEventListenerDisabled.html: Added.
9:56 AM Changeset in webkit [223320] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark fast/frames/frame-unload-navigate-and-setTimeout-assert-fail.html as a flaky crash on Windows.
https://bugs.webkit.org/show_bug.cgi?id=178309

Unreviewed test gardening.

  • platform/win/TestExpectations:
9:14 AM Changeset in webkit [223319] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark fast/images/animated-gif-scrolling-crash.html as flaky on Windows.
https://bugs.webkit.org/show_bug.cgi?id=178307

Unreviewed test gardening.

  • platform/win/TestExpectations:
8:35 AM Changeset in webkit [223318] by Yusuke Suzuki
  • 35 edits
    2 adds in trunk

Reland "Add Above/Below comparisons for UInt32 patterns"
https://bugs.webkit.org/show_bug.cgi?id=177281

Reviewed by Saam Barati.

JSTests:

  • stress/uint32-comparison-jump.js: Added.

(shouldBe):
(above):
(aboveOrEqual):
(below):
(belowOrEqual):
(notAbove):
(notAboveOrEqual):
(notBelow):
(notBelowOrEqual):

  • stress/uint32-comparison.js: Added.

(shouldBe):
(above):
(aboveOrEqual):
(below):
(belowOrEqual):
(aboveTest):
(aboveOrEqualTest):
(belowTest):
(belowOrEqualTest):

Source/JavaScriptCore:

We reland this patch without DFGStrengthReduction change to see what causes
regression in the iOS bot.

Sometimes, we would like to have UInt32 operations in JS. While VM does
not support UInt32 nicely, VM supports efficient Int32 operations. As long
as signedness does not matter, we can just perform Int32 operations instead
and recognize its bit pattern as UInt32.

But of course, some operations respect signedness. The most frequently
used one is comparison. Octane/zlib performs UInt32 comparison by performing
val >>> 0. It emits op_urshift and op_unsigned. op_urshift produces
UInt32 in Int32 form. And op_unsigned will generate Double value if
the generated Int32 is < 0 (which should be UInt32).

There is a chance for optimization. The given code pattern is the following.

op_unsigned(op_urshift(@1)) lessThan:< op_unsigned(op_urshift(@2))

This can be converted to the following.

op_urshift(@1) below:< op_urshift(@2)

The above conversion is nice since

  1. We can avoid op_unsigned. This could be unsignedness check in DFG. Since

this check depends on the value of Int32, dropping this check is not as easy as
removing Int32 edge filters.

  1. We can perform unsigned comparison in Int32 form. We do not need to convert

them to DoubleRep.

Since the above comparison exists in Octane/zlib's *super* hot path, dropping
op_unsigned offers huge win.

At first, my patch attempts to convert the above thing in DFG pipeline.
However it poses several problems.

  1. MovHint is not well removed. It makes UInt32ToNumber (which is for op_unsigned) live.
  2. UInt32ToNumber could cause an OSR exit. So if we have the following nodes,

2: UInt32ToNumber(@0)
3: MovHint(@2, xxx)
4: UInt32ToNumber(@1)
5: MovHint(@1, xxx)

we could drop @5's MovHint. But @3 is difficult since @4 can exit.

So, instead, we start introducing a simple optimization in the bytecode compiler.
It performs pattern matching for op_urshift and comparison to drop op_unsigned.
We adds op_below and op_above families to bytecodes. They only accept Int32 and
perform unsigned comparison.

This offers 4% performance improvement in Octane/zlib.

baseline patched

zlib x2 431.07483+-16.28434 414.33407+-9.38375 might be 1.0404x faster

  • bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::printCompareJump):
(JSC::BytecodeDumper<Block>::dumpBytecode):

  • bytecode/BytecodeDumper.h:
  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/Opcode.h:

(JSC::isBranch):

  • bytecode/PreciseJumpTargetsInlines.h:

(JSC::extractStoredJumpTargetsForBytecodeOffset):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):

  • bytecompiler/NodesCodegen.cpp:

(JSC::BinaryOpNode::emitBytecode):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGIntegerRangeOptimizationPhase.cpp:
  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCompareUnsigned):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareBelow):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareBelowEq):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_below):
(JSC::JIT::emit_op_beloweq):
(JSC::JIT::emit_op_jbelow):
(JSC::JIT::emit_op_jbeloweq):
(JSC::JIT::emit_compareUnsignedAndJump):
(JSC::JIT::emit_compareUnsigned):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_compareUnsignedAndJump):
(JSC::JIT::emit_compareUnsigned):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • parser/Nodes.h:

(JSC::ExpressionNode::isBinaryOpNode const):

8:07 AM Changeset in webkit [223317] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Remove HashCountedSet's copyToVector functions
https://bugs.webkit.org/show_bug.cgi?id=178215

Patch by Sam Weinig <sam@webkit.org> on 2017-10-14
Reviewed by Daniel Bates.

Source/WebCore:

  • page/DeviceController.cpp:

(WebCore::DeviceController::dispatchDeviceEvent):
(WebCore::DeviceController::fireDeviceEvent):

Replace use of HashCountedSet's copyToVector functions with copyToVector(hashCountedSet.values()).

Source/WTF:

  • wtf/HashCountedSet.h:

(WTF::copyToVector): Deleted.

They are replaced by either copyToVector(hashCountedSet) or copyToVector(hashCountedSet.values())

Oct 13, 2017:

9:45 PM Changeset in webkit [223316] by commit-queue@webkit.org
  • 28 edits in trunk/Source/WTF

Adopt type trait template aliases everywhere in WTF
https://bugs.webkit.org/show_bug.cgi?id=178299

Patch by Sam Weinig <sam@webkit.org> on 2017-10-13
Reviewed by Yusuke Suzuki.

Adopt type trait template aliases (e.g. replace 'typename std::make_unsigned<Source>::type'
with 'std::make_unsigned_t<Source>'). Also adopt using over typedef consistently.

  • wtf/Atomics.h:
  • wtf/CagedUniquePtr.h:
  • wtf/CheckedArithmetic.h:
  • wtf/CompletionHandler.h:
  • wtf/Function.h:
  • wtf/HashCountedSet.h:
  • wtf/HashFunctions.h:
  • wtf/HashMap.h:
  • wtf/HashSet.h:
  • wtf/HashTable.h:
  • wtf/HashTraits.h:
  • wtf/IndexedContainerIterator.h:
  • wtf/IteratorAdaptors.h:
  • wtf/KeyValuePair.h:
  • wtf/LEBDecoder.h:
  • wtf/ListHashSet.h:
  • wtf/MathExtras.h:
  • wtf/NeverDestroyed.h:
  • wtf/OptionSet.h:
  • wtf/RetainPtr.h:
  • wtf/SizeLimits.cpp:
  • wtf/StdLibExtras.h:
  • wtf/SystemFree.h:
  • wtf/ThreadSpecific.h:
  • wtf/TypeCasts.h:
  • wtf/Vector.h:
  • wtf/text/IntegerToStringConversion.h:
7:38 PM Changeset in webkit [223315] by jer.noble@apple.com
  • 7 edits
    1 add in trunk/Source

Performance: Skip texture upload if source image and destination texture haven't changed
https://bugs.webkit.org/show_bug.cgi?id=178254
<rdar://problem/34968181>

Reviewed by Dean Jackson.

Source/WebCore:

Update GraphicsContext3D to track which texture is bound to which texture unit, and also to
track when those bound textures have their backing stores modified. This new "seed" value
will be used to determine whether a given texture which has previously had image data
uploaded to it needs to be re-updated.

In VideoTextureCopierCV, track whether the texture's seed changed, whether the IOSurface is
the same, whether the IOSurface's seed has changed, and whether the "flipY" parameter
changed since the last time the copier was asked to upload to the texture.

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::textureSeed):
(WebCore::GraphicsContext3D::GraphicsContext3DState::currentBoundTexture):
(WebCore::GraphicsContext3D::GraphicsContext3DState::boundTexture):
(WebCore::GraphicsContext3D::GraphicsContext3DState::setBoundTexture):

  • platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::VideoTextureCopierCV::copyImageToPlatformTexture):

  • platform/graphics/cv/VideoTextureCopierCV.h:

(WebCore::VideoTextureCopierCV::lastTextureSeed):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::texStorage2D):
(WebCore::GraphicsContext3D::texStorage3D):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::texSubImage2D):
(WebCore::GraphicsContext3D::compressedTexImage2D):
(WebCore::GraphicsContext3D::compressedTexSubImage2D):
(WebCore::GraphicsContext3D::createTexture):
(WebCore::GraphicsContext3D::deleteTexture):
(WebCore::GraphicsContext3D::texImage2DDirect):

Source/WTF:

Add a new class, UnsafePointer, for safely holding pointers to objects with uncontrolled lifetimes.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/UnsafePointer.h: Added.

(WTF::UnsafePointer::UnsafePointer):
(WTF::UnsafePointer::operator== const):
(WTF::UnsafePointer::operator!= const):
(WTF::UnsafePointer::operator bool const):
(WTF::operator==):
(WTF::operator!=):

5:50 PM Changeset in webkit [223314] by pvollan@apple.com
  • 10 edits in trunk/Source

[Win] When built with VS2017, MiniBrowser crashes on startup.
https://bugs.webkit.org/show_bug.cgi?id=175209

Reviewed by Daniel Bates.

Source/WebCore:

Generated StaticStringImpl objects are not initialized compile-time with VS2017.
When compiling with VS2017, the global, static, StaticStringImpl objects needs to
be defined with the constexpr specifier, in order for the objects to be initialized
at compile time. Since the StaticStringImpl objects will be const then, we need to
be able to create an AtomicString object from a const StaticStringImpl object.
This constructor has been added to the AtomicString class.

No new tests, covered by existing tests.

  • bindings/scripts/StaticString.pm:

(GenerateStrings):
(GenerateStringAsserts):

  • dom/QualifiedName.cpp:

(WebCore::createQualifiedName):

  • dom/QualifiedName.h:
  • dom/make_names.pl:

(printDefinitions):

Source/WTF:

Add AtomicString(const StaticStringImpl*) constructor. This is needed since
this patch adds constexpr to the static, global StaticStringImpl objects
generated in WebCore/bindings/scripts/StaticString.pm.

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):

  • wtf/text/AtomicStringImpl.cpp:

(WTF::addStatic):
(WTF::AtomicStringImpl::add):

  • wtf/text/AtomicStringImpl.h:
  • wtf/text/StringImpl.h:

(WTF::StringImpl::assertHashIsCorrect const):
(WTF::StringImpl::assertHashIsCorrect): Deleted.

5:44 PM Changeset in webkit [223313] by Brent Fulgham
  • 3 edits
    2 adds in trunk

Protect FrameView during style calculations
https://bugs.webkit.org/show_bug.cgi?id=178300
<rdar://problem/34869329>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Protect the FrameView during layout and style updates in case arbitrary script
is run that might clear it.

Test: fast/html/marquee-reparent-check.html

  • page/FrameView.cpp:

(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

LayoutTests:

  • fast/html/marquee-reparent-check-expected.txt: Added.
  • fast/html/marquee-reparent-check.html: Added.
5:42 PM Changeset in webkit [223312] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/tests/cache-storage/cache-clearing-origin.https.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=178305

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:25 PM Changeset in webkit [223311] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/cache-storage/cache-clearing-origin.https.html is flaky on Sierra
https://bugs.webkit.org/show_bug.cgi?id=178303

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-13

5:05 PM Changeset in webkit [223310] by webkit@devinrousso.com
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: make split console full width of view
https://bugs.webkit.org/show_bug.cgi?id=176635

Reviewed by Timothy Hatcher.

  • UserInterface/Main.html:
  • UserInterface/Views/Main.css:

(#main):
(#content):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ :matches(.options-container, .class-list-container)):
(.sidebar > .panel.details.css-style > .content ~ .options-container):

5:02 PM Changeset in webkit [223309] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

Crash under ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData
https://bugs.webkit.org/show_bug.cgi?id=178279

Reviewed by Alex Christensen.

Check if the connection is valid before calling ResourceHandleClient::didSendData.

No new tests, covered by existing tests.

  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):

4:52 PM Changeset in webkit [223308] by webkit@devinrousso.com
  • 64 edits in trunk/Source/WebInspectorUI

Web Inspector: fix ESLint errors
https://bugs.webkit.org/show_bug.cgi?id=175065

Reviewed by Joseph Pecoraro.

Removed trailing whitespace, extra parenthesis, and some unnecessary escape characters.
Added missing semicolons, spacing around default values for parameters, and changed == to
=== where applicable.

Specific changes to each file were removed for brevity.

  • .eslintrc:

Alphabetize each list of global variables and add some missing utility functions.

  • UserInterface/Base/EventListener.js:
  • UserInterface/Base/EventListenerSet.js:
  • UserInterface/Base/Main.js:
  • UserInterface/Base/Setting.js:
  • UserInterface/Base/TextUtilities.js:
  • UserInterface/Base/URLUtilities.js:
  • UserInterface/Base/Utilities.js:
  • UserInterface/Base/YieldableTask.js:
  • UserInterface/Controllers/AppControllerBase.js:
  • UserInterface/Controllers/CanvasManager.js:
  • UserInterface/Controllers/CodeMirrorCompletionController.js:
  • UserInterface/Controllers/DOMDebuggerManager.js:
  • UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
  • UserInterface/Controllers/RuntimeManager.js:
  • UserInterface/Controllers/SourceMapManager.js:
  • UserInterface/Debug/DebugContentView.js:
  • UserInterface/Debug/UncaughtExceptionReporter.js:
  • UserInterface/Models/CSSKeywordCompletions.js:
  • UserInterface/Models/DOMNode.js:
  • UserInterface/Models/DOMNodeStyles.js:
  • UserInterface/Models/KeyboardShortcut.js:
  • UserInterface/Models/ProfileNode.js:
  • UserInterface/Models/Resource.js:
  • UserInterface/Models/ResourceCollection.js:
  • UserInterface/Models/Script.js:
  • UserInterface/Models/ScriptSyntaxTree.js:
  • UserInterface/Models/ScriptTimelineRecord.js:
  • UserInterface/Protocol/Connection.js:
  • UserInterface/Test/FrontendTestHarness.js:
  • UserInterface/Test/TestHarness.js:
  • UserInterface/Views/CSSStyleDeclarationSection.js:
  • UserInterface/Views/ChartDetailsSectionRow.js:
  • UserInterface/Views/CodeMirrorAdditions.js:
  • UserInterface/Views/CodeMirrorFormatters.js:
  • UserInterface/Views/CodeMirrorRegexMode.js:
  • UserInterface/Views/ContentBrowserTabContentView.js:
  • UserInterface/Views/DataGrid.js:
  • UserInterface/Views/DataGridNode.js:
  • UserInterface/Views/FindBanner.js:
  • UserInterface/Views/GroupNavigationItem.js:
  • UserInterface/Views/HierarchicalPathNavigationItem.js:
  • UserInterface/Views/NetworkTableContentView.js:
  • UserInterface/Views/NetworkTimelineView.js:
  • UserInterface/Views/ObjectTreePropertyTreeElement.js:
  • UserInterface/Views/ObjectTreeView.js:
  • UserInterface/Views/RecordingContentView.js:
  • UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
  • UserInterface/Views/ResourceCookiesContentView.js:
  • UserInterface/Views/ResourceDetailsSection.js:
  • UserInterface/Views/ResourceHeadersContentView.js:
  • UserInterface/Views/ResourceTimelineDataGridNode.js:
  • UserInterface/Views/SettingEditor.js:
  • UserInterface/Views/Sidebar.js:
  • UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
  • UserInterface/Views/Table.js:
  • UserInterface/Views/TextEditor.js:
  • UserInterface/Views/TimelineDataGridNode.js:
  • UserInterface/Views/TreeElement.js:
  • UserInterface/Views/TreeOutline.js:
  • UserInterface/Views/WebSocketDataGridNode.js:
  • UserInterface/Workers/Formatter/EsprimaFormatter.js:
  • UserInterface/Workers/Formatter/FormatterWorker.js:
4:28 PM Changeset in webkit [223307] by Brent Fulgham
  • 6 edits
    5 adds in trunk

CMD+R / CMD+Q keyboard shortcuts are treated as user interaction with page
https://bugs.webkit.org/show_bug.cgi?id=178183
<rdar://problem/33327730>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Key events are granted user interaction credit (in terms of updating the last time of user
interaction), even if the key event was not handled. Instead, we should defer granting
access until the key event has been handled.

Add a new default constructor argument to UserGestureIndicator to be used when handling key
events, so we can delay a decision about whether to grant ResourceLoadStatistics
'hasHadUserInteraction' until we confirm that the event was handled by the page.

This change does not affect other aspects of user interaction.

Tests: fast/events

http/tests/resourceLoadStatistics/prevalent-resource-handled-keydown.html
http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown.html

  • dom/UserGestureIndicator.cpp:

(WebCore::UserGestureIndicator::UserGestureIndicator): Add check based on constructor argument.
Also: Drive by fix to avoid calling 'currentToken' when not on the main thread.

  • dom/UserGestureIndicator.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::keyEvent): If the key event was handled, grant user interaction credit
for ResourceLoadStatistics processing.
(WebCore::EventHandler::internalKeyEvent): Use the new UserGestureIndicator constructor argument.

LayoutTests:

  • http/tests/resourceLoadStatistics/prevalent-resource-handled-keydown-expected.txt: Added.
  • http/tests/resourceLoadStatistics/prevalent-resource-handled-keydown.html: Added.
  • http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown-expected.txt: Added.
  • http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown.html: Added.
  • http/tests/resourceLoadStatistics/resources: Added.
  • http/tests/resourceLoadStatistics/resources/onclick.html: Added.
  • platform/ios/TestExpectations: Skip tests that require 'keyDown' support, since this is not available on iOS.
4:05 PM DOM Security Mitigation.key attached to October 2017 Meeting by rniwa@webkit.org
DOM Security Mitigation Slides
4:04 PM clipboard-talk.key attached to October 2017 Meeting by rniwa@webkit.org
Clipboard Talk Slides
3:36 PM Changeset in webkit [223306] by Chris Dumez
  • 4 edits in trunk

DOMTokenList shouldn't add empty attributes
https://bugs.webkit.org/show_bug.cgi?id=178280

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline web-platform-test now that all checks are passing.

  • web-platform-tests/dom/nodes/Element-classlist-expected.txt:

Source/WebCore:

DOMTokenList shouldn't add empty attributes after:

Firefox and Chrome follow the latest spec.

No new tests, updating existing test.

  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::updateAssociatedAttributeFromTokens):
Implement the first step of https://dom.spec.whatwg.org/#concept-dtl-update

3:33 PM October 2017 Meeting edited by Jon Davis
(diff)
3:26 PM Changeset in webkit [223305] by jmarcell@apple.com
  • 5 edits in branches/safari-604-branch/Source/WebCore

Apply patch. rdar://problem/34891297

Cherry-pick of r222803 <rdar://problem/34745579>

2017-10-03 Jer Noble <jer.noble@apple.com>

Implement quality-of-service tiers in WebCoreDecompressionSession
https://bugs.webkit.org/show_bug.cgi?id=177769

Reviewed by Dean Jackson.

VTDecompressionSession will suggest quality-of-service tiers to be used when decompression
can't keep up with playback speed. Use a simple exponential-moving-average heuristic to
determine when to move up and down the tiers.

Drive-by fix: When frames are so late that they miss the display deadline, mark them as
dropped rather than just delayed.

  • platform/graphics/cocoa/WebCoreDecompressionSession.h:
  • platform/graphics/cocoa/WebCoreDecompressionSession.mm: (WebCore::WebCoreDecompressionSession::ensureDecompressionSessionForSample): (WebCore::WebCoreDecompressionSession::decodeSample): (WebCore::WebCoreDecompressionSession::handleDecompressionOutput): (WebCore::WebCoreDecompressionSession::automaticDequeue): (WebCore::WebCoreDecompressionSession::enqueueDecodedSample): (WebCore::WebCoreDecompressionSession::resetQosTier): (WebCore::WebCoreDecompressionSession::increaseQosTier): (WebCore::WebCoreDecompressionSession::decreaseQosTier): (WebCore::WebCoreDecompressionSession::updateQosWithDecodeTimeStatistics):
  • platform/cocoa/VideoToolboxSoftLink.cpp:
  • platform/cocoa/VideoToolboxSoftLink.h:
3:26 PM Changeset in webkit [223304] by jmarcell@apple.com
  • 6 edits in branches/safari-604-branch/Source/WebCore

Apply patch. rdar://problem/34891297

Partial cherry-pick of r222225 <rdar://problem/34745579>, only the changes to WebCoreDecompressionSession.

2017-09-19 Jer Noble <jer.noble@apple.com>

[Cocoa] Add an ImageDecoder subclass backed by AVFoundation
https://bugs.webkit.org/show_bug.cgi?id=176825

Reviewed by Eric Carlson.

Modify WebCoreDecompressionSession so that it can emit frames which have been converted from
YUV -> RGB as part of the decode operation. Also, add a synchronous decoding operation
method, for use in ImageDecoderAVFObjC.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureDecompressionSession):
  • platform/graphics/cocoa/WebCoreDecompressionSession.h: (WebCore::WebCoreDecompressionSession::createOpenGL): (WebCore::WebCoreDecompressionSession::createRGB):
  • platform/graphics/cocoa/WebCoreDecompressionSession.mm: (WebCore::WebCoreDecompressionSession::WebCoreDecompressionSession): (WebCore::WebCoreDecompressionSession::ensureDecompressionSessionForSample): (WebCore::WebCoreDecompressionSession::decodeSample): (WebCore::WebCoreDecompressionSession::decodeSampleSync):
3:07 PM Changeset in webkit [223303] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

3:06 PM Changeset in webkit [223302] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.4.3

Tag Safari-604.4.3.

3:03 PM Changeset in webkit [223301] by Adrian Perez de Castro
  • 2 edits in trunk/Tools

[WPE] Fontconfig fails build in JHBuild with “error: conflicting types for ‘FcObjectTypeHash’”
https://bugs.webkit.org/show_bug.cgi?id=178283

Reviewed by Žan Doberšek.

  • wpe/jhbuild.modules: Flag Fontconfig to be built inside the source directory, otherwise

compilation fails. While at it, pass "--disable-docs" to cut a bit on build time.

2:58 PM Changeset in webkit [223300] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked http/tests/inspector/network/resource-sizes-memory-cache.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=177687

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:04 PM October 2017 Meeting edited by Jon Davis
(diff)
2:04 PM NextGenerationLayoutAndRendering created by Jon Davis
1:45 PM October 2017 Meeting edited by Jon Davis
(diff)
1:31 PM Changeset in webkit [223299] by commit-queue@webkit.org
  • 16 edits in trunk

Implement listing origins for which CacheStorage is storing data
https://bugs.webkit.org/show_bug.cgi?id=178236

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-13
Reviewed by Chris Dumez.

Source/WebKit:

Cache storage is split on per-origin folders which name is obfuscated through salting.
To retrieve the origin for each folder, an origin file is now stored within each folder.
This file contains the actual origin.

Adding support to get the list of origin by iterating through each folder and
getting the actual origin by reading the content of the 'origin' file.

Adding C API for WebKitTestRunner.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::fetchEntries):
(WebKit::CacheStorage::ReadOriginsTaskCounter::create):
(WebKit::CacheStorage::ReadOriginsTaskCounter::~ReadOriginsTaskCounter):
(WebKit::CacheStorage::ReadOriginsTaskCounter::addOrigin):
(WebKit::CacheStorage::ReadOriginsTaskCounter::ReadOriginsTaskCounter):

  • NetworkProcess/cache/CacheStorageEngine.h:
  • NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::cachesOriginFilename):
(WebKit::CacheStorage::Caches::retrieveOriginFromDirectory):
(WebKit::CacheStorage::Caches::Caches):
(WebKit::CacheStorage::Caches::storeOrigin):
(WebKit::CacheStorage::Caches::readOrigin):
(WebKit::CacheStorage::Caches::initialize):

  • NetworkProcess/cache/CacheStorageEngineCaches.h:

(WebKit::CacheStorage::Caches::origin const):

  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreGetFetchCacheOrigins):

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:

Tools:

Adding hasDOMCache API for checking whether origin is storing data through Cache API.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::hasDOMCache):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::FetchCacheOriginsCallbackContext::FetchCacheOriginsCallbackContext):
(WTR::fetchCacheOriginsCallback):
(WTR::TestController::hasDOMCache):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

  • http/tests/cache-storage/cache-clearing-origin.https.html:
1:24 PM Changeset in webkit [223298] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; wrap more functions in USE(IOSURFACE) so that
they do not generate "unused function" errors.

  • platform/graphics/cv/VideoTextureCopierCV.cpp:
1:14 PM October 2017 Meeting edited by Jon Davis
(diff)
1:13 PM WebKitGoalsFor2018 created by Jon Davis
1:12 PM October 2017 Meeting edited by Jon Davis
(diff)
1:08 PM October 2017 Meeting edited by Jon Davis
(diff)
1:06 PM OptimizingzlibforARM created by Jon Davis
12:55 PM Changeset in webkit [223297] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

One last unreviewed build fix; since the IOSurface APIs don't exist at
all on the simulator, just wrap the entirety of the implementation of
copyImageToPlatformTexture() in a #if USE(IOSURFACE) check.

  • platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::VideoTextureCopierCV::copyImageToPlatformTexture):

12:08 PM WebKitGTK/2.18.x edited by Adrian Perez de Castro
(diff)
12:04 PM Changeset in webkit [223296] by Adrian Perez de Castro
  • 3 edits
    2 adds in trunk/Source/WebCore/PAL

[WPE][GTK] Provide an implementation of PAL::logLevelString()
https://bugs.webkit.org/show_bug.cgi?id=178263

Reviewed by Carlos Alberto Lopez Perez.

Provide an implementation of PAL::logLevelString() which picks the value from the
WEBCORE_DEBUG environment variable. Logging of notImplemented() calls is always enabled,
which is the same behavior as in WebCore::logLevelString().

  • pal/PlatformGTK.cmake: Add LoggingUnix.cpp to the list of sources.
  • pal/PlatformWPE.cmake: Add LoggingUnix.cpp to the list of sources.
  • pal/unix/LoggingUnix.cpp: Added.

(PAL::logLevelString):

11:55 AM Changeset in webkit [223295] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for the previous build fix; use the right PAL path for IOSurfaceSPI.h.

  • platform/graphics/cv/VideoTextureCopierCV.cpp:
11:48 AM Changeset in webkit [223294] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

Unreviewed build fix; add definitions for IOSurface methods missing on some platforms.

Source/WebCore:

  • platform/graphics/cv/VideoTextureCopierCV.cpp:

Source/WebCore/PAL:

  • pal/spi/cocoa/IOSurfaceSPI.h:
11:47 AM October 2017 Meeting edited by Simon Fraser
(diff)
11:45 AM October 2017 Meeting edited by Simon Fraser
(diff)
11:45 AM October 2017 Meeting edited by Simon Fraser
(diff)
11:43 AM Changeset in webkit [223293] by jmarcell@apple.com
  • 2 edits
    2 adds in tags/Safari-605.1.10.1/Source/WebCore/PAL

Cherry-pick r223241. rdar://problem/34974253

11:42 AM Changeset in webkit [223292] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.1.10.1/Source

Versioning.

11:23 AM Changeset in webkit [223291] by achristensen@apple.com
  • 7 edits
    1 delete in trunk

Remove Editor::simplifyMarkup
https://bugs.webkit.org/show_bug.cgi?id=178271

Reviewed by Wenson Hsieh.

Source/WebCore:

An API test became flaky, and it turns out this isn't used anywhere, so let's remove it!
It was used in Mountain Lion, Mavericks, and Yosemite, but not since then.
See <rdar://problem/10726177>

  • editing/Editor.cpp:

(WebCore::Editor::simplifyMarkup): Deleted.

  • editing/Editor.h:

Source/WebKitLegacy/mac:

  • WebView/WebView.mm:

(-[WebView _simplifyMarkup:endNode:]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Removed.
11:17 AM Changeset in webkit [223290] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.10.1

New tag.

11:16 AM Changeset in webkit [223289] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix; forward declare the type of IOSurfaceRef.

  • platform/cocoa/CoreVideoSoftLink.cpp:
  • platform/cocoa/CoreVideoSoftLink.h:
11:03 AM Changeset in webkit [223288] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/cache-storage/cache-origins.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=178266

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-13

  • http/tests/cache-storage/cache-clearing-origin.https.html:
10:41 AM Changeset in webkit [223287] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix; add soft link macros for newly called CoreVideo methods.

  • platform/cocoa/CoreVideoSoftLink.cpp:
  • platform/cocoa/CoreVideoSoftLink.h:
10:30 AM Changeset in webkit [223286] by achristensen@apple.com
  • 3 edits in trunk/Source/WebKit

Fix API tests after r223269.
https://bugs.webkit.org/show_bug.cgi?id=178246

  • UIProcess/API/APIContentRuleListStore.cpp:

(API::ContentRuleListStore::getContentRuleListSource):
Version 10 also has the ability to recover content rule list source.

10:30 AM Changeset in webkit [223285] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; add UNUSED_PARAM macros.

  • platform/graphics/cocoa/GraphicsContext3DCocoa.mm:

(WebCore::GraphicsContext3D::texImageIOSurface2D):

10:19 AM Changeset in webkit [223284] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Modernize LayoutTests/http/tests/cache-storage/cache-clearing-*.https.html
https://bugs.webkit.org/show_bug.cgi?id=178245

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-13
Reviewed by Chris Dumez.

Using await/async to improve the testing.
Taking benefit of clearDOMCache to wait for completion to simplify both tests as well.

  • http/tests/cache-storage/cache-clearing-all.https.html:
  • http/tests/cache-storage/cache-clearing-origin.https.html:
10:14 AM Changeset in webkit [223283] by Nikita Vasilyev
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: hook up autocompletion to property names and values
https://bugs.webkit.org/show_bug.cgi?id=177313
<rdar://problem/34577057>

Reviewed by Joseph Pecoraro.

  • Arrow Right accept the current completion item and places the text caret after it.
  • Arrow Left hides the completion popover.
  • Arrow Up selects the previous completion item.
  • Arrow Down selects the next completion item.
  • Enter and Tab accept the current completion item and navigate to the next focusable item.
  • Escape hides the completion popover, if there is one.
  • UserInterface/Views/CompletionSuggestionsView.js:

(WI.CompletionSuggestionsView):
(WI.CompletionSuggestionsView.prototype._mouseDown):
Add a preventBlur option so clicking on an completion item doesn't change the focus and
doesn't cause "blur" event on the target text field.

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor .completion-hint):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.layout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.detached):
Call detached on every SpreadsheetTextField to hide CompletionSuggestionsView once
SpreadsheetCSSStyleDeclarationEditor is removed from the DOM.

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._addBlankProperty):
Remove index argument since it is no longer used.

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype.detached):
(WI.SpreadsheetStyleProperty.prototype._remove):
(WI.SpreadsheetStyleProperty.prototype._update):
(WI.SpreadsheetStyleProperty.prototype._nameCompletionDataProvider):
(WI.SpreadsheetStyleProperty.prototype._valueCompletionDataProvider):
Add an extra parameter to SpreadsheetTextField to pass a completion data provider.

  • UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField):
(WI.SpreadsheetTextField.prototype.get suggestionHint):
(WI.SpreadsheetTextField.prototype.set suggestionHint):
(WI.SpreadsheetTextField.prototype.startEditing):
(WI.SpreadsheetTextField.prototype.stopEditing):
(WI.SpreadsheetTextField.prototype.detached):
(WI.SpreadsheetTextField.prototype.completionSuggestionsSelectedCompletion):
(WI.SpreadsheetTextField.prototype.completionSuggestionsClickedCompletion):
(WI.SpreadsheetTextField.prototype._getPrefix):
(WI.SpreadsheetTextField.prototype._handleBlur):
(WI.SpreadsheetTextField.prototype._handleKeyDown):
(WI.SpreadsheetTextField.prototype._handleKeyDownForSuggestionView):
(WI.SpreadsheetTextField.prototype._handleInput):
(WI.SpreadsheetTextField.prototype._updateCompletions):
(WI.SpreadsheetTextField.prototype._getCaretRect):
(WI.SpreadsheetTextField.prototype._getCompletionPrefix):
(WI.SpreadsheetTextField.prototype._applyCompletionHint):
(WI.SpreadsheetTextField.prototype._hideCompletions):
Provide text completion based on the existing CompletionSuggestionsView when completionProvider is passed to SpreadsheetTextField.

10:07 AM Changeset in webkit [223282] by gns@gnome.org
  • 8 edits in trunk

[GLib] WebKitNavigationAction should tell whether it is a redirect
https://bugs.webkit.org/show_bug.cgi?id=178178

Source/WebKit:

There is no good way to know whether a given navigation action has been caused
by a redirect through the glib API. This is necessary to implement some app mode
heuristics for Epiphany.

Reviewed by Carlos Garcia Campos.

  • UIProcess/API/glib/WebKitNavigationAction.cpp:

(webkit_navigation_action_is_redirect): returns whether the navigation action is a redirect.

  • UIProcess/API/glib/WebKitNavigationActionPrivate.h: add isRedirect to the wrapper object.

(_WebKitNavigationAction::_WebKitNavigationAction):

  • UIProcess/API/gtk/WebKitNavigationAction.h: add the new API.
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: ditto.
  • UIProcess/API/wpe/WebKitNavigationAction.h: ditto.

Tools:

Test that WebKitNavigationAction properly reports being a redirect.

Reviewed by Carlos Garcia Campos.

  • TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:

(testNavigationPolicy): test that loading /redirect leads to a redirect WebKitNavigationAction.
(serverCallback): add a /redirect path to the server, which causes a redirect.

10:05 AM Changeset in webkit [223281] by Chris Dumez
  • 2 edits in trunk/Tools

Unreviewed, fix webkitpy failure after r223273

  • Scripts/webkitpy/w3c/test_importer_unittest.py:

(TestImporterTest.test_harnesslinks_conversion):

9:32 AM Changeset in webkit [223280] by jer.noble@apple.com
  • 11 edits in trunk/Source/WebCore

Performance: do pixel conformance and texturing in a single step.
https://bugs.webkit.org/show_bug.cgi?id=178219
<rdar://problem/34937237>

Reviewed by Dean Jackson.

No new tests; performance improvements should have no behavior change.

Rather than asking the VTDecompressionSession to conform the output CVPixelBuffer into a
pixel format compatible with OpenGL (& ES), don't constrain the output at all, and only do a
conformance step if the output is not already compatible with OpenGL. This eliminates one
copy (in hardware) operation.

Move the TextureCacheCV object into VideoTextureCopierCV; it will be conditionally used to
create the texture if the pixel buffer is compatible.

Refactor copyVideoTextureToPlatformTexture(CVOpenGLTextureRef) in VideoTextureCopierCV. The
new entry point, copyImageToPlatformTexture(), will attempt to use the texture cache first,
and call a new common copyVideoTextureToPlatformTexture(Platform3DObject) with the result.

The new copyImageToPlatformTexture() will pull planar YUV frames into two textures, and combine
the two with a color transfer function when drawing to the output texture.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::copyVideoTextureToPlatformTexture):

  • platform/graphics/cocoa/GraphicsContext3DCocoa.mm:

(WebCore::GraphicsContext3D::texImageIOSurface2D):

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::ensureDecompressionSessionForSample):

  • platform/graphics/cv/TextureCacheCV.h:
  • platform/graphics/cv/TextureCacheCV.mm:

(WebCore::TextureCacheCV::textureFromImage):

  • platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::pixelRangeFromPixelFormat):
(WebCore::transferFunctionFromString):
(WebCore::YCbCrToRGBMatrixForRangeAndTransferFunction):
(WebCore::VideoTextureCopierCV::~VideoTextureCopierCV):
(WebCore::VideoTextureCopierCV::initializeUVContextObjects):
(WebCore::VideoTextureCopierCV::copyImageToPlatformTexture):
(WebCore::VideoTextureCopierCV::copyVideoTextureToPlatformTexture):

  • platform/graphics/cv/VideoTextureCopierCV.h:
9:03 AM October 2017 Meeting edited by yoav@yoav.ws
(diff)
9:02 AM October 2017 Meeting edited by yoav@yoav.ws
(diff)
9:02 AM October 2017 Meeting edited by yoav@yoav.ws
(diff)
8:32 AM October 2017 Meeting edited by Jon Davis
(diff)
8:20 AM October 2017 Meeting edited by Jon Davis
(diff)
7:46 AM October 2017 Meeting edited by Jon Davis
(diff)
7:45 AM October 2017 Meeting edited by Jon Davis
(diff)
7:36 AM October 2017 Meeting edited by Jon Davis
(diff)
7:35 AM October 2017 Meeting edited by Jon Davis
(diff)
6:38 AM October 2017 Meeting edited by cavalcantii@gmail.com
(diff)
2:22 AM Changeset in webkit [223279] by romain.bellessort@crf.canon.fr
  • 7 edits in trunk

[Readable Streams API] Align queue with spec for ReadableStreamDefaultController
https://bugs.webkit.org/show_bug.cgi?id=178082

Reviewed by Xabier Rodriguez-Calvar.

LayoutTests/imported/w3c:

Updated test expectations for tests that were previously failing but now pass.

  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size-expected.txt:
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.dedicatedworker-expected.txt:

Source/WebCore:

Implemented new queue behavior for dequeueValue (used by ReadableStreamDefaultController),
which fixes rounding errors (as described in https://github.com/whatwg/streams/pull/661).
Also aligned ReadableByteStreamController queue so that both queues are implemented in
the same way.

No new tests (covered by existing tests, especially WPT tests that now pass).

  • Modules/streams/ReadableByteStreamInternals.js:

(privateInitializeReadableByteStreamController): Aligned queue with RSDC.
(readableByteStreamControllerCancel): Aligned queue with RSDC.
(readableByteStreamControllerError): Aligned queue with RSDC.
(readableByteStreamControllerClose): Aligned queue with RSDC.
(readableByteStreamControllerHandleQueueDrain): Aligned queue with RSDC.
(readableByteStreamControllerPull): Aligned queue with RSDC.
(readableByteStreamControllerEnqueue): Aligned queue with RSDC.
(readableByteStreamControllerEnqueueChunk): Aligned queue with RSDC.
(readableByteStreamControllerProcessPullDescriptors): Aligned queue with RSDC.
(readableByteStreamControllerFillDescriptorFromQueue): Aligned queue with RSDC.
(readableByteStreamControllerPullInto): Aligned queue with RSDC.

  • Modules/streams/StreamInternals.js:

(dequeueValue): Updated to match spec.

  • bindings/js/WebCoreBuiltinNames.h: Removed now useless "totalQueuedBytes".
12:14 AM Changeset in webkit [223278] by Wenson Hsieh
  • 5 edits
    7 moves in trunk

"text/html" data is not exposed when dragging and dropping across origins
https://bugs.webkit.org/show_bug.cgi?id=178253
<rdar://problem/34971203>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Minor tweak to DataTransfer::setDataFromItemList to allow "text/html" written from bindings to transfer across
origins without requiring a sanitized representation. Currently, sanitizedData is null, which limits "text/html"
to being treated as custom data, inaccessible across origins. We should instead treat markup supplied via
bindings the same way as we do "text/plain" supplied via bindings.

Modified Tests: editing/pasteboard/data-transfer-set-data-sanitize-url-when-copying-in-null-origin.html

editing/pasteboard/data-transfer-set-data-sanitize-url-when-dragging-in-null-origin.html

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDataFromItemList):

LayoutTests:

Renames some existing layout tests, and also augments two tests to verify that "text/html" is preserved when
copying and dragging across origins that don't match.

  • TestExpectations:
  • editing/pasteboard/data-transfer-set-data-ignore-copied-malformed-url-in-null-expected.txt: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-ignore-copied-walformed-url-in-null-expected.txt.
  • editing/pasteboard/data-transfer-set-data-ignore-copied-malformed-url-in-null-origin-expected.txt: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-ignore-copied-walformed-url-in-null-origin-expected.txt.
  • editing/pasteboard/data-transfer-set-data-ignore-copied-malformed-url-in-null-origin.html: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-ignore-copied-walformed-url-in-null-origin.html.
  • editing/pasteboard/data-transfer-set-data-sanitize-url-when-copying-in-null-origin-expected.txt: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-sanitlize-url-when-copying-in-null-origin-expected.txt.
  • editing/pasteboard/data-transfer-set-data-sanitize-url-when-copying-in-null-origin.html: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-sanitlize-url-when-copying-in-null-origin.html.
  • editing/pasteboard/data-transfer-set-data-sanitize-url-when-dragging-in-null-origin-expected.txt: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-sanitlize-url-when-dragging-in-null-origin-expected.txt.
  • editing/pasteboard/data-transfer-set-data-sanitize-url-when-dragging-in-null-origin.html: Renamed from LayoutTests/editing/pasteboard/data-transfer-set-data-sanitlize-url-when-dragging-in-null-origin.html.
  • platform/mac-wk1/TestExpectations:

Oct 12, 2017:

11:44 PM Changeset in webkit [223277] by beidson@apple.com
  • 15 edits
    4 copies
    2 adds in trunk

SW "Hello world".
https://bugs.webkit.org/show_bug.cgi?id=178187

Reviewed by Andy Estes.

Source/WebCore:

No new tests (Covered by changes to existing tests).

With this patch, SW scripts are actually compiled and run inside a ServiceWorkerGlobalScope environment
in the SW context process.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):

  • dom/EventTargetFactory.in:
  • workers/WorkerGlobalScope.h:

(WebCore::WorkerGlobalScope::isServiceWorkerGlobalScope const):

  • workers/service/ServiceWorkerContextData.cpp: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp.

(WebCore::ServiceWorkerContextData::isolatedCopy const):

  • workers/service/ServiceWorkerContextData.h:

(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):

  • workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::ServiceWorkerGlobalScope):
(WebCore::ServiceWorkerGlobalScope::~ServiceWorkerGlobalScope):
(WebCore::ServiceWorkerGlobalScope::registration):
(WebCore::ServiceWorkerGlobalScope::eventTargetInterface const):

  • workers/service/ServiceWorkerGlobalScope.h:

(WebCore::ServiceWorkerGlobalScope::create):
(WebCore::ServiceWorkerGlobalScope::serverConnectionIdentifier const):

  • workers/service/context/SWContextManager.cpp: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp.

(WebCore::SWContextManager::singleton):
(WebCore::SWContextManager::SWContextManager):
(WebCore::SWContextManager::startServiceWorkerContext):

  • workers/service/context/SWContextManager.h: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.h.
  • workers/service/context/ServiceWorkerThread.cpp: Added.

(WebCore::ServiceWorkerThreadProxy::sharedDummyProxy):
(WebCore::ServiceWorkerThread::ServiceWorkerThread):
(WebCore::m_workerObjectProxy):
(WebCore::ServiceWorkerThread::~ServiceWorkerThread):
(WebCore::ServiceWorkerThread::createWorkerGlobalScope):
(WebCore::ServiceWorkerThread::runEventLoop):

  • workers/service/context/ServiceWorkerThread.h: Copied from Source/WebCore/workers/service/ServiceWorkerGlobalScope.h.

(WebCore::ServiceWorkerThread::create):
(WebCore::ServiceWorkerThread::workerObjectProxy const):

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::createWorker):

Source/WebKit:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::startServiceWorkerContext):

LayoutTests:

  • http/tests/workers/service/basic-register-exceptions-expected.txt:
  • http/tests/workers/service/basic-register-expected.txt:
  • http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt:
10:35 PM Changeset in webkit [223276] by jmarcell@apple.com
  • 4 edits
    4 adds in branches/safari-604-branch

Cherry-pick r223144. rdar://problem/34958765

10:35 PM Changeset in webkit [223275] by jmarcell@apple.com
  • 9 edits
    8 deletes in branches/safari-604-branch

Cherry-pick r222627. rdar://problem/34938437

7:13 PM Changeset in webkit [223274] by Yusuke Suzuki
  • 9 edits in trunk

WebAssembly: Wasm functions should have either JSFunctionType or TypeOfShouldCallGetCallData
https://bugs.webkit.org/show_bug.cgi?id=178210

Reviewed by Saam Barati.

JSTests:

  • wasm/function-tests/trap-from-start-async.js:

(async.StartTrapsAsync):

  • wasm/function-tests/trap-from-start.js:

(StartTraps):

  • wasm/js-api/web-assembly-function.js:

(assert.eq.Object.getPrototypeOf):

  • wasm/js-api/wrapper-function.js:

(return.new.WebAssembly.Module):
(assert.throws.makeInstance): Deleted.
(assert.throws.Bar): Deleted.
(assert.throws): Deleted.

Source/JavaScriptCore:

In Wasm, we have two JS functions exposed to users: WebAssemblyFunction and WebAssemblyWrapperFunction.
The former is an exported wasm function and the latter is an imported & exported function. Since they
have Call?, they should be categorized into "function" in typeof operation.

However, these functions do not implement our function protocol correctly. They inherit JSFunction.
But JSType of WebAssemblyFunction is WebAssemblyFunctionType, and one of WebAssemblyWrapperFunction is
ObjectType. Since both do not have TypeOfShouldCallGetCallData, they return "object" when performing
typeof operation.

In this patch, we address the above issue by the following 2 fixes.

  1. We add TypeOfShouldCallGetCallData to WebAssemblyFunction. This is the same way how we implement

InternalFunction. Since WebAssemblyFunction requires WebAssemblyFunctionType for fast checking in Wasm
implementation, we cannot make this JSFunctionType.

  1. On the other hand, WebAssemblyWrapperFunction does not require a specific JSType. So this patch

changes JSType of WebAssemblyWrapperFunction to JSFunctionType. JSFunctionType can be usable for derived
classes of JSFunction (e.g. JSCustomGetterSetterFunction).

  • wasm/js/WebAssemblyFunction.h:

(JSC::WebAssemblyFunction::signatureIndex const): Deleted.
(JSC::WebAssemblyFunction::wasmEntrypointLoadLocation const): Deleted.
(JSC::WebAssemblyFunction::callableFunction const): Deleted.
(JSC::WebAssemblyFunction::jsEntrypoint): Deleted.
(JSC::WebAssemblyFunction::offsetOfWasmEntrypointLoadLocation): Deleted.

  • wasm/js/WebAssemblyWrapperFunction.cpp:

(JSC::WebAssemblyWrapperFunction::createStructure):

  • wasm/js/WebAssemblyWrapperFunction.h:

(JSC::WebAssemblyWrapperFunction::signatureIndex const): Deleted.
(JSC::WebAssemblyWrapperFunction::wasmEntrypointLoadLocation const): Deleted.
(JSC::WebAssemblyWrapperFunction::callableFunction const): Deleted.
(JSC::WebAssemblyWrapperFunction::function): Deleted.

7:04 PM Changeset in webkit [223273] by Chris Dumez
  • 523 edits in trunk

import-w3c-tests modifies test sources and sometimes causes them to fail
https://bugs.webkit.org/show_bug.cgi?id=178234

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Resync tests now that they no longer get re-written by the importer.
Most changes are about casing and spacing.

Also note that some tests are now passing and that they have been rebaselined.

  • web-platform-tests/FileAPI/url/multi-global-origin-serialization.sub.html:
  • web-platform-tests/IndexedDB/abort-in-initial-upgradeneeded.html:
  • web-platform-tests/IndexedDB/close-in-upgradeneeded.html:
  • web-platform-tests/IndexedDB/cursor-overloads.htm:
  • web-platform-tests/IndexedDB/idbkeyrange_incorrect.htm:
  • web-platform-tests/IndexedDB/key_invalid.htm:
  • web-platform-tests/IndexedDB/key_valid.html:
  • web-platform-tests/IndexedDB/keyorder.htm:
  • web-platform-tests/IndexedDB/keypath.htm:
  • web-platform-tests/IndexedDB/keypath_invalid.htm:
  • web-platform-tests/IndexedDB/string-list-ordering.htm:
  • web-platform-tests/WebIDL/current-realm.html:
  • web-platform-tests/css/css-display-3/display-contents-before-after-001.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-before-after-001.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-none.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-none.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-inline-flex-001-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-inline-flex-001-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-inline-flex-001-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-inline-flex-001-none.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-none.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-none.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-none.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-inline-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-inline.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-none-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-none.html:
  • web-platform-tests/css/css-display-3/display-contents-flex-002-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-flex-002.html:
  • web-platform-tests/css/css-display-3/display-contents-flex-003-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-flex-003.html:
  • web-platform-tests/css/css-display-3/display-contents-inline-flex-001-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-inline-flex-001.html:
  • web-platform-tests/css/css-display-3/display-contents-list-001-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-list-001.html:
  • web-platform-tests/css/css-display-3/display-contents-multicol-001-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-multicol-001.html:
  • web-platform-tests/css/css-display-3/display-contents-table-001-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-table-001.html:
  • web-platform-tests/css/css-display-3/display-contents-table-002-expected.html:
  • web-platform-tests/css/css-display-3/display-contents-table-002.html:
  • web-platform-tests/css/css-display-3/display-flow-root-001-expected.html:
  • web-platform-tests/css/css-display-3/display-flow-root-001.html:
  • web-platform-tests/css/css-grid-1/grid-definition/fr-unit-expected.html:
  • web-platform-tests/css/css-grid-1/grid-definition/fr-unit-with-percentage-expected.html:
  • web-platform-tests/css/css-grid-1/grid-definition/fr-unit-with-percentage.html:
  • web-platform-tests/css/css-grid-1/grid-definition/fr-unit.html:
  • web-platform-tests/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html:
  • web-platform-tests/css/css-grid-1/grid-layout-properties.html:
  • web-platform-tests/css/css-grid-1/grid-model/display-grid-expected.html:
  • web-platform-tests/css/css-grid-1/grid-model/display-grid.html:
  • web-platform-tests/css/css-grid-1/grid-model/display-inline-grid-expected.html:
  • web-platform-tests/css/css-grid-1/grid-model/display-inline-grid.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-display-grid-001.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-display-inline-grid-001.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-float-001.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-float-001.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-inline-vertical-align-001.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-support-display-001.html:
  • web-platform-tests/css/css-grid-1/grid-model/grid-vertical-align-001.html:
  • web-platform-tests/css/css-grid-1/test-plan/index.html:
  • web-platform-tests/css/css-pseudo-4/marker-color-expected.html:
  • web-platform-tests/css/css-pseudo-4/marker-color.html:
  • web-platform-tests/css/css-pseudo-4/marker-font-properties.html:
  • web-platform-tests/css/css-shapes-1/shape-outside-invalid-circle-003.html:
  • web-platform-tests/css/css-shapes-1/shape-outside-invalid-ellipse-001.html:
  • web-platform-tests/css/css-shapes-1/shape-outside-invalid-ellipse-002.html:
  • web-platform-tests/css/css-shapes-1/shape-outside-invalid-ellipse-003.html:
  • web-platform-tests/css/css-shapes-1/shape-outside-invalid-inset-001.html:
  • web-platform-tests/css/css-shapes-1/shape-outside-invalid-inset-002.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-001.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-002.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-003.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-004.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-005.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-006.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-007.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-008.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-010.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-011.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-012.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-013.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-014.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-015.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-016.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-017.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-018.html:
  • web-platform-tests/css/css-shapes-1/spec-examples/shape-outside-019.html:
  • web-platform-tests/css/css-shapes-1/test-plan/index.html:
  • web-platform-tests/css/css-ui-3/cursor-image-001.html:
  • web-platform-tests/css/css-ui-3/cursor-image-002.html:
  • web-platform-tests/css/css-ui-3/cursor-image-003.html:
  • web-platform-tests/css/css-ui-3/cursor-image-004.html:
  • web-platform-tests/css/css-ui-3/cursor-image-005-nfs.html:
  • web-platform-tests/css/css-ui-3/cursor-image-005.html:
  • web-platform-tests/css/css-ui-3/cursor-image-009.html:
  • web-platform-tests/css/css-ui-3/cursor-image-012.html:
  • web-platform-tests/css/css-ui-3/cursor-image-png-012.html:
  • web-platform-tests/css/css-ui-3/cursor-image-png-013.html:
  • web-platform-tests/css/css-ui-3/cursor-image-png-027.html:
  • web-platform-tests/css/css-ui-3/cursor-image-png-028.html:
  • web-platform-tests/css/css-ui-3/resize-015.html:
  • web-platform-tests/css/css-ui-3/resize-018.html:
  • web-platform-tests/css/css-ui-3/support/cursors/woolly-64.svg:
  • web-platform-tests/css/css-ui-3/support/cursors/woolly.svg:
  • web-platform-tests/css/css-ui-3/text-overflow-002-expected.html:
  • web-platform-tests/css/css-ui-3/text-overflow-004-expected.html:
  • web-platform-tests/css/css-ui-3/text-overflow-008.html:
  • web-platform-tests/css/css-ui-3/text-overflow-011.html:
  • web-platform-tests/css/css-ui-3/text-overflow-012.html:
  • web-platform-tests/css/css-ui-3/text-overflow-013.html:
  • web-platform-tests/css/css-ui-3/text-overflow-022.html:
  • web-platform-tests/css/css-ui-3/text-overflow-023.html:
  • web-platform-tests/cssom-view/elementFromPoint.html:
  • web-platform-tests/cssom-view/elementsFromPoint.html:
  • web-platform-tests/cssom-view/interfaces.html:
  • web-platform-tests/cssom-view/scrollingElement-quirks-dynamic-001-expected.html:
  • web-platform-tests/cssom-view/scrollingElement-quirks-dynamic-001.html:
  • web-platform-tests/cssom-view/scrollingElement-quirks-dynamic-002-expected.html:
  • web-platform-tests/cssom-view/scrollingElement-quirks-dynamic-002.html:
  • web-platform-tests/cssom/cssom-fontfacerule-constructors.html:
  • web-platform-tests/cssom/cssstyledeclaration-csstext.html:
  • web-platform-tests/cssom/cssstyledeclaration-mutability.html:
  • web-platform-tests/cssom/interfaces.html:
  • web-platform-tests/cssom/medialist-interfaces-002.html:
  • web-platform-tests/cssom/style-sheet-interfaces-002.html:
  • web-platform-tests/cssom/ttwf-cssom-document-extension.html:
  • web-platform-tests/dom/collections/HTMLCollection-supported-property-indices.html:
  • web-platform-tests/dom/collections/HTMLCollection-supported-property-names.html:
  • web-platform-tests/dom/nodes/DOMImplementation-createHTMLDocument.html:
  • web-platform-tests/dom/nodes/Document-adoptNode.html:
  • web-platform-tests/dom/nodes/Document-characterSet-normalization.html:
  • web-platform-tests/dom/nodes/Document-constructor-svg.svg:
  • web-platform-tests/dom/nodes/Document-constructor-xml.xml:
  • web-platform-tests/dom/nodes/Document-constructor.html:
  • web-platform-tests/dom/nodes/Document-doctype.html:
  • web-platform-tests/dom/nodes/Document-getElementById.html:
  • web-platform-tests/dom/nodes/Element-matches.html:
  • web-platform-tests/dom/nodes/Element-webkitMatchesSelector.html:
  • web-platform-tests/dom/nodes/MutationObserver-characterData-expected.txt:
  • web-platform-tests/dom/nodes/MutationObserver-characterData.html:
  • web-platform-tests/dom/nodes/Node-compareDocumentPosition.html:
  • web-platform-tests/dom/nodes/Node-contains.html:
  • web-platform-tests/dom/nodes/Node-lookupPrefix.xhtml:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-content.html:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-content.xht:
  • web-platform-tests/dom/nodes/getElementsByClassName-14.htm:
  • web-platform-tests/dom/nodes/getElementsByClassName-28.htm:
  • web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter.html:
  • web-platform-tests/dom/traversal/TreeWalker-basic.html:
  • web-platform-tests/dom/traversal/TreeWalker-currentNode.html:
  • web-platform-tests/dom/traversal/TreeWalker-previousNodeLastChildReject.html:
  • web-platform-tests/dom/traversal/TreeWalker-previousSiblingLastChildSkip.html:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-reject.html:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-skip-most.html:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-skip.html:
  • web-platform-tests/dom/traversal/TreeWalker-walking-outside-a-tree.html:
  • web-platform-tests/encrypted-media/clearkey-check-initdata-type.html:
  • web-platform-tests/encrypted-media/clearkey-events-session-closed-event.html:
  • web-platform-tests/encrypted-media/clearkey-events.html:
  • web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input.html:
  • web-platform-tests/encrypted-media/clearkey-invalid-license.html:
  • web-platform-tests/encrypted-media/clearkey-keystatuses-multiple-sessions.html:
  • web-platform-tests/encrypted-media/clearkey-keystatuses.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-destroy-persistent-license.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license-events.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-usage-record-events.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-usage-record.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-destroy-persistent-license.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-license.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-usage-record.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-immediately.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-playback.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-at-same-time.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-different-mediakeys.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-to-multiple-video-elements.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeys.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysession.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysystemaccess.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-unique-origin.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input.html:
  • web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key.html:
  • web-platform-tests/encrypted-media/clearkey-not-callable-after-createsession.html:
  • web-platform-tests/encrypted-media/clearkey-update-non-ascii-input.html:
  • web-platform-tests/encrypted-media/drm-check-initdata-type.html:
  • web-platform-tests/encrypted-media/drm-events-session-closed-event.html:
  • web-platform-tests/encrypted-media/drm-events.html:
  • web-platform-tests/encrypted-media/drm-expiration.html:
  • web-platform-tests/encrypted-media/drm-generate-request-disallowed-input.html:
  • web-platform-tests/encrypted-media/drm-invalid-license.html:
  • web-platform-tests/encrypted-media/drm-keystatuses-multiple-sessions.html:
  • web-platform-tests/encrypted-media/drm-keystatuses.html:
  • web-platform-tests/encrypted-media/drm-mp4-onencrypted.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-destroy-persistent-license.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-persistent-license-events.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-persistent-license.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-persistent-usage-record-events.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-persistent-usage-record.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-retrieve-destroy-persistent-license.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-retrieve-persistent-license.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-retrieve-persistent-usage-record.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-clear-encrypted.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-encrypted-clear-sources.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-encrypted-clear.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-events.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-expired.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-multikey-sequential-readyState.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-multikey-sequential.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-multikey.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-multisession.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-setMediaKeys-after-src.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-setMediaKeys-after-update.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-setMediaKeys-immediately.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-setMediaKeys-onencrypted.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-two-videos.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary-waitingforkey.html:
  • web-platform-tests/encrypted-media/drm-mp4-playback-temporary.html:
  • web-platform-tests/encrypted-media/drm-mp4-requestmediakeysystemaccess.html:
  • web-platform-tests/encrypted-media/drm-mp4-reset-src-after-setmediakeys.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys-again-after-playback.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys-again-after-resetting-src.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys-at-same-time.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys-multiple-times-with-different-mediakeys.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys-multiple-times-with-the-same-mediakeys.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys-to-multiple-video-elements.html:
  • web-platform-tests/encrypted-media/drm-mp4-setmediakeys.html:
  • web-platform-tests/encrypted-media/drm-mp4-syntax-mediakeys.html:
  • web-platform-tests/encrypted-media/drm-mp4-syntax-mediakeysession.html:
  • web-platform-tests/encrypted-media/drm-mp4-syntax-mediakeysystemaccess.html:
  • web-platform-tests/encrypted-media/drm-mp4-unique-origin.html:
  • web-platform-tests/encrypted-media/drm-mp4-waiting-for-a-key.html:
  • web-platform-tests/encrypted-media/drm-not-callable-after-createsession.html:
  • web-platform-tests/encrypted-media/drm-temporary-license-type.html:
  • web-platform-tests/encrypted-media/resources/clearkey-retrieve-destroy-persistent-license.html:
  • web-platform-tests/encrypted-media/resources/clearkey-retrieve-persistent-license.html:
  • web-platform-tests/encrypted-media/resources/drm-retrieve-destroy-persistent-license.html:
  • web-platform-tests/encrypted-media/resources/drm-retrieve-persistent-license.html:
  • web-platform-tests/encrypted-media/resources/drm-retrieve-persistent-usage-record.html:
  • web-platform-tests/encrypted-media/resources/retrieve-persistent-usage-record.html:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-close.htm:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-constructor-non-same-origin.htm:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-constructor-url-bogus.htm:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-onmesage.htm:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-onopen.htm:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-prototype.htm:
  • web-platform-tests/eventsource/dedicated-worker/eventsource-url.htm:
  • web-platform-tests/eventsource/eventsource-constructor-document-domain.htm:
  • web-platform-tests/eventsource/eventsource-constructor-non-same-origin.htm:
  • web-platform-tests/eventsource/eventsource-onmessage-trusted.htm:
  • web-platform-tests/eventsource/eventsource-prototype.htm:
  • web-platform-tests/eventsource/format-leading-space.htm:
  • web-platform-tests/eventsource/format-mime-bogus.htm:
  • web-platform-tests/eventsource/format-mime-valid-bogus.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-close.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-constructor-non-same-origin.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-constructor-url-bogus.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-eventtarget.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-onmesage.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-onopen.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-prototype.htm:
  • web-platform-tests/eventsource/shared-worker/eventsource-url.htm:
  • web-platform-tests/fetch/api/request/multi-globals/url-parsing.html:
  • web-platform-tests/fetch/api/resources/basic.html:
  • web-platform-tests/fetch/api/response/multi-globals/url-parsing.html:
  • web-platform-tests/fetch/api/response/response-trailer.html:
  • web-platform-tests/fetch/nosniff/stylesheet.html:
  • web-platform-tests/html/browsers/browsing-the-web/history-traversal/unset_context_name.html:
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/012.html:
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-form-submit.html:
  • web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/001.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/002.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/003.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/004.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/005.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/006.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/007.html:
  • web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/forward-triggers-hashchange.html:
  • web-platform-tests/html/browsers/history/the-history-interface/008.html:
  • web-platform-tests/html/browsers/history/the-location-interface/cross_origin_joined_frame.sub.html:
  • web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-weird.html:
  • web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html:
  • web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-with-colon.sub.html:
  • web-platform-tests/html/browsers/history/the-location-interface/location-tojson.html:
  • web-platform-tests/html/browsers/history/the-location-interface/same_origin_frame.html:
  • web-platform-tests/html/browsers/offline/resources/html/clock.html:
  • web-platform-tests/html/browsers/origin/cross-origin-objects/frame.html:
  • web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain_setter_null.tentative.html:
  • web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain_setter_srcdoc.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-innerwidth-innerheight.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-screenx-screeny.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-top-left.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-negative-width-height.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-height.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerheight.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-innerwidth.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-left.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screenx.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screeny.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-top.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-width.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-innerheight-innerwidth.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-screenx-screeny.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-top-left.html:
  • web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-width-height.html:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/Document.currentScript.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-001.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-002.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-003.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-004.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-005.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-006.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-007.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-008.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-009.html:
  • web-platform-tests/html/dom/elements/global-attributes/the-lang-attribute-010.html:
  • web-platform-tests/html/dom/interfaces.html:
  • web-platform-tests/html/dom/self-origin.sub.html:
  • web-platform-tests/html/semantics/document-metadata/the-meta-element/the-lang-attribute-012.html:
  • web-platform-tests/html/semantics/embedded-content/media-elements/user-interface/muted.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.canvas.readonly.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.canvas.reference.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.getcontext.exists.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.getcontext.extraargs.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.getcontext.shared.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.getcontext.unique.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.type.exists.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.type.extend.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.type.prototype.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.type.replace.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.arguments.missing.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.casesensitive.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.emptystring.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.unrecognised.badname.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.unrecognised.badsuffix.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.unrecognised.nullsuffix.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.unrecognised.unicode.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/fallback.basic.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/fallback.multiple.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/fallback.nested.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.colour.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.2dstate.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.clip.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.different.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.gradient.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.path.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.pattern.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.same.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/initial.reset.transform.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.dataURI.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.canvas.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.canvas.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.image.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.image.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.fillStyle.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.fillStyle.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.strokeStyle.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.strokeStyle.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.timing.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.timing.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.create.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.create.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.cross.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.cross.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.fillStyle.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.fillStyle.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.strokeStyle.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.strokeStyle.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.cross.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.redirect.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.default.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.idl.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.idl.set.zero.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.decimal.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.em.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.empty.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.exp.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.hex.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.junk.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.minus.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.octal.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.onlyspace.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.percent.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.plus.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.space.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.trailingjunk.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.parse.zero.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.reflect.setcontent.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.reflect.setidl.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.reflect.setidlzero.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.removed.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.decimal.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.em.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.empty.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.exp.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.hex.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.junk.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.minus.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.octal.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.onlyspace.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.percent.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.plus.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.space.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.trailingjunk.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.whitespace.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.zero.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/size.attributes.style.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.arguments.1.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.arguments.2.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.arguments.3.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.bogustype.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.default.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.alpha.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.primarycolours.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.quality.basic.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.quality.notnumber.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.quality.outsiderange.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpg.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.lowercase.ascii.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.lowercase.unicode.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.nocontext.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.complexcolours.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.primarycolours.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.unrecognised.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.zeroheight.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.zerosize.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.zerowidth.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.delete.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.exists.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.extend.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.name.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.prototype.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/type.replace.html:
  • web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-in-object-fallback.html:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation-3.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/adoption.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/non-active-document.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/sizes-iframed.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/select-an-image-source.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html:
  • web-platform-tests/html/semantics/forms/form-control-infrastructure/form.html:
  • web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter.html:
  • web-platform-tests/html/semantics/forms/the-form-element/form-nameditem.html:
  • web-platform-tests/html/semantics/grouping-content/the-pre-element/grouping-pre-reftest-001.html:
  • web-platform-tests/html/semantics/interactive-elements/the-details-element/details.html:
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering-iframe.sub.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/load-error-events-1.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/load-error-events-2.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/nomodule-set-on-async-classic-script.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-charset-01.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-charset-02.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-type-and-language-empty.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-type-and-language-with-params.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/checked.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/enabled.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange.html:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly.html:
  • web-platform-tests/html/semantics/tabular-data/processing-model-1/span-limits.html:
  • web-platform-tests/html/semantics/text-level-semantics/the-a-element/a.text-getter-01.html:
  • web-platform-tests/html/semantics/text-level-semantics/the-a-element/a.text-setter-01.html:
  • web-platform-tests/html/semantics/text-level-semantics/the-time-element/001.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-001.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-007.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-009.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-016.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-018.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-030.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-034.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-037.html:
  • web-platform-tests/html/syntax/parsing-html-fragments/the-input-byte-stream-038.html:
  • web-platform-tests/html/syntax/parsing/Element.getElementsByTagName-foreign-02.html:
  • web-platform-tests/html/syntax/parsing/math-parse03.html:
  • web-platform-tests/html/syntax/parsing/named-character-references.html:
  • web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt:
  • web-platform-tests/html/syntax/serializing-html-fragments/serializing.html:
  • web-platform-tests/html/webappapis/atob/base64.html:
  • web-platform-tests/html/webappapis/scripting/events/eventhandler-cancellation.html:
  • web-platform-tests/html/webappapis/scripting/events/resources/compiled-event-handler-settings-objects-support.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-body-onerror.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-parse-error.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-runtime-error-throw.html:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-runtime-error.html:
  • web-platform-tests/media-source/mediasource-activesourcebuffers.html:
  • web-platform-tests/media-source/mediasource-addsourcebuffer.html:
  • web-platform-tests/media-source/mediasource-append-buffer.html:
  • web-platform-tests/media-source/mediasource-appendbuffer-quota-exceeded.html:
  • web-platform-tests/media-source/mediasource-appendwindow.html:
  • web-platform-tests/media-source/mediasource-attach-stops-delaying-load-event.html:
  • web-platform-tests/media-source/mediasource-avtracks.html:
  • web-platform-tests/media-source/mediasource-buffered.html:
  • web-platform-tests/media-source/mediasource-closed.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-a-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-av-audio-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-av-framesize.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-av-video-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-v-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-v-framerate.html:
  • web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-a-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-av-audio-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-av-framesize.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-av-video-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-v-bitrate.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-v-framerate.html:
  • web-platform-tests/media-source/mediasource-config-change-webm-v-framesize.html:
  • web-platform-tests/media-source/mediasource-detach.html:
  • web-platform-tests/media-source/mediasource-duration-boundaryconditions.html:
  • web-platform-tests/media-source/mediasource-duration.html:
  • web-platform-tests/media-source/mediasource-endofstream-invaliderror.html:
  • web-platform-tests/media-source/mediasource-errors.html:
  • web-platform-tests/media-source/mediasource-getvideoplaybackquality.html:
  • web-platform-tests/media-source/mediasource-is-type-supported.html:
  • web-platform-tests/media-source/mediasource-liveseekable.html:
  • web-platform-tests/media-source/mediasource-multiple-attach.html:
  • web-platform-tests/media-source/mediasource-play-then-seek-back.html:
  • web-platform-tests/media-source/mediasource-play.html:
  • web-platform-tests/media-source/mediasource-preload.html:
  • web-platform-tests/media-source/mediasource-redundant-seek.html:
  • web-platform-tests/media-source/mediasource-remove.html:
  • web-platform-tests/media-source/mediasource-removesourcebuffer.html:
  • web-platform-tests/media-source/mediasource-seek-beyond-duration.html:
  • web-platform-tests/media-source/mediasource-seek-during-pending-seek.html:
  • web-platform-tests/media-source/mediasource-seekable.html:
  • web-platform-tests/media-source/mediasource-sequencemode-append-buffer.html:
  • web-platform-tests/media-source/mediasource-sourcebuffer-mode.html:
  • web-platform-tests/media-source/mediasource-sourcebuffer-trackdefaults.html:
  • web-platform-tests/media-source/mediasource-sourcebufferlist.html:
  • web-platform-tests/media-source/mediasource-timestamp-offset.html:
  • web-platform-tests/media-source/mediasource-trackdefault.html:
  • web-platform-tests/media-source/mediasource-trackdefaultlist.html:
  • web-platform-tests/mediacapture-streams/MediaStream-MediaElement-preload-none.https.html:
  • web-platform-tests/resource-timing/resource-timing.html:
  • web-platform-tests/resource-timing/resources/resource_timing_test0.xml:
  • web-platform-tests/resources/test/tests/iframe-consolidate-errors.html:
  • web-platform-tests/resources/test/tests/iframe-consolidate-tests.html:
  • web-platform-tests/resources/test/tests/iframe-msg.html:
  • web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html:
  • web-platform-tests/service-workers/service-worker/multi-globals/url-parsing.https.html:
  • web-platform-tests/service-workers/service-worker/multiple-update.https.html:
  • web-platform-tests/service-workers/service-worker/resources/appcache-ordering.is-appcached.html:
  • web-platform-tests/service-workers/service-worker/resources/clients-matchall-client-types-iframe.html:
  • web-platform-tests/service-workers/service-worker/update-after-oneday.https.html:
  • web-platform-tests/service-workers/stub-3.1-service-worker-obj.html:
  • web-platform-tests/service-workers/stub-3.1.1-service-worker-scope.html:
  • web-platform-tests/service-workers/stub-3.1.2-service-worker-url.html:
  • web-platform-tests/service-workers/stub-3.1.3-service-worker-state.html:
  • web-platform-tests/service-workers/stub-3.1.4-service-worker-on-state-change.html:
  • web-platform-tests/service-workers/stub-3.2-navigator-service-worker.html:
  • web-platform-tests/service-workers/stub-3.2.1-navigator-service-worker-installing.html:
  • web-platform-tests/service-workers/stub-3.2.10-navigator-service-worker-oncontrollerchange.html:
  • web-platform-tests/service-workers/stub-3.2.11-navigator-service-worker-onreloadpage.html:
  • web-platform-tests/service-workers/stub-3.2.12-navigator-service-worker-onerror.html:
  • web-platform-tests/service-workers/stub-3.2.2-navigator-service-worker-waiting.html:
  • web-platform-tests/service-workers/stub-3.2.3-navigator-service-worker-active.html:
  • web-platform-tests/service-workers/stub-3.2.4-navigator-service-worker-controller.html:
  • web-platform-tests/service-workers/stub-3.2.5-navigator-service-worker-ready.html:
  • web-platform-tests/service-workers/stub-3.2.6-navigator-service-worker-getAll.html:
  • web-platform-tests/service-workers/stub-3.2.7-navigator-service-worker-register.html:
  • web-platform-tests/service-workers/stub-3.2.8-navigator-service-worker-unregister.html:
  • web-platform-tests/service-workers/stub-3.2.9-navigator-service-worker-onupdatefound.html:
  • web-platform-tests/service-workers/stub-4.1-service-worker-global-scope.html:
  • web-platform-tests/service-workers/stub-4.1.1-service-worker-global-scope-caches.html:
  • web-platform-tests/service-workers/stub-4.1.2-service-worker-global-scope-clients.html:
  • web-platform-tests/service-workers/stub-4.1.3-service-worker-global-scope-scope.html:
  • web-platform-tests/service-workers/stub-4.1.4-service-worker-global-scope-fetch.html:
  • web-platform-tests/service-workers/stub-4.1.5-service-worker-global-scope-update.html:
  • web-platform-tests/service-workers/stub-4.1.6-service-worker-global-scope-unregister.html:
  • web-platform-tests/service-workers/stub-4.1.7-service-worker-global-scope-onmessage.html:
  • web-platform-tests/service-workers/stub-4.2-client.html:
  • web-platform-tests/service-workers/stub-4.3-service-worker-clients.html:
  • web-platform-tests/service-workers/stub-4.3.1-get-serviced-method.html:
  • web-platform-tests/service-workers/stub-4.3.2-reloadall-method.html:
  • web-platform-tests/service-workers/stub-4.5-response-objects.html:
  • web-platform-tests/service-workers/stub-4.5.2-response.html:
  • web-platform-tests/service-workers/stub-4.5.4-opaque-response.html:
  • web-platform-tests/service-workers/stub-4.6-cache-objects.html:
  • web-platform-tests/service-workers/stub-4.6.1-cache-lifetimes.html:
  • web-platform-tests/service-workers/stub-4.6.3-cache-storage.html:
  • web-platform-tests/service-workers/stub-4.7.1-install-phase-event.html:
  • web-platform-tests/service-workers/stub-4.7.1.1-wait-until-method.html:
  • web-platform-tests/service-workers/stub-4.7.2-install-event.html:
  • web-platform-tests/service-workers/stub-4.7.2.1-install-event-section.html:
  • web-platform-tests/service-workers/stub-4.7.2.2-replace-method.html:
  • web-platform-tests/service-workers/stub-4.7.3-activate-event.html:
  • web-platform-tests/service-workers/stub-4.7.4.1-fetch-event-section.html:
  • web-platform-tests/service-workers/stub-4.7.4.2-respond-with-method.html:
  • web-platform-tests/service-workers/stub-4.7.4.3-default-method.html:
  • web-platform-tests/service-workers/stub-4.7.4.4-is-reload-attribute.html:
  • web-platform-tests/service-workers/stub-5.1-origin-relativity.html:
  • web-platform-tests/service-workers/stub-5.2-cross-origin-resources.html:
  • web-platform-tests/shadow-dom/leaktests/get-elements.html:
  • web-platform-tests/tools/pywebsocket/src/example/arraybuffer_benchmark.html:
  • web-platform-tests/tools/pywebsocket/src/example/benchmark.html:
  • web-platform-tests/tools/pywebsocket/src/example/console.html:
  • web-platform-tests/tools/pywebsocket/src/example/eventsource.html:
  • web-platform-tests/tools/pywebsocket/src/example/xhr_benchmark.html:
  • web-platform-tests/tools/pywebsocket/src/example/xhr_event_logger.html:
  • web-platform-tests/url/a-element-origin-xhtml.xhtml:
  • web-platform-tests/url/a-element-origin.html:
  • web-platform-tests/url/a-element-xhtml.xhtml:
  • web-platform-tests/url/a-element.html:
  • web-platform-tests/webrtc/RTCConfiguration-iceCandidatePoolSize.html:
  • web-platform-tests/webrtc/RTCPeerConnection-canTrickleIceCandidates.html:
  • web-platform-tests/webrtc/RTCPeerConnection-idl.html:
  • web-platform-tests/webrtc/RTCPeerConnectionIceEvent-constructor.html:
  • web-platform-tests/webrtc/datachannel-emptystring.html:
  • web-platform-tests/webrtc/datachannel-idlharness.html:
  • web-platform-tests/webrtc/getstats.html:
  • web-platform-tests/webrtc/no-media-call.html:
  • web-platform-tests/webrtc/promises-call.html:
  • web-platform-tests/webrtc/simplecall.html:

Tools:

Update import-w3c-tests to stop rewriting tests as this is causing some tests
to fail unexpectedly.

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.import_tests):

6:59 PM Changeset in webkit [223272] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.3.5.0.3

Tag Safari-604.3.5.0.3.

6:55 PM Changeset in webkit [223271] by achristensen@apple.com
  • 48 edits
    4 deletes in trunk

Use asynchronous ResourceHandleClient calls for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=160677

Reviewed by Brady Eidson.

Source/WebCore:

Covered by existing tests.

  • PlatformAppleWin.cmake:
  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequestAsync):
(WebCore::ResourceLoader::didReceiveResponseAsync):
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):

  • loader/ResourceLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponseAsync):
(WebCore::ApplicationCacheGroup::willSendRequestAsync):
(WebCore::ApplicationCacheGroup::canAuthenticateAgainstProtectionSpaceAsync):
(WebCore::ApplicationCacheGroup::didReceiveResponse): Deleted.

  • loader/appcache/ApplicationCacheGroup.h:
  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::continueDidReceiveResponse):
(WebCore::BlobResourceHandle::getSizeForNext):
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
(WebCore::BlobResourceHandle::notifyResponseOnError):

  • platform/network/PingHandle.h:
  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::didReceiveResponse):
(WebCore::ResourceHandle::usesAsyncCallbacks): Deleted.

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.cpp:

(WebCore::ResourceHandleClient::~ResourceHandleClient):
(WebCore::ResourceHandleClient::willSendRequest): Deleted.
(WebCore::ResourceHandleClient::willSendRequestAsync): Deleted.
(WebCore::ResourceHandleClient::didReceiveResponseAsync): Deleted.
(WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpaceAsync): Deleted.

  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandleClient::didReceiveResponse): Deleted.
(WebCore::ResourceHandleClient::usesAsyncCallbacks): Deleted.
(WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpace): Deleted.

  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

  • platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::willSendRequestAsync):
(WebCore::SynchronousLoaderClient::canAuthenticateAgainstProtectionSpaceAsync):
(WebCore::SynchronousLoaderClient::didReceiveResponseAsync):
(WebCore::SynchronousLoaderClient::didFinishLoading):
(WebCore::SynchronousLoaderClient::didFail):
(WebCore::SynchronousLoaderClient::willSendRequest): Deleted.
(WebCore::SynchronousLoaderClient::canAuthenticateAgainstProtectionSpace): Deleted.
(WebCore::SynchronousLoaderClient::didReceiveResponse): Deleted.

  • platform/network/SynchronousLoaderClient.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::willSendRequest):
(WebCore::ResourceHandle::shouldUseCredentialStorage):
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):

  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::ResourceHandleCFURLConnectionDelegateWithOperationQueue):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::releaseHandle):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveChallenge):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::shouldUseCredentialStorage):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueCanAuthenticateAgainstProtectionSpace):

  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:
  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp: Removed.
  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h: Removed.
  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::schedule):
(WebCore::ResourceHandle::makeDelegate):
(WebCore::ResourceHandle::delegate):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandle::willSendRequest):
(WebCore::ResourceHandle::continueWillSendRequest):
(WebCore::ResourceHandle::continueDidReceiveResponse):
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::continueWillCacheResponse):
(WebCore::ResourceHandle::shouldUseCredentialStorage): Deleted.

  • platform/network/mac/WebCoreResourceHandleAsDelegate.h: Removed.
  • platform/network/mac/WebCoreResourceHandleAsDelegate.mm: Removed.
  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:
  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveData:lengthReceived:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didFailWithError:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):

Source/WebKitLegacy:

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::createPingHandle):

LayoutTests:

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/wk2/TestExpectations:

http/tests/cache/iframe-304-crash.html used to deterministically record its didFinishLoading callback,
but only for WK1. It was marked as flaky for all WK2 ports. It is now flaky in WK1 because the order
of the testRunner.notifyDone call and the didFinishLoading logging is no longer deterministic with
asynchronous loading, but the test still verifies that there is no crash.

http/tests/security/cross-origin-modal-dialog-base.html does navigation during showModalDialog, which
probably should've never worked in WK1 and never worked in WK2. WK1 behavior now matches WK2 behavior.
I'm not aware of any complaints about no navigation working during showModalDialog in WK2 and I imagine
nobody will be regressed by this change, but if we do find such a problem, creative use of MessageQueues
like we do with sync xhr in WK1 now could theoretically fix the problem, but we are trying to get
rid of showModalDialog anyway. The test was written to verify that the SecurityOrigin doesn't fall back
to the wrong origin, and it certainly doesn't now.

These tests dump load delegate call order, which are less deterministic now but the tests still behave correctly.
http/tests/svg/svg-use-external.html
http/tests/loading/text-content-type-with-binary-extension.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-iframe-in-main-frame.html

6:10 PM Changeset in webkit [223270] by achristensen@apple.com
  • 7 edits in trunk/Source/WebKit

Remove unnecessary includes in WebKit
https://bugs.webkit.org/show_bug.cgi?id=178235

Reviewed by Tim Horton.

  • Platform/IPC/ArgumentCoders.h:
  • WebProcess/WebProcess.cpp:
  • WebProcess/WebStorage/StorageAreaImpl.h:
6:04 PM Changeset in webkit [223269] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Increment ContentRuleListStore::CurrentContentRuleListFileVersion
https://bugs.webkit.org/show_bug.cgi?id=178246
<rdar://problem/34890057>

Reviewed by Tim Horton.

  • UIProcess/API/APIContentRuleListStore.h:

Things are crashing. Something isn't binary reverse compatible.
Probably something related to r222602.
This is why we have a version number to update.

6:01 PM October 2017 Meeting edited by Simon Fraser
(diff)
6:01 PM October 2017 Meeting edited by Simon Fraser
(diff)
5:47 PM Changeset in webkit [223268] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk/Source/WebInspectorUI

Web Inspector: Switch Clear navigation item back to the Trash icon (Console, Timelines, Network)
https://bugs.webkit.org/show_bug.cgi?id=178244
<rdar://problem/34966525>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-12
Reviewed by Brian Burg.

  • UserInterface/Images/NavigationItemClear.svg: Removed.
  • UserInterface/Images/gtk/NavigationItemClear.svg: Removed.
  • UserInterface/Views/LogContentView.js:

(WI.LogContentView):

  • UserInterface/Views/NetworkGridContentView.js:

(WI.NetworkGridContentView):

  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):

  • UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):
Many users found the new Clear icon confusing. Revert to the Trash icon.

5:41 PM Changeset in webkit [223267] by achristensen@apple.com
  • 8 edits in trunk/Source/WebKit

Expose some of WKView's WebViewImpl accessors through WKWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=178240
<rdar://problem/34962720>

Reviewed by Tim Horton.

Also renamed createFullScreenWindow to fullScreenWindow to reflect the fact that it returns
an autoreleased NSWindow so we don't make the same naming mistake in the WKWebView SPI.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _dismissContentRelativeChildWindows]):
(-[WKWebView _setFrame:andScrollBy:]):
(-[WKWebView _setTotalHeightOfBanners:]):
(-[WKWebView _totalHeightOfBanners]):
(-[WKWebView _beginDeferringViewInWindowChanges]):
(-[WKWebView _endDeferringViewInWindowChanges]):
(-[WKWebView _endDeferringViewInWindowChangesSync]):
(-[WKWebView _gestureEventWasNotHandledByWebCore:]):
(-[WKWebView _setIgnoresNonWheelEvents:]):
(-[WKWebView _ignoresNonWheelEvents]):
(-[WKWebView _setCustomSwipeViews:]):
(-[WKWebView _setCustomSwipeViewsTopContentInset:]):
(-[WKWebView _tryToSwipeWithEvent:ignoringPinnedState:]):
(-[WKWebView _setDidMoveSwipeSnapshotCallback:]):
(-[WKWebView _fullScreenPlaceholderView]):
(-[WKWebView _fullScreenWindow]):
(-[WKWebView _disableFrameSizeUpdates]):
(-[WKWebView _enableFrameSizeUpdates]):
(-[WKWebView _canChangeFrameLayout:]):
(-[WKWebView _underlayColor]):
(-[WKWebView _setUnderlayColor:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView createFullScreenWindow]):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::fullScreenWindowController):
(WebKit::WebViewImpl::fullScreenWindow):
(WebKit::WebViewImpl::createFullScreenWindow): Deleted.

5:39 PM Changeset in webkit [223266] by achristensen@apple.com
  • 4 edits in trunk/Source/WTF

Add Expected, HashMap, HashSet, and SHA1 to wtf/Forward.h
https://bugs.webkit.org/show_bug.cgi?id=178243

Reviewed by Tim Horton.

  • wtf/Forward.h:
  • wtf/HashMap.h:

Move default parameters to Forward.h like we did with Vector.

  • wtf/HashSet.h:

Also fix indentation.

5:36 PM Changeset in webkit [223265] by commit-queue@webkit.org
  • 11 edits
    1 copy
    1 move
    2 adds in trunk

Layout Test http/tests/cache-storage/cache-clearing.https.html is failing
https://bugs.webkit.org/show_bug.cgi?id=178200

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-12
Reviewed by Chris Dumez.

Source/WebKit:

Deleting only the per-origin folders inside the CacheStorage engine root folder.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::clearAllCaches):

  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreRemoveAllFetchCaches):
(WKWebsiteDataStoreRemoveFetchCacheForOrigin):

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:

Tools:

Making clearDOMCache wait for removal completion to exit.
This removes the risk to interact with the cache while deleting it which will end up be racy in tests.

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::clearDOMCache):

  • WebKitTestRunner/TestController.cpp:

(WTR::ClearDOMCacheCallbackContext::ClearDOMCacheCallbackContext):
(WTR::clearDOMCacheCallback):
(WTR::TestController::clearDOMCache):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

Splitting cache-clearing.https.html in two sub tests and marking them as Pass/Timeout for the moment.

  • platform/win/TestExpectations: Skipping cache/sw tests.
  • TestExpectations:
  • http/tests/cache-storage/cache-clearing.https.html: Removed.
  • http/tests/cache-storage/cache-clearing-all.https-expected.txt: Added.
  • http/tests/cache-storage/cache-clearing-all.https.html: Added.
  • http/tests/cache-storage/cache-clearing-origin.https-expected.txt: Added.
  • http/tests/cache-storage/cache-clearing-origin.https.html: Added.
5:24 PM Changeset in webkit [223264] by Chris Dumez
  • 28 edits in trunk

[Mac] Add support for MouseEvent.buttons
https://bugs.webkit.org/show_bug.cgi?id=178214

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline test now that more checks are passing.

  • web-platform-tests/dom/events/Event-subclasses-constructors-expected.txt:

Source/WebCore:

Add support for MouseEvent.buttons on Mac as per:

This is supported by Firefox and Chrome already.

No new tests, rebaselined existing test.

  • dom/Element.cpp:

(WebCore::Element::dispatchMouseEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):

  • dom/MouseEvent.h:

(WebCore::MouseEvent::buttons const):

  • dom/MouseEvent.idl:
  • dom/MouseEventInit.h:
  • dom/MouseEventInit.idl:
  • dom/SimulatedClick.cpp:
  • dom/WheelEvent.cpp:
  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):

  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::buttons const):

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::currentlyPressedMouseButtons):
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):

Source/WebKit:

  • Shared/WebEvent.h:

(WebKit::WebMouseEvent::buttons const):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):

  • Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::WebMouseEvent):
(WebKit::WebMouseEvent::encode const):
(WebKit::WebMouseEvent::decode):

  • Shared/mac/WebEventFactory.mm:

(WebKit::currentlyPressedMouseButtons):
(WebKit::WebEventFactory::createWebMouseEvent):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::showContextMenuAtPoint):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::createWebEvent const):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):
(WebKit::WebPage::simulateMouseDown):
(WebKit::WebPage::simulateMouseUp):
(WebKit::WebPage::simulateMouseMotion):

Source/WebKitLegacy/mac:

  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

5:19 PM Changeset in webkit [223263] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Add API to clean CacheStorage data
https://bugs.webkit.org/show_bug.cgi?id=178034

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-12

  • Shared/WebsiteData/WebsiteDataType.h: fixing the DOMCache value.
3:39 PM October 2017 Meeting edited by cavalcantii@gmail.com
(diff)
3:36 PM Changeset in webkit [223262] by commit-queue@webkit.org
  • 4 edits
    14 adds in trunk/Source/WebKit

[WinCairo] add WebProcess files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=178024

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-10-12
Reviewed by Alex Christensen.

  • PlatformWin.cmake:
  • WebProcess/Cookies/curl/WebCookieManagerCurl.cpp: Added.

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):

  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp: Added.

(WebKit::InjectedBundle::initialize):
(WebKit::InjectedBundle::setBundleParameter):
(WebKit::InjectedBundle::setBundleParameters):

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/win/PluginProxyWin.cpp: Added.

(WebKit::PluginProxy::needsBackingStore const):

  • WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp: Added.

(WebKit::WebContextMenuClient::lookUpInDictionary):
(WebKit::WebContextMenuClient::isSpeaking):
(WebKit::WebContextMenuClient::speak):
(WebKit::WebContextMenuClient::stopSpeaking):

  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp: Added.

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::storageSession const):
(WebKit::WebFrameNetworkingContext::webFrameLoaderClient const):
(WebKit::WebFrameNetworkingContext::blockedError const):

  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h: Added.

(WebKit::WebFrameNetworkingContext::create):

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: Added.

(WebKit::WebPopupMenu::setUpPlatformData):

  • WebProcess/WebPage/win/WebInspectorUIWin.cpp: Added.

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):
(WebKit::RemoteWebInspectorUI::localizedStringsURL):

  • WebProcess/WebPage/win/WebPageWin.cpp: Added.

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::platformDetach):
(WebKit::WebPage::platformEditorState const):
(WebKit::WebPage::platformPreferencesDidChange):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::platformCanHandleRequest):
(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseDataForURL):
(WebKit::WebPage::platformUserAgent const):
(WebKit::WebPage::interpretKeyEvent):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensureWebToStorageProcessConnection):

  • WebProcess/win/WebProcessWin.cpp: Added.

(loadResourceIntoBuffer):
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):
(WebKit::WebProcess::platformSetCacheModel):

2:44 PM Changeset in webkit [223261] by ddkilzer@apple.com
  • 4 edits in trunk/Source

[iOS] Fix -Wunused-lambda-capture warnings in WebCore/WebKit with new clang compiler
<https://webkit.org/b/178226>

Reviewed by Chris Fleizach.

Source/WebCore:

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityArticleAncestor]):

  • Remove unused lambda variable 'self'.

Source/WebKit:

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]):

  • Remove unused lambda variable 'touch' which was also passed as an argument.

(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):

  • Remove unused lambda variable 'gestureState' which was also passed as an argument.

(-[WKContentView _simulateLongPressActionAtLocation:]):

  • Remove unused lambda variable 'location'.
2:38 PM Changeset in webkit [223260] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

Mark more InlineBox member functions as const
https://bugs.webkit.org/show_bug.cgi?id=178217

Reviewed by Andy Estes.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::locationIncludingFlipping const): Mark as const. Also fix some style
nits while I am here.
(WebCore::InlineBox::flipForWritingMode const): Mark as const.
(WebCore::InlineBox::locationIncludingFlipping): Deleted.
(WebCore::InlineBox::flipForWritingMode): Deleted.

  • rendering/InlineBox.h:
2:31 PM Changeset in webkit [223259] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Teach InlineTextBox::clampOffset() about combined text and hyphenation
https://bugs.webkit.org/show_bug.cgi?id=178032

Reviewed by Zalan Bujtas.

Treat combined text and the last character of a word halve plus hyphen as single units.

With regards to combined text, ideally we would allow arbitrary selection inside combined
text. Currently we do not support selection of combined text. To simplify the process of
adding support for selecting combined text we treat combined text as a single unit. Once
we are confident that we correctly implemented such support we can re-evaluate allowing
arbitrary selection of combined text.

With regards to treating the last character of a word halve plus hyphen as a single unit.
This patch extends the targeted fix made for document markers in r223013 to all code that
makes use of clamped offsets as a result the selection rect for inline boxes more accurately
reflect the rectangle(s) that make up the painted selection. This is a step towards reconciling
the difference between the computation of the rectangle that represents an arbitrary
selection and the code that paints the active selection as part of <https://bugs.webkit.org/show_bug.cgi?id=138913>.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::localSelectionRect const): Compute text run, including combined text
or hyphens due to line wrapping now that specified start and end positions are clamped with
respect to combined text and hyphens (computed earlier in this function). Only measure the
text represented by the selection if the start position > 0 or the end position is not equal
to the length of the run.
(WebCore::InlineTextBox::paint): Remove unnecessary code to fix up the selection start and
end positions based on the truncation offset as this is done by clampedOffset(), called by
selectionStartEnd().
(WebCore::InlineTextBox::clampedOffset const): Modified to adjust the clamped offset with
respect to truncation as well as treat combined text or a trailing word halve plus hyphen
as single units. Assert that we are not fully truncated because it does not make sense to
be computing the clamped offset in such a situation since nothing should be painted.
(WebCore::InlineTextBox::selectionStartEnd const): Modified to compute the end of an inside
selection using clampedOffset() to account for truncation, combined text or a hyphen. We
already are using clampedOffset() when computing the start and end position for all other
selection states.
(WebCore::InlineTextBox::paintSelection): Compute text run, including combined text
or hyphens due to line wrapping now that specified start and end positions are clamped with
respect to combined text and hyphens (computed earlier in this function). Remove unnecessary
code to adjust selection end point with respect to truncation, combined text, or an added
hyphen now that selectionStartEnd() takes care of this (via clampedOffset()).
(WebCore::InlineTextBox::paintTextSubrangeBackground): Compute text run, including combined
text or hyphens due to line wrapping now that specified start and end positions are clamped
with respect to combined text and hyphens (computed earlier in this function).
(WebCore::InlineTextBox::paintDocumentMarker): Compute text run, including combined text now
that specified start and end positions are clamped with respect to combined text (computed earlier in this function).
Also remove unnecessary code to adjust end offset of the marker with respect to truncation
and length of the text run as clampedOffset() now does this for us.

2:29 PM Changeset in webkit [223258] by achristensen@apple.com
  • 3 edits in trunk/Source/WTF

Add CompletionHandler and HashCountedSet to wtf/Forward.h
https://bugs.webkit.org/show_bug.cgi?id=178231

Reviewed by Tim Horton.

  • wtf/Forward.h:
  • wtf/HashCountedSet.h:
2:21 PM Changeset in webkit [223257] by dino@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r223063. rdar://problem/34921832

2:16 PM Changeset in webkit [223256] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark some xhtml tests as failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=178230

Unreviewed test gardening.

  • platform/win/TestExpectations:
2:15 PM Changeset in webkit [223255] by dino@apple.com
  • 10 edits in branches/safari-604-branch

Cherry-pick r222961. <rdar://problem/34891070>

2:12 PM Changeset in webkit [223254] by Simon Fraser
  • 3 edits
    2 adds in trunk

Don't assert if mix-blend-mode is set to a non-separable blend mode on a composited layer
https://bugs.webkit.org/show_bug.cgi?id=178196
rdar://problem/34942337

Reviewed by Dan Bates.

Source/WebCore:

Core Animation doesn't support non-separable blend modes (hue, saturation, color, luminosity)
on layers, but don't assert if we try to use them.

Test: compositing/filters/blend-mode-saturation.html

  • platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:

(PlatformCAFilters::setBlendingFiltersOnLayer):

LayoutTests:

  • compositing/filters/blend-mode-saturation-expected.txt: Added.
  • compositing/filters/blend-mode-saturation.html: Added.
1:13 PM Changeset in webkit [223253] by wilander@apple.com
  • 22 edits
    32 adds in trunk

ResourceLoadObserver::logFrameNavigation() should use redirectResponse.url()
https://bugs.webkit.org/show_bug.cgi?id=175257
<rdar://problem/33359866>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch was joint work between Michael Specter and John Wilander.

Tests: http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html

http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html
http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html
http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip.html
http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html
http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest):

Now sends redirectResponse.url() to WebCore::ResourceLoadObserver::logFrameNavigation().

  • loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logFrameNavigation):

Now receives the redirect response URL from WebCore::DocumentLoader().

(WebCore::ResourceLoadObserver::nonNullOwnerURL const):

New function to traverse the frame chain upward and find the first non-null URL.

  • loader/ResourceLoadObserver.h:

Source/WebKit:

  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _resourceLoadStatisticsIsRegisteredAsSubFrameUnder:topFrameHost:completionHandler:]):
(-[WKWebsiteDataStore _resourceLoadStatisticsIsRegisteredAsRedirectingTo:hostRedirectedTo:completionHandler:]):

Test infrastructure.

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsSubFrameUnder):
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsRedirectingTo):

Test infrastructure.

  • UIProcess/WebResourceLoadStatisticsStore.h:

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
(WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):

Not implemented.

(WTR::TestController::isStatisticsRegisteredAsRedirectingTo):

Not implemented.

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):

Implemented platform-specific.

(WTR::TestController::isStatisticsRegisteredAsRedirectingTo):

Implemented platform-specific.

LayoutTests:

Marked new directory as [ Skip ] since these are WK2-only.

  • http/tests/resourceLoadStatistics: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt: Added.
  • http/tests/resourceLoadStatistics/non-sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/resources: Added.
  • http/tests/resourceLoadStatistics/resources/iframe-report-back-loaded.html: Added.
  • http/tests/resourceLoadStatistics/resources/page-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/resources/page-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/resources/page-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/resources/page-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/resources/redirect.php: Added.
  • http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt: Added.
  • http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt: Added.
  • http/tests/resourceLoadStatistics/sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-non-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip-expected.txt: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-ip-to-localhost-to-ip.html: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost-expected.txt: Added.
  • http/tests/resourceLoadStatistics/sandboxed-nesting-iframe-with-sandboxed-iframe-redirect-localhost-to-ip-to-localhost.html: Added.
  • platform/gtk/TestExpectations:

Marked new directory as [ Skip ].

  • platform/wk2/TestExpectations:

Marked new directory as [ Pass ].

  • platform/wpe/TestExpectations:

Marked new directory as [ Skip ].

1:07 PM Changeset in webkit [223252] by jmarcell@apple.com
  • 2 edits in tags/Safari-605.1.10/Source/JavaScriptCore

Cherry-pick r223248. rdar://problem/34956170

1:01 PM Changeset in webkit [223251] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/fetch/security/dangling-markup-mitigation-data-url.tentative.sub.html as flaky on iOS.
https://bugs.webkit.org/show_bug.cgi?id=177547

Unreviewed test gardening.

  • platform/ios/TestExpectations:
12:51 PM Changeset in webkit [223250] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

12:48 PM Changeset in webkit [223249] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.4.2

Tag Safari-604.4.2.

12:24 PM Changeset in webkit [223248] by pvollan@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Win64] JSC compile error.
https://bugs.webkit.org/show_bug.cgi?id=178213

Reviewed by Alex Christensen.

Add static cast from int64 to uintptr_t.

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::executeOSRExit):

12:12 PM Changeset in webkit [223247] by aestes@apple.com
  • 5 edits in trunk

[iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices
https://bugs.webkit.org/show_bug.cgi?id=178181
<rdar://problem/33660282>

Reviewed by Dan Bernstein.

Source/WebKit:

  • Configurations/BaseTarget.xcconfig:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName):

  • WebKit.xcodeproj/project.pbxproj:

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::databaseProcessName):

11:45 AM Changeset in webkit [223246] by mmaxfield@apple.com
  • 6 edits
    3 adds in trunk/Tools

Emit SPIR-V from WSL compiler (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=177998

Reviewed by Filip Pizlo.

This patch implements the first half of a SPIR-V codegen phase for WSL.
This includes all the operations which aren't actually emitting the contents
of functions themselves. For example, this includes things like representing
WSL types with SPIR-V types, and declaring shaders' inputs and outputs. A
future patch will actually emit the contents of functions.

There are two helper visitors here: SPIRVTypeAnalyzer which generates SPIR-V
types from WSL types, and SPIRVPrimitiveVariableAnalyzer which identifies
input and output variables from a shader (and assigns location values to
each one).

This patch is currently pursuing the "logical mode" detailed in
https://bugs.webkit.org/show_bug.cgi?id=176967. In this mode, each pointer and
array reference operation can be statically traced to the variable or array it
is operating on.

This has the interesting property where accessing a pointer inside an array is
forbidden, because the array index may be computed at runtime, so the compiler
can't know at compile time which variable the pointer operation will be
accessing. However, this isn't true for structs; the program must statically
state which struct member it is accessing. Therefore, pointers or array
references must not transitively appear within an array, but they may appear
within a struct. The same logic applies to array references; those get lowered
to just two indexes in SPIR-V (a lower bound and an upper bound).

So, outside of an array, SPIR-V types don't need to include any pointers because
any operation with the pointer doesn't need access to the runtime value of the
pointer. Inside of an array, pointers are forbidden. Therefore, SPIR-V types
will never include any pointers.

This means that, for example, WSL can represent a linked list in logical mode.
However, a WSL program cannot iterate across the list, because that would require
assigning to a pointer. So instead, a program using a linked list could only say
something like "list.ptr->ptr->ptr->value".

  • WebGPUShadingLanguageRI/LateChecker.js:

(LateChecker.prototype._checkShaderType):

  • WebGPUShadingLanguageRI/SPIR-V.js:

(SPIRV.OperandChecker.prototype._isStar):
(SPIRV.OperandChecker.prototype.nextComparisonType):
(SPIRV.OperandChecker.prototype.finalize):
(SPIRV.OperandChecker):

  • WebGPUShadingLanguageRI/SPIRV.html:
  • WebGPUShadingLanguageRI/SPIRVCodegen.js: Added.

(findEntryPoints):
(emitTypes.doEmitTypes):
(emitTypes):
(ConstantFinder.prototype.visitGenericLiteralType):
(ConstantFinder):
(generateSPIRV):

  • WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Added.

(SPIRVTypeAnalyzer):
(SPIRVTypeAnalyzer.prototype.get program):
(SPIRVTypeAnalyzer.prototype.get typeMap):
(SPIRVTypeAnalyzer.prototype.get currentId):
(SPIRVTypeAnalyzer.prototype.get stack):
(SPIRVTypeAnalyzer.prototype.visitTypeRef):
(SPIRVTypeAnalyzer.prototype._encounterType):
(SPIRVTypeAnalyzer.prototype.visitNullType):
(SPIRVTypeAnalyzer.prototype.visitGenericLiteralType):
(SPIRVTypeAnalyzer.prototype.visitNativeType):
(SPIRVTypeAnalyzer.prototype.visitEnumType):
(SPIRVTypeAnalyzer.prototype.visitPtrType):
(SPIRVTypeAnalyzer.prototype.visitArrayRefType):
(SPIRVTypeAnalyzer.prototype.visitArrayType):
(SPIRVTypeAnalyzer.prototype.visitStructType):

  • WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Added.

(SPIRVPrimitiveVariableAnalyzer):
(SPIRVPrimitiveVariableAnalyzer.prototype.get program):
(SPIRVPrimitiveVariableAnalyzer.prototype.get typeMap):
(SPIRVPrimitiveVariableAnalyzer.prototype.get currentId):
(SPIRVPrimitiveVariableAnalyzer.prototype.get currentLocation):
(SPIRVPrimitiveVariableAnalyzer.prototype.get nameComponents):
(SPIRVPrimitiveVariableAnalyzer.prototype.get result):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitTypeRef):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitNullType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitGenericLiteralType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitNativeType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitEnumType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitPtrType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitArrayRefType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitArrayType):
(SPIRVPrimitiveVariableAnalyzer.prototype.visitStructType):

  • WebGPUShadingLanguageRI/WSL.md:
  • WebGPUShadingLanguageRI/index.html:
11:31 AM Changeset in webkit [223245] by jmarcell@apple.com
  • 5 edits in branches/safari-604-branch

Apply patch. rdar://problem/34891292

11:31 AM Changeset in webkit [223244] by jmarcell@apple.com
  • 11 edits
    4 adds in branches/safari-604-branch

Apply patch. rdar://problem/34893194

11:29 AM Changeset in webkit [223243] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Edited expectations for http/tests/media/video-buffered-range-contains-currentTime.html.
https://bugs.webkit.org/show_bug.cgi?id=177616

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:26 AM Changeset in webkit [223242] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit

CacheStorage persistent folder should be in /Library/Cache
https://bugs.webkit.org/show_bug.cgi?id=178193

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-12
Reviewed by Brady Eidson.

  • UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:

(API::WebsiteDataStore::defaultCacheStorageDirectory): Making CacheStorage
directory a subfolder of Caches folder.
(API::WebsiteDataStore::defaultDataStoreConfiguration):

  • UIProcess/WebProcessPool.cpp:

(WebKit::legacyWebsiteDataStoreConfiguration):
(WebKit::WebProcessPool::ensureNetworkProcess): Make sure the web site data store
has the right cache directory path. Also make sure that the quota is set even if there is no folder specified.
Quota may still be useful in case of non persistent sessions.

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):

  • UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp:

(API::WebsiteDataStore::defaultCacheStorageDirectory):

11:21 AM Changeset in webkit [223241] by mmaxfield@apple.com
  • 2 edits
    2 adds in trunk/Source/WebCore/PAL

[Win] Build fix after r223206
https://bugs.webkit.org/show_bug.cgi?id=171523

Unreviewed.

  • pal/PlatformWin.cmake:
  • pal/win/LoggingWin.cpp: Added.

(PAL::logLevelString):

10:42 AM Changeset in webkit [223240] by fred.wang@free.fr
  • 2 edits in trunk/Source/WebCore

Use less specific cast in ScrollingTree::scrollPositionChangedViaDelegatedScrolling
https://bugs.webkit.org/show_bug.cgi?id=178211

Patch by Frederic Wang <fwang@igalia.com> on 2017-10-12
Reviewed by Simon Fraser.

No new tests, behavior is not changed.

ScrollingTree::scrollPositionChangedViaDelegatedScrolling is a generic function that applies
to scrolling nodes. Casting to more specific ScrollingTreeOverflowScrollingNodes is however
not necessary to implement it. This patch moves to the least specific cast necessary so that
this function will be usable for async scrolling of non-main frames in the future. Note that
the function is currently only called from ScrollingTreeScrollingNodeDelegateIOS which in
turn is only used by the ScrollingTreeScrollingOverflowNodeIOS class and so code behavior is
not changed.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::scrollPositionChangedViaDelegatedScrolling): Only cast the node to
ScrollingTreeScrollingNode.

9:02 AM Changeset in webkit [223239] by fpizlo@apple.com
  • 22 edits
    6 adds in trunk

Enable gigacage on iOS
https://bugs.webkit.org/show_bug.cgi?id=177586

Reviewed by JF Bastien.
JSTests:


Add tests for when Gigacage gets runtime disabled.

  • stress/disable-gigacage-arrays.js: Added.

(foo):

  • stress/disable-gigacage-strings.js: Added.

(foo):

  • stress/disable-gigacage-typed-arrays.js: Added.

(foo):

Source/bmalloc:


Introduce the ability to disable gigacage at runtime if allocation fails. If any step of gigacage
allocation fails, we free all of the gigacages and turn off gigacage support.

Roll this back in after discussion.

  • CMakeLists.txt:
  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Cache.cpp:

(bmalloc::Cache::scavenge):

  • bmalloc/Cache.h:

(bmalloc::Cache::tryAllocate):
(bmalloc::Cache::allocate):
(bmalloc::Cache::deallocate):
(bmalloc::Cache::reallocate):

  • bmalloc/Gigacage.cpp:

(Gigacage::ensureGigacage):
(Gigacage::runway):
(Gigacage::totalSize):
(Gigacage::shouldBeEnabled):
(): Deleted.
(Gigacage::Callback::Callback): Deleted.
(Gigacage::Callback::function): Deleted.
(Gigacage::PrimitiveDisableCallbacks::PrimitiveDisableCallbacks): Deleted.

  • bmalloc/Gigacage.h:

(Gigacage::wasEnabled):
(Gigacage::isEnabled):
(Gigacage::runway): Deleted.
(Gigacage::totalSize): Deleted.

  • bmalloc/HeapKind.cpp: Added.

(bmalloc::isActiveHeapKind):
(bmalloc::mapToActiveHeapKind):

  • bmalloc/HeapKind.h:

(bmalloc::isActiveHeapKindAfterEnsuringGigacage):
(bmalloc::mapToActiveHeapKindAfterEnsuringGigacage):

  • bmalloc/Scavenger.cpp:

(bmalloc::Scavenger::scavenge):

  • bmalloc/bmalloc.h:

(bmalloc::api::tryLargeMemalignVirtual):
(bmalloc::api::freeLargeVirtual):
(bmalloc::api::isEnabled):

Source/JavaScriptCore:

The hardest part of enabling Gigacage on iOS is that it requires loading global variables while
executing JS, so the LLInt needs to know how to load from global variables on all platforms that
have Gigacage. So, this teaches ARM64 how to load from global variables.

Also, this makes the code handle disabling the gigacage a bit better.

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::cage):
(JSC::AssemblyHelpers::cageConditionally):

  • offlineasm/arm64.rb:
  • offlineasm/asm.rb:
  • offlineasm/instructions.rb:

Tools:


Add a mode to test disabling Gigacage.

  • Scripts/run-jsc-stress-tests:
  • Scripts/webkitruby/jsc-stress-test-writer-default.rb:
8:38 AM Changeset in webkit [223238] by weinig@apple.com
  • 54 edits in trunk

Remove out-parameter variants of copyToVector
https://bugs.webkit.org/show_bug.cgi?id=178155

Reviewed by Tim Horton.

Source/JavaScriptCore:

  • inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::dispatchBreakpointActionLog):
(Inspector::ScriptDebugServer::dispatchBreakpointActionSound):
(Inspector::ScriptDebugServer::dispatchBreakpointActionProbe):
(Inspector::ScriptDebugServer::dispatchDidParseSource):
(Inspector::ScriptDebugServer::dispatchFailedToParseSource):
(Inspector::ScriptDebugServer::dispatchFunctionToListeners):

Replace out-parameter based copyToVector, with one that returns a Vector.

Source/WebCore:

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::stopTimersForOneShots):
(WebCore::Geolocation::cancelAllRequests):
(WebCore::Geolocation::handleError):
(WebCore::Geolocation::makeSuccessCallbacks):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBGetAllResult.cpp:

(WebCore::IDBGetAllResult::allBlobFilePaths const):

  • Modules/indexeddb/server/MemoryIndex.cpp:

(WebCore::IDBServer::MemoryIndex::notifyCursorsOfValueChange):
(WebCore::IDBServer::MemoryIndex::notifyCursorsOfAllRecordsChanged):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):

  • dom/Document.cpp:

(WebCore::Document::moveNodeIteratorsToNewDocument):
(WebCore::Document::resume):
(WebCore::Document::didAssociateFormControlsTimerFired):

  • dom/IdTargetObserverRegistry.cpp:

(WebCore::IdTargetObserverRegistry::notifyObserversInternal):

  • dom/MutationObserver.cpp:

(WebCore::MutationObserver::notifyMutationObservers):

  • dom/Node.cpp:

(WebCore::Document::invalidateNodeListAndCollectionCaches):

  • dom/RadioButtonGroups.cpp:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::dispatchMessagePortEvents):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
(WebCore::ApplicationCacheGroup::deliverDelayedMainResources):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::forEachResource):
(WebCore::MemoryCache::pruneDeadResourcesToSize):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::willDestroyCachedFrame):
(WebCore::DOMWindow::willDestroyDocumentInFrame):
(WebCore::DOMWindow::willDetachDocumentFromFrame):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::reconnectDOMWindowProperties):

  • page/FrameView.cpp:

(WebCore::collectAndProtectWidgets):

  • page/MemoryRelease.cpp:

(WebCore::releaseCriticalMemory):

  • page/Performance.cpp:

(WebCore::Performance::queueEntry):

  • platform/cocoa/PasteboardCocoa.mm:

(WebCore::Pasteboard::typesForLegacyUnsafeBindings):

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::systemFontFamilies):

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):

  • platform/ios/WebCoreMotionManager.mm:

(-[WebCoreMotionManager sendAccelerometerData:]):
(-[WebCoreMotionManager sendMotionData:withHeading:]):

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):

  • platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSession invalidateAndCancel]):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::endAndCommitUpdateScrollInfoAfterLayoutTransaction):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintObject):

Replace out-parameter based copyToVector, with one that returns a Vector.

Source/WebKit:

  • Shared/API/Cocoa/_WKRemoteObjectInterface.mm:

(-[_WKRemoteObjectInterface debugDescription]):

  • Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::dump):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):

  • UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::parameters):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::pendingCookies const):

  • UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager _notifyClientsOfImminentSuspension]):

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::getHostnamesWithCookies):

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::internallyFailedLoadTimerFired):

Replace out-parameter based copyToVector, with one that returns a Vector.

Source/WebKitLegacy/ios:

  • Misc/WebGeolocationProviderIOS.mm:

(-[WebGeolocationProviderIOS _handlePendingInitialPosition:]):
(-[WebGeolocationProviderIOS positionChanged:]):
(-[WebGeolocationProviderIOS errorOccurred:]):
(-[WebGeolocationProviderIOS resetGeolocation]):

Replace out-parameter based copyToVector, with one that returns a Vector.

Source/WebKitLegacy/mac:

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView destroyPlugin]):

  • WebView/WebHTMLRepresentation.mm:

(newArrayWithStrings):

Replace out-parameter based copyToVector, with one that returns a Vector.

Source/WTF:

  • wtf/HashMap.h:

(WTF::copyToVector): Deleted.

  • wtf/HashSet.h:

(WTF::copyToVector): Deleted.

Remove copyToVector.


  • wtf/Vector.h:

(WTF::copyToVectorSpecialization):

Add another version of copyToVector, called copyToVectorSpecialization, that allows
you to specify the entire specialization for the Vector you want to copy to. This
can be useful if you want your resulting Vector to have an inline capacity.

Tools:

  • DumpRenderTree/JavaScriptThreading.cpp:

(stopJavaScriptThreads):

6:12 AM Changeset in webkit [223237] by Yusuke Suzuki
  • 31 edits
    1 copy
    18 adds in trunk

Support integrity="" on module scripts
https://bugs.webkit.org/show_bug.cgi?id=177959

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This patch adds Subresource Integrity check for module scripts. Currently,
only top-level module can be verified with integrity parameter since there
is no way to perform integrity check onto the imported modules.

In JSC side, we add parameters to the entry point of the module loader
pipeline. This is fetching parameters and used when fetching modules.

We separately pass this parameters to the pipeline along with the script fetcher.
The script fetcher is only one for module graph since this is the initiator of
this module graph loading. On the other hand, this parameters is for each
module fetching. While setting "integrity" parameters to this script fetcher is
sufficient to pass parameters to top-level-module's fetching, it is not enough
for the future extension.

In the future, we will investigate a way to pass parameters to each non-top-level
module. At that time, this parameters should be per-module. This is because
"integrity" value should be different for each module. For example, we will accept
some form of syntax to add parameters to import. Some proposed syntax is like
https://discourse.wicg.io/t/specifying-nonce-or-integrity-when-importing-modules/1861

import "./xxx.js" integrity "xxxxxxx"

In this case, this parameters will be passed to "./xxx.js" module fetching. This
parameters should be different from the one of top-level-module's one. That's why
we need per-module parameters and why this patch adds parameters to the module pipeline.

On the other hand, we also want to keep script fetcher. This per-module-graph thing
is important to offer module-graph-wide information. For example, import.meta would
have import.meta.scriptElement, which is the script element fetching the module graph
including this. So, we keep the both, script fetcher and parameters.
https://github.com/tc39/proposal-import-meta

This parameters will be finally used by pipeline's fetch hook, and WebCore side
can use this parameters to fetch modules.

We also further clean up the module pipeline by dropping unnecessary features.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • builtins/ModuleLoaderPrototype.js:

(requestFetch):
(requestInstantiate):
(requestSatisfy):
(loadModule):
(loadAndEvaluateModule):
This loadAndEvaluateModule should be implemented by just calling loadModule and
linkAndEvaluateModule. We can drop requestReady and requestLink.

(requestLink): Deleted.
(requestImportModule): Deleted.

  • jsc.cpp:

(GlobalObject::moduleLoaderImportModule):
(GlobalObject::moduleLoaderFetch):
import and fetch hook takes parameters. Currently, we always pass undefined for
import hook. When dynamic import() is extended to accept additional parameters
like integrity, this parameters will be replaced with the actual value.

(functionLoadModule):
(runWithOptions):

  • runtime/Completion.cpp:

(JSC::loadAndEvaluateModule):
(JSC::loadModule):
(JSC::importModule):

  • runtime/Completion.h:
  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncImportModule):

  • runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::loadAndEvaluateModule):
(JSC::JSModuleLoader::loadModule):
(JSC::JSModuleLoader::requestImportModule):
(JSC::JSModuleLoader::importModule):
(JSC::JSModuleLoader::fetch):

  • runtime/JSModuleLoader.h:
  • runtime/JSScriptFetchParameters.cpp: Added.

(JSC::JSScriptFetchParameters::destroy):

  • runtime/JSScriptFetchParameters.h: Added.

(JSC::JSScriptFetchParameters::createStructure):
(JSC::JSScriptFetchParameters::create):
(JSC::JSScriptFetchParameters::parameters const):
(JSC::JSScriptFetchParameters::JSScriptFetchParameters):
Add ScriptFetchParameters' JSCell wrapper, JSScriptFetchParameters.
It is used in the module pipeline.

  • runtime/JSType.h:
  • runtime/ModuleLoaderPrototype.cpp:

(JSC::moduleLoaderPrototypeFetch):

  • runtime/ScriptFetchParameters.h: Added.

(JSC::ScriptFetchParameters::~ScriptFetchParameters):
Add ScriptFetchParameters. We can define our own custom ScriptFetchParameters
by inheriting this class. WebCore creates ModuleFetchParameters by inheriting
this.

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WebCore:

This patch extends module hooks to accept fetching parameters.
When starting fetching modules, WebCore creates ModuleFetchParameters.
And this parameters is propagated to the fetch hook. Then, fetch
hook can use this parameters to fetch modules.

This parameters only contains integrity field. This "integrity" is
used to perform subresource integrity check in module loader pipeline.
And this error is just proparaged as errors in module pipeline, which
is the same to the other types of errors in module pipeline.

Test: http/tests/subresource-integrity/sri-module.html

  • ForwardingHeaders/runtime/JSScriptFetchParameters.h: Added.
  • ForwardingHeaders/runtime/ScriptFetchParameters.h: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/CachedModuleScriptLoader.cpp:

(WebCore::CachedModuleScriptLoader::create):
(WebCore::CachedModuleScriptLoader::CachedModuleScriptLoader):
Take parameters, which includes "integrity".

  • bindings/js/CachedModuleScriptLoader.h:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::moduleLoaderFetch):
(WebCore::JSDOMWindowBase::moduleLoaderImportModule):
import and fetch hooks take parameters.

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::loadModule):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::loadModuleScriptInWorld):
(WebCore::ScriptController::loadModuleScript):
Pass parameters to the entry point of the module pipeline.

  • bindings/js/ScriptController.h:
  • bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::fetch):
If parameters are passed, we set them to CachedModuleScriptLoader.

(WebCore::ScriptModuleLoader::importModule):
Pass parameters to the entry point of dynamic import.

(WebCore::ScriptModuleLoader::notifyFinished):
If script loader has parameters, we perform subresource integrity check here.

  • bindings/js/ScriptModuleLoader.h:
  • dom/LoadableModuleScript.cpp:

(WebCore::LoadableModuleScript::create):
(WebCore::LoadableModuleScript::LoadableModuleScript):
(WebCore::LoadableModuleScript::load):
Create ModuleFetchParameters with "integrity" value.

  • dom/LoadableModuleScript.h:
  • dom/ModuleFetchParameters.h: Copied from Source/WebCore/bindings/js/CachedModuleScriptLoader.h.

(WebCore::ModuleFetchParameters::create):
(WebCore::ModuleFetchParameters::integrity const):
(WebCore::ModuleFetchParameters::ModuleFetchParameters):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestModuleScript):
Pass "integrity" value to the module script.

LayoutTests:

  • http/tests/subresource-integrity/resources/crossorigin-anon-script-module.js: Added.
  • http/tests/subresource-integrity/resources/crossorigin-creds-script-module.js: Added.
  • http/tests/subresource-integrity/resources/crossorigin-ineligible-script-module.js: Added.
  • http/tests/subresource-integrity/resources/matching-digest-module.js: Added.
  • http/tests/subresource-integrity/resources/non-matching-digest-module.js: Added.
  • http/tests/subresource-integrity/resources/sri-utilities.js:

(add_result_callback):
(SRIModuleTest):
(SRIModuleTest.prototype.execute):

  • http/tests/subresource-integrity/sri-module-expected.txt: Added.
  • http/tests/subresource-integrity/sri-module.html: Added.
  • js/dom/modules/module-inline-ignore-integrity-expected.txt: Added.
  • js/dom/modules/module-inline-ignore-integrity.html: Added.
  • js/dom/modules/module-integrity-non-top-level-expected.txt: Added.
  • js/dom/modules/module-integrity-non-top-level.html: Added.
  • js/dom/modules/script-tests/module-integrity-non-top-level-2.js: Added.
  • js/dom/modules/script-tests/module-integrity-non-top-level.js: Added.
5:45 AM Changeset in webkit [223236] by commit-queue@webkit.org
  • 4 edits in trunk

It should be possible to iterate just the values (and not the counts) of a HashCountedSet
https://bugs.webkit.org/show_bug.cgi?id=178169

Patch by Sam Weinig <sam@webkit.org> on 2017-10-12
Reviewed by Daniel Bates.

Source/WTF:

Cleanup (fix indentation, simplify type names, adopt using), and add a values() range to
HashCountedSet. This will allow getting a Vector of all the values (and not the counts)
using the new copyToVector.

  • wtf/HashCountedSet.h:

Tools:

  • TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:

(TestWebKitAPI::TEST):
Add test for HashCountedSet's new values() range.

4:58 AM Changeset in webkit [223235] by tpopela@redhat.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix compilation warning

warning: extra tokens at end of #endif directive [-Wendif-labels]

  • rendering/RenderMediaControls.h:
1:37 AM Changeset in webkit [223234] by fred.wang@free.fr
  • 3 edits in trunk/Tools

run-safari --ios-simulator is no longer working with Xcode 9
https://bugs.webkit.org/show_bug.cgi?id=177595

Patch by Frederic Wang <fwang@igalia.com> on 2017-10-11
Reviewed by Daniel Bates.

In Xcode 9, the path of the simulator application is now in a new CoreSimulator subdirectory
of the iphoneOS SDK platform. This patch updates webkitdirs.pm to use the new path in
Xcode 9 or higher so that it is possible to run Safari on the iOS simulator again. It also
does some minor code refactoring to improve code reuse.

  • Scripts/configure-xcode-for-ios-development: Move sdkDirectory() and sdkPlatformDirectory()

into webkitdirs.
(sdkDirectory): Deleted.
(sdkPlatformDirectory): Deleted.

  • Scripts/webkitdirs.pm: Expose new sdkDirectory() and sdkPlatformDirectory().

(sdkDirectory): Moved from configure-xcode-for-ios-development.
(sdkPlatformDirectory): Ditto.
(XcodeSDKPath): Rely on sdkDirectory() to implement this function.
(iosSimulatorApplicationsPath): In Xcode 9 or higher use the new path. It is calculated
by relying on sdkPlatformDirectory().

Oct 11, 2017:

11:46 PM Changeset in webkit [223233] by jmarcell@apple.com
  • 5 edits in tags/Safari-605.1.10/Source/WebCore

Cherry-pick r223212. rdar://problem/33667497

11:45 PM Changeset in webkit [223232] by Yusuke Suzuki
  • 9 edits
    1 add in trunk

import.meta should not be assignable
https://bugs.webkit.org/show_bug.cgi?id=178202

Reviewed by Saam Barati.

JSTests:

  • modules/import-meta-assignment.js: Added.

(shouldThrow):
(SyntaxError.import.meta.can.shouldThrow):

Source/JavaScriptCore:

import.meta cannot be used for LHS. This patch adds MetaPropertyNode
and make NewTargetNode and ImportMetaNode as derived classes of MetaPropertyNode.
We change the parser not to allow assignments for MetaPropertyNode.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ImportMetaNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createImportMetaExpr):
(JSC::ASTBuilder::isMetaProperty):
(JSC::ASTBuilder::isImportMeta):

  • parser/NodeConstructors.h:

(JSC::MetaPropertyNode::MetaPropertyNode):
(JSC::NewTargetNode::NewTargetNode):
(JSC::ImportMetaNode::ImportMetaNode):

  • parser/Nodes.h:

(JSC::ExpressionNode::isMetaProperty const):
(JSC::ExpressionNode::isImportMeta const):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::metaPropertyName):
(JSC::Parser<LexerType>::parseAssignmentExpression):
(JSC::Parser<LexerType>::parseMemberExpression):
(JSC::Parser<LexerType>::parseUnaryExpression):

  • parser/Parser.h:
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createImportMetaExpr):
(JSC::SyntaxChecker::isMetaProperty):
(JSC::SyntaxChecker::isImportMeta):

11:15 PM Changeset in webkit [223231] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.10

Tag Safari-605.1.10.

10:20 PM October 2017 Meeting edited by mjs@apple.com
(diff)
9:31 PM Changeset in webkit [223230] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebKit

Fix debug build

Unreviewed.

Add ENABLE(SERVICE_WORKER) guard.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createWebPage):

9:24 PM Changeset in webkit [223229] by jmarcell@apple.com
  • 6 edits
    1 copy
    1 add in branches/safari-604-branch/Source/WebKit

Apply patch. rdar://problem/34920294

8:01 PM Changeset in webkit [223228] by Brent Fulgham
  • 7 edits in trunk/Source/WebCore

Correct nullptr deref in selection handling.
https://bugs.webkit.org/show_bug.cgi?id=178189
<rdar://problem/33833012>

Reviewed by Ryosuke Niwa.

The VisibleSelection::toNormalizedRange returns nullptr for certain conditions (e.g., 'isNone'
and 'isOrphaned' cases). It's possible to crash the WebProcess by executing a code path with
an orphaned selection range.

The return value of 'toNormalizedRange' is checked for nullptr in many places, but not everywhere.
This patch adds those missing nullptr checks.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper textMarkerRangeForSelection]):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::styleAtSelectionStart):

  • editing/Editor.cpp:

(WebCore::Editor::misspelledWordAtCaretOrRange const):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::containsNode const):

  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

6:35 PM Changeset in webkit [223227] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark http/tests/cache-storage/cache-clearing.https.html as failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=178200

Unreviewed test gardening.

  • platform/win/TestExpectations:
6:15 PM Changeset in webkit [223226] by Dewei Zhu
  • 3 edits in trunk/Tools

run-benchmark script should set 'XPC_DYLD_FRAMEWORK_PATH' while launching local-built Safari on Mac.
https://bugs.webkit.org/show_bug.cgi?id=178199

Reviewed by Saam Barati.

'XPC_DYLD_FRAMEWORK_PATH' should be set while launching Safari on run-benchmark script.
'force_remove' function should support both file and directory.

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:

(OSXSafariDriver.launch_url):

  • Scripts/webkitpy/benchmark_runner/utils.py:

(force_remove):

6:13 PM Changeset in webkit [223225] by jmarcell@apple.com
  • 7 edits in trunk/Source

Versioning.

6:06 PM Changeset in webkit [223224] by jmarcell@apple.com
  • 7 edits in branches/safari-604.3.5.0-branch/Source

Versioning.

6:03 PM Changeset in webkit [223223] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

5:53 PM Changeset in webkit [223222] by sbarati@apple.com
  • 5 edits in trunk

Runtime disable poly proto because it may be a 3-4% Speedometer regression
https://bugs.webkit.org/show_bug.cgi?id=178192

Reviewed by JF Bastien.

Source/JavaScriptCore:

  • runtime/Options.h:
  • runtime/StructureInlines.h:

(JSC::Structure::shouldConvertToPolyProto):

Tools:

  • Scripts/run-jsc-stress-tests:
5:47 PM Changeset in webkit [223221] by Ryan Haddad
  • 7 edits in trunk

Unreviewed, rolling out r223215.

This change broke the Sierra build.

Reverted changeset:

"[Apple Pay] Add subLocality and subAdministrativeArea to
ApplePayPaymentContact"
https://bugs.webkit.org/show_bug.cgi?id=178191
https://trac.webkit.org/changeset/223215

5:46 PM Changeset in webkit [223220] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Add API to clean CacheStorage data
https://bugs.webkit.org/show_bug.cgi?id=178034

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-11

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::fetchWebsiteData): Fixing lifetime of aggregator.

5:33 PM Changeset in webkit [223219] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

[JSC] Add ability to build with ARMV8 ILP32 ABI
https://bugs.webkit.org/show_bug.cgi?id=178194

Reviewed by Saam Barati.

For ARMV8 32 bit ABI, use JSVALUE32_64 and the CLOOP.

  • wtf/Platform.h:
5:33 PM Changeset in webkit [223218] by Ryan Haddad
  • 1 edit
    1 add in trunk/LayoutTests

Rebaseline fast/scrolling/adjust-scroll-offset-on-zoom.html for iOS.

Unreviewed test gardening.

  • platform/ios/fast/scrolling/adjust-scroll-offset-on-zoom-expected.txt: Added.
5:27 PM Changeset in webkit [223217] by Chris Dumez
  • 7 edits
    4 deletes in trunk

XMLHttpRequest: do not sniff text/html, and do not sniff XML when responseType is set to "text"
https://bugs.webkit.org/show_bug.cgi?id=168724

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline web-platform-tests now that all checks are passing.

  • web-platform-tests/XMLHttpRequest/responsetext-decoding-expected.txt:

Source/WebCore:

WebKit enabled HTML / XML charset detection for HTML-ish / XML-ish
responses even when response type is text, which does not match the
specification.

This patch is based on the following Blink patch by Yutaka Hirano <yhirano@chromium.org>:

Tests:
imported/w3c/web-platform-tests/XMLHttpRequest/responsetext-decoding.htm
imported/w3c/web-platform-tests/XMLHttpRequest/responsedocument-decoding.htm

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createDecoder const):
(WebCore::XMLHttpRequest::didReceiveData):

  • xml/XMLHttpRequest.h:

LayoutTests:

Drop outdated test, proper behavior is covered by web-platform-tests.

  • fast/xmlhttprequest/xmlhttprequest-html-response-encoding-expected.txt: Removed.
  • fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html: Removed.
5:17 PM Changeset in webkit [223216] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/XMLHttpRequest/open-url-worker-origin.htm as flaky.
https://bugs.webkit.org/show_bug.cgi?id=178190

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:14 PM Changeset in webkit [223215] by aestes@apple.com
  • 7 edits in trunk

[Apple Pay] Add subLocality and subAdministrativeArea to ApplePayPaymentContact
https://bugs.webkit.org/show_bug.cgi?id=178191
<rdar://problem/34906367>

Reviewed by Tim Horton.

Source/WebCore:

Added test cases to http/tests/ssl/applepay/ApplePaySession.html.

  • Modules/applepay/ApplePayPaymentContact.h:
  • Modules/applepay/ApplePayPaymentContact.idl:
  • Modules/applepay/cocoa/PaymentContactCocoa.mm:

(WebCore::convert):

LayoutTests:

  • http/tests/ssl/applepay/ApplePaySession-expected.txt:
  • http/tests/ssl/applepay/ApplePaySession.html:
5:00 PM Changeset in webkit [223214] by sbarati@apple.com
  • 4 edits in trunk/JSTests

Unreviewed. Actually skip certain type profiler tests in debug.

  • typeProfiler.yaml:
  • typeProfiler/deltablue-for-of.js:
  • typeProfiler/getter-richards.js:
5:00 PM October 2017 Meeting edited by rniwa@webkit.org
Make Maciej the speaker of feature focus talk, and swap the time slot … (diff)
4:55 PM Changeset in webkit [223213] by commit-queue@webkit.org
  • 26 edits
    1 copy
    2 adds in trunk

Add API to clean CacheStorage data
https://bugs.webkit.org/show_bug.cgi?id=178034

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-11
Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/cache-storage/cache-clearing.https.html

  • platform/FileSystem.h:

Source/WebKit:

Introducing a new website data type for DOMCache.
Adding API to delete DOMCache for a given origin or for all origins.
This is added to WKWebsiteDataStore.

Cleaning a CacheStorage will remove all data in the Cache object but the object will stay live
for the duration of the NetworkProcess.
This allows ensuring that once a cache is cleaned, WebProcess will update to this new state.

Fetching of WebsiteData for DOMCache is not implemented yet since we do not keep a list of all origins for which we have data.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::fetchDOMCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::cachesRootPath):
(WebKit::CacheStorage::Engine::fetchEntries):
(WebKit::CacheStorage::ClearTasksHandler::ClearTasksHandler):
(WebKit::CacheStorage::ClearTasksHandler::~ClearTasksHandler):
(WebKit::CacheStorage::Engine::clearEngines):
(WebKit::CacheStorage::Engine::clearCachesForOrigins):
(WebKit::CacheStorage::Engine::readCachesFromDisk):
(WebKit::CacheStorage::deleteFolder):
(WebKit::CacheStorage::Engine::clearCaches):
(WebKit::CacheStorage::Engine::unlock): Removing the assertion as Cache objects are removed when clearing data.

  • NetworkProcess/cache/CacheStorageEngine.h:
  • NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::Caches):
(WebKit::CacheStorage::Caches::clear):

  • NetworkProcess/cache/CacheStorageEngineCaches.h:

(WebKit::CacheStorage::Caches::create):

  • Shared/WebsiteData/WebsiteDataType.h:
  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreRemoveAllDOMCaches):
(WKWebsiteDataStoreRemoveDOMCacheForOrigin):

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:

(dataTypesToString):

  • UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:

(WebKit::toWebsiteDataType):
(WebKit::toWKWebsiteDataTypes):

  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore allWebsiteDataTypes]):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::computeNetworkProcessAccessTypeForDataFetch):
(WebKit::computeNetworkProcessAccessTypeForDataRemoval):

Source/WTF:

Moving CallbackAggregator pattern into its own class for easier reuse.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CallbackAggregator.h: Added.

(WTF::CallbackAggregator::create):
(WTF::CallbackAggregator::~CallbackAggregator):
(WTF::CallbackAggregator::CallbackAggregator):

Tools:

Adding internals API to trigger deleting all or origin-persistent cache storage persistent data.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::clearDOMCache):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::clearDOMCache):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

  • http/tests/cache-storage/cache-clearing.https-expected.txt: Added.
  • http/tests/cache-storage/cache-clearing.https.html: Added.
4:26 PM Changeset in webkit [223212] by ddkilzer@apple.com
  • 5 edits in trunk/Source/WebCore

Part 2: Fix -Wcast-qual and -Wunused-lambda-capture warnings in WebCore with new clang compiler
<https://webkit.org/b/178036>
<rdar://problem/33667497>

Reviewed by Chris Dumez.

  • Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::WorkerCacheStorageConnection::doRemove):

  • Change ASSERT() to ASSERT_UNUSED() to suppress warnings about unused lambda capture for 'cacheIdentifier' in Release builds.
  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::classForIsA): Change C-style cast
into reinterpret_cast and const_cast to go from CFTypeRef to
ObjcClass*.

  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::castDataArgumentToCCRSACryptorCreateFromDataIfNeeded):
Add. Introduce method to add a required const_cast for older
OSes since the signature of CCRSACryptorCreateFromData() changed
in iOS 11 & High Sierra.
(WebCore::CryptoKeyRSA::create): Use
castDataArgumentToCCRSACryptorCreateFromDataIfNeeded().

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):
Remove unused lambda capture for 'status'.

3:21 PM Changeset in webkit [223211] by Chris Dumez
  • 25 edits
    2 adds in trunk

[Geolocation] Expose Coordinates.floorLevel
https://bugs.webkit.org/show_bug.cgi?id=178173
<rdar://problem/34918936>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Expose Coordinates.floorLevel via the Geolocation API. This is currently
a WebKit-specific extension and it is only populated on iOS / WKTR / DRT.
It is null on other platforms.

Test: fast/dom/Geolocation/floorLevel.html

  • Modules/geolocation/Coordinates.h:

(WebCore::Coordinates::floorLevel const):

  • Modules/geolocation/Coordinates.idl:
  • Modules/geolocation/GeolocationPosition.h:

(WebCore::GeolocationPosition::encode const):
(WebCore::GeolocationPosition::decode):

  • Modules/geolocation/ios/GeolocationPositionIOS.mm:

(WebCore::GeolocationPosition::GeolocationPosition):

  • page/Settings.in:

Source/WebKit:

  • UIProcess/API/C/WKGeolocationPosition.cpp:

(WKGeolocationPositionCreate):
(WKGeolocationPositionCreate_b):
(WKGeolocationPositionCreate_c):

  • UIProcess/API/C/WKGeolocationPosition.h:

Tools:

Add test infrastructure for testing Coordinates.floorLevel.

  • DumpRenderTree/TestRunner.cpp:

(setMockGeolocationPositionCallback):

  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setMockGeolocationPosition):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setMockGeolocationPosition):

  • WebKitTestRunner/GeolocationProviderMock.cpp:

(WTR::GeolocationProviderMock::setPosition):

  • WebKitTestRunner/GeolocationProviderMock.h:
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::setMockGeolocationPosition):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setMockGeolocationPosition):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::setMockGeolocationPosition):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Add layout test coverage.

  • fast/dom/Geolocation/floorLevel-expected.txt: Added.
  • fast/dom/Geolocation/floorLevel.html: Added.
2:33 PM Changeset in webkit [223210] by Simon Fraser
  • 5 edits
    2 adds in trunk

Avoid triggering layout from style change
https://bugs.webkit.org/show_bug.cgi?id=178184
Source/WebCore:

rdar://problem/34699113

Reviewed by Zalan Bujtas.

It's bad for RenderBox::styleDidChange() to scroll RenderLayers, because that
can trigger layout via FrameView::updateWidgetPositions() and ScrollingCoordinator::absoluteEventTrackingRegions().
So postpone the scrolling until after layout.

Test: fast/scrolling/adjust-scroll-offset-on-zoom.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::setPostLayoutScrollPosition):
(WebCore::RenderLayer::applyPostLayoutScrollPositionIfNeeded):

  • rendering/RenderLayer.h:

LayoutTests:

Reviewed by Zalan Bujtas.

  • fast/scrolling/adjust-scroll-offset-on-zoom-expected.txt: Added.
  • fast/scrolling/adjust-scroll-offset-on-zoom.html: Added.
1:54 PM Changeset in webkit [223209] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Make 3D objects selectable in Layers visualization
https://bugs.webkit.org/show_bug.cgi?id=178136

Patch by Ross Kirsling <Ross Kirsling> on 2017-10-11
Reviewed by Devin Rousso.

  • UserInterface/Views/Layers3DContentView.js:

(WI.Layers3DContentView):
(WI.Layers3DContentView.prototype.initialLayout):
(WI.Layers3DContentView.prototype._canvasMouseDown):
(WI.Layers3DContentView.prototype._updateLayerGroupSelection):
Implement selection of 3D layer objects.

(WI.Layers3DContentView.prototype._addLayerGroup): Renamed from _addLayer.
(WI.Layers3DContentView.prototype._updateLayerGroupPosition):
(WI.Layers3DContentView.prototype._createLayerMesh):
Refactor -- one group per layer (visible plane and composited outline), not groups by shape.

(WI.Layers3DContentView.prototype.layout):
(WI.Layers3DContentView.prototype._updateLayers):
(WI.Layers3DContentView.prototype._clearLayers): Deleted.
Don't destroy all 3D objects on every LayerTreeDidChange; make use of layerTreeMutations.
(Not only a performance improvement, but also necessary to properly preserve highlighting.)

(WI.Layers3DContentView.prototype.selectLayerById):
Allow selection to be updated from the outside.

  • UserInterface/Views/LayerDetailsSidebarPanel.js:

(WI.LayerDetailsSidebarPanel.prototype.selectNodeByLayerId):
(WI.LayerDetailsSidebarPanel.prototype._buildDataGrid):
(WI.LayerDetailsSidebarPanel.prototype._dataGridSelectedNodeChanged):
Allow selection to be updated from the outside.

(WI.LayerDetailsSidebarPanel.prototype.inspect):
(WI.LayerDetailsSidebarPanel.prototype._updateLayers): Renamed from _updateDisplayWithLayers.
(WI.LayerDetailsSidebarPanel.prototype._updateDataGrid):
(WI.LayerDetailsSidebarPanel.prototype._updateBottomBar):
(WI.LayerDetailsSidebarPanel.prototype._contentForPopover):
(WI.LayerDetailsSidebarPanel.prototype._dataGridNodeForLayer): Deleted.
Cleanup.

  • UserInterface/Views/LayersTabContentView.js:

(WI.LayersTabContentView):
(WI.LayersTabContentView.prototype._detailsSidebarSelectedLayerChanged):
(WI.LayersTabContentView.prototype._contentViewSelectedLayerChanged):
Orchestrate communication of selection state between visualization and sidebar.

1:43 PM Changeset in webkit [223208] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.4.1

Tag Safari-604.4.1.

1:41 PM Changeset in webkit [223207] by commit-queue@webkit.org
  • 21 edits in trunk

Bump default cache storage quota to 20MB
https://bugs.webkit.org/show_bug.cgi?id=178132

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-11
Reviewed by Alex Christensen.

Source/WebCore:

Covered by http/wpt/cache-storage/cache-quota.any.html.

  • platform/network/NetworkStorageSession.h:

(WebCore::NetworkStorageSession::cacheStoragePerOriginQuota const):
(WebCore::NetworkStorageSession::setCacheStoragePerOriginQuota):

Source/WebKit:

Adding the ability to set the quota per origin through WebsiteDataStore.
Moving cache storage directory setting also in WebsiteDataStore.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::ensureLegacyPrivateBrowsingSession):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

  • Shared/WebsiteDataStoreParameters.cpp:

(WebKit::WebsiteDataStoreParameters::encode const):
(WebKit::WebsiteDataStoreParameters::decode):

  • Shared/WebsiteDataStoreParameters.h:
  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::createWithLegacyOptions):
(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration):
(API::ProcessPoolConfiguration::ProcessPoolConfiguration):
(API::ProcessPoolConfiguration::copy):

  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/C/WKContextConfigurationRef.cpp:
  • UIProcess/API/C/WKContextConfigurationRef.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _cacheStoragePerOriginQuota]):
(-[WKWebsiteDataStore _setCacheStoragePerOriginQuota:]):
(-[WKWebsiteDataStore _cacheStorageDirectory]):
(-[WKWebsiteDataStore _setCacheStorageDirectory:]):

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:
  • UIProcess/WebProcessPool.cpp:

(WebKit::legacyWebsiteDataStoreConfiguration):
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::setAnyPageGroupMightHavePrivateBrowsingEnabled):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::cacheStoragePerOriginQuota const):
(WebKit::WebsiteDataStore::setCacheStoragePerOriginQuota):
(WebKit::WebsiteDataStore::cacheStorageDirectory const):
(WebKit::WebsiteDataStore::setCacheStorageDirectory):

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::generateContextConfiguration const):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration): Setting quota to 400kb

1:30 PM Changeset in webkit [223206] by mmaxfield@apple.com
  • 13 edits
    4 copies
    1 move
    1 add in trunk/Source

Allow PAL to log messages
https://bugs.webkit.org/show_bug.cgi?id=171523

Reviewed by Alex Christensen.

Source/WebCore:

Make the model of WebCore/PAL match the model of WebKit/WebCore. This is because PAL will
need to log things (because existing files in WebCore/platform need to log things).

No new tests because there is no behavior change.

  • WebCore.xcodeproj/project.pbxproj:
  • page/mac/PageMac.mm:

(WebCore::Page::platformInitialize):

  • platform/Logging.cpp:

(WebCore::registerNotifyCallback): Deleted.

  • platform/Logging.h:
  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForWithReason):

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/CMakeLists.txt:
  • pal/LogInitialization.h: Copied from Source/WebCore/platform/LogMacros.h.
  • pal/LogMacros.h: Copied from Source/WebCore/platform/LogMacros.h.
  • pal/Logging.cpp: Copied from Source/WebCore/platform/Logging.cpp.

(PAL::isLogChannelEnabled):
(PAL::setLogChannelToAccumulate):
(PAL::initializeLogChannelsIfNecessary):
(PAL::registerNotifyCallback):

  • pal/Logging.h: Copied from Source/WebCore/platform/LogMacros.h.
  • pal/PlatformMac.cmake:
  • pal/cocoa/LoggingCocoa.mm: Renamed from Source/WebCore/platform/LogMacros.h.

(PAL::logLevelString):

Source/WebKit:

  • Platform/Logging.h:
  • Scripts/generate-forwarding-headers.pl:
1:21 PM October 2017 Meeting edited by Jon Davis
(diff)
1:20 PM October 2017 Meeting edited by Jon Davis
(diff)
1:16 PM Changeset in webkit [223205] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix build with some SDKs.

Stop capturing |this| unnecessarily in lambda.

  • Modules/entriesapi/FileSystemDirectoryEntry.cpp:

(WebCore::FileSystemDirectoryEntry::getEntry):

12:51 PM Changeset in webkit [223204] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix build with some SDKs.

Stop capturing |this| unnecessarily in lambda.

  • Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::getFile):

12:40 PM Changeset in webkit [223203] by Chris Dumez
  • 4 edits
    28 adds in trunk/LayoutTests/imported/w3c

Re-sync XMLHttpRequests Web-Platform-Tests
https://bugs.webkit.org/show_bug.cgi?id=178172

Reviewed by Youenn Fablet.

Re-sync XMLHttpRequests Web-Platform-Tests from upstream 2f76ef2c1d.

  • resources/import-expectations.json:
  • web-platform-tests/XMLHttpRequest/abort-after-stop-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/abort-after-stop.htm: Added.
  • web-platform-tests/XMLHttpRequest/event-error-order.sub-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/event-error-order.sub.html: Added.
  • web-platform-tests/XMLHttpRequest/event-timeout-order-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/event-timeout-order.htm: Added.
  • web-platform-tests/XMLHttpRequest/open-url-worker-origin-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/open-url-worker-origin.htm: Added.
  • web-platform-tests/XMLHttpRequest/preserve-ua-header-on-redirect-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/preserve-ua-header-on-redirect.htm: Added.
  • web-platform-tests/XMLHttpRequest/responsedocument-decoding-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/responsedocument-decoding.htm: Added.
  • web-platform-tests/XMLHttpRequest/responsetext-decoding-expected.txt:
  • web-platform-tests/XMLHttpRequest/responsetext-decoding.htm:
  • web-platform-tests/XMLHttpRequest/send-after-setting-document-domain-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/send-after-setting-document-domain.htm: Added.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-cors-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-cors-not-enabled-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-cors-not-enabled.htm: Added.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-cors.htm: Added.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-repeat-no-args-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-repeat-no-args.htm: Added.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-setrequestheader-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic-setrequestheader.htm: Added.
  • web-platform-tests/XMLHttpRequest/send-authentication-basic.htm: Added.
  • web-platform-tests/XMLHttpRequest/send-authentication-competing-names-passwords-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/send-authentication-competing-names-passwords.htm: Added.
  • web-platform-tests/XMLHttpRequest/send-entity-body-basic-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/send-entity-body-basic.htm: Added.
  • web-platform-tests/XMLHttpRequest/send-network-error-async-events.sub-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/send-network-error-async-events.sub.htm: Added.
  • web-platform-tests/XMLHttpRequest/w3c-import.log:
12:33 PM Changeset in webkit [223202] by commit-queue@webkit.org
  • 22 edits
    6 deletes in trunk

Unreviewed, rolling out r223113 and r223121.
https://bugs.webkit.org/show_bug.cgi?id=178182

Reintroduced 20% regression on Kraken (Requested by rniwa on
#webkit).

Reverted changesets:

"Enable gigacage on iOS"
https://bugs.webkit.org/show_bug.cgi?id=177586
https://trac.webkit.org/changeset/223113

"Use one virtual allocation for all gigacages and their
runways"
https://bugs.webkit.org/show_bug.cgi?id=178050
https://trac.webkit.org/changeset/223121

12:24 PM Changeset in webkit [223201] by msaboff@apple.com
  • 2 edits in trunk/JSTests

Disable test262 named capture group tests with direct unicode names and with references before definitions
https://bugs.webkit.org/show_bug.cgi?id=178177

Reviewed by Keith Miller.

Bugs to track fixing these test are:
https://bugs.webkit.org/show_bug.cgi?id=178174 -

"Add support in named capture group identifiers for direct surrogate pairs"

https://bugs.webkit.org/show_bug.cgi?id=178175 -

"Test262 failure with Named Capture Groups - using a reference before the group is defined"

  • test262.yaml:
12:23 PM Changeset in webkit [223200] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.3.5.0.2

Tag Safari-604.3.5.0.2.

12:19 PM Changeset in webkit [223199] by jmarcell@apple.com
  • 7 edits in branches/safari-604.3.5.0-branch/Source

Versioning.

12:18 PM Changeset in webkit [223198] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

Extract logic to paint composition underlines to its own function
https://bugs.webkit.org/show_bug.cgi?id=178038

Reviewed by Zalan Bujtas.

No functionality changed. So, no new tests.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Modified to call paintCompositionUnderlines().
(WebCore::InlineTextBox::paintCompositionUnderlines const): Added; extract code
from InlineTextBox::paint() and modernized it.
(WebCore::InlineTextBox::paintCompositionUnderline const): Added.
(WebCore::InlineTextBox::paintCompositionUnderline): Deleted; made const.

  • rendering/InlineTextBox.h:
12:13 PM Changeset in webkit [223197] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Update JavaScriptCore/ucd/CaseFolding.txt to Unicode database 10.0
https://bugs.webkit.org/show_bug.cgi?id=178106

Reviewed by Keith Miller.

  • ucd/CaseFolding.txt:
12:13 PM Changeset in webkit [223196] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

InlineTextBox::isSelected() should only return true for a non-empty selection
and remove incorrect FIXME from InlineTextBox::localSelectionRect()
https://bugs.webkit.org/show_bug.cgi?id=160786

Reviewed by Zalan Bujtas.

Partial revert of r204400 in InlineTextBox::{isSelected, localSelectionRect}().

The function InlineTextBox::isSelected() should only return true for a non-empty selection.
Also remove an incorrect FIXME added to InlineTextBox::localSelectionRect() that questioned
whether it was correct for it to return an empty rectangle. It is correct for it to return
such a rectangle because this function is used to implement Element.getClientRects(). And
Element.getClientRects() can return a rectangle with zero width or zero height by step 3
of algorithm getClientRects() of section Extensions to the Element interface of the
CSSOM View Module spec., <https://drafts.csswg.org/cssom-view/> (Editor's Draft, 15 September 2017).

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::isSelected const): Only return true for a non-empty selection
and remove unnecessary FIXME. Also rename variables to improve readability.
(WebCore::InlineTextBox::localSelectionRect const): Remove inaccurate FIXME comment.

  • rendering/InlineTextBox.h:
12:01 PM Changeset in webkit [223195] by rniwa@webkit.org
  • 42 edits
    14 adds in trunk

Sanitize URL in pasteboard for other applications and cross origin content
https://bugs.webkit.org/show_bug.cgi?id=178060
<rdar://problem/34874518>

Reviewed by Wenson Hsieh.

Source/WebCore:

This patch introduces the sanitization of URL when written from a web content to prevent web content from
exploiting the URL parser of other applications in the system particularly of those that actively monitor
system pasteboard (a.k.a. clipboard on non-Cocoa platforms) and decode or otherwise process URLs.

Because the Web compatibility requires that DataTransfer exposes the original URL to any document in the
same origin as the one which wrote the URL into the pasteboard, we store a string which uniquely identifies
the origin of an originating document into our custom pasteboard data. Note that we expose any URL which
didn't come from WebKit since we don't expect URLs to reveal privacy sensitive information. We use UUID for
the origin identifier of a null origin document.

An alternative approach is to store the pasteboard data from the same origin into the document and invalidate
it when the system pasteboard changes. However, Pasteboard object cannot know about Document (as Pasteboard
is a platform object and Document is a WebCore object), this turns out be quite tricky as there are multiple
places where we create Pasteboard objects, and they all need to be aware of this special same origin
Pasteboard object that hangs off of Document. Also, this approach would result in the same origin code paths
to diverge between null origin and non-null origin documents.

Tests: editing/pasteboard/data-transfer-get-data-on-copying-pasting-malformed-url-in-same-document.html

editing/pasteboard/data-transfer-set-data-ignore-copied-walformed-url-in-null-origin.html
editing/pasteboard/data-transfer-set-data-sanitlize-url-when-copying-in-null-origin.html
editing/pasteboard/data-transfer-set-data-sanitlize-url-when-dragging-in-null-origin.html
http/tests/security/clipboard/copy-paste-url-across-origin-sanitizes-url.html
CopyURL.ValidURL
CopyURL.UnescapedURL
CopyURL.MalformedURL
DataInteractionTests.DataTransferSetDataValidURL
DataInteractionTests.DataTransferSetDataUnescapedURL
DataInteractionTests.DataTransferSetDataInvalidURL

  • dom/DataTransfer.cpp:

(WebCore::originForDocument): Extracted from createForCopyAndPaste.
(WebCore::DataTransfer::createForCopyAndPaste):
(WebCore::DataTransfer::getDataForItem const): Read the URL from the custom data when the originating content
is of the same origin. When the originating content is cross origin, or there is no custom data (e.g. written
by another native application; or sanitization didn't result in any difference), then callback to native value.
(WebCore::DataTransfer::setDataFromItemList): Sanitize the URL before writing it to the native pasteboard.
Store the original value if the sanitization resulted in any difference.
(WebCore::DataTransfer::types const):
(WebCore::DataTransfer::commitToPasteboard): Moved the code to write custom data to Pasteboard since we need
to write the origin string with it.
(WebCore::DataTransfer::createForDragStartEvent): Added Document as an argument to compute the origin string.
(WebCore::DataTransfer::createForDrop): Ditto.
(WebCore::DataTransfer::createForUpdatingDropTarget):
(WebCore::DataTransfer::moveDragState):

  • dom/DataTransfer.h:
  • dom/Document.cpp:

(WebCore::Document::uniqueIdentifier): Added. See above.

  • dom/Document.h:
  • editing/Editor.cpp:

(WebCore::createDataTransferForClipboardEvent):
(WebCore::dispatchClipboardEvent):

  • page/DragController.cpp:

(WebCore::DragController::dispatchTextInputEventFor):

  • page/EventHandler.cpp:

(WebCore::EventHandler::performDragAndDrop):
(WebCore::EventHandler::handleDrag):

  • platform/Pasteboard.h:
  • platform/PasteboardStrategy.h:
  • platform/PlatformPasteboard.h:
  • platform/StaticPasteboard.cpp:

(WebCore::StaticPasteboard::takeCustomData): Moved the logic to write to native pasteboard to DataTransfer.

  • platform/StaticPasteboard.h:
  • platform/cocoa/PasteboardCocoa.mm:

(WebCore::Pasteboard::typesSafeForBindings):
(WebCore::Pasteboard::readStringInCustomData): Rewritten using readCustomData. See below.
(WebCore::Pasteboard::readOrigin): Added.
(WebCore::Pasteboard::readCustomData): Added. Populates the cache. Because a single Pasteboard object is never
allowed to read values once its content is updated by other applications, we can permanently cache the result.

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::typesSafeForBindings): Now takes the unused origin string.
(WebCore::Pasteboard::readOrigin): Added.

  • platform/gtk/PlatformPasteboardGtk.cpp:

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const): Now takes the unused origin string.

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::originKeyKeyForTeamData): Added.
(WebCore::customTypesKeyForTeamData): Added. Replaces the use of PasteboardCustomData::cocoaType() in the team
data for clarity since the team data key isn't same as the pasteboard type. We don't have to worry about the
backwards compatibility since drag & drop session doesn't persist across iOS upgrades, and there is no publicly
released iOS with this team data support.
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const): Read the origin string and the custom data
off the team data. Don't expose custom types that are written by cross origin documents.
(WebCore::PlatformPasteboard::write): Add the orign string with custom pasteboard types in the team data.
(WebCore::PlatformPasteboard::readURL): Fixed a bug that this function was not reading NSURL when UIPasteboard
serializes NSURL as a plist. This code is exercised by CopyURL.ValidURL.

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const): Don't add custom pasteboard types that are
added by cross origin documents.

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::typesSafeForBindings): Now takes the unused origin string.
(WebCore::Pasteboard::readOrigin): Added.

  • platform/wpe/PasteboardWPE.cpp:

(WebCore::Pasteboard::typesSafeForBindings): Now takes the unused origin string.
(WebCore::Pasteboard::readOrigin): Added.

  • platform/wpe/PlatformPasteboardWPE.cpp:

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const): Now takes the unused origin string.

Source/WebKit:

Plubmed the origin identifier through IPC from Pasteboard in WebContent process to PlatformPasteboard in UIProcess.

  • UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::typesSafeForDOMToReadAndWrite):

  • UIProcess/WebPasteboardProxy.cpp:

(WebKit::WebPasteboardProxy::typesSafeForDOMToReadAndWrite):

  • UIProcess/WebPasteboardProxy.h:
  • UIProcess/WebPasteboardProxy.messages.in:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::typesSafeForDOMToReadAndWrite):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::typesSafeForDOMToReadAndWrite):

Tools:

Added API tests for sanitizing URLs copied from web content, and that the original URL is exposed to the web content.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm: Added.

(readURLFromPasteboard): A helper function.

  • TestWebKitAPI/Tests/WebKitCocoa/copy-url.html: Added.
  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(DataInteractionTests.DataTransferGetDataWhenDroppingCustomData): Rebaselined. https://www.apple.com is no longer
normalized to https://www.apple.com/ by NSURL / UIPasteboard as expected.
(DataInteractionTests.DataTransferSetDataValidURL): Added.
(DataInteractionTests.DataTransferSetDataUnescapedURL): Added.
(DataInteractionTests.qDataTransferSetDataInvalidURL): Added.

LayoutTests:

Added tests for copying & pasting URLs. URLs should be %-escaped and any invalid URL should be stripped away and
invisible to a cross-origin content or a null origin document but the same origin content should have access to
its original form.

  • TestExpectations:
  • editing/pasteboard/data-transfer-get-data-on-copying-pasting-malformed-url-in-same-document-expected.txt: Added.
  • editing/pasteboard/data-transfer-get-data-on-copying-pasting-malformed-url-in-same-document.html: Added.
  • editing/pasteboard/data-transfer-get-data-on-drop-custom-expected.txt: Rebaselined. We no longer normalize

"https://www.apple.com" into "https://www.apple.com/" by NSURL / UIPasteboard within the same origin content.

  • editing/pasteboard/data-transfer-get-data-on-paste-custom-expected.txt: Ditto.
  • editing/pasteboard/data-transfer-set-data-ignore-copied-walformed-url-in-null-expected.txt: Added.
  • editing/pasteboard/data-transfer-set-data-ignore-copied-walformed-url-in-null-origin-expected.txt: Added.
  • editing/pasteboard/data-transfer-set-data-ignore-copied-walformed-url-in-null-origin.html: Added.
  • editing/pasteboard/data-transfer-set-data-sanitlize-url-when-copying-in-null-origin-expected.txt: Added.
  • editing/pasteboard/data-transfer-set-data-sanitlize-url-when-copying-in-null-origin.html: Added.
  • editing/pasteboard/data-transfer-set-data-sanitlize-url-when-dragging-in-null-origin-expected.txt: Added.
  • editing/pasteboard/data-transfer-set-data-sanitlize-url-when-dragging-in-null-origin.html: Added.
  • editing/pasteboard/dataTransfer-setData-getData-expected.txt: Rebaselined. More test cases are passing.
  • editing/pasteboard/dataTransfer-setData-getData.html: Updated expectations as the original URL is now preserved.
  • http/tests/security/clipboard/copy-paste-url-across-origin-sanitizes-url-expected.txt: Added.
  • http/tests/security/clipboard/copy-paste-url-across-origin-sanitizes-url.html: Added.
  • http/tests/security/clipboard/resources/copy.html: Added.
  • platform/mac-wk1/TestExpectations:
11:32 AM Changeset in webkit [223194] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Remove some obsolete layout assertions
https://bugs.webkit.org/show_bug.cgi?id=178170

Reviewed by Zalan Bujtas.

We have strong assertions against render tree mutation functions being called in layout. These are unnecessary.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::moveChildTo):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::takeChildInternal):

  • rendering/RenderElement.h:
  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::layout):

  • rendering/RenderListItem.h:
10:48 AM Changeset in webkit [223193] by aestes@apple.com
  • 13 edits
    2 copies
    3 adds in trunk

[Payment Request] Implement Apple Pay merchant validation
https://bugs.webkit.org/show_bug.cgi?id=178159

Reviewed by Brady Eidson.

Source/WebCore:

When ApplePayPaymentHandler::validateMerchant() is called, dispatch the
applepayvalidatemerchant event to the PaymentRequest object.

The event object is an ApplePayMerchantValidationEvent, on which the client calls complete()
with a merchant session.

Test: http/tests/ssl/applepay/ApplePayMerchantValidationEvent.https.html

  • DerivedSources.make:
  • Modules/applepay/ApplePayValidateMerchantEvent.h:
  • Modules/applepay/paymentrequest/ApplePayMerchantValidationEvent.cpp: Added.

(WebCore::ApplePayMerchantValidationEvent::create):
(WebCore::ApplePayMerchantValidationEvent::ApplePayMerchantValidationEvent):
(WebCore::ApplePayMerchantValidationEvent::complete):
(WebCore::ApplePayMerchantValidationEvent::eventInterface const):

  • Modules/applepay/paymentrequest/ApplePayMerchantValidationEvent.h: Added.
  • Modules/applepay/paymentrequest/ApplePayMerchantValidationEvent.idl: Added.
  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::validateMerchant):

  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
  • Modules/paymentrequest/PaymentRequest.idl:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.h:
  • dom/EventNames.in:
  • testing/Internals.cpp:

(WebCore::Internals::Internals):

  • testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::MockPaymentCoordinator):
(WebCore::MockPaymentCoordinator::showPaymentUI):

  • testing/MockPaymentCoordinator.h:

LayoutTests:

  • http/tests/ssl/applepay/ApplePayMerchantValidationEvent.https-expected.txt: Added.
  • http/tests/ssl/applepay/ApplePayMerchantValidationEvent.https.html: Added.
10:47 AM October 2017 Meeting edited by Jon Davis
(diff)
10:41 AM Changeset in webkit [223192] by Chris Dumez
  • 40 edits
    1 copy
    1 add in trunk

Modernize Geolocation code
https://bugs.webkit.org/show_bug.cgi?id=178148

Reviewed by Ryosuke Niwa.

Source/WebCore:

Modernize Geolocation code:

  • Use std::optional<> instead of separate boolean members
  • Make GeolocationPosition a simple struct that can be passed via IPC
  • Replace WebGeolocationPosition::Data with GeolocationPosition
  • Move logic to construct a GeolocationPosition from a CLLocation on iOS in one place to avoid code duplication.
  • Modules/geolocation/Coordinates.cpp:

(WebCore::Coordinates::Coordinates):

  • Modules/geolocation/Coordinates.h:

(WebCore::Coordinates::create):
(WebCore::Coordinates::isolatedCopy const):
(WebCore::Coordinates::latitude const):
(WebCore::Coordinates::longitude const):
(WebCore::Coordinates::altitude const):
(WebCore::Coordinates::accuracy const):
(WebCore::Coordinates::altitudeAccuracy const):
(WebCore::Coordinates::heading const):
(WebCore::Coordinates::speed const):

  • Modules/geolocation/Geolocation.cpp:

(WebCore::createGeoposition):
(WebCore::Geolocation::lastPosition):

  • Modules/geolocation/GeolocationClient.h:
  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::lastPosition):

  • Modules/geolocation/GeolocationController.h:
  • Modules/geolocation/GeolocationPosition.h:

(WebCore::GeolocationPosition::GeolocationPosition):
The default constructor is only needed by our IPC decoding code.

(WebCore::GeolocationPosition::encode const):
(WebCore::GeolocationPosition::decode):

  • Modules/geolocation/ios/GeolocationPositionIOS.mm: Copied from Source/WebCore/Modules/geolocation/Coordinates.cpp.

(WebCore::GeolocationPosition::GeolocationPosition):

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mock/GeolocationClientMock.cpp:

(WebCore::GeolocationClientMock::lastPosition):
(WebCore::GeolocationClientMock::controllerTimerFired):

  • platform/mock/GeolocationClientMock.h:

Source/WebKit:

  • Shared/WebGeolocationPosition.cpp:

(WebKit::WebGeolocationPosition::create):
(WebKit::WebGeolocationPosition::~WebGeolocationPosition):

  • Shared/WebGeolocationPosition.h:

(WebKit::WebGeolocationPosition::timestamp const):
(WebKit::WebGeolocationPosition::latitude const):
(WebKit::WebGeolocationPosition::longitude const):
(WebKit::WebGeolocationPosition::accuracy const):
(WebKit::WebGeolocationPosition::altitude const):
(WebKit::WebGeolocationPosition::altitudeAccuracy const):
(WebKit::WebGeolocationPosition::heading const):
(WebKit::WebGeolocationPosition::speed const):
(WebKit::WebGeolocationPosition::corePosition const):
(WebKit::WebGeolocationPosition::WebGeolocationPosition):

  • UIProcess/API/C/WKGeolocationPosition.cpp:

(WKGeolocationPositionCreate_b):

  • UIProcess/API/Cocoa/_WKGeolocationPosition.mm:

(WebKit::wrapper):

  • UIProcess/API/glib/WebKitGeolocationProvider.cpp:

(WebKit::WebKitGeolocationProvider::notifyPositionChanged):

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::providerDidChangePosition):

  • UIProcess/ios/WKGeolocationProviderIOS.mm:

(-[WKLegacyCoreLocationProvider positionChanged:]):

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):

  • WebProcess/Geolocation/WebGeolocationManager.h:
  • WebProcess/Geolocation/WebGeolocationManager.messages.in:
  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp:

(WebKit::WebGeolocationClient::lastPosition):

  • WebProcess/WebCoreSupport/WebGeolocationClient.h:

Source/WebKitLegacy/ios:

  • Misc/WebGeolocationCoreLocationProvider.h:
  • Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider sendLocation:]):

  • Misc/WebGeolocationProviderIOS.mm:

(-[_WebCoreLocationUpdateThreadingProxy positionChanged:]):

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebGeolocationClient.h:
  • WebCoreSupport/WebGeolocationClient.mm:

(WebGeolocationClient::lastPosition):

  • WebView/WebGeolocationPosition.mm:

(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(core):
(-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
(-[WebGeolocationPosition initWithGeolocationPosition:]):

  • WebView/WebGeolocationPositionInternal.h:

Source/WebKitLegacy/win:

  • WebCoreSupport/WebGeolocationClient.cpp:

(WebGeolocationClient::lastPosition):

  • WebCoreSupport/WebGeolocationClient.h:
  • WebGeolocationPosition.cpp:

(WebGeolocationPosition::initWithTimestamp):
(core):

  • WebGeolocationPosition.h:

(WebGeolocationPosition::impl const):

Tools:

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setMockGeolocationPosition):

10:34 AM October 2017 Meeting edited by Jon Davis
(diff)
10:27 AM Changeset in webkit [223191] by beidson@apple.com
  • 31 edits
    1 copy in trunk

Add a SW context process (where SW scripts will actually execute).
https://bugs.webkit.org/show_bug.cgi?id=178156
Source/WebCore:

Reviewed by Andy Estes.

No new tests (Covered by changes to existing tests).

This patch adds an auxiliary "ServiceWorker context" WebProcess to a WebProcessPool.

This process is where ServiceWorker scripts will execute, separate from the client WebProcess
hosting the page(s) they are serving.

This patch also adds all of the plumbing to pass along a fetched service worker script to this
context WebProcess, as well as message back failure to actually start the script so we can test.

Touches lots of code sites but is basically just a lot of plumbing.

  • WebCore.xcodeproj/project.pbxproj:
  • workers/service/ServiceWorkerContextData.h: Copied from Source/WebCore/workers/service/server/SWServerWorker.h.

(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::finishFetchingScriptInServer):
(WebCore::SWServer::Connection::scriptContextFailedToStart):
(WebCore::SWServer::scriptFetchFinished):
(WebCore::SWServer::scriptContextFailedToStart):
(WebCore::SWServer::createWorker):

  • workers/service/server/SWServer.h:
  • workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::scriptFetchFinished):
(WebCore::SWServerRegistration::scriptContextFailedToStart):

  • workers/service/server/SWServerRegistration.h:
  • workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::SWServerWorker):
(WebCore::SWServerWorker::~SWServerWorker):

  • workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::create):
(WebCore::SWServerWorker::scriptURL const):
(WebCore::SWServerWorker::script const):
(WebCore::SWServerWorker::type const):
(WebCore::SWServerWorker::workerID const):

Source/WebKit:

Reviewed by Andy Estes.

This patch adds an auxiliary "ServiceWorker context" WebProcess to a WebProcessPool.

This process is where ServiceWorker scripts will execute, separate from the client WebProcess
hosting the page(s) they are serving.

This patch also adds all of the plumbing to pass along a fetched service worker script to this
context WebProcess, as well as message back failure to actually start the script so we can test.

Touches lots of code sites but is basically just a lot of plumbing.

  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::startServiceWorkerContext):
(WebKit::WebSWServerConnection::sendToContextProcess):
(WebKit::WebSWServerConnection::setContextConnection):

  • StorageProcess/ServiceWorker/WebSWServerConnection.h:
  • StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::workerContextProcessConnection):
(WebKit::StorageProcess::createWorkerContextProcessConnection):
(WebKit::StorageProcess::didGetWorkerContextProcessConnection):
(WebKit::StorageProcess::serviceWorkerContextFailedToStart):
(WebKit::StorageProcess::registerSWServerConnection):
(WebKit::StorageProcess::unregisterSWServerConnection):

  • StorageProcess/StorageProcess.h:
  • StorageProcess/StorageProcess.messages.in:
  • StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::~StorageToWebProcessConnection):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::removeSWServerConnection):
(WebKit::StorageToWebProcessConnection::workerContextProcessConnectionCreated):

  • StorageProcess/StorageToWebProcessConnection.h:
  • UIProcess/Storage/StorageProcessProxy.cpp:

(WebKit::StorageProcessProxy::create):
(WebKit::StorageProcessProxy::StorageProcessProxy):
(WebKit::StorageProcessProxy::didClose):
(WebKit::StorageProcessProxy::getWorkerContextProcessConnection):
(WebKit::StorageProcessProxy::didGetWorkerContextProcessConnection):

  • UIProcess/Storage/StorageProcessProxy.h:
  • UIProcess/Storage/StorageProcessProxy.messages.in:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureStorageProcessAndWebsiteDataStore):
(WebKit::WebProcessPool::getWorkerContextProcessConnection):
(WebKit::WebProcessPool::didGetWorkerContextProcessConnection):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::createWebPage):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didGetWorkerContextConnection):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWorkerContextConnection):
(WebKit::WebProcess::startServiceWorkerContext):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

LayoutTests:

Reviewed by Andy Estes.

  • http/tests/workers/service/basic-register-exceptions-expected.txt:
  • http/tests/workers/service/basic-register-expected.txt:
  • http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt:
10:04 AM Changeset in webkit [223190] by jdiggs@igalia.com
  • 6 edits
    2 adds in trunk

[ATK] Expose value of aria-keyshortcuts as object attribute
https://bugs.webkit.org/show_bug.cgi?id=171175

Reviewed by Chris Fleizach.

Source/WebCore:

Expose the author-provided string through the "keyshortcuts" object attribute.

Test: accessibility/gtk/aria-keyshortcuts.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::ariaKeyShortcutsValue const):

  • accessibility/AccessibilityObject.h:
  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

  • html/HTMLAttributeNames.in:

LayoutTests:

  • accessibility/gtk/aria-keyshortcuts-expected.txt: Added.
  • accessibility/gtk/aria-keyshortcuts.html: Added.
9:27 AM Changeset in webkit [223189] by commit-queue@webkit.org
  • 6 edits
    71 adds in trunk/LayoutTests

Import media capture WPT tests
https://bugs.webkit.org/show_bug.cgi?id=178138

Patch by Youenn Fablet <youenn@apple.com> on 2017-10-11
Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/feature-policy/resources/feature-policy-payment.html: Added.
  • web-platform-tests/feature-policy/resources/feature-policy-usb.html: Added.
  • web-platform-tests/feature-policy/resources/feature-policy-webvr.html: Added.
  • web-platform-tests/feature-policy/resources/featurepolicy.js: Added.

(test_feature_availability):
(expect_feature_available_default):
(expect_feature_unavailable_default):
(test_result):
(test_feature_availability_with_post_message_result):
(run_all_fp_tests_allow_self):

  • web-platform-tests/feature-policy/resources/redirect-on-load.html: Added.
  • web-platform-tests/feature-policy/resources/w3c-import.log: Added.
  • web-platform-tests/mediacapture-streams/GUM-api.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/GUM-api.https.html: Added.
  • web-platform-tests/mediacapture-streams/GUM-deny.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/GUM-deny.https.html: Added.
  • web-platform-tests/mediacapture-streams/GUM-empty-option-param.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/GUM-empty-option-param.https.html: Added.
  • web-platform-tests/mediacapture-streams/GUM-impossible-constraint.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/GUM-impossible-constraint.https.html: Added.
  • web-platform-tests/mediacapture-streams/GUM-optional-constraint.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/GUM-optional-constraint.https.html: Added.
  • web-platform-tests/mediacapture-streams/GUM-trivial-constraint.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/GUM-trivial-constraint.https.html: Added.
  • web-platform-tests/mediacapture-streams/GUM-unknownkey-option-param.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/GUM-unknownkey-option-param.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaDevices-IDL-all-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaDevices-IDL-all.html: Added.
  • web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaDevices-IDL-enumerateDevices.html: Added.
  • web-platform-tests/mediacapture-streams/MediaDevices-enumerateDevices.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaDevices-enumerateDevices.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaDevices-getUserMedia.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaDevices-getUserMedia.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-MediaElement-preload-none.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-MediaElement-preload-none.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-add-audio-track.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-add-audio-track.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-audio-only.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-audio-only.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https.sub-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https.sub.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-finished-add.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-finished-add.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-gettrackid.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-gettrackid.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-id-manual.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-id-manual.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-idl.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-idl.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-removetrack.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-removetrack.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-video-only.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStream-video-only.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-MediaElement-disabled-audio-is-silence.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-MediaElement-disabled-audio-is-silence.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-MediaElement-disabled-video-is-black.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-MediaElement-disabled-video-is-black.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-end-manual.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-end-manual.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-getSettings.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-getSettings.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-id.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-id.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-init.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrack-init.https.html: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrackEvent-constructor.https-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/MediaStreamTrackEvent-constructor.https.html: Added.
  • web-platform-tests/mediacapture-streams/OWNERS: Added.
  • web-platform-tests/mediacapture-streams/historical-expected.txt: Added.
  • web-platform-tests/mediacapture-streams/historical.html: Added.
  • web-platform-tests/mediacapture-streams/w3c-import.log: Added.

LayoutTests:

Skipping tests for ports not supporting getUserMedia.

  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wpe/TestExpectations:
9:12 AM Changeset in webkit [223188] by aestes@apple.com
  • 1 edit in trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp

Try to fix the Sierra build after r223163.

  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::convertAndValidate):

9:09 AM Changeset in webkit [223187] by jmarcell@apple.com
  • 2 edits
    1 add in branches/safari-604-branch

Cherry-pick r222963. rdar://problem/34891307

9:09 AM Changeset in webkit [223186] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WTF

Cherry-pick r223111. rdar://problem/34920353

9:09 AM Changeset in webkit [223185] by jmarcell@apple.com
  • 3 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r222826. rdar://problem/34792131

9:09 AM Changeset in webkit [223184] by jmarcell@apple.com
  • 3 edits
    3 adds in branches/safari-604-branch

Cherry-pick r222788. rdar://problem/34771440

9:09 AM Changeset in webkit [223183] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebInspectorUI

Cherry-pick r222762. rdar://problem/34771420

9:09 AM Changeset in webkit [223182] by jmarcell@apple.com
  • 4 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r221937. rdar://problem/34893195

9:09 AM Changeset in webkit [223181] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r221872. rdar://problem/34891288

9:09 AM Changeset in webkit [223180] by jmarcell@apple.com
  • 4 edits
    2 adds in branches/safari-604-branch

Cherry-pick r221831. rdar://problem/34891283

8:53 AM Changeset in webkit [223179] by don.olmstead@sony.com
  • 42 edits in trunk/Source/WebKit

Remove ENABLE_NETWORK_CACHE
https://bugs.webkit.org/show_bug.cgi?id=177424

Reviewed by Antti Koivisto.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::storeDerivedDataToCache):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::fetchDiskCacheEntries):
(WebKit::clearDiskCacheEntries):
(WebKit::NetworkProcess::setCacheModel):

  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::cache):

  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::canUseCachedRedirect const):
(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFailLoading):
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
(WebKit::NetworkResourceLoader::dispatchWillSendRequestForCacheEntry):

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/cache/NetworkCache.cpp:
  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheBlobStorage.cpp:
  • NetworkProcess/cache/NetworkCacheBlobStorage.h:
  • NetworkProcess/cache/NetworkCacheCoders.cpp:
  • NetworkProcess/cache/NetworkCacheCoders.h:
  • NetworkProcess/cache/NetworkCacheCodersCocoa.cpp:
  • NetworkProcess/cache/NetworkCacheCodersSoup.cpp:
  • NetworkProcess/cache/NetworkCacheData.cpp:
  • NetworkProcess/cache/NetworkCacheData.h:
  • NetworkProcess/cache/NetworkCacheDataCocoa.mm:
  • NetworkProcess/cache/NetworkCacheDataSoup.cpp:
  • NetworkProcess/cache/NetworkCacheEntry.cpp:
  • NetworkProcess/cache/NetworkCacheEntry.h:
  • NetworkProcess/cache/NetworkCacheFileSystem.cpp:
  • NetworkProcess/cache/NetworkCacheFileSystem.h:
  • NetworkProcess/cache/NetworkCacheIOChannel.h:
  • NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:
  • NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
  • NetworkProcess/cache/NetworkCacheKey.cpp:
  • NetworkProcess/cache/NetworkCacheKey.h:
  • NetworkProcess/cache/NetworkCacheStatistics.cpp:
  • NetworkProcess/cache/NetworkCacheStatistics.h:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:
  • NetworkProcess/cache/NetworkCacheStorage.h:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
(WebKit::NetworkProcess::clearDiskCache):

  • NetworkProcess/ios/NetworkProcessIOS.mm:

(WebKit::NetworkProcess::clearCacheForAllOrigins):

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::clearDiskCache):

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::registerUserDefaultsIfNeeded):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebProcessPool::legacyPlatformDefaultNetworkCacheDirectory):
(WebKit::WebProcessPool::isNetworkCacheEnabled):

  • UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::storeDerivedDataToCache):

  • config.h:
7:51 AM Changeset in webkit [223178] by nael.ouedraogo@crf.canon.fr
  • 4 edits
    1 add in trunk

[GStreamer] Many media source tests crashing with GStreamer-CRITICAL : _gst_util_uint64_scale: assertion 'denom != 0' failed in gst_qtdemux_configure_stream()
https://bugs.webkit.org/show_bug.cgi?id=176804

Reviewed by Michael Catanzaro.

Tools:

Add patch to fix assert in qtdemux.

  • gstreamer/jhbuild.modules:
  • gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Added.

LayoutTests:

Update expectations for fixed tests.

  • platform/gtk/TestExpectations:
6:59 AM Changeset in webkit [223177] by tpopela@redhat.com
  • 22 edits in trunk/Tools

Use https for trac changeset and browser links
https://bugs.webkit.org/show_bug.cgi?id=178167

Reviewed by Alexey Proskuryakov.

Switch the http://trac.webkit.org/changeset and
http://trac.webkit.org/browser links that are printed by webkitpy to
https. Also update the test expectations.

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/config/committervalidator_unittest.py:

(CommitterValidatorTest.test_flag_permission_rejection_message):

  • Scripts/webkitpy/common/config/urls.py:

(view_source_url):
(view_revision_url):

  • Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:

(BugTest.test_commit_revision):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(MainTest):
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):

  • Scripts/webkitpy/style/checkers/changelog_unittest.py:

(ChangeLogCheckerTest.test_missing_bug_number):

  • Scripts/webkitpy/tool/bot/feeders_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_rollout):
(IRCBotTest.test_revert):
(IRCBotTest.test_multi_rollout):
(IRCBotTest.test_rollout_with_r_in_svn_revision):
(IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
(IRCBotTest.test_rollout_invalidate_reason):
(test_multi_rollout_invalidate_reason):

  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/suggestnominations.py:

(SuggestNominations._count_commit):

  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js:

(getTracUrl):
(getSortedKeys):

  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:

(CloseBugForLandDiffTest.test_empty_state):

  • Scripts/webkitpy/tool/steps/commit_unittest.py:

(CommitTest._test_check_test_expectations):

  • Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:

(UpdateChangeLogsForRevertTest):

6:51 AM Changeset in webkit [223176] by commit-queue@webkit.org
  • 18 edits
    6 moves
    3 adds
    6 deletes in trunk/LayoutTests

Rebaseline tests at media/modern-media-controls/media-controller
https://bugs.webkit.org/show_bug.cgi?id=178129

Patch by Antoine Quint <Antoine Quint> on 2017-10-11
Reviewed by Sam Weinig.

Rebaseline a series of tests to work with the current modern-media-controls codebase. For the most part, this is accounting
for metrics changes and the refactoring of the auto-hide controller code.

  • media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-pause-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide.html:
  • media/modern-media-controls/media-controller/media-controller-click-on-video-controls-should-not-pause.html:
  • media/modern-media-controls/media-controller/media-controller-compact-expected.txt: Removed.
  • media/modern-media-controls/media-controller/media-controller-compact.html: Removed.
  • media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-fullscreen-change.html:
  • media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
  • media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html:
  • media/modern-media-controls/media-controller/media-controller-scale-factor-audio-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html:
  • media/modern-media-controls/media-controller/media-controller-scale-factor-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-scale-factor.html:
  • media/modern-media-controls/media-controller/media-controller-tight-padding-expected.txt: Removed.
  • media/modern-media-controls/media-controller/media-controller-tight-padding.html: Removed.
  • platform/ios-simulator/TestExpectations:
  • platform/mac-elcapitan/TestExpectations:
  • platform/mac/TestExpectations:
5:59 AM Changeset in webkit [223175] by Caio Lima
  • 5 edits
    2 adds in trunk

Object properties are undefined in super.call() but not in this.call()
https://bugs.webkit.org/show_bug.cgi?id=177230

Reviewed by Saam Barati.

JSTests:

  • stress/super-call-function-subclass.js: Added.

(assert):
(A.prototype.t):
(A):

  • stress/super-dot-call-and-apply.js: Added.

(assert):
(A):
(A.prototype.call):
(A.prototype.apply):
(B.prototype.testSuper):
(B):
(const.obj.new.B.string_appeared_here.obj.testSuper.C):
(D.prototype.testSuper):
(D):

Source/JavaScriptCore:

Bytecode generation for "super.call(...)" or "super.apply(...)"
shouldn't be considered as CallFunctionCallDotNode or
ApplyFunctionCallDotNode because they should be considered as common
super property access as any other function. According to spec[1],
"super" is not refering to parent constructor.

[1] - https://tc39.github.io/ecma262/#sec-super-keyword-runtime-semantics-evaluation

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::makeFunctionCallNode):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::makeFunctionCallNode):

5:42 AM Changeset in webkit [223174] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit

Unreviewed, rolling out r223146.

Better to not expose cairo in the WPE API

Reverted changeset:

"[WPE] Header cairo.h is used in GLib API headers but cannot
be found"
https://bugs.webkit.org/show_bug.cgi?id=178100
http://trac.webkit.org/changeset/223146

5:30 AM Changeset in webkit [223173] by Yusuke Suzuki
  • 12 edits in trunk/Source

[JSC] Drop Instantiate hook in ES6 module loader
https://bugs.webkit.org/show_bug.cgi?id=178162

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This patch is a part of patch series for module loader refactoring to adopt
integrity="" parameters and introduce new whatwg module import mechanism.

In this patch, we drop instantiate hook in module loader. This hook is originally
introduced because it is defined in whatwg/loader spec. But this hook is not
used in our implementation, and this hook won't be used since (1) whatwg/loader
spec is abandoned, and (2) this type of hooks should be done in Service Workers.

In addition, this patch applies some cleaning up of our module loader JS code
to simplify things. This change paves the way to more efficient loader implementation
with great flexibility to adopt integrity="" parameters.

  • builtins/ModuleLoaderPrototype.js:

(requestInstantiate):
(provideFetch):
provide is changed to provideFetch since we only used this function with Fetch stage parameter.

(fulfillInstantiate): Deleted.
(commitInstantiated): Deleted.
(instantiation): Deleted.
They are merged into requestInstantiate code. This is simpler.

(provide): Deleted.

  • jsc.cpp:
  • runtime/Completion.cpp:

(JSC::loadAndEvaluateModule):
(JSC::loadModule):

  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::provideFetch):
(JSC::JSModuleLoader::provide): Deleted.
Changed to provideFetch.

(JSC::JSModuleLoader::instantiate): Deleted.
Drop this hook.

  • runtime/JSModuleLoader.h:
  • runtime/ModuleLoaderPrototype.cpp:

(JSC::moduleLoaderPrototypeInstantiate): Deleted.
Drop this hook.

Source/WebCore:

Drop instantiate hooks.
No behavior change.

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSWorkerGlobalScopeBase.cpp:
3:24 AM WebKitGTK/2.18.x edited by tpopela@redhat.com
(diff)
2:33 AM Changeset in webkit [223172] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[MSE][GStreamer] Add dump of append pipeline
https://bugs.webkit.org/show_bug.cgi?id=178074

Patch by Alicia Boya García <aboya@igalia.com> on 2017-10-11
Reviewed by Xabier Rodriguez-Calvar.

Enable dump of AppendPipeline.

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::appendPipelineStateChangeMessageCallback):
(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::handleStateChangeMessage):

  • platform/graphics/gstreamer/mse/AppendPipeline.h:
12:59 AM Changeset in webkit [223171] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Avoid "100.00ms" vs "100.0ms" jitter in TimelineRuler labels
https://bugs.webkit.org/show_bug.cgi?id=178143

Reviewed by Brian Burg.

  • UserInterface/Base/Utilities.js:

Allow a small slop factor that wouldn't have changed the display value's
significant figures anyways. This addresses cases where 100.0000000000001
were being treated slightly differently from 100.0.

12:55 AM Changeset in webkit [223170] by Joseph Pecoraro
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Tab - Show initially loaded resources even if network info not logged
https://bugs.webkit.org/show_bug.cgi?id=178098
<rdar://problem/34073529>

Reviewed by Devin Rousso.

  • UserInterface/Models/Resource.js:

(WI.Resource.prototype.hasResponse):
Resources loaded by Page.getFrameTree have a response but no status code data.
So include finished resources as having a resource.

  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.closed):
(WI.NetworkTableContentView.prototype._populateWithInitialResourcesIfNeeded):
(WI.NetworkTableContentView.prototype._mainFrameDidChange):
Listen for the first main frame change to perform an initial population.

(WI.NetworkTableContentView.prototype._insertResourceAndReloadTable):
This path is not currently taken when table is null, but change the code so
that if it is reached without the table it would behave gracefully.

  • UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype._refreshSummarySection):
On first open none of the resources have a statusCode. Show an emDash.

12:54 AM Changeset in webkit [223169] by fred.wang@free.fr
  • 10 edits
    2 adds in trunk

[iOS] Do not flatten frames when async frame scrolling is enabled
https://bugs.webkit.org/show_bug.cgi?id=173704

Patch by Frederic Wang <fwang@igalia.com> on 2017-09-27
Reviewed by Simon Fraser.

Source/WebCore:

This patch disables frame flattening when async frame scrolling is enabled on iOS, as
otherwise you can not scroll them. Once iframe scrolling is implemented in iOS (bug 149264),
developers and beta testers will be able to check it by enabling "Async Frame Scrolling"
in the "Experimental WebKit Features" menu of Safari iOS.

Test: platform/ios/fast/frames/flattening/iframe-flattening-with-async-frame-scrolling.html

  • page/FrameView.cpp:

(WebCore::FrameView::frameFlatteningEnabled): Use effectiveFrameFlattening()

  • page/Settings.cpp:

(WebCore::Settings::effectiveFrameFlattening): New function to return frameFlattening() or do
some exceptions on iOS.

  • page/Settings.h: Declare effectiveFrameFlattening.
  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::flattenFrameSet): Use effectiveFrameFlattening()

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::flattenFrame): Ditto.

  • rendering/RenderView.cpp:

(WebCore::FrameFlatteningLayoutDisallower::FrameFlatteningLayoutDisallower): Ditto.

Source/WebKit:

This patch disables frame flattening when async frame scrolling is enabled on iOS, as
otherwise you can not scroll them. Once iframe scrolling is implemented in iOS (bug 149264),
developers and beta testers will be able to check it by enabling "Async Frame Scrolling"
in the "Experimental WebKit Features" menu of Safari iOS.

Test: platform/ios/fast/frames/flattening/iframe-flattening-with-async-frame-scrolling.html

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged): Use effectiveFrameFlattening() introduced in
Source/WebCore.

LayoutTests:

Add an iOS test to verify that frame flattening is disabled when async frame scrolling is enabled.

  • platform/ios/fast/frames/flattening/iframe-flattening-with-async-frame-scrolling-expected.txt: Added.
  • platform/ios/fast/frames/flattening/iframe-flattening-with-async-frame-scrolling.html: Added.
12:42 AM WebKitGTK/2.16.x edited by tpopela@redhat.com
(diff)
Note: See TracTimeline for information about the timeline view.