Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Nov 26, 2017:

11:51 PM Changeset in webkit [225154] by Yusuke Suzuki

• 19 edits
  5 adds in trunk

[DFG] Add NormalizeMapKey DFG IR
​https://bugs.webkit.org/show_bug.cgi?id=179912

Reviewed by Saam Barati.

JSTests:

• stress/map-untyped-normalize-cse.js: Added.

(shouldBe):
(test):

• stress/map-untyped-normalize.js: Added.

(shouldBe):
(test):

• stress/set-untyped-normalize-cse.js: Added.

(shouldBe):
(set return.set has.set has):

• stress/set-untyped-normalize.js: Added.

(shouldBe):
(set return.set has):

Source/JavaScriptCore:

This patch introduces NormalizeMapKey DFG node. It executes what normalizeMapKey does in inlined manner.
By separating this from MapHash and Map/Set related operations, we can perform CSE onto that, and we
do not need to call normalizeMapKey conservatively in DFG operations.
This can reduce slow path case in Untyped GetMapBucket since we can normalize keys in DFG/FTL.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupNormalizeMapKey):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNormalizeMapKey):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileMapHash):
(JSC::FTL::DFG::LowerDFGToB3::compileNormalizeMapKey):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket):

• runtime/HashMapImpl.h:

7:45 PM Changeset in webkit [225153] by Yusuke Suzuki

• 4 edits
  2 adds in trunk

[FTL] Support DeleteById and DeleteByVal
​https://bugs.webkit.org/show_bug.cgi?id=180022

Reviewed by Saam Barati.

JSTests:

• stress/delete-by-id.js: Added.

(shouldBe):
(test1):
(test2):

• stress/delete-by-val-ftl.js: Added.

(shouldBe):
(test1):
(test2):

Source/JavaScriptCore:

We should increase the coverage of FTL. Even if the code includes DeleteById,
it does not mean that remaining part of the code should not be optimized in FTL.
Right now, even CallEval and with scope are handled in FTL.

This patch just adds DeleteById and DeleteByVal handling to FTL to allow optimizing
code including them.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteById):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteByVal):

6:19 PM Changeset in webkit [225152] by Simon Fraser

• 3 edits
  2 adds in trunk

feImage as filter input has skewed colors
​https://bugs.webkit.org/show_bug.cgi?id=180021

Reviewed by Sam Weinig.
Source/WebCore:

Using an <feImage> as a filter input sometimes results in incorrect colors, because
the image is being sourced as linearRGB when it should always be sRGB.

Fix by setting the result colorspace in FEImage before we allocate the output
buffer.

Tests: svg/filters/feImage-color-fidelity-expected.svg

svg/filters/feImage-color-fidelity.svg

• svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::platformApplySoftware):

LayoutTests:

• svg/filters/feImage-color-fidelity-expected.svg: Added.
• svg/filters/feImage-color-fidelity.svg: Added.

5:46 PM Changeset in webkit [225151] by Yusuke Suzuki

• 8 edits
  5 adds in trunk

[DFG] Introduce {Set,Map,WeakMap}Fields
​https://bugs.webkit.org/show_bug.cgi?id=179925

Reviewed by Saam Barati.

JSTests:

• stress/map-set-clobber-map-get.js: Added.

(shouldBe):
(test):

• stress/map-set-does-not-clobber-set-has.js: Added.

(shouldBe):

• stress/map-set-does-not-clobber-weak-map-get.js: Added.

(shouldBe):
(test):

• stress/set-add-clobber-set-has.js: Added.

(shouldBe):

• stress/set-add-does-not-clobber-map-get.js: Added.

(shouldBe):

Source/JavaScriptCore:

SetAdd and MapSet uses write(MiscFields), but it is not correct. It accidentally
writes readonly MiscFields which is used by various nodes and make optimization
conservative.

We introduce JSSetFields, JSMapFields, and JSWeakMapFields to precisely model clobberizing of Map, Set, and WeakMap.

• dfg/DFGAbstractHeap.h:
• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

• dfg/DFGHeapLocation.h:
• dfg/DFGNode.h:

(JSC::DFG::Node::hasBucketOwnerType):

5:22 PM Changeset in webkit [225150] by Yusuke Suzuki

• 12 edits
  1 delete in trunk/Source/JavaScriptCore

[JSC] Remove JSStringBuilder
​https://bugs.webkit.org/show_bug.cgi?id=180016

Reviewed by Saam Barati.

JSStringBuilder is replaced with WTF::StringBuilder.
This patch removes remaning uses and drop JSStringBuilder.

• JavaScriptCore.xcodeproj/project.pbxproj:
• runtime/ArrayPrototype.cpp:
• runtime/AsyncFunctionPrototype.cpp:
• runtime/AsyncGeneratorFunctionPrototype.cpp:
• runtime/ErrorPrototype.cpp:
• runtime/FunctionPrototype.cpp:
• runtime/GeneratorFunctionPrototype.cpp:
• runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode):
(JSC::globalFuncEscape):

• runtime/JSStringBuilder.h: Removed.
• runtime/JSStringInlines.h:

(JSC::jsMakeNontrivialString):

• runtime/RegExpPrototype.cpp:
• runtime/StringPrototype.cpp:

5:15 PM Changeset in webkit [225149] by Yusuke Suzuki

• 15 edits in trunk/Source/JavaScriptCore

[DFG] Remove GetLocalUnlinked
​https://bugs.webkit.org/show_bug.cgi?id=180017

Reviewed by Saam Barati.

Since DFGArgumentsSimplificationPhase is removed 2 years ago, GetLocalUnlinked is no longer used in DFG.
This patch just removes it.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGCommon.h:
• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGNode.h:

(JSC::DFG::Node::hasUnlinkedLocal):
(JSC::DFG::Node::convertToGetLocalUnlinked): Deleted.
(JSC::DFG::Node::convertToGetLocal): Deleted.
(JSC::DFG::Node::hasUnlinkedMachineLocal): Deleted.
(JSC::DFG::Node::setUnlinkedMachineLocal): Deleted.
(JSC::DFG::Node::unlinkedMachineLocal): Deleted.

• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

• dfg/DFGValidate.cpp:

2:13 PM Changeset in webkit [225148] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Cleanup code for RenderMathMLUnderOver::layoutBlock
​https://bugs.webkit.org/show_bug.cgi?id=179681

Patch by Minsheng Liu <​lambda@liu.ms> on 2017-11-26
Reviewed by Frédéric Wang.

The patch removes some unnecessary calls to layoutIfNeeds() and guards the change
with assertion. Since there is no behavior change, no new tests are required.

• rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::stretchHorizontalOperatorsAndLayoutChildren):
(WebCore::RenderMathMLUnderOver::layoutBlock):
(WebCore::RenderMathMLUnderOver::computeOperatorsHorizontalStretch): Deleted.

• rendering/mathml/RenderMathMLUnderOver.h:

12:03 PM Changeset in webkit [225147] by Simon Fraser

• 36 edits in trunk

Use more Uint8ClampedArray& and constness in filter and image buffer code
​https://bugs.webkit.org/show_bug.cgi?id=180008

Reviewed by Darin Adler.

Source/WebCore:

Use references to Uint8ClampedArrays rather than pointers where necessary.

Use const for source data buffers when possible, and uint8_t for the underlying
data type.

Fix a bug in FEGaussianBlur where the output of the last blur pass wasn't
copied to the result buffer, which required a test adjustment.

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::putImageData):

• platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::genericConvertToLuminanceMask):

• platform/graphics/ImageBuffer.h:
• platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::blurShadowBuffer):

• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::putByteArray):

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::putByteArray):

• platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData const):
(WebCore::ImageBufferData::putData):

• platform/graphics/cg/ImageBufferDataCG.h:
• platform/graphics/cpu/arm/filters/FEBlendNEON.h:

(WebCore::FEBlend::platformApplySoftware):

• platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h:

(WebCore::FEComposite::computeArithmeticPixelsNeon):
(WebCore::FEComposite::platformArithmeticNeon):

• platform/graphics/cpu/arm/filters/FEGaussianBlurNEON.h:

(WebCore::boxBlurNEON):

• platform/graphics/cpu/arm/filters/NEONHelpers.h:

(WebCore::loadRGBA8AsFloat):

• platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::effectApplyAccelerated):
(WebCore::effectType):
(WebCore::FEColorMatrix::platformApplySoftware):

• platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::platformApplySoftware):

• platform/graphics/filters/FEComposite.cpp:

(WebCore::computeArithmeticPixels):
(WebCore::FEComposite::platformArithmeticSoftware):
(WebCore::FEComposite::platformApplySoftware):

• platform/graphics/filters/FEComposite.h:
• platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::setDestinationPixels):
(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
(WebCore::FEConvolveMatrix::fastSetOuterPixels):
(WebCore::FEConvolveMatrix::platformApplySoftware):

• platform/graphics/filters/FEConvolveMatrix.h:
• platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::platformApplySoftware):

• platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

• platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::boxBlurAlphaOnly):
(WebCore::boxBlur):
(WebCore::accelerateBoxBlur):
(WebCore::standardBoxBlur):
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):
(WebCore::FEGaussianBlur::platformApplySoftware):

• platform/graphics/filters/FEGaussianBlur.h:
• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::drawLighting):
(WebCore::FELighting::platformApplySoftware):

• platform/graphics/filters/FELighting.h:
• platform/graphics/filters/FEMorphology.cpp:

(WebCore::columnExtremum):
(WebCore::FEMorphology::platformApplyGeneric):
(WebCore::FEMorphology::platformApplyDegenerate):
(WebCore::FEMorphology::platformApplySoftware):

• platform/graphics/filters/FEMorphology.h:
• platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegion const):
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):

• platform/graphics/filters/FETurbulence.h:
• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::forceValidPreMultipliedPixels):
(WebCore::FilterEffect::imageBufferResult):
(WebCore::FilterEffect::unmultipliedResult):
(WebCore::FilterEffect::premultipliedResult):
(WebCore::FilterEffect::copyImageBytes const):
(WebCore::copyPremultiplyingAlpha):
(WebCore::copyUnpremultiplyingAlpha):
(WebCore::FilterEffect::copyUnmultipliedResult):
(WebCore::FilterEffect::copyPremultipliedResult):

• platform/graphics/filters/FilterEffect.h:
• platform/graphics/win/ImageBufferDataDirect2D.cpp:

(WebCore::ImageBufferData::putData):

• platform/graphics/win/ImageBufferDataDirect2D.h:

LayoutTests:

Fix a bug in FEGaussianBlur where the output of the last blur pass wasn't
copied to the result buffer, which required a test adjustment.

• css3/filters/filter-on-overflow-hidden-expected.html:
• css3/filters/filter-on-overflow-hidden.html:

7:56 AM Changeset in webkit [225146] by Yusuke Suzuki

• 2 edits in trunk/Source/JavaScriptCore

Make ArgList::data() private again when we can remove callWasmFunction().
​https://bugs.webkit.org/show_bug.cgi?id=168582

Reviewed by JF Bastien.

Make ArgList::data() private since we already removed callWasmFunction.

• runtime/ArgList.h:

Nov 25, 2017:

8:59 AM Changeset in webkit [225145] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

Make RenderSnapshottedPlugIn ISO allocated
​https://bugs.webkit.org/show_bug.cgi?id=180010
<rdar://problem/35671977>

Reviewed by David Kilzer.

RenderEmbeddedObject, the base class is ISO allocated since r224537.

• rendering/RenderSnapshottedPlugIn.cpp:
• rendering/RenderSnapshottedPlugIn.h:

Nov 24, 2017:

6:44 PM Changeset in webkit [225144] by Darin Adler

• 14 edits in trunk/Source

Fix some minor problems in the StringImpl header
​https://bugs.webkit.org/show_bug.cgi?id=160630

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

• inspector/ContentSearchUtilities.cpp: Removed a lot of unneeded explicit

Yarr namespacing since we use "using namespace" in this file.

Source/WebCore:

• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::text): Use stripLeadingAndTrailingHTMLSpaces
instead of stripWhiteSpace(isHTMLSpace).
(WebCore::HTMLOptionElement::value): Ditto.
(WebCore::HTMLOptionElement::label): Ditto.
(WebCore::HTMLOptionElement::displayLabel): Ditto.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument): Use stripLeadingAndTrailingHTMLSpaces
instead of calling the general purpose one and passing isHTMLSpace.

• platform/network/HTTPParsers.h:

(WebCore::stripLeadingAndTrailingHTTPSpaces): Updated to use the
new name, stripLeadingAndTrailingCharacters.

Source/WTF:

• wtf/text/AtomicString.h: Update since CharacterMatchFunctionPtr is now

CodeUnitMatchFunction.

• wtf/text/StringCommon.h: Added CodeUnitMatchFunction, which replaces

CharacterMatchFunctionPtr.

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripMatchedCharacters): Changed template argument name
to CodeUnitPredicate to help make it clear this works on code units, not
code points.
(WTF::UCharPredicate): Deleted.
(WTF::SpaceOrNewlinePredicate): Deleted.
(WTF::StringImpl::stripWhiteSpace): Removed unneeded use of predicate class to
turn a function into a functor; functions already work fine as functors without
a class wrapping them.
(WTF::StringImpl::stripLeadingAndTrailingCharacters): Ditto. Also renamed
from stripWhiteSpace, since it strips arbitrary characters.
(WTF::StringImpl::removeCharacters): Fixed various minor style issues and
updated to new type name.
(WTF::StringImpl::simplifyMatchedCharactersToSpace): Ditto.
(WTF::StringImpl::simplifyWhiteSpace): More of the same.
(WTF::StringImpl::find): Ditto.

• wtf/text/StringImpl.h: Removed unneeded include of uchar.h, since it's

included by StringCommon.h. Removed =CharacterMatchFunctionPtr and
IsWhiteSpaceFunctionPtr, both replaced by CodeUnitMatchFunction. Fixed
a mistake recently introduced in isSpaceOrNewline, which was unnecessarily,
inefficiently using ICU for non-ASCII Latin-1 characters.

• wtf/text/StringView.h: Use CodeUnitMatchFunction instead of CharacterMatchFunction.

• wtf/text/WTFString.cpp:

(WTF::String::stripLeadingAndTrailingCharacters): Updated function name and type.
(WTF::String::simplifyWhiteSpace): Updated type.
(WTF::String::removeCharacters): Updated type.

• wtf/text/WTFString.h: Ditto.

5:49 PM Changeset in webkit [225143] by Darin Adler

• 2 edits in trunk/Tools

• TestWebKitAPI/Tests/WTF/OptionSet.cpp:

(TestWebKitAPI::TEST): Added a test for OptionSet operator|.

5:09 PM Changeset in webkit [225142] by Darin Adler

• 34 edits in trunk/Source

Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
​https://bugs.webkit.org/show_bug.cgi?id=179981

Reviewed by Sam Weinig.

Source/WebCore:

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rangeMatchesTextNearRange): Pass { } instead of 0.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection const): Use { }
instead of | to construct value.

• editing/Editor.cpp:

(WebCore::Editor::findString): Use contains instead of & to test an option.
(WebCore::Editor::rangeOfString): Ditto.
(WebCore::Editor::countMatchesForText): Ditto.

• editing/EditorCommand.cpp:

(WebCore::executeFindString): Use { } instead of | to construct value.

• editing/FindOptions.h: Use OptionSet for type.
• editing/TextIterator.cpp:

(WebCore::SearchBuffer::SearchBuffer): Use contains instead of &. Also use -= instead
of &= coupled with ~ to remove a flag.
(WebCore::SearchBuffer::isWordEndMatch const): Ditto.
(WebCore::SearchBuffer::isWordStartMatch const): Ditto.
(WebCore::SearchBuffer::search): Ditto.
(WebCore::findIteratorOptions): Ditto.
(WebCore::findClosestPlainText): Ditto.
(WebCore::findPlainText): Ditto.

• editing/mac/DictionaryLookup.h: Changed optional dictionary out arguments to

RetainPtr<NSDictionary>. Before, they were returning a retained object, but callers
did not seem to realize that.

• editing/mac/DictionaryLookup.mm:

(WebCore::tokenRange): Added helper. Takes care of doing adoptNS on the options
dictionary, and also handles the Objective-C exception possibility cleanly. Also
fixed the exception case to return NSNotFound instead of a zero-length range at
the location we are searching, which is what the code expects.
(WebCore::DictionaryLookup::rangeForSelection): Refactored to use the tokenRange
helper function, and also to do much less work when the options pointer is null.
(WebCore::DictionaryLookup::rangeAtHitTestResult): Use the tokenRange helper
function and also use auto a bunch to tighten up the code a bit.
(WebCore::DictionaryLookup::stringForPDFSelection): Ditto.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::find const): Use |= instead of | to build find options.

• page/Page.cpp:

(WebCore::Page::findString): Use contains instead of & and also - instead of
& combined with ~.
(WebCore::Page::findStringMatchingRanges): Ditto.
(WebCore::Page::rangeOfString): Ditto.

• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::selectClosestWordFromHitTestResultBasedOnLookup):
Pass nullptr to indicate we don't need the options dictionary. The code before
was passing a pointer to a null, which meant we would do the work to get the
options dictionary, not use it, and also leak it.

• testing/Internals.cpp:

(WebCore::Internals::rangeOfStringNearLocation): Pass { } instead of 0.
(WebCore::Internals::rangeForDictionaryLookupAtLocation): Pass nullptr to
indicate we don't need the options dictionary as above.
(WebCore::parseFindOptions): Initialize options without an explicit 0, since
an OptionSet starts out empty rather than uninitialized.

Source/WebKit:

• WebProcess/Plugins/PDF/PDFPlugin.h: Use some references instead of pointers. Made more

things final and private. Changed functions with multiple return values to use tuples
instead of out arguments for clarity, especially because some were using pointers and it
was ambiguous whether the pointers could be nullptr. Tweaked formatting. Moved initialization
of data members into the class definition.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::create): Take a reference.
(WebKit::PDFPlugin::PDFPlugin): Ditto. Also moved some initialization to the class definition.
(WebKit::PDFPlugin::countFindMatches): Added comment about ignored maxMatchCount argument.
(WebKit::PDFPlugin::findString): Use contains instead of & to check bits in options.
Simplified slightly confusing match count code that was doing some unnecessary comparisons
with the maximum match count. Use auto a bit.
(WebKit::coreCursor): Renamed from pdfLayerControllerCursorTypeToCursor since this is C++
and overloading works based on the argument type.
(WebKit::PDFPlugin::notifyCursorChanged): Updated for name change.
(WebKit::PDFPlugin::lookupTextAtLocation const): Return a tuple instead of using two out
arguments and use a RetainPtr so we don't leak the options dictionary.

• WebProcess/Plugins/PluginProxy.h: Removed unneeded include of FindOptions.h.

• WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:

(WebKit::WebContextMenuClient::lookUpInDictionary): Pass a reference.

• WebProcess/WebPage/FindController.cpp:

(WebKit::core): Use |= instead of | to build up a FindOptions.
(WebKit::FindController::FindController): Initialize data members in the class definition.
(WebKit::pluginViewForFrame): Deleted. Callers now use WebPage::pluginViewForFrame.
(WebKit::FindController::updateFindUIAfterPageScroll): Added a FIXME about some peculiar code.
(WebKit::FindController::findString): Use |= rather than | to add in an option.
(WebKit::FindController::hideFindUI): Use { } rather than 0 for no options.

• WebProcess/WebPage/FindController.h: Moved initialization to the header. Exported the core

function that converts WebKit::FindOptions to WebCore::FindOptions.

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::handlesPageScaleGesture const): Use WebPage::pluginViewForFrame.
(WebKit::WebFrame::requiresUnifiedScaleFactor const): Use WebPage::pluginViewForFrame.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Removed unneeded local variable and UNUSED_PARAM.
(WebKit::WebPage::focusedPluginViewForFrame): Use pluginViewForFrame.
(WebKit::WebPage::pluginViewForFrame): Added a null check since this takes a pointer.
Use is/downcast insteadof more ad hoc coding style.
(WebKit::WebPage::findStringFromInjectedBundle): Call core to convert WebKit::FindOptions
to WebCore::FindOptions. Before, this was accidentally relying on the bits from the two
enumrations matching! The stricter type checking of OptionSet helps us catch mistakes
like this.

• WebProcess/WebPage/WebPage.h: Updated for the above. Also flattened out nested #if

statements, made forward declarations unconditional, and re-sorted them. Changed the
Mac-specific lookupTextAtLocation to return a tuple (see below).

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performDictionaryLookupForSelection): Take a reference instead of a pointer.
(WebKit::WebPage::performDictionaryLookupForRange): Ditto.
(WebKit::rangeNearPositionMatchesText): Use { } rather than 0 for no options.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation): Use RetainPtr<NSDictionary> to fix
code that used to leak.
(WebKit::WebPage::performDictionaryLookupForSelection): Ditto.
(WebKit::WebPage::performDictionaryLookupOfCurrentSelection): Use a reference.
(WebKit::WebPage::dictionaryPopupInfoForRange): Updated for changed argument types.
(WebKit::WebPage::dictionaryPopupInfoForSelectionInPDFPlugin): Ditto.
(WebKit::WebPage::performDictionaryLookupForRange): Ditto.
(WebKit::WebPage::performImmediateActionHitTestAtLocation): Updated to handle the
tuple result from the lookupTextAtLocation functions.
(WebKit::WebPage::lookupTextAtLocation): Changed to return a tuple and use RetainPtr
for the NSDictionary to help fix the leak.

Source/WebKitLegacy/mac:

• WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.

• WebView/WebView.mm:

(coreOptions): Use |= instead of | to build up FindOptions.

Source/WebKitLegacy/win:

• WebView.cpp:

(WebView::searchFor): Use |= instead of | to build FindOptions.
(WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
(WebView::findString): Create FindOptions with |=; the old code just passed a
WebKit FindOptions through without converting to WebCore::FindOptions.

Source/WTF:

• wtf/OptionSet.h: Added some operators so it's easier to use | and - with individual

options from the set.

1:15 PM Changeset in webkit [225141] by Antti Koivisto

• 4 edits
  2 adds in trunk

Style resolution spin due to calc() values always comparing inequal (seen on arstechnica.com)
​https://bugs.webkit.org/show_bug.cgi?id=179982
<rdar://problem/35677991>

Reviewed by Darin Adler.

Source/WebCore:

Test: transitions/transition-with-calc-spin.html

Something like calc(100% - 10px) would compare inequal to itself. This causes the implicit animation engine think that
there is a new target value after style resolution and restart the transition. Starting the transition triggers another style
resolution on zero duration timer and so on.

• platform/CalculationValue.cpp:

(WebCore::operator==):

• platform/CalculationValue.h:

Deep compare the child vectors.

LayoutTests:

• transitions/transition-with-calc-spin-expected.txt: Added.
• transitions/transition-with-calc-spin.html: Added.

1:02 PM Changeset in webkit [225140] by mark.lam@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Fix CLoop::sanitizeStack() bug where it was clearing part of the JS stack in use.
​https://bugs.webkit.org/show_bug.cgi?id=179936
<rdar://problem/35623998>

Reviewed by Saam Barati.

This issue was uncovered when we enabled --useDollarVM=true on the JSC tests.
See ​https://bugs.webkit.org/show_bug.cgi?id=179684.

Basically, in the case of the failing test we observed, op_tail_call_forward_arguments
was allocating stack space to stash arguments (to be forwarded) and new frame
info. The location of this new stash space happens to lie beyond the top of frame
of the tail call caller frame. After stashing the arguments, the code proceeded
to load the callee codeBlock. This triggered an allocation, which in turn,
triggered stack sanitization. The CLoop stack sanitizer was relying on
frame->topOfFrame() to tell it where the top of the used stack is. In this case,
that turned out to be inadequate. As a result, part of the stashed data was
zeroed out, and subsequently led to a crash.

This bug does not affect JIT builds (i.e. the ASM LLint) for 2 reasons:

1. JIT builds do stack sanitization in the LLInt code itself (different from the CLoop implementation), and the sanitizer there is aware of the true top of stack value (i.e. the stack pointer).
2. JIT builds don't use a parallel stack like the CLoop. The presence of the parallel stack is one condition necessary for reproducing this issue.

The fix is to make the CLoop record the stack pointer in CLoopStack::m_currentStackPointer
every time before it calls out to native C++ code. This also brings the CLoop's
behavior closer to hardware behavior where we can know where the stack pointer
is after calling from JS back into native C++ code, which makes it easier to
reason about correctness.

Also simplified the various stack boundary calculations (removed the +1 and -1
adjustments). The CLoopStack bounds are now:

reservationTop(): the lowest reserved address that can be within stack bounds.
m_commitTop: the lowest address within stack bounds that has been committed.
lowAddress() aka m_end: the lowest stack address that JS code can use.
m_lastStackPointer: cache of the last m_currentStackPointer value.
m_currentStackPointer: the CLoopStack stack pointer value when calling from JS into C++ code.
highAddress(): the highest address just beyond the bounds of the stack.

Also deleted some unneeded code.

• interpreter/CLoopStack.cpp:

(JSC::CLoopStack::CLoopStack):
(JSC::CLoopStack::gatherConservativeRoots):
(JSC::CLoopStack::sanitizeStack):
(JSC::CLoopStack::setSoftReservedZoneSize):

• interpreter/CLoopStack.h:

(JSC::CLoopStack::setCurrentStackPointer):
(JSC::CLoopStack::lowAddress const):

(JSC::CLoopStack::baseOfStack const): Deleted.

• Not needed after we simplified the code and removed all the +1/-1 adjustments. Now, it has the exact same value as highAddress() and can be removed.

• interpreter/CLoopStackInlines.h:

(JSC::CLoopStack::ensureCapacityFor):
(JSC::CLoopStack::currentStackPointer):
(JSC::CLoopStack::setCLoopStackLimit):

(JSC::CLoopStack::topOfFrameFor): Deleted.

• Not needed.

(JSC::CLoopStack::topOfStack): Deleted.

• Supplanted by currentStackPointer().

(JSC::CLoopStack::shrink): Deleted.

• This is unused.

• llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

• Introduce a StackPointerScope to restore the original CLoopStack::m_currentStackPointer upon exitting the interpreter loop.

• offlineasm/cloop.rb:
• Added setting of CLoopStack::m_currentStackPointer at boundary points where we call from JS into C++ code.

• tools/VMInspector.h:
• Added some default argument values. These were being used while debugging this issue.

11:52 AM Changeset in webkit [225139] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKitLegacy

[WinCairo] WebPreferences IDL not regenerating
​https://bugs.webkit.org/show_bug.cgi?id=179960

Patch by Fujii Hironori <Fujii Hironori> on 2017-11-24
Reviewed by Darin Adler.

WebKitLegacy shouldn't include the forwarding header of
WebKitLegacy itself.

• CMakeLists.txt: Add ${FORWARDING_HEADERS_DIR} and remove

${FORWARDING_HEADERS_DIR}/JavaScriptCore and
${FORWARDING_HEADERS_DIR}/WebKitLegacy from
WebKitLegacy_INCLUDE_DIRECTORIES.

11:27 AM Changeset in webkit [225138] by commit-queue@webkit.org

• 4 edits
  5 adds in trunk

Captions move when <video> with no controls is hovered
​https://bugs.webkit.org/show_bug.cgi?id=178600
<rdar://problem/35112309>

Patch by Antoine Quint <Antoine Quint> on 2017-11-24
Reviewed by Jer Noble.

Source/WebCore:

We should only reduce the text tracks container height to make room for the controls
bar when controls are enabled.

Tests: media/modern-media-controls/text-tracks/text-tracks-height-no-controls.html

media/modern-media-controls/text-tracks/text-tracks-height-with-controls.html

• Modules/modern-media-controls/controls/text-tracks.css:

(video[controls]::-webkit-media-text-track-container.visible-controls-bar):
(video::-webkit-media-text-track-container.visible-controls-bar): Deleted.

LayoutTests:

We add two tests to check that we correctly reduce the height of the text tracks container
when the controls bar should be visible, and that we do not reduce it when the controls are
not visible.

• media/modern-media-controls/text-tracks/text-tracks-height-no-controls-expected.txt: Added.
• media/modern-media-controls/text-tracks/text-tracks-height-no-controls.html: Added.
• media/modern-media-controls/text-tracks/text-tracks-height-with-controls-expected.txt: Added.
• media/modern-media-controls/text-tracks/text-tracks-height-with-controls.html: Added.
• platform/mac/TestExpectations:

9:26 AM Changeset in webkit [225137] by Simon Fraser

• 41 edits in trunk/Source/WebCore

Some FilterEffect cleanup and logging
​https://bugs.webkit.org/show_bug.cgi?id=179932

Reviewed by Darin Adler.

Rename the FilterEffect functions that get the result of the filter
to have "result" in the name.

Re-order FilterEffect member variables and use initializers. webkit.org/b/45614
is closed so remove the comment about things moving to RenderSVGResourceFilterPrimitive.

Add a virtual filterName() function for use by logging.

Add a Filters log channel. Log some stuff.

Rename RenderSVGResourceFilter::m_filter to m_rendererFilterDataMap.

• platform/Logging.h:
• platform/graphics/cpu/arm/filters/FEBlendNEON.h:

(WebCore::FEBlend::platformApplySoftware):

• platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::platformApplySoftware):

• platform/graphics/filters/FEBlend.h:
• platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

• platform/graphics/filters/FEColorMatrix.h:
• platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::platformApplySoftware):

• platform/graphics/filters/FEComponentTransfer.h:
• platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

• platform/graphics/filters/FEComposite.h:
• platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

• platform/graphics/filters/FEConvolveMatrix.h:
• platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::platformApplySoftware):

• platform/graphics/filters/FEDisplacementMap.h:
• platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

• platform/graphics/filters/FEDropShadow.h:
• platform/graphics/filters/FEFlood.h:
• platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplySoftware):

• platform/graphics/filters/FEGaussianBlur.h:
• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplySoftware):

• platform/graphics/filters/FELighting.h:
• platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::platformApplySoftware):

• platform/graphics/filters/FEMerge.h:
• platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyDegenerate):
(WebCore::FEMorphology::platformApplySoftware):

• platform/graphics/filters/FEMorphology.h:
• platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::platformApplySoftware):

• platform/graphics/filters/FEOffset.h:
• platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

• platform/graphics/filters/FETile.h:
• platform/graphics/filters/FETurbulence.cpp:

(WebCore::operator<<):

• platform/graphics/filters/FETurbulence.h:
• platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::imageBufferResult):
(WebCore::FilterEffect::unmultipliedResult):
(WebCore::FilterEffect::premultipliedResult):
(WebCore::FilterEffect::copyImageBytes const): This can be const. It'a also crazy
to mark a large, slow function like this as 'inline'.
(WebCore::FilterEffect::copyUnmultipliedResult):
(WebCore::FilterEffect::copyPremultipliedResult):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):
(WebCore::FilterEffect::transformResultColorSpace):
(WebCore::FilterEffect::asImageBuffer): Deleted.
(WebCore::FilterEffect::asUnmultipliedImage): Deleted.
(WebCore::FilterEffect::asPremultipliedImage): Deleted.
(WebCore::FilterEffect::copyImageBytes): Deleted.
(WebCore::FilterEffect::copyUnmultipliedImage): Deleted.
(WebCore::FilterEffect::copyPremultipliedImage): Deleted.

• platform/graphics/filters/FilterEffect.h:
• platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::platformApplySoftware):

• platform/graphics/filters/SourceAlpha.h:
• platform/graphics/filters/SourceGraphic.h:
• rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::output const):

• rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::removeAllClientsFromCache):
(WebCore::RenderSVGResourceFilter::removeClientFromCache):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
(WebCore::RenderSVGResourceFilter::drawingRegion const):
(WebCore::operator<<):

• rendering/svg/RenderSVGResourceFilter.h:

(WebCore::FilterData::FilterData): Deleted.

• svg/graphics/filters/SVGFEImage.h:

7:36 AM Changeset in webkit [225136] by Ms2ger@igalia.com

• 4 edits
  1 delete in trunk/LayoutTests

LayoutTests/imported/w3c:
Stop importing css-shapes-1/test-plan/index.html.
​https://bugs.webkit.org/show_bug.cgi?id=168553

Unreviewed test gardening.

It's not a test; there's no good reason to import it.

• resources/import-expectations.json:
• web-platform-tests/css/css-shapes-1/test-plan/index-expected.txt: Removed.
• web-platform-tests/css/css-shapes-1/test-plan/index.html: Removed.
• web-platform-tests/css/css-shapes-1/test-plan/w3c-import.log: Removed.

LayoutTests:
[GTK] Remove reference to css-shapes-1/test-plan/index.html.
​https://bugs.webkit.org/show_bug.cgi?id=168553

Unreviewed test gardening.

• platform/gtk/TestExpectations:

6:23 AM Changeset in webkit [225135] by Ms2ger@igalia.com

• 2 edits in trunk/LayoutTests

[WPE] Update some test expectations
​https://bugs.webkit.org/show_bug.cgi?id=180000

Unreviewed test gardening.

• platform/wpe/TestExpectations:
  • Mark as intermittently passing:
    • animations/negative-delay.html (also noted the bug)
    • fast/canvas/canvas-overflow-hidden-animation.html
    • imported/w3c/i18n/bidi/bidi-plaintext-011.html

• Enable tests fixed in r224580:
  • imported/w3c/IndexedDB-private-browsing/idb_webworkers.html
  • storage/indexeddb/basics-workers.html
  • storage/indexeddb/cursor-advance-workers.html
  • storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers.html
  • storage/indexeddb/dont-commit-on-blocked.html
  • storage/indexeddb/index-basics-workers.html
  • storage/indexeddb/modern/blob-simple-workers.html
  • storage/indexeddb/modern/worker-getall.html
  • storage/indexeddb/modern/workers-enable.html
  • storage/indexeddb/objectstore-basics-workers.html
  • storage/indexeddb/open-twice-workers.html
  • storage/indexeddb/pending-activity-workers.html
  • storage/indexeddb/pending-version-change-on-exit.html
  • storage/indexeddb/pending-version-change-on-exit-private.html
  • storage/indexeddb/pending-version-change-stuck.html
  • storage/indexeddb/pending-version-change-stuck-private.html
  • storage/indexeddb/pending-version-change-stuck-works-with-terminate.html
  • storage/indexeddb/pending-version-change-stuck-works-with-terminate-private.html
  • storage/indexeddb/transaction-complete-workers.html
  • storage/indexeddb/transaction-complete-workers-private.html
  • storage/indexeddb/unprefix-workers.html

• Remove failure expectations for tests that are passing on the bot:
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html: passing since r225060.
  • fast/events/event-view-toString.html: passing since r221858.
  • fast/events/offsetX-offsetY.html: passing since r221858.
  • fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-percent.html: passing since r221858.
  • webgl/1.0.2/conformance/context/context-creation-and-destruction.html: passing since its missing resource was added in r223632.

• Add some passing expectations for tests that are marked as failing in the platform-neutral file:
  • css2.1/20110323/replaced-intrinsic-001.htm: has been passing for a long time; the baseline probably does not reflect the actual pass condition. (The upstream test is claimed to be invalid, and fails in all browsers.)
  • css2.1/20110323/replaced-intrinsic-002.htm: has been passing for a long time; the baseline probably does not reflect the actual pass condition. (The upstream test is claimed to be invalid, and fails in all browsers.)
  • css3/flexbox/csswg/flexbox_flex-natural-mixed-basis-auto.html: passing since r222128.
  • transitions/svg-text-shadow-transition.html: passing since expectation rebaseline in r222084.

6:17 AM Changeset in webkit [225134] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

REGRESSION(r225098): [WPE] Gardening of tests after r225098.

70 new failures after some features changed of value.
Reported on ​https://bugs.webkit.org/show_bug.cgi?id=180004
Remove also 2 duplicated entries on the expectations file.

Unreviewed gardening.

• platform/wpe/TestExpectations:

5:30 AM Changeset in webkit [225133] by graouts@webkit.org

• 7 edits
  2 adds in trunk

[Web Animations] Allow getComputedStyle() to return animated values for accelerated animations
​https://bugs.webkit.org/show_bug.cgi?id=179975
<rdar://problem/35676811>

Reviewed by Dean Jackson.

Source/WebCore:

In case we're running an accelerated animation, we are not blending RenderStyles as the animation
progresses and thus we need to hook into computeRenderStyleForProperty() to query the DocumentTimeline
for the animated style of running accelerated animations where we blend styles manually for the
animation's current time.

Test: http/wpt/wk-web-animations/interfaces/keyframe-effect-getComputedStyle.html

• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::animatedStyleForRenderer): Iterate through all running accelerated animations
for the element to which the provided renderer is attached and ask for their animated styles.

• animation/DocumentTimeline.h:
• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::getAnimatedStyle): Manually blend all animated properties and populate the provided
RenderStyle with their values, creating the RenderStyle if needed.

• animation/KeyframeEffect.h:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::computeRenderStyleForProperty): Query the DocumentTimeline for accelerated animated properties in
case such animations are running, otherwise let the CSS animation controller report the animated values.

LayoutTests:

Add a new test that checks that the computed style of accelerated animation returns the animated value.
This test would fail for the accelerated case prior to this patch.

• http/wpt/wk-web-animations/interfaces/keyframe-effect-getComputedStyle-expected.txt: Added.
• http/wpt/wk-web-animations/interfaces/keyframe-effect-getComputedStyle.html: Added.

5:04 AM Changeset in webkit [225132] by zandobersek@gmail.com

• 6 edits in trunk/Source

[CoordGraphics] CoordinatedGraphicsLayer::updateContentBuffers() should always assume a non-null CoordinatedBuffer
​https://bugs.webkit.org/show_bug.cgi?id=179977

Reviewed by Carlos Garcia Campos.

Source/WebCore:

CoordinatedGraphicsLayer::updateContentBuffers() retrieves a RefPtr<CoordinatedBuffer>
from the CompositingCoordinator. This pointer should never be null since if no
existing UpdateAtlas can provide the necessary memory area, a fresh UpdateAtlas is
created and its buffer returned. This can't fail in theory since the tiles that are
being updated are smaller than the UpdateAtlas area.

The CoordinatedGraphicsLayerClient::getCoordinatedBuffer() method is updated to
always return a Ref<CoordinatedBuffer> value. Code in updateContentBuffers() is
updated to remove a null-check on what is now the Ref<CoordinatedBuffer> value.

No new tests -- no change in functionality.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

Make CompositingCoordinator::getCoordinatedBuffer() return a Ref<CoordinatedBuffer>
value. In case an UpdateAtlas with enough free area is found, its CoordinatedBuffer
is dereferenced into the return value. In case a new UpdateAtlas is created, the
returned CoordinatedBuffer pointer is asserted to be non-null and dereferenced.

The retrieved CoordinatedBuffer pointer on a newly-created UpdateAtlas should never
be null since the tiles are smaller in size than the UpdateAtlas area. The assert
is done in release configurations as well since the code in CoordinatedGraphicsLayer
assumes the returned pointer will be non-null, so it's just a matter of where to
crash first in case somehow a null value is returned.

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::getCoordinatedBuffer):

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

3:27 AM Changeset in webkit [225131] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebKit

[CoordGraphics] UpdateAtlas constructor should receive an IntSize, not a dimension value
​https://bugs.webkit.org/show_bug.cgi?id=179976

Reviewed by Carlos Garcia Campos.

Have the UpdateAtlas constructor receive an IntSize object that specifies
the desired size for the CoordinatedBuffer. Passing in a dimension doesn't
really make sense since this value isn't dynamically configurable, and
the only value that is passed in is already a power-of-two.

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::getCoordinatedBuffer):

• WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):

• WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

3:04 AM Changeset in webkit [225130] by Yusuke Suzuki

• 5 edits in trunk/Source/JavaScriptCore

[JSC] Make empty key as deleted mark in HashMapBucket and drop m_deleted field
​https://bugs.webkit.org/show_bug.cgi?id=179923

Reviewed by Darin Adler.

We do not set empty as a key in HashMapBucket since JSMap / JSSet can expose it to users.
So we can use it as a marker of deleted bucket.

This patch uses empty key as a deleted flag, and drop m_deleted field of HashMapBucket.
It shrinks the size of HashMapBucket much.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetMapBucketNext):

• ftl/FTLAbstractHeapRepository.h:
• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucketNext):

• runtime/HashMapImpl.h:

(JSC::HashMapBucket::createSentinel):
We make sentinel bucket as (undefined, undefined) since DFG/FTL can load a value from sentinels.
While the sentinel's deleted flag becomes false since key is set, it is not a problem since deleted
flag of sentinel bucket is not used.

(JSC::HashMapBucket::HashMapBucket):
(JSC::HashMapBucket::deleted const):
(JSC::HashMapBucket::makeDeleted):
(JSC::HashMapImpl::remove):
(JSC::HashMapImpl::clear):
(JSC::HashMapImpl::setUpHeadAndTail):
(JSC::HashMapImpl::addNormalizedInternal):
(JSC::HashMapBucket::setDeleted): Deleted.
(JSC::HashMapBucket::offsetOfDeleted): Deleted.
(): Deleted.

2:58 AM Changeset in webkit [225129] by mark.lam@apple.com

• 113 edits in trunk

Move unsafe jsc shell test functions to the $vm object.
​https://bugs.webkit.org/show_bug.cgi?id=179980

Reviewed by Yusuke Suzuki.

JSTests:

• controlFlowProfiler/driver/driver.js:
• controlFlowProfiler/execution-count.js:
• controlFlowProfiler/if-statement.js:
• controlFlowProfiler/loop-statements.js:
• controlFlowProfiler/switch-statements.js:
• controlFlowProfiler/test-jit.js:
• exceptionFuzz/3d-cube.js:
• exceptionFuzz/date-format-xparb.js:
• exceptionFuzz/earley-boyer.js:
• heapProfiler/basic-edges.js:
• heapProfiler/property-edge-types.js:
• microbenchmarks/try-get-by-id-basic.js:
• microbenchmarks/try-get-by-id-polymorphic.js:
• modules/namespace-object-try-get.js:
• stress/argument-count-bytecode.js:
• stress/argument-intrinsic-basic.js:
• stress/argument-intrinsic-inlining-use-caller-arg.js:
• stress/argument-intrinsic-inlining-with-result-escape.js:
• stress/argument-intrinsic-inlining-with-vararg-with-enough-arguments.js:
• stress/argument-intrinsic-inlining-with-vararg.js:
• stress/argument-intrinsic-nested-inlining.js:
• stress/argument-intrinsic-not-convert-to-get-argument.js:
• stress/argument-intrinsic-with-stack-write.js:
• stress/arity-mismatch-get-argument.js:
• stress/array-message-passing.js:
• stress/array-push-with-force-exit.js:
• stress/check-dom-with-signature.js:
• stress/check-sub-class.js:
• stress/compare-eq-incomplete-profile.js:
• stress/custom-get-set-inline-caching-one-level-up-proto-chain.js:
• stress/do-eval-virtual-call-correctly.js:
• stress/dom-jit-with-poly-proto.js:
• stress/domjit-exception-ic.js:
• stress/domjit-exception.js:
• stress/domjit-getter-complex-with-incorrect-object.js:
• stress/domjit-getter-complex.js:
• stress/domjit-getter-poly.js:
• stress/domjit-getter-proto.js:
• stress/domjit-getter-super-poly.js:
• stress/domjit-getter-try-catch-getter-as-get-by-id-register-restoration.js:
• stress/domjit-getter-type-check.js:
• stress/domjit-getter.js:
• stress/exit-during-inlined-arity-fixup-recover-proper-frame.js:
• stress/for-in-proxy-target-changed-structure.js:
• stress/for-in-proxy.js:
• stress/generational-opaque-roots.js:
• stress/global-const-redeclaration-setting-2.js:
• stress/global-const-redeclaration-setting-3.js:
• stress/global-const-redeclaration-setting-4.js:
• stress/global-const-redeclaration-setting-5.js:
• stress/global-const-redeclaration-setting.js:
• stress/import-basic.js:
• stress/import-from-eval.js:
• stress/import-reject-with-exception.js:
• stress/import-syntax.js:
• stress/impure-get-own-property-slot-inline-cache.js:
• stress/is-constructor.js:
• stress/istypedarrayview-intrinsic.js:
• stress/jsc-setImpureGetterDelegate-on-bad-type.js:
• stress/jsc-test-functions-should-be-more-robust.js:
• stress/object-toString-with-proxy.js:
• stress/poly-proto-custom-value-and-accessor.js:
• stress/proxy-inline-cache.js:
• stress/re-execute-error-module.js:
• stress/regress-150532.js:
• stress/regress-156992.js:
• stress/regress-179619.js:
• stress/resources/shadow-chicken-support.js:
• stress/runtime-array.js:
• stress/sampling-profiler-microtasks.js:
• stress/shadow-chicken-enabled.js:
• stress/spread-correct-global-object-on-exception.js:
• stress/super-get-by-id.js:
• stress/tailCallForwardArguments.js:
• stress/to-object-intrinsic-boolean-edge.js:
• stress/to-object-intrinsic-null-or-undefined-edge.js:
• stress/to-object-intrinsic-number-edge.js:
• stress/to-object-intrinsic-object-edge.js:
• stress/to-object-intrinsic-string-edge.js:
• stress/to-object-intrinsic-symbol-edge.js:
• stress/to-object-intrinsic.js:
• stress/try-catch-custom-getter-as-get-by-id.js:
• stress/try-get-by-id-poly-proto.js:
• stress/try-get-by-id-should-spill-registers-dfg.js:
• stress/try-get-by-id.js:
• typeProfiler/arrow-functions.js:
• typeProfiler/basic.js:
• typeProfiler/captured.js:
• typeProfiler/classes.js:
• typeProfiler/dfg-jit-optimizations.js:
• typeProfiler/dictionary-mode.js:
• typeProfiler/es6-block-scoping.js:
• typeProfiler/es6-classes.js:
• typeProfiler/inheritance.js:
• typeProfiler/int52-dfg.js:
• typeProfiler/loop.js:
• typeProfiler/optional-fields.js:
• typeProfiler/overflow.js:
• typeProfiler/return.js:
• typeProfiler/symbol.js:
• typeProfiler/weird-prototype-chain.js:

Source/JavaScriptCore:

Also removed setElementRoot() which was not used.

• jsc.cpp:

(GlobalObject::finishCreation):
(WTF::Element::Element): Deleted.
(WTF::Element::root const): Deleted.
(WTF::Element::setRoot): Deleted.
(WTF::Element::create): Deleted.
(WTF::Element::visitChildren): Deleted.
(WTF::Element::createStructure): Deleted.
(WTF::Root::Root): Deleted.
(WTF::Root::element): Deleted.
(WTF::Root::setElement): Deleted.
(WTF::Root::create): Deleted.
(WTF::Root::createStructure): Deleted.
(WTF::Root::visitChildren): Deleted.
(WTF::ImpureGetter::ImpureGetter): Deleted.
(WTF::ImpureGetter::createStructure): Deleted.
(WTF::ImpureGetter::create): Deleted.
(WTF::ImpureGetter::finishCreation): Deleted.
(WTF::ImpureGetter::getOwnPropertySlot): Deleted.
(WTF::ImpureGetter::visitChildren): Deleted.
(WTF::ImpureGetter::setDelegate): Deleted.
(WTF::CustomGetter::CustomGetter): Deleted.
(WTF::CustomGetter::createStructure): Deleted.
(WTF::CustomGetter::create): Deleted.
(WTF::CustomGetter::getOwnPropertySlot): Deleted.
(WTF::CustomGetter::customGetter): Deleted.
(WTF::CustomGetter::customGetterAcessor): Deleted.
(WTF::RuntimeArray::create): Deleted.
(WTF::RuntimeArray::~RuntimeArray): Deleted.
(WTF::RuntimeArray::destroy): Deleted.
(WTF::RuntimeArray::getOwnPropertySlot): Deleted.
(WTF::RuntimeArray::getOwnPropertySlotByIndex): Deleted.
(WTF::RuntimeArray::put): Deleted.
(WTF::RuntimeArray::deleteProperty): Deleted.
(WTF::RuntimeArray::getLength const): Deleted.
(WTF::RuntimeArray::createPrototype): Deleted.
(WTF::RuntimeArray::createStructure): Deleted.
(WTF::RuntimeArray::finishCreation): Deleted.
(WTF::RuntimeArray::RuntimeArray): Deleted.
(WTF::RuntimeArray::lengthGetter): Deleted.
(WTF::SimpleObject::SimpleObject): Deleted.
(WTF::SimpleObject::create): Deleted.
(WTF::SimpleObject::visitChildren): Deleted.
(WTF::SimpleObject::createStructure): Deleted.
(WTF::SimpleObject::hiddenValue): Deleted.
(WTF::SimpleObject::setHiddenValue): Deleted.
(WTF::DOMJITNode::DOMJITNode): Deleted.
(WTF::DOMJITNode::createStructure): Deleted.
(WTF::DOMJITNode::checkSubClassSnippet): Deleted.
(WTF::DOMJITNode::create): Deleted.
(WTF::DOMJITNode::value const): Deleted.
(WTF::DOMJITNode::offsetOfValue): Deleted.
(WTF::DOMJITGetter::DOMJITGetter): Deleted.
(WTF::DOMJITGetter::createStructure): Deleted.
(WTF::DOMJITGetter::create): Deleted.
(WTF::DOMJITGetter::DOMJITAttribute::DOMJITAttribute): Deleted.
(WTF::DOMJITGetter::DOMJITAttribute::slowCall): Deleted.
(WTF::DOMJITGetter::DOMJITAttribute::callDOMGetter): Deleted.
(WTF::DOMJITGetter::customGetter): Deleted.
(WTF::DOMJITGetter::finishCreation): Deleted.
(WTF::DOMJITGetterComplex::DOMJITGetterComplex): Deleted.
(WTF::DOMJITGetterComplex::createStructure): Deleted.
(WTF::DOMJITGetterComplex::create): Deleted.
(WTF::DOMJITGetterComplex::DOMJITAttribute::DOMJITAttribute): Deleted.
(WTF::DOMJITGetterComplex::DOMJITAttribute::slowCall): Deleted.
(WTF::DOMJITGetterComplex::DOMJITAttribute::callDOMGetter): Deleted.
(WTF::DOMJITGetterComplex::functionEnableException): Deleted.
(WTF::DOMJITGetterComplex::customGetter): Deleted.
(WTF::DOMJITGetterComplex::finishCreation): Deleted.
(WTF::DOMJITFunctionObject::DOMJITFunctionObject): Deleted.
(WTF::DOMJITFunctionObject::createStructure): Deleted.
(WTF::DOMJITFunctionObject::create): Deleted.
(WTF::DOMJITFunctionObject::safeFunction): Deleted.
(WTF::DOMJITFunctionObject::unsafeFunction): Deleted.
(WTF::DOMJITFunctionObject::checkSubClassSnippet): Deleted.
(WTF::DOMJITFunctionObject::finishCreation): Deleted.
(WTF::DOMJITCheckSubClassObject::DOMJITCheckSubClassObject): Deleted.
(WTF::DOMJITCheckSubClassObject::createStructure): Deleted.
(WTF::DOMJITCheckSubClassObject::create): Deleted.
(WTF::DOMJITCheckSubClassObject::safeFunction): Deleted.
(WTF::DOMJITCheckSubClassObject::unsafeFunction): Deleted.
(WTF::DOMJITCheckSubClassObject::finishCreation): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITGetterBaseJSObject): Deleted.
(WTF::DOMJITGetterBaseJSObject::createStructure): Deleted.
(WTF::DOMJITGetterBaseJSObject::create): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::DOMJITAttribute): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::slowCall): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::callDOMGetter): Deleted.
(WTF::DOMJITGetterBaseJSObject::customGetter): Deleted.
(WTF::DOMJITGetterBaseJSObject::finishCreation): Deleted.
(WTF::Element::handleOwner): Deleted.
(WTF::Element::finishCreation): Deleted.
(JSTestCustomGetterSetter::JSTestCustomGetterSetter): Deleted.
(JSTestCustomGetterSetter::create): Deleted.
(JSTestCustomGetterSetter::createStructure): Deleted.
(customGetAccessor): Deleted.
(customGetValue): Deleted.
(customSetAccessor): Deleted.
(customSetValue): Deleted.
(JSTestCustomGetterSetter::finishCreation): Deleted.
(GlobalObject::addConstructableFunction): Deleted.
(functionCreateRoot): Deleted.
(functionCreateElement): Deleted.
(functionGetElement): Deleted.
(functionSetElementRoot): Deleted.
(functionCreateSimpleObject): Deleted.
(functionGetHiddenValue): Deleted.
(functionSetHiddenValue): Deleted.
(functionCreateProxy): Deleted.
(functionCreateRuntimeArray): Deleted.
(functionCreateImpureGetter): Deleted.
(functionCreateCustomGetterObject): Deleted.
(functionCreateDOMJITNodeObject): Deleted.
(functionCreateDOMJITGetterObject): Deleted.
(functionCreateDOMJITGetterComplexObject): Deleted.
(functionCreateDOMJITFunctionObject): Deleted.
(functionCreateDOMJITCheckSubClassObject): Deleted.
(functionCreateDOMJITGetterBaseJSObject): Deleted.
(functionSetImpureGetterDelegate): Deleted.
(functionGetGetterSetter): Deleted.
(functionShadowChickenFunctionsOnStack): Deleted.
(functionSetGlobalConstRedeclarationShouldNotThrow): Deleted.
(functionGlobalObjectForObject): Deleted.
(functionLoadGetterFromGetterSetter): Deleted.
(functionCreateCustomTestGetterSetter): Deleted.
(functionAbort): Deleted.
(functionFindTypeForExpression): Deleted.
(functionReturnTypeFor): Deleted.
(functionDumpBasicBlockExecutionRanges): Deleted.
(functionHasBasicBlockExecuted): Deleted.
(functionBasicBlockExecutionCount): Deleted.
(functionEnableExceptionFuzz): Deleted.
(functionCreateBuiltin): Deleted.

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• tools/JSDollarVM.cpp:

(WTF::Element::Element):
(WTF::Element::root const):
(WTF::Element::setRoot):
(WTF::Element::create):
(WTF::Element::visitChildren):
(WTF::Element::createStructure):
(WTF::Root::Root):
(WTF::Root::element):
(WTF::Root::setElement):
(WTF::Root::create):
(WTF::Root::createStructure):
(WTF::Root::visitChildren):
(WTF::SimpleObject::SimpleObject):
(WTF::SimpleObject::create):
(WTF::SimpleObject::visitChildren):
(WTF::SimpleObject::createStructure):
(WTF::SimpleObject::hiddenValue):
(WTF::SimpleObject::setHiddenValue):
(WTF::ImpureGetter::ImpureGetter):
(WTF::ImpureGetter::createStructure):
(WTF::ImpureGetter::create):
(WTF::ImpureGetter::finishCreation):
(WTF::ImpureGetter::getOwnPropertySlot):
(WTF::ImpureGetter::visitChildren):
(WTF::ImpureGetter::setDelegate):
(WTF::CustomGetter::CustomGetter):
(WTF::CustomGetter::createStructure):
(WTF::CustomGetter::create):
(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetter):
(WTF::CustomGetter::customGetterAcessor):
(WTF::RuntimeArray::create):
(WTF::RuntimeArray::~RuntimeArray):
(WTF::RuntimeArray::destroy):
(WTF::RuntimeArray::getOwnPropertySlot):
(WTF::RuntimeArray::getOwnPropertySlotByIndex):
(WTF::RuntimeArray::put):
(WTF::RuntimeArray::deleteProperty):
(WTF::RuntimeArray::getLength const):
(WTF::RuntimeArray::createPrototype):
(WTF::RuntimeArray::createStructure):
(WTF::RuntimeArray::finishCreation):
(WTF::RuntimeArray::RuntimeArray):
(WTF::RuntimeArray::lengthGetter):
(WTF::DOMJITNode::DOMJITNode):
(WTF::DOMJITNode::createStructure):
(WTF::DOMJITNode::checkSubClassSnippet):
(WTF::DOMJITNode::create):
(WTF::DOMJITNode::value const):
(WTF::DOMJITNode::offsetOfValue):
(WTF::DOMJITGetter::DOMJITGetter):
(WTF::DOMJITGetter::createStructure):
(WTF::DOMJITGetter::create):
(WTF::DOMJITGetter::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetter::DOMJITAttribute::slowCall):
(WTF::DOMJITGetter::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetter::customGetter):
(WTF::DOMJITGetter::finishCreation):
(WTF::DOMJITGetterComplex::DOMJITGetterComplex):
(WTF::DOMJITGetterComplex::createStructure):
(WTF::DOMJITGetterComplex::create):
(WTF::DOMJITGetterComplex::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetterComplex::DOMJITAttribute::slowCall):
(WTF::DOMJITGetterComplex::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetterComplex::functionEnableException):
(WTF::DOMJITGetterComplex::customGetter):
(WTF::DOMJITGetterComplex::finishCreation):
(WTF::DOMJITFunctionObject::DOMJITFunctionObject):
(WTF::DOMJITFunctionObject::createStructure):
(WTF::DOMJITFunctionObject::create):
(WTF::DOMJITFunctionObject::safeFunction):
(WTF::DOMJITFunctionObject::unsafeFunction):
(WTF::DOMJITFunctionObject::checkSubClassSnippet):
(WTF::DOMJITFunctionObject::finishCreation):
(WTF::DOMJITCheckSubClassObject::DOMJITCheckSubClassObject):
(WTF::DOMJITCheckSubClassObject::createStructure):
(WTF::DOMJITCheckSubClassObject::create):
(WTF::DOMJITCheckSubClassObject::safeFunction):
(WTF::DOMJITCheckSubClassObject::unsafeFunction):
(WTF::DOMJITCheckSubClassObject::finishCreation):
(WTF::DOMJITGetterBaseJSObject::DOMJITGetterBaseJSObject):
(WTF::DOMJITGetterBaseJSObject::createStructure):
(WTF::DOMJITGetterBaseJSObject::create):
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::slowCall):
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetterBaseJSObject::customGetter):
(WTF::DOMJITGetterBaseJSObject::finishCreation):
(WTF::Message::releaseContents):
(WTF::Message::index const):
(WTF::JSTestCustomGetterSetter::JSTestCustomGetterSetter):
(WTF::JSTestCustomGetterSetter::create):
(WTF::JSTestCustomGetterSetter::createStructure):
(WTF::customGetAccessor):
(WTF::customGetValue):
(WTF::customSetAccessor):
(WTF::customSetValue):
(WTF::JSTestCustomGetterSetter::finishCreation):
(WTF::Element::handleOwner):
(WTF::Element::finishCreation):
(JSC::functionCrash):
(JSC::functionCreateProxy):
(JSC::functionCreateRuntimeArray):
(JSC::functionCreateImpureGetter):
(JSC::functionCreateCustomGetterObject):
(JSC::functionCreateDOMJITNodeObject):
(JSC::functionCreateDOMJITGetterObject):
(JSC::functionCreateDOMJITGetterComplexObject):
(JSC::functionCreateDOMJITFunctionObject):
(JSC::functionCreateDOMJITCheckSubClassObject):
(JSC::functionCreateDOMJITGetterBaseJSObject):
(JSC::functionSetImpureGetterDelegate):
(JSC::functionCreateBuiltin):
(JSC::functionCreateRoot):
(JSC::functionCreateElement):
(JSC::functionGetElement):
(JSC::functionCreateSimpleObject):
(JSC::functionGetHiddenValue):
(JSC::functionSetHiddenValue):
(JSC::functionShadowChickenFunctionsOnStack):
(JSC::functionSetGlobalConstRedeclarationShouldNotThrow):
(JSC::functionFindTypeForExpression):
(JSC::functionReturnTypeFor):
(JSC::functionDumpBasicBlockExecutionRanges):
(JSC::functionHasBasicBlockExecuted):
(JSC::functionBasicBlockExecutionCount):
(JSC::functionEnableExceptionFuzz):
(JSC::functionGlobalObjectForObject):
(JSC::functionGetGetterSetter):
(JSC::functionLoadGetterFromGetterSetter):
(JSC::functionCreateCustomTestGetterSetter):
(JSC::JSDollarVM::finishCreation):
(JSC::JSDollarVM::addFunction):
(JSC::JSDollarVM::addConstructibleFunction):

• tools/JSDollarVM.h:

(JSC::JSDollarVM::create):

Tools:

Always set --useDollarVM=true for jsc runs of benchmarks. This is needed because
some microbenchmarks relies on createBuiltin().

Also set --useDollarVM=true for runExceptionFuzz and runExecutableAllocationFuzz.

• Scripts/run-jsc-benchmarks:
• Scripts/run-jsc-stress-tests:

LayoutTests:

• js/script-tests/stack-trace.js:
• js/stack-trace-expected.txt:

1:45 AM Changeset in webkit [225128] by graouts@webkit.org

• 9 edits
  8 adds in trunk

Source/WebCore:
[Web Animations] Perform accelerated animations when possible
​https://bugs.webkit.org/show_bug.cgi?id=179973
<rdar://problem/34953922>

Reviewed by Dean Jackson.

When we're entering and leaving the active duration of an animation effect, we now check
whether the animation can be accelerated, using the existing CSSPropertyAnimation::animationOfPropertyIsAccelerated()
utility, and start and stop animations using the startAnimation() and animationFinished() functions on RenderBoxModelObject.

This patch is only a first step towards full support for accelerated animations,
there are two known issues at the moment. Because we're not blending the styles to perform
the animation, getComputedStyle() will not return the animated value (webkit.org/b/179974).
Additionally, if other animations happen to run later during the active state of an animation
that can run accelerated, we will not fall back to software-only animation for this
element and these animations will appear not to run (webkit.org/b/179975). These will be
addressed in follow-up patches.

Tests: webanimations/left-and-opacity-animation-yields-no-compositing.html

webanimations/opacity-animation-no-longer-composited-upon-completion.html
webanimations/opacity-animation-yields-compositing.html
webanimations/width-and-opacity-separate-animation-yields-no-compositing.html

• animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::updateAnimations): Check in the map of pending accelerated animations
to see if any animation requires toggling their active state after their styles have been invalidated.
(WebCore::DocumentTimeline::animationAcceleratedRunningStateDidChange): New function to
let animations indicate that they need to have their accelerated backing animation toggled after
style invalidation has been completed.
(WebCore::DocumentTimeline::runningAnimationsForElementAreAllAccelerated): This function is used
in RenderLayerCompositor::requiresCompositingForAnimation() to identify whether an element requires
hardware compositing due to running accelerated animations. We check all running animations for the
provided element to see if they can all be running accelerated and return true in this situation only.

• animation/DocumentTimeline.h:
• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::applyAtLocalTime): Identify if we're crossing into or out of the active state
for an animation and check if it will be or has been running accelerated such that we can notify the
DocumentTimeline, through the associated animation, that the accelerated backing animation will need to
be toggled after style invalidation has been completed.
(WebCore::KeyframeEffect::shouldRunAccelerated): Check that all properties for this animation
effect can be accelerated according to CSSPropertyAnimation::animationOfPropertyIsAccelerated().
(WebCore::KeyframeEffect::startOrStopAccelerated): Start or stop the associated accelerated
animation through the associated element's RenderBoxModelObject renderer.

• animation/KeyframeEffect.h:
• animation/WebAnimation.cpp:

(WebCore::WebAnimation::acceleratedRunningStateDidChange): Called from AnimationEffect::applyAtLocalTime(),
we forward to the DocumentTimeline the information that the animation will cross an active state boundary while
allowing to be backed by hardware compositing.
(WebCore::WebAnimation::startOrStopAccelerated): Forward to the associated KeyframeEffect that accelerated
animation backing should be toggled.

• animation/WebAnimation.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const): Check via the renderer's element's
DocumentTimeline that all running animations for this particular element are accelerated to ensure that
the element will be hardware-composited.

LayoutTests:
[Web Animations] Perform hardware-composited animations when possible
​https://bugs.webkit.org/show_bug.cgi?id=179973
<rdar://problem/34953922>

Reviewed by Dean Jackson.

Add a series of tests to check that we use hardware-compositing for animations when possible.
Specifically, we check that:

1. Specifying both accelerated and non-accelerated properties for a single animation does *not*

yield hardware compositing (left-and-opacity-animation-yields-no-compositing.html).

2. Specifying both accelerated and non-accelerated properties via multiple animations does *not*

yield hardware compositing (width-and-opacity-separate-animation-yields-no-compositing.html).

3. Specifying only accelerated properties *does* yield hardware compositing

(opacity-animation-yields-compositing.html).

4. Hardware-composited animations no longer enforce hardware compositing after their completion

(opacity-animation-no-longer-composited-upon-completion.html).

• webanimations/left-and-opacity-animation-yields-no-compositing-expected.txt: Added.
• webanimations/left-and-opacity-animation-yields-no-compositing.html: Added.
• webanimations/opacity-animation-no-longer-composited-upon-completion-expected.txt: Added.
• webanimations/opacity-animation-no-longer-composited-upon-completion.html: Added.
• webanimations/opacity-animation-yields-compositing-expected.txt: Added.
• webanimations/opacity-animation-yields-compositing.html: Added.
• webanimations/width-and-opacity-separate-animation-yields-no-compositing-expected.txt: Added.
• webanimations/width-and-opacity-separate-animation-yields-no-compositing.html: Added.

Nov 23, 2017:

9:39 PM Changeset in webkit [225127] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Win] PasteboardWin.cpp(653): error C2039: 'containsOnlyASCII': is not a member of 'WTF::String'
​https://bugs.webkit.org/show_bug.cgi?id=179991

Unreviewed build fix.

No new tests (No behaviour change).

Patch by Fujii Hironori <Fujii Hironori> on 2017-11-23

• platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeURLToDataObject): Renamed containsOnlyASCII() to isAllASCII().

5:36 PM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com

(diff)

5:25 PM Changeset in webkit [225126] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

REGRESSION(r225098): [GTK] Gardening of tests after r225098.
​https://bugs.webkit.org/show_bug.cgi?id=179989

Unreviewed.

Mark new expected failures meanwhile the issue is not fixed.

• platform/gtk/TestExpectations:

4:47 PM Changeset in webkit [225125] by fpizlo@apple.com

• 10 edits
  1 add in trunk/Source/bmalloc

Isolated Heaps caused an increase in reported leaks on the bots
​https://bugs.webkit.org/show_bug.cgi?id=179463

Reviewed by Darin Adler.

This fixes the way isoheaps interact with system tools:

• Opts into the VMHeap API so that the leaks tool can find isoheap memory.

• Opts into the DebugHeap/Environment APIs so that we turn off isoheap allocation if memory debugging options are in use.

• bmalloc.xcodeproj/project.pbxproj:
• bmalloc/DebugHeap.h:
• bmalloc/IsoHeap.h:
• bmalloc/IsoPage.cpp: Added.

(bmalloc::IsoPageBase::allocatePageMemory):

• bmalloc/IsoPage.h:
• bmalloc/IsoPageInlines.h:

(bmalloc::IsoPage<Config>::tryCreate):

• bmalloc/IsoTLS.cpp:

(bmalloc::IsoTLS::deallocateSlow):
(bmalloc::IsoTLS::ensureEntries):
(bmalloc::IsoTLS::isUsingDebugHeap):
(bmalloc::IsoTLS::debugMalloc):

• bmalloc/IsoTLS.h:
• bmalloc/IsoTLSInlines.h:

(bmalloc::IsoTLS::allocate):
(bmalloc::IsoTLS::deallocate):
(bmalloc::IsoTLS::allocateImpl):
(bmalloc::IsoTLS::allocateFast):
(bmalloc::IsoTLS::allocateSlow):
(bmalloc::IsoTLS::deallocateImpl):
(bmalloc::IsoTLS::deallocateFast):
(bmalloc::IsoTLS::ensureHeapAndEntries):
(bmalloc::IsoTLS::allocator): Deleted.
(bmalloc::IsoTLS::deallocator): Deleted.

• bmalloc/bmalloc.cpp:

(bmalloc::api::tryLargeMemalignVirtual):
(bmalloc::api::freeLargeVirtual):
(bmalloc::api::scavenge):
(bmalloc::api::isEnabled):
(bmalloc::api::setScavengerThreadQOSClass):

• bmalloc/bmalloc.h:

(bmalloc::api::tryLargeMemalignVirtual): Deleted.
(bmalloc::api::freeLargeVirtual): Deleted.
(bmalloc::api::scavenge): Deleted.
(bmalloc::api::isEnabled): Deleted.
(bmalloc::api::setScavengerThreadQOSClass): Deleted.

4:35 PM Changeset in webkit [225124] by clopez@igalia.com

• 2 edits in trunk/Source/WebCore

[GTK] [Debug] Fix build after r225117.
​https://bugs.webkit.org/show_bug.cgi?id=179907

Unreviewed build fix.

r225117 renamed containsOnlyASCII() to isAllASCII().
And this reference was not updated for the GTK Debug build.

No new tests, its a build fix.

• loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

2:23 PM Changeset in webkit [225123] by Simon Fraser

• 2 edits in trunk/Source/JavaScriptCore

Minor ArrayBufferView cleanup
​https://bugs.webkit.org/show_bug.cgi?id=179966

Reviewed by Darin Adler.

Use void* for data pointers when we don't need to do offset math. Use const for
source pointers.

Prefer uint8_t* to char*.

Add comments noting that the assertions should not be made release assertions
as recommended by the style checker, since the point is to avoid the virtual byteLength()
call in release.

• runtime/ArrayBufferView.h:

(JSC::ArrayBufferView::setImpl):
(JSC::ArrayBufferView::setRangeImpl):
(JSC::ArrayBufferView::getRangeImpl):
(JSC::ArrayBufferView::zeroRangeImpl):

2:20 PM Changeset in webkit [225122] by Simon Fraser

• 11 edits in trunk/Source/WebCore

FELighting cleanup and optimization
​https://bugs.webkit.org/show_bug.cgi?id=179933

Reviewed by Darin Adler.

Make FELighting about 25% faster by maintaining an "alpha" window of the alpha
values of the 9 pixels surrounding the current pixel, and sliding this window over
when moving to the next pixel. This avoids reading the same alpha values from the original
buffer multiple times.

Clean up LightSource and subclasses, adding SPECIALIZE_TYPE_TRAITS macros,
and turning updatePaintingData() into a function with no side effects that returns
the required data.

Remove explicit 'inline' keywords, allowing the compiler to make inlining decisions.

• platform/graphics/cpu/arm/filters/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon):

• platform/graphics/filters/DistantLightSource.cpp:

(WebCore::DistantLightSource::initPaintingData):
(WebCore::DistantLightSource::computePixelLightingData const):
(WebCore::DistantLightSource::updatePaintingData): Deleted.

• platform/graphics/filters/DistantLightSource.h:
• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::LightingData::interiorNormal const):
(WebCore::FELighting::setPixel):
(WebCore::FELighting::setPixelInternal):
(WebCore::FELighting::platformApplyGenericPaint):
(WebCore::FELighting::platformApplyGeneric):
(WebCore::FELighting::platformApply):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::inlineSetPixel): Deleted.

• platform/graphics/filters/FELighting.h:

(WebCore::FELighting::AlphaWindow::topLeft const):
(WebCore::FELighting::AlphaWindow::left const):
(WebCore::FELighting::AlphaWindow::bottomLeft const):
(WebCore::FELighting::AlphaWindow::top const):
(WebCore::FELighting::AlphaWindow::center const):
(WebCore::FELighting::AlphaWindow::bottom const):
(WebCore::FELighting::AlphaWindow::setTop):
(WebCore::FELighting::AlphaWindow::setCenter):
(WebCore::FELighting::AlphaWindow::setBottom):
(WebCore::FELighting::AlphaWindow::setTopRight):
(WebCore::FELighting::AlphaWindow::setRight):
(WebCore::FELighting::AlphaWindow::setBottomRight):
(WebCore::FELighting::AlphaWindow::shiftRow):
(WebCore::FELighting::AlphaWindow::shift):

• platform/graphics/filters/LightSource.h:
• platform/graphics/filters/PointLightSource.cpp:

(WebCore::PointLightSource::computePixelLightingData const):
(WebCore::PointLightSource::updatePaintingData): Deleted.

• platform/graphics/filters/PointLightSource.h:
• platform/graphics/filters/SpotLightSource.cpp:

(WebCore::SpotLightSource::initPaintingData):
(WebCore::SpotLightSource::computePixelLightingData const):
(WebCore::SpotLightSource::updatePaintingData): Deleted.

• platform/graphics/filters/SpotLightSource.h:

1:33 PM Changeset in webkit [225121] by Simon Fraser

• 9 edits
  2 copies
  1 move in trunk

Add support for CanvasPattern.setTransform()
​https://bugs.webkit.org/show_bug.cgi?id=179935

Reviewed by Sam Weinig.

Source/WebCore:

Add support for setTransform() on CanvasPattern, per
<​https://html.spec.whatwg.org/multipage/canvas.html#dom-canvaspattern-settransform>
It uses [MayThrowException] since the "validate and fixup" steps for DOMMatrix can throw
an exception.

Under the hood, the transform is just pushed onto Pattern as the patternSpaceTransform().

Minor cleanup in Pattern.

Test: fast/canvas/canvas-pattern-with-transform.html

• html/canvas/CanvasPattern.cpp:

(WebCore::CanvasPattern::setTransform):

• html/canvas/CanvasPattern.h:
• html/canvas/CanvasPattern.idl:
• platform/graphics/Pattern.h:

LayoutTests:

Moved the test previously known as canvas-pattern-transform.html to canvas-pattern-with-transform.html
and added a new test.

• fast/canvas/canvas-pattern-transform-expected.txt:
• fast/canvas/canvas-pattern-transform.html:
• fast/canvas/canvas-pattern-with-transform-expected.txt: Copied from LayoutTests/fast/canvas/canvas-pattern-transform-expected.txt.
• fast/canvas/canvas-pattern-with-transform.html: Copied from LayoutTests/fast/canvas/canvas-pattern-transform.html.
• fast/canvas/canvas-pattern-with-transform.js: Renamed from LayoutTests/fast/canvas/canvas-pattern-transform.js.

11:36 AM Changeset in webkit [225120] by commit-queue@webkit.org

• 20 edits in trunk/Source

Remove unneeded ScriptController::processingUserGesture() forwarding functions
​https://bugs.webkit.org/show_bug.cgi?id=179954

Patch by Sam Weinig <​sam@webkit.org> on 2017-11-23
Reviewed by Darin Adler.

Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
with direct calls to the corresponding UserGestureIndicator functions.

Source/WebCore:

• Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::create):
(WebCore::ApplePaySession::openPaymentSetup):

• Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::speak):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::processingUserGesture): Deleted.
(WebCore::ScriptController::processingUserGestureForMedia): Deleted.

• bindings/js/ScriptController.h:
• dom/Document.cpp:

(WebCore::Document::processingUserGestureForMedia const):

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):

• html/ColorInputType.cpp:

(WebCore::ColorInputType::handleDOMActivateEvent):

• html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::submitFromJavaScript):

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::shouldOpenExternalURLsPolicyToApply):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::allowPopUp):
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):

• page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):

Source/WebKit:

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::isProcessingUserGesture):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::addResourceRequest):

Source/WebKitLegacy/mac:

• Plugins/WebPluginController.mm:

(-[WebPluginController processingUserGesture]):

• WebView/WebView.mm:

(-[WebView _isProcessingUserGesture]):

11:00 AM Changeset in webkit [225119] by dino@apple.com

• 14 edits in trunk/Source/WebCore

Add a base class for HTMLCanvasElement and OffscreenCanvas
​https://bugs.webkit.org/show_bug.cgi?id=179701
<rdar://problem/35545195>

Post-review updates from Darin Adler review.

• html/CanvasBase.cpp:

(WebCore::CanvasBase::asHTMLCanvasElement): Deleted. Replaced by having the call
sites get the reference and do the correct downcast<>.

• html/CanvasBase.h: Remove asHTMLCanvasElement. Add pure virtual ref/deref functions

so they can be overridden by subclasses. Unfortunately they can't be called ref/deref otherwise
they conflict with Node.

• html/HTMLCanvasElement.h: Add the type traits, so is<HTMLCanvasElement>(canvasBase) will

work.

• html/HTMLTagNames.in: Specify the <canvas> element as having custom type traits.
• html/OffscreenCanvas.h: Lots of overrides to finals.
• html/canvas/CanvasRenderingContext.cpp: Use canvasBase.de/refCanvasBase rather than

casting.
(WebCore::CanvasRenderingContext::ref):
(WebCore::CanvasRenderingContext::deref):

• html/canvas/CanvasRenderingContext.h: Lots of overrides to finals.
• html/canvas/CanvasRenderingContext2D.h:
• html/canvas/ImageBitmapRenderingContext.cpp:

(WebCore::ImageBitmapRenderingContext::canvas const):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::canvas):

• html/canvas/WebGPURenderingContext.cpp:

(WebCore::WebGPURenderingContext::canvas const):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::recordCanvasAction):

• inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::recordCanvasAction):

9:51 AM Changeset in webkit [225118] by Chris Dumez

• 3 edits in trunk/Source/WebKit

WebSWServerConnection should register/unregister itself with the StorageProcess
​https://bugs.webkit.org/show_bug.cgi?id=179965

Reviewed by Darin Adler.

WebSWServerConnection should register/unregister itself with the StorageProcess instead of relying
on StorageToWebProcessConnection to do so on its behalf. This is less error-prone.

• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::~WebSWServerConnection):

• StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::~StorageToWebProcessConnection):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::removeSWServerConnection):

9:32 AM Changeset in webkit [225117] by Darin Adler

• 137 edits in trunk

Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
​https://bugs.webkit.org/show_bug.cgi?id=179907

Reviewed by Sam Weinig.

Source/JavaScriptCore:

• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::matches): Removed explicit TextCaseSensitive because RegularExpression now
defaults to that.

• runtime/StringPrototype.cpp:

(JSC::stringIncludesImpl): Use String::find since there is no overload of
String::contains that takes a start offset now that we removed the one that took a
caseSensitive boolean. We can add one later if we like, but this should do for now.

• yarr/RegularExpression.h: Moved the TextCaseSensitivity enumeration here from

the StringImpl.h header because it is only used here.

Source/WebCore:

• Modules/plugins/YouTubePluginReplacement.cpp:

(WebCore::hasCaseInsensitivePrefix): Deleted.
(WebCore::processAndCreateYouTubeURL): Use startsWithLettersIgnoringASCIICase.

• Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readHTTPHeaders): Use isAllASCII.

• accessibility/atk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::getLengthForTextRange const): Use text().length().

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::traverseToOffsetInRange): Use isHTMLSpace instead of
isSpaceOrNewline since the code is trying to skip collapsible HTML spaces, not
arbitrary Unicode whitespace.

• accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers): Use
isAllSpecialCharacters<isHTMLSpace> for the same reason as above.

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isSearchField const): Use containsIgnoringASCIICase.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::accessibilityObjectContainsText const): Use
new findPlainText function exported from TextIterator so this can share the
same search matching logic used to find text in webpages.
(WebCore::AccessibilityObject::selectText): Use capitalize and its return value
rather than makeCapitalize modifying a string in place.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::objectInclusionFromAltText): Use isAllSpecialCharacters<isHTMLSpace>
for the same reason as above.
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const): Ditto.

• bindings/js/JSDOMConvertStrings.cpp:

(WebCore::stringToByteString): Use isAllLatin1.

• contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::containsOnlyASCIIWithNoUppercase): Use
StringView::codeUnits instead of String::at.

• contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad const):
Use isAllASCII.

• contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::URLFilterParser::addPattern): Ditto.

• css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::isSupportedFormat const): Use protocolIs and
endsWithIgnoringASCIICase.

• css/DOMCSSNamespace.cpp:

(WebCore::valueWithoutImportant): Use endsWithIgnoringASCIICase.

• css/parser/CSSPropertyParser.cpp:

(WebCore::parseGridTemplateAreasRow): Use isAllSpecialCharacters<isCSSSpace>,
for the preflight, which matches what the actual parsing code uses.

• dom/CharacterData.cpp:

(WebCore::CharacterData::containsOnlyWhitespace const): Deleted. Callers can
efficiently get at the data and do this kind of check on the data directly.

• dom/CharacterData.h: Updated for the above.

• dom/DataTransfer.cpp:

(WebCore::normalizeType): Use startsWith since the string is already converted
to ASCII lowercase.

• dom/Position.cpp:

(WebCore::Position::leadingWhitespacePosition const): Use isHTMLSpace since
since the code is trying to check for collapsible HTML spaces, not general
Unicode spaces. Other call sites of isSpaceOrNewline need to be checked for
this, but I did not fix them all at this time.
(WebCore::Position::trailingWhitespacePosition const): Ditto.

• editing/Editor.cpp:

(WebCore::Editor::editorUIUpdateTimerFired): Use noBreakSpace.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::debugRenderer const): Use text().length() instead
of textLength.
(WebCore::FrameSelection::selectionAtWordStart const): Use noBreakSpace.
(WebCore::FrameSelection::wordSelectionContainingCaretSelection): Ditto.
(WebCore::FrameSelection::actualSelectionAtSentenceStart const): Ditto.

• editing/TextIterator.cpp:

(WebCore::textNodeOffsetInFlow): Use text().length().
(WebCore::TextIterator::handleTextNode): Ditto.
(WebCore::collapsedSpaceLength): Updated since RenderText::text now returns
a reference rather than a pointer.
(WebCore::findPlainText): Added. Uses SearchBuffer to search for one string
within another. Exported so accessibility code can do this operation.

• editing/TextIterator.h: Updated for the above.

• editing/TypingCommand.cpp:

(WebCore::TypingCommand::markMisspellingsAfterTyping): Use noBreakSpace.

• editing/VisibleUnits.cpp:

(WebCore::findStartOfParagraph): Updated since RenderText::text now returns
a reference.
(WebCore::findEndOfParagraph): Ditto.

• editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_processText): Use String::characterAt instead of String::at.
Use capitalize instead of makeCapitalized.

• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::stripMicrosoftPrefix): Use findIgnoringASCIICase.

• html/Autofill.cpp:

(WebCore::AutofillData::createFromHTMLFormControlElement): Use
startsWithLettersIgnoringASCIICase.

• html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::patternMismatch const): Removed explicit
TextCaseSensitive since it now is the default, and needed to touch this anyway
because the enumeration is now in a different namespace.

• html/EmailInputType.cpp:

(WebCore::isValidEmailAddress): Updated to use JSC::Yarr::TextCaseInsensitive.

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::hasFallbackContent const): Use
isAllSpecialCharacters<isHTMLSpace>.
(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk): Use
startsWithLettersIgnoringASCIICase.
(WebCore::HTMLObjectElement::hasValidClassId): Use protocolIs.
(WebCore::preventsParentObjectFromExposure): Use isAllSpecialCharacters<isHTMLSpace>.

• html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype):
Use startsWithLettersIgnoringASCIICase.

• html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::extractCharset): Use findIgnoringASCIICase.

• html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::isContainedInRequest): Use containsIgnoringASCIICase.

• html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::hasRequiredFileIdentifier): Don't pass the length to
the String::startsWith function. There has never been a version of that function
that takes the length, there is no need to pass the length since the function
handles null-terminated strings like the one here, and in the past the length
has been getting converted to a boolean making the comparison be case sensitive.
Removing the argument entirely leaves it case sensitive.

• inspector/InspectorNodeFinder.cpp:

(WebCore::InspectorNodeFinder::matchesElement): Use startsWithIgnoringASCIICase
and endsWithIgnoringASCIICase.

• inspector/InspectorStyleSheet.cpp:

(WebCore::selectorsFromSource): Use JSC::Yarr::TextCaseSensitive.

• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::containsOnlyHTMLWhitespace): Made this a non-member function
and reimplemented using isAllSpecialCharacters<isHTMLSpace>().
(WebCore::InspectorDOMAgent::innerFirstChild): Use containsOnlyHTMLWhitespace.
(WebCore::InspectorDOMAgent::innerNextSibling): Ditto.
(WebCore::InspectorDOMAgent::innerPreviousSibling): Ditto.
(WebCore::InspectorDOMAgent::innerChildNodeCount): Ditto.
(WebCore::InspectorDOMAgent::didInsertDOMNode): Ditto.
(WebCore::InspectorDOMAgent::didRemoveDOMNode): Ditto.

• inspector/agents/InspectorDOMAgent.h: Updated for above change.

• loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::shouldStoreResourceAsFlatFile):
Use startsWithLettersIgnoringASCIICase.

• page/Base64Utilities.cpp:

(WebCore::Base64Utilities::btoa): Use isAllLatin1.

• page/Frame.cpp:

(WebCore::createRegExpForLabels): Removed TextCaseSensitive argument since
that is now the default and also used JSC::Yarr::TextCaseInsensitive.
(WebCore::matchLabelsAgainstString): More of the same.

• page/FrameView.cpp:

(WebCore::countRenderedCharactersInRenderObjectWithThreshold): Use
text().length().

• page/SecurityOrigin.cpp:

(WebCore::isFeedWithNestedProtocolInHTTPFamily): Use
startsWithLettersIgnoringASCIICase.

• page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::matchesHost const):
Use endsWithIgnoringASCIICase.

• page/csp/ContentSecurityPolicySource.cpp:

(WebCore::ContentSecurityPolicySource::hostMatches const): Ditto.

• page/csp/ContentSecurityPolicySourceList.cpp:

(WebCore::ContentSecurityPolicySourceList::parseNonceSource):
Use startsWithIgnoringASCIICase.

• page/ios/FrameIOS.mm:

(WebCore::Frame::wordsInCurrentParagraph const): Use noBreakSpace.

• platform/ContentType.cpp:

(WebCore::ContentType::parameter const): Use findIgnoringASCIICase.

• platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::isSupportedFontMIMEType): Use
startsWithLettersIgnoringASCIICase.
(WebCore::MIMETypeRegistry::isSupportedJSONMIMEType): Use
mimeType.endsWithIgnoringASCIICase.
(WebCore::MIMETypeRegistry::isTextMIMEType): Use
startsWithLettersIgnoringASCIICase.
(WebCore::MIMETypeRegistry::isXMLMIMEType): Use endsWithIgnoringASCIICase.
(WebCore::MIMETypeRegistry::isJavaAppletMIMEType): Use
startsWithLettersIgnoringASCIICase.
(WebCore::MIMETypeRegistry::canShowMIMEType): Ditto.

• platform/URL.cpp:

(WebCore::isAllASCII): Renamed from containsOnlyASCII.
(WebCore::appendEncodedHostname): Use isAllASCII.

• platform/URLParser.cpp:

(WebCore::containsOnlyASCII): Deleted.
(WebCore::URLParser::domainToASCII): Use StringImpl::isAllASCII. Changed
to take StringImpl& to guarantee we won't keep doing null checks since
the caller already checks for null.
(WebCore::URLParser::parseHostAndPort): Pass StringImpl&.

• platform/URLParser.h: Updated for above.

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::supportsType): Use endsWithIgnoringASCIICase
and startsWithLettersIgnoringASCIICase.

• platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::validKeySystemRE): Use JSC::Yarr::TextCaseInsensitive.

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::similarFont): Use containsIgnoringASCIICase for
the Geeza font special cases.

• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::shouldRejectMIMEType): Use startsWithLettersIgnoringASCIICase.

• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::getUnmangledInfoLog): Removed
TextCaseSensitive since it now is the default.

• platform/mac/PublicSuffixMac.mm:

(WebCore::topPrivatelyControlledDomain): Use isAllASCII.

• platform/mac/SSLKeyGeneratorMac.mm:

(WebCore::signedPublicKeyAndChallengeString): Use isAllASCII.

• platform/mac/StringUtilities.mm:

(WebCore::stringMatchesWildcardString): Use JSC::Yarr::TextCaseInsensitive.

• platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::addStringToSHA1): Use isAllASCII.

• platform/network/CacheValidation.cpp:

(WebCore::parseCacheControlDirectives): Use containsIgnoringASCIICase.

• platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPRefresh): Use findIgnoringASCIICase.
(WebCore::findCharsetInMediaType): Ditto.
(WebCore::parseRange): Use startsWithLettersIgnoringASCIICase.

• platform/network/curl/AuthenticationChallengeCurl.cpp:

(WebCore::AuthenticationChallenge::protectionSpaceFromHandle):
Use findIgnoringASCIICase.

• platform/network/curl/MultipartHandle.cpp:

(WebCore::MultipartHandle::extractBoundary): Ditto.

• platform/network/curl/ResourceHandleCurlDelegate.cpp:

(WebCore::ResourceHandleCurlDelegate::handleDataURL): Use
endsWithIgnoringASCIICase.

• platform/network/curl/ResourceResponseCurl.cpp:

(WebCore::ResourceResponse::isAppendableHeader): Use
startsWithLettersIgnoringASCIICase.
(WebCore::ResourceResponse::appendHTTPHeaderField): Ditto.

• platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::extractMarkupFromCFHTML): Use findIgnoringASCIICase.
(WebCore::fragmentFromCFHTML): Ditto.

• rendering/BidiRun.cpp:

(WebCore::BidiRun::BidiRun): Use text().length().

• rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absolutePDFURL const): Use
endsWithIgnoringASCIICase.

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection): Use text().length().

• rendering/InlineIterator.h:

(WebCore::InlineIterator::fastIncrementInTextNode): Ditto.
(WebCore::InlineIterator::increment): Dtto.

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::isLineBreak const): Updated since RenderText::text
now returns a StringImpl&.
(WebCore::InlineTextBox::selectionStartEnd const): Use text().length().
(WebCore::InlineTextBox::text const): Updated since RenderText::text
now returns a StringImpl&.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::constructTextRun): Use text().length().

• rendering/RenderBlockFlow.cpp:

(WebCore::isVisibleRenderText): Use isAllSpecialCharacters<isHTMLSpace>().
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):
Use the new trimmedPreferredWidths that returns a structure instead of the
old one with lots of arguments. Also use text().length().

• rendering/RenderBlockLineLayout.cpp:

(WebCore::endsWithHTMLSpaces): Renamed and changed to use isHTMLSpace
instead of isASCIISpace.
(WebCore::reachedEndOfTextRenderer): Use endsWithHTMLSpaces.
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
Updated for hcanges to RenderText.
(WebCore::RenderBlockFlow::handleTrailingSpaces): Ditto.
(WebCore::RenderBlockFlow::determineStartPosition): Ditto.

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::combineTextIfNeeded): Use
isAllSpecialCharacters<isHTMLSpace>.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const): Ditto.

• rendering/RenderListBox.cpp:

(WebCore::bolder): Added. Helper function.
(WebCore::RenderListBox::updateFromElement): Rewrote to
only compute the bolder font once rather than for every item.
(WebCore::RenderListBox::paintItemForeground): Updated for
change to applyTextTransform.

• rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::adjustInnerStyle): Updated for change
to RenderText::text.
(RenderMenuList::updateOptionsWidth): Updated for change to
applyTextTransform.
(RenderMenuList::itemText const): Ditto.

• rendering/RenderText.cpp:

(WebCore::capitalize): Renamed from makeCapitalized. Changed to
take and return a String instead of taking a String*.
(WebCore::RenderText::RenderText): Use isAllASCII. Also moved
initialization of most non-bitfield members to the class definition.
(WebCore::RenderText::positionForPoint): Use text().
(WebCore::RenderText::widthFromCache const): Ditto.
(WebCore::RenderText::hangablePunctuationStartWidth const): Ditto.
(WebCore::RenderText::hangablePunctuationEndWidth const): Ditto.
(WebCore::RenderText::isHangableStopOrComma): Ditto.
(WebCore::RenderText::firstCharacterIndexStrippingSpaces const): Ditto.
(WebCore::RenderText::lastCharacterIndexStrippingSpaces const): Ditto.
(WebCore::RenderText::trimmedPreferredWidths): Changed to return values
in a structure instead of taking lots of arguments.
(WebCore::RenderText::computePreferredLogicalWidths): Updated to use
the text() function.
(WebCore::isAllCollapsibleWhitespace): Added.
(WebCore::RenderText::isAllCollapsibleWhitespace const): Updated to
use a tighter loop.
(WebCore::isAllPossiblyCollapsibleWhitespace): Added.
(WebCore::RenderText::containsOnlyHTMLWhitespace const): Updated to
use a tighter loop. Renamed from containsOnlyWhitespace.
(WebCore::RenderText::setTextWithOffset): Updated to use text().
(WebCore::isInlineFlowOrEmptyText): Rewrote to be easier to read.
(WebCore::RenderText::previousCharacter const): Got rid of unneeded
null check and simplified.
(WebCore::applyTextTransform): Changed to return a String rather
than modifying one that is passed in.
(WebCore::RenderText::setRenderedText): Updated use of applyTextTransform.
(WebCore::RenderText::secureText): More of the same.
(WebCore::RenderText::computeCanUseSimplifiedTextMeasuring const): Ditto.
(WebCore::RenderText::textWithoutConvertingBackslashToYenSymbol const): Ditto.
(WebCore::RenderText::width const): Ditto.
(WebCore::RenderText::collectSelectionRectsForLineBoxes): Ditto.
(WebCore::RenderText::previousOffset const): Ditto.
(WebCore::RenderText::previousOffsetForBackwardDeletion const): Ditto.
(WebCore::RenderText::nextOffset const): Ditto.
(WebCore::RenderText::computeCanUseSimpleFontCodePath const): Ditto.
(WebCore::RenderText::stringView const): Ditto.

• rendering/RenderText.h: Made some more members private and final.

Updated for above, including adding the Widths structure. Got rid of the
textLength function, which existed as a workaround before we could mark
a function like length final. Made the text function return a StringImpl&,
which is good since the m_text string is never null, and so callers end
up using StringImpl directly and saving null checks. Removed functions
that are not needed, including is8Bit, characters8, characters16,
uncheckedCharacterAt, operator[], and isAllASCII.

• rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::setText): Use text().length().

• rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::caretMaxOffset const): Ditto.
(WebCore::RenderTextLineBoxes::positionForPoint const): Ditto.
(WebCore::RenderTextLineBoxes::setSelectionState): Ditto.
(WebCore::RenderTextLineBoxes::absoluteQuads const): Ditto.

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForFontAndText): Ditto.

• rendering/SimpleLineLayoutCoverage.cpp:

(WebCore::SimpleLineLayout::textLengthForSubtree): Ditto.
(WebCore::SimpleLineLayout::collectNonEmptyLeafRenderBlockFlows): Ditto.

• rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::initializeSegments): Ditto.

• rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::textOffsetForPoint): Ditto.

• rendering/SimpleLineLayoutFunctions.h:

(WebCore::SimpleLineLayout::findCaretMaximumOffset): Ditto.

• rendering/line/BreakingContext.h:

(WebCore::shouldAddBorderPaddingMargin): Ditto.
(WebCore::shouldSkipWhitespaceAfterStartObject): Ditto.
(WebCore::iteratorIsBeyondEndOfRenderCombineText): Ditto.
(WebCore::textWidth): Ditto.
(WebCore::BreakingContext::handleText): Ditto.
(WebCore::BreakingContext::optimalLineBreakLocationForTrailingWord): Ditto.

• rendering/line/TrailingObjects.cpp:

(WebCore::TrailingObjects::updateWhitespaceCollapsingTransitionsForTrailingBoxes): Ditto.

• rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement): Removed stray use of "unsigned int".

• rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::characterStartsNewTextChunk const): Use text().length().
(WebCore::RenderSVGInlineText::positionForPoint): Ditto.

• rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::processRenderSVGInlineText): Ditto.

• rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes): Ditto.

• rendering/svg/SVGTextQuery.cpp:

(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures const): Ditto.

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRenderTree): Use isAllSpecialCharacters<isHTMLSpace>.
(WebCore::RenderTreeUpdater::textRendererIsNeeded): Ditto.

• svg/SVGTests.cpp:

(WebCore::SVGTests::hasFeatureForLegacyBindings): Use startsWithLettersIgnoringASCIICase.

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::shouldAllowExternalLoad): Ditto.

Source/WebKit:

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::isMediaMIMEType): Use startsWithLettersIgnoringASCIICase.

• NetworkProcess/cache/NetworkCacheKey.cpp:

(WebKit::NetworkCache::hashString): Use isAllASCII..

• UIProcess/API/C/WKWebsitePolicies.cpp:

(WKWebsitePoliciesSetCustomHeaderFields): Use startsWithLettersIgnoringASCIICase..

• UIProcess/API/Cocoa/_WKWebsitePolicies.mm:

(-[_WKWebsitePolicies setCustomHeaderFields:]): Ditto.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder): Use endsWithIgnoringASCIICase.

• UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::WebPreferences): Initialize m_identifier explicitly. Somehow
changing the String default constructor to be "= default" led to a warning that we
otherwise did not get about not initializing m_identifier. Arguably a compiler bug,
but legitimately strange that the copy constructor does not copy m_identifier and so
nice to be explicit about it, I guess.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplicationRaw): Use
endsWithIgnoringASCIICase.
(WebKit::WebPageProxy::openPDFFromTemporaryFolderWithNativeApplication): Ditto.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Ditto.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const): Use isAllSpecialCharacters<isHTMLSpace>.

Source/WebKitLegacy/mac:

• History/BinaryPropertyList.cpp:

(BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
(BinaryPropertyListSerializer::appendStringObject): Ditto.

• WebView/WebHTMLRepresentation.mm:

(regExpForLabels): Removed TextCaseSensitive since it is now the default.
(matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.

Source/WebKitLegacy/win:

• Plugins/PluginDatabaseWin.cpp:

(WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.

• WebDownloadCFNet.cpp:

(WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.

• WebView.cpp:

(WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
the code does not cause any change in behavior.

Source/WTF:

• wtf/text/ASCIIFastPath.h: Moved the using for charactersAreAllASCII here since

the function is defined here.

• wtf/text/AtomicString.h: Removed overloads of contains, find, startsWith, and

endsWith that take a boolean indicating whether they should be "case sensitive".
When false, this was doing Unicode case folding, and no callers needed that.
Also tweaked formatting and argument names.

• wtf/text/IntegerToStringConversion.h: Added an include of LChar.h since this file

uses that. Also tweaked formatting a bit.

• wtf/text/StringImpl.cpp:

(WTF::StringImpl::containsOnlyWhitespace): Deleted. Despite its name sounding like
it used the full Unicode whitespace definition, this actually checked isASCIISpace.
Callers now all use isAllSpecialCharacters instead with the whitespace definition
that is appropriate to each call site.
(WTF::latin1CaseFoldTable): Deleted.
(WTF::equalCompatibilityCaseless): Deleted.
(WTF::StringImpl::findIgnoringCase): Deleted.
(WTF::findIgnoringCaseInner): Deleted.
(WTF::reverseFindIgnoringCaseInner): Deleted.
(WTF::StringImpl::reverseFindIgnoringCase): Deleted.
(WTF::equalInner): Removed boolean caseSensitive argument.
(WTF::StringImpl::startsWith): Ditto.
(WTF::StringImpl::endsWith): Ditto.

• wtf/text/StringImpl.h: Moved TextCaseSensitivity out into a different header.

Moved ASCIIFastPath.h include here from WTFString.h. Moved isAllSpecialCharacters
free function here from WTFString.h. Moved lots of function bodies out of class
definitions to make the class definitions easier to read. Sorted things a bit.
Tweaked formatting. Marked constructor that takes one argument explicit. Added
an isEmpty function like the one in String. Renamed copyChars to copyCharacters.
Added isAllASCII, isAllLatin1 and isAllSpecialCharacters functions. Removed
boolean caseSensitive arguments from various functions. Removed findIgnoringCase
and reverseFindIgnoringCase. Added a FIXME to codePointCompare about the way it
treats null and empty strings as equal. Changed length argument in remove to
unsigned to match other lengths.

• wtf/text/WTFString.cpp:

(WTF::String::removeInternal): Changed length argument to be unsigned.
(WTF::createWithFormatAndArguments): Use emptyString.
(WTF::String::isSafeToSendToAnotherThread const): Rewrote to be easier to read.

• wtf/text/WTFString.h: Moved ASCIIFastPath.h to StringImpl.h. Moved lots of

function bodies out of class definitions to make the class definitions easier
to read, made others one-liners. Removed the String::at function but kept the
String::characterAt function; the two were identical. Removed boolean
caseSensitive arguments from various functions. Removed findIgnoringCase and
reverseFindIgnoringCase. Renamed containsOnlyASCII to isAllASCII and
containsOnlyLatin1 to isAllLatin1 to match the naming of isAllSpecialCharacters.
Moved the inline implementations of functions that are defined above further
down, after things like the ASCIILiteral class and various functions.

• wtf/text/icu/UTextProviderLatin1.cpp: Updated name of copyChars.

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(changeWindowScaleIfNeeded): Use containsIgnoringASCIICase.

• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::urlContains const): Ditto.

7:50 AM Changeset in webkit [225116] by Ms2ger@igalia.com

• 2 edits in trunk/LayoutTests

[WPE] Mark media/media-source/media-source-paint-to-canvas.html as passing.
​https://bugs.webkit.org/show_bug.cgi?id=178706

Unreviewed test gardening.

It has passed since r225060.

• platform/wpe/TestExpectations:

[WPE] Re-enable fast/dom/Document/CaretRangeFromPoint/replace-element.html.
​https://bugs.webkit.org/show_bug.cgi?id=176820

Unreviewed test gardening.

The test started passing again in r221974.

• platform/wpe/TestExpectations:

6:19 AM Changeset in webkit [225115] by zandobersek@gmail.com

• 15 edits in trunk/Source

[CoordGraphics] Simplify CoordinatedGraphicsLayer's content buffer updates
​https://bugs.webkit.org/show_bug.cgi?id=179972

Reviewed by Carlos Garcia Campos.

Source/WebCore:

During layer flushes, when a CoordinatedGraphicsLayer's tiled backing store
has dirty tiles that need to be updated, the following chain of calls would
be invoked to perform the painting, starting in
CoordinatedGraphicsLayer::updateContentBuffers():

CoordinatedGraphicsLayer::updateContentBuffers() TiledBackingStore::updateTileBuffers() Tile::updateBackBuffer() CoordinatedGraphicsLayer::paintToSurface() CompositingCoordinator::paintToSurface() UpdateAtlas::paintOnAvailableBuffer() ThreadSafeCoordinatedSurface::paintToSurface() Tile::paintToSurfaceContext() CoordinatedGraphicsLayer::tiledBackingStorePaint() GraphicsLayer::paintGraphicsLayerContents()

That's a bit much.

In CoordinatedGraphicsLayer::updateContentBuffers(), we now first retrieve
all the dirty layers in our TiledBackingStore. We then iterate through them,
first establishing their ID and then retrieving an available CoordinatedBuffer
that we can use for painting. The CoordinatedBuffer is retrieved through
CompositingCoordinator, which is still caching these buffers via UpdateAtlas
objects.

With a CoordinatedBuffer available, we can then proceed with painting. The
painting context has to be properly set up to paint into the correct area of
the given buffer, and the alpha channel, if necessary, has to be addressed.
After properly positioning and scaling ourselves on the given context, we
can proceed with the GraphicsLayer::paintGraphicsLayerContents() call.

What's left is filling out the missing SurfaceUpdateInfo information which is
then passed to the updateTile() method that properly registers the tile
update we've just performed. The tile itself is marked clean. After the
iteration, we call the didUpdateTileBuffers() method in case any successful
tile update was indeed performed, incrementing the repaint counter.

That's it -- we clipped 8 calls from the call chain. We can now also remove
the CoordinatedBuffer::Client interface, as well as slim down the
TiledBackingStore interface. The Tile class is cleaned up a bit, with methods
shifted into a more sensible order.

No new tests -- no change in functionality.

• platform/graphics/texmap/coordinated/CoordinatedBuffer.cpp:
• platform/graphics/texmap/coordinated/CoordinatedBuffer.h:
• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::didUpdateTileBuffers):
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStorePaint): Deleted.
(WebCore::CoordinatedGraphicsLayer::paintToSurface): Deleted.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
• platform/graphics/texmap/coordinated/Tile.cpp:

(WebCore::Tile::ensureTileID):
(WebCore::Tile::isDirty const):
(WebCore::Tile::invalidate):
(WebCore::Tile::markClean):
(WebCore::Tile::updateBackBuffer): Deleted.
(WebCore::Tile::paintToSurfaceContext): Deleted.

• platform/graphics/texmap/coordinated/Tile.h:

(WebCore::Tile::tileID const):
(WebCore::Tile::dirtyRect const):

• platform/graphics/texmap/coordinated/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::dirtyTiles):
(WebCore::TiledBackingStore::updateTileBuffers): Deleted.

• platform/graphics/texmap/coordinated/TiledBackingStore.h:
• platform/graphics/texmap/coordinated/TiledBackingStoreClient.h:

Source/WebKit:

In CompositingCoordinator, add the getCoordinatedBuffer() method, replacing
paintToSurface(). The new method traverses the list of UpdateAtlases and
returns any CoordinatedBuffer object that was free to use. If none exist,
a new UpdateAtlas object is created, and its CoordinatedBuffer is returned.

In UpdateAtlas, the paintOnAvailableBuffer() method is replaced with
getCoordinatedBuffer(). The latter allocates the necessary area but then
returns a reference to the CoordinatedBuffer buffer, along with the atlas ID
and the allocated rectangle information, and does not invoke any painting
operation like paintOnAvailableBuffer() did.

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::getCoordinatedBuffer):
(WebKit::CompositingCoordinator::paintToSurface): Deleted.

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
• WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::getCoordinatedBuffer):
(WebKit::UpdateAtlas::paintOnAvailableBuffer): Deleted.

• WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

5:09 AM Changeset in webkit [225114] by Ms2ger@igalia.com

• 2 edits in trunk/LayoutTests

[WPE] Re-enable fast/dom/Document/CaretRangeFromPoint/replace-element.html.
​https://bugs.webkit.org/show_bug.cgi?id=176820

Unreviewed test gardening.

The test started passing again in r221974.

• platform/wpe/TestExpectations:

3:04 AM Changeset in webkit [225113] by zandobersek@gmail.com

• 6 edits in trunk/Source

[CoordGraphics] Remove relay CoordinatedBuffer::Client implementations
​https://bugs.webkit.org/show_bug.cgi?id=179970

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Drop CoordinatedBuffer::painToSurface() in favor of a simpler
GraphicsContext reference getter that returns a reference to the
GraphicsContext object of the internal ImageBuffer.

Remove the ImageBackingSurfaceClient class that only acted as a relay
that enabled a CoordinatedBuffer to draw an image through its context.
Instead, we use the GraphicsContext of the allocated CoordinatedBuffer
to draw the image directly. We still use a rectangle whose size
matches the size of the given Image as the clipping area and as the
source and destination rectangle for the image.

No new tests -- no change in behavior.

• platform/graphics/texmap/coordinated/CoordinatedBuffer.cpp:

(WebCore::CoordinatedBuffer::context):
(WebCore::CoordinatedBuffer::paintToSurface): Deleted.

• platform/graphics/texmap/coordinated/CoordinatedBuffer.h:
• platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:

(WebCore::CoordinatedImageBacking::update):
(WebCore::ImageBackingSurfaceClient::ImageBackingSurfaceClient): Deleted.

Source/WebKit:

Drop the helper UpdateAtlasSurfaceClient class and instead directly use
the CoordinatedBuffer's GraphicsContext to perform clip and translation
operations based on the allocated rectangle, to pre-fill the target rect
with transparent color in case the alpha channel is supported, and to
then invoke CoordinatedBuffer::Client::paintToSurfaceContext() method,
passing the GraphicsContext as the argument.

• WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::paintOnAvailableBuffer):
(): Deleted.

3:01 AM Changeset in webkit [225112] by zandobersek@gmail.com

• 5 edits in trunk/Source/WebCore

[CoordGraphics] TiledBackingStore: use a reference to the client
​https://bugs.webkit.org/show_bug.cgi?id=179969

Reviewed by Carlos Garcia Campos.

TiledBackingStore should keep a C++ reference to the TiledBackingStoreClient
object, and not a pointer. client() method is updated to reflect that, and
uses of this method and the member variable are updated accordingly.

No new tests -- no change in behavior.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::createBackingStore):

• platform/graphics/texmap/coordinated/Tile.cpp:

(WebCore::Tile::~Tile):
(WebCore::Tile::updateBackBuffer):
(WebCore::Tile::paintToSurfaceContext):

• platform/graphics/texmap/coordinated/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::updateTileBuffers):
(WebCore::TiledBackingStore::createTiles):

• platform/graphics/texmap/coordinated/TiledBackingStore.h:

(WebCore::TiledBackingStore::client):

3:00 AM Changeset in webkit [225111] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebCore

[CoordGraphics] Early tile buffer update in TiledBackingStore::createTiles() is unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=179968

Reviewed by Carlos Garcia Campos.

Under CoordinatedGraphicsLayer::updateContentBuffers(), the TiledBackingStore
object has the createTilesIfNeeded() method invoked, if necessary. This
invokes createTiles(), where the edge tiles are resized if necessary, and
the missing tiles are created. If any of those two cases is fulfilled, the
updateTileBuffers() method is invoked, updating any dirty tiles (i.e. the
ones that were resized or newly-created).

This specific invocation of updateTileBuffers() is not needed since it's the
very next method that's invoked on the TiledBackingStore object by
CoordinatedGraphicsLayer::updateContentBuffers(). It's therefore removed,
and the resizeEdgeTiles() method is changed to not return any value.

No new tests -- no change in behavior.

• platform/graphics/texmap/coordinated/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::resizeEdgeTiles):

• platform/graphics/texmap/coordinated/TiledBackingStore.h:

2:45 AM Changeset in webkit [225110] by Antti Koivisto

• 3 edits in trunk/Source/WebCore

RenderBlockFlow::layoutRunsAndFloatsInRange is O(n^{2) for runs of inlines without any text
​https://bugs.webkit.org/show_bug.cgi?id=179950}

Reviewed by Simon Fraser.

It calls createBidiRunsForLine for each line. createBidiRunsForLine traverses past the end of the line until
it finds the end of the current bidi run. If there is no text in the flow, it never finds anything and traverses
the entire flow. This is O(n^{2) for the number of renderers in the flow.}

Tested by PerformanceTests/Layout/inline-layout-no-text.html

• platform/text/BidiResolver.h:

(WebCore::BidiResolverBase::needsContinuePastEnd const):
(WebCore::BidiResolverBase::needsContinuePastEndInternal const):
(WebCore::DerivedClass>::createBidiRunsForLine):

When past end of line call needsContinuePastEnd() to see if we need to continue searching for the end of the bidi run.

• rendering/InlineIterator.h:

(WebCore::InlineBidiResolver::needsContinuePastEndInternal const):

InlineBidiResolver only returns runs up to the last renderer on the line and can bail out.

2:31 AM Changeset in webkit [225109] by Ms2ger@igalia.com

• 3 edits
  2 adds in trunk/LayoutTests

[WPE] Enable some more wpt tests.
​https://bugs.webkit.org/show_bug.cgi?id=179939

Reviewed by Žan Doberšek.

• TestExpectations: Add the number of a bug I filed.
• platform/wpe/TestExpectations: Enable some smaller top-level wpt directories.
• platform/wpe/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: Added: Service Workers are not yet enabled for WPE, which affects the results of this test in a harmless way.

1:17 AM Changeset in webkit [225108] by zandobersek@gmail.com

• 22 edits
  2 adds
  4 deletes in trunk/Source

[CoordGraphics] Replace CoordinatedSurface, ThreadSafeCoordinatedSurface with CoordinatedBuffer
​https://bugs.webkit.org/show_bug.cgi?id=179967

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Roll the CoordinatedSurface and ThreadSafeCoordinatedSurface classes
into one CoordinatedBuffer class.

CoordinatedBuffer class mimics CoordinatedSurface in providing the
Client class that allows specifying how the client should paint using a
GraphicsContext object. supportsAlpha() and size() methods are also
present, as well as paintToSurface(). uploadImage() retrieves the
Image that's created from the contained ImageBuffer, allowing the user
to then manually upload the buffer data onto the GPU.

CoordinatedBuffer otherwise serves as a drop-in replacement for the
CoordinatedSurface class, and the remaining changes in the
CoordiantedGraphics code reflect that.

No new tests -- no change in behavior.

• platform/TextureMapper.cmake:
• platform/graphics/texmap/coordinated/CoordinatedBuffer.cpp: Added.

(WebCore::CoordinatedBuffer::create):
(WebCore::CoordinatedBuffer::CoordinatedBuffer):
(WebCore::CoordinatedBuffer::paintToSurface):
(WebCore::CoordinatedBuffer::uploadImage):

• platform/graphics/texmap/coordinated/CoordinatedBuffer.h: Added.

(WebCore::CoordinatedBuffer::supportsAlpha const):
(WebCore::CoordinatedBuffer::size const):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::paintToSurface):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
• platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
• platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:

(WebCore::CoordinatedImageBacking::update):
(WebCore::CoordinatedImageBacking::releaseSurfaceIfNeeded):

• platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
• platform/graphics/texmap/coordinated/CoordinatedSurface.cpp: Removed.
• platform/graphics/texmap/coordinated/CoordinatedSurface.h: Removed.
• platform/graphics/texmap/coordinated/Tile.h:
• platform/graphics/texmap/coordinated/TiledBackingStoreClient.h:

Source/WebKit:

Replace uses of CoordinatedSurface class with CoordinatedBuffer. The
ThreadSafeCoordinatedSurface class is removed, along with the code in
CoordinatedLayerTreeHost that established a CoordinatedSurface factory.

• PlatformGTK.cmake:
• PlatformWPE.cmake:
• Shared/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStoreTile::swapBuffers):
(WebKit::CoordinatedBackingStoreTile::setBackBuffer):
(WebKit::CoordinatedBackingStore::updateTile):

• Shared/CoordinatedGraphics/CoordinatedBackingStore.h:

Rename m_surface to m_buffer, m_surfaceOffset to m_bufferOffset.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::createUpdateAtlas):
(WebKit::CoordinatedGraphicsScene::updateImageBacking):

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
• Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp: Removed.
• Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.h: Removed.
• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::updateImageBacking):
(WebKit::CompositingCoordinator::createUpdateAtlas):
(WebKit::CompositingCoordinator::paintToSurface):

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::createCoordinatedSurface): Deleted.

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
• WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::paintOnAvailableBuffer):

• WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

Rename m_surface to m_buffer.
(WebKit::UpdateAtlas::size const):
(WebKit::UpdateAtlas::supportsAlpha const):

Nov 22, 2017:

10:47 PM Changeset in webkit [225107] by Simon Fraser

• 3 edits in trunk/Source/WebCore

FEComponentTransfer cleanup and optimization
​https://bugs.webkit.org/show_bug.cgi?id=179952

Reviewed by Darin Adler.

Change terminology for FEComponentTransfer to be more explicit about the fact
that it's creating and using lookup tables. Use std::array for the lookup tables.

Use uint8_t instead of unsigned char.

Avoid confusing arrays for channels in computeLookupTables; just setup the lut for
each channel manually.

This is about 1.25x faster than before.

• platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::computeIdentityTable):
(WebCore::FEComponentTransfer::computeTabularTable):
(WebCore::FEComponentTransfer::computeDiscreteTable):
(WebCore::FEComponentTransfer::computeLinearTable):
(WebCore::FEComponentTransfer::computeGammaTable):
(WebCore::FEComponentTransfer::platformApplySoftware):
(WebCore::FEComponentTransfer::computeLookupTables):
(WebCore::operator<<):
(WebCore::identity): Deleted.
(WebCore::table): Deleted.
(WebCore::discrete): Deleted.
(WebCore::linear): Deleted.
(WebCore::gamma): Deleted.
(WebCore::FEComponentTransfer::getValues): Deleted.

• platform/graphics/filters/FEComponentTransfer.h:

(WebCore::ComponentTransferFunction::ComponentTransferFunction): Deleted.

10:47 PM Changeset in webkit [225106] by Simon Fraser

• 2 edits in trunk/Source/JavaScriptCore

Followup after r225084: if anyone called GenericTypedArrayView() it didn't compile,
because of a getRangeUnchecked/getRangeImpl name mismatch; fixed to use getRangeImpl().

Also name the argument to zeroRange() to 'count' since it's an item count.

• runtime/GenericTypedArrayView.h:

(JSC::GenericTypedArrayView::zeroRange):
(JSC::GenericTypedArrayView::getRange):

4:57 PM Changeset in webkit [225105] by Michael Catanzaro

• 8 edits in trunk

Sanity-check feature defaults in WebKitFeatures.cmake
​https://bugs.webkit.org/show_bug.cgi?id=179095

Reviewed by Konstantin Tokarev.

Change the default value of some features in WebKitFeatures.cmake to reduce the number of
Options*.cmake files the feature's default value must be overridden in.

Remove feature definitions where they are redundant with the definition in
WebKitFeatures.cmake, particluarly in OptionsMac.cmake.

This commit should not include any functional changes. It just aims to reduce the total
number of times we need to call WEBKIT_OPTION_DEFAULT_PORT_VALUE.

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsJSCOnly.cmake:
• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWPE.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/WebKitFeatures.cmake:

3:46 PM Changeset in webkit [225104] by jfernandez@igalia.com

• 8 edits
  1 copy
  1 add in trunk/Source/WebCore

[css-grid] Refactoring and new namespace with grid related utility functions
​https://bugs.webkit.org/show_bug.cgi?id=179633

Reviewed by Darin Adler.

Added a new namespace with several utility functions to share logic
between RenderGrid and GridTrackSizingAlgorithm.

No new tests, since no new functionality is added.

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• rendering/GridLayoutUtils.cpp: Added.

(WebCore::GridLayoutUtils::computeMarginLogicalSizeForChild):
(WebCore::GridLayoutUtils::marginLogicalSizeForChild):
(WebCore::GridLayoutUtils::isOrthogonalChild):
(WebCore::GridLayoutUtils::flowAwareDirectionForChild):

• rendering/GridLayoutUtils.h: Added.
• rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::assumedRowsSizeForOrthogonalChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::DefiniteSizeStrategy::minLogicalWidthForChild const):

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::layoutPositionedObject):
(WebCore::RenderGrid::availableAlignmentSpaceForChildBeforeStretching const):
(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
(WebCore::RenderGrid::isInlineBaselineAlignedChild const):
(WebCore::RenderGrid::firstLineBaseline const):
(WebCore::RenderGrid::columnAxisPositionForChild const):
(WebCore::RenderGrid::rowAxisPositionForChild const):
(WebCore::RenderGrid::columnAxisOffsetForChild const):
(WebCore::RenderGrid::rowAxisOffsetForChild const):
(WebCore::RenderGrid::findChildLogicalPosition const):

2:20 PM Changeset in webkit [225103] by commit-queue@webkit.org

• 44 edits
  18 adds in trunk

Implement VisualViewport API attributes
​https://bugs.webkit.org/show_bug.cgi?id=179385

Patch by Ali Juma <​ajuma@chromium.org> on 2017-11-22
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Update expectations for viewport WPTs. The new expectations are all passing,
except as mentioned below.

• web-platform-tests/viewport/viewport-no-resize-event-on-overflow-recalc-expected.txt:
• web-platform-tests/viewport/viewport-read-size-causes-layout-expected.txt:
• web-platform-tests/viewport/viewport-read-size-in-iframe-causes-layout-expected.txt:
• web-platform-tests/viewport/viewport-resize-event-on-load-overflowing-page-expected.txt: Fails since events are not implemented yet (wkbug.com/b/179386).
• web-platform-tests/viewport/viewport-scrollbars-cause-resize-expected.txt:
• web-platform-tests/viewport/viewport-type-expected.txt:
• web-platform-tests/viewport/viewport-unscaled-scale-expected.txt:
• web-platform-tests/viewport/viewport-unscaled-scale-iframe-expected.txt:
• web-platform-tests/viewport/viewport-unscaled-scroll-expected.txt:
• web-platform-tests/viewport/viewport-unscaled-scroll-iframe-expected.txt: Passing expectation for non-iOS, but fails on iOS because iframes aren't scrollable (wkbug.com/b/179794).
• web-platform-tests/viewport/viewport-unscaled-size-expected.txt:
• web-platform-tests/viewport/viewport-unscaled-size-iframe-expected.txt: Passing expectation for non-iOS, but fails on iOS because iframes aren't scrollable (wkbug.com/b/179794).

Source/WebCore:

Add a visualViewport attribute to Window, and implement the VisualViewport
interface (​https://wicg.github.io/visual-viewport/#the-visualviewport-interface).

This is behind a newly-added VisualViewportAPI experimental feature flag.

Tests: fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html

fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html
fast/visual-viewport/viewport-dimensions-iframe.html
fast/visual-viewport/viewport-dimensions-under-page-zoom.html
fast/visual-viewport/viewport-dimensions.html

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/WebCoreBuiltinNames.h:
• dom/EventTargetFactory.in:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::resetDOMWindowProperties):
(WebCore::DOMWindow::visualViewport const):

• page/DOMWindow.h:
• page/DOMWindow.idl:
• page/Settings.yaml:
• page/VisualViewport.cpp: Added.

(WebCore::VisualViewport::VisualViewport):
(WebCore::VisualViewport::eventTargetInterface const):
(WebCore::VisualViewport::scriptExecutionContext const):
(WebCore::getFrameViewAndLayoutIfNonNull):
(WebCore::VisualViewport::offsetLeft const):
(WebCore::VisualViewport::offsetTop const):
(WebCore::VisualViewport::pageLeft const):
(WebCore::VisualViewport::pageTop const):
(WebCore::VisualViewport::width const):
(WebCore::VisualViewport::height const):
(WebCore::VisualViewport::scale const):

• page/VisualViewport.h: Added.
• page/VisualViewport.idl: Added.

Source/WebKit:

Add a VisualViewportAPI experimental feature.

• Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

Add a VisualViewportAPI preference.

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences visualViewportAPIEnabled]):
(-[WebPreferences setVisualViewportAPIEnabled:]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

Add a VisualViewportAPI preference.

• Interfaces/IWebPreferencesPrivate.idl:
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::visualViewportAPIEnabled):
(WebPreferences::setVisualViewportAPIEnabled):

• WebPreferences.h:
• WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

Enable the VisualViewportAPI in layout tests.

• DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

• DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):

LayoutTests:

Add tests for the Visual Viewport API, based on Blink's layout tests but modified
to use UIScriptController.

• fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars-expected.txt: Added.
• fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html: Added.
• fast/visual-viewport/viewport-dimensions-exclude-scrollbars-expected.txt: Added.
• fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html: Added.
• fast/visual-viewport/viewport-dimensions-expected.txt: Added.
• fast/visual-viewport/viewport-dimensions-iframe-expected.txt: Added.
• fast/visual-viewport/viewport-dimensions-iframe.html: Added.
• fast/visual-viewport/viewport-dimensions-under-page-zoom-expected.txt: Added.
• fast/visual-viewport/viewport-dimensions-under-page-zoom.html: Added.
• fast/visual-viewport/viewport-dimensions.html: Added.
• platform/gtk/TestExpectations: Skipped tests that use UIScriptController::zoomToScale, since this isn't implemented on GTK (webkit.org/b/168050).
• platform/ios/fast/visual-viewport/viewport-dimensions-iframe-expected.txt: Added. Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
• platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-scroll-iframe-expected.txt: Added. Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
• platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-expected.txt: Added. Platform-specific expectation because of the window size being different on iOS.
• platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-iframe-expected.txt: Added. Fails because iframes aren't scrollable on iOS (webkit.org/b/179794).
• platform/mac-wk1/TestExpectations: Skipped a test that applies webkit-scrollbar to main frame scrollbars, since this is unsupported in WK1.

1:24 PM Changeset in webkit [225102] by Antti Koivisto

• 1 edit
  1 add in trunk/PerformanceTests

Add performance test for inlines and inline-blocks without text
​https://bugs.webkit.org/show_bug.cgi?id=179955

Reviewed by Darin Adler.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=179950

• Layout/inline-layout-no-text.html: Added.

12:37 PM Changeset in webkit [225101] by Manuel Rego Casasnovas

• 3 edits
  4 adds in trunk

Available height is wrong for positioned elements with "box-sizing: border-box"
​https://bugs.webkit.org/show_bug.cgi?id=178783

Reviewed by Darin Adler.

Source/WebCore:

These methods were returning a wrong value for positioned items
in combination with "box-sizing: border-box".
The problem was that if the height of the element is given
by its offset properties (top and bottom) we don't need to call
adjustContentBoxLogicalHeightForBoxSizing().

Tests: fast/box-sizing/fill-available.html

fast/box-sizing/replaced.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
(WebCore::RenderBox::availableLogicalHeightUsing const):

LayoutTests:

There are some cases failing in fast/box-sizing/fill-available.html,
this is because of a different bug (see ​https://webkit.org/b/178790)
as noted down in the text comments.

• fast/box-sizing/fill-available-expected.txt: Added.
• fast/box-sizing/fill-available.html: Added.
• fast/box-sizing/replaced-expected.txt: Added.
• fast/box-sizing/replaced.html: Added.

11:44 AM Changeset in webkit [225100] by commit-queue@webkit.org

• 12 edits in trunk/Source

WebCoreObjCExtras.h is being included in too many places
​https://bugs.webkit.org/show_bug.cgi?id=179931

Patch by Christopher Reid <​chris.reid@sony.com> on 2017-11-22
Reviewed by Darin Adler.

Source/WebCore:

No new tests no change in behavior.

Fixing cases where WebCoreObjCExtras.h is imported but not used.

• accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
• platform/mac/WebCoreNSURLExtras.mm:

Source/WebKitLegacy/mac:

• Plugins/Hosted/WebHostedNetscapePluginView.mm:
• Plugins/WebBaseNetscapePluginView.mm:
• Plugins/WebBasePluginPackage.mm:
• Plugins/WebNetscapePluginStream.mm:
• Plugins/WebNetscapePluginView.mm:
• WebView/WebTextIterator.mm:
• WebView/WebViewData.mm:

11:04 AM Changeset in webkit [225099] by graouts@webkit.org

• 4 edits in trunk/Source/WebCore

[Web Animations] Adopt KeyframeList in KeyframeEffect
​https://bugs.webkit.org/show_bug.cgi?id=179941
<rdar://problem/35666924>

Reviewed by Darin Adler.

KeyframeEffect used to model its keyframes by creating a new Keyframe struct and storing them in a Vector<Keyframe>.
However, there already is a way to model keyframes in WebCore using the KeyframeList class. We now adopt this class
in KeyframeEffect, which makes it possible to run hardware-composited animations using RenderBoxModelObject::startAnimation()
in a follow-up patch, since this function expects a KeyframeList.

No news tests, this is an internals change and does not yield any changes in Web content.

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::KeyframeEffect): Create a default m_keyframes at construction time.
(WebCore::KeyframeEffect::processKeyframes): Create a temporary KeyframeList as we parse keyframes passed from the JS API
and assign it to m_keyframes upon successful parsing. We also use cssPropertyId to refer to a CSSPropertyID to make the code
clearer and ensure there is no confusion with JS properties that we manipulate in this function.
(WebCore::KeyframeEffect::computeStackingContextImpact): Use the list of CSS properties exposed on KeyframeList directly rather
than enumerating each keyframe and use cssPropertyId to refer to individual CSSPropertyID values for consistency.
(WebCore::KeyframeEffect::applyAtLocalTime): Use the list of CSS properties exposed on KeyframeList directly rather than
using the properties specified on the first keyframe only. We also remove a stale FIXME comment which was addressed in r224957.

• animation/KeyframeEffect.h: Remove the Keyframe struct and change the type of m_keyframes from Vector<Keyframe> to KeyframeList.
• rendering/style/KeyframeList.h:

(WebCore::KeyframeList::KeyframeList): We remove the default insertions at KeyframeList construction time since it requires
an immediate call to clear() when doing any meaningful work with a KeyframeList. We also add the default move assignment operator
to allow KeyframeEffect::processKeyframes() to make a move assignment from the temporary keyframe list we build at parsing to the
member variable.

10:52 AM Changeset in webkit [225098] by Michael Catanzaro

• 11 edits in trunk

Remove build-webkit's notion of feature flags having a default value
​https://bugs.webkit.org/show_bug.cgi?id=177338

Reviewed by Carlos Alberto Lopez Perez.

.:

Add an ENABLE_EXPERIMENTAL_FEATURES flag and use it to enable certain features.

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/WebKitFeatures.cmake:

Source/WebKit:

Use ENABLE_EXPERIMENTAL_FEATURES instead of ENABLE_DEVELOPER_MODE to enable runtime
experimental features.

• Shared/WebPreferencesDefaultValues.h:

Tools:

Delegate feature flag default values to the build system.
(FeatureDefines.xcconfig for Xcode, WebKitFeatures.cmake and Options*.cmake for CMake, and FeatureDefines.h for everyone)

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(Factory.init):
Update GTK and WPE buildbot configuration to use --no-experimental-features on old stable
bots instead of --default-cmake-features.

• Scripts/build-webkit:

(cMakeArgsFromFeatures): Deleted.
Default feature values to 'undef'.
Remove the --default-cmake-features argument; it is now the default.
Add --no-experimental-features to replace it.
Stop printing the default feature flag value in the help.
Avoid propagating undefined values to the build system;
only mention flags that are overridden on the command line.

This has the nice side effect of using the default CMake features
for CMake builds, but still allowing toggling of them using the
prettier --FEATURE and --no-FEATURE arguments.

• Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):
No longer need to suppress CMake warnings about unused arguments.

• Scripts/webkitperl/FeatureList.pm:

Remove the default values from the feature list.

10:08 AM Changeset in webkit [225097] by mark.lam@apple.com

• 2 edits in trunk/Tools

[Re-landing] Pass --useDollarVM=true to all JSC tests.
​https://bugs.webkit.org/show_bug.cgi?id=179647

Reviewed by Saam Barati.

• Scripts/run-jsc-stress-tests:

9:56 AM Changeset in webkit [225096] by commit-queue@webkit.org

• 4 edits in trunk/Source/WTF

tuple related items are used in WTF without including tuple
​https://bugs.webkit.org/show_bug.cgi?id=179926

Patch by Stephan Szabo <​stephan.szabo@sony.com> on 2017-11-22
Reviewed by Darin Adler.

• wtf/HashFunctions.h:
• wtf/PrintStream.h:
• wtf/threads/Signals.h:

8:54 AM Changeset in webkit [225095] by Ms2ger@igalia.com

• 2 edits in trunk/LayoutTests

[WPE] Enable request-animation-frame-disabled.html.
​https://bugs.webkit.org/show_bug.cgi?id=173422

Unreviewed test gardening.

The test is passing since the change in r218754, and doesn't seem to have
crashed in months.

• platform/wpe/TestExpectations:

8:33 AM WebKitGTK/Gardening/Calendar edited by aboya@igalia.com

(diff)

12:14 AM Changeset in webkit [225094] by fred.wang@free.fr

• 44 edits
  15 deletes in trunk

Unreviewed, rolling out r225093.
​https://bugs.webkit.org/show_bug.cgi?id=179938

Compilation failed on WinCairo 64-bit Release (Requested by
fredw on #webkit).

Reverted changeset:

"Implement VisualViewport API attributes"
​https://bugs.webkit.org/show_bug.cgi?id=179385
​https://trac.webkit.org/changeset/225093

Patch by Commit Queue <​commit-queue@webkit.org> on 2017-11-22