Timeline



Jan 29, 2018:

11:34 PM Changeset in webkit [227775] by Yusuke Suzuki
  • 9 edits
    1 add in trunk

[JSC] Relax line terminators in String to make JSON subset of JS
https://bugs.webkit.org/show_bug.cgi?id=182232

Reviewed by Keith Miller.

JSTests:

  • ChakraCore/test/es5/Lex_u3.baseline-jsc:
  • stress/relaxed-line-terminators-in-string.js: Added.

(shouldBe):

Source/JavaScriptCore:

"Subsume JSON" spec is now stage 3[1]. Before this spec change,
JSON can accept \u2028 / \u2029 in string while JS cannot do that.
It accidentally made JSON non subset of JS.

Now we extend our JS string to accept \u2028 / \u2029 to make JSON
subset of JS in this spec change.

[1]: https://github.com/tc39/proposal-json-superset

  • parser/Lexer.cpp:

(JSC::Lexer<T>::parseStringSlowCase):

LayoutTests:

  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.3.html:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A2.4.html:
11:00 PM Changeset in webkit [227774] by jmarcell@apple.com
  • 11 edits
    1 add in branches/safari-605-branch

Cherry-pick r227737. rdar://problem/36746140

10:32 PM Changeset in webkit [227773] by Carlos Garcia Campos
  • 4 edits in trunk/Source

WebDriver: evaluateJavaScriptFunction should return null when return value is undefined
https://bugs.webkit.org/show_bug.cgi?id=180350

Reviewed by Carlos Alberto Lopez Perez.

Source/WebDriver:

Stop handling the empty string as a special case of evaluateJavaScriptFunction result.

  • Session.cpp:

(WebDriver::Session::executeScript):

Source/WebKit:

undefined can't be converted to JSON string, in which case JSON.stringify() returns undefined and we handle that
case to return an empty string. We currently handle this case for execute script commands, but not in all other
cases where we use evaluateJavaScriptFunction. It would be simpler if evaluateJavaScriptFunction returned null,
because in that case we wouldn't need to handle it as a special case.

15.2 Executing Script
https://w3c.github.io/webdriver/webdriver-spec.html#dfn-json-clone

Fixes: imported/w3c/webdriver/tests/state/get_element_property.py::test_element_non_existent

  • WebProcess/Automation/WebAutomationSessionProxy.js:

(let.AutomationSessionProxy.prototype._jsonStringify): Return "null" instead of "" when undefined is given.

9:56 PM Changeset in webkit [227772] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit

Release assert in updateLayout while waiting for sync reply to WebPageProxy::HasInsecureContent
https://bugs.webkit.org/show_bug.cgi?id=182273

Reviewed by Chris Dumez.

The assertion was caused by unrelated sync IPCs being processed while WebContent process is waiting for
the reply to WebPageProxy::HasInsecureContent. Since this IPC can be used while creating CachedFrame,
it's not safe to execute arbitrary code.

Fixed the bug by using DoNotProcessIncomingMessagesWhenWaitingForSyncReply added in r227566.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::savePlatformDataToCachedFrame):

9:36 PM Changeset in webkit [227771] by wenson_hsieh@apple.com
  • 2 edits in trunk/Source/WebKit

Add a build step to copy resources from WebKitAdditions as bundle resources in WebKit
https://bugs.webkit.org/show_bug.cgi?id=182268
<rdar://problem/37003784>

Reviewed by Tim Horton and Dan Bernstein.

Adds a "Copy Additional Resources" phase when building WebKit. This phase copies resources from
usr/local/include/WebKitAdditions/WebKit/AdditionalResources in the build directory into the
unlocalized resources directory. If the AdditionalResources directory does not exist in the build
directory, we fall back to searching the SDK.

  • WebKit.xcodeproj/project.pbxproj:
6:15 PM Changeset in webkit [227770] by commit-queue@webkit.org
  • 7 edits in trunk

ServiceWorkerClientFetch should not consider responses without Location headers as redirection responses
https://bugs.webkit.org/show_bug.cgi?id=182134

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-29
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:

Source/WebKit:

As per fetch spec, a response with a redirection status code but no Location header should not be considered as a redirection.
This is also consistent with SubresourceLoader::didReceiveResponse.

  • WebProcess/Storage/ServiceWorkerClientFetch.cpp:

(WebKit::ServiceWorkerClientFetch::didReceiveResponse):

LayoutTests:

6:04 PM Changeset in webkit [227769] by Antti Koivisto
  • 2 edits in trunk/PerformanceTests

StyleBench: Remove : from a test name
https://bugs.webkit.org/show_bug.cgi?id=182258

Reviewed by Ryosuke Niwa.

It breaks reporting.

  • StyleBench/resources/style-bench.js:

(nthPseudoClassConfiguration):

5:41 PM Changeset in webkit [227768] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Cache API should make sure to resolve caches.open promises in the same order as called
https://bugs.webkit.org/show_bug.cgi?id=182193
<rdar://problem/36930363>

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-29
Reviewed by Chris Dumez.

Source/WebCore:

Covered by LayoutTests/http/wpt/cache-storage/cache-open-delete-in-parallel.https.html.

  • Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::doRemove): Removed optimization consisting in removing the cache from DOMCacheStorage object synchronously.
This optimization prevents going to the network process to try deleting the cache.

Source/WebKit:

Covered by added test.
Whenever opening/removing a cache requires writing to disk, wait to finish the task
until any disk writing task is done.
Applying this strategy when clearing data so that we also clear data that is pending to be written.
For removing cache, we now return whether a cache was actually deleted by returning zero as removed cache identifier.
WebCore uses that information to return true/false as promise resolution value.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::retrieveCaches):

  • NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::clear):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):
(WebKit::CacheStorage::Caches::writeCachesToDisk):
(WebKit::CacheStorage::Caches::cacheInfos):
(WebKit::CacheStorage::Caches::cacheInfos const): Deleted.

  • NetworkProcess/cache/CacheStorageEngineCaches.h:

(WebKit::CacheStorage::Caches::createWeakPtr):

LayoutTests:

  • http/wpt/cache-storage/cache-open.https-expected.txt: Added.
  • http/wpt/cache-storage/cache-open.https.html: Added.
5:38 PM Changeset in webkit [227767] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Temporarily skip StyleBench until webkit.org/b/182088 is fixed.

  • Skipped:
5:33 PM Changeset in webkit [227766] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/errorhandling.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=182177

Unreviewed test expectations.

5:27 PM Changeset in webkit [227765] by achristensen@apple.com
  • 6 edits in trunk

Clean up API after bugs 178240 and 176474
https://bugs.webkit.org/show_bug.cgi?id=182259

Reviewed by Dan Bernstein.

Source/WebKit:

NS_OPTIONS should be NSUInteger, not NSInteger. This is how all other NS_OPTIONS in WebKit are,
and it's necessary if we get really big numbers as options. Changing them won't cause binary
incompatibility unless someone does signed integer comparison with currently invalid values.

Added availability macros I forgot to add earlier.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(TEST):
(-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):

5:20 PM Changeset in webkit [227764] by jiewen_tan@apple.com
  • 60 edits in trunk

[WebAuthN] Add a compile-time feature flag
https://bugs.webkit.org/show_bug.cgi?id=182211
<rdar://problem/36936365>

Reviewed by Brent Fulgham.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add a compile-time feature flag for WebAuthN as most of the functionality is platform
dependent.

No tests.

  • Configurations/FeatureDefines.xcconfig:
  • Modules/credentialmanagement/BasicCredential.cpp:
  • Modules/credentialmanagement/BasicCredential.h:
  • Modules/credentialmanagement/BasicCredential.idl:
  • Modules/credentialmanagement/CredentialCreationOptions.h:
  • Modules/credentialmanagement/CredentialCreationOptions.idl:
  • Modules/credentialmanagement/CredentialRequestOptions.h:
  • Modules/credentialmanagement/CredentialRequestOptions.idl:
  • Modules/credentialmanagement/CredentialsContainer.cpp:
  • Modules/credentialmanagement/CredentialsContainer.h:
  • Modules/credentialmanagement/CredentialsContainer.idl:
  • Modules/credentialmanagement/NavigatorCredentials.cpp:
  • Modules/credentialmanagement/NavigatorCredentials.h:
  • Modules/credentialmanagement/NavigatorCredentials.idl:
  • Modules/webauthn/Authenticator.cpp:
  • Modules/webauthn/Authenticator.h:
  • Modules/webauthn/AuthenticatorAssertionResponse.cpp:
  • Modules/webauthn/AuthenticatorAssertionResponse.h:
  • Modules/webauthn/AuthenticatorAssertionResponse.idl:
  • Modules/webauthn/AuthenticatorAttestationResponse.cpp:
  • Modules/webauthn/AuthenticatorAttestationResponse.h:
  • Modules/webauthn/AuthenticatorAttestationResponse.idl:
  • Modules/webauthn/AuthenticatorResponse.cpp:
  • Modules/webauthn/AuthenticatorResponse.h:
  • Modules/webauthn/AuthenticatorResponse.idl:
  • Modules/webauthn/PublicKeyCredential.cpp:
  • Modules/webauthn/PublicKeyCredential.h:
  • Modules/webauthn/PublicKeyCredential.idl:
  • Modules/webauthn/PublicKeyCredentialCreationOptions.h:
  • Modules/webauthn/PublicKeyCredentialCreationOptions.idl:
  • Modules/webauthn/PublicKeyCredentialDescriptor.h:
  • Modules/webauthn/PublicKeyCredentialDescriptor.idl:
  • Modules/webauthn/PublicKeyCredentialRequestOptions.h:
  • Modules/webauthn/PublicKeyCredentialRequestOptions.idl:
  • Modules/webauthn/PublicKeyCredentialType.h:
  • Modules/webauthn/PublicKeyCredentialType.idl:
  • bindings/js/JSAuthenticatorResponseCustom.cpp:
  • bindings/js/JSBasicCredentialCustom.cpp:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

Skip WebAuthN related tests on certain platforms as they won't
support it immediately.

  • platform/gtk/TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wpe/TestExpectations:
4:37 PM Changeset in webkit [227763] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark webrtc/captureCanvas-webrtc.html as flaky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=181835

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
4:25 PM Changeset in webkit [227762] by wilander@apple.com
  • 16 edits in trunk/Source

Resource Load Statistics: Introduce debug mode as experimental feature
https://bugs.webkit.org/show_bug.cgi?id=182199
<rdar://problem/36930364>

Reviewed by Alex Christensen.

Source/WebCore:

No new tests. This adds an experimental feature.

The only changes to default behavior are:

  • Increased resolution on timestamps which is needed to be able to set shorter timeouts in debug mode.
  • Only update partitioning and blocking table when needed. This is an optimization which pays off in less XPC with shorter timeouts.
  • loader/ResourceLoadObserver.cpp:

(WebCore::reduceTimeResolution):
(WebCore::ResourceLoadObserver::logFrameNavigation):
(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logWebSocketLoading):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
(WebCore::reduceToHourlyTimeResolution): Deleted.

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setResourceLoadStatisticsDebugMode):
(WebCore::RuntimeEnabledFeatures::resourceLoadStatisticsDebugMode const):

  • page/Settings.yaml:

Source/WebKit:

The only changes to default behavior are:

  • Increased resolution on timestamps which is needed to be able to set shorter timeouts in debug mode.
  • Only update partitioning and blocking table when needed. This is an optimization which pays off in less XPC with shorter timeouts.
  • Shared/WebPreferences.yaml:
  • UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::resourceLoadStatisticsDebugMode const):
(API::WebsiteDataStore::setResourceLoadStatisticsDebugMode):

  • UIProcess/API/APIWebsiteDataStore.h:
  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetResourceLoadStatisticsDebugMode):

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _resourceLoadStatisticsDebugMode]):
(-[WKWebsiteDataStore _setResourceLoadStatisticsDebugMode:]):

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::setResourceLoadStatisticsDebugMode):
(WebKit::WebResourceLoadStatisticsStore::logUserInteraction):

  • UIProcess/WebResourceLoadStatisticsStore.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resourceLoadStatisticsDebugMode const):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsDebugMode):

  • UIProcess/WebsiteData/WebsiteDataStore.h:
4:16 PM Changeset in webkit [227761] by wilander@apple.com
  • 3 edits in trunk/LayoutTests

Switch grandfathering layout test to trigger on data record scanning instead of data record modification
https://bugs.webkit.org/show_bug.cgi?id=181482
<rdar://problem/36549026>

Unreviewed test gardening.

  • http/tests/resourceLoadStatistics/grandfathering.html:

Switched from
testRunner.installStatisticsDidModifyDataRecordsCallback()
to
testRunner.installStatisticsDidScanDataRecordsCallback().

  • platform/mac-wk2/TestExpectations:

Marked as [ Pass ] again.

3:39 PM Changeset in webkit [227760] by gskachkov@gmail.com
  • 10 edits
    4 adds in trunk

FetchResponse should support ConsumeData callback on chunk data is received: handling ReadableStream bodies
https://bugs.webkit.org/show_bug.cgi?id=182008

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/fetch-event-respond-with-readable-stream-chunk.https-expected.txt: Added.
  • web-platform-tests/service-workers/service-worker/fetch-event-respond-with-readable-stream-chunk.https.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-event-respond-with-readable-stream-chunk-iframe.html: Added.
  • web-platform-tests/service-workers/service-worker/resources/fetch-event-respond-with-readable-stream-chunk-worker.js: Added.

(const.process):
(this.step):
(this.run):
(const.asyncSteps):

Source/WebCore:

Modify FetchResponse to support ConsumeData callback with
handling of ReadableStream by chunks

  • Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::put):

  • Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::resolve):

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::consumeBodyFromReadableStream):

  • Modules/fetch/FetchResponse.h:
  • Modules/streams/ReadableStreamChunk.h: Added.
  • Modules/streams/ReadableStreamSink.cpp:

(WebCore::ReadableStreamToSharedBufferSink::enqueue):
(WebCore::ReadableStreamToSharedBufferSink::close):

  • Modules/streams/ReadableStreamSink.h:
  • WebCore.xcodeproj/project.pbxproj:
  • workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::processResponse):

3:20 PM Changeset in webkit [227759] by aestes@apple.com
  • 11 edits
    7 adds in trunk

[iOS] Restrict synthetic clicks to the origin that handled the underlying touch event
https://bugs.webkit.org/show_bug.cgi?id=182252
<rdar://problem/21555881>

Reviewed by Tim Horton.

Source/WebCore:

Test: http/tests/events/touch/ios/cross-frame-single-tap-same-origin.https.html

  • dom/Document.h:

(WebCore::Document::handlingTouchEvent const):

  • page/EventHandler.h:

(WebCore::EventHandler::touchEventTargetSubframe const):
(WebCore::EventHandler::touches const):

Exposed some information needed by WebPage::updatePotentialTapSecurityOrigin().

  • page/Frame.h:
  • page/ios/FrameIOS.mm:

(WebCore::Frame::betterApproximateNode):
(WebCore::Frame::qualifyingNodeAtViewportLocation):

Changed NodeQualifier from a function pointer to a WTF::Function.

(WebCore::Frame::nodeRespondingToClickEvents):

Turned ancestorRespondingToClickEvents() into a lambda that captures originRestriction. In
the lambda, if there is an origin restriction, return nullptr if the hit test result's inner
Node is not in the restricted origin.

(WebCore::Frame::nodeRespondingToScrollWheelEvents):

Turned ancestorRespondingToScrollWheelEvents() into a lambda.

(WebCore::ancestorRespondingToScrollWheelEvents):

Moved to lambda in nodeRespondingToScrollWheelEvents().

(WebCore::ancestorRespondingToClickEvents):

Moved to lambda in nodeRespondingToClickEvents().

Source/WebKit:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::dispatchTouchEvent):
(WebKit::WebPage::updatePotentialTapSecurityOrigin):

Record the target frame origin of touch events that are potential taps, are
TouchStart events, are targeted in frames that have touch event listeners, and are not
handled by those listeners.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::potentialTapAtPosition):
(WebKit::WebPage::commitPotentialTap):
(WebKit::WebPage::cancelPotentialTapInFrame):

Passed the target frame origin to Frame::nodeRespondingToClickEvents() then cleared it.

LayoutTests:

  • TestExpectations:
  • http/tests/events/touch/ios/cross-frame-single-tap-same-origin.https-expected.txt: Added.
  • http/tests/events/touch/ios/cross-frame-single-tap-same-origin.https.html: Added.
  • http/tests/events/touch/ios/resources/click-target.html: Added.
3:17 PM Changeset in webkit [227758] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Make policy checks more robust against null pointer dereferencing
https://bugs.webkit.org/show_bug.cgi?id=182263
<rdar://problem/34895714>

Reviewed by Tim Horton.

We're still dereferencing null. Check everything.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

2:35 PM Changeset in webkit [227757] by emilio
  • 2 edits in trunk/Source/WebCore

Trivially cleanup std::optional usage in RenderBlockFlow.
https://bugs.webkit.org/show_bug.cgi?id=182142

Reviewed by Antti Koivisto.

No new tests, no behavior change.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::firstLineBaseline const):
(WebCore::RenderBlockFlow::inlineBlockBaseline const):

2:09 PM Changeset in webkit [227756] by rniwa@webkit.org
  • 3 edits
    6 copies in trunk/PerformanceTests

Make StyleBench compatible with run-benchmark and run-perf-tests
https://bugs.webkit.org/show_bug.cgi?id=182262

Reviewed by Antti Koivisto.

Copied resource files referenced from Speedometer directory since run-benchmark needs to be able
to checkout each benchmark separately.

Removed the code to create tests of the same name five times in makeSteps since this
won't be compatible with either run-benchmark or run-perf-tests.

  • StyleBench/index.html: Removed the code to show warnings for local files since run-benchmark

doesn't use HTTP server in WebDriver mode.

  • StyleBench/resources/benchmark-report.js: Copied from resources/benchmark-report.js.
  • StyleBench/resources/benchmark-runner.js: Copied from resources/benchmark-runner.js.

(BenchmarkRunner.prototype._finalize): Use the correction factor of 8 instead of 5 in StyleBench.

  • StyleBench/resources/gauge.png: Copied from resources/gauge.png.
  • StyleBench/resources/gauge@2x.png: Copied from resources/gauge@2x.png.
  • StyleBench/resources/main.css: Copied from resources/main.css.
  • StyleBench/resources/main.js: Copied from resources/main.js.
  • StyleBench/resources/tests.js:

(makeSteps): Only make each test once.

2:00 PM Changeset in webkit [227755] by Brent Fulgham
  • 11 edits in trunk/Source

Add telemetry to track storage access API adoption
https://bugs.webkit.org/show_bug.cgi?id=182197
<rdar://problem/35803309>

Reviewed by Chris Dumez.
Source/WebCore:


Part 1: Add telemetry for the user interaction case

This patch adds telemetry to track how frequently third-party cookies are
used in a first party context due to user interaction. This will help
understand cases where the new Storage Access API can help, and to help
us understand if we have considered relevant use cases in its design.

  • loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::setTimeToLivePartitionFree): Let the observer
know the first party interaction duration.
(WebCore::ResourceLoadObserver::wasAccessedWithinInteractionWindow const): Added.
(WebCore::ResourceLoadObserver::logFrameNavigation): Note when a third party
resource is accessed as a first party due to user interaction.
(WebCore::ResourceLoadObserver::logSubresourceLoading): Ditto.

  • loader/ResourceLoadObserver.h:
  • loader/ResourceLoadStatistics.cpp:

(WebCore::ResourceLoadStatistics::encode const): Handle new fields.
(WebCore::ResourceLoadStatistics::decode): Ditto.

  • loader/ResourceLoadStatistics.h:

Source/WebKit:

Part 1: Add telemetry for the user interaction case

This patch adds telemetry to track how frequently third-party cookies are
used in a first party context due to user interaction. This will help
understand cases where the new Storage Access API can help, and to help
us understand if we have considered relevant use cases in its design.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • UIProcess/WebResourceLoadStatisticsTelemetry.cpp:

(WebKit::sortedPrevalentResourceTelemetry): Update for new telemetry.
(WebKit::submitTopList): Update for new data types.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess): Handle the partitioning time
passed from the UIProcess.

1:58 PM Changeset in webkit [227754] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Fix crash when during canAuthenticateAgainstProtectionSpace
https://bugs.webkit.org/show_bug.cgi?id=182260
<rdar://problem/34911343>

Reviewed by Chris Dumez.

If we have a valid network load with no challenge completion handler and we are
telling it to continue with the challenge handling, something has gone wrong.
Maybe we've just recovered from a crashed network process. If this happens, do nothing.

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):

1:46 PM Changeset in webkit [227753] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

CalcExpressionBlendLength::evaluate hits stack limit
https://bugs.webkit.org/show_bug.cgi?id=182243

Reviewed by Zalan Bujtas.

Speculative fix to prevent nesting of CalcExpressionBlendLength.

No test, don't know how to make one.

  • platform/CalculationValue.cpp:

(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):

CalcExpressionBlendLength is only used in Length values of animated style. Normally such styles are not used
as input for further blending but there are some paths where this could in principle happen. Repeated
application (for each animation frame) could construct CalcExpressionBlendLength expression that blows
the stack when evaluated.

Speculatively fix by flattening any nesting.

  • platform/CalculationValue.h:

(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength): Deleted.

1:32 PM Changeset in webkit [227752] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

Warning in 32-bit WebKit build when trying to link to SafariSafeBrowsing
https://bugs.webkit.org/show_bug.cgi?id=182251
rdar://problem/36964995

Patch by Zach Li <zacharyli323@gmail.com> on 2018-01-29
Reviewed by Alex Christensen.

  • Configurations/WebKit.xcconfig:

Only link against SafariSafeBrowsing framework in 64-bit architecture.

  • Platform/spi/Cocoa/SafeBrowsingSPI.h:

Guard the Safe Browsing code with WK_API_ENABLED.

1:20 PM Changeset in webkit [227751] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Make sure we do not re-enter Webcore during StorageToWebProcessConnection::EstablishSWServerConnection Sync IPC
https://bugs.webkit.org/show_bug.cgi?id=182256
<rdar://problem/36689233>

Reviewed by Simon Fraser.

Make sure we do not re-enter Webcore during StorageToWebProcessConnection::EstablishSWServerConnection Sync IPC as
this can lead to crashes such as the one in <rdar://problem/36689233>.

  • WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::WebSWClientConnection):

12:38 PM Changeset in webkit [227750] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Add the support for reporting Speedometer 2.0 results to perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=182089
<rdar://problem/36172346>

Rubber-stamped by Chris Dumez.

Apparently, this has always worked since the very first version of the perf dashboard added in r163688.
The relevant code is at the line 313 of report-processor.php now.

Added regression tests for this feature since we didn't have any tests four years ago.

  • server-tests/api-report-tests.js:
12:35 PM Changeset in webkit [227749] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

REGRESSION(r225898): The perf dashboard fails to open when there are no summary pages
https://bugs.webkit.org/show_bug.cgi?id=182210

Rubber-stamped by Chris Dumez.

The bug was caused by TestFreshnessPage unconditionally assuming that summaryPageConfiguration is set.
Fixed it by not creating TestFreshnessPage when there are no summary pages specified.

Also modernized the code to use const & let instead of var.

  • public/v3/main.js:

(main):

12:34 PM Changeset in webkit [227748] by beidson@apple.com
  • 2 edits in trunk/Tools

Make the API test added in r227737 be Mac-only.

Unreviewed gardening.

  • TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
12:31 PM Changeset in webkit [227747] by rniwa@webkit.org
  • 3 edits
    1 add in trunk/Websites/perf.webkit.org

Perf dashboard's page title can be set to a previously visited page
https://bugs.webkit.org/show_bug.cgi?id=182209

Rubber-stamped by Chris Dumez.

Before this patch, opening a page and navigating away from it could result in the page title
getting set to that of the previously visited page after the new page had been opened.

This bug was caused by Page.render keep setting document.title even though the page is no longer
the currently open page of the router. Fixed it by exiting early in Page.enqueueToRender when
this page is not the currently open page of the router.

Also added basic tests for Page.

  • browser-tests/index.html:
  • browser-tests/page-tests.js: Added.
  • public/v3/pages/page.js:

(Page): Removed the unused second constructor argument.
(Page.prototype.enqueueToRender): Fixed the bug.
(Page.prototype.render): Use const instead of var.

12:27 PM Changeset in webkit [227746] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

CommitLogViewer should not fetch commits in serial
https://bugs.webkit.org/show_bug.cgi?id=182207

Rubber-stamped by Chris Dumez.

Fetch both the commits in the range as well as the preceding commit at once instead of
fetching the preceding commit only after the commits in the range had been fetched.

  • browser-tests/commit-log-viewer-tests.js: Fixed the tcoest case after r224227.
  • public/v3/components/commit-log-viewer.js:

(CommitLogViewer.prototype._fetchCommitLogs): Fetch commits in parallel.

11:45 AM Changeset in webkit [227745] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Drop unnecessary "ServiceWorker Task Thread" in SWServer
https://bugs.webkit.org/show_bug.cgi?id=182253

Reviewed by Youenn Fablet.

Drop unnecessary "ServiceWorker Task Thread" in SWServer. We're spinning a thread for
each SWServer that is never used.

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::~SWServer):
(WebCore::SWServer::SWServer):
(WebCore::SWServer::taskThreadEntryPoint): Deleted.
(WebCore::SWServer::postTask): Deleted.
(WebCore::SWServer::postTaskReply): Deleted.
(WebCore::SWServer::handleTaskRepliesOnMainThread): Deleted.

  • workers/service/server/SWServer.h:
11:29 AM Changeset in webkit [227744] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

[GTK] Zooming gesture incorrectly uses scale instead of zoom
https://bugs.webkit.org/show_bug.cgi?id=182174

Patch by Jan-Michael Brummer <jan.brummer@tabos.org> on 2018-01-29
Reviewed by Michael Catanzaro.

Switch zooming gesture to use zoom instead of scale function.

  • UIProcess/gtk/GestureController.cpp:

(WebKit::GestureController::ZoomGesture::begin):
(WebKit::GestureController::ZoomGesture::handleZoom):

11:27 AM Changeset in webkit [227743] by Matt Lewis
  • 10 edits in trunk

Unreviewed, rolling out r227731.

This caused and assertion failure in API tests.

Reverted changeset:

"Layout Test fast/events/beforeunload-dom-manipulation-
crash.html is crashing"
https://bugs.webkit.org/show_bug.cgi?id=181204
https://trac.webkit.org/changeset/227731

11:13 AM Changeset in webkit [227742] by msaboff@apple.com
  • 3 edits
    1 add in trunk

REGRESSION (r227341): DFG_ASSERT failure at JSC::DFG::AtTailAbstractState::forNode()
https://bugs.webkit.org/show_bug.cgi?id=182249

Reviewed by Keith Miller.

JSTests:

New regression test.

  • stress/compare-clobber-untypeduse.js: Added.

Source/JavaScriptCore:

Changed clobberize() handling of CompareEq, et al to properly handle comparisons between
Untyped and Object values when compared against built in types. Such comparisons can
invoke toNumber() or other methods.

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

10:37 AM Changeset in webkit [227741] by commit-queue@webkit.org
  • 1 edit
    2 moves in trunk/LayoutTests

Move http/wpt/service-workers/clone-opaque-being-loaded-response.https.html to use HTTP
https://bugs.webkit.org/show_bug.cgi?id=182202

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-29
Reviewed by Chris Dumez.

Some bots dislike cross origin HTTPS fetches.

  • http/wpt/service-workers/clone-opaque-being-loaded-response-expected.txt: Renamed from LayoutTests/http/wpt/service-workers/clone-opaque-being-loaded-response.https-expected.txt.
  • http/wpt/service-workers/clone-opaque-being-loaded-response.html: Renamed from LayoutTests/http/wpt/service-workers/clone-opaque-being-loaded-response.https.html.
10:37 AM Changeset in webkit [227740] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

WPT test exporter should add WebKit export in its PR description
https://bugs.webkit.org/show_bug.cgi?id=182246

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-29
Reviewed by Chris Dumez.

Updating PR description body to contain the words 'WebKit export'.
That way, WPT PR bot will mark the PR as reviewed downstream.

  • Scripts/webkitpy/w3c/test_exporter.py:

(TestExporter.init):
(TestExporter.make_pull_request):

  • Scripts/webkitpy/w3c/test_exporter_unittest.py:

(TestExporterTest.test_export):

10:18 AM Changeset in webkit [227739] by rniwa@webkit.org
  • 6 edits
    2 adds in trunk/Tools

Add the support for running Speedometer 2.0 to run-benchmark
https://bugs.webkit.org/show_bug.cgi?id=182231

Reviewed by Antti Koivisto.

Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
requires aggregating the geometric mean out of total time spent in each suite.

Also added --show-iteration-values to show individual measured values in each iteration.

  • Scripts/webkitpy/benchmark_runner/benchmark_results.py:

(BenchmarkResults.format): Added show_iteration_values as an option.
(BenchmarkResults._format_tests): Ditto.
(BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
is easily parsable as a JSON array.
(BenchmarkResults._format_values.format_scaled): Added. A helper function.
(BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
had exactly one aggregator.
(BenchmarkResults._lint_results):
(BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
test's name only when the parent test had an aggregator, by self-explanatory parent_test and
parent_aggregator_list.
(BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
(BenchmarkResults._lint_configuration):

  • Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:

(test_format_values_with_no_unit_scaling): Added.
(test_format_values_with_iteration_values): Added.
(test_format_values_with_no_unit_scaling_and_iteration_values): Added.
(test_aggregate_results_from_another_aggregator): Added.
(test_lint_results): Added a test case.

  • Scripts/webkitpy/benchmark_runner/benchmark_runner.py:

(BenchmarkRunner.init): Added show_iteration_values as an argument.
(BenchmarkRunner._run_benchmark): Ditto.
(BenchmarkRunner.show_results): Ditto.

  • Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
  • Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
  • Scripts/webkitpy/benchmark_runner/run_benchmark.py:

(parse_args): Added --show-iteration-values as a boolean argument.
(run_benchmark_plan): Ditto.
(start): Ditto.

  • Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:

(WebServerBenchmarkRunner.init): Ditto.

9:47 AM Changeset in webkit [227738] by Matt Lewis
  • 15 edits
    2 deletes in trunk

Unreviewed, rolling out r227725.

This caused internal failures.

Reverted changeset:

"JSC Sampling Profiler: Detect tester and testee when sampling
in RegExp JIT"
https://bugs.webkit.org/show_bug.cgi?id=152729
https://trac.webkit.org/changeset/227725

9:45 AM Changeset in webkit [227737] by beidson@apple.com
  • 11 edits
    1 add in trunk

Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
https://bugs.webkit.org/show_bug.cgi?id=182229

Reviewed by Chris Dumez.

Source/WebCore:

Covered by existing LayoutTests and a new API test.

  • dom/messageports/MessagePortChannel.cpp:

(WebCore::MessagePortChannel::checkRemotePortForActivity): Don't use the global singleton

provider. Instead use the provider that belongs to the owning registry.

  • dom/messageports/MessagePortChannelProviderImpl.cpp:

(WebCore::MessagePortChannelProviderImpl::MessagePortChannelProviderImpl): Pass a reference

to *this to the Registry.

  • dom/messageports/MessagePortChannelProviderImpl.h:
  • dom/messageports/MessagePortChannelRegistry.cpp:

(WebCore::MessagePortChannelRegistry::MessagePortChannelRegistry): Keep a Provider member so

MessagePortChannels can get to it instead of relying on the global singleton provider.

  • dom/messageports/MessagePortChannelRegistry.h:

(WebCore::MessagePortChannelRegistry::provider):

Source/WebKit:

  • UIProcess/UIMessagePortChannelProvider.cpp:

(WebKit::UIMessagePortChannelProvider::UIMessagePortChannelProvider):

  • UIProcess/WebPageProxy.cpp:

(WebKit::m_configurationPreferenceValues): The UI process does not need to override the

global singleton provider. It can remain the default ProviderImpl to allow WK1 views
to work fine, too.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
9:07 AM Changeset in webkit [227736] by Ryan Haddad
  • 2 edits in branches/safari-605-branch/LayoutTests

Cherry-pick r227708. rdar://problem/36915685

9:07 AM Changeset in webkit [227735] by Ryan Haddad
  • 2 edits in branches/safari-605-branch/LayoutTests

Cherry-pick r227203. rdar://problem/36837397

8:57 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
8:56 AM Changeset in webkit [227734] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

Unreviewed WPE test gardening

  • platform/wpe/TestExpectations:
8:47 AM Changeset in webkit [227733] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

WebDriver: ASSERTION FAILED: !m_loadTimer.isActive()
https://bugs.webkit.org/show_bug.cgi?id=182237

Reviewed by Carlos Alberto Lopez Perez.

We should stop the load timer when we dispatch the pending navigation callbacks due to an alert open.

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::willShowJavaScriptDialog):

8:45 AM Changeset in webkit [227732] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

WebDriver: properly recover w3c tests after a webdriver server crash
https://bugs.webkit.org/show_bug.cgi?id=182242

Reviewed by Carlos Alberto Lopez Perez.

When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
relaunching the server after every test failure, because other failures, even when not crashing the server,
might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.

  • Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:

(WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.

  • Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:

(WebDriverW3CExecutor.init): Save timeout and expectations and do not import pytest.
(WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
(WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
(WebDriverW3CExecutor._runner): Run the tests using pytest runner.
(WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.

8:02 AM Changeset in webkit [227731] by pvollan@apple.com
  • 10 edits in trunk

Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=181204
<rdar://problem/36256274>

Reviewed by Ryosuke Niwa.

Source/WebCore:

When a frame element is moved in the DOM tree during the execution of a beforeunload handler,
the frame will be detached when removed from its previous position in the DOM tree. When being
detached, an attempt will also be made to stop the load by calling FrameLoader::stopAllLoaders().
However, this method will return early when executed in a beforeunload handler, since navigation
is not allowed then. The end result is a detached frame which will continue to load, and hitting
asserts in DocumentLoader::dataReceived(), and DocumentLoader::notifyFinished(). It should be
possible to stop a frame load, even when executing a beforeunload handler.

No new tests. Covered by the existing test fast/events/beforeunload-dom-manipulation-crash.html.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::isStopLoadingAllowed const):
(WebCore::FrameLoader::stopAllLoaders):

  • loader/FrameLoader.h:

Tools:

Implement 'testRunner.forceImmediateCompletion()' for WK1.

  • DumpRenderTree/TestRunner.cpp:

(forceImmediateCompletionCallback):
(TestRunner::staticFunctions):

LayoutTests:

  • fast/events/beforeunload-dom-manipulation-crash.html: Make it clear that the

frame element is a child of the 'del' element.

  • fast/events/beforeunload-dom-manipulation-crash-expected.html:
  • platform/mac-wk1/TestExpectations: Unskip test.
7:56 AM WebKitGTK/Gardening/Calendar edited by zandobersek@gmail.com
(diff)
7:35 AM Changeset in webkit [227730] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark js/dom/array-with-double-assign.html as a failure on Windows.
https://bugs.webkit.org/show_bug.cgi?id=182239

Unreviewed test gardening.

  • platform/win/TestExpectations:
7:26 AM Changeset in webkit [227729] by magomez@igalia.com
  • 2 edits in trunk/Source/WebCore

[CoordnatedGraphics] A child layer of a semitransparent layer isn't clipped properly
https://bugs.webkit.org/show_bug.cgi?id=181080

Reviewed by Žan Doberšek.

Check whether the applied clipping area is empty before drawing the children of a TextureMapperLayer. If
the area is empty no children will be drawn, so we can avoid drawing them.

No new tests -- no change in behavior.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelfAndChildren):

6:32 AM Changeset in webkit [227728] by zandobersek@gmail.com
  • 11 edits in trunk/Source

[Cairo] Add GraphicsContextImplCairo::createFactory() helpers
https://bugs.webkit.org/show_bug.cgi?id=182238

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Instead of duplicating lambdas that return a newly-created
GraphicsContextImplCairo object, provide static createFactory() helpers
on that class that produce GraphicsContextImplFactory wrappers which are
then invoked in the GraphicsContext constructor. The static functions
accept either the PlatformContextCairo reference or the cairo_t pointer,
invoking the proper GraphicsContextImplCairo constructor in the returned
lambda wrapper.

No new tests -- no change in functionality.

  • platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::createFactory):

  • platform/graphics/cairo/GraphicsContextImplCairo.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/cairo/PathCairo.cpp:

(WebCore::Path::strokeBoundingRect const):
(WebCore::Path::strokeContains const):

  • platform/graphics/nicosia/NicosiaPaintingContextCairo.cpp:

(Nicosia::PaintingContextCairo::PaintingContextCairo):

  • platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):

Source/WebKit:

Use GraphicsContextImplCairo::createFactory() helpers throughout the
Cairo-specific GraphicsContext constructors in the WebKit layer.

  • Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):

  • UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::incorporateUpdate):

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::renderPage):

2:56 AM Changeset in webkit [227727] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Construct GraphicsContext with NonPaintingReasons::NoReason in FrameView::adjustPageHeightDeprecated()
https://bugs.webkit.org/show_bug.cgi?id=182235

Reviewed by Carlos Garcia Campos.

Pass the NonPaintingReasons::NoReason value to the GraphicsContext
constructor in FrameView::adjustPageHeightDeprecated(). This has the
same effect as when passing a null PlatformGraphicsContext to the
constructor, which effectively disables any painting through that
GraphicsContext, but doesn't have a platform-specific connotation.

No new tests -- no change in functionality.

  • page/FrameView.cpp:

(WebCore::FrameView::adjustPageHeightDeprecated):

2:56 AM Changeset in webkit [227726] by zandobersek@gmail.com
  • 11 edits in trunk/Source

[Cairo] Remove the GraphicsContext(cairo_t*) constructor
https://bugs.webkit.org/show_bug.cgi?id=182234

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Instead of using the GraphicsContext(cairo_t*) constructor, leverage the
GraphicsContextImplCairo class and work with an existing Cairo context
through that GraphicsContextImpl implementation.

A new GraphicsContextImplCairo constructor is added, expecting pointer
to the cairo_t object. With that, a PlatformContextCairo object is
created, with ownership of that object now being handled by the
GraphicsContextImplCairo class.

Call sites of the GraphicsContext(cairo_t*) constructor are adjusted to
instead provide a factory function that returns a fresh
GraphicsContextImplCairo object, passing that cairo_t object to its
constructor.

No new tests -- no change in behavior.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::GraphicsContext): Deleted.

  • platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::GraphicsContextImplCairo):
(WebCore::m_private):

  • platform/graphics/cairo/GraphicsContextImplCairo.h:
  • platform/graphics/cairo/PathCairo.cpp:

(WebCore::Path::strokeBoundingRect const):
(WebCore::Path::strokeContains const):

  • platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):

Source/WebKit:

Call sites of the GraphicsContext(cairo_t*) constructor are adjusted to
instead provide a factory function that returns a fresh
GraphicsContextImplCairo object, passing that cairo_t object to its
constructor.

  • Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):

  • UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::incorporateUpdate):

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::renderPage):

2:43 AM Changeset in webkit [227725] by Yusuke Suzuki
  • 15 edits
    2 adds in trunk

JSC Sampling Profiler: Detect tester and testee when sampling in RegExp JIT
https://bugs.webkit.org/show_bug.cgi?id=152729

Reviewed by Saam Barati.

JSTests:

  • stress/sampling-profiler-regexp.js: Added.

(platformSupportsSamplingProfiler.test):
(platformSupportsSamplingProfiler.baz):
(platformSupportsSamplingProfiler):

Source/JavaScriptCore:

This patch extends SamplingProfiler to recognize JIT RegExp execution. We record
executing RegExp in VM so that SamplingProfiler can detect it. This is better
than the previous VM::isExecutingInRegExpJIT flag approach since

  1. isExecutingInRegExpJIT is set after starting executing JIT RegExp code. Thus,

if we suspend the thread just before executing this flag, or just after clearing
this flag, SamplingProfiler gets invalid frame, and frame validation fails. We
should set such a flag before and after executing JIT RegExp code.

  1. This removes VM dependency from YarrJIT which is not essential one.

We add ExecutionContext enum to RegExp::matchInline not to mark execution if it
is done in non JS thread.

  • bytecode/BytecodeDumper.cpp:

(JSC::regexpName):
(JSC::BytecodeDumper<Block>::dumpRegExps):
(JSC::regexpToSourceString): Deleted.

  • heap/Heap.cpp:

(JSC::Heap::addCoreConstraints):

  • runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::match):
(JSC::RegExp::matchConcurrently):
(JSC::RegExp::compileMatchOnly):
(JSC::RegExp::toSourceString const):

  • runtime/RegExp.h:
  • runtime/RegExpInlines.h:

(JSC::RegExp::matchInline):

  • runtime/RegExpMatchesArray.h:

(JSC::createRegExpMatchesArray):

  • runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::SamplingProfiler):
(JSC::SamplingProfiler::timerLoop):
(JSC::SamplingProfiler::takeSample):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::StackFrame::nameFromCallee):
(JSC::SamplingProfiler::StackFrame::displayName):
(JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):
(JSC::SamplingProfiler::StackFrame::functionStartLine):
(JSC::SamplingProfiler::StackFrame::functionStartColumn):
(JSC::SamplingProfiler::StackFrame::sourceID):
(JSC::SamplingProfiler::StackFrame::url):
(WTF::printInternal):
(JSC::SamplingProfiler::~SamplingProfiler): Deleted.

  • runtime/SamplingProfiler.h:
  • runtime/VM.h:
  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::jitCompile):

  • yarr/YarrJIT.h:
2:20 AM Changeset in webkit [227724] by fred.wang@free.fr
  • 2 edits in trunk/Tools

Unreviewed, add myself to some watch lists.

Patch by Frederic Wang <fwang@igalia.com> on 2018-01-29

  • Scripts/webkitpy/common/config/watchlist:
1:25 AM Changeset in webkit [227723] by Yusuke Suzuki
  • 24 edits
    4 adds in trunk

[DFG][FTL] WeakMap#set should have DFG node
https://bugs.webkit.org/show_bug.cgi?id=180015

Reviewed by Saam Barati.

JSTests:

  • stress/weakmap-set-change-get.js: Added.

(shouldBe):
(test):

  • stress/weakmap-set-cse.js: Added.

(shouldBe):
(test):

  • stress/weakset-add-change-get.js: Added.

(shouldBe):

  • stress/weakset-add-cse.js: Added.

(shouldBe):

Source/JavaScriptCore:

This patch adds WeakMapSet and WeakSetAdd DFG nodes to handle them efficiently in DFG and FTL.
We also define CSE rules for them. Now, WeakMapSet and WeakSetAdd can offer the results of
the subsequent WeakMapGet if CSE allows.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):
WeakMap operations do not cause GC.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileWeakSetAdd):
(JSC::DFG::SpeculativeJIT::compileWeakMapSet):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileWeakSetAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileWeakMapSet):

  • jit/JITOperations.h:
  • runtime/Intrinsic.cpp:

(JSC::intrinsicName):

  • runtime/Intrinsic.h:
  • runtime/WeakMapPrototype.cpp:

(JSC::WeakMapPrototype::finishCreation):

  • runtime/WeakSetPrototype.cpp:

(JSC::WeakSetPrototype::finishCreation):

Jan 28, 2018:

10:35 PM Changeset in webkit [227722] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Overflow of formulas is hidden for display mathematics
https://bugs.webkit.org/show_bug.cgi?id=160547

Patch by Minsheng Liu <lambda@liu.ms> on 2018-01-28
Reviewed by Frédéric Wang.

Source/WebCore:

Previously, <math> with display="block" uses its container's logical width as logical width.
However, that behavior will truncate overflowed contents. The patch fixes it by setting
the logical width as its content width rather than its container's logical width
if the former is wider than the latter.

Test: mathml/presentation/display-math-horizontal-overflow.html

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layoutBlock):

LayoutTests:

Add a test to ensure <math> with display="block" will not truncate overflowed contents.

  • mathml/presentation/display-math-horizontal-overflow-expected.txt: Added.
  • mathml/presentation/display-math-horizontal-overflow.html: Added.
9:08 PM Changeset in webkit [227721] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

LargeAllocation should do the same distancing as MarkedBlock
https://bugs.webkit.org/show_bug.cgi?id=182226

Reviewed by Saam Barati.

This makes LargeAllocation do the same exact distancing that MarkedBlock promises to do.

To make that possible, this patch first makes MarkedBlock know exactly how much distancing it
is doing:

  • I've rationalized the payloadSize calculation. In particular, I made MarkedSpace use the calculation done in MarkedBlock. MarkedSpace used to do the math a different way. This keeps the old way just for a static_assert.


  • The promised amount of distancing is now codified in HeapCell.h as minimumDistanceBetweenCellsFromDifferentOrigins. We assert that the footer size is at least as big as this. I didn't want to just use footer size for this constant because then, if you increased the size of the footer, you'd also add padding to every large allocation.


Then this patch just adds minimumDistanceBetweenCellsFromDifferentOrigins to each large
allocation. It also zeroes that slice of memory to prevent any information leaks that way.

This is perf neutral. Large allocations start out at ~8000 bytes. The amount of padding is
~300 bytes. That's 3.75% space overhead for objects that are ~8000 bytes, zero overhead for
smaller objects, and diminishing overhead for larger objects. We allocate very few large
objects, so we shouldn't have any real space overhead from this.

  • heap/HeapCell.h:
  • heap/LargeAllocation.cpp:

(JSC::LargeAllocation::tryCreate):

  • heap/MarkedBlock.h:
  • heap/MarkedSpace.h:
12:54 PM Changeset in webkit [227720] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed WPE gardening.

  • platform/wpe/TestExpectations: Add test failure expectations. Shuffle

around a few expectations and eliminate duplicate ones, removing overlap
warnings printed out when invoking run-webkit-tests.

12:00 PM Changeset in webkit [227719] by zandobersek@gmail.com
  • 2 edits
    4 adds in trunk/LayoutTests

Unreviewed GTK+ gardening.

  • platform/gtk/TestExpectations: Add failure expectations for three tests.
  • platform/gtk/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/errorhandling-expected.txt:

Added a test baseline due to console messages being output in a slightly different order.

11:20 AM WebKitGTK/2.18.x edited by Michael Catanzaro
Add warning about r227544 (diff)
11:08 AM Changeset in webkit [227718] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Make MarkedBlock::Footer bigger
https://bugs.webkit.org/show_bug.cgi?id=182220

Reviewed by JF Bastien.

This makes the block footer larger by moving the newlyAllocated bits from the handle into
the footer.

It used to be profitable to put anything we could into the handle because that would free up
payload space inside the block. But now that we want to use the footer for padding, it's
profitable to put GC state information - especially data that is used by the GC itself and so
is not useful for a Spectre attack - into the footer to increase object distancing.

  • heap/CellContainer.cpp:

(JSC::CellContainer::isNewlyAllocated const):

  • heap/IsoCellSet.cpp:

(JSC::IsoCellSet::sweepToFreeList):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::Handle):
(JSC::MarkedBlock::Footer::Footer):
(JSC::MarkedBlock::Handle::stopAllocating):
(JSC::MarkedBlock::Handle::lastChanceToFinalize):
(JSC::MarkedBlock::Handle::resumeAllocating):
(JSC::MarkedBlock::aboutToMarkSlow):
(JSC::MarkedBlock::resetAllocated):
(JSC::MarkedBlock::Handle::resetAllocated): Deleted.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::newlyAllocatedVersion const):
(JSC::MarkedBlock::isNewlyAllocated):
(JSC::MarkedBlock::setNewlyAllocated):
(JSC::MarkedBlock::clearNewlyAllocated):
(JSC::MarkedBlock::newlyAllocated const):
(JSC::MarkedBlock::Handle::newlyAllocatedVersion const): Deleted.
(JSC::MarkedBlock::Handle::isNewlyAllocated): Deleted.
(JSC::MarkedBlock::Handle::setNewlyAllocated): Deleted.
(JSC::MarkedBlock::Handle::clearNewlyAllocated): Deleted.
(JSC::MarkedBlock::Handle::newlyAllocated const): Deleted.

  • heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::isNewlyAllocatedStale const):
(JSC::MarkedBlock::hasAnyNewlyAllocated):
(JSC::MarkedBlock::Handle::isLive):
(JSC::MarkedBlock::Handle::specializedSweep):
(JSC::MarkedBlock::Handle::newlyAllocatedMode):
(JSC::MarkedBlock::Handle::isNewlyAllocatedStale const): Deleted.
(JSC::MarkedBlock::Handle::hasAnyNewlyAllocated): Deleted.

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::endMarking):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::appendJSCellOrAuxiliary):

Jan 27, 2018:

6:23 PM Changeset in webkit [227717] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

MarkedBlock should have a footer instead of a header
https://bugs.webkit.org/show_bug.cgi?id=182217

Reviewed by JF Bastien.

This moves the MarkedBlock's meta-data from the header to the footer. This doesn't really
change anything except for some compile-time constants, so it should not affect performance.

This change is to help protect against Spectre attacks on structure checks, which allow for
small-offset out-of-bounds access. By putting the meta-data at the end of the block, small
OOBs will only get to other objects in the same block or the block footer. The block footer
is not super interesting. So, if we combine this with the TLC change (r227617), this means we
can use blocks as the mechanism of achieving distance between objects from different origins.
We just need to avoid ever putting objects from different origins in the same block. That's
what bug 181636 is about.

  • heap/BlockDirectory.cpp:

(JSC::blockHeaderSize): Deleted.
(JSC::BlockDirectory::blockSizeForBytes): Deleted.

  • heap/BlockDirectory.h:
  • heap/HeapUtil.h:

(JSC::HeapUtil::findGCObjectPointersForMarking):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::~MarkedBlock):
(JSC::MarkedBlock::Footer::Footer):
(JSC::MarkedBlock::Footer::~Footer):
(JSC::MarkedBlock::Handle::stopAllocating):
(JSC::MarkedBlock::Handle::lastChanceToFinalize):
(JSC::MarkedBlock::Handle::resumeAllocating):
(JSC::MarkedBlock::aboutToMarkSlow):
(JSC::MarkedBlock::resetMarks):
(JSC::MarkedBlock::assertMarksNotStale):
(JSC::MarkedBlock::Handle::didConsumeFreeList):
(JSC::MarkedBlock::markCount):
(JSC::MarkedBlock::clearHasAnyMarked):
(JSC::MarkedBlock::Handle::didAddToDirectory):
(JSC::MarkedBlock::Handle::didRemoveFromDirectory):
(JSC::MarkedBlock::Handle::sweep):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::markingVersion const):
(JSC::MarkedBlock::lock):
(JSC::MarkedBlock::subspace const):
(JSC::MarkedBlock::footer):
(JSC::MarkedBlock::footer const):
(JSC::MarkedBlock::handle):
(JSC::MarkedBlock::handle const):
(JSC::MarkedBlock::Handle::blockFooter):
(JSC::MarkedBlock::isAtomAligned):
(JSC::MarkedBlock::Handle::cellAlign):
(JSC::MarkedBlock::blockFor):
(JSC::MarkedBlock::vm const):
(JSC::MarkedBlock::weakSet):
(JSC::MarkedBlock::cellSize):
(JSC::MarkedBlock::attributes const):
(JSC::MarkedBlock::atomNumber):
(JSC::MarkedBlock::areMarksStale):
(JSC::MarkedBlock::aboutToMark):
(JSC::MarkedBlock::isMarkedRaw):
(JSC::MarkedBlock::isMarked):
(JSC::MarkedBlock::testAndSetMarked):
(JSC::MarkedBlock::marks const):
(JSC::MarkedBlock::isAtom):
(JSC::MarkedBlock::Handle::forEachCell):
(JSC::MarkedBlock::hasAnyMarked const):
(JSC::MarkedBlock::noteMarked):
(WTF::MarkedBlockHash::hash):
(JSC::MarkedBlock::firstAtom): Deleted.

  • heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::marksConveyLivenessDuringMarking):
(JSC::MarkedBlock::Handle::isLive):
(JSC::MarkedBlock::Handle::specializedSweep):
(JSC::MarkedBlock::Handle::forEachLiveCell):
(JSC::MarkedBlock::Handle::forEachDeadCell):
(JSC::MarkedBlock::Handle::forEachMarkedCell):

  • heap/MarkedSpace.cpp:
  • heap/MarkedSpace.h:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
10:14 AM Changeset in webkit [227716] by Yusuke Suzuki
  • 3 edits
    2 adds in trunk

DFG strength reduction fails to convert NumberToStringWithValidRadixConstant for 0 to constant '0'
https://bugs.webkit.org/show_bug.cgi?id=182213

Reviewed by Mark Lam.

JSTests:

  • stress/int32-min-to-string.js: Added.

(shouldBe):
(test2):
(test4):
(test8):
(test16):
(test32):

  • stress/zero-to-string.js: Added.

(shouldBe):
(test2):
(test4):
(test8):
(test16):
(test32):

Source/JavaScriptCore:

toStringWithRadixInternal is originally used for the slow path if the given value is larger than radix or negative.
As a result, it does not accept 0 correctly, and produces an empty string. Since DFGStrengthReductionPhase uses
this function, it accidentally converts NumberToStringWithValidRadixConstant(0, radix) to an empty string.
This patch fixes toStringWithRadixInternal to accept 0. This change fixes twitch.tv's issue.

We also add a careful cast to avoid -INT32_MIN. It does not produce incorrect value in x86 in practice,
but it is UB, and a compiler may assume that the given value is never INT32_MIN and could do an incorrect optimization.

  • runtime/NumberPrototype.cpp:

(JSC::toStringWithRadixInternal):

9:50 AM Changeset in webkit [227715] by mitz@apple.com
  • 12 edits in trunk

HaveInternalSDK includes should be "#include?"
https://bugs.webkit.org/show_bug.cgi?id=179670

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:

Source/ThirdParty/libwebrtc:

  • Configurations/Base.xcconfig:

Source/WebCore/PAL:

  • Configurations/Base.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/Base.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
1:26 AM Changeset in webkit [227714] by graouts@webkit.org
  • 11 edits
    1 add in trunk

[Web Animations] Distinguish between an omitted and a null timeline argument to the Animation constructor
https://bugs.webkit.org/show_bug.cgi?id=179065
LayoutTests/imported/w3c:

Reviewed by Dean Jackson.

Update WPT test output with progressions.

  • web-platform-tests/web-animations/interfaces/Animation/constructor-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/reversing-an-animation-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/set-the-timeline-of-an-animation-expected.txt:

Source/WebCore:

<rdar://problem/36869046>

Reviewed by Dean Jackson.

The Web Animations specification requires that a missing or undefined "timeline" parameter means that the
document's timeline should be used, but a null value should be supported. To support this, we need to provide
a custom Animation constructor where we can check on the ExecState whether the second argument passed is
undefined, which is true if an explicit "undefined" value is passed or if the argument does not exist.

  • Sources.txt: Add the new JSWebAnimationCustom.cpp file.
  • WebCore.xcodeproj/project.pbxproj: Add the new JSWebAnimationCustom.cpp file.
  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::create): Add a create() variant that doesn't provide an AnimationTimeline parameter
to clearly indicate that the provided Document's timeline should be used.

  • animation/WebAnimation.h:
  • animation/WebAnimation.idl:
  • bindings/js/JSWebAnimationCustom.cpp: Added.

(WebCore::constructJSWebAnimation): Provide a custom Animation constructor where we check whether the second
argument, the timeline, is undefined.

  • dom/Element.cpp:

(WebCore::Element::animate): Use the new create() variant since passing "nullptr" now means a null timeline.

Jan 26, 2018:

10:26 PM Changeset in webkit [227713] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk/LayoutTests

Make accessibility/mac/selection-notification-focus-change.html more reliable and re-enable it
https://bugs.webkit.org/show_bug.cgi?id=182198
<rdar://problem/36930258>

Reviewed by Tim Horton.

Refactored the test by splitting each test case into its own function split by setTimeout by zero seconds
instead of triggering the next test case when receiving a specific notification to make the test more robust.

Also moved functions which trigger the focus move into evalAndLog so that they appear in the expected result,
and added more logging to make the debugging of the test easier.

Finally, added WebKit2 specific expected result because it has one extra test failure compared to WebKit1.

  • accessibility/mac/selection-notification-focus-change-expected.txt:
  • accessibility/mac/selection-notification-focus-change.html:
  • platform/mac-wk2/accessibility/mac: Added.
  • platform/mac-wk2/accessibility/mac/selection-notification-focus-change-expected.txt: Added.
  • platform/mac/TestExpectations: Removed the flaky test failure expectation since this test should now have

the same expected result everywhere on macOS.

8:26 PM Changeset in webkit [227712] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Layout Test http/wpt/beacon/beacon-async-error-logging.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=182184
<rdar://problem/36929478>

Reviewed by Youenn Fablet.

Stop relying on a setTimeout(500) to end the test. Instead rely on the
internals.setConsoleMessageListener() API to wait for the console message
we are expecting.

  • http/wpt/beacon/beacon-async-error-logging.html:
7:32 PM Changeset in webkit [227711] by Ricky Mondello
  • 5 edits in trunk

Use the standard -webkit-autofill color on iOS
https://bugs.webkit.org/show_bug.cgi?id=182182

Reviewed by Tim Horton.

Source/WebCore:

  • css/html.css:

(input:-webkit-autofill, input:-webkit-autofill-strong-password):

LayoutTests:

Update test expectations.

  • platform/ios/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt:
  • platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
6:13 PM Changeset in webkit [227710] by Megan Gardner
  • 5 edits in trunk

Don't retain focus for input peripheral views
https://bugs.webkit.org/show_bug.cgi?id=182204

Reviewed by Tim Horton.

Source/WebKit:

Retaining focus on input peripheral views makes it so they cannot dismiss themselves with
the current architecture. This should probably be fixed in UIKit, as there is no reason for
focus to be retained on these views anyways, as they don't have keyboard input, but this
guards against over-aggressive retain requests.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _restoreFocusWithToken:]):
(-[WKContentView _preserveFocusWithToken:destructively:]):

LayoutTests:

Fixed a spelling error while fixing a bug this test caught.

  • fast/forms/ios/ipad/unfocus-inside-fixed-hittest.html:
  • fast/forms/ios/ipad/unfocus-inside-fixed-hittest-expected.txt:
5:49 PM Changeset in webkit [227709] by Chris Dumez
  • 5 edits in trunk

Make sure service worker code does not launch a StorageProcess unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=182192
<rdar://problem/36927427>

Reviewed by Geoffrey Garen.

Source/WebKit:

When calling WebProcess::existingWebToStorageProcessConnection(), make sure we do not
force the creation of a WebProcess connection to the StorageProcess. If there is
no WebProcess, just return false right away.

  • WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession):

  • WebProcess/WebProcess.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
5:43 PM Changeset in webkit [227708] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/appcache-ordering-main.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=182176
<rdar://problem/36915685>

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-26

5:36 PM Changeset in webkit [227707] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines content browser NavigationBar is squashed at narrow heights
https://bugs.webkit.org/show_bug.cgi?id=182196
<rdar://problem/36929899>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/NavigationBar.css:

(.navigation-bar):

5:35 PM Changeset in webkit [227706] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/blink/fast/text/international-iteration-simple-text.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=179853

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
5:26 PM Changeset in webkit [227705] by jmarcell@apple.com
  • 4 edits in branches/safari-605-branch/Source/WebKit

Cherry-pick r227687. rdar://problem/36873343

5:25 PM Changeset in webkit [227704] by jmarcell@apple.com
  • 2 edits in branches/safari-605-branch/Tools

Apply patch. rdar://problem/36830858

[safari-605-branch] API test CSSPropertyParserTest.GridTrackLimits is failing
<rdar://problem/36830858>

Reviewed by Maciej Stachowiak.

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Make it match the other FeatureDefines.xcconfig files, otherwise it will result in test failures.
4:49 PM Changeset in webkit [227703] by Matt Baker
  • 19 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: TabBar redesign: improvements to tab layout and resize behavior
https://bugs.webkit.org/show_bug.cgi?id=181468
<rdar://problem/36395439>

Reviewed by Devin Rousso.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Images/TabPicker.svg: Added.

New ">>" icon for the tab picker button.

  • UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView):

  • UserInterface/Views/ConsoleTabContentView.js:

(WI.ConsoleTabContentView):

  • UserInterface/Views/DebuggerTabContentView.js:

(WI.DebuggerTabContentView):

  • UserInterface/Views/ElementsTabContentView.js:

(WI.ElementsTabContentView):

  • UserInterface/Views/GeneralTabBarItem.js:

(WI.GeneralTabBarItem):
(WI.GeneralTabBarItem.fromTabContentViewConstructor):
(WI.GeneralTabBarItem.prototype.get title):
Add missing override for getter/setter pair.
(WI.GeneralTabBarItem.prototype.set title):
(WI.GeneralTabBarItem.prototype._handleContextMenuEvent):
Show the close button on ephemeral tabs only (Search, New Tab).
Replace unused representedObject parameter with isEphemeral, which
determines whether to show a close button for the tab.

  • UserInterface/Views/LayersTabContentView.js:

(WI.LayersTabContentView):

  • UserInterface/Views/NavigationBar.js:

Remove unused symbol.

  • UserInterface/Views/NetworkTabContentView.js:

(WI.NetworkTabContentView):

  • UserInterface/Views/NewTabContentView.js:

(WI.NewTabContentView):

  • UserInterface/Views/PinnedTabBarItem.js:

(WI.PinnedTabBarItem):
Remove unused parameter.

  • UserInterface/Views/ResourcesTabContentView.js:

(WI.ResourcesTabContentView):

  • UserInterface/Views/SearchTabContentView.js:

(WI.SearchTabContentView):

  • UserInterface/Views/StorageTabContentView.js:

(WI.StorageTabContentView):

  • UserInterface/Views/TabBar.css:

(.tab-bar > .item):
(.tab-bar.calculate-width > .item):
(.tab-bar > .item.pinned.tab-picker):
(.tab-bar > .item > .close):
(.tab-bar > .item > .title):
(.tab-bar:not(.collapsed) > .item > .title):
(.tab-bar.collapsed > .item:not(.pinned) > .icon):
(.tab-bar > .item:hover > .close):
(.tab-bar.collapsed > .item:hover > .close):
(.tab-bar:not(.collapsed) > .item.ephemeral:hover > .icon):
(.tab-bar.collapsed > .item.ephemeral:hover > .title):
(body[dir=ltr] .tab-bar > .item > .close): Deleted.
(body[dir=rtl] .tab-bar > .item > .close): Deleted.
(.tab-bar > .item > .flex-space): Deleted.
(.tab-bar > .item:not(.pinned) > .flex-space:last-child): Deleted.
(body[dir=ltr] .tab-bar > .item:not(.pinned) > .flex-space:last-child): Deleted.
(body[dir=rtl] .tab-bar > .item:not(.pinned) > .flex-space:last-child): Deleted.
(body[dir=ltr] .tab-bar > .item > .title): Deleted.
(body[dir=rtl] .tab-bar > .item > .title): Deleted.
(.tab-bar.collapsed > .item): Deleted.
(.tab-bar.collapsed > .item > .flex-space): Deleted.
(.tab-bar.collapsed > .item > .close): Deleted.
(body[dir=ltr] .tab-bar.collapsed > .item > .close): Deleted.
(body[dir=rtl] .tab-bar.collapsed > .item > .close): Deleted.
(.tab-bar.hide-titles > .item > .title): Deleted.
(.tab-bar.collapsed:not(.hide-titles) > .item:not(.pinned):hover > .icon,): Deleted.
(.tab-bar.collapsed:not(.hide-titles) > .item:hover > .close,): Deleted.
Clean up tab styles and prevent tabs from shrinking during flex layout.
Added new calculate-width class, to disable flex layout when measuring
the minimum width of the TabBar required to fit all tab items.

  • UserInterface/Views/TabBar.js:

(WI.TabBar):
(WI.TabBar.prototype.set selectedTabBarItem):
(WI.TabBar.prototype.layout.forceItemHidden):
(WI.TabBar.prototype.layout):
Perform two layout passes, similar to NavigationBar. The first pass disables
flex layout and measures tab items at full size. If the bar isn't wide enough
to show all the tabs, hide their icons and measure again. If there still isn't
room, hide tabs starting from the end of the bar and display the tab picker.

(WI.TabBar.prototype._handleMouseDown):
(WI.TabBar.prototype._handleTabPickerTabContextMenu):

  • UserInterface/Views/TabBarItem.js:

(WI.TabBarItem):

  • UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView):

4:45 PM Changeset in webkit [227702] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r222961): Clear function not clearing whole screen when antialias is set to false
https://bugs.webkit.org/show_bug.cgi?id=179368
<rdar://problem/36111549>

Reviewed by Sam Weinig.

When we changed from using a CAOpenGLLayer to a regular CALayer, we should
have also swapped the "opaque" property to "contentsOpaque".

Covered by the existing test: fast/canvas/webgl/context-attributes-alpha.html
(when run on some hardware!)

  • platform/graphics/cocoa/WebGLLayer.mm:

(-[WebGLLayer initWithGraphicsContext3D:]):

4:43 PM Changeset in webkit [227701] by mark.lam@apple.com
  • 68 edits
    1 add in trunk/Source

Add infrastructure for pointer preparation.
https://bugs.webkit.org/show_bug.cgi?id=182191
<rdar://problem/36889194>

Reviewed by JF Bastien.

Source/WebCore:

No new tests because this patch does not introduce any behavior change.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSInterfaceName.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSMapLike.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestCEReactions.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestCallTracer.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestDOMJIT.cpp:
  • bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
  • bindings/scripts/test/JS/JSTestIterable.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestPluginInterface.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestSerialization.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:
  • bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
  • bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestStringifier.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::toJSNewlyCreated):

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/PointerPreparations.h: Added.
4:05 PM Changeset in webkit [227700] by sbarati@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix emitAllocateWithNonNullAllocator to work on arm
https://bugs.webkit.org/show_bug.cgi?id=182187
<rdar://problem/36906550>

Reviewed by Filip Pizlo.

This patch unifies the x86 and ARM paths in emitAllocateWithNonNullAllocator
and makes it so that emitAllocateWithNonNullAllocator uses the macro scratch
register on ARM.

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell):

  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):

3:44 PM Changeset in webkit [227699] by jmarcell@apple.com
  • 2 edits in tags/Safari-605.1.25.1/Source/ThirdParty/libwebrtc

Cherry-pick r227698. rdar://problem/36926420

2:37 PM Changeset in webkit [227698] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

Disable VCP for MacOS
https://bugs.webkit.org/show_bug.cgi?id=182183
<rdar://problem/36919791>

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-26
Reviewed by Eric Carlson.

  • Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/VideoProcessingSoftLink.h:
2:36 PM Changeset in webkit [227697] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

REGRESSiON (r226492): Crash under Element::absoluteEventBounds() on a SVGPathElement which has not been laid out yet
https://bugs.webkit.org/show_bug.cgi?id=182185
rdar://problem/36836262

Reviewed by Zalan Bujtas.

Document::absoluteRegionForEventTargets() can fire when layout is dirty, and SVGPathElement's path() can be null if it
hasn't been laid out yet. So protect against a null path in getBBox().

Not easily testable because internals.nonFastScrollableRects() forces layout, and the crash depends on the timing of
absoluteRegionForEventTargets().

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::getBBox):

2:11 PM Changeset in webkit [227696] by Chris Dumez
  • 6 edits in trunk

Offlined content does not work for apps on home screen
https://bugs.webkit.org/show_bug.cgi?id=182070
<rdar://problem/36843906>

Reviewed by Youenn Fablet.

Source/WebCore:

Already registered service workers were unable to intercept the very first
load because registration matching was happening after the registration
was loaded from disk, but *before* its active worker was populated.

We now initialize the registrations' active worker as soon as we load
them from disk. We do not necessarily have a SW Context process connection
identifier yet at this point so I made it optional on the SWServerWorker.
This identifier gets set on the SWServerWorker when the worker is actually
launched and gets cleared when the SWServerWorker gets terminated.

Covered by new API test.

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::addRegistrationFromStore):
(WebCore::SWServer::installContextData):
(WebCore::SWServer::terminateWorkerInternal):
(WebCore::SWServer::workerContextTerminated):
(WebCore::SWServer::fireInstallEvent):
(WebCore::SWServer::fireActivateEvent):

  • workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::SWServerWorker):

  • workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::contextConnectionIdentifier const):
(WebCore::SWServerWorker::setContextConnectionIdentifier):

Tools:

Add API test coverage to make sure an already registered service worker is able to intercept
the very first load.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

(-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):

1:41 PM Changeset in webkit [227695] by jmarcell@apple.com
  • 18 edits
    4 deletes in tags/Safari-605.1.25.1/Source

Revert r227340. rdar://problem/36746140

1:41 PM Changeset in webkit [227694] by jmarcell@apple.com
  • 57 edits
    4 deletes in tags/Safari-605.1.25.1

Revert r227425. rdar://problem/36791667

1:23 PM Changeset in webkit [227693] by Joseph Pecoraro
  • 14 edits in trunk/Source/JavaScriptCore

Rebaselining builtin generator tests after r227685.

Unreviewed.

  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
  • Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:

It used to be that the builtins generator was minifying by default. That was an accident
and we now only minify on Release builds. The generator tests are now getting the
default unminified output behavior so they need to update their expectations
for some extra whitespace.

1:14 PM Changeset in webkit [227692] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

We should only append ParserArenaDeletable pointers to ParserArena::m_deletableObjects.
https://bugs.webkit.org/show_bug.cgi?id=182180
<rdar://problem/36460697>

Reviewed by Michael Saboff.

Some parser Node subclasses extend ParserArenaDeletable via multiple inheritance,
but not as the Node's first base class. ParserArena::m_deletableObjects is
expecting pointers to objects of the shape of ParserArenaDeletable. We ensure
this by allocating the Node subclass, and casting it to ParserArenaDeletable to
get the correct pointer to append to ParserArena::m_deletableObjects.

To simplify things, we introduce a JSC_MAKE_PARSER_ARENA_DELETABLE_ALLOCATED
(analogous to WTF_MAKE_FAST_ALLOCATED) for use in Node subclasses that extends
ParserArenaDeletable.

  • parser/NodeConstructors.h:

(JSC::ParserArenaDeletable::operator new):

  • parser/Nodes.h:
  • parser/ParserArena.h:

(JSC::ParserArena::allocateDeletable):

12:55 PM Changeset in webkit [227691] by commit-queue@webkit.org
  • 15 edits in trunk

Addressing post-review comments after r226614
https://bugs.webkit.org/show_bug.cgi?id=182151

Patch by Chris Nardi <cnardi@chromium.org> on 2018-01-26
Reviewed by Myles C. Maxfield.

PerformanceTests:

  • StitchMarker/wtf/text/StringImpl.h:

(WTF::isSpaceOrNewline):

  • StitchMarker/wtf/text/TextBreakIterator.cpp:

(WTF::numCodeUnitsInGraphemeClusters):

  • StitchMarker/wtf/text/TextBreakIterator.h:

Source/WebCore:

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::sanitizeUserInputValue):

  • html/TextFieldInputType.cpp:

(WebCore::limitLength):

  • platform/LocalizedStrings.cpp:

(WebCore::truncatedStringForLookupMenuItem):

  • rendering/updating/RenderTreeBuilderFirstLetter.cpp:

(WebCore::RenderTreeBuilder::FirstLetter::createRenderers):

Source/WTF:

  • wtf/text/StringImpl.h:

(WTF::isSpaceOrNewline):

  • wtf/text/TextBreakIterator.cpp:

(WTF::numCodeUnitsInGraphemeClusters):

  • wtf/text/TextBreakIterator.h:

Tools:

  • TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:

(TestWebKitAPI::TEST):

12:51 PM Changeset in webkit [227690] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.1.25.1/Source

Versioning.

12:17 PM Changeset in webkit [227689] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.25.1

New tag.

12:16 PM Changeset in webkit [227688] by jmarcell@apple.com
  • 6 edits in branches/safari-605-branch

Cherry-pick r227570. rdar://problem/36873398

12:15 PM Changeset in webkit [227687] by achristensen@apple.com
  • 4 edits in trunk/Source/WebKit

Allow cellular access for default-created ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=182179
<rdar://problem/36572023>

Reviewed by Andy Estes.

This makes it so when we recover from a NetworkProcess crash (see r227590) on iOS, we will
be able to continue browsing using cell data.

  • Shared/WebsiteDataStoreParameters.cpp:

(WebKit::WebsiteDataStoreParameters::privateSessionParameters):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::pageBeginUsingWebsiteDataStore):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

11:39 AM Changeset in webkit [227686] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[iOS] prefers-reduced-motion media query is not working
https://bugs.webkit.org/show_bug.cgi?id=182169
<rdar://problem/36801631>

Patch by Antoine Quint <Antoine Quint> on 2018-01-26
Reviewed by Dean Jackson.

The code that would eventually query UIKit for the system setting was not run since USE(NEW_THEME) is off on iOS.
Adding a PLATFORM(IOS) flag here allows the code to run.

  • css/MediaQueryEvaluator.cpp:

(WebCore::prefersReducedMotionEvaluate):

11:32 AM Changeset in webkit [227685] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JavaScriptCore builtins should be partially minified in Release builds not Debug builds
https://bugs.webkit.org/show_bug.cgi?id=182165

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-26
Reviewed by Keith Miller.

  • Scripts/builtins/builtins_model.py:

(BuiltinFunction.fromString):
Apply minifications on Release builds instead of Debug builds.
Also eliminate leading whitespace.

10:52 AM Changeset in webkit [227684] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Fix style - need to use C comments.

  • wtf/Platform.h:
10:42 AM Changeset in webkit [227683] by fpizlo@apple.com
  • 11 edits in trunk/Source

Disable TLS-based TLCs
https://bugs.webkit.org/show_bug.cgi?id=182175

Reviewed by Saam Barati.

Source/JavaScriptCore:

Check for the new USE(FAST_TLS_FOR_TLC) flag instead of just ENABLE(FAST_TLS_JIT).

  • heap/BlockDirectory.cpp:

(JSC::BlockDirectory::~BlockDirectory):

  • heap/BlockDirectory.h:
  • heap/ThreadLocalCache.cpp:

(JSC::ThreadLocalCache::installSlow):
(JSC::ThreadLocalCache::installData):

  • heap/ThreadLocalCache.h:
  • heap/ThreadLocalCacheInlines.h:

(JSC::ThreadLocalCache::getImpl):

  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):

  • runtime/VM.cpp:

(JSC::VM::~VM):

  • runtime/VM.h:

Source/WTF:

Add a flag for TLS-based TLCs and set it to 0. We can re-enable this feature when we need to use TLCs for
actual thread-local allocation and when we fix the fact that WebCore context switches JSC VMs without telling
us.

  • wtf/Platform.h:
10:36 AM Changeset in webkit [227682] by achristensen@apple.com
  • 10 edits in trunk/Source/WebKit

Clean up more networking code
https://bugs.webkit.org/show_bug.cgi?id=182161

Reviewed by Anders Carlsson.

Two cleanups:

  1. The WebProcess doesn't need to initialize NetworkSessions.
  2. WebFrameNetworkingContext doesn't need to have the NetworkingContext functions to support ResourceHandles in WebKit any more.
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:
  • NetworkProcess/NetworkLoad.h:
  • NetworkProcess/RemoteNetworkingContext.h:

(): Deleted.

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:
  • NetworkProcess/curl/RemoteNetworkingContextCurl.cpp:

(WebKit::RemoteNetworkingContext::~RemoteNetworkingContext): Deleted.
(WebKit::RemoteNetworkingContext::isValid const): Deleted.
(WebKit::RemoteNetworkingContext::storageSession const): Deleted.

  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::~RemoteNetworkingContext): Deleted.
(WebKit::RemoteNetworkingContext::isValid const): Deleted.
(WebKit::RemoteNetworkingContext::localFileContentSniffingEnabled const): Deleted.
(WebKit::RemoteNetworkingContext::storageSession const): Deleted.
(WebKit::RemoteNetworkingContext::sourceApplicationAuditData const): Deleted.
(WebKit::RemoteNetworkingContext::sourceApplicationIdentifier const): Deleted.
(WebKit::RemoteNetworkingContext::blockedError const): Deleted.

  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:

(WebKit::RemoteNetworkingContext::~RemoteNetworkingContext): Deleted.
(WebKit::RemoteNetworkingContext::isValid const): Deleted.
(WebKit::RemoteNetworkingContext::storageSession const): Deleted.

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::clearCachedCredentials):

9:50 AM Changeset in webkit [227681] by Ryan Haddad
  • 2 edits in branches/safari-605-branch/LayoutTests

Cherry-pick r227426. rdar://problem/36837397

9:36 AM Changeset in webkit [227680] by commit-queue@webkit.org
  • 5 edits in trunk

CSP post checks should be done for service worker responses
https://bugs.webkit.org/show_bug.cgi?id=182160

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-26
Reviewed by Daniel Bates.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/fetch-csp.https-expected.txt:

Source/WebCore:

Covered by updated test.

Add security checks when receiving a service worker response.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):

  • loader/cache/CachedResourceLoader.h:
8:53 AM Changeset in webkit [227679] by pvollan@apple.com
  • 2 edits in trunk/Tools

Unreviewed, rolling out r224920.

Some Win EWS bots are not coming back up after starting reboot.

  • EWSTools/start-queue-win.sh:
8:49 AM Changeset in webkit [227678] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Update test expectations.

Unreviewed test gardening.

  • platform/win/TestExpectations:
8:48 AM Changeset in webkit [227677] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

WebDriver: simplify the tests json report
https://bugs.webkit.org/show_bug.cgi?id=182171

Reviewed by Carlos Alberto Lopez Perez.

We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
form the subtest name. We should do the same for simplicity and compatibility with WPT.

  • Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:

(WebDriverTestRunner.dump_results_to_json_file):

8:36 AM WPE edited by cturner@igalia.com
fix typo (diff)
6:57 AM Changeset in webkit [227676] by Manuel Rego Casasnovas
  • 20 edits
    2 adds in trunk

[css-multicol] Support percentages in column-gap
https://bugs.webkit.org/show_bug.cgi?id=182004

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

New expected results for a few tests that are passing now.
One is the test for this specific patch, the other are tests related to animations
of "normal" and initial value, that were fixed with the introduction of GapLength.

  • web-platform-tests/css/css-multicol/multicol-gap-animation-002-expected.txt:
  • web-platform-tests/css/css-multicol/multicol-gap-animation-003-expected.txt:
  • web-platform-tests/css/css-multicol/multicol-gap-percentage-001-expected.txt:

Source/WebCore:

This patch adds percentage support to column-gap property.

Most of the changes are related to the parsing logic,
the column-gap property now accepts both length and percentages,
on top of the "normal" initial value.
A new utility class GapLength has been added, as it'll be useful
to implement row-gap in the future.

Apart from that the muticolumn layout code has been modified
to resolve the percentage gaps (treating them as zero while computing
preferred widths) and resolving them during layout.
This doesn't follow the current text on the spec, but there is an
ongoing discussion that might cause the text is changed:
https://github.com/w3c/csswg-drafts/issues/509#issuecomment-355242101
We could update the implementation once we have a definitive answer
from the CSS WG.

Test: web-platform-tests/css/css-multicol/multicol-gap-percentage-001.html

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

  • css/CSSProperties.json:
  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertGapLength):

  • css/StyleBuilderCustom.h:

(WebCore::forwardInheritedValue):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeGapLength):
(WebCore::CSSPropertyParser::parseSingleValue):

  • page/FrameView.cpp:

(WebCore::FrameView::applyPaginationToViewport):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::columnGap const):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::columnGap const):

  • rendering/style/GapLength.cpp: Added.

(WebCore::operator<<):

  • rendering/style/GapLength.h: Added.

(WebCore::GapLength::GapLength):
(WebCore::GapLength::isNormal const):
(WebCore::GapLength::length const):
(WebCore::GapLength::operator== const):

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::columnGap const):
(WebCore::RenderStyle::setColumnGap):
(WebCore::RenderStyle::initialColumnGap):

  • rendering/style/StyleMultiColData.cpp:

(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator== const):

  • rendering/style/StyleMultiColData.h:
  • style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

6:52 AM Changeset in webkit [227675] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

[GTK] Support using long-tap gesture to open context menu
https://bugs.webkit.org/show_bug.cgi?id=140747

Patch by Jan-Michael Brummer <jan.brummer@tabos.org> on 2018-01-26
Reviewed by Carlos Garcia Campos.

Add long press gesture which simulates a secondary mouse press to open context menu.

  • UIProcess/gtk/GestureController.cpp:

(WebKit::GestureController::GestureController):
(WebKit::GestureController::handleEvent):
(WebKit::GestureController::isProcessingGestures const):
(WebKit::GestureController::Gesture::simulateMousePress):
(WebKit::GestureController::DragGesture::handleTap):
(WebKit::GestureController::LongPressGesture::longPressed):
(WebKit::GestureController::LongPressGesture::pressed):
(WebKit::GestureController::LongPressGesture::LongPressGesture):

  • UIProcess/gtk/GestureController.h:

(WebKit::GestureController::reset):

5:20 AM Changeset in webkit [227674] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebDriver

WebDriver: service hangs after a browser crash
https://bugs.webkit.org/show_bug.cgi?id=182170

Reviewed by Carlos Alberto Lopez Perez.

This is currently happening in the GTK+ debug bot. There's a test that makes the browser crash due to an assert,
hanging the whole process and preventing the rest of the tests from running. When the browser crashes, we
correctly handle the pending requests, by completing them with an error. However, if the client tries to send
another command we fail to send the message to the browser and the reply is never sent to the client. In the
case of the tests, delete session command is sent, but never gets a reply.

  • Session.cpp:

(WebDriver::Session::isConnected const): Return whether the session is connected to the browser.

  • Session.h:
  • SessionHost.cpp:

(WebDriver::SessionHost::sendCommandToBackend): Pass the message ID to SessionHost::sendMessageToBackend().

  • SessionHost.h:
  • WebDriverService.cpp:

(WebDriver::WebDriverService::deleteSession): Ignore unknown errors if the session is no longer connected.

  • glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::sendMessageToBackend): Handle errors when sending the command by completing the request
with an error.

2:46 AM Changeset in webkit [227673] by emilio
  • 3 edits in trunk/Source/WebCore

Remove unused RenderFragmentedFlow::createFragmentedFlowStyle.
https://bugs.webkit.org/show_bug.cgi?id=182138

Reviewed by Manuel Rego Casasnovas.

Has no callers.

No new tests, just removes unused code so no behavior change.

  • rendering/RenderFragmentedFlow.cpp:
  • rendering/RenderFragmentedFlow.h:
2:45 AM Changeset in webkit [227672] by emilio
  • 3 edits in trunk/Source/WebCore

Remove useless RenderBlockFlow overrides.
https://bugs.webkit.org/show_bug.cgi?id=182139

Reviewed by Manuel Rego Casasnovas.

I think these are leftovers from the CSS regions removal, looking at
blame.

No new tests, no behavior change.

  • rendering/RenderBlockFlow.cpp:
  • rendering/RenderBlockFlow.h:
1:50 AM Changeset in webkit [227671] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebDriver

WebDriver: timeouts value and cookie expiry should be limited to max safe integer
https://bugs.webkit.org/show_bug.cgi?id=182167

Reviewed by Žan Doberšek.

This changed recently in the spec, but our implementation was wrong in any case since we were limiting to
INT_MAX. Use valueAsNumberInRange() to ensure we get a valid double value in the given range, and then convert
to unsigned if it's a valid integer.

Fixes: imported/w3c/webdriver/tests/sessions/new_session/create_firstMatch.py::test_valid[timeouts-value10]

imported/w3c/webdriver/tests/sessions/new_session/create_alwaysMatch.py::test_valid[timeouts-value10]

  • Session.h:
  • WebDriverService.cpp:

(WebDriver::valueAsNumberInRange):
(WebDriver::unsignedValue):
(WebDriver::deserializeTimeouts):
(WebDriver::deserializeCookie):

1:18 AM Changeset in webkit [227670] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

Unreviewed. REGRESSION(r227647): window.open() is broken in GTK and WPE after r227647.

In r227647, API::UIClient::createNewPage() was changed to use CompletionHandler instead of Function. All
implementations were updated expect the GLib one, and we didn't notice it because the method doesn't have the
final/override mark.

  • UIProcess/API/glib/WebKitUIClient.cpp:

(UIClient::createNewPage):

12:54 AM Changeset in webkit [227669] by svillar@igalia.com
  • 2 edits in trunk/Source/WebKit

[WebVR] Make WebVR available by default for developer builds
https://bugs.webkit.org/show_bug.cgi?id=182101

Reviewed by Michael Catanzaro.

Moved WebVR setting to the experimental features section and make it
available by default for developer builds for GTK and WPE.

  • Shared/WebPreferences.yaml:
12:51 AM Changeset in webkit [227668] by Carlos Garcia Campos
  • 11 edits in trunk/WebDriverTests

Unreviewed. Update W3C WebDriver imported tests.

  • imported/w3c/importer.json:
  • imported/w3c/tools/wptrunner/wptrunner/executors/executormarionette.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/pytestrunner/runner.py:
  • imported/w3c/webdriver/tests/element_click/select.py:
  • imported/w3c/webdriver/tests/interaction/element_clear.py:
  • imported/w3c/webdriver/tests/sessions/new_session/support/create.py:
  • imported/w3c/webdriver/tests/state/get_element_attribute.py:
  • imported/w3c/webdriver/tests/state/get_element_property.py:
  • imported/w3c/webdriver/tests/state/get_element_tag_name.py:
  • imported/w3c/webdriver/tests/state/is_element_selected.py:

Jan 25, 2018:

9:30 PM Changeset in webkit [227667] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Table: Sort indicator is not displayed when sorted column is hidden and re-shown
https://bugs.webkit.org/show_bug.cgi?id=182164
<rdar://problem/36892619>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-25
Reviewed by Brian Burg.

  • UserInterface/Views/Table.js:

(WI.Table.prototype.showColumn):
Re-add the sort classes if the column being shown is the active sort column.

9:22 PM Changeset in webkit [227666] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Network - Cookies view should behave better at narrow widths, all data is hidden
https://bugs.webkit.org/show_bug.cgi?id=182163
<rdar://problem/36893241>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-25
Reviewed by Brian Burg.

  • UserInterface/Views/ResourceCookiesContentView.css:

(.resource-cookies .table):
Give these tables a reasonable minimum size so that if the inspector
is narrow, the content view can still be scrolled to see all of
the table data.

  • UserInterface/Views/Table.css:

(.table > .header):
Match the data-container and mark overflow as hidden, otherwise
super narrow widths show header content beyond the edge.

9:08 PM Changeset in webkit [227665] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Add InspectorShaderProgram to Unified Sources build
https://bugs.webkit.org/show_bug.cgi?id=182084

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-25
Reviewed by Dan Bernstein.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • Sources.txt:

Move to Sources.txt always.

  • inspector/InspectorShaderProgram.cpp:

Add ENABLE(WEBGL) guard to contents.

9:03 PM Changeset in webkit [227664] by rniwa@webkit.org
  • 15 edits
    4 adds in trunk

Make scrolling to the focused element async
https://bugs.webkit.org/show_bug.cgi?id=181575
<rdar://problem/36459767>

Reviewed by Simon Fraser.

Source/WebCore:

Made the revealing of the focused element asynchronous in Element::focus. Like selection, schedule a timer when
a new element is focused, and only scroll to the focused element when the timer fires. If any other scrolling
happens meanwhile, we cancel this timer.

There are two Web exposed behavioral changes:

  1. The scrolling position doesn't change immediately when calling Element::focus.
  2. Only the last focused element will be revealed.

Both behavioral changes pose its own compatibility risks but we're making a conscious decision here since
the scrolling asynchronous has a clear performance benefit.

There is one edge case to cosnider: when the history controller restores the scrolling position, canceling the
timer results in a focused element in an overflow: hidden element to be never revealed. Expediate revealing of
the focused element in this one case instead of canceling.

Tests: fast/scrolling/scroll-to-focused-element-asynchronously.html

fast/scrolling/scroll-to-focused-element-canceled-by-fragment-navigation.html

  • dom/Element.cpp:

(WebCore::Element::focus): Call updateFocusAppearance on focusAppearanceUpdateTarget to handle HTMLAreaElement
which delegates the focus appearance update to its image element.
(WebCore::Element::focusAppearanceUpdateTarget): Extracted. Returns "this" element for all but HTMLAreaElement.
(WebCore::Element::updateFocusAppearance): Schedule the revealing of the focused element in FrameView instead of
synchronously scrolling to the focused element.

  • dom/Element.h:

(WebCore::Element::defaultFocusTextStateChangeIntent):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::focusAppearanceUpdateTarget): Extracted from updateFocusAppearance.
(WebCore::HTMLAreaElement::updateFocusAppearance): Deleted.

  • html/HTMLAreaElement.h:
  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState): Reveal the focused element
prior to restoring the scrolling location of the fragment navigation. This is needed to reveal a focused element
inside overflow: hidden element which got focused.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView): Added a boolean flag and a timer for scrolling to the focused element.
(WebCore::FrameView::reset): Stop the timer and clear the flag.
(WebCore::FrameView::maintainScrollPositionAtAnchor): Ditto when scrolling to an anchor.
(WebCore::FrameView::setScrollPosition): Ditto when some other programatic scroll or the user scrolls the view.
(WebCore::FrameView::scheduleScrollToFocusedElement): Added.
(WebCore::FrameView::scrollToFocusedElementImmediatelyIfNeeded): Added.
(WebCore::FrameView::scrollToFocusedElementTimerFired): Added.
(WebCore::FrameView::scrollToAnchor): Stop the timer and clear the flag when scrolling to an achor.
(WebCore::FrameView::setWasScrolledByUser): Ditto when the user scrolls.

  • page/FrameView.h:

LayoutTests:

Updated the tests per the behavioral change and added two more tests for scrolling to the focused element.

  • accessibility/mac/webkit-scrollarea-position.html: Wait for the focus scrolling to take effect.
  • fast/events/reveal-link-when-focused.html: Ditto.
  • fast/images/imagemap-scroll.html: Ditto.
  • fast/overflow/scroll-nested-positioned-layer-in-overflow.html: Ditto.
  • fast/overflow/scrollRevealButton.html: Ditto.
  • fast/transforms/scrollIntoView-transformed.html: Ditto. We need to focus each element in a seperate task

since only the last focused element will be revealed otherwise.

  • fast/scrolling/scroll-to-focused-element-asynchronously-expected.txt: Added.
  • fast/scrolling/scroll-to-focused-element-asynchronously.html: Added.
  • fast/scrolling/scroll-to-focused-element-canceled-by-fragment-navigation-expected.txt: Added.
  • fast/scrolling/scroll-to-focused-element-canceled-by-fragment-navigation.html: Added.
9:03 PM Changeset in webkit [227663] by jmarcell@apple.com
  • 11 edits in branches/safari-605-branch

Cherry-pick r227612. rdar://problem/36873390

9:03 PM Changeset in webkit [227662] by jmarcell@apple.com
  • 7 edits
    1 add in branches/safari-605-branch

Cherry-pick r227590. rdar://problem/36873343

9:03 PM Changeset in webkit [227661] by jmarcell@apple.com
  • 4 edits in branches/safari-605-branch/Source/WebInspectorUI

Cherry-pick r227585. rdar://problem/36873363

9:03 PM Changeset in webkit [227660] by jmarcell@apple.com
  • 8 edits in branches/safari-605-branch

Cherry-pick r227578. rdar://problem/36873356

9:03 PM Changeset in webkit [227659] by jmarcell@apple.com
  • 2 edits in branches/safari-605-branch/Source/WebInspectorUI

Cherry-pick r227572. rdar://problem/36873386

9:03 PM Changeset in webkit [227658] by jmarcell@apple.com
  • 3 edits
    4 adds in branches/safari-605-branch

Cherry-pick r227567. rdar://problem/36873353

9:03 PM Changeset in webkit [227657] by jmarcell@apple.com
  • 19 edits
    2 adds in branches/safari-605-branch

Cherry-pick r227566. rdar://problem/36722508

9:03 PM Changeset in webkit [227656] by jmarcell@apple.com
  • 10 edits
    3 adds in branches/safari-605-branch

Cherry-pick r227533. rdar://problem/36873383

9:02 PM Changeset in webkit [227655] by jmarcell@apple.com
  • 5 edits in branches/safari-605-branch/Source/JavaScriptCore

Cherry-pick r227435. rdar://problem/36873349

9:02 PM Changeset in webkit [227654] by jmarcell@apple.com
  • 5 edits
    2 adds in branches/safari-605-branch

Cherry-pick r227430. rdar://problem/36873610

9:02 PM Changeset in webkit [227653] by jmarcell@apple.com
  • 20 edits
    1 add in branches/safari-605-branch

Cherry-pick r227410. rdar://problem/36873404

8:58 PM Changeset in webkit [227652] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: "Displayed Columns" should not be displayed in context menu if all columns are required columns
https://bugs.webkit.org/show_bug.cgi?id=182162
<rdar://problem/36893758>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-25
Reviewed by Matt Baker.

  • UserInterface/Views/Table.js:

(WI.Table.prototype._handleHeaderContextMenu):
Only add the header column when we know there are hideable columns.

7:42 PM Changeset in webkit [227651] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

REGRESSION(r217236): [iOS] PDFDocumentImage does not update its cached ImageBuffer if it has a sub-rectangle of the image
https://bugs.webkit.org/show_bug.cgi?id=182083

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-01-25
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/images/pdf-as-image-dest-rect-change.html

Revert the change r217236 back. Fix the issue of throwing out the cached
ImageBuffer of the PDF document image when moving its rectangle.

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::cacheParametersMatch): Return the if-statement
which was deleted in r217236 back but intersect it with dstRect. The context
clipping rectangle can be more than the dstRect.
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):
-- Remove a wrong optimization which used to work for Mac only if the context

interpolation quality is not set to low or none quality. This optimization
does not consider the case when srcRect or destRect change after caching
the ImageBuffer. Or even if m_cachedImageRect does not include the
whole clipping rectangle.

-- Move back the call to cacheParametersMatch() before changing the

m_cachedImageRect.

-- Always intersect the clipping rectangle with the dstRect to ensure we

only look at the dirty rectangle inside the image boundary.

-- If cacheParametersMatch() returns true, set m_cachedDestinationRect to

dstRect and move m_cachedImageRect by the difference between the new
and the old dstRects since no re-caching will happen.

  • platform/graphics/cg/PDFDocumentImage.h:
  • testing/Internals.cpp:

(WebCore::pdfDocumentImageFromImageElement):
(WebCore::Internals::pdfDocumentCachingCount):

  • testing/Internals.h:
  • testing/Internals.idl:

Add an internal API which returns the number of drawing the PDF into an
ImageBuffer.

LayoutTests:

PDFDocumentImage renders only on CG platforms. Enable the new test for
iOS only.

  • TestExpectations:
  • fast/images/pdf-as-image-dest-rect-change-expected.txt: Added.
  • fast/images/pdf-as-image-dest-rect-change.html: Added.
  • platform/ios/TestExpectations:
7:31 PM Changeset in webkit [227650] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove unnecessary developerExtrasEnabled checks
https://bugs.webkit.org/show_bug.cgi?id=182156

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-25
Reviewed by Matt Baker.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
(WebCore::InspectorInstrumentation::frameDocumentUpdatedImpl):
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
These checks should not be needed. The step above bails if there is
no inspector frontend, and there can be no inspector frontend unless
developer extras enabled are enabled.

6:42 PM Changeset in webkit [227649] by Yusuke Suzuki
  • 6 edits
    1 add in trunk

imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/errorhandling.html crashes
https://bugs.webkit.org/show_bug.cgi?id=181980

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/scripting-1/the-script-element/module/dynamic-import/dynamic-imports-script-error-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/module/errorhandling-expected.txt: Added.

Source/JavaScriptCore:

We accidentally failed to propagate errored promise in instantiate and satify phase if entry.{instantiate,satisfy}
promises are set. Since we just returned entry, it becomes succeeded promise even if the dependent fetch, instantiate,
and satisfy promises are failed. This patch fixes error propagation by returning entry.instantiate and entry.satisfy
correctly.

  • builtins/ModuleLoaderPrototype.js:

(requestInstantiate):
(requestSatisfy):

LayoutTests:

5:35 PM Changeset in webkit [227648] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed, fix windows build.

  • wtf/MathExtras.h:

(WTF::opaque):

5:31 PM Changeset in webkit [227647] by achristensen@apple.com
  • 7 edits in trunk

REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
https://bugs.webkit.org/show_bug.cgi?id=182152

Reviewed by Joseph Pecoraro.

Source/WebKit:

Call the completion handler of the default API::UIClient::createNewPage.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::createNewPage):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::createNewPage):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(TEST):

5:18 PM Changeset in webkit [227646] by wenson_hsieh@apple.com
  • 4 edits in trunk/Source/WebCore

Add localizable strings for extra-zoomed form controls
https://bugs.webkit.org/show_bug.cgi?id=182080

Reviewed by Tim Horton.

Add new localizable strings. Additionally, run update-webkit-localizable-strings to re-sort
Localizable.strings.

  • English.lproj/Localizable.strings:
  • platform/LocalizedStrings.cpp:

(WebCore::formControlCancelButtonTitle):
(WebCore::formControlHideButtonTitle):
(WebCore::formControlGoButtonTitle):
(WebCore::formControlSearchButtonTitle):
(WebCore::textInputModeWriteButton):
(WebCore::textInputModeSpeechButton):

  • platform/LocalizedStrings.h:
5:12 PM Changeset in webkit [227645] by wenson_hsieh@apple.com
  • 2 edits
    10 adds in trunk/Source/WebKit

[iOS] [WK2] Introduce new views and view controllers to support extra-zoomed text form controls
https://bugs.webkit.org/show_bug.cgi?id=182000
<rdar://problem/35143035>

Reviewed by Tim Horton.

Add new files to support text form control editing while extra-zoomed.

  • UIProcess/ios/forms/WKFocusedFormControlView.h: Added.
  • UIProcess/ios/forms/WKFocusedFormControlView.mm: Added.
  • UIProcess/ios/forms/WKFocusedFormControlViewController.h: Added.
  • UIProcess/ios/forms/WKFocusedFormControlViewController.mm: Added.
  • UIProcess/ios/forms/WKTextFormControlViewController.h: Added.
  • UIProcess/ios/forms/WKTextFormControlViewController.mm: Added.
  • UIProcess/ios/forms/WKTextInputViewController.h: Added.
  • UIProcess/ios/forms/WKTextInputViewController.mm: Added.
  • UIProcess/ios/forms/WKTextSuggestionButton.h: Added.
  • UIProcess/ios/forms/WKTextSuggestionButton.mm: Added.
  • WebKit.xcodeproj/project.pbxproj:
4:41 PM Changeset in webkit [227644] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: fix 32-bit build after r227643.
https://bugs.webkit.org/show_bug.cgi?id=182086

Not reviewed.

  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitDynamicPoisonOnLoadedType):

4:05 PM Changeset in webkit [227643] by fpizlo@apple.com
  • 10 edits in trunk/Source

DirectArguments should protect itself using dynamic poisoning and precise index masking
https://bugs.webkit.org/show_bug.cgi?id=182086

Reviewed by Saam Barati.

Source/JavaScriptCore:

This implements dynamic poisoning and precise index masking in DirectArguments, using the
helpers from <wtf/MathExtras.h> and helpers in AssemblyHelpers and FTL::LowerDFGToB3.

We use dynamic poisoning for DirectArguments since this object did not have any additional
indirection inside it that could have been poisoned. So, we use the xor of the expected type
and the actual type as an additional input into the pointer.

We use precise index masking for bounds checks, because it's not worth doing index masking
unless we know that precise index masking is too slow.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::lshiftPtr):
(JSC::MacroAssembler::rshiftPtr):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnDirectArguments):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMyArgumentByVal):
(JSC::FTL::DFG::LowerDFGToB3::preciseIndexMask64):
(JSC::FTL::DFG::LowerDFGToB3::preciseIndexMask32):
(JSC::FTL::DFG::LowerDFGToB3::dynamicPoison):
(JSC::FTL::DFG::LowerDFGToB3::dynamicPoisonOnLoadedType):
(JSC::FTL::DFG::LowerDFGToB3::dynamicPoisonOnType):

  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitPreciseIndexMask32):
(JSC::AssemblyHelpers::emitDynamicPoison):
(JSC::AssemblyHelpers::emitDynamicPoisonOnLoadedType):
(JSC::AssemblyHelpers::emitDynamicPoisonOnType):

  • jit/AssemblyHelpers.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDirectArgumentsGetByVal):

  • runtime/DirectArguments.h:

(JSC::DirectArguments::getIndexQuickly const):
(JSC::DirectArguments::setIndexQuickly):
(JSC::DirectArguments::argument):

  • runtime/GenericArgumentsInlines.h:

Source/WTF:

Add helpers for:

Dynamic poisoning: this means arranging to have the pointer you will dereference become an
invalid pointer if the type check you were relying on would have failed.

Precise index masking: a variant of index masking that does not depend on distancing. I figured
I'd just try this first for DirectArguments, since I didn't think that arguments[i] was ever
hot enough to warrant anything better. Turns out that in all of the benchmarks that care about
arguments performance, we optimize things to the point that the index masking isn't on a hot
path anymore. Turns out, it's neutral!

  • wtf/MathExtras.h:

(WTF::preciseIndexMask):
(WTF::dynamicPoison):

3:45 PM Changeset in webkit [227642] by jmarcell@apple.com
  • 7 edits in branches/safari-605-branch/Source

Versioning.

3:43 PM Changeset in webkit [227641] by jer.noble@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed build fix after r227631; make USE_VIDEOTOOLBOX universally enabled on iOS.

  • wtf/Platform.h:
3:42 PM Changeset in webkit [227640] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.25

Tag Safari-605.1.25.

3:09 PM Changeset in webkit [227639] by Chris Dumez
  • 10 edits in trunk

Access to service workers / Cache API should be disabled in sandboxed frames without allow-same-origin flag
https://bugs.webkit.org/show_bug.cgi?id=182140
<rdar://problem/36879952>

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline several WPT test that either pass or fail differently.

  • web-platform-tests/service-workers/cache-storage/window/sandboxed-iframes.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/sandboxed-iframe-navigator-serviceworker.https-expected.txt:

Source/WebCore:

Throw a SecurityError when accessing navigator.serviceWorker or window.caches inside a sandboxed iframe
without the allow-same-origin flag. This behavior is consistent with Chrome. Firefox, however, seems
to return these objects but have their API reject promises with a SecurityError instead.

No new tests, rebaselined existing tests.

  • Modules/cache/DOMWindowCaches.cpp:

(WebCore::DOMWindowCaches::caches): Deleted.

  • Modules/cache/DOMWindowCaches.h:
  • Modules/cache/DOMWindowCaches.idl:
  • page/NavigatorBase.cpp:
  • page/NavigatorBase.h:
  • page/NavigatorServiceWorker.idl:
3:08 PM Changeset in webkit [227638] by Chris Dumez
  • 9 edits in trunk

Clients.get(id) should only returns clients in the service worker's origin
https://bugs.webkit.org/show_bug.cgi?id=182149
<rdar://problem/36882310>

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebase WPT test that is now passing.

  • web-platform-tests/service-workers/service-worker/clients-get-cross-origin.https-expected.txt:

Source/WebCore:

When looking for SW clients with a given identifier, only look in the list of
clients that have the same origin as the service worker.

No new tests, rebaselined existing test.

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::serviceWorkerClientWithOriginByID const):
(WebCore::SWServer::serviceWorkerClientByID const): Deleted.

  • workers/service/server/SWServer.h:
  • workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::findClientByIdentifier const):

  • workers/service/server/SWServerWorker.h:

Source/WebKit:

  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::postMessageToServiceWorker):

3:06 PM Changeset in webkit [227637] by commit-queue@webkit.org
  • 6 edits in trunk

WebPluginInfoProvider should handle null host queries
https://bugs.webkit.org/show_bug.cgi?id=182112

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-25
Reviewed by Chris Dumez.

Source/WebCore:

No change of behavior.

Removed assertion that is not always true, as shown by API tests.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

Source/WebKit:

Return early if host is null.

  • WebProcess/Plugins/WebPluginInfoProvider.cpp:

(WebKit::WebPluginInfoProvider::populatePluginCache):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:

(TEST):

2:56 PM Changeset in webkit [227636] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Rename some local vars from type to typedArrayType for greater clarity.
https://bugs.webkit.org/show_bug.cgi?id=182148
<rdar://problem/36882310>

Reviewed by Saam Barati.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewTypedArrayWithSize):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):

2:49 PM Changeset in webkit [227635] by commit-queue@webkit.org
  • 4 edits in trunk

ShapeOutside should use same origin credentials mode
https://bugs.webkit.org/show_bug.cgi?id=182141

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-25
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/fetch-request-css-images.https-expected.txt:

Source/WebCore:

Covered by updated test.
As per https://drafts.csswg.org/css-shapes/#shape-outside-property, ShapeOutside images
should be fetched with anonymous cors mode, meaning credentials should be set to same-origin.

  • style/StylePendingResources.cpp:

(WebCore::Style::loadPendingImage):

2:47 PM Changeset in webkit [227634] by Ryan Haddad
  • 2 edits in branches/safari-605-branch/LayoutTests

Cherry-pick r227421. rdar://problem/36837397

2:46 PM Changeset in webkit [227633] by Ryan Haddad
  • 4 edits
    2 adds in branches/safari-605-branch/LayoutTests

Cherry-pick r227260. rdar://problem/36837397

2:31 PM Changeset in webkit [227632] by wilander@apple.com
  • 2 edits in trunk/Source/WebCore

Make sure we have a frame as we iterate in ResourceLoadObserver::nonNullOwnerURL()
https://bugs.webkit.org/show_bug.cgi?id=182116
<rdar://problem/36210134>

Reviewed by Alex Christensen.

No new tests. No known repro case, just crash logs.

  • loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::nonNullOwnerURL const):

2:29 PM Changeset in webkit [227631] by jer.noble@apple.com
  • 12 edits
    3 adds in trunk

Move ImageDecoderAVFObjC from using AVSampleBufferGenerator to AVAssetReaderOutput for parsing
https://bugs.webkit.org/show_bug.cgi?id=182091

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; should be covered by existing tests.

AVSampleBufferGenerator is not available on iOS, so in order to enable ImageDecoderAVFObjC there,
we must adopt a similar API which is available both on iOS and macOS: AVAssetReaderOutput. Unlike
the generator, AVAssetReaderOutput doesn't necessarily generate samples in decode order, so we'll
repurpose the SampleMap from EME to hold the decoded samples as well as their generated images.

  • Modules/mediasource/SampleMap.cpp:
  • Modules/mediasource/SampleMap.h:

(WebCore::SampleMap::size const):

  • platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::isSupportedImageVideoOrSVGMIMEType):

  • platform/MediaSample.h:

(WebCore::MediaSample::hasAlpha const):

  • platform/graphics/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):
(WebCore::ImageDecoder::supportsMediaType):

  • platform/graphics/avfoundation/MediaSampleAVFObjC.h: Make non-final.

(WebCore::MediaSampleAVFObjC::sampleBuffer const):
(WebCore::MediaSampleAVFObjC::MediaSampleAVFObjC):

  • platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.h:
  • platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::ImageDecoderAVFObjCSample::create):
(WebCore::ImageDecoderAVFObjCSample::sampleBuffer const):
(WebCore::ImageDecoderAVFObjCSample::image const):
(WebCore::ImageDecoderAVFObjCSample::setImage):
(WebCore::ImageDecoderAVFObjCSample::ImageDecoderAVFObjCSample):
(WebCore::ImageDecoderAVFObjCSample::cacheMetadata):
(WebCore::toSample):
(WebCore::ImageDecoderAVFObjC::readSamples):
(WebCore::ImageDecoderAVFObjC::storeSampleBuffer):
(WebCore::ImageDecoderAVFObjC::advanceCursor):
(WebCore::ImageDecoderAVFObjC::setTrack):
(WebCore::ImageDecoderAVFObjC::encodedDataStatus const):
(WebCore::ImageDecoderAVFObjC::repetitionCount const):
(WebCore::ImageDecoderAVFObjC::frameIsCompleteAtIndex const):
(WebCore::ImageDecoderAVFObjC::frameDurationAtIndex const):
(WebCore::ImageDecoderAVFObjC::frameHasAlphaAtIndex const):
(WebCore::ImageDecoderAVFObjC::createFrameImageAtIndex):
(WebCore::ImageDecoderAVFObjC::setData):
(WebCore::ImageDecoderAVFObjC::clearFrameBufferCache):
(WebCore::ImageDecoderAVFObjC::sampleAtIndex const):
(WebCore::ImageDecoderAVFObjC::readSampleMetadata): Deleted.

Source/WTF:

  • wtf/Platform.h:

LayoutTests:

  • platform/ios/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt: Added.
2:27 PM Changeset in webkit [227630] by Simon Fraser
  • 16 edits in trunk/Source/WebKit

ASSERT(CGSizeEqualToSize(m_resizeScrollOffset, CGSizeZero)) in WebViewImpl::setFrameAndScrollBy()
https://bugs.webkit.org/show_bug.cgi?id=182082
rdar://problem/13971838

Reviewed by Tim Horton.

Safari could call WebViewImpl::setFrameAndScrollBy() multiple times with different scroll offsets,
triggering this assertion.

Rename to m_resizeScrollOffset to m_scrollOffsetAdjustment to reduce confusion with actual scroll offsets.
This parameter has no effect on macOS, but is used by the -[WKWebView setFrame:andScrollBy:] so at some point
needs to be hooked up to allow synchronous view resize and scroll adjustment (e.g. for the Find bar animation).

Remove DrawingAreaProxy's m_layerPosition which was unused, and remove the parameters from the UpdateGeometry message.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::setFrameAndScrollBy):
(WebKit::WebViewImpl::setDrawingAreaSize):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::setSize):

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::sendUpdateGeometry):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updateGeometry):

  • WebProcess/WebPage/DrawingArea.messages.in:
  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::updateGeometry):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):

2:04 PM Changeset in webkit [227629] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[webkitpy] Stop modifying path information only when running on Cygwin
https://bugs.webkit.org/show_bug.cgi?id=182136

On LayoutTestApacheHttpd, some path configuration is modified when platform
is Windows. This modification is only required for AppleWin running on Cygwin.
WinCairo uses native Windows environment, so the condition should be changed.

Patch by Basuke Suzuki <Basuke Suzuki> on 2018-01-25
Reviewed by Per Arne Vollan.

  • Scripts/webkitpy/layout_tests/servers/apache_http_server.py:

(LayoutTestApacheHttpd.init):
(LayoutTestApacheHttpd._get_apache_config_file_path):

1:54 PM Changeset in webkit [227628] by mark.lam@apple.com
  • 3 edits in trunk/Source/WTF

Rename the Poisoned::isPoisoned constant to Poisoned::isPoisonedType.
https://bugs.webkit.org/show_bug.cgi?id=182143
<rdar://problem/36880970>

Reviewed by JF Bastien.

This is so that it doesn't conflict with the isPoisoned() debugging methods that
are normally not built. Also renamed PoisonedUniquePtr::isPoisonedUniquePtr to
PoisonedUniquePtr::isPoisonedUniquePtrType to be consistent.

  • wtf/Poisoned.h:
  • wtf/PoisonedUniquePtr.h:
1:30 PM Changeset in webkit [227627] by Keith Rollin
  • 4 edits in trunk/Source/WebKit

Add logging to facilitate binding of WebContent and Network processes to UI process
https://bugs.webkit.org/show_bug.cgi?id=182066

Reviewed by Brent Fulgham.

When examining sysdiagnose logs and tracing events from one process to
another, it would be helpful to know which WebKit processes were
related to each other. When Safari, Mail, Messages, etc. are all
running at the same time, it may otherwise be difficult to know if a
particular Network process, for example was associated with Safari or
some other application. Add some logging to the creation of WebContent
and Network processes to identify their "presenting process" (parent
application).

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

  • Platform/Logging.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

1:27 PM Changeset in webkit [227626] by commit-queue@webkit.org
  • 4 edits in trunk

DocumentThreadableLoader should ensure service worker is not reused if redirection comes from the network
https://bugs.webkit.org/show_bug.cgi?id=182137

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-25
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/fetch-request-fallback.https-expected.txt:

Source/WebCore:

Covered by rebased test.
In case redirection does not come from memory cache or service worker, disable service worker interception when following the redirection.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::redirectReceived):

1:26 PM Changeset in webkit [227625] by commit-queue@webkit.org
  • 6 edits in trunk

DocumentLoader should interrupt ongoing load when getting a redirection from network that matches a service worker
https://bugs.webkit.org/show_bug.cgi?id=182115

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-25
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:

Source/WebCore:

Covered by rebased test.

In case a navigation load is going to the network process,
we need to interrupt it if having a redirection that leads to a new request going to a service worker.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::redirectReceived):

Source/WebKit:

  • WebProcess/Storage/ServiceWorkerClientFetch.cpp:

(WebKit::ServiceWorkerClientFetch::didReceiveResponse):

1:12 PM Changeset in webkit [227624] by Chris Dumez
  • 4 edits in trunk

Registering same scope as the script directory without the last slash should fail
https://bugs.webkit.org/show_bug.cgi?id=182122
<rdar://problem/36877167>

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test now that one more check is passing.

  • web-platform-tests/service-workers/service-worker/registration-security-error.https-expected.txt:

Source/WebCore:

This aligns our behavior with Firefox and Chrome.

No new tests, rebaselined existing test.

  • workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::didReceiveResponse):

12:23 PM Changeset in webkit [227623] by graouts@webkit.org
  • 7 edits in trunk

[Web Animations] Expose the reverse() method
https://bugs.webkit.org/show_bug.cgi?id=182100
<rdar://problem/36867117>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Update WPT test output with progressions.

  • web-platform-tests/web-animations/interfaces/Animation/idlharness-expected.txt:
  • web-platform-tests/web-animations/timing-model/animations/reversing-an-animation-expected.txt:

Source/WebCore:

We expose and implement the reverse() method on Animation as specified.

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::setPlaybackRate):
(WebCore::WebAnimation::reverse):

  • animation/WebAnimation.h:
  • animation/WebAnimation.idl:
12:21 PM Changeset in webkit [227622] by graouts@webkit.org
  • 18 edits in trunk

[Web Animations] Account for provided easings when computing progress and resolving keyframe effect values
https://bugs.webkit.org/show_bug.cgi?id=182098
<rdar://problem/36866149>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Update expected values with a few adjusted failures and many progressions.

  • web-platform-tests/css-timing-1/step-timing-functions-output-expected.txt:
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt:
  • web-platform-tests/web-animations/interfaces/Animation/effect-expected.txt:
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/easing-expected.txt:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/iterationComposite-expected.txt:
  • web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress-expected.txt:

Source/WebCore:

We now account for the timing functions provided through the "easing" propreties on whole animation effects
and individual keyframes. Exposing those exposed shortcomings of our keyframe resolution in general through
WPT tests so we now implement the "effect value of a keyframe effect" procedure from the spec to correctly
resolve keyframes in KeyframeEffect::setAnimatedPropertiesInStyle(). The tests also showed some shortcomings
in our TimingFunction code where our step() function resolution wasn't fully compliant and our cubic-bezier()
resolution not accurate enough. We now have microsecond accuracy when resolving cubic-bezier() timing functions
and identify cubic-bezier(0, 0, 0, 0), cubic-bezier(0, 0, 1, 1) and cubic-bezier(1, 1, 1, 1) as linear timing
functions, as called out by the WPT tests.

  • animation/AnimationEffect.cpp:

(WebCore::AnimationEffect::transformedProgress const): Account for the effect-wide timing function when computing
the progress.
(WebCore::AnimationEffect::iterationProgress const): Use the transformed progress now that we support this procedure.

  • animation/AnimationEffect.h:
  • animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::apply): We now use the computed progress from AnimationEffect rather than compute based
on the provided time, which we've dropped as an argument.
(WebCore::KeyframeEffect::getAnimatedStyle):
(WebCore::KeyframeEffect::setAnimatedPropertiesInStyle): Implement the "effect value of a keyframe effect" procedure
in full as specified (save for composite operations).
(WebCore::KeyframeEffect::applyAtLocalTime): Deleted.

  • animation/KeyframeEffect.h:
  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::resolve):

  • css/CSSTimingFunctionValue.h: Fix a small error made in a previous patch where we used "int" instead of "unsigned".
  • platform/animation/TimingFunction.cpp:

(WebCore::TimingFunction::transformTime const):

  • platform/animation/TimingFunction.h:

LayoutTests:

Update an animated value due to more accurate resolution of cubic-bezier() timing functions.

  • platform/mac/transitions/default-timing-function-expected.txt:
12:13 PM Changeset in webkit [227621] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Fix crash when preconnecting while closing private browsing
https://bugs.webkit.org/show_bug.cgi?id=182114
<rdar://problem/35637284>

Reviewed by Joseph Pecoraro.

  • NetworkProcess/PreconnectTask.cpp:

There is a race condition when destroying a session while a page is initiating a preconnect.
If this happens, fail gracefully instead of trying to preconnect with a null session.

12:12 PM Changeset in webkit [227620] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Update test expectations.

Unreviewed test gardening.

  • platform/win/TestExpectations:
12:00 PM Changeset in webkit [227619] by Ryan Haddad
  • 2 edits in branches/safari-605-branch/LayoutTests

Work towards rdar://problem/36837397.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
11:34 AM Changeset in webkit [227618] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit

[Mac] Enable library validation for Networking & Storage XPC services
https://bugs.webkit.org/show_bug.cgi?id=173424
<rdar://problem/32386565>

Reviewed by Joseph Pecoraro.

  • Configurations/BaseXPCService.xcconfig: Moved the definitions of WK_LIBRARY_VALIDATION_ENABLED and WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS from WebContentService.xcconfig to here and made them Mac-only at this level.
  • Configurations/NetworkService.xcconfig: Also set OTHER_CODE_SIGN_FLAGS to WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS.
  • Configurations/StorageService.xcconfig: Ditto.
  • Configurations/WebContentService.xcconfig: Moved definitions from here to BaseXPCService.xcconfig.
11:32 AM Changeset in webkit [227617] by fpizlo@apple.com
  • 58 edits
    12 adds in trunk/Source

JSC GC should support TLCs (thread local caches)
https://bugs.webkit.org/show_bug.cgi?id=181559

Reviewed by Mark Lam and Saam Barati.
Source/JavaScriptCore:


This is a big step towards object distancing by site origin. This patch implements TLCs, or
thread-local caches, which allow each thread to allocate from its own free lists. It also
means that any given thread can context-switch TLCs. This will allow us to do separate
allocation for separate site origins. Eventually, once we reshape how MarkedBlock looks, this
will allow us to have a hard distancing constraint between objects from different origins.

In this new design, every "size class" is represented as a BlockDirectory (formerly known as
MarkedAllocator, prior to r226822). This contains a bag of blocks allocated using some
aligned memory allocator (which roughly represents which cage you came out of), and anyone
using the same allocator can share those blocks - but so long as they are in that
BlockDirectory, they will have the size and type of that directory. Previously, each
BlockDirectory had exactly one FreeList. Now, each BlockDirectory has a double-linked-list of
LocalAllocators, each of which has a FreeList.

To decide which LocalAllocator to allocate out of, we need a ThreadLocalCache and a
BlockDirectory. The directory gives us an offset-within-the-ThreadLocalCache, which we simply
call the Allocator (which is just a POD type that contains a 32-bit offset). Each allocation
starts by figuring out what Allocator it wants (often we have this information at JIT time).
Then the allocation loads its ThreadLocalCache::Data from a fast TLS slot. Then we add the
Allocator offset to the ThreadLocalCache::Data to get the LocalAllocator. Note that we use
offsets as opposed to indices to make it easy to do the math on each allocation (if
LocalAllocator had a weird size then every allocation would have to do an imul).

This is a definite slow-down on GC-heavy benchmarks, but by a small margin, and only on
unusually heavy tests. For example, boyer and splay are both 3% regressed, but the Octane
geomean is just fine. The JetStream score regressed by 0.5% with p = 0.08 (so maybe there is
something there, but it's not significant according to our threshold).

Relanding after fixing ARM64 bug in AssemblyHelpers::emitAllocateWithNonNullAllocator(). That
function needs to be careful to avoid using the scratch register because the FTL will call it
in disallow-scratch-register mode.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • b3/B3LowerToAir.cpp:
  • b3/B3PatchpointSpecial.cpp:

(JSC::B3::PatchpointSpecial::admitsStack):

  • b3/B3StackmapSpecial.cpp:

(JSC::B3::StackmapSpecial::forEachArgImpl):
(JSC::B3::StackmapSpecial::isArgValidForRep):

  • b3/B3StackmapValue.cpp:

(JSC::B3::StackmapValue::appendSomeRegisterWithClobber):

  • b3/B3StackmapValue.h:
  • b3/B3Validate.cpp:
  • b3/B3ValueRep.cpp:

(JSC::B3::ValueRep::addUsedRegistersTo const):
(JSC::B3::ValueRep::dump const):
(WTF::printInternal):

  • b3/B3ValueRep.h:

(JSC::B3::ValueRep::ValueRep):

  • bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

  • bytecode/ObjectAllocationProfile.h:

(JSC::ObjectAllocationProfile::ObjectAllocationProfile):
(JSC::ObjectAllocationProfile::clear):

  • bytecode/ObjectAllocationProfileInlines.h:

(JSC::ObjectAllocationProfile::initializeProfile):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):
(JSC::DFG::SpeculativeJIT::compileMakeRope):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileCreateThis):
(JSC::DFG::SpeculativeJIT::compileNewObject):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateJSCell):
(JSC::DFG::SpeculativeJIT::emitAllocateJSObject):

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):
(JSC::FTL::DFG::LowerDFGToB3::allocatePropertyStorageWithSizeImpl):
(JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell):
(JSC::FTL::DFG::LowerDFGToB3::allocateObject):
(JSC::FTL::DFG::LowerDFGToB3::allocatorForSize):
(JSC::FTL::DFG::LowerDFGToB3::allocateVariableSizedObject):
(JSC::FTL::DFG::LowerDFGToB3::allocateVariableSizedCell):

  • heap/Allocator.cpp: Added.

(JSC::Allocator::cellSize const):

  • heap/Allocator.h: Added.

(JSC::Allocator::Allocator):
(JSC::Allocator::offset const):
(JSC::Allocator::operator== const):
(JSC::Allocator::operator!= const):
(JSC::Allocator::operator bool const):

  • heap/AllocatorInlines.h: Added.

(JSC::Allocator::allocate const):
(JSC::Allocator::tryAllocate const):

  • heap/BlockDirectory.cpp:

(JSC::BlockDirectory::BlockDirectory):
(JSC::BlockDirectory::findBlockForAllocation):
(JSC::BlockDirectory::stopAllocating):
(JSC::BlockDirectory::prepareForAllocation):
(JSC::BlockDirectory::stopAllocatingForGood):
(JSC::BlockDirectory::resumeAllocating):
(JSC::BlockDirectory::endMarking):
(JSC::BlockDirectory::isFreeListedCell):
(JSC::BlockDirectory::didConsumeFreeList): Deleted.
(JSC::BlockDirectory::tryAllocateWithoutCollecting): Deleted.
(JSC::BlockDirectory::allocateIn): Deleted.
(JSC::BlockDirectory::tryAllocateIn): Deleted.
(JSC::BlockDirectory::doTestCollectionsIfNeeded): Deleted.
(JSC::BlockDirectory::allocateSlowCase): Deleted.

  • heap/BlockDirectory.h:

(JSC::BlockDirectory::cellKind const):
(JSC::BlockDirectory::allocator const):
(JSC::BlockDirectory::freeList const): Deleted.
(JSC::BlockDirectory::offsetOfFreeList): Deleted.
(JSC::BlockDirectory::offsetOfCellSize): Deleted.

  • heap/BlockDirectoryInlines.h:

(JSC::BlockDirectory::isFreeListedCell const): Deleted.
(JSC::BlockDirectory::allocate): Deleted.

  • heap/CompleteSubspace.cpp:

(JSC::CompleteSubspace::CompleteSubspace):
(JSC::CompleteSubspace::allocatorFor):
(JSC::CompleteSubspace::allocate):
(JSC::CompleteSubspace::allocateNonVirtual):
(JSC::CompleteSubspace::allocatorForSlow):
(JSC::CompleteSubspace::allocateSlow):
(JSC::CompleteSubspace::tryAllocateSlow):

  • heap/CompleteSubspace.h:

(JSC::CompleteSubspace::allocatorForSizeStep):
(JSC::CompleteSubspace::allocatorForNonVirtual):

  • heap/FreeList.h:
  • heap/GCDeferralContext.h:
  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::lastChanceToFinalize):

  • heap/Heap.h:

(JSC::Heap::threadLocalCacheLayout):

  • heap/IsoCellSet.h:
  • heap/IsoSubspace.cpp:

(JSC::IsoSubspace::IsoSubspace):
(JSC::IsoSubspace::allocatorFor):
(JSC::IsoSubspace::allocate):
(JSC::IsoSubspace::allocateNonVirtual):

  • heap/IsoSubspace.h:

(JSC::IsoSubspace::allocatorForNonVirtual):

  • heap/LocalAllocator.cpp: Added.

(JSC::LocalAllocator::LocalAllocator):
(JSC::LocalAllocator::reset):
(JSC::LocalAllocator::~LocalAllocator):
(JSC::LocalAllocator::stopAllocating):
(JSC::LocalAllocator::resumeAllocating):
(JSC::LocalAllocator::prepareForAllocation):
(JSC::LocalAllocator::stopAllocatingForGood):
(JSC::LocalAllocator::allocateSlowCase):
(JSC::LocalAllocator::didConsumeFreeList):
(JSC::LocalAllocator::tryAllocateWithoutCollecting):
(JSC::LocalAllocator::allocateIn):
(JSC::LocalAllocator::tryAllocateIn):
(JSC::LocalAllocator::doTestCollectionsIfNeeded):
(JSC::LocalAllocator::isFreeListedCell const):

  • heap/LocalAllocator.h: Added.

(JSC::LocalAllocator::offsetOfFreeList):
(JSC::LocalAllocator::offsetOfCellSize):

  • heap/LocalAllocatorInlines.h: Added.

(JSC::LocalAllocator::allocate):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::stopAllocatingForGood):

  • heap/MarkedSpace.h:
  • heap/SlotVisitor.cpp:
  • heap/SlotVisitor.h:
  • heap/Subspace.h:
  • heap/ThreadLocalCache.cpp: Added.

(JSC::ThreadLocalCache::create):
(JSC::ThreadLocalCache::ThreadLocalCache):
(JSC::ThreadLocalCache::~ThreadLocalCache):
(JSC::ThreadLocalCache::allocateData):
(JSC::ThreadLocalCache::destroyData):
(JSC::ThreadLocalCache::installSlow):
(JSC::ThreadLocalCache::installData):
(JSC::ThreadLocalCache::allocatorSlow):
(JSC::ThreadLocalCache::destructor):

  • heap/ThreadLocalCache.h: Added.

(JSC::ThreadLocalCache::offsetOfSize):
(JSC::ThreadLocalCache::offsetOfFirstAllocator):

  • heap/ThreadLocalCacheInlines.h: Added.

(JSC::ThreadLocalCache::getImpl):
(JSC::ThreadLocalCache::get):
(JSC::ThreadLocalCache::install):
(JSC::ThreadLocalCache::allocator):
(JSC::ThreadLocalCache::tryGetAllocator):

  • heap/ThreadLocalCacheLayout.cpp: Added.

(JSC::ThreadLocalCacheLayout::ThreadLocalCacheLayout):
(JSC::ThreadLocalCacheLayout::~ThreadLocalCacheLayout):
(JSC::ThreadLocalCacheLayout::allocateOffset):
(JSC::ThreadLocalCacheLayout::snapshot):
(JSC::ThreadLocalCacheLayout::directory):

  • heap/ThreadLocalCacheLayout.h: Added.
  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):
(JSC::AssemblyHelpers::emitAllocate):
(JSC::AssemblyHelpers::emitAllocateVariableSized):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::vm):
(JSC::AssemblyHelpers::emitAllocateJSCell):
(JSC::AssemblyHelpers::emitAllocateJSObject):
(JSC::AssemblyHelpers::emitAllocateJSObjectWithKnownSize):
(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator): Deleted.
(JSC::AssemblyHelpers::emitAllocate): Deleted.
(JSC::AssemblyHelpers::emitAllocateVariableSized): Deleted.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_object):
(JSC::JIT::emit_op_create_this):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_new_object):
(JSC::JIT::emit_op_create_this):

  • runtime/ButterflyInlines.h:

(JSC::Butterfly::createUninitialized):
(JSC::Butterfly::tryCreate):
(JSC::Butterfly::growArrayRight):

  • runtime/DirectArguments.cpp:

(JSC::DirectArguments::overrideThings):

  • runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::initModifiedArgumentsDescriptor):

  • runtime/HashMapImpl.h:

(JSC::HashMapBuffer::create):

  • runtime/JSArray.cpp:

(JSC::JSArray::tryCreateUninitializedRestricted):
(JSC::JSArray::unshiftCountSlowCase):

  • runtime/JSArray.h:

(JSC::JSArray::tryCreate):

  • runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):

  • runtime/JSCellInlines.h:

(JSC::tryAllocateCellHelper):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::threadLocalCache const):

  • runtime/JSLock.cpp:

(JSC::JSLock::didAcquireLock):

  • runtime/Options.h:
  • runtime/RegExpMatchesArray.h:

(JSC::tryCreateUninitializedRegExpMatchesArray):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
  • runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope):

Source/WTF:

  • wtf/Bitmap.h: Just fixing a compile error.
11:27 AM Changeset in webkit [227616] by eric.carlson@apple.com
  • 2 edits in trunk/Tools

REGRESSION(r227457): Release assert in updateLayout while destructing a media element
https://bugs.webkit.org/show_bug.cgi?id=182038
<rdar://problem/36812083>

Reviewed by Jer Noble.

  • TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:

(TestWebKitAPI::TEST): Show/hide page so controls are always updated.

10:48 AM Changeset in webkit [227615] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Web Animations] Avoid querying the current time multiple time when resolving the play state
https://bugs.webkit.org/show_bug.cgi?id=182099

Patch by Antoine Quint <Antoine Quint> on 2018-01-25
Reviewed by Dean Jackson.

No test change since this shouldn't cause any change in behavior.

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::playState const):

10:43 AM Changeset in webkit [227614] by hyatt@apple.com
  • 7 edits in trunk/Source/WebKit

Enable lines clamp support for Apple Mail by default
https://bugs.webkit.org/show_bug.cgi?id=182113

Reviewed by Dean Jackson.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::appleMailLinesClampEnabled):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

10:40 AM Changeset in webkit [227613] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Adjusted expectation for memory/memory-pressure-simulation.html.
https://bugs.webkit.org/show_bug.cgi?id=170629

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:02 AM Changeset in webkit [227612] by commit-queue@webkit.org
  • 11 edits in trunk

Set integrity fetch options for loading scripts and CSS
https://bugs.webkit.org/show_bug.cgi?id=182077

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-25
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/fetch-request-resources.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/fetch-request-resources.https.html:

Source/WebCore:

Covered by updated test.

Set integrity fetch option in script and CSS loading.

  • bindings/js/CachedModuleScriptLoader.cpp:

(WebCore::CachedModuleScriptLoader::load):

  • bindings/js/CachedScriptFetcher.cpp:

(WebCore::CachedScriptFetcher::requestModuleScript const):
(WebCore::CachedScriptFetcher::requestScriptWithCache const):

  • bindings/js/CachedScriptFetcher.h:
  • dom/LoadableClassicScript.cpp:

(WebCore::LoadableClassicScript::load):

  • dom/ScriptElementCachedScriptFetcher.cpp:

(WebCore::ScriptElementCachedScriptFetcher::requestModuleScript const):

  • dom/ScriptElementCachedScriptFetcher.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

10:00 AM Changeset in webkit [227611] by Ryan Haddad
  • 6 edits in branches/safari-605-branch/LayoutTests

Work towards rdar://problem/36837397.

Unreviewed test gardening.

LayoutTests/imported/w3c:

  • web-platform-tests/html/dom/reflection-forms-expected.txt:

LayoutTests:

  • platform/mac-elcapitan-wk2/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/mac/TestExpectations:
9:48 AM Changeset in webkit [227610] by dbates@webkit.org
  • 2 edits in trunk/Tools

webkit-patch upload emits irrelevant simulator warnings
https://bugs.webkit.org/show_bug.cgi?id=181702
<rdar://problem/36556359>

Reviewed by Aakash Jain.

Remove warning when a person explicitly passes --child-processes with a value greater than
the default number of simulator instances webkitpy would have used had --child-processes
been omitted. Moreover, the placement of the warning logic to support printing such a message
(in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.

By default, webkitpy will parallelize running tests using the maximum number of simulator
instances that can be supported based on available system resources at the time run-webkit-tests
is invoked. It seems reasonable to assume that a person that explicitly overrides this default
by specifying --child-processes knows what they are doing. The effects of picking a large
value be obvious, the system may become sluggish.

As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).

  • Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort.init):

9:21 AM Changeset in webkit [227609] by commit-queue@webkit.org
  • 58 edits
    12 deletes in trunk/Source

Unreviewed, rolling out r227592.
https://bugs.webkit.org/show_bug.cgi?id=182110

it made ARM64 (Linux and iOS) crash (Requested by pizlo-mbp on
#webkit).

Reverted changeset:

"JSC GC should support TLCs (thread local caches)"
https://bugs.webkit.org/show_bug.cgi?id=181559
https://trac.webkit.org/changeset/227592

8:44 AM WebKitGTK/Gardening/Calendar edited by magomez@igalia.com
(diff)
8:40 AM Changeset in webkit [227608] by magomez@igalia.com
  • 4 edits in trunk/LayoutTests

Unreviewed GTK+ gardening after r227599.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/overflow/line-clamp-expected.png:
  • platform/gtk/fast/overflow/line-clamp-expected.txt:
7:52 AM Changeset in webkit [227607] by svillar@igalia.com
  • 7 edits in trunk

[WebVR][GTK][WPE] Remove the WebVR public API added in r227518
https://bugs.webkit.org/show_bug.cgi?id=182102

Reviewed by Carlos Garcia Campos.

Source/WebKit:

  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:

Tools:

  • MiniBrowser/gtk/main.c:

(main): Removed the call to set_enable_webvr().

7:37 AM Changeset in webkit [227606] by Claudio Saavedra
  • 3 edits in trunk/Source/WebKit

[GTK] Fix build with touch events disabled

Unreviewed build fix.

Explicitly include gtk.h in files that were indirectly getting it
only when touch events were enabled.

  • UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:
  • UIProcess/gtk/WaylandCompositor.h:
7:25 AM Changeset in webkit [227605] by Manuel Rego Casasnovas
  • 2 edits in trunk/LayoutTests

[css-multicol] Some test imported in r227600 are failing

Unreviewed gardening.

5:53 AM Changeset in webkit [227604] by Carlos Garcia Campos
  • 4 edits in trunk

WebDriver: add support for slow tests
https://bugs.webkit.org/show_bug.cgi?id=182095

Reviewed by Carlos Alberto Lopez Perez.

Tools:

Add timeout mark to slow tests.

  • Scripts/webkitpy/webdriver_tests/pytest_runner.py:

(TestExpectationsMarker.init): Save the timeout.
(TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
(run): Pass timeout to TestExpectationsMarker constructor.

WebDriverTests:

Mark several tests as slow.

5:52 AM Changeset in webkit [227603] by Carlos Garcia Campos
  • 11 edits in trunk

WebDriver: test imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_browserName fails
https://bugs.webkit.org/show_bug.cgi?id=181985

Reviewed by Carlos Alberto Lopez Perez.

Source/WebDriver:

The problem is that we are considering a failure when the browser name doesn't match the capabilities, instead
of trying with the next merged capabilities. This is happening because when processing capabilities, we only
match the ones that we know without having to launch the browser. Browser name and version are provided by the
browser during the session initialization. This patch reworks the session creation to make it possible to try
with the next merged capabilities when matching fails after the browser is launched.

  • Session.cpp:

(WebDriver::Session::Session): Initialize timeouts from capabilities, because now we have the final capabilities here.
(WebDriver::Session::id const): Return the session ID from the SessionHost, since it's now created there.
(WebDriver::Session::createTopLevelBrowsingContext): Do not start the session, it has already been started a
this point.
(WebDriver::Session::createElement): Use id() instead of m_id.

  • Session.h:
  • SessionHost.h:

(WebDriver::SessionHost::sessionID const): Return the session ID.

  • WebDriverService.cpp:

(WebDriver::WebDriverService::matchCapabilities const): Remove the error handling, and return a boolean instead,
since not mathing is not an error.
(WebDriver::WebDriverService::processCapabilities const): Return a list of matched capabilities, instead of the
JSON object corresponding to the first match.
(WebDriver::WebDriverService::newSession): Use helper connectToBrowser().
(WebDriver::WebDriverService::connectToBrowser): Create a session host for the next merged capabilities and
connect to the browser.
(WebDriver::WebDriverService::createSession): Start a new automation session. If capabilities didn't match,
start the process again calling connectToBrowser(), otherwise create the new session and top level.

  • WebDriverService.h:
  • glib/SessionHostGlib.cpp:

(WebDriver::matchBrowserOptions): Helper to check browser options.
(WebDriver::SessionHost::matchCapabilities): Use matchBrowserOptions() and return true or false instead of an
optional error message.
(WebDriver::SessionHost::startAutomationSession): Create the session ID here and notify the caller in case
capabilities didn't match.
(WebDriver::SessionHost::setTargetList): Notify that capabilities did match.

  • gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformMatchCapability const): Make it return bool.

  • wpe/WebDriverServiceWPE.cpp:

(WebDriver::WebDriverService::platformMatchCapability const): Ditto.

WebDriverTests:

Remove expectations for imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_browserName.

5:51 AM Changeset in webkit [227602] by Carlos Garcia Campos
  • 4 edits in trunk

WebDriver: test imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_platformName fails
https://bugs.webkit.org/show_bug.cgi?id=181984

Reviewed by Carlos Alberto Lopez Perez.

Source/WebDriver:

Platform name is expected to be lower case, so do not compre ignoring case.

Fixes: imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_platformName

  • WebDriverService.cpp:

(WebDriver::WebDriverService::matchCapabilities const):

WebDriverTests:

Remove expectations for imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_platformName.

5:50 AM Changeset in webkit [227601] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

WebDriver: test imported/selenium/py/test/selenium/webdriver/common/alerts_tests.py crashes in debug
https://bugs.webkit.org/show_bug.cgi?id=182096

Reviewed by Carlos Alberto Lopez Perez.

It's an assert in HashTable iterators checkValidity(). The problem is that we get the keys to iterate the values
and the map is modified inside the loop. We need to use copyToVector to copy the keys.

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::respondToPendingPageNavigationCallbacksWithTimeout):
(WebKit::WebAutomationSession::respondToPendingFrameNavigationCallbacksWithTimeout):
(WebKit::WebAutomationSession::willShowJavaScriptDialog):

5:26 AM Changeset in webkit [227600] by Manuel Rego Casasnovas
  • 130 edits
    6 copies
    37 adds in trunk/LayoutTests

[css-multicol] Update WPT test suite
https://bugs.webkit.org/show_bug.cgi?id=182087

Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/css/css-multicol/OWNERS: Added.
  • web-platform-tests/css/css-multicol/extremely-tall-multicol-with-extremely-tall-child-crash-expected.txt: Added.
  • web-platform-tests/css/css-multicol/extremely-tall-multicol-with-extremely-tall-child-crash.html: Added.
  • web-platform-tests/css/css-multicol/multicol-basic-001-expected.html:
  • web-platform-tests/css/css-multicol/multicol-basic-001.html:
  • web-platform-tests/css/css-multicol/multicol-basic-002-expected.html:
  • web-platform-tests/css/css-multicol/multicol-basic-002.html:
  • web-platform-tests/css/css-multicol/multicol-basic-003-expected.html:
  • web-platform-tests/css/css-multicol/multicol-basic-003.html:
  • web-platform-tests/css/css-multicol/multicol-basic-004-expected.html:
  • web-platform-tests/css/css-multicol/multicol-basic-004.html:
  • web-platform-tests/css/css-multicol/multicol-basic-005-expected.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-basic-005.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-basic-006-expected.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-basic-006.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-basic-007-expected.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-basic-007.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-basic-008-expected.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-basic-008.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-block-no-clip-001-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/multicol-width-002-expected.xht.
  • web-platform-tests/css/css-multicol/multicol-block-no-clip-001.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/multicol-clip-001.xht.
  • web-platform-tests/css/css-multicol/multicol-block-no-clip-002-expected.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-block-no-clip-002.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/multicol-clip-001.xht.
  • web-platform-tests/css/css-multicol/multicol-br-inside-avoidcolumn-001-expected.html: Added.
  • web-platform-tests/css/css-multicol/multicol-br-inside-avoidcolumn-001.xht:
  • web-platform-tests/css/css-multicol/multicol-break-000-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-break-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-break-001.xht:
  • web-platform-tests/css/css-multicol/multicol-clip-001.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-001.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-002-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-002.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-003-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-003.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-004-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-004.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-005-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-005.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-006-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-006.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-007-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-007.xht:
  • web-platform-tests/css/css-multicol/multicol-columns-invalid-002.xht:
  • web-platform-tests/css/css-multicol/multicol-containing-001.xht:
  • web-platform-tests/css/css-multicol/multicol-containing-002.xht:
  • web-platform-tests/css/css-multicol/multicol-count-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-count-001.xht:
  • web-platform-tests/css/css-multicol/multicol-count-002-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-count-computed-003-expected.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-count-computed-003.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-count-computed-005-expected.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-count-computed-005.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-fill-000.xht:
  • web-platform-tests/css/css-multicol/multicol-fill-001.xht:
  • web-platform-tests/css/css-multicol/multicol-fill-auto-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-fill-auto-001.xht:
  • web-platform-tests/css/css-multicol/multicol-fill-auto-002-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-fill-auto-002.xht:
  • web-platform-tests/css/css-multicol/multicol-fill-auto-003.xht:
  • web-platform-tests/css/css-multicol/multicol-fill-auto-block-children-002-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-fill-auto-block-children-002.xht:
  • web-platform-tests/css/css-multicol/multicol-fill-balance-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-fill-balance-001.xht:
  • web-platform-tests/css/css-multicol/multicol-fill-balance-002-expected.html: Added.
  • web-platform-tests/css/css-multicol/multicol-fill-balance-002.html: Added.
  • web-platform-tests/css/css-multicol/multicol-gap-000.xht:
  • web-platform-tests/css/css-multicol/multicol-gap-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-gap-animation-001-expected.txt: Added.
  • web-platform-tests/css/css-multicol/multicol-gap-animation-001.html: Added.
  • web-platform-tests/css/css-multicol/multicol-gap-animation-002-expected.txt: Added.
  • web-platform-tests/css/css-multicol/multicol-gap-animation-002.html: Added.
  • web-platform-tests/css/css-multicol/multicol-gap-animation-003-expected.txt: Added.
  • web-platform-tests/css/css-multicol/multicol-gap-animation-003.html: Added.
  • web-platform-tests/css/css-multicol/multicol-gap-fraction-002-expected.html: Added.
  • web-platform-tests/css/css-multicol/multicol-gap-fraction-002.html: Added.
  • web-platform-tests/css/css-multicol/multicol-gap-large-001.xht:
  • web-platform-tests/css/css-multicol/multicol-gap-large-002-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-gap-percentage-001-expected.txt: Added.
  • web-platform-tests/css/css-multicol/multicol-gap-percentage-001.html: Added.
  • web-platform-tests/css/css-multicol/multicol-height-block-child-001-expected.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-height-block-child-001.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-inherit-001.xht:
  • web-platform-tests/css/css-multicol/multicol-inherit-002.xht:
  • web-platform-tests/css/css-multicol/multicol-inherit-003.xht:
  • web-platform-tests/css/css-multicol/multicol-margin-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-margin-001.xht:
  • web-platform-tests/css/css-multicol/multicol-margin-002-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-margin-002.xht:
  • web-platform-tests/css/css-multicol/multicol-margin-child-001.xht:
  • web-platform-tests/css/css-multicol/multicol-nested-005.xht:
  • web-platform-tests/css/css-multicol/multicol-nested-column-rule-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-nested-column-rule-001.xht:
  • web-platform-tests/css/css-multicol/multicol-nested-margin-002-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-nested-margin-002.xht:
  • web-platform-tests/css/css-multicol/multicol-nested-margin-003.xht:
  • web-platform-tests/css/css-multicol/multicol-nested-margin-004-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-nested-margin-004.xht:
  • web-platform-tests/css/css-multicol/multicol-nested-margin-005-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-nested-margin-005.xht:
  • web-platform-tests/css/css-multicol/multicol-overflow-000.xht:
  • web-platform-tests/css/css-multicol/multicol-reduce-000-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-reduce-000.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-000-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-000.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-001.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-002-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-002.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-003.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-color-001.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-color-inherit-002.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-dashed-000.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-double-000.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-fraction-002.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-fraction-003-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-fraction-003.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-groove-000.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-hidden-000.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-inset-000.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-large-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-large-001.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-large-002.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/multicol-rule-large-001.xht.
  • web-platform-tests/css/css-multicol/multicol-rule-none-000.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-outset-000.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-px-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-px-001.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-ridge-000.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-samelength-001.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-shorthand-2-expected.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/multicol-shorthand-001-expected.xht.
  • web-platform-tests/css/css-multicol/multicol-rule-shorthand-2.xht: Copied from LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/multicol-rule-002.xht.
  • web-platform-tests/css/css-multicol/multicol-rule-solid-000.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-stacking-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-rule-stacking-001.xht:
  • web-platform-tests/css/css-multicol/multicol-shorthand-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-shorthand-001.xht:
  • web-platform-tests/css/css-multicol/multicol-span-000.xht:
  • web-platform-tests/css/css-multicol/multicol-span-all-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-span-all-001.xht:
  • web-platform-tests/css/css-multicol/multicol-span-all-003-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-span-all-003.xht:
  • web-platform-tests/css/css-multicol/multicol-span-all-block-sibling-003-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-span-all-block-sibling-003.xht:
  • web-platform-tests/css/css-multicol/multicol-span-all-margin-001.xht:
  • web-platform-tests/css/css-multicol/multicol-span-all-margin-002-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-span-all-margin-bottom-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-span-all-margin-bottom-001.xht:
  • web-platform-tests/css/css-multicol/multicol-span-all-margin-nested-firstchild-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-span-all-margin-nested-firstchild-001.xht:
  • web-platform-tests/css/css-multicol/multicol-span-none-001-expected.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-span-none-001.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-table-cell-vertical-align-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-table-cell-vertical-align-001.xht:
  • web-platform-tests/css/css-multicol/multicol-width-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-width-001.xht:
  • web-platform-tests/css/css-multicol/multicol-width-002-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-width-003-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-width-ch-001-expected.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-width-ch-001.xht: Added.
  • web-platform-tests/css/css-multicol/multicol-width-count-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-width-count-001.xht:
  • web-platform-tests/css/css-multicol/multicol-width-count-002-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-width-negative-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-width-small-001.xht:
  • web-platform-tests/css/css-multicol/multicol-zero-height-001-expected.xht:
  • web-platform-tests/css/css-multicol/multicol-zero-height-001.xht:
  • web-platform-tests/css/css-multicol/support/w3c-import.log: Added.
  • web-platform-tests/css/css-multicol/w3c-import.log: Added.

LayoutTests:

4:18 AM Changeset in webkit [227599] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[Cairo] Use GraphicsContextImplCairo in Nicosia::PaintingContextCairo
https://bugs.webkit.org/show_bug.cgi?id=182094

Reviewed by Carlos Garcia Campos.

Have Nicosia::PaintingContextCairo create a GraphicsContext object that
utilizes a factory function which returns a freshly-allocated
GraphicsContextImplCairo through which all the painting is then done.
This moves GraphicsLayer painting over to using the GraphicsContextImpl
infrastructure.

No new tests -- no changes in behavior.

  • platform/graphics/nicosia/NicosiaPaintingContextCairo.cpp:

(Nicosia::PaintingContextCairo::PaintingContextCairo):

2:24 AM Changeset in webkit [227598] by graouts@webkit.org
  • 3 edits
    98 copies
    73 adds
    1 delete in trunk/LayoutTests

[Web Animations] Update WPT tests and move them to imported/w3c/web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=182092

Unreviewed test gardening.

LayoutTests/imported/w3c:

  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt.
  • web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property.html: Renamed from LayoutTests/http/wpt/web-animations/animation-model/animation-types/accumulation-per-property.html.
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/animation-model/animation-types/addition-per-property-expected.txt.
  • web-platform-tests/web-animations/animation-model/animation-types/addition-per-property.html: Renamed from LayoutTests/http/wpt/web-animations/animation-model/animation-types/addition-per-property.html.
  • web-platform-tests/web-animations/animation-model/animation-types/discrete-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/animation-model/animation-types/discrete-animation-expected.txt.
  • web-platform-tests/web-animations/animation-model/animation-types/discrete.html: Renamed from LayoutTests/http/wpt/web-animations/animation-model/animation-types/discrete-animation.html.
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt.
  • web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property.html: Renamed from LayoutTests/http/wpt/web-animations/animation-model/animation-types/interpolation-per-property.html.
  • web-platform-tests/web-animations/animation-model/animation-types/property-list.js: Renamed from LayoutTests/http/wpt/web-animations/animation-model/animation-types/property-list.js.
  • web-platform-tests/web-animations/animation-model/animation-types/property-types.js: Renamed from LayoutTests/http/wpt/web-animations/animation-model/animation-types/property-types.js.
  • web-platform-tests/web-animations/animation-model/animation-types/visibility-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/animation-model/keyframe-effects/effect-value-visibility-expected.txt.
  • web-platform-tests/web-animations/animation-model/animation-types/visibility.html: Renamed from LayoutTests/http/wpt/web-animations/animation-model/keyframe-effects/effect-value-visibility.html.
  • web-platform-tests/web-animations/animation-model/combining-effects/effect-composition-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/animation-model/combining-effects/effect-composition-expected.txt.
  • web-platform-tests/web-animations/animation-model/combining-effects/effect-composition.html: Renamed from LayoutTests/http/wpt/web-animations/animation-model/combining-effects/effect-composition.html.
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-context-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/animation-model/keyframe-effects/effect-value-context-expected.txt.
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-context.html: Renamed from LayoutTests/http/wpt/web-animations/animation-model/keyframe-effects/effect-value-context.html.
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt: Added.
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/KeyframeEffect/iterationComposite.html.
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-overlapping-keyframes-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/animation-model/keyframe-effects/effect-value-overlapping-keyframes-expected.txt.
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-overlapping-keyframes.html: Renamed from LayoutTests/http/wpt/web-animations/animation-model/keyframe-effects/effect-value-overlapping-keyframes.html.
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-transformed-distance-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/animation-model/keyframe-effects/effect-value-transformed-distance-expected.txt.
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-transformed-distance.html: Renamed from LayoutTests/http/wpt/web-animations/animation-model/keyframe-effects/effect-value-transformed-distance.html.
  • web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animatable/animate-no-browsing-context-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animatable/animate-no-browsing-context.html.
  • web-platform-tests/web-animations/interfaces/Animatable/animate.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animatable/animate.html.
  • web-platform-tests/web-animations/interfaces/Animatable/getAnimations-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/Animatable/getAnimations.html: Added.
  • web-platform-tests/web-animations/interfaces/Animation/cancel-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/cancel-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animation/cancel.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/cancel.html.
  • web-platform-tests/web-animations/interfaces/Animation/constructor-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/constructor-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animation/constructor.html: Added.
  • web-platform-tests/web-animations/interfaces/Animation/effect-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/effect-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animation/effect.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/effect.html.
  • web-platform-tests/web-animations/interfaces/Animation/finish-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/Animation/finish.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/finish.html.
  • web-platform-tests/web-animations/interfaces/Animation/finished-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/Animation/finished.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/finished.html.
  • web-platform-tests/web-animations/interfaces/Animation/id-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/id-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animation/id.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/id.html.
  • web-platform-tests/web-animations/interfaces/Animation/idlharness-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/idlharness-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animation/idlharness.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/idlharness.html.
  • web-platform-tests/web-animations/interfaces/Animation/oncancel-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/oncancel-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animation/oncancel.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/oncancel.html.
  • web-platform-tests/web-animations/interfaces/Animation/onfinish-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/onfinish-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animation/onfinish.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/onfinish.html.
  • web-platform-tests/web-animations/interfaces/Animation/pause-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/pause-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animation/pause.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/pause.html.
  • web-platform-tests/web-animations/interfaces/Animation/pending-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/Animation/pending.html: Added.
  • web-platform-tests/web-animations/interfaces/Animation/play-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/play-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animation/play.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/play.html.
  • web-platform-tests/web-animations/interfaces/Animation/playbackRate-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/playbackRate-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animation/playbackRate.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/playbackRate.html.
  • web-platform-tests/web-animations/interfaces/Animation/ready-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/ready-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animation/ready.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/ready.html.
  • web-platform-tests/web-animations/interfaces/Animation/startTime-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/startTime-expected.txt.
  • web-platform-tests/web-animations/interfaces/Animation/startTime.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Animation/startTime.html.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/delay-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/delay.html: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/direction-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/direction.html: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/duration-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/duration.html: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/easing-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/AnimationEffectTiming/easing-expected.txt.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/easing.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/AnimationEffectTiming/easing.html.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/endDelay-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/endDelay.html: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/fill-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/fill.html: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/getComputedTiming-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/getComputedTiming.html: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/idlharness-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/idlharness.html: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/iterationStart-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/iterationStart.html: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/iterations-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/AnimationEffectTiming/iterations.html: Added.
  • web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/constructor-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/constructor.html: Added.
  • web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/idlharness-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/AnimationPlaybackEvent/idlharness.html: Added.
  • web-platform-tests/web-animations/interfaces/Document/getAnimations-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Document/getAnimations-expected.txt.
  • web-platform-tests/web-animations/interfaces/Document/getAnimations.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/Document/getAnimations.html.
  • web-platform-tests/web-animations/interfaces/Document/timeline-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/Document/timeline.html: Added.
  • web-platform-tests/web-animations/interfaces/DocumentTimeline/constructor-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/DocumentTimeline/constructor-expected.txt.
  • web-platform-tests/web-animations/interfaces/DocumentTimeline/constructor.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/DocumentTimeline/constructor.html.
  • web-platform-tests/web-animations/interfaces/DocumentTimeline/idlharness-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/AnimationTimeline/idlharness-expected.txt.
  • web-platform-tests/web-animations/interfaces/DocumentTimeline/idlharness.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/AnimationTimeline/idlharness.html.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/composite-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/composite.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/KeyframeEffect/composite.html.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/constructor-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/constructor.html: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/copy-constructor-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/copy-constructor.html: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/idlharness-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/idlharness.html: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/iterationComposite-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/iterationComposite.html: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002-expected.txt.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-002.html.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes-expected.txt: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes.html: Added.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/target-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/interfaces/KeyframeEffect/setTarget-expected.txt.
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/target.html: Renamed from LayoutTests/http/wpt/web-animations/interfaces/KeyframeEffect/setTarget.html.
  • web-platform-tests/web-animations/resources/easing-tests.js: Renamed from LayoutTests/http/wpt/web-animations/resources/easing-tests.js.
  • web-platform-tests/web-animations/resources/effect-tests.js: Renamed from LayoutTests/http/wpt/web-animations/resources/effect-tests.js.
  • web-platform-tests/web-animations/resources/keyframe-tests.js: Added.
  • web-platform-tests/web-animations/resources/keyframe-utils.js: Added.
  • web-platform-tests/web-animations/resources/xhr-doc.py: Renamed from LayoutTests/http/wpt/web-animations/resources/xhr-doc.py.
  • web-platform-tests/web-animations/testcommon.js: Renamed from LayoutTests/http/wpt/web-animations/testcommon.js.
  • web-platform-tests/web-animations/timing-model/animation-effects/active-time-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animation-effects/active-time-expected.txt.
  • web-platform-tests/web-animations/timing-model/animation-effects/active-time.html: Added.
  • web-platform-tests/web-animations/timing-model/animation-effects/current-iteration-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animation-effects/current-iteration-expected.txt.
  • web-platform-tests/web-animations/timing-model/animation-effects/current-iteration.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animation-effects/current-iteration.html.
  • web-platform-tests/web-animations/timing-model/animation-effects/local-time-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animation-effects/local-time-expected.txt.
  • web-platform-tests/web-animations/timing-model/animation-effects/local-time.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animation-effects/local-time.html.
  • web-platform-tests/web-animations/timing-model/animation-effects/phases-and-states-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animation-effects/phases-and-states-expected.txt.
  • web-platform-tests/web-animations/timing-model/animation-effects/phases-and-states.html: Added.
  • web-platform-tests/web-animations/timing-model/animation-effects/simple-iteration-progress-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animation-effects/simple-iteration-progress-expected.txt.
  • web-platform-tests/web-animations/timing-model/animation-effects/simple-iteration-progress.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animation-effects/simple-iteration-progress.html.
  • web-platform-tests/web-animations/timing-model/animations/canceling-an-animation-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/canceling-an-animation-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/canceling-an-animation.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/canceling-an-animation.html.
  • web-platform-tests/web-animations/timing-model/animations/current-time-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/current-time-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/current-time.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/current-time.html.
  • web-platform-tests/web-animations/timing-model/animations/finishing-an-animation-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/finishing-an-animation-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/finishing-an-animation.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/finishing-an-animation.html.
  • web-platform-tests/web-animations/timing-model/animations/pausing-an-animation-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/pausing-an-animation-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/pausing-an-animation.html.
  • web-platform-tests/web-animations/timing-model/animations/play-states-expected.txt: Added.
  • web-platform-tests/web-animations/timing-model/animations/play-states.html: Added.
  • web-platform-tests/web-animations/timing-model/animations/playing-an-animation-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/playing-an-animation-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/playing-an-animation.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/playing-an-animation.html.
  • web-platform-tests/web-animations/timing-model/animations/reversing-an-animation-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/reversing-an-animation-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/reversing-an-animation.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/reversing-an-animation.html.
  • web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/set-the-animation-start-time-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/set-the-animation-start-time.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html.
  • web-platform-tests/web-animations/timing-model/animations/set-the-target-effect-of-an-animation-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/set-the-target-effect-of-an-animation-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/set-the-target-effect-of-an-animation.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/set-the-target-effect-of-an-animation.html.
  • web-platform-tests/web-animations/timing-model/animations/set-the-timeline-of-an-animation-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/set-the-timeline-of-an-animation-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/set-the-timeline-of-an-animation.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/set-the-timeline-of-an-animation.html.
  • web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/updating-the-finished-state-expected.txt.
  • web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/animations/updating-the-finished-state.html.
  • web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress-expected.txt: Renamed from LayoutTests/http/wpt/web-animations/timing-model/time-transformations/transformed-progress-expected.txt.
  • web-platform-tests/web-animations/timing-model/time-transformations/transformed-progress.html: Renamed from LayoutTests/http/wpt/web-animations/timing-model/time-transformations/transformed-progress.html.
  • web-platform-tests/web-animations/timing-model/timelines/document-timelines-expected.txt: Added.
  • web-platform-tests/web-animations/timing-model/timelines/document-timelines.html: Added.
  • web-platform-tests/web-animations/timing-model/timelines/timelines-expected.txt: Added.
  • web-platform-tests/web-animations/timing-model/timelines/timelines.html: Added.

LayoutTests:

  • TestExpectations:
  • http/wpt/web-animations/OWNERS: Removed.
  • http/wpt/web-animations/README.md: Removed.
  • http/wpt/web-animations/interfaces/Animatable/animate-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/Animatable/getAnimations-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/Animatable/getAnimations.html: Removed.
  • http/wpt/web-animations/interfaces/Animation/constructor.html: Removed.
  • http/wpt/web-animations/interfaces/Animation/finish-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/Animation/finished-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/Animation/playState-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/Animation/playState.html: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/delay-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/delay.html: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/direction-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/direction.html: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/duration-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/duration.html: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/endDelay-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/endDelay.html: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/fill-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/fill.html: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/getAnimations-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/getAnimations.html: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/getComputedStyle-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/getComputedStyle.html: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/iterationStart-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/iterationStart.html: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/iterations-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/AnimationEffectTiming/iterations.html: Removed.
  • http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html: Removed.
  • http/wpt/web-animations/interfaces/KeyframeEffect/composite-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/KeyframeEffect/constructor.html: Removed.
  • http/wpt/web-animations/interfaces/KeyframeEffect/copy-constructor-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/KeyframeEffect/copy-constructor.html: Removed.
  • http/wpt/web-animations/interfaces/KeyframeEffect/getComputedTiming-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/KeyframeEffect/getComputedTiming.html: Removed.
  • http/wpt/web-animations/interfaces/KeyframeEffect/iterationComposite-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/KeyframeEffect/setKeyframes-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/KeyframeEffect/setKeyframes.html: Removed.
  • http/wpt/web-animations/interfaces/KeyframeEffectReadOnly/copy-constructor-expected.txt: Removed.
  • http/wpt/web-animations/interfaces/KeyframeEffectReadOnly/copy-constructor.html: Removed.
  • http/wpt/web-animations/resources/keyframe-utils.js: Removed.
  • http/wpt/web-animations/timing-model/animation-effects/active-time.html: Removed.
  • http/wpt/web-animations/timing-model/animation-effects/phases-and-states.html: Removed.
1:06 AM Changeset in webkit [227597] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

undefined reference to 'JSC::B3::BasicBlock::fallThrough() const
https://bugs.webkit.org/show_bug.cgi?id=180637

Patch by Alejandro G. Castro <alex@igalia.com> on 2018-01-25
Reviewed by Michael Catanzaro.

We need to make sure the implementation of the inline functions is
compiled when we compile the code using the function, now that the
compilation is divided, or we could end up with undefined symbols
when the declaration is not inlined, at least with some compilers
and optimizations enabled -O2.

  • b3/B3SwitchValue.cpp: replace the include.
Note: See TracTimeline for information about the timeline view.