Timeline
Apr 2, 2019:
- 11:23 PM Changeset in webkit [243792] by
-
- 9 edits in tags/Safari-608.1.13.5
Cherry-pick r243711. rdar://problem/49245471
UIProcess crash when a prewarmed process is terminated
https://bugs.webkit.org/show_bug.cgi?id=196451
<rdar://problem/49245471>
Reviewed by Geoffrey Garen.
Source/WebKit:
Stop assuming that WebProcessProxy::m_websiteDataStore is non-null as this is no longer
true after r243384. For example, prewarmed WebContent processe do not get a data store
until they actually get used.
- UIProcess/API/Cocoa/WKProcessPool.mm: (-[WKProcessPool _prewarmedProcessIdentifier]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::networkProcessIdentifier): (WebKit::WebProcessPool::prewarmedProcessIdentifier):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didClose): (WebKit::WebProcessProxy::didFinishLaunching): (WebKit::WebProcessProxy::requestTermination): (WebKit::WebProcessProxy::isReleaseLoggingAllowed const):
- UIProcess/WebProcessProxy.h:
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm: (TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:23 PM Changeset in webkit [243791] by
-
- 2 edits in tags/Safari-608.1.13.5/Source/WebKit
Cherry-pick r243606. rdar://problem/49229632
[iPad] Tapping on a popup form control may not show a popover
https://bugs.webkit.org/show_bug.cgi?id=196322
<rdar://problem/49229632>
Reviewed by Wenson Hsieh.
Stop taking advantage of -[WKContentView inputView] being called when we invoke -reloadInputViews
to "lazily" allocate the input peripheral for the currently focused element. In theory, UIKit only
needs to call -inputView when it actually needs to display the input view (the keyboard). For
popup menu buttons, like <select>, no keyboard is needed. Instead we should create the peripheral
as part of the logic in the UI process to focus a new element before we call -reloadInputViews.
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView inputView]): Extract logic to allocate the peripheral from here and moved it to createInputPeripheralWithView(). (-[WKContentView accessoryTab:]): While I am here, add a FIXME comment to explain why we need to end the input sessions and nullify the input peripheral before we tell the web process to switch focus as opposed to letting this happen after the web process tells us it focused a new element. (createInputPeripheralWithView): Added. (-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]): Write in terms of createInputPeripheralWithView(). Create the input peripheral after becoming first responder because creating the peripheral has known side-effects: for popup buttons it tells the popup controller to present the popover. For key input to popovers to work from the get-go, the content view must be the first responder. See <https://bugs.webkit.org/show_bug.cgi?id=196272> for more details.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:23 PM Changeset in webkit [243790] by
-
- 2 edits in tags/Safari-608.1.13.5/Source/WebKit
Cherry-pick r243485. rdar://problem/49083324
Regression(r242369) Trying to change profile picture on linked in shows file picker, not the image picker
https://bugs.webkit.org/show_bug.cgi?id=196205
<rdar://problem/49083324>
Reviewed by Geoffrey Garen.
Update our FileUploadPanel code on iOS to properly deal with the MIME types containing
wild cards (e.g. "image/*") that are defined in the HTML specification:
Previously, we would fail to convert those to UTIs.
- UIProcess/ios/forms/WKFileUploadPanel.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:19 PM Changeset in webkit [243789] by
-
- 7 edits in tags/Safari-608.1.13.5/Source
Versioning.
- 11:16 PM Changeset in webkit [243788] by
-
- 1 copy in tags/Safari-608.1.13.5
New tag.
- 9:58 PM Changeset in webkit [243787] by
-
- 13 edits in trunk/Source/WebKit
[Cocoa] Add new API around WKWebpagePreferences in WKNavigationDelegate and WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=196284
<rdar://problem/47228232>
Reviewed by Tim Horton.
Tests for both of these APIs will be added in a subsequent patch.
- Shared/API/Cocoa/WebKit.h:
- UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::defaultWebsitePolicies const):
(API::PageConfiguration::setDefaultWebsitePolicies):
- UIProcess/API/APIPageConfiguration.h:
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
Add a new navigation delegate hook to allow clients to return a WKWebpagePreference targeting the given
navigation action.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
Add new API on WKWebViewConfiguration to specify a default WKWebpagePreference to use when navigating.
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration defaultWebpagePreferences]):
(-[WKWebViewConfiguration setDefaultWebpagePreferences:]):
- UIProcess/API/Cocoa/WKWebpagePreferences.h:
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
Invoke the new WKWebpagePreferences-based navigation delegate method.
- WebKit.xcodeproj/project.pbxproj:
- mac/postprocess-framework-headers.sh:
- mac/replace-webkit-additions-in-framework-headers.sh: Added.
Move logic in the "Postprocess Framework Headers" step responsible for stripping away included files from
WebKitAdditions out into a separate build phase, called "Replace WebKitAdditions in Framework Headers". This
ensures headers attempting to include from WebKitAdditions have these additional statements removed.
- 9:20 PM Changeset in webkit [243786] by
-
- 3 edits2 adds in trunk
REGRESSION (r238266): Exchange 2013 Outlook Web Access displays partially blank page when creating new e-mail
https://bugs.webkit.org/show_bug.cgi?id=196522
Source/WebCore:
rdar://problem/49472941
Reviewed by Zalan Bujtas.
In this content a layer is composited to clip descendants, and has negative z-order children,
so we compute that it "paints into ancestor", and has a foreground layer. This combination doesn't
make sense, and when the layer becomes scrollable, we end up with bad paint phases on layers, and
fail to paint the contents.
Fix by ensuring that a layer has its own backing store if it requires a foreground layer
by virtue of having negative z-order children.
Test: compositing/backing/foreground-layer-no-paints-into-ancestor.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
LayoutTests:
Reviewed by Zalan Bujtas.
- compositing/backing/foreground-layer-no-paints-into-ancestor-expected.html: Added.
- compositing/backing/foreground-layer-no-paints-into-ancestor.html: Added.
- 8:46 PM Changeset in webkit [243785] by
-
- 2 edits in trunk/Source/WebCore
Cursor count badge reverts to Zero during Drag & Drop of multiple items.
https://bugs.webkit.org/show_bug.cgi?id=196511
Reviewed by Daniel Bates.
- page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag): Don't set m_numberOfItemsToBeAccepted to
zero when dragging to a non-file input element.
- 8:24 PM Changeset in webkit [243784] by
-
- 5 edits in trunk/Source/WebKit
Eliminate plugin sandbox exceptions
https://bugs.webkit.org/show_bug.cgi?id=196510
Reviewed by Chris Dumez.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::initializeSandbox):
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::shouldAllowPluginToRunUnsandboxed): Deleted.
- UIProcess/Plugins/PluginInfoStore.h:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
(WebKit::PluginInfoStore::shouldAllowPluginToRunUnsandboxed): Deleted.
- 6:56 PM Changeset in webkit [243783] by
-
- 2 edits in trunk/Tools
[WK2] Add support for Window's beforeprint / afterprint events
https://bugs.webkit.org/show_bug.cgi?id=196478
<rdar://problem/49535124>
Unreviewed build fix for MSVC.
WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
- WebKitTestRunner/TestController.cpp:
(WTR::printFrame): Use int and float literals.
- 6:55 PM Changeset in webkit [243782] by
-
- 8 edits in trunk
HTML Parser: Remove conditional parsing of <noembed> content
https://bugs.webkit.org/show_bug.cgi?id=196514
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Resync WPT after https://github.com/web-platform-tests/wpt/pull/15471 to gain
test coverage. Both Gecko and Blink are passing the new check, only WebKit was
failing.
- web-platform-tests/domparsing/DOMParser-parseFromString-html-expected.txt:
- web-platform-tests/domparsing/DOMParser-parseFromString-html.html:
Source/WebCore:
Our HTML Parser has raw text handling for <noembed> content only if plugins are runnable.
However, the HTML specification doesn't ask such behavior [1], and it doesn't match to
our HTML serializer. We should always handle it as raw text.
Blink already made this change in https://chromium-review.googlesource.com/c/1477556.
[1] https://html.spec.whatwg.org/multipage/parsing.html#parsing-html-fragments:noembed
No new tests, updated existing test.
- html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):
- html/parser/HTMLParserOptions.h:
- html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::updateStateFor):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
- 5:44 PM Changeset in webkit [243781] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Elements: DOM breakpoint icon should stroke when hovering selection area
https://bugs.webkit.org/show_bug.cgi?id=196516
<rdar://problem/49540494>
Reviewed by Timothy Hatcher.
- UserInterface/Views/DOMTreeContentView.css:
(body:not(.window-inactive) .content-view.dom-tree .tree-outline.dom:focus li:matches(.selected, .hovered) .status-image.breakpoint,): Added.
(body:not(.window-inactive) .content-view.dom-tree .tree-outline.dom:focus li:matches(.selected, .hovered) .status-image.breakpoint.subtree): Added.
(body:not(.window-inactive) .content-view.dom-tree .tree-outline.dom:focus li:matches(.selected, :hover) .status-image.breakpoint): Deleted.
(body:not(.window-inactive) .content-view.dom-tree .tree-outline.dom:focus li:matches(.selected, :hover) .status-image.breakpoint.subtree): Deleted.
- 5:26 PM Changeset in webkit [243780] by
-
- 1 edit2 adds in trunk/LayoutTests
SVG Animation (SMIL) on <text> or <tspan> doesn't work on second run
https://bugs.webkit.org/show_bug.cgi?id=150388
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-04-02
Reviewed by Simon Fraser.
The bug is fixed by removing the SVG tear off objects. See
https://bugs.webkit.org/show_bug.cgi?id=191237.
We need to add a layout test to ensure that no code change will break
this scenario in the future.
- svg/animations/smil-multiple-animate-list-expected.svg: Added.
- svg/animations/smil-multiple-animate-list.svg: Added.
- 5:04 PM Changeset in webkit [243779] by
-
- 2 edits in trunk/LayoutTests
imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=196517
Unreviewed test gardening.
- platform/mac/TestExpectations: Skipping test for flaky crashing
- 5:04 PM Changeset in webkit [243778] by
-
- 3 edits in branches/safari-607-branch/LayoutTests
Cherry-pick r240492. rdar://problem/49539128
webkitpy: Implement device type specific expected results (Gardening)
https://bugs.webkit.org/show_bug.cgi?id=192162
<rdar://problem/46345449>
Unreviewed test gardening.
- platform/ios/TestExpectations: Remove non-existant directories.
- platform/mac/TestExpectations: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243777] by
-
- 2 edits in branches/safari-607-branch/Tools
Cherry-pick r240339. rdar://problem/49539128
webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
https://bugs.webkit.org/show_bug.cgi?id=193722
<rdar://problem/47481475>
Reviewed by Lucas Forschler.
iPhone and iPad ports should both use the iOS config.
- Scripts/webkitpy/port/ios_simulator.py: (IPhoneSimulatorPort.init): (IPadSimulatorPort.init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243776] by
-
- 4 edits in branches/safari-607-branch/Tools
Cherry-pick r240163. rdar://problem/49539128
webkitpy: Add iPhone and iPad ports
https://bugs.webkit.org/show_bug.cgi?id=193537
<rdar://problem/47353390>
Reviewed by Lucas Forschler.
Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
ports. Note that this separation is optional, the --ios-simulator command remains.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_device_type_test_division): Drive-by fix. (RunTest.test_device_type_specific_listing): Ditto. (RunTest.test_ipad_test_division): (RunTest): (RunTest.test_ipad_listing):
- Scripts/webkitpy/port/factory.py: (platform_options): Add --iphone-simulator and --ipad-simulator flags. (PortFactory):
- Scripts/webkitpy/port/ios_simulator.py: (IPhoneSimulatorPort): (IPadSimulatorPort):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243775] by
-
- 1 edit2 deletes in branches/safari-607-branch/LayoutTests
Cherry-pick r240157. rdar://problem/49539128
webkitpy: Implement device type specific expected results (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=192162
<rdar://problem/46345449>
Unreviewed test gardening.
- tiled-drawing/ios/iphone7: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243774] by
-
- 2 edits in branches/safari-607-branch/Tools
Cherry-pick r240153. rdar://problem/49539128
webkitpy: Implement device type specific expected results (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=192162
<rdar://problem/46345449>
Unreviewed infrastructure fix.
- Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.run): Don't boot a device if no tests are available to run on it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243773] by
-
- 2 edits in branches/safari-607-branch/Tools
Cherry-pick r240151. rdar://problem/49539128
webkitpy: Implement device type specific expected results (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=192162
<rdar://problem/46345449>
Unreviewed infrastructure fix.
- Scripts/webkitpy/api_tests/manager.py: (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243772] by
-
- 24 edits43 moves19 adds in branches/safari-607-branch
Cherry-pick r240150. rdar://problem/49539128
webkitpy: Implement device type specific expected results (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=192162
<rdar://problem/46345449>
Rubber-stamped by Aakash Jain.
Tools:
This change uses device_type to select a different set of TestExpectation files based on the type of device running
tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
- Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: (LayoutTestFinder.find_tests): Pass device_type through.
- Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
- Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.init): Make _expectations an OrderedDict indexed by device_type, add current_device_type. (Manager._collect_tests): Pass device type to test finder. (Manager._needs_web_platform_test): (Manager._prepare_lists): Index _expectations by device type. (Manager._test_input_for_file): (Manager._test_is_slow): Ditto. (Manager._test_should_dump_jsconsolelog_in_stderr): (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto. (Manager._get_test_inputs): (Manager._update_worker_count): (Manager._set_up_run): Use current_device_type instead of passing device_type in. (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event that a test can be run on multiple device types, the first device in the device type list which is eligible will be the one which runs the test. (Manager._run_test_subset): (Manager._run_tests): Index _expectations by current_device_type. (Manager._print_expectation_line_for_test): Ditto. (Manager._print_expectations_for_subset): Ditto. (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths. Unlike run, this function will behave the same regardless of what devices are available. (Manager._custom_device_for_test): Deleted.
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: (ManagerTest.test_uses_custom_device): Deleted. (ManagerTest.test_uses_custom_device.get_manager): Deleted.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: (JSONLayoutResultsGenerator.init): Pass expectations as a dictionary indexed by device type. (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration all of the expectations.
- Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: (FakePort.skipped_layout_tests): Allow device_type to be passed in.
- Scripts/webkitpy/layout_tests/models/test_expectations.py: (TestExpectations.init): Allow device_type to be passed through. (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
- Scripts/webkitpy/layout_tests/models/test_run_results.py: (summarize_results):
- Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation a test ran with, one must check all expectations to find the first non-skip expectation.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.test_device_type_test_division): (RunTest): (RunTest.test_device_type_specific_listing):
- Scripts/webkitpy/port/base.py: (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES. (Port.supported_device_types): The result of this function will change based on what devices are available.
- Scripts/webkitpy/port/device_port.py: (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE. (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object can be used. (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are any, or the DEFAULT_DEVICE_TYPES of the port.
- Scripts/webkitpy/port/ios.py: (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
- Scripts/webkitpy/port/ios_simulator.py: (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
- Scripts/webkitpy/port/watch.py: (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
- Scripts/webkitpy/port/watch_simulator.py: (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
- Scripts/webkitpy/xcode/device_type.py: (DeviceType): (DeviceType.hash): Allow DeviceType to be used as a dictionary index.
LayoutTests:
Move iPad and iPhone 7 tests to their respective platform specific directories.
- TestExpectations:
- fast/events/touch/ios/iphone7: Removed.
- fast/forms/ios/ipad: Removed.
- fast/text-autosizing/ios/ipad: Removed.
- fast/viewport/ios/ipad: Removed.
- media/controls/ipad: Removed.
- media/modern-media-controls/media-documents/ipad: Removed.
- media/modern-media-controls/pip-support/ipad: Removed.
- platform/ios-wk1/TestExpectations:
- platform/ios/TestExpectations:
- platform/ipad: Added.
- platform/ipad/fast: Added.
- platform/ipad/fast/forms: Added.
- platform/ipad/fast/forms/choose-select-option-expected.txt: Added.
- platform/ipad/fast/forms/choose-select-option.html: Added.
- platform/ipad/fast/forms/focus-input-via-button-expected.txt: Added.
- platform/ipad/fast/forms/focus-input-via-button.html: Added.
- platform/ipad/fast/forms/multiple-select-updates-renderer-expected.txt: Added.
- platform/ipad/fast/forms/multiple-select-updates-renderer.html: Added.
- platform/ipad/fast/forms/select-form-run-twice-expected.txt: Added.
- platform/ipad/fast/forms/select-form-run-twice.html: Added.
- platform/ipad/fast/forms/select-with-title-expected.txt: Added.
- platform/ipad/fast/forms/select-with-title.html: Added.
- platform/ipad/fast/forms/unfocus-inside-fixed-hittest-expected.txt: Added.
- platform/ipad/fast/forms/unfocus-inside-fixed-hittest.html: Added.
- platform/ipad/fast/text-autosizing: Added.
- platform/ipad/fast/text-autosizing/programmatic-text-size-adjust-expected.txt: Added.
- platform/ipad/fast/text-autosizing/programmatic-text-size-adjust.html: Added.
- platform/ipad/fast/text-autosizing/text-size-adjust-inline-style-expected.html: Added.
- platform/ipad/fast/text-autosizing/text-size-adjust-inline-style.html: Added.
- platform/ipad/fast/viewport: Added.
- platform/ipad/fast/viewport/empty-meta-expected.txt: Added.
- platform/ipad/fast/viewport/empty-meta.html: Added.
- platform/ipad/fast/viewport/meta-viewport-ignored-expected.txt: Added.
- platform/ipad/fast/viewport/meta-viewport-ignored.html: Added.
- platform/ipad/fast/viewport/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport-expected.txt: Added.
- platform/ipad/fast/viewport/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport.html: Added.
- platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport-expected.txt: Added.
- platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html: Added.
- platform/ipad/fast/viewport/width-is-device-width-expected.txt: Added.
- platform/ipad/fast/viewport/width-is-device-width.html: Added.
- platform/ipad/media: Added.
- platform/ipad/media/controls: Added.
- platform/ipad/media/controls/close-page-with-picture-in-picture-video-assertion-failure-expected.txt: Added.
- platform/ipad/media/controls/close-page-with-picture-in-picture-video-assertion-failure.html: Added.
- platform/ipad/media/controls/resources: Added.
- platform/ipad/media/controls/resources/picture-in-picture.html: Added.
- platform/ipad/media/modern-media-controls: Added.
- platform/ipad/media/modern-media-controls/media-documents: Added.
- platform/ipad/media/modern-media-controls/media-documents/media-document-audio-ios-sizing-expected.txt: Added.
- platform/ipad/media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html: Added.
- platform/ipad/media/modern-media-controls/media-documents/media-document-video-ios-sizing-expected.txt: Added.
- platform/ipad/media/modern-media-controls/media-documents/media-document-video-ios-sizing.html: Added.
- platform/ipad/media/modern-media-controls/pip-support: Added.
- platform/ipad/media/modern-media-controls/pip-support/pip-support-enabled-expected.txt: Added.
- platform/ipad/media/modern-media-controls/pip-support/pip-support-enabled.html: Added.
- platform/ipad/media/modern-media-controls/pip-support/pip-support-tap-expected.txt: Added.
- platform/ipad/media/modern-media-controls/pip-support/pip-support-tap.html: Added.
- platform/iphone-7: Added.
- platform/iphone-7/fast: Added.
- platform/iphone-7/fast/events: Added.
- platform/iphone-7/fast/events/touch: Added.
- platform/iphone-7/fast/events/touch/force-press-event-expected.txt: Added.
- platform/iphone-7/fast/events/touch/force-press-event.html: Added.
- platform/iphone-7/fast/events/touch/force-press-on-link-expected.txt: Added.
- platform/iphone-7/fast/events/touch/force-press-on-link.html: Added.
- platform/iphone-7/fast/events/touch/prevent-default-touchmove-prevents-scrolling-expected.txt: Added.
- platform/iphone-7/fast/events/touch/prevent-default-touchmove-prevents-scrolling.html: Added.
- platform/iphone-7/tiled-drawing: Added.
- platform/iphone-7/tiled-drawing/compositing-layers-deep-color-expected.txt: Added.
- platform/iphone-7/tiled-drawing/compositing-layers-deep-color.html: Added.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- tiled-drawing/ios: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243771] by
-
- 19 edits in branches/safari-607-branch/Tools
Cherry-pick r239989. rdar://problem/49539128
webkitpy: Implement device type specific expected results (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=192162
Reviewed by Lucas Forschler.
Device type specific expected results covers two related ideas. The first (covered by this change)
is where to search for -expected.* files. The second is which tests to run based on the
TestExpectations.txt file.
After this change, the baseline search path will be determined by the type of device running a
test. Device type will be passed into any function which picks a file based on the baseline search
path.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
- Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.run): Print baseline search path for each round of devices.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: (SingleTestRunner.init): Pass device_type into expected_*(...). (SingleTestRunner._expected_driver_output): Ditto. (SingleTestRunner._driver_input): Ditto.
- Scripts/webkitpy/layout_tests/views/printing.py: (Printer.print_config): Move printing of baseline search path to a separate function. (Printer.print_baseline_search_path): Moved from Printer.print_config.
- Scripts/webkitpy/layout_tests/views/printing_unittest.py: (Testprinter.test_print_config): (Testprinter.test_print_baseline_search_path):
- Scripts/webkitpy/port/base.py: (Port.baseline_search_path): Pass device_type through. (Port._expected_baselines_for_suffixes): Ditto. (Port.expected_baselines): Ditto. (Port.expected_filename): Ditto. (Port.expected_checksum): Ditto. (Port.expected_image): Ditto. (Port.expected_audio): Ditto. (Port.expected_text): Ditto. (Port.reference_files): Ditto. (Port.tests): Ditto. (Port._expanded_paths): Ditto. (Port.skipped_layout_tests): Ditto. (Port.expectations_dict): Ditto. (Port._port_specific_expectations_files): Ditto. (Port.expectations_files): Ditto. (Port.test_search_path): Ditto. (Port._tests_for_other_platforms): Ditto.
- Scripts/webkitpy/port/base_unittest.py: (PortTest.test_additional_platform_directory): Accept, but do not use, device_type. (PortTest.test_nonexistant_expectations): Ditto. (test_ref_tests_platform_directory): Ditto.
- Scripts/webkitpy/port/darwin.py: (DarwinPort._port_specific_expectations_files): Accept device_type.
- Scripts/webkitpy/port/driver.py: (DriverProxy): (DriverProxy.host): Expose _target_host for device_type information.
- Scripts/webkitpy/port/gtk.py: (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
- Scripts/webkitpy/port/ios.py: (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept kwargs.
- Scripts/webkitpy/port/mac.py: (MacPort. default_baseline_search_path): Ditto.
- Scripts/webkitpy/port/port_testcase.py: (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
- Scripts/webkitpy/port/test.py:
- Scripts/webkitpy/port/watch.py: (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept kwargs.
- Scripts/webkitpy/port/win.py: (WinPort.test_search_path): Accept, but do not use, device_type.
- Scripts/webkitpy/port/wpe.py: (WPEPort._port_specific_expectations_files): Ditto.
- Scripts/webkitpy/tool/servers/rebaselineserver.py: (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:04 PM Changeset in webkit [243770] by
-
- 6 edits in branches/safari-607-branch/Tools
Cherry-pick r239945. rdar://problem/49539128
webkitpy: Expose device_type from host-like objects
https://bugs.webkit.org/show_bug.cgi?id=193406
<rdar://problem/47262305>
Reviewed by Lucas Forschler.
Devices should expose device_type. As a result, all host objects should
provide a device_type property, even if they do not yet define a device_type.
- Scripts/webkitpy/common/system/systemhost.py: (SystemHost): (SystemHost.device_type):
- Scripts/webkitpy/common/system/systemhost_mock.py: (MockSystemHost): (MockSystemHost.device_type):
- Scripts/webkitpy/port/device.py: (Device): (Device.device_type):
- Scripts/webkitpy/xcode/simulated_device.py: (SimulatedDeviceManager._find_exisiting_device_for_request): (SimulatedDeviceManager._disambiguate_device_type): (SimulatedDeviceManager._does_fulfill_request): (SimulatedDeviceManager.device_count_for_type): (SimulatedDeviceManager.initialize_devices):
- Scripts/webkitpy/xcode/simulated_device_unittest.py: (test_available_devices): (test_swapping_devices):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:03 PM Changeset in webkit [243769] by
-
- 10 edits in branches/safari-607-branch/Tools
Cherry-pick r239875. rdar://problem/49539128
webkitpy: Incorporate device type into baseline search path
https://bugs.webkit.org/show_bug.cgi?id=193356
<rdar://problem/47215515>
Reviewed by Lucas Forschler.
We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
- Scripts/webkitpy/port/base.py: (Port.default_baseline_search_path): Allow device type to be passed in.
- Scripts/webkitpy/port/gtk.py: (GtkPort.default_baseline_search_path): Ignore device type.
- Scripts/webkitpy/port/ios.py: (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path. (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
- Scripts/webkitpy/port/ios_device_unittest.py: (IOSDeviceTest):
- Scripts/webkitpy/port/ios_simulator_unittest.py: (IOSSimulatorTest):
- Scripts/webkitpy/port/mac.py: (MacPort.default_baseline_search_path): Ignore device type.
- Scripts/webkitpy/port/watch.py: (WatchPort.default_baseline_search_path): Ditto.
- Scripts/webkitpy/port/win.py: (WinPort.default_baseline_search_path): Ditto. (WinCairoPort.default_baseline_search_path): Ditto.
- Scripts/webkitpy/port/wpe.py: (WPEPort.default_baseline_search_path): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:33 PM Changeset in webkit [243768] by
-
- 2 edits in trunk/LayoutTests
[Mojave] Layout test fast/text/complex-initial-advance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=196512
Unreviewed test gardening.
- platform/mac/TestExpectations: Mark test as failing.
- 4:11 PM Changeset in webkit [243767] by
-
- 8 edits in trunk
Fix assertion in http/tests/adClickAttribution/store-ad-click-attribution.html
https://bugs.webkit.org/show_bug.cgi?id=196503
Reviewed by Chris Dumez.
Source/WebKit:
In WebPageProxy::didDestroyNavigation we try to ignore a request to destroy a navigation from a page being navigated from
during a cross-site navigation, but if the old web process sends the message after WebPageProxy::commitProvisionalPage
has been called, we can still destroy a navigation when we are continuing a navigation in another process. To prevent this,
have the process not send the message when it knows the navigation is continuing in another process.
Also make the use of unchecked navigation pointers more robust by checking it for nullity.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::didReceivePolicyDecision):
(WebKit::WebFrame::documentLoaderDetached):
- WebProcess/WebPage/WebFrame.h:
LayoutTests:
- http/tests/adClickAttribution/store-ad-click-attribution-expected.txt:
- http/tests/adClickAttribution/store-ad-click-attribution.html:
- platform/wk2/TestExpectations:
- 4:07 PM Changeset in webkit [243766] by
-
- 2 edits in trunk/Tools
[ews-build] Reassign bots to queues
- BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
- 4:00 PM Changeset in webkit [243765] by
-
- 14 edits in trunk
XMLHttpRequestUpload's loadstart event not correct initialized
https://bugs.webkit.org/show_bug.cgi?id=196174
<rdar://problem/49191412>
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/xhr/event-error-order.sub.html:
Update test after https://github.com/web-platform-tests/wpt/pull/13365
- web-platform-tests/xhr/abort-during-upload-expected.txt:
- web-platform-tests/xhr/event-error-order.sub-expected.txt:
- web-platform-tests/xhr/event-loadstart-upload-expected.txt:
- web-platform-tests/xhr/event-timeout-order-expected.txt:
- web-platform-tests/xhr/send-response-event-order-expected.txt:
Rebaseline several WPT tests that are now passing.
Source/WebCore:
Align progress event firing with the XHR specification.
No new tests, rebaselined existing tests.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
As per [1], the loadstart event fired on the XMLHttpRequestUpload object should use
loaded=0 and total=req’s body’s total bytes.
[1] https://xhr.spec.whatwg.org/#the-send()-method (step 11.2.)
(WebCore::XMLHttpRequest::didSendData):
As per [2], the progress / load / loadend should use loaded=transmitted and total=length.
[2] https://xhr.spec.whatwg.org/#ref-for-process-request-end-of-body (steps 5, 6 and 7)
(WebCore::XMLHttpRequest::didReceiveData):
As per [3], we should fire the readystatechange event *before* the progress event.
This is covered by web-platform-tests/xhr/send-response-event-order.htm which was failing
differently after the other changes in this patch.
[3] https://xhr.spec.whatwg.org/#ref-for-process-response (steps 9.4 and 9.5)
(WebCore::XMLHttpRequest::dispatchErrorEvents):
As per [4], in case of an error, we should fire the provided 'event' and 'loadend' with
loaded=0 and total=0.
[4] https://xhr.spec.whatwg.org/#request-error-steps (steps 7 and 8)
- xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
- xml/XMLHttpRequestUpload.h:
Simplify XMLHttpRequestUpload. It no longer needs to store loaded / total as data
members now that they are always passed by the call site. lengthComputable is set
to !!total as [5] says to set it to true if length/total is not 0.
[5] https://xhr.spec.whatwg.org/#concept-event-fire-progress
- 3:39 PM Changeset in webkit [243764] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Fix iokit-get-properties sandbox violation in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=196500
<rdar://problem/49497788>
Reviewed by Brent Fulgham.
Attempting to get the iokit properties 'product-description', 'artwork-display-gamut' and
'artwork-scale-factor' is causing sandbox violations.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 3:19 PM Changeset in webkit [243763] by
-
- 24 edits1 copy3 adds in trunk
Web Inspector: Canvas: add support for showing WebGPU contexts
https://bugs.webkit.org/show_bug.cgi?id=196413
<rdar://problem/49438898>
Reviewed by Timothy Hatcher.
Source/WebCore:
Tests: inspector/canvas/create-context-webgpu.html
inspector/canvas/resolveCanvasContext-webgpu.html
- Modules/webgpu/GPUCanvasContext.idl:
- Modules/webgpu/GPUCanvasContext.h:
(WebCore::GPUCanvasContext::canvas const): Added.
- Modules/webgpu/GPUCanvasContext.cpp:
(WebCore::GPUCanvasContext::create):
- testing/InternalSettings.idl:
- testing/InternalSettings.h:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setWebGPUEnabled): Added.
LayoutTests:
- inspector/canvas/create-context-webgpu.html: Added.
- inspector/canvas/create-context-webgpu-expected.txt: Added.
- inspector/canvas/resolveCanvasContext-webgpu.html: Added.
- inspector/canvas/resolveCanvasContext-webgpu-expected.txt: Added.
- inspector/canvas/resources/create-context-utilities.js:
(createDetachedCanvas):
(createCSSCanvas):
(destroyCanvases):
(TestPage.registerInitializer.InspectorTest.CreateContextUtilities.initializeTestSuite): Added.
(TestPage.registerInitializer.InspectorTest.CreateContextUtilities.addSimpleTestCase): Added.
(TestPage.registerInitializer.InspectorTest.CreateContextUtilities.addCSSCanvasTestCase): Added.
(TestPage.registerInitializer.window.initializeTestSuite): Deleted.
(TestPage.registerInitializer.window.addSimpleTestCase): Deleted.
(TestPage.registerInitializer.window.addCSSCanvasTestCase): Deleted.
- inspector/canvas/create-context-2d.html:
- inspector/canvas/create-context-2d-expected.txt:
- inspector/canvas/create-context-bitmaprenderer.html:
- inspector/canvas/create-context-bitmaprenderer-expected.txt:
- inspector/canvas/create-context-webgl.html:
- inspector/canvas/create-context-webgl-expected.txt:
- inspector/canvas/create-context-webgl2.html:
- inspector/canvas/create-context-webgl2-expected.txt:
- platform/gtk/TestExpectations:
- platform/ios/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wpe/TestExpectations:
- 2:43 PM Changeset in webkit [243762] by
-
- 22 edits2 adds in trunk
[WK2] Add support for Window's beforeprint / afterprint events
https://bugs.webkit.org/show_bug.cgi?id=196478
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/html/browsers/the-window-object/security-window/window-security.https-expected.txt:
- web-platform-tests/html/browsers/the-window-object/security-window/window-security.sub-expected.txt:
- web-platform-tests/html/browsers/the-window-object/window-properties.https-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/webappapis/scripting/events/body-exposed-window-event-handlers-expected.txt:
- web-platform-tests/html/webappapis/scripting/events/event-handler-attributes-body-window-expected.txt:
Source/WebCore:
Add support for Window's beforeprint / afterprint events as per:
Blink and Gecko already support this.
Test: printing/printing-events.html
- dom/EventNames.h:
- html/HTMLAttributeNames.in:
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::createWindowEventHandlerNameMap):
- page/Page.cpp:
(WebCore::dispatchPrintEvent):
(WebCore::Page::dispatchBeforePrintEvent):
(WebCore::Page::dispatchAfterPrintEvent):
- page/Page.h:
- page/WindowEventHandlers.idl:
Source/WebKit:
Add support for Window's beforeprint / afterprint events as per:
Blink and Gecko already support this.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::beginPrinting):
(WebKit::WebPage::endPrinting):
Tools:
Add minimal implementation for printFrame in WebKitTestRunner.
- WebKitTestRunner/TestController.cpp:
(WTR::printFrame):
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
LayoutTests:
Add layout test coverage.
- TestExpectations:
- platform/wk2/TestExpectations:
- printing/printing-events-expected.txt: Added.
- printing/printing-events.html: Added.
- 2:15 PM Changeset in webkit [243761] by
-
- 2 edits in trunk/Tools
[ews-app] Status bubble hover over message should clearly indicate that build is in-progress
https://bugs.webkit.org/show_bug.cgi?id=196491
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
- 2:11 PM Changeset in webkit [243760] by
-
- 3 edits2 adds in trunk
[ContentChangeObserver] Hover menus do not function on fidelity.com
https://bugs.webkit.org/show_bug.cgi?id=196507
<rdar://problem/49496520>
Reviewed by Simon Fraser.
Source/WebCore:
fidelity.com has 400ms hover intent timer to bring up the main menus.
Test: fast/events/touch/ios/content-observation/400ms-hover-intent.html
- page/ios/ContentChangeObserver.cpp:
LayoutTests:
- fast/events/touch/ios/content-observation/400ms-hover-intent-expected.txt: Added.
- fast/events/touch/ios/content-observation/400ms-hover-intent.html: Added.
- 2:09 PM Changeset in webkit [243759] by
-
- 4 edits in trunk/Tools
[ews-build] Configure buildbot try credentials in environment variables
https://bugs.webkit.org/show_bug.cgi?id=196501
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
- BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
- BuildSlaveSupport/ews-app/ews/config.py: Ditto.
- 2:06 PM Changeset in webkit [243758] by
-
- 2 edits in trunk/Source/WebCore
NSAttributedString crashes when encoding text attachment cell for missing image.
https://bugs.webkit.org/show_bug.cgi?id=196504
rdar://problem/49161281
Reviewed by Tim Horton.
Clean up and fix a couple of errors and crashes in the missing image path of our
attributed string converter.
Fixes include:
- Removed manual call to release on a RetainPtr, leading to autorelease pool crash.
- No longer try to load an image that is missing on disk and has long been renamed.
- No longer use a NSTextAttachmentCell in the Mac code path which can't be encoded for sending to the UIProcess, so it was pretty useless in the web content process.
- Stopped using NSFileWrapper for the missing image so the attachment can contain the retina versions of the missing image.
- Simplified bundle finding code, since WebCore is assumed to be loaded.
- Fix leak of attachment by adding missing adoptNS().
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_addAttachmentForElement): Unify and simplify missing image path.
(_NSFirstPathForDirectoriesInDomains): Deleted.
(_NSSystemLibraryPath): Deleted.
(_webKitBundle): Deleted.
- 1:48 PM Changeset in webkit [243757] by
-
- 4 edits in trunk
[Fetch API] Allow used body replacement in Request constructor
https://bugs.webkit.org/show_bug.cgi?id=183703
<rdar://problem/49425609>
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Rebaseline WPT test now that one more check is passing.
- web-platform-tests/fetch/api/request/request-disturbed-expected.txt:
Source/WebCore:
Allow used body replacement in Request constructor as per:
No new tests, rebaseline existing test.
- Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::initializeWith):
- 1:30 PM Changeset in webkit [243756] by
-
- 15 edits in trunk
Unreviewed, rolling out r243551.
Seems to have broken file uploads to SoundCloud
Reverted changeset:
"XMLHttpRequestUpload's loadstart event not correct
initialized"
https://bugs.webkit.org/show_bug.cgi?id=196174
https://trac.webkit.org/changeset/243551
- 12:59 PM Changeset in webkit [243755] by
-
- 20 edits4 copies4 adds in trunk
Source/WebCore:
[Web GPU] Implement blend states and color write mask for GPUColorStateDescriptor
https://bugs.webkit.org/show_bug.cgi?id=196474
Reviewed by Myles C. Maxfield.
Blend states and color write masks must now be specified on GPUColorStateDescriptor instead of
relying on underlying MTLRenderPipelineColorAttachmentDescriptor defaults.
Test: webgpu/blend-triangle-strip.html, webgpu/color-write-mask-triangle-strip.html
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webgpu/GPUBlendDescriptor.idl:
- Modules/webgpu/GPUColorStateDescriptor.idl:
- Modules/webgpu/GPUColorWriteBits.idl:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
- platform/graphics/gpu/GPUBlendDescriptor.h:
- platform/graphics/gpu/GPUColorStateDescriptor.h:
- platform/graphics/gpu/GPUColorWriteBits.h:
- platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
(WebCore::mtlColorWriteMaskForGPUColorWriteFlags):
(WebCore::mtlBlendOperationForGPUBlendOperation):
(WebCore::mtlBlendFactorForGPUBlendFactor):
(WebCore::setColorStatesForColorAttachmentArray):
(WebCore::tryCreateMtlRenderPipelineState):
(WebCore::trySetColorStatesForColorAttachmentArray): Deleted.
LayoutTests:
[Web GPU] Implement blend states and color write mask for GPUColorStateDescriptor
https://bugs.webkit.org/show_bug.cgi?id=196474
Reviewed by Myles C. Maxfield.
Add blend-triangle-strip to test color blending and color-write-mask-triangle-strip.html to test color write mask.
Update other tests to specify blend states when creating a GPURenderPipeline.
- webgpu/blend-triangle-strip-expected.html: Added.
- webgpu/blend-triangle-strip.html: Added.
- webgpu/buffer-command-buffer-races.html:
- webgpu/buffer-resource-triangles.html:
- webgpu/color-write-mask-triangle-strip-expected.html: Added.
- webgpu/color-write-mask-triangle-strip.html: Added.
- webgpu/depth-enabled-triangle-strip.html:
- webgpu/js/webgpu-functions.js:
- webgpu/render-pipelines.html:
- webgpu/texture-triangle-strip.html:
- webgpu/vertex-buffer-triangle-strip.html:
- webgpu/whlsl.html:
- 12:56 PM Changeset in webkit [243754] by
-
- 2 edits in trunk/Source/JavaScriptCore
Crash in Options::setOptions() using --configFile option and libgmalloc
https://bugs.webkit.org/show_bug.cgi?id=196506
Reviewed by Keith Miller.
Changed to call CString::data() while making the call to Options::setOptions(). This keeps
the implicit CString temporary alive until after setOptions() returns.
- runtime/ConfigFile.cpp:
(JSC::ConfigFile::parse):
- 12:46 PM Changeset in webkit [243753] by
-
- 4 edits in trunk
REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
https://bugs.webkit.org/show_bug.cgi?id=196496
<rdar://problem/49521634>
Reviewed by Chris Dumez.
Source/WebKit:
r243726 made an incorrect assumption that all callers of -decidePolicyForNavigationAction:decisionHandler: and
-decidePolicyForNavigationAction:userInfo:decisionHandler: must be instances of _WKWebsitePolicies, as opposed
to the new WKWebpagePreferences. However, it's possible for clients (in this case, Safari) to already generate
and pass in an instance of WKWebpagePreferences by bridging the C API opaque ref (WKWebsitePoliciesRef) into the
Objective-C object (which is now WKWebpagePreferences, after my change).
To maintain binary compatibility of trunk WebKit against prior versions of Safari, we need to handle both
WKWebpagePreferences and the soon-to-be-deprecated _WKWebsitePolicies in the navigation action policy decision
handler.
Tests: WebKit.WebsitePoliciesWithBridgingCast
WebKit.WebsitePoliciesWithUnexpectedType
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
Tools:
Add new API tests (see WebKit ChangeLog for more detail).
- TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(TEST):
- 12:43 PM Changeset in webkit [243752] by
-
- 5 edits6 adds in trunk
[ContentChangeObserver] Ignore reconstructed renderers when checking for visibility change
https://bugs.webkit.org/show_bug.cgi?id=196483
<rdar://problem/49288174>
Reviewed by Simon Fraser.
Source/WebCore:
This patch fixes the cases when the content gets reconstructed in a way that existing and visible elements gain
new renderers within one style recalc. We failed to recognize such cases and ended up detecting the newly constructed renderers
as "visible change" thereby triggering hover.
Test: fast/events/touch/ios/content-observation/visible-content-gains-new-renderer.html
- page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::renderTreeUpdateDidStart):
(WebCore::ContentChangeObserver::renderTreeUpdateDidFinish):
(WebCore::ContentChangeObserver::reset):
(WebCore::ContentChangeObserver::willDestroyRenderer):
(WebCore::ContentChangeObserver::StyleChangeScope::StyleChangeScope):
(WebCore::ContentChangeObserver::RenderTreeUpdateScope::RenderTreeUpdateScope):
(WebCore::ContentChangeObserver::RenderTreeUpdateScope::~RenderTreeUpdateScope):
- page/ios/ContentChangeObserver.h:
(WebCore::ContentChangeObserver::visibleRendererWasDestroyed const):
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::tearDownRenderers):
LayoutTests:
- fast/events/touch/ios/content-observation/visible-content-gains-new-renderer-expected.txt: Added.
- fast/events/touch/ios/content-observation/visible-content-gains-new-renderer.html: Added.
- 12:41 PM Changeset in webkit [243751] by
-
- 2 edits in trunk/Tools
Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
<https://webkit.org/b/196499>
Reviewed by Alexey Proskuryakov.
- asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
ENABLE_ADDRESS_SANITIZER.
- 12:08 PM Changeset in webkit [243750] by
-
- 2 edits in trunk/LayoutTests
accessibility/mac/press-not-work-for-disabled-menu-list.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196505
Unreviewed test gardening.
- platform/mac/TestExpectations: Updating test expectations for flaky failure
- 11:36 AM Changeset in webkit [243749] by
-
- 2 edits in trunk/LayoutTests
media/video-background-tab-playback.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196502
Unreviewed test gardening
- platform/mac-wk1/TestExpectations: Updating test expectations for flaky failure
- 10:51 AM Changeset in webkit [243748] by
-
- 11 edits in branches/safari-607-branch/Tools
Cherry-pick r243732. rdar://problem/49356714
run-api-tests: Upload test results
https://bugs.webkit.org/show_bug.cgi?id=196323
<rdar://problem/49356714>
Reviewed by Lucas Forschler.
- Scripts/webkitpy/api_tests/manager.py: (Manager): (Manager.run): Upload results to a results database.
- Scripts/webkitpy/api_tests/run_api_tests.py: (parse_args): Add upload arguments.
- Scripts/webkitpy/port/base.py: (Port): (Port.configuration_for_upload): Creates a configuration dictionary for uploading results. (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along with commits from any other associated repositories.
- Scripts/webkitpy/port/device.py: (Device): (Device.build_version): Access build_versoin of underlying platform device.
- Scripts/webkitpy/port/ios_simulator_unittest.py: (IOSSimulatorTest): (IOSSimulatorTest.test_configuration_for_upload):
- Scripts/webkitpy/port/device_port.py: (DevicePort): (DevicePort.configuration_for_upload): Devices are unique because their configuration is not the same as the machine uploading results.
- Scripts/webkitpy/port/mac.py: (MacPort): (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
- Scripts/webkitpy/port/mac_unittest.py: (MacTest): (MacTest.test_configuration_for_upload):
- Scripts/webkitpy/xcode/simulated_device.py: (SimulatedDeviceManager._create_device_with_runtime): (SimulatedDevice.init): Create simulated device with a build_version.
- Scripts/webkitpy/xcode/simulated_device_unittest.py: (test_existing_simulator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:46 AM Changeset in webkit [243747] by
-
- 2 edits in trunk/Source/WTF
Inhibit CFNetwork logging in private sessions
https://bugs.webkit.org/show_bug.cgi?id=196268
<rdar://problem/48210793>
Fix a conditional in Platform.h where IOS should have been used
instead of IOS_FAMILY. The latter happened to work, but we really want
to be using the proper symbol here.
Reviewed by Alexey Proskuryakov.
- wtf/Platform.h:
- 9:33 AM Changeset in webkit [243746] by
-
- 12 edits in trunk
[CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
https://bugs.webkit.org/show_bug.cgi?id=182757
Reviewed by Don Olmstead.
.:
Some generated headers need to be exported to its client modules.
Before this change, WEBKIT_MAKE_FORWARDING_HEADERS copies all *.h
files in the directory specified by DERIVED_SOURCE_DIRECTORIES
parameter. The copy operation was triggered by POST_BUILD event.
This caused build dependency issues for Ninja builds. This change
remove the DERIVED_SOURCE_DIRECTORIES parameter. And list all
generated headers explicitly which need to be copied.
- Source/cmake/WebKitMacros.cmake: Removed
DERIVED_SOURCE_DIRECTORIES parameter of
WEBKIT_MAKE_FORWARDING_HEADERS. Accept absolute paths for FILES
parameter.
Source/JavaScriptCore:
- CMakeLists.txt: Do not use DERIVED_SOURCE_DIRECTORIES parameter
of WEBKIT_MAKE_FORWARDING_HEADERS. Added generated headers to
JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS.
Source/WebCore:
No new tests because no behavior changes.
- PlatformWin.cmake: Do not use DERIVED_SOURCE_DIRECTORIES of
WEBKIT_MAKE_FORWARDING_HEADERS. Added
WebCore_PRIVATE_FRAMEWORK_HEADERS.
- WebCoreMacros.cmake (GENERATE_DOM_NAMES): Added
${_namespace}ElementTypeHelpers.h to _outputfiles.
Source/WebKitLegacy:
- PlatformWin.cmake: Do not use DERIVED_SOURCE_DIRECTORIES
parameter of WEBKIT_MAKE_FORWARDING_HEADERS. Added
WebKitLegacyGUID_PRIVATE_FRAMEWORK_HEADERS.
Tools:
- TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
- TestWebKitAPI/PlatformWPE.cmake: Ditto.
- 9:23 AM Changeset in webkit [243745] by
-
- 3 edits in trunk/LayoutTests
inspector/audit/basic.html is a flaky timeout on bots
https://bugs.webkit.org/show_bug.cgi?id=196448
Unreviewed test gardening
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations: Updating test expectaions for flaky timeout
- 8:58 AM Changeset in webkit [243744] by
-
- 5 edits2 adds in trunk/Source/JavaScriptCore
Add a ValueRepReduction phase
https://bugs.webkit.org/show_bug.cgi?id=196234
Reviewed by Filip Pizlo.
This patch adds a ValueRepReduction phase. The main idea here is
to try to reduce DoubleRep(RealNumberUse:ValueRep(DoubleRepUse:@x))
to just be @x. This patch handles such above strengh reduction rules
as long as we prove that all users of the ValueRep can be converted
to using the incoming double value. That way we prevent introducing
a parallel live range for the double value.
This patch tracks the uses of the ValueRep through Phi variables,
so we can convert entire Phi variables to being Double instead
of JSValue if the Phi also has only double uses.
This is implemented through a simple escape analysis. DoubleRep(RealNumberUse:)
and OSR exit hints are not counted as escapes. All other uses are counted
as escapes. Connected Phi graphs are converted to being Double only if the
entire graph is ok with the result being Double.
Some ways we could extend this phase in the future:
- There are a lot of DoubleRep(NumberUse:@ValueRep(@x)) uses. This ensures that the result of the DoubleRep of @x is not impure NaN. We could handle this case if we introduced a PurifyNaN node and replace the DoubleRep with PurifyNaN(@x). Alternatively, we could see if certain users of this DoubleRep are okay with impure NaN flowing into them and we'd need to ensure their output type is always treated as if the input is impure NaN.
- We could do sinking of ValueRep where we think it's profitable. So instead of an escape making it so we never represent the variable as a Double, we could make the escape reconstruct the JSValueRep where profitable.
- We can extend this phase to handle Int52Rep if it's profitable.
- We can opt other nodes into accepting incoming Doubles so we no longer treat them as escapes.
This patch is somewhere between neutral and a 1% progression on JetStream 2.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGValueRepReductionPhase.cpp: Added.
(JSC::DFG::ValueRepReductionPhase::ValueRepReductionPhase):
(JSC::DFG::ValueRepReductionPhase::run):
(JSC::DFG::ValueRepReductionPhase::convertValueRepsToDouble):
(JSC::DFG::performValueRepReduction):
- dfg/DFGValueRepReductionPhase.h: Added.
- runtime/Options.h:
- 8:57 AM Changeset in webkit [243743] by
-
- 2 edits in trunk/LayoutTests
fast/viewport/ios/constant-width-viewport-after-changing-view-scale.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=195341
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations: Updating test expecations for flaky failure
- 8:50 AM Changeset in webkit [243742] by
-
- 2 edits in trunk/LayoutTests
fast/viewport/ios/viewport-shrink-to-fit-on-new-navigation.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196495
Unreviewed test gardening
- platform/ios-simulator-wk2/TestExpectations: Updating test expectations for flaky failure
- 7:47 AM Changeset in webkit [243741] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
[GSteamer][WebRTC] Fix building libwebrtc on ARM
https://bugs.webkit.org/show_bug.cgi?id=196157
Patch by Thibault Saunier <tsaunier@igalia.com> on 2019-04-02
Reviewed by Philippe Normand.
Making sure neon files are built as required
- CMakeLists.txt:
- 7:31 AM Changeset in webkit [243740] by
-
- 4 edits in trunk/LayoutTests
REGRESSION(r243512): Change locale of test in intl-datetimeformat.js
https://bugs.webkit.org/show_bug.cgi?id=196395
r243512 modifes Intl.DateTimeFormat to obey 2-digit hour. A test was
added to test 2-digit hour in Russian using 12-hour setting as true and
false. In the former case, the expected string appends the string 'AM'
in Russian. This localised string made GTK-based ports fail since
according to Glib the 'am_pm' values in Russian are not localised.
This patch keeps the same test but changes locale to 'en' to prevent
the test from failing.
Reviewed by Michael Catanzaro.
- js/intl-datetimeformat-expected.txt:
- js/script-tests/intl-datetimeformat.js:
- platform/gtk/js/intl-datetimeformat-expected.txt:
- 3:59 AM Changeset in webkit [243739] by
-
- 2 edits in trunk/Source/WebCore
Update the status of ResizeObserver in features.json.
https://bugs.webkit.org/show_bug.cgi?id=196443
Patch by Cathie Chen <cathiechen> on 2019-04-02
Reviewed by Rob Buis.
- features.json:
Apr 1, 2019:
- 11:44 PM Changeset in webkit [243738] by
-
- 2 edits in trunk/Source/WebCore
Nullptr crash in Document::open after calling policyChecker().stopCheck()
https://bugs.webkit.org/show_bug.cgi?id=196479
Reviewed by Antti Koivisto.
Added a missing nullptr check in Document::open after calling m_frame->loader().policyChecker().stopCheck()
since it invokes m_willSubmitFormCompletionHandlers in WebKit2, and that could clear m_frame.
Unfortunately, we don't have any reproducible test case.
- dom/Document.cpp:
(WebCore::Document::open):
- 11:23 PM Changeset in webkit [243737] by
-
- 2 edits in trunk/LayoutTests
Skip the tests added in r236519 on iOS. This feature was never implemented in iOS.
- platform/ios/TestExpectations:
- 9:01 PM Changeset in webkit [243736] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- crypto/mac/SerializedCryptoKeyWrapMac.mm:
(WebCore::createAndStoreMasterKey): Add ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END
around SecTrustedApplicationCreateFromPath call.
- 8:16 PM Changeset in webkit [243735] by
-
- 3 edits in trunk/Source/WebCore
Remove some unused iOS scrolling-related code in Frame
https://bugs.webkit.org/show_bug.cgi?id=196473
Reviewed by Zalan Bujtas.
This code has no callers.
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::scrollOverflowLayer): Deleted.
(WebCore::Frame::overflowAutoScrollTimerFired): Deleted.
(WebCore::Frame::startOverflowAutoScroll): Deleted.
(WebCore::Frame::checkOverflowScroll): Deleted.
- page/Frame.h:
- 8:14 PM Changeset in webkit [243734] by
-
- 4 edits in trunk
Attr nodes are not cloned properly
https://bugs.webkit.org/show_bug.cgi?id=196466
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline WPT test now that one more check is passing.
- web-platform-tests/dom/nodes/Document-importNode-expected.txt:
Source/WebCore:
Attr nodes are not cloned properly according to:
A cloned Attr node should retain its prefix and namespace.
Both Gecko and Blink agree with the DOM specification here.
No new tests, rebaselined existing test.
- dom/Document.cpp:
(WebCore::Document::importNode):
- 8:12 PM Changeset in webkit [243733] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, drop debug logging landed as part of r242903 by mistake.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
- 7:57 PM Changeset in webkit [243732] by
-
- 11 edits in trunk/Tools
run-api-tests: Upload test results
https://bugs.webkit.org/show_bug.cgi?id=196323
<rdar://problem/49356714>
Reviewed by Lucas Forschler.
- Scripts/webkitpy/api_tests/manager.py:
(Manager):
(Manager.run): Upload results to a results database.
- Scripts/webkitpy/api_tests/run_api_tests.py:
(parse_args): Add upload arguments.
- Scripts/webkitpy/port/base.py:
(Port):
(Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
(Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
with commits from any other associated repositories.
- Scripts/webkitpy/port/device.py:
(Device):
(Device.build_version): Access build_versoin of underlying platform device.
- Scripts/webkitpy/port/ios_simulator_unittest.py:
(IOSSimulatorTest):
(IOSSimulatorTest.test_configuration_for_upload):
- Scripts/webkitpy/port/device_port.py:
(DevicePort):
(DevicePort.configuration_for_upload): Devices are unique because their configuration is not
the same as the machine uploading results.
- Scripts/webkitpy/port/mac.py:
(MacPort):
(MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
- Scripts/webkitpy/port/mac_unittest.py:
(MacTest):
(MacTest.test_configuration_for_upload):
- Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager._create_device_with_runtime):
(SimulatedDevice.init): Create simulated device with a build_version.
- Scripts/webkitpy/xcode/simulated_device_unittest.py:
(test_existing_simulator):
- 7:04 PM Changeset in webkit [243731] by
-
- 2 edits2 adds in trunk/Source/WebKit
Add SPI to give injected bundles access to displayed PDFDocuments
https://bugs.webkit.org/show_bug.cgi?id=196471
<rdar://problem/48080768>
Patch by Remy Demarest <rdemarest@apple.com> on 2019-04-01
Reviewed by Tim Horton.
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.h: Added.
- WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.mm: Added.
(WKBundlePageGetPDFDocumentInFrame):
- 6:31 PM Changeset in webkit [243730] by
-
- 51 edits15 deletes in trunk
Remove the SVG tear off objects for SVGMatrix, SVGTransfrom, SVGTransformList and SVGAnimatedTransformList
https://bugs.webkit.org/show_bug.cgi?id=196086
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-04-01
Reviewed by Simon Fraser.
Source/WebCore:
The IDL changes:
SVGTransform.idl:
Remove the NewObject qualifier from matrix attribute. This matches
the specs: https://www.w3.org/TR/SVG11/coords.html#InterfaceSVGTransform.
SVGTransform will internally hold an SVGMatrix. A change in this
SVGMatrix will affect the container SVGTransform.
SVGTransformList.idl:
Remove the NewObject qualifier from consolidate() method. This matches
the specs:
https://www.w3.org/TR/SVG11/coords.html#__svg__SVGTransformList__consolidate
The method consolidate() should return a reference to the first item
in the list after consolidating it.
Code changes:
-- SVGMatrix is now a superclass of SVGValueProperty<AffineTransform>.
No need for SVGMatrixValue since it was wrapper of AffineTransform.
-- SVGTransformValue now holds a Ref<SVGMatrix> member in addition to the
angle and the rotationCenter. Ref<SVGMatrix> is what SVGTransform.matrix
will return. So a change in this matrix will change the owner SVGTransform.
-- SVGTransform is now the owner of SVGMatrix via its SVGTransformValue.
-- SVGTransformList is now a superclass of SVGValuePropertyList<SVGTransform>.
It is responsible for parsing a String to items of SVGTransform.
-- SVGAnimatedTransformList is now defined as SVGAnimatedPropertyList<
SVGTransformList>.
Note the ownership chain of these objects is the following:
-- SVGAnimatedTransformList owns the SVGTransformList via its baseVal
and animVal members.
-- SVGTransformList owns SVGTransform via its list of items
-- SVGTransform owns SVGMatrix via its SVGTransformValue.
So a change in SVGMatrix will propagate to the owner SVGElement through
the following ownership chain:
SVGMatrix
|_ SVGTransfrom
|_ SVGTransformList
|_ SVGAmimatedTransformList
|_ SVGElement
To get the mechanics of this change right, a new accessor, a new animator
and animation functions are added for the SVGAnimatedTransformList.
-- SVGViewSpec used to hold an SVGAnimatedTransformListAttribute for the
member m_transform although this member should not be animated. See the
comment in the old SVGViewSpec::transform(). This has been changed in this
patch. SVGViewSpec now holds Ref<SVGTransformList> which matches the specs:
https://www.w3.org/TR/SVG11/types.html#InterfaceSVGViewSpec.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- svg/SVGAnimateElementBase.cpp:
(WebCore::SVGAnimateElementBase::attributeAnimationController):
(WebCore::SVGAnimateElementBase::hasValidAttributeType const):
(WebCore::SVGAnimateElementBase::calculateToAtEndOfDurationValue):
(WebCore::SVGAnimateElementBase::calculateFromAndToValues):
(WebCore::SVGAnimateElementBase::calculateFromAndByValues):
- svg/SVGAnimateElementBase.h:
(WebCore::SVGAnimateElementBase::animateRangeString const):
- svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::animateRangeString const):
- svg/SVGAnimateTransformElement.h:
This change is needed because animating the transform attribute can be
written as
<animate ... from="translate(100)" to="translate(200)"/>
or
<animateTransform type="translate" from="100" to="200"/>"
So we need to surround the animation range string with the type qualifier
for animateTransform.
- svg/SVGAnimatedTransformList.cpp: Removed.
- svg/SVGAnimatedTransformList.h: Removed.
- svg/SVGAnimatedType.h: Removed.
- svg/SVGAnimatedTypeAnimator.cpp: Removed.
- svg/SVGAnimatedTypeAnimator.h: Removed.
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::adjustForInheritance): Deleted.
- svg/SVGAnimationElement.h:
(WebCore::SVGAnimationElement::adjustForInheritance): Deleted.
(WebCore::SVGAnimationElement::adjustFromToListValues): Deleted.
(WebCore::SVGAnimationElement::animateDiscreteType): Deleted.
These functions were used by SVGLegacyAttributeAnimationController.
- svg/SVGAnimatorFactory.h: Removed.
- svg/SVGExternalResourcesRequired.h:
(WebCore::SVGExternalResourcesRequired::isKnownAttribute):
- svg/SVGFEImageElement.h:
- svg/SVGFEMorphologyElement.h:
- svg/SVGFETileElement.h:
- svg/SVGFitToViewBox.h:
(WebCore::SVGFitToViewBox::isKnownAttribute):
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::SVGGradientElement):
(WebCore::SVGGradientElement::parseAttribute):
(WebCore::SVGGradientElement::registerAttributes): Deleted.
- svg/SVGGradientElement.h:
(WebCore::SVGGradientElement::gradientTransform const):
(WebCore::SVGGradientElement::gradientTransformAnimated):
(WebCore::SVGGradientElement::isKnownAttribute):
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::animatedLocalTransform const):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
There is one attribute for this element which is "SVGNames::transformAttr"
So there is no need to check for it twice.
(WebCore::SVGGraphicsElement::registerAttributes): Deleted.
- svg/SVGGraphicsElement.h:
(WebCore::SVGGraphicsElement::transform const):
(WebCore::SVGGraphicsElement::transformAnimated):
(WebCore::SVGGraphicsElement::isKnownAttribute): Deleted.
- svg/SVGLangSpace.cpp:
(WebCore::SVGLangSpace::SVGLangSpace):
(WebCore::SVGLangSpace::xmlspace const):
(WebCore::SVGLangSpace::isKnownAttribute):
(WebCore::SVGLangSpace::svgAttributeChanged):
(WebCore::SVGLangSpace::registerAttributes): Deleted.
- svg/SVGLangSpace.h:
(WebCore::SVGLangSpace::xmllang const):
(WebCore::SVGLangSpace::setXmllang):
(WebCore::SVGLangSpace::setXmlspace):
(WebCore::SVGLangSpace::attributeRegistry): Deleted.
(WebCore::SVGLangSpace::isKnownAttribute): Deleted.
- svg/SVGLegacyAttributeAnimationController.cpp: Removed.
- svg/SVGLegacyAttributeAnimationController.h: Removed.
- svg/SVGLinearGradientElement.cpp:
(WebCore::setGradientAttributes):
- svg/SVGMaskElement.h:
- svg/SVGMatrix.h:
(WebCore::SVGMatrix::create):
(WebCore::SVGMatrix::a const):
(WebCore::SVGMatrix::setA):
(WebCore::SVGMatrix::b const):
(WebCore::SVGMatrix::setB):
(WebCore::SVGMatrix::c const):
(WebCore::SVGMatrix::setC):
(WebCore::SVGMatrix::d const):
(WebCore::SVGMatrix::setD):
(WebCore::SVGMatrix::e const):
(WebCore::SVGMatrix::setE):
(WebCore::SVGMatrix::f const):
(WebCore::SVGMatrix::setF):
(WebCore::SVGMatrix::multiply const):
(WebCore::SVGMatrix::inverse const):
(WebCore::SVGMatrix::translate const):
(WebCore::SVGMatrix::scale const):
(WebCore::SVGMatrix::scaleNonUniform const):
(WebCore::SVGMatrix::rotate const):
(WebCore::SVGMatrix::rotateFromVector const):
(WebCore::SVGMatrix::flipX const):
(WebCore::SVGMatrix::flipY const):
(WebCore::SVGMatrix::skewX const):
(WebCore::SVGMatrix::skewY const):
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::SVGPatternElement):
(WebCore::SVGPatternElement::parseAttribute):
(WebCore::SVGPatternElement::svgAttributeChanged):
(WebCore::SVGPatternElement::collectPatternAttributes const):
(WebCore::SVGPatternElement::localCoordinateSpaceTransform const):
(WebCore::SVGPatternElement::registerAttributes): Deleted.
- svg/SVGPatternElement.h:
- svg/SVGPoint.h:
(WebCore::SVGPoint::matrixTransform const):
- svg/SVGPolyElement.h:
(WebCore::SVGPolyElement::isKnownAttribute): Deleted.
- svg/SVGRadialGradientElement.cpp:
(WebCore::setGradientAttributes):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::createSVGTransform):
(WebCore::SVGSVGElement::createSVGTransformFromMatrix):
(WebCore::SVGSVGElement::viewBoxToViewTransform const):
- svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::animatedLocalTransform const):
- svg/SVGTransform.cpp: Removed.
- svg/SVGTransform.h:
(WebCore::SVGTransform::create):
(WebCore::SVGTransform::~SVGTransform):
(WebCore::SVGTransform::clone const):
(WebCore::SVGTransform::type):
(WebCore::SVGTransform::angle):
(WebCore::SVGTransform::matrix):
(WebCore::SVGTransform::setMatrix):
(WebCore::SVGTransform::setTranslate):
(WebCore::SVGTransform::setScale):
(WebCore::SVGTransform::setRotate):
(WebCore::SVGTransform::setSkewX):
(WebCore::SVGTransform::setSkewY):
(WebCore::SVGTransform::SVGTransform):
- svg/SVGTransform.idl:
- svg/SVGTransformList.h:
- svg/SVGTransformList.idl:
- svg/SVGTransformListValues.cpp: Removed.
- svg/SVGTransformListValues.h: Removed.
- svg/SVGTransformValue.cpp: Removed.
- svg/SVGTransformValue.h:
(WebCore::SVGTransformValue::SVGTransformValue):
(WebCore::SVGTransformValue::operator=):
(WebCore::SVGTransformValue::matrix const):
(WebCore::SVGTransformValue::rotationCenter const):
(WebCore::SVGTransformValue::isValid const):
(WebCore::SVGTransformValue::setMatrix):
(WebCore::SVGTransformValue::matrixDidChange):
(WebCore::SVGTransformValue::translate const):
(WebCore::SVGTransformValue::setTranslate):
(WebCore::SVGTransformValue::scale const):
(WebCore::SVGTransformValue::setScale):
(WebCore::SVGTransformValue::setRotate):
(WebCore::SVGTransformValue::setSkewX):
(WebCore::SVGTransformValue::setSkewY):
(WebCore::SVGTransformValue::valueAsString const):
(WebCore::SVGTransformValue::prefixForTransfromType):
(WebCore::SVGTransformValue::appendNumbers const):
(WebCore::SVGTransformValue::appendMatrix const):
(WebCore::SVGTransformValue::appendTranslate const):
(WebCore::SVGTransformValue::appendScale const):
(WebCore::SVGTransformValue::appendRotate const):
(WebCore::SVGTransformValue::appendSkewX const):
(WebCore::SVGTransformValue::appendSkewY const):
(WebCore::SVGTransformValue::matrix): Deleted.
- svg/SVGTransformable.cpp:
(WebCore::SVGTransformable::parseAndSkipType):
(WebCore::parseAndSkipType): Deleted.
(WebCore::SVGTransformable::parseTransformAttribute): Deleted.
The code of this function was moved to SVGTransformList::parse().
- svg/SVGTransformable.h:
There is no need for enum TransformParsingMode. It was used by
SVGViewSpec::parseViewSpec() to tell SVGTransformable::parseTransformAttribute()
not to clear the list. SVGTransfromList now has two parse() functions:
one public and the second is private. The public one clear the list
before parsing the input String. The private one just does the parsing.
SVGViewSpec::parseViewSpec() calls the private once since it is a friend
of SVGTransfromList.
- svg/SVGValue.h: Removed.
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::SVGViewSpec):
(WebCore::SVGViewSpec::reset):
(WebCore::SVGViewSpec::parseViewSpec):
(WebCore::SVGViewSpec::registerAttributes): Deleted.
(WebCore::SVGViewSpec::transform): Deleted.
- svg/SVGViewSpec.h:
- svg/properties/SVGAnimatedPropertyAccessorImpl.h:
- svg/properties/SVGAnimatedPropertyAnimatorImpl.h:
- svg/properties/SVGAnimatedPropertyImpl.h:
- svg/properties/SVGAnimatedTransformListPropertyTearOff.h: Removed.
- svg/properties/SVGAnimationAdditiveListFunctionImpl.h:
(WebCore::SVGAnimationTransformListFunction::progress):
- svg/properties/SVGAnimationAdditiveValueFunctionImpl.h:
- svg/properties/SVGAttributeRegistry.h:
- svg/properties/SVGMatrixTearOff.h: Removed.
- svg/properties/SVGPropertyAccessorImpl.h:
- svg/properties/SVGPropertyOwnerRegistry.h:
(WebCore::SVGPropertyOwnerRegistry::registerProperty):
LayoutTests:
- svg/dom/SVGTransformList-basics-expected.txt:
- svg/dom/SVGTransformList-basics.xhtml:
These changes are required because SVGTransfromList will be following the
SVG2 specs regarding adding new items to the list.
See https://www.w3.org/TR/SVG/types.html#TermListInterface.
- 6:08 PM Changeset in webkit [243729] by
-
- 2 edits in trunk
[CMake] Remove EXTRA_DIRECTORIES parameter of WEBKIT_MAKE_FORWARDING_HEADERS
https://bugs.webkit.org/show_bug.cgi?id=196436
Reviewed by Darin Adler.
The parameter was only for WebCore/ForwardingHeaders which was
removed in Bug 182347.
- Source/cmake/WebKitMacros.cmake: Remove unused EXTRA_DIRECTORIES parameter.
- 5:26 PM Changeset in webkit [243728] by
-
- 2 edits in trunk/Tools
Remove extra newline characters (Follow-up fix to r243707)
- BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
- 5:20 PM Changeset in webkit [243727] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Debugger: modernize serialization of breakpoints and the maps that hold them
https://bugs.webkit.org/show_bug.cgi?id=196230
<rdar://problem/49236485>
Reviewed by Joseph Pecoraro.
- UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager):
(WI.DebuggerManager.prototype.breakpointsForSourceCode):
(WI.DebuggerManager.prototype.addBreakpoint):
(WI.DebuggerManager.prototype.removeBreakpoint):
(WI.DebuggerManager.prototype._setBreakpoint):
(WI.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
- UserInterface/Models/Breakpoint.js:
(WI.Breakpoint):
(WI.Breakpoint.fromJSON): Added.
(WI.Breakpoint.prototype.toJSON):
(WI.Breakpoint.prototype.set resolved):
(WI.Breakpoint.prototype.recreateAction):
(WI.Breakpoint.prototype.saveIdentityToCookie):
(WI.Breakpoint.prototype._isSpecial): Added.
(WI.Breakpoint.set resolved.isSpecialBreakpoint): Deleted.
(WI.Breakpoint.serializeOptions): Deleted.
- UserInterface/Models/BreakpointAction.js:
(WI.BreakpointAction):
(WI.BreakpointAction.fromJSON): Added.
(WI.BreakpointAction.prototype.toProtocol): Added.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WI.DebuggerSidebarPanel.prototype._addBreakpointsForSourceCode):
- UserInterface/Views/SourceCodeTextEditor.js:
(WI.SourceCodeTextEditor.prototype._prepareEditorForInitialContent):
(WI.SourceCodeTextEditor.prototype._breakpointsEnabledDidChange):
- 5:01 PM Changeset in webkit [243726] by
-
- 9 edits4 copies in trunk/Source/WebKit
[WebKit2] Introduce a public version of WKWebsitePolicies
https://bugs.webkit.org/show_bug.cgi?id=195989
<rdar://problem/47228232>
Reviewed by Tim Horton.
Expose the existing _WKWebsitePolicies object as WKWebpagePreferences, in what will eventually become a public
header in the WebKit SDK (WKWebpagePreferences.h). Following a similar transitioning strategy as
_WKWebsiteDataStore and WKWebsiteDataStore, we move existing logic from _WKWebsitePolicies to WKWebpagePreferences
and make _WKWebsitePolicies a wrapper around WKWebpagePreferences.
No change in behavior.
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
Wrap API::WebsitePolicies with WKWebpagePreferences.
- SourcesCocoa.txt:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateWebsitePolicies:]):
- UIProcess/API/Cocoa/WKWebpagePreferences.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebsitePoliciesInternal.h.
- UIProcess/API/Cocoa/WKWebpagePreferences.mm: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebsitePolicies.mm.
Introduce WKWebpagePreferences.
(+[WKWebpagePreferences defaultPreferences]):
(-[WKWebpagePreferences dealloc]):
(-[WKWebpagePreferences init]):
(-[WKWebpagePreferences _setContentBlockersEnabled:]):
(-[WKWebpagePreferences _contentBlockersEnabled]):
(-[WKWebpagePreferences _setAllowedAutoplayQuirks:]):
(-[WKWebpagePreferences _allowedAutoplayQuirks]):
(-[WKWebpagePreferences _setAutoplayPolicy:]):
(-[WKWebpagePreferences _autoplayPolicy]):
(-[WKWebpagePreferences _setDeviceOrientationAndMotionAccessPolicy:]):
(-[WKWebpagePreferences _deviceOrientationAndMotionAccessPolicy]):
(-[WKWebpagePreferences _setPopUpPolicy:]):
(-[WKWebpagePreferences _popUpPolicy]):
(-[WKWebpagePreferences _customHeaderFields]):
(-[WKWebpagePreferences _setCustomHeaderFields:]):
(-[WKWebpagePreferences _websiteDataStore]):
(-[WKWebpagePreferences _setWebsiteDataStore:]):
(-[WKWebpagePreferences _setCustomUserAgent:]):
(-[WKWebpagePreferences _customUserAgent]):
(-[WKWebpagePreferences _setCustomJavaScriptUserAgentAsSiteSpecificQuirks:]):
(-[WKWebpagePreferences _customJavaScriptUserAgentAsSiteSpecificQuirks]):
(-[WKWebpagePreferences _setCustomNavigatorPlatform:]):
(-[WKWebpagePreferences _customNavigatorPlatform]):
(-[WKWebpagePreferences _apiObject]):
- UIProcess/API/Cocoa/WKWebpagePreferencesInternal.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebsitePoliciesInternal.h.
- UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebsitePolicies.h.
Reintroduce all the interfaces currently available on _WKWebsitePolicies as underscore-prefixed SPI on
WKWebpagePreferences.
- UIProcess/API/Cocoa/_WKWebsitePolicies.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.mm:
Make _WKWebsitePolicies wrap WKWebpagePreferences, and plumb all existing SPI on WKWebsitePolicies through to
WKWebpagePreferences.
(-[_WKWebsitePolicies init]):
(-[_WKWebsitePolicies webpagePreferences]):
(-[_WKWebsitePolicies setContentBlockersEnabled:]):
(-[_WKWebsitePolicies contentBlockersEnabled]):
(-[_WKWebsitePolicies setAllowedAutoplayQuirks:]):
(-[_WKWebsitePolicies allowedAutoplayQuirks]):
(-[_WKWebsitePolicies setAutoplayPolicy:]):
(-[_WKWebsitePolicies autoplayPolicy]):
(-[_WKWebsitePolicies setDeviceOrientationAndMotionAccessPolicy:]):
(-[_WKWebsitePolicies deviceOrientationAndMotionAccessPolicy]):
(-[_WKWebsitePolicies setPopUpPolicy:]):
(-[_WKWebsitePolicies popUpPolicy]):
(-[_WKWebsitePolicies customHeaderFields]):
(-[_WKWebsitePolicies setCustomHeaderFields:]):
(-[_WKWebsitePolicies websiteDataStore]):
(-[_WKWebsitePolicies setWebsiteDataStore:]):
(-[_WKWebsitePolicies setCustomUserAgent:]):
(-[_WKWebsitePolicies customUserAgent]):
(-[_WKWebsitePolicies setCustomJavaScriptUserAgentAsSiteSpecificQuirks:]):
(-[_WKWebsitePolicies customJavaScriptUserAgentAsSiteSpecificQuirks]):
(-[_WKWebsitePolicies setCustomNavigatorPlatform:]):
(-[_WKWebsitePolicies customNavigatorPlatform]):
(-[_WKWebsitePolicies description]):
(-[_WKWebsitePolicies _apiObject]):
(-[_WKWebsitePolicies dealloc]): Deleted.
- UIProcess/API/Cocoa/_WKWebsitePoliciesInternal.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
- WebKit.xcodeproj/project.pbxproj:
- 5:00 PM Changeset in webkit [243725] by
-
- 7 edits in tags/Safari-608.1.13.4/Source
Versioning.
- 4:54 PM Changeset in webkit [243724] by
-
- 3 edits2 adds in tags/Safari-608.1.13.4
Cherry-pick r243684. rdar://problem/49454962
[iOS] Crash when changing inputmode for certain types of focusable elements
https://bugs.webkit.org/show_bug.cgi?id=196431
<rdar://problem/49454962>
Reviewed by Tim Horton.
Source/WebKit:
The crash is happening because WebPage::focusedElementDidChangeInputMode assumes that the document's focused
element must be the same as m_focusedElement in WebPage. However, this is not the case, since m_focusedElement
is only set for certain types of elements that require user input (e.g. text fields, editable content, select
menus, etc.). The function then attempts to dereference m_focusedElement, which may be null if the document's
focused element doesn't fall into one of the aforementioned categories.
To fix this, bail if the element that is changing inputmode is not equal to the WebPage's current focused
element. See below for more details.
Test: fast/forms/change-inputmode-crash.html
- WebProcess/WebPage/WebPage.cpp: (WebKit::isTextFormControlOrEditableContent):
Clean up some existing logic by introducing a helper method for determining whether an element should
propagate inputmode attribute changes to the UI process. Also, check the element type using type traits instead
of checking against the tag name.
(WebKit::WebPage::elementDidFocus):
(WebKit::WebPage::focusedElementDidChangeInputMode):
LayoutTests:
Add a layout test that exercises the edge case; see WebKit ChangeLogs for more details.
- fast/forms/change-inputmode-crash-expected.txt: Added.
- fast/forms/change-inputmode-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:54 PM Changeset in webkit [243723] by
-
- 20 edits3 adds1 delete in tags/Safari-608.1.13.4
Cherry-pick r243671. rdar://problem/47859936
Move WebResourceLoadStatisticsStore IPC calls from the UI process to the network process
https://bugs.webkit.org/show_bug.cgi?id=196407
<rdar://problem/47859936>
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/storageAccess/grant-storage-access-under-opener-at-popup-user-gesture.html
This patch removes old code for the batching into "statistics updated" calls.
Since the move of Resource Load Statistics to the network process, all such
collection is done directly through dedicated calls to the network process.
The remaining functionality was renamed to make it more clear, i.e.
ResourceLoadObserver::notifyObserver() renamed to
ResourceLoadObserver::updateCentralStatisticsStore().
- loader/ResourceLoadObserver.cpp: (WebCore::ResourceLoadObserver::setStatisticsUpdatedCallback): (WebCore::ResourceLoadObserver::setRequestStorageAccessUnderOpenerCallback): (WebCore::ResourceLoadObserver::logSubresourceLoading): (WebCore::ResourceLoadObserver::logWebSocketLoading): (WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution): (WebCore::ResourceLoadObserver::requestStorageAccessUnderOpener): (WebCore::ResourceLoadObserver::updateCentralStatisticsStore): (WebCore::ResourceLoadObserver::clearState): (WebCore::ResourceLoadObserver::setNotificationCallback): Deleted. (WebCore::ResourceLoadObserver::ResourceLoadObserver): Deleted. (WebCore::ResourceLoadObserver::scheduleNotificationIfNeeded): Deleted. (WebCore::ResourceLoadObserver::notifyObserver): Deleted.
- loader/ResourceLoadObserver.h:
- testing/Internals.cpp: (WebCore::Internals::notifyResourceLoadObserver):
Source/WebKit:
The two WebResourceLoadStatisticsStore IPC endpoints were left behind when we
moved Resource Load Statistics from the UI process to the network process. One
of the endpoints is the message RequestStorageAccessUnderOpener which underpins
our compatibility fix for federated logins using popups. This patch redirects
these IPC calls to the network process and cleans up some assumptions around
them.
- CMakeLists.txt:
Removed the old IPC receiver.
- DerivedSources.make:
Removed the old IPC receiver.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::requestUpdate): Deleted.
This is no longer needed since there is a dedicated update mechanism
that actually sends the update.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::resourceLoadStatisticsUpdated): (WebKit::NetworkConnectionToWebProcess::requestStorageAccessUnderOpener):
Two new IPC receivers to pipe the calls to the network process.
(WebKit::NetworkConnectionToWebProcess::requestResourceLoadStatisticsUpdate): Deleted.
NetworkConnectionToWebProcess::resourceLoadStatisticsUpdated now serves
this purpose.
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- UIProcess/WebResourceLoadStatisticsStore.messages.in: Removed.
Removed the old IPC receiver.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleResourceLoadStatisticsNotifyObserver):
Function name update.
- WebProcess/WebProcess.cpp:
Now calls IPC to the network process instead of the UI process.
LayoutTests:
- http/tests/storageAccess/deny-storage-access-under-opener-expected.txt:
- http/tests/storageAccess/deny-storage-access-under-opener-if-auto-dismiss-expected.txt:
- http/tests/storageAccess/grant-storage-access-under-opener-at-popup-user-gesture-expected.txt: Added.
- http/tests/storageAccess/grant-storage-access-under-opener-at-popup-user-gesture.html: Added.
- http/tests/storageAccess/resources/get-cookies.php:
- http/tests/storageAccess/resources/produce-user-gesture-set-cookie-and-report-back.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:38 PM Changeset in webkit [243722] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: DOMDebugger: disabling a breakpoint for a specific event listener removes it from the UI
https://bugs.webkit.org/show_bug.cgi?id=196453
<rdar://problem/49489318>
Reviewed by Joseph Pecoraro.
Allow breakpoints for specific event listeners to be disabled, rather than immeditately
removing/deleting them when they are about to become disabled. This preserves the existing
functionality, but now allows for the tree element to stay in the UI in a disabled state.
- UserInterface/Controllers/DOMManager.js:
(WI.DOMManager):
(WI.DOMManager.prototype.setBreakpointForEventListener):
(WI.DOMManager.prototype.removeBreakpointForEventListener):
(WI.DOMManager.prototype.removeEventListenerBreakpointsForNode): Added.
(WI.DOMManager.prototype._updateEventBreakpoint): Added.
(WI.DOMManager.prototype._handleEventBreakpointDisabledStateChanged): Added.
- UserInterface/Controllers/DOMDebuggerManager.js:
(WI.DOMDebuggerManager.prototype._handleEventBreakpointDisabledStateChanged):
- UserInterface/Views/EventBreakpointTreeElement.js:
(WI.EventBreakpointTreeElement.prototype.populateContextMenu):
(WI.EventBreakpointTreeElement.prototype._toggleBreakpoint):
- UserInterface/Views/ContextMenuUtilities.js:
(WI.appendContextMenuItemsForDOMNodeBreakpoints):
- UserInterface/Views/DOMNodeTreeElement.js:
(WI.DOMNodeTreeElement.prototype.ondelete):
- 4:13 PM Changeset in webkit [243721] by
-
- 1 copy in tags/Safari-608.1.13.4
New tag.
- 3:41 PM Changeset in webkit [243720] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Canvas: auto-record after page load sometimes shows the wrong UI
https://bugs.webkit.org/show_bug.cgi?id=196320
<rdar://problem/49356686>
Reviewed by Joseph Pecoraro.
It was previously possible that the timing of a recording being started and the preview
image being loaded would not always be in the same order.
Utilize the existing
View.prototype.layoutmechanics to ensure that updates are coalesced
and that the changes are always applied in a particular order.
- UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView):
(WI.CanvasContentView.prototype.refreshPreview): Added.
(WI.CanvasContentView.prototype.initialLayout):
(WI.CanvasContentView.prototype.layout):
(WI.CanvasContentView.prototype.shown):
(WI.CanvasContentView.prototype.attached):
(WI.CanvasContentView.prototype._refreshPixelSize):
(WI.CanvasContentView.prototype.refresh): Deleted.
(WI.CanvasContentView.prototype._recordingStarted): Deleted.
(WI.CanvasContentView.prototype._recordingProgress): Deleted.
(WI.CanvasContentView.prototype._recordingStopped): Deleted.
(WI.CanvasContentView.prototype._shaderProgramAdded): Deleted.
(WI.CanvasContentView.prototype._shaderProgramRemoved): Deleted.
- UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView.prototype._refreshPreviews):
- 3:41 PM Changeset in webkit [243719] by
-
- 5 edits in trunk
Web Inspector: DOMDebugger: breakpoints for attribute modifications still fire when breakpoints are disabled
https://bugs.webkit.org/show_bug.cgi?id=196456
<rdar://problem/49489747>
Reviewed by Joseph Pecoraro.
Source/WebCore:
Test: inspector/dom-debugger/dom-breakpoints.html
- inspector/agents/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
LayoutTests:
- inspector/dom-debugger/dom-breakpoints.html:
- inspector/dom-debugger/dom-breakpoints-expected.txt:
- 3:38 PM Changeset in webkit [243718] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Canvas: add compatibility support for WebMetal
https://bugs.webkit.org/show_bug.cgi?id=196412
<rdar://problem/49439417>
Reviewed by Joseph Pecoraro.
- UserInterface/Models/Canvas.js:
(WI.Canvas.fromPayload):
(WI.Canvas.displayNameForContextType):
- UserInterface/Protocol/Legacy/12.2/InspectorBackendCommands.js:
- Versions/Inspector-iOS-12.2.json:
- 3:35 PM Changeset in webkit [243717] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: "Copy as HTML" appears twice when showing a context menu for a logged node
https://bugs.webkit.org/show_bug.cgi?id=196271
<rdar://problem/49290676>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/ObjectTreeBaseTreeElement.js:
(WI.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
- Localizations/en.lproj/localizedStrings.js:
- 2:57 PM Changeset in webkit [243716] by
-
- 3 edits in trunk/Tools
[ews-app] Use API_KEY to accept results data
https://bugs.webkit.org/show_bug.cgi?id=196461
Reviewed by Dewei Zhu.
- BuildSlaveSupport/ews-app/ews/views/results.py:
(Results.post): Validate EWS_API_KEY before accepting any data.
- BuildSlaveSupport/ews-build/events.py:
(Events.sendData): Send EWS_API_KEY if available along with event data.
- 2:50 PM Changeset in webkit [243715] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Debugger: breakpoints don't populate in inspector2 on first load
https://bugs.webkit.org/show_bug.cgi?id=196063
<rdar://problem/49097787>
Reviewed by Joseph Pecoraro.
In the case that a breakpoint becomes resolved after the resource has finished loaded, there
won't be an already existingTreeElementfor the breakpoint to replace.
This can realistically only happen if the IndexedDB lookup is super slow, or the resource is
extremely fast (e.g. adataurl).
- UserInterface/Views/DebuggerSidebarPanel.js:
(WI.DebuggerSidebarPanel.prototype._handleDebuggerObjectDisplayLocationDidChange):
(WI.DebuggerSidebarPanel.prototype._addDebuggerObject): Deleted.
- UserInterface/Views/SourcesNavigationSidebarPanel.js:
(WI.SourcesNavigationSidebarPanel.prototype._addBreakpoint):
(WI.SourcesNavigationSidebarPanel.prototype._addBreakpointsForSourceCode):
(WI.SourcesNavigationSidebarPanel.prototype._handleDebuggerObjectDisplayLocationDidChange):
- 2:27 PM Changeset in webkit [243714] by
-
- 2 edits in trunk/LayoutTests
[Win10] Look into platform specific layout test failures
https://bugs.webkit.org/show_bug.cgi?id=196463
Unreviewed test gardening.
- platform/win/TestExpectations:
- 2:21 PM Changeset in webkit [243713] by
-
- 9 edits in trunk
Unable to copy and paste a PDF from Notes into Mail compose body
https://bugs.webkit.org/show_bug.cgi?id=196442
<rdar://problem/48573098>
Reviewed by Tim Horton.
Source/WebCore:
Refactor some logic for inserting attachment elements upon paste or drop. Currently, we only prefer inserting
content as attachment elements if the items are annotated with UIPreferredPresentationStyleAttachment. However,
many data sources around the system (both first and third party) have not adopted this API, which makes it
difficult to determine whether a given item provider should be treated as a file or not. In this bug in
particular, no preferred presentation style is set, so we fail to handle the paste command by inserting an
attachment element.
However, most apps around the system that write file or attachment-like data to the pasteboard will at least
offer a suggested name for the file, in the form of -[NSItemProvider suggestedName]. To address this, instead of
relying solely on the preferredPresentationStyle, additionally take a suggested name as an indicator that the
item is probably a file.
In fact, Pasteboard::fileContentState already has similar logic to check for either a suggested file name or
explicitly specified presentation style. We pull this out into a separate helper method on PasteboardItemInfo,
and use it for both Pasteboard::fileContentState and prefersAttachmentRepresentation.
Tests: WKAttachmentTestsIOS.InsertPastedContactAsAttachment
WKAttachmentTestsIOS.InsertPastedMapItemAsAttachment
- editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::mimeTypeFromContentType):
Work around <rdar://problem/49478229> by using the "text/vcard" MIME type to handle "public.vcard". CoreServices
currently maps "public.vcard" to "text/directory" when using UTTypeCopyPreferredTagWithClass, despite the SPI
-[NSURLFileTypeMappings MIMETypeForExtension:] returning "text/vcard" for a ".vcf" file.
- platform/PasteboardItemInfo.h:
(WebCore::PasteboardItemInfo::canBeTreatedAsAttachmentOrFile const):
Add a helper method to determine whether the PasteboardItemInfo prefers to be represented as inline data, or an
attachment, or neither. This differs slightly from the existing value of preferredPresentationStyle in that we
consider having a suggested file name as a strong indicator that the item should be treated as an attachment,
even if the presentation style is unspecified.
- platform/cocoa/PasteboardCocoa.mm:
(WebCore::Pasteboard::fileContentState):
Use PasteboardItemInfo::canBeTreatedAsAttachmentOrFile().
- platform/ios/PasteboardIOS.mm:
(WebCore::prefersAttachmentRepresentation):
Use PasteboardItemInfo::canBeTreatedAsAttachmentOrFile().
Source/WebKit:
Relax the -canPerformAction: logic in the case of pasting an attachment. Consider an NSItemProvider to possibly
paste as an attachment if either it has a preferred presentation style of UIPreferredPresentationStyleAttachment
or has a style of UIPreferredPresentationStyleUnspecified, but has a suggested file name.
This allows for the "Paste" action to be shown in the callout menu when copying and pasting a non-text file.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformActionForWebView:withSender:]):
Tools:
Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
to be specified on the item providers.
- TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::mapItemForTesting):
(TestWebKitAPI::contactItemForTesting):
- 2:08 PM Changeset in webkit [243712] by
-
- 7 edits in trunk
Make UIWKDocumentContext rects per-character instead of per-word
https://bugs.webkit.org/show_bug.cgi?id=196459
Reviewed by Wenson Hsieh.
Source/WebCore:
No new tests; adjusted expected results of WebKit.DocumentEditingContext.
- editing/TextIterator.cpp:
(WebCore::CharacterIterator::CharacterIterator):
- editing/TextIterator.h:
(WebCore::CharacterIterator::atEnd const):
(WebCore::CharacterIterator::text const):
Add WEBCORE_EXPORT to some things.
Introduce a CharacterIterator constructor that takes Positions, like one that TextIterator has.
Move initializers to the header.
Source/WebKit:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestDocumentEditingContext):
Switch to CharacterIterator instead of TextIterator directly, to get
per-character rects as the API requests.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
(TEST):
Adjust test results due to switching to per-character rects.
- 1:52 PM Changeset in webkit [243711] by
-
- 9 edits in trunk
UIProcess crash when a prewarmed process is terminated
https://bugs.webkit.org/show_bug.cgi?id=196451
<rdar://problem/49245471>
Reviewed by Geoffrey Garen.
Source/WebKit:
Stop assuming that WebProcessProxy::m_websiteDataStore is non-null as this is no longer
true after r243384. For example, prewarmed WebContent processe do not get a data store
until they actually get used.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _prewarmedProcessIdentifier]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::networkProcessIdentifier):
(WebKit::WebProcessPool::prewarmedProcessIdentifier):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didFinishLaunching):
(WebKit::WebProcessProxy::requestTermination):
(WebKit::WebProcessProxy::isReleaseLoggingAllowed const):
- UIProcess/WebProcessProxy.h:
Tools:
Add API test coverage.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
(TEST):
- 1:46 PM Changeset in webkit [243710] by
-
- 2 edits in trunk/LayoutTests
accessibility/Mac/async-increment-decrement-action.html is crashing and blaming other tests on bots
https://bugs.webkit.org/show_bug.cgi?id=187391
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Updating test expectations to skip crashing test
- 12:53 PM Changeset in webkit [243709] by
-
- 5 edits2 adds in trunk
Update event region when toggling pointer-events:none
https://bugs.webkit.org/show_bug.cgi?id=195902
<rdar://problem/48988384>
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/scrolling/ios/event-region-pointer-events.html
Normally paint invalidation requests compositing configuration update whenever anything that would
affect event region changes. However mutating 'pointer-events' property does not cause paint invalidation.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):
Request compositing update explicitly from the containing layer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::invalidateEventRegion):
- rendering/RenderLayer.h:
LayoutTests:
- fast/scrolling/ios/event-region-pointer-events-expected.txt: Added.
- fast/scrolling/ios/event-region-pointer-events.html: Added.
- 12:51 PM Changeset in webkit [243708] by
-
- 3 edits in trunk/Source/WebKit
[GTK][WPE] Add more websitedatastore directories to web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=196447
Patch by Patrick Griffis <Patrick Griffis> on 2019-04-01
Reviewed by Michael Catanzaro.
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bubblewrapSpawn):
- UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
- 12:48 PM Changeset in webkit [243707] by
-
- 2 edits in trunk/Tools
[ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
https://bugs.webkit.org/show_bug.cgi?id=196449
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble.get_os_details): Method to get OS and Xcode details.
(StatusBubble._build_bubble): Moved the timestamp logic to common method.
(StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
- 12:45 PM Changeset in webkit [243706] by
-
- 2 edits in trunk/Tools
[ews-build] Remove force schedulers from OpenSource EWS Buildbot
https://bugs.webkit.org/show_bug.cgi?id=196444
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
- 12:05 PM Changeset in webkit [243705] by
-
- 7 edits5 adds in trunk
Support "noreferrer" for window.open()
https://bugs.webkit.org/show_bug.cgi?id=194533
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline WPT test now that all checks are passing.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noreferrer-expected.txt:
Source/WebCore:
Support "noreferrer" for window.open() as per:
Tests: imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noreferrer.html
http/wpt/html/browsers/the-window-object/window-open-noopener-webkit.html
- page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):
- page/WindowFeatures.cpp:
(WebCore::setWindowFeature):
- page/WindowFeatures.h:
LayoutTests:
Add equivalent test to imported/w3c/web-platform-tests/html/browsers/the-window-object/window-open-noopener.html
but which relies on localStorage instead of BroadcastChannel so that it works with WebKit.
- http/wpt/html/browsers/the-window-object/support/noreferrer-target-webkit.html: Added.
- http/wpt/html/browsers/the-window-object/window-open-noopener-webkit-expected.txt: Added.
- http/wpt/html/browsers/the-window-object/window-open-noopener-webkit.html: Added.
- 11:54 AM Changeset in webkit [243704] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: CPU Usage Timeline - Adjust Energy Impact Threshholds
https://bugs.webkit.org/show_bug.cgi?id=196421
<rdar://problem/49125703>
Reviewed by Devin Rousso.
- Low - Keep Below 3% to continue to encourage idle pages stay below 3% Might want to reduce to 2.5 or 2 after fixing bug 196419.
- High - Make Above 30% instead of 50% to encourage long running interactivity to stay below 30% Depends on interaction, but sustained (1-2min) at 30%+ will certainly impact battery.
- Very High - Make above 100% instead of 150% CPU Usage spikes around page load and is quite often still under 100% despite many threads. Drop this a bit as we dropped High down.
Reduce the size of the Medium section, and increase the High section
Having 70% of the chart be "Medium" is just too much Medium, and
we've now made it more possible to be in the High range.
- UserInterface/Views/CPUTimelineView.js:
(WI.CPUTimelineView.prototype.get mediumEnergyThreshold):
(WI.CPUTimelineView.prototype.get highEnergyThreshold):
(WI.CPUTimelineView.prototype.get lowEnergyGraphBoundary):
(WI.CPUTimelineView.prototype.get mediumEnergyGraphBoundary):
(WI.CPUTimelineView.prototype.get highEnergyGraphBoundary):
(WI.CPUTimelineView.prototype.initialLayout):
(WI.CPUTimelineView.prototype.layout.bestThreadLayoutMax):
(WI.CPUTimelineView.prototype._layoutEnergyChart):
- 11:46 AM Changeset in webkit [243703] by
-
- 12 edits1 delete in trunk
SVGMatrix.IDL methods do not conform to the specs
https://bugs.webkit.org/show_bug.cgi?id=196263
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-04-01
Reviewed by Simon Fraser.
Source/WebCore:
I think there was a misconception about these functions. The specs link
is: https://www.w3.org/TR/SVG11/coords.html#InterfaceSVGMatrix.
Notice that the specs does not state that the SVGMethod methods should
raise the exception NO_MODIFICATION_ALLOWED_ERR if the object is read
only. Notice setting the attribute 'a' for example may raise this
exception. Therefore, I think the specs wanted to make these operations
read-only. None of the methods should raise the exception
NO_MODIFICATION_ALLOWED_ERR.
In fact the SVG code was doing the right thing. For example SVGMatrix::scale()
was calling SVGMatrixValue::scale() which was making a copy of itself,
applying the scale on the copy and then returning the copy. When
SVGMatrix::scale() receives the copy of the SVGMatrixValue it creates and
returns a new SVGMatrix object.
- WebCore.xcodeproj/project.pbxproj:
- svg/SVGMatrix.h:
(WebCore::SVGMatrix::create):
(WebCore::SVGMatrix::a const):
(WebCore::SVGMatrix::b const):
(WebCore::SVGMatrix::c const):
(WebCore::SVGMatrix::d const):
(WebCore::SVGMatrix::e const):
(WebCore::SVGMatrix::f const):
(WebCore::SVGMatrix::multiply const):
(WebCore::SVGMatrix::inverse const):
(WebCore::SVGMatrix::translate const):
(WebCore::SVGMatrix::scale const):
(WebCore::SVGMatrix::scaleNonUniform const):
(WebCore::SVGMatrix::rotate const):
(WebCore::SVGMatrix::rotateFromVector const):
(WebCore::SVGMatrix::flipX const):
(WebCore::SVGMatrix::flipY const):
(WebCore::SVGMatrix::skewX const):
(WebCore::SVGMatrix::skewY const):
(WebCore::SVGMatrix::a): Deleted.
(WebCore::SVGMatrix::b): Deleted.
(WebCore::SVGMatrix::c): Deleted.
(WebCore::SVGMatrix::d): Deleted.
(WebCore::SVGMatrix::e): Deleted.
(WebCore::SVGMatrix::f): Deleted.
(WebCore::SVGMatrix::multiply): Deleted.
(WebCore::SVGMatrix::inverse): Deleted.
(WebCore::SVGMatrix::translate): Deleted.
(WebCore::SVGMatrix::scale): Deleted.
(WebCore::SVGMatrix::scaleNonUniform): Deleted.
(WebCore::SVGMatrix::rotate): Deleted.
(WebCore::SVGMatrix::rotateFromVector): Deleted.
(WebCore::SVGMatrix::flipX): Deleted.
(WebCore::SVGMatrix::flipY): Deleted.
(WebCore::SVGMatrix::skewX): Deleted.
(WebCore::SVGMatrix::skewY): Deleted.
(WebCore::SVGMatrix::SVGMatrix): Deleted.
- svg/SVGMatrix.idl:
- svg/SVGMatrixValue.h: Removed.
- svg/SVGTransform.cpp:
(WebCore::SVGTransform::matrix):
- svg/SVGTransformDistance.cpp:
(WebCore::SVGTransformDistance::addToSVGTransform const):
- svg/SVGTransformValue.h:
(WebCore::SVGTransformValue::matrix const):
(WebCore::SVGTransformValue::matrix):
(WebCore::SVGTransformValue::svgMatrix): Deleted.
(WebCore::operator==): Deleted.
(WebCore::operator!=): Deleted.
- svg/properties/SVGMatrixTearOff.h:
- svg/properties/SVGPropertyTearOff.h:
(WebCore::SVGPropertyTearOff::propertyReference const):
LayoutTests:
- svg/dom/SVGMatrix-expected.txt:
- svg/dom/SVGMatrix.html:
Clean this test. Make it test the case when valid arguments are passed to
the methods of the SVGMatrix. Make sure the methods are read-only. All
of them should be making a copy of the matrix, applying the transform and
returning the copy.
- 11:33 AM Changeset in webkit [243702] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] JSRunLoopTimer::Manager should be small
https://bugs.webkit.org/show_bug.cgi?id=196425
Reviewed by Darin Adler.
Using very large Key or Value in HashMap potentially bloats memory since HashMap pre-allocates large size of
memory ((sizeof(Key) + sizeof(Value)) * N) for its backing storage's array. Using std::unique_ptr<> for JSRunLoopTimer's
PerVMData to keep HashMap's backing store size small.
- runtime/JSRunLoopTimer.cpp:
(JSC::JSRunLoopTimer::Manager::timerDidFire):
(JSC::JSRunLoopTimer::Manager::registerVM):
(JSC::JSRunLoopTimer::Manager::scheduleTimer):
(JSC::JSRunLoopTimer::Manager::cancelTimer):
(JSC::JSRunLoopTimer::Manager::timeUntilFire):
(JSC::JSRunLoopTimer::Manager::didChangeRunLoop):
- runtime/JSRunLoopTimer.h:
- 11:33 AM Changeset in webkit [243701] by
-
- 11 edits in trunk/Source/WebCore
Plumb through a ScrollType value that indicates whether a scroll was a user or programmatic scroll
https://bugs.webkit.org/show_bug.cgi?id=196424
Reviewed by Zalan Bujtas.
In preparation for fixing webkit.org/b/195584, we need to know if an overflow scroll
is programmatic, so plumb through an enum value. The functions touched by this patch are
only ever called for programmatic scrolls.
- dom/Element.cpp:
(WebCore::Element::scrollTo):
(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):
- platform/ScrollTypes.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
- rendering/RenderBox.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToXPosition):
(WebCore::RenderLayer::scrollToYPosition):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::setScrollLeft):
(WebCore::RenderListBox::setScrollTop):
- rendering/RenderListBox.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
- rendering/RenderTextControlSingleLine.h:
- 11:25 AM Changeset in webkit [243700] by
-
- 3 edits3 adds in trunk
[PlayStation] Add initialization for JSC shell for PlayStation port
https://bugs.webkit.org/show_bug.cgi?id=195411
Reviewed by Ross Kirsling.
.:
Add functions for doing the automatic libc, floating point
initializations, signing of binaries and libraries and
wrapping of libc functions on PlayStation port.
- Source/cmake/OptionsPlayStation.cmake:
Source/JavaScriptCore:
Add ps options
- shell/PlatformPlayStation.cmake: Added.
- shell/playstation/Initializer.cpp: Added.
(initializer):
- 11:23 AM Changeset in webkit [243699] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Crash when loading Twitter with autoplay video enabled.
https://bugs.webkit.org/show_bug.cgi?id=196446
<rdar://problem/49060359>
Reviewed by Brent Fulgham.
This is caused by a syscall violation.
- WebProcess/com.apple.WebProcess.sb.in:
- 11:21 AM Changeset in webkit [243698] by
-
- 5 edits1 add in trunk
Add SPI to canonicalize NSURLs with WTF::URL
https://bugs.webkit.org/show_bug.cgi?id=196415
<rdar://problem/44980271>
Patch by Alex Christensen <achristensen@webkit.org> on 2019-04-01
Reviewed by Darin Adler.
Source/WebKitLegacy/mac:
- Misc/WebNSURLExtras.h:
- Misc/WebNSURLExtras.mm:
(-[NSURL _webkit_canonicalize_with_wtf]):
_webkit_canonicalize is old and changing it causes strange bugs like rdar://problem/5315926
Instead, make a new version that uses WTF::URL to canonicalize an NSURL.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
(TestWebKitAPI::TEST):
- 10:27 AM Changeset in webkit [243697] by
-
- 10 edits in trunk/Source
Stop trying to support building JSC with clang 3.8
https://bugs.webkit.org/show_bug.cgi?id=195947
<rdar://problem/49069219>
Reviewed by Darin Adler.
It seems WebKit hasn't built with clang 3.8 in a while, no devs are using this compiler, we
don't know how much effort it would be to make JSC work again, and it's making the code
Source/JavaScriptCore:
worse. Remove my hacks to support clang 3.8 from JSC.
- bindings/ScriptValue.cpp:
(Inspector::jsToInspectorValue):
- bytecode/GetterSetterAccessCase.cpp:
(JSC::GetterSetterAccessCase::create):
(JSC::GetterSetterAccessCase::clone const):
- bytecode/InstanceOfAccessCase.cpp:
(JSC::InstanceOfAccessCase::clone const):
- bytecode/IntrinsicGetterAccessCase.cpp:
(JSC::IntrinsicGetterAccessCase::clone const):
- bytecode/ModuleNamespaceAccessCase.cpp:
(JSC::ModuleNamespaceAccessCase::clone const):
- bytecode/ProxyableAccessCase.cpp:
(JSC::ProxyableAccessCase::clone const):
Source/WTF:
worse. Remove my hacks to support clang 3.8 from WTF.
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::allocate):
- wtf/text/StringConcatenate.h:
(WTF::tryMakeStringFromAdapters):
- 10:21 AM Changeset in webkit [243696] by
-
- 2 edits in trunk/LayoutTests
storage/indexeddb/modern/deletedatabase-2-private.html is a flaky failure on Mac Debug
https://bugs.webkit.org/show_bug.cgi?id=196445
Unreviewed test gardening
- platform/ios-simulator-wk2/TestExpectations: Updating test expectations for flaky test
- 9:45 AM Changeset in webkit [243695] by
-
- 5 edits in trunk/Source/WebCore
[iOS] Refactor some logic for inserting pasted or dropped virtual card files as attachment elements
https://bugs.webkit.org/show_bug.cgi?id=196435
Work towards <rdar://problem/48573098>
Reviewed by Darin Adler.
Refactor some existing codepaths on iOS for inserting VCard files as attachment elements. Instead of using a
separate readVirtualContactFile method for converting a vcard file or data into an attachment element (possibly
accompanied by a link), use the existing readFilePaths WebContentReader method.
To handle links which may accompany the attachment element, add a helper method in PasteboardIOS that reads a
titled URL prior to inserting an attachment element, in the case of pasting or dropping a VCF.
This means we no longer need to handle attachment reading in readPasteboardWebContentDataForType, so we can
simply bail before reading "public.vcard" here and defer to reading other data types.
Covered by existing API tests in WKAttachmentTests and DragAndDropTestsIOS.
- editing/WebContentReader.h:
- editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::WebContentReader::readVirtualContactFile): Deleted.
- platform/Pasteboard.h:
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::readPasteboardWebContentDataForType):
(WebCore::readURLAlongsideAttachmentIfNecessary):
(WebCore::prefersAttachmentRepresentation):
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::readRespectingUTIFidelities):
- 9:38 AM Changeset in webkit [243694] by
-
- 4 edits2 adds in trunk
Trying to scroll the compose pane on gmail.com scrolls the message list behind
https://bugs.webkit.org/show_bug.cgi?id=196426
<rdar://problem/49402667>
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/scrolling/ios/event-region-visibility-hidden.html
We fail to gather event region from desdendants of non-overflowing elements with 'visibility:hidden'.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
Skip the subtree walk only if the current region covers the box already.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintList):
Remove the (wrong) optimization, we bail out quickly on first renderer if possible so this is not high value.
LayoutTests:
- fast/scrolling/ios/event-region-visibility-hidden-expected.txt: Added.
- fast/scrolling/ios/event-region-visibility-hidden.html: Added.
- 6:36 AM Changeset in webkit [243693] by
-
- 2 edits in trunk/LayoutTests
Change expectation for imported/w3c/web-platform-tests/resize-observer/eventloop.html.
https://bugs.webkit.org/show_bug.cgi?id=196422
Patch by Cathie Chen <cathiechen> on 2019-04-01
Reviewed by Frédéric Wang.
At current implement, notifyResizeObservers is not synchronized to requestAnimationFrame, so the test would be flaky.
- TestExpectations: eventloop.html is flaky because it depend on the order of requestAnimationFrame and ResizeObserver timer.
- 6:02 AM Changeset in webkit [243692] by
-
- 2 edits in trunk/Source/WebKit
[GTK][WPE] Fix seccomp rule for blacklisting TIOCSTI
https://bugs.webkit.org/show_bug.cgi?id=196297
Patch by Patrick Griffis <Patrick Griffis> on 2019-04-01
Reviewed by Michael Catanzaro.
More information can be found here: https://www.exploit-db.com/exploits/46594
Note that this sandbox never made it into production so does not
warrant any CVE specific to WebKit.
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::setupSeccomp):
- 5:50 AM Changeset in webkit [243691] by
-
- 13 edits in trunk
Be less strict about closing blocks in attribute and functional pseudo-element selectors.
https://bugs.webkit.org/show_bug.cgi?id=142167
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/dom/nodes/selectors.js: Add tests for ::slotted
Source/WebCore:
This was also an issue for, e.g., "::slotted(foo", turns out.
This matches Chromium, Firefox, and the spec:
https://drafts.csswg.org/css-syntax/#parse-error:
Certain points in the parsing algorithm are said to be parse errors. The error
handling for parse errors is well-defined: user agents must either act as
described below when encountering such problems, or must abort processing at
the first error that they encounter for which they do not wish to apply the
rules described below.
https://drafts.csswg.org/css-syntax/#consume-simple-block:
<EOF-token>
This is a parse error. Return the block.
Tests: web-platform-tests/dom/nodes/selectors.js (and probably others)
- css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumeAttribute):
(WebCore::CSSSelectorParser::consumePseudo):
- 2:47 AM Changeset in webkit [243690] by
-
- 2 edits in trunk/Source/WebCore
Build failure after r243644 in GTK Linux 64-bit stable builds
https://bugs.webkit.org/show_bug.cgi?id=196440
Patch by Pablo Saavedra <Pablo Saavedra> on 2019-04-01
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::updateTextureMapperFlags):
- 2:07 AM Changeset in webkit [243689] by
-
- 3 edits in trunk/Tools
[WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
https://bugs.webkit.org/show_bug.cgi?id=196441
Reviewed by Carlos Garcia Campos.
Don't cache the wpe_view_backend object that might not exist yet at the
time of EventSenderProxy constructor invocation, but instead retrieve
that object whenever it's required for event dispatching. This should
avoid crashes in this constructor now that it's invoked before any
PlatformWindow has been set up (as changed in r243496).
- WebKitTestRunner/EventSenderProxy.h:
- WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
(WTR::viewBackend):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
Mar 31, 2019:
- 11:51 PM Changeset in webkit [243688] by
-
- 21 edits in trunk/Source
[JSC] Butterfly allocation from LargeAllocation should try "realloc" behavior if collector thread is not active
https://bugs.webkit.org/show_bug.cgi?id=196160
Reviewed by Saam Barati.
Source/JavaScriptCore:
"realloc" can be effective in terms of peak/current memory footprint when realloc succeeds because,
- It does not allocate additional memory while expanding a vector
- It does not deallocate an old memory, just reusing the current memory by expanding, so that memory footprint is tight even before scavenging
We found that we can "realloc" large butterflies in certain conditions are met because,
- If it goes to LargeAllocation, this memory region is never reused until GC sweeps it.
- Butterflies are owned by owner JSObjects, so we know the lifetime of Butterflies.
This patch attempts to use "realloc" onto butterflies if,
- Butterflies are allocated in LargeAllocation kind
- Concurrent collector is not active
- Butterflies do not have property storage
The condition (2) is required to avoid deallocating butterflies while the concurrent collector looks into it. The condition (3) is
also required to avoid deallocating butterflies while the concurrent compiler looks into it.
We also change LargeAllocation mechanism to using "malloc" and "free" instead of "posix_memalign". This allows us to use "realloc"
safely in all the platforms. Since LargeAllocation uses alignment to distinguish LargeAllocation and MarkedBlock, we manually adjust
16B alignment by allocating 8B more memory in "malloc".
Speedometer2 and JetStream2 are neutral. RAMification shows about 1% progression (even in some of JIT tests).
- heap/AlignedMemoryAllocator.h:
- heap/CompleteSubspace.cpp:
(JSC::CompleteSubspace::tryAllocateSlow):
(JSC::CompleteSubspace::reallocateLargeAllocationNonVirtual):
- heap/CompleteSubspace.h:
- heap/FastMallocAlignedMemoryAllocator.cpp:
(JSC::FastMallocAlignedMemoryAllocator::tryAllocateMemory):
(JSC::FastMallocAlignedMemoryAllocator::freeMemory):
(JSC::FastMallocAlignedMemoryAllocator::tryReallocateMemory):
- heap/FastMallocAlignedMemoryAllocator.h:
- heap/GigacageAlignedMemoryAllocator.cpp:
(JSC::GigacageAlignedMemoryAllocator::tryAllocateMemory):
(JSC::GigacageAlignedMemoryAllocator::freeMemory):
(JSC::GigacageAlignedMemoryAllocator::tryReallocateMemory):
- heap/GigacageAlignedMemoryAllocator.h:
- heap/IsoAlignedMemoryAllocator.cpp:
(JSC::IsoAlignedMemoryAllocator::tryAllocateMemory):
(JSC::IsoAlignedMemoryAllocator::freeMemory):
(JSC::IsoAlignedMemoryAllocator::tryReallocateMemory):
- heap/IsoAlignedMemoryAllocator.h:
- heap/LargeAllocation.cpp:
(JSC::isAlignedForLargeAllocation):
(JSC::LargeAllocation::tryCreate):
(JSC::LargeAllocation::tryReallocate):
(JSC::LargeAllocation::LargeAllocation):
(JSC::LargeAllocation::destroy):
- heap/LargeAllocation.h:
(JSC::LargeAllocation::indexInSpace):
(JSC::LargeAllocation::setIndexInSpace):
(JSC::LargeAllocation::basePointer const):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::sweepLargeAllocations):
(JSC::MarkedSpace::prepareForConservativeScan):
- heap/WeakSet.h:
(JSC::WeakSet::isTriviallyDestructible const):
- runtime/Butterfly.h:
- runtime/ButterflyInlines.h:
(JSC::Butterfly::reallocArrayRightIfPossible):
- runtime/JSObject.cpp:
(JSC::JSObject::ensureLengthSlow):
Source/WTF:
- wtf/FastMalloc.h:
(WTF::FastMalloc::tryRealloc):
- wtf/Gigacage.cpp:
(Gigacage::tryRealloc):
- wtf/Gigacage.h:
- 11:42 PM Changeset in webkit [243687] by
-
- 3 edits2 adds in trunk
Scroll position gets reset when overflow:scroll is inside grid
https://bugs.webkit.org/show_bug.cgi?id=196337
<rdar://problem/49385784>
Reviewed by Simon Fraser.
Fix scroll position when there are changes inside a grid item with "overflow: scroll".
Source/WebCore:
Test: fast/css-grid-layout/grid-item-content-scroll-position.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock): Use beginUpdateScrollInfoAfterLayoutTransaction()
and endAndCommitUpdateScrollInfoAfterLayoutTransaction().
LayoutTests:
- fast/css-grid-layout/grid-item-content-scroll-position-expected.txt: Added.
- fast/css-grid-layout/grid-item-content-scroll-position.html: Added.
- 7:03 PM Changeset in webkit [243686] by
-
- 4 edits in trunk/Source/WebCore
Reduce the size of Node::deref by eliminating an explicit parentNode check
https://bugs.webkit.org/show_bug.cgi?id=195776
Reviewed by Darin Adler.
Address post-commit review comments.
- dom/Document.cpp:
(WebCore::Document::removedLastRef):
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::removedLastRef):
- dom/Node.h:
(WebCore::Node::deref):
(WebCore::Node::setParentNode):
- 6:38 PM Changeset in webkit [243685] by
-
- 3 edits in trunk/Tools
[Win][WebKit] MiniBrowser should support high DPI display
https://bugs.webkit.org/show_bug.cgi?id=196391
Reviewed by Alex Christensen.
- MiniBrowser/win/WebKitBrowserWindow.cpp:
(WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
(WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
- MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
- 1:01 PM Changeset in webkit [243684] by
-
- 3 edits2 adds in trunk
[iOS] Crash when changing inputmode for certain types of focusable elements
https://bugs.webkit.org/show_bug.cgi?id=196431
<rdar://problem/49454962>
Reviewed by Tim Horton.
Source/WebKit:
The crash is happening because WebPage::focusedElementDidChangeInputMode assumes that the document's focused
element must be the same as m_focusedElement in WebPage. However, this is not the case, since m_focusedElement
is only set for certain types of elements that require user input (e.g. text fields, editable content, select
menus, etc.). The function then attempts to dereference m_focusedElement, which may be null if the document's
focused element doesn't fall into one of the aforementioned categories.
To fix this, bail if the element that is changing inputmode is not equal to the WebPage's current focused
element. See below for more details.
Test: fast/forms/change-inputmode-crash.html
- WebProcess/WebPage/WebPage.cpp:
(WebKit::isTextFormControlOrEditableContent):
Clean up some existing logic by introducing a helper method for determining whether an element should
propagate inputmode attribute changes to the UI process. Also, check the element type using type traits instead
of checking against the tag name.
(WebKit::WebPage::elementDidFocus):
(WebKit::WebPage::focusedElementDidChangeInputMode):
LayoutTests:
Add a layout test that exercises the edge case; see WebKit ChangeLogs for more details.
- fast/forms/change-inputmode-crash-expected.txt: Added.
- fast/forms/change-inputmode-crash.html: Added.
- 12:29 PM Changeset in webkit [243683] by
-
- 14 edits in trunk
Remove more i386 specific configurations
https://bugs.webkit.org/show_bug.cgi?id=196430
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
- Configurations/ToolExecutable.xcconfig:
ARC can be enabled unconditionally now.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
Source/WebKit:
- Configurations/BaseTarget.xcconfig:
WK_HAVE_CORE_PREDICTION can now be enabled unconditionally.
- Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
- 10:37 AM Changeset in webkit [243682] by
-
- 24 edits1 move in trunk
[iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
https://bugs.webkit.org/show_bug.cgi?id=196433
<rdar://problem/49293305>
Reviewed by Tim Horton.
Source/WebCore:
When ResourceLoader would encounter a response with a MIME type that QuickLook supports, the
response would be implicitly allowed and a QuickLook preview would be generated. After
generating, the client's navigation response policy delegate would be notified of the
preview response, but not the underlying response. Notably, the preview response has a URL
scheme of "x-apple-ql-id", does not include any underlying HTTP headers, and usually has a
MIME type of "text/html" or "application/pdf" rather than the underlying response MIME type.
To allow clients to make better navigation response policy decisions, this patch changes the
above behavior for WKWebView clients that have linked against a version of WebKit that
includes this change. Rather than notifying the client's navigation response policy delegate
of the preview response, we notify the client of the underlying response. Only if the client
responds with a policy of "allow" will the QuickLook preview response be loaded (without
another call to the navigation response policy delegate).
Non-WKWebView clients and clients that have linked against a version of WebKit that does not
include this change will retain the original behavior.
Covered by existing layout tests and new and existing API tests.
- WebCore.xcodeproj/project.pbxproj:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::shouldCreatePreviewLoaderForResponse const):
(WebCore::SubresourceLoader::didReceiveResponse):
- loader/ios/PreviewLoader.h:
- loader/ios/PreviewLoader.mm:
(-[WebPreviewLoader initWithResourceLoader:resourceResponse:]):
(-[WebPreviewLoader _loadPreviewIfNeeded]):
(-[WebPreviewLoader connection:didReceiveData:lengthReceived:]):
(-[WebPreviewLoader connectionDidFinishLoading:]):
(-[WebPreviewLoader connection:didFailWithError:]):
(WebCore::PreviewLoader::create):
(WebCore::PreviewLoader::didReceiveResponse):
(-[WebPreviewLoader _sendDidReceiveResponseIfNecessary]): Deleted.
(WebCore::PreviewLoader::shouldCreateForMIMEType): Deleted.
- page/Settings.yaml:
- platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::canShowMIMEType):
- platform/network/ios/PreviewConverter.h:
- platform/network/ios/PreviewConverter.mm:
(WebCore::PreviewConverter::supportsMIMEType):
Source/WebKit:
Added WKWebViewConfiguration SPI for setting the QuickLook navigation response policy
decision behavior. The configuration setting defaults to YES for clients linked on or after
this WebKit change and NO otherwise.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::shouldInterruptLoadForCSPFrameAncestorsOrXFrameOptions):
- Shared/WebPreferences.yaml:
- Shared/ios/QuickLookDocumentData.cpp:
(WebKit::QuickLookDocumentData::isEmpty const):
- Shared/ios/QuickLookDocumentData.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(defaultShouldDecidePolicyBeforeLoadingQuickLookPreview):
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration encodeWithCoder:]):
(-[WKWebViewConfiguration initWithCoder:]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _shouldDecidePolicyBeforeLoadingQuickLookPreview]):
(-[WKWebViewConfiguration _setShouldDecidePolicyBeforeLoadingQuickLookPreview:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/Cocoa/VersionChecks.h:
- WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp:
(WebKit::WebPreviewLoaderClient::didReceiveDataArray):
Source/WTF:
- wtf/NeverDestroyed.h:
(WTF::NeverDestroyed::operator->):
(WTF::NeverDestroyed::operator-> const):
Tools:
Enhanced API test coverage to include all navigation response policy decisions in both
linked-before and linked-on-or-after modes. Also added new expectations for all tests.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
(readFile):
(-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
(-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
(-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
(-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
(-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
(-[QuickLookDelegate _webViewWebProcessDidCrash:]):
(-[QuickLookDelegate _downloadDidStart:]):
(-[QuickLookDelegate _download:didReceiveResponse:]):
(-[QuickLookDelegate _download:didReceiveData:]):
(-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
(-[QuickLookDelegate _downloadDidFinish:]):
(-[QuickLookDelegate _download:didFailWithError:]):
(-[QuickLookDelegate _downloadDidCancel:]):
(-[QuickLookDelegate verifyDownload]):
(runTest):
(runTestDecideBeforeLoading):
(runTestDecideAfterLoading):
(TEST):
(-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
(-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
(-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
(-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
(-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
(-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
(-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
(-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
(-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
(-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
(-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
(-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
(-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
Mar 30, 2019:
- 3:07 PM Changeset in webkit [243681] by
-
- 4 edits2 adds in trunk
gl.readPixels with type gl.FLOAT does not work
https://bugs.webkit.org/show_bug.cgi?id=171432
<rdar://problem/31905150>
Reviewed by Antoine Quint.
Source/WebCore:
Our validation code was identifying readPixels of
type FLOAT as invalid, for three reasons:
- we didn't support the FLOAT type at all.
- we only allowed the combination of RGBA and
UNSIGNED_BYTE in WebGL 1 [*].
- if we had a framebuffer of format RGBA, we assumed
we could only read into a Uint8 ArrayBuffer.
[*] This bug isn't completely fixed, so I opened
https://bugs.webkit.org/show_bug.cgi?id=196418
Test: fast/canvas/webgl/readPixels-float.html
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::readPixels):
- flip the logic in a conditional that was clearly wrong yet thankfully had no impact.
- support type FLOAT when the relevant extension is enabled.
- allow FLOAT as a valid type (see new bug above)
- create a new macro for CHECK_COMPONENT_COUNT
- update the existing macros to not be case statements, so that we can put logic in the switch.
LayoutTests:
New test that exercises reading a framebuffer object
with a floating point texture attached.
- platform/ios/TestExpectations: Skip this test on iOS, where floating-point
FBOs are not supported.
- fast/canvas/webgl/readPixels-float-expected.txt: Added.
- fast/canvas/webgl/readPixels-float.html: Added.
- 11:34 AM WebKitGTK/2.24.x edited by
- (diff)
- 11:32 AM WebKitGTK/2.24.x edited by
- (diff)
- 11:32 AM WebKitGTK/2.24.x edited by
- (diff)
- 10:50 AM Changeset in webkit [243680] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Windows build.
- platform/graphics/RoundedRect.cpp:
(WebCore::approximateAsRegion):
- 9:38 AM Changeset in webkit [243679] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: JSC Sampling Profiler thread not getting subtracted in CPU Usage Timeline
https://bugs.webkit.org/show_bug.cgi?id=196419
<rdar://problem/49444023>
Reviewed by Devin Rousso.
- page/ResourceUsageThread.cpp:
(WebCore::ResourceUsageThread::addObserver):
We forgot to call the function that would setup platform state
allowing us to subtract out the sampling profiler thread.
- 7:09 AM Changeset in webkit [243678] by
-
- 3 edits2 adds in trunk
[ContentChangeObserver] Add iFrame elements to the list of "considered clickable" elements.
https://bugs.webkit.org/show_bug.cgi?id=196410
<rdar://problem/49436828>
Reviewed by Simon Fraser.
Source/WebCore:
163.com constructs an iFrame to display the login pane on hover. This patch ensures that we take iFrames into account while observing for visible content change by considering iFrame elements "clickable".
(While iFrames don't necessarily have clickable content, we can't just sit and wait until they are fully loaded.)
Test: fast/events/touch/ios/content-observation/iframe-is-shown-on-hover.html
- page/ios/ContentChangeObserver.cpp:
(WebCore::ContentChangeObserver::StyleChangeScope::isConsideredClickable const):
LayoutTests:
- fast/events/touch/ios/content-observation/iframe-is-shown-on-hover-expected.txt: Added.
- fast/events/touch/ios/content-observation/iframe-is-shown-on-hover.html: Added.
- 6:47 AM Changeset in webkit [243677] by
-
- 3 edits2 adds in trunk
[ContentChangeObserver] Subframe load should not reset content observation on the mainframe
https://bugs.webkit.org/show_bug.cgi?id=196408
<rdar://problem/49436797>
Reviewed by Simon Fraser.
Source/WebKit:
Hover intent fails when an unrelated frame commits a load the same time.
cancelPotentialTapInFrame is called from didCommitLoad, but what we are looking for here is the user initiated cancel of a tap (cancelPotentialTap).
(If the current frame navigates away, willDetachPage takes care of canceling the observation.)
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::cancelPotentialTap):
(WebKit::WebPage::cancelPotentialTapInFrame):
LayoutTests:
- fast/events/touch/ios/content-observation/hover-while-loading-subframe-expected.txt: Added.
- fast/events/touch/ios/content-observation/hover-while-loading-subframe.html: Added.
- 4:09 AM Changeset in webkit [243676] by
-
- 2 edits in trunk/Tools
[CMake] add testdfg as target with build-jsc
https://bugs.webkit.org/show_bug.cgi?id=196393
Reviewed by Saam Barati.
Added testdfg as one of the targets to build when
using CMake.
- Scripts/build-jsc:
- 2:19 AM Changeset in webkit [243675] by
-
- 3 edits in trunk/Source/WebCore
Try to fix Windows build.
- platform/graphics/Region.cpp:
- platform/graphics/RoundedRect.cpp:
- 1:28 AM Changeset in webkit [243674] by
-
- 15 edits2 adds in trunk
Hit-testing of boxes over scrollers should account for border-radius
https://bugs.webkit.org/show_bug.cgi?id=195374
<rdar://problem/48649993>
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/scrolling/ios/border-radious-event-region.html
- page/Frame.h:
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties const):
Testing support.
- platform/graphics/GraphicsLayerClient.h:
- platform/graphics/RoundedRect.cpp:
(WebCore::approximateAsRegion):
Add a function to approximate RoundedRects as Regions.
It cuts away rectangles from the corners following the corner shapes.
More rectangles are cut for larger radii.
- platform/graphics/RoundedRect.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
Use the new interface to get rounded corners right.
In rectangle case this takes optimized paths.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
- testing/Internals.cpp:
(WebCore::toLayerTreeFlags):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- fast/scrolling/ios/border-radius-event-region-expected.txt: Added.
- fast/scrolling/ios/border-radius-event-region.html: Added.
- fast/scrolling/ios/overflow-scroll-overlap-2-expected.txt:
Mar 29, 2019:
- 7:56 PM Changeset in webkit [243673] by
-
- 3 edits2 adds in trunk
[ContentChangeObserver] Expand DOM timer observation to 350ms
https://bugs.webkit.org/show_bug.cgi?id=196411
<rdar://problem/49391144>
Reviewed by Simon Fraser.
Source/WebCore:
imdb.com main page has 350ms hover intent timer to bring up the hover menus around the search bar.
Test: fast/events/touch/ios/content-observation/350ms-hover-intent.html
- page/ios/ContentChangeObserver.cpp:
LayoutTests:
- fast/events/touch/ios/content-observation/350ms-hover-intent-expected.txt: Added.
- fast/events/touch/ios/content-observation/350ms-hover-intent.html: Added.
- 6:30 PM Changeset in webkit [243672] by
-
- 7 edits in trunk/Source/JavaScriptCore
[JSC] JSWrapperMap should not use Objective-C Weak map (NSMapTable with NSPointerFunctionsWeakMemory) for m_cachedObjCWrappers
https://bugs.webkit.org/show_bug.cgi?id=196392
Reviewed by Saam Barati.
Weak representation in Objective-C is surprisingly costly in terms of memory. We can see that very easy program shows 10KB memory consumption due to
this weak wrapper map in JavaScriptCore.framework. But we do not need this weak map since Objective-C JSValue has a dealloc. We can unregister itself
from the map when it is deallocated without using Objective-C weak mechanism. And since Objective-C JSValue is tightly coupled to a specific JSContext,
and wrapper map is created per JSContext, JSValue wrapper and actual JavaScriptCore value is one-on-one, and [JSValue dealloc] knows which JSContext's
wrapper map holds itself.
- We do not use Objective-C weak mechanism. We use WTF::HashSet instead. When JSValue is allocated, we register it to JSWrapperMap's HashSet. And unregister JSValue from this map when JSValue is deallocated.
- We use HashSet<JSValue> (logically) instead of HashMap<JSValueRef, JSValue> to keep JSValueRef and JSValue relationship. We can achieve it because JSValue holds JSValueRef inside it.
- API/JSContext.mm:
(-[JSContext removeWrapper:]):
- API/JSContextInternal.h:
- API/JSValue.mm:
(-[JSValue dealloc]):
(-[JSValue initWithValue:inContext:]):
- API/JSWrapperMap.h:
- API/JSWrapperMap.mm:
(WrapperKey::hashTableDeletedValue):
(WrapperKey::WrapperKey):
(WrapperKey::isHashTableDeletedValue const):
(WrapperKey::Hash::hash):
(WrapperKey::Hash::equal):
(WrapperKey::Traits::isEmptyValue):
(WrapperKey::Translator::hash):
(WrapperKey::Translator::equal):
(WrapperKey::Translator::translate):
(-[JSWrapperMap initWithGlobalContextRef:]):
(-[JSWrapperMap dealloc]):
(-[JSWrapperMap objcWrapperForJSValueRef:inContext:]):
(-[JSWrapperMap removeWrapper:]):
- API/tests/testapi.mm:
(testObjectiveCAPIMain):
- 6:09 PM Changeset in webkit [243671] by
-
- 20 edits3 adds1 delete in trunk
Move WebResourceLoadStatisticsStore IPC calls from the UI process to the network process
https://bugs.webkit.org/show_bug.cgi?id=196407
<rdar://problem/47859936>
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/storageAccess/grant-storage-access-under-opener-at-popup-user-gesture.html
This patch removes old code for the batching into "statistics updated" calls.
Since the move of Resource Load Statistics to the network process, all such
collection is done directly through dedicated calls to the network process.
The remaining functionality was renamed to make it more clear, i.e.
ResourceLoadObserver::notifyObserver() renamed to
ResourceLoadObserver::updateCentralStatisticsStore().
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::setStatisticsUpdatedCallback):
(WebCore::ResourceLoadObserver::setRequestStorageAccessUnderOpenerCallback):
(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logWebSocketLoading):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
(WebCore::ResourceLoadObserver::requestStorageAccessUnderOpener):
(WebCore::ResourceLoadObserver::updateCentralStatisticsStore):
(WebCore::ResourceLoadObserver::clearState):
(WebCore::ResourceLoadObserver::setNotificationCallback): Deleted.
(WebCore::ResourceLoadObserver::ResourceLoadObserver): Deleted.
(WebCore::ResourceLoadObserver::scheduleNotificationIfNeeded): Deleted.
(WebCore::ResourceLoadObserver::notifyObserver): Deleted.
- loader/ResourceLoadObserver.h:
- testing/Internals.cpp:
(WebCore::Internals::notifyResourceLoadObserver):
Source/WebKit:
The two WebResourceLoadStatisticsStore IPC endpoints were left behind when we
moved Resource Load Statistics from the UI process to the network process. One
of the endpoints is the message RequestStorageAccessUnderOpener which underpins
our compatibility fix for federated logins using popups. This patch redirects
these IPC calls to the network process and cleans up some assumptions around
them.
- CMakeLists.txt:
Removed the old IPC receiver.
- DerivedSources.make:
Removed the old IPC receiver.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::requestUpdate): Deleted.
This is no longer needed since there is a dedicated update mechanism
that actually sends the update.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::resourceLoadStatisticsUpdated):
(WebKit::NetworkConnectionToWebProcess::requestStorageAccessUnderOpener):
Two new IPC receivers to pipe the calls to the network process.
(WebKit::NetworkConnectionToWebProcess::requestResourceLoadStatisticsUpdate): Deleted.
NetworkConnectionToWebProcess::resourceLoadStatisticsUpdated now serves
this purpose.
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- UIProcess/WebResourceLoadStatisticsStore.messages.in: Removed.
Removed the old IPC receiver.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleResourceLoadStatisticsNotifyObserver):
Function name update.
- WebProcess/WebProcess.cpp:
Now calls IPC to the network process instead of the UI process.
LayoutTests:
- http/tests/storageAccess/deny-storage-access-under-opener-expected.txt:
- http/tests/storageAccess/deny-storage-access-under-opener-if-auto-dismiss-expected.txt:
- http/tests/storageAccess/grant-storage-access-under-opener-at-popup-user-gesture-expected.txt: Added.
- http/tests/storageAccess/grant-storage-access-under-opener-at-popup-user-gesture.html: Added.
- http/tests/storageAccess/resources/get-cookies.php:
- http/tests/storageAccess/resources/produce-user-gesture-set-cookie-and-report-back.html: Added.
- 5:21 PM Changeset in webkit [243670] by
-
- 3 edits in trunk/Source/JavaScriptCore
B3ReduceStrength should know that Mul distributes over Add and Sub
https://bugs.webkit.org/show_bug.cgi?id=196325
Reviewed by Michael Saboff.
In this patch I add the following patterns to B3ReduceStrength:
- Turn this: Integer Neg(Mul(value, c)) Into this: Mul(value, -c), as long as -c does not overflow
- Turn these: Integer Mul(value, Neg(otherValue)) and Integer Mul(Neg(value), otherValue) Into this: Neg(Mul(value, otherValue))
- For Op==Add or Sub, turn any of these:
Op(Mul(x1, x2), Mul(x1, x3))
Op(Mul(x2, x1), Mul(x1, x3))
Op(Mul(x1, x2), Mul(x3, x1))
Op(Mul(x2, x1), Mul(x3, x1))
Into this: Mul(x1, Op(x2, x3))
Also includes a trivial change: a similar reduction for the distributivity of BitAnd over BitOr/BitXor now
emits the arguments to BitAnd in the other order, to minimize the probability that we'll spend a full fixpoint step just to flip them.
- b3/B3ReduceStrength.cpp:
- b3/testb3.cpp:
(JSC::B3::testAddMulMulArgs):
(JSC::B3::testMulArgNegArg):
(JSC::B3::testMulNegArgArg):
(JSC::B3::testNegMulArgImm):
(JSC::B3::testSubMulMulArgs):
(JSC::B3::run):
- 5:21 PM Changeset in webkit [243669] by
-
- 11 edits in trunk
Make someWindow.frames, .self, .window always return someWindow
https://bugs.webkit.org/show_bug.cgi?id=195406
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline WPT test now that all its checks are passing.
- web-platform-tests/html/browsers/the-window-object/self-et-al.window-expected.txt:
Source/WebCore:
Make someWindow.frames, .self, .window always return someWindow. Previously, they
would return null when the window would lose its browsing context.
This aligns our behavior with Firefox and the HTML specification:
Chrome has also recently aligned with Firefox and the HTML specification here so
it makes sense for WebKit to follow.
No new tests, rebaselined existing tests.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::self const):
(WebCore::JSDOMWindow::window const):
(WebCore::JSDOMWindow::frames const):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::focus):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
Update / rebaseline existing test to reflect behavior change.
- fast/frames/detached-frame-property-expected.txt:
- fast/frames/detached-frame-property.html:
- 4:57 PM Changeset in webkit [243668] by
-
- 1 copy in tags/Safari-607.2.3
Tag Safari-607.2.3.
- 4:33 PM Changeset in webkit [243667] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Remove distancing for LargeAllocation
https://bugs.webkit.org/show_bug.cgi?id=196335
Reviewed by Saam Barati.
In r230226, we removed distancing feature from our GC. This patch removes remaining distancing thing in LargeAllocation.
- heap/HeapCell.h:
- heap/LargeAllocation.cpp:
(JSC::LargeAllocation::tryCreate):
- heap/MarkedBlock.h:
- 3:18 PM Changeset in webkit [243666] by
-
- 66 edits79 deletes in trunk
Delete WebMetal implementation in favor of WebGPU
https://bugs.webkit.org/show_bug.cgi?id=195418
Reviewed by Dean Jackson.
.:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- inspector/protocol/Canvas.json:
- inspector/scripts/codegen/generator.py:
Source/WebCore:
WebMetal was only ever intended to be a proof-of-concept, and was never intended to be shipped.
Now that our WebGPU implementation is achieving good functionality, we're hitting conflicts
because we have both implementations. We should delete the non-standard implementation in favor
of the standards-based implementation.
Deletes relevant tests.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Sources.txt:
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebMetalRenderPassAttachmentDescriptorCustom.cpp: Removed.
- bindings/js/JSWebMetalRenderingContextCustom.cpp: Removed.
- bindings/js/WebCoreBuiltinNames.h:
- dom/Document.cpp:
(WebCore::Document::getCSSCanvasContext):
- dom/Document.h:
- dom/Document.idl:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::isWebMetalType): Deleted.
(WebCore::HTMLCanvasElement::createContextWebMetal): Deleted.
(WebCore::HTMLCanvasElement::getContextWebMetal): Deleted.
- html/HTMLCanvasElement.h:
- html/HTMLCanvasElement.idl:
- html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::isWebGPU const):
(WebCore::CanvasRenderingContext::isWebMetal const): Deleted.
- html/canvas/WebMetalBuffer.cpp: Removed.
- html/canvas/WebMetalBuffer.h: Removed.
- html/canvas/WebMetalBuffer.idl: Removed.
- html/canvas/WebMetalCommandBuffer.cpp: Removed.
- html/canvas/WebMetalCommandBuffer.h: Removed.
- html/canvas/WebMetalCommandBuffer.idl: Removed.
- html/canvas/WebMetalCommandQueue.cpp: Removed.
- html/canvas/WebMetalCommandQueue.h: Removed.
- html/canvas/WebMetalCommandQueue.idl: Removed.
- html/canvas/WebMetalComputeCommandEncoder.cpp: Removed.
- html/canvas/WebMetalComputeCommandEncoder.h: Removed.
- html/canvas/WebMetalComputeCommandEncoder.idl: Removed.
- html/canvas/WebMetalComputePipelineState.cpp: Removed.
- html/canvas/WebMetalComputePipelineState.h: Removed.
- html/canvas/WebMetalComputePipelineState.idl: Removed.
- html/canvas/WebMetalDepthStencilDescriptor.cpp: Removed.
- html/canvas/WebMetalDepthStencilDescriptor.h: Removed.
- html/canvas/WebMetalDepthStencilDescriptor.idl: Removed.
- html/canvas/WebMetalDepthStencilState.cpp: Removed.
- html/canvas/WebMetalDepthStencilState.h: Removed.
- html/canvas/WebMetalDepthStencilState.idl: Removed.
- html/canvas/WebMetalDrawable.cpp: Removed.
- html/canvas/WebMetalDrawable.h: Removed.
- html/canvas/WebMetalDrawable.idl: Removed.
- html/canvas/WebMetalEnums.cpp: Removed.
- html/canvas/WebMetalEnums.h: Removed.
- html/canvas/WebMetalEnums.idl: Removed.
- html/canvas/WebMetalFunction.cpp: Removed.
- html/canvas/WebMetalFunction.h: Removed.
- html/canvas/WebMetalFunction.idl: Removed.
- html/canvas/WebMetalLibrary.cpp: Removed.
- html/canvas/WebMetalLibrary.h: Removed.
- html/canvas/WebMetalLibrary.idl: Removed.
- html/canvas/WebMetalRenderCommandEncoder.cpp: Removed.
- html/canvas/WebMetalRenderCommandEncoder.h: Removed.
- html/canvas/WebMetalRenderCommandEncoder.idl: Removed.
- html/canvas/WebMetalRenderPassAttachmentDescriptor.cpp: Removed.
- html/canvas/WebMetalRenderPassAttachmentDescriptor.h: Removed.
- html/canvas/WebMetalRenderPassAttachmentDescriptor.idl: Removed.
- html/canvas/WebMetalRenderPassColorAttachmentDescriptor.cpp: Removed.
- html/canvas/WebMetalRenderPassColorAttachmentDescriptor.h: Removed.
- html/canvas/WebMetalRenderPassColorAttachmentDescriptor.idl: Removed.
- html/canvas/WebMetalRenderPassDepthAttachmentDescriptor.cpp: Removed.
- html/canvas/WebMetalRenderPassDepthAttachmentDescriptor.h: Removed.
- html/canvas/WebMetalRenderPassDepthAttachmentDescriptor.idl: Removed.
- html/canvas/WebMetalRenderPassDescriptor.cpp: Removed.
- html/canvas/WebMetalRenderPassDescriptor.h: Removed.
- html/canvas/WebMetalRenderPassDescriptor.idl: Removed.
- html/canvas/WebMetalRenderPipelineColorAttachmentDescriptor.cpp: Removed.
- html/canvas/WebMetalRenderPipelineColorAttachmentDescriptor.h: Removed.
- html/canvas/WebMetalRenderPipelineColorAttachmentDescriptor.idl: Removed.
- html/canvas/WebMetalRenderPipelineDescriptor.cpp: Removed.
- html/canvas/WebMetalRenderPipelineDescriptor.h: Removed.
- html/canvas/WebMetalRenderPipelineDescriptor.idl: Removed.
- html/canvas/WebMetalRenderPipelineState.cpp: Removed.
- html/canvas/WebMetalRenderPipelineState.h: Removed.
- html/canvas/WebMetalRenderPipelineState.idl: Removed.
- html/canvas/WebMetalRenderingContext.cpp: Removed.
- html/canvas/WebMetalRenderingContext.h: Removed.
- html/canvas/WebMetalRenderingContext.idl: Removed.
- html/canvas/WebMetalSize.h: Removed.
- html/canvas/WebMetalSize.idl: Removed.
- html/canvas/WebMetalTexture.cpp: Removed.
- html/canvas/WebMetalTexture.h: Removed.
- html/canvas/WebMetalTexture.idl: Removed.
- html/canvas/WebMetalTextureDescriptor.cpp: Removed.
- html/canvas/WebMetalTextureDescriptor.h: Removed.
- html/canvas/WebMetalTextureDescriptor.idl: Removed.
- inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::buildObjectForCanvas):
- inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::requestContent):
(WebCore::contextAsScriptValue):
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebMetalEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webMetalEnabled const): Deleted.
- platform/Logging.h:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::layerTypeForPlatformLayer):
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
- platform/graphics/cocoa/WebMetalLayer.h: Removed.
- platform/graphics/cocoa/WebMetalLayer.mm: Removed.
- platform/graphics/gpu/legacy/GPULegacyBuffer.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyBuffer.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyCommandBuffer.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyCommandBuffer.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyCommandQueue.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyCommandQueue.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyComputeCommandEncoder.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyComputeCommandEncoder.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyComputePipelineState.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyComputePipelineState.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyDepthStencilDescriptor.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyDepthStencilDescriptor.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyDepthStencilState.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyDepthStencilState.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyDevice.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyDevice.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyDrawable.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyDrawable.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyEnums.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyFunction.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyFunction.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyLibrary.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyLibrary.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderCommandEncoder.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderCommandEncoder.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPassAttachmentDescriptor.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPassAttachmentDescriptor.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPassColorAttachmentDescriptor.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPassColorAttachmentDescriptor.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPassDepthAttachmentDescriptor.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPassDepthAttachmentDescriptor.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPassDescriptor.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPassDescriptor.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPipelineColorAttachmentDescriptor.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPipelineColorAttachmentDescriptor.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPipelineDescriptor.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPipelineDescriptor.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPipelineState.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyRenderPipelineState.h: Removed.
- platform/graphics/gpu/legacy/GPULegacySize.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyTexture.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyTexture.h: Removed.
- platform/graphics/gpu/legacy/GPULegacyTextureDescriptor.cpp: Removed.
- platform/graphics/gpu/legacy/GPULegacyTextureDescriptor.h: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyBufferMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyCommandBufferMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyCommandQueueMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyComputeCommandEncoderMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyComputePipelineStateMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyDepthStencilDescriptorMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyDepthStencilStateMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyDeviceMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyDrawableMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyFunctionMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyLibraryMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyRenderCommandEncoderMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPassAttachmentDescriptorMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPassColorAttachmentDescriptorMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPassDepthAttachmentDescriptorMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPassDescriptorMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPipelineColorAttachmentDescriptorMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPipelineDescriptorMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyRenderPipelineStateMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyTextureDescriptorMetal.mm: Removed.
- platform/graphics/gpu/legacy/cocoa/GPULegacyTextureMetal.mm: Removed.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setWebMetalEnabled): Deleted.
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebInspectorUI:
- UserInterface/Models/Canvas.js:
(WI.Canvas.fromPayload):
(WI.Canvas.displayNameForContextType):
- UserInterface/Protocol/Legacy/12.2/InspectorBackendCommands.js:
- Versions/Inspector-iOS-12.2.json:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
- Shared/WebPreferences.yaml:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences webMetalEnabled]): Deleted.
(-[WebPreferences setWebMetalEnabled:]): Deleted.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
- TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
- TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
- TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
- TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
- TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
- TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setWebMetalEnabled): Deleted.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
LayoutTests:
- fast/canvas/webmetal/webmetal-dispatch-expected.txt: Removed.
- fast/canvas/webmetal/webmetal-dispatch.html: Removed.
- fast/canvas/webmetal/webmetal-runtime-flag-expected.txt: Removed.
- fast/canvas/webmetal/webmetal-runtime-flag.html: Removed.
- inspector/canvas/create-context-webmetal-expected.txt: Removed.
- inspector/canvas/create-context-webmetal.html: Removed.
- inspector/canvas/resolveCanvasContext-webmetal-expected.txt: Removed.
- inspector/canvas/resolveCanvasContext-webmetal.html: Removed.
- platform/gtk/TestExpectations:
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wpe/TestExpectations:
- 2:53 PM Changeset in webkit [243665] by
-
- 3 edits1 add in trunk
Assertion failed in JSC::createError
https://bugs.webkit.org/show_bug.cgi?id=196305
<rdar://problem/49387382>
Reviewed by Saam Barati.
JSTests:
- stress/create-error-out-of-memory-rope-string-2.js: Added.
(assert):
(catch):
Source/JavaScriptCore:
JSC::createError assumes that
errorDescriptionForValuewill either
throw an exception or return a valid description string. However, that
is not true if the value is a rope string and we successfully resolve it,
but later fail to wrap the string in quotes withtryMakeString.
- runtime/ExceptionHelpers.cpp:
(JSC::createError):
- 2:52 PM Changeset in webkit [243664] by
-
- 27 edits2 adds in trunk/LayoutTests
Update the CSS Text WPT test suite
https://bugs.webkit.org/show_bug.cgi?id=196397
Reviewed by Manuel Rego Casasnovas.
Updated several tests from the CSS Text test suite.
- resources/resource-files.json:
- web-platform-tests/css/css-text/META.yml:
- web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-006.html:
- web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-007.html:
- web-platform-tests/css/css-text/white-space/break-spaces-004.html:
- web-platform-tests/css/css-text/white-space/break-spaces-005.html:
- web-platform-tests/css/css-text/white-space/break-spaces-006.html:
- web-platform-tests/css/css-text/white-space/break-spaces-007.html:
- web-platform-tests/css/css-text/white-space/break-spaces-008.html:
- web-platform-tests/css/css-text/white-space/pre-wrap-008.html:
- web-platform-tests/css/css-text/white-space/pre-wrap-015.html:
- web-platform-tests/css/css-text/white-space/pre-wrap-016.html:
- web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-001-expected.html:
- web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-001.html:
- web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-002-expected.html:
- web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-002.html:
- web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-003-expected.html:
- web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-003.html:
- web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-004-expected.html:
- web-platform-tests/css/css-text/white-space/white-space-intrinsic-size-004.html:
- web-platform-tests/css/css-text/word-break/w3c-import.log:
- web-platform-tests/css/css-text/word-break/word-break-break-all-010.html:
- web-platform-tests/css/css-text/word-break/word-break-break-all-011.html:
- web-platform-tests/css/css-text/word-break/word-break-break-all-012.html:
- web-platform-tests/css/css-text/word-break/word-break-break-all-013.html:
- web-platform-tests/css/css-text/word-break/word-break-break-all-015.html:
- web-platform-tests/css/css-text/word-break/word-break-break-word-overflow-wrap-interactions-expected.html: Added.
- web-platform-tests/css/css-text/word-break/word-break-break-word-overflow-wrap-interactions.html: Added.
- 2:49 PM Changeset in webkit [243663] by
-
- 6 edits in trunk/Source
Web Inspector: add fast returns for instrumentation hooks that have no affect before a frontend is connected
https://bugs.webkit.org/show_bug.cgi?id=196382
<rdar://problem/49403417>
Reviewed by Joseph Pecoraro.
Ensure that all instrumentation hooks use
FAST_RETURN_IF_NO_FRONTENDSor check that
developerExtrasEnabled. There should be no activity to/from any inspector objects until
developer extras are enabled.
Source/JavaScriptCore:
- inspector/agents/InspectorConsoleAgent.cpp:
(Inspector::InspectorConsoleAgent::startTiming):
(Inspector::InspectorConsoleAgent::stopTiming):
(Inspector::InspectorConsoleAgent::count):
(Inspector::InspectorConsoleAgent::addConsoleMessage):
Source/WebCore:
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
(WebCore::InspectorInstrumentation::scriptExecutionBlockedByCSP):
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
(WebCore::InspectorInstrumentation::frameDetachedFromParent):
(WebCore::InspectorInstrumentation::loaderDetachedFromFrame):
(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameWindowDiscardedImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::consoleCountImpl):
(WebCore::InspectorInstrumentation::startConsoleTimingImpl):
(WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
- inspector/agents/WebConsoleAgent.cpp:
(WebCore::WebConsoleAgent::frameWindowDiscarded):
- 1:56 PM Changeset in webkit [243662] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Storage: some cookie column headers are not localized
https://bugs.webkit.org/show_bug.cgi?id=196406
<rdar://problem/48467422>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/CookieStorageContentView.js:
(WI.CookieStorageContentView.prototype.initialLayout):
- Localizations/en.lproj/localizedStrings.js:
- 1:46 PM Changeset in webkit [243661] by
-
- 6 edits in trunk
Set window.closed immediately when close() is invoked
https://bugs.webkit.org/show_bug.cgi?id=195409
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/html/browsers/the-window-object/close-method.window-expected.txt:
- web-platform-tests/html/browsers/the-window-object/closed-attribute.window-expected.txt:
Source/WebCore:
Window.closed should return true if it is closing:
Window.close() sets the 'is closing' flag to true synchronously, as per:
No new tests, rebaselined existing tests.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::closed const):
- 1:26 PM Changeset in webkit [243660] by
-
- 3 edits2 adds in trunk
[Simple line layout] Turn off inline boxtree generation for multiline content
https://bugs.webkit.org/show_bug.cgi?id=196404
<rdar://problem/49234033>
Reviewed by Simon Fraser.
Source/WebCore:
Currently simple line layout can't provide the correct line breaking context to the inline tree when the boxtree is
generated using the simple line runs. This patch limits the generation of such trees to single lines. Multiline content will
go through the "let's layout this content again" codepath.
This patch fixes disappearing content on Questar.
Test: fast/text/simple-line-layout-and-multiline-inlineboxtree.html
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::canUseForLineBoxTree):
LayoutTests:
- fast/text/simple-line-layout-and-multiline-inlineboxtree-expected.html: Added.
- fast/text/simple-line-layout-and-multiline-inlineboxtree.html: Added.
- 1:23 PM Changeset in webkit [243659] by
-
- 3 edits in trunk/LayoutTests
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-stop.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196403
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations: Updating test expectations for flaky test
- 1:18 PM Changeset in webkit [243658] by
-
- 20 edits in trunk/Source/WebCore
[Web GPU] Replace unsigned longs in WebGPU with uint64_t
https://bugs.webkit.org/show_bug.cgi?id=196401
Reviewed by Myles C. Maxfield.
Unsigned long is not guaranteed to be 64 bits on all platforms. In addition, rowPitch is updated
to u32 in the API and the implementation to match.
No new tests. No new behavior.
- Modules/webgpu/WebGPUBuffer.cpp:
(WebCore::WebGPUBuffer::setSubData):
- Modules/webgpu/WebGPUBuffer.h:
- Modules/webgpu/WebGPUBufferBinding.h:
- Modules/webgpu/WebGPUCommandEncoder.cpp:
(WebCore::WebGPUCommandEncoder::copyBufferToBuffer):
- Modules/webgpu/WebGPUCommandEncoder.h:
- Modules/webgpu/WebGPUCommandEncoder.idl:
- Modules/webgpu/WebGPURenderPassEncoder.cpp:
(WebCore::WebGPURenderPassEncoder::setVertexBuffers):
- Modules/webgpu/WebGPURenderPassEncoder.h:
- platform/graphics/gpu/GPUBindGroupLayout.h:
- platform/graphics/gpu/GPUBuffer.h:
(WebCore::GPUBuffer::byteLength const):
- platform/graphics/gpu/GPUBufferBinding.h:
- platform/graphics/gpu/GPUBufferDescriptor.h:
- platform/graphics/gpu/GPUCommandBuffer.h:
- platform/graphics/gpu/GPURenderPassEncoder.h:
- platform/graphics/gpu/GPUVertexAttributeDescriptor.h:
- platform/graphics/gpu/GPUVertexInputDescriptor.h:
- platform/graphics/gpu/cocoa/GPUBufferMetal.mm:
(WebCore::GPUBuffer::GPUBuffer):
(WebCore::GPUBuffer::setSubData):
- platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm:
(WebCore::GPUCommandBuffer::copyBufferToBuffer):
- platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:
(WebCore::GPURenderPassEncoder::setVertexBuffers):
- 1:11 PM Changeset in webkit [243657] by
-
- 7 edits in trunk
REGRESSION (r243523): Six form-related watchOS layout tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=196405
<rdar://problem/49428130>
Reviewed by Wenson Hsieh.
Tools:
Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
the popover presentation methods to be no-ops. Use this in the new test added in
r243523 so that we do not swizzle those methods for all tests. This is needed because
those WatchOS tests rely on the popover getting presented and interactive.
- WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformInitialize):
(WTR::TestController::platformResetStateToConsistentValues):
LayoutTests:
- fast/forms/ios/file-upload-panel.html:
- 1:09 PM Changeset in webkit [243656] by
-
- 3 edits2 adds in trunk
REGRESSION (r243250): Text interactions are no longer suppressed when editing in some websites
https://bugs.webkit.org/show_bug.cgi?id=196378
<rdar://problem/49231299>
Reviewed by Simon Fraser.
Source/WebCore:
Enabling async overflow scrolling by default in r243250 exposed an issue with hidden editable area detection
heuristics. Currently, an empty value for RenderLayer::selfClipRect is used to determine whether the layer
enclosing the editable element or form control is completely clipped by a parent (in other words, the clip rect
is empty). With async overflow scrolling, the enclosing layer of the editable element (as seen in the websites
affected by this bug) will now be a clipping root for painting, since it is composited. This means selfClipRect
returns a non-empty rect despite the layer being entirely clipped, which negates the heuristic.
To address this, we adjust the clipping heuristic to instead walk up the layer tree (crossing frame boundaries)
and look for enclosing ancestors with overflow clip. For each layer we find with an overflow clip, compute the
clip rect of the previous layer relative to the ancestor with overflow clip. If the clipping rect is empty, we
know that the layer is hidden.
This isn't a perfect strategy, since it may still report false negatives (reporting a layer as visible when it
is not) in some cases. One such edge case is a series of overflow hidden containers, nested in such a way that
each container is only partially clipped relative to its ancestor, but the deepest layer is completely clipped
relative to the topmost layer. However, this heuristic is relatively cheap (entailing a layer tree walk at
worst) and works for common use cases on the web without risking scenarios in which text selection that
shouldn't be suppressed ends up becoming suppressed.
Test: editing/selection/ios/hide-selection-in-textarea-with-transform.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::isTransparentOrFullyClippedRespectingParentFrames const):
LayoutTests:
Add a new layout test to exercise the scenario in which a transformed textarea is hidden inside an empty
overflow: hidden container.
- editing/selection/ios/hide-selection-in-textarea-with-transform-expected.txt: Added.
- editing/selection/ios/hide-selection-in-textarea-with-transform.html: Added.
- 1:00 PM Changeset in webkit [243655] by
-
- 7 edits in trunk/LayoutTests
Unreviewed test gardening for imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm
https://bugs.webkit.org/show_bug.cgi?id=159724
<rdar://problem/48116418>
- TestExpectations:
- platform/ios-wk1/TestExpectations:
- platform/ios-wk2/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- platform/wpe/TestExpectations:
This test asserts on Cocoa WebKitLegacy platforms. A patch I uploaded to https://bugs.webkit.org/show_bug.cgi?id=159724 shows why we do not intend to fix this.
This test crashes on iOS12 and Mojave because of rdar://problem/28233746
This test should not crash anywhere else, but it is flaky in WebKit and Gecko. This is being taken care of in https://github.com/w3c/web-platform-tests/issues/8191
Updated test expectations to reflect the sad state of things.
- 12:03 PM Changeset in webkit [243654] by
-
- 20 edits in trunk
[Curl] Add Server Trust Evaluation Support.
https://bugs.webkit.org/show_bug.cgi?id=191646
Patch by Takashi Komori <Takashi.Komori@sony.com> on 2019-03-29
Reviewed by Fujii Hironori.
Source/WebCore:
Tests: http/tests/ssl/iframe-upgrade.https.html
http/tests/ssl/mixedContent/insecure-websocket.html
http/tests/ssl/upgrade-origin-usage.html
- platform/network/curl/AuthenticationChallenge.h:
- platform/network/curl/AuthenticationChallengeCurl.cpp:
(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::AuthenticationChallenge::protectionSpaceForPasswordBased):
(WebCore::AuthenticationChallenge::protectionSpaceForServerTrust):
(WebCore::AuthenticationChallenge::protectionSpaceFromHandle): Deleted.
- platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::disableServerTrustEvaluation):
- platform/network/curl/CurlContext.h:
- platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::setupTransfer):
- platform/network/curl/CurlRequest.h:
(WebCore::CurlRequest::disableServerTrustEvaluation):
Source/WebKit:
Tests: http/tests/ssl/iframe-upgrade.https.html
http/tests/ssl/mixedContent/insecure-websocket.html
http/tests/ssl/upgrade-origin-usage.html
- NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::curlDidFailWithError):
(WebKit::NetworkDataTaskCurl::tryServerTrustEvaluation):
(WebKit::NetworkDataTaskCurl::restartWithCredential):
- NetworkProcess/curl/NetworkDataTaskCurl.h:
Tools:
Implemented MiniBrowser UI for asking if user trusts the server.
- MiniBrowser/win/Common.cpp:
(askServerTrustEvaluation):
(replaceString):
- MiniBrowser/win/Common.h:
- MiniBrowser/win/MiniBrowserLib.rc:
- MiniBrowser/win/MiniBrowserLibResource.h:
- MiniBrowser/win/WebKitBrowserWindow.cpp:
(createPEMString):
(WebKitBrowserWindow::didReceiveAuthenticationChallenge):
(WebKitBrowserWindow::canTrustServerCertificate):
- MiniBrowser/win/WebKitBrowserWindow.h:
LayoutTests:
- platform/wincairo-wk1/TestExpectations:
- platform/wincairo/TestExpectations:
- 11:39 AM Changeset in webkit [243653] by
-
- 3 edits2 adds in trunk
Pasting a table from Confluence strip of table cell content
https://bugs.webkit.org/show_bug.cgi?id=196390
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was ultimately caused by FrameView of the document we use to sanitize the pasteboard content
having 0px by 0px dimension. This caused div withoverflow-x: autosurrounding a table to have
the height of 0px. Because StyledMarkupAccumulator::renderedTextRespectingRange uses TextIterator
to serialize a text node and this div was an ancestor of the text node, TextIterator::handleTextNode
ended up exiting early.
Fixed the bug by giving FrameView, which is used to sanitize the content, a dimension of 800px by 600px.
Using TextIteratorIgnoresStyleVisibility is not a great alternative since removing invisible content
during paste is an important privacy feature.
Test: editing/pasteboard/paste-content-with-overflow-auto-parent-across-origin.html
- editing/markup.cpp:
(WebCore::createPageForSanitizingWebContent):
LayoutTests:
Added a regression test.
- editing/pasteboard/paste-content-with-overflow-auto-parent-across-origin-expected.txt: Added.
- editing/pasteboard/paste-content-with-overflow-auto-parent-across-origin.html: Added.
- 11:36 AM Changeset in webkit [243652] by
-
- 2 edits in trunk/LayoutTests
fast/mediastream/MediaStreamTrack-getSettings.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=196400
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations: Updating test expectations for flaky failure
- 11:36 AM Changeset in webkit [243651] by
-
- 2 edits in tags/Safari-608.1.13.3/Source/WebKit
Cherry-pick r243640. rdar://problem/49339242
CFDictionary encoder crashes on non-string keys.
https://bugs.webkit.org/show_bug.cgi?id=196388
rdar://problem/49339242
Reviewed by Ryosuke Niwa.
Allow non-string keys in CFDictionary encoding/decoding. Encode the correct
size for dictionaries and arrays when unknown keys or values are skipped.
Allow null array encoding and decoding like dictionary already allowed.
- Shared/cf/ArgumentCodersCF.cpp: (IPC::encode): (IPC::decode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:33 AM Changeset in webkit [243650] by
-
- 7 edits in tags/Safari-608.1.13.3/Source
Versioning.
- 11:29 AM Changeset in webkit [243649] by
-
- 1 copy in tags/Safari-608.1.13.3
New tag.
- 10:44 AM Changeset in webkit [243648] by
-
- 3 edits in trunk/Source/WebCore
WebKitTestRunner crashes when running pointerevents/ios/touch-action-none-in-overflow-scrolling-touch.html
https://bugs.webkit.org/show_bug.cgi?id=196345
Patch by Antoine Quint <Antoine Quint> on 2019-03-29
Reviewed by Dean Jackson.
An enum used within a WTF::OptionSet needs to have only power-of-two values that are larger than 0.
- platform/TouchAction.h:
- rendering/style/StyleRareNonInheritedData.h:
- 9:11 AM Changeset in webkit [243647] by
-
- 3 edits2 adds in trunk
HTMLInputElement::setEditingValue should not fail if renderer doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=195708
Reviewed by Wenson Hsieh.
Source/WebCore:
HTMLInputElement::setEditingValue currently returns early if the element's renderer() is
null. This is causing the Epiphany password manager to fail to remember passwords on
https://www.geico.com/ except for navigations through page cache.
This check was originally added to avoid some assertion, but I don't know which one, and
there's definitely not any assertion hit nowadays in this case. Probably there are more
guards checking if renderer() is null elsewhere in the code nowadays, closer to where it's
really needed.
Test: fast/forms/editing-value-null-renderer.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setEditingValue):
LayoutTests:
This is a copy of fast/forms/editing-value.html, except the form is not displayed. The input
value should still change.
- fast/forms/editing-value-null-renderer-expected.txt: Added.
- fast/forms/editing-value-null-renderer.html: Added.
- 8:56 AM Changeset in webkit [243646] by
-
- 5 edits in trunk
Unreviewed, rebaseline WPT test after r243638.
LayoutTests/imported/w3c:
- web-platform-tests/html/browsers/the-window-object/named-access-on-the-window-object/navigated-named-objects.window-expected.txt:
Source/WebCore:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- 8:54 AM Changeset in webkit [243645] by
-
- 8 edits2 adds in trunk
All PointerEvent.isTrusted is always false.
https://bugs.webkit.org/show_bug.cgi?id=196075
<rdar://problem/49158778>
Reviewed by Chris Dumez.
Source/WebCore:
Test: pointerevents/ios/pointer-events-is-trusted.html
The constructors we were using for some PointerEvent::create() methods were using initializers which are expected to be used with JS APIs
and thus generate untrusted events. We switch to using constructors using dedicated parameters which will set isTrusted to true.
- dom/PointerEvent.cpp:
(WebCore::PointerEvent::create):
(WebCore::PointerEvent::createPointerCancelEvent):
(WebCore::PointerEvent::PointerEvent):
(WebCore::m_isPrimary):
(WebCore::m_pointerType):
- dom/PointerEvent.h:
- page/PointerCaptureController.cpp:
(WebCore::PointerCaptureController::cancelPointer):
LayoutTests:
Add tests to the macOS and iOS series of tests that check that isTrusted is indeed true. This uncovered a couple of issues with how some tests were written.
- pointerevents/ios/pointer-events-is-primary.html: Ensure we end both touches so that further tests run cleanly.
- pointerevents/ios/pointer-events-is-trusted-expected.txt: Added.
- pointerevents/ios/pointer-events-is-trusted.html: Added.
- pointerevents/mouse/pointer-event-basic-properties.html: Ensure we wait for the event to be handled before finishing the test.
- pointerevents/utils.js:
(prototype._handlePointerEvent):
- 3:43 AM Changeset in webkit [243644] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] imxvpudecoder detection and handling
https://bugs.webkit.org/show_bug.cgi?id=196346
Reviewed by Xabier Rodriguez-Calvar.
When the imxvpudecoder is used, the texture sampling of the
directviv-uploaded texture returns an RGB value, so there's no need
to convert it. This patch also includes a refactoring of the
ImageRotation flag handling. The flag is now computed once only
and stored in an instance variable.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamerBase::flushCurrentBuffer):
(WebCore::MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):
(WebCore::MediaPlayerPrivateGStreamerBase::setVideoSourceOrientation):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTextureMapperFlags):
(WebCore::texMapFlagFromOrientation): Deleted.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- 1:37 AM Changeset in webkit [243643] by
-
- 59 edits6 copies20 adds in trunk
Implement ResizeObserver.
https://bugs.webkit.org/show_bug.cgi?id=157743
Patch by Cathie Chen <cathiechen> on 2019-03-29
Reviewed by Simon Fraser.
.:
Add ENABLE_RESIZE_OBSERVER.
- Source/cmake/WebKitFeatures.cmake:
LayoutTests/imported/w3c:
Set ResizeObserverEnabled for test runner and update expectations.
- web-platform-tests/interfaces/ResizeObserver.idl: Added.
- web-platform-tests/resize-observer/eventloop-expected.txt:
- web-platform-tests/resize-observer/eventloop.html:
- web-platform-tests/resize-observer/idlharness.window-expected.txt:
- web-platform-tests/resize-observer/idlharness.window.html:
- web-platform-tests/resize-observer/notify-expected.txt:
- web-platform-tests/resize-observer/notify.html:
- web-platform-tests/resize-observer/observe-expected.txt:
- web-platform-tests/resize-observer/observe.html:
- web-platform-tests/resize-observer/svg-expected.txt:
- web-platform-tests/resize-observer/svg.html:
Source/JavaScriptCore:
Add ENABLE_RESIZE_OBSERVER.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Tests: resize-observer/modify-frametree-in-callback.html
resize-observer/multi-frames.html
resize-observer/observe-element-from-other-frame.html
Imported from WPT by https://bugs.webkit.org/show_bug.cgi?id=193821
The data structure: Document has a ResizeObserver slot. ResizeObserver has a ResizeObservation slot.
ResizeObservation is related to one Element and the last reported size.
On the other hand, Element has a ResizeObservation slot.
At the beginning of willDisplayPage, it will check resize observations for current page if:
- There is FrameView be layout and there are ResizeObservers in this page.
- m_resizeObserverTimer has been started by observe() or hasSkippedResizeObservers().
During checkResizeObservations(), we'll gatherDocumentsNeedingResizeObservationCheck() first,
then notifyResizeObservers() for each document. During notifyResizeObservers(), it will gather
the m_activeObservations whose size changed and target element deeper than require depth.
The size changed shallower observations are skipped observations which will be delivered
in the next time. And an ErrorEvent will be reported.
After gathering, deliverResizeObservations create entries and invoke the callbacks with them.
The Element from other document could be observed.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
- dom/Document.cpp:
(WebCore::Document::getParserLocation const):
(WebCore::Document::addResizeObserver):
(WebCore::Document::removeResizeObserver):
(WebCore::Document::hasResizeObservers):
(WebCore::Document::gatherResizeObservations): Gather m_activeObservations at depth and return the shallowest depth.
(WebCore::Document::deliverResizeObservations): Deliver m_activeObservations, generate ResizeObserverEntries, and invoke the m_callbacks.
(WebCore::Document::hasSkippedResizeObservations const): To determine if Document has the size changed but not delivered observations.
(WebCore::Document::setHasSkippedResizeObservations):
(WebCore::Document::scheduleResizeObservations):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::disconnectFromResizeObservers):
(WebCore::Element::ensureResizeObserverData):
(WebCore::Element::resizeObserverData):
- dom/Element.h:
- dom/ElementRareData.cpp:
- dom/ElementRareData.h:
(WebCore::ElementRareData::resizeObserverData):
(WebCore::ElementRareData::setResizeObserverData):
(WebCore::ElementRareData::useTypes const):
- page/FrameView.cpp:
(WebCore::FrameView::didLayout):
- page/FrameViewLayoutContext.cpp:
(WebCore::FrameViewLayoutContext::layoutTimerFired): We need to start a ResizeObserver timer here, because for WK1 this might not trigger flushCompositingChanges.
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::willDisplayPage):
(WebCore::Page::hasResizeObservers const):
(WebCore::Page::gatherDocumentsNeedingResizeObservationCheck): Gather the documents with resize observers.
(WebCore::Page::checkResizeObservations): Gather documents then notifyResizeObservers for each document.
(WebCore::Page::scheduleResizeObservations):
(WebCore::Page::notifyResizeObservers): Gather m_activeObservations and deliver them. Report ErrorEvent if it has skipped observations.
- page/Page.h:
(WebCore::Page::setNeedsCheckResizeObservations): Page needs to check ResizeObservations if FrameView layout or m_resizeObserverTimer has been started.
(WebCore::Page::needsCheckResizeObservations const):
- page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::addMessage):
(WebCore::getParserLocationForConsoleMessage): Deleted.
- page/ResizeObservation.cpp: Added.
(WebCore::ResizeObservation::create):
(WebCore::ResizeObservation::ResizeObservation):
(WebCore::ResizeObservation::~ResizeObservation):
(WebCore::ResizeObservation::updateObservationSize):
(WebCore::ResizeObservation::computeObservedSize const):
(WebCore::ResizeObservation::computeTargetLocation const):
(WebCore::ResizeObservation::computeContentRect const):
(WebCore::ResizeObservation::elementSizeChanged const):
(WebCore::ResizeObservation::targetElementDepth const):
- page/ResizeObservation.h: Copied from Tools/DumpRenderTree/TestOptions.h.
(WebCore::ResizeObservation::target const):
- page/ResizeObserver.cpp: Added.
(WebCore::ResizeObserver::create):
(WebCore::ResizeObserver::ResizeObserver):
(WebCore::ResizeObserver::~ResizeObserver):
(WebCore::ResizeObserver::scheduleObservations):
(WebCore::ResizeObserver::observe):
(WebCore::ResizeObserver::unobserve):
(WebCore::ResizeObserver::disconnect):
(WebCore::ResizeObserver::targetDestroyed):
(WebCore::ResizeObserver::gatherObservations):
(WebCore::ResizeObserver::deliverObservations):
(WebCore::ResizeObserver::removeTarget):
(WebCore::ResizeObserver::removeAllTargets):
(WebCore::ResizeObserver::removeObservation):
(WebCore::ResizeObserver::hasPendingActivity const):
(WebCore::ResizeObserver::activeDOMObjectName const):
(WebCore::ResizeObserver::canSuspendForDocumentSuspension const):
(WebCore::ResizeObserver::stop):
- page/ResizeObserver.h: Added.
(WebCore::ResizeObserver::hasObservations const):
(WebCore::ResizeObserver::hasActiveObservations const):
(WebCore::ResizeObserver::maxElementDepth):
(WebCore::ResizeObserver::hasSkippedObservations const):
(WebCore::ResizeObserver::setHasSkippedObservations):
- page/ResizeObserver.idl: Copied from Tools/DumpRenderTree/TestOptions.h.
- page/ResizeObserverCallback.h: Copied from Tools/DumpRenderTree/TestOptions.h.
- page/ResizeObserverCallback.idl: Copied from Tools/DumpRenderTree/TestOptions.h.
- page/ResizeObserverEntry.h: Copied from Tools/DumpRenderTree/TestOptions.h.
(WebCore::ResizeObserverEntry::create):
(WebCore::ResizeObserverEntry::target const):
(WebCore::ResizeObserverEntry::contentRect const):
(WebCore::ResizeObserverEntry::ResizeObserverEntry):
- page/ResizeObserverEntry.idl: Copied from Tools/DumpRenderTree/TestOptions.h.
- page/Settings.yaml:
Source/WebCore/PAL:
Add ENABLE_RESIZE_OBSERVER.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
Add WebPreferences and FeatureDefines for ResizeObserver.
- Configurations/FeatureDefines.xcconfig:
- Shared/WebPreferences.yaml:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences resizeObserverEnabled]):
(-[WebPreferences setResizeObserverEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
(-[WebView _flushCompositingChanges]): checkResizeObservations() in the begining.
Source/WebKitLegacy/win:
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::resizeObserverEnabled):
(WebPreferences::setResizeObserverEnabled):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
Support resizeObserverEnabled webPreferences.
- DumpRenderTree/TestOptions.cpp:
(TestOptions::TestOptions):
- DumpRenderTree/TestOptions.h:
- DumpRenderTree/mac/DumpRenderTree.mm:
(setWebPreferencesForTestOptions):
- DumpRenderTree/win/DumpRenderTree.cpp:
(enableExperimentalFeatures):
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
LayoutTests:
Add tests for resize-observer of multiframe.
- resize-observer/modify-frametree-in-callback-expected.txt: Added.
- resize-observer/modify-frametree-in-callback.html: Added.
- resize-observer/multi-frames-expected.txt: Added.
- resize-observer/multi-frames.html: Added.
- resize-observer/observe-element-from-other-frame-expected.txt: Added.
- resize-observer/observe-element-from-other-frame.html: Added.
- resize-observer/resources/frame1.html: Added.
- resize-observer/resources/frame2.html: Added.
- resize-observer/resources/frame3.html: Added.
- resize-observer/resources/frame4.html: Added.
- resize-observer/resources/frameset1.html: Added.
- resize-observer/resources/frameset2.html: Added.
- resize-observer/resources/iframe1.html: Added.
- resize-observer/resources/resizeTestHelper.js: Added.
(ResizeTestHelper):
(ResizeTestHelper.prototype.get _currentStep):
(ResizeTestHelper.prototype._nextStep):
(ResizeTestHelper.prototype._handleNotification):
(ResizeTestHelper.prototype._handleTimeout):
(ResizeTestHelper.prototype._done):
(ResizeTestHelper.prototype.start):
(ResizeTestHelper.prototype.get rafCount):
(ResizeTestHelper.prototype._incrementRaf):
(ResizeTestHelper.prototype.startCountingRaf):
